gdb/ChangeLog

   1 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * infcmd.c: Remove includes.
   4         * infrun.c: Remove includes.
   5
   6 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
   7
   8         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
   9         (grow_vect): Remove declaration.
  10         (ada_type_of_array): Remove declaration.
  11         (ada_update_initial_language): Remove declaration.
  12         (ada_fold_name): Remove declaration.
  13         (ada_fill_in_ada_prototype): Remove declaration.
  14         (user_select_syms): Remove declaration.
  15         (get_selections): Remove declaration.
  16         (ada_tag_type): Remove declaration.
  17         (ada_value_tag): Remove declaration.
  18         (ada_is_others_clause): Remove declaration.
  19         (ada_in_variant): Remove declaration.
  20         (ada_value_struct_elt): Remove declaration.
  21         (ada_attribute_name): Remove declaration.
  22         (ada_system_address_type): Remove declaration.
  23         * ada-lang.c (ada_watch_location_expression): Make static.
  24         (GROW_VECT): Move here from ada-lang.h.
  25         (grow_vect): Make static.
  26         (ada_update_initial_language): Make static.
  27         (ada_fold_name): Make static.
  28         (ada_type_of_array): Make static.
  29         (encoded_ordered_before): Move up.
  30         (sort_choices): Move up.
  31         (print_signatures): Move up.
  32         (ada_print_symbol_signature): Move up.
  33         (get_selections): Move up and make static.
  34         (user_select_syms): Move up and make static.
  35         (ada_value_struct_elt): Move up and make static.
  36         (ada_tag_type): Make static.
  37         (ada_value_tag): Make static.
  38         (ada_is_others_clause): Make static.
  39         (ada_in_variant): Make static.
  40         (ada_attribute_name): Make static.
  41
  42 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
  43
  44         * ada-lang.c: Remove includes.
  45         * ada-typeprint.c: Remove includes.
  46         * ada-valprint.c: Remove includes.
  47
  48 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
  49
  50         * addrmap.c: Add static assertions of type size, moved from
  51         _initialize_addrmap.
  52         (_initialize_addrmap): Remove.
  53
  54 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
  55
  56         * coffread.c (record_minimal_symbol): Update.
  57         (process_coff_symbol): Update.
  58         * dbxread.c (read_dbx_symtab): Update.
  59         * dwarf2read.c (add_partial_symbol): Update.
  60         (fixup_go_packaging): Update.
  61         (load_partial_dies): Update.
  62         (new_symbol): Update.
  63         * elfread.c (record_minimal_symbol): Change signature to use
  64         gdb::string_view instead of name+len.
  65         (elf_symtab_read): Update.
  66         (elf_rel_plt_read): Update.
  67         * mdebugread.c (parse_partial_symbols): Update.
  68         (handle_psymbol_enumerators): Update.
  69         (new_symbol): Update.
  70         * minsyms.c (minimal_symbol_reader::record_full): Change signature
  71         to use gdb::string_view instead of name+len.
  72         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
  73         * psympriv.h (add_psymbol_to_list): Likewise.
  74         * psymtab.c (add_psymbol_to_bcache): Likewise.
  75         (add_psymbol_to_list): Likewise.
  76         * stabsread.c (define_symbol): Update.
  77         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
  78         * symtab.h (SYMBOL_SET_NAMES): Likewise.
  79         (symbol_set_names): Likewise.
  80         * xcoffread.c (scan_xcoff_symtab): Update.
  81
  82 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
  83
  84         * symtab.h (symbol_set_names): Document that copy_name must be
  85         set to true for non-nullterminated strings.
  86         * symtab.c (symbol_set_names): Only make a nullterminated copy of
  87         linkage_name if the entry was not found and we need to demangle.
  88
  89 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
  90
  91         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
  92         * dwarf2-frame.c (bsearch_fde_cmp): Update.
  93         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
  94         * gdbsupport/gdb_binary_search.h: New file.
  95
  96 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
  97
  98         * NEWS: Mention new --with-system-gdbinit-dir option.
  99         * config.in: Regenerate.
 100         * configure: Regenerate.
 101         * configure.ac: Add new option --with-system-gdbinit-dir.
 102         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 103         for a ".gdb" suffix.
 104         * main.c (get_init_files): Change system_gdbinit argument to
 105         a vector and return the files in SYSTEM_GDBINIT_DIR in
 106         addition to SYSTEM_GDBINIT.
 107         (captured_main_1): Update.
 108         (print_gdb_help): Update.
 109         * top.c (print_gdb_configuration): Also print the value of
 110         SYSTEM_GDBINIT_DIR.
 111
 112 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 113
 114         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 115         that takes gdb::string_view arguments.
 116
 117 2019-10-26  Tom de Vries  <tdevries@suse.de>
 118
 119         * aarch64-linux-tdep.c: Fix typos in comments.
 120         * aarch64-tdep.c: Same.
 121         * ada-lang.c: Same.
 122         * amd64-nat.c: Same.
 123         * arc-tdep.c: Same.
 124         * arch/aarch64-insn.c: Same.
 125         * block.c: Same.
 126         * breakpoint.h: Same.
 127         * btrace.h: Same.
 128         * c-varobj.c: Same.
 129         * cli/cli-decode.c: Same.
 130         * cli/cli-script.c: Same.
 131         * cli/cli-utils.h: Same.
 132         * coff-pe-read.c: Same.
 133         * coffread.c: Same.
 134         * compile/compile-cplus-symbols.c: Same.
 135         * compile/compile-object-run.c: Same.
 136         * completer.c: Same.
 137         * corelow.c: Same.
 138         * cp-support.c: Same.
 139         * demangle.c: Same.
 140         * dwarf-index-write.c: Same.
 141         * dwarf2-frame.c: Same.
 142         * dwarf2-frame.h: Same.
 143         * eval.c: Same.
 144         * frame-base.h: Same.
 145         * frame.h: Same.
 146         * gdbcmd.h: Same.
 147         * gdbtypes.h: Same.
 148         * gnu-nat.c: Same.
 149         * guile/scm-objfile.c: Same.
 150         * i386-tdep.c: Same.
 151         * i386-tdep.h: Same.
 152         * infcall.c: Same.
 153         * infcall.h: Same.
 154         * linux-nat.c: Same.
 155         * m68k-tdep.c: Same.
 156         * macroexp.c: Same.
 157         * memattr.c: Same.
 158         * mi/mi-cmd-disas.c: Same.
 159         * mi/mi-getopt.h: Same.
 160         * mi/mi-main.c: Same.
 161         * minsyms.c: Same.
 162         * nat/aarch64-sve-linux-sigcontext.h: Same.
 163         * objfiles.h: Same.
 164         * ppc-linux-nat.c: Same.
 165         * ppc-linux-tdep.c: Same.
 166         * ppc-tdep.h: Same.
 167         * progspace.h: Same.
 168         * prologue-value.h: Same.
 169         * python/py-evtregistry.c: Same.
 170         * python/py-instruction.h: Same.
 171         * record-btrace.c: Same.
 172         * record-full.c: Same.
 173         * remote.c: Same.
 174         * rs6000-tdep.c: Same.
 175         * ser-tcp.c: Same.
 176         * sol-thread.c: Same.
 177         * sparc-sol2-tdep.c: Same.
 178         * sparc64-tdep.c: Same.
 179         * stabsread.c: Same.
 180         * symfile.c: Same.
 181         * symtab.h: Same.
 182         * target.c: Same.
 183         * tracepoint.c: Same.
 184         * tui/tui-data.h: Same.
 185         * tui/tui-io.c: Same.
 186         * tui/tui-win.c: Same.
 187         * tui/tui.c: Same.
 188         * unittests/rsp-low-selftests.c: Same.
 189         * user-regs.h: Same.
 190         * utils.c: Same.
 191         * utils.h: Same.
 192         * valarith.c: Same.
 193         * valops.c: Same.
 194         * valprint.c: Same.
 195         * valprint.h: Same.
 196         * value.c: Same.
 197         * value.h: Same.
 198         * varobj.c: Same.
 199         * x86-nat.h: Same.
 200         * xtensa-tdep.c: Same.
 201
 202 2019-10-25  Ali Tamur <tamur@google.com>
 203
 204         * charset.c (find_charset_names): Reflect API change.
 205
 206 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 207
 208         * symtab.c (struct demangled_name_entry): Change demangled name
 209         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 210         part of the struct anymore.
 211         (symbol_set_names): No longer obstack allocate + copy the demangled
 212         name, just store the allocated name from bfd.
 213
 214 2019-10-25  Tom Tromey  <tromey@adacore.com>
 215
 216         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 217         (bsearch_cie_cmp, add_cie): Remove.
 218         (find_cie): Reimplement.
 219         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 220         (dwarf2_build_frame_info): Update.
 221
 222 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 223
 224         PR gdb/25126
 225         * symfile.c (reread_symbols): Call forget_cached_source_info to
 226         clear the stale source cache.
 227
 228 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 229
 230         * configure: Regenerate.
 231         * configure.ac: Remove code that sets python_has_threads.
 232
 233 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 234
 235         * config.in: Regenerate.
 236         * configure: Regenerate.
 237         * configure.ac: Remove the code that uses sed to get the python
 238         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 239
 240 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 241
 242         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 243         error paths.
 244
 245 2019-10-23  Tom Tromey  <tom@tromey.com>
 246
 247         * arc-tdep.c: Remove ".." from include.
 248         * frv-tdep.c: Remove ".." from include.
 249         * lm32-tdep.c: Remove ".." from include.
 250         * microblaze-tdep.c: Remove ".." from include.
 251         * or1k-tdep.h: Remove ".." from include.
 252         * s12z-tdep.c: Remove ".." from include.
 253         * Makefile.in (OPCODES_CFLAGS): Add comment.
 254         (TOP_CFLAGS): New variable.
 255         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 256
 257 2019-10-23  Tom Tromey  <tom@tromey.com>
 258
 259         * Makefile.in (READLINE_DIR): Update.
 260
 261 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 262
 263         * infcall.c (call_function_by_hand_dummy): Fix the function
 264         comment.  And extract out a code section into...
 265         (reserve_stack_space): ...this new function.
 266
 267 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 268
 269         * infcall.c (value_arg_coerce): Remove an unused parameter.
 270         (call_function_by_hand_dummy): Update the call to
 271         'value_arg_coerce'.
 272
 273 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 274
 275         * infcall.c (call_function_by_hand_dummy): Refactor.
 276
 277 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 278
 279         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 280
 281 2019-10-23  Tom Tromey  <tom@tromey.com>
 282
 283         * configure: Rebuild.
 284         * configure.ac: Don't check for sigprocmask.
 285         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 286
 287 2019-10-23  Tom Tromey  <tom@tromey.com>
 288
 289         * configure: Rebuild.
 290         * acinclude.m4: Use m4_include, not sinclude.
 291
 292 2019-10-23  Tom de Vries  <tdevries@suse.de>
 293
 294         PR breakpoints/24687
 295         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 296
 297 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 298
 299         * symtab.c (struct demangled_name_entry) <language>: Change from
 300         bitfield to regular variable.
 301
 302 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 303
 304         * symtab.c (struct demangled_name_entry): Add a constructor.
 305         (free_demangled_name_entry): New function to call the destructor
 306         for demangled_name_entry.
 307         (create_demangled_names_hash): Pass free_demangled_name_entry to
 308         htab_create_alloc.
 309         (symbol_set_names): Call placement new for demangled_name_entry.
 310         * utils.c: No longer include xxhash.h here, now that fast_hash
 311         is inlined in the header.
 312         * utils.h: Instead, include it here.
 313
 314 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 315
 316         * Makefile.in: Link with libxxhash.
 317         * config.in: Regenerate.
 318         * configure: Regenerate.
 319         * configure.ac: Search for libxxhash.
 320         * utils.c (fast_hash): Use xxhash if present.
 321
 322 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 323
 324         * utils.h (fast_hash): New function.
 325         * symtab.c (hash_demangled_name_entry): Call new function
 326         fast_hash.
 327
 328 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 329
 330         * symtab.c (struct demangled_name_entry): Change type of mangled
 331         to gdb::string_view. Also adds a constructor that takes the
 332         mangled name.
 333         (hash_demangled_name_entry): Update.
 334         (eq_demangled_name_entry): Update.
 335         (free_demangled_name_entry): New function to call the destructor
 336         now that this is not a POD anymore.
 337         (create_demangled_names_hash): Pass free_demangled_name_entry to
 338         htab_create_alloc.
 339         (symbol_set_names): Update.
 340
 341 2019-10-21  Ali Tamur  <tamu@google.com>
 342
 343         * dwarf2read.c (dir_index): Change type.
 344         (file_name_index): Likewise.
 345         (line_header::include_dir_at): Change comment and implementation on
 346         whether it is DWARF 5.
 347         (line_header::is_valid_file_index): New function.
 348         (line_header::file_name_at): Change comment and implementation on
 349         whether it is DWARF 5.
 350         (line_header::file_names): Change to private field renamed as
 351         m_file_names and introduce a new accessor method.
 352         (line_header::file_names_size): New method.
 353         (line_header::include_dirs): Change to private field and rename as
 354         m_include_dirs.
 355         (dw2_get_file_names_reader): Define local var at a smaller scope and
 356         reflect API change.
 357         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 358         (process_structure_scope): Likewise.
 359         (line_header::add_include_dir): Change message and reflect renaming.
 360         (line_header::add_file_name): Likewise.
 361         (read_formatted_entries): Handle DW_FORM_data16.
 362         (dwarf_decode_line_header): Fix line header length calculation.
 363         (psymtab_include_file_name): Change comment and API.
 364         (lnp_state_machine::m_file): Update comment and reflect type change.
 365         (lnp_state_machine::record_line): Reflect type change.
 366         (dwarf_decode_lines): Reflect API change.
 367         (file_file_name): Likewise.
 368         (file_full_name): Likewise.
 369
 370 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 371
 372         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 373
 374 2019-10-21  Tom Tromey  <tom@tromey.com>
 375
 376         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 377
 378 2019-10-21  Tom Tromey  <tom@tromey.com>
 379
 380         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 381         NM_H.   Use AC_CONFIG_LINKS.
 382         * configure: Rebuild.
 383         * Makefile.in (NM_H): New variable.
 384         (generated_files): Add NM_H.  Remove gcore.
 385         (nm.h, stamp-nmh): New targets.
 386
 387 2019-10-20  Tom Tromey  <tom@tromey.com>
 388
 389         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 390         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 391         obsolete comment.
 392         (put_objfile_before): Now static.
 393
 394 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 395
 396         * gdbsupport/common-utils.h (startswith): Change return type to
 397         bool.
 398
 399 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 400
 401         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 402         * breakpoint.c (bp_locations_compare): Rename to...
 403         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 404         (update_global_location_list): Use std::sort instead of qsort.
 405         * buildsym.c (compare_line_numbers): Rename to...
 406         (lte_is_less_than): ...this, and change to std::sort semantics.
 407         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 408         instead of qsort.
 409         * disasm.c (compare_lines): Rename to...
 410         (line_is_less_than): ...this, and change to std::sort semantics.
 411         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 412         of qsort.
 413         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 414         (fde_is_less_than): ...this, and change to std::sort semantics.
 415         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 416         * mdebugread.c (compare_blocks):
 417         (block_is_less_than): ...this, and change to std::sort semantics.
 418         (sort_blocks): Call std::sort instead of qsort.
 419         * objfiles.c (qsort_cmp): Rename to...
 420         (sort_cmp): ...this, and change to std::sort semantics.
 421         (update_section_map): Call std::sort instead of qsort.
 422         * remote.c (compare_pnums): Remove.
 423         (map_regcache_remote_table): Call std::sort instead of qsort.
 424         * utils.c (compare_positive_ints): Remove.
 425         * utils.h (compare_positive_ints): Remove.
 426         * xcoffread.c (compare_lte): Remove.
 427         (arrange_linetable): Call std::sort instead of qsort.
 428
 429 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 430
 431         * symfile.c (init_entry_point_info): Fix typo.
 432         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 433
 434 2019-10-18  Tom de Vries  <tdevries@suse.de>
 435
 436         * aarch64-tdep.c: Fix typos in comments.
 437         * ada-lang.c: Same.
 438         * ada-tasks.c: Same.
 439         * alpha-tdep.c: Same.
 440         * alpha-tdep.h: Same.
 441         * amd64-nat.c: Same.
 442         * amd64-windows-tdep.c: Same.
 443         * arc-tdep.c: Same.
 444         * arc-tdep.h: Same.
 445         * arch-utils.c: Same.
 446         * arm-nbsd-tdep.c: Same.
 447         * arm-tdep.c: Same.
 448         * ax-gdb.c: Same.
 449         * blockframe.c: Same.
 450         * btrace.c: Same.
 451         * c-varobj.c: Same.
 452         * coff-pe-read.c: Same.
 453         * coffread.c: Same.
 454         * cris-tdep.c: Same.
 455         * darwin-nat.c: Same.
 456         * dbxread.c: Same.
 457         * dcache.c: Same.
 458         * disasm.c: Same.
 459         * dtrace-probe.c: Same.
 460         * dwarf-index-write.c: Same.
 461         * dwarf2-frame-tailcall.c: Same.
 462         * dwarf2-frame.c: Same.
 463         * dwarf2read.c: Same.
 464         * eval.c: Same.
 465         * exceptions.c: Same.
 466         * fbsd-tdep.c: Same.
 467         * findvar.c: Same.
 468         * frame.c: Same.
 469         * frv-tdep.c: Same.
 470         * gnu-v3-abi.c: Same.
 471         * go32-nat.c: Same.
 472         * h8300-tdep.c: Same.
 473         * hppa-tdep.c: Same.
 474         * i386-linux-tdep.c: Same.
 475         * i386-tdep.c: Same.
 476         * ia64-libunwind-tdep.c: Same.
 477         * ia64-tdep.c: Same.
 478         * infcmd.c: Same.
 479         * infrun.c: Same.
 480         * linespec.c: Same.
 481         * linux-nat.c: Same.
 482         * linux-thread-db.c: Same.
 483         * machoread.c: Same.
 484         * mdebugread.c: Same.
 485         * mep-tdep.c: Same.
 486         * mn10300-tdep.c: Same.
 487         * namespace.c: Same.
 488         * objfiles.c: Same.
 489         * opencl-lang.c: Same.
 490         * or1k-tdep.c: Same.
 491         * osabi.c: Same.
 492         * ppc-linux-nat.c: Same.
 493         * ppc-linux-tdep.c: Same.
 494         * ppc-sysv-tdep.c: Same.
 495         * printcmd.c: Same.
 496         * procfs.c: Same.
 497         * record-btrace.c: Same.
 498         * record-full.c: Same.
 499         * remote-fileio.c: Same.
 500         * remote.c: Same.
 501         * rs6000-tdep.c: Same.
 502         * s12z-tdep.c: Same.
 503         * score-tdep.c: Same.
 504         * ser-base.c: Same.
 505         * ser-go32.c: Same.
 506         * skip.c: Same.
 507         * sol-thread.c: Same.
 508         * solib-svr4.c: Same.
 509         * solib.c: Same.
 510         * source.c: Same.
 511         * sparc-nat.c: Same.
 512         * sparc-sol2-tdep.c: Same.
 513         * sparc-tdep.c: Same.
 514         * sparc64-tdep.c: Same.
 515         * stabsread.c: Same.
 516         * stack.c: Same.
 517         * symfile.c: Same.
 518         * symtab.c: Same.
 519         * target-descriptions.c: Same.
 520         * target-float.c: Same.
 521         * thread.c: Same.
 522         * utils.c: Same.
 523         * valops.c: Same.
 524         * valprint.c: Same.
 525         * value.c: Same.
 526         * varobj.c: Same.
 527         * windows-nat.c: Same.
 528         * xcoffread.c: Same.
 529         * xstormy16-tdep.c: Same.
 530         * xtensa-tdep.c: Same.
 531
 532 2019-10-17  Tom Tromey  <tromey@adacore.com>
 533
 534         * configure: Rebuild.
 535         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 536         in AC_CONFIG_FILES invocation.
 537         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 538         new-style config.status invocation.
 539
 540 2019-10-17  Tom de Vries  <tdevries@suse.de>
 541
 542         * arm-nbsd-nat.c: Fix typos in comments.
 543         * arm-tdep.c: Same.
 544         * darwin-nat-info.c: Same.
 545         * dwarf2read.c: Same.
 546         * elfread.c: Same.
 547         * event-top.c: Same.
 548         * findvar.c: Same.
 549         * gdbtypes.c: Same.
 550         * hppa-tdep.c: Same.
 551         * i386-tdep.c: Same.
 552         * jit.c: Same.
 553         * main.c: Same.
 554         * mdebugread.c: Same.
 555         * moxie-tdep.c: Same.
 556         * nto-procfs.c: Same.
 557         * osabi.c: Same.
 558         * ppc-linux-tdep.c: Same.
 559         * remote.c: Same.
 560         * riscv-tdep.c: Same.
 561         * s390-tdep.c: Same.
 562         * sh-tdep.c: Same.
 563         * sparc-linux-tdep.c: Same.
 564         * sparc-nat.c: Same.
 565         * stack.c: Same.
 566         * target-descriptions.c: Same.
 567         * top.c: Same.
 568         * varobj.c: Same.
 569
 570 2019-10-16  Tom Tromey  <tom@tromey.com>
 571
 572         * objfiles.h (struct objfile) <original_name>: Now const.
 573
 574 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 575
 576         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 577         pass on to sigsetjmp's second argument.
 578         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 579
 580 2019-10-16  Keith Seitz  <keiths@redhat.com>
 581
 582         PR gdb/23567
 583         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 584         sections whose size is greater than the file size.
 585
 586 2019-10-16  Jim Wilson  <jimw@sifive.com>
 587
 588         * riscv-tdep.c (riscv_gcc_target_options): New.
 589         (riscv_gnu_triplet_regexp): New.
 590         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 591         set_gdbarch_gnu_triplet_regexp.
 592
 593 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 594
 595         * Makefile.in: Add xml-builtin.h.
 596         * features/feature_to_c.sh: Add an include for xml-builtin.h
 597         to ensure that the compiler checks that the types match.
 598         * xml-builtin.h: New file.
 599         * xml-support.c (fetch_xml_builtin): Add missing const.
 600         * xml-support.h: Remove declaration of xml_builtins.
 601
 602 2019-10-16  Tom de Vries  <tdevries@suse.de>
 603
 604         PR tdep/25096
 605         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 606         (amd64_classify_aggregate): ... here.
 607         (amd64_classify_aggregate_field): Handled fiels of nested structs
 608         recursively.
 609
 610 2019-10-16  Tom de Vries  <tdevries@suse.de>
 611
 612         PR tdep/24104
 613         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 614         that handles 'theclass'.
 615
 616 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 617
 618         * linespec.c (decode_digits_ordinary): Update comment.
 619         * make-target-delegates: No longer need to handle VEC case.
 620         * memrange.c (normalize_mem_ranges): Update comment.
 621         * namespace.c (add_using_directive): Update comment.
 622         * objc-lang.c (uniquify_strings): Update comment.
 623         * ppc-linux-nat.c (struct thread_points): Update comment.
 624         * probe.h (find_probes_in_objfile): Update comment.
 625         * target.h (enum flash_preserve_mode): Update comment.
 626         * varobj.c (varobj_restrict_range): Update comment.
 627         * varobj.h (varobj_list_children): Update comment.
 628
 629 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 630
 631         * Makefile.in: Remove references to vec.h and vec.c.
 632         * aarch64-tdep.c: No longer include vec.h.
 633         * ada-lang.c: Likewise.
 634         * ada-lang.h: Likewise.
 635         * arm-tdep.c: Likewise.
 636         * ax.h: Likewise.
 637         * breakpoint.h: Likewise.
 638         * charset.c: Likewise.
 639         * cp-support.h: Likewise.
 640         * dtrace-probe.c: Likewise.
 641         * dwarf2read.c: Likewise.
 642         * extension.h: Likewise.
 643         * gdb_bfd.c: Likewise.
 644         * gdbsupport/gdb_vecs.h: Likewise.
 645         * gdbsupport/vec.c: Remove.
 646         * gdbsupport/vec.h: Remove.
 647         * gdbthread.h: Likewise.
 648         * guile/scm-type.c: Likewise.
 649         * inline-frame.c: Likewise.
 650         * machoread.c: Likewise.
 651         * memattr.c: Likewise.
 652         * memrange.h: Likewise.
 653         * namespace.h: Likewise.
 654         * nat/linux-btrace.h: Likewise.
 655         * osdata.c: Likewise.
 656         * parser-defs.h: Likewise.
 657         * progspace.h: Likewise.
 658         * python/py-type.c: Likewise.
 659         * record-btrace.c: Likewise.
 660         * rust-exp.y: Likewise.
 661         * solib-target.c: Likewise.
 662         * stap-probe.c: Likewise.
 663         * target-descriptions.c: Likewise.
 664         * target-memory.c: Likewise.
 665         * target.h: Likewise.
 666         * varobj.c: Likewise.
 667         * varobj.h: Likewise.
 668         * xml-support.h: Likewise.
 669
 670 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 671
 672         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 673         Update for new std::vector based implementation.
 674         (process_psymtab_comp_unit_reader): Likewise.
 675         (scan_partial_symbols): Likewise.
 676         (recursively_compute_inclusions): Likewise.
 677         (compute_compunit_symtab_includes): Likewise.
 678         (process_imported_unit_die): Likewise.
 679         (queue_and_load_dwo_tu): Likewise.
 680         (follow_die_sig_1): Likewise.
 681         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 682         (typedef dwarf2_per_cu_ptr): Remove.
 683         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 684         function.
 685         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 686         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 687         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 688         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 689         std::vector.
 690
 691 2019-10-15  Tom Tromey  <tromey@adacore.com>
 692
 693         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 694         TID.
 695
 696 2019-10-15  Tom Tromey  <tromey@adacore.com>
 697
 698         * windows-nat.c (windows_nat_target::fetch_registers)
 699         (windows_nat_target::store_registers): Rename "pid" to "tid".
 700
 701 2019-10-15  Tom Tromey  <tromey@adacore.com>
 702
 703         * gdbarch.h, gdbarch.c: Rebuild.
 704         * gdbarch.sh (gcc_target_options): Change return type to
 705         std::string.
 706         * compile/compile.c (get_args): Update.
 707         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 708         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 709         std::string.
 710         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 711         std::string.
 712         * arch-utils.c (default_gcc_target_options): Return std::string.
 713         * arch-utils.h (default_gcc_target_options): Return std::string.
 714         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 715
 716 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 717
 718         * breakpoint.c (breakpoint_chain): Make static.
 719         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 720         of accessing breakpoint_chain.
 721
 722 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 723
 724         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 725         to a gdb::function_view and return value to bool.
 726         * breakpoint.h (iterate_over_breakpoints): Likewise.
 727         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 728         (pop_dummy_frame): Update.
 729         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 730         (gdbscm_breakpoints): Update.
 731         * python/py-breakpoint.c (build_bp_list): Update.
 732         (gdbpy_breakpoints): Update.
 733         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 734         Update.
 735         (bpfinishpy_handle_stop): Update.
 736         (bpfinishpy_handle_exit): Update.
 737         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 738         (svr4_update_solib_event_breakpoints): Update.
 739
 740 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 741
 742         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 743         when unwrapping single-field structs.
 744
 745 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 746
 747         * dwarf2read.c: Remove includes.
 748
 749 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 750
 751         * ui-out.c (ui_out::call_do_message): Silence
 752         -Wformat-nonliteral warning.
 753
 754 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 755
 756         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 757         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 758         include: readline/tilde.h.
 759
 760 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 761
 762         * remote.c (remote_target::get_trace_status): Remove declaration of
 763         trace_regblock_size.
 764
 765 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 766
 767         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 768         (show_user): Remove declaration of cmdlist.
 769         * cli/cli-cmds.h (max_user_call_depth): Declare.
 770         * cli/cli-script.c (execute_user_command): Remove declaration
 771         of max_user_call_depth.
 772
 773 2019-10-11  Jim Wilson  <jimw@sifive.com>
 774
 775         * gdbsupport/print-utils.h (pulongest): Fix comment.
 776         (plongest): Likewise.
 777         (phex): Add missing comment, mention leading zeros.
 778         (phex_nz): Add mention of no leading zeros to comment.
 779
 780         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 781         plongest instead of unsigned long long cast.
 782
 783 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 784
 785         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 786         for external_editor_command and gdbtk_test.
 787
 788 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 789
 790         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 791         * varobj.c (varobjdebug): Move comment to...
 792         * varobj.h (varobjdebug): ...here, and declare.
 793
 794 2019-10-09  Tom Tromey  <tom@tromey.com>
 795
 796         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 797         erase_data_content.
 798
 799 2019-10-09  Tom Tromey  <tom@tromey.com>
 800
 801         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 802         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 803         * tui/tui-command.c (tui_cmd_window::resize)
 804         (tui_refresh_cmd_win): Update.
 805         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 806         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 807         * tui/tui-data.c (~tui_gen_win_info): Remove.
 808         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 809         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 810         (tui_redisplay_readline, tui_mld_flush)
 811         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 812         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 813         (tui_data_window::erase_data_content)
 814         (tui_data_item_window::rerender)
 815         (tui_data_item_window::refresh_window): Update.
 816         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 817         (box_win, tui_gen_win_info::make_window)
 818         (tui_gen_win_info::make_visible): Update.
 819         (tui_delete_win): Remove.
 820         * tui/tui-winsource.c
 821         (tui_source_window_base::do_erase_source_content): Update.
 822         (tui_show_source_line, tui_source_window_base::update_tab_width)
 823         (tui_source_window_base::update_exec_info): Update.
 824         * tui/tui-data.h (struct curses_deleter): New.
 825         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 826         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 827
 828 2019-10-09  Tom Tromey  <tom@tromey.com>
 829
 830         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 831
 832 2019-10-09  Tom Tromey  <tom@tromey.com>
 833
 834         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 835         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 836
 837 2019-10-09  Tom Tromey  <tom@tromey.com>
 838
 839         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 840         window height directly.
 841         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 842         declare.
 843         * tui/tui-layout.c (tui_default_win_height): Remove.
 844         (tui_default_win_viewport_height): Remove.
 845
 846 2019-10-09  Tom Tromey  <tom@tromey.com>
 847
 848         * tui/tui.h: Remove comments.
 849
 850 2019-10-09  Tom de Vries  <tdevries@suse.de>
 851
 852         * python/lib/gdb/printer/bound_registers.py: Use
 853         '^builtin_type_bound128' as regexp argument for
 854         add_builtin_pretty_printer.
 855
 856 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 857
 858         * guile/guile.c (guile_extension_script_ops): Remove forward
 859         declaration and mark as static.
 860         (guile_script_ops): Likewise.
 861         (extension_language_guile): Move further down in the file so
 862         it can reference the definitions for guile_{extension_,}script_ops.
 863
 864 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 865
 866         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 867         except SORTL, DFLTCC, and KDSA.
 868
 869 2019-10-08  Tom Tromey  <tromey@adacore.com>
 870
 871         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 872         (struct safe_symbol_file_add_args): Remove.
 873
 874 2019-10-08  Tom Tromey  <tromey@adacore.com>
 875
 876         * windows-nat.c: Don't include buildsym-legacy.h.
 877
 878 2019-10-08  Tom Tromey  <tromey@adacore.com>
 879
 880         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 881
 882 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 883
 884         * gdbtypes.c (overload_debug): Move comment to header.
 885         * gdbtypes.h (overload_debug): Declare.
 886         * valops.c: Remove declaration of overload_debug, instead
 887         include gdbtypes.h.
 888
 889 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 890
 891         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 892         through _().
 893         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 894         move comment...
 895         * language.h (lang_frame_mismatch_warn): ... here. Also add
 896         declaration.
 897         * top.c (lang_frame_mismatch_warn): Remove declaration.
 898         (check_frame_language_change): Pass lang_frame_mismatch_warn
 899         through _().
 900
 901 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 902
 903         * c-lang.h (vtbl_ptr_name): Declare.
 904         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 905         it from the header.
 906         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 907
 908 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 909
 910         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 911         gdb_static_assert.
 912
 913 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 914
 915         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 916         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 917         * ctfread.c: New file.
 918         * ctfread.h: New file.
 919         * elfread.c: Include ctfread.h.
 920         (struct elfinfo text_p): New member ctfsect.
 921         (elf_locate_sections): Mark CTF section.
 922         (elf_symfile_read): Call elfctf_build_psymtabs.
 923         * Makefile.in (LIBCTF): Add.
 924         (CLIBS): Use it.
 925         (CDEPS): Likewise.
 926         (DIST): Add ctfread.c.
 927
 928 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 929
 930         * ctfread.c (struct nextfield): Renamed to ...
 931         (struct ctf_nextfield): ... this.
 932         (struct field_info): Renamed to ...
 933         (strut ctf_field_info): ... this.
 934         (attach_fields_to_type): Update for renamed structures.
 935         (ctf_add_member_cb): Likewise.
 936         (ctf_add_enum_member_cb): Likewise.
 937         (process_struct_members): Likewise.
 938         (process_enum_type): Likewise.
 939
 940 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 941
 942         * tracectf.h: Rename, was ctf.h.
 943         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 944         * tracefile.c: Likewise.
 945         * tracepoint.c: Remove unused include ctf.h.
 946         * mi/mi-main.c: Likewise.
 947         * Makefile.in Replace ctf.c with tracectf.c.
 948
 949 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 950
 951         * version.in: Change version number to "9.0.50.DATE-git".
 952
 953 2019-10-03  Tom Tromey  <tom@tromey.com>
 954
 955         PR rust/24976:
 956         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 957
 958 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 959
 960         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 961         cp_search_name_hash.
 962         * NEWS: Add entry about nested function support.
 963
 964 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 965             Andrew Burgess  <andrew.burgess@embecosm.com>
 966
 967         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 968         for nested static variables when searchin VAR_DOMAIN.
 969         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 970         global scope, update comment.
 971         (add_partial_subprogram): Call add_partial_subprogram recursively
 972         for nested subroutines when processinng Fortran.
 973         (load_partial_dies): Process the child entities of a subprogram
 974         when processing Fortran.
 975         (partial_die_parent_scope): Handle building scope
 976         for Fortran nested functions.
 977         (process_die): Record that nested functions have a scope.
 978         (new_symbol): Always record Fortran subprograms on the global
 979         symbol list.
 980         (determine_prefix): How to build the prefix for Fortran
 981         subprograms.
 982
 983 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 984
 985         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 986         have just sent the thread a SIGSTOP and are waiting for it to
 987         arrive.
 988
 989 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 990
 991         * btrace.c (btrace_add_pc): Remove whitespace before the template
 992         parameter in 'std::vector <...>'.
 993         (parse_xml_btrace_block): Likewise.
 994         (btrace_maint_decode_pt): Likewise.
 995         (btrace_maint_update_packets): Likewise.
 996         (btrace_maint_print_packets): Likewise.
 997         * btrace.h (struct btrace_maint_info): Likewise.
 998         * dwarf2read.c (struct type_unit_group): Likewise.
 999         (build_type_psymtabs_reader): Likewise.
1000         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1001         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1002         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1003
1004 2019-10-03  Tom de Vries  <tdevries@suse.de>
1005
1006         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1007         the first line of the help text for set/show style metadata.
1008
1009 2019-10-02  Tom Tromey  <tromey@adacore.com>
1010
1011         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1012         * gdbsupport/common-inferior.c: New file.
1013         * infcmd.c (startup_with_shell): Don't define.
1014         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1015         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1016         * inferior.h (startup_with_shell): Don't declare.
1017
1018 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1019
1020         * gdbsupport/gdb_assert.h: Include errors.h.
1021         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1022
1023 2019-10-02  Tom Tromey  <tromey@adacore.com>
1024
1025         * NEWS: Add $_ada_exception entry.
1026         * ada-lang.c (struct ada_catchpoint): Add constructor.
1027         <m_kind>: New member.
1028         (allocate_location_exception, re_set_exception): Remove
1029         "ex" parameter.
1030         (should_stop_exception): Compute $_ada_exception.
1031         (check_status_exception, print_it_exception)
1032         (print_one_exception, print_mention_exception): Remove
1033         "ex" parameter.
1034         (allocate_location_catch_exception, re_set_catch_exception)
1035         (check_status_exception, print_it_catch_exception)
1036         (print_one_catch_exception, print_mention_catch_exception)
1037         (print_recreate_catch_exception)
1038         (allocate_location_catch_exception_unhandled)
1039         (re_set_catch_exception_unhandled)
1040         (check_status_exception, print_it_catch_exception_unhandled)
1041         (print_one_catch_exception_unhandled)
1042         (print_mention_catch_exception_unhandled)
1043         (print_recreate_catch_exception_unhandled)
1044         (allocate_location_catch_assert, re_set_catch_assert)
1045         (check_status_assert, print_it_catch_assert)
1046         (print_one_catch_assert, print_mention_catch_assert)
1047         (print_recreate_catch_assert)
1048         (allocate_location_catch_handlers, re_set_catch_handlers)
1049         (check_status_handlers, print_it_catch_handlers)
1050         (print_one_catch_handlers, print_mention_catch_handlers)
1051         (print_recreate_catch_handlers): Remove.
1052         (create_ada_exception_catchpoint): Update.
1053         (initialize_ada_catchpoint_ops): Update.
1054
1055 2019-10-02  Tom Tromey  <tromey@adacore.com>
1056
1057         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1058         (create_excep_cond_exprs): Simplify exception string computation.
1059         (ada_exception_catchpoint_cond_string): Likewise.
1060
1061 2019-10-02  Tom Tromey  <tromey@adacore.com>
1062
1063         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1064         * ada-lang.c (lesseq_defined_than): Handle
1065         LOC_STATIC.
1066         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1067         parameter.
1068         (dwarf2_has_info): Likewise.
1069         (new_symbol): Set maybe_copied on symbol when
1070         appropriate.
1071         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1072         parameter.
1073         <can_copy>: New member.
1074         * elfread.c (record_minimal_symbol): Set maybe_copied
1075         on symbol when appropriate.
1076         (elf_symfile_read): Update call to dwarf2_has_info.
1077         * minsyms.c (lookup_minimal_symbol_linkage): New
1078         function.
1079         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1080         * symtab.c (get_symbol_address, get_msymbol_address):
1081         New functions.
1082         * symtab.h (get_symbol_address, get_msymbol_address):
1083         Declare.
1084         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1085         maybe_copied.
1086         (struct symbol, struct minimal_symbol) <maybe_copied>:
1087         New member.
1088
1089 2019-10-02  Tom Tromey  <tromey@adacore.com>
1090
1091         * source.c (struct current_source_location): New.
1092         (current_source_key): New global.
1093         (current_source_symtab, current_source_line)
1094         (current_source_pspace): Remove.
1095         (get_source_location): New function.
1096         (get_current_source_symtab_and_line)
1097         (set_default_source_symtab_and_line)
1098         (set_current_source_symtab_and_line)
1099         (clear_current_source_symtab_and_line, select_source_symtab)
1100         (info_source_command, print_source_lines_base)
1101         (info_line_command, search_command_helper, _initialize_source):
1102         Update.
1103
1104 2019-10-02  Tom Tromey  <tromey@adacore.com>
1105
1106         * source.c (select_source_symtab): Don't call
1107         decode_line_with_current_source.
1108
1109 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1110
1111         * symtab.c (lookup_global_symbol): Search global block.
1112
1113 2019-10-02  Tom Tromey  <tromey@adacore.com>
1114
1115         * coffread.c (process_coff_symbol): Update.
1116         * dwarf2read.c (var_decode_location, new_symbol): Update.
1117         * mdebugread.c (parse_symbol): Update.
1118         * objfiles.c (relocate_one_symbol): Update.
1119         * stabsread.c (define_symbol, fix_common_block)
1120         (scan_file_globals): Update.
1121         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1122         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1123         * xcoffread.c (process_xcoff_symbol): Update.
1124
1125 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1126
1127         * MAINTAINERS: Update my email address.
1128
1129 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1130
1131         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1132         std::vector.
1133         (build_type_psymtabs_reader): Update for std::vector.
1134         (build_type_psymtab_dependencies): Likewise.
1135         * dwarf2read.h: Remove use of DEF_VEC_P.
1136         (typedef sig_type_ptr): Delete.
1137
1138 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1139
1140         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1141         to std::vector.
1142         (btrace_maint_decode_pt): Likewise, and move allocation of the
1143         vector outside of the loop.
1144         (btrace_maint_update_packets): Update to handle change from VEC to
1145         std::vector.
1146         (btrace_maint_print_packets): Likewise.
1147         (maint_info_btrace_cmd): Likewise.
1148         * btrace.h: Remove use of DEF_VEC_O.
1149         (typedef btrace_pt_packet_s): Delete.
1150         (struct btrace_maint_info) <packets>: Change fromm VEC to
1151         std::vector.
1152         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1153
1154 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1155
1156         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1157         make accesses into the vector constant references.
1158         (btrace_add_pc): Update for std::vector.
1159         (btrace_stitch_bts): Likewise.
1160         (parse_xml_btrace_block): Likewise.
1161         (btrace_maint_update_packets): Likewise.
1162         (btrace_maint_print_packets): Likewise.
1163         (maint_info_btrace_cmd): Likewise.
1164         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1165         std::vector.
1166         (btrace_data::empty): Likewise.
1167         (btrace_data_append): Likewise.
1168         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1169         (typedef btrace_block_s): Delete.
1170         (struct btrace_block): Add constructor.
1171         (struct btrace_data_bts) <blocks>: Change to std::vector.
1172         * nat/linux-btrace.c (perf_event_read_bts): Update for
1173         std::vector.
1174         (linux_read_bts): Likewise.
1175
1176 2019-10-01  Tom Tromey  <tom@tromey.com>
1177
1178         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1179
1180 2019-10-01  Tom Tromey  <tom@tromey.com>
1181
1182         * stack.c (print_frame, info_frame_command_core): Use
1183         styled_string.
1184         * linux-thread-db.c (try_thread_db_load_1)
1185         (try_thread_db_load_from_pdir_1): Use styled_string.
1186         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1187         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1188         (maybe_print_unsupported_script_warning)
1189         (maybe_print_script_not_found_warning): Use styled_string.
1190         * ada-lang.c (user_select_syms): Use styled_string.
1191
1192 2019-10-01  Tom Tromey  <tom@tromey.com>
1193
1194         * p-lang.c (pascal_printstr): Use metadata style.
1195         * value.c (show_convenience): Use metadata style.
1196         * valprint.c (valprint_check_validity, val_print_optimized_out)
1197         (val_print_not_saved, val_print_unavailable)
1198         (val_print_invalid_address, generic_val_print, val_print)
1199         (value_check_printable, val_print_array_elements): Use metadata
1200         style.
1201         * ui-out.h (class ui_out) <field_fmt>: New overload.
1202         <do_field_fmt>: Add style parameter.
1203         * ui-out.c (ui_out::field_fmt): New overload.
1204         * typeprint.c (type_print_unknown_return_type)
1205         (val_print_not_allocated, val_print_not_associated): Use metadata
1206         style.
1207         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1208         parameter.
1209         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1210         * tracepoint.c (tvariables_info_1): Use metadata style.
1211         * stack.c (print_frame_arg, print_frame_info, print_frame)
1212         (info_frame_command_core): Use metadata style.
1213         * skip.c (info_skip_command): Use metadata style.
1214         * rust-lang.c (rust_print_enum): Use metadata style.
1215         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1216         metadata style.
1217         * python/py-framefilter.c (py_print_single_arg): Use metadata
1218         style.
1219         * printcmd.c (do_one_display, print_variable_and_value): Use
1220         metadata style.
1221         * p-valprint.c (pascal_val_print)
1222         (pascal_object_print_value_fields): Use metadata style.
1223         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1224         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1225         parameter.
1226         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1227         * m2-valprint.c (m2_print_long_set): Use metadata style.
1228         * m2-typeprint.c (m2_print_type): Use metadata style.
1229         * infcmd.c (print_return_value_1): Use metadata style.
1230         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1231         * f-valprint.c (info_common_command_for_block): Use metadata
1232         style.
1233         * f-typeprint.c (f_type_print_base): Use metadata style.
1234         * expprint.c (print_subexp_standard): Use metadata style.
1235         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1236         * cli/cli-style.h (class cli_style_option): Add constructor.
1237         (metadata_style): Declare.
1238         * cli/cli-style.c (metadata_style): New global.
1239         (_initialize_cli_style): Register metadata style.
1240         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1241         parameter.
1242         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1243         * c-typeprint.c (c_type_print_base_struct_union)
1244         (c_type_print_base_1): Use metadata style.
1245         * breakpoint.c (watchpoint_value_print)
1246         (print_one_breakpoint_location): Use metadata style.
1247         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1248         style.
1249         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1250         style.
1251         * ada-valprint.c (val_print_packed_array_elements, printstr)
1252         (print_field_values, ada_val_print_ref, ada_val_print): Use
1253         metadata style.
1254         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1255         style.
1256         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1257         style.
1258         * ada-lang.c (user_select_syms): Use metadata style.
1259
1260 2019-10-01  Tom Tromey  <tom@tromey.com>
1261
1262         * cli/cli-cmds.c (pwd_command): Style output.
1263
1264 2019-10-01  Pedro Alves  <palves@redhat.com>
1265             Tom Tromey  <tom@tromey.com>
1266
1267         * symtab.c (print_symbol_info): Use %ps.
1268         (print_msymbol_info): Use %ps.
1269         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1270         * printcmd.c (print_variable_and_value): Use %ps.
1271         * macrocmd.c (show_pp_source_pos): Use %ps.
1272         * infrun.c (print_exited_reason): Use ui_out::message.
1273         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1274         (describe_other_breakpoints): Use ui_out::message and new
1275         formats.
1276         (say_where): Use new formats.
1277         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1278         and new formats.
1279
1280 2019-10-01  Pedro Alves  <palves@redhat.com>
1281             Tom Tromey  <tom@tromey.com>
1282
1283         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1284         (test_gdb_formats): New function.
1285         (run_tests): Call it.
1286         (test_format_specifier): Update.
1287         * utils.h (fputs_filtered): Update comment.
1288         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1289         (fputs_styled_unfiltered): Declare.
1290         * utils.c (fputs_styled_unfiltered): New function.
1291         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1292         (vfprintf_filtered): Update.
1293         (vfprintf_unfiltered, vprintf_filtered): Update.
1294         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1295         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1296         disallow_ui_out_field>: New constants.
1297         (enum class field_kind): New.
1298         (struct base_field_s, struct signed_field_s): New.
1299         (signed_field): New function.
1300         (struct string_field_s): New.
1301         (string_field): New function.
1302         (struct styled_string_s): New.
1303         (styled_string): New function.
1304         (class ui_out) <message>: Add comment.
1305         <vmessage, call_do_message>: New methods.
1306         <do_message>: Add style parameter.
1307         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1308         methods.
1309         (ui_out::message): Rewrite.
1310         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1311         parameter.
1312         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1313         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1314         gdb_extensions parameter.
1315         (class format_piece): Add parameter to constructor.
1316         (n_int_args): New field.
1317         * gdbsupport/format.c (format_pieces::format_pieces): Add
1318         gdb_extensions parameter.  Handle '*'.
1319         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1320         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1321         vfprintf_styled_no_gdbfmt.
1322         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1323         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1324         unfiltered output.
1325         * ui-style.h (struct ui_file_style) <ptr>: New method.
1326
1327 2019-10-01  Tom Tromey  <tom@tromey.com>
1328
1329         * unittests/format_pieces-selftests.c: Update.  Add final format.
1330         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1331         empty literal pieces.
1332
1333 2019-10-01  Tom Tromey  <tom@tromey.com>
1334
1335         * ui-out.h (enum class ui_out_style_kind): Remove.
1336         (class ui_out) <field_string, field_stsream, do_field_string>:
1337         Change type of "style".
1338         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1339         (ui_out::field_string): Update.
1340         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1341         of "style".
1342         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1343         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1344         * stack.c (print_frame_arg, print_frame_info, print_frame):
1345         Update.
1346         * source.c (print_source_lines_base): Update.
1347         * solib.c (info_sharedlibrary_command): Update.
1348         * skip.c (info_skip_command): Update.
1349         * record-btrace.c (btrace_call_history_src_line)
1350         (btrace_call_history): Update.
1351         * python/py-framefilter.c (py_print_frame): Update.
1352         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1353         "style".
1354         * mi/mi-out.c (mi_ui_out::do_table_header)
1355         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1356         (mi_ui_out::do_field_string): Update.
1357         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1358         Update.
1359         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1360         "style".
1361         * cli-out.c (cli_ui_out::do_table_header)
1362         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1363         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1364         (cli_ui_out::do_field_fmt): Update.
1365         * breakpoint.c (print_breakpoint_location): Update.
1366         (update_static_tracepoint): Update.
1367
1368 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1369
1370         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1371         conversion of gdb_datadir.
1372         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1373         remove not needed c_str ().
1374
1375 2019-09-30  Ali Tamur <tamur@google.com>
1376
1377         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1378         (dwarf2_string_attr): Likewise.
1379
1380 2019-09-30  Ali Tamur <tamur@google.com>
1381
1382         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1383         (process_full_type_unit): Likewise.
1384         (dump_die_shallow): Likewise.
1385         (cu_debug_loc_section): Likewise.
1386
1387 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1388
1389         * minsyms.c (compare_minimal_symbols): Rename to...
1390         (minimal_symbol_is_less_than): ...this, and adjust to STL
1391         conventions (return bool, take arguments as references)
1392         (minimal_symbol_reader::install): Call std::sort instead
1393         of qsort.
1394
1395 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1396
1397         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1398         hash and why.
1399         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1400         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1401
1402 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1403
1404         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1405         * psympriv.h (add_psymbol_to_list): Move comment here and update
1406         it.
1407
1408 2019-09-29  Tom de Vries  <tdevries@suse.de>
1409
1410         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1411         Use $tmpdir/$(basename "$output_file").dwz instead of
1412         "${output_file}.dwz".
1413
1414 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1415
1416         PR gdb/25045
1417         * hppa-linux-nat.c: Include gdbarch.h.
1418
1419 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1420
1421         * blockframe.c (find_pc_partial_function): Change return type to bool.
1422         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1423         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1424         (stub_gnu_ifunc_resolve_name): Likewise.
1425         * symtab.c (compare_filenames_for_search): Likewise.
1426         (compare_glob_filenames_for_search): Likewise.
1427         (matching_obj_sections): Likewise.
1428         (symbol_matches_domain): Likewise.
1429         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1430         (find_line_pc): Change return type to bool.
1431         (find_line_pc_range): Likewise.
1432         (producer_is_realview): Likewise.
1433         * symtab.h (symbol_matches_domain): Likewise.
1434         (find_pc_partial_function): Likewise.
1435         (find_pc_line_pc_range): Likewise.
1436         (in_gnu_ifunc_stub): Likewise.
1437         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1438         (find_line_pc): Likewise.
1439         (find_line_pc_range): Likewise.
1440         (matching_obj_sections): Likewise.
1441         (find_line_symtab): Change out parameter to bool.
1442         (producer_is_realview): Change return type to bool.
1443         (compare_filenames_for_search): Likewise.
1444         (compare_glob_filenames_for_search): Likewise.
1445
1446 2019-09-26  Tom Tromey  <tom@tromey.com>
1447
1448         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1449         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1450         * gdb_usleep.h: Remove.
1451         * gdb_usleep.c: Remove.
1452         * utils.c: Don't include gdb_usleep.h.
1453
1454 2019-09-26  Tom Tromey  <tromey@adacore.com>
1455
1456         * python/py-type.c (type_to_type_object): Call check_typedef
1457         for stub types.
1458
1459 2019-09-26  Tom Tromey  <tom@tromey.com>
1460
1461         * utils.h (initialize_utils): Don't declare.
1462         * top.c (gdb_init): Don't call initialize_utils.
1463         * utils.c (initialize_utils): Remove.  Move contents...
1464         (_initialize_utils): ... here.
1465
1466 2019-09-25  Tom Tromey  <tom@tromey.com>
1467
1468         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1469         * utils.h (make_hex_string): Don't declare.
1470         * utils.c (make_hex_string): Remove.
1471
1472 2019-09-24  Tom de Vries  <tdevries@suse.de>
1473
1474         PR gdb/23815
1475         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1476         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1477
1478 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1479
1480         * NEWS: Mention new simulator port for PRU.
1481
1482 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1483
1484         * ada-exp.y (write_object_remaining): Update.
1485         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1486         and eliminate the static buffer.
1487         (ada_decode_symbol): Update.
1488         (ada_la_decode): Update.
1489         (ada_sniff_from_mangled_name): Update.
1490         (is_valid_name_for_wild_match): Update.
1491         (ada_lookup_name_info::matches): Update and simplify.
1492         (name_matches_regex): Update.
1493         (ada_add_global_exceptions): Update.
1494         * ada-lang.h (ada_decode): Update signature.
1495         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1496         * dwarf-index-write.c (debug_names::insert): Update.
1497
1498 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1499
1500         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1501         formatting.
1502
1503 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1504
1505         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1506         Change "nonzero" to "true" in documentation.
1507
1508 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1509
1510         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1511         (_initialize_darwin_solib): Don't set
1512         darwin_so_ops.lookup_lib_global_symbol.
1513         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1514         set_gdbarch_iterate_over_objfiles_in_search_order.
1515         (elf_lookup_lib_symbol): Rename to...
1516         (svr4_iterate_over_objfiles_in_search_order): this, and update
1517         to iterate semantics.
1518         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1519         * solib.c (solib_global_lookup): Remove.
1520         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1521         (solib_global_lookup): Remove.
1522         * symtab.c (lookup_global_or_static_symbol): Remove call to
1523         solib_global_lookup.
1524
1525 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1526
1527         * NEWS: Move entries about default MI version now being
1528         version 3, and about the GDB/MI fix for multi-location
1529         breakpoints to the "since GDB 8.3" section.
1530
1531 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1532
1533         GDB 8.3.1 released.
1534
1535 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1536
1537         * NEWS: Mention that Cell/B.E. debugging support was removed.
1538         * MAINTAINERS: Remove spu target.
1539
1540         * config/djgpp/fnchange.lst: Remove entries for removed files.
1541
1542         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1543         spu-multiarch.o, and spu-tdep.o.
1544         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1545         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1546         spu-multiarch.c, and spu-tdep.c.
1547         * spu-linux-nat.c: Remove file.
1548         * spu-multiarch.c: Remove file.
1549         * spu-tdep.c: Remove file.
1550         * spu-tdep.h: Remove file.
1551         * solib-spu.c: Remove file.
1552         * solib-spu.h: Remove file.
1553
1554         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1555         * configure.nat (spu-linux): Remove.
1556         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1557         solib-multiarch.o from gdb_target_obs.
1558         (spu*-*-*): Remove.
1559
1560         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1561         feature flag.
1562         (ppc_linux_no_features): Update.
1563         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1564         Cell/B.E. support.
1565         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1566         (tdesc_powerpc_cell64l): Likewise.
1567         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1568         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1569         Cell/B.E. support.
1570         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1571         Do not include "features/rs6000/powerpc-cell32l.c" or
1572         "features/rs6000/powerpc-cell64l.c".
1573         (ppc_linux_spu_section): Remove.
1574         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1575         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1576         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1577         (ppc_linux_spe_context_lookup): Remove.
1578         (ppc_linux_spe_context_inferior_created): Remove.
1579         (ppc_linux_spe_context_solib_loaded): Remove.
1580         (ppc_linux_spe_context_solib_unloaded): Remove.
1581         (ppc_linux_spe_context): Remove.
1582         (struct ppu2spu_cache): Remove.
1583         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1584         (struct ppu2spu_data): Remove.
1585         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1586         ppu2spu_unwind): Remove.
1587         (ppc_linux_init_abi): Remove Cell/B.E. support.
1588         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1589
1590         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1591         (rs6000/powerpc-cell64l-expedite): Likewise
1592         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1593         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1594         rs6000/powerpc-cell64l.xml.
1595         * features/rs6000/powerpc-cell32l.xml: Remove.
1596         * features/rs6000/powerpc-cell64l.xml: Likewise.
1597         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1598         * features/rs6000/powerpc-cell64l.c: Likewise.
1599         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1600         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1601         * regformats/reg-spu.dat: Remove.
1602
1603         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1604         * corelow.c (struct spuid_list): Remove.
1605         (add_to_spuid_list): Remove.
1606         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1607         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1608         (remote_protocol_features): Remove associated entries.
1609         (_initialize_remote): No longer initialize them.
1610         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1611         * linux-nat.c (SPUFS_MAGIC): Remove.
1612         (linux_proc_xfer_spu): Remove.
1613         (spu_enumerate_spu_ids): Remove.
1614         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1615         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1616         (linux_make_corefile_notes): No longer call it.
1617
1618         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1619         (cooked_write_test): Likewise.
1620
1621 2019-09-20  Tom Tromey  <tom@tromey.com>
1622
1623         * NEWS: Mention case-sensitivity of TUI commands.
1624         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1625         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1626         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1627
1628 2019-09-20  Tom Tromey  <tom@tromey.com>
1629
1630         * tui/tui-source.c (tui_source_window::set_contents): Use
1631         make_unique_xstrdup.
1632         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1633         make_unique_xstrdup.
1634
1635 2019-09-20  Tom Tromey  <tom@tromey.com>
1636
1637         * tui/tui-data.c: Remove separator comments.
1638         * tui/tui-layout.c: Remove separator comments.
1639         * tui/tui-win.c: Remove separator comments.
1640         * tui/tui-wingeneral.c: Remove separator comments.
1641
1642 2019-09-20  Tom Tromey  <tom@tromey.com>
1643
1644         * tui/tui.h (strcat_to_buf): Don't declare.
1645         * tui/tui.c (strcat_to_buf): Remove.
1646
1647 2019-09-20  Tom Tromey  <tom@tromey.com>
1648
1649         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1650         from "fullname".
1651         * tui/tui-source.c (tui_source_window::set_contents)
1652         (tui_source_window::location_matches_p)
1653         (tui_source_window::maybe_update): Update.
1654
1655 2019-09-20  Tom Tromey  <tom@tromey.com>
1656
1657         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1658         Update.
1659         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1660         prefix.
1661         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1662         (tui_data_window::line_from_reg_element_no)
1663         (tui_data_window::first_reg_element_no_inline)
1664         (tui_data_window::show_registers)
1665         (tui_data_window::show_register_group)
1666         (tui_data_window::display_registers_from)
1667         (tui_data_window::display_registers_from_line)
1668         (tui_data_window::first_data_item_displayed)
1669         (tui_data_window::delete_data_content_windows)
1670         (tui_data_window::erase_data_content)
1671         (tui_data_window::do_scroll_vertical)
1672         (tui_data_window::refresh_window)
1673         (tui_data_window::check_register_values): Update.
1674
1675 2019-09-20  Tom Tromey  <tom@tromey.com>
1676
1677         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1678         (struct tui_locator_window) <full_name, proc_name>: Now
1679         std::string.
1680         * tui/tui-stack.c (tui_locator_window::make_status_line)
1681         (tui_locator_window::set_locator_fullname)
1682         (tui_locator_window::set_locator_info): Update.
1683         * tui/tui-source.c (tui_source_window::set_contents)
1684         (tui_source_window::showing_source_p): Update.
1685
1686 2019-09-20  Tom Tromey  <tom@tromey.com>
1687
1688         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1689         Don't call tui_locator_win_info_ptr.
1690
1691 2019-09-20  Tom Tromey  <tom@tromey.com>
1692
1693         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1694
1695 2019-09-20  Tom Tromey  <tom@tromey.com>
1696
1697         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1698         height for locator.
1699         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1700         * tui/tui-layout.c (show_source_disasm_command, show_data)
1701         (show_source_or_disasm_and_command): Use 1 as height for locator.
1702
1703 2019-09-20  Tom Tromey  <tom@tromey.com>
1704
1705         * tui/tui.c (tui_enable): Update.
1706         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1707         Update.
1708         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1709         Update.
1710         * tui/tui-data.c (win_resized): Now bool.
1711         (tui_win_resized): Return bool.
1712         (tui_set_win_resized_to): Accept a bool.
1713
1714 2019-09-20  Tom Tromey  <tom@tromey.com>
1715
1716         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1717         Change type of "refresh_values_only".
1718         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1719         type of "refresh_values_only".
1720
1721 2019-09-20  Tom Tromey  <tom@tromey.com>
1722
1723         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1724         std::string.
1725         (tui_disassemble): Add "pos" parameter.
1726         (tui_disasm_window::set_contents): Simplify.
1727
1728 2019-09-20  Tom Tromey  <tom@tromey.com>
1729
1730         * tui/tui-winsource.h (struct tui_source_window_base)
1731         <show_source_content>: Now private.
1732         * tui/tui-winsource.c
1733         (tui_source_window_base::show_source_content): Don't handle empty
1734         content case.
1735
1736 2019-09-20  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-layout.c (show_source_disasm_command)
1739         (show_source_or_disasm_and_command): Don't call
1740         show_source_content.
1741
1742 2019-09-20  Tom Tromey  <tom@tromey.com>
1743
1744         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1745         Declare.
1746         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1747         from tui_make_status_line.
1748         (tui_locator_window::rerender): Update.
1749
1750 2019-09-20  Tom Tromey  <tom@tromey.com>
1751
1752         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1753         (tui_locator_window::rerender): Update.
1754
1755 2019-09-20  Tom Tromey  <tom@tromey.com>
1756
1757         * tui/tui-winsource.h (struct tui_source_window_base)
1758         <~tui_source_window_base>: Don't declare.
1759         <fullname>: Remove.
1760         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1761         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1762         member.
1763         * tui/tui-source.c (tui_source_window::set_contents): Update.
1764         (tui_source_window::location_matches_p)
1765         (tui_source_window::maybe_update): Update.
1766
1767 2019-09-20  Tom Tromey  <tom@tromey.com>
1768
1769         * tui/tui-winsource.h (~tui_source_element): Remove.
1770         (tui_source_element): Update.
1771         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1772         * tui/tui-winsource.c (tui_show_source_line): Update.
1773         * tui/tui-source.c (tui_source_window::set_contents): Update.
1774         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1775
1776 2019-09-20  Tom Tromey  <tom@tromey.com>
1777
1778         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1779         declare.
1780         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1781         tui_clear_source_windows_detail.
1782         * tui/tui-winsource.h (struct tui_source_window_base)
1783         <clear_detail>: Don't declare.
1784         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1785         Remove.
1786         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1787
1788 2019-09-20  Tom Tromey  <tromey@adacore.com>
1789
1790         PR ada/24919:
1791         * block.c (contained_in): Fix final return value.
1792
1793 2019-09-20  Alan Modra  <amodra@gmail.com>
1794
1795         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1796         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1797         (read_indirect_string_from_dwz): Use bfd accessor.
1798         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1799         * machoread.c (macho_symfile_read_all_oso): Likewise.
1800         * solib.c (solib_bfd_open): Likewise.
1801
1802 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1803
1804         * eval.c: Move declaration of overload_resolution to...
1805         * value.h: ...here.
1806
1807 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1808
1809         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1810         * arm-linux-tdep.c: Likewise.
1811         * arm-nbsd-nat.c: Likewise.
1812         * arm-tdep.h: Declare arm_apcs_32.
1813         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1814
1815 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1816
1817         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1818         * dwarf2read.h: Declare dwarf_always_disassemble.
1819
1820 2019-09-19  Tom de Vries  <tdevries@suse.de>
1821
1822         PR gdb/25009
1823         * source-cache.c (source_cache::ensure): Catch exception thrown during
1824         construction of the highlighter.
1825
1826 2019-09-18  Alan Modra  <amodra@gmail.com>
1827
1828         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1829         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1830         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1831         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1832         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1833         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1834         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1835         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1836         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1837         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1838         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1839         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1840         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1841         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1842         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1843         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1844         * mi/mi-interp.c: Update throughout for bfd section macro and
1845         function changes.
1846         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1847         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1848
1849 2019-09-18  Tom Tromey  <tom@tromey.com>
1850
1851         * NEWS: Add entry.
1852         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1853         call rl_initialize.
1854         (tui_enable): Do not call rl_initialize.
1855
1856 2019-09-18  Christian Groessler  <chris@groessler.org>
1857
1858         * alpha-linux-nat.c: Include gdbarch.h.
1859
1860 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1861
1862         * ui-file.c: Include cli/cli-style.h.
1863         (term_cli_styling): Remove cli_styling declaration.
1864
1865 2019-09-18  Alan Modra  <amodra@gmail.com>
1866
1867         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1868         to bfd_asymbol_section.
1869
1870 2019-09-18  Alan Modra  <amodra@gmail.com>
1871
1872         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1873         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1874         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1875
1876 2019-09-18  Alan Modra  <amodra@gmail.com>
1877
1878         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1879         * spu-linux-nat.c (spu_bfd_open): Likewise.
1880
1881 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1882
1883         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1884         to bool to match definition in dwarf2read.c.
1885
1886 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1887
1888         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1889         (print_signatures): Likewise.
1890         (trust_pad_over_xvs): Likewise.
1891         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1892         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1893         * arm-linux-nat.c (arm_apcs_32): Likewise.
1894         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1895         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1896         * arm-tdep.c (arm_debug): Likewise.
1897         (arm_apcs_32): Likewise.
1898         * auto-load.c (debug_auto_load): Likewise.
1899         (auto_load_gdb_scripts): Likewise.
1900         (global_auto_load): Likewise.
1901         (auto_load_local_gdbinit): Likewise.
1902         (auto_load_local_gdbinit_loaded): Likewise.
1903         * auto-load.h (global_auto_load): Likewise.
1904         (auto_load_local_gdbinit): Likewise.
1905         (auto_load_local_gdbinit_loaded): Likewise.
1906         * breakpoint.c (disconnected_dprintf): Likewise.
1907         (breakpoint_proceeded): Likewise.
1908         (automatic_hardware_breakpoints): Likewise.
1909         (always_inserted_mode): Likewise.
1910         (target_exact_watchpoints): Likewise.
1911         (_initialize_breakpoint): Update.
1912         * breakpoint.h (target_exact_watchpoints): Change to bool.
1913         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1914         * cli/cli-cmds.c (trace_commands): Likewise.
1915         * cli/cli-cmds.h (trace_commands): Likewise.
1916         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1917         to bool*.
1918         * cli/cli-logging.c (logging_overwrite): Change to bool.
1919         (logging_redirect): Likewise.
1920         (debug_redirect): Likewise.
1921         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1922         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1923         to bool.
1924         <boolean_option_def>: Update.
1925         (struct flag_option_def): Change default type of Context to bool
1926         from int.
1927         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1928         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1929         (get_setshow_command_value_string): Likewise.
1930         * cli/cli-style.c (cli_styling): Change to bool.
1931         (source_styling): Likewise.
1932         * cli/cli-style.h (source_styling): Likewise.
1933         (cli_styling): Likewise.
1934         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1935         to bool.
1936         * command.h (var_types): Update comment.
1937         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1938         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1939         bool.
1940         (debug_compile_cplus_scopes): Likewise.
1941         * compile/compile-internal.h (compile_debug): Likewise.
1942         * compile/compile.c (compile_debug): Likewise.
1943         (struct compile_options) <raw>: Likewise.
1944         * cp-support.c (catch_demangler_crashes): Likewise.
1945         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1946         (usr_cmd_cris_dwarf2_cfi): Likewise.
1947         * csky-tdep.c (csky_debug): Likewise.
1948         * darwin-nat.c (enable_mach_exceptions): Likewise.
1949         * dcache.c (dcache_enabled_p): Likewise.
1950         * defs.h (info_verbose): Likewise.
1951         * demangle.c (demangle): Likewise.
1952         (asm_demangle): Likewise.
1953         * dwarf-index-cache.c (debug_index_cache): Likewise.
1954         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1955         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1956         * dwarf2read.c (check_physname): Likewise.
1957         (use_deprecated_index_sections): Likewise.
1958         (dwarf_always_disassemble): Likewise.
1959         * eval.c (overload_resolution): Likewise.
1960         * event-top.c (set_editing_cmd_var): Likewise.
1961         (exec_done_display_p): Likewise.
1962         * event-top.h (set_editing_cmd_var): Likewise.
1963         (exec_done_display_p): Likewise.
1964         * exec.c (write_files): Likewise.
1965         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1966         (debug_fbsd_nat): Likewise.
1967         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1968         Likewise.
1969         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1970         <backtrace_past_entry> Likewise.
1971         * gdb-demangle.h (demangle): Likewise.
1972         (asm_demangle): Likewise.
1973         * gdb_bfd.c (bfd_sharing): Likewise.
1974         * gdbcore.h (write_files): Likewise.
1975         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1976         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1977         * gdbthread.h (print_thread_events): Likewise.
1978         * gdbtypes.c (opaque_type_resolution): Likewise.
1979         (strict_type_checking): Likewise.
1980         * gnu-nat.c (gnu_debug_flag): Likewise.
1981         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1982         * guile/scm-param.c (pascm_variable): Add boolval.
1983         (add_setshow_generic): Update.
1984         (pascm_param_value): Update.
1985         (pascm_set_param_value_x): Update.
1986         * hppa-tdep.c (hppa_debug): Change to bool..
1987         * infcall.c (may_call_functions_p): Likewise.
1988         (coerce_float_to_double_p): Likewise.
1989         (unwind_on_signal_p): Likewise.
1990         (unwind_on_terminating_exception_p): Likewise.
1991         * infcmd.c (startup_with_shell): Likewise.
1992         * inferior.c (print_inferior_events): Likewise.
1993         * inferior.h (startup_with_shell): Likewise.
1994         (print_inferior_events): Likewise.
1995         * infrun.c (step_stop_if_no_debug): Likewise.
1996         (detach_fork): Likewise.
1997         (debug_displaced): Likewise.
1998         (disable_randomization): Likewise.
1999         (non_stop): Likewise.
2000         (non_stop_1): Likewise.
2001         (observer_mode): Likewise.
2002         (observer_mode_1): Likewise.
2003         (set_observer_mode): Update.
2004         (sched_multi): Change to bool.
2005         * infrun.h (debug_displaced): Likewise.
2006         (sched_multi): Likewise.
2007         (step_stop_if_no_debug): Likewise.
2008         (non_stop): Likewise.
2009         (disable_randomization): Likewise.
2010         * linux-tdep.c (use_coredump_filter): Likewise.
2011         (dump_excluded_mappings): Likewise.
2012         * linux-thread-db.c (auto_load_thread_db): Likewise.
2013         (check_thread_db_on_load): Likewise.
2014         * main.c (captured_main_1): Update.
2015         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2016         xx2_opt, boolean_opt>: Change to bool.
2017         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2018         * maint.c (maintenance_profile_p): Likewise.
2019         (per_command_time): Likewise.
2020         (per_command_space): Likewise.
2021         (per_command_symtab): Likewise.
2022         * memattr.c (inaccessible_by_default): Likewise.
2023         * mi/mi-main.c (mi_async): Likewise.
2024         (mi_async_1): Likewise.
2025         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2026         * nat/fork-inferior.h (startup_with_shell): Likewise.
2027         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2028         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2029         * nios2-tdep.c (nios2_debug): Likewise.
2030         * or1k-tdep.c (or1k_debug): Likewise.
2031         * parse.c (parser_debug): Likewise.
2032         * parser-defs.h (parser_debug): Likewise.
2033         * printcmd.c (print_symbol_filename): Likewise.
2034         * proc-api.c (procfs_trace): Likewise.
2035         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2036         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2037         (set_parameter_value): Update.
2038         (add_setshow_generic): Update.
2039         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2040         to bool*.
2041         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2042         int*.
2043         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2044         * record-btrace.c (record_btrace_target::store_registers): Update.
2045         * record-full.c (record_full_memory_query): Change to bool.
2046         (record_full_stop_at_limit): Likewise.
2047         * record-full.h (record_full_memory_query): Likewise.
2048         * remote-notif.c (notif_debug): Likewise.
2049         * remote-notif.h (notif_debug): Likewise.
2050         * remote.c (use_range_stepping): Likewise.
2051         (interrupt_on_connect): Likewise.
2052         (remote_break): Likewise.
2053         * ser-tcp.c (tcp_auto_retry): Likewise.
2054         * ser-unix.c (serial_hwflow): Likewise.
2055         * skip.c (debug_skip): Likewise.
2056         * solib-aix.c (solib_aix_debug): Likewise.
2057         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2058         (spu_auto_flush_cache_p): Likewise.
2059         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2060         Likewise.
2061         (struct info_print_options) <quiet>: Likewise.
2062         * symfile-debug.c (debug_symfile): Likewise.
2063         * symfile.c (auto_solib_add): Likewise.
2064         (separate_debug_file_debug): Likewise.
2065         * symfile.h (auto_solib_add): Likewise.
2066         (separate_debug_file_debug): Likewise.
2067         * symtab.c (basenames_may_differ): Likewise.
2068         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2069         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2070         (struct info_types_options) <quiet>: Likewise.
2071         * symtab.h (demangle): Likewise.
2072         (basenames_may_differ): Likewise.
2073         * target-dcache.c (stack_cache_enabled_1): Likewise.
2074         (code_cache_enabled_1): Likewise.
2075         * target.c (trust_readonly): Likewise.
2076         (may_write_registers): Likewise.
2077         (may_write_memory): Likewise.
2078         (may_insert_breakpoints): Likewise.
2079         (may_insert_tracepoints): Likewise.
2080         (may_insert_fast_tracepoints): Likewise.
2081         (may_stop): Likewise.
2082         (auto_connect_native_target): Likewise.
2083         (target_stop_and_wait): Update.
2084         (target_async_permitted): Change to bool.
2085         (target_async_permitted_1): Likewise.
2086         (may_write_registers_1): Likewise.
2087         (may_write_memory_1): Likewise.
2088         (may_insert_breakpoints_1): Likewise.
2089         (may_insert_tracepoints_1): Likewise.
2090         (may_insert_fast_tracepoints_1): Likewise.
2091         (may_stop_1): Likewise.
2092         * target.h (target_async_permitted): Likewise.
2093         (may_write_registers): Likewise.
2094         (may_write_memory): Likewise.
2095         (may_insert_breakpoints): Likewise.
2096         (may_insert_tracepoints): Likewise.
2097         (may_insert_fast_tracepoints): Likewise.
2098         (may_stop): Likewise.
2099         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2100         (make_thread_apply_all_options_def_group): Change argument from int*
2101         to bool*.
2102         (thread_apply_all_command): Update.
2103         (print_thread_events): Change to bool.
2104         * top.c (confirm): Likewise.
2105         (command_editing_p): Likewise.
2106         (history_expansion_p): Likewise.
2107         (write_history_p): Likewise.
2108         (info_verbose): Likewise.
2109         * top.h (confirm): Likewise.
2110         (history_expansion_p): Likewise.
2111         * tracepoint.c (disconnected_tracing): Likewise.
2112         (circular_trace_buffer): Likewise.
2113         * typeprint.c (print_methods): Likewise.
2114         (print_typedefs): Likewise.
2115         * utils.c (debug_timestamp): Likewise.
2116         (sevenbit_strings): Likewise.
2117         (pagination_enabled): Likewise.
2118         * utils.h (sevenbit_strings): Likewise.
2119         (pagination_enabled): Likewise.
2120         * valops.c (overload_resolution): Likewise.
2121         * valprint.h (struct value_print_options) <prettyformat_arrays,
2122         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2123         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2124         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2125         Likewise.
2126         * windows-nat.c (new_console): Likewise.
2127         (cygwin_exceptions): Likewise.
2128         (new_group): Likewise.
2129         (debug_exec): Likewise.
2130         (debug_events): Likewise.
2131         (debug_memory): Likewise.
2132         (debug_exceptions): Likewise.
2133         (useshell): Likewise.
2134         * windows-tdep.c (maint_display_all_tib): Likewise.
2135         * xml-support.c (debug_xml): Likewise.
2136
2137 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2138
2139         * source.c (prepare_path_for_appending): New function.
2140         (openp): Make use of new function.
2141         (find_and_open_source): Search for the compilation directory and
2142         source file as a relative path beneath the directory search path.
2143
2144 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2145
2146         * source-cache.c (source_cache::get_line_charpos): Catch
2147         exceptions and return false, this matches the behaviour documented
2148         in the header file.
2149
2150 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2151
2152         * ada-tasks.c (info_task): Remove quoting of the task's name.
2153
2154 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2155
2156         * symfile.c (auto_solib_add): Replace comment with a reference
2157         to the header file.
2158
2159 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2160
2161         * NEWS: Mention that gdb can now be compiled with Python 3
2162         on Windows.
2163
2164 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2165
2166         * maint.c (maint_print_section_data::maint_print_section_data):
2167         Force use of 'float log10 (float)' by casting the argument to
2168         float.
2169
2170 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2171
2172         * maint.c: Add 'cmath' include.
2173         (struct maint_print_section_data): New structure.
2174         (print_section_index): New function.
2175         (print_bfd_section_info): Add header comment, small whitespace
2176         cleanup, and update to call new print_section_index function.
2177         (print_objfile_section_info): Likewise.
2178         (maint_obj_section_from_bfd_section): New function.
2179         (print_bfd_section_info_maybe_relocated): New function.
2180         (maintenance_info_sections): Add header comment, always use
2181         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2182
2183 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2184
2185         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2186         inner scope, add check that the objfile has psymtabs before
2187         checking psymtabs_addrmap.
2188         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2189
2190 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2191
2192         * NEWS: Announce that Ada task names are now shown at more places,
2193         and between quotes (except in info task output).
2194         * gdb/ada-tasks.c (task_to_str): New function.
2195         (display_current_task_id): Call task_to_str.
2196         (task_command_1): Likewise.
2197         (print_ada_task_info): In non-mi mode, Properly align headers and data
2198         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2199
2200 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2201
2202         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2203         prstatus.pr_lwp.pr_info instead of making it up.
2204
2205 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2206
2207         * auto-load.c (auto_load_expand_dir_vars): Update.
2208         * defs.h (gdb_datadir): Change to std::string.
2209         (python_libdir): Likewise.
2210         (relocate_gdb_directory): Change return type to std::string.
2211         * guile/guile.c (gdbscm_data_directory): Update.
2212         (initialize_scheme_side): Update.
2213         * jit.c (jit_reader_dir): Change to std::string.
2214         (jit_reader_load_command): Update.
2215         * main.c (gdb_datadir): Change to std::string.
2216         (python_libdir): Likewise.
2217         (set_gdb_data_directory): Update.
2218         (relocate_path): Change to return std::string.
2219         (relocate_gdb_directory): Change to return std::string.
2220         (relocate_gdbinit_path_maybe_in_datadir): Update.
2221         (captured_main_1): Update.
2222         * python/python.c (do_start_initialization): Update.
2223         * top.c (show_gdb_datadir): Update.
2224         * xml-syscall.c (xml_init_syscalls_info): Update.
2225         (init_syscalls_info): Update.
2226
2227 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2228
2229         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2230         out of get_init_files.
2231         (get_init_files): Update.
2232
2233 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2234
2235         * main.c (get_init_files): Change to use std::string.
2236         (captured_main_1): Update.
2237         (print_gdb_help): Update.
2238
2239 2019-09-11  Ali Tamur  <tamur@google.com>
2240
2241         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2242         implementation.
2243
2244 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2245
2246         * dbxread.c (read_dbx_symtab): Update.
2247         * dwarf2read.c (load_partial_dies): Update.
2248         * mdebugread.c (parse_partial_symbols): Update.
2249         (handle_psymbol_enumerators): Update.
2250         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2251         * psymtab.c (add_psymbol_to_bcache): Likewise.
2252         (add_psymbol_to_list): Likewise.
2253         * symtab.c (symbol_set_names): Likewise.
2254         * symtab.h (symbol_set_names): Likewise.
2255         * xcoffread.c (scan_xcoff_symtab): Update.
2256
2257 2019-09-11  Tom Tromey  <tom@tromey.com>
2258
2259         * symfile-mem.c (symbol_file_add_from_memory): Use
2260         bfd_set_filename.
2261         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2262         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2263
2264 2019-09-10  Tom Tromey  <tromey@adacore.com>
2265
2266         * dwarf-index-write.c (write_psymbols): Extend error message.
2267         (debug_names::insert): Add Ada code.
2268         (debug_names::write_psymbols): Remove Ada check.
2269         (debug_names) <m_string_obstack>: New member.
2270         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2271         (gdb_index_symbol_name_matcher::matches): Remove.
2272         (mapped_index_base::find_name_components_bounds): Add "lang"
2273         parameter.
2274         (mapped_index_base::build_name_components): Also split names
2275         according to Ada syntax.
2276         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2277         type of "match_callback".
2278         (check_match, check_find_bounds_finds)
2279         (dw2_expand_symtabs_matching): Update.
2280         (dw2_debug_names_iterator): Add new constructor.
2281         (dw2_debug_names_map_matching_symbols): New function.
2282         (dw2_debug_names_expand_symtabs_matching): Update.
2283         (dwarf2_debug_names_functions): Use
2284         dw2_debug_names_map_matching_symbols.
2285
2286 2019-09-10  Tom Tromey  <tromey@adacore.com>
2287
2288         * dwarf2read.c (dw2_get_file_names_reader): Add the
2289         CU's file name to the results.
2290
2291 2019-09-10  Tom Tromey  <tromey@adacore.com>
2292
2293         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2294         map_matching_symbols.  Update.
2295         * dwarf2read.c (dw2_map_matching_symbols): Update.
2296         * psymtab.c (match_partial_symbol): Change type; update.
2297         (psym_map_matching_symbols): Likewise.
2298         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2299         type; update.
2300         * symfile.h (struct quick_symbol_functions)
2301         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2302         Remove "match".
2303
2304 2019-09-10  Tom Tromey  <tromey@adacore.com>
2305
2306         * psymtab.c (map_block): Remove.
2307         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2308         * symtab.c (iterate_over_symbols_terminated): New function.
2309         * symtab.c (iterate_over_symbols_terminated): Declare.
2310
2311 2019-09-10  Tom Tromey  <tromey@adacore.com>
2312
2313         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2314         * language.h (struct language_defn) <la_iterate_over_symbols>:
2315         Return bool.
2316         * symtab.c (iterate_over_symbols): Return bool.
2317         * symtab.h (iterate_over_symbols): Return bool.
2318
2319 2019-09-10  Tom Tromey  <tromey@adacore.com>
2320
2321         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2322         (add_nonlocal_symbols): Update.
2323         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2324         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2325         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2326         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2327         Change type of "callback".  Remove "data".
2328
2329
2330 2019-09-09  Ali Tamur  <tamur@google.com>
2331
2332         * dwarf2read.c (comp_unit_head): Update comment.
2333         (dwarf2_dwo_name): New function declaration.
2334         (dwarf_unit_type_name): New function declaration.
2335         (read_comp_unit_head): Add support for new compilation units,
2336         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2337         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2338         (currently named as "signature") in their header. Also clarify error
2339         messages.
2340         (lookup_dwo_id): New function. Returns the dwo id of the given
2341         compile unit.
2342         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2343         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2344         functions.
2345         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2346         (dwarf2_dwo_name): Get the dwo name if present.
2347         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2348         purposes.
2349
2350 2019-09-09  Tom Tromey  <tom@tromey.com>
2351
2352         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2353
2354 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2355
2356         * python/python.c (do_start_initialization): Make progname_copy static,
2357         to avoid a leak report.
2358
2359 2019-09-08  Tom Tromey  <tom@tromey.com>
2360
2361         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2362
2363 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2364
2365         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2366         Change type to gdb::optional<block_enum>.
2367         (dw2_symtab_iter_init): Change block_index parameter type
2368         to gdb::optional<block_enum>.
2369         (dw2_lookup_symbol): Change block_index parameter
2370         type to block_enum.c
2371         (dw2_debug_names_lookup_symbol): Likewise.
2372         * psymtab.c (psym_lookup_symbol): Likewise.
2373         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2374         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2375         Likewise.
2376
2377 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2378
2379         * defs.h (relocate_gdb_directory): Change int to bool in
2380         signature and rename flag to relocatable.
2381         * main.c (relocate_path): Likewise.
2382         (relocate_gdb_directory): Likewise.
2383
2384 2019-09-06  Alan Modra  <amodra@gmail.com>
2385
2386         * coffread.c (coff_symfile_read): Constify filename variable.
2387         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2388         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2389         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2390         * solib.c (reload_shared_libraries_1): Likewise.
2391         * symfile.c (reread_symbols): Likewise.
2392         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2393         * solib-darwin.c (darwin_bfd_open): Likewise.
2394         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2395
2396 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2397
2398         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2399         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2400
2401 2019-09-03  Tom Tromey  <tromey@adacore.com>
2402
2403         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2404         types.
2405         (has_negatives): Unbias a range type bound.
2406         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2407         * gdbtypes.c (operator==): Handle new field.
2408         (create_range_type): Add "bias" parameter.
2409         (create_static_range_type, resolve_dynamic_range): Update.
2410         * gdbtypes.h (struct range_bounds) <bias>: New member.
2411         (create_range_type): Add bias parameter.
2412         * printcmd.c (print_scalar_formatted): Unbias range types.
2413         * value.c (unpack_long): Unbias range types.
2414         (pack_long): Bias range types.
2415
2416 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2417
2418         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2419         probe arguments.
2420
2421 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2422
2423         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2424         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2425         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2426         (compile_probe_arg): Likewise.
2427         * probe.h (get_argument_count): Likewise.
2428         * solib-svr4.c (solib_event_probe_action): Likewise.
2429         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2430
2431 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2432
2433         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2434         code to here...
2435         (svr4_create_solib_event_breakpoints): ...from here.
2436
2437 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2438
2439         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2440         suffix from warning message.
2441
2442 2019-08-30  Tom Tromey  <tom@tromey.com>
2443
2444         * tui/tui-winsource.h (struct tui_source_window_base)
2445         <refresh_all>: Don't declare.
2446         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2447         Remove.
2448         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2449         tui_show_locator_content.
2450         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2451         declare.
2452         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2453         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2454         declare.
2455
2456 2019-08-30  Tom Tromey  <tom@tromey.com>
2457
2458         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2459
2460 2019-08-30  Tom Tromey  <tom@tromey.com>
2461
2462         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2463         Remove unnecessary forward declarations.
2464
2465 2019-08-30  Tom Tromey  <tom@tromey.com>
2466
2467         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2468         rerender.
2469         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2470         tui_show_locator_content.
2471
2472 2019-08-30  Tom Tromey  <tom@tromey.com>
2473
2474         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2475         (tui_locator_window::rerender): Rewrite using body of previous
2476         tui_show_locator_content.
2477
2478 2019-08-30  Tom Tromey  <tom@tromey.com>
2479
2480         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2481         set_locator_fullname>: New methods.
2482         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2483         Rename from tui_set_locator_fullname.
2484         (tui_locator_window::set_locator_info): Rename from
2485         tui_set_locator_info.  Return bool.
2486         (tui_update_locator_fullname, tui_show_frame_info): Update.
2487
2488 2019-08-30  Tom Tromey  <tom@tromey.com>
2489
2490         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2491
2492 2019-08-30  Tom Tromey  <tom@tromey.com>
2493
2494         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2495         call touchwin.
2496
2497 2019-08-30  Tom Tromey  <tom@tromey.com>
2498
2499         * tui/tui-wingeneral.c (box_win): Assume win_info and
2500         win_info->handle cannot be NULL.
2501
2502 2019-08-30  Tom Tromey  <tom@tromey.com>
2503
2504         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2505         refresh_window>: Declare.
2506         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2507         resize.
2508         (tui_data_item_window::rerender): Rename from
2509         tui_display_register.
2510         (tui_data_item_window::refresh_window): New method.
2511         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2512         no-op.
2513
2514 2019-08-30  Tom Tromey  <tom@tromey.com>
2515
2516         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2517         regs_column_count, current_group>: Move later.  Now private.
2518         <get_current_group>: New method.
2519         * tui/tui-regs.c (tui_reg_command): Update.
2520         * tui/tui-layout.c (tui_set_layout): Update.
2521
2522 2019-08-30  Tom Tromey  <tom@tromey.com>
2523
2524         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2525         (tui_data_window::rerender): Don't call
2526         check_and_display_highlight_if_needed.
2527         (tui_data_window::refresh_all): Remove call to
2528         erase_data_content.
2529
2530 2019-08-30  Tom Tromey  <tom@tromey.com>
2531
2532         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2533         (tui_data_window::display_registers_from)
2534         (tui_data_window::display_reg_element_at_line)
2535         (tui_data_window::display_registers_from_line): Remove checks of
2536         "empty".
2537
2538 2019-08-30  Tom Tromey  <tom@tromey.com>
2539
2540         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2541         Don't declare.
2542         * tui/tui-regs.c (tui_data_window::show_registers): Call
2543         rerender.
2544         (tui_data_window::rerender): Rename from display_all_data.
2545         (tui_data_window::rerender): Remove old implementation.
2546
2547 2019-08-30  Tom Tromey  <tom@tromey.com>
2548
2549         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2550         text.
2551         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2552
2553 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2554             Sergio Durigan Junior  <sergiodj@redhat.com>
2555
2556         PR win32/24284
2557         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2558
2559 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2560
2561         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2562         when searching for types.
2563
2564 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2565
2566         * f-lang.c (f_language_defn): Use f_print_typedef.
2567         * f-lang.h (f_print_typedef): Declare.
2568         * f-typeprint.c (f_print_typedef): Define.
2569
2570 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2571
2572         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2573
2574 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2575
2576         * cli/cli-utils.c (info_print_options_defs): Delete.
2577         (make_info_print_options_def_group): Delete.
2578         (extract_info_print_options): Delete.
2579         (info_print_command_completer): Delete.
2580         (info_print_args_help): Add extra parameter, and optionally
2581         include text about -n flag.
2582         * cli/cli-utils.h (struct info_print_options): Delete.
2583         (extract_info_print_options): Delete declaration.
2584         (info_print_command_completer): Delete declaration.
2585         (info_print_args_help): Add extra parameter, extend header
2586         comment.
2587         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2588         search_symbols.
2589         * stack.c (struct info_print_options): New type.
2590         (info_print_options_defs): New file scoped variable.
2591         (make_info_print_options_def_group): New static function.
2592         (info_print_command_completer): New static function.
2593         (info_locals_command): Update to use new local functions.
2594         (info_args_command): Likewise.
2595         (_initialize_stack): Add extra parameter to calls to
2596         info_print_args_help.
2597         * symtab.c (search_symbols): Add extra parameter, use this to
2598         possibly excluse non-debug symbols.
2599         (symtab_symbol_info): Add extra parameter, which is passed on to
2600         search_symbols.
2601         (struct info_print_options): New type.
2602         (info_print_options_defs): New file scoped variable.
2603         (make_info_print_options_def_group): New static function.
2604         (info_print_command_completer): New static function.
2605         (info_variables_command): Update to use local functions, and pass
2606         extra parameter through to symtab_symbol_info.
2607         (info_functions_command): Likewise.
2608         (info_types_command): Pass additional argument through to
2609         symtab_symbol_info.
2610         (rbreak_command): Pass extra argument to search_symbols.
2611         (_initialize_symtab): Add extra arguments for calls to
2612         info_print_args_help, and update help text for 'info variables',
2613         'whereis', and 'info functions' commands.
2614         * symtab.h (search_symbols): Add extra argument to declaration.
2615         * NEWS: Mention new flags.
2616
2617 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2618
2619         * symtab.c (lookup_static_symbol): Call the new function (and move
2620         it down to be next to lookup_global_symbol).
2621         (struct global_sym_lookup_data): Add block_enum member and rename to...
2622         (struct global_or_static_sym_lookup_data): ...this.
2623         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2624         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2625         (lookup_symbol_global_or_static_iterator_cb): ...this.
2626         (lookup_global_or_static_symbol): New function.
2627         (lookup_global_symbol): Call new function.
2628
2629 2019-08-26  Tom de Vries  <tdevries@suse.de>
2630
2631         PR c++/24852
2632         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2633         when pc_probe.prob == NULL.
2634
2635 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2636
2637         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2638         variable symbol_linkage to symbol_linkage_.
2639
2640 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2641
2642         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2643         represent whether the symbol is static, dynamic, or we don't
2644         know.
2645
2646 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2647
2648         * gdb/rx-tdep.c (rx_register_names): New.
2649         (rx_register_name): Delete.
2650         (rx_psw_type): Delete.
2651         (rx_fpsw_type): Delete.
2652         (rx_register_type): Delete.
2653         (rx_gdbarch_init): Convert target-descriptions.
2654         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2655         * gdb/features/Makefile: Add rx.xml.
2656         * gdb/features/rx.xml: New.
2657         * gdb/features/rx.c: Generated.
2658         * gdb/NEWS: Mention target description support.
2659
2660 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2661
2662         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2663         *slot_ptr.
2664
2665 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2666
2667         * configure.ac: Don't check for 'dlfcn.h' (moved to
2668         gdbsupport/common.m4).
2669         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2670         'gdbsupport/'.
2671         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2672         * compile/compile-c-support.c: Include
2673         'gdbsupport/gdb-dlfcn.h'.
2674         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2675         * gdb-dlfcn.c: Move to...
2676         * gdbsupport/gdb-dlfcn.c: ... here.
2677         * gdb-dlfcn.h: Move to...
2678         * gdbsupport/gdb-dlfcn.h: ... here.
2679
2680 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2681
2682         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2683         the offset field signed.
2684
2685 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2686
2687         * python/lib/gdb/__init__.py (_execute_file): New function.
2688         * python/python.c (python_run_simple_file): Call gdb._execute_file
2689         on Windows.
2690
2691 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2692
2693         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2694         all uses as this was never set to anything but a zero value.
2695
2696 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2697
2698         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2699
2700 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2701
2702         * tui/tui-data.h (tui_gen_win_info): Add an =default
2703         move constructor, required by some GCC versions.
2704
2705 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2706
2707         * go32-nat.c (go32_sysinfo): Add hygon_p.
2708
2709 2019-08-20  Tom Tromey  <tom@tromey.com>
2710
2711         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2712         line_from_reg_element_no, first_reg_element_no_inline,
2713         display_all_data, delete_data_content_windows,
2714         erase_data_content>: Now private.
2715
2716 2019-08-20  Tom Tromey  <tom@tromey.com>
2717
2718         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2719         (tui_unhighlight_win, tui_highlight_win)
2720         (tui_win_info::make_window): Update.
2721         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2722
2723 2019-08-20  Tom Tromey  <tom@tromey.com>
2724
2725         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2726         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2727         (MAX_PID_WIDTH): Move to tui-stack.c.
2728         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2729         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2730         (MAX_PID_WIDTH): Move from tui-data.h.
2731
2732 2019-08-20  Tom Tromey  <tom@tromey.com>
2733
2734         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2735         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2736         (box_win): Update.
2737         (tui_gen_win_info::make_window): Rename from tui_make_window.
2738         (tui_win_info::make_window): New method.
2739         (tui_gen_win_info::make_visible): Update.
2740         * tui/tui-source.c (tui_source_window::set_contents): Update.
2741         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2742         (tui_data_window::display_registers_from): Update.
2743         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2744         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2745         Declare.
2746         <can_box>: Remove.
2747         <title>: Remove.
2748         (struct tui_win_info) <make_window>: Declare.
2749         <can_box>: Now virtual.
2750         <title>: New member.
2751         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2752         * tui/tui-command.c (tui_cmd_window::resize): Update.
2753
2754 2019-08-20  Tom Tromey  <tom@tromey.com>
2755
2756         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2757         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2758         (tui_data_window::check_register_values): Update.
2759
2760 2019-08-20  Tom Tromey  <tom@tromey.com>
2761
2762         * tui/tui-regs.h (struct tui_data_window): Use
2763         DISABLE_COPY_AND_ASSIGN.
2764         <regs_content>: Change type, removing unique_ptr.
2765         <tui_data_window>: Add move constructor.
2766         * tui/tui-regs.c (tui_data_window::show_registers)
2767         (tui_data_window::show_register_group)
2768         (tui_data_window::display_registers_from)
2769         (tui_data_window::display_registers_from)
2770         (tui_data_window::first_data_item_displayed)
2771         (tui_data_window::delete_data_content_windows)
2772         (tui_data_window::rerender, tui_data_window::refresh_window)
2773         (tui_data_window::check_register_values): Update.
2774
2775 2019-08-20  Tom Tromey  <tom@tromey.com>
2776
2777         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2778         show_register_group>: Declare.
2779         (tui_show_register_group): Don't declare.
2780         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2781         tui_show_registers.
2782         (tui_data_window::show_register_group): Rename from
2783         tui_show_register_group.
2784         (tui_data_window::check_register_values, tui_reg_command):
2785         Update.
2786         * tui/tui-layout.c (tui_set_layout): Update.
2787
2788 2019-08-20  Tom Tromey  <tom@tromey.com>
2789
2790         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2791         Declare.
2792         (tui_check_register_values): Don't declare.
2793         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2794         from tui_check_register_values.
2795         * tui/tui-hooks.c (tui_register_changed): Update.
2796
2797 2019-08-20  Tom Tromey  <tom@tromey.com>
2798
2799         * tui/tui-regs.c (tui_reg_layout): Move later.
2800         (tui_show_registers): Don't enable TUI mode or change layout.
2801
2802 2019-08-20  Tom Tromey  <tom@tromey.com>
2803
2804         * tui/tui-regs.h (struct tui_data_item_window)
2805         <~tui_data_item_window>: Remove.
2806         <content>: Now a unique_xmalloc_ptr.
2807         * tui/tui-regs.c (tui_register_format): Return a
2808         unique_xmalloc_ptr.
2809         (tui_get_register): Update.
2810         (~tui_data_item_window): Remove.
2811         (tui_data_window::display_registers_from, tui_display_register):
2812         Update.
2813         * tui/tui-io.h (tui_expand_tabs): Update.
2814         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2815         Remove "col" parameter.
2816
2817 2019-08-20  Tom Tromey  <tom@tromey.com>
2818
2819         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2820         field.
2821         * tui/tui-regs.c (~tui_data_item_window): Update.
2822
2823 2019-08-20  Tom Tromey  <tom@tromey.com>
2824
2825         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2826         earlier.
2827
2828 2019-08-20  Tom Tromey  <tom@tromey.com>
2829
2830         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2831
2832 2019-08-20  Tom Tromey  <tom@tromey.com>
2833
2834         * tui/tui-source.h (struct tui_source_window): Update.
2835         * tui/tui-regs.c (tui_show_registers): Update.
2836         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2837         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2838         (NO_REGS_STRING): Remove defines.
2839
2840 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2841
2842         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2843         unnecessary thread walk if remote doesn't support the packet.
2844
2845 2019-08-19  Tom Tromey  <tromey@adacore.com>
2846
2847         * python/py-value.c (value_has_field): Fix indentation.
2848
2849 2019-08-19  Tom Tromey  <tromey@adacore.com>
2850
2851         * printcmd.c (do_one_display, info_display_command): Update.
2852         * block.h (contained_in): Return bool.  Add allow_nested
2853         parameter.
2854         * block.c (contained_in): Return bool.  Add allow_nested
2855         parameter.
2856
2857 2019-08-19  Tom Tromey  <tom@tromey.com>
2858
2859         * configure: Rebuild.
2860         * configure.ac: Disallow the combination of -static-libstdc++ and
2861         source highlight.
2862         * source-cache.c (get_language_name): Handle rust.
2863         (source_cache::get_source_lines): Ignore highlighting exceptions.
2864
2865 2019-08-16  Tom Tromey  <tom@tromey.com>
2866
2867         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2868         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2869         (struct tui_source_window_base) <make_visible, refresh_window,
2870         resize>: Remove methods.
2871         <execution_info>: Remove field.
2872         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2873         (tui_show_source_line, tui_source_window_base)
2874         (~tui_source_window_base): Update.
2875         (tui_source_window_base::resize)
2876         (tui_source_window_base::make_visible)
2877         (tui_source_window_base::refresh_window): Remove.
2878         (tui_source_window_base::update_exec_info): Update.
2879         * tui/tui-source.c (tui_source_window::set_contents): Update.
2880         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2881
2882 2019-08-16  Tom Tromey  <tom@tromey.com>
2883
2884         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2885         deprecated_query_hook.
2886
2887 2019-08-16  Tom Tromey  <tom@tromey.com>
2888
2889         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2890         (tui_update_source_windows_with_line): Update.
2891         * tui/tui-source.h (struct tui_source_window)
2892         <show_symtab_source>: Declare.
2893         (tui_show_symtab_source): Don't declare.
2894         * tui/tui-source.c (tui_show_symtab_source): Rename from
2895         tui_show_symtab_source.
2896
2897 2019-08-16  Tom Tromey  <tom@tromey.com>
2898
2899         * tui/tui-winsource.h (struct tui_source_window_base)
2900         <set_contents>: Declare.
2901         * tui/tui-winsource.c
2902         (tui_source_window_base::update_source_window_as_is): Update.
2903         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2904         Declare.
2905         (tui_set_source_content): Don't declare.
2906         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2907         tui_set_source_content.
2908         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2909         Declare.
2910         (tui_set_disassem_content): Don't declare.
2911         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2912         tui_set_disassem_content.
2913
2914 2019-08-16  Tom Tromey  <tom@tromey.com>
2915
2916         * tui/tui-winsource.h (struct tui_source_window_base)
2917         <update_breakpoint_info>: Declare.
2918         (tui_update_breakpoint_info): Don't declare.
2919         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2920         (tui_update_all_breakpoint_info): Update.
2921         (tui_source_window_base::update_breakpoint_info): Rename from
2922         tui_update_breakpoint_info.
2923         (tui_source_window_base::update_exec_info): Update.
2924
2925 2019-08-16  Tom Tromey  <tom@tromey.com>
2926
2927         * tui/tui-winsource.h (struct tui_source_window_base)
2928         <update_source_window>: Declare.
2929         (tui_update_source_window): Don't declare.
2930         * tui/tui-winsource.c
2931         (tui_source_window_base::update_source_window): Rename from
2932         tui_update_source_window.
2933         (tui_source_window_base::rerender): Update.
2934         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2935         * tui/tui-disasm.c (tui_show_disassem)
2936         (tui_show_disassem_and_update_source)
2937         (tui_disasm_window::maybe_update): Update.
2938
2939 2019-08-16  Tom Tromey  <tom@tromey.com>
2940
2941         * tui/tui-winsource.h (struct tui_source_window_base)
2942         <update_source_window_as_is>: Declare.
2943         (tui_update_source_window_as_is): Don't declare.
2944         * tui/tui-winsource.c (tui_update_source_window): Update
2945         (tui_source_window_base::update_source_window_as_is): Rename from
2946         tui_update_source_window_as_is.
2947         (tui_source_window_base::refill): Update.
2948         * tui/tui-source.c (tui_show_symtab_source): Update.
2949         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2950         Update.
2951
2952 2019-08-16  Tom Tromey  <tom@tromey.com>
2953
2954         * tui/tui-winsource.h (tui_update_source_window)
2955         (tui_update_source_window_as_is): Remove "noerror" parameter.
2956         * tui/tui-winsource.c (tui_update_source_window)
2957         (tui_update_source_window_as_is): Remove "noerror" parameter.
2958         (tui_update_source_windows_with_addr)
2959         (tui_update_source_windows_with_line)
2960         (tui_source_window_base::rerender)
2961         (tui_source_window_base::refill): Update.
2962         * tui/tui-source.h (tui_set_source_content)
2963         (tui_show_symtab_source): Remove "noerror" parameter.
2964         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2965         parameter.
2966         (tui_show_symtab_source): Likewise.
2967         (tui_source_window::maybe_update): Update.
2968         * tui/tui-disasm.c (tui_show_disassem)
2969         (tui_show_disassem_and_update_source)
2970         (tui_disasm_window::do_scroll_vertical)
2971         (tui_disasm_window::maybe_update): Update.
2972
2973 2019-08-16  Tom Tromey  <tom@tromey.com>
2974
2975         * tui/tui.c (tui_is_window_visible): Update.
2976         * tui/tui-wingeneral.c (tui_make_window)
2977         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2978         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2979         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2980         (tui_set_win_height_command, parse_scrolling_args): Update.
2981         * tui/tui-source.c (tui_source_window::style_changed): Update.
2982         * tui/tui-regs.c (tui_show_registers)
2983         (tui_data_window::first_data_item_displayed)
2984         (tui_data_window::delete_data_content_windows)
2985         (tui_check_register_values, tui_reg_command): Update.
2986         * tui/tui-disasm.c (tui_show_disassem): Update.
2987         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2988         method.
2989         <is_visible>: Remove field.
2990         * tui/tui-data.c (tui_next_win, tui_prev_win)
2991         (tui_delete_invisible_windows): Update.
2992
2993 2019-08-16  Tom Tromey  <tom@tromey.com>
2994
2995         * tui/tui-winsource.h (struct tui_source_window_base)
2996         <m_has_locator>: Remove.
2997         * tui/tui-layout.c (show_source_disasm_command, show_data)
2998         (show_source_or_disasm_and_command): Update.
2999
3000 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3001
3002         * NEWS (Other MI changes): New subsection.
3003         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3004         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3005         * arch-utils.c (default_get_pc_address_flags): New function.
3006         * arch-utils.h (default_get_pc_address_flags): New declaration.
3007         * gdbarch.sh: Add get_pc_address_flags.
3008         * gdbarch.c: Regenerate.
3009         * gdbarch.h: Likewise.
3010         * stack.c (print_pc): New function.
3011         (print_frame_info) (print_frame): Call print_pc.
3012
3013 2019-08-16  Tom de Vries  <tdevries@suse.de>
3014
3015         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3016         print_objfile_section_info.
3017
3018 2019-08-15  Tom Tromey  <tom@tromey.com>
3019
3020         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3021         calling update_cmdwin_start_line.
3022         * tui/tui-winsource.h (struct tui_source_window_base)
3023         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3024         <rerender>: Declare.
3025         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3026         Call rerender.
3027         (tui_source_window_base::set_new_height): Remove.
3028         (tui_source_window_base::rerender): Rename from
3029         do_make_visible_with_new_height.
3030         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3031         resize method.
3032         (tui_win_info::make_invisible_and_set_new_height)
3033         (tui_win_info::make_visible_with_new_height): Remove.
3034         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3035         Declare.
3036         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3037         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3038         do_make_visible_with_new_height>: Don't declare.
3039         <rerender>: Declare.
3040         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3041         set_new_height.
3042         (tui_data_window::do_make_visible_with_new_height): Remove.
3043         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3044         call tui_show_locator_content.
3045         (tui_gen_win_info::resize): Call rerender.
3046         (show_source_or_disasm_and_command): Don't call
3047         tui_show_locator_content.
3048         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3049         method.
3050         (struct tui_win_info) <rerender>: Declare.
3051         <set_new_height, make_invisible_and_set_new_height,
3052         make_visible_with_new_height>: Don't declare.
3053         * tui/tui-data.c (tui_win_list::rerender): New method.
3054         * tui/tui-command.h (struct tui_cmd_window)
3055         <do_make_visible_with_new_height>: Don't declare.
3056         * tui/tui-command.c
3057         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3058
3059 2019-08-15  Tom Tromey  <tromey@adacore.com>
3060
3061         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3062         * ada-lang.c (ada_enum_name): Likewise.
3063
3064 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3065
3066         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3067         leading underscore.
3068         (GdbOutputErrorFile): Likewise.
3069         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3070         accordingly.
3071         (execute_unwinders): Rename to have a leading underscore.
3072         (auto_load_packages): Likewise.
3073         (global scope): Adjust call to auto_load_packages accordingly.
3074         (GdbSetPythonDirectory): Likewise.
3075         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3076         instead of execute_unwinders.
3077
3078 2019-08-15  Tom Tromey  <tom@tromey.com>
3079
3080         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3081         (show_data): Don't change window visibility.
3082         (tui_gen_win_info::resize): Remove special case for command
3083         window.  Use wresize, when available.
3084         (show_source_or_disasm_and_command): Don't change window
3085         visibility.
3086         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3087         <make_visible>: New method.
3088         * tui/tui-command.c (tui_cmd_window::resize): New method.
3089
3090 2019-08-15  Tom Tromey  <tom@tromey.com>
3091
3092         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3093         (struct tui_source_windows): New.
3094         * tui/tui-winsource.c (tui_display_main): Update.
3095         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3096         (new_height_ok, parse_scrolling_args): Update.
3097         * tui/tui-layout.c (show_layout, show_data): Update.
3098         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3099         (tui_add_to_source_windows): Don't declare.
3100         * tui/tui-data.c (source_windows, tui_source_windows)
3101         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3102
3103 2019-08-15  Tom Tromey  <tom@tromey.com>
3104
3105         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3106         Rename from reset.
3107         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3108         * tui/tui-layout.c (show_source_disasm_command, show_data):
3109         Update.
3110         (tui_gen_win_info::resize): Rename.
3111         (show_source_or_disasm_and_command): Update.
3112         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3113         reset.
3114
3115 2019-08-15  Tom Tromey  <tom@tromey.com>
3116
3117         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3118         * tui/tui-interp.c (tui_interp::init): Don't call
3119         tui_initialize_static_data.
3120         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3121
3122 2019-08-15  Tom Tromey  <tom@tromey.com>
3123
3124         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3125         examine tui_win_list.
3126
3127 2019-08-15  Tom Tromey  <tom@tromey.com>
3128
3129         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3130         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3131         tui_clear_source_content.
3132         (tui_clear_source_content): Remove.
3133         (tui_source_window_base::do_erase_source_content): Hoist call to
3134         content.clear().
3135         * tui/tui-stack.c (tui_show_frame_info): Don't call
3136         tui_clear_source_content.
3137
3138 2019-08-15  Tom Tromey  <tom@tromey.com>
3139
3140         * tui/tui-winsource.h (struct tui_source_window_base)
3141         <do_erase_source_content>: New method.
3142         <erase_source_content>: New method.
3143         (tui_erase_source_content): Don't declare.
3144         * tui/tui-winsource.c (tui_clear_source_content): Update.
3145         (tui_source_window_base::do_erase_source_content): Rename from
3146         tui_erase_source_content.
3147         (tui_source_window_base::show_source_content): Update.
3148         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3149         * tui/tui-source.h (struct tui_source_window)
3150         <erase_source_content>: New method.
3151         * tui/tui-disasm.h (struct tui_disasm_window)
3152         <erase_source_content>: New method.
3153
3154 2019-08-15  Tom Tromey  <tom@tromey.com>
3155
3156         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3157         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3158         constructor.
3159         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3160         * tui/tui-source.c (tui_set_source_content): Update.
3161         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3162
3163 2019-08-15  Tom Tromey  <tom@tromey.com>
3164
3165         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3166         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3167         tui-source.c.
3168         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3169         Declare.
3170         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3171         method.
3172         (tui_source_window::maybe_update): Update.
3173
3174 2019-08-15  Tom Tromey  <tom@tromey.com>
3175
3176         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3177         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3178         tui-disasm.c.
3179         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3180         Declare.
3181         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3182         method.
3183         (tui_disasm_window::maybe_update): Update.
3184
3185 2019-08-15  Tom Tromey  <tom@tromey.com>
3186
3187         * tui/tui-winsource.h (struct tui_source_window_base)
3188         <maybe_update>: Declare.
3189         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3190         method.
3191         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3192         Declare.
3193         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3194         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3195         Declare.
3196         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3197
3198 2019-08-15  Tom Tromey  <tom@tromey.com>
3199
3200         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3201
3202 2019-08-15  Tom Tromey  <tom@tromey.com>
3203
3204         * tui/tui-wingeneral.c: Include tui-stack.h.
3205         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3206         (struct tui_locator_window): Move from tui-data.h.
3207         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3208         (tui_initialize_static_data): Move from tui-data.c.
3209         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3210         (struct tui_locator_window): Move to tui-stack.c.
3211         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3212         (tui_initialize_static_data): Move to tui-stack.c.
3213
3214 2019-08-15  Tom Tromey  <tom@tromey.com>
3215
3216         * tui/tui-layout.c (show_source_disasm_command)
3217         (show_source_or_disasm_and_command): Use make_visible method, not
3218         tui_make_window.
3219         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3220         Remove.
3221
3222 2019-08-15  Tom Tromey  <tom@tromey.com>
3223
3224         * tui/tui-wingeneral.h (tui_make_window): Update.
3225         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3226         parameter.
3227         (tui_gen_win_info::make_visible): Update.
3228         * tui/tui-regs.c (tui_data_window::display_registers_from):
3229         Update.
3230         * tui/tui-layout.c (show_source_disasm_command)
3231         (show_source_or_disasm_and_command): Update.
3232         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3233         (enum tui_box): Remove.
3234         (struct tui_win_info) <can_box>: New method.
3235         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3236         method.
3237
3238 2019-08-15  Tom de Vries  <tdevries@suse.de>
3239
3240         * linux-nat-trad.c: Include gdbarch.h.
3241
3242 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3243
3244         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3245         register sizes.
3246
3247 2019-08-14  Tom Tromey  <tromey@adacore.com>
3248
3249         * darwin-nat.c: Include gdbarch.h.
3250         * darwin-nat-info.c: Include gdbarch.h.
3251
3252 2019-08-13  Tom Tromey  <tom@tromey.com>
3253
3254         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3255         Remove.
3256         * tui/tui-data.c (tui_initialize_static_data): Update.
3257
3258 2019-08-13  Tom Tromey  <tom@tromey.com>
3259
3260         * tui/tui-winsource.h (struct tui_exec_info_window)
3261         <~tui_exec_info_window, maybe_allocate_content, get_content,
3262         m_content>: Remove.
3263         (struct tui_source_window_base) <set_exec_info_content,
3264         show_exec_info_content>: Don't declare.
3265         * tui/tui-winsource.c
3266         (tui_exec_info_window::maybe_allocate_content): Remove.
3267         (tui_source_window_base::update_exec_info): Rename from
3268         set_exec_info_content.
3269         (tui_source_window_base::show_exec_info_content)
3270         (tui_source_window_base::update_exec_info): Remove.
3271
3272 2019-08-13  Tom Tromey  <tom@tromey.com>
3273
3274         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3275         declare.
3276         * tui/tui-winsource.c (tui_update_source_window_as_is)
3277         (tui_update_source_windows_with_addr, tui_erase_source_content):
3278         Update.
3279         (tui_clear_exec_info_content): Remove.
3280
3281 2019-08-13  Tom Tromey  <tom@tromey.com>
3282
3283         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3284         declare.
3285         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3286         call tui_erase_exec_info_content.
3287         (tui_clear_exec_info_content): Rename from
3288         tui_erase_exec_info_content.
3289         (tui_clear_exec_info_content): Delete.
3290
3291 2019-08-13  Tom Tromey  <tom@tromey.com>
3292
3293         * tui/tui-winsource.h (struct tui_source_window_base)
3294         <show_exec_info_content>: Declare.
3295         (tui_show_exec_info_content): Don't declare.
3296         * tui/tui-winsource.c
3297         (tui_source_window_base::show_exec_info_content): Rename from
3298         tui_show_exec_info_content.
3299         (tui_source_window_base::update_exec_info): Update.
3300
3301 2019-08-13  Tom Tromey  <tom@tromey.com>
3302
3303         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3304         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3305         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3306         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3307         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3308         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3309         ... here.
3310
3311 2019-08-13  Tom Tromey  <tom@tromey.com>
3312
3313         * tui/tui-winsource.h (struct tui_source_window_base)
3314         <update_exec_info>: Declare.
3315         (tui_update_exec_info): Don't declare.
3316         * tui/tui-winsource.c (tui_update_source_window_as_is)
3317         (tui_source_window_base::refresh_all)
3318         (tui_update_all_breakpoint_info): Update.
3319         (tui_source_window_base::update_exec_info): Rename from
3320         tui_update_exec_info.
3321         * tui/tui-stack.c (tui_show_frame_info): Update.
3322
3323 2019-08-13  Tom Tromey  <tom@tromey.com>
3324
3325         * tui/tui-winsource.h (struct tui_source_window_base)
3326         <set_exec_info_content>: Declare.
3327         (tui_set_exec_info_content): Don't declare.
3328         * tui/tui-winsource.c
3329         (tui_source_window_base::set_exec_info_content): Rename from
3330         tui_set_exec_info_content.
3331         (tui_update_exec_info): Update.
3332
3333 2019-08-13  Tom Tromey  <tom@tromey.com>
3334
3335         * tui/tui-winsource.h (struct tui_source_window_base)
3336         <show_source_content>: Declare.
3337         (tui_show_source_content): Don't declare.
3338         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3339         (tui_source_window_base::show_source_content): Rename from
3340         tui_show_source_content.
3341         (tui_source_window_base::refresh_all): Update.
3342         * tui/tui-layout.c (show_source_disasm_command)
3343         (show_source_or_disasm_and_command): Update.
3344
3345 2019-08-13  Tom Tromey  <tom@tromey.com>
3346
3347         * tui/tui-winsource.c (tui_erase_source_content)
3348         (tui_show_source_content, tui_source_window_base::refresh_all):
3349         Update.
3350         * tui/tui-wingeneral.h
3351         (tui_check_and_display_highlight_if_needed): Don't declare.
3352         * tui/tui-wingeneral.c
3353         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3354         check_and_display_highlight_if_needed.
3355         * tui/tui-win.c (tui_rehighlight_all)
3356         (tui_win_info::make_visible_with_new_height): Update.
3357         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3358         (tui_data_window::erase_data_content)
3359         (tui_data_window::display_all_data): Update.
3360         * tui/tui-data.h (struct tui_win_info)
3361         <check_and_display_highlight_if_needed>: Declare.
3362
3363 2019-08-13  Tom Tromey  <tom@tromey.com>
3364
3365         * tui/tui-win.c (tui_resize_all): Call
3366         tui_delete_invisible_windows.
3367         * tui/tui-layout.c (show_layout): Call
3368         tui_delete_invisible_windows.
3369         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3370         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3371
3372 2019-08-13  Tom Tromey  <tom@tromey.com>
3373
3374         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3375         tui_add_win_to_layout.
3376
3377 2019-08-13  Tom Tromey  <tom@tromey.com>
3378
3379         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3380         * tui/tui-layout.c (tui_default_win_height): Now static.
3381
3382 2019-08-13  Tom Tromey  <tom@tromey.com>
3383
3384         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3385         single switch.
3386         (show_source_disasm_command, show_source_or_disasm_and_command):
3387         Don't check current layout.
3388
3389 2019-08-13  Tom Tromey  <tom@tromey.com>
3390
3391         * tui/tui-wingeneral.c (make_all_visible): Remove.
3392         (tui_make_all_invisible): Simplify.
3393         * tui/tui-layout.c (tui_make_all_invisible): Move from
3394         tui-wingeneral.c; simplify.
3395         (show_layout): Hoist call to tui_make_all_invisible.
3396         (show_data): Don't call tui_make_all_invisible.
3397
3398 2019-08-13  Tom Tromey  <tom@tromey.com>
3399
3400         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3401         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3402
3403 2019-08-13  Tom Tromey  <tom@tromey.com>
3404
3405         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3406         tui-data.c.
3407         (show_source_disasm_command, show_data)
3408         (show_source_or_disasm_and_command): Don't use
3409         tui_set_current_layout_to.
3410         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3411         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3412         tui-layout.c.
3413         (tui_set_current_layout_to): Remove.
3414
3415 2019-08-13  Tom Tromey  <tom@tromey.com>
3416
3417         * tui/tui-layout.c (tui_set_layout): Update.
3418         * tui/tui-data.h (struct tui_layout_def): Remove.
3419         (tui_layout_def): Don't declare.
3420         * tui/tui-data.c (layout_def): Remove.
3421         (tui_layout_def): Remove.
3422
3423 2019-08-13  Tom Tromey  <tom@tromey.com>
3424
3425         * tui/tui-winsource.h (struct tui_source_window_base)
3426         <clear_detail>: No longer "override".
3427         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3428         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3429         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3430         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3431         Remove.
3432         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3433
3434 2019-08-13  Tom Tromey  <tromey@adacore.com>
3435
3436         * tracepoint.c: Don't include readline.h or history.h.
3437
3438 2019-08-12  Tom Tromey  <tom@tromey.com>
3439
3440         * configure: Rebuild.
3441         * configure.ac: Check for readline 7.
3442         * NEWS: Mention readline 7 requirement.
3443         * README: Update.
3444
3445 2019-08-12  Tom Tromey  <tom@tromey.com>
3446
3447         * mingw-hdep.c (gdb_select): Remove readline hack.
3448
3449 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3450
3451         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3452         when the function fails.
3453
3454 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3455
3456         * s390-tdep.c (s390_type_align): New function.
3457         (s390_gdbarch_init): Set it as type_align gdbarch method.
3458
3459 2019-08-09  Tom de Vries  <tdevries@suse.de>
3460
3461         PR gdb/24591
3462         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3463         pc_low with relocation offset.
3464
3465 2019-08-07  Tom Tromey  <tromey@adacore.com>
3466
3467         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3468         (print_frame_args): Update.
3469         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3470         Update.
3471         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3472         * frame.h (struct frame_arg): Add initializers.
3473         <error>: Now a unique_xmalloc_ptr.
3474
3475 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3476
3477         * NEWS: Expand the Pointer Authentication entry.
3478         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3479         (aarch64_frame_unmask_lr): ... to this.
3480         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3481         Call aarch64_frame_unmask_lr.
3482         * frame.c (struct frame_info): Add "masked" variable.
3483         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3484         (fprint_frame): Check for masked pc.
3485         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3486         declarations.
3487         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3488         * stack.c (print_frame): Check for masked pc.
3489
3490 2019-08-06  Tom Tromey  <tom@tromey.com>
3491
3492         * stabsread.c (patch_block_stabs, read_one_struct_field)
3493         (read_enum_type): Use obstack_strndup.
3494         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3495         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3496         * dwarf2read.c (guess_full_die_structure_name)
3497         (anonymous_struct_prefix): Use obstack_strndup.
3498         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3499         * c-exp.y (yylex): Use obstack_strndup.
3500         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3501         (write_var_or_type): Use obstack_strndup.
3502
3503 2019-08-06  Tom Tromey  <tom@tromey.com>
3504
3505         * symfile.c (reread_symbols): Use obstack_strdup.
3506         * stabsread.c (read_type): Use obstack_strdup.
3507         * gdb_obstack.h (obstack_strdup): New overload.
3508         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3509         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3510         (dwarf2_canonicalize_name): Use obstack_strdup.
3511         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3512         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3513         Use obstack_strdup.
3514
3515 2019-08-06  Tom Tromey  <tom@tromey.com>
3516
3517         * gdb_obstack.h (obstack_strdup): Define.
3518         * gdb_obstack.c (obstack_strdup): Don't define.
3519
3520 2019-08-06  Tom Tromey  <tom@tromey.com>
3521
3522         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3523         obstack_strdup.
3524         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3525         obstack_strdup.
3526         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3527         * stabsread.c (common_block_start): Use obstack_strdup.
3528         * objfiles.c (set_objfile_main_name, objfile): Use
3529         obstack_strdup.
3530         * namespace.c (add_using_directive): Use obstack_strdup.
3531         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3532         * jit.c (finalize_symtab): Use obstack_strdup.
3533         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3534         (guess_partial_die_structure_name, partial_die_info::fixup)
3535         (dwarf2_name): Use obstack_strdup.
3536         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3537         obstack_strdup.
3538         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3539         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3540         obstack_strdup.
3541         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3542
3543 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3544
3545         * unittests/help-doc-selftests.c: New file.
3546         * Makefile.in: Add the new file.
3547
3548 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3549
3550         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3551         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3552         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3553         the trailing '.' is not output, and the first character is uppercased.
3554         (print_help_for_command): Update call to print_doc_line.
3555         (print_doc_of_command): Likewise.
3556         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3557         * cli/cli-option.c (append_indented_doc): Do not append newline.
3558         (build_help_option): Append newline after first appended_indented_doc
3559         only if a second call is done.
3560         (build_help): Append 2 new lines before each option, except the first
3561         one.
3562         * compile/compile.c (_initialize_compile): Add new lines after
3563         %OPTIONS%, when not at the end of the help.
3564         Change help doc or code
3565         producing the help doc to respect the invariants.
3566         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3567         Also removed the new line after 'Options:', as all other commands
3568         do not put an empty line between 'Options:' and the first option.
3569         * printcmd.c (_initialize_printcmd): Likewise.
3570         * stack.c (_initialize_stack): Likewise.
3571         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3572         incorrectly telling COMMAND is optional.
3573         * ada-lang.c (_initialize_ada_language): Change help doc or code
3574         producing the help doc to respect the invariants.
3575         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3576         * breakpoint.c (_initialize_breakpoint): Likewise.
3577         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3578         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3579         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3580         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3581         _initialize_cli_style): Likewise.
3582         * corelow.c (core_target_info): Likewise.
3583         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3584         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3585         * filesystem.c (_initialize_filesystem): Likewise.
3586         * frame.c (_initialize_frame): Likewise.
3587         * gnu-nat.c (add_task_commands): Likewise.
3588         * infcall.c (_initialize_infcall): Likewise.
3589         * infcmd.c (_initialize_infcmd): Likewise.
3590         * interps.c (_initialize_interpreter): Likewise.
3591         * language.c (_initialize_language): Likewise.
3592         * linux-fork.c (_initialize_linux_fork): Likewise.
3593         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3594         * maint.c (_initialize_maint_cmds): Likewise.
3595         * memattr.c (_initialize_mem): Likewise.
3596         * printcmd.c (_initialize_printcmd): Likewise.
3597         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3598         _RegEx): Likewise.
3599         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3600         * record-btrace.c (_initialize_record_btrace): Likewise.
3601         * record-full.c (_initialize_record_full): Likewise.
3602         * record.c (_initialize_record): Likewise.
3603         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3604         * regcache.c (_initialize_regcache): Likewise.
3605         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3606         _initialize_remote): Likewise.
3607         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3608         * serial.c (_initialize_serial): Likewise.
3609         * skip.c (_initialize_step_skip): Likewise.
3610         * source.c (_initialize_source): Likewise.
3611         * stack.c (_initialize_stack): Likewise.
3612         * symfile.c (_initialize_symfile): Likewise.
3613         * symtab.c (_initialize_symtab): Likewise.
3614         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3615         * top.c (init_main): Likewise.
3616         * tracefile-tfile.c (tfile_target_info): Likewise.
3617         * tracepoint.c (_initialize_tracepoint): Likewise.
3618         * tui/tui-win.c (_initialize_tui_win): Likewise.
3619         * utils.c (add_internal_problem_command): Likewise.
3620         * valprint.c (value_print_option_defs): Likewise.
3621
3622 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3623
3624         PR build/24886
3625         * configure.ac: Drop enable-libmcheck support.
3626         * configure, config.in: Rebuild.
3627         * libmcheck.m4: Remove.
3628         * acinclude.m4: Don't include it.
3629         * Makefile.in: Don't distribute it.
3630         * top.c (print_gdb_configuration): Don't mention it.
3631
3632 2019-08-06  Tom Tromey  <tom@tromey.com>
3633
3634         * utils.c (set_output_style): Sometimes pass stream to
3635         emit_style_escape.
3636         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3637         * record-btrace.c (btrace_insn_history): Update.
3638         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3639         method.
3640         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3641         Update initializers.
3642         <m_uiout>: New field.
3643         <m_di>: Move lower.
3644         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3645         Remove "uiout" parameter.
3646         (dump_insns): Update.
3647         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3648         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3649
3650 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3651
3652         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3653         (error_in_psymtab_expansion): Likewise.
3654         (lookup_symbol_via_quick_fns): Likewise.
3655         (basic_lookup_transparent_type_quick): Likewise.
3656         (basic_lookup_transparent_type_1): Likewise.
3657
3658 2019-08-06  Tom Tromey  <tromey@adacore.com>
3659
3660         * source.c (last_source_error): Now bool.
3661         (print_source_lines_base): Make "noprint" bool.  Only open
3662         source file when last_source_visited changes.
3663
3664 2019-08-06  Tom Tromey  <tromey@adacore.com>
3665
3666         * annotate.c (annotate_source_line): Use g_source_cache.
3667         * source-cache.c (source_cache::get_plain_source_lines): Change
3668         parameters.  Populate m_offset_cache.
3669         (source_cache::ensure): New method.
3670         (source_cache::get_line_charpos): New method.
3671         (extract_lines): Move lower.  Change parameters.
3672         (source_cache::get_source_lines): Move lower.
3673         * source-cache.h (class source_cache): Update comment.
3674         <get_line_charpos>: New method.
3675         <get_source_lines>: Update comment.
3676         <clear>: Clear m_offset_cache.
3677         <get_plain_source_lines>: Change parameters.
3678         <ensure>: New method
3679         <m_offset_cache>: New member.
3680         * source.c (forget_cached_source_info_for_objfile): Update.
3681         (info_source_command): Use g_source_cache.
3682         (find_source_lines, open_source_file_with_line_charpos): Remove.
3683         (print_source_lines_base, search_command_helper): Use g_source_cache.
3684         * source.h (open_source_file_with_line_charpos): Don't declare.
3685         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3686         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3687         Use g_source_cache.
3688
3689 2019-08-06  Tom Tromey  <tromey@adacore.com>
3690
3691         * source-cache.c (source_cache::get_plain_source_lines):
3692         Remove "first_line" and "last_line" parameters.
3693         (source_cache::get_source_lines): Cache plain text.
3694         * source-cache.h (class source_cache)
3695         <get_plain_source_lines>: Update.
3696
3697 2019-08-06  Tom Tromey  <tromey@adacore.com>
3698
3699         * source-cache.c (extract_lines): No longer a method.
3700         Changed type of parameter.  Include final newline.
3701         (selftests::extract_lines_test): New function.
3702         (_initialize_source_cache): Likewise.
3703         * source-cache.h (class source_cache)
3704         <extract_lines>: Don't declare.
3705
3706 2019-08-06  Tom Tromey  <tromey@adacore.com>
3707
3708         * breakpoint.c (init_breakpoint_sal): Update.
3709         (breakpoint): Update.
3710         * breakpoint.h (struct breakpoint) <filter>: Now a
3711         unique_xmalloc_ptr.
3712
3713 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3714
3715         * NEWS: Mention dictionary access on blocks.
3716         * python/py-block.c (blpy_getitem): New function.
3717         (block_object_as_mapping): New struct.
3718         (block_object_type): Use new struct for tp_as_mapping field.
3719
3720 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3721
3722         * objfiles.h (objfile): Add a comment describing partial symbols.
3723
3724 2019-08-05  Tom Tromey  <tromey@adacore.com>
3725
3726         * compile/compile.c (_initialize_compile): Use _(), not N_().
3727         * thread.c (_initialize_thread): Use _(), not N_().
3728         * stack.c (_initialize_stack): Use _(), not N_().
3729         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3730
3731 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3732
3733         * dwarf2read.c (struct dw2_symtab_iterator):
3734         <want_specific_block>: Remove.
3735         <block_index>: Change type to gdb::optional.
3736         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3737         change type of BLOCK_INDEX parameter to gdb::optional.
3738         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3739         (dw2_lookup_symbol): Don't pass argument for
3740         WANT_SPECIFIC_BLOCK.
3741         (dw2_expand_symtabs_for_function): Don't pass argument for
3742         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3743         (class dw2_debug_names_iterator)
3744         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3745         parameter, change BLOCK_INDEX type to gdb::optional.
3746         <m_want_specific_block>: Remove.
3747         <m_block_index>: Change type to gdb::optional.
3748         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3749         gdb::optional.  Re-write in function of gdb::optional.
3750         (dw2_debug_names_lookup_symbol): Don't pass argument for
3751         WANT_SPECIFIC_BLOCK.
3752         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3753         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3754         BLOCK_INDEX.
3755
3756 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3757
3758         * NEWS: Mention changes to "info sources" command.
3759
3760 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3761
3762         * symtab.c (filename_partial_match_opts): New struct type.
3763         (struct output_source_filename_data): New members
3764         regexp, c_regexp, partial_match.
3765         (output_source_filename): Use new members to decide to print file.
3766         (info_sources_option_defs): New variable.
3767         (make_info_sources_options_def_group, print_info_sources_header,
3768         info_sources_command_completer):
3769         New functions.
3770         (info_sources_command): Read new optional arguments.
3771         (_initialize_symtab): Update info sources help.
3772
3773 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3774
3775         * ada-lang.c (exception_support_info_v0): Renamed from...
3776         (default_exception_support_info): ... this.  Create new
3777         definition for v1.
3778         (ada_has_this_exception_support): Look up catch_handlers_sym.
3779         (ada_exception_support_info_sniffer): Try v0 after default.
3780
3781 2019-08-01  Tom Tromey  <tromey@adacore.com>
3782
3783         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3784         gdbarch.h.
3785
3786 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3787
3788         * s12z-tdep.c: Fix include path for s12z-opc.h.
3789
3790 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3791
3792         * NEWS: Require GNU make 3.82.
3793
3794 2019-07-16  Tom Tromey  <tom@tromey.com>
3795
3796         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3797         declare.
3798
3799 2019-07-30  Tom Tromey  <tromey@adacore.com>
3800
3801         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3802
3803 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3804
3805         * printcmd.c (print_address_symbolic): Print negative offsets.
3806         (build_address_symbolic): Force signed arithmetic when computing
3807         offset.
3808
3809 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3810
3811         PR/24474: Add a function to lookup static variables.
3812         * NEWS: Mention this new function.
3813         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3814         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3815         * python/python.c (python_GdbMethods): Add new function.
3816
3817 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3818
3819         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3820         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3821         (objfpy_lookup_static_symbol): New function.
3822         (objfile_object_methods): Add new functions.
3823
3824 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3825
3826         * NEWS: Mention 'set|show print frame-info'.  Mention new
3827         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3828         backtrace argument.  Mention that python frame filtering code
3829         is now consistent with what 'backtrace' command prints.
3830
3831 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3832
3833         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3834         comments.
3835         (print_frame_info_auto, print_frame_info_source_line,
3836         print_frame_info_location, print_frame_info_source_and_location,
3837         print_frame_info_location_and_address, print_frame_info_short_location):
3838         New declarations.
3839         (struct frame_print_options): New member print_frame_info.
3840         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3841         * stack.h (get_user_print_what_frame_info): New declaration.
3842         (frame_show_address): New declaration.
3843         * stack.c (print_frame_arguments_choices): New value 'presence'.
3844         (print_frame_info_auto, print_frame_info_source_line,
3845         print_frame_info_location, print_frame_info_source_and_location,
3846         print_frame_info_location_and_address, print_frame_info_short_location,
3847         print_frame_info_choices, print_frame_info_print_what): New definitions.
3848         (print_frame_args): Only print dots for args if print frame-arguments
3849         is 'presence'.
3850         (frame_print_option_defs): New element for "frame-info".
3851         (get_user_print_what_frame_info): New function.
3852         (frame_show_address): Make non static.  Move comment to stack.h.
3853         (print_frame_info_to_print_what): New function.
3854         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3855         to decide what to print.
3856         (backtrace_command_1): Handle the new print_frame_arguments_presence
3857         value.
3858         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3859         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3860         (py_print_frame): In non-mi mode, use LOCATION as default for
3861         print_what, similarly to frame information printed directly by
3862         backtrace command. Handle frame-info user option in non MI mode.
3863
3864 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3865
3866         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3867         Add case for debugging 32-bit target on 64-bit host.  Revise
3868         comment.
3869
3870 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3871
3872         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3873         instead of find_function_entry_range_from_pc.
3874
3875 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3876
3877         * stack.c (find_frame_funname): Remove code which preferred
3878         minsym over symtab sym in "certain pathological cases".
3879
3880         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3881         parameter.  Change type of "do_demangle" to bool.
3882         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3883         Pass suitable "prefer_sym_over_minsym" flag to
3884         build_address_symbolic().  Don't output "+" for negative offsets.
3885         * printcmd.c (print_address_symbolic): Update invocation of
3886         build_address_symbolic to include a "prefer_sym_over_minsym"
3887         flag.
3888         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3889         Restrict cases in which use of minimal symbol is preferred to that
3890         of a found symbol.  Update comments.
3891
3892         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3893         for entry pc when entry pc is out of range for that FDE.
3894
3895 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3896
3897         PR gdb/24839:
3898         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3899         type.
3900
3901 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3902
3903         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3904         this function's Python signature.
3905
3906
3907 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3908
3909         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3910         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3911         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3912         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3913         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3914
3915
3916 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3917
3918         * h8300-tdep.c (h8300_register_name_common): New.
3919         h8300_register_name): Use h8300_register_name_common.
3920         (h8300s_register_name): Likewise.
3921         (h8300sx_register_name): Likewise.
3922         (h8300h_register_nam): New.
3923         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3924
3925
3926 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3927
3928         * arm-tdep.c (arm_skip_cmse_entry): New function.
3929         (arm_is_sgstubs_section): New function.
3930         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3931
3932 2019-07-22  Tom Tromey  <tom@tromey.com>
3933
3934         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3935         Don't self-assign.
3936
3937 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3938
3939         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3940         type_print.
3941
3942 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3943
3944         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3945         so that GDB doesn't match any msymbols when searching in the
3946         TYPES_DOMAIN.
3947         (print_symbol_info): Print using typedef_print or type_print based
3948         on the type of the symbol.  Add updated FIXME comment moved from...
3949         (_initialize_symtab): ... move and update FIXME comment to above.
3950
3951 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3952
3953         * NEWS: Mention adding -q option to "info types".
3954         * symtab.c (struct info_types_options): New struct.
3955         (info_types_options_defs): New variable.
3956         (make_info_types_options_def_group): New function.
3957         (info_types_command): Use gdb::option framework to parse options.
3958         (info_types_command_completer): New function.
3959         (_initialize_symtab): Extend the help text on "info types" and
3960         register command completer.
3961
3962 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3963
3964         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3965         (lookup_symbol_in_objfile): Change int to block_enum and add a
3966         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3967
3968 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3969
3970         * MAINTAINERS (Write After Approval): Add self.
3971
3972 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3973
3974         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3975         instruction to the dummy code region.
3976
3977 2019-07-19  Tom Tromey  <tromey@adacore.com>
3978
3979         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3980         (ARGSUSED, PARAMS, __func__): Remove rules.
3981
3982 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3983
3984         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3985         * features/arm/arm-with-iwmmxt.c: Remove.
3986         * features/arm/arm-with-iwmmxt.xml: Remove.
3987         * features/arm/arm-with-m-fpa-layout.c: Remove.
3988         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3989         * features/arm/arm-with-m-vfp-d16.c: Remove.
3990         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3991         * features/arm/arm-with-m.c: Remove.
3992         * features/arm/arm-with-m.xml: Remove.
3993         * features/arm/arm-with-neon.c: Remove.
3994         * features/arm/arm-with-neon.xml: Remove.
3995         * features/arm/arm-with-vfpv2.c: Remove.
3996         * features/arm/arm-with-vfpv2.xml: Remove.
3997         * features/arm/arm-with-vfpv3.c: Remove.
3998         * features/arm/arm-with-vfpv3.xml: Remove.
3999
4000 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4001
4002         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4003
4004 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4005
4006         * arch/aarch32.c (aarch32_create_target_description): Create
4007         target descriptions using features.
4008         * arch/arm.c (arm_create_target_description)
4009         (arm_create_mprofile_target_description): Likewise.
4010         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4011
4012 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4013
4014         * Makefile.in: Add new files.
4015         * aarch32-tdep.c: New file.
4016         * aarch32-tdep.h: New file.
4017         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4018         Call aarch32_read_description.
4019         * arch/aarch32.c: New file.
4020         * arch/aarch32.h: New file.
4021         * arch/arm.c (arm_create_target_description)
4022         (arm_create_mprofile_target_description): New function.
4023         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4024         (arm_create_target_description)
4025         (arm_create_mprofile_target_description): New declaration.
4026         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4027         read_description functions.
4028         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4029         Likewise.
4030         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4031         * arm-tdep.c (tdesc_arm_list): New variable.
4032         (arm_register_g_packet_guesses): Call create description functions.
4033         (arm_read_description) (arm_read_mprofile_description): New
4034         function.
4035         * arm-tdep.h (arm_read_description)
4036         (arm_read_mprofile_description): Add declaration.
4037         * configure.tgt: Add new files.
4038
4039 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4040
4041         * top.c (new_ui_command): Open specified terminal just once.
4042
4043 2019-07-18  Tom Tromey  <tromey@adacore.com>
4044
4045         * symtab.c (main_name): Constify return type.
4046         * symfile.c (set_initial_language): Update.
4047         * symtab.h (main_name): Constify return type.
4048
4049 2019-07-17  Tom Tromey  <tom@tromey.com>
4050
4051         * tui/tui-winsource.c (tui_update_source_window)
4052         (tui_update_source_window_as_is)
4053         (tui_update_source_windows_with_line): Remove return.
4054         * tui/tui-disasm.c (tui_show_disassem)
4055         (tui_show_disassem_and_update_source): Remove return.
4056         * tui/tui.c (tui_reset): Remove return.
4057         * tui/tui-wingeneral.c
4058         (tui_check_and_display_highlight_if_needed): Remove return.
4059
4060 2019-07-17  Tom Tromey  <tom@tromey.com>
4061
4062         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4063
4064 2019-07-17  Tom Tromey  <tom@tromey.com>
4065
4066         * tui/tui-winsource.h (struct tui_exec_info_window)
4067         (struct tui_source_window_base): Move from tui-data.h.
4068         * tui/tui-winsource.c: Move many method definitions from
4069         elsewhere.  Remove "structuring" comments.
4070         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4071         (tui_source_window_base::refresh_window): Move to
4072         tui-winsource.c.
4073         * tui/tui-win.c (tui_source_window_base::refresh_all)
4074         (tui_source_window_base::update_tab_width)
4075         (tui_source_window_base::set_new_height)
4076         (tui_source_window_base::do_make_visible_with_new_height): Move to
4077         tui-winsource.c.
4078         * tui/tui-source.h: Update.
4079         * tui/tui-source.c (tui_source_window_base::reset): Move to
4080         tui-winsource.c.
4081         * tui/tui-disasm.h: Update.
4082         * tui/tui-data.h (struct tui_exec_info_window): Move to
4083         tui-winsource.h.
4084         (struct tui_source_window_base): Likewise.
4085         * tui/tui-data.c (tui_source_window_base::clear_detail)
4086         (tui_source_window_base, ~tui_source_window_base): Move to
4087         tui-winsource.c.
4088
4089 2019-07-17  Tom Tromey  <tom@tromey.com>
4090
4091         * tui/tui-win.c (tui_resize_all)
4092         (tui_source_window_base::update_tab_width)
4093         (tui_adjust_win_heights): Update.
4094         (tui_win_info::make_invisible_and_set_new_height): Rename from
4095         make_invisible_and_set_new_height.
4096         * tui/tui-data.h (struct tui_win_info)
4097         <make_invisible_and_set_new_height>: New method.
4098
4099 2019-07-17  Tom Tromey  <tom@tromey.com>
4100
4101         * tui/tui.c: Update.
4102         * tui/tui-source.h (struct tui_source_window): Move from
4103         tui-data.h.
4104         * tui/tui-layout.c: Update.
4105         * tui/tui-disasm.c: Update.
4106         * tui/tui-data.h (struct tui_source_window): Move to
4107         tui-source.h.
4108
4109 2019-07-17  Tom Tromey  <tom@tromey.com>
4110
4111         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4112         tui-data.h.
4113         * tui/tui-data.h (struct tui_disasm_window): Move to
4114         tui-disasm.h.
4115
4116 2019-07-17  Tom Tromey  <tom@tromey.com>
4117
4118         * tui/tui-regs.h (struct tui_data_item_window): Move from
4119         tui-data.h.
4120         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4121         * tui/tui-data.h (struct tui_data_item_window): Move to
4122         tui-regs.h.
4123         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4124
4125 2019-07-17  Tom Tromey  <tom@tromey.com>
4126
4127         * tui/tui.c: Update.
4128         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4129         (tui_cmd_window::max_height): Move to tui-command.c.
4130         * tui/tui-layout.c: Update.
4131         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4132         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4133         tui-command.c.
4134         * tui/tui-command.h (struct tui_cmd_window): Move from
4135         tui-data.h.
4136         * tui/tui-command.c: Remove "structuring" comments.
4137         (tui_cmd_window::clear_detail)
4138         (tui_cmd_window::do_make_visible_with_new_height)
4139         (tui_cmd_window::max_height): Move from elsewhere.
4140
4141 2019-07-17  Tom Tromey  <tom@tromey.com>
4142
4143         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4144         Now static.
4145         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4146         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4147
4148 2019-07-17  Tom Tromey  <tom@tromey.com>
4149
4150         * tui/tui.c: Update.
4151         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4152         tui-regs.c.
4153         * tui/tui-windata.h: Remove file.
4154         * tui/tui-windata.c: Remove file.
4155         * tui/tui-win.c (tui_data_window::set_new_height)
4156         (tui_data_window::do_make_visible_with_new_height): Move to
4157         tui-regs.c.
4158         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4159         * tui/tui-regs.c: Remove "structuring" comments.
4160         (tui_data_window::first_data_item_displayed)
4161         (tui_data_window::delete_data_content_windows)
4162         (tui_data_window::erase_data_content)
4163         (tui_data_window::display_all_data)
4164         (tui_data_window::refresh_all)
4165         (tui_data_window::do_scroll_vertical)
4166         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4167         (tui_data_window::do_make_visible_with_new_height)
4168         (tui_data_window::refresh_window): Move from elsewhere.
4169         (_initialize_tui_regs): Move to end of file.
4170         * tui/tui-layout.c: Update.
4171         * tui/tui-hooks.c: Update.
4172         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4173         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4174         tui-regs.c.
4175         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4176
4177 2019-07-17  Tom Tromey  <tom@tromey.com>
4178
4179         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4180         seen.
4181
4182 2019-07-17  Tom Tromey  <tom@tromey.com>
4183
4184         * tui/tui-win.c (tui_source_window_base::set_new_height)
4185         (tui_source_window_base::do_make_visible_with_new_height): Use
4186         m_has_locator field directly.
4187         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4188         method.
4189         (struct tui_source_window_base) <has_locator>: Likewise.
4190
4191 2019-07-17  Tom Tromey  <tom@tromey.com>
4192
4193         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4194         Don't declare.
4195         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4196         Remove.
4197         * tui/tui-win.c (tui_source_window_base::set_new_height)
4198         (tui_source_window_base::set_new_height)
4199         (make_invisible_and_set_new_height)
4200         (tui_source_window_base::do_make_visible_with_new_height)
4201         (tui_source_window_base::do_make_visible_with_new_height):
4202         Update.
4203         * tui/tui-layout.c (show_source_disasm_command, show_data)
4204         (show_source_or_disasm_and_command): Update.
4205         * tui/tui-layout.c (show_layout): Update.
4206
4207 2019-07-17  Tom Tromey  <tom@tromey.com>
4208
4209         * tui/tui-layout.c (make_data_window): Remove.
4210         (show_data): Unify creation and re-initialization cases.
4211
4212 2019-07-17  Tom Tromey  <tom@tromey.com>
4213
4214         * tui/tui-layout.c (make_source_window, make_disasm_window):
4215         Remove.
4216         (show_data): Unify creation and re-initialization cases.
4217
4218 2019-07-17  Tom Tromey  <tom@tromey.com>
4219
4220         * tui/tui-layout.c (make_command_window): Remove.
4221         (show_source_disasm_command, show_source_or_disasm_and_command):
4222         Unify creation and re-initialization cases.
4223
4224 2019-07-17  Tom Tromey  <tom@tromey.com>
4225
4226         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4227         creation and re-initialization cases.
4228
4229 2019-07-17  Tom Tromey  <tom@tromey.com>
4230
4231         * tui/tui-regs.c (tui_get_register): Return void.
4232
4233 2019-07-17  Tom Tromey  <tom@tromey.com>
4234
4235         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4236         Simplify.
4237
4238 2019-07-17  Tom Tromey  <tom@tromey.com>
4239
4240         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4241         resetting.
4242
4243 2019-07-17  Tom Tromey  <tom@tromey.com>
4244
4245         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4246         * tui/tui-regs.c (tui_reg_layout): New function.
4247         (tui_show_registers, tui_reg_command): Use it.
4248         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4249         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4250         parameters.
4251         (tui_layout_command): Remove.
4252
4253 2019-07-17  Tom Tromey  <tom@tromey.com>
4254
4255         * tui/tui-layout.h (tui/tui-layout): Return void.
4256         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4257
4258 2019-07-17  Tom Tromey  <tom@tromey.com>
4259
4260         * tui/tui-layout.c (show_source_disasm_command, show_data):
4261         Update.
4262         (reset_locator): Remove.
4263         (show_source_or_disasm_and_command): Update.
4264
4265 2019-07-17  Tom Tromey  <tom@tromey.com>
4266
4267         * tui/tui-source.c (tui_source_window_base::reset): Remove
4268         win_type parameter.
4269         * tui/tui-layout.c (make_command_window, make_source_window)
4270         (make_disasm_window, make_data_window)
4271         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4272         (reset_locator, show_source_or_disasm_and_command): Update.
4273         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4274         win_type parameter.
4275         (struct tui_source_window_base) <reset>: Likewise.
4276
4277 2019-07-17  Tom Tromey  <tom@tromey.com>
4278
4279         * tui/tui-layout.c (show_source_disasm_command): Use
4280         reset_locator.
4281         (reset_locator): New function.
4282         (init_and_make_win): Remove.
4283         (show_source_or_disasm_and_command): Use reset_locator.
4284
4285 2019-07-17  Tom Tromey  <tom@tromey.com>
4286
4287         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4288         condition.
4289         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4290         Remove condition.
4291         * tui/tui-source.c (tui_source_window_base::reset): New method.
4292         * tui/tui-layout.c (make_command_window): Don't call
4293         init_and_make_win.
4294         (make_source_window, make_disasm_window): Don't call
4295         make_source_or_disasm_window.
4296         (make_data_window): Don't call init_and_make_win.  Change calling
4297         convention.
4298         (show_source_disasm_command, show_data): Simplify.
4299         (make_source_or_disasm_window): Remove.
4300         (show_source_or_disasm_and_command): Simplify.
4301         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4302         (struct tui_source_window_base) <reset>: Likewise.
4303         <execution_info>: Remove initializer.
4304         * tui/tui-data.c (tui_source_window_base): Initialize
4305         execution_info.
4306
4307 2019-07-17  Tom Tromey  <tom@tromey.com>
4308
4309         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4310         variable.
4311
4312 2019-07-17  Tom Tromey  <tom@tromey.com>
4313
4314         * tui/tui.c (tui_rl_other_window): Update.
4315         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4316         superclass method first.  Always iterate over regs_content.
4317         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4318         method.
4319         * tui/tui-win.c (tui_set_focus_command): Update.
4320
4321 2019-07-17  Tom Tromey  <tom@tromey.com>
4322
4323         * tui/tui-win.c (tui_set_focus_command): Rename from
4324         tui_set_focus.  Call tui_enable.
4325         (tui_set_focus_command): Remove.
4326
4327 2019-07-17  Tom Tromey  <tom@tromey.com>
4328
4329         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4330         refresh_window.
4331         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4332         touchwin.
4333         (tui_data_window::refresh_window): Call refresh_window on data
4334         items.  Always call superclass refresh_window.
4335         (tui_win_info::refresh): Remove.
4336         (tui_source_window_base::refresh_window): Update.
4337         (tui_refresh_all): Update.
4338         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4339         refresh_window.
4340         (show_source_or_disasm_and_command): Likewise.
4341         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4342         (struct tui_source_window_base) <refresh>: Likewise.
4343
4344 2019-07-17  Tom Tromey  <tom@tromey.com>
4345
4346         * tui/tui-winsource.c (tui_clear_source_content)
4347         (tui_show_source_content): Update.
4348         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4349         whether content is empty.
4350         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4351         Remove.
4352
4353 2019-07-17  Tom Tromey  <tom@tromey.com>
4354
4355         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4356         window's contents.
4357         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4358         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4359
4360 2019-07-17  Tom Tromey  <tom@tromey.com>
4361
4362         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4363         (struct tui_data_item_window): Update.
4364
4365 2019-07-17  Tom Tromey  <tom@tromey.com>
4366
4367         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4368         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4369         defines.
4370
4371 2019-07-17  Tom Tromey  <tom@tromey.com>
4372
4373         * tui/tui-winsource.h (tui_erase_source_content)
4374         (tui_clear_source_content): Remove "display_prompt" parameter.
4375         * tui/tui-winsource.c (tui_update_source_window_as_is)
4376         (tui_update_source_windows_with_addr): Update.
4377         (tui_clear_source_content): Remove "display_prompt" parameter.
4378         (tui_erase_source_content): Likewise.  Simplify.
4379         (tui_show_source_content): Update.
4380         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4381         * tui/tui-stack.c (tui_show_frame_info): Update.
4382         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4383         Remove defines.
4384
4385 2019-07-17  Tom Tromey  <tom@tromey.com>
4386
4387         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4388         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4389         parameter.
4390         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4391         parameter.
4392
4393 2019-07-17  Tom Tromey  <tom@tromey.com>
4394
4395         * tui/tui-winsource.c (tui_clear_source_content)
4396         (tui_show_source_content, tui_show_exec_info_content)
4397         (tui_clear_exec_info_content): Update.
4398         * tui/tui-stack.c (tui_show_locator_content): Update.
4399         (tui_show_frame_info): Update.
4400         * tui/tui-source.h (tui_source_window): Don't declare.
4401         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4402         from tui_source_is_displayed.
4403         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4404         Remove field.
4405         (struct tui_source_window_base) <content_in_use>: New field.  Now
4406         bool.
4407         (struct tui_source_window) <showing_source_p>: New method.
4408         (TUI_SRC_WIN): Change cast.
4409         * tui/tui-data.c (tui_initialize_static_data): Update.
4410
4411 2019-07-17  Tom Tromey  <tom@tromey.com>
4412
4413         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4414         location_matches_p.
4415         * tui/tui-source.c (tui_source_window::location_matches_p): New
4416         method.
4417         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4418         method.
4419         * tui/tui-data.h (struct tui_source_window_base)
4420         <location_matches_p>: New method.
4421         (struct tui_source_window, struct tui_disasm_window)
4422         <location_matches_p>: Likewise.
4423
4424 2019-07-17  Tom Tromey  <tom@tromey.com>
4425
4426         * tui/tui-win.c (tui_set_win_height_command): Rename from
4427         tui_set_win_height.
4428         (tui_set_win_height_command): Remove.
4429
4430 2019-07-17  Tom Tromey  <tom@tromey.com>
4431
4432         * tui/tui-source.c (tui_source_window): New constructor.  Add
4433         observer.
4434         (~tui_source_window): New destructor.
4435         (tui_source_window::style_changed): New method.
4436         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4437         (tui_attach_detach_observers): Update.
4438         * tui/tui-data.h (struct tui_source_window): Make constructor not
4439         inline.  Add destructor.
4440         (struct tui_source_window) <style_changed>: New method.
4441         <m_observable>: New member.
4442
4443 2019-07-17  Tom Tromey  <tom@tromey.com>
4444
4445         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4446         * tui/tui-win.c (tui_resize_all): Fix typo.
4447
4448 2019-07-17  Tom Tromey  <tom@tromey.com>
4449
4450         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4451         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4452         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4453         * tui/tui-win.c (window_name_completer): Use foreach.
4454         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4455         (update_tab_width): Likewise.
4456         * tui/tui-layout.c (show_layout): Update.
4457         * tui/tui-data.h (class tui_window_iterator): New.
4458         (struct all_tui_windows): New.
4459         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4460
4461 2019-07-17  Tom Tromey  <tom@tromey.com>
4462
4463         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4464         parameter.  Don't reference globals.
4465         (tui_reg_command): Update.
4466
4467 2019-07-17  Tom Tromey  <tom@tromey.com>
4468
4469         * tui/tui-regs.c (tui_show_registers): Simplify.
4470
4471 2019-07-17  Tom Tromey  <tom@tromey.com>
4472
4473         * tui/tui-regs.c (tui_show_registers): Update.
4474         (tui_show_register_group): Add win_info parameter.
4475
4476 2019-07-17  Tom Tromey  <tom@tromey.com>
4477
4478         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4479         Rename from tui_display_reg_element_at_line.
4480         (tui_data_window::display_registers_from_line): Update.
4481         * tui/tui-data.h (struct tui_data_window)
4482         <display_reg_element_at_line>: New method.
4483
4484 2019-07-17  Tom Tromey  <tom@tromey.com>
4485
4486         * tui/tui-regs.h (tui_display_registers_from)
4487         (tui_display_registers_from_line): Don't declare.
4488         * tui/tui-windata.c (tui_data_window::display_all_data)
4489         (tui_data_window::refresh_all)
4490         (tui_data_window::do_scroll_vertical): Update.
4491         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4492         from tui_display_registers_from.
4493         (tui_display_reg_element_at_line): Update.
4494         (tui_data_window::display_registers_from_line): Rename from
4495         tui_display_registers_from_line.
4496         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4497         display_registers_from_line>: New methods.
4498
4499 2019-07-17  Tom Tromey  <tom@tromey.com>
4500
4501         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4502         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4503         from tui_erase_data_content.
4504         (tui_data_window::display_all_data)
4505         (tui_data_window::refresh_all)
4506         (tui_data_window::do_scroll_vertical): Update.
4507         * tui/tui-regs.c (tui_show_registers): Update.
4508         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4509         New method.
4510
4511 2019-07-17  Tom Tromey  <tom@tromey.com>
4512
4513         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4514         declare.
4515         * tui/tui-windata.c
4516         (tui_data_window::delete_data_content_windows): Rename from
4517         tui_delete_data_content_windows.
4518         (tui_data_window::display_all_data)
4519         (tui_data_window::do_scroll_vertical): Update.
4520         * tui/tui-data.h (struct tui_data_window)
4521         <delete_data_content_windows>: New method.
4522
4523 2019-07-17  Tom Tromey  <tom@tromey.com>
4524
4525         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4526         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4527
4528 2019-07-17  Tom Tromey  <tom@tromey.com>
4529
4530         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4531         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4532         from tui_display_all_data.
4533         * tui/tui-win.c
4534         (tui_data_window::do_make_visible_with_new_height): Update.
4535         * tui/tui-regs.c (tui_show_registers): Update.
4536         * tui/tui-layout.c (tui_set_layout): Update.
4537         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4538         method.
4539
4540 2019-07-17  Tom Tromey  <tom@tromey.com>
4541
4542         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4543         * tui/tui-windata.c (tui_display_data_from): Remove.
4544         (tui_data_window::refresh_all): Update.
4545
4546 2019-07-17  Tom Tromey  <tom@tromey.com>
4547
4548         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4549         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4550         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4551         tui_display_registers_from_line.
4552         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4553         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4554         "force_display" parameter.
4555
4556 2019-07-17  Tom Tromey  <tom@tromey.com>
4557
4558         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4559         declare.
4560         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4561         Rename from tui_first_reg_element_no_inline.
4562         (tui_display_reg_element_at_line)
4563         (tui_display_registers_from_line): Update.
4564         * tui/tui-data.h (struct tui_data_window)
4565         <first_reg_element_no_inline>: New method.
4566
4567 2019-07-17  Tom Tromey  <tom@tromey.com>
4568
4569         * tui/tui-windata.c (tui_display_data_from)
4570         (tui_data_window::do_scroll_vertical): Update.
4571         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4572         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4573         Rename from tui_line_from_reg_element_no.
4574         (tui_display_registers_from_line): Update.
4575         * tui/tui-data.h (struct tui_data_window)
4576         <line_from_reg_element_no>: New method.
4577
4578 2019-07-17  Tom Tromey  <tom@tromey.com>
4579
4580         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4581         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4582         tui_last_regs_line_no.
4583         (tui_display_reg_element_at_line)
4584         (tui_display_registers_from_line): Update.
4585         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4586         method.
4587
4588 2019-07-17  Tom Tromey  <tom@tromey.com>
4589
4590         PR tui/24722:
4591         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4592         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4593         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4594         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4595         (tui_update_breakpoint_info): Likewise.
4596         * tui/tui-hooks.c (tui_event_create_breakpoint)
4597         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4598         Update.
4599
4600 2019-07-17  Tom Tromey  <tom@tromey.com>
4601
4602         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4603
4604 2019-07-17  Tom Tromey  <tom@tromey.com>
4605
4606         * tui/tui-winsource.c (tui_update_source_window_as_is)
4607         (tui_update_source_windows_with_addr): Update.
4608         * tui/tui-source.h (tui_set_source_content)
4609         (tui_show_symtab_source): Add "win_info" parameter.
4610         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4611         parameter.
4612         (tui_show_symtab_source): Likewise.
4613
4614 2019-07-17  Tom Tromey  <tom@tromey.com>
4615
4616         * tui/tui-wingeneral.c
4617         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4618
4619 2019-07-17  Tom Tromey  <tom@tromey.com>
4620
4621         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4622         (struct tui_cmd_window) <can_scroll>: New method.
4623         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4624         method.
4625
4626 2019-07-17  Tom Tromey  <tromey@adacore.com>
4627
4628         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4629         do_field_signed>: Rename.  Change type of "value".
4630         * ui-out.c (ui_out::field_signed): Rename from field_int.
4631         Change type of "value".
4632         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4633         type of "value".
4634         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4635         do_field_int.  Change type of "value".
4636         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4637         do_field_int.  Change type of "value".
4638         * tracepoint.c (trace_status_mi, tfind_1)
4639         (print_one_static_tracepoint_marker): Update.
4640         * thread.c (print_thread_info_1, print_selected_thread_frame):
4641         Update.
4642         * stack.c (print_frame, print_frame_info): Update.
4643         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4644         Update.
4645         * source.c (print_source_lines_base): Update.
4646         * skip.c (info_skip_command): Update.
4647         * record-btrace.c (btrace_ui_out_decode_error)
4648         (btrace_call_history_src_line): Update.
4649         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4650         Update.
4651         * progspace.c (print_program_space): Update.
4652         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4653         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4654         do_field_int.  Change type of "value".
4655         * mi/mi-out.c (mi_ui_out::do_table_begin)
4656         (mi_ui_out::do_table_header): Update.
4657         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4658         type of "value".
4659         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4660         (mi_cmd_data_list_changed_registers, output_register)
4661         (mi_cmd_data_read_memory, mi_load_progress)
4662         (mi_cmd_trace_frame_collected): Update.
4663         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4664         Update.
4665         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4666         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4667         (mi_cmd_var_list_children, varobj_update_one): Update.
4668         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4669         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4670         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4671         * inferior.c (print_inferior): Update.
4672         * gdb_bfd.c (print_one_bfd): Update.
4673         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4674         Update.
4675         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4676         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4677         do_field_int.  Change type of "value".
4678         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4679         do_field_int.  Change type of "value".
4680         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4681         (print_one_breakpoint_location, print_it_catch_fork)
4682         (print_one_catch_fork, print_it_catch_vfork)
4683         (print_one_catch_vfork, print_it_catch_solib)
4684         (print_it_catch_exec, print_it_ranged_breakpoint)
4685         (print_mention_watchpoint, print_mention_masked_watchpoint)
4686         (bkpt_print_it, update_static_tracepoint): Update.
4687         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4688         * break-catch-syscall.c (print_it_catch_syscall): Update.
4689         * ada-tasks.c (print_ada_task_info): Update.
4690         * ada-lang.c (print_it_exception, print_mention_exception):
4691         Update.
4692
4693 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4694
4695         PR breakpoints/24541
4696         * gdbarch.c: Regenerate.
4697         * gdbarch.h: Regenerate.
4698         * gdbarch.sh: Adjust return type and parameter types for
4699         'stap_adjust_register'.
4700         (i386_stap_adjust_register): Adjust signature and return new
4701         register name.
4702         * stap-probe.c (stap_parse_register_operand): Adjust use of
4703         'gdbarch_stap_adjust_register'.
4704
4705 2019-07-17  Tom Tromey  <tromey@adacore.com>
4706
4707         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4708         declare VEC.
4709         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4710         std::vector.
4711         (struct s390_process_info): Add initializers.
4712         (s390_add_process): Use new.
4713         (s390_linux_nat_target::low_forget_process): Use delete.
4714         (s390_linux_nat_target::low_new_fork)
4715         (s390_linux_nat_target::stopped_by_watchpoint)
4716         (s390_linux_nat_target::low_prepare_to_resume)
4717         (s390_linux_nat_target::insert_watchpoint)
4718         (s390_linux_nat_target::insert_hw_breakpoint)
4719         (s390_linux_nat_target::remove_watchpoint)
4720         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4721
4722 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4723
4724         * aarch64-fbsd-nat.c: Include regcache.h.
4725         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4726         argument.
4727         (aarch64_fbsd_nat_target::fetch_registers)
4728         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4729         variable.
4730         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4731
4732 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4733
4734         * fbsd-nat.c: Include gdbarch.h.
4735
4736 2019-07-15  Tom Tromey  <tromey@adacore.com>
4737
4738         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4739
4740 2019-07-15  Tom Tromey  <tromey@adacore.com>
4741
4742         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4743         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4744         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4745         * cli-out.c (cli_ui_out::do_field_int): New method.
4746         * ui-out.c (ui_out::field_unsigned): New method.
4747         * symfile.c (generic_load): Use field_unsigned.
4748         (print_transfer_performance): Likewise.
4749         * record-btrace.c (ui_out_field_uint): Remove.
4750         (btrace_call_history_insn_range, btrace_call_history): Use
4751         field_unsigned.
4752         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4753         field_unsigned.
4754         * ui-out.h (class ui_out) <field_unsigned>: New method.
4755         <do_field_unsigned>: Likewise.
4756
4757 2019-07-15  Tom Tromey  <tromey@adacore.com>
4758
4759         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4760         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4761         * target.c (flash_erase_command): Use field_string.
4762         * infrun.c (print_signal_received_reason): Use field_string.
4763         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4764         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4765         field_string.
4766         * ada-tasks.c (print_ada_task_info): Use field_string.
4767
4768 2019-07-15  Tom Tromey  <tromey@adacore.com>
4769
4770         * target.c (flash_erase_command): Use field_core_addr.
4771         * symfile.c (generic_load): Use field_core_addr.
4772         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4773         Use field_core_addr.
4774         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4775         field_core_addr.
4776
4777 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4778
4779         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4780         value if its desired type is smaller than a CORE_ADDR and signed.
4781
4782 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4783
4784         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4785         of changes to field names, and use new is_reference field to
4786         decide if a property is a reference or not.
4787         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4788         field.
4789         (struct dwarf2_property_baton): Update header comment, rename
4790         'referenced_type' to 'property_type' and update comments.
4791         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4792         default property type, store in property baton, update to take
4793         accound of renamed field.
4794         (read_func_scope): Update call to attr_to_dynamic_prop.
4795         (read_array_type): Likewise.
4796         (dwarf2_per_cu_addr_sized_int_type): New function.
4797         (read_subrange_index_type): Move type finding code to
4798         dwarf2_per_cu_addr_sized_int_type.
4799         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4800         (dwarf2_per_cu_addr_type): New function.
4801         (set_die_type): Update calls to attr_to_dynamic_prop.
4802
4803 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4804
4805         * dwarf2read.c (read_subrange_index_type): New function.
4806         (read_subrange_type): Move code into new function and call it.
4807         * gdbtypes.c (create_range_type): Add some asserts.
4808
4809 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4810
4811         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4812         update return statements.
4813         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4814         declaration, and update comment to match.
4815         * gdbtypes.c (resolve_dynamic_array): Update call to
4816         dwarf2_evaluate_property to match new return type.
4817
4818 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4819
4820         * valarith.c (value_subscripted_rvalue): Change lowerbound
4821         parameter type from int to LONGEST.
4822         * value.h (value_subscripted_rvalue): Likewise in declaration.
4823
4824 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4825
4826         * cli/cli-utils.c (info_print_command_completer): New function.
4827         * cli/cli-utils.h: Add 'completer.h' include, and forward
4828         declaration for 'struct cmd_list_element'.
4829         (info_print_command_completer): Declare.
4830         * stack.c (_initialize_stack): Add completer for 'info locals' and
4831         'info args'.
4832         * symtab.c (_initialize_symtab): Add completer for 'info
4833         variables' and 'info functions'.
4834         * NEWS: Mention completion for additional info commands.
4835
4836 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4837
4838         * cli/cli-utils.c (extract_info_print_args): Delete.
4839         (extract_arg_maybe_quoted): Delete.
4840         (info_print_options_defs): New variable.
4841         (make_info_print_options_def_group): New function.
4842         (extract_info_print_options): Define new function.
4843         * cli/cli-utils.h (extract_info_print_args): Delete.
4844         (struct info_print_options): New structure.
4845         (extract_info_print_options): Declare new function.
4846         * stack.c (info_locals_command): Update to use new
4847         extract_info_print_options, also add a header comment.
4848         (info_args_command): Likewise.
4849         * symtab.c (info_variables_command): Likewise.
4850         (info_functions_command): Likewise.
4851
4852 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4853
4854         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4855         to extract string arguments.
4856         * common/common-utils.c (extract_string_maybe_quoted): New function.
4857         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4858
4859 2019-07-11  Tom Tromey  <tromey@adacore.com>
4860
4861         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4862         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4863         * top.h (gdbinit): Don't declare.
4864         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4865         into...
4866         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4867         * top.c (gdb_init): Don't call init_cli_cmds.
4868         (gdbinit): Remove.
4869         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4870
4871 2019-07-11  Tom Tromey  <tromey@adacore.com>
4872
4873         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4874         after it has been moved.
4875
4876 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4877
4878         * valops.c (value_must_coerce_to_target): Change return type to
4879         bool.
4880         * value.h (value_must_coerce_to_target): Likewise.
4881
4882 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4883
4884         * breakpoint.c (is_hardware_watchpoint): Remove
4885         forward-declaration.
4886         (is_masked_watchpoint): Change return type to bool.
4887         (is_tracepoint): Likewise.
4888         (is_breakpoint): Likewise.
4889         (is_hardware_watchpoint): Likewise.
4890         (is_watchpoint): Likewise.
4891         (is_no_memory_software_watchpoint): Likewise.
4892         (is_catchpoint): Likewise.
4893         (breakpoint_1): Make FILTER parameter's return type bool.
4894         is_masked_watchpoint): Change return type to bool.
4895         (save_breakpoints): Make FILTER parameter's return type bool.
4896         * breakpoint.h (is_breakpoint): Change return type to bool.
4897         (is_watchpoint): Likewise.
4898         (is_catchpoint): Likewise.
4899         (is_tracepoint): Likewise.
4900
4901 2019-07-10  Tom Tromey  <tom@tromey.com>
4902
4903         * defs.h: Don't include gdbarch.h.
4904         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4905         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4906         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4907         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4908         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4909         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4910         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4911         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4912         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4913         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4914         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4915         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4916         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4917         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4918         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4919         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4920         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4921         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4922         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4923         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4924         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4925         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4926         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4927         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4928         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4929         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4930         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4931
4932 2019-07-10  Tom Tromey  <tromey@adacore.com>
4933
4934         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4935         * breakpoint.c (init_ada_exception_breakpoint): Register as
4936         bp_catchpoint.
4937         (print_one_breakpoint_location, print_one_breakpoint): Use
4938         is_ada_exception_catchpoint.
4939         * ada-lang.c (class ada_catchpoint_location): Pass
4940         bp_loc_software_breakpoint to bp_location constructor.
4941         (is_ada_exception_catchpoint): New function.
4942
4943 2019-07-10  Tom Tromey  <tromey@adacore.com>
4944
4945         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4946         VEC.
4947         (struct arm_exidx_entry): New method operator<.
4948         (struct arm_exidx_data) <section_maps>: Change type.
4949         (arm_exidx_data_free): Remove.
4950         (arm_exidx_data_key): Change type.  Move lower.
4951         (arm_exidx_new_objfile): Update.
4952         (arm_compare_exidx_entries): Remove.
4953         (arm_find_exidx_entry, _initialize_arm_tdep)
4954
4955 2019-07-10  Tom Tromey  <tromey@adacore.com>
4956
4957         * solib-spu.c (ocl_program_data_key): Change type.
4958         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4959         Update.
4960
4961 2019-07-10  Tom Tromey  <tromey@adacore.com>
4962
4963         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4964         (struct solib_aix_inferior_data) <library_list>: Change type.
4965         (solib_aix_inferior_data_handle): Change type.
4966         (get_solib_aix_inferior_data): Update.
4967         (solib_aix_free_library_list): Remove.
4968         (library_list_start_library): Update.
4969         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4970         return type.
4971         (solib_aix_get_library_list)
4972         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4973         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4974
4975 2019-07-10  Tom Tromey  <tromey@adacore.com>
4976
4977         * solib-dsbt.c (struct dsbt_info): Add initializers.
4978         (solib_dsbt_pspace_data): Change type.
4979         (dsbt_pspace_data_cleanup): Remove.
4980         (get_dsbt_info, _initialize_dsbt_solib): Update.
4981
4982 2019-07-10  Tom Tromey  <tromey@adacore.com>
4983
4984         * spu-tdep.c (spu_overlay_data): Change type.
4985         (spu_get_overlay_table, spu_overlay_new_objfile)
4986         (_initialize_spu_tdep): Update.
4987
4988 2019-07-10  Tom Tromey  <tromey@adacore.com>
4989
4990         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4991         destructor.
4992         (dbx_objfile_data_key): Change type and declare later.
4993         (DBX_SYMFILE_INFO): Rewrite.
4994         * dbxread.c (dbx_objfile_data_key): Change type.
4995         (dbx_symfile_init): Update.
4996         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4997         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4998         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4999
5000 2019-07-10  Tom Tromey  <tromey@adacore.com>
5001
5002         * jit.c (jit_program_space_key): Change type.  Move lower.
5003         (get_jit_program_space_data): Update.
5004         (jit_program_space_data_cleanup): Remove.
5005         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5006         Update.
5007         (struct jit_program_space_data): Add initializers.
5008
5009 2019-07-10  Tom Tromey  <tromey@adacore.com>
5010
5011         * solib-darwin.c (struct darwin_info): Add initializers.
5012         (solib_darwin_pspace_data): Change type.
5013         (darwin_pspace_data_cleanup): Remove.
5014         (get_darwin_info, _initialize_darwin_solib): Update.
5015
5016 2019-07-10  Tom Tromey  <tromey@adacore.com>
5017
5018         * remote-sim.c (struct sim_inferior_data): Add initializers,
5019         constructor, and destructor.
5020         (sim_inferior_data_key): Change type.  Move lower.
5021         (check_for_duplicate_sim_descriptor): Update.
5022         (get_sim_inferior_data): Use new.  Update.
5023         (~sim_inferior_data_cleanup): Rename from
5024         sim_inferior_data_cleanup.  Simplify.
5025         (gdbsim_close_inferior, simulator_command)
5026         (sim_command_completer, _initialize_remote_sim): Update.
5027         (next_pid, INITIAL_PID): Move earlier.
5028
5029 2019-07-10  Tom Tromey  <tromey@adacore.com>
5030
5031         * python/python-internal.h (create_thread_object): Return
5032         gdbpy_ref.
5033         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5034         * python/py-inferior.c (struct threadlist_entry): Add
5035         constructor.
5036         <thread_obj>: Now a gdbpy_ref.
5037         (thread_to_thread_object): Update.
5038         (add_thread_object): Use new.
5039         (delete_thread_object): Use delete.
5040         (infpy_threads): Update.
5041         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5042         GIL.
5043
5044 2019-07-10  Tom Tromey  <tromey@adacore.com>
5045
5046         * valops.c (value_cast): Specialize error message for Ada.
5047
5048 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5049
5050         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5051
5052 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5053
5054         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5055         bpstat_should_step): Return bool, adjust comments.
5056         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5057         bpstat_should_step): Likewise.
5058
5059 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5060
5061         * features/Makefile: Use feature target descriptions for Arm.
5062         * features/arm/arm-core.c: Generate new file.
5063         * features/arm/arm-fpa.c: Likewise.
5064         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5065         * features/arm/arm-m-profile.c: Likewise.
5066         * features/arm/arm-vfpv2.c: Likewise.
5067         * features/arm/arm-vfpv3.c: Likewise.
5068         * features/arm/xscale-iwmmxt.c: Likewise.
5069         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5070
5071 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5072
5073         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5074         ptrace earlier.
5075
5076 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5077
5078         * features/aarch64-pauth.c: Regenerate.
5079
5080 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5081
5082         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5083         bool.
5084         (bpstat_what): Use false instead of 0.
5085
5086 2019-07-09  Pedro Alves  <palves@redhat.com>
5087
5088         * break-catch-throw.c (is_exception_catchpoint): New.
5089         * breakpoint.c (print_one_breakpoint_location): New parameter
5090         'raw_loc'.  Handle it.  Use
5091         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5092         looking at the breakpoint's type.
5093         (print_one_breakpoint): If handling "maint info breakpoints", also
5094         print locations of exception catchpoints.
5095         * breakpoint.h (is_exception_catchpoint): Declare.
5096
5097 2019-07-09  Pedro Alves  <palves@redhat.com>
5098
5099         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5100         "addr" field.
5101         (allocate_location_exception_catchpoint): New.
5102         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5103         (initialize_throw_catchpoint_ops): Install
5104         allocate_location_exception_catchpoint as allocate_location
5105         method.
5106         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5107         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5108         bp_loc_other.
5109         (breakpoint_address_is_meaningful): Delete.
5110         (bl_address_is_meaningful): New.
5111         (breakpoint_locations_match): Adjust comment.
5112         (bp_location_from_bp_type): New, factored out of...
5113         (bp_location::bp_location(breakpoint *)): ... this.
5114         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5115         factored out of...
5116         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5117         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5118         breakpoint_address_is_meaningful.
5119         (bp_locations_compare): Adjust comment.
5120         (update_global_location_list): Use bl_address_is_meaningful
5121         instead of breakpoint_address_is_meaningful.
5122         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5123         explicit.
5124         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5125         * python/py-breakpoint.c (bppy_get_location): No longer check
5126         whether location is null.
5127
5128 2019-07-09  Pedro Alves  <palves@redhat.com>
5129
5130         PR c++/15468
5131         * breakpoint.c (print_one_breakpoint_location): Remove
5132         single-location assert.
5133
5134 2019-07-09  Tom Tromey  <tom@tromey.com>
5135
5136         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5137         * configure: Rebuild.
5138         * configure.ac: Change common to gdbsupport.
5139         * gdbsupport: Rename from common.
5140         * acinclude.m4: Change common to gdbsupport.
5141         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5142         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5143         gdbsupport.
5144         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5145         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5146         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5147         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5148         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5149         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5150         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5151         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5152         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5153         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5154         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5155         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5156         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5157         coff-pe-read.c, command.h, compile/compile-c-support.c,
5158         compile/compile-c.h, compile/compile-cplus-symbols.c,
5159         compile/compile-cplus-types.c, compile/compile-cplus.h,
5160         compile/compile-loc2c.c, compile/compile.c, completer.c,
5161         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5162         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5163         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5164         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5165         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5166         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5167         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5168         features/aarch64-core.c, features/aarch64-fpu.c,
5169         features/aarch64-pauth.c, features/aarch64-sve.c,
5170         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5171         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5172         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5173         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5174         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5175         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5176         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5177         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5178         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5179         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5180         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5181         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5182         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5183         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5184         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5185         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5186         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5187         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5188         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5189         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5190         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5191         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5192         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5193         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5194         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5195         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5196         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5197         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5198         minsyms.c, mips-linux-tdep.c, namespace.h,
5199         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5200         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5201         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5202         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5203         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5204         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5205         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5206         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5207         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5208         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5209         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5210         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5211         procfs.c, producer.c, progspace.h, psymtab.h,
5212         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5213         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5214         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5215         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5216         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5217         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5218         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5219         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5220         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5221         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5222         target-memory.c, target.c, target.h, target/waitstatus.c,
5223         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5224         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5225         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5226         unittests/array-view-selftests.c,
5227         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5228         unittests/common-utils-selftests.c,
5229         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5230         unittests/format_pieces-selftests.c,
5231         unittests/function-view-selftests.c,
5232         unittests/lookup_name_info-selftests.c,
5233         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5234         unittests/mkdir-recursive-selftests.c,
5235         unittests/observable-selftests.c,
5236         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5237         unittests/parse-connection-spec-selftests.c,
5238         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5239         unittests/scoped_fd-selftests.c,
5240         unittests/scoped_mmap-selftests.c,
5241         unittests/scoped_restore-selftests.c,
5242         unittests/string_view-selftests.c, unittests/style-selftests.c,
5243         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5244         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5245         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5246         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5247         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5248         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5249
5250 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5251
5252         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5253         bool value.
5254         (decode_digits_ordinary): Set explicit_line field in sal.
5255         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5256         symtab_and_line that was set on an explicit line number in
5257         assembler code.  Do always update the recorded symtab and line if
5258         we do skip the prologue.
5259
5260 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5261
5262         * breakpoint.c (set_breakpoint_location_function): Remove
5263         explicit_loc parameter.
5264         (momentary_breakpoint_from_master): Update call to
5265         set_breakpoint_location_function.
5266         (add_location_to_breakpoint): Likewise.
5267
5268 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5269
5270         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5271         required features based on default bfd type when no specific bfd
5272         is present.
5273
5274 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5275
5276         * NEWS: Mention that GDB printf and eval commands can now print
5277         C-style and Ada-style convenience var strings without
5278         calling the inferior.
5279         * printcmd.c (printf_c_string): Locally print GDB internal var
5280         instead of transiting via the inferior.
5281         (printf_wide_c_string): Likewise.
5282
5283 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5284
5285         PR breakpoints/25011
5286         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5287
5288 2019-07-04  Tom Tromey  <tom@tromey.com>
5289
5290         PR tui/24724:
5291         * tui/tui-winsource.c (tui_clear_source_content): Update.
5292         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5293         (tui_update_breakpoint_info): Update.
5294         (tui_set_exec_info_content): Update.
5295         * tui/tui-source.c (tui_set_source_content_nil): Update.
5296         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5297         has_break.
5298         * tui/tui-data.h (enum tui_bp_flag): New.
5299         (tui_bp_flags): New enum flags type.
5300         (struct tui_source_element) <break_mode>: Change type.  Rename
5301         from has_break.
5302         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5303         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5304         constants.
5305         * tui/tui-winsource.h: Fix comment.
5306
5307 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5308
5309         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5310         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5311         (store_fpregs_to_thread)
5312         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5313         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5314         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5315         (IWMMXT_REGS_SIZE): Add define.
5316         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5317         (fetch_vfp_regs, store_vfp_regs)
5318         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5319         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5320
5321 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5322
5323         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5324         defines.
5325         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5326         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5327         (ARM_INT_REGISTER_SIZE): ...to this.
5328         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5329         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5330         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5331         (arm_linux_collect_gregset, supply_nwfpe_register)
5332         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5333         defines.
5334         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5335         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5336         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5337         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5338         (arm_return_in_memory, arm_store_return_value)
5339         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5340         (arm_record_ld_st_multiple): Likewise.
5341         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5342         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5343
5344 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5345
5346         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5347         AARCH64_DISPLACED_MODIFIED_INSNS.
5348         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5349         (aarch64_displaced_step_copy_insn): Likewise.
5350         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5351         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5352         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5353         ARM_DISPLACED_MODIFIED_INSNS.
5354         * arm-tdep.c (arm_gdbarch_init): Likewise.
5355         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5356         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5357         (struct arm_displaced_step_closure): Use
5358         ARM_DISPLACED_MODIFIED_INSNS.
5359
5360 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5361
5362         * features/Makefile: Remove unused xml files.
5363         * features/aarch64.xml: Remove.
5364         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5365         * features/i386/amd64-avx-avx512.xml: Remove.
5366         * features/i386/amd64-avx-linux.xml: Remove.
5367         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5368         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5369         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5370         * features/i386/amd64-avx-mpx.xml: Remove.
5371         * features/i386/amd64-avx.xml: Remove.
5372         * features/i386/amd64-linux.xml: Remove.
5373         * features/i386/amd64-mpx-linux.xml: Remove.
5374         * features/i386/amd64-mpx.xml: Remove.
5375         * features/i386/amd64.xml: Remove.
5376         * features/i386/i386-avx-avx512-linux.xml: Remove.
5377         * features/i386/i386-avx-avx512.xml: Remove.
5378         * features/i386/i386-avx-linux.xml: Remove.
5379         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5380         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5381         * features/i386/i386-avx-mpx-linux.xml: Remove.
5382         * features/i386/i386-avx-mpx.xml: Remove.
5383         * features/i386/i386-avx.xml: Remove.
5384         * features/i386/i386-linux.xml: Remove.
5385         * features/i386/i386-mmx-linux.xml: Remove.
5386         * features/i386/i386-mmx.xml: Remove.
5387         * features/i386/i386-mpx-linux.xml: Remove.
5388         * features/i386/i386-mpx.xml: Remove.
5389         * features/i386/i386.xml: Remove.
5390         * features/i386/x32-avx-avx512-linux.xml: Remove.
5391         * features/i386/x32-avx-linux.xml: Remove.
5392         * features/i386/x32-linux.xml: Remove.
5393
5394 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5395
5396         * regformats/aarch64.dat: Remove.
5397         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5398         * regformats/i386/amd64-avx-linux.dat: Remove.
5399         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5400         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5401         * regformats/i386/amd64-linux.dat: Remove.
5402         * regformats/i386/amd64-mpx-linux.dat: Remove.
5403         * regformats/i386/amd64.dat: Remove.
5404         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5405         * regformats/i386/i386-avx-linux.dat: Remove.
5406         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5407         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5408         * regformats/i386/i386-linux.dat: Remove.
5409         * regformats/i386/i386-mmx-linux.dat: Remove.
5410         * regformats/i386/i386-mpx-linux.dat: Remove.
5411         * regformats/i386/i386.dat: Remove.
5412         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5413         * regformats/i386/x32-avx-linux.dat: Remove.
5414         * regformats/i386/x32-linux.dat: Remove.
5415
5416 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5417
5418         * aarch64-tdep.c: Remove xml self tests.
5419         * amd64-linux-tdep.c: Likewise.
5420         * amd64-tdep.c: Likewise.
5421         * i386-linux-tdep.c: Likewise.
5422         * i386-tdep.c: Likewise.
5423
5424 2019-07-03  Pedro Alves  <palves@redhat.com>
5425
5426         PR cli/24732
5427         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5428         (pipe_cmd_option_defs): New.
5429         (make_pipe_cmd_options_def_group): New.
5430         (pipe_command): Use gdb::option::process_options.
5431         (pipe_command_completer): New function.
5432         (_initialize_cli_cmds): Install completer for "pipe" command.
5433
5434 2019-07-03  Pedro Alves  <palves@redhat.com>
5435
5436         * cli/cli-option.c (union option_value) <string>: New field.
5437         (struct option_def_and_value): Add ctor, move ctor, dtor and
5438         use DISABLE_COPY_AND_ASSIGN.
5439         (option_def_and_value::clear_value): New.
5440         (parse_option, save_option_value_in_ctx, get_val_type_str)
5441         (add_setshow_cmds_for_options): Handle var_string.
5442         * cli-option.h (union option_def::var_address) <string>: New
5443         field.
5444         (struct string_option_def): New.
5445         * maint-test-options.c (struct test_options_opts): Add default
5446         ctor and use DISABLE_COPY_AND_ASSIGN.
5447         <string_opt>: New field.
5448         (test_options_opts::~test_options_opts): New.
5449         (test_options_opts::dump): Also dump "-string".
5450         (test_options_option_defs): Install "string.
5451
5452 2019-07-03  Pedro Alves  <palves@redhat.com>
5453
5454         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5455         option_value with a null enumeration.
5456         (complete_options): Save the option values in the context.
5457         (save_option_value_in_ctx): New, factored out from ...
5458         (process_options): ... here.
5459         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5460         of the function.
5461         * maint-test-options.c (test_options_opts::dump): New, factored
5462         out from ...
5463         (maintenance_test_options_command_mode): ... here.
5464         (maintenance_test_options_command_completion_result): Delete.
5465         (maintenance_test_options_command_completion_text): Update
5466         comment.
5467         (maintenance_show_test_options_completion_result): Change
5468         prototype.  Just print
5469         maintenance_test_options_command_completion_text.
5470         (save_completion_result): New.
5471         (maintenance_test_options_completer_mode): Pass options context to
5472         complete_options, and then save a dump.
5473         (_initialize_maint_test_options): Use add_cmd to install "maint
5474         show test-options-completion-result".
5475
5476 2019-07-03  Pedro Alves  <palves@redhat.com>
5477
5478         * NEWS (New commands): Mention "with" and "maint with".
5479         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5480         (with_command, with_command_completer): New.
5481         (pipe_command): Adjust to new repeat_previous
5482         interface.
5483         (_initialize_cli_cmds): Install the "with" command and its "w"
5484         alias.
5485         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5486         declarations.
5487         * cli/cli-setshow.c (parse_cli_var_uinteger)
5488         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5489         argument strings for all var_types.
5490         (get_setshow_command_value_string): New, factored out from ...
5491         (do_show_command): ... this.
5492         * cli/cli-setshow.h: Include <string>.
5493         (get_setshow_command_value_string): Declare.
5494         * command.h (repeat_previous): Now returns const char *.  Adjust
5495         comment.
5496         * maint.c: Include "cli/cli-cmds.h".
5497         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5498         (_initialize_maint_cmds): Register the "maintenance with" command.
5499         * top.c (repeat_previous): Move bits from pipe_command here:
5500         Return the saved command line, if any; error out if there's no
5501         command to relaunch.
5502
5503 2019-07-03  Pedro Alves  <palves@redhat.com>
5504
5505         * NEWS (New commands): Mention "maint set/show test-settings"
5506         instead of "maint test-settings".
5507         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5508         (maintenance_test_settings_set_list): Rename to ...
5509         (maintenance_set_test_settings_list): ... this.
5510         (maintenance_test_settings_show_list): Rename to  ...
5511         (maintenance_show_test_settings_list): ... this.
5512         (maintenance_test_settings_cmd): Delete.
5513         (maintenance_test_settings_set_cmd): ...
5514         (maintenance_set_test_settings_cmd): ... this.
5515         (maintenance_test_settings_show_cmd): ...
5516         (maintenance_show_test_settings_cmd): ... this.
5517         (maintenance_test_settings_show_value_cmd):
5518         (maintenance_show_test_settings_value_cmd): ... this.
5519         (_initialize_maint_test_settings): No longer install the "maint
5520         test-settings" prefix command.  Rename "maint test-settings set"
5521         to "maint set test-settings", and "maint test-settings show" to
5522         "maint show test-settings".  Adjust all subcommands.
5523
5524 2019-07-03  Pedro Alves  <palves@redhat.com>
5525
5526         * maint-test-settings.c: Fix file's intro comment.  Replace all
5527         references to "test-options" with references to "test-settings",
5528         in comments.
5529
5530 2019-07-03  Pedro Alves  <palves@redhat.com>
5531
5532         * maint-test-settings.c (maintenance_test_settings_xxx)
5533         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5534         New.
5535         (maintenance_test_settings_enums): Use them.
5536         (maintenance_test_settings_enum): Default to
5537         maintenance_test_settings_xxx.
5538         (_initialize_maint_test_settings): Initialize
5539         MAINTENANCE_TEST_SETTINGS_FILENAME.
5540
5541 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5542
5543         * breakpoint.h (remove_breakpoints_inf): Change return type to
5544         void, move function documentation here.
5545         * breakpoint.c (remove_breakpoints_inf): Change return type to
5546         void, move function documentation to header.
5547
5548 2019-07-02  Pedro Alves  <palves@redhat.com>
5549
5550         * NEWS (Completion improvements): Mention "info threads".
5551         * thread.c (struct info_threads_opts, info_threads_option_defs)
5552         (make_info_threads_options_def_group): New.
5553         (info_threads_command): Use gdb::option::process_options.
5554         (info_threads_command_completer): New.
5555         (_initialize_thread): Use gdb::option::build_help to build the
5556         help text for "info threads".
5557
5558 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5559
5560         * defs.h (generic_load): Move from here...
5561         * symfile.h (generic_load): ... to here.  Rename name parameter
5562         to args.
5563         * symfile.c (generic_load): Add comment.
5564
5565 2019-07-01  Tom Tromey  <tromey@adacore.com>
5566
5567         * dwarf2read.c
5568         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5569         declaration of without_params.  Fix formatting.
5570
5571 2019-07-01  Tom Tromey  <tromey@adacore.com>
5572
5573         * ada-exp.y (find_primitive_type): Update.
5574         * ada-lang.h (ada_lookup_symbol): Update.
5575         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5576         parameter.
5577         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5578
5579 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5580
5581         PR breakpoints/24541
5582         * gdbarch.c: Regenerate.
5583         * gdbarch.h: Regenerate.
5584         * gdbarch.sh: Add 'stap_adjust_register'.
5585         * i386-tdep.c: Include '<unordered_set>'.
5586         (i386_stap_adjust_register): New function.
5587         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5588         * stap-probe.c (stap_parse_register_operand): Call
5589         'gdbarch_stap_adjust_register'.
5590
5591 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5592
5593         PR python/24742
5594         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5595         * python/python.c (do_start_initialization): Use 'xmalloc'
5596         instead of 'PyMem_Malloc'.
5597
5598 2019-06-28  Tom Tromey  <tromey@adacore.com>
5599
5600         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5601         for Ada.
5602
5603 2019-06-27  Tom Tromey  <tromey@adacore.com>
5604
5605         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5606         objfile_key.
5607         (arm_find_mapping_symbol, arm_record_special_symbol)
5608         (_initialize_arm_tdep): Update.
5609         (arm_objfile_data_free): Remove.
5610
5611 2019-06-27  Tom Tromey  <tromey@adacore.com>
5612
5613         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5614         to cp_print_static_field.
5615
5616 2019-06-26  Tom Tromey  <tromey@adacore.com>
5617
5618         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5619         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5620         declare.
5621
5622 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5623
5624         * features/aarch64-core.c (create_feature_aarch64_core):
5625         Regenerate.
5626         * features/aarch64-core.xml: Add cpsr flags.
5627
5628 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5629
5630         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5631         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5632
5633 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5634
5635         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5636         field.
5637         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5638         use.
5639         (arm_record_special_symbol): Don't insert new symbol in sorted
5640         position, push it at the end.
5641
5642 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5643
5644         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5645         (arm_mapping_symbol_s): Remove.
5646         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5647         (arm_mapping_symbol_vec): New typedef.
5648         (struct arm_per_objfile): Add constructor.
5649         <section_maps>: Change type to
5650         std::unique_ptr<arm_mapping_symbol_vec[]>.
5651         (arm_compare_mapping_symbols): Remove.
5652         (arm_find_mapping_symbol): Adjust to section_maps type change.
5653         (arm_objfile_data_free): Call delete on arm_per_objfile.
5654         (arm_record_special_symbol): Adjust to section_maps type change.
5655         Allocate arm_per_objfile with new.
5656
5657 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5658
5659         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5660         with the command prefix.
5661
5662 2019-06-25  Tom Tromey  <tom@tromey.com>
5663
5664         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5665         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5666
5667 2019-06-25  Tom Tromey  <tom@tromey.com>
5668
5669         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5670         type.
5671         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5672         protected.
5673
5674 2019-06-25  Tom Tromey  <tom@tromey.com>
5675
5676         * tui/tui-winsource.c
5677         (tui_source_window_base::set_is_exec_point_at): Add check against
5678         LOA_ADDRESS.
5679
5680 2019-06-25  Tom Tromey  <tom@tromey.com>
5681
5682         * tui/tui-source.c (tui_set_source_content): Don't check before
5683         xfree.
5684         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5685
5686 2019-06-25  Tom Tromey  <tom@tromey.com>
5687
5688         * tui/tui-winsource.h (tui_update_source_window_as_is)
5689         (tui_alloc_source_buffer, tui_line_is_displayed)
5690         (tui_addr_is_displayed): Change type of win_info.
5691         * tui/tui-winsource.c (tui_update_source_window_as_is)
5692         (tui_clear_source_content, tui_show_source_line)
5693         (tui_show_source_content, tui_source_window_base::refill)
5694         (tui_source_window_base::set_is_exec_point_at)
5695         (tui_source_window_base::set_is_exec_point_at)
5696         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5697         (tui_alloc_source_buffer, tui_line_is_displayed)
5698         (tui_addr_is_displayed): Change type of win_info.  Update.
5699         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5700         (tui_source_window_base::do_make_visible_with_new_height):
5701         Update.
5702         * tui/tui-source.c (tui_set_source_content)
5703         (tui_set_source_content_nil)
5704         (tui_source_window::do_scroll_vertical): Update.
5705         * tui/tui-layout.c (show_layout): Update.
5706         * tui/tui-disasm.c (tui_set_disassem_content)
5707         (tui_disasm_window::do_scroll_vertical): Update.
5708         * tui/tui-data.h (tui_win_content): Remove.
5709         (struct tui_gen_win_info) <content, content_size>: Remove.
5710         (struct tui_source_element): Add initializers and destructor.
5711         (union tui_which_element, struct tui_win_element): Remove.
5712         (struct tui_source_window_base) <content>: New field.
5713         (struct tui_data_window): Remove destructor.
5714         (tui_alloc_content, tui_free_win_content)
5715         (tui_free_all_source_wins_content): Don't declare.
5716         * tui/tui-data.c (tui_initialize_static_data): Update.
5717         (init_content_element, tui_alloc_content): Remove.
5718         (~tui_gen_win_info): Update.
5719         (~tui_data_window, tui_free_all_source_wins_content)
5720         (tui_free_win_content, free_content, free_content_elements):
5721         Remove.
5722
5723 2019-06-25  Tom Tromey  <tom@tromey.com>
5724
5725         * tui/tui-winsource.h (tui_clear_source_content)
5726         (tui_erase_source_content, tui_show_source_content): Change type
5727         of win_info.
5728         * tui/tui-winsource.c (tui_clear_source_content)
5729         (tui_erase_source_content, tui_show_source_content): Change type
5730         of win_info.
5731         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5732         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5733         win_info.
5734         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5735         win_info.
5736         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5737
5738 2019-06-25  Tom Tromey  <tom@tromey.com>
5739
5740         * tui/tui-winsource.c (tui_clear_source_content)
5741         (tui_source_window_base::set_is_exec_point_at): Update.
5742         * tui/tui-source.c (tui_set_source_content_nil): Update.
5743         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5744         a bool.
5745         * tui/tui-data.c (init_content_element): Update.
5746
5747 2019-06-25  Tom Tromey  <tom@tromey.com>
5748
5749         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5750         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5751         * tui/tui-layout.c (init_and_make_win): Update.
5752         * tui/tui.h (enum tui_win_type): Update.
5753         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5754         tui_win_is_auxillary.
5755         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5756         tui_win_is_auxillary.
5757
5758 2019-06-25  Tom Tromey  <tom@tromey.com>
5759
5760         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5761         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5762         (tui_delete_data_content_windows, tui_display_all_data)
5763         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5764         Update.
5765         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5766         * tui/tui-regs.c (tui_last_regs_line_no)
5767         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5768         (tui_show_registers): Update.
5769         (tui_show_register_group): Return void.  Update.
5770         (tui_display_registers_from, tui_display_reg_element_at_line)
5771         (tui_display_registers_from_line, tui_check_register_values):
5772         Update.
5773         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5774         member.
5775         (struct tui_data_window) <regs_content>: Now a std::vector.
5776         <regs_content_count>: Remove.
5777         (tui_add_content_elements, tui_free_data_content): Don't declare.
5778         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5779         (init_content_element): Remove DATA_WIN case.  Add assert.
5780         (tui_add_content_elements): Remove.
5781         (tui_data_window): Update.
5782         (tui_free_data_content): Remove.
5783         (free_content_elements): Remove DATA_WIN case.
5784
5785 2019-06-25  Tom Tromey  <tom@tromey.com>
5786
5787         * tui/tui-data.c (tui_data_item_window): Update.
5788         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5789         * tui/tui-windata.c (tui_display_all_data)
5790         (tui_display_data_from_line): Update.
5791         (tui_check_data_values): Remove.
5792         * tui/tui-regs.c (tui_show_register_group)
5793         (tui_display_reg_element_at_line): Update.
5794         * tui/tui-hooks.c (tui_register_changed)
5795         (tui_refresh_frame_and_register_information): Call
5796         tui_check_register_values.
5797         * tui/tui-data.h (struct tui_data_window) <data_content,
5798         data_content_count, data_type>: Remove.
5799         (enum tui_data_type): Remove.
5800
5801         * tui/tui-data.c (tui_data_window::clear_detail)
5802         (~tui_data_window): Update.
5803
5804 2019-06-25  Tom Tromey  <tom@tromey.com>
5805
5806         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5807         declare.
5808         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5809         Rename from tui_first_data_item_displayed.  Update.
5810         (tui_data_window::refresh_all)
5811         (tui_data_window::do_scroll_vertical): Update.
5812         * tui/tui-data.h (struct tui_data_window)
5813         <first_data_item_displayed>: Declare new method.
5814
5815 2019-06-25  Tom Tromey  <tom@tromey.com>
5816
5817         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5818         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5819         contents...
5820         (tui_initialize_static_data): ...here.
5821
5822 2019-06-25  Tom Tromey  <tom@tromey.com>
5823
5824         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5825         (tui_display_registers_from, tui_check_register_values): Update.
5826         (tui_display_register): Remove win_info parameter; update.
5827         (tui_get_register): Change type of parameters.
5828         * tui/tui-data.h (struct tui_data_element): Remove.
5829         (union tui_which_element) <data>: Remove.
5830         <data_window>: Change type.
5831         (struct tui_data_item_window): New.
5832         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5833         case.  Add assert.
5834         (~tui_data_item_window): New destructor.
5835         (free_content_elements): Remove DATA_ITEM_WIN case.
5836
5837 2019-06-25  Tom Tromey  <tom@tromey.com>
5838
5839         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5840         Remove.
5841
5842 2019-06-25  Tom Tromey  <tom@tromey.com>
5843
5844         * tui/tui-data.h (struct tui_command_element): Remove.
5845         (union tui_which_element) <command>: Remove.
5846         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5847         assert.
5848         (free_content_elements): Remove CMD_WIN case.
5849
5850 2019-06-25  Tom Tromey  <tom@tromey.com>
5851
5852         * tui/tui-layout.c (tui_set_layout): Update.
5853         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5854         * tui/tui-data.c (layout_def): Update.
5855
5856 2019-06-25  Tom Tromey  <tom@tromey.com>
5857
5858         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5859         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5860         (tui_source_window_base::set_new_height): Update.
5861         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5862         Update.
5863         (tui_set_locator_fullname, tui_set_locator_info)
5864         (tui_show_frame_info): Update.
5865         * tui/tui-source.c (tui_set_source_content)
5866         (tui_source_is_displayed): Update.
5867         * tui/tui-layout.c (show_source_disasm_command, show_data)
5868         (show_source_or_disasm_and_command): Update.
5869         * tui/tui-disasm.c (tui_set_disassem_content)
5870         (tui_get_begin_asm_address): Update.
5871         * tui/tui-data.h (struct tui_locator_element): Remove.
5872         (union tui_which_element) <locator>: Remove.
5873         (struct tui_locator_window): New.
5874         (tui_locator_win_info_ptr): Change return type.
5875         * tui/tui-data.c (_locator): Change type.
5876         (tui_locator_win_info_ptr): Change return type.
5877         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5878         (tui_alloc_content): Add assert.
5879
5880 2019-06-25  Tom Tromey  <tom@tromey.com>
5881
5882         * tui/tui-winsource.c
5883         (tui_exec_info_window::maybe_allocate_content): New method.
5884         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5885         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5886         (make_source_or_disasm_window): Add cast.
5887         * tui/tui-data.h (union tui_which_element) <simple_string>:
5888         Remove.
5889         (struct tui_source_info): New.
5890         (struct tui_source_window_base) <execution_info>: Change type.
5891         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5892         case, and add assert.
5893         (tui_alloc_content): Add assert.
5894
5895 2019-06-25  Tom Tromey  <tom@tromey.com>
5896
5897         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5898         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5899         * tui/tui-data.c (tui_alloc_win_info): Remove.
5900
5901 2019-06-25  Tom Tromey  <tom@tromey.com>
5902
5903         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5904         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5905         can_highlight.
5906
5907 2019-06-25  Tom Tromey  <tom@tromey.com>
5908
5909         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5910         make_visible_with_new_height method.
5911         (tui_win_info::make_visible_with_new_height): New method.
5912         (tui_source_window_base::do_make_visible_with_new_height)
5913         (tui_data_window::do_make_visible_with_new_height)
5914         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5915         (make_visible_with_new_height): Remove.
5916         (tui_resize_all, tui_adjust_win_heights): Use
5917         make_visible_with_new_height method.
5918         * tui/tui-data.h (struct tui_win_info)
5919         <do_make_visible_with_new_height, make_visible_with_new_height>:
5920         New methods.
5921         (struct tui_source_window_base, struct tui_data_window)
5922         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5923         methods.
5924
5925 2019-06-25  Tom Tromey  <tom@tromey.com>
5926
5927         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5928         method.
5929         (update_tab_width): Call update_tab_width method.
5930         * tui/tui-data.h (struct tui_win_info)
5931         (struct tui_source_window_base) <update_tab_width>: New methods.
5932
5933 2019-06-25  Tom Tromey  <tom@tromey.com>
5934
5935         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5936         parameter.
5937         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5938         parameter.
5939         (tui_gen_win_info::make_visible): Update.
5940         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5941         parameter.
5942         * tui/tui-data.h (enum tui_box): New enum.
5943         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5944
5945 2019-06-25  Tom Tromey  <tom@tromey.com>
5946
5947         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5948         init_and_make_win for EXEC_INFO_WIN.
5949         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5950         longer inline.
5951         (struct tui_win_info) <~tui_win_info>: Inline.
5952         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5953         Don't declare.
5954         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5955         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5956         Remove.
5957         (tui_initialize_static_data): Update.
5958         (~tui_gen_win_info): Handle more cleanup here.
5959         (~tui_source_window_base): Delete "execution_info".
5960         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5961
5962 2019-06-25  Tom Tromey  <tom@tromey.com>
5963
5964         * tui/tui-layout.c (make_command_window): Don't set
5965         can_highlight.
5966         (show_source_disasm_command): Call the reset method.
5967         (show_data): Don't set can_highlight.  Call the reset method.
5968         (tui_gen_win_info::reset): Rename from init_gen_win_info
5969         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5970         (show_source_or_disasm_and_command): Call the reset method.
5971         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5972         (struct tui_cmd_window): Set can_highlight.
5973
5974 2019-06-25  Tom Tromey  <tom@tromey.com>
5975
5976         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5977         from make_visible.
5978         (tui_make_visible, tui_make_invisible): Rewrite.
5979         (tui_win_info::make_visible): Remove.
5980         (tui_source_window_base::make_visible): Update.
5981         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5982         method.  Moved from...
5983         (struct tui_win_info) <make_visible>: ...here.
5984
5985 2019-06-25  Tom Tromey  <tom@tromey.com>
5986
5987         * tui/tui-winsource.c
5988         (tui_source_window_base::do_scroll_horizontal): Remove direction
5989         parameter.
5990         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5991         direction parameter.
5992         * tui/tui-win.c (tui_win_info::forward_scroll)
5993         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5994         (tui_win_info::right_scroll): Update.
5995         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5996         direction parameter.
5997         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5998         direction parameter.
5999         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6000         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6001         Remove direction parameter.
6002         (struct tui_source_window_base, struct tui_source_window)
6003         (struct tui_disasm_window, struct tui_data_window)
6004         (struct tui_cmd_window): Update.
6005
6006 2019-06-25  Tom Tromey  <tom@tromey.com>
6007
6008         * tui/tui-winsource.h (tui_set_exec_info_content)
6009         (tui_show_exec_info_content, tui_erase_exec_info_content)
6010         (tui_clear_exec_info_content, tui_update_exec_info): Change
6011         argument to tui_source_window_base.
6012         * tui/tui-winsource.c (tui_set_exec_info_content)
6013         (tui_show_exec_info_content, tui_erase_exec_info_content)
6014         (tui_clear_exec_info_content, tui_update_exec_info): Change
6015         argument to tui_source_window_base.
6016
6017 2019-06-25  Tom Tromey  <tom@tromey.com>
6018
6019         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6020         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6021
6022 2019-06-25  Tom Tromey  <tom@tromey.com>
6023
6024         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6025         check.
6026
6027 2019-06-25  Tom Tromey  <tom@tromey.com>
6028
6029         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6030         type to void.
6031         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6032         type to void.
6033         * tui/tui-source.c (tui_set_source_content): Update.
6034         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6035
6036 2019-06-25  Tom Tromey  <tom@tromey.com>
6037
6038         * tui/tui-win.c (window_name_completer, tui_set_focus)
6039         (tui_all_windows_info): Use name method.
6040         * tui/tui-data.h (struct tui_gen_win_info)
6041         (struct tui_source_window, struct tui_disasm_window)
6042         (struct tui_data_window, struct tui_cmd_window) <name>: New
6043         method.
6044         (tui_win_name): Don't declare.
6045         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6046         (tui_win_name): Remove.
6047
6048 2019-06-25  Tom Tromey  <tom@tromey.com>
6049
6050         * tui/tui-winsource.h (tui_update_source_window)
6051         (tui_update_source_window_as_is): Change parameter type.
6052         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6053         to be a tui_source_window_base.
6054         (tui_update_source_window_as_is): Likewise.
6055         * tui/tui-win.c (make_visible_with_new_height): Update.
6056
6057 2019-06-25  Tom Tromey  <tom@tromey.com>
6058
6059         * tui/tui-winsource.c (tui_erase_source_content)
6060         (tui_show_source_content, tui_show_exec_info_content)
6061         (tui_erase_exec_info_content): Use refresh_window method.
6062         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6063         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6064         from tui_refresh_win.
6065         (tui_data_window::refresh_window): New method.
6066         (tui_win_info::refresh, tui_source_window_base::refresh)
6067         (tui_refresh_all): Use refresh_window method.
6068         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6069         method.
6070         * tui/tui-regs.c (tui_display_register): Call refresh_window
6071         method.
6072         * tui/tui-layout.c (show_source_disasm_command)
6073         (show_source_or_disasm_and_command): Call refresh_window method.
6074         * tui/tui-data.h (struct tui_gen_win_info)
6075         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6076         New method.
6077
6078 2019-06-25  Tom Tromey  <tom@tromey.com>
6079
6080         * tui/tui.c (tui_rl_other_window, tui_enable)
6081         (tui_is_window_visible, tui_get_command_dimension): Update.
6082         * tui/tui-winsource.c (tui_update_source_window_as_is)
6083         (tui_clear_source_content, tui_erase_source_content)
6084         (tui_show_source_line, tui_source_window_base::refill)
6085         (tui_source_window_base::do_scroll_horizontal)
6086         (tui_source_window_base::set_is_exec_point_at)
6087         (tui_update_breakpoint_info, tui_set_exec_info_content)
6088         (tui_alloc_source_buffer, tui_line_is_displayed)
6089         (tui_addr_is_displayed): Update.
6090         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6091         (tui_check_and_display_highlight_if_needed)
6092         (tui_win_info::make_visible, tui_win_info::refresh)
6093         (tui_refresh_all): Update.
6094         * tui/tui-windata.c (tui_first_data_item_displayed)
6095         (tui_delete_data_content_windows, tui_erase_data_content)
6096         (tui_display_all_data, tui_data_window::refresh_all)
6097         (tui_check_data_values): Update.
6098         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6099         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6100         (tui_win_info::backward_scroll, tui_refresh_all_win)
6101         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6102         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6103         (tui_source_window_base::set_new_height)
6104         (tui_data_window::set_new_height)
6105         (make_invisible_and_set_new_height)
6106         (make_visible_with_new_height, new_height_ok)
6107         (parse_scrolling_args): Update.
6108         * tui/tui-stack.c (tui_show_frame_info): Update.
6109         * tui/tui-source.c (tui_set_source_content)
6110         (tui_set_source_content_nil, tui_source_is_displayed)
6111         (tui_source_window::do_scroll_vertical): Update.
6112         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6113         (tui_display_registers_from, tui_display_reg_element_at_line)
6114         (tui_check_register_values, tui_reg_command): Update.
6115         * tui/tui-layout.c (tui_default_win_height)
6116         (show_source_disasm_command, show_data, init_and_make_win)
6117         (show_source_or_disasm_and_command): Update.
6118         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6119         (tui_redisplay_readline, tui_mld_flush)
6120         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6121         (tui_getc): Update.
6122         * tui/tui-disasm.c (tui_set_disassem_content)
6123         (tui_disasm_window::do_scroll_vertical): Update.
6124         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6125         Now virtual.
6126         (struct tui_win_info): Derive from tui_gen_win_info.
6127         <~tui_win_info>: Mark as override.
6128         <generic>: Remove member.
6129         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6130         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6131         (~tui_data_window, ~tui_win_info)
6132         (tui_free_all_source_wins_content): Update.
6133         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6134
6135 2019-06-25  Tom Tromey  <tom@tromey.com>
6136
6137         * tui/tui-layout.c (init_and_make_win): Use new.
6138         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6139         destructor, initializers.
6140         (tui_alloc_generic_win_info): Don't declare.
6141         * tui/tui-data.c (_locator): Add argument to constructor.
6142         (source_win, disasm_win): New globals.
6143         (exec_info): Remove.
6144         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6145         Update.
6146         (tui_alloc_generic_win_info): Remove.
6147         (init_content_element): Use new.
6148         (tui_win_info::tui_win_info): Update.
6149         (free_content_elements) <case DATA_WIN>: Use delete.
6150
6151 2019-06-25  Tom Tromey  <tom@tromey.com>
6152
6153         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6154         * tui/tui-windata.c (tui_first_data_item_displayed)
6155         (tui_delete_data_content_windows): Update.
6156         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6157         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6158         (tui_display_registers_from, tui_check_register_values): Update.
6159         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6160         pointer.
6161         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6162         window.
6163         (tui_free_data_content): Update.
6164         (free_content_elements) <case DATA_WIN>: Free the window.
6165
6166 2019-06-25  Tom Tromey  <tom@tromey.com>
6167
6168         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6169         Update.
6170         * tui/tui-layout.c (make_command_window)
6171         (show_source_disasm_command, show_data, init_and_make_win)
6172         (show_source_or_disasm_and_command): Update.
6173         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6174         method.
6175         <can_highight, is_highlighted>: Now bool.
6176         (tui_set_win_highlight): Don't declare.
6177         * tui/tui-data.c (tui_set_win_highlight): Remove.
6178
6179 2019-06-25  Tom Tromey  <tom@tromey.com>
6180
6181         * tui/tui-wingeneral.c (make_visible): Remove check of window
6182         type.
6183
6184 2019-06-25  Tom Tromey  <tom@tromey.com>
6185
6186         * tui/tui-win.c (tui_win_info::max_height)
6187         (tui_cmd_window::max_height): New methods.
6188         (new_height_ok): Call max_height.
6189         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6190         <max_height>: New method.
6191
6192 2019-06-25  Tom Tromey  <tom@tromey.com>
6193
6194         * tui/tui-win.c (tui_source_window_base::set_new_height)
6195         (tui_data_window::set_new_height): New methods.
6196         (make_invisible_and_set_new_height): Call set_new_height method.
6197         * tui/tui-data.h (struct tui_win_info)
6198         (struct tui_source_window_base, struct tui_data_window)
6199         <set_new_height>: New method.
6200
6201 2019-06-25  Tom Tromey  <tom@tromey.com>
6202
6203         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6204         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6205         tui_refresh_data_win.
6206         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6207         method.
6208         (tui_refresh_all_win): Call the refresh_all method.
6209         (tui_set_focus): Likewise.
6210         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6211         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6212         Likewise.
6213
6214 2019-06-25  Tom Tromey  <tom@tromey.com>
6215
6216         * tui/tui-winsource.h (tui_refill_source_window)
6217         (tui_set_is_exec_point_at): Don't declare.
6218         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6219         (tui_source_window_base::refill): Rename from
6220         tui_refill_source_window.
6221         (tui_source_window_base::do_scroll_horizontal): Update.
6222         (tui_source_window_base::set_is_exec_point_at): Rename from
6223         tui_set_is_exec_point_at.
6224         (tui_update_all_breakpoint_info): Update.
6225         * tui/tui-stack.c (tui_show_frame_info): Update.
6226         * tui/tui-layout.c (show_data): Add cast.
6227         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6228         * tui/tui-data.h (struct tui_source_window_base) <refill,
6229         set_is_exec_point_at>: New methods.
6230         (tui_source_windows, tui_add_to_source_windows): Update types.
6231         (tui_add_to_source_windows): Remove redundant declaration.
6232         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6233         (tui_source_windows): Change return type.
6234         (tui_clear_source_windows_detail): Update.
6235         (tui_add_to_source_windows): Change type of parameter.
6236         (tui_free_all_source_wins_content): Update.
6237
6238 2019-06-25  Tom Tromey  <tom@tromey.com>
6239
6240         * tui/tui-wingeneral.c (tui_win_info::refresh)
6241         (tui_source_window_base::refresh): New methods.
6242         (tui_refresh_all): Call the refresh method.
6243         * tui/tui-data.h (struct tui_win_info)
6244         (struct tui_source_window_base) <refresh>: New method.
6245
6246 2019-06-25  Tom Tromey  <tom@tromey.com>
6247
6248         * tui/tui.h (tui_is_window_visible): Return bool.
6249         * tui/tui.c (tui_is_window_visible): Return bool.
6250         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6251         (tui_make_visible, tui_make_invisible)
6252         (tui_win_info::make_visible)
6253         (tui_source_window_base::make_visible, make_all_visible)
6254         (tui_make_all_visible, tui_make_all_invisible): Update.
6255         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6256         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6257         bool.
6258         (struct tui_win_info, struct tui_source_window_base)
6259         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6260         * tui/tui-data.c (tui_init_generic_part): Update.
6261
6262 2019-06-25  Tom Tromey  <tom@tromey.com>
6263
6264         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6265         (tui_source_window_base::make_visible): New methods.
6266         (make_all_visible): Make method call.
6267         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6268         (struct tui_source_window_base, struct tui_cmd_window): Override
6269         make_visible.
6270         (tui_win_is_source_type): Don't declare.
6271         * tui/tui-data.c (tui_win_is_source_type): Remove.
6272
6273 2019-06-25  Tom Tromey  <tom@tromey.com>
6274
6275         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6276         NULL check.
6277
6278 2019-06-25  Tom Tromey  <tom@tromey.com>
6279
6280         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6281         Inline constructor.  Add initializers for members.
6282         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6283         constructors; now inline in class.
6284
6285 2019-06-25  Tom Tromey  <tom@tromey.com>
6286
6287         * tui/tui-regs.c (tui_show_registers): Update.
6288         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6289         bool.
6290         * tui/tui-data.c (tui_data_window::clear_detail)
6291         (tui_data_window): Update.
6292
6293 2019-06-25  Tom Tromey  <tom@tromey.com>
6294
6295         * tui/tui-windata.c (tui_display_all_data)
6296         (tui_display_data_from_line, tui_display_data_from)
6297         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6298         Update.
6299         * tui/tui-regs.c (tui_last_regs_line_no)
6300         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6301         (tui_show_registers, tui_show_register_group)
6302         (tui_display_registers_from, tui_display_reg_element_at_line)
6303         (tui_display_registers_from_line, tui_check_register_values)
6304         (tui_reg_next, tui_reg_prev): Update.
6305         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6306         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6307         tui_data_window.
6308         (struct tui_win_info) <detail>: Remove.  Add new fields from
6309         tui_data_info.
6310         (TUI_DATA_WIN): Add cast.
6311         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6312         (~tui_data_window): Simplify.
6313
6314 2019-06-25  Tom Tromey  <tom@tromey.com>
6315
6316         * tui/tui-layout.c (show_source_disasm_command)
6317         (show_source_or_disasm_and_command): Update.
6318         * tui/tui-io.c (update_cmdwin_start_line)
6319         (tui_redisplay_readline): Update.
6320         * tui/tui-data.h (struct tui_command_info): Remove.
6321         (struct tui_win_info) <detail>: Remove command_info member.
6322         (struct tui_data_window) <start_line>: New member, from
6323         tui_command_info.
6324         (TUI_CMD_WIN): Add casts.
6325
6326 2019-06-25  Tom Tromey  <tom@tromey.com>
6327
6328         * tui/tui-winsource.c (tui_update_source_window)
6329         (tui_refill_source_window)
6330         (tui_source_window_base::do_scroll_horizontal)
6331         (tui_update_breakpoint_info, tui_set_exec_info_content)
6332         (tui_show_exec_info_content, tui_erase_exec_info_content)
6333         (tui_clear_exec_info_content): Update.
6334         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6335         Update.
6336         * tui/tui-win.c (make_invisible_and_set_new_height)
6337         (make_visible_with_new_height): Update.
6338         * tui/tui-source.c (tui_set_source_content)
6339         (tui_show_symtab_source): Update.
6340         * tui/tui-layout.c (extract_display_start_addr)
6341         (show_source_disasm_command, show_data)
6342         (make_source_or_disasm_window)
6343         (show_source_or_disasm_and_command): Update.
6344         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6345         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6346         "gdbarch".
6347         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6348         to tui_source_window_base.
6349         (struct tui_win_info) <detail>: Remove source_info member.
6350         (struct tui_source_window_base) <has_locator>: Inline.
6351         Move contents from tui_source_info; rename has_locator member to
6352         m_has_locator.
6353         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6354         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6355         header file.
6356         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6357         Simplify.
6358         (tui_free_all_source_wins_content): Cast to
6359         tui_source_window_base.
6360
6361 2019-06-25  Tom Tromey  <tom@tromey.com>
6362
6363         * tui/tui-win.c (make_invisible_and_set_new_height)
6364         (make_visible_with_new_height): Call has_locator method.
6365         * tui/tui-layout.c (show_source_disasm_command, show_data)
6366         (show_source_or_disasm_and_command): Update for bool change.
6367         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6368         (tui_win_info) <has_locator>: New method.
6369         (struct tui_source_window_base) <has_locator>: New method.
6370         (tui_win_has_locator): Don't declare.
6371         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6372         from tui_win_has_locator.
6373         (tui_source_window_base): Use false, not FALSE.
6374
6375 2019-06-25  Tom Tromey  <tom@tromey.com>
6376
6377         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6378         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6379         clear_detail method directly.
6380         (tui_clear_win_detail): Remove.
6381
6382 2019-06-25  Tom Tromey  <tom@tromey.com>
6383
6384         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6385         "this", not TUI_DISASM_WIN.
6386
6387 2019-06-25  Tom Tromey  <tom@tromey.com>
6388
6389         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6390         declare.
6391         * tui/tui-winsource.c
6392         (tui_source_window_base::do_scroll_horizontal): Rename from
6393         tui_horizontal_source_scroll.
6394         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6395         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6396         from tui_vertical_data_scroll.
6397         * tui/tui-win.h (tui_scroll): Don't declare.
6398         * tui/tui-win.c (tui_win_info::forward_scroll)
6399         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6400         (tui_win_info::right_scroll): Rename and update.
6401         (tui_scroll_forward_command, tui_scroll_backward_command)
6402         (tui_scroll_left_command, tui_scroll_right_command): Update.
6403         (tui_scroll): Remove.
6404         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6405         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6406         from tui_vertical_source_scroll.
6407         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6408         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6409         from tui_vertical_disassem_scroll.
6410         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6411         do_scroll_horizontal>: New methods.
6412         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6413         Likewise.
6414         (struct tui_source_window_base): Add do_scroll_horizontal.
6415         (struct tui_source_window, struct tui_disasm_window): Add
6416         do_scroll_vertical.
6417         (struct tui_data_window, struct tui_cmd_window): Add
6418         do_scroll_horizontal and do_scroll_vertical.
6419         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6420
6421 2019-06-25  Tom Tromey  <tom@tromey.com>
6422
6423         * tui/tui-data.h (struct tui_source_window_base): New struct.
6424         (struct tui_source_window): Derive from tui_source_window_base.
6425         (struct tui_disasm_window): New struct.
6426         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6427         from tui_source_window::clear_detail.
6428         (tui_source_window_base): Rename from tui_source_window.
6429         (~tui_source_window_base): Rename from ~tui_source_window.
6430         (tui_alloc_win_info): Create a tui_disasm_window.
6431
6432 2019-06-25  Tom Tromey  <tom@tromey.com>
6433
6434         * tui/tui-data.h (struct tui_source_window)
6435         (struct tui_data_window): Declare destructors.
6436         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6437         destructors.
6438         (tui_win_info): Simplify.
6439
6440 2019-06-25  Tom Tromey  <tom@tromey.com>
6441
6442         * tui/tui-winsource.c (tui_display_main)
6443         (tui_update_source_windows_with_addr)
6444         (tui_update_all_breakpoint_info): Update.
6445         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6446         (new_height_ok, parse_scrolling_args): Update.
6447         * tui/tui-stack.c (tui_show_frame_info): Update.
6448         * tui/tui-data.h (struct tui_list): Remove.
6449         (tui_source_windows): Return a reference to a std::vector.
6450         * tui/tui-data.c (source_windows): Now a std::vector.
6451         (tui_source_windows): Change return type.
6452         (tui_clear_source_windows): Rewrite.
6453         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6454         (tui_free_all_source_wins_content): Rewrite.
6455
6456 2019-06-25  Tom Tromey  <tom@tromey.com>
6457
6458         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6459         (struct tui_data_window, struct tui_cmd_window): Declare
6460         clear_detail method.
6461         * tui/tui-data.c (tui_source_window::clear_detail)
6462         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6463         methods.
6464         (tui_clear_win_detail): Simplify.
6465
6466 2019-06-25  Tom Tromey  <tom@tromey.com>
6467
6468         * tui/tui-layout.c (make_source_window, make_disasm_window)
6469         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6470         Return the new window.
6471         (show_source_disasm_command, show_data)
6472         (show_source_or_disasm_and_command): Update.
6473
6474 2019-06-25  Tom Tromey  <tom@tromey.com>
6475
6476         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6477         parameter.  Return the new window.
6478         (show_source_disasm_command): Update and remove NULL check.
6479         (show_source_or_disasm_and_command): Update.
6480
6481 2019-06-25  Tom Tromey  <tom@tromey.com>
6482
6483         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6484
6485 2019-06-25  Tom Tromey  <tom@tromey.com>
6486
6487         * tui/tui-data.h (struct tui_win_info): Make constructor
6488         protected.  Make destructor virtual.  Add initializers.
6489         (tui_source_window, tui_data_window, tui_cmd_window): New
6490         classes.
6491         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6492         constructor.  Add "type" parameter.
6493         (tui_source_window, tui_data_window, tui_cmd_window): New
6494         constructors.
6495         (tui_alloc_win_info): Instantiate the appropriate subclass.
6496
6497 2019-06-25  Tom Tromey  <tom@tromey.com>
6498
6499         * tui/tui-win.c (tui_resize_all): Use delete.
6500         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6501         destructor.
6502         (tui_free_window): Don't declare.
6503         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6504         Update.
6505
6506 2019-06-25  Tom Tromey  <tom@tromey.com>
6507
6508         * tui/tui-data.h (struct tui_win_info): Add constructor.
6509         * tui/tui-data.c (tui_alloc_win_info): Use new.
6510         (tui_free_window): Use delete.
6511
6512 2019-06-22  Tom Tromey  <tom@tromey.com>
6513
6514         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6515         declare.
6516         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6517
6518 2019-06-22  Tom Tromey  <tom@tromey.com>
6519
6520         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6521         declare.
6522         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6523
6524 2019-06-22  Tom de Vries  <tdevries@suse.de>
6525
6526         * dwarf2read.c (create_addrmap_from_aranges)
6527         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6528         instead of '%zu'.
6529
6530 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6531
6532         * dwarf2read.h (dwarf2_section_info_def): Remove.
6533         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6534         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6535         std::vector<dwarf2_section_info>.
6536         (struct dwo_file) <~dwo_file>: Remove.
6537         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6538         types field.
6539         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6540         (dwarf2_read_debug_names): Likewise.
6541         (create_debug_types_hash_table): Change parameter type to
6542         array_view, adjust code accordingly.
6543         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6544         (partial_die_info::fixup): Likewise.
6545         (determine_prefix): Likewise.
6546         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6547
6548 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6549
6550         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6551         gdb_bfd_ref_ptr.
6552         <~dwo_file>: Remove call to gdb_bfd_unref.
6553         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6554         gdb_bfd_ref_ptr::get.
6555
6556 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6557
6558         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6559         type to htab_up.
6560         * dwarf2read.c (struct dwo_file): Initialize fields.
6561         <~dwo_file>: New.
6562         (free_dwo_file): Remove, move content to ~dwo_file.
6563         (struct dwo_file_deleter): Remove.
6564         (dwo_file_up>: Remove custom deleter.
6565         (free_dwo_files): Remove.
6566         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6567         dwo_files.
6568         (process_skeletonless_type_units): Call unique_ptr::get.
6569         (allocate_dwo_file_hash_table): Add deleter to created hash
6570         table.  Change return type to htab_up.
6571         (lookup_dwo_file_slot): Don't memset dwo_file, call
6572         unique_ptr::get.
6573         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6574         (create_dwo_unit_in_dwp_v2): Likewise.
6575         (open_and_init_dwo_file): Likewise.
6576         (free_dwo_file_from_slot): Remove.
6577
6578 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6579
6580         * dwarf2read.h (struct dwarf2_section_info) <readin,
6581         is_virtual>: Change type to bool.
6582         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6583         true instead of 1.
6584
6585 2019-06-19  Tom Tromey  <tom@tromey.com>
6586
6587         * tui/tui-data.h (tui_init_content_element): Don't declare.
6588
6589 2019-06-19  Tom Tromey  <tom@tromey.com>
6590
6591         * tui/tui-data.h (tui_init_win_info): Don't declare.
6592
6593 2019-06-19  Tom de Vries  <tdevries@suse.de>
6594
6595         * dwarf2read.h (abstract_to_concrete): Change type to
6596         std::unordered_map<sect_offset, std::vector<sect_offset>,
6597         gdb::hash_enum<sect_offset>>.
6598
6599 2019-06-19  Tom Tromey  <tromey@adacore.com>
6600
6601         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6602         EVAL_AVOID_SIDE_EFFECTS specially.
6603
6604 2019-06-19  Tom Tromey  <tromey@adacore.com>
6605
6606         * source-cache.c (highlighter): New global.
6607         (source_cache::get_source_lines): Create a highlighter on demand.
6608
6609 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6610
6611         * defs.h (deprecated_interactive_hook): Delete declaration.
6612         * interps.c (clear_interpreter_hooks): Remove use of
6613         deprecated_interactive_hook.
6614         * top.c (deprecated_interactive_hook): Delete definition.
6615         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6616
6617 2019-06-18  Tom de Vries  <tdevries@suse.de>
6618
6619         PR gdb/24515
6620         * dwarf2read.h (abstract_to_concrete): Change type from
6621         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6622         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6623         * dwarf2read.c (read_variable): Update.
6624         (dwarf2_fetch_die_loc_sect_off): Update.
6625
6626 2019-06-17  Tom de Vries  <tdevries@suse.de>
6627
6628         PR gdb/24617
6629         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6630         accessing parent[parent_len - 1].
6631
6632 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6633
6634         PR gdb/24364
6635         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6636         call dtrace_process_dof with NULL dof.
6637
6638 2019-06-16  Tom de Vries  <tdevries@suse.de>
6639
6640         PR gdb/24445
6641         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6642
6643 2019-06-16  Tom Tromey  <tom@tromey.com>
6644
6645         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6646         (make_all_visible): Use address of member.
6647
6648 2019-06-16  Tom Tromey  <tom@tromey.com>
6649
6650         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6651         (tui_free_window, free_content, free_content_elements): Remove
6652         unnecessary cast.
6653         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6654         cast.
6655         * tui/tui-regs.c (tui_show_register_group)
6656         (tui_display_registers_from, tui_display_reg_element_at_line):
6657         Remove unnecessary cast.
6658
6659 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6660
6661         * linux-nat.c (normal_mask): Delete.
6662         (_initialize_linux_nat): Don't initialise normal_mask.
6663
6664 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6665
6666         PR gdb/24445
6667         * dwarf-index-write.h (write_psymtabs_to_index): Add
6668         dwz_basename parameter.
6669         * dwarf-index-write.c (write_gdbindex): Move file writing to
6670         write_gdbindex_1.  Change return type void.
6671         (assert_file_size): Move up, remove filename parameter.
6672         (write_gdbindex_1): New function.
6673         (write_debug_names): Change return type to void, call
6674         assert_file_size.
6675         (struct index_wip_file): New struct.
6676         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6677         file logic to index_wip_file.  Write index for dwz file if
6678         needed.
6679         (save_gdb_index_command): Pass basename of dwz file, if present.
6680         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6681         build-id of dwz file, if present.
6682         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6683         (dwarf2_get_dwz_file): Likewise.
6684         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6685         (dwarf2_get_dwz_file): Likewise.
6686
6687 2019-06-16  Tom Tromey  <tom@tromey.com>
6688
6689         * coffread.c (process_coff_symbol): Use xstrdup.
6690         * value.c (create_internalvar): Use xstrdup.
6691
6692 2019-06-16  Tom Tromey  <tom@tromey.com>
6693
6694         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6695         * breakpoint.c (stopin_command, stopat_command)
6696         (until_break_command, decode_location_default): Remove unnecessary
6697         cast.
6698         * utils.c (subset_compare): Remove unnecessary cast.
6699         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6700         cast.
6701         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6702         cast.
6703         * infcmd.c (path_command): Remove unnecessary cast.
6704         * coffread.c (decode_type): Remove unnecessary cast.
6705         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6706         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6707         * tui/tui-stack.c (tui_show_locator_content)
6708         (tui_show_frame_info): Remove unnecessary cast.
6709         * tui/tui-win.c (tui_scroll_forward_command)
6710         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6711         (parse_scrolling_args): Remove unnecessary cast.
6712         * tui/tui-data.c (init_win_info, tui_del_window)
6713         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6714         (free_content_elements): Remove unnecessary cast.
6715         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6716         unnecessary cast.
6717         * tui/tui-source.c (tui_set_source_content)
6718         (tui_vertical_source_scroll): Remove unnecessary cast.
6719         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6720         cast.
6721         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6722         * tui/tui-regs.c (tui_display_registers_from)
6723         (tui_display_register): Remove unnecessary cast.
6724         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6725         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6726         (make_visible): Remove unnecessary cast.
6727         * tui/tui-winsource.c (tui_erase_source_content)
6728         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6729         unnecessary cast.
6730         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6731         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6732         * stabsread.c (read_type, read_array_type, read_range_type):
6733         Remove unnecessary cast.
6734         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6735         (parse_symbol, parse_type, upgrade_type, parse_external)
6736         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6737         unnecessary cast.
6738         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6739
6740 2019-06-16  Tom Tromey  <tom@tromey.com>
6741
6742         * tui/tui-data.c (tui_alloc_generic_win_info)
6743         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6744         checks.
6745
6746 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6747             Andrew Burgess  <andrew.burgess@embecosm.com>
6748
6749         * f-typeprint.c (f_print_type): Don't return early for not
6750         associated or not allocated types.
6751         (f_type_print_varspec_suffix): Add print_rank parameter and print
6752         ranks of array types in case they dangling.
6753         (f_type_print_base): Add print_rank parameter.
6754
6755 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6756
6757         * NEWS: Mention new MI commands.
6758         * break-catch-throw.c (enum exception_event_kind): Move to
6759         breakpoint.h.
6760         (print_mention_exception_catchpoint): Output text as a single
6761         message.
6762         (catch_exception_command_1): Rename to...
6763         (catch_exception_event): ...this, make non-static, update header
6764         command, and change some parameter types.
6765         (catch_catch_command): Update for changes to
6766         catch_exception_command_1.
6767         (catch_throw_command): Likewise.
6768         (catch_rethrow_command): Likewise.
6769         * breakpoint.c (enum exception_event_kind): Delete.
6770         * breakpoint.h (enum exception_event_kind): Moved here from
6771         break-catch-throw.c.
6772         (catch_exception_event): Declare.
6773         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6774         (mi_cmd_catch_throw): New function.
6775         (mi_cmd_catch_rethrow): New function.
6776         (mi_cmd_catch_catch): New function.
6777         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6778         'catch-catch' entries.
6779         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6780         (mi_cmd_catch_rethrow): Declare.
6781         (mi_cmd_catch_catch): Declare.
6782
6783 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6784
6785         * annotate.c (annotate_source_line): Change return type to void,
6786         update implementation to match.
6787         * annotate.h (annotate_source_line): Change return type to void,
6788         update header comment.
6789         * stack.c (print_frame_info): Don't change what frame information
6790         is printed based on whether annotations are on or not.
6791
6792 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6793
6794         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6795         (annotate_source): Make static.
6796         (annotate_source_line): Moved from source.c and renamed from
6797         identify_source_line.  Update the return type.
6798         * annotate.h (annotate_source): Delete declaration.
6799         (annotate_source_line): Declaration moved from source.h, and
6800         renamed from identify_source_line.  Return type updated.
6801         * source.c (identify_source_line): Moved to annotate.c and renamed
6802         to annotate_source_line.
6803         (info_line_command): Remove check of annotation_level.
6804         * source.h (identify_source_line): Move declaration to annotate.h
6805         and rename to annotate_source_line.
6806         * stack.c: Add 'annotate.h' include.
6807         (print_frame_info): Remove check of annotation_level before
6808         calling annotate_source_line.
6809
6810 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6811
6812         * source-cache.c (source_cache::get_plain_source_lines): Use
6813         open_source_file_with_line_charpos instead of just
6814         open_source_file, remove call to find_source_lines.
6815         (source_cache::get_source_lines): Likewise.
6816         * source.c (find_source_lines): Make static.
6817         (get_filename_and_charpos): Renamed into...
6818         (open_source_file_with_line_charpos): ..this along with changes to
6819         return a scoped_fd, and some other minor clean ups.
6820         (identify_source_line): Use open_source_file_with_line_charpos.
6821         (search_command_helper): Use open_source_file_with_line_charpos
6822         instead of just open_source_file, remove call to
6823         find_source_lines.
6824         * source.h (open_source_file_with_line_charpos): Declare new
6825         function.
6826         (find_source_lines): Delete declaration.
6827
6828 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6829
6830         * source.c (get_filename_and_charpos): Remove fullname
6831         parameter.
6832         (identify_source_line): Update call to get_filename_and_charpos.
6833
6834 2019-06-14  Tom Tromey  <tromey@adacore.com>
6835
6836         PR gdb/24502:
6837         * ui-style.h (skip_ansi_escape): Update comment.
6838         * ui-file.h (class no_terminal_escape_file): New class.
6839         * ui-file.c (no_terminal_escape_file::write)
6840         (no_terminal_escape_file::puts): New methods.
6841         * cli/cli-logging.c (handle_redirections): Use
6842         no_terminal_escape_file.
6843
6844 2019-06-14  Tom Tromey  <tromey@adacore.com>
6845
6846         * NEWS: Move convenience variable news above Python news.
6847
6848 2019-06-14  Tom Tromey  <tom@tromey.com>
6849
6850         * gnulib: Move directory to top-level.
6851         * configure.ac: Don't configure gnulib.
6852         * configure: Rebuild.
6853         * common/common-defs.h: Use new path to gnulib.
6854         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6855         (GNULIB_H): Remove.
6856         (INCGNU): Look in new gnulib location.
6857         (HFILES_NO_SRCDIR): Remove gnulib files.
6858         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6859         (generated_files): Remove GNULIB_H.
6860         ($(LIBGNU), all-lib): Remove targets.
6861         (distclean): Don't mention GNULIB_BUILDDIR.
6862         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6863
6864 2019-06-14  Tom Tromey  <tromey@adacore.com>
6865
6866         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6867         Warn if symbol file does not provide any symbols.
6868
6869 2019-06-14  Tom Tromey  <tromey@adacore.com>
6870
6871         * source.c (find_and_open_source): Respect basenames_may_differ.
6872
6873 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6874
6875         * annotate.c (annotate_breakpoints_invalid): Make use of
6876         scoped_restore_terminal_state.
6877         (annotate_frames_invalid): Likewise.
6878
6879 2019-06-14  Tom Tromey  <tromey@adacore.com>
6880
6881         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6882         allow assignment to an internalvar.
6883
6884 2019-06-14  Tom Tromey  <tromey@adacore.com>
6885
6886         * ada-lex.l: Allow "_" in attribute names.
6887
6888 2019-06-14  Tom Tromey  <tromey@adacore.com>
6889
6890         PR gdb/24653:
6891         * regcache.c (registers_changed): Don't call alloca.
6892         * top.c (execute_command): Don't call alloca.
6893
6894 2019-06-13  Pedro Alves  <palves@redhat.com>
6895
6896         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6897         'expression'.  When parsing an expression, error out if there's
6898         junk after "unlimited".
6899         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6900         (do_set_command): Adjust calls to is_unlimited_literal.
6901
6902 2019-06-13  Pedro Alves  <palves@redhat.com>
6903
6904         * compile/compile.c (make_compile_options_def_group): Add braces
6905         around array_view initializer.
6906         * thread.c (make_thread_apply_all_options_def_group)
6907         (make_thread_apply_all_options_def_group): Likewise.
6908
6909 2019-06-13  Pedro Alves  <palves@redhat.com>
6910
6911         * NEWS (New commands): Mention "maint test-options
6912         require-delimiter", "maint test-options unknown-is-error", "maint
6913         test-options unknown-is-operand" and "maint show
6914         test-options-completion-result".
6915         (New command options, command completion): New section.
6916         (Completion improvements): New section.
6917         Mention that you can abbreviate "unlimited".
6918
6919 2019-06-13  Pedro Alves  <palves@redhat.com>
6920
6921         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6922         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6923         * unittests/cli-utils-selftests.c (test_parse_flags)
6924         (test_parse_flags_qcs): Delete.
6925         (test_cli_utils): Don't call deleted functions.
6926
6927 2019-06-13  Pedro Alves  <palves@redhat.com>
6928
6929         * thread.c: Include "cli/cli-option.h".
6930         (tp_array_compar_ascending): Global.
6931         (tp_array_compar): Delete function.
6932         (tp_array_compar_ascending, tp_array_compar_descending): New
6933         functions.
6934         (ascending_option_def, qcs_flag_option_def)
6935         (thr_qcs_flags_option_defs)
6936         (make_thread_apply_all_options_def_group)
6937         (make_thread_apply_options_def_group): New.
6938         (thread_apply_all_command): Use gdb::option::process_options.
6939         (thread_apply_command_completer)
6940         (thread_apply_all_command_completer): New.
6941         (thread_apply_command): Use gdb::option::process_options.
6942         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6943         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6944         to generate help text of "thread apply".  Adjust "taas"'s help.
6945         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6946         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6947
6948 2019-06-13  Pedro Alves  <palves@redhat.com>
6949
6950         * thread.c (thread_apply_command): Check for invalid TID with
6951         isdigit instead of !isalpha.
6952
6953 2019-06-13  Pedro Alves  <palves@redhat.com>
6954
6955         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6956         (validate_flags_qcs): New.
6957         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6958         (validate_flags_qcs): Declare.
6959         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6960         (make_frame_apply_options_def_group): New.
6961         (frame_apply_command_count): Process options with
6962         gdb::option::process_options.
6963         (frame_apply_completer): New.
6964         (frame_apply_level_completer, frame_apply_all_completer)
6965         (frame_apply_completer): New.
6966         (_initialize_stack): Update help of "frame apply", "frame apply
6967         level", "frame apply all" and "faas" to mention supported options
6968         and install command completers.
6969         * stack.h (frame_apply_all_completer): Declare.
6970         * thread.c: Include "stack.h".
6971         (tfaas_command): Add "--".
6972         (_initialize_thread): Update help "tfaas" to mention supported
6973         options and install command completer.
6974
6975 2019-06-13  Pedro Alves  <palves@redhat.com>
6976
6977         * completer.c (complete_nested_command_line): New.
6978         (gdb_completion_word_break_characters_throw): Add assertion.
6979         * completer.h (complete_nested_command_line): Declare.
6980
6981 2019-06-13  Pedro Alves  <palves@redhat.com>
6982
6983         * stack.c (parse_backtrace_qualifiers): New.
6984         (backtrace_command): Use it.
6985         (backtrace_command_completer): Complete on qualifiers.
6986
6987 2019-06-13  Pedro Alves  <palves@redhat.com>
6988
6989         * frame.c: Include "cli/cli-option.h.
6990         (user_set_backtrace_options): New.
6991         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6992         Delete.
6993         (get_prev_frame): Adjust.
6994         (boolean_option_def, uinteger_option_def)
6995         (set_backtrace_option_defs): New.
6996         (_initialize_frame): Adjust and use
6997         gdb::option::add_setshow_cmds_for_options to install "set
6998         backtrace past-main" and "set backtrace past-entry".
6999         * frame.h: Include "cli/cli-option.h".
7000         (struct frame_print_options): Forward declare.
7001         (print_frame_arguments_all, print_frame_arguments_scalars)
7002         (print_frame_arguments_none): Declare.
7003         (print_entry_values): Delete declaration.
7004         (struct frame_print_options, user_frame_print_options): New.
7005         (struct set_backtrace_options): New.
7006         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7007         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7008         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7009         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7010         (list_args_or_locals): Add frame_print_options parameter.
7011         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7012         * python/py-framefilter.c (enumerate_args): Pass down
7013         USER_FRAME_PRINT_OPTIONS.
7014         * stack.c: Include "cli/cli-option.h".
7015         (print_frame_arguments_all, print_frame_arguments_scalars)
7016         (print_frame_arguments_none): Declare.
7017         (print_raw_frame_arguments, print_entry_values): Delete.
7018         (user_frame_print_options): New.
7019         (boolean_option_def, enum_option_def, frame_print_option_defs):
7020         New.
7021         (struct backtrace_cmd_options): New.
7022         (bt_flag_option_def): New.
7023         (backtrace_command_option_defs): New.
7024         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7025         (print_frame_arg, read_frame_arg, print_frame_args)
7026         (print_frame_info, print_frame): Add frame_print_options parameter
7027         and use it.
7028         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7029         (backtrace_command_1): Add frame_print_options and
7030         backtrace_cmd_options parameters and use them.
7031         (make_backtrace_options_def_group): New.
7032         (backtrace_command): Process command options with
7033         gdb::option::process_options.
7034         (backtrace_command_completer): New.
7035         (_initialize_stack): Extend "backtrace"'s help to mention
7036         supported options.  Install completer for "backtrace".
7037         Install some settings commands with add_setshow_cmds_for_options.
7038
7039 2019-06-13  Pedro Alves  <palves@redhat.com>
7040
7041         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7042         and that "set/show print raw frame-arguments" are now deprecated.
7043
7044         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7045         command.
7046         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7047         * stack.c (_initialize_stack): Install "set/show print
7048         raw-frame-arguments", and deprecate "set/show print raw
7049         frame-arguments".
7050         * valprint.c (_initialize_valprint): Deprecate "set/show print
7051         raw".
7052
7053 2019-06-13  Pedro Alves  <palves@redhat.com>
7054
7055         * compile/compile.c (struct compile_options): New.
7056         (compile_flag_option_def, compile_command_option_defs)
7057         (make_compile_options_def_group): New.
7058         (compile_file_command): Handle options with
7059         gdb::option::process_options.
7060         (compile_file_command_completer): New function.
7061         (compile_code_command): Handle options with
7062         gdb::option::process_options.
7063         (compile_code_command_completer): New function.
7064         (_initialize_compiler): Install completers for "compile code" and
7065         "compile file".  Mention available options in "compile code" and
7066         "compile code"'s help.
7067         * completer.c (advance_to_completion_word): New, factored out from
7068         ...
7069         (advance_to_expression_complete_word_point): ... this.
7070         (advance_to_filename_complete_word_point): New.
7071         * completer.h (advance_to_filename_complete_word_point): New
7072         declaration.
7073
7074 2019-06-13  Pedro Alves  <palves@redhat.com>
7075
7076         * compile/compile.c: Include "cli/cli-option.h".
7077         (compile_print_value): Scope data pointer is now a
7078         value_print_options pointer; adjust.
7079         (compile_print_command): Process options.  Scope data pointer is
7080         now a value_print_options pointer; adjust.
7081         (_initialize_compile): Update "compile print"'s help to include
7082         supported options.  Install a completer for "compile print".
7083         * cp-valprint.c (show_vtblprint, show_objectprint)
7084         (show_static_field_print): Delete.
7085         (_initialize_cp_valprint): Don't install "set print
7086         static-members", "set print vtbl", "set print object" here.
7087         * printcmd.c: Include "cli/cli-option.h" and
7088         "common/gdb_optional.h".
7089         (print_command_parse_format): Rework to fill in a
7090         value_print_options instead of a format_data.
7091         (print_value): Change parameter type from format_data pointer to
7092         value_print_options reference.  Adjust.
7093         (print_command_1): Process options.  Adjust to pass down a
7094         value_print_options.
7095         (print_command_completer): New.
7096         (_initialize_printcmd): Install print_command_completer as
7097         handle_brkchars completer for the "print" command.  Update
7098         "print"'s help to include supported options.
7099         * valprint.c: Include "cli/cli-option.h".
7100         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7101         here from cp-valprint.c.
7102         (boolean_option_def, uinteger_option_def)
7103         (value_print_option_defs, make_value_print_options_def_group):
7104         New.  Use gdb::option::add_setshow_cmds_for_options to install
7105         "set print elements", "set print null-stop", "set print repeats",
7106         "set print pretty", "set print union", "set print array", "set
7107         print address", "set print symbol", "set print array-indexes".
7108         * valprint.h: Include <string> and "cli/cli-option.h".
7109         (make_value_print_options_def_group): Declare.
7110         (print_value): Change parameter type from format_data pointer to
7111         value_print_options reference.
7112         (print_command_completer): Declare.
7113
7114 2019-06-13  Pedro Alves  <palves@redhat.com>
7115
7116         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7117         (COMMON_SFILES): Add maint-test-settings.c.
7118         * cli/cli-decode.c (boolean_enums): New global, factored out from
7119         ...
7120         (add_setshow_boolean_cmd): ... here.
7121         * cli/cli-decode.h (boolean_enums): Declare.
7122         * cli/cli-option.c: New file.
7123         * cli/cli-option.h: New file.
7124         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7125         factored out from ...
7126         (parse_cli_boolean_value(const char *)): ... this.
7127         (is_unlimited_literal): Change parameter type to pointer to
7128         pointer.  Adjust and advance ARG pointer.
7129         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7130         (parse_cli_var_enum): New, factored out from ...
7131         (do_set_command): ... this.  Adjust.
7132         * cli/cli-setshow.h (parse_cli_boolean_value)
7133         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7134         (parse_cli_var_enum): Declare.
7135         * cli/cli-utils.c: Include "cli/cli-option.h".
7136         (get_ulongest): New.
7137         * cli/cli-utils.h (get_ulongest): Declare.
7138         (check_for_argument): New overloads.
7139         * maint-test-options.c: New file.
7140
7141 2019-06-13  Pedro Alves  <palves@redhat.com>
7142
7143         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7144         parse a range if "-" is at the end of the string.
7145
7146 2019-06-13  Pedro Alves  <palves@redhat.com>
7147
7148         * cli/cli-setshow.c (parse_auto_binary_operation)
7149         (parse_cli_boolean_value): Don't allow "o".
7150
7151 2019-06-13  Pedro Alves  <palves@redhat.com>
7152
7153         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7154         * NEWS: Mention maint test-settings KIND.
7155         * maint-test-settings.c: New file.
7156
7157 2019-06-13  Pedro Alves  <palves@redhat.com>
7158
7159         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7160         completer.
7161         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7162         "set" completers.
7163
7164 2019-06-13  Pedro Alves  <palves@redhat.com>
7165
7166         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7167         after item.
7168
7169 2019-06-13  Pedro Alves  <palves@redhat.com>
7170
7171         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7172
7173 2019-06-13  Pedro Alves <palves@redhat.com>
7174
7175         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7176         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7177         call.
7178         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7179         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7180         calls.
7181         (check_for_argument): Skip spaces after argument.
7182
7183 2019-06-13  Pedro Alves  <palves@redhat.com>
7184
7185         * thread.c (thread_apply_command): Adjust TID parsing.
7186         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7187         detected before end of string.
7188         (tid_is_in_list): Error out if LIST is invalid.
7189
7190 2019-06-13  Pedro Alves  <palves@redhat.com>
7191
7192         * completer.c (complete_line_internal_1): Rewind completion word
7193         point.
7194         (completion_tracker::advance_custom_word_point_by): Change
7195         parameter type to int.
7196         * completer.h (completion_tracker::advance_custom_word_point_by):
7197         Likewise.
7198
7199 2019-06-13  Pedro Alves  <palves@redhat.com>
7200
7201         * completer.c (advance_to_completion_word): Handle delimiters.
7202
7203 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7204
7205         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7206
7207 2019-06-11  Tom Tromey  <tom@tromey.com>
7208
7209         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7210         (xmalloc_failed): Move to alloc.c.
7211         * alloc.c: New file.
7212         * Makefile.in (COMMON_SFILES): Add alloc.c.
7213
7214 2019-06-11  Tom Tromey  <tom@tromey.com>
7215
7216         * nat/linux-waitpid.c: Don't include server.h.
7217         (linux_debug): Remove.
7218         (my_waitpid): Update.
7219
7220 2019-06-11  Tom Tromey  <tromey@adacore.com>
7221
7222         * infcall.c (_initialize_infcall): Remove trailing newline from
7223         help.
7224         * user-regs.c (_initialize_user_regs): Remove trailing newline
7225         from help.
7226         * typeprint.c (_initialize_typeprint): Remove trailing newline
7227         from help.
7228         * reverse.c (_initialize_reverse): Remove trailing newlines from
7229         help.
7230         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7231         from help.
7232         * language.c (add_set_language_command): Remove trailing newline
7233         from help.
7234         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7235         help.
7236         * disasm.c (_initialize_disasm): Remove trailing newline from
7237         help.
7238         * top.c (init_main): Remove trailing newline from help.
7239         * interps.c (_initialize_interpreter): Remove trailing newline
7240         from help.
7241         * btrace.c (_initialize_btrace): Remove trailing newlines from
7242         help.
7243         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7244         from help.
7245         * python/python.c (_initialize_python): Remove trailing newline
7246         from help.
7247         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7248         help.
7249         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7250         from help.  Reformat some text.
7251         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7252         from help.
7253         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7254         newline from help.
7255
7256 2019-06-11  Tom Tromey  <tromey@adacore.com>
7257
7258         * darwin-nat.c (darwin_decode_exception_message)
7259         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7260
7261 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7262
7263         * valops.c (value_slice): Check for not allocated or not
7264         associated values.
7265
7266 2019-06-10  Tom de Vries  <tdevries@suse.de>
7267
7268         PR gdb/24618
7269         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7270         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7271         invalid.
7272
7273 2019-06-10  Tom de Vries  <tdevries@suse.de>
7274
7275         PR gdb/24611
7276         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7277         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7278
7279 2019-06-10  Tom de Vries  <tdevries@suse.de>
7280
7281         PR symtab/24545
7282         * symtab.c (struct demangled_name_entry): Add language field.
7283         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7284         static minimal symbol".  Set and use language field.
7285
7286 2019-06-10  Tom Tromey  <tromey@adacore.com>
7287
7288         * ada-lang.c (_initialize_ada_language): Update help text.
7289
7290 2019-06-10  Tom Tromey  <tromey@adacore.com>
7291
7292         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7293         with a newline.
7294         * guile/guile.c (handle_boot_error): Don't end warning with a
7295         newline.
7296         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7297         warning with a newline.
7298         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7299         newline.
7300         (s12z_frame_cache): Likewise.
7301         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7302         a newline.
7303         * solib-svr4.c (disable_probes_interface): Don't end warning with
7304         a newline.
7305         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7306         newline.
7307         * python/python.c (do_finish_initialization): Don't end warning
7308         with a newline.
7309
7310 2019-06-10  Tom Tromey  <tom@tromey.com>
7311
7312         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7313         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7314         gdbpy_enter.
7315
7316 2019-06-10  Tom Tromey  <tromey@adacore.com>
7317
7318         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7319         data.
7320         (elf_new_init): Don't call stabsread_new_init.
7321         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7322         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7323         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7324
7325 2019-06-10  Tom de Vries  <tdevries@suse.de>
7326
7327         PR symtab/16264
7328         PR symtab/24517
7329         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7330
7331 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7332
7333         * source.c (find_and_open_source): Also rewrite relative file
7334         names.
7335
7336 2019-04-26  Amos Bird  <amosbird@gmail.com>
7337
7338         * annotate.c (annotate_thread_exited): Add "thread-exited"
7339         annotation.
7340
7341 2019-06-06  Tom Tromey  <tromey@adacore.com>
7342
7343         * maint.h (class scoped_command_stats): Use
7344         DISABLE_COPY_AND_ASSIGN.
7345         <print_time>: New method.
7346         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7347         print_time.
7348         (scoped_command_stats::print_time): New method.
7349
7350 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7351
7352         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7353         instructions of lengths 6 or 8 bytes.
7354
7355 2019-06-04  Pedro Alves  <palves@redhat.com>
7356
7357         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7358
7359         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7360         * breakpoint.c (condition_completer): Likewise.
7361         * cli/cli-dump.c (scan_expression): Likewise.
7362         * common/filestuff.c (mkdir_recursive): Likewise.
7363         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7364         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7365         (gdb_abspath): Likewise.
7366         * compile/compile-cplus-types.c
7367         (compile_cplus_instance::decl_name): Likewise.
7368         * completer.c (complete_explicit_location):
7369         (signal_completer, reg_or_group_completer_1): Likewise.
7370         * cp-support.c (cp_remove_params_if_any): Likewise.
7371         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7372         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7373         * infcmd.c (strip_bg_char): Likewise.
7374         * linespec.c (copy_token_string): Likewise.
7375         * mi/mi-main.c (output_cores): Likewise.
7376         * psymtab.c (psymtab_search_name):
7377         * symfile.c (test_set_ext_lang_command): Likewise.
7378         * target.c (target_fileio_read_stralloc): Likewise.
7379         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7380         * value.c (complete_internalvar): Likewise.
7381
7382 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7383
7384         Add objfile property to gdb.Type.
7385         * NEWS: Mention Python API addition.
7386         * python/py-type.c (typy_get_objfile): New method.
7387
7388 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7389
7390         * NEWS: Mention the new set|show style [title|highlight].
7391         Mention changes to "show style", "help" and "apropos".
7392
7393 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7394
7395         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7396         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7397         instead of print_help_for_command.
7398         (print_doc_of_command): New function.
7399         (help_list): Add 'apropos -v word' suggestion.
7400         (print_help_for_command): Style the command name using title style.
7401         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7402         (_initialize_cli_cmds): Describe -v in apropos_command help.
7403
7404 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7405
7406         * cli/cli-style.h (cli_style_option): Add name in constructor,
7407         add m_name class member, add constructor with intensity,
7408         add name class function.
7409         (cli_style_option::add_setshow_commands): Remove name argument.
7410         (highlight_style, title_style): New styles.
7411         * cli/cli-style.c (do_show): New function that shows a style
7412         characteristic styling the style name with itself.
7413         (set_style_name): New function.
7414         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7415         Update all callers according to the changes in cli/cli-style.h.
7416         * utils.h (fputs_highlighted): New function.
7417         * utils.c (fputs_highlighted): Likewise.
7418
7419 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7420
7421         * NEWS: Mention new pipe command and new convenience variables.
7422
7423 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7424
7425         * cli/cli-cmds.c (pipe_command): New function.
7426         (_initialize_cli_cmds): Call add_com for pipe_command.
7427         Define | as an alias for pipe.
7428         (exit_status_set_internal_vars): New function.
7429         (shell_escape): Call exit_status_set_internal_vars.
7430         cli/cli-decode.c (find_command_name_length): Recognize | as
7431         a single character command.
7432
7433 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7434
7435         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7436         top.c (execute_command_to_ui_file): New function, mostly a copy
7437         of execute_command_to_string.
7438         (execute_command_to_string): Implement by calling
7439         execute_command_to_ui_file.
7440
7441 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7442
7443         * top.h (saved_command_line): Remove declaration.
7444         * top.c (previous_saved_command_line, previous_repeat_arguments):
7445         New variables.
7446         (saved_command_line): Make static, define together with other
7447         'repeat variables'.
7448         (dont_repeat): Clear repeat_arguments.
7449         (repeat_previous, get_saved_command_line, save_command_line):
7450         New functions.
7451         (gdb_init): Initialize saved_command_line
7452         and previous_saved_command_line.
7453         * main.c (captured_main_1): Remove saved_command_line initialization.
7454         * event-top.c (handle_line_of_input): Update to use
7455         the new 'repeat' related functions instead of direct access to
7456         saved_command_line.
7457         * command.h (repeat_previous, get_saved_command_line,
7458         save_command_line): New declarations.
7459         (dont_repeat): Add comment.
7460
7461 2019-05-30  Tom Tromey  <tromey@adacore.com>
7462
7463         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7464         Fix comment.
7465         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7466
7467 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7468
7469         PR cli/24587
7470         * completer.c (complete): Initialize variable word.
7471
7472 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7473
7474         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7475         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7476         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7477         'body' is NULL to the outter 'if', protecting the '!is_define'
7478         situation as well.
7479
7480 2019-05-29  Tom Tromey  <tromey@adacore.com>
7481
7482         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7483         (dwarf_unknown): New function.
7484         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7485         (dwarf_type_encoding_name): Use dwarf_unknown.
7486
7487 2019-05-29  Tom Tromey  <tromey@adacore.com>
7488
7489         PR c++/20020:
7490         * cp-valprint.c (cp_print_value_fields): Call
7491         cp_print_static_field inside "try".
7492
7493 2019-05-29  Tom Tromey  <tromey@adacore.com>
7494
7495         * inflow.c (struct terminal_info): Add default operator=.
7496         * configure: Rebuild.
7497         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7498         -Wdeprecated-copy-dtor, -Wredundant-move.
7499
7500 2019-05-29  Tom Tromey  <tromey@adacore.com>
7501
7502         * NEWS: Add entry.
7503         * infcmd.c (print_return_value_1): Handle finish_print
7504         option.
7505         (show_print_finish): New function.
7506         (_initialize_infcmd): Add "set/show print finish" commands.
7507         * valprint.c (user_print_options): Initialize new member.
7508         * valprint.h (struct value_print_options) <finish_print>: New
7509         member.
7510
7511 2019-05-28  Tom Tromey  <tromey@adacore.com>
7512
7513         * ada-lang.c (ada_remove_Xbn_suffix)
7514         (find_old_style_renaming_symbol)
7515         (parse_old_style_renaming): Remove.
7516         (ada_find_renaming_symbol): Don't call
7517         find_old_style_renaming_symbol.
7518         (ada_is_renaming_symbol): Rename from
7519         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7520         bool.  Now static.
7521         (ada_read_var_value): Update and simplify.
7522         * ada-exp.y (write_var_or_type): Remove old code.
7523
7524 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7525
7526         PR gdb/25010
7527         * event-top.c: Remove include comment.
7528         * inflow.c (class scoped_ignore_sigttou): Move from here...
7529         * inflow.h (class scoped_ignore_sigttou): ...to here.
7530         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7531         * top.c:  Remove include comment.
7532
7533 2019-05-27  Tom Tromey  <tom@tromey.com>
7534
7535         * NEWS: Fix typo.
7536
7537 2019-05-22  Tom Tromey  <tromey@adacore.com>
7538
7539         * target.c (target_follow_exec): Constify parameter.
7540         * target-delegates.c: Rebuild.
7541         * remote.c (remote_target::follow_exec): Constify parameter.
7542         * infrun.c (follow_exec): Constify parameter.
7543         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7544         (target_follow_exec): Likewise.
7545
7546 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7547
7548         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7549         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7550
7551 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7552
7553         * NEWS: Add debugredirect and testsuite sections.
7554
7555 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7556
7557         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7558         target descriptions using exclusively floating point register name
7559         aliases.
7560
7561 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7562
7563         PR gdb/18644:
7564         * f-lang.c (build_fortran_types): Handle the case where
7565         gdbarch_floatformat_for_type returns a nullptr.
7566
7567 2019-05-21  Tom de Vries  <tdevries@suse.de>
7568
7569         PR cli/24587
7570         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7571
7572 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7573
7574         PR gdb/18644:
7575         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7576         16-byte floats.
7577         * i386-tdep.c (i386_floatformat_for_type): Use
7578         floatformats_ia64_quad for the 16-byte floating point component
7579         within a fortran 32-byte complex number.
7580
7581 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7582
7583         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7584         delete default constructor.
7585         (find_partial_die): Update to return const struct.
7586         (partial_die_parent_scope): Move variable declaration into scope
7587         of its use and change its type to auto.
7588         (guess_partial_die_structure_name): Likewise.
7589         (partial_die_info::fixup): Likewise.
7590
7591 2019-05-17  Tom Tromey  <tromey@adacore.com>
7592
7593         * source.c (find_and_open_source): Remove cast.
7594
7595 2019-05-17  Tom Tromey  <tromey@adacore.com>
7596
7597         * annotate.c (annotate_source): Make "filename" const.
7598         * annotate.h (annotate_source): Use const.
7599
7600 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7601
7602         * disasm.c (set_disassembler_options): Send errors to stderr.
7603
7604 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7605
7606         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7607         (cli_interp_base::set_logging): Check debug_redirect.
7608         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7609         * cli/cli-logging.c (debug_redirect): Add static variable.
7610         (pop_output_files): Add default param.
7611         (handle_redirections): Print debug setting.
7612         (show_logging_command): Likewise.
7613         (_initialize_cli_logging): Add debugredirect command.
7614         * interps.c (current_interp_set_logging): Add debug_redirect
7615         parameter.
7616         * interps.h (set_logging): Add debug_redirect parameter.
7617         (current_interp_set_logging): Likewise.
7618         * mi/mi-common.h: Likewise.
7619         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7620
7621 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7622             Tom Tromey  <tromey@adacore.com>
7623
7624         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7625         directly.
7626         * cli/cli-interp.h (make_logging_output): Remove declaration.
7627         * cli/cli-logging.c (make_logging_output): Remove function.
7628         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7629         directly.
7630         * ui-file.c (tee_file::tee_file): Remove bools.
7631         (tee_file::~tee_file): Remove deletes.
7632         * ui-file.h (tee_file): Remove bools.
7633
7634 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7635
7636         * mi/mi-cmds.h (mi_cmd_complete): New function.
7637         * mi/mi-main.c (mi_cmd_complete): Likewise.
7638         * mi/mi-cmds.c: Define new MI command -complete.
7639         * NEWS: Mention new -complete command.
7640
7641 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7642
7643         * completer.h (complete): New function.
7644         * completer.c (complete): Likewise.
7645         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7646         function defined in completer.h.
7647
7648 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7649
7650         * MAINTAINERS (Write After Approval): Add myself.
7651
7652 2019-05-17  Tom de Vries  <tdevries@suse.de>
7653
7654         PR gdb/24094
7655         * dwarf2read.c (struct cu_partial_die_info): New struct.
7656         (find_partial_die): Return cu_partial_die_info.
7657         (partial_die_parent_scope, guess_partial_die_structure_name)
7658         (partial_die_info::fixup): Handle new return type of find_partial_die.
7659
7660 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7661
7662         PR breakpoints/24541
7663         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7664         "std::string", simplifying the algorithm.
7665
7666 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7667
7668         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7669         (stap_static_probe_ops::get_probes): Likewise.
7670
7671 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7672
7673         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7674         '-')" and "else if".
7675         (stap_parse_single_operand): Join checks for
7676         "gdbarch_stap_parse_special_token_p" and
7677         "gdbarch_stap_parse_special_token" in the same "if" statement.
7678         Invert check when verifying for operation on register
7679         displacement.
7680
7681 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7682
7683         * stap-probe.c (stap_get_opcode): Update comment.
7684         (stap_get_expected_argument_type): Likewise.
7685         (handle_stap_probe): Likewise.
7686
7687 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7688
7689         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7690         return type to 'bool'.  Adjust comment.  Use 'bool' when
7691         appropriate.
7692         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7693         * stap-probe.c (stap_parse_argument_1): Likewise.
7694         (stap_is_operator): Likewise.
7695         (stap_is_generic_prefix): Likewise.
7696         (stap_is_register_prefix): Likewise.
7697         (stap_is_register_indirection_prefix): Likewise.
7698         (stap_is_integer_prefix): Likewise.
7699         (stap_generic_check_suffix): Likewise.
7700         (stap_check_integer_suffix): Likewise.
7701         (stap_check_register_suffix): Likewise.
7702         (stap_check_register_indirection_suffix): Likewise.
7703         (stap_parse_register_operand): Likewise.
7704         (stap_parse_single_operand): Likewise.
7705         (stap_parse_argument_1): Likewise.
7706         (stap_probe::get_argument_count): Likewise.
7707         (stap_is_operator): Likewise.
7708
7709 2019-05-16  Tom Tromey  <tromey@adacore.com>
7710
7711         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7712         keyword to foreach.
7713
7714 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7715
7716         * linux-thread-db.c (try_thread_db_load_1): Change return type
7717         to bool.
7718         (try_thread_db_load): Likewise.
7719         (try_thread_db_load_from_pdir_1): Likewise.
7720         (try_thread_db_load_from_pdir): Likewise.
7721         (try_thread_db_load_from_sdir): Likewise.
7722         (try_thread_db_load_from_dir): Likewise.
7723         (thread_db_load_search): Likewise.
7724         (has_libpthread): Likewise.
7725         (thread_db_load): Likewise.
7726
7727 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7728
7729         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7730         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7731         NULL, and complain/return if that's the case.
7732
7733 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7734
7735         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7736         (advance, posn, abstract_read_memory): New functions.
7737         [struct mem_read_abstraction]: New struct.
7738         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7739
7740 2019-05-14  Tom Tromey  <tromey@adacore.com>
7741
7742         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7743         value is not lval_memory.
7744
7745 2019-05-14  Tom Tromey  <tromey@adacore.com>
7746
7747         * solib.c (info_sharedlibrary_command): Style the file name.
7748
7749 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7750
7751         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7752         (aarch64_vnv_type): Likewise.
7753         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7754         * common/tdesc.c: Likewise.
7755         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7756         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7757         * features/aarch64-fpu.xml: Add ieee half view.
7758         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7759         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7760         * gdbtypes.h (struct builtin_type): Likewise.
7761         (struct objfile_type): Likewise.
7762
7763 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7764
7765         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7766         typo.
7767         * location.h (string_to_event_location): Likewise.
7768
7769 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7770
7771         GDB 8.3 released.
7772
7773 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7774
7775         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7776         New variable declaration.
7777         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7778         New variable.
7779         (print_one_breakpoint): Use ui_out::test_flags and new global
7780         variable to compute use_fixed_output.
7781         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7782         Remove.
7783         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7784         (mi_multi_location_breakpoint_output_fixed): Remove.
7785         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7786         new variable.
7787         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7788         fix_multi_location_breakpoint_output flag if version >= 3.
7789         * ui-out.h (enum ui_out_flag)
7790         <fix_multi_location_breakpoint_output>: New enumerator.
7791
7792 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7793
7794         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7795
7796 2019-05-10  Tom Tromey  <tromey@adacore.com>
7797
7798         * ada-lang.c (catch_ada_completer): New function.
7799         (_initialize_ada_language): Use it.
7800
7801 2019-05-10  Tom Tromey  <tromey@adacore.com>
7802
7803         * thread.c (print_thread_info): Make "requested_threads" const.
7804         * gdbthread.h (print_thread_info): Make "requested_threads"
7805         const.
7806         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7807         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7808
7809 2019-05-08  Tom Tromey  <tom@tromey.com>
7810
7811         * gdbtypes.c (objfile_type_data): Change type.
7812         (objfile_type, _initialize_gdbtypes): Update.
7813
7814 2019-05-08  Tom Tromey  <tom@tromey.com>
7815
7816         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7817         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7818         (_initialize_dwarf2_frame): Update.
7819
7820 2019-05-08  Tom Tromey  <tom@tromey.com>
7821
7822         * objc-lang.c (objc_objfile_data): Change type.
7823         (find_methods): Update.
7824         (_initialize_objc_lang): Remove.
7825
7826 2019-05-08  Tom Tromey  <tom@tromey.com>
7827
7828         * stabsread.c (rs6000_builtin_type_data): Change type.
7829         (rs6000_builtin_type, _initialize_stabsread): Update.
7830
7831 2019-05-08  Tom Tromey  <tom@tromey.com>
7832
7833         * mips-tdep.c (mips_pdr_data): Remove.
7834         (_initialize_mips_tdep): Update.
7835
7836 2019-05-08  Tom Tromey  <tom@tromey.com>
7837
7838         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7839         (hppa_init_objfile_priv_data, read_unwind_info)
7840         (find_unwind_entry, _initialize_hppa_tdep): Update.
7841
7842 2019-05-08  Tom Tromey  <tom@tromey.com>
7843
7844         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7845         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7846         on obstack.
7847         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7848
7849 2019-05-08  Tom Tromey  <tom@tromey.com>
7850
7851         * mdebugread.c (basic_type_data): Change type.
7852         (basic_type, _initialize_mdebugread): Update.
7853
7854 2019-05-08  Tom Tromey  <tom@tromey.com>
7855
7856         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7857
7858 2019-05-08  Tom Tromey  <tom@tromey.com>
7859
7860         * nto-tdep.c (nto_inferior_data_reg): Change type.
7861         (nto_inferior_data): Update.
7862         (nto_inferior_data_cleanup, nto_new_inferior_data)
7863         (_initialize_nto_tdep): Remove.
7864         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7865
7866 2019-05-08  Tom Tromey  <tom@tromey.com>
7867
7868         * ada-lang.c (struct ada_inferior_data): Add initializers.
7869         (ada_inferior_data): Change type.
7870         (ada_inferior_data_cleanup): Remove.
7871         (get_ada_inferior_data, ada_inferior_exit)
7872         (struct ada_pspace_data): Add initializers, destructor.
7873         (ada_pspace_data_handle): Change type.
7874         (get_ada_pspace_data): Update.
7875         (ada_pspace_data_cleanup): Remove.
7876
7877 2019-05-08  Tom Tromey  <tom@tromey.com>
7878
7879         * coffread.c (struct coff_symfile_info): Add initializers.
7880         (coff_objfile_data_key): Move lower.  Change type.
7881         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7882         Update.
7883         (coff_free_info): Remove.
7884
7885 2019-05-08  Tom Tromey  <tom@tromey.com>
7886
7887         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7888         (fbsd_pspace_data_handle): Move lower.  Change type.
7889         (get_fbsd_pspace_data): Update.
7890         (fbsd_pspace_data_cleanup): Remove.
7891         (_initialize_fbsd_tdep): Update.
7892
7893 2019-05-08  Tom Tromey  <tom@tromey.com>
7894
7895         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7896         (get_ada_tasks_pspace_data): Update.
7897         (ada_tasks_pspace_data_cleanup): Remove.
7898         (_initialize_tasks): Update.
7899         (ada_tasks_inferior_data_handle): Change type.
7900         (get_ada_tasks_inferior_data): Update.
7901         (ada_tasks_inferior_data_cleanup): Remove.
7902         (struct ada_tasks_pspace_data): Add initializers.
7903
7904 2019-05-08  Tom Tromey  <tom@tromey.com>
7905
7906         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7907         * symfile-debug.c (debug_sym_get_probes): Change type.
7908         * stap-probe.c (handle_stap_probe):
7909         (stap_static_probe_ops::get_probes): Change type.
7910         * probe.h (class static_probe_ops) <get_probes>: Change type.
7911         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7912         (parse_probes_in_pspace): Update.
7913         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7914         Update.
7915         (any_static_probe_ops::get_probes): Change type.
7916         * elfread.c (elfread_data): New typedef.
7917         (probe_key): Change type.
7918         (elf_get_probes): Likewise.  Update.
7919         (probe_key_free): Remove.
7920         (_initialize_elfread): Update.
7921         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7922         Change type.
7923         (dtrace_process_dof_probe, dtrace_process_dof)
7924         (dtrace_static_probe_ops::get_probe): Change type.
7925
7926 2019-05-08  Tom Tromey  <tom@tromey.com>
7927
7928         * xcoffread.c (struct xcoff_symfile_info): Rename from
7929         coff_symfile_info.  Add initializers.
7930         (xcoff_objfile_data_key): Move lower.  Change type.
7931         (XCOFF_DATA): Rewrite.
7932         (xcoff_free_info): Remove.
7933         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7934         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7935         (xcoff_initial_scan): Update.
7936
7937 2019-05-08  Tom Tromey  <tom@tromey.com>
7938
7939         * solib-svr4.c (struct svr4_info): Add initializers and
7940         destructor.
7941         <probes_table>: Now an htab_up.
7942         (solib_svr4_pspace_data): Change type.
7943         (free_probes_table): Simplify.
7944         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7945         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7946         (probes_table_remove_objfile_probes, register_solib_event_probe)
7947         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7948         (_initialize_svr4_solib): Update.
7949
7950 2019-05-08  Tom Tromey  <tom@tromey.com>
7951
7952         * remote.c (remote_pspace_data): Change type.
7953         (remote_pspace_data_cleanup): Remove.
7954         (get_remote_exec_file, set_pspace_remote_exec_file)
7955         (_initialize_remote): Update.
7956
7957 2019-05-08  Tom Tromey  <tom@tromey.com>
7958
7959         * breakpoint.c (breakpoint_objfile_key): Change type.
7960         (get_breakpoint_objfile_data): Update.
7961         (free_breakpoint_objfile_data): Remove.
7962         (_initialize_breakpoint): Update.
7963
7964 2019-05-08  Tom Tromey  <tom@tromey.com>
7965
7966         * linux-tdep.c (struct linux_info): Add initializers.
7967         (linux_inferior_data): Move.  Change type.
7968         (invalidate_linux_cache_inf): Update.
7969         (linux_inferior_data_cleanup): Remove.
7970         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7971
7972 2019-05-08  Tom Tromey  <tom@tromey.com>
7973
7974         * auxv.c (auxv_inferior_data): Move.  Change type.
7975         (auxv_inferior_data_cleanup): Remove.
7976         (invalidate_auxv_cache_inf): Rewrite.
7977         (get_auxv_inferior_data, _initialize_auxv): Update.
7978
7979 2019-05-08  Tom Tromey  <tom@tromey.com>
7980
7981         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7982         (symfile_debug_objfile_data_key): Change type.
7983         (symfile_debug_installed, debug_qf_has_symbols)
7984         (debug_qf_find_last_source_symtab)
7985         (debug_qf_forget_cached_source_info)
7986         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7987         (debug_qf_print_stats, debug_qf_dump)
7988         (debug_qf_expand_symtabs_for_function)
7989         (debug_qf_expand_all_symtabs)
7990         (debug_qf_expand_symtabs_with_fullname)
7991         (debug_qf_map_matching_symbols)
7992         (debug_qf_expand_symtabs_matching)
7993         (debug_qf_find_pc_sect_compunit_symtab)
7994         (debug_qf_map_symbol_filenames)
7995         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7996         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7997         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7998         (debug_sym_read_linetable, debug_sym_relocate): Update.
7999         (symfile_debug_free_objfile): Remove.
8000         (install_symfile_debug_logging, _initialize_symfile_debug):
8001         Update.
8002
8003 2019-05-08  Tom Tromey  <tom@tromey.com>
8004
8005         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8006         allocate_on_obstack.
8007         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8008         (get_dwarf2_per_objfile): Update.
8009         (set_dwarf2_per_objfile): Remove.
8010         (dwarf2_has_info, dwarf2_get_section_info): Update.
8011         (dwarf2_free_objfile): Remove.
8012         (_initialize_dwarf2_read): Update.
8013
8014 2019-05-08  Tom Tromey  <tom@tromey.com>
8015
8016         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8017         initializers.
8018         <unsupported_script_warning_printed,
8019         script_not_found_warning_printed>: Now bool.
8020         (auto_load_pspace_data): Change type.
8021         (~auto_load_pspace_info): Rename from
8022         auto_load_pspace_data_cleanup.
8023         (get_auto_load_pspace_data, init_loaded_scripts_info)
8024         (clear_section_scripts, maybe_print_unsupported_script_warning)
8025         (maybe_print_script_not_found_warning, _initialize_auto_load):
8026         Update.
8027
8028 2019-05-08  Tom Tromey  <tom@tromey.com>
8029
8030         * objfiles.c (objfile_pspace_info): Add destructor and
8031         initializers.
8032         (objfiles_pspace_data): Change type.
8033         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8034         (get_objfile_pspace_data): Update.
8035         (objfiles_bfd_data): Change type.
8036         (get_objfile_bfd_data): Update.
8037         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8038
8039 2019-05-08  Tom Tromey  <tom@tromey.com>
8040
8041         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8042         Change type.
8043         (get_catch_syscall_inferior_data): Update.
8044         (catch_syscall_inferior_data_cleanup): Remove.
8045         (_initialize_break_catch_syscall): Update.
8046
8047 2019-05-08  Tom Tromey  <tom@tromey.com>
8048
8049         * inflow.c (struct terminal_info): Add destructor and
8050         initializers.
8051         (inflow_inferior_data): Change type.
8052         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8053         (get_inflow_inferior_data, inflow_inferior_exit)
8054         (swap_terminal_info, _initialize_inflow): Update.
8055
8056 2019-05-08  Tom Tromey  <tom@tromey.com>
8057
8058         * target-dcache.c (target_dcache_cleanup): Remove.
8059         (target_dcache_aspace_key): Change type.
8060         (target_dcache_init_p, target_dcache_invalidate)
8061         (target_dcache_get, target_dcache_get_or_init)
8062         (_initialize_target_dcache): Update.
8063         * dcache.h (struct dcache_deleter): New.
8064
8065 2019-05-08  Tom Tromey  <tom@tromey.com>
8066
8067         * symtab.c (struct symbol_cache): Add destructor and
8068         initializers.
8069         (symbol_cache_key): Move.  Change type.
8070         (make_symbol_cache, free_symbol_cache): Remove.
8071         (get_symbol_cache): Update.
8072         (symbol_cache_cleanup): Remove.
8073         (ALL_PSPACES, symbol_cache_flush)
8074         (maintenance_print_symbol_cache)
8075         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8076         Update.
8077
8078 2019-05-08  Tom Tromey  <tom@tromey.com>
8079
8080         * symtab.c (struct main_info): Add destructor and initializers.
8081         (main_progspace_key): Move.  Change type.
8082         (get_main_info): Update.
8083         (main_info_cleanup): Remove.
8084         (_initialize_symtab): Update.
8085
8086 2019-05-08  Tom Tromey  <tom@tromey.com>
8087
8088         * registry.h (DECLARE_REGISTRY): Define the _key class.
8089
8090 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8091
8092         * NEWS: Merge two 'New commands' sections.
8093
8094 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8095
8096         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8097         parameter and use Ada language definition instead.
8098         (ada_val_print_ptr): Remove unused language parameter.
8099         (ada_val_print_num): Remove language parameter and use Ada language
8100         definition instead.
8101         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8102         parameter.
8103         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8104         parameter and use Ada language definition instead.
8105         (ada_val_print_1): Update all ada_val_print_xxx calls.
8106         Remove language parameter.
8107         (ada_val_print): Update ada_val_print_1 call.
8108
8109 2019-05-08  Tom Tromey  <tromey@adacore.com>
8110
8111         * remote.c (remote_hw_watchpoint_limit)
8112         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8113         Now static.
8114
8115 2019-05-08  Tom Tromey  <tromey@adacore.com>
8116
8117         * maint.c (_initialize_maint_cmds): Move initialization code to
8118         remote.c.
8119         (watchdog, show_watchdog): Move to remote.c.
8120         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8121         "watchdog" static.
8122         (_initialize_remote): Move initialization code from maint.c.
8123         * defs.h (watchdog): Don't declare.
8124
8125 2019-05-08  Tom Tromey  <tromey@adacore.com>
8126
8127         * tui/tui-interp.c: Include main.h.
8128         * interps.c: Include main.h.
8129         * main.h (interpreter_p): Declare.
8130         * defs.h (interpreter_p): Don't declare.
8131
8132 2019-05-08  Tom Tromey  <tromey@adacore.com>
8133
8134         * dwarf2loc.c: Include dwarf2read.h.
8135         * defs.h (read_unsigned_leb128): Don't declare.
8136         * dwarf2read.h (read_unsigned_leb128): Declare.
8137
8138 2019-05-08  Tom Tromey  <tromey@adacore.com>
8139
8140         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8141         method.
8142
8143 2019-05-08  Tom Tromey  <tromey@adacore.com>
8144
8145         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8146         when no wrap column is set.
8147
8148 2019-05-08  Tom Tromey  <tromey@adacore.com>
8149
8150         * c-lang.c (c_get_string): Handle non-C-style arrays.
8151
8152 2019-05-08  Tom Tromey  <tromey@adacore.com>
8153
8154         * typeprint.c (print_offset_data::update): Print the bit offset,
8155         not the number of bits remaining.
8156
8157 2019-05-08  Tom Tromey  <tromey@adacore.com>
8158
8159         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8160         padding at end of comment.
8161
8162 2019-05-08  Tom Tromey  <tromey@adacore.com>
8163
8164         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8165         Compare main types.
8166
8167 2019-05-06  Tom Tromey  <tom@tromey.com>
8168
8169         * common/scoped_mmap.c: Include common-defs.h.
8170         * common/scoped_mmap.h: Don't include config.h.
8171
8172 2019-05-04  Tom Tromey  <tom@tromey.com>
8173
8174         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8175         (struct aarch64_call_info): Add initializers.
8176         <si>: Now a std::vector.
8177         (pass_on_stack, aarch64_push_dummy_call): Update.
8178
8179 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8180             Tom Tromey  <tom@tromey.com>
8181
8182         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8183         (ppc_threads): Now a std::vector.  Now static.
8184         (hwdebug_find_thread_points_by_tid)
8185         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8186         Update.
8187
8188 2019-05-04  Tom Tromey  <tom@tromey.com>
8189
8190         * arc-tdep.c (arc_tdesc_init): Return bool.
8191
8192 2019-05-04  Tom Tromey  <tom@tromey.com>
8193
8194         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8195         Use gdb_assert_not_reached.
8196
8197 2019-05-04  Tom Tromey  <tom@tromey.com>
8198
8199         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8200         "false".
8201
8202 2019-05-04  Tom Tromey  <tom@tromey.com>
8203
8204         * arc-tdep.c (arc_tdesc_init): Use bool.
8205
8206 2019-05-04  Tom Tromey  <tom@tromey.com>
8207
8208         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8209
8210 2019-05-04  Tom Tromey  <tom@tromey.com>
8211
8212         * cli/cli-cmds.c (valid_command_p): Return bool.
8213
8214 2019-05-04  Tom Tromey  <tom@tromey.com>
8215
8216         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8217         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8218
8219 2019-05-04  Raul Tambre  <raul@tambre.ee>
8220
8221         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8222         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8223         operator for comparison.
8224
8225 2019-05-04  Tom Tromey  <tom@tromey.com>
8226
8227         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8228         (lookup_partial_symbol, print_partial_symbols)
8229         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8230         (psymbol_compare): Update.
8231         (add_psymbol_to_bcache): Clear the entire psymbol.
8232         (maintenance_check_psymtabs): Update.
8233         * psympriv.h (struct partial_symbol): Don't derive from
8234         general_symbol_info.
8235         <obj_section, unrelocated_address, address,
8236         set_unrelocated_address>: Update.
8237         <ginfo>: New member.
8238         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8239         (debug_names::write_psymbols): Update.
8240
8241 2019-05-04  Tom de Vries  <tdevries@suse.de>
8242
8243         * contrib/cc-with-tweaks.sh: Support -n arg.
8244
8245 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8246
8247         * corelow.c (core_target::detach): Ensure frame cache and
8248         register caches are cleared.
8249         inferior.c (exit_inferior_1): Likewise.
8250
8251 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8252             Tom Tromey  <tom@tromey.com>
8253
8254         * dictionary.c (collate_pending_symbols_by_language): Remove
8255         "struct" from foreach.
8256         * symtab.c (lookup_global_symbol_from_objfile)
8257         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8258         foreach.
8259         * ser-tcp.c (net_open): Remove "struct" from foreach.
8260         * objfiles.c (objfile_relocate, objfile_rebase)
8261         (objfile_has_symbols): Remove "struct" from foreach.
8262         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8263         from foreach.
8264         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8265         foreach.
8266         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8267         "struct" from foreach.
8268         * ada-lang.c (create_excep_cond_exprs)
8269         (ada_exception_catchpoint_cond_string): Remove "struct" from
8270         foreach.
8271
8272 2019-05-03  Tom Tromey  <tromey@adacore.com>
8273
8274         * ada-exp.y (convert_char_literal): Check suffix of each
8275         enumerator.
8276
8277 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8278
8279         PR ada/21406:
8280         * ada-exp.y (yywrap): Don't define.
8281         * ada-lex.l (%option): Add noyywrap
8282         (yywrap): Remove.
8283
8284 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8285
8286         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8287         _WIN32_WINNT to the XP level, unless already defined to a higher
8288         level.
8289
8290         * unittests/parse-connection-spec-selftests.c:
8291         * ser-tcp.c:
8292         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8293         override.
8294
8295         * symfile.c (find_separate_debug_file): Remove colon from the
8296         drive spec of DOS/Windows file names of the target, so that the
8297         file name produced from DEBUGDIR and the target's directory will
8298         be valid on DOS/Windows systems.
8299
8300 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8301
8302         * rust-lang.c (val_print_struct): Handle printing structures
8303         containing strings.
8304
8305 2019-05-02  Tom Tromey  <tromey@adacore.com>
8306
8307         * valarith.c (_initialize_valarith): Remove.
8308
8309 2019-05-01  Tom Tromey  <tromey@adacore.com>
8310
8311         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8312         bitfields.
8313
8314 2019-05-01  Tom Tromey  <tromey@adacore.com>
8315
8316         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8317         for big-endian copies.
8318
8319 2019-04-30  Ali Tamur  <tamur@google.com>
8320         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8321         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8322         (read_3_bytes): New function.
8323
8324 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8325
8326         * windows-nat.c (main_thread_id): Delete.
8327         (handle_output_debug_string): Replace main_thread_id by
8328         current_event.dwThreadId.
8329         (fake_create_process): Likewise.
8330         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8331         Do not set main_thread_id.
8332         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8333         current_event.dwThreadId.
8334         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8335
8336 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8337
8338         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8339         Use current_event.dwThreadId instead of main_thread_id.
8340
8341 2019-04-30  Tom Tromey  <tromey@adacore.com>
8342
8343         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8344         (create_excep_cond_exprs): Iterate over program spaces.
8345         (ada_exception_catchpoint_cond_string): Examine all minimal
8346         symbols for exception types.
8347
8348 2019-04-30  Tom Tromey  <tromey@adacore.com>
8349
8350         PR c++/24470:
8351         * dwarf2read.c (process_structure_scope): Handle case where type
8352         has template parameters but no symbol was created.
8353
8354 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8355             Chris January  <chris.january@arm.com>
8356
8357         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8358         qualifier.
8359         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8360
8361 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8362
8363         * f-typeprint.c (f_print_type): Update rules for printing
8364         whitespace.
8365         (f_type_print_varspec_suffix): Likewise.
8366
8367 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8368             Chris January  <chris.january@arm.com>
8369
8370         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8371         function arguments.
8372
8373 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8374
8375         * f-lang.c (build_fortran_types): Change name of void type to
8376         lower case.
8377         * f-typeprint.c (f_type_print_base): Print the name of the void
8378         type, rather than a fixed string.
8379         * f-valprint.c (f_decorations): Use lower case void string.
8380
8381 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8382             Chris January  <chris.january@arm.com>
8383
8384         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8385         types for Fortran.
8386
8387 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8388             Chris January  <chris.january@arm.com>
8389             David Lecomber  <david.lecomber@arm.com>
8390
8391         * f-exp.y (BINOP_INTRINSIC): New token.
8392         (exp): New parser rule handling BINOP_INTRINSIC.
8393         (f77_keywords): Add new builtin procedures.
8394         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8395         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8396         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8397         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8398         (print_unop_subexp_f): New function.
8399         (print_binop_subexp_f): New function.
8400         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8401         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8402         (dump_subexp_body_f): Likewise.
8403         (operator_check_f): Likewise.
8404         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8405         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8406
8407 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8408
8409         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8410         UNOP_KIND.
8411         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8412         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8413         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8414         (operator_length_f): New fuction.
8415         (print_subexp_f): New function.
8416         (op_name_f): New function.
8417         (dump_subexp_body_f): New function.
8418         (operator_check_f): New function.
8419         (exp_descriptor_f): Replace standard expression handling functions
8420         with new functions.
8421         * gdb/fortran-operator.def: New file.
8422         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8423         * gdb/std-operator.def: Remove UNOP_KIND.
8424
8425 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8426
8427         * std-operator.def: Remove unbalanced, stray double quote
8428         character.
8429
8430 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8431             Chris January  <chris.january@arm.com>
8432             Daniel Everett  <daniel.everett@arm.com>
8433             Nick Forrington  <nick.forrington@arm.com>
8434             Richard Bunt  <richard.bunt@arm.com>
8435
8436         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8437         of depth when printing anonymous structs or unions.
8438         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8439         Don't print either the top-level value, or the children if the
8440         max-depth is exceeded.
8441         (ppscm_print_children): When printing the key of a map, allow one
8442         extra level of depth.
8443         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8444         print either the top-level value, or the children if the max-depth
8445         is exceeded.
8446         (print_children): When printing the key of a map, allow one extra
8447         level of depth.
8448         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8449         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8450         (user_print_options): Initialise max_depth field.
8451         (val_print_scalar_or_string_type_p): New function.
8452         (val_print): Check to see if the max depth has been reached.
8453         (val_print_check_max_depth): Define new function.
8454         (show_print_max_depth): New function.
8455         (_initialize_valprint): Add 'print max-depth' option.
8456         * valprint.h (struct value_print_options) <max_depth>: New field.
8457         (val_print_check_max_depth): Declare new function.
8458         * NEWS: Document new feature.
8459
8460 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8461
8462         * ada-lang.c (ada_language_defn): Initialise new field.
8463         * c-lang.c (c_is_string_type_p): New function.
8464         (c_language_defn): Initialise new field.
8465         (cplus_language_defn): Initialise new field.
8466         (asm_language_defn): Initialise new field.
8467         (minimal_language_defn): Initialise new field.
8468         * c-lang.h (c_is_string_type_p): Declare new function.
8469         * d-lang.c (d_language_defn): Initialise new field.
8470         * f-lang.c (f_is_string_type_p): New function.
8471         (f_language_defn): Initialise new field.
8472         * go-lang.c (go_is_string_type_p): New function.
8473         (go_language_defn): Initialise new field.
8474         * language.c (default_is_string_type_p): New function.
8475         (unknown_language_defn): Initialise new field.
8476         (auto_language_defn): Initialise new field.
8477         * language.h (struct language_defn) <la_is_string_type_p>: New
8478         member variable.
8479         (default_is_string_type_p): Declare new function.
8480         * m2-lang.c (m2_language_defn): Initialise new field.
8481         * objc-lang.c (objc_language_defn): Initialise new field.
8482         * opencl-lang.c (opencl_language_defn): Initialise new field.
8483         * p-lang.c (pascal_is_string_type_p): New function.
8484         (pascal_language_defn): Initialise new field.
8485         * rust-lang.c (rust_is_string_type_p): New function.
8486         (rust_language_defn): Initialise new field.
8487
8488 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8489
8490         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8491         New field.
8492         * ada-lang.c (ada_language_defn): Initialise new field.
8493         * c-lang.c (c_language_defn): Likewise.
8494         (cplus_language_defn): Likewise.
8495         (asm_language_defn): Likewise.
8496         (minimal_language_defn): Likewise.
8497         * d-lang.c (d_language_defn): Likewise.
8498         * f-lang.c (f_language_defn): Likewise.
8499         * go-lang.c (go_language_defn): Likewise.
8500         * language.c (unknown_language_defn): Likewise.
8501         (auto_language_defn): Likewise.
8502         * m2-lang.c (m2_language_defn): Likewise.
8503         * objc-lang.c (objc_language_defn): Likewise.
8504         * opencl-lang.c (opencl_language_defn): Likewise.
8505         * p-lang.c (pascal_language_defn): Likewise.
8506         * rust-lang.c (rust_language_defn): Likewise.
8507
8508 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8509
8510         * ada-lang.c (ada_is_character_type): Change return type to bool.
8511         (ada_is_string_type): Likewise.
8512         * ada-lang.h (ada_is_character_type): Update declaration
8513         (ada_is_string_type): Likewise.
8514
8515 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8516
8517         Support style in 'frame|thread apply'
8518
8519         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8520         * record.c (record_start, record_stop): Update callers of
8521         execute_command_to_string with false.
8522         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8523         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8524         methods.
8525         (class string_file): New constructor with term_out parameter.
8526         Override methods term_out and can_emit_style_escape.  New member
8527         term_out.
8528         (class stdio_file): Override can_emit_style_escape.
8529         (class tee_file): Override term_out and can_emit_style_escape.
8530         * utils.h (can_emit_style_escape): Remove.
8531         * utils.c (can_emit_style_escape): Likewise.
8532         Update all callers of can_emit_style_escape (SOMESTREAM) to
8533         SOMESTREAM->can_emit_style_escape.
8534         * source-cache.c (source_cache::get_source_lines): Likewise.
8535         * stack.c (frame_apply_command_count): Call execute_command_to_string
8536         passing the term_out characteristic of the current gdb_stdout.
8537         * thread.c (thr_try_catch_cmd): Likewise.
8538         * top.c (execute_command_to_string): pass term_out parameter
8539         to construct the string_file for the command output.
8540         * ui-file.c (term_cli_styling): New function (most code moved
8541         from utils.c can_emit_style_escape).
8542         (string_file::string_file, string_file::can_emit_style_escape,
8543         stdio_file::can_emit_style_escape, tee_file::term_out,
8544         tee_file::can_emit_style_escape): New functions.
8545
8546 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8547
8548         * NEWS: Mention the new set|show may-call-functions.
8549         * infcall.c (may_call_functions_p): New variable.
8550         (show_may_call_functions_p): New function.
8551         (call_function_by_hand_dummy): Throws an error if not
8552         may-call-functions.
8553         (_initialize_infcall): Call add_setshow_boolean_cmd for
8554         may-call-functions.
8555
8556 2019-04-25  Keith Seitz  <keiths@redhat.com>
8557
8558         PR c++/24367
8559         * cp-support.c (inspect_type): Don't attempt substitutions
8560         of symbol with the same name.
8561
8562 2019-04-25  Tom Tromey  <tromey@adacore.com>
8563
8564         PR gdb/24475:
8565         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8566         static.
8567
8568 2019-04-25  Tom Tromey  <tromey@adacore.com>
8569
8570         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8571         rvalue reference.
8572         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8573         (gdb_xml_parser::parse): Use std::move.
8574         * python/python-internal.h (gdbpy_convert_exception): Take a const
8575         reference.
8576         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8577         std::move.
8578         * python/py-utils.c (gdbpy_convert_exception): Take a const
8579         reference.
8580         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8581         Use std::move.
8582         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8583         Use std::move.
8584         * mi/mi-main.c (mi_print_exception): Take a const reference.
8585         * main.c (handle_command_errors): Take a const reference.
8586         * linespec.c (parse_linespec): Use std::move.
8587         * infcall.c (run_inferior_call): Use std::move.
8588         (call_function_by_hand_dummy): Use std::move.
8589         * exec.c (try_open_exec_file): Use std::move.
8590         * exceptions.h (exception_print, exception_fprintf)
8591         (exception_print_same): Update.
8592         * exceptions.c (print_exception, exception_print)
8593         (exception_fprintf, exception_print_same): Change parameters to
8594         const reference.
8595         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8596         * common/new-op.c: Use std::move.
8597         * common/common-exceptions.h (struct gdb_exception): Add move
8598         constructor.
8599         (struct gdb_exception_error, struct gdb_exception_quit, struct
8600         gdb_quit_bad_alloc): Change constructor to move constructor.
8601         (throw_exception): Change parameter to rvalue reference.
8602         * common/common-exceptions.c (throw_exception): Take rvalue
8603         reference.
8604         * cli/cli-interp.c (safe_execute_command): Use std::move.
8605         * breakpoint.c (insert_bp_location, location_to_sals): Use
8606         std::move.
8607
8608 2019-04-25  Tom Tromey  <tromey@adacore.com>
8609
8610         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8611         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8612         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8613         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8614         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8615         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8616         guile/scm-value.c: Use unpack.
8617         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8618         gdbscm_gdb_exception.
8619         (gdbscm_throw_gdb_exception): Likewise.
8620         (struct gdbscm_gdb_exception): New.
8621         (unpack): New function.
8622         (gdbscm_wrap): Use unpack.
8623
8624 2019-04-25  Tom Tromey  <tromey@adacore.com>
8625
8626         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8627         (gdb_rl_callback_handler): Use std::move.
8628         * common/common-exceptions.h (struct gdb_exception): Add move
8629         assignment operator.
8630         (throw_exception_sjlj): Change "exception" to const reference.
8631         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8632         (throw_exception_sjlj): Change "exception" to const reference.
8633
8634 2019-04-25  Tom Tromey  <tromey@adacore.com>
8635
8636         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8637         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8638         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8639         Update.
8640         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8641         Update.
8642         * mi/mi-interp.c (mi_interp::exec): Update.
8643         * linespec.c (parse_linespec): Update.
8644         * infcall.c (run_inferior_call): Update.
8645         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8646         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8647         (gdbscm_lookup_global_symbol): Update.
8648         * guile/scm-param.c (gdbscm_parameter_value): Update.
8649         * guile/scm-frame.c (gdbscm_frame_read_register)
8650         (gdbscm_frame_read_var): Update.
8651         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8652         * exec.c (try_open_exec_file): Update.
8653         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8654         (gdb_rl_callback_handler): Update.
8655         * common/common-exceptions.h (exception_none): Don't declare.
8656         * common/common-exceptions.c (exception_none): Don't define.
8657         (struct catcher) <exception>: Update.
8658         * cli/cli-interp.c (safe_execute_command): Update.
8659         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8660
8661 2019-04-25  Ali Tamur  <tamur@google.com>
8662
8663         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8664         (read_attribute_value): Likewise.
8665         (dwarf2_read_addr_index): Update comment.
8666         (read_str_index): Add DW_FORM_strx.
8667         (dwarf2_string_attr): Likewise.
8668         (dwarf2_const_value_attr): Likewise.
8669         (dump_die_shallow): Likewise.
8670         (dwarf2_fetch_constant_bytes): Likewise.
8671         (skip_form_bytes): Likewise.
8672         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8673
8674 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8675
8676         PR corefiles/11608
8677         PR corefiles/18187
8678         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8679         OFFSET.  Verify if current mapping contains an ELF header.
8680         (linux_find_memory_regions_full): Adjust call to
8681         dump_mapping_p.
8682
8683 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8684             Kang Li <kanglictf@gmail.com>
8685
8686         PR gdb/21600
8687
8688         * dwarf2-frame.c (read_initial_length): Be consistent about using
8689         unsigned representation of length.
8690         (decode_frame_entry_1): Likewise.  Check for wraparound of
8691         end pointer as well as buffer overflow.
8692
8693 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8694
8695         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8696         "vq".
8697
8698 2019-04-24  Tom Tromey  <tromey@adacore.com>
8699
8700         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8701
8702 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8703
8704         * s12z-tdep.c (s12z_unwind_pc): Delete.
8705         (s12z_unwind_sp): Delete.
8706         (s12z_gdbarch_init): Don't register deleted functions with
8707         gdbarch.
8708
8709 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8710
8711         * rl78-tdep.c (rl78_unwind_sp): Delete.
8712         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8713
8714 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8715
8716         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8717         (xstormy16_unwind_pc): Delete.
8718         (xstormy16_dummy_id): Delete.
8719         (xstormy16_gdbarch_init): Don't register deleted functions with
8720         gdbarch.
8721
8722 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8723
8724         * vax-tdep.c (vax_unwind_pc): Delete.
8725         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8726
8727 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8728
8729         * v850-tdep.c (v850_unwind_sp): Delete.
8730         (v850_unwind_pc): Delete.
8731         (v850_dummy_id): Delete.
8732         (v850_gdbarch_init): Don't register deleted functions with
8733         gdbarch.
8734
8735 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8736
8737         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8738         (tilegx_unwind_pc): Delete.
8739         (tilegx_unwind_dummy_id): Delete.
8740         (tilegx_gdbarch_init): Don't register deleted functions with
8741         gdbarch.
8742
8743 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8744
8745         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8746         (tic6x_dummy_id): Delete.
8747         (tic6x_gdbarch_init): Don't register deleted functions with
8748         gdbarch.
8749
8750 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8751
8752         * sparc-tdep.c (sparc_unwind_pc): Delete.
8753         (sparc32_gdbarch_init): Don't register deleted function with
8754         gdbarch.
8755
8756 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8757
8758         * sh-tdep.c (sh_unwind_sp): Delete.
8759         (sh_unwind_pc): Delete.
8760         (sh_dummy_id): Delete.
8761         (sh_gdbarch_init): Don't register deleted functions with
8762         gdbarch.
8763
8764 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8765
8766         * score-tdep.c (score_unwind_sp): Delete.
8767         (score_unwind_pc): Delete.
8768         (score_dummy_id): Delete.
8769         (score_gdbarch_init): Don't register deleted functions with
8770         gdbarch.
8771
8772 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8773
8774         * rx-tdep.c (rx_unwind_pc): Delete.
8775         (rx_unwind_sp): Delete.
8776         (rx_dummy_id): Delete.
8777         (rx_gdbarch_init): Don't register deleted functions with
8778         gdbarch.  Update comment.
8779
8780 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8781
8782         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8783         (rs6000_dummy_id): Delete.
8784         (rs6000_gdbarch_init): Don't register deleted functions with
8785         gdbarch.
8786
8787 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8788
8789         * or1k-tdep.c (or1k_dummy_id): Delete.
8790         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8791
8792 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8793
8794         * nios2-tdep.c (nios2_dummy_id): Delete.
8795         (nios2_unwind_sp): Delete.
8796         (nios2_gdbarch_init): Don't register deleted functions with
8797         gdbarch.
8798
8799 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8800
8801         * nds32-tdep.c (nds32_dummy_id): Delete.
8802         (nds32_unwind_pc): Delete.
8803         (nds32_unwind_sp): Delete.
8804         (nds32_gdbarch_init): Don't register deleted functions with
8805         gdbarch.
8806
8807 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8808
8809         * msp430-tdep.c (msp430_unwind_pc): Delete.
8810         (msp430_unwind_sp): Delete.
8811         (msp430_dummy_id): Delete.
8812         (msp430_gdbarch_init): Don't register deleted functions with
8813         gdbarch.
8814
8815 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8816
8817         * moxie-tdep.c (moxie_unwind_sp): Delete.
8818         (moxie_unwind_pc): Delete.
8819         (moxie_dummy_id): Delete.
8820         (moxie_gdbarch_init): Don't register deleted functions with
8821         gdbarch.
8822
8823 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8824
8825         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8826         (mn10300_unwind_pc): Delete.
8827         (mn10300_unwind_sp): Delete.
8828         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8829         mn10300_unwind_sp.
8830         (mn10300_frame_unwind_init): Don't register deleted functions with
8831         gdbarch.
8832
8833 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8834
8835         * mep-tdep.c (mep_unwind_pc): Delete.
8836         (mep_unwind_sp): Delete.
8837         (mep_dummy_id): Delete.
8838         (mep_gdbarch_init): Don't register deleted functions with
8839         gdbarch.
8840
8841 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8842
8843         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8844         (m68hc11_unwind_sp): Delete.
8845         (m68hc11_gdbarch_init): Don't register deleted functions with
8846         gdbarch.
8847
8848 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8849
8850         * m32r-tdep.c (m32r_unwind_sp): Delete.
8851         (m32r_unwind_pc): Delete.
8852         (m32r_dummy_id): Delete.
8853         (m32r_gdbarch_init): Don't register deleted functions with
8854         gdbarch.
8855
8856 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8857
8858         * m32c-tdep.c (m32c_unwind_pc): Delete.
8859         (m32c_unwind_sp): Delete.
8860         (m32c_dummy_id): Delete.
8861         (m32c_gdbarch_init): Don't register deleted functions with
8862         gdbarch.
8863
8864 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8865
8866         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8867         (lm32_unwind_pc): Delete.
8868         (lm32_dummy_id): Delete.
8869         (lm32_gdbarch_init): Don't register deleted functions with
8870         gdbarch.
8871
8872 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8873
8874         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8875         (iq2000_unwind_pc): Delete.
8876         (iq2000_dummy_id): Delete.
8877         (iq2000_gdbarch_init): Don't register deleted functions with
8878         gdbarch.
8879
8880 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8881
8882         * nds32-tdep.c (nds32_type_align): Delete.
8883         (nds32_push_dummy_call): Use type_align instead.
8884
8885 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8886
8887         * arm-tdep.c (arm_type_align): Only handle vector override case.
8888         (arm_push_dummy_call): Use type_align.
8889         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8890
8891 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8892
8893         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8894         case.
8895         (pass_on_stack): Use type_align.
8896         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8897         function.
8898
8899 2019-04-23  Tom Tromey  <tromey@adacore.com>
8900
8901         * dwarf2read.c (line_header::file_name_at): Remove unused
8902         overload.
8903
8904 2019-04-23  Tom de Vries  <tdevries@suse.de>
8905
8906         PR gdb/24438
8907         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8908         invocation.
8909
8910
8911 2019-03-27  Ali Tamur  <tamur@google.com>
8912
8913         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8914         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8915         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8916         (dwarf_expr_context::get_addr_index): Likewise
8917         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8918         (symbol_needs_eval_context::get_addr_index): Likewise
8919         (disassemble_dwarf_expression): Add DW_OP_addrx
8920         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8921         (read_cutu_die_from_dwo): Update comment
8922         (skip_one_die): Add DW_FORM_addrx
8923         (read_attribute_value): Likewise
8924         (var_decode_location): Add DW_OP_addrx
8925         (dwarf2_const_value_attr): Add DW_FORM_addrx
8926         (dump_die_shallow): Likewise
8927         (dwarf2_fetch_constant_bytes): Likewise
8928         (decode_locdesc): Add DW_OP_addrx
8929         (skip_form_bytes): Add DW_FORM_addrx
8930
8931 2019-04-22  Ali Tamur  <tamur@google.com>
8932
8933         * MAINTAINERS (Write After Approval): Add self.
8934
8935 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8936
8937         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8938         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8939         (open_symbol_file_object): Likewise.
8940         (svr4_default_sos): Add info parameter.
8941         (svr4_read_so_list): Likewise.
8942         (svr4_current_sos_direct): Adjust functions calls to pass down
8943         info.
8944         (svr4_current_sos_1): Add info parameter.
8945         (svr4_current_sos): Call get_svr4_info, pass info down to
8946         svr4_current_sos_1.
8947         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8948         get_svr4_info.
8949         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8950         get_svr4_info.
8951         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8952         to get_svr4_info.
8953         (probes_table_remove_objfile_probes): Likewise.
8954         (register_solib_event_probe): Add info parameter.
8955         (solist_update_incremental): Pass info parameter down to
8956         svr4_read_so_list.
8957         (disable_probes_interface): Add info parameter.
8958         (svr4_handle_solib_event): Pass current_program_space to
8959         get_svr4_info.  Adjust disable_probes_interface cleanup.
8960         (svr4_create_probe_breakpoints): Add info parameter, pass it
8961         down to register_solib_event_probe.
8962         (svr4_create_solib_event_breakpoints): Add info parameter,
8963         pass it down to svr4_create_probe_breakpoints.
8964         (enable_break): Pass info down to
8965         svr4_create_solib_event_breakpoints.
8966         (svr4_solib_create_inferior_hook): Pass current_program_space to
8967         get_svr4_info.
8968         (svr4_clear_solib): Likewise.
8969
8970 2019-04-22  Pedro Alves  <palves@redhat.com>
8971
8972         * solib-svr4.c (svr4_free_objfile_observer): New.
8973         (probe_and_action::objfile): New field.
8974         (probes_table_htab_remove_objfile_probes)
8975         (probes_table_remove_objfile_probes): New functions.
8976         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8977         in the new probe_and_action.  Don't store the probe in 'lookup'.
8978         (svr4_create_probe_breakpoints): Pass objfile to
8979         register_solib_event_probe.
8980         (_initialize_svr4_solib): Register a free_objfile observer.
8981
8982 2019-04-19  Tom Tromey  <tom@tromey.com>
8983
8984         * common/queue.h: Remove.
8985
8986 2019-04-19  Tom Tromey  <tom@tromey.com>
8987
8988         * event-loop.c: Don't include "common/queue.h".
8989
8990 2019-04-19  Tom Tromey  <tom@tromey.com>
8991
8992         * remote.c (remote_target): Use delete.
8993         * remote-notif.h: Include <list>, not "common/queue.h".
8994         (notif_client_p): Remove typedef.
8995         (remote_notif_state): Add constructor, destructor, initializer.
8996         <notif_queue>: Now a std::list.
8997         (remote_notif_state_xfree): Don't declare.
8998         * remote-notif.c (remote_notif_process, handle_notification)
8999         (remote_notif_state_allocate): Update.
9000         (~remote_notif_state): Rename from remote_notif_state_xfree.
9001
9002 2019-04-19  Tom Tromey  <tom@tromey.com>
9003
9004         * symfile.c (reread_symbols): Update.
9005         * objfiles.c (objfile_register_static_link)
9006         (objfile_lookup_static_link): Update
9007         (~objfile) Don't delete static_links.
9008         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9009
9010 2019-04-19  Tom Tromey  <tom@tromey.com>
9011
9012         * type-stack.h (struct type_stack) <insert>: Constify string.
9013         * type-stack.c (type_stack::insert): Constify string.
9014         * gdbtypes.h (lookup_template_type): Update.
9015         (address_space_name_to_int): Update.
9016         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9017         const.
9018         (lookup_template_type): Make name const.
9019         * c-exp.y: Update rules.
9020         (lex_one_token, classify_name, classify_inner_name)
9021         (c_print_token): Update.
9022         * p-exp.y: Update rules.
9023         (yylex): Update.
9024         * f-exp.y: Update rules.
9025         (yylex): Update.
9026         * d-exp.y: Update rules.
9027         (lex_one_token, classify_name, classify_inner_name): Update.
9028         * parse.c (write_dollar_variable, copy_name): Return std::string.
9029         * parser-defs.h (copy_name): Change return type.
9030         * m2-exp.y: Update rules.
9031         (yylex): Update.
9032         * go-exp.y (lex_one_token): Update.
9033         Update rules.
9034         (classify_unsafe_function, classify_packaged_name)
9035         (classify_name, yylex): Update.
9036
9037 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9038
9039         * configure.ac: add --enable-source-highlight switch.
9040         * configure: Regenerate.
9041         * top.c (print_gdb_version): plumb --enable-source-highlight
9042         status to "show configuration".
9043
9044 2019-04-19  Tom Tromey  <tromey@adacore.com>
9045
9046         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9047         Check ADA_TYPE_P.
9048         (empty_record, ada_template_to_fixed_record_type_1)
9049         (template_to_static_fixed_type)
9050         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9051         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9052         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9053         macros.
9054
9055 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9056
9057         PR symtab/24423:
9058         * source.c (print_source_lines_base): Advance "iter" when a
9059         control character is seen.
9060
9061 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9062
9063         * inferior.h (struct infcall_suspend_state_deleter):
9064         Catch exception in destructor to avoid crash.
9065
9066 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9067
9068         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9069         close to the add_com "shell".
9070
9071 2019-04-18  Tom Tromey  <tromey@adacore.com>
9072
9073         * process-stratum-target.h (class process_stratum_target)
9074         <stratum>: Add "final".
9075
9076 2019-04-17  Tom Tromey  <tromey@adacore.com>
9077
9078         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9079         against nullptr before use.
9080
9081 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9082
9083         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9084
9085 2019-04-17  Jim Wilson  <jimw@sifive.com>
9086             Andrew Burgess  <andrew.burgess@embecosm.com>
9087
9088         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9089         code read might fail, assume 4-byte breakpoint in that case.
9090
9091 2019-04-15  Leszek Swirski  <leszeks@google.com>
9092
9093         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9094         rather than a hand-rolled POD check when checking for forced MEMORY
9095         classification.
9096
9097 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9098
9099         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9100         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9101         function.
9102         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9103         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9104         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9105         declaration.
9106
9107 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9108
9109         * aarch64-linux-nat.c
9110         (aarch64_linux_nat_target::thread_architecture): Add override.
9111         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9112         each VQ.
9113
9114 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9115
9116         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9117
9118 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9119
9120         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9121         target types of size 96-bits, add some additional comments, and
9122         check that the builtin type we found was the correct size.
9123
9124 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9125
9126         * utils.c (prompt_for_continue): Don't restore the styling at the
9127         end, as applied_style has the wrong value.  This fixes styling in
9128         long lists of file names that are interrupted by the "Continue?"
9129         prompt.
9130
9131 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9132
9133         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9134         * c-lang.c (c_language_defn): Likewise.
9135         (cplus_language_defn): Likewise.
9136         (asm_language_defn): Likewise.
9137         (minimal_language_defn): Likewise.
9138         * d-lang.c (d_language_defn): Likewise.
9139         * f-lang.c (f_language_defn): Likewise.
9140         * go-lang.c (go_language_defn): Likewise.
9141         * language.c (unknown_language_defn): Likewise.
9142         (auto_language_defn): Likewise.
9143         * language.h (struct language_defn): Remove la_magic field.
9144         (LANG_MAGIC): Delete.
9145         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9146         * objc-lang.c (objc_language_defn): Likewise.
9147         * opencl-lang.c (opencl_language_defn): Likewise.
9148         * p-lang.c (pascal_language_defn): Likewise.
9149         * rust-lang.c (rust_language_defn): Likewise.
9150
9151 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9152
9153         * riscv-tdep.c (riscv_type_align): New function.
9154         (riscv_type_alignment): Delete.
9155         (riscv_arg_location): Use 'type_align'.
9156         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9157
9158 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9159
9160         * gdbtypes.c (type_align): A struct with no non-static fields also
9161         has alignment of 1.
9162
9163 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9164
9165         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9166         component to 0.
9167         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9168         member.
9169         (riscv_struct_info::analyse): New implementation using new
9170         analyse_inner member function.
9171         (riscv_struct_info::field_offset): New member function.
9172         (riscv_struct_info::m_offsets): New member variable.
9173         (riscv_struct_info::analyse_inner): New private member function,
9174         takes the old implementation of riscv_struct_info::analyse but
9175         extended to track field offsets.
9176         (riscv_call_arg_struct): Update the struct folding special cases
9177         to handle cases where empty C++ structs, which are non-zero
9178         length, are found.
9179         (riscv_arg_location): Initialise the length of each location, a
9180         non-zero length now indicates the location is in use.
9181         (riscv_push_dummy_call): Allow for the first location having a
9182         non-zero offset when setting up arguments.
9183         (riscv_return_value): Likewise, but for return values.
9184
9185 2019-04-11  Tom Tromey  <tromey@adacore.com>
9186
9187         * utils.c (internal_vproblem): Make "msg" const.
9188
9189 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9190
9191         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9192         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9193         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9194         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9195
9196 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9197
9198         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9199         function.
9200         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9201         of amd64_collect_native_gregset.
9202         (amd64_linux_nat_target::store_registers): Likewise.
9203
9204 2019-04-10  Tom Tromey  <tom@tromey.com>
9205
9206         * symtab.c (lookup_global_symbol_from_objfile)
9207         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9208         * objfiles.h (class separate_debug_iterator): New.
9209         (class separate_debug_range): New.
9210         (struct objfile) <separate_debug_objfiles>: New method.
9211         (objfile_separate_debug_iterate): Don't declare.
9212         * objfiles.c (separate_debug_iterator::operator++): Rename from
9213         objfile_separate_debug_iterate.
9214         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9215         iterator.
9216         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9217         iterator.
9218
9219 2019-04-10  Tom Tromey  <tom@tromey.com>
9220
9221         * symfile.c (reread_symbols): Remove old comment.
9222         * objfiles.c (free_all_objfiles): Fix a typo.
9223
9224 2019-04-10  Tom Tromey  <tom@tromey.com>
9225
9226         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9227         * minsyms.c (lookup_minimal_symbol): Use foreach.
9228         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9229         (lookup_minimal_symbol_solib_trampoline): Likewise.
9230         * symfile.c (reread_symbols): Use foreach.
9231
9232 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9233             Tom Tromey  <tromey@adacore.com>
9234
9235         PR rust/24414:
9236         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9237         (rust_lex_int_test): Change "value" to be LONGEST.
9238         (rust_lex_tests): Add test for long integer literal.
9239
9240 2019-04-09  Tom Tromey  <tromey@adacore.com>
9241
9242         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9243         to bool.
9244         (extended_remote_target::attach): Update.
9245         (remote_target::remote_notice_new_inferior): Update.
9246         (remote_target::add_current_inferior_and_thread): Update.
9247         * inferior.c (exit_inferior_1): Use "false".
9248         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9249
9250 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9251
9252         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9253         the "start" command.
9254
9255 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9256
9257         * python/py-inferior.c (infpy_thread_from_thread_handle):
9258         Adjust comments to reflect renaming of thread_from_thread_handle
9259         to thread_from_handle.  Adjust keywords.  Fix type error message.
9260         (inferior_object_methods): Add thread_from_handle.  Retain
9261         thread_from_thread_handle, but mark it as deprecated.
9262
9263 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9264
9265         * gdbthread.h (find_thread_by_handle): Revise declaration.
9266         * thread.c (find_thread_by_handle): Likewise.  Adjust
9267         implementation too.
9268         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9269         support for buffer objects as handles.
9270
9271 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9272
9273         * python/py-infthread.c (thpy_thread_handle): New function.
9274         (thread_object_methods): Register thpy_thread_handle.
9275
9276 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9277
9278         * gdbthread.h (thread_to_thread_handle): Declare.
9279         * thread.c (gdbtypes.h): Include.
9280         (thread_to_thread_handle): New function.
9281
9282         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9283         (target_thread_info_to_thread_handle): Declare.
9284         * target.c (target_thread_info_to_thread_handle): New function.
9285         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9286         * target-delegates.c: Regenerate.
9287
9288         * linux-thread-db.c (class thread_db_target): Add method
9289         thread_info_to_thread_handle.
9290         (thread_db_target::thread_info_to_thread_handle): Define.
9291         * remote.c (class remote_target): Add new method
9292         thread_info_to_thread_handle.
9293         (remote_target::thread_info_to_thread_handle): Define.
9294
9295 2019-04-08  Pedro Alves  <palves@redhat.com>
9296
9297         * common/common-exceptions.c (throw_exception): Don't create
9298         named object to throw; throw directly.
9299         (throw_it): Likewise.  Don't initialize gdb_exception::message
9300         here, with new; pass FMT and AP to the ctor instead.
9301         * common/common-exceptions.h: Include <string>.
9302         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9303         const char *, va_list)): New ctor.  Use std::make_shared.
9304         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9305         errors)): Delete.
9306         (gdb_exception_error::gdb_exception_error(enum errors, const char
9307         *, va_list)): New.
9308         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9309         Add assertion.
9310         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9311         errors)): Delete.
9312         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9313         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9314         Add assertion.
9315
9316 2019-04-08  Tom Tromey  <tom@tromey.com>
9317
9318         * valops.c (value_rtti_indirect_type): Replace throw_exception
9319         with throw.
9320         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9321         with throw.
9322         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9323         throw.
9324         * target.c (target_translate_tls_address): Replace throw_exception
9325         with throw.
9326         * stack.c (frame_apply_command_count): Replace throw_exception
9327         with throw.
9328         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9329         throw.
9330         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9331         with throw.
9332         * rs6000-tdep.c (rs6000_frame_cache)
9333         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9334         * remote.c: Replace throw_exception with throw.
9335         * record-full.c (record_full_message, record_full_wait_1)
9336         (record_full_restore): Replace throw_exception with throw.
9337         * record-btrace.c:
9338         (get_thread_current_frame_id, record_btrace_start_replaying)
9339         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9340         (cmd_record_btrace_start): Replace throw_exception with throw.
9341         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9342         throw.
9343         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9344         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9345         * linespec.c:
9346         (find_linespec_symbols): Replace throw_exception with throw.
9347         * infrun.c (displaced_step_prepare, resume): Replace
9348         throw_exception with throw.
9349         * infcmd.c (post_create_inferior): Replace throw_exception with
9350         throw.
9351         * inf-loop.c (inferior_event_handler): Replace throw_exception
9352         with throw.
9353         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9354         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9355         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9356         (get_prev_frame_always, get_frame_pc_if_available)
9357         (get_frame_address_in_block_if_available, get_frame_language):
9358         Replace throw_exception with throw.
9359         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9360         throw_exception with throw.
9361         * eval.c (fetch_subexp_value, evaluate_var_value)
9362         (evaluate_funcall, evaluate_subexp_standard): Replace
9363         throw_exception with throw.
9364         * dwarf2loc.c (call_site_find_chain)
9365         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9366         Replace throw_exception with throw.
9367         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9368         with throw.
9369         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9370         throw.
9371         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9372         * completer.c (complete_line_internal): Replace throw_exception
9373         with throw.
9374         * compile/compile-object-run.c (compile_object_run): Replace
9375         throw_exception with throw.
9376         * cli/cli-script.c (process_next_line): Replace throw_exception
9377         with throw.
9378         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9379         (btrace_enable, btrace_maint_update_pt_packets): Replace
9380         throw_exception with throw.
9381         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9382         throw_exception with throw.
9383         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9384         throw_exception with throw.
9385         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9386         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9387         * aarch64-tdep.c (aarch64_make_prologue_cache)
9388         (aarch64_make_stub_cache): Replace throw_exception with throw.
9389
9390 2019-04-08  Tom Tromey  <tom@tromey.com>
9391
9392         * common/common-exceptions.c (throw_exception): Rename from
9393         throw_exception_cxx.  Remove old copy.  Make argument const.
9394         (throw_it): Create and throw exception objects directly.
9395         * common/common-exceptions.h (throw_exception): Make argument
9396         const.
9397         (struct gdb_exception_error): Add constructor.
9398         (struct gdb_exception_quit): Add constructor.
9399
9400 2019-04-08  Tom Tromey  <tom@tromey.com>
9401
9402         * common/common-exceptions.h (exception_rethrow): Don't declare.
9403         (TRY_SJLJ): Update comment.
9404         (TRY, CATCH, END_CATCH): Remove.
9405         * common/common-exceptions.c (exception_rethrow): Remove.
9406
9407 2019-04-08  Tom Tromey  <tom@tromey.com>
9408
9409         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9410         Remove.
9411         (gdb_exception_error): Rename from
9412         gdb_exception_RETURN_MASK_ERROR.
9413         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9414         (gdb_quit_bad_alloc): Update.
9415         * aarch64-tdep.c: Update.
9416         * ada-lang.c: Update.
9417         * ada-typeprint.c: Update.
9418         * ada-valprint.c: Update.
9419         * amd64-tdep.c: Update.
9420         * arch-utils.c: Update.
9421         * break-catch-throw.c: Update.
9422         * breakpoint.c: Update.
9423         * btrace.c: Update.
9424         * c-varobj.c: Update.
9425         * cli/cli-cmds.c: Update.
9426         * cli/cli-interp.c: Update.
9427         * cli/cli-script.c: Update.
9428         * common/common-exceptions.c: Update.
9429         * common/new-op.c: Update.
9430         * common/selftest.c: Update.
9431         * compile/compile-c-symbols.c: Update.
9432         * compile/compile-cplus-symbols.c: Update.
9433         * compile/compile-object-load.c: Update.
9434         * compile/compile-object-run.c: Update.
9435         * completer.c: Update.
9436         * corelow.c: Update.
9437         * cp-abi.c: Update.
9438         * cp-support.c: Update.
9439         * cp-valprint.c: Update.
9440         * darwin-nat.c: Update.
9441         * disasm-selftests.c: Update.
9442         * dtrace-probe.c: Update.
9443         * dwarf-index-cache.c: Update.
9444         * dwarf-index-write.c: Update.
9445         * dwarf2-frame-tailcall.c: Update.
9446         * dwarf2-frame.c: Update.
9447         * dwarf2loc.c: Update.
9448         * dwarf2read.c: Update.
9449         * eval.c: Update.
9450         * event-loop.c: Update.
9451         * event-top.c: Update.
9452         * exec.c: Update.
9453         * f-valprint.c: Update.
9454         * fbsd-tdep.c: Update.
9455         * frame-unwind.c: Update.
9456         * frame.c: Update.
9457         * gdbtypes.c: Update.
9458         * gnu-v3-abi.c: Update.
9459         * guile/guile-internal.h: Update.
9460         * guile/scm-block.c: Update.
9461         * guile/scm-breakpoint.c: Update.
9462         * guile/scm-cmd.c: Update.
9463         * guile/scm-disasm.c: Update.
9464         * guile/scm-frame.c: Update.
9465         * guile/scm-lazy-string.c: Update.
9466         * guile/scm-math.c: Update.
9467         * guile/scm-param.c: Update.
9468         * guile/scm-ports.c: Update.
9469         * guile/scm-pretty-print.c: Update.
9470         * guile/scm-symbol.c: Update.
9471         * guile/scm-symtab.c: Update.
9472         * guile/scm-type.c: Update.
9473         * guile/scm-value.c: Update.
9474         * i386-linux-tdep.c: Update.
9475         * i386-tdep.c: Update.
9476         * inf-loop.c: Update.
9477         * infcall.c: Update.
9478         * infcmd.c: Update.
9479         * infrun.c: Update.
9480         * jit.c: Update.
9481         * language.c: Update.
9482         * linespec.c: Update.
9483         * linux-fork.c: Update.
9484         * linux-nat.c: Update.
9485         * linux-tdep.c: Update.
9486         * linux-thread-db.c: Update.
9487         * main.c: Update.
9488         * mi/mi-cmd-break.c: Update.
9489         * mi/mi-cmd-stack.c: Update.
9490         * mi/mi-interp.c: Update.
9491         * mi/mi-main.c: Update.
9492         * objc-lang.c: Update.
9493         * p-valprint.c: Update.
9494         * parse.c: Update.
9495         * ppc-linux-tdep.c: Update.
9496         * printcmd.c: Update.
9497         * python/py-arch.c: Update.
9498         * python/py-breakpoint.c: Update.
9499         * python/py-cmd.c: Update.
9500         * python/py-finishbreakpoint.c: Update.
9501         * python/py-frame.c: Update.
9502         * python/py-framefilter.c: Update.
9503         * python/py-gdb-readline.c: Update.
9504         * python/py-inferior.c: Update.
9505         * python/py-infthread.c: Update.
9506         * python/py-lazy-string.c: Update.
9507         * python/py-linetable.c: Update.
9508         * python/py-objfile.c: Update.
9509         * python/py-param.c: Update.
9510         * python/py-prettyprint.c: Update.
9511         * python/py-progspace.c: Update.
9512         * python/py-record-btrace.c: Update.
9513         * python/py-record.c: Update.
9514         * python/py-symbol.c: Update.
9515         * python/py-type.c: Update.
9516         * python/py-unwind.c: Update.
9517         * python/py-utils.c: Update.
9518         * python/py-value.c: Update.
9519         * python/python.c: Update.
9520         * record-btrace.c: Update.
9521         * record-full.c: Update.
9522         * remote-fileio.c: Update.
9523         * remote.c: Update.
9524         * riscv-tdep.c: Update.
9525         * rs6000-aix-tdep.c: Update.
9526         * rs6000-tdep.c: Update.
9527         * rust-exp.y: Update.
9528         * rust-lang.c: Update.
9529         * s390-tdep.c: Update.
9530         * selftest-arch.c: Update.
9531         * solib-dsbt.c: Update.
9532         * solib-frv.c: Update.
9533         * solib-spu.c: Update.
9534         * solib-svr4.c: Update.
9535         * solib.c: Update.
9536         * sparc64-linux-tdep.c: Update.
9537         * stack.c: Update.
9538         * symfile-mem.c: Update.
9539         * symmisc.c: Update.
9540         * target.c: Update.
9541         * thread.c: Update.
9542         * top.c: Update.
9543         * tracefile-tfile.c: Update.
9544         * tui/tui.c: Update.
9545         * typeprint.c: Update.
9546         * unittests/cli-utils-selftests.c: Update.
9547         * unittests/parse-connection-spec-selftests.c: Update.
9548         * valops.c: Update.
9549         * valprint.c: Update.
9550         * value.c: Update.
9551         * varobj.c: Update.
9552         * windows-nat.c: Update.
9553         * x86-linux-nat.c: Update.
9554         * xml-support.c: Update.
9555
9556 2019-04-08  Tom Tromey  <tom@tromey.com>
9557
9558         * xml-support.c: Use C++ exception handling.
9559         * x86-linux-nat.c: Use C++ exception handling.
9560         * windows-nat.c: Use C++ exception handling.
9561         * varobj.c: Use C++ exception handling.
9562         * value.c: Use C++ exception handling.
9563         * valprint.c: Use C++ exception handling.
9564         * valops.c: Use C++ exception handling.
9565         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9566         handling.
9567         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9568         * typeprint.c: Use C++ exception handling.
9569         * tui/tui.c: Use C++ exception handling.
9570         * tracefile-tfile.c: Use C++ exception handling.
9571         * top.c: Use C++ exception handling.
9572         * thread.c: Use C++ exception handling.
9573         * target.c: Use C++ exception handling.
9574         * symmisc.c: Use C++ exception handling.
9575         * symfile-mem.c: Use C++ exception handling.
9576         * stack.c: Use C++ exception handling.
9577         * sparc64-linux-tdep.c: Use C++ exception handling.
9578         * solib.c: Use C++ exception handling.
9579         * solib-svr4.c: Use C++ exception handling.
9580         * solib-spu.c: Use C++ exception handling.
9581         * solib-frv.c: Use C++ exception handling.
9582         * solib-dsbt.c: Use C++ exception handling.
9583         * selftest-arch.c: Use C++ exception handling.
9584         * s390-tdep.c: Use C++ exception handling.
9585         * rust-lang.c: Use C++ exception handling.
9586         * rust-exp.y: Use C++ exception handling.
9587         * rs6000-tdep.c: Use C++ exception handling.
9588         * rs6000-aix-tdep.c: Use C++ exception handling.
9589         * riscv-tdep.c: Use C++ exception handling.
9590         * remote.c: Use C++ exception handling.
9591         * remote-fileio.c: Use C++ exception handling.
9592         * record-full.c: Use C++ exception handling.
9593         * record-btrace.c: Use C++ exception handling.
9594         * python/python.c: Use C++ exception handling.
9595         * python/py-value.c: Use C++ exception handling.
9596         * python/py-utils.c: Use C++ exception handling.
9597         * python/py-unwind.c: Use C++ exception handling.
9598         * python/py-type.c: Use C++ exception handling.
9599         * python/py-symbol.c: Use C++ exception handling.
9600         * python/py-record.c: Use C++ exception handling.
9601         * python/py-record-btrace.c: Use C++ exception handling.
9602         * python/py-progspace.c: Use C++ exception handling.
9603         * python/py-prettyprint.c: Use C++ exception handling.
9604         * python/py-param.c: Use C++ exception handling.
9605         * python/py-objfile.c: Use C++ exception handling.
9606         * python/py-linetable.c: Use C++ exception handling.
9607         * python/py-lazy-string.c: Use C++ exception handling.
9608         * python/py-infthread.c: Use C++ exception handling.
9609         * python/py-inferior.c: Use C++ exception handling.
9610         * python/py-gdb-readline.c: Use C++ exception handling.
9611         * python/py-framefilter.c: Use C++ exception handling.
9612         * python/py-frame.c: Use C++ exception handling.
9613         * python/py-finishbreakpoint.c: Use C++ exception handling.
9614         * python/py-cmd.c: Use C++ exception handling.
9615         * python/py-breakpoint.c: Use C++ exception handling.
9616         * python/py-arch.c: Use C++ exception handling.
9617         * printcmd.c: Use C++ exception handling.
9618         * ppc-linux-tdep.c: Use C++ exception handling.
9619         * parse.c: Use C++ exception handling.
9620         * p-valprint.c: Use C++ exception handling.
9621         * objc-lang.c: Use C++ exception handling.
9622         * mi/mi-main.c: Use C++ exception handling.
9623         * mi/mi-interp.c: Use C++ exception handling.
9624         * mi/mi-cmd-stack.c: Use C++ exception handling.
9625         * mi/mi-cmd-break.c: Use C++ exception handling.
9626         * main.c: Use C++ exception handling.
9627         * linux-thread-db.c: Use C++ exception handling.
9628         * linux-tdep.c: Use C++ exception handling.
9629         * linux-nat.c: Use C++ exception handling.
9630         * linux-fork.c: Use C++ exception handling.
9631         * linespec.c: Use C++ exception handling.
9632         * language.c: Use C++ exception handling.
9633         * jit.c: Use C++ exception handling.
9634         * infrun.c: Use C++ exception handling.
9635         * infcmd.c: Use C++ exception handling.
9636         * infcall.c: Use C++ exception handling.
9637         * inf-loop.c: Use C++ exception handling.
9638         * i386-tdep.c: Use C++ exception handling.
9639         * i386-linux-tdep.c: Use C++ exception handling.
9640         * guile/scm-value.c: Use C++ exception handling.
9641         * guile/scm-type.c: Use C++ exception handling.
9642         * guile/scm-symtab.c: Use C++ exception handling.
9643         * guile/scm-symbol.c: Use C++ exception handling.
9644         * guile/scm-pretty-print.c: Use C++ exception handling.
9645         * guile/scm-ports.c: Use C++ exception handling.
9646         * guile/scm-param.c: Use C++ exception handling.
9647         * guile/scm-math.c: Use C++ exception handling.
9648         * guile/scm-lazy-string.c: Use C++ exception handling.
9649         * guile/scm-frame.c: Use C++ exception handling.
9650         * guile/scm-disasm.c: Use C++ exception handling.
9651         * guile/scm-cmd.c: Use C++ exception handling.
9652         * guile/scm-breakpoint.c: Use C++ exception handling.
9653         * guile/scm-block.c: Use C++ exception handling.
9654         * guile/guile-internal.h: Use C++ exception handling.
9655         * gnu-v3-abi.c: Use C++ exception handling.
9656         * gdbtypes.c: Use C++ exception handling.
9657         * frame.c: Use C++ exception handling.
9658         * frame-unwind.c: Use C++ exception handling.
9659         * fbsd-tdep.c: Use C++ exception handling.
9660         * f-valprint.c: Use C++ exception handling.
9661         * exec.c: Use C++ exception handling.
9662         * event-top.c: Use C++ exception handling.
9663         * event-loop.c: Use C++ exception handling.
9664         * eval.c: Use C++ exception handling.
9665         * dwarf2read.c: Use C++ exception handling.
9666         * dwarf2loc.c: Use C++ exception handling.
9667         * dwarf2-frame.c: Use C++ exception handling.
9668         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9669         * dwarf-index-write.c: Use C++ exception handling.
9670         * dwarf-index-cache.c: Use C++ exception handling.
9671         * dtrace-probe.c: Use C++ exception handling.
9672         * disasm-selftests.c: Use C++ exception handling.
9673         * darwin-nat.c: Use C++ exception handling.
9674         * cp-valprint.c: Use C++ exception handling.
9675         * cp-support.c: Use C++ exception handling.
9676         * cp-abi.c: Use C++ exception handling.
9677         * corelow.c: Use C++ exception handling.
9678         * completer.c: Use C++ exception handling.
9679         * compile/compile-object-run.c: Use C++ exception handling.
9680         * compile/compile-object-load.c: Use C++ exception handling.
9681         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9682         * compile/compile-c-symbols.c: Use C++ exception handling.
9683         * common/selftest.c: Use C++ exception handling.
9684         * common/new-op.c: Use C++ exception handling.
9685         * cli/cli-script.c: Use C++ exception handling.
9686         * cli/cli-interp.c: Use C++ exception handling.
9687         * cli/cli-cmds.c: Use C++ exception handling.
9688         * c-varobj.c: Use C++ exception handling.
9689         * btrace.c: Use C++ exception handling.
9690         * breakpoint.c: Use C++ exception handling.
9691         * break-catch-throw.c: Use C++ exception handling.
9692         * arch-utils.c: Use C++ exception handling.
9693         * amd64-tdep.c: Use C++ exception handling.
9694         * ada-valprint.c: Use C++ exception handling.
9695         * ada-typeprint.c: Use C++ exception handling.
9696         * ada-lang.c: Use C++ exception handling.
9697         * aarch64-tdep.c: Use C++ exception handling.
9698
9699 2019-04-08  Tom Tromey  <tom@tromey.com>
9700
9701         * xml-support.c (gdb_xml_parser::parse): Update.
9702         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9703         * value.c (show_convenience): Update.
9704         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9705         (test_parse_flags_qcs): Update.
9706         * thread.c (thr_try_catch_cmd): Update.
9707         * target.c (target_translate_tls_address): Update.
9708         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9709         (info_frame_command_core, frame_apply_command_count): Update.
9710         * rust-exp.y (rust_lex_exception_test): Update.
9711         * riscv-tdep.c (riscv_print_one_register_info): Update.
9712         * remote.c (remote_target::enable_btrace): Update.
9713         * record-btrace.c (record_btrace_enable_warn): Update.
9714         * python/py-utils.c (gdbpy_convert_exception): Update.
9715         * printcmd.c (do_one_display, print_variable_and_value): Update.
9716         * mi/mi-main.c (mi_print_exception): Update.
9717         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9718         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9719         * linux-nat.c (linux_nat_target::attach): Update.
9720         * linux-fork.c (class scoped_switch_fork_info): Update.
9721         * infrun.c (displaced_step_prepare): Update.
9722         * infcall.c (call_function_by_hand_dummy): Update.
9723         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9724         * gnu-v3-abi.c (print_one_vtable): Update.
9725         * frame.c (get_prev_frame_always): Update.
9726         * f-valprint.c (info_common_command_for_block): Update.
9727         * exec.c (try_open_exec_file): Update.
9728         * exceptions.c (print_exception, exception_print)
9729         (exception_fprintf, exception_print_same): Update.
9730         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9731         * dwarf-index-cache.c (index_cache::store)
9732         (index_cache::lookup_gdb_index): Update.
9733         * darwin-nat.c (maybe_cache_shell): Update.
9734         * cp-valprint.c (cp_print_value_fields): Update.
9735         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9736         (gcc_cplus_symbol_address): Update.
9737         * compile/compile-c-symbols.c (gcc_convert_symbol)
9738         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9739         * common/selftest.c: Update.
9740         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9741         a std::string.
9742         (exception_try_scope_entry, exception_try_scope_exit): Don't
9743         declare.
9744         (struct exception_try_scope): Remove.
9745         (TRY): Don't use exception_try_scope.
9746         (struct gdb_exception): Add constructor, operator=.
9747         <what>: New method.
9748         (struct gdb_exception_RETURN_MASK_ALL)
9749         (struct gdb_exception_RETURN_MASK_ERROR)
9750         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9751         (struct gdb_quit_bad_alloc): Update.
9752         * common/common-exceptions.c (exception_none): Change
9753         initializer.
9754         (struct catcher) <state, exception>: Initialize inline.
9755         <prev>: Remove member.
9756         (current_catcher): Remove.
9757         (catchers): New global.
9758         (exceptions_state_mc_init): Simplify.
9759         (catcher_pop): Remove.
9760         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9761         (try_scope_depth, exception_try_scope_entry)
9762         (exception_try_scope_exit): Remove.
9763         (throw_exception_sjlj): Update.
9764         (exception_messages, exception_messages_size): Remove.
9765         (throw_it): Simplify.
9766         (gdb_exception_sliced_copy): Remove.
9767         (throw_exception_cxx): Update.
9768         * cli/cli-script.c (script_from_file): Update.
9769         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9770         Update.
9771         * ada-valprint.c (ada_val_print): Update.
9772         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9773         (create_excep_cond_exprs): Update.
9774
9775 2019-04-08  Tom Tromey  <tom@tromey.com>
9776
9777         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9778         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9779         (TRY, CATCH, END_CATCH): Remove some definitions.
9780         * common/common-exceptions.c: Don't use GDB_XCPT.
9781         (catcher_list_size): Remove.
9782         (throw_exception, throw_it): Simplify.
9783
9784 2019-04-05  Tom Tromey  <tom@tromey.com>
9785
9786         Revert the header-sorting patch.
9787         * ft32-tdep.c: Revert.
9788         * frv-tdep.c: Revert.
9789         * frv-linux-tdep.c: Revert.
9790         * frame.c: Revert.
9791         * frame-unwind.c: Revert.
9792         * frame-base.c: Revert.
9793         * fork-child.c: Revert.
9794         * findvar.c: Revert.
9795         * findcmd.c: Revert.
9796         * filesystem.c: Revert.
9797         * filename-seen-cache.h: Revert.
9798         * filename-seen-cache.c: Revert.
9799         * fbsd-tdep.c: Revert.
9800         * fbsd-nat.h: Revert.
9801         * fbsd-nat.c: Revert.
9802         * f-valprint.c: Revert.
9803         * f-typeprint.c: Revert.
9804         * f-lang.c: Revert.
9805         * extension.h: Revert.
9806         * extension.c: Revert.
9807         * extension-priv.h: Revert.
9808         * expprint.c: Revert.
9809         * exec.h: Revert.
9810         * exec.c: Revert.
9811         * exceptions.c: Revert.
9812         * event-top.c: Revert.
9813         * event-loop.c: Revert.
9814         * eval.c: Revert.
9815         * elfread.c: Revert.
9816         * dwarf2read.h: Revert.
9817         * dwarf2read.c: Revert.
9818         * dwarf2loc.c: Revert.
9819         * dwarf2expr.h: Revert.
9820         * dwarf2expr.c: Revert.
9821         * dwarf2-frame.c: Revert.
9822         * dwarf2-frame-tailcall.c: Revert.
9823         * dwarf-index-write.h: Revert.
9824         * dwarf-index-write.c: Revert.
9825         * dwarf-index-common.c: Revert.
9826         * dwarf-index-cache.h: Revert.
9827         * dwarf-index-cache.c: Revert.
9828         * dummy-frame.c: Revert.
9829         * dtrace-probe.c: Revert.
9830         * disasm.h: Revert.
9831         * disasm.c: Revert.
9832         * disasm-selftests.c: Revert.
9833         * dictionary.c: Revert.
9834         * dicos-tdep.c: Revert.
9835         * demangle.c: Revert.
9836         * dcache.h: Revert.
9837         * dcache.c: Revert.
9838         * darwin-nat.h: Revert.
9839         * darwin-nat.c: Revert.
9840         * darwin-nat-info.c: Revert.
9841         * d-valprint.c: Revert.
9842         * d-namespace.c: Revert.
9843         * d-lang.c: Revert.
9844         * ctf.c: Revert.
9845         * csky-tdep.c: Revert.
9846         * csky-linux-tdep.c: Revert.
9847         * cris-tdep.c: Revert.
9848         * cris-linux-tdep.c: Revert.
9849         * cp-valprint.c: Revert.
9850         * cp-support.c: Revert.
9851         * cp-namespace.c: Revert.
9852         * cp-abi.c: Revert.
9853         * corelow.c: Revert.
9854         * corefile.c: Revert.
9855         * continuations.c: Revert.
9856         * completer.h: Revert.
9857         * completer.c: Revert.
9858         * complaints.c: Revert.
9859         * coffread.c: Revert.
9860         * coff-pe-read.c: Revert.
9861         * cli-out.h: Revert.
9862         * cli-out.c: Revert.
9863         * charset.c: Revert.
9864         * c-varobj.c: Revert.
9865         * c-valprint.c: Revert.
9866         * c-typeprint.c: Revert.
9867         * c-lang.c: Revert.
9868         * buildsym.c: Revert.
9869         * buildsym-legacy.c: Revert.
9870         * build-id.h: Revert.
9871         * build-id.c: Revert.
9872         * btrace.c: Revert.
9873         * bsd-uthread.c: Revert.
9874         * breakpoint.h: Revert.
9875         * breakpoint.c: Revert.
9876         * break-catch-throw.c: Revert.
9877         * break-catch-syscall.c: Revert.
9878         * break-catch-sig.c: Revert.
9879         * blockframe.c: Revert.
9880         * block.c: Revert.
9881         * bfin-tdep.c: Revert.
9882         * bfin-linux-tdep.c: Revert.
9883         * bfd-target.c: Revert.
9884         * bcache.c: Revert.
9885         * ax-general.c: Revert.
9886         * ax-gdb.h: Revert.
9887         * ax-gdb.c: Revert.
9888         * avr-tdep.c: Revert.
9889         * auxv.c: Revert.
9890         * auto-load.c: Revert.
9891         * arm-wince-tdep.c: Revert.
9892         * arm-tdep.c: Revert.
9893         * arm-symbian-tdep.c: Revert.
9894         * arm-pikeos-tdep.c: Revert.
9895         * arm-obsd-tdep.c: Revert.
9896         * arm-nbsd-tdep.c: Revert.
9897         * arm-nbsd-nat.c: Revert.
9898         * arm-linux-tdep.c: Revert.
9899         * arm-linux-nat.c: Revert.
9900         * arm-fbsd-tdep.c: Revert.
9901         * arm-fbsd-nat.c: Revert.
9902         * arm-bsd-tdep.c: Revert.
9903         * arch-utils.c: Revert.
9904         * arc-tdep.c: Revert.
9905         * arc-newlib-tdep.c: Revert.
9906         * annotate.h: Revert.
9907         * annotate.c: Revert.
9908         * amd64-windows-tdep.c: Revert.
9909         * amd64-windows-nat.c: Revert.
9910         * amd64-tdep.c: Revert.
9911         * amd64-sol2-tdep.c: Revert.
9912         * amd64-obsd-tdep.c: Revert.
9913         * amd64-obsd-nat.c: Revert.
9914         * amd64-nbsd-tdep.c: Revert.
9915         * amd64-nbsd-nat.c: Revert.
9916         * amd64-nat.c: Revert.
9917         * amd64-linux-tdep.c: Revert.
9918         * amd64-linux-nat.c: Revert.
9919         * amd64-fbsd-tdep.c: Revert.
9920         * amd64-fbsd-nat.c: Revert.
9921         * amd64-dicos-tdep.c: Revert.
9922         * amd64-darwin-tdep.c: Revert.
9923         * amd64-bsd-nat.c: Revert.
9924         * alpha-tdep.c: Revert.
9925         * alpha-obsd-tdep.c: Revert.
9926         * alpha-nbsd-tdep.c: Revert.
9927         * alpha-mdebug-tdep.c: Revert.
9928         * alpha-linux-tdep.c: Revert.
9929         * alpha-linux-nat.c: Revert.
9930         * alpha-bsd-tdep.c: Revert.
9931         * alpha-bsd-nat.c: Revert.
9932         * aix-thread.c: Revert.
9933         * agent.c: Revert.
9934         * addrmap.c: Revert.
9935         * ada-varobj.c: Revert.
9936         * ada-valprint.c: Revert.
9937         * ada-typeprint.c: Revert.
9938         * ada-tasks.c: Revert.
9939         * ada-lang.c: Revert.
9940         * aarch64-tdep.c: Revert.
9941         * aarch64-ravenscar-thread.c: Revert.
9942         * aarch64-newlib-tdep.c: Revert.
9943         * aarch64-linux-tdep.c: Revert.
9944         * aarch64-linux-nat.c: Revert.
9945         * aarch64-fbsd-tdep.c: Revert.
9946         * aarch64-fbsd-nat.c: Revert.
9947         * aarch32-linux-nat.c: Revert.
9948
9949 2019-04-05  Tom Tromey  <tom@tromey.com>
9950
9951         * ft32-tdep.c: Sort headers.
9952         * frv-tdep.c: Sort headers.
9953         * frv-linux-tdep.c: Sort headers.
9954         * frame.c: Sort headers.
9955         * frame-unwind.c: Sort headers.
9956         * frame-base.c: Sort headers.
9957         * fork-child.c: Sort headers.
9958         * findvar.c: Sort headers.
9959         * findcmd.c: Sort headers.
9960         * filesystem.c: Sort headers.
9961         * filename-seen-cache.h: Sort headers.
9962         * filename-seen-cache.c: Sort headers.
9963         * fbsd-tdep.c: Sort headers.
9964         * fbsd-nat.h: Sort headers.
9965         * fbsd-nat.c: Sort headers.
9966         * f-valprint.c: Sort headers.
9967         * f-typeprint.c: Sort headers.
9968         * f-lang.c: Sort headers.
9969         * extension.h: Sort headers.
9970         * extension.c: Sort headers.
9971         * extension-priv.h: Sort headers.
9972         * expprint.c: Sort headers.
9973         * exec.h: Sort headers.
9974         * exec.c: Sort headers.
9975         * exceptions.c: Sort headers.
9976         * event-top.c: Sort headers.
9977         * event-loop.c: Sort headers.
9978         * eval.c: Sort headers.
9979         * elfread.c: Sort headers.
9980         * dwarf2read.h: Sort headers.
9981         * dwarf2read.c: Sort headers.
9982         * dwarf2loc.c: Sort headers.
9983         * dwarf2expr.h: Sort headers.
9984         * dwarf2expr.c: Sort headers.
9985         * dwarf2-frame.c: Sort headers.
9986         * dwarf2-frame-tailcall.c: Sort headers.
9987         * dwarf-index-write.h: Sort headers.
9988         * dwarf-index-write.c: Sort headers.
9989         * dwarf-index-common.c: Sort headers.
9990         * dwarf-index-cache.h: Sort headers.
9991         * dwarf-index-cache.c: Sort headers.
9992         * dummy-frame.c: Sort headers.
9993         * dtrace-probe.c: Sort headers.
9994         * disasm.h: Sort headers.
9995         * disasm.c: Sort headers.
9996         * disasm-selftests.c: Sort headers.
9997         * dictionary.c: Sort headers.
9998         * dicos-tdep.c: Sort headers.
9999         * demangle.c: Sort headers.
10000         * dcache.h: Sort headers.
10001         * dcache.c: Sort headers.
10002         * darwin-nat.h: Sort headers.
10003         * darwin-nat.c: Sort headers.
10004         * darwin-nat-info.c: Sort headers.
10005         * d-valprint.c: Sort headers.
10006         * d-namespace.c: Sort headers.
10007         * d-lang.c: Sort headers.
10008         * ctf.c: Sort headers.
10009         * csky-tdep.c: Sort headers.
10010         * csky-linux-tdep.c: Sort headers.
10011         * cris-tdep.c: Sort headers.
10012         * cris-linux-tdep.c: Sort headers.
10013         * cp-valprint.c: Sort headers.
10014         * cp-support.c: Sort headers.
10015         * cp-namespace.c: Sort headers.
10016         * cp-abi.c: Sort headers.
10017         * corelow.c: Sort headers.
10018         * corefile.c: Sort headers.
10019         * continuations.c: Sort headers.
10020         * completer.h: Sort headers.
10021         * completer.c: Sort headers.
10022         * complaints.c: Sort headers.
10023         * coffread.c: Sort headers.
10024         * coff-pe-read.c: Sort headers.
10025         * cli-out.h: Sort headers.
10026         * cli-out.c: Sort headers.
10027         * charset.c: Sort headers.
10028         * c-varobj.c: Sort headers.
10029         * c-valprint.c: Sort headers.
10030         * c-typeprint.c: Sort headers.
10031         * c-lang.c: Sort headers.
10032         * buildsym.c: Sort headers.
10033         * buildsym-legacy.c: Sort headers.
10034         * build-id.h: Sort headers.
10035         * build-id.c: Sort headers.
10036         * btrace.c: Sort headers.
10037         * bsd-uthread.c: Sort headers.
10038         * breakpoint.h: Sort headers.
10039         * breakpoint.c: Sort headers.
10040         * break-catch-throw.c: Sort headers.
10041         * break-catch-syscall.c: Sort headers.
10042         * break-catch-sig.c: Sort headers.
10043         * blockframe.c: Sort headers.
10044         * block.c: Sort headers.
10045         * bfin-tdep.c: Sort headers.
10046         * bfin-linux-tdep.c: Sort headers.
10047         * bfd-target.c: Sort headers.
10048         * bcache.c: Sort headers.
10049         * ax-general.c: Sort headers.
10050         * ax-gdb.h: Sort headers.
10051         * ax-gdb.c: Sort headers.
10052         * avr-tdep.c: Sort headers.
10053         * auxv.c: Sort headers.
10054         * auto-load.c: Sort headers.
10055         * arm-wince-tdep.c: Sort headers.
10056         * arm-tdep.c: Sort headers.
10057         * arm-symbian-tdep.c: Sort headers.
10058         * arm-pikeos-tdep.c: Sort headers.
10059         * arm-obsd-tdep.c: Sort headers.
10060         * arm-nbsd-tdep.c: Sort headers.
10061         * arm-nbsd-nat.c: Sort headers.
10062         * arm-linux-tdep.c: Sort headers.
10063         * arm-linux-nat.c: Sort headers.
10064         * arm-fbsd-tdep.c: Sort headers.
10065         * arm-fbsd-nat.c: Sort headers.
10066         * arm-bsd-tdep.c: Sort headers.
10067         * arch-utils.c: Sort headers.
10068         * arc-tdep.c: Sort headers.
10069         * arc-newlib-tdep.c: Sort headers.
10070         * annotate.h: Sort headers.
10071         * annotate.c: Sort headers.
10072         * amd64-windows-tdep.c: Sort headers.
10073         * amd64-windows-nat.c: Sort headers.
10074         * amd64-tdep.c: Sort headers.
10075         * amd64-sol2-tdep.c: Sort headers.
10076         * amd64-obsd-tdep.c: Sort headers.
10077         * amd64-obsd-nat.c: Sort headers.
10078         * amd64-nbsd-tdep.c: Sort headers.
10079         * amd64-nbsd-nat.c: Sort headers.
10080         * amd64-nat.c: Sort headers.
10081         * amd64-linux-tdep.c: Sort headers.
10082         * amd64-linux-nat.c: Sort headers.
10083         * amd64-fbsd-tdep.c: Sort headers.
10084         * amd64-fbsd-nat.c: Sort headers.
10085         * amd64-dicos-tdep.c: Sort headers.
10086         * amd64-darwin-tdep.c: Sort headers.
10087         * amd64-bsd-nat.c: Sort headers.
10088         * alpha-tdep.c: Sort headers.
10089         * alpha-obsd-tdep.c: Sort headers.
10090         * alpha-nbsd-tdep.c: Sort headers.
10091         * alpha-mdebug-tdep.c: Sort headers.
10092         * alpha-linux-tdep.c: Sort headers.
10093         * alpha-linux-nat.c: Sort headers.
10094         * alpha-bsd-tdep.c: Sort headers.
10095         * alpha-bsd-nat.c: Sort headers.
10096         * aix-thread.c: Sort headers.
10097         * agent.c: Sort headers.
10098         * addrmap.c: Sort headers.
10099         * ada-varobj.c: Sort headers.
10100         * ada-valprint.c: Sort headers.
10101         * ada-typeprint.c: Sort headers.
10102         * ada-tasks.c: Sort headers.
10103         * ada-lang.c: Sort headers.
10104         * aarch64-tdep.c: Sort headers.
10105         * aarch64-ravenscar-thread.c: Sort headers.
10106         * aarch64-newlib-tdep.c: Sort headers.
10107         * aarch64-linux-tdep.c: Sort headers.
10108         * aarch64-linux-nat.c: Sort headers.
10109         * aarch64-fbsd-tdep.c: Sort headers.
10110         * aarch64-fbsd-nat.c: Sort headers.
10111         * aarch32-linux-nat.c: Sort headers.
10112
10113 2019-04-04  Tom Tromey  <tom@tromey.com>
10114
10115         * varobj.c (varobj_create): Update.
10116         * rust-exp.y (struct rust_parser) <update_innermost_block,
10117         lookup_symbol>: New methods.
10118         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10119         Rename.
10120         (rust_parser::rust_lookup_type)
10121         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10122         * printcmd.c (display_command, do_one_display): Update.
10123         * parser-defs.h (struct parser_state) <parser_state>: Add
10124         "tracker" parameter.
10125         (block_tracker): New member.
10126         (class innermost_block_tracker) <innermost_block_tracker>: Add
10127         "types" parameter.
10128         <reset>: Remove method.
10129         (innermost_block): Don't declare.
10130         (null_post_parser): Update.
10131         * parse.c (innermost_block): Remove global.
10132         (write_dollar_variable): Update.
10133         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10134         Remove "tracker_types" parameter.
10135         (parse_expression): Add "tracker" parameter.
10136         (parse_expression_for_completion): Update.
10137         (null_post_parser): Add "tracker" parameter.
10138         * p-exp.y: Update rules.
10139         * m2-exp.y: Update rules.
10140         * language.h (struct language_defn) <la_post_parser>: Add
10141         "tracker" parameter.
10142         * go-exp.y: Update rules.
10143         * f-exp.y: Update rules.
10144         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10145         parameter.
10146         * d-exp.y: Update rules.
10147         * c-exp.y: Update rules.
10148         * breakpoint.c (set_breakpoint_condition): Create an
10149         innermost_block_tracker.
10150         (watch_command_1): Likewise.
10151         * ada-lang.c (resolve): Add "tracker" parameter.
10152         (resolve_subexp): Likewise.
10153         * ada-exp.y (write_var_from_sym): Update.
10154
10155 2019-04-04  Tom Tromey  <tom@tromey.com>
10156
10157         * type-stack.h: New file.
10158         * type-stack.c: New file.
10159         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10160         type-stack.h.
10161         (insert_into_type_stack, insert_type, push_type, push_type_int)
10162         (insert_type_address_space, pop_type, pop_type_int)
10163         (pop_typelist, pop_type_stack, append_type_stack)
10164         (push_type_stack, get_type_stack, push_typelist)
10165         (follow_type_instance_flags, follow_types): Don't declare.
10166         * parse.c (type_stack): Remove global.
10167         (parse_exp_in_context): Update.
10168         (insert_into_type_stack, insert_type, push_type, push_type_int)
10169         (insert_type_address_space, pop_type, pop_type_int)
10170         (pop_typelist, pop_type_stack, append_type_stack)
10171         (push_type_stack, get_type_stack, push_typelist)
10172         (follow_type_instance_flags, follow_types): Remove (moved to
10173         type-stack.c).
10174         * f-exp.y (type_stack): New global.
10175         Update rules.
10176         (push_kind_type, f_parse): Update.
10177         * d-exp.y (type_stack): New global.
10178         Update rules.
10179         (d_parse): Update.
10180         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10181         Update rules.
10182         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10183         (HFILES_NO_SRCDIR): Add type-stack.h.
10184
10185 2019-04-04  Tom Tromey  <tom@tromey.com>
10186
10187         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10188         (rust_parser::convert_ast_to_expression, rust_parse)
10189         (rust_lex_test_completion, rust_lex_tests): Update.
10190         * parser-defs.h (struct expr_completion_state): New.
10191         (struct parser_state) <parser_state>: Add completion parameter.
10192         <mark_struct_expression, mark_completion_tag>: New methods.
10193         <parse_completion, m_completion_state>: New members.
10194         (prefixify_expression, null_post_parser): Update.
10195         (mark_struct_expression, mark_completion_tag): Don't declare.
10196         * parse.c (parse_completion, expout_last_struct)
10197         (expout_tag_completion_type, expout_completion_name): Remove
10198         globals.
10199         (parser_state::mark_struct_expression)
10200         (parser_state::mark_completion_tag): Now methods.
10201         (prefixify_expression): Add last_struct parameter.
10202         (prefixify_subexp): Likewise.
10203         (parse_exp_1): Update.
10204         (parse_exp_in_context): Add cstate parameter.  Update.
10205         (parse_expression_for_completion): Create an
10206         expr_completion_state.
10207         (null_post_parser): Add "completion" parameter.
10208         * p-exp.y: Update rules.
10209         (yylex): Update.
10210         * language.h (struct language_defn) <la_post_parser>: Add
10211         "completing" parameter.
10212         * go-exp.y: Update rules.
10213         (lex_one_token): Update.
10214         * expression.h (parse_completion): Don't declare.
10215         * d-exp.y: Update rules.
10216         (lex_one_token): Update rules.
10217         * c-exp.y: Update rules.
10218         (lex_one_token): Update.
10219         * ada-lang.c (resolve): Add "parse_completion" parameter.
10220         (resolve_subexp): Likewise.
10221         (ada_resolve_function): Likewise.
10222
10223 2019-04-04  Tom Tromey  <tom@tromey.com>
10224
10225         * parser-defs.h (struct parser_state) <start_arglist,
10226         end_arglist>: New methods.
10227         <arglist_len, m_funcall_chain>: New members.
10228         (arglist_len, start_arglist, end_arglist): Don't declare.
10229         * parse.c (arglist_len, funcall_chain): Remove global.
10230         (start_arglist, end_arglist): Remove functions.
10231         (parse_exp_in_context): Update.
10232         * p-exp.y: Update rules.
10233         * m2-exp.y: Update rules.
10234         * go-exp.y: Update rules.
10235         * f-exp.y: Update rules.
10236         * d-exp.y: Update rules.
10237         * c-exp.y: Update rules.
10238
10239 2019-04-04  Tom Tromey  <tom@tromey.com>
10240
10241         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10242         lex_operator, push_back>: New methods.
10243         Update all rules.
10244         (rust_parser::lex_hex, lex_escape): Rename and update.
10245         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10246         (rust_parser::lex_operator): Rename and update.
10247         (rust_parser::lex_number, rustyylex, rustyyerror)
10248         (rust_lex_test_init, rust_lex_test_sequence)
10249         (rust_lex_test_push_back, rust_lex_tests): Update.
10250         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10251         parameter.
10252         <lexptr, prev_lexptr>: New members.
10253         (lexptr, prev_lexptr): Don't declare.
10254         * parse.c (lexptr, prev_lexptr): Remove globals.
10255         (parse_exp_in_context): Update.
10256         * p-exp.y (yylex, yyerror): Update.
10257         * m2-exp.y (parse_number, yylex, yyerror): Update.
10258         * go-exp.y (lex_one_token, yyerror): Update.
10259         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10260         * d-exp.y (lex_one_token, yyerror): Update.
10261         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10262         (lex_one_token, yyerror): Update.
10263         * ada-lex.l (YY_INPUT): Update.
10264         (rewind_to_char): Update.
10265         * ada-exp.y (yyerror): Update.
10266
10267 2019-04-04  Tom Tromey  <tom@tromey.com>
10268
10269         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10270         * parser-defs.h (struct parser_state) <parser_state>: Add new
10271         parameter.
10272         <comma_terminates>: New member.
10273         (comma_terminates): Don't declare global.
10274         * parse.c (comma_terminates): Remove global.
10275         (parse_exp_in_context): Update.
10276         * p-exp.y (yylex): Update.
10277         * m2-exp.y (yylex): Update.
10278         * go-exp.y (lex_one_token): Update.
10279         * f-exp.y (yylex): Update.
10280         * d-exp.y (lex_one_token): Update.
10281         * c-exp.y (lex_one_token): Update.
10282         * ada-lex.l: Update.
10283
10284 2019-04-04  Tom Tromey  <tom@tromey.com>
10285
10286         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10287         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10288         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10289         * parser-defs.h (paren_depth): Don't declare.
10290         * parse.c (paren_depth): Remove global.
10291         (parse_exp_in_context): Update.
10292         * p-exp.y (paren_depth): New global.
10293         (pascal_parse): Initialize it.
10294         * m2-exp.y (paren_depth): New global.
10295         (m2_parse): Initialize it.
10296         * go-exp.y (paren_depth): New global.
10297         (go_parse): Initialize it.
10298         * f-exp.y (paren_depth): New global.
10299         (f_parse): Initialize it.
10300         * d-exp.y (paren_depth): New global.
10301         (d_parse): Initialize it.
10302         * c-exp.y (paren_depth): New global.
10303         (c_parse): Initialize it.
10304         * ada-lex.l (paren_depth): New global.
10305         (lexer_init): Initialize it.
10306
10307 2019-04-04  Tom Tromey  <tom@tromey.com>
10308
10309         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10310         (rust_parser::convert_ast_to_type)
10311         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10312         * parser-defs.h (struct parser_state) <parser_state>: Add
10313         parameters.  Initialize new members.
10314         <expression_context_block, expression_context_pc>: New members.
10315         * parse.c (expression_context_block, expression_context_pc):
10316         Remove globals.
10317         (parse_exp_in_context): Update.
10318         * p-exp.y: Update all rules.
10319         (yylex): Update.
10320         * m2-exp.y: Update all rules.
10321         (yylex): Update.
10322         * go-exp.y (yylex): Update.
10323         * f-exp.y (yylex): Update.
10324         * d-exp.y: Update all rules.
10325         (yylex): Update.
10326         * c-exp.y: Update all rules.
10327         (lex_one_token, classify_name, yylex, c_parse): Update.
10328         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10329
10330 2019-04-04  Tom Tromey  <tom@tromey.com>
10331
10332         * gdbarch.h, gdbarch.c: Rebuild.
10333         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10334         * stap-probe.h:
10335         (struct stap_parse_info): Replace "parser_state" with
10336         "expr_builder".
10337         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10338         (parser_state): New class.
10339         * parse.c (expr_builder): Rename.
10340         (expr_builder::release): Rename.
10341         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10342         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10343         (write_exp_elt_longcst, write_exp_elt_floatcst)
10344         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10345         (write_exp_string_vector, write_exp_bitstring)
10346         (write_exp_msymbol, mark_struct_expression)
10347         (write_dollar_variable)
10348         (insert_type_address_space, increase_expout_size): Replace
10349         "parser_state" with "expr_builder".
10350         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10351         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10352         "parser_state" with "expr_builder".
10353
10354 2019-04-04  Tom Tromey  <tom@tromey.com>
10355
10356         * rust-exp.y: Replace "parse_language" with method call.
10357         * p-exp.y:
10358         (yylex): Replace "parse_language" with method call.
10359         * m2-exp.y:
10360         (yylex): Replace "parse_language" with method call.
10361         * go-exp.y (classify_name): Replace "parse_language" with method
10362         call.
10363         * f-exp.y (yylex): Replace "parse_language" with method call.
10364         * d-exp.y (lex_one_token): Replace "parse_language" with method
10365         call.
10366         * c-exp.y:
10367         (lex_one_token, classify_name, yylex): Replace "parse_language"
10368         with method call.
10369         * ada-exp.y (find_primitive_type, type_char)
10370         (type_system_address): Replace "parse_language" with method call.
10371
10372 2019-04-04  Tom Tromey  <tom@tromey.com>
10373
10374         * rust-exp.y: Replace "parse_gdbarch" with method call.
10375         * parse.c (write_dollar_variable, insert_type_address_space):
10376         Replace "parse_gdbarch" with method call.
10377         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10378         call.
10379         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10380         call.
10381         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10382         "parse_gdbarch" with method call.
10383         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10384         with method call.
10385         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10386         "parse_gdbarch" with method call.
10387         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10388         "parse_gdbarch" with method call.
10389         * c-exp.y (parse_type, parse_number, classify_name): Replace
10390         "parse_gdbarch" with method call.
10391         * ada-lex.l: Replace "parse_gdbarch" with method call.
10392         * ada-exp.y (parse_type, find_primitive_type, type_char)
10393         (type_system_address): Replace "parse_gdbarch" with method call.
10394
10395 2019-04-04  Tom Tromey  <tom@tromey.com>
10396
10397         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10398         * stap-probe.c (stap_parse_argument): Update.
10399         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10400         initial_size parameter.
10401         * rust-exp.y (rust_lex_tests): Update.
10402         * parse.c (parser_state): Update.
10403         (parse_exp_in_context): Update.
10404         * parser-defs.h (struct parser_state) <parser_state>: Remove
10405         "initial_size" parameter.
10406
10407 2019-04-04  Tom Tromey  <tom@tromey.com>
10408
10409         * parser-defs.h (increase_expout_size): Don't declare.
10410         * parse.c (increase_expout_size): Now static.
10411
10412 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10413
10414         * gnu-nat.c (gnu_nat_target::wait): Fix
10415         target_waitstatus_to_string call.
10416
10417 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10418
10419         * eval.c (evaluate_subexp_standard): Handle internal functions
10420         during Fortran function call handling.
10421
10422 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10423
10424         * NEWS: Mention new internal functions.
10425         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10426         (read_base_type): Use dwarf2_init_complex_target_type.
10427         * value.c (creal_internal_fn): New function.
10428         (cimag_internal_fn): New function.
10429         (_initialize_values): Register new internal functions.
10430
10431 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10432
10433         * infrun.c (stop_all_threads): If debug_infrun, always
10434         trace the wait status after wait_one, using
10435         target_waitstatus_to_string and target_pid_to_str.
10436         (handle_inferior_event): Replace various trace of
10437         wait status kind by a single trace.
10438         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10439         wait status kind image by target_waitstatus_to_string.
10440         * target/waitstatus.c (target_waitstatus_to_string): Fix
10441         obsolete comment.
10442
10443 2019-04-01  Tom Tromey  <tromey@adacore.com>
10444
10445         PR symtab/23331:
10446         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10447
10448 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10449             Pedro Alves  <palves@redhat.com>
10450
10451         * top.c (quit_force): Call 'finalize_values'.
10452         * value.c (finalize_values): New function.
10453         * value.h (finalize_values): Declare.
10454
10455 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10456
10457         * NEWS: Announce $_gdb_major and $_gdb_minor.
10458
10459         * top.c (init_gdb_version_vars): New function.
10460         (gdb_init): Call init_gdb_version_vars.
10461
10462 2019-03-29  Tom Tromey  <tromey@adacore.com>
10463
10464         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10465         help text.  Remove dead code.
10466
10467 2019-03-29  Keith Seitz  <keiths@redhat.com>
10468
10469         From Siddhesh Poyarekar:
10470         * f-lang.h (f77_get_upperbound): Return LONGEST.
10471         (f77_get_lowerbound): Likewise.
10472         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10473         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10474         print them.
10475         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10476         plongest to format print it.
10477         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10478         (f77_get_upperbound): Likewise.
10479         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10480         LOWER_BOUND to LONGEST.
10481         (f77_create_arrayprint_offset_tbl): Likewise.
10482
10483 2019-03-29  Keith Seitz  <keiths@redhat.com>
10484
10485         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10486         %s/pulongest for TYPE_LENGTH instead of %d in format
10487         strings.
10488         * ada-typerint.c (ada_print_type): Likewise.
10489         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10490         * compile/compile-c-support.c (generate_register_struct): Likewise.
10491         * gdbtypes.c (recursive_dump_type): Likewise.
10492         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10493         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10494         instead of %d in format strings.
10495         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10496         to std::min to ULONGEST.
10497         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10498         instead of %d in format strings.
10499         * tracepoint.c (info_scope_command): Likewise.
10500         * typeprint.c (print_offset_data::update)
10501         (print_offset_data::finish): Likewise.
10502         * xtensa-tdep.c (xtensa_store_return_value)
10503         (xtensa_push_dummy_call): Likewise.
10504
10505 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10506
10507         * windows-nat.c (display_selector): Fixed format specifications
10508         for 64-bit Cygwin.
10509
10510 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10511
10512         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10513
10514 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10515
10516         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10517         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10518         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10519         (nios2_linux_init_abi): Install it.
10520
10521 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10522
10523         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10524
10525 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10526
10527         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10528
10529 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10530             Tom Tromey  <tromey@adacore.com>
10531
10532         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10533
10534 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10535
10536         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10537         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10538         method to compute the bounds of range types. Also print "[evaluated]"
10539         if the bounds' values come from a dynamic evaluation.
10540
10541 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10542
10543         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10544         whitespace when pretty printing is on.
10545
10546 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10547
10548         * ppc-linux-nat.c: Add include.
10549
10550 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10551
10552         * NEWS: Mention AArch64 Pointer Authentication.
10553
10554 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10555
10556         * arm-linux-nat.c: Add include.
10557
10558 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10559
10560         * source-cache.c (source_cache::get_source_lines): Re-read
10561         fullname after calling open_source_file.
10562
10563 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10564
10565         * NEWS: Mention TLS support for FreeBSD.
10566
10567 2019-03-25  Tom Tromey  <tromey@adacore.com>
10568
10569         * minsyms.c (BUNCH_SIZE): Update comment.
10570         (~minimal_symbol_reader): Remove old comment.
10571         (compact_minimal_symbols): Update comment.
10572         (minimal_symbol_reader::install): Remove old comment.  Update
10573         other comments.
10574
10575 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10576
10577         * s390-linux-nat.c: Add include.
10578
10579 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10580
10581         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10582         Call linux_get_hwcap.
10583         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10584         Likewise.
10585         (aarch64_linux_get_hwcap): Remove function.
10586         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10587         declaration.
10588         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10589         linux_get_hwcap.
10590         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10591         * linux-tdep.c (linux_get_hwcap): Add function.
10592         (linux_get_hwcap2): Likewise.
10593         * linux-tdep.h (linux_get_hwcap): Add declaration.
10594         (linux_get_hwcap2): Likewise.
10595         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10596         (ppc_linux_get_hwcap2): Likewise.
10597         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10598         linux_get_hwcap.
10599         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10600         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10601         (ppc_linux_nat_target::read_description): Likewise.
10602         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10603         * s390-linux-nat.c: Likewise.
10604         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10605
10606 2019-03-24  Tom Tromey  <tom@tromey.com>
10607
10608         * ada-lang.c (standard_lookup): Simplify initialization.
10609         (ada_lookup_symbol_nonlocal): Simplify return.
10610         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10611         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10612         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10613         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10614         initialization.
10615         * solib.c (solib_global_lookup): Simplify.
10616         * symtab.c (null_block_symbol): Remove.
10617         (symbol_cache_lookup): Simplify returns.
10618         (lookup_language_this): Simplify returns.
10619         (lookup_symbol_aux): Simplify return.
10620         (lookup_local_symbol): Simplify returns.
10621         (lookup_global_symbol_from_objfile): Simplify return.
10622         (lookup_symbol_in_objfile_symtabs)
10623         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10624         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10625         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10626         * cp-namespace.c (cp_lookup_bare_symbol)
10627         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10628         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10629         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10630         (cp_lookup_symbol_via_imports): Simplify initialization.
10631         (find_symbol_in_baseclass): Likewise.
10632         * symtab.h (null_block_symbol): Remove.
10633         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10634         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10635         (d_lookup_symbol_module): Likewise.
10636         (find_symbol_in_baseclass): Simplify initialization.
10637
10638 2019-03-24  Tom Tromey  <tom@tromey.com>
10639
10640         * expression.h: Don't include symtab.h.
10641         (struct block): Forward declare.
10642
10643 2019-03-24  Tom Tromey  <tom@tromey.com>
10644
10645         * c-exp.y (typebase): Remove casts.
10646         * gdbtypes.c (lookup_unsigned_typename, )
10647         (lookup_signed_typename): Remove cast.
10648         * eval.c (parse_to_comma_and_eval): Remove cast.
10649         * parse.c (write_dollar_variable): Remove cast.
10650         * block.h (struct block) <superblock>: Now const.
10651         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10652         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10653         (map_block): Make "block" const.
10654         * symfile.h (struct quick_symbol_functions)
10655         <map_matching_symbols>: Constify block argument to "callback".
10656         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10657         const.
10658         (find_pc_sect_compunit_symtab): Make "b" const.
10659         (find_symbol_at_address): Likewise.
10660         (search_symbols): Likewise.
10661         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10662         (dw2_debug_names_lookup_symbol): Likewise.
10663         (dw2_map_matching_symbols): Update.
10664         * p-valprint.c (pascal_val_print): Remove "block".
10665         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10666         (aux_add_nonlocal_symbols): Make "block" const.
10667         (resolve_subexp): Remove cast.
10668         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10669         const.
10670         (iterate_over_file_blocks): Likewise.
10671         * f-exp.y (%union) <bval>: Remove.
10672         * coffread.c (patch_opaque_types): Make "b" const.
10673         * spu-tdep.c (spu_catch_start): Make "block" const.
10674         * c-valprint.c (print_unpacked_pointer): Remove "block".
10675         * symmisc.c (dump_symtab_1): Make "b" const.
10676         (block_depth): Make "block" const.
10677         * d-exp.y (%union) <bval>: Remove.
10678         * cp-support.h (cp_lookup_rtti_type): Update.
10679         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10680         * psymtab.c (psym_lookup_symbol): Make "block" const.
10681         (maintenance_check_psymtabs): Make "b" const.
10682         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10683         (enumerate_locals, enumerate_args): Update.
10684         * python/py-symtab.c (stpy_global_block): Make "block" const.
10685         (stpy_static_block): Likewise.
10686         * inline-frame.c (block_starting_point_at): Make "new_block"
10687         const.
10688         * block.c (find_block_in_blockvector): Make return type const.
10689         (blockvector_for_pc_sect): Make "b" const.
10690         (find_block_in_blockvector): Make "b" const.
10691
10692 2019-03-23  Tom Tromey  <tom@tromey.com>
10693
10694         * varobj.c (varobj_create): Update.
10695         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10696         * printcmd.c (display_command, do_one_display): Don't reset
10697         innermost_block.
10698         * parser-defs.h (enum innermost_block_tracker_type): Move to
10699         expression.h.
10700         (innermost_block): Update comment.
10701         * parse.c (parse_exp_1): Add tracker_types parameter.
10702         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10703         tracker_types parameter.  Reset innermost_block.
10704         (parse_exp_in_context): Remove.
10705         (parse_expression_for_completion): Update.
10706         * objfiles.c (~objfile): Don't reset expression_context_block or
10707         innermost_block.
10708         * expression.h (enum innermost_block_tracker_type): Move from
10709         parser-defs.h.
10710         (parse_exp_1): Add tracker_types parameter.
10711         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10712         reset innermost_block.
10713
10714 2019-03-23  Tom Tromey  <tom@tromey.com>
10715
10716         * objfiles.h: Include bcache.h.
10717
10718 2019-03-23  Tom Tromey  <tom@tromey.com>
10719
10720         * linespec.c (get_current_search_block): Use
10721         scoped_restore_current_language.
10722         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10723
10724 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10725             Jiong Wang  <jiong.wang@arm.com>
10726
10727         * aarch64-linux-tdep.c
10728         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10729         section.
10730         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10731
10732 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10733             Jiong Wang  <jiong.wang@arm.com>
10734
10735         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10736         instructions.
10737         (aarch64_analyze_prologue_test): Add PACIASP test.
10738         (aarch64_prologue_prev_register): Unmask PC value.
10739
10740 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10741             Jiong Wang  <jiong.wang@arm.com>
10742
10743         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10744         (aarch64_dwarf2_prev_register): Unmask PC value.
10745         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10746         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10747         DW_CFA_AARCH64_negate_ra_state.
10748         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10749
10750 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10751             Jiong Wang  <jiong.wang@arm.com>
10752
10753         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10754         registers.
10755         (aarch64_pseudo_register_name): Likewise.
10756         (aarch64_pseudo_register_type): Likewise.
10757         (aarch64_pseudo_register_reggroup_p): Likewise.
10758         (aarch64_gdbarch_init): Add pauth registers.
10759         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10760         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10761         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10762         (struct gdbarch_tdep): Add regnum for ra_state.
10763
10764 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10765             Jiong Wang  <jiong.wang@arm.com>
10766
10767         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10768
10769 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10770             Jiong Wang  <jiong.wang@arm.com>
10771
10772         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10773         function.
10774         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10775         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10776         (aarch64_gdbarch_init): Add puth registers.
10777         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10778         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10779         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10780
10781 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10782             Jiong Wang  <jiong.wang@arm.com>
10783
10784         * aarch64-linux-nat.c
10785         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10786         * aarch64-linux-tdep.c
10787         (aarch64_linux_core_read_description): Likewise.
10788         (aarch64_linux_get_hwcap): New function.
10789         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10790         (aarch64_linux_get_hwcap): New declaration.
10791
10792 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10793             Jiong Wang  <jiong.wang@arm.com>
10794
10795         * aarch64-linux-nat.c
10796         (aarch64_linux_nat_target::read_description): Add pauth param.
10797         * aarch64-linux-tdep.c
10798         (aarch64_linux_core_read_description): Likewise.
10799         * aarch64-tdep.c (struct target_desc): Add in pauth.
10800         (aarch64_read_description): Add pauth param.
10801         (aarch64_gdbarch_init): Likewise.
10802         * aarch64-tdep.h (aarch64_read_description): Likewise.
10803         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10804         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10805         * features/Makefile: Add new files.
10806         * features/aarch64-pauth.c: New file.
10807         * features/aarch64-pauth.xml: New file.
10808
10809 2019-03-20  Tom Tromey  <tromey@adacore.com>
10810
10811         * infrun.c (handle_inferior_event): Rename from
10812         handle_inferior_event_1.  Create a scoped_value_mark.
10813         (handle_inferior_event): Remove.
10814
10815 2019-03-19  Tom Tromey  <tromey@adacore.com>
10816
10817         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10818         * infrun.h (print_stop_event): Add "displays" parameter.
10819         * infrun.c (print_stop_event): Add "displays" parameter.
10820
10821 2019-03-19  Pedro Alves  <palves@redhat.com>
10822
10823         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10824         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10825         to -1.  Fix TABs vs spaces.
10826         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10827         * tui/tui-out.h (tui_ui_out) Add intro comments.
10828         <m_line, m_start_of_line>: In-class initialize, and add describing
10829         comment.
10830
10831 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10832
10833         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10834         variable names.
10835         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10836
10837 2019-03-18  Pedro Alves  <palves@redhat.com>
10838             Eli Zaretskii <eliz@gnu.org>
10839
10840         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10841         m_line and m_start_of_line.
10842
10843 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10844
10845         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10846         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10847         it returns a newline.  This fixes a regression in TU mode, whereby
10848         the next line is output on the same screen line as the user input.
10849
10850 2019-03-18  Tom Tromey  <tromey@adacore.com>
10851
10852         * minsyms.c (minimal_symbol_reader::install): Remove call to
10853         obstack_blank.
10854
10855 2019-03-18  Pedro Alves  <palves@redhat.com>
10856
10857         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10858         New globals.
10859         (apply_style): New, factored out from ...
10860         (apply_ansi_escape): ... this.  Handle reverse video mode.
10861         (tui_set_reverse_mode): New function.
10862         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10863         * tui/tui-winsource.c (tui_show_source_line): Use
10864         tui_set_reverse_mode instead of setting A_STANDOUT.
10865         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10866         New setter methods.
10867
10868 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10869
10870         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10871         Handle tabs.
10872
10873 2019-03-18  Tom Tromey  <tromey@adacore.com>
10874
10875         * ada-lang.c (empty_array): Add "high" parameter.
10876         (ada_evaluate_subexp): Update.
10877
10878 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10879
10880         * unittests/string_view-selftests.c: Define
10881         _initialize_string_view_selftests unconditionally.
10882
10883 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10884
10885         PR gdb/24350
10886         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10887
10888 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10889
10890         PR gdb/24351
10891         * windows-nat.c (display_selector): Fix format specifiers.
10892
10893 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10894
10895         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10896         tui_refill_source_window instead of tui_refresh_win, to update the
10897         current execution line.  This fixes redisplay of the current line
10898         when stepping through the code with "next" or "step".
10899
10900 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10901
10902         * source-cache.c (source_cache::get_source_lines): Call
10903         find_source_lines to initialize s->nlines.  This fixes vertical
10904         scrolling of TUI source window when the DOWN arrow is pressed.
10905
10906 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10907
10908         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10909         linux-thread-db.c (_initialize_thread_db): Likewise.
10910
10911 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10912
10913         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10914         wclrtoeol in tui_show_source_line".  This reverts changes made in
10915         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10916
10917 2019-03-15  Tom Tromey  <tom@tromey.com>
10918
10919         * symtab.h (struct minimal_symbol): Derive from
10920         general_symbol_info.
10921         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10922         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10923         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10924         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10925         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10926         (MSYMBOL_SEARCH_NAME): Update.
10927         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10928         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10929         * minsyms.c (minimal_symbol_reader::record_full): Update.
10930
10931 2019-03-15  Tom Tromey  <tom@tromey.com>
10932
10933         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10934
10935 2019-03-15  Tom Tromey  <tom@tromey.com>
10936
10937         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10938         unique_xmalloc_ptr.
10939         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10940         Update.
10941         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10942         (build_minimal_symbol_hash_tables)
10943         (minimal_symbol_reader::install): Update.
10944
10945 2019-03-15  Tom Tromey  <tom@tromey.com>
10946
10947         * symtab.c (create_demangled_names_hash): Update.
10948         (symbol_set_names): Update.
10949         * objfiles.h (struct objfile_per_bfd_storage)
10950         <demangled_names_hash>: Now an htab_up.
10951         * objfiles.c (objfile_per_bfd_storage): Simplify.
10952
10953 2019-03-15  Tom Tromey  <tom@tromey.com>
10954
10955         * objfiles.h (struct objfile_per_bfd_storage): Declare
10956         destructor.
10957         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10958         New.
10959         (get_objfile_bfd_data): Use new.  Don't initialize
10960         language_of_main.
10961         (free_objfile_per_bfd_storage): Remove.
10962         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10963
10964 2019-03-15  Tom Tromey  <tom@tromey.com>
10965
10966         * symfile.c (reread_symbols): Update.
10967         * objfiles.c (objfile::objfile): Update.
10968         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10969         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10970         comment.
10971         (minimal_symbol_reader::install): Update.
10972         (terminate_minimal_symbol_table): Remove.
10973         * jit.c (jit_object_close_impl): Update.
10974
10975 2019-03-15  Tom Tromey  <tom@tromey.com>
10976
10977         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10978         initializations.
10979
10980 2019-03-15  Tom Tromey  <tom@tromey.com>
10981
10982         * objfiles.h (struct objfile_per_bfd_storage)
10983         <demangled_hash_languages>: Now a bitset.
10984         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10985         (lookup_minimal_symbol): Update.
10986
10987 2019-03-15  Tom Tromey  <tom@tromey.com>
10988
10989         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10990         Don't return the symbol.
10991         * coffread.c (record_minimal_symbol): Use record_full.
10992
10993 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10994
10995         The MS-Windows port of ncurses fails to switch to a color pair if
10996         one or both of the colors are the implicit default colors.  This
10997         change records the default colors when TUI is initialized, and
10998         then specifies them explicitly when a color pair uses the default
10999         colors.  This allows color styling in TUI mode on MS-Windows.
11000
11001         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11002         ncurses_norm_attr.
11003         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11004         colors in ncurses_norm_attr.
11005         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11006         "none", replace it with the default color recorded in
11007         ncurses_norm_attr.
11008
11009 2019-03-14  Tom Tromey  <tromey@adacore.com>
11010
11011         * source-cache.h (class source_cache) <get_source_lines>: Return
11012         std::string.
11013         * source-cache.c (source_cache::extract_lines): Handle case where
11014         first_pos==npos.  Return std::string.
11015         (source_cache::get_source_lines): Update.
11016
11017 2019-03-14  Tom Tromey  <tromey@adacore.com>
11018
11019         * NEWS: Add item for "style sources" commands.
11020         * source-cache.c (source_cache::get_source_lines): Check
11021         source_styling.
11022         * cli/cli-style.c (source_styling): New global.
11023         (_initialize_cli_style): Add "style sources" commands.
11024         (show_style_sources): New function.
11025         * cli/cli-style.h (source_styling): Declare.
11026
11027 2019-03-14  Pedro Alves  <palves@redhat.com>
11028             Tom Tromey  <tromey@adacore.com>
11029
11030         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11031         * tui/tui-winsource.c (tui_refill_source_window): New function,
11032         from...
11033         (tui_horizontal_source_scroll): ... here.  Move some logic.
11034         * cli/cli-style.c (set_style_enabled): Notify new observable.
11035         * tui/tui-hooks.c (tui_redisplay_source): New function.
11036         (tui_attach_detach_observers): Attach or detach
11037         tui_redisplay_source.
11038         * observable.h (source_styling_changed): New observable.
11039         * observable.c: Define source_styling_changed observable.
11040
11041 2019-03-13  Tom Tromey  <tromey@adacore.com>
11042
11043         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11044         (i386_gnu_nat_target::store_registers): Update.
11045         * target-debug.h (target_debug_print_std_string): New macro.
11046         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11047         * windows-tdep.c (display_one_tib): Update.
11048         * tui/tui-stack.c (tui_make_status_line): Update.
11049         * top.c (print_inferior_quit_action): Update.
11050         * thread.c (thr_try_catch_cmd): Update.
11051         (add_thread_with_info): Update.
11052         (thread_target_id_str): Update.
11053         (thr_try_catch_cmd): Update.
11054         (thread_command): Update.
11055         (thread_find_command): Update.
11056         * record-btrace.c (record_btrace_target::info_record)
11057         (record_btrace_resume_thread, record_btrace_target::resume)
11058         (record_btrace_cancel_resume, record_btrace_step_thread)
11059         (record_btrace_target::wait, record_btrace_target::wait)
11060         (record_btrace_target::wait, record_btrace_target::stop): Update.
11061         * progspace.c (print_program_space): Update.
11062         * process-stratum-target.c
11063         (process_stratum_target::thread_address_space): Update.
11064         * linux-fork.c (linux_fork_mourn_inferior)
11065         (detach_checkpoint_command, info_checkpoints_command)
11066         (linux_fork_context): Update.
11067         (linux_fork_detach): Update.
11068         (class scoped_switch_fork_info): Update.
11069         (delete_checkpoint_command): Update.
11070         * infrun.c (follow_fork_inferior): Update.
11071         (follow_fork_inferior): Update.
11072         (proceed_after_vfork_done): Update.
11073         (handle_vfork_child_exec_or_exit): Update.
11074         (follow_exec): Update.
11075         (displaced_step_prepare_throw): Update.
11076         (displaced_step_restore): Update.
11077         (start_step_over): Update.
11078         (resume_1): Update.
11079         (clear_proceed_status_thread): Update.
11080         (proceed): Update.
11081         (print_target_wait_results): Update.
11082         (do_target_wait): Update.
11083         (context_switch): Update.
11084         (stop_all_threads): Update.
11085         (restart_threads): Update.
11086         (finish_step_over): Update.
11087         (handle_signal_stop): Update.
11088         (switch_back_to_stepped_thread): Update.
11089         (keep_going_pass_signal): Update.
11090         (print_exited_reason): Update.
11091         (normal_stop): Update.
11092         * inferior.c (inferior_pid_to_str): Change return type.
11093         (print_selected_inferior): Update.
11094         (add_inferior): Update.
11095         (detach_inferior): Update.
11096         * dummy-frame.c (fprint_dummy_frames): Update.
11097         * dcache.c (dcache_info_1): Update.
11098         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11099         (btrace_fetch, btrace_clear): Update.
11100         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11101         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11102         type.
11103         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11104         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11105         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11106         * gdbarch.c, gdbarch.h: Rebuild.
11107         * gdbarch.sh (core_pid_to_str): Change return type.
11108         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11109         return type.
11110         (windows_nat_target::pid_to_str): Change return type.
11111         (windows_delete_thread): Update.
11112         (windows_nat_target::attach): Update.
11113         (windows_nat_target::files_info): Update.
11114         * target-delegates.c: Rebuild.
11115         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11116         return type.
11117         (sol_thread_target::pid_to_str): Change return type.
11118         * remote.c (class remote_target) <pid_to_str>: Change return
11119         type.
11120         (remote_target::pid_to_str): Change return type.
11121         (extended_remote_target::attach, remote_target::remote_stop_ns)
11122         (remote_target::remote_notif_remove_queued_reply)
11123         (remote_target::push_stop_reply, remote_target::disable_btrace):
11124         Update.
11125         (extended_remote_target::attach): Update.
11126         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11127         type.
11128         (gdbsim_target::pid_to_str): Change return type.
11129         * ravenscar-thread.c (struct ravenscar_thread_target)
11130         <pid_to_str>: Change return type.
11131         (ravenscar_thread_target::pid_to_str): Change return type.
11132         * procfs.c (class procfs_target) <pid_to_str>: Change return
11133         type.
11134         (procfs_target::pid_to_str): Change return type.
11135         (procfs_target::attach): Update.
11136         (procfs_target::detach): Update.
11137         (procfs_target::fetch_registers): Update.
11138         (procfs_target::store_registers): Update.
11139         (procfs_target::wait): Update.
11140         (procfs_target::files_info): Update.
11141         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11142         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11143         return type.
11144         (nto_procfs_target::pid_to_str): Change return type.
11145         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11146         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11147         return type.
11148         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11149         (exit_lwp): Update.
11150         (attach_proc_task_lwp_callback, get_detach_signal)
11151         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11152         (linux_nat_target::resume, wait_lwp, stop_callback)
11153         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11154         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11155         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11156         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11157         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11158         type.
11159         (inf_ptrace_target::attach): Update.
11160         (inf_ptrace_target::files_info): Update.
11161         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11162         type.
11163         (go32_nat_target::pid_to_str): Change return type.
11164         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11165         (gnu_nat_target::wait): Update.
11166         (gnu_nat_target::wait): Update.
11167         (gnu_nat_target::resume): Update.
11168         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11169         (fbsd_nat_target::wait): Update.
11170         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11171         type.
11172         (darwin_nat_target::attach): Update.
11173         * corelow.c (class core_target) <pid_to_str>: Change return type.
11174         (core_target::pid_to_str): Change return type.
11175         * target.c (normal_pid_to_str): Change return type.
11176         (default_pid_to_str): Likewise.
11177         (target_pid_to_str): Change return type.
11178         (target_translate_tls_address): Update.
11179         (target_announce_detach): Update.
11180         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11181         return type.
11182         (bsd_uthread_target::pid_to_str): Change return type.
11183         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11184         type.
11185         (bsd_kvm_target::pid_to_str): Change return type.
11186         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11187         return type.
11188         (aix_thread_target::pid_to_str): Change return type.
11189         * target.h (struct target_ops) <pid_to_str>: Change return type.
11190         (target_pid_to_str, normal_pid_to_str): Likewise.
11191         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11192         type.
11193         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11194         type.
11195         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11196         return type.
11197         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11198         type.
11199         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11200         type.
11201         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11202         return type.
11203
11204 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11205
11206         * NEWS: Mention that the new default MI version is 3.  Mention
11207         changes to the output of commands and events that deal with
11208         multi-location breakpoints.
11209         * breakpoint.c: Include "mi/mi-out.h".
11210         (print_one_breakpoint): Change output syntax if using MI version
11211         >= 3.
11212         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11213         New.
11214         (mi_multi_location_breakpoint_output_fixed): New.
11215         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11216         (mi_cmd_fix_multi_location_breakpoint_output): New.
11217         (mi_multi_location_breakpoint_output_fixed): New.
11218         * mi/mi-cmds.c (mi_cmds): Register command
11219         -fix-multi-location-breakpoint-output.
11220         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11221         interpreter "mi".
11222
11223 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11224
11225         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11226         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11227         instantiate mi_ui_out based on interpreter name.
11228         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11229         * mi/mi-main.c (mi_load_progress): Likewise.
11230
11231 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11232
11233         * NEWS: Combine separate "New targets" sections for 8.3.
11234
11235 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11236
11237         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11238         (ppcfbsd_init_abi): Install gdbarch
11239         "fetch_tls_load_module_address" and "get_thread_local_address"
11240         methods.
11241
11242 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11243
11244         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11245         (riscv_fbsd_init_abi): Install gdbarch
11246         "fetch_tls_load_module_address" and "get_thread_local_address"
11247         methods.
11248
11249 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11250
11251         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11252         (i386fbsd_init_abi): Install gdbarch
11253         "fetch_tls_load_module_address" and "get_thread_local_address"
11254         methods.
11255
11256 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11257
11258         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11259         (amd64fbsd_init_abi): Install gdbarch
11260         "fetch_tls_load_module_address" and "get_thread_local_address"
11261         methods.
11262
11263 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11264
11265         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11266         (struct fbsd_pspace_data): New type.
11267         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11268         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11269         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11270         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11271         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11272
11273 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11274
11275         * gdbtypes.c (lookup_struct_elt): New function.
11276         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11277         * gdbtypes.h (struct struct_elt): New type.
11278         (lookup_struct_elt): New prototype.
11279
11280 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11281
11282         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11283         remove disabled code block.
11284
11285 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11286
11287         * gdbarch.sh (get_thread_local_address): New method.
11288         * gdbarch.h, gdbarch.c: Regenerate.
11289         * target.c (target_translate_tls_address): Use
11290         gdbarch_get_thread_local_address if present instead of
11291         target::get_thread_local_address.
11292
11293 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11294
11295         * target.h (target::get_thread_local_address): Update comment.
11296
11297 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11298
11299         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11300         objfile->separate_debug_objfile_backlink if not NULL.
11301
11302 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11303
11304         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11305         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11306         (amd64bsd_store_inferior_registers): Likewise.
11307         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11308         Enable segment base registers.
11309         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11310         PT_GETFSBASE and PT_GETGSBASE.
11311         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11312         PT_SETGSBASE.
11313         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11314         segment base registers.
11315         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11316
11317 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11318
11319         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11320         Update calls to i386_target_description to add 'segments'
11321         parameter.
11322         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11323         add segment base registers.
11324         * arch/i386.c (i386_create_target_description): Add 'segments'
11325         parameter to enable segment base registers.
11326         * arch/i386.h (i386_create_target_description): Likewise.
11327         * features/i386/32bit-segments.xml: New file.
11328         * features/i386/32bit-segments.c: Generate.
11329         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11330         call to i386_target_description to add 'segments' parameter.
11331         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11332         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11333         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11334         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11335         if feature is present.
11336         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11337         Add 'segments' parameter to call to i386_target_description.
11338         (i386_target_description): Add 'segments' parameter to enable
11339         segment base registers.
11340         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11341         to call to i386_target_description.
11342         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11343         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11344         Define I386_NUM_REGS.
11345         (i386_target_description): Add 'segments' parameter to enable
11346         segment base registers.
11347
11348 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11349
11350         PR/24325
11351         * source-cache.c: #undef open and close, to avoid unresolved
11352         externals during linking.
11353
11354 2019-03-12  Tom Tromey  <tromey@adacore.com>
11355
11356         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11357         const.  Add initializers.
11358         (_initialize_remote): Don't initialize ptid globals.
11359
11360 2019-03-12  Pedro Alves  <palves@redhat.com>
11361
11362         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11363
11364 2019-03-12  Pedro Alves  <palves@redhat.com>
11365
11366         * cp-name-parser.y (main): Remove unused 'len' variable.
11367
11368 2019-03-12  Tom Tromey  <tromey@adacore.com>
11369
11370         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11371         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11372
11373 2019-03-12  Tom Tromey  <tromey@adacore.com>
11374
11375         * linux-nat.c (iterate_over_lwps): Update.
11376         (stop_callback): Remove parameter.
11377         (stop_wait_callback, detach_callback, resume_set_callback)
11378         (select_singlestep_lwp_callback, set_ignore_sigint)
11379         (status_callback, resumed_callback, resume_clear_callback)
11380         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11381         data parameter.
11382         (linux_nat_target::detach, linux_nat_target::resume)
11383         (linux_stop_and_wait_all_lwps, select_event_lwp)
11384         (linux_nat_filter_event, linux_nat_wait_1)
11385         (linux_nat_target::kill, linux_nat_target::stop)
11386         (linux_nat_target::stop): Update.
11387         (linux_nat_resume_callback): Change type.
11388         (resume_stopped_resumed_lwps, count_events_callback)
11389         (select_event_lwp_callback): Likewise.
11390         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11391         * arm-linux-nat.c (struct update_registers_data): Remove.
11392         (update_registers_callback): Change type.
11393         (arm_linux_insert_hw_breakpoint1): Update.
11394         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11395         parameter.
11396         (x86_linux_dr_set_addr): Update.
11397         (x86_linux_dr_set_control): Update.
11398         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11399         (iterate_over_lwps): Use gdb::function_view.
11400         * nat/aarch64-linux-hw-point.c (struct
11401         aarch64_dr_update_callback_param): Remove.
11402         (debug_reg_change_callback): Change type.
11403         (aarch64_notify_debug_reg_change): Update.
11404         * s390-linux-nat.c (s390_refresh_per_info): Update.
11405
11406 2019-03-11  Tom Tromey  <tromey@adacore.com>
11407
11408         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11409         redundant assignment to "this_cu".
11410
11411 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11412
11413         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11414
11415 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11416
11417         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11418         from...
11419         (rank_one_type): ... this.
11420
11421 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11422
11423         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11424         from...
11425         (rank_one_type): ... this.
11426
11427 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11428
11429         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11430         from...
11431         (rank_one_type): ... this.
11432
11433 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11434
11435         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11436         from...
11437         (rank_one_type): ... this.
11438
11439 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11440
11441         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11442         from...
11443         (rank_one_type): ... this.
11444
11445 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11446
11447         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11448         from...
11449         (rank_one_type): ... this.
11450
11451 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11452
11453         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11454         from...
11455         (rank_one_type): ... this.
11456
11457 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11458
11459         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11460         from...
11461         (rank_one_type): ... this.
11462
11463 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11464
11465         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11466         from...
11467         (rank_one_type): ... this.
11468
11469 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11470
11471         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11472         from...
11473         (rank_one_type): ... this.
11474
11475 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11476
11477         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11478         from...
11479         (rank_one_type): ... this.
11480
11481 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11482
11483         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11484         from...
11485         (rank_one_type): ... this.
11486
11487 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11488
11489         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11490         inferior-events' shows the example events.
11491
11492 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11493
11494         Support styling on native MS-Windows console
11495
11496         PR/24315
11497         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11498         on MS-Windows if $TERM is not defined.
11499
11500         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11501
11502         * posix-hdep.c (gdb_console_fputs):
11503         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11504         functions.
11505         * ui-file.h (gdb_console_fputs): Add prototype.
11506
11507         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11508         back to fputs only if the former returns zero.
11509
11510 2019-03-07  Tom Tromey  <tom@tromey.com>
11511
11512         * symmisc.c (print_symbol_bcache_statistics): Update.
11513         (print_objfile_statistics): Update.
11514         * symfile.c (allocate_symtab): Update.
11515         * stabsread.c: Don't include bcache.h.
11516         * psymtab.h (struct psymbol_bcache): Don't declare.
11517         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11518         (psymbol_bcache_init, psymbol_bcache_free)
11519         (psymbol_bcache_get_bcache): Don't declare.
11520         * psymtab.c (struct psymbol_bcache): Remove.
11521         (psymtab_storage::psymtab_storage): Update.
11522         (psymtab_storage::~psymtab_storage): Update.
11523         (psymbol_bcache_init, psymbol_bcache_free)
11524         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11525         (add_psymbol_to_bcache): Update.
11526         (allocate_psymtab): Update.
11527         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11528         macro_cache>: No longer pointers.
11529         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11530         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11531         * macrotab.c (macro_bcache): Update.
11532         * macroexp.c: Don't include bcache.h.
11533         * gdbtypes.c (check_types_worklist): Update.
11534         (types_deeply_equal): Remove TRY/CATCH.  Update.
11535         * elfread.c (elf_symtab_read): Update.
11536         * dwarf2read.c: Don't include bcache.h.
11537         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11538         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11539         (print_bcache_statistics, bcache_memory_used): Don't declare.
11540         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11541         methods.  Rename all data members.
11542         * bcache.c (struct bcache): Move to bcache.h.
11543         (bcache::expand_hash_table): Rename from expand_hash_table.
11544         (bcache): Remove.
11545         (bcache::insert): Rename from bcache_full.
11546         (bcache::compare): Rename from bcache_compare.
11547         (bcache_xmalloc): Remove.
11548         (bcache::~bcache): Rename from bcache_xfree.
11549         (bcache::print_statistics): Rename from print_bcache_statistics.
11550         (bcache::memory_used): Rename from bcache_memory_used.
11551
11552 2019-03-07  Pedro Alves  <palves@redhat.com>
11553
11554         * infrun.c (normal_stop): Also check for
11555         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11556
11557 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11558
11559         * f-lang.c (value_from_host_double): Moved to...
11560         * value.c (value_from_host_double): ...here.
11561         * value.h (value_from_host_double): Declare.
11562         * guile/scm-math.c (vlscm_convert_typed_number): Use
11563         value_from_host_double.
11564         (vlscm_convert_number): Likewise.
11565         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11566         * python/py-value.c (convert_value_from_python): Likewise.
11567
11568 2019-03-06  Tom Tromey  <tom@tromey.com>
11569
11570         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11571
11572 2019-03-06  Tom Tromey  <tom@tromey.com>
11573
11574         * utils.h (free_current_contents): Don't declare.
11575         * utils.c (free_current_contents): Remove.
11576
11577 2019-03-06  Tom Tromey  <tom@tromey.com>
11578
11579         * top.c (quit_force): Update.
11580         * main.c (captured_command_loop): Update.
11581         * common/new-op.c (operator new): Update.
11582         * common/common-exceptions.c (struct catcher)
11583         <save_cleanup_chain>: Remove member.
11584         (exceptions_state_mc_init): Update.
11585         (exception_try_scope_entry): Return nullptr.
11586         (exception_try_scope_exit, exception_rethrow)
11587         (throw_exception_sjlj, throw_exception_cxx): Update.
11588         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11589         (all_cleanups, do_cleanups, discard_cleanups)
11590         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11591         (restore_cleanups, restore_final_cleanups): Don't declare.
11592         (do_final_cleanups): Remove parameter.
11593         * common/cleanups.c (cleanup_chain, make_cleanup)
11594         (make_cleanup_dtor, all_cleanups, do_cleanups)
11595         (discard_my_cleanups, discard_cleanups)
11596         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11597         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11598         (null_cleanup): Remove.
11599         (do_final_cleanups): Remove parameter.
11600
11601 2019-03-06  Tom Tromey  <tom@tromey.com>
11602
11603         * remote.c (remote_target::remote_parse_stop_reply): Use
11604         unique_xmalloc_ptr.
11605
11606 2019-03-06  Tom Tromey  <tom@tromey.com>
11607
11608         * stabsread.c (struct stabs_field_info): Rename from field_info.
11609         <list, fnlist>: Add initializers.
11610         <obstack>: New member.
11611         (read_member_functions, read_struct_fields, read_baseclasses):
11612         Allocate on obstack.  Don't use cleanups.
11613         (read_one_struct_field, read_member_functions, read_struct_fields)
11614         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11615         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11616         (read_struct_type): Update.
11617
11618 2019-03-06  Tom Tromey  <tom@tromey.com>
11619
11620         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11621         * common/filestuff.h (make_cleanup_close): Don't declare.
11622         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11623         Remove.
11624
11625 2019-03-06  Tom Tromey  <tom@tromey.com>
11626
11627         * solib-aix.c: Use make_scope_exit.
11628
11629 2019-03-06  Tom Tromey  <tom@tromey.com>
11630
11631         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11632         Use make_scope_exit.
11633
11634 2019-03-06  Tom Tromey  <tom@tromey.com>
11635
11636         * solib-svr4.c (disable_probes_interface): Remove parameter.
11637         (svr4_handle_solib_event): Use make_scope_exit.
11638
11639 2019-03-06  Tom Tromey  <tom@tromey.com>
11640
11641         * remote.c (struct stop_reply_deleter): Remove.
11642         (stop_reply_up): Update.
11643         (struct stop_reply): Derive from notif_event.  Don't typedef.
11644         <regcache>: Now a std::vector.
11645         (stop_reply_xfree): Remove.
11646         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11647         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11648         (remote_target::discard_pending_stop_replies): Use delete.
11649         (remote_target::remote_parse_stop_reply): Update.
11650         (remote_target::process_stop_reply): Update.
11651         * remote-notif.h (struct notif_event): Add virtual destructor.
11652         Remove "dtr" member.
11653         (struct notif_client) <alloc_event>: Return a unique_ptr.
11654         (notif_event_xfree): Don't declare.
11655         (notif_event_up): New typedef.
11656         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11657         (notif_event_xfree, do_notif_event_xfree): Remove.
11658         (remote_notif_state_xfree): Update.
11659
11660 2019-03-06  Tom Tromey  <tom@tromey.com>
11661
11662         * infrun.c (displaced_step_clear_cleanup): Now a
11663         forward_scope_exit type.
11664         (displaced_step_prepare_throw): Update.
11665         (displaced_step_fixup): Update.
11666
11667 2019-03-06  Tom Tromey  <tom@tromey.com>
11668
11669         * inferior.h (class inferior): Update comment.
11670         * gdbthread.h (class thread_info): Update comment.
11671
11672 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11673             Tom Tromey  <tom@tromey.com>
11674
11675         * stabsread.h (struct stab_section_list): Remove.
11676         (coffstab_build_psymtabs): Update.
11677         * dbxread.c (symbuf_sections): Now a std::vector.
11678         (sect_idx): New global.
11679         (fill_symbuf): Update.
11680         (coffstab_build_psymtabs): Change type of stabsects parameter.
11681         Update.
11682         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11683         std::vector.
11684         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11685         (coff_locate_sections): Update.
11686         (coff_symfile_read): Remove cleanups.  Update.
11687         (init_stringtab): Add storage parameter.
11688         (free_stringtab, free_stringtab_cleanup): Remove.
11689         (init_lineno): Add storage parameter.
11690         (free_linetab, free_linetab_cleanup): Remove.
11691
11692 2019-03-06  Pedro Alves  <palves@redhat.com>
11693
11694         * linux-fork.c (fork_info::clobber_regs): Delete.
11695         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11696         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11697         comment.  Adjust.
11698         (scoped_switch_fork_info::scoped_switch_fork_info)
11699         (checkpoint_command, linux_fork_context): Adjust
11700         fork_save_infrun_state calls.
11701
11702 2019-03-06  Pedro Alves  <palves@redhat.com>
11703
11704         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11705         (inf_has_multiple_threads): Return 'bool' and rewrite using
11706         inferior_info::threads().
11707
11708 2019-03-06  Pedro Alves  <palves@redhat.com>
11709
11710         * linux-fork.c: Include <list>.
11711         (fork_list): Now a std::list instance.
11712         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11713         (forks_exist_p, find_last_fork): Adjust.
11714         (new_fork): Delete.
11715         (one_fork_p): New.
11716         (add_fork): Adjust.
11717         (free_fork): Delete, folded into fork_info::~fork_info().
11718         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11719         Adjust.
11720         (init_fork_list): Delete.
11721         (linux_fork_killall, linux_fork_mourn_inferior)
11722         (linux_fork_detach, info_checkpoints_command): Adjust.
11723         (_initialize_linux_fork): No longer call init_fork_list.
11724
11725 2019-03-06  Pedro Alves  <palves@redhat.com>
11726
11727         * linux-fork.c (new_fork): New, split out of ...
11728         (add_fork): ... this.  Return void.  Move "first fork" special
11729         case from here, to ...
11730         (checkpoint_command): ... here.
11731         * linux-linux.h (add_fork): Return void.
11732
11733 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11734
11735         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11736
11737 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11738             Chris January  <chris.january@arm.com>
11739             David Lecomber  <david.lecomber@arm.com>
11740
11741         * f-exp.y: New token, UNOP_INTRINSIC.
11742         (exp): New pattern using UNOP_INTRINSIC token.
11743         (f77_keywords): Add 'abs' keyword.
11744         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11745         (value_from_host_double): New function.
11746         (evaluate_subexp_f): Support UNOP_ABS.
11747
11748 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11749
11750         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11751         types.
11752
11753 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11754
11755         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11756         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11757         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11758
11759 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11760
11761         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11762
11763 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11764             Chris January  <chris.january@arm.com>
11765
11766         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11767         * f-exp.y: Define 'KIND' token.
11768         (exp): New pattern for KIND expressions.
11769         (ptype): Handle types with a kind extension.
11770         (direct_abs_decl): Extend to spot kind extensions.
11771         (f77_keywords): Add 'kind' to the list.
11772         (push_kind_type): New function.
11773         (convert_to_kind_type): New function.
11774         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11775         * parse.c (operator_length_standard): Likewise.
11776         * parser-defs.h (enum type_pieces): Add tp_kind.
11777         * std-operator.def: Add UNOP_KIND.
11778
11779 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11780
11781         * f-exp.y (f_parse): Set yydebug.
11782
11783 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11784
11785         * f-lang.c (evaluate_subexp_f): New function.
11786         (exp_descriptor_f): New global.
11787         (f_language_defn): Use exp_descriptor_f instead of
11788         exp_descriptor_standard.
11789
11790 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11791
11792         * f-exp.y (struct token): Add comments.
11793         (dot_ops): Remove uppercase versions and the end marker.
11794         (f77_keywords): Likewise.
11795         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11796         entries in the dot_ops array are case insensitive, and use
11797         strncasecmp to compare strings.  Also some whitespace cleanup in
11798         this area.  Similar for the f77_keywords array, except entries in
11799         this list might be case sensitive.
11800
11801 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11802
11803         * f-exp.y (struct f77_boolean_val): Add comments.
11804         (boolean_values): Remove uppercase versions, and end marker.
11805         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11806         and use strncasecmp to achieve case insensitivity.  Additionally,
11807         perform whitespace cleanup around this code.
11808
11809 2019-03-06  Tom Tromey  <tromey@adacore.com>
11810
11811         * remote-sim.c (gdbsim_target_open): Use result of
11812         gdb_argv::release.
11813
11814 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11815         Dirk Schubert  <dirk.schubert@arm.com>
11816         Chris January  <chris.january@arm.com>
11817
11818         * eval.c (evaluate_subexp_standard): Call Fortran argument
11819         wrapping logic.
11820         * f-lang.c (struct value): A value which can be passed into a
11821         Fortran function call.
11822         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11823         where appropriate.
11824         (struct type): Value ready for a Fortran function call.
11825         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11826         is needed.
11827         * f-lang.h (fortran_argument_convert): Declaration.
11828         (fortran_preserve_arg_pointer): Declaration.
11829         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11830
11831 2019-03-05  Tom Tromey  <tromey@adacore.com>
11832
11833         * python/py-prettyprint.c (print_string_repr): Remove #if.
11834         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11835
11836 2019-03-05  Tom Tromey  <tromey@adacore.com>
11837
11838         * target.c (the_dummy_target): Move later.  Change type to
11839         "dummy_target".
11840         (initialize_targets): Don't initialize the_dummy_target.
11841
11842 2019-03-05  Tom Tromey  <tromey@adacore.com>
11843
11844         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11845         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11846
11847 2019-03-05  Tom Tromey  <tromey@adacore.com>
11848
11849         * windows-nat.c (windows_nat_target::attach)
11850         (windows_nat_target::detach): Don't call gdb_flush.
11851         * valprint.c (generic_val_print, val_print, val_print_string):
11852         Don't call gdb_flush.
11853         * utils.c (defaulted_query): Don't call gdb_flush.
11854         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11855         * target.c (target_announce_detach): Don't call gdb_flush.
11856         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11857         * remote.c (extended_remote_target::attach): Don't call
11858         gdb_flush.
11859         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11860         * printcmd.c (do_examine): Don't call gdb_flush.
11861         (info_display_command): Don't call gdb_flush.
11862         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11863         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11864         * memattr.c (info_mem_command): Don't call gdb_flush.
11865         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11866         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11867         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11868         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11869         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11870         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11871         (gnu_nat_target::detach): Don't call gdb_flush.
11872         * f-valprint.c (f_val_print): Don't call gdb_flush.
11873         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11874         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11875         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11876         gdb_flush.
11877         * c-valprint.c (c_val_print): Don't call gdb_flush.
11878         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11879
11880 2019-03-05  Tom Tromey  <tromey@adacore.com>
11881
11882         * varobj.c (update_dynamic_varobj_children): Update.
11883         (install_default_visualizer): Use reset, not release.
11884         * value.c (set_internalvar): Update.
11885         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11886         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11887         ATTRIBUTE_UNUSED_RESULT.
11888
11889 2019-03-05  Tom Tromey  <tromey@adacore.com>
11890
11891         * remote.c (class scoped_remote_fd) <release>: Add
11892         ATTRIBUTE_UNUSED_RESULT.
11893
11894 2019-03-05  Tom Tromey  <tromey@adacore.com>
11895
11896         * macroexp.c (struct macro_buffer) <release>: Add
11897         ATTRIBUTE_UNUSED_RESULT.
11898
11899 2019-03-05  Tom Tromey  <tromey@adacore.com>
11900
11901         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11902         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11903         ATTRIBUTE_UNUSED_RESULT.
11904
11905 2019-03-05  Tom Tromey  <tromey@adacore.com>
11906
11907         * common/scoped_fd.h (class scoped_fd) <release>: Add
11908         ATTRIBUTE_UNUSED_RESULT.
11909
11910 2019-03-05  Tom Tromey  <tromey@adacore.com>
11911
11912         * parser-defs.h (struct parser_state) <release>: Add
11913         ATTRIBUTE_UNUSED_RESULT.
11914
11915 2019-03-05  Tom Tromey  <tromey@adacore.com>
11916
11917         * utils.h (class gdb_argv) <release>: Add
11918         ATTRIBUTE_UNUSED_RESULT.
11919         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11920
11921 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11922
11923         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11924         for-loop range, to avoid compiler warnings.
11925
11926         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11927         avoid compiler warnings about unused variables.
11928
11929         * NEWS: Mention end of support for native debugging on MS-Windows
11930         before XP.
11931
11932         PR gdb/24292
11933         * common/netstuff.c:
11934         * gdbserver/gdbreplay.c
11935         * gdbserver/remote-utils.c:
11936         * ser-tcp.c:
11937         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11938         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11939         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11940         'getaddrinfo' and 'freeaddrinfo' were not available before
11941         Windows XP, and mingw.org's MinGW headers by default define
11942         _WIN32_WINNT to 0x500.
11943
11944 2019-03-01  Gary Benson <gbenson@redhat.com>
11945
11946         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11947
11948 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11949             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11950
11951         PR gdb/8527
11952         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11953         set_sigint_trap, clear_sigint_trap.
11954
11955 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11956
11957         * target.c (target_detach): Clear the regcache and the
11958         frame cache.
11959
11960 2019-02-27  Pedro Alves  <palves@redhat.com>
11961
11962         * utils.c (set_screen_size): When we cap the height/width sizes,
11963         tweak the corresponding command variable to show "unlimited":
11964
11965 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11966             Pedro Alves  <palves@redhat.com>
11967
11968         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11969         before calling rl_set_screen_size.
11970
11971 2019-02-27  Tom Tromey  <tromey@adacore.com>
11972
11973         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11974         define.
11975         * python/py-value.c: Remove Python 2.4 workaround.
11976         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11977         workaround.
11978         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11979         Python 2.4 workaround.
11980         * python/python-internal.h: Remove Python 2.4 comment.
11981         (Py_ssize_t): Don't define.
11982         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11983         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11984         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11985         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11986         * python/python.c (do_start_initialization): Remove Python 2.4
11987         workaround.
11988         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11989         (print_children): Remove Python 2.4 workaround.
11990         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11991         workaround.
11992         (CHARBUFFERPROC_NAME): Remove.
11993         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11994         Python 2.4 workaround.
11995
11996 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11997
11998         * NEWS: Note minimum Python version.
11999
12000 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12001
12002         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12003         code from these functions.  Remove corresponding ifdefs.  Use
12004         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12005         Remove gotos and target of gotos.
12006         (infpy_search_memory): Likewise.
12007
12008 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12009
12010         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12011         (hppa_gdbarch_init): Don't register deleted functions with
12012         gdbarch.
12013
12014 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12015
12016         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12017         (h8300_unwind_sp): Delete.
12018         (h8300_dummy_id): Delete.
12019         (h8300_gdbarch_init): Don't register deleted functions with
12020         gdbarch.
12021
12022 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12023
12024         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12025         (ft32_unwind_pc): Delete.
12026         (ft32_unwind_sp): Delete.
12027         (ft32_gdbarch_init): Don't register deleted functions with
12028         gdbarch.
12029
12030 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12031
12032         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12033         (frv_unwind_pc): Delete.
12034         (frv_unwind_sp): Delete.
12035         (frv_gdbarch_init): Don't register deleted functions with
12036         gdbarch.
12037
12038 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12039
12040         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12041         (riscv_unwind_pc): Delete.
12042         (riscv_unwind_sp): Delete.
12043         (riscv_gdbarch_init): Don't register deleted functions with
12044         gdbarch.
12045
12046 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12047
12048         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12049         (csky_unwind_pc): Delete.
12050         (csky_unwind_sp): Delete.
12051         (csky_gdbarch_init): Don't register deleted functions with
12052         gdbarch.
12053
12054 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12055
12056         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12057         (cris_unwind_pc): Delete.
12058         (cris_unwind_sp): Delete.
12059         (cris_gdbarch_init): Don't register deleted functions with
12060         gdbarch.
12061
12062 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12063
12064         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12065         (bfin_unwind_pc): Delete.
12066         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12067
12068 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12069
12070         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12071         (arm_unwind_pc): Delete.
12072         (arm_unwind_sp): Delete.
12073         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12074
12075 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12076
12077         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12078         (arc_unwind_pc): Delete.
12079         (arc_unwind_sp): Delete.
12080         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12081
12082 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12083
12084         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12085         (alpha_unwind_pc): Delete.
12086         (alpha_gdbarch_init): Don't register deleted functions with
12087         gdbarch.
12088
12089 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12090
12091         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12092         (aarch64_unwind_pc): Delete.
12093         (aarch64_unwind_sp): Delete.
12094         (aarch64_gdbarch_init): Don't register deleted functions with
12095         gdbarch.
12096
12097 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12098
12099         * gdbtypes.c (type_align): Don't consider static members when
12100         computing structure alignment.
12101
12102 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12103
12104         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12105         return 0 for other types.
12106         * arch-utils.c (default_type_align): Always return 0.
12107         * gdbarch.h: Regenerate.
12108         * gdbarch.sh (type_align): Extend comment.
12109         * gdbtypes.c (type_align): Add additional comments, always call
12110         gdbarch_type_align before applying the default rules.
12111         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12112         generic code will then apply a suitable default.
12113         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12114         types, return 0 for other types.
12115
12116 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12117
12118         * NEWS: Create a new section for the next release branch.
12119         Rename the section of the current branch, now that it has
12120         been cut.
12121
12122 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12123
12124         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12125         * version.in: Bump version to 8.3.50.DATE-git.
12126
12127 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12128
12129         * aix-thread.c (ptid_cmp): Remove unused variable.
12130         (get_signaled_thread): Likewise.
12131         (store_regs_user_thread): Likewise.
12132         (store_regs_kernel_thread): Likewise.
12133         (fetch_regs_kernel_thread): Remove shadowed variable.
12134
12135 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12136
12137         * features/riscv/32bit-cpu.xml: Add register numbers.
12138         * features/riscv/32bit-fpu.c: Regenerate.
12139         * features/riscv/32bit-fpu.xml: Add register numbers.
12140         * features/riscv/64bit-cpu.xml: Add register numbers.
12141         * features/riscv/64bit-fpu.c: Regenerate.
12142         * features/riscv/64bit-fpu.xml: Add register numbers.
12143
12144 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12145
12146         * NEWS: Mention two argument form of gdb.Value constructor.
12147         * python/py-value.c (convert_buffer_and_type_to_value): New
12148         function.
12149         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12150         Add support for handling an optional second argument.  Call
12151         convert_buffer_and_type_to_value as appropriate.
12152         * python/python-internal.h (Py_buffer_deleter): New struct.
12153         (Py_buffer_up): New typedef.
12154
12155 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12156
12157         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12158         instead of releasing ownership.
12159
12160 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12161
12162         * dwarf2read.c (open_and_init_dwp_file): Call
12163         elf_numsections instead of bfd_count_sections to initialize
12164         dwp_file->num_sections.
12165
12166 2019-02-25  Tom Tromey  <tromey@adacore.com>
12167
12168         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12169
12170 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12171
12172         * gcore.in: Add '--readnever' option when invoking GDB.
12173
12174 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12175
12176         * MAINTAINERS: Update my email address.
12177
12178 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12179
12180         * build-id.c (build_id_to_debug_bfd_1): New function.
12181         (build_id_to_debug_bfd): Look for separate debug file in
12182         sysroot.
12183
12184 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12185
12186         * gdbarch.sh: Update the copyright year range that is placed into
12187         generated files.
12188
12189 2019-02-22  Keith Seitz  <keiths@redhat.com>
12190
12191         PR symtab/23853
12192         * linespec.c (create_sals_line_offset): Search for the default
12193         symtab's filename instead of its fullname.
12194
12195 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12196
12197         * NEWS: Update style defaults.
12198
12199 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12200
12201         * main.c (captured_main_1): Disable styling in batch mode.
12202
12203 2019-02-20  Tom Tromey  <tom@tromey.com>
12204
12205         * symtab.c (symtab_symbol_info): Fix typos.
12206
12207 2019-02-20  Tom Tromey  <tromey@adacore.com>
12208
12209         * findcmd.c (_initialize_mem_search): Use upper case for
12210         metasyntactic variables.
12211
12212 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12213
12214         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12215         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12216
12217 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12218
12219         * top.h (source_file_name): Change to std::string.
12220         * top.c (source_file_name): Likewise.
12221         (command_line_input): Adjust.
12222         * cli/cli-script.c (script_from_file): Adjust.
12223
12224 2019-02-19  Tom Tromey  <tromey@adacore.com>
12225
12226         * ravenscar-thread.c
12227         (ravenscar_thread_target::update_thread_list): Don't call
12228         ada_build_task_list.
12229         * ada-lang.h (ada_build_task_list): Don't declare.
12230         * ada-tasks.c (struct ada_tasks_inferior_data)
12231         <task_list_valid_p>: Now bool.
12232         (read_known_tasks, ada_task_list_changed)
12233         (ada_tasks_invalidate_inferior_data): Update.
12234         (read_known_tasks_array): Return bool.
12235         (read_known_tasks_list): Likewise.
12236         (read_known_tasks): Return void.
12237         (ada_build_task_list): Now static.
12238
12239 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12240
12241         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12242         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12243
12244 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12245
12246         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12247         variant for ada_tasks_pspace_data_handle and
12248         ada_tasks_inferior_data_handle.
12249         (ada_tasks_pspace_data_cleanup): New function.
12250         (ada_tasks_inferior_data_cleanup): New function.
12251
12252 2019-02-17  Tom Tromey  <tom@tromey.com>
12253
12254         * macrotab.h (macro_source_fullname): Return a std::string.
12255         * macrotab.c (macro_include, check_for_redefinition)
12256         (macro_undef, macro_lookup_definition, foreach_macro)
12257         (foreach_macro_in_scope): Update.
12258         (macro_source_fullname): Return a std::string.
12259         * macrocmd.c (show_pp_source_pos): Update.
12260
12261 2019-02-17  Tom Tromey  <tom@tromey.com>
12262
12263         * macrocmd.c (show_pp_source_pos): Style the file names.
12264
12265 2019-02-17  Tom Tromey  <tom@tromey.com>
12266
12267         PR tui/24197:
12268         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12269
12270 2019-02-17  Tom Tromey  <tom@tromey.com>
12271
12272         * ada-lang.c (user_select_syms): Use filtered printing.
12273         * utils.c (wrap_style): New global.
12274         (desired_style): Remove.
12275         (emit_style_escape): Add stream parameter.
12276         (set_output_style, reset_terminal_style, prompt_for_continue):
12277         Update.
12278         (flush_wrap_buffer): Only flush gdb_stdout.
12279         (wrap_here): Set wrap_style.
12280         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12281         treat escape sequences as a character.  Change when wrap buffer is
12282         flushed.
12283         (fputs_styled): Do not set the output style when the default is
12284         requested.
12285         * ui-style.h (struct ui_file_style) <is_default>: New method.
12286         * source.c (print_source_lines_base): Emit escape sequences in one
12287         piece.
12288
12289 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12290
12291         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12292         integers and enumeration types.
12293
12294 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12295
12296         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12297         instead of lookup_symbol_in_language
12298         (do_exact_match): New function.
12299         (ada_get_symbol_name_matcher): Return do_exact_match when
12300         doing a verbatim match.
12301
12302 2019-02-15  Tom Tromey  <tromey@adacore.com>
12303
12304         * ravenscar-thread.c (ravenscar_thread_target::resume)
12305         (ravenscar_thread_target::wait): Special case wildcard requests.
12306
12307 2019-02-15  Tom Tromey  <tromey@adacore.com>
12308
12309         * ravenscar-thread.c (base_ptid): Remove.
12310         (struct ravenscar_thread_target) <close>: New method.
12311         <m_base_ptid>: New member.
12312         <update_inferior_ptid, active_task, task_is_currently_active,
12313         runtime_initialized>: Declare methods.
12314         <ravenscar_thread_target>: Add constructor.
12315         (ravenscar_thread_target::task_is_currently_active)
12316         (ravenscar_thread_target::update_inferior_ptid)
12317         (ravenscar_runtime_initialized): Rename.  Now methods.
12318         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12319         (ravenscar_thread_target::update_thread_list): Update.
12320         (ravenscar_thread_target::active_task): Now method.
12321         (ravenscar_thread_target::store_registers)
12322         (ravenscar_thread_target::prepare_to_store)
12323         (ravenscar_thread_target::prepare_to_store)
12324         (ravenscar_thread_target::mourn_inferior): Update.
12325         (ravenscar_inferior_created): Use "new" to create target.
12326         (ravenscar_thread_target::get_ada_task_ptid): Update.
12327         (_initialize_ravenscar): Don't initialize base_ptid.
12328         (ravenscar_ops): Remove global.
12329
12330 2019-02-15  Tom Tromey  <tromey@adacore.com>
12331
12332         * target.h (push_target): Declare new overload.
12333         * target.c (push_target): New overload, taking an rvalue reference.
12334         * remote.c (remote_target::open_1): Use push_target overload.
12335         * corelow.c (core_target_open): Use push_target overload.
12336
12337 2019-02-15  Tom Tromey  <tromey@adacore.com>
12338
12339         * ravenscar-thread.c (is_ravenscar_task)
12340         (ravenscar_task_is_currently_active): Return bool.
12341         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12342         (_initialize_ravenscar): Remove "(void)".
12343         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12344         Return bool.
12345
12346 2019-02-15  Tom Tromey  <tromey@adacore.com>
12347
12348         * ravenscar-thread.c (ravenscar_runtime_initializer)
12349         (has_ravenscar_runtime, get_running_thread_id)
12350         (ravenscar_thread_target::resume): Fix indentation.
12351
12352 2019-02-15  Tom Tromey  <tromey@adacore.com>
12353
12354         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12355         from ravenscar_arch_ops.
12356         (sparc_ravenscar_ops::fetch_registers)
12357         (sparc_ravenscar_ops::store_registers): Now methods.
12358         (sparc_ravenscar_prepare_to_store): Remove.
12359         (sparc_ravenscar_ops): Redefine.
12360         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12361         methods and destructor.  Remove members.
12362         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12363         (ravenscar_thread_target::store_registers)
12364         (ravenscar_thread_target::prepare_to_store): Update.
12365         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12366         Remove.
12367         (struct ppc_ravenscar_powerpc_ops): Derive from
12368         ravenscar_arch_ops.
12369         (ppc_ravenscar_powerpc_ops::fetch_registers)
12370         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12371         (ppc_ravenscar_powerpc_ops): Redefine.
12372         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12373         (ppc_ravenscar_e500_ops::fetch_registers)
12374         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12375         (ppc_ravenscar_e500_ops): Redefine.
12376         * aarch64-ravenscar-thread.c
12377         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12378         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12379         (aarch64_ravenscar_fetch_registers)
12380         (aarch64_ravenscar_store_registers): Now methods.
12381         (aarch64_ravenscar_ops): Redefine.
12382
12383 2019-02-15  Tom Tromey  <tromey@adacore.com>
12384
12385         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12386         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12387         (ravenscar_thread_target::stopped_by_watchpoint)
12388         (ravenscar_thread_target::stopped_data_address)
12389         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12390
12391 2019-02-15  Tom Tromey  <tromey@adacore.com>
12392
12393         * ravenscar-thread.c: Fix some typos.
12394
12395 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12396             Tom Tromey  <tromey@adacore.com>
12397
12398         * ada-lang.c (ada_exception_sal): Change addr_string to a
12399         std::string.
12400         (create_ada_exception_catchpoint): Update.
12401
12402 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12403             Tom Tromey  <tromey@adacore.com>
12404
12405         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12406         (bp_location_ops): Remove.
12407         (base_breakpoint_allocate_location): Update.
12408         (free_bp_location): Update.
12409         * ada-lang.c (class ada_catchpoint_location)
12410         <ada_catchpoint_location>: Remove ops parameter.
12411         (ada_catchpoint_location_dtor): Remove.
12412         (ada_catchpoint_location_ops): Remove.
12413         (allocate_location_exception): Update.
12414         * breakpoint.h (struct bp_location_ops): Remove.
12415         (class bp_location) <bp_location>: Remove bp_location_ops
12416         parameter.
12417         <~bp_location>: Add destructor.
12418         <ops>: Remove.
12419
12420 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12421             Pedro Alves  <palves@redhat.com>
12422
12423         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12424         'PATH_MAX'.
12425
12426 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12427             Samuel Thibault  <samuel.thibault@gnu.org>
12428             Thomas Schwinge  <thomas@codesourcery.com>
12429
12430         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12431         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12432
12433 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12434
12435         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12436         (check_empty): Use "const char *".
12437
12438         * gnu-nat.c (gnu_nat_target::detach): Instead of
12439         'detach_inferior (pid)' call
12440         'detach_inferior (find_inferior_pid (pid))'.
12441
12442         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12443         'nat/fork-inferior.o'.
12444         * gnu-nat.c: #include "nat/fork-inferior.h".
12445
12446         * gnu-nat.c (gnu_nat_target::detach): Instead of
12447         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12448         * gnu-nat.h: #include "inf-child.h".
12449         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12450         'i386_gnu_nat_target::fetch_registers'.
12451         (gnu_store_registers): Rename/move to
12452         'i386_gnu_nat_target::store_registers'.
12453
12454         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12455         * gnu-nat.h (mach_thread_info): New function.
12456         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12457
12458         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12459
12460 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12461
12462         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12463
12464 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12465
12466         * windows-nat.c (windows_add_thread): Add new parameter
12467         "main_thread_p" with default value set to false.  Update
12468         function documentation as well as all callers.
12469         (windows_delete_thread): Likewise.
12470         (fake_create_process): Update call to windows_add_thread.
12471         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12472         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12473         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12474         call to windows_delete_thread.
12475
12476 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12477
12478         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12479
12480 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12481
12482         * symfile.c (find_separate_debug_file): Use canonical path of
12483         sysroot with child_path instead of gdb_sysroot if it is valid.
12484
12485 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12486
12487         * symfile.c (find_separate_debug_file): Use child_path to
12488         determine if an object file is under a sysroot.
12489
12490 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12491
12492         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12493         unittests/child-path-selftests.c.
12494         * common/pathstuff.c (child_path): New function.
12495         * common/pathstuff.h (child_path): New prototype.
12496         * unittests/child-path-selftests.c: New file.
12497
12498 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12499
12500         * symfile.c (find_separate_debug_file): Look for separate debug
12501         files in debug directories under the sysroot.
12502
12503 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12504
12505         * symtab.h (struct minimal_symbol data_p): New const method.
12506         (struct minimal_symbol text_p): Likewise.
12507         * symtab.c (output_source_filename): Use file name style
12508         to print file name.
12509         (print_symbol_info): Likewise.
12510         (print_msymbol_info): Use address style to print addresses.
12511         Use function name style to print executable text symbols.
12512         (expand_symtab_containing_pc): Use data_p.
12513         (find_pc_sect_compunit_symtab): Likewise.
12514
12515 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12516
12517         * breakpoint.c (describe_other_breakpoints): Use address style
12518         to print addresses.
12519         (say_where): Likewise.
12520
12521 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12522
12523         * ada-typeprint.c (print_func_type): Print function name
12524         style to print function name.
12525         * c-typeprint.c (c_print_type_1): Likewise.
12526
12527 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12528
12529         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12530         for execve.
12531
12532 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12533
12534         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12535         type_stack.
12536
12537 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12538
12539         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12540         TYPE_CODE_REF types.
12541
12542 2019-02-08  Jim Wilson  <jimw@sifive.com>
12543
12544         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12545         (riscv_linux_fregset): New.
12546         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12547
12548 2019-02-07  Tom Tromey  <tom@tromey.com>
12549
12550         * thread.c (thread_cancel_execution_command): Update.
12551         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12552         methods.
12553         (struct thread_fsm_ops): Remove.
12554         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12555         (thread_fsm_should_stop, thread_fsm_return_value)
12556         (thread_fsm_set_finished, thread_fsm_finished_p)
12557         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12558         Don't declare.
12559         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12560         * infrun.c (clear_proceed_status_thread)
12561         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12562         (print_stop_event): Update.
12563         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12564         Add constructor.
12565         (step_command_fsm_ops): Remove.
12566         (new_step_command_fsm): Remove.
12567         (step_1): Update.
12568         (step_command_fsm::should_stop): Rename from
12569         step_command_fsm_should_stop.
12570         (step_command_fsm::clean_up): Rename from
12571         step_command_fsm_clean_up.
12572         (step_command_fsm::do_async_reply_reason): Rename from
12573         step_command_fsm_async_reply_reason.
12574         (struct until_next_fsm): Inherit from thread_fsm.  Add
12575         constructor.
12576         (until_next_fsm_ops): Remove.
12577         (new_until_next_fsm): Remove.
12578         (until_next_fsm::should_stop): Rename from
12579         until_next_fsm_should_stop.
12580         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12581         (until_next_fsm::do_async_reply_reason): Rename from
12582         until_next_fsm_async_reply_reason.
12583         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12584         constructor.  Change type of breakpoint.
12585         (finish_command_fsm_ops): Remove.
12586         (new_finish_command_fsm): Remove.
12587         (finish_command_fsm::should_stop): Rename from
12588         finish_command_fsm_should_stop.
12589         (finish_command_fsm::clean_up): Rename from
12590         finish_command_fsm_clean_up.
12591         (finish_command_fsm::return_value): Rename from
12592         finish_command_fsm_return_value.
12593         (finish_command_fsm::do_async_reply_reason): Rename from
12594         finish_command_fsm_async_reply_reason.
12595         (finish_command): Update.
12596         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12597         Add constructor.
12598         (call_thread_fsm_ops): Remove.
12599         (call_thread_fsm::call_thread_fsm): Rename from
12600         new_call_thread_fsm.
12601         (call_thread_fsm::should_stop): Rename from
12602         call_thread_fsm_should_stop.
12603         (call_thread_fsm::should_notify_stop): Rename from
12604         call_thread_fsm_should_notify_stop.
12605         (run_inferior_call, call_function_by_hand_dummy): Update.
12606         * cli/cli-interp.c (should_print_stop_to_console): Update.
12607         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12608         Add constructor.  Change type of location_breakpoint,
12609         caller_breakpoint.
12610         (until_break_fsm_ops): Remove.
12611         (new_until_break_fsm): Remove.
12612         (until_break_fsm::should_stop): Rename from
12613         until_break_fsm_should_stop.
12614         (until_break_fsm::clean_up): Rename from
12615         until_break_fsm_clean_up.
12616         (until_break_fsm::do_async_reply_reason): Rename from
12617         until_break_fsm_async_reply_reason.
12618         (until_break_command): Update.
12619         * thread-fsm.c: Remove.
12620         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12621
12622 2019-02-07  Tom Tromey  <tom@tromey.com>
12623
12624         * yy-remap.h: Add include guard.
12625         * xtensa-tdep.h: Add include guard.
12626         * xcoffread.h: Rename include guard.
12627         * varobj-iter.h: Add include guard.
12628         * tui/tui.h: Rename include guard.
12629         * tui/tui-winsource.h: Rename include guard.
12630         * tui/tui-wingeneral.h: Rename include guard.
12631         * tui/tui-windata.h: Rename include guard.
12632         * tui/tui-win.h: Rename include guard.
12633         * tui/tui-stack.h: Rename include guard.
12634         * tui/tui-source.h: Rename include guard.
12635         * tui/tui-regs.h: Rename include guard.
12636         * tui/tui-out.h: Rename include guard.
12637         * tui/tui-layout.h: Rename include guard.
12638         * tui/tui-io.h: Rename include guard.
12639         * tui/tui-hooks.h: Rename include guard.
12640         * tui/tui-file.h: Rename include guard.
12641         * tui/tui-disasm.h: Rename include guard.
12642         * tui/tui-data.h: Rename include guard.
12643         * tui/tui-command.h: Rename include guard.
12644         * tic6x-tdep.h: Add include guard.
12645         * target/waitstatus.h: Rename include guard.
12646         * target/wait.h: Rename include guard.
12647         * target/target.h: Rename include guard.
12648         * target/resume.h: Rename include guard.
12649         * target-float.h: Rename include guard.
12650         * stabsread.h: Add include guard.
12651         * rs6000-tdep.h: Add include guard.
12652         * riscv-fbsd-tdep.h: Add include guard.
12653         * regformats/regdef.h: Rename include guard.
12654         * record.h: Rename include guard.
12655         * python/python.h: Rename include guard.
12656         * python/python-internal.h: Rename include guard.
12657         * python/py-stopevent.h: Rename include guard.
12658         * python/py-ref.h: Rename include guard.
12659         * python/py-record.h: Rename include guard.
12660         * python/py-record-full.h: Rename include guard.
12661         * python/py-record-btrace.h: Rename include guard.
12662         * python/py-instruction.h: Rename include guard.
12663         * python/py-events.h: Rename include guard.
12664         * python/py-event.h: Rename include guard.
12665         * procfs.h: Add include guard.
12666         * proc-utils.h: Add include guard.
12667         * p-lang.h: Add include guard.
12668         * or1k-tdep.h: Rename include guard.
12669         * observable.h: Rename include guard.
12670         * nto-tdep.h: Rename include guard.
12671         * nat/x86-linux.h: Rename include guard.
12672         * nat/x86-linux-dregs.h: Rename include guard.
12673         * nat/x86-gcc-cpuid.h: Add include guard.
12674         * nat/x86-dregs.h: Rename include guard.
12675         * nat/x86-cpuid.h: Rename include guard.
12676         * nat/ppc-linux.h: Rename include guard.
12677         * nat/mips-linux-watch.h: Rename include guard.
12678         * nat/linux-waitpid.h: Rename include guard.
12679         * nat/linux-ptrace.h: Rename include guard.
12680         * nat/linux-procfs.h: Rename include guard.
12681         * nat/linux-osdata.h: Rename include guard.
12682         * nat/linux-nat.h: Rename include guard.
12683         * nat/linux-namespaces.h: Rename include guard.
12684         * nat/linux-btrace.h: Rename include guard.
12685         * nat/glibc_thread_db.h: Rename include guard.
12686         * nat/gdb_thread_db.h: Rename include guard.
12687         * nat/gdb_ptrace.h: Rename include guard.
12688         * nat/fork-inferior.h: Rename include guard.
12689         * nat/amd64-linux-siginfo.h: Rename include guard.
12690         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12691         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12692         * nat/aarch64-linux.h: Rename include guard.
12693         * nat/aarch64-linux-hw-point.h: Rename include guard.
12694         * mn10300-tdep.h: Add include guard.
12695         * mips-linux-tdep.h: Add include guard.
12696         * mi/mi-parse.h: Rename include guard.
12697         * mi/mi-out.h: Rename include guard.
12698         * mi/mi-main.h: Rename include guard.
12699         * mi/mi-interp.h: Rename include guard.
12700         * mi/mi-getopt.h: Rename include guard.
12701         * mi/mi-console.h: Rename include guard.
12702         * mi/mi-common.h: Rename include guard.
12703         * mi/mi-cmds.h: Rename include guard.
12704         * mi/mi-cmd-break.h: Rename include guard.
12705         * m2-lang.h: Add include guard.
12706         * location.h: Rename include guard.
12707         * linux-record.h: Rename include guard.
12708         * linux-nat.h: Add include guard.
12709         * linux-fork.h: Add include guard.
12710         * i386-darwin-tdep.h: Rename include guard.
12711         * hppa-linux-offsets.h: Add include guard.
12712         * guile/guile.h: Rename include guard.
12713         * guile/guile-internal.h: Rename include guard.
12714         * gnu-nat.h: Rename include guard.
12715         * gdb-stabs.h: Rename include guard.
12716         * frv-tdep.h: Add include guard.
12717         * f-lang.h: Add include guard.
12718         * event-loop.h: Add include guard.
12719         * darwin-nat.h: Rename include guard.
12720         * cp-abi.h: Rename include guard.
12721         * config/sparc/nm-sol2.h: Rename include guard.
12722         * config/nm-nto.h: Rename include guard.
12723         * config/nm-linux.h: Add include guard.
12724         * config/i386/nm-i386gnu.h: Rename include guard.
12725         * config/djgpp/nl_types.h: Rename include guard.
12726         * config/djgpp/langinfo.h: Rename include guard.
12727         * compile/gcc-cp-plugin.h: Add include guard.
12728         * compile/gcc-c-plugin.h: Add include guard.
12729         * compile/compile.h: Rename include guard.
12730         * compile/compile-object-run.h: Rename include guard.
12731         * compile/compile-object-load.h: Rename include guard.
12732         * compile/compile-internal.h: Rename include guard.
12733         * compile/compile-cplus.h: Rename include guard.
12734         * compile/compile-c.h: Rename include guard.
12735         * common/xml-utils.h: Rename include guard.
12736         * common/x86-xstate.h: Rename include guard.
12737         * common/version.h: Rename include guard.
12738         * common/vec.h: Rename include guard.
12739         * common/tdesc.h: Rename include guard.
12740         * common/selftest.h: Rename include guard.
12741         * common/scoped_restore.h: Rename include guard.
12742         * common/scoped_mmap.h: Rename include guard.
12743         * common/scoped_fd.h: Rename include guard.
12744         * common/safe-iterator.h: Rename include guard.
12745         * common/run-time-clock.h: Rename include guard.
12746         * common/refcounted-object.h: Rename include guard.
12747         * common/queue.h: Rename include guard.
12748         * common/ptid.h: Rename include guard.
12749         * common/print-utils.h: Rename include guard.
12750         * common/preprocessor.h: Rename include guard.
12751         * common/pathstuff.h: Rename include guard.
12752         * common/observable.h: Rename include guard.
12753         * common/netstuff.h: Rename include guard.
12754         * common/job-control.h: Rename include guard.
12755         * common/host-defs.h: Rename include guard.
12756         * common/gdb_wait.h: Rename include guard.
12757         * common/gdb_vecs.h: Rename include guard.
12758         * common/gdb_unlinker.h: Rename include guard.
12759         * common/gdb_unique_ptr.h: Rename include guard.
12760         * common/gdb_tilde_expand.h: Rename include guard.
12761         * common/gdb_sys_time.h: Rename include guard.
12762         * common/gdb_string_view.h: Rename include guard.
12763         * common/gdb_splay_tree.h: Rename include guard.
12764         * common/gdb_setjmp.h: Rename include guard.
12765         * common/gdb_ref_ptr.h: Rename include guard.
12766         * common/gdb_optional.h: Rename include guard.
12767         * common/gdb_locale.h: Rename include guard.
12768         * common/gdb_assert.h: Rename include guard.
12769         * common/filtered-iterator.h: Rename include guard.
12770         * common/filestuff.h: Rename include guard.
12771         * common/fileio.h: Rename include guard.
12772         * common/environ.h: Rename include guard.
12773         * common/common-utils.h: Rename include guard.
12774         * common/common-types.h: Rename include guard.
12775         * common/common-regcache.h: Rename include guard.
12776         * common/common-inferior.h: Rename include guard.
12777         * common/common-gdbthread.h: Rename include guard.
12778         * common/common-exceptions.h: Rename include guard.
12779         * common/common-defs.h: Rename include guard.
12780         * common/common-debug.h: Rename include guard.
12781         * common/cleanups.h: Rename include guard.
12782         * common/buffer.h: Rename include guard.
12783         * common/btrace-common.h: Rename include guard.
12784         * common/break-common.h: Rename include guard.
12785         * cli/cli-utils.h: Rename include guard.
12786         * cli/cli-style.h: Rename include guard.
12787         * cli/cli-setshow.h: Rename include guard.
12788         * cli/cli-script.h: Rename include guard.
12789         * cli/cli-interp.h: Rename include guard.
12790         * cli/cli-decode.h: Rename include guard.
12791         * cli/cli-cmds.h: Rename include guard.
12792         * charset-list.h: Add include guard.
12793         * buildsym-legacy.h: Rename include guard.
12794         * bfin-tdep.h: Add include guard.
12795         * ax.h: Rename include guard.
12796         * arm-linux-tdep.h: Add include guard.
12797         * arm-fbsd-tdep.h: Add include guard.
12798         * arch/xtensa.h: Rename include guard.
12799         * arch/tic6x.h: Add include guard.
12800         * arch/i386.h: Add include guard.
12801         * arch/arm.h: Rename include guard.
12802         * arch/arm-linux.h: Rename include guard.
12803         * arch/arm-get-next-pcs.h: Rename include guard.
12804         * arch/amd64.h: Add include guard.
12805         * arch/aarch64-insn.h: Rename include guard.
12806         * arch-utils.h: Rename include guard.
12807         * annotate.h: Add include guard.
12808         * amd64-darwin-tdep.h: Rename include guard.
12809         * aarch64-linux-tdep.h: Add include guard.
12810         * aarch64-fbsd-tdep.h: Add include guard.
12811         * aarch32-linux-nat.h: Add include guard.
12812
12813 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12814
12815         * macrotab.c (macro_define_internal): New function that
12816         factorizes macro_define_object_internal and macro_define_function
12817         code.
12818         (macro_define_object_internal): Use macro_define_internal.
12819         (macro_define_function): Likewise.
12820
12821 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12822
12823         * macrocmd.c (extract_identifier): Return
12824         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12825         callers.
12826
12827 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12828
12829         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12830
12831 2019-02-05  Tom Tromey  <tom@tromey.com>
12832
12833         * target.c (target_stack::unpush): Move assertion earlier.
12834
12835 2019-01-30  Tom Tromey  <tom@tromey.com>
12836
12837         PR python/23615:
12838         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12839         (gdbpy_parse_and_eval): Likewise.
12840         * python/python-internal.h (gdbpy_allow_threads): New class.
12841
12842 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12843
12844         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12845         (aarch64_fbsd_fpregmap): Move earlier.
12846         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12847         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12848         instead of individual calls to trad_frame_set_reg_addr.
12849         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12850         earlier.
12851         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12852         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12853         instead of individual calls to trad_frame_set_reg_addr.
12854
12855 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12856
12857         * CONTRIBUTE: Replace contribution list with wiki link.
12858
12859 2019-01-25  Tom Tromey  <tom@tromey.com>
12860
12861         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12862
12863 2019-01-25  Tom Tromey  <tom@tromey.com>
12864
12865         * xtensa-linux-nat.c: Fix common/ includes.
12866         * xml-support.h: Fix common/ includes.
12867         * xml-support.c: Fix common/ includes.
12868         * x86-linux-nat.c: Fix common/ includes.
12869         * windows-nat.c: Fix common/ includes.
12870         * varobj.h: Fix common/ includes.
12871         * varobj.c: Fix common/ includes.
12872         * value.c: Fix common/ includes.
12873         * valops.c: Fix common/ includes.
12874         * utils.c: Fix common/ includes.
12875         * unittests/xml-utils-selftests.c: Fix common/ includes.
12876         * unittests/utils-selftests.c: Fix common/ includes.
12877         * unittests/unpack-selftests.c: Fix common/ includes.
12878         * unittests/tracepoint-selftests.c: Fix common/ includes.
12879         * unittests/style-selftests.c: Fix common/ includes.
12880         * unittests/string_view-selftests.c: Fix common/ includes.
12881         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12882         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12883         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12884         * unittests/rsp-low-selftests.c: Fix common/ includes.
12885         * unittests/parse-connection-spec-selftests.c: Fix common/
12886         includes.
12887         * unittests/optional-selftests.c: Fix common/ includes.
12888         * unittests/offset-type-selftests.c: Fix common/ includes.
12889         * unittests/observable-selftests.c: Fix common/ includes.
12890         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12891         * unittests/memrange-selftests.c: Fix common/ includes.
12892         * unittests/memory-map-selftests.c: Fix common/ includes.
12893         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12894         * unittests/function-view-selftests.c: Fix common/ includes.
12895         * unittests/environ-selftests.c: Fix common/ includes.
12896         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12897         * unittests/common-utils-selftests.c: Fix common/ includes.
12898         * unittests/cli-utils-selftests.c: Fix common/ includes.
12899         * unittests/array-view-selftests.c: Fix common/ includes.
12900         * ui-file.c: Fix common/ includes.
12901         * tui/tui-io.c: Fix common/ includes.
12902         * tracepoint.h: Fix common/ includes.
12903         * tracepoint.c: Fix common/ includes.
12904         * tracefile-tfile.c: Fix common/ includes.
12905         * top.h: Fix common/ includes.
12906         * top.c: Fix common/ includes.
12907         * thread.c: Fix common/ includes.
12908         * target/waitstatus.h: Fix common/ includes.
12909         * target/waitstatus.c: Fix common/ includes.
12910         * target.h: Fix common/ includes.
12911         * target.c: Fix common/ includes.
12912         * target-memory.c: Fix common/ includes.
12913         * target-descriptions.c: Fix common/ includes.
12914         * symtab.h: Fix common/ includes.
12915         * symfile.c: Fix common/ includes.
12916         * stap-probe.c: Fix common/ includes.
12917         * spu-linux-nat.c: Fix common/ includes.
12918         * sparc-nat.c: Fix common/ includes.
12919         * source.c: Fix common/ includes.
12920         * solib.c: Fix common/ includes.
12921         * solib-target.c: Fix common/ includes.
12922         * ser-unix.c: Fix common/ includes.
12923         * ser-tcp.c: Fix common/ includes.
12924         * ser-pipe.c: Fix common/ includes.
12925         * ser-base.c: Fix common/ includes.
12926         * selftest-arch.c: Fix common/ includes.
12927         * s12z-tdep.c: Fix common/ includes.
12928         * rust-exp.y: Fix common/ includes.
12929         * rs6000-aix-tdep.c: Fix common/ includes.
12930         * riscv-tdep.c: Fix common/ includes.
12931         * remote.c: Fix common/ includes.
12932         * remote-notif.h: Fix common/ includes.
12933         * remote-fileio.h: Fix common/ includes.
12934         * remote-fileio.c: Fix common/ includes.
12935         * regcache.h: Fix common/ includes.
12936         * regcache.c: Fix common/ includes.
12937         * record-btrace.c: Fix common/ includes.
12938         * python/python.c: Fix common/ includes.
12939         * python/py-type.c: Fix common/ includes.
12940         * python/py-inferior.c: Fix common/ includes.
12941         * progspace.h: Fix common/ includes.
12942         * producer.c: Fix common/ includes.
12943         * procfs.c: Fix common/ includes.
12944         * proc-api.c: Fix common/ includes.
12945         * printcmd.c: Fix common/ includes.
12946         * ppc-linux-nat.c: Fix common/ includes.
12947         * parser-defs.h: Fix common/ includes.
12948         * osdata.c: Fix common/ includes.
12949         * obsd-nat.c: Fix common/ includes.
12950         * nat/x86-linux.c: Fix common/ includes.
12951         * nat/x86-linux-dregs.c: Fix common/ includes.
12952         * nat/x86-dregs.h: Fix common/ includes.
12953         * nat/x86-dregs.c: Fix common/ includes.
12954         * nat/ppc-linux.c: Fix common/ includes.
12955         * nat/mips-linux-watch.h: Fix common/ includes.
12956         * nat/mips-linux-watch.c: Fix common/ includes.
12957         * nat/linux-waitpid.c: Fix common/ includes.
12958         * nat/linux-ptrace.h: Fix common/ includes.
12959         * nat/linux-ptrace.c: Fix common/ includes.
12960         * nat/linux-procfs.c: Fix common/ includes.
12961         * nat/linux-personality.c: Fix common/ includes.
12962         * nat/linux-osdata.c: Fix common/ includes.
12963         * nat/linux-namespaces.c: Fix common/ includes.
12964         * nat/linux-btrace.h: Fix common/ includes.
12965         * nat/linux-btrace.c: Fix common/ includes.
12966         * nat/fork-inferior.c: Fix common/ includes.
12967         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12968         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12969         * nat/aarch64-linux.c: Fix common/ includes.
12970         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12971         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12972         * namespace.h: Fix common/ includes.
12973         * mips-linux-tdep.c: Fix common/ includes.
12974         * minsyms.c: Fix common/ includes.
12975         * mi/mi-parse.h: Fix common/ includes.
12976         * mi/mi-main.c: Fix common/ includes.
12977         * mi/mi-cmd-env.c: Fix common/ includes.
12978         * memrange.h: Fix common/ includes.
12979         * memattr.c: Fix common/ includes.
12980         * maint.h: Fix common/ includes.
12981         * maint.c: Fix common/ includes.
12982         * main.c: Fix common/ includes.
12983         * machoread.c: Fix common/ includes.
12984         * location.c: Fix common/ includes.
12985         * linux-thread-db.c: Fix common/ includes.
12986         * linux-nat.c: Fix common/ includes.
12987         * linux-fork.c: Fix common/ includes.
12988         * inline-frame.c: Fix common/ includes.
12989         * infrun.c: Fix common/ includes.
12990         * inflow.c: Fix common/ includes.
12991         * inferior.h: Fix common/ includes.
12992         * inferior.c: Fix common/ includes.
12993         * infcmd.c: Fix common/ includes.
12994         * inf-ptrace.c: Fix common/ includes.
12995         * inf-child.c: Fix common/ includes.
12996         * ia64-linux-nat.c: Fix common/ includes.
12997         * i387-tdep.c: Fix common/ includes.
12998         * i386-tdep.c: Fix common/ includes.
12999         * i386-linux-tdep.c: Fix common/ includes.
13000         * i386-linux-nat.c: Fix common/ includes.
13001         * i386-go32-tdep.c: Fix common/ includes.
13002         * i386-fbsd-tdep.c: Fix common/ includes.
13003         * i386-fbsd-nat.c: Fix common/ includes.
13004         * guile/scm-type.c: Fix common/ includes.
13005         * guile/guile.c: Fix common/ includes.
13006         * go32-nat.c: Fix common/ includes.
13007         * gnu-nat.c: Fix common/ includes.
13008         * gdbthread.h: Fix common/ includes.
13009         * gdbarch-selftests.c: Fix common/ includes.
13010         * gdb_usleep.c: Fix common/ includes.
13011         * gdb_select.h: Fix common/ includes.
13012         * gdb_bfd.c: Fix common/ includes.
13013         * gcore.c: Fix common/ includes.
13014         * fork-child.c: Fix common/ includes.
13015         * findvar.c: Fix common/ includes.
13016         * fbsd-nat.c: Fix common/ includes.
13017         * event-top.c: Fix common/ includes.
13018         * event-loop.c: Fix common/ includes.
13019         * dwarf2read.c: Fix common/ includes.
13020         * dwarf2loc.c: Fix common/ includes.
13021         * dwarf2-frame.c: Fix common/ includes.
13022         * dwarf-index-cache.c: Fix common/ includes.
13023         * dtrace-probe.c: Fix common/ includes.
13024         * disasm-selftests.c: Fix common/ includes.
13025         * defs.h: Fix common/ includes.
13026         * csky-tdep.c: Fix common/ includes.
13027         * cp-valprint.c: Fix common/ includes.
13028         * cp-support.h: Fix common/ includes.
13029         * cp-support.c: Fix common/ includes.
13030         * corelow.c: Fix common/ includes.
13031         * completer.h: Fix common/ includes.
13032         * completer.c: Fix common/ includes.
13033         * compile/compile.c: Fix common/ includes.
13034         * compile/compile-loc2c.c: Fix common/ includes.
13035         * compile/compile-cplus-types.c: Fix common/ includes.
13036         * compile/compile-cplus-symbols.c: Fix common/ includes.
13037         * command.h: Fix common/ includes.
13038         * cli/cli-dump.c: Fix common/ includes.
13039         * cli/cli-cmds.c: Fix common/ includes.
13040         * charset.c: Fix common/ includes.
13041         * build-id.c: Fix common/ includes.
13042         * btrace.h: Fix common/ includes.
13043         * btrace.c: Fix common/ includes.
13044         * breakpoint.h: Fix common/ includes.
13045         * breakpoint.c: Fix common/ includes.
13046         * ax.h:
13047         (enum agent_op): Fix common/ includes.
13048         * ax-general.c (struct aop_map): Fix common/ includes.
13049         * ax-gdb.c: Fix common/ includes.
13050         * auxv.c: Fix common/ includes.
13051         * auto-load.c: Fix common/ includes.
13052         * arm-tdep.c: Fix common/ includes.
13053         * arch/riscv.c: Fix common/ includes.
13054         * arch/ppc-linux-common.c: Fix common/ includes.
13055         * arch/i386.c: Fix common/ includes.
13056         * arch/arm.c: Fix common/ includes.
13057         * arch/arm-linux.c: Fix common/ includes.
13058         * arch/arm-get-next-pcs.c: Fix common/ includes.
13059         * arch/amd64.c: Fix common/ includes.
13060         * arch/aarch64.c: Fix common/ includes.
13061         * arch/aarch64-insn.c: Fix common/ includes.
13062         * arch-utils.c: Fix common/ includes.
13063         * amd64-windows-tdep.c: Fix common/ includes.
13064         * amd64-tdep.c: Fix common/ includes.
13065         * amd64-sol2-tdep.c: Fix common/ includes.
13066         * amd64-obsd-tdep.c: Fix common/ includes.
13067         * amd64-nbsd-tdep.c: Fix common/ includes.
13068         * amd64-linux-tdep.c: Fix common/ includes.
13069         * amd64-linux-nat.c: Fix common/ includes.
13070         * amd64-fbsd-tdep.c: Fix common/ includes.
13071         * amd64-fbsd-nat.c: Fix common/ includes.
13072         * amd64-dicos-tdep.c: Fix common/ includes.
13073         * amd64-darwin-tdep.c: Fix common/ includes.
13074         * agent.c: Fix common/ includes.
13075         * ada-lang.h: Fix common/ includes.
13076         * ada-lang.c: Fix common/ includes.
13077         * aarch64-tdep.c: Fix common/ includes.
13078
13079 2019-01-25  Tom Tromey  <tom@tromey.com>
13080
13081         * common/create-version.sh: Use common/version.h.
13082
13083 2019-01-24  Pedro Alves  <palves@redhat.com>
13084
13085         * infrun.c (signal_stop, signal_print, signal_program)
13086         (signal_catch, signal_pass): Now arrays instead of pointers.
13087         (update_signals_program_target, do_target_resume)
13088         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13089         * linux-nat.c (linux_nat_target::pass_signals)
13090         (linux_nat_target::create_inferior, linux_nat_target::attach):
13091         Adjust.
13092         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13093         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13094         * procfs.c (procfs_target::pass_signals): Adjust.
13095         * record-full.c (record_full_target::resume): Adjust.
13096         * remote.c (remote_target::pass_signals)
13097         (remote_target::program_signals): Adjust.
13098         * target-debug.h (target_debug_print_signals): Now takes a
13099         gdb::array_view as parameter.  Adjust.
13100         * target.h (target_ops) <pass_signals, program_signals>: Replace
13101         pointer and length parameters with gdb::array_view.
13102         (target_pass_signals, target_program_signals): Likewise.
13103         * target-delegates.c: Regenerate.
13104
13105 2019-01-24  Pedro Alves  <palves@redhat.com>
13106
13107         * common/forward-scope-exit.h
13108         (forward_scope_exit::forward_scope_exit): Pass arguments to
13109         m_bind_function directly, instead of creating a std::bind and
13110         copying that.
13111
13112 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13113
13114         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13115         for static members.
13116         (pass_in_v_vfp_candidate): Likewise.
13117
13118 2019-01-23  Tom Tromey  <tom@tromey.com>
13119             Pedro Alves  <palves@redhat.com>
13120
13121         * regcache.c (class regcache_invalidator): Remove.
13122         (regcache::raw_write): Use make_scope_exit.
13123
13124 2019-01-23  Tom Tromey  <tom@tromey.com>
13125
13126         * ui-out.h (class ui_out_emit_type): Update comment.
13127
13128 2019-01-23  Tom Tromey  <tom@tromey.com>
13129
13130         * infrun.c (fetch_inferior_event): Update comment.
13131
13132 2019-01-23  Tom Tromey  <tom@tromey.com>
13133             Pedro Alves  <palves@redhat.com>
13134
13135         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13136         parameter.
13137         (fetch_inferior_event): Use SCOPE_EXIT.
13138
13139
13140 2019-01-23  Tom Tromey  <tom@tromey.com>
13141             Pedro Alves  <palves@redhat.com>
13142
13143         * infrun.c (disable_thread_events): Delete.
13144         (stop_all_threads): Use SCOPE_EXIT.
13145
13146 2019-01-23  Tom Tromey  <tom@tromey.com>
13147             Pedro Alves  <palves@redhat.com>
13148
13149         * symfile.c: Include forward-scope-exit.h.
13150         (clear_symtab_users_cleanup): Replace forward declaration with
13151         a FORWARD_SCOPE_EXIT.
13152         (syms_from_objfile_1): Use the forward_scope_exit and
13153         gdb::optional instead of cleanup_function.
13154         (reread_symbols): Use the forward_scope_exit instead of
13155         cleanup_function.
13156         (clear_symtab_users_cleanup): Remove function.
13157
13158 2019-01-23  Tom Tromey  <tom@tromey.com>
13159             Pedro Alves  <palves@redhat.com>
13160
13161         * linux-nat.c: Include scope-exit.h.
13162         (cleanup_target_stop): Remove.
13163         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13164         SCOPE_EXIT.
13165
13166 2019-01-23  Tom Tromey  <tom@tromey.com>
13167             Pedro Alves  <palves@redhat.com>
13168
13169         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13170         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13171
13172 2019-01-23  Tom Tromey  <tom@tromey.com>
13173             Andrew Burgess  <andrew.burgess@embecosm.com>
13174             Pedro Alves  <palves@redhat.com>
13175
13176         * infrun.c (fetch_inferior_event): Use scope_exit.
13177         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13178         * top.c (execute_command): Use scope_exit.
13179         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13180         * utils.c (do_bpstat_clear_actions_cleanup)
13181         (make_bpstat_clear_actions_cleanup): Remove.
13182
13183 2019-01-23  Tom Tromey  <tom@tromey.com>
13184             Pedro Alves  <palves@redhat.com>
13185
13186         * infrun.c: Include "common/scope-exit.h"
13187         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13188         (wait_for_inferior): Use SCOPE_EXIT.
13189         (fetch_inferior_event): Use scope_exit.
13190
13191 2019-01-23  Tom Tromey  <tom@tromey.com>
13192             Pedro Alves  <palves@redhat.com>
13193
13194         * breakpoint.c (create_breakpoint): Remove cleanup.
13195
13196 2019-01-23  Tom Tromey  <tom@tromey.com>
13197             Andrew Burgess  <andrew.burgess@embecosm.com>
13198             Pedro Alves  <palves@redhat.com>
13199
13200 2019-01-23  Pedro Alves  <palves@redhat.com>
13201
13202         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13203
13204 2019-01-23  Pedro Alves  <palves@redhat.com>
13205             Andrew Burgess  <andrew.burgess@embecosm.com>
13206
13207         * gdbthread.h: Include "common/forward-scope-exit.h".
13208         (scoped_finish_thread_state): Redefine custom class in terms of
13209         forward_scope_exit.
13210
13211 2019-01-23  Pedro Alves  <palves@redhat.com>
13212             Andrew Burgess  <andrew.burgess@embecosm.com>
13213
13214         * common/forward-scope-exit.h: New file.
13215
13216 2019-01-23  Pedro Alves  <palves@redhat.com>
13217             Andrew Burgess  <andrew.burgess@embecosm.com>
13218             Tom Tromey  <tom@tromey.com>
13219
13220         * common/scope-exit.h: New file.
13221
13222 2019-01-23  Pedro Alves  <palves@redhat.com>
13223
13224         * common/preprocessor.h (ESC): Rename to ...
13225         (ESC_PARENS): ... this.
13226         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13227         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13228
13229 2019-01-23  Tom Tromey  <tom@tromey.com>
13230
13231         * language.h (class scoped_switch_to_sym_language_if_auto):
13232         Initialize m_lang in both cases.
13233
13234 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13235
13236         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13237         with XCNEW.
13238
13239 2019-01-22  Tom Tromey  <tom@tromey.com>
13240
13241         * corelow.c: Do not include sys/file.h.
13242
13243 2019-01-22  Tom Tromey  <tom@tromey.com>
13244
13245         * tui/tui-wingeneral.h: Include gdb_curses.h.
13246
13247 2019-01-22  Tom Tromey  <tom@tromey.com>
13248
13249         * source-cache.h (class source_cache) <get_source_lines,
13250         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13251
13252 2019-01-22  Tom Tromey  <tom@tromey.com>
13253
13254         * remote-fileio.h (struct remote_target): Declare.
13255
13256 2019-01-22  Tom Tromey  <tom@tromey.com>
13257
13258         * python/py-arch.c: Do not include py-ref.h.
13259         * python/py-bpevent.c: Do not include py-ref.h.
13260         * python/py-cmd.c: Do not include py-ref.h.
13261         * python/py-continueevent.c: Do not include py-ref.h.
13262         * python/py-event.h: Do not include py-ref.h.
13263         * python/py-evtregistry.c: Do not include py-ref.h.
13264         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13265         * python/py-frame.c: Do not include py-ref.h.
13266         * python/py-framefilter.c: Do not include py-ref.h.
13267         * python/py-function.c: Do not include py-ref.h.
13268         * python/py-infevents.c: Do not include py-ref.h.
13269         * python/py-linetable.c: Do not include py-ref.h.
13270         * python/py-objfile.c: Do not include py-ref.h.
13271         * python/py-param.c: Do not include py-ref.h.
13272         * python/py-prettyprint.c: Do not include py-ref.h.
13273         * python/py-progspace.c: Do not include py-ref.h.
13274         * python/py-symbol.c: Do not include py-ref.h.
13275         * python/py-symtab.c: Do not include py-ref.h.
13276         * python/py-type.c: Do not include py-ref.h.
13277         * python/py-unwind.c: Do not include py-ref.h.
13278         * python/py-utils.c: Do not include py-ref.h.
13279         * python/py-value.c: Do not include py-ref.h.
13280         * python/py-varobj.c: Do not include py-ref.h.
13281         * python/py-xmethods.c: Do not include py-ref.h.
13282         * python/python.c: Do not include py-ref.h.
13283         * varobj.c: Do not include py-ref.h.
13284
13285 2019-01-22  Tom Tromey  <tom@tromey.com>
13286
13287         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13288         keyword for bcache.
13289
13290 2019-01-22  Tom Tromey  <tom@tromey.com>
13291
13292         * compile/compile-cplus-types.c: Remove a comment by #include.
13293
13294 2019-01-22  Tom Tromey  <tom@tromey.com>
13295
13296         * compile/gcc-c-plugin.h: Include compile-internal.h.
13297
13298 2019-01-22  Tom Tromey  <tom@tromey.com>
13299
13300         * stabsread.c (EXTERN): Do not define.
13301         (symnum, next_symbol_text_func, processing_gcc_compilation)
13302         (within_function, global_sym_chain, global_stabs)
13303         (previous_stab_code, this_object_header_files)
13304         (n_this_object_header_files)
13305         (n_allocated_this_object_header_files): Define.
13306         * stabsread.h (EXTERN): Never define.  Use "extern".
13307
13308 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13309
13310         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13311         history_value.
13312
13313 2019-01-21  Tom Tromey  <tom@tromey.com>
13314
13315         * ui-out.c: Fix includes.
13316         * tui/tui-source.c: Fix includes.
13317         * target.c: Fix includes.
13318         * remote.c: Fix includes.
13319         * regcache.c: Fix includes.
13320         * python/py-block.c: Fix includes.
13321         * printcmd.c: Fix includes.
13322         * or1k-tdep.c: Fix includes.
13323         * mi/mi-main.c: Fix includes.
13324         * m32r-tdep.c: Fix includes.
13325         * csky-tdep.c: Fix includes.
13326         * compile/compile-cplus-types.c: Fix includes.
13327         * cli/cli-interp.c: Fix includes.
13328
13329 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13330
13331         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13332         for padding.
13333
13334 2019-01-16  Tom Tromey  <tom@tromey.com>
13335
13336         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13337         earlier.
13338         (struct objfile) <msymbols_range>: Move from top level.
13339         <msymbols>: New method.
13340         (class objfile_msymbols): Remove.
13341         * symtab.c (default_collect_symbol_completion_matches_break_on):
13342         Update.
13343         * symmisc.c (dump_msymbols): Update.
13344         * stabsread.c (scan_file_globals): Update.
13345         * objc-lang.c (info_selectors_command, info_classes_command)
13346         (find_methods): Update.
13347         * minsyms.c (find_solib_trampoline_target): Update.
13348         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13349         * coffread.c (coff_symfile_read): Update.
13350         * ada-lang.c (ada_lookup_simple_minsym)
13351         (ada_collect_symbol_completion_matches): Update.
13352
13353 2019-01-16  Tom Tromey  <tom@tromey.com>
13354
13355         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13356         type.  Remove no-argument constructor.
13357         <iterator::operator++>: Simplify.
13358         <begin>: Update.
13359         <end>: Use minimal_symbol_count.
13360
13361 2019-01-16  Tom Tromey  <tom@tromey.com>
13362
13363         * objfiles.h (struct objfile) <psymtabs>: New method.
13364         (class objfile_psymtabs): Remove.
13365         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13366         typedef.
13367         <range>: New method.
13368         (require_partial_symbols): Change return type.
13369         * psymtab.c (require_partial_symbols)
13370         (psym_expand_symtabs_matching): Update.
13371         * mdebugread.c (parse_partial_symbols): Update.
13372         * dbxread.c (dbx_end_psymtab): Update.
13373
13374 2019-01-15  Tom Tromey  <tom@tromey.com>
13375
13376         * symtab.c (lookup_objfile_from_block)
13377         (lookup_symbol_in_objfile_symtabs)
13378         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13379         (find_line_symtab, info_sources_command)
13380         (default_collect_symbol_completion_matches_break_on)
13381         (make_source_files_completion_list): Update.
13382         * symmisc.c (print_objfile_statistics, dump_objfile)
13383         (maintenance_print_symbols, maintenance_info_symtabs)
13384         (maintenance_check_symtabs, maintenance_info_line_tables):
13385         Update.
13386         * source.c (select_source_symtab)
13387         (forget_cached_source_info_for_objfile): Update.
13388         * objfiles.h (class objfile_compunits): Remove.
13389         (struct objfile) <compunits_range>: New typedef.
13390         (compunits): New method.
13391         * objfiles.c (objfile_relocate1): Update.
13392         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13393         * maint.c (count_symtabs_and_blocks): Update.
13394         * linespec.c (iterate_over_all_matching_symtabs): Update.
13395         * cp-support.c (add_symbol_overload_list_qualified): Update.
13396         * coffread.c (coff_symtab_read): Update.
13397         * ada-lang.c (add_nonlocal_symbols)
13398         (ada_collect_symbol_completion_matches)
13399         (ada_add_global_exceptions): Update.
13400
13401 2019-01-15  Tom Tromey  <tom@tromey.com>
13402
13403         * progspace.h (program_space) <objfiles_safe_range>: New
13404         typedef.
13405         <objfiles_safe>: New method.
13406         * objfiles.h (class all_objfiles_safe): Remove.
13407         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13408         * jit.c (jit_inferior_exit_hook): Update.
13409
13410 2019-01-17  Tom Tromey  <tom@tromey.com>
13411
13412         * progspace.h (program_space) <objfiles_range>: New typedef.
13413         <objfiles>: New method.
13414         <objfiles_head>: Rename from objfiles.
13415         (object_files): Update.
13416         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13417         * guile/scm-pretty-print.c
13418         (ppscm_find_pretty_printer_from_objfiles): Update.
13419         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13420         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13421         Update.
13422         * python/py-progspace.c (pspy_get_objfiles): Update.
13423         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13424         Update.
13425         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13426         (objfpy_lookup_objfile_by_build_id): Update.
13427         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13428         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13429         Update.
13430         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13431         (expand_symtab_containing_pc, lookup_objfile_from_block)
13432         (lookup_static_symbol, basic_lookup_transparent_type)
13433         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13434         (find_line_symtab, info_sources_command)
13435         (default_collect_symbol_completion_matches_break_on)
13436         (make_source_files_completion_list, find_main_name): Update.
13437         * symmisc.c (print_symbol_bcache_statistics)
13438         (print_objfile_statistics, maintenance_print_symbols)
13439         (maintenance_print_msymbols, maintenance_print_objfiles)
13440         (maintenance_info_symtabs, maintenance_check_symtabs)
13441         (maintenance_expand_symtabs, maintenance_info_line_tables):
13442         Update.
13443         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13444         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13445         (map_overlay_command, unmap_overlay_command)
13446         (simple_overlay_update, expand_symtabs_matching)
13447         (map_symbol_filenames): Update.
13448         * symfile-debug.c (set_debug_symfile): Update.
13449         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13450         Update.
13451         * source.c (select_source_symtab, forget_cached_source_info):
13452         Update.
13453         * solib.c (solib_read_symbols): Update.
13454         * solib-spu.c (append_ocl_sos): Update.
13455         * psymtab.c (maintenance_print_psymbols)
13456         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13457         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13458         * printcmd.c (info_symbol_command): Update.
13459         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13460         Update.
13461         * objfiles.h (class all_objfiles): Remove.
13462         * objfiles.c (have_partial_symbols, have_full_symbols)
13463         (have_minimal_symbols, qsort_cmp, update_section_map)
13464         (shared_objfile_contains_address_p)
13465         (default_iterate_over_objfiles_in_search_order): Update.
13466         * objc-lang.c (info_selectors_command, info_classes_command)
13467         (find_methods): Update.
13468         * minsyms.c (find_solib_trampoline_target): Update.
13469         * maint.c (maintenance_info_sections)
13470         (maintenance_translate_address, count_symtabs_and_blocks):
13471         Update.
13472         * main.c (captured_main_1): Update.
13473         * linux-thread-db.c (try_thread_db_load_from_pdir)
13474         (has_libpthread): Update.
13475         * linespec.c (iterate_over_all_matching_symtabs)
13476         (search_minsyms_for_name): Update.
13477         * jit.c (jit_find_objf_with_entry_addr): Update.
13478         * hppa-tdep.c (find_unwind_entry)
13479         (hppa_lookup_stub_minimal_symbol): Update.
13480         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13481         Update.
13482         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13483         (elf_gnu_ifunc_resolve_by_got): Update.
13484         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13485         * dwarf-index-write.c (save_gdb_index_command): Update.
13486         * cp-support.c (add_symbol_overload_list_qualified): Update.
13487         * breakpoint.c (create_overlay_event_breakpoint)
13488         (create_longjmp_master_breakpoint)
13489         (create_std_terminate_master_breakpoint)
13490         (create_exception_master_breakpoint): Update.
13491         * blockframe.c (find_pc_partial_function): Update.
13492         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13493         (ada_collect_symbol_completion_matches)
13494         (ada_add_global_exceptions): Update.
13495
13496 2019-01-17  Tom Tromey  <tom@tromey.com>
13497
13498         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13499         declare VEC.
13500         (solib_target_parse_libraries): Change return type.
13501         (library_list_start_segment, library_list_start_section)
13502         (library_list_end_library, library_list_start_library); Update.
13503         (solib_target_free_library_list): Remove.
13504         (solib_target_parse_libraries): Remove cleanup.  Change return
13505         type.
13506         (solib_target_current_sos): Update.
13507
13508 2019-01-17  Tom Tromey  <tromey@bapiya>
13509
13510         * valprint.c: Replace "the the" with "the".
13511         * symtab.c: Replace "the the" with "the".
13512         * solib.c: Replace "the the" with "the".
13513         * solib-dsbt.c: Replace "the the" with "the".
13514         * linespec.c: Replace "the the" with "the".
13515         * dwarf2loc.h: Replace "the the" with "the".
13516         * amd64-windows-tdep.c: Replace "the the" with "the".
13517         * aarch64-tdep.c: Replace "the the" with "the".
13518
13519 2019-01-16  Keith Seitz  <keiths@redhat.com>
13520
13521         PR gdb/23773
13522         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13523         <builder>: Rename to ..
13524         <m_builder>: ... this and make private.
13525         (dwarf2_cu::get_builder): New method.  Change all users of
13526         `builder' to use this method.
13527         (dwarf2_start_symtab): Move to ...
13528         (dwarf2_cu::start_symtab): ... here.  Update all callers
13529         (setup_type_unit_groups): Move to ...
13530         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13531         callers.
13532         (dwarf2_cu::reset_builder): New method.
13533         (process_full_compunit, process_full_type_unit): Use
13534         dwarf2_cu::reset_builder.
13535         (follow_die_offset): Record the ancestor CU if it is different
13536         from the followed DIE's CU.
13537         (follow_die_sig_1): Likewise.
13538
13539 2019-01-15  Tom Tromey  <tom@tromey.com>
13540
13541         * remote.c (class remote_state) <buf>: Now a char_vector.
13542         <buf_size>: Remove.
13543         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13544         parameter.
13545         (remote_target::getpkt_or_notif_sane_1)
13546         (remote_target::getpkt_sane)
13547         (remote_target::getpkt_or_notif_sane): Likewise.
13548         (class remote_target) <putpkt>: New overload.
13549         (remote_target::read_frame): Change type of "buf_p".  Remove
13550         sizeof_p parameter.
13551         (packet_ok): New overload.
13552         (packet_check_result): New overload.
13553         Update all uses.
13554
13555 2019-01-14  Tom Tromey  <tom@tromey.com>
13556
13557         * remote-notif.c (handle_notification, remote_notif_ack)
13558         (remote_notif_parse): Make "buf" const.
13559         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13560         const.
13561         (remote_notif_parse, remote_notif_ack, handle_notification):
13562         Likewise.
13563         * remote.c (remote_notif_stop_parse): Make "buf" const.
13564         (remote_target::remote_parse_stop_reply): Make "buf" const.
13565         (remote_notif_stop_ack): Make "buf" const.
13566
13567 2019-01-14  Tom Tromey  <tom@tromey.com>
13568
13569         * remote.c (remote_console_output): Make parameter const.
13570
13571 2019-01-14  Tom Tromey  <tom@tromey.com>
13572
13573         * target-debug.h (target_debug_print_signals): Constify.
13574         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13575         * procfs.c (procfs_target::pass_signals): Update.
13576         * linux-nat.c (linux_nat_target::pass_signals): Update.
13577         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13578         * target-delegates.c: Rebuild.
13579         * remote.c (remote_target::program_signals): Update.
13580         (remote_target::pass_signals): Update.
13581         * target.c (target_pass_signals): Constify argument.
13582         (target_program_signals): Likewise.
13583         * target.h (struct target_ops) <pass_signals, program_signals>:
13584         Constify argument.
13585         (target_pass_signals, target_program_signals): Constify argument.
13586
13587 2019-01-14  Tom Tromey  <tom@tromey.com>
13588
13589         PR tui/28819:
13590         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13591
13592 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13593
13594         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13595         field.
13596         * rs6000-tdep.c: Include reggroups.h.
13597         (IS_V_ALIAS_PSEUDOREG): Define.
13598         (rs6000_register_name): Return names for the "vX" aliases.
13599         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13600         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13601         aliases.  Call default_register_reggroup_p for all other
13602         pseudo-registers.
13603         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13604         New functions.
13605         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13606         Handle "vX" aliases.
13607         (v_alias_pseudo_register_collect): New function.
13608         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13609         (rs6000_gdbarch_init): Initialize "vX" aliases as
13610         pseudo-registers.  Restore registration of
13611         rs6000_pseudo_register_reggroup_p with
13612         set_tdesc_pseudo_register_reggroup_p.
13613
13614 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13615
13616         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13617         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13618         set_gdbarch_num_pseudo_regs.
13619
13620 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13621
13622         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13623         Remove arg prefixname, add do_set and do_show.
13624         Add member functions set_list and show_list.
13625         * cli/cli-style.c (class cli_style_option): Update accordingly.
13626         (style_set_list): Move to file scope.
13627         (style_show_list): Likewise.
13628         (set_style): Call help_list.
13629         (show_style): Call cmd_show_list.
13630         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13631         Update to use the new macro.
13632
13633 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13634
13635         * ada-lang.c (_initialize_ada_language): Expand the help text
13636         for the "catch exception" command.
13637
13638 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13639
13640         * symtab.c (matching_obj_sections): Initialize obj,
13641         declare it closer to its usage.
13642
13643 2019-01-10  Tom Tromey  <tom@tromey.com>
13644
13645         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13646         (basic_inf_threads_range): Remove.
13647         (inf_threads_range, inf_non_exited_threads_range)
13648         (safe_inf_threads_range): Use next_adapter.
13649
13650 2019-01-10  Keith Seitz  <keiths@redhat.com>
13651
13652         PR gdb/23712
13653         PR symtab/23010
13654         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13655         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13656
13657 2019-01-10  Keith Seitz  <keiths@redhat.com>
13658
13659         PR gdb/23712
13660         PR symtab/23010
13661         * dictionary.c (pending_to_vector): Remove.
13662         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13663         Remove _1 suffix, replacing functions of the same name.  Update
13664         all callers.
13665         (dict_create_hashed, dict_create_hashed_expandable)
13666         (dict_create_linear, dict_create_linear_expandable, dict_free)
13667         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13668         Make functions static.
13669
13670 2019-01-10  Keith Seitz  <keiths@redhat.com>
13671
13672         PR gdb/23712
13673         PR symtab/23010
13674         * dictionary.h (struct dictionary): Replace declaration with
13675         multidictionary.
13676         (dict_create_hashed, dict_create_hashed_expandable)
13677         (dict_create_linear, dict_create_linear_expandable)
13678         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13679         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13680         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13681         taking multidictionary argument.
13682         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13683         * block.h (struct block) <dict>: Change to multidictionary
13684         and rename `multidict'.
13685         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13686         symmisc.c: Update all dictionary references to multidictionary.
13687
13688 2019-01-10  Keith Seitz  <keiths@redhat.com>
13689
13690         PR gdb/23712
13691         PR symtab/23010
13692         * dictionary.c: Include unordered_map.
13693         (pending_to_vector): New function.
13694         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13695         Rewrite the non-"_1" functions to take vector instead
13696         of linked list.
13697         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13698         "new" _1 versions of the same name.
13699         (multidictionary): Define.
13700         (std::hash<enum language): New definition.
13701         (collate_pending_symbols_by_language, mdict_create_hashed)
13702         (mdict_create_hashed_expandable, mdict_create_linear)
13703         (mdict_create_linear_expandable, mdict_free)
13704         (find_language_dictionary, create_new_language_dictionary)
13705         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13706         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13707         (mdict_size, mdict_empty): New functions.
13708         * dictionary.h (mdict_iterator): Define.
13709
13710 2019-01-10  Pedro Alves  <palves@redhat.com>
13711
13712         * breakpoint.c (read_uploaded_action)
13713         (create_tracepoint_from_upload): Adjust to use
13714         gdb::unique_xmalloc_ptr.
13715         * ctf.c (ctf_write_uploaded_tp):
13716         (SET_ARRAY_FIELD): Use emplace_back.
13717         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13718         * tracefile-tfile.c (tfile_write_uploaded_tp):
13719         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13720         gdb::unique_xmalloc_ptr.
13721         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13722         at_string, cond_string, cmd_strings>: Replace char pointers
13723         with gdb::unique_xmalloc_ptr.
13724
13725 2019-01-10  Pedro Alves  <palves@redhat.com>
13726
13727         * solib-target.c (library_list_start_library): Don't xstrdup name.
13728
13729 2019-01-10  Pedro Alves  <palves@redhat.com>
13730
13731         * mdebugread.c (parse_partial_symbols): Use
13732         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13733
13734 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13735
13736         * linux-fork.c (scoped_switch_fork_info)
13737         <~scoped_switch_fork_info>: Fix incorrect variable name.
13738
13739 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13740
13741         * linux-fork.c (scoped_switch_fork_info)
13742         <scoped_switch_fork_info>: Make explicit.
13743         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13744
13745 2019-01-10  Tom Tromey  <tom@tromey.com>
13746
13747         * objfiles.h (objfile::reset_psymtabs): Update.
13748         * objfiles.c (objfile::objfile): Update.
13749         * psymtab.h (psymtab_storage::obstack): Update.
13750         (psymtab_storage::m_obstack): Use gdb::optional.
13751         (class psymtab_storage): Update comment.  Remove objfile
13752         parameter.
13753         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13754
13755 2019-01-10  Tom Tromey  <tom@tromey.com>
13756
13757         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13758         <free_psymtabs>: Now private.
13759         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13760         (allocate_psymtab): Use new method.
13761
13762 2019-01-10  Tom Tromey  <tom@tromey.com>
13763
13764         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13765         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13766         * mdebugread.c (parse_partial_symbols): Use
13767         allocate_dependencies.
13768         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13769         allocate_dependencies.
13770         (process_psymtab_comp_unit_reader)
13771         (build_type_psymtab_dependencies): Likewise.
13772         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13773
13774 2019-01-10  Tom Tromey  <tom@tromey.com>
13775
13776         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13777         PSYMBOL_SET_LANGUAGE.
13778         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13779
13780 2019-01-10  Tom Tromey  <tom@tromey.com>
13781
13782         * psymtab.h (psymtab_storage::obstack): New method.
13783         <m_obstack>: Rename from obstack; now private.
13784         * psymtab.c (psymtab_storage): Update.
13785         * dwarf2read.c (create_addrmap_from_index)
13786         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13787         Update.
13788
13789 2019-01-10  Tom Tromey  <tom@tromey.com>
13790
13791         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13792         * objfiles.h (objfile::reset_psymtabs): New method.
13793
13794 2019-01-10  Tom Tromey  <tom@tromey.com>
13795
13796         * symmisc.c (print_symbol_bcache_statistics): Update.
13797         (print_objfile_statistics): Update.
13798         * symfile.c (reread_symbols): Update.
13799         * psymtab.h (class psymtab_storage): New.
13800         * psymtab.c (psymtab_storage): New constructor.
13801         (~psymtab_storage): New destructor.
13802         (require_partial_symbols): Update.
13803         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13804         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13805         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13806         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13807         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13808         (start_psymtab_common, end_psymtab_common)
13809         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13810         (allocate_psymtab): Update.
13811         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13812         Update.
13813         (dump_psymtab_addrmap, maintenance_print_psymbols)
13814         (maintenance_check_psymtabs): Update.
13815         (class objfile_psymtabs): Move to objfiles.h.
13816         * psympriv.h (discard_psymtab): Now inline.
13817         (psymtab_discarder::psymtab_discarder): Update.
13818         (psymtab_discarder::~psymtab_discarder): Update.
13819         (ALL_OBJFILE_PSYMTABS): Rewrite.
13820         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13821         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13822         Remove fields.
13823         <partial_symtabs>: New field.
13824         (class objfile_psymtabs): Move from psymtab.h.  Update.
13825         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13826         psymbol_cache.
13827         (objfile::~objfile): Don't destroy psymbol_cache.
13828         * mdebugread.c (parse_partial_symbols): Update.
13829         * dwarf2read.c (create_addrmap_from_index)
13830         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13831         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13832         (add_partial_subprogram, dwarf2_ranges_read): Update.
13833         * dwarf-index-write.c (write_address_map)
13834         (write_one_signatured_type, recursively_write_psymbols)
13835         (class debug_names, class debug_names, write_psymtabs_to_index):
13836         Update.
13837
13838 2019-01-10  Tom Tromey  <tom@tromey.com>
13839
13840         * symtab.h (SYMBOL_SET_NAMES): Update.
13841         (symbol_set_names): Update.
13842         (MSYMBOL_SET_NAMES): Update.
13843         * symtab.c (symbol_set_names): Change argument to be an
13844         objfile_per_bfd_storage.
13845         * psymtab.c (add_psymbol_to_bcache): Update.
13846         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13847
13848 2019-01-10  Tom Tromey  <tom@tromey.com>
13849
13850         * symtab.c (create_demangled_names_hash): Change argument to be an
13851         objfile_per_bfd_storage.
13852         (symbol_set_names): Update.
13853
13854 2019-01-10  Tom Tromey  <tom@tromey.com>
13855
13856         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13857         init_psymbol_list.
13858         * psymtab.c (init_psymbol_list): Do nothing if already called.
13859         * psympriv.h (init_psymbol_list): Add comment.
13860         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13861         init_psymbol_list.
13862         * dbxread.c (dbx_symfile_read): Unconditionally call
13863         init_psymbol_list.
13864
13865 2019-01-10  Tom Tromey  <tom@tromey.com>
13866
13867         * xcoffread.c (scan_xcoff_symtab): Update.
13868         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13869         "where".
13870         * mdebugread.c (parse_partial_symbols)
13871         (handle_psymbol_enumerators): Update.
13872         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13873         * dbxread.c (read_dbx_symtab): Update.
13874         * psympriv.h (psymbol_placement): New enum.
13875         (add_psymbol_to_list): Update.
13876
13877 2019-01-10  Tom Tromey  <tom@tromey.com>
13878
13879         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13880         static_psymbols parameters.
13881         (scan_xcoff_symtab): Update.
13882         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13883         static_psymbols parameters.
13884         * psympriv.h (start_psymtab_common): Update.
13885         * mdebugread.c (parse_partial_symbols): Update.
13886         * dwarf2read.c (create_partial_symtab): Update.
13887         * dbxread.c (read_dbx_symtab): Update.
13888         (start_psymtab): Remove global_psymbols and static_psymbols
13889         parameters.
13890
13891 2019-01-10  Tom Tromey  <tom@tromey.com>
13892
13893         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13894         * psymtab.c (allocate_psymtab): Add comment.
13895         * psympriv.h (allocate_psymtab): Add comment.
13896         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13897         initializations.
13898         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13899
13900 2019-01-10  Tom Tromey  <tom@tromey.com>
13901
13902         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13903         Don't declare.
13904         * mipsread.c: Include mdebugread.h.
13905         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13906         Declare.
13907         * elfread.c: Include mdebugread.h.
13908
13909 2019-01-09  Tom Tromey  <tom@tromey.com>
13910
13911         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13912         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13913         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13914         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13915         (psym_lookup_symbol, psym_find_last_source_symtab)
13916         (psym_forget_cached_source_info, psym_print_stats)
13917         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13918         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13919         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13920         (psym_find_compunit_symtab_by_address)
13921         (maintenance_print_psymbols, maintenance_info_psymtabs)
13922         (maintenance_check_psymtabs): Use ranged for.
13923         * psymtab.h (class objfile_psymtabs): New.
13924         (require_partial_symbols): Return objfile_psymtabs.
13925         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13926
13927 2019-01-09  Tom Tromey  <tom@tromey.com>
13928
13929         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13930         (find_pc_mapped_section, list_overlays_command)
13931         (map_overlay_command, unmap_overlay_command)
13932         (simple_overlay_update): Use all_objfiles.
13933         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13934         * printcmd.c (info_symbol_command): Use all_objfiles.
13935         * objfiles.h (ALL_OBJSECTIONS): Remove.
13936         * maint.c (maintenance_translate_address): Use all_objfiles.
13937         * gcore.c (gcore_create_callback): Use all_objfiles.
13938         (objfile_find_memory_regions): Likewise.
13939
13940 2019-01-09  Tom Tromey  <tom@tromey.com>
13941
13942         * symtab.c (find_line_symtab, info_sources_command)
13943         (make_source_files_completion_list): Use objfile_compunits.
13944         * source.c (select_source_symtab): Use objfile_compunits.
13945         * objfiles.h (struct objfile): Update comment.
13946         (ALL_OBJFILES): Remove.
13947         (ALL_FILETABS): Remove.
13948         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13949         objfile_compunits.
13950
13951 2019-01-09  Tom Tromey  <tom@tromey.com>
13952
13953         * symmisc.c (print_objfile_statistics, dump_objfile)
13954         (maintenance_print_symbols): Use compunit_filetabs.
13955         * source.c (forget_cached_source_info_for_objfile): Use
13956         compunit_filetabs.
13957         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13958         (ALL_FILETABS): Use compunit_filetabs.
13959         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13960         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13961
13962 2019-01-09  Tom Tromey  <tom@tromey.com>
13963
13964         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13965         (compunit_filetabs): New.
13966         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13967         compunit_filetabs.
13968         (info_sources_command, make_source_files_completion_list): Remove
13969         declaration.
13970         * symmisc.c (print_objfile_statistics, dump_objfile)
13971         (maintenance_print_symbols): Remove declaration.
13972         (maintenance_info_symtabs): Use compunit_filetabs.
13973         (maintenance_info_line_tables): Likewise.
13974         * source.c (select_source_symtab): Change local variable name.
13975         (forget_cached_source_info_for_objfile): Remove declaration.
13976         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13977         * objfiles.c (objfile_relocate1): Remove declaration.
13978         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13979         declaration.
13980         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13981         * coffread.c (coff_symtab_read): Remove declaration.
13982         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13983         compunit_filetabs.
13984
13985 2019-01-09  Tom Tromey  <tom@tromey.com>
13986
13987         * symtab.c (lookup_objfile_from_block)
13988         (find_pc_sect_compunit_symtab, search_symbols)
13989         (default_collect_symbol_completion_matches_break_on): Use
13990         objfile_compunits.
13991         * objfiles.h (ALL_COMPUNITS): Remove.
13992         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13993         * cp-support.c (add_symbol_overload_list_qualified): Use
13994         objfile_compunits.
13995         * ada-lang.c (ada_collect_symbol_completion_matches)
13996         (ada_add_global_exceptions): Use objfile_compunits.
13997
13998 2019-01-09  Tom Tromey  <tom@tromey.com>
13999
14000         * source.c (select_source_symtab)
14001         (forget_cached_source_info_for_objfile): Remove declaration.
14002         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14003         declaration.
14004         * maint.c (count_symtabs_and_blocks): Remove declaration.
14005         * cp-support.c (add_symbol_overload_list_qualified): Remove
14006         declaration.
14007         * coffread.c (coff_symtab_read): Remove declaration.
14008         * symtab.c (lookup_symbol_in_objfile_symtabs)
14009         (basic_lookup_transparent_type_1): Use objfile_compunits.
14010         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14011         (info_sources_command, search_symbols)
14012         (default_collect_symbol_completion_matches_break_on)
14013         (make_source_files_completion_list): Remove declaration.
14014         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14015         (ada_collect_symbol_completion_matches)
14016         (ada_add_global_exceptions): Remove declaration.
14017         * linespec.c (iterate_over_all_matching_symtabs): Use
14018         objfile_compunits.
14019         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14020         (class objfile_compunits): New.
14021         (ALL_COMPUNITS): Use objfile_compunits.
14022         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14023         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14024         objfile_compunits.
14025         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14026
14027 2019-01-09  Tom Tromey  <tom@tromey.com>
14028
14029         * symtab.c (search_symbols)
14030         (default_collect_symbol_completion_matches_break_on): Use
14031         objfile_msymbols.
14032         * ada-lang.c (ada_lookup_simple_minsym)
14033         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14034         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14035         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14036         objfile_msymbols.
14037         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14038         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14039         * objc-lang.c (find_methods): Use objfile_msymbols.
14040         (info_selectors_command, info_classes_command): Likewise.
14041         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14042         * objfiles.h (class objfile_msymbols): New.
14043         (ALL_OBJFILE_MSYMBOLS): Remove.
14044         (ALL_MSYMBOLS): Remove.
14045
14046 2019-01-09  Tom Tromey  <tom@tromey.com>
14047
14048         * common/next-iterator.h (next_adapter): Add Iterator template
14049         parameter.
14050         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14051         (class all_objfiles_safe): New.
14052         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14053         * objfiles.c (put_objfile_before): Update comment.
14054         (add_separate_debug_objfile): Likewise.
14055         (free_all_objfiles): Use all_objfiles_safe.
14056         (objfile_purge_solibs): Likewise.
14057
14058 2019-01-09  Tom Tromey  <tom@tromey.com>
14059
14060         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14061         (expand_symtab_containing_pc, lookup_static_symbol)
14062         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14063         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14064         all_objfiles.
14065         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14066         * breakpoint.c (create_overlay_event_breakpoint)
14067         (create_longjmp_master_breakpoint)
14068         (create_std_terminate_master_breakpoint)
14069         (create_exception_master_breakpoint): Use all_objfiles.
14070         * linux-thread-db.c (try_thread_db_load_from_pdir)
14071         (has_libpthread): Use all_objfiles.
14072         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14073         * linespec.c (iterate_over_all_matching_symtabs)
14074         (search_minsyms_for_name): Use all_objfiles.
14075         * maint.c (maintenance_info_sections): Use all_objfiles.
14076         * main.c (captured_main_1): Use all_objfiles.
14077         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14078         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14079         * guile/scm-pretty-print.c
14080         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14081         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14082         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14083         (maintenance_print_msymbols): Use all_objfiles.
14084         * source.c (select_source_symtab): Use all_objfiles.
14085         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14086         * symfile.c (remove_symbol_file_command)
14087         (expand_symtabs_matching, map_symbol_filenames): Use
14088         all_objfiles.
14089         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14090         all_objfiles.
14091         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14092         * objc-lang.c (find_methods): Use all_objfiles.
14093         * objfiles.c (have_partial_symbols, have_full_symbols)
14094         (have_minimal_symbols, qsort_cmp)
14095         (default_iterate_over_objfiles_in_search_order): Use
14096         all_objfiles.
14097         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14098         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14099         (maintenance_check_psymtabs): Use all_objfiles.
14100         (ALL_PSYMTABS): Remove.
14101         * compile/compile-object-run.c (do_module_cleanup): Use
14102         all_objfiles.
14103         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14104         * cp-support.c (add_symbol_overload_list_qualified): Use
14105         all_objfiles.
14106         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14107         Use all_objfiles.
14108         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14109         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14110         all_objfiles.
14111         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14112         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14113         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14114         Uses all_objfiles.
14115         * solib.c (solib_read_symbols): Use all_objfiles
14116
14117 2019-01-09  Tom Tromey  <tom@tromey.com>
14118
14119         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14120         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14121         all_objfiles.
14122         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14123         * symmisc.c (print_symbol_bcache_statistics)
14124         (print_objfile_statistics, maintenance_print_objfiles)
14125         (maintenance_info_symtabs, maintenance_check_symtabs)
14126         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14127         all_objfiles.
14128         * source.c (forget_cached_source_info): Use all_objfiles.
14129         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14130         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14131         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14132         * objfiles.c (update_section_map): Use all_objfiles.
14133         (shared_objfile_contains_address_p): Likewise.
14134         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14135         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14136
14137 2019-01-09  Tom Tromey  <tom@tromey.com>
14138
14139         * common/next-iterator.h: New file.
14140         * objfiles.h (class all_objfiles): New.
14141         (struct objfile_iterator): New.
14142
14143 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14144
14145         * NEWS: Move the description of the changed "frame", "select-frame",
14146          and "info frame" commands to the Changed commands section.
14147
14148 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14149
14150         * gdbtypes.c (check_stub_method_group): Remove handling of old
14151         mangling schemes.
14152         * linespec.c (find_methods): Likewise.
14153         * stabsread.c (read_member_functions): Likewise.
14154         * valops.c (search_struct_method): Likewise.
14155         (value_struct_elt_for_reference): Likewise.
14156         * NEWS: Mention this change.
14157
14158 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14159
14160         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14161         print_source_lines.
14162         * source.c (print_source_lines_base): Update line number check.
14163         (print_source_lines): New function.
14164         (source_lines_range::source_lines_range): New function.
14165         * source.h (class source_lines_range): New class.
14166         (print_source_lines): New declaration.
14167
14168 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14169
14170         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14171
14172 2019-01-08  Tom Tromey  <tom@tromey.com>
14173             Simon Marchi  <simon.marchi@ericsson.com>
14174
14175         PR gdb/24060
14176         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14177         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14178         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14179         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14180         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14181         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14182
14183 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14184
14185         * source.c (select_source_symtab): Move header comment to
14186         declaration in source.h.
14187         (forget_cached_source_info_for_objfile): Likewise.
14188         (forget_cached_source_info): Likewise.
14189         (identify_source_line): Likewise.
14190         * source.h (identify_source_line): Move declaration from symtab.h
14191         and add comment from source.c
14192         (print_source_lines): Likewise.
14193         (forget_cached_source_info_for_objfile): Likewise.
14194         (forget_cached_source_info): Likewise.
14195         (select_source_symtab): Likewise.
14196         (enum print_source_lines_flag): Move definition from symtab.h.
14197         * symtab.h (identify_source_line): Move declaration to source.h.
14198         (print_source_lines): Likewise.
14199         (forget_cached_source_info_for_objfile): Likewise.
14200         (forget_cached_source_info): Likewise.
14201         (select_source_symtab): Likewise.
14202         (enum print_source_lines_flag): Move definition to source.h.
14203         * tui/tui-hooks.c: Add 'source.h' include.
14204
14205 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14206
14207         * source.c (print_source_lines_base): Handle requests to print
14208         reverse line number sequences, and guard against empty lines
14209         string.
14210
14211 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14212
14213         * source.c (print_source_lines_base): Fix skip of '\r' if next
14214         character is '\n'.
14215
14216 2019-01-06  Tom Tromey  <tom@tromey.com>
14217
14218         * c-exp.y (struct c_parse_state) <macro_original_text,
14219         expansion_obstack>: New member.
14220         (macro_original_text, expansion_obstack): Remove globals.
14221         (scan_macro_expansion, scanning_macro_expansion)
14222         (finished_macro_expansion): Update.
14223         (scan_macro_cleanup): Remove.
14224         (yylex, c_parse): Update.
14225
14226 2019-01-06  Tom Tromey  <tom@tromey.com>
14227
14228         * c-exp.y (struct c_parse_state) <strings>: New member.
14229         (operator_stoken): Update.
14230
14231 2019-01-06  Tom Tromey  <tom@tromey.com>
14232
14233         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14234         (union type_stack_elt) <typelist_val>: Now a pointer to
14235         std::vector.
14236         (type_stack_cleanup): Don't declare.
14237         (push_typelist): Update.
14238         * parse.c (pop_typelist): Return a std::vector.
14239         (push_typelist): Take a std::vector.
14240         (follow_types): Update.  Do not free args.
14241         (type_stack_cleanup): Remove.
14242         * c-exp.y (struct c_parse_state): New.
14243         (cpstate): New global.
14244         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14245         (nonempty_typelist): Update.
14246         (func_mod): Create a new vector.
14247         (c_parse): Create a c_parse_state.
14248         (check_parameter_typelist): Do not delete params.
14249         (function_method): Update.  Do not delete type_list.
14250
14251 2019-01-06  Tom Tromey  <tom@tromey.com>
14252
14253         PR gdb/28155:
14254         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14255         check_typedef.
14256         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14257         (print_return_value): Likewise.
14258
14259 2019-01-05  Tom Tromey  <tom@tromey.com>
14260
14261         * contrib/cleanup_check.py: Remove.
14262         * contrib/gcc-with-excheck: Remove.
14263         * contrib/exsummary.py: Remove.
14264         * contrib/excheck.py: Remove.
14265
14266 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14267
14268         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14269         NULL. Initialize tpprev to NULL instead of assigning it
14270         to NULL on the next statement.
14271         * windows-nat.c (windows_delete_thread): Remove check for
14272         main_thread_id before printing thread exit notifications.
14273         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14274         Remove thread ID check against main_thread_id.
14275         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14276         windows_delete_thread.
14277         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14278
14279 2019-01-04  Tom Tromey  <tom@tromey.com>
14280
14281         * compile/compile.c (_initialize_compile): Use upper case for
14282         metasyntactic variables.
14283         * symmisc.c (_initialize_symmisc): Use upper case for
14284         metasyntactic variables.
14285         * psymtab.c (_initialize_psymtab): Use upper case for
14286         metasyntactic variables.
14287         * demangle.c (demangle_command): Use upper case for metasyntactic
14288         variables.
14289         (_initialize_demangler): Likewise.
14290         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14291         variables.
14292
14293 2019-01-03  Tom Tromey  <tom@tromey.com>
14294
14295         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14296
14297 2019-01-03  Tom Tromey  <tom@tromey.com>
14298
14299         * python/py-symtab.c (salpy_str): Update.
14300         (struct salpy_sal_object) <symtab>: Now a PyObject.
14301         (salpy_dealloc): Update.
14302         (del_objfile_sal): Use gdbpy_ref.
14303
14304 2019-01-03  Tom Tromey  <tom@tromey.com>
14305
14306         * python/py-type.c (convert_field): Use new_reference.  Return
14307         gdbpy_ref.
14308         (make_fielditem): Return gdbpy_ref.
14309         (typy_fields): Update.
14310         (typy_getitem): Update.
14311         (field_name): Return gdbpy_ref.  Use new_reference.
14312         (typy_iterator_iternext): Update.
14313
14314 2019-01-03  Tom Tromey  <tom@tromey.com>
14315
14316         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14317
14318 2019-01-03  Tom Tromey  <tom@tromey.com>
14319
14320         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14321         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14322         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14323         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14324         (pspy_set_type_printers): Likewise.
14325         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14326         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14327         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14328         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14329         (objfpy_set_type_printers): Likewise.
14330
14331 2019-01-03  Tom Tromey  <tom@tromey.com>
14332
14333         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14334         (gdbpy_print_stack): Use gdbpy_err_fetch.
14335         * python/python-internal.h (class gdbpy_err_fetch): New class.
14336         (class gdbpy_enter) <m_error_type, m_error_value,
14337         m_error_traceback>: Remove.
14338         <m_error>: New member.
14339         (gdbpy_exception_to_string): Don't declare.
14340         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14341         * python/py-value.c (convert_value_from_python): Use
14342         gdbpy_err_fetch.
14343         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14344         gdbpy_exception_to_string.
14345         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14346         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14347         gdbpy_err_fetch.
14348
14349 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14350
14351         * linux-nat.c (delete_lwp_cleanup): Delete.
14352         (struct lwp_deleter): New struct.
14353         (lwp_info_up): New typedef.
14354         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14355         lwp_info_up.
14356
14357 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14358
14359         * linux-fork.c (class scoped_switch_fork_info): New class.
14360         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14361
14362 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14363
14364         * valops.c (find_overload_match): Remove use of null_cleanup, and
14365         calls to do_cleanups.
14366
14367 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14368
14369         * compile/compile-cplus-types.c
14370         (compile_cplus_instance::decl_name): Handle changes to
14371         cp_func_name.
14372         * cp-support.c (cp_func_name): Update header comment, update
14373         return type.
14374         * cp-support.h (cp_func_name): Update return type in declaration.
14375         * valops.c (find_overload_match): Move temp_func local to top
14376         level of function and change its type.  Use temp_func to hold and
14377         delete temporary string obtained from cp_func_name.
14378
14379 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14380
14381         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14382         gdb::char_vector, remove cleanup, and update uses of `msg`.
14383
14384 2019-01-03  Jim Wilson  <jimw@sifive.com>
14385
14386         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14387
14388 2019-01-02  Tom Tromey  <tom@tromey.com>
14389
14390         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14391         (tdesc_parse_xml): Remove cleanups.
14392         * target-descriptions.h (make_cleanup_free_target_description):
14393         Don't declare.
14394         (target_desc_deleter): New struct.
14395         (target_desc_up): New typedef.
14396         * target-descriptions.c (target_desc_deleter::operator()): Rename
14397         from free_target_description.
14398         (make_cleanup_free_target_description): Remove.
14399
14400 2019-01-02  Tom Tromey  <tom@tromey.com>
14401
14402         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14403         constructor, destructor.
14404         (linespec_parser): Remove typedef.
14405         (~linespec_parser): Rename from linespec_parser_delete.
14406         (linespec_lex_to_end, linespec_complete_label)
14407         (linespec_complete): Update.
14408         (decode_line_full): Remove cleanups.
14409         (decode_line_1): Update.
14410
14411 2019-01-02  Tom Tromey  <tom@tromey.com>
14412
14413         * python/python-internal.h (inferior_to_inferior_object): Change
14414         return type.
14415         * python/py-exitedevent.c (create_exited_event_object): Update.
14416         * python/py-inferior.c (inferior_to_inferior_object): Return
14417         gdbpy_ref.
14418         (python_new_inferior, python_inferior_deleted)
14419         (thread_to_thread_object, delete_thread_object)
14420         (build_inferior_list, gdbpy_selected_inferior): Update.
14421         * python/py-infthread.c (create_thread_object): Update.  Also fail
14422         if inferior_to_inferior_object fails.
14423
14424 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14425
14426         * inferior.h (class inferior) <displaced_step_state>: New field.
14427         * infrun.h (struct displaced_step_state): Move here from
14428         infrun.c.  Initialize fields, add constructor.
14429         <inf>: Remove field.
14430         <reset>: New method.
14431         * infrun.c (struct displaced_step_inferior_state): Move to
14432         infrun.h.
14433         (displaced_step_inferior_states): Remove.
14434         (get_displaced_stepping_state): Adust.
14435         (displaced_step_in_progress_any_inferior): Adjust.
14436         (displaced_step_in_progress_thread): Adjust.
14437         (displaced_step_in_progress): Adjust.
14438         (add_displaced_stepping_state): Remove.
14439         (get_displaced_step_closure_by_addr): Adjust.
14440         (remove_displaced_stepping_state): Remove.
14441         (infrun_inferior_exit): Call displaced_step_state.reset.
14442         (use_displaced_stepping): Don't check for NULL.
14443         (displaced_step_prepare_throw): Call
14444         get_displaced_stepping_state.
14445         (displaced_step_fixup): Don't check for NULL.
14446         (prepare_for_detach): Don't check for NULL.
14447
14448 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14449
14450         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14451          in case of call that did not complete.
14452
14453 2019-01-02  Andrey Utkin  <autkin@undo.io>
14454
14455         * symfile.c (find_separate_debug_file): Fix search of debug files for
14456         remote debuggee.
14457
14458 2019-01-02  Tom Tromey  <tom@tromey.com>
14459
14460         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14461         indentation.
14462         * python/py-frame.c (frapy_older): Remove cast.
14463         (frapy_newer): Likewise.
14464         * python/py-breakpoint.c (local_setattro): Remove cast.
14465         * python/py-arch.c (archpy_name): Remove local variable.
14466         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14467
14468 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14469
14470         * unittests/basic_string_view/element_access/char/empty.cc:
14471         Fix year range in copyright header.
14472
14473 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14474
14475         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14476         Delete.
14477         <operator==>: Update with for removed field.
14478         <hash>: Likewise.
14479         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14480         <isa_features>: ...this.
14481         <abi_features>: New field.
14482         (riscv_isa_flen): Update comment.
14483         (riscv_abi_xlen): New declaration.
14484         (riscv_abi_flen): New declaration.
14485         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14486         isa_features.
14487         (riscv_abi_xlen): New function.
14488         (riscv_isa_flen): Update to get answer from isa_features.
14489         (riscv_abi_flen): New function.
14490         (riscv_has_fp_abi): Update to get answer from abi_features.
14491         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14492         xlen and flen.
14493         (riscv_call_info) <xlen, flen>: Update comment.
14494         (riscv_call_arg_struct): Remove invalid assertions
14495         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14496         is removed.
14497         (riscv_gdbarch_init): Gather isa features and abi features
14498         separately, ensure both match on the gdbarch when reusing an old
14499         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14500         a target with 64-bit float hardware.
14501
14502 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14503
14504         * source.c (search_command_helper): Stop reverse search
14505         when line 1 has been searched.
14506
14507 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14508
14509         * record-full.c (record_full_base_target::close): Rewrite
14510         record_full_core_buf_list free logic.
14511
14512 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14513
14514         * break-catch-syscall.c (print_one_catch_syscall): xfree
14515         the last text.
14516
14517 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14518
14519         * top.c (print_gdb_version): Update Copyright year in version
14520         message.
14521
14522 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14523
14524         Update copyright year range in all GDB files.
14525
14526 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14527
14528         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14529
14530 For older changes see ChangeLog-2018.
14531 \f
14532 Local Variables:
14533 mode: change-log
14534 left-margin: 8
14535 fill-column: 74
14536 version-control: never
14537 coding: utf-8
14538 End:
14539