gdb/ChangeLog

   1 2019-12-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.c (tui_update_source_windows_with_addr):
   4         Simplify.
   5
   6 2019-12-20  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-winsource.h (struct tui_source_window_base)
   9         <set_contents, update_source_window_as_is, update_source_window>:
  10         Take a sal, not a separate symtab and tui_line_or_address.
  11         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
  12         (tui_source_window_base::update_source_window_as_is): Take a sal,
  13         not a separate symtab and tui_line_or_address.
  14         (tui_update_source_windows_with_addr)
  15         (tui_update_source_windows_with_line)
  16         (tui_source_window_base::rerender)
  17         (tui_source_window_base::refill): Update.
  18         * tui/tui-source.h (struct tui_source_window) <set_contents>: Take
  19         a sal, not a separate symtab and tui_line_or_address.
  20         * tui/tui-source.c (tui_source_window::set_contents): Take a sal,
  21         not a separate symtab and tui_line_or_address.
  22         (tui_source_window::maybe_update): Update.
  23         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>: Take
  24         a sal, not a separate symtab and tui_line_or_address.
  25         * tui/tui-disasm.c (tui_disasm_window::set_contents): Take a sal,
  26         not a separate symtab and tui_line_or_address.
  27         (tui_disasm_window::do_scroll_vertical)
  28         (tui_disasm_window::maybe_update): Update.
  29
  30 2019-12-20  Tom Tromey  <tom@tromey.com>
  31
  32         * tui/tui-winsource.c (tui_source_window_base::refill): Use
  33         start_line_or_addr.
  34         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Use
  35         start_line_or_addr.
  36         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
  37         start_line_or_addr.
  38
  39 2019-12-20  Tom Tromey  <tom@tromey.com>
  40
  41         * tui/tui-winsource.h (struct tui_source_window_base)
  42         <set_contents>: Return bool.
  43         * tui/tui-winsource.c
  44         (tui_source_window_base::update_source_window_as_is): Update.
  45         * tui/tui-source.h (struct tui_source_window) <set_contents>:
  46         Return bool.
  47         * tui/tui-source.c (tui_source_window::set_contents): Return
  48         bool.  Simplify.
  49         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
  50         Return bool.
  51         * tui/tui-disasm.c (tui_disasm_window::set_contents): Return
  52         bool.
  53
  54 2019-12-20  Tom Tromey  <tom@tromey.com>
  55
  56         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
  57         (tui_update_source_windows_with_line): Call update_source_window.
  58         * tui/tui-source.h (struct tui_source_window)
  59         <show_symtab_source>: Don't declare.
  60         * tui/tui-source.c (tui_source_window::show_symtab_source):
  61         Remove.
  62
  63 2019-12-20  Tom Tromey  <tom@tromey.com>
  64
  65         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
  66         update_source_window directly.
  67         * tui/tui-disasm.h (tui_show_disassem): Don't declare.
  68         * tui/tui-disasm.c (tui_show_disassem): Remove.
  69
  70 2019-12-20  Tom Tromey  <tom@tromey.com>
  71
  72         * tui/tui-winsource.c
  73         (tui_source_window_base::update_source_window_as_is): Don't switch focus.
  74         * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
  75
  76 2019-12-20  Tom Tromey  <tom@tromey.com>
  77
  78         * tui/tui-winsource.h (struct tui_source_window_base)
  79         <maybe_update>: Remove line_no and addr parameters.
  80         * tui/tui-stack.c (tui_show_frame_info): Set PC on sal.  Update.
  81         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
  82         Update.
  83         * tui/tui-source.c (tui_source_window::maybe_update): Remove
  84         line_no and addr parameters.
  85         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
  86         Update.
  87         * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
  88         line_no and addr parameters.
  89
  90 2019-12-20  Tom Tromey  <tom@tromey.com>
  91
  92         * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
  93         (tui_source_window_base::update_breakpoint_info): Remove asserts.
  94
  95 2019-12-20  Tom Tromey  <tom@tromey.com>
  96
  97         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
  98         tui_show_disassem.
  99         * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
 100         declare.
 101         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
 102
 103 2019-12-20  Tom Tromey  <tom@tromey.com>
 104
 105         * tui/tui.h (tui_show_source): Remove parameters.
 106         * tui/tui.c (tui_show_source): Remove parameters.
 107         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 108
 109 2019-12-20  Tom Tromey  <tom@tromey.com>
 110
 111         * tui/tui.c (tui_show_source): Update.
 112         * tui/tui-winsource.c (tui_display_main): Update.
 113         * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
 114         to symtab.
 115         * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
 116         to symtab.
 117         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
 118
 119 2019-12-20  Tom Tromey  <tom@tromey.com>
 120
 121         PR tui/23619:
 122         * tui/tui-io.c (tui_rl_saved_prompt): Remove.
 123         (tui_redisplay_readline): Use rl_display_prompt.
 124         (tui_prep_terminal): Update.
 125
 126 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 127
 128         * configure: Regenerate.
 129         * configure.ac: Quote variable arguments of test.
 130         * gdbsupport/common.m4: Likewise.
 131
 132 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 133
 134         * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
 135         2 to pow ().
 136
 137 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 138
 139         * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
 140         log10 to double to fix Solaris 11 with gcc 5.5.
 141
 142 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 143
 144         * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
 145         "sun" to "saddr_un".
 146
 147 2019-12-19  Tom Tromey  <tromey@adacore.com>
 148
 149         * ui-out.h (enum class field_kind): Fix comment.
 150
 151 2019-12-11  Tom Tromey  <tromey@adacore.com>
 152
 153         * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
 154
 155 2019-12-18  Tom Tromey  <tromey@adacore.com>
 156
 157         PR build/25268:
 158         * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
 159         type on macOS.  Add comment.
 160
 161 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 162
 163         * c-lang.c (c_get_string, asm_language_defn): Remove space
 164         before tab.
 165
 166 2019-12-18  Tom Tromey  <tromey@adacore.com>
 167
 168         PR build/25250:
 169         * ui-out.c (ui_out::vmessage): Update.
 170         * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
 171         Rename.
 172         (string_field): Update.
 173         (signed_field): Update.
 174
 175 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 176
 177         * top.c (print_gdb_configuration): Adjust indentation.
 178
 179 2019-12-17  Christian Biesinger  <cbiesinger@google.com>
 180
 181         * bsd-kvm.c: Include gdbsupport/pathstuff.h.
 182
 183 2019-12-17  Simon Marchi  <simon.marchi@polymtl.ca>
 184
 185         * tui/tui-layout.h (class tui_layout_base): Add virtual
 186         destructor.
 187
 188 2019-12-16  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 189
 190         * infcmd.c (prepare_one_step): Step over skipped inline functions.
 191         * infrun.c (inline_frame_is_marked_for_skip): New helper function.
 192         (process_event_stop_test): Keep stepping over skipped inline functions.
 193
 194 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 195
 196         * jit.c (struct gdb_block) <next>: Remove field.
 197         (struct gdb_symtab) <~gdb_symtab>: Remove.
 198         <blocks>: Change type to std::forward_list<gdb_block>.
 199         (compare_block): Remove.
 200         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
 201         block at the beginning, don't mind about sorting.
 202         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
 203         before using it.
 204
 205 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 206
 207         * jit.c (struct gdb_block): Add constructor, initialize
 208         real_block and next fields.
 209         <name>: Change type to gdb::unique_xmalloc_ptr.
 210         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
 211         (jit_block_open_impl): Allocate gdb_block with new.
 212         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
 213
 214 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 215
 216         * jit.c: Include forward_list.
 217         (struct gdb_symtab) <next>: Remove field.
 218         (struct gdb_object) <symtabs>: Change type to
 219         std::forward_list<gdb_symtab>.
 220         (jit_object_open_impl): Allocate gdb_object with new.
 221         (jit_symtab_open_impl): Adjust to std::forward_list.
 222         (finalize_symtab): Don't delete symtab.
 223         (jit_object_close_impl):  Adjust to std::forward_list.  Free
 224         gdb_object with delete.
 225
 226 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 227
 228         * jit.c (struct gdb_symtab): Add constructor, destructor,
 229         initialize fields.
 230         <linetable>: Change type to unique_xmalloc_ptr.
 231         <file_name>: Change type to std::string.
 232         (jit_symtab_open_impl): Allocate gdb_symtab with new.
 233         (jit_symtab_line_mapping_add_impl): Adjust.
 234         (finalize_symtab): Adjust, call delete on stab.
 235
 236 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 237
 238         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
 239
 240 2019-12-16  Tom Tromey  <tromey@adacore.com>
 241
 242         * windows-nat.c (windows_nat_target::attach): Update.
 243         * remote.c (extended_remote_target::attach): Update.
 244         * procfs.c (procfs_target::attach): Update.
 245         * nto-procfs.c (nto_procfs_target::attach): Update.
 246         (nto_procfs_target::create_inferior): Update.
 247         * inf-ptrace.c (inf_ptrace_target::attach): Update.
 248         * gnu-nat.c (gnu_nat_target::attach): Update.
 249         (gnu_nat_target::detach): Update.
 250         * darwin-nat.c (darwin_nat_target::attach): Update.
 251         * corefile.c (get_exec_file): Constify result.  Remove extraneous
 252         return.
 253         * bsd-kvm.c (bsd_kvm_target_open): Update.
 254         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
 255
 256 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
 257
 258         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
 259         (we no longer need to include time.h before pathmax.h)
 260
 261 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 262
 263         * ada-exp.y (write_ambiguous_var): Update.
 264         * coffread.c (process_coff_symbol): Update.
 265         * ctfread.c (ctf_add_enum_member_cb): Update.
 266         (new_symbol): Update.
 267         * dwarf2read.c (fixup_go_packaging): Update.
 268         (new_symbol): Update.
 269         * language.c (language_alloc_type_symbol): Update.
 270         * mdebugread.c (new_symbol): Update.
 271         * minsyms.c (minimal_symbol_reader::record_full): Update.
 272         * psymtab.c (add_psymbol_to_bcache): Update.
 273         * stabsread.c (define_symbol): Update.
 274         (read_enum_type): Update.
 275         * symtab.c (symbol_set_language): Make this a member function...
 276         (general_symbol_info::set_language): ... here.
 277         * symtab.h (struct general_symbol_info) <set_language>: New function.
 278         (SYMBOL_SET_LANGUAGE): Remove.
 279         (symbol_set_language): Remove.
 280
 281 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 282
 283         * ada-lang.c (ada_add_block_symbols): Update.
 284         (ada_collect_symbol_completion_matches): Update.
 285         * ax-gdb.c (gen_expr): Update.
 286         * block.c (block_lookup_symbol): Update.
 287         (block_lookup_symbol_primary): Update.
 288         (block_find_symbol): Update.
 289         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
 290         * dbxread.c (process_one_symbol): Update.
 291         * dictionary.c (insert_symbol_hashed): Update.
 292         (collate_pending_symbols_by_language): Update.
 293         (mdict_add_symbol): Update.
 294         * dwarf-index-write.c (write_psymbols): Update.
 295         * dwarf2read.c (fixup_go_packaging): Update.
 296         * findvar.c (read_var_value): Update.
 297         * ft32-tdep.c (ft32_skip_prologue): Update.
 298         * go-lang.c (go_symbol_package_name): Update.
 299         * language.h (scoped_switch_to_sym_language_if_auto::
 300         scoped_switch_to_sym_language_if_auto): Update.
 301         * linespec.c (find_method): Update.
 302         (find_label_symbols_in_block): Update.
 303         * mdebugread.c (parse_symbol): Update.
 304         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 305         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 306         (minimal_symbol_reader::install): Update.
 307         * moxie-tdep.c (moxie_skip_prologue): Update.
 308         * parse.c (parse_exp_in_context): Update.
 309         * psymtab.c (psymbol_name_matches): Update.
 310         (match_partial_symbol): Update.
 311         (lookup_partial_symbol): Update.
 312         (psymbol_hash): Update.
 313         (psymbol_compare): Update.
 314         * python/py-framefilter.c (extract_sym): Update.
 315         (py_print_single_arg): Update.
 316         * stabsread.c (define_symbol): Update.
 317         * stack.c (print_frame_arg): Update.
 318         (find_frame_funname): Update.
 319         (info_frame_command_core): Update.
 320         * symfile.c (set_initial_language): Update.
 321         * symtab.c (symbol_set_demangled_name): Update.
 322         (symbol_get_demangled_name): Update.
 323         (symbol_set_language): Update.
 324         (symbol_find_demangled_name): Update.
 325         (symbol_set_names): Update.
 326         (general_symbol_info::natural_name): Update.
 327         (general_symbol_info::demangled_name): Update.
 328         (general_symbol_info::search_name): Update.
 329         (symbol_matches_search_name): Update.
 330         (eq_symbol_entry): Update.
 331         (iterate_over_symbols): Update.
 332         (completion_list_add_symbol): Update.
 333         (completion_list_add_msymbol): Update.
 334         (completion_list_add_fields): Update.
 335         * symtab.h (struct general_symbol_info) <language>: New function.
 336         <language>: Rename to...
 337         <m_language>: ...this.
 338         (SYMBOL_LANGUAGE): Remove.
 339         (MSYMBOL_LANGUAGE): Remove.
 340         (struct symbol) <ctor>: Update.
 341         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 342
 343 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 344
 345         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 346         set the language of sym.
 347         * language.c (language_alloc_type_symbol): Likewise.
 348
 349 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 350
 351         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 352         PR gdb/23613
 353         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 354         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 355         (core_target_open): Use 'gdb_abspath'.
 356         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 357         'current_directory == NULL' case.
 358         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 359         explain what happens when 'current_directory' is NULL.
 360         * go32-nat.c (go32_nat_target::wait): Check if
 361         'current_directory' is NULL before call to 'chdir'.
 362         * source.c (add_path): Use 'gdb_abspath'.
 363         * top.c: Include 'gdbsupport/pathstuff.h'.
 364         (init_history): Use 'gdb_abspath'.
 365         (set_history_filename): Likewise.
 366         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 367         (tfile_target_open): Use 'gdb_abspath'.
 368
 369 2019-12-13  Tom Tromey  <tromey@adacore.com>
 370
 371         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 372         warning or error.
 373
 374 2019-12-13  Tom Tromey  <tromey@adacore.com>
 375
 376         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 377
 378 2019-12-13  Tom Tromey  <tromey@adacore.com>
 379
 380         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 381
 382 2019-12-13  Tom Tromey  <tromey@adacore.com>
 383
 384         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 385
 386 2019-12-13  Tom Tromey  <tromey@adacore.com>
 387
 388         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 389         (string_vappendf): Add ARI comment.
 390
 391 2019-12-13  Tom Tromey  <tromey@adacore.com>
 392
 393         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 394         floatformat_to_double.
 395         * target-float.c (host_float_ops<T>::from_target): Add ARI
 396         comment.
 397
 398 2019-12-13  Tom Tromey  <tromey@adacore.com>
 399
 400         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 401         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 402         ARI marker to abort.
 403         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 404
 405 2019-12-13  Tom Tromey  <tromey@adacore.com>
 406
 407         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 408
 409 2019-12-13  Tom Tromey  <tromey@adacore.com>
 410
 411         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 412
 413 2019-12-13  Tom Tromey  <tromey@adacore.com>
 414
 415         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 416         checks.
 417
 418 2019-12-13  Tom Tromey  <tromey@adacore.com>
 419
 420         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 421         end>: No longer "const".
 422
 423 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 424
 425         * jit.c: Fix indentation, replace spaces with tabs where
 426         applicable.
 427
 428 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 429
 430         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 431
 432 2019-12-12  Tom Tromey  <tom@tromey.com>
 433
 434         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 435         unique_ptr.
 436
 437 2019-12-12  Tom Tromey  <tom@tromey.com>
 438
 439         * progspace.h (objfile_list): New typedef.
 440         (class unwrapping_objfile_iterator)
 441         (struct unwrapping_objfile_range): Newl
 442         (struct program_space) <objfiles_range>: Change type.
 443         <objfiles>: Change return type.
 444         <add_objfile>: Change type of "objfile" parameter.
 445         <objfiles_list>: Now a list of shared_ptr.
 446         * progspace.c (program_space::add_objfile): Change type of
 447         "objfile".  Update.
 448         (program_space::remove_objfile): Update.
 449         * objfiles.h (struct objfile) <~objfile>: Make public.
 450         * objfiles.c (objfile::make): Update.
 451         (objfile::unlink): Don't call delete.
 452
 453 2019-12-12  Tom Tromey  <tom@tromey.com>
 454
 455         * symfile.c (symbol_file_clear): Update.
 456         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 457         method.
 458         * progspace.c (program_space::free_all_objfiles): New method.
 459         * objfiles.h (free_all_objfiles): Don't declare.
 460         * objfiles.c (free_all_objfiles): Move to program_space.
 461
 462 2019-12-12  Tom Tromey  <tom@tromey.com>
 463
 464         * progspace.c (program_space::add_objfile)
 465         (program_space::remove_objfile): Update.
 466         (program_space::multi_objfile_p): Remove.
 467         * objfiles.h (struct objfile) <next>: Remove.
 468         * objfiles.c (objfile::objfile): Update.
 469         (put_objfile_before): Update.
 470         (unlink_objfile): Update.
 471         * progspace.h (object_files): Remove.
 472         (struct program_space) <objfiles_head>: Remove.
 473         <objfiles_list>: New member.
 474         <objfiles_range, objfiles_safe_range>: Change type.
 475         (objfiles): Change return type.
 476         (objfiles_safe): Update.
 477         (multi_objfile_p): Rewrite and inline.
 478         (object_files): Remove macro.
 479
 480 2019-12-12  Tom Tromey  <tom@tromey.com>
 481
 482         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 483         second constructor.
 484         (basic_safe_range): New class.
 485
 486 2019-12-12  Tom Tromey  <tom@tromey.com>
 487
 488         * progspace.c (program_space::multi_objfile_p): New method.
 489         * printcmd.c (info_symbol_command): Update.
 490         * maint.c (maintenance_translate_address): Update.
 491         * objfiles.h (MULTI_OBJFILE_P): Remove.
 492         * progspace.h (struct program_space) <multi_objfile_p>: New
 493         method.
 494
 495 2019-12-12  Tom Tromey  <tom@tromey.com>
 496
 497         * progspace.h (struct program_space) <remove_objfile>: Declare.
 498         * progspace.c (program_space::remove_objfile): New method.
 499         * objfiles.c (unlink_objfile): Remove.
 500         (objfile::unlink): Call remove_objfile.
 501         (objfile): Don't call unlink_objfile.
 502
 503 2019-12-12  Tom Tromey  <tom@tromey.com>
 504
 505         * progspace.h (struct program_space) <add_objfile>: Declare
 506         method.
 507         * progspace.c (program_space::add_objfile): New method.
 508         * objfiles.c (~objfile): Don't unlink objfile.
 509         (put_objfile_before): Remove.
 510         (add_separate_debug_objfile): Don't call put_objfile_before.
 511         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 512         the per-program-space data.
 513
 514 2019-12-12  Tom Tromey  <tom@tromey.com>
 515
 516         * symfile.c (syms_from_objfile_1): Use objfile_up.
 517         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 518         method.
 519         (reread_symbols): Use objfile_up.
 520         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 521         unlink method.
 522         * objfiles.h (struct objfile) <~objfile>: Now private.
 523         <unlink>: New method.
 524         (struct objfile_deleter): New.
 525         (objfile_up): New typedef.
 526         * objfiles.c (objfile::unlink): New method.
 527         (free_objfile_separate_debug, free_all_objfiles)
 528         (objfile_purge_solibs): Use it.
 529         * jit.c (jit_unregister_code): Remove.
 530         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 531         objfile.
 532         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 533         objfile.
 534         * compile/compile-object-load.c (compile_object_load): Use
 535         objfile_up.
 536
 537 2019-12-12  Tom Tromey  <tom@tromey.com>
 538
 539         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 540         objfile::make.
 541         * objfiles.h (struct objjfile) <make>: No longer inline.
 542         (add_separate_debug_objfile): Don't declare.
 543         * objfiles.c (add_separate_debug_objfile): Now static.
 544         (objfile::make): Move from objfiles.h.  Call
 545         add_separate_debug_objfile.  Add "parent" parameter.
 546
 547 2019-12-12  Tom Tromey  <tom@tromey.com>
 548
 549         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 550         * objfiles.h (struct objfile): Make constructor private.
 551         <make>: New static method.
 552         * jit.c (jit_object_close_impl): Update.
 553
 554 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 555
 556         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 557         gdb::byte_vector.
 558
 559 2019-12-12  Tom Tromey  <tromey@adacore.com>
 560
 561         * xml-support.c (xml_fetch_content_from_file): Don't call
 562         malloc_failure.
 563         * utils.h (class gdb_argv): Remove malloc_failure comment.
 564         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 565
 566 2019-12-12  Tom Tromey  <tromey@adacore.com>
 567
 568         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 569         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 570         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 571         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 572         * riscv-ravenscar-thread.c: New file.
 573         * riscv-ravenscar-thread.h: New file.
 574         * riscv-tdep.c (riscv_gdbarch_init): Call
 575         register_riscv_ravenscar_ops.
 576
 577 2019-12-12  Tom Tromey  <tromey@adacore.com>
 578
 579         * gdbsupport/thread-pool.c (set_thread_name): Use
 580         ATTRIBUTE_UNUSED.
 581
 582 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 583
 584         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 585         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 586         macros.
 587
 588 2019-12-11  Tom Tromey  <tom@tromey.com>
 589
 590         * tui/tui-win.c (tui_set_win_height_command): Call
 591         tui_adjust_window_height.
 592         (tui_adjust_win_heights, new_height_ok): Remove.
 593         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 594         * tui/tui-layout.c (tui_adjust_window_height): New function.
 595
 596 2019-12-11  Tom Tromey  <tom@tromey.com>
 597
 598         * tui/tui-win.c (tui_resize_all): Remove code, call
 599         tui_apply_current_layout.
 600
 601 2019-12-11  Tom Tromey  <tom@tromey.com>
 602
 603         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 604         * tui/tui-layout.c (standard_layouts, applied_layout): New
 605         globals.
 606         (tui_apply_current_layout): New function.
 607         (show_layout): Set applied_layout.  Call
 608         tui_apply_current_layout.
 609         (show_source_command, show_disasm_command)
 610         (show_source_disasm_command, show_data)
 611         (show_source_or_disasm_and_command): Remove.
 612         (initialize_layouts): New function.
 613         (_initialize_tui_layout): Call initialize_layouts.
 614
 615 2019-12-11  Tom Tromey  <tom@tromey.com>
 616
 617         * tui/tui-layout.h (class tui_layout_base)
 618         (class tui_layout_window, class tui_layout_split): New.
 619         * tui/tui-layout.c (tui_get_window_by_name)
 620         (tui_layout_window::clone, tui_layout_window::apply)
 621         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 622         (tui_layout_split::add_window, tui_layout_split::clone)
 623         (tui_layout_split::get_sizes)
 624         (tui_layout_split::set_weights_from_heights)
 625         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 626         functions.
 627         (tui_layout_split::add_split, tui_layout_split::add_split)
 628         (tui_layout_split::set_weights_from_heights)
 629         (tui_layout_split::set_weights_from_heights): New functions.
 630
 631 2019-12-11  Tom Tromey  <tom@tromey.com>
 632
 633         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 634         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 635         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 636         * tui/tui-data.h (struct tui_point): Remove.
 637         (struct tui_gen_win_info) <origin>: Remove.
 638         <x, y>: New fields.
 639         * tui/tui-command.c (tui_cmd_window::resize): Update.
 640
 641 2019-12-11  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 644         Implement.
 645         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 646         Implement.
 647         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 648         method.
 649         (struct tui_win_info) <min_height>: Implement.
 650
 651 2019-12-11  Tom Tromey  <tom@tromey.com>
 652
 653         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 654         (struct tui_win_info) <can_box>: Update.
 655
 656 2019-12-11  Tom Tromey  <tom@tromey.com>
 657
 658         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 659         method.
 660         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 661         method.
 662         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 663         method.
 664         (struct tui_win_info) <max_height>: Now override.
 665
 666 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 667
 668         * NEWS: Create a new section for the next release branch.
 669         Rename the section of the current branch, now that it has
 670         been cut.
 671
 672 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 673
 674         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 675         * version.in: Bump version to 10.0.50.DATE-git.
 676
 677 2019-12-11  Tom Tromey  <tromey@adacore.com>
 678
 679         PR build/25268:
 680         * gdbsupport/thread-pool.c (set_thread_name): New function.
 681         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 682         (thread_pool::thread_function): Call set_thread_name.
 683
 684 2019-12-11  Tom Tromey  <tromey@adacore.com>
 685
 686         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 687         bfd_get_signed_8.
 688
 689 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 690
 691         * NEWS: Document -raw-values option and the related setting commands.
 692         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 693         only set it on when /r is given.
 694         * valprint.c (value_print_option_defs): New element raw-values.
 695         * Makefile.in: Add the new file.
 696
 697 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 698
 699         * gdbsupport/safe-strerror.c: Supress the unused function warning
 700         for select_strerror_r.
 701
 702 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 703
 704         * config.in: Regenerate.
 705         * configure: Regenerate.
 706         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 707         safe_strerror instead of strerror.
 708         * gdbsupport/common.m4: Don't check for strerror.
 709         * gdbsupport/safe-strerror.c: Support both the glibc version
 710         of strerror_r and the XSI version.
 711
 712 2019-12-10  Tom Tromey  <tromey@adacore.com>
 713
 714         * ada-typeprint.c (print_choices): Use a single "?".
 715         (print_variant_part): Print "?" if the discriminant name
 716         is not known.
 717
 718 2019-12-10  George Barrett  <bob@bob131.so>
 719
 720         Fix scripted probe breakpoints.
 721         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 722         declaration forward.
 723         (breakpoint_ops_for_event_location_type)
 724         (breakpoint_ops_for_event_location): Add function definitions.
 725         (break_command_1, trace_command): Use
 726         breakpoint_ops_for_event_location.
 727         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 728         declarations.
 729         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 730         breakpoint_ops_for_event_location.
 731         * python/py-breakpoint.c (bppy_init): Use
 732         breakpoint_ops_for_event_location.
 733
 734 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 735
 736         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 737         when ranking an lvalue argument for an rvalue parameter.
 738
 739 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 740
 741         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 742         template argument for scoped_restore_tmpl from bool to int.
 743
 744 2019-12-07  Keith Seitz  <keiths@redhat.com>
 745
 746         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 747         (build_id_to_debug_bfd): Make static, rewriting to use
 748         build_id_to_bfd_suffix.
 749         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 750         adding `suffix' parameter. Append SUFFIX to file names
 751         when searching for matching files.
 752         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 753         (build_id_to_exec_bfd): Likewise.
 754         * build-id.h (build_id_to_debug_bfd): Clarify that function
 755         searches for BFD of debug info file.
 756         (build_id_to_exec_bfd): Declare.
 757         * corelow.c: Include build-id.h.
 758         (locate_exec_from_corefile_build_id): New function.
 759         (core_target_open): If no executable BFD is found,
 760         search for a core file BFD using build-id.
 761
 762 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 763
 764         * bcache.c: Put in namespace gdb.
 765         * bcache.h: Likewise.
 766         * gdbtypes.c (check_types_worklist): Update.
 767         (types_deeply_equal): Update.
 768         * macrotab.c (struct macro_table) <bcache>: Update.
 769         (new_macro_table): Update.
 770         * macrotab.h (struct bcache): Put this forward declaration
 771         inside namespace gdb.
 772         (new_macro_table): Update.
 773         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 774         Update.
 775         <macro_cache>: Update.
 776         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 777
 778 2019-12-06  Tom de Vries  <tdevries@suse.de>
 779
 780         PR symtab/24971
 781         * block.c (best_symbol, better_symbol): New function.
 782         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 783         decl.
 784
 785 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 786
 787         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 788         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 789         for ranking see-through reference cases.
 790
 791 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 792         * stack.c (faas_command): Check a command is provided.
 793         * thread.c (taas_command, tfaas_command): Likewise.
 794
 795 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 796         * inferior.c (prune_inferiors):  Only call delete_inferior,
 797         Do not modify the inferior list.
 798
 799 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 800
 801         * c-exp.y: Update calls to lookup_typename,
 802         lookup_signed_typename and lookup_unsigned_typename.
 803         * c-lang.c (evaluate_subexp_c): Likewise.
 804         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 805         Likewise.
 806         * eval.c (binop_promote): Likewise.
 807         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 808         (lookup_unsigned_typename): Likewise.
 809         (lookup_signed_typename): Likewise.
 810         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 811         (lookup_signed_typename): Likewise.
 812         (lookup_typename): Likewise.
 813         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 814         lookup_typename, lookup_signed_typename,
 815         lookup_unsigned_typename.
 816         * m2-exp.y: Likewise.
 817         * printcmd.c (printf_wide_c_string): Likewise.
 818         (ui_printf): Likewise.
 819         * python/py-type.c (typy_lookup_typename): Likewise.
 820         * python/py-xmethods.c (python_xmethod_worker::invoke):
 821         Likewise.
 822         * rust-exp.y: Likewise.
 823
 824 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 825
 826         * configure.nat (obsd64): Add missing files x86-nat.o and
 827         nat/x86-dregs.o.
 828
 829 2019-12-04  Tom Tromey  <tom@tromey.com>
 830
 831         * valprint.c (val_print_string): Use metadata_style.
 832         * go-valprint.c (print_go_string): Use metadata style.
 833         * p-valprint.c (pascal_object_print_static_field): Use metadata
 834         style.
 835         * cp-valprint.c (cp_print_static_field): Use metadata style.
 836
 837 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 838             Chris January  <chris.january@arm.com>
 839
 840         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 841         tokens.
 842         (typebase): New patterns for complex, single/double precision, and
 843         single/double complex.
 844         (f77_keywords): Change token for complex keyword, and add single,
 845         double, and precision keywords.
 846
 847 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 848
 849         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 850         "info io_registers".
 851
 852 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 853
 854         * regcache.c (cooked_read_test): Initialize thread list of
 855         mock_inferior.
 856
 857 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 858
 859         * aarch64-linux-tdep.c: Remove includes.
 860
 861 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 862
 863         * aarch64-tdep.c: Remove includes.
 864
 865 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 866
 867         * filtered-iterator.h (filtered_iterator) <operator==,
 868         operator!=>: Compare wrapped iterators, not wrapped pointers.
 869         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 870         unittests/filtered_iterator-selftests.c.
 871         * unittests/filtered_iterator-selftests.c: New file.
 872
 873 2019-12-04  Tom Tromey  <tromey@adacore.com>
 874
 875         * gdbtypes.c (create_range_type): Inherit endianity
 876         from base type.
 877
 878 2019-12-04  Tom Tromey  <tromey@adacore.com>
 879
 880         * ada-lang.c (decode_constrained_packed_array)
 881         (ada_value_assign, value_assign_to_component): Update.
 882         * dwarf2loc.c (rw_pieced_value, access_memory)
 883         (dwarf2_compile_expr_to_ax): Update.
 884         * dwarf2read.c (dwarf2_add_field): Update.
 885         * eval.c (evaluate_subexp_standard): Update.
 886         * gdbarch.c, gdbarch.h: Rebuild.
 887         * gdbarch.sh (bits_big_endian): Remove.
 888         * gdbtypes.h (union field_location): Update comment.
 889         * target-descriptions.c (make_gdb_type): Update.
 890         * valarith.c (value_bit_index): Update.
 891         * value.c (struct value) <bitpos>: Update comment.
 892         (unpack_bits_as_long, modify_field): Update.
 893         * value.h (value_bitpos): Update comment.
 894
 895 2019-12-04  Tom Tromey  <tromey@adacore.com>
 896
 897         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 898         endian-ness.
 899
 900 2019-12-04  Tom Tromey  <tromey@adacore.com>
 901
 902         * dwarf2read.c (dwarf2_init_float_type)
 903         (dwarf2_init_complex_target_type): Add byte_order parameter.
 904         (read_base_type): Compute byte order earlier.
 905         * gdbtypes.c (init_float_type): Add byte_order parameter.
 906         * gdbtypes.h (init_float_type): Add byte_order parameter.
 907
 908 2019-12-04  Tom Tromey  <tromey@adacore.com>
 909
 910         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 911
 912 2019-12-04  Tom Tromey  <tromey@adacore.com>
 913
 914         * dwarf2read.c (process_structure_scope): Initialize
 915         "discr_offset".
 916
 917 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 918
 919         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 920         add it into the search spec.
 921         (parse_max_results_option): New function.
 922         (mi_info_functions_or_variables): Parse -max-results flag and pass
 923         it to mi_symbol_info.
 924         (mi_cmd_symbol_info_modules): Likewise.
 925         (mi_cmd_symbol_info_types): Likewise.
 926         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 927         return type to bool, change result container into a set, and don't
 928         add new results if we have enough already.
 929         (global_symbol_searcher::add_matching_msymbols): Change return
 930         type to bool, and don't add new results if we have enough already.
 931         (sort_search_symbols_remove_dups): Delete.
 932         (global_symbol_searcher::search): Early exit from search loop when
 933         we have enough results.  Use a std::set to collect the results
 934         from calling add_matching_symbols.
 935         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 936         member function.
 937         (global_symbol_searcher) <m_max_search_results>: New member
 938         variable.
 939         (global_symbol_searcher) <add_matching_symbols>: Update header
 940         comment and change return type to bool.
 941         (global_symbol_searcher) <add_matching_msymbols>: Update header
 942         comment and change return type to bool.
 943
 944 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 945
 946         * symtab.c (symbol_search::compare_search_syms): Update header
 947         comment.
 948         (global_symbol_searcher::is_suitable_msymbol): New function.
 949         (global_symbol_searcher::expand_symtabs): New function.
 950         (global_symbol_searcher::add_matching_symbols): New function.
 951         (global_symbol_searcher::add_matching_msymbols): New function.
 952         (global_symbol_searcher::search): Move most of the content
 953         into the new functions above, and call them as needed.
 954         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 955         function.
 956         (global_symbol_searcher) <add_matching_symbols>: New member
 957         function.
 958         (global_symbol_searcher) <add_matching_msymbols>: New member
 959         function.
 960         (global_symbol_searcher) <is_suitable_msymbol>: New member
 961         function.
 962
 963 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 964
 965         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 966         -symbol-info-module-variables entries.
 967         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 968         (mi_cmd_symbol_info_module_variables): Declare.
 969         * mi/mi-symbol-cmds.c
 970         (module_symbol_search_iterator): New typedef.
 971         (output_module_symbols_in_single_module_and_file): New function.
 972         (output_module_symbols_in_single_module): New function.
 973         (mi_info_module_functions_or_variables): New function.
 974         (mi_cmd_symbol_info_module_functions): New function.
 975         (mi_cmd_symbol_info_module_variables): New function.
 976         * NEWS: Mention new MI command.
 977
 978 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 979
 980         * bcache.c (hash): Remove.
 981         (hash_continue): Remove.
 982         * bcache.h (hash): Remove.
 983         (hash_continue): Remove.
 984         (struct bcache) <ctor>: Update.
 985         * psymtab.c (psymbol_hash): Update.
 986         * stabsread.c (hashname): Update.
 987         * utils.h (fast_hash): Add an argument for a start value,
 988         defaulting to zero.
 989
 990 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 991         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 992         (destroy_block_symbol_cache): New function.
 993         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 994         (resize_symbol_cache): Likewise.
 995
 996 2019-12-02  Tom Tromey  <tom@tromey.com>
 997
 998         * unittests/tui-selftests.c (run_tests): Make conditional.
 999         (_initialize_tui_selftest): Make conditional.
1000
1001 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
1002
1003         * aix-thread.c (debug_aix_thread): Change type to bool.
1004
1005 2019-12-02  Luis Machado  <luis.machado@linaro.org>
1006
1007         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
1008
1009 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1010
1011         * dwarf2read.c (read_tag_string_type): Read the fields required to
1012         make a dynamic string, and possibly create a dynamic range for the
1013         string.
1014         (attr_to_dynamic_prop): Setup is_reference based on the type of
1015         attribute being processed.
1016         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
1017         (resolve_dynamic_array): Rename to...
1018         (resolve_dynamic_array_or_string): ...this, update header comment,
1019         and accept TYPE_CODE_STRING.
1020         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
1021
1022 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1023
1024         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
1025         of its implementation from...
1026         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
1027         the new function.
1028
1029 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1030
1031         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
1032         create a range with stride where appropriate.
1033         * f-valprint.c: Include 'gdbarch.h'.
1034         (f77_print_array_1): Take the stride into account when walking the
1035         array.  Also convert the stride into addressable units.
1036         * gdbtypes.c (create_range_type): Initialise the stride to
1037         constant zero.
1038         (create_range_type_with_stride): New function, initialise the
1039         range as normal, and then setup the stride.
1040         (has_static_range): Include the stride here.  Also change the
1041         return type to bool.
1042         (create_array_type_with_stride): Consider the range stride if the
1043         array isn't given its own stride.
1044         (resolve_dynamic_range): Resolve the stride if needed.
1045         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
1046         (struct range_bounds) <flag_is_byte_stride>: New member variable.
1047         (TYPE_BIT_STRIDE): Define.
1048         (TYPE_ARRAY_BIT_STRIDE): Define.
1049         (create_range_type_with_stride): Declare.
1050         * valarith.c (value_subscripted_rvalue): Take range stride into
1051         account when walking the array.
1052
1053 2019-12-01  Tom Tromey  <tom@tromey.com>
1054
1055         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
1056         specially.
1057
1058 2019-12-01  Tom Tromey  <tom@tromey.com>
1059
1060         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
1061         \0.
1062         * unittests/tui-selftests.c: New file.
1063         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1064
1065 2019-12-01  Tom Tromey  <tom@tromey.com>
1066
1067         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1068
1069 2019-12-01  Tom Tromey  <tom@tromey.com>
1070
1071         * NEWS: Document new settings.
1072         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1073         * tui/tui-win.c (_initialize_tui_win): Add border style
1074         observers.
1075         * tui/tui-io.h (tui_apply_style): Declare.
1076         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
1077         longer static.
1078         (apply_ansi_escape, tui_set_reverse_mode): Update.
1079         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1080         Add "skip_intensity" parameter.
1081         <changed>: New member.
1082         <do_set_value>: Declare.
1083         (tui_border_style, tui_active_border_style): Declare.
1084         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1085         globals.
1086         (cli_style_option): Initialize "changed".
1087         (cli_style_option::do_set_value): New function.
1088         (cli_style_option::add_setshow_commands): Add "skip_intensity"
1089         parameter.  Update.
1090         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1091         (_initialize_cli_style): Update.  Create TUI border style
1092         commands.
1093
1094 2019-12-01  Tom Tromey  <tom@tromey.com>
1095
1096         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1097         parameter.
1098         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1099         parameter.
1100         * tui/tui-win.h (compact_source): Declare.
1101         * tui/tui-win.c (compact_source): New global.
1102         (tui_set_compact_source, tui_show_compact_source): New functions.
1103         (_initialize_tui_win): Add "compact-source" setting.
1104         * tui/tui-source.c (tui_source_window::set_contents): Handle
1105         compact_source setting.
1106         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1107         * NEWS: Document new setting.
1108
1109 2019-11-30  Tom Tromey  <tom@tromey.com>
1110
1111         * dwarf2read.c (dwarf2_add_field): Include field offset when
1112         computing variant part length.
1113
1114 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1115         * NEWS:  Mention define-prefix.  Tell that command names can now
1116         contain a . character.
1117
1118 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1119
1120         * command.h (valid_cmd_char_p): Declare.
1121         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1122         the check of valid command char.
1123         (find_command_name_length, valid_user_defined_cmd_name_p): Use
1124         valid_cmd_char_p.
1125         * cli/cli-script.c (validate_comname): Likewise.
1126         * completer.c (gdb_completer_command_word_break_characters):
1127         Do not remove . from the word break char, update comments.
1128         (complete_line_internal_1): Use valid_cmd_char_p.
1129         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1130         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1131
1132 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1133
1134         * cli/cli-script.c (do_define_command): Ensure a redefined
1135         prefix command is kept as a prefix command.
1136         (define_prefix_command): New function.
1137         (show_user_1): Report user defined prefixes.
1138         (_initialize_cli_script):  Create the new 'define-prefix' command.
1139         Add completers for 'define' and 'document'.
1140         * top.c (execute_command):  If command is a user-defined prefix only
1141         command, report the list of commands for this prefix command.
1142
1143 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1144
1145         * valops.c (find_oload_champ): Improve debug output.
1146
1147 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1148
1149         * valops.c (find_oload_champ): Print part of debug messages
1150         before the badness vector is std::move'd.
1151
1152 2019-11-28  Tom Tromey  <tom@tromey.com>
1153
1154         * value.c (creal_internal_fn): Fix comment.
1155
1156 2019-11-28  Tom Tromey  <tom@tromey.com>
1157
1158         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1159         flag_bound_evaluated>: Now unsigned.
1160
1161 2019-11-28  Tom Tromey  <tom@tromey.com>
1162
1163         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1164         declare.
1165
1166 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
1167
1168         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1169         debug output.
1170         * jit.c (jit_unregister_code): Add debug print to match
1171         `jit_register_code`.
1172
1173 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1174
1175         * NEWS: Mention the new multithreaded symbol loading.
1176
1177 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1178
1179         * maint.c (n_worker_threads): Default to 0.
1180         (worker_threads_disabled): New function.
1181         * maint.h (worker_threads_disabled): New function.
1182         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1183         here if worker_threads_disabled () is true.
1184         (minimal_symbol_reader::install): Skip all threading if
1185         worker_threads_disabled () is true.
1186
1187 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1188
1189         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1190         hash code if possible.
1191         (add_minsym_to_demangled_hash_table): Likewise.
1192         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1193         on the background thread.
1194         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1195         Add these fields.
1196
1197 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1198
1199         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1200         of the mangled name on the background thread.
1201         * symtab.c (symbol_set_names): Allow passing in the hash of the
1202         linkage_name.
1203         * symtab.h (symbol_set_names): Likewise.
1204
1205 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1206
1207         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1208         physnames are computed for inherited DIEs.
1209
1210 2019-11-27  Tom Tromey  <tromey@adacore.com>
1211
1212         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1213         backslashes.
1214         * cp-support.c: Remove unnecessary backslashes.
1215
1216 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1217
1218         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1219         with sym->set_linkage_name.
1220         * coffread.c (coff_read_enum_type): Likewise.
1221         * mdebugread.c (parse_symbol): Likewise.
1222         * stabsread.c (patch_block_stabs): Likewise.
1223         (define_symbol): Likewise.
1224         (read_enum_type): Likewise.
1225         (common_block_end): Likewise.
1226         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1227         function.
1228         (SYMBOL_SET_LINKAGE_NAME): Remove.
1229         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1230         with sym->set_linkage_name.
1231
1232 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1233
1234         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1235         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1236         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1237         * NEWS: Mention new MI command.
1238
1239 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1240
1241         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1242         '-symbol-info-types', and '-symbol-info-variables'.
1243         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1244         (mi_cmd_symbol_info_types): Declare.
1245         (mi_cmd_symbol_info_variables): Declare.
1246         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1247         (output_debug_symbol): New function.
1248         (output_nondebug_symbol): New function.
1249         (mi_symbol_info): New function.
1250         (mi_info_functions_or_variables): New function.
1251         (mi_cmd_symbol_info_functions): New function.
1252         (mi_cmd_symbol_info_types): New function.
1253         (mi_cmd_symbol_info_variables): New function.
1254         * NEWS: Mention new commands.
1255
1256 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1257
1258         * symtab.c (symbol_to_info_string): New function, most content
1259         moved from print_symbol_info, but updated to return a std::string.
1260         (print_symbol_info): Update to use symbol_to_info_string and print
1261         returned string.
1262         * symtab.h (symbol_to_info_string): Declare new function.
1263
1264 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1265
1266         * python/python.c (gdbpy_rbreak): Convert to using
1267         global_symbol_searcher.
1268         * symtab.c (file_matches): Convert return type to bool, change
1269         file list to std::vector, update header comment.
1270         (search_symbols): Rename to...
1271         (global_symbol_searcher::search): ...this and update now its
1272         a member function of global_symbol_searcher.  Take account of the
1273         changes to file_matches.
1274         (symtab_symbol_info): Convert to using global_symbol_searcher.
1275         (rbreak_command): Likewise.
1276         (search_module_symbols): Likewise.
1277         * symtab.h (enum symbol_search): Update comment.
1278         (search_symbols): Remove declaration.
1279         (class global_symbol_searcher): New class.
1280
1281 2019-11-26  Tom Tromey  <tromey@adacore.com>
1282
1283         * cp-support.c (_initialize_cp_support): Conditionally initialize
1284         gdb_demangle_attempt_core_dump.
1285
1286 2019-11-26  Tom Tromey  <tom@tromey.com>
1287
1288         * python/py-function.c (fnpy_init): Update.
1289         * value.h (add_internal_function): Adjust declaration.
1290         * value.c (function_destroyer): Remove.
1291         (do_add_internal_function): Don't set destroyer or copy name.
1292         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1293         Set name_allocated.
1294         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1295         (cmdpy_init): Set name_allocated.
1296         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1297         member.
1298         (~cmd_list_element): Free "name" if needed.
1299
1300 2019-11-26  Tom Tromey  <tom@tromey.com>
1301
1302         * value.h (add_internal_function): Add new overload.  Move
1303         documentation from value.h.
1304         * value.c (do_add_internal_function): New function.
1305         (add_internal_function): Use it.  Add new overload.
1306         (function_destroyer): Don't free doc.
1307         * python/py-function.c (fnpy_init): Update.
1308
1309 2019-11-26  Tom Tromey  <tom@tromey.com>
1310
1311         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1312         (cmdpy_init): Set "doc_allocated".
1313
1314 2019-11-26  Tom Tromey  <tom@tromey.com>
1315
1316         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1317         name of worker thread.
1318         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1319         pthread_setname_np.
1320         * configure, config.in: Rebuild.
1321
1322 2019-11-26  Tom Tromey  <tom@tromey.com>
1323
1324         * python/python.c (class gdbpy_gil): New.
1325         (struct gdbpy_event): Add constructor, destructor, operator().
1326         (gdbpy_post_event): Use run_on_main_thread.
1327         (gdbpy_initialize_events): Remove.
1328         (do_start_initialization): Update.
1329
1330 2019-11-26  Tom Tromey  <tom@tromey.com>
1331
1332         * NEWS: Add entry.
1333         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1334         commands.  Call update_thread_pool_size.
1335         (update_thread_pool_size, maintenance_set_worker_threads): New
1336         functions.
1337         (n_worker_threads): New global.
1338
1339 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1340             Tom Tromey  <tom@tromey.com>
1341
1342         * minsyms.c (minimal_symbol_reader::install): Use
1343         parallel_for_each.
1344         * gdbsupport/parallel-for.h: New file.
1345         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1346
1347 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1348             Tom Tromey  <tom@tromey.com>
1349
1350         * gdbsupport/thread-pool.h: New file.
1351         * gdbsupport/thread-pool.c: New file.
1352         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1353         (HFILES_NO_SRCDIR): Add thread-pool.h.
1354
1355 2019-11-26  Tom Tromey  <tom@tromey.com>
1356
1357         * event-top.h (thread_local_segv_handler): Declare.
1358         * event-top.c (thread_local_segv_handler): New global.
1359         (install_handle_sigsegv, handle_sigsegv): New functions.
1360         (async_init_signals): Install SIGSEGV handler.
1361         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1362         thread-local.
1363         (report_failed_demangle): New function.
1364         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1365         handler-setting code, instead use segv_handler.  Run warning code
1366         on main thread.
1367
1368 2019-11-26  Tom Tromey  <tom@tromey.com>
1369
1370         * run-on-main-thread.c: New file.
1371         * run-on-main-thread.h: New file.
1372         * unittests/main-thread-selftests.c: New file.
1373         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1374         main-thread-selftests.c.
1375         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1376         (COMMON_SFILES): Add run-on-main-thread.c.
1377
1378 2019-11-26  Tom Tromey  <tom@tromey.com>
1379
1380         * main.c (setup_alternate_signal_stack): Remove.
1381         (captured_main_1): Use gdb::alternate_signal_stack.
1382         * gdbsupport/alt-stack.h: New file.
1383
1384 2019-11-26  Tom Tromey  <tom@tromey.com>
1385
1386         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1387         Remove comment.
1388         (save_original_signals_state, restore_original_signals_state): Use
1389         gdb_sigmask.
1390         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1391         (_initialize_linux_nat): Use gdb_sigmask.
1392         * guile/guile.c (_initialize_guile): Use block_signals.
1393         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1394         * gdbsupport/gdb-sigmask.h: New file.
1395         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1396         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1397         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1398         pthread_sigmask.
1399         * configure, config.in: Rebuild.
1400         * gdbsupport/block-signals.h: New file.
1401
1402 2019-11-26  Tom Tromey  <tom@tromey.com>
1403
1404         * acinclude.m4: Include ax_pthread.m4.
1405         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1406         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1407         (CLIBS): Use PTHREAD_LIBS.
1408         (aclocal_m4_deps): Add ax_pthread.m4.
1409         * config.in, configure: Rebuild.
1410         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1411
1412 2019-11-26  Tom Tromey  <tom@tromey.com>
1413
1414         * symtab.h (struct minimal_symbol) <name_set>: New member.
1415         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1416         Don't call symbol_set_names.
1417         (minimal_symbol_reader::install): Call symbol_set_names.
1418
1419 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1420
1421         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1422         restore_active_ext_lang, as GIL is needed for (indirectly)
1423         called PyOS_InterruptOccurred.
1424
1425 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1426
1427         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1428         definition.
1429
1430 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1431
1432         * remote-sim.c (simulator_command): Make static, remove
1433         declaration.
1434
1435 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1436
1437         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1438         static.
1439         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1440         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1441         (main): Likewise.
1442         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1443         (main): Likewise.
1444         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1445         (main): Likewise.
1446         * unittests/basic_string_view/element_access/char/1.cc (test01):
1447         Likewise.
1448         (main): Likewise.
1449         * unittests/basic_string_view/element_access/char/empty.cc (main):
1450         Likewise.
1451         * unittests/basic_string_view/element_access/char/front_back.cc
1452         (test01): Likewise.
1453         (main): Likewise.
1454         * unittests/basic_string_view/inserters/char/2.cc (test05):
1455         Likewise.
1456         (main): Likewise.
1457         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1458         (test01): Likewise.
1459         (main): Likewise.
1460         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1461         (test01): Likewise.
1462         (main): Likewise.
1463         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1464         Likewise.
1465         * unittests/basic_string_view/operations/compare/char/1.cc
1466         (test01): Likewise.
1467         (main): Likewise.
1468         * unittests/basic_string_view/operations/compare/char/13650.cc
1469         (test01): Likewise.
1470         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1471         Likewise.
1472         (main): Likewise.
1473         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1474         Likewise.
1475         (main): Likewise.
1476         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1477         Likewise.
1478         (main): Likewise.
1479         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1480         Likewise.
1481         (main): Likewise.
1482         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1483         Likewise.
1484         (main): Likewise.
1485         * unittests/basic_string_view/operations/find/char/4.cc (main):
1486         Likewise.
1487         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1488         Likewise.
1489         (main): Likewise.
1490         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1491         Likewise.
1492         (main): Likewise.
1493         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1494         Likewise.
1495         (main): Likewise.
1496         * unittests/basic_string_view/operations/substr/char/1.cc
1497         (test01): Likewise.
1498         (main): Likewise.
1499         * unittests/basic_string_view/operators/char/2.cc (main):
1500         Likewise.
1501         * unittests/optional/assignment/1.cc (test): Likewise.
1502         * unittests/optional/assignment/2.cc (test): Likewise.
1503         * unittests/optional/assignment/3.cc (test): Likewise.
1504         * unittests/optional/assignment/4.cc (test): Likewise.
1505         * unittests/optional/assignment/5.cc (test): Likewise.
1506         * unittests/optional/assignment/6.cc (test): Likewise.
1507         * unittests/optional/assignment/7.cc (test): Likewise.
1508         * unittests/optional/cons/copy.cc (test): Likewise.
1509         * unittests/optional/cons/default.cc (test): Likewise.
1510         * unittests/optional/cons/move.cc (test): Likewise.
1511         * unittests/optional/cons/value.cc (test): Likewise.
1512         * unittests/optional/in_place.cc (test): Likewise.
1513         * unittests/optional/observers/1.cc (test): Likewise.
1514         * unittests/optional/observers/2.cc (test): Likewise.
1515
1516 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1517
1518         * tui-win.h (tui_set_var_cmd): Remove.
1519         * tui-win.c (tui_set_var_cmd): Make static.
1520
1521 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1522
1523         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1524         rbreak_command_wrapper): Remove.
1525         * symtab.c (rbreak_command_wrapper): Remove.
1526
1527 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1528
1529         * inferior.h (info_terminal_command): Remove declaration.
1530         * inflow.c (info_terminal_command): Make static.
1531
1532 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1533
1534         * inferior.c (exit_inferior_silent): Remove.
1535
1536 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1537
1538         * dictionary.c (dict_empty, mdict_empty): Remove.
1539         * dictionary.c (mdict_empty): Remove.
1540
1541 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1542
1543          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1544          (arc_insn_get_memory_offset): Likewise.
1545          (arc_insn_dump): Likewise.
1546          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1547          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1548          * dictionary.c (dict_iterator_next): Likewise.
1549          (dict_iter_match_first): Likewise.
1550          (dict_iter_match_next): Likewise.
1551          * f-lang.c (evaluate_subexp_f): Likewise.
1552          * hppa-tdep.c (hppa_read_pc): Likewise.
1553          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1554          * parse.c (write_exp_elt_msym): Likewise.
1555          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1556          * remote.c (remote_packet_size): Likewise.
1557          (remote_notif_stop_parse): Likewise.
1558          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1559          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1560          * source.c (prepare_path_for_appending): Likewise.
1561          * sparc64-linux-tdep.c
1562          (sparc64_linux_handle_segmentation_fault); Likewise.
1563          * stack.c (frame_selection_by_function_completer): Likewise.
1564
1565 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1566
1567         * completer.c (set_gdb_completion_word_break_characters):
1568         Remove.
1569
1570 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1571
1572         * dwarf-index-write.c: Include dwarf-index-write.h.
1573         * mi/mi-interp.c: Include mi/mi-interp.h.
1574
1575 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1576
1577         * aarch32-tdep.c: Include aarch32-tdep.h.
1578         * aarch32-tdep.h: Forward-declare struct target_desc.
1579
1580 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1581
1582         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1583         strerror.
1584         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1585         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1586
1587 2019-11-25  Tom de Vries  <tdevries@suse.de>
1588
1589         * contrib/words.sh: Add -c option.
1590
1591 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1592
1593         * solib.c (solib_find_1): Change int to bool.
1594         (exec_file_find): Change int to bool.
1595         (solib_find): Change int to bool.
1596         (solib_read_symbols): Change int to bool.
1597         (solib_used): Change int to bool.
1598         (solib_add): Change int to bool.
1599         (info_sharedlibrary_command): Change int to bool.
1600         (solib_contains_address_p): Change int to bool.
1601         (solib_keep_data_in_core): Change int to bool.
1602         (in_solib_dynsym_resolve_code): Change int to bool.
1603         (reload_shared_libraries_1): Change int to bool.
1604         (gdb_sysroot_changed): Change int to bool.
1605         * solib.h (solib_read_symbols): Change int to bool.
1606         (solib_contains_address_p): Change int to bool.
1607         (solib_keep_data_in_core): Change int to bool.
1608         (in_solib_dynsym_resolve_code): Change int to bool.
1609         (libpthread_name_p): Change int to bool.
1610
1611 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1612
1613         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1614         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1615         (remote_packet_max_chars): New static global.
1616         (show_remote_packet_max_chars): New function.
1617         (remote_target::putpkt_binary): Adjust to use new
1618         remote_packet_max_chars option.
1619         (remote_target::getpkt_or_notif_sane_1): Likewise.
1620         (_initialize_remote): Register new remote-packet-max-chars option.
1621
1622 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1623
1624         * m68k-linux-nat.c: Include gdbarch.h.
1625
1626 2019-11-24  Tom Tromey  <tom@tromey.com>
1627
1628         * symfile.c (read_symbols): Update.
1629         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1630         bool.
1631         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1632         (psym_lookup_symbol, psym_find_last_source_symtab)
1633         (psym_forget_cached_source_info, psym_print_stats)
1634         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1635         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1636         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1637         (psym_find_compunit_symtab_by_address)
1638         (maintenance_print_psymbols, maintenance_info_psymtabs)
1639         (maintenance_check_psymtabs): Update.
1640         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1641         bool.
1642
1643 2019-11-22  Tom Tromey  <tom@tromey.com>
1644
1645         * observable.h: Update comments.
1646
1647 2019-11-22  Tom Tromey  <tromey@adacore.com>
1648
1649         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1650         (print_ada_task_info): Don't try to fetch thread id if task is not
1651         alive.
1652
1653 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1654
1655         * ada-exp.y: Update.
1656         * ada-lang.c (sort_choices): Update.
1657         (ada_print_symbol_signature): Update.
1658         (resolve_subexp): Update.
1659         (ada_parse_renaming): Update.
1660         (ada_read_renaming_var_value): Update.
1661         (lesseq_defined_than): Update.
1662         (remove_extra_symbols): Update.
1663         (remove_irrelevant_renamings): Update.
1664         (ada_add_block_symbols): Update.
1665         (ada_collect_symbol_completion_matches): Update.
1666         (ada_is_renaming_symbol): Update.
1667         (aggregate_assign_from_choices): Update.
1668         (ada_evaluate_subexp): Update.
1669         (ada_has_this_exception_support): Update.
1670         (ada_is_non_standard_exception_sym): Update.
1671         (ada_add_exceptions_from_frame): Update.
1672         (ada_add_global_exceptions): Update.
1673         (ada_print_subexp): Update.
1674         * ax-gdb.c (gen_var_ref): Update.
1675         (gen_maybe_namespace_elt): Update.
1676         (gen_expr_for_cast): Update.
1677         (gen_expr): Update.
1678         * block.h: Update.
1679         * blockframe.c (find_pc_partial_function): Update.
1680         * breakpoint.c (print_breakpoint_location): Update.
1681         (update_static_tracepoint): Update.
1682         * btrace.c (ftrace_print_function_name): Update.
1683         (ftrace_function_switched): Update.
1684         * buildsym.c (find_symbol_in_list): Update.
1685         * c-exp.y: Update.
1686         * c-typeprint.c (c_print_typedef): Update.
1687         (c_type_print_template_args): Update.
1688         * cli/cli-cmds.c (edit_command): Update.
1689         (list_command): Update.
1690         (print_sal_location): Update.
1691         * coffread.c (patch_opaque_types): Update.
1692         (process_coff_symbol): Update.
1693         (coff_read_enum_type): Update.
1694         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1695         (convert_one_symbol): Update.
1696         (hash_symname): Update.
1697         (eq_symname): Update.
1698         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1699         * compile/compile-cplus-types.c (debug_print_scope): Update.
1700         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1701         * compile/compile-object-load.c (get_out_value_type): Update.
1702         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1703         (search_symbol_list): Update.
1704         (cp_lookup_symbol_imports_or_template): Update.
1705         * cp-support.c (overload_list_add_symbol): Update.
1706         * ctfread.c (psymtab_to_symtab): Update.
1707         * dbxread.c (cp_set_block_scope): Update.
1708         * dictionary.c (iter_match_first_hashed): Update.
1709         (iter_match_next_hashed): Update.
1710         (insert_symbol_hashed): Update.
1711         (iter_match_next_linear): Update.
1712         * dictionary.h: Update.
1713         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1714         (locexpr_describe_location_piece): Update.
1715         (locexpr_describe_location_1): Update.
1716         (locexpr_generate_c_location): Update.
1717         (loclist_describe_location): Update.
1718         (loclist_generate_c_location): Update.
1719         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1720         (read_func_scope): Update.
1721         (process_enumeration_scope): Update.
1722         (new_symbol): Update.
1723         (dwarf2_const_value): Update.
1724         (dwarf2_symbol_mark_computed): Update.
1725         * eval.c (evaluate_funcall): Update.
1726         (evaluate_subexp_standard): Update.
1727         * expprint.c (print_subexp_standard): Update.
1728         (dump_subexp_body_standard): Update.
1729         * f-valprint.c (info_common_command_for_block): Update.
1730         * findvar.c (get_hosting_frame): Update.
1731         (default_read_var_value): Update.
1732         * go-lang.c (go_symbol_package_name): Update.
1733         * guile/scm-block.c (bkscm_print_block_smob): Update.
1734         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1735         (gdbscm_symbol_name): Update.
1736         (gdbscm_symbol_linkage_name): Update.
1737         (gdbscm_symbol_print_name): Update.
1738         * infcall.c (get_function_name): Update.
1739         * infcmd.c (jump_command): Update.
1740         (finish_command): Update.
1741         * infrun.c (insert_exception_resume_breakpoint): Update.
1742         * linespec.c (canonicalize_linespec): Update.
1743         (create_sals_line_offset): Update.
1744         (convert_linespec_to_sals): Update.
1745         (complete_label): Update.
1746         (find_label_symbols_in_block): Update.
1747         * m2-typeprint.c (m2_print_typedef): Update.
1748         * mdebugread.c (mdebug_reg_to_regnum): Update.
1749         (parse_symbol): Update.
1750         (mylookup_symbol): Update.
1751         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1752         (list_args_or_locals): Update.
1753         * objc-lang.c (compare_selectors): Update.
1754         (info_selectors_command): Update.
1755         (compare_classes): Update.
1756         (info_classes_command): Update.
1757         (find_imps): Update.
1758         * p-typeprint.c (pascal_print_typedef): Update.
1759         * printcmd.c (build_address_symbolic): Update.
1760         (info_address_command): Update.
1761         (print_variable_and_value): Update.
1762         * python/py-framefilter.c (extract_sym): Update.
1763         (py_print_single_arg): Update.
1764         * python/py-symbol.c (sympy_str): Update.
1765         (sympy_get_name): Update.
1766         (sympy_get_linkage_name): Update.
1767         * python/python.c (gdbpy_rbreak): Update.
1768         * record-btrace.c (btrace_get_bfun_name): Update.
1769         (btrace_call_history): Update.
1770         * rust-lang.c (rust_print_typedef): Update.
1771         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1772         * stabsread.c (stab_reg_to_regnum): Update.
1773         (define_symbol): Update.
1774         (read_enum_type): Update.
1775         (common_block_end): Update.
1776         (cleanup_undefined_types_1): Update.
1777         (scan_file_globals): Update.
1778         * stack.c (print_frame_arg): Update.
1779         (print_frame_args): Update.
1780         (find_frame_funname): Update.
1781         (info_frame_command_core): Update.
1782         (iterate_over_block_locals): Update.
1783         (print_block_frame_labels): Update.
1784         (do_print_variable_and_value): Update.
1785         (iterate_over_block_arg_vars): Update.
1786         (return_command): Update.
1787         * symmisc.c (dump_symtab_1): Update.
1788         (print_symbol): Update.
1789         * symtab.c (eq_symbol_entry): Update.
1790         (symbol_cache_dump): Update.
1791         (lookup_language_this): Update.
1792         (find_pc_sect_line): Update.
1793         (skip_prologue_sal): Update.
1794         (symbol_search::compare_search_syms): Update.
1795         (treg_matches_sym_type_name): Update.
1796         (search_symbols): Update.
1797         (print_symbol_info): Update.
1798         (rbreak_command): Update.
1799         (completion_list_add_symbol): Update.
1800         (find_gnu_ifunc): Update.
1801         (get_symbol_address): Update.
1802         (search_module_symbols): Update.
1803         (info_module_subcommand): Update.
1804         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1805         (SYMBOL_LINKAGE_NAME): Remove.
1806         (SYMBOL_DEMANGLED_NAME): Remove.
1807         (SYMBOL_PRINT_NAME): Remove.
1808         (SYMBOL_SEARCH_NAME): Remove.
1809         * tracepoint.c (set_traceframe_context): Update.
1810         (validate_actionline): Update.
1811         (collection_list::collect_symbol): Update.
1812         (encode_actions_1): Update.
1813         (info_scope_command): Update.
1814         (print_one_static_tracepoint_marker): Update.
1815         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1816         * valops.c (address_of_variable): Update.
1817         (find_overload_match): Update.
1818         (find_oload_champ): Update.
1819
1820 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1821
1822         * ada-lang.c (ada_lookup_simple_minsym): Update.
1823         (ada_collect_symbol_completion_matches): Update.
1824         * ada-tasks.c (read_atcb): Update.
1825         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1826         (amd64_windows_skip_trampoline_code): Update.
1827         * arm-tdep.c (skip_prologue_function): Update.
1828         (arm_skip_stack_protector): Update.
1829         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1830         (arm_wince_skip_main_prologue): Update.
1831         * ax-gdb.c (gen_expr): Update.
1832         * block.c (call_site_for_pc): Update.
1833         * blockframe.c (find_pc_partial_function): Update.
1834         * breakpoint.c (set_breakpoint_location_function): Update.
1835         * btrace.c (ftrace_print_function_name): Update.
1836         (ftrace_function_switched): Update.
1837         * c-valprint.c (print_unpacked_pointer): Update.
1838         * coffread.c (coff_symfile_read): Update.
1839         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1840         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1841         * dwarf-index-write.c (write_psymbols): Update.
1842         * dwarf2loc.c (call_site_to_target_addr): Update.
1843         (func_verify_no_selftailcall): Update.
1844         (tailcall_dump): Update.
1845         (call_site_find_chain_1): Update.
1846         (dwarf_expr_reg_to_entry_parameter): Update.
1847         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1848         * eval.c (evaluate_funcall): Update.
1849         (evaluate_subexp_standard): Update.
1850         (evaluate_subexp_for_sizeof): Update.
1851         * expprint.c (print_subexp_standard): Update.
1852         (dump_subexp_body_standard): Update.
1853         * frame.c (get_prev_frame_always_1): Update.
1854         * frv-tdep.c (frv_skip_main_prologue): Update.
1855         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1856         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1857         (gnuv3_get_typename_from_type_info): Update.
1858         (gnuv3_skip_trampoline): Update.
1859         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1860         * i386-tdep.c (i386_skip_main_prologue): Update.
1861         (i386_pe_skip_trampoline_code): Update.
1862         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1863         * infcall.c (get_function_name): Update.
1864         * linespec.c (minsym_found): Update.
1865         * linux-fork.c (info_checkpoints_command): Update.
1866         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1867         (m32c_m16c_pointer_to_address): Update.
1868         * maint.c (maintenance_translate_address): Update.
1869         * minsyms.c (add_minsym_to_hash_table): Update.
1870         (add_minsym_to_demangled_hash_table): Update.
1871         (lookup_minimal_symbol_mangled): Update.
1872         (lookup_minimal_symbol_demangled): Update.
1873         (lookup_minimal_symbol_linkage): Update.
1874         (lookup_minimal_symbol_text): Update.
1875         (lookup_minimal_symbol_by_pc_name): Update.
1876         (minimal_symbol_is_less_than): Update.
1877         (compact_minimal_symbols): Update.
1878         (build_minimal_symbol_hash_tables): Update.
1879         (find_solib_trampoline_target): Update.
1880         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1881         (mips_skip_pic_trampoline_code): Update.
1882         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1883         * objc-lang.c (info_selectors_command): Update.
1884         (info_classes_command): Update.
1885         (find_methods): Update.
1886         (find_imps): Update.
1887         * p-valprint.c (pascal_val_print): Update.
1888         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1889         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1890         * printcmd.c (build_address_symbolic): Update.
1891         (info_symbol_command): Update.
1892         * psymtab.c (psymbol_name_matches): Update.
1893         (match_partial_symbol): Update.
1894         (lookup_partial_symbol): Update.
1895         (print_partial_symbols): Update.
1896         (sort_pst_symbols): Update.
1897         (maintenance_check_psymtabs): Update.
1898         * python/py-framefilter.c (py_print_frame): Update.
1899         * python/python.c (gdbpy_rbreak): Update.
1900         * record-btrace.c (btrace_get_bfun_name): Update.
1901         (btrace_call_history): Update.
1902         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1903         (rs6000_skip_trampoline_code): Update.
1904         * sol-thread.c (info_cb): Update.
1905         * stabsread.c (scan_file_globals): Update.
1906         * stack.c (find_frame_funname): Update.
1907         (info_frame_command_core): Update.
1908         * symmisc.c (dump_msymbols): Update.
1909         * symtab.c (symbol_natural_name): Rename to..,
1910         (general_symbol_info::natural_name): ...this.
1911         (symbol_demangled_name): Rename to...
1912         (general_symbol_info::demangled_name): ...this.
1913         (symbol_search_name): Rename to...
1914         (general_symbol_info::search_name): ...this.
1915         (symbol_matches_search_name): Update.
1916         (find_pc_sect_line): Update.
1917         (skip_prologue_sal): Update.
1918         (search_symbols): Update.
1919         (print_msymbol_info): Update.
1920         (rbreak_command): Update.
1921         (completion_list_add_msymbol): Update.
1922         (completion_list_objc_symbol): Update.
1923         (get_msymbol_address): Update.
1924         * symtab.h (struct general_symbol_info): Add member functions
1925         natural_name (), linkage_name (), print_name (), demangled_name (),
1926         and search_name ().
1927         (SYMBOL_NATURAL_NAME): Update.
1928         (symbol_natural_name): Move to a member function on general_symbol_info.
1929         (SYMBOL_DEMANGLED_NAME): Update.
1930         (symbol_demangled_name): Move to a member function on
1931         general_symbol_info.
1932         (SYMBOL_SEARCH_NAME): Update.
1933         (symbol_search_name): Move to a member function on general_symbol_info.
1934         (MSYMBOL_NATURAL_NAME): Remove.
1935         (MSYMBOL_LINKAGE_NAME): Remove.
1936         (MSYMBOL_PRINT_NAME): Remove.
1937         (MSYMBOL_DEMANGLED_NAME): Remove.
1938         (MSYMBOL_SEARCH_NAME): Remove.
1939         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1940
1941 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1942
1943         * symtab.c (create_demangled_names_hash): Use per_bfd->
1944         minimal_symbol_count for computing the initial size, if greater
1945         than our default size.
1946
1947 2019-11-22  Tom de Vries  <tdevries@suse.de>
1948
1949         * contrib/words.sh: Improve words extraction.
1950
1951 2019-11-22  Tom de Vries  <tdevries@suse.de>
1952
1953         * contrib/words.sh: Combine sed invocations.
1954
1955 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1956
1957         * Makefile.in: Update.
1958         * demangle.c: Rename to...
1959         * gdb-demangle.c: ..this.
1960         (is_cplus_marker): Change return type to bool.
1961         (_initialize_demangler): Rename to...
1962         (_initialize_gdb_demangle): ...this.
1963         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1964         * symtab.h (demangle): Remove declaration; instead include
1965         gdb-demangle.h.
1966
1967 2019-11-21  Tom Tromey  <tromey@adacore.com>
1968
1969         * gdbsupport/format.c (format_pieces): Parse %I64d.
1970         * unittests/format_pieces-selftests.c (test_windows_formats): New
1971         function.
1972         (run_tests): Call it.
1973
1974 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1975
1976         Byte reverse display of variables with DW_END_big, DW_END_little
1977         (DW_AT_endianity) dwarf attributes if different than the native
1978         byte order.
1979         * ada-lang.c (ada_value_binop):
1980         Use type_byte_order instead of gdbarch_byte_order.
1981         * ada-valprint.c (printstr):
1982         (ada_val_print_string):
1983         * ada-lang.c (value_pointer):
1984         (ada_value_binop):
1985         Use type_byte_order instead of gdbarch_byte_order.
1986         * c-lang.c (c_get_string):
1987         Use type_byte_order instead of gdbarch_byte_order.
1988         * c-valprint.c (c_val_print_array):
1989         Use type_byte_order instead of gdbarch_byte_order.
1990         * cp-valprint.c (cp_print_class_member):
1991         Use type_byte_order instead of gdbarch_byte_order.
1992         * dwarf2loc.c (rw_pieced_value):
1993         Use type_byte_order instead of gdbarch_byte_order.
1994         * dwarf2read.c (read_base_type): Handle DW_END_big,
1995         DW_END_little
1996         * f-lang.c (f_get_encoding):
1997         Use type_byte_order instead of gdbarch_byte_order.
1998         * findvar.c (default_read_var_value):
1999         Use type_byte_order instead of gdbarch_byte_order.
2000         * gdbtypes.c (check_types_equal):
2001         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
2002         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
2003         and TYPE_ENDIANITY_LITTLE if set.
2004         (type_byte_order): new function.
2005         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
2006         (struct main_type) <flag_endianity_not_default>:
2007         New field.
2008         (type_byte_order): New function.
2009         * infcmd.c (default_print_one_register_info):
2010         Use type_byte_order instead of gdbarch_byte_order.
2011         * p-lang.c (pascal_printstr):
2012         Use type_byte_order instead of gdbarch_byte_order.
2013         * p-valprint.c (pascal_val_print):
2014         Use type_byte_order instead of gdbarch_byte_order.
2015         * printcmd.c (print_scalar_formatted):
2016         Use type_byte_order instead of gdbarch_byte_order.
2017         * solib-darwin.c (darwin_current_sos):
2018         Use type_byte_order instead of gdbarch_byte_order.
2019         * solib-svr4.c (solib_svr4_r_ldsomap):
2020         Use type_byte_order instead of gdbarch_byte_order.
2021         * stap-probe.c (stap_modify_semaphore):
2022         Use type_byte_order instead of gdbarch_byte_order.
2023         * target-float.c (target_float_same_format_p):
2024         Use type_byte_order instead of gdbarch_byte_order.
2025         * valarith.c (scalar_binop):
2026         (value_bit_index):
2027         Use type_byte_order instead of gdbarch_byte_order.
2028         * valops.c (value_cast):
2029         Use type_byte_order instead of gdbarch_byte_order.
2030         * valprint.c (generic_emit_char):
2031         (generic_printstr):
2032         (val_print_string):
2033         Use type_byte_order instead of gdbarch_byte_order.
2034         * value.c (unpack_long):
2035         (unpack_bits_as_long):
2036         (unpack_value_bitfield):
2037         (modify_field):
2038         (pack_long):
2039         (pack_unsigned_long):
2040         Use type_byte_order instead of gdbarch_byte_order.
2041         * findvar.c (unsigned_pointer_to_address):
2042         (signed_pointer_to_address):
2043         (unsigned_address_to_pointer):
2044         (address_to_signed_pointer):
2045         (default_read_var_value):
2046         (default_value_from_register):
2047         Use type_byte_order instead of gdbarch_byte_order.
2048         * gnu-v3-abi.c (gnuv3_make_method_ptr):
2049         Use type_byte_order instead of gdbarch_byte_order.
2050         * riscv-tdep.c (riscv_print_one_register_info):
2051         Use type_byte_order instead of gdbarch_byte_order.
2052
2053 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
2054
2055         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
2056         (current_ui_gdb_stdin_ptr): Likewise.
2057         (current_ui_gdb_stderr_ptr): Likewise.
2058         (current_ui_gdb_stdlog_ptr): Likewise.
2059         (current_ui_current_uiout_ptr): Likewise.
2060         (gen_ret_current_ui_field_ptr): Remove.
2061
2062 2019-11-21  Tom de Vries  <tdevries@suse.de>
2063
2064         PR gdb/24956
2065         * cli/cli-script.c (execute_control_command): Only switch to
2066         INTERP_CONSOLE's ui_out when INTERP_MI is active.
2067
2068 2019-11-19  Tom Tromey  <tom@tromey.com>
2069
2070         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2071         Now static.  Change type of "name".
2072         (tui_set_win_height_command): Don't copy "arg".
2073         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2074         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2075
2076 2019-11-19  Ali Tamur <tamur@google.com>
2077
2078         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2079         "if (attr != nullptr)".
2080         (dwarf2_find_base_address): Likewise.
2081         (dwarf2_build_include_psymtabs): Likewise.
2082         (read_cutu_die_from_dwo): Likewise.
2083         (read_func_scope): Likewise.
2084         (read_call_site_scope): Likewise.
2085         (dwarf2_get_pc_bounds): Likewise.
2086         (dwarf2_record_block_ranges): Likewise.
2087         (dwarf2_add_field): Likewise.
2088         (dwarf2_add_member_fn): Likewise.
2089         (read_structure_type): Likewise.
2090         (read_enumeration_type): Likewise.
2091         (read_array_type): Likewise.
2092         (read_array_order): Likewise.
2093         (read_set_type): Likewise.
2094         (read_common_block): Likewise.
2095         (read_tag_reference_type): Likewise.
2096         (read_tag_string_type): Likewise.
2097         (read_subroutine_type): Likewise.
2098         (read_base_type): Likewise.
2099         (read_subrange_type): Likewise.
2100         (new_symbol): Likewise.
2101         (prepare_one_comp_unit): Likewise.
2102
2103 2019-11-19  Tom Tromey  <tromey@adacore.com>
2104
2105         * windows-nat.c (windows_nat_target::attach): Include GetLastError
2106         result in error when DebugActiveProcess fails.
2107
2108 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
2109             Pedro Alves  <palves@redhat.com>
2110
2111         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2112         * target.c (target_stack::push): Call 'unpush' if there's a
2113         target on top of the stack.
2114
2115 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2116
2117         * python/py-block.c (blpy_dealloc): Call tp_free.
2118         (blpy_block_syms_dealloc): Likewise.
2119         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2120         * python/py-inferior.c (infpy_dealloc): Likewise.
2121         * python/py-lazy-string.c (stpy_dealloc): Likewise.
2122         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2123         * python/py-symbol.c (sympy_dealloc): Likewise.
2124         * python/py-symtab.c (stpy_dealloc): Likewise.
2125         * python/py-type.c (typy_iterator_dealloc): Likewise.
2126
2127 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
2128
2129         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2130         constructor instead of using a class initializer.
2131
2132 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2133
2134         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2135         * configure: Regenerate.
2136         * configure.ac: Don't source common.host.
2137         * gdbsupport/common.host: Remove.
2138         * gdbsupport/mingw-strerror.c: Remove.
2139         * gdbsupport/posix-strerror.c: Rename to...
2140         * gdbsupport/safe-strerror.c: ...this.
2141
2142 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2143
2144         * maint.c (scoped_command_stats::print_time): Use localtime_r
2145         instead of localtime (provided through gnulib if necessary).
2146         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2147         of ctime.
2148
2149 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2150
2151         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2152         avoid compile errors.
2153
2154 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2155
2156         * config.in: Regenerate.
2157         * configure: Regenerate.
2158         * gdbsupport/common.m4: No longer check for strerror_r.
2159         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2160         POSIX version of strerror_r, now that gnulib provides it if
2161         necessary.
2162
2163 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
2164
2165         * README (`configure' options): Update.
2166
2167 2019-11-14  Tom Tromey  <tromey@adacore.com>
2168
2169         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2170         expected type for the RHS if the LHS is a convenience variable.
2171
2172 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
2173
2174         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2175         Provide explicit default and copy constructor.
2176
2177 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2178
2179         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2180         only call Py_INCREF (newbp) in the bppy_pending_object case.
2181
2182 2019-11-13  Tom Tromey  <tromey@adacore.com>
2183
2184         PR build/25182:
2185         * psympriv.h (partial_symbol): Remove static assert.
2186         * symtab.h (general_symbol_info, symbol): Remove static assert.
2187
2188 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2189
2190         * gdbsupport/format.c (format_pieces::format_pieces): Support
2191         printf 'z' size modifier.
2192         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2193         * printcmd.c (ui_printf):  Handle size_t_arg.
2194         * ui-out.c (ui_out::vmessage): Likewise.
2195         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2196         function.
2197         (run_tests): Call test_format_int_sizes.
2198
2199 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2200
2201         * ada-exp.y (write_ambiguous_var): Update.
2202         * buildsym.c (add_symbol_to_list): Update.
2203         * dwarf2read.c (read_variable): Update.
2204         (new_symbol): Update.
2205         * jit.c (finalize_symtab): Update.
2206         * language.c (language_alloc_type_symbol): Update.
2207         * symtab.c (fixup_symbol_section): Update.
2208         (initialize_objfile_symbol_1): Move code to...
2209         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2210         (allocate_symbol): Update.
2211         (allocate_template_symbol): Update.
2212         (get_symbol_address): Update.
2213         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2214         of having as a field, and add a constructor.
2215         (SYMBOL_VALUE): Update.
2216         (SYMBOL_VALUE_ADDRESS): Update.
2217         (SET_SYMBOL_VALUE_ADDRESS): Update.
2218         (SYMBOL_VALUE_BYTES): Update.
2219         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2220         (SYMBOL_BLOCK_VALUE): Update.
2221         (SYMBOL_VALUE_CHAIN): Update.
2222         (SYMBOL_LANGUAGE): Update.
2223         (SYMBOL_SECTION): Update.
2224         (SYMBOL_OBJ_SECTION): Update.
2225         (SYMBOL_SET_LANGUAGE): Update.
2226         (SYMBOL_SET_LINKAGE_NAME): Update.
2227         (SYMBOL_SET_NAMES): Update.
2228         (SYMBOL_NATURAL_NAME): Update.
2229         (SYMBOL_LINKAGE_NAME): Update.
2230         (SYMBOL_DEMANGLED_NAME): Update.
2231         (SYMBOL_SEARCH_NAME): Update.
2232         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2233         (struct symbol): Update.
2234         (struct template_symbol): Update.
2235         (struct rust_vtable_symbol): Update.
2236         * xcoffread.c (SYMBOL_DUP): Update.
2237
2238 2019-11-12  Tom Tromey  <tom@tromey.com>
2239
2240         * tui/tui-layout.c (show_layout): Set current_layout.
2241         (show_source_disasm_command, show_data)
2242         (show_source_or_disasm_and_command): Don't set current_layout.
2243
2244 2019-11-12  Tom Tromey  <tom@tromey.com>
2245
2246         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2247
2248 2019-11-12  Tom Tromey  <tom@tromey.com>
2249
2250         * tui/tui-win.c (resize_message): New global.
2251         (show_tui_resize_message): New function.
2252         (tui_async_resize_screen): Print message if requested.
2253         (_initialize_tui_win): Add tui-resize-message setting.
2254         * NEWS: Add entry for new commands.
2255
2256 2019-11-11  Tom Tromey  <tom@tromey.com>
2257
2258         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2259         functions.
2260
2261 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2262
2263         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2264
2265 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2266
2267         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2268         function.
2269         * python/python-internal.h (gdbpy_lookup_static_symbols):
2270         Declare new function.
2271         * python/python.c (python_GdbMethods): Add
2272         gdb.lookup_static_symbols method.
2273         * NEWS: Mention gdb.lookup_static_symbols.
2274
2275 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2276
2277         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2278         static block of current object file first.  Also fix typo in
2279         header comment.
2280
2281 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2282
2283         * stack.c (set_last_displayed_sal): Delete.
2284         (last_displayed_sal_valid): Delete.
2285         (last_displayed_pspace): Delete.
2286         (last_displayed_addr): Delete.
2287         (last_displayed_symtab): Delete.
2288         (last_displayed_line): Delete.
2289         (class last_displayed_symtab_info_type): New.
2290         (last_displayed_symtab_info): New static global variable.
2291         (print_frame_info): Call methods on last_displayed_symtab_info.
2292         (clear_last_displayed_sal): Update header comment, and make use of
2293         last_displayed_symtab_info.
2294         (last_displayed_sal_is_valid): Likewise.
2295         (get_last_displayed_pspace): Likewise.
2296         (get_last_displayed_addr): Likewise.
2297         (get_last_displayed_symtab): Likewise.
2298         (get_last_displayed_line): Likewise.
2299         (get_last_displayed_sal): Likewise.
2300         * stack.h (clear_last_displayed_sal): Update header comment.
2301         (last_displayed_sal_is_valid): Likewise.
2302         (get_last_displayed_pspace): Likewise.
2303         (get_last_displayed_addr): Likewise.
2304         (get_last_displayed_symtab): Likewise.
2305         (get_last_displayed_line): Likewise.
2306         (get_last_displayed_sal): Likewise.
2307
2308 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2309
2310         * stack.c (frame_show_address): Convert return type to bool.
2311         * stack.h (frame_show_address): Likewise, and update header
2312         comment.
2313
2314 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2315
2316         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2317         * unittests/vec-utils-selftests.c: New file.
2318         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2319
2320 2019-11-10  Tom Tromey  <tom@tromey.com>
2321
2322         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2323         (tui_highlight_win): Likewise.
2324         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2325         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2326         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2327         Don't set can_highlight.
2328
2329 2019-11-10  Tom Tromey  <tom@tromey.com>
2330
2331         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2332         Remove unused declaration.
2333
2334 2019-11-08  Tom Tromey  <tromey@adacore.com>
2335
2336         * top.c (read_command_file): Update.
2337         (command_line_input): Make return type const.
2338         * python/py-gdb-readline.c: Update.
2339         * linespec.c (decode_line_2): Update.
2340         * defs.h (command_line_input): Make return type const.
2341         * cli/cli-script.c (read_next_line): Make return type const.
2342         * ada-lang.c (get_selections): Update.
2343
2344 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2345
2346         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2347         * mi/mi-main.c (output_cores): Likewise.
2348         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2349         (linux_xfer_osdata_modules): Likewise.
2350         * remote.c (register_remote_support_xml): Likewise.
2351         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2352         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2353
2354 2019-11-06  Tom Tromey  <tom@tromey.com>
2355
2356         * tui/tui-interp.c: Don't include readline.h.
2357         * tui/tui-hooks.c: Don't include readline.h.
2358         * symmisc.c: Include tilde.h, not readline.h.
2359         * symfile.c: Include tilde.h, not readline.h.
2360         * source.c: Include tilde.h, not readline.h.
2361         * solib.c: Include tilde.h, not readline.h.
2362         * psymtab.c: Include tilde.h, not readline.h.
2363         * exec.c: Include tilde.h, not readline.h.
2364         * corelow.c: Include tilde.h, not readline.h.
2365         * cli/cli-dump.c: Include tilde.h, not readline.h.
2366         * cli/cli-cmds.c: Don't include readline.h.
2367
2368 2019-11-05  Tom Tromey  <tom@tromey.com>
2369
2370         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2371         (tui_disassemble): Set addr_size.
2372         (tui_disasm_window::set_contents): Use addr_size.
2373
2374 2019-11-05  Tom Tromey  <tom@tromey.com>
2375
2376         * rust-lang.c (rust_language_defn): Update.
2377         * python/py-value.c (valpy_string): Call c_get_string.
2378         * p-lang.c (pascal_language_defn): Update.
2379         * opencl-lang.c (opencl_language_defn): Update.
2380         * objc-lang.c (objc_language_defn): Update.
2381         * m2-lang.c (m2_language_defn): Update.
2382         * language.c (unknown_language_defn, auto_language_defn): Update.
2383         (default_get_string): Remove.
2384         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2385         * go-lang.c (go_language_defn): Update.
2386         * f-lang.c (f_language_defn): Update.
2387         * d-lang.c (d_language_defn): Update.
2388         * c-lang.c (c_language_defn, cplus_language_defn)
2389         (asm_language_defn, minimal_language_defn): Update.
2390         * ada-lang.c (ada_language_defn): Update.
2391         * language.h (struct language_defn) <la_get_string>: Remove.
2392         (LA_GET_STRING): Remove.
2393         (default_get_string): Don't declare.
2394
2395 2019-11-05  Tom Tromey  <tom@tromey.com>
2396
2397         * tui/tui-source.h (struct tui_source_window): Inline
2398         constructor.  Remove destructor.
2399         <style_changed, m_observable>: Move to superclass.
2400         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2401         (struct tui_source_window_base): Move private members to end.
2402         <style_changed, m_observable>: Move from tui_source_window.
2403         * tui/tui-winsource.c (tui_copy_source_line): Move from
2404         tui-source.c.  Rename from copy_source_line.  Add special handling
2405         for negative line number.
2406         (tui_source_window_base::style_changed): Move from
2407         tui_source_window.
2408         (tui_source_window_base): Register observer.
2409         (~tui_source_window_base): New.
2410         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2411         rename.
2412         (tui_source_window::set_contents): Use tui_copy_source_line.
2413         (tui_source_window::tui_source_window): Move to tui-source.h.
2414         (tui_source_window::~tui_source_window): Remove.
2415         (tui_source_window::style_changed): Move to superclass.
2416         * tui/tui-disasm.c (tui_disassemble): Create string file with
2417         styling, when possible.  Add "addr_size" parameter.
2418         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2419         Don't compute maximum size.
2420         (len_without_escapes): New function
2421
2422 2019-11-05  Tom Tromey  <tom@tromey.com>
2423
2424         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2425         std::string.
2426         * tui/tui-winsource.c (tui_show_source_line): Update.
2427         * tui/tui-source.c (tui_source_window::set_contents): Update.
2428         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2429
2430 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2431
2432         * symtab.h (gdb_static_assert): Put && operator at the beginning
2433         of the line instead of the end.
2434
2435 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2436
2437         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2438         and sizeof (symbol).
2439         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2440
2441 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2442
2443         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2444         * configure.host: Mark *-*-solaris2.10* obsolete.
2445         * configure.tgt: Mark Solaris < 11 obsolete.
2446         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2447         Update target triplet.
2448
2449 2019-11-01  Tom Tromey  <tromey@adacore.com>
2450
2451         * utils.c (print_sys_errmsg): Simplify.
2452
2453 2019-11-01  Tom Tromey  <tromey@adacore.com>
2454
2455         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2456
2457 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2458
2459         * configure: Regenerate.
2460         * configure.ac: Remove check for strerror_r.
2461         * gdbsupport/common.m4: Check for strerror_r.
2462
2463 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2464
2465         PR gdb/25124
2466
2467         * arm-tdep.c (arm_per_objfile): Rename to ...
2468         (arm_per_bfd): ... this.
2469         (arm_objfile_data_key): Rename to ...
2470         (arm_bfd_data_key): ... this.
2471         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2472         data.
2473         (arm_record_special_symbol): Likewise.
2474
2475 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2476
2477         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2478         end.
2479         * c-typeprint.c (c_print_typedef): Likewise.
2480         * f-typeprint.c (f_print_typedef): Likewise.
2481         * m2-typeprint.c (m2_print_typedef): Likewise.
2482         * p-typeprint.c (pascal_print_typedef): Likewise.
2483         * rust-lang.c (rust_print_typedef): Likewise.
2484         * symtab.c (print_symbol_info): Print a newline after calling
2485         typedef_print.
2486
2487 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2488
2489         * symtab.c (info_module_cmdlist): New variable.
2490         (info_module_command): New function.
2491         (search_module_symbols): New function.
2492         (info_module_subcommand): New function.
2493         (struct info_modules_var_func_options): New struct.
2494         (info_modules_var_func_options_defs): New variable.
2495         (make_info_modules_var_func_options_def_group): New function.
2496         (info_module_functions_command): New function.
2497         (info_module_variables_command): New function.
2498         (info_module_var_func_command_completer): New function.
2499         (_initialize_symtab): Register new 'info module functions' and
2500         'info module variables' commands.
2501         * symtab.h (typedef symbol_search_in_module): New typedef.
2502         (search_module_symbols): Declare new function.
2503         * NEWS: Mention new commands.
2504
2505 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2506
2507         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2508         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2509         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2510         MODULES_DOMAIN.
2511         (scan_partial_symbols): Only create partial module symbols for non
2512         declarations.
2513         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2514         and MODULES_DOMAIN.
2515         * symtab.c (search_domain_name): Likewise.
2516         (search_symbols): Likewise.
2517         (print_symbol_info): Likewise.
2518         (symtab_symbol_info): Likewise.
2519         (info_modules_command): New function.
2520         (_initialize_symtab): Register 'info modules' command.
2521         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2522         * NEWS: Mention new 'info modules' command.
2523
2524 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2525
2526         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2527         and $_gdb_maint_setting_str.
2528
2529 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2530
2531         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2532         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2533         (str_value_from_setting, gdb_setting_str_internal_fn)
2534         (gdb_maint_setting_str_internal_fn): New functions.
2535         (_initialize_cli_cmds): Define the new convenience functions.
2536         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2537         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2538
2539 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2540
2541         * agent.c (set_can_use_agent): When the setting is turned on,
2542         look up agent symbols if we don't have them yet.
2543         (agent_new_objfile): Don't look up agent symbols when the agent
2544         setting is off.
2545
2546 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2547
2548         * config.in: Regenerate.
2549
2550 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2551
2552         * configure: Regenerate.
2553         * configure.ac: Check for strerror_r.
2554         * gdbsupport/common-utils.h (safe_strerror): Change return value
2555         to const char * and document that this function is now threadsafe.
2556         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2557         thread_local and call strerror_r, if available.
2558         * utils.c (perror_string): Update.
2559         (print_sys_errmsg): Update.
2560
2561 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2562
2563         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2564         objfile_key.
2565         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2566         objfile to fetch per-bfd data.
2567         (arm_find_exidx_entry): Likewise.
2568
2569 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2570
2571         * gdbsupport/agent.c (debug_agent): Change type to bool.
2572         (use_agent): Likewise.
2573         (all_agent_symbols_look_up): Likewise.
2574         (agent_loaded_p): Change return value to bool.
2575         (agent_look_up_symbols): Update.
2576         (agent_capability_check): Change return value to bool.
2577         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2578         (debug_agent): Change type to bool.
2579         (use_agent): Likewise.
2580         (agent_capability_check): Change return value to bool.
2581
2582 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2583
2584         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2585         (build_minimal_symbol_hash_tables): Code to clear the table moved
2586         to clear_minimal_symbol_hash_tables.
2587         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2588         when needed.
2589
2590 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2591
2592         * infcmd.c: Remove includes.
2593         * infrun.c: Remove includes.
2594
2595 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2596
2597         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2598         (grow_vect): Remove declaration.
2599         (ada_type_of_array): Remove declaration.
2600         (ada_update_initial_language): Remove declaration.
2601         (ada_fold_name): Remove declaration.
2602         (ada_fill_in_ada_prototype): Remove declaration.
2603         (user_select_syms): Remove declaration.
2604         (get_selections): Remove declaration.
2605         (ada_tag_type): Remove declaration.
2606         (ada_value_tag): Remove declaration.
2607         (ada_is_others_clause): Remove declaration.
2608         (ada_in_variant): Remove declaration.
2609         (ada_value_struct_elt): Remove declaration.
2610         (ada_attribute_name): Remove declaration.
2611         (ada_system_address_type): Remove declaration.
2612         * ada-lang.c (ada_watch_location_expression): Make static.
2613         (GROW_VECT): Move here from ada-lang.h.
2614         (grow_vect): Make static.
2615         (ada_update_initial_language): Make static.
2616         (ada_fold_name): Make static.
2617         (ada_type_of_array): Make static.
2618         (encoded_ordered_before): Move up.
2619         (sort_choices): Move up.
2620         (print_signatures): Move up.
2621         (ada_print_symbol_signature): Move up.
2622         (get_selections): Move up and make static.
2623         (user_select_syms): Move up and make static.
2624         (ada_value_struct_elt): Move up and make static.
2625         (ada_tag_type): Make static.
2626         (ada_value_tag): Make static.
2627         (ada_is_others_clause): Make static.
2628         (ada_in_variant): Make static.
2629         (ada_attribute_name): Make static.
2630
2631 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2632
2633         * ada-lang.c: Remove includes.
2634         * ada-typeprint.c: Remove includes.
2635         * ada-valprint.c: Remove includes.
2636
2637 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2638
2639         * addrmap.c: Add static assertions of type size, moved from
2640         _initialize_addrmap.
2641         (_initialize_addrmap): Remove.
2642
2643 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2644
2645         * coffread.c (record_minimal_symbol): Update.
2646         (process_coff_symbol): Update.
2647         * dbxread.c (read_dbx_symtab): Update.
2648         * dwarf2read.c (add_partial_symbol): Update.
2649         (fixup_go_packaging): Update.
2650         (load_partial_dies): Update.
2651         (new_symbol): Update.
2652         * elfread.c (record_minimal_symbol): Change signature to use
2653         gdb::string_view instead of name+len.
2654         (elf_symtab_read): Update.
2655         (elf_rel_plt_read): Update.
2656         * mdebugread.c (parse_partial_symbols): Update.
2657         (handle_psymbol_enumerators): Update.
2658         (new_symbol): Update.
2659         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2660         to use gdb::string_view instead of name+len.
2661         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2662         * psympriv.h (add_psymbol_to_list): Likewise.
2663         * psymtab.c (add_psymbol_to_bcache): Likewise.
2664         (add_psymbol_to_list): Likewise.
2665         * stabsread.c (define_symbol): Update.
2666         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2667         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2668         (symbol_set_names): Likewise.
2669         * xcoffread.c (scan_xcoff_symtab): Update.
2670
2671 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2672
2673         * symtab.h (symbol_set_names): Document that copy_name must be
2674         set to true for non-nullterminated strings.
2675         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2676         linkage_name if the entry was not found and we need to demangle.
2677
2678 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2679
2680         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2681         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2682         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2683         * gdbsupport/gdb_binary_search.h: New file.
2684
2685 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2686
2687         * NEWS: Mention new --with-system-gdbinit-dir option.
2688         * config.in: Regenerate.
2689         * configure: Regenerate.
2690         * configure.ac: Add new option --with-system-gdbinit-dir.
2691         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2692         for a ".gdb" suffix.
2693         * main.c (get_init_files): Change system_gdbinit argument to
2694         a vector and return the files in SYSTEM_GDBINIT_DIR in
2695         addition to SYSTEM_GDBINIT.
2696         (captured_main_1): Update.
2697         (print_gdb_help): Update.
2698         * top.c (print_gdb_configuration): Also print the value of
2699         SYSTEM_GDBINIT_DIR.
2700
2701 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2702
2703         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2704         that takes gdb::string_view arguments.
2705
2706 2019-10-26  Tom de Vries  <tdevries@suse.de>
2707
2708         * aarch64-linux-tdep.c: Fix typos in comments.
2709         * aarch64-tdep.c: Same.
2710         * ada-lang.c: Same.
2711         * amd64-nat.c: Same.
2712         * arc-tdep.c: Same.
2713         * arch/aarch64-insn.c: Same.
2714         * block.c: Same.
2715         * breakpoint.h: Same.
2716         * btrace.h: Same.
2717         * c-varobj.c: Same.
2718         * cli/cli-decode.c: Same.
2719         * cli/cli-script.c: Same.
2720         * cli/cli-utils.h: Same.
2721         * coff-pe-read.c: Same.
2722         * coffread.c: Same.
2723         * compile/compile-cplus-symbols.c: Same.
2724         * compile/compile-object-run.c: Same.
2725         * completer.c: Same.
2726         * corelow.c: Same.
2727         * cp-support.c: Same.
2728         * demangle.c: Same.
2729         * dwarf-index-write.c: Same.
2730         * dwarf2-frame.c: Same.
2731         * dwarf2-frame.h: Same.
2732         * eval.c: Same.
2733         * frame-base.h: Same.
2734         * frame.h: Same.
2735         * gdbcmd.h: Same.
2736         * gdbtypes.h: Same.
2737         * gnu-nat.c: Same.
2738         * guile/scm-objfile.c: Same.
2739         * i386-tdep.c: Same.
2740         * i386-tdep.h: Same.
2741         * infcall.c: Same.
2742         * infcall.h: Same.
2743         * linux-nat.c: Same.
2744         * m68k-tdep.c: Same.
2745         * macroexp.c: Same.
2746         * memattr.c: Same.
2747         * mi/mi-cmd-disas.c: Same.
2748         * mi/mi-getopt.h: Same.
2749         * mi/mi-main.c: Same.
2750         * minsyms.c: Same.
2751         * nat/aarch64-sve-linux-sigcontext.h: Same.
2752         * objfiles.h: Same.
2753         * ppc-linux-nat.c: Same.
2754         * ppc-linux-tdep.c: Same.
2755         * ppc-tdep.h: Same.
2756         * progspace.h: Same.
2757         * prologue-value.h: Same.
2758         * python/py-evtregistry.c: Same.
2759         * python/py-instruction.h: Same.
2760         * record-btrace.c: Same.
2761         * record-full.c: Same.
2762         * remote.c: Same.
2763         * rs6000-tdep.c: Same.
2764         * ser-tcp.c: Same.
2765         * sol-thread.c: Same.
2766         * sparc-sol2-tdep.c: Same.
2767         * sparc64-tdep.c: Same.
2768         * stabsread.c: Same.
2769         * symfile.c: Same.
2770         * symtab.h: Same.
2771         * target.c: Same.
2772         * tracepoint.c: Same.
2773         * tui/tui-data.h: Same.
2774         * tui/tui-io.c: Same.
2775         * tui/tui-win.c: Same.
2776         * tui/tui.c: Same.
2777         * unittests/rsp-low-selftests.c: Same.
2778         * user-regs.h: Same.
2779         * utils.c: Same.
2780         * utils.h: Same.
2781         * valarith.c: Same.
2782         * valops.c: Same.
2783         * valprint.c: Same.
2784         * valprint.h: Same.
2785         * value.c: Same.
2786         * value.h: Same.
2787         * varobj.c: Same.
2788         * x86-nat.h: Same.
2789         * xtensa-tdep.c: Same.
2790
2791 2019-10-25  Ali Tamur <tamur@google.com>
2792
2793         * charset.c (find_charset_names): Reflect API change.
2794
2795 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2796
2797         * symtab.c (struct demangled_name_entry): Change demangled name
2798         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2799         part of the struct anymore.
2800         (symbol_set_names): No longer obstack allocate + copy the demangled
2801         name, just store the allocated name from bfd.
2802
2803 2019-10-25  Tom Tromey  <tromey@adacore.com>
2804
2805         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2806         (bsearch_cie_cmp, add_cie): Remove.
2807         (find_cie): Reimplement.
2808         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2809         (dwarf2_build_frame_info): Update.
2810
2811 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2812
2813         PR gdb/25126
2814         * symfile.c (reread_symbols): Call forget_cached_source_info to
2815         clear the stale source cache.
2816
2817 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2818
2819         * configure: Regenerate.
2820         * configure.ac: Remove code that sets python_has_threads.
2821
2822 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2823
2824         * config.in: Regenerate.
2825         * configure: Regenerate.
2826         * configure.ac: Remove the code that uses sed to get the python
2827         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2828
2829 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2830
2831         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2832         error paths.
2833
2834 2019-10-23  Tom Tromey  <tom@tromey.com>
2835
2836         * arc-tdep.c: Remove ".." from include.
2837         * frv-tdep.c: Remove ".." from include.
2838         * lm32-tdep.c: Remove ".." from include.
2839         * microblaze-tdep.c: Remove ".." from include.
2840         * or1k-tdep.h: Remove ".." from include.
2841         * s12z-tdep.c: Remove ".." from include.
2842         * Makefile.in (OPCODES_CFLAGS): Add comment.
2843         (TOP_CFLAGS): New variable.
2844         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2845
2846 2019-10-23  Tom Tromey  <tom@tromey.com>
2847
2848         * Makefile.in (READLINE_DIR): Update.
2849
2850 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2851
2852         * infcall.c (call_function_by_hand_dummy): Fix the function
2853         comment.  And extract out a code section into...
2854         (reserve_stack_space): ...this new function.
2855
2856 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2857
2858         * infcall.c (value_arg_coerce): Remove an unused parameter.
2859         (call_function_by_hand_dummy): Update the call to
2860         'value_arg_coerce'.
2861
2862 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2863
2864         * infcall.c (call_function_by_hand_dummy): Refactor.
2865
2866 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2867
2868         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2869
2870 2019-10-23  Tom Tromey  <tom@tromey.com>
2871
2872         * configure: Rebuild.
2873         * configure.ac: Don't check for sigprocmask.
2874         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2875
2876 2019-10-23  Tom Tromey  <tom@tromey.com>
2877
2878         * configure: Rebuild.
2879         * acinclude.m4: Use m4_include, not sinclude.
2880
2881 2019-10-23  Tom de Vries  <tdevries@suse.de>
2882
2883         PR breakpoints/24687
2884         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2885
2886 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2887
2888         * symtab.c (struct demangled_name_entry) <language>: Change from
2889         bitfield to regular variable.
2890
2891 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2892
2893         * symtab.c (struct demangled_name_entry): Add a constructor.
2894         (free_demangled_name_entry): New function to call the destructor
2895         for demangled_name_entry.
2896         (create_demangled_names_hash): Pass free_demangled_name_entry to
2897         htab_create_alloc.
2898         (symbol_set_names): Call placement new for demangled_name_entry.
2899         * utils.c: No longer include xxhash.h here, now that fast_hash
2900         is inlined in the header.
2901         * utils.h: Instead, include it here.
2902
2903 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2904
2905         * Makefile.in: Link with libxxhash.
2906         * config.in: Regenerate.
2907         * configure: Regenerate.
2908         * configure.ac: Search for libxxhash.
2909         * utils.c (fast_hash): Use xxhash if present.
2910
2911 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2912
2913         * utils.h (fast_hash): New function.
2914         * symtab.c (hash_demangled_name_entry): Call new function
2915         fast_hash.
2916
2917 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2918
2919         * symtab.c (struct demangled_name_entry): Change type of mangled
2920         to gdb::string_view. Also adds a constructor that takes the
2921         mangled name.
2922         (hash_demangled_name_entry): Update.
2923         (eq_demangled_name_entry): Update.
2924         (free_demangled_name_entry): New function to call the destructor
2925         now that this is not a POD anymore.
2926         (create_demangled_names_hash): Pass free_demangled_name_entry to
2927         htab_create_alloc.
2928         (symbol_set_names): Update.
2929
2930 2019-10-21  Ali Tamur  <tamu@google.com>
2931
2932         * dwarf2read.c (dir_index): Change type.
2933         (file_name_index): Likewise.
2934         (line_header::include_dir_at): Change comment and implementation on
2935         whether it is DWARF 5.
2936         (line_header::is_valid_file_index): New function.
2937         (line_header::file_name_at): Change comment and implementation on
2938         whether it is DWARF 5.
2939         (line_header::file_names): Change to private field renamed as
2940         m_file_names and introduce a new accessor method.
2941         (line_header::file_names_size): New method.
2942         (line_header::include_dirs): Change to private field and rename as
2943         m_include_dirs.
2944         (dw2_get_file_names_reader): Define local var at a smaller scope and
2945         reflect API change.
2946         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2947         (process_structure_scope): Likewise.
2948         (line_header::add_include_dir): Change message and reflect renaming.
2949         (line_header::add_file_name): Likewise.
2950         (read_formatted_entries): Handle DW_FORM_data16.
2951         (dwarf_decode_line_header): Fix line header length calculation.
2952         (psymtab_include_file_name): Change comment and API.
2953         (lnp_state_machine::m_file): Update comment and reflect type change.
2954         (lnp_state_machine::record_line): Reflect type change.
2955         (dwarf_decode_lines): Reflect API change.
2956         (file_file_name): Likewise.
2957         (file_full_name): Likewise.
2958
2959 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2960
2961         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2962
2963 2019-10-21  Tom Tromey  <tom@tromey.com>
2964
2965         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2966
2967 2019-10-21  Tom Tromey  <tom@tromey.com>
2968
2969         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2970         NM_H.   Use AC_CONFIG_LINKS.
2971         * configure: Rebuild.
2972         * Makefile.in (NM_H): New variable.
2973         (generated_files): Add NM_H.  Remove gcore.
2974         (nm.h, stamp-nmh): New targets.
2975
2976 2019-10-20  Tom Tromey  <tom@tromey.com>
2977
2978         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2979         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2980         obsolete comment.
2981         (put_objfile_before): Now static.
2982
2983 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2984
2985         * gdbsupport/common-utils.h (startswith): Change return type to
2986         bool.
2987
2988 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2989
2990         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2991         * breakpoint.c (bp_locations_compare): Rename to...
2992         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2993         (update_global_location_list): Use std::sort instead of qsort.
2994         * buildsym.c (compare_line_numbers): Rename to...
2995         (lte_is_less_than): ...this, and change to std::sort semantics.
2996         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2997         instead of qsort.
2998         * disasm.c (compare_lines): Rename to...
2999         (line_is_less_than): ...this, and change to std::sort semantics.
3000         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
3001         of qsort.
3002         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
3003         (fde_is_less_than): ...this, and change to std::sort semantics.
3004         (dwarf2_build_frame_info): Call std::sort instead of qsort.
3005         * mdebugread.c (compare_blocks):
3006         (block_is_less_than): ...this, and change to std::sort semantics.
3007         (sort_blocks): Call std::sort instead of qsort.
3008         * objfiles.c (qsort_cmp): Rename to...
3009         (sort_cmp): ...this, and change to std::sort semantics.
3010         (update_section_map): Call std::sort instead of qsort.
3011         * remote.c (compare_pnums): Remove.
3012         (map_regcache_remote_table): Call std::sort instead of qsort.
3013         * utils.c (compare_positive_ints): Remove.
3014         * utils.h (compare_positive_ints): Remove.
3015         * xcoffread.c (compare_lte): Remove.
3016         (arrange_linetable): Call std::sort instead of qsort.
3017
3018 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
3019
3020         * symfile.c (init_entry_point_info): Fix typo.
3021         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
3022
3023 2019-10-18  Tom de Vries  <tdevries@suse.de>
3024
3025         * aarch64-tdep.c: Fix typos in comments.
3026         * ada-lang.c: Same.
3027         * ada-tasks.c: Same.
3028         * alpha-tdep.c: Same.
3029         * alpha-tdep.h: Same.
3030         * amd64-nat.c: Same.
3031         * amd64-windows-tdep.c: Same.
3032         * arc-tdep.c: Same.
3033         * arc-tdep.h: Same.
3034         * arch-utils.c: Same.
3035         * arm-nbsd-tdep.c: Same.
3036         * arm-tdep.c: Same.
3037         * ax-gdb.c: Same.
3038         * blockframe.c: Same.
3039         * btrace.c: Same.
3040         * c-varobj.c: Same.
3041         * coff-pe-read.c: Same.
3042         * coffread.c: Same.
3043         * cris-tdep.c: Same.
3044         * darwin-nat.c: Same.
3045         * dbxread.c: Same.
3046         * dcache.c: Same.
3047         * disasm.c: Same.
3048         * dtrace-probe.c: Same.
3049         * dwarf-index-write.c: Same.
3050         * dwarf2-frame-tailcall.c: Same.
3051         * dwarf2-frame.c: Same.
3052         * dwarf2read.c: Same.
3053         * eval.c: Same.
3054         * exceptions.c: Same.
3055         * fbsd-tdep.c: Same.
3056         * findvar.c: Same.
3057         * frame.c: Same.
3058         * frv-tdep.c: Same.
3059         * gnu-v3-abi.c: Same.
3060         * go32-nat.c: Same.
3061         * h8300-tdep.c: Same.
3062         * hppa-tdep.c: Same.
3063         * i386-linux-tdep.c: Same.
3064         * i386-tdep.c: Same.
3065         * ia64-libunwind-tdep.c: Same.
3066         * ia64-tdep.c: Same.
3067         * infcmd.c: Same.
3068         * infrun.c: Same.
3069         * linespec.c: Same.
3070         * linux-nat.c: Same.
3071         * linux-thread-db.c: Same.
3072         * machoread.c: Same.
3073         * mdebugread.c: Same.
3074         * mep-tdep.c: Same.
3075         * mn10300-tdep.c: Same.
3076         * namespace.c: Same.
3077         * objfiles.c: Same.
3078         * opencl-lang.c: Same.
3079         * or1k-tdep.c: Same.
3080         * osabi.c: Same.
3081         * ppc-linux-nat.c: Same.
3082         * ppc-linux-tdep.c: Same.
3083         * ppc-sysv-tdep.c: Same.
3084         * printcmd.c: Same.
3085         * procfs.c: Same.
3086         * record-btrace.c: Same.
3087         * record-full.c: Same.
3088         * remote-fileio.c: Same.
3089         * remote.c: Same.
3090         * rs6000-tdep.c: Same.
3091         * s12z-tdep.c: Same.
3092         * score-tdep.c: Same.
3093         * ser-base.c: Same.
3094         * ser-go32.c: Same.
3095         * skip.c: Same.
3096         * sol-thread.c: Same.
3097         * solib-svr4.c: Same.
3098         * solib.c: Same.
3099         * source.c: Same.
3100         * sparc-nat.c: Same.
3101         * sparc-sol2-tdep.c: Same.
3102         * sparc-tdep.c: Same.
3103         * sparc64-tdep.c: Same.
3104         * stabsread.c: Same.
3105         * stack.c: Same.
3106         * symfile.c: Same.
3107         * symtab.c: Same.
3108         * target-descriptions.c: Same.
3109         * target-float.c: Same.
3110         * thread.c: Same.
3111         * utils.c: Same.
3112         * valops.c: Same.
3113         * valprint.c: Same.
3114         * value.c: Same.
3115         * varobj.c: Same.
3116         * windows-nat.c: Same.
3117         * xcoffread.c: Same.
3118         * xstormy16-tdep.c: Same.
3119         * xtensa-tdep.c: Same.
3120
3121 2019-10-17  Tom Tromey  <tromey@adacore.com>
3122
3123         * configure: Rebuild.
3124         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
3125         in AC_CONFIG_FILES invocation.
3126         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3127         new-style config.status invocation.
3128
3129 2019-10-17  Tom de Vries  <tdevries@suse.de>
3130
3131         * arm-nbsd-nat.c: Fix typos in comments.
3132         * arm-tdep.c: Same.
3133         * darwin-nat-info.c: Same.
3134         * dwarf2read.c: Same.
3135         * elfread.c: Same.
3136         * event-top.c: Same.
3137         * findvar.c: Same.
3138         * gdbtypes.c: Same.
3139         * hppa-tdep.c: Same.
3140         * i386-tdep.c: Same.
3141         * jit.c: Same.
3142         * main.c: Same.
3143         * mdebugread.c: Same.
3144         * moxie-tdep.c: Same.
3145         * nto-procfs.c: Same.
3146         * osabi.c: Same.
3147         * ppc-linux-tdep.c: Same.
3148         * remote.c: Same.
3149         * riscv-tdep.c: Same.
3150         * s390-tdep.c: Same.
3151         * sh-tdep.c: Same.
3152         * sparc-linux-tdep.c: Same.
3153         * sparc-nat.c: Same.
3154         * stack.c: Same.
3155         * target-descriptions.c: Same.
3156         * top.c: Same.
3157         * varobj.c: Same.
3158
3159 2019-10-16  Tom Tromey  <tom@tromey.com>
3160
3161         * objfiles.h (struct objfile) <original_name>: Now const.
3162
3163 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3164
3165         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3166         pass on to sigsetjmp's second argument.
3167         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3168
3169 2019-10-16  Keith Seitz  <keiths@redhat.com>
3170
3171         PR gdb/23567
3172         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3173         sections whose size is greater than the file size.
3174
3175 2019-10-16  Jim Wilson  <jimw@sifive.com>
3176
3177         * riscv-tdep.c (riscv_gcc_target_options): New.
3178         (riscv_gnu_triplet_regexp): New.
3179         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3180         set_gdbarch_gnu_triplet_regexp.
3181
3182 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3183
3184         * Makefile.in: Add xml-builtin.h.
3185         * features/feature_to_c.sh: Add an include for xml-builtin.h
3186         to ensure that the compiler checks that the types match.
3187         * xml-builtin.h: New file.
3188         * xml-support.c (fetch_xml_builtin): Add missing const.
3189         * xml-support.h: Remove declaration of xml_builtins.
3190
3191 2019-10-16  Tom de Vries  <tdevries@suse.de>
3192
3193         PR tdep/25096
3194         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3195         (amd64_classify_aggregate): ... here.
3196         (amd64_classify_aggregate_field): Handled fiels of nested structs
3197         recursively.
3198
3199 2019-10-16  Tom de Vries  <tdevries@suse.de>
3200
3201         PR tdep/24104
3202         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3203         that handles 'theclass'.
3204
3205 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3206
3207         * linespec.c (decode_digits_ordinary): Update comment.
3208         * make-target-delegates: No longer need to handle VEC case.
3209         * memrange.c (normalize_mem_ranges): Update comment.
3210         * namespace.c (add_using_directive): Update comment.
3211         * objc-lang.c (uniquify_strings): Update comment.
3212         * ppc-linux-nat.c (struct thread_points): Update comment.
3213         * probe.h (find_probes_in_objfile): Update comment.
3214         * target.h (enum flash_preserve_mode): Update comment.
3215         * varobj.c (varobj_restrict_range): Update comment.
3216         * varobj.h (varobj_list_children): Update comment.
3217
3218 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3219
3220         * Makefile.in: Remove references to vec.h and vec.c.
3221         * aarch64-tdep.c: No longer include vec.h.
3222         * ada-lang.c: Likewise.
3223         * ada-lang.h: Likewise.
3224         * arm-tdep.c: Likewise.
3225         * ax.h: Likewise.
3226         * breakpoint.h: Likewise.
3227         * charset.c: Likewise.
3228         * cp-support.h: Likewise.
3229         * dtrace-probe.c: Likewise.
3230         * dwarf2read.c: Likewise.
3231         * extension.h: Likewise.
3232         * gdb_bfd.c: Likewise.
3233         * gdbsupport/gdb_vecs.h: Likewise.
3234         * gdbsupport/vec.c: Remove.
3235         * gdbsupport/vec.h: Remove.
3236         * gdbthread.h: Likewise.
3237         * guile/scm-type.c: Likewise.
3238         * inline-frame.c: Likewise.
3239         * machoread.c: Likewise.
3240         * memattr.c: Likewise.
3241         * memrange.h: Likewise.
3242         * namespace.h: Likewise.
3243         * nat/linux-btrace.h: Likewise.
3244         * osdata.c: Likewise.
3245         * parser-defs.h: Likewise.
3246         * progspace.h: Likewise.
3247         * python/py-type.c: Likewise.
3248         * record-btrace.c: Likewise.
3249         * rust-exp.y: Likewise.
3250         * solib-target.c: Likewise.
3251         * stap-probe.c: Likewise.
3252         * target-descriptions.c: Likewise.
3253         * target-memory.c: Likewise.
3254         * target.h: Likewise.
3255         * varobj.c: Likewise.
3256         * varobj.h: Likewise.
3257         * xml-support.h: Likewise.
3258
3259 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3260
3261         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3262         Update for new std::vector based implementation.
3263         (process_psymtab_comp_unit_reader): Likewise.
3264         (scan_partial_symbols): Likewise.
3265         (recursively_compute_inclusions): Likewise.
3266         (compute_compunit_symtab_includes): Likewise.
3267         (process_imported_unit_die): Likewise.
3268         (queue_and_load_dwo_tu): Likewise.
3269         (follow_die_sig_1): Likewise.
3270         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3271         (typedef dwarf2_per_cu_ptr): Remove.
3272         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3273         function.
3274         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3275         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3276         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3277         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3278         std::vector.
3279
3280 2019-10-15  Tom Tromey  <tromey@adacore.com>
3281
3282         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3283         TID.
3284
3285 2019-10-15  Tom Tromey  <tromey@adacore.com>
3286
3287         * windows-nat.c (windows_nat_target::fetch_registers)
3288         (windows_nat_target::store_registers): Rename "pid" to "tid".
3289
3290 2019-10-15  Tom Tromey  <tromey@adacore.com>
3291
3292         * gdbarch.h, gdbarch.c: Rebuild.
3293         * gdbarch.sh (gcc_target_options): Change return type to
3294         std::string.
3295         * compile/compile.c (get_args): Update.
3296         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3297         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3298         std::string.
3299         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3300         std::string.
3301         * arch-utils.c (default_gcc_target_options): Return std::string.
3302         * arch-utils.h (default_gcc_target_options): Return std::string.
3303         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3304
3305 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3306
3307         * breakpoint.c (breakpoint_chain): Make static.
3308         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3309         of accessing breakpoint_chain.
3310
3311 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3312
3313         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3314         to a gdb::function_view and return value to bool.
3315         * breakpoint.h (iterate_over_breakpoints): Likewise.
3316         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3317         (pop_dummy_frame): Update.
3318         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3319         (gdbscm_breakpoints): Update.
3320         * python/py-breakpoint.c (build_bp_list): Update.
3321         (gdbpy_breakpoints): Update.
3322         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3323         Update.
3324         (bpfinishpy_handle_stop): Update.
3325         (bpfinishpy_handle_exit): Update.
3326         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3327         (svr4_update_solib_event_breakpoints): Update.
3328
3329 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3330
3331         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3332         when unwrapping single-field structs.
3333
3334 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3335
3336         * dwarf2read.c: Remove includes.
3337
3338 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3339
3340         * ui-out.c (ui_out::call_do_message): Silence
3341         -Wformat-nonliteral warning.
3342
3343 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3344
3345         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3346         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3347         include: readline/tilde.h.
3348
3349 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3350
3351         * remote.c (remote_target::get_trace_status): Remove declaration of
3352         trace_regblock_size.
3353
3354 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3355
3356         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3357         (show_user): Remove declaration of cmdlist.
3358         * cli/cli-cmds.h (max_user_call_depth): Declare.
3359         * cli/cli-script.c (execute_user_command): Remove declaration
3360         of max_user_call_depth.
3361
3362 2019-10-11  Jim Wilson  <jimw@sifive.com>
3363
3364         * gdbsupport/print-utils.h (pulongest): Fix comment.
3365         (plongest): Likewise.
3366         (phex): Add missing comment, mention leading zeros.
3367         (phex_nz): Add mention of no leading zeros to comment.
3368
3369         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3370         plongest instead of unsigned long long cast.
3371
3372 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3373
3374         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3375         for external_editor_command and gdbtk_test.
3376
3377 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3378
3379         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3380         * varobj.c (varobjdebug): Move comment to...
3381         * varobj.h (varobjdebug): ...here, and declare.
3382
3383 2019-10-09  Tom Tromey  <tom@tromey.com>
3384
3385         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3386         erase_data_content.
3387
3388 2019-10-09  Tom Tromey  <tom@tromey.com>
3389
3390         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3391         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3392         * tui/tui-command.c (tui_cmd_window::resize)
3393         (tui_refresh_cmd_win): Update.
3394         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3395         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3396         * tui/tui-data.c (~tui_gen_win_info): Remove.
3397         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3398         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3399         (tui_redisplay_readline, tui_mld_flush)
3400         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3401         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3402         (tui_data_window::erase_data_content)
3403         (tui_data_item_window::rerender)
3404         (tui_data_item_window::refresh_window): Update.
3405         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3406         (box_win, tui_gen_win_info::make_window)
3407         (tui_gen_win_info::make_visible): Update.
3408         (tui_delete_win): Remove.
3409         * tui/tui-winsource.c
3410         (tui_source_window_base::do_erase_source_content): Update.
3411         (tui_show_source_line, tui_source_window_base::update_tab_width)
3412         (tui_source_window_base::update_exec_info): Update.
3413         * tui/tui-data.h (struct curses_deleter): New.
3414         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3415         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3416
3417 2019-10-09  Tom Tromey  <tom@tromey.com>
3418
3419         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3420
3421 2019-10-09  Tom Tromey  <tom@tromey.com>
3422
3423         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3424         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3425
3426 2019-10-09  Tom Tromey  <tom@tromey.com>
3427
3428         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3429         window height directly.
3430         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3431         declare.
3432         * tui/tui-layout.c (tui_default_win_height): Remove.
3433         (tui_default_win_viewport_height): Remove.
3434
3435 2019-10-09  Tom Tromey  <tom@tromey.com>
3436
3437         * tui/tui.h: Remove comments.
3438
3439 2019-10-09  Tom de Vries  <tdevries@suse.de>
3440
3441         * python/lib/gdb/printer/bound_registers.py: Use
3442         '^builtin_type_bound128' as regexp argument for
3443         add_builtin_pretty_printer.
3444
3445 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3446
3447         * guile/guile.c (guile_extension_script_ops): Remove forward
3448         declaration and mark as static.
3449         (guile_script_ops): Likewise.
3450         (extension_language_guile): Move further down in the file so
3451         it can reference the definitions for guile_{extension_,}script_ops.
3452
3453 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3454
3455         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3456         except SORTL, DFLTCC, and KDSA.
3457
3458 2019-10-08  Tom Tromey  <tromey@adacore.com>
3459
3460         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3461         (struct safe_symbol_file_add_args): Remove.
3462
3463 2019-10-08  Tom Tromey  <tromey@adacore.com>
3464
3465         * windows-nat.c: Don't include buildsym-legacy.h.
3466
3467 2019-10-08  Tom Tromey  <tromey@adacore.com>
3468
3469         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3470
3471 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3472
3473         * gdbtypes.c (overload_debug): Move comment to header.
3474         * gdbtypes.h (overload_debug): Declare.
3475         * valops.c: Remove declaration of overload_debug, instead
3476         include gdbtypes.h.
3477
3478 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3479
3480         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3481         through _().
3482         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3483         move comment...
3484         * language.h (lang_frame_mismatch_warn): ... here. Also add
3485         declaration.
3486         * top.c (lang_frame_mismatch_warn): Remove declaration.
3487         (check_frame_language_change): Pass lang_frame_mismatch_warn
3488         through _().
3489
3490 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3491
3492         * c-lang.h (vtbl_ptr_name): Declare.
3493         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3494         it from the header.
3495         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3496
3497 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3498
3499         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3500         gdb_static_assert.
3501
3502 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3503
3504         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3505         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3506         * ctfread.c: New file.
3507         * ctfread.h: New file.
3508         * elfread.c: Include ctfread.h.
3509         (struct elfinfo text_p): New member ctfsect.
3510         (elf_locate_sections): Mark CTF section.
3511         (elf_symfile_read): Call elfctf_build_psymtabs.
3512         * Makefile.in (LIBCTF): Add.
3513         (CLIBS): Use it.
3514         (CDEPS): Likewise.
3515         (DIST): Add ctfread.c.
3516
3517 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3518
3519         * ctfread.c (struct nextfield): Renamed to ...
3520         (struct ctf_nextfield): ... this.
3521         (struct field_info): Renamed to ...
3522         (strut ctf_field_info): ... this.
3523         (attach_fields_to_type): Update for renamed structures.
3524         (ctf_add_member_cb): Likewise.
3525         (ctf_add_enum_member_cb): Likewise.
3526         (process_struct_members): Likewise.
3527         (process_enum_type): Likewise.
3528
3529 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3530
3531         * tracectf.h: Rename, was ctf.h.
3532         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3533         * tracefile.c: Likewise.
3534         * tracepoint.c: Remove unused include ctf.h.
3535         * mi/mi-main.c: Likewise.
3536         * Makefile.in Replace ctf.c with tracectf.c.
3537
3538 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3539
3540         * version.in: Change version number to "9.0.50.DATE-git".
3541
3542 2019-10-03  Tom Tromey  <tom@tromey.com>
3543
3544         PR rust/24976:
3545         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3546
3547 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3548
3549         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3550         cp_search_name_hash.
3551         * NEWS: Add entry about nested function support.
3552
3553 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3554             Andrew Burgess  <andrew.burgess@embecosm.com>
3555
3556         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3557         for nested static variables when searchin VAR_DOMAIN.
3558         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3559         global scope, update comment.
3560         (add_partial_subprogram): Call add_partial_subprogram recursively
3561         for nested subroutines when processinng Fortran.
3562         (load_partial_dies): Process the child entities of a subprogram
3563         when processing Fortran.
3564         (partial_die_parent_scope): Handle building scope
3565         for Fortran nested functions.
3566         (process_die): Record that nested functions have a scope.
3567         (new_symbol): Always record Fortran subprograms on the global
3568         symbol list.
3569         (determine_prefix): How to build the prefix for Fortran
3570         subprograms.
3571
3572 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3573
3574         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3575         have just sent the thread a SIGSTOP and are waiting for it to
3576         arrive.
3577
3578 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3579
3580         * btrace.c (btrace_add_pc): Remove whitespace before the template
3581         parameter in 'std::vector <...>'.
3582         (parse_xml_btrace_block): Likewise.
3583         (btrace_maint_decode_pt): Likewise.
3584         (btrace_maint_update_packets): Likewise.
3585         (btrace_maint_print_packets): Likewise.
3586         * btrace.h (struct btrace_maint_info): Likewise.
3587         * dwarf2read.c (struct type_unit_group): Likewise.
3588         (build_type_psymtabs_reader): Likewise.
3589         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3590         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3591         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3592
3593 2019-10-03  Tom de Vries  <tdevries@suse.de>
3594
3595         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3596         the first line of the help text for set/show style metadata.
3597
3598 2019-10-02  Tom Tromey  <tromey@adacore.com>
3599
3600         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3601         * gdbsupport/common-inferior.c: New file.
3602         * infcmd.c (startup_with_shell): Don't define.
3603         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3604         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3605         * inferior.h (startup_with_shell): Don't declare.
3606
3607 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3608
3609         * gdbsupport/gdb_assert.h: Include errors.h.
3610         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3611
3612 2019-10-02  Tom Tromey  <tromey@adacore.com>
3613
3614         * NEWS: Add $_ada_exception entry.
3615         * ada-lang.c (struct ada_catchpoint): Add constructor.
3616         <m_kind>: New member.
3617         (allocate_location_exception, re_set_exception): Remove
3618         "ex" parameter.
3619         (should_stop_exception): Compute $_ada_exception.
3620         (check_status_exception, print_it_exception)
3621         (print_one_exception, print_mention_exception): Remove
3622         "ex" parameter.
3623         (allocate_location_catch_exception, re_set_catch_exception)
3624         (check_status_exception, print_it_catch_exception)
3625         (print_one_catch_exception, print_mention_catch_exception)
3626         (print_recreate_catch_exception)
3627         (allocate_location_catch_exception_unhandled)
3628         (re_set_catch_exception_unhandled)
3629         (check_status_exception, print_it_catch_exception_unhandled)
3630         (print_one_catch_exception_unhandled)
3631         (print_mention_catch_exception_unhandled)
3632         (print_recreate_catch_exception_unhandled)
3633         (allocate_location_catch_assert, re_set_catch_assert)
3634         (check_status_assert, print_it_catch_assert)
3635         (print_one_catch_assert, print_mention_catch_assert)
3636         (print_recreate_catch_assert)
3637         (allocate_location_catch_handlers, re_set_catch_handlers)
3638         (check_status_handlers, print_it_catch_handlers)
3639         (print_one_catch_handlers, print_mention_catch_handlers)
3640         (print_recreate_catch_handlers): Remove.
3641         (create_ada_exception_catchpoint): Update.
3642         (initialize_ada_catchpoint_ops): Update.
3643
3644 2019-10-02  Tom Tromey  <tromey@adacore.com>
3645
3646         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3647         (create_excep_cond_exprs): Simplify exception string computation.
3648         (ada_exception_catchpoint_cond_string): Likewise.
3649
3650 2019-10-02  Tom Tromey  <tromey@adacore.com>
3651
3652         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3653         * ada-lang.c (lesseq_defined_than): Handle
3654         LOC_STATIC.
3655         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3656         parameter.
3657         (dwarf2_has_info): Likewise.
3658         (new_symbol): Set maybe_copied on symbol when
3659         appropriate.
3660         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3661         parameter.
3662         <can_copy>: New member.
3663         * elfread.c (record_minimal_symbol): Set maybe_copied
3664         on symbol when appropriate.
3665         (elf_symfile_read): Update call to dwarf2_has_info.
3666         * minsyms.c (lookup_minimal_symbol_linkage): New
3667         function.
3668         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3669         * symtab.c (get_symbol_address, get_msymbol_address):
3670         New functions.
3671         * symtab.h (get_symbol_address, get_msymbol_address):
3672         Declare.
3673         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3674         maybe_copied.
3675         (struct symbol, struct minimal_symbol) <maybe_copied>:
3676         New member.
3677
3678 2019-10-02  Tom Tromey  <tromey@adacore.com>
3679
3680         * source.c (struct current_source_location): New.
3681         (current_source_key): New global.
3682         (current_source_symtab, current_source_line)
3683         (current_source_pspace): Remove.
3684         (get_source_location): New function.
3685         (get_current_source_symtab_and_line)
3686         (set_default_source_symtab_and_line)
3687         (set_current_source_symtab_and_line)
3688         (clear_current_source_symtab_and_line, select_source_symtab)
3689         (info_source_command, print_source_lines_base)
3690         (info_line_command, search_command_helper, _initialize_source):
3691         Update.
3692
3693 2019-10-02  Tom Tromey  <tromey@adacore.com>
3694
3695         * source.c (select_source_symtab): Don't call
3696         decode_line_with_current_source.
3697
3698 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3699
3700         * symtab.c (lookup_global_symbol): Search global block.
3701
3702 2019-10-02  Tom Tromey  <tromey@adacore.com>
3703
3704         * coffread.c (process_coff_symbol): Update.
3705         * dwarf2read.c (var_decode_location, new_symbol): Update.
3706         * mdebugread.c (parse_symbol): Update.
3707         * objfiles.c (relocate_one_symbol): Update.
3708         * stabsread.c (define_symbol, fix_common_block)
3709         (scan_file_globals): Update.
3710         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3711         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3712         * xcoffread.c (process_xcoff_symbol): Update.
3713
3714 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3715
3716         * MAINTAINERS: Update my email address.
3717
3718 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3719
3720         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3721         std::vector.
3722         (build_type_psymtabs_reader): Update for std::vector.
3723         (build_type_psymtab_dependencies): Likewise.
3724         * dwarf2read.h: Remove use of DEF_VEC_P.
3725         (typedef sig_type_ptr): Delete.
3726
3727 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3728
3729         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3730         to std::vector.
3731         (btrace_maint_decode_pt): Likewise, and move allocation of the
3732         vector outside of the loop.
3733         (btrace_maint_update_packets): Update to handle change from VEC to
3734         std::vector.
3735         (btrace_maint_print_packets): Likewise.
3736         (maint_info_btrace_cmd): Likewise.
3737         * btrace.h: Remove use of DEF_VEC_O.
3738         (typedef btrace_pt_packet_s): Delete.
3739         (struct btrace_maint_info) <packets>: Change fromm VEC to
3740         std::vector.
3741         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3742
3743 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3744
3745         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3746         make accesses into the vector constant references.
3747         (btrace_add_pc): Update for std::vector.
3748         (btrace_stitch_bts): Likewise.
3749         (parse_xml_btrace_block): Likewise.
3750         (btrace_maint_update_packets): Likewise.
3751         (btrace_maint_print_packets): Likewise.
3752         (maint_info_btrace_cmd): Likewise.
3753         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3754         std::vector.
3755         (btrace_data::empty): Likewise.
3756         (btrace_data_append): Likewise.
3757         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3758         (typedef btrace_block_s): Delete.
3759         (struct btrace_block): Add constructor.
3760         (struct btrace_data_bts) <blocks>: Change to std::vector.
3761         * nat/linux-btrace.c (perf_event_read_bts): Update for
3762         std::vector.
3763         (linux_read_bts): Likewise.
3764
3765 2019-10-01  Tom Tromey  <tom@tromey.com>
3766
3767         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3768
3769 2019-10-01  Tom Tromey  <tom@tromey.com>
3770
3771         * stack.c (print_frame, info_frame_command_core): Use
3772         styled_string.
3773         * linux-thread-db.c (try_thread_db_load_1)
3774         (try_thread_db_load_from_pdir_1): Use styled_string.
3775         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3776         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3777         (maybe_print_unsupported_script_warning)
3778         (maybe_print_script_not_found_warning): Use styled_string.
3779         * ada-lang.c (user_select_syms): Use styled_string.
3780
3781 2019-10-01  Tom Tromey  <tom@tromey.com>
3782
3783         * p-lang.c (pascal_printstr): Use metadata style.
3784         * value.c (show_convenience): Use metadata style.
3785         * valprint.c (valprint_check_validity, val_print_optimized_out)
3786         (val_print_not_saved, val_print_unavailable)
3787         (val_print_invalid_address, generic_val_print, val_print)
3788         (value_check_printable, val_print_array_elements): Use metadata
3789         style.
3790         * ui-out.h (class ui_out) <field_fmt>: New overload.
3791         <do_field_fmt>: Add style parameter.
3792         * ui-out.c (ui_out::field_fmt): New overload.
3793         * typeprint.c (type_print_unknown_return_type)
3794         (val_print_not_allocated, val_print_not_associated): Use metadata
3795         style.
3796         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3797         parameter.
3798         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3799         * tracepoint.c (tvariables_info_1): Use metadata style.
3800         * stack.c (print_frame_arg, print_frame_info, print_frame)
3801         (info_frame_command_core): Use metadata style.
3802         * skip.c (info_skip_command): Use metadata style.
3803         * rust-lang.c (rust_print_enum): Use metadata style.
3804         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3805         metadata style.
3806         * python/py-framefilter.c (py_print_single_arg): Use metadata
3807         style.
3808         * printcmd.c (do_one_display, print_variable_and_value): Use
3809         metadata style.
3810         * p-valprint.c (pascal_val_print)
3811         (pascal_object_print_value_fields): Use metadata style.
3812         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3813         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3814         parameter.
3815         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3816         * m2-valprint.c (m2_print_long_set): Use metadata style.
3817         * m2-typeprint.c (m2_print_type): Use metadata style.
3818         * infcmd.c (print_return_value_1): Use metadata style.
3819         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3820         * f-valprint.c (info_common_command_for_block): Use metadata
3821         style.
3822         * f-typeprint.c (f_type_print_base): Use metadata style.
3823         * expprint.c (print_subexp_standard): Use metadata style.
3824         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3825         * cli/cli-style.h (class cli_style_option): Add constructor.
3826         (metadata_style): Declare.
3827         * cli/cli-style.c (metadata_style): New global.
3828         (_initialize_cli_style): Register metadata style.
3829         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3830         parameter.
3831         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3832         * c-typeprint.c (c_type_print_base_struct_union)
3833         (c_type_print_base_1): Use metadata style.
3834         * breakpoint.c (watchpoint_value_print)
3835         (print_one_breakpoint_location): Use metadata style.
3836         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3837         style.
3838         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3839         style.
3840         * ada-valprint.c (val_print_packed_array_elements, printstr)
3841         (print_field_values, ada_val_print_ref, ada_val_print): Use
3842         metadata style.
3843         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3844         style.
3845         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3846         style.
3847         * ada-lang.c (user_select_syms): Use metadata style.
3848
3849 2019-10-01  Tom Tromey  <tom@tromey.com>
3850
3851         * cli/cli-cmds.c (pwd_command): Style output.
3852
3853 2019-10-01  Pedro Alves  <palves@redhat.com>
3854             Tom Tromey  <tom@tromey.com>
3855
3856         * symtab.c (print_symbol_info): Use %ps.
3857         (print_msymbol_info): Use %ps.
3858         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3859         * printcmd.c (print_variable_and_value): Use %ps.
3860         * macrocmd.c (show_pp_source_pos): Use %ps.
3861         * infrun.c (print_exited_reason): Use ui_out::message.
3862         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3863         (describe_other_breakpoints): Use ui_out::message and new
3864         formats.
3865         (say_where): Use new formats.
3866         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3867         and new formats.
3868
3869 2019-10-01  Pedro Alves  <palves@redhat.com>
3870             Tom Tromey  <tom@tromey.com>
3871
3872         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3873         (test_gdb_formats): New function.
3874         (run_tests): Call it.
3875         (test_format_specifier): Update.
3876         * utils.h (fputs_filtered): Update comment.
3877         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3878         (fputs_styled_unfiltered): Declare.
3879         * utils.c (fputs_styled_unfiltered): New function.
3880         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3881         (vfprintf_filtered): Update.
3882         (vfprintf_unfiltered, vprintf_filtered): Update.
3883         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3884         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3885         disallow_ui_out_field>: New constants.
3886         (enum class field_kind): New.
3887         (struct base_field_s, struct signed_field_s): New.
3888         (signed_field): New function.
3889         (struct string_field_s): New.
3890         (string_field): New function.
3891         (struct styled_string_s): New.
3892         (styled_string): New function.
3893         (class ui_out) <message>: Add comment.
3894         <vmessage, call_do_message>: New methods.
3895         <do_message>: Add style parameter.
3896         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3897         methods.
3898         (ui_out::message): Rewrite.
3899         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3900         parameter.
3901         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3902         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3903         gdb_extensions parameter.
3904         (class format_piece): Add parameter to constructor.
3905         (n_int_args): New field.
3906         * gdbsupport/format.c (format_pieces::format_pieces): Add
3907         gdb_extensions parameter.  Handle '*'.
3908         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3909         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3910         vfprintf_styled_no_gdbfmt.
3911         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3912         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3913         unfiltered output.
3914         * ui-style.h (struct ui_file_style) <ptr>: New method.
3915
3916 2019-10-01  Tom Tromey  <tom@tromey.com>
3917
3918         * unittests/format_pieces-selftests.c: Update.  Add final format.
3919         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3920         empty literal pieces.
3921
3922 2019-10-01  Tom Tromey  <tom@tromey.com>
3923
3924         * ui-out.h (enum class ui_out_style_kind): Remove.
3925         (class ui_out) <field_string, field_stsream, do_field_string>:
3926         Change type of "style".
3927         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3928         (ui_out::field_string): Update.
3929         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3930         of "style".
3931         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3932         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3933         * stack.c (print_frame_arg, print_frame_info, print_frame):
3934         Update.
3935         * source.c (print_source_lines_base): Update.
3936         * solib.c (info_sharedlibrary_command): Update.
3937         * skip.c (info_skip_command): Update.
3938         * record-btrace.c (btrace_call_history_src_line)
3939         (btrace_call_history): Update.
3940         * python/py-framefilter.c (py_print_frame): Update.
3941         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3942         "style".
3943         * mi/mi-out.c (mi_ui_out::do_table_header)
3944         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3945         (mi_ui_out::do_field_string): Update.
3946         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3947         Update.
3948         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3949         "style".
3950         * cli-out.c (cli_ui_out::do_table_header)
3951         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3952         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3953         (cli_ui_out::do_field_fmt): Update.
3954         * breakpoint.c (print_breakpoint_location): Update.
3955         (update_static_tracepoint): Update.
3956
3957 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3958
3959         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3960         conversion of gdb_datadir.
3961         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3962         remove not needed c_str ().
3963
3964 2019-09-30  Ali Tamur <tamur@google.com>
3965
3966         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3967         (dwarf2_string_attr): Likewise.
3968
3969 2019-09-30  Ali Tamur <tamur@google.com>
3970
3971         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3972         (process_full_type_unit): Likewise.
3973         (dump_die_shallow): Likewise.
3974         (cu_debug_loc_section): Likewise.
3975
3976 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3977
3978         * minsyms.c (compare_minimal_symbols): Rename to...
3979         (minimal_symbol_is_less_than): ...this, and adjust to STL
3980         conventions (return bool, take arguments as references)
3981         (minimal_symbol_reader::install): Call std::sort instead
3982         of qsort.
3983
3984 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3985
3986         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3987         hash and why.
3988         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3989         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3990
3991 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3992
3993         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3994         * psympriv.h (add_psymbol_to_list): Move comment here and update
3995         it.
3996
3997 2019-09-29  Tom de Vries  <tdevries@suse.de>
3998
3999         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
4000         Use $tmpdir/$(basename "$output_file").dwz instead of
4001         "${output_file}.dwz".
4002
4003 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
4004
4005         PR gdb/25045
4006         * hppa-linux-nat.c: Include gdbarch.h.
4007
4008 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
4009
4010         * blockframe.c (find_pc_partial_function): Change return type to bool.
4011         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
4012         * minsyms.c (in_gnu_ifunc_stub): Likewise.
4013         (stub_gnu_ifunc_resolve_name): Likewise.
4014         * symtab.c (compare_filenames_for_search): Likewise.
4015         (compare_glob_filenames_for_search): Likewise.
4016         (matching_obj_sections): Likewise.
4017         (symbol_matches_domain): Likewise.
4018         (find_line_symtab): Change out param EXACT_MATCH to bool *.
4019         (find_line_pc): Change return type to bool.
4020         (find_line_pc_range): Likewise.
4021         (producer_is_realview): Likewise.
4022         * symtab.h (symbol_matches_domain): Likewise.
4023         (find_pc_partial_function): Likewise.
4024         (find_pc_line_pc_range): Likewise.
4025         (in_gnu_ifunc_stub): Likewise.
4026         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
4027         (find_line_pc): Likewise.
4028         (find_line_pc_range): Likewise.
4029         (matching_obj_sections): Likewise.
4030         (find_line_symtab): Change out parameter to bool.
4031         (producer_is_realview): Change return type to bool.
4032         (compare_filenames_for_search): Likewise.
4033         (compare_glob_filenames_for_search): Likewise.
4034
4035 2019-09-26  Tom Tromey  <tom@tromey.com>
4036
4037         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
4038         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
4039         * gdb_usleep.h: Remove.
4040         * gdb_usleep.c: Remove.
4041         * utils.c: Don't include gdb_usleep.h.
4042
4043 2019-09-26  Tom Tromey  <tromey@adacore.com>
4044
4045         * python/py-type.c (type_to_type_object): Call check_typedef
4046         for stub types.
4047
4048 2019-09-26  Tom Tromey  <tom@tromey.com>
4049
4050         * utils.h (initialize_utils): Don't declare.
4051         * top.c (gdb_init): Don't call initialize_utils.
4052         * utils.c (initialize_utils): Remove.  Move contents...
4053         (_initialize_utils): ... here.
4054
4055 2019-09-25  Tom Tromey  <tom@tromey.com>
4056
4057         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
4058         * utils.h (make_hex_string): Don't declare.
4059         * utils.c (make_hex_string): Remove.
4060
4061 2019-09-24  Tom de Vries  <tdevries@suse.de>
4062
4063         PR gdb/23815
4064         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4065         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4066
4067 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
4068
4069         * NEWS: Mention new simulator port for PRU.
4070
4071 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
4072
4073         * ada-exp.y (write_object_remaining): Update.
4074         * ada-lang.c (ada_decode): Return a std::string instead of a char*
4075         and eliminate the static buffer.
4076         (ada_decode_symbol): Update.
4077         (ada_la_decode): Update.
4078         (ada_sniff_from_mangled_name): Update.
4079         (is_valid_name_for_wild_match): Update.
4080         (ada_lookup_name_info::matches): Update and simplify.
4081         (name_matches_regex): Update.
4082         (ada_add_global_exceptions): Update.
4083         * ada-lang.h (ada_decode): Update signature.
4084         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4085         * dwarf-index-write.c (debug_names::insert): Update.
4086
4087 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4088
4089         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4090         formatting.
4091
4092 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4093
4094         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4095         Change "nonzero" to "true" in documentation.
4096
4097 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
4098
4099         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4100         (_initialize_darwin_solib): Don't set
4101         darwin_so_ops.lookup_lib_global_symbol.
4102         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4103         set_gdbarch_iterate_over_objfiles_in_search_order.
4104         (elf_lookup_lib_symbol): Rename to...
4105         (svr4_iterate_over_objfiles_in_search_order): this, and update
4106         to iterate semantics.
4107         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4108         * solib.c (solib_global_lookup): Remove.
4109         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4110         (solib_global_lookup): Remove.
4111         * symtab.c (lookup_global_or_static_symbol): Remove call to
4112         solib_global_lookup.
4113
4114 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4115
4116         * NEWS: Move entries about default MI version now being
4117         version 3, and about the GDB/MI fix for multi-location
4118         breakpoints to the "since GDB 8.3" section.
4119
4120 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4121
4122         GDB 8.3.1 released.
4123
4124 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
4125
4126         * NEWS: Mention that Cell/B.E. debugging support was removed.
4127         * MAINTAINERS: Remove spu target.
4128
4129         * config/djgpp/fnchange.lst: Remove entries for removed files.
4130
4131         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4132         spu-multiarch.o, and spu-tdep.o.
4133         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4134         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4135         spu-multiarch.c, and spu-tdep.c.
4136         * spu-linux-nat.c: Remove file.
4137         * spu-multiarch.c: Remove file.
4138         * spu-tdep.c: Remove file.
4139         * spu-tdep.h: Remove file.
4140         * solib-spu.c: Remove file.
4141         * solib-spu.h: Remove file.
4142
4143         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4144         * configure.nat (spu-linux): Remove.
4145         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4146         solib-multiarch.o from gdb_target_obs.
4147         (spu*-*-*): Remove.
4148
4149         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4150         feature flag.
4151         (ppc_linux_no_features): Update.
4152         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4153         Cell/B.E. support.
4154         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4155         (tdesc_powerpc_cell64l): Likewise.
4156         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4157         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4158         Cell/B.E. support.
4159         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4160         Do not include "features/rs6000/powerpc-cell32l.c" or
4161         "features/rs6000/powerpc-cell64l.c".
4162         (ppc_linux_spu_section): Remove.
4163         (ppc_linux_core_read_description): Remove Cell/B.E. support.
4164         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4165         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4166         (ppc_linux_spe_context_lookup): Remove.
4167         (ppc_linux_spe_context_inferior_created): Remove.
4168         (ppc_linux_spe_context_solib_loaded): Remove.
4169         (ppc_linux_spe_context_solib_unloaded): Remove.
4170         (ppc_linux_spe_context): Remove.
4171         (struct ppu2spu_cache): Remove.
4172         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4173         (struct ppu2spu_data): Remove.
4174         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4175         ppu2spu_unwind): Remove.
4176         (ppc_linux_init_abi): Remove Cell/B.E. support.
4177         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4178
4179         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4180         (rs6000/powerpc-cell64l-expedite): Likewise
4181         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4182         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4183         rs6000/powerpc-cell64l.xml.
4184         * features/rs6000/powerpc-cell32l.xml: Remove.
4185         * features/rs6000/powerpc-cell64l.xml: Likewise.
4186         * features/rs6000/powerpc-cell32l.c: Remove generated file.
4187         * features/rs6000/powerpc-cell64l.c: Likewise.
4188         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4189         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4190         * regformats/reg-spu.dat: Remove.
4191
4192         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4193         * corelow.c (struct spuid_list): Remove.
4194         (add_to_spuid_list): Remove.
4195         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4196         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4197         (remote_protocol_features): Remove associated entries.
4198         (_initialize_remote): No longer initialize them.
4199         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4200         * linux-nat.c (SPUFS_MAGIC): Remove.
4201         (linux_proc_xfer_spu): Remove.
4202         (spu_enumerate_spu_ids): Remove.
4203         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4204         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4205         (linux_make_corefile_notes): No longer call it.
4206
4207         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4208         (cooked_write_test): Likewise.
4209
4210 2019-09-20  Tom Tromey  <tom@tromey.com>
4211
4212         * NEWS: Mention case-sensitivity of TUI commands.
4213         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4214         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4215         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4216
4217 2019-09-20  Tom Tromey  <tom@tromey.com>
4218
4219         * tui/tui-source.c (tui_source_window::set_contents): Use
4220         make_unique_xstrdup.
4221         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4222         make_unique_xstrdup.
4223
4224 2019-09-20  Tom Tromey  <tom@tromey.com>
4225
4226         * tui/tui-data.c: Remove separator comments.
4227         * tui/tui-layout.c: Remove separator comments.
4228         * tui/tui-win.c: Remove separator comments.
4229         * tui/tui-wingeneral.c: Remove separator comments.
4230
4231 2019-09-20  Tom Tromey  <tom@tromey.com>
4232
4233         * tui/tui.h (strcat_to_buf): Don't declare.
4234         * tui/tui.c (strcat_to_buf): Remove.
4235
4236 2019-09-20  Tom Tromey  <tom@tromey.com>
4237
4238         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4239         from "fullname".
4240         * tui/tui-source.c (tui_source_window::set_contents)
4241         (tui_source_window::location_matches_p)
4242         (tui_source_window::maybe_update): Update.
4243
4244 2019-09-20  Tom Tromey  <tom@tromey.com>
4245
4246         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4247         Update.
4248         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4249         prefix.
4250         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4251         (tui_data_window::line_from_reg_element_no)
4252         (tui_data_window::first_reg_element_no_inline)
4253         (tui_data_window::show_registers)
4254         (tui_data_window::show_register_group)
4255         (tui_data_window::display_registers_from)
4256         (tui_data_window::display_registers_from_line)
4257         (tui_data_window::first_data_item_displayed)
4258         (tui_data_window::delete_data_content_windows)
4259         (tui_data_window::erase_data_content)
4260         (tui_data_window::do_scroll_vertical)
4261         (tui_data_window::refresh_window)
4262         (tui_data_window::check_register_values): Update.
4263
4264 2019-09-20  Tom Tromey  <tom@tromey.com>
4265
4266         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4267         (struct tui_locator_window) <full_name, proc_name>: Now
4268         std::string.
4269         * tui/tui-stack.c (tui_locator_window::make_status_line)
4270         (tui_locator_window::set_locator_fullname)
4271         (tui_locator_window::set_locator_info): Update.
4272         * tui/tui-source.c (tui_source_window::set_contents)
4273         (tui_source_window::showing_source_p): Update.
4274
4275 2019-09-20  Tom Tromey  <tom@tromey.com>
4276
4277         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4278         Don't call tui_locator_win_info_ptr.
4279
4280 2019-09-20  Tom Tromey  <tom@tromey.com>
4281
4282         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4283
4284 2019-09-20  Tom Tromey  <tom@tromey.com>
4285
4286         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4287         height for locator.
4288         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4289         * tui/tui-layout.c (show_source_disasm_command, show_data)
4290         (show_source_or_disasm_and_command): Use 1 as height for locator.
4291
4292 2019-09-20  Tom Tromey  <tom@tromey.com>
4293
4294         * tui/tui.c (tui_enable): Update.
4295         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4296         Update.
4297         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4298         Update.
4299         * tui/tui-data.c (win_resized): Now bool.
4300         (tui_win_resized): Return bool.
4301         (tui_set_win_resized_to): Accept a bool.
4302
4303 2019-09-20  Tom Tromey  <tom@tromey.com>
4304
4305         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4306         Change type of "refresh_values_only".
4307         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4308         type of "refresh_values_only".
4309
4310 2019-09-20  Tom Tromey  <tom@tromey.com>
4311
4312         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4313         std::string.
4314         (tui_disassemble): Add "pos" parameter.
4315         (tui_disasm_window::set_contents): Simplify.
4316
4317 2019-09-20  Tom Tromey  <tom@tromey.com>
4318
4319         * tui/tui-winsource.h (struct tui_source_window_base)
4320         <show_source_content>: Now private.
4321         * tui/tui-winsource.c
4322         (tui_source_window_base::show_source_content): Don't handle empty
4323         content case.
4324
4325 2019-09-20  Tom Tromey  <tom@tromey.com>
4326
4327         * tui/tui-layout.c (show_source_disasm_command)
4328         (show_source_or_disasm_and_command): Don't call
4329         show_source_content.
4330
4331 2019-09-20  Tom Tromey  <tom@tromey.com>
4332
4333         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4334         Declare.
4335         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4336         from tui_make_status_line.
4337         (tui_locator_window::rerender): Update.
4338
4339 2019-09-20  Tom Tromey  <tom@tromey.com>
4340
4341         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4342         (tui_locator_window::rerender): Update.
4343
4344 2019-09-20  Tom Tromey  <tom@tromey.com>
4345
4346         * tui/tui-winsource.h (struct tui_source_window_base)
4347         <~tui_source_window_base>: Don't declare.
4348         <fullname>: Remove.
4349         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4350         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4351         member.
4352         * tui/tui-source.c (tui_source_window::set_contents): Update.
4353         (tui_source_window::location_matches_p)
4354         (tui_source_window::maybe_update): Update.
4355
4356 2019-09-20  Tom Tromey  <tom@tromey.com>
4357
4358         * tui/tui-winsource.h (~tui_source_element): Remove.
4359         (tui_source_element): Update.
4360         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4361         * tui/tui-winsource.c (tui_show_source_line): Update.
4362         * tui/tui-source.c (tui_source_window::set_contents): Update.
4363         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4364
4365 2019-09-20  Tom Tromey  <tom@tromey.com>
4366
4367         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4368         declare.
4369         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4370         tui_clear_source_windows_detail.
4371         * tui/tui-winsource.h (struct tui_source_window_base)
4372         <clear_detail>: Don't declare.
4373         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4374         Remove.
4375         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4376
4377 2019-09-20  Tom Tromey  <tromey@adacore.com>
4378
4379         PR ada/24919:
4380         * block.c (contained_in): Fix final return value.
4381
4382 2019-09-20  Alan Modra  <amodra@gmail.com>
4383
4384         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4385         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4386         (read_indirect_string_from_dwz): Use bfd accessor.
4387         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4388         * machoread.c (macho_symfile_read_all_oso): Likewise.
4389         * solib.c (solib_bfd_open): Likewise.
4390
4391 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4392
4393         * eval.c: Move declaration of overload_resolution to...
4394         * value.h: ...here.
4395
4396 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4397
4398         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4399         * arm-linux-tdep.c: Likewise.
4400         * arm-nbsd-nat.c: Likewise.
4401         * arm-tdep.h: Declare arm_apcs_32.
4402         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4403
4404 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4405
4406         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4407         * dwarf2read.h: Declare dwarf_always_disassemble.
4408
4409 2019-09-19  Tom de Vries  <tdevries@suse.de>
4410
4411         PR gdb/25009
4412         * source-cache.c (source_cache::ensure): Catch exception thrown during
4413         construction of the highlighter.
4414
4415 2019-09-18  Alan Modra  <amodra@gmail.com>
4416
4417         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4418         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4419         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4420         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4421         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4422         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4423         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4424         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4425         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4426         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4427         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4428         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4429         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4430         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4431         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4432         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4433         * mi/mi-interp.c: Update throughout for bfd section macro and
4434         function changes.
4435         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4436         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4437
4438 2019-09-18  Tom Tromey  <tom@tromey.com>
4439
4440         * NEWS: Add entry.
4441         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4442         call rl_initialize.
4443         (tui_enable): Do not call rl_initialize.
4444
4445 2019-09-18  Christian Groessler  <chris@groessler.org>
4446
4447         * alpha-linux-nat.c: Include gdbarch.h.
4448
4449 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4450
4451         * ui-file.c: Include cli/cli-style.h.
4452         (term_cli_styling): Remove cli_styling declaration.
4453
4454 2019-09-18  Alan Modra  <amodra@gmail.com>
4455
4456         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4457         to bfd_asymbol_section.
4458
4459 2019-09-18  Alan Modra  <amodra@gmail.com>
4460
4461         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4462         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4463         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4464
4465 2019-09-18  Alan Modra  <amodra@gmail.com>
4466
4467         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4468         * spu-linux-nat.c (spu_bfd_open): Likewise.
4469
4470 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4471
4472         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4473         to bool to match definition in dwarf2read.c.
4474
4475 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4476
4477         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4478         (print_signatures): Likewise.
4479         (trust_pad_over_xvs): Likewise.
4480         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4481         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4482         * arm-linux-nat.c (arm_apcs_32): Likewise.
4483         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4484         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4485         * arm-tdep.c (arm_debug): Likewise.
4486         (arm_apcs_32): Likewise.
4487         * auto-load.c (debug_auto_load): Likewise.
4488         (auto_load_gdb_scripts): Likewise.
4489         (global_auto_load): Likewise.
4490         (auto_load_local_gdbinit): Likewise.
4491         (auto_load_local_gdbinit_loaded): Likewise.
4492         * auto-load.h (global_auto_load): Likewise.
4493         (auto_load_local_gdbinit): Likewise.
4494         (auto_load_local_gdbinit_loaded): Likewise.
4495         * breakpoint.c (disconnected_dprintf): Likewise.
4496         (breakpoint_proceeded): Likewise.
4497         (automatic_hardware_breakpoints): Likewise.
4498         (always_inserted_mode): Likewise.
4499         (target_exact_watchpoints): Likewise.
4500         (_initialize_breakpoint): Update.
4501         * breakpoint.h (target_exact_watchpoints): Change to bool.
4502         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4503         * cli/cli-cmds.c (trace_commands): Likewise.
4504         * cli/cli-cmds.h (trace_commands): Likewise.
4505         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4506         to bool*.
4507         * cli/cli-logging.c (logging_overwrite): Change to bool.
4508         (logging_redirect): Likewise.
4509         (debug_redirect): Likewise.
4510         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4511         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4512         to bool.
4513         <boolean_option_def>: Update.
4514         (struct flag_option_def): Change default type of Context to bool
4515         from int.
4516         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4517         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4518         (get_setshow_command_value_string): Likewise.
4519         * cli/cli-style.c (cli_styling): Change to bool.
4520         (source_styling): Likewise.
4521         * cli/cli-style.h (source_styling): Likewise.
4522         (cli_styling): Likewise.
4523         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4524         to bool.
4525         * command.h (var_types): Update comment.
4526         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4527         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4528         bool.
4529         (debug_compile_cplus_scopes): Likewise.
4530         * compile/compile-internal.h (compile_debug): Likewise.
4531         * compile/compile.c (compile_debug): Likewise.
4532         (struct compile_options) <raw>: Likewise.
4533         * cp-support.c (catch_demangler_crashes): Likewise.
4534         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4535         (usr_cmd_cris_dwarf2_cfi): Likewise.
4536         * csky-tdep.c (csky_debug): Likewise.
4537         * darwin-nat.c (enable_mach_exceptions): Likewise.
4538         * dcache.c (dcache_enabled_p): Likewise.
4539         * defs.h (info_verbose): Likewise.
4540         * demangle.c (demangle): Likewise.
4541         (asm_demangle): Likewise.
4542         * dwarf-index-cache.c (debug_index_cache): Likewise.
4543         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4544         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4545         * dwarf2read.c (check_physname): Likewise.
4546         (use_deprecated_index_sections): Likewise.
4547         (dwarf_always_disassemble): Likewise.
4548         * eval.c (overload_resolution): Likewise.
4549         * event-top.c (set_editing_cmd_var): Likewise.
4550         (exec_done_display_p): Likewise.
4551         * event-top.h (set_editing_cmd_var): Likewise.
4552         (exec_done_display_p): Likewise.
4553         * exec.c (write_files): Likewise.
4554         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4555         (debug_fbsd_nat): Likewise.
4556         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4557         Likewise.
4558         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4559         <backtrace_past_entry> Likewise.
4560         * gdb-demangle.h (demangle): Likewise.
4561         (asm_demangle): Likewise.
4562         * gdb_bfd.c (bfd_sharing): Likewise.
4563         * gdbcore.h (write_files): Likewise.
4564         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4565         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4566         * gdbthread.h (print_thread_events): Likewise.
4567         * gdbtypes.c (opaque_type_resolution): Likewise.
4568         (strict_type_checking): Likewise.
4569         * gnu-nat.c (gnu_debug_flag): Likewise.
4570         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4571         * guile/scm-param.c (pascm_variable): Add boolval.
4572         (add_setshow_generic): Update.
4573         (pascm_param_value): Update.
4574         (pascm_set_param_value_x): Update.
4575         * hppa-tdep.c (hppa_debug): Change to bool..
4576         * infcall.c (may_call_functions_p): Likewise.
4577         (coerce_float_to_double_p): Likewise.
4578         (unwind_on_signal_p): Likewise.
4579         (unwind_on_terminating_exception_p): Likewise.
4580         * infcmd.c (startup_with_shell): Likewise.
4581         * inferior.c (print_inferior_events): Likewise.
4582         * inferior.h (startup_with_shell): Likewise.
4583         (print_inferior_events): Likewise.
4584         * infrun.c (step_stop_if_no_debug): Likewise.
4585         (detach_fork): Likewise.
4586         (debug_displaced): Likewise.
4587         (disable_randomization): Likewise.
4588         (non_stop): Likewise.
4589         (non_stop_1): Likewise.
4590         (observer_mode): Likewise.
4591         (observer_mode_1): Likewise.
4592         (set_observer_mode): Update.
4593         (sched_multi): Change to bool.
4594         * infrun.h (debug_displaced): Likewise.
4595         (sched_multi): Likewise.
4596         (step_stop_if_no_debug): Likewise.
4597         (non_stop): Likewise.
4598         (disable_randomization): Likewise.
4599         * linux-tdep.c (use_coredump_filter): Likewise.
4600         (dump_excluded_mappings): Likewise.
4601         * linux-thread-db.c (auto_load_thread_db): Likewise.
4602         (check_thread_db_on_load): Likewise.
4603         * main.c (captured_main_1): Update.
4604         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4605         xx2_opt, boolean_opt>: Change to bool.
4606         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4607         * maint.c (maintenance_profile_p): Likewise.
4608         (per_command_time): Likewise.
4609         (per_command_space): Likewise.
4610         (per_command_symtab): Likewise.
4611         * memattr.c (inaccessible_by_default): Likewise.
4612         * mi/mi-main.c (mi_async): Likewise.
4613         (mi_async_1): Likewise.
4614         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4615         * nat/fork-inferior.h (startup_with_shell): Likewise.
4616         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4617         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4618         * nios2-tdep.c (nios2_debug): Likewise.
4619         * or1k-tdep.c (or1k_debug): Likewise.
4620         * parse.c (parser_debug): Likewise.
4621         * parser-defs.h (parser_debug): Likewise.
4622         * printcmd.c (print_symbol_filename): Likewise.
4623         * proc-api.c (procfs_trace): Likewise.
4624         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4625         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4626         (set_parameter_value): Update.
4627         (add_setshow_generic): Update.
4628         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4629         to bool*.
4630         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4631         int*.
4632         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4633         * record-btrace.c (record_btrace_target::store_registers): Update.
4634         * record-full.c (record_full_memory_query): Change to bool.
4635         (record_full_stop_at_limit): Likewise.
4636         * record-full.h (record_full_memory_query): Likewise.
4637         * remote-notif.c (notif_debug): Likewise.
4638         * remote-notif.h (notif_debug): Likewise.
4639         * remote.c (use_range_stepping): Likewise.
4640         (interrupt_on_connect): Likewise.
4641         (remote_break): Likewise.
4642         * ser-tcp.c (tcp_auto_retry): Likewise.
4643         * ser-unix.c (serial_hwflow): Likewise.
4644         * skip.c (debug_skip): Likewise.
4645         * solib-aix.c (solib_aix_debug): Likewise.
4646         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4647         (spu_auto_flush_cache_p): Likewise.
4648         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4649         Likewise.
4650         (struct info_print_options) <quiet>: Likewise.
4651         * symfile-debug.c (debug_symfile): Likewise.
4652         * symfile.c (auto_solib_add): Likewise.
4653         (separate_debug_file_debug): Likewise.
4654         * symfile.h (auto_solib_add): Likewise.
4655         (separate_debug_file_debug): Likewise.
4656         * symtab.c (basenames_may_differ): Likewise.
4657         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4658         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4659         (struct info_types_options) <quiet>: Likewise.
4660         * symtab.h (demangle): Likewise.
4661         (basenames_may_differ): Likewise.
4662         * target-dcache.c (stack_cache_enabled_1): Likewise.
4663         (code_cache_enabled_1): Likewise.
4664         * target.c (trust_readonly): Likewise.
4665         (may_write_registers): Likewise.
4666         (may_write_memory): Likewise.
4667         (may_insert_breakpoints): Likewise.
4668         (may_insert_tracepoints): Likewise.
4669         (may_insert_fast_tracepoints): Likewise.
4670         (may_stop): Likewise.
4671         (auto_connect_native_target): Likewise.
4672         (target_stop_and_wait): Update.
4673         (target_async_permitted): Change to bool.
4674         (target_async_permitted_1): Likewise.
4675         (may_write_registers_1): Likewise.
4676         (may_write_memory_1): Likewise.
4677         (may_insert_breakpoints_1): Likewise.
4678         (may_insert_tracepoints_1): Likewise.
4679         (may_insert_fast_tracepoints_1): Likewise.
4680         (may_stop_1): Likewise.
4681         * target.h (target_async_permitted): Likewise.
4682         (may_write_registers): Likewise.
4683         (may_write_memory): Likewise.
4684         (may_insert_breakpoints): Likewise.
4685         (may_insert_tracepoints): Likewise.
4686         (may_insert_fast_tracepoints): Likewise.
4687         (may_stop): Likewise.
4688         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4689         (make_thread_apply_all_options_def_group): Change argument from int*
4690         to bool*.
4691         (thread_apply_all_command): Update.
4692         (print_thread_events): Change to bool.
4693         * top.c (confirm): Likewise.
4694         (command_editing_p): Likewise.
4695         (history_expansion_p): Likewise.
4696         (write_history_p): Likewise.
4697         (info_verbose): Likewise.
4698         * top.h (confirm): Likewise.
4699         (history_expansion_p): Likewise.
4700         * tracepoint.c (disconnected_tracing): Likewise.
4701         (circular_trace_buffer): Likewise.
4702         * typeprint.c (print_methods): Likewise.
4703         (print_typedefs): Likewise.
4704         * utils.c (debug_timestamp): Likewise.
4705         (sevenbit_strings): Likewise.
4706         (pagination_enabled): Likewise.
4707         * utils.h (sevenbit_strings): Likewise.
4708         (pagination_enabled): Likewise.
4709         * valops.c (overload_resolution): Likewise.
4710         * valprint.h (struct value_print_options) <prettyformat_arrays,
4711         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4712         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4713         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4714         Likewise.
4715         * windows-nat.c (new_console): Likewise.
4716         (cygwin_exceptions): Likewise.
4717         (new_group): Likewise.
4718         (debug_exec): Likewise.
4719         (debug_events): Likewise.
4720         (debug_memory): Likewise.
4721         (debug_exceptions): Likewise.
4722         (useshell): Likewise.
4723         * windows-tdep.c (maint_display_all_tib): Likewise.
4724         * xml-support.c (debug_xml): Likewise.
4725
4726 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4727
4728         * source.c (prepare_path_for_appending): New function.
4729         (openp): Make use of new function.
4730         (find_and_open_source): Search for the compilation directory and
4731         source file as a relative path beneath the directory search path.
4732
4733 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4734
4735         * source-cache.c (source_cache::get_line_charpos): Catch
4736         exceptions and return false, this matches the behaviour documented
4737         in the header file.
4738
4739 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4740
4741         * ada-tasks.c (info_task): Remove quoting of the task's name.
4742
4743 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4744
4745         * symfile.c (auto_solib_add): Replace comment with a reference
4746         to the header file.
4747
4748 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4749
4750         * NEWS: Mention that gdb can now be compiled with Python 3
4751         on Windows.
4752
4753 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4754
4755         * maint.c (maint_print_section_data::maint_print_section_data):
4756         Force use of 'float log10 (float)' by casting the argument to
4757         float.
4758
4759 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4760
4761         * maint.c: Add 'cmath' include.
4762         (struct maint_print_section_data): New structure.
4763         (print_section_index): New function.
4764         (print_bfd_section_info): Add header comment, small whitespace
4765         cleanup, and update to call new print_section_index function.
4766         (print_objfile_section_info): Likewise.
4767         (maint_obj_section_from_bfd_section): New function.
4768         (print_bfd_section_info_maybe_relocated): New function.
4769         (maintenance_info_sections): Add header comment, always use
4770         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4771
4772 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4773
4774         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4775         inner scope, add check that the objfile has psymtabs before
4776         checking psymtabs_addrmap.
4777         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4778
4779 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4780
4781         * NEWS: Announce that Ada task names are now shown at more places,
4782         and between quotes (except in info task output).
4783         * gdb/ada-tasks.c (task_to_str): New function.
4784         (display_current_task_id): Call task_to_str.
4785         (task_command_1): Likewise.
4786         (print_ada_task_info): In non-mi mode, Properly align headers and data
4787         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4788
4789 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4790
4791         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4792         prstatus.pr_lwp.pr_info instead of making it up.
4793
4794 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4795
4796         * auto-load.c (auto_load_expand_dir_vars): Update.
4797         * defs.h (gdb_datadir): Change to std::string.
4798         (python_libdir): Likewise.
4799         (relocate_gdb_directory): Change return type to std::string.
4800         * guile/guile.c (gdbscm_data_directory): Update.
4801         (initialize_scheme_side): Update.
4802         * jit.c (jit_reader_dir): Change to std::string.
4803         (jit_reader_load_command): Update.
4804         * main.c (gdb_datadir): Change to std::string.
4805         (python_libdir): Likewise.
4806         (set_gdb_data_directory): Update.
4807         (relocate_path): Change to return std::string.
4808         (relocate_gdb_directory): Change to return std::string.
4809         (relocate_gdbinit_path_maybe_in_datadir): Update.
4810         (captured_main_1): Update.
4811         * python/python.c (do_start_initialization): Update.
4812         * top.c (show_gdb_datadir): Update.
4813         * xml-syscall.c (xml_init_syscalls_info): Update.
4814         (init_syscalls_info): Update.
4815
4816 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4817
4818         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4819         out of get_init_files.
4820         (get_init_files): Update.
4821
4822 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4823
4824         * main.c (get_init_files): Change to use std::string.
4825         (captured_main_1): Update.
4826         (print_gdb_help): Update.
4827
4828 2019-09-11  Ali Tamur  <tamur@google.com>
4829
4830         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4831         implementation.
4832
4833 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4834
4835         * dbxread.c (read_dbx_symtab): Update.
4836         * dwarf2read.c (load_partial_dies): Update.
4837         * mdebugread.c (parse_partial_symbols): Update.
4838         (handle_psymbol_enumerators): Update.
4839         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4840         * psymtab.c (add_psymbol_to_bcache): Likewise.
4841         (add_psymbol_to_list): Likewise.
4842         * symtab.c (symbol_set_names): Likewise.
4843         * symtab.h (symbol_set_names): Likewise.
4844         * xcoffread.c (scan_xcoff_symtab): Update.
4845
4846 2019-09-11  Tom Tromey  <tom@tromey.com>
4847
4848         * symfile-mem.c (symbol_file_add_from_memory): Use
4849         bfd_set_filename.
4850         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4851         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4852
4853 2019-09-10  Tom Tromey  <tromey@adacore.com>
4854
4855         * dwarf-index-write.c (write_psymbols): Extend error message.
4856         (debug_names::insert): Add Ada code.
4857         (debug_names::write_psymbols): Remove Ada check.
4858         (debug_names) <m_string_obstack>: New member.
4859         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4860         (gdb_index_symbol_name_matcher::matches): Remove.
4861         (mapped_index_base::find_name_components_bounds): Add "lang"
4862         parameter.
4863         (mapped_index_base::build_name_components): Also split names
4864         according to Ada syntax.
4865         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4866         type of "match_callback".
4867         (check_match, check_find_bounds_finds)
4868         (dw2_expand_symtabs_matching): Update.
4869         (dw2_debug_names_iterator): Add new constructor.
4870         (dw2_debug_names_map_matching_symbols): New function.
4871         (dw2_debug_names_expand_symtabs_matching): Update.
4872         (dwarf2_debug_names_functions): Use
4873         dw2_debug_names_map_matching_symbols.
4874
4875 2019-09-10  Tom Tromey  <tromey@adacore.com>
4876
4877         * dwarf2read.c (dw2_get_file_names_reader): Add the
4878         CU's file name to the results.
4879
4880 2019-09-10  Tom Tromey  <tromey@adacore.com>
4881
4882         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4883         map_matching_symbols.  Update.
4884         * dwarf2read.c (dw2_map_matching_symbols): Update.
4885         * psymtab.c (match_partial_symbol): Change type; update.
4886         (psym_map_matching_symbols): Likewise.
4887         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4888         type; update.
4889         * symfile.h (struct quick_symbol_functions)
4890         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4891         Remove "match".
4892
4893 2019-09-10  Tom Tromey  <tromey@adacore.com>
4894
4895         * psymtab.c (map_block): Remove.
4896         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4897         * symtab.c (iterate_over_symbols_terminated): New function.
4898         * symtab.c (iterate_over_symbols_terminated): Declare.
4899
4900 2019-09-10  Tom Tromey  <tromey@adacore.com>
4901
4902         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4903         * language.h (struct language_defn) <la_iterate_over_symbols>:
4904         Return bool.
4905         * symtab.c (iterate_over_symbols): Return bool.
4906         * symtab.h (iterate_over_symbols): Return bool.
4907
4908 2019-09-10  Tom Tromey  <tromey@adacore.com>
4909
4910         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4911         (add_nonlocal_symbols): Update.
4912         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4913         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4914         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4915         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4916         Change type of "callback".  Remove "data".
4917
4918
4919 2019-09-09  Ali Tamur  <tamur@google.com>
4920
4921         * dwarf2read.c (comp_unit_head): Update comment.
4922         (dwarf2_dwo_name): New function declaration.
4923         (dwarf_unit_type_name): New function declaration.
4924         (read_comp_unit_head): Add support for new compilation units,
4925         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4926         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4927         (currently named as "signature") in their header. Also clarify error
4928         messages.
4929         (lookup_dwo_id): New function. Returns the dwo id of the given
4930         compile unit.
4931         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4932         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4933         functions.
4934         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4935         (dwarf2_dwo_name): Get the dwo name if present.
4936         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4937         purposes.
4938
4939 2019-09-09  Tom Tromey  <tom@tromey.com>
4940
4941         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4942
4943 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4944
4945         * python/python.c (do_start_initialization): Make progname_copy static,
4946         to avoid a leak report.
4947
4948 2019-09-08  Tom Tromey  <tom@tromey.com>
4949
4950         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4951
4952 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4953
4954         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4955         Change type to gdb::optional<block_enum>.
4956         (dw2_symtab_iter_init): Change block_index parameter type
4957         to gdb::optional<block_enum>.
4958         (dw2_lookup_symbol): Change block_index parameter
4959         type to block_enum.c
4960         (dw2_debug_names_lookup_symbol): Likewise.
4961         * psymtab.c (psym_lookup_symbol): Likewise.
4962         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4963         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4964         Likewise.
4965
4966 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4967
4968         * defs.h (relocate_gdb_directory): Change int to bool in
4969         signature and rename flag to relocatable.
4970         * main.c (relocate_path): Likewise.
4971         (relocate_gdb_directory): Likewise.
4972
4973 2019-09-06  Alan Modra  <amodra@gmail.com>
4974
4975         * coffread.c (coff_symfile_read): Constify filename variable.
4976         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4977         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4978         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4979         * solib.c (reload_shared_libraries_1): Likewise.
4980         * symfile.c (reread_symbols): Likewise.
4981         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4982         * solib-darwin.c (darwin_bfd_open): Likewise.
4983         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4984
4985 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4986
4987         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4988         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4989
4990 2019-09-03  Tom Tromey  <tromey@adacore.com>
4991
4992         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4993         types.
4994         (has_negatives): Unbias a range type bound.
4995         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4996         * gdbtypes.c (operator==): Handle new field.
4997         (create_range_type): Add "bias" parameter.
4998         (create_static_range_type, resolve_dynamic_range): Update.
4999         * gdbtypes.h (struct range_bounds) <bias>: New member.
5000         (create_range_type): Add bias parameter.
5001         * printcmd.c (print_scalar_formatted): Unbias range types.
5002         * value.c (unpack_long): Unbias range types.
5003         (pack_long): Bias range types.
5004
5005 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5006
5007         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
5008         probe arguments.
5009
5010 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5011
5012         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
5013         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
5014         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
5015         (compile_probe_arg): Likewise.
5016         * probe.h (get_argument_count): Likewise.
5017         * solib-svr4.c (solib_event_probe_action): Likewise.
5018         * stap-probe.c (stap_probe::get_argument_count): Likewise.
5019
5020 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5021
5022         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
5023         code to here...
5024         (svr4_create_solib_event_breakpoints): ...from here.
5025
5026 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
5027
5028         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
5029         suffix from warning message.
5030
5031 2019-08-30  Tom Tromey  <tom@tromey.com>
5032
5033         * tui/tui-winsource.h (struct tui_source_window_base)
5034         <refresh_all>: Don't declare.
5035         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
5036         Remove.
5037         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
5038         tui_show_locator_content.
5039         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
5040         declare.
5041         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
5042         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
5043         declare.
5044
5045 2019-08-30  Tom Tromey  <tom@tromey.com>
5046
5047         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
5048
5049 2019-08-30  Tom Tromey  <tom@tromey.com>
5050
5051         * tui/tui-stack.c (_initialize_tui_stack): Move later.
5052         Remove unnecessary forward declarations.
5053
5054 2019-08-30  Tom Tromey  <tom@tromey.com>
5055
5056         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
5057         rerender.
5058         (tui_update_locator_fullname, tui_show_frame_info): Don't call
5059         tui_show_locator_content.
5060
5061 2019-08-30  Tom Tromey  <tom@tromey.com>
5062
5063         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
5064         (tui_locator_window::rerender): Rewrite using body of previous
5065         tui_show_locator_content.
5066
5067 2019-08-30  Tom Tromey  <tom@tromey.com>
5068
5069         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5070         set_locator_fullname>: New methods.
5071         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5072         Rename from tui_set_locator_fullname.
5073         (tui_locator_window::set_locator_info): Rename from
5074         tui_set_locator_info.  Return bool.
5075         (tui_update_locator_fullname, tui_show_frame_info): Update.
5076
5077 2019-08-30  Tom Tromey  <tom@tromey.com>
5078
5079         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5080
5081 2019-08-30  Tom Tromey  <tom@tromey.com>
5082
5083         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5084         call touchwin.
5085
5086 2019-08-30  Tom Tromey  <tom@tromey.com>
5087
5088         * tui/tui-wingeneral.c (box_win): Assume win_info and
5089         win_info->handle cannot be NULL.
5090
5091 2019-08-30  Tom Tromey  <tom@tromey.com>
5092
5093         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5094         refresh_window>: Declare.
5095         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5096         resize.
5097         (tui_data_item_window::rerender): Rename from
5098         tui_display_register.
5099         (tui_data_item_window::refresh_window): New method.
5100         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5101         no-op.
5102
5103 2019-08-30  Tom Tromey  <tom@tromey.com>
5104
5105         * tui/tui-regs.h (struct tui_data_window) <regs_content,
5106         regs_column_count, current_group>: Move later.  Now private.
5107         <get_current_group>: New method.
5108         * tui/tui-regs.c (tui_reg_command): Update.
5109         * tui/tui-layout.c (tui_set_layout): Update.
5110
5111 2019-08-30  Tom Tromey  <tom@tromey.com>
5112
5113         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5114         (tui_data_window::rerender): Don't call
5115         check_and_display_highlight_if_needed.
5116         (tui_data_window::refresh_all): Remove call to
5117         erase_data_content.
5118
5119 2019-08-30  Tom Tromey  <tom@tromey.com>
5120
5121         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5122         (tui_data_window::display_registers_from)
5123         (tui_data_window::display_reg_element_at_line)
5124         (tui_data_window::display_registers_from_line): Remove checks of
5125         "empty".
5126
5127 2019-08-30  Tom Tromey  <tom@tromey.com>
5128
5129         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5130         Don't declare.
5131         * tui/tui-regs.c (tui_data_window::show_registers): Call
5132         rerender.
5133         (tui_data_window::rerender): Rename from display_all_data.
5134         (tui_data_window::rerender): Remove old implementation.
5135
5136 2019-08-30  Tom Tromey  <tom@tromey.com>
5137
5138         * tui/tui-regs.c (tui_data_window::display_all_data): Change
5139         text.
5140         * tui/tui-data.h (NO_DATA_STRING): Remove define.
5141
5142 2019-08-29  Bernhard Wodok  <barto@gmx.net>
5143             Sergio Durigan Junior  <sergiodj@redhat.com>
5144
5145         PR win32/24284
5146         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5147
5148 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5149
5150         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5151         when searching for types.
5152
5153 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5154
5155         * f-lang.c (f_language_defn): Use f_print_typedef.
5156         * f-lang.h (f_print_typedef): Declare.
5157         * f-typeprint.c (f_print_typedef): Define.
5158
5159 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
5160
5161         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5162
5163 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5164
5165         * cli/cli-utils.c (info_print_options_defs): Delete.
5166         (make_info_print_options_def_group): Delete.
5167         (extract_info_print_options): Delete.
5168         (info_print_command_completer): Delete.
5169         (info_print_args_help): Add extra parameter, and optionally
5170         include text about -n flag.
5171         * cli/cli-utils.h (struct info_print_options): Delete.
5172         (extract_info_print_options): Delete declaration.
5173         (info_print_command_completer): Delete declaration.
5174         (info_print_args_help): Add extra parameter, extend header
5175         comment.
5176         * python/python.c (gdbpy_rbreak): Pass additional parameter to
5177         search_symbols.
5178         * stack.c (struct info_print_options): New type.
5179         (info_print_options_defs): New file scoped variable.
5180         (make_info_print_options_def_group): New static function.
5181         (info_print_command_completer): New static function.
5182         (info_locals_command): Update to use new local functions.
5183         (info_args_command): Likewise.
5184         (_initialize_stack): Add extra parameter to calls to
5185         info_print_args_help.
5186         * symtab.c (search_symbols): Add extra parameter, use this to
5187         possibly excluse non-debug symbols.
5188         (symtab_symbol_info): Add extra parameter, which is passed on to
5189         search_symbols.
5190         (struct info_print_options): New type.
5191         (info_print_options_defs): New file scoped variable.
5192         (make_info_print_options_def_group): New static function.
5193         (info_print_command_completer): New static function.
5194         (info_variables_command): Update to use local functions, and pass
5195         extra parameter through to symtab_symbol_info.
5196         (info_functions_command): Likewise.
5197         (info_types_command): Pass additional argument through to
5198         symtab_symbol_info.
5199         (rbreak_command): Pass extra argument to search_symbols.
5200         (_initialize_symtab): Add extra arguments for calls to
5201         info_print_args_help, and update help text for 'info variables',
5202         'whereis', and 'info functions' commands.
5203         * symtab.h (search_symbols): Add extra argument to declaration.
5204         * NEWS: Mention new flags.
5205
5206 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5207
5208         * symtab.c (lookup_static_symbol): Call the new function (and move
5209         it down to be next to lookup_global_symbol).
5210         (struct global_sym_lookup_data): Add block_enum member and rename to...
5211         (struct global_or_static_sym_lookup_data): ...this.
5212         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5213         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5214         (lookup_symbol_global_or_static_iterator_cb): ...this.
5215         (lookup_global_or_static_symbol): New function.
5216         (lookup_global_symbol): Call new function.
5217
5218 2019-08-26  Tom de Vries  <tdevries@suse.de>
5219
5220         PR c++/24852
5221         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5222         when pc_probe.prob == NULL.
5223
5224 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5225
5226         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5227         variable symbol_linkage to symbol_linkage_.
5228
5229 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5230
5231         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5232         represent whether the symbol is static, dynamic, or we don't
5233         know.
5234
5235 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5236
5237         * gdb/rx-tdep.c (rx_register_names): New.
5238         (rx_register_name): Delete.
5239         (rx_psw_type): Delete.
5240         (rx_fpsw_type): Delete.
5241         (rx_register_type): Delete.
5242         (rx_gdbarch_init): Convert target-descriptions.
5243         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5244         * gdb/features/Makefile: Add rx.xml.
5245         * gdb/features/rx.xml: New.
5246         * gdb/features/rx.c: Generated.
5247         * gdb/NEWS: Mention target description support.
5248
5249 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5250
5251         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5252         *slot_ptr.
5253
5254 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5255
5256         * configure.ac: Don't check for 'dlfcn.h' (moved to
5257         gdbsupport/common.m4).
5258         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5259         'gdbsupport/'.
5260         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5261         * compile/compile-c-support.c: Include
5262         'gdbsupport/gdb-dlfcn.h'.
5263         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5264         * gdb-dlfcn.c: Move to...
5265         * gdbsupport/gdb-dlfcn.c: ... here.
5266         * gdb-dlfcn.h: Move to...
5267         * gdbsupport/gdb-dlfcn.h: ... here.
5268
5269 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5270
5271         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5272         the offset field signed.
5273
5274 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5275
5276         * python/lib/gdb/__init__.py (_execute_file): New function.
5277         * python/python.c (python_run_simple_file): Call gdb._execute_file
5278         on Windows.
5279
5280 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5281
5282         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5283         all uses as this was never set to anything but a zero value.
5284
5285 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5286
5287         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5288
5289 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5290
5291         * tui/tui-data.h (tui_gen_win_info): Add an =default
5292         move constructor, required by some GCC versions.
5293
5294 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5295
5296         * go32-nat.c (go32_sysinfo): Add hygon_p.
5297
5298 2019-08-20  Tom Tromey  <tom@tromey.com>
5299
5300         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5301         line_from_reg_element_no, first_reg_element_no_inline,
5302         display_all_data, delete_data_content_windows,
5303         erase_data_content>: Now private.
5304
5305 2019-08-20  Tom Tromey  <tom@tromey.com>
5306
5307         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5308         (tui_unhighlight_win, tui_highlight_win)
5309         (tui_win_info::make_window): Update.
5310         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5311
5312 2019-08-20  Tom Tromey  <tom@tromey.com>
5313
5314         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5315         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5316         (MAX_PID_WIDTH): Move to tui-stack.c.
5317         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5318         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5319         (MAX_PID_WIDTH): Move from tui-data.h.
5320
5321 2019-08-20  Tom Tromey  <tom@tromey.com>
5322
5323         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5324         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5325         (box_win): Update.
5326         (tui_gen_win_info::make_window): Rename from tui_make_window.
5327         (tui_win_info::make_window): New method.
5328         (tui_gen_win_info::make_visible): Update.
5329         * tui/tui-source.c (tui_source_window::set_contents): Update.
5330         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5331         (tui_data_window::display_registers_from): Update.
5332         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5333         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5334         Declare.
5335         <can_box>: Remove.
5336         <title>: Remove.
5337         (struct tui_win_info) <make_window>: Declare.
5338         <can_box>: Now virtual.
5339         <title>: New member.
5340         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5341         * tui/tui-command.c (tui_cmd_window::resize): Update.
5342
5343 2019-08-20  Tom Tromey  <tom@tromey.com>
5344
5345         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5346         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5347         (tui_data_window::check_register_values): Update.
5348
5349 2019-08-20  Tom Tromey  <tom@tromey.com>
5350
5351         * tui/tui-regs.h (struct tui_data_window): Use
5352         DISABLE_COPY_AND_ASSIGN.
5353         <regs_content>: Change type, removing unique_ptr.
5354         <tui_data_window>: Add move constructor.
5355         * tui/tui-regs.c (tui_data_window::show_registers)
5356         (tui_data_window::show_register_group)
5357         (tui_data_window::display_registers_from)
5358         (tui_data_window::display_registers_from)
5359         (tui_data_window::first_data_item_displayed)
5360         (tui_data_window::delete_data_content_windows)
5361         (tui_data_window::rerender, tui_data_window::refresh_window)
5362         (tui_data_window::check_register_values): Update.
5363
5364 2019-08-20  Tom Tromey  <tom@tromey.com>
5365
5366         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5367         show_register_group>: Declare.
5368         (tui_show_register_group): Don't declare.
5369         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5370         tui_show_registers.
5371         (tui_data_window::show_register_group): Rename from
5372         tui_show_register_group.
5373         (tui_data_window::check_register_values, tui_reg_command):
5374         Update.
5375         * tui/tui-layout.c (tui_set_layout): Update.
5376
5377 2019-08-20  Tom Tromey  <tom@tromey.com>
5378
5379         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5380         Declare.
5381         (tui_check_register_values): Don't declare.
5382         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5383         from tui_check_register_values.
5384         * tui/tui-hooks.c (tui_register_changed): Update.
5385
5386 2019-08-20  Tom Tromey  <tom@tromey.com>
5387
5388         * tui/tui-regs.c (tui_reg_layout): Move later.
5389         (tui_show_registers): Don't enable TUI mode or change layout.
5390
5391 2019-08-20  Tom Tromey  <tom@tromey.com>
5392
5393         * tui/tui-regs.h (struct tui_data_item_window)
5394         <~tui_data_item_window>: Remove.
5395         <content>: Now a unique_xmalloc_ptr.
5396         * tui/tui-regs.c (tui_register_format): Return a
5397         unique_xmalloc_ptr.
5398         (tui_get_register): Update.
5399         (~tui_data_item_window): Remove.
5400         (tui_data_window::display_registers_from, tui_display_register):
5401         Update.
5402         * tui/tui-io.h (tui_expand_tabs): Update.
5403         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5404         Remove "col" parameter.
5405
5406 2019-08-20  Tom Tromey  <tom@tromey.com>
5407
5408         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5409         field.
5410         * tui/tui-regs.c (~tui_data_item_window): Update.
5411
5412 2019-08-20  Tom Tromey  <tom@tromey.com>
5413
5414         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5415         earlier.
5416
5417 2019-08-20  Tom Tromey  <tom@tromey.com>
5418
5419         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5420
5421 2019-08-20  Tom Tromey  <tom@tromey.com>
5422
5423         * tui/tui-source.h (struct tui_source_window): Update.
5424         * tui/tui-regs.c (tui_show_registers): Update.
5425         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5426         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5427         (NO_REGS_STRING): Remove defines.
5428
5429 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5430
5431         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5432         unnecessary thread walk if remote doesn't support the packet.
5433
5434 2019-08-19  Tom Tromey  <tromey@adacore.com>
5435
5436         * python/py-value.c (value_has_field): Fix indentation.
5437
5438 2019-08-19  Tom Tromey  <tromey@adacore.com>
5439
5440         * printcmd.c (do_one_display, info_display_command): Update.
5441         * block.h (contained_in): Return bool.  Add allow_nested
5442         parameter.
5443         * block.c (contained_in): Return bool.  Add allow_nested
5444         parameter.
5445
5446 2019-08-19  Tom Tromey  <tom@tromey.com>
5447
5448         * configure: Rebuild.
5449         * configure.ac: Disallow the combination of -static-libstdc++ and
5450         source highlight.
5451         * source-cache.c (get_language_name): Handle rust.
5452         (source_cache::get_source_lines): Ignore highlighting exceptions.
5453
5454 2019-08-16  Tom Tromey  <tom@tromey.com>
5455
5456         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5457         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5458         (struct tui_source_window_base) <make_visible, refresh_window,
5459         resize>: Remove methods.
5460         <execution_info>: Remove field.
5461         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5462         (tui_show_source_line, tui_source_window_base)
5463         (~tui_source_window_base): Update.
5464         (tui_source_window_base::resize)
5465         (tui_source_window_base::make_visible)
5466         (tui_source_window_base::refresh_window): Remove.
5467         (tui_source_window_base::update_exec_info): Update.
5468         * tui/tui-source.c (tui_source_window::set_contents): Update.
5469         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5470
5471 2019-08-16  Tom Tromey  <tom@tromey.com>
5472
5473         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5474         deprecated_query_hook.
5475
5476 2019-08-16  Tom Tromey  <tom@tromey.com>
5477
5478         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5479         (tui_update_source_windows_with_line): Update.
5480         * tui/tui-source.h (struct tui_source_window)
5481         <show_symtab_source>: Declare.
5482         (tui_show_symtab_source): Don't declare.
5483         * tui/tui-source.c (tui_show_symtab_source): Rename from
5484         tui_show_symtab_source.
5485
5486 2019-08-16  Tom Tromey  <tom@tromey.com>
5487
5488         * tui/tui-winsource.h (struct tui_source_window_base)
5489         <set_contents>: Declare.
5490         * tui/tui-winsource.c
5491         (tui_source_window_base::update_source_window_as_is): Update.
5492         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5493         Declare.
5494         (tui_set_source_content): Don't declare.
5495         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5496         tui_set_source_content.
5497         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5498         Declare.
5499         (tui_set_disassem_content): Don't declare.
5500         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5501         tui_set_disassem_content.
5502
5503 2019-08-16  Tom Tromey  <tom@tromey.com>
5504
5505         * tui/tui-winsource.h (struct tui_source_window_base)
5506         <update_breakpoint_info>: Declare.
5507         (tui_update_breakpoint_info): Don't declare.
5508         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5509         (tui_update_all_breakpoint_info): Update.
5510         (tui_source_window_base::update_breakpoint_info): Rename from
5511         tui_update_breakpoint_info.
5512         (tui_source_window_base::update_exec_info): Update.
5513
5514 2019-08-16  Tom Tromey  <tom@tromey.com>
5515
5516         * tui/tui-winsource.h (struct tui_source_window_base)
5517         <update_source_window>: Declare.
5518         (tui_update_source_window): Don't declare.
5519         * tui/tui-winsource.c
5520         (tui_source_window_base::update_source_window): Rename from
5521         tui_update_source_window.
5522         (tui_source_window_base::rerender): Update.
5523         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5524         * tui/tui-disasm.c (tui_show_disassem)
5525         (tui_show_disassem_and_update_source)
5526         (tui_disasm_window::maybe_update): Update.
5527
5528 2019-08-16  Tom Tromey  <tom@tromey.com>
5529
5530         * tui/tui-winsource.h (struct tui_source_window_base)
5531         <update_source_window_as_is>: Declare.
5532         (tui_update_source_window_as_is): Don't declare.
5533         * tui/tui-winsource.c (tui_update_source_window): Update
5534         (tui_source_window_base::update_source_window_as_is): Rename from
5535         tui_update_source_window_as_is.
5536         (tui_source_window_base::refill): Update.
5537         * tui/tui-source.c (tui_show_symtab_source): Update.
5538         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5539         Update.
5540
5541 2019-08-16  Tom Tromey  <tom@tromey.com>
5542
5543         * tui/tui-winsource.h (tui_update_source_window)
5544         (tui_update_source_window_as_is): Remove "noerror" parameter.
5545         * tui/tui-winsource.c (tui_update_source_window)
5546         (tui_update_source_window_as_is): Remove "noerror" parameter.
5547         (tui_update_source_windows_with_addr)
5548         (tui_update_source_windows_with_line)
5549         (tui_source_window_base::rerender)
5550         (tui_source_window_base::refill): Update.
5551         * tui/tui-source.h (tui_set_source_content)
5552         (tui_show_symtab_source): Remove "noerror" parameter.
5553         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5554         parameter.
5555         (tui_show_symtab_source): Likewise.
5556         (tui_source_window::maybe_update): Update.
5557         * tui/tui-disasm.c (tui_show_disassem)
5558         (tui_show_disassem_and_update_source)
5559         (tui_disasm_window::do_scroll_vertical)
5560         (tui_disasm_window::maybe_update): Update.
5561
5562 2019-08-16  Tom Tromey  <tom@tromey.com>
5563
5564         * tui/tui.c (tui_is_window_visible): Update.
5565         * tui/tui-wingeneral.c (tui_make_window)
5566         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5567         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5568         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5569         (tui_set_win_height_command, parse_scrolling_args): Update.
5570         * tui/tui-source.c (tui_source_window::style_changed): Update.
5571         * tui/tui-regs.c (tui_show_registers)
5572         (tui_data_window::first_data_item_displayed)
5573         (tui_data_window::delete_data_content_windows)
5574         (tui_check_register_values, tui_reg_command): Update.
5575         * tui/tui-disasm.c (tui_show_disassem): Update.
5576         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5577         method.
5578         <is_visible>: Remove field.
5579         * tui/tui-data.c (tui_next_win, tui_prev_win)
5580         (tui_delete_invisible_windows): Update.
5581
5582 2019-08-16  Tom Tromey  <tom@tromey.com>
5583
5584         * tui/tui-winsource.h (struct tui_source_window_base)
5585         <m_has_locator>: Remove.
5586         * tui/tui-layout.c (show_source_disasm_command, show_data)
5587         (show_source_or_disasm_and_command): Update.
5588
5589 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5590
5591         * NEWS (Other MI changes): New subsection.
5592         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5593         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5594         * arch-utils.c (default_get_pc_address_flags): New function.
5595         * arch-utils.h (default_get_pc_address_flags): New declaration.
5596         * gdbarch.sh: Add get_pc_address_flags.
5597         * gdbarch.c: Regenerate.
5598         * gdbarch.h: Likewise.
5599         * stack.c (print_pc): New function.
5600         (print_frame_info) (print_frame): Call print_pc.
5601
5602 2019-08-16  Tom de Vries  <tdevries@suse.de>
5603
5604         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5605         print_objfile_section_info.
5606
5607 2019-08-15  Tom Tromey  <tom@tromey.com>
5608
5609         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5610         calling update_cmdwin_start_line.
5611         * tui/tui-winsource.h (struct tui_source_window_base)
5612         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5613         <rerender>: Declare.
5614         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5615         Call rerender.
5616         (tui_source_window_base::set_new_height): Remove.
5617         (tui_source_window_base::rerender): Rename from
5618         do_make_visible_with_new_height.
5619         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5620         resize method.
5621         (tui_win_info::make_invisible_and_set_new_height)
5622         (tui_win_info::make_visible_with_new_height): Remove.
5623         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5624         Declare.
5625         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5626         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5627         do_make_visible_with_new_height>: Don't declare.
5628         <rerender>: Declare.
5629         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5630         set_new_height.
5631         (tui_data_window::do_make_visible_with_new_height): Remove.
5632         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5633         call tui_show_locator_content.
5634         (tui_gen_win_info::resize): Call rerender.
5635         (show_source_or_disasm_and_command): Don't call
5636         tui_show_locator_content.
5637         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5638         method.
5639         (struct tui_win_info) <rerender>: Declare.
5640         <set_new_height, make_invisible_and_set_new_height,
5641         make_visible_with_new_height>: Don't declare.
5642         * tui/tui-data.c (tui_win_list::rerender): New method.
5643         * tui/tui-command.h (struct tui_cmd_window)
5644         <do_make_visible_with_new_height>: Don't declare.
5645         * tui/tui-command.c
5646         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5647
5648 2019-08-15  Tom Tromey  <tromey@adacore.com>
5649
5650         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5651         * ada-lang.c (ada_enum_name): Likewise.
5652
5653 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5654
5655         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5656         leading underscore.
5657         (GdbOutputErrorFile): Likewise.
5658         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5659         accordingly.
5660         (execute_unwinders): Rename to have a leading underscore.
5661         (auto_load_packages): Likewise.
5662         (global scope): Adjust call to auto_load_packages accordingly.
5663         (GdbSetPythonDirectory): Likewise.
5664         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5665         instead of execute_unwinders.
5666
5667 2019-08-15  Tom Tromey  <tom@tromey.com>
5668
5669         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5670         (show_data): Don't change window visibility.
5671         (tui_gen_win_info::resize): Remove special case for command
5672         window.  Use wresize, when available.
5673         (show_source_or_disasm_and_command): Don't change window
5674         visibility.
5675         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5676         <make_visible>: New method.
5677         * tui/tui-command.c (tui_cmd_window::resize): New method.
5678
5679 2019-08-15  Tom Tromey  <tom@tromey.com>
5680
5681         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5682         (struct tui_source_windows): New.
5683         * tui/tui-winsource.c (tui_display_main): Update.
5684         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5685         (new_height_ok, parse_scrolling_args): Update.
5686         * tui/tui-layout.c (show_layout, show_data): Update.
5687         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5688         (tui_add_to_source_windows): Don't declare.
5689         * tui/tui-data.c (source_windows, tui_source_windows)
5690         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5691
5692 2019-08-15  Tom Tromey  <tom@tromey.com>
5693
5694         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5695         Rename from reset.
5696         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5697         * tui/tui-layout.c (show_source_disasm_command, show_data):
5698         Update.
5699         (tui_gen_win_info::resize): Rename.
5700         (show_source_or_disasm_and_command): Update.
5701         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5702         reset.
5703
5704 2019-08-15  Tom Tromey  <tom@tromey.com>
5705
5706         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5707         * tui/tui-interp.c (tui_interp::init): Don't call
5708         tui_initialize_static_data.
5709         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5710
5711 2019-08-15  Tom Tromey  <tom@tromey.com>
5712
5713         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5714         examine tui_win_list.
5715
5716 2019-08-15  Tom Tromey  <tom@tromey.com>
5717
5718         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5719         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5720         tui_clear_source_content.
5721         (tui_clear_source_content): Remove.
5722         (tui_source_window_base::do_erase_source_content): Hoist call to
5723         content.clear().
5724         * tui/tui-stack.c (tui_show_frame_info): Don't call
5725         tui_clear_source_content.
5726
5727 2019-08-15  Tom Tromey  <tom@tromey.com>
5728
5729         * tui/tui-winsource.h (struct tui_source_window_base)
5730         <do_erase_source_content>: New method.
5731         <erase_source_content>: New method.
5732         (tui_erase_source_content): Don't declare.
5733         * tui/tui-winsource.c (tui_clear_source_content): Update.
5734         (tui_source_window_base::do_erase_source_content): Rename from
5735         tui_erase_source_content.
5736         (tui_source_window_base::show_source_content): Update.
5737         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5738         * tui/tui-source.h (struct tui_source_window)
5739         <erase_source_content>: New method.
5740         * tui/tui-disasm.h (struct tui_disasm_window)
5741         <erase_source_content>: New method.
5742
5743 2019-08-15  Tom Tromey  <tom@tromey.com>
5744
5745         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5746         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5747         constructor.
5748         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5749         * tui/tui-source.c (tui_set_source_content): Update.
5750         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5751
5752 2019-08-15  Tom Tromey  <tom@tromey.com>
5753
5754         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5755         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5756         tui-source.c.
5757         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5758         Declare.
5759         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5760         method.
5761         (tui_source_window::maybe_update): Update.
5762
5763 2019-08-15  Tom Tromey  <tom@tromey.com>
5764
5765         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5766         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5767         tui-disasm.c.
5768         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5769         Declare.
5770         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5771         method.
5772         (tui_disasm_window::maybe_update): Update.
5773
5774 2019-08-15  Tom Tromey  <tom@tromey.com>
5775
5776         * tui/tui-winsource.h (struct tui_source_window_base)
5777         <maybe_update>: Declare.
5778         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5779         method.
5780         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5781         Declare.
5782         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5783         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5784         Declare.
5785         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5786
5787 2019-08-15  Tom Tromey  <tom@tromey.com>
5788
5789         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5790
5791 2019-08-15  Tom Tromey  <tom@tromey.com>
5792
5793         * tui/tui-wingeneral.c: Include tui-stack.h.
5794         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5795         (struct tui_locator_window): Move from tui-data.h.
5796         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5797         (tui_initialize_static_data): Move from tui-data.c.
5798         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5799         (struct tui_locator_window): Move to tui-stack.c.
5800         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5801         (tui_initialize_static_data): Move to tui-stack.c.
5802
5803 2019-08-15  Tom Tromey  <tom@tromey.com>
5804
5805         * tui/tui-layout.c (show_source_disasm_command)
5806         (show_source_or_disasm_and_command): Use make_visible method, not
5807         tui_make_window.
5808         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5809         Remove.
5810
5811 2019-08-15  Tom Tromey  <tom@tromey.com>
5812
5813         * tui/tui-wingeneral.h (tui_make_window): Update.
5814         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5815         parameter.
5816         (tui_gen_win_info::make_visible): Update.
5817         * tui/tui-regs.c (tui_data_window::display_registers_from):
5818         Update.
5819         * tui/tui-layout.c (show_source_disasm_command)
5820         (show_source_or_disasm_and_command): Update.
5821         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5822         (enum tui_box): Remove.
5823         (struct tui_win_info) <can_box>: New method.
5824         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5825         method.
5826
5827 2019-08-15  Tom de Vries  <tdevries@suse.de>
5828
5829         * linux-nat-trad.c: Include gdbarch.h.
5830
5831 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5832
5833         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5834         register sizes.
5835
5836 2019-08-14  Tom Tromey  <tromey@adacore.com>
5837
5838         * darwin-nat.c: Include gdbarch.h.
5839         * darwin-nat-info.c: Include gdbarch.h.
5840
5841 2019-08-13  Tom Tromey  <tom@tromey.com>
5842
5843         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5844         Remove.
5845         * tui/tui-data.c (tui_initialize_static_data): Update.
5846
5847 2019-08-13  Tom Tromey  <tom@tromey.com>
5848
5849         * tui/tui-winsource.h (struct tui_exec_info_window)
5850         <~tui_exec_info_window, maybe_allocate_content, get_content,
5851         m_content>: Remove.
5852         (struct tui_source_window_base) <set_exec_info_content,
5853         show_exec_info_content>: Don't declare.
5854         * tui/tui-winsource.c
5855         (tui_exec_info_window::maybe_allocate_content): Remove.
5856         (tui_source_window_base::update_exec_info): Rename from
5857         set_exec_info_content.
5858         (tui_source_window_base::show_exec_info_content)
5859         (tui_source_window_base::update_exec_info): Remove.
5860
5861 2019-08-13  Tom Tromey  <tom@tromey.com>
5862
5863         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5864         declare.
5865         * tui/tui-winsource.c (tui_update_source_window_as_is)
5866         (tui_update_source_windows_with_addr, tui_erase_source_content):
5867         Update.
5868         (tui_clear_exec_info_content): Remove.
5869
5870 2019-08-13  Tom Tromey  <tom@tromey.com>
5871
5872         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5873         declare.
5874         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5875         call tui_erase_exec_info_content.
5876         (tui_clear_exec_info_content): Rename from
5877         tui_erase_exec_info_content.
5878         (tui_clear_exec_info_content): Delete.
5879
5880 2019-08-13  Tom Tromey  <tom@tromey.com>
5881
5882         * tui/tui-winsource.h (struct tui_source_window_base)
5883         <show_exec_info_content>: Declare.
5884         (tui_show_exec_info_content): Don't declare.
5885         * tui/tui-winsource.c
5886         (tui_source_window_base::show_exec_info_content): Rename from
5887         tui_show_exec_info_content.
5888         (tui_source_window_base::update_exec_info): Update.
5889
5890 2019-08-13  Tom Tromey  <tom@tromey.com>
5891
5892         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5893         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5894         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5895         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5896         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5897         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5898         ... here.
5899
5900 2019-08-13  Tom Tromey  <tom@tromey.com>
5901
5902         * tui/tui-winsource.h (struct tui_source_window_base)
5903         <update_exec_info>: Declare.
5904         (tui_update_exec_info): Don't declare.
5905         * tui/tui-winsource.c (tui_update_source_window_as_is)
5906         (tui_source_window_base::refresh_all)
5907         (tui_update_all_breakpoint_info): Update.
5908         (tui_source_window_base::update_exec_info): Rename from
5909         tui_update_exec_info.
5910         * tui/tui-stack.c (tui_show_frame_info): Update.
5911
5912 2019-08-13  Tom Tromey  <tom@tromey.com>
5913
5914         * tui/tui-winsource.h (struct tui_source_window_base)
5915         <set_exec_info_content>: Declare.
5916         (tui_set_exec_info_content): Don't declare.
5917         * tui/tui-winsource.c
5918         (tui_source_window_base::set_exec_info_content): Rename from
5919         tui_set_exec_info_content.
5920         (tui_update_exec_info): Update.
5921
5922 2019-08-13  Tom Tromey  <tom@tromey.com>
5923
5924         * tui/tui-winsource.h (struct tui_source_window_base)
5925         <show_source_content>: Declare.
5926         (tui_show_source_content): Don't declare.
5927         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5928         (tui_source_window_base::show_source_content): Rename from
5929         tui_show_source_content.
5930         (tui_source_window_base::refresh_all): Update.
5931         * tui/tui-layout.c (show_source_disasm_command)
5932         (show_source_or_disasm_and_command): Update.
5933
5934 2019-08-13  Tom Tromey  <tom@tromey.com>
5935
5936         * tui/tui-winsource.c (tui_erase_source_content)
5937         (tui_show_source_content, tui_source_window_base::refresh_all):
5938         Update.
5939         * tui/tui-wingeneral.h
5940         (tui_check_and_display_highlight_if_needed): Don't declare.
5941         * tui/tui-wingeneral.c
5942         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5943         check_and_display_highlight_if_needed.
5944         * tui/tui-win.c (tui_rehighlight_all)
5945         (tui_win_info::make_visible_with_new_height): Update.
5946         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5947         (tui_data_window::erase_data_content)
5948         (tui_data_window::display_all_data): Update.
5949         * tui/tui-data.h (struct tui_win_info)
5950         <check_and_display_highlight_if_needed>: Declare.
5951
5952 2019-08-13  Tom Tromey  <tom@tromey.com>
5953
5954         * tui/tui-win.c (tui_resize_all): Call
5955         tui_delete_invisible_windows.
5956         * tui/tui-layout.c (show_layout): Call
5957         tui_delete_invisible_windows.
5958         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5959         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5960
5961 2019-08-13  Tom Tromey  <tom@tromey.com>
5962
5963         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5964         tui_add_win_to_layout.
5965
5966 2019-08-13  Tom Tromey  <tom@tromey.com>
5967
5968         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5969         * tui/tui-layout.c (tui_default_win_height): Now static.
5970
5971 2019-08-13  Tom Tromey  <tom@tromey.com>
5972
5973         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5974         single switch.
5975         (show_source_disasm_command, show_source_or_disasm_and_command):
5976         Don't check current layout.
5977
5978 2019-08-13  Tom Tromey  <tom@tromey.com>
5979
5980         * tui/tui-wingeneral.c (make_all_visible): Remove.
5981         (tui_make_all_invisible): Simplify.
5982         * tui/tui-layout.c (tui_make_all_invisible): Move from
5983         tui-wingeneral.c; simplify.
5984         (show_layout): Hoist call to tui_make_all_invisible.
5985         (show_data): Don't call tui_make_all_invisible.
5986
5987 2019-08-13  Tom Tromey  <tom@tromey.com>
5988
5989         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5990         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5991
5992 2019-08-13  Tom Tromey  <tom@tromey.com>
5993
5994         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5995         tui-data.c.
5996         (show_source_disasm_command, show_data)
5997         (show_source_or_disasm_and_command): Don't use
5998         tui_set_current_layout_to.
5999         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
6000         * tui/tui-data.c (current_layout, tui_current_layout): Move to
6001         tui-layout.c.
6002         (tui_set_current_layout_to): Remove.
6003
6004 2019-08-13  Tom Tromey  <tom@tromey.com>
6005
6006         * tui/tui-layout.c (tui_set_layout): Update.
6007         * tui/tui-data.h (struct tui_layout_def): Remove.
6008         (tui_layout_def): Don't declare.
6009         * tui/tui-data.c (layout_def): Remove.
6010         (tui_layout_def): Remove.
6011
6012 2019-08-13  Tom Tromey  <tom@tromey.com>
6013
6014         * tui/tui-winsource.h (struct tui_source_window_base)
6015         <clear_detail>: No longer "override".
6016         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
6017         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
6018         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
6019         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
6020         Remove.
6021         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
6022
6023 2019-08-13  Tom Tromey  <tromey@adacore.com>
6024
6025         * tracepoint.c: Don't include readline.h or history.h.
6026
6027 2019-08-12  Tom Tromey  <tom@tromey.com>
6028
6029         * configure: Rebuild.
6030         * configure.ac: Check for readline 7.
6031         * NEWS: Mention readline 7 requirement.
6032         * README: Update.
6033
6034 2019-08-12  Tom Tromey  <tom@tromey.com>
6035
6036         * mingw-hdep.c (gdb_select): Remove readline hack.
6037
6038 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6039
6040         * blockframe.c (find_pc_partial_function): Set *block to nullptr
6041         when the function fails.
6042
6043 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
6044
6045         * s390-tdep.c (s390_type_align): New function.
6046         (s390_gdbarch_init): Set it as type_align gdbarch method.
6047
6048 2019-08-09  Tom de Vries  <tdevries@suse.de>
6049
6050         PR gdb/24591
6051         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
6052         pc_low with relocation offset.
6053
6054 2019-08-07  Tom Tromey  <tromey@adacore.com>
6055
6056         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6057         (print_frame_args): Update.
6058         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
6059         Update.
6060         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6061         * frame.h (struct frame_arg): Add initializers.
6062         <error>: Now a unique_xmalloc_ptr.
6063
6064 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
6065
6066         * NEWS: Expand the Pointer Authentication entry.
6067         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6068         (aarch64_frame_unmask_lr): ... to this.
6069         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6070         Call aarch64_frame_unmask_lr.
6071         * frame.c (struct frame_info): Add "masked" variable.
6072         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6073         (fprint_frame): Check for masked pc.
6074         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6075         declarations.
6076         * python/py-framefilter.c (py_print_frame): Check for masked pc.
6077         * stack.c (print_frame): Check for masked pc.
6078
6079 2019-08-06  Tom Tromey  <tom@tromey.com>
6080
6081         * stabsread.c (patch_block_stabs, read_one_struct_field)
6082         (read_enum_type): Use obstack_strndup.
6083         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6084         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6085         * dwarf2read.c (guess_full_die_structure_name)
6086         (anonymous_struct_prefix): Use obstack_strndup.
6087         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6088         * c-exp.y (yylex): Use obstack_strndup.
6089         * ada-exp.y (write_object_renaming, write_ambiguous_var)
6090         (write_var_or_type): Use obstack_strndup.
6091
6092 2019-08-06  Tom Tromey  <tom@tromey.com>
6093
6094         * symfile.c (reread_symbols): Use obstack_strdup.
6095         * stabsread.c (read_type): Use obstack_strdup.
6096         * gdb_obstack.h (obstack_strdup): New overload.
6097         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6098         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6099         (dwarf2_canonicalize_name): Use obstack_strdup.
6100         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6101         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6102         Use obstack_strdup.
6103
6104 2019-08-06  Tom Tromey  <tom@tromey.com>
6105
6106         * gdb_obstack.h (obstack_strdup): Define.
6107         * gdb_obstack.c (obstack_strdup): Don't define.
6108
6109 2019-08-06  Tom Tromey  <tom@tromey.com>
6110
6111         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6112         obstack_strdup.
6113         * typeprint.c (typedef_hash_table::find_global_typedef): Use
6114         obstack_strdup.
6115         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6116         * stabsread.c (common_block_start): Use obstack_strdup.
6117         * objfiles.c (set_objfile_main_name, objfile): Use
6118         obstack_strdup.
6119         * namespace.c (add_using_directive): Use obstack_strdup.
6120         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6121         * jit.c (finalize_symtab): Use obstack_strdup.
6122         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6123         (guess_partial_die_structure_name, partial_die_info::fixup)
6124         (dwarf2_name): Use obstack_strdup.
6125         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6126         obstack_strdup.
6127         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6128         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6129         obstack_strdup.
6130         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6131
6132 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6133
6134         * unittests/help-doc-selftests.c: New file.
6135         * Makefile.in: Add the new file.
6136
6137 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6138
6139         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6140         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
6141         the full first line, except when FOR_VALUE_PREFIX.  In this case,
6142         the trailing '.' is not output, and the first character is uppercased.
6143         (print_help_for_command): Update call to print_doc_line.
6144         (print_doc_of_command): Likewise.
6145         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6146         * cli/cli-option.c (append_indented_doc): Do not append newline.
6147         (build_help_option): Append newline after first appended_indented_doc
6148         only if a second call is done.
6149         (build_help): Append 2 new lines before each option, except the first
6150         one.
6151         * compile/compile.c (_initialize_compile): Add new lines after
6152         %OPTIONS%, when not at the end of the help.
6153         Change help doc or code
6154         producing the help doc to respect the invariants.
6155         * maint-test-options.c (_initialize_maint_test_options): Likewise.
6156         Also removed the new line after 'Options:', as all other commands
6157         do not put an empty line between 'Options:' and the first option.
6158         * printcmd.c (_initialize_printcmd): Likewise.
6159         * stack.c (_initialize_stack): Likewise.
6160         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6161         incorrectly telling COMMAND is optional.
6162         * ada-lang.c (_initialize_ada_language): Change help doc or code
6163         producing the help doc to respect the invariants.
6164         * ada-tasks.c (_initialize_ada_tasks): Likewise.
6165         * breakpoint.c (_initialize_breakpoint): Likewise.
6166         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6167         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6168         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6169         * cli/cli-style.c (cli_style_option::add_setshow_commands,
6170         _initialize_cli_style): Likewise.
6171         * corelow.c (core_target_info): Likewise.
6172         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6173         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6174         * filesystem.c (_initialize_filesystem): Likewise.
6175         * frame.c (_initialize_frame): Likewise.
6176         * gnu-nat.c (add_task_commands): Likewise.
6177         * infcall.c (_initialize_infcall): Likewise.
6178         * infcmd.c (_initialize_infcmd): Likewise.
6179         * interps.c (_initialize_interpreter): Likewise.
6180         * language.c (_initialize_language): Likewise.
6181         * linux-fork.c (_initialize_linux_fork): Likewise.
6182         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6183         * maint.c (_initialize_maint_cmds): Likewise.
6184         * memattr.c (_initialize_mem): Likewise.
6185         * printcmd.c (_initialize_printcmd): Likewise.
6186         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6187         _RegEx): Likewise.
6188         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6189         * record-btrace.c (_initialize_record_btrace): Likewise.
6190         * record-full.c (_initialize_record_full): Likewise.
6191         * record.c (_initialize_record): Likewise.
6192         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6193         * regcache.c (_initialize_regcache): Likewise.
6194         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6195         _initialize_remote): Likewise.
6196         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6197         * serial.c (_initialize_serial): Likewise.
6198         * skip.c (_initialize_step_skip): Likewise.
6199         * source.c (_initialize_source): Likewise.
6200         * stack.c (_initialize_stack): Likewise.
6201         * symfile.c (_initialize_symfile): Likewise.
6202         * symtab.c (_initialize_symtab): Likewise.
6203         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6204         * top.c (init_main): Likewise.
6205         * tracefile-tfile.c (tfile_target_info): Likewise.
6206         * tracepoint.c (_initialize_tracepoint): Likewise.
6207         * tui/tui-win.c (_initialize_tui_win): Likewise.
6208         * utils.c (add_internal_problem_command): Likewise.
6209         * valprint.c (value_print_option_defs): Likewise.
6210
6211 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6212
6213         PR build/24886
6214         * configure.ac: Drop enable-libmcheck support.
6215         * configure, config.in: Rebuild.
6216         * libmcheck.m4: Remove.
6217         * acinclude.m4: Don't include it.
6218         * Makefile.in: Don't distribute it.
6219         * top.c (print_gdb_configuration): Don't mention it.
6220
6221 2019-08-06  Tom Tromey  <tom@tromey.com>
6222
6223         * utils.c (set_output_style): Sometimes pass stream to
6224         emit_style_escape.
6225         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6226         * record-btrace.c (btrace_insn_history): Update.
6227         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6228         method.
6229         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6230         Update initializers.
6231         <m_uiout>: New field.
6232         <m_di>: Move lower.
6233         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6234         Remove "uiout" parameter.
6235         (dump_insns): Update.
6236         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6237         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6238
6239 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6240
6241         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6242         (error_in_psymtab_expansion): Likewise.
6243         (lookup_symbol_via_quick_fns): Likewise.
6244         (basic_lookup_transparent_type_quick): Likewise.
6245         (basic_lookup_transparent_type_1): Likewise.
6246
6247 2019-08-06  Tom Tromey  <tromey@adacore.com>
6248
6249         * source.c (last_source_error): Now bool.
6250         (print_source_lines_base): Make "noprint" bool.  Only open
6251         source file when last_source_visited changes.
6252
6253 2019-08-06  Tom Tromey  <tromey@adacore.com>
6254
6255         * annotate.c (annotate_source_line): Use g_source_cache.
6256         * source-cache.c (source_cache::get_plain_source_lines): Change
6257         parameters.  Populate m_offset_cache.
6258         (source_cache::ensure): New method.
6259         (source_cache::get_line_charpos): New method.
6260         (extract_lines): Move lower.  Change parameters.
6261         (source_cache::get_source_lines): Move lower.
6262         * source-cache.h (class source_cache): Update comment.
6263         <get_line_charpos>: New method.
6264         <get_source_lines>: Update comment.
6265         <clear>: Clear m_offset_cache.
6266         <get_plain_source_lines>: Change parameters.
6267         <ensure>: New method
6268         <m_offset_cache>: New member.
6269         * source.c (forget_cached_source_info_for_objfile): Update.
6270         (info_source_command): Use g_source_cache.
6271         (find_source_lines, open_source_file_with_line_charpos): Remove.
6272         (print_source_lines_base, search_command_helper): Use g_source_cache.
6273         * source.h (open_source_file_with_line_charpos): Don't declare.
6274         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6275         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6276         Use g_source_cache.
6277
6278 2019-08-06  Tom Tromey  <tromey@adacore.com>
6279
6280         * source-cache.c (source_cache::get_plain_source_lines):
6281         Remove "first_line" and "last_line" parameters.
6282         (source_cache::get_source_lines): Cache plain text.
6283         * source-cache.h (class source_cache)
6284         <get_plain_source_lines>: Update.
6285
6286 2019-08-06  Tom Tromey  <tromey@adacore.com>
6287
6288         * source-cache.c (extract_lines): No longer a method.
6289         Changed type of parameter.  Include final newline.
6290         (selftests::extract_lines_test): New function.
6291         (_initialize_source_cache): Likewise.
6292         * source-cache.h (class source_cache)
6293         <extract_lines>: Don't declare.
6294
6295 2019-08-06  Tom Tromey  <tromey@adacore.com>
6296
6297         * breakpoint.c (init_breakpoint_sal): Update.
6298         (breakpoint): Update.
6299         * breakpoint.h (struct breakpoint) <filter>: Now a
6300         unique_xmalloc_ptr.
6301
6302 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6303
6304         * NEWS: Mention dictionary access on blocks.
6305         * python/py-block.c (blpy_getitem): New function.
6306         (block_object_as_mapping): New struct.
6307         (block_object_type): Use new struct for tp_as_mapping field.
6308
6309 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6310
6311         * objfiles.h (objfile): Add a comment describing partial symbols.
6312
6313 2019-08-05  Tom Tromey  <tromey@adacore.com>
6314
6315         * compile/compile.c (_initialize_compile): Use _(), not N_().
6316         * thread.c (_initialize_thread): Use _(), not N_().
6317         * stack.c (_initialize_stack): Use _(), not N_().
6318         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6319
6320 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6321
6322         * dwarf2read.c (struct dw2_symtab_iterator):
6323         <want_specific_block>: Remove.
6324         <block_index>: Change type to gdb::optional.
6325         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6326         change type of BLOCK_INDEX parameter to gdb::optional.
6327         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6328         (dw2_lookup_symbol): Don't pass argument for
6329         WANT_SPECIFIC_BLOCK.
6330         (dw2_expand_symtabs_for_function): Don't pass argument for
6331         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6332         (class dw2_debug_names_iterator)
6333         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6334         parameter, change BLOCK_INDEX type to gdb::optional.
6335         <m_want_specific_block>: Remove.
6336         <m_block_index>: Change type to gdb::optional.
6337         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6338         gdb::optional.  Re-write in function of gdb::optional.
6339         (dw2_debug_names_lookup_symbol): Don't pass argument for
6340         WANT_SPECIFIC_BLOCK.
6341         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6342         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6343         BLOCK_INDEX.
6344
6345 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6346
6347         * NEWS: Mention changes to "info sources" command.
6348
6349 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6350
6351         * symtab.c (filename_partial_match_opts): New struct type.
6352         (struct output_source_filename_data): New members
6353         regexp, c_regexp, partial_match.
6354         (output_source_filename): Use new members to decide to print file.
6355         (info_sources_option_defs): New variable.
6356         (make_info_sources_options_def_group, print_info_sources_header,
6357         info_sources_command_completer):
6358         New functions.
6359         (info_sources_command): Read new optional arguments.
6360         (_initialize_symtab): Update info sources help.
6361
6362 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6363
6364         * ada-lang.c (exception_support_info_v0): Renamed from...
6365         (default_exception_support_info): ... this.  Create new
6366         definition for v1.
6367         (ada_has_this_exception_support): Look up catch_handlers_sym.
6368         (ada_exception_support_info_sniffer): Try v0 after default.
6369
6370 2019-08-01  Tom Tromey  <tromey@adacore.com>
6371
6372         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6373         gdbarch.h.
6374
6375 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6376
6377         * s12z-tdep.c: Fix include path for s12z-opc.h.
6378
6379 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6380
6381         * NEWS: Require GNU make 3.82.
6382
6383 2019-07-16  Tom Tromey  <tom@tromey.com>
6384
6385         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6386         declare.
6387
6388 2019-07-30  Tom Tromey  <tromey@adacore.com>
6389
6390         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6391
6392 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6393
6394         * printcmd.c (print_address_symbolic): Print negative offsets.
6395         (build_address_symbolic): Force signed arithmetic when computing
6396         offset.
6397
6398 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6399
6400         PR/24474: Add a function to lookup static variables.
6401         * NEWS: Mention this new function.
6402         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6403         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6404         * python/python.c (python_GdbMethods): Add new function.
6405
6406 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6407
6408         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6409         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6410         (objfpy_lookup_static_symbol): New function.
6411         (objfile_object_methods): Add new functions.
6412
6413 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6414
6415         * NEWS: Mention 'set|show print frame-info'.  Mention new
6416         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6417         backtrace argument.  Mention that python frame filtering code
6418         is now consistent with what 'backtrace' command prints.
6419
6420 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6421
6422         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6423         comments.
6424         (print_frame_info_auto, print_frame_info_source_line,
6425         print_frame_info_location, print_frame_info_source_and_location,
6426         print_frame_info_location_and_address, print_frame_info_short_location):
6427         New declarations.
6428         (struct frame_print_options): New member print_frame_info.
6429         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6430         * stack.h (get_user_print_what_frame_info): New declaration.
6431         (frame_show_address): New declaration.
6432         * stack.c (print_frame_arguments_choices): New value 'presence'.
6433         (print_frame_info_auto, print_frame_info_source_line,
6434         print_frame_info_location, print_frame_info_source_and_location,
6435         print_frame_info_location_and_address, print_frame_info_short_location,
6436         print_frame_info_choices, print_frame_info_print_what): New definitions.
6437         (print_frame_args): Only print dots for args if print frame-arguments
6438         is 'presence'.
6439         (frame_print_option_defs): New element for "frame-info".
6440         (get_user_print_what_frame_info): New function.
6441         (frame_show_address): Make non static.  Move comment to stack.h.
6442         (print_frame_info_to_print_what): New function.
6443         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6444         to decide what to print.
6445         (backtrace_command_1): Handle the new print_frame_arguments_presence
6446         value.
6447         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6448         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6449         (py_print_frame): In non-mi mode, use LOCATION as default for
6450         print_what, similarly to frame information printed directly by
6451         backtrace command. Handle frame-info user option in non MI mode.
6452
6453 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6454
6455         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6456         Add case for debugging 32-bit target on 64-bit host.  Revise
6457         comment.
6458
6459 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6460
6461         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6462         instead of find_function_entry_range_from_pc.
6463
6464 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6465
6466         * stack.c (find_frame_funname): Remove code which preferred
6467         minsym over symtab sym in "certain pathological cases".
6468
6469         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6470         parameter.  Change type of "do_demangle" to bool.
6471         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6472         Pass suitable "prefer_sym_over_minsym" flag to
6473         build_address_symbolic().  Don't output "+" for negative offsets.
6474         * printcmd.c (print_address_symbolic): Update invocation of
6475         build_address_symbolic to include a "prefer_sym_over_minsym"
6476         flag.
6477         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6478         Restrict cases in which use of minimal symbol is preferred to that
6479         of a found symbol.  Update comments.
6480
6481         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6482         for entry pc when entry pc is out of range for that FDE.
6483
6484 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6485
6486         PR gdb/24839:
6487         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6488         type.
6489
6490 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6491
6492         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6493         this function's Python signature.
6494
6495
6496 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6497
6498         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6499         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6500         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6501         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6502         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6503
6504
6505 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6506
6507         * h8300-tdep.c (h8300_register_name_common): New.
6508         h8300_register_name): Use h8300_register_name_common.
6509         (h8300s_register_name): Likewise.
6510         (h8300sx_register_name): Likewise.
6511         (h8300h_register_nam): New.
6512         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6513
6514
6515 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6516
6517         * arm-tdep.c (arm_skip_cmse_entry): New function.
6518         (arm_is_sgstubs_section): New function.
6519         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6520
6521 2019-07-22  Tom Tromey  <tom@tromey.com>
6522
6523         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6524         Don't self-assign.
6525
6526 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6527
6528         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6529         type_print.
6530
6531 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6532
6533         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6534         so that GDB doesn't match any msymbols when searching in the
6535         TYPES_DOMAIN.
6536         (print_symbol_info): Print using typedef_print or type_print based
6537         on the type of the symbol.  Add updated FIXME comment moved from...
6538         (_initialize_symtab): ... move and update FIXME comment to above.
6539
6540 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6541
6542         * NEWS: Mention adding -q option to "info types".
6543         * symtab.c (struct info_types_options): New struct.
6544         (info_types_options_defs): New variable.
6545         (make_info_types_options_def_group): New function.
6546         (info_types_command): Use gdb::option framework to parse options.
6547         (info_types_command_completer): New function.
6548         (_initialize_symtab): Extend the help text on "info types" and
6549         register command completer.
6550
6551 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6552
6553         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6554         (lookup_symbol_in_objfile): Change int to block_enum and add a
6555         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6556
6557 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6558
6559         * MAINTAINERS (Write After Approval): Add self.
6560
6561 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6562
6563         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6564         instruction to the dummy code region.
6565
6566 2019-07-19  Tom Tromey  <tromey@adacore.com>
6567
6568         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6569         (ARGSUSED, PARAMS, __func__): Remove rules.
6570
6571 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6572
6573         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6574         * features/arm/arm-with-iwmmxt.c: Remove.
6575         * features/arm/arm-with-iwmmxt.xml: Remove.
6576         * features/arm/arm-with-m-fpa-layout.c: Remove.
6577         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6578         * features/arm/arm-with-m-vfp-d16.c: Remove.
6579         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6580         * features/arm/arm-with-m.c: Remove.
6581         * features/arm/arm-with-m.xml: Remove.
6582         * features/arm/arm-with-neon.c: Remove.
6583         * features/arm/arm-with-neon.xml: Remove.
6584         * features/arm/arm-with-vfpv2.c: Remove.
6585         * features/arm/arm-with-vfpv2.xml: Remove.
6586         * features/arm/arm-with-vfpv3.c: Remove.
6587         * features/arm/arm-with-vfpv3.xml: Remove.
6588
6589 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6590
6591         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6592
6593 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6594
6595         * arch/aarch32.c (aarch32_create_target_description): Create
6596         target descriptions using features.
6597         * arch/arm.c (arm_create_target_description)
6598         (arm_create_mprofile_target_description): Likewise.
6599         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6600
6601 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6602
6603         * Makefile.in: Add new files.
6604         * aarch32-tdep.c: New file.
6605         * aarch32-tdep.h: New file.
6606         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6607         Call aarch32_read_description.
6608         * arch/aarch32.c: New file.
6609         * arch/aarch32.h: New file.
6610         * arch/arm.c (arm_create_target_description)
6611         (arm_create_mprofile_target_description): New function.
6612         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6613         (arm_create_target_description)
6614         (arm_create_mprofile_target_description): New declaration.
6615         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6616         read_description functions.
6617         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6618         Likewise.
6619         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6620         * arm-tdep.c (tdesc_arm_list): New variable.
6621         (arm_register_g_packet_guesses): Call create description functions.
6622         (arm_read_description) (arm_read_mprofile_description): New
6623         function.
6624         * arm-tdep.h (arm_read_description)
6625         (arm_read_mprofile_description): Add declaration.
6626         * configure.tgt: Add new files.
6627
6628 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6629
6630         * top.c (new_ui_command): Open specified terminal just once.
6631
6632 2019-07-18  Tom Tromey  <tromey@adacore.com>
6633
6634         * symtab.c (main_name): Constify return type.
6635         * symfile.c (set_initial_language): Update.
6636         * symtab.h (main_name): Constify return type.
6637
6638 2019-07-17  Tom Tromey  <tom@tromey.com>
6639
6640         * tui/tui-winsource.c (tui_update_source_window)
6641         (tui_update_source_window_as_is)
6642         (tui_update_source_windows_with_line): Remove return.
6643         * tui/tui-disasm.c (tui_show_disassem)
6644         (tui_show_disassem_and_update_source): Remove return.
6645         * tui/tui.c (tui_reset): Remove return.
6646         * tui/tui-wingeneral.c
6647         (tui_check_and_display_highlight_if_needed): Remove return.
6648
6649 2019-07-17  Tom Tromey  <tom@tromey.com>
6650
6651         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6652
6653 2019-07-17  Tom Tromey  <tom@tromey.com>
6654
6655         * tui/tui-winsource.h (struct tui_exec_info_window)
6656         (struct tui_source_window_base): Move from tui-data.h.
6657         * tui/tui-winsource.c: Move many method definitions from
6658         elsewhere.  Remove "structuring" comments.
6659         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6660         (tui_source_window_base::refresh_window): Move to
6661         tui-winsource.c.
6662         * tui/tui-win.c (tui_source_window_base::refresh_all)
6663         (tui_source_window_base::update_tab_width)
6664         (tui_source_window_base::set_new_height)
6665         (tui_source_window_base::do_make_visible_with_new_height): Move to
6666         tui-winsource.c.
6667         * tui/tui-source.h: Update.
6668         * tui/tui-source.c (tui_source_window_base::reset): Move to
6669         tui-winsource.c.
6670         * tui/tui-disasm.h: Update.
6671         * tui/tui-data.h (struct tui_exec_info_window): Move to
6672         tui-winsource.h.
6673         (struct tui_source_window_base): Likewise.
6674         * tui/tui-data.c (tui_source_window_base::clear_detail)
6675         (tui_source_window_base, ~tui_source_window_base): Move to
6676         tui-winsource.c.
6677
6678 2019-07-17  Tom Tromey  <tom@tromey.com>
6679
6680         * tui/tui-win.c (tui_resize_all)
6681         (tui_source_window_base::update_tab_width)
6682         (tui_adjust_win_heights): Update.
6683         (tui_win_info::make_invisible_and_set_new_height): Rename from
6684         make_invisible_and_set_new_height.
6685         * tui/tui-data.h (struct tui_win_info)
6686         <make_invisible_and_set_new_height>: New method.
6687
6688 2019-07-17  Tom Tromey  <tom@tromey.com>
6689
6690         * tui/tui.c: Update.
6691         * tui/tui-source.h (struct tui_source_window): Move from
6692         tui-data.h.
6693         * tui/tui-layout.c: Update.
6694         * tui/tui-disasm.c: Update.
6695         * tui/tui-data.h (struct tui_source_window): Move to
6696         tui-source.h.
6697
6698 2019-07-17  Tom Tromey  <tom@tromey.com>
6699
6700         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6701         tui-data.h.
6702         * tui/tui-data.h (struct tui_disasm_window): Move to
6703         tui-disasm.h.
6704
6705 2019-07-17  Tom Tromey  <tom@tromey.com>
6706
6707         * tui/tui-regs.h (struct tui_data_item_window): Move from
6708         tui-data.h.
6709         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6710         * tui/tui-data.h (struct tui_data_item_window): Move to
6711         tui-regs.h.
6712         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6713
6714 2019-07-17  Tom Tromey  <tom@tromey.com>
6715
6716         * tui/tui.c: Update.
6717         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6718         (tui_cmd_window::max_height): Move to tui-command.c.
6719         * tui/tui-layout.c: Update.
6720         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6721         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6722         tui-command.c.
6723         * tui/tui-command.h (struct tui_cmd_window): Move from
6724         tui-data.h.
6725         * tui/tui-command.c: Remove "structuring" comments.
6726         (tui_cmd_window::clear_detail)
6727         (tui_cmd_window::do_make_visible_with_new_height)
6728         (tui_cmd_window::max_height): Move from elsewhere.
6729
6730 2019-07-17  Tom Tromey  <tom@tromey.com>
6731
6732         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6733         Now static.
6734         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6735         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6736
6737 2019-07-17  Tom Tromey  <tom@tromey.com>
6738
6739         * tui/tui.c: Update.
6740         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6741         tui-regs.c.
6742         * tui/tui-windata.h: Remove file.
6743         * tui/tui-windata.c: Remove file.
6744         * tui/tui-win.c (tui_data_window::set_new_height)
6745         (tui_data_window::do_make_visible_with_new_height): Move to
6746         tui-regs.c.
6747         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6748         * tui/tui-regs.c: Remove "structuring" comments.
6749         (tui_data_window::first_data_item_displayed)
6750         (tui_data_window::delete_data_content_windows)
6751         (tui_data_window::erase_data_content)
6752         (tui_data_window::display_all_data)
6753         (tui_data_window::refresh_all)
6754         (tui_data_window::do_scroll_vertical)
6755         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6756         (tui_data_window::do_make_visible_with_new_height)
6757         (tui_data_window::refresh_window): Move from elsewhere.
6758         (_initialize_tui_regs): Move to end of file.
6759         * tui/tui-layout.c: Update.
6760         * tui/tui-hooks.c: Update.
6761         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6762         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6763         tui-regs.c.
6764         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6765
6766 2019-07-17  Tom Tromey  <tom@tromey.com>
6767
6768         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6769         seen.
6770
6771 2019-07-17  Tom Tromey  <tom@tromey.com>
6772
6773         * tui/tui-win.c (tui_source_window_base::set_new_height)
6774         (tui_source_window_base::do_make_visible_with_new_height): Use
6775         m_has_locator field directly.
6776         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6777         method.
6778         (struct tui_source_window_base) <has_locator>: Likewise.
6779
6780 2019-07-17  Tom Tromey  <tom@tromey.com>
6781
6782         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6783         Don't declare.
6784         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6785         Remove.
6786         * tui/tui-win.c (tui_source_window_base::set_new_height)
6787         (tui_source_window_base::set_new_height)
6788         (make_invisible_and_set_new_height)
6789         (tui_source_window_base::do_make_visible_with_new_height)
6790         (tui_source_window_base::do_make_visible_with_new_height):
6791         Update.
6792         * tui/tui-layout.c (show_source_disasm_command, show_data)
6793         (show_source_or_disasm_and_command): Update.
6794         * tui/tui-layout.c (show_layout): Update.
6795
6796 2019-07-17  Tom Tromey  <tom@tromey.com>
6797
6798         * tui/tui-layout.c (make_data_window): Remove.
6799         (show_data): Unify creation and re-initialization cases.
6800
6801 2019-07-17  Tom Tromey  <tom@tromey.com>
6802
6803         * tui/tui-layout.c (make_source_window, make_disasm_window):
6804         Remove.
6805         (show_data): Unify creation and re-initialization cases.
6806
6807 2019-07-17  Tom Tromey  <tom@tromey.com>
6808
6809         * tui/tui-layout.c (make_command_window): Remove.
6810         (show_source_disasm_command, show_source_or_disasm_and_command):
6811         Unify creation and re-initialization cases.
6812
6813 2019-07-17  Tom Tromey  <tom@tromey.com>
6814
6815         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6816         creation and re-initialization cases.
6817
6818 2019-07-17  Tom Tromey  <tom@tromey.com>
6819
6820         * tui/tui-regs.c (tui_get_register): Return void.
6821
6822 2019-07-17  Tom Tromey  <tom@tromey.com>
6823
6824         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6825         Simplify.
6826
6827 2019-07-17  Tom Tromey  <tom@tromey.com>
6828
6829         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6830         resetting.
6831
6832 2019-07-17  Tom Tromey  <tom@tromey.com>
6833
6834         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6835         * tui/tui-regs.c (tui_reg_layout): New function.
6836         (tui_show_registers, tui_reg_command): Use it.
6837         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6838         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6839         parameters.
6840         (tui_layout_command): Remove.
6841
6842 2019-07-17  Tom Tromey  <tom@tromey.com>
6843
6844         * tui/tui-layout.h (tui/tui-layout): Return void.
6845         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6846
6847 2019-07-17  Tom Tromey  <tom@tromey.com>
6848
6849         * tui/tui-layout.c (show_source_disasm_command, show_data):
6850         Update.
6851         (reset_locator): Remove.
6852         (show_source_or_disasm_and_command): Update.
6853
6854 2019-07-17  Tom Tromey  <tom@tromey.com>
6855
6856         * tui/tui-source.c (tui_source_window_base::reset): Remove
6857         win_type parameter.
6858         * tui/tui-layout.c (make_command_window, make_source_window)
6859         (make_disasm_window, make_data_window)
6860         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6861         (reset_locator, show_source_or_disasm_and_command): Update.
6862         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6863         win_type parameter.
6864         (struct tui_source_window_base) <reset>: Likewise.
6865
6866 2019-07-17  Tom Tromey  <tom@tromey.com>
6867
6868         * tui/tui-layout.c (show_source_disasm_command): Use
6869         reset_locator.
6870         (reset_locator): New function.
6871         (init_and_make_win): Remove.
6872         (show_source_or_disasm_and_command): Use reset_locator.
6873
6874 2019-07-17  Tom Tromey  <tom@tromey.com>
6875
6876         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6877         condition.
6878         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6879         Remove condition.
6880         * tui/tui-source.c (tui_source_window_base::reset): New method.
6881         * tui/tui-layout.c (make_command_window): Don't call
6882         init_and_make_win.
6883         (make_source_window, make_disasm_window): Don't call
6884         make_source_or_disasm_window.
6885         (make_data_window): Don't call init_and_make_win.  Change calling
6886         convention.
6887         (show_source_disasm_command, show_data): Simplify.
6888         (make_source_or_disasm_window): Remove.
6889         (show_source_or_disasm_and_command): Simplify.
6890         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6891         (struct tui_source_window_base) <reset>: Likewise.
6892         <execution_info>: Remove initializer.
6893         * tui/tui-data.c (tui_source_window_base): Initialize
6894         execution_info.
6895
6896 2019-07-17  Tom Tromey  <tom@tromey.com>
6897
6898         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6899         variable.
6900
6901 2019-07-17  Tom Tromey  <tom@tromey.com>
6902
6903         * tui/tui.c (tui_rl_other_window): Update.
6904         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6905         superclass method first.  Always iterate over regs_content.
6906         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6907         method.
6908         * tui/tui-win.c (tui_set_focus_command): Update.
6909
6910 2019-07-17  Tom Tromey  <tom@tromey.com>
6911
6912         * tui/tui-win.c (tui_set_focus_command): Rename from
6913         tui_set_focus.  Call tui_enable.
6914         (tui_set_focus_command): Remove.
6915
6916 2019-07-17  Tom Tromey  <tom@tromey.com>
6917
6918         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6919         refresh_window.
6920         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6921         touchwin.
6922         (tui_data_window::refresh_window): Call refresh_window on data
6923         items.  Always call superclass refresh_window.
6924         (tui_win_info::refresh): Remove.
6925         (tui_source_window_base::refresh_window): Update.
6926         (tui_refresh_all): Update.
6927         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6928         refresh_window.
6929         (show_source_or_disasm_and_command): Likewise.
6930         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6931         (struct tui_source_window_base) <refresh>: Likewise.
6932
6933 2019-07-17  Tom Tromey  <tom@tromey.com>
6934
6935         * tui/tui-winsource.c (tui_clear_source_content)
6936         (tui_show_source_content): Update.
6937         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6938         whether content is empty.
6939         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6940         Remove.
6941
6942 2019-07-17  Tom Tromey  <tom@tromey.com>
6943
6944         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6945         window's contents.
6946         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6947         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6948
6949 2019-07-17  Tom Tromey  <tom@tromey.com>
6950
6951         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6952         (struct tui_data_item_window): Update.
6953
6954 2019-07-17  Tom Tromey  <tom@tromey.com>
6955
6956         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6957         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6958         defines.
6959
6960 2019-07-17  Tom Tromey  <tom@tromey.com>
6961
6962         * tui/tui-winsource.h (tui_erase_source_content)
6963         (tui_clear_source_content): Remove "display_prompt" parameter.
6964         * tui/tui-winsource.c (tui_update_source_window_as_is)
6965         (tui_update_source_windows_with_addr): Update.
6966         (tui_clear_source_content): Remove "display_prompt" parameter.
6967         (tui_erase_source_content): Likewise.  Simplify.
6968         (tui_show_source_content): Update.
6969         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6970         * tui/tui-stack.c (tui_show_frame_info): Update.
6971         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6972         Remove defines.
6973
6974 2019-07-17  Tom Tromey  <tom@tromey.com>
6975
6976         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6977         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6978         parameter.
6979         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6980         parameter.
6981
6982 2019-07-17  Tom Tromey  <tom@tromey.com>
6983
6984         * tui/tui-winsource.c (tui_clear_source_content)
6985         (tui_show_source_content, tui_show_exec_info_content)
6986         (tui_clear_exec_info_content): Update.
6987         * tui/tui-stack.c (tui_show_locator_content): Update.
6988         (tui_show_frame_info): Update.
6989         * tui/tui-source.h (tui_source_window): Don't declare.
6990         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6991         from tui_source_is_displayed.
6992         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6993         Remove field.
6994         (struct tui_source_window_base) <content_in_use>: New field.  Now
6995         bool.
6996         (struct tui_source_window) <showing_source_p>: New method.
6997         (TUI_SRC_WIN): Change cast.
6998         * tui/tui-data.c (tui_initialize_static_data): Update.
6999
7000 2019-07-17  Tom Tromey  <tom@tromey.com>
7001
7002         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
7003         location_matches_p.
7004         * tui/tui-source.c (tui_source_window::location_matches_p): New
7005         method.
7006         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
7007         method.
7008         * tui/tui-data.h (struct tui_source_window_base)
7009         <location_matches_p>: New method.
7010         (struct tui_source_window, struct tui_disasm_window)
7011         <location_matches_p>: Likewise.
7012
7013 2019-07-17  Tom Tromey  <tom@tromey.com>
7014
7015         * tui/tui-win.c (tui_set_win_height_command): Rename from
7016         tui_set_win_height.
7017         (tui_set_win_height_command): Remove.
7018
7019 2019-07-17  Tom Tromey  <tom@tromey.com>
7020
7021         * tui/tui-source.c (tui_source_window): New constructor.  Add
7022         observer.
7023         (~tui_source_window): New destructor.
7024         (tui_source_window::style_changed): New method.
7025         * tui/tui-hooks.c (tui_redisplay_source): Remove.
7026         (tui_attach_detach_observers): Update.
7027         * tui/tui-data.h (struct tui_source_window): Make constructor not
7028         inline.  Add destructor.
7029         (struct tui_source_window) <style_changed>: New method.
7030         <m_observable>: New member.
7031
7032 2019-07-17  Tom Tromey  <tom@tromey.com>
7033
7034         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
7035         * tui/tui-win.c (tui_resize_all): Fix typo.
7036
7037 2019-07-17  Tom Tromey  <tom@tromey.com>
7038
7039         * tui/tui-wingeneral.h (tui_refresh_all): Update.
7040         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
7041         (tui_refresh_all): Remove "list" parameter.  Use foreach.
7042         * tui/tui-win.c (window_name_completer): Use foreach.
7043         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
7044         (update_tab_width): Likewise.
7045         * tui/tui-layout.c (show_layout): Update.
7046         * tui/tui-data.h (class tui_window_iterator): New.
7047         (struct all_tui_windows): New.
7048         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
7049
7050 2019-07-17  Tom Tromey  <tom@tromey.com>
7051
7052         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
7053         parameter.  Don't reference globals.
7054         (tui_reg_command): Update.
7055
7056 2019-07-17  Tom Tromey  <tom@tromey.com>
7057
7058         * tui/tui-regs.c (tui_show_registers): Simplify.
7059
7060 2019-07-17  Tom Tromey  <tom@tromey.com>
7061
7062         * tui/tui-regs.c (tui_show_registers): Update.
7063         (tui_show_register_group): Add win_info parameter.
7064
7065 2019-07-17  Tom Tromey  <tom@tromey.com>
7066
7067         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7068         Rename from tui_display_reg_element_at_line.
7069         (tui_data_window::display_registers_from_line): Update.
7070         * tui/tui-data.h (struct tui_data_window)
7071         <display_reg_element_at_line>: New method.
7072
7073 2019-07-17  Tom Tromey  <tom@tromey.com>
7074
7075         * tui/tui-regs.h (tui_display_registers_from)
7076         (tui_display_registers_from_line): Don't declare.
7077         * tui/tui-windata.c (tui_data_window::display_all_data)
7078         (tui_data_window::refresh_all)
7079         (tui_data_window::do_scroll_vertical): Update.
7080         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7081         from tui_display_registers_from.
7082         (tui_display_reg_element_at_line): Update.
7083         (tui_data_window::display_registers_from_line): Rename from
7084         tui_display_registers_from_line.
7085         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7086         display_registers_from_line>: New methods.
7087
7088 2019-07-17  Tom Tromey  <tom@tromey.com>
7089
7090         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7091         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7092         from tui_erase_data_content.
7093         (tui_data_window::display_all_data)
7094         (tui_data_window::refresh_all)
7095         (tui_data_window::do_scroll_vertical): Update.
7096         * tui/tui-regs.c (tui_show_registers): Update.
7097         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7098         New method.
7099
7100 2019-07-17  Tom Tromey  <tom@tromey.com>
7101
7102         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7103         declare.
7104         * tui/tui-windata.c
7105         (tui_data_window::delete_data_content_windows): Rename from
7106         tui_delete_data_content_windows.
7107         (tui_data_window::display_all_data)
7108         (tui_data_window::do_scroll_vertical): Update.
7109         * tui/tui-data.h (struct tui_data_window)
7110         <delete_data_content_windows>: New method.
7111
7112 2019-07-17  Tom Tromey  <tom@tromey.com>
7113
7114         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7115         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7116
7117 2019-07-17  Tom Tromey  <tom@tromey.com>
7118
7119         * tui/tui-windata.h (tui_display_all_data): Don't declare.
7120         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7121         from tui_display_all_data.
7122         * tui/tui-win.c
7123         (tui_data_window::do_make_visible_with_new_height): Update.
7124         * tui/tui-regs.c (tui_show_registers): Update.
7125         * tui/tui-layout.c (tui_set_layout): Update.
7126         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7127         method.
7128
7129 2019-07-17  Tom Tromey  <tom@tromey.com>
7130
7131         * tui/tui-windata.h (tui_display_data_from): Don't declare.
7132         * tui/tui-windata.c (tui_display_data_from): Remove.
7133         (tui_data_window::refresh_all): Update.
7134
7135 2019-07-17  Tom Tromey  <tom@tromey.com>
7136
7137         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7138         * tui/tui-windata.c (tui_display_data_from_line): Remove.
7139         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7140         tui_display_registers_from_line.
7141         * tui/tui-regs.h (tui_display_registers_from_line): Update.
7142         * tui/tui-regs.c (tui_display_registers_from_line): Remove
7143         "force_display" parameter.
7144
7145 2019-07-17  Tom Tromey  <tom@tromey.com>
7146
7147         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7148         declare.
7149         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7150         Rename from tui_first_reg_element_no_inline.
7151         (tui_display_reg_element_at_line)
7152         (tui_display_registers_from_line): Update.
7153         * tui/tui-data.h (struct tui_data_window)
7154         <first_reg_element_no_inline>: New method.
7155
7156 2019-07-17  Tom Tromey  <tom@tromey.com>
7157
7158         * tui/tui-windata.c (tui_display_data_from)
7159         (tui_data_window::do_scroll_vertical): Update.
7160         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7161         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7162         Rename from tui_line_from_reg_element_no.
7163         (tui_display_registers_from_line): Update.
7164         * tui/tui-data.h (struct tui_data_window)
7165         <line_from_reg_element_no>: New method.
7166
7167 2019-07-17  Tom Tromey  <tom@tromey.com>
7168
7169         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7170         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7171         tui_last_regs_line_no.
7172         (tui_display_reg_element_at_line)
7173         (tui_display_registers_from_line): Update.
7174         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7175         method.
7176
7177 2019-07-17  Tom Tromey  <tom@tromey.com>
7178
7179         PR tui/24722:
7180         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7181         (tui_update_breakpoint_info): Add "being_deleted" parameter.
7182         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7183         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7184         (tui_update_breakpoint_info): Likewise.
7185         * tui/tui-hooks.c (tui_event_create_breakpoint)
7186         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7187         Update.
7188
7189 2019-07-17  Tom Tromey  <tom@tromey.com>
7190
7191         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7192
7193 2019-07-17  Tom Tromey  <tom@tromey.com>
7194
7195         * tui/tui-winsource.c (tui_update_source_window_as_is)
7196         (tui_update_source_windows_with_addr): Update.
7197         * tui/tui-source.h (tui_set_source_content)
7198         (tui_show_symtab_source): Add "win_info" parameter.
7199         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7200         parameter.
7201         (tui_show_symtab_source): Likewise.
7202
7203 2019-07-17  Tom Tromey  <tom@tromey.com>
7204
7205         * tui/tui-wingeneral.c
7206         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7207
7208 2019-07-17  Tom Tromey  <tom@tromey.com>
7209
7210         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7211         (struct tui_cmd_window) <can_scroll>: New method.
7212         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7213         method.
7214
7215 2019-07-17  Tom Tromey  <tromey@adacore.com>
7216
7217         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7218         do_field_signed>: Rename.  Change type of "value".
7219         * ui-out.c (ui_out::field_signed): Rename from field_int.
7220         Change type of "value".
7221         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7222         type of "value".
7223         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7224         do_field_int.  Change type of "value".
7225         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7226         do_field_int.  Change type of "value".
7227         * tracepoint.c (trace_status_mi, tfind_1)
7228         (print_one_static_tracepoint_marker): Update.
7229         * thread.c (print_thread_info_1, print_selected_thread_frame):
7230         Update.
7231         * stack.c (print_frame, print_frame_info): Update.
7232         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7233         Update.
7234         * source.c (print_source_lines_base): Update.
7235         * skip.c (info_skip_command): Update.
7236         * record-btrace.c (btrace_ui_out_decode_error)
7237         (btrace_call_history_src_line): Update.
7238         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7239         Update.
7240         * progspace.c (print_program_space): Update.
7241         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7242         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7243         do_field_int.  Change type of "value".
7244         * mi/mi-out.c (mi_ui_out::do_table_begin)
7245         (mi_ui_out::do_table_header): Update.
7246         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7247         type of "value".
7248         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7249         (mi_cmd_data_list_changed_registers, output_register)
7250         (mi_cmd_data_read_memory, mi_load_progress)
7251         (mi_cmd_trace_frame_collected): Update.
7252         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7253         Update.
7254         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7255         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7256         (mi_cmd_var_list_children, varobj_update_one): Update.
7257         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7258         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7259         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7260         * inferior.c (print_inferior): Update.
7261         * gdb_bfd.c (print_one_bfd): Update.
7262         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7263         Update.
7264         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7265         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7266         do_field_int.  Change type of "value".
7267         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7268         do_field_int.  Change type of "value".
7269         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7270         (print_one_breakpoint_location, print_it_catch_fork)
7271         (print_one_catch_fork, print_it_catch_vfork)
7272         (print_one_catch_vfork, print_it_catch_solib)
7273         (print_it_catch_exec, print_it_ranged_breakpoint)
7274         (print_mention_watchpoint, print_mention_masked_watchpoint)
7275         (bkpt_print_it, update_static_tracepoint): Update.
7276         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7277         * break-catch-syscall.c (print_it_catch_syscall): Update.
7278         * ada-tasks.c (print_ada_task_info): Update.
7279         * ada-lang.c (print_it_exception, print_mention_exception):
7280         Update.
7281
7282 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7283
7284         PR breakpoints/24541
7285         * gdbarch.c: Regenerate.
7286         * gdbarch.h: Regenerate.
7287         * gdbarch.sh: Adjust return type and parameter types for
7288         'stap_adjust_register'.
7289         (i386_stap_adjust_register): Adjust signature and return new
7290         register name.
7291         * stap-probe.c (stap_parse_register_operand): Adjust use of
7292         'gdbarch_stap_adjust_register'.
7293
7294 2019-07-17  Tom Tromey  <tromey@adacore.com>
7295
7296         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7297         declare VEC.
7298         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7299         std::vector.
7300         (struct s390_process_info): Add initializers.
7301         (s390_add_process): Use new.
7302         (s390_linux_nat_target::low_forget_process): Use delete.
7303         (s390_linux_nat_target::low_new_fork)
7304         (s390_linux_nat_target::stopped_by_watchpoint)
7305         (s390_linux_nat_target::low_prepare_to_resume)
7306         (s390_linux_nat_target::insert_watchpoint)
7307         (s390_linux_nat_target::insert_hw_breakpoint)
7308         (s390_linux_nat_target::remove_watchpoint)
7309         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7310
7311 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7312
7313         * aarch64-fbsd-nat.c: Include regcache.h.
7314         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7315         argument.
7316         (aarch64_fbsd_nat_target::fetch_registers)
7317         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7318         variable.
7319         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7320
7321 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7322
7323         * fbsd-nat.c: Include gdbarch.h.
7324
7325 2019-07-15  Tom Tromey  <tromey@adacore.com>
7326
7327         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7328
7329 2019-07-15  Tom Tromey  <tromey@adacore.com>
7330
7331         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7332         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7333         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7334         * cli-out.c (cli_ui_out::do_field_int): New method.
7335         * ui-out.c (ui_out::field_unsigned): New method.
7336         * symfile.c (generic_load): Use field_unsigned.
7337         (print_transfer_performance): Likewise.
7338         * record-btrace.c (ui_out_field_uint): Remove.
7339         (btrace_call_history_insn_range, btrace_call_history): Use
7340         field_unsigned.
7341         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7342         field_unsigned.
7343         * ui-out.h (class ui_out) <field_unsigned>: New method.
7344         <do_field_unsigned>: Likewise.
7345
7346 2019-07-15  Tom Tromey  <tromey@adacore.com>
7347
7348         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7349         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7350         * target.c (flash_erase_command): Use field_string.
7351         * infrun.c (print_signal_received_reason): Use field_string.
7352         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7353         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7354         field_string.
7355         * ada-tasks.c (print_ada_task_info): Use field_string.
7356
7357 2019-07-15  Tom Tromey  <tromey@adacore.com>
7358
7359         * target.c (flash_erase_command): Use field_core_addr.
7360         * symfile.c (generic_load): Use field_core_addr.
7361         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7362         Use field_core_addr.
7363         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7364         field_core_addr.
7365
7366 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7367
7368         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7369         value if its desired type is smaller than a CORE_ADDR and signed.
7370
7371 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7372
7373         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7374         of changes to field names, and use new is_reference field to
7375         decide if a property is a reference or not.
7376         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7377         field.
7378         (struct dwarf2_property_baton): Update header comment, rename
7379         'referenced_type' to 'property_type' and update comments.
7380         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7381         default property type, store in property baton, update to take
7382         accound of renamed field.
7383         (read_func_scope): Update call to attr_to_dynamic_prop.
7384         (read_array_type): Likewise.
7385         (dwarf2_per_cu_addr_sized_int_type): New function.
7386         (read_subrange_index_type): Move type finding code to
7387         dwarf2_per_cu_addr_sized_int_type.
7388         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7389         (dwarf2_per_cu_addr_type): New function.
7390         (set_die_type): Update calls to attr_to_dynamic_prop.
7391
7392 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7393
7394         * dwarf2read.c (read_subrange_index_type): New function.
7395         (read_subrange_type): Move code into new function and call it.
7396         * gdbtypes.c (create_range_type): Add some asserts.
7397
7398 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7399
7400         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7401         update return statements.
7402         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7403         declaration, and update comment to match.
7404         * gdbtypes.c (resolve_dynamic_array): Update call to
7405         dwarf2_evaluate_property to match new return type.
7406
7407 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7408
7409         * valarith.c (value_subscripted_rvalue): Change lowerbound
7410         parameter type from int to LONGEST.
7411         * value.h (value_subscripted_rvalue): Likewise in declaration.
7412
7413 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7414
7415         * cli/cli-utils.c (info_print_command_completer): New function.
7416         * cli/cli-utils.h: Add 'completer.h' include, and forward
7417         declaration for 'struct cmd_list_element'.
7418         (info_print_command_completer): Declare.
7419         * stack.c (_initialize_stack): Add completer for 'info locals' and
7420         'info args'.
7421         * symtab.c (_initialize_symtab): Add completer for 'info
7422         variables' and 'info functions'.
7423         * NEWS: Mention completion for additional info commands.
7424
7425 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7426
7427         * cli/cli-utils.c (extract_info_print_args): Delete.
7428         (extract_arg_maybe_quoted): Delete.
7429         (info_print_options_defs): New variable.
7430         (make_info_print_options_def_group): New function.
7431         (extract_info_print_options): Define new function.
7432         * cli/cli-utils.h (extract_info_print_args): Delete.
7433         (struct info_print_options): New structure.
7434         (extract_info_print_options): Declare new function.
7435         * stack.c (info_locals_command): Update to use new
7436         extract_info_print_options, also add a header comment.
7437         (info_args_command): Likewise.
7438         * symtab.c (info_variables_command): Likewise.
7439         (info_functions_command): Likewise.
7440
7441 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7442
7443         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7444         to extract string arguments.
7445         * common/common-utils.c (extract_string_maybe_quoted): New function.
7446         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7447
7448 2019-07-11  Tom Tromey  <tromey@adacore.com>
7449
7450         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7451         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7452         * top.h (gdbinit): Don't declare.
7453         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7454         into...
7455         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7456         * top.c (gdb_init): Don't call init_cli_cmds.
7457         (gdbinit): Remove.
7458         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7459
7460 2019-07-11  Tom Tromey  <tromey@adacore.com>
7461
7462         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7463         after it has been moved.
7464
7465 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7466
7467         * valops.c (value_must_coerce_to_target): Change return type to
7468         bool.
7469         * value.h (value_must_coerce_to_target): Likewise.
7470
7471 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7472
7473         * breakpoint.c (is_hardware_watchpoint): Remove
7474         forward-declaration.
7475         (is_masked_watchpoint): Change return type to bool.
7476         (is_tracepoint): Likewise.
7477         (is_breakpoint): Likewise.
7478         (is_hardware_watchpoint): Likewise.
7479         (is_watchpoint): Likewise.
7480         (is_no_memory_software_watchpoint): Likewise.
7481         (is_catchpoint): Likewise.
7482         (breakpoint_1): Make FILTER parameter's return type bool.
7483         is_masked_watchpoint): Change return type to bool.
7484         (save_breakpoints): Make FILTER parameter's return type bool.
7485         * breakpoint.h (is_breakpoint): Change return type to bool.
7486         (is_watchpoint): Likewise.
7487         (is_catchpoint): Likewise.
7488         (is_tracepoint): Likewise.
7489
7490 2019-07-10  Tom Tromey  <tom@tromey.com>
7491
7492         * defs.h: Don't include gdbarch.h.
7493         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7494         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7495         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7496         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7497         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7498         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7499         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7500         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7501         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7502         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7503         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7504         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7505         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7506         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7507         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7508         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7509         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7510         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7511         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7512         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7513         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7514         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7515         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7516         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7517         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7518         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7519         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7520
7521 2019-07-10  Tom Tromey  <tromey@adacore.com>
7522
7523         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7524         * breakpoint.c (init_ada_exception_breakpoint): Register as
7525         bp_catchpoint.
7526         (print_one_breakpoint_location, print_one_breakpoint): Use
7527         is_ada_exception_catchpoint.
7528         * ada-lang.c (class ada_catchpoint_location): Pass
7529         bp_loc_software_breakpoint to bp_location constructor.
7530         (is_ada_exception_catchpoint): New function.
7531
7532 2019-07-10  Tom Tromey  <tromey@adacore.com>
7533
7534         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7535         VEC.
7536         (struct arm_exidx_entry): New method operator<.
7537         (struct arm_exidx_data) <section_maps>: Change type.
7538         (arm_exidx_data_free): Remove.
7539         (arm_exidx_data_key): Change type.  Move lower.
7540         (arm_exidx_new_objfile): Update.
7541         (arm_compare_exidx_entries): Remove.
7542         (arm_find_exidx_entry, _initialize_arm_tdep)
7543
7544 2019-07-10  Tom Tromey  <tromey@adacore.com>
7545
7546         * solib-spu.c (ocl_program_data_key): Change type.
7547         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7548         Update.
7549
7550 2019-07-10  Tom Tromey  <tromey@adacore.com>
7551
7552         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7553         (struct solib_aix_inferior_data) <library_list>: Change type.
7554         (solib_aix_inferior_data_handle): Change type.
7555         (get_solib_aix_inferior_data): Update.
7556         (solib_aix_free_library_list): Remove.
7557         (library_list_start_library): Update.
7558         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7559         return type.
7560         (solib_aix_get_library_list)
7561         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7562         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7563
7564 2019-07-10  Tom Tromey  <tromey@adacore.com>
7565
7566         * solib-dsbt.c (struct dsbt_info): Add initializers.
7567         (solib_dsbt_pspace_data): Change type.
7568         (dsbt_pspace_data_cleanup): Remove.
7569         (get_dsbt_info, _initialize_dsbt_solib): Update.
7570
7571 2019-07-10  Tom Tromey  <tromey@adacore.com>
7572
7573         * spu-tdep.c (spu_overlay_data): Change type.
7574         (spu_get_overlay_table, spu_overlay_new_objfile)
7575         (_initialize_spu_tdep): Update.
7576
7577 2019-07-10  Tom Tromey  <tromey@adacore.com>
7578
7579         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7580         destructor.
7581         (dbx_objfile_data_key): Change type and declare later.
7582         (DBX_SYMFILE_INFO): Rewrite.
7583         * dbxread.c (dbx_objfile_data_key): Change type.
7584         (dbx_symfile_init): Update.
7585         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7586         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7587         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7588
7589 2019-07-10  Tom Tromey  <tromey@adacore.com>
7590
7591         * jit.c (jit_program_space_key): Change type.  Move lower.
7592         (get_jit_program_space_data): Update.
7593         (jit_program_space_data_cleanup): Remove.
7594         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7595         Update.
7596         (struct jit_program_space_data): Add initializers.
7597
7598 2019-07-10  Tom Tromey  <tromey@adacore.com>
7599
7600         * solib-darwin.c (struct darwin_info): Add initializers.
7601         (solib_darwin_pspace_data): Change type.
7602         (darwin_pspace_data_cleanup): Remove.
7603         (get_darwin_info, _initialize_darwin_solib): Update.
7604
7605 2019-07-10  Tom Tromey  <tromey@adacore.com>
7606
7607         * remote-sim.c (struct sim_inferior_data): Add initializers,
7608         constructor, and destructor.
7609         (sim_inferior_data_key): Change type.  Move lower.
7610         (check_for_duplicate_sim_descriptor): Update.
7611         (get_sim_inferior_data): Use new.  Update.
7612         (~sim_inferior_data_cleanup): Rename from
7613         sim_inferior_data_cleanup.  Simplify.
7614         (gdbsim_close_inferior, simulator_command)
7615         (sim_command_completer, _initialize_remote_sim): Update.
7616         (next_pid, INITIAL_PID): Move earlier.
7617
7618 2019-07-10  Tom Tromey  <tromey@adacore.com>
7619
7620         * python/python-internal.h (create_thread_object): Return
7621         gdbpy_ref.
7622         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7623         * python/py-inferior.c (struct threadlist_entry): Add
7624         constructor.
7625         <thread_obj>: Now a gdbpy_ref.
7626         (thread_to_thread_object): Update.
7627         (add_thread_object): Use new.
7628         (delete_thread_object): Use delete.
7629         (infpy_threads): Update.
7630         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7631         GIL.
7632
7633 2019-07-10  Tom Tromey  <tromey@adacore.com>
7634
7635         * valops.c (value_cast): Specialize error message for Ada.
7636
7637 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7638
7639         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7640
7641 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7642
7643         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7644         bpstat_should_step): Return bool, adjust comments.
7645         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7646         bpstat_should_step): Likewise.
7647
7648 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7649
7650         * features/Makefile: Use feature target descriptions for Arm.
7651         * features/arm/arm-core.c: Generate new file.
7652         * features/arm/arm-fpa.c: Likewise.
7653         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7654         * features/arm/arm-m-profile.c: Likewise.
7655         * features/arm/arm-vfpv2.c: Likewise.
7656         * features/arm/arm-vfpv3.c: Likewise.
7657         * features/arm/xscale-iwmmxt.c: Likewise.
7658         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7659
7660 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7661
7662         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7663         ptrace earlier.
7664
7665 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7666
7667         * features/aarch64-pauth.c: Regenerate.
7668
7669 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7670
7671         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7672         bool.
7673         (bpstat_what): Use false instead of 0.
7674
7675 2019-07-09  Pedro Alves  <palves@redhat.com>
7676
7677         * break-catch-throw.c (is_exception_catchpoint): New.
7678         * breakpoint.c (print_one_breakpoint_location): New parameter
7679         'raw_loc'.  Handle it.  Use
7680         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7681         looking at the breakpoint's type.
7682         (print_one_breakpoint): If handling "maint info breakpoints", also
7683         print locations of exception catchpoints.
7684         * breakpoint.h (is_exception_catchpoint): Declare.
7685
7686 2019-07-09  Pedro Alves  <palves@redhat.com>
7687
7688         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7689         "addr" field.
7690         (allocate_location_exception_catchpoint): New.
7691         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7692         (initialize_throw_catchpoint_ops): Install
7693         allocate_location_exception_catchpoint as allocate_location
7694         method.
7695         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7696         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7697         bp_loc_other.
7698         (breakpoint_address_is_meaningful): Delete.
7699         (bl_address_is_meaningful): New.
7700         (breakpoint_locations_match): Adjust comment.
7701         (bp_location_from_bp_type): New, factored out of...
7702         (bp_location::bp_location(breakpoint *)): ... this.
7703         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7704         factored out of...
7705         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7706         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7707         breakpoint_address_is_meaningful.
7708         (bp_locations_compare): Adjust comment.
7709         (update_global_location_list): Use bl_address_is_meaningful
7710         instead of breakpoint_address_is_meaningful.
7711         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7712         explicit.
7713         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7714         * python/py-breakpoint.c (bppy_get_location): No longer check
7715         whether location is null.
7716
7717 2019-07-09  Pedro Alves  <palves@redhat.com>
7718
7719         PR c++/15468
7720         * breakpoint.c (print_one_breakpoint_location): Remove
7721         single-location assert.
7722
7723 2019-07-09  Tom Tromey  <tom@tromey.com>
7724
7725         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7726         * configure: Rebuild.
7727         * configure.ac: Change common to gdbsupport.
7728         * gdbsupport: Rename from common.
7729         * acinclude.m4: Change common to gdbsupport.
7730         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7731         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7732         gdbsupport.
7733         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7734         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7735         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7736         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7737         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7738         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7739         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7740         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7741         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7742         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7743         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7744         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7745         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7746         coff-pe-read.c, command.h, compile/compile-c-support.c,
7747         compile/compile-c.h, compile/compile-cplus-symbols.c,
7748         compile/compile-cplus-types.c, compile/compile-cplus.h,
7749         compile/compile-loc2c.c, compile/compile.c, completer.c,
7750         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7751         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7752         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7753         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7754         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7755         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7756         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7757         features/aarch64-core.c, features/aarch64-fpu.c,
7758         features/aarch64-pauth.c, features/aarch64-sve.c,
7759         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7760         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7761         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7762         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7763         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7764         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7765         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7766         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7767         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7768         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7769         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7770         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7771         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7772         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7773         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7774         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7775         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7776         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7777         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7778         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7779         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7780         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7781         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7782         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7783         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7784         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7785         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7786         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7787         minsyms.c, mips-linux-tdep.c, namespace.h,
7788         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7789         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7790         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7791         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7792         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7793         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7794         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7795         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7796         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7797         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7798         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7799         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7800         procfs.c, producer.c, progspace.h, psymtab.h,
7801         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7802         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7803         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7804         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7805         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7806         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7807         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7808         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7809         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7810         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7811         target-memory.c, target.c, target.h, target/waitstatus.c,
7812         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7813         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7814         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7815         unittests/array-view-selftests.c,
7816         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7817         unittests/common-utils-selftests.c,
7818         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7819         unittests/format_pieces-selftests.c,
7820         unittests/function-view-selftests.c,
7821         unittests/lookup_name_info-selftests.c,
7822         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7823         unittests/mkdir-recursive-selftests.c,
7824         unittests/observable-selftests.c,
7825         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7826         unittests/parse-connection-spec-selftests.c,
7827         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7828         unittests/scoped_fd-selftests.c,
7829         unittests/scoped_mmap-selftests.c,
7830         unittests/scoped_restore-selftests.c,
7831         unittests/string_view-selftests.c, unittests/style-selftests.c,
7832         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7833         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7834         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7835         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7836         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7837         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7838
7839 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7840
7841         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7842         bool value.
7843         (decode_digits_ordinary): Set explicit_line field in sal.
7844         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7845         symtab_and_line that was set on an explicit line number in
7846         assembler code.  Do always update the recorded symtab and line if
7847         we do skip the prologue.
7848
7849 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7850
7851         * breakpoint.c (set_breakpoint_location_function): Remove
7852         explicit_loc parameter.
7853         (momentary_breakpoint_from_master): Update call to
7854         set_breakpoint_location_function.
7855         (add_location_to_breakpoint): Likewise.
7856
7857 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7858
7859         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7860         required features based on default bfd type when no specific bfd
7861         is present.
7862
7863 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7864
7865         * NEWS: Mention that GDB printf and eval commands can now print
7866         C-style and Ada-style convenience var strings without
7867         calling the inferior.
7868         * printcmd.c (printf_c_string): Locally print GDB internal var
7869         instead of transiting via the inferior.
7870         (printf_wide_c_string): Likewise.
7871
7872 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7873
7874         PR breakpoints/25011
7875         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7876
7877 2019-07-04  Tom Tromey  <tom@tromey.com>
7878
7879         PR tui/24724:
7880         * tui/tui-winsource.c (tui_clear_source_content): Update.
7881         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7882         (tui_update_breakpoint_info): Update.
7883         (tui_set_exec_info_content): Update.
7884         * tui/tui-source.c (tui_set_source_content_nil): Update.
7885         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7886         has_break.
7887         * tui/tui-data.h (enum tui_bp_flag): New.
7888         (tui_bp_flags): New enum flags type.
7889         (struct tui_source_element) <break_mode>: Change type.  Rename
7890         from has_break.
7891         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7892         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7893         constants.
7894         * tui/tui-winsource.h: Fix comment.
7895
7896 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7897
7898         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7899         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7900         (store_fpregs_to_thread)
7901         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7902         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7903         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7904         (IWMMXT_REGS_SIZE): Add define.
7905         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7906         (fetch_vfp_regs, store_vfp_regs)
7907         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7908         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7909
7910 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7911
7912         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7913         defines.
7914         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7915         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7916         (ARM_INT_REGISTER_SIZE): ...to this.
7917         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7918         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7919         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7920         (arm_linux_collect_gregset, supply_nwfpe_register)
7921         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7922         defines.
7923         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7924         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7925         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7926         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7927         (arm_return_in_memory, arm_store_return_value)
7928         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7929         (arm_record_ld_st_multiple): Likewise.
7930         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7931         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7932
7933 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7934
7935         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7936         AARCH64_DISPLACED_MODIFIED_INSNS.
7937         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7938         (aarch64_displaced_step_copy_insn): Likewise.
7939         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7940         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7941         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7942         ARM_DISPLACED_MODIFIED_INSNS.
7943         * arm-tdep.c (arm_gdbarch_init): Likewise.
7944         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7945         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7946         (struct arm_displaced_step_closure): Use
7947         ARM_DISPLACED_MODIFIED_INSNS.
7948
7949 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7950
7951         * features/Makefile: Remove unused xml files.
7952         * features/aarch64.xml: Remove.
7953         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7954         * features/i386/amd64-avx-avx512.xml: Remove.
7955         * features/i386/amd64-avx-linux.xml: Remove.
7956         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7957         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7958         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7959         * features/i386/amd64-avx-mpx.xml: Remove.
7960         * features/i386/amd64-avx.xml: Remove.
7961         * features/i386/amd64-linux.xml: Remove.
7962         * features/i386/amd64-mpx-linux.xml: Remove.
7963         * features/i386/amd64-mpx.xml: Remove.
7964         * features/i386/amd64.xml: Remove.
7965         * features/i386/i386-avx-avx512-linux.xml: Remove.
7966         * features/i386/i386-avx-avx512.xml: Remove.
7967         * features/i386/i386-avx-linux.xml: Remove.
7968         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7969         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7970         * features/i386/i386-avx-mpx-linux.xml: Remove.
7971         * features/i386/i386-avx-mpx.xml: Remove.
7972         * features/i386/i386-avx.xml: Remove.
7973         * features/i386/i386-linux.xml: Remove.
7974         * features/i386/i386-mmx-linux.xml: Remove.
7975         * features/i386/i386-mmx.xml: Remove.
7976         * features/i386/i386-mpx-linux.xml: Remove.
7977         * features/i386/i386-mpx.xml: Remove.
7978         * features/i386/i386.xml: Remove.
7979         * features/i386/x32-avx-avx512-linux.xml: Remove.
7980         * features/i386/x32-avx-linux.xml: Remove.
7981         * features/i386/x32-linux.xml: Remove.
7982
7983 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7984
7985         * regformats/aarch64.dat: Remove.
7986         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7987         * regformats/i386/amd64-avx-linux.dat: Remove.
7988         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7989         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7990         * regformats/i386/amd64-linux.dat: Remove.
7991         * regformats/i386/amd64-mpx-linux.dat: Remove.
7992         * regformats/i386/amd64.dat: Remove.
7993         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7994         * regformats/i386/i386-avx-linux.dat: Remove.
7995         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7996         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7997         * regformats/i386/i386-linux.dat: Remove.
7998         * regformats/i386/i386-mmx-linux.dat: Remove.
7999         * regformats/i386/i386-mpx-linux.dat: Remove.
8000         * regformats/i386/i386.dat: Remove.
8001         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
8002         * regformats/i386/x32-avx-linux.dat: Remove.
8003         * regformats/i386/x32-linux.dat: Remove.
8004
8005 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8006
8007         * aarch64-tdep.c: Remove xml self tests.
8008         * amd64-linux-tdep.c: Likewise.
8009         * amd64-tdep.c: Likewise.
8010         * i386-linux-tdep.c: Likewise.
8011         * i386-tdep.c: Likewise.
8012
8013 2019-07-03  Pedro Alves  <palves@redhat.com>
8014
8015         PR cli/24732
8016         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
8017         (pipe_cmd_option_defs): New.
8018         (make_pipe_cmd_options_def_group): New.
8019         (pipe_command): Use gdb::option::process_options.
8020         (pipe_command_completer): New function.
8021         (_initialize_cli_cmds): Install completer for "pipe" command.
8022
8023 2019-07-03  Pedro Alves  <palves@redhat.com>
8024
8025         * cli/cli-option.c (union option_value) <string>: New field.
8026         (struct option_def_and_value): Add ctor, move ctor, dtor and
8027         use DISABLE_COPY_AND_ASSIGN.
8028         (option_def_and_value::clear_value): New.
8029         (parse_option, save_option_value_in_ctx, get_val_type_str)
8030         (add_setshow_cmds_for_options): Handle var_string.
8031         * cli-option.h (union option_def::var_address) <string>: New
8032         field.
8033         (struct string_option_def): New.
8034         * maint-test-options.c (struct test_options_opts): Add default
8035         ctor and use DISABLE_COPY_AND_ASSIGN.
8036         <string_opt>: New field.
8037         (test_options_opts::~test_options_opts): New.
8038         (test_options_opts::dump): Also dump "-string".
8039         (test_options_option_defs): Install "string.
8040
8041 2019-07-03  Pedro Alves  <palves@redhat.com>
8042
8043         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
8044         option_value with a null enumeration.
8045         (complete_options): Save the option values in the context.
8046         (save_option_value_in_ctx): New, factored out from ...
8047         (process_options): ... here.
8048         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
8049         of the function.
8050         * maint-test-options.c (test_options_opts::dump): New, factored
8051         out from ...
8052         (maintenance_test_options_command_mode): ... here.
8053         (maintenance_test_options_command_completion_result): Delete.
8054         (maintenance_test_options_command_completion_text): Update
8055         comment.
8056         (maintenance_show_test_options_completion_result): Change
8057         prototype.  Just print
8058         maintenance_test_options_command_completion_text.
8059         (save_completion_result): New.
8060         (maintenance_test_options_completer_mode): Pass options context to
8061         complete_options, and then save a dump.
8062         (_initialize_maint_test_options): Use add_cmd to install "maint
8063         show test-options-completion-result".
8064
8065 2019-07-03  Pedro Alves  <palves@redhat.com>
8066
8067         * NEWS (New commands): Mention "with" and "maint with".
8068         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8069         (with_command, with_command_completer): New.
8070         (pipe_command): Adjust to new repeat_previous
8071         interface.
8072         (_initialize_cli_cmds): Install the "with" command and its "w"
8073         alias.
8074         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8075         declarations.
8076         * cli/cli-setshow.c (parse_cli_var_uinteger)
8077         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8078         argument strings for all var_types.
8079         (get_setshow_command_value_string): New, factored out from ...
8080         (do_show_command): ... this.
8081         * cli/cli-setshow.h: Include <string>.
8082         (get_setshow_command_value_string): Declare.
8083         * command.h (repeat_previous): Now returns const char *.  Adjust
8084         comment.
8085         * maint.c: Include "cli/cli-cmds.h".
8086         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8087         (_initialize_maint_cmds): Register the "maintenance with" command.
8088         * top.c (repeat_previous): Move bits from pipe_command here:
8089         Return the saved command line, if any; error out if there's no
8090         command to relaunch.
8091
8092 2019-07-03  Pedro Alves  <palves@redhat.com>
8093
8094         * NEWS (New commands): Mention "maint set/show test-settings"
8095         instead of "maint test-settings".
8096         * maint-test-settings.c (maintenance_test_settings_list): Delete.
8097         (maintenance_test_settings_set_list): Rename to ...
8098         (maintenance_set_test_settings_list): ... this.
8099         (maintenance_test_settings_show_list): Rename to  ...
8100         (maintenance_show_test_settings_list): ... this.
8101         (maintenance_test_settings_cmd): Delete.
8102         (maintenance_test_settings_set_cmd): ...
8103         (maintenance_set_test_settings_cmd): ... this.
8104         (maintenance_test_settings_show_cmd): ...
8105         (maintenance_show_test_settings_cmd): ... this.
8106         (maintenance_test_settings_show_value_cmd):
8107         (maintenance_show_test_settings_value_cmd): ... this.
8108         (_initialize_maint_test_settings): No longer install the "maint
8109         test-settings" prefix command.  Rename "maint test-settings set"
8110         to "maint set test-settings", and "maint test-settings show" to
8111         "maint show test-settings".  Adjust all subcommands.
8112
8113 2019-07-03  Pedro Alves  <palves@redhat.com>
8114
8115         * maint-test-settings.c: Fix file's intro comment.  Replace all
8116         references to "test-options" with references to "test-settings",
8117         in comments.
8118
8119 2019-07-03  Pedro Alves  <palves@redhat.com>
8120
8121         * maint-test-settings.c (maintenance_test_settings_xxx)
8122         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8123         New.
8124         (maintenance_test_settings_enums): Use them.
8125         (maintenance_test_settings_enum): Default to
8126         maintenance_test_settings_xxx.
8127         (_initialize_maint_test_settings): Initialize
8128         MAINTENANCE_TEST_SETTINGS_FILENAME.
8129
8130 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8131
8132         * breakpoint.h (remove_breakpoints_inf): Change return type to
8133         void, move function documentation here.
8134         * breakpoint.c (remove_breakpoints_inf): Change return type to
8135         void, move function documentation to header.
8136
8137 2019-07-02  Pedro Alves  <palves@redhat.com>
8138
8139         * NEWS (Completion improvements): Mention "info threads".
8140         * thread.c (struct info_threads_opts, info_threads_option_defs)
8141         (make_info_threads_options_def_group): New.
8142         (info_threads_command): Use gdb::option::process_options.
8143         (info_threads_command_completer): New.
8144         (_initialize_thread): Use gdb::option::build_help to build the
8145         help text for "info threads".
8146
8147 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8148
8149         * defs.h (generic_load): Move from here...
8150         * symfile.h (generic_load): ... to here.  Rename name parameter
8151         to args.
8152         * symfile.c (generic_load): Add comment.
8153
8154 2019-07-01  Tom Tromey  <tromey@adacore.com>
8155
8156         * dwarf2read.c
8157         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8158         declaration of without_params.  Fix formatting.
8159
8160 2019-07-01  Tom Tromey  <tromey@adacore.com>
8161
8162         * ada-exp.y (find_primitive_type): Update.
8163         * ada-lang.h (ada_lookup_symbol): Update.
8164         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8165         parameter.
8166         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8167
8168 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8169
8170         PR breakpoints/24541
8171         * gdbarch.c: Regenerate.
8172         * gdbarch.h: Regenerate.
8173         * gdbarch.sh: Add 'stap_adjust_register'.
8174         * i386-tdep.c: Include '<unordered_set>'.
8175         (i386_stap_adjust_register): New function.
8176         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8177         * stap-probe.c (stap_parse_register_operand): Call
8178         'gdbarch_stap_adjust_register'.
8179
8180 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8181
8182         PR python/24742
8183         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8184         * python/python.c (do_start_initialization): Use 'xmalloc'
8185         instead of 'PyMem_Malloc'.
8186
8187 2019-06-28  Tom Tromey  <tromey@adacore.com>
8188
8189         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8190         for Ada.
8191
8192 2019-06-27  Tom Tromey  <tromey@adacore.com>
8193
8194         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8195         objfile_key.
8196         (arm_find_mapping_symbol, arm_record_special_symbol)
8197         (_initialize_arm_tdep): Update.
8198         (arm_objfile_data_free): Remove.
8199
8200 2019-06-27  Tom Tromey  <tromey@adacore.com>
8201
8202         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8203         to cp_print_static_field.
8204
8205 2019-06-26  Tom Tromey  <tromey@adacore.com>
8206
8207         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8208         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8209         declare.
8210
8211 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8212
8213         * features/aarch64-core.c (create_feature_aarch64_core):
8214         Regenerate.
8215         * features/aarch64-core.xml: Add cpsr flags.
8216
8217 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8218
8219         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8220         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8221
8222 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8223
8224         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8225         field.
8226         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8227         use.
8228         (arm_record_special_symbol): Don't insert new symbol in sorted
8229         position, push it at the end.
8230
8231 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8232
8233         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8234         (arm_mapping_symbol_s): Remove.
8235         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8236         (arm_mapping_symbol_vec): New typedef.
8237         (struct arm_per_objfile): Add constructor.
8238         <section_maps>: Change type to
8239         std::unique_ptr<arm_mapping_symbol_vec[]>.
8240         (arm_compare_mapping_symbols): Remove.
8241         (arm_find_mapping_symbol): Adjust to section_maps type change.
8242         (arm_objfile_data_free): Call delete on arm_per_objfile.
8243         (arm_record_special_symbol): Adjust to section_maps type change.
8244         Allocate arm_per_objfile with new.
8245
8246 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8247
8248         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8249         with the command prefix.
8250
8251 2019-06-25  Tom Tromey  <tom@tromey.com>
8252
8253         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8254         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8255
8256 2019-06-25  Tom Tromey  <tom@tromey.com>
8257
8258         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8259         type.
8260         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8261         protected.
8262
8263 2019-06-25  Tom Tromey  <tom@tromey.com>
8264
8265         * tui/tui-winsource.c
8266         (tui_source_window_base::set_is_exec_point_at): Add check against
8267         LOA_ADDRESS.
8268
8269 2019-06-25  Tom Tromey  <tom@tromey.com>
8270
8271         * tui/tui-source.c (tui_set_source_content): Don't check before
8272         xfree.
8273         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8274
8275 2019-06-25  Tom Tromey  <tom@tromey.com>
8276
8277         * tui/tui-winsource.h (tui_update_source_window_as_is)
8278         (tui_alloc_source_buffer, tui_line_is_displayed)
8279         (tui_addr_is_displayed): Change type of win_info.
8280         * tui/tui-winsource.c (tui_update_source_window_as_is)
8281         (tui_clear_source_content, tui_show_source_line)
8282         (tui_show_source_content, tui_source_window_base::refill)
8283         (tui_source_window_base::set_is_exec_point_at)
8284         (tui_source_window_base::set_is_exec_point_at)
8285         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8286         (tui_alloc_source_buffer, tui_line_is_displayed)
8287         (tui_addr_is_displayed): Change type of win_info.  Update.
8288         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8289         (tui_source_window_base::do_make_visible_with_new_height):
8290         Update.
8291         * tui/tui-source.c (tui_set_source_content)
8292         (tui_set_source_content_nil)
8293         (tui_source_window::do_scroll_vertical): Update.
8294         * tui/tui-layout.c (show_layout): Update.
8295         * tui/tui-disasm.c (tui_set_disassem_content)
8296         (tui_disasm_window::do_scroll_vertical): Update.
8297         * tui/tui-data.h (tui_win_content): Remove.
8298         (struct tui_gen_win_info) <content, content_size>: Remove.
8299         (struct tui_source_element): Add initializers and destructor.
8300         (union tui_which_element, struct tui_win_element): Remove.
8301         (struct tui_source_window_base) <content>: New field.
8302         (struct tui_data_window): Remove destructor.
8303         (tui_alloc_content, tui_free_win_content)
8304         (tui_free_all_source_wins_content): Don't declare.
8305         * tui/tui-data.c (tui_initialize_static_data): Update.
8306         (init_content_element, tui_alloc_content): Remove.
8307         (~tui_gen_win_info): Update.
8308         (~tui_data_window, tui_free_all_source_wins_content)
8309         (tui_free_win_content, free_content, free_content_elements):
8310         Remove.
8311
8312 2019-06-25  Tom Tromey  <tom@tromey.com>
8313
8314         * tui/tui-winsource.h (tui_clear_source_content)
8315         (tui_erase_source_content, tui_show_source_content): Change type
8316         of win_info.
8317         * tui/tui-winsource.c (tui_clear_source_content)
8318         (tui_erase_source_content, tui_show_source_content): Change type
8319         of win_info.
8320         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8321         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8322         win_info.
8323         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8324         win_info.
8325         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8326
8327 2019-06-25  Tom Tromey  <tom@tromey.com>
8328
8329         * tui/tui-winsource.c (tui_clear_source_content)
8330         (tui_source_window_base::set_is_exec_point_at): Update.
8331         * tui/tui-source.c (tui_set_source_content_nil): Update.
8332         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8333         a bool.
8334         * tui/tui-data.c (init_content_element): Update.
8335
8336 2019-06-25  Tom Tromey  <tom@tromey.com>
8337
8338         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8339         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8340         * tui/tui-layout.c (init_and_make_win): Update.
8341         * tui/tui.h (enum tui_win_type): Update.
8342         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8343         tui_win_is_auxillary.
8344         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8345         tui_win_is_auxillary.
8346
8347 2019-06-25  Tom Tromey  <tom@tromey.com>
8348
8349         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8350         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8351         (tui_delete_data_content_windows, tui_display_all_data)
8352         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8353         Update.
8354         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8355         * tui/tui-regs.c (tui_last_regs_line_no)
8356         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8357         (tui_show_registers): Update.
8358         (tui_show_register_group): Return void.  Update.
8359         (tui_display_registers_from, tui_display_reg_element_at_line)
8360         (tui_display_registers_from_line, tui_check_register_values):
8361         Update.
8362         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8363         member.
8364         (struct tui_data_window) <regs_content>: Now a std::vector.
8365         <regs_content_count>: Remove.
8366         (tui_add_content_elements, tui_free_data_content): Don't declare.
8367         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8368         (init_content_element): Remove DATA_WIN case.  Add assert.
8369         (tui_add_content_elements): Remove.
8370         (tui_data_window): Update.
8371         (tui_free_data_content): Remove.
8372         (free_content_elements): Remove DATA_WIN case.
8373
8374 2019-06-25  Tom Tromey  <tom@tromey.com>
8375
8376         * tui/tui-data.c (tui_data_item_window): Update.
8377         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8378         * tui/tui-windata.c (tui_display_all_data)
8379         (tui_display_data_from_line): Update.
8380         (tui_check_data_values): Remove.
8381         * tui/tui-regs.c (tui_show_register_group)
8382         (tui_display_reg_element_at_line): Update.
8383         * tui/tui-hooks.c (tui_register_changed)
8384         (tui_refresh_frame_and_register_information): Call
8385         tui_check_register_values.
8386         * tui/tui-data.h (struct tui_data_window) <data_content,
8387         data_content_count, data_type>: Remove.
8388         (enum tui_data_type): Remove.
8389
8390         * tui/tui-data.c (tui_data_window::clear_detail)
8391         (~tui_data_window): Update.
8392
8393 2019-06-25  Tom Tromey  <tom@tromey.com>
8394
8395         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8396         declare.
8397         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8398         Rename from tui_first_data_item_displayed.  Update.
8399         (tui_data_window::refresh_all)
8400         (tui_data_window::do_scroll_vertical): Update.
8401         * tui/tui-data.h (struct tui_data_window)
8402         <first_data_item_displayed>: Declare new method.
8403
8404 2019-06-25  Tom Tromey  <tom@tromey.com>
8405
8406         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8407         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8408         contents...
8409         (tui_initialize_static_data): ...here.
8410
8411 2019-06-25  Tom Tromey  <tom@tromey.com>
8412
8413         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8414         (tui_display_registers_from, tui_check_register_values): Update.
8415         (tui_display_register): Remove win_info parameter; update.
8416         (tui_get_register): Change type of parameters.
8417         * tui/tui-data.h (struct tui_data_element): Remove.
8418         (union tui_which_element) <data>: Remove.
8419         <data_window>: Change type.
8420         (struct tui_data_item_window): New.
8421         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8422         case.  Add assert.
8423         (~tui_data_item_window): New destructor.
8424         (free_content_elements): Remove DATA_ITEM_WIN case.
8425
8426 2019-06-25  Tom Tromey  <tom@tromey.com>
8427
8428         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8429         Remove.
8430
8431 2019-06-25  Tom Tromey  <tom@tromey.com>
8432
8433         * tui/tui-data.h (struct tui_command_element): Remove.
8434         (union tui_which_element) <command>: Remove.
8435         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8436         assert.
8437         (free_content_elements): Remove CMD_WIN case.
8438
8439 2019-06-25  Tom Tromey  <tom@tromey.com>
8440
8441         * tui/tui-layout.c (tui_set_layout): Update.
8442         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8443         * tui/tui-data.c (layout_def): Update.
8444
8445 2019-06-25  Tom Tromey  <tom@tromey.com>
8446
8447         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8448         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8449         (tui_source_window_base::set_new_height): Update.
8450         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8451         Update.
8452         (tui_set_locator_fullname, tui_set_locator_info)
8453         (tui_show_frame_info): Update.
8454         * tui/tui-source.c (tui_set_source_content)
8455         (tui_source_is_displayed): Update.
8456         * tui/tui-layout.c (show_source_disasm_command, show_data)
8457         (show_source_or_disasm_and_command): Update.
8458         * tui/tui-disasm.c (tui_set_disassem_content)
8459         (tui_get_begin_asm_address): Update.
8460         * tui/tui-data.h (struct tui_locator_element): Remove.
8461         (union tui_which_element) <locator>: Remove.
8462         (struct tui_locator_window): New.
8463         (tui_locator_win_info_ptr): Change return type.
8464         * tui/tui-data.c (_locator): Change type.
8465         (tui_locator_win_info_ptr): Change return type.
8466         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8467         (tui_alloc_content): Add assert.
8468
8469 2019-06-25  Tom Tromey  <tom@tromey.com>
8470
8471         * tui/tui-winsource.c
8472         (tui_exec_info_window::maybe_allocate_content): New method.
8473         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8474         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8475         (make_source_or_disasm_window): Add cast.
8476         * tui/tui-data.h (union tui_which_element) <simple_string>:
8477         Remove.
8478         (struct tui_source_info): New.
8479         (struct tui_source_window_base) <execution_info>: Change type.
8480         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8481         case, and add assert.
8482         (tui_alloc_content): Add assert.
8483
8484 2019-06-25  Tom Tromey  <tom@tromey.com>
8485
8486         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8487         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8488         * tui/tui-data.c (tui_alloc_win_info): Remove.
8489
8490 2019-06-25  Tom Tromey  <tom@tromey.com>
8491
8492         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8493         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8494         can_highlight.
8495
8496 2019-06-25  Tom Tromey  <tom@tromey.com>
8497
8498         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8499         make_visible_with_new_height method.
8500         (tui_win_info::make_visible_with_new_height): New method.
8501         (tui_source_window_base::do_make_visible_with_new_height)
8502         (tui_data_window::do_make_visible_with_new_height)
8503         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8504         (make_visible_with_new_height): Remove.
8505         (tui_resize_all, tui_adjust_win_heights): Use
8506         make_visible_with_new_height method.
8507         * tui/tui-data.h (struct tui_win_info)
8508         <do_make_visible_with_new_height, make_visible_with_new_height>:
8509         New methods.
8510         (struct tui_source_window_base, struct tui_data_window)
8511         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8512         methods.
8513
8514 2019-06-25  Tom Tromey  <tom@tromey.com>
8515
8516         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8517         method.
8518         (update_tab_width): Call update_tab_width method.
8519         * tui/tui-data.h (struct tui_win_info)
8520         (struct tui_source_window_base) <update_tab_width>: New methods.
8521
8522 2019-06-25  Tom Tromey  <tom@tromey.com>
8523
8524         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8525         parameter.
8526         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8527         parameter.
8528         (tui_gen_win_info::make_visible): Update.
8529         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8530         parameter.
8531         * tui/tui-data.h (enum tui_box): New enum.
8532         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8533
8534 2019-06-25  Tom Tromey  <tom@tromey.com>
8535
8536         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8537         init_and_make_win for EXEC_INFO_WIN.
8538         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8539         longer inline.
8540         (struct tui_win_info) <~tui_win_info>: Inline.
8541         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8542         Don't declare.
8543         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8544         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8545         Remove.
8546         (tui_initialize_static_data): Update.
8547         (~tui_gen_win_info): Handle more cleanup here.
8548         (~tui_source_window_base): Delete "execution_info".
8549         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8550
8551 2019-06-25  Tom Tromey  <tom@tromey.com>
8552
8553         * tui/tui-layout.c (make_command_window): Don't set
8554         can_highlight.
8555         (show_source_disasm_command): Call the reset method.
8556         (show_data): Don't set can_highlight.  Call the reset method.
8557         (tui_gen_win_info::reset): Rename from init_gen_win_info
8558         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8559         (show_source_or_disasm_and_command): Call the reset method.
8560         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8561         (struct tui_cmd_window): Set can_highlight.
8562
8563 2019-06-25  Tom Tromey  <tom@tromey.com>
8564
8565         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8566         from make_visible.
8567         (tui_make_visible, tui_make_invisible): Rewrite.
8568         (tui_win_info::make_visible): Remove.
8569         (tui_source_window_base::make_visible): Update.
8570         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8571         method.  Moved from...
8572         (struct tui_win_info) <make_visible>: ...here.
8573
8574 2019-06-25  Tom Tromey  <tom@tromey.com>
8575
8576         * tui/tui-winsource.c
8577         (tui_source_window_base::do_scroll_horizontal): Remove direction
8578         parameter.
8579         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8580         direction parameter.
8581         * tui/tui-win.c (tui_win_info::forward_scroll)
8582         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8583         (tui_win_info::right_scroll): Update.
8584         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8585         direction parameter.
8586         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8587         direction parameter.
8588         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8589         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8590         Remove direction parameter.
8591         (struct tui_source_window_base, struct tui_source_window)
8592         (struct tui_disasm_window, struct tui_data_window)
8593         (struct tui_cmd_window): Update.
8594
8595 2019-06-25  Tom Tromey  <tom@tromey.com>
8596
8597         * tui/tui-winsource.h (tui_set_exec_info_content)
8598         (tui_show_exec_info_content, tui_erase_exec_info_content)
8599         (tui_clear_exec_info_content, tui_update_exec_info): Change
8600         argument to tui_source_window_base.
8601         * tui/tui-winsource.c (tui_set_exec_info_content)
8602         (tui_show_exec_info_content, tui_erase_exec_info_content)
8603         (tui_clear_exec_info_content, tui_update_exec_info): Change
8604         argument to tui_source_window_base.
8605
8606 2019-06-25  Tom Tromey  <tom@tromey.com>
8607
8608         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8609         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8610
8611 2019-06-25  Tom Tromey  <tom@tromey.com>
8612
8613         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8614         check.
8615
8616 2019-06-25  Tom Tromey  <tom@tromey.com>
8617
8618         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8619         type to void.
8620         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8621         type to void.
8622         * tui/tui-source.c (tui_set_source_content): Update.
8623         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8624
8625 2019-06-25  Tom Tromey  <tom@tromey.com>
8626
8627         * tui/tui-win.c (window_name_completer, tui_set_focus)
8628         (tui_all_windows_info): Use name method.
8629         * tui/tui-data.h (struct tui_gen_win_info)
8630         (struct tui_source_window, struct tui_disasm_window)
8631         (struct tui_data_window, struct tui_cmd_window) <name>: New
8632         method.
8633         (tui_win_name): Don't declare.
8634         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8635         (tui_win_name): Remove.
8636
8637 2019-06-25  Tom Tromey  <tom@tromey.com>
8638
8639         * tui/tui-winsource.h (tui_update_source_window)
8640         (tui_update_source_window_as_is): Change parameter type.
8641         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8642         to be a tui_source_window_base.
8643         (tui_update_source_window_as_is): Likewise.
8644         * tui/tui-win.c (make_visible_with_new_height): Update.
8645
8646 2019-06-25  Tom Tromey  <tom@tromey.com>
8647
8648         * tui/tui-winsource.c (tui_erase_source_content)
8649         (tui_show_source_content, tui_show_exec_info_content)
8650         (tui_erase_exec_info_content): Use refresh_window method.
8651         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8652         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8653         from tui_refresh_win.
8654         (tui_data_window::refresh_window): New method.
8655         (tui_win_info::refresh, tui_source_window_base::refresh)
8656         (tui_refresh_all): Use refresh_window method.
8657         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8658         method.
8659         * tui/tui-regs.c (tui_display_register): Call refresh_window
8660         method.
8661         * tui/tui-layout.c (show_source_disasm_command)
8662         (show_source_or_disasm_and_command): Call refresh_window method.
8663         * tui/tui-data.h (struct tui_gen_win_info)
8664         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8665         New method.
8666
8667 2019-06-25  Tom Tromey  <tom@tromey.com>
8668
8669         * tui/tui.c (tui_rl_other_window, tui_enable)
8670         (tui_is_window_visible, tui_get_command_dimension): Update.
8671         * tui/tui-winsource.c (tui_update_source_window_as_is)
8672         (tui_clear_source_content, tui_erase_source_content)
8673         (tui_show_source_line, tui_source_window_base::refill)
8674         (tui_source_window_base::do_scroll_horizontal)
8675         (tui_source_window_base::set_is_exec_point_at)
8676         (tui_update_breakpoint_info, tui_set_exec_info_content)
8677         (tui_alloc_source_buffer, tui_line_is_displayed)
8678         (tui_addr_is_displayed): Update.
8679         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8680         (tui_check_and_display_highlight_if_needed)
8681         (tui_win_info::make_visible, tui_win_info::refresh)
8682         (tui_refresh_all): Update.
8683         * tui/tui-windata.c (tui_first_data_item_displayed)
8684         (tui_delete_data_content_windows, tui_erase_data_content)
8685         (tui_display_all_data, tui_data_window::refresh_all)
8686         (tui_check_data_values): Update.
8687         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8688         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8689         (tui_win_info::backward_scroll, tui_refresh_all_win)
8690         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8691         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8692         (tui_source_window_base::set_new_height)
8693         (tui_data_window::set_new_height)
8694         (make_invisible_and_set_new_height)
8695         (make_visible_with_new_height, new_height_ok)
8696         (parse_scrolling_args): Update.
8697         * tui/tui-stack.c (tui_show_frame_info): Update.
8698         * tui/tui-source.c (tui_set_source_content)
8699         (tui_set_source_content_nil, tui_source_is_displayed)
8700         (tui_source_window::do_scroll_vertical): Update.
8701         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8702         (tui_display_registers_from, tui_display_reg_element_at_line)
8703         (tui_check_register_values, tui_reg_command): Update.
8704         * tui/tui-layout.c (tui_default_win_height)
8705         (show_source_disasm_command, show_data, init_and_make_win)
8706         (show_source_or_disasm_and_command): Update.
8707         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8708         (tui_redisplay_readline, tui_mld_flush)
8709         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8710         (tui_getc): Update.
8711         * tui/tui-disasm.c (tui_set_disassem_content)
8712         (tui_disasm_window::do_scroll_vertical): Update.
8713         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8714         Now virtual.
8715         (struct tui_win_info): Derive from tui_gen_win_info.
8716         <~tui_win_info>: Mark as override.
8717         <generic>: Remove member.
8718         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8719         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8720         (~tui_data_window, ~tui_win_info)
8721         (tui_free_all_source_wins_content): Update.
8722         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8723
8724 2019-06-25  Tom Tromey  <tom@tromey.com>
8725
8726         * tui/tui-layout.c (init_and_make_win): Use new.
8727         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8728         destructor, initializers.
8729         (tui_alloc_generic_win_info): Don't declare.
8730         * tui/tui-data.c (_locator): Add argument to constructor.
8731         (source_win, disasm_win): New globals.
8732         (exec_info): Remove.
8733         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8734         Update.
8735         (tui_alloc_generic_win_info): Remove.
8736         (init_content_element): Use new.
8737         (tui_win_info::tui_win_info): Update.
8738         (free_content_elements) <case DATA_WIN>: Use delete.
8739
8740 2019-06-25  Tom Tromey  <tom@tromey.com>
8741
8742         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8743         * tui/tui-windata.c (tui_first_data_item_displayed)
8744         (tui_delete_data_content_windows): Update.
8745         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8746         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8747         (tui_display_registers_from, tui_check_register_values): Update.
8748         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8749         pointer.
8750         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8751         window.
8752         (tui_free_data_content): Update.
8753         (free_content_elements) <case DATA_WIN>: Free the window.
8754
8755 2019-06-25  Tom Tromey  <tom@tromey.com>
8756
8757         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8758         Update.
8759         * tui/tui-layout.c (make_command_window)
8760         (show_source_disasm_command, show_data, init_and_make_win)
8761         (show_source_or_disasm_and_command): Update.
8762         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8763         method.
8764         <can_highight, is_highlighted>: Now bool.
8765         (tui_set_win_highlight): Don't declare.
8766         * tui/tui-data.c (tui_set_win_highlight): Remove.
8767
8768 2019-06-25  Tom Tromey  <tom@tromey.com>
8769
8770         * tui/tui-wingeneral.c (make_visible): Remove check of window
8771         type.
8772
8773 2019-06-25  Tom Tromey  <tom@tromey.com>
8774
8775         * tui/tui-win.c (tui_win_info::max_height)
8776         (tui_cmd_window::max_height): New methods.
8777         (new_height_ok): Call max_height.
8778         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8779         <max_height>: New method.
8780
8781 2019-06-25  Tom Tromey  <tom@tromey.com>
8782
8783         * tui/tui-win.c (tui_source_window_base::set_new_height)
8784         (tui_data_window::set_new_height): New methods.
8785         (make_invisible_and_set_new_height): Call set_new_height method.
8786         * tui/tui-data.h (struct tui_win_info)
8787         (struct tui_source_window_base, struct tui_data_window)
8788         <set_new_height>: New method.
8789
8790 2019-06-25  Tom Tromey  <tom@tromey.com>
8791
8792         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8793         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8794         tui_refresh_data_win.
8795         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8796         method.
8797         (tui_refresh_all_win): Call the refresh_all method.
8798         (tui_set_focus): Likewise.
8799         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8800         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8801         Likewise.
8802
8803 2019-06-25  Tom Tromey  <tom@tromey.com>
8804
8805         * tui/tui-winsource.h (tui_refill_source_window)
8806         (tui_set_is_exec_point_at): Don't declare.
8807         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8808         (tui_source_window_base::refill): Rename from
8809         tui_refill_source_window.
8810         (tui_source_window_base::do_scroll_horizontal): Update.
8811         (tui_source_window_base::set_is_exec_point_at): Rename from
8812         tui_set_is_exec_point_at.
8813         (tui_update_all_breakpoint_info): Update.
8814         * tui/tui-stack.c (tui_show_frame_info): Update.
8815         * tui/tui-layout.c (show_data): Add cast.
8816         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8817         * tui/tui-data.h (struct tui_source_window_base) <refill,
8818         set_is_exec_point_at>: New methods.
8819         (tui_source_windows, tui_add_to_source_windows): Update types.
8820         (tui_add_to_source_windows): Remove redundant declaration.
8821         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8822         (tui_source_windows): Change return type.
8823         (tui_clear_source_windows_detail): Update.
8824         (tui_add_to_source_windows): Change type of parameter.
8825         (tui_free_all_source_wins_content): Update.
8826
8827 2019-06-25  Tom Tromey  <tom@tromey.com>
8828
8829         * tui/tui-wingeneral.c (tui_win_info::refresh)
8830         (tui_source_window_base::refresh): New methods.
8831         (tui_refresh_all): Call the refresh method.
8832         * tui/tui-data.h (struct tui_win_info)
8833         (struct tui_source_window_base) <refresh>: New method.
8834
8835 2019-06-25  Tom Tromey  <tom@tromey.com>
8836
8837         * tui/tui.h (tui_is_window_visible): Return bool.
8838         * tui/tui.c (tui_is_window_visible): Return bool.
8839         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8840         (tui_make_visible, tui_make_invisible)
8841         (tui_win_info::make_visible)
8842         (tui_source_window_base::make_visible, make_all_visible)
8843         (tui_make_all_visible, tui_make_all_invisible): Update.
8844         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8845         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8846         bool.
8847         (struct tui_win_info, struct tui_source_window_base)
8848         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8849         * tui/tui-data.c (tui_init_generic_part): Update.
8850
8851 2019-06-25  Tom Tromey  <tom@tromey.com>
8852
8853         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8854         (tui_source_window_base::make_visible): New methods.
8855         (make_all_visible): Make method call.
8856         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8857         (struct tui_source_window_base, struct tui_cmd_window): Override
8858         make_visible.
8859         (tui_win_is_source_type): Don't declare.
8860         * tui/tui-data.c (tui_win_is_source_type): Remove.
8861
8862 2019-06-25  Tom Tromey  <tom@tromey.com>
8863
8864         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8865         NULL check.
8866
8867 2019-06-25  Tom Tromey  <tom@tromey.com>
8868
8869         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8870         Inline constructor.  Add initializers for members.
8871         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8872         constructors; now inline in class.
8873
8874 2019-06-25  Tom Tromey  <tom@tromey.com>
8875
8876         * tui/tui-regs.c (tui_show_registers): Update.
8877         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8878         bool.
8879         * tui/tui-data.c (tui_data_window::clear_detail)
8880         (tui_data_window): Update.
8881
8882 2019-06-25  Tom Tromey  <tom@tromey.com>
8883
8884         * tui/tui-windata.c (tui_display_all_data)
8885         (tui_display_data_from_line, tui_display_data_from)
8886         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8887         Update.
8888         * tui/tui-regs.c (tui_last_regs_line_no)
8889         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8890         (tui_show_registers, tui_show_register_group)
8891         (tui_display_registers_from, tui_display_reg_element_at_line)
8892         (tui_display_registers_from_line, tui_check_register_values)
8893         (tui_reg_next, tui_reg_prev): Update.
8894         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8895         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8896         tui_data_window.
8897         (struct tui_win_info) <detail>: Remove.  Add new fields from
8898         tui_data_info.
8899         (TUI_DATA_WIN): Add cast.
8900         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8901         (~tui_data_window): Simplify.
8902
8903 2019-06-25  Tom Tromey  <tom@tromey.com>
8904
8905         * tui/tui-layout.c (show_source_disasm_command)
8906         (show_source_or_disasm_and_command): Update.
8907         * tui/tui-io.c (update_cmdwin_start_line)
8908         (tui_redisplay_readline): Update.
8909         * tui/tui-data.h (struct tui_command_info): Remove.
8910         (struct tui_win_info) <detail>: Remove command_info member.
8911         (struct tui_data_window) <start_line>: New member, from
8912         tui_command_info.
8913         (TUI_CMD_WIN): Add casts.
8914
8915 2019-06-25  Tom Tromey  <tom@tromey.com>
8916
8917         * tui/tui-winsource.c (tui_update_source_window)
8918         (tui_refill_source_window)
8919         (tui_source_window_base::do_scroll_horizontal)
8920         (tui_update_breakpoint_info, tui_set_exec_info_content)
8921         (tui_show_exec_info_content, tui_erase_exec_info_content)
8922         (tui_clear_exec_info_content): Update.
8923         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8924         Update.
8925         * tui/tui-win.c (make_invisible_and_set_new_height)
8926         (make_visible_with_new_height): Update.
8927         * tui/tui-source.c (tui_set_source_content)
8928         (tui_show_symtab_source): Update.
8929         * tui/tui-layout.c (extract_display_start_addr)
8930         (show_source_disasm_command, show_data)
8931         (make_source_or_disasm_window)
8932         (show_source_or_disasm_and_command): Update.
8933         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8934         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8935         "gdbarch".
8936         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8937         to tui_source_window_base.
8938         (struct tui_win_info) <detail>: Remove source_info member.
8939         (struct tui_source_window_base) <has_locator>: Inline.
8940         Move contents from tui_source_info; rename has_locator member to
8941         m_has_locator.
8942         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8943         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8944         header file.
8945         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8946         Simplify.
8947         (tui_free_all_source_wins_content): Cast to
8948         tui_source_window_base.
8949
8950 2019-06-25  Tom Tromey  <tom@tromey.com>
8951
8952         * tui/tui-win.c (make_invisible_and_set_new_height)
8953         (make_visible_with_new_height): Call has_locator method.
8954         * tui/tui-layout.c (show_source_disasm_command, show_data)
8955         (show_source_or_disasm_and_command): Update for bool change.
8956         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8957         (tui_win_info) <has_locator>: New method.
8958         (struct tui_source_window_base) <has_locator>: New method.
8959         (tui_win_has_locator): Don't declare.
8960         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8961         from tui_win_has_locator.
8962         (tui_source_window_base): Use false, not FALSE.
8963
8964 2019-06-25  Tom Tromey  <tom@tromey.com>
8965
8966         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8967         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8968         clear_detail method directly.
8969         (tui_clear_win_detail): Remove.
8970
8971 2019-06-25  Tom Tromey  <tom@tromey.com>
8972
8973         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8974         "this", not TUI_DISASM_WIN.
8975
8976 2019-06-25  Tom Tromey  <tom@tromey.com>
8977
8978         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8979         declare.
8980         * tui/tui-winsource.c
8981         (tui_source_window_base::do_scroll_horizontal): Rename from
8982         tui_horizontal_source_scroll.
8983         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8984         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8985         from tui_vertical_data_scroll.
8986         * tui/tui-win.h (tui_scroll): Don't declare.
8987         * tui/tui-win.c (tui_win_info::forward_scroll)
8988         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8989         (tui_win_info::right_scroll): Rename and update.
8990         (tui_scroll_forward_command, tui_scroll_backward_command)
8991         (tui_scroll_left_command, tui_scroll_right_command): Update.
8992         (tui_scroll): Remove.
8993         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8994         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8995         from tui_vertical_source_scroll.
8996         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8997         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8998         from tui_vertical_disassem_scroll.
8999         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
9000         do_scroll_horizontal>: New methods.
9001         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
9002         Likewise.
9003         (struct tui_source_window_base): Add do_scroll_horizontal.
9004         (struct tui_source_window, struct tui_disasm_window): Add
9005         do_scroll_vertical.
9006         (struct tui_data_window, struct tui_cmd_window): Add
9007         do_scroll_horizontal and do_scroll_vertical.
9008         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
9009
9010 2019-06-25  Tom Tromey  <tom@tromey.com>
9011
9012         * tui/tui-data.h (struct tui_source_window_base): New struct.
9013         (struct tui_source_window): Derive from tui_source_window_base.
9014         (struct tui_disasm_window): New struct.
9015         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
9016         from tui_source_window::clear_detail.
9017         (tui_source_window_base): Rename from tui_source_window.
9018         (~tui_source_window_base): Rename from ~tui_source_window.
9019         (tui_alloc_win_info): Create a tui_disasm_window.
9020
9021 2019-06-25  Tom Tromey  <tom@tromey.com>
9022
9023         * tui/tui-data.h (struct tui_source_window)
9024         (struct tui_data_window): Declare destructors.
9025         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
9026         destructors.
9027         (tui_win_info): Simplify.
9028
9029 2019-06-25  Tom Tromey  <tom@tromey.com>
9030
9031         * tui/tui-winsource.c (tui_display_main)
9032         (tui_update_source_windows_with_addr)
9033         (tui_update_all_breakpoint_info): Update.
9034         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
9035         (new_height_ok, parse_scrolling_args): Update.
9036         * tui/tui-stack.c (tui_show_frame_info): Update.
9037         * tui/tui-data.h (struct tui_list): Remove.
9038         (tui_source_windows): Return a reference to a std::vector.
9039         * tui/tui-data.c (source_windows): Now a std::vector.
9040         (tui_source_windows): Change return type.
9041         (tui_clear_source_windows): Rewrite.
9042         (tui_clear_source_windows_detail, tui_add_to_source_windows)
9043         (tui_free_all_source_wins_content): Rewrite.
9044
9045 2019-06-25  Tom Tromey  <tom@tromey.com>
9046
9047         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
9048         (struct tui_data_window, struct tui_cmd_window): Declare
9049         clear_detail method.
9050         * tui/tui-data.c (tui_source_window::clear_detail)
9051         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
9052         methods.
9053         (tui_clear_win_detail): Simplify.
9054
9055 2019-06-25  Tom Tromey  <tom@tromey.com>
9056
9057         * tui/tui-layout.c (make_source_window, make_disasm_window)
9058         (make_source_or_disasm_window): Remove win_info_ptr parameter.
9059         Return the new window.
9060         (show_source_disasm_command, show_data)
9061         (show_source_or_disasm_and_command): Update.
9062
9063 2019-06-25  Tom Tromey  <tom@tromey.com>
9064
9065         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9066         parameter.  Return the new window.
9067         (show_source_disasm_command): Update and remove NULL check.
9068         (show_source_or_disasm_and_command): Update.
9069
9070 2019-06-25  Tom Tromey  <tom@tromey.com>
9071
9072         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9073
9074 2019-06-25  Tom Tromey  <tom@tromey.com>
9075
9076         * tui/tui-data.h (struct tui_win_info): Make constructor
9077         protected.  Make destructor virtual.  Add initializers.
9078         (tui_source_window, tui_data_window, tui_cmd_window): New
9079         classes.
9080         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
9081         constructor.  Add "type" parameter.
9082         (tui_source_window, tui_data_window, tui_cmd_window): New
9083         constructors.
9084         (tui_alloc_win_info): Instantiate the appropriate subclass.
9085
9086 2019-06-25  Tom Tromey  <tom@tromey.com>
9087
9088         * tui/tui-win.c (tui_resize_all): Use delete.
9089         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9090         destructor.
9091         (tui_free_window): Don't declare.
9092         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9093         Update.
9094
9095 2019-06-25  Tom Tromey  <tom@tromey.com>
9096
9097         * tui/tui-data.h (struct tui_win_info): Add constructor.
9098         * tui/tui-data.c (tui_alloc_win_info): Use new.
9099         (tui_free_window): Use delete.
9100
9101 2019-06-22  Tom Tromey  <tom@tromey.com>
9102
9103         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9104         declare.
9105         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9106
9107 2019-06-22  Tom Tromey  <tom@tromey.com>
9108
9109         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9110         declare.
9111         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9112
9113 2019-06-22  Tom de Vries  <tdevries@suse.de>
9114
9115         * dwarf2read.c (create_addrmap_from_aranges)
9116         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9117         instead of '%zu'.
9118
9119 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
9120
9121         * dwarf2read.h (dwarf2_section_info_def): Remove.
9122         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9123         * dwarf2read.c (struct dwo_sections) <types>: Change type to
9124         std::vector<dwarf2_section_info>.
9125         (struct dwo_file) <~dwo_file>: Remove.
9126         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9127         types field.
9128         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9129         (dwarf2_read_debug_names): Likewise.
9130         (create_debug_types_hash_table): Change parameter type to
9131         array_view, adjust code accordingly.
9132         (dwarf2_locate_dwo_sections): Adjust to std::vector.
9133         (partial_die_info::fixup): Likewise.
9134         (determine_prefix): Likewise.
9135         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9136
9137 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9138
9139         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9140         gdb_bfd_ref_ptr.
9141         <~dwo_file>: Remove call to gdb_bfd_unref.
9142         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9143         gdb_bfd_ref_ptr::get.
9144
9145 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9146
9147         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9148         type to htab_up.
9149         * dwarf2read.c (struct dwo_file): Initialize fields.
9150         <~dwo_file>: New.
9151         (free_dwo_file): Remove, move content to ~dwo_file.
9152         (struct dwo_file_deleter): Remove.
9153         (dwo_file_up>: Remove custom deleter.
9154         (free_dwo_files): Remove.
9155         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9156         dwo_files.
9157         (process_skeletonless_type_units): Call unique_ptr::get.
9158         (allocate_dwo_file_hash_table): Add deleter to created hash
9159         table.  Change return type to htab_up.
9160         (lookup_dwo_file_slot): Don't memset dwo_file, call
9161         unique_ptr::get.
9162         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9163         (create_dwo_unit_in_dwp_v2): Likewise.
9164         (open_and_init_dwo_file): Likewise.
9165         (free_dwo_file_from_slot): Remove.
9166
9167 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9168
9169         * dwarf2read.h (struct dwarf2_section_info) <readin,
9170         is_virtual>: Change type to bool.
9171         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9172         true instead of 1.
9173
9174 2019-06-19  Tom Tromey  <tom@tromey.com>
9175
9176         * tui/tui-data.h (tui_init_content_element): Don't declare.
9177
9178 2019-06-19  Tom Tromey  <tom@tromey.com>
9179
9180         * tui/tui-data.h (tui_init_win_info): Don't declare.
9181
9182 2019-06-19  Tom de Vries  <tdevries@suse.de>
9183
9184         * dwarf2read.h (abstract_to_concrete): Change type to
9185         std::unordered_map<sect_offset, std::vector<sect_offset>,
9186         gdb::hash_enum<sect_offset>>.
9187
9188 2019-06-19  Tom Tromey  <tromey@adacore.com>
9189
9190         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9191         EVAL_AVOID_SIDE_EFFECTS specially.
9192
9193 2019-06-19  Tom Tromey  <tromey@adacore.com>
9194
9195         * source-cache.c (highlighter): New global.
9196         (source_cache::get_source_lines): Create a highlighter on demand.
9197
9198 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9199
9200         * defs.h (deprecated_interactive_hook): Delete declaration.
9201         * interps.c (clear_interpreter_hooks): Remove use of
9202         deprecated_interactive_hook.
9203         * top.c (deprecated_interactive_hook): Delete definition.
9204         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9205
9206 2019-06-18  Tom de Vries  <tdevries@suse.de>
9207
9208         PR gdb/24515
9209         * dwarf2read.h (abstract_to_concrete): Change type from
9210         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9211         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9212         * dwarf2read.c (read_variable): Update.
9213         (dwarf2_fetch_die_loc_sect_off): Update.
9214
9215 2019-06-17  Tom de Vries  <tdevries@suse.de>
9216
9217         PR gdb/24617
9218         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9219         accessing parent[parent_len - 1].
9220
9221 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9222
9223         PR gdb/24364
9224         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9225         call dtrace_process_dof with NULL dof.
9226
9227 2019-06-16  Tom de Vries  <tdevries@suse.de>
9228
9229         PR gdb/24445
9230         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9231
9232 2019-06-16  Tom Tromey  <tom@tromey.com>
9233
9234         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9235         (make_all_visible): Use address of member.
9236
9237 2019-06-16  Tom Tromey  <tom@tromey.com>
9238
9239         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9240         (tui_free_window, free_content, free_content_elements): Remove
9241         unnecessary cast.
9242         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9243         cast.
9244         * tui/tui-regs.c (tui_show_register_group)
9245         (tui_display_registers_from, tui_display_reg_element_at_line):
9246         Remove unnecessary cast.
9247
9248 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9249
9250         * linux-nat.c (normal_mask): Delete.
9251         (_initialize_linux_nat): Don't initialise normal_mask.
9252
9253 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9254
9255         PR gdb/24445
9256         * dwarf-index-write.h (write_psymtabs_to_index): Add
9257         dwz_basename parameter.
9258         * dwarf-index-write.c (write_gdbindex): Move file writing to
9259         write_gdbindex_1.  Change return type void.
9260         (assert_file_size): Move up, remove filename parameter.
9261         (write_gdbindex_1): New function.
9262         (write_debug_names): Change return type to void, call
9263         assert_file_size.
9264         (struct index_wip_file): New struct.
9265         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9266         file logic to index_wip_file.  Write index for dwz file if
9267         needed.
9268         (save_gdb_index_command): Pass basename of dwz file, if present.
9269         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9270         build-id of dwz file, if present.
9271         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9272         (dwarf2_get_dwz_file): Likewise.
9273         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9274         (dwarf2_get_dwz_file): Likewise.
9275
9276 2019-06-16  Tom Tromey  <tom@tromey.com>
9277
9278         * coffread.c (process_coff_symbol): Use xstrdup.
9279         * value.c (create_internalvar): Use xstrdup.
9280
9281 2019-06-16  Tom Tromey  <tom@tromey.com>
9282
9283         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9284         * breakpoint.c (stopin_command, stopat_command)
9285         (until_break_command, decode_location_default): Remove unnecessary
9286         cast.
9287         * utils.c (subset_compare): Remove unnecessary cast.
9288         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9289         cast.
9290         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9291         cast.
9292         * infcmd.c (path_command): Remove unnecessary cast.
9293         * coffread.c (decode_type): Remove unnecessary cast.
9294         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9295         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9296         * tui/tui-stack.c (tui_show_locator_content)
9297         (tui_show_frame_info): Remove unnecessary cast.
9298         * tui/tui-win.c (tui_scroll_forward_command)
9299         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9300         (parse_scrolling_args): Remove unnecessary cast.
9301         * tui/tui-data.c (init_win_info, tui_del_window)
9302         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9303         (free_content_elements): Remove unnecessary cast.
9304         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9305         unnecessary cast.
9306         * tui/tui-source.c (tui_set_source_content)
9307         (tui_vertical_source_scroll): Remove unnecessary cast.
9308         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9309         cast.
9310         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9311         * tui/tui-regs.c (tui_display_registers_from)
9312         (tui_display_register): Remove unnecessary cast.
9313         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9314         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9315         (make_visible): Remove unnecessary cast.
9316         * tui/tui-winsource.c (tui_erase_source_content)
9317         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9318         unnecessary cast.
9319         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9320         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9321         * stabsread.c (read_type, read_array_type, read_range_type):
9322         Remove unnecessary cast.
9323         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9324         (parse_symbol, parse_type, upgrade_type, parse_external)
9325         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9326         unnecessary cast.
9327         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9328
9329 2019-06-16  Tom Tromey  <tom@tromey.com>
9330
9331         * tui/tui-data.c (tui_alloc_generic_win_info)
9332         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9333         checks.
9334
9335 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9336             Andrew Burgess  <andrew.burgess@embecosm.com>
9337
9338         * f-typeprint.c (f_print_type): Don't return early for not
9339         associated or not allocated types.
9340         (f_type_print_varspec_suffix): Add print_rank parameter and print
9341         ranks of array types in case they dangling.
9342         (f_type_print_base): Add print_rank parameter.
9343
9344 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9345
9346         * NEWS: Mention new MI commands.
9347         * break-catch-throw.c (enum exception_event_kind): Move to
9348         breakpoint.h.
9349         (print_mention_exception_catchpoint): Output text as a single
9350         message.
9351         (catch_exception_command_1): Rename to...
9352         (catch_exception_event): ...this, make non-static, update header
9353         command, and change some parameter types.
9354         (catch_catch_command): Update for changes to
9355         catch_exception_command_1.
9356         (catch_throw_command): Likewise.
9357         (catch_rethrow_command): Likewise.
9358         * breakpoint.c (enum exception_event_kind): Delete.
9359         * breakpoint.h (enum exception_event_kind): Moved here from
9360         break-catch-throw.c.
9361         (catch_exception_event): Declare.
9362         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9363         (mi_cmd_catch_throw): New function.
9364         (mi_cmd_catch_rethrow): New function.
9365         (mi_cmd_catch_catch): New function.
9366         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9367         'catch-catch' entries.
9368         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9369         (mi_cmd_catch_rethrow): Declare.
9370         (mi_cmd_catch_catch): Declare.
9371
9372 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9373
9374         * annotate.c (annotate_source_line): Change return type to void,
9375         update implementation to match.
9376         * annotate.h (annotate_source_line): Change return type to void,
9377         update header comment.
9378         * stack.c (print_frame_info): Don't change what frame information
9379         is printed based on whether annotations are on or not.
9380
9381 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9382
9383         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9384         (annotate_source): Make static.
9385         (annotate_source_line): Moved from source.c and renamed from
9386         identify_source_line.  Update the return type.
9387         * annotate.h (annotate_source): Delete declaration.
9388         (annotate_source_line): Declaration moved from source.h, and
9389         renamed from identify_source_line.  Return type updated.
9390         * source.c (identify_source_line): Moved to annotate.c and renamed
9391         to annotate_source_line.
9392         (info_line_command): Remove check of annotation_level.
9393         * source.h (identify_source_line): Move declaration to annotate.h
9394         and rename to annotate_source_line.
9395         * stack.c: Add 'annotate.h' include.
9396         (print_frame_info): Remove check of annotation_level before
9397         calling annotate_source_line.
9398
9399 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9400
9401         * source-cache.c (source_cache::get_plain_source_lines): Use
9402         open_source_file_with_line_charpos instead of just
9403         open_source_file, remove call to find_source_lines.
9404         (source_cache::get_source_lines): Likewise.
9405         * source.c (find_source_lines): Make static.
9406         (get_filename_and_charpos): Renamed into...
9407         (open_source_file_with_line_charpos): ..this along with changes to
9408         return a scoped_fd, and some other minor clean ups.
9409         (identify_source_line): Use open_source_file_with_line_charpos.
9410         (search_command_helper): Use open_source_file_with_line_charpos
9411         instead of just open_source_file, remove call to
9412         find_source_lines.
9413         * source.h (open_source_file_with_line_charpos): Declare new
9414         function.
9415         (find_source_lines): Delete declaration.
9416
9417 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9418
9419         * source.c (get_filename_and_charpos): Remove fullname
9420         parameter.
9421         (identify_source_line): Update call to get_filename_and_charpos.
9422
9423 2019-06-14  Tom Tromey  <tromey@adacore.com>
9424
9425         PR gdb/24502:
9426         * ui-style.h (skip_ansi_escape): Update comment.
9427         * ui-file.h (class no_terminal_escape_file): New class.
9428         * ui-file.c (no_terminal_escape_file::write)
9429         (no_terminal_escape_file::puts): New methods.
9430         * cli/cli-logging.c (handle_redirections): Use
9431         no_terminal_escape_file.
9432
9433 2019-06-14  Tom Tromey  <tromey@adacore.com>
9434
9435         * NEWS: Move convenience variable news above Python news.
9436
9437 2019-06-14  Tom Tromey  <tom@tromey.com>
9438
9439         * gnulib: Move directory to top-level.
9440         * configure.ac: Don't configure gnulib.
9441         * configure: Rebuild.
9442         * common/common-defs.h: Use new path to gnulib.
9443         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9444         (GNULIB_H): Remove.
9445         (INCGNU): Look in new gnulib location.
9446         (HFILES_NO_SRCDIR): Remove gnulib files.
9447         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9448         (generated_files): Remove GNULIB_H.
9449         ($(LIBGNU), all-lib): Remove targets.
9450         (distclean): Don't mention GNULIB_BUILDDIR.
9451         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9452
9453 2019-06-14  Tom Tromey  <tromey@adacore.com>
9454
9455         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9456         Warn if symbol file does not provide any symbols.
9457
9458 2019-06-14  Tom Tromey  <tromey@adacore.com>
9459
9460         * source.c (find_and_open_source): Respect basenames_may_differ.
9461
9462 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9463
9464         * annotate.c (annotate_breakpoints_invalid): Make use of
9465         scoped_restore_terminal_state.
9466         (annotate_frames_invalid): Likewise.
9467
9468 2019-06-14  Tom Tromey  <tromey@adacore.com>
9469
9470         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9471         allow assignment to an internalvar.
9472
9473 2019-06-14  Tom Tromey  <tromey@adacore.com>
9474
9475         * ada-lex.l: Allow "_" in attribute names.
9476
9477 2019-06-14  Tom Tromey  <tromey@adacore.com>
9478
9479         PR gdb/24653:
9480         * regcache.c (registers_changed): Don't call alloca.
9481         * top.c (execute_command): Don't call alloca.
9482
9483 2019-06-13  Pedro Alves  <palves@redhat.com>
9484
9485         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9486         'expression'.  When parsing an expression, error out if there's
9487         junk after "unlimited".
9488         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9489         (do_set_command): Adjust calls to is_unlimited_literal.
9490
9491 2019-06-13  Pedro Alves  <palves@redhat.com>
9492
9493         * compile/compile.c (make_compile_options_def_group): Add braces
9494         around array_view initializer.
9495         * thread.c (make_thread_apply_all_options_def_group)
9496         (make_thread_apply_all_options_def_group): Likewise.
9497
9498 2019-06-13  Pedro Alves  <palves@redhat.com>
9499
9500         * NEWS (New commands): Mention "maint test-options
9501         require-delimiter", "maint test-options unknown-is-error", "maint
9502         test-options unknown-is-operand" and "maint show
9503         test-options-completion-result".
9504         (New command options, command completion): New section.
9505         (Completion improvements): New section.
9506         Mention that you can abbreviate "unlimited".
9507
9508 2019-06-13  Pedro Alves  <palves@redhat.com>
9509
9510         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9511         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9512         * unittests/cli-utils-selftests.c (test_parse_flags)
9513         (test_parse_flags_qcs): Delete.
9514         (test_cli_utils): Don't call deleted functions.
9515
9516 2019-06-13  Pedro Alves  <palves@redhat.com>
9517
9518         * thread.c: Include "cli/cli-option.h".
9519         (tp_array_compar_ascending): Global.
9520         (tp_array_compar): Delete function.
9521         (tp_array_compar_ascending, tp_array_compar_descending): New
9522         functions.
9523         (ascending_option_def, qcs_flag_option_def)
9524         (thr_qcs_flags_option_defs)
9525         (make_thread_apply_all_options_def_group)
9526         (make_thread_apply_options_def_group): New.
9527         (thread_apply_all_command): Use gdb::option::process_options.
9528         (thread_apply_command_completer)
9529         (thread_apply_all_command_completer): New.
9530         (thread_apply_command): Use gdb::option::process_options.
9531         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9532         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9533         to generate help text of "thread apply".  Adjust "taas"'s help.
9534         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9535         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9536
9537 2019-06-13  Pedro Alves  <palves@redhat.com>
9538
9539         * thread.c (thread_apply_command): Check for invalid TID with
9540         isdigit instead of !isalpha.
9541
9542 2019-06-13  Pedro Alves  <palves@redhat.com>
9543
9544         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9545         (validate_flags_qcs): New.
9546         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9547         (validate_flags_qcs): Declare.
9548         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9549         (make_frame_apply_options_def_group): New.
9550         (frame_apply_command_count): Process options with
9551         gdb::option::process_options.
9552         (frame_apply_completer): New.
9553         (frame_apply_level_completer, frame_apply_all_completer)
9554         (frame_apply_completer): New.
9555         (_initialize_stack): Update help of "frame apply", "frame apply
9556         level", "frame apply all" and "faas" to mention supported options
9557         and install command completers.
9558         * stack.h (frame_apply_all_completer): Declare.
9559         * thread.c: Include "stack.h".
9560         (tfaas_command): Add "--".
9561         (_initialize_thread): Update help "tfaas" to mention supported
9562         options and install command completer.
9563
9564 2019-06-13  Pedro Alves  <palves@redhat.com>
9565
9566         * completer.c (complete_nested_command_line): New.
9567         (gdb_completion_word_break_characters_throw): Add assertion.
9568         * completer.h (complete_nested_command_line): Declare.
9569
9570 2019-06-13  Pedro Alves  <palves@redhat.com>
9571
9572         * stack.c (parse_backtrace_qualifiers): New.
9573         (backtrace_command): Use it.
9574         (backtrace_command_completer): Complete on qualifiers.
9575
9576 2019-06-13  Pedro Alves  <palves@redhat.com>
9577
9578         * frame.c: Include "cli/cli-option.h.
9579         (user_set_backtrace_options): New.
9580         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9581         Delete.
9582         (get_prev_frame): Adjust.
9583         (boolean_option_def, uinteger_option_def)
9584         (set_backtrace_option_defs): New.
9585         (_initialize_frame): Adjust and use
9586         gdb::option::add_setshow_cmds_for_options to install "set
9587         backtrace past-main" and "set backtrace past-entry".
9588         * frame.h: Include "cli/cli-option.h".
9589         (struct frame_print_options): Forward declare.
9590         (print_frame_arguments_all, print_frame_arguments_scalars)
9591         (print_frame_arguments_none): Declare.
9592         (print_entry_values): Delete declaration.
9593         (struct frame_print_options, user_frame_print_options): New.
9594         (struct set_backtrace_options): New.
9595         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9596         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9597         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9598         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9599         (list_args_or_locals): Add frame_print_options parameter.
9600         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9601         * python/py-framefilter.c (enumerate_args): Pass down
9602         USER_FRAME_PRINT_OPTIONS.
9603         * stack.c: Include "cli/cli-option.h".
9604         (print_frame_arguments_all, print_frame_arguments_scalars)
9605         (print_frame_arguments_none): Declare.
9606         (print_raw_frame_arguments, print_entry_values): Delete.
9607         (user_frame_print_options): New.
9608         (boolean_option_def, enum_option_def, frame_print_option_defs):
9609         New.
9610         (struct backtrace_cmd_options): New.
9611         (bt_flag_option_def): New.
9612         (backtrace_command_option_defs): New.
9613         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9614         (print_frame_arg, read_frame_arg, print_frame_args)
9615         (print_frame_info, print_frame): Add frame_print_options parameter
9616         and use it.
9617         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9618         (backtrace_command_1): Add frame_print_options and
9619         backtrace_cmd_options parameters and use them.
9620         (make_backtrace_options_def_group): New.
9621         (backtrace_command): Process command options with
9622         gdb::option::process_options.
9623         (backtrace_command_completer): New.
9624         (_initialize_stack): Extend "backtrace"'s help to mention
9625         supported options.  Install completer for "backtrace".
9626         Install some settings commands with add_setshow_cmds_for_options.
9627
9628 2019-06-13  Pedro Alves  <palves@redhat.com>
9629
9630         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9631         and that "set/show print raw frame-arguments" are now deprecated.
9632
9633         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9634         command.
9635         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9636         * stack.c (_initialize_stack): Install "set/show print
9637         raw-frame-arguments", and deprecate "set/show print raw
9638         frame-arguments".
9639         * valprint.c (_initialize_valprint): Deprecate "set/show print
9640         raw".
9641
9642 2019-06-13  Pedro Alves  <palves@redhat.com>
9643
9644         * compile/compile.c (struct compile_options): New.
9645         (compile_flag_option_def, compile_command_option_defs)
9646         (make_compile_options_def_group): New.
9647         (compile_file_command): Handle options with
9648         gdb::option::process_options.
9649         (compile_file_command_completer): New function.
9650         (compile_code_command): Handle options with
9651         gdb::option::process_options.
9652         (compile_code_command_completer): New function.
9653         (_initialize_compiler): Install completers for "compile code" and
9654         "compile file".  Mention available options in "compile code" and
9655         "compile code"'s help.
9656         * completer.c (advance_to_completion_word): New, factored out from
9657         ...
9658         (advance_to_expression_complete_word_point): ... this.
9659         (advance_to_filename_complete_word_point): New.
9660         * completer.h (advance_to_filename_complete_word_point): New
9661         declaration.
9662
9663 2019-06-13  Pedro Alves  <palves@redhat.com>
9664
9665         * compile/compile.c: Include "cli/cli-option.h".
9666         (compile_print_value): Scope data pointer is now a
9667         value_print_options pointer; adjust.
9668         (compile_print_command): Process options.  Scope data pointer is
9669         now a value_print_options pointer; adjust.
9670         (_initialize_compile): Update "compile print"'s help to include
9671         supported options.  Install a completer for "compile print".
9672         * cp-valprint.c (show_vtblprint, show_objectprint)
9673         (show_static_field_print): Delete.
9674         (_initialize_cp_valprint): Don't install "set print
9675         static-members", "set print vtbl", "set print object" here.
9676         * printcmd.c: Include "cli/cli-option.h" and
9677         "common/gdb_optional.h".
9678         (print_command_parse_format): Rework to fill in a
9679         value_print_options instead of a format_data.
9680         (print_value): Change parameter type from format_data pointer to
9681         value_print_options reference.  Adjust.
9682         (print_command_1): Process options.  Adjust to pass down a
9683         value_print_options.
9684         (print_command_completer): New.
9685         (_initialize_printcmd): Install print_command_completer as
9686         handle_brkchars completer for the "print" command.  Update
9687         "print"'s help to include supported options.
9688         * valprint.c: Include "cli/cli-option.h".
9689         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9690         here from cp-valprint.c.
9691         (boolean_option_def, uinteger_option_def)
9692         (value_print_option_defs, make_value_print_options_def_group):
9693         New.  Use gdb::option::add_setshow_cmds_for_options to install
9694         "set print elements", "set print null-stop", "set print repeats",
9695         "set print pretty", "set print union", "set print array", "set
9696         print address", "set print symbol", "set print array-indexes".
9697         * valprint.h: Include <string> and "cli/cli-option.h".
9698         (make_value_print_options_def_group): Declare.
9699         (print_value): Change parameter type from format_data pointer to
9700         value_print_options reference.
9701         (print_command_completer): Declare.
9702
9703 2019-06-13  Pedro Alves  <palves@redhat.com>
9704
9705         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9706         (COMMON_SFILES): Add maint-test-settings.c.
9707         * cli/cli-decode.c (boolean_enums): New global, factored out from
9708         ...
9709         (add_setshow_boolean_cmd): ... here.
9710         * cli/cli-decode.h (boolean_enums): Declare.
9711         * cli/cli-option.c: New file.
9712         * cli/cli-option.h: New file.
9713         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9714         factored out from ...
9715         (parse_cli_boolean_value(const char *)): ... this.
9716         (is_unlimited_literal): Change parameter type to pointer to
9717         pointer.  Adjust and advance ARG pointer.
9718         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9719         (parse_cli_var_enum): New, factored out from ...
9720         (do_set_command): ... this.  Adjust.
9721         * cli/cli-setshow.h (parse_cli_boolean_value)
9722         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9723         (parse_cli_var_enum): Declare.
9724         * cli/cli-utils.c: Include "cli/cli-option.h".
9725         (get_ulongest): New.
9726         * cli/cli-utils.h (get_ulongest): Declare.
9727         (check_for_argument): New overloads.
9728         * maint-test-options.c: New file.
9729
9730 2019-06-13  Pedro Alves  <palves@redhat.com>
9731
9732         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9733         parse a range if "-" is at the end of the string.
9734
9735 2019-06-13  Pedro Alves  <palves@redhat.com>
9736
9737         * cli/cli-setshow.c (parse_auto_binary_operation)
9738         (parse_cli_boolean_value): Don't allow "o".
9739
9740 2019-06-13  Pedro Alves  <palves@redhat.com>
9741
9742         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9743         * NEWS: Mention maint test-settings KIND.
9744         * maint-test-settings.c: New file.
9745
9746 2019-06-13  Pedro Alves  <palves@redhat.com>
9747
9748         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9749         completer.
9750         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9751         "set" completers.
9752
9753 2019-06-13  Pedro Alves  <palves@redhat.com>
9754
9755         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9756         after item.
9757
9758 2019-06-13  Pedro Alves  <palves@redhat.com>
9759
9760         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9761
9762 2019-06-13  Pedro Alves <palves@redhat.com>
9763
9764         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9765         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9766         call.
9767         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9768         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9769         calls.
9770         (check_for_argument): Skip spaces after argument.
9771
9772 2019-06-13  Pedro Alves  <palves@redhat.com>
9773
9774         * thread.c (thread_apply_command): Adjust TID parsing.
9775         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9776         detected before end of string.
9777         (tid_is_in_list): Error out if LIST is invalid.
9778
9779 2019-06-13  Pedro Alves  <palves@redhat.com>
9780
9781         * completer.c (complete_line_internal_1): Rewind completion word
9782         point.
9783         (completion_tracker::advance_custom_word_point_by): Change
9784         parameter type to int.
9785         * completer.h (completion_tracker::advance_custom_word_point_by):
9786         Likewise.
9787
9788 2019-06-13  Pedro Alves  <palves@redhat.com>
9789
9790         * completer.c (advance_to_completion_word): Handle delimiters.
9791
9792 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9793
9794         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9795
9796 2019-06-11  Tom Tromey  <tom@tromey.com>
9797
9798         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9799         (xmalloc_failed): Move to alloc.c.
9800         * alloc.c: New file.
9801         * Makefile.in (COMMON_SFILES): Add alloc.c.
9802
9803 2019-06-11  Tom Tromey  <tom@tromey.com>
9804
9805         * nat/linux-waitpid.c: Don't include server.h.
9806         (linux_debug): Remove.
9807         (my_waitpid): Update.
9808
9809 2019-06-11  Tom Tromey  <tromey@adacore.com>
9810
9811         * infcall.c (_initialize_infcall): Remove trailing newline from
9812         help.
9813         * user-regs.c (_initialize_user_regs): Remove trailing newline
9814         from help.
9815         * typeprint.c (_initialize_typeprint): Remove trailing newline
9816         from help.
9817         * reverse.c (_initialize_reverse): Remove trailing newlines from
9818         help.
9819         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9820         from help.
9821         * language.c (add_set_language_command): Remove trailing newline
9822         from help.
9823         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9824         help.
9825         * disasm.c (_initialize_disasm): Remove trailing newline from
9826         help.
9827         * top.c (init_main): Remove trailing newline from help.
9828         * interps.c (_initialize_interpreter): Remove trailing newline
9829         from help.
9830         * btrace.c (_initialize_btrace): Remove trailing newlines from
9831         help.
9832         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9833         from help.
9834         * python/python.c (_initialize_python): Remove trailing newline
9835         from help.
9836         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9837         help.
9838         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9839         from help.  Reformat some text.
9840         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9841         from help.
9842         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9843         newline from help.
9844
9845 2019-06-11  Tom Tromey  <tromey@adacore.com>
9846
9847         * darwin-nat.c (darwin_decode_exception_message)
9848         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9849
9850 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9851
9852         * valops.c (value_slice): Check for not allocated or not
9853         associated values.
9854
9855 2019-06-10  Tom de Vries  <tdevries@suse.de>
9856
9857         PR gdb/24618
9858         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9859         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9860         invalid.
9861
9862 2019-06-10  Tom de Vries  <tdevries@suse.de>
9863
9864         PR gdb/24611
9865         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9866         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9867
9868 2019-06-10  Tom de Vries  <tdevries@suse.de>
9869
9870         PR symtab/24545
9871         * symtab.c (struct demangled_name_entry): Add language field.
9872         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9873         static minimal symbol".  Set and use language field.
9874
9875 2019-06-10  Tom Tromey  <tromey@adacore.com>
9876
9877         * ada-lang.c (_initialize_ada_language): Update help text.
9878
9879 2019-06-10  Tom Tromey  <tromey@adacore.com>
9880
9881         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9882         with a newline.
9883         * guile/guile.c (handle_boot_error): Don't end warning with a
9884         newline.
9885         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9886         warning with a newline.
9887         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9888         newline.
9889         (s12z_frame_cache): Likewise.
9890         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9891         a newline.
9892         * solib-svr4.c (disable_probes_interface): Don't end warning with
9893         a newline.
9894         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9895         newline.
9896         * python/python.c (do_finish_initialization): Don't end warning
9897         with a newline.
9898
9899 2019-06-10  Tom Tromey  <tom@tromey.com>
9900
9901         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9902         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9903         gdbpy_enter.
9904
9905 2019-06-10  Tom Tromey  <tromey@adacore.com>
9906
9907         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9908         data.
9909         (elf_new_init): Don't call stabsread_new_init.
9910         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9911         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9912         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9913
9914 2019-06-10  Tom de Vries  <tdevries@suse.de>
9915
9916         PR symtab/16264
9917         PR symtab/24517
9918         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9919
9920 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9921
9922         * source.c (find_and_open_source): Also rewrite relative file
9923         names.
9924
9925 2019-04-26  Amos Bird  <amosbird@gmail.com>
9926
9927         * annotate.c (annotate_thread_exited): Add "thread-exited"
9928         annotation.
9929
9930 2019-06-06  Tom Tromey  <tromey@adacore.com>
9931
9932         * maint.h (class scoped_command_stats): Use
9933         DISABLE_COPY_AND_ASSIGN.
9934         <print_time>: New method.
9935         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9936         print_time.
9937         (scoped_command_stats::print_time): New method.
9938
9939 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9940
9941         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9942         instructions of lengths 6 or 8 bytes.
9943
9944 2019-06-04  Pedro Alves  <palves@redhat.com>
9945
9946         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9947
9948         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9949         * breakpoint.c (condition_completer): Likewise.
9950         * cli/cli-dump.c (scan_expression): Likewise.
9951         * common/filestuff.c (mkdir_recursive): Likewise.
9952         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9953         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9954         (gdb_abspath): Likewise.
9955         * compile/compile-cplus-types.c
9956         (compile_cplus_instance::decl_name): Likewise.
9957         * completer.c (complete_explicit_location):
9958         (signal_completer, reg_or_group_completer_1): Likewise.
9959         * cp-support.c (cp_remove_params_if_any): Likewise.
9960         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9961         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9962         * infcmd.c (strip_bg_char): Likewise.
9963         * linespec.c (copy_token_string): Likewise.
9964         * mi/mi-main.c (output_cores): Likewise.
9965         * psymtab.c (psymtab_search_name):
9966         * symfile.c (test_set_ext_lang_command): Likewise.
9967         * target.c (target_fileio_read_stralloc): Likewise.
9968         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9969         * value.c (complete_internalvar): Likewise.
9970
9971 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9972
9973         Add objfile property to gdb.Type.
9974         * NEWS: Mention Python API addition.
9975         * python/py-type.c (typy_get_objfile): New method.
9976
9977 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9978
9979         * NEWS: Mention the new set|show style [title|highlight].
9980         Mention changes to "show style", "help" and "apropos".
9981
9982 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9983
9984         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9985         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9986         instead of print_help_for_command.
9987         (print_doc_of_command): New function.
9988         (help_list): Add 'apropos -v word' suggestion.
9989         (print_help_for_command): Style the command name using title style.
9990         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9991         (_initialize_cli_cmds): Describe -v in apropos_command help.
9992
9993 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9994
9995         * cli/cli-style.h (cli_style_option): Add name in constructor,
9996         add m_name class member, add constructor with intensity,
9997         add name class function.
9998         (cli_style_option::add_setshow_commands): Remove name argument.
9999         (highlight_style, title_style): New styles.
10000         * cli/cli-style.c (do_show): New function that shows a style
10001         characteristic styling the style name with itself.
10002         (set_style_name): New function.
10003         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
10004         Update all callers according to the changes in cli/cli-style.h.
10005         * utils.h (fputs_highlighted): New function.
10006         * utils.c (fputs_highlighted): Likewise.
10007
10008 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10009
10010         * NEWS: Mention new pipe command and new convenience variables.
10011
10012 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10013
10014         * cli/cli-cmds.c (pipe_command): New function.
10015         (_initialize_cli_cmds): Call add_com for pipe_command.
10016         Define | as an alias for pipe.
10017         (exit_status_set_internal_vars): New function.
10018         (shell_escape): Call exit_status_set_internal_vars.
10019         cli/cli-decode.c (find_command_name_length): Recognize | as
10020         a single character command.
10021
10022 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10023
10024         * gdbcmd.h (execute_command_to_ui_file): New declaration.
10025         top.c (execute_command_to_ui_file): New function, mostly a copy
10026         of execute_command_to_string.
10027         (execute_command_to_string): Implement by calling
10028         execute_command_to_ui_file.
10029
10030 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10031
10032         * top.h (saved_command_line): Remove declaration.
10033         * top.c (previous_saved_command_line, previous_repeat_arguments):
10034         New variables.
10035         (saved_command_line): Make static, define together with other
10036         'repeat variables'.
10037         (dont_repeat): Clear repeat_arguments.
10038         (repeat_previous, get_saved_command_line, save_command_line):
10039         New functions.
10040         (gdb_init): Initialize saved_command_line
10041         and previous_saved_command_line.
10042         * main.c (captured_main_1): Remove saved_command_line initialization.
10043         * event-top.c (handle_line_of_input): Update to use
10044         the new 'repeat' related functions instead of direct access to
10045         saved_command_line.
10046         * command.h (repeat_previous, get_saved_command_line,
10047         save_command_line): New declarations.
10048         (dont_repeat): Add comment.
10049
10050 2019-05-30  Tom Tromey  <tromey@adacore.com>
10051
10052         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
10053         Fix comment.
10054         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
10055
10056 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
10057
10058         PR cli/24587
10059         * completer.c (complete): Initialize variable word.
10060
10061 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
10062
10063         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10064         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10065         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10066         'body' is NULL to the outter 'if', protecting the '!is_define'
10067         situation as well.
10068
10069 2019-05-29  Tom Tromey  <tromey@adacore.com>
10070
10071         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10072         (dwarf_unknown): New function.
10073         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10074         (dwarf_type_encoding_name): Use dwarf_unknown.
10075
10076 2019-05-29  Tom Tromey  <tromey@adacore.com>
10077
10078         PR c++/20020:
10079         * cp-valprint.c (cp_print_value_fields): Call
10080         cp_print_static_field inside "try".
10081
10082 2019-05-29  Tom Tromey  <tromey@adacore.com>
10083
10084         * inflow.c (struct terminal_info): Add default operator=.
10085         * configure: Rebuild.
10086         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10087         -Wdeprecated-copy-dtor, -Wredundant-move.
10088
10089 2019-05-29  Tom Tromey  <tromey@adacore.com>
10090
10091         * NEWS: Add entry.
10092         * infcmd.c (print_return_value_1): Handle finish_print
10093         option.
10094         (show_print_finish): New function.
10095         (_initialize_infcmd): Add "set/show print finish" commands.
10096         * valprint.c (user_print_options): Initialize new member.
10097         * valprint.h (struct value_print_options) <finish_print>: New
10098         member.
10099
10100 2019-05-28  Tom Tromey  <tromey@adacore.com>
10101
10102         * ada-lang.c (ada_remove_Xbn_suffix)
10103         (find_old_style_renaming_symbol)
10104         (parse_old_style_renaming): Remove.
10105         (ada_find_renaming_symbol): Don't call
10106         find_old_style_renaming_symbol.
10107         (ada_is_renaming_symbol): Rename from
10108         ada_find_renaming_symbol.  Remove "block" parameter.  Return
10109         bool.  Now static.
10110         (ada_read_var_value): Update and simplify.
10111         * ada-exp.y (write_var_or_type): Remove old code.
10112
10113 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
10114
10115         PR gdb/25010
10116         * event-top.c: Remove include comment.
10117         * inflow.c (class scoped_ignore_sigttou): Move from here...
10118         * inflow.h (class scoped_ignore_sigttou): ...to here.
10119         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10120         * top.c:  Remove include comment.
10121
10122 2019-05-27  Tom Tromey  <tom@tromey.com>
10123
10124         * NEWS: Fix typo.
10125
10126 2019-05-22  Tom Tromey  <tromey@adacore.com>
10127
10128         * target.c (target_follow_exec): Constify parameter.
10129         * target-delegates.c: Rebuild.
10130         * remote.c (remote_target::follow_exec): Constify parameter.
10131         * infrun.c (follow_exec): Constify parameter.
10132         * target.h (struct target_ops) <follow_exec>: Constify parameter.
10133         (target_follow_exec): Likewise.
10134
10135 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10136
10137         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10138         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10139
10140 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10141
10142         * NEWS: Add debugredirect and testsuite sections.
10143
10144 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
10145
10146         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10147         target descriptions using exclusively floating point register name
10148         aliases.
10149
10150 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10151
10152         PR gdb/18644:
10153         * f-lang.c (build_fortran_types): Handle the case where
10154         gdbarch_floatformat_for_type returns a nullptr.
10155
10156 2019-05-21  Tom de Vries  <tdevries@suse.de>
10157
10158         PR cli/24587
10159         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10160
10161 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10162
10163         PR gdb/18644:
10164         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10165         16-byte floats.
10166         * i386-tdep.c (i386_floatformat_for_type): Use
10167         floatformats_ia64_quad for the 16-byte floating point component
10168         within a fortran 32-byte complex number.
10169
10170 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10171
10172         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10173         delete default constructor.
10174         (find_partial_die): Update to return const struct.
10175         (partial_die_parent_scope): Move variable declaration into scope
10176         of its use and change its type to auto.
10177         (guess_partial_die_structure_name): Likewise.
10178         (partial_die_info::fixup): Likewise.
10179
10180 2019-05-17  Tom Tromey  <tromey@adacore.com>
10181
10182         * source.c (find_and_open_source): Remove cast.
10183
10184 2019-05-17  Tom Tromey  <tromey@adacore.com>
10185
10186         * annotate.c (annotate_source): Make "filename" const.
10187         * annotate.h (annotate_source): Use const.
10188
10189 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10190
10191         * disasm.c (set_disassembler_options): Send errors to stderr.
10192
10193 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10194
10195         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10196         (cli_interp_base::set_logging): Check debug_redirect.
10197         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10198         * cli/cli-logging.c (debug_redirect): Add static variable.
10199         (pop_output_files): Add default param.
10200         (handle_redirections): Print debug setting.
10201         (show_logging_command): Likewise.
10202         (_initialize_cli_logging): Add debugredirect command.
10203         * interps.c (current_interp_set_logging): Add debug_redirect
10204         parameter.
10205         * interps.h (set_logging): Add debug_redirect parameter.
10206         (current_interp_set_logging): Likewise.
10207         * mi/mi-common.h: Likewise.
10208         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10209
10210 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10211             Tom Tromey  <tromey@adacore.com>
10212
10213         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10214         directly.
10215         * cli/cli-interp.h (make_logging_output): Remove declaration.
10216         * cli/cli-logging.c (make_logging_output): Remove function.
10217         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10218         directly.
10219         * ui-file.c (tee_file::tee_file): Remove bools.
10220         (tee_file::~tee_file): Remove deletes.
10221         * ui-file.h (tee_file): Remove bools.
10222
10223 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10224
10225         * mi/mi-cmds.h (mi_cmd_complete): New function.
10226         * mi/mi-main.c (mi_cmd_complete): Likewise.
10227         * mi/mi-cmds.c: Define new MI command -complete.
10228         * NEWS: Mention new -complete command.
10229
10230 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10231
10232         * completer.h (complete): New function.
10233         * completer.c (complete): Likewise.
10234         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10235         function defined in completer.h.
10236
10237 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10238
10239         * MAINTAINERS (Write After Approval): Add myself.
10240
10241 2019-05-17  Tom de Vries  <tdevries@suse.de>
10242
10243         PR gdb/24094
10244         * dwarf2read.c (struct cu_partial_die_info): New struct.
10245         (find_partial_die): Return cu_partial_die_info.
10246         (partial_die_parent_scope, guess_partial_die_structure_name)
10247         (partial_die_info::fixup): Handle new return type of find_partial_die.
10248
10249 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10250
10251         PR breakpoints/24541
10252         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10253         "std::string", simplifying the algorithm.
10254
10255 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10256
10257         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10258         (stap_static_probe_ops::get_probes): Likewise.
10259
10260 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10261
10262         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10263         '-')" and "else if".
10264         (stap_parse_single_operand): Join checks for
10265         "gdbarch_stap_parse_special_token_p" and
10266         "gdbarch_stap_parse_special_token" in the same "if" statement.
10267         Invert check when verifying for operation on register
10268         displacement.
10269
10270 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10271
10272         * stap-probe.c (stap_get_opcode): Update comment.
10273         (stap_get_expected_argument_type): Likewise.
10274         (handle_stap_probe): Likewise.
10275
10276 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10277
10278         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10279         return type to 'bool'.  Adjust comment.  Use 'bool' when
10280         appropriate.
10281         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10282         * stap-probe.c (stap_parse_argument_1): Likewise.
10283         (stap_is_operator): Likewise.
10284         (stap_is_generic_prefix): Likewise.
10285         (stap_is_register_prefix): Likewise.
10286         (stap_is_register_indirection_prefix): Likewise.
10287         (stap_is_integer_prefix): Likewise.
10288         (stap_generic_check_suffix): Likewise.
10289         (stap_check_integer_suffix): Likewise.
10290         (stap_check_register_suffix): Likewise.
10291         (stap_check_register_indirection_suffix): Likewise.
10292         (stap_parse_register_operand): Likewise.
10293         (stap_parse_single_operand): Likewise.
10294         (stap_parse_argument_1): Likewise.
10295         (stap_probe::get_argument_count): Likewise.
10296         (stap_is_operator): Likewise.
10297
10298 2019-05-16  Tom Tromey  <tromey@adacore.com>
10299
10300         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10301         keyword to foreach.
10302
10303 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10304
10305         * linux-thread-db.c (try_thread_db_load_1): Change return type
10306         to bool.
10307         (try_thread_db_load): Likewise.
10308         (try_thread_db_load_from_pdir_1): Likewise.
10309         (try_thread_db_load_from_pdir): Likewise.
10310         (try_thread_db_load_from_sdir): Likewise.
10311         (try_thread_db_load_from_dir): Likewise.
10312         (thread_db_load_search): Likewise.
10313         (has_libpthread): Likewise.
10314         (thread_db_load): Likewise.
10315
10316 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10317
10318         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10319         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10320         NULL, and complain/return if that's the case.
10321
10322 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10323
10324         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10325         (advance, posn, abstract_read_memory): New functions.
10326         [struct mem_read_abstraction]: New struct.
10327         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10328
10329 2019-05-14  Tom Tromey  <tromey@adacore.com>
10330
10331         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10332         value is not lval_memory.
10333
10334 2019-05-14  Tom Tromey  <tromey@adacore.com>
10335
10336         * solib.c (info_sharedlibrary_command): Style the file name.
10337
10338 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10339
10340         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10341         (aarch64_vnv_type): Likewise.
10342         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10343         * common/tdesc.c: Likewise.
10344         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10345         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10346         * features/aarch64-fpu.xml: Add ieee half view.
10347         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10348         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10349         * gdbtypes.h (struct builtin_type): Likewise.
10350         (struct objfile_type): Likewise.
10351
10352 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10353
10354         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10355         typo.
10356         * location.h (string_to_event_location): Likewise.
10357
10358 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10359
10360         GDB 8.3 released.
10361
10362 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10363
10364         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10365         New variable declaration.
10366         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10367         New variable.
10368         (print_one_breakpoint): Use ui_out::test_flags and new global
10369         variable to compute use_fixed_output.
10370         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10371         Remove.
10372         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10373         (mi_multi_location_breakpoint_output_fixed): Remove.
10374         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10375         new variable.
10376         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10377         fix_multi_location_breakpoint_output flag if version >= 3.
10378         * ui-out.h (enum ui_out_flag)
10379         <fix_multi_location_breakpoint_output>: New enumerator.
10380
10381 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10382
10383         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10384
10385 2019-05-10  Tom Tromey  <tromey@adacore.com>
10386
10387         * ada-lang.c (catch_ada_completer): New function.
10388         (_initialize_ada_language): Use it.
10389
10390 2019-05-10  Tom Tromey  <tromey@adacore.com>
10391
10392         * thread.c (print_thread_info): Make "requested_threads" const.
10393         * gdbthread.h (print_thread_info): Make "requested_threads"
10394         const.
10395         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10396         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10397
10398 2019-05-08  Tom Tromey  <tom@tromey.com>
10399
10400         * gdbtypes.c (objfile_type_data): Change type.
10401         (objfile_type, _initialize_gdbtypes): Update.
10402
10403 2019-05-08  Tom Tromey  <tom@tromey.com>
10404
10405         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10406         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10407         (_initialize_dwarf2_frame): Update.
10408
10409 2019-05-08  Tom Tromey  <tom@tromey.com>
10410
10411         * objc-lang.c (objc_objfile_data): Change type.
10412         (find_methods): Update.
10413         (_initialize_objc_lang): Remove.
10414
10415 2019-05-08  Tom Tromey  <tom@tromey.com>
10416
10417         * stabsread.c (rs6000_builtin_type_data): Change type.
10418         (rs6000_builtin_type, _initialize_stabsread): Update.
10419
10420 2019-05-08  Tom Tromey  <tom@tromey.com>
10421
10422         * mips-tdep.c (mips_pdr_data): Remove.
10423         (_initialize_mips_tdep): Update.
10424
10425 2019-05-08  Tom Tromey  <tom@tromey.com>
10426
10427         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10428         (hppa_init_objfile_priv_data, read_unwind_info)
10429         (find_unwind_entry, _initialize_hppa_tdep): Update.
10430
10431 2019-05-08  Tom Tromey  <tom@tromey.com>
10432
10433         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10434         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10435         on obstack.
10436         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10437
10438 2019-05-08  Tom Tromey  <tom@tromey.com>
10439
10440         * mdebugread.c (basic_type_data): Change type.
10441         (basic_type, _initialize_mdebugread): Update.
10442
10443 2019-05-08  Tom Tromey  <tom@tromey.com>
10444
10445         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10446
10447 2019-05-08  Tom Tromey  <tom@tromey.com>
10448
10449         * nto-tdep.c (nto_inferior_data_reg): Change type.
10450         (nto_inferior_data): Update.
10451         (nto_inferior_data_cleanup, nto_new_inferior_data)
10452         (_initialize_nto_tdep): Remove.
10453         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10454
10455 2019-05-08  Tom Tromey  <tom@tromey.com>
10456
10457         * ada-lang.c (struct ada_inferior_data): Add initializers.
10458         (ada_inferior_data): Change type.
10459         (ada_inferior_data_cleanup): Remove.
10460         (get_ada_inferior_data, ada_inferior_exit)
10461         (struct ada_pspace_data): Add initializers, destructor.
10462         (ada_pspace_data_handle): Change type.
10463         (get_ada_pspace_data): Update.
10464         (ada_pspace_data_cleanup): Remove.
10465
10466 2019-05-08  Tom Tromey  <tom@tromey.com>
10467
10468         * coffread.c (struct coff_symfile_info): Add initializers.
10469         (coff_objfile_data_key): Move lower.  Change type.
10470         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10471         Update.
10472         (coff_free_info): Remove.
10473
10474 2019-05-08  Tom Tromey  <tom@tromey.com>
10475
10476         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10477         (fbsd_pspace_data_handle): Move lower.  Change type.
10478         (get_fbsd_pspace_data): Update.
10479         (fbsd_pspace_data_cleanup): Remove.
10480         (_initialize_fbsd_tdep): Update.
10481
10482 2019-05-08  Tom Tromey  <tom@tromey.com>
10483
10484         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10485         (get_ada_tasks_pspace_data): Update.
10486         (ada_tasks_pspace_data_cleanup): Remove.
10487         (_initialize_tasks): Update.
10488         (ada_tasks_inferior_data_handle): Change type.
10489         (get_ada_tasks_inferior_data): Update.
10490         (ada_tasks_inferior_data_cleanup): Remove.
10491         (struct ada_tasks_pspace_data): Add initializers.
10492
10493 2019-05-08  Tom Tromey  <tom@tromey.com>
10494
10495         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10496         * symfile-debug.c (debug_sym_get_probes): Change type.
10497         * stap-probe.c (handle_stap_probe):
10498         (stap_static_probe_ops::get_probes): Change type.
10499         * probe.h (class static_probe_ops) <get_probes>: Change type.
10500         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10501         (parse_probes_in_pspace): Update.
10502         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10503         Update.
10504         (any_static_probe_ops::get_probes): Change type.
10505         * elfread.c (elfread_data): New typedef.
10506         (probe_key): Change type.
10507         (elf_get_probes): Likewise.  Update.
10508         (probe_key_free): Remove.
10509         (_initialize_elfread): Update.
10510         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10511         Change type.
10512         (dtrace_process_dof_probe, dtrace_process_dof)
10513         (dtrace_static_probe_ops::get_probe): Change type.
10514
10515 2019-05-08  Tom Tromey  <tom@tromey.com>
10516
10517         * xcoffread.c (struct xcoff_symfile_info): Rename from
10518         coff_symfile_info.  Add initializers.
10519         (xcoff_objfile_data_key): Move lower.  Change type.
10520         (XCOFF_DATA): Rewrite.
10521         (xcoff_free_info): Remove.
10522         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10523         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10524         (xcoff_initial_scan): Update.
10525
10526 2019-05-08  Tom Tromey  <tom@tromey.com>
10527
10528         * solib-svr4.c (struct svr4_info): Add initializers and
10529         destructor.
10530         <probes_table>: Now an htab_up.
10531         (solib_svr4_pspace_data): Change type.
10532         (free_probes_table): Simplify.
10533         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10534         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10535         (probes_table_remove_objfile_probes, register_solib_event_probe)
10536         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10537         (_initialize_svr4_solib): Update.
10538
10539 2019-05-08  Tom Tromey  <tom@tromey.com>
10540
10541         * remote.c (remote_pspace_data): Change type.
10542         (remote_pspace_data_cleanup): Remove.
10543         (get_remote_exec_file, set_pspace_remote_exec_file)
10544         (_initialize_remote): Update.
10545
10546 2019-05-08  Tom Tromey  <tom@tromey.com>
10547
10548         * breakpoint.c (breakpoint_objfile_key): Change type.
10549         (get_breakpoint_objfile_data): Update.
10550         (free_breakpoint_objfile_data): Remove.
10551         (_initialize_breakpoint): Update.
10552
10553 2019-05-08  Tom Tromey  <tom@tromey.com>
10554
10555         * linux-tdep.c (struct linux_info): Add initializers.
10556         (linux_inferior_data): Move.  Change type.
10557         (invalidate_linux_cache_inf): Update.
10558         (linux_inferior_data_cleanup): Remove.
10559         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10560
10561 2019-05-08  Tom Tromey  <tom@tromey.com>
10562
10563         * auxv.c (auxv_inferior_data): Move.  Change type.
10564         (auxv_inferior_data_cleanup): Remove.
10565         (invalidate_auxv_cache_inf): Rewrite.
10566         (get_auxv_inferior_data, _initialize_auxv): Update.
10567
10568 2019-05-08  Tom Tromey  <tom@tromey.com>
10569
10570         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10571         (symfile_debug_objfile_data_key): Change type.
10572         (symfile_debug_installed, debug_qf_has_symbols)
10573         (debug_qf_find_last_source_symtab)
10574         (debug_qf_forget_cached_source_info)
10575         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10576         (debug_qf_print_stats, debug_qf_dump)
10577         (debug_qf_expand_symtabs_for_function)
10578         (debug_qf_expand_all_symtabs)
10579         (debug_qf_expand_symtabs_with_fullname)
10580         (debug_qf_map_matching_symbols)
10581         (debug_qf_expand_symtabs_matching)
10582         (debug_qf_find_pc_sect_compunit_symtab)
10583         (debug_qf_map_symbol_filenames)
10584         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10585         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10586         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10587         (debug_sym_read_linetable, debug_sym_relocate): Update.
10588         (symfile_debug_free_objfile): Remove.
10589         (install_symfile_debug_logging, _initialize_symfile_debug):
10590         Update.
10591
10592 2019-05-08  Tom Tromey  <tom@tromey.com>
10593
10594         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10595         allocate_on_obstack.
10596         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10597         (get_dwarf2_per_objfile): Update.
10598         (set_dwarf2_per_objfile): Remove.
10599         (dwarf2_has_info, dwarf2_get_section_info): Update.
10600         (dwarf2_free_objfile): Remove.
10601         (_initialize_dwarf2_read): Update.
10602
10603 2019-05-08  Tom Tromey  <tom@tromey.com>
10604
10605         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10606         initializers.
10607         <unsupported_script_warning_printed,
10608         script_not_found_warning_printed>: Now bool.
10609         (auto_load_pspace_data): Change type.
10610         (~auto_load_pspace_info): Rename from
10611         auto_load_pspace_data_cleanup.
10612         (get_auto_load_pspace_data, init_loaded_scripts_info)
10613         (clear_section_scripts, maybe_print_unsupported_script_warning)
10614         (maybe_print_script_not_found_warning, _initialize_auto_load):
10615         Update.
10616
10617 2019-05-08  Tom Tromey  <tom@tromey.com>
10618
10619         * objfiles.c (objfile_pspace_info): Add destructor and
10620         initializers.
10621         (objfiles_pspace_data): Change type.
10622         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10623         (get_objfile_pspace_data): Update.
10624         (objfiles_bfd_data): Change type.
10625         (get_objfile_bfd_data): Update.
10626         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10627
10628 2019-05-08  Tom Tromey  <tom@tromey.com>
10629
10630         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10631         Change type.
10632         (get_catch_syscall_inferior_data): Update.
10633         (catch_syscall_inferior_data_cleanup): Remove.
10634         (_initialize_break_catch_syscall): Update.
10635
10636 2019-05-08  Tom Tromey  <tom@tromey.com>
10637
10638         * inflow.c (struct terminal_info): Add destructor and
10639         initializers.
10640         (inflow_inferior_data): Change type.
10641         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10642         (get_inflow_inferior_data, inflow_inferior_exit)
10643         (swap_terminal_info, _initialize_inflow): Update.
10644
10645 2019-05-08  Tom Tromey  <tom@tromey.com>
10646
10647         * target-dcache.c (target_dcache_cleanup): Remove.
10648         (target_dcache_aspace_key): Change type.
10649         (target_dcache_init_p, target_dcache_invalidate)
10650         (target_dcache_get, target_dcache_get_or_init)
10651         (_initialize_target_dcache): Update.
10652         * dcache.h (struct dcache_deleter): New.
10653
10654 2019-05-08  Tom Tromey  <tom@tromey.com>
10655
10656         * symtab.c (struct symbol_cache): Add destructor and
10657         initializers.
10658         (symbol_cache_key): Move.  Change type.
10659         (make_symbol_cache, free_symbol_cache): Remove.
10660         (get_symbol_cache): Update.
10661         (symbol_cache_cleanup): Remove.
10662         (ALL_PSPACES, symbol_cache_flush)
10663         (maintenance_print_symbol_cache)
10664         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10665         Update.
10666
10667 2019-05-08  Tom Tromey  <tom@tromey.com>
10668
10669         * symtab.c (struct main_info): Add destructor and initializers.
10670         (main_progspace_key): Move.  Change type.
10671         (get_main_info): Update.
10672         (main_info_cleanup): Remove.
10673         (_initialize_symtab): Update.
10674
10675 2019-05-08  Tom Tromey  <tom@tromey.com>
10676
10677         * registry.h (DECLARE_REGISTRY): Define the _key class.
10678
10679 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10680
10681         * NEWS: Merge two 'New commands' sections.
10682
10683 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10684
10685         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10686         parameter and use Ada language definition instead.
10687         (ada_val_print_ptr): Remove unused language parameter.
10688         (ada_val_print_num): Remove language parameter and use Ada language
10689         definition instead.
10690         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10691         parameter.
10692         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10693         parameter and use Ada language definition instead.
10694         (ada_val_print_1): Update all ada_val_print_xxx calls.
10695         Remove language parameter.
10696         (ada_val_print): Update ada_val_print_1 call.
10697
10698 2019-05-08  Tom Tromey  <tromey@adacore.com>
10699
10700         * remote.c (remote_hw_watchpoint_limit)
10701         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10702         Now static.
10703
10704 2019-05-08  Tom Tromey  <tromey@adacore.com>
10705
10706         * maint.c (_initialize_maint_cmds): Move initialization code to
10707         remote.c.
10708         (watchdog, show_watchdog): Move to remote.c.
10709         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10710         "watchdog" static.
10711         (_initialize_remote): Move initialization code from maint.c.
10712         * defs.h (watchdog): Don't declare.
10713
10714 2019-05-08  Tom Tromey  <tromey@adacore.com>
10715
10716         * tui/tui-interp.c: Include main.h.
10717         * interps.c: Include main.h.
10718         * main.h (interpreter_p): Declare.
10719         * defs.h (interpreter_p): Don't declare.
10720
10721 2019-05-08  Tom Tromey  <tromey@adacore.com>
10722
10723         * dwarf2loc.c: Include dwarf2read.h.
10724         * defs.h (read_unsigned_leb128): Don't declare.
10725         * dwarf2read.h (read_unsigned_leb128): Declare.
10726
10727 2019-05-08  Tom Tromey  <tromey@adacore.com>
10728
10729         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10730         method.
10731
10732 2019-05-08  Tom Tromey  <tromey@adacore.com>
10733
10734         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10735         when no wrap column is set.
10736
10737 2019-05-08  Tom Tromey  <tromey@adacore.com>
10738
10739         * c-lang.c (c_get_string): Handle non-C-style arrays.
10740
10741 2019-05-08  Tom Tromey  <tromey@adacore.com>
10742
10743         * typeprint.c (print_offset_data::update): Print the bit offset,
10744         not the number of bits remaining.
10745
10746 2019-05-08  Tom Tromey  <tromey@adacore.com>
10747
10748         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10749         padding at end of comment.
10750
10751 2019-05-08  Tom Tromey  <tromey@adacore.com>
10752
10753         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10754         Compare main types.
10755
10756 2019-05-06  Tom Tromey  <tom@tromey.com>
10757
10758         * common/scoped_mmap.c: Include common-defs.h.
10759         * common/scoped_mmap.h: Don't include config.h.
10760
10761 2019-05-04  Tom Tromey  <tom@tromey.com>
10762
10763         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10764         (struct aarch64_call_info): Add initializers.
10765         <si>: Now a std::vector.
10766         (pass_on_stack, aarch64_push_dummy_call): Update.
10767
10768 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10769             Tom Tromey  <tom@tromey.com>
10770
10771         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10772         (ppc_threads): Now a std::vector.  Now static.
10773         (hwdebug_find_thread_points_by_tid)
10774         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10775         Update.
10776
10777 2019-05-04  Tom Tromey  <tom@tromey.com>
10778
10779         * arc-tdep.c (arc_tdesc_init): Return bool.
10780
10781 2019-05-04  Tom Tromey  <tom@tromey.com>
10782
10783         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10784         Use gdb_assert_not_reached.
10785
10786 2019-05-04  Tom Tromey  <tom@tromey.com>
10787
10788         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10789         "false".
10790
10791 2019-05-04  Tom Tromey  <tom@tromey.com>
10792
10793         * arc-tdep.c (arc_tdesc_init): Use bool.
10794
10795 2019-05-04  Tom Tromey  <tom@tromey.com>
10796
10797         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10798
10799 2019-05-04  Tom Tromey  <tom@tromey.com>
10800
10801         * cli/cli-cmds.c (valid_command_p): Return bool.
10802
10803 2019-05-04  Tom Tromey  <tom@tromey.com>
10804
10805         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10806         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10807
10808 2019-05-04  Raul Tambre  <raul@tambre.ee>
10809
10810         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10811         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10812         operator for comparison.
10813
10814 2019-05-04  Tom Tromey  <tom@tromey.com>
10815
10816         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10817         (lookup_partial_symbol, print_partial_symbols)
10818         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10819         (psymbol_compare): Update.
10820         (add_psymbol_to_bcache): Clear the entire psymbol.
10821         (maintenance_check_psymtabs): Update.
10822         * psympriv.h (struct partial_symbol): Don't derive from
10823         general_symbol_info.
10824         <obj_section, unrelocated_address, address,
10825         set_unrelocated_address>: Update.
10826         <ginfo>: New member.
10827         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10828         (debug_names::write_psymbols): Update.
10829
10830 2019-05-04  Tom de Vries  <tdevries@suse.de>
10831
10832         * contrib/cc-with-tweaks.sh: Support -n arg.
10833
10834 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10835
10836         * corelow.c (core_target::detach): Ensure frame cache and
10837         register caches are cleared.
10838         inferior.c (exit_inferior_1): Likewise.
10839
10840 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10841             Tom Tromey  <tom@tromey.com>
10842
10843         * dictionary.c (collate_pending_symbols_by_language): Remove
10844         "struct" from foreach.
10845         * symtab.c (lookup_global_symbol_from_objfile)
10846         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10847         foreach.
10848         * ser-tcp.c (net_open): Remove "struct" from foreach.
10849         * objfiles.c (objfile_relocate, objfile_rebase)
10850         (objfile_has_symbols): Remove "struct" from foreach.
10851         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10852         from foreach.
10853         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10854         foreach.
10855         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10856         "struct" from foreach.
10857         * ada-lang.c (create_excep_cond_exprs)
10858         (ada_exception_catchpoint_cond_string): Remove "struct" from
10859         foreach.
10860
10861 2019-05-03  Tom Tromey  <tromey@adacore.com>
10862
10863         * ada-exp.y (convert_char_literal): Check suffix of each
10864         enumerator.
10865
10866 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10867
10868         PR ada/21406:
10869         * ada-exp.y (yywrap): Don't define.
10870         * ada-lex.l (%option): Add noyywrap
10871         (yywrap): Remove.
10872
10873 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10874
10875         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10876         _WIN32_WINNT to the XP level, unless already defined to a higher
10877         level.
10878
10879         * unittests/parse-connection-spec-selftests.c:
10880         * ser-tcp.c:
10881         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10882         override.
10883
10884         * symfile.c (find_separate_debug_file): Remove colon from the
10885         drive spec of DOS/Windows file names of the target, so that the
10886         file name produced from DEBUGDIR and the target's directory will
10887         be valid on DOS/Windows systems.
10888
10889 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10890
10891         * rust-lang.c (val_print_struct): Handle printing structures
10892         containing strings.
10893
10894 2019-05-02  Tom Tromey  <tromey@adacore.com>
10895
10896         * valarith.c (_initialize_valarith): Remove.
10897
10898 2019-05-01  Tom Tromey  <tromey@adacore.com>
10899
10900         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10901         bitfields.
10902
10903 2019-05-01  Tom Tromey  <tromey@adacore.com>
10904
10905         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10906         for big-endian copies.
10907
10908 2019-04-30  Ali Tamur  <tamur@google.com>
10909         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10910         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10911         (read_3_bytes): New function.
10912
10913 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10914
10915         * windows-nat.c (main_thread_id): Delete.
10916         (handle_output_debug_string): Replace main_thread_id by
10917         current_event.dwThreadId.
10918         (fake_create_process): Likewise.
10919         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10920         Do not set main_thread_id.
10921         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10922         current_event.dwThreadId.
10923         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10924
10925 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10926
10927         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10928         Use current_event.dwThreadId instead of main_thread_id.
10929
10930 2019-04-30  Tom Tromey  <tromey@adacore.com>
10931
10932         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10933         (create_excep_cond_exprs): Iterate over program spaces.
10934         (ada_exception_catchpoint_cond_string): Examine all minimal
10935         symbols for exception types.
10936
10937 2019-04-30  Tom Tromey  <tromey@adacore.com>
10938
10939         PR c++/24470:
10940         * dwarf2read.c (process_structure_scope): Handle case where type
10941         has template parameters but no symbol was created.
10942
10943 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10944             Chris January  <chris.january@arm.com>
10945
10946         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10947         qualifier.
10948         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10949
10950 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10951
10952         * f-typeprint.c (f_print_type): Update rules for printing
10953         whitespace.
10954         (f_type_print_varspec_suffix): Likewise.
10955
10956 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10957             Chris January  <chris.january@arm.com>
10958
10959         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10960         function arguments.
10961
10962 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10963
10964         * f-lang.c (build_fortran_types): Change name of void type to
10965         lower case.
10966         * f-typeprint.c (f_type_print_base): Print the name of the void
10967         type, rather than a fixed string.
10968         * f-valprint.c (f_decorations): Use lower case void string.
10969
10970 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10971             Chris January  <chris.january@arm.com>
10972
10973         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10974         types for Fortran.
10975
10976 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10977             Chris January  <chris.january@arm.com>
10978             David Lecomber  <david.lecomber@arm.com>
10979
10980         * f-exp.y (BINOP_INTRINSIC): New token.
10981         (exp): New parser rule handling BINOP_INTRINSIC.
10982         (f77_keywords): Add new builtin procedures.
10983         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10984         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10985         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10986         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10987         (print_unop_subexp_f): New function.
10988         (print_binop_subexp_f): New function.
10989         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10990         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10991         (dump_subexp_body_f): Likewise.
10992         (operator_check_f): Likewise.
10993         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10994         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10995
10996 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10997
10998         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10999         UNOP_KIND.
11000         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
11001         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
11002         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
11003         (operator_length_f): New fuction.
11004         (print_subexp_f): New function.
11005         (op_name_f): New function.
11006         (dump_subexp_body_f): New function.
11007         (operator_check_f): New function.
11008         (exp_descriptor_f): Replace standard expression handling functions
11009         with new functions.
11010         * gdb/fortran-operator.def: New file.
11011         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
11012         * gdb/std-operator.def: Remove UNOP_KIND.
11013
11014 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11015
11016         * std-operator.def: Remove unbalanced, stray double quote
11017         character.
11018
11019 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11020             Chris January  <chris.january@arm.com>
11021             Daniel Everett  <daniel.everett@arm.com>
11022             Nick Forrington  <nick.forrington@arm.com>
11023             Richard Bunt  <richard.bunt@arm.com>
11024
11025         * cp-valprint.c (cp_print_value_fields): Allow an additional level
11026         of depth when printing anonymous structs or unions.
11027         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
11028         Don't print either the top-level value, or the children if the
11029         max-depth is exceeded.
11030         (ppscm_print_children): When printing the key of a map, allow one
11031         extra level of depth.
11032         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
11033         print either the top-level value, or the children if the max-depth
11034         is exceeded.
11035         (print_children): When printing the key of a map, allow one extra
11036         level of depth.
11037         * python/py-value.c (valpy_format_string): Add max_depth keyword.
11038         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
11039         (user_print_options): Initialise max_depth field.
11040         (val_print_scalar_or_string_type_p): New function.
11041         (val_print): Check to see if the max depth has been reached.
11042         (val_print_check_max_depth): Define new function.
11043         (show_print_max_depth): New function.
11044         (_initialize_valprint): Add 'print max-depth' option.
11045         * valprint.h (struct value_print_options) <max_depth>: New field.
11046         (val_print_check_max_depth): Declare new function.
11047         * NEWS: Document new feature.
11048
11049 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11050
11051         * ada-lang.c (ada_language_defn): Initialise new field.
11052         * c-lang.c (c_is_string_type_p): New function.
11053         (c_language_defn): Initialise new field.
11054         (cplus_language_defn): Initialise new field.
11055         (asm_language_defn): Initialise new field.
11056         (minimal_language_defn): Initialise new field.
11057         * c-lang.h (c_is_string_type_p): Declare new function.
11058         * d-lang.c (d_language_defn): Initialise new field.
11059         * f-lang.c (f_is_string_type_p): New function.
11060         (f_language_defn): Initialise new field.
11061         * go-lang.c (go_is_string_type_p): New function.
11062         (go_language_defn): Initialise new field.
11063         * language.c (default_is_string_type_p): New function.
11064         (unknown_language_defn): Initialise new field.
11065         (auto_language_defn): Initialise new field.
11066         * language.h (struct language_defn) <la_is_string_type_p>: New
11067         member variable.
11068         (default_is_string_type_p): Declare new function.
11069         * m2-lang.c (m2_language_defn): Initialise new field.
11070         * objc-lang.c (objc_language_defn): Initialise new field.
11071         * opencl-lang.c (opencl_language_defn): Initialise new field.
11072         * p-lang.c (pascal_is_string_type_p): New function.
11073         (pascal_language_defn): Initialise new field.
11074         * rust-lang.c (rust_is_string_type_p): New function.
11075         (rust_language_defn): Initialise new field.
11076
11077 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11078
11079         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11080         New field.
11081         * ada-lang.c (ada_language_defn): Initialise new field.
11082         * c-lang.c (c_language_defn): Likewise.
11083         (cplus_language_defn): Likewise.
11084         (asm_language_defn): Likewise.
11085         (minimal_language_defn): Likewise.
11086         * d-lang.c (d_language_defn): Likewise.
11087         * f-lang.c (f_language_defn): Likewise.
11088         * go-lang.c (go_language_defn): Likewise.
11089         * language.c (unknown_language_defn): Likewise.
11090         (auto_language_defn): Likewise.
11091         * m2-lang.c (m2_language_defn): Likewise.
11092         * objc-lang.c (objc_language_defn): Likewise.
11093         * opencl-lang.c (opencl_language_defn): Likewise.
11094         * p-lang.c (pascal_language_defn): Likewise.
11095         * rust-lang.c (rust_language_defn): Likewise.
11096
11097 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11098
11099         * ada-lang.c (ada_is_character_type): Change return type to bool.
11100         (ada_is_string_type): Likewise.
11101         * ada-lang.h (ada_is_character_type): Update declaration
11102         (ada_is_string_type): Likewise.
11103
11104 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11105
11106         Support style in 'frame|thread apply'
11107
11108         * gdbcmd.h (execute_command_to_string): New term_out parameter.
11109         * record.c (record_start, record_stop): Update callers of
11110         execute_command_to_string with false.
11111         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11112         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11113         methods.
11114         (class string_file): New constructor with term_out parameter.
11115         Override methods term_out and can_emit_style_escape.  New member
11116         term_out.
11117         (class stdio_file): Override can_emit_style_escape.
11118         (class tee_file): Override term_out and can_emit_style_escape.
11119         * utils.h (can_emit_style_escape): Remove.
11120         * utils.c (can_emit_style_escape): Likewise.
11121         Update all callers of can_emit_style_escape (SOMESTREAM) to
11122         SOMESTREAM->can_emit_style_escape.
11123         * source-cache.c (source_cache::get_source_lines): Likewise.
11124         * stack.c (frame_apply_command_count): Call execute_command_to_string
11125         passing the term_out characteristic of the current gdb_stdout.
11126         * thread.c (thr_try_catch_cmd): Likewise.
11127         * top.c (execute_command_to_string): pass term_out parameter
11128         to construct the string_file for the command output.
11129         * ui-file.c (term_cli_styling): New function (most code moved
11130         from utils.c can_emit_style_escape).
11131         (string_file::string_file, string_file::can_emit_style_escape,
11132         stdio_file::can_emit_style_escape, tee_file::term_out,
11133         tee_file::can_emit_style_escape): New functions.
11134
11135 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11136
11137         * NEWS: Mention the new set|show may-call-functions.
11138         * infcall.c (may_call_functions_p): New variable.
11139         (show_may_call_functions_p): New function.
11140         (call_function_by_hand_dummy): Throws an error if not
11141         may-call-functions.
11142         (_initialize_infcall): Call add_setshow_boolean_cmd for
11143         may-call-functions.
11144
11145 2019-04-25  Keith Seitz  <keiths@redhat.com>
11146
11147         PR c++/24367
11148         * cp-support.c (inspect_type): Don't attempt substitutions
11149         of symbol with the same name.
11150
11151 2019-04-25  Tom Tromey  <tromey@adacore.com>
11152
11153         PR gdb/24475:
11154         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11155         static.
11156
11157 2019-04-25  Tom Tromey  <tromey@adacore.com>
11158
11159         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11160         rvalue reference.
11161         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11162         (gdb_xml_parser::parse): Use std::move.
11163         * python/python-internal.h (gdbpy_convert_exception): Take a const
11164         reference.
11165         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11166         std::move.
11167         * python/py-utils.c (gdbpy_convert_exception): Take a const
11168         reference.
11169         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11170         Use std::move.
11171         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11172         Use std::move.
11173         * mi/mi-main.c (mi_print_exception): Take a const reference.
11174         * main.c (handle_command_errors): Take a const reference.
11175         * linespec.c (parse_linespec): Use std::move.
11176         * infcall.c (run_inferior_call): Use std::move.
11177         (call_function_by_hand_dummy): Use std::move.
11178         * exec.c (try_open_exec_file): Use std::move.
11179         * exceptions.h (exception_print, exception_fprintf)
11180         (exception_print_same): Update.
11181         * exceptions.c (print_exception, exception_print)
11182         (exception_fprintf, exception_print_same): Change parameters to
11183         const reference.
11184         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11185         * common/new-op.c: Use std::move.
11186         * common/common-exceptions.h (struct gdb_exception): Add move
11187         constructor.
11188         (struct gdb_exception_error, struct gdb_exception_quit, struct
11189         gdb_quit_bad_alloc): Change constructor to move constructor.
11190         (throw_exception): Change parameter to rvalue reference.
11191         * common/common-exceptions.c (throw_exception): Take rvalue
11192         reference.
11193         * cli/cli-interp.c (safe_execute_command): Use std::move.
11194         * breakpoint.c (insert_bp_location, location_to_sals): Use
11195         std::move.
11196
11197 2019-04-25  Tom Tromey  <tromey@adacore.com>
11198
11199         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11200         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11201         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11202         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11203         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11204         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11205         guile/scm-value.c: Use unpack.
11206         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11207         gdbscm_gdb_exception.
11208         (gdbscm_throw_gdb_exception): Likewise.
11209         (struct gdbscm_gdb_exception): New.
11210         (unpack): New function.
11211         (gdbscm_wrap): Use unpack.
11212
11213 2019-04-25  Tom Tromey  <tromey@adacore.com>
11214
11215         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11216         (gdb_rl_callback_handler): Use std::move.
11217         * common/common-exceptions.h (struct gdb_exception): Add move
11218         assignment operator.
11219         (throw_exception_sjlj): Change "exception" to const reference.
11220         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11221         (throw_exception_sjlj): Change "exception" to const reference.
11222
11223 2019-04-25  Tom Tromey  <tromey@adacore.com>
11224
11225         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11226         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11227         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11228         Update.
11229         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11230         Update.
11231         * mi/mi-interp.c (mi_interp::exec): Update.
11232         * linespec.c (parse_linespec): Update.
11233         * infcall.c (run_inferior_call): Update.
11234         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11235         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11236         (gdbscm_lookup_global_symbol): Update.
11237         * guile/scm-param.c (gdbscm_parameter_value): Update.
11238         * guile/scm-frame.c (gdbscm_frame_read_register)
11239         (gdbscm_frame_read_var): Update.
11240         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11241         * exec.c (try_open_exec_file): Update.
11242         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11243         (gdb_rl_callback_handler): Update.
11244         * common/common-exceptions.h (exception_none): Don't declare.
11245         * common/common-exceptions.c (exception_none): Don't define.
11246         (struct catcher) <exception>: Update.
11247         * cli/cli-interp.c (safe_execute_command): Update.
11248         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11249
11250 2019-04-25  Ali Tamur  <tamur@google.com>
11251
11252         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11253         (read_attribute_value): Likewise.
11254         (dwarf2_read_addr_index): Update comment.
11255         (read_str_index): Add DW_FORM_strx.
11256         (dwarf2_string_attr): Likewise.
11257         (dwarf2_const_value_attr): Likewise.
11258         (dump_die_shallow): Likewise.
11259         (dwarf2_fetch_constant_bytes): Likewise.
11260         (skip_form_bytes): Likewise.
11261         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11262
11263 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11264
11265         PR corefiles/11608
11266         PR corefiles/18187
11267         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11268         OFFSET.  Verify if current mapping contains an ELF header.
11269         (linux_find_memory_regions_full): Adjust call to
11270         dump_mapping_p.
11271
11272 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11273             Kang Li <kanglictf@gmail.com>
11274
11275         PR gdb/21600
11276
11277         * dwarf2-frame.c (read_initial_length): Be consistent about using
11278         unsigned representation of length.
11279         (decode_frame_entry_1): Likewise.  Check for wraparound of
11280         end pointer as well as buffer overflow.
11281
11282 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11283
11284         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11285         "vq".
11286
11287 2019-04-24  Tom Tromey  <tromey@adacore.com>
11288
11289         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11290
11291 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11292
11293         * s12z-tdep.c (s12z_unwind_pc): Delete.
11294         (s12z_unwind_sp): Delete.
11295         (s12z_gdbarch_init): Don't register deleted functions with
11296         gdbarch.
11297
11298 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11299
11300         * rl78-tdep.c (rl78_unwind_sp): Delete.
11301         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11302
11303 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11304
11305         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11306         (xstormy16_unwind_pc): Delete.
11307         (xstormy16_dummy_id): Delete.
11308         (xstormy16_gdbarch_init): Don't register deleted functions with
11309         gdbarch.
11310
11311 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11312
11313         * vax-tdep.c (vax_unwind_pc): Delete.
11314         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11315
11316 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11317
11318         * v850-tdep.c (v850_unwind_sp): Delete.
11319         (v850_unwind_pc): Delete.
11320         (v850_dummy_id): Delete.
11321         (v850_gdbarch_init): Don't register deleted functions with
11322         gdbarch.
11323
11324 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11325
11326         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11327         (tilegx_unwind_pc): Delete.
11328         (tilegx_unwind_dummy_id): Delete.
11329         (tilegx_gdbarch_init): Don't register deleted functions with
11330         gdbarch.
11331
11332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11333
11334         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11335         (tic6x_dummy_id): Delete.
11336         (tic6x_gdbarch_init): Don't register deleted functions with
11337         gdbarch.
11338
11339 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11340
11341         * sparc-tdep.c (sparc_unwind_pc): Delete.
11342         (sparc32_gdbarch_init): Don't register deleted function with
11343         gdbarch.
11344
11345 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11346
11347         * sh-tdep.c (sh_unwind_sp): Delete.
11348         (sh_unwind_pc): Delete.
11349         (sh_dummy_id): Delete.
11350         (sh_gdbarch_init): Don't register deleted functions with
11351         gdbarch.
11352
11353 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11354
11355         * score-tdep.c (score_unwind_sp): Delete.
11356         (score_unwind_pc): Delete.
11357         (score_dummy_id): Delete.
11358         (score_gdbarch_init): Don't register deleted functions with
11359         gdbarch.
11360
11361 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11362
11363         * rx-tdep.c (rx_unwind_pc): Delete.
11364         (rx_unwind_sp): Delete.
11365         (rx_dummy_id): Delete.
11366         (rx_gdbarch_init): Don't register deleted functions with
11367         gdbarch.  Update comment.
11368
11369 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11370
11371         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11372         (rs6000_dummy_id): Delete.
11373         (rs6000_gdbarch_init): Don't register deleted functions with
11374         gdbarch.
11375
11376 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11377
11378         * or1k-tdep.c (or1k_dummy_id): Delete.
11379         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11380
11381 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11382
11383         * nios2-tdep.c (nios2_dummy_id): Delete.
11384         (nios2_unwind_sp): Delete.
11385         (nios2_gdbarch_init): Don't register deleted functions with
11386         gdbarch.
11387
11388 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11389
11390         * nds32-tdep.c (nds32_dummy_id): Delete.
11391         (nds32_unwind_pc): Delete.
11392         (nds32_unwind_sp): Delete.
11393         (nds32_gdbarch_init): Don't register deleted functions with
11394         gdbarch.
11395
11396 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11397
11398         * msp430-tdep.c (msp430_unwind_pc): Delete.
11399         (msp430_unwind_sp): Delete.
11400         (msp430_dummy_id): Delete.
11401         (msp430_gdbarch_init): Don't register deleted functions with
11402         gdbarch.
11403
11404 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11405
11406         * moxie-tdep.c (moxie_unwind_sp): Delete.
11407         (moxie_unwind_pc): Delete.
11408         (moxie_dummy_id): Delete.
11409         (moxie_gdbarch_init): Don't register deleted functions with
11410         gdbarch.
11411
11412 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11413
11414         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11415         (mn10300_unwind_pc): Delete.
11416         (mn10300_unwind_sp): Delete.
11417         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11418         mn10300_unwind_sp.
11419         (mn10300_frame_unwind_init): Don't register deleted functions with
11420         gdbarch.
11421
11422 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11423
11424         * mep-tdep.c (mep_unwind_pc): Delete.
11425         (mep_unwind_sp): Delete.
11426         (mep_dummy_id): Delete.
11427         (mep_gdbarch_init): Don't register deleted functions with
11428         gdbarch.
11429
11430 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11431
11432         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11433         (m68hc11_unwind_sp): Delete.
11434         (m68hc11_gdbarch_init): Don't register deleted functions with
11435         gdbarch.
11436
11437 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11438
11439         * m32r-tdep.c (m32r_unwind_sp): Delete.
11440         (m32r_unwind_pc): Delete.
11441         (m32r_dummy_id): Delete.
11442         (m32r_gdbarch_init): Don't register deleted functions with
11443         gdbarch.
11444
11445 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11446
11447         * m32c-tdep.c (m32c_unwind_pc): Delete.
11448         (m32c_unwind_sp): Delete.
11449         (m32c_dummy_id): Delete.
11450         (m32c_gdbarch_init): Don't register deleted functions with
11451         gdbarch.
11452
11453 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11454
11455         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11456         (lm32_unwind_pc): Delete.
11457         (lm32_dummy_id): Delete.
11458         (lm32_gdbarch_init): Don't register deleted functions with
11459         gdbarch.
11460
11461 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11462
11463         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11464         (iq2000_unwind_pc): Delete.
11465         (iq2000_dummy_id): Delete.
11466         (iq2000_gdbarch_init): Don't register deleted functions with
11467         gdbarch.
11468
11469 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11470
11471         * nds32-tdep.c (nds32_type_align): Delete.
11472         (nds32_push_dummy_call): Use type_align instead.
11473
11474 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11475
11476         * arm-tdep.c (arm_type_align): Only handle vector override case.
11477         (arm_push_dummy_call): Use type_align.
11478         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11479
11480 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11481
11482         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11483         case.
11484         (pass_on_stack): Use type_align.
11485         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11486         function.
11487
11488 2019-04-23  Tom Tromey  <tromey@adacore.com>
11489
11490         * dwarf2read.c (line_header::file_name_at): Remove unused
11491         overload.
11492
11493 2019-04-23  Tom de Vries  <tdevries@suse.de>
11494
11495         PR gdb/24438
11496         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11497         invocation.
11498
11499
11500 2019-03-27  Ali Tamur  <tamur@google.com>
11501
11502         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11503         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11504         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11505         (dwarf_expr_context::get_addr_index): Likewise
11506         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11507         (symbol_needs_eval_context::get_addr_index): Likewise
11508         (disassemble_dwarf_expression): Add DW_OP_addrx
11509         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11510         (read_cutu_die_from_dwo): Update comment
11511         (skip_one_die): Add DW_FORM_addrx
11512         (read_attribute_value): Likewise
11513         (var_decode_location): Add DW_OP_addrx
11514         (dwarf2_const_value_attr): Add DW_FORM_addrx
11515         (dump_die_shallow): Likewise
11516         (dwarf2_fetch_constant_bytes): Likewise
11517         (decode_locdesc): Add DW_OP_addrx
11518         (skip_form_bytes): Add DW_FORM_addrx
11519
11520 2019-04-22  Ali Tamur  <tamur@google.com>
11521
11522         * MAINTAINERS (Write After Approval): Add self.
11523
11524 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11525
11526         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11527         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11528         (open_symbol_file_object): Likewise.
11529         (svr4_default_sos): Add info parameter.
11530         (svr4_read_so_list): Likewise.
11531         (svr4_current_sos_direct): Adjust functions calls to pass down
11532         info.
11533         (svr4_current_sos_1): Add info parameter.
11534         (svr4_current_sos): Call get_svr4_info, pass info down to
11535         svr4_current_sos_1.
11536         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11537         get_svr4_info.
11538         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11539         get_svr4_info.
11540         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11541         to get_svr4_info.
11542         (probes_table_remove_objfile_probes): Likewise.
11543         (register_solib_event_probe): Add info parameter.
11544         (solist_update_incremental): Pass info parameter down to
11545         svr4_read_so_list.
11546         (disable_probes_interface): Add info parameter.
11547         (svr4_handle_solib_event): Pass current_program_space to
11548         get_svr4_info.  Adjust disable_probes_interface cleanup.
11549         (svr4_create_probe_breakpoints): Add info parameter, pass it
11550         down to register_solib_event_probe.
11551         (svr4_create_solib_event_breakpoints): Add info parameter,
11552         pass it down to svr4_create_probe_breakpoints.
11553         (enable_break): Pass info down to
11554         svr4_create_solib_event_breakpoints.
11555         (svr4_solib_create_inferior_hook): Pass current_program_space to
11556         get_svr4_info.
11557         (svr4_clear_solib): Likewise.
11558
11559 2019-04-22  Pedro Alves  <palves@redhat.com>
11560
11561         * solib-svr4.c (svr4_free_objfile_observer): New.
11562         (probe_and_action::objfile): New field.
11563         (probes_table_htab_remove_objfile_probes)
11564         (probes_table_remove_objfile_probes): New functions.
11565         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11566         in the new probe_and_action.  Don't store the probe in 'lookup'.
11567         (svr4_create_probe_breakpoints): Pass objfile to
11568         register_solib_event_probe.
11569         (_initialize_svr4_solib): Register a free_objfile observer.
11570
11571 2019-04-19  Tom Tromey  <tom@tromey.com>
11572
11573         * common/queue.h: Remove.
11574
11575 2019-04-19  Tom Tromey  <tom@tromey.com>
11576
11577         * event-loop.c: Don't include "common/queue.h".
11578
11579 2019-04-19  Tom Tromey  <tom@tromey.com>
11580
11581         * remote.c (remote_target): Use delete.
11582         * remote-notif.h: Include <list>, not "common/queue.h".
11583         (notif_client_p): Remove typedef.
11584         (remote_notif_state): Add constructor, destructor, initializer.
11585         <notif_queue>: Now a std::list.
11586         (remote_notif_state_xfree): Don't declare.
11587         * remote-notif.c (remote_notif_process, handle_notification)
11588         (remote_notif_state_allocate): Update.
11589         (~remote_notif_state): Rename from remote_notif_state_xfree.
11590
11591 2019-04-19  Tom Tromey  <tom@tromey.com>
11592
11593         * symfile.c (reread_symbols): Update.
11594         * objfiles.c (objfile_register_static_link)
11595         (objfile_lookup_static_link): Update
11596         (~objfile) Don't delete static_links.
11597         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11598
11599 2019-04-19  Tom Tromey  <tom@tromey.com>
11600
11601         * type-stack.h (struct type_stack) <insert>: Constify string.
11602         * type-stack.c (type_stack::insert): Constify string.
11603         * gdbtypes.h (lookup_template_type): Update.
11604         (address_space_name_to_int): Update.
11605         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11606         const.
11607         (lookup_template_type): Make name const.
11608         * c-exp.y: Update rules.
11609         (lex_one_token, classify_name, classify_inner_name)
11610         (c_print_token): Update.
11611         * p-exp.y: Update rules.
11612         (yylex): Update.
11613         * f-exp.y: Update rules.
11614         (yylex): Update.
11615         * d-exp.y: Update rules.
11616         (lex_one_token, classify_name, classify_inner_name): Update.
11617         * parse.c (write_dollar_variable, copy_name): Return std::string.
11618         * parser-defs.h (copy_name): Change return type.
11619         * m2-exp.y: Update rules.
11620         (yylex): Update.
11621         * go-exp.y (lex_one_token): Update.
11622         Update rules.
11623         (classify_unsafe_function, classify_packaged_name)
11624         (classify_name, yylex): Update.
11625
11626 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11627
11628         * configure.ac: add --enable-source-highlight switch.
11629         * configure: Regenerate.
11630         * top.c (print_gdb_version): plumb --enable-source-highlight
11631         status to "show configuration".
11632
11633 2019-04-19  Tom Tromey  <tromey@adacore.com>
11634
11635         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11636         Check ADA_TYPE_P.
11637         (empty_record, ada_template_to_fixed_record_type_1)
11638         (template_to_static_fixed_type)
11639         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11640         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11641         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11642         macros.
11643
11644 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11645
11646         PR symtab/24423:
11647         * source.c (print_source_lines_base): Advance "iter" when a
11648         control character is seen.
11649
11650 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11651
11652         * inferior.h (struct infcall_suspend_state_deleter):
11653         Catch exception in destructor to avoid crash.
11654
11655 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11656
11657         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11658         close to the add_com "shell".
11659
11660 2019-04-18  Tom Tromey  <tromey@adacore.com>
11661
11662         * process-stratum-target.h (class process_stratum_target)
11663         <stratum>: Add "final".
11664
11665 2019-04-17  Tom Tromey  <tromey@adacore.com>
11666
11667         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11668         against nullptr before use.
11669
11670 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11671
11672         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11673
11674 2019-04-17  Jim Wilson  <jimw@sifive.com>
11675             Andrew Burgess  <andrew.burgess@embecosm.com>
11676
11677         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11678         code read might fail, assume 4-byte breakpoint in that case.
11679
11680 2019-04-15  Leszek Swirski  <leszeks@google.com>
11681
11682         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11683         rather than a hand-rolled POD check when checking for forced MEMORY
11684         classification.
11685
11686 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11687
11688         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11689         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11690         function.
11691         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11692         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11693         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11694         declaration.
11695
11696 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11697
11698         * aarch64-linux-nat.c
11699         (aarch64_linux_nat_target::thread_architecture): Add override.
11700         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11701         each VQ.
11702
11703 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11704
11705         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11706
11707 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11708
11709         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11710         target types of size 96-bits, add some additional comments, and
11711         check that the builtin type we found was the correct size.
11712
11713 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11714
11715         * utils.c (prompt_for_continue): Don't restore the styling at the
11716         end, as applied_style has the wrong value.  This fixes styling in
11717         long lists of file names that are interrupted by the "Continue?"
11718         prompt.
11719
11720 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11721
11722         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11723         * c-lang.c (c_language_defn): Likewise.
11724         (cplus_language_defn): Likewise.
11725         (asm_language_defn): Likewise.
11726         (minimal_language_defn): Likewise.
11727         * d-lang.c (d_language_defn): Likewise.
11728         * f-lang.c (f_language_defn): Likewise.
11729         * go-lang.c (go_language_defn): Likewise.
11730         * language.c (unknown_language_defn): Likewise.
11731         (auto_language_defn): Likewise.
11732         * language.h (struct language_defn): Remove la_magic field.
11733         (LANG_MAGIC): Delete.
11734         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11735         * objc-lang.c (objc_language_defn): Likewise.
11736         * opencl-lang.c (opencl_language_defn): Likewise.
11737         * p-lang.c (pascal_language_defn): Likewise.
11738         * rust-lang.c (rust_language_defn): Likewise.
11739
11740 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11741
11742         * riscv-tdep.c (riscv_type_align): New function.
11743         (riscv_type_alignment): Delete.
11744         (riscv_arg_location): Use 'type_align'.
11745         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11746
11747 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11748
11749         * gdbtypes.c (type_align): A struct with no non-static fields also
11750         has alignment of 1.
11751
11752 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11753
11754         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11755         component to 0.
11756         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11757         member.
11758         (riscv_struct_info::analyse): New implementation using new
11759         analyse_inner member function.
11760         (riscv_struct_info::field_offset): New member function.
11761         (riscv_struct_info::m_offsets): New member variable.
11762         (riscv_struct_info::analyse_inner): New private member function,
11763         takes the old implementation of riscv_struct_info::analyse but
11764         extended to track field offsets.
11765         (riscv_call_arg_struct): Update the struct folding special cases
11766         to handle cases where empty C++ structs, which are non-zero
11767         length, are found.
11768         (riscv_arg_location): Initialise the length of each location, a
11769         non-zero length now indicates the location is in use.
11770         (riscv_push_dummy_call): Allow for the first location having a
11771         non-zero offset when setting up arguments.
11772         (riscv_return_value): Likewise, but for return values.
11773
11774 2019-04-11  Tom Tromey  <tromey@adacore.com>
11775
11776         * utils.c (internal_vproblem): Make "msg" const.
11777
11778 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11779
11780         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11781         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11782         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11783         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11784
11785 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11786
11787         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11788         function.
11789         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11790         of amd64_collect_native_gregset.
11791         (amd64_linux_nat_target::store_registers): Likewise.
11792
11793 2019-04-10  Tom Tromey  <tom@tromey.com>
11794
11795         * symtab.c (lookup_global_symbol_from_objfile)
11796         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11797         * objfiles.h (class separate_debug_iterator): New.
11798         (class separate_debug_range): New.
11799         (struct objfile) <separate_debug_objfiles>: New method.
11800         (objfile_separate_debug_iterate): Don't declare.
11801         * objfiles.c (separate_debug_iterator::operator++): Rename from
11802         objfile_separate_debug_iterate.
11803         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11804         iterator.
11805         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11806         iterator.
11807
11808 2019-04-10  Tom Tromey  <tom@tromey.com>
11809
11810         * symfile.c (reread_symbols): Remove old comment.
11811         * objfiles.c (free_all_objfiles): Fix a typo.
11812
11813 2019-04-10  Tom Tromey  <tom@tromey.com>
11814
11815         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11816         * minsyms.c (lookup_minimal_symbol): Use foreach.
11817         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11818         (lookup_minimal_symbol_solib_trampoline): Likewise.
11819         * symfile.c (reread_symbols): Use foreach.
11820
11821 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11822             Tom Tromey  <tromey@adacore.com>
11823
11824         PR rust/24414:
11825         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11826         (rust_lex_int_test): Change "value" to be LONGEST.
11827         (rust_lex_tests): Add test for long integer literal.
11828
11829 2019-04-09  Tom Tromey  <tromey@adacore.com>
11830
11831         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11832         to bool.
11833         (extended_remote_target::attach): Update.
11834         (remote_target::remote_notice_new_inferior): Update.
11835         (remote_target::add_current_inferior_and_thread): Update.
11836         * inferior.c (exit_inferior_1): Use "false".
11837         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11838
11839 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11840
11841         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11842         the "start" command.
11843
11844 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11845
11846         * python/py-inferior.c (infpy_thread_from_thread_handle):
11847         Adjust comments to reflect renaming of thread_from_thread_handle
11848         to thread_from_handle.  Adjust keywords.  Fix type error message.
11849         (inferior_object_methods): Add thread_from_handle.  Retain
11850         thread_from_thread_handle, but mark it as deprecated.
11851
11852 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11853
11854         * gdbthread.h (find_thread_by_handle): Revise declaration.
11855         * thread.c (find_thread_by_handle): Likewise.  Adjust
11856         implementation too.
11857         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11858         support for buffer objects as handles.
11859
11860 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11861
11862         * python/py-infthread.c (thpy_thread_handle): New function.
11863         (thread_object_methods): Register thpy_thread_handle.
11864
11865 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11866
11867         * gdbthread.h (thread_to_thread_handle): Declare.
11868         * thread.c (gdbtypes.h): Include.
11869         (thread_to_thread_handle): New function.
11870
11871         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11872         (target_thread_info_to_thread_handle): Declare.
11873         * target.c (target_thread_info_to_thread_handle): New function.
11874         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11875         * target-delegates.c: Regenerate.
11876
11877         * linux-thread-db.c (class thread_db_target): Add method
11878         thread_info_to_thread_handle.
11879         (thread_db_target::thread_info_to_thread_handle): Define.
11880         * remote.c (class remote_target): Add new method
11881         thread_info_to_thread_handle.
11882         (remote_target::thread_info_to_thread_handle): Define.
11883
11884 2019-04-08  Pedro Alves  <palves@redhat.com>
11885
11886         * common/common-exceptions.c (throw_exception): Don't create
11887         named object to throw; throw directly.
11888         (throw_it): Likewise.  Don't initialize gdb_exception::message
11889         here, with new; pass FMT and AP to the ctor instead.
11890         * common/common-exceptions.h: Include <string>.
11891         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11892         const char *, va_list)): New ctor.  Use std::make_shared.
11893         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11894         errors)): Delete.
11895         (gdb_exception_error::gdb_exception_error(enum errors, const char
11896         *, va_list)): New.
11897         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11898         Add assertion.
11899         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11900         errors)): Delete.
11901         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11902         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11903         Add assertion.
11904
11905 2019-04-08  Tom Tromey  <tom@tromey.com>
11906
11907         * valops.c (value_rtti_indirect_type): Replace throw_exception
11908         with throw.
11909         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11910         with throw.
11911         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11912         throw.
11913         * target.c (target_translate_tls_address): Replace throw_exception
11914         with throw.
11915         * stack.c (frame_apply_command_count): Replace throw_exception
11916         with throw.
11917         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11918         throw.
11919         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11920         with throw.
11921         * rs6000-tdep.c (rs6000_frame_cache)
11922         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11923         * remote.c: Replace throw_exception with throw.
11924         * record-full.c (record_full_message, record_full_wait_1)
11925         (record_full_restore): Replace throw_exception with throw.
11926         * record-btrace.c:
11927         (get_thread_current_frame_id, record_btrace_start_replaying)
11928         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11929         (cmd_record_btrace_start): Replace throw_exception with throw.
11930         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11931         throw.
11932         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11933         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11934         * linespec.c:
11935         (find_linespec_symbols): Replace throw_exception with throw.
11936         * infrun.c (displaced_step_prepare, resume): Replace
11937         throw_exception with throw.
11938         * infcmd.c (post_create_inferior): Replace throw_exception with
11939         throw.
11940         * inf-loop.c (inferior_event_handler): Replace throw_exception
11941         with throw.
11942         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11943         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11944         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11945         (get_prev_frame_always, get_frame_pc_if_available)
11946         (get_frame_address_in_block_if_available, get_frame_language):
11947         Replace throw_exception with throw.
11948         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11949         throw_exception with throw.
11950         * eval.c (fetch_subexp_value, evaluate_var_value)
11951         (evaluate_funcall, evaluate_subexp_standard): Replace
11952         throw_exception with throw.
11953         * dwarf2loc.c (call_site_find_chain)
11954         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11955         Replace throw_exception with throw.
11956         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11957         with throw.
11958         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11959         throw.
11960         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11961         * completer.c (complete_line_internal): Replace throw_exception
11962         with throw.
11963         * compile/compile-object-run.c (compile_object_run): Replace
11964         throw_exception with throw.
11965         * cli/cli-script.c (process_next_line): Replace throw_exception
11966         with throw.
11967         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11968         (btrace_enable, btrace_maint_update_pt_packets): Replace
11969         throw_exception with throw.
11970         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11971         throw_exception with throw.
11972         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11973         throw_exception with throw.
11974         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11975         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11976         * aarch64-tdep.c (aarch64_make_prologue_cache)
11977         (aarch64_make_stub_cache): Replace throw_exception with throw.
11978
11979 2019-04-08  Tom Tromey  <tom@tromey.com>
11980
11981         * common/common-exceptions.c (throw_exception): Rename from
11982         throw_exception_cxx.  Remove old copy.  Make argument const.
11983         (throw_it): Create and throw exception objects directly.
11984         * common/common-exceptions.h (throw_exception): Make argument
11985         const.
11986         (struct gdb_exception_error): Add constructor.
11987         (struct gdb_exception_quit): Add constructor.
11988
11989 2019-04-08  Tom Tromey  <tom@tromey.com>
11990
11991         * common/common-exceptions.h (exception_rethrow): Don't declare.
11992         (TRY_SJLJ): Update comment.
11993         (TRY, CATCH, END_CATCH): Remove.
11994         * common/common-exceptions.c (exception_rethrow): Remove.
11995
11996 2019-04-08  Tom Tromey  <tom@tromey.com>
11997
11998         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11999         Remove.
12000         (gdb_exception_error): Rename from
12001         gdb_exception_RETURN_MASK_ERROR.
12002         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
12003         (gdb_quit_bad_alloc): Update.
12004         * aarch64-tdep.c: Update.
12005         * ada-lang.c: Update.
12006         * ada-typeprint.c: Update.
12007         * ada-valprint.c: Update.
12008         * amd64-tdep.c: Update.
12009         * arch-utils.c: Update.
12010         * break-catch-throw.c: Update.
12011         * breakpoint.c: Update.
12012         * btrace.c: Update.
12013         * c-varobj.c: Update.
12014         * cli/cli-cmds.c: Update.
12015         * cli/cli-interp.c: Update.
12016         * cli/cli-script.c: Update.
12017         * common/common-exceptions.c: Update.
12018         * common/new-op.c: Update.
12019         * common/selftest.c: Update.
12020         * compile/compile-c-symbols.c: Update.
12021         * compile/compile-cplus-symbols.c: Update.
12022         * compile/compile-object-load.c: Update.
12023         * compile/compile-object-run.c: Update.
12024         * completer.c: Update.
12025         * corelow.c: Update.
12026         * cp-abi.c: Update.
12027         * cp-support.c: Update.
12028         * cp-valprint.c: Update.
12029         * darwin-nat.c: Update.
12030         * disasm-selftests.c: Update.
12031         * dtrace-probe.c: Update.
12032         * dwarf-index-cache.c: Update.
12033         * dwarf-index-write.c: Update.
12034         * dwarf2-frame-tailcall.c: Update.
12035         * dwarf2-frame.c: Update.
12036         * dwarf2loc.c: Update.
12037         * dwarf2read.c: Update.
12038         * eval.c: Update.
12039         * event-loop.c: Update.
12040         * event-top.c: Update.
12041         * exec.c: Update.
12042         * f-valprint.c: Update.
12043         * fbsd-tdep.c: Update.
12044         * frame-unwind.c: Update.
12045         * frame.c: Update.
12046         * gdbtypes.c: Update.
12047         * gnu-v3-abi.c: Update.
12048         * guile/guile-internal.h: Update.
12049         * guile/scm-block.c: Update.
12050         * guile/scm-breakpoint.c: Update.
12051         * guile/scm-cmd.c: Update.
12052         * guile/scm-disasm.c: Update.
12053         * guile/scm-frame.c: Update.
12054         * guile/scm-lazy-string.c: Update.
12055         * guile/scm-math.c: Update.
12056         * guile/scm-param.c: Update.
12057         * guile/scm-ports.c: Update.
12058         * guile/scm-pretty-print.c: Update.
12059         * guile/scm-symbol.c: Update.
12060         * guile/scm-symtab.c: Update.
12061         * guile/scm-type.c: Update.
12062         * guile/scm-value.c: Update.
12063         * i386-linux-tdep.c: Update.
12064         * i386-tdep.c: Update.
12065         * inf-loop.c: Update.
12066         * infcall.c: Update.
12067         * infcmd.c: Update.
12068         * infrun.c: Update.
12069         * jit.c: Update.
12070         * language.c: Update.
12071         * linespec.c: Update.
12072         * linux-fork.c: Update.
12073         * linux-nat.c: Update.
12074         * linux-tdep.c: Update.
12075         * linux-thread-db.c: Update.
12076         * main.c: Update.
12077         * mi/mi-cmd-break.c: Update.
12078         * mi/mi-cmd-stack.c: Update.
12079         * mi/mi-interp.c: Update.
12080         * mi/mi-main.c: Update.
12081         * objc-lang.c: Update.
12082         * p-valprint.c: Update.
12083         * parse.c: Update.
12084         * ppc-linux-tdep.c: Update.
12085         * printcmd.c: Update.
12086         * python/py-arch.c: Update.
12087         * python/py-breakpoint.c: Update.
12088         * python/py-cmd.c: Update.
12089         * python/py-finishbreakpoint.c: Update.
12090         * python/py-frame.c: Update.
12091         * python/py-framefilter.c: Update.
12092         * python/py-gdb-readline.c: Update.
12093         * python/py-inferior.c: Update.
12094         * python/py-infthread.c: Update.
12095         * python/py-lazy-string.c: Update.
12096         * python/py-linetable.c: Update.
12097         * python/py-objfile.c: Update.
12098         * python/py-param.c: Update.
12099         * python/py-prettyprint.c: Update.
12100         * python/py-progspace.c: Update.
12101         * python/py-record-btrace.c: Update.
12102         * python/py-record.c: Update.
12103         * python/py-symbol.c: Update.
12104         * python/py-type.c: Update.
12105         * python/py-unwind.c: Update.
12106         * python/py-utils.c: Update.
12107         * python/py-value.c: Update.
12108         * python/python.c: Update.
12109         * record-btrace.c: Update.
12110         * record-full.c: Update.
12111         * remote-fileio.c: Update.
12112         * remote.c: Update.
12113         * riscv-tdep.c: Update.
12114         * rs6000-aix-tdep.c: Update.
12115         * rs6000-tdep.c: Update.
12116         * rust-exp.y: Update.
12117         * rust-lang.c: Update.
12118         * s390-tdep.c: Update.
12119         * selftest-arch.c: Update.
12120         * solib-dsbt.c: Update.
12121         * solib-frv.c: Update.
12122         * solib-spu.c: Update.
12123         * solib-svr4.c: Update.
12124         * solib.c: Update.
12125         * sparc64-linux-tdep.c: Update.
12126         * stack.c: Update.
12127         * symfile-mem.c: Update.
12128         * symmisc.c: Update.
12129         * target.c: Update.
12130         * thread.c: Update.
12131         * top.c: Update.
12132         * tracefile-tfile.c: Update.
12133         * tui/tui.c: Update.
12134         * typeprint.c: Update.
12135         * unittests/cli-utils-selftests.c: Update.
12136         * unittests/parse-connection-spec-selftests.c: Update.
12137         * valops.c: Update.
12138         * valprint.c: Update.
12139         * value.c: Update.
12140         * varobj.c: Update.
12141         * windows-nat.c: Update.
12142         * x86-linux-nat.c: Update.
12143         * xml-support.c: Update.
12144
12145 2019-04-08  Tom Tromey  <tom@tromey.com>
12146
12147         * xml-support.c: Use C++ exception handling.
12148         * x86-linux-nat.c: Use C++ exception handling.
12149         * windows-nat.c: Use C++ exception handling.
12150         * varobj.c: Use C++ exception handling.
12151         * value.c: Use C++ exception handling.
12152         * valprint.c: Use C++ exception handling.
12153         * valops.c: Use C++ exception handling.
12154         * unittests/parse-connection-spec-selftests.c: Use C++ exception
12155         handling.
12156         * unittests/cli-utils-selftests.c: Use C++ exception handling.
12157         * typeprint.c: Use C++ exception handling.
12158         * tui/tui.c: Use C++ exception handling.
12159         * tracefile-tfile.c: Use C++ exception handling.
12160         * top.c: Use C++ exception handling.
12161         * thread.c: Use C++ exception handling.
12162         * target.c: Use C++ exception handling.
12163         * symmisc.c: Use C++ exception handling.
12164         * symfile-mem.c: Use C++ exception handling.
12165         * stack.c: Use C++ exception handling.
12166         * sparc64-linux-tdep.c: Use C++ exception handling.
12167         * solib.c: Use C++ exception handling.
12168         * solib-svr4.c: Use C++ exception handling.
12169         * solib-spu.c: Use C++ exception handling.
12170         * solib-frv.c: Use C++ exception handling.
12171         * solib-dsbt.c: Use C++ exception handling.
12172         * selftest-arch.c: Use C++ exception handling.
12173         * s390-tdep.c: Use C++ exception handling.
12174         * rust-lang.c: Use C++ exception handling.
12175         * rust-exp.y: Use C++ exception handling.
12176         * rs6000-tdep.c: Use C++ exception handling.
12177         * rs6000-aix-tdep.c: Use C++ exception handling.
12178         * riscv-tdep.c: Use C++ exception handling.
12179         * remote.c: Use C++ exception handling.
12180         * remote-fileio.c: Use C++ exception handling.
12181         * record-full.c: Use C++ exception handling.
12182         * record-btrace.c: Use C++ exception handling.
12183         * python/python.c: Use C++ exception handling.
12184         * python/py-value.c: Use C++ exception handling.
12185         * python/py-utils.c: Use C++ exception handling.
12186         * python/py-unwind.c: Use C++ exception handling.
12187         * python/py-type.c: Use C++ exception handling.
12188         * python/py-symbol.c: Use C++ exception handling.
12189         * python/py-record.c: Use C++ exception handling.
12190         * python/py-record-btrace.c: Use C++ exception handling.
12191         * python/py-progspace.c: Use C++ exception handling.
12192         * python/py-prettyprint.c: Use C++ exception handling.
12193         * python/py-param.c: Use C++ exception handling.
12194         * python/py-objfile.c: Use C++ exception handling.
12195         * python/py-linetable.c: Use C++ exception handling.
12196         * python/py-lazy-string.c: Use C++ exception handling.
12197         * python/py-infthread.c: Use C++ exception handling.
12198         * python/py-inferior.c: Use C++ exception handling.
12199         * python/py-gdb-readline.c: Use C++ exception handling.
12200         * python/py-framefilter.c: Use C++ exception handling.
12201         * python/py-frame.c: Use C++ exception handling.
12202         * python/py-finishbreakpoint.c: Use C++ exception handling.
12203         * python/py-cmd.c: Use C++ exception handling.
12204         * python/py-breakpoint.c: Use C++ exception handling.
12205         * python/py-arch.c: Use C++ exception handling.
12206         * printcmd.c: Use C++ exception handling.
12207         * ppc-linux-tdep.c: Use C++ exception handling.
12208         * parse.c: Use C++ exception handling.
12209         * p-valprint.c: Use C++ exception handling.
12210         * objc-lang.c: Use C++ exception handling.
12211         * mi/mi-main.c: Use C++ exception handling.
12212         * mi/mi-interp.c: Use C++ exception handling.
12213         * mi/mi-cmd-stack.c: Use C++ exception handling.
12214         * mi/mi-cmd-break.c: Use C++ exception handling.
12215         * main.c: Use C++ exception handling.
12216         * linux-thread-db.c: Use C++ exception handling.
12217         * linux-tdep.c: Use C++ exception handling.
12218         * linux-nat.c: Use C++ exception handling.
12219         * linux-fork.c: Use C++ exception handling.
12220         * linespec.c: Use C++ exception handling.
12221         * language.c: Use C++ exception handling.
12222         * jit.c: Use C++ exception handling.
12223         * infrun.c: Use C++ exception handling.
12224         * infcmd.c: Use C++ exception handling.
12225         * infcall.c: Use C++ exception handling.
12226         * inf-loop.c: Use C++ exception handling.
12227         * i386-tdep.c: Use C++ exception handling.
12228         * i386-linux-tdep.c: Use C++ exception handling.
12229         * guile/scm-value.c: Use C++ exception handling.
12230         * guile/scm-type.c: Use C++ exception handling.
12231         * guile/scm-symtab.c: Use C++ exception handling.
12232         * guile/scm-symbol.c: Use C++ exception handling.
12233         * guile/scm-pretty-print.c: Use C++ exception handling.
12234         * guile/scm-ports.c: Use C++ exception handling.
12235         * guile/scm-param.c: Use C++ exception handling.
12236         * guile/scm-math.c: Use C++ exception handling.
12237         * guile/scm-lazy-string.c: Use C++ exception handling.
12238         * guile/scm-frame.c: Use C++ exception handling.
12239         * guile/scm-disasm.c: Use C++ exception handling.
12240         * guile/scm-cmd.c: Use C++ exception handling.
12241         * guile/scm-breakpoint.c: Use C++ exception handling.
12242         * guile/scm-block.c: Use C++ exception handling.
12243         * guile/guile-internal.h: Use C++ exception handling.
12244         * gnu-v3-abi.c: Use C++ exception handling.
12245         * gdbtypes.c: Use C++ exception handling.
12246         * frame.c: Use C++ exception handling.
12247         * frame-unwind.c: Use C++ exception handling.
12248         * fbsd-tdep.c: Use C++ exception handling.
12249         * f-valprint.c: Use C++ exception handling.
12250         * exec.c: Use C++ exception handling.
12251         * event-top.c: Use C++ exception handling.
12252         * event-loop.c: Use C++ exception handling.
12253         * eval.c: Use C++ exception handling.
12254         * dwarf2read.c: Use C++ exception handling.
12255         * dwarf2loc.c: Use C++ exception handling.
12256         * dwarf2-frame.c: Use C++ exception handling.
12257         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12258         * dwarf-index-write.c: Use C++ exception handling.
12259         * dwarf-index-cache.c: Use C++ exception handling.
12260         * dtrace-probe.c: Use C++ exception handling.
12261         * disasm-selftests.c: Use C++ exception handling.
12262         * darwin-nat.c: Use C++ exception handling.
12263         * cp-valprint.c: Use C++ exception handling.
12264         * cp-support.c: Use C++ exception handling.
12265         * cp-abi.c: Use C++ exception handling.
12266         * corelow.c: Use C++ exception handling.
12267         * completer.c: Use C++ exception handling.
12268         * compile/compile-object-run.c: Use C++ exception handling.
12269         * compile/compile-object-load.c: Use C++ exception handling.
12270         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12271         * compile/compile-c-symbols.c: Use C++ exception handling.
12272         * common/selftest.c: Use C++ exception handling.
12273         * common/new-op.c: Use C++ exception handling.
12274         * cli/cli-script.c: Use C++ exception handling.
12275         * cli/cli-interp.c: Use C++ exception handling.
12276         * cli/cli-cmds.c: Use C++ exception handling.
12277         * c-varobj.c: Use C++ exception handling.
12278         * btrace.c: Use C++ exception handling.
12279         * breakpoint.c: Use C++ exception handling.
12280         * break-catch-throw.c: Use C++ exception handling.
12281         * arch-utils.c: Use C++ exception handling.
12282         * amd64-tdep.c: Use C++ exception handling.
12283         * ada-valprint.c: Use C++ exception handling.
12284         * ada-typeprint.c: Use C++ exception handling.
12285         * ada-lang.c: Use C++ exception handling.
12286         * aarch64-tdep.c: Use C++ exception handling.
12287
12288 2019-04-08  Tom Tromey  <tom@tromey.com>
12289
12290         * xml-support.c (gdb_xml_parser::parse): Update.
12291         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12292         * value.c (show_convenience): Update.
12293         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12294         (test_parse_flags_qcs): Update.
12295         * thread.c (thr_try_catch_cmd): Update.
12296         * target.c (target_translate_tls_address): Update.
12297         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12298         (info_frame_command_core, frame_apply_command_count): Update.
12299         * rust-exp.y (rust_lex_exception_test): Update.
12300         * riscv-tdep.c (riscv_print_one_register_info): Update.
12301         * remote.c (remote_target::enable_btrace): Update.
12302         * record-btrace.c (record_btrace_enable_warn): Update.
12303         * python/py-utils.c (gdbpy_convert_exception): Update.
12304         * printcmd.c (do_one_display, print_variable_and_value): Update.
12305         * mi/mi-main.c (mi_print_exception): Update.
12306         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12307         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12308         * linux-nat.c (linux_nat_target::attach): Update.
12309         * linux-fork.c (class scoped_switch_fork_info): Update.
12310         * infrun.c (displaced_step_prepare): Update.
12311         * infcall.c (call_function_by_hand_dummy): Update.
12312         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12313         * gnu-v3-abi.c (print_one_vtable): Update.
12314         * frame.c (get_prev_frame_always): Update.
12315         * f-valprint.c (info_common_command_for_block): Update.
12316         * exec.c (try_open_exec_file): Update.
12317         * exceptions.c (print_exception, exception_print)
12318         (exception_fprintf, exception_print_same): Update.
12319         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12320         * dwarf-index-cache.c (index_cache::store)
12321         (index_cache::lookup_gdb_index): Update.
12322         * darwin-nat.c (maybe_cache_shell): Update.
12323         * cp-valprint.c (cp_print_value_fields): Update.
12324         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12325         (gcc_cplus_symbol_address): Update.
12326         * compile/compile-c-symbols.c (gcc_convert_symbol)
12327         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12328         * common/selftest.c: Update.
12329         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12330         a std::string.
12331         (exception_try_scope_entry, exception_try_scope_exit): Don't
12332         declare.
12333         (struct exception_try_scope): Remove.
12334         (TRY): Don't use exception_try_scope.
12335         (struct gdb_exception): Add constructor, operator=.
12336         <what>: New method.
12337         (struct gdb_exception_RETURN_MASK_ALL)
12338         (struct gdb_exception_RETURN_MASK_ERROR)
12339         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12340         (struct gdb_quit_bad_alloc): Update.
12341         * common/common-exceptions.c (exception_none): Change
12342         initializer.
12343         (struct catcher) <state, exception>: Initialize inline.
12344         <prev>: Remove member.
12345         (current_catcher): Remove.
12346         (catchers): New global.
12347         (exceptions_state_mc_init): Simplify.
12348         (catcher_pop): Remove.
12349         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12350         (try_scope_depth, exception_try_scope_entry)
12351         (exception_try_scope_exit): Remove.
12352         (throw_exception_sjlj): Update.
12353         (exception_messages, exception_messages_size): Remove.
12354         (throw_it): Simplify.
12355         (gdb_exception_sliced_copy): Remove.
12356         (throw_exception_cxx): Update.
12357         * cli/cli-script.c (script_from_file): Update.
12358         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12359         Update.
12360         * ada-valprint.c (ada_val_print): Update.
12361         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12362         (create_excep_cond_exprs): Update.
12363
12364 2019-04-08  Tom Tromey  <tom@tromey.com>
12365
12366         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12367         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12368         (TRY, CATCH, END_CATCH): Remove some definitions.
12369         * common/common-exceptions.c: Don't use GDB_XCPT.
12370         (catcher_list_size): Remove.
12371         (throw_exception, throw_it): Simplify.
12372
12373 2019-04-05  Tom Tromey  <tom@tromey.com>
12374
12375         Revert the header-sorting patch.
12376         * ft32-tdep.c: Revert.
12377         * frv-tdep.c: Revert.
12378         * frv-linux-tdep.c: Revert.
12379         * frame.c: Revert.
12380         * frame-unwind.c: Revert.
12381         * frame-base.c: Revert.
12382         * fork-child.c: Revert.
12383         * findvar.c: Revert.
12384         * findcmd.c: Revert.
12385         * filesystem.c: Revert.
12386         * filename-seen-cache.h: Revert.
12387         * filename-seen-cache.c: Revert.
12388         * fbsd-tdep.c: Revert.
12389         * fbsd-nat.h: Revert.
12390         * fbsd-nat.c: Revert.
12391         * f-valprint.c: Revert.
12392         * f-typeprint.c: Revert.
12393         * f-lang.c: Revert.
12394         * extension.h: Revert.
12395         * extension.c: Revert.
12396         * extension-priv.h: Revert.
12397         * expprint.c: Revert.
12398         * exec.h: Revert.
12399         * exec.c: Revert.
12400         * exceptions.c: Revert.
12401         * event-top.c: Revert.
12402         * event-loop.c: Revert.
12403         * eval.c: Revert.
12404         * elfread.c: Revert.
12405         * dwarf2read.h: Revert.
12406         * dwarf2read.c: Revert.
12407         * dwarf2loc.c: Revert.
12408         * dwarf2expr.h: Revert.
12409         * dwarf2expr.c: Revert.
12410         * dwarf2-frame.c: Revert.
12411         * dwarf2-frame-tailcall.c: Revert.
12412         * dwarf-index-write.h: Revert.
12413         * dwarf-index-write.c: Revert.
12414         * dwarf-index-common.c: Revert.
12415         * dwarf-index-cache.h: Revert.
12416         * dwarf-index-cache.c: Revert.
12417         * dummy-frame.c: Revert.
12418         * dtrace-probe.c: Revert.
12419         * disasm.h: Revert.
12420         * disasm.c: Revert.
12421         * disasm-selftests.c: Revert.
12422         * dictionary.c: Revert.
12423         * dicos-tdep.c: Revert.
12424         * demangle.c: Revert.
12425         * dcache.h: Revert.
12426         * dcache.c: Revert.
12427         * darwin-nat.h: Revert.
12428         * darwin-nat.c: Revert.
12429         * darwin-nat-info.c: Revert.
12430         * d-valprint.c: Revert.
12431         * d-namespace.c: Revert.
12432         * d-lang.c: Revert.
12433         * ctf.c: Revert.
12434         * csky-tdep.c: Revert.
12435         * csky-linux-tdep.c: Revert.
12436         * cris-tdep.c: Revert.
12437         * cris-linux-tdep.c: Revert.
12438         * cp-valprint.c: Revert.
12439         * cp-support.c: Revert.
12440         * cp-namespace.c: Revert.
12441         * cp-abi.c: Revert.
12442         * corelow.c: Revert.
12443         * corefile.c: Revert.
12444         * continuations.c: Revert.
12445         * completer.h: Revert.
12446         * completer.c: Revert.
12447         * complaints.c: Revert.
12448         * coffread.c: Revert.
12449         * coff-pe-read.c: Revert.
12450         * cli-out.h: Revert.
12451         * cli-out.c: Revert.
12452         * charset.c: Revert.
12453         * c-varobj.c: Revert.
12454         * c-valprint.c: Revert.
12455         * c-typeprint.c: Revert.
12456         * c-lang.c: Revert.
12457         * buildsym.c: Revert.
12458         * buildsym-legacy.c: Revert.
12459         * build-id.h: Revert.
12460         * build-id.c: Revert.
12461         * btrace.c: Revert.
12462         * bsd-uthread.c: Revert.
12463         * breakpoint.h: Revert.
12464         * breakpoint.c: Revert.
12465         * break-catch-throw.c: Revert.
12466         * break-catch-syscall.c: Revert.
12467         * break-catch-sig.c: Revert.
12468         * blockframe.c: Revert.
12469         * block.c: Revert.
12470         * bfin-tdep.c: Revert.
12471         * bfin-linux-tdep.c: Revert.
12472         * bfd-target.c: Revert.
12473         * bcache.c: Revert.
12474         * ax-general.c: Revert.
12475         * ax-gdb.h: Revert.
12476         * ax-gdb.c: Revert.
12477         * avr-tdep.c: Revert.
12478         * auxv.c: Revert.
12479         * auto-load.c: Revert.
12480         * arm-wince-tdep.c: Revert.
12481         * arm-tdep.c: Revert.
12482         * arm-symbian-tdep.c: Revert.
12483         * arm-pikeos-tdep.c: Revert.
12484         * arm-obsd-tdep.c: Revert.
12485         * arm-nbsd-tdep.c: Revert.
12486         * arm-nbsd-nat.c: Revert.
12487         * arm-linux-tdep.c: Revert.
12488         * arm-linux-nat.c: Revert.
12489         * arm-fbsd-tdep.c: Revert.
12490         * arm-fbsd-nat.c: Revert.
12491         * arm-bsd-tdep.c: Revert.
12492         * arch-utils.c: Revert.
12493         * arc-tdep.c: Revert.
12494         * arc-newlib-tdep.c: Revert.
12495         * annotate.h: Revert.
12496         * annotate.c: Revert.
12497         * amd64-windows-tdep.c: Revert.
12498         * amd64-windows-nat.c: Revert.
12499         * amd64-tdep.c: Revert.
12500         * amd64-sol2-tdep.c: Revert.
12501         * amd64-obsd-tdep.c: Revert.
12502         * amd64-obsd-nat.c: Revert.
12503         * amd64-nbsd-tdep.c: Revert.
12504         * amd64-nbsd-nat.c: Revert.
12505         * amd64-nat.c: Revert.
12506         * amd64-linux-tdep.c: Revert.
12507         * amd64-linux-nat.c: Revert.
12508         * amd64-fbsd-tdep.c: Revert.
12509         * amd64-fbsd-nat.c: Revert.
12510         * amd64-dicos-tdep.c: Revert.
12511         * amd64-darwin-tdep.c: Revert.
12512         * amd64-bsd-nat.c: Revert.
12513         * alpha-tdep.c: Revert.
12514         * alpha-obsd-tdep.c: Revert.
12515         * alpha-nbsd-tdep.c: Revert.
12516         * alpha-mdebug-tdep.c: Revert.
12517         * alpha-linux-tdep.c: Revert.
12518         * alpha-linux-nat.c: Revert.
12519         * alpha-bsd-tdep.c: Revert.
12520         * alpha-bsd-nat.c: Revert.
12521         * aix-thread.c: Revert.
12522         * agent.c: Revert.
12523         * addrmap.c: Revert.
12524         * ada-varobj.c: Revert.
12525         * ada-valprint.c: Revert.
12526         * ada-typeprint.c: Revert.
12527         * ada-tasks.c: Revert.
12528         * ada-lang.c: Revert.
12529         * aarch64-tdep.c: Revert.
12530         * aarch64-ravenscar-thread.c: Revert.
12531         * aarch64-newlib-tdep.c: Revert.
12532         * aarch64-linux-tdep.c: Revert.
12533         * aarch64-linux-nat.c: Revert.
12534         * aarch64-fbsd-tdep.c: Revert.
12535         * aarch64-fbsd-nat.c: Revert.
12536         * aarch32-linux-nat.c: Revert.
12537
12538 2019-04-05  Tom Tromey  <tom@tromey.com>
12539
12540         * ft32-tdep.c: Sort headers.
12541         * frv-tdep.c: Sort headers.
12542         * frv-linux-tdep.c: Sort headers.
12543         * frame.c: Sort headers.
12544         * frame-unwind.c: Sort headers.
12545         * frame-base.c: Sort headers.
12546         * fork-child.c: Sort headers.
12547         * findvar.c: Sort headers.
12548         * findcmd.c: Sort headers.
12549         * filesystem.c: Sort headers.
12550         * filename-seen-cache.h: Sort headers.
12551         * filename-seen-cache.c: Sort headers.
12552         * fbsd-tdep.c: Sort headers.
12553         * fbsd-nat.h: Sort headers.
12554         * fbsd-nat.c: Sort headers.
12555         * f-valprint.c: Sort headers.
12556         * f-typeprint.c: Sort headers.
12557         * f-lang.c: Sort headers.
12558         * extension.h: Sort headers.
12559         * extension.c: Sort headers.
12560         * extension-priv.h: Sort headers.
12561         * expprint.c: Sort headers.
12562         * exec.h: Sort headers.
12563         * exec.c: Sort headers.
12564         * exceptions.c: Sort headers.
12565         * event-top.c: Sort headers.
12566         * event-loop.c: Sort headers.
12567         * eval.c: Sort headers.
12568         * elfread.c: Sort headers.
12569         * dwarf2read.h: Sort headers.
12570         * dwarf2read.c: Sort headers.
12571         * dwarf2loc.c: Sort headers.
12572         * dwarf2expr.h: Sort headers.
12573         * dwarf2expr.c: Sort headers.
12574         * dwarf2-frame.c: Sort headers.
12575         * dwarf2-frame-tailcall.c: Sort headers.
12576         * dwarf-index-write.h: Sort headers.
12577         * dwarf-index-write.c: Sort headers.
12578         * dwarf-index-common.c: Sort headers.
12579         * dwarf-index-cache.h: Sort headers.
12580         * dwarf-index-cache.c: Sort headers.
12581         * dummy-frame.c: Sort headers.
12582         * dtrace-probe.c: Sort headers.
12583         * disasm.h: Sort headers.
12584         * disasm.c: Sort headers.
12585         * disasm-selftests.c: Sort headers.
12586         * dictionary.c: Sort headers.
12587         * dicos-tdep.c: Sort headers.
12588         * demangle.c: Sort headers.
12589         * dcache.h: Sort headers.
12590         * dcache.c: Sort headers.
12591         * darwin-nat.h: Sort headers.
12592         * darwin-nat.c: Sort headers.
12593         * darwin-nat-info.c: Sort headers.
12594         * d-valprint.c: Sort headers.
12595         * d-namespace.c: Sort headers.
12596         * d-lang.c: Sort headers.
12597         * ctf.c: Sort headers.
12598         * csky-tdep.c: Sort headers.
12599         * csky-linux-tdep.c: Sort headers.
12600         * cris-tdep.c: Sort headers.
12601         * cris-linux-tdep.c: Sort headers.
12602         * cp-valprint.c: Sort headers.
12603         * cp-support.c: Sort headers.
12604         * cp-namespace.c: Sort headers.
12605         * cp-abi.c: Sort headers.
12606         * corelow.c: Sort headers.
12607         * corefile.c: Sort headers.
12608         * continuations.c: Sort headers.
12609         * completer.h: Sort headers.
12610         * completer.c: Sort headers.
12611         * complaints.c: Sort headers.
12612         * coffread.c: Sort headers.
12613         * coff-pe-read.c: Sort headers.
12614         * cli-out.h: Sort headers.
12615         * cli-out.c: Sort headers.
12616         * charset.c: Sort headers.
12617         * c-varobj.c: Sort headers.
12618         * c-valprint.c: Sort headers.
12619         * c-typeprint.c: Sort headers.
12620         * c-lang.c: Sort headers.
12621         * buildsym.c: Sort headers.
12622         * buildsym-legacy.c: Sort headers.
12623         * build-id.h: Sort headers.
12624         * build-id.c: Sort headers.
12625         * btrace.c: Sort headers.
12626         * bsd-uthread.c: Sort headers.
12627         * breakpoint.h: Sort headers.
12628         * breakpoint.c: Sort headers.
12629         * break-catch-throw.c: Sort headers.
12630         * break-catch-syscall.c: Sort headers.
12631         * break-catch-sig.c: Sort headers.
12632         * blockframe.c: Sort headers.
12633         * block.c: Sort headers.
12634         * bfin-tdep.c: Sort headers.
12635         * bfin-linux-tdep.c: Sort headers.
12636         * bfd-target.c: Sort headers.
12637         * bcache.c: Sort headers.
12638         * ax-general.c: Sort headers.
12639         * ax-gdb.h: Sort headers.
12640         * ax-gdb.c: Sort headers.
12641         * avr-tdep.c: Sort headers.
12642         * auxv.c: Sort headers.
12643         * auto-load.c: Sort headers.
12644         * arm-wince-tdep.c: Sort headers.
12645         * arm-tdep.c: Sort headers.
12646         * arm-symbian-tdep.c: Sort headers.
12647         * arm-pikeos-tdep.c: Sort headers.
12648         * arm-obsd-tdep.c: Sort headers.
12649         * arm-nbsd-tdep.c: Sort headers.
12650         * arm-nbsd-nat.c: Sort headers.
12651         * arm-linux-tdep.c: Sort headers.
12652         * arm-linux-nat.c: Sort headers.
12653         * arm-fbsd-tdep.c: Sort headers.
12654         * arm-fbsd-nat.c: Sort headers.
12655         * arm-bsd-tdep.c: Sort headers.
12656         * arch-utils.c: Sort headers.
12657         * arc-tdep.c: Sort headers.
12658         * arc-newlib-tdep.c: Sort headers.
12659         * annotate.h: Sort headers.
12660         * annotate.c: Sort headers.
12661         * amd64-windows-tdep.c: Sort headers.
12662         * amd64-windows-nat.c: Sort headers.
12663         * amd64-tdep.c: Sort headers.
12664         * amd64-sol2-tdep.c: Sort headers.
12665         * amd64-obsd-tdep.c: Sort headers.
12666         * amd64-obsd-nat.c: Sort headers.
12667         * amd64-nbsd-tdep.c: Sort headers.
12668         * amd64-nbsd-nat.c: Sort headers.
12669         * amd64-nat.c: Sort headers.
12670         * amd64-linux-tdep.c: Sort headers.
12671         * amd64-linux-nat.c: Sort headers.
12672         * amd64-fbsd-tdep.c: Sort headers.
12673         * amd64-fbsd-nat.c: Sort headers.
12674         * amd64-dicos-tdep.c: Sort headers.
12675         * amd64-darwin-tdep.c: Sort headers.
12676         * amd64-bsd-nat.c: Sort headers.
12677         * alpha-tdep.c: Sort headers.
12678         * alpha-obsd-tdep.c: Sort headers.
12679         * alpha-nbsd-tdep.c: Sort headers.
12680         * alpha-mdebug-tdep.c: Sort headers.
12681         * alpha-linux-tdep.c: Sort headers.
12682         * alpha-linux-nat.c: Sort headers.
12683         * alpha-bsd-tdep.c: Sort headers.
12684         * alpha-bsd-nat.c: Sort headers.
12685         * aix-thread.c: Sort headers.
12686         * agent.c: Sort headers.
12687         * addrmap.c: Sort headers.
12688         * ada-varobj.c: Sort headers.
12689         * ada-valprint.c: Sort headers.
12690         * ada-typeprint.c: Sort headers.
12691         * ada-tasks.c: Sort headers.
12692         * ada-lang.c: Sort headers.
12693         * aarch64-tdep.c: Sort headers.
12694         * aarch64-ravenscar-thread.c: Sort headers.
12695         * aarch64-newlib-tdep.c: Sort headers.
12696         * aarch64-linux-tdep.c: Sort headers.
12697         * aarch64-linux-nat.c: Sort headers.
12698         * aarch64-fbsd-tdep.c: Sort headers.
12699         * aarch64-fbsd-nat.c: Sort headers.
12700         * aarch32-linux-nat.c: Sort headers.
12701
12702 2019-04-04  Tom Tromey  <tom@tromey.com>
12703
12704         * varobj.c (varobj_create): Update.
12705         * rust-exp.y (struct rust_parser) <update_innermost_block,
12706         lookup_symbol>: New methods.
12707         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12708         Rename.
12709         (rust_parser::rust_lookup_type)
12710         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12711         * printcmd.c (display_command, do_one_display): Update.
12712         * parser-defs.h (struct parser_state) <parser_state>: Add
12713         "tracker" parameter.
12714         (block_tracker): New member.
12715         (class innermost_block_tracker) <innermost_block_tracker>: Add
12716         "types" parameter.
12717         <reset>: Remove method.
12718         (innermost_block): Don't declare.
12719         (null_post_parser): Update.
12720         * parse.c (innermost_block): Remove global.
12721         (write_dollar_variable): Update.
12722         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12723         Remove "tracker_types" parameter.
12724         (parse_expression): Add "tracker" parameter.
12725         (parse_expression_for_completion): Update.
12726         (null_post_parser): Add "tracker" parameter.
12727         * p-exp.y: Update rules.
12728         * m2-exp.y: Update rules.
12729         * language.h (struct language_defn) <la_post_parser>: Add
12730         "tracker" parameter.
12731         * go-exp.y: Update rules.
12732         * f-exp.y: Update rules.
12733         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12734         parameter.
12735         * d-exp.y: Update rules.
12736         * c-exp.y: Update rules.
12737         * breakpoint.c (set_breakpoint_condition): Create an
12738         innermost_block_tracker.
12739         (watch_command_1): Likewise.
12740         * ada-lang.c (resolve): Add "tracker" parameter.
12741         (resolve_subexp): Likewise.
12742         * ada-exp.y (write_var_from_sym): Update.
12743
12744 2019-04-04  Tom Tromey  <tom@tromey.com>
12745
12746         * type-stack.h: New file.
12747         * type-stack.c: New file.
12748         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12749         type-stack.h.
12750         (insert_into_type_stack, insert_type, push_type, push_type_int)
12751         (insert_type_address_space, pop_type, pop_type_int)
12752         (pop_typelist, pop_type_stack, append_type_stack)
12753         (push_type_stack, get_type_stack, push_typelist)
12754         (follow_type_instance_flags, follow_types): Don't declare.
12755         * parse.c (type_stack): Remove global.
12756         (parse_exp_in_context): Update.
12757         (insert_into_type_stack, insert_type, push_type, push_type_int)
12758         (insert_type_address_space, pop_type, pop_type_int)
12759         (pop_typelist, pop_type_stack, append_type_stack)
12760         (push_type_stack, get_type_stack, push_typelist)
12761         (follow_type_instance_flags, follow_types): Remove (moved to
12762         type-stack.c).
12763         * f-exp.y (type_stack): New global.
12764         Update rules.
12765         (push_kind_type, f_parse): Update.
12766         * d-exp.y (type_stack): New global.
12767         Update rules.
12768         (d_parse): Update.
12769         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12770         Update rules.
12771         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12772         (HFILES_NO_SRCDIR): Add type-stack.h.
12773
12774 2019-04-04  Tom Tromey  <tom@tromey.com>
12775
12776         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12777         (rust_parser::convert_ast_to_expression, rust_parse)
12778         (rust_lex_test_completion, rust_lex_tests): Update.
12779         * parser-defs.h (struct expr_completion_state): New.
12780         (struct parser_state) <parser_state>: Add completion parameter.
12781         <mark_struct_expression, mark_completion_tag>: New methods.
12782         <parse_completion, m_completion_state>: New members.
12783         (prefixify_expression, null_post_parser): Update.
12784         (mark_struct_expression, mark_completion_tag): Don't declare.
12785         * parse.c (parse_completion, expout_last_struct)
12786         (expout_tag_completion_type, expout_completion_name): Remove
12787         globals.
12788         (parser_state::mark_struct_expression)
12789         (parser_state::mark_completion_tag): Now methods.
12790         (prefixify_expression): Add last_struct parameter.
12791         (prefixify_subexp): Likewise.
12792         (parse_exp_1): Update.
12793         (parse_exp_in_context): Add cstate parameter.  Update.
12794         (parse_expression_for_completion): Create an
12795         expr_completion_state.
12796         (null_post_parser): Add "completion" parameter.
12797         * p-exp.y: Update rules.
12798         (yylex): Update.
12799         * language.h (struct language_defn) <la_post_parser>: Add
12800         "completing" parameter.
12801         * go-exp.y: Update rules.
12802         (lex_one_token): Update.
12803         * expression.h (parse_completion): Don't declare.
12804         * d-exp.y: Update rules.
12805         (lex_one_token): Update rules.
12806         * c-exp.y: Update rules.
12807         (lex_one_token): Update.
12808         * ada-lang.c (resolve): Add "parse_completion" parameter.
12809         (resolve_subexp): Likewise.
12810         (ada_resolve_function): Likewise.
12811
12812 2019-04-04  Tom Tromey  <tom@tromey.com>
12813
12814         * parser-defs.h (struct parser_state) <start_arglist,
12815         end_arglist>: New methods.
12816         <arglist_len, m_funcall_chain>: New members.
12817         (arglist_len, start_arglist, end_arglist): Don't declare.
12818         * parse.c (arglist_len, funcall_chain): Remove global.
12819         (start_arglist, end_arglist): Remove functions.
12820         (parse_exp_in_context): Update.
12821         * p-exp.y: Update rules.
12822         * m2-exp.y: Update rules.
12823         * go-exp.y: Update rules.
12824         * f-exp.y: Update rules.
12825         * d-exp.y: Update rules.
12826         * c-exp.y: Update rules.
12827
12828 2019-04-04  Tom Tromey  <tom@tromey.com>
12829
12830         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12831         lex_operator, push_back>: New methods.
12832         Update all rules.
12833         (rust_parser::lex_hex, lex_escape): Rename and update.
12834         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12835         (rust_parser::lex_operator): Rename and update.
12836         (rust_parser::lex_number, rustyylex, rustyyerror)
12837         (rust_lex_test_init, rust_lex_test_sequence)
12838         (rust_lex_test_push_back, rust_lex_tests): Update.
12839         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12840         parameter.
12841         <lexptr, prev_lexptr>: New members.
12842         (lexptr, prev_lexptr): Don't declare.
12843         * parse.c (lexptr, prev_lexptr): Remove globals.
12844         (parse_exp_in_context): Update.
12845         * p-exp.y (yylex, yyerror): Update.
12846         * m2-exp.y (parse_number, yylex, yyerror): Update.
12847         * go-exp.y (lex_one_token, yyerror): Update.
12848         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12849         * d-exp.y (lex_one_token, yyerror): Update.
12850         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12851         (lex_one_token, yyerror): Update.
12852         * ada-lex.l (YY_INPUT): Update.
12853         (rewind_to_char): Update.
12854         * ada-exp.y (yyerror): Update.
12855
12856 2019-04-04  Tom Tromey  <tom@tromey.com>
12857
12858         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12859         * parser-defs.h (struct parser_state) <parser_state>: Add new
12860         parameter.
12861         <comma_terminates>: New member.
12862         (comma_terminates): Don't declare global.
12863         * parse.c (comma_terminates): Remove global.
12864         (parse_exp_in_context): Update.
12865         * p-exp.y (yylex): Update.
12866         * m2-exp.y (yylex): Update.
12867         * go-exp.y (lex_one_token): Update.
12868         * f-exp.y (yylex): Update.
12869         * d-exp.y (lex_one_token): Update.
12870         * c-exp.y (lex_one_token): Update.
12871         * ada-lex.l: Update.
12872
12873 2019-04-04  Tom Tromey  <tom@tromey.com>
12874
12875         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12876         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12877         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12878         * parser-defs.h (paren_depth): Don't declare.
12879         * parse.c (paren_depth): Remove global.
12880         (parse_exp_in_context): Update.
12881         * p-exp.y (paren_depth): New global.
12882         (pascal_parse): Initialize it.
12883         * m2-exp.y (paren_depth): New global.
12884         (m2_parse): Initialize it.
12885         * go-exp.y (paren_depth): New global.
12886         (go_parse): Initialize it.
12887         * f-exp.y (paren_depth): New global.
12888         (f_parse): Initialize it.
12889         * d-exp.y (paren_depth): New global.
12890         (d_parse): Initialize it.
12891         * c-exp.y (paren_depth): New global.
12892         (c_parse): Initialize it.
12893         * ada-lex.l (paren_depth): New global.
12894         (lexer_init): Initialize it.
12895
12896 2019-04-04  Tom Tromey  <tom@tromey.com>
12897
12898         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12899         (rust_parser::convert_ast_to_type)
12900         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12901         * parser-defs.h (struct parser_state) <parser_state>: Add
12902         parameters.  Initialize new members.
12903         <expression_context_block, expression_context_pc>: New members.
12904         * parse.c (expression_context_block, expression_context_pc):
12905         Remove globals.
12906         (parse_exp_in_context): Update.
12907         * p-exp.y: Update all rules.
12908         (yylex): Update.
12909         * m2-exp.y: Update all rules.
12910         (yylex): Update.
12911         * go-exp.y (yylex): Update.
12912         * f-exp.y (yylex): Update.
12913         * d-exp.y: Update all rules.
12914         (yylex): Update.
12915         * c-exp.y: Update all rules.
12916         (lex_one_token, classify_name, yylex, c_parse): Update.
12917         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12918
12919 2019-04-04  Tom Tromey  <tom@tromey.com>
12920
12921         * gdbarch.h, gdbarch.c: Rebuild.
12922         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12923         * stap-probe.h:
12924         (struct stap_parse_info): Replace "parser_state" with
12925         "expr_builder".
12926         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12927         (parser_state): New class.
12928         * parse.c (expr_builder): Rename.
12929         (expr_builder::release): Rename.
12930         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12931         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12932         (write_exp_elt_longcst, write_exp_elt_floatcst)
12933         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12934         (write_exp_string_vector, write_exp_bitstring)
12935         (write_exp_msymbol, mark_struct_expression)
12936         (write_dollar_variable)
12937         (insert_type_address_space, increase_expout_size): Replace
12938         "parser_state" with "expr_builder".
12939         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12940         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12941         "parser_state" with "expr_builder".
12942
12943 2019-04-04  Tom Tromey  <tom@tromey.com>
12944
12945         * rust-exp.y: Replace "parse_language" with method call.
12946         * p-exp.y:
12947         (yylex): Replace "parse_language" with method call.
12948         * m2-exp.y:
12949         (yylex): Replace "parse_language" with method call.
12950         * go-exp.y (classify_name): Replace "parse_language" with method
12951         call.
12952         * f-exp.y (yylex): Replace "parse_language" with method call.
12953         * d-exp.y (lex_one_token): Replace "parse_language" with method
12954         call.
12955         * c-exp.y:
12956         (lex_one_token, classify_name, yylex): Replace "parse_language"
12957         with method call.
12958         * ada-exp.y (find_primitive_type, type_char)
12959         (type_system_address): Replace "parse_language" with method call.
12960
12961 2019-04-04  Tom Tromey  <tom@tromey.com>
12962
12963         * rust-exp.y: Replace "parse_gdbarch" with method call.
12964         * parse.c (write_dollar_variable, insert_type_address_space):
12965         Replace "parse_gdbarch" with method call.
12966         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12967         call.
12968         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12969         call.
12970         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12971         "parse_gdbarch" with method call.
12972         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12973         with method call.
12974         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12975         "parse_gdbarch" with method call.
12976         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12977         "parse_gdbarch" with method call.
12978         * c-exp.y (parse_type, parse_number, classify_name): Replace
12979         "parse_gdbarch" with method call.
12980         * ada-lex.l: Replace "parse_gdbarch" with method call.
12981         * ada-exp.y (parse_type, find_primitive_type, type_char)
12982         (type_system_address): Replace "parse_gdbarch" with method call.
12983
12984 2019-04-04  Tom Tromey  <tom@tromey.com>
12985
12986         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12987         * stap-probe.c (stap_parse_argument): Update.
12988         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12989         initial_size parameter.
12990         * rust-exp.y (rust_lex_tests): Update.
12991         * parse.c (parser_state): Update.
12992         (parse_exp_in_context): Update.
12993         * parser-defs.h (struct parser_state) <parser_state>: Remove
12994         "initial_size" parameter.
12995
12996 2019-04-04  Tom Tromey  <tom@tromey.com>
12997
12998         * parser-defs.h (increase_expout_size): Don't declare.
12999         * parse.c (increase_expout_size): Now static.
13000
13001 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
13002
13003         * gnu-nat.c (gnu_nat_target::wait): Fix
13004         target_waitstatus_to_string call.
13005
13006 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13007
13008         * eval.c (evaluate_subexp_standard): Handle internal functions
13009         during Fortran function call handling.
13010
13011 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13012
13013         * NEWS: Mention new internal functions.
13014         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
13015         (read_base_type): Use dwarf2_init_complex_target_type.
13016         * value.c (creal_internal_fn): New function.
13017         (cimag_internal_fn): New function.
13018         (_initialize_values): Register new internal functions.
13019
13020 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13021
13022         * infrun.c (stop_all_threads): If debug_infrun, always
13023         trace the wait status after wait_one, using
13024         target_waitstatus_to_string and target_pid_to_str.
13025         (handle_inferior_event): Replace various trace of
13026         wait status kind by a single trace.
13027         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
13028         wait status kind image by target_waitstatus_to_string.
13029         * target/waitstatus.c (target_waitstatus_to_string): Fix
13030         obsolete comment.
13031
13032 2019-04-01  Tom Tromey  <tromey@adacore.com>
13033
13034         PR symtab/23331:
13035         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
13036
13037 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
13038             Pedro Alves  <palves@redhat.com>
13039
13040         * top.c (quit_force): Call 'finalize_values'.
13041         * value.c (finalize_values): New function.
13042         * value.h (finalize_values): Declare.
13043
13044 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
13045
13046         * NEWS: Announce $_gdb_major and $_gdb_minor.
13047
13048         * top.c (init_gdb_version_vars): New function.
13049         (gdb_init): Call init_gdb_version_vars.
13050
13051 2019-03-29  Tom Tromey  <tromey@adacore.com>
13052
13053         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
13054         help text.  Remove dead code.
13055
13056 2019-03-29  Keith Seitz  <keiths@redhat.com>
13057
13058         From Siddhesh Poyarekar:
13059         * f-lang.h (f77_get_upperbound): Return LONGEST.
13060         (f77_get_lowerbound): Likewise.
13061         * f-typeprint.c (f_type_print_varspec_suffix): Expand
13062         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
13063         print them.
13064         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
13065         plongest to format print it.
13066         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13067         (f77_get_upperbound): Likewise.
13068         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13069         LOWER_BOUND to LONGEST.
13070         (f77_create_arrayprint_offset_tbl): Likewise.
13071
13072 2019-03-29  Keith Seitz  <keiths@redhat.com>
13073
13074         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13075         %s/pulongest for TYPE_LENGTH instead of %d in format
13076         strings.
13077         * ada-typerint.c (ada_print_type): Likewise.
13078         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13079         * compile/compile-c-support.c (generate_register_struct): Likewise.
13080         * gdbtypes.c (recursive_dump_type): Likewise.
13081         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13082         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
13083         instead of %d in format strings.
13084         * riscv-tdep.c (riscv_type_alignment): Cast second argument
13085         to std::min to ULONGEST.
13086         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13087         instead of %d in format strings.
13088         * tracepoint.c (info_scope_command): Likewise.
13089         * typeprint.c (print_offset_data::update)
13090         (print_offset_data::finish): Likewise.
13091         * xtensa-tdep.c (xtensa_store_return_value)
13092         (xtensa_push_dummy_call): Likewise.
13093
13094 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
13095
13096         * windows-nat.c (display_selector): Fixed format specifications
13097         for 64-bit Cygwin.
13098
13099 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13100
13101         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13102
13103 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
13104
13105         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13106         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13107         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13108         (nios2_linux_init_abi): Install it.
13109
13110 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13111
13112         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13113
13114 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13115
13116         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13117
13118 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13119             Tom Tromey  <tromey@adacore.com>
13120
13121         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13122
13123 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
13124
13125         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13126         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13127         method to compute the bounds of range types. Also print "[evaluated]"
13128         if the bounds' values come from a dynamic evaluation.
13129
13130 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13131
13132         * cp-valprint.c (cp_print_value_fields): Don't print trailing
13133         whitespace when pretty printing is on.
13134
13135 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13136
13137         * ppc-linux-nat.c: Add include.
13138
13139 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13140
13141         * NEWS: Mention AArch64 Pointer Authentication.
13142
13143 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13144
13145         * arm-linux-nat.c: Add include.
13146
13147 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
13148
13149         * source-cache.c (source_cache::get_source_lines): Re-read
13150         fullname after calling open_source_file.
13151
13152 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
13153
13154         * NEWS: Mention TLS support for FreeBSD.
13155
13156 2019-03-25  Tom Tromey  <tromey@adacore.com>
13157
13158         * minsyms.c (BUNCH_SIZE): Update comment.
13159         (~minimal_symbol_reader): Remove old comment.
13160         (compact_minimal_symbols): Update comment.
13161         (minimal_symbol_reader::install): Remove old comment.  Update
13162         other comments.
13163
13164 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13165
13166         * s390-linux-nat.c: Add include.
13167
13168 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13169
13170         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13171         Call linux_get_hwcap.
13172         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13173         Likewise.
13174         (aarch64_linux_get_hwcap): Remove function.
13175         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13176         declaration.
13177         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13178         linux_get_hwcap.
13179         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13180         * linux-tdep.c (linux_get_hwcap): Add function.
13181         (linux_get_hwcap2): Likewise.
13182         * linux-tdep.h (linux_get_hwcap): Add declaration.
13183         (linux_get_hwcap2): Likewise.
13184         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13185         (ppc_linux_get_hwcap2): Likewise.
13186         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13187         linux_get_hwcap.
13188         (ppc_linux_nat_target::insert_watchpoint): Likewise.
13189         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13190         (ppc_linux_nat_target::read_description): Likewise.
13191         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13192         * s390-linux-nat.c: Likewise.
13193         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13194
13195 2019-03-24  Tom Tromey  <tom@tromey.com>
13196
13197         * ada-lang.c (standard_lookup): Simplify initialization.
13198         (ada_lookup_symbol_nonlocal): Simplify return.
13199         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13200         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13201         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13202         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13203         initialization.
13204         * solib.c (solib_global_lookup): Simplify.
13205         * symtab.c (null_block_symbol): Remove.
13206         (symbol_cache_lookup): Simplify returns.
13207         (lookup_language_this): Simplify returns.
13208         (lookup_symbol_aux): Simplify return.
13209         (lookup_local_symbol): Simplify returns.
13210         (lookup_global_symbol_from_objfile): Simplify return.
13211         (lookup_symbol_in_objfile_symtabs)
13212         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13213         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13214         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13215         * cp-namespace.c (cp_lookup_bare_symbol)
13216         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13217         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13218         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13219         (cp_lookup_symbol_via_imports): Simplify initialization.
13220         (find_symbol_in_baseclass): Likewise.
13221         * symtab.h (null_block_symbol): Remove.
13222         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13223         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13224         (d_lookup_symbol_module): Likewise.
13225         (find_symbol_in_baseclass): Simplify initialization.
13226
13227 2019-03-24  Tom Tromey  <tom@tromey.com>
13228
13229         * expression.h: Don't include symtab.h.
13230         (struct block): Forward declare.
13231
13232 2019-03-24  Tom Tromey  <tom@tromey.com>
13233
13234         * c-exp.y (typebase): Remove casts.
13235         * gdbtypes.c (lookup_unsigned_typename, )
13236         (lookup_signed_typename): Remove cast.
13237         * eval.c (parse_to_comma_and_eval): Remove cast.
13238         * parse.c (write_dollar_variable): Remove cast.
13239         * block.h (struct block) <superblock>: Now const.
13240         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13241         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13242         (map_block): Make "block" const.
13243         * symfile.h (struct quick_symbol_functions)
13244         <map_matching_symbols>: Constify block argument to "callback".
13245         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13246         const.
13247         (find_pc_sect_compunit_symtab): Make "b" const.
13248         (find_symbol_at_address): Likewise.
13249         (search_symbols): Likewise.
13250         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13251         (dw2_debug_names_lookup_symbol): Likewise.
13252         (dw2_map_matching_symbols): Update.
13253         * p-valprint.c (pascal_val_print): Remove "block".
13254         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13255         (aux_add_nonlocal_symbols): Make "block" const.
13256         (resolve_subexp): Remove cast.
13257         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13258         const.
13259         (iterate_over_file_blocks): Likewise.
13260         * f-exp.y (%union) <bval>: Remove.
13261         * coffread.c (patch_opaque_types): Make "b" const.
13262         * spu-tdep.c (spu_catch_start): Make "block" const.
13263         * c-valprint.c (print_unpacked_pointer): Remove "block".
13264         * symmisc.c (dump_symtab_1): Make "b" const.
13265         (block_depth): Make "block" const.
13266         * d-exp.y (%union) <bval>: Remove.
13267         * cp-support.h (cp_lookup_rtti_type): Update.
13268         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13269         * psymtab.c (psym_lookup_symbol): Make "block" const.
13270         (maintenance_check_psymtabs): Make "b" const.
13271         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13272         (enumerate_locals, enumerate_args): Update.
13273         * python/py-symtab.c (stpy_global_block): Make "block" const.
13274         (stpy_static_block): Likewise.
13275         * inline-frame.c (block_starting_point_at): Make "new_block"
13276         const.
13277         * block.c (find_block_in_blockvector): Make return type const.
13278         (blockvector_for_pc_sect): Make "b" const.
13279         (find_block_in_blockvector): Make "b" const.
13280
13281 2019-03-23  Tom Tromey  <tom@tromey.com>
13282
13283         * varobj.c (varobj_create): Update.
13284         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13285         * printcmd.c (display_command, do_one_display): Don't reset
13286         innermost_block.
13287         * parser-defs.h (enum innermost_block_tracker_type): Move to
13288         expression.h.
13289         (innermost_block): Update comment.
13290         * parse.c (parse_exp_1): Add tracker_types parameter.
13291         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13292         tracker_types parameter.  Reset innermost_block.
13293         (parse_exp_in_context): Remove.
13294         (parse_expression_for_completion): Update.
13295         * objfiles.c (~objfile): Don't reset expression_context_block or
13296         innermost_block.
13297         * expression.h (enum innermost_block_tracker_type): Move from
13298         parser-defs.h.
13299         (parse_exp_1): Add tracker_types parameter.
13300         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13301         reset innermost_block.
13302
13303 2019-03-23  Tom Tromey  <tom@tromey.com>
13304
13305         * objfiles.h: Include bcache.h.
13306
13307 2019-03-23  Tom Tromey  <tom@tromey.com>
13308
13309         * linespec.c (get_current_search_block): Use
13310         scoped_restore_current_language.
13311         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13312
13313 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13314             Jiong Wang  <jiong.wang@arm.com>
13315
13316         * aarch64-linux-tdep.c
13317         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13318         section.
13319         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13320
13321 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13322             Jiong Wang  <jiong.wang@arm.com>
13323
13324         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13325         instructions.
13326         (aarch64_analyze_prologue_test): Add PACIASP test.
13327         (aarch64_prologue_prev_register): Unmask PC value.
13328
13329 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13330             Jiong Wang  <jiong.wang@arm.com>
13331
13332         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13333         (aarch64_dwarf2_prev_register): Unmask PC value.
13334         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13335         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13336         DW_CFA_AARCH64_negate_ra_state.
13337         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13338
13339 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13340             Jiong Wang  <jiong.wang@arm.com>
13341
13342         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13343         registers.
13344         (aarch64_pseudo_register_name): Likewise.
13345         (aarch64_pseudo_register_type): Likewise.
13346         (aarch64_pseudo_register_reggroup_p): Likewise.
13347         (aarch64_gdbarch_init): Add pauth registers.
13348         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13349         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13350         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13351         (struct gdbarch_tdep): Add regnum for ra_state.
13352
13353 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13354             Jiong Wang  <jiong.wang@arm.com>
13355
13356         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13357
13358 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13359             Jiong Wang  <jiong.wang@arm.com>
13360
13361         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13362         function.
13363         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13364         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13365         (aarch64_gdbarch_init): Add puth registers.
13366         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13367         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13368         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13369
13370 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13371             Jiong Wang  <jiong.wang@arm.com>
13372
13373         * aarch64-linux-nat.c
13374         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13375         * aarch64-linux-tdep.c
13376         (aarch64_linux_core_read_description): Likewise.
13377         (aarch64_linux_get_hwcap): New function.
13378         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13379         (aarch64_linux_get_hwcap): New declaration.
13380
13381 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13382             Jiong Wang  <jiong.wang@arm.com>
13383
13384         * aarch64-linux-nat.c
13385         (aarch64_linux_nat_target::read_description): Add pauth param.
13386         * aarch64-linux-tdep.c
13387         (aarch64_linux_core_read_description): Likewise.
13388         * aarch64-tdep.c (struct target_desc): Add in pauth.
13389         (aarch64_read_description): Add pauth param.
13390         (aarch64_gdbarch_init): Likewise.
13391         * aarch64-tdep.h (aarch64_read_description): Likewise.
13392         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13393         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13394         * features/Makefile: Add new files.
13395         * features/aarch64-pauth.c: New file.
13396         * features/aarch64-pauth.xml: New file.
13397
13398 2019-03-20  Tom Tromey  <tromey@adacore.com>
13399
13400         * infrun.c (handle_inferior_event): Rename from
13401         handle_inferior_event_1.  Create a scoped_value_mark.
13402         (handle_inferior_event): Remove.
13403
13404 2019-03-19  Tom Tromey  <tromey@adacore.com>
13405
13406         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13407         * infrun.h (print_stop_event): Add "displays" parameter.
13408         * infrun.c (print_stop_event): Add "displays" parameter.
13409
13410 2019-03-19  Pedro Alves  <palves@redhat.com>
13411
13412         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13413         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13414         to -1.  Fix TABs vs spaces.
13415         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13416         * tui/tui-out.h (tui_ui_out) Add intro comments.
13417         <m_line, m_start_of_line>: In-class initialize, and add describing
13418         comment.
13419
13420 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13421
13422         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13423         variable names.
13424         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13425
13426 2019-03-18  Pedro Alves  <palves@redhat.com>
13427             Eli Zaretskii <eliz@gnu.org>
13428
13429         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13430         m_line and m_start_of_line.
13431
13432 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13433
13434         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13435         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13436         it returns a newline.  This fixes a regression in TU mode, whereby
13437         the next line is output on the same screen line as the user input.
13438
13439 2019-03-18  Tom Tromey  <tromey@adacore.com>
13440
13441         * minsyms.c (minimal_symbol_reader::install): Remove call to
13442         obstack_blank.
13443
13444 2019-03-18  Pedro Alves  <palves@redhat.com>
13445
13446         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13447         New globals.
13448         (apply_style): New, factored out from ...
13449         (apply_ansi_escape): ... this.  Handle reverse video mode.
13450         (tui_set_reverse_mode): New function.
13451         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13452         * tui/tui-winsource.c (tui_show_source_line): Use
13453         tui_set_reverse_mode instead of setting A_STANDOUT.
13454         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13455         New setter methods.
13456
13457 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13458
13459         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13460         Handle tabs.
13461
13462 2019-03-18  Tom Tromey  <tromey@adacore.com>
13463
13464         * ada-lang.c (empty_array): Add "high" parameter.
13465         (ada_evaluate_subexp): Update.
13466
13467 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13468
13469         * unittests/string_view-selftests.c: Define
13470         _initialize_string_view_selftests unconditionally.
13471
13472 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13473
13474         PR gdb/24350
13475         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13476
13477 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13478
13479         PR gdb/24351
13480         * windows-nat.c (display_selector): Fix format specifiers.
13481
13482 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13483
13484         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13485         tui_refill_source_window instead of tui_refresh_win, to update the
13486         current execution line.  This fixes redisplay of the current line
13487         when stepping through the code with "next" or "step".
13488
13489 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13490
13491         * source-cache.c (source_cache::get_source_lines): Call
13492         find_source_lines to initialize s->nlines.  This fixes vertical
13493         scrolling of TUI source window when the DOWN arrow is pressed.
13494
13495 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13496
13497         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13498         linux-thread-db.c (_initialize_thread_db): Likewise.
13499
13500 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13501
13502         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13503         wclrtoeol in tui_show_source_line".  This reverts changes made in
13504         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13505
13506 2019-03-15  Tom Tromey  <tom@tromey.com>
13507
13508         * symtab.h (struct minimal_symbol): Derive from
13509         general_symbol_info.
13510         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13511         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13512         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13513         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13514         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13515         (MSYMBOL_SEARCH_NAME): Update.
13516         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13517         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13518         * minsyms.c (minimal_symbol_reader::record_full): Update.
13519
13520 2019-03-15  Tom Tromey  <tom@tromey.com>
13521
13522         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13523
13524 2019-03-15  Tom Tromey  <tom@tromey.com>
13525
13526         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13527         unique_xmalloc_ptr.
13528         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13529         Update.
13530         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13531         (build_minimal_symbol_hash_tables)
13532         (minimal_symbol_reader::install): Update.
13533
13534 2019-03-15  Tom Tromey  <tom@tromey.com>
13535
13536         * symtab.c (create_demangled_names_hash): Update.
13537         (symbol_set_names): Update.
13538         * objfiles.h (struct objfile_per_bfd_storage)
13539         <demangled_names_hash>: Now an htab_up.
13540         * objfiles.c (objfile_per_bfd_storage): Simplify.
13541
13542 2019-03-15  Tom Tromey  <tom@tromey.com>
13543
13544         * objfiles.h (struct objfile_per_bfd_storage): Declare
13545         destructor.
13546         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13547         New.
13548         (get_objfile_bfd_data): Use new.  Don't initialize
13549         language_of_main.
13550         (free_objfile_per_bfd_storage): Remove.
13551         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13552
13553 2019-03-15  Tom Tromey  <tom@tromey.com>
13554
13555         * symfile.c (reread_symbols): Update.
13556         * objfiles.c (objfile::objfile): Update.
13557         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13558         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13559         comment.
13560         (minimal_symbol_reader::install): Update.
13561         (terminate_minimal_symbol_table): Remove.
13562         * jit.c (jit_object_close_impl): Update.
13563
13564 2019-03-15  Tom Tromey  <tom@tromey.com>
13565
13566         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13567         initializations.
13568
13569 2019-03-15  Tom Tromey  <tom@tromey.com>
13570
13571         * objfiles.h (struct objfile_per_bfd_storage)
13572         <demangled_hash_languages>: Now a bitset.
13573         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13574         (lookup_minimal_symbol): Update.
13575
13576 2019-03-15  Tom Tromey  <tom@tromey.com>
13577
13578         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13579         Don't return the symbol.
13580         * coffread.c (record_minimal_symbol): Use record_full.
13581
13582 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13583
13584         The MS-Windows port of ncurses fails to switch to a color pair if
13585         one or both of the colors are the implicit default colors.  This
13586         change records the default colors when TUI is initialized, and
13587         then specifies them explicitly when a color pair uses the default
13588         colors.  This allows color styling in TUI mode on MS-Windows.
13589
13590         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13591         ncurses_norm_attr.
13592         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13593         colors in ncurses_norm_attr.
13594         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13595         "none", replace it with the default color recorded in
13596         ncurses_norm_attr.
13597
13598 2019-03-14  Tom Tromey  <tromey@adacore.com>
13599
13600         * source-cache.h (class source_cache) <get_source_lines>: Return
13601         std::string.
13602         * source-cache.c (source_cache::extract_lines): Handle case where
13603         first_pos==npos.  Return std::string.
13604         (source_cache::get_source_lines): Update.
13605
13606 2019-03-14  Tom Tromey  <tromey@adacore.com>
13607
13608         * NEWS: Add item for "style sources" commands.
13609         * source-cache.c (source_cache::get_source_lines): Check
13610         source_styling.
13611         * cli/cli-style.c (source_styling): New global.
13612         (_initialize_cli_style): Add "style sources" commands.
13613         (show_style_sources): New function.
13614         * cli/cli-style.h (source_styling): Declare.
13615
13616 2019-03-14  Pedro Alves  <palves@redhat.com>
13617             Tom Tromey  <tromey@adacore.com>
13618
13619         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13620         * tui/tui-winsource.c (tui_refill_source_window): New function,
13621         from...
13622         (tui_horizontal_source_scroll): ... here.  Move some logic.
13623         * cli/cli-style.c (set_style_enabled): Notify new observable.
13624         * tui/tui-hooks.c (tui_redisplay_source): New function.
13625         (tui_attach_detach_observers): Attach or detach
13626         tui_redisplay_source.
13627         * observable.h (source_styling_changed): New observable.
13628         * observable.c: Define source_styling_changed observable.
13629
13630 2019-03-13  Tom Tromey  <tromey@adacore.com>
13631
13632         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13633         (i386_gnu_nat_target::store_registers): Update.
13634         * target-debug.h (target_debug_print_std_string): New macro.
13635         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13636         * windows-tdep.c (display_one_tib): Update.
13637         * tui/tui-stack.c (tui_make_status_line): Update.
13638         * top.c (print_inferior_quit_action): Update.
13639         * thread.c (thr_try_catch_cmd): Update.
13640         (add_thread_with_info): Update.
13641         (thread_target_id_str): Update.
13642         (thr_try_catch_cmd): Update.
13643         (thread_command): Update.
13644         (thread_find_command): Update.
13645         * record-btrace.c (record_btrace_target::info_record)
13646         (record_btrace_resume_thread, record_btrace_target::resume)
13647         (record_btrace_cancel_resume, record_btrace_step_thread)
13648         (record_btrace_target::wait, record_btrace_target::wait)
13649         (record_btrace_target::wait, record_btrace_target::stop): Update.
13650         * progspace.c (print_program_space): Update.
13651         * process-stratum-target.c
13652         (process_stratum_target::thread_address_space): Update.
13653         * linux-fork.c (linux_fork_mourn_inferior)
13654         (detach_checkpoint_command, info_checkpoints_command)
13655         (linux_fork_context): Update.
13656         (linux_fork_detach): Update.
13657         (class scoped_switch_fork_info): Update.
13658         (delete_checkpoint_command): Update.
13659         * infrun.c (follow_fork_inferior): Update.
13660         (follow_fork_inferior): Update.
13661         (proceed_after_vfork_done): Update.
13662         (handle_vfork_child_exec_or_exit): Update.
13663         (follow_exec): Update.
13664         (displaced_step_prepare_throw): Update.
13665         (displaced_step_restore): Update.
13666         (start_step_over): Update.
13667         (resume_1): Update.
13668         (clear_proceed_status_thread): Update.
13669         (proceed): Update.
13670         (print_target_wait_results): Update.
13671         (do_target_wait): Update.
13672         (context_switch): Update.
13673         (stop_all_threads): Update.
13674         (restart_threads): Update.
13675         (finish_step_over): Update.
13676         (handle_signal_stop): Update.
13677         (switch_back_to_stepped_thread): Update.
13678         (keep_going_pass_signal): Update.
13679         (print_exited_reason): Update.
13680         (normal_stop): Update.
13681         * inferior.c (inferior_pid_to_str): Change return type.
13682         (print_selected_inferior): Update.
13683         (add_inferior): Update.
13684         (detach_inferior): Update.
13685         * dummy-frame.c (fprint_dummy_frames): Update.
13686         * dcache.c (dcache_info_1): Update.
13687         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13688         (btrace_fetch, btrace_clear): Update.
13689         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13690         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13691         type.
13692         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13693         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13694         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13695         * gdbarch.c, gdbarch.h: Rebuild.
13696         * gdbarch.sh (core_pid_to_str): Change return type.
13697         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13698         return type.
13699         (windows_nat_target::pid_to_str): Change return type.
13700         (windows_delete_thread): Update.
13701         (windows_nat_target::attach): Update.
13702         (windows_nat_target::files_info): Update.
13703         * target-delegates.c: Rebuild.
13704         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13705         return type.
13706         (sol_thread_target::pid_to_str): Change return type.
13707         * remote.c (class remote_target) <pid_to_str>: Change return
13708         type.
13709         (remote_target::pid_to_str): Change return type.
13710         (extended_remote_target::attach, remote_target::remote_stop_ns)
13711         (remote_target::remote_notif_remove_queued_reply)
13712         (remote_target::push_stop_reply, remote_target::disable_btrace):
13713         Update.
13714         (extended_remote_target::attach): Update.
13715         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13716         type.
13717         (gdbsim_target::pid_to_str): Change return type.
13718         * ravenscar-thread.c (struct ravenscar_thread_target)
13719         <pid_to_str>: Change return type.
13720         (ravenscar_thread_target::pid_to_str): Change return type.
13721         * procfs.c (class procfs_target) <pid_to_str>: Change return
13722         type.
13723         (procfs_target::pid_to_str): Change return type.
13724         (procfs_target::attach): Update.
13725         (procfs_target::detach): Update.
13726         (procfs_target::fetch_registers): Update.
13727         (procfs_target::store_registers): Update.
13728         (procfs_target::wait): Update.
13729         (procfs_target::files_info): Update.
13730         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13731         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13732         return type.
13733         (nto_procfs_target::pid_to_str): Change return type.
13734         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13735         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13736         return type.
13737         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13738         (exit_lwp): Update.
13739         (attach_proc_task_lwp_callback, get_detach_signal)
13740         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13741         (linux_nat_target::resume, wait_lwp, stop_callback)
13742         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13743         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13744         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13745         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13746         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13747         type.
13748         (inf_ptrace_target::attach): Update.
13749         (inf_ptrace_target::files_info): Update.
13750         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13751         type.
13752         (go32_nat_target::pid_to_str): Change return type.
13753         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13754         (gnu_nat_target::wait): Update.
13755         (gnu_nat_target::wait): Update.
13756         (gnu_nat_target::resume): Update.
13757         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13758         (fbsd_nat_target::wait): Update.
13759         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13760         type.
13761         (darwin_nat_target::attach): Update.
13762         * corelow.c (class core_target) <pid_to_str>: Change return type.
13763         (core_target::pid_to_str): Change return type.
13764         * target.c (normal_pid_to_str): Change return type.
13765         (default_pid_to_str): Likewise.
13766         (target_pid_to_str): Change return type.
13767         (target_translate_tls_address): Update.
13768         (target_announce_detach): Update.
13769         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13770         return type.
13771         (bsd_uthread_target::pid_to_str): Change return type.
13772         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13773         type.
13774         (bsd_kvm_target::pid_to_str): Change return type.
13775         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13776         return type.
13777         (aix_thread_target::pid_to_str): Change return type.
13778         * target.h (struct target_ops) <pid_to_str>: Change return type.
13779         (target_pid_to_str, normal_pid_to_str): Likewise.
13780         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13781         type.
13782         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13783         type.
13784         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13785         return type.
13786         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13787         type.
13788         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13789         type.
13790         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13791         return type.
13792
13793 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13794
13795         * NEWS: Mention that the new default MI version is 3.  Mention
13796         changes to the output of commands and events that deal with
13797         multi-location breakpoints.
13798         * breakpoint.c: Include "mi/mi-out.h".
13799         (print_one_breakpoint): Change output syntax if using MI version
13800         >= 3.
13801         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13802         New.
13803         (mi_multi_location_breakpoint_output_fixed): New.
13804         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13805         (mi_cmd_fix_multi_location_breakpoint_output): New.
13806         (mi_multi_location_breakpoint_output_fixed): New.
13807         * mi/mi-cmds.c (mi_cmds): Register command
13808         -fix-multi-location-breakpoint-output.
13809         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13810         interpreter "mi".
13811
13812 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13813
13814         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13815         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13816         instantiate mi_ui_out based on interpreter name.
13817         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13818         * mi/mi-main.c (mi_load_progress): Likewise.
13819
13820 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13821
13822         * NEWS: Combine separate "New targets" sections for 8.3.
13823
13824 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13825
13826         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13827         (ppcfbsd_init_abi): Install gdbarch
13828         "fetch_tls_load_module_address" and "get_thread_local_address"
13829         methods.
13830
13831 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13832
13833         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13834         (riscv_fbsd_init_abi): Install gdbarch
13835         "fetch_tls_load_module_address" and "get_thread_local_address"
13836         methods.
13837
13838 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13839
13840         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13841         (i386fbsd_init_abi): Install gdbarch
13842         "fetch_tls_load_module_address" and "get_thread_local_address"
13843         methods.
13844
13845 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13846
13847         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13848         (amd64fbsd_init_abi): Install gdbarch
13849         "fetch_tls_load_module_address" and "get_thread_local_address"
13850         methods.
13851
13852 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13853
13854         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13855         (struct fbsd_pspace_data): New type.
13856         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13857         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13858         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13859         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13860         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13861
13862 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13863
13864         * gdbtypes.c (lookup_struct_elt): New function.
13865         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13866         * gdbtypes.h (struct struct_elt): New type.
13867         (lookup_struct_elt): New prototype.
13868
13869 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13870
13871         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13872         remove disabled code block.
13873
13874 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13875
13876         * gdbarch.sh (get_thread_local_address): New method.
13877         * gdbarch.h, gdbarch.c: Regenerate.
13878         * target.c (target_translate_tls_address): Use
13879         gdbarch_get_thread_local_address if present instead of
13880         target::get_thread_local_address.
13881
13882 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13883
13884         * target.h (target::get_thread_local_address): Update comment.
13885
13886 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13887
13888         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13889         objfile->separate_debug_objfile_backlink if not NULL.
13890
13891 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13892
13893         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13894         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13895         (amd64bsd_store_inferior_registers): Likewise.
13896         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13897         Enable segment base registers.
13898         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13899         PT_GETFSBASE and PT_GETGSBASE.
13900         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13901         PT_SETGSBASE.
13902         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13903         segment base registers.
13904         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13905
13906 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13907
13908         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13909         Update calls to i386_target_description to add 'segments'
13910         parameter.
13911         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13912         add segment base registers.
13913         * arch/i386.c (i386_create_target_description): Add 'segments'
13914         parameter to enable segment base registers.
13915         * arch/i386.h (i386_create_target_description): Likewise.
13916         * features/i386/32bit-segments.xml: New file.
13917         * features/i386/32bit-segments.c: Generate.
13918         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13919         call to i386_target_description to add 'segments' parameter.
13920         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13921         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13922         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13923         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13924         if feature is present.
13925         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13926         Add 'segments' parameter to call to i386_target_description.
13927         (i386_target_description): Add 'segments' parameter to enable
13928         segment base registers.
13929         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13930         to call to i386_target_description.
13931         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13932         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13933         Define I386_NUM_REGS.
13934         (i386_target_description): Add 'segments' parameter to enable
13935         segment base registers.
13936
13937 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13938
13939         PR/24325
13940         * source-cache.c: #undef open and close, to avoid unresolved
13941         externals during linking.
13942
13943 2019-03-12  Tom Tromey  <tromey@adacore.com>
13944
13945         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13946         const.  Add initializers.
13947         (_initialize_remote): Don't initialize ptid globals.
13948
13949 2019-03-12  Pedro Alves  <palves@redhat.com>
13950
13951         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13952
13953 2019-03-12  Pedro Alves  <palves@redhat.com>
13954
13955         * cp-name-parser.y (main): Remove unused 'len' variable.
13956
13957 2019-03-12  Tom Tromey  <tromey@adacore.com>
13958
13959         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13960         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13961
13962 2019-03-12  Tom Tromey  <tromey@adacore.com>
13963
13964         * linux-nat.c (iterate_over_lwps): Update.
13965         (stop_callback): Remove parameter.
13966         (stop_wait_callback, detach_callback, resume_set_callback)
13967         (select_singlestep_lwp_callback, set_ignore_sigint)
13968         (status_callback, resumed_callback, resume_clear_callback)
13969         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13970         data parameter.
13971         (linux_nat_target::detach, linux_nat_target::resume)
13972         (linux_stop_and_wait_all_lwps, select_event_lwp)
13973         (linux_nat_filter_event, linux_nat_wait_1)
13974         (linux_nat_target::kill, linux_nat_target::stop)
13975         (linux_nat_target::stop): Update.
13976         (linux_nat_resume_callback): Change type.
13977         (resume_stopped_resumed_lwps, count_events_callback)
13978         (select_event_lwp_callback): Likewise.
13979         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13980         * arm-linux-nat.c (struct update_registers_data): Remove.
13981         (update_registers_callback): Change type.
13982         (arm_linux_insert_hw_breakpoint1): Update.
13983         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13984         parameter.
13985         (x86_linux_dr_set_addr): Update.
13986         (x86_linux_dr_set_control): Update.
13987         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13988         (iterate_over_lwps): Use gdb::function_view.
13989         * nat/aarch64-linux-hw-point.c (struct
13990         aarch64_dr_update_callback_param): Remove.
13991         (debug_reg_change_callback): Change type.
13992         (aarch64_notify_debug_reg_change): Update.
13993         * s390-linux-nat.c (s390_refresh_per_info): Update.
13994
13995 2019-03-11  Tom Tromey  <tromey@adacore.com>
13996
13997         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13998         redundant assignment to "this_cu".
13999
14000 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14001
14002         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
14003
14004 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14005
14006         * gdbtypes.c (rank_one_type_parm_set): New function extracted
14007         from...
14008         (rank_one_type): ... this.
14009
14010 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14011
14012         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
14013         from...
14014         (rank_one_type): ... this.
14015
14016 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14017
14018         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
14019         from...
14020         (rank_one_type): ... this.
14021
14022 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14023
14024         * gdbtypes.c (rank_one_type_parm_float): New function extracted
14025         from...
14026         (rank_one_type): ... this.
14027
14028 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14029
14030         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
14031         from...
14032         (rank_one_type): ... this.
14033
14034 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14035
14036         * gdbtypes.c (rank_one_type_parm_range): New function extracted
14037         from...
14038         (rank_one_type): ... this.
14039
14040 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14041
14042         * gdbtypes.c (rank_one_type_parm_char): New function extracted
14043         from...
14044         (rank_one_type): ... this.
14045
14046 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14047
14048         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
14049         from...
14050         (rank_one_type): ... this.
14051
14052 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14053
14054         * gdbtypes.c (rank_one_type_parm_int): New function extracted
14055         from...
14056         (rank_one_type): ... this.
14057
14058 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14059
14060         * gdbtypes.c (rank_one_type_parm_func): New function extracted
14061         from...
14062         (rank_one_type): ... this.
14063
14064 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14065
14066         * gdbtypes.c (rank_one_type_parm_array): New function extracted
14067         from...
14068         (rank_one_type): ... this.
14069
14070 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14071
14072         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14073         from...
14074         (rank_one_type): ... this.
14075
14076 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14077
14078         * inferior.c (initialize_inferiors): Ensure 'help set/show print
14079         inferior-events' shows the example events.
14080
14081 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
14082
14083         Support styling on native MS-Windows console
14084
14085         PR/24315
14086         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14087         on MS-Windows if $TERM is not defined.
14088
14089         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14090
14091         * posix-hdep.c (gdb_console_fputs):
14092         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14093         functions.
14094         * ui-file.h (gdb_console_fputs): Add prototype.
14095
14096         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14097         back to fputs only if the former returns zero.
14098
14099 2019-03-07  Tom Tromey  <tom@tromey.com>
14100
14101         * symmisc.c (print_symbol_bcache_statistics): Update.
14102         (print_objfile_statistics): Update.
14103         * symfile.c (allocate_symtab): Update.
14104         * stabsread.c: Don't include bcache.h.
14105         * psymtab.h (struct psymbol_bcache): Don't declare.
14106         (class psymtab_storage) <psymbol_cache>: Now a bcache.
14107         (psymbol_bcache_init, psymbol_bcache_free)
14108         (psymbol_bcache_get_bcache): Don't declare.
14109         * psymtab.c (struct psymbol_bcache): Remove.
14110         (psymtab_storage::psymtab_storage): Update.
14111         (psymtab_storage::~psymtab_storage): Update.
14112         (psymbol_bcache_init, psymbol_bcache_free)
14113         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14114         (add_psymbol_to_bcache): Update.
14115         (allocate_psymtab): Update.
14116         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14117         macro_cache>: No longer pointers.
14118         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14119         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14120         * macrotab.c (macro_bcache): Update.
14121         * macroexp.c: Don't include bcache.h.
14122         * gdbtypes.c (check_types_worklist): Update.
14123         (types_deeply_equal): Remove TRY/CATCH.  Update.
14124         * elfread.c (elf_symtab_read): Update.
14125         * dwarf2read.c: Don't include bcache.h.
14126         * buildsym.c (buildsym_compunit::get_macro_table): Update.
14127         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14128         (print_bcache_statistics, bcache_memory_used): Don't declare.
14129         (struct bcache): Move from bcache.c.  Add constructor, destructor,
14130         methods.  Rename all data members.
14131         * bcache.c (struct bcache): Move to bcache.h.
14132         (bcache::expand_hash_table): Rename from expand_hash_table.
14133         (bcache): Remove.
14134         (bcache::insert): Rename from bcache_full.
14135         (bcache::compare): Rename from bcache_compare.
14136         (bcache_xmalloc): Remove.
14137         (bcache::~bcache): Rename from bcache_xfree.
14138         (bcache::print_statistics): Rename from print_bcache_statistics.
14139         (bcache::memory_used): Rename from bcache_memory_used.
14140
14141 2019-03-07  Pedro Alves  <palves@redhat.com>
14142
14143         * infrun.c (normal_stop): Also check for
14144         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14145
14146 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
14147
14148         * f-lang.c (value_from_host_double): Moved to...
14149         * value.c (value_from_host_double): ...here.
14150         * value.h (value_from_host_double): Declare.
14151         * guile/scm-math.c (vlscm_convert_typed_number): Use
14152         value_from_host_double.
14153         (vlscm_convert_number): Likewise.
14154         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14155         * python/py-value.c (convert_value_from_python): Likewise.
14156
14157 2019-03-06  Tom Tromey  <tom@tromey.com>
14158
14159         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14160
14161 2019-03-06  Tom Tromey  <tom@tromey.com>
14162
14163         * utils.h (free_current_contents): Don't declare.
14164         * utils.c (free_current_contents): Remove.
14165
14166 2019-03-06  Tom Tromey  <tom@tromey.com>
14167
14168         * top.c (quit_force): Update.
14169         * main.c (captured_command_loop): Update.
14170         * common/new-op.c (operator new): Update.
14171         * common/common-exceptions.c (struct catcher)
14172         <save_cleanup_chain>: Remove member.
14173         (exceptions_state_mc_init): Update.
14174         (exception_try_scope_entry): Return nullptr.
14175         (exception_try_scope_exit, exception_rethrow)
14176         (throw_exception_sjlj, throw_exception_cxx): Update.
14177         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14178         (all_cleanups, do_cleanups, discard_cleanups)
14179         (discard_final_cleanups, save_cleanups, save_final_cleanups)
14180         (restore_cleanups, restore_final_cleanups): Don't declare.
14181         (do_final_cleanups): Remove parameter.
14182         * common/cleanups.c (cleanup_chain, make_cleanup)
14183         (make_cleanup_dtor, all_cleanups, do_cleanups)
14184         (discard_my_cleanups, discard_cleanups)
14185         (discard_final_cleanups, save_my_cleanups, save_cleanups)
14186         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14187         (null_cleanup): Remove.
14188         (do_final_cleanups): Remove parameter.
14189
14190 2019-03-06  Tom Tromey  <tom@tromey.com>
14191
14192         * remote.c (remote_target::remote_parse_stop_reply): Use
14193         unique_xmalloc_ptr.
14194
14195 2019-03-06  Tom Tromey  <tom@tromey.com>
14196
14197         * stabsread.c (struct stabs_field_info): Rename from field_info.
14198         <list, fnlist>: Add initializers.
14199         <obstack>: New member.
14200         (read_member_functions, read_struct_fields, read_baseclasses):
14201         Allocate on obstack.  Don't use cleanups.
14202         (read_one_struct_field, read_member_functions, read_struct_fields)
14203         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14204         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14205         (read_struct_type): Update.
14206
14207 2019-03-06  Tom Tromey  <tom@tromey.com>
14208
14209         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14210         * common/filestuff.h (make_cleanup_close): Don't declare.
14211         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14212         Remove.
14213
14214 2019-03-06  Tom Tromey  <tom@tromey.com>
14215
14216         * solib-aix.c: Use make_scope_exit.
14217
14218 2019-03-06  Tom Tromey  <tom@tromey.com>
14219
14220         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14221         Use make_scope_exit.
14222
14223 2019-03-06  Tom Tromey  <tom@tromey.com>
14224
14225         * solib-svr4.c (disable_probes_interface): Remove parameter.
14226         (svr4_handle_solib_event): Use make_scope_exit.
14227
14228 2019-03-06  Tom Tromey  <tom@tromey.com>
14229
14230         * remote.c (struct stop_reply_deleter): Remove.
14231         (stop_reply_up): Update.
14232         (struct stop_reply): Derive from notif_event.  Don't typedef.
14233         <regcache>: Now a std::vector.
14234         (stop_reply_xfree): Remove.
14235         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14236         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14237         (remote_target::discard_pending_stop_replies): Use delete.
14238         (remote_target::remote_parse_stop_reply): Update.
14239         (remote_target::process_stop_reply): Update.
14240         * remote-notif.h (struct notif_event): Add virtual destructor.
14241         Remove "dtr" member.
14242         (struct notif_client) <alloc_event>: Return a unique_ptr.
14243         (notif_event_xfree): Don't declare.
14244         (notif_event_up): New typedef.
14245         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14246         (notif_event_xfree, do_notif_event_xfree): Remove.
14247         (remote_notif_state_xfree): Update.
14248
14249 2019-03-06  Tom Tromey  <tom@tromey.com>
14250
14251         * infrun.c (displaced_step_clear_cleanup): Now a
14252         forward_scope_exit type.
14253         (displaced_step_prepare_throw): Update.
14254         (displaced_step_fixup): Update.
14255
14256 2019-03-06  Tom Tromey  <tom@tromey.com>
14257
14258         * inferior.h (class inferior): Update comment.
14259         * gdbthread.h (class thread_info): Update comment.
14260
14261 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14262             Tom Tromey  <tom@tromey.com>
14263
14264         * stabsread.h (struct stab_section_list): Remove.
14265         (coffstab_build_psymtabs): Update.
14266         * dbxread.c (symbuf_sections): Now a std::vector.
14267         (sect_idx): New global.
14268         (fill_symbuf): Update.
14269         (coffstab_build_psymtabs): Change type of stabsects parameter.
14270         Update.
14271         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14272         std::vector.
14273         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14274         (coff_locate_sections): Update.
14275         (coff_symfile_read): Remove cleanups.  Update.
14276         (init_stringtab): Add storage parameter.
14277         (free_stringtab, free_stringtab_cleanup): Remove.
14278         (init_lineno): Add storage parameter.
14279         (free_linetab, free_linetab_cleanup): Remove.
14280
14281 2019-03-06  Pedro Alves  <palves@redhat.com>
14282
14283         * linux-fork.c (fork_info::clobber_regs): Delete.
14284         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14285         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14286         comment.  Adjust.
14287         (scoped_switch_fork_info::scoped_switch_fork_info)
14288         (checkpoint_command, linux_fork_context): Adjust
14289         fork_save_infrun_state calls.
14290
14291 2019-03-06  Pedro Alves  <palves@redhat.com>
14292
14293         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14294         (inf_has_multiple_threads): Return 'bool' and rewrite using
14295         inferior_info::threads().
14296
14297 2019-03-06  Pedro Alves  <palves@redhat.com>
14298
14299         * linux-fork.c: Include <list>.
14300         (fork_list): Now a std::list instance.
14301         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14302         (forks_exist_p, find_last_fork): Adjust.
14303         (new_fork): Delete.
14304         (one_fork_p): New.
14305         (add_fork): Adjust.
14306         (free_fork): Delete, folded into fork_info::~fork_info().
14307         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14308         Adjust.
14309         (init_fork_list): Delete.
14310         (linux_fork_killall, linux_fork_mourn_inferior)
14311         (linux_fork_detach, info_checkpoints_command): Adjust.
14312         (_initialize_linux_fork): No longer call init_fork_list.
14313
14314 2019-03-06  Pedro Alves  <palves@redhat.com>
14315
14316         * linux-fork.c (new_fork): New, split out of ...
14317         (add_fork): ... this.  Return void.  Move "first fork" special
14318         case from here, to ...
14319         (checkpoint_command): ... here.
14320         * linux-linux.h (add_fork): Return void.
14321
14322 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14323
14324         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14325
14326 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14327             Chris January  <chris.january@arm.com>
14328             David Lecomber  <david.lecomber@arm.com>
14329
14330         * f-exp.y: New token, UNOP_INTRINSIC.
14331         (exp): New pattern using UNOP_INTRINSIC token.
14332         (f77_keywords): Add 'abs' keyword.
14333         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14334         (value_from_host_double): New function.
14335         (evaluate_subexp_f): Support UNOP_ABS.
14336
14337 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14338
14339         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14340         types.
14341
14342 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14343
14344         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14345         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14346         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14347
14348 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14349
14350         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14351
14352 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14353             Chris January  <chris.january@arm.com>
14354
14355         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14356         * f-exp.y: Define 'KIND' token.
14357         (exp): New pattern for KIND expressions.
14358         (ptype): Handle types with a kind extension.
14359         (direct_abs_decl): Extend to spot kind extensions.
14360         (f77_keywords): Add 'kind' to the list.
14361         (push_kind_type): New function.
14362         (convert_to_kind_type): New function.
14363         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14364         * parse.c (operator_length_standard): Likewise.
14365         * parser-defs.h (enum type_pieces): Add tp_kind.
14366         * std-operator.def: Add UNOP_KIND.
14367
14368 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14369
14370         * f-exp.y (f_parse): Set yydebug.
14371
14372 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14373
14374         * f-lang.c (evaluate_subexp_f): New function.
14375         (exp_descriptor_f): New global.
14376         (f_language_defn): Use exp_descriptor_f instead of
14377         exp_descriptor_standard.
14378
14379 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14380
14381         * f-exp.y (struct token): Add comments.
14382         (dot_ops): Remove uppercase versions and the end marker.
14383         (f77_keywords): Likewise.
14384         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14385         entries in the dot_ops array are case insensitive, and use
14386         strncasecmp to compare strings.  Also some whitespace cleanup in
14387         this area.  Similar for the f77_keywords array, except entries in
14388         this list might be case sensitive.
14389
14390 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14391
14392         * f-exp.y (struct f77_boolean_val): Add comments.
14393         (boolean_values): Remove uppercase versions, and end marker.
14394         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14395         and use strncasecmp to achieve case insensitivity.  Additionally,
14396         perform whitespace cleanup around this code.
14397
14398 2019-03-06  Tom Tromey  <tromey@adacore.com>
14399
14400         * remote-sim.c (gdbsim_target_open): Use result of
14401         gdb_argv::release.
14402
14403 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14404         Dirk Schubert  <dirk.schubert@arm.com>
14405         Chris January  <chris.january@arm.com>
14406
14407         * eval.c (evaluate_subexp_standard): Call Fortran argument
14408         wrapping logic.
14409         * f-lang.c (struct value): A value which can be passed into a
14410         Fortran function call.
14411         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14412         where appropriate.
14413         (struct type): Value ready for a Fortran function call.
14414         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14415         is needed.
14416         * f-lang.h (fortran_argument_convert): Declaration.
14417         (fortran_preserve_arg_pointer): Declaration.
14418         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14419
14420 2019-03-05  Tom Tromey  <tromey@adacore.com>
14421
14422         * python/py-prettyprint.c (print_string_repr): Remove #if.
14423         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14424
14425 2019-03-05  Tom Tromey  <tromey@adacore.com>
14426
14427         * target.c (the_dummy_target): Move later.  Change type to
14428         "dummy_target".
14429         (initialize_targets): Don't initialize the_dummy_target.
14430
14431 2019-03-05  Tom Tromey  <tromey@adacore.com>
14432
14433         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14434         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14435
14436 2019-03-05  Tom Tromey  <tromey@adacore.com>
14437
14438         * windows-nat.c (windows_nat_target::attach)
14439         (windows_nat_target::detach): Don't call gdb_flush.
14440         * valprint.c (generic_val_print, val_print, val_print_string):
14441         Don't call gdb_flush.
14442         * utils.c (defaulted_query): Don't call gdb_flush.
14443         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14444         * target.c (target_announce_detach): Don't call gdb_flush.
14445         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14446         * remote.c (extended_remote_target::attach): Don't call
14447         gdb_flush.
14448         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14449         * printcmd.c (do_examine): Don't call gdb_flush.
14450         (info_display_command): Don't call gdb_flush.
14451         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14452         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14453         * memattr.c (info_mem_command): Don't call gdb_flush.
14454         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14455         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14456         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14457         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14458         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14459         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14460         (gnu_nat_target::detach): Don't call gdb_flush.
14461         * f-valprint.c (f_val_print): Don't call gdb_flush.
14462         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14463         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14464         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14465         gdb_flush.
14466         * c-valprint.c (c_val_print): Don't call gdb_flush.
14467         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14468
14469 2019-03-05  Tom Tromey  <tromey@adacore.com>
14470
14471         * varobj.c (update_dynamic_varobj_children): Update.
14472         (install_default_visualizer): Use reset, not release.
14473         * value.c (set_internalvar): Update.
14474         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14475         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14476         ATTRIBUTE_UNUSED_RESULT.
14477
14478 2019-03-05  Tom Tromey  <tromey@adacore.com>
14479
14480         * remote.c (class scoped_remote_fd) <release>: Add
14481         ATTRIBUTE_UNUSED_RESULT.
14482
14483 2019-03-05  Tom Tromey  <tromey@adacore.com>
14484
14485         * macroexp.c (struct macro_buffer) <release>: Add
14486         ATTRIBUTE_UNUSED_RESULT.
14487
14488 2019-03-05  Tom Tromey  <tromey@adacore.com>
14489
14490         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14491         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14492         ATTRIBUTE_UNUSED_RESULT.
14493
14494 2019-03-05  Tom Tromey  <tromey@adacore.com>
14495
14496         * common/scoped_fd.h (class scoped_fd) <release>: Add
14497         ATTRIBUTE_UNUSED_RESULT.
14498
14499 2019-03-05  Tom Tromey  <tromey@adacore.com>
14500
14501         * parser-defs.h (struct parser_state) <release>: Add
14502         ATTRIBUTE_UNUSED_RESULT.
14503
14504 2019-03-05  Tom Tromey  <tromey@adacore.com>
14505
14506         * utils.h (class gdb_argv) <release>: Add
14507         ATTRIBUTE_UNUSED_RESULT.
14508         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14509
14510 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14511
14512         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14513         for-loop range, to avoid compiler warnings.
14514
14515         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14516         avoid compiler warnings about unused variables.
14517
14518         * NEWS: Mention end of support for native debugging on MS-Windows
14519         before XP.
14520
14521         PR gdb/24292
14522         * common/netstuff.c:
14523         * gdbserver/gdbreplay.c
14524         * gdbserver/remote-utils.c:
14525         * ser-tcp.c:
14526         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14527         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14528         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14529         'getaddrinfo' and 'freeaddrinfo' were not available before
14530         Windows XP, and mingw.org's MinGW headers by default define
14531         _WIN32_WINNT to 0x500.
14532
14533 2019-03-01  Gary Benson <gbenson@redhat.com>
14534
14535         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14536
14537 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14538             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14539
14540         PR gdb/8527
14541         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14542         set_sigint_trap, clear_sigint_trap.
14543
14544 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14545
14546         * target.c (target_detach): Clear the regcache and the
14547         frame cache.
14548
14549 2019-02-27  Pedro Alves  <palves@redhat.com>
14550
14551         * utils.c (set_screen_size): When we cap the height/width sizes,
14552         tweak the corresponding command variable to show "unlimited":
14553
14554 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14555             Pedro Alves  <palves@redhat.com>
14556
14557         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14558         before calling rl_set_screen_size.
14559
14560 2019-02-27  Tom Tromey  <tromey@adacore.com>
14561
14562         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14563         define.
14564         * python/py-value.c: Remove Python 2.4 workaround.
14565         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14566         workaround.
14567         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14568         Python 2.4 workaround.
14569         * python/python-internal.h: Remove Python 2.4 comment.
14570         (Py_ssize_t): Don't define.
14571         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14572         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14573         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14574         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14575         * python/python.c (do_start_initialization): Remove Python 2.4
14576         workaround.
14577         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14578         (print_children): Remove Python 2.4 workaround.
14579         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14580         workaround.
14581         (CHARBUFFERPROC_NAME): Remove.
14582         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14583         Python 2.4 workaround.
14584
14585 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14586
14587         * NEWS: Note minimum Python version.
14588
14589 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14590
14591         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14592         code from these functions.  Remove corresponding ifdefs.  Use
14593         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14594         Remove gotos and target of gotos.
14595         (infpy_search_memory): Likewise.
14596
14597 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14598
14599         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14600         (hppa_gdbarch_init): Don't register deleted functions with
14601         gdbarch.
14602
14603 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14604
14605         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14606         (h8300_unwind_sp): Delete.
14607         (h8300_dummy_id): Delete.
14608         (h8300_gdbarch_init): Don't register deleted functions with
14609         gdbarch.
14610
14611 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14612
14613         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14614         (ft32_unwind_pc): Delete.
14615         (ft32_unwind_sp): Delete.
14616         (ft32_gdbarch_init): Don't register deleted functions with
14617         gdbarch.
14618
14619 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14620
14621         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14622         (frv_unwind_pc): Delete.
14623         (frv_unwind_sp): Delete.
14624         (frv_gdbarch_init): Don't register deleted functions with
14625         gdbarch.
14626
14627 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14628
14629         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14630         (riscv_unwind_pc): Delete.
14631         (riscv_unwind_sp): Delete.
14632         (riscv_gdbarch_init): Don't register deleted functions with
14633         gdbarch.
14634
14635 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14636
14637         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14638         (csky_unwind_pc): Delete.
14639         (csky_unwind_sp): Delete.
14640         (csky_gdbarch_init): Don't register deleted functions with
14641         gdbarch.
14642
14643 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14644
14645         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14646         (cris_unwind_pc): Delete.
14647         (cris_unwind_sp): Delete.
14648         (cris_gdbarch_init): Don't register deleted functions with
14649         gdbarch.
14650
14651 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14652
14653         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14654         (bfin_unwind_pc): Delete.
14655         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14656
14657 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14658
14659         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14660         (arm_unwind_pc): Delete.
14661         (arm_unwind_sp): Delete.
14662         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14663
14664 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14665
14666         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14667         (arc_unwind_pc): Delete.
14668         (arc_unwind_sp): Delete.
14669         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14670
14671 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14672
14673         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14674         (alpha_unwind_pc): Delete.
14675         (alpha_gdbarch_init): Don't register deleted functions with
14676         gdbarch.
14677
14678 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14679
14680         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14681         (aarch64_unwind_pc): Delete.
14682         (aarch64_unwind_sp): Delete.
14683         (aarch64_gdbarch_init): Don't register deleted functions with
14684         gdbarch.
14685
14686 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14687
14688         * gdbtypes.c (type_align): Don't consider static members when
14689         computing structure alignment.
14690
14691 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14692
14693         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14694         return 0 for other types.
14695         * arch-utils.c (default_type_align): Always return 0.
14696         * gdbarch.h: Regenerate.
14697         * gdbarch.sh (type_align): Extend comment.
14698         * gdbtypes.c (type_align): Add additional comments, always call
14699         gdbarch_type_align before applying the default rules.
14700         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14701         generic code will then apply a suitable default.
14702         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14703         types, return 0 for other types.
14704
14705 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14706
14707         * NEWS: Create a new section for the next release branch.
14708         Rename the section of the current branch, now that it has
14709         been cut.
14710
14711 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14712
14713         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14714         * version.in: Bump version to 8.3.50.DATE-git.
14715
14716 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14717
14718         * aix-thread.c (ptid_cmp): Remove unused variable.
14719         (get_signaled_thread): Likewise.
14720         (store_regs_user_thread): Likewise.
14721         (store_regs_kernel_thread): Likewise.
14722         (fetch_regs_kernel_thread): Remove shadowed variable.
14723
14724 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14725
14726         * features/riscv/32bit-cpu.xml: Add register numbers.
14727         * features/riscv/32bit-fpu.c: Regenerate.
14728         * features/riscv/32bit-fpu.xml: Add register numbers.
14729         * features/riscv/64bit-cpu.xml: Add register numbers.
14730         * features/riscv/64bit-fpu.c: Regenerate.
14731         * features/riscv/64bit-fpu.xml: Add register numbers.
14732
14733 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14734
14735         * NEWS: Mention two argument form of gdb.Value constructor.
14736         * python/py-value.c (convert_buffer_and_type_to_value): New
14737         function.
14738         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14739         Add support for handling an optional second argument.  Call
14740         convert_buffer_and_type_to_value as appropriate.
14741         * python/python-internal.h (Py_buffer_deleter): New struct.
14742         (Py_buffer_up): New typedef.
14743
14744 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14745
14746         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14747         instead of releasing ownership.
14748
14749 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14750
14751         * dwarf2read.c (open_and_init_dwp_file): Call
14752         elf_numsections instead of bfd_count_sections to initialize
14753         dwp_file->num_sections.
14754
14755 2019-02-25  Tom Tromey  <tromey@adacore.com>
14756
14757         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14758
14759 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14760
14761         * gcore.in: Add '--readnever' option when invoking GDB.
14762
14763 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14764
14765         * MAINTAINERS: Update my email address.
14766
14767 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14768
14769         * build-id.c (build_id_to_debug_bfd_1): New function.
14770         (build_id_to_debug_bfd): Look for separate debug file in
14771         sysroot.
14772
14773 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14774
14775         * gdbarch.sh: Update the copyright year range that is placed into
14776         generated files.
14777
14778 2019-02-22  Keith Seitz  <keiths@redhat.com>
14779
14780         PR symtab/23853
14781         * linespec.c (create_sals_line_offset): Search for the default
14782         symtab's filename instead of its fullname.
14783
14784 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14785
14786         * NEWS: Update style defaults.
14787
14788 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14789
14790         * main.c (captured_main_1): Disable styling in batch mode.
14791
14792 2019-02-20  Tom Tromey  <tom@tromey.com>
14793
14794         * symtab.c (symtab_symbol_info): Fix typos.
14795
14796 2019-02-20  Tom Tromey  <tromey@adacore.com>
14797
14798         * findcmd.c (_initialize_mem_search): Use upper case for
14799         metasyntactic variables.
14800
14801 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14802
14803         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14804         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14805
14806 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14807
14808         * top.h (source_file_name): Change to std::string.
14809         * top.c (source_file_name): Likewise.
14810         (command_line_input): Adjust.
14811         * cli/cli-script.c (script_from_file): Adjust.
14812
14813 2019-02-19  Tom Tromey  <tromey@adacore.com>
14814
14815         * ravenscar-thread.c
14816         (ravenscar_thread_target::update_thread_list): Don't call
14817         ada_build_task_list.
14818         * ada-lang.h (ada_build_task_list): Don't declare.
14819         * ada-tasks.c (struct ada_tasks_inferior_data)
14820         <task_list_valid_p>: Now bool.
14821         (read_known_tasks, ada_task_list_changed)
14822         (ada_tasks_invalidate_inferior_data): Update.
14823         (read_known_tasks_array): Return bool.
14824         (read_known_tasks_list): Likewise.
14825         (read_known_tasks): Return void.
14826         (ada_build_task_list): Now static.
14827
14828 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14829
14830         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14831         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14832
14833 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14834
14835         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14836         variant for ada_tasks_pspace_data_handle and
14837         ada_tasks_inferior_data_handle.
14838         (ada_tasks_pspace_data_cleanup): New function.
14839         (ada_tasks_inferior_data_cleanup): New function.
14840
14841 2019-02-17  Tom Tromey  <tom@tromey.com>
14842
14843         * macrotab.h (macro_source_fullname): Return a std::string.
14844         * macrotab.c (macro_include, check_for_redefinition)
14845         (macro_undef, macro_lookup_definition, foreach_macro)
14846         (foreach_macro_in_scope): Update.
14847         (macro_source_fullname): Return a std::string.
14848         * macrocmd.c (show_pp_source_pos): Update.
14849
14850 2019-02-17  Tom Tromey  <tom@tromey.com>
14851
14852         * macrocmd.c (show_pp_source_pos): Style the file names.
14853
14854 2019-02-17  Tom Tromey  <tom@tromey.com>
14855
14856         PR tui/24197:
14857         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14858
14859 2019-02-17  Tom Tromey  <tom@tromey.com>
14860
14861         * ada-lang.c (user_select_syms): Use filtered printing.
14862         * utils.c (wrap_style): New global.
14863         (desired_style): Remove.
14864         (emit_style_escape): Add stream parameter.
14865         (set_output_style, reset_terminal_style, prompt_for_continue):
14866         Update.
14867         (flush_wrap_buffer): Only flush gdb_stdout.
14868         (wrap_here): Set wrap_style.
14869         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14870         treat escape sequences as a character.  Change when wrap buffer is
14871         flushed.
14872         (fputs_styled): Do not set the output style when the default is
14873         requested.
14874         * ui-style.h (struct ui_file_style) <is_default>: New method.
14875         * source.c (print_source_lines_base): Emit escape sequences in one
14876         piece.
14877
14878 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14879
14880         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14881         integers and enumeration types.
14882
14883 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14884
14885         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14886         instead of lookup_symbol_in_language
14887         (do_exact_match): New function.
14888         (ada_get_symbol_name_matcher): Return do_exact_match when
14889         doing a verbatim match.
14890
14891 2019-02-15  Tom Tromey  <tromey@adacore.com>
14892
14893         * ravenscar-thread.c (ravenscar_thread_target::resume)
14894         (ravenscar_thread_target::wait): Special case wildcard requests.
14895
14896 2019-02-15  Tom Tromey  <tromey@adacore.com>
14897
14898         * ravenscar-thread.c (base_ptid): Remove.
14899         (struct ravenscar_thread_target) <close>: New method.
14900         <m_base_ptid>: New member.
14901         <update_inferior_ptid, active_task, task_is_currently_active,
14902         runtime_initialized>: Declare methods.
14903         <ravenscar_thread_target>: Add constructor.
14904         (ravenscar_thread_target::task_is_currently_active)
14905         (ravenscar_thread_target::update_inferior_ptid)
14906         (ravenscar_runtime_initialized): Rename.  Now methods.
14907         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14908         (ravenscar_thread_target::update_thread_list): Update.
14909         (ravenscar_thread_target::active_task): Now method.
14910         (ravenscar_thread_target::store_registers)
14911         (ravenscar_thread_target::prepare_to_store)
14912         (ravenscar_thread_target::prepare_to_store)
14913         (ravenscar_thread_target::mourn_inferior): Update.
14914         (ravenscar_inferior_created): Use "new" to create target.
14915         (ravenscar_thread_target::get_ada_task_ptid): Update.
14916         (_initialize_ravenscar): Don't initialize base_ptid.
14917         (ravenscar_ops): Remove global.
14918
14919 2019-02-15  Tom Tromey  <tromey@adacore.com>
14920
14921         * target.h (push_target): Declare new overload.
14922         * target.c (push_target): New overload, taking an rvalue reference.
14923         * remote.c (remote_target::open_1): Use push_target overload.
14924         * corelow.c (core_target_open): Use push_target overload.
14925
14926 2019-02-15  Tom Tromey  <tromey@adacore.com>
14927
14928         * ravenscar-thread.c (is_ravenscar_task)
14929         (ravenscar_task_is_currently_active): Return bool.
14930         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14931         (_initialize_ravenscar): Remove "(void)".
14932         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14933         Return bool.
14934
14935 2019-02-15  Tom Tromey  <tromey@adacore.com>
14936
14937         * ravenscar-thread.c (ravenscar_runtime_initializer)
14938         (has_ravenscar_runtime, get_running_thread_id)
14939         (ravenscar_thread_target::resume): Fix indentation.
14940
14941 2019-02-15  Tom Tromey  <tromey@adacore.com>
14942
14943         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14944         from ravenscar_arch_ops.
14945         (sparc_ravenscar_ops::fetch_registers)
14946         (sparc_ravenscar_ops::store_registers): Now methods.
14947         (sparc_ravenscar_prepare_to_store): Remove.
14948         (sparc_ravenscar_ops): Redefine.
14949         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14950         methods and destructor.  Remove members.
14951         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14952         (ravenscar_thread_target::store_registers)
14953         (ravenscar_thread_target::prepare_to_store): Update.
14954         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14955         Remove.
14956         (struct ppc_ravenscar_powerpc_ops): Derive from
14957         ravenscar_arch_ops.
14958         (ppc_ravenscar_powerpc_ops::fetch_registers)
14959         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14960         (ppc_ravenscar_powerpc_ops): Redefine.
14961         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14962         (ppc_ravenscar_e500_ops::fetch_registers)
14963         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14964         (ppc_ravenscar_e500_ops): Redefine.
14965         * aarch64-ravenscar-thread.c
14966         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14967         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14968         (aarch64_ravenscar_fetch_registers)
14969         (aarch64_ravenscar_store_registers): Now methods.
14970         (aarch64_ravenscar_ops): Redefine.
14971
14972 2019-02-15  Tom Tromey  <tromey@adacore.com>
14973
14974         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14975         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14976         (ravenscar_thread_target::stopped_by_watchpoint)
14977         (ravenscar_thread_target::stopped_data_address)
14978         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14979
14980 2019-02-15  Tom Tromey  <tromey@adacore.com>
14981
14982         * ravenscar-thread.c: Fix some typos.
14983
14984 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14985             Tom Tromey  <tromey@adacore.com>
14986
14987         * ada-lang.c (ada_exception_sal): Change addr_string to a
14988         std::string.
14989         (create_ada_exception_catchpoint): Update.
14990
14991 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14992             Tom Tromey  <tromey@adacore.com>
14993
14994         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14995         (bp_location_ops): Remove.
14996         (base_breakpoint_allocate_location): Update.
14997         (free_bp_location): Update.
14998         * ada-lang.c (class ada_catchpoint_location)
14999         <ada_catchpoint_location>: Remove ops parameter.
15000         (ada_catchpoint_location_dtor): Remove.
15001         (ada_catchpoint_location_ops): Remove.
15002         (allocate_location_exception): Update.
15003         * breakpoint.h (struct bp_location_ops): Remove.
15004         (class bp_location) <bp_location>: Remove bp_location_ops
15005         parameter.
15006         <~bp_location>: Add destructor.
15007         <ops>: Remove.
15008
15009 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
15010             Pedro Alves  <palves@redhat.com>
15011
15012         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
15013         'PATH_MAX'.
15014
15015 2019-02-14  David Michael  <fedora.dm0@gmail.com>
15016             Samuel Thibault  <samuel.thibault@gnu.org>
15017             Thomas Schwinge  <thomas@codesourcery.com>
15018
15019         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
15020         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
15021
15022 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
15023
15024         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
15025         (check_empty): Use "const char *".
15026
15027         * gnu-nat.c (gnu_nat_target::detach): Instead of
15028         'detach_inferior (pid)' call
15029         'detach_inferior (find_inferior_pid (pid))'.
15030
15031         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
15032         'nat/fork-inferior.o'.
15033         * gnu-nat.c: #include "nat/fork-inferior.h".
15034
15035         * gnu-nat.c (gnu_nat_target::detach): Instead of
15036         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
15037         * gnu-nat.h: #include "inf-child.h".
15038         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15039         'i386_gnu_nat_target::fetch_registers'.
15040         (gnu_store_registers): Rename/move to
15041         'i386_gnu_nat_target::store_registers'.
15042
15043         * config/i386/nm-i386gnu.h: Don't "#include" any files.
15044         * gnu-nat.h (mach_thread_info): New function.
15045         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
15046
15047         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
15048
15049 2019-02-14  Frederic Konrad  <konrad@adacore.com>
15050
15051         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
15052
15053 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
15054
15055         * windows-nat.c (windows_add_thread): Add new parameter
15056         "main_thread_p" with default value set to false.  Update
15057         function documentation as well as all callers.
15058         (windows_delete_thread): Likewise.
15059         (fake_create_process): Update call to windows_add_thread.
15060         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
15061         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15062         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15063         call to windows_delete_thread.
15064
15065 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
15066
15067         * MAINTAINERS: Add Andrew Burgess as global maintainer.
15068
15069 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15070
15071         * symfile.c (find_separate_debug_file): Use canonical path of
15072         sysroot with child_path instead of gdb_sysroot if it is valid.
15073
15074 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15075
15076         * symfile.c (find_separate_debug_file): Use child_path to
15077         determine if an object file is under a sysroot.
15078
15079 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15080
15081         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15082         unittests/child-path-selftests.c.
15083         * common/pathstuff.c (child_path): New function.
15084         * common/pathstuff.h (child_path): New prototype.
15085         * unittests/child-path-selftests.c: New file.
15086
15087 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15088
15089         * symfile.c (find_separate_debug_file): Look for separate debug
15090         files in debug directories under the sysroot.
15091
15092 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15093
15094         * symtab.h (struct minimal_symbol data_p): New const method.
15095         (struct minimal_symbol text_p): Likewise.
15096         * symtab.c (output_source_filename): Use file name style
15097         to print file name.
15098         (print_symbol_info): Likewise.
15099         (print_msymbol_info): Use address style to print addresses.
15100         Use function name style to print executable text symbols.
15101         (expand_symtab_containing_pc): Use data_p.
15102         (find_pc_sect_compunit_symtab): Likewise.
15103
15104 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15105
15106         * breakpoint.c (describe_other_breakpoints): Use address style
15107         to print addresses.
15108         (say_where): Likewise.
15109
15110 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15111
15112         * ada-typeprint.c (print_func_type): Print function name
15113         style to print function name.
15114         * c-typeprint.c (c_print_type_1): Likewise.
15115
15116 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
15117
15118         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15119         for execve.
15120
15121 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15122
15123         * c-exp.y (direct_abs_decl): Use emplace_back to record the
15124         type_stack.
15125
15126 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
15127
15128         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15129         TYPE_CODE_REF types.
15130
15131 2019-02-08  Jim Wilson  <jimw@sifive.com>
15132
15133         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15134         (riscv_linux_fregset): New.
15135         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15136
15137 2019-02-07  Tom Tromey  <tom@tromey.com>
15138
15139         * thread.c (thread_cancel_execution_command): Update.
15140         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15141         methods.
15142         (struct thread_fsm_ops): Remove.
15143         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15144         (thread_fsm_should_stop, thread_fsm_return_value)
15145         (thread_fsm_set_finished, thread_fsm_finished_p)
15146         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15147         Don't declare.
15148         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15149         * infrun.c (clear_proceed_status_thread)
15150         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15151         (print_stop_event): Update.
15152         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15153         Add constructor.
15154         (step_command_fsm_ops): Remove.
15155         (new_step_command_fsm): Remove.
15156         (step_1): Update.
15157         (step_command_fsm::should_stop): Rename from
15158         step_command_fsm_should_stop.
15159         (step_command_fsm::clean_up): Rename from
15160         step_command_fsm_clean_up.
15161         (step_command_fsm::do_async_reply_reason): Rename from
15162         step_command_fsm_async_reply_reason.
15163         (struct until_next_fsm): Inherit from thread_fsm.  Add
15164         constructor.
15165         (until_next_fsm_ops): Remove.
15166         (new_until_next_fsm): Remove.
15167         (until_next_fsm::should_stop): Rename from
15168         until_next_fsm_should_stop.
15169         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15170         (until_next_fsm::do_async_reply_reason): Rename from
15171         until_next_fsm_async_reply_reason.
15172         (struct finish_command_fsm): Inherit from thread_fsm.  Add
15173         constructor.  Change type of breakpoint.
15174         (finish_command_fsm_ops): Remove.
15175         (new_finish_command_fsm): Remove.
15176         (finish_command_fsm::should_stop): Rename from
15177         finish_command_fsm_should_stop.
15178         (finish_command_fsm::clean_up): Rename from
15179         finish_command_fsm_clean_up.
15180         (finish_command_fsm::return_value): Rename from
15181         finish_command_fsm_return_value.
15182         (finish_command_fsm::do_async_reply_reason): Rename from
15183         finish_command_fsm_async_reply_reason.
15184         (finish_command): Update.
15185         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15186         Add constructor.
15187         (call_thread_fsm_ops): Remove.
15188         (call_thread_fsm::call_thread_fsm): Rename from
15189         new_call_thread_fsm.
15190         (call_thread_fsm::should_stop): Rename from
15191         call_thread_fsm_should_stop.
15192         (call_thread_fsm::should_notify_stop): Rename from
15193         call_thread_fsm_should_notify_stop.
15194         (run_inferior_call, call_function_by_hand_dummy): Update.
15195         * cli/cli-interp.c (should_print_stop_to_console): Update.
15196         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15197         Add constructor.  Change type of location_breakpoint,
15198         caller_breakpoint.
15199         (until_break_fsm_ops): Remove.
15200         (new_until_break_fsm): Remove.
15201         (until_break_fsm::should_stop): Rename from
15202         until_break_fsm_should_stop.
15203         (until_break_fsm::clean_up): Rename from
15204         until_break_fsm_clean_up.
15205         (until_break_fsm::do_async_reply_reason): Rename from
15206         until_break_fsm_async_reply_reason.
15207         (until_break_command): Update.
15208         * thread-fsm.c: Remove.
15209         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15210
15211 2019-02-07  Tom Tromey  <tom@tromey.com>
15212
15213         * yy-remap.h: Add include guard.
15214         * xtensa-tdep.h: Add include guard.
15215         * xcoffread.h: Rename include guard.
15216         * varobj-iter.h: Add include guard.
15217         * tui/tui.h: Rename include guard.
15218         * tui/tui-winsource.h: Rename include guard.
15219         * tui/tui-wingeneral.h: Rename include guard.
15220         * tui/tui-windata.h: Rename include guard.
15221         * tui/tui-win.h: Rename include guard.
15222         * tui/tui-stack.h: Rename include guard.
15223         * tui/tui-source.h: Rename include guard.
15224         * tui/tui-regs.h: Rename include guard.
15225         * tui/tui-out.h: Rename include guard.
15226         * tui/tui-layout.h: Rename include guard.
15227         * tui/tui-io.h: Rename include guard.
15228         * tui/tui-hooks.h: Rename include guard.
15229         * tui/tui-file.h: Rename include guard.
15230         * tui/tui-disasm.h: Rename include guard.
15231         * tui/tui-data.h: Rename include guard.
15232         * tui/tui-command.h: Rename include guard.
15233         * tic6x-tdep.h: Add include guard.
15234         * target/waitstatus.h: Rename include guard.
15235         * target/wait.h: Rename include guard.
15236         * target/target.h: Rename include guard.
15237         * target/resume.h: Rename include guard.
15238         * target-float.h: Rename include guard.
15239         * stabsread.h: Add include guard.
15240         * rs6000-tdep.h: Add include guard.
15241         * riscv-fbsd-tdep.h: Add include guard.
15242         * regformats/regdef.h: Rename include guard.
15243         * record.h: Rename include guard.
15244         * python/python.h: Rename include guard.
15245         * python/python-internal.h: Rename include guard.
15246         * python/py-stopevent.h: Rename include guard.
15247         * python/py-ref.h: Rename include guard.
15248         * python/py-record.h: Rename include guard.
15249         * python/py-record-full.h: Rename include guard.
15250         * python/py-record-btrace.h: Rename include guard.
15251         * python/py-instruction.h: Rename include guard.
15252         * python/py-events.h: Rename include guard.
15253         * python/py-event.h: Rename include guard.
15254         * procfs.h: Add include guard.
15255         * proc-utils.h: Add include guard.
15256         * p-lang.h: Add include guard.
15257         * or1k-tdep.h: Rename include guard.
15258         * observable.h: Rename include guard.
15259         * nto-tdep.h: Rename include guard.
15260         * nat/x86-linux.h: Rename include guard.
15261         * nat/x86-linux-dregs.h: Rename include guard.
15262         * nat/x86-gcc-cpuid.h: Add include guard.
15263         * nat/x86-dregs.h: Rename include guard.
15264         * nat/x86-cpuid.h: Rename include guard.
15265         * nat/ppc-linux.h: Rename include guard.
15266         * nat/mips-linux-watch.h: Rename include guard.
15267         * nat/linux-waitpid.h: Rename include guard.
15268         * nat/linux-ptrace.h: Rename include guard.
15269         * nat/linux-procfs.h: Rename include guard.
15270         * nat/linux-osdata.h: Rename include guard.
15271         * nat/linux-nat.h: Rename include guard.
15272         * nat/linux-namespaces.h: Rename include guard.
15273         * nat/linux-btrace.h: Rename include guard.
15274         * nat/glibc_thread_db.h: Rename include guard.
15275         * nat/gdb_thread_db.h: Rename include guard.
15276         * nat/gdb_ptrace.h: Rename include guard.
15277         * nat/fork-inferior.h: Rename include guard.
15278         * nat/amd64-linux-siginfo.h: Rename include guard.
15279         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15280         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15281         * nat/aarch64-linux.h: Rename include guard.
15282         * nat/aarch64-linux-hw-point.h: Rename include guard.
15283         * mn10300-tdep.h: Add include guard.
15284         * mips-linux-tdep.h: Add include guard.
15285         * mi/mi-parse.h: Rename include guard.
15286         * mi/mi-out.h: Rename include guard.
15287         * mi/mi-main.h: Rename include guard.
15288         * mi/mi-interp.h: Rename include guard.
15289         * mi/mi-getopt.h: Rename include guard.
15290         * mi/mi-console.h: Rename include guard.
15291         * mi/mi-common.h: Rename include guard.
15292         * mi/mi-cmds.h: Rename include guard.
15293         * mi/mi-cmd-break.h: Rename include guard.
15294         * m2-lang.h: Add include guard.
15295         * location.h: Rename include guard.
15296         * linux-record.h: Rename include guard.
15297         * linux-nat.h: Add include guard.
15298         * linux-fork.h: Add include guard.
15299         * i386-darwin-tdep.h: Rename include guard.
15300         * hppa-linux-offsets.h: Add include guard.
15301         * guile/guile.h: Rename include guard.
15302         * guile/guile-internal.h: Rename include guard.
15303         * gnu-nat.h: Rename include guard.
15304         * gdb-stabs.h: Rename include guard.
15305         * frv-tdep.h: Add include guard.
15306         * f-lang.h: Add include guard.
15307         * event-loop.h: Add include guard.
15308         * darwin-nat.h: Rename include guard.
15309         * cp-abi.h: Rename include guard.
15310         * config/sparc/nm-sol2.h: Rename include guard.
15311         * config/nm-nto.h: Rename include guard.
15312         * config/nm-linux.h: Add include guard.
15313         * config/i386/nm-i386gnu.h: Rename include guard.
15314         * config/djgpp/nl_types.h: Rename include guard.
15315         * config/djgpp/langinfo.h: Rename include guard.
15316         * compile/gcc-cp-plugin.h: Add include guard.
15317         * compile/gcc-c-plugin.h: Add include guard.
15318         * compile/compile.h: Rename include guard.
15319         * compile/compile-object-run.h: Rename include guard.
15320         * compile/compile-object-load.h: Rename include guard.
15321         * compile/compile-internal.h: Rename include guard.
15322         * compile/compile-cplus.h: Rename include guard.
15323         * compile/compile-c.h: Rename include guard.
15324         * common/xml-utils.h: Rename include guard.
15325         * common/x86-xstate.h: Rename include guard.
15326         * common/version.h: Rename include guard.
15327         * common/vec.h: Rename include guard.
15328         * common/tdesc.h: Rename include guard.
15329         * common/selftest.h: Rename include guard.
15330         * common/scoped_restore.h: Rename include guard.
15331         * common/scoped_mmap.h: Rename include guard.
15332         * common/scoped_fd.h: Rename include guard.
15333         * common/safe-iterator.h: Rename include guard.
15334         * common/run-time-clock.h: Rename include guard.
15335         * common/refcounted-object.h: Rename include guard.
15336         * common/queue.h: Rename include guard.
15337         * common/ptid.h: Rename include guard.
15338         * common/print-utils.h: Rename include guard.
15339         * common/preprocessor.h: Rename include guard.
15340         * common/pathstuff.h: Rename include guard.
15341         * common/observable.h: Rename include guard.
15342         * common/netstuff.h: Rename include guard.
15343         * common/job-control.h: Rename include guard.
15344         * common/host-defs.h: Rename include guard.
15345         * common/gdb_wait.h: Rename include guard.
15346         * common/gdb_vecs.h: Rename include guard.
15347         * common/gdb_unlinker.h: Rename include guard.
15348         * common/gdb_unique_ptr.h: Rename include guard.
15349         * common/gdb_tilde_expand.h: Rename include guard.
15350         * common/gdb_sys_time.h: Rename include guard.
15351         * common/gdb_string_view.h: Rename include guard.
15352         * common/gdb_splay_tree.h: Rename include guard.
15353         * common/gdb_setjmp.h: Rename include guard.
15354         * common/gdb_ref_ptr.h: Rename include guard.
15355         * common/gdb_optional.h: Rename include guard.
15356         * common/gdb_locale.h: Rename include guard.
15357         * common/gdb_assert.h: Rename include guard.
15358         * common/filtered-iterator.h: Rename include guard.
15359         * common/filestuff.h: Rename include guard.
15360         * common/fileio.h: Rename include guard.
15361         * common/environ.h: Rename include guard.
15362         * common/common-utils.h: Rename include guard.
15363         * common/common-types.h: Rename include guard.
15364         * common/common-regcache.h: Rename include guard.
15365         * common/common-inferior.h: Rename include guard.
15366         * common/common-gdbthread.h: Rename include guard.
15367         * common/common-exceptions.h: Rename include guard.
15368         * common/common-defs.h: Rename include guard.
15369         * common/common-debug.h: Rename include guard.
15370         * common/cleanups.h: Rename include guard.
15371         * common/buffer.h: Rename include guard.
15372         * common/btrace-common.h: Rename include guard.
15373         * common/break-common.h: Rename include guard.
15374         * cli/cli-utils.h: Rename include guard.
15375         * cli/cli-style.h: Rename include guard.
15376         * cli/cli-setshow.h: Rename include guard.
15377         * cli/cli-script.h: Rename include guard.
15378         * cli/cli-interp.h: Rename include guard.
15379         * cli/cli-decode.h: Rename include guard.
15380         * cli/cli-cmds.h: Rename include guard.
15381         * charset-list.h: Add include guard.
15382         * buildsym-legacy.h: Rename include guard.
15383         * bfin-tdep.h: Add include guard.
15384         * ax.h: Rename include guard.
15385         * arm-linux-tdep.h: Add include guard.
15386         * arm-fbsd-tdep.h: Add include guard.
15387         * arch/xtensa.h: Rename include guard.
15388         * arch/tic6x.h: Add include guard.
15389         * arch/i386.h: Add include guard.
15390         * arch/arm.h: Rename include guard.
15391         * arch/arm-linux.h: Rename include guard.
15392         * arch/arm-get-next-pcs.h: Rename include guard.
15393         * arch/amd64.h: Add include guard.
15394         * arch/aarch64-insn.h: Rename include guard.
15395         * arch-utils.h: Rename include guard.
15396         * annotate.h: Add include guard.
15397         * amd64-darwin-tdep.h: Rename include guard.
15398         * aarch64-linux-tdep.h: Add include guard.
15399         * aarch64-fbsd-tdep.h: Add include guard.
15400         * aarch32-linux-nat.h: Add include guard.
15401
15402 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15403
15404         * macrotab.c (macro_define_internal): New function that
15405         factorizes macro_define_object_internal and macro_define_function
15406         code.
15407         (macro_define_object_internal): Use macro_define_internal.
15408         (macro_define_function): Likewise.
15409
15410 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15411
15412         * macrocmd.c (extract_identifier): Return
15413         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15414         callers.
15415
15416 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15417
15418         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15419
15420 2019-02-05  Tom Tromey  <tom@tromey.com>
15421
15422         * target.c (target_stack::unpush): Move assertion earlier.
15423
15424 2019-01-30  Tom Tromey  <tom@tromey.com>
15425
15426         PR python/23615:
15427         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15428         (gdbpy_parse_and_eval): Likewise.
15429         * python/python-internal.h (gdbpy_allow_threads): New class.
15430
15431 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15432
15433         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15434         (aarch64_fbsd_fpregmap): Move earlier.
15435         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15436         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15437         instead of individual calls to trad_frame_set_reg_addr.
15438         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15439         earlier.
15440         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15441         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15442         instead of individual calls to trad_frame_set_reg_addr.
15443
15444 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15445
15446         * CONTRIBUTE: Replace contribution list with wiki link.
15447
15448 2019-01-25  Tom Tromey  <tom@tromey.com>
15449
15450         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15451
15452 2019-01-25  Tom Tromey  <tom@tromey.com>
15453
15454         * xtensa-linux-nat.c: Fix common/ includes.
15455         * xml-support.h: Fix common/ includes.
15456         * xml-support.c: Fix common/ includes.
15457         * x86-linux-nat.c: Fix common/ includes.
15458         * windows-nat.c: Fix common/ includes.
15459         * varobj.h: Fix common/ includes.
15460         * varobj.c: Fix common/ includes.
15461         * value.c: Fix common/ includes.
15462         * valops.c: Fix common/ includes.
15463         * utils.c: Fix common/ includes.
15464         * unittests/xml-utils-selftests.c: Fix common/ includes.
15465         * unittests/utils-selftests.c: Fix common/ includes.
15466         * unittests/unpack-selftests.c: Fix common/ includes.
15467         * unittests/tracepoint-selftests.c: Fix common/ includes.
15468         * unittests/style-selftests.c: Fix common/ includes.
15469         * unittests/string_view-selftests.c: Fix common/ includes.
15470         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15471         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15472         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15473         * unittests/rsp-low-selftests.c: Fix common/ includes.
15474         * unittests/parse-connection-spec-selftests.c: Fix common/
15475         includes.
15476         * unittests/optional-selftests.c: Fix common/ includes.
15477         * unittests/offset-type-selftests.c: Fix common/ includes.
15478         * unittests/observable-selftests.c: Fix common/ includes.
15479         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15480         * unittests/memrange-selftests.c: Fix common/ includes.
15481         * unittests/memory-map-selftests.c: Fix common/ includes.
15482         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15483         * unittests/function-view-selftests.c: Fix common/ includes.
15484         * unittests/environ-selftests.c: Fix common/ includes.
15485         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15486         * unittests/common-utils-selftests.c: Fix common/ includes.
15487         * unittests/cli-utils-selftests.c: Fix common/ includes.
15488         * unittests/array-view-selftests.c: Fix common/ includes.
15489         * ui-file.c: Fix common/ includes.
15490         * tui/tui-io.c: Fix common/ includes.
15491         * tracepoint.h: Fix common/ includes.
15492         * tracepoint.c: Fix common/ includes.
15493         * tracefile-tfile.c: Fix common/ includes.
15494         * top.h: Fix common/ includes.
15495         * top.c: Fix common/ includes.
15496         * thread.c: Fix common/ includes.
15497         * target/waitstatus.h: Fix common/ includes.
15498         * target/waitstatus.c: Fix common/ includes.
15499         * target.h: Fix common/ includes.
15500         * target.c: Fix common/ includes.
15501         * target-memory.c: Fix common/ includes.
15502         * target-descriptions.c: Fix common/ includes.
15503         * symtab.h: Fix common/ includes.
15504         * symfile.c: Fix common/ includes.
15505         * stap-probe.c: Fix common/ includes.
15506         * spu-linux-nat.c: Fix common/ includes.
15507         * sparc-nat.c: Fix common/ includes.
15508         * source.c: Fix common/ includes.
15509         * solib.c: Fix common/ includes.
15510         * solib-target.c: Fix common/ includes.
15511         * ser-unix.c: Fix common/ includes.
15512         * ser-tcp.c: Fix common/ includes.
15513         * ser-pipe.c: Fix common/ includes.
15514         * ser-base.c: Fix common/ includes.
15515         * selftest-arch.c: Fix common/ includes.
15516         * s12z-tdep.c: Fix common/ includes.
15517         * rust-exp.y: Fix common/ includes.
15518         * rs6000-aix-tdep.c: Fix common/ includes.
15519         * riscv-tdep.c: Fix common/ includes.
15520         * remote.c: Fix common/ includes.
15521         * remote-notif.h: Fix common/ includes.
15522         * remote-fileio.h: Fix common/ includes.
15523         * remote-fileio.c: Fix common/ includes.
15524         * regcache.h: Fix common/ includes.
15525         * regcache.c: Fix common/ includes.
15526         * record-btrace.c: Fix common/ includes.
15527         * python/python.c: Fix common/ includes.
15528         * python/py-type.c: Fix common/ includes.
15529         * python/py-inferior.c: Fix common/ includes.
15530         * progspace.h: Fix common/ includes.
15531         * producer.c: Fix common/ includes.
15532         * procfs.c: Fix common/ includes.
15533         * proc-api.c: Fix common/ includes.
15534         * printcmd.c: Fix common/ includes.
15535         * ppc-linux-nat.c: Fix common/ includes.
15536         * parser-defs.h: Fix common/ includes.
15537         * osdata.c: Fix common/ includes.
15538         * obsd-nat.c: Fix common/ includes.
15539         * nat/x86-linux.c: Fix common/ includes.
15540         * nat/x86-linux-dregs.c: Fix common/ includes.
15541         * nat/x86-dregs.h: Fix common/ includes.
15542         * nat/x86-dregs.c: Fix common/ includes.
15543         * nat/ppc-linux.c: Fix common/ includes.
15544         * nat/mips-linux-watch.h: Fix common/ includes.
15545         * nat/mips-linux-watch.c: Fix common/ includes.
15546         * nat/linux-waitpid.c: Fix common/ includes.
15547         * nat/linux-ptrace.h: Fix common/ includes.
15548         * nat/linux-ptrace.c: Fix common/ includes.
15549         * nat/linux-procfs.c: Fix common/ includes.
15550         * nat/linux-personality.c: Fix common/ includes.
15551         * nat/linux-osdata.c: Fix common/ includes.
15552         * nat/linux-namespaces.c: Fix common/ includes.
15553         * nat/linux-btrace.h: Fix common/ includes.
15554         * nat/linux-btrace.c: Fix common/ includes.
15555         * nat/fork-inferior.c: Fix common/ includes.
15556         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15557         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15558         * nat/aarch64-linux.c: Fix common/ includes.
15559         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15560         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15561         * namespace.h: Fix common/ includes.
15562         * mips-linux-tdep.c: Fix common/ includes.
15563         * minsyms.c: Fix common/ includes.
15564         * mi/mi-parse.h: Fix common/ includes.
15565         * mi/mi-main.c: Fix common/ includes.
15566         * mi/mi-cmd-env.c: Fix common/ includes.
15567         * memrange.h: Fix common/ includes.
15568         * memattr.c: Fix common/ includes.
15569         * maint.h: Fix common/ includes.
15570         * maint.c: Fix common/ includes.
15571         * main.c: Fix common/ includes.
15572         * machoread.c: Fix common/ includes.
15573         * location.c: Fix common/ includes.
15574         * linux-thread-db.c: Fix common/ includes.
15575         * linux-nat.c: Fix common/ includes.
15576         * linux-fork.c: Fix common/ includes.
15577         * inline-frame.c: Fix common/ includes.
15578         * infrun.c: Fix common/ includes.
15579         * inflow.c: Fix common/ includes.
15580         * inferior.h: Fix common/ includes.
15581         * inferior.c: Fix common/ includes.
15582         * infcmd.c: Fix common/ includes.
15583         * inf-ptrace.c: Fix common/ includes.
15584         * inf-child.c: Fix common/ includes.
15585         * ia64-linux-nat.c: Fix common/ includes.
15586         * i387-tdep.c: Fix common/ includes.
15587         * i386-tdep.c: Fix common/ includes.
15588         * i386-linux-tdep.c: Fix common/ includes.
15589         * i386-linux-nat.c: Fix common/ includes.
15590         * i386-go32-tdep.c: Fix common/ includes.
15591         * i386-fbsd-tdep.c: Fix common/ includes.
15592         * i386-fbsd-nat.c: Fix common/ includes.
15593         * guile/scm-type.c: Fix common/ includes.
15594         * guile/guile.c: Fix common/ includes.
15595         * go32-nat.c: Fix common/ includes.
15596         * gnu-nat.c: Fix common/ includes.
15597         * gdbthread.h: Fix common/ includes.
15598         * gdbarch-selftests.c: Fix common/ includes.
15599         * gdb_usleep.c: Fix common/ includes.
15600         * gdb_select.h: Fix common/ includes.
15601         * gdb_bfd.c: Fix common/ includes.
15602         * gcore.c: Fix common/ includes.
15603         * fork-child.c: Fix common/ includes.
15604         * findvar.c: Fix common/ includes.
15605         * fbsd-nat.c: Fix common/ includes.
15606         * event-top.c: Fix common/ includes.
15607         * event-loop.c: Fix common/ includes.
15608         * dwarf2read.c: Fix common/ includes.
15609         * dwarf2loc.c: Fix common/ includes.
15610         * dwarf2-frame.c: Fix common/ includes.
15611         * dwarf-index-cache.c: Fix common/ includes.
15612         * dtrace-probe.c: Fix common/ includes.
15613         * disasm-selftests.c: Fix common/ includes.
15614         * defs.h: Fix common/ includes.
15615         * csky-tdep.c: Fix common/ includes.
15616         * cp-valprint.c: Fix common/ includes.
15617         * cp-support.h: Fix common/ includes.
15618         * cp-support.c: Fix common/ includes.
15619         * corelow.c: Fix common/ includes.
15620         * completer.h: Fix common/ includes.
15621         * completer.c: Fix common/ includes.
15622         * compile/compile.c: Fix common/ includes.
15623         * compile/compile-loc2c.c: Fix common/ includes.
15624         * compile/compile-cplus-types.c: Fix common/ includes.
15625         * compile/compile-cplus-symbols.c: Fix common/ includes.
15626         * command.h: Fix common/ includes.
15627         * cli/cli-dump.c: Fix common/ includes.
15628         * cli/cli-cmds.c: Fix common/ includes.
15629         * charset.c: Fix common/ includes.
15630         * build-id.c: Fix common/ includes.
15631         * btrace.h: Fix common/ includes.
15632         * btrace.c: Fix common/ includes.
15633         * breakpoint.h: Fix common/ includes.
15634         * breakpoint.c: Fix common/ includes.
15635         * ax.h:
15636         (enum agent_op): Fix common/ includes.
15637         * ax-general.c (struct aop_map): Fix common/ includes.
15638         * ax-gdb.c: Fix common/ includes.
15639         * auxv.c: Fix common/ includes.
15640         * auto-load.c: Fix common/ includes.
15641         * arm-tdep.c: Fix common/ includes.
15642         * arch/riscv.c: Fix common/ includes.
15643         * arch/ppc-linux-common.c: Fix common/ includes.
15644         * arch/i386.c: Fix common/ includes.
15645         * arch/arm.c: Fix common/ includes.
15646         * arch/arm-linux.c: Fix common/ includes.
15647         * arch/arm-get-next-pcs.c: Fix common/ includes.
15648         * arch/amd64.c: Fix common/ includes.
15649         * arch/aarch64.c: Fix common/ includes.
15650         * arch/aarch64-insn.c: Fix common/ includes.
15651         * arch-utils.c: Fix common/ includes.
15652         * amd64-windows-tdep.c: Fix common/ includes.
15653         * amd64-tdep.c: Fix common/ includes.
15654         * amd64-sol2-tdep.c: Fix common/ includes.
15655         * amd64-obsd-tdep.c: Fix common/ includes.
15656         * amd64-nbsd-tdep.c: Fix common/ includes.
15657         * amd64-linux-tdep.c: Fix common/ includes.
15658         * amd64-linux-nat.c: Fix common/ includes.
15659         * amd64-fbsd-tdep.c: Fix common/ includes.
15660         * amd64-fbsd-nat.c: Fix common/ includes.
15661         * amd64-dicos-tdep.c: Fix common/ includes.
15662         * amd64-darwin-tdep.c: Fix common/ includes.
15663         * agent.c: Fix common/ includes.
15664         * ada-lang.h: Fix common/ includes.
15665         * ada-lang.c: Fix common/ includes.
15666         * aarch64-tdep.c: Fix common/ includes.
15667
15668 2019-01-25  Tom Tromey  <tom@tromey.com>
15669
15670         * common/create-version.sh: Use common/version.h.
15671
15672 2019-01-24  Pedro Alves  <palves@redhat.com>
15673
15674         * infrun.c (signal_stop, signal_print, signal_program)
15675         (signal_catch, signal_pass): Now arrays instead of pointers.
15676         (update_signals_program_target, do_target_resume)
15677         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15678         * linux-nat.c (linux_nat_target::pass_signals)
15679         (linux_nat_target::create_inferior, linux_nat_target::attach):
15680         Adjust.
15681         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15682         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15683         * procfs.c (procfs_target::pass_signals): Adjust.
15684         * record-full.c (record_full_target::resume): Adjust.
15685         * remote.c (remote_target::pass_signals)
15686         (remote_target::program_signals): Adjust.
15687         * target-debug.h (target_debug_print_signals): Now takes a
15688         gdb::array_view as parameter.  Adjust.
15689         * target.h (target_ops) <pass_signals, program_signals>: Replace
15690         pointer and length parameters with gdb::array_view.
15691         (target_pass_signals, target_program_signals): Likewise.
15692         * target-delegates.c: Regenerate.
15693
15694 2019-01-24  Pedro Alves  <palves@redhat.com>
15695
15696         * common/forward-scope-exit.h
15697         (forward_scope_exit::forward_scope_exit): Pass arguments to
15698         m_bind_function directly, instead of creating a std::bind and
15699         copying that.
15700
15701 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15702
15703         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15704         for static members.
15705         (pass_in_v_vfp_candidate): Likewise.
15706
15707 2019-01-23  Tom Tromey  <tom@tromey.com>
15708             Pedro Alves  <palves@redhat.com>
15709
15710         * regcache.c (class regcache_invalidator): Remove.
15711         (regcache::raw_write): Use make_scope_exit.
15712
15713 2019-01-23  Tom Tromey  <tom@tromey.com>
15714
15715         * ui-out.h (class ui_out_emit_type): Update comment.
15716
15717 2019-01-23  Tom Tromey  <tom@tromey.com>
15718
15719         * infrun.c (fetch_inferior_event): Update comment.
15720
15721 2019-01-23  Tom Tromey  <tom@tromey.com>
15722             Pedro Alves  <palves@redhat.com>
15723
15724         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15725         parameter.
15726         (fetch_inferior_event): Use SCOPE_EXIT.
15727
15728
15729 2019-01-23  Tom Tromey  <tom@tromey.com>
15730             Pedro Alves  <palves@redhat.com>
15731
15732         * infrun.c (disable_thread_events): Delete.
15733         (stop_all_threads): Use SCOPE_EXIT.
15734
15735 2019-01-23  Tom Tromey  <tom@tromey.com>
15736             Pedro Alves  <palves@redhat.com>
15737
15738         * symfile.c: Include forward-scope-exit.h.
15739         (clear_symtab_users_cleanup): Replace forward declaration with
15740         a FORWARD_SCOPE_EXIT.
15741         (syms_from_objfile_1): Use the forward_scope_exit and
15742         gdb::optional instead of cleanup_function.
15743         (reread_symbols): Use the forward_scope_exit instead of
15744         cleanup_function.
15745         (clear_symtab_users_cleanup): Remove function.
15746
15747 2019-01-23  Tom Tromey  <tom@tromey.com>
15748             Pedro Alves  <palves@redhat.com>
15749
15750         * linux-nat.c: Include scope-exit.h.
15751         (cleanup_target_stop): Remove.
15752         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15753         SCOPE_EXIT.
15754
15755 2019-01-23  Tom Tromey  <tom@tromey.com>
15756             Pedro Alves  <palves@redhat.com>
15757
15758         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15759         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15760
15761 2019-01-23  Tom Tromey  <tom@tromey.com>
15762             Andrew Burgess  <andrew.burgess@embecosm.com>
15763             Pedro Alves  <palves@redhat.com>
15764
15765         * infrun.c (fetch_inferior_event): Use scope_exit.
15766         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15767         * top.c (execute_command): Use scope_exit.
15768         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15769         * utils.c (do_bpstat_clear_actions_cleanup)
15770         (make_bpstat_clear_actions_cleanup): Remove.
15771
15772 2019-01-23  Tom Tromey  <tom@tromey.com>
15773             Pedro Alves  <palves@redhat.com>
15774
15775         * infrun.c: Include "common/scope-exit.h"
15776         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15777         (wait_for_inferior): Use SCOPE_EXIT.
15778         (fetch_inferior_event): Use scope_exit.
15779
15780 2019-01-23  Tom Tromey  <tom@tromey.com>
15781             Pedro Alves  <palves@redhat.com>
15782
15783         * breakpoint.c (create_breakpoint): Remove cleanup.
15784
15785 2019-01-23  Tom Tromey  <tom@tromey.com>
15786             Andrew Burgess  <andrew.burgess@embecosm.com>
15787             Pedro Alves  <palves@redhat.com>
15788
15789 2019-01-23  Pedro Alves  <palves@redhat.com>
15790
15791         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15792
15793 2019-01-23  Pedro Alves  <palves@redhat.com>
15794             Andrew Burgess  <andrew.burgess@embecosm.com>
15795
15796         * gdbthread.h: Include "common/forward-scope-exit.h".
15797         (scoped_finish_thread_state): Redefine custom class in terms of
15798         forward_scope_exit.
15799
15800 2019-01-23  Pedro Alves  <palves@redhat.com>
15801             Andrew Burgess  <andrew.burgess@embecosm.com>
15802
15803         * common/forward-scope-exit.h: New file.
15804
15805 2019-01-23  Pedro Alves  <palves@redhat.com>
15806             Andrew Burgess  <andrew.burgess@embecosm.com>
15807             Tom Tromey  <tom@tromey.com>
15808
15809         * common/scope-exit.h: New file.
15810
15811 2019-01-23  Pedro Alves  <palves@redhat.com>
15812
15813         * common/preprocessor.h (ESC): Rename to ...
15814         (ESC_PARENS): ... this.
15815         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15816         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15817
15818 2019-01-23  Tom Tromey  <tom@tromey.com>
15819
15820         * language.h (class scoped_switch_to_sym_language_if_auto):
15821         Initialize m_lang in both cases.
15822
15823 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15824
15825         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15826         with XCNEW.
15827
15828 2019-01-22  Tom Tromey  <tom@tromey.com>
15829
15830         * corelow.c: Do not include sys/file.h.
15831
15832 2019-01-22  Tom Tromey  <tom@tromey.com>
15833
15834         * tui/tui-wingeneral.h: Include gdb_curses.h.
15835
15836 2019-01-22  Tom Tromey  <tom@tromey.com>
15837
15838         * source-cache.h (class source_cache) <get_source_lines,
15839         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15840
15841 2019-01-22  Tom Tromey  <tom@tromey.com>
15842
15843         * remote-fileio.h (struct remote_target): Declare.
15844
15845 2019-01-22  Tom Tromey  <tom@tromey.com>
15846
15847         * python/py-arch.c: Do not include py-ref.h.
15848         * python/py-bpevent.c: Do not include py-ref.h.
15849         * python/py-cmd.c: Do not include py-ref.h.
15850         * python/py-continueevent.c: Do not include py-ref.h.
15851         * python/py-event.h: Do not include py-ref.h.
15852         * python/py-evtregistry.c: Do not include py-ref.h.
15853         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15854         * python/py-frame.c: Do not include py-ref.h.
15855         * python/py-framefilter.c: Do not include py-ref.h.
15856         * python/py-function.c: Do not include py-ref.h.
15857         * python/py-infevents.c: Do not include py-ref.h.
15858         * python/py-linetable.c: Do not include py-ref.h.
15859         * python/py-objfile.c: Do not include py-ref.h.
15860         * python/py-param.c: Do not include py-ref.h.
15861         * python/py-prettyprint.c: Do not include py-ref.h.
15862         * python/py-progspace.c: Do not include py-ref.h.
15863         * python/py-symbol.c: Do not include py-ref.h.
15864         * python/py-symtab.c: Do not include py-ref.h.
15865         * python/py-type.c: Do not include py-ref.h.
15866         * python/py-unwind.c: Do not include py-ref.h.
15867         * python/py-utils.c: Do not include py-ref.h.
15868         * python/py-value.c: Do not include py-ref.h.
15869         * python/py-varobj.c: Do not include py-ref.h.
15870         * python/py-xmethods.c: Do not include py-ref.h.
15871         * python/python.c: Do not include py-ref.h.
15872         * varobj.c: Do not include py-ref.h.
15873
15874 2019-01-22  Tom Tromey  <tom@tromey.com>
15875
15876         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15877         keyword for bcache.
15878
15879 2019-01-22  Tom Tromey  <tom@tromey.com>
15880
15881         * compile/compile-cplus-types.c: Remove a comment by #include.
15882
15883 2019-01-22  Tom Tromey  <tom@tromey.com>
15884
15885         * compile/gcc-c-plugin.h: Include compile-internal.h.
15886
15887 2019-01-22  Tom Tromey  <tom@tromey.com>
15888
15889         * stabsread.c (EXTERN): Do not define.
15890         (symnum, next_symbol_text_func, processing_gcc_compilation)
15891         (within_function, global_sym_chain, global_stabs)
15892         (previous_stab_code, this_object_header_files)
15893         (n_this_object_header_files)
15894         (n_allocated_this_object_header_files): Define.
15895         * stabsread.h (EXTERN): Never define.  Use "extern".
15896
15897 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15898
15899         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15900         history_value.
15901
15902 2019-01-21  Tom Tromey  <tom@tromey.com>
15903
15904         * ui-out.c: Fix includes.
15905         * tui/tui-source.c: Fix includes.
15906         * target.c: Fix includes.
15907         * remote.c: Fix includes.
15908         * regcache.c: Fix includes.
15909         * python/py-block.c: Fix includes.
15910         * printcmd.c: Fix includes.
15911         * or1k-tdep.c: Fix includes.
15912         * mi/mi-main.c: Fix includes.
15913         * m32r-tdep.c: Fix includes.
15914         * csky-tdep.c: Fix includes.
15915         * compile/compile-cplus-types.c: Fix includes.
15916         * cli/cli-interp.c: Fix includes.
15917
15918 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15919
15920         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15921         for padding.
15922
15923 2019-01-16  Tom Tromey  <tom@tromey.com>
15924
15925         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15926         earlier.
15927         (struct objfile) <msymbols_range>: Move from top level.
15928         <msymbols>: New method.
15929         (class objfile_msymbols): Remove.
15930         * symtab.c (default_collect_symbol_completion_matches_break_on):
15931         Update.
15932         * symmisc.c (dump_msymbols): Update.
15933         * stabsread.c (scan_file_globals): Update.
15934         * objc-lang.c (info_selectors_command, info_classes_command)
15935         (find_methods): Update.
15936         * minsyms.c (find_solib_trampoline_target): Update.
15937         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15938         * coffread.c (coff_symfile_read): Update.
15939         * ada-lang.c (ada_lookup_simple_minsym)
15940         (ada_collect_symbol_completion_matches): Update.
15941
15942 2019-01-16  Tom Tromey  <tom@tromey.com>
15943
15944         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15945         type.  Remove no-argument constructor.
15946         <iterator::operator++>: Simplify.
15947         <begin>: Update.
15948         <end>: Use minimal_symbol_count.
15949
15950 2019-01-16  Tom Tromey  <tom@tromey.com>
15951
15952         * objfiles.h (struct objfile) <psymtabs>: New method.
15953         (class objfile_psymtabs): Remove.
15954         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15955         typedef.
15956         <range>: New method.
15957         (require_partial_symbols): Change return type.
15958         * psymtab.c (require_partial_symbols)
15959         (psym_expand_symtabs_matching): Update.
15960         * mdebugread.c (parse_partial_symbols): Update.
15961         * dbxread.c (dbx_end_psymtab): Update.
15962
15963 2019-01-15  Tom Tromey  <tom@tromey.com>
15964
15965         * symtab.c (lookup_objfile_from_block)
15966         (lookup_symbol_in_objfile_symtabs)
15967         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15968         (find_line_symtab, info_sources_command)
15969         (default_collect_symbol_completion_matches_break_on)
15970         (make_source_files_completion_list): Update.
15971         * symmisc.c (print_objfile_statistics, dump_objfile)
15972         (maintenance_print_symbols, maintenance_info_symtabs)
15973         (maintenance_check_symtabs, maintenance_info_line_tables):
15974         Update.
15975         * source.c (select_source_symtab)
15976         (forget_cached_source_info_for_objfile): Update.
15977         * objfiles.h (class objfile_compunits): Remove.
15978         (struct objfile) <compunits_range>: New typedef.
15979         (compunits): New method.
15980         * objfiles.c (objfile_relocate1): Update.
15981         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15982         * maint.c (count_symtabs_and_blocks): Update.
15983         * linespec.c (iterate_over_all_matching_symtabs): Update.
15984         * cp-support.c (add_symbol_overload_list_qualified): Update.
15985         * coffread.c (coff_symtab_read): Update.
15986         * ada-lang.c (add_nonlocal_symbols)
15987         (ada_collect_symbol_completion_matches)
15988         (ada_add_global_exceptions): Update.
15989
15990 2019-01-15  Tom Tromey  <tom@tromey.com>
15991
15992         * progspace.h (program_space) <objfiles_safe_range>: New
15993         typedef.
15994         <objfiles_safe>: New method.
15995         * objfiles.h (class all_objfiles_safe): Remove.
15996         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15997         * jit.c (jit_inferior_exit_hook): Update.
15998
15999 2019-01-17  Tom Tromey  <tom@tromey.com>
16000
16001         * progspace.h (program_space) <objfiles_range>: New typedef.
16002         <objfiles>: New method.
16003         <objfiles_head>: Rename from objfiles.
16004         (object_files): Update.
16005         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
16006         * guile/scm-pretty-print.c
16007         (ppscm_find_pretty_printer_from_objfiles): Update.
16008         * guile/scm-objfile.c (gdbscm_objfiles): Update.
16009         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
16010         Update.
16011         * python/py-progspace.c (pspy_get_objfiles): Update.
16012         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16013         Update.
16014         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16015         (objfpy_lookup_objfile_by_build_id): Update.
16016         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16017         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16018         Update.
16019         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16020         (expand_symtab_containing_pc, lookup_objfile_from_block)
16021         (lookup_static_symbol, basic_lookup_transparent_type)
16022         (find_pc_sect_compunit_symtab, find_symbol_at_address)
16023         (find_line_symtab, info_sources_command)
16024         (default_collect_symbol_completion_matches_break_on)
16025         (make_source_files_completion_list, find_main_name): Update.
16026         * symmisc.c (print_symbol_bcache_statistics)
16027         (print_objfile_statistics, maintenance_print_symbols)
16028         (maintenance_print_msymbols, maintenance_print_objfiles)
16029         (maintenance_info_symtabs, maintenance_check_symtabs)
16030         (maintenance_expand_symtabs, maintenance_info_line_tables):
16031         Update.
16032         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
16033         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
16034         (map_overlay_command, unmap_overlay_command)
16035         (simple_overlay_update, expand_symtabs_matching)
16036         (map_symbol_filenames): Update.
16037         * symfile-debug.c (set_debug_symfile): Update.
16038         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
16039         Update.
16040         * source.c (select_source_symtab, forget_cached_source_info):
16041         Update.
16042         * solib.c (solib_read_symbols): Update.
16043         * solib-spu.c (append_ocl_sos): Update.
16044         * psymtab.c (maintenance_print_psymbols)
16045         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
16046         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
16047         * printcmd.c (info_symbol_command): Update.
16048         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
16049         Update.
16050         * objfiles.h (class all_objfiles): Remove.
16051         * objfiles.c (have_partial_symbols, have_full_symbols)
16052         (have_minimal_symbols, qsort_cmp, update_section_map)
16053         (shared_objfile_contains_address_p)
16054         (default_iterate_over_objfiles_in_search_order): Update.
16055         * objc-lang.c (info_selectors_command, info_classes_command)
16056         (find_methods): Update.
16057         * minsyms.c (find_solib_trampoline_target): Update.
16058         * maint.c (maintenance_info_sections)
16059         (maintenance_translate_address, count_symtabs_and_blocks):
16060         Update.
16061         * main.c (captured_main_1): Update.
16062         * linux-thread-db.c (try_thread_db_load_from_pdir)
16063         (has_libpthread): Update.
16064         * linespec.c (iterate_over_all_matching_symtabs)
16065         (search_minsyms_for_name): Update.
16066         * jit.c (jit_find_objf_with_entry_addr): Update.
16067         * hppa-tdep.c (find_unwind_entry)
16068         (hppa_lookup_stub_minimal_symbol): Update.
16069         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16070         Update.
16071         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16072         (elf_gnu_ifunc_resolve_by_got): Update.
16073         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16074         * dwarf-index-write.c (save_gdb_index_command): Update.
16075         * cp-support.c (add_symbol_overload_list_qualified): Update.
16076         * breakpoint.c (create_overlay_event_breakpoint)
16077         (create_longjmp_master_breakpoint)
16078         (create_std_terminate_master_breakpoint)
16079         (create_exception_master_breakpoint): Update.
16080         * blockframe.c (find_pc_partial_function): Update.
16081         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16082         (ada_collect_symbol_completion_matches)
16083         (ada_add_global_exceptions): Update.
16084
16085 2019-01-17  Tom Tromey  <tom@tromey.com>
16086
16087         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
16088         declare VEC.
16089         (solib_target_parse_libraries): Change return type.
16090         (library_list_start_segment, library_list_start_section)
16091         (library_list_end_library, library_list_start_library); Update.
16092         (solib_target_free_library_list): Remove.
16093         (solib_target_parse_libraries): Remove cleanup.  Change return
16094         type.
16095         (solib_target_current_sos): Update.
16096
16097 2019-01-17  Tom Tromey  <tromey@bapiya>
16098
16099         * valprint.c: Replace "the the" with "the".
16100         * symtab.c: Replace "the the" with "the".
16101         * solib.c: Replace "the the" with "the".
16102         * solib-dsbt.c: Replace "the the" with "the".
16103         * linespec.c: Replace "the the" with "the".
16104         * dwarf2loc.h: Replace "the the" with "the".
16105         * amd64-windows-tdep.c: Replace "the the" with "the".
16106         * aarch64-tdep.c: Replace "the the" with "the".
16107
16108 2019-01-16  Keith Seitz  <keiths@redhat.com>
16109
16110         PR gdb/23773
16111         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16112         <builder>: Rename to ..
16113         <m_builder>: ... this and make private.
16114         (dwarf2_cu::get_builder): New method.  Change all users of
16115         `builder' to use this method.
16116         (dwarf2_start_symtab): Move to ...
16117         (dwarf2_cu::start_symtab): ... here.  Update all callers
16118         (setup_type_unit_groups): Move to ...
16119         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
16120         callers.
16121         (dwarf2_cu::reset_builder): New method.
16122         (process_full_compunit, process_full_type_unit): Use
16123         dwarf2_cu::reset_builder.
16124         (follow_die_offset): Record the ancestor CU if it is different
16125         from the followed DIE's CU.
16126         (follow_die_sig_1): Likewise.
16127
16128 2019-01-15  Tom Tromey  <tom@tromey.com>
16129
16130         * remote.c (class remote_state) <buf>: Now a char_vector.
16131         <buf_size>: Remove.
16132         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
16133         parameter.
16134         (remote_target::getpkt_or_notif_sane_1)
16135         (remote_target::getpkt_sane)
16136         (remote_target::getpkt_or_notif_sane): Likewise.
16137         (class remote_target) <putpkt>: New overload.
16138         (remote_target::read_frame): Change type of "buf_p".  Remove
16139         sizeof_p parameter.
16140         (packet_ok): New overload.
16141         (packet_check_result): New overload.
16142         Update all uses.
16143
16144 2019-01-14  Tom Tromey  <tom@tromey.com>
16145
16146         * remote-notif.c (handle_notification, remote_notif_ack)
16147         (remote_notif_parse): Make "buf" const.
16148         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16149         const.
16150         (remote_notif_parse, remote_notif_ack, handle_notification):
16151         Likewise.
16152         * remote.c (remote_notif_stop_parse): Make "buf" const.
16153         (remote_target::remote_parse_stop_reply): Make "buf" const.
16154         (remote_notif_stop_ack): Make "buf" const.
16155
16156 2019-01-14  Tom Tromey  <tom@tromey.com>
16157
16158         * remote.c (remote_console_output): Make parameter const.
16159
16160 2019-01-14  Tom Tromey  <tom@tromey.com>
16161
16162         * target-debug.h (target_debug_print_signals): Constify.
16163         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16164         * procfs.c (procfs_target::pass_signals): Update.
16165         * linux-nat.c (linux_nat_target::pass_signals): Update.
16166         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16167         * target-delegates.c: Rebuild.
16168         * remote.c (remote_target::program_signals): Update.
16169         (remote_target::pass_signals): Update.
16170         * target.c (target_pass_signals): Constify argument.
16171         (target_program_signals): Likewise.
16172         * target.h (struct target_ops) <pass_signals, program_signals>:
16173         Constify argument.
16174         (target_pass_signals, target_program_signals): Constify argument.
16175
16176 2019-01-14  Tom Tromey  <tom@tromey.com>
16177
16178         PR tui/28819:
16179         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16180
16181 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
16182
16183         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16184         field.
16185         * rs6000-tdep.c: Include reggroups.h.
16186         (IS_V_ALIAS_PSEUDOREG): Define.
16187         (rs6000_register_name): Return names for the "vX" aliases.
16188         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16189         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
16190         aliases.  Call default_register_reggroup_p for all other
16191         pseudo-registers.
16192         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16193         New functions.
16194         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16195         Handle "vX" aliases.
16196         (v_alias_pseudo_register_collect): New function.
16197         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16198         (rs6000_gdbarch_init): Initialize "vX" aliases as
16199         pseudo-registers.  Restore registration of
16200         rs6000_pseudo_register_reggroup_p with
16201         set_tdesc_pseudo_register_reggroup_p.
16202
16203 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16204
16205         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16206         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16207         set_gdbarch_num_pseudo_regs.
16208
16209 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16210
16211         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16212         Remove arg prefixname, add do_set and do_show.
16213         Add member functions set_list and show_list.
16214         * cli/cli-style.c (class cli_style_option): Update accordingly.
16215         (style_set_list): Move to file scope.
16216         (style_show_list): Likewise.
16217         (set_style): Call help_list.
16218         (show_style): Call cmd_show_list.
16219         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16220         Update to use the new macro.
16221
16222 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16223
16224         * ada-lang.c (_initialize_ada_language): Expand the help text
16225         for the "catch exception" command.
16226
16227 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16228
16229         * symtab.c (matching_obj_sections): Initialize obj,
16230         declare it closer to its usage.
16231
16232 2019-01-10  Tom Tromey  <tom@tromey.com>
16233
16234         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16235         (basic_inf_threads_range): Remove.
16236         (inf_threads_range, inf_non_exited_threads_range)
16237         (safe_inf_threads_range): Use next_adapter.
16238
16239 2019-01-10  Keith Seitz  <keiths@redhat.com>
16240
16241         PR gdb/23712
16242         PR symtab/23010
16243         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16244         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16245
16246 2019-01-10  Keith Seitz  <keiths@redhat.com>
16247
16248         PR gdb/23712
16249         PR symtab/23010
16250         * dictionary.c (pending_to_vector): Remove.
16251         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16252         Remove _1 suffix, replacing functions of the same name.  Update
16253         all callers.
16254         (dict_create_hashed, dict_create_hashed_expandable)
16255         (dict_create_linear, dict_create_linear_expandable, dict_free)
16256         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16257         Make functions static.
16258
16259 2019-01-10  Keith Seitz  <keiths@redhat.com>
16260
16261         PR gdb/23712
16262         PR symtab/23010
16263         * dictionary.h (struct dictionary): Replace declaration with
16264         multidictionary.
16265         (dict_create_hashed, dict_create_hashed_expandable)
16266         (dict_create_linear, dict_create_linear_expandable)
16267         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16268         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16269         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16270         taking multidictionary argument.
16271         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16272         * block.h (struct block) <dict>: Change to multidictionary
16273         and rename `multidict'.
16274         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16275         symmisc.c: Update all dictionary references to multidictionary.
16276
16277 2019-01-10  Keith Seitz  <keiths@redhat.com>
16278
16279         PR gdb/23712
16280         PR symtab/23010
16281         * dictionary.c: Include unordered_map.
16282         (pending_to_vector): New function.
16283         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16284         Rewrite the non-"_1" functions to take vector instead
16285         of linked list.
16286         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16287         "new" _1 versions of the same name.
16288         (multidictionary): Define.
16289         (std::hash<enum language): New definition.
16290         (collate_pending_symbols_by_language, mdict_create_hashed)
16291         (mdict_create_hashed_expandable, mdict_create_linear)
16292         (mdict_create_linear_expandable, mdict_free)
16293         (find_language_dictionary, create_new_language_dictionary)
16294         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16295         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16296         (mdict_size, mdict_empty): New functions.
16297         * dictionary.h (mdict_iterator): Define.
16298
16299 2019-01-10  Pedro Alves  <palves@redhat.com>
16300
16301         * breakpoint.c (read_uploaded_action)
16302         (create_tracepoint_from_upload): Adjust to use
16303         gdb::unique_xmalloc_ptr.
16304         * ctf.c (ctf_write_uploaded_tp):
16305         (SET_ARRAY_FIELD): Use emplace_back.
16306         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16307         * tracefile-tfile.c (tfile_write_uploaded_tp):
16308         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16309         gdb::unique_xmalloc_ptr.
16310         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16311         at_string, cond_string, cmd_strings>: Replace char pointers
16312         with gdb::unique_xmalloc_ptr.
16313
16314 2019-01-10  Pedro Alves  <palves@redhat.com>
16315
16316         * solib-target.c (library_list_start_library): Don't xstrdup name.
16317
16318 2019-01-10  Pedro Alves  <palves@redhat.com>
16319
16320         * mdebugread.c (parse_partial_symbols): Use
16321         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16322
16323 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16324
16325         * linux-fork.c (scoped_switch_fork_info)
16326         <~scoped_switch_fork_info>: Fix incorrect variable name.
16327
16328 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16329
16330         * linux-fork.c (scoped_switch_fork_info)
16331         <scoped_switch_fork_info>: Make explicit.
16332         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16333
16334 2019-01-10  Tom Tromey  <tom@tromey.com>
16335
16336         * objfiles.h (objfile::reset_psymtabs): Update.
16337         * objfiles.c (objfile::objfile): Update.
16338         * psymtab.h (psymtab_storage::obstack): Update.
16339         (psymtab_storage::m_obstack): Use gdb::optional.
16340         (class psymtab_storage): Update comment.  Remove objfile
16341         parameter.
16342         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16343
16344 2019-01-10  Tom Tromey  <tom@tromey.com>
16345
16346         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16347         <free_psymtabs>: Now private.
16348         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16349         (allocate_psymtab): Use new method.
16350
16351 2019-01-10  Tom Tromey  <tom@tromey.com>
16352
16353         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16354         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16355         * mdebugread.c (parse_partial_symbols): Use
16356         allocate_dependencies.
16357         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16358         allocate_dependencies.
16359         (process_psymtab_comp_unit_reader)
16360         (build_type_psymtab_dependencies): Likewise.
16361         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16362
16363 2019-01-10  Tom Tromey  <tom@tromey.com>
16364
16365         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16366         PSYMBOL_SET_LANGUAGE.
16367         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16368
16369 2019-01-10  Tom Tromey  <tom@tromey.com>
16370
16371         * psymtab.h (psymtab_storage::obstack): New method.
16372         <m_obstack>: Rename from obstack; now private.
16373         * psymtab.c (psymtab_storage): Update.
16374         * dwarf2read.c (create_addrmap_from_index)
16375         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16376         Update.
16377
16378 2019-01-10  Tom Tromey  <tom@tromey.com>
16379
16380         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16381         * objfiles.h (objfile::reset_psymtabs): New method.
16382
16383 2019-01-10  Tom Tromey  <tom@tromey.com>
16384
16385         * symmisc.c (print_symbol_bcache_statistics): Update.
16386         (print_objfile_statistics): Update.
16387         * symfile.c (reread_symbols): Update.
16388         * psymtab.h (class psymtab_storage): New.
16389         * psymtab.c (psymtab_storage): New constructor.
16390         (~psymtab_storage): New destructor.
16391         (require_partial_symbols): Update.
16392         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16393         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16394         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16395         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16396         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16397         (start_psymtab_common, end_psymtab_common)
16398         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16399         (allocate_psymtab): Update.
16400         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16401         Update.
16402         (dump_psymtab_addrmap, maintenance_print_psymbols)
16403         (maintenance_check_psymtabs): Update.
16404         (class objfile_psymtabs): Move to objfiles.h.
16405         * psympriv.h (discard_psymtab): Now inline.
16406         (psymtab_discarder::psymtab_discarder): Update.
16407         (psymtab_discarder::~psymtab_discarder): Update.
16408         (ALL_OBJFILE_PSYMTABS): Rewrite.
16409         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16410         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16411         Remove fields.
16412         <partial_symtabs>: New field.
16413         (class objfile_psymtabs): Move from psymtab.h.  Update.
16414         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16415         psymbol_cache.
16416         (objfile::~objfile): Don't destroy psymbol_cache.
16417         * mdebugread.c (parse_partial_symbols): Update.
16418         * dwarf2read.c (create_addrmap_from_index)
16419         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16420         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16421         (add_partial_subprogram, dwarf2_ranges_read): Update.
16422         * dwarf-index-write.c (write_address_map)
16423         (write_one_signatured_type, recursively_write_psymbols)
16424         (class debug_names, class debug_names, write_psymtabs_to_index):
16425         Update.
16426
16427 2019-01-10  Tom Tromey  <tom@tromey.com>
16428
16429         * symtab.h (SYMBOL_SET_NAMES): Update.
16430         (symbol_set_names): Update.
16431         (MSYMBOL_SET_NAMES): Update.
16432         * symtab.c (symbol_set_names): Change argument to be an
16433         objfile_per_bfd_storage.
16434         * psymtab.c (add_psymbol_to_bcache): Update.
16435         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16436
16437 2019-01-10  Tom Tromey  <tom@tromey.com>
16438
16439         * symtab.c (create_demangled_names_hash): Change argument to be an
16440         objfile_per_bfd_storage.
16441         (symbol_set_names): Update.
16442
16443 2019-01-10  Tom Tromey  <tom@tromey.com>
16444
16445         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16446         init_psymbol_list.
16447         * psymtab.c (init_psymbol_list): Do nothing if already called.
16448         * psympriv.h (init_psymbol_list): Add comment.
16449         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16450         init_psymbol_list.
16451         * dbxread.c (dbx_symfile_read): Unconditionally call
16452         init_psymbol_list.
16453
16454 2019-01-10  Tom Tromey  <tom@tromey.com>
16455
16456         * xcoffread.c (scan_xcoff_symtab): Update.
16457         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16458         "where".
16459         * mdebugread.c (parse_partial_symbols)
16460         (handle_psymbol_enumerators): Update.
16461         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16462         * dbxread.c (read_dbx_symtab): Update.
16463         * psympriv.h (psymbol_placement): New enum.
16464         (add_psymbol_to_list): Update.
16465
16466 2019-01-10  Tom Tromey  <tom@tromey.com>
16467
16468         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16469         static_psymbols parameters.
16470         (scan_xcoff_symtab): Update.
16471         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16472         static_psymbols parameters.
16473         * psympriv.h (start_psymtab_common): Update.
16474         * mdebugread.c (parse_partial_symbols): Update.
16475         * dwarf2read.c (create_partial_symtab): Update.
16476         * dbxread.c (read_dbx_symtab): Update.
16477         (start_psymtab): Remove global_psymbols and static_psymbols
16478         parameters.
16479
16480 2019-01-10  Tom Tromey  <tom@tromey.com>
16481
16482         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16483         * psymtab.c (allocate_psymtab): Add comment.
16484         * psympriv.h (allocate_psymtab): Add comment.
16485         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16486         initializations.
16487         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16488
16489 2019-01-10  Tom Tromey  <tom@tromey.com>
16490
16491         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16492         Don't declare.
16493         * mipsread.c: Include mdebugread.h.
16494         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16495         Declare.
16496         * elfread.c: Include mdebugread.h.
16497
16498 2019-01-09  Tom Tromey  <tom@tromey.com>
16499
16500         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16501         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16502         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16503         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16504         (psym_lookup_symbol, psym_find_last_source_symtab)
16505         (psym_forget_cached_source_info, psym_print_stats)
16506         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16507         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16508         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16509         (psym_find_compunit_symtab_by_address)
16510         (maintenance_print_psymbols, maintenance_info_psymtabs)
16511         (maintenance_check_psymtabs): Use ranged for.
16512         * psymtab.h (class objfile_psymtabs): New.
16513         (require_partial_symbols): Return objfile_psymtabs.
16514         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16515
16516 2019-01-09  Tom Tromey  <tom@tromey.com>
16517
16518         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16519         (find_pc_mapped_section, list_overlays_command)
16520         (map_overlay_command, unmap_overlay_command)
16521         (simple_overlay_update): Use all_objfiles.
16522         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16523         * printcmd.c (info_symbol_command): Use all_objfiles.
16524         * objfiles.h (ALL_OBJSECTIONS): Remove.
16525         * maint.c (maintenance_translate_address): Use all_objfiles.
16526         * gcore.c (gcore_create_callback): Use all_objfiles.
16527         (objfile_find_memory_regions): Likewise.
16528
16529 2019-01-09  Tom Tromey  <tom@tromey.com>
16530
16531         * symtab.c (find_line_symtab, info_sources_command)
16532         (make_source_files_completion_list): Use objfile_compunits.
16533         * source.c (select_source_symtab): Use objfile_compunits.
16534         * objfiles.h (struct objfile): Update comment.
16535         (ALL_OBJFILES): Remove.
16536         (ALL_FILETABS): Remove.
16537         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16538         objfile_compunits.
16539
16540 2019-01-09  Tom Tromey  <tom@tromey.com>
16541
16542         * symmisc.c (print_objfile_statistics, dump_objfile)
16543         (maintenance_print_symbols): Use compunit_filetabs.
16544         * source.c (forget_cached_source_info_for_objfile): Use
16545         compunit_filetabs.
16546         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16547         (ALL_FILETABS): Use compunit_filetabs.
16548         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16549         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16550
16551 2019-01-09  Tom Tromey  <tom@tromey.com>
16552
16553         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16554         (compunit_filetabs): New.
16555         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16556         compunit_filetabs.
16557         (info_sources_command, make_source_files_completion_list): Remove
16558         declaration.
16559         * symmisc.c (print_objfile_statistics, dump_objfile)
16560         (maintenance_print_symbols): Remove declaration.
16561         (maintenance_info_symtabs): Use compunit_filetabs.
16562         (maintenance_info_line_tables): Likewise.
16563         * source.c (select_source_symtab): Change local variable name.
16564         (forget_cached_source_info_for_objfile): Remove declaration.
16565         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16566         * objfiles.c (objfile_relocate1): Remove declaration.
16567         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16568         declaration.
16569         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16570         * coffread.c (coff_symtab_read): Remove declaration.
16571         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16572         compunit_filetabs.
16573
16574 2019-01-09  Tom Tromey  <tom@tromey.com>
16575
16576         * symtab.c (lookup_objfile_from_block)
16577         (find_pc_sect_compunit_symtab, search_symbols)
16578         (default_collect_symbol_completion_matches_break_on): Use
16579         objfile_compunits.
16580         * objfiles.h (ALL_COMPUNITS): Remove.
16581         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16582         * cp-support.c (add_symbol_overload_list_qualified): Use
16583         objfile_compunits.
16584         * ada-lang.c (ada_collect_symbol_completion_matches)
16585         (ada_add_global_exceptions): Use objfile_compunits.
16586
16587 2019-01-09  Tom Tromey  <tom@tromey.com>
16588
16589         * source.c (select_source_symtab)
16590         (forget_cached_source_info_for_objfile): Remove declaration.
16591         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16592         declaration.
16593         * maint.c (count_symtabs_and_blocks): Remove declaration.
16594         * cp-support.c (add_symbol_overload_list_qualified): Remove
16595         declaration.
16596         * coffread.c (coff_symtab_read): Remove declaration.
16597         * symtab.c (lookup_symbol_in_objfile_symtabs)
16598         (basic_lookup_transparent_type_1): Use objfile_compunits.
16599         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16600         (info_sources_command, search_symbols)
16601         (default_collect_symbol_completion_matches_break_on)
16602         (make_source_files_completion_list): Remove declaration.
16603         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16604         (ada_collect_symbol_completion_matches)
16605         (ada_add_global_exceptions): Remove declaration.
16606         * linespec.c (iterate_over_all_matching_symtabs): Use
16607         objfile_compunits.
16608         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16609         (class objfile_compunits): New.
16610         (ALL_COMPUNITS): Use objfile_compunits.
16611         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16612         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16613         objfile_compunits.
16614         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16615
16616 2019-01-09  Tom Tromey  <tom@tromey.com>
16617
16618         * symtab.c (search_symbols)
16619         (default_collect_symbol_completion_matches_break_on): Use
16620         objfile_msymbols.
16621         * ada-lang.c (ada_lookup_simple_minsym)
16622         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16623         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16624         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16625         objfile_msymbols.
16626         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16627         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16628         * objc-lang.c (find_methods): Use objfile_msymbols.
16629         (info_selectors_command, info_classes_command): Likewise.
16630         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16631         * objfiles.h (class objfile_msymbols): New.
16632         (ALL_OBJFILE_MSYMBOLS): Remove.
16633         (ALL_MSYMBOLS): Remove.
16634
16635 2019-01-09  Tom Tromey  <tom@tromey.com>
16636
16637         * common/next-iterator.h (next_adapter): Add Iterator template
16638         parameter.
16639         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16640         (class all_objfiles_safe): New.
16641         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16642         * objfiles.c (put_objfile_before): Update comment.
16643         (add_separate_debug_objfile): Likewise.
16644         (free_all_objfiles): Use all_objfiles_safe.
16645         (objfile_purge_solibs): Likewise.
16646
16647 2019-01-09  Tom Tromey  <tom@tromey.com>
16648
16649         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16650         (expand_symtab_containing_pc, lookup_static_symbol)
16651         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16652         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16653         all_objfiles.
16654         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16655         * breakpoint.c (create_overlay_event_breakpoint)
16656         (create_longjmp_master_breakpoint)
16657         (create_std_terminate_master_breakpoint)
16658         (create_exception_master_breakpoint): Use all_objfiles.
16659         * linux-thread-db.c (try_thread_db_load_from_pdir)
16660         (has_libpthread): Use all_objfiles.
16661         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16662         * linespec.c (iterate_over_all_matching_symtabs)
16663         (search_minsyms_for_name): Use all_objfiles.
16664         * maint.c (maintenance_info_sections): Use all_objfiles.
16665         * main.c (captured_main_1): Use all_objfiles.
16666         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16667         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16668         * guile/scm-pretty-print.c
16669         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16670         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16671         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16672         (maintenance_print_msymbols): Use all_objfiles.
16673         * source.c (select_source_symtab): Use all_objfiles.
16674         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16675         * symfile.c (remove_symbol_file_command)
16676         (expand_symtabs_matching, map_symbol_filenames): Use
16677         all_objfiles.
16678         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16679         all_objfiles.
16680         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16681         * objc-lang.c (find_methods): Use all_objfiles.
16682         * objfiles.c (have_partial_symbols, have_full_symbols)
16683         (have_minimal_symbols, qsort_cmp)
16684         (default_iterate_over_objfiles_in_search_order): Use
16685         all_objfiles.
16686         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16687         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16688         (maintenance_check_psymtabs): Use all_objfiles.
16689         (ALL_PSYMTABS): Remove.
16690         * compile/compile-object-run.c (do_module_cleanup): Use
16691         all_objfiles.
16692         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16693         * cp-support.c (add_symbol_overload_list_qualified): Use
16694         all_objfiles.
16695         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16696         Use all_objfiles.
16697         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16698         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16699         all_objfiles.
16700         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16701         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16702         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16703         Uses all_objfiles.
16704         * solib.c (solib_read_symbols): Use all_objfiles
16705
16706 2019-01-09  Tom Tromey  <tom@tromey.com>
16707
16708         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16709         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16710         all_objfiles.
16711         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16712         * symmisc.c (print_symbol_bcache_statistics)
16713         (print_objfile_statistics, maintenance_print_objfiles)
16714         (maintenance_info_symtabs, maintenance_check_symtabs)
16715         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16716         all_objfiles.
16717         * source.c (forget_cached_source_info): Use all_objfiles.
16718         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16719         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16720         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16721         * objfiles.c (update_section_map): Use all_objfiles.
16722         (shared_objfile_contains_address_p): Likewise.
16723         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16724         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16725
16726 2019-01-09  Tom Tromey  <tom@tromey.com>
16727
16728         * common/next-iterator.h: New file.
16729         * objfiles.h (class all_objfiles): New.
16730         (struct objfile_iterator): New.
16731
16732 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16733
16734         * NEWS: Move the description of the changed "frame", "select-frame",
16735          and "info frame" commands to the Changed commands section.
16736
16737 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16738
16739         * gdbtypes.c (check_stub_method_group): Remove handling of old
16740         mangling schemes.
16741         * linespec.c (find_methods): Likewise.
16742         * stabsread.c (read_member_functions): Likewise.
16743         * valops.c (search_struct_method): Likewise.
16744         (value_struct_elt_for_reference): Likewise.
16745         * NEWS: Mention this change.
16746
16747 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16748
16749         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16750         print_source_lines.
16751         * source.c (print_source_lines_base): Update line number check.
16752         (print_source_lines): New function.
16753         (source_lines_range::source_lines_range): New function.
16754         * source.h (class source_lines_range): New class.
16755         (print_source_lines): New declaration.
16756
16757 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16758
16759         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16760
16761 2019-01-08  Tom Tromey  <tom@tromey.com>
16762             Simon Marchi  <simon.marchi@ericsson.com>
16763
16764         PR gdb/24060
16765         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16766         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16767         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16768         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16769         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16770         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16771
16772 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16773
16774         * source.c (select_source_symtab): Move header comment to
16775         declaration in source.h.
16776         (forget_cached_source_info_for_objfile): Likewise.
16777         (forget_cached_source_info): Likewise.
16778         (identify_source_line): Likewise.
16779         * source.h (identify_source_line): Move declaration from symtab.h
16780         and add comment from source.c
16781         (print_source_lines): Likewise.
16782         (forget_cached_source_info_for_objfile): Likewise.
16783         (forget_cached_source_info): Likewise.
16784         (select_source_symtab): Likewise.
16785         (enum print_source_lines_flag): Move definition from symtab.h.
16786         * symtab.h (identify_source_line): Move declaration to source.h.
16787         (print_source_lines): Likewise.
16788         (forget_cached_source_info_for_objfile): Likewise.
16789         (forget_cached_source_info): Likewise.
16790         (select_source_symtab): Likewise.
16791         (enum print_source_lines_flag): Move definition to source.h.
16792         * tui/tui-hooks.c: Add 'source.h' include.
16793
16794 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16795
16796         * source.c (print_source_lines_base): Handle requests to print
16797         reverse line number sequences, and guard against empty lines
16798         string.
16799
16800 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16801
16802         * source.c (print_source_lines_base): Fix skip of '\r' if next
16803         character is '\n'.
16804
16805 2019-01-06  Tom Tromey  <tom@tromey.com>
16806
16807         * c-exp.y (struct c_parse_state) <macro_original_text,
16808         expansion_obstack>: New member.
16809         (macro_original_text, expansion_obstack): Remove globals.
16810         (scan_macro_expansion, scanning_macro_expansion)
16811         (finished_macro_expansion): Update.
16812         (scan_macro_cleanup): Remove.
16813         (yylex, c_parse): Update.
16814
16815 2019-01-06  Tom Tromey  <tom@tromey.com>
16816
16817         * c-exp.y (struct c_parse_state) <strings>: New member.
16818         (operator_stoken): Update.
16819
16820 2019-01-06  Tom Tromey  <tom@tromey.com>
16821
16822         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16823         (union type_stack_elt) <typelist_val>: Now a pointer to
16824         std::vector.
16825         (type_stack_cleanup): Don't declare.
16826         (push_typelist): Update.
16827         * parse.c (pop_typelist): Return a std::vector.
16828         (push_typelist): Take a std::vector.
16829         (follow_types): Update.  Do not free args.
16830         (type_stack_cleanup): Remove.
16831         * c-exp.y (struct c_parse_state): New.
16832         (cpstate): New global.
16833         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16834         (nonempty_typelist): Update.
16835         (func_mod): Create a new vector.
16836         (c_parse): Create a c_parse_state.
16837         (check_parameter_typelist): Do not delete params.
16838         (function_method): Update.  Do not delete type_list.
16839
16840 2019-01-06  Tom Tromey  <tom@tromey.com>
16841
16842         PR gdb/28155:
16843         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16844         check_typedef.
16845         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16846         (print_return_value): Likewise.
16847
16848 2019-01-05  Tom Tromey  <tom@tromey.com>
16849
16850         * contrib/cleanup_check.py: Remove.
16851         * contrib/gcc-with-excheck: Remove.
16852         * contrib/exsummary.py: Remove.
16853         * contrib/excheck.py: Remove.
16854
16855 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16856
16857         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16858         NULL. Initialize tpprev to NULL instead of assigning it
16859         to NULL on the next statement.
16860         * windows-nat.c (windows_delete_thread): Remove check for
16861         main_thread_id before printing thread exit notifications.
16862         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16863         Remove thread ID check against main_thread_id.
16864         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16865         windows_delete_thread.
16866         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16867
16868 2019-01-04  Tom Tromey  <tom@tromey.com>
16869
16870         * compile/compile.c (_initialize_compile): Use upper case for
16871         metasyntactic variables.
16872         * symmisc.c (_initialize_symmisc): Use upper case for
16873         metasyntactic variables.
16874         * psymtab.c (_initialize_psymtab): Use upper case for
16875         metasyntactic variables.
16876         * demangle.c (demangle_command): Use upper case for metasyntactic
16877         variables.
16878         (_initialize_demangler): Likewise.
16879         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16880         variables.
16881
16882 2019-01-03  Tom Tromey  <tom@tromey.com>
16883
16884         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16885
16886 2019-01-03  Tom Tromey  <tom@tromey.com>
16887
16888         * python/py-symtab.c (salpy_str): Update.
16889         (struct salpy_sal_object) <symtab>: Now a PyObject.
16890         (salpy_dealloc): Update.
16891         (del_objfile_sal): Use gdbpy_ref.
16892
16893 2019-01-03  Tom Tromey  <tom@tromey.com>
16894
16895         * python/py-type.c (convert_field): Use new_reference.  Return
16896         gdbpy_ref.
16897         (make_fielditem): Return gdbpy_ref.
16898         (typy_fields): Update.
16899         (typy_getitem): Update.
16900         (field_name): Return gdbpy_ref.  Use new_reference.
16901         (typy_iterator_iternext): Update.
16902
16903 2019-01-03  Tom Tromey  <tom@tromey.com>
16904
16905         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16906
16907 2019-01-03  Tom Tromey  <tom@tromey.com>
16908
16909         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16910         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16911         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16912         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16913         (pspy_set_type_printers): Likewise.
16914         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16915         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16916         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16917         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16918         (objfpy_set_type_printers): Likewise.
16919
16920 2019-01-03  Tom Tromey  <tom@tromey.com>
16921
16922         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16923         (gdbpy_print_stack): Use gdbpy_err_fetch.
16924         * python/python-internal.h (class gdbpy_err_fetch): New class.
16925         (class gdbpy_enter) <m_error_type, m_error_value,
16926         m_error_traceback>: Remove.
16927         <m_error>: New member.
16928         (gdbpy_exception_to_string): Don't declare.
16929         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16930         * python/py-value.c (convert_value_from_python): Use
16931         gdbpy_err_fetch.
16932         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16933         gdbpy_exception_to_string.
16934         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16935         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16936         gdbpy_err_fetch.
16937
16938 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16939
16940         * linux-nat.c (delete_lwp_cleanup): Delete.
16941         (struct lwp_deleter): New struct.
16942         (lwp_info_up): New typedef.
16943         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16944         lwp_info_up.
16945
16946 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16947
16948         * linux-fork.c (class scoped_switch_fork_info): New class.
16949         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16950
16951 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16952
16953         * valops.c (find_overload_match): Remove use of null_cleanup, and
16954         calls to do_cleanups.
16955
16956 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16957
16958         * compile/compile-cplus-types.c
16959         (compile_cplus_instance::decl_name): Handle changes to
16960         cp_func_name.
16961         * cp-support.c (cp_func_name): Update header comment, update
16962         return type.
16963         * cp-support.h (cp_func_name): Update return type in declaration.
16964         * valops.c (find_overload_match): Move temp_func local to top
16965         level of function and change its type.  Use temp_func to hold and
16966         delete temporary string obtained from cp_func_name.
16967
16968 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16969
16970         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16971         gdb::char_vector, remove cleanup, and update uses of `msg`.
16972
16973 2019-01-03  Jim Wilson  <jimw@sifive.com>
16974
16975         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16976
16977 2019-01-02  Tom Tromey  <tom@tromey.com>
16978
16979         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16980         (tdesc_parse_xml): Remove cleanups.
16981         * target-descriptions.h (make_cleanup_free_target_description):
16982         Don't declare.
16983         (target_desc_deleter): New struct.
16984         (target_desc_up): New typedef.
16985         * target-descriptions.c (target_desc_deleter::operator()): Rename
16986         from free_target_description.
16987         (make_cleanup_free_target_description): Remove.
16988
16989 2019-01-02  Tom Tromey  <tom@tromey.com>
16990
16991         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16992         constructor, destructor.
16993         (linespec_parser): Remove typedef.
16994         (~linespec_parser): Rename from linespec_parser_delete.
16995         (linespec_lex_to_end, linespec_complete_label)
16996         (linespec_complete): Update.
16997         (decode_line_full): Remove cleanups.
16998         (decode_line_1): Update.
16999
17000 2019-01-02  Tom Tromey  <tom@tromey.com>
17001
17002         * python/python-internal.h (inferior_to_inferior_object): Change
17003         return type.
17004         * python/py-exitedevent.c (create_exited_event_object): Update.
17005         * python/py-inferior.c (inferior_to_inferior_object): Return
17006         gdbpy_ref.
17007         (python_new_inferior, python_inferior_deleted)
17008         (thread_to_thread_object, delete_thread_object)
17009         (build_inferior_list, gdbpy_selected_inferior): Update.
17010         * python/py-infthread.c (create_thread_object): Update.  Also fail
17011         if inferior_to_inferior_object fails.
17012
17013 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
17014
17015         * inferior.h (class inferior) <displaced_step_state>: New field.
17016         * infrun.h (struct displaced_step_state): Move here from
17017         infrun.c.  Initialize fields, add constructor.
17018         <inf>: Remove field.
17019         <reset>: New method.
17020         * infrun.c (struct displaced_step_inferior_state): Move to
17021         infrun.h.
17022         (displaced_step_inferior_states): Remove.
17023         (get_displaced_stepping_state): Adust.
17024         (displaced_step_in_progress_any_inferior): Adjust.
17025         (displaced_step_in_progress_thread): Adjust.
17026         (displaced_step_in_progress): Adjust.
17027         (add_displaced_stepping_state): Remove.
17028         (get_displaced_step_closure_by_addr): Adjust.
17029         (remove_displaced_stepping_state): Remove.
17030         (infrun_inferior_exit): Call displaced_step_state.reset.
17031         (use_displaced_stepping): Don't check for NULL.
17032         (displaced_step_prepare_throw): Call
17033         get_displaced_stepping_state.
17034         (displaced_step_fixup): Don't check for NULL.
17035         (prepare_for_detach): Don't check for NULL.
17036
17037 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17038
17039         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
17040          in case of call that did not complete.
17041
17042 2019-01-02  Andrey Utkin  <autkin@undo.io>
17043
17044         * symfile.c (find_separate_debug_file): Fix search of debug files for
17045         remote debuggee.
17046
17047 2019-01-02  Tom Tromey  <tom@tromey.com>
17048
17049         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
17050         indentation.
17051         * python/py-frame.c (frapy_older): Remove cast.
17052         (frapy_newer): Likewise.
17053         * python/py-breakpoint.c (local_setattro): Remove cast.
17054         * python/py-arch.c (archpy_name): Remove local variable.
17055         * python/py-type.c (gdbpy_lookup_type): Remove cast.
17056
17057 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
17058
17059         * unittests/basic_string_view/element_access/char/empty.cc:
17060         Fix year range in copyright header.
17061
17062 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
17063
17064         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17065         Delete.
17066         <operator==>: Update with for removed field.
17067         <hash>: Likewise.
17068         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17069         <isa_features>: ...this.
17070         <abi_features>: New field.
17071         (riscv_isa_flen): Update comment.
17072         (riscv_abi_xlen): New declaration.
17073         (riscv_abi_flen): New declaration.
17074         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17075         isa_features.
17076         (riscv_abi_xlen): New function.
17077         (riscv_isa_flen): Update to get answer from isa_features.
17078         (riscv_abi_flen): New function.
17079         (riscv_has_fp_abi): Update to get answer from abi_features.
17080         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17081         xlen and flen.
17082         (riscv_call_info) <xlen, flen>: Update comment.
17083         (riscv_call_arg_struct): Remove invalid assertions
17084         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17085         is removed.
17086         (riscv_gdbarch_init): Gather isa features and abi features
17087         separately, ensure both match on the gdbarch when reusing an old
17088         gdbarch.  Relax an error check to allow 32-bit abi float to run on
17089         a target with 64-bit float hardware.
17090
17091 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17092
17093         * source.c (search_command_helper): Stop reverse search
17094         when line 1 has been searched.
17095
17096 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17097
17098         * record-full.c (record_full_base_target::close): Rewrite
17099         record_full_core_buf_list free logic.
17100
17101 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17102
17103         * break-catch-syscall.c (print_one_catch_syscall): xfree
17104         the last text.
17105
17106 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17107
17108         * top.c (print_gdb_version): Update Copyright year in version
17109         message.
17110
17111 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17112
17113         Update copyright year range in all GDB files.
17114
17115 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
17116
17117         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
17118
17119 For older changes see ChangeLog-2018.
17120 \f
17121 Local Variables:
17122 mode: change-log
17123 left-margin: 8
17124 fill-column: 74
17125 version-control: never
17126 coding: utf-8
17127 End:
17128