gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (struct tui_exec_info_window)
   4         (struct tui_source_window_base): Move from tui-data.h.
   5         * tui/tui-winsource.c: Move many method definitions from
   6         elsewhere.  Remove "structuring" comments.
   7         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
   8         (tui_source_window_base::refresh_window): Move to
   9         tui-winsource.c.
  10         * tui/tui-win.c (tui_source_window_base::refresh_all)
  11         (tui_source_window_base::update_tab_width)
  12         (tui_source_window_base::set_new_height)
  13         (tui_source_window_base::do_make_visible_with_new_height): Move to
  14         tui-winsource.c.
  15         * tui/tui-source.h: Update.
  16         * tui/tui-source.c (tui_source_window_base::reset): Move to
  17         tui-winsource.c.
  18         * tui/tui-disasm.h: Update.
  19         * tui/tui-data.h (struct tui_exec_info_window): Move to
  20         tui-winsource.h.
  21         (struct tui_source_window_base): Likewise.
  22         * tui/tui-data.c (tui_source_window_base::clear_detail)
  23         (tui_source_window_base, ~tui_source_window_base): Move to
  24         tui-winsource.c.
  25
  26 2019-07-17  Tom Tromey  <tom@tromey.com>
  27
  28         * tui/tui-win.c (tui_resize_all)
  29         (tui_source_window_base::update_tab_width)
  30         (tui_adjust_win_heights): Update.
  31         (tui_win_info::make_invisible_and_set_new_height): Rename from
  32         make_invisible_and_set_new_height.
  33         * tui/tui-data.h (struct tui_win_info)
  34         <make_invisible_and_set_new_height>: New method.
  35
  36 2019-07-17  Tom Tromey  <tom@tromey.com>
  37
  38         * tui/tui.c: Update.
  39         * tui/tui-source.h (struct tui_source_window): Move from
  40         tui-data.h.
  41         * tui/tui-layout.c: Update.
  42         * tui/tui-disasm.c: Update.
  43         * tui/tui-data.h (struct tui_source_window): Move to
  44         tui-source.h.
  45
  46 2019-07-17  Tom Tromey  <tom@tromey.com>
  47
  48         * tui/tui-disasm.h (struct tui_disasm_window): Move from
  49         tui-data.h.
  50         * tui/tui-data.h (struct tui_disasm_window): Move to
  51         tui-disasm.h.
  52
  53 2019-07-17  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui-regs.h (struct tui_data_item_window): Move from
  56         tui-data.h.
  57         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
  58         * tui/tui-data.h (struct tui_data_item_window): Move to
  59         tui-regs.h.
  60         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
  61
  62 2019-07-17  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui.c: Update.
  65         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
  66         (tui_cmd_window::max_height): Move to tui-command.c.
  67         * tui/tui-layout.c: Update.
  68         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
  69         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
  70         tui-command.c.
  71         * tui/tui-command.h (struct tui_cmd_window): Move from
  72         tui-data.h.
  73         * tui/tui-command.c: Remove "structuring" comments.
  74         (tui_cmd_window::clear_detail)
  75         (tui_cmd_window::do_make_visible_with_new_height)
  76         (tui_cmd_window::max_height): Move from elsewhere.
  77
  78 2019-07-17  Tom Tromey  <tom@tromey.com>
  79
  80         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
  81         Now static.
  82         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
  83         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
  84
  85 2019-07-17  Tom Tromey  <tom@tromey.com>
  86
  87         * tui/tui.c: Update.
  88         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
  89         tui-regs.c.
  90         * tui/tui-windata.h: Remove file.
  91         * tui/tui-windata.c: Remove file.
  92         * tui/tui-win.c (tui_data_window::set_new_height)
  93         (tui_data_window::do_make_visible_with_new_height): Move to
  94         tui-regs.c.
  95         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
  96         * tui/tui-regs.c: Remove "structuring" comments.
  97         (tui_data_window::first_data_item_displayed)
  98         (tui_data_window::delete_data_content_windows)
  99         (tui_data_window::erase_data_content)
 100         (tui_data_window::display_all_data)
 101         (tui_data_window::refresh_all)
 102         (tui_data_window::do_scroll_vertical)
 103         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 104         (tui_data_window::do_make_visible_with_new_height)
 105         (tui_data_window::refresh_window): Move from elsewhere.
 106         (_initialize_tui_regs): Move to end of file.
 107         * tui/tui-layout.c: Update.
 108         * tui/tui-hooks.c: Update.
 109         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 110         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 111         tui-regs.c.
 112         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 113
 114 2019-07-17  Tom Tromey  <tom@tromey.com>
 115
 116         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 117         seen.
 118
 119 2019-07-17  Tom Tromey  <tom@tromey.com>
 120
 121         * tui/tui-win.c (tui_source_window_base::set_new_height)
 122         (tui_source_window_base::do_make_visible_with_new_height): Use
 123         m_has_locator field directly.
 124         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 125         method.
 126         (struct tui_source_window_base) <has_locator>: Likewise.
 127
 128 2019-07-17  Tom Tromey  <tom@tromey.com>
 129
 130         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 131         Don't declare.
 132         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 133         Remove.
 134         * tui/tui-win.c (tui_source_window_base::set_new_height)
 135         (tui_source_window_base::set_new_height)
 136         (make_invisible_and_set_new_height)
 137         (tui_source_window_base::do_make_visible_with_new_height)
 138         (tui_source_window_base::do_make_visible_with_new_height):
 139         Update.
 140         * tui/tui-layout.c (show_source_disasm_command, show_data)
 141         (show_source_or_disasm_and_command): Update.
 142         * tui/tui-layout.c (show_layout): Update.
 143
 144 2019-07-17  Tom Tromey  <tom@tromey.com>
 145
 146         * tui/tui-layout.c (make_data_window): Remove.
 147         (show_data): Unify creation and re-initialization cases.
 148
 149 2019-07-17  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui-layout.c (make_source_window, make_disasm_window):
 152         Remove.
 153         (show_data): Unify creation and re-initialization cases.
 154
 155 2019-07-17  Tom Tromey  <tom@tromey.com>
 156
 157         * tui/tui-layout.c (make_command_window): Remove.
 158         (show_source_disasm_command, show_source_or_disasm_and_command):
 159         Unify creation and re-initialization cases.
 160
 161 2019-07-17  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 164         creation and re-initialization cases.
 165
 166 2019-07-17  Tom Tromey  <tom@tromey.com>
 167
 168         * tui/tui-regs.c (tui_get_register): Return void.
 169
 170 2019-07-17  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 173         Simplify.
 174
 175 2019-07-17  Tom Tromey  <tom@tromey.com>
 176
 177         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 178         resetting.
 179
 180 2019-07-17  Tom Tromey  <tom@tromey.com>
 181
 182         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 183         * tui/tui-regs.c (tui_reg_layout): New function.
 184         (tui_show_registers, tui_reg_command): Use it.
 185         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 186         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 187         parameters.
 188         (tui_layout_command): Remove.
 189
 190 2019-07-17  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui-layout.h (tui/tui-layout): Return void.
 193         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 194
 195 2019-07-17  Tom Tromey  <tom@tromey.com>
 196
 197         * tui/tui-layout.c (show_source_disasm_command, show_data):
 198         Update.
 199         (reset_locator): Remove.
 200         (show_source_or_disasm_and_command): Update.
 201
 202 2019-07-17  Tom Tromey  <tom@tromey.com>
 203
 204         * tui/tui-source.c (tui_source_window_base::reset): Remove
 205         win_type parameter.
 206         * tui/tui-layout.c (make_command_window, make_source_window)
 207         (make_disasm_window, make_data_window)
 208         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 209         (reset_locator, show_source_or_disasm_and_command): Update.
 210         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 211         win_type parameter.
 212         (struct tui_source_window_base) <reset>: Likewise.
 213
 214 2019-07-17  Tom Tromey  <tom@tromey.com>
 215
 216         * tui/tui-layout.c (show_source_disasm_command): Use
 217         reset_locator.
 218         (reset_locator): New function.
 219         (init_and_make_win): Remove.
 220         (show_source_or_disasm_and_command): Use reset_locator.
 221
 222 2019-07-17  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 225         condition.
 226         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 227         Remove condition.
 228         * tui/tui-source.c (tui_source_window_base::reset): New method.
 229         * tui/tui-layout.c (make_command_window): Don't call
 230         init_and_make_win.
 231         (make_source_window, make_disasm_window): Don't call
 232         make_source_or_disasm_window.
 233         (make_data_window): Don't call init_and_make_win.  Change calling
 234         convention.
 235         (show_source_disasm_command, show_data): Simplify.
 236         (make_source_or_disasm_window): Remove.
 237         (show_source_or_disasm_and_command): Simplify.
 238         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 239         (struct tui_source_window_base) <reset>: Likewise.
 240         <execution_info>: Remove initializer.
 241         * tui/tui-data.c (tui_source_window_base): Initialize
 242         execution_info.
 243
 244 2019-07-17  Tom Tromey  <tom@tromey.com>
 245
 246         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 247         variable.
 248
 249 2019-07-17  Tom Tromey  <tom@tromey.com>
 250
 251         * tui/tui.c (tui_rl_other_window): Update.
 252         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 253         superclass method first.  Always iterate over regs_content.
 254         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 255         method.
 256         * tui/tui-win.c (tui_set_focus_command): Update.
 257
 258 2019-07-17  Tom Tromey  <tom@tromey.com>
 259
 260         * tui/tui-win.c (tui_set_focus_command): Rename from
 261         tui_set_focus.  Call tui_enable.
 262         (tui_set_focus_command): Remove.
 263
 264 2019-07-17  Tom Tromey  <tom@tromey.com>
 265
 266         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 267         refresh_window.
 268         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 269         touchwin.
 270         (tui_data_window::refresh_window): Call refresh_window on data
 271         items.  Always call superclass refresh_window.
 272         (tui_win_info::refresh): Remove.
 273         (tui_source_window_base::refresh_window): Update.
 274         (tui_refresh_all): Update.
 275         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 276         refresh_window.
 277         (show_source_or_disasm_and_command): Likewise.
 278         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 279         (struct tui_source_window_base) <refresh>: Likewise.
 280
 281 2019-07-17  Tom Tromey  <tom@tromey.com>
 282
 283         * tui/tui-winsource.c (tui_clear_source_content)
 284         (tui_show_source_content): Update.
 285         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 286         whether content is empty.
 287         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 288         Remove.
 289
 290 2019-07-17  Tom Tromey  <tom@tromey.com>
 291
 292         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 293         window's contents.
 294         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 295         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 296
 297 2019-07-17  Tom Tromey  <tom@tromey.com>
 298
 299         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 300         (struct tui_data_item_window): Update.
 301
 302 2019-07-17  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 305         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 306         defines.
 307
 308 2019-07-17  Tom Tromey  <tom@tromey.com>
 309
 310         * tui/tui-winsource.h (tui_erase_source_content)
 311         (tui_clear_source_content): Remove "display_prompt" parameter.
 312         * tui/tui-winsource.c (tui_update_source_window_as_is)
 313         (tui_update_source_windows_with_addr): Update.
 314         (tui_clear_source_content): Remove "display_prompt" parameter.
 315         (tui_erase_source_content): Likewise.  Simplify.
 316         (tui_show_source_content): Update.
 317         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 318         * tui/tui-stack.c (tui_show_frame_info): Update.
 319         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 320         Remove defines.
 321
 322 2019-07-17  Tom Tromey  <tom@tromey.com>
 323
 324         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 325         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 326         parameter.
 327         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 328         parameter.
 329
 330 2019-07-17  Tom Tromey  <tom@tromey.com>
 331
 332         * tui/tui-winsource.c (tui_clear_source_content)
 333         (tui_show_source_content, tui_show_exec_info_content)
 334         (tui_clear_exec_info_content): Update.
 335         * tui/tui-stack.c (tui_show_locator_content): Update.
 336         (tui_show_frame_info): Update.
 337         * tui/tui-source.h (tui_source_window): Don't declare.
 338         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 339         from tui_source_is_displayed.
 340         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 341         Remove field.
 342         (struct tui_source_window_base) <content_in_use>: New field.  Now
 343         bool.
 344         (struct tui_source_window) <showing_source_p>: New method.
 345         (TUI_SRC_WIN): Change cast.
 346         * tui/tui-data.c (tui_initialize_static_data): Update.
 347
 348 2019-07-17  Tom Tromey  <tom@tromey.com>
 349
 350         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 351         location_matches_p.
 352         * tui/tui-source.c (tui_source_window::location_matches_p): New
 353         method.
 354         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 355         method.
 356         * tui/tui-data.h (struct tui_source_window_base)
 357         <location_matches_p>: New method.
 358         (struct tui_source_window, struct tui_disasm_window)
 359         <location_matches_p>: Likewise.
 360
 361 2019-07-17  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-win.c (tui_set_win_height_command): Rename from
 364         tui_set_win_height.
 365         (tui_set_win_height_command): Remove.
 366
 367 2019-07-17  Tom Tromey  <tom@tromey.com>
 368
 369         * tui/tui-source.c (tui_source_window): New constructor.  Add
 370         observer.
 371         (~tui_source_window): New destructor.
 372         (tui_source_window::style_changed): New method.
 373         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 374         (tui_attach_detach_observers): Update.
 375         * tui/tui-data.h (struct tui_source_window): Make constructor not
 376         inline.  Add destructor.
 377         (struct tui_source_window) <style_changed>: New method.
 378         <m_observable>: New member.
 379
 380 2019-07-17  Tom Tromey  <tom@tromey.com>
 381
 382         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 383         * tui/tui-win.c (tui_resize_all): Fix typo.
 384
 385 2019-07-17  Tom Tromey  <tom@tromey.com>
 386
 387         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 388         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 389         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 390         * tui/tui-win.c (window_name_completer): Use foreach.
 391         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 392         (update_tab_width): Likewise.
 393         * tui/tui-layout.c (show_layout): Update.
 394         * tui/tui-data.h (class tui_window_iterator): New.
 395         (struct all_tui_windows): New.
 396         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 397
 398 2019-07-17  Tom Tromey  <tom@tromey.com>
 399
 400         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 401         parameter.  Don't reference globals.
 402         (tui_reg_command): Update.
 403
 404 2019-07-17  Tom Tromey  <tom@tromey.com>
 405
 406         * tui/tui-regs.c (tui_show_registers): Simplify.
 407
 408 2019-07-17  Tom Tromey  <tom@tromey.com>
 409
 410         * tui/tui-regs.c (tui_show_registers): Update.
 411         (tui_show_register_group): Add win_info parameter.
 412
 413 2019-07-17  Tom Tromey  <tom@tromey.com>
 414
 415         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 416         Rename from tui_display_reg_element_at_line.
 417         (tui_data_window::display_registers_from_line): Update.
 418         * tui/tui-data.h (struct tui_data_window)
 419         <display_reg_element_at_line>: New method.
 420
 421 2019-07-17  Tom Tromey  <tom@tromey.com>
 422
 423         * tui/tui-regs.h (tui_display_registers_from)
 424         (tui_display_registers_from_line): Don't declare.
 425         * tui/tui-windata.c (tui_data_window::display_all_data)
 426         (tui_data_window::refresh_all)
 427         (tui_data_window::do_scroll_vertical): Update.
 428         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 429         from tui_display_registers_from.
 430         (tui_display_reg_element_at_line): Update.
 431         (tui_data_window::display_registers_from_line): Rename from
 432         tui_display_registers_from_line.
 433         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 434         display_registers_from_line>: New methods.
 435
 436 2019-07-17  Tom Tromey  <tom@tromey.com>
 437
 438         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 439         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 440         from tui_erase_data_content.
 441         (tui_data_window::display_all_data)
 442         (tui_data_window::refresh_all)
 443         (tui_data_window::do_scroll_vertical): Update.
 444         * tui/tui-regs.c (tui_show_registers): Update.
 445         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 446         New method.
 447
 448 2019-07-17  Tom Tromey  <tom@tromey.com>
 449
 450         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 451         declare.
 452         * tui/tui-windata.c
 453         (tui_data_window::delete_data_content_windows): Rename from
 454         tui_delete_data_content_windows.
 455         (tui_data_window::display_all_data)
 456         (tui_data_window::do_scroll_vertical): Update.
 457         * tui/tui-data.h (struct tui_data_window)
 458         <delete_data_content_windows>: New method.
 459
 460 2019-07-17  Tom Tromey  <tom@tromey.com>
 461
 462         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 463         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 464
 465 2019-07-17  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 468         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 469         from tui_display_all_data.
 470         * tui/tui-win.c
 471         (tui_data_window::do_make_visible_with_new_height): Update.
 472         * tui/tui-regs.c (tui_show_registers): Update.
 473         * tui/tui-layout.c (tui_set_layout): Update.
 474         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 475         method.
 476
 477 2019-07-17  Tom Tromey  <tom@tromey.com>
 478
 479         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 480         * tui/tui-windata.c (tui_display_data_from): Remove.
 481         (tui_data_window::refresh_all): Update.
 482
 483 2019-07-17  Tom Tromey  <tom@tromey.com>
 484
 485         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 486         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 487         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 488         tui_display_registers_from_line.
 489         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 490         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 491         "force_display" parameter.
 492
 493 2019-07-17  Tom Tromey  <tom@tromey.com>
 494
 495         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 496         declare.
 497         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 498         Rename from tui_first_reg_element_no_inline.
 499         (tui_display_reg_element_at_line)
 500         (tui_display_registers_from_line): Update.
 501         * tui/tui-data.h (struct tui_data_window)
 502         <first_reg_element_no_inline>: New method.
 503
 504 2019-07-17  Tom Tromey  <tom@tromey.com>
 505
 506         * tui/tui-windata.c (tui_display_data_from)
 507         (tui_data_window::do_scroll_vertical): Update.
 508         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 509         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 510         Rename from tui_line_from_reg_element_no.
 511         (tui_display_registers_from_line): Update.
 512         * tui/tui-data.h (struct tui_data_window)
 513         <line_from_reg_element_no>: New method.
 514
 515 2019-07-17  Tom Tromey  <tom@tromey.com>
 516
 517         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 518         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 519         tui_last_regs_line_no.
 520         (tui_display_reg_element_at_line)
 521         (tui_display_registers_from_line): Update.
 522         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 523         method.
 524
 525 2019-07-17  Tom Tromey  <tom@tromey.com>
 526
 527         PR tui/24722:
 528         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 529         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 530         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 531         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 532         (tui_update_breakpoint_info): Likewise.
 533         * tui/tui-hooks.c (tui_event_create_breakpoint)
 534         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 535         Update.
 536
 537 2019-07-17  Tom Tromey  <tom@tromey.com>
 538
 539         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 540
 541 2019-07-17  Tom Tromey  <tom@tromey.com>
 542
 543         * tui/tui-winsource.c (tui_update_source_window_as_is)
 544         (tui_update_source_windows_with_addr): Update.
 545         * tui/tui-source.h (tui_set_source_content)
 546         (tui_show_symtab_source): Add "win_info" parameter.
 547         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 548         parameter.
 549         (tui_show_symtab_source): Likewise.
 550
 551 2019-07-17  Tom Tromey  <tom@tromey.com>
 552
 553         * tui/tui-wingeneral.c
 554         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 555
 556 2019-07-17  Tom Tromey  <tom@tromey.com>
 557
 558         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 559         (struct tui_cmd_window) <can_scroll>: New method.
 560         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 561         method.
 562
 563 2019-07-17  Tom Tromey  <tromey@adacore.com>
 564
 565         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 566         do_field_signed>: Rename.  Change type of "value".
 567         * ui-out.c (ui_out::field_signed): Rename from field_int.
 568         Change type of "value".
 569         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 570         type of "value".
 571         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 572         do_field_int.  Change type of "value".
 573         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 574         do_field_int.  Change type of "value".
 575         * tracepoint.c (trace_status_mi, tfind_1)
 576         (print_one_static_tracepoint_marker): Update.
 577         * thread.c (print_thread_info_1, print_selected_thread_frame):
 578         Update.
 579         * stack.c (print_frame, print_frame_info): Update.
 580         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 581         Update.
 582         * source.c (print_source_lines_base): Update.
 583         * skip.c (info_skip_command): Update.
 584         * record-btrace.c (btrace_ui_out_decode_error)
 585         (btrace_call_history_src_line): Update.
 586         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 587         Update.
 588         * progspace.c (print_program_space): Update.
 589         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 590         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 591         do_field_int.  Change type of "value".
 592         * mi/mi-out.c (mi_ui_out::do_table_begin)
 593         (mi_ui_out::do_table_header): Update.
 594         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 595         type of "value".
 596         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 597         (mi_cmd_data_list_changed_registers, output_register)
 598         (mi_cmd_data_read_memory, mi_load_progress)
 599         (mi_cmd_trace_frame_collected): Update.
 600         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 601         Update.
 602         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 603         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 604         (mi_cmd_var_list_children, varobj_update_one): Update.
 605         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 606         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 607         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 608         * inferior.c (print_inferior): Update.
 609         * gdb_bfd.c (print_one_bfd): Update.
 610         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 611         Update.
 612         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 613         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 614         do_field_int.  Change type of "value".
 615         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 616         do_field_int.  Change type of "value".
 617         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 618         (print_one_breakpoint_location, print_it_catch_fork)
 619         (print_one_catch_fork, print_it_catch_vfork)
 620         (print_one_catch_vfork, print_it_catch_solib)
 621         (print_it_catch_exec, print_it_ranged_breakpoint)
 622         (print_mention_watchpoint, print_mention_masked_watchpoint)
 623         (bkpt_print_it, update_static_tracepoint): Update.
 624         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 625         * break-catch-syscall.c (print_it_catch_syscall): Update.
 626         * ada-tasks.c (print_ada_task_info): Update.
 627         * ada-lang.c (print_it_exception, print_mention_exception):
 628         Update.
 629
 630 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 631
 632         PR breakpoints/24541
 633         * gdbarch.c: Regenerate.
 634         * gdbarch.h: Regenerate.
 635         * gdbarch.sh: Adjust return type and parameter types for
 636         'stap_adjust_register'.
 637         (i386_stap_adjust_register): Adjust signature and return new
 638         register name.
 639         * stap-probe.c (stap_parse_register_operand): Adjust use of
 640         'gdbarch_stap_adjust_register'.
 641
 642 2019-07-17  Tom Tromey  <tromey@adacore.com>
 643
 644         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 645         declare VEC.
 646         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 647         std::vector.
 648         (struct s390_process_info): Add initializers.
 649         (s390_add_process): Use new.
 650         (s390_linux_nat_target::low_forget_process): Use delete.
 651         (s390_linux_nat_target::low_new_fork)
 652         (s390_linux_nat_target::stopped_by_watchpoint)
 653         (s390_linux_nat_target::low_prepare_to_resume)
 654         (s390_linux_nat_target::insert_watchpoint)
 655         (s390_linux_nat_target::insert_hw_breakpoint)
 656         (s390_linux_nat_target::remove_watchpoint)
 657         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 658
 659 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 660
 661         * aarch64-fbsd-nat.c: Include regcache.h.
 662         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 663         argument.
 664         (aarch64_fbsd_nat_target::fetch_registers)
 665         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 666         variable.
 667         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 668
 669 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 670
 671         * fbsd-nat.c: Include gdbarch.h.
 672
 673 2019-07-15  Tom Tromey  <tromey@adacore.com>
 674
 675         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 676
 677 2019-07-15  Tom Tromey  <tromey@adacore.com>
 678
 679         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 680         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 681         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 682         * cli-out.c (cli_ui_out::do_field_int): New method.
 683         * ui-out.c (ui_out::field_unsigned): New method.
 684         * symfile.c (generic_load): Use field_unsigned.
 685         (print_transfer_performance): Likewise.
 686         * record-btrace.c (ui_out_field_uint): Remove.
 687         (btrace_call_history_insn_range, btrace_call_history): Use
 688         field_unsigned.
 689         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 690         field_unsigned.
 691         * ui-out.h (class ui_out) <field_unsigned>: New method.
 692         <do_field_unsigned>: Likewise.
 693
 694 2019-07-15  Tom Tromey  <tromey@adacore.com>
 695
 696         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 697         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 698         * target.c (flash_erase_command): Use field_string.
 699         * infrun.c (print_signal_received_reason): Use field_string.
 700         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 701         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 702         field_string.
 703         * ada-tasks.c (print_ada_task_info): Use field_string.
 704
 705 2019-07-15  Tom Tromey  <tromey@adacore.com>
 706
 707         * target.c (flash_erase_command): Use field_core_addr.
 708         * symfile.c (generic_load): Use field_core_addr.
 709         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 710         Use field_core_addr.
 711         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 712         field_core_addr.
 713
 714 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 715
 716         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 717         value if its desired type is smaller than a CORE_ADDR and signed.
 718
 719 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 720
 721         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 722         of changes to field names, and use new is_reference field to
 723         decide if a property is a reference or not.
 724         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 725         field.
 726         (struct dwarf2_property_baton): Update header comment, rename
 727         'referenced_type' to 'property_type' and update comments.
 728         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 729         default property type, store in property baton, update to take
 730         accound of renamed field.
 731         (read_func_scope): Update call to attr_to_dynamic_prop.
 732         (read_array_type): Likewise.
 733         (dwarf2_per_cu_addr_sized_int_type): New function.
 734         (read_subrange_index_type): Move type finding code to
 735         dwarf2_per_cu_addr_sized_int_type.
 736         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 737         (dwarf2_per_cu_addr_type): New function.
 738         (set_die_type): Update calls to attr_to_dynamic_prop.
 739
 740 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 741
 742         * dwarf2read.c (read_subrange_index_type): New function.
 743         (read_subrange_type): Move code into new function and call it.
 744         * gdbtypes.c (create_range_type): Add some asserts.
 745
 746 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 747
 748         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 749         update return statements.
 750         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 751         declaration, and update comment to match.
 752         * gdbtypes.c (resolve_dynamic_array): Update call to
 753         dwarf2_evaluate_property to match new return type.
 754
 755 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 756
 757         * valarith.c (value_subscripted_rvalue): Change lowerbound
 758         parameter type from int to LONGEST.
 759         * value.h (value_subscripted_rvalue): Likewise in declaration.
 760
 761 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 762
 763         * cli/cli-utils.c (info_print_command_completer): New function.
 764         * cli/cli-utils.h: Add 'completer.h' include, and forward
 765         declaration for 'struct cmd_list_element'.
 766         (info_print_command_completer): Declare.
 767         * stack.c (_initialize_stack): Add completer for 'info locals' and
 768         'info args'.
 769         * symtab.c (_initialize_symtab): Add completer for 'info
 770         variables' and 'info functions'.
 771         * NEWS: Mention completion for additional info commands.
 772
 773 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 774
 775         * cli/cli-utils.c (extract_info_print_args): Delete.
 776         (extract_arg_maybe_quoted): Delete.
 777         (info_print_options_defs): New variable.
 778         (make_info_print_options_def_group): New function.
 779         (extract_info_print_options): Define new function.
 780         * cli/cli-utils.h (extract_info_print_args): Delete.
 781         (struct info_print_options): New structure.
 782         (extract_info_print_options): Declare new function.
 783         * stack.c (info_locals_command): Update to use new
 784         extract_info_print_options, also add a header comment.
 785         (info_args_command): Likewise.
 786         * symtab.c (info_variables_command): Likewise.
 787         (info_functions_command): Likewise.
 788
 789 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 790
 791         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 792         to extract string arguments.
 793         * common/common-utils.c (extract_string_maybe_quoted): New function.
 794         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 795
 796 2019-07-11  Tom Tromey  <tromey@adacore.com>
 797
 798         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 799         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 800         * top.h (gdbinit): Don't declare.
 801         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 802         into...
 803         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 804         * top.c (gdb_init): Don't call init_cli_cmds.
 805         (gdbinit): Remove.
 806         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 807
 808 2019-07-11  Tom Tromey  <tromey@adacore.com>
 809
 810         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 811         after it has been moved.
 812
 813 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 814
 815         * valops.c (value_must_coerce_to_target): Change return type to
 816         bool.
 817         * value.h (value_must_coerce_to_target): Likewise.
 818
 819 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 820
 821         * breakpoint.c (is_hardware_watchpoint): Remove
 822         forward-declaration.
 823         (is_masked_watchpoint): Change return type to bool.
 824         (is_tracepoint): Likewise.
 825         (is_breakpoint): Likewise.
 826         (is_hardware_watchpoint): Likewise.
 827         (is_watchpoint): Likewise.
 828         (is_no_memory_software_watchpoint): Likewise.
 829         (is_catchpoint): Likewise.
 830         (breakpoint_1): Make FILTER parameter's return type bool.
 831         is_masked_watchpoint): Change return type to bool.
 832         (save_breakpoints): Make FILTER parameter's return type bool.
 833         * breakpoint.h (is_breakpoint): Change return type to bool.
 834         (is_watchpoint): Likewise.
 835         (is_catchpoint): Likewise.
 836         (is_tracepoint): Likewise.
 837
 838 2019-07-10  Tom Tromey  <tom@tromey.com>
 839
 840         * defs.h: Don't include gdbarch.h.
 841         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 842         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 843         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 844         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 845         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 846         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 847         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 848         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 849         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 850         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 851         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 852         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 853         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 854         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 855         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 856         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 857         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 858         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 859         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 860         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 861         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 862         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 863         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 864         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 865         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 866         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 867         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 868
 869 2019-07-10  Tom Tromey  <tromey@adacore.com>
 870
 871         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 872         * breakpoint.c (init_ada_exception_breakpoint): Register as
 873         bp_catchpoint.
 874         (print_one_breakpoint_location, print_one_breakpoint): Use
 875         is_ada_exception_catchpoint.
 876         * ada-lang.c (class ada_catchpoint_location): Pass
 877         bp_loc_software_breakpoint to bp_location constructor.
 878         (is_ada_exception_catchpoint): New function.
 879
 880 2019-07-10  Tom Tromey  <tromey@adacore.com>
 881
 882         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 883         VEC.
 884         (struct arm_exidx_entry): New method operator<.
 885         (struct arm_exidx_data) <section_maps>: Change type.
 886         (arm_exidx_data_free): Remove.
 887         (arm_exidx_data_key): Change type.  Move lower.
 888         (arm_exidx_new_objfile): Update.
 889         (arm_compare_exidx_entries): Remove.
 890         (arm_find_exidx_entry, _initialize_arm_tdep)
 891
 892 2019-07-10  Tom Tromey  <tromey@adacore.com>
 893
 894         * solib-spu.c (ocl_program_data_key): Change type.
 895         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 896         Update.
 897
 898 2019-07-10  Tom Tromey  <tromey@adacore.com>
 899
 900         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 901         (struct solib_aix_inferior_data) <library_list>: Change type.
 902         (solib_aix_inferior_data_handle): Change type.
 903         (get_solib_aix_inferior_data): Update.
 904         (solib_aix_free_library_list): Remove.
 905         (library_list_start_library): Update.
 906         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 907         return type.
 908         (solib_aix_get_library_list)
 909         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 910         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 911
 912 2019-07-10  Tom Tromey  <tromey@adacore.com>
 913
 914         * solib-dsbt.c (struct dsbt_info): Add initializers.
 915         (solib_dsbt_pspace_data): Change type.
 916         (dsbt_pspace_data_cleanup): Remove.
 917         (get_dsbt_info, _initialize_dsbt_solib): Update.
 918
 919 2019-07-10  Tom Tromey  <tromey@adacore.com>
 920
 921         * spu-tdep.c (spu_overlay_data): Change type.
 922         (spu_get_overlay_table, spu_overlay_new_objfile)
 923         (_initialize_spu_tdep): Update.
 924
 925 2019-07-10  Tom Tromey  <tromey@adacore.com>
 926
 927         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 928         destructor.
 929         (dbx_objfile_data_key): Change type and declare later.
 930         (DBX_SYMFILE_INFO): Rewrite.
 931         * dbxread.c (dbx_objfile_data_key): Change type.
 932         (dbx_symfile_init): Update.
 933         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 934         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 935         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 936
 937 2019-07-10  Tom Tromey  <tromey@adacore.com>
 938
 939         * jit.c (jit_program_space_key): Change type.  Move lower.
 940         (get_jit_program_space_data): Update.
 941         (jit_program_space_data_cleanup): Remove.
 942         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 943         Update.
 944         (struct jit_program_space_data): Add initializers.
 945
 946 2019-07-10  Tom Tromey  <tromey@adacore.com>
 947
 948         * solib-darwin.c (struct darwin_info): Add initializers.
 949         (solib_darwin_pspace_data): Change type.
 950         (darwin_pspace_data_cleanup): Remove.
 951         (get_darwin_info, _initialize_darwin_solib): Update.
 952
 953 2019-07-10  Tom Tromey  <tromey@adacore.com>
 954
 955         * remote-sim.c (struct sim_inferior_data): Add initializers,
 956         constructor, and destructor.
 957         (sim_inferior_data_key): Change type.  Move lower.
 958         (check_for_duplicate_sim_descriptor): Update.
 959         (get_sim_inferior_data): Use new.  Update.
 960         (~sim_inferior_data_cleanup): Rename from
 961         sim_inferior_data_cleanup.  Simplify.
 962         (gdbsim_close_inferior, simulator_command)
 963         (sim_command_completer, _initialize_remote_sim): Update.
 964         (next_pid, INITIAL_PID): Move earlier.
 965
 966 2019-07-10  Tom Tromey  <tromey@adacore.com>
 967
 968         * python/python-internal.h (create_thread_object): Return
 969         gdbpy_ref.
 970         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 971         * python/py-inferior.c (struct threadlist_entry): Add
 972         constructor.
 973         <thread_obj>: Now a gdbpy_ref.
 974         (thread_to_thread_object): Update.
 975         (add_thread_object): Use new.
 976         (delete_thread_object): Use delete.
 977         (infpy_threads): Update.
 978         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 979         GIL.
 980
 981 2019-07-10  Tom Tromey  <tromey@adacore.com>
 982
 983         * valops.c (value_cast): Specialize error message for Ada.
 984
 985 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 986
 987         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 988
 989 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 990
 991         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 992         bpstat_should_step): Return bool, adjust comments.
 993         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 994         bpstat_should_step): Likewise.
 995
 996 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 997
 998         * features/Makefile: Use feature target descriptions for Arm.
 999         * features/arm/arm-core.c: Generate new file.
1000         * features/arm/arm-fpa.c: Likewise.
1001         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1002         * features/arm/arm-m-profile.c: Likewise.
1003         * features/arm/arm-vfpv2.c: Likewise.
1004         * features/arm/arm-vfpv3.c: Likewise.
1005         * features/arm/xscale-iwmmxt.c: Likewise.
1006         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1007
1008 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1009
1010         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1011         ptrace earlier.
1012
1013 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1014
1015         * features/aarch64-pauth.c: Regenerate.
1016
1017 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1018
1019         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1020         bool.
1021         (bpstat_what): Use false instead of 0.
1022
1023 2019-07-09  Pedro Alves  <palves@redhat.com>
1024
1025         * break-catch-throw.c (is_exception_catchpoint): New.
1026         * breakpoint.c (print_one_breakpoint_location): New parameter
1027         'raw_loc'.  Handle it.  Use
1028         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1029         looking at the breakpoint's type.
1030         (print_one_breakpoint): If handling "maint info breakpoints", also
1031         print locations of exception catchpoints.
1032         * breakpoint.h (is_exception_catchpoint): Declare.
1033
1034 2019-07-09  Pedro Alves  <palves@redhat.com>
1035
1036         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1037         "addr" field.
1038         (allocate_location_exception_catchpoint): New.
1039         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1040         (initialize_throw_catchpoint_ops): Install
1041         allocate_location_exception_catchpoint as allocate_location
1042         method.
1043         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1044         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1045         bp_loc_other.
1046         (breakpoint_address_is_meaningful): Delete.
1047         (bl_address_is_meaningful): New.
1048         (breakpoint_locations_match): Adjust comment.
1049         (bp_location_from_bp_type): New, factored out of...
1050         (bp_location::bp_location(breakpoint *)): ... this.
1051         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1052         factored out of...
1053         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1054         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1055         breakpoint_address_is_meaningful.
1056         (bp_locations_compare): Adjust comment.
1057         (update_global_location_list): Use bl_address_is_meaningful
1058         instead of breakpoint_address_is_meaningful.
1059         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1060         explicit.
1061         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1062         * python/py-breakpoint.c (bppy_get_location): No longer check
1063         whether location is null.
1064
1065 2019-07-09  Pedro Alves  <palves@redhat.com>
1066
1067         PR c++/15468
1068         * breakpoint.c (print_one_breakpoint_location): Remove
1069         single-location assert.
1070
1071 2019-07-09  Tom Tromey  <tom@tromey.com>
1072
1073         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1074         * configure: Rebuild.
1075         * configure.ac: Change common to gdbsupport.
1076         * gdbsupport: Rename from common.
1077         * acinclude.m4: Change common to gdbsupport.
1078         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1079         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1080         gdbsupport.
1081         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1082         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1083         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1084         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1085         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1086         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1087         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1088         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1089         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1090         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1091         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1092         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1093         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1094         coff-pe-read.c, command.h, compile/compile-c-support.c,
1095         compile/compile-c.h, compile/compile-cplus-symbols.c,
1096         compile/compile-cplus-types.c, compile/compile-cplus.h,
1097         compile/compile-loc2c.c, compile/compile.c, completer.c,
1098         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1099         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1100         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1101         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1102         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1103         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1104         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1105         features/aarch64-core.c, features/aarch64-fpu.c,
1106         features/aarch64-pauth.c, features/aarch64-sve.c,
1107         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1108         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1109         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1110         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1111         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1112         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1113         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1114         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1115         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1116         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1117         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1118         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1119         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1120         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1121         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1122         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1123         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1124         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1125         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1126         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1127         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1128         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1129         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1130         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1131         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1132         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1133         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1134         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1135         minsyms.c, mips-linux-tdep.c, namespace.h,
1136         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1137         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1138         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1139         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1140         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1141         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1142         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1143         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1144         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1145         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1146         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1147         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1148         procfs.c, producer.c, progspace.h, psymtab.h,
1149         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1150         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1151         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1152         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1153         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1154         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1155         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1156         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1157         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1158         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1159         target-memory.c, target.c, target.h, target/waitstatus.c,
1160         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1161         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1162         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1163         unittests/array-view-selftests.c,
1164         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1165         unittests/common-utils-selftests.c,
1166         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1167         unittests/format_pieces-selftests.c,
1168         unittests/function-view-selftests.c,
1169         unittests/lookup_name_info-selftests.c,
1170         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1171         unittests/mkdir-recursive-selftests.c,
1172         unittests/observable-selftests.c,
1173         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1174         unittests/parse-connection-spec-selftests.c,
1175         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1176         unittests/scoped_fd-selftests.c,
1177         unittests/scoped_mmap-selftests.c,
1178         unittests/scoped_restore-selftests.c,
1179         unittests/string_view-selftests.c, unittests/style-selftests.c,
1180         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1181         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1182         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1183         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1184         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1185         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1186
1187 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1188
1189         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1190         bool value.
1191         (decode_digits_ordinary): Set explicit_line field in sal.
1192         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1193         symtab_and_line that was set on an explicit line number in
1194         assembler code.  Do always update the recorded symtab and line if
1195         we do skip the prologue.
1196
1197 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1198
1199         * breakpoint.c (set_breakpoint_location_function): Remove
1200         explicit_loc parameter.
1201         (momentary_breakpoint_from_master): Update call to
1202         set_breakpoint_location_function.
1203         (add_location_to_breakpoint): Likewise.
1204
1205 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1206
1207         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1208         required features based on default bfd type when no specific bfd
1209         is present.
1210
1211 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1212
1213         * NEWS: Mention that GDB printf and eval commands can now print
1214         C-style and Ada-style convenience var strings without
1215         calling the inferior.
1216         * printcmd.c (printf_c_string): Locally print GDB internal var
1217         instead of transiting via the inferior.
1218         (printf_wide_c_string): Likewise.
1219
1220 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1221
1222         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1223
1224 2019-07-04  Tom Tromey  <tom@tromey.com>
1225
1226         PR tui/24724:
1227         * tui/tui-winsource.c (tui_clear_source_content): Update.
1228         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1229         (tui_update_breakpoint_info): Update.
1230         (tui_set_exec_info_content): Update.
1231         * tui/tui-source.c (tui_set_source_content_nil): Update.
1232         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1233         has_break.
1234         * tui/tui-data.h (enum tui_bp_flag): New.
1235         (tui_bp_flags): New enum flags type.
1236         (struct tui_source_element) <break_mode>: Change type.  Rename
1237         from has_break.
1238         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1239         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1240         constants.
1241         * tui/tui-winsource.h: Fix comment.
1242
1243 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1244
1245         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1246         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1247         (store_fpregs_to_thread)
1248         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1249         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1250         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1251         (IWMMXT_REGS_SIZE): Add define.
1252         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1253         (fetch_vfp_regs, store_vfp_regs)
1254         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1255         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1256
1257 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1258
1259         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1260         defines.
1261         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1262         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1263         (ARM_INT_REGISTER_SIZE): ...to this.
1264         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1265         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1266         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1267         (arm_linux_collect_gregset, supply_nwfpe_register)
1268         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1269         defines.
1270         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1271         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1272         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1273         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1274         (arm_return_in_memory, arm_store_return_value)
1275         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1276         (arm_record_ld_st_multiple): Likewise.
1277         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1278         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1279
1280 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1281
1282         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1283         AARCH64_DISPLACED_MODIFIED_INSNS.
1284         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1285         (aarch64_displaced_step_copy_insn): Likewise.
1286         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1287         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1288         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1289         ARM_DISPLACED_MODIFIED_INSNS.
1290         * arm-tdep.c (arm_gdbarch_init): Likewise.
1291         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1292         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1293         (struct arm_displaced_step_closure): Use
1294         ARM_DISPLACED_MODIFIED_INSNS.
1295
1296 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1297
1298         * features/Makefile: Remove unused xml files.
1299         * features/aarch64.xml: Remove.
1300         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1301         * features/i386/amd64-avx-avx512.xml: Remove.
1302         * features/i386/amd64-avx-linux.xml: Remove.
1303         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1304         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1305         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1306         * features/i386/amd64-avx-mpx.xml: Remove.
1307         * features/i386/amd64-avx.xml: Remove.
1308         * features/i386/amd64-linux.xml: Remove.
1309         * features/i386/amd64-mpx-linux.xml: Remove.
1310         * features/i386/amd64-mpx.xml: Remove.
1311         * features/i386/amd64.xml: Remove.
1312         * features/i386/i386-avx-avx512-linux.xml: Remove.
1313         * features/i386/i386-avx-avx512.xml: Remove.
1314         * features/i386/i386-avx-linux.xml: Remove.
1315         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1316         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1317         * features/i386/i386-avx-mpx-linux.xml: Remove.
1318         * features/i386/i386-avx-mpx.xml: Remove.
1319         * features/i386/i386-avx.xml: Remove.
1320         * features/i386/i386-linux.xml: Remove.
1321         * features/i386/i386-mmx-linux.xml: Remove.
1322         * features/i386/i386-mmx.xml: Remove.
1323         * features/i386/i386-mpx-linux.xml: Remove.
1324         * features/i386/i386-mpx.xml: Remove.
1325         * features/i386/i386.xml: Remove.
1326         * features/i386/x32-avx-avx512-linux.xml: Remove.
1327         * features/i386/x32-avx-linux.xml: Remove.
1328         * features/i386/x32-linux.xml: Remove.
1329
1330 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1331
1332         * regformats/aarch64.dat: Remove.
1333         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1334         * regformats/i386/amd64-avx-linux.dat: Remove.
1335         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1336         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1337         * regformats/i386/amd64-linux.dat: Remove.
1338         * regformats/i386/amd64-mpx-linux.dat: Remove.
1339         * regformats/i386/amd64.dat: Remove.
1340         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1341         * regformats/i386/i386-avx-linux.dat: Remove.
1342         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1343         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1344         * regformats/i386/i386-linux.dat: Remove.
1345         * regformats/i386/i386-mmx-linux.dat: Remove.
1346         * regformats/i386/i386-mpx-linux.dat: Remove.
1347         * regformats/i386/i386.dat: Remove.
1348         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1349         * regformats/i386/x32-avx-linux.dat: Remove.
1350         * regformats/i386/x32-linux.dat: Remove.
1351
1352 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1353
1354         * aarch64-tdep.c: Remove xml self tests.
1355         * amd64-linux-tdep.c: Likewise.
1356         * amd64-tdep.c: Likewise.
1357         * i386-linux-tdep.c: Likewise.
1358         * i386-tdep.c: Likewise.
1359
1360 2019-07-03  Pedro Alves  <palves@redhat.com>
1361
1362         PR cli/24732
1363         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1364         (pipe_cmd_option_defs): New.
1365         (make_pipe_cmd_options_def_group): New.
1366         (pipe_command): Use gdb::option::process_options.
1367         (pipe_command_completer): New function.
1368         (_initialize_cli_cmds): Install completer for "pipe" command.
1369
1370 2019-07-03  Pedro Alves  <palves@redhat.com>
1371
1372         * cli/cli-option.c (union option_value) <string>: New field.
1373         (struct option_def_and_value): Add ctor, move ctor, dtor and
1374         use DISABLE_COPY_AND_ASSIGN.
1375         (option_def_and_value::clear_value): New.
1376         (parse_option, save_option_value_in_ctx, get_val_type_str)
1377         (add_setshow_cmds_for_options): Handle var_string.
1378         * cli-option.h (union option_def::var_address) <string>: New
1379         field.
1380         (struct string_option_def): New.
1381         * maint-test-options.c (struct test_options_opts): Add default
1382         ctor and use DISABLE_COPY_AND_ASSIGN.
1383         <string_opt>: New field.
1384         (test_options_opts::~test_options_opts): New.
1385         (test_options_opts::dump): Also dump "-string".
1386         (test_options_option_defs): Install "string.
1387
1388 2019-07-03  Pedro Alves  <palves@redhat.com>
1389
1390         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1391         option_value with a null enumeration.
1392         (complete_options): Save the option values in the context.
1393         (save_option_value_in_ctx): New, factored out from ...
1394         (process_options): ... here.
1395         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1396         of the function.
1397         * maint-test-options.c (test_options_opts::dump): New, factored
1398         out from ...
1399         (maintenance_test_options_command_mode): ... here.
1400         (maintenance_test_options_command_completion_result): Delete.
1401         (maintenance_test_options_command_completion_text): Update
1402         comment.
1403         (maintenance_show_test_options_completion_result): Change
1404         prototype.  Just print
1405         maintenance_test_options_command_completion_text.
1406         (save_completion_result): New.
1407         (maintenance_test_options_completer_mode): Pass options context to
1408         complete_options, and then save a dump.
1409         (_initialize_maint_test_options): Use add_cmd to install "maint
1410         show test-options-completion-result".
1411
1412 2019-07-03  Pedro Alves  <palves@redhat.com>
1413
1414         * NEWS (New commands): Mention "with" and "maint with".
1415         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1416         (with_command, with_command_completer): New.
1417         (pipe_command): Adjust to new repeat_previous
1418         interface.
1419         (_initialize_cli_cmds): Install the "with" command and its "w"
1420         alias.
1421         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1422         declarations.
1423         * cli/cli-setshow.c (parse_cli_var_uinteger)
1424         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1425         argument strings for all var_types.
1426         (get_setshow_command_value_string): New, factored out from ...
1427         (do_show_command): ... this.
1428         * cli/cli-setshow.h: Include <string>.
1429         (get_setshow_command_value_string): Declare.
1430         * command.h (repeat_previous): Now returns const char *.  Adjust
1431         comment.
1432         * maint.c: Include "cli/cli-cmds.h".
1433         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1434         (_initialize_maint_cmds): Register the "maintenance with" command.
1435         * top.c (repeat_previous): Move bits from pipe_command here:
1436         Return the saved command line, if any; error out if there's no
1437         command to relaunch.
1438
1439 2019-07-03  Pedro Alves  <palves@redhat.com>
1440
1441         * NEWS (New commands): Mention "maint set/show test-settings"
1442         instead of "maint test-settings".
1443         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1444         (maintenance_test_settings_set_list): Rename to ...
1445         (maintenance_set_test_settings_list): ... this.
1446         (maintenance_test_settings_show_list): Rename to  ...
1447         (maintenance_show_test_settings_list): ... this.
1448         (maintenance_test_settings_cmd): Delete.
1449         (maintenance_test_settings_set_cmd): ...
1450         (maintenance_set_test_settings_cmd): ... this.
1451         (maintenance_test_settings_show_cmd): ...
1452         (maintenance_show_test_settings_cmd): ... this.
1453         (maintenance_test_settings_show_value_cmd):
1454         (maintenance_show_test_settings_value_cmd): ... this.
1455         (_initialize_maint_test_settings): No longer install the "maint
1456         test-settings" prefix command.  Rename "maint test-settings set"
1457         to "maint set test-settings", and "maint test-settings show" to
1458         "maint show test-settings".  Adjust all subcommands.
1459
1460 2019-07-03  Pedro Alves  <palves@redhat.com>
1461
1462         * maint-test-settings.c: Fix file's intro comment.  Replace all
1463         references to "test-options" with references to "test-settings",
1464         in comments.
1465
1466 2019-07-03  Pedro Alves  <palves@redhat.com>
1467
1468         * maint-test-settings.c (maintenance_test_settings_xxx)
1469         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1470         New.
1471         (maintenance_test_settings_enums): Use them.
1472         (maintenance_test_settings_enum): Default to
1473         maintenance_test_settings_xxx.
1474         (_initialize_maint_test_settings): Initialize
1475         MAINTENANCE_TEST_SETTINGS_FILENAME.
1476
1477 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1478
1479         * breakpoint.h (remove_breakpoints_inf): Change return type to
1480         void, move function documentation here.
1481         * breakpoint.c (remove_breakpoints_inf): Change return type to
1482         void, move function documentation to header.
1483
1484 2019-07-02  Pedro Alves  <palves@redhat.com>
1485
1486         * NEWS (Completion improvements): Mention "info threads".
1487         * thread.c (struct info_threads_opts, info_threads_option_defs)
1488         (make_info_threads_options_def_group): New.
1489         (info_threads_command): Use gdb::option::process_options.
1490         (info_threads_command_completer): New.
1491         (_initialize_thread): Use gdb::option::build_help to build the
1492         help text for "info threads".
1493
1494 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1495
1496         * defs.h (generic_load): Move from here...
1497         * symfile.h (generic_load): ... to here.  Rename name parameter
1498         to args.
1499         * symfile.c (generic_load): Add comment.
1500
1501 2019-07-01  Tom Tromey  <tromey@adacore.com>
1502
1503         * dwarf2read.c
1504         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1505         declaration of without_params.  Fix formatting.
1506
1507 2019-07-01  Tom Tromey  <tromey@adacore.com>
1508
1509         * ada-exp.y (find_primitive_type): Update.
1510         * ada-lang.h (ada_lookup_symbol): Update.
1511         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1512         parameter.
1513         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1514
1515 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1516
1517         PR breakpoints/24541
1518         * gdbarch.c: Regenerate.
1519         * gdbarch.h: Regenerate.
1520         * gdbarch.sh: Add 'stap_adjust_register'.
1521         * i386-tdep.c: Include '<unordered_set>'.
1522         (i386_stap_adjust_register): New function.
1523         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1524         * stap-probe.c (stap_parse_register_operand): Call
1525         'gdbarch_stap_adjust_register'.
1526
1527 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1528
1529         PR python/24742
1530         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1531         * python/python.c (do_start_initialization): Use 'xmalloc'
1532         instead of 'PyMem_Malloc'.
1533
1534 2019-06-28  Tom Tromey  <tromey@adacore.com>
1535
1536         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1537         for Ada.
1538
1539 2019-06-27  Tom Tromey  <tromey@adacore.com>
1540
1541         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1542         objfile_key.
1543         (arm_find_mapping_symbol, arm_record_special_symbol)
1544         (_initialize_arm_tdep): Update.
1545         (arm_objfile_data_free): Remove.
1546
1547 2019-06-27  Tom Tromey  <tromey@adacore.com>
1548
1549         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1550         to cp_print_static_field.
1551
1552 2019-06-26  Tom Tromey  <tromey@adacore.com>
1553
1554         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1555         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1556         declare.
1557
1558 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1559
1560         * features/aarch64-core.c (create_feature_aarch64_core):
1561         Regenerate.
1562         * features/aarch64-core.xml: Add cpsr flags.
1563
1564 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1565
1566         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1567         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1568
1569 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1570
1571         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1572         field.
1573         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1574         use.
1575         (arm_record_special_symbol): Don't insert new symbol in sorted
1576         position, push it at the end.
1577
1578 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1579
1580         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1581         (arm_mapping_symbol_s): Remove.
1582         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1583         (arm_mapping_symbol_vec): New typedef.
1584         (struct arm_per_objfile): Add constructor.
1585         <section_maps>: Change type to
1586         std::unique_ptr<arm_mapping_symbol_vec[]>.
1587         (arm_compare_mapping_symbols): Remove.
1588         (arm_find_mapping_symbol): Adjust to section_maps type change.
1589         (arm_objfile_data_free): Call delete on arm_per_objfile.
1590         (arm_record_special_symbol): Adjust to section_maps type change.
1591         Allocate arm_per_objfile with new.
1592
1593 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1594
1595         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1596         with the command prefix.
1597
1598 2019-06-25  Tom Tromey  <tom@tromey.com>
1599
1600         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1601         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1602
1603 2019-06-25  Tom Tromey  <tom@tromey.com>
1604
1605         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1606         type.
1607         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1608         protected.
1609
1610 2019-06-25  Tom Tromey  <tom@tromey.com>
1611
1612         * tui/tui-winsource.c
1613         (tui_source_window_base::set_is_exec_point_at): Add check against
1614         LOA_ADDRESS.
1615
1616 2019-06-25  Tom Tromey  <tom@tromey.com>
1617
1618         * tui/tui-source.c (tui_set_source_content): Don't check before
1619         xfree.
1620         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1621
1622 2019-06-25  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui-winsource.h (tui_update_source_window_as_is)
1625         (tui_alloc_source_buffer, tui_line_is_displayed)
1626         (tui_addr_is_displayed): Change type of win_info.
1627         * tui/tui-winsource.c (tui_update_source_window_as_is)
1628         (tui_clear_source_content, tui_show_source_line)
1629         (tui_show_source_content, tui_source_window_base::refill)
1630         (tui_source_window_base::set_is_exec_point_at)
1631         (tui_source_window_base::set_is_exec_point_at)
1632         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1633         (tui_alloc_source_buffer, tui_line_is_displayed)
1634         (tui_addr_is_displayed): Change type of win_info.  Update.
1635         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1636         (tui_source_window_base::do_make_visible_with_new_height):
1637         Update.
1638         * tui/tui-source.c (tui_set_source_content)
1639         (tui_set_source_content_nil)
1640         (tui_source_window::do_scroll_vertical): Update.
1641         * tui/tui-layout.c (show_layout): Update.
1642         * tui/tui-disasm.c (tui_set_disassem_content)
1643         (tui_disasm_window::do_scroll_vertical): Update.
1644         * tui/tui-data.h (tui_win_content): Remove.
1645         (struct tui_gen_win_info) <content, content_size>: Remove.
1646         (struct tui_source_element): Add initializers and destructor.
1647         (union tui_which_element, struct tui_win_element): Remove.
1648         (struct tui_source_window_base) <content>: New field.
1649         (struct tui_data_window): Remove destructor.
1650         (tui_alloc_content, tui_free_win_content)
1651         (tui_free_all_source_wins_content): Don't declare.
1652         * tui/tui-data.c (tui_initialize_static_data): Update.
1653         (init_content_element, tui_alloc_content): Remove.
1654         (~tui_gen_win_info): Update.
1655         (~tui_data_window, tui_free_all_source_wins_content)
1656         (tui_free_win_content, free_content, free_content_elements):
1657         Remove.
1658
1659 2019-06-25  Tom Tromey  <tom@tromey.com>
1660
1661         * tui/tui-winsource.h (tui_clear_source_content)
1662         (tui_erase_source_content, tui_show_source_content): Change type
1663         of win_info.
1664         * tui/tui-winsource.c (tui_clear_source_content)
1665         (tui_erase_source_content, tui_show_source_content): Change type
1666         of win_info.
1667         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1668         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1669         win_info.
1670         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1671         win_info.
1672         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1673
1674 2019-06-25  Tom Tromey  <tom@tromey.com>
1675
1676         * tui/tui-winsource.c (tui_clear_source_content)
1677         (tui_source_window_base::set_is_exec_point_at): Update.
1678         * tui/tui-source.c (tui_set_source_content_nil): Update.
1679         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1680         a bool.
1681         * tui/tui-data.c (init_content_element): Update.
1682
1683 2019-06-25  Tom Tromey  <tom@tromey.com>
1684
1685         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1686         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1687         * tui/tui-layout.c (init_and_make_win): Update.
1688         * tui/tui.h (enum tui_win_type): Update.
1689         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1690         tui_win_is_auxillary.
1691         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1692         tui_win_is_auxillary.
1693
1694 2019-06-25  Tom Tromey  <tom@tromey.com>
1695
1696         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1697         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1698         (tui_delete_data_content_windows, tui_display_all_data)
1699         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1700         Update.
1701         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1702         * tui/tui-regs.c (tui_last_regs_line_no)
1703         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1704         (tui_show_registers): Update.
1705         (tui_show_register_group): Return void.  Update.
1706         (tui_display_registers_from, tui_display_reg_element_at_line)
1707         (tui_display_registers_from_line, tui_check_register_values):
1708         Update.
1709         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1710         member.
1711         (struct tui_data_window) <regs_content>: Now a std::vector.
1712         <regs_content_count>: Remove.
1713         (tui_add_content_elements, tui_free_data_content): Don't declare.
1714         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1715         (init_content_element): Remove DATA_WIN case.  Add assert.
1716         (tui_add_content_elements): Remove.
1717         (tui_data_window): Update.
1718         (tui_free_data_content): Remove.
1719         (free_content_elements): Remove DATA_WIN case.
1720
1721 2019-06-25  Tom Tromey  <tom@tromey.com>
1722
1723         * tui/tui-data.c (tui_data_item_window): Update.
1724         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1725         * tui/tui-windata.c (tui_display_all_data)
1726         (tui_display_data_from_line): Update.
1727         (tui_check_data_values): Remove.
1728         * tui/tui-regs.c (tui_show_register_group)
1729         (tui_display_reg_element_at_line): Update.
1730         * tui/tui-hooks.c (tui_register_changed)
1731         (tui_refresh_frame_and_register_information): Call
1732         tui_check_register_values.
1733         * tui/tui-data.h (struct tui_data_window) <data_content,
1734         data_content_count, data_type>: Remove.
1735         (enum tui_data_type): Remove.
1736
1737         * tui/tui-data.c (tui_data_window::clear_detail)
1738         (~tui_data_window): Update.
1739
1740 2019-06-25  Tom Tromey  <tom@tromey.com>
1741
1742         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1743         declare.
1744         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1745         Rename from tui_first_data_item_displayed.  Update.
1746         (tui_data_window::refresh_all)
1747         (tui_data_window::do_scroll_vertical): Update.
1748         * tui/tui-data.h (struct tui_data_window)
1749         <first_data_item_displayed>: Declare new method.
1750
1751 2019-06-25  Tom Tromey  <tom@tromey.com>
1752
1753         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1754         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1755         contents...
1756         (tui_initialize_static_data): ...here.
1757
1758 2019-06-25  Tom Tromey  <tom@tromey.com>
1759
1760         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1761         (tui_display_registers_from, tui_check_register_values): Update.
1762         (tui_display_register): Remove win_info parameter; update.
1763         (tui_get_register): Change type of parameters.
1764         * tui/tui-data.h (struct tui_data_element): Remove.
1765         (union tui_which_element) <data>: Remove.
1766         <data_window>: Change type.
1767         (struct tui_data_item_window): New.
1768         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1769         case.  Add assert.
1770         (~tui_data_item_window): New destructor.
1771         (free_content_elements): Remove DATA_ITEM_WIN case.
1772
1773 2019-06-25  Tom Tromey  <tom@tromey.com>
1774
1775         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1776         Remove.
1777
1778 2019-06-25  Tom Tromey  <tom@tromey.com>
1779
1780         * tui/tui-data.h (struct tui_command_element): Remove.
1781         (union tui_which_element) <command>: Remove.
1782         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1783         assert.
1784         (free_content_elements): Remove CMD_WIN case.
1785
1786 2019-06-25  Tom Tromey  <tom@tromey.com>
1787
1788         * tui/tui-layout.c (tui_set_layout): Update.
1789         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1790         * tui/tui-data.c (layout_def): Update.
1791
1792 2019-06-25  Tom Tromey  <tom@tromey.com>
1793
1794         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1795         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1796         (tui_source_window_base::set_new_height): Update.
1797         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1798         Update.
1799         (tui_set_locator_fullname, tui_set_locator_info)
1800         (tui_show_frame_info): Update.
1801         * tui/tui-source.c (tui_set_source_content)
1802         (tui_source_is_displayed): Update.
1803         * tui/tui-layout.c (show_source_disasm_command, show_data)
1804         (show_source_or_disasm_and_command): Update.
1805         * tui/tui-disasm.c (tui_set_disassem_content)
1806         (tui_get_begin_asm_address): Update.
1807         * tui/tui-data.h (struct tui_locator_element): Remove.
1808         (union tui_which_element) <locator>: Remove.
1809         (struct tui_locator_window): New.
1810         (tui_locator_win_info_ptr): Change return type.
1811         * tui/tui-data.c (_locator): Change type.
1812         (tui_locator_win_info_ptr): Change return type.
1813         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1814         (tui_alloc_content): Add assert.
1815
1816 2019-06-25  Tom Tromey  <tom@tromey.com>
1817
1818         * tui/tui-winsource.c
1819         (tui_exec_info_window::maybe_allocate_content): New method.
1820         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1821         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1822         (make_source_or_disasm_window): Add cast.
1823         * tui/tui-data.h (union tui_which_element) <simple_string>:
1824         Remove.
1825         (struct tui_source_info): New.
1826         (struct tui_source_window_base) <execution_info>: Change type.
1827         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1828         case, and add assert.
1829         (tui_alloc_content): Add assert.
1830
1831 2019-06-25  Tom Tromey  <tom@tromey.com>
1832
1833         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1834         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1835         * tui/tui-data.c (tui_alloc_win_info): Remove.
1836
1837 2019-06-25  Tom Tromey  <tom@tromey.com>
1838
1839         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1840         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1841         can_highlight.
1842
1843 2019-06-25  Tom Tromey  <tom@tromey.com>
1844
1845         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1846         make_visible_with_new_height method.
1847         (tui_win_info::make_visible_with_new_height): New method.
1848         (tui_source_window_base::do_make_visible_with_new_height)
1849         (tui_data_window::do_make_visible_with_new_height)
1850         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1851         (make_visible_with_new_height): Remove.
1852         (tui_resize_all, tui_adjust_win_heights): Use
1853         make_visible_with_new_height method.
1854         * tui/tui-data.h (struct tui_win_info)
1855         <do_make_visible_with_new_height, make_visible_with_new_height>:
1856         New methods.
1857         (struct tui_source_window_base, struct tui_data_window)
1858         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1859         methods.
1860
1861 2019-06-25  Tom Tromey  <tom@tromey.com>
1862
1863         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1864         method.
1865         (update_tab_width): Call update_tab_width method.
1866         * tui/tui-data.h (struct tui_win_info)
1867         (struct tui_source_window_base) <update_tab_width>: New methods.
1868
1869 2019-06-25  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1872         parameter.
1873         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1874         parameter.
1875         (tui_gen_win_info::make_visible): Update.
1876         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1877         parameter.
1878         * tui/tui-data.h (enum tui_box): New enum.
1879         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1880
1881 2019-06-25  Tom Tromey  <tom@tromey.com>
1882
1883         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1884         init_and_make_win for EXEC_INFO_WIN.
1885         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1886         longer inline.
1887         (struct tui_win_info) <~tui_win_info>: Inline.
1888         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1889         Don't declare.
1890         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1891         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1892         Remove.
1893         (tui_initialize_static_data): Update.
1894         (~tui_gen_win_info): Handle more cleanup here.
1895         (~tui_source_window_base): Delete "execution_info".
1896         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1897
1898 2019-06-25  Tom Tromey  <tom@tromey.com>
1899
1900         * tui/tui-layout.c (make_command_window): Don't set
1901         can_highlight.
1902         (show_source_disasm_command): Call the reset method.
1903         (show_data): Don't set can_highlight.  Call the reset method.
1904         (tui_gen_win_info::reset): Rename from init_gen_win_info
1905         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1906         (show_source_or_disasm_and_command): Call the reset method.
1907         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1908         (struct tui_cmd_window): Set can_highlight.
1909
1910 2019-06-25  Tom Tromey  <tom@tromey.com>
1911
1912         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1913         from make_visible.
1914         (tui_make_visible, tui_make_invisible): Rewrite.
1915         (tui_win_info::make_visible): Remove.
1916         (tui_source_window_base::make_visible): Update.
1917         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1918         method.  Moved from...
1919         (struct tui_win_info) <make_visible>: ...here.
1920
1921 2019-06-25  Tom Tromey  <tom@tromey.com>
1922
1923         * tui/tui-winsource.c
1924         (tui_source_window_base::do_scroll_horizontal): Remove direction
1925         parameter.
1926         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1927         direction parameter.
1928         * tui/tui-win.c (tui_win_info::forward_scroll)
1929         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1930         (tui_win_info::right_scroll): Update.
1931         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1932         direction parameter.
1933         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1934         direction parameter.
1935         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1936         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1937         Remove direction parameter.
1938         (struct tui_source_window_base, struct tui_source_window)
1939         (struct tui_disasm_window, struct tui_data_window)
1940         (struct tui_cmd_window): Update.
1941
1942 2019-06-25  Tom Tromey  <tom@tromey.com>
1943
1944         * tui/tui-winsource.h (tui_set_exec_info_content)
1945         (tui_show_exec_info_content, tui_erase_exec_info_content)
1946         (tui_clear_exec_info_content, tui_update_exec_info): Change
1947         argument to tui_source_window_base.
1948         * tui/tui-winsource.c (tui_set_exec_info_content)
1949         (tui_show_exec_info_content, tui_erase_exec_info_content)
1950         (tui_clear_exec_info_content, tui_update_exec_info): Change
1951         argument to tui_source_window_base.
1952
1953 2019-06-25  Tom Tromey  <tom@tromey.com>
1954
1955         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1956         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1957
1958 2019-06-25  Tom Tromey  <tom@tromey.com>
1959
1960         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1961         check.
1962
1963 2019-06-25  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1966         type to void.
1967         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1968         type to void.
1969         * tui/tui-source.c (tui_set_source_content): Update.
1970         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1971
1972 2019-06-25  Tom Tromey  <tom@tromey.com>
1973
1974         * tui/tui-win.c (window_name_completer, tui_set_focus)
1975         (tui_all_windows_info): Use name method.
1976         * tui/tui-data.h (struct tui_gen_win_info)
1977         (struct tui_source_window, struct tui_disasm_window)
1978         (struct tui_data_window, struct tui_cmd_window) <name>: New
1979         method.
1980         (tui_win_name): Don't declare.
1981         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1982         (tui_win_name): Remove.
1983
1984 2019-06-25  Tom Tromey  <tom@tromey.com>
1985
1986         * tui/tui-winsource.h (tui_update_source_window)
1987         (tui_update_source_window_as_is): Change parameter type.
1988         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1989         to be a tui_source_window_base.
1990         (tui_update_source_window_as_is): Likewise.
1991         * tui/tui-win.c (make_visible_with_new_height): Update.
1992
1993 2019-06-25  Tom Tromey  <tom@tromey.com>
1994
1995         * tui/tui-winsource.c (tui_erase_source_content)
1996         (tui_show_source_content, tui_show_exec_info_content)
1997         (tui_erase_exec_info_content): Use refresh_window method.
1998         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1999         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2000         from tui_refresh_win.
2001         (tui_data_window::refresh_window): New method.
2002         (tui_win_info::refresh, tui_source_window_base::refresh)
2003         (tui_refresh_all): Use refresh_window method.
2004         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2005         method.
2006         * tui/tui-regs.c (tui_display_register): Call refresh_window
2007         method.
2008         * tui/tui-layout.c (show_source_disasm_command)
2009         (show_source_or_disasm_and_command): Call refresh_window method.
2010         * tui/tui-data.h (struct tui_gen_win_info)
2011         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2012         New method.
2013
2014 2019-06-25  Tom Tromey  <tom@tromey.com>
2015
2016         * tui/tui.c (tui_rl_other_window, tui_enable)
2017         (tui_is_window_visible, tui_get_command_dimension): Update.
2018         * tui/tui-winsource.c (tui_update_source_window_as_is)
2019         (tui_clear_source_content, tui_erase_source_content)
2020         (tui_show_source_line, tui_source_window_base::refill)
2021         (tui_source_window_base::do_scroll_horizontal)
2022         (tui_source_window_base::set_is_exec_point_at)
2023         (tui_update_breakpoint_info, tui_set_exec_info_content)
2024         (tui_alloc_source_buffer, tui_line_is_displayed)
2025         (tui_addr_is_displayed): Update.
2026         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2027         (tui_check_and_display_highlight_if_needed)
2028         (tui_win_info::make_visible, tui_win_info::refresh)
2029         (tui_refresh_all): Update.
2030         * tui/tui-windata.c (tui_first_data_item_displayed)
2031         (tui_delete_data_content_windows, tui_erase_data_content)
2032         (tui_display_all_data, tui_data_window::refresh_all)
2033         (tui_check_data_values): Update.
2034         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2035         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2036         (tui_win_info::backward_scroll, tui_refresh_all_win)
2037         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2038         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2039         (tui_source_window_base::set_new_height)
2040         (tui_data_window::set_new_height)
2041         (make_invisible_and_set_new_height)
2042         (make_visible_with_new_height, new_height_ok)
2043         (parse_scrolling_args): Update.
2044         * tui/tui-stack.c (tui_show_frame_info): Update.
2045         * tui/tui-source.c (tui_set_source_content)
2046         (tui_set_source_content_nil, tui_source_is_displayed)
2047         (tui_source_window::do_scroll_vertical): Update.
2048         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2049         (tui_display_registers_from, tui_display_reg_element_at_line)
2050         (tui_check_register_values, tui_reg_command): Update.
2051         * tui/tui-layout.c (tui_default_win_height)
2052         (show_source_disasm_command, show_data, init_and_make_win)
2053         (show_source_or_disasm_and_command): Update.
2054         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2055         (tui_redisplay_readline, tui_mld_flush)
2056         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2057         (tui_getc): Update.
2058         * tui/tui-disasm.c (tui_set_disassem_content)
2059         (tui_disasm_window::do_scroll_vertical): Update.
2060         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2061         Now virtual.
2062         (struct tui_win_info): Derive from tui_gen_win_info.
2063         <~tui_win_info>: Mark as override.
2064         <generic>: Remove member.
2065         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2066         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2067         (~tui_data_window, ~tui_win_info)
2068         (tui_free_all_source_wins_content): Update.
2069         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2070
2071 2019-06-25  Tom Tromey  <tom@tromey.com>
2072
2073         * tui/tui-layout.c (init_and_make_win): Use new.
2074         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2075         destructor, initializers.
2076         (tui_alloc_generic_win_info): Don't declare.
2077         * tui/tui-data.c (_locator): Add argument to constructor.
2078         (source_win, disasm_win): New globals.
2079         (exec_info): Remove.
2080         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2081         Update.
2082         (tui_alloc_generic_win_info): Remove.
2083         (init_content_element): Use new.
2084         (tui_win_info::tui_win_info): Update.
2085         (free_content_elements) <case DATA_WIN>: Use delete.
2086
2087 2019-06-25  Tom Tromey  <tom@tromey.com>
2088
2089         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2090         * tui/tui-windata.c (tui_first_data_item_displayed)
2091         (tui_delete_data_content_windows): Update.
2092         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2093         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2094         (tui_display_registers_from, tui_check_register_values): Update.
2095         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2096         pointer.
2097         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2098         window.
2099         (tui_free_data_content): Update.
2100         (free_content_elements) <case DATA_WIN>: Free the window.
2101
2102 2019-06-25  Tom Tromey  <tom@tromey.com>
2103
2104         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2105         Update.
2106         * tui/tui-layout.c (make_command_window)
2107         (show_source_disasm_command, show_data, init_and_make_win)
2108         (show_source_or_disasm_and_command): Update.
2109         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2110         method.
2111         <can_highight, is_highlighted>: Now bool.
2112         (tui_set_win_highlight): Don't declare.
2113         * tui/tui-data.c (tui_set_win_highlight): Remove.
2114
2115 2019-06-25  Tom Tromey  <tom@tromey.com>
2116
2117         * tui/tui-wingeneral.c (make_visible): Remove check of window
2118         type.
2119
2120 2019-06-25  Tom Tromey  <tom@tromey.com>
2121
2122         * tui/tui-win.c (tui_win_info::max_height)
2123         (tui_cmd_window::max_height): New methods.
2124         (new_height_ok): Call max_height.
2125         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2126         <max_height>: New method.
2127
2128 2019-06-25  Tom Tromey  <tom@tromey.com>
2129
2130         * tui/tui-win.c (tui_source_window_base::set_new_height)
2131         (tui_data_window::set_new_height): New methods.
2132         (make_invisible_and_set_new_height): Call set_new_height method.
2133         * tui/tui-data.h (struct tui_win_info)
2134         (struct tui_source_window_base, struct tui_data_window)
2135         <set_new_height>: New method.
2136
2137 2019-06-25  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2140         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2141         tui_refresh_data_win.
2142         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2143         method.
2144         (tui_refresh_all_win): Call the refresh_all method.
2145         (tui_set_focus): Likewise.
2146         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2147         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2148         Likewise.
2149
2150 2019-06-25  Tom Tromey  <tom@tromey.com>
2151
2152         * tui/tui-winsource.h (tui_refill_source_window)
2153         (tui_set_is_exec_point_at): Don't declare.
2154         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2155         (tui_source_window_base::refill): Rename from
2156         tui_refill_source_window.
2157         (tui_source_window_base::do_scroll_horizontal): Update.
2158         (tui_source_window_base::set_is_exec_point_at): Rename from
2159         tui_set_is_exec_point_at.
2160         (tui_update_all_breakpoint_info): Update.
2161         * tui/tui-stack.c (tui_show_frame_info): Update.
2162         * tui/tui-layout.c (show_data): Add cast.
2163         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2164         * tui/tui-data.h (struct tui_source_window_base) <refill,
2165         set_is_exec_point_at>: New methods.
2166         (tui_source_windows, tui_add_to_source_windows): Update types.
2167         (tui_add_to_source_windows): Remove redundant declaration.
2168         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2169         (tui_source_windows): Change return type.
2170         (tui_clear_source_windows_detail): Update.
2171         (tui_add_to_source_windows): Change type of parameter.
2172         (tui_free_all_source_wins_content): Update.
2173
2174 2019-06-25  Tom Tromey  <tom@tromey.com>
2175
2176         * tui/tui-wingeneral.c (tui_win_info::refresh)
2177         (tui_source_window_base::refresh): New methods.
2178         (tui_refresh_all): Call the refresh method.
2179         * tui/tui-data.h (struct tui_win_info)
2180         (struct tui_source_window_base) <refresh>: New method.
2181
2182 2019-06-25  Tom Tromey  <tom@tromey.com>
2183
2184         * tui/tui.h (tui_is_window_visible): Return bool.
2185         * tui/tui.c (tui_is_window_visible): Return bool.
2186         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2187         (tui_make_visible, tui_make_invisible)
2188         (tui_win_info::make_visible)
2189         (tui_source_window_base::make_visible, make_all_visible)
2190         (tui_make_all_visible, tui_make_all_invisible): Update.
2191         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2192         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2193         bool.
2194         (struct tui_win_info, struct tui_source_window_base)
2195         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2196         * tui/tui-data.c (tui_init_generic_part): Update.
2197
2198 2019-06-25  Tom Tromey  <tom@tromey.com>
2199
2200         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2201         (tui_source_window_base::make_visible): New methods.
2202         (make_all_visible): Make method call.
2203         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2204         (struct tui_source_window_base, struct tui_cmd_window): Override
2205         make_visible.
2206         (tui_win_is_source_type): Don't declare.
2207         * tui/tui-data.c (tui_win_is_source_type): Remove.
2208
2209 2019-06-25  Tom Tromey  <tom@tromey.com>
2210
2211         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2212         NULL check.
2213
2214 2019-06-25  Tom Tromey  <tom@tromey.com>
2215
2216         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2217         Inline constructor.  Add initializers for members.
2218         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2219         constructors; now inline in class.
2220
2221 2019-06-25  Tom Tromey  <tom@tromey.com>
2222
2223         * tui/tui-regs.c (tui_show_registers): Update.
2224         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2225         bool.
2226         * tui/tui-data.c (tui_data_window::clear_detail)
2227         (tui_data_window): Update.
2228
2229 2019-06-25  Tom Tromey  <tom@tromey.com>
2230
2231         * tui/tui-windata.c (tui_display_all_data)
2232         (tui_display_data_from_line, tui_display_data_from)
2233         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2234         Update.
2235         * tui/tui-regs.c (tui_last_regs_line_no)
2236         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2237         (tui_show_registers, tui_show_register_group)
2238         (tui_display_registers_from, tui_display_reg_element_at_line)
2239         (tui_display_registers_from_line, tui_check_register_values)
2240         (tui_reg_next, tui_reg_prev): Update.
2241         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2242         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2243         tui_data_window.
2244         (struct tui_win_info) <detail>: Remove.  Add new fields from
2245         tui_data_info.
2246         (TUI_DATA_WIN): Add cast.
2247         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2248         (~tui_data_window): Simplify.
2249
2250 2019-06-25  Tom Tromey  <tom@tromey.com>
2251
2252         * tui/tui-layout.c (show_source_disasm_command)
2253         (show_source_or_disasm_and_command): Update.
2254         * tui/tui-io.c (update_cmdwin_start_line)
2255         (tui_redisplay_readline): Update.
2256         * tui/tui-data.h (struct tui_command_info): Remove.
2257         (struct tui_win_info) <detail>: Remove command_info member.
2258         (struct tui_data_window) <start_line>: New member, from
2259         tui_command_info.
2260         (TUI_CMD_WIN): Add casts.
2261
2262 2019-06-25  Tom Tromey  <tom@tromey.com>
2263
2264         * tui/tui-winsource.c (tui_update_source_window)
2265         (tui_refill_source_window)
2266         (tui_source_window_base::do_scroll_horizontal)
2267         (tui_update_breakpoint_info, tui_set_exec_info_content)
2268         (tui_show_exec_info_content, tui_erase_exec_info_content)
2269         (tui_clear_exec_info_content): Update.
2270         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2271         Update.
2272         * tui/tui-win.c (make_invisible_and_set_new_height)
2273         (make_visible_with_new_height): Update.
2274         * tui/tui-source.c (tui_set_source_content)
2275         (tui_show_symtab_source): Update.
2276         * tui/tui-layout.c (extract_display_start_addr)
2277         (show_source_disasm_command, show_data)
2278         (make_source_or_disasm_window)
2279         (show_source_or_disasm_and_command): Update.
2280         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2281         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2282         "gdbarch".
2283         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2284         to tui_source_window_base.
2285         (struct tui_win_info) <detail>: Remove source_info member.
2286         (struct tui_source_window_base) <has_locator>: Inline.
2287         Move contents from tui_source_info; rename has_locator member to
2288         m_has_locator.
2289         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2290         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2291         header file.
2292         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2293         Simplify.
2294         (tui_free_all_source_wins_content): Cast to
2295         tui_source_window_base.
2296
2297 2019-06-25  Tom Tromey  <tom@tromey.com>
2298
2299         * tui/tui-win.c (make_invisible_and_set_new_height)
2300         (make_visible_with_new_height): Call has_locator method.
2301         * tui/tui-layout.c (show_source_disasm_command, show_data)
2302         (show_source_or_disasm_and_command): Update for bool change.
2303         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2304         (tui_win_info) <has_locator>: New method.
2305         (struct tui_source_window_base) <has_locator>: New method.
2306         (tui_win_has_locator): Don't declare.
2307         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2308         from tui_win_has_locator.
2309         (tui_source_window_base): Use false, not FALSE.
2310
2311 2019-06-25  Tom Tromey  <tom@tromey.com>
2312
2313         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2314         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2315         clear_detail method directly.
2316         (tui_clear_win_detail): Remove.
2317
2318 2019-06-25  Tom Tromey  <tom@tromey.com>
2319
2320         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2321         "this", not TUI_DISASM_WIN.
2322
2323 2019-06-25  Tom Tromey  <tom@tromey.com>
2324
2325         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2326         declare.
2327         * tui/tui-winsource.c
2328         (tui_source_window_base::do_scroll_horizontal): Rename from
2329         tui_horizontal_source_scroll.
2330         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2331         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2332         from tui_vertical_data_scroll.
2333         * tui/tui-win.h (tui_scroll): Don't declare.
2334         * tui/tui-win.c (tui_win_info::forward_scroll)
2335         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2336         (tui_win_info::right_scroll): Rename and update.
2337         (tui_scroll_forward_command, tui_scroll_backward_command)
2338         (tui_scroll_left_command, tui_scroll_right_command): Update.
2339         (tui_scroll): Remove.
2340         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2341         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2342         from tui_vertical_source_scroll.
2343         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2344         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2345         from tui_vertical_disassem_scroll.
2346         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2347         do_scroll_horizontal>: New methods.
2348         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2349         Likewise.
2350         (struct tui_source_window_base): Add do_scroll_horizontal.
2351         (struct tui_source_window, struct tui_disasm_window): Add
2352         do_scroll_vertical.
2353         (struct tui_data_window, struct tui_cmd_window): Add
2354         do_scroll_horizontal and do_scroll_vertical.
2355         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2356
2357 2019-06-25  Tom Tromey  <tom@tromey.com>
2358
2359         * tui/tui-data.h (struct tui_source_window_base): New struct.
2360         (struct tui_source_window): Derive from tui_source_window_base.
2361         (struct tui_disasm_window): New struct.
2362         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2363         from tui_source_window::clear_detail.
2364         (tui_source_window_base): Rename from tui_source_window.
2365         (~tui_source_window_base): Rename from ~tui_source_window.
2366         (tui_alloc_win_info): Create a tui_disasm_window.
2367
2368 2019-06-25  Tom Tromey  <tom@tromey.com>
2369
2370         * tui/tui-data.h (struct tui_source_window)
2371         (struct tui_data_window): Declare destructors.
2372         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2373         destructors.
2374         (tui_win_info): Simplify.
2375
2376 2019-06-25  Tom Tromey  <tom@tromey.com>
2377
2378         * tui/tui-winsource.c (tui_display_main)
2379         (tui_update_source_windows_with_addr)
2380         (tui_update_all_breakpoint_info): Update.
2381         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2382         (new_height_ok, parse_scrolling_args): Update.
2383         * tui/tui-stack.c (tui_show_frame_info): Update.
2384         * tui/tui-data.h (struct tui_list): Remove.
2385         (tui_source_windows): Return a reference to a std::vector.
2386         * tui/tui-data.c (source_windows): Now a std::vector.
2387         (tui_source_windows): Change return type.
2388         (tui_clear_source_windows): Rewrite.
2389         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2390         (tui_free_all_source_wins_content): Rewrite.
2391
2392 2019-06-25  Tom Tromey  <tom@tromey.com>
2393
2394         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2395         (struct tui_data_window, struct tui_cmd_window): Declare
2396         clear_detail method.
2397         * tui/tui-data.c (tui_source_window::clear_detail)
2398         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2399         methods.
2400         (tui_clear_win_detail): Simplify.
2401
2402 2019-06-25  Tom Tromey  <tom@tromey.com>
2403
2404         * tui/tui-layout.c (make_source_window, make_disasm_window)
2405         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2406         Return the new window.
2407         (show_source_disasm_command, show_data)
2408         (show_source_or_disasm_and_command): Update.
2409
2410 2019-06-25  Tom Tromey  <tom@tromey.com>
2411
2412         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2413         parameter.  Return the new window.
2414         (show_source_disasm_command): Update and remove NULL check.
2415         (show_source_or_disasm_and_command): Update.
2416
2417 2019-06-25  Tom Tromey  <tom@tromey.com>
2418
2419         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2420
2421 2019-06-25  Tom Tromey  <tom@tromey.com>
2422
2423         * tui/tui-data.h (struct tui_win_info): Make constructor
2424         protected.  Make destructor virtual.  Add initializers.
2425         (tui_source_window, tui_data_window, tui_cmd_window): New
2426         classes.
2427         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2428         constructor.  Add "type" parameter.
2429         (tui_source_window, tui_data_window, tui_cmd_window): New
2430         constructors.
2431         (tui_alloc_win_info): Instantiate the appropriate subclass.
2432
2433 2019-06-25  Tom Tromey  <tom@tromey.com>
2434
2435         * tui/tui-win.c (tui_resize_all): Use delete.
2436         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2437         destructor.
2438         (tui_free_window): Don't declare.
2439         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2440         Update.
2441
2442 2019-06-25  Tom Tromey  <tom@tromey.com>
2443
2444         * tui/tui-data.h (struct tui_win_info): Add constructor.
2445         * tui/tui-data.c (tui_alloc_win_info): Use new.
2446         (tui_free_window): Use delete.
2447
2448 2019-06-22  Tom Tromey  <tom@tromey.com>
2449
2450         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2451         declare.
2452         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2453
2454 2019-06-22  Tom Tromey  <tom@tromey.com>
2455
2456         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2457         declare.
2458         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2459
2460 2019-06-22  Tom de Vries  <tdevries@suse.de>
2461
2462         * dwarf2read.c (create_addrmap_from_aranges)
2463         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2464         instead of '%zu'.
2465
2466 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2467
2468         * dwarf2read.h (dwarf2_section_info_def): Remove.
2469         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2470         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2471         std::vector<dwarf2_section_info>.
2472         (struct dwo_file) <~dwo_file>: Remove.
2473         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2474         types field.
2475         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2476         (dwarf2_read_debug_names): Likewise.
2477         (create_debug_types_hash_table): Change parameter type to
2478         array_view, adjust code accordingly.
2479         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2480         (partial_die_info::fixup): Likewise.
2481         (determine_prefix): Likewise.
2482         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2483
2484 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2485
2486         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2487         gdb_bfd_ref_ptr.
2488         <~dwo_file>: Remove call to gdb_bfd_unref.
2489         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2490         gdb_bfd_ref_ptr::get.
2491
2492 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2493
2494         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2495         type to htab_up.
2496         * dwarf2read.c (struct dwo_file): Initialize fields.
2497         <~dwo_file>: New.
2498         (free_dwo_file): Remove, move content to ~dwo_file.
2499         (struct dwo_file_deleter): Remove.
2500         (dwo_file_up>: Remove custom deleter.
2501         (free_dwo_files): Remove.
2502         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2503         dwo_files.
2504         (process_skeletonless_type_units): Call unique_ptr::get.
2505         (allocate_dwo_file_hash_table): Add deleter to created hash
2506         table.  Change return type to htab_up.
2507         (lookup_dwo_file_slot): Don't memset dwo_file, call
2508         unique_ptr::get.
2509         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2510         (create_dwo_unit_in_dwp_v2): Likewise.
2511         (open_and_init_dwo_file): Likewise.
2512         (free_dwo_file_from_slot): Remove.
2513
2514 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2515
2516         * dwarf2read.h (struct dwarf2_section_info) <readin,
2517         is_virtual>: Change type to bool.
2518         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2519         true instead of 1.
2520
2521 2019-06-19  Tom Tromey  <tom@tromey.com>
2522
2523         * tui/tui-data.h (tui_init_content_element): Don't declare.
2524
2525 2019-06-19  Tom Tromey  <tom@tromey.com>
2526
2527         * tui/tui-data.h (tui_init_win_info): Don't declare.
2528
2529 2019-06-19  Tom de Vries  <tdevries@suse.de>
2530
2531         * dwarf2read.h (abstract_to_concrete): Change type to
2532         std::unordered_map<sect_offset, std::vector<sect_offset>,
2533         gdb::hash_enum<sect_offset>>.
2534
2535 2019-06-19  Tom Tromey  <tromey@adacore.com>
2536
2537         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2538         EVAL_AVOID_SIDE_EFFECTS specially.
2539
2540 2019-06-19  Tom Tromey  <tromey@adacore.com>
2541
2542         * source-cache.c (highlighter): New global.
2543         (source_cache::get_source_lines): Create a highlighter on demand.
2544
2545 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2546
2547         * defs.h (deprecated_interactive_hook): Delete declaration.
2548         * interps.c (clear_interpreter_hooks): Remove use of
2549         deprecated_interactive_hook.
2550         * top.c (deprecated_interactive_hook): Delete definition.
2551         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2552
2553 2019-06-18  Tom de Vries  <tdevries@suse.de>
2554
2555         PR gdb/24515
2556         * dwarf2read.h (abstract_to_concrete): Change type from
2557         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2558         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2559         * dwarf2read.c (read_variable): Update.
2560         (dwarf2_fetch_die_loc_sect_off): Update.
2561
2562 2019-06-17  Tom de Vries  <tdevries@suse.de>
2563
2564         PR gdb/24617
2565         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2566         accessing parent[parent_len - 1].
2567
2568 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2569
2570         PR gdb/24364
2571         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2572         call dtrace_process_dof with NULL dof.
2573
2574 2019-06-16  Tom de Vries  <tdevries@suse.de>
2575
2576         PR gdb/24445
2577         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2578
2579 2019-06-16  Tom Tromey  <tom@tromey.com>
2580
2581         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2582         (make_all_visible): Use address of member.
2583
2584 2019-06-16  Tom Tromey  <tom@tromey.com>
2585
2586         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2587         (tui_free_window, free_content, free_content_elements): Remove
2588         unnecessary cast.
2589         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2590         cast.
2591         * tui/tui-regs.c (tui_show_register_group)
2592         (tui_display_registers_from, tui_display_reg_element_at_line):
2593         Remove unnecessary cast.
2594
2595 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2596
2597         * linux-nat.c (normal_mask): Delete.
2598         (_initialize_linux_nat): Don't initialise normal_mask.
2599
2600 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2601
2602         PR gdb/24445
2603         * dwarf-index-write.h (write_psymtabs_to_index): Add
2604         dwz_basename parameter.
2605         * dwarf-index-write.c (write_gdbindex): Move file writing to
2606         write_gdbindex_1.  Change return type void.
2607         (assert_file_size): Move up, remove filename parameter.
2608         (write_gdbindex_1): New function.
2609         (write_debug_names): Change return type to void, call
2610         assert_file_size.
2611         (struct index_wip_file): New struct.
2612         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2613         file logic to index_wip_file.  Write index for dwz file if
2614         needed.
2615         (save_gdb_index_command): Pass basename of dwz file, if present.
2616         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2617         build-id of dwz file, if present.
2618         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2619         (dwarf2_get_dwz_file): Likewise.
2620         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2621         (dwarf2_get_dwz_file): Likewise.
2622
2623 2019-06-16  Tom Tromey  <tom@tromey.com>
2624
2625         * coffread.c (process_coff_symbol): Use xstrdup.
2626         * value.c (create_internalvar): Use xstrdup.
2627
2628 2019-06-16  Tom Tromey  <tom@tromey.com>
2629
2630         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2631         * breakpoint.c (stopin_command, stopat_command)
2632         (until_break_command, decode_location_default): Remove unnecessary
2633         cast.
2634         * utils.c (subset_compare): Remove unnecessary cast.
2635         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2636         cast.
2637         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2638         cast.
2639         * infcmd.c (path_command): Remove unnecessary cast.
2640         * coffread.c (decode_type): Remove unnecessary cast.
2641         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2642         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2643         * tui/tui-stack.c (tui_show_locator_content)
2644         (tui_show_frame_info): Remove unnecessary cast.
2645         * tui/tui-win.c (tui_scroll_forward_command)
2646         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2647         (parse_scrolling_args): Remove unnecessary cast.
2648         * tui/tui-data.c (init_win_info, tui_del_window)
2649         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2650         (free_content_elements): Remove unnecessary cast.
2651         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2652         unnecessary cast.
2653         * tui/tui-source.c (tui_set_source_content)
2654         (tui_vertical_source_scroll): Remove unnecessary cast.
2655         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2656         cast.
2657         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2658         * tui/tui-regs.c (tui_display_registers_from)
2659         (tui_display_register): Remove unnecessary cast.
2660         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2661         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2662         (make_visible): Remove unnecessary cast.
2663         * tui/tui-winsource.c (tui_erase_source_content)
2664         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2665         unnecessary cast.
2666         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2667         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2668         * stabsread.c (read_type, read_array_type, read_range_type):
2669         Remove unnecessary cast.
2670         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2671         (parse_symbol, parse_type, upgrade_type, parse_external)
2672         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2673         unnecessary cast.
2674         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2675
2676 2019-06-16  Tom Tromey  <tom@tromey.com>
2677
2678         * tui/tui-data.c (tui_alloc_generic_win_info)
2679         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2680         checks.
2681
2682 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2683             Andrew Burgess  <andrew.burgess@embecosm.com>
2684
2685         * f-typeprint.c (f_print_type): Don't return early for not
2686         associated or not allocated types.
2687         (f_type_print_varspec_suffix): Add print_rank parameter and print
2688         ranks of array types in case they dangling.
2689         (f_type_print_base): Add print_rank parameter.
2690
2691 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2692
2693         * NEWS: Mention new MI commands.
2694         * break-catch-throw.c (enum exception_event_kind): Move to
2695         breakpoint.h.
2696         (print_mention_exception_catchpoint): Output text as a single
2697         message.
2698         (catch_exception_command_1): Rename to...
2699         (catch_exception_event): ...this, make non-static, update header
2700         command, and change some parameter types.
2701         (catch_catch_command): Update for changes to
2702         catch_exception_command_1.
2703         (catch_throw_command): Likewise.
2704         (catch_rethrow_command): Likewise.
2705         * breakpoint.c (enum exception_event_kind): Delete.
2706         * breakpoint.h (enum exception_event_kind): Moved here from
2707         break-catch-throw.c.
2708         (catch_exception_event): Declare.
2709         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2710         (mi_cmd_catch_throw): New function.
2711         (mi_cmd_catch_rethrow): New function.
2712         (mi_cmd_catch_catch): New function.
2713         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2714         'catch-catch' entries.
2715         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2716         (mi_cmd_catch_rethrow): Declare.
2717         (mi_cmd_catch_catch): Declare.
2718
2719 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2720
2721         * annotate.c (annotate_source_line): Change return type to void,
2722         update implementation to match.
2723         * annotate.h (annotate_source_line): Change return type to void,
2724         update header comment.
2725         * stack.c (print_frame_info): Don't change what frame information
2726         is printed based on whether annotations are on or not.
2727
2728 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2729
2730         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2731         (annotate_source): Make static.
2732         (annotate_source_line): Moved from source.c and renamed from
2733         identify_source_line.  Update the return type.
2734         * annotate.h (annotate_source): Delete declaration.
2735         (annotate_source_line): Declaration moved from source.h, and
2736         renamed from identify_source_line.  Return type updated.
2737         * source.c (identify_source_line): Moved to annotate.c and renamed
2738         to annotate_source_line.
2739         (info_line_command): Remove check of annotation_level.
2740         * source.h (identify_source_line): Move declaration to annotate.h
2741         and rename to annotate_source_line.
2742         * stack.c: Add 'annotate.h' include.
2743         (print_frame_info): Remove check of annotation_level before
2744         calling annotate_source_line.
2745
2746 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2747
2748         * source-cache.c (source_cache::get_plain_source_lines): Use
2749         open_source_file_with_line_charpos instead of just
2750         open_source_file, remove call to find_source_lines.
2751         (source_cache::get_source_lines): Likewise.
2752         * source.c (find_source_lines): Make static.
2753         (get_filename_and_charpos): Renamed into...
2754         (open_source_file_with_line_charpos): ..this along with changes to
2755         return a scoped_fd, and some other minor clean ups.
2756         (identify_source_line): Use open_source_file_with_line_charpos.
2757         (search_command_helper): Use open_source_file_with_line_charpos
2758         instead of just open_source_file, remove call to
2759         find_source_lines.
2760         * source.h (open_source_file_with_line_charpos): Declare new
2761         function.
2762         (find_source_lines): Delete declaration.
2763
2764 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2765
2766         * source.c (get_filename_and_charpos): Remove fullname
2767         parameter.
2768         (identify_source_line): Update call to get_filename_and_charpos.
2769
2770 2019-06-14  Tom Tromey  <tromey@adacore.com>
2771
2772         PR gdb/24502:
2773         * ui-style.h (skip_ansi_escape): Update comment.
2774         * ui-file.h (class no_terminal_escape_file): New class.
2775         * ui-file.c (no_terminal_escape_file::write)
2776         (no_terminal_escape_file::puts): New methods.
2777         * cli/cli-logging.c (handle_redirections): Use
2778         no_terminal_escape_file.
2779
2780 2019-06-14  Tom Tromey  <tromey@adacore.com>
2781
2782         * NEWS: Move convenience variable news above Python news.
2783
2784 2019-06-14  Tom Tromey  <tom@tromey.com>
2785
2786         * gnulib: Move directory to top-level.
2787         * configure.ac: Don't configure gnulib.
2788         * configure: Rebuild.
2789         * common/common-defs.h: Use new path to gnulib.
2790         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2791         (GNULIB_H): Remove.
2792         (INCGNU): Look in new gnulib location.
2793         (HFILES_NO_SRCDIR): Remove gnulib files.
2794         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2795         (generated_files): Remove GNULIB_H.
2796         ($(LIBGNU), all-lib): Remove targets.
2797         (distclean): Don't mention GNULIB_BUILDDIR.
2798         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2799
2800 2019-06-14  Tom Tromey  <tromey@adacore.com>
2801
2802         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2803         Warn if symbol file does not provide any symbols.
2804
2805 2019-06-14  Tom Tromey  <tromey@adacore.com>
2806
2807         * source.c (find_and_open_source): Respect basenames_may_differ.
2808
2809 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2810
2811         * annotate.c (annotate_breakpoints_invalid): Make use of
2812         scoped_restore_terminal_state.
2813         (annotate_frames_invalid): Likewise.
2814
2815 2019-06-14  Tom Tromey  <tromey@adacore.com>
2816
2817         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2818         allow assignment to an internalvar.
2819
2820 2019-06-14  Tom Tromey  <tromey@adacore.com>
2821
2822         * ada-lex.l: Allow "_" in attribute names.
2823
2824 2019-06-14  Tom Tromey  <tromey@adacore.com>
2825
2826         PR gdb/24653:
2827         * regcache.c (registers_changed): Don't call alloca.
2828         * top.c (execute_command): Don't call alloca.
2829
2830 2019-06-13  Pedro Alves  <palves@redhat.com>
2831
2832         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2833         'expression'.  When parsing an expression, error out if there's
2834         junk after "unlimited".
2835         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2836         (do_set_command): Adjust calls to is_unlimited_literal.
2837
2838 2019-06-13  Pedro Alves  <palves@redhat.com>
2839
2840         * compile/compile.c (make_compile_options_def_group): Add braces
2841         around array_view initializer.
2842         * thread.c (make_thread_apply_all_options_def_group)
2843         (make_thread_apply_all_options_def_group): Likewise.
2844
2845 2019-06-13  Pedro Alves  <palves@redhat.com>
2846
2847         * NEWS (New commands): Mention "maint test-options
2848         require-delimiter", "maint test-options unknown-is-error", "maint
2849         test-options unknown-is-operand" and "maint show
2850         test-options-completion-result".
2851         (New command options, command completion): New section.
2852         (Completion improvements): New section.
2853         Mention that you can abbreviate "unlimited".
2854
2855 2019-06-13  Pedro Alves  <palves@redhat.com>
2856
2857         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2858         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2859         * unittests/cli-utils-selftests.c (test_parse_flags)
2860         (test_parse_flags_qcs): Delete.
2861         (test_cli_utils): Don't call deleted functions.
2862
2863 2019-06-13  Pedro Alves  <palves@redhat.com>
2864
2865         * thread.c: Include "cli/cli-option.h".
2866         (tp_array_compar_ascending): Global.
2867         (tp_array_compar): Delete function.
2868         (tp_array_compar_ascending, tp_array_compar_descending): New
2869         functions.
2870         (ascending_option_def, qcs_flag_option_def)
2871         (thr_qcs_flags_option_defs)
2872         (make_thread_apply_all_options_def_group)
2873         (make_thread_apply_options_def_group): New.
2874         (thread_apply_all_command): Use gdb::option::process_options.
2875         (thread_apply_command_completer)
2876         (thread_apply_all_command_completer): New.
2877         (thread_apply_command): Use gdb::option::process_options.
2878         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2879         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2880         to generate help text of "thread apply".  Adjust "taas"'s help.
2881         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2882         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2883
2884 2019-06-13  Pedro Alves  <palves@redhat.com>
2885
2886         * thread.c (thread_apply_command): Check for invalid TID with
2887         isdigit instead of !isalpha.
2888
2889 2019-06-13  Pedro Alves  <palves@redhat.com>
2890
2891         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2892         (validate_flags_qcs): New.
2893         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2894         (validate_flags_qcs): Declare.
2895         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2896         (make_frame_apply_options_def_group): New.
2897         (frame_apply_command_count): Process options with
2898         gdb::option::process_options.
2899         (frame_apply_completer): New.
2900         (frame_apply_level_completer, frame_apply_all_completer)
2901         (frame_apply_completer): New.
2902         (_initialize_stack): Update help of "frame apply", "frame apply
2903         level", "frame apply all" and "faas" to mention supported options
2904         and install command completers.
2905         * stack.h (frame_apply_all_completer): Declare.
2906         * thread.c: Include "stack.h".
2907         (tfaas_command): Add "--".
2908         (_initialize_thread): Update help "tfaas" to mention supported
2909         options and install command completer.
2910
2911 2019-06-13  Pedro Alves  <palves@redhat.com>
2912
2913         * completer.c (complete_nested_command_line): New.
2914         (gdb_completion_word_break_characters_throw): Add assertion.
2915         * completer.h (complete_nested_command_line): Declare.
2916
2917 2019-06-13  Pedro Alves  <palves@redhat.com>
2918
2919         * stack.c (parse_backtrace_qualifiers): New.
2920         (backtrace_command): Use it.
2921         (backtrace_command_completer): Complete on qualifiers.
2922
2923 2019-06-13  Pedro Alves  <palves@redhat.com>
2924
2925         * frame.c: Include "cli/cli-option.h.
2926         (user_set_backtrace_options): New.
2927         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2928         Delete.
2929         (get_prev_frame): Adjust.
2930         (boolean_option_def, uinteger_option_def)
2931         (set_backtrace_option_defs): New.
2932         (_initialize_frame): Adjust and use
2933         gdb::option::add_setshow_cmds_for_options to install "set
2934         backtrace past-main" and "set backtrace past-entry".
2935         * frame.h: Include "cli/cli-option.h".
2936         (struct frame_print_options): Forward declare.
2937         (print_frame_arguments_all, print_frame_arguments_scalars)
2938         (print_frame_arguments_none): Declare.
2939         (print_entry_values): Delete declaration.
2940         (struct frame_print_options, user_frame_print_options): New.
2941         (struct set_backtrace_options): New.
2942         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2943         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2944         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2945         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2946         (list_args_or_locals): Add frame_print_options parameter.
2947         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2948         * python/py-framefilter.c (enumerate_args): Pass down
2949         USER_FRAME_PRINT_OPTIONS.
2950         * stack.c: Include "cli/cli-option.h".
2951         (print_frame_arguments_all, print_frame_arguments_scalars)
2952         (print_frame_arguments_none): Declare.
2953         (print_raw_frame_arguments, print_entry_values): Delete.
2954         (user_frame_print_options): New.
2955         (boolean_option_def, enum_option_def, frame_print_option_defs):
2956         New.
2957         (struct backtrace_cmd_options): New.
2958         (bt_flag_option_def): New.
2959         (backtrace_command_option_defs): New.
2960         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2961         (print_frame_arg, read_frame_arg, print_frame_args)
2962         (print_frame_info, print_frame): Add frame_print_options parameter
2963         and use it.
2964         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2965         (backtrace_command_1): Add frame_print_options and
2966         backtrace_cmd_options parameters and use them.
2967         (make_backtrace_options_def_group): New.
2968         (backtrace_command): Process command options with
2969         gdb::option::process_options.
2970         (backtrace_command_completer): New.
2971         (_initialize_stack): Extend "backtrace"'s help to mention
2972         supported options.  Install completer for "backtrace".
2973         Install some settings commands with add_setshow_cmds_for_options.
2974
2975 2019-06-13  Pedro Alves  <palves@redhat.com>
2976
2977         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2978         and that "set/show print raw frame-arguments" are now deprecated.
2979
2980         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2981         command.
2982         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2983         * stack.c (_initialize_stack): Install "set/show print
2984         raw-frame-arguments", and deprecate "set/show print raw
2985         frame-arguments".
2986         * valprint.c (_initialize_valprint): Deprecate "set/show print
2987         raw".
2988
2989 2019-06-13  Pedro Alves  <palves@redhat.com>
2990
2991         * compile/compile.c (struct compile_options): New.
2992         (compile_flag_option_def, compile_command_option_defs)
2993         (make_compile_options_def_group): New.
2994         (compile_file_command): Handle options with
2995         gdb::option::process_options.
2996         (compile_file_command_completer): New function.
2997         (compile_code_command): Handle options with
2998         gdb::option::process_options.
2999         (compile_code_command_completer): New function.
3000         (_initialize_compiler): Install completers for "compile code" and
3001         "compile file".  Mention available options in "compile code" and
3002         "compile code"'s help.
3003         * completer.c (advance_to_completion_word): New, factored out from
3004         ...
3005         (advance_to_expression_complete_word_point): ... this.
3006         (advance_to_filename_complete_word_point): New.
3007         * completer.h (advance_to_filename_complete_word_point): New
3008         declaration.
3009
3010 2019-06-13  Pedro Alves  <palves@redhat.com>
3011
3012         * compile/compile.c: Include "cli/cli-option.h".
3013         (compile_print_value): Scope data pointer is now a
3014         value_print_options pointer; adjust.
3015         (compile_print_command): Process options.  Scope data pointer is
3016         now a value_print_options pointer; adjust.
3017         (_initialize_compile): Update "compile print"'s help to include
3018         supported options.  Install a completer for "compile print".
3019         * cp-valprint.c (show_vtblprint, show_objectprint)
3020         (show_static_field_print): Delete.
3021         (_initialize_cp_valprint): Don't install "set print
3022         static-members", "set print vtbl", "set print object" here.
3023         * printcmd.c: Include "cli/cli-option.h" and
3024         "common/gdb_optional.h".
3025         (print_command_parse_format): Rework to fill in a
3026         value_print_options instead of a format_data.
3027         (print_value): Change parameter type from format_data pointer to
3028         value_print_options reference.  Adjust.
3029         (print_command_1): Process options.  Adjust to pass down a
3030         value_print_options.
3031         (print_command_completer): New.
3032         (_initialize_printcmd): Install print_command_completer as
3033         handle_brkchars completer for the "print" command.  Update
3034         "print"'s help to include supported options.
3035         * valprint.c: Include "cli/cli-option.h".
3036         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3037         here from cp-valprint.c.
3038         (boolean_option_def, uinteger_option_def)
3039         (value_print_option_defs, make_value_print_options_def_group):
3040         New.  Use gdb::option::add_setshow_cmds_for_options to install
3041         "set print elements", "set print null-stop", "set print repeats",
3042         "set print pretty", "set print union", "set print array", "set
3043         print address", "set print symbol", "set print array-indexes".
3044         * valprint.h: Include <string> and "cli/cli-option.h".
3045         (make_value_print_options_def_group): Declare.
3046         (print_value): Change parameter type from format_data pointer to
3047         value_print_options reference.
3048         (print_command_completer): Declare.
3049
3050 2019-06-13  Pedro Alves  <palves@redhat.com>
3051
3052         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3053         (COMMON_SFILES): Add maint-test-settings.c.
3054         * cli/cli-decode.c (boolean_enums): New global, factored out from
3055         ...
3056         (add_setshow_boolean_cmd): ... here.
3057         * cli/cli-decode.h (boolean_enums): Declare.
3058         * cli/cli-option.c: New file.
3059         * cli/cli-option.h: New file.
3060         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3061         factored out from ...
3062         (parse_cli_boolean_value(const char *)): ... this.
3063         (is_unlimited_literal): Change parameter type to pointer to
3064         pointer.  Adjust and advance ARG pointer.
3065         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3066         (parse_cli_var_enum): New, factored out from ...
3067         (do_set_command): ... this.  Adjust.
3068         * cli/cli-setshow.h (parse_cli_boolean_value)
3069         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3070         (parse_cli_var_enum): Declare.
3071         * cli/cli-utils.c: Include "cli/cli-option.h".
3072         (get_ulongest): New.
3073         * cli/cli-utils.h (get_ulongest): Declare.
3074         (check_for_argument): New overloads.
3075         * maint-test-options.c: New file.
3076
3077 2019-06-13  Pedro Alves  <palves@redhat.com>
3078
3079         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3080         parse a range if "-" is at the end of the string.
3081
3082 2019-06-13  Pedro Alves  <palves@redhat.com>
3083
3084         * cli/cli-setshow.c (parse_auto_binary_operation)
3085         (parse_cli_boolean_value): Don't allow "o".
3086
3087 2019-06-13  Pedro Alves  <palves@redhat.com>
3088
3089         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3090         * NEWS: Mention maint test-settings KIND.
3091         * maint-test-settings.c: New file.
3092
3093 2019-06-13  Pedro Alves  <palves@redhat.com>
3094
3095         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3096         completer.
3097         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3098         "set" completers.
3099
3100 2019-06-13  Pedro Alves  <palves@redhat.com>
3101
3102         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3103         after item.
3104
3105 2019-06-13  Pedro Alves  <palves@redhat.com>
3106
3107         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3108
3109 2019-06-13  Pedro Alves <palves@redhat.com>
3110
3111         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3112         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3113         call.
3114         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3115         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3116         calls.
3117         (check_for_argument): Skip spaces after argument.
3118
3119 2019-06-13  Pedro Alves  <palves@redhat.com>
3120
3121         * thread.c (thread_apply_command): Adjust TID parsing.
3122         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3123         detected before end of string.
3124         (tid_is_in_list): Error out if LIST is invalid.
3125
3126 2019-06-13  Pedro Alves  <palves@redhat.com>
3127
3128         * completer.c (complete_line_internal_1): Rewind completion word
3129         point.
3130         (completion_tracker::advance_custom_word_point_by): Change
3131         parameter type to int.
3132         * completer.h (completion_tracker::advance_custom_word_point_by):
3133         Likewise.
3134
3135 2019-06-13  Pedro Alves  <palves@redhat.com>
3136
3137         * completer.c (advance_to_completion_word): Handle delimiters.
3138
3139 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3140
3141         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3142
3143 2019-06-11  Tom Tromey  <tom@tromey.com>
3144
3145         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3146         (xmalloc_failed): Move to alloc.c.
3147         * alloc.c: New file.
3148         * Makefile.in (COMMON_SFILES): Add alloc.c.
3149
3150 2019-06-11  Tom Tromey  <tom@tromey.com>
3151
3152         * nat/linux-waitpid.c: Don't include server.h.
3153         (linux_debug): Remove.
3154         (my_waitpid): Update.
3155
3156 2019-06-11  Tom Tromey  <tromey@adacore.com>
3157
3158         * infcall.c (_initialize_infcall): Remove trailing newline from
3159         help.
3160         * user-regs.c (_initialize_user_regs): Remove trailing newline
3161         from help.
3162         * typeprint.c (_initialize_typeprint): Remove trailing newline
3163         from help.
3164         * reverse.c (_initialize_reverse): Remove trailing newlines from
3165         help.
3166         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3167         from help.
3168         * language.c (add_set_language_command): Remove trailing newline
3169         from help.
3170         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3171         help.
3172         * disasm.c (_initialize_disasm): Remove trailing newline from
3173         help.
3174         * top.c (init_main): Remove trailing newline from help.
3175         * interps.c (_initialize_interpreter): Remove trailing newline
3176         from help.
3177         * btrace.c (_initialize_btrace): Remove trailing newlines from
3178         help.
3179         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3180         from help.
3181         * python/python.c (_initialize_python): Remove trailing newline
3182         from help.
3183         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3184         help.
3185         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3186         from help.  Reformat some text.
3187         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3188         from help.
3189         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3190         newline from help.
3191
3192 2019-06-11  Tom Tromey  <tromey@adacore.com>
3193
3194         * darwin-nat.c (darwin_decode_exception_message)
3195         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3196
3197 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3198
3199         * valops.c (value_slice): Check for not allocated or not
3200         associated values.
3201
3202 2019-06-10  Tom de Vries  <tdevries@suse.de>
3203
3204         PR gdb/24618
3205         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3206         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3207         invalid.
3208
3209 2019-06-10  Tom de Vries  <tdevries@suse.de>
3210
3211         PR gdb/24611
3212         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3213         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3214
3215 2019-06-10  Tom de Vries  <tdevries@suse.de>
3216
3217         PR symtab/24545
3218         * symtab.c (struct demangled_name_entry): Add language field.
3219         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3220         static minimal symbol".  Set and use language field.
3221
3222 2019-06-10  Tom Tromey  <tromey@adacore.com>
3223
3224         * ada-lang.c (_initialize_ada_language): Update help text.
3225
3226 2019-06-10  Tom Tromey  <tromey@adacore.com>
3227
3228         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3229         with a newline.
3230         * guile/guile.c (handle_boot_error): Don't end warning with a
3231         newline.
3232         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3233         warning with a newline.
3234         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3235         newline.
3236         (s12z_frame_cache): Likewise.
3237         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3238         a newline.
3239         * solib-svr4.c (disable_probes_interface): Don't end warning with
3240         a newline.
3241         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3242         newline.
3243         * python/python.c (do_finish_initialization): Don't end warning
3244         with a newline.
3245
3246 2019-06-10  Tom Tromey  <tom@tromey.com>
3247
3248         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3249         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3250         gdbpy_enter.
3251
3252 2019-06-10  Tom Tromey  <tromey@adacore.com>
3253
3254         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3255         data.
3256         (elf_new_init): Don't call stabsread_new_init.
3257         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3258         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3259         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3260
3261 2019-06-10  Tom de Vries  <tdevries@suse.de>
3262
3263         PR symtab/16264
3264         PR symtab/24517
3265         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3266
3267 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3268
3269         * source.c (find_and_open_source): Also rewrite relative file
3270         names.
3271
3272 2019-04-26  Amos Bird  <amosbird@gmail.com>
3273
3274         * annotate.c (annotate_thread_exited): Add "thread-exited"
3275         annotation.
3276
3277 2019-06-06  Tom Tromey  <tromey@adacore.com>
3278
3279         * maint.h (class scoped_command_stats): Use
3280         DISABLE_COPY_AND_ASSIGN.
3281         <print_time>: New method.
3282         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3283         print_time.
3284         (scoped_command_stats::print_time): New method.
3285
3286 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3287
3288         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3289         instructions of lengths 6 or 8 bytes.
3290
3291 2019-06-04  Pedro Alves  <palves@redhat.com>
3292
3293         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3294
3295         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3296         * breakpoint.c (condition_completer): Likewise.
3297         * cli/cli-dump.c (scan_expression): Likewise.
3298         * common/filestuff.c (mkdir_recursive): Likewise.
3299         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3300         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3301         (gdb_abspath): Likewise.
3302         * compile/compile-cplus-types.c
3303         (compile_cplus_instance::decl_name): Likewise.
3304         * completer.c (complete_explicit_location):
3305         (signal_completer, reg_or_group_completer_1): Likewise.
3306         * cp-support.c (cp_remove_params_if_any): Likewise.
3307         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3308         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3309         * infcmd.c (strip_bg_char): Likewise.
3310         * linespec.c (copy_token_string): Likewise.
3311         * mi/mi-main.c (output_cores): Likewise.
3312         * psymtab.c (psymtab_search_name):
3313         * symfile.c (test_set_ext_lang_command): Likewise.
3314         * target.c (target_fileio_read_stralloc): Likewise.
3315         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3316         * value.c (complete_internalvar): Likewise.
3317
3318 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3319
3320         Add objfile property to gdb.Type.
3321         * NEWS: Mention Python API addition.
3322         * python/py-type.c (typy_get_objfile): New method.
3323
3324 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3325
3326         * NEWS: Mention the new set|show style [title|highlight].
3327         Mention changes to "show style", "help" and "apropos".
3328
3329 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3330
3331         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3332         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3333         instead of print_help_for_command.
3334         (print_doc_of_command): New function.
3335         (help_list): Add 'apropos -v word' suggestion.
3336         (print_help_for_command): Style the command name using title style.
3337         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3338         (_initialize_cli_cmds): Describe -v in apropos_command help.
3339
3340 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3341
3342         * cli/cli-style.h (cli_style_option): Add name in constructor,
3343         add m_name class member, add constructor with intensity,
3344         add name class function.
3345         (cli_style_option::add_setshow_commands): Remove name argument.
3346         (highlight_style, title_style): New styles.
3347         * cli/cli-style.c (do_show): New function that shows a style
3348         characteristic styling the style name with itself.
3349         (set_style_name): New function.
3350         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3351         Update all callers according to the changes in cli/cli-style.h.
3352         * utils.h (fputs_highlighted): New function.
3353         * utils.c (fputs_highlighted): Likewise.
3354
3355 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3356
3357         * NEWS: Mention new pipe command and new convenience variables.
3358
3359 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3360
3361         * cli/cli-cmds.c (pipe_command): New function.
3362         (_initialize_cli_cmds): Call add_com for pipe_command.
3363         Define | as an alias for pipe.
3364         (exit_status_set_internal_vars): New function.
3365         (shell_escape): Call exit_status_set_internal_vars.
3366         cli/cli-decode.c (find_command_name_length): Recognize | as
3367         a single character command.
3368
3369 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3370
3371         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3372         top.c (execute_command_to_ui_file): New function, mostly a copy
3373         of execute_command_to_string.
3374         (execute_command_to_string): Implement by calling
3375         execute_command_to_ui_file.
3376
3377 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3378
3379         * top.h (saved_command_line): Remove declaration.
3380         * top.c (previous_saved_command_line, previous_repeat_arguments):
3381         New variables.
3382         (saved_command_line): Make static, define together with other
3383         'repeat variables'.
3384         (dont_repeat): Clear repeat_arguments.
3385         (repeat_previous, get_saved_command_line, save_command_line):
3386         New functions.
3387         (gdb_init): Initialize saved_command_line
3388         and previous_saved_command_line.
3389         * main.c (captured_main_1): Remove saved_command_line initialization.
3390         * event-top.c (handle_line_of_input): Update to use
3391         the new 'repeat' related functions instead of direct access to
3392         saved_command_line.
3393         * command.h (repeat_previous, get_saved_command_line,
3394         save_command_line): New declarations.
3395         (dont_repeat): Add comment.
3396
3397 2019-05-30  Tom Tromey  <tromey@adacore.com>
3398
3399         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3400         Fix comment.
3401         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3402
3403 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3404
3405         PR cli/24587
3406         * completer.c (complete): Initialize variable word.
3407
3408 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3409
3410         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3411         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3412         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3413         'body' is NULL to the outter 'if', protecting the '!is_define'
3414         situation as well.
3415
3416 2019-05-29  Tom Tromey  <tromey@adacore.com>
3417
3418         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3419         (dwarf_unknown): New function.
3420         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3421         (dwarf_type_encoding_name): Use dwarf_unknown.
3422
3423 2019-05-29  Tom Tromey  <tromey@adacore.com>
3424
3425         PR c++/20020:
3426         * cp-valprint.c (cp_print_value_fields): Call
3427         cp_print_static_field inside "try".
3428
3429 2019-05-29  Tom Tromey  <tromey@adacore.com>
3430
3431         * inflow.c (struct terminal_info): Add default operator=.
3432         * configure: Rebuild.
3433         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3434         -Wdeprecated-copy-dtor, -Wredundant-move.
3435
3436 2019-05-29  Tom Tromey  <tromey@adacore.com>
3437
3438         * NEWS: Add entry.
3439         * infcmd.c (print_return_value_1): Handle finish_print
3440         option.
3441         (show_print_finish): New function.
3442         (_initialize_infcmd): Add "set/show print finish" commands.
3443         * valprint.c (user_print_options): Initialize new member.
3444         * valprint.h (struct value_print_options) <finish_print>: New
3445         member.
3446
3447 2019-05-28  Tom Tromey  <tromey@adacore.com>
3448
3449         * ada-lang.c (ada_remove_Xbn_suffix)
3450         (find_old_style_renaming_symbol)
3451         (parse_old_style_renaming): Remove.
3452         (ada_find_renaming_symbol): Don't call
3453         find_old_style_renaming_symbol.
3454         (ada_is_renaming_symbol): Rename from
3455         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3456         bool.  Now static.
3457         (ada_read_var_value): Update and simplify.
3458         * ada-exp.y (write_var_or_type): Remove old code.
3459
3460 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3461
3462         * event-top.c: Remove include comment.
3463         * inflow.c (class scoped_ignore_sigttou): Move from here...
3464         * inflow.h (class scoped_ignore_sigttou): ...to here.
3465         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3466         * top.c:  Remove include comment.
3467
3468 2019-05-27  Tom Tromey  <tom@tromey.com>
3469
3470         * NEWS: Fix typo.
3471
3472 2019-05-22  Tom Tromey  <tromey@adacore.com>
3473
3474         * target.c (target_follow_exec): Constify parameter.
3475         * target-delegates.c: Rebuild.
3476         * remote.c (remote_target::follow_exec): Constify parameter.
3477         * infrun.c (follow_exec): Constify parameter.
3478         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3479         (target_follow_exec): Likewise.
3480
3481 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3482
3483         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3484         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3485
3486 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3487
3488         * NEWS: Add debugredirect and testsuite sections.
3489
3490 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3491
3492         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3493         target descriptions using exclusively floating point register name
3494         aliases.
3495
3496 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3497
3498         PR gdb/18644:
3499         * f-lang.c (build_fortran_types): Handle the case where
3500         gdbarch_floatformat_for_type returns a nullptr.
3501
3502 2019-05-21  Tom de Vries  <tdevries@suse.de>
3503
3504         PR cli/24587
3505         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3506
3507 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3508
3509         PR gdb/18644:
3510         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3511         16-byte floats.
3512         * i386-tdep.c (i386_floatformat_for_type): Use
3513         floatformats_ia64_quad for the 16-byte floating point component
3514         within a fortran 32-byte complex number.
3515
3516 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3517
3518         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3519         delete default constructor.
3520         (find_partial_die): Update to return const struct.
3521         (partial_die_parent_scope): Move variable declaration into scope
3522         of its use and change its type to auto.
3523         (guess_partial_die_structure_name): Likewise.
3524         (partial_die_info::fixup): Likewise.
3525
3526 2019-05-17  Tom Tromey  <tromey@adacore.com>
3527
3528         * source.c (find_and_open_source): Remove cast.
3529
3530 2019-05-17  Tom Tromey  <tromey@adacore.com>
3531
3532         * annotate.c (annotate_source): Make "filename" const.
3533         * annotate.h (annotate_source): Use const.
3534
3535 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3536
3537         * disasm.c (set_disassembler_options): Send errors to stderr.
3538
3539 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3540
3541         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3542         (cli_interp_base::set_logging): Check debug_redirect.
3543         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3544         * cli/cli-logging.c (debug_redirect): Add static variable.
3545         (pop_output_files): Add default param.
3546         (handle_redirections): Print debug setting.
3547         (show_logging_command): Likewise.
3548         (_initialize_cli_logging): Add debugredirect command.
3549         * interps.c (current_interp_set_logging): Add debug_redirect
3550         parameter.
3551         * interps.h (set_logging): Add debug_redirect parameter.
3552         (current_interp_set_logging): Likewise.
3553         * mi/mi-common.h: Likewise.
3554         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3555
3556 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3557             Tom Tromey  <tromey@adacore.com>
3558
3559         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3560         directly.
3561         * cli/cli-interp.h (make_logging_output): Remove declaration.
3562         * cli/cli-logging.c (make_logging_output): Remove function.
3563         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3564         directly.
3565         * ui-file.c (tee_file::tee_file): Remove bools.
3566         (tee_file::~tee_file): Remove deletes.
3567         * ui-file.h (tee_file): Remove bools.
3568
3569 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3570
3571         * mi/mi-cmds.h (mi_cmd_complete): New function.
3572         * mi/mi-main.c (mi_cmd_complete): Likewise.
3573         * mi/mi-cmds.c: Define new MI command -complete.
3574         * NEWS: Mention new -complete command.
3575
3576 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3577
3578         * completer.h (complete): New function.
3579         * completer.c (complete): Likewise.
3580         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3581         function defined in completer.h.
3582
3583 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3584
3585         * MAINTAINERS (Write After Approval): Add myself.
3586
3587 2019-05-17  Tom de Vries  <tdevries@suse.de>
3588
3589         PR gdb/24094
3590         * dwarf2read.c (struct cu_partial_die_info): New struct.
3591         (find_partial_die): Return cu_partial_die_info.
3592         (partial_die_parent_scope, guess_partial_die_structure_name)
3593         (partial_die_info::fixup): Handle new return type of find_partial_die.
3594
3595 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3596
3597         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3598         "std::string", simplifying the algorithm.
3599
3600 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3601
3602         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3603         (stap_static_probe_ops::get_probes): Likewise.
3604
3605 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3606
3607         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3608         '-')" and "else if".
3609         (stap_parse_single_operand): Join checks for
3610         "gdbarch_stap_parse_special_token_p" and
3611         "gdbarch_stap_parse_special_token" in the same "if" statement.
3612         Invert check when verifying for operation on register
3613         displacement.
3614
3615 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3616
3617         * stap-probe.c (stap_get_opcode): Update comment.
3618         (stap_get_expected_argument_type): Likewise.
3619         (handle_stap_probe): Likewise.
3620
3621 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3622
3623         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3624         return type to 'bool'.  Adjust comment.  Use 'bool' when
3625         appropriate.
3626         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3627         * stap-probe.c (stap_parse_argument_1): Likewise.
3628         (stap_is_operator): Likewise.
3629         (stap_is_generic_prefix): Likewise.
3630         (stap_is_register_prefix): Likewise.
3631         (stap_is_register_indirection_prefix): Likewise.
3632         (stap_is_integer_prefix): Likewise.
3633         (stap_generic_check_suffix): Likewise.
3634         (stap_check_integer_suffix): Likewise.
3635         (stap_check_register_suffix): Likewise.
3636         (stap_check_register_indirection_suffix): Likewise.
3637         (stap_parse_register_operand): Likewise.
3638         (stap_parse_single_operand): Likewise.
3639         (stap_parse_argument_1): Likewise.
3640         (stap_probe::get_argument_count): Likewise.
3641         (stap_is_operator): Likewise.
3642
3643 2019-05-16  Tom Tromey  <tromey@adacore.com>
3644
3645         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3646         keyword to foreach.
3647
3648 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3649
3650         * linux-thread-db.c (try_thread_db_load_1): Change return type
3651         to bool.
3652         (try_thread_db_load): Likewise.
3653         (try_thread_db_load_from_pdir_1): Likewise.
3654         (try_thread_db_load_from_pdir): Likewise.
3655         (try_thread_db_load_from_sdir): Likewise.
3656         (try_thread_db_load_from_dir): Likewise.
3657         (thread_db_load_search): Likewise.
3658         (has_libpthread): Likewise.
3659         (thread_db_load): Likewise.
3660
3661 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3662
3663         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3664         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3665         NULL, and complain/return if that's the case.
3666
3667 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3668
3669         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3670         (advance, posn, abstract_read_memory): New functions.
3671         [struct mem_read_abstraction]: New struct.
3672         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3673
3674 2019-05-14  Tom Tromey  <tromey@adacore.com>
3675
3676         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3677         value is not lval_memory.
3678
3679 2019-05-14  Tom Tromey  <tromey@adacore.com>
3680
3681         * solib.c (info_sharedlibrary_command): Style the file name.
3682
3683 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3684
3685         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3686         (aarch64_vnv_type): Likewise.
3687         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3688         * common/tdesc.c: Likewise.
3689         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3690         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3691         * features/aarch64-fpu.xml: Add ieee half view.
3692         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3693         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3694         * gdbtypes.h (struct builtin_type): Likewise.
3695         (struct objfile_type): Likewise.
3696
3697 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3698
3699         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3700         typo.
3701         * location.h (string_to_event_location): Likewise.
3702
3703 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3704
3705         GDB 8.3 released.
3706
3707 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3708
3709         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3710         New variable declaration.
3711         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3712         New variable.
3713         (print_one_breakpoint): Use ui_out::test_flags and new global
3714         variable to compute use_fixed_output.
3715         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3716         Remove.
3717         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3718         (mi_multi_location_breakpoint_output_fixed): Remove.
3719         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3720         new variable.
3721         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3722         fix_multi_location_breakpoint_output flag if version >= 3.
3723         * ui-out.h (enum ui_out_flag)
3724         <fix_multi_location_breakpoint_output>: New enumerator.
3725
3726 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3727
3728         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3729
3730 2019-05-10  Tom Tromey  <tromey@adacore.com>
3731
3732         * ada-lang.c (catch_ada_completer): New function.
3733         (_initialize_ada_language): Use it.
3734
3735 2019-05-10  Tom Tromey  <tromey@adacore.com>
3736
3737         * thread.c (print_thread_info): Make "requested_threads" const.
3738         * gdbthread.h (print_thread_info): Make "requested_threads"
3739         const.
3740         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3741         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3742
3743 2019-05-08  Tom Tromey  <tom@tromey.com>
3744
3745         * gdbtypes.c (objfile_type_data): Change type.
3746         (objfile_type, _initialize_gdbtypes): Update.
3747
3748 2019-05-08  Tom Tromey  <tom@tromey.com>
3749
3750         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3751         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3752         (_initialize_dwarf2_frame): Update.
3753
3754 2019-05-08  Tom Tromey  <tom@tromey.com>
3755
3756         * objc-lang.c (objc_objfile_data): Change type.
3757         (find_methods): Update.
3758         (_initialize_objc_lang): Remove.
3759
3760 2019-05-08  Tom Tromey  <tom@tromey.com>
3761
3762         * stabsread.c (rs6000_builtin_type_data): Change type.
3763         (rs6000_builtin_type, _initialize_stabsread): Update.
3764
3765 2019-05-08  Tom Tromey  <tom@tromey.com>
3766
3767         * mips-tdep.c (mips_pdr_data): Remove.
3768         (_initialize_mips_tdep): Update.
3769
3770 2019-05-08  Tom Tromey  <tom@tromey.com>
3771
3772         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3773         (hppa_init_objfile_priv_data, read_unwind_info)
3774         (find_unwind_entry, _initialize_hppa_tdep): Update.
3775
3776 2019-05-08  Tom Tromey  <tom@tromey.com>
3777
3778         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3779         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3780         on obstack.
3781         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3782
3783 2019-05-08  Tom Tromey  <tom@tromey.com>
3784
3785         * mdebugread.c (basic_type_data): Change type.
3786         (basic_type, _initialize_mdebugread): Update.
3787
3788 2019-05-08  Tom Tromey  <tom@tromey.com>
3789
3790         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3791
3792 2019-05-08  Tom Tromey  <tom@tromey.com>
3793
3794         * nto-tdep.c (nto_inferior_data_reg): Change type.
3795         (nto_inferior_data): Update.
3796         (nto_inferior_data_cleanup, nto_new_inferior_data)
3797         (_initialize_nto_tdep): Remove.
3798         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3799
3800 2019-05-08  Tom Tromey  <tom@tromey.com>
3801
3802         * ada-lang.c (struct ada_inferior_data): Add initializers.
3803         (ada_inferior_data): Change type.
3804         (ada_inferior_data_cleanup): Remove.
3805         (get_ada_inferior_data, ada_inferior_exit)
3806         (struct ada_pspace_data): Add initializers, destructor.
3807         (ada_pspace_data_handle): Change type.
3808         (get_ada_pspace_data): Update.
3809         (ada_pspace_data_cleanup): Remove.
3810
3811 2019-05-08  Tom Tromey  <tom@tromey.com>
3812
3813         * coffread.c (struct coff_symfile_info): Add initializers.
3814         (coff_objfile_data_key): Move lower.  Change type.
3815         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3816         Update.
3817         (coff_free_info): Remove.
3818
3819 2019-05-08  Tom Tromey  <tom@tromey.com>
3820
3821         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3822         (fbsd_pspace_data_handle): Move lower.  Change type.
3823         (get_fbsd_pspace_data): Update.
3824         (fbsd_pspace_data_cleanup): Remove.
3825         (_initialize_fbsd_tdep): Update.
3826
3827 2019-05-08  Tom Tromey  <tom@tromey.com>
3828
3829         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3830         (get_ada_tasks_pspace_data): Update.
3831         (ada_tasks_pspace_data_cleanup): Remove.
3832         (_initialize_tasks): Update.
3833         (ada_tasks_inferior_data_handle): Change type.
3834         (get_ada_tasks_inferior_data): Update.
3835         (ada_tasks_inferior_data_cleanup): Remove.
3836         (struct ada_tasks_pspace_data): Add initializers.
3837
3838 2019-05-08  Tom Tromey  <tom@tromey.com>
3839
3840         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3841         * symfile-debug.c (debug_sym_get_probes): Change type.
3842         * stap-probe.c (handle_stap_probe):
3843         (stap_static_probe_ops::get_probes): Change type.
3844         * probe.h (class static_probe_ops) <get_probes>: Change type.
3845         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3846         (parse_probes_in_pspace): Update.
3847         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3848         Update.
3849         (any_static_probe_ops::get_probes): Change type.
3850         * elfread.c (elfread_data): New typedef.
3851         (probe_key): Change type.
3852         (elf_get_probes): Likewise.  Update.
3853         (probe_key_free): Remove.
3854         (_initialize_elfread): Update.
3855         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3856         Change type.
3857         (dtrace_process_dof_probe, dtrace_process_dof)
3858         (dtrace_static_probe_ops::get_probe): Change type.
3859
3860 2019-05-08  Tom Tromey  <tom@tromey.com>
3861
3862         * xcoffread.c (struct xcoff_symfile_info): Rename from
3863         coff_symfile_info.  Add initializers.
3864         (xcoff_objfile_data_key): Move lower.  Change type.
3865         (XCOFF_DATA): Rewrite.
3866         (xcoff_free_info): Remove.
3867         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3868         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3869         (xcoff_initial_scan): Update.
3870
3871 2019-05-08  Tom Tromey  <tom@tromey.com>
3872
3873         * solib-svr4.c (struct svr4_info): Add initializers and
3874         destructor.
3875         <probes_table>: Now an htab_up.
3876         (solib_svr4_pspace_data): Change type.
3877         (free_probes_table): Simplify.
3878         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3879         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3880         (probes_table_remove_objfile_probes, register_solib_event_probe)
3881         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3882         (_initialize_svr4_solib): Update.
3883
3884 2019-05-08  Tom Tromey  <tom@tromey.com>
3885
3886         * remote.c (remote_pspace_data): Change type.
3887         (remote_pspace_data_cleanup): Remove.
3888         (get_remote_exec_file, set_pspace_remote_exec_file)
3889         (_initialize_remote): Update.
3890
3891 2019-05-08  Tom Tromey  <tom@tromey.com>
3892
3893         * breakpoint.c (breakpoint_objfile_key): Change type.
3894         (get_breakpoint_objfile_data): Update.
3895         (free_breakpoint_objfile_data): Remove.
3896         (_initialize_breakpoint): Update.
3897
3898 2019-05-08  Tom Tromey  <tom@tromey.com>
3899
3900         * linux-tdep.c (struct linux_info): Add initializers.
3901         (linux_inferior_data): Move.  Change type.
3902         (invalidate_linux_cache_inf): Update.
3903         (linux_inferior_data_cleanup): Remove.
3904         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3905
3906 2019-05-08  Tom Tromey  <tom@tromey.com>
3907
3908         * auxv.c (auxv_inferior_data): Move.  Change type.
3909         (auxv_inferior_data_cleanup): Remove.
3910         (invalidate_auxv_cache_inf): Rewrite.
3911         (get_auxv_inferior_data, _initialize_auxv): Update.
3912
3913 2019-05-08  Tom Tromey  <tom@tromey.com>
3914
3915         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3916         (symfile_debug_objfile_data_key): Change type.
3917         (symfile_debug_installed, debug_qf_has_symbols)
3918         (debug_qf_find_last_source_symtab)
3919         (debug_qf_forget_cached_source_info)
3920         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3921         (debug_qf_print_stats, debug_qf_dump)
3922         (debug_qf_expand_symtabs_for_function)
3923         (debug_qf_expand_all_symtabs)
3924         (debug_qf_expand_symtabs_with_fullname)
3925         (debug_qf_map_matching_symbols)
3926         (debug_qf_expand_symtabs_matching)
3927         (debug_qf_find_pc_sect_compunit_symtab)
3928         (debug_qf_map_symbol_filenames)
3929         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3930         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3931         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3932         (debug_sym_read_linetable, debug_sym_relocate): Update.
3933         (symfile_debug_free_objfile): Remove.
3934         (install_symfile_debug_logging, _initialize_symfile_debug):
3935         Update.
3936
3937 2019-05-08  Tom Tromey  <tom@tromey.com>
3938
3939         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3940         allocate_on_obstack.
3941         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3942         (get_dwarf2_per_objfile): Update.
3943         (set_dwarf2_per_objfile): Remove.
3944         (dwarf2_has_info, dwarf2_get_section_info): Update.
3945         (dwarf2_free_objfile): Remove.
3946         (_initialize_dwarf2_read): Update.
3947
3948 2019-05-08  Tom Tromey  <tom@tromey.com>
3949
3950         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3951         initializers.
3952         <unsupported_script_warning_printed,
3953         script_not_found_warning_printed>: Now bool.
3954         (auto_load_pspace_data): Change type.
3955         (~auto_load_pspace_info): Rename from
3956         auto_load_pspace_data_cleanup.
3957         (get_auto_load_pspace_data, init_loaded_scripts_info)
3958         (clear_section_scripts, maybe_print_unsupported_script_warning)
3959         (maybe_print_script_not_found_warning, _initialize_auto_load):
3960         Update.
3961
3962 2019-05-08  Tom Tromey  <tom@tromey.com>
3963
3964         * objfiles.c (objfile_pspace_info): Add destructor and
3965         initializers.
3966         (objfiles_pspace_data): Change type.
3967         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3968         (get_objfile_pspace_data): Update.
3969         (objfiles_bfd_data): Change type.
3970         (get_objfile_bfd_data): Update.
3971         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3972
3973 2019-05-08  Tom Tromey  <tom@tromey.com>
3974
3975         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3976         Change type.
3977         (get_catch_syscall_inferior_data): Update.
3978         (catch_syscall_inferior_data_cleanup): Remove.
3979         (_initialize_break_catch_syscall): Update.
3980
3981 2019-05-08  Tom Tromey  <tom@tromey.com>
3982
3983         * inflow.c (struct terminal_info): Add destructor and
3984         initializers.
3985         (inflow_inferior_data): Change type.
3986         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3987         (get_inflow_inferior_data, inflow_inferior_exit)
3988         (swap_terminal_info, _initialize_inflow): Update.
3989
3990 2019-05-08  Tom Tromey  <tom@tromey.com>
3991
3992         * target-dcache.c (target_dcache_cleanup): Remove.
3993         (target_dcache_aspace_key): Change type.
3994         (target_dcache_init_p, target_dcache_invalidate)
3995         (target_dcache_get, target_dcache_get_or_init)
3996         (_initialize_target_dcache): Update.
3997         * dcache.h (struct dcache_deleter): New.
3998
3999 2019-05-08  Tom Tromey  <tom@tromey.com>
4000
4001         * symtab.c (struct symbol_cache): Add destructor and
4002         initializers.
4003         (symbol_cache_key): Move.  Change type.
4004         (make_symbol_cache, free_symbol_cache): Remove.
4005         (get_symbol_cache): Update.
4006         (symbol_cache_cleanup): Remove.
4007         (ALL_PSPACES, symbol_cache_flush)
4008         (maintenance_print_symbol_cache)
4009         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4010         Update.
4011
4012 2019-05-08  Tom Tromey  <tom@tromey.com>
4013
4014         * symtab.c (struct main_info): Add destructor and initializers.
4015         (main_progspace_key): Move.  Change type.
4016         (get_main_info): Update.
4017         (main_info_cleanup): Remove.
4018         (_initialize_symtab): Update.
4019
4020 2019-05-08  Tom Tromey  <tom@tromey.com>
4021
4022         * registry.h (DECLARE_REGISTRY): Define the _key class.
4023
4024 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4025
4026         * NEWS: Merge two 'New commands' sections.
4027
4028 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4029
4030         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4031         parameter and use Ada language definition instead.
4032         (ada_val_print_ptr): Remove unused language parameter.
4033         (ada_val_print_num): Remove language parameter and use Ada language
4034         definition instead.
4035         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4036         parameter.
4037         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4038         parameter and use Ada language definition instead.
4039         (ada_val_print_1): Update all ada_val_print_xxx calls.
4040         Remove language parameter.
4041         (ada_val_print): Update ada_val_print_1 call.
4042
4043 2019-05-08  Tom Tromey  <tromey@adacore.com>
4044
4045         * remote.c (remote_hw_watchpoint_limit)
4046         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4047         Now static.
4048
4049 2019-05-08  Tom Tromey  <tromey@adacore.com>
4050
4051         * maint.c (_initialize_maint_cmds): Move initialization code to
4052         remote.c.
4053         (watchdog, show_watchdog): Move to remote.c.
4054         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4055         "watchdog" static.
4056         (_initialize_remote): Move initialization code from maint.c.
4057         * defs.h (watchdog): Don't declare.
4058
4059 2019-05-08  Tom Tromey  <tromey@adacore.com>
4060
4061         * tui/tui-interp.c: Include main.h.
4062         * interps.c: Include main.h.
4063         * main.h (interpreter_p): Declare.
4064         * defs.h (interpreter_p): Don't declare.
4065
4066 2019-05-08  Tom Tromey  <tromey@adacore.com>
4067
4068         * dwarf2loc.c: Include dwarf2read.h.
4069         * defs.h (read_unsigned_leb128): Don't declare.
4070         * dwarf2read.h (read_unsigned_leb128): Declare.
4071
4072 2019-05-08  Tom Tromey  <tromey@adacore.com>
4073
4074         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4075         method.
4076
4077 2019-05-08  Tom Tromey  <tromey@adacore.com>
4078
4079         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4080         when no wrap column is set.
4081
4082 2019-05-08  Tom Tromey  <tromey@adacore.com>
4083
4084         * c-lang.c (c_get_string): Handle non-C-style arrays.
4085
4086 2019-05-08  Tom Tromey  <tromey@adacore.com>
4087
4088         * typeprint.c (print_offset_data::update): Print the bit offset,
4089         not the number of bits remaining.
4090
4091 2019-05-08  Tom Tromey  <tromey@adacore.com>
4092
4093         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4094         padding at end of comment.
4095
4096 2019-05-08  Tom Tromey  <tromey@adacore.com>
4097
4098         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4099         Compare main types.
4100
4101 2019-05-06  Tom Tromey  <tom@tromey.com>
4102
4103         * common/scoped_mmap.c: Include common-defs.h.
4104         * common/scoped_mmap.h: Don't include config.h.
4105
4106 2019-05-04  Tom Tromey  <tom@tromey.com>
4107
4108         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4109         (struct aarch64_call_info): Add initializers.
4110         <si>: Now a std::vector.
4111         (pass_on_stack, aarch64_push_dummy_call): Update.
4112
4113 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4114             Tom Tromey  <tom@tromey.com>
4115
4116         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4117         (ppc_threads): Now a std::vector.  Now static.
4118         (hwdebug_find_thread_points_by_tid)
4119         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4120         Update.
4121
4122 2019-05-04  Tom Tromey  <tom@tromey.com>
4123
4124         * arc-tdep.c (arc_tdesc_init): Return bool.
4125
4126 2019-05-04  Tom Tromey  <tom@tromey.com>
4127
4128         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4129         Use gdb_assert_not_reached.
4130
4131 2019-05-04  Tom Tromey  <tom@tromey.com>
4132
4133         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4134         "false".
4135
4136 2019-05-04  Tom Tromey  <tom@tromey.com>
4137
4138         * arc-tdep.c (arc_tdesc_init): Use bool.
4139
4140 2019-05-04  Tom Tromey  <tom@tromey.com>
4141
4142         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4143
4144 2019-05-04  Tom Tromey  <tom@tromey.com>
4145
4146         * cli/cli-cmds.c (valid_command_p): Return bool.
4147
4148 2019-05-04  Tom Tromey  <tom@tromey.com>
4149
4150         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4151         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4152
4153 2019-05-04  Raul Tambre  <raul@tambre.ee>
4154
4155         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4156         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4157         operator for comparison.
4158
4159 2019-05-04  Tom Tromey  <tom@tromey.com>
4160
4161         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4162         (lookup_partial_symbol, print_partial_symbols)
4163         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4164         (psymbol_compare): Update.
4165         (add_psymbol_to_bcache): Clear the entire psymbol.
4166         (maintenance_check_psymtabs): Update.
4167         * psympriv.h (struct partial_symbol): Don't derive from
4168         general_symbol_info.
4169         <obj_section, unrelocated_address, address,
4170         set_unrelocated_address>: Update.
4171         <ginfo>: New member.
4172         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4173         (debug_names::write_psymbols): Update.
4174
4175 2019-05-04  Tom de Vries  <tdevries@suse.de>
4176
4177         * contrib/cc-with-tweaks.sh: Support -n arg.
4178
4179 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4180
4181         * corelow.c (core_target::detach): Ensure frame cache and
4182         register caches are cleared.
4183         inferior.c (exit_inferior_1): Likewise.
4184
4185 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4186             Tom Tromey  <tom@tromey.com>
4187
4188         * dictionary.c (collate_pending_symbols_by_language): Remove
4189         "struct" from foreach.
4190         * symtab.c (lookup_global_symbol_from_objfile)
4191         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4192         foreach.
4193         * ser-tcp.c (net_open): Remove "struct" from foreach.
4194         * objfiles.c (objfile_relocate, objfile_rebase)
4195         (objfile_has_symbols): Remove "struct" from foreach.
4196         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4197         from foreach.
4198         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4199         foreach.
4200         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4201         "struct" from foreach.
4202         * ada-lang.c (create_excep_cond_exprs)
4203         (ada_exception_catchpoint_cond_string): Remove "struct" from
4204         foreach.
4205
4206 2019-05-03  Tom Tromey  <tromey@adacore.com>
4207
4208         * ada-exp.y (convert_char_literal): Check suffix of each
4209         enumerator.
4210
4211 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4212
4213         PR ada/21406:
4214         * ada-exp.y (yywrap): Don't define.
4215         * ada-lex.l (%option): Add noyywrap
4216         (yywrap): Remove.
4217
4218 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4219
4220         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4221         _WIN32_WINNT to the XP level, unless already defined to a higher
4222         level.
4223
4224         * unittests/parse-connection-spec-selftests.c:
4225         * ser-tcp.c:
4226         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4227         override.
4228
4229         * symfile.c (find_separate_debug_file): Remove colon from the
4230         drive spec of DOS/Windows file names of the target, so that the
4231         file name produced from DEBUGDIR and the target's directory will
4232         be valid on DOS/Windows systems.
4233
4234 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4235
4236         * rust-lang.c (val_print_struct): Handle printing structures
4237         containing strings.
4238
4239 2019-05-02  Tom Tromey  <tromey@adacore.com>
4240
4241         * valarith.c (_initialize_valarith): Remove.
4242
4243 2019-05-01  Tom Tromey  <tromey@adacore.com>
4244
4245         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4246         bitfields.
4247
4248 2019-05-01  Tom Tromey  <tromey@adacore.com>
4249
4250         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4251         for big-endian copies.
4252
4253 2019-04-30  Ali Tamur  <tamur@google.com>
4254         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4255         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4256         (read_3_bytes): New function.
4257
4258 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4259
4260         * windows-nat.c (main_thread_id): Delete.
4261         (handle_output_debug_string): Replace main_thread_id by
4262         current_event.dwThreadId.
4263         (fake_create_process): Likewise.
4264         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4265         Do not set main_thread_id.
4266         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4267         current_event.dwThreadId.
4268         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4269
4270 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4271
4272         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4273         Use current_event.dwThreadId instead of main_thread_id.
4274
4275 2019-04-30  Tom Tromey  <tromey@adacore.com>
4276
4277         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4278         (create_excep_cond_exprs): Iterate over program spaces.
4279         (ada_exception_catchpoint_cond_string): Examine all minimal
4280         symbols for exception types.
4281
4282 2019-04-30  Tom Tromey  <tromey@adacore.com>
4283
4284         PR c++/24470:
4285         * dwarf2read.c (process_structure_scope): Handle case where type
4286         has template parameters but no symbol was created.
4287
4288 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4289             Chris January  <chris.january@arm.com>
4290
4291         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4292         qualifier.
4293         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4294
4295 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4296
4297         * f-typeprint.c (f_print_type): Update rules for printing
4298         whitespace.
4299         (f_type_print_varspec_suffix): Likewise.
4300
4301 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4302             Chris January  <chris.january@arm.com>
4303
4304         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4305         function arguments.
4306
4307 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4308
4309         * f-lang.c (build_fortran_types): Change name of void type to
4310         lower case.
4311         * f-typeprint.c (f_type_print_base): Print the name of the void
4312         type, rather than a fixed string.
4313         * f-valprint.c (f_decorations): Use lower case void string.
4314
4315 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4316             Chris January  <chris.january@arm.com>
4317
4318         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4319         types for Fortran.
4320
4321 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4322             Chris January  <chris.january@arm.com>
4323             David Lecomber  <david.lecomber@arm.com>
4324
4325         * f-exp.y (BINOP_INTRINSIC): New token.
4326         (exp): New parser rule handling BINOP_INTRINSIC.
4327         (f77_keywords): Add new builtin procedures.
4328         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4329         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4330         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4331         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4332         (print_unop_subexp_f): New function.
4333         (print_binop_subexp_f): New function.
4334         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4335         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4336         (dump_subexp_body_f): Likewise.
4337         (operator_check_f): Likewise.
4338         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4339         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4340
4341 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4342
4343         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4344         UNOP_KIND.
4345         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4346         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4347         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4348         (operator_length_f): New fuction.
4349         (print_subexp_f): New function.
4350         (op_name_f): New function.
4351         (dump_subexp_body_f): New function.
4352         (operator_check_f): New function.
4353         (exp_descriptor_f): Replace standard expression handling functions
4354         with new functions.
4355         * gdb/fortran-operator.def: New file.
4356         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4357         * gdb/std-operator.def: Remove UNOP_KIND.
4358
4359 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4360
4361         * std-operator.def: Remove unbalanced, stray double quote
4362         character.
4363
4364 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4365             Chris January  <chris.january@arm.com>
4366             Daniel Everett  <daniel.everett@arm.com>
4367             Nick Forrington  <nick.forrington@arm.com>
4368             Richard Bunt  <richard.bunt@arm.com>
4369
4370         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4371         of depth when printing anonymous structs or unions.
4372         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4373         Don't print either the top-level value, or the children if the
4374         max-depth is exceeded.
4375         (ppscm_print_children): When printing the key of a map, allow one
4376         extra level of depth.
4377         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4378         print either the top-level value, or the children if the max-depth
4379         is exceeded.
4380         (print_children): When printing the key of a map, allow one extra
4381         level of depth.
4382         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4383         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4384         (user_print_options): Initialise max_depth field.
4385         (val_print_scalar_or_string_type_p): New function.
4386         (val_print): Check to see if the max depth has been reached.
4387         (val_print_check_max_depth): Define new function.
4388         (show_print_max_depth): New function.
4389         (_initialize_valprint): Add 'print max-depth' option.
4390         * valprint.h (struct value_print_options) <max_depth>: New field.
4391         (val_print_check_max_depth): Declare new function.
4392         * NEWS: Document new feature.
4393
4394 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4395
4396         * ada-lang.c (ada_language_defn): Initialise new field.
4397         * c-lang.c (c_is_string_type_p): New function.
4398         (c_language_defn): Initialise new field.
4399         (cplus_language_defn): Initialise new field.
4400         (asm_language_defn): Initialise new field.
4401         (minimal_language_defn): Initialise new field.
4402         * c-lang.h (c_is_string_type_p): Declare new function.
4403         * d-lang.c (d_language_defn): Initialise new field.
4404         * f-lang.c (f_is_string_type_p): New function.
4405         (f_language_defn): Initialise new field.
4406         * go-lang.c (go_is_string_type_p): New function.
4407         (go_language_defn): Initialise new field.
4408         * language.c (default_is_string_type_p): New function.
4409         (unknown_language_defn): Initialise new field.
4410         (auto_language_defn): Initialise new field.
4411         * language.h (struct language_defn) <la_is_string_type_p>: New
4412         member variable.
4413         (default_is_string_type_p): Declare new function.
4414         * m2-lang.c (m2_language_defn): Initialise new field.
4415         * objc-lang.c (objc_language_defn): Initialise new field.
4416         * opencl-lang.c (opencl_language_defn): Initialise new field.
4417         * p-lang.c (pascal_is_string_type_p): New function.
4418         (pascal_language_defn): Initialise new field.
4419         * rust-lang.c (rust_is_string_type_p): New function.
4420         (rust_language_defn): Initialise new field.
4421
4422 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4423
4424         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4425         New field.
4426         * ada-lang.c (ada_language_defn): Initialise new field.
4427         * c-lang.c (c_language_defn): Likewise.
4428         (cplus_language_defn): Likewise.
4429         (asm_language_defn): Likewise.
4430         (minimal_language_defn): Likewise.
4431         * d-lang.c (d_language_defn): Likewise.
4432         * f-lang.c (f_language_defn): Likewise.
4433         * go-lang.c (go_language_defn): Likewise.
4434         * language.c (unknown_language_defn): Likewise.
4435         (auto_language_defn): Likewise.
4436         * m2-lang.c (m2_language_defn): Likewise.
4437         * objc-lang.c (objc_language_defn): Likewise.
4438         * opencl-lang.c (opencl_language_defn): Likewise.
4439         * p-lang.c (pascal_language_defn): Likewise.
4440         * rust-lang.c (rust_language_defn): Likewise.
4441
4442 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4443
4444         * ada-lang.c (ada_is_character_type): Change return type to bool.
4445         (ada_is_string_type): Likewise.
4446         * ada-lang.h (ada_is_character_type): Update declaration
4447         (ada_is_string_type): Likewise.
4448
4449 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4450
4451         Support style in 'frame|thread apply'
4452
4453         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4454         * record.c (record_start, record_stop): Update callers of
4455         execute_command_to_string with false.
4456         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4457         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4458         methods.
4459         (class string_file): New constructor with term_out parameter.
4460         Override methods term_out and can_emit_style_escape.  New member
4461         term_out.
4462         (class stdio_file): Override can_emit_style_escape.
4463         (class tee_file): Override term_out and can_emit_style_escape.
4464         * utils.h (can_emit_style_escape): Remove.
4465         * utils.c (can_emit_style_escape): Likewise.
4466         Update all callers of can_emit_style_escape (SOMESTREAM) to
4467         SOMESTREAM->can_emit_style_escape.
4468         * source-cache.c (source_cache::get_source_lines): Likewise.
4469         * stack.c (frame_apply_command_count): Call execute_command_to_string
4470         passing the term_out characteristic of the current gdb_stdout.
4471         * thread.c (thr_try_catch_cmd): Likewise.
4472         * top.c (execute_command_to_string): pass term_out parameter
4473         to construct the string_file for the command output.
4474         * ui-file.c (term_cli_styling): New function (most code moved
4475         from utils.c can_emit_style_escape).
4476         (string_file::string_file, string_file::can_emit_style_escape,
4477         stdio_file::can_emit_style_escape, tee_file::term_out,
4478         tee_file::can_emit_style_escape): New functions.
4479
4480 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4481
4482         * NEWS: Mention the new set|show may-call-functions.
4483         * infcall.c (may_call_functions_p): New variable.
4484         (show_may_call_functions_p): New function.
4485         (call_function_by_hand_dummy): Throws an error if not
4486         may-call-functions.
4487         (_initialize_infcall): Call add_setshow_boolean_cmd for
4488         may-call-functions.
4489
4490 2019-04-25  Keith Seitz  <keiths@redhat.com>
4491
4492         PR c++/24367
4493         * cp-support.c (inspect_type): Don't attempt substitutions
4494         of symbol with the same name.
4495
4496 2019-04-25  Tom Tromey  <tromey@adacore.com>
4497
4498         PR gdb/24475:
4499         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4500         static.
4501
4502 2019-04-25  Tom Tromey  <tromey@adacore.com>
4503
4504         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4505         rvalue reference.
4506         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4507         (gdb_xml_parser::parse): Use std::move.
4508         * python/python-internal.h (gdbpy_convert_exception): Take a const
4509         reference.
4510         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4511         std::move.
4512         * python/py-utils.c (gdbpy_convert_exception): Take a const
4513         reference.
4514         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4515         Use std::move.
4516         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4517         Use std::move.
4518         * mi/mi-main.c (mi_print_exception): Take a const reference.
4519         * main.c (handle_command_errors): Take a const reference.
4520         * linespec.c (parse_linespec): Use std::move.
4521         * infcall.c (run_inferior_call): Use std::move.
4522         (call_function_by_hand_dummy): Use std::move.
4523         * exec.c (try_open_exec_file): Use std::move.
4524         * exceptions.h (exception_print, exception_fprintf)
4525         (exception_print_same): Update.
4526         * exceptions.c (print_exception, exception_print)
4527         (exception_fprintf, exception_print_same): Change parameters to
4528         const reference.
4529         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4530         * common/new-op.c: Use std::move.
4531         * common/common-exceptions.h (struct gdb_exception): Add move
4532         constructor.
4533         (struct gdb_exception_error, struct gdb_exception_quit, struct
4534         gdb_quit_bad_alloc): Change constructor to move constructor.
4535         (throw_exception): Change parameter to rvalue reference.
4536         * common/common-exceptions.c (throw_exception): Take rvalue
4537         reference.
4538         * cli/cli-interp.c (safe_execute_command): Use std::move.
4539         * breakpoint.c (insert_bp_location, location_to_sals): Use
4540         std::move.
4541
4542 2019-04-25  Tom Tromey  <tromey@adacore.com>
4543
4544         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4545         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4546         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4547         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4548         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4549         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4550         guile/scm-value.c: Use unpack.
4551         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4552         gdbscm_gdb_exception.
4553         (gdbscm_throw_gdb_exception): Likewise.
4554         (struct gdbscm_gdb_exception): New.
4555         (unpack): New function.
4556         (gdbscm_wrap): Use unpack.
4557
4558 2019-04-25  Tom Tromey  <tromey@adacore.com>
4559
4560         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4561         (gdb_rl_callback_handler): Use std::move.
4562         * common/common-exceptions.h (struct gdb_exception): Add move
4563         assignment operator.
4564         (throw_exception_sjlj): Change "exception" to const reference.
4565         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4566         (throw_exception_sjlj): Change "exception" to const reference.
4567
4568 2019-04-25  Tom Tromey  <tromey@adacore.com>
4569
4570         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4571         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4572         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4573         Update.
4574         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4575         Update.
4576         * mi/mi-interp.c (mi_interp::exec): Update.
4577         * linespec.c (parse_linespec): Update.
4578         * infcall.c (run_inferior_call): Update.
4579         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4580         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4581         (gdbscm_lookup_global_symbol): Update.
4582         * guile/scm-param.c (gdbscm_parameter_value): Update.
4583         * guile/scm-frame.c (gdbscm_frame_read_register)
4584         (gdbscm_frame_read_var): Update.
4585         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4586         * exec.c (try_open_exec_file): Update.
4587         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4588         (gdb_rl_callback_handler): Update.
4589         * common/common-exceptions.h (exception_none): Don't declare.
4590         * common/common-exceptions.c (exception_none): Don't define.
4591         (struct catcher) <exception>: Update.
4592         * cli/cli-interp.c (safe_execute_command): Update.
4593         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4594
4595 2019-04-25  Ali Tamur  <tamur@google.com>
4596
4597         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4598         (read_attribute_value): Likewise.
4599         (dwarf2_read_addr_index): Update comment.
4600         (read_str_index): Add DW_FORM_strx.
4601         (dwarf2_string_attr): Likewise.
4602         (dwarf2_const_value_attr): Likewise.
4603         (dump_die_shallow): Likewise.
4604         (dwarf2_fetch_constant_bytes): Likewise.
4605         (skip_form_bytes): Likewise.
4606         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4607
4608 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4609
4610         PR corefiles/11608
4611         PR corefiles/18187
4612         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4613         OFFSET.  Verify if current mapping contains an ELF header.
4614         (linux_find_memory_regions_full): Adjust call to
4615         dump_mapping_p.
4616
4617 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4618             Kang Li <kanglictf@gmail.com>
4619
4620         PR gdb/21600
4621
4622         * dwarf2-frame.c (read_initial_length): Be consistent about using
4623         unsigned representation of length.
4624         (decode_frame_entry_1): Likewise.  Check for wraparound of
4625         end pointer as well as buffer overflow.
4626
4627 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4628
4629         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4630         "vq".
4631
4632 2019-04-24  Tom Tromey  <tromey@adacore.com>
4633
4634         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4635
4636 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4637
4638         * s12z-tdep.c (s12z_unwind_pc): Delete.
4639         (s12z_unwind_sp): Delete.
4640         (s12z_gdbarch_init): Don't register deleted functions with
4641         gdbarch.
4642
4643 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4644
4645         * rl78-tdep.c (rl78_unwind_sp): Delete.
4646         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4647
4648 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4649
4650         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4651         (xstormy16_unwind_pc): Delete.
4652         (xstormy16_dummy_id): Delete.
4653         (xstormy16_gdbarch_init): Don't register deleted functions with
4654         gdbarch.
4655
4656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4657
4658         * vax-tdep.c (vax_unwind_pc): Delete.
4659         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4660
4661 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4662
4663         * v850-tdep.c (v850_unwind_sp): Delete.
4664         (v850_unwind_pc): Delete.
4665         (v850_dummy_id): Delete.
4666         (v850_gdbarch_init): Don't register deleted functions with
4667         gdbarch.
4668
4669 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4670
4671         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4672         (tilegx_unwind_pc): Delete.
4673         (tilegx_unwind_dummy_id): Delete.
4674         (tilegx_gdbarch_init): Don't register deleted functions with
4675         gdbarch.
4676
4677 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4678
4679         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4680         (tic6x_dummy_id): Delete.
4681         (tic6x_gdbarch_init): Don't register deleted functions with
4682         gdbarch.
4683
4684 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4685
4686         * sparc-tdep.c (sparc_unwind_pc): Delete.
4687         (sparc32_gdbarch_init): Don't register deleted function with
4688         gdbarch.
4689
4690 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4691
4692         * sh-tdep.c (sh_unwind_sp): Delete.
4693         (sh_unwind_pc): Delete.
4694         (sh_dummy_id): Delete.
4695         (sh_gdbarch_init): Don't register deleted functions with
4696         gdbarch.
4697
4698 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4699
4700         * score-tdep.c (score_unwind_sp): Delete.
4701         (score_unwind_pc): Delete.
4702         (score_dummy_id): Delete.
4703         (score_gdbarch_init): Don't register deleted functions with
4704         gdbarch.
4705
4706 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4707
4708         * rx-tdep.c (rx_unwind_pc): Delete.
4709         (rx_unwind_sp): Delete.
4710         (rx_dummy_id): Delete.
4711         (rx_gdbarch_init): Don't register deleted functions with
4712         gdbarch.  Update comment.
4713
4714 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4715
4716         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4717         (rs6000_dummy_id): Delete.
4718         (rs6000_gdbarch_init): Don't register deleted functions with
4719         gdbarch.
4720
4721 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4722
4723         * or1k-tdep.c (or1k_dummy_id): Delete.
4724         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4725
4726 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4727
4728         * nios2-tdep.c (nios2_dummy_id): Delete.
4729         (nios2_unwind_sp): Delete.
4730         (nios2_gdbarch_init): Don't register deleted functions with
4731         gdbarch.
4732
4733 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4734
4735         * nds32-tdep.c (nds32_dummy_id): Delete.
4736         (nds32_unwind_pc): Delete.
4737         (nds32_unwind_sp): Delete.
4738         (nds32_gdbarch_init): Don't register deleted functions with
4739         gdbarch.
4740
4741 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4742
4743         * msp430-tdep.c (msp430_unwind_pc): Delete.
4744         (msp430_unwind_sp): Delete.
4745         (msp430_dummy_id): Delete.
4746         (msp430_gdbarch_init): Don't register deleted functions with
4747         gdbarch.
4748
4749 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4750
4751         * moxie-tdep.c (moxie_unwind_sp): Delete.
4752         (moxie_unwind_pc): Delete.
4753         (moxie_dummy_id): Delete.
4754         (moxie_gdbarch_init): Don't register deleted functions with
4755         gdbarch.
4756
4757 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4758
4759         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4760         (mn10300_unwind_pc): Delete.
4761         (mn10300_unwind_sp): Delete.
4762         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4763         mn10300_unwind_sp.
4764         (mn10300_frame_unwind_init): Don't register deleted functions with
4765         gdbarch.
4766
4767 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4768
4769         * mep-tdep.c (mep_unwind_pc): Delete.
4770         (mep_unwind_sp): Delete.
4771         (mep_dummy_id): Delete.
4772         (mep_gdbarch_init): Don't register deleted functions with
4773         gdbarch.
4774
4775 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4776
4777         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4778         (m68hc11_unwind_sp): Delete.
4779         (m68hc11_gdbarch_init): Don't register deleted functions with
4780         gdbarch.
4781
4782 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4783
4784         * m32r-tdep.c (m32r_unwind_sp): Delete.
4785         (m32r_unwind_pc): Delete.
4786         (m32r_dummy_id): Delete.
4787         (m32r_gdbarch_init): Don't register deleted functions with
4788         gdbarch.
4789
4790 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4791
4792         * m32c-tdep.c (m32c_unwind_pc): Delete.
4793         (m32c_unwind_sp): Delete.
4794         (m32c_dummy_id): Delete.
4795         (m32c_gdbarch_init): Don't register deleted functions with
4796         gdbarch.
4797
4798 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4799
4800         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4801         (lm32_unwind_pc): Delete.
4802         (lm32_dummy_id): Delete.
4803         (lm32_gdbarch_init): Don't register deleted functions with
4804         gdbarch.
4805
4806 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4807
4808         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4809         (iq2000_unwind_pc): Delete.
4810         (iq2000_dummy_id): Delete.
4811         (iq2000_gdbarch_init): Don't register deleted functions with
4812         gdbarch.
4813
4814 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4815
4816         * nds32-tdep.c (nds32_type_align): Delete.
4817         (nds32_push_dummy_call): Use type_align instead.
4818
4819 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4820
4821         * arm-tdep.c (arm_type_align): Only handle vector override case.
4822         (arm_push_dummy_call): Use type_align.
4823         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4824
4825 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4826
4827         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4828         case.
4829         (pass_on_stack): Use type_align.
4830         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4831         function.
4832
4833 2019-04-23  Tom Tromey  <tromey@adacore.com>
4834
4835         * dwarf2read.c (line_header::file_name_at): Remove unused
4836         overload.
4837
4838 2019-04-23  Tom de Vries  <tdevries@suse.de>
4839
4840         PR gdb/24438
4841         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4842         invocation.
4843
4844
4845 2019-03-27  Ali Tamur  <tamur@google.com>
4846
4847         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4848         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4849         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4850         (dwarf_expr_context::get_addr_index): Likewise
4851         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4852         (symbol_needs_eval_context::get_addr_index): Likewise
4853         (disassemble_dwarf_expression): Add DW_OP_addrx
4854         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4855         (read_cutu_die_from_dwo): Update comment
4856         (skip_one_die): Add DW_FORM_addrx
4857         (read_attribute_value): Likewise
4858         (var_decode_location): Add DW_OP_addrx
4859         (dwarf2_const_value_attr): Add DW_FORM_addrx
4860         (dump_die_shallow): Likewise
4861         (dwarf2_fetch_constant_bytes): Likewise
4862         (decode_locdesc): Add DW_OP_addrx
4863         (skip_form_bytes): Add DW_FORM_addrx
4864
4865 2019-04-22  Ali Tamur  <tamur@google.com>
4866
4867         * MAINTAINERS (Write After Approval): Add self.
4868
4869 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4870
4871         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4872         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4873         (open_symbol_file_object): Likewise.
4874         (svr4_default_sos): Add info parameter.
4875         (svr4_read_so_list): Likewise.
4876         (svr4_current_sos_direct): Adjust functions calls to pass down
4877         info.
4878         (svr4_current_sos_1): Add info parameter.
4879         (svr4_current_sos): Call get_svr4_info, pass info down to
4880         svr4_current_sos_1.
4881         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4882         get_svr4_info.
4883         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4884         get_svr4_info.
4885         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4886         to get_svr4_info.
4887         (probes_table_remove_objfile_probes): Likewise.
4888         (register_solib_event_probe): Add info parameter.
4889         (solist_update_incremental): Pass info parameter down to
4890         svr4_read_so_list.
4891         (disable_probes_interface): Add info parameter.
4892         (svr4_handle_solib_event): Pass current_program_space to
4893         get_svr4_info.  Adjust disable_probes_interface cleanup.
4894         (svr4_create_probe_breakpoints): Add info parameter, pass it
4895         down to register_solib_event_probe.
4896         (svr4_create_solib_event_breakpoints): Add info parameter,
4897         pass it down to svr4_create_probe_breakpoints.
4898         (enable_break): Pass info down to
4899         svr4_create_solib_event_breakpoints.
4900         (svr4_solib_create_inferior_hook): Pass current_program_space to
4901         get_svr4_info.
4902         (svr4_clear_solib): Likewise.
4903
4904 2019-04-22  Pedro Alves  <palves@redhat.com>
4905
4906         * solib-svr4.c (svr4_free_objfile_observer): New.
4907         (probe_and_action::objfile): New field.
4908         (probes_table_htab_remove_objfile_probes)
4909         (probes_table_remove_objfile_probes): New functions.
4910         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4911         in the new probe_and_action.  Don't store the probe in 'lookup'.
4912         (svr4_create_probe_breakpoints): Pass objfile to
4913         register_solib_event_probe.
4914         (_initialize_svr4_solib): Register a free_objfile observer.
4915
4916 2019-04-19  Tom Tromey  <tom@tromey.com>
4917
4918         * common/queue.h: Remove.
4919
4920 2019-04-19  Tom Tromey  <tom@tromey.com>
4921
4922         * event-loop.c: Don't include "common/queue.h".
4923
4924 2019-04-19  Tom Tromey  <tom@tromey.com>
4925
4926         * remote.c (remote_target): Use delete.
4927         * remote-notif.h: Include <list>, not "common/queue.h".
4928         (notif_client_p): Remove typedef.
4929         (remote_notif_state): Add constructor, destructor, initializer.
4930         <notif_queue>: Now a std::list.
4931         (remote_notif_state_xfree): Don't declare.
4932         * remote-notif.c (remote_notif_process, handle_notification)
4933         (remote_notif_state_allocate): Update.
4934         (~remote_notif_state): Rename from remote_notif_state_xfree.
4935
4936 2019-04-19  Tom Tromey  <tom@tromey.com>
4937
4938         * symfile.c (reread_symbols): Update.
4939         * objfiles.c (objfile_register_static_link)
4940         (objfile_lookup_static_link): Update
4941         (~objfile) Don't delete static_links.
4942         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4943
4944 2019-04-19  Tom Tromey  <tom@tromey.com>
4945
4946         * type-stack.h (struct type_stack) <insert>: Constify string.
4947         * type-stack.c (type_stack::insert): Constify string.
4948         * gdbtypes.h (lookup_template_type): Update.
4949         (address_space_name_to_int): Update.
4950         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4951         const.
4952         (lookup_template_type): Make name const.
4953         * c-exp.y: Update rules.
4954         (lex_one_token, classify_name, classify_inner_name)
4955         (c_print_token): Update.
4956         * p-exp.y: Update rules.
4957         (yylex): Update.
4958         * f-exp.y: Update rules.
4959         (yylex): Update.
4960         * d-exp.y: Update rules.
4961         (lex_one_token, classify_name, classify_inner_name): Update.
4962         * parse.c (write_dollar_variable, copy_name): Return std::string.
4963         * parser-defs.h (copy_name): Change return type.
4964         * m2-exp.y: Update rules.
4965         (yylex): Update.
4966         * go-exp.y (lex_one_token): Update.
4967         Update rules.
4968         (classify_unsafe_function, classify_packaged_name)
4969         (classify_name, yylex): Update.
4970
4971 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4972
4973         * configure.ac: add --enable-source-highlight switch.
4974         * configure: Regenerate.
4975         * top.c (print_gdb_version): plumb --enable-source-highlight
4976         status to "show configuration".
4977
4978 2019-04-19  Tom Tromey  <tromey@adacore.com>
4979
4980         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4981         Check ADA_TYPE_P.
4982         (empty_record, ada_template_to_fixed_record_type_1)
4983         (template_to_static_fixed_type)
4984         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4985         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4986         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4987         macros.
4988
4989 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4990
4991         PR symtab/24423:
4992         * source.c (print_source_lines_base): Advance "iter" when a
4993         control character is seen.
4994
4995 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4996
4997         * inferior.h (struct infcall_suspend_state_deleter):
4998         Catch exception in destructor to avoid crash.
4999
5000 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5001
5002         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5003         close to the add_com "shell".
5004
5005 2019-04-18  Tom Tromey  <tromey@adacore.com>
5006
5007         * process-stratum-target.h (class process_stratum_target)
5008         <stratum>: Add "final".
5009
5010 2019-04-17  Tom Tromey  <tromey@adacore.com>
5011
5012         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5013         against nullptr before use.
5014
5015 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5016
5017         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5018
5019 2019-04-17  Jim Wilson  <jimw@sifive.com>
5020             Andrew Burgess  <andrew.burgess@embecosm.com>
5021
5022         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5023         code read might fail, assume 4-byte breakpoint in that case.
5024
5025 2019-04-15  Leszek Swirski  <leszeks@google.com>
5026
5027         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5028         rather than a hand-rolled POD check when checking for forced MEMORY
5029         classification.
5030
5031 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5032
5033         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5034         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5035         function.
5036         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5037         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5038         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5039         declaration.
5040
5041 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5042
5043         * aarch64-linux-nat.c
5044         (aarch64_linux_nat_target::thread_architecture): Add override.
5045         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5046         each VQ.
5047
5048 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5049
5050         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5051
5052 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5053
5054         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5055         target types of size 96-bits, add some additional comments, and
5056         check that the builtin type we found was the correct size.
5057
5058 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5059
5060         * utils.c (prompt_for_continue): Don't restore the styling at the
5061         end, as applied_style has the wrong value.  This fixes styling in
5062         long lists of file names that are interrupted by the "Continue?"
5063         prompt.
5064
5065 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5066
5067         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5068         * c-lang.c (c_language_defn): Likewise.
5069         (cplus_language_defn): Likewise.
5070         (asm_language_defn): Likewise.
5071         (minimal_language_defn): Likewise.
5072         * d-lang.c (d_language_defn): Likewise.
5073         * f-lang.c (f_language_defn): Likewise.
5074         * go-lang.c (go_language_defn): Likewise.
5075         * language.c (unknown_language_defn): Likewise.
5076         (auto_language_defn): Likewise.
5077         * language.h (struct language_defn): Remove la_magic field.
5078         (LANG_MAGIC): Delete.
5079         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5080         * objc-lang.c (objc_language_defn): Likewise.
5081         * opencl-lang.c (opencl_language_defn): Likewise.
5082         * p-lang.c (pascal_language_defn): Likewise.
5083         * rust-lang.c (rust_language_defn): Likewise.
5084
5085 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5086
5087         * riscv-tdep.c (riscv_type_align): New function.
5088         (riscv_type_alignment): Delete.
5089         (riscv_arg_location): Use 'type_align'.
5090         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5091
5092 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5093
5094         * gdbtypes.c (type_align): A struct with no non-static fields also
5095         has alignment of 1.
5096
5097 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5098
5099         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5100         component to 0.
5101         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5102         member.
5103         (riscv_struct_info::analyse): New implementation using new
5104         analyse_inner member function.
5105         (riscv_struct_info::field_offset): New member function.
5106         (riscv_struct_info::m_offsets): New member variable.
5107         (riscv_struct_info::analyse_inner): New private member function,
5108         takes the old implementation of riscv_struct_info::analyse but
5109         extended to track field offsets.
5110         (riscv_call_arg_struct): Update the struct folding special cases
5111         to handle cases where empty C++ structs, which are non-zero
5112         length, are found.
5113         (riscv_arg_location): Initialise the length of each location, a
5114         non-zero length now indicates the location is in use.
5115         (riscv_push_dummy_call): Allow for the first location having a
5116         non-zero offset when setting up arguments.
5117         (riscv_return_value): Likewise, but for return values.
5118
5119 2019-04-11  Tom Tromey  <tromey@adacore.com>
5120
5121         * utils.c (internal_vproblem): Make "msg" const.
5122
5123 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5124
5125         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5126         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5127         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5128         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5129
5130 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5131
5132         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5133         function.
5134         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5135         of amd64_collect_native_gregset.
5136         (amd64_linux_nat_target::store_registers): Likewise.
5137
5138 2019-04-10  Tom Tromey  <tom@tromey.com>
5139
5140         * symtab.c (lookup_global_symbol_from_objfile)
5141         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5142         * objfiles.h (class separate_debug_iterator): New.
5143         (class separate_debug_range): New.
5144         (struct objfile) <separate_debug_objfiles>: New method.
5145         (objfile_separate_debug_iterate): Don't declare.
5146         * objfiles.c (separate_debug_iterator::operator++): Rename from
5147         objfile_separate_debug_iterate.
5148         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5149         iterator.
5150         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5151         iterator.
5152
5153 2019-04-10  Tom Tromey  <tom@tromey.com>
5154
5155         * symfile.c (reread_symbols): Remove old comment.
5156         * objfiles.c (free_all_objfiles): Fix a typo.
5157
5158 2019-04-10  Tom Tromey  <tom@tromey.com>
5159
5160         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5161         * minsyms.c (lookup_minimal_symbol): Use foreach.
5162         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5163         (lookup_minimal_symbol_solib_trampoline): Likewise.
5164         * symfile.c (reread_symbols): Use foreach.
5165
5166 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5167             Tom Tromey  <tromey@adacore.com>
5168
5169         PR rust/24414:
5170         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5171         (rust_lex_int_test): Change "value" to be LONGEST.
5172         (rust_lex_tests): Add test for long integer literal.
5173
5174 2019-04-09  Tom Tromey  <tromey@adacore.com>
5175
5176         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5177         to bool.
5178         (extended_remote_target::attach): Update.
5179         (remote_target::remote_notice_new_inferior): Update.
5180         (remote_target::add_current_inferior_and_thread): Update.
5181         * inferior.c (exit_inferior_1): Use "false".
5182         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5183
5184 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5185
5186         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5187         the "start" command.
5188
5189 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5190
5191         * python/py-inferior.c (infpy_thread_from_thread_handle):
5192         Adjust comments to reflect renaming of thread_from_thread_handle
5193         to thread_from_handle.  Adjust keywords.  Fix type error message.
5194         (inferior_object_methods): Add thread_from_handle.  Retain
5195         thread_from_thread_handle, but mark it as deprecated.
5196
5197 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5198
5199         * gdbthread.h (find_thread_by_handle): Revise declaration.
5200         * thread.c (find_thread_by_handle): Likewise.  Adjust
5201         implementation too.
5202         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5203         support for buffer objects as handles.
5204
5205 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5206
5207         * python/py-infthread.c (thpy_thread_handle): New function.
5208         (thread_object_methods): Register thpy_thread_handle.
5209
5210 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5211
5212         * gdbthread.h (thread_to_thread_handle): Declare.
5213         * thread.c (gdbtypes.h): Include.
5214         (thread_to_thread_handle): New function.
5215
5216         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5217         (target_thread_info_to_thread_handle): Declare.
5218         * target.c (target_thread_info_to_thread_handle): New function.
5219         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5220         * target-delegates.c: Regenerate.
5221
5222         * linux-thread-db.c (class thread_db_target): Add method
5223         thread_info_to_thread_handle.
5224         (thread_db_target::thread_info_to_thread_handle): Define.
5225         * remote.c (class remote_target): Add new method
5226         thread_info_to_thread_handle.
5227         (remote_target::thread_info_to_thread_handle): Define.
5228
5229 2019-04-08  Pedro Alves  <palves@redhat.com>
5230
5231         * common/common-exceptions.c (throw_exception): Don't create
5232         named object to throw; throw directly.
5233         (throw_it): Likewise.  Don't initialize gdb_exception::message
5234         here, with new; pass FMT and AP to the ctor instead.
5235         * common/common-exceptions.h: Include <string>.
5236         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5237         const char *, va_list)): New ctor.  Use std::make_shared.
5238         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5239         errors)): Delete.
5240         (gdb_exception_error::gdb_exception_error(enum errors, const char
5241         *, va_list)): New.
5242         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5243         Add assertion.
5244         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5245         errors)): Delete.
5246         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5247         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5248         Add assertion.
5249
5250 2019-04-08  Tom Tromey  <tom@tromey.com>
5251
5252         * valops.c (value_rtti_indirect_type): Replace throw_exception
5253         with throw.
5254         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5255         with throw.
5256         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5257         throw.
5258         * target.c (target_translate_tls_address): Replace throw_exception
5259         with throw.
5260         * stack.c (frame_apply_command_count): Replace throw_exception
5261         with throw.
5262         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5263         throw.
5264         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5265         with throw.
5266         * rs6000-tdep.c (rs6000_frame_cache)
5267         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5268         * remote.c: Replace throw_exception with throw.
5269         * record-full.c (record_full_message, record_full_wait_1)
5270         (record_full_restore): Replace throw_exception with throw.
5271         * record-btrace.c:
5272         (get_thread_current_frame_id, record_btrace_start_replaying)
5273         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5274         (cmd_record_btrace_start): Replace throw_exception with throw.
5275         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5276         throw.
5277         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5278         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5279         * linespec.c:
5280         (find_linespec_symbols): Replace throw_exception with throw.
5281         * infrun.c (displaced_step_prepare, resume): Replace
5282         throw_exception with throw.
5283         * infcmd.c (post_create_inferior): Replace throw_exception with
5284         throw.
5285         * inf-loop.c (inferior_event_handler): Replace throw_exception
5286         with throw.
5287         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5288         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5289         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5290         (get_prev_frame_always, get_frame_pc_if_available)
5291         (get_frame_address_in_block_if_available, get_frame_language):
5292         Replace throw_exception with throw.
5293         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5294         throw_exception with throw.
5295         * eval.c (fetch_subexp_value, evaluate_var_value)
5296         (evaluate_funcall, evaluate_subexp_standard): Replace
5297         throw_exception with throw.
5298         * dwarf2loc.c (call_site_find_chain)
5299         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5300         Replace throw_exception with throw.
5301         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5302         with throw.
5303         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5304         throw.
5305         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5306         * completer.c (complete_line_internal): Replace throw_exception
5307         with throw.
5308         * compile/compile-object-run.c (compile_object_run): Replace
5309         throw_exception with throw.
5310         * cli/cli-script.c (process_next_line): Replace throw_exception
5311         with throw.
5312         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5313         (btrace_enable, btrace_maint_update_pt_packets): Replace
5314         throw_exception with throw.
5315         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5316         throw_exception with throw.
5317         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5318         throw_exception with throw.
5319         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5320         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5321         * aarch64-tdep.c (aarch64_make_prologue_cache)
5322         (aarch64_make_stub_cache): Replace throw_exception with throw.
5323
5324 2019-04-08  Tom Tromey  <tom@tromey.com>
5325
5326         * common/common-exceptions.c (throw_exception): Rename from
5327         throw_exception_cxx.  Remove old copy.  Make argument const.
5328         (throw_it): Create and throw exception objects directly.
5329         * common/common-exceptions.h (throw_exception): Make argument
5330         const.
5331         (struct gdb_exception_error): Add constructor.
5332         (struct gdb_exception_quit): Add constructor.
5333
5334 2019-04-08  Tom Tromey  <tom@tromey.com>
5335
5336         * common/common-exceptions.h (exception_rethrow): Don't declare.
5337         (TRY_SJLJ): Update comment.
5338         (TRY, CATCH, END_CATCH): Remove.
5339         * common/common-exceptions.c (exception_rethrow): Remove.
5340
5341 2019-04-08  Tom Tromey  <tom@tromey.com>
5342
5343         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5344         Remove.
5345         (gdb_exception_error): Rename from
5346         gdb_exception_RETURN_MASK_ERROR.
5347         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5348         (gdb_quit_bad_alloc): Update.
5349         * aarch64-tdep.c: Update.
5350         * ada-lang.c: Update.
5351         * ada-typeprint.c: Update.
5352         * ada-valprint.c: Update.
5353         * amd64-tdep.c: Update.
5354         * arch-utils.c: Update.
5355         * break-catch-throw.c: Update.
5356         * breakpoint.c: Update.
5357         * btrace.c: Update.
5358         * c-varobj.c: Update.
5359         * cli/cli-cmds.c: Update.
5360         * cli/cli-interp.c: Update.
5361         * cli/cli-script.c: Update.
5362         * common/common-exceptions.c: Update.
5363         * common/new-op.c: Update.
5364         * common/selftest.c: Update.
5365         * compile/compile-c-symbols.c: Update.
5366         * compile/compile-cplus-symbols.c: Update.
5367         * compile/compile-object-load.c: Update.
5368         * compile/compile-object-run.c: Update.
5369         * completer.c: Update.
5370         * corelow.c: Update.
5371         * cp-abi.c: Update.
5372         * cp-support.c: Update.
5373         * cp-valprint.c: Update.
5374         * darwin-nat.c: Update.
5375         * disasm-selftests.c: Update.
5376         * dtrace-probe.c: Update.
5377         * dwarf-index-cache.c: Update.
5378         * dwarf-index-write.c: Update.
5379         * dwarf2-frame-tailcall.c: Update.
5380         * dwarf2-frame.c: Update.
5381         * dwarf2loc.c: Update.
5382         * dwarf2read.c: Update.
5383         * eval.c: Update.
5384         * event-loop.c: Update.
5385         * event-top.c: Update.
5386         * exec.c: Update.
5387         * f-valprint.c: Update.
5388         * fbsd-tdep.c: Update.
5389         * frame-unwind.c: Update.
5390         * frame.c: Update.
5391         * gdbtypes.c: Update.
5392         * gnu-v3-abi.c: Update.
5393         * guile/guile-internal.h: Update.
5394         * guile/scm-block.c: Update.
5395         * guile/scm-breakpoint.c: Update.
5396         * guile/scm-cmd.c: Update.
5397         * guile/scm-disasm.c: Update.
5398         * guile/scm-frame.c: Update.
5399         * guile/scm-lazy-string.c: Update.
5400         * guile/scm-math.c: Update.
5401         * guile/scm-param.c: Update.
5402         * guile/scm-ports.c: Update.
5403         * guile/scm-pretty-print.c: Update.
5404         * guile/scm-symbol.c: Update.
5405         * guile/scm-symtab.c: Update.
5406         * guile/scm-type.c: Update.
5407         * guile/scm-value.c: Update.
5408         * i386-linux-tdep.c: Update.
5409         * i386-tdep.c: Update.
5410         * inf-loop.c: Update.
5411         * infcall.c: Update.
5412         * infcmd.c: Update.
5413         * infrun.c: Update.
5414         * jit.c: Update.
5415         * language.c: Update.
5416         * linespec.c: Update.
5417         * linux-fork.c: Update.
5418         * linux-nat.c: Update.
5419         * linux-tdep.c: Update.
5420         * linux-thread-db.c: Update.
5421         * main.c: Update.
5422         * mi/mi-cmd-break.c: Update.
5423         * mi/mi-cmd-stack.c: Update.
5424         * mi/mi-interp.c: Update.
5425         * mi/mi-main.c: Update.
5426         * objc-lang.c: Update.
5427         * p-valprint.c: Update.
5428         * parse.c: Update.
5429         * ppc-linux-tdep.c: Update.
5430         * printcmd.c: Update.
5431         * python/py-arch.c: Update.
5432         * python/py-breakpoint.c: Update.
5433         * python/py-cmd.c: Update.
5434         * python/py-finishbreakpoint.c: Update.
5435         * python/py-frame.c: Update.
5436         * python/py-framefilter.c: Update.
5437         * python/py-gdb-readline.c: Update.
5438         * python/py-inferior.c: Update.
5439         * python/py-infthread.c: Update.
5440         * python/py-lazy-string.c: Update.
5441         * python/py-linetable.c: Update.
5442         * python/py-objfile.c: Update.
5443         * python/py-param.c: Update.
5444         * python/py-prettyprint.c: Update.
5445         * python/py-progspace.c: Update.
5446         * python/py-record-btrace.c: Update.
5447         * python/py-record.c: Update.
5448         * python/py-symbol.c: Update.
5449         * python/py-type.c: Update.
5450         * python/py-unwind.c: Update.
5451         * python/py-utils.c: Update.
5452         * python/py-value.c: Update.
5453         * python/python.c: Update.
5454         * record-btrace.c: Update.
5455         * record-full.c: Update.
5456         * remote-fileio.c: Update.
5457         * remote.c: Update.
5458         * riscv-tdep.c: Update.
5459         * rs6000-aix-tdep.c: Update.
5460         * rs6000-tdep.c: Update.
5461         * rust-exp.y: Update.
5462         * rust-lang.c: Update.
5463         * s390-tdep.c: Update.
5464         * selftest-arch.c: Update.
5465         * solib-dsbt.c: Update.
5466         * solib-frv.c: Update.
5467         * solib-spu.c: Update.
5468         * solib-svr4.c: Update.
5469         * solib.c: Update.
5470         * sparc64-linux-tdep.c: Update.
5471         * stack.c: Update.
5472         * symfile-mem.c: Update.
5473         * symmisc.c: Update.
5474         * target.c: Update.
5475         * thread.c: Update.
5476         * top.c: Update.
5477         * tracefile-tfile.c: Update.
5478         * tui/tui.c: Update.
5479         * typeprint.c: Update.
5480         * unittests/cli-utils-selftests.c: Update.
5481         * unittests/parse-connection-spec-selftests.c: Update.
5482         * valops.c: Update.
5483         * valprint.c: Update.
5484         * value.c: Update.
5485         * varobj.c: Update.
5486         * windows-nat.c: Update.
5487         * x86-linux-nat.c: Update.
5488         * xml-support.c: Update.
5489
5490 2019-04-08  Tom Tromey  <tom@tromey.com>
5491
5492         * xml-support.c: Use C++ exception handling.
5493         * x86-linux-nat.c: Use C++ exception handling.
5494         * windows-nat.c: Use C++ exception handling.
5495         * varobj.c: Use C++ exception handling.
5496         * value.c: Use C++ exception handling.
5497         * valprint.c: Use C++ exception handling.
5498         * valops.c: Use C++ exception handling.
5499         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5500         handling.
5501         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5502         * typeprint.c: Use C++ exception handling.
5503         * tui/tui.c: Use C++ exception handling.
5504         * tracefile-tfile.c: Use C++ exception handling.
5505         * top.c: Use C++ exception handling.
5506         * thread.c: Use C++ exception handling.
5507         * target.c: Use C++ exception handling.
5508         * symmisc.c: Use C++ exception handling.
5509         * symfile-mem.c: Use C++ exception handling.
5510         * stack.c: Use C++ exception handling.
5511         * sparc64-linux-tdep.c: Use C++ exception handling.
5512         * solib.c: Use C++ exception handling.
5513         * solib-svr4.c: Use C++ exception handling.
5514         * solib-spu.c: Use C++ exception handling.
5515         * solib-frv.c: Use C++ exception handling.
5516         * solib-dsbt.c: Use C++ exception handling.
5517         * selftest-arch.c: Use C++ exception handling.
5518         * s390-tdep.c: Use C++ exception handling.
5519         * rust-lang.c: Use C++ exception handling.
5520         * rust-exp.y: Use C++ exception handling.
5521         * rs6000-tdep.c: Use C++ exception handling.
5522         * rs6000-aix-tdep.c: Use C++ exception handling.
5523         * riscv-tdep.c: Use C++ exception handling.
5524         * remote.c: Use C++ exception handling.
5525         * remote-fileio.c: Use C++ exception handling.
5526         * record-full.c: Use C++ exception handling.
5527         * record-btrace.c: Use C++ exception handling.
5528         * python/python.c: Use C++ exception handling.
5529         * python/py-value.c: Use C++ exception handling.
5530         * python/py-utils.c: Use C++ exception handling.
5531         * python/py-unwind.c: Use C++ exception handling.
5532         * python/py-type.c: Use C++ exception handling.
5533         * python/py-symbol.c: Use C++ exception handling.
5534         * python/py-record.c: Use C++ exception handling.
5535         * python/py-record-btrace.c: Use C++ exception handling.
5536         * python/py-progspace.c: Use C++ exception handling.
5537         * python/py-prettyprint.c: Use C++ exception handling.
5538         * python/py-param.c: Use C++ exception handling.
5539         * python/py-objfile.c: Use C++ exception handling.
5540         * python/py-linetable.c: Use C++ exception handling.
5541         * python/py-lazy-string.c: Use C++ exception handling.
5542         * python/py-infthread.c: Use C++ exception handling.
5543         * python/py-inferior.c: Use C++ exception handling.
5544         * python/py-gdb-readline.c: Use C++ exception handling.
5545         * python/py-framefilter.c: Use C++ exception handling.
5546         * python/py-frame.c: Use C++ exception handling.
5547         * python/py-finishbreakpoint.c: Use C++ exception handling.
5548         * python/py-cmd.c: Use C++ exception handling.
5549         * python/py-breakpoint.c: Use C++ exception handling.
5550         * python/py-arch.c: Use C++ exception handling.
5551         * printcmd.c: Use C++ exception handling.
5552         * ppc-linux-tdep.c: Use C++ exception handling.
5553         * parse.c: Use C++ exception handling.
5554         * p-valprint.c: Use C++ exception handling.
5555         * objc-lang.c: Use C++ exception handling.
5556         * mi/mi-main.c: Use C++ exception handling.
5557         * mi/mi-interp.c: Use C++ exception handling.
5558         * mi/mi-cmd-stack.c: Use C++ exception handling.
5559         * mi/mi-cmd-break.c: Use C++ exception handling.
5560         * main.c: Use C++ exception handling.
5561         * linux-thread-db.c: Use C++ exception handling.
5562         * linux-tdep.c: Use C++ exception handling.
5563         * linux-nat.c: Use C++ exception handling.
5564         * linux-fork.c: Use C++ exception handling.
5565         * linespec.c: Use C++ exception handling.
5566         * language.c: Use C++ exception handling.
5567         * jit.c: Use C++ exception handling.
5568         * infrun.c: Use C++ exception handling.
5569         * infcmd.c: Use C++ exception handling.
5570         * infcall.c: Use C++ exception handling.
5571         * inf-loop.c: Use C++ exception handling.
5572         * i386-tdep.c: Use C++ exception handling.
5573         * i386-linux-tdep.c: Use C++ exception handling.
5574         * guile/scm-value.c: Use C++ exception handling.
5575         * guile/scm-type.c: Use C++ exception handling.
5576         * guile/scm-symtab.c: Use C++ exception handling.
5577         * guile/scm-symbol.c: Use C++ exception handling.
5578         * guile/scm-pretty-print.c: Use C++ exception handling.
5579         * guile/scm-ports.c: Use C++ exception handling.
5580         * guile/scm-param.c: Use C++ exception handling.
5581         * guile/scm-math.c: Use C++ exception handling.
5582         * guile/scm-lazy-string.c: Use C++ exception handling.
5583         * guile/scm-frame.c: Use C++ exception handling.
5584         * guile/scm-disasm.c: Use C++ exception handling.
5585         * guile/scm-cmd.c: Use C++ exception handling.
5586         * guile/scm-breakpoint.c: Use C++ exception handling.
5587         * guile/scm-block.c: Use C++ exception handling.
5588         * guile/guile-internal.h: Use C++ exception handling.
5589         * gnu-v3-abi.c: Use C++ exception handling.
5590         * gdbtypes.c: Use C++ exception handling.
5591         * frame.c: Use C++ exception handling.
5592         * frame-unwind.c: Use C++ exception handling.
5593         * fbsd-tdep.c: Use C++ exception handling.
5594         * f-valprint.c: Use C++ exception handling.
5595         * exec.c: Use C++ exception handling.
5596         * event-top.c: Use C++ exception handling.
5597         * event-loop.c: Use C++ exception handling.
5598         * eval.c: Use C++ exception handling.
5599         * dwarf2read.c: Use C++ exception handling.
5600         * dwarf2loc.c: Use C++ exception handling.
5601         * dwarf2-frame.c: Use C++ exception handling.
5602         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5603         * dwarf-index-write.c: Use C++ exception handling.
5604         * dwarf-index-cache.c: Use C++ exception handling.
5605         * dtrace-probe.c: Use C++ exception handling.
5606         * disasm-selftests.c: Use C++ exception handling.
5607         * darwin-nat.c: Use C++ exception handling.
5608         * cp-valprint.c: Use C++ exception handling.
5609         * cp-support.c: Use C++ exception handling.
5610         * cp-abi.c: Use C++ exception handling.
5611         * corelow.c: Use C++ exception handling.
5612         * completer.c: Use C++ exception handling.
5613         * compile/compile-object-run.c: Use C++ exception handling.
5614         * compile/compile-object-load.c: Use C++ exception handling.
5615         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5616         * compile/compile-c-symbols.c: Use C++ exception handling.
5617         * common/selftest.c: Use C++ exception handling.
5618         * common/new-op.c: Use C++ exception handling.
5619         * cli/cli-script.c: Use C++ exception handling.
5620         * cli/cli-interp.c: Use C++ exception handling.
5621         * cli/cli-cmds.c: Use C++ exception handling.
5622         * c-varobj.c: Use C++ exception handling.
5623         * btrace.c: Use C++ exception handling.
5624         * breakpoint.c: Use C++ exception handling.
5625         * break-catch-throw.c: Use C++ exception handling.
5626         * arch-utils.c: Use C++ exception handling.
5627         * amd64-tdep.c: Use C++ exception handling.
5628         * ada-valprint.c: Use C++ exception handling.
5629         * ada-typeprint.c: Use C++ exception handling.
5630         * ada-lang.c: Use C++ exception handling.
5631         * aarch64-tdep.c: Use C++ exception handling.
5632
5633 2019-04-08  Tom Tromey  <tom@tromey.com>
5634
5635         * xml-support.c (gdb_xml_parser::parse): Update.
5636         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5637         * value.c (show_convenience): Update.
5638         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5639         (test_parse_flags_qcs): Update.
5640         * thread.c (thr_try_catch_cmd): Update.
5641         * target.c (target_translate_tls_address): Update.
5642         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5643         (info_frame_command_core, frame_apply_command_count): Update.
5644         * rust-exp.y (rust_lex_exception_test): Update.
5645         * riscv-tdep.c (riscv_print_one_register_info): Update.
5646         * remote.c (remote_target::enable_btrace): Update.
5647         * record-btrace.c (record_btrace_enable_warn): Update.
5648         * python/py-utils.c (gdbpy_convert_exception): Update.
5649         * printcmd.c (do_one_display, print_variable_and_value): Update.
5650         * mi/mi-main.c (mi_print_exception): Update.
5651         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5652         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5653         * linux-nat.c (linux_nat_target::attach): Update.
5654         * linux-fork.c (class scoped_switch_fork_info): Update.
5655         * infrun.c (displaced_step_prepare): Update.
5656         * infcall.c (call_function_by_hand_dummy): Update.
5657         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5658         * gnu-v3-abi.c (print_one_vtable): Update.
5659         * frame.c (get_prev_frame_always): Update.
5660         * f-valprint.c (info_common_command_for_block): Update.
5661         * exec.c (try_open_exec_file): Update.
5662         * exceptions.c (print_exception, exception_print)
5663         (exception_fprintf, exception_print_same): Update.
5664         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5665         * dwarf-index-cache.c (index_cache::store)
5666         (index_cache::lookup_gdb_index): Update.
5667         * darwin-nat.c (maybe_cache_shell): Update.
5668         * cp-valprint.c (cp_print_value_fields): Update.
5669         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5670         (gcc_cplus_symbol_address): Update.
5671         * compile/compile-c-symbols.c (gcc_convert_symbol)
5672         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5673         * common/selftest.c: Update.
5674         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5675         a std::string.
5676         (exception_try_scope_entry, exception_try_scope_exit): Don't
5677         declare.
5678         (struct exception_try_scope): Remove.
5679         (TRY): Don't use exception_try_scope.
5680         (struct gdb_exception): Add constructor, operator=.
5681         <what>: New method.
5682         (struct gdb_exception_RETURN_MASK_ALL)
5683         (struct gdb_exception_RETURN_MASK_ERROR)
5684         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5685         (struct gdb_quit_bad_alloc): Update.
5686         * common/common-exceptions.c (exception_none): Change
5687         initializer.
5688         (struct catcher) <state, exception>: Initialize inline.
5689         <prev>: Remove member.
5690         (current_catcher): Remove.
5691         (catchers): New global.
5692         (exceptions_state_mc_init): Simplify.
5693         (catcher_pop): Remove.
5694         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5695         (try_scope_depth, exception_try_scope_entry)
5696         (exception_try_scope_exit): Remove.
5697         (throw_exception_sjlj): Update.
5698         (exception_messages, exception_messages_size): Remove.
5699         (throw_it): Simplify.
5700         (gdb_exception_sliced_copy): Remove.
5701         (throw_exception_cxx): Update.
5702         * cli/cli-script.c (script_from_file): Update.
5703         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5704         Update.
5705         * ada-valprint.c (ada_val_print): Update.
5706         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5707         (create_excep_cond_exprs): Update.
5708
5709 2019-04-08  Tom Tromey  <tom@tromey.com>
5710
5711         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5712         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5713         (TRY, CATCH, END_CATCH): Remove some definitions.
5714         * common/common-exceptions.c: Don't use GDB_XCPT.
5715         (catcher_list_size): Remove.
5716         (throw_exception, throw_it): Simplify.
5717
5718 2019-04-05  Tom Tromey  <tom@tromey.com>
5719
5720         Revert the header-sorting patch.
5721         * ft32-tdep.c: Revert.
5722         * frv-tdep.c: Revert.
5723         * frv-linux-tdep.c: Revert.
5724         * frame.c: Revert.
5725         * frame-unwind.c: Revert.
5726         * frame-base.c: Revert.
5727         * fork-child.c: Revert.
5728         * findvar.c: Revert.
5729         * findcmd.c: Revert.
5730         * filesystem.c: Revert.
5731         * filename-seen-cache.h: Revert.
5732         * filename-seen-cache.c: Revert.
5733         * fbsd-tdep.c: Revert.
5734         * fbsd-nat.h: Revert.
5735         * fbsd-nat.c: Revert.
5736         * f-valprint.c: Revert.
5737         * f-typeprint.c: Revert.
5738         * f-lang.c: Revert.
5739         * extension.h: Revert.
5740         * extension.c: Revert.
5741         * extension-priv.h: Revert.
5742         * expprint.c: Revert.
5743         * exec.h: Revert.
5744         * exec.c: Revert.
5745         * exceptions.c: Revert.
5746         * event-top.c: Revert.
5747         * event-loop.c: Revert.
5748         * eval.c: Revert.
5749         * elfread.c: Revert.
5750         * dwarf2read.h: Revert.
5751         * dwarf2read.c: Revert.
5752         * dwarf2loc.c: Revert.
5753         * dwarf2expr.h: Revert.
5754         * dwarf2expr.c: Revert.
5755         * dwarf2-frame.c: Revert.
5756         * dwarf2-frame-tailcall.c: Revert.
5757         * dwarf-index-write.h: Revert.
5758         * dwarf-index-write.c: Revert.
5759         * dwarf-index-common.c: Revert.
5760         * dwarf-index-cache.h: Revert.
5761         * dwarf-index-cache.c: Revert.
5762         * dummy-frame.c: Revert.
5763         * dtrace-probe.c: Revert.
5764         * disasm.h: Revert.
5765         * disasm.c: Revert.
5766         * disasm-selftests.c: Revert.
5767         * dictionary.c: Revert.
5768         * dicos-tdep.c: Revert.
5769         * demangle.c: Revert.
5770         * dcache.h: Revert.
5771         * dcache.c: Revert.
5772         * darwin-nat.h: Revert.
5773         * darwin-nat.c: Revert.
5774         * darwin-nat-info.c: Revert.
5775         * d-valprint.c: Revert.
5776         * d-namespace.c: Revert.
5777         * d-lang.c: Revert.
5778         * ctf.c: Revert.
5779         * csky-tdep.c: Revert.
5780         * csky-linux-tdep.c: Revert.
5781         * cris-tdep.c: Revert.
5782         * cris-linux-tdep.c: Revert.
5783         * cp-valprint.c: Revert.
5784         * cp-support.c: Revert.
5785         * cp-namespace.c: Revert.
5786         * cp-abi.c: Revert.
5787         * corelow.c: Revert.
5788         * corefile.c: Revert.
5789         * continuations.c: Revert.
5790         * completer.h: Revert.
5791         * completer.c: Revert.
5792         * complaints.c: Revert.
5793         * coffread.c: Revert.
5794         * coff-pe-read.c: Revert.
5795         * cli-out.h: Revert.
5796         * cli-out.c: Revert.
5797         * charset.c: Revert.
5798         * c-varobj.c: Revert.
5799         * c-valprint.c: Revert.
5800         * c-typeprint.c: Revert.
5801         * c-lang.c: Revert.
5802         * buildsym.c: Revert.
5803         * buildsym-legacy.c: Revert.
5804         * build-id.h: Revert.
5805         * build-id.c: Revert.
5806         * btrace.c: Revert.
5807         * bsd-uthread.c: Revert.
5808         * breakpoint.h: Revert.
5809         * breakpoint.c: Revert.
5810         * break-catch-throw.c: Revert.
5811         * break-catch-syscall.c: Revert.
5812         * break-catch-sig.c: Revert.
5813         * blockframe.c: Revert.
5814         * block.c: Revert.
5815         * bfin-tdep.c: Revert.
5816         * bfin-linux-tdep.c: Revert.
5817         * bfd-target.c: Revert.
5818         * bcache.c: Revert.
5819         * ax-general.c: Revert.
5820         * ax-gdb.h: Revert.
5821         * ax-gdb.c: Revert.
5822         * avr-tdep.c: Revert.
5823         * auxv.c: Revert.
5824         * auto-load.c: Revert.
5825         * arm-wince-tdep.c: Revert.
5826         * arm-tdep.c: Revert.
5827         * arm-symbian-tdep.c: Revert.
5828         * arm-pikeos-tdep.c: Revert.
5829         * arm-obsd-tdep.c: Revert.
5830         * arm-nbsd-tdep.c: Revert.
5831         * arm-nbsd-nat.c: Revert.
5832         * arm-linux-tdep.c: Revert.
5833         * arm-linux-nat.c: Revert.
5834         * arm-fbsd-tdep.c: Revert.
5835         * arm-fbsd-nat.c: Revert.
5836         * arm-bsd-tdep.c: Revert.
5837         * arch-utils.c: Revert.
5838         * arc-tdep.c: Revert.
5839         * arc-newlib-tdep.c: Revert.
5840         * annotate.h: Revert.
5841         * annotate.c: Revert.
5842         * amd64-windows-tdep.c: Revert.
5843         * amd64-windows-nat.c: Revert.
5844         * amd64-tdep.c: Revert.
5845         * amd64-sol2-tdep.c: Revert.
5846         * amd64-obsd-tdep.c: Revert.
5847         * amd64-obsd-nat.c: Revert.
5848         * amd64-nbsd-tdep.c: Revert.
5849         * amd64-nbsd-nat.c: Revert.
5850         * amd64-nat.c: Revert.
5851         * amd64-linux-tdep.c: Revert.
5852         * amd64-linux-nat.c: Revert.
5853         * amd64-fbsd-tdep.c: Revert.
5854         * amd64-fbsd-nat.c: Revert.
5855         * amd64-dicos-tdep.c: Revert.
5856         * amd64-darwin-tdep.c: Revert.
5857         * amd64-bsd-nat.c: Revert.
5858         * alpha-tdep.c: Revert.
5859         * alpha-obsd-tdep.c: Revert.
5860         * alpha-nbsd-tdep.c: Revert.
5861         * alpha-mdebug-tdep.c: Revert.
5862         * alpha-linux-tdep.c: Revert.
5863         * alpha-linux-nat.c: Revert.
5864         * alpha-bsd-tdep.c: Revert.
5865         * alpha-bsd-nat.c: Revert.
5866         * aix-thread.c: Revert.
5867         * agent.c: Revert.
5868         * addrmap.c: Revert.
5869         * ada-varobj.c: Revert.
5870         * ada-valprint.c: Revert.
5871         * ada-typeprint.c: Revert.
5872         * ada-tasks.c: Revert.
5873         * ada-lang.c: Revert.
5874         * aarch64-tdep.c: Revert.
5875         * aarch64-ravenscar-thread.c: Revert.
5876         * aarch64-newlib-tdep.c: Revert.
5877         * aarch64-linux-tdep.c: Revert.
5878         * aarch64-linux-nat.c: Revert.
5879         * aarch64-fbsd-tdep.c: Revert.
5880         * aarch64-fbsd-nat.c: Revert.
5881         * aarch32-linux-nat.c: Revert.
5882
5883 2019-04-05  Tom Tromey  <tom@tromey.com>
5884
5885         * ft32-tdep.c: Sort headers.
5886         * frv-tdep.c: Sort headers.
5887         * frv-linux-tdep.c: Sort headers.
5888         * frame.c: Sort headers.
5889         * frame-unwind.c: Sort headers.
5890         * frame-base.c: Sort headers.
5891         * fork-child.c: Sort headers.
5892         * findvar.c: Sort headers.
5893         * findcmd.c: Sort headers.
5894         * filesystem.c: Sort headers.
5895         * filename-seen-cache.h: Sort headers.
5896         * filename-seen-cache.c: Sort headers.
5897         * fbsd-tdep.c: Sort headers.
5898         * fbsd-nat.h: Sort headers.
5899         * fbsd-nat.c: Sort headers.
5900         * f-valprint.c: Sort headers.
5901         * f-typeprint.c: Sort headers.
5902         * f-lang.c: Sort headers.
5903         * extension.h: Sort headers.
5904         * extension.c: Sort headers.
5905         * extension-priv.h: Sort headers.
5906         * expprint.c: Sort headers.
5907         * exec.h: Sort headers.
5908         * exec.c: Sort headers.
5909         * exceptions.c: Sort headers.
5910         * event-top.c: Sort headers.
5911         * event-loop.c: Sort headers.
5912         * eval.c: Sort headers.
5913         * elfread.c: Sort headers.
5914         * dwarf2read.h: Sort headers.
5915         * dwarf2read.c: Sort headers.
5916         * dwarf2loc.c: Sort headers.
5917         * dwarf2expr.h: Sort headers.
5918         * dwarf2expr.c: Sort headers.
5919         * dwarf2-frame.c: Sort headers.
5920         * dwarf2-frame-tailcall.c: Sort headers.
5921         * dwarf-index-write.h: Sort headers.
5922         * dwarf-index-write.c: Sort headers.
5923         * dwarf-index-common.c: Sort headers.
5924         * dwarf-index-cache.h: Sort headers.
5925         * dwarf-index-cache.c: Sort headers.
5926         * dummy-frame.c: Sort headers.
5927         * dtrace-probe.c: Sort headers.
5928         * disasm.h: Sort headers.
5929         * disasm.c: Sort headers.
5930         * disasm-selftests.c: Sort headers.
5931         * dictionary.c: Sort headers.
5932         * dicos-tdep.c: Sort headers.
5933         * demangle.c: Sort headers.
5934         * dcache.h: Sort headers.
5935         * dcache.c: Sort headers.
5936         * darwin-nat.h: Sort headers.
5937         * darwin-nat.c: Sort headers.
5938         * darwin-nat-info.c: Sort headers.
5939         * d-valprint.c: Sort headers.
5940         * d-namespace.c: Sort headers.
5941         * d-lang.c: Sort headers.
5942         * ctf.c: Sort headers.
5943         * csky-tdep.c: Sort headers.
5944         * csky-linux-tdep.c: Sort headers.
5945         * cris-tdep.c: Sort headers.
5946         * cris-linux-tdep.c: Sort headers.
5947         * cp-valprint.c: Sort headers.
5948         * cp-support.c: Sort headers.
5949         * cp-namespace.c: Sort headers.
5950         * cp-abi.c: Sort headers.
5951         * corelow.c: Sort headers.
5952         * corefile.c: Sort headers.
5953         * continuations.c: Sort headers.
5954         * completer.h: Sort headers.
5955         * completer.c: Sort headers.
5956         * complaints.c: Sort headers.
5957         * coffread.c: Sort headers.
5958         * coff-pe-read.c: Sort headers.
5959         * cli-out.h: Sort headers.
5960         * cli-out.c: Sort headers.
5961         * charset.c: Sort headers.
5962         * c-varobj.c: Sort headers.
5963         * c-valprint.c: Sort headers.
5964         * c-typeprint.c: Sort headers.
5965         * c-lang.c: Sort headers.
5966         * buildsym.c: Sort headers.
5967         * buildsym-legacy.c: Sort headers.
5968         * build-id.h: Sort headers.
5969         * build-id.c: Sort headers.
5970         * btrace.c: Sort headers.
5971         * bsd-uthread.c: Sort headers.
5972         * breakpoint.h: Sort headers.
5973         * breakpoint.c: Sort headers.
5974         * break-catch-throw.c: Sort headers.
5975         * break-catch-syscall.c: Sort headers.
5976         * break-catch-sig.c: Sort headers.
5977         * blockframe.c: Sort headers.
5978         * block.c: Sort headers.
5979         * bfin-tdep.c: Sort headers.
5980         * bfin-linux-tdep.c: Sort headers.
5981         * bfd-target.c: Sort headers.
5982         * bcache.c: Sort headers.
5983         * ax-general.c: Sort headers.
5984         * ax-gdb.h: Sort headers.
5985         * ax-gdb.c: Sort headers.
5986         * avr-tdep.c: Sort headers.
5987         * auxv.c: Sort headers.
5988         * auto-load.c: Sort headers.
5989         * arm-wince-tdep.c: Sort headers.
5990         * arm-tdep.c: Sort headers.
5991         * arm-symbian-tdep.c: Sort headers.
5992         * arm-pikeos-tdep.c: Sort headers.
5993         * arm-obsd-tdep.c: Sort headers.
5994         * arm-nbsd-tdep.c: Sort headers.
5995         * arm-nbsd-nat.c: Sort headers.
5996         * arm-linux-tdep.c: Sort headers.
5997         * arm-linux-nat.c: Sort headers.
5998         * arm-fbsd-tdep.c: Sort headers.
5999         * arm-fbsd-nat.c: Sort headers.
6000         * arm-bsd-tdep.c: Sort headers.
6001         * arch-utils.c: Sort headers.
6002         * arc-tdep.c: Sort headers.
6003         * arc-newlib-tdep.c: Sort headers.
6004         * annotate.h: Sort headers.
6005         * annotate.c: Sort headers.
6006         * amd64-windows-tdep.c: Sort headers.
6007         * amd64-windows-nat.c: Sort headers.
6008         * amd64-tdep.c: Sort headers.
6009         * amd64-sol2-tdep.c: Sort headers.
6010         * amd64-obsd-tdep.c: Sort headers.
6011         * amd64-obsd-nat.c: Sort headers.
6012         * amd64-nbsd-tdep.c: Sort headers.
6013         * amd64-nbsd-nat.c: Sort headers.
6014         * amd64-nat.c: Sort headers.
6015         * amd64-linux-tdep.c: Sort headers.
6016         * amd64-linux-nat.c: Sort headers.
6017         * amd64-fbsd-tdep.c: Sort headers.
6018         * amd64-fbsd-nat.c: Sort headers.
6019         * amd64-dicos-tdep.c: Sort headers.
6020         * amd64-darwin-tdep.c: Sort headers.
6021         * amd64-bsd-nat.c: Sort headers.
6022         * alpha-tdep.c: Sort headers.
6023         * alpha-obsd-tdep.c: Sort headers.
6024         * alpha-nbsd-tdep.c: Sort headers.
6025         * alpha-mdebug-tdep.c: Sort headers.
6026         * alpha-linux-tdep.c: Sort headers.
6027         * alpha-linux-nat.c: Sort headers.
6028         * alpha-bsd-tdep.c: Sort headers.
6029         * alpha-bsd-nat.c: Sort headers.
6030         * aix-thread.c: Sort headers.
6031         * agent.c: Sort headers.
6032         * addrmap.c: Sort headers.
6033         * ada-varobj.c: Sort headers.
6034         * ada-valprint.c: Sort headers.
6035         * ada-typeprint.c: Sort headers.
6036         * ada-tasks.c: Sort headers.
6037         * ada-lang.c: Sort headers.
6038         * aarch64-tdep.c: Sort headers.
6039         * aarch64-ravenscar-thread.c: Sort headers.
6040         * aarch64-newlib-tdep.c: Sort headers.
6041         * aarch64-linux-tdep.c: Sort headers.
6042         * aarch64-linux-nat.c: Sort headers.
6043         * aarch64-fbsd-tdep.c: Sort headers.
6044         * aarch64-fbsd-nat.c: Sort headers.
6045         * aarch32-linux-nat.c: Sort headers.
6046
6047 2019-04-04  Tom Tromey  <tom@tromey.com>
6048
6049         * varobj.c (varobj_create): Update.
6050         * rust-exp.y (struct rust_parser) <update_innermost_block,
6051         lookup_symbol>: New methods.
6052         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6053         Rename.
6054         (rust_parser::rust_lookup_type)
6055         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6056         * printcmd.c (display_command, do_one_display): Update.
6057         * parser-defs.h (struct parser_state) <parser_state>: Add
6058         "tracker" parameter.
6059         (block_tracker): New member.
6060         (class innermost_block_tracker) <innermost_block_tracker>: Add
6061         "types" parameter.
6062         <reset>: Remove method.
6063         (innermost_block): Don't declare.
6064         (null_post_parser): Update.
6065         * parse.c (innermost_block): Remove global.
6066         (write_dollar_variable): Update.
6067         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6068         Remove "tracker_types" parameter.
6069         (parse_expression): Add "tracker" parameter.
6070         (parse_expression_for_completion): Update.
6071         (null_post_parser): Add "tracker" parameter.
6072         * p-exp.y: Update rules.
6073         * m2-exp.y: Update rules.
6074         * language.h (struct language_defn) <la_post_parser>: Add
6075         "tracker" parameter.
6076         * go-exp.y: Update rules.
6077         * f-exp.y: Update rules.
6078         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6079         parameter.
6080         * d-exp.y: Update rules.
6081         * c-exp.y: Update rules.
6082         * breakpoint.c (set_breakpoint_condition): Create an
6083         innermost_block_tracker.
6084         (watch_command_1): Likewise.
6085         * ada-lang.c (resolve): Add "tracker" parameter.
6086         (resolve_subexp): Likewise.
6087         * ada-exp.y (write_var_from_sym): Update.
6088
6089 2019-04-04  Tom Tromey  <tom@tromey.com>
6090
6091         * type-stack.h: New file.
6092         * type-stack.c: New file.
6093         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6094         type-stack.h.
6095         (insert_into_type_stack, insert_type, push_type, push_type_int)
6096         (insert_type_address_space, pop_type, pop_type_int)
6097         (pop_typelist, pop_type_stack, append_type_stack)
6098         (push_type_stack, get_type_stack, push_typelist)
6099         (follow_type_instance_flags, follow_types): Don't declare.
6100         * parse.c (type_stack): Remove global.
6101         (parse_exp_in_context): Update.
6102         (insert_into_type_stack, insert_type, push_type, push_type_int)
6103         (insert_type_address_space, pop_type, pop_type_int)
6104         (pop_typelist, pop_type_stack, append_type_stack)
6105         (push_type_stack, get_type_stack, push_typelist)
6106         (follow_type_instance_flags, follow_types): Remove (moved to
6107         type-stack.c).
6108         * f-exp.y (type_stack): New global.
6109         Update rules.
6110         (push_kind_type, f_parse): Update.
6111         * d-exp.y (type_stack): New global.
6112         Update rules.
6113         (d_parse): Update.
6114         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6115         Update rules.
6116         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6117         (HFILES_NO_SRCDIR): Add type-stack.h.
6118
6119 2019-04-04  Tom Tromey  <tom@tromey.com>
6120
6121         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6122         (rust_parser::convert_ast_to_expression, rust_parse)
6123         (rust_lex_test_completion, rust_lex_tests): Update.
6124         * parser-defs.h (struct expr_completion_state): New.
6125         (struct parser_state) <parser_state>: Add completion parameter.
6126         <mark_struct_expression, mark_completion_tag>: New methods.
6127         <parse_completion, m_completion_state>: New members.
6128         (prefixify_expression, null_post_parser): Update.
6129         (mark_struct_expression, mark_completion_tag): Don't declare.
6130         * parse.c (parse_completion, expout_last_struct)
6131         (expout_tag_completion_type, expout_completion_name): Remove
6132         globals.
6133         (parser_state::mark_struct_expression)
6134         (parser_state::mark_completion_tag): Now methods.
6135         (prefixify_expression): Add last_struct parameter.
6136         (prefixify_subexp): Likewise.
6137         (parse_exp_1): Update.
6138         (parse_exp_in_context): Add cstate parameter.  Update.
6139         (parse_expression_for_completion): Create an
6140         expr_completion_state.
6141         (null_post_parser): Add "completion" parameter.
6142         * p-exp.y: Update rules.
6143         (yylex): Update.
6144         * language.h (struct language_defn) <la_post_parser>: Add
6145         "completing" parameter.
6146         * go-exp.y: Update rules.
6147         (lex_one_token): Update.
6148         * expression.h (parse_completion): Don't declare.
6149         * d-exp.y: Update rules.
6150         (lex_one_token): Update rules.
6151         * c-exp.y: Update rules.
6152         (lex_one_token): Update.
6153         * ada-lang.c (resolve): Add "parse_completion" parameter.
6154         (resolve_subexp): Likewise.
6155         (ada_resolve_function): Likewise.
6156
6157 2019-04-04  Tom Tromey  <tom@tromey.com>
6158
6159         * parser-defs.h (struct parser_state) <start_arglist,
6160         end_arglist>: New methods.
6161         <arglist_len, m_funcall_chain>: New members.
6162         (arglist_len, start_arglist, end_arglist): Don't declare.
6163         * parse.c (arglist_len, funcall_chain): Remove global.
6164         (start_arglist, end_arglist): Remove functions.
6165         (parse_exp_in_context): Update.
6166         * p-exp.y: Update rules.
6167         * m2-exp.y: Update rules.
6168         * go-exp.y: Update rules.
6169         * f-exp.y: Update rules.
6170         * d-exp.y: Update rules.
6171         * c-exp.y: Update rules.
6172
6173 2019-04-04  Tom Tromey  <tom@tromey.com>
6174
6175         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6176         lex_operator, push_back>: New methods.
6177         Update all rules.
6178         (rust_parser::lex_hex, lex_escape): Rename and update.
6179         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6180         (rust_parser::lex_operator): Rename and update.
6181         (rust_parser::lex_number, rustyylex, rustyyerror)
6182         (rust_lex_test_init, rust_lex_test_sequence)
6183         (rust_lex_test_push_back, rust_lex_tests): Update.
6184         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6185         parameter.
6186         <lexptr, prev_lexptr>: New members.
6187         (lexptr, prev_lexptr): Don't declare.
6188         * parse.c (lexptr, prev_lexptr): Remove globals.
6189         (parse_exp_in_context): Update.
6190         * p-exp.y (yylex, yyerror): Update.
6191         * m2-exp.y (parse_number, yylex, yyerror): Update.
6192         * go-exp.y (lex_one_token, yyerror): Update.
6193         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6194         * d-exp.y (lex_one_token, yyerror): Update.
6195         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6196         (lex_one_token, yyerror): Update.
6197         * ada-lex.l (YY_INPUT): Update.
6198         (rewind_to_char): Update.
6199         * ada-exp.y (yyerror): Update.
6200
6201 2019-04-04  Tom Tromey  <tom@tromey.com>
6202
6203         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6204         * parser-defs.h (struct parser_state) <parser_state>: Add new
6205         parameter.
6206         <comma_terminates>: New member.
6207         (comma_terminates): Don't declare global.
6208         * parse.c (comma_terminates): Remove global.
6209         (parse_exp_in_context): Update.
6210         * p-exp.y (yylex): Update.
6211         * m2-exp.y (yylex): Update.
6212         * go-exp.y (lex_one_token): Update.
6213         * f-exp.y (yylex): Update.
6214         * d-exp.y (lex_one_token): Update.
6215         * c-exp.y (lex_one_token): Update.
6216         * ada-lex.l: Update.
6217
6218 2019-04-04  Tom Tromey  <tom@tromey.com>
6219
6220         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6221         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6222         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6223         * parser-defs.h (paren_depth): Don't declare.
6224         * parse.c (paren_depth): Remove global.
6225         (parse_exp_in_context): Update.
6226         * p-exp.y (paren_depth): New global.
6227         (pascal_parse): Initialize it.
6228         * m2-exp.y (paren_depth): New global.
6229         (m2_parse): Initialize it.
6230         * go-exp.y (paren_depth): New global.
6231         (go_parse): Initialize it.
6232         * f-exp.y (paren_depth): New global.
6233         (f_parse): Initialize it.
6234         * d-exp.y (paren_depth): New global.
6235         (d_parse): Initialize it.
6236         * c-exp.y (paren_depth): New global.
6237         (c_parse): Initialize it.
6238         * ada-lex.l (paren_depth): New global.
6239         (lexer_init): Initialize it.
6240
6241 2019-04-04  Tom Tromey  <tom@tromey.com>
6242
6243         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6244         (rust_parser::convert_ast_to_type)
6245         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6246         * parser-defs.h (struct parser_state) <parser_state>: Add
6247         parameters.  Initialize new members.
6248         <expression_context_block, expression_context_pc>: New members.
6249         * parse.c (expression_context_block, expression_context_pc):
6250         Remove globals.
6251         (parse_exp_in_context): Update.
6252         * p-exp.y: Update all rules.
6253         (yylex): Update.
6254         * m2-exp.y: Update all rules.
6255         (yylex): Update.
6256         * go-exp.y (yylex): Update.
6257         * f-exp.y (yylex): Update.
6258         * d-exp.y: Update all rules.
6259         (yylex): Update.
6260         * c-exp.y: Update all rules.
6261         (lex_one_token, classify_name, yylex, c_parse): Update.
6262         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6263
6264 2019-04-04  Tom Tromey  <tom@tromey.com>
6265
6266         * gdbarch.h, gdbarch.c: Rebuild.
6267         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6268         * stap-probe.h:
6269         (struct stap_parse_info): Replace "parser_state" with
6270         "expr_builder".
6271         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6272         (parser_state): New class.
6273         * parse.c (expr_builder): Rename.
6274         (expr_builder::release): Rename.
6275         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6276         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6277         (write_exp_elt_longcst, write_exp_elt_floatcst)
6278         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6279         (write_exp_string_vector, write_exp_bitstring)
6280         (write_exp_msymbol, mark_struct_expression)
6281         (write_dollar_variable)
6282         (insert_type_address_space, increase_expout_size): Replace
6283         "parser_state" with "expr_builder".
6284         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6285         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6286         "parser_state" with "expr_builder".
6287
6288 2019-04-04  Tom Tromey  <tom@tromey.com>
6289
6290         * rust-exp.y: Replace "parse_language" with method call.
6291         * p-exp.y:
6292         (yylex): Replace "parse_language" with method call.
6293         * m2-exp.y:
6294         (yylex): Replace "parse_language" with method call.
6295         * go-exp.y (classify_name): Replace "parse_language" with method
6296         call.
6297         * f-exp.y (yylex): Replace "parse_language" with method call.
6298         * d-exp.y (lex_one_token): Replace "parse_language" with method
6299         call.
6300         * c-exp.y:
6301         (lex_one_token, classify_name, yylex): Replace "parse_language"
6302         with method call.
6303         * ada-exp.y (find_primitive_type, type_char)
6304         (type_system_address): Replace "parse_language" with method call.
6305
6306 2019-04-04  Tom Tromey  <tom@tromey.com>
6307
6308         * rust-exp.y: Replace "parse_gdbarch" with method call.
6309         * parse.c (write_dollar_variable, insert_type_address_space):
6310         Replace "parse_gdbarch" with method call.
6311         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6312         call.
6313         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6314         call.
6315         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6316         "parse_gdbarch" with method call.
6317         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6318         with method call.
6319         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6320         "parse_gdbarch" with method call.
6321         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6322         "parse_gdbarch" with method call.
6323         * c-exp.y (parse_type, parse_number, classify_name): Replace
6324         "parse_gdbarch" with method call.
6325         * ada-lex.l: Replace "parse_gdbarch" with method call.
6326         * ada-exp.y (parse_type, find_primitive_type, type_char)
6327         (type_system_address): Replace "parse_gdbarch" with method call.
6328
6329 2019-04-04  Tom Tromey  <tom@tromey.com>
6330
6331         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6332         * stap-probe.c (stap_parse_argument): Update.
6333         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6334         initial_size parameter.
6335         * rust-exp.y (rust_lex_tests): Update.
6336         * parse.c (parser_state): Update.
6337         (parse_exp_in_context): Update.
6338         * parser-defs.h (struct parser_state) <parser_state>: Remove
6339         "initial_size" parameter.
6340
6341 2019-04-04  Tom Tromey  <tom@tromey.com>
6342
6343         * parser-defs.h (increase_expout_size): Don't declare.
6344         * parse.c (increase_expout_size): Now static.
6345
6346 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6347
6348         * gnu-nat.c (gnu_nat_target::wait): Fix
6349         target_waitstatus_to_string call.
6350
6351 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6352
6353         * eval.c (evaluate_subexp_standard): Handle internal functions
6354         during Fortran function call handling.
6355
6356 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6357
6358         * NEWS: Mention new internal functions.
6359         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6360         (read_base_type): Use dwarf2_init_complex_target_type.
6361         * value.c (creal_internal_fn): New function.
6362         (cimag_internal_fn): New function.
6363         (_initialize_values): Register new internal functions.
6364
6365 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6366
6367         * infrun.c (stop_all_threads): If debug_infrun, always
6368         trace the wait status after wait_one, using
6369         target_waitstatus_to_string and target_pid_to_str.
6370         (handle_inferior_event): Replace various trace of
6371         wait status kind by a single trace.
6372         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6373         wait status kind image by target_waitstatus_to_string.
6374         * target/waitstatus.c (target_waitstatus_to_string): Fix
6375         obsolete comment.
6376
6377 2019-04-01  Tom Tromey  <tromey@adacore.com>
6378
6379         PR symtab/23331:
6380         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6381
6382 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6383             Pedro Alves  <palves@redhat.com>
6384
6385         * top.c (quit_force): Call 'finalize_values'.
6386         * value.c (finalize_values): New function.
6387         * value.h (finalize_values): Declare.
6388
6389 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6390
6391         * NEWS: Announce $_gdb_major and $_gdb_minor.
6392
6393         * top.c (init_gdb_version_vars): New function.
6394         (gdb_init): Call init_gdb_version_vars.
6395
6396 2019-03-29  Tom Tromey  <tromey@adacore.com>
6397
6398         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6399         help text.  Remove dead code.
6400
6401 2019-03-29  Keith Seitz  <keiths@redhat.com>
6402
6403         From Siddhesh Poyarekar:
6404         * f-lang.h (f77_get_upperbound): Return LONGEST.
6405         (f77_get_lowerbound): Likewise.
6406         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6407         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6408         print them.
6409         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6410         plongest to format print it.
6411         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6412         (f77_get_upperbound): Likewise.
6413         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6414         LOWER_BOUND to LONGEST.
6415         (f77_create_arrayprint_offset_tbl): Likewise.
6416
6417 2019-03-29  Keith Seitz  <keiths@redhat.com>
6418
6419         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6420         %s/pulongest for TYPE_LENGTH instead of %d in format
6421         strings.
6422         * ada-typerint.c (ada_print_type): Likewise.
6423         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6424         * compile/compile-c-support.c (generate_register_struct): Likewise.
6425         * gdbtypes.c (recursive_dump_type): Likewise.
6426         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6427         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6428         instead of %d in format strings.
6429         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6430         to std::min to ULONGEST.
6431         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6432         instead of %d in format strings.
6433         * tracepoint.c (info_scope_command): Likewise.
6434         * typeprint.c (print_offset_data::update)
6435         (print_offset_data::finish): Likewise.
6436         * xtensa-tdep.c (xtensa_store_return_value)
6437         (xtensa_push_dummy_call): Likewise.
6438
6439 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6440
6441         * windows-nat.c (display_selector): Fixed format specifications
6442         for 64-bit Cygwin.
6443
6444 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6445
6446         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6447
6448 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6449
6450         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6451         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6452         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6453         (nios2_linux_init_abi): Install it.
6454
6455 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6456
6457         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6458
6459 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6460
6461         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6462
6463 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6464             Tom Tromey  <tromey@adacore.com>
6465
6466         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6467
6468 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6469
6470         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6471         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6472         method to compute the bounds of range types. Also print "[evaluated]"
6473         if the bounds' values come from a dynamic evaluation.
6474
6475 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6476
6477         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6478         whitespace when pretty printing is on.
6479
6480 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6481
6482         * ppc-linux-nat.c: Add include.
6483
6484 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6485
6486         * NEWS: Mention AArch64 Pointer Authentication.
6487
6488 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6489
6490         * arm-linux-nat.c: Add include.
6491
6492 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6493
6494         * source-cache.c (source_cache::get_source_lines): Re-read
6495         fullname after calling open_source_file.
6496
6497 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6498
6499         * NEWS: Mention TLS support for FreeBSD.
6500
6501 2019-03-25  Tom Tromey  <tromey@adacore.com>
6502
6503         * minsyms.c (BUNCH_SIZE): Update comment.
6504         (~minimal_symbol_reader): Remove old comment.
6505         (compact_minimal_symbols): Update comment.
6506         (minimal_symbol_reader::install): Remove old comment.  Update
6507         other comments.
6508
6509 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6510
6511         * s390-linux-nat.c: Add include.
6512
6513 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6514
6515         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6516         Call linux_get_hwcap.
6517         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6518         Likewise.
6519         (aarch64_linux_get_hwcap): Remove function.
6520         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6521         declaration.
6522         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6523         linux_get_hwcap.
6524         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6525         * linux-tdep.c (linux_get_hwcap): Add function.
6526         (linux_get_hwcap2): Likewise.
6527         * linux-tdep.h (linux_get_hwcap): Add declaration.
6528         (linux_get_hwcap2): Likewise.
6529         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6530         (ppc_linux_get_hwcap2): Likewise.
6531         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6532         linux_get_hwcap.
6533         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6534         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6535         (ppc_linux_nat_target::read_description): Likewise.
6536         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6537         * s390-linux-nat.c: Likewise.
6538         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6539
6540 2019-03-24  Tom Tromey  <tom@tromey.com>
6541
6542         * ada-lang.c (standard_lookup): Simplify initialization.
6543         (ada_lookup_symbol_nonlocal): Simplify return.
6544         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6545         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6546         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6547         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6548         initialization.
6549         * solib.c (solib_global_lookup): Simplify.
6550         * symtab.c (null_block_symbol): Remove.
6551         (symbol_cache_lookup): Simplify returns.
6552         (lookup_language_this): Simplify returns.
6553         (lookup_symbol_aux): Simplify return.
6554         (lookup_local_symbol): Simplify returns.
6555         (lookup_global_symbol_from_objfile): Simplify return.
6556         (lookup_symbol_in_objfile_symtabs)
6557         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6558         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6559         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6560         * cp-namespace.c (cp_lookup_bare_symbol)
6561         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6562         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6563         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6564         (cp_lookup_symbol_via_imports): Simplify initialization.
6565         (find_symbol_in_baseclass): Likewise.
6566         * symtab.h (null_block_symbol): Remove.
6567         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6568         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6569         (d_lookup_symbol_module): Likewise.
6570         (find_symbol_in_baseclass): Simplify initialization.
6571
6572 2019-03-24  Tom Tromey  <tom@tromey.com>
6573
6574         * expression.h: Don't include symtab.h.
6575         (struct block): Forward declare.
6576
6577 2019-03-24  Tom Tromey  <tom@tromey.com>
6578
6579         * c-exp.y (typebase): Remove casts.
6580         * gdbtypes.c (lookup_unsigned_typename, )
6581         (lookup_signed_typename): Remove cast.
6582         * eval.c (parse_to_comma_and_eval): Remove cast.
6583         * parse.c (write_dollar_variable): Remove cast.
6584         * block.h (struct block) <superblock>: Now const.
6585         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6586         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6587         (map_block): Make "block" const.
6588         * symfile.h (struct quick_symbol_functions)
6589         <map_matching_symbols>: Constify block argument to "callback".
6590         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6591         const.
6592         (find_pc_sect_compunit_symtab): Make "b" const.
6593         (find_symbol_at_address): Likewise.
6594         (search_symbols): Likewise.
6595         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6596         (dw2_debug_names_lookup_symbol): Likewise.
6597         (dw2_map_matching_symbols): Update.
6598         * p-valprint.c (pascal_val_print): Remove "block".
6599         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6600         (aux_add_nonlocal_symbols): Make "block" const.
6601         (resolve_subexp): Remove cast.
6602         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6603         const.
6604         (iterate_over_file_blocks): Likewise.
6605         * f-exp.y (%union) <bval>: Remove.
6606         * coffread.c (patch_opaque_types): Make "b" const.
6607         * spu-tdep.c (spu_catch_start): Make "block" const.
6608         * c-valprint.c (print_unpacked_pointer): Remove "block".
6609         * symmisc.c (dump_symtab_1): Make "b" const.
6610         (block_depth): Make "block" const.
6611         * d-exp.y (%union) <bval>: Remove.
6612         * cp-support.h (cp_lookup_rtti_type): Update.
6613         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6614         * psymtab.c (psym_lookup_symbol): Make "block" const.
6615         (maintenance_check_psymtabs): Make "b" const.
6616         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6617         (enumerate_locals, enumerate_args): Update.
6618         * python/py-symtab.c (stpy_global_block): Make "block" const.
6619         (stpy_static_block): Likewise.
6620         * inline-frame.c (block_starting_point_at): Make "new_block"
6621         const.
6622         * block.c (find_block_in_blockvector): Make return type const.
6623         (blockvector_for_pc_sect): Make "b" const.
6624         (find_block_in_blockvector): Make "b" const.
6625
6626 2019-03-23  Tom Tromey  <tom@tromey.com>
6627
6628         * varobj.c (varobj_create): Update.
6629         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6630         * printcmd.c (display_command, do_one_display): Don't reset
6631         innermost_block.
6632         * parser-defs.h (enum innermost_block_tracker_type): Move to
6633         expression.h.
6634         (innermost_block): Update comment.
6635         * parse.c (parse_exp_1): Add tracker_types parameter.
6636         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6637         tracker_types parameter.  Reset innermost_block.
6638         (parse_exp_in_context): Remove.
6639         (parse_expression_for_completion): Update.
6640         * objfiles.c (~objfile): Don't reset expression_context_block or
6641         innermost_block.
6642         * expression.h (enum innermost_block_tracker_type): Move from
6643         parser-defs.h.
6644         (parse_exp_1): Add tracker_types parameter.
6645         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6646         reset innermost_block.
6647
6648 2019-03-23  Tom Tromey  <tom@tromey.com>
6649
6650         * objfiles.h: Include bcache.h.
6651
6652 2019-03-23  Tom Tromey  <tom@tromey.com>
6653
6654         * linespec.c (get_current_search_block): Use
6655         scoped_restore_current_language.
6656         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6657
6658 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6659             Jiong Wang  <jiong.wang@arm.com>
6660
6661         * aarch64-linux-tdep.c
6662         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6663         section.
6664         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6665
6666 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6667             Jiong Wang  <jiong.wang@arm.com>
6668
6669         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6670         instructions.
6671         (aarch64_analyze_prologue_test): Add PACIASP test.
6672         (aarch64_prologue_prev_register): Unmask PC value.
6673
6674 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6675             Jiong Wang  <jiong.wang@arm.com>
6676
6677         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6678         (aarch64_dwarf2_prev_register): Unmask PC value.
6679         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6680         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6681         DW_CFA_AARCH64_negate_ra_state.
6682         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6683
6684 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6685             Jiong Wang  <jiong.wang@arm.com>
6686
6687         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6688         registers.
6689         (aarch64_pseudo_register_name): Likewise.
6690         (aarch64_pseudo_register_type): Likewise.
6691         (aarch64_pseudo_register_reggroup_p): Likewise.
6692         (aarch64_gdbarch_init): Add pauth registers.
6693         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6694         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6695         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6696         (struct gdbarch_tdep): Add regnum for ra_state.
6697
6698 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6699             Jiong Wang  <jiong.wang@arm.com>
6700
6701         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6702
6703 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6704             Jiong Wang  <jiong.wang@arm.com>
6705
6706         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6707         function.
6708         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6709         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6710         (aarch64_gdbarch_init): Add puth registers.
6711         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6712         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6713         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6714
6715 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6716             Jiong Wang  <jiong.wang@arm.com>
6717
6718         * aarch64-linux-nat.c
6719         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6720         * aarch64-linux-tdep.c
6721         (aarch64_linux_core_read_description): Likewise.
6722         (aarch64_linux_get_hwcap): New function.
6723         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6724         (aarch64_linux_get_hwcap): New declaration.
6725
6726 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6727             Jiong Wang  <jiong.wang@arm.com>
6728
6729         * aarch64-linux-nat.c
6730         (aarch64_linux_nat_target::read_description): Add pauth param.
6731         * aarch64-linux-tdep.c
6732         (aarch64_linux_core_read_description): Likewise.
6733         * aarch64-tdep.c (struct target_desc): Add in pauth.
6734         (aarch64_read_description): Add pauth param.
6735         (aarch64_gdbarch_init): Likewise.
6736         * aarch64-tdep.h (aarch64_read_description): Likewise.
6737         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6738         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6739         * features/Makefile: Add new files.
6740         * features/aarch64-pauth.c: New file.
6741         * features/aarch64-pauth.xml: New file.
6742
6743 2019-03-20  Tom Tromey  <tromey@adacore.com>
6744
6745         * infrun.c (handle_inferior_event): Rename from
6746         handle_inferior_event_1.  Create a scoped_value_mark.
6747         (handle_inferior_event): Remove.
6748
6749 2019-03-19  Tom Tromey  <tromey@adacore.com>
6750
6751         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6752         * infrun.h (print_stop_event): Add "displays" parameter.
6753         * infrun.c (print_stop_event): Add "displays" parameter.
6754
6755 2019-03-19  Pedro Alves  <palves@redhat.com>
6756
6757         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6758         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6759         to -1.  Fix TABs vs spaces.
6760         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6761         * tui/tui-out.h (tui_ui_out) Add intro comments.
6762         <m_line, m_start_of_line>: In-class initialize, and add describing
6763         comment.
6764
6765 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6766
6767         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6768         variable names.
6769         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6770
6771 2019-03-18  Pedro Alves  <palves@redhat.com>
6772             Eli Zaretskii <eliz@gnu.org>
6773
6774         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6775         m_line and m_start_of_line.
6776
6777 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6778
6779         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6780         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6781         it returns a newline.  This fixes a regression in TU mode, whereby
6782         the next line is output on the same screen line as the user input.
6783
6784 2019-03-18  Tom Tromey  <tromey@adacore.com>
6785
6786         * minsyms.c (minimal_symbol_reader::install): Remove call to
6787         obstack_blank.
6788
6789 2019-03-18  Pedro Alves  <palves@redhat.com>
6790
6791         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6792         New globals.
6793         (apply_style): New, factored out from ...
6794         (apply_ansi_escape): ... this.  Handle reverse video mode.
6795         (tui_set_reverse_mode): New function.
6796         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6797         * tui/tui-winsource.c (tui_show_source_line): Use
6798         tui_set_reverse_mode instead of setting A_STANDOUT.
6799         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6800         New setter methods.
6801
6802 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6803
6804         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6805         Handle tabs.
6806
6807 2019-03-18  Tom Tromey  <tromey@adacore.com>
6808
6809         * ada-lang.c (empty_array): Add "high" parameter.
6810         (ada_evaluate_subexp): Update.
6811
6812 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6813
6814         * unittests/string_view-selftests.c: Define
6815         _initialize_string_view_selftests unconditionally.
6816
6817 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6818
6819         PR gdb/24350
6820         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6821
6822 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6823
6824         PR gdb/24351
6825         * windows-nat.c (display_selector): Fix format specifiers.
6826
6827 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6828
6829         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6830         tui_refill_source_window instead of tui_refresh_win, to update the
6831         current execution line.  This fixes redisplay of the current line
6832         when stepping through the code with "next" or "step".
6833
6834 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6835
6836         * source-cache.c (source_cache::get_source_lines): Call
6837         find_source_lines to initialize s->nlines.  This fixes vertical
6838         scrolling of TUI source window when the DOWN arrow is pressed.
6839
6840 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6841
6842         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6843         linux-thread-db.c (_initialize_thread_db): Likewise.
6844
6845 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6846
6847         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6848         wclrtoeol in tui_show_source_line".  This reverts changes made in
6849         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6850
6851 2019-03-15  Tom Tromey  <tom@tromey.com>
6852
6853         * symtab.h (struct minimal_symbol): Derive from
6854         general_symbol_info.
6855         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6856         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6857         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6858         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6859         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6860         (MSYMBOL_SEARCH_NAME): Update.
6861         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6862         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6863         * minsyms.c (minimal_symbol_reader::record_full): Update.
6864
6865 2019-03-15  Tom Tromey  <tom@tromey.com>
6866
6867         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6868
6869 2019-03-15  Tom Tromey  <tom@tromey.com>
6870
6871         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6872         unique_xmalloc_ptr.
6873         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6874         Update.
6875         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6876         (build_minimal_symbol_hash_tables)
6877         (minimal_symbol_reader::install): Update.
6878
6879 2019-03-15  Tom Tromey  <tom@tromey.com>
6880
6881         * symtab.c (create_demangled_names_hash): Update.
6882         (symbol_set_names): Update.
6883         * objfiles.h (struct objfile_per_bfd_storage)
6884         <demangled_names_hash>: Now an htab_up.
6885         * objfiles.c (objfile_per_bfd_storage): Simplify.
6886
6887 2019-03-15  Tom Tromey  <tom@tromey.com>
6888
6889         * objfiles.h (struct objfile_per_bfd_storage): Declare
6890         destructor.
6891         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6892         New.
6893         (get_objfile_bfd_data): Use new.  Don't initialize
6894         language_of_main.
6895         (free_objfile_per_bfd_storage): Remove.
6896         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6897
6898 2019-03-15  Tom Tromey  <tom@tromey.com>
6899
6900         * symfile.c (reread_symbols): Update.
6901         * objfiles.c (objfile::objfile): Update.
6902         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6903         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6904         comment.
6905         (minimal_symbol_reader::install): Update.
6906         (terminate_minimal_symbol_table): Remove.
6907         * jit.c (jit_object_close_impl): Update.
6908
6909 2019-03-15  Tom Tromey  <tom@tromey.com>
6910
6911         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6912         initializations.
6913
6914 2019-03-15  Tom Tromey  <tom@tromey.com>
6915
6916         * objfiles.h (struct objfile_per_bfd_storage)
6917         <demangled_hash_languages>: Now a bitset.
6918         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6919         (lookup_minimal_symbol): Update.
6920
6921 2019-03-15  Tom Tromey  <tom@tromey.com>
6922
6923         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6924         Don't return the symbol.
6925         * coffread.c (record_minimal_symbol): Use record_full.
6926
6927 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6928
6929         The MS-Windows port of ncurses fails to switch to a color pair if
6930         one or both of the colors are the implicit default colors.  This
6931         change records the default colors when TUI is initialized, and
6932         then specifies them explicitly when a color pair uses the default
6933         colors.  This allows color styling in TUI mode on MS-Windows.
6934
6935         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6936         ncurses_norm_attr.
6937         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6938         colors in ncurses_norm_attr.
6939         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6940         "none", replace it with the default color recorded in
6941         ncurses_norm_attr.
6942
6943 2019-03-14  Tom Tromey  <tromey@adacore.com>
6944
6945         * source-cache.h (class source_cache) <get_source_lines>: Return
6946         std::string.
6947         * source-cache.c (source_cache::extract_lines): Handle case where
6948         first_pos==npos.  Return std::string.
6949         (source_cache::get_source_lines): Update.
6950
6951 2019-03-14  Tom Tromey  <tromey@adacore.com>
6952
6953         * NEWS: Add item for "style sources" commands.
6954         * source-cache.c (source_cache::get_source_lines): Check
6955         source_styling.
6956         * cli/cli-style.c (source_styling): New global.
6957         (_initialize_cli_style): Add "style sources" commands.
6958         (show_style_sources): New function.
6959         * cli/cli-style.h (source_styling): Declare.
6960
6961 2019-03-14  Pedro Alves  <palves@redhat.com>
6962             Tom Tromey  <tromey@adacore.com>
6963
6964         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6965         * tui/tui-winsource.c (tui_refill_source_window): New function,
6966         from...
6967         (tui_horizontal_source_scroll): ... here.  Move some logic.
6968         * cli/cli-style.c (set_style_enabled): Notify new observable.
6969         * tui/tui-hooks.c (tui_redisplay_source): New function.
6970         (tui_attach_detach_observers): Attach or detach
6971         tui_redisplay_source.
6972         * observable.h (source_styling_changed): New observable.
6973         * observable.c: Define source_styling_changed observable.
6974
6975 2019-03-13  Tom Tromey  <tromey@adacore.com>
6976
6977         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6978         (i386_gnu_nat_target::store_registers): Update.
6979         * target-debug.h (target_debug_print_std_string): New macro.
6980         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6981         * windows-tdep.c (display_one_tib): Update.
6982         * tui/tui-stack.c (tui_make_status_line): Update.
6983         * top.c (print_inferior_quit_action): Update.
6984         * thread.c (thr_try_catch_cmd): Update.
6985         (add_thread_with_info): Update.
6986         (thread_target_id_str): Update.
6987         (thr_try_catch_cmd): Update.
6988         (thread_command): Update.
6989         (thread_find_command): Update.
6990         * record-btrace.c (record_btrace_target::info_record)
6991         (record_btrace_resume_thread, record_btrace_target::resume)
6992         (record_btrace_cancel_resume, record_btrace_step_thread)
6993         (record_btrace_target::wait, record_btrace_target::wait)
6994         (record_btrace_target::wait, record_btrace_target::stop): Update.
6995         * progspace.c (print_program_space): Update.
6996         * process-stratum-target.c
6997         (process_stratum_target::thread_address_space): Update.
6998         * linux-fork.c (linux_fork_mourn_inferior)
6999         (detach_checkpoint_command, info_checkpoints_command)
7000         (linux_fork_context): Update.
7001         (linux_fork_detach): Update.
7002         (class scoped_switch_fork_info): Update.
7003         (delete_checkpoint_command): Update.
7004         * infrun.c (follow_fork_inferior): Update.
7005         (follow_fork_inferior): Update.
7006         (proceed_after_vfork_done): Update.
7007         (handle_vfork_child_exec_or_exit): Update.
7008         (follow_exec): Update.
7009         (displaced_step_prepare_throw): Update.
7010         (displaced_step_restore): Update.
7011         (start_step_over): Update.
7012         (resume_1): Update.
7013         (clear_proceed_status_thread): Update.
7014         (proceed): Update.
7015         (print_target_wait_results): Update.
7016         (do_target_wait): Update.
7017         (context_switch): Update.
7018         (stop_all_threads): Update.
7019         (restart_threads): Update.
7020         (finish_step_over): Update.
7021         (handle_signal_stop): Update.
7022         (switch_back_to_stepped_thread): Update.
7023         (keep_going_pass_signal): Update.
7024         (print_exited_reason): Update.
7025         (normal_stop): Update.
7026         * inferior.c (inferior_pid_to_str): Change return type.
7027         (print_selected_inferior): Update.
7028         (add_inferior): Update.
7029         (detach_inferior): Update.
7030         * dummy-frame.c (fprint_dummy_frames): Update.
7031         * dcache.c (dcache_info_1): Update.
7032         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7033         (btrace_fetch, btrace_clear): Update.
7034         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7035         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7036         type.
7037         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7038         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7039         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7040         * gdbarch.c, gdbarch.h: Rebuild.
7041         * gdbarch.sh (core_pid_to_str): Change return type.
7042         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7043         return type.
7044         (windows_nat_target::pid_to_str): Change return type.
7045         (windows_delete_thread): Update.
7046         (windows_nat_target::attach): Update.
7047         (windows_nat_target::files_info): Update.
7048         * target-delegates.c: Rebuild.
7049         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7050         return type.
7051         (sol_thread_target::pid_to_str): Change return type.
7052         * remote.c (class remote_target) <pid_to_str>: Change return
7053         type.
7054         (remote_target::pid_to_str): Change return type.
7055         (extended_remote_target::attach, remote_target::remote_stop_ns)
7056         (remote_target::remote_notif_remove_queued_reply)
7057         (remote_target::push_stop_reply, remote_target::disable_btrace):
7058         Update.
7059         (extended_remote_target::attach): Update.
7060         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7061         type.
7062         (gdbsim_target::pid_to_str): Change return type.
7063         * ravenscar-thread.c (struct ravenscar_thread_target)
7064         <pid_to_str>: Change return type.
7065         (ravenscar_thread_target::pid_to_str): Change return type.
7066         * procfs.c (class procfs_target) <pid_to_str>: Change return
7067         type.
7068         (procfs_target::pid_to_str): Change return type.
7069         (procfs_target::attach): Update.
7070         (procfs_target::detach): Update.
7071         (procfs_target::fetch_registers): Update.
7072         (procfs_target::store_registers): Update.
7073         (procfs_target::wait): Update.
7074         (procfs_target::files_info): Update.
7075         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7076         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7077         return type.
7078         (nto_procfs_target::pid_to_str): Change return type.
7079         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7080         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7081         return type.
7082         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7083         (exit_lwp): Update.
7084         (attach_proc_task_lwp_callback, get_detach_signal)
7085         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7086         (linux_nat_target::resume, wait_lwp, stop_callback)
7087         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7088         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7089         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7090         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7091         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7092         type.
7093         (inf_ptrace_target::attach): Update.
7094         (inf_ptrace_target::files_info): Update.
7095         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7096         type.
7097         (go32_nat_target::pid_to_str): Change return type.
7098         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7099         (gnu_nat_target::wait): Update.
7100         (gnu_nat_target::wait): Update.
7101         (gnu_nat_target::resume): Update.
7102         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7103         (fbsd_nat_target::wait): Update.
7104         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7105         type.
7106         (darwin_nat_target::attach): Update.
7107         * corelow.c (class core_target) <pid_to_str>: Change return type.
7108         (core_target::pid_to_str): Change return type.
7109         * target.c (normal_pid_to_str): Change return type.
7110         (default_pid_to_str): Likewise.
7111         (target_pid_to_str): Change return type.
7112         (target_translate_tls_address): Update.
7113         (target_announce_detach): Update.
7114         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7115         return type.
7116         (bsd_uthread_target::pid_to_str): Change return type.
7117         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7118         type.
7119         (bsd_kvm_target::pid_to_str): Change return type.
7120         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7121         return type.
7122         (aix_thread_target::pid_to_str): Change return type.
7123         * target.h (struct target_ops) <pid_to_str>: Change return type.
7124         (target_pid_to_str, normal_pid_to_str): Likewise.
7125         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7126         type.
7127         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7128         type.
7129         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7130         return type.
7131         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7132         type.
7133         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7134         type.
7135         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7136         return type.
7137
7138 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7139
7140         * NEWS: Mention that the new default MI version is 3.  Mention
7141         changes to the output of commands and events that deal with
7142         multi-location breakpoints.
7143         * breakpoint.c: Include "mi/mi-out.h".
7144         (print_one_breakpoint): Change output syntax if using MI version
7145         >= 3.
7146         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7147         New.
7148         (mi_multi_location_breakpoint_output_fixed): New.
7149         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7150         (mi_cmd_fix_multi_location_breakpoint_output): New.
7151         (mi_multi_location_breakpoint_output_fixed): New.
7152         * mi/mi-cmds.c (mi_cmds): Register command
7153         -fix-multi-location-breakpoint-output.
7154         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7155         interpreter "mi".
7156
7157 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7158
7159         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7160         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7161         instantiate mi_ui_out based on interpreter name.
7162         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7163         * mi/mi-main.c (mi_load_progress): Likewise.
7164
7165 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7166
7167         * NEWS: Combine separate "New targets" sections for 8.3.
7168
7169 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7170
7171         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7172         (ppcfbsd_init_abi): Install gdbarch
7173         "fetch_tls_load_module_address" and "get_thread_local_address"
7174         methods.
7175
7176 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7177
7178         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7179         (riscv_fbsd_init_abi): Install gdbarch
7180         "fetch_tls_load_module_address" and "get_thread_local_address"
7181         methods.
7182
7183 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7184
7185         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7186         (i386fbsd_init_abi): Install gdbarch
7187         "fetch_tls_load_module_address" and "get_thread_local_address"
7188         methods.
7189
7190 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7191
7192         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7193         (amd64fbsd_init_abi): Install gdbarch
7194         "fetch_tls_load_module_address" and "get_thread_local_address"
7195         methods.
7196
7197 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7198
7199         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7200         (struct fbsd_pspace_data): New type.
7201         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7202         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7203         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7204         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7205         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7206
7207 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7208
7209         * gdbtypes.c (lookup_struct_elt): New function.
7210         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7211         * gdbtypes.h (struct struct_elt): New type.
7212         (lookup_struct_elt): New prototype.
7213
7214 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7215
7216         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7217         remove disabled code block.
7218
7219 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7220
7221         * gdbarch.sh (get_thread_local_address): New method.
7222         * gdbarch.h, gdbarch.c: Regenerate.
7223         * target.c (target_translate_tls_address): Use
7224         gdbarch_get_thread_local_address if present instead of
7225         target::get_thread_local_address.
7226
7227 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7228
7229         * target.h (target::get_thread_local_address): Update comment.
7230
7231 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7232
7233         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7234         objfile->separate_debug_objfile_backlink if not NULL.
7235
7236 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7237
7238         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7239         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7240         (amd64bsd_store_inferior_registers): Likewise.
7241         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7242         Enable segment base registers.
7243         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7244         PT_GETFSBASE and PT_GETGSBASE.
7245         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7246         PT_SETGSBASE.
7247         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7248         segment base registers.
7249         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7250
7251 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7252
7253         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7254         Update calls to i386_target_description to add 'segments'
7255         parameter.
7256         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7257         add segment base registers.
7258         * arch/i386.c (i386_create_target_description): Add 'segments'
7259         parameter to enable segment base registers.
7260         * arch/i386.h (i386_create_target_description): Likewise.
7261         * features/i386/32bit-segments.xml: New file.
7262         * features/i386/32bit-segments.c: Generate.
7263         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7264         call to i386_target_description to add 'segments' parameter.
7265         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7266         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7267         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7268         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7269         if feature is present.
7270         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7271         Add 'segments' parameter to call to i386_target_description.
7272         (i386_target_description): Add 'segments' parameter to enable
7273         segment base registers.
7274         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7275         to call to i386_target_description.
7276         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7277         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7278         Define I386_NUM_REGS.
7279         (i386_target_description): Add 'segments' parameter to enable
7280         segment base registers.
7281
7282 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7283
7284         PR/24325
7285         * source-cache.c: #undef open and close, to avoid unresolved
7286         externals during linking.
7287
7288 2019-03-12  Tom Tromey  <tromey@adacore.com>
7289
7290         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7291         const.  Add initializers.
7292         (_initialize_remote): Don't initialize ptid globals.
7293
7294 2019-03-12  Pedro Alves  <palves@redhat.com>
7295
7296         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7297
7298 2019-03-12  Pedro Alves  <palves@redhat.com>
7299
7300         * cp-name-parser.y (main): Remove unused 'len' variable.
7301
7302 2019-03-12  Tom Tromey  <tromey@adacore.com>
7303
7304         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7305         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7306
7307 2019-03-12  Tom Tromey  <tromey@adacore.com>
7308
7309         * linux-nat.c (iterate_over_lwps): Update.
7310         (stop_callback): Remove parameter.
7311         (stop_wait_callback, detach_callback, resume_set_callback)
7312         (select_singlestep_lwp_callback, set_ignore_sigint)
7313         (status_callback, resumed_callback, resume_clear_callback)
7314         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7315         data parameter.
7316         (linux_nat_target::detach, linux_nat_target::resume)
7317         (linux_stop_and_wait_all_lwps, select_event_lwp)
7318         (linux_nat_filter_event, linux_nat_wait_1)
7319         (linux_nat_target::kill, linux_nat_target::stop)
7320         (linux_nat_target::stop): Update.
7321         (linux_nat_resume_callback): Change type.
7322         (resume_stopped_resumed_lwps, count_events_callback)
7323         (select_event_lwp_callback): Likewise.
7324         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7325         * arm-linux-nat.c (struct update_registers_data): Remove.
7326         (update_registers_callback): Change type.
7327         (arm_linux_insert_hw_breakpoint1): Update.
7328         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7329         parameter.
7330         (x86_linux_dr_set_addr): Update.
7331         (x86_linux_dr_set_control): Update.
7332         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7333         (iterate_over_lwps): Use gdb::function_view.
7334         * nat/aarch64-linux-hw-point.c (struct
7335         aarch64_dr_update_callback_param): Remove.
7336         (debug_reg_change_callback): Change type.
7337         (aarch64_notify_debug_reg_change): Update.
7338         * s390-linux-nat.c (s390_refresh_per_info): Update.
7339
7340 2019-03-11  Tom Tromey  <tromey@adacore.com>
7341
7342         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7343         redundant assignment to "this_cu".
7344
7345 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7346
7347         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7348
7349 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7350
7351         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7352         from...
7353         (rank_one_type): ... this.
7354
7355 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7356
7357         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7358         from...
7359         (rank_one_type): ... this.
7360
7361 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7362
7363         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7364         from...
7365         (rank_one_type): ... this.
7366
7367 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7368
7369         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7370         from...
7371         (rank_one_type): ... this.
7372
7373 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7374
7375         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7376         from...
7377         (rank_one_type): ... this.
7378
7379 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7380
7381         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7382         from...
7383         (rank_one_type): ... this.
7384
7385 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7386
7387         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7388         from...
7389         (rank_one_type): ... this.
7390
7391 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7392
7393         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7394         from...
7395         (rank_one_type): ... this.
7396
7397 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7398
7399         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7400         from...
7401         (rank_one_type): ... this.
7402
7403 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7404
7405         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7406         from...
7407         (rank_one_type): ... this.
7408
7409 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7410
7411         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7412         from...
7413         (rank_one_type): ... this.
7414
7415 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7416
7417         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7418         from...
7419         (rank_one_type): ... this.
7420
7421 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7422
7423         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7424         inferior-events' shows the example events.
7425
7426 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7427
7428         Support styling on native MS-Windows console
7429
7430         PR/24315
7431         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7432         on MS-Windows if $TERM is not defined.
7433
7434         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7435
7436         * posix-hdep.c (gdb_console_fputs):
7437         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7438         functions.
7439         * ui-file.h (gdb_console_fputs): Add prototype.
7440
7441         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7442         back to fputs only if the former returns zero.
7443
7444 2019-03-07  Tom Tromey  <tom@tromey.com>
7445
7446         * symmisc.c (print_symbol_bcache_statistics): Update.
7447         (print_objfile_statistics): Update.
7448         * symfile.c (allocate_symtab): Update.
7449         * stabsread.c: Don't include bcache.h.
7450         * psymtab.h (struct psymbol_bcache): Don't declare.
7451         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7452         (psymbol_bcache_init, psymbol_bcache_free)
7453         (psymbol_bcache_get_bcache): Don't declare.
7454         * psymtab.c (struct psymbol_bcache): Remove.
7455         (psymtab_storage::psymtab_storage): Update.
7456         (psymtab_storage::~psymtab_storage): Update.
7457         (psymbol_bcache_init, psymbol_bcache_free)
7458         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7459         (add_psymbol_to_bcache): Update.
7460         (allocate_psymtab): Update.
7461         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7462         macro_cache>: No longer pointers.
7463         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7464         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7465         * macrotab.c (macro_bcache): Update.
7466         * macroexp.c: Don't include bcache.h.
7467         * gdbtypes.c (check_types_worklist): Update.
7468         (types_deeply_equal): Remove TRY/CATCH.  Update.
7469         * elfread.c (elf_symtab_read): Update.
7470         * dwarf2read.c: Don't include bcache.h.
7471         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7472         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7473         (print_bcache_statistics, bcache_memory_used): Don't declare.
7474         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7475         methods.  Rename all data members.
7476         * bcache.c (struct bcache): Move to bcache.h.
7477         (bcache::expand_hash_table): Rename from expand_hash_table.
7478         (bcache): Remove.
7479         (bcache::insert): Rename from bcache_full.
7480         (bcache::compare): Rename from bcache_compare.
7481         (bcache_xmalloc): Remove.
7482         (bcache::~bcache): Rename from bcache_xfree.
7483         (bcache::print_statistics): Rename from print_bcache_statistics.
7484         (bcache::memory_used): Rename from bcache_memory_used.
7485
7486 2019-03-07  Pedro Alves  <palves@redhat.com>
7487
7488         * infrun.c (normal_stop): Also check for
7489         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7490
7491 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7492
7493         * f-lang.c (value_from_host_double): Moved to...
7494         * value.c (value_from_host_double): ...here.
7495         * value.h (value_from_host_double): Declare.
7496         * guile/scm-math.c (vlscm_convert_typed_number): Use
7497         value_from_host_double.
7498         (vlscm_convert_number): Likewise.
7499         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7500         * python/py-value.c (convert_value_from_python): Likewise.
7501
7502 2019-03-06  Tom Tromey  <tom@tromey.com>
7503
7504         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7505
7506 2019-03-06  Tom Tromey  <tom@tromey.com>
7507
7508         * utils.h (free_current_contents): Don't declare.
7509         * utils.c (free_current_contents): Remove.
7510
7511 2019-03-06  Tom Tromey  <tom@tromey.com>
7512
7513         * top.c (quit_force): Update.
7514         * main.c (captured_command_loop): Update.
7515         * common/new-op.c (operator new): Update.
7516         * common/common-exceptions.c (struct catcher)
7517         <save_cleanup_chain>: Remove member.
7518         (exceptions_state_mc_init): Update.
7519         (exception_try_scope_entry): Return nullptr.
7520         (exception_try_scope_exit, exception_rethrow)
7521         (throw_exception_sjlj, throw_exception_cxx): Update.
7522         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7523         (all_cleanups, do_cleanups, discard_cleanups)
7524         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7525         (restore_cleanups, restore_final_cleanups): Don't declare.
7526         (do_final_cleanups): Remove parameter.
7527         * common/cleanups.c (cleanup_chain, make_cleanup)
7528         (make_cleanup_dtor, all_cleanups, do_cleanups)
7529         (discard_my_cleanups, discard_cleanups)
7530         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7531         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7532         (null_cleanup): Remove.
7533         (do_final_cleanups): Remove parameter.
7534
7535 2019-03-06  Tom Tromey  <tom@tromey.com>
7536
7537         * remote.c (remote_target::remote_parse_stop_reply): Use
7538         unique_xmalloc_ptr.
7539
7540 2019-03-06  Tom Tromey  <tom@tromey.com>
7541
7542         * stabsread.c (struct stabs_field_info): Rename from field_info.
7543         <list, fnlist>: Add initializers.
7544         <obstack>: New member.
7545         (read_member_functions, read_struct_fields, read_baseclasses):
7546         Allocate on obstack.  Don't use cleanups.
7547         (read_one_struct_field, read_member_functions, read_struct_fields)
7548         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7549         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7550         (read_struct_type): Update.
7551
7552 2019-03-06  Tom Tromey  <tom@tromey.com>
7553
7554         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7555         * common/filestuff.h (make_cleanup_close): Don't declare.
7556         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7557         Remove.
7558
7559 2019-03-06  Tom Tromey  <tom@tromey.com>
7560
7561         * solib-aix.c: Use make_scope_exit.
7562
7563 2019-03-06  Tom Tromey  <tom@tromey.com>
7564
7565         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7566         Use make_scope_exit.
7567
7568 2019-03-06  Tom Tromey  <tom@tromey.com>
7569
7570         * solib-svr4.c (disable_probes_interface): Remove parameter.
7571         (svr4_handle_solib_event): Use make_scope_exit.
7572
7573 2019-03-06  Tom Tromey  <tom@tromey.com>
7574
7575         * remote.c (struct stop_reply_deleter): Remove.
7576         (stop_reply_up): Update.
7577         (struct stop_reply): Derive from notif_event.  Don't typedef.
7578         <regcache>: Now a std::vector.
7579         (stop_reply_xfree): Remove.
7580         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7581         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7582         (remote_target::discard_pending_stop_replies): Use delete.
7583         (remote_target::remote_parse_stop_reply): Update.
7584         (remote_target::process_stop_reply): Update.
7585         * remote-notif.h (struct notif_event): Add virtual destructor.
7586         Remove "dtr" member.
7587         (struct notif_client) <alloc_event>: Return a unique_ptr.
7588         (notif_event_xfree): Don't declare.
7589         (notif_event_up): New typedef.
7590         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7591         (notif_event_xfree, do_notif_event_xfree): Remove.
7592         (remote_notif_state_xfree): Update.
7593
7594 2019-03-06  Tom Tromey  <tom@tromey.com>
7595
7596         * infrun.c (displaced_step_clear_cleanup): Now a
7597         forward_scope_exit type.
7598         (displaced_step_prepare_throw): Update.
7599         (displaced_step_fixup): Update.
7600
7601 2019-03-06  Tom Tromey  <tom@tromey.com>
7602
7603         * inferior.h (class inferior): Update comment.
7604         * gdbthread.h (class thread_info): Update comment.
7605
7606 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7607             Tom Tromey  <tom@tromey.com>
7608
7609         * stabsread.h (struct stab_section_list): Remove.
7610         (coffstab_build_psymtabs): Update.
7611         * dbxread.c (symbuf_sections): Now a std::vector.
7612         (sect_idx): New global.
7613         (fill_symbuf): Update.
7614         (coffstab_build_psymtabs): Change type of stabsects parameter.
7615         Update.
7616         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7617         std::vector.
7618         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7619         (coff_locate_sections): Update.
7620         (coff_symfile_read): Remove cleanups.  Update.
7621         (init_stringtab): Add storage parameter.
7622         (free_stringtab, free_stringtab_cleanup): Remove.
7623         (init_lineno): Add storage parameter.
7624         (free_linetab, free_linetab_cleanup): Remove.
7625
7626 2019-03-06  Pedro Alves  <palves@redhat.com>
7627
7628         * linux-fork.c (fork_info::clobber_regs): Delete.
7629         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7630         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7631         comment.  Adjust.
7632         (scoped_switch_fork_info::scoped_switch_fork_info)
7633         (checkpoint_command, linux_fork_context): Adjust
7634         fork_save_infrun_state calls.
7635
7636 2019-03-06  Pedro Alves  <palves@redhat.com>
7637
7638         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7639         (inf_has_multiple_threads): Return 'bool' and rewrite using
7640         inferior_info::threads().
7641
7642 2019-03-06  Pedro Alves  <palves@redhat.com>
7643
7644         * linux-fork.c: Include <list>.
7645         (fork_list): Now a std::list instance.
7646         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7647         (forks_exist_p, find_last_fork): Adjust.
7648         (new_fork): Delete.
7649         (one_fork_p): New.
7650         (add_fork): Adjust.
7651         (free_fork): Delete, folded into fork_info::~fork_info().
7652         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7653         Adjust.
7654         (init_fork_list): Delete.
7655         (linux_fork_killall, linux_fork_mourn_inferior)
7656         (linux_fork_detach, info_checkpoints_command): Adjust.
7657         (_initialize_linux_fork): No longer call init_fork_list.
7658
7659 2019-03-06  Pedro Alves  <palves@redhat.com>
7660
7661         * linux-fork.c (new_fork): New, split out of ...
7662         (add_fork): ... this.  Return void.  Move "first fork" special
7663         case from here, to ...
7664         (checkpoint_command): ... here.
7665         * linux-linux.h (add_fork): Return void.
7666
7667 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7668
7669         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7670
7671 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7672             Chris January  <chris.january@arm.com>
7673             David Lecomber  <david.lecomber@arm.com>
7674
7675         * f-exp.y: New token, UNOP_INTRINSIC.
7676         (exp): New pattern using UNOP_INTRINSIC token.
7677         (f77_keywords): Add 'abs' keyword.
7678         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7679         (value_from_host_double): New function.
7680         (evaluate_subexp_f): Support UNOP_ABS.
7681
7682 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7683
7684         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7685         types.
7686
7687 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7688
7689         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7690         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7691         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7692
7693 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7694
7695         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7696
7697 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7698             Chris January  <chris.january@arm.com>
7699
7700         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7701         * f-exp.y: Define 'KIND' token.
7702         (exp): New pattern for KIND expressions.
7703         (ptype): Handle types with a kind extension.
7704         (direct_abs_decl): Extend to spot kind extensions.
7705         (f77_keywords): Add 'kind' to the list.
7706         (push_kind_type): New function.
7707         (convert_to_kind_type): New function.
7708         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7709         * parse.c (operator_length_standard): Likewise.
7710         * parser-defs.h (enum type_pieces): Add tp_kind.
7711         * std-operator.def: Add UNOP_KIND.
7712
7713 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7714
7715         * f-exp.y (f_parse): Set yydebug.
7716
7717 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7718
7719         * f-lang.c (evaluate_subexp_f): New function.
7720         (exp_descriptor_f): New global.
7721         (f_language_defn): Use exp_descriptor_f instead of
7722         exp_descriptor_standard.
7723
7724 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7725
7726         * f-exp.y (struct token): Add comments.
7727         (dot_ops): Remove uppercase versions and the end marker.
7728         (f77_keywords): Likewise.
7729         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7730         entries in the dot_ops array are case insensitive, and use
7731         strncasecmp to compare strings.  Also some whitespace cleanup in
7732         this area.  Similar for the f77_keywords array, except entries in
7733         this list might be case sensitive.
7734
7735 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7736
7737         * f-exp.y (struct f77_boolean_val): Add comments.
7738         (boolean_values): Remove uppercase versions, and end marker.
7739         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7740         and use strncasecmp to achieve case insensitivity.  Additionally,
7741         perform whitespace cleanup around this code.
7742
7743 2019-03-06  Tom Tromey  <tromey@adacore.com>
7744
7745         * remote-sim.c (gdbsim_target_open): Use result of
7746         gdb_argv::release.
7747
7748 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7749         Dirk Schubert  <dirk.schubert@arm.com>
7750         Chris January  <chris.january@arm.com>
7751
7752         * eval.c (evaluate_subexp_standard): Call Fortran argument
7753         wrapping logic.
7754         * f-lang.c (struct value): A value which can be passed into a
7755         Fortran function call.
7756         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7757         where appropriate.
7758         (struct type): Value ready for a Fortran function call.
7759         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7760         is needed.
7761         * f-lang.h (fortran_argument_convert): Declaration.
7762         (fortran_preserve_arg_pointer): Declaration.
7763         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7764
7765 2019-03-05  Tom Tromey  <tromey@adacore.com>
7766
7767         * python/py-prettyprint.c (print_string_repr): Remove #if.
7768         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7769
7770 2019-03-05  Tom Tromey  <tromey@adacore.com>
7771
7772         * target.c (the_dummy_target): Move later.  Change type to
7773         "dummy_target".
7774         (initialize_targets): Don't initialize the_dummy_target.
7775
7776 2019-03-05  Tom Tromey  <tromey@adacore.com>
7777
7778         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7779         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7780
7781 2019-03-05  Tom Tromey  <tromey@adacore.com>
7782
7783         * windows-nat.c (windows_nat_target::attach)
7784         (windows_nat_target::detach): Don't call gdb_flush.
7785         * valprint.c (generic_val_print, val_print, val_print_string):
7786         Don't call gdb_flush.
7787         * utils.c (defaulted_query): Don't call gdb_flush.
7788         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7789         * target.c (target_announce_detach): Don't call gdb_flush.
7790         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7791         * remote.c (extended_remote_target::attach): Don't call
7792         gdb_flush.
7793         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7794         * printcmd.c (do_examine): Don't call gdb_flush.
7795         (info_display_command): Don't call gdb_flush.
7796         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7797         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7798         * memattr.c (info_mem_command): Don't call gdb_flush.
7799         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7800         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7801         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7802         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7803         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7804         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7805         (gnu_nat_target::detach): Don't call gdb_flush.
7806         * f-valprint.c (f_val_print): Don't call gdb_flush.
7807         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7808         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7809         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7810         gdb_flush.
7811         * c-valprint.c (c_val_print): Don't call gdb_flush.
7812         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7813
7814 2019-03-05  Tom Tromey  <tromey@adacore.com>
7815
7816         * varobj.c (update_dynamic_varobj_children): Update.
7817         (install_default_visualizer): Use reset, not release.
7818         * value.c (set_internalvar): Update.
7819         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7820         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7821         ATTRIBUTE_UNUSED_RESULT.
7822
7823 2019-03-05  Tom Tromey  <tromey@adacore.com>
7824
7825         * remote.c (class scoped_remote_fd) <release>: Add
7826         ATTRIBUTE_UNUSED_RESULT.
7827
7828 2019-03-05  Tom Tromey  <tromey@adacore.com>
7829
7830         * macroexp.c (struct macro_buffer) <release>: Add
7831         ATTRIBUTE_UNUSED_RESULT.
7832
7833 2019-03-05  Tom Tromey  <tromey@adacore.com>
7834
7835         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7836         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7837         ATTRIBUTE_UNUSED_RESULT.
7838
7839 2019-03-05  Tom Tromey  <tromey@adacore.com>
7840
7841         * common/scoped_fd.h (class scoped_fd) <release>: Add
7842         ATTRIBUTE_UNUSED_RESULT.
7843
7844 2019-03-05  Tom Tromey  <tromey@adacore.com>
7845
7846         * parser-defs.h (struct parser_state) <release>: Add
7847         ATTRIBUTE_UNUSED_RESULT.
7848
7849 2019-03-05  Tom Tromey  <tromey@adacore.com>
7850
7851         * utils.h (class gdb_argv) <release>: Add
7852         ATTRIBUTE_UNUSED_RESULT.
7853         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7854
7855 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7856
7857         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7858         for-loop range, to avoid compiler warnings.
7859
7860         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7861         avoid compiler warnings about unused variables.
7862
7863         * NEWS: Mention end of support for native debugging on MS-Windows
7864         before XP.
7865
7866         PR gdb/24292
7867         * common/netstuff.c:
7868         * gdbserver/gdbreplay.c
7869         * gdbserver/remote-utils.c:
7870         * ser-tcp.c:
7871         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7872         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7873         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7874         'getaddrinfo' and 'freeaddrinfo' were not available before
7875         Windows XP, and mingw.org's MinGW headers by default define
7876         _WIN32_WINNT to 0x500.
7877
7878 2019-03-01  Gary Benson <gbenson@redhat.com>
7879
7880         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7881
7882 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7883             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7884
7885         PR gdb/8527
7886         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7887         set_sigint_trap, clear_sigint_trap.
7888
7889 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7890
7891         * target.c (target_detach): Clear the regcache and the
7892         frame cache.
7893
7894 2019-02-27  Pedro Alves  <palves@redhat.com>
7895
7896         * utils.c (set_screen_size): When we cap the height/width sizes,
7897         tweak the corresponding command variable to show "unlimited":
7898
7899 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7900             Pedro Alves  <palves@redhat.com>
7901
7902         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7903         before calling rl_set_screen_size.
7904
7905 2019-02-27  Tom Tromey  <tromey@adacore.com>
7906
7907         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7908         define.
7909         * python/py-value.c: Remove Python 2.4 workaround.
7910         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7911         workaround.
7912         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7913         Python 2.4 workaround.
7914         * python/python-internal.h: Remove Python 2.4 comment.
7915         (Py_ssize_t): Don't define.
7916         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7917         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7918         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7919         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7920         * python/python.c (do_start_initialization): Remove Python 2.4
7921         workaround.
7922         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7923         (print_children): Remove Python 2.4 workaround.
7924         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7925         workaround.
7926         (CHARBUFFERPROC_NAME): Remove.
7927         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7928         Python 2.4 workaround.
7929
7930 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7931
7932         * NEWS: Note minimum Python version.
7933
7934 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7935
7936         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7937         code from these functions.  Remove corresponding ifdefs.  Use
7938         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7939         Remove gotos and target of gotos.
7940         (infpy_search_memory): Likewise.
7941
7942 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7943
7944         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7945         (hppa_gdbarch_init): Don't register deleted functions with
7946         gdbarch.
7947
7948 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7949
7950         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7951         (h8300_unwind_sp): Delete.
7952         (h8300_dummy_id): Delete.
7953         (h8300_gdbarch_init): Don't register deleted functions with
7954         gdbarch.
7955
7956 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7957
7958         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7959         (ft32_unwind_pc): Delete.
7960         (ft32_unwind_sp): Delete.
7961         (ft32_gdbarch_init): Don't register deleted functions with
7962         gdbarch.
7963
7964 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7965
7966         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7967         (frv_unwind_pc): Delete.
7968         (frv_unwind_sp): Delete.
7969         (frv_gdbarch_init): Don't register deleted functions with
7970         gdbarch.
7971
7972 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7973
7974         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7975         (riscv_unwind_pc): Delete.
7976         (riscv_unwind_sp): Delete.
7977         (riscv_gdbarch_init): Don't register deleted functions with
7978         gdbarch.
7979
7980 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7981
7982         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7983         (csky_unwind_pc): Delete.
7984         (csky_unwind_sp): Delete.
7985         (csky_gdbarch_init): Don't register deleted functions with
7986         gdbarch.
7987
7988 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7989
7990         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7991         (cris_unwind_pc): Delete.
7992         (cris_unwind_sp): Delete.
7993         (cris_gdbarch_init): Don't register deleted functions with
7994         gdbarch.
7995
7996 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7997
7998         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7999         (bfin_unwind_pc): Delete.
8000         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8001
8002 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8003
8004         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8005         (arm_unwind_pc): Delete.
8006         (arm_unwind_sp): Delete.
8007         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8008
8009 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8010
8011         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8012         (arc_unwind_pc): Delete.
8013         (arc_unwind_sp): Delete.
8014         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8015
8016 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8017
8018         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8019         (alpha_unwind_pc): Delete.
8020         (alpha_gdbarch_init): Don't register deleted functions with
8021         gdbarch.
8022
8023 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8024
8025         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8026         (aarch64_unwind_pc): Delete.
8027         (aarch64_unwind_sp): Delete.
8028         (aarch64_gdbarch_init): Don't register deleted functions with
8029         gdbarch.
8030
8031 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8032
8033         * gdbtypes.c (type_align): Don't consider static members when
8034         computing structure alignment.
8035
8036 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8037
8038         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8039         return 0 for other types.
8040         * arch-utils.c (default_type_align): Always return 0.
8041         * gdbarch.h: Regenerate.
8042         * gdbarch.sh (type_align): Extend comment.
8043         * gdbtypes.c (type_align): Add additional comments, always call
8044         gdbarch_type_align before applying the default rules.
8045         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8046         generic code will then apply a suitable default.
8047         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8048         types, return 0 for other types.
8049
8050 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8051
8052         * NEWS: Create a new section for the next release branch.
8053         Rename the section of the current branch, now that it has
8054         been cut.
8055
8056 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8057
8058         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8059         * version.in: Bump version to 8.3.50.DATE-git.
8060
8061 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8062
8063         * aix-thread.c (ptid_cmp): Remove unused variable.
8064         (get_signaled_thread): Likewise.
8065         (store_regs_user_thread): Likewise.
8066         (store_regs_kernel_thread): Likewise.
8067         (fetch_regs_kernel_thread): Remove shadowed variable.
8068
8069 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8070
8071         * features/riscv/32bit-cpu.xml: Add register numbers.
8072         * features/riscv/32bit-fpu.c: Regenerate.
8073         * features/riscv/32bit-fpu.xml: Add register numbers.
8074         * features/riscv/64bit-cpu.xml: Add register numbers.
8075         * features/riscv/64bit-fpu.c: Regenerate.
8076         * features/riscv/64bit-fpu.xml: Add register numbers.
8077
8078 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8079
8080         * NEWS: Mention two argument form of gdb.Value constructor.
8081         * python/py-value.c (convert_buffer_and_type_to_value): New
8082         function.
8083         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8084         Add support for handling an optional second argument.  Call
8085         convert_buffer_and_type_to_value as appropriate.
8086         * python/python-internal.h (Py_buffer_deleter): New struct.
8087         (Py_buffer_up): New typedef.
8088
8089 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8090
8091         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8092         instead of releasing ownership.
8093
8094 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8095
8096         * dwarf2read.c (open_and_init_dwp_file): Call
8097         elf_numsections instead of bfd_count_sections to initialize
8098         dwp_file->num_sections.
8099
8100 2019-02-25  Tom Tromey  <tromey@adacore.com>
8101
8102         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8103
8104 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8105
8106         * gcore.in: Add '--readnever' option when invoking GDB.
8107
8108 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8109
8110         * MAINTAINERS: Update my email address.
8111
8112 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8113
8114         * build-id.c (build_id_to_debug_bfd_1): New function.
8115         (build_id_to_debug_bfd): Look for separate debug file in
8116         sysroot.
8117
8118 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8119
8120         * gdbarch.sh: Update the copyright year range that is placed into
8121         generated files.
8122
8123 2019-02-22  Keith Seitz  <keiths@redhat.com>
8124
8125         PR symtab/23853
8126         * linespec.c (create_sals_line_offset): Search for the default
8127         symtab's filename instead of its fullname.
8128
8129 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8130
8131         * NEWS: Update style defaults.
8132
8133 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8134
8135         * main.c (captured_main_1): Disable styling in batch mode.
8136
8137 2019-02-20  Tom Tromey  <tom@tromey.com>
8138
8139         * symtab.c (symtab_symbol_info): Fix typos.
8140
8141 2019-02-20  Tom Tromey  <tromey@adacore.com>
8142
8143         * findcmd.c (_initialize_mem_search): Use upper case for
8144         metasyntactic variables.
8145
8146 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8147
8148         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8149         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8150
8151 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8152
8153         * top.h (source_file_name): Change to std::string.
8154         * top.c (source_file_name): Likewise.
8155         (command_line_input): Adjust.
8156         * cli/cli-script.c (script_from_file): Adjust.
8157
8158 2019-02-19  Tom Tromey  <tromey@adacore.com>
8159
8160         * ravenscar-thread.c
8161         (ravenscar_thread_target::update_thread_list): Don't call
8162         ada_build_task_list.
8163         * ada-lang.h (ada_build_task_list): Don't declare.
8164         * ada-tasks.c (struct ada_tasks_inferior_data)
8165         <task_list_valid_p>: Now bool.
8166         (read_known_tasks, ada_task_list_changed)
8167         (ada_tasks_invalidate_inferior_data): Update.
8168         (read_known_tasks_array): Return bool.
8169         (read_known_tasks_list): Likewise.
8170         (read_known_tasks): Return void.
8171         (ada_build_task_list): Now static.
8172
8173 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8174
8175         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8176         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8177
8178 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8179
8180         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8181         variant for ada_tasks_pspace_data_handle and
8182         ada_tasks_inferior_data_handle.
8183         (ada_tasks_pspace_data_cleanup): New function.
8184         (ada_tasks_inferior_data_cleanup): New function.
8185
8186 2019-02-17  Tom Tromey  <tom@tromey.com>
8187
8188         * macrotab.h (macro_source_fullname): Return a std::string.
8189         * macrotab.c (macro_include, check_for_redefinition)
8190         (macro_undef, macro_lookup_definition, foreach_macro)
8191         (foreach_macro_in_scope): Update.
8192         (macro_source_fullname): Return a std::string.
8193         * macrocmd.c (show_pp_source_pos): Update.
8194
8195 2019-02-17  Tom Tromey  <tom@tromey.com>
8196
8197         * macrocmd.c (show_pp_source_pos): Style the file names.
8198
8199 2019-02-17  Tom Tromey  <tom@tromey.com>
8200
8201         PR tui/24197:
8202         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8203
8204 2019-02-17  Tom Tromey  <tom@tromey.com>
8205
8206         * ada-lang.c (user_select_syms): Use filtered printing.
8207         * utils.c (wrap_style): New global.
8208         (desired_style): Remove.
8209         (emit_style_escape): Add stream parameter.
8210         (set_output_style, reset_terminal_style, prompt_for_continue):
8211         Update.
8212         (flush_wrap_buffer): Only flush gdb_stdout.
8213         (wrap_here): Set wrap_style.
8214         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8215         treat escape sequences as a character.  Change when wrap buffer is
8216         flushed.
8217         (fputs_styled): Do not set the output style when the default is
8218         requested.
8219         * ui-style.h (struct ui_file_style) <is_default>: New method.
8220         * source.c (print_source_lines_base): Emit escape sequences in one
8221         piece.
8222
8223 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8224
8225         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8226         integers and enumeration types.
8227
8228 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8229
8230         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8231         instead of lookup_symbol_in_language
8232         (do_exact_match): New function.
8233         (ada_get_symbol_name_matcher): Return do_exact_match when
8234         doing a verbatim match.
8235
8236 2019-02-15  Tom Tromey  <tromey@adacore.com>
8237
8238         * ravenscar-thread.c (ravenscar_thread_target::resume)
8239         (ravenscar_thread_target::wait): Special case wildcard requests.
8240
8241 2019-02-15  Tom Tromey  <tromey@adacore.com>
8242
8243         * ravenscar-thread.c (base_ptid): Remove.
8244         (struct ravenscar_thread_target) <close>: New method.
8245         <m_base_ptid>: New member.
8246         <update_inferior_ptid, active_task, task_is_currently_active,
8247         runtime_initialized>: Declare methods.
8248         <ravenscar_thread_target>: Add constructor.
8249         (ravenscar_thread_target::task_is_currently_active)
8250         (ravenscar_thread_target::update_inferior_ptid)
8251         (ravenscar_runtime_initialized): Rename.  Now methods.
8252         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8253         (ravenscar_thread_target::update_thread_list): Update.
8254         (ravenscar_thread_target::active_task): Now method.
8255         (ravenscar_thread_target::store_registers)
8256         (ravenscar_thread_target::prepare_to_store)
8257         (ravenscar_thread_target::prepare_to_store)
8258         (ravenscar_thread_target::mourn_inferior): Update.
8259         (ravenscar_inferior_created): Use "new" to create target.
8260         (ravenscar_thread_target::get_ada_task_ptid): Update.
8261         (_initialize_ravenscar): Don't initialize base_ptid.
8262         (ravenscar_ops): Remove global.
8263
8264 2019-02-15  Tom Tromey  <tromey@adacore.com>
8265
8266         * target.h (push_target): Declare new overload.
8267         * target.c (push_target): New overload, taking an rvalue reference.
8268         * remote.c (remote_target::open_1): Use push_target overload.
8269         * corelow.c (core_target_open): Use push_target overload.
8270
8271 2019-02-15  Tom Tromey  <tromey@adacore.com>
8272
8273         * ravenscar-thread.c (is_ravenscar_task)
8274         (ravenscar_task_is_currently_active): Return bool.
8275         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8276         (_initialize_ravenscar): Remove "(void)".
8277         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8278         Return bool.
8279
8280 2019-02-15  Tom Tromey  <tromey@adacore.com>
8281
8282         * ravenscar-thread.c (ravenscar_runtime_initializer)
8283         (has_ravenscar_runtime, get_running_thread_id)
8284         (ravenscar_thread_target::resume): Fix indentation.
8285
8286 2019-02-15  Tom Tromey  <tromey@adacore.com>
8287
8288         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8289         from ravenscar_arch_ops.
8290         (sparc_ravenscar_ops::fetch_registers)
8291         (sparc_ravenscar_ops::store_registers): Now methods.
8292         (sparc_ravenscar_prepare_to_store): Remove.
8293         (sparc_ravenscar_ops): Redefine.
8294         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8295         methods and destructor.  Remove members.
8296         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8297         (ravenscar_thread_target::store_registers)
8298         (ravenscar_thread_target::prepare_to_store): Update.
8299         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8300         Remove.
8301         (struct ppc_ravenscar_powerpc_ops): Derive from
8302         ravenscar_arch_ops.
8303         (ppc_ravenscar_powerpc_ops::fetch_registers)
8304         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8305         (ppc_ravenscar_powerpc_ops): Redefine.
8306         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8307         (ppc_ravenscar_e500_ops::fetch_registers)
8308         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8309         (ppc_ravenscar_e500_ops): Redefine.
8310         * aarch64-ravenscar-thread.c
8311         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8312         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8313         (aarch64_ravenscar_fetch_registers)
8314         (aarch64_ravenscar_store_registers): Now methods.
8315         (aarch64_ravenscar_ops): Redefine.
8316
8317 2019-02-15  Tom Tromey  <tromey@adacore.com>
8318
8319         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8320         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8321         (ravenscar_thread_target::stopped_by_watchpoint)
8322         (ravenscar_thread_target::stopped_data_address)
8323         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8324
8325 2019-02-15  Tom Tromey  <tromey@adacore.com>
8326
8327         * ravenscar-thread.c: Fix some typos.
8328
8329 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8330             Tom Tromey  <tromey@adacore.com>
8331
8332         * ada-lang.c (ada_exception_sal): Change addr_string to a
8333         std::string.
8334         (create_ada_exception_catchpoint): Update.
8335
8336 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8337             Tom Tromey  <tromey@adacore.com>
8338
8339         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8340         (bp_location_ops): Remove.
8341         (base_breakpoint_allocate_location): Update.
8342         (free_bp_location): Update.
8343         * ada-lang.c (class ada_catchpoint_location)
8344         <ada_catchpoint_location>: Remove ops parameter.
8345         (ada_catchpoint_location_dtor): Remove.
8346         (ada_catchpoint_location_ops): Remove.
8347         (allocate_location_exception): Update.
8348         * breakpoint.h (struct bp_location_ops): Remove.
8349         (class bp_location) <bp_location>: Remove bp_location_ops
8350         parameter.
8351         <~bp_location>: Add destructor.
8352         <ops>: Remove.
8353
8354 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8355             Pedro Alves  <palves@redhat.com>
8356
8357         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8358         'PATH_MAX'.
8359
8360 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8361             Samuel Thibault  <samuel.thibault@gnu.org>
8362             Thomas Schwinge  <thomas@codesourcery.com>
8363
8364         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8365         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8366
8367 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8368
8369         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8370         (check_empty): Use "const char *".
8371
8372         * gnu-nat.c (gnu_nat_target::detach): Instead of
8373         'detach_inferior (pid)' call
8374         'detach_inferior (find_inferior_pid (pid))'.
8375
8376         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8377         'nat/fork-inferior.o'.
8378         * gnu-nat.c: #include "nat/fork-inferior.h".
8379
8380         * gnu-nat.c (gnu_nat_target::detach): Instead of
8381         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8382         * gnu-nat.h: #include "inf-child.h".
8383         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8384         'i386_gnu_nat_target::fetch_registers'.
8385         (gnu_store_registers): Rename/move to
8386         'i386_gnu_nat_target::store_registers'.
8387
8388         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8389         * gnu-nat.h (mach_thread_info): New function.
8390         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8391
8392         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8393
8394 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8395
8396         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8397
8398 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8399
8400         * windows-nat.c (windows_add_thread): Add new parameter
8401         "main_thread_p" with default value set to false.  Update
8402         function documentation as well as all callers.
8403         (windows_delete_thread): Likewise.
8404         (fake_create_process): Update call to windows_add_thread.
8405         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8406         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8407         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8408         call to windows_delete_thread.
8409
8410 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8411
8412         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8413
8414 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8415
8416         * symfile.c (find_separate_debug_file): Use canonical path of
8417         sysroot with child_path instead of gdb_sysroot if it is valid.
8418
8419 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8420
8421         * symfile.c (find_separate_debug_file): Use child_path to
8422         determine if an object file is under a sysroot.
8423
8424 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8425
8426         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8427         unittests/child-path-selftests.c.
8428         * common/pathstuff.c (child_path): New function.
8429         * common/pathstuff.h (child_path): New prototype.
8430         * unittests/child-path-selftests.c: New file.
8431
8432 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8433
8434         * symfile.c (find_separate_debug_file): Look for separate debug
8435         files in debug directories under the sysroot.
8436
8437 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8438
8439         * symtab.h (struct minimal_symbol data_p): New const method.
8440         (struct minimal_symbol text_p): Likewise.
8441         * symtab.c (output_source_filename): Use file name style
8442         to print file name.
8443         (print_symbol_info): Likewise.
8444         (print_msymbol_info): Use address style to print addresses.
8445         Use function name style to print executable text symbols.
8446         (expand_symtab_containing_pc): Use data_p.
8447         (find_pc_sect_compunit_symtab): Likewise.
8448
8449 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8450
8451         * breakpoint.c (describe_other_breakpoints): Use address style
8452         to print addresses.
8453         (say_where): Likewise.
8454
8455 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8456
8457         * ada-typeprint.c (print_func_type): Print function name
8458         style to print function name.
8459         * c-typeprint.c (c_print_type_1): Likewise.
8460
8461 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8462
8463         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8464         for execve.
8465
8466 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8467
8468         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8469         type_stack.
8470
8471 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8472
8473         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8474         TYPE_CODE_REF types.
8475
8476 2019-02-08  Jim Wilson  <jimw@sifive.com>
8477
8478         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8479         (riscv_linux_fregset): New.
8480         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8481
8482 2019-02-07  Tom Tromey  <tom@tromey.com>
8483
8484         * thread.c (thread_cancel_execution_command): Update.
8485         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8486         methods.
8487         (struct thread_fsm_ops): Remove.
8488         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8489         (thread_fsm_should_stop, thread_fsm_return_value)
8490         (thread_fsm_set_finished, thread_fsm_finished_p)
8491         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8492         Don't declare.
8493         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8494         * infrun.c (clear_proceed_status_thread)
8495         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8496         (print_stop_event): Update.
8497         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8498         Add constructor.
8499         (step_command_fsm_ops): Remove.
8500         (new_step_command_fsm): Remove.
8501         (step_1): Update.
8502         (step_command_fsm::should_stop): Rename from
8503         step_command_fsm_should_stop.
8504         (step_command_fsm::clean_up): Rename from
8505         step_command_fsm_clean_up.
8506         (step_command_fsm::do_async_reply_reason): Rename from
8507         step_command_fsm_async_reply_reason.
8508         (struct until_next_fsm): Inherit from thread_fsm.  Add
8509         constructor.
8510         (until_next_fsm_ops): Remove.
8511         (new_until_next_fsm): Remove.
8512         (until_next_fsm::should_stop): Rename from
8513         until_next_fsm_should_stop.
8514         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8515         (until_next_fsm::do_async_reply_reason): Rename from
8516         until_next_fsm_async_reply_reason.
8517         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8518         constructor.  Change type of breakpoint.
8519         (finish_command_fsm_ops): Remove.
8520         (new_finish_command_fsm): Remove.
8521         (finish_command_fsm::should_stop): Rename from
8522         finish_command_fsm_should_stop.
8523         (finish_command_fsm::clean_up): Rename from
8524         finish_command_fsm_clean_up.
8525         (finish_command_fsm::return_value): Rename from
8526         finish_command_fsm_return_value.
8527         (finish_command_fsm::do_async_reply_reason): Rename from
8528         finish_command_fsm_async_reply_reason.
8529         (finish_command): Update.
8530         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8531         Add constructor.
8532         (call_thread_fsm_ops): Remove.
8533         (call_thread_fsm::call_thread_fsm): Rename from
8534         new_call_thread_fsm.
8535         (call_thread_fsm::should_stop): Rename from
8536         call_thread_fsm_should_stop.
8537         (call_thread_fsm::should_notify_stop): Rename from
8538         call_thread_fsm_should_notify_stop.
8539         (run_inferior_call, call_function_by_hand_dummy): Update.
8540         * cli/cli-interp.c (should_print_stop_to_console): Update.
8541         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8542         Add constructor.  Change type of location_breakpoint,
8543         caller_breakpoint.
8544         (until_break_fsm_ops): Remove.
8545         (new_until_break_fsm): Remove.
8546         (until_break_fsm::should_stop): Rename from
8547         until_break_fsm_should_stop.
8548         (until_break_fsm::clean_up): Rename from
8549         until_break_fsm_clean_up.
8550         (until_break_fsm::do_async_reply_reason): Rename from
8551         until_break_fsm_async_reply_reason.
8552         (until_break_command): Update.
8553         * thread-fsm.c: Remove.
8554         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8555
8556 2019-02-07  Tom Tromey  <tom@tromey.com>
8557
8558         * yy-remap.h: Add include guard.
8559         * xtensa-tdep.h: Add include guard.
8560         * xcoffread.h: Rename include guard.
8561         * varobj-iter.h: Add include guard.
8562         * tui/tui.h: Rename include guard.
8563         * tui/tui-winsource.h: Rename include guard.
8564         * tui/tui-wingeneral.h: Rename include guard.
8565         * tui/tui-windata.h: Rename include guard.
8566         * tui/tui-win.h: Rename include guard.
8567         * tui/tui-stack.h: Rename include guard.
8568         * tui/tui-source.h: Rename include guard.
8569         * tui/tui-regs.h: Rename include guard.
8570         * tui/tui-out.h: Rename include guard.
8571         * tui/tui-layout.h: Rename include guard.
8572         * tui/tui-io.h: Rename include guard.
8573         * tui/tui-hooks.h: Rename include guard.
8574         * tui/tui-file.h: Rename include guard.
8575         * tui/tui-disasm.h: Rename include guard.
8576         * tui/tui-data.h: Rename include guard.
8577         * tui/tui-command.h: Rename include guard.
8578         * tic6x-tdep.h: Add include guard.
8579         * target/waitstatus.h: Rename include guard.
8580         * target/wait.h: Rename include guard.
8581         * target/target.h: Rename include guard.
8582         * target/resume.h: Rename include guard.
8583         * target-float.h: Rename include guard.
8584         * stabsread.h: Add include guard.
8585         * rs6000-tdep.h: Add include guard.
8586         * riscv-fbsd-tdep.h: Add include guard.
8587         * regformats/regdef.h: Rename include guard.
8588         * record.h: Rename include guard.
8589         * python/python.h: Rename include guard.
8590         * python/python-internal.h: Rename include guard.
8591         * python/py-stopevent.h: Rename include guard.
8592         * python/py-ref.h: Rename include guard.
8593         * python/py-record.h: Rename include guard.
8594         * python/py-record-full.h: Rename include guard.
8595         * python/py-record-btrace.h: Rename include guard.
8596         * python/py-instruction.h: Rename include guard.
8597         * python/py-events.h: Rename include guard.
8598         * python/py-event.h: Rename include guard.
8599         * procfs.h: Add include guard.
8600         * proc-utils.h: Add include guard.
8601         * p-lang.h: Add include guard.
8602         * or1k-tdep.h: Rename include guard.
8603         * observable.h: Rename include guard.
8604         * nto-tdep.h: Rename include guard.
8605         * nat/x86-linux.h: Rename include guard.
8606         * nat/x86-linux-dregs.h: Rename include guard.
8607         * nat/x86-gcc-cpuid.h: Add include guard.
8608         * nat/x86-dregs.h: Rename include guard.
8609         * nat/x86-cpuid.h: Rename include guard.
8610         * nat/ppc-linux.h: Rename include guard.
8611         * nat/mips-linux-watch.h: Rename include guard.
8612         * nat/linux-waitpid.h: Rename include guard.
8613         * nat/linux-ptrace.h: Rename include guard.
8614         * nat/linux-procfs.h: Rename include guard.
8615         * nat/linux-osdata.h: Rename include guard.
8616         * nat/linux-nat.h: Rename include guard.
8617         * nat/linux-namespaces.h: Rename include guard.
8618         * nat/linux-btrace.h: Rename include guard.
8619         * nat/glibc_thread_db.h: Rename include guard.
8620         * nat/gdb_thread_db.h: Rename include guard.
8621         * nat/gdb_ptrace.h: Rename include guard.
8622         * nat/fork-inferior.h: Rename include guard.
8623         * nat/amd64-linux-siginfo.h: Rename include guard.
8624         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8625         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8626         * nat/aarch64-linux.h: Rename include guard.
8627         * nat/aarch64-linux-hw-point.h: Rename include guard.
8628         * mn10300-tdep.h: Add include guard.
8629         * mips-linux-tdep.h: Add include guard.
8630         * mi/mi-parse.h: Rename include guard.
8631         * mi/mi-out.h: Rename include guard.
8632         * mi/mi-main.h: Rename include guard.
8633         * mi/mi-interp.h: Rename include guard.
8634         * mi/mi-getopt.h: Rename include guard.
8635         * mi/mi-console.h: Rename include guard.
8636         * mi/mi-common.h: Rename include guard.
8637         * mi/mi-cmds.h: Rename include guard.
8638         * mi/mi-cmd-break.h: Rename include guard.
8639         * m2-lang.h: Add include guard.
8640         * location.h: Rename include guard.
8641         * linux-record.h: Rename include guard.
8642         * linux-nat.h: Add include guard.
8643         * linux-fork.h: Add include guard.
8644         * i386-darwin-tdep.h: Rename include guard.
8645         * hppa-linux-offsets.h: Add include guard.
8646         * guile/guile.h: Rename include guard.
8647         * guile/guile-internal.h: Rename include guard.
8648         * gnu-nat.h: Rename include guard.
8649         * gdb-stabs.h: Rename include guard.
8650         * frv-tdep.h: Add include guard.
8651         * f-lang.h: Add include guard.
8652         * event-loop.h: Add include guard.
8653         * darwin-nat.h: Rename include guard.
8654         * cp-abi.h: Rename include guard.
8655         * config/sparc/nm-sol2.h: Rename include guard.
8656         * config/nm-nto.h: Rename include guard.
8657         * config/nm-linux.h: Add include guard.
8658         * config/i386/nm-i386gnu.h: Rename include guard.
8659         * config/djgpp/nl_types.h: Rename include guard.
8660         * config/djgpp/langinfo.h: Rename include guard.
8661         * compile/gcc-cp-plugin.h: Add include guard.
8662         * compile/gcc-c-plugin.h: Add include guard.
8663         * compile/compile.h: Rename include guard.
8664         * compile/compile-object-run.h: Rename include guard.
8665         * compile/compile-object-load.h: Rename include guard.
8666         * compile/compile-internal.h: Rename include guard.
8667         * compile/compile-cplus.h: Rename include guard.
8668         * compile/compile-c.h: Rename include guard.
8669         * common/xml-utils.h: Rename include guard.
8670         * common/x86-xstate.h: Rename include guard.
8671         * common/version.h: Rename include guard.
8672         * common/vec.h: Rename include guard.
8673         * common/tdesc.h: Rename include guard.
8674         * common/selftest.h: Rename include guard.
8675         * common/scoped_restore.h: Rename include guard.
8676         * common/scoped_mmap.h: Rename include guard.
8677         * common/scoped_fd.h: Rename include guard.
8678         * common/safe-iterator.h: Rename include guard.
8679         * common/run-time-clock.h: Rename include guard.
8680         * common/refcounted-object.h: Rename include guard.
8681         * common/queue.h: Rename include guard.
8682         * common/ptid.h: Rename include guard.
8683         * common/print-utils.h: Rename include guard.
8684         * common/preprocessor.h: Rename include guard.
8685         * common/pathstuff.h: Rename include guard.
8686         * common/observable.h: Rename include guard.
8687         * common/netstuff.h: Rename include guard.
8688         * common/job-control.h: Rename include guard.
8689         * common/host-defs.h: Rename include guard.
8690         * common/gdb_wait.h: Rename include guard.
8691         * common/gdb_vecs.h: Rename include guard.
8692         * common/gdb_unlinker.h: Rename include guard.
8693         * common/gdb_unique_ptr.h: Rename include guard.
8694         * common/gdb_tilde_expand.h: Rename include guard.
8695         * common/gdb_sys_time.h: Rename include guard.
8696         * common/gdb_string_view.h: Rename include guard.
8697         * common/gdb_splay_tree.h: Rename include guard.
8698         * common/gdb_setjmp.h: Rename include guard.
8699         * common/gdb_ref_ptr.h: Rename include guard.
8700         * common/gdb_optional.h: Rename include guard.
8701         * common/gdb_locale.h: Rename include guard.
8702         * common/gdb_assert.h: Rename include guard.
8703         * common/filtered-iterator.h: Rename include guard.
8704         * common/filestuff.h: Rename include guard.
8705         * common/fileio.h: Rename include guard.
8706         * common/environ.h: Rename include guard.
8707         * common/common-utils.h: Rename include guard.
8708         * common/common-types.h: Rename include guard.
8709         * common/common-regcache.h: Rename include guard.
8710         * common/common-inferior.h: Rename include guard.
8711         * common/common-gdbthread.h: Rename include guard.
8712         * common/common-exceptions.h: Rename include guard.
8713         * common/common-defs.h: Rename include guard.
8714         * common/common-debug.h: Rename include guard.
8715         * common/cleanups.h: Rename include guard.
8716         * common/buffer.h: Rename include guard.
8717         * common/btrace-common.h: Rename include guard.
8718         * common/break-common.h: Rename include guard.
8719         * cli/cli-utils.h: Rename include guard.
8720         * cli/cli-style.h: Rename include guard.
8721         * cli/cli-setshow.h: Rename include guard.
8722         * cli/cli-script.h: Rename include guard.
8723         * cli/cli-interp.h: Rename include guard.
8724         * cli/cli-decode.h: Rename include guard.
8725         * cli/cli-cmds.h: Rename include guard.
8726         * charset-list.h: Add include guard.
8727         * buildsym-legacy.h: Rename include guard.
8728         * bfin-tdep.h: Add include guard.
8729         * ax.h: Rename include guard.
8730         * arm-linux-tdep.h: Add include guard.
8731         * arm-fbsd-tdep.h: Add include guard.
8732         * arch/xtensa.h: Rename include guard.
8733         * arch/tic6x.h: Add include guard.
8734         * arch/i386.h: Add include guard.
8735         * arch/arm.h: Rename include guard.
8736         * arch/arm-linux.h: Rename include guard.
8737         * arch/arm-get-next-pcs.h: Rename include guard.
8738         * arch/amd64.h: Add include guard.
8739         * arch/aarch64-insn.h: Rename include guard.
8740         * arch-utils.h: Rename include guard.
8741         * annotate.h: Add include guard.
8742         * amd64-darwin-tdep.h: Rename include guard.
8743         * aarch64-linux-tdep.h: Add include guard.
8744         * aarch64-fbsd-tdep.h: Add include guard.
8745         * aarch32-linux-nat.h: Add include guard.
8746
8747 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8748
8749         * macrotab.c (macro_define_internal): New function that
8750         factorizes macro_define_object_internal and macro_define_function
8751         code.
8752         (macro_define_object_internal): Use macro_define_internal.
8753         (macro_define_function): Likewise.
8754
8755 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8756
8757         * macrocmd.c (extract_identifier): Return
8758         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8759         callers.
8760
8761 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8762
8763         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8764
8765 2019-02-05  Tom Tromey  <tom@tromey.com>
8766
8767         * target.c (target_stack::unpush): Move assertion earlier.
8768
8769 2019-01-30  Tom Tromey  <tom@tromey.com>
8770
8771         PR python/23615:
8772         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8773         (gdbpy_parse_and_eval): Likewise.
8774         * python/python-internal.h (gdbpy_allow_threads): New class.
8775
8776 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8777
8778         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8779         (aarch64_fbsd_fpregmap): Move earlier.
8780         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8781         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8782         instead of individual calls to trad_frame_set_reg_addr.
8783         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8784         earlier.
8785         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8786         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8787         instead of individual calls to trad_frame_set_reg_addr.
8788
8789 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8790
8791         * CONTRIBUTE: Replace contribution list with wiki link.
8792
8793 2019-01-25  Tom Tromey  <tom@tromey.com>
8794
8795         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8796
8797 2019-01-25  Tom Tromey  <tom@tromey.com>
8798
8799         * xtensa-linux-nat.c: Fix common/ includes.
8800         * xml-support.h: Fix common/ includes.
8801         * xml-support.c: Fix common/ includes.
8802         * x86-linux-nat.c: Fix common/ includes.
8803         * windows-nat.c: Fix common/ includes.
8804         * varobj.h: Fix common/ includes.
8805         * varobj.c: Fix common/ includes.
8806         * value.c: Fix common/ includes.
8807         * valops.c: Fix common/ includes.
8808         * utils.c: Fix common/ includes.
8809         * unittests/xml-utils-selftests.c: Fix common/ includes.
8810         * unittests/utils-selftests.c: Fix common/ includes.
8811         * unittests/unpack-selftests.c: Fix common/ includes.
8812         * unittests/tracepoint-selftests.c: Fix common/ includes.
8813         * unittests/style-selftests.c: Fix common/ includes.
8814         * unittests/string_view-selftests.c: Fix common/ includes.
8815         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8816         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8817         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8818         * unittests/rsp-low-selftests.c: Fix common/ includes.
8819         * unittests/parse-connection-spec-selftests.c: Fix common/
8820         includes.
8821         * unittests/optional-selftests.c: Fix common/ includes.
8822         * unittests/offset-type-selftests.c: Fix common/ includes.
8823         * unittests/observable-selftests.c: Fix common/ includes.
8824         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8825         * unittests/memrange-selftests.c: Fix common/ includes.
8826         * unittests/memory-map-selftests.c: Fix common/ includes.
8827         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8828         * unittests/function-view-selftests.c: Fix common/ includes.
8829         * unittests/environ-selftests.c: Fix common/ includes.
8830         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8831         * unittests/common-utils-selftests.c: Fix common/ includes.
8832         * unittests/cli-utils-selftests.c: Fix common/ includes.
8833         * unittests/array-view-selftests.c: Fix common/ includes.
8834         * ui-file.c: Fix common/ includes.
8835         * tui/tui-io.c: Fix common/ includes.
8836         * tracepoint.h: Fix common/ includes.
8837         * tracepoint.c: Fix common/ includes.
8838         * tracefile-tfile.c: Fix common/ includes.
8839         * top.h: Fix common/ includes.
8840         * top.c: Fix common/ includes.
8841         * thread.c: Fix common/ includes.
8842         * target/waitstatus.h: Fix common/ includes.
8843         * target/waitstatus.c: Fix common/ includes.
8844         * target.h: Fix common/ includes.
8845         * target.c: Fix common/ includes.
8846         * target-memory.c: Fix common/ includes.
8847         * target-descriptions.c: Fix common/ includes.
8848         * symtab.h: Fix common/ includes.
8849         * symfile.c: Fix common/ includes.
8850         * stap-probe.c: Fix common/ includes.
8851         * spu-linux-nat.c: Fix common/ includes.
8852         * sparc-nat.c: Fix common/ includes.
8853         * source.c: Fix common/ includes.
8854         * solib.c: Fix common/ includes.
8855         * solib-target.c: Fix common/ includes.
8856         * ser-unix.c: Fix common/ includes.
8857         * ser-tcp.c: Fix common/ includes.
8858         * ser-pipe.c: Fix common/ includes.
8859         * ser-base.c: Fix common/ includes.
8860         * selftest-arch.c: Fix common/ includes.
8861         * s12z-tdep.c: Fix common/ includes.
8862         * rust-exp.y: Fix common/ includes.
8863         * rs6000-aix-tdep.c: Fix common/ includes.
8864         * riscv-tdep.c: Fix common/ includes.
8865         * remote.c: Fix common/ includes.
8866         * remote-notif.h: Fix common/ includes.
8867         * remote-fileio.h: Fix common/ includes.
8868         * remote-fileio.c: Fix common/ includes.
8869         * regcache.h: Fix common/ includes.
8870         * regcache.c: Fix common/ includes.
8871         * record-btrace.c: Fix common/ includes.
8872         * python/python.c: Fix common/ includes.
8873         * python/py-type.c: Fix common/ includes.
8874         * python/py-inferior.c: Fix common/ includes.
8875         * progspace.h: Fix common/ includes.
8876         * producer.c: Fix common/ includes.
8877         * procfs.c: Fix common/ includes.
8878         * proc-api.c: Fix common/ includes.
8879         * printcmd.c: Fix common/ includes.
8880         * ppc-linux-nat.c: Fix common/ includes.
8881         * parser-defs.h: Fix common/ includes.
8882         * osdata.c: Fix common/ includes.
8883         * obsd-nat.c: Fix common/ includes.
8884         * nat/x86-linux.c: Fix common/ includes.
8885         * nat/x86-linux-dregs.c: Fix common/ includes.
8886         * nat/x86-dregs.h: Fix common/ includes.
8887         * nat/x86-dregs.c: Fix common/ includes.
8888         * nat/ppc-linux.c: Fix common/ includes.
8889         * nat/mips-linux-watch.h: Fix common/ includes.
8890         * nat/mips-linux-watch.c: Fix common/ includes.
8891         * nat/linux-waitpid.c: Fix common/ includes.
8892         * nat/linux-ptrace.h: Fix common/ includes.
8893         * nat/linux-ptrace.c: Fix common/ includes.
8894         * nat/linux-procfs.c: Fix common/ includes.
8895         * nat/linux-personality.c: Fix common/ includes.
8896         * nat/linux-osdata.c: Fix common/ includes.
8897         * nat/linux-namespaces.c: Fix common/ includes.
8898         * nat/linux-btrace.h: Fix common/ includes.
8899         * nat/linux-btrace.c: Fix common/ includes.
8900         * nat/fork-inferior.c: Fix common/ includes.
8901         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8902         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8903         * nat/aarch64-linux.c: Fix common/ includes.
8904         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8905         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8906         * namespace.h: Fix common/ includes.
8907         * mips-linux-tdep.c: Fix common/ includes.
8908         * minsyms.c: Fix common/ includes.
8909         * mi/mi-parse.h: Fix common/ includes.
8910         * mi/mi-main.c: Fix common/ includes.
8911         * mi/mi-cmd-env.c: Fix common/ includes.
8912         * memrange.h: Fix common/ includes.
8913         * memattr.c: Fix common/ includes.
8914         * maint.h: Fix common/ includes.
8915         * maint.c: Fix common/ includes.
8916         * main.c: Fix common/ includes.
8917         * machoread.c: Fix common/ includes.
8918         * location.c: Fix common/ includes.
8919         * linux-thread-db.c: Fix common/ includes.
8920         * linux-nat.c: Fix common/ includes.
8921         * linux-fork.c: Fix common/ includes.
8922         * inline-frame.c: Fix common/ includes.
8923         * infrun.c: Fix common/ includes.
8924         * inflow.c: Fix common/ includes.
8925         * inferior.h: Fix common/ includes.
8926         * inferior.c: Fix common/ includes.
8927         * infcmd.c: Fix common/ includes.
8928         * inf-ptrace.c: Fix common/ includes.
8929         * inf-child.c: Fix common/ includes.
8930         * ia64-linux-nat.c: Fix common/ includes.
8931         * i387-tdep.c: Fix common/ includes.
8932         * i386-tdep.c: Fix common/ includes.
8933         * i386-linux-tdep.c: Fix common/ includes.
8934         * i386-linux-nat.c: Fix common/ includes.
8935         * i386-go32-tdep.c: Fix common/ includes.
8936         * i386-fbsd-tdep.c: Fix common/ includes.
8937         * i386-fbsd-nat.c: Fix common/ includes.
8938         * guile/scm-type.c: Fix common/ includes.
8939         * guile/guile.c: Fix common/ includes.
8940         * go32-nat.c: Fix common/ includes.
8941         * gnu-nat.c: Fix common/ includes.
8942         * gdbthread.h: Fix common/ includes.
8943         * gdbarch-selftests.c: Fix common/ includes.
8944         * gdb_usleep.c: Fix common/ includes.
8945         * gdb_select.h: Fix common/ includes.
8946         * gdb_bfd.c: Fix common/ includes.
8947         * gcore.c: Fix common/ includes.
8948         * fork-child.c: Fix common/ includes.
8949         * findvar.c: Fix common/ includes.
8950         * fbsd-nat.c: Fix common/ includes.
8951         * event-top.c: Fix common/ includes.
8952         * event-loop.c: Fix common/ includes.
8953         * dwarf2read.c: Fix common/ includes.
8954         * dwarf2loc.c: Fix common/ includes.
8955         * dwarf2-frame.c: Fix common/ includes.
8956         * dwarf-index-cache.c: Fix common/ includes.
8957         * dtrace-probe.c: Fix common/ includes.
8958         * disasm-selftests.c: Fix common/ includes.
8959         * defs.h: Fix common/ includes.
8960         * csky-tdep.c: Fix common/ includes.
8961         * cp-valprint.c: Fix common/ includes.
8962         * cp-support.h: Fix common/ includes.
8963         * cp-support.c: Fix common/ includes.
8964         * corelow.c: Fix common/ includes.
8965         * completer.h: Fix common/ includes.
8966         * completer.c: Fix common/ includes.
8967         * compile/compile.c: Fix common/ includes.
8968         * compile/compile-loc2c.c: Fix common/ includes.
8969         * compile/compile-cplus-types.c: Fix common/ includes.
8970         * compile/compile-cplus-symbols.c: Fix common/ includes.
8971         * command.h: Fix common/ includes.
8972         * cli/cli-dump.c: Fix common/ includes.
8973         * cli/cli-cmds.c: Fix common/ includes.
8974         * charset.c: Fix common/ includes.
8975         * build-id.c: Fix common/ includes.
8976         * btrace.h: Fix common/ includes.
8977         * btrace.c: Fix common/ includes.
8978         * breakpoint.h: Fix common/ includes.
8979         * breakpoint.c: Fix common/ includes.
8980         * ax.h:
8981         (enum agent_op): Fix common/ includes.
8982         * ax-general.c (struct aop_map): Fix common/ includes.
8983         * ax-gdb.c: Fix common/ includes.
8984         * auxv.c: Fix common/ includes.
8985         * auto-load.c: Fix common/ includes.
8986         * arm-tdep.c: Fix common/ includes.
8987         * arch/riscv.c: Fix common/ includes.
8988         * arch/ppc-linux-common.c: Fix common/ includes.
8989         * arch/i386.c: Fix common/ includes.
8990         * arch/arm.c: Fix common/ includes.
8991         * arch/arm-linux.c: Fix common/ includes.
8992         * arch/arm-get-next-pcs.c: Fix common/ includes.
8993         * arch/amd64.c: Fix common/ includes.
8994         * arch/aarch64.c: Fix common/ includes.
8995         * arch/aarch64-insn.c: Fix common/ includes.
8996         * arch-utils.c: Fix common/ includes.
8997         * amd64-windows-tdep.c: Fix common/ includes.
8998         * amd64-tdep.c: Fix common/ includes.
8999         * amd64-sol2-tdep.c: Fix common/ includes.
9000         * amd64-obsd-tdep.c: Fix common/ includes.
9001         * amd64-nbsd-tdep.c: Fix common/ includes.
9002         * amd64-linux-tdep.c: Fix common/ includes.
9003         * amd64-linux-nat.c: Fix common/ includes.
9004         * amd64-fbsd-tdep.c: Fix common/ includes.
9005         * amd64-fbsd-nat.c: Fix common/ includes.
9006         * amd64-dicos-tdep.c: Fix common/ includes.
9007         * amd64-darwin-tdep.c: Fix common/ includes.
9008         * agent.c: Fix common/ includes.
9009         * ada-lang.h: Fix common/ includes.
9010         * ada-lang.c: Fix common/ includes.
9011         * aarch64-tdep.c: Fix common/ includes.
9012
9013 2019-01-25  Tom Tromey  <tom@tromey.com>
9014
9015         * common/create-version.sh: Use common/version.h.
9016
9017 2019-01-24  Pedro Alves  <palves@redhat.com>
9018
9019         * infrun.c (signal_stop, signal_print, signal_program)
9020         (signal_catch, signal_pass): Now arrays instead of pointers.
9021         (update_signals_program_target, do_target_resume)
9022         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9023         * linux-nat.c (linux_nat_target::pass_signals)
9024         (linux_nat_target::create_inferior, linux_nat_target::attach):
9025         Adjust.
9026         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9027         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9028         * procfs.c (procfs_target::pass_signals): Adjust.
9029         * record-full.c (record_full_target::resume): Adjust.
9030         * remote.c (remote_target::pass_signals)
9031         (remote_target::program_signals): Adjust.
9032         * target-debug.h (target_debug_print_signals): Now takes a
9033         gdb::array_view as parameter.  Adjust.
9034         * target.h (target_ops) <pass_signals, program_signals>: Replace
9035         pointer and length parameters with gdb::array_view.
9036         (target_pass_signals, target_program_signals): Likewise.
9037         * target-delegates.c: Regenerate.
9038
9039 2019-01-24  Pedro Alves  <palves@redhat.com>
9040
9041         * common/forward-scope-exit.h
9042         (forward_scope_exit::forward_scope_exit): Pass arguments to
9043         m_bind_function directly, instead of creating a std::bind and
9044         copying that.
9045
9046 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9047
9048         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9049         for static members.
9050         (pass_in_v_vfp_candidate): Likewise.
9051
9052 2019-01-23  Tom Tromey  <tom@tromey.com>
9053             Pedro Alves  <palves@redhat.com>
9054
9055         * regcache.c (class regcache_invalidator): Remove.
9056         (regcache::raw_write): Use make_scope_exit.
9057
9058 2019-01-23  Tom Tromey  <tom@tromey.com>
9059
9060         * ui-out.h (class ui_out_emit_type): Update comment.
9061
9062 2019-01-23  Tom Tromey  <tom@tromey.com>
9063
9064         * infrun.c (fetch_inferior_event): Update comment.
9065
9066 2019-01-23  Tom Tromey  <tom@tromey.com>
9067             Pedro Alves  <palves@redhat.com>
9068
9069         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9070         parameter.
9071         (fetch_inferior_event): Use SCOPE_EXIT.
9072
9073
9074 2019-01-23  Tom Tromey  <tom@tromey.com>
9075             Pedro Alves  <palves@redhat.com>
9076
9077         * infrun.c (disable_thread_events): Delete.
9078         (stop_all_threads): Use SCOPE_EXIT.
9079
9080 2019-01-23  Tom Tromey  <tom@tromey.com>
9081             Pedro Alves  <palves@redhat.com>
9082
9083         * symfile.c: Include forward-scope-exit.h.
9084         (clear_symtab_users_cleanup): Replace forward declaration with
9085         a FORWARD_SCOPE_EXIT.
9086         (syms_from_objfile_1): Use the forward_scope_exit and
9087         gdb::optional instead of cleanup_function.
9088         (reread_symbols): Use the forward_scope_exit instead of
9089         cleanup_function.
9090         (clear_symtab_users_cleanup): Remove function.
9091
9092 2019-01-23  Tom Tromey  <tom@tromey.com>
9093             Pedro Alves  <palves@redhat.com>
9094
9095         * linux-nat.c: Include scope-exit.h.
9096         (cleanup_target_stop): Remove.
9097         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9098         SCOPE_EXIT.
9099
9100 2019-01-23  Tom Tromey  <tom@tromey.com>
9101             Pedro Alves  <palves@redhat.com>
9102
9103         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9104         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9105
9106 2019-01-23  Tom Tromey  <tom@tromey.com>
9107             Andrew Burgess  <andrew.burgess@embecosm.com>
9108             Pedro Alves  <palves@redhat.com>
9109
9110         * infrun.c (fetch_inferior_event): Use scope_exit.
9111         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9112         * top.c (execute_command): Use scope_exit.
9113         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9114         * utils.c (do_bpstat_clear_actions_cleanup)
9115         (make_bpstat_clear_actions_cleanup): Remove.
9116
9117 2019-01-23  Tom Tromey  <tom@tromey.com>
9118             Pedro Alves  <palves@redhat.com>
9119
9120         * infrun.c: Include "common/scope-exit.h"
9121         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9122         (wait_for_inferior): Use SCOPE_EXIT.
9123         (fetch_inferior_event): Use scope_exit.
9124
9125 2019-01-23  Tom Tromey  <tom@tromey.com>
9126             Pedro Alves  <palves@redhat.com>
9127
9128         * breakpoint.c (create_breakpoint): Remove cleanup.
9129
9130 2019-01-23  Tom Tromey  <tom@tromey.com>
9131             Andrew Burgess  <andrew.burgess@embecosm.com>
9132             Pedro Alves  <palves@redhat.com>
9133
9134 2019-01-23  Pedro Alves  <palves@redhat.com>
9135
9136         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9137
9138 2019-01-23  Pedro Alves  <palves@redhat.com>
9139             Andrew Burgess  <andrew.burgess@embecosm.com>
9140
9141         * gdbthread.h: Include "common/forward-scope-exit.h".
9142         (scoped_finish_thread_state): Redefine custom class in terms of
9143         forward_scope_exit.
9144
9145 2019-01-23  Pedro Alves  <palves@redhat.com>
9146             Andrew Burgess  <andrew.burgess@embecosm.com>
9147
9148         * common/forward-scope-exit.h: New file.
9149
9150 2019-01-23  Pedro Alves  <palves@redhat.com>
9151             Andrew Burgess  <andrew.burgess@embecosm.com>
9152             Tom Tromey  <tom@tromey.com>
9153
9154         * common/scope-exit.h: New file.
9155
9156 2019-01-23  Pedro Alves  <palves@redhat.com>
9157
9158         * common/preprocessor.h (ESC): Rename to ...
9159         (ESC_PARENS): ... this.
9160         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9161         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9162
9163 2019-01-23  Tom Tromey  <tom@tromey.com>
9164
9165         * language.h (class scoped_switch_to_sym_language_if_auto):
9166         Initialize m_lang in both cases.
9167
9168 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9169
9170         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9171         with XCNEW.
9172
9173 2019-01-22  Tom Tromey  <tom@tromey.com>
9174
9175         * corelow.c: Do not include sys/file.h.
9176
9177 2019-01-22  Tom Tromey  <tom@tromey.com>
9178
9179         * tui/tui-wingeneral.h: Include gdb_curses.h.
9180
9181 2019-01-22  Tom Tromey  <tom@tromey.com>
9182
9183         * source-cache.h (class source_cache) <get_source_lines,
9184         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9185
9186 2019-01-22  Tom Tromey  <tom@tromey.com>
9187
9188         * remote-fileio.h (struct remote_target): Declare.
9189
9190 2019-01-22  Tom Tromey  <tom@tromey.com>
9191
9192         * python/py-arch.c: Do not include py-ref.h.
9193         * python/py-bpevent.c: Do not include py-ref.h.
9194         * python/py-cmd.c: Do not include py-ref.h.
9195         * python/py-continueevent.c: Do not include py-ref.h.
9196         * python/py-event.h: Do not include py-ref.h.
9197         * python/py-evtregistry.c: Do not include py-ref.h.
9198         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9199         * python/py-frame.c: Do not include py-ref.h.
9200         * python/py-framefilter.c: Do not include py-ref.h.
9201         * python/py-function.c: Do not include py-ref.h.
9202         * python/py-infevents.c: Do not include py-ref.h.
9203         * python/py-linetable.c: Do not include py-ref.h.
9204         * python/py-objfile.c: Do not include py-ref.h.
9205         * python/py-param.c: Do not include py-ref.h.
9206         * python/py-prettyprint.c: Do not include py-ref.h.
9207         * python/py-progspace.c: Do not include py-ref.h.
9208         * python/py-symbol.c: Do not include py-ref.h.
9209         * python/py-symtab.c: Do not include py-ref.h.
9210         * python/py-type.c: Do not include py-ref.h.
9211         * python/py-unwind.c: Do not include py-ref.h.
9212         * python/py-utils.c: Do not include py-ref.h.
9213         * python/py-value.c: Do not include py-ref.h.
9214         * python/py-varobj.c: Do not include py-ref.h.
9215         * python/py-xmethods.c: Do not include py-ref.h.
9216         * python/python.c: Do not include py-ref.h.
9217         * varobj.c: Do not include py-ref.h.
9218
9219 2019-01-22  Tom Tromey  <tom@tromey.com>
9220
9221         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9222         keyword for bcache.
9223
9224 2019-01-22  Tom Tromey  <tom@tromey.com>
9225
9226         * compile/compile-cplus-types.c: Remove a comment by #include.
9227
9228 2019-01-22  Tom Tromey  <tom@tromey.com>
9229
9230         * compile/gcc-c-plugin.h: Include compile-internal.h.
9231
9232 2019-01-22  Tom Tromey  <tom@tromey.com>
9233
9234         * stabsread.c (EXTERN): Do not define.
9235         (symnum, next_symbol_text_func, processing_gcc_compilation)
9236         (within_function, global_sym_chain, global_stabs)
9237         (previous_stab_code, this_object_header_files)
9238         (n_this_object_header_files)
9239         (n_allocated_this_object_header_files): Define.
9240         * stabsread.h (EXTERN): Never define.  Use "extern".
9241
9242 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9243
9244         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9245         history_value.
9246
9247 2019-01-21  Tom Tromey  <tom@tromey.com>
9248
9249         * ui-out.c: Fix includes.
9250         * tui/tui-source.c: Fix includes.
9251         * target.c: Fix includes.
9252         * remote.c: Fix includes.
9253         * regcache.c: Fix includes.
9254         * python/py-block.c: Fix includes.
9255         * printcmd.c: Fix includes.
9256         * or1k-tdep.c: Fix includes.
9257         * mi/mi-main.c: Fix includes.
9258         * m32r-tdep.c: Fix includes.
9259         * csky-tdep.c: Fix includes.
9260         * compile/compile-cplus-types.c: Fix includes.
9261         * cli/cli-interp.c: Fix includes.
9262
9263 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9264
9265         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9266         for padding.
9267
9268 2019-01-16  Tom Tromey  <tom@tromey.com>
9269
9270         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9271         earlier.
9272         (struct objfile) <msymbols_range>: Move from top level.
9273         <msymbols>: New method.
9274         (class objfile_msymbols): Remove.
9275         * symtab.c (default_collect_symbol_completion_matches_break_on):
9276         Update.
9277         * symmisc.c (dump_msymbols): Update.
9278         * stabsread.c (scan_file_globals): Update.
9279         * objc-lang.c (info_selectors_command, info_classes_command)
9280         (find_methods): Update.
9281         * minsyms.c (find_solib_trampoline_target): Update.
9282         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9283         * coffread.c (coff_symfile_read): Update.
9284         * ada-lang.c (ada_lookup_simple_minsym)
9285         (ada_collect_symbol_completion_matches): Update.
9286
9287 2019-01-16  Tom Tromey  <tom@tromey.com>
9288
9289         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9290         type.  Remove no-argument constructor.
9291         <iterator::operator++>: Simplify.
9292         <begin>: Update.
9293         <end>: Use minimal_symbol_count.
9294
9295 2019-01-16  Tom Tromey  <tom@tromey.com>
9296
9297         * objfiles.h (struct objfile) <psymtabs>: New method.
9298         (class objfile_psymtabs): Remove.
9299         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9300         typedef.
9301         <range>: New method.
9302         (require_partial_symbols): Change return type.
9303         * psymtab.c (require_partial_symbols)
9304         (psym_expand_symtabs_matching): Update.
9305         * mdebugread.c (parse_partial_symbols): Update.
9306         * dbxread.c (dbx_end_psymtab): Update.
9307
9308 2019-01-15  Tom Tromey  <tom@tromey.com>
9309
9310         * symtab.c (lookup_objfile_from_block)
9311         (lookup_symbol_in_objfile_symtabs)
9312         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9313         (find_line_symtab, info_sources_command)
9314         (default_collect_symbol_completion_matches_break_on)
9315         (make_source_files_completion_list): Update.
9316         * symmisc.c (print_objfile_statistics, dump_objfile)
9317         (maintenance_print_symbols, maintenance_info_symtabs)
9318         (maintenance_check_symtabs, maintenance_info_line_tables):
9319         Update.
9320         * source.c (select_source_symtab)
9321         (forget_cached_source_info_for_objfile): Update.
9322         * objfiles.h (class objfile_compunits): Remove.
9323         (struct objfile) <compunits_range>: New typedef.
9324         (compunits): New method.
9325         * objfiles.c (objfile_relocate1): Update.
9326         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9327         * maint.c (count_symtabs_and_blocks): Update.
9328         * linespec.c (iterate_over_all_matching_symtabs): Update.
9329         * cp-support.c (add_symbol_overload_list_qualified): Update.
9330         * coffread.c (coff_symtab_read): Update.
9331         * ada-lang.c (add_nonlocal_symbols)
9332         (ada_collect_symbol_completion_matches)
9333         (ada_add_global_exceptions): Update.
9334
9335 2019-01-15  Tom Tromey  <tom@tromey.com>
9336
9337         * progspace.h (program_space) <objfiles_safe_range>: New
9338         typedef.
9339         <objfiles_safe>: New method.
9340         * objfiles.h (class all_objfiles_safe): Remove.
9341         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9342         * jit.c (jit_inferior_exit_hook): Update.
9343
9344 2019-01-17  Tom Tromey  <tom@tromey.com>
9345
9346         * progspace.h (program_space) <objfiles_range>: New typedef.
9347         <objfiles>: New method.
9348         <objfiles_head>: Rename from objfiles.
9349         (object_files): Update.
9350         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9351         * guile/scm-pretty-print.c
9352         (ppscm_find_pretty_printer_from_objfiles): Update.
9353         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9354         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9355         Update.
9356         * python/py-progspace.c (pspy_get_objfiles): Update.
9357         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9358         Update.
9359         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9360         (objfpy_lookup_objfile_by_build_id): Update.
9361         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9362         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9363         Update.
9364         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9365         (expand_symtab_containing_pc, lookup_objfile_from_block)
9366         (lookup_static_symbol, basic_lookup_transparent_type)
9367         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9368         (find_line_symtab, info_sources_command)
9369         (default_collect_symbol_completion_matches_break_on)
9370         (make_source_files_completion_list, find_main_name): Update.
9371         * symmisc.c (print_symbol_bcache_statistics)
9372         (print_objfile_statistics, maintenance_print_symbols)
9373         (maintenance_print_msymbols, maintenance_print_objfiles)
9374         (maintenance_info_symtabs, maintenance_check_symtabs)
9375         (maintenance_expand_symtabs, maintenance_info_line_tables):
9376         Update.
9377         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9378         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9379         (map_overlay_command, unmap_overlay_command)
9380         (simple_overlay_update, expand_symtabs_matching)
9381         (map_symbol_filenames): Update.
9382         * symfile-debug.c (set_debug_symfile): Update.
9383         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9384         Update.
9385         * source.c (select_source_symtab, forget_cached_source_info):
9386         Update.
9387         * solib.c (solib_read_symbols): Update.
9388         * solib-spu.c (append_ocl_sos): Update.
9389         * psymtab.c (maintenance_print_psymbols)
9390         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9391         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9392         * printcmd.c (info_symbol_command): Update.
9393         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9394         Update.
9395         * objfiles.h (class all_objfiles): Remove.
9396         * objfiles.c (have_partial_symbols, have_full_symbols)
9397         (have_minimal_symbols, qsort_cmp, update_section_map)
9398         (shared_objfile_contains_address_p)
9399         (default_iterate_over_objfiles_in_search_order): Update.
9400         * objc-lang.c (info_selectors_command, info_classes_command)
9401         (find_methods): Update.
9402         * minsyms.c (find_solib_trampoline_target): Update.
9403         * maint.c (maintenance_info_sections)
9404         (maintenance_translate_address, count_symtabs_and_blocks):
9405         Update.
9406         * main.c (captured_main_1): Update.
9407         * linux-thread-db.c (try_thread_db_load_from_pdir)
9408         (has_libpthread): Update.
9409         * linespec.c (iterate_over_all_matching_symtabs)
9410         (search_minsyms_for_name): Update.
9411         * jit.c (jit_find_objf_with_entry_addr): Update.
9412         * hppa-tdep.c (find_unwind_entry)
9413         (hppa_lookup_stub_minimal_symbol): Update.
9414         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9415         Update.
9416         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9417         (elf_gnu_ifunc_resolve_by_got): Update.
9418         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9419         * dwarf-index-write.c (save_gdb_index_command): Update.
9420         * cp-support.c (add_symbol_overload_list_qualified): Update.
9421         * breakpoint.c (create_overlay_event_breakpoint)
9422         (create_longjmp_master_breakpoint)
9423         (create_std_terminate_master_breakpoint)
9424         (create_exception_master_breakpoint): Update.
9425         * blockframe.c (find_pc_partial_function): Update.
9426         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9427         (ada_collect_symbol_completion_matches)
9428         (ada_add_global_exceptions): Update.
9429
9430 2019-01-17  Tom Tromey  <tom@tromey.com>
9431
9432         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9433         declare VEC.
9434         (solib_target_parse_libraries): Change return type.
9435         (library_list_start_segment, library_list_start_section)
9436         (library_list_end_library, library_list_start_library); Update.
9437         (solib_target_free_library_list): Remove.
9438         (solib_target_parse_libraries): Remove cleanup.  Change return
9439         type.
9440         (solib_target_current_sos): Update.
9441
9442 2019-01-17  Tom Tromey  <tromey@bapiya>
9443
9444         * valprint.c: Replace "the the" with "the".
9445         * symtab.c: Replace "the the" with "the".
9446         * solib.c: Replace "the the" with "the".
9447         * solib-dsbt.c: Replace "the the" with "the".
9448         * linespec.c: Replace "the the" with "the".
9449         * dwarf2loc.h: Replace "the the" with "the".
9450         * amd64-windows-tdep.c: Replace "the the" with "the".
9451         * aarch64-tdep.c: Replace "the the" with "the".
9452
9453 2019-01-16  Keith Seitz  <keiths@redhat.com>
9454
9455         PR gdb/23773
9456         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9457         <builder>: Rename to ..
9458         <m_builder>: ... this and make private.
9459         (dwarf2_cu::get_builder): New method.  Change all users of
9460         `builder' to use this method.
9461         (dwarf2_start_symtab): Move to ...
9462         (dwarf2_cu::start_symtab): ... here.  Update all callers
9463         (setup_type_unit_groups): Move to ...
9464         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9465         callers.
9466         (dwarf2_cu::reset_builder): New method.
9467         (process_full_compunit, process_full_type_unit): Use
9468         dwarf2_cu::reset_builder.
9469         (follow_die_offset): Record the ancestor CU if it is different
9470         from the followed DIE's CU.
9471         (follow_die_sig_1): Likewise.
9472
9473 2019-01-15  Tom Tromey  <tom@tromey.com>
9474
9475         * remote.c (class remote_state) <buf>: Now a char_vector.
9476         <buf_size>: Remove.
9477         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9478         parameter.
9479         (remote_target::getpkt_or_notif_sane_1)
9480         (remote_target::getpkt_sane)
9481         (remote_target::getpkt_or_notif_sane): Likewise.
9482         (class remote_target) <putpkt>: New overload.
9483         (remote_target::read_frame): Change type of "buf_p".  Remove
9484         sizeof_p parameter.
9485         (packet_ok): New overload.
9486         (packet_check_result): New overload.
9487         Update all uses.
9488
9489 2019-01-14  Tom Tromey  <tom@tromey.com>
9490
9491         * remote-notif.c (handle_notification, remote_notif_ack)
9492         (remote_notif_parse): Make "buf" const.
9493         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9494         const.
9495         (remote_notif_parse, remote_notif_ack, handle_notification):
9496         Likewise.
9497         * remote.c (remote_notif_stop_parse): Make "buf" const.
9498         (remote_target::remote_parse_stop_reply): Make "buf" const.
9499         (remote_notif_stop_ack): Make "buf" const.
9500
9501 2019-01-14  Tom Tromey  <tom@tromey.com>
9502
9503         * remote.c (remote_console_output): Make parameter const.
9504
9505 2019-01-14  Tom Tromey  <tom@tromey.com>
9506
9507         * target-debug.h (target_debug_print_signals): Constify.
9508         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9509         * procfs.c (procfs_target::pass_signals): Update.
9510         * linux-nat.c (linux_nat_target::pass_signals): Update.
9511         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9512         * target-delegates.c: Rebuild.
9513         * remote.c (remote_target::program_signals): Update.
9514         (remote_target::pass_signals): Update.
9515         * target.c (target_pass_signals): Constify argument.
9516         (target_program_signals): Likewise.
9517         * target.h (struct target_ops) <pass_signals, program_signals>:
9518         Constify argument.
9519         (target_pass_signals, target_program_signals): Constify argument.
9520
9521 2019-01-14  Tom Tromey  <tom@tromey.com>
9522
9523         PR tui/28819:
9524         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9525
9526 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9527
9528         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9529         field.
9530         * rs6000-tdep.c: Include reggroups.h.
9531         (IS_V_ALIAS_PSEUDOREG): Define.
9532         (rs6000_register_name): Return names for the "vX" aliases.
9533         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9534         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9535         aliases.  Call default_register_reggroup_p for all other
9536         pseudo-registers.
9537         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9538         New functions.
9539         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9540         Handle "vX" aliases.
9541         (v_alias_pseudo_register_collect): New function.
9542         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9543         (rs6000_gdbarch_init): Initialize "vX" aliases as
9544         pseudo-registers.  Restore registration of
9545         rs6000_pseudo_register_reggroup_p with
9546         set_tdesc_pseudo_register_reggroup_p.
9547
9548 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9549
9550         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9551         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9552         set_gdbarch_num_pseudo_regs.
9553
9554 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9555
9556         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9557         Remove arg prefixname, add do_set and do_show.
9558         Add member functions set_list and show_list.
9559         * cli/cli-style.c (class cli_style_option): Update accordingly.
9560         (style_set_list): Move to file scope.
9561         (style_show_list): Likewise.
9562         (set_style): Call help_list.
9563         (show_style): Call cmd_show_list.
9564         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9565         Update to use the new macro.
9566
9567 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9568
9569         * ada-lang.c (_initialize_ada_language): Expand the help text
9570         for the "catch exception" command.
9571
9572 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9573
9574         * symtab.c (matching_obj_sections): Initialize obj,
9575         declare it closer to its usage.
9576
9577 2019-01-10  Tom Tromey  <tom@tromey.com>
9578
9579         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9580         (basic_inf_threads_range): Remove.
9581         (inf_threads_range, inf_non_exited_threads_range)
9582         (safe_inf_threads_range): Use next_adapter.
9583
9584 2019-01-10  Keith Seitz  <keiths@redhat.com>
9585
9586         PR gdb/23712
9587         PR symtab/23010
9588         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9589         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9590
9591 2019-01-10  Keith Seitz  <keiths@redhat.com>
9592
9593         PR gdb/23712
9594         PR symtab/23010
9595         * dictionary.c (pending_to_vector): Remove.
9596         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9597         Remove _1 suffix, replacing functions of the same name.  Update
9598         all callers.
9599         (dict_create_hashed, dict_create_hashed_expandable)
9600         (dict_create_linear, dict_create_linear_expandable, dict_free)
9601         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9602         Make functions static.
9603
9604 2019-01-10  Keith Seitz  <keiths@redhat.com>
9605
9606         PR gdb/23712
9607         PR symtab/23010
9608         * dictionary.h (struct dictionary): Replace declaration with
9609         multidictionary.
9610         (dict_create_hashed, dict_create_hashed_expandable)
9611         (dict_create_linear, dict_create_linear_expandable)
9612         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9613         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9614         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9615         taking multidictionary argument.
9616         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9617         * block.h (struct block) <dict>: Change to multidictionary
9618         and rename `multidict'.
9619         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9620         symmisc.c: Update all dictionary references to multidictionary.
9621
9622 2019-01-10  Keith Seitz  <keiths@redhat.com>
9623
9624         PR gdb/23712
9625         PR symtab/23010
9626         * dictionary.c: Include unordered_map.
9627         (pending_to_vector): New function.
9628         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9629         Rewrite the non-"_1" functions to take vector instead
9630         of linked list.
9631         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9632         "new" _1 versions of the same name.
9633         (multidictionary): Define.
9634         (std::hash<enum language): New definition.
9635         (collate_pending_symbols_by_language, mdict_create_hashed)
9636         (mdict_create_hashed_expandable, mdict_create_linear)
9637         (mdict_create_linear_expandable, mdict_free)
9638         (find_language_dictionary, create_new_language_dictionary)
9639         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9640         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9641         (mdict_size, mdict_empty): New functions.
9642         * dictionary.h (mdict_iterator): Define.
9643
9644 2019-01-10  Pedro Alves  <palves@redhat.com>
9645
9646         * breakpoint.c (read_uploaded_action)
9647         (create_tracepoint_from_upload): Adjust to use
9648         gdb::unique_xmalloc_ptr.
9649         * ctf.c (ctf_write_uploaded_tp):
9650         (SET_ARRAY_FIELD): Use emplace_back.
9651         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9652         * tracefile-tfile.c (tfile_write_uploaded_tp):
9653         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9654         gdb::unique_xmalloc_ptr.
9655         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9656         at_string, cond_string, cmd_strings>: Replace char pointers
9657         with gdb::unique_xmalloc_ptr.
9658
9659 2019-01-10  Pedro Alves  <palves@redhat.com>
9660
9661         * solib-target.c (library_list_start_library): Don't xstrdup name.
9662
9663 2019-01-10  Pedro Alves  <palves@redhat.com>
9664
9665         * mdebugread.c (parse_partial_symbols): Use
9666         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9667
9668 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9669
9670         * linux-fork.c (scoped_switch_fork_info)
9671         <~scoped_switch_fork_info>: Fix incorrect variable name.
9672
9673 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9674
9675         * linux-fork.c (scoped_switch_fork_info)
9676         <scoped_switch_fork_info>: Make explicit.
9677         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9678
9679 2019-01-10  Tom Tromey  <tom@tromey.com>
9680
9681         * objfiles.h (objfile::reset_psymtabs): Update.
9682         * objfiles.c (objfile::objfile): Update.
9683         * psymtab.h (psymtab_storage::obstack): Update.
9684         (psymtab_storage::m_obstack): Use gdb::optional.
9685         (class psymtab_storage): Update comment.  Remove objfile
9686         parameter.
9687         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9688
9689 2019-01-10  Tom Tromey  <tom@tromey.com>
9690
9691         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9692         <free_psymtabs>: Now private.
9693         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9694         (allocate_psymtab): Use new method.
9695
9696 2019-01-10  Tom Tromey  <tom@tromey.com>
9697
9698         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9699         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9700         * mdebugread.c (parse_partial_symbols): Use
9701         allocate_dependencies.
9702         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9703         allocate_dependencies.
9704         (process_psymtab_comp_unit_reader)
9705         (build_type_psymtab_dependencies): Likewise.
9706         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9707
9708 2019-01-10  Tom Tromey  <tom@tromey.com>
9709
9710         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9711         PSYMBOL_SET_LANGUAGE.
9712         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9713
9714 2019-01-10  Tom Tromey  <tom@tromey.com>
9715
9716         * psymtab.h (psymtab_storage::obstack): New method.
9717         <m_obstack>: Rename from obstack; now private.
9718         * psymtab.c (psymtab_storage): Update.
9719         * dwarf2read.c (create_addrmap_from_index)
9720         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9721         Update.
9722
9723 2019-01-10  Tom Tromey  <tom@tromey.com>
9724
9725         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9726         * objfiles.h (objfile::reset_psymtabs): New method.
9727
9728 2019-01-10  Tom Tromey  <tom@tromey.com>
9729
9730         * symmisc.c (print_symbol_bcache_statistics): Update.
9731         (print_objfile_statistics): Update.
9732         * symfile.c (reread_symbols): Update.
9733         * psymtab.h (class psymtab_storage): New.
9734         * psymtab.c (psymtab_storage): New constructor.
9735         (~psymtab_storage): New destructor.
9736         (require_partial_symbols): Update.
9737         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9738         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9739         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9740         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9741         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9742         (start_psymtab_common, end_psymtab_common)
9743         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9744         (allocate_psymtab): Update.
9745         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9746         Update.
9747         (dump_psymtab_addrmap, maintenance_print_psymbols)
9748         (maintenance_check_psymtabs): Update.
9749         (class objfile_psymtabs): Move to objfiles.h.
9750         * psympriv.h (discard_psymtab): Now inline.
9751         (psymtab_discarder::psymtab_discarder): Update.
9752         (psymtab_discarder::~psymtab_discarder): Update.
9753         (ALL_OBJFILE_PSYMTABS): Rewrite.
9754         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9755         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9756         Remove fields.
9757         <partial_symtabs>: New field.
9758         (class objfile_psymtabs): Move from psymtab.h.  Update.
9759         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9760         psymbol_cache.
9761         (objfile::~objfile): Don't destroy psymbol_cache.
9762         * mdebugread.c (parse_partial_symbols): Update.
9763         * dwarf2read.c (create_addrmap_from_index)
9764         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9765         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9766         (add_partial_subprogram, dwarf2_ranges_read): Update.
9767         * dwarf-index-write.c (write_address_map)
9768         (write_one_signatured_type, recursively_write_psymbols)
9769         (class debug_names, class debug_names, write_psymtabs_to_index):
9770         Update.
9771
9772 2019-01-10  Tom Tromey  <tom@tromey.com>
9773
9774         * symtab.h (SYMBOL_SET_NAMES): Update.
9775         (symbol_set_names): Update.
9776         (MSYMBOL_SET_NAMES): Update.
9777         * symtab.c (symbol_set_names): Change argument to be an
9778         objfile_per_bfd_storage.
9779         * psymtab.c (add_psymbol_to_bcache): Update.
9780         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9781
9782 2019-01-10  Tom Tromey  <tom@tromey.com>
9783
9784         * symtab.c (create_demangled_names_hash): Change argument to be an
9785         objfile_per_bfd_storage.
9786         (symbol_set_names): Update.
9787
9788 2019-01-10  Tom Tromey  <tom@tromey.com>
9789
9790         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9791         init_psymbol_list.
9792         * psymtab.c (init_psymbol_list): Do nothing if already called.
9793         * psympriv.h (init_psymbol_list): Add comment.
9794         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9795         init_psymbol_list.
9796         * dbxread.c (dbx_symfile_read): Unconditionally call
9797         init_psymbol_list.
9798
9799 2019-01-10  Tom Tromey  <tom@tromey.com>
9800
9801         * xcoffread.c (scan_xcoff_symtab): Update.
9802         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9803         "where".
9804         * mdebugread.c (parse_partial_symbols)
9805         (handle_psymbol_enumerators): Update.
9806         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9807         * dbxread.c (read_dbx_symtab): Update.
9808         * psympriv.h (psymbol_placement): New enum.
9809         (add_psymbol_to_list): Update.
9810
9811 2019-01-10  Tom Tromey  <tom@tromey.com>
9812
9813         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9814         static_psymbols parameters.
9815         (scan_xcoff_symtab): Update.
9816         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9817         static_psymbols parameters.
9818         * psympriv.h (start_psymtab_common): Update.
9819         * mdebugread.c (parse_partial_symbols): Update.
9820         * dwarf2read.c (create_partial_symtab): Update.
9821         * dbxread.c (read_dbx_symtab): Update.
9822         (start_psymtab): Remove global_psymbols and static_psymbols
9823         parameters.
9824
9825 2019-01-10  Tom Tromey  <tom@tromey.com>
9826
9827         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9828         * psymtab.c (allocate_psymtab): Add comment.
9829         * psympriv.h (allocate_psymtab): Add comment.
9830         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9831         initializations.
9832         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9833
9834 2019-01-10  Tom Tromey  <tom@tromey.com>
9835
9836         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9837         Don't declare.
9838         * mipsread.c: Include mdebugread.h.
9839         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9840         Declare.
9841         * elfread.c: Include mdebugread.h.
9842
9843 2019-01-09  Tom Tromey  <tom@tromey.com>
9844
9845         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9846         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9847         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9848         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9849         (psym_lookup_symbol, psym_find_last_source_symtab)
9850         (psym_forget_cached_source_info, psym_print_stats)
9851         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9852         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9853         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9854         (psym_find_compunit_symtab_by_address)
9855         (maintenance_print_psymbols, maintenance_info_psymtabs)
9856         (maintenance_check_psymtabs): Use ranged for.
9857         * psymtab.h (class objfile_psymtabs): New.
9858         (require_partial_symbols): Return objfile_psymtabs.
9859         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9860
9861 2019-01-09  Tom Tromey  <tom@tromey.com>
9862
9863         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9864         (find_pc_mapped_section, list_overlays_command)
9865         (map_overlay_command, unmap_overlay_command)
9866         (simple_overlay_update): Use all_objfiles.
9867         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9868         * printcmd.c (info_symbol_command): Use all_objfiles.
9869         * objfiles.h (ALL_OBJSECTIONS): Remove.
9870         * maint.c (maintenance_translate_address): Use all_objfiles.
9871         * gcore.c (gcore_create_callback): Use all_objfiles.
9872         (objfile_find_memory_regions): Likewise.
9873
9874 2019-01-09  Tom Tromey  <tom@tromey.com>
9875
9876         * symtab.c (find_line_symtab, info_sources_command)
9877         (make_source_files_completion_list): Use objfile_compunits.
9878         * source.c (select_source_symtab): Use objfile_compunits.
9879         * objfiles.h (struct objfile): Update comment.
9880         (ALL_OBJFILES): Remove.
9881         (ALL_FILETABS): Remove.
9882         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9883         objfile_compunits.
9884
9885 2019-01-09  Tom Tromey  <tom@tromey.com>
9886
9887         * symmisc.c (print_objfile_statistics, dump_objfile)
9888         (maintenance_print_symbols): Use compunit_filetabs.
9889         * source.c (forget_cached_source_info_for_objfile): Use
9890         compunit_filetabs.
9891         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9892         (ALL_FILETABS): Use compunit_filetabs.
9893         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9894         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9895
9896 2019-01-09  Tom Tromey  <tom@tromey.com>
9897
9898         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9899         (compunit_filetabs): New.
9900         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9901         compunit_filetabs.
9902         (info_sources_command, make_source_files_completion_list): Remove
9903         declaration.
9904         * symmisc.c (print_objfile_statistics, dump_objfile)
9905         (maintenance_print_symbols): Remove declaration.
9906         (maintenance_info_symtabs): Use compunit_filetabs.
9907         (maintenance_info_line_tables): Likewise.
9908         * source.c (select_source_symtab): Change local variable name.
9909         (forget_cached_source_info_for_objfile): Remove declaration.
9910         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9911         * objfiles.c (objfile_relocate1): Remove declaration.
9912         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9913         declaration.
9914         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9915         * coffread.c (coff_symtab_read): Remove declaration.
9916         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9917         compunit_filetabs.
9918
9919 2019-01-09  Tom Tromey  <tom@tromey.com>
9920
9921         * symtab.c (lookup_objfile_from_block)
9922         (find_pc_sect_compunit_symtab, search_symbols)
9923         (default_collect_symbol_completion_matches_break_on): Use
9924         objfile_compunits.
9925         * objfiles.h (ALL_COMPUNITS): Remove.
9926         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9927         * cp-support.c (add_symbol_overload_list_qualified): Use
9928         objfile_compunits.
9929         * ada-lang.c (ada_collect_symbol_completion_matches)
9930         (ada_add_global_exceptions): Use objfile_compunits.
9931
9932 2019-01-09  Tom Tromey  <tom@tromey.com>
9933
9934         * source.c (select_source_symtab)
9935         (forget_cached_source_info_for_objfile): Remove declaration.
9936         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9937         declaration.
9938         * maint.c (count_symtabs_and_blocks): Remove declaration.
9939         * cp-support.c (add_symbol_overload_list_qualified): Remove
9940         declaration.
9941         * coffread.c (coff_symtab_read): Remove declaration.
9942         * symtab.c (lookup_symbol_in_objfile_symtabs)
9943         (basic_lookup_transparent_type_1): Use objfile_compunits.
9944         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9945         (info_sources_command, search_symbols)
9946         (default_collect_symbol_completion_matches_break_on)
9947         (make_source_files_completion_list): Remove declaration.
9948         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9949         (ada_collect_symbol_completion_matches)
9950         (ada_add_global_exceptions): Remove declaration.
9951         * linespec.c (iterate_over_all_matching_symtabs): Use
9952         objfile_compunits.
9953         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9954         (class objfile_compunits): New.
9955         (ALL_COMPUNITS): Use objfile_compunits.
9956         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9957         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9958         objfile_compunits.
9959         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9960
9961 2019-01-09  Tom Tromey  <tom@tromey.com>
9962
9963         * symtab.c (search_symbols)
9964         (default_collect_symbol_completion_matches_break_on): Use
9965         objfile_msymbols.
9966         * ada-lang.c (ada_lookup_simple_minsym)
9967         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9968         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9969         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9970         objfile_msymbols.
9971         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9972         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9973         * objc-lang.c (find_methods): Use objfile_msymbols.
9974         (info_selectors_command, info_classes_command): Likewise.
9975         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9976         * objfiles.h (class objfile_msymbols): New.
9977         (ALL_OBJFILE_MSYMBOLS): Remove.
9978         (ALL_MSYMBOLS): Remove.
9979
9980 2019-01-09  Tom Tromey  <tom@tromey.com>
9981
9982         * common/next-iterator.h (next_adapter): Add Iterator template
9983         parameter.
9984         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9985         (class all_objfiles_safe): New.
9986         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9987         * objfiles.c (put_objfile_before): Update comment.
9988         (add_separate_debug_objfile): Likewise.
9989         (free_all_objfiles): Use all_objfiles_safe.
9990         (objfile_purge_solibs): Likewise.
9991
9992 2019-01-09  Tom Tromey  <tom@tromey.com>
9993
9994         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9995         (expand_symtab_containing_pc, lookup_static_symbol)
9996         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9997         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9998         all_objfiles.
9999         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10000         * breakpoint.c (create_overlay_event_breakpoint)
10001         (create_longjmp_master_breakpoint)
10002         (create_std_terminate_master_breakpoint)
10003         (create_exception_master_breakpoint): Use all_objfiles.
10004         * linux-thread-db.c (try_thread_db_load_from_pdir)
10005         (has_libpthread): Use all_objfiles.
10006         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10007         * linespec.c (iterate_over_all_matching_symtabs)
10008         (search_minsyms_for_name): Use all_objfiles.
10009         * maint.c (maintenance_info_sections): Use all_objfiles.
10010         * main.c (captured_main_1): Use all_objfiles.
10011         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10012         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10013         * guile/scm-pretty-print.c
10014         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10015         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10016         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10017         (maintenance_print_msymbols): Use all_objfiles.
10018         * source.c (select_source_symtab): Use all_objfiles.
10019         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10020         * symfile.c (remove_symbol_file_command)
10021         (expand_symtabs_matching, map_symbol_filenames): Use
10022         all_objfiles.
10023         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10024         all_objfiles.
10025         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10026         * objc-lang.c (find_methods): Use all_objfiles.
10027         * objfiles.c (have_partial_symbols, have_full_symbols)
10028         (have_minimal_symbols, qsort_cmp)
10029         (default_iterate_over_objfiles_in_search_order): Use
10030         all_objfiles.
10031         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10032         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10033         (maintenance_check_psymtabs): Use all_objfiles.
10034         (ALL_PSYMTABS): Remove.
10035         * compile/compile-object-run.c (do_module_cleanup): Use
10036         all_objfiles.
10037         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10038         * cp-support.c (add_symbol_overload_list_qualified): Use
10039         all_objfiles.
10040         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10041         Use all_objfiles.
10042         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10043         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10044         all_objfiles.
10045         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10046         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10047         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10048         Uses all_objfiles.
10049         * solib.c (solib_read_symbols): Use all_objfiles
10050
10051 2019-01-09  Tom Tromey  <tom@tromey.com>
10052
10053         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10054         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10055         all_objfiles.
10056         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10057         * symmisc.c (print_symbol_bcache_statistics)
10058         (print_objfile_statistics, maintenance_print_objfiles)
10059         (maintenance_info_symtabs, maintenance_check_symtabs)
10060         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10061         all_objfiles.
10062         * source.c (forget_cached_source_info): Use all_objfiles.
10063         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10064         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10065         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10066         * objfiles.c (update_section_map): Use all_objfiles.
10067         (shared_objfile_contains_address_p): Likewise.
10068         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10069         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10070
10071 2019-01-09  Tom Tromey  <tom@tromey.com>
10072
10073         * common/next-iterator.h: New file.
10074         * objfiles.h (class all_objfiles): New.
10075         (struct objfile_iterator): New.
10076
10077 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10078
10079         * NEWS: Move the description of the changed "frame", "select-frame",
10080          and "info frame" commands to the Changed commands section.
10081
10082 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10083
10084         * gdbtypes.c (check_stub_method_group): Remove handling of old
10085         mangling schemes.
10086         * linespec.c (find_methods): Likewise.
10087         * stabsread.c (read_member_functions): Likewise.
10088         * valops.c (search_struct_method): Likewise.
10089         (value_struct_elt_for_reference): Likewise.
10090         * NEWS: Mention this change.
10091
10092 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10093
10094         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10095         print_source_lines.
10096         * source.c (print_source_lines_base): Update line number check.
10097         (print_source_lines): New function.
10098         (source_lines_range::source_lines_range): New function.
10099         * source.h (class source_lines_range): New class.
10100         (print_source_lines): New declaration.
10101
10102 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10103
10104         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10105
10106 2019-01-08  Tom Tromey  <tom@tromey.com>
10107             Simon Marchi  <simon.marchi@ericsson.com>
10108
10109         PR gdb/24060
10110         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10111         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10112         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10113         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10114         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10115         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10116
10117 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10118
10119         * source.c (select_source_symtab): Move header comment to
10120         declaration in source.h.
10121         (forget_cached_source_info_for_objfile): Likewise.
10122         (forget_cached_source_info): Likewise.
10123         (identify_source_line): Likewise.
10124         * source.h (identify_source_line): Move declaration from symtab.h
10125         and add comment from source.c
10126         (print_source_lines): Likewise.
10127         (forget_cached_source_info_for_objfile): Likewise.
10128         (forget_cached_source_info): Likewise.
10129         (select_source_symtab): Likewise.
10130         (enum print_source_lines_flag): Move definition from symtab.h.
10131         * symtab.h (identify_source_line): Move declaration to source.h.
10132         (print_source_lines): Likewise.
10133         (forget_cached_source_info_for_objfile): Likewise.
10134         (forget_cached_source_info): Likewise.
10135         (select_source_symtab): Likewise.
10136         (enum print_source_lines_flag): Move definition to source.h.
10137         * tui/tui-hooks.c: Add 'source.h' include.
10138
10139 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10140
10141         * source.c (print_source_lines_base): Handle requests to print
10142         reverse line number sequences, and guard against empty lines
10143         string.
10144
10145 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10146
10147         * source.c (print_source_lines_base): Fix skip of '\r' if next
10148         character is '\n'.
10149
10150 2019-01-06  Tom Tromey  <tom@tromey.com>
10151
10152         * c-exp.y (struct c_parse_state) <macro_original_text,
10153         expansion_obstack>: New member.
10154         (macro_original_text, expansion_obstack): Remove globals.
10155         (scan_macro_expansion, scanning_macro_expansion)
10156         (finished_macro_expansion): Update.
10157         (scan_macro_cleanup): Remove.
10158         (yylex, c_parse): Update.
10159
10160 2019-01-06  Tom Tromey  <tom@tromey.com>
10161
10162         * c-exp.y (struct c_parse_state) <strings>: New member.
10163         (operator_stoken): Update.
10164
10165 2019-01-06  Tom Tromey  <tom@tromey.com>
10166
10167         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10168         (union type_stack_elt) <typelist_val>: Now a pointer to
10169         std::vector.
10170         (type_stack_cleanup): Don't declare.
10171         (push_typelist): Update.
10172         * parse.c (pop_typelist): Return a std::vector.
10173         (push_typelist): Take a std::vector.
10174         (follow_types): Update.  Do not free args.
10175         (type_stack_cleanup): Remove.
10176         * c-exp.y (struct c_parse_state): New.
10177         (cpstate): New global.
10178         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10179         (nonempty_typelist): Update.
10180         (func_mod): Create a new vector.
10181         (c_parse): Create a c_parse_state.
10182         (check_parameter_typelist): Do not delete params.
10183         (function_method): Update.  Do not delete type_list.
10184
10185 2019-01-06  Tom Tromey  <tom@tromey.com>
10186
10187         PR gdb/28155:
10188         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10189         check_typedef.
10190         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10191         (print_return_value): Likewise.
10192
10193 2019-01-05  Tom Tromey  <tom@tromey.com>
10194
10195         * contrib/cleanup_check.py: Remove.
10196         * contrib/gcc-with-excheck: Remove.
10197         * contrib/exsummary.py: Remove.
10198         * contrib/excheck.py: Remove.
10199
10200 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10201
10202         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10203         NULL. Initialize tpprev to NULL instead of assigning it
10204         to NULL on the next statement.
10205         * windows-nat.c (windows_delete_thread): Remove check for
10206         main_thread_id before printing thread exit notifications.
10207         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10208         Remove thread ID check against main_thread_id.
10209         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10210         windows_delete_thread.
10211         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10212
10213 2019-01-04  Tom Tromey  <tom@tromey.com>
10214
10215         * compile/compile.c (_initialize_compile): Use upper case for
10216         metasyntactic variables.
10217         * symmisc.c (_initialize_symmisc): Use upper case for
10218         metasyntactic variables.
10219         * psymtab.c (_initialize_psymtab): Use upper case for
10220         metasyntactic variables.
10221         * demangle.c (demangle_command): Use upper case for metasyntactic
10222         variables.
10223         (_initialize_demangler): Likewise.
10224         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10225         variables.
10226
10227 2019-01-03  Tom Tromey  <tom@tromey.com>
10228
10229         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10230
10231 2019-01-03  Tom Tromey  <tom@tromey.com>
10232
10233         * python/py-symtab.c (salpy_str): Update.
10234         (struct salpy_sal_object) <symtab>: Now a PyObject.
10235         (salpy_dealloc): Update.
10236         (del_objfile_sal): Use gdbpy_ref.
10237
10238 2019-01-03  Tom Tromey  <tom@tromey.com>
10239
10240         * python/py-type.c (convert_field): Use new_reference.  Return
10241         gdbpy_ref.
10242         (make_fielditem): Return gdbpy_ref.
10243         (typy_fields): Update.
10244         (typy_getitem): Update.
10245         (field_name): Return gdbpy_ref.  Use new_reference.
10246         (typy_iterator_iternext): Update.
10247
10248 2019-01-03  Tom Tromey  <tom@tromey.com>
10249
10250         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10251
10252 2019-01-03  Tom Tromey  <tom@tromey.com>
10253
10254         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10255         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10256         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10257         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10258         (pspy_set_type_printers): Likewise.
10259         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10260         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10261         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10262         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10263         (objfpy_set_type_printers): Likewise.
10264
10265 2019-01-03  Tom Tromey  <tom@tromey.com>
10266
10267         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10268         (gdbpy_print_stack): Use gdbpy_err_fetch.
10269         * python/python-internal.h (class gdbpy_err_fetch): New class.
10270         (class gdbpy_enter) <m_error_type, m_error_value,
10271         m_error_traceback>: Remove.
10272         <m_error>: New member.
10273         (gdbpy_exception_to_string): Don't declare.
10274         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10275         * python/py-value.c (convert_value_from_python): Use
10276         gdbpy_err_fetch.
10277         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10278         gdbpy_exception_to_string.
10279         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10280         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10281         gdbpy_err_fetch.
10282
10283 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10284
10285         * linux-nat.c (delete_lwp_cleanup): Delete.
10286         (struct lwp_deleter): New struct.
10287         (lwp_info_up): New typedef.
10288         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10289         lwp_info_up.
10290
10291 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10292
10293         * linux-fork.c (class scoped_switch_fork_info): New class.
10294         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10295
10296 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10297
10298         * valops.c (find_overload_match): Remove use of null_cleanup, and
10299         calls to do_cleanups.
10300
10301 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10302
10303         * compile/compile-cplus-types.c
10304         (compile_cplus_instance::decl_name): Handle changes to
10305         cp_func_name.
10306         * cp-support.c (cp_func_name): Update header comment, update
10307         return type.
10308         * cp-support.h (cp_func_name): Update return type in declaration.
10309         * valops.c (find_overload_match): Move temp_func local to top
10310         level of function and change its type.  Use temp_func to hold and
10311         delete temporary string obtained from cp_func_name.
10312
10313 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10314
10315         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10316         gdb::char_vector, remove cleanup, and update uses of `msg`.
10317
10318 2019-01-03  Jim Wilson  <jimw@sifive.com>
10319
10320         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10321
10322 2019-01-02  Tom Tromey  <tom@tromey.com>
10323
10324         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10325         (tdesc_parse_xml): Remove cleanups.
10326         * target-descriptions.h (make_cleanup_free_target_description):
10327         Don't declare.
10328         (target_desc_deleter): New struct.
10329         (target_desc_up): New typedef.
10330         * target-descriptions.c (target_desc_deleter::operator()): Rename
10331         from free_target_description.
10332         (make_cleanup_free_target_description): Remove.
10333
10334 2019-01-02  Tom Tromey  <tom@tromey.com>
10335
10336         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10337         constructor, destructor.
10338         (linespec_parser): Remove typedef.
10339         (~linespec_parser): Rename from linespec_parser_delete.
10340         (linespec_lex_to_end, linespec_complete_label)
10341         (linespec_complete): Update.
10342         (decode_line_full): Remove cleanups.
10343         (decode_line_1): Update.
10344
10345 2019-01-02  Tom Tromey  <tom@tromey.com>
10346
10347         * python/python-internal.h (inferior_to_inferior_object): Change
10348         return type.
10349         * python/py-exitedevent.c (create_exited_event_object): Update.
10350         * python/py-inferior.c (inferior_to_inferior_object): Return
10351         gdbpy_ref.
10352         (python_new_inferior, python_inferior_deleted)
10353         (thread_to_thread_object, delete_thread_object)
10354         (build_inferior_list, gdbpy_selected_inferior): Update.
10355         * python/py-infthread.c (create_thread_object): Update.  Also fail
10356         if inferior_to_inferior_object fails.
10357
10358 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10359
10360         * inferior.h (class inferior) <displaced_step_state>: New field.
10361         * infrun.h (struct displaced_step_state): Move here from
10362         infrun.c.  Initialize fields, add constructor.
10363         <inf>: Remove field.
10364         <reset>: New method.
10365         * infrun.c (struct displaced_step_inferior_state): Move to
10366         infrun.h.
10367         (displaced_step_inferior_states): Remove.
10368         (get_displaced_stepping_state): Adust.
10369         (displaced_step_in_progress_any_inferior): Adjust.
10370         (displaced_step_in_progress_thread): Adjust.
10371         (displaced_step_in_progress): Adjust.
10372         (add_displaced_stepping_state): Remove.
10373         (get_displaced_step_closure_by_addr): Adjust.
10374         (remove_displaced_stepping_state): Remove.
10375         (infrun_inferior_exit): Call displaced_step_state.reset.
10376         (use_displaced_stepping): Don't check for NULL.
10377         (displaced_step_prepare_throw): Call
10378         get_displaced_stepping_state.
10379         (displaced_step_fixup): Don't check for NULL.
10380         (prepare_for_detach): Don't check for NULL.
10381
10382 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10383
10384         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10385          in case of call that did not complete.
10386
10387 2019-01-02  Andrey Utkin  <autkin@undo.io>
10388
10389         * symfile.c (find_separate_debug_file): Fix search of debug files for
10390         remote debuggee.
10391
10392 2019-01-02  Tom Tromey  <tom@tromey.com>
10393
10394         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10395         indentation.
10396         * python/py-frame.c (frapy_older): Remove cast.
10397         (frapy_newer): Likewise.
10398         * python/py-breakpoint.c (local_setattro): Remove cast.
10399         * python/py-arch.c (archpy_name): Remove local variable.
10400         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10401
10402 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10403
10404         * unittests/basic_string_view/element_access/char/empty.cc:
10405         Fix year range in copyright header.
10406
10407 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10408
10409         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10410         Delete.
10411         <operator==>: Update with for removed field.
10412         <hash>: Likewise.
10413         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10414         <isa_features>: ...this.
10415         <abi_features>: New field.
10416         (riscv_isa_flen): Update comment.
10417         (riscv_abi_xlen): New declaration.
10418         (riscv_abi_flen): New declaration.
10419         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10420         isa_features.
10421         (riscv_abi_xlen): New function.
10422         (riscv_isa_flen): Update to get answer from isa_features.
10423         (riscv_abi_flen): New function.
10424         (riscv_has_fp_abi): Update to get answer from abi_features.
10425         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10426         xlen and flen.
10427         (riscv_call_info) <xlen, flen>: Update comment.
10428         (riscv_call_arg_struct): Remove invalid assertions
10429         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10430         is removed.
10431         (riscv_gdbarch_init): Gather isa features and abi features
10432         separately, ensure both match on the gdbarch when reusing an old
10433         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10434         a target with 64-bit float hardware.
10435
10436 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10437
10438         * source.c (search_command_helper): Stop reverse search
10439         when line 1 has been searched.
10440
10441 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10442
10443         * record-full.c (record_full_base_target::close): Rewrite
10444         record_full_core_buf_list free logic.
10445
10446 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10447
10448         * break-catch-syscall.c (print_one_catch_syscall): xfree
10449         the last text.
10450
10451 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10452
10453         * top.c (print_gdb_version): Update Copyright year in version
10454         message.
10455
10456 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10457
10458         Update copyright year range in all GDB files.
10459
10460 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10461
10462         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10463
10464 For older changes see ChangeLog-2018.
10465 \f
10466 Local Variables:
10467 mode: change-log
10468 left-margin: 8
10469 fill-column: 74
10470 version-control: never
10471 coding: utf-8
10472 End:
10473