gdb/ChangeLog

   1 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
   2             Andrew Burgess  <andrew.burgess@embecosm.com>
   3
   4         * f-typeprint.c (f_print_type): Don't return early for not
   5         associated or not allocated types.
   6         (f_type_print_varspec_suffix): Add print_rank parameter and print
   7         ranks of array types in case they dangling.
   8         (f_type_print_base): Add print_rank parameter.
   9
  10 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
  11
  12         * NEWS: Mention new MI commands.
  13         * break-catch-throw.c (enum exception_event_kind): Move to
  14         breakpoint.h.
  15         (print_mention_exception_catchpoint): Output text as a single
  16         message.
  17         (catch_exception_command_1): Rename to...
  18         (catch_exception_event): ...this, make non-static, update header
  19         command, and change some parameter types.
  20         (catch_catch_command): Update for changes to
  21         catch_exception_command_1.
  22         (catch_throw_command): Likewise.
  23         (catch_rethrow_command): Likewise.
  24         * breakpoint.c (enum exception_event_kind): Delete.
  25         * breakpoint.h (enum exception_event_kind): Moved here from
  26         break-catch-throw.c.
  27         (catch_exception_event): Declare.
  28         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
  29         (mi_cmd_catch_throw): New function.
  30         (mi_cmd_catch_rethrow): New function.
  31         (mi_cmd_catch_catch): New function.
  32         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
  33         'catch-catch' entries.
  34         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
  35         (mi_cmd_catch_rethrow): Declare.
  36         (mi_cmd_catch_catch): Declare.
  37
  38 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
  39
  40         * annotate.c (annotate_source_line): Change return type to void,
  41         update implementation to match.
  42         * annotate.h (annotate_source_line): Change return type to void,
  43         update header comment.
  44         * stack.c (print_frame_info): Don't change what frame information
  45         is printed based on whether annotations are on or not.
  46
  47 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
  48
  49         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
  50         (annotate_source): Make static.
  51         (annotate_source_line): Moved from source.c and renamed from
  52         identify_source_line.  Update the return type.
  53         * annotate.h (annotate_source): Delete declaration.
  54         (annotate_source_line): Declaration moved from source.h, and
  55         renamed from identify_source_line.  Return type updated.
  56         * source.c (identify_source_line): Moved to annotate.c and renamed
  57         to annotate_source_line.
  58         (info_line_command): Remove check of annotation_level.
  59         * source.h (identify_source_line): Move declaration to annotate.h
  60         and rename to annotate_source_line.
  61         * stack.c: Add 'annotate.h' include.
  62         (print_frame_info): Remove check of annotation_level before
  63         calling annotate_source_line.
  64
  65 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
  66
  67         * source-cache.c (source_cache::get_plain_source_lines): Use
  68         open_source_file_with_line_charpos instead of just
  69         open_source_file, remove call to find_source_lines.
  70         (source_cache::get_source_lines): Likewise.
  71         * source.c (find_source_lines): Make static.
  72         (get_filename_and_charpos): Renamed into...
  73         (open_source_file_with_line_charpos): ..this along with changes to
  74         return a scoped_fd, and some other minor clean ups.
  75         (identify_source_line): Use open_source_file_with_line_charpos.
  76         (search_command_helper): Use open_source_file_with_line_charpos
  77         instead of just open_source_file, remove call to
  78         find_source_lines.
  79         * source.h (open_source_file_with_line_charpos): Declare new
  80         function.
  81         (find_source_lines): Delete declaration.
  82
  83 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
  84
  85         * source.c (get_filename_and_charpos): Remove fullname
  86         parameter.
  87         (identify_source_line): Update call to get_filename_and_charpos.
  88
  89 2019-06-14  Tom Tromey  <tromey@adacore.com>
  90
  91         PR gdb/24502:
  92         * ui-style.h (skip_ansi_escape): Update comment.
  93         * ui-file.h (class no_terminal_escape_file): New class.
  94         * ui-file.c (no_terminal_escape_file::write)
  95         (no_terminal_escape_file::puts): New methods.
  96         * cli/cli-logging.c (handle_redirections): Use
  97         no_terminal_escape_file.
  98
  99 2019-06-14  Tom Tromey  <tromey@adacore.com>
 100
 101         * NEWS: Move convenience variable news above Python news.
 102
 103 2019-06-14  Tom Tromey  <tom@tromey.com>
 104
 105         * gnulib: Move directory to top-level.
 106         * configure.ac: Don't configure gnulib.
 107         * configure: Rebuild.
 108         * common/common-defs.h: Use new path to gnulib.
 109         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 110         (GNULIB_H): Remove.
 111         (INCGNU): Look in new gnulib location.
 112         (HFILES_NO_SRCDIR): Remove gnulib files.
 113         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 114         (generated_files): Remove GNULIB_H.
 115         ($(LIBGNU), all-lib): Remove targets.
 116         (distclean): Don't mention GNULIB_BUILDDIR.
 117         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 118
 119 2019-06-14  Tom Tromey  <tromey@adacore.com>
 120
 121         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 122         Warn if symbol file does not provide any symbols.
 123
 124 2019-06-14  Tom Tromey  <tromey@adacore.com>
 125
 126         * source.c (find_and_open_source): Respect basenames_may_differ.
 127
 128 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 129
 130         * annotate.c (annotate_breakpoints_invalid): Make use of
 131         scoped_restore_terminal_state.
 132         (annotate_frames_invalid): Likewise.
 133
 134 2019-06-14  Tom Tromey  <tromey@adacore.com>
 135
 136         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 137         allow assignment to an internalvar.
 138
 139 2019-06-14  Tom Tromey  <tromey@adacore.com>
 140
 141         * ada-lex.l: Allow "_" in attribute names.
 142
 143 2019-06-14  Tom Tromey  <tromey@adacore.com>
 144
 145         PR gdb/24653:
 146         * regcache.c (registers_changed): Don't call alloca.
 147         * top.c (execute_command): Don't call alloca.
 148
 149 2019-06-13  Pedro Alves  <palves@redhat.com>
 150
 151         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 152         'expression'.  When parsing an expression, error out if there's
 153         junk after "unlimited".
 154         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 155         (do_set_command): Adjust calls to is_unlimited_literal.
 156
 157 2019-06-13  Pedro Alves  <palves@redhat.com>
 158
 159         * compile/compile.c (make_compile_options_def_group): Add braces
 160         around array_view initializer.
 161         * thread.c (make_thread_apply_all_options_def_group)
 162         (make_thread_apply_all_options_def_group): Likewise.
 163
 164 2019-06-13  Pedro Alves  <palves@redhat.com>
 165
 166         * NEWS (New commands): Mention "maint test-options
 167         require-delimiter", "maint test-options unknown-is-error", "maint
 168         test-options unknown-is-operand" and "maint show
 169         test-options-completion-result".
 170         (New command options, command completion): New section.
 171         (Completion improvements): New section.
 172         Mention that you can abbreviate "unlimited".
 173
 174 2019-06-13  Pedro Alves  <palves@redhat.com>
 175
 176         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 177         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 178         * unittests/cli-utils-selftests.c (test_parse_flags)
 179         (test_parse_flags_qcs): Delete.
 180         (test_cli_utils): Don't call deleted functions.
 181
 182 2019-06-13  Pedro Alves  <palves@redhat.com>
 183
 184         * thread.c: Include "cli/cli-option.h".
 185         (tp_array_compar_ascending): Global.
 186         (tp_array_compar): Delete function.
 187         (tp_array_compar_ascending, tp_array_compar_descending): New
 188         functions.
 189         (ascending_option_def, qcs_flag_option_def)
 190         (thr_qcs_flags_option_defs)
 191         (make_thread_apply_all_options_def_group)
 192         (make_thread_apply_options_def_group): New.
 193         (thread_apply_all_command): Use gdb::option::process_options.
 194         (thread_apply_command_completer)
 195         (thread_apply_all_command_completer): New.
 196         (thread_apply_command): Use gdb::option::process_options.
 197         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 198         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 199         to generate help text of "thread apply".  Adjust "taas"'s help.
 200         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 201         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 202
 203 2019-06-13  Pedro Alves  <palves@redhat.com>
 204
 205         * thread.c (thread_apply_command): Check for invalid TID with
 206         isdigit instead of !isalpha.
 207
 208 2019-06-13  Pedro Alves  <palves@redhat.com>
 209
 210         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 211         (validate_flags_qcs): New.
 212         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 213         (validate_flags_qcs): Declare.
 214         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 215         (make_frame_apply_options_def_group): New.
 216         (frame_apply_command_count): Process options with
 217         gdb::option::process_options.
 218         (frame_apply_completer): New.
 219         (frame_apply_level_completer, frame_apply_all_completer)
 220         (frame_apply_completer): New.
 221         (_initialize_stack): Update help of "frame apply", "frame apply
 222         level", "frame apply all" and "faas" to mention supported options
 223         and install command completers.
 224         * stack.h (frame_apply_all_completer): Declare.
 225         * thread.c: Include "stack.h".
 226         (tfaas_command): Add "--".
 227         (_initialize_thread): Update help "tfaas" to mention supported
 228         options and install command completer.
 229
 230 2019-06-13  Pedro Alves  <palves@redhat.com>
 231
 232         * completer.c (complete_nested_command_line): New.
 233         (gdb_completion_word_break_characters_throw): Add assertion.
 234         * completer.h (complete_nested_command_line): Declare.
 235
 236 2019-06-13  Pedro Alves  <palves@redhat.com>
 237
 238         * stack.c (parse_backtrace_qualifiers): New.
 239         (backtrace_command): Use it.
 240         (backtrace_command_completer): Complete on qualifiers.
 241
 242 2019-06-13  Pedro Alves  <palves@redhat.com>
 243
 244         * frame.c: Include "cli/cli-option.h.
 245         (user_set_backtrace_options): New.
 246         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 247         Delete.
 248         (get_prev_frame): Adjust.
 249         (boolean_option_def, uinteger_option_def)
 250         (set_backtrace_option_defs): New.
 251         (_initialize_frame): Adjust and use
 252         gdb::option::add_setshow_cmds_for_options to install "set
 253         backtrace past-main" and "set backtrace past-entry".
 254         * frame.h: Include "cli/cli-option.h".
 255         (struct frame_print_options): Forward declare.
 256         (print_frame_arguments_all, print_frame_arguments_scalars)
 257         (print_frame_arguments_none): Declare.
 258         (print_entry_values): Delete declaration.
 259         (struct frame_print_options, user_frame_print_options): New.
 260         (struct set_backtrace_options): New.
 261         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 262         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 263         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 264         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 265         (list_args_or_locals): Add frame_print_options parameter.
 266         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 267         * python/py-framefilter.c (enumerate_args): Pass down
 268         USER_FRAME_PRINT_OPTIONS.
 269         * stack.c: Include "cli/cli-option.h".
 270         (print_frame_arguments_all, print_frame_arguments_scalars)
 271         (print_frame_arguments_none): Declare.
 272         (print_raw_frame_arguments, print_entry_values): Delete.
 273         (user_frame_print_options): New.
 274         (boolean_option_def, enum_option_def, frame_print_option_defs):
 275         New.
 276         (struct backtrace_cmd_options): New.
 277         (bt_flag_option_def): New.
 278         (backtrace_command_option_defs): New.
 279         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 280         (print_frame_arg, read_frame_arg, print_frame_args)
 281         (print_frame_info, print_frame): Add frame_print_options parameter
 282         and use it.
 283         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 284         (backtrace_command_1): Add frame_print_options and
 285         backtrace_cmd_options parameters and use them.
 286         (make_backtrace_options_def_group): New.
 287         (backtrace_command): Process command options with
 288         gdb::option::process_options.
 289         (backtrace_command_completer): New.
 290         (_initialize_stack): Extend "backtrace"'s help to mention
 291         supported options.  Install completer for "backtrace".
 292         Install some settings commands with add_setshow_cmds_for_options.
 293
 294 2019-06-13  Pedro Alves  <palves@redhat.com>
 295
 296         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 297         and that "set/show print raw frame-arguments" are now deprecated.
 298
 299         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 300         command.
 301         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 302         * stack.c (_initialize_stack): Install "set/show print
 303         raw-frame-arguments", and deprecate "set/show print raw
 304         frame-arguments".
 305         * valprint.c (_initialize_valprint): Deprecate "set/show print
 306         raw".
 307
 308 2019-06-13  Pedro Alves  <palves@redhat.com>
 309
 310         * compile/compile.c (struct compile_options): New.
 311         (compile_flag_option_def, compile_command_option_defs)
 312         (make_compile_options_def_group): New.
 313         (compile_file_command): Handle options with
 314         gdb::option::process_options.
 315         (compile_file_command_completer): New function.
 316         (compile_code_command): Handle options with
 317         gdb::option::process_options.
 318         (compile_code_command_completer): New function.
 319         (_initialize_compiler): Install completers for "compile code" and
 320         "compile file".  Mention available options in "compile code" and
 321         "compile code"'s help.
 322         * completer.c (advance_to_completion_word): New, factored out from
 323         ...
 324         (advance_to_expression_complete_word_point): ... this.
 325         (advance_to_filename_complete_word_point): New.
 326         * completer.h (advance_to_filename_complete_word_point): New
 327         declaration.
 328
 329 2019-06-13  Pedro Alves  <palves@redhat.com>
 330
 331         * compile/compile.c: Include "cli/cli-option.h".
 332         (compile_print_value): Scope data pointer is now a
 333         value_print_options pointer; adjust.
 334         (compile_print_command): Process options.  Scope data pointer is
 335         now a value_print_options pointer; adjust.
 336         (_initialize_compile): Update "compile print"'s help to include
 337         supported options.  Install a completer for "compile print".
 338         * cp-valprint.c (show_vtblprint, show_objectprint)
 339         (show_static_field_print): Delete.
 340         (_initialize_cp_valprint): Don't install "set print
 341         static-members", "set print vtbl", "set print object" here.
 342         * printcmd.c: Include "cli/cli-option.h" and
 343         "common/gdb_optional.h".
 344         (print_command_parse_format): Rework to fill in a
 345         value_print_options instead of a format_data.
 346         (print_value): Change parameter type from format_data pointer to
 347         value_print_options reference.  Adjust.
 348         (print_command_1): Process options.  Adjust to pass down a
 349         value_print_options.
 350         (print_command_completer): New.
 351         (_initialize_printcmd): Install print_command_completer as
 352         handle_brkchars completer for the "print" command.  Update
 353         "print"'s help to include supported options.
 354         * valprint.c: Include "cli/cli-option.h".
 355         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 356         here from cp-valprint.c.
 357         (boolean_option_def, uinteger_option_def)
 358         (value_print_option_defs, make_value_print_options_def_group):
 359         New.  Use gdb::option::add_setshow_cmds_for_options to install
 360         "set print elements", "set print null-stop", "set print repeats",
 361         "set print pretty", "set print union", "set print array", "set
 362         print address", "set print symbol", "set print array-indexes".
 363         * valprint.h: Include <string> and "cli/cli-option.h".
 364         (make_value_print_options_def_group): Declare.
 365         (print_value): Change parameter type from format_data pointer to
 366         value_print_options reference.
 367         (print_command_completer): Declare.
 368
 369 2019-06-13  Pedro Alves  <palves@redhat.com>
 370
 371         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 372         (COMMON_SFILES): Add maint-test-settings.c.
 373         * cli/cli-decode.c (boolean_enums): New global, factored out from
 374         ...
 375         (add_setshow_boolean_cmd): ... here.
 376         * cli/cli-decode.h (boolean_enums): Declare.
 377         * cli/cli-option.c: New file.
 378         * cli/cli-option.h: New file.
 379         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 380         factored out from ...
 381         (parse_cli_boolean_value(const char *)): ... this.
 382         (is_unlimited_literal): Change parameter type to pointer to
 383         pointer.  Adjust and advance ARG pointer.
 384         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 385         (parse_cli_var_enum): New, factored out from ...
 386         (do_set_command): ... this.  Adjust.
 387         * cli/cli-setshow.h (parse_cli_boolean_value)
 388         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 389         (parse_cli_var_enum): Declare.
 390         * cli/cli-utils.c: Include "cli/cli-option.h".
 391         (get_ulongest): New.
 392         * cli/cli-utils.h (get_ulongest): Declare.
 393         (check_for_argument): New overloads.
 394         * maint-test-options.c: New file.
 395
 396 2019-06-13  Pedro Alves  <palves@redhat.com>
 397
 398         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 399         parse a range if "-" is at the end of the string.
 400
 401 2019-06-13  Pedro Alves  <palves@redhat.com>
 402
 403         * cli/cli-setshow.c (parse_auto_binary_operation)
 404         (parse_cli_boolean_value): Don't allow "o".
 405
 406 2019-06-13  Pedro Alves  <palves@redhat.com>
 407
 408         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 409         * NEWS: Mention maint test-settings KIND.
 410         * maint-test-settings.c: New file.
 411
 412 2019-06-13  Pedro Alves  <palves@redhat.com>
 413
 414         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 415         completer.
 416         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 417         "set" completers.
 418
 419 2019-06-13  Pedro Alves  <palves@redhat.com>
 420
 421         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 422         after item.
 423
 424 2019-06-13  Pedro Alves  <palves@redhat.com>
 425
 426         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 427
 428 2019-06-13  Pedro Alves <palves@redhat.com>
 429
 430         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 431         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 432         call.
 433         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 434         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 435         calls.
 436         (check_for_argument): Skip spaces after argument.
 437
 438 2019-06-13  Pedro Alves  <palves@redhat.com>
 439
 440         * thread.c (thread_apply_command): Adjust TID parsing.
 441         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 442         detected before end of string.
 443         (tid_is_in_list): Error out if LIST is invalid.
 444
 445 2019-06-13  Pedro Alves  <palves@redhat.com>
 446
 447         * completer.c (complete_line_internal_1): Rewind completion word
 448         point.
 449         (completion_tracker::advance_custom_word_point_by): Change
 450         parameter type to int.
 451         * completer.h (completion_tracker::advance_custom_word_point_by):
 452         Likewise.
 453
 454 2019-06-13  Pedro Alves  <palves@redhat.com>
 455
 456         * completer.c (advance_to_completion_word): Handle delimiters.
 457
 458 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 459
 460         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 461
 462 2019-06-11  Tom Tromey  <tom@tromey.com>
 463
 464         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 465         (xmalloc_failed): Move to alloc.c.
 466         * alloc.c: New file.
 467         * Makefile.in (COMMON_SFILES): Add alloc.c.
 468
 469 2019-06-11  Tom Tromey  <tom@tromey.com>
 470
 471         * nat/linux-waitpid.c: Don't include server.h.
 472         (linux_debug): Remove.
 473         (my_waitpid): Update.
 474
 475 2019-06-11  Tom Tromey  <tromey@adacore.com>
 476
 477         * infcall.c (_initialize_infcall): Remove trailing newline from
 478         help.
 479         * user-regs.c (_initialize_user_regs): Remove trailing newline
 480         from help.
 481         * typeprint.c (_initialize_typeprint): Remove trailing newline
 482         from help.
 483         * reverse.c (_initialize_reverse): Remove trailing newlines from
 484         help.
 485         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 486         from help.
 487         * language.c (add_set_language_command): Remove trailing newline
 488         from help.
 489         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 490         help.
 491         * disasm.c (_initialize_disasm): Remove trailing newline from
 492         help.
 493         * top.c (init_main): Remove trailing newline from help.
 494         * interps.c (_initialize_interpreter): Remove trailing newline
 495         from help.
 496         * btrace.c (_initialize_btrace): Remove trailing newlines from
 497         help.
 498         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 499         from help.
 500         * python/python.c (_initialize_python): Remove trailing newline
 501         from help.
 502         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 503         help.
 504         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 505         from help.  Reformat some text.
 506         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 507         from help.
 508         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 509         newline from help.
 510
 511 2019-06-11  Tom Tromey  <tromey@adacore.com>
 512
 513         * darwin-nat.c (darwin_decode_exception_message)
 514         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 515
 516 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 517
 518         * valops.c (value_slice): Check for not allocated or not
 519         associated values.
 520
 521 2019-06-10  Tom de Vries  <tdevries@suse.de>
 522
 523         PR gdb/24618
 524         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 525         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 526         invalid.
 527
 528 2019-06-10  Tom de Vries  <tdevries@suse.de>
 529
 530         PR gdb/24611
 531         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 532         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 533
 534 2019-06-10  Tom de Vries  <tdevries@suse.de>
 535
 536         PR symtab/24545
 537         * symtab.c (struct demangled_name_entry): Add language field.
 538         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 539         static minimal symbol".  Set and use language field.
 540
 541 2019-06-10  Tom Tromey  <tromey@adacore.com>
 542
 543         * ada-lang.c (_initialize_ada_language): Update help text.
 544
 545 2019-06-10  Tom Tromey  <tromey@adacore.com>
 546
 547         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 548         with a newline.
 549         * guile/guile.c (handle_boot_error): Don't end warning with a
 550         newline.
 551         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 552         warning with a newline.
 553         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 554         newline.
 555         (s12z_frame_cache): Likewise.
 556         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 557         a newline.
 558         * solib-svr4.c (disable_probes_interface): Don't end warning with
 559         a newline.
 560         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 561         newline.
 562         * python/python.c (do_finish_initialization): Don't end warning
 563         with a newline.
 564
 565 2019-06-10  Tom Tromey  <tom@tromey.com>
 566
 567         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 568         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 569         gdbpy_enter.
 570
 571 2019-06-10  Tom Tromey  <tromey@adacore.com>
 572
 573         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 574         data.
 575         (elf_new_init): Don't call stabsread_new_init.
 576         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 577         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 578         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 579
 580 2019-06-10  Tom de Vries  <tdevries@suse.de>
 581
 582         PR symtab/16264
 583         PR symtab/24517
 584         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 585
 586 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 587
 588         * source.c (find_and_open_source): Also rewrite relative file
 589         names.
 590
 591 2019-04-26  Amos Bird  <amosbird@gmail.com>
 592
 593         * annotate.c (annotate_thread_exited): Add "thread-exited"
 594         annotation.
 595
 596 2019-06-06  Tom Tromey  <tromey@adacore.com>
 597
 598         * maint.h (class scoped_command_stats): Use
 599         DISABLE_COPY_AND_ASSIGN.
 600         <print_time>: New method.
 601         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 602         print_time.
 603         (scoped_command_stats::print_time): New method.
 604
 605 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 606
 607         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 608         instructions of lengths 6 or 8 bytes.
 609
 610 2019-06-04  Pedro Alves  <palves@redhat.com>
 611
 612         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 613
 614         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 615         * breakpoint.c (condition_completer): Likewise.
 616         * cli/cli-dump.c (scan_expression): Likewise.
 617         * common/filestuff.c (mkdir_recursive): Likewise.
 618         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 619         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 620         (gdb_abspath): Likewise.
 621         * compile/compile-cplus-types.c
 622         (compile_cplus_instance::decl_name): Likewise.
 623         * completer.c (complete_explicit_location):
 624         (signal_completer, reg_or_group_completer_1): Likewise.
 625         * cp-support.c (cp_remove_params_if_any): Likewise.
 626         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 627         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 628         * infcmd.c (strip_bg_char): Likewise.
 629         * linespec.c (copy_token_string): Likewise.
 630         * mi/mi-main.c (output_cores): Likewise.
 631         * psymtab.c (psymtab_search_name):
 632         * symfile.c (test_set_ext_lang_command): Likewise.
 633         * target.c (target_fileio_read_stralloc): Likewise.
 634         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 635         * value.c (complete_internalvar): Likewise.
 636
 637 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 638
 639         Add objfile property to gdb.Type.
 640         * NEWS: Mention Python API addition.
 641         * python/py-type.c (typy_get_objfile): New method.
 642
 643 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 644
 645         * NEWS: Mention the new set|show style [title|highlight].
 646         Mention changes to "show style", "help" and "apropos".
 647
 648 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 649
 650         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 651         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 652         instead of print_help_for_command.
 653         (print_doc_of_command): New function.
 654         (help_list): Add 'apropos -v word' suggestion.
 655         (print_help_for_command): Style the command name using title style.
 656         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 657         (_initialize_cli_cmds): Describe -v in apropos_command help.
 658
 659 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 660
 661         * cli/cli-style.h (cli_style_option): Add name in constructor,
 662         add m_name class member, add constructor with intensity,
 663         add name class function.
 664         (cli_style_option::add_setshow_commands): Remove name argument.
 665         (highlight_style, title_style): New styles.
 666         * cli/cli-style.c (do_show): New function that shows a style
 667         characteristic styling the style name with itself.
 668         (set_style_name): New function.
 669         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 670         Update all callers according to the changes in cli/cli-style.h.
 671         * utils.h (fputs_highlighted): New function.
 672         * utils.c (fputs_highlighted): Likewise.
 673
 674 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 675
 676         * NEWS: Mention new pipe command and new convenience variables.
 677
 678 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 679
 680         * cli/cli-cmds.c (pipe_command): New function.
 681         (_initialize_cli_cmds): Call add_com for pipe_command.
 682         Define | as an alias for pipe.
 683         (exit_status_set_internal_vars): New function.
 684         (shell_escape): Call exit_status_set_internal_vars.
 685         cli/cli-decode.c (find_command_name_length): Recognize | as
 686         a single character command.
 687
 688 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 689
 690         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 691         top.c (execute_command_to_ui_file): New function, mostly a copy
 692         of execute_command_to_string.
 693         (execute_command_to_string): Implement by calling
 694         execute_command_to_ui_file.
 695
 696 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 697
 698         * top.h (saved_command_line): Remove declaration.
 699         * top.c (previous_saved_command_line, previous_repeat_arguments):
 700         New variables.
 701         (saved_command_line): Make static, define together with other
 702         'repeat variables'.
 703         (dont_repeat): Clear repeat_arguments.
 704         (repeat_previous, get_saved_command_line, save_command_line):
 705         New functions.
 706         (gdb_init): Initialize saved_command_line
 707         and previous_saved_command_line.
 708         * main.c (captured_main_1): Remove saved_command_line initialization.
 709         * event-top.c (handle_line_of_input): Update to use
 710         the new 'repeat' related functions instead of direct access to
 711         saved_command_line.
 712         * command.h (repeat_previous, get_saved_command_line,
 713         save_command_line): New declarations.
 714         (dont_repeat): Add comment.
 715
 716 2019-05-30  Tom Tromey  <tromey@adacore.com>
 717
 718         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 719         Fix comment.
 720         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 721
 722 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 723
 724         PR cli/24587
 725         * completer.c (complete): Initialize variable word.
 726
 727 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 728
 729         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 730         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 731         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 732         'body' is NULL to the outter 'if', protecting the '!is_define'
 733         situation as well.
 734
 735 2019-05-29  Tom Tromey  <tromey@adacore.com>
 736
 737         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 738         (dwarf_unknown): New function.
 739         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 740         (dwarf_type_encoding_name): Use dwarf_unknown.
 741
 742 2019-05-29  Tom Tromey  <tromey@adacore.com>
 743
 744         PR c++/20020:
 745         * cp-valprint.c (cp_print_value_fields): Call
 746         cp_print_static_field inside "try".
 747
 748 2019-05-29  Tom Tromey  <tromey@adacore.com>
 749
 750         * inflow.c (struct terminal_info): Add default operator=.
 751         * configure: Rebuild.
 752         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 753         -Wdeprecated-copy-dtor, -Wredundant-move.
 754
 755 2019-05-29  Tom Tromey  <tromey@adacore.com>
 756
 757         * NEWS: Add entry.
 758         * infcmd.c (print_return_value_1): Handle finish_print
 759         option.
 760         (show_print_finish): New function.
 761         (_initialize_infcmd): Add "set/show print finish" commands.
 762         * valprint.c (user_print_options): Initialize new member.
 763         * valprint.h (struct value_print_options) <finish_print>: New
 764         member.
 765
 766 2019-05-28  Tom Tromey  <tromey@adacore.com>
 767
 768         * ada-lang.c (ada_remove_Xbn_suffix)
 769         (find_old_style_renaming_symbol)
 770         (parse_old_style_renaming): Remove.
 771         (ada_find_renaming_symbol): Don't call
 772         find_old_style_renaming_symbol.
 773         (ada_is_renaming_symbol): Rename from
 774         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 775         bool.  Now static.
 776         (ada_read_var_value): Update and simplify.
 777         * ada-exp.y (write_var_or_type): Remove old code.
 778
 779 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 780
 781         * event-top.c: Remove include comment.
 782         * inflow.c (class scoped_ignore_sigttou): Move from here...
 783         * inflow.h (class scoped_ignore_sigttou): ...to here.
 784         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 785         * top.c:  Remove include comment.
 786
 787 2019-05-27  Tom Tromey  <tom@tromey.com>
 788
 789         * NEWS: Fix typo.
 790
 791 2019-05-22  Tom Tromey  <tromey@adacore.com>
 792
 793         * target.c (target_follow_exec): Constify parameter.
 794         * target-delegates.c: Rebuild.
 795         * remote.c (remote_target::follow_exec): Constify parameter.
 796         * infrun.c (follow_exec): Constify parameter.
 797         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 798         (target_follow_exec): Likewise.
 799
 800 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 801
 802         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 803         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 804
 805 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 806
 807         * NEWS: Add debugredirect and testsuite sections.
 808
 809 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 810
 811         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 812         target descriptions using exclusively floating point register name
 813         aliases.
 814
 815 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 816
 817         PR gdb/18644:
 818         * f-lang.c (build_fortran_types): Handle the case where
 819         gdbarch_floatformat_for_type returns a nullptr.
 820
 821 2019-05-21  Tom de Vries  <tdevries@suse.de>
 822
 823         PR cli/24587
 824         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 825
 826 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 827
 828         PR gdb/18644:
 829         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 830         16-byte floats.
 831         * i386-tdep.c (i386_floatformat_for_type): Use
 832         floatformats_ia64_quad for the 16-byte floating point component
 833         within a fortran 32-byte complex number.
 834
 835 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 836
 837         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 838         delete default constructor.
 839         (find_partial_die): Update to return const struct.
 840         (partial_die_parent_scope): Move variable declaration into scope
 841         of its use and change its type to auto.
 842         (guess_partial_die_structure_name): Likewise.
 843         (partial_die_info::fixup): Likewise.
 844
 845 2019-05-17  Tom Tromey  <tromey@adacore.com>
 846
 847         * source.c (find_and_open_source): Remove cast.
 848
 849 2019-05-17  Tom Tromey  <tromey@adacore.com>
 850
 851         * annotate.c (annotate_source): Make "filename" const.
 852         * annotate.h (annotate_source): Use const.
 853
 854 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 855
 856         * disasm.c (set_disassembler_options): Send errors to stderr.
 857
 858 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 859
 860         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 861         (cli_interp_base::set_logging): Check debug_redirect.
 862         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 863         * cli/cli-logging.c (debug_redirect): Add static variable.
 864         (pop_output_files): Add default param.
 865         (handle_redirections): Print debug setting.
 866         (show_logging_command): Likewise.
 867         (_initialize_cli_logging): Add debugredirect command.
 868         * interps.c (current_interp_set_logging): Add debug_redirect
 869         parameter.
 870         * interps.h (set_logging): Add debug_redirect parameter.
 871         (current_interp_set_logging): Likewise.
 872         * mi/mi-common.h: Likewise.
 873         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 874
 875 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 876             Tom Tromey  <tromey@adacore.com>
 877
 878         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 879         directly.
 880         * cli/cli-interp.h (make_logging_output): Remove declaration.
 881         * cli/cli-logging.c (make_logging_output): Remove function.
 882         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 883         directly.
 884         * ui-file.c (tee_file::tee_file): Remove bools.
 885         (tee_file::~tee_file): Remove deletes.
 886         * ui-file.h (tee_file): Remove bools.
 887
 888 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 889
 890         * mi/mi-cmds.h (mi_cmd_complete): New function.
 891         * mi/mi-main.c (mi_cmd_complete): Likewise.
 892         * mi/mi-cmds.c: Define new MI command -complete.
 893         * NEWS: Mention new -complete command.
 894
 895 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 896
 897         * completer.h (complete): New function.
 898         * completer.c (complete): Likewise.
 899         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 900         function defined in completer.h.
 901
 902 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 903
 904        * MAINTAINERS (Write After Approval): Add myself.
 905
 906 2019-05-17  Tom de Vries  <tdevries@suse.de>
 907
 908         PR gdb/24094
 909         * dwarf2read.c (struct cu_partial_die_info): New struct.
 910         (find_partial_die): Return cu_partial_die_info.
 911         (partial_die_parent_scope, guess_partial_die_structure_name)
 912         (partial_die_info::fixup): Handle new return type of find_partial_die.
 913
 914 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 915
 916         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 917         "std::string", simplifying the algorithm.
 918
 919 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 920
 921         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 922         (stap_static_probe_ops::get_probes): Likewise.
 923
 924 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 925
 926         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 927         '-')" and "else if".
 928         (stap_parse_single_operand): Join checks for
 929         "gdbarch_stap_parse_special_token_p" and
 930         "gdbarch_stap_parse_special_token" in the same "if" statement.
 931         Invert check when verifying for operation on register
 932         displacement.
 933
 934 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 935
 936         * stap-probe.c (stap_get_opcode): Update comment.
 937         (stap_get_expected_argument_type): Likewise.
 938         (handle_stap_probe): Likewise.
 939
 940 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 941
 942         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 943         return type to 'bool'.  Adjust comment.  Use 'bool' when
 944         appropriate.
 945         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 946         * stap-probe.c (stap_parse_argument_1): Likewise.
 947         (stap_is_operator): Likewise.
 948         (stap_is_generic_prefix): Likewise.
 949         (stap_is_register_prefix): Likewise.
 950         (stap_is_register_indirection_prefix): Likewise.
 951         (stap_is_integer_prefix): Likewise.
 952         (stap_generic_check_suffix): Likewise.
 953         (stap_check_integer_suffix): Likewise.
 954         (stap_check_register_suffix): Likewise.
 955         (stap_check_register_indirection_suffix): Likewise.
 956         (stap_parse_register_operand): Likewise.
 957         (stap_parse_single_operand): Likewise.
 958         (stap_parse_argument_1): Likewise.
 959         (stap_probe::get_argument_count): Likewise.
 960         (stap_is_operator): Likewise.
 961
 962 2019-05-16  Tom Tromey  <tromey@adacore.com>
 963
 964         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 965         keyword to foreach.
 966
 967 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 968
 969         * linux-thread-db.c (try_thread_db_load_1): Change return type
 970         to bool.
 971         (try_thread_db_load): Likewise.
 972         (try_thread_db_load_from_pdir_1): Likewise.
 973         (try_thread_db_load_from_pdir): Likewise.
 974         (try_thread_db_load_from_sdir): Likewise.
 975         (try_thread_db_load_from_dir): Likewise.
 976         (thread_db_load_search): Likewise.
 977         (has_libpthread): Likewise.
 978         (thread_db_load): Likewise.
 979
 980 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 981
 982         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 983         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 984         NULL, and complain/return if that's the case.
 985
 986 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 987
 988         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 989         (advance, posn, abstract_read_memory): New functions.
 990         [struct mem_read_abstraction]: New struct.
 991         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 992
 993 2019-05-14  Tom Tromey  <tromey@adacore.com>
 994
 995         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 996         value is not lval_memory.
 997
 998 2019-05-14  Tom Tromey  <tromey@adacore.com>
 999
1000         * solib.c (info_sharedlibrary_command): Style the file name.
1001
1002 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1003
1004         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1005         (aarch64_vnv_type): Likewise.
1006         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1007         * common/tdesc.c: Likewise.
1008         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1009         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1010         * features/aarch64-fpu.xml: Add ieee half view.
1011         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1012         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1013         * gdbtypes.h (struct builtin_type): Likewise.
1014         (struct objfile_type): Likewise.
1015
1016 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1017
1018         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1019         typo.
1020         * location.h (string_to_event_location): Likewise.
1021
1022 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1023
1024         GDB 8.3 released.
1025
1026 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1027
1028         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1029         New variable declaration.
1030         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1031         New variable.
1032         (print_one_breakpoint): Use ui_out::test_flags and new global
1033         variable to compute use_fixed_output.
1034         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1035         Remove.
1036         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1037         (mi_multi_location_breakpoint_output_fixed): Remove.
1038         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1039         new variable.
1040         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1041         fix_multi_location_breakpoint_output flag if version >= 3.
1042         * ui-out.h (enum ui_out_flag)
1043         <fix_multi_location_breakpoint_output>: New enumerator.
1044
1045 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1046
1047         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1048
1049 2019-05-10  Tom Tromey  <tromey@adacore.com>
1050
1051         * ada-lang.c (catch_ada_completer): New function.
1052         (_initialize_ada_language): Use it.
1053
1054 2019-05-10  Tom Tromey  <tromey@adacore.com>
1055
1056         * thread.c (print_thread_info): Make "requested_threads" const.
1057         * gdbthread.h (print_thread_info): Make "requested_threads"
1058         const.
1059         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1060         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1061
1062 2019-05-08  Tom Tromey  <tom@tromey.com>
1063
1064         * gdbtypes.c (objfile_type_data): Change type.
1065         (objfile_type, _initialize_gdbtypes): Update.
1066
1067 2019-05-08  Tom Tromey  <tom@tromey.com>
1068
1069         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1070         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1071         (_initialize_dwarf2_frame): Update.
1072
1073 2019-05-08  Tom Tromey  <tom@tromey.com>
1074
1075         * objc-lang.c (objc_objfile_data): Change type.
1076         (find_methods): Update.
1077         (_initialize_objc_lang): Remove.
1078
1079 2019-05-08  Tom Tromey  <tom@tromey.com>
1080
1081         * stabsread.c (rs6000_builtin_type_data): Change type.
1082         (rs6000_builtin_type, _initialize_stabsread): Update.
1083
1084 2019-05-08  Tom Tromey  <tom@tromey.com>
1085
1086         * mips-tdep.c (mips_pdr_data): Remove.
1087         (_initialize_mips_tdep): Update.
1088
1089 2019-05-08  Tom Tromey  <tom@tromey.com>
1090
1091         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1092         (hppa_init_objfile_priv_data, read_unwind_info)
1093         (find_unwind_entry, _initialize_hppa_tdep): Update.
1094
1095 2019-05-08  Tom Tromey  <tom@tromey.com>
1096
1097         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1098         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1099         on obstack.
1100         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1101
1102 2019-05-08  Tom Tromey  <tom@tromey.com>
1103
1104         * mdebugread.c (basic_type_data): Change type.
1105         (basic_type, _initialize_mdebugread): Update.
1106
1107 2019-05-08  Tom Tromey  <tom@tromey.com>
1108
1109         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1110
1111 2019-05-08  Tom Tromey  <tom@tromey.com>
1112
1113         * nto-tdep.c (nto_inferior_data_reg): Change type.
1114         (nto_inferior_data): Update.
1115         (nto_inferior_data_cleanup, nto_new_inferior_data)
1116         (_initialize_nto_tdep): Remove.
1117         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1118
1119 2019-05-08  Tom Tromey  <tom@tromey.com>
1120
1121         * ada-lang.c (struct ada_inferior_data): Add initializers.
1122         (ada_inferior_data): Change type.
1123         (ada_inferior_data_cleanup): Remove.
1124         (get_ada_inferior_data, ada_inferior_exit)
1125         (struct ada_pspace_data): Add initializers, destructor.
1126         (ada_pspace_data_handle): Change type.
1127         (get_ada_pspace_data): Update.
1128         (ada_pspace_data_cleanup): Remove.
1129
1130 2019-05-08  Tom Tromey  <tom@tromey.com>
1131
1132         * coffread.c (struct coff_symfile_info): Add initializers.
1133         (coff_objfile_data_key): Move lower.  Change type.
1134         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1135         Update.
1136         (coff_free_info): Remove.
1137
1138 2019-05-08  Tom Tromey  <tom@tromey.com>
1139
1140         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1141         (fbsd_pspace_data_handle): Move lower.  Change type.
1142         (get_fbsd_pspace_data): Update.
1143         (fbsd_pspace_data_cleanup): Remove.
1144         (_initialize_fbsd_tdep): Update.
1145
1146 2019-05-08  Tom Tromey  <tom@tromey.com>
1147
1148         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1149         (get_ada_tasks_pspace_data): Update.
1150         (ada_tasks_pspace_data_cleanup): Remove.
1151         (_initialize_tasks): Update.
1152         (ada_tasks_inferior_data_handle): Change type.
1153         (get_ada_tasks_inferior_data): Update.
1154         (ada_tasks_inferior_data_cleanup): Remove.
1155         (struct ada_tasks_pspace_data): Add initializers.
1156
1157 2019-05-08  Tom Tromey  <tom@tromey.com>
1158
1159         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1160         * symfile-debug.c (debug_sym_get_probes): Change type.
1161         * stap-probe.c (handle_stap_probe):
1162         (stap_static_probe_ops::get_probes): Change type.
1163         * probe.h (class static_probe_ops) <get_probes>: Change type.
1164         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1165         (parse_probes_in_pspace): Update.
1166         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1167         Update.
1168         (any_static_probe_ops::get_probes): Change type.
1169         * elfread.c (elfread_data): New typedef.
1170         (probe_key): Change type.
1171         (elf_get_probes): Likewise.  Update.
1172         (probe_key_free): Remove.
1173         (_initialize_elfread): Update.
1174         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1175         Change type.
1176         (dtrace_process_dof_probe, dtrace_process_dof)
1177         (dtrace_static_probe_ops::get_probe): Change type.
1178
1179 2019-05-08  Tom Tromey  <tom@tromey.com>
1180
1181         * xcoffread.c (struct xcoff_symfile_info): Rename from
1182         coff_symfile_info.  Add initializers.
1183         (xcoff_objfile_data_key): Move lower.  Change type.
1184         (XCOFF_DATA): Rewrite.
1185         (xcoff_free_info): Remove.
1186         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1187         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1188         (xcoff_initial_scan): Update.
1189
1190 2019-05-08  Tom Tromey  <tom@tromey.com>
1191
1192         * solib-svr4.c (struct svr4_info): Add initializers and
1193         destructor.
1194         <probes_table>: Now an htab_up.
1195         (solib_svr4_pspace_data): Change type.
1196         (free_probes_table): Simplify.
1197         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1198         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1199         (probes_table_remove_objfile_probes, register_solib_event_probe)
1200         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1201         (_initialize_svr4_solib): Update.
1202
1203 2019-05-08  Tom Tromey  <tom@tromey.com>
1204
1205         * remote.c (remote_pspace_data): Change type.
1206         (remote_pspace_data_cleanup): Remove.
1207         (get_remote_exec_file, set_pspace_remote_exec_file)
1208         (_initialize_remote): Update.
1209
1210 2019-05-08  Tom Tromey  <tom@tromey.com>
1211
1212         * breakpoint.c (breakpoint_objfile_key): Change type.
1213         (get_breakpoint_objfile_data): Update.
1214         (free_breakpoint_objfile_data): Remove.
1215         (_initialize_breakpoint): Update.
1216
1217 2019-05-08  Tom Tromey  <tom@tromey.com>
1218
1219         * linux-tdep.c (struct linux_info): Add initializers.
1220         (linux_inferior_data): Move.  Change type.
1221         (invalidate_linux_cache_inf): Update.
1222         (linux_inferior_data_cleanup): Remove.
1223         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1224
1225 2019-05-08  Tom Tromey  <tom@tromey.com>
1226
1227         * auxv.c (auxv_inferior_data): Move.  Change type.
1228         (auxv_inferior_data_cleanup): Remove.
1229         (invalidate_auxv_cache_inf): Rewrite.
1230         (get_auxv_inferior_data, _initialize_auxv): Update.
1231
1232 2019-05-08  Tom Tromey  <tom@tromey.com>
1233
1234         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1235         (symfile_debug_objfile_data_key): Change type.
1236         (symfile_debug_installed, debug_qf_has_symbols)
1237         (debug_qf_find_last_source_symtab)
1238         (debug_qf_forget_cached_source_info)
1239         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1240         (debug_qf_print_stats, debug_qf_dump)
1241         (debug_qf_expand_symtabs_for_function)
1242         (debug_qf_expand_all_symtabs)
1243         (debug_qf_expand_symtabs_with_fullname)
1244         (debug_qf_map_matching_symbols)
1245         (debug_qf_expand_symtabs_matching)
1246         (debug_qf_find_pc_sect_compunit_symtab)
1247         (debug_qf_map_symbol_filenames)
1248         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1249         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1250         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1251         (debug_sym_read_linetable, debug_sym_relocate): Update.
1252         (symfile_debug_free_objfile): Remove.
1253         (install_symfile_debug_logging, _initialize_symfile_debug):
1254         Update.
1255
1256 2019-05-08  Tom Tromey  <tom@tromey.com>
1257
1258         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1259         allocate_on_obstack.
1260         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1261         (get_dwarf2_per_objfile): Update.
1262         (set_dwarf2_per_objfile): Remove.
1263         (dwarf2_has_info, dwarf2_get_section_info): Update.
1264         (dwarf2_free_objfile): Remove.
1265         (_initialize_dwarf2_read): Update.
1266
1267 2019-05-08  Tom Tromey  <tom@tromey.com>
1268
1269         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1270         initializers.
1271         <unsupported_script_warning_printed,
1272         script_not_found_warning_printed>: Now bool.
1273         (auto_load_pspace_data): Change type.
1274         (~auto_load_pspace_info): Rename from
1275         auto_load_pspace_data_cleanup.
1276         (get_auto_load_pspace_data, init_loaded_scripts_info)
1277         (clear_section_scripts, maybe_print_unsupported_script_warning)
1278         (maybe_print_script_not_found_warning, _initialize_auto_load):
1279         Update.
1280
1281 2019-05-08  Tom Tromey  <tom@tromey.com>
1282
1283         * objfiles.c (objfile_pspace_info): Add destructor and
1284         initializers.
1285         (objfiles_pspace_data): Change type.
1286         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1287         (get_objfile_pspace_data): Update.
1288         (objfiles_bfd_data): Change type.
1289         (get_objfile_bfd_data): Update.
1290         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1291
1292 2019-05-08  Tom Tromey  <tom@tromey.com>
1293
1294         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1295         Change type.
1296         (get_catch_syscall_inferior_data): Update.
1297         (catch_syscall_inferior_data_cleanup): Remove.
1298         (_initialize_break_catch_syscall): Update.
1299
1300 2019-05-08  Tom Tromey  <tom@tromey.com>
1301
1302         * inflow.c (struct terminal_info): Add destructor and
1303         initializers.
1304         (inflow_inferior_data): Change type.
1305         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1306         (get_inflow_inferior_data, inflow_inferior_exit)
1307         (swap_terminal_info, _initialize_inflow): Update.
1308
1309 2019-05-08  Tom Tromey  <tom@tromey.com>
1310
1311         * target-dcache.c (target_dcache_cleanup): Remove.
1312         (target_dcache_aspace_key): Change type.
1313         (target_dcache_init_p, target_dcache_invalidate)
1314         (target_dcache_get, target_dcache_get_or_init)
1315         (_initialize_target_dcache): Update.
1316         * dcache.h (struct dcache_deleter): New.
1317
1318 2019-05-08  Tom Tromey  <tom@tromey.com>
1319
1320         * symtab.c (struct symbol_cache): Add destructor and
1321         initializers.
1322         (symbol_cache_key): Move.  Change type.
1323         (make_symbol_cache, free_symbol_cache): Remove.
1324         (get_symbol_cache): Update.
1325         (symbol_cache_cleanup): Remove.
1326         (ALL_PSPACES, symbol_cache_flush)
1327         (maintenance_print_symbol_cache)
1328         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1329         Update.
1330
1331 2019-05-08  Tom Tromey  <tom@tromey.com>
1332
1333         * symtab.c (struct main_info): Add destructor and initializers.
1334         (main_progspace_key): Move.  Change type.
1335         (get_main_info): Update.
1336         (main_info_cleanup): Remove.
1337         (_initialize_symtab): Update.
1338
1339 2019-05-08  Tom Tromey  <tom@tromey.com>
1340
1341         * registry.h (DECLARE_REGISTRY): Define the _key class.
1342
1343 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1344
1345         * NEWS: Merge two 'New commands' sections.
1346
1347 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1348
1349         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1350         parameter and use Ada language definition instead.
1351         (ada_val_print_ptr): Remove unused language parameter.
1352         (ada_val_print_num): Remove language parameter and use Ada language
1353         definition instead.
1354         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1355         parameter.
1356         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1357         parameter and use Ada language definition instead.
1358         (ada_val_print_1): Update all ada_val_print_xxx calls.
1359         Remove language parameter.
1360         (ada_val_print): Update ada_val_print_1 call.
1361
1362 2019-05-08  Tom Tromey  <tromey@adacore.com>
1363
1364         * remote.c (remote_hw_watchpoint_limit)
1365         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1366         Now static.
1367
1368 2019-05-08  Tom Tromey  <tromey@adacore.com>
1369
1370         * maint.c (_initialize_maint_cmds): Move initialization code to
1371         remote.c.
1372         (watchdog, show_watchdog): Move to remote.c.
1373         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1374         "watchdog" static.
1375         (_initialize_remote): Move initialization code from maint.c.
1376         * defs.h (watchdog): Don't declare.
1377
1378 2019-05-08  Tom Tromey  <tromey@adacore.com>
1379
1380         * tui/tui-interp.c: Include main.h.
1381         * interps.c: Include main.h.
1382         * main.h (interpreter_p): Declare.
1383         * defs.h (interpreter_p): Don't declare.
1384
1385 2019-05-08  Tom Tromey  <tromey@adacore.com>
1386
1387         * dwarf2loc.c: Include dwarf2read.h.
1388         * defs.h (read_unsigned_leb128): Don't declare.
1389         * dwarf2read.h (read_unsigned_leb128): Declare.
1390
1391 2019-05-08  Tom Tromey  <tromey@adacore.com>
1392
1393         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1394         method.
1395
1396 2019-05-08  Tom Tromey  <tromey@adacore.com>
1397
1398         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1399         when no wrap column is set.
1400
1401 2019-05-08  Tom Tromey  <tromey@adacore.com>
1402
1403         * c-lang.c (c_get_string): Handle non-C-style arrays.
1404
1405 2019-05-08  Tom Tromey  <tromey@adacore.com>
1406
1407         * typeprint.c (print_offset_data::update): Print the bit offset,
1408         not the number of bits remaining.
1409
1410 2019-05-08  Tom Tromey  <tromey@adacore.com>
1411
1412         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1413         padding at end of comment.
1414
1415 2019-05-08  Tom Tromey  <tromey@adacore.com>
1416
1417         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1418         Compare main types.
1419
1420 2019-05-06  Tom Tromey  <tom@tromey.com>
1421
1422         * common/scoped_mmap.c: Include common-defs.h.
1423         * common/scoped_mmap.h: Don't include config.h.
1424
1425 2019-05-04  Tom Tromey  <tom@tromey.com>
1426
1427         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1428         (struct aarch64_call_info): Add initializers.
1429         <si>: Now a std::vector.
1430         (pass_on_stack, aarch64_push_dummy_call): Update.
1431
1432 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1433             Tom Tromey  <tom@tromey.com>
1434
1435         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1436         (ppc_threads): Now a std::vector.  Now static.
1437         (hwdebug_find_thread_points_by_tid)
1438         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1439         Update.
1440
1441 2019-05-04  Tom Tromey  <tom@tromey.com>
1442
1443         * arc-tdep.c (arc_tdesc_init): Return bool.
1444
1445 2019-05-04  Tom Tromey  <tom@tromey.com>
1446
1447         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1448         Use gdb_assert_not_reached.
1449
1450 2019-05-04  Tom Tromey  <tom@tromey.com>
1451
1452         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1453         "false".
1454
1455 2019-05-04  Tom Tromey  <tom@tromey.com>
1456
1457         * arc-tdep.c (arc_tdesc_init): Use bool.
1458
1459 2019-05-04  Tom Tromey  <tom@tromey.com>
1460
1461         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1462
1463 2019-05-04  Tom Tromey  <tom@tromey.com>
1464
1465         * cli/cli-cmds.c (valid_command_p): Return bool.
1466
1467 2019-05-04  Tom Tromey  <tom@tromey.com>
1468
1469         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1470         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1471
1472 2019-05-04  Raul Tambre  <raul@tambre.ee>
1473
1474         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1475         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1476         operator for comparison.
1477
1478 2019-05-04  Tom Tromey  <tom@tromey.com>
1479
1480         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1481         (lookup_partial_symbol, print_partial_symbols)
1482         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1483         (psymbol_compare): Update.
1484         (add_psymbol_to_bcache): Clear the entire psymbol.
1485         (maintenance_check_psymtabs): Update.
1486         * psympriv.h (struct partial_symbol): Don't derive from
1487         general_symbol_info.
1488         <obj_section, unrelocated_address, address,
1489         set_unrelocated_address>: Update.
1490         <ginfo>: New member.
1491         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1492         (debug_names::write_psymbols): Update.
1493
1494 2019-05-04  Tom de Vries  <tdevries@suse.de>
1495
1496         * contrib/cc-with-tweaks.sh: Support -n arg.
1497
1498 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1499
1500         * corelow.c (core_target::detach): Ensure frame cache and
1501         register caches are cleared.
1502         inferior.c (exit_inferior_1): Likewise.
1503
1504 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1505             Tom Tromey  <tom@tromey.com>
1506
1507         * dictionary.c (collate_pending_symbols_by_language): Remove
1508         "struct" from foreach.
1509         * symtab.c (lookup_global_symbol_from_objfile)
1510         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1511         foreach.
1512         * ser-tcp.c (net_open): Remove "struct" from foreach.
1513         * objfiles.c (objfile_relocate, objfile_rebase)
1514         (objfile_has_symbols): Remove "struct" from foreach.
1515         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1516         from foreach.
1517         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1518         foreach.
1519         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1520         "struct" from foreach.
1521         * ada-lang.c (create_excep_cond_exprs)
1522         (ada_exception_catchpoint_cond_string): Remove "struct" from
1523         foreach.
1524
1525 2019-05-03  Tom Tromey  <tromey@adacore.com>
1526
1527         * ada-exp.y (convert_char_literal): Check suffix of each
1528         enumerator.
1529
1530 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1531
1532         PR ada/21406:
1533         * ada-exp.y (yywrap): Don't define.
1534         * ada-lex.l (%option): Add noyywrap
1535         (yywrap): Remove.
1536
1537 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1538
1539         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1540         _WIN32_WINNT to the XP level, unless already defined to a higher
1541         level.
1542
1543         * unittests/parse-connection-spec-selftests.c:
1544         * ser-tcp.c:
1545         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1546         override.
1547
1548         * symfile.c (find_separate_debug_file): Remove colon from the
1549         drive spec of DOS/Windows file names of the target, so that the
1550         file name produced from DEBUGDIR and the target's directory will
1551         be valid on DOS/Windows systems.
1552
1553 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1554
1555         * rust-lang.c (val_print_struct): Handle printing structures
1556         containing strings.
1557
1558 2019-05-02  Tom Tromey  <tromey@adacore.com>
1559
1560         * valarith.c (_initialize_valarith): Remove.
1561
1562 2019-05-01  Tom Tromey  <tromey@adacore.com>
1563
1564         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1565         bitfields.
1566
1567 2019-05-01  Tom Tromey  <tromey@adacore.com>
1568
1569         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1570         for big-endian copies.
1571
1572 2019-04-30  Ali Tamur  <tamur@google.com>
1573         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1574         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1575         (read_3_bytes): New function.
1576
1577 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1578
1579         * windows-nat.c (main_thread_id): Delete.
1580         (handle_output_debug_string): Replace main_thread_id by
1581         current_event.dwThreadId.
1582         (fake_create_process): Likewise.
1583         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1584         Do not set main_thread_id.
1585         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1586         current_event.dwThreadId.
1587         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1588
1589 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1590
1591         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1592         Use current_event.dwThreadId instead of main_thread_id.
1593
1594 2019-04-30  Tom Tromey  <tromey@adacore.com>
1595
1596         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1597         (create_excep_cond_exprs): Iterate over program spaces.
1598         (ada_exception_catchpoint_cond_string): Examine all minimal
1599         symbols for exception types.
1600
1601 2019-04-30  Tom Tromey  <tromey@adacore.com>
1602
1603         PR c++/24470:
1604         * dwarf2read.c (process_structure_scope): Handle case where type
1605         has template parameters but no symbol was created.
1606
1607 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1608             Chris January  <chris.january@arm.com>
1609
1610         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1611         qualifier.
1612         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1613
1614 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1615
1616         * f-typeprint.c (f_print_type): Update rules for printing
1617         whitespace.
1618         (f_type_print_varspec_suffix): Likewise.
1619
1620 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1621             Chris January  <chris.january@arm.com>
1622
1623         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1624         function arguments.
1625
1626 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1627
1628         * f-lang.c (build_fortran_types): Change name of void type to
1629         lower case.
1630         * f-typeprint.c (f_type_print_base): Print the name of the void
1631         type, rather than a fixed string.
1632         * f-valprint.c (f_decorations): Use lower case void string.
1633
1634 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1635             Chris January  <chris.january@arm.com>
1636
1637         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1638         types for Fortran.
1639
1640 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1641             Chris January  <chris.january@arm.com>
1642             David Lecomber  <david.lecomber@arm.com>
1643
1644         * f-exp.y (BINOP_INTRINSIC): New token.
1645         (exp): New parser rule handling BINOP_INTRINSIC.
1646         (f77_keywords): Add new builtin procedures.
1647         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1648         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1649         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1650         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1651         (print_unop_subexp_f): New function.
1652         (print_binop_subexp_f): New function.
1653         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1654         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1655         (dump_subexp_body_f): Likewise.
1656         (operator_check_f): Likewise.
1657         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1658         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1659
1660 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1661
1662         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1663         UNOP_KIND.
1664         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1665         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1666         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1667         (operator_length_f): New fuction.
1668         (print_subexp_f): New function.
1669         (op_name_f): New function.
1670         (dump_subexp_body_f): New function.
1671         (operator_check_f): New function.
1672         (exp_descriptor_f): Replace standard expression handling functions
1673         with new functions.
1674         * gdb/fortran-operator.def: New file.
1675         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1676         * gdb/std-operator.def: Remove UNOP_KIND.
1677
1678 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1679
1680         * std-operator.def: Remove unbalanced, stray double quote
1681         character.
1682
1683 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1684             Chris January  <chris.january@arm.com>
1685             Daniel Everett  <daniel.everett@arm.com>
1686             Nick Forrington  <nick.forrington@arm.com>
1687             Richard Bunt  <richard.bunt@arm.com>
1688
1689         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1690         of depth when printing anonymous structs or unions.
1691         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1692         Don't print either the top-level value, or the children if the
1693         max-depth is exceeded.
1694         (ppscm_print_children): When printing the key of a map, allow one
1695         extra level of depth.
1696         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1697         print either the top-level value, or the children if the max-depth
1698         is exceeded.
1699         (print_children): When printing the key of a map, allow one extra
1700         level of depth.
1701         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1702         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1703         (user_print_options): Initialise max_depth field.
1704         (val_print_scalar_or_string_type_p): New function.
1705         (val_print): Check to see if the max depth has been reached.
1706         (val_print_check_max_depth): Define new function.
1707         (show_print_max_depth): New function.
1708         (_initialize_valprint): Add 'print max-depth' option.
1709         * valprint.h (struct value_print_options) <max_depth>: New field.
1710         (val_print_check_max_depth): Declare new function.
1711         * NEWS: Document new feature.
1712
1713 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1714
1715         * ada-lang.c (ada_language_defn): Initialise new field.
1716         * c-lang.c (c_is_string_type_p): New function.
1717         (c_language_defn): Initialise new field.
1718         (cplus_language_defn): Initialise new field.
1719         (asm_language_defn): Initialise new field.
1720         (minimal_language_defn): Initialise new field.
1721         * c-lang.h (c_is_string_type_p): Declare new function.
1722         * d-lang.c (d_language_defn): Initialise new field.
1723         * f-lang.c (f_is_string_type_p): New function.
1724         (f_language_defn): Initialise new field.
1725         * go-lang.c (go_is_string_type_p): New function.
1726         (go_language_defn): Initialise new field.
1727         * language.c (default_is_string_type_p): New function.
1728         (unknown_language_defn): Initialise new field.
1729         (auto_language_defn): Initialise new field.
1730         * language.h (struct language_defn) <la_is_string_type_p>: New
1731         member variable.
1732         (default_is_string_type_p): Declare new function.
1733         * m2-lang.c (m2_language_defn): Initialise new field.
1734         * objc-lang.c (objc_language_defn): Initialise new field.
1735         * opencl-lang.c (opencl_language_defn): Initialise new field.
1736         * p-lang.c (pascal_is_string_type_p): New function.
1737         (pascal_language_defn): Initialise new field.
1738         * rust-lang.c (rust_is_string_type_p): New function.
1739         (rust_language_defn): Initialise new field.
1740
1741 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1742
1743         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1744         New field.
1745         * ada-lang.c (ada_language_defn): Initialise new field.
1746         * c-lang.c (c_language_defn): Likewise.
1747         (cplus_language_defn): Likewise.
1748         (asm_language_defn): Likewise.
1749         (minimal_language_defn): Likewise.
1750         * d-lang.c (d_language_defn): Likewise.
1751         * f-lang.c (f_language_defn): Likewise.
1752         * go-lang.c (go_language_defn): Likewise.
1753         * language.c (unknown_language_defn): Likewise.
1754         (auto_language_defn): Likewise.
1755         * m2-lang.c (m2_language_defn): Likewise.
1756         * objc-lang.c (objc_language_defn): Likewise.
1757         * opencl-lang.c (opencl_language_defn): Likewise.
1758         * p-lang.c (pascal_language_defn): Likewise.
1759         * rust-lang.c (rust_language_defn): Likewise.
1760
1761 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1762
1763         * ada-lang.c (ada_is_character_type): Change return type to bool.
1764         (ada_is_string_type): Likewise.
1765         * ada-lang.h (ada_is_character_type): Update declaration
1766         (ada_is_string_type): Likewise.
1767
1768 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1769
1770         Support style in 'frame|thread apply'
1771
1772         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1773         * record.c (record_start, record_stop): Update callers of
1774         execute_command_to_string with false.
1775         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1776         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1777         methods.
1778         (class string_file): New constructor with term_out parameter.
1779         Override methods term_out and can_emit_style_escape.  New member
1780         term_out.
1781         (class stdio_file): Override can_emit_style_escape.
1782         (class tee_file): Override term_out and can_emit_style_escape.
1783         * utils.h (can_emit_style_escape): Remove.
1784         * utils.c (can_emit_style_escape): Likewise.
1785         Update all callers of can_emit_style_escape (SOMESTREAM) to
1786         SOMESTREAM->can_emit_style_escape.
1787         * source-cache.c (source_cache::get_source_lines): Likewise.
1788         * stack.c (frame_apply_command_count): Call execute_command_to_string
1789         passing the term_out characteristic of the current gdb_stdout.
1790         * thread.c (thr_try_catch_cmd): Likewise.
1791         * top.c (execute_command_to_string): pass term_out parameter
1792         to construct the string_file for the command output.
1793         * ui-file.c (term_cli_styling): New function (most code moved
1794         from utils.c can_emit_style_escape).
1795         (string_file::string_file, string_file::can_emit_style_escape,
1796         stdio_file::can_emit_style_escape, tee_file::term_out,
1797         tee_file::can_emit_style_escape): New functions.
1798
1799 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1800
1801         * NEWS: Mention the new set|show may-call-functions.
1802         * infcall.c (may_call_functions_p): New variable.
1803         (show_may_call_functions_p): New function.
1804         (call_function_by_hand_dummy): Throws an error if not
1805         may-call-functions.
1806         (_initialize_infcall): Call add_setshow_boolean_cmd for
1807         may-call-functions.
1808
1809 2019-04-25  Keith Seitz  <keiths@redhat.com>
1810
1811         PR c++/24367
1812         * cp-support.c (inspect_type): Don't attempt substitutions
1813         of symbol with the same name.
1814
1815 2019-04-25  Tom Tromey  <tromey@adacore.com>
1816
1817         PR gdb/24475:
1818         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1819         static.
1820
1821 2019-04-25  Tom Tromey  <tromey@adacore.com>
1822
1823         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1824         rvalue reference.
1825         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1826         (gdb_xml_parser::parse): Use std::move.
1827         * python/python-internal.h (gdbpy_convert_exception): Take a const
1828         reference.
1829         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1830         std::move.
1831         * python/py-utils.c (gdbpy_convert_exception): Take a const
1832         reference.
1833         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1834         Use std::move.
1835         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1836         Use std::move.
1837         * mi/mi-main.c (mi_print_exception): Take a const reference.
1838         * main.c (handle_command_errors): Take a const reference.
1839         * linespec.c (parse_linespec): Use std::move.
1840         * infcall.c (run_inferior_call): Use std::move.
1841         (call_function_by_hand_dummy): Use std::move.
1842         * exec.c (try_open_exec_file): Use std::move.
1843         * exceptions.h (exception_print, exception_fprintf)
1844         (exception_print_same): Update.
1845         * exceptions.c (print_exception, exception_print)
1846         (exception_fprintf, exception_print_same): Change parameters to
1847         const reference.
1848         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1849         * common/new-op.c: Use std::move.
1850         * common/common-exceptions.h (struct gdb_exception): Add move
1851         constructor.
1852         (struct gdb_exception_error, struct gdb_exception_quit, struct
1853         gdb_quit_bad_alloc): Change constructor to move constructor.
1854         (throw_exception): Change parameter to rvalue reference.
1855         * common/common-exceptions.c (throw_exception): Take rvalue
1856         reference.
1857         * cli/cli-interp.c (safe_execute_command): Use std::move.
1858         * breakpoint.c (insert_bp_location, location_to_sals): Use
1859         std::move.
1860
1861 2019-04-25  Tom Tromey  <tromey@adacore.com>
1862
1863         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1864         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1865         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1866         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1867         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1868         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1869         guile/scm-value.c: Use unpack.
1870         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1871         gdbscm_gdb_exception.
1872         (gdbscm_throw_gdb_exception): Likewise.
1873         (struct gdbscm_gdb_exception): New.
1874         (unpack): New function.
1875         (gdbscm_wrap): Use unpack.
1876
1877 2019-04-25  Tom Tromey  <tromey@adacore.com>
1878
1879         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1880         (gdb_rl_callback_handler): Use std::move.
1881         * common/common-exceptions.h (struct gdb_exception): Add move
1882         assignment operator.
1883         (throw_exception_sjlj): Change "exception" to const reference.
1884         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1885         (throw_exception_sjlj): Change "exception" to const reference.
1886
1887 2019-04-25  Tom Tromey  <tromey@adacore.com>
1888
1889         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1890         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1891         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1892         Update.
1893         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1894         Update.
1895         * mi/mi-interp.c (mi_interp::exec): Update.
1896         * linespec.c (parse_linespec): Update.
1897         * infcall.c (run_inferior_call): Update.
1898         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1899         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1900         (gdbscm_lookup_global_symbol): Update.
1901         * guile/scm-param.c (gdbscm_parameter_value): Update.
1902         * guile/scm-frame.c (gdbscm_frame_read_register)
1903         (gdbscm_frame_read_var): Update.
1904         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1905         * exec.c (try_open_exec_file): Update.
1906         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1907         (gdb_rl_callback_handler): Update.
1908         * common/common-exceptions.h (exception_none): Don't declare.
1909         * common/common-exceptions.c (exception_none): Don't define.
1910         (struct catcher) <exception>: Update.
1911         * cli/cli-interp.c (safe_execute_command): Update.
1912         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1913
1914 2019-04-25  Ali Tamur  <tamur@google.com>
1915
1916         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1917         (read_attribute_value): Likewise.
1918         (dwarf2_read_addr_index): Update comment.
1919         (read_str_index): Add DW_FORM_strx.
1920         (dwarf2_string_attr): Likewise.
1921         (dwarf2_const_value_attr): Likewise.
1922         (dump_die_shallow): Likewise.
1923         (dwarf2_fetch_constant_bytes): Likewise.
1924         (skip_form_bytes): Likewise.
1925         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1926
1927 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1928
1929         PR corefiles/11608
1930         PR corefiles/18187
1931         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1932         OFFSET.  Verify if current mapping contains an ELF header.
1933         (linux_find_memory_regions_full): Adjust call to
1934         dump_mapping_p.
1935
1936 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1937             Kang Li <kanglictf@gmail.com>
1938
1939         PR gdb/21600
1940
1941         * dwarf2-frame.c (read_initial_length): Be consistent about using
1942         unsigned representation of length.
1943         (decode_frame_entry_1): Likewise.  Check for wraparound of
1944         end pointer as well as buffer overflow.
1945
1946 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1947
1948         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1949         "vq".
1950
1951 2019-04-24  Tom Tromey  <tromey@adacore.com>
1952
1953         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1954
1955 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1956
1957         * s12z-tdep.c (s12z_unwind_pc): Delete.
1958         (s12z_unwind_sp): Delete.
1959         (s12z_gdbarch_init): Don't register deleted functions with
1960         gdbarch.
1961
1962 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1963
1964         * rl78-tdep.c (rl78_unwind_sp): Delete.
1965         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1966
1967 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1968
1969         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1970         (xstormy16_unwind_pc): Delete.
1971         (xstormy16_dummy_id): Delete.
1972         (xstormy16_gdbarch_init): Don't register deleted functions with
1973         gdbarch.
1974
1975 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1976
1977         * vax-tdep.c (vax_unwind_pc): Delete.
1978         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1979
1980 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1981
1982         * v850-tdep.c (v850_unwind_sp): Delete.
1983         (v850_unwind_pc): Delete.
1984         (v850_dummy_id): Delete.
1985         (v850_gdbarch_init): Don't register deleted functions with
1986         gdbarch.
1987
1988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1989
1990         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1991         (tilegx_unwind_pc): Delete.
1992         (tilegx_unwind_dummy_id): Delete.
1993         (tilegx_gdbarch_init): Don't register deleted functions with
1994         gdbarch.
1995
1996 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1997
1998         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1999         (tic6x_dummy_id): Delete.
2000         (tic6x_gdbarch_init): Don't register deleted functions with
2001         gdbarch.
2002
2003 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2004
2005         * sparc-tdep.c (sparc_unwind_pc): Delete.
2006         (sparc32_gdbarch_init): Don't register deleted function with
2007         gdbarch.
2008
2009 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2010
2011         * sh-tdep.c (sh_unwind_sp): Delete.
2012         (sh_unwind_pc): Delete.
2013         (sh_dummy_id): Delete.
2014         (sh_gdbarch_init): Don't register deleted functions with
2015         gdbarch.
2016
2017 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2018
2019         * score-tdep.c (score_unwind_sp): Delete.
2020         (score_unwind_pc): Delete.
2021         (score_dummy_id): Delete.
2022         (score_gdbarch_init): Don't register deleted functions with
2023         gdbarch.
2024
2025 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2026
2027         * rx-tdep.c (rx_unwind_pc): Delete.
2028         (rx_unwind_sp): Delete.
2029         (rx_dummy_id): Delete.
2030         (rx_gdbarch_init): Don't register deleted functions with
2031         gdbarch.  Update comment.
2032
2033 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2034
2035         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2036         (rs6000_dummy_id): Delete.
2037         (rs6000_gdbarch_init): Don't register deleted functions with
2038         gdbarch.
2039
2040 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2041
2042         * or1k-tdep.c (or1k_dummy_id): Delete.
2043         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2044
2045 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2046
2047         * nios2-tdep.c (nios2_dummy_id): Delete.
2048         (nios2_unwind_sp): Delete.
2049         (nios2_gdbarch_init): Don't register deleted functions with
2050         gdbarch.
2051
2052 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2053
2054         * nds32-tdep.c (nds32_dummy_id): Delete.
2055         (nds32_unwind_pc): Delete.
2056         (nds32_unwind_sp): Delete.
2057         (nds32_gdbarch_init): Don't register deleted functions with
2058         gdbarch.
2059
2060 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2061
2062         * msp430-tdep.c (msp430_unwind_pc): Delete.
2063         (msp430_unwind_sp): Delete.
2064         (msp430_dummy_id): Delete.
2065         (msp430_gdbarch_init): Don't register deleted functions with
2066         gdbarch.
2067
2068 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2069
2070         * moxie-tdep.c (moxie_unwind_sp): Delete.
2071         (moxie_unwind_pc): Delete.
2072         (moxie_dummy_id): Delete.
2073         (moxie_gdbarch_init): Don't register deleted functions with
2074         gdbarch.
2075
2076 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2077
2078         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2079         (mn10300_unwind_pc): Delete.
2080         (mn10300_unwind_sp): Delete.
2081         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2082         mn10300_unwind_sp.
2083         (mn10300_frame_unwind_init): Don't register deleted functions with
2084         gdbarch.
2085
2086 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2087
2088         * mep-tdep.c (mep_unwind_pc): Delete.
2089         (mep_unwind_sp): Delete.
2090         (mep_dummy_id): Delete.
2091         (mep_gdbarch_init): Don't register deleted functions with
2092         gdbarch.
2093
2094 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2095
2096         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2097         (m68hc11_unwind_sp): Delete.
2098         (m68hc11_gdbarch_init): Don't register deleted functions with
2099         gdbarch.
2100
2101 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2102
2103         * m32r-tdep.c (m32r_unwind_sp): Delete.
2104         (m32r_unwind_pc): Delete.
2105         (m32r_dummy_id): Delete.
2106         (m32r_gdbarch_init): Don't register deleted functions with
2107         gdbarch.
2108
2109 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2110
2111         * m32c-tdep.c (m32c_unwind_pc): Delete.
2112         (m32c_unwind_sp): Delete.
2113         (m32c_dummy_id): Delete.
2114         (m32c_gdbarch_init): Don't register deleted functions with
2115         gdbarch.
2116
2117 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2118
2119         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2120         (lm32_unwind_pc): Delete.
2121         (lm32_dummy_id): Delete.
2122         (lm32_gdbarch_init): Don't register deleted functions with
2123         gdbarch.
2124
2125 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2126
2127         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2128         (iq2000_unwind_pc): Delete.
2129         (iq2000_dummy_id): Delete.
2130         (iq2000_gdbarch_init): Don't register deleted functions with
2131         gdbarch.
2132
2133 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2134
2135         * nds32-tdep.c (nds32_type_align): Delete.
2136         (nds32_push_dummy_call): Use type_align instead.
2137
2138 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2139
2140         * arm-tdep.c (arm_type_align): Only handle vector override case.
2141         (arm_push_dummy_call): Use type_align.
2142         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2143
2144 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2145
2146         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2147         case.
2148         (pass_on_stack): Use type_align.
2149         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2150         function.
2151
2152 2019-04-23  Tom Tromey  <tromey@adacore.com>
2153
2154         * dwarf2read.c (line_header::file_name_at): Remove unused
2155         overload.
2156
2157 2019-04-23  Tom de Vries  <tdevries@suse.de>
2158
2159         PR gdb/24438
2160         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2161         invocation.
2162
2163
2164 2019-03-27  Ali Tamur  <tamur@google.com>
2165
2166         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2167         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2168         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2169         (dwarf_expr_context::get_addr_index): Likewise
2170         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2171         (symbol_needs_eval_context::get_addr_index): Likewise
2172         (disassemble_dwarf_expression): Add DW_OP_addrx
2173         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2174         (read_cutu_die_from_dwo): Update comment
2175         (skip_one_die): Add DW_FORM_addrx
2176         (read_attribute_value): Likewise
2177         (var_decode_location): Add DW_OP_addrx
2178         (dwarf2_const_value_attr): Add DW_FORM_addrx
2179         (dump_die_shallow): Likewise
2180         (dwarf2_fetch_constant_bytes): Likewise
2181         (decode_locdesc): Add DW_OP_addrx
2182         (skip_form_bytes): Add DW_FORM_addrx
2183
2184 2019-04-22  Ali Tamur  <tamur@google.com>
2185
2186         * MAINTAINERS (Write After Approval): Add self.
2187
2188 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2189
2190         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2191         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2192         (open_symbol_file_object): Likewise.
2193         (svr4_default_sos): Add info parameter.
2194         (svr4_read_so_list): Likewise.
2195         (svr4_current_sos_direct): Adjust functions calls to pass down
2196         info.
2197         (svr4_current_sos_1): Add info parameter.
2198         (svr4_current_sos): Call get_svr4_info, pass info down to
2199         svr4_current_sos_1.
2200         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2201         get_svr4_info.
2202         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2203         get_svr4_info.
2204         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2205         to get_svr4_info.
2206         (probes_table_remove_objfile_probes): Likewise.
2207         (register_solib_event_probe): Add info parameter.
2208         (solist_update_incremental): Pass info parameter down to
2209         svr4_read_so_list.
2210         (disable_probes_interface): Add info parameter.
2211         (svr4_handle_solib_event): Pass current_program_space to
2212         get_svr4_info.  Adjust disable_probes_interface cleanup.
2213         (svr4_create_probe_breakpoints): Add info parameter, pass it
2214         down to register_solib_event_probe.
2215         (svr4_create_solib_event_breakpoints): Add info parameter,
2216         pass it down to svr4_create_probe_breakpoints.
2217         (enable_break): Pass info down to
2218         svr4_create_solib_event_breakpoints.
2219         (svr4_solib_create_inferior_hook): Pass current_program_space to
2220         get_svr4_info.
2221         (svr4_clear_solib): Likewise.
2222
2223 2019-04-22  Pedro Alves  <palves@redhat.com>
2224
2225         * solib-svr4.c (svr4_free_objfile_observer): New.
2226         (probe_and_action::objfile): New field.
2227         (probes_table_htab_remove_objfile_probes)
2228         (probes_table_remove_objfile_probes): New functions.
2229         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2230         in the new probe_and_action.  Don't store the probe in 'lookup'.
2231         (svr4_create_probe_breakpoints): Pass objfile to
2232         register_solib_event_probe.
2233         (_initialize_svr4_solib): Register a free_objfile observer.
2234
2235 2019-04-19  Tom Tromey  <tom@tromey.com>
2236
2237         * common/queue.h: Remove.
2238
2239 2019-04-19  Tom Tromey  <tom@tromey.com>
2240
2241         * event-loop.c: Don't include "common/queue.h".
2242
2243 2019-04-19  Tom Tromey  <tom@tromey.com>
2244
2245         * remote.c (remote_target): Use delete.
2246         * remote-notif.h: Include <list>, not "common/queue.h".
2247         (notif_client_p): Remove typedef.
2248         (remote_notif_state): Add constructor, destructor, initializer.
2249         <notif_queue>: Now a std::list.
2250         (remote_notif_state_xfree): Don't declare.
2251         * remote-notif.c (remote_notif_process, handle_notification)
2252         (remote_notif_state_allocate): Update.
2253         (~remote_notif_state): Rename from remote_notif_state_xfree.
2254
2255 2019-04-19  Tom Tromey  <tom@tromey.com>
2256
2257         * symfile.c (reread_symbols): Update.
2258         * objfiles.c (objfile_register_static_link)
2259         (objfile_lookup_static_link): Update
2260         (~objfile) Don't delete static_links.
2261         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2262
2263 2019-04-19  Tom Tromey  <tom@tromey.com>
2264
2265         * type-stack.h (struct type_stack) <insert>: Constify string.
2266         * type-stack.c (type_stack::insert): Constify string.
2267         * gdbtypes.h (lookup_template_type): Update.
2268         (address_space_name_to_int): Update.
2269         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2270         const.
2271         (lookup_template_type): Make name const.
2272         * c-exp.y: Update rules.
2273         (lex_one_token, classify_name, classify_inner_name)
2274         (c_print_token): Update.
2275         * p-exp.y: Update rules.
2276         (yylex): Update.
2277         * f-exp.y: Update rules.
2278         (yylex): Update.
2279         * d-exp.y: Update rules.
2280         (lex_one_token, classify_name, classify_inner_name): Update.
2281         * parse.c (write_dollar_variable, copy_name): Return std::string.
2282         * parser-defs.h (copy_name): Change return type.
2283         * m2-exp.y: Update rules.
2284         (yylex): Update.
2285         * go-exp.y (lex_one_token): Update.
2286         Update rules.
2287         (classify_unsafe_function, classify_packaged_name)
2288         (classify_name, yylex): Update.
2289
2290 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2291
2292         * configure.ac: add --enable-source-highlight switch.
2293         * configure: Regenerate.
2294         * top.c (print_gdb_version): plumb --enable-source-highlight
2295         status to "show configuration".
2296
2297 2019-04-19  Tom Tromey  <tromey@adacore.com>
2298
2299         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2300         Check ADA_TYPE_P.
2301         (empty_record, ada_template_to_fixed_record_type_1)
2302         (template_to_static_fixed_type)
2303         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2304         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2305         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2306         macros.
2307
2308 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2309
2310         PR symtab/24423:
2311         * source.c (print_source_lines_base): Advance "iter" when a
2312         control character is seen.
2313
2314 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2315
2316         * inferior.h (struct infcall_suspend_state_deleter):
2317         Catch exception in destructor to avoid crash.
2318
2319 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2320
2321         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2322         close to the add_com "shell".
2323
2324 2019-04-18  Tom Tromey  <tromey@adacore.com>
2325
2326         * process-stratum-target.h (class process_stratum_target)
2327         <stratum>: Add "final".
2328
2329 2019-04-17  Tom Tromey  <tromey@adacore.com>
2330
2331         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2332         against nullptr before use.
2333
2334 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2335
2336         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2337
2338 2019-04-17  Jim Wilson  <jimw@sifive.com>
2339             Andrew Burgess  <andrew.burgess@embecosm.com>
2340
2341         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2342         code read might fail, assume 4-byte breakpoint in that case.
2343
2344 2019-04-15  Leszek Swirski  <leszeks@google.com>
2345
2346         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2347         rather than a hand-rolled POD check when checking for forced MEMORY
2348         classification.
2349
2350 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2351
2352         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2353         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2354         function.
2355         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2356         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2357         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2358         declaration.
2359
2360 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2361
2362         * aarch64-linux-nat.c
2363         (aarch64_linux_nat_target::thread_architecture): Add override.
2364         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2365         each VQ.
2366
2367 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2368
2369         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2370
2371 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2372
2373         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2374         target types of size 96-bits, add some additional comments, and
2375         check that the builtin type we found was the correct size.
2376
2377 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2378
2379         * utils.c (prompt_for_continue): Don't restore the styling at the
2380         end, as applied_style has the wrong value.  This fixes styling in
2381         long lists of file names that are interrupted by the "Continue?"
2382         prompt.
2383
2384 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2385
2386         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2387         * c-lang.c (c_language_defn): Likewise.
2388         (cplus_language_defn): Likewise.
2389         (asm_language_defn): Likewise.
2390         (minimal_language_defn): Likewise.
2391         * d-lang.c (d_language_defn): Likewise.
2392         * f-lang.c (f_language_defn): Likewise.
2393         * go-lang.c (go_language_defn): Likewise.
2394         * language.c (unknown_language_defn): Likewise.
2395         (auto_language_defn): Likewise.
2396         * language.h (struct language_defn): Remove la_magic field.
2397         (LANG_MAGIC): Delete.
2398         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2399         * objc-lang.c (objc_language_defn): Likewise.
2400         * opencl-lang.c (opencl_language_defn): Likewise.
2401         * p-lang.c (pascal_language_defn): Likewise.
2402         * rust-lang.c (rust_language_defn): Likewise.
2403
2404 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2405
2406         * riscv-tdep.c (riscv_type_align): New function.
2407         (riscv_type_alignment): Delete.
2408         (riscv_arg_location): Use 'type_align'.
2409         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2410
2411 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2412
2413         * gdbtypes.c (type_align): A struct with no non-static fields also
2414         has alignment of 1.
2415
2416 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2417
2418         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2419         component to 0.
2420         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2421         member.
2422         (riscv_struct_info::analyse): New implementation using new
2423         analyse_inner member function.
2424         (riscv_struct_info::field_offset): New member function.
2425         (riscv_struct_info::m_offsets): New member variable.
2426         (riscv_struct_info::analyse_inner): New private member function,
2427         takes the old implementation of riscv_struct_info::analyse but
2428         extended to track field offsets.
2429         (riscv_call_arg_struct): Update the struct folding special cases
2430         to handle cases where empty C++ structs, which are non-zero
2431         length, are found.
2432         (riscv_arg_location): Initialise the length of each location, a
2433         non-zero length now indicates the location is in use.
2434         (riscv_push_dummy_call): Allow for the first location having a
2435         non-zero offset when setting up arguments.
2436         (riscv_return_value): Likewise, but for return values.
2437
2438 2019-04-11  Tom Tromey  <tromey@adacore.com>
2439
2440         * utils.c (internal_vproblem): Make "msg" const.
2441
2442 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2443
2444         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2445         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2446         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2447         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2448
2449 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2450
2451         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2452         function.
2453         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2454         of amd64_collect_native_gregset.
2455         (amd64_linux_nat_target::store_registers): Likewise.
2456
2457 2019-04-10  Tom Tromey  <tom@tromey.com>
2458
2459         * symtab.c (lookup_global_symbol_from_objfile)
2460         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2461         * objfiles.h (class separate_debug_iterator): New.
2462         (class separate_debug_range): New.
2463         (struct objfile) <separate_debug_objfiles>: New method.
2464         (objfile_separate_debug_iterate): Don't declare.
2465         * objfiles.c (separate_debug_iterator::operator++): Rename from
2466         objfile_separate_debug_iterate.
2467         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2468         iterator.
2469         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2470         iterator.
2471
2472 2019-04-10  Tom Tromey  <tom@tromey.com>
2473
2474         * symfile.c (reread_symbols): Remove old comment.
2475         * objfiles.c (free_all_objfiles): Fix a typo.
2476
2477 2019-04-10  Tom Tromey  <tom@tromey.com>
2478
2479         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2480         * minsyms.c (lookup_minimal_symbol): Use foreach.
2481         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2482         (lookup_minimal_symbol_solib_trampoline): Likewise.
2483         * symfile.c (reread_symbols): Use foreach.
2484
2485 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2486             Tom Tromey  <tromey@adacore.com>
2487
2488         PR rust/24414:
2489         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2490         (rust_lex_int_test): Change "value" to be LONGEST.
2491         (rust_lex_tests): Add test for long integer literal.
2492
2493 2019-04-09  Tom Tromey  <tromey@adacore.com>
2494
2495         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2496         to bool.
2497         (extended_remote_target::attach): Update.
2498         (remote_target::remote_notice_new_inferior): Update.
2499         (remote_target::add_current_inferior_and_thread): Update.
2500         * inferior.c (exit_inferior_1): Use "false".
2501         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2502
2503 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2504
2505         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2506         the "start" command.
2507
2508 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2509
2510         * python/py-inferior.c (infpy_thread_from_thread_handle):
2511         Adjust comments to reflect renaming of thread_from_thread_handle
2512         to thread_from_handle.  Adjust keywords.  Fix type error message.
2513         (inferior_object_methods): Add thread_from_handle.  Retain
2514         thread_from_thread_handle, but mark it as deprecated.
2515
2516 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2517
2518         * gdbthread.h (find_thread_by_handle): Revise declaration.
2519         * thread.c (find_thread_by_handle): Likewise.  Adjust
2520         implementation too.
2521         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2522         support for buffer objects as handles.
2523
2524 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2525
2526         * python/py-infthread.c (thpy_thread_handle): New function.
2527         (thread_object_methods): Register thpy_thread_handle.
2528
2529 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2530
2531         * gdbthread.h (thread_to_thread_handle): Declare.
2532         * thread.c (gdbtypes.h): Include.
2533         (thread_to_thread_handle): New function.
2534
2535         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2536         (target_thread_info_to_thread_handle): Declare.
2537         * target.c (target_thread_info_to_thread_handle): New function.
2538         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2539         * target-delegates.c: Regenerate.
2540
2541         * linux-thread-db.c (class thread_db_target): Add method
2542         thread_info_to_thread_handle.
2543         (thread_db_target::thread_info_to_thread_handle): Define.
2544         * remote.c (class remote_target): Add new method
2545         thread_info_to_thread_handle.
2546         (remote_target::thread_info_to_thread_handle): Define.
2547
2548 2019-04-08  Pedro Alves  <palves@redhat.com>
2549
2550         * common/common-exceptions.c (throw_exception): Don't create
2551         named object to throw; throw directly.
2552         (throw_it): Likewise.  Don't initialize gdb_exception::message
2553         here, with new; pass FMT and AP to the ctor instead.
2554         * common/common-exceptions.h: Include <string>.
2555         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2556         const char *, va_list)): New ctor.  Use std::make_shared.
2557         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2558         errors)): Delete.
2559         (gdb_exception_error::gdb_exception_error(enum errors, const char
2560         *, va_list)): New.
2561         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2562         Add assertion.
2563         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2564         errors)): Delete.
2565         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2566         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2567         Add assertion.
2568
2569 2019-04-08  Tom Tromey  <tom@tromey.com>
2570
2571         * valops.c (value_rtti_indirect_type): Replace throw_exception
2572         with throw.
2573         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2574         with throw.
2575         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2576         throw.
2577         * target.c (target_translate_tls_address): Replace throw_exception
2578         with throw.
2579         * stack.c (frame_apply_command_count): Replace throw_exception
2580         with throw.
2581         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2582         throw.
2583         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2584         with throw.
2585         * rs6000-tdep.c (rs6000_frame_cache)
2586         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2587         * remote.c: Replace throw_exception with throw.
2588         * record-full.c (record_full_message, record_full_wait_1)
2589         (record_full_restore): Replace throw_exception with throw.
2590         * record-btrace.c:
2591         (get_thread_current_frame_id, record_btrace_start_replaying)
2592         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2593         (cmd_record_btrace_start): Replace throw_exception with throw.
2594         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2595         throw.
2596         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2597         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2598         * linespec.c:
2599         (find_linespec_symbols): Replace throw_exception with throw.
2600         * infrun.c (displaced_step_prepare, resume): Replace
2601         throw_exception with throw.
2602         * infcmd.c (post_create_inferior): Replace throw_exception with
2603         throw.
2604         * inf-loop.c (inferior_event_handler): Replace throw_exception
2605         with throw.
2606         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2607         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2608         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2609         (get_prev_frame_always, get_frame_pc_if_available)
2610         (get_frame_address_in_block_if_available, get_frame_language):
2611         Replace throw_exception with throw.
2612         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2613         throw_exception with throw.
2614         * eval.c (fetch_subexp_value, evaluate_var_value)
2615         (evaluate_funcall, evaluate_subexp_standard): Replace
2616         throw_exception with throw.
2617         * dwarf2loc.c (call_site_find_chain)
2618         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2619         Replace throw_exception with throw.
2620         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2621         with throw.
2622         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2623         throw.
2624         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2625         * completer.c (complete_line_internal): Replace throw_exception
2626         with throw.
2627         * compile/compile-object-run.c (compile_object_run): Replace
2628         throw_exception with throw.
2629         * cli/cli-script.c (process_next_line): Replace throw_exception
2630         with throw.
2631         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2632         (btrace_enable, btrace_maint_update_pt_packets): Replace
2633         throw_exception with throw.
2634         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2635         throw_exception with throw.
2636         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2637         throw_exception with throw.
2638         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2639         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2640         * aarch64-tdep.c (aarch64_make_prologue_cache)
2641         (aarch64_make_stub_cache): Replace throw_exception with throw.
2642
2643 2019-04-08  Tom Tromey  <tom@tromey.com>
2644
2645         * common/common-exceptions.c (throw_exception): Rename from
2646         throw_exception_cxx.  Remove old copy.  Make argument const.
2647         (throw_it): Create and throw exception objects directly.
2648         * common/common-exceptions.h (throw_exception): Make argument
2649         const.
2650         (struct gdb_exception_error): Add constructor.
2651         (struct gdb_exception_quit): Add constructor.
2652
2653 2019-04-08  Tom Tromey  <tom@tromey.com>
2654
2655         * common/common-exceptions.h (exception_rethrow): Don't declare.
2656         (TRY_SJLJ): Update comment.
2657         (TRY, CATCH, END_CATCH): Remove.
2658         * common/common-exceptions.c (exception_rethrow): Remove.
2659
2660 2019-04-08  Tom Tromey  <tom@tromey.com>
2661
2662         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2663         Remove.
2664         (gdb_exception_error): Rename from
2665         gdb_exception_RETURN_MASK_ERROR.
2666         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2667         (gdb_quit_bad_alloc): Update.
2668         * aarch64-tdep.c: Update.
2669         * ada-lang.c: Update.
2670         * ada-typeprint.c: Update.
2671         * ada-valprint.c: Update.
2672         * amd64-tdep.c: Update.
2673         * arch-utils.c: Update.
2674         * break-catch-throw.c: Update.
2675         * breakpoint.c: Update.
2676         * btrace.c: Update.
2677         * c-varobj.c: Update.
2678         * cli/cli-cmds.c: Update.
2679         * cli/cli-interp.c: Update.
2680         * cli/cli-script.c: Update.
2681         * common/common-exceptions.c: Update.
2682         * common/new-op.c: Update.
2683         * common/selftest.c: Update.
2684         * compile/compile-c-symbols.c: Update.
2685         * compile/compile-cplus-symbols.c: Update.
2686         * compile/compile-object-load.c: Update.
2687         * compile/compile-object-run.c: Update.
2688         * completer.c: Update.
2689         * corelow.c: Update.
2690         * cp-abi.c: Update.
2691         * cp-support.c: Update.
2692         * cp-valprint.c: Update.
2693         * darwin-nat.c: Update.
2694         * disasm-selftests.c: Update.
2695         * dtrace-probe.c: Update.
2696         * dwarf-index-cache.c: Update.
2697         * dwarf-index-write.c: Update.
2698         * dwarf2-frame-tailcall.c: Update.
2699         * dwarf2-frame.c: Update.
2700         * dwarf2loc.c: Update.
2701         * dwarf2read.c: Update.
2702         * eval.c: Update.
2703         * event-loop.c: Update.
2704         * event-top.c: Update.
2705         * exec.c: Update.
2706         * f-valprint.c: Update.
2707         * fbsd-tdep.c: Update.
2708         * frame-unwind.c: Update.
2709         * frame.c: Update.
2710         * gdbtypes.c: Update.
2711         * gnu-v3-abi.c: Update.
2712         * guile/guile-internal.h: Update.
2713         * guile/scm-block.c: Update.
2714         * guile/scm-breakpoint.c: Update.
2715         * guile/scm-cmd.c: Update.
2716         * guile/scm-disasm.c: Update.
2717         * guile/scm-frame.c: Update.
2718         * guile/scm-lazy-string.c: Update.
2719         * guile/scm-math.c: Update.
2720         * guile/scm-param.c: Update.
2721         * guile/scm-ports.c: Update.
2722         * guile/scm-pretty-print.c: Update.
2723         * guile/scm-symbol.c: Update.
2724         * guile/scm-symtab.c: Update.
2725         * guile/scm-type.c: Update.
2726         * guile/scm-value.c: Update.
2727         * i386-linux-tdep.c: Update.
2728         * i386-tdep.c: Update.
2729         * inf-loop.c: Update.
2730         * infcall.c: Update.
2731         * infcmd.c: Update.
2732         * infrun.c: Update.
2733         * jit.c: Update.
2734         * language.c: Update.
2735         * linespec.c: Update.
2736         * linux-fork.c: Update.
2737         * linux-nat.c: Update.
2738         * linux-tdep.c: Update.
2739         * linux-thread-db.c: Update.
2740         * main.c: Update.
2741         * mi/mi-cmd-break.c: Update.
2742         * mi/mi-cmd-stack.c: Update.
2743         * mi/mi-interp.c: Update.
2744         * mi/mi-main.c: Update.
2745         * objc-lang.c: Update.
2746         * p-valprint.c: Update.
2747         * parse.c: Update.
2748         * ppc-linux-tdep.c: Update.
2749         * printcmd.c: Update.
2750         * python/py-arch.c: Update.
2751         * python/py-breakpoint.c: Update.
2752         * python/py-cmd.c: Update.
2753         * python/py-finishbreakpoint.c: Update.
2754         * python/py-frame.c: Update.
2755         * python/py-framefilter.c: Update.
2756         * python/py-gdb-readline.c: Update.
2757         * python/py-inferior.c: Update.
2758         * python/py-infthread.c: Update.
2759         * python/py-lazy-string.c: Update.
2760         * python/py-linetable.c: Update.
2761         * python/py-objfile.c: Update.
2762         * python/py-param.c: Update.
2763         * python/py-prettyprint.c: Update.
2764         * python/py-progspace.c: Update.
2765         * python/py-record-btrace.c: Update.
2766         * python/py-record.c: Update.
2767         * python/py-symbol.c: Update.
2768         * python/py-type.c: Update.
2769         * python/py-unwind.c: Update.
2770         * python/py-utils.c: Update.
2771         * python/py-value.c: Update.
2772         * python/python.c: Update.
2773         * record-btrace.c: Update.
2774         * record-full.c: Update.
2775         * remote-fileio.c: Update.
2776         * remote.c: Update.
2777         * riscv-tdep.c: Update.
2778         * rs6000-aix-tdep.c: Update.
2779         * rs6000-tdep.c: Update.
2780         * rust-exp.y: Update.
2781         * rust-lang.c: Update.
2782         * s390-tdep.c: Update.
2783         * selftest-arch.c: Update.
2784         * solib-dsbt.c: Update.
2785         * solib-frv.c: Update.
2786         * solib-spu.c: Update.
2787         * solib-svr4.c: Update.
2788         * solib.c: Update.
2789         * sparc64-linux-tdep.c: Update.
2790         * stack.c: Update.
2791         * symfile-mem.c: Update.
2792         * symmisc.c: Update.
2793         * target.c: Update.
2794         * thread.c: Update.
2795         * top.c: Update.
2796         * tracefile-tfile.c: Update.
2797         * tui/tui.c: Update.
2798         * typeprint.c: Update.
2799         * unittests/cli-utils-selftests.c: Update.
2800         * unittests/parse-connection-spec-selftests.c: Update.
2801         * valops.c: Update.
2802         * valprint.c: Update.
2803         * value.c: Update.
2804         * varobj.c: Update.
2805         * windows-nat.c: Update.
2806         * x86-linux-nat.c: Update.
2807         * xml-support.c: Update.
2808
2809 2019-04-08  Tom Tromey  <tom@tromey.com>
2810
2811         * xml-support.c: Use C++ exception handling.
2812         * x86-linux-nat.c: Use C++ exception handling.
2813         * windows-nat.c: Use C++ exception handling.
2814         * varobj.c: Use C++ exception handling.
2815         * value.c: Use C++ exception handling.
2816         * valprint.c: Use C++ exception handling.
2817         * valops.c: Use C++ exception handling.
2818         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2819         handling.
2820         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2821         * typeprint.c: Use C++ exception handling.
2822         * tui/tui.c: Use C++ exception handling.
2823         * tracefile-tfile.c: Use C++ exception handling.
2824         * top.c: Use C++ exception handling.
2825         * thread.c: Use C++ exception handling.
2826         * target.c: Use C++ exception handling.
2827         * symmisc.c: Use C++ exception handling.
2828         * symfile-mem.c: Use C++ exception handling.
2829         * stack.c: Use C++ exception handling.
2830         * sparc64-linux-tdep.c: Use C++ exception handling.
2831         * solib.c: Use C++ exception handling.
2832         * solib-svr4.c: Use C++ exception handling.
2833         * solib-spu.c: Use C++ exception handling.
2834         * solib-frv.c: Use C++ exception handling.
2835         * solib-dsbt.c: Use C++ exception handling.
2836         * selftest-arch.c: Use C++ exception handling.
2837         * s390-tdep.c: Use C++ exception handling.
2838         * rust-lang.c: Use C++ exception handling.
2839         * rust-exp.y: Use C++ exception handling.
2840         * rs6000-tdep.c: Use C++ exception handling.
2841         * rs6000-aix-tdep.c: Use C++ exception handling.
2842         * riscv-tdep.c: Use C++ exception handling.
2843         * remote.c: Use C++ exception handling.
2844         * remote-fileio.c: Use C++ exception handling.
2845         * record-full.c: Use C++ exception handling.
2846         * record-btrace.c: Use C++ exception handling.
2847         * python/python.c: Use C++ exception handling.
2848         * python/py-value.c: Use C++ exception handling.
2849         * python/py-utils.c: Use C++ exception handling.
2850         * python/py-unwind.c: Use C++ exception handling.
2851         * python/py-type.c: Use C++ exception handling.
2852         * python/py-symbol.c: Use C++ exception handling.
2853         * python/py-record.c: Use C++ exception handling.
2854         * python/py-record-btrace.c: Use C++ exception handling.
2855         * python/py-progspace.c: Use C++ exception handling.
2856         * python/py-prettyprint.c: Use C++ exception handling.
2857         * python/py-param.c: Use C++ exception handling.
2858         * python/py-objfile.c: Use C++ exception handling.
2859         * python/py-linetable.c: Use C++ exception handling.
2860         * python/py-lazy-string.c: Use C++ exception handling.
2861         * python/py-infthread.c: Use C++ exception handling.
2862         * python/py-inferior.c: Use C++ exception handling.
2863         * python/py-gdb-readline.c: Use C++ exception handling.
2864         * python/py-framefilter.c: Use C++ exception handling.
2865         * python/py-frame.c: Use C++ exception handling.
2866         * python/py-finishbreakpoint.c: Use C++ exception handling.
2867         * python/py-cmd.c: Use C++ exception handling.
2868         * python/py-breakpoint.c: Use C++ exception handling.
2869         * python/py-arch.c: Use C++ exception handling.
2870         * printcmd.c: Use C++ exception handling.
2871         * ppc-linux-tdep.c: Use C++ exception handling.
2872         * parse.c: Use C++ exception handling.
2873         * p-valprint.c: Use C++ exception handling.
2874         * objc-lang.c: Use C++ exception handling.
2875         * mi/mi-main.c: Use C++ exception handling.
2876         * mi/mi-interp.c: Use C++ exception handling.
2877         * mi/mi-cmd-stack.c: Use C++ exception handling.
2878         * mi/mi-cmd-break.c: Use C++ exception handling.
2879         * main.c: Use C++ exception handling.
2880         * linux-thread-db.c: Use C++ exception handling.
2881         * linux-tdep.c: Use C++ exception handling.
2882         * linux-nat.c: Use C++ exception handling.
2883         * linux-fork.c: Use C++ exception handling.
2884         * linespec.c: Use C++ exception handling.
2885         * language.c: Use C++ exception handling.
2886         * jit.c: Use C++ exception handling.
2887         * infrun.c: Use C++ exception handling.
2888         * infcmd.c: Use C++ exception handling.
2889         * infcall.c: Use C++ exception handling.
2890         * inf-loop.c: Use C++ exception handling.
2891         * i386-tdep.c: Use C++ exception handling.
2892         * i386-linux-tdep.c: Use C++ exception handling.
2893         * guile/scm-value.c: Use C++ exception handling.
2894         * guile/scm-type.c: Use C++ exception handling.
2895         * guile/scm-symtab.c: Use C++ exception handling.
2896         * guile/scm-symbol.c: Use C++ exception handling.
2897         * guile/scm-pretty-print.c: Use C++ exception handling.
2898         * guile/scm-ports.c: Use C++ exception handling.
2899         * guile/scm-param.c: Use C++ exception handling.
2900         * guile/scm-math.c: Use C++ exception handling.
2901         * guile/scm-lazy-string.c: Use C++ exception handling.
2902         * guile/scm-frame.c: Use C++ exception handling.
2903         * guile/scm-disasm.c: Use C++ exception handling.
2904         * guile/scm-cmd.c: Use C++ exception handling.
2905         * guile/scm-breakpoint.c: Use C++ exception handling.
2906         * guile/scm-block.c: Use C++ exception handling.
2907         * guile/guile-internal.h: Use C++ exception handling.
2908         * gnu-v3-abi.c: Use C++ exception handling.
2909         * gdbtypes.c: Use C++ exception handling.
2910         * frame.c: Use C++ exception handling.
2911         * frame-unwind.c: Use C++ exception handling.
2912         * fbsd-tdep.c: Use C++ exception handling.
2913         * f-valprint.c: Use C++ exception handling.
2914         * exec.c: Use C++ exception handling.
2915         * event-top.c: Use C++ exception handling.
2916         * event-loop.c: Use C++ exception handling.
2917         * eval.c: Use C++ exception handling.
2918         * dwarf2read.c: Use C++ exception handling.
2919         * dwarf2loc.c: Use C++ exception handling.
2920         * dwarf2-frame.c: Use C++ exception handling.
2921         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2922         * dwarf-index-write.c: Use C++ exception handling.
2923         * dwarf-index-cache.c: Use C++ exception handling.
2924         * dtrace-probe.c: Use C++ exception handling.
2925         * disasm-selftests.c: Use C++ exception handling.
2926         * darwin-nat.c: Use C++ exception handling.
2927         * cp-valprint.c: Use C++ exception handling.
2928         * cp-support.c: Use C++ exception handling.
2929         * cp-abi.c: Use C++ exception handling.
2930         * corelow.c: Use C++ exception handling.
2931         * completer.c: Use C++ exception handling.
2932         * compile/compile-object-run.c: Use C++ exception handling.
2933         * compile/compile-object-load.c: Use C++ exception handling.
2934         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2935         * compile/compile-c-symbols.c: Use C++ exception handling.
2936         * common/selftest.c: Use C++ exception handling.
2937         * common/new-op.c: Use C++ exception handling.
2938         * cli/cli-script.c: Use C++ exception handling.
2939         * cli/cli-interp.c: Use C++ exception handling.
2940         * cli/cli-cmds.c: Use C++ exception handling.
2941         * c-varobj.c: Use C++ exception handling.
2942         * btrace.c: Use C++ exception handling.
2943         * breakpoint.c: Use C++ exception handling.
2944         * break-catch-throw.c: Use C++ exception handling.
2945         * arch-utils.c: Use C++ exception handling.
2946         * amd64-tdep.c: Use C++ exception handling.
2947         * ada-valprint.c: Use C++ exception handling.
2948         * ada-typeprint.c: Use C++ exception handling.
2949         * ada-lang.c: Use C++ exception handling.
2950         * aarch64-tdep.c: Use C++ exception handling.
2951
2952 2019-04-08  Tom Tromey  <tom@tromey.com>
2953
2954         * xml-support.c (gdb_xml_parser::parse): Update.
2955         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2956         * value.c (show_convenience): Update.
2957         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2958         (test_parse_flags_qcs): Update.
2959         * thread.c (thr_try_catch_cmd): Update.
2960         * target.c (target_translate_tls_address): Update.
2961         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2962         (info_frame_command_core, frame_apply_command_count): Update.
2963         * rust-exp.y (rust_lex_exception_test): Update.
2964         * riscv-tdep.c (riscv_print_one_register_info): Update.
2965         * remote.c (remote_target::enable_btrace): Update.
2966         * record-btrace.c (record_btrace_enable_warn): Update.
2967         * python/py-utils.c (gdbpy_convert_exception): Update.
2968         * printcmd.c (do_one_display, print_variable_and_value): Update.
2969         * mi/mi-main.c (mi_print_exception): Update.
2970         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2971         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2972         * linux-nat.c (linux_nat_target::attach): Update.
2973         * linux-fork.c (class scoped_switch_fork_info): Update.
2974         * infrun.c (displaced_step_prepare): Update.
2975         * infcall.c (call_function_by_hand_dummy): Update.
2976         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2977         * gnu-v3-abi.c (print_one_vtable): Update.
2978         * frame.c (get_prev_frame_always): Update.
2979         * f-valprint.c (info_common_command_for_block): Update.
2980         * exec.c (try_open_exec_file): Update.
2981         * exceptions.c (print_exception, exception_print)
2982         (exception_fprintf, exception_print_same): Update.
2983         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2984         * dwarf-index-cache.c (index_cache::store)
2985         (index_cache::lookup_gdb_index): Update.
2986         * darwin-nat.c (maybe_cache_shell): Update.
2987         * cp-valprint.c (cp_print_value_fields): Update.
2988         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2989         (gcc_cplus_symbol_address): Update.
2990         * compile/compile-c-symbols.c (gcc_convert_symbol)
2991         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2992         * common/selftest.c: Update.
2993         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2994         a std::string.
2995         (exception_try_scope_entry, exception_try_scope_exit): Don't
2996         declare.
2997         (struct exception_try_scope): Remove.
2998         (TRY): Don't use exception_try_scope.
2999         (struct gdb_exception): Add constructor, operator=.
3000         <what>: New method.
3001         (struct gdb_exception_RETURN_MASK_ALL)
3002         (struct gdb_exception_RETURN_MASK_ERROR)
3003         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3004         (struct gdb_quit_bad_alloc): Update.
3005         * common/common-exceptions.c (exception_none): Change
3006         initializer.
3007         (struct catcher) <state, exception>: Initialize inline.
3008         <prev>: Remove member.
3009         (current_catcher): Remove.
3010         (catchers): New global.
3011         (exceptions_state_mc_init): Simplify.
3012         (catcher_pop): Remove.
3013         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3014         (try_scope_depth, exception_try_scope_entry)
3015         (exception_try_scope_exit): Remove.
3016         (throw_exception_sjlj): Update.
3017         (exception_messages, exception_messages_size): Remove.
3018         (throw_it): Simplify.
3019         (gdb_exception_sliced_copy): Remove.
3020         (throw_exception_cxx): Update.
3021         * cli/cli-script.c (script_from_file): Update.
3022         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3023         Update.
3024         * ada-valprint.c (ada_val_print): Update.
3025         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3026         (create_excep_cond_exprs): Update.
3027
3028 2019-04-08  Tom Tromey  <tom@tromey.com>
3029
3030         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3031         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3032         (TRY, CATCH, END_CATCH): Remove some definitions.
3033         * common/common-exceptions.c: Don't use GDB_XCPT.
3034         (catcher_list_size): Remove.
3035         (throw_exception, throw_it): Simplify.
3036
3037 2019-04-05  Tom Tromey  <tom@tromey.com>
3038
3039         Revert the header-sorting patch.
3040         * ft32-tdep.c: Revert.
3041         * frv-tdep.c: Revert.
3042         * frv-linux-tdep.c: Revert.
3043         * frame.c: Revert.
3044         * frame-unwind.c: Revert.
3045         * frame-base.c: Revert.
3046         * fork-child.c: Revert.
3047         * findvar.c: Revert.
3048         * findcmd.c: Revert.
3049         * filesystem.c: Revert.
3050         * filename-seen-cache.h: Revert.
3051         * filename-seen-cache.c: Revert.
3052         * fbsd-tdep.c: Revert.
3053         * fbsd-nat.h: Revert.
3054         * fbsd-nat.c: Revert.
3055         * f-valprint.c: Revert.
3056         * f-typeprint.c: Revert.
3057         * f-lang.c: Revert.
3058         * extension.h: Revert.
3059         * extension.c: Revert.
3060         * extension-priv.h: Revert.
3061         * expprint.c: Revert.
3062         * exec.h: Revert.
3063         * exec.c: Revert.
3064         * exceptions.c: Revert.
3065         * event-top.c: Revert.
3066         * event-loop.c: Revert.
3067         * eval.c: Revert.
3068         * elfread.c: Revert.
3069         * dwarf2read.h: Revert.
3070         * dwarf2read.c: Revert.
3071         * dwarf2loc.c: Revert.
3072         * dwarf2expr.h: Revert.
3073         * dwarf2expr.c: Revert.
3074         * dwarf2-frame.c: Revert.
3075         * dwarf2-frame-tailcall.c: Revert.
3076         * dwarf-index-write.h: Revert.
3077         * dwarf-index-write.c: Revert.
3078         * dwarf-index-common.c: Revert.
3079         * dwarf-index-cache.h: Revert.
3080         * dwarf-index-cache.c: Revert.
3081         * dummy-frame.c: Revert.
3082         * dtrace-probe.c: Revert.
3083         * disasm.h: Revert.
3084         * disasm.c: Revert.
3085         * disasm-selftests.c: Revert.
3086         * dictionary.c: Revert.
3087         * dicos-tdep.c: Revert.
3088         * demangle.c: Revert.
3089         * dcache.h: Revert.
3090         * dcache.c: Revert.
3091         * darwin-nat.h: Revert.
3092         * darwin-nat.c: Revert.
3093         * darwin-nat-info.c: Revert.
3094         * d-valprint.c: Revert.
3095         * d-namespace.c: Revert.
3096         * d-lang.c: Revert.
3097         * ctf.c: Revert.
3098         * csky-tdep.c: Revert.
3099         * csky-linux-tdep.c: Revert.
3100         * cris-tdep.c: Revert.
3101         * cris-linux-tdep.c: Revert.
3102         * cp-valprint.c: Revert.
3103         * cp-support.c: Revert.
3104         * cp-namespace.c: Revert.
3105         * cp-abi.c: Revert.
3106         * corelow.c: Revert.
3107         * corefile.c: Revert.
3108         * continuations.c: Revert.
3109         * completer.h: Revert.
3110         * completer.c: Revert.
3111         * complaints.c: Revert.
3112         * coffread.c: Revert.
3113         * coff-pe-read.c: Revert.
3114         * cli-out.h: Revert.
3115         * cli-out.c: Revert.
3116         * charset.c: Revert.
3117         * c-varobj.c: Revert.
3118         * c-valprint.c: Revert.
3119         * c-typeprint.c: Revert.
3120         * c-lang.c: Revert.
3121         * buildsym.c: Revert.
3122         * buildsym-legacy.c: Revert.
3123         * build-id.h: Revert.
3124         * build-id.c: Revert.
3125         * btrace.c: Revert.
3126         * bsd-uthread.c: Revert.
3127         * breakpoint.h: Revert.
3128         * breakpoint.c: Revert.
3129         * break-catch-throw.c: Revert.
3130         * break-catch-syscall.c: Revert.
3131         * break-catch-sig.c: Revert.
3132         * blockframe.c: Revert.
3133         * block.c: Revert.
3134         * bfin-tdep.c: Revert.
3135         * bfin-linux-tdep.c: Revert.
3136         * bfd-target.c: Revert.
3137         * bcache.c: Revert.
3138         * ax-general.c: Revert.
3139         * ax-gdb.h: Revert.
3140         * ax-gdb.c: Revert.
3141         * avr-tdep.c: Revert.
3142         * auxv.c: Revert.
3143         * auto-load.c: Revert.
3144         * arm-wince-tdep.c: Revert.
3145         * arm-tdep.c: Revert.
3146         * arm-symbian-tdep.c: Revert.
3147         * arm-pikeos-tdep.c: Revert.
3148         * arm-obsd-tdep.c: Revert.
3149         * arm-nbsd-tdep.c: Revert.
3150         * arm-nbsd-nat.c: Revert.
3151         * arm-linux-tdep.c: Revert.
3152         * arm-linux-nat.c: Revert.
3153         * arm-fbsd-tdep.c: Revert.
3154         * arm-fbsd-nat.c: Revert.
3155         * arm-bsd-tdep.c: Revert.
3156         * arch-utils.c: Revert.
3157         * arc-tdep.c: Revert.
3158         * arc-newlib-tdep.c: Revert.
3159         * annotate.h: Revert.
3160         * annotate.c: Revert.
3161         * amd64-windows-tdep.c: Revert.
3162         * amd64-windows-nat.c: Revert.
3163         * amd64-tdep.c: Revert.
3164         * amd64-sol2-tdep.c: Revert.
3165         * amd64-obsd-tdep.c: Revert.
3166         * amd64-obsd-nat.c: Revert.
3167         * amd64-nbsd-tdep.c: Revert.
3168         * amd64-nbsd-nat.c: Revert.
3169         * amd64-nat.c: Revert.
3170         * amd64-linux-tdep.c: Revert.
3171         * amd64-linux-nat.c: Revert.
3172         * amd64-fbsd-tdep.c: Revert.
3173         * amd64-fbsd-nat.c: Revert.
3174         * amd64-dicos-tdep.c: Revert.
3175         * amd64-darwin-tdep.c: Revert.
3176         * amd64-bsd-nat.c: Revert.
3177         * alpha-tdep.c: Revert.
3178         * alpha-obsd-tdep.c: Revert.
3179         * alpha-nbsd-tdep.c: Revert.
3180         * alpha-mdebug-tdep.c: Revert.
3181         * alpha-linux-tdep.c: Revert.
3182         * alpha-linux-nat.c: Revert.
3183         * alpha-bsd-tdep.c: Revert.
3184         * alpha-bsd-nat.c: Revert.
3185         * aix-thread.c: Revert.
3186         * agent.c: Revert.
3187         * addrmap.c: Revert.
3188         * ada-varobj.c: Revert.
3189         * ada-valprint.c: Revert.
3190         * ada-typeprint.c: Revert.
3191         * ada-tasks.c: Revert.
3192         * ada-lang.c: Revert.
3193         * aarch64-tdep.c: Revert.
3194         * aarch64-ravenscar-thread.c: Revert.
3195         * aarch64-newlib-tdep.c: Revert.
3196         * aarch64-linux-tdep.c: Revert.
3197         * aarch64-linux-nat.c: Revert.
3198         * aarch64-fbsd-tdep.c: Revert.
3199         * aarch64-fbsd-nat.c: Revert.
3200         * aarch32-linux-nat.c: Revert.
3201
3202 2019-04-05  Tom Tromey  <tom@tromey.com>
3203
3204         * ft32-tdep.c: Sort headers.
3205         * frv-tdep.c: Sort headers.
3206         * frv-linux-tdep.c: Sort headers.
3207         * frame.c: Sort headers.
3208         * frame-unwind.c: Sort headers.
3209         * frame-base.c: Sort headers.
3210         * fork-child.c: Sort headers.
3211         * findvar.c: Sort headers.
3212         * findcmd.c: Sort headers.
3213         * filesystem.c: Sort headers.
3214         * filename-seen-cache.h: Sort headers.
3215         * filename-seen-cache.c: Sort headers.
3216         * fbsd-tdep.c: Sort headers.
3217         * fbsd-nat.h: Sort headers.
3218         * fbsd-nat.c: Sort headers.
3219         * f-valprint.c: Sort headers.
3220         * f-typeprint.c: Sort headers.
3221         * f-lang.c: Sort headers.
3222         * extension.h: Sort headers.
3223         * extension.c: Sort headers.
3224         * extension-priv.h: Sort headers.
3225         * expprint.c: Sort headers.
3226         * exec.h: Sort headers.
3227         * exec.c: Sort headers.
3228         * exceptions.c: Sort headers.
3229         * event-top.c: Sort headers.
3230         * event-loop.c: Sort headers.
3231         * eval.c: Sort headers.
3232         * elfread.c: Sort headers.
3233         * dwarf2read.h: Sort headers.
3234         * dwarf2read.c: Sort headers.
3235         * dwarf2loc.c: Sort headers.
3236         * dwarf2expr.h: Sort headers.
3237         * dwarf2expr.c: Sort headers.
3238         * dwarf2-frame.c: Sort headers.
3239         * dwarf2-frame-tailcall.c: Sort headers.
3240         * dwarf-index-write.h: Sort headers.
3241         * dwarf-index-write.c: Sort headers.
3242         * dwarf-index-common.c: Sort headers.
3243         * dwarf-index-cache.h: Sort headers.
3244         * dwarf-index-cache.c: Sort headers.
3245         * dummy-frame.c: Sort headers.
3246         * dtrace-probe.c: Sort headers.
3247         * disasm.h: Sort headers.
3248         * disasm.c: Sort headers.
3249         * disasm-selftests.c: Sort headers.
3250         * dictionary.c: Sort headers.
3251         * dicos-tdep.c: Sort headers.
3252         * demangle.c: Sort headers.
3253         * dcache.h: Sort headers.
3254         * dcache.c: Sort headers.
3255         * darwin-nat.h: Sort headers.
3256         * darwin-nat.c: Sort headers.
3257         * darwin-nat-info.c: Sort headers.
3258         * d-valprint.c: Sort headers.
3259         * d-namespace.c: Sort headers.
3260         * d-lang.c: Sort headers.
3261         * ctf.c: Sort headers.
3262         * csky-tdep.c: Sort headers.
3263         * csky-linux-tdep.c: Sort headers.
3264         * cris-tdep.c: Sort headers.
3265         * cris-linux-tdep.c: Sort headers.
3266         * cp-valprint.c: Sort headers.
3267         * cp-support.c: Sort headers.
3268         * cp-namespace.c: Sort headers.
3269         * cp-abi.c: Sort headers.
3270         * corelow.c: Sort headers.
3271         * corefile.c: Sort headers.
3272         * continuations.c: Sort headers.
3273         * completer.h: Sort headers.
3274         * completer.c: Sort headers.
3275         * complaints.c: Sort headers.
3276         * coffread.c: Sort headers.
3277         * coff-pe-read.c: Sort headers.
3278         * cli-out.h: Sort headers.
3279         * cli-out.c: Sort headers.
3280         * charset.c: Sort headers.
3281         * c-varobj.c: Sort headers.
3282         * c-valprint.c: Sort headers.
3283         * c-typeprint.c: Sort headers.
3284         * c-lang.c: Sort headers.
3285         * buildsym.c: Sort headers.
3286         * buildsym-legacy.c: Sort headers.
3287         * build-id.h: Sort headers.
3288         * build-id.c: Sort headers.
3289         * btrace.c: Sort headers.
3290         * bsd-uthread.c: Sort headers.
3291         * breakpoint.h: Sort headers.
3292         * breakpoint.c: Sort headers.
3293         * break-catch-throw.c: Sort headers.
3294         * break-catch-syscall.c: Sort headers.
3295         * break-catch-sig.c: Sort headers.
3296         * blockframe.c: Sort headers.
3297         * block.c: Sort headers.
3298         * bfin-tdep.c: Sort headers.
3299         * bfin-linux-tdep.c: Sort headers.
3300         * bfd-target.c: Sort headers.
3301         * bcache.c: Sort headers.
3302         * ax-general.c: Sort headers.
3303         * ax-gdb.h: Sort headers.
3304         * ax-gdb.c: Sort headers.
3305         * avr-tdep.c: Sort headers.
3306         * auxv.c: Sort headers.
3307         * auto-load.c: Sort headers.
3308         * arm-wince-tdep.c: Sort headers.
3309         * arm-tdep.c: Sort headers.
3310         * arm-symbian-tdep.c: Sort headers.
3311         * arm-pikeos-tdep.c: Sort headers.
3312         * arm-obsd-tdep.c: Sort headers.
3313         * arm-nbsd-tdep.c: Sort headers.
3314         * arm-nbsd-nat.c: Sort headers.
3315         * arm-linux-tdep.c: Sort headers.
3316         * arm-linux-nat.c: Sort headers.
3317         * arm-fbsd-tdep.c: Sort headers.
3318         * arm-fbsd-nat.c: Sort headers.
3319         * arm-bsd-tdep.c: Sort headers.
3320         * arch-utils.c: Sort headers.
3321         * arc-tdep.c: Sort headers.
3322         * arc-newlib-tdep.c: Sort headers.
3323         * annotate.h: Sort headers.
3324         * annotate.c: Sort headers.
3325         * amd64-windows-tdep.c: Sort headers.
3326         * amd64-windows-nat.c: Sort headers.
3327         * amd64-tdep.c: Sort headers.
3328         * amd64-sol2-tdep.c: Sort headers.
3329         * amd64-obsd-tdep.c: Sort headers.
3330         * amd64-obsd-nat.c: Sort headers.
3331         * amd64-nbsd-tdep.c: Sort headers.
3332         * amd64-nbsd-nat.c: Sort headers.
3333         * amd64-nat.c: Sort headers.
3334         * amd64-linux-tdep.c: Sort headers.
3335         * amd64-linux-nat.c: Sort headers.
3336         * amd64-fbsd-tdep.c: Sort headers.
3337         * amd64-fbsd-nat.c: Sort headers.
3338         * amd64-dicos-tdep.c: Sort headers.
3339         * amd64-darwin-tdep.c: Sort headers.
3340         * amd64-bsd-nat.c: Sort headers.
3341         * alpha-tdep.c: Sort headers.
3342         * alpha-obsd-tdep.c: Sort headers.
3343         * alpha-nbsd-tdep.c: Sort headers.
3344         * alpha-mdebug-tdep.c: Sort headers.
3345         * alpha-linux-tdep.c: Sort headers.
3346         * alpha-linux-nat.c: Sort headers.
3347         * alpha-bsd-tdep.c: Sort headers.
3348         * alpha-bsd-nat.c: Sort headers.
3349         * aix-thread.c: Sort headers.
3350         * agent.c: Sort headers.
3351         * addrmap.c: Sort headers.
3352         * ada-varobj.c: Sort headers.
3353         * ada-valprint.c: Sort headers.
3354         * ada-typeprint.c: Sort headers.
3355         * ada-tasks.c: Sort headers.
3356         * ada-lang.c: Sort headers.
3357         * aarch64-tdep.c: Sort headers.
3358         * aarch64-ravenscar-thread.c: Sort headers.
3359         * aarch64-newlib-tdep.c: Sort headers.
3360         * aarch64-linux-tdep.c: Sort headers.
3361         * aarch64-linux-nat.c: Sort headers.
3362         * aarch64-fbsd-tdep.c: Sort headers.
3363         * aarch64-fbsd-nat.c: Sort headers.
3364         * aarch32-linux-nat.c: Sort headers.
3365
3366 2019-04-04  Tom Tromey  <tom@tromey.com>
3367
3368         * varobj.c (varobj_create): Update.
3369         * rust-exp.y (struct rust_parser) <update_innermost_block,
3370         lookup_symbol>: New methods.
3371         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3372         Rename.
3373         (rust_parser::rust_lookup_type)
3374         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3375         * printcmd.c (display_command, do_one_display): Update.
3376         * parser-defs.h (struct parser_state) <parser_state>: Add
3377         "tracker" parameter.
3378         (block_tracker): New member.
3379         (class innermost_block_tracker) <innermost_block_tracker>: Add
3380         "types" parameter.
3381         <reset>: Remove method.
3382         (innermost_block): Don't declare.
3383         (null_post_parser): Update.
3384         * parse.c (innermost_block): Remove global.
3385         (write_dollar_variable): Update.
3386         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3387         Remove "tracker_types" parameter.
3388         (parse_expression): Add "tracker" parameter.
3389         (parse_expression_for_completion): Update.
3390         (null_post_parser): Add "tracker" parameter.
3391         * p-exp.y: Update rules.
3392         * m2-exp.y: Update rules.
3393         * language.h (struct language_defn) <la_post_parser>: Add
3394         "tracker" parameter.
3395         * go-exp.y: Update rules.
3396         * f-exp.y: Update rules.
3397         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3398         parameter.
3399         * d-exp.y: Update rules.
3400         * c-exp.y: Update rules.
3401         * breakpoint.c (set_breakpoint_condition): Create an
3402         innermost_block_tracker.
3403         (watch_command_1): Likewise.
3404         * ada-lang.c (resolve): Add "tracker" parameter.
3405         (resolve_subexp): Likewise.
3406         * ada-exp.y (write_var_from_sym): Update.
3407
3408 2019-04-04  Tom Tromey  <tom@tromey.com>
3409
3410         * type-stack.h: New file.
3411         * type-stack.c: New file.
3412         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3413         type-stack.h.
3414         (insert_into_type_stack, insert_type, push_type, push_type_int)
3415         (insert_type_address_space, pop_type, pop_type_int)
3416         (pop_typelist, pop_type_stack, append_type_stack)
3417         (push_type_stack, get_type_stack, push_typelist)
3418         (follow_type_instance_flags, follow_types): Don't declare.
3419         * parse.c (type_stack): Remove global.
3420         (parse_exp_in_context): Update.
3421         (insert_into_type_stack, insert_type, push_type, push_type_int)
3422         (insert_type_address_space, pop_type, pop_type_int)
3423         (pop_typelist, pop_type_stack, append_type_stack)
3424         (push_type_stack, get_type_stack, push_typelist)
3425         (follow_type_instance_flags, follow_types): Remove (moved to
3426         type-stack.c).
3427         * f-exp.y (type_stack): New global.
3428         Update rules.
3429         (push_kind_type, f_parse): Update.
3430         * d-exp.y (type_stack): New global.
3431         Update rules.
3432         (d_parse): Update.
3433         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3434         Update rules.
3435         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3436         (HFILES_NO_SRCDIR): Add type-stack.h.
3437
3438 2019-04-04  Tom Tromey  <tom@tromey.com>
3439
3440         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3441         (rust_parser::convert_ast_to_expression, rust_parse)
3442         (rust_lex_test_completion, rust_lex_tests): Update.
3443         * parser-defs.h (struct expr_completion_state): New.
3444         (struct parser_state) <parser_state>: Add completion parameter.
3445         <mark_struct_expression, mark_completion_tag>: New methods.
3446         <parse_completion, m_completion_state>: New members.
3447         (prefixify_expression, null_post_parser): Update.
3448         (mark_struct_expression, mark_completion_tag): Don't declare.
3449         * parse.c (parse_completion, expout_last_struct)
3450         (expout_tag_completion_type, expout_completion_name): Remove
3451         globals.
3452         (parser_state::mark_struct_expression)
3453         (parser_state::mark_completion_tag): Now methods.
3454         (prefixify_expression): Add last_struct parameter.
3455         (prefixify_subexp): Likewise.
3456         (parse_exp_1): Update.
3457         (parse_exp_in_context): Add cstate parameter.  Update.
3458         (parse_expression_for_completion): Create an
3459         expr_completion_state.
3460         (null_post_parser): Add "completion" parameter.
3461         * p-exp.y: Update rules.
3462         (yylex): Update.
3463         * language.h (struct language_defn) <la_post_parser>: Add
3464         "completing" parameter.
3465         * go-exp.y: Update rules.
3466         (lex_one_token): Update.
3467         * expression.h (parse_completion): Don't declare.
3468         * d-exp.y: Update rules.
3469         (lex_one_token): Update rules.
3470         * c-exp.y: Update rules.
3471         (lex_one_token): Update.
3472         * ada-lang.c (resolve): Add "parse_completion" parameter.
3473         (resolve_subexp): Likewise.
3474         (ada_resolve_function): Likewise.
3475
3476 2019-04-04  Tom Tromey  <tom@tromey.com>
3477
3478         * parser-defs.h (struct parser_state) <start_arglist,
3479         end_arglist>: New methods.
3480         <arglist_len, m_funcall_chain>: New members.
3481         (arglist_len, start_arglist, end_arglist): Don't declare.
3482         * parse.c (arglist_len, funcall_chain): Remove global.
3483         (start_arglist, end_arglist): Remove functions.
3484         (parse_exp_in_context): Update.
3485         * p-exp.y: Update rules.
3486         * m2-exp.y: Update rules.
3487         * go-exp.y: Update rules.
3488         * f-exp.y: Update rules.
3489         * d-exp.y: Update rules.
3490         * c-exp.y: Update rules.
3491
3492 2019-04-04  Tom Tromey  <tom@tromey.com>
3493
3494         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3495         lex_operator, push_back>: New methods.
3496         Update all rules.
3497         (rust_parser::lex_hex, lex_escape): Rename and update.
3498         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3499         (rust_parser::lex_operator): Rename and update.
3500         (rust_parser::lex_number, rustyylex, rustyyerror)
3501         (rust_lex_test_init, rust_lex_test_sequence)
3502         (rust_lex_test_push_back, rust_lex_tests): Update.
3503         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3504         parameter.
3505         <lexptr, prev_lexptr>: New members.
3506         (lexptr, prev_lexptr): Don't declare.
3507         * parse.c (lexptr, prev_lexptr): Remove globals.
3508         (parse_exp_in_context): Update.
3509         * p-exp.y (yylex, yyerror): Update.
3510         * m2-exp.y (parse_number, yylex, yyerror): Update.
3511         * go-exp.y (lex_one_token, yyerror): Update.
3512         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3513         * d-exp.y (lex_one_token, yyerror): Update.
3514         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3515         (lex_one_token, yyerror): Update.
3516         * ada-lex.l (YY_INPUT): Update.
3517         (rewind_to_char): Update.
3518         * ada-exp.y (yyerror): Update.
3519
3520 2019-04-04  Tom Tromey  <tom@tromey.com>
3521
3522         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3523         * parser-defs.h (struct parser_state) <parser_state>: Add new
3524         parameter.
3525         <comma_terminates>: New member.
3526         (comma_terminates): Don't declare global.
3527         * parse.c (comma_terminates): Remove global.
3528         (parse_exp_in_context): Update.
3529         * p-exp.y (yylex): Update.
3530         * m2-exp.y (yylex): Update.
3531         * go-exp.y (lex_one_token): Update.
3532         * f-exp.y (yylex): Update.
3533         * d-exp.y (lex_one_token): Update.
3534         * c-exp.y (lex_one_token): Update.
3535         * ada-lex.l: Update.
3536
3537 2019-04-04  Tom Tromey  <tom@tromey.com>
3538
3539         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3540         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3541         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3542         * parser-defs.h (paren_depth): Don't declare.
3543         * parse.c (paren_depth): Remove global.
3544         (parse_exp_in_context): Update.
3545         * p-exp.y (paren_depth): New global.
3546         (pascal_parse): Initialize it.
3547         * m2-exp.y (paren_depth): New global.
3548         (m2_parse): Initialize it.
3549         * go-exp.y (paren_depth): New global.
3550         (go_parse): Initialize it.
3551         * f-exp.y (paren_depth): New global.
3552         (f_parse): Initialize it.
3553         * d-exp.y (paren_depth): New global.
3554         (d_parse): Initialize it.
3555         * c-exp.y (paren_depth): New global.
3556         (c_parse): Initialize it.
3557         * ada-lex.l (paren_depth): New global.
3558         (lexer_init): Initialize it.
3559
3560 2019-04-04  Tom Tromey  <tom@tromey.com>
3561
3562         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3563         (rust_parser::convert_ast_to_type)
3564         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3565         * parser-defs.h (struct parser_state) <parser_state>: Add
3566         parameters.  Initialize new members.
3567         <expression_context_block, expression_context_pc>: New members.
3568         * parse.c (expression_context_block, expression_context_pc):
3569         Remove globals.
3570         (parse_exp_in_context): Update.
3571         * p-exp.y: Update all rules.
3572         (yylex): Update.
3573         * m2-exp.y: Update all rules.
3574         (yylex): Update.
3575         * go-exp.y (yylex): Update.
3576         * f-exp.y (yylex): Update.
3577         * d-exp.y: Update all rules.
3578         (yylex): Update.
3579         * c-exp.y: Update all rules.
3580         (lex_one_token, classify_name, yylex, c_parse): Update.
3581         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3582
3583 2019-04-04  Tom Tromey  <tom@tromey.com>
3584
3585         * gdbarch.h, gdbarch.c: Rebuild.
3586         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3587         * stap-probe.h:
3588         (struct stap_parse_info): Replace "parser_state" with
3589         "expr_builder".
3590         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3591         (parser_state): New class.
3592         * parse.c (expr_builder): Rename.
3593         (expr_builder::release): Rename.
3594         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3595         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3596         (write_exp_elt_longcst, write_exp_elt_floatcst)
3597         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3598         (write_exp_string_vector, write_exp_bitstring)
3599         (write_exp_msymbol, mark_struct_expression)
3600         (write_dollar_variable)
3601         (insert_type_address_space, increase_expout_size): Replace
3602         "parser_state" with "expr_builder".
3603         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3604         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3605         "parser_state" with "expr_builder".
3606
3607 2019-04-04  Tom Tromey  <tom@tromey.com>
3608
3609         * rust-exp.y: Replace "parse_language" with method call.
3610         * p-exp.y:
3611         (yylex): Replace "parse_language" with method call.
3612         * m2-exp.y:
3613         (yylex): Replace "parse_language" with method call.
3614         * go-exp.y (classify_name): Replace "parse_language" with method
3615         call.
3616         * f-exp.y (yylex): Replace "parse_language" with method call.
3617         * d-exp.y (lex_one_token): Replace "parse_language" with method
3618         call.
3619         * c-exp.y:
3620         (lex_one_token, classify_name, yylex): Replace "parse_language"
3621         with method call.
3622         * ada-exp.y (find_primitive_type, type_char)
3623         (type_system_address): Replace "parse_language" with method call.
3624
3625 2019-04-04  Tom Tromey  <tom@tromey.com>
3626
3627         * rust-exp.y: Replace "parse_gdbarch" with method call.
3628         * parse.c (write_dollar_variable, insert_type_address_space):
3629         Replace "parse_gdbarch" with method call.
3630         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3631         call.
3632         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3633         call.
3634         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3635         "parse_gdbarch" with method call.
3636         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3637         with method call.
3638         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3639         "parse_gdbarch" with method call.
3640         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3641         "parse_gdbarch" with method call.
3642         * c-exp.y (parse_type, parse_number, classify_name): Replace
3643         "parse_gdbarch" with method call.
3644         * ada-lex.l: Replace "parse_gdbarch" with method call.
3645         * ada-exp.y (parse_type, find_primitive_type, type_char)
3646         (type_system_address): Replace "parse_gdbarch" with method call.
3647
3648 2019-04-04  Tom Tromey  <tom@tromey.com>
3649
3650         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3651         * stap-probe.c (stap_parse_argument): Update.
3652         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3653         initial_size parameter.
3654         * rust-exp.y (rust_lex_tests): Update.
3655         * parse.c (parser_state): Update.
3656         (parse_exp_in_context): Update.
3657         * parser-defs.h (struct parser_state) <parser_state>: Remove
3658         "initial_size" parameter.
3659
3660 2019-04-04  Tom Tromey  <tom@tromey.com>
3661
3662         * parser-defs.h (increase_expout_size): Don't declare.
3663         * parse.c (increase_expout_size): Now static.
3664
3665 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3666
3667         * gnu-nat.c (gnu_nat_target::wait): Fix
3668         target_waitstatus_to_string call.
3669
3670 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3671
3672         * eval.c (evaluate_subexp_standard): Handle internal functions
3673         during Fortran function call handling.
3674
3675 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3676
3677         * NEWS: Mention new internal functions.
3678         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3679         (read_base_type): Use dwarf2_init_complex_target_type.
3680         * value.c (creal_internal_fn): New function.
3681         (cimag_internal_fn): New function.
3682         (_initialize_values): Register new internal functions.
3683
3684 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3685
3686         * infrun.c (stop_all_threads): If debug_infrun, always
3687         trace the wait status after wait_one, using
3688         target_waitstatus_to_string and target_pid_to_str.
3689         (handle_inferior_event): Replace various trace of
3690         wait status kind by a single trace.
3691         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3692         wait status kind image by target_waitstatus_to_string.
3693         * target/waitstatus.c (target_waitstatus_to_string): Fix
3694         obsolete comment.
3695
3696 2019-04-01  Tom Tromey  <tromey@adacore.com>
3697
3698         PR symtab/23331:
3699         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3700
3701 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3702             Pedro Alves  <palves@redhat.com>
3703
3704         * top.c (quit_force): Call 'finalize_values'.
3705         * value.c (finalize_values): New function.
3706         * value.h (finalize_values): Declare.
3707
3708 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3709
3710         * NEWS: Announce $_gdb_major and $_gdb_minor.
3711
3712         * top.c (init_gdb_version_vars): New function.
3713         (gdb_init): Call init_gdb_version_vars.
3714
3715 2019-03-29  Tom Tromey  <tromey@adacore.com>
3716
3717         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3718         help text.  Remove dead code.
3719
3720 2019-03-29  Keith Seitz  <keiths@redhat.com>
3721
3722         From Siddhesh Poyarekar:
3723         * f-lang.h (f77_get_upperbound): Return LONGEST.
3724         (f77_get_lowerbound): Likewise.
3725         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3726         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3727         print them.
3728         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3729         plongest to format print it.
3730         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3731         (f77_get_upperbound): Likewise.
3732         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3733         LOWER_BOUND to LONGEST.
3734         (f77_create_arrayprint_offset_tbl): Likewise.
3735
3736 2019-03-29  Keith Seitz  <keiths@redhat.com>
3737
3738         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3739         %s/pulongest for TYPE_LENGTH instead of %d in format
3740         strings.
3741         * ada-typerint.c (ada_print_type): Likewise.
3742         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3743         * compile/compile-c-support.c (generate_register_struct): Likewise.
3744         * gdbtypes.c (recursive_dump_type): Likewise.
3745         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3746         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3747         instead of %d in format strings.
3748         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3749         to std::min to ULONGEST.
3750         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3751         instead of %d in format strings.
3752         * tracepoint.c (info_scope_command): Likewise.
3753         * typeprint.c (print_offset_data::update)
3754         (print_offset_data::finish): Likewise.
3755         * xtensa-tdep.c (xtensa_store_return_value)
3756         (xtensa_push_dummy_call): Likewise.
3757
3758 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3759
3760         * windows-nat.c (display_selector): Fixed format specifications
3761         for 64-bit Cygwin.
3762
3763 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3764
3765         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3766
3767 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3768
3769         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3770         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3771         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3772         (nios2_linux_init_abi): Install it.
3773
3774 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3775
3776         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3777
3778 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3779
3780         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3781
3782 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3783             Tom Tromey  <tromey@adacore.com>
3784
3785         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3786
3787 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3788
3789         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3790         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3791         method to compute the bounds of range types. Also print "[evaluated]"
3792         if the bounds' values come from a dynamic evaluation.
3793
3794 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3795
3796         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3797         whitespace when pretty printing is on.
3798
3799 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3800
3801         * ppc-linux-nat.c: Add include.
3802
3803 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3804
3805         * NEWS: Mention AArch64 Pointer Authentication.
3806
3807 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3808
3809         * arm-linux-nat.c: Add include.
3810
3811 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3812
3813         * source-cache.c (source_cache::get_source_lines): Re-read
3814         fullname after calling open_source_file.
3815
3816 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3817
3818         * NEWS: Mention TLS support for FreeBSD.
3819
3820 2019-03-25  Tom Tromey  <tromey@adacore.com>
3821
3822         * minsyms.c (BUNCH_SIZE): Update comment.
3823         (~minimal_symbol_reader): Remove old comment.
3824         (compact_minimal_symbols): Update comment.
3825         (minimal_symbol_reader::install): Remove old comment.  Update
3826         other comments.
3827
3828 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3829
3830         * s390-linux-nat.c: Add include.
3831
3832 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3833
3834         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3835         Call linux_get_hwcap.
3836         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3837         Likewise.
3838         (aarch64_linux_get_hwcap): Remove function.
3839         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3840         declaration.
3841         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3842         linux_get_hwcap.
3843         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3844         * linux-tdep.c (linux_get_hwcap): Add function.
3845         (linux_get_hwcap2): Likewise.
3846         * linux-tdep.h (linux_get_hwcap): Add declaration.
3847         (linux_get_hwcap2): Likewise.
3848         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3849         (ppc_linux_get_hwcap2): Likewise.
3850         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3851         linux_get_hwcap.
3852         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3853         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3854         (ppc_linux_nat_target::read_description): Likewise.
3855         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3856         * s390-linux-nat.c: Likewise.
3857         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3858
3859 2019-03-24  Tom Tromey  <tom@tromey.com>
3860
3861         * ada-lang.c (standard_lookup): Simplify initialization.
3862         (ada_lookup_symbol_nonlocal): Simplify return.
3863         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3864         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3865         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3866         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3867         initialization.
3868         * solib.c (solib_global_lookup): Simplify.
3869         * symtab.c (null_block_symbol): Remove.
3870         (symbol_cache_lookup): Simplify returns.
3871         (lookup_language_this): Simplify returns.
3872         (lookup_symbol_aux): Simplify return.
3873         (lookup_local_symbol): Simplify returns.
3874         (lookup_global_symbol_from_objfile): Simplify return.
3875         (lookup_symbol_in_objfile_symtabs)
3876         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3877         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3878         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3879         * cp-namespace.c (cp_lookup_bare_symbol)
3880         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3881         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3882         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3883         (cp_lookup_symbol_via_imports): Simplify initialization.
3884         (find_symbol_in_baseclass): Likewise.
3885         * symtab.h (null_block_symbol): Remove.
3886         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3887         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3888         (d_lookup_symbol_module): Likewise.
3889         (find_symbol_in_baseclass): Simplify initialization.
3890
3891 2019-03-24  Tom Tromey  <tom@tromey.com>
3892
3893         * expression.h: Don't include symtab.h.
3894         (struct block): Forward declare.
3895
3896 2019-03-24  Tom Tromey  <tom@tromey.com>
3897
3898         * c-exp.y (typebase): Remove casts.
3899         * gdbtypes.c (lookup_unsigned_typename, )
3900         (lookup_signed_typename): Remove cast.
3901         * eval.c (parse_to_comma_and_eval): Remove cast.
3902         * parse.c (write_dollar_variable): Remove cast.
3903         * block.h (struct block) <superblock>: Now const.
3904         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3905         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3906         (map_block): Make "block" const.
3907         * symfile.h (struct quick_symbol_functions)
3908         <map_matching_symbols>: Constify block argument to "callback".
3909         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3910         const.
3911         (find_pc_sect_compunit_symtab): Make "b" const.
3912         (find_symbol_at_address): Likewise.
3913         (search_symbols): Likewise.
3914         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3915         (dw2_debug_names_lookup_symbol): Likewise.
3916         (dw2_map_matching_symbols): Update.
3917         * p-valprint.c (pascal_val_print): Remove "block".
3918         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3919         (aux_add_nonlocal_symbols): Make "block" const.
3920         (resolve_subexp): Remove cast.
3921         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3922         const.
3923         (iterate_over_file_blocks): Likewise.
3924         * f-exp.y (%union) <bval>: Remove.
3925         * coffread.c (patch_opaque_types): Make "b" const.
3926         * spu-tdep.c (spu_catch_start): Make "block" const.
3927         * c-valprint.c (print_unpacked_pointer): Remove "block".
3928         * symmisc.c (dump_symtab_1): Make "b" const.
3929         (block_depth): Make "block" const.
3930         * d-exp.y (%union) <bval>: Remove.
3931         * cp-support.h (cp_lookup_rtti_type): Update.
3932         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3933         * psymtab.c (psym_lookup_symbol): Make "block" const.
3934         (maintenance_check_psymtabs): Make "b" const.
3935         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3936         (enumerate_locals, enumerate_args): Update.
3937         * python/py-symtab.c (stpy_global_block): Make "block" const.
3938         (stpy_static_block): Likewise.
3939         * inline-frame.c (block_starting_point_at): Make "new_block"
3940         const.
3941         * block.c (find_block_in_blockvector): Make return type const.
3942         (blockvector_for_pc_sect): Make "b" const.
3943         (find_block_in_blockvector): Make "b" const.
3944
3945 2019-03-23  Tom Tromey  <tom@tromey.com>
3946
3947         * varobj.c (varobj_create): Update.
3948         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3949         * printcmd.c (display_command, do_one_display): Don't reset
3950         innermost_block.
3951         * parser-defs.h (enum innermost_block_tracker_type): Move to
3952         expression.h.
3953         (innermost_block): Update comment.
3954         * parse.c (parse_exp_1): Add tracker_types parameter.
3955         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3956         tracker_types parameter.  Reset innermost_block.
3957         (parse_exp_in_context): Remove.
3958         (parse_expression_for_completion): Update.
3959         * objfiles.c (~objfile): Don't reset expression_context_block or
3960         innermost_block.
3961         * expression.h (enum innermost_block_tracker_type): Move from
3962         parser-defs.h.
3963         (parse_exp_1): Add tracker_types parameter.
3964         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3965         reset innermost_block.
3966
3967 2019-03-23  Tom Tromey  <tom@tromey.com>
3968
3969         * objfiles.h: Include bcache.h.
3970
3971 2019-03-23  Tom Tromey  <tom@tromey.com>
3972
3973         * linespec.c (get_current_search_block): Use
3974         scoped_restore_current_language.
3975         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3976
3977 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3978             Jiong Wang  <jiong.wang@arm.com>
3979
3980         * aarch64-linux-tdep.c
3981         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3982         section.
3983         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3984
3985 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3986             Jiong Wang  <jiong.wang@arm.com>
3987
3988         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3989         instructions.
3990         (aarch64_analyze_prologue_test): Add PACIASP test.
3991         (aarch64_prologue_prev_register): Unmask PC value.
3992
3993 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3994             Jiong Wang  <jiong.wang@arm.com>
3995
3996         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3997         (aarch64_dwarf2_prev_register): Unmask PC value.
3998         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3999         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4000         DW_CFA_AARCH64_negate_ra_state.
4001         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4002
4003 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4004             Jiong Wang  <jiong.wang@arm.com>
4005
4006         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4007         registers.
4008         (aarch64_pseudo_register_name): Likewise.
4009         (aarch64_pseudo_register_type): Likewise.
4010         (aarch64_pseudo_register_reggroup_p): Likewise.
4011         (aarch64_gdbarch_init): Add pauth registers.
4012         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4013         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4014         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4015         (struct gdbarch_tdep): Add regnum for ra_state.
4016
4017 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4018             Jiong Wang  <jiong.wang@arm.com>
4019
4020         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4021
4022 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4023             Jiong Wang  <jiong.wang@arm.com>
4024
4025         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4026         function.
4027         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4028         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4029         (aarch64_gdbarch_init): Add puth registers.
4030         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4031         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4032         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4033
4034 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4035             Jiong Wang  <jiong.wang@arm.com>
4036
4037         * aarch64-linux-nat.c
4038         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4039         * aarch64-linux-tdep.c
4040         (aarch64_linux_core_read_description): Likewise.
4041         (aarch64_linux_get_hwcap): New function.
4042         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4043         (aarch64_linux_get_hwcap): New declaration.
4044
4045 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4046             Jiong Wang  <jiong.wang@arm.com>
4047
4048         * aarch64-linux-nat.c
4049         (aarch64_linux_nat_target::read_description): Add pauth param.
4050         * aarch64-linux-tdep.c
4051         (aarch64_linux_core_read_description): Likewise.
4052         * aarch64-tdep.c (struct target_desc): Add in pauth.
4053         (aarch64_read_description): Add pauth param.
4054         (aarch64_gdbarch_init): Likewise.
4055         * aarch64-tdep.h (aarch64_read_description): Likewise.
4056         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4057         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4058         * features/Makefile: Add new files.
4059         * features/aarch64-pauth.c: New file.
4060         * features/aarch64-pauth.xml: New file.
4061
4062 2019-03-20  Tom Tromey  <tromey@adacore.com>
4063
4064         * infrun.c (handle_inferior_event): Rename from
4065         handle_inferior_event_1.  Create a scoped_value_mark.
4066         (handle_inferior_event): Remove.
4067
4068 2019-03-19  Tom Tromey  <tromey@adacore.com>
4069
4070         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4071         * infrun.h (print_stop_event): Add "displays" parameter.
4072         * infrun.c (print_stop_event): Add "displays" parameter.
4073
4074 2019-03-19  Pedro Alves  <palves@redhat.com>
4075
4076         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4077         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4078         to -1.  Fix TABs vs spaces.
4079         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4080         * tui/tui-out.h (tui_ui_out) Add intro comments.
4081         <m_line, m_start_of_line>: In-class initialize, and add describing
4082         comment.
4083
4084 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4085
4086         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4087         variable names.
4088         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4089
4090 2019-03-18  Pedro Alves  <palves@redhat.com>
4091             Eli Zaretskii <eliz@gnu.org>
4092
4093         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4094         m_line and m_start_of_line.
4095
4096 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4097
4098         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4099         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4100         it returns a newline.  This fixes a regression in TU mode, whereby
4101         the next line is output on the same screen line as the user input.
4102
4103 2019-03-18  Tom Tromey  <tromey@adacore.com>
4104
4105         * minsyms.c (minimal_symbol_reader::install): Remove call to
4106         obstack_blank.
4107
4108 2019-03-18  Pedro Alves  <palves@redhat.com>
4109
4110         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4111         New globals.
4112         (apply_style): New, factored out from ...
4113         (apply_ansi_escape): ... this.  Handle reverse video mode.
4114         (tui_set_reverse_mode): New function.
4115         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4116         * tui/tui-winsource.c (tui_show_source_line): Use
4117         tui_set_reverse_mode instead of setting A_STANDOUT.
4118         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4119         New setter methods.
4120
4121 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4122
4123         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4124         Handle tabs.
4125
4126 2019-03-18  Tom Tromey  <tromey@adacore.com>
4127
4128         * ada-lang.c (empty_array): Add "high" parameter.
4129         (ada_evaluate_subexp): Update.
4130
4131 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4132
4133         * unittests/string_view-selftests.c: Define
4134         _initialize_string_view_selftests unconditionally.
4135
4136 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4137
4138         PR gdb/24350
4139         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4140
4141 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4142
4143         PR gdb/24351
4144         * windows-nat.c (display_selector): Fix format specifiers.
4145
4146 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4147
4148         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4149         tui_refill_source_window instead of tui_refresh_win, to update the
4150         current execution line.  This fixes redisplay of the current line
4151         when stepping through the code with "next" or "step".
4152
4153 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4154
4155         * source-cache.c (source_cache::get_source_lines): Call
4156         find_source_lines to initialize s->nlines.  This fixes vertical
4157         scrolling of TUI source window when the DOWN arrow is pressed.
4158
4159 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4160
4161         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4162         linux-thread-db.c (_initialize_thread_db): Likewise.
4163
4164 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4165
4166         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4167         wclrtoeol in tui_show_source_line".  This reverts changes made in
4168         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4169
4170 2019-03-15  Tom Tromey  <tom@tromey.com>
4171
4172         * symtab.h (struct minimal_symbol): Derive from
4173         general_symbol_info.
4174         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4175         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4176         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4177         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4178         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4179         (MSYMBOL_SEARCH_NAME): Update.
4180         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4181         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4182         * minsyms.c (minimal_symbol_reader::record_full): Update.
4183
4184 2019-03-15  Tom Tromey  <tom@tromey.com>
4185
4186         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4187
4188 2019-03-15  Tom Tromey  <tom@tromey.com>
4189
4190         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4191         unique_xmalloc_ptr.
4192         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4193         Update.
4194         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4195         (build_minimal_symbol_hash_tables)
4196         (minimal_symbol_reader::install): Update.
4197
4198 2019-03-15  Tom Tromey  <tom@tromey.com>
4199
4200         * symtab.c (create_demangled_names_hash): Update.
4201         (symbol_set_names): Update.
4202         * objfiles.h (struct objfile_per_bfd_storage)
4203         <demangled_names_hash>: Now an htab_up.
4204         * objfiles.c (objfile_per_bfd_storage): Simplify.
4205
4206 2019-03-15  Tom Tromey  <tom@tromey.com>
4207
4208         * objfiles.h (struct objfile_per_bfd_storage): Declare
4209         destructor.
4210         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4211         New.
4212         (get_objfile_bfd_data): Use new.  Don't initialize
4213         language_of_main.
4214         (free_objfile_per_bfd_storage): Remove.
4215         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4216
4217 2019-03-15  Tom Tromey  <tom@tromey.com>
4218
4219         * symfile.c (reread_symbols): Update.
4220         * objfiles.c (objfile::objfile): Update.
4221         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4222         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4223         comment.
4224         (minimal_symbol_reader::install): Update.
4225         (terminate_minimal_symbol_table): Remove.
4226         * jit.c (jit_object_close_impl): Update.
4227
4228 2019-03-15  Tom Tromey  <tom@tromey.com>
4229
4230         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4231         initializations.
4232
4233 2019-03-15  Tom Tromey  <tom@tromey.com>
4234
4235         * objfiles.h (struct objfile_per_bfd_storage)
4236         <demangled_hash_languages>: Now a bitset.
4237         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4238         (lookup_minimal_symbol): Update.
4239
4240 2019-03-15  Tom Tromey  <tom@tromey.com>
4241
4242         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4243         Don't return the symbol.
4244         * coffread.c (record_minimal_symbol): Use record_full.
4245
4246 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4247
4248         The MS-Windows port of ncurses fails to switch to a color pair if
4249         one or both of the colors are the implicit default colors.  This
4250         change records the default colors when TUI is initialized, and
4251         then specifies them explicitly when a color pair uses the default
4252         colors.  This allows color styling in TUI mode on MS-Windows.
4253
4254         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4255         ncurses_norm_attr.
4256         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4257         colors in ncurses_norm_attr.
4258         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4259         "none", replace it with the default color recorded in
4260         ncurses_norm_attr.
4261
4262 2019-03-14  Tom Tromey  <tromey@adacore.com>
4263
4264         * source-cache.h (class source_cache) <get_source_lines>: Return
4265         std::string.
4266         * source-cache.c (source_cache::extract_lines): Handle case where
4267         first_pos==npos.  Return std::string.
4268         (source_cache::get_source_lines): Update.
4269
4270 2019-03-14  Tom Tromey  <tromey@adacore.com>
4271
4272         * NEWS: Add item for "style sources" commands.
4273         * source-cache.c (source_cache::get_source_lines): Check
4274         source_styling.
4275         * cli/cli-style.c (source_styling): New global.
4276         (_initialize_cli_style): Add "style sources" commands.
4277         (show_style_sources): New function.
4278         * cli/cli-style.h (source_styling): Declare.
4279
4280 2019-03-14  Pedro Alves  <palves@redhat.com>
4281             Tom Tromey  <tromey@adacore.com>
4282
4283         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4284         * tui/tui-winsource.c (tui_refill_source_window): New function,
4285         from...
4286         (tui_horizontal_source_scroll): ... here.  Move some logic.
4287         * cli/cli-style.c (set_style_enabled): Notify new observable.
4288         * tui/tui-hooks.c (tui_redisplay_source): New function.
4289         (tui_attach_detach_observers): Attach or detach
4290         tui_redisplay_source.
4291         * observable.h (source_styling_changed): New observable.
4292         * observable.c: Define source_styling_changed observable.
4293
4294 2019-03-13  Tom Tromey  <tromey@adacore.com>
4295
4296         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4297         (i386_gnu_nat_target::store_registers): Update.
4298         * target-debug.h (target_debug_print_std_string): New macro.
4299         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4300         * windows-tdep.c (display_one_tib): Update.
4301         * tui/tui-stack.c (tui_make_status_line): Update.
4302         * top.c (print_inferior_quit_action): Update.
4303         * thread.c (thr_try_catch_cmd): Update.
4304         (add_thread_with_info): Update.
4305         (thread_target_id_str): Update.
4306         (thr_try_catch_cmd): Update.
4307         (thread_command): Update.
4308         (thread_find_command): Update.
4309         * record-btrace.c (record_btrace_target::info_record)
4310         (record_btrace_resume_thread, record_btrace_target::resume)
4311         (record_btrace_cancel_resume, record_btrace_step_thread)
4312         (record_btrace_target::wait, record_btrace_target::wait)
4313         (record_btrace_target::wait, record_btrace_target::stop): Update.
4314         * progspace.c (print_program_space): Update.
4315         * process-stratum-target.c
4316         (process_stratum_target::thread_address_space): Update.
4317         * linux-fork.c (linux_fork_mourn_inferior)
4318         (detach_checkpoint_command, info_checkpoints_command)
4319         (linux_fork_context): Update.
4320         (linux_fork_detach): Update.
4321         (class scoped_switch_fork_info): Update.
4322         (delete_checkpoint_command): Update.
4323         * infrun.c (follow_fork_inferior): Update.
4324         (follow_fork_inferior): Update.
4325         (proceed_after_vfork_done): Update.
4326         (handle_vfork_child_exec_or_exit): Update.
4327         (follow_exec): Update.
4328         (displaced_step_prepare_throw): Update.
4329         (displaced_step_restore): Update.
4330         (start_step_over): Update.
4331         (resume_1): Update.
4332         (clear_proceed_status_thread): Update.
4333         (proceed): Update.
4334         (print_target_wait_results): Update.
4335         (do_target_wait): Update.
4336         (context_switch): Update.
4337         (stop_all_threads): Update.
4338         (restart_threads): Update.
4339         (finish_step_over): Update.
4340         (handle_signal_stop): Update.
4341         (switch_back_to_stepped_thread): Update.
4342         (keep_going_pass_signal): Update.
4343         (print_exited_reason): Update.
4344         (normal_stop): Update.
4345         * inferior.c (inferior_pid_to_str): Change return type.
4346         (print_selected_inferior): Update.
4347         (add_inferior): Update.
4348         (detach_inferior): Update.
4349         * dummy-frame.c (fprint_dummy_frames): Update.
4350         * dcache.c (dcache_info_1): Update.
4351         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4352         (btrace_fetch, btrace_clear): Update.
4353         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4354         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4355         type.
4356         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4357         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4358         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4359         * gdbarch.c, gdbarch.h: Rebuild.
4360         * gdbarch.sh (core_pid_to_str): Change return type.
4361         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4362         return type.
4363         (windows_nat_target::pid_to_str): Change return type.
4364         (windows_delete_thread): Update.
4365         (windows_nat_target::attach): Update.
4366         (windows_nat_target::files_info): Update.
4367         * target-delegates.c: Rebuild.
4368         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4369         return type.
4370         (sol_thread_target::pid_to_str): Change return type.
4371         * remote.c (class remote_target) <pid_to_str>: Change return
4372         type.
4373         (remote_target::pid_to_str): Change return type.
4374         (extended_remote_target::attach, remote_target::remote_stop_ns)
4375         (remote_target::remote_notif_remove_queued_reply)
4376         (remote_target::push_stop_reply, remote_target::disable_btrace):
4377         Update.
4378         (extended_remote_target::attach): Update.
4379         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4380         type.
4381         (gdbsim_target::pid_to_str): Change return type.
4382         * ravenscar-thread.c (struct ravenscar_thread_target)
4383         <pid_to_str>: Change return type.
4384         (ravenscar_thread_target::pid_to_str): Change return type.
4385         * procfs.c (class procfs_target) <pid_to_str>: Change return
4386         type.
4387         (procfs_target::pid_to_str): Change return type.
4388         (procfs_target::attach): Update.
4389         (procfs_target::detach): Update.
4390         (procfs_target::fetch_registers): Update.
4391         (procfs_target::store_registers): Update.
4392         (procfs_target::wait): Update.
4393         (procfs_target::files_info): Update.
4394         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4395         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4396         return type.
4397         (nto_procfs_target::pid_to_str): Change return type.
4398         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4399         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4400         return type.
4401         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4402         (exit_lwp): Update.
4403         (attach_proc_task_lwp_callback, get_detach_signal)
4404         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4405         (linux_nat_target::resume, wait_lwp, stop_callback)
4406         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4407         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4408         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4409         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4410         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4411         type.
4412         (inf_ptrace_target::attach): Update.
4413         (inf_ptrace_target::files_info): Update.
4414         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4415         type.
4416         (go32_nat_target::pid_to_str): Change return type.
4417         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4418         (gnu_nat_target::wait): Update.
4419         (gnu_nat_target::wait): Update.
4420         (gnu_nat_target::resume): Update.
4421         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4422         (fbsd_nat_target::wait): Update.
4423         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4424         type.
4425         (darwin_nat_target::attach): Update.
4426         * corelow.c (class core_target) <pid_to_str>: Change return type.
4427         (core_target::pid_to_str): Change return type.
4428         * target.c (normal_pid_to_str): Change return type.
4429         (default_pid_to_str): Likewise.
4430         (target_pid_to_str): Change return type.
4431         (target_translate_tls_address): Update.
4432         (target_announce_detach): Update.
4433         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4434         return type.
4435         (bsd_uthread_target::pid_to_str): Change return type.
4436         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4437         type.
4438         (bsd_kvm_target::pid_to_str): Change return type.
4439         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4440         return type.
4441         (aix_thread_target::pid_to_str): Change return type.
4442         * target.h (struct target_ops) <pid_to_str>: Change return type.
4443         (target_pid_to_str, normal_pid_to_str): Likewise.
4444         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4445         type.
4446         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4447         type.
4448         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4449         return type.
4450         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4451         type.
4452         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4453         type.
4454         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4455         return type.
4456
4457 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4458
4459         * NEWS: Mention that the new default MI version is 3.  Mention
4460         changes to the output of commands and events that deal with
4461         multi-location breakpoints.
4462         * breakpoint.c: Include "mi/mi-out.h".
4463         (print_one_breakpoint): Change output syntax if using MI version
4464         >= 3.
4465         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4466         New.
4467         (mi_multi_location_breakpoint_output_fixed): New.
4468         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4469         (mi_cmd_fix_multi_location_breakpoint_output): New.
4470         (mi_multi_location_breakpoint_output_fixed): New.
4471         * mi/mi-cmds.c (mi_cmds): Register command
4472         -fix-multi-location-breakpoint-output.
4473         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4474         interpreter "mi".
4475
4476 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4477
4478         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4479         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4480         instantiate mi_ui_out based on interpreter name.
4481         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4482         * mi/mi-main.c (mi_load_progress): Likewise.
4483
4484 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4485
4486         * NEWS: Combine separate "New targets" sections for 8.3.
4487
4488 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4489
4490         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4491         (ppcfbsd_init_abi): Install gdbarch
4492         "fetch_tls_load_module_address" and "get_thread_local_address"
4493         methods.
4494
4495 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4496
4497         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4498         (riscv_fbsd_init_abi): Install gdbarch
4499         "fetch_tls_load_module_address" and "get_thread_local_address"
4500         methods.
4501
4502 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4503
4504         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4505         (i386fbsd_init_abi): Install gdbarch
4506         "fetch_tls_load_module_address" and "get_thread_local_address"
4507         methods.
4508
4509 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4510
4511         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4512         (amd64fbsd_init_abi): Install gdbarch
4513         "fetch_tls_load_module_address" and "get_thread_local_address"
4514         methods.
4515
4516 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4517
4518         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4519         (struct fbsd_pspace_data): New type.
4520         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4521         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4522         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4523         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4524         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4525
4526 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4527
4528         * gdbtypes.c (lookup_struct_elt): New function.
4529         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4530         * gdbtypes.h (struct struct_elt): New type.
4531         (lookup_struct_elt): New prototype.
4532
4533 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4534
4535         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4536         remove disabled code block.
4537
4538 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4539
4540         * gdbarch.sh (get_thread_local_address): New method.
4541         * gdbarch.h, gdbarch.c: Regenerate.
4542         * target.c (target_translate_tls_address): Use
4543         gdbarch_get_thread_local_address if present instead of
4544         target::get_thread_local_address.
4545
4546 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4547
4548         * target.h (target::get_thread_local_address): Update comment.
4549
4550 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4551
4552         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4553         objfile->separate_debug_objfile_backlink if not NULL.
4554
4555 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4556
4557         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4558         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4559         (amd64bsd_store_inferior_registers): Likewise.
4560         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4561         Enable segment base registers.
4562         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4563         PT_GETFSBASE and PT_GETGSBASE.
4564         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4565         PT_SETGSBASE.
4566         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4567         segment base registers.
4568         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4569
4570 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4571
4572         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4573         Update calls to i386_target_description to add 'segments'
4574         parameter.
4575         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4576         add segment base registers.
4577         * arch/i386.c (i386_create_target_description): Add 'segments'
4578         parameter to enable segment base registers.
4579         * arch/i386.h (i386_create_target_description): Likewise.
4580         * features/i386/32bit-segments.xml: New file.
4581         * features/i386/32bit-segments.c: Generate.
4582         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4583         call to i386_target_description to add 'segments' parameter.
4584         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4585         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4586         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4587         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4588         if feature is present.
4589         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4590         Add 'segments' parameter to call to i386_target_description.
4591         (i386_target_description): Add 'segments' parameter to enable
4592         segment base registers.
4593         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4594         to call to i386_target_description.
4595         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4596         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4597         Define I386_NUM_REGS.
4598         (i386_target_description): Add 'segments' parameter to enable
4599         segment base registers.
4600
4601 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4602
4603         PR/24325
4604         * source-cache.c: #undef open and close, to avoid unresolved
4605         externals during linking.
4606
4607 2019-03-12  Tom Tromey  <tromey@adacore.com>
4608
4609         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4610         const.  Add initializers.
4611         (_initialize_remote): Don't initialize ptid globals.
4612
4613 2019-03-12  Pedro Alves  <palves@redhat.com>
4614
4615         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4616
4617 2019-03-12  Pedro Alves  <palves@redhat.com>
4618
4619         * cp-name-parser.y (main): Remove unused 'len' variable.
4620
4621 2019-03-12  Tom Tromey  <tromey@adacore.com>
4622
4623         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4624         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4625
4626 2019-03-12  Tom Tromey  <tromey@adacore.com>
4627
4628         * linux-nat.c (iterate_over_lwps): Update.
4629         (stop_callback): Remove parameter.
4630         (stop_wait_callback, detach_callback, resume_set_callback)
4631         (select_singlestep_lwp_callback, set_ignore_sigint)
4632         (status_callback, resumed_callback, resume_clear_callback)
4633         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4634         data parameter.
4635         (linux_nat_target::detach, linux_nat_target::resume)
4636         (linux_stop_and_wait_all_lwps, select_event_lwp)
4637         (linux_nat_filter_event, linux_nat_wait_1)
4638         (linux_nat_target::kill, linux_nat_target::stop)
4639         (linux_nat_target::stop): Update.
4640         (linux_nat_resume_callback): Change type.
4641         (resume_stopped_resumed_lwps, count_events_callback)
4642         (select_event_lwp_callback): Likewise.
4643         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4644         * arm-linux-nat.c (struct update_registers_data): Remove.
4645         (update_registers_callback): Change type.
4646         (arm_linux_insert_hw_breakpoint1): Update.
4647         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4648         parameter.
4649         (x86_linux_dr_set_addr): Update.
4650         (x86_linux_dr_set_control): Update.
4651         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4652         (iterate_over_lwps): Use gdb::function_view.
4653         * nat/aarch64-linux-hw-point.c (struct
4654         aarch64_dr_update_callback_param): Remove.
4655         (debug_reg_change_callback): Change type.
4656         (aarch64_notify_debug_reg_change): Update.
4657         * s390-linux-nat.c (s390_refresh_per_info): Update.
4658
4659 2019-03-11  Tom Tromey  <tromey@adacore.com>
4660
4661         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4662         redundant assignment to "this_cu".
4663
4664 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4665
4666         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4667
4668 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4669
4670         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4671         from...
4672         (rank_one_type): ... this.
4673
4674 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4675
4676         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4677         from...
4678         (rank_one_type): ... this.
4679
4680 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4681
4682         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4683         from...
4684         (rank_one_type): ... this.
4685
4686 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4687
4688         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4689         from...
4690         (rank_one_type): ... this.
4691
4692 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4693
4694         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4695         from...
4696         (rank_one_type): ... this.
4697
4698 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4699
4700         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4701         from...
4702         (rank_one_type): ... this.
4703
4704 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4705
4706         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4707         from...
4708         (rank_one_type): ... this.
4709
4710 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4711
4712         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4713         from...
4714         (rank_one_type): ... this.
4715
4716 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4717
4718         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4719         from...
4720         (rank_one_type): ... this.
4721
4722 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4723
4724         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4725         from...
4726         (rank_one_type): ... this.
4727
4728 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4729
4730         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4731         from...
4732         (rank_one_type): ... this.
4733
4734 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4735
4736         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4737         from...
4738         (rank_one_type): ... this.
4739
4740 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4741
4742         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4743         inferior-events' shows the example events.
4744
4745 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4746
4747         Support styling on native MS-Windows console
4748
4749         PR/24315
4750         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4751         on MS-Windows if $TERM is not defined.
4752
4753         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4754
4755         * posix-hdep.c (gdb_console_fputs):
4756         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4757         functions.
4758         * ui-file.h (gdb_console_fputs): Add prototype.
4759
4760         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4761         back to fputs only if the former returns zero.
4762
4763 2019-03-07  Tom Tromey  <tom@tromey.com>
4764
4765         * symmisc.c (print_symbol_bcache_statistics): Update.
4766         (print_objfile_statistics): Update.
4767         * symfile.c (allocate_symtab): Update.
4768         * stabsread.c: Don't include bcache.h.
4769         * psymtab.h (struct psymbol_bcache): Don't declare.
4770         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4771         (psymbol_bcache_init, psymbol_bcache_free)
4772         (psymbol_bcache_get_bcache): Don't declare.
4773         * psymtab.c (struct psymbol_bcache): Remove.
4774         (psymtab_storage::psymtab_storage): Update.
4775         (psymtab_storage::~psymtab_storage): Update.
4776         (psymbol_bcache_init, psymbol_bcache_free)
4777         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4778         (add_psymbol_to_bcache): Update.
4779         (allocate_psymtab): Update.
4780         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4781         macro_cache>: No longer pointers.
4782         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4783         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4784         * macrotab.c (macro_bcache): Update.
4785         * macroexp.c: Don't include bcache.h.
4786         * gdbtypes.c (check_types_worklist): Update.
4787         (types_deeply_equal): Remove TRY/CATCH.  Update.
4788         * elfread.c (elf_symtab_read): Update.
4789         * dwarf2read.c: Don't include bcache.h.
4790         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4791         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4792         (print_bcache_statistics, bcache_memory_used): Don't declare.
4793         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4794         methods.  Rename all data members.
4795         * bcache.c (struct bcache): Move to bcache.h.
4796         (bcache::expand_hash_table): Rename from expand_hash_table.
4797         (bcache): Remove.
4798         (bcache::insert): Rename from bcache_full.
4799         (bcache::compare): Rename from bcache_compare.
4800         (bcache_xmalloc): Remove.
4801         (bcache::~bcache): Rename from bcache_xfree.
4802         (bcache::print_statistics): Rename from print_bcache_statistics.
4803         (bcache::memory_used): Rename from bcache_memory_used.
4804
4805 2019-03-07  Pedro Alves  <palves@redhat.com>
4806
4807         * infrun.c (normal_stop): Also check for
4808         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4809
4810 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4811
4812         * f-lang.c (value_from_host_double): Moved to...
4813         * value.c (value_from_host_double): ...here.
4814         * value.h (value_from_host_double): Declare.
4815         * guile/scm-math.c (vlscm_convert_typed_number): Use
4816         value_from_host_double.
4817         (vlscm_convert_number): Likewise.
4818         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4819         * python/py-value.c (convert_value_from_python): Likewise.
4820
4821 2019-03-06  Tom Tromey  <tom@tromey.com>
4822
4823         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4824
4825 2019-03-06  Tom Tromey  <tom@tromey.com>
4826
4827         * utils.h (free_current_contents): Don't declare.
4828         * utils.c (free_current_contents): Remove.
4829
4830 2019-03-06  Tom Tromey  <tom@tromey.com>
4831
4832         * top.c (quit_force): Update.
4833         * main.c (captured_command_loop): Update.
4834         * common/new-op.c (operator new): Update.
4835         * common/common-exceptions.c (struct catcher)
4836         <save_cleanup_chain>: Remove member.
4837         (exceptions_state_mc_init): Update.
4838         (exception_try_scope_entry): Return nullptr.
4839         (exception_try_scope_exit, exception_rethrow)
4840         (throw_exception_sjlj, throw_exception_cxx): Update.
4841         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4842         (all_cleanups, do_cleanups, discard_cleanups)
4843         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4844         (restore_cleanups, restore_final_cleanups): Don't declare.
4845         (do_final_cleanups): Remove parameter.
4846         * common/cleanups.c (cleanup_chain, make_cleanup)
4847         (make_cleanup_dtor, all_cleanups, do_cleanups)
4848         (discard_my_cleanups, discard_cleanups)
4849         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4850         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4851         (null_cleanup): Remove.
4852         (do_final_cleanups): Remove parameter.
4853
4854 2019-03-06  Tom Tromey  <tom@tromey.com>
4855
4856         * remote.c (remote_target::remote_parse_stop_reply): Use
4857         unique_xmalloc_ptr.
4858
4859 2019-03-06  Tom Tromey  <tom@tromey.com>
4860
4861         * stabsread.c (struct stabs_field_info): Rename from field_info.
4862         <list, fnlist>: Add initializers.
4863         <obstack>: New member.
4864         (read_member_functions, read_struct_fields, read_baseclasses):
4865         Allocate on obstack.  Don't use cleanups.
4866         (read_one_struct_field, read_member_functions, read_struct_fields)
4867         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4868         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4869         (read_struct_type): Update.
4870
4871 2019-03-06  Tom Tromey  <tom@tromey.com>
4872
4873         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4874         * common/filestuff.h (make_cleanup_close): Don't declare.
4875         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4876         Remove.
4877
4878 2019-03-06  Tom Tromey  <tom@tromey.com>
4879
4880         * solib-aix.c: Use make_scope_exit.
4881
4882 2019-03-06  Tom Tromey  <tom@tromey.com>
4883
4884         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4885         Use make_scope_exit.
4886
4887 2019-03-06  Tom Tromey  <tom@tromey.com>
4888
4889         * solib-svr4.c (disable_probes_interface): Remove parameter.
4890         (svr4_handle_solib_event): Use make_scope_exit.
4891
4892 2019-03-06  Tom Tromey  <tom@tromey.com>
4893
4894         * remote.c (struct stop_reply_deleter): Remove.
4895         (stop_reply_up): Update.
4896         (struct stop_reply): Derive from notif_event.  Don't typedef.
4897         <regcache>: Now a std::vector.
4898         (stop_reply_xfree): Remove.
4899         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4900         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4901         (remote_target::discard_pending_stop_replies): Use delete.
4902         (remote_target::remote_parse_stop_reply): Update.
4903         (remote_target::process_stop_reply): Update.
4904         * remote-notif.h (struct notif_event): Add virtual destructor.
4905         Remove "dtr" member.
4906         (struct notif_client) <alloc_event>: Return a unique_ptr.
4907         (notif_event_xfree): Don't declare.
4908         (notif_event_up): New typedef.
4909         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4910         (notif_event_xfree, do_notif_event_xfree): Remove.
4911         (remote_notif_state_xfree): Update.
4912
4913 2019-03-06  Tom Tromey  <tom@tromey.com>
4914
4915         * infrun.c (displaced_step_clear_cleanup): Now a
4916         forward_scope_exit type.
4917         (displaced_step_prepare_throw): Update.
4918         (displaced_step_fixup): Update.
4919
4920 2019-03-06  Tom Tromey  <tom@tromey.com>
4921
4922         * inferior.h (class inferior): Update comment.
4923         * gdbthread.h (class thread_info): Update comment.
4924
4925 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4926             Tom Tromey  <tom@tromey.com>
4927
4928         * stabsread.h (struct stab_section_list): Remove.
4929         (coffstab_build_psymtabs): Update.
4930         * dbxread.c (symbuf_sections): Now a std::vector.
4931         (sect_idx): New global.
4932         (fill_symbuf): Update.
4933         (coffstab_build_psymtabs): Change type of stabsects parameter.
4934         Update.
4935         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4936         std::vector.
4937         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4938         (coff_locate_sections): Update.
4939         (coff_symfile_read): Remove cleanups.  Update.
4940         (init_stringtab): Add storage parameter.
4941         (free_stringtab, free_stringtab_cleanup): Remove.
4942         (init_lineno): Add storage parameter.
4943         (free_linetab, free_linetab_cleanup): Remove.
4944
4945 2019-03-06  Pedro Alves  <palves@redhat.com>
4946
4947         * linux-fork.c (fork_info::clobber_regs): Delete.
4948         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4949         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4950         comment.  Adjust.
4951         (scoped_switch_fork_info::scoped_switch_fork_info)
4952         (checkpoint_command, linux_fork_context): Adjust
4953         fork_save_infrun_state calls.
4954
4955 2019-03-06  Pedro Alves  <palves@redhat.com>
4956
4957         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4958         (inf_has_multiple_threads): Return 'bool' and rewrite using
4959         inferior_info::threads().
4960
4961 2019-03-06  Pedro Alves  <palves@redhat.com>
4962
4963         * linux-fork.c: Include <list>.
4964         (fork_list): Now a std::list instance.
4965         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4966         (forks_exist_p, find_last_fork): Adjust.
4967         (new_fork): Delete.
4968         (one_fork_p): New.
4969         (add_fork): Adjust.
4970         (free_fork): Delete, folded into fork_info::~fork_info().
4971         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4972         Adjust.
4973         (init_fork_list): Delete.
4974         (linux_fork_killall, linux_fork_mourn_inferior)
4975         (linux_fork_detach, info_checkpoints_command): Adjust.
4976         (_initialize_linux_fork): No longer call init_fork_list.
4977
4978 2019-03-06  Pedro Alves  <palves@redhat.com>
4979
4980         * linux-fork.c (new_fork): New, split out of ...
4981         (add_fork): ... this.  Return void.  Move "first fork" special
4982         case from here, to ...
4983         (checkpoint_command): ... here.
4984         * linux-linux.h (add_fork): Return void.
4985
4986 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4987
4988         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4989
4990 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4991             Chris January  <chris.january@arm.com>
4992             David Lecomber  <david.lecomber@arm.com>
4993
4994         * f-exp.y: New token, UNOP_INTRINSIC.
4995         (exp): New pattern using UNOP_INTRINSIC token.
4996         (f77_keywords): Add 'abs' keyword.
4997         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4998         (value_from_host_double): New function.
4999         (evaluate_subexp_f): Support UNOP_ABS.
5000
5001 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5002
5003         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5004         types.
5005
5006 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5007
5008         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5009         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5010         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5011
5012 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5013
5014         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5015
5016 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5017             Chris January  <chris.january@arm.com>
5018
5019         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5020         * f-exp.y: Define 'KIND' token.
5021         (exp): New pattern for KIND expressions.
5022         (ptype): Handle types with a kind extension.
5023         (direct_abs_decl): Extend to spot kind extensions.
5024         (f77_keywords): Add 'kind' to the list.
5025         (push_kind_type): New function.
5026         (convert_to_kind_type): New function.
5027         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5028         * parse.c (operator_length_standard): Likewise.
5029         * parser-defs.h (enum type_pieces): Add tp_kind.
5030         * std-operator.def: Add UNOP_KIND.
5031
5032 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5033
5034         * f-exp.y (f_parse): Set yydebug.
5035
5036 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5037
5038         * f-lang.c (evaluate_subexp_f): New function.
5039         (exp_descriptor_f): New global.
5040         (f_language_defn): Use exp_descriptor_f instead of
5041         exp_descriptor_standard.
5042
5043 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5044
5045         * f-exp.y (struct token): Add comments.
5046         (dot_ops): Remove uppercase versions and the end marker.
5047         (f77_keywords): Likewise.
5048         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5049         entries in the dot_ops array are case insensitive, and use
5050         strncasecmp to compare strings.  Also some whitespace cleanup in
5051         this area.  Similar for the f77_keywords array, except entries in
5052         this list might be case sensitive.
5053
5054 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5055
5056         * f-exp.y (struct f77_boolean_val): Add comments.
5057         (boolean_values): Remove uppercase versions, and end marker.
5058         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5059         and use strncasecmp to achieve case insensitivity.  Additionally,
5060         perform whitespace cleanup around this code.
5061
5062 2019-03-06  Tom Tromey  <tromey@adacore.com>
5063
5064         * remote-sim.c (gdbsim_target_open): Use result of
5065         gdb_argv::release.
5066
5067 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5068         Dirk Schubert  <dirk.schubert@arm.com>
5069         Chris January  <chris.january@arm.com>
5070
5071         * eval.c (evaluate_subexp_standard): Call Fortran argument
5072         wrapping logic.
5073         * f-lang.c (struct value): A value which can be passed into a
5074         Fortran function call.
5075         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5076         where appropriate.
5077         (struct type): Value ready for a Fortran function call.
5078         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5079         is needed.
5080         * f-lang.h (fortran_argument_convert): Declaration.
5081         (fortran_preserve_arg_pointer): Declaration.
5082         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5083
5084 2019-03-05  Tom Tromey  <tromey@adacore.com>
5085
5086         * python/py-prettyprint.c (print_string_repr): Remove #if.
5087         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5088
5089 2019-03-05  Tom Tromey  <tromey@adacore.com>
5090
5091         * target.c (the_dummy_target): Move later.  Change type to
5092         "dummy_target".
5093         (initialize_targets): Don't initialize the_dummy_target.
5094
5095 2019-03-05  Tom Tromey  <tromey@adacore.com>
5096
5097         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5098         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5099
5100 2019-03-05  Tom Tromey  <tromey@adacore.com>
5101
5102         * windows-nat.c (windows_nat_target::attach)
5103         (windows_nat_target::detach): Don't call gdb_flush.
5104         * valprint.c (generic_val_print, val_print, val_print_string):
5105         Don't call gdb_flush.
5106         * utils.c (defaulted_query): Don't call gdb_flush.
5107         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5108         * target.c (target_announce_detach): Don't call gdb_flush.
5109         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5110         * remote.c (extended_remote_target::attach): Don't call
5111         gdb_flush.
5112         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5113         * printcmd.c (do_examine): Don't call gdb_flush.
5114         (info_display_command): Don't call gdb_flush.
5115         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5116         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5117         * memattr.c (info_mem_command): Don't call gdb_flush.
5118         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5119         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5120         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5121         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5122         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5123         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5124         (gnu_nat_target::detach): Don't call gdb_flush.
5125         * f-valprint.c (f_val_print): Don't call gdb_flush.
5126         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5127         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5128         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5129         gdb_flush.
5130         * c-valprint.c (c_val_print): Don't call gdb_flush.
5131         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5132
5133 2019-03-05  Tom Tromey  <tromey@adacore.com>
5134
5135         * varobj.c (update_dynamic_varobj_children): Update.
5136         (install_default_visualizer): Use reset, not release.
5137         * value.c (set_internalvar): Update.
5138         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5139         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5140         ATTRIBUTE_UNUSED_RESULT.
5141
5142 2019-03-05  Tom Tromey  <tromey@adacore.com>
5143
5144         * remote.c (class scoped_remote_fd) <release>: Add
5145         ATTRIBUTE_UNUSED_RESULT.
5146
5147 2019-03-05  Tom Tromey  <tromey@adacore.com>
5148
5149         * macroexp.c (struct macro_buffer) <release>: Add
5150         ATTRIBUTE_UNUSED_RESULT.
5151
5152 2019-03-05  Tom Tromey  <tromey@adacore.com>
5153
5154         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5155         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5156         ATTRIBUTE_UNUSED_RESULT.
5157
5158 2019-03-05  Tom Tromey  <tromey@adacore.com>
5159
5160         * common/scoped_fd.h (class scoped_fd) <release>: Add
5161         ATTRIBUTE_UNUSED_RESULT.
5162
5163 2019-03-05  Tom Tromey  <tromey@adacore.com>
5164
5165         * parser-defs.h (struct parser_state) <release>: Add
5166         ATTRIBUTE_UNUSED_RESULT.
5167
5168 2019-03-05  Tom Tromey  <tromey@adacore.com>
5169
5170         * utils.h (class gdb_argv) <release>: Add
5171         ATTRIBUTE_UNUSED_RESULT.
5172         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5173
5174 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5175
5176         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5177         for-loop range, to avoid compiler warnings.
5178
5179         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5180         avoid compiler warnings about unused variables.
5181
5182         * NEWS: Mention end of support for native debugging on MS-Windows
5183         before XP.
5184
5185         PR gdb/24292
5186         * common/netstuff.c:
5187         * gdbserver/gdbreplay.c
5188         * gdbserver/remote-utils.c:
5189         * ser-tcp.c:
5190         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5191         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5192         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5193         'getaddrinfo' and 'freeaddrinfo' were not available before
5194         Windows XP, and mingw.org's MinGW headers by default define
5195         _WIN32_WINNT to 0x500.
5196
5197 2019-03-01  Gary Benson <gbenson@redhat.com>
5198
5199         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5200
5201 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5202             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5203
5204         PR gdb/8527
5205         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5206         set_sigint_trap, clear_sigint_trap.
5207
5208 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5209
5210         * target.c (target_detach): Clear the regcache and the
5211         frame cache.
5212
5213 2019-02-27  Pedro Alves  <palves@redhat.com>
5214
5215         * utils.c (set_screen_size): When we cap the height/width sizes,
5216         tweak the corresponding command variable to show "unlimited":
5217
5218 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5219             Pedro Alves  <palves@redhat.com>
5220
5221         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5222         before calling rl_set_screen_size.
5223
5224 2019-02-27  Tom Tromey  <tromey@adacore.com>
5225
5226         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5227         define.
5228         * python/py-value.c: Remove Python 2.4 workaround.
5229         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5230         workaround.
5231         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5232         Python 2.4 workaround.
5233         * python/python-internal.h: Remove Python 2.4 comment.
5234         (Py_ssize_t): Don't define.
5235         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5236         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5237         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5238         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5239         * python/python.c (do_start_initialization): Remove Python 2.4
5240         workaround.
5241         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5242         (print_children): Remove Python 2.4 workaround.
5243         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5244         workaround.
5245         (CHARBUFFERPROC_NAME): Remove.
5246         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5247         Python 2.4 workaround.
5248
5249 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5250
5251         * NEWS: Note minimum Python version.
5252
5253 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5254
5255         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5256         code from these functions.  Remove corresponding ifdefs.  Use
5257         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5258         Remove gotos and target of gotos.
5259         (infpy_search_memory): Likewise.
5260
5261 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5262
5263         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5264         (hppa_gdbarch_init): Don't register deleted functions with
5265         gdbarch.
5266
5267 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5268
5269         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5270         (h8300_unwind_sp): Delete.
5271         (h8300_dummy_id): Delete.
5272         (h8300_gdbarch_init): Don't register deleted functions with
5273         gdbarch.
5274
5275 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5276
5277         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5278         (ft32_unwind_pc): Delete.
5279         (ft32_unwind_sp): Delete.
5280         (ft32_gdbarch_init): Don't register deleted functions with
5281         gdbarch.
5282
5283 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5284
5285         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5286         (frv_unwind_pc): Delete.
5287         (frv_unwind_sp): Delete.
5288         (frv_gdbarch_init): Don't register deleted functions with
5289         gdbarch.
5290
5291 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5292
5293         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5294         (riscv_unwind_pc): Delete.
5295         (riscv_unwind_sp): Delete.
5296         (riscv_gdbarch_init): Don't register deleted functions with
5297         gdbarch.
5298
5299 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5300
5301         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5302         (csky_unwind_pc): Delete.
5303         (csky_unwind_sp): Delete.
5304         (csky_gdbarch_init): Don't register deleted functions with
5305         gdbarch.
5306
5307 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5308
5309         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5310         (cris_unwind_pc): Delete.
5311         (cris_unwind_sp): Delete.
5312         (cris_gdbarch_init): Don't register deleted functions with
5313         gdbarch.
5314
5315 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5316
5317         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5318         (bfin_unwind_pc): Delete.
5319         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5320
5321 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5322
5323         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5324         (arm_unwind_pc): Delete.
5325         (arm_unwind_sp): Delete.
5326         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5327
5328 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5329
5330         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5331         (arc_unwind_pc): Delete.
5332         (arc_unwind_sp): Delete.
5333         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5334
5335 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5336
5337         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5338         (alpha_unwind_pc): Delete.
5339         (alpha_gdbarch_init): Don't register deleted functions with
5340         gdbarch.
5341
5342 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5343
5344         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5345         (aarch64_unwind_pc): Delete.
5346         (aarch64_unwind_sp): Delete.
5347         (aarch64_gdbarch_init): Don't register deleted functions with
5348         gdbarch.
5349
5350 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5351
5352         * gdbtypes.c (type_align): Don't consider static members when
5353         computing structure alignment.
5354
5355 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5356
5357         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5358         return 0 for other types.
5359         * arch-utils.c (default_type_align): Always return 0.
5360         * gdbarch.h: Regenerate.
5361         * gdbarch.sh (type_align): Extend comment.
5362         * gdbtypes.c (type_align): Add additional comments, always call
5363         gdbarch_type_align before applying the default rules.
5364         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5365         generic code will then apply a suitable default.
5366         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5367         types, return 0 for other types.
5368
5369 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5370
5371         * NEWS: Create a new section for the next release branch.
5372         Rename the section of the current branch, now that it has
5373         been cut.
5374
5375 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5376
5377         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5378         * version.in: Bump version to 8.3.50.DATE-git.
5379
5380 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5381
5382         * aix-thread.c (ptid_cmp): Remove unused variable.
5383         (get_signaled_thread): Likewise.
5384         (store_regs_user_thread): Likewise.
5385         (store_regs_kernel_thread): Likewise.
5386         (fetch_regs_kernel_thread): Remove shadowed variable.
5387
5388 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5389
5390         * features/riscv/32bit-cpu.xml: Add register numbers.
5391         * features/riscv/32bit-fpu.c: Regenerate.
5392         * features/riscv/32bit-fpu.xml: Add register numbers.
5393         * features/riscv/64bit-cpu.xml: Add register numbers.
5394         * features/riscv/64bit-fpu.c: Regenerate.
5395         * features/riscv/64bit-fpu.xml: Add register numbers.
5396
5397 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5398
5399         * NEWS: Mention two argument form of gdb.Value constructor.
5400         * python/py-value.c (convert_buffer_and_type_to_value): New
5401         function.
5402         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5403         Add support for handling an optional second argument.  Call
5404         convert_buffer_and_type_to_value as appropriate.
5405         * python/python-internal.h (Py_buffer_deleter): New struct.
5406         (Py_buffer_up): New typedef.
5407
5408 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5409
5410         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5411         instead of releasing ownership.
5412
5413 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5414
5415         * dwarf2read.c (open_and_init_dwp_file): Call
5416         elf_numsections instead of bfd_count_sections to initialize
5417         dwp_file->num_sections.
5418
5419 2019-02-25  Tom Tromey  <tromey@adacore.com>
5420
5421         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5422
5423 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5424
5425         * gcore.in: Add '--readnever' option when invoking GDB.
5426
5427 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5428
5429         * MAINTAINERS: Update my email address.
5430
5431 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5432
5433         * build-id.c (build_id_to_debug_bfd_1): New function.
5434         (build_id_to_debug_bfd): Look for separate debug file in
5435         sysroot.
5436
5437 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5438
5439         * gdbarch.sh: Update the copyright year range that is placed into
5440         generated files.
5441
5442 2019-02-22  Keith Seitz  <keiths@redhat.com>
5443
5444         PR symtab/23853
5445         * linespec.c (create_sals_line_offset): Search for the default
5446         symtab's filename instead of its fullname.
5447
5448 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5449
5450         * NEWS: Update style defaults.
5451
5452 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5453
5454         * main.c (captured_main_1): Disable styling in batch mode.
5455
5456 2019-02-20  Tom Tromey  <tom@tromey.com>
5457
5458         * symtab.c (symtab_symbol_info): Fix typos.
5459
5460 2019-02-20  Tom Tromey  <tromey@adacore.com>
5461
5462         * findcmd.c (_initialize_mem_search): Use upper case for
5463         metasyntactic variables.
5464
5465 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5466
5467         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5468         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5469
5470 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5471
5472         * top.h (source_file_name): Change to std::string.
5473         * top.c (source_file_name): Likewise.
5474         (command_line_input): Adjust.
5475         * cli/cli-script.c (script_from_file): Adjust.
5476
5477 2019-02-19  Tom Tromey  <tromey@adacore.com>
5478
5479         * ravenscar-thread.c
5480         (ravenscar_thread_target::update_thread_list): Don't call
5481         ada_build_task_list.
5482         * ada-lang.h (ada_build_task_list): Don't declare.
5483         * ada-tasks.c (struct ada_tasks_inferior_data)
5484         <task_list_valid_p>: Now bool.
5485         (read_known_tasks, ada_task_list_changed)
5486         (ada_tasks_invalidate_inferior_data): Update.
5487         (read_known_tasks_array): Return bool.
5488         (read_known_tasks_list): Likewise.
5489         (read_known_tasks): Return void.
5490         (ada_build_task_list): Now static.
5491
5492 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5493
5494         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5495         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5496
5497 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5498
5499         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5500         variant for ada_tasks_pspace_data_handle and
5501         ada_tasks_inferior_data_handle.
5502         (ada_tasks_pspace_data_cleanup): New function.
5503         (ada_tasks_inferior_data_cleanup): New function.
5504
5505 2019-02-17  Tom Tromey  <tom@tromey.com>
5506
5507         * macrotab.h (macro_source_fullname): Return a std::string.
5508         * macrotab.c (macro_include, check_for_redefinition)
5509         (macro_undef, macro_lookup_definition, foreach_macro)
5510         (foreach_macro_in_scope): Update.
5511         (macro_source_fullname): Return a std::string.
5512         * macrocmd.c (show_pp_source_pos): Update.
5513
5514 2019-02-17  Tom Tromey  <tom@tromey.com>
5515
5516         * macrocmd.c (show_pp_source_pos): Style the file names.
5517
5518 2019-02-17  Tom Tromey  <tom@tromey.com>
5519
5520         PR tui/24197:
5521         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5522
5523 2019-02-17  Tom Tromey  <tom@tromey.com>
5524
5525         * ada-lang.c (user_select_syms): Use filtered printing.
5526         * utils.c (wrap_style): New global.
5527         (desired_style): Remove.
5528         (emit_style_escape): Add stream parameter.
5529         (set_output_style, reset_terminal_style, prompt_for_continue):
5530         Update.
5531         (flush_wrap_buffer): Only flush gdb_stdout.
5532         (wrap_here): Set wrap_style.
5533         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5534         treat escape sequences as a character.  Change when wrap buffer is
5535         flushed.
5536         (fputs_styled): Do not set the output style when the default is
5537         requested.
5538         * ui-style.h (struct ui_file_style) <is_default>: New method.
5539         * source.c (print_source_lines_base): Emit escape sequences in one
5540         piece.
5541
5542 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5543
5544         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5545         integers and enumeration types.
5546
5547 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5548
5549         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5550         instead of lookup_symbol_in_language
5551         (do_exact_match): New function.
5552         (ada_get_symbol_name_matcher): Return do_exact_match when
5553         doing a verbatim match.
5554
5555 2019-02-15  Tom Tromey  <tromey@adacore.com>
5556
5557         * ravenscar-thread.c (ravenscar_thread_target::resume)
5558         (ravenscar_thread_target::wait): Special case wildcard requests.
5559
5560 2019-02-15  Tom Tromey  <tromey@adacore.com>
5561
5562         * ravenscar-thread.c (base_ptid): Remove.
5563         (struct ravenscar_thread_target) <close>: New method.
5564         <m_base_ptid>: New member.
5565         <update_inferior_ptid, active_task, task_is_currently_active,
5566         runtime_initialized>: Declare methods.
5567         <ravenscar_thread_target>: Add constructor.
5568         (ravenscar_thread_target::task_is_currently_active)
5569         (ravenscar_thread_target::update_inferior_ptid)
5570         (ravenscar_runtime_initialized): Rename.  Now methods.
5571         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5572         (ravenscar_thread_target::update_thread_list): Update.
5573         (ravenscar_thread_target::active_task): Now method.
5574         (ravenscar_thread_target::store_registers)
5575         (ravenscar_thread_target::prepare_to_store)
5576         (ravenscar_thread_target::prepare_to_store)
5577         (ravenscar_thread_target::mourn_inferior): Update.
5578         (ravenscar_inferior_created): Use "new" to create target.
5579         (ravenscar_thread_target::get_ada_task_ptid): Update.
5580         (_initialize_ravenscar): Don't initialize base_ptid.
5581         (ravenscar_ops): Remove global.
5582
5583 2019-02-15  Tom Tromey  <tromey@adacore.com>
5584
5585         * target.h (push_target): Declare new overload.
5586         * target.c (push_target): New overload, taking an rvalue reference.
5587         * remote.c (remote_target::open_1): Use push_target overload.
5588         * corelow.c (core_target_open): Use push_target overload.
5589
5590 2019-02-15  Tom Tromey  <tromey@adacore.com>
5591
5592         * ravenscar-thread.c (is_ravenscar_task)
5593         (ravenscar_task_is_currently_active): Return bool.
5594         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5595         (_initialize_ravenscar): Remove "(void)".
5596         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5597         Return bool.
5598
5599 2019-02-15  Tom Tromey  <tromey@adacore.com>
5600
5601         * ravenscar-thread.c (ravenscar_runtime_initializer)
5602         (has_ravenscar_runtime, get_running_thread_id)
5603         (ravenscar_thread_target::resume): Fix indentation.
5604
5605 2019-02-15  Tom Tromey  <tromey@adacore.com>
5606
5607         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5608         from ravenscar_arch_ops.
5609         (sparc_ravenscar_ops::fetch_registers)
5610         (sparc_ravenscar_ops::store_registers): Now methods.
5611         (sparc_ravenscar_prepare_to_store): Remove.
5612         (sparc_ravenscar_ops): Redefine.
5613         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5614         methods and destructor.  Remove members.
5615         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5616         (ravenscar_thread_target::store_registers)
5617         (ravenscar_thread_target::prepare_to_store): Update.
5618         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5619         Remove.
5620         (struct ppc_ravenscar_powerpc_ops): Derive from
5621         ravenscar_arch_ops.
5622         (ppc_ravenscar_powerpc_ops::fetch_registers)
5623         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5624         (ppc_ravenscar_powerpc_ops): Redefine.
5625         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5626         (ppc_ravenscar_e500_ops::fetch_registers)
5627         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5628         (ppc_ravenscar_e500_ops): Redefine.
5629         * aarch64-ravenscar-thread.c
5630         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5631         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5632         (aarch64_ravenscar_fetch_registers)
5633         (aarch64_ravenscar_store_registers): Now methods.
5634         (aarch64_ravenscar_ops): Redefine.
5635
5636 2019-02-15  Tom Tromey  <tromey@adacore.com>
5637
5638         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5639         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5640         (ravenscar_thread_target::stopped_by_watchpoint)
5641         (ravenscar_thread_target::stopped_data_address)
5642         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5643
5644 2019-02-15  Tom Tromey  <tromey@adacore.com>
5645
5646         * ravenscar-thread.c: Fix some typos.
5647
5648 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5649             Tom Tromey  <tromey@adacore.com>
5650
5651         * ada-lang.c (ada_exception_sal): Change addr_string to a
5652         std::string.
5653         (create_ada_exception_catchpoint): Update.
5654
5655 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5656             Tom Tromey  <tromey@adacore.com>
5657
5658         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5659         (bp_location_ops): Remove.
5660         (base_breakpoint_allocate_location): Update.
5661         (free_bp_location): Update.
5662         * ada-lang.c (class ada_catchpoint_location)
5663         <ada_catchpoint_location>: Remove ops parameter.
5664         (ada_catchpoint_location_dtor): Remove.
5665         (ada_catchpoint_location_ops): Remove.
5666         (allocate_location_exception): Update.
5667         * breakpoint.h (struct bp_location_ops): Remove.
5668         (class bp_location) <bp_location>: Remove bp_location_ops
5669         parameter.
5670         <~bp_location>: Add destructor.
5671         <ops>: Remove.
5672
5673 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5674             Pedro Alves  <palves@redhat.com>
5675
5676         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5677         'PATH_MAX'.
5678
5679 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5680             Samuel Thibault  <samuel.thibault@gnu.org>
5681             Thomas Schwinge  <thomas@codesourcery.com>
5682
5683         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5684         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5685
5686 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5687
5688         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5689         (check_empty): Use "const char *".
5690
5691         * gnu-nat.c (gnu_nat_target::detach): Instead of
5692         'detach_inferior (pid)' call
5693         'detach_inferior (find_inferior_pid (pid))'.
5694
5695         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5696         'nat/fork-inferior.o'.
5697         * gnu-nat.c: #include "nat/fork-inferior.h".
5698
5699         * gnu-nat.c (gnu_nat_target::detach): Instead of
5700         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5701         * gnu-nat.h: #include "inf-child.h".
5702         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5703         'i386_gnu_nat_target::fetch_registers'.
5704         (gnu_store_registers): Rename/move to
5705         'i386_gnu_nat_target::store_registers'.
5706
5707         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5708         * gnu-nat.h (mach_thread_info): New function.
5709         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5710
5711         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5712
5713 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5714
5715         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5716
5717 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5718
5719         * windows-nat.c (windows_add_thread): Add new parameter
5720         "main_thread_p" with default value set to false.  Update
5721         function documentation as well as all callers.
5722         (windows_delete_thread): Likewise.
5723         (fake_create_process): Update call to windows_add_thread.
5724         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5725         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5726         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5727         call to windows_delete_thread.
5728
5729 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5730
5731         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5732
5733 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5734
5735         * symfile.c (find_separate_debug_file): Use canonical path of
5736         sysroot with child_path instead of gdb_sysroot if it is valid.
5737
5738 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5739
5740         * symfile.c (find_separate_debug_file): Use child_path to
5741         determine if an object file is under a sysroot.
5742
5743 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5744
5745         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5746         unittests/child-path-selftests.c.
5747         * common/pathstuff.c (child_path): New function.
5748         * common/pathstuff.h (child_path): New prototype.
5749         * unittests/child-path-selftests.c: New file.
5750
5751 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5752
5753         * symfile.c (find_separate_debug_file): Look for separate debug
5754         files in debug directories under the sysroot.
5755
5756 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5757
5758         * symtab.h (struct minimal_symbol data_p): New const method.
5759         (struct minimal_symbol text_p): Likewise.
5760         * symtab.c (output_source_filename): Use file name style
5761         to print file name.
5762         (print_symbol_info): Likewise.
5763         (print_msymbol_info): Use address style to print addresses.
5764         Use function name style to print executable text symbols.
5765         (expand_symtab_containing_pc): Use data_p.
5766         (find_pc_sect_compunit_symtab): Likewise.
5767
5768 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5769
5770         * breakpoint.c (describe_other_breakpoints): Use address style
5771         to print addresses.
5772         (say_where): Likewise.
5773
5774 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5775
5776         * ada-typeprint.c (print_func_type): Print function name
5777         style to print function name.
5778         * c-typeprint.c (c_print_type_1): Likewise.
5779
5780 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5781
5782         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5783         for execve.
5784
5785 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5786
5787         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5788         type_stack.
5789
5790 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5791
5792         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5793         TYPE_CODE_REF types.
5794
5795 2019-02-08  Jim Wilson  <jimw@sifive.com>
5796
5797         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5798         (riscv_linux_fregset): New.
5799         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5800
5801 2019-02-07  Tom Tromey  <tom@tromey.com>
5802
5803         * thread.c (thread_cancel_execution_command): Update.
5804         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5805         methods.
5806         (struct thread_fsm_ops): Remove.
5807         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5808         (thread_fsm_should_stop, thread_fsm_return_value)
5809         (thread_fsm_set_finished, thread_fsm_finished_p)
5810         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5811         Don't declare.
5812         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5813         * infrun.c (clear_proceed_status_thread)
5814         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5815         (print_stop_event): Update.
5816         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5817         Add constructor.
5818         (step_command_fsm_ops): Remove.
5819         (new_step_command_fsm): Remove.
5820         (step_1): Update.
5821         (step_command_fsm::should_stop): Rename from
5822         step_command_fsm_should_stop.
5823         (step_command_fsm::clean_up): Rename from
5824         step_command_fsm_clean_up.
5825         (step_command_fsm::do_async_reply_reason): Rename from
5826         step_command_fsm_async_reply_reason.
5827         (struct until_next_fsm): Inherit from thread_fsm.  Add
5828         constructor.
5829         (until_next_fsm_ops): Remove.
5830         (new_until_next_fsm): Remove.
5831         (until_next_fsm::should_stop): Rename from
5832         until_next_fsm_should_stop.
5833         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5834         (until_next_fsm::do_async_reply_reason): Rename from
5835         until_next_fsm_async_reply_reason.
5836         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5837         constructor.  Change type of breakpoint.
5838         (finish_command_fsm_ops): Remove.
5839         (new_finish_command_fsm): Remove.
5840         (finish_command_fsm::should_stop): Rename from
5841         finish_command_fsm_should_stop.
5842         (finish_command_fsm::clean_up): Rename from
5843         finish_command_fsm_clean_up.
5844         (finish_command_fsm::return_value): Rename from
5845         finish_command_fsm_return_value.
5846         (finish_command_fsm::do_async_reply_reason): Rename from
5847         finish_command_fsm_async_reply_reason.
5848         (finish_command): Update.
5849         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5850         Add constructor.
5851         (call_thread_fsm_ops): Remove.
5852         (call_thread_fsm::call_thread_fsm): Rename from
5853         new_call_thread_fsm.
5854         (call_thread_fsm::should_stop): Rename from
5855         call_thread_fsm_should_stop.
5856         (call_thread_fsm::should_notify_stop): Rename from
5857         call_thread_fsm_should_notify_stop.
5858         (run_inferior_call, call_function_by_hand_dummy): Update.
5859         * cli/cli-interp.c (should_print_stop_to_console): Update.
5860         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5861         Add constructor.  Change type of location_breakpoint,
5862         caller_breakpoint.
5863         (until_break_fsm_ops): Remove.
5864         (new_until_break_fsm): Remove.
5865         (until_break_fsm::should_stop): Rename from
5866         until_break_fsm_should_stop.
5867         (until_break_fsm::clean_up): Rename from
5868         until_break_fsm_clean_up.
5869         (until_break_fsm::do_async_reply_reason): Rename from
5870         until_break_fsm_async_reply_reason.
5871         (until_break_command): Update.
5872         * thread-fsm.c: Remove.
5873         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5874
5875 2019-02-07  Tom Tromey  <tom@tromey.com>
5876
5877         * yy-remap.h: Add include guard.
5878         * xtensa-tdep.h: Add include guard.
5879         * xcoffread.h: Rename include guard.
5880         * varobj-iter.h: Add include guard.
5881         * tui/tui.h: Rename include guard.
5882         * tui/tui-winsource.h: Rename include guard.
5883         * tui/tui-wingeneral.h: Rename include guard.
5884         * tui/tui-windata.h: Rename include guard.
5885         * tui/tui-win.h: Rename include guard.
5886         * tui/tui-stack.h: Rename include guard.
5887         * tui/tui-source.h: Rename include guard.
5888         * tui/tui-regs.h: Rename include guard.
5889         * tui/tui-out.h: Rename include guard.
5890         * tui/tui-layout.h: Rename include guard.
5891         * tui/tui-io.h: Rename include guard.
5892         * tui/tui-hooks.h: Rename include guard.
5893         * tui/tui-file.h: Rename include guard.
5894         * tui/tui-disasm.h: Rename include guard.
5895         * tui/tui-data.h: Rename include guard.
5896         * tui/tui-command.h: Rename include guard.
5897         * tic6x-tdep.h: Add include guard.
5898         * target/waitstatus.h: Rename include guard.
5899         * target/wait.h: Rename include guard.
5900         * target/target.h: Rename include guard.
5901         * target/resume.h: Rename include guard.
5902         * target-float.h: Rename include guard.
5903         * stabsread.h: Add include guard.
5904         * rs6000-tdep.h: Add include guard.
5905         * riscv-fbsd-tdep.h: Add include guard.
5906         * regformats/regdef.h: Rename include guard.
5907         * record.h: Rename include guard.
5908         * python/python.h: Rename include guard.
5909         * python/python-internal.h: Rename include guard.
5910         * python/py-stopevent.h: Rename include guard.
5911         * python/py-ref.h: Rename include guard.
5912         * python/py-record.h: Rename include guard.
5913         * python/py-record-full.h: Rename include guard.
5914         * python/py-record-btrace.h: Rename include guard.
5915         * python/py-instruction.h: Rename include guard.
5916         * python/py-events.h: Rename include guard.
5917         * python/py-event.h: Rename include guard.
5918         * procfs.h: Add include guard.
5919         * proc-utils.h: Add include guard.
5920         * p-lang.h: Add include guard.
5921         * or1k-tdep.h: Rename include guard.
5922         * observable.h: Rename include guard.
5923         * nto-tdep.h: Rename include guard.
5924         * nat/x86-linux.h: Rename include guard.
5925         * nat/x86-linux-dregs.h: Rename include guard.
5926         * nat/x86-gcc-cpuid.h: Add include guard.
5927         * nat/x86-dregs.h: Rename include guard.
5928         * nat/x86-cpuid.h: Rename include guard.
5929         * nat/ppc-linux.h: Rename include guard.
5930         * nat/mips-linux-watch.h: Rename include guard.
5931         * nat/linux-waitpid.h: Rename include guard.
5932         * nat/linux-ptrace.h: Rename include guard.
5933         * nat/linux-procfs.h: Rename include guard.
5934         * nat/linux-osdata.h: Rename include guard.
5935         * nat/linux-nat.h: Rename include guard.
5936         * nat/linux-namespaces.h: Rename include guard.
5937         * nat/linux-btrace.h: Rename include guard.
5938         * nat/glibc_thread_db.h: Rename include guard.
5939         * nat/gdb_thread_db.h: Rename include guard.
5940         * nat/gdb_ptrace.h: Rename include guard.
5941         * nat/fork-inferior.h: Rename include guard.
5942         * nat/amd64-linux-siginfo.h: Rename include guard.
5943         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5944         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5945         * nat/aarch64-linux.h: Rename include guard.
5946         * nat/aarch64-linux-hw-point.h: Rename include guard.
5947         * mn10300-tdep.h: Add include guard.
5948         * mips-linux-tdep.h: Add include guard.
5949         * mi/mi-parse.h: Rename include guard.
5950         * mi/mi-out.h: Rename include guard.
5951         * mi/mi-main.h: Rename include guard.
5952         * mi/mi-interp.h: Rename include guard.
5953         * mi/mi-getopt.h: Rename include guard.
5954         * mi/mi-console.h: Rename include guard.
5955         * mi/mi-common.h: Rename include guard.
5956         * mi/mi-cmds.h: Rename include guard.
5957         * mi/mi-cmd-break.h: Rename include guard.
5958         * m2-lang.h: Add include guard.
5959         * location.h: Rename include guard.
5960         * linux-record.h: Rename include guard.
5961         * linux-nat.h: Add include guard.
5962         * linux-fork.h: Add include guard.
5963         * i386-darwin-tdep.h: Rename include guard.
5964         * hppa-linux-offsets.h: Add include guard.
5965         * guile/guile.h: Rename include guard.
5966         * guile/guile-internal.h: Rename include guard.
5967         * gnu-nat.h: Rename include guard.
5968         * gdb-stabs.h: Rename include guard.
5969         * frv-tdep.h: Add include guard.
5970         * f-lang.h: Add include guard.
5971         * event-loop.h: Add include guard.
5972         * darwin-nat.h: Rename include guard.
5973         * cp-abi.h: Rename include guard.
5974         * config/sparc/nm-sol2.h: Rename include guard.
5975         * config/nm-nto.h: Rename include guard.
5976         * config/nm-linux.h: Add include guard.
5977         * config/i386/nm-i386gnu.h: Rename include guard.
5978         * config/djgpp/nl_types.h: Rename include guard.
5979         * config/djgpp/langinfo.h: Rename include guard.
5980         * compile/gcc-cp-plugin.h: Add include guard.
5981         * compile/gcc-c-plugin.h: Add include guard.
5982         * compile/compile.h: Rename include guard.
5983         * compile/compile-object-run.h: Rename include guard.
5984         * compile/compile-object-load.h: Rename include guard.
5985         * compile/compile-internal.h: Rename include guard.
5986         * compile/compile-cplus.h: Rename include guard.
5987         * compile/compile-c.h: Rename include guard.
5988         * common/xml-utils.h: Rename include guard.
5989         * common/x86-xstate.h: Rename include guard.
5990         * common/version.h: Rename include guard.
5991         * common/vec.h: Rename include guard.
5992         * common/tdesc.h: Rename include guard.
5993         * common/selftest.h: Rename include guard.
5994         * common/scoped_restore.h: Rename include guard.
5995         * common/scoped_mmap.h: Rename include guard.
5996         * common/scoped_fd.h: Rename include guard.
5997         * common/safe-iterator.h: Rename include guard.
5998         * common/run-time-clock.h: Rename include guard.
5999         * common/refcounted-object.h: Rename include guard.
6000         * common/queue.h: Rename include guard.
6001         * common/ptid.h: Rename include guard.
6002         * common/print-utils.h: Rename include guard.
6003         * common/preprocessor.h: Rename include guard.
6004         * common/pathstuff.h: Rename include guard.
6005         * common/observable.h: Rename include guard.
6006         * common/netstuff.h: Rename include guard.
6007         * common/job-control.h: Rename include guard.
6008         * common/host-defs.h: Rename include guard.
6009         * common/gdb_wait.h: Rename include guard.
6010         * common/gdb_vecs.h: Rename include guard.
6011         * common/gdb_unlinker.h: Rename include guard.
6012         * common/gdb_unique_ptr.h: Rename include guard.
6013         * common/gdb_tilde_expand.h: Rename include guard.
6014         * common/gdb_sys_time.h: Rename include guard.
6015         * common/gdb_string_view.h: Rename include guard.
6016         * common/gdb_splay_tree.h: Rename include guard.
6017         * common/gdb_setjmp.h: Rename include guard.
6018         * common/gdb_ref_ptr.h: Rename include guard.
6019         * common/gdb_optional.h: Rename include guard.
6020         * common/gdb_locale.h: Rename include guard.
6021         * common/gdb_assert.h: Rename include guard.
6022         * common/filtered-iterator.h: Rename include guard.
6023         * common/filestuff.h: Rename include guard.
6024         * common/fileio.h: Rename include guard.
6025         * common/environ.h: Rename include guard.
6026         * common/common-utils.h: Rename include guard.
6027         * common/common-types.h: Rename include guard.
6028         * common/common-regcache.h: Rename include guard.
6029         * common/common-inferior.h: Rename include guard.
6030         * common/common-gdbthread.h: Rename include guard.
6031         * common/common-exceptions.h: Rename include guard.
6032         * common/common-defs.h: Rename include guard.
6033         * common/common-debug.h: Rename include guard.
6034         * common/cleanups.h: Rename include guard.
6035         * common/buffer.h: Rename include guard.
6036         * common/btrace-common.h: Rename include guard.
6037         * common/break-common.h: Rename include guard.
6038         * cli/cli-utils.h: Rename include guard.
6039         * cli/cli-style.h: Rename include guard.
6040         * cli/cli-setshow.h: Rename include guard.
6041         * cli/cli-script.h: Rename include guard.
6042         * cli/cli-interp.h: Rename include guard.
6043         * cli/cli-decode.h: Rename include guard.
6044         * cli/cli-cmds.h: Rename include guard.
6045         * charset-list.h: Add include guard.
6046         * buildsym-legacy.h: Rename include guard.
6047         * bfin-tdep.h: Add include guard.
6048         * ax.h: Rename include guard.
6049         * arm-linux-tdep.h: Add include guard.
6050         * arm-fbsd-tdep.h: Add include guard.
6051         * arch/xtensa.h: Rename include guard.
6052         * arch/tic6x.h: Add include guard.
6053         * arch/i386.h: Add include guard.
6054         * arch/arm.h: Rename include guard.
6055         * arch/arm-linux.h: Rename include guard.
6056         * arch/arm-get-next-pcs.h: Rename include guard.
6057         * arch/amd64.h: Add include guard.
6058         * arch/aarch64-insn.h: Rename include guard.
6059         * arch-utils.h: Rename include guard.
6060         * annotate.h: Add include guard.
6061         * amd64-darwin-tdep.h: Rename include guard.
6062         * aarch64-linux-tdep.h: Add include guard.
6063         * aarch64-fbsd-tdep.h: Add include guard.
6064         * aarch32-linux-nat.h: Add include guard.
6065
6066 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6067
6068         * macrotab.c (macro_define_internal): New function that
6069         factorizes macro_define_object_internal and macro_define_function
6070         code.
6071         (macro_define_object_internal): Use macro_define_internal.
6072         (macro_define_function): Likewise.
6073
6074 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6075
6076         * macrocmd.c (extract_identifier): Return
6077         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6078         callers.
6079
6080 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6081
6082         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6083
6084 2019-02-05  Tom Tromey  <tom@tromey.com>
6085
6086         * target.c (target_stack::unpush): Move assertion earlier.
6087
6088 2019-01-30  Tom Tromey  <tom@tromey.com>
6089
6090         PR python/23615:
6091         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6092         (gdbpy_parse_and_eval): Likewise.
6093         * python/python-internal.h (gdbpy_allow_threads): New class.
6094
6095 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6096
6097         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6098         (aarch64_fbsd_fpregmap): Move earlier.
6099         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6100         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6101         instead of individual calls to trad_frame_set_reg_addr.
6102         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6103         earlier.
6104         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6105         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6106         instead of individual calls to trad_frame_set_reg_addr.
6107
6108 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6109
6110         * CONTRIBUTE: Replace contribution list with wiki link.
6111
6112 2019-01-25  Tom Tromey  <tom@tromey.com>
6113
6114         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6115
6116 2019-01-25  Tom Tromey  <tom@tromey.com>
6117
6118         * xtensa-linux-nat.c: Fix common/ includes.
6119         * xml-support.h: Fix common/ includes.
6120         * xml-support.c: Fix common/ includes.
6121         * x86-linux-nat.c: Fix common/ includes.
6122         * windows-nat.c: Fix common/ includes.
6123         * varobj.h: Fix common/ includes.
6124         * varobj.c: Fix common/ includes.
6125         * value.c: Fix common/ includes.
6126         * valops.c: Fix common/ includes.
6127         * utils.c: Fix common/ includes.
6128         * unittests/xml-utils-selftests.c: Fix common/ includes.
6129         * unittests/utils-selftests.c: Fix common/ includes.
6130         * unittests/unpack-selftests.c: Fix common/ includes.
6131         * unittests/tracepoint-selftests.c: Fix common/ includes.
6132         * unittests/style-selftests.c: Fix common/ includes.
6133         * unittests/string_view-selftests.c: Fix common/ includes.
6134         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6135         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6136         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6137         * unittests/rsp-low-selftests.c: Fix common/ includes.
6138         * unittests/parse-connection-spec-selftests.c: Fix common/
6139         includes.
6140         * unittests/optional-selftests.c: Fix common/ includes.
6141         * unittests/offset-type-selftests.c: Fix common/ includes.
6142         * unittests/observable-selftests.c: Fix common/ includes.
6143         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6144         * unittests/memrange-selftests.c: Fix common/ includes.
6145         * unittests/memory-map-selftests.c: Fix common/ includes.
6146         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6147         * unittests/function-view-selftests.c: Fix common/ includes.
6148         * unittests/environ-selftests.c: Fix common/ includes.
6149         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6150         * unittests/common-utils-selftests.c: Fix common/ includes.
6151         * unittests/cli-utils-selftests.c: Fix common/ includes.
6152         * unittests/array-view-selftests.c: Fix common/ includes.
6153         * ui-file.c: Fix common/ includes.
6154         * tui/tui-io.c: Fix common/ includes.
6155         * tracepoint.h: Fix common/ includes.
6156         * tracepoint.c: Fix common/ includes.
6157         * tracefile-tfile.c: Fix common/ includes.
6158         * top.h: Fix common/ includes.
6159         * top.c: Fix common/ includes.
6160         * thread.c: Fix common/ includes.
6161         * target/waitstatus.h: Fix common/ includes.
6162         * target/waitstatus.c: Fix common/ includes.
6163         * target.h: Fix common/ includes.
6164         * target.c: Fix common/ includes.
6165         * target-memory.c: Fix common/ includes.
6166         * target-descriptions.c: Fix common/ includes.
6167         * symtab.h: Fix common/ includes.
6168         * symfile.c: Fix common/ includes.
6169         * stap-probe.c: Fix common/ includes.
6170         * spu-linux-nat.c: Fix common/ includes.
6171         * sparc-nat.c: Fix common/ includes.
6172         * source.c: Fix common/ includes.
6173         * solib.c: Fix common/ includes.
6174         * solib-target.c: Fix common/ includes.
6175         * ser-unix.c: Fix common/ includes.
6176         * ser-tcp.c: Fix common/ includes.
6177         * ser-pipe.c: Fix common/ includes.
6178         * ser-base.c: Fix common/ includes.
6179         * selftest-arch.c: Fix common/ includes.
6180         * s12z-tdep.c: Fix common/ includes.
6181         * rust-exp.y: Fix common/ includes.
6182         * rs6000-aix-tdep.c: Fix common/ includes.
6183         * riscv-tdep.c: Fix common/ includes.
6184         * remote.c: Fix common/ includes.
6185         * remote-notif.h: Fix common/ includes.
6186         * remote-fileio.h: Fix common/ includes.
6187         * remote-fileio.c: Fix common/ includes.
6188         * regcache.h: Fix common/ includes.
6189         * regcache.c: Fix common/ includes.
6190         * record-btrace.c: Fix common/ includes.
6191         * python/python.c: Fix common/ includes.
6192         * python/py-type.c: Fix common/ includes.
6193         * python/py-inferior.c: Fix common/ includes.
6194         * progspace.h: Fix common/ includes.
6195         * producer.c: Fix common/ includes.
6196         * procfs.c: Fix common/ includes.
6197         * proc-api.c: Fix common/ includes.
6198         * printcmd.c: Fix common/ includes.
6199         * ppc-linux-nat.c: Fix common/ includes.
6200         * parser-defs.h: Fix common/ includes.
6201         * osdata.c: Fix common/ includes.
6202         * obsd-nat.c: Fix common/ includes.
6203         * nat/x86-linux.c: Fix common/ includes.
6204         * nat/x86-linux-dregs.c: Fix common/ includes.
6205         * nat/x86-dregs.h: Fix common/ includes.
6206         * nat/x86-dregs.c: Fix common/ includes.
6207         * nat/ppc-linux.c: Fix common/ includes.
6208         * nat/mips-linux-watch.h: Fix common/ includes.
6209         * nat/mips-linux-watch.c: Fix common/ includes.
6210         * nat/linux-waitpid.c: Fix common/ includes.
6211         * nat/linux-ptrace.h: Fix common/ includes.
6212         * nat/linux-ptrace.c: Fix common/ includes.
6213         * nat/linux-procfs.c: Fix common/ includes.
6214         * nat/linux-personality.c: Fix common/ includes.
6215         * nat/linux-osdata.c: Fix common/ includes.
6216         * nat/linux-namespaces.c: Fix common/ includes.
6217         * nat/linux-btrace.h: Fix common/ includes.
6218         * nat/linux-btrace.c: Fix common/ includes.
6219         * nat/fork-inferior.c: Fix common/ includes.
6220         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6221         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6222         * nat/aarch64-linux.c: Fix common/ includes.
6223         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6224         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6225         * namespace.h: Fix common/ includes.
6226         * mips-linux-tdep.c: Fix common/ includes.
6227         * minsyms.c: Fix common/ includes.
6228         * mi/mi-parse.h: Fix common/ includes.
6229         * mi/mi-main.c: Fix common/ includes.
6230         * mi/mi-cmd-env.c: Fix common/ includes.
6231         * memrange.h: Fix common/ includes.
6232         * memattr.c: Fix common/ includes.
6233         * maint.h: Fix common/ includes.
6234         * maint.c: Fix common/ includes.
6235         * main.c: Fix common/ includes.
6236         * machoread.c: Fix common/ includes.
6237         * location.c: Fix common/ includes.
6238         * linux-thread-db.c: Fix common/ includes.
6239         * linux-nat.c: Fix common/ includes.
6240         * linux-fork.c: Fix common/ includes.
6241         * inline-frame.c: Fix common/ includes.
6242         * infrun.c: Fix common/ includes.
6243         * inflow.c: Fix common/ includes.
6244         * inferior.h: Fix common/ includes.
6245         * inferior.c: Fix common/ includes.
6246         * infcmd.c: Fix common/ includes.
6247         * inf-ptrace.c: Fix common/ includes.
6248         * inf-child.c: Fix common/ includes.
6249         * ia64-linux-nat.c: Fix common/ includes.
6250         * i387-tdep.c: Fix common/ includes.
6251         * i386-tdep.c: Fix common/ includes.
6252         * i386-linux-tdep.c: Fix common/ includes.
6253         * i386-linux-nat.c: Fix common/ includes.
6254         * i386-go32-tdep.c: Fix common/ includes.
6255         * i386-fbsd-tdep.c: Fix common/ includes.
6256         * i386-fbsd-nat.c: Fix common/ includes.
6257         * guile/scm-type.c: Fix common/ includes.
6258         * guile/guile.c: Fix common/ includes.
6259         * go32-nat.c: Fix common/ includes.
6260         * gnu-nat.c: Fix common/ includes.
6261         * gdbthread.h: Fix common/ includes.
6262         * gdbarch-selftests.c: Fix common/ includes.
6263         * gdb_usleep.c: Fix common/ includes.
6264         * gdb_select.h: Fix common/ includes.
6265         * gdb_bfd.c: Fix common/ includes.
6266         * gcore.c: Fix common/ includes.
6267         * fork-child.c: Fix common/ includes.
6268         * findvar.c: Fix common/ includes.
6269         * fbsd-nat.c: Fix common/ includes.
6270         * event-top.c: Fix common/ includes.
6271         * event-loop.c: Fix common/ includes.
6272         * dwarf2read.c: Fix common/ includes.
6273         * dwarf2loc.c: Fix common/ includes.
6274         * dwarf2-frame.c: Fix common/ includes.
6275         * dwarf-index-cache.c: Fix common/ includes.
6276         * dtrace-probe.c: Fix common/ includes.
6277         * disasm-selftests.c: Fix common/ includes.
6278         * defs.h: Fix common/ includes.
6279         * csky-tdep.c: Fix common/ includes.
6280         * cp-valprint.c: Fix common/ includes.
6281         * cp-support.h: Fix common/ includes.
6282         * cp-support.c: Fix common/ includes.
6283         * corelow.c: Fix common/ includes.
6284         * completer.h: Fix common/ includes.
6285         * completer.c: Fix common/ includes.
6286         * compile/compile.c: Fix common/ includes.
6287         * compile/compile-loc2c.c: Fix common/ includes.
6288         * compile/compile-cplus-types.c: Fix common/ includes.
6289         * compile/compile-cplus-symbols.c: Fix common/ includes.
6290         * command.h: Fix common/ includes.
6291         * cli/cli-dump.c: Fix common/ includes.
6292         * cli/cli-cmds.c: Fix common/ includes.
6293         * charset.c: Fix common/ includes.
6294         * build-id.c: Fix common/ includes.
6295         * btrace.h: Fix common/ includes.
6296         * btrace.c: Fix common/ includes.
6297         * breakpoint.h: Fix common/ includes.
6298         * breakpoint.c: Fix common/ includes.
6299         * ax.h:
6300         (enum agent_op): Fix common/ includes.
6301         * ax-general.c (struct aop_map): Fix common/ includes.
6302         * ax-gdb.c: Fix common/ includes.
6303         * auxv.c: Fix common/ includes.
6304         * auto-load.c: Fix common/ includes.
6305         * arm-tdep.c: Fix common/ includes.
6306         * arch/riscv.c: Fix common/ includes.
6307         * arch/ppc-linux-common.c: Fix common/ includes.
6308         * arch/i386.c: Fix common/ includes.
6309         * arch/arm.c: Fix common/ includes.
6310         * arch/arm-linux.c: Fix common/ includes.
6311         * arch/arm-get-next-pcs.c: Fix common/ includes.
6312         * arch/amd64.c: Fix common/ includes.
6313         * arch/aarch64.c: Fix common/ includes.
6314         * arch/aarch64-insn.c: Fix common/ includes.
6315         * arch-utils.c: Fix common/ includes.
6316         * amd64-windows-tdep.c: Fix common/ includes.
6317         * amd64-tdep.c: Fix common/ includes.
6318         * amd64-sol2-tdep.c: Fix common/ includes.
6319         * amd64-obsd-tdep.c: Fix common/ includes.
6320         * amd64-nbsd-tdep.c: Fix common/ includes.
6321         * amd64-linux-tdep.c: Fix common/ includes.
6322         * amd64-linux-nat.c: Fix common/ includes.
6323         * amd64-fbsd-tdep.c: Fix common/ includes.
6324         * amd64-fbsd-nat.c: Fix common/ includes.
6325         * amd64-dicos-tdep.c: Fix common/ includes.
6326         * amd64-darwin-tdep.c: Fix common/ includes.
6327         * agent.c: Fix common/ includes.
6328         * ada-lang.h: Fix common/ includes.
6329         * ada-lang.c: Fix common/ includes.
6330         * aarch64-tdep.c: Fix common/ includes.
6331
6332 2019-01-25  Tom Tromey  <tom@tromey.com>
6333
6334         * common/create-version.sh: Use common/version.h.
6335
6336 2019-01-24  Pedro Alves  <palves@redhat.com>
6337
6338         * infrun.c (signal_stop, signal_print, signal_program)
6339         (signal_catch, signal_pass): Now arrays instead of pointers.
6340         (update_signals_program_target, do_target_resume)
6341         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6342         * linux-nat.c (linux_nat_target::pass_signals)
6343         (linux_nat_target::create_inferior, linux_nat_target::attach):
6344         Adjust.
6345         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6346         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6347         * procfs.c (procfs_target::pass_signals): Adjust.
6348         * record-full.c (record_full_target::resume): Adjust.
6349         * remote.c (remote_target::pass_signals)
6350         (remote_target::program_signals): Adjust.
6351         * target-debug.h (target_debug_print_signals): Now takes a
6352         gdb::array_view as parameter.  Adjust.
6353         * target.h (target_ops) <pass_signals, program_signals>: Replace
6354         pointer and length parameters with gdb::array_view.
6355         (target_pass_signals, target_program_signals): Likewise.
6356         * target-delegates.c: Regenerate.
6357
6358 2019-01-24  Pedro Alves  <palves@redhat.com>
6359
6360         * common/forward-scope-exit.h
6361         (forward_scope_exit::forward_scope_exit): Pass arguments to
6362         m_bind_function directly, instead of creating a std::bind and
6363         copying that.
6364
6365 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6366
6367         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6368         for static members.
6369         (pass_in_v_vfp_candidate): Likewise.
6370
6371 2019-01-23  Tom Tromey  <tom@tromey.com>
6372             Pedro Alves  <palves@redhat.com>
6373
6374         * regcache.c (class regcache_invalidator): Remove.
6375         (regcache::raw_write): Use make_scope_exit.
6376
6377 2019-01-23  Tom Tromey  <tom@tromey.com>
6378
6379         * ui-out.h (class ui_out_emit_type): Update comment.
6380
6381 2019-01-23  Tom Tromey  <tom@tromey.com>
6382
6383         * infrun.c (fetch_inferior_event): Update comment.
6384
6385 2019-01-23  Tom Tromey  <tom@tromey.com>
6386             Pedro Alves  <palves@redhat.com>
6387
6388         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6389         parameter.
6390         (fetch_inferior_event): Use SCOPE_EXIT.
6391
6392
6393 2019-01-23  Tom Tromey  <tom@tromey.com>
6394             Pedro Alves  <palves@redhat.com>
6395
6396         * infrun.c (disable_thread_events): Delete.
6397         (stop_all_threads): Use SCOPE_EXIT.
6398
6399 2019-01-23  Tom Tromey  <tom@tromey.com>
6400             Pedro Alves  <palves@redhat.com>
6401
6402         * symfile.c: Include forward-scope-exit.h.
6403         (clear_symtab_users_cleanup): Replace forward declaration with
6404         a FORWARD_SCOPE_EXIT.
6405         (syms_from_objfile_1): Use the forward_scope_exit and
6406         gdb::optional instead of cleanup_function.
6407         (reread_symbols): Use the forward_scope_exit instead of
6408         cleanup_function.
6409         (clear_symtab_users_cleanup): Remove function.
6410
6411 2019-01-23  Tom Tromey  <tom@tromey.com>
6412             Pedro Alves  <palves@redhat.com>
6413
6414         * linux-nat.c: Include scope-exit.h.
6415         (cleanup_target_stop): Remove.
6416         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6417         SCOPE_EXIT.
6418
6419 2019-01-23  Tom Tromey  <tom@tromey.com>
6420             Pedro Alves  <palves@redhat.com>
6421
6422         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6423         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6424
6425 2019-01-23  Tom Tromey  <tom@tromey.com>
6426             Andrew Burgess  <andrew.burgess@embecosm.com>
6427             Pedro Alves  <palves@redhat.com>
6428
6429         * infrun.c (fetch_inferior_event): Use scope_exit.
6430         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6431         * top.c (execute_command): Use scope_exit.
6432         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6433         * utils.c (do_bpstat_clear_actions_cleanup)
6434         (make_bpstat_clear_actions_cleanup): Remove.
6435
6436 2019-01-23  Tom Tromey  <tom@tromey.com>
6437             Pedro Alves  <palves@redhat.com>
6438
6439         * infrun.c: Include "common/scope-exit.h"
6440         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6441         (wait_for_inferior): Use SCOPE_EXIT.
6442         (fetch_inferior_event): Use scope_exit.
6443
6444 2019-01-23  Tom Tromey  <tom@tromey.com>
6445             Pedro Alves  <palves@redhat.com>
6446
6447         * breakpoint.c (create_breakpoint): Remove cleanup.
6448
6449 2019-01-23  Tom Tromey  <tom@tromey.com>
6450             Andrew Burgess  <andrew.burgess@embecosm.com>
6451             Pedro Alves  <palves@redhat.com>
6452
6453 2019-01-23  Pedro Alves  <palves@redhat.com>
6454
6455         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6456
6457 2019-01-23  Pedro Alves  <palves@redhat.com>
6458             Andrew Burgess  <andrew.burgess@embecosm.com>
6459
6460         * gdbthread.h: Include "common/forward-scope-exit.h".
6461         (scoped_finish_thread_state): Redefine custom class in terms of
6462         forward_scope_exit.
6463
6464 2019-01-23  Pedro Alves  <palves@redhat.com>
6465             Andrew Burgess  <andrew.burgess@embecosm.com>
6466
6467         * common/forward-scope-exit.h: New file.
6468
6469 2019-01-23  Pedro Alves  <palves@redhat.com>
6470             Andrew Burgess  <andrew.burgess@embecosm.com>
6471             Tom Tromey  <tom@tromey.com>
6472
6473         * common/scope-exit.h: New file.
6474
6475 2019-01-23  Pedro Alves  <palves@redhat.com>
6476
6477         * common/preprocessor.h (ESC): Rename to ...
6478         (ESC_PARENS): ... this.
6479         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6480         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6481
6482 2019-01-23  Tom Tromey  <tom@tromey.com>
6483
6484         * language.h (class scoped_switch_to_sym_language_if_auto):
6485         Initialize m_lang in both cases.
6486
6487 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6488
6489         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6490         with XCNEW.
6491
6492 2019-01-22  Tom Tromey  <tom@tromey.com>
6493
6494         * corelow.c: Do not include sys/file.h.
6495
6496 2019-01-22  Tom Tromey  <tom@tromey.com>
6497
6498         * tui/tui-wingeneral.h: Include gdb_curses.h.
6499
6500 2019-01-22  Tom Tromey  <tom@tromey.com>
6501
6502         * source-cache.h (class source_cache) <get_source_lines,
6503         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6504
6505 2019-01-22  Tom Tromey  <tom@tromey.com>
6506
6507         * remote-fileio.h (struct remote_target): Declare.
6508
6509 2019-01-22  Tom Tromey  <tom@tromey.com>
6510
6511         * python/py-arch.c: Do not include py-ref.h.
6512         * python/py-bpevent.c: Do not include py-ref.h.
6513         * python/py-cmd.c: Do not include py-ref.h.
6514         * python/py-continueevent.c: Do not include py-ref.h.
6515         * python/py-event.h: Do not include py-ref.h.
6516         * python/py-evtregistry.c: Do not include py-ref.h.
6517         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6518         * python/py-frame.c: Do not include py-ref.h.
6519         * python/py-framefilter.c: Do not include py-ref.h.
6520         * python/py-function.c: Do not include py-ref.h.
6521         * python/py-infevents.c: Do not include py-ref.h.
6522         * python/py-linetable.c: Do not include py-ref.h.
6523         * python/py-objfile.c: Do not include py-ref.h.
6524         * python/py-param.c: Do not include py-ref.h.
6525         * python/py-prettyprint.c: Do not include py-ref.h.
6526         * python/py-progspace.c: Do not include py-ref.h.
6527         * python/py-symbol.c: Do not include py-ref.h.
6528         * python/py-symtab.c: Do not include py-ref.h.
6529         * python/py-type.c: Do not include py-ref.h.
6530         * python/py-unwind.c: Do not include py-ref.h.
6531         * python/py-utils.c: Do not include py-ref.h.
6532         * python/py-value.c: Do not include py-ref.h.
6533         * python/py-varobj.c: Do not include py-ref.h.
6534         * python/py-xmethods.c: Do not include py-ref.h.
6535         * python/python.c: Do not include py-ref.h.
6536         * varobj.c: Do not include py-ref.h.
6537
6538 2019-01-22  Tom Tromey  <tom@tromey.com>
6539
6540         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6541         keyword for bcache.
6542
6543 2019-01-22  Tom Tromey  <tom@tromey.com>
6544
6545         * compile/compile-cplus-types.c: Remove a comment by #include.
6546
6547 2019-01-22  Tom Tromey  <tom@tromey.com>
6548
6549         * compile/gcc-c-plugin.h: Include compile-internal.h.
6550
6551 2019-01-22  Tom Tromey  <tom@tromey.com>
6552
6553         * stabsread.c (EXTERN): Do not define.
6554         (symnum, next_symbol_text_func, processing_gcc_compilation)
6555         (within_function, global_sym_chain, global_stabs)
6556         (previous_stab_code, this_object_header_files)
6557         (n_this_object_header_files)
6558         (n_allocated_this_object_header_files): Define.
6559         * stabsread.h (EXTERN): Never define.  Use "extern".
6560
6561 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6562
6563         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6564         history_value.
6565
6566 2019-01-21  Tom Tromey  <tom@tromey.com>
6567
6568         * ui-out.c: Fix includes.
6569         * tui/tui-source.c: Fix includes.
6570         * target.c: Fix includes.
6571         * remote.c: Fix includes.
6572         * regcache.c: Fix includes.
6573         * python/py-block.c: Fix includes.
6574         * printcmd.c: Fix includes.
6575         * or1k-tdep.c: Fix includes.
6576         * mi/mi-main.c: Fix includes.
6577         * m32r-tdep.c: Fix includes.
6578         * csky-tdep.c: Fix includes.
6579         * compile/compile-cplus-types.c: Fix includes.
6580         * cli/cli-interp.c: Fix includes.
6581
6582 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6583
6584         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6585         for padding.
6586
6587 2019-01-16  Tom Tromey  <tom@tromey.com>
6588
6589         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6590         earlier.
6591         (struct objfile) <msymbols_range>: Move from top level.
6592         <msymbols>: New method.
6593         (class objfile_msymbols): Remove.
6594         * symtab.c (default_collect_symbol_completion_matches_break_on):
6595         Update.
6596         * symmisc.c (dump_msymbols): Update.
6597         * stabsread.c (scan_file_globals): Update.
6598         * objc-lang.c (info_selectors_command, info_classes_command)
6599         (find_methods): Update.
6600         * minsyms.c (find_solib_trampoline_target): Update.
6601         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6602         * coffread.c (coff_symfile_read): Update.
6603         * ada-lang.c (ada_lookup_simple_minsym)
6604         (ada_collect_symbol_completion_matches): Update.
6605
6606 2019-01-16  Tom Tromey  <tom@tromey.com>
6607
6608         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6609         type.  Remove no-argument constructor.
6610         <iterator::operator++>: Simplify.
6611         <begin>: Update.
6612         <end>: Use minimal_symbol_count.
6613
6614 2019-01-16  Tom Tromey  <tom@tromey.com>
6615
6616         * objfiles.h (struct objfile) <psymtabs>: New method.
6617         (class objfile_psymtabs): Remove.
6618         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6619         typedef.
6620         <range>: New method.
6621         (require_partial_symbols): Change return type.
6622         * psymtab.c (require_partial_symbols)
6623         (psym_expand_symtabs_matching): Update.
6624         * mdebugread.c (parse_partial_symbols): Update.
6625         * dbxread.c (dbx_end_psymtab): Update.
6626
6627 2019-01-15  Tom Tromey  <tom@tromey.com>
6628
6629         * symtab.c (lookup_objfile_from_block)
6630         (lookup_symbol_in_objfile_symtabs)
6631         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6632         (find_line_symtab, info_sources_command)
6633         (default_collect_symbol_completion_matches_break_on)
6634         (make_source_files_completion_list): Update.
6635         * symmisc.c (print_objfile_statistics, dump_objfile)
6636         (maintenance_print_symbols, maintenance_info_symtabs)
6637         (maintenance_check_symtabs, maintenance_info_line_tables):
6638         Update.
6639         * source.c (select_source_symtab)
6640         (forget_cached_source_info_for_objfile): Update.
6641         * objfiles.h (class objfile_compunits): Remove.
6642         (struct objfile) <compunits_range>: New typedef.
6643         (compunits): New method.
6644         * objfiles.c (objfile_relocate1): Update.
6645         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6646         * maint.c (count_symtabs_and_blocks): Update.
6647         * linespec.c (iterate_over_all_matching_symtabs): Update.
6648         * cp-support.c (add_symbol_overload_list_qualified): Update.
6649         * coffread.c (coff_symtab_read): Update.
6650         * ada-lang.c (add_nonlocal_symbols)
6651         (ada_collect_symbol_completion_matches)
6652         (ada_add_global_exceptions): Update.
6653
6654 2019-01-15  Tom Tromey  <tom@tromey.com>
6655
6656         * progspace.h (program_space) <objfiles_safe_range>: New
6657         typedef.
6658         <objfiles_safe>: New method.
6659         * objfiles.h (class all_objfiles_safe): Remove.
6660         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6661         * jit.c (jit_inferior_exit_hook): Update.
6662
6663 2019-01-17  Tom Tromey  <tom@tromey.com>
6664
6665         * progspace.h (program_space) <objfiles_range>: New typedef.
6666         <objfiles>: New method.
6667         <objfiles_head>: Rename from objfiles.
6668         (object_files): Update.
6669         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6670         * guile/scm-pretty-print.c
6671         (ppscm_find_pretty_printer_from_objfiles): Update.
6672         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6673         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6674         Update.
6675         * python/py-progspace.c (pspy_get_objfiles): Update.
6676         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6677         Update.
6678         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6679         (objfpy_lookup_objfile_by_build_id): Update.
6680         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6681         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6682         Update.
6683         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6684         (expand_symtab_containing_pc, lookup_objfile_from_block)
6685         (lookup_static_symbol, basic_lookup_transparent_type)
6686         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6687         (find_line_symtab, info_sources_command)
6688         (default_collect_symbol_completion_matches_break_on)
6689         (make_source_files_completion_list, find_main_name): Update.
6690         * symmisc.c (print_symbol_bcache_statistics)
6691         (print_objfile_statistics, maintenance_print_symbols)
6692         (maintenance_print_msymbols, maintenance_print_objfiles)
6693         (maintenance_info_symtabs, maintenance_check_symtabs)
6694         (maintenance_expand_symtabs, maintenance_info_line_tables):
6695         Update.
6696         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6697         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6698         (map_overlay_command, unmap_overlay_command)
6699         (simple_overlay_update, expand_symtabs_matching)
6700         (map_symbol_filenames): Update.
6701         * symfile-debug.c (set_debug_symfile): Update.
6702         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6703         Update.
6704         * source.c (select_source_symtab, forget_cached_source_info):
6705         Update.
6706         * solib.c (solib_read_symbols): Update.
6707         * solib-spu.c (append_ocl_sos): Update.
6708         * psymtab.c (maintenance_print_psymbols)
6709         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6710         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6711         * printcmd.c (info_symbol_command): Update.
6712         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6713         Update.
6714         * objfiles.h (class all_objfiles): Remove.
6715         * objfiles.c (have_partial_symbols, have_full_symbols)
6716         (have_minimal_symbols, qsort_cmp, update_section_map)
6717         (shared_objfile_contains_address_p)
6718         (default_iterate_over_objfiles_in_search_order): Update.
6719         * objc-lang.c (info_selectors_command, info_classes_command)
6720         (find_methods): Update.
6721         * minsyms.c (find_solib_trampoline_target): Update.
6722         * maint.c (maintenance_info_sections)
6723         (maintenance_translate_address, count_symtabs_and_blocks):
6724         Update.
6725         * main.c (captured_main_1): Update.
6726         * linux-thread-db.c (try_thread_db_load_from_pdir)
6727         (has_libpthread): Update.
6728         * linespec.c (iterate_over_all_matching_symtabs)
6729         (search_minsyms_for_name): Update.
6730         * jit.c (jit_find_objf_with_entry_addr): Update.
6731         * hppa-tdep.c (find_unwind_entry)
6732         (hppa_lookup_stub_minimal_symbol): Update.
6733         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6734         Update.
6735         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6736         (elf_gnu_ifunc_resolve_by_got): Update.
6737         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6738         * dwarf-index-write.c (save_gdb_index_command): Update.
6739         * cp-support.c (add_symbol_overload_list_qualified): Update.
6740         * breakpoint.c (create_overlay_event_breakpoint)
6741         (create_longjmp_master_breakpoint)
6742         (create_std_terminate_master_breakpoint)
6743         (create_exception_master_breakpoint): Update.
6744         * blockframe.c (find_pc_partial_function): Update.
6745         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6746         (ada_collect_symbol_completion_matches)
6747         (ada_add_global_exceptions): Update.
6748
6749 2019-01-17  Tom Tromey  <tom@tromey.com>
6750
6751         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6752         declare VEC.
6753         (solib_target_parse_libraries): Change return type.
6754         (library_list_start_segment, library_list_start_section)
6755         (library_list_end_library, library_list_start_library); Update.
6756         (solib_target_free_library_list): Remove.
6757         (solib_target_parse_libraries): Remove cleanup.  Change return
6758         type.
6759         (solib_target_current_sos): Update.
6760
6761 2019-01-17  Tom Tromey  <tromey@bapiya>
6762
6763         * valprint.c: Replace "the the" with "the".
6764         * symtab.c: Replace "the the" with "the".
6765         * solib.c: Replace "the the" with "the".
6766         * solib-dsbt.c: Replace "the the" with "the".
6767         * linespec.c: Replace "the the" with "the".
6768         * dwarf2loc.h: Replace "the the" with "the".
6769         * amd64-windows-tdep.c: Replace "the the" with "the".
6770         * aarch64-tdep.c: Replace "the the" with "the".
6771
6772 2019-01-16  Keith Seitz  <keiths@redhat.com>
6773
6774         PR gdb/23773
6775         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6776         <builder>: Rename to ..
6777         <m_builder>: ... this and make private.
6778         (dwarf2_cu::get_builder): New method.  Change all users of
6779         `builder' to use this method.
6780         (dwarf2_start_symtab): Move to ...
6781         (dwarf2_cu::start_symtab): ... here.  Update all callers
6782         (setup_type_unit_groups): Move to ...
6783         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6784         callers.
6785         (dwarf2_cu::reset_builder): New method.
6786         (process_full_compunit, process_full_type_unit): Use
6787         dwarf2_cu::reset_builder.
6788         (follow_die_offset): Record the ancestor CU if it is different
6789         from the followed DIE's CU.
6790         (follow_die_sig_1): Likewise.
6791
6792 2019-01-15  Tom Tromey  <tom@tromey.com>
6793
6794         * remote.c (class remote_state) <buf>: Now a char_vector.
6795         <buf_size>: Remove.
6796         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6797         parameter.
6798         (remote_target::getpkt_or_notif_sane_1)
6799         (remote_target::getpkt_sane)
6800         (remote_target::getpkt_or_notif_sane): Likewise.
6801         (class remote_target) <putpkt>: New overload.
6802         (remote_target::read_frame): Change type of "buf_p".  Remove
6803         sizeof_p parameter.
6804         (packet_ok): New overload.
6805         (packet_check_result): New overload.
6806         Update all uses.
6807
6808 2019-01-14  Tom Tromey  <tom@tromey.com>
6809
6810         * remote-notif.c (handle_notification, remote_notif_ack)
6811         (remote_notif_parse): Make "buf" const.
6812         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6813         const.
6814         (remote_notif_parse, remote_notif_ack, handle_notification):
6815         Likewise.
6816         * remote.c (remote_notif_stop_parse): Make "buf" const.
6817         (remote_target::remote_parse_stop_reply): Make "buf" const.
6818         (remote_notif_stop_ack): Make "buf" const.
6819
6820 2019-01-14  Tom Tromey  <tom@tromey.com>
6821
6822         * remote.c (remote_console_output): Make parameter const.
6823
6824 2019-01-14  Tom Tromey  <tom@tromey.com>
6825
6826         * target-debug.h (target_debug_print_signals): Constify.
6827         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6828         * procfs.c (procfs_target::pass_signals): Update.
6829         * linux-nat.c (linux_nat_target::pass_signals): Update.
6830         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6831         * target-delegates.c: Rebuild.
6832         * remote.c (remote_target::program_signals): Update.
6833         (remote_target::pass_signals): Update.
6834         * target.c (target_pass_signals): Constify argument.
6835         (target_program_signals): Likewise.
6836         * target.h (struct target_ops) <pass_signals, program_signals>:
6837         Constify argument.
6838         (target_pass_signals, target_program_signals): Constify argument.
6839
6840 2019-01-14  Tom Tromey  <tom@tromey.com>
6841
6842         PR tui/28819:
6843         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6844
6845 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6846
6847         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6848         field.
6849         * rs6000-tdep.c: Include reggroups.h.
6850         (IS_V_ALIAS_PSEUDOREG): Define.
6851         (rs6000_register_name): Return names for the "vX" aliases.
6852         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6853         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6854         aliases.  Call default_register_reggroup_p for all other
6855         pseudo-registers.
6856         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6857         New functions.
6858         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6859         Handle "vX" aliases.
6860         (v_alias_pseudo_register_collect): New function.
6861         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6862         (rs6000_gdbarch_init): Initialize "vX" aliases as
6863         pseudo-registers.  Restore registration of
6864         rs6000_pseudo_register_reggroup_p with
6865         set_tdesc_pseudo_register_reggroup_p.
6866
6867 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6868
6869         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6870         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6871         set_gdbarch_num_pseudo_regs.
6872
6873 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6874
6875         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6876         Remove arg prefixname, add do_set and do_show.
6877         Add member functions set_list and show_list.
6878         * cli/cli-style.c (class cli_style_option): Update accordingly.
6879         (style_set_list): Move to file scope.
6880         (style_show_list): Likewise.
6881         (set_style): Call help_list.
6882         (show_style): Call cmd_show_list.
6883         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6884         Update to use the new macro.
6885
6886 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6887
6888         * ada-lang.c (_initialize_ada_language): Expand the help text
6889         for the "catch exception" command.
6890
6891 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6892
6893         * symtab.c (matching_obj_sections): Initialize obj,
6894         declare it closer to its usage.
6895
6896 2019-01-10  Tom Tromey  <tom@tromey.com>
6897
6898         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6899         (basic_inf_threads_range): Remove.
6900         (inf_threads_range, inf_non_exited_threads_range)
6901         (safe_inf_threads_range): Use next_adapter.
6902
6903 2019-01-10  Keith Seitz  <keiths@redhat.com>
6904
6905         PR gdb/23712
6906         PR symtab/23010
6907         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6908         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6909
6910 2019-01-10  Keith Seitz  <keiths@redhat.com>
6911
6912         PR gdb/23712
6913         PR symtab/23010
6914         * dictionary.c (pending_to_vector): Remove.
6915         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6916         Remove _1 suffix, replacing functions of the same name.  Update
6917         all callers.
6918         (dict_create_hashed, dict_create_hashed_expandable)
6919         (dict_create_linear, dict_create_linear_expandable, dict_free)
6920         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6921         Make functions static.
6922
6923 2019-01-10  Keith Seitz  <keiths@redhat.com>
6924
6925         PR gdb/23712
6926         PR symtab/23010
6927         * dictionary.h (struct dictionary): Replace declaration with
6928         multidictionary.
6929         (dict_create_hashed, dict_create_hashed_expandable)
6930         (dict_create_linear, dict_create_linear_expandable)
6931         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6932         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6933         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6934         taking multidictionary argument.
6935         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6936         * block.h (struct block) <dict>: Change to multidictionary
6937         and rename `multidict'.
6938         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6939         symmisc.c: Update all dictionary references to multidictionary.
6940
6941 2019-01-10  Keith Seitz  <keiths@redhat.com>
6942
6943         PR gdb/23712
6944         PR symtab/23010
6945         * dictionary.c: Include unordered_map.
6946         (pending_to_vector): New function.
6947         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6948         Rewrite the non-"_1" functions to take vector instead
6949         of linked list.
6950         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6951         "new" _1 versions of the same name.
6952         (multidictionary): Define.
6953         (std::hash<enum language): New definition.
6954         (collate_pending_symbols_by_language, mdict_create_hashed)
6955         (mdict_create_hashed_expandable, mdict_create_linear)
6956         (mdict_create_linear_expandable, mdict_free)
6957         (find_language_dictionary, create_new_language_dictionary)
6958         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6959         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6960         (mdict_size, mdict_empty): New functions.
6961         * dictionary.h (mdict_iterator): Define.
6962
6963 2019-01-10  Pedro Alves  <palves@redhat.com>
6964
6965         * breakpoint.c (read_uploaded_action)
6966         (create_tracepoint_from_upload): Adjust to use
6967         gdb::unique_xmalloc_ptr.
6968         * ctf.c (ctf_write_uploaded_tp):
6969         (SET_ARRAY_FIELD): Use emplace_back.
6970         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6971         * tracefile-tfile.c (tfile_write_uploaded_tp):
6972         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6973         gdb::unique_xmalloc_ptr.
6974         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6975         at_string, cond_string, cmd_strings>: Replace char pointers
6976         with gdb::unique_xmalloc_ptr.
6977
6978 2019-01-10  Pedro Alves  <palves@redhat.com>
6979
6980         * solib-target.c (library_list_start_library): Don't xstrdup name.
6981
6982 2019-01-10  Pedro Alves  <palves@redhat.com>
6983
6984         * mdebugread.c (parse_partial_symbols): Use
6985         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6986
6987 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6988
6989         * linux-fork.c (scoped_switch_fork_info)
6990         <~scoped_switch_fork_info>: Fix incorrect variable name.
6991
6992 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6993
6994         * linux-fork.c (scoped_switch_fork_info)
6995         <scoped_switch_fork_info>: Make explicit.
6996         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6997
6998 2019-01-10  Tom Tromey  <tom@tromey.com>
6999
7000         * objfiles.h (objfile::reset_psymtabs): Update.
7001         * objfiles.c (objfile::objfile): Update.
7002         * psymtab.h (psymtab_storage::obstack): Update.
7003         (psymtab_storage::m_obstack): Use gdb::optional.
7004         (class psymtab_storage): Update comment.  Remove objfile
7005         parameter.
7006         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7007
7008 2019-01-10  Tom Tromey  <tom@tromey.com>
7009
7010         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7011         <free_psymtabs>: Now private.
7012         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7013         (allocate_psymtab): Use new method.
7014
7015 2019-01-10  Tom Tromey  <tom@tromey.com>
7016
7017         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7018         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7019         * mdebugread.c (parse_partial_symbols): Use
7020         allocate_dependencies.
7021         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7022         allocate_dependencies.
7023         (process_psymtab_comp_unit_reader)
7024         (build_type_psymtab_dependencies): Likewise.
7025         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7026
7027 2019-01-10  Tom Tromey  <tom@tromey.com>
7028
7029         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7030         PSYMBOL_SET_LANGUAGE.
7031         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7032
7033 2019-01-10  Tom Tromey  <tom@tromey.com>
7034
7035         * psymtab.h (psymtab_storage::obstack): New method.
7036         <m_obstack>: Rename from obstack; now private.
7037         * psymtab.c (psymtab_storage): Update.
7038         * dwarf2read.c (create_addrmap_from_index)
7039         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7040         Update.
7041
7042 2019-01-10  Tom Tromey  <tom@tromey.com>
7043
7044         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7045         * objfiles.h (objfile::reset_psymtabs): New method.
7046
7047 2019-01-10  Tom Tromey  <tom@tromey.com>
7048
7049         * symmisc.c (print_symbol_bcache_statistics): Update.
7050         (print_objfile_statistics): Update.
7051         * symfile.c (reread_symbols): Update.
7052         * psymtab.h (class psymtab_storage): New.
7053         * psymtab.c (psymtab_storage): New constructor.
7054         (~psymtab_storage): New destructor.
7055         (require_partial_symbols): Update.
7056         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7057         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7058         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7059         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7060         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7061         (start_psymtab_common, end_psymtab_common)
7062         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7063         (allocate_psymtab): Update.
7064         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7065         Update.
7066         (dump_psymtab_addrmap, maintenance_print_psymbols)
7067         (maintenance_check_psymtabs): Update.
7068         (class objfile_psymtabs): Move to objfiles.h.
7069         * psympriv.h (discard_psymtab): Now inline.
7070         (psymtab_discarder::psymtab_discarder): Update.
7071         (psymtab_discarder::~psymtab_discarder): Update.
7072         (ALL_OBJFILE_PSYMTABS): Rewrite.
7073         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7074         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7075         Remove fields.
7076         <partial_symtabs>: New field.
7077         (class objfile_psymtabs): Move from psymtab.h.  Update.
7078         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7079         psymbol_cache.
7080         (objfile::~objfile): Don't destroy psymbol_cache.
7081         * mdebugread.c (parse_partial_symbols): Update.
7082         * dwarf2read.c (create_addrmap_from_index)
7083         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7084         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7085         (add_partial_subprogram, dwarf2_ranges_read): Update.
7086         * dwarf-index-write.c (write_address_map)
7087         (write_one_signatured_type, recursively_write_psymbols)
7088         (class debug_names, class debug_names, write_psymtabs_to_index):
7089         Update.
7090
7091 2019-01-10  Tom Tromey  <tom@tromey.com>
7092
7093         * symtab.h (SYMBOL_SET_NAMES): Update.
7094         (symbol_set_names): Update.
7095         (MSYMBOL_SET_NAMES): Update.
7096         * symtab.c (symbol_set_names): Change argument to be an
7097         objfile_per_bfd_storage.
7098         * psymtab.c (add_psymbol_to_bcache): Update.
7099         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7100
7101 2019-01-10  Tom Tromey  <tom@tromey.com>
7102
7103         * symtab.c (create_demangled_names_hash): Change argument to be an
7104         objfile_per_bfd_storage.
7105         (symbol_set_names): Update.
7106
7107 2019-01-10  Tom Tromey  <tom@tromey.com>
7108
7109         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7110         init_psymbol_list.
7111         * psymtab.c (init_psymbol_list): Do nothing if already called.
7112         * psympriv.h (init_psymbol_list): Add comment.
7113         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7114         init_psymbol_list.
7115         * dbxread.c (dbx_symfile_read): Unconditionally call
7116         init_psymbol_list.
7117
7118 2019-01-10  Tom Tromey  <tom@tromey.com>
7119
7120         * xcoffread.c (scan_xcoff_symtab): Update.
7121         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7122         "where".
7123         * mdebugread.c (parse_partial_symbols)
7124         (handle_psymbol_enumerators): Update.
7125         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7126         * dbxread.c (read_dbx_symtab): Update.
7127         * psympriv.h (psymbol_placement): New enum.
7128         (add_psymbol_to_list): Update.
7129
7130 2019-01-10  Tom Tromey  <tom@tromey.com>
7131
7132         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7133         static_psymbols parameters.
7134         (scan_xcoff_symtab): Update.
7135         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7136         static_psymbols parameters.
7137         * psympriv.h (start_psymtab_common): Update.
7138         * mdebugread.c (parse_partial_symbols): Update.
7139         * dwarf2read.c (create_partial_symtab): Update.
7140         * dbxread.c (read_dbx_symtab): Update.
7141         (start_psymtab): Remove global_psymbols and static_psymbols
7142         parameters.
7143
7144 2019-01-10  Tom Tromey  <tom@tromey.com>
7145
7146         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7147         * psymtab.c (allocate_psymtab): Add comment.
7148         * psympriv.h (allocate_psymtab): Add comment.
7149         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7150         initializations.
7151         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7152
7153 2019-01-10  Tom Tromey  <tom@tromey.com>
7154
7155         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7156         Don't declare.
7157         * mipsread.c: Include mdebugread.h.
7158         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7159         Declare.
7160         * elfread.c: Include mdebugread.h.
7161
7162 2019-01-09  Tom Tromey  <tom@tromey.com>
7163
7164         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7165         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7166         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7167         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7168         (psym_lookup_symbol, psym_find_last_source_symtab)
7169         (psym_forget_cached_source_info, psym_print_stats)
7170         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7171         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7172         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7173         (psym_find_compunit_symtab_by_address)
7174         (maintenance_print_psymbols, maintenance_info_psymtabs)
7175         (maintenance_check_psymtabs): Use ranged for.
7176         * psymtab.h (class objfile_psymtabs): New.
7177         (require_partial_symbols): Return objfile_psymtabs.
7178         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7179
7180 2019-01-09  Tom Tromey  <tom@tromey.com>
7181
7182         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7183         (find_pc_mapped_section, list_overlays_command)
7184         (map_overlay_command, unmap_overlay_command)
7185         (simple_overlay_update): Use all_objfiles.
7186         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7187         * printcmd.c (info_symbol_command): Use all_objfiles.
7188         * objfiles.h (ALL_OBJSECTIONS): Remove.
7189         * maint.c (maintenance_translate_address): Use all_objfiles.
7190         * gcore.c (gcore_create_callback): Use all_objfiles.
7191         (objfile_find_memory_regions): Likewise.
7192
7193 2019-01-09  Tom Tromey  <tom@tromey.com>
7194
7195         * symtab.c (find_line_symtab, info_sources_command)
7196         (make_source_files_completion_list): Use objfile_compunits.
7197         * source.c (select_source_symtab): Use objfile_compunits.
7198         * objfiles.h (struct objfile): Update comment.
7199         (ALL_OBJFILES): Remove.
7200         (ALL_FILETABS): Remove.
7201         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7202         objfile_compunits.
7203
7204 2019-01-09  Tom Tromey  <tom@tromey.com>
7205
7206         * symmisc.c (print_objfile_statistics, dump_objfile)
7207         (maintenance_print_symbols): Use compunit_filetabs.
7208         * source.c (forget_cached_source_info_for_objfile): Use
7209         compunit_filetabs.
7210         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7211         (ALL_FILETABS): Use compunit_filetabs.
7212         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7213         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7214
7215 2019-01-09  Tom Tromey  <tom@tromey.com>
7216
7217         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7218         (compunit_filetabs): New.
7219         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7220         compunit_filetabs.
7221         (info_sources_command, make_source_files_completion_list): Remove
7222         declaration.
7223         * symmisc.c (print_objfile_statistics, dump_objfile)
7224         (maintenance_print_symbols): Remove declaration.
7225         (maintenance_info_symtabs): Use compunit_filetabs.
7226         (maintenance_info_line_tables): Likewise.
7227         * source.c (select_source_symtab): Change local variable name.
7228         (forget_cached_source_info_for_objfile): Remove declaration.
7229         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7230         * objfiles.c (objfile_relocate1): Remove declaration.
7231         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7232         declaration.
7233         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7234         * coffread.c (coff_symtab_read): Remove declaration.
7235         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7236         compunit_filetabs.
7237
7238 2019-01-09  Tom Tromey  <tom@tromey.com>
7239
7240         * symtab.c (lookup_objfile_from_block)
7241         (find_pc_sect_compunit_symtab, search_symbols)
7242         (default_collect_symbol_completion_matches_break_on): Use
7243         objfile_compunits.
7244         * objfiles.h (ALL_COMPUNITS): Remove.
7245         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7246         * cp-support.c (add_symbol_overload_list_qualified): Use
7247         objfile_compunits.
7248         * ada-lang.c (ada_collect_symbol_completion_matches)
7249         (ada_add_global_exceptions): Use objfile_compunits.
7250
7251 2019-01-09  Tom Tromey  <tom@tromey.com>
7252
7253         * source.c (select_source_symtab)
7254         (forget_cached_source_info_for_objfile): Remove declaration.
7255         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7256         declaration.
7257         * maint.c (count_symtabs_and_blocks): Remove declaration.
7258         * cp-support.c (add_symbol_overload_list_qualified): Remove
7259         declaration.
7260         * coffread.c (coff_symtab_read): Remove declaration.
7261         * symtab.c (lookup_symbol_in_objfile_symtabs)
7262         (basic_lookup_transparent_type_1): Use objfile_compunits.
7263         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7264         (info_sources_command, search_symbols)
7265         (default_collect_symbol_completion_matches_break_on)
7266         (make_source_files_completion_list): Remove declaration.
7267         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7268         (ada_collect_symbol_completion_matches)
7269         (ada_add_global_exceptions): Remove declaration.
7270         * linespec.c (iterate_over_all_matching_symtabs): Use
7271         objfile_compunits.
7272         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7273         (class objfile_compunits): New.
7274         (ALL_COMPUNITS): Use objfile_compunits.
7275         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7276         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7277         objfile_compunits.
7278         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7279
7280 2019-01-09  Tom Tromey  <tom@tromey.com>
7281
7282         * symtab.c (search_symbols)
7283         (default_collect_symbol_completion_matches_break_on): Use
7284         objfile_msymbols.
7285         * ada-lang.c (ada_lookup_simple_minsym)
7286         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7287         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7288         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7289         objfile_msymbols.
7290         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7291         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7292         * objc-lang.c (find_methods): Use objfile_msymbols.
7293         (info_selectors_command, info_classes_command): Likewise.
7294         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7295         * objfiles.h (class objfile_msymbols): New.
7296         (ALL_OBJFILE_MSYMBOLS): Remove.
7297         (ALL_MSYMBOLS): Remove.
7298
7299 2019-01-09  Tom Tromey  <tom@tromey.com>
7300
7301         * common/next-iterator.h (next_adapter): Add Iterator template
7302         parameter.
7303         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7304         (class all_objfiles_safe): New.
7305         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7306         * objfiles.c (put_objfile_before): Update comment.
7307         (add_separate_debug_objfile): Likewise.
7308         (free_all_objfiles): Use all_objfiles_safe.
7309         (objfile_purge_solibs): Likewise.
7310
7311 2019-01-09  Tom Tromey  <tom@tromey.com>
7312
7313         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7314         (expand_symtab_containing_pc, lookup_static_symbol)
7315         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7316         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7317         all_objfiles.
7318         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7319         * breakpoint.c (create_overlay_event_breakpoint)
7320         (create_longjmp_master_breakpoint)
7321         (create_std_terminate_master_breakpoint)
7322         (create_exception_master_breakpoint): Use all_objfiles.
7323         * linux-thread-db.c (try_thread_db_load_from_pdir)
7324         (has_libpthread): Use all_objfiles.
7325         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7326         * linespec.c (iterate_over_all_matching_symtabs)
7327         (search_minsyms_for_name): Use all_objfiles.
7328         * maint.c (maintenance_info_sections): Use all_objfiles.
7329         * main.c (captured_main_1): Use all_objfiles.
7330         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7331         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7332         * guile/scm-pretty-print.c
7333         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7334         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7335         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7336         (maintenance_print_msymbols): Use all_objfiles.
7337         * source.c (select_source_symtab): Use all_objfiles.
7338         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7339         * symfile.c (remove_symbol_file_command)
7340         (expand_symtabs_matching, map_symbol_filenames): Use
7341         all_objfiles.
7342         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7343         all_objfiles.
7344         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7345         * objc-lang.c (find_methods): Use all_objfiles.
7346         * objfiles.c (have_partial_symbols, have_full_symbols)
7347         (have_minimal_symbols, qsort_cmp)
7348         (default_iterate_over_objfiles_in_search_order): Use
7349         all_objfiles.
7350         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7351         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7352         (maintenance_check_psymtabs): Use all_objfiles.
7353         (ALL_PSYMTABS): Remove.
7354         * compile/compile-object-run.c (do_module_cleanup): Use
7355         all_objfiles.
7356         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7357         * cp-support.c (add_symbol_overload_list_qualified): Use
7358         all_objfiles.
7359         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7360         Use all_objfiles.
7361         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7362         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7363         all_objfiles.
7364         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7365         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7366         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7367         Uses all_objfiles.
7368         * solib.c (solib_read_symbols): Use all_objfiles
7369
7370 2019-01-09  Tom Tromey  <tom@tromey.com>
7371
7372         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7373         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7374         all_objfiles.
7375         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7376         * symmisc.c (print_symbol_bcache_statistics)
7377         (print_objfile_statistics, maintenance_print_objfiles)
7378         (maintenance_info_symtabs, maintenance_check_symtabs)
7379         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7380         all_objfiles.
7381         * source.c (forget_cached_source_info): Use all_objfiles.
7382         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7383         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7384         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7385         * objfiles.c (update_section_map): Use all_objfiles.
7386         (shared_objfile_contains_address_p): Likewise.
7387         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7388         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7389
7390 2019-01-09  Tom Tromey  <tom@tromey.com>
7391
7392         * common/next-iterator.h: New file.
7393         * objfiles.h (class all_objfiles): New.
7394         (struct objfile_iterator): New.
7395
7396 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7397
7398         * NEWS: Move the description of the changed "frame", "select-frame",
7399          and "info frame" commands to the Changed commands section.
7400
7401 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7402
7403         * gdbtypes.c (check_stub_method_group): Remove handling of old
7404         mangling schemes.
7405         * linespec.c (find_methods): Likewise.
7406         * stabsread.c (read_member_functions): Likewise.
7407         * valops.c (search_struct_method): Likewise.
7408         (value_struct_elt_for_reference): Likewise.
7409         * NEWS: Mention this change.
7410
7411 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7412
7413         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7414         print_source_lines.
7415         * source.c (print_source_lines_base): Update line number check.
7416         (print_source_lines): New function.
7417         (source_lines_range::source_lines_range): New function.
7418         * source.h (class source_lines_range): New class.
7419         (print_source_lines): New declaration.
7420
7421 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7422
7423         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7424
7425 2019-01-08  Tom Tromey  <tom@tromey.com>
7426             Simon Marchi  <simon.marchi@ericsson.com>
7427
7428         PR gdb/24060
7429         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7430         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7431         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7432         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7433         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7434         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7435
7436 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7437
7438         * source.c (select_source_symtab): Move header comment to
7439         declaration in source.h.
7440         (forget_cached_source_info_for_objfile): Likewise.
7441         (forget_cached_source_info): Likewise.
7442         (identify_source_line): Likewise.
7443         * source.h (identify_source_line): Move declaration from symtab.h
7444         and add comment from source.c
7445         (print_source_lines): Likewise.
7446         (forget_cached_source_info_for_objfile): Likewise.
7447         (forget_cached_source_info): Likewise.
7448         (select_source_symtab): Likewise.
7449         (enum print_source_lines_flag): Move definition from symtab.h.
7450         * symtab.h (identify_source_line): Move declaration to source.h.
7451         (print_source_lines): Likewise.
7452         (forget_cached_source_info_for_objfile): Likewise.
7453         (forget_cached_source_info): Likewise.
7454         (select_source_symtab): Likewise.
7455         (enum print_source_lines_flag): Move definition to source.h.
7456         * tui/tui-hooks.c: Add 'source.h' include.
7457
7458 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7459
7460         * source.c (print_source_lines_base): Handle requests to print
7461         reverse line number sequences, and guard against empty lines
7462         string.
7463
7464 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7465
7466         * source.c (print_source_lines_base): Fix skip of '\r' if next
7467         character is '\n'.
7468
7469 2019-01-06  Tom Tromey  <tom@tromey.com>
7470
7471         * c-exp.y (struct c_parse_state) <macro_original_text,
7472         expansion_obstack>: New member.
7473         (macro_original_text, expansion_obstack): Remove globals.
7474         (scan_macro_expansion, scanning_macro_expansion)
7475         (finished_macro_expansion): Update.
7476         (scan_macro_cleanup): Remove.
7477         (yylex, c_parse): Update.
7478
7479 2019-01-06  Tom Tromey  <tom@tromey.com>
7480
7481         * c-exp.y (struct c_parse_state) <strings>: New member.
7482         (operator_stoken): Update.
7483
7484 2019-01-06  Tom Tromey  <tom@tromey.com>
7485
7486         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7487         (union type_stack_elt) <typelist_val>: Now a pointer to
7488         std::vector.
7489         (type_stack_cleanup): Don't declare.
7490         (push_typelist): Update.
7491         * parse.c (pop_typelist): Return a std::vector.
7492         (push_typelist): Take a std::vector.
7493         (follow_types): Update.  Do not free args.
7494         (type_stack_cleanup): Remove.
7495         * c-exp.y (struct c_parse_state): New.
7496         (cpstate): New global.
7497         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7498         (nonempty_typelist): Update.
7499         (func_mod): Create a new vector.
7500         (c_parse): Create a c_parse_state.
7501         (check_parameter_typelist): Do not delete params.
7502         (function_method): Update.  Do not delete type_list.
7503
7504 2019-01-06  Tom Tromey  <tom@tromey.com>
7505
7506         PR gdb/28155:
7507         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7508         check_typedef.
7509         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7510         (print_return_value): Likewise.
7511
7512 2019-01-05  Tom Tromey  <tom@tromey.com>
7513
7514         * contrib/cleanup_check.py: Remove.
7515         * contrib/gcc-with-excheck: Remove.
7516         * contrib/exsummary.py: Remove.
7517         * contrib/excheck.py: Remove.
7518
7519 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7520
7521         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7522         NULL. Initialize tpprev to NULL instead of assigning it
7523         to NULL on the next statement.
7524         * windows-nat.c (windows_delete_thread): Remove check for
7525         main_thread_id before printing thread exit notifications.
7526         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7527         Remove thread ID check against main_thread_id.
7528         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7529         windows_delete_thread.
7530         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7531
7532 2019-01-04  Tom Tromey  <tom@tromey.com>
7533
7534         * compile/compile.c (_initialize_compile): Use upper case for
7535         metasyntactic variables.
7536         * symmisc.c (_initialize_symmisc): Use upper case for
7537         metasyntactic variables.
7538         * psymtab.c (_initialize_psymtab): Use upper case for
7539         metasyntactic variables.
7540         * demangle.c (demangle_command): Use upper case for metasyntactic
7541         variables.
7542         (_initialize_demangler): Likewise.
7543         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7544         variables.
7545
7546 2019-01-03  Tom Tromey  <tom@tromey.com>
7547
7548         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7549
7550 2019-01-03  Tom Tromey  <tom@tromey.com>
7551
7552         * python/py-symtab.c (salpy_str): Update.
7553         (struct salpy_sal_object) <symtab>: Now a PyObject.
7554         (salpy_dealloc): Update.
7555         (del_objfile_sal): Use gdbpy_ref.
7556
7557 2019-01-03  Tom Tromey  <tom@tromey.com>
7558
7559         * python/py-type.c (convert_field): Use new_reference.  Return
7560         gdbpy_ref.
7561         (make_fielditem): Return gdbpy_ref.
7562         (typy_fields): Update.
7563         (typy_getitem): Update.
7564         (field_name): Return gdbpy_ref.  Use new_reference.
7565         (typy_iterator_iternext): Update.
7566
7567 2019-01-03  Tom Tromey  <tom@tromey.com>
7568
7569         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7570
7571 2019-01-03  Tom Tromey  <tom@tromey.com>
7572
7573         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7574         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7575         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7576         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7577         (pspy_set_type_printers): Likewise.
7578         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7579         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7580         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7581         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7582         (objfpy_set_type_printers): Likewise.
7583
7584 2019-01-03  Tom Tromey  <tom@tromey.com>
7585
7586         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7587         (gdbpy_print_stack): Use gdbpy_err_fetch.
7588         * python/python-internal.h (class gdbpy_err_fetch): New class.
7589         (class gdbpy_enter) <m_error_type, m_error_value,
7590         m_error_traceback>: Remove.
7591         <m_error>: New member.
7592         (gdbpy_exception_to_string): Don't declare.
7593         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7594         * python/py-value.c (convert_value_from_python): Use
7595         gdbpy_err_fetch.
7596         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7597         gdbpy_exception_to_string.
7598         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7599         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7600         gdbpy_err_fetch.
7601
7602 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7603
7604         * linux-nat.c (delete_lwp_cleanup): Delete.
7605         (struct lwp_deleter): New struct.
7606         (lwp_info_up): New typedef.
7607         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7608         lwp_info_up.
7609
7610 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7611
7612         * linux-fork.c (class scoped_switch_fork_info): New class.
7613         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7614
7615 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7616
7617         * valops.c (find_overload_match): Remove use of null_cleanup, and
7618         calls to do_cleanups.
7619
7620 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7621
7622         * compile/compile-cplus-types.c
7623         (compile_cplus_instance::decl_name): Handle changes to
7624         cp_func_name.
7625         * cp-support.c (cp_func_name): Update header comment, update
7626         return type.
7627         * cp-support.h (cp_func_name): Update return type in declaration.
7628         * valops.c (find_overload_match): Move temp_func local to top
7629         level of function and change its type.  Use temp_func to hold and
7630         delete temporary string obtained from cp_func_name.
7631
7632 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7633
7634         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7635         gdb::char_vector, remove cleanup, and update uses of `msg`.
7636
7637 2019-01-03  Jim Wilson  <jimw@sifive.com>
7638
7639         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7640
7641 2019-01-02  Tom Tromey  <tom@tromey.com>
7642
7643         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7644         (tdesc_parse_xml): Remove cleanups.
7645         * target-descriptions.h (make_cleanup_free_target_description):
7646         Don't declare.
7647         (target_desc_deleter): New struct.
7648         (target_desc_up): New typedef.
7649         * target-descriptions.c (target_desc_deleter::operator()): Rename
7650         from free_target_description.
7651         (make_cleanup_free_target_description): Remove.
7652
7653 2019-01-02  Tom Tromey  <tom@tromey.com>
7654
7655         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7656         constructor, destructor.
7657         (linespec_parser): Remove typedef.
7658         (~linespec_parser): Rename from linespec_parser_delete.
7659         (linespec_lex_to_end, linespec_complete_label)
7660         (linespec_complete): Update.
7661         (decode_line_full): Remove cleanups.
7662         (decode_line_1): Update.
7663
7664 2019-01-02  Tom Tromey  <tom@tromey.com>
7665
7666         * python/python-internal.h (inferior_to_inferior_object): Change
7667         return type.
7668         * python/py-exitedevent.c (create_exited_event_object): Update.
7669         * python/py-inferior.c (inferior_to_inferior_object): Return
7670         gdbpy_ref.
7671         (python_new_inferior, python_inferior_deleted)
7672         (thread_to_thread_object, delete_thread_object)
7673         (build_inferior_list, gdbpy_selected_inferior): Update.
7674         * python/py-infthread.c (create_thread_object): Update.  Also fail
7675         if inferior_to_inferior_object fails.
7676
7677 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7678
7679         * inferior.h (class inferior) <displaced_step_state>: New field.
7680         * infrun.h (struct displaced_step_state): Move here from
7681         infrun.c.  Initialize fields, add constructor.
7682         <inf>: Remove field.
7683         <reset>: New method.
7684         * infrun.c (struct displaced_step_inferior_state): Move to
7685         infrun.h.
7686         (displaced_step_inferior_states): Remove.
7687         (get_displaced_stepping_state): Adust.
7688         (displaced_step_in_progress_any_inferior): Adjust.
7689         (displaced_step_in_progress_thread): Adjust.
7690         (displaced_step_in_progress): Adjust.
7691         (add_displaced_stepping_state): Remove.
7692         (get_displaced_step_closure_by_addr): Adjust.
7693         (remove_displaced_stepping_state): Remove.
7694         (infrun_inferior_exit): Call displaced_step_state.reset.
7695         (use_displaced_stepping): Don't check for NULL.
7696         (displaced_step_prepare_throw): Call
7697         get_displaced_stepping_state.
7698         (displaced_step_fixup): Don't check for NULL.
7699         (prepare_for_detach): Don't check for NULL.
7700
7701 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7702
7703         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7704          in case of call that did not complete.
7705
7706 2019-01-02  Andrey Utkin  <autkin@undo.io>
7707
7708         * symfile.c (find_separate_debug_file): Fix search of debug files for
7709         remote debuggee.
7710
7711 2019-01-02  Tom Tromey  <tom@tromey.com>
7712
7713         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7714         indentation.
7715         * python/py-frame.c (frapy_older): Remove cast.
7716         (frapy_newer): Likewise.
7717         * python/py-breakpoint.c (local_setattro): Remove cast.
7718         * python/py-arch.c (archpy_name): Remove local variable.
7719         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7720
7721 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7722
7723         * unittests/basic_string_view/element_access/char/empty.cc:
7724         Fix year range in copyright header.
7725
7726 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7727
7728         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7729         Delete.
7730         <operator==>: Update with for removed field.
7731         <hash>: Likewise.
7732         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7733         <isa_features>: ...this.
7734         <abi_features>: New field.
7735         (riscv_isa_flen): Update comment.
7736         (riscv_abi_xlen): New declaration.
7737         (riscv_abi_flen): New declaration.
7738         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7739         isa_features.
7740         (riscv_abi_xlen): New function.
7741         (riscv_isa_flen): Update to get answer from isa_features.
7742         (riscv_abi_flen): New function.
7743         (riscv_has_fp_abi): Update to get answer from abi_features.
7744         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7745         xlen and flen.
7746         (riscv_call_info) <xlen, flen>: Update comment.
7747         (riscv_call_arg_struct): Remove invalid assertions
7748         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7749         is removed.
7750         (riscv_gdbarch_init): Gather isa features and abi features
7751         separately, ensure both match on the gdbarch when reusing an old
7752         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7753         a target with 64-bit float hardware.
7754
7755 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7756
7757         * source.c (search_command_helper): Stop reverse search
7758         when line 1 has been searched.
7759
7760 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7761
7762         * record-full.c (record_full_base_target::close): Rewrite
7763         record_full_core_buf_list free logic.
7764
7765 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7766
7767         * break-catch-syscall.c (print_one_catch_syscall): xfree
7768         the last text.
7769
7770 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7771
7772         * top.c (print_gdb_version): Update Copyright year in version
7773         message.
7774
7775 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7776
7777         Update copyright year range in all GDB files.
7778
7779 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7780
7781         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7782
7783 For older changes see ChangeLog-2018.
7784 \f
7785 Local Variables:
7786 mode: change-log
7787 left-margin: 8
7788 fill-column: 74
7789 version-control: never
7790 coding: utf-8
7791 End:
7792