gdb/ChangeLog

   1 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
   2
   3         * version.in: Change version number to "9.0.50.DATE-git".
   4
   5 2019-10-03  Tom Tromey  <tom@tromey.com>
   6
   7         PR rust/24976:
   8         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
   9
  10 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
  11
  12         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
  13         cp_search_name_hash.
  14         * NEWS: Add entry about nested function support.
  15
  16 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
  17             Andrew Burgess  <andrew.burgess@embecosm.com>
  18
  19         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
  20         for nested static variables when searchin VAR_DOMAIN.
  21         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
  22         global scope, update comment.
  23         (add_partial_subprogram): Call add_partial_subprogram recursively
  24         for nested subroutines when processinng Fortran.
  25         (load_partial_dies): Process the child entities of a subprogram
  26         when processing Fortran.
  27         (partial_die_parent_scope): Handle building scope
  28         for Fortran nested functions.
  29         (process_die): Record that nested functions have a scope.
  30         (new_symbol): Always record Fortran subprograms on the global
  31         symbol list.
  32         (determine_prefix): How to build the prefix for Fortran
  33         subprograms.
  34
  35 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
  36
  37         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
  38         have just sent the thread a SIGSTOP and are waiting for it to
  39         arrive.
  40
  41 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
  42
  43         * btrace.c (btrace_add_pc): Remove whitespace before the template
  44         parameter in 'std::vector <...>'.
  45         (parse_xml_btrace_block): Likewise.
  46         (btrace_maint_decode_pt): Likewise.
  47         (btrace_maint_update_packets): Likewise.
  48         (btrace_maint_print_packets): Likewise.
  49         * btrace.h (struct btrace_maint_info): Likewise.
  50         * dwarf2read.c (struct type_unit_group): Likewise.
  51         (build_type_psymtabs_reader): Likewise.
  52         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
  53         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
  54         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
  55
  56 2019-10-03  Tom de Vries  <tdevries@suse.de>
  57
  58         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
  59         the first line of the help text for set/show style metadata.
  60
  61 2019-10-02  Tom Tromey  <tromey@adacore.com>
  62
  63         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
  64         * gdbsupport/common-inferior.c: New file.
  65         * infcmd.c (startup_with_shell): Don't define.
  66         * nat/fork-inferior.h (startup_with_shell): Don't declare.
  67         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
  68         * inferior.h (startup_with_shell): Don't declare.
  69
  70 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
  71
  72         * gdbsupport/gdb_assert.h: Include errors.h.
  73         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
  74
  75 2019-10-02  Tom Tromey  <tromey@adacore.com>
  76
  77         * NEWS: Add $_ada_exception entry.
  78         * ada-lang.c (struct ada_catchpoint): Add constructor.
  79         <m_kind>: New member.
  80         (allocate_location_exception, re_set_exception): Remove
  81         "ex" parameter.
  82         (should_stop_exception): Compute $_ada_exception.
  83         (check_status_exception, print_it_exception)
  84         (print_one_exception, print_mention_exception): Remove
  85         "ex" parameter.
  86         (allocate_location_catch_exception, re_set_catch_exception)
  87         (check_status_exception, print_it_catch_exception)
  88         (print_one_catch_exception, print_mention_catch_exception)
  89         (print_recreate_catch_exception)
  90         (allocate_location_catch_exception_unhandled)
  91         (re_set_catch_exception_unhandled)
  92         (check_status_exception, print_it_catch_exception_unhandled)
  93         (print_one_catch_exception_unhandled)
  94         (print_mention_catch_exception_unhandled)
  95         (print_recreate_catch_exception_unhandled)
  96         (allocate_location_catch_assert, re_set_catch_assert)
  97         (check_status_assert, print_it_catch_assert)
  98         (print_one_catch_assert, print_mention_catch_assert)
  99         (print_recreate_catch_assert)
 100         (allocate_location_catch_handlers, re_set_catch_handlers)
 101         (check_status_handlers, print_it_catch_handlers)
 102         (print_one_catch_handlers, print_mention_catch_handlers)
 103         (print_recreate_catch_handlers): Remove.
 104         (create_ada_exception_catchpoint): Update.
 105         (initialize_ada_catchpoint_ops): Update.
 106
 107 2019-10-02  Tom Tromey  <tromey@adacore.com>
 108
 109         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 110         (create_excep_cond_exprs): Simplify exception string computation.
 111         (ada_exception_catchpoint_cond_string): Likewise.
 112
 113 2019-10-02  Tom Tromey  <tromey@adacore.com>
 114
 115         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 116         * ada-lang.c (lesseq_defined_than): Handle
 117         LOC_STATIC.
 118         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 119         parameter.
 120         (dwarf2_has_info): Likewise.
 121         (new_symbol): Set maybe_copied on symbol when
 122         appropriate.
 123         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 124         parameter.
 125         <can_copy>: New member.
 126         * elfread.c (record_minimal_symbol): Set maybe_copied
 127         on symbol when appropriate.
 128         (elf_symfile_read): Update call to dwarf2_has_info.
 129         * minsyms.c (lookup_minimal_symbol_linkage): New
 130         function.
 131         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 132         * symtab.c (get_symbol_address, get_msymbol_address):
 133         New functions.
 134         * symtab.h (get_symbol_address, get_msymbol_address):
 135         Declare.
 136         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 137         maybe_copied.
 138         (struct symbol, struct minimal_symbol) <maybe_copied>:
 139         New member.
 140
 141 2019-10-02  Tom Tromey  <tromey@adacore.com>
 142
 143         * source.c (struct current_source_location): New.
 144         (current_source_key): New global.
 145         (current_source_symtab, current_source_line)
 146         (current_source_pspace): Remove.
 147         (get_source_location): New function.
 148         (get_current_source_symtab_and_line)
 149         (set_default_source_symtab_and_line)
 150         (set_current_source_symtab_and_line)
 151         (clear_current_source_symtab_and_line, select_source_symtab)
 152         (info_source_command, print_source_lines_base)
 153         (info_line_command, search_command_helper, _initialize_source):
 154         Update.
 155
 156 2019-10-02  Tom Tromey  <tromey@adacore.com>
 157
 158         * source.c (select_source_symtab): Don't call
 159         decode_line_with_current_source.
 160
 161 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 162
 163         * symtab.c (lookup_global_symbol): Search global block.
 164
 165 2019-10-02  Tom Tromey  <tromey@adacore.com>
 166
 167         * coffread.c (process_coff_symbol): Update.
 168         * dwarf2read.c (var_decode_location, new_symbol): Update.
 169         * mdebugread.c (parse_symbol): Update.
 170         * objfiles.c (relocate_one_symbol): Update.
 171         * stabsread.c (define_symbol, fix_common_block)
 172         (scan_file_globals): Update.
 173         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 174         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 175         * xcoffread.c (process_xcoff_symbol): Update.
 176
 177 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 178
 179         * MAINTAINERS: Update my email address.
 180
 181 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 182
 183         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 184         std::vector.
 185         (build_type_psymtabs_reader): Update for std::vector.
 186         (build_type_psymtab_dependencies): Likewise.
 187         * dwarf2read.h: Remove use of DEF_VEC_P.
 188         (typedef sig_type_ptr): Delete.
 189
 190 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 191
 192         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 193         to std::vector.
 194         (btrace_maint_decode_pt): Likewise, and move allocation of the
 195         vector outside of the loop.
 196         (btrace_maint_update_packets): Update to handle change from VEC to
 197         std::vector.
 198         (btrace_maint_print_packets): Likewise.
 199         (maint_info_btrace_cmd): Likewise.
 200         * btrace.h: Remove use of DEF_VEC_O.
 201         (typedef btrace_pt_packet_s): Delete.
 202         (struct btrace_maint_info) <packets>: Change fromm VEC to
 203         std::vector.
 204         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 205
 206 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 207
 208         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 209         make accesses into the vector constant references.
 210         (btrace_add_pc): Update for std::vector.
 211         (btrace_stitch_bts): Likewise.
 212         (parse_xml_btrace_block): Likewise.
 213         (btrace_maint_update_packets): Likewise.
 214         (btrace_maint_print_packets): Likewise.
 215         (maint_info_btrace_cmd): Likewise.
 216         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 217         std::vector.
 218         (btrace_data::empty): Likewise.
 219         (btrace_data_append): Likewise.
 220         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 221         (typedef btrace_block_s): Delete.
 222         (struct btrace_block): Add constructor.
 223         (struct btrace_data_bts) <blocks>: Change to std::vector.
 224         * nat/linux-btrace.c (perf_event_read_bts): Update for
 225         std::vector.
 226         (linux_read_bts): Likewise.
 227
 228 2019-10-01  Tom Tromey  <tom@tromey.com>
 229
 230         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 231
 232 2019-10-01  Tom Tromey  <tom@tromey.com>
 233
 234         * stack.c (print_frame, info_frame_command_core): Use
 235         styled_string.
 236         * linux-thread-db.c (try_thread_db_load_1)
 237         (try_thread_db_load_from_pdir_1): Use styled_string.
 238         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 239         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 240         (maybe_print_unsupported_script_warning)
 241         (maybe_print_script_not_found_warning): Use styled_string.
 242         * ada-lang.c (user_select_syms): Use styled_string.
 243
 244 2019-10-01  Tom Tromey  <tom@tromey.com>
 245
 246         * p-lang.c (pascal_printstr): Use metadata style.
 247         * value.c (show_convenience): Use metadata style.
 248         * valprint.c (valprint_check_validity, val_print_optimized_out)
 249         (val_print_not_saved, val_print_unavailable)
 250         (val_print_invalid_address, generic_val_print, val_print)
 251         (value_check_printable, val_print_array_elements): Use metadata
 252         style.
 253         * ui-out.h (class ui_out) <field_fmt>: New overload.
 254         <do_field_fmt>: Add style parameter.
 255         * ui-out.c (ui_out::field_fmt): New overload.
 256         * typeprint.c (type_print_unknown_return_type)
 257         (val_print_not_allocated, val_print_not_associated): Use metadata
 258         style.
 259         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 260         parameter.
 261         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 262         * tracepoint.c (tvariables_info_1): Use metadata style.
 263         * stack.c (print_frame_arg, print_frame_info, print_frame)
 264         (info_frame_command_core): Use metadata style.
 265         * skip.c (info_skip_command): Use metadata style.
 266         * rust-lang.c (rust_print_enum): Use metadata style.
 267         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 268         metadata style.
 269         * python/py-framefilter.c (py_print_single_arg): Use metadata
 270         style.
 271         * printcmd.c (do_one_display, print_variable_and_value): Use
 272         metadata style.
 273         * p-valprint.c (pascal_val_print)
 274         (pascal_object_print_value_fields): Use metadata style.
 275         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 276         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 277         parameter.
 278         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 279         * m2-valprint.c (m2_print_long_set): Use metadata style.
 280         * m2-typeprint.c (m2_print_type): Use metadata style.
 281         * infcmd.c (print_return_value_1): Use metadata style.
 282         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 283         * f-valprint.c (info_common_command_for_block): Use metadata
 284         style.
 285         * f-typeprint.c (f_type_print_base): Use metadata style.
 286         * expprint.c (print_subexp_standard): Use metadata style.
 287         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 288         * cli/cli-style.h (class cli_style_option): Add constructor.
 289         (metadata_style): Declare.
 290         * cli/cli-style.c (metadata_style): New global.
 291         (_initialize_cli_style): Register metadata style.
 292         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 293         parameter.
 294         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 295         * c-typeprint.c (c_type_print_base_struct_union)
 296         (c_type_print_base_1): Use metadata style.
 297         * breakpoint.c (watchpoint_value_print)
 298         (print_one_breakpoint_location): Use metadata style.
 299         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 300         style.
 301         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 302         style.
 303         * ada-valprint.c (val_print_packed_array_elements, printstr)
 304         (print_field_values, ada_val_print_ref, ada_val_print): Use
 305         metadata style.
 306         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 307         style.
 308         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 309         style.
 310         * ada-lang.c (user_select_syms): Use metadata style.
 311
 312 2019-10-01  Tom Tromey  <tom@tromey.com>
 313
 314         * cli/cli-cmds.c (pwd_command): Style output.
 315
 316 2019-10-01  Pedro Alves  <palves@redhat.com>
 317             Tom Tromey  <tom@tromey.com>
 318
 319         * symtab.c (print_symbol_info): Use %ps.
 320         (print_msymbol_info): Use %ps.
 321         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 322         * printcmd.c (print_variable_and_value): Use %ps.
 323         * macrocmd.c (show_pp_source_pos): Use %ps.
 324         * infrun.c (print_exited_reason): Use ui_out::message.
 325         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 326         (describe_other_breakpoints): Use ui_out::message and new
 327         formats.
 328         (say_where): Use new formats.
 329         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 330         and new formats.
 331
 332 2019-10-01  Pedro Alves  <palves@redhat.com>
 333             Tom Tromey  <tom@tromey.com>
 334
 335         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 336         (test_gdb_formats): New function.
 337         (run_tests): Call it.
 338         (test_format_specifier): Update.
 339         * utils.h (fputs_filtered): Update comment.
 340         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 341         (fputs_styled_unfiltered): Declare.
 342         * utils.c (fputs_styled_unfiltered): New function.
 343         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 344         (vfprintf_filtered): Update.
 345         (vfprintf_unfiltered, vprintf_filtered): Update.
 346         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 347         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 348         disallow_ui_out_field>: New constants.
 349         (enum class field_kind): New.
 350         (struct base_field_s, struct signed_field_s): New.
 351         (signed_field): New function.
 352         (struct string_field_s): New.
 353         (string_field): New function.
 354         (struct styled_string_s): New.
 355         (styled_string): New function.
 356         (class ui_out) <message>: Add comment.
 357         <vmessage, call_do_message>: New methods.
 358         <do_message>: Add style parameter.
 359         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 360         methods.
 361         (ui_out::message): Rewrite.
 362         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 363         parameter.
 364         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 365         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 366         gdb_extensions parameter.
 367         (class format_piece): Add parameter to constructor.
 368         (n_int_args): New field.
 369         * gdbsupport/format.c (format_pieces::format_pieces): Add
 370         gdb_extensions parameter.  Handle '*'.
 371         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 372         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 373         vfprintf_styled_no_gdbfmt.
 374         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 375         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 376         unfiltered output.
 377         * ui-style.h (struct ui_file_style) <ptr>: New method.
 378
 379 2019-10-01  Tom Tromey  <tom@tromey.com>
 380
 381         * unittests/format_pieces-selftests.c: Update.  Add final format.
 382         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 383         empty literal pieces.
 384
 385 2019-10-01  Tom Tromey  <tom@tromey.com>
 386
 387         * ui-out.h (enum class ui_out_style_kind): Remove.
 388         (class ui_out) <field_string, field_stsream, do_field_string>:
 389         Change type of "style".
 390         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 391         (ui_out::field_string): Update.
 392         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 393         of "style".
 394         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 395         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 396         * stack.c (print_frame_arg, print_frame_info, print_frame):
 397         Update.
 398         * source.c (print_source_lines_base): Update.
 399         * solib.c (info_sharedlibrary_command): Update.
 400         * skip.c (info_skip_command): Update.
 401         * record-btrace.c (btrace_call_history_src_line)
 402         (btrace_call_history): Update.
 403         * python/py-framefilter.c (py_print_frame): Update.
 404         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 405         "style".
 406         * mi/mi-out.c (mi_ui_out::do_table_header)
 407         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 408         (mi_ui_out::do_field_string): Update.
 409         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 410         Update.
 411         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 412         "style".
 413         * cli-out.c (cli_ui_out::do_table_header)
 414         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 415         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 416         (cli_ui_out::do_field_fmt): Update.
 417         * breakpoint.c (print_breakpoint_location): Update.
 418         (update_static_tracepoint): Update.
 419
 420 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 421
 422         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 423         conversion of gdb_datadir.
 424         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 425         remove not needed c_str ().
 426
 427 2019-09-30  Ali Tamur <tamur@google.com>
 428
 429         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 430         (dwarf2_string_attr): Likewise.
 431
 432 2019-09-30  Ali Tamur <tamur@google.com>
 433
 434         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 435         (process_full_type_unit): Likewise.
 436         (dump_die_shallow): Likewise.
 437         (cu_debug_loc_section): Likewise.
 438
 439 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 440
 441         * minsyms.c (compare_minimal_symbols): Rename to...
 442         (minimal_symbol_is_less_than): ...this, and adjust to STL
 443         conventions (return bool, take arguments as references)
 444         (minimal_symbol_reader::install): Call std::sort instead
 445         of qsort.
 446
 447 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 448
 449         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 450         hash and why.
 451         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 452         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 453
 454 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 455
 456         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 457         * psympriv.h (add_psymbol_to_list): Move comment here and update
 458         it.
 459
 460 2019-09-29  Tom de Vries  <tdevries@suse.de>
 461
 462         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 463         Use $tmpdir/$(basename "$output_file").dwz instead of
 464         "${output_file}.dwz".
 465
 466 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 467
 468         PR gdb/25045
 469         * hppa-linux-nat.c: Include gdbarch.h.
 470
 471 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 472
 473         * blockframe.c (find_pc_partial_function): Change return type to bool.
 474         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 475         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 476         (stub_gnu_ifunc_resolve_name): Likewise.
 477         * symtab.c (compare_filenames_for_search): Likewise.
 478         (compare_glob_filenames_for_search): Likewise.
 479         (matching_obj_sections): Likewise.
 480         (symbol_matches_domain): Likewise.
 481         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 482         (find_line_pc): Change return type to bool.
 483         (find_line_pc_range): Likewise.
 484         (producer_is_realview): Likewise.
 485         * symtab.h (symbol_matches_domain): Likewise.
 486         (find_pc_partial_function): Likewise.
 487         (find_pc_line_pc_range): Likewise.
 488         (in_gnu_ifunc_stub): Likewise.
 489         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 490         (find_line_pc): Likewise.
 491         (find_line_pc_range): Likewise.
 492         (matching_obj_sections): Likewise.
 493         (find_line_symtab): Change out parameter to bool.
 494         (producer_is_realview): Change return type to bool.
 495         (compare_filenames_for_search): Likewise.
 496         (compare_glob_filenames_for_search): Likewise.
 497
 498 2019-09-26  Tom Tromey  <tom@tromey.com>
 499
 500         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 501         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 502         * gdb_usleep.h: Remove.
 503         * gdb_usleep.c: Remove.
 504         * utils.c: Don't include gdb_usleep.h.
 505
 506 2019-09-26  Tom Tromey  <tromey@adacore.com>
 507
 508         * python/py-type.c (type_to_type_object): Call check_typedef
 509         for stub types.
 510
 511 2019-09-26  Tom Tromey  <tom@tromey.com>
 512
 513         * utils.h (initialize_utils): Don't declare.
 514         * top.c (gdb_init): Don't call initialize_utils.
 515         * utils.c (initialize_utils): Remove.  Move contents...
 516         (_initialize_utils): ... here.
 517
 518 2019-09-25  Tom Tromey  <tom@tromey.com>
 519
 520         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 521         * utils.h (make_hex_string): Don't declare.
 522         * utils.c (make_hex_string): Remove.
 523
 524 2019-09-24  Tom de Vries  <tdevries@suse.de>
 525
 526         PR gdb/23815
 527         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 528         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 529
 530 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 531
 532         * NEWS: Mention new simulator port for PRU.
 533
 534 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 535
 536         * ada-exp.y (write_object_remaining): Update.
 537         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 538         and eliminate the static buffer.
 539         (ada_decode_symbol): Update.
 540         (ada_la_decode): Update.
 541         (ada_sniff_from_mangled_name): Update.
 542         (is_valid_name_for_wild_match): Update.
 543         (ada_lookup_name_info::matches): Update and simplify.
 544         (name_matches_regex): Update.
 545         (ada_add_global_exceptions): Update.
 546         * ada-lang.h (ada_decode): Update signature.
 547         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 548         * dwarf-index-write.c (debug_names::insert): Update.
 549
 550 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 551
 552         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 553         formatting.
 554
 555 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 556
 557         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 558         Change "nonzero" to "true" in documentation.
 559
 560 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 561
 562         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 563         (_initialize_darwin_solib): Don't set
 564         darwin_so_ops.lookup_lib_global_symbol.
 565         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 566         set_gdbarch_iterate_over_objfiles_in_search_order.
 567         (elf_lookup_lib_symbol): Rename to...
 568         (svr4_iterate_over_objfiles_in_search_order): this, and update
 569         to iterate semantics.
 570         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 571         * solib.c (solib_global_lookup): Remove.
 572         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 573         (solib_global_lookup): Remove.
 574         * symtab.c (lookup_global_or_static_symbol): Remove call to
 575         solib_global_lookup.
 576
 577 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 578
 579         * NEWS: Move entries about default MI version now being
 580         version 3, and about the GDB/MI fix for multi-location
 581         breakpoints to the "since GDB 8.3" section.
 582
 583 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 584
 585         GDB 8.3.1 released.
 586
 587 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 588
 589         * NEWS: Mention that Cell/B.E. debugging support was removed.
 590         * MAINTAINERS: Remove spu target.
 591
 592         * config/djgpp/fnchange.lst: Remove entries for removed files.
 593
 594         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 595         spu-multiarch.o, and spu-tdep.o.
 596         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 597         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 598         spu-multiarch.c, and spu-tdep.c.
 599         * spu-linux-nat.c: Remove file.
 600         * spu-multiarch.c: Remove file.
 601         * spu-tdep.c: Remove file.
 602         * spu-tdep.h: Remove file.
 603         * solib-spu.c: Remove file.
 604         * solib-spu.h: Remove file.
 605
 606         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 607         * configure.nat (spu-linux): Remove.
 608         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 609         solib-multiarch.o from gdb_target_obs.
 610         (spu*-*-*): Remove.
 611
 612         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 613         feature flag.
 614         (ppc_linux_no_features): Update.
 615         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 616         Cell/B.E. support.
 617         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 618         (tdesc_powerpc_cell64l): Likewise.
 619         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 620         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 621         Cell/B.E. support.
 622         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 623         Do not include "features/rs6000/powerpc-cell32l.c" or
 624         "features/rs6000/powerpc-cell64l.c".
 625         (ppc_linux_spu_section): Remove.
 626         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 627         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 628         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 629         (ppc_linux_spe_context_lookup): Remove.
 630         (ppc_linux_spe_context_inferior_created): Remove.
 631         (ppc_linux_spe_context_solib_loaded): Remove.
 632         (ppc_linux_spe_context_solib_unloaded): Remove.
 633         (ppc_linux_spe_context): Remove.
 634         (struct ppu2spu_cache): Remove.
 635         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 636         (struct ppu2spu_data): Remove.
 637         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 638         ppu2spu_unwind): Remove.
 639         (ppc_linux_init_abi): Remove Cell/B.E. support.
 640         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 641
 642         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 643         (rs6000/powerpc-cell64l-expedite): Likewise
 644         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 645         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 646         rs6000/powerpc-cell64l.xml.
 647         * features/rs6000/powerpc-cell32l.xml: Remove.
 648         * features/rs6000/powerpc-cell64l.xml: Likewise.
 649         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 650         * features/rs6000/powerpc-cell64l.c: Likewise.
 651         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 652         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 653         * regformats/reg-spu.dat: Remove.
 654
 655         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 656         * corelow.c (struct spuid_list): Remove.
 657         (add_to_spuid_list): Remove.
 658         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 659         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 660         (remote_protocol_features): Remove associated entries.
 661         (_initialize_remote): No longer initialize them.
 662         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 663         * linux-nat.c (SPUFS_MAGIC): Remove.
 664         (linux_proc_xfer_spu): Remove.
 665         (spu_enumerate_spu_ids): Remove.
 666         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 667         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 668         (linux_make_corefile_notes): No longer call it.
 669
 670         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 671         (cooked_write_test): Likewise.
 672
 673 2019-09-20  Tom Tromey  <tom@tromey.com>
 674
 675         * NEWS: Mention case-sensitivity of TUI commands.
 676         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 677         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 678         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 679
 680 2019-09-20  Tom Tromey  <tom@tromey.com>
 681
 682         * tui/tui-source.c (tui_source_window::set_contents): Use
 683         make_unique_xstrdup.
 684         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 685         make_unique_xstrdup.
 686
 687 2019-09-20  Tom Tromey  <tom@tromey.com>
 688
 689         * tui/tui-data.c: Remove separator comments.
 690         * tui/tui-layout.c: Remove separator comments.
 691         * tui/tui-win.c: Remove separator comments.
 692         * tui/tui-wingeneral.c: Remove separator comments.
 693
 694 2019-09-20  Tom Tromey  <tom@tromey.com>
 695
 696         * tui/tui.h (strcat_to_buf): Don't declare.
 697         * tui/tui.c (strcat_to_buf): Remove.
 698
 699 2019-09-20  Tom Tromey  <tom@tromey.com>
 700
 701         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 702         from "fullname".
 703         * tui/tui-source.c (tui_source_window::set_contents)
 704         (tui_source_window::location_matches_p)
 705         (tui_source_window::maybe_update): Update.
 706
 707 2019-09-20  Tom Tromey  <tom@tromey.com>
 708
 709         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 710         Update.
 711         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 712         prefix.
 713         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 714         (tui_data_window::line_from_reg_element_no)
 715         (tui_data_window::first_reg_element_no_inline)
 716         (tui_data_window::show_registers)
 717         (tui_data_window::show_register_group)
 718         (tui_data_window::display_registers_from)
 719         (tui_data_window::display_registers_from_line)
 720         (tui_data_window::first_data_item_displayed)
 721         (tui_data_window::delete_data_content_windows)
 722         (tui_data_window::erase_data_content)
 723         (tui_data_window::do_scroll_vertical)
 724         (tui_data_window::refresh_window)
 725         (tui_data_window::check_register_values): Update.
 726
 727 2019-09-20  Tom Tromey  <tom@tromey.com>
 728
 729         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 730         (struct tui_locator_window) <full_name, proc_name>: Now
 731         std::string.
 732         * tui/tui-stack.c (tui_locator_window::make_status_line)
 733         (tui_locator_window::set_locator_fullname)
 734         (tui_locator_window::set_locator_info): Update.
 735         * tui/tui-source.c (tui_source_window::set_contents)
 736         (tui_source_window::showing_source_p): Update.
 737
 738 2019-09-20  Tom Tromey  <tom@tromey.com>
 739
 740         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 741         Don't call tui_locator_win_info_ptr.
 742
 743 2019-09-20  Tom Tromey  <tom@tromey.com>
 744
 745         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 746
 747 2019-09-20  Tom Tromey  <tom@tromey.com>
 748
 749         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 750         height for locator.
 751         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 752         * tui/tui-layout.c (show_source_disasm_command, show_data)
 753         (show_source_or_disasm_and_command): Use 1 as height for locator.
 754
 755 2019-09-20  Tom Tromey  <tom@tromey.com>
 756
 757         * tui/tui.c (tui_enable): Update.
 758         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 759         Update.
 760         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 761         Update.
 762         * tui/tui-data.c (win_resized): Now bool.
 763         (tui_win_resized): Return bool.
 764         (tui_set_win_resized_to): Accept a bool.
 765
 766 2019-09-20  Tom Tromey  <tom@tromey.com>
 767
 768         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 769         Change type of "refresh_values_only".
 770         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 771         type of "refresh_values_only".
 772
 773 2019-09-20  Tom Tromey  <tom@tromey.com>
 774
 775         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 776         std::string.
 777         (tui_disassemble): Add "pos" parameter.
 778         (tui_disasm_window::set_contents): Simplify.
 779
 780 2019-09-20  Tom Tromey  <tom@tromey.com>
 781
 782         * tui/tui-winsource.h (struct tui_source_window_base)
 783         <show_source_content>: Now private.
 784         * tui/tui-winsource.c
 785         (tui_source_window_base::show_source_content): Don't handle empty
 786         content case.
 787
 788 2019-09-20  Tom Tromey  <tom@tromey.com>
 789
 790         * tui/tui-layout.c (show_source_disasm_command)
 791         (show_source_or_disasm_and_command): Don't call
 792         show_source_content.
 793
 794 2019-09-20  Tom Tromey  <tom@tromey.com>
 795
 796         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 797         Declare.
 798         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 799         from tui_make_status_line.
 800         (tui_locator_window::rerender): Update.
 801
 802 2019-09-20  Tom Tromey  <tom@tromey.com>
 803
 804         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 805         (tui_locator_window::rerender): Update.
 806
 807 2019-09-20  Tom Tromey  <tom@tromey.com>
 808
 809         * tui/tui-winsource.h (struct tui_source_window_base)
 810         <~tui_source_window_base>: Don't declare.
 811         <fullname>: Remove.
 812         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 813         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 814         member.
 815         * tui/tui-source.c (tui_source_window::set_contents): Update.
 816         (tui_source_window::location_matches_p)
 817         (tui_source_window::maybe_update): Update.
 818
 819 2019-09-20  Tom Tromey  <tom@tromey.com>
 820
 821         * tui/tui-winsource.h (~tui_source_element): Remove.
 822         (tui_source_element): Update.
 823         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 824         * tui/tui-winsource.c (tui_show_source_line): Update.
 825         * tui/tui-source.c (tui_source_window::set_contents): Update.
 826         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 827
 828 2019-09-20  Tom Tromey  <tom@tromey.com>
 829
 830         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 831         declare.
 832         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 833         tui_clear_source_windows_detail.
 834         * tui/tui-winsource.h (struct tui_source_window_base)
 835         <clear_detail>: Don't declare.
 836         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 837         Remove.
 838         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 839
 840 2019-09-20  Tom Tromey  <tromey@adacore.com>
 841
 842         PR ada/24919:
 843         * block.c (contained_in): Fix final return value.
 844
 845 2019-09-20  Alan Modra  <amodra@gmail.com>
 846
 847         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 848         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 849         (read_indirect_string_from_dwz): Use bfd accessor.
 850         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 851         * machoread.c (macho_symfile_read_all_oso): Likewise.
 852         * solib.c (solib_bfd_open): Likewise.
 853
 854 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 855
 856         * eval.c: Move declaration of overload_resolution to...
 857         * value.h: ...here.
 858
 859 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 860
 861         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 862         * arm-linux-tdep.c: Likewise.
 863         * arm-nbsd-nat.c: Likewise.
 864         * arm-tdep.h: Declare arm_apcs_32.
 865         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 866
 867 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 868
 869         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 870         * dwarf2read.h: Declare dwarf_always_disassemble.
 871
 872 2019-09-19  Tom de Vries  <tdevries@suse.de>
 873
 874         PR gdb/25009
 875         * source-cache.c (source_cache::ensure): Catch exception thrown during
 876         construction of the highlighter.
 877
 878 2019-09-18  Alan Modra  <amodra@gmail.com>
 879
 880         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 881         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 882         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 883         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 884         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 885         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 886         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 887         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 888         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 889         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 890         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 891         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 892         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 893         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 894         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 895         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 896         * mi/mi-interp.c: Update throughout for bfd section macro and
 897         function changes.
 898         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 899         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 900
 901 2019-09-18  Tom Tromey  <tom@tromey.com>
 902
 903         * NEWS: Add entry.
 904         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 905         call rl_initialize.
 906         (tui_enable): Do not call rl_initialize.
 907
 908 2019-09-18  Christian Groessler  <chris@groessler.org>
 909
 910         * alpha-linux-nat.c: Include gdbarch.h.
 911
 912 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 913
 914         * ui-file.c: Include cli/cli-style.h.
 915         (term_cli_styling): Remove cli_styling declaration.
 916
 917 2019-09-18  Alan Modra  <amodra@gmail.com>
 918
 919         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 920         to bfd_asymbol_section.
 921
 922 2019-09-18  Alan Modra  <amodra@gmail.com>
 923
 924         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 925         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 926         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 927
 928 2019-09-18  Alan Modra  <amodra@gmail.com>
 929
 930         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 931         * spu-linux-nat.c (spu_bfd_open): Likewise.
 932
 933 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 934
 935         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 936         to bool to match definition in dwarf2read.c.
 937
 938 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 939
 940         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 941         (print_signatures): Likewise.
 942         (trust_pad_over_xvs): Likewise.
 943         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 944         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 945         * arm-linux-nat.c (arm_apcs_32): Likewise.
 946         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 947         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 948         * arm-tdep.c (arm_debug): Likewise.
 949         (arm_apcs_32): Likewise.
 950         * auto-load.c (debug_auto_load): Likewise.
 951         (auto_load_gdb_scripts): Likewise.
 952         (global_auto_load): Likewise.
 953         (auto_load_local_gdbinit): Likewise.
 954         (auto_load_local_gdbinit_loaded): Likewise.
 955         * auto-load.h (global_auto_load): Likewise.
 956         (auto_load_local_gdbinit): Likewise.
 957         (auto_load_local_gdbinit_loaded): Likewise.
 958         * breakpoint.c (disconnected_dprintf): Likewise.
 959         (breakpoint_proceeded): Likewise.
 960         (automatic_hardware_breakpoints): Likewise.
 961         (always_inserted_mode): Likewise.
 962         (target_exact_watchpoints): Likewise.
 963         (_initialize_breakpoint): Update.
 964         * breakpoint.h (target_exact_watchpoints): Change to bool.
 965         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 966         * cli/cli-cmds.c (trace_commands): Likewise.
 967         * cli/cli-cmds.h (trace_commands): Likewise.
 968         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 969         to bool*.
 970         * cli/cli-logging.c (logging_overwrite): Change to bool.
 971         (logging_redirect): Likewise.
 972         (debug_redirect): Likewise.
 973         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 974         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 975         to bool.
 976         <boolean_option_def>: Update.
 977         (struct flag_option_def): Change default type of Context to bool
 978         from int.
 979         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 980         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 981         (get_setshow_command_value_string): Likewise.
 982         * cli/cli-style.c (cli_styling): Change to bool.
 983         (source_styling): Likewise.
 984         * cli/cli-style.h (source_styling): Likewise.
 985         (cli_styling): Likewise.
 986         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 987         to bool.
 988         * command.h (var_types): Update comment.
 989         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 990         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 991         bool.
 992         (debug_compile_cplus_scopes): Likewise.
 993         * compile/compile-internal.h (compile_debug): Likewise.
 994         * compile/compile.c (compile_debug): Likewise.
 995         (struct compile_options) <raw>: Likewise.
 996         * cp-support.c (catch_demangler_crashes): Likewise.
 997         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 998         (usr_cmd_cris_dwarf2_cfi): Likewise.
 999         * csky-tdep.c (csky_debug): Likewise.
1000         * darwin-nat.c (enable_mach_exceptions): Likewise.
1001         * dcache.c (dcache_enabled_p): Likewise.
1002         * defs.h (info_verbose): Likewise.
1003         * demangle.c (demangle): Likewise.
1004         (asm_demangle): Likewise.
1005         * dwarf-index-cache.c (debug_index_cache): Likewise.
1006         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1007         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1008         * dwarf2read.c (check_physname): Likewise.
1009         (use_deprecated_index_sections): Likewise.
1010         (dwarf_always_disassemble): Likewise.
1011         * eval.c (overload_resolution): Likewise.
1012         * event-top.c (set_editing_cmd_var): Likewise.
1013         (exec_done_display_p): Likewise.
1014         * event-top.h (set_editing_cmd_var): Likewise.
1015         (exec_done_display_p): Likewise.
1016         * exec.c (write_files): Likewise.
1017         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1018         (debug_fbsd_nat): Likewise.
1019         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1020         Likewise.
1021         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1022         <backtrace_past_entry> Likewise.
1023         * gdb-demangle.h (demangle): Likewise.
1024         (asm_demangle): Likewise.
1025         * gdb_bfd.c (bfd_sharing): Likewise.
1026         * gdbcore.h (write_files): Likewise.
1027         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1028         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1029         * gdbthread.h (print_thread_events): Likewise.
1030         * gdbtypes.c (opaque_type_resolution): Likewise.
1031         (strict_type_checking): Likewise.
1032         * gnu-nat.c (gnu_debug_flag): Likewise.
1033         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1034         * guile/scm-param.c (pascm_variable): Add boolval.
1035         (add_setshow_generic): Update.
1036         (pascm_param_value): Update.
1037         (pascm_set_param_value_x): Update.
1038         * hppa-tdep.c (hppa_debug): Change to bool..
1039         * infcall.c (may_call_functions_p): Likewise.
1040         (coerce_float_to_double_p): Likewise.
1041         (unwind_on_signal_p): Likewise.
1042         (unwind_on_terminating_exception_p): Likewise.
1043         * infcmd.c (startup_with_shell): Likewise.
1044         * inferior.c (print_inferior_events): Likewise.
1045         * inferior.h (startup_with_shell): Likewise.
1046         (print_inferior_events): Likewise.
1047         * infrun.c (step_stop_if_no_debug): Likewise.
1048         (detach_fork): Likewise.
1049         (debug_displaced): Likewise.
1050         (disable_randomization): Likewise.
1051         (non_stop): Likewise.
1052         (non_stop_1): Likewise.
1053         (observer_mode): Likewise.
1054         (observer_mode_1): Likewise.
1055         (set_observer_mode): Update.
1056         (sched_multi): Change to bool.
1057         * infrun.h (debug_displaced): Likewise.
1058         (sched_multi): Likewise.
1059         (step_stop_if_no_debug): Likewise.
1060         (non_stop): Likewise.
1061         (disable_randomization): Likewise.
1062         * linux-tdep.c (use_coredump_filter): Likewise.
1063         (dump_excluded_mappings): Likewise.
1064         * linux-thread-db.c (auto_load_thread_db): Likewise.
1065         (check_thread_db_on_load): Likewise.
1066         * main.c (captured_main_1): Update.
1067         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1068         xx2_opt, boolean_opt>: Change to bool.
1069         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1070         * maint.c (maintenance_profile_p): Likewise.
1071         (per_command_time): Likewise.
1072         (per_command_space): Likewise.
1073         (per_command_symtab): Likewise.
1074         * memattr.c (inaccessible_by_default): Likewise.
1075         * mi/mi-main.c (mi_async): Likewise.
1076         (mi_async_1): Likewise.
1077         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1078         * nat/fork-inferior.h (startup_with_shell): Likewise.
1079         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1080         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1081         * nios2-tdep.c (nios2_debug): Likewise.
1082         * or1k-tdep.c (or1k_debug): Likewise.
1083         * parse.c (parser_debug): Likewise.
1084         * parser-defs.h (parser_debug): Likewise.
1085         * printcmd.c (print_symbol_filename): Likewise.
1086         * proc-api.c (procfs_trace): Likewise.
1087         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1088         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1089         (set_parameter_value): Update.
1090         (add_setshow_generic): Update.
1091         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1092         to bool*.
1093         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1094         int*.
1095         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1096         * record-btrace.c (record_btrace_target::store_registers): Update.
1097         * record-full.c (record_full_memory_query): Change to bool.
1098         (record_full_stop_at_limit): Likewise.
1099         * record-full.h (record_full_memory_query): Likewise.
1100         * remote-notif.c (notif_debug): Likewise.
1101         * remote-notif.h (notif_debug): Likewise.
1102         * remote.c (use_range_stepping): Likewise.
1103         (interrupt_on_connect): Likewise.
1104         (remote_break): Likewise.
1105         * ser-tcp.c (tcp_auto_retry): Likewise.
1106         * ser-unix.c (serial_hwflow): Likewise.
1107         * skip.c (debug_skip): Likewise.
1108         * solib-aix.c (solib_aix_debug): Likewise.
1109         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1110         (spu_auto_flush_cache_p): Likewise.
1111         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1112         Likewise.
1113         (struct info_print_options) <quiet>: Likewise.
1114         * symfile-debug.c (debug_symfile): Likewise.
1115         * symfile.c (auto_solib_add): Likewise.
1116         (separate_debug_file_debug): Likewise.
1117         * symfile.h (auto_solib_add): Likewise.
1118         (separate_debug_file_debug): Likewise.
1119         * symtab.c (basenames_may_differ): Likewise.
1120         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1121         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1122         (struct info_types_options) <quiet>: Likewise.
1123         * symtab.h (demangle): Likewise.
1124         (basenames_may_differ): Likewise.
1125         * target-dcache.c (stack_cache_enabled_1): Likewise.
1126         (code_cache_enabled_1): Likewise.
1127         * target.c (trust_readonly): Likewise.
1128         (may_write_registers): Likewise.
1129         (may_write_memory): Likewise.
1130         (may_insert_breakpoints): Likewise.
1131         (may_insert_tracepoints): Likewise.
1132         (may_insert_fast_tracepoints): Likewise.
1133         (may_stop): Likewise.
1134         (auto_connect_native_target): Likewise.
1135         (target_stop_and_wait): Update.
1136         (target_async_permitted): Change to bool.
1137         (target_async_permitted_1): Likewise.
1138         (may_write_registers_1): Likewise.
1139         (may_write_memory_1): Likewise.
1140         (may_insert_breakpoints_1): Likewise.
1141         (may_insert_tracepoints_1): Likewise.
1142         (may_insert_fast_tracepoints_1): Likewise.
1143         (may_stop_1): Likewise.
1144         * target.h (target_async_permitted): Likewise.
1145         (may_write_registers): Likewise.
1146         (may_write_memory): Likewise.
1147         (may_insert_breakpoints): Likewise.
1148         (may_insert_tracepoints): Likewise.
1149         (may_insert_fast_tracepoints): Likewise.
1150         (may_stop): Likewise.
1151         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1152         (make_thread_apply_all_options_def_group): Change argument from int*
1153         to bool*.
1154         (thread_apply_all_command): Update.
1155         (print_thread_events): Change to bool.
1156         * top.c (confirm): Likewise.
1157         (command_editing_p): Likewise.
1158         (history_expansion_p): Likewise.
1159         (write_history_p): Likewise.
1160         (info_verbose): Likewise.
1161         * top.h (confirm): Likewise.
1162         (history_expansion_p): Likewise.
1163         * tracepoint.c (disconnected_tracing): Likewise.
1164         (circular_trace_buffer): Likewise.
1165         * typeprint.c (print_methods): Likewise.
1166         (print_typedefs): Likewise.
1167         * utils.c (debug_timestamp): Likewise.
1168         (sevenbit_strings): Likewise.
1169         (pagination_enabled): Likewise.
1170         * utils.h (sevenbit_strings): Likewise.
1171         (pagination_enabled): Likewise.
1172         * valops.c (overload_resolution): Likewise.
1173         * valprint.h (struct value_print_options) <prettyformat_arrays,
1174         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1175         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1176         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1177         Likewise.
1178         * windows-nat.c (new_console): Likewise.
1179         (cygwin_exceptions): Likewise.
1180         (new_group): Likewise.
1181         (debug_exec): Likewise.
1182         (debug_events): Likewise.
1183         (debug_memory): Likewise.
1184         (debug_exceptions): Likewise.
1185         (useshell): Likewise.
1186         * windows-tdep.c (maint_display_all_tib): Likewise.
1187         * xml-support.c (debug_xml): Likewise.
1188
1189 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1190
1191         * source.c (prepare_path_for_appending): New function.
1192         (openp): Make use of new function.
1193         (find_and_open_source): Search for the compilation directory and
1194         source file as a relative path beneath the directory search path.
1195
1196 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1197
1198         * source-cache.c (source_cache::get_line_charpos): Catch
1199         exceptions and return false, this matches the behaviour documented
1200         in the header file.
1201
1202 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1203
1204         * ada-tasks.c (info_task): Remove quoting of the task's name.
1205
1206 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1207
1208         * symfile.c (auto_solib_add): Replace comment with a reference
1209         to the header file.
1210
1211 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1212
1213         * NEWS: Mention that gdb can now be compiled with Python 3
1214         on Windows.
1215
1216 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1217
1218         * maint.c (maint_print_section_data::maint_print_section_data):
1219         Force use of 'float log10 (float)' by casting the argument to
1220         float.
1221
1222 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1223
1224         * maint.c: Add 'cmath' include.
1225         (struct maint_print_section_data): New structure.
1226         (print_section_index): New function.
1227         (print_bfd_section_info): Add header comment, small whitespace
1228         cleanup, and update to call new print_section_index function.
1229         (print_objfile_section_info): Likewise.
1230         (maint_obj_section_from_bfd_section): New function.
1231         (print_bfd_section_info_maybe_relocated): New function.
1232         (maintenance_info_sections): Add header comment, always use
1233         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1234
1235 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1236
1237         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1238         inner scope, add check that the objfile has psymtabs before
1239         checking psymtabs_addrmap.
1240         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1241
1242 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1243
1244         * NEWS: Announce that Ada task names are now shown at more places,
1245         and between quotes (except in info task output).
1246         * gdb/ada-tasks.c (task_to_str): New function.
1247         (display_current_task_id): Call task_to_str.
1248         (task_command_1): Likewise.
1249         (print_ada_task_info): In non-mi mode, Properly align headers and data
1250         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1251
1252 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1253
1254         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1255         prstatus.pr_lwp.pr_info instead of making it up.
1256
1257 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1258
1259         * auto-load.c (auto_load_expand_dir_vars): Update.
1260         * defs.h (gdb_datadir): Change to std::string.
1261         (python_libdir): Likewise.
1262         (relocate_gdb_directory): Change return type to std::string.
1263         * guile/guile.c (gdbscm_data_directory): Update.
1264         (initialize_scheme_side): Update.
1265         * jit.c (jit_reader_dir): Change to std::string.
1266         (jit_reader_load_command): Update.
1267         * main.c (gdb_datadir): Change to std::string.
1268         (python_libdir): Likewise.
1269         (set_gdb_data_directory): Update.
1270         (relocate_path): Change to return std::string.
1271         (relocate_gdb_directory): Change to return std::string.
1272         (relocate_gdbinit_path_maybe_in_datadir): Update.
1273         (captured_main_1): Update.
1274         * python/python.c (do_start_initialization): Update.
1275         * top.c (show_gdb_datadir): Update.
1276         * xml-syscall.c (xml_init_syscalls_info): Update.
1277         (init_syscalls_info): Update.
1278
1279 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1280
1281         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1282         out of get_init_files.
1283         (get_init_files): Update.
1284
1285 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1286
1287         * main.c (get_init_files): Change to use std::string.
1288         (captured_main_1): Update.
1289         (print_gdb_help): Update.
1290
1291 2019-09-11  Ali Tamur  <tamur@google.com>
1292
1293         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1294         implementation.
1295
1296 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1297
1298         * dbxread.c (read_dbx_symtab): Update.
1299         * dwarf2read.c (load_partial_dies): Update.
1300         * mdebugread.c (parse_partial_symbols): Update.
1301         (handle_psymbol_enumerators): Update.
1302         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1303         * psymtab.c (add_psymbol_to_bcache): Likewise.
1304         (add_psymbol_to_list): Likewise.
1305         * symtab.c (symbol_set_names): Likewise.
1306         * symtab.h (symbol_set_names): Likewise.
1307         * xcoffread.c (scan_xcoff_symtab): Update.
1308
1309 2019-09-11  Tom Tromey  <tom@tromey.com>
1310
1311         * symfile-mem.c (symbol_file_add_from_memory): Use
1312         bfd_set_filename.
1313         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1314         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1315
1316 2019-09-10  Tom Tromey  <tromey@adacore.com>
1317
1318         * dwarf-index-write.c (write_psymbols): Extend error message.
1319         (debug_names::insert): Add Ada code.
1320         (debug_names::write_psymbols): Remove Ada check.
1321         (debug_names) <m_string_obstack>: New member.
1322         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1323         (gdb_index_symbol_name_matcher::matches): Remove.
1324         (mapped_index_base::find_name_components_bounds): Add "lang"
1325         parameter.
1326         (mapped_index_base::build_name_components): Also split names
1327         according to Ada syntax.
1328         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1329         type of "match_callback".
1330         (check_match, check_find_bounds_finds)
1331         (dw2_expand_symtabs_matching): Update.
1332         (dw2_debug_names_iterator): Add new constructor.
1333         (dw2_debug_names_map_matching_symbols): New function.
1334         (dw2_debug_names_expand_symtabs_matching): Update.
1335         (dwarf2_debug_names_functions): Use
1336         dw2_debug_names_map_matching_symbols.
1337
1338 2019-09-10  Tom Tromey  <tromey@adacore.com>
1339
1340         * dwarf2read.c (dw2_get_file_names_reader): Add the
1341         CU's file name to the results.
1342
1343 2019-09-10  Tom Tromey  <tromey@adacore.com>
1344
1345         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1346         map_matching_symbols.  Update.
1347         * dwarf2read.c (dw2_map_matching_symbols): Update.
1348         * psymtab.c (match_partial_symbol): Change type; update.
1349         (psym_map_matching_symbols): Likewise.
1350         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1351         type; update.
1352         * symfile.h (struct quick_symbol_functions)
1353         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1354         Remove "match".
1355
1356 2019-09-10  Tom Tromey  <tromey@adacore.com>
1357
1358         * psymtab.c (map_block): Remove.
1359         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1360         * symtab.c (iterate_over_symbols_terminated): New function.
1361         * symtab.c (iterate_over_symbols_terminated): Declare.
1362
1363 2019-09-10  Tom Tromey  <tromey@adacore.com>
1364
1365         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1366         * language.h (struct language_defn) <la_iterate_over_symbols>:
1367         Return bool.
1368         * symtab.c (iterate_over_symbols): Return bool.
1369         * symtab.h (iterate_over_symbols): Return bool.
1370
1371 2019-09-10  Tom Tromey  <tromey@adacore.com>
1372
1373         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1374         (add_nonlocal_symbols): Update.
1375         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1376         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1377         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1378         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1379         Change type of "callback".  Remove "data".
1380
1381
1382 2019-09-09  Ali Tamur  <tamur@google.com>
1383
1384         * dwarf2read.c (comp_unit_head): Update comment.
1385         (dwarf2_dwo_name): New function declaration.
1386         (dwarf_unit_type_name): New function declaration.
1387         (read_comp_unit_head): Add support for new compilation units,
1388         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1389         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1390         (currently named as "signature") in their header. Also clarify error
1391         messages.
1392         (lookup_dwo_id): New function. Returns the dwo id of the given
1393         compile unit.
1394         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1395         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1396         functions.
1397         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1398         (dwarf2_dwo_name): Get the dwo name if present.
1399         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1400         purposes.
1401
1402 2019-09-09  Tom Tromey  <tom@tromey.com>
1403
1404         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1405
1406 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1407
1408         * python/python.c (do_start_initialization): Make progname_copy static,
1409         to avoid a leak report.
1410
1411 2019-09-08  Tom Tromey  <tom@tromey.com>
1412
1413         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1414
1415 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1416
1417         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1418         Change type to gdb::optional<block_enum>.
1419         (dw2_symtab_iter_init): Change block_index parameter type
1420         to gdb::optional<block_enum>.
1421         (dw2_lookup_symbol): Change block_index parameter
1422         type to block_enum.c
1423         (dw2_debug_names_lookup_symbol): Likewise.
1424         * psymtab.c (psym_lookup_symbol): Likewise.
1425         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1426         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1427         Likewise.
1428
1429 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1430
1431         * defs.h (relocate_gdb_directory): Change int to bool in
1432         signature and rename flag to relocatable.
1433         * main.c (relocate_path): Likewise.
1434         (relocate_gdb_directory): Likewise.
1435
1436 2019-09-06  Alan Modra  <amodra@gmail.com>
1437
1438         * coffread.c (coff_symfile_read): Constify filename variable.
1439         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1440         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1441         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1442         * solib.c (reload_shared_libraries_1): Likewise.
1443         * symfile.c (reread_symbols): Likewise.
1444         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1445         * solib-darwin.c (darwin_bfd_open): Likewise.
1446         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1447
1448 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1449
1450         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1451         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1452
1453 2019-09-03  Tom Tromey  <tromey@adacore.com>
1454
1455         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1456         types.
1457         (has_negatives): Unbias a range type bound.
1458         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1459         * gdbtypes.c (operator==): Handle new field.
1460         (create_range_type): Add "bias" parameter.
1461         (create_static_range_type, resolve_dynamic_range): Update.
1462         * gdbtypes.h (struct range_bounds) <bias>: New member.
1463         (create_range_type): Add bias parameter.
1464         * printcmd.c (print_scalar_formatted): Unbias range types.
1465         * value.c (unpack_long): Unbias range types.
1466         (pack_long): Bias range types.
1467
1468 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1469
1470         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1471         probe arguments.
1472
1473 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1474
1475         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1476         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1477         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1478         (compile_probe_arg): Likewise.
1479         * probe.h (get_argument_count): Likewise.
1480         * solib-svr4.c (solib_event_probe_action): Likewise.
1481         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1482
1483 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1484
1485         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1486         code to here...
1487         (svr4_create_solib_event_breakpoints): ...from here.
1488
1489 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1490
1491         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1492         suffix from warning message.
1493
1494 2019-08-30  Tom Tromey  <tom@tromey.com>
1495
1496         * tui/tui-winsource.h (struct tui_source_window_base)
1497         <refresh_all>: Don't declare.
1498         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1499         Remove.
1500         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1501         tui_show_locator_content.
1502         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1503         declare.
1504         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1505         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1506         declare.
1507
1508 2019-08-30  Tom Tromey  <tom@tromey.com>
1509
1510         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1511
1512 2019-08-30  Tom Tromey  <tom@tromey.com>
1513
1514         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1515         Remove unnecessary forward declarations.
1516
1517 2019-08-30  Tom Tromey  <tom@tromey.com>
1518
1519         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1520         rerender.
1521         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1522         tui_show_locator_content.
1523
1524 2019-08-30  Tom Tromey  <tom@tromey.com>
1525
1526         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1527         (tui_locator_window::rerender): Rewrite using body of previous
1528         tui_show_locator_content.
1529
1530 2019-08-30  Tom Tromey  <tom@tromey.com>
1531
1532         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1533         set_locator_fullname>: New methods.
1534         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1535         Rename from tui_set_locator_fullname.
1536         (tui_locator_window::set_locator_info): Rename from
1537         tui_set_locator_info.  Return bool.
1538         (tui_update_locator_fullname, tui_show_frame_info): Update.
1539
1540 2019-08-30  Tom Tromey  <tom@tromey.com>
1541
1542         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1543
1544 2019-08-30  Tom Tromey  <tom@tromey.com>
1545
1546         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1547         call touchwin.
1548
1549 2019-08-30  Tom Tromey  <tom@tromey.com>
1550
1551         * tui/tui-wingeneral.c (box_win): Assume win_info and
1552         win_info->handle cannot be NULL.
1553
1554 2019-08-30  Tom Tromey  <tom@tromey.com>
1555
1556         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1557         refresh_window>: Declare.
1558         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1559         resize.
1560         (tui_data_item_window::rerender): Rename from
1561         tui_display_register.
1562         (tui_data_item_window::refresh_window): New method.
1563         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1564         no-op.
1565
1566 2019-08-30  Tom Tromey  <tom@tromey.com>
1567
1568         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1569         regs_column_count, current_group>: Move later.  Now private.
1570         <get_current_group>: New method.
1571         * tui/tui-regs.c (tui_reg_command): Update.
1572         * tui/tui-layout.c (tui_set_layout): Update.
1573
1574 2019-08-30  Tom Tromey  <tom@tromey.com>
1575
1576         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1577         (tui_data_window::rerender): Don't call
1578         check_and_display_highlight_if_needed.
1579         (tui_data_window::refresh_all): Remove call to
1580         erase_data_content.
1581
1582 2019-08-30  Tom Tromey  <tom@tromey.com>
1583
1584         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1585         (tui_data_window::display_registers_from)
1586         (tui_data_window::display_reg_element_at_line)
1587         (tui_data_window::display_registers_from_line): Remove checks of
1588         "empty".
1589
1590 2019-08-30  Tom Tromey  <tom@tromey.com>
1591
1592         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1593         Don't declare.
1594         * tui/tui-regs.c (tui_data_window::show_registers): Call
1595         rerender.
1596         (tui_data_window::rerender): Rename from display_all_data.
1597         (tui_data_window::rerender): Remove old implementation.
1598
1599 2019-08-30  Tom Tromey  <tom@tromey.com>
1600
1601         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1602         text.
1603         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1604
1605 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1606             Sergio Durigan Junior  <sergiodj@redhat.com>
1607
1608         PR win32/24284
1609         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1610
1611 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1612
1613         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1614         when searching for types.
1615
1616 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1617
1618         * f-lang.c (f_language_defn): Use f_print_typedef.
1619         * f-lang.h (f_print_typedef): Declare.
1620         * f-typeprint.c (f_print_typedef): Define.
1621
1622 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1623
1624         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1625
1626 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1627
1628         * cli/cli-utils.c (info_print_options_defs): Delete.
1629         (make_info_print_options_def_group): Delete.
1630         (extract_info_print_options): Delete.
1631         (info_print_command_completer): Delete.
1632         (info_print_args_help): Add extra parameter, and optionally
1633         include text about -n flag.
1634         * cli/cli-utils.h (struct info_print_options): Delete.
1635         (extract_info_print_options): Delete declaration.
1636         (info_print_command_completer): Delete declaration.
1637         (info_print_args_help): Add extra parameter, extend header
1638         comment.
1639         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1640         search_symbols.
1641         * stack.c (struct info_print_options): New type.
1642         (info_print_options_defs): New file scoped variable.
1643         (make_info_print_options_def_group): New static function.
1644         (info_print_command_completer): New static function.
1645         (info_locals_command): Update to use new local functions.
1646         (info_args_command): Likewise.
1647         (_initialize_stack): Add extra parameter to calls to
1648         info_print_args_help.
1649         * symtab.c (search_symbols): Add extra parameter, use this to
1650         possibly excluse non-debug symbols.
1651         (symtab_symbol_info): Add extra parameter, which is passed on to
1652         search_symbols.
1653         (struct info_print_options): New type.
1654         (info_print_options_defs): New file scoped variable.
1655         (make_info_print_options_def_group): New static function.
1656         (info_print_command_completer): New static function.
1657         (info_variables_command): Update to use local functions, and pass
1658         extra parameter through to symtab_symbol_info.
1659         (info_functions_command): Likewise.
1660         (info_types_command): Pass additional argument through to
1661         symtab_symbol_info.
1662         (rbreak_command): Pass extra argument to search_symbols.
1663         (_initialize_symtab): Add extra arguments for calls to
1664         info_print_args_help, and update help text for 'info variables',
1665         'whereis', and 'info functions' commands.
1666         * symtab.h (search_symbols): Add extra argument to declaration.
1667         * NEWS: Mention new flags.
1668
1669 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1670
1671         * symtab.c (lookup_static_symbol): Call the new function (and move
1672         it down to be next to lookup_global_symbol).
1673         (struct global_sym_lookup_data): Add block_enum member and rename to...
1674         (struct global_or_static_sym_lookup_data): ...this.
1675         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1676         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1677         (lookup_symbol_global_or_static_iterator_cb): ...this.
1678         (lookup_global_or_static_symbol): New function.
1679         (lookup_global_symbol): Call new function.
1680
1681 2019-08-26  Tom de Vries  <tdevries@suse.de>
1682
1683         PR c++/24852
1684         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1685         when pc_probe.prob == NULL.
1686
1687 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1688
1689         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1690         variable symbol_linkage to symbol_linkage_.
1691
1692 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1693
1694         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1695         represent whether the symbol is static, dynamic, or we don't
1696         know.
1697
1698 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1699
1700         * gdb/rx-tdep.c (rx_register_names): New.
1701         (rx_register_name): Delete.
1702         (rx_psw_type): Delete.
1703         (rx_fpsw_type): Delete.
1704         (rx_register_type): Delete.
1705         (rx_gdbarch_init): Convert target-descriptions.
1706         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1707         * gdb/features/Makefile: Add rx.xml.
1708         * gdb/features/rx.xml: New.
1709         * gdb/features/rx.c: Generated.
1710         * gdb/NEWS: Mention target description support.
1711
1712 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1713
1714         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1715         *slot_ptr.
1716
1717 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1718
1719         * configure.ac: Don't check for 'dlfcn.h' (moved to
1720         gdbsupport/common.m4).
1721         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1722         'gdbsupport/'.
1723         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1724         * compile/compile-c-support.c: Include
1725         'gdbsupport/gdb-dlfcn.h'.
1726         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1727         * gdb-dlfcn.c: Move to...
1728         * gdbsupport/gdb-dlfcn.c: ... here.
1729         * gdb-dlfcn.h: Move to...
1730         * gdbsupport/gdb-dlfcn.h: ... here.
1731
1732 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1733
1734         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1735         the offset field signed.
1736
1737 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1738
1739         * python/lib/gdb/__init__.py (_execute_file): New function.
1740         * python/python.c (python_run_simple_file): Call gdb._execute_file
1741         on Windows.
1742
1743 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1744
1745         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1746         all uses as this was never set to anything but a zero value.
1747
1748 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1749
1750         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1751
1752 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1753
1754         * tui/tui-data.h (tui_gen_win_info): Add an =default
1755         move constructor, required by some GCC versions.
1756
1757 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1758
1759         * go32-nat.c (go32_sysinfo): Add hygon_p.
1760
1761 2019-08-20  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1764         line_from_reg_element_no, first_reg_element_no_inline,
1765         display_all_data, delete_data_content_windows,
1766         erase_data_content>: Now private.
1767
1768 2019-08-20  Tom Tromey  <tom@tromey.com>
1769
1770         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1771         (tui_unhighlight_win, tui_highlight_win)
1772         (tui_win_info::make_window): Update.
1773         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1774
1775 2019-08-20  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1778         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1779         (MAX_PID_WIDTH): Move to tui-stack.c.
1780         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1781         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1782         (MAX_PID_WIDTH): Move from tui-data.h.
1783
1784 2019-08-20  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1787         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1788         (box_win): Update.
1789         (tui_gen_win_info::make_window): Rename from tui_make_window.
1790         (tui_win_info::make_window): New method.
1791         (tui_gen_win_info::make_visible): Update.
1792         * tui/tui-source.c (tui_source_window::set_contents): Update.
1793         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1794         (tui_data_window::display_registers_from): Update.
1795         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1796         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1797         Declare.
1798         <can_box>: Remove.
1799         <title>: Remove.
1800         (struct tui_win_info) <make_window>: Declare.
1801         <can_box>: Now virtual.
1802         <title>: New member.
1803         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1804         * tui/tui-command.c (tui_cmd_window::resize): Update.
1805
1806 2019-08-20  Tom Tromey  <tom@tromey.com>
1807
1808         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1809         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1810         (tui_data_window::check_register_values): Update.
1811
1812 2019-08-20  Tom Tromey  <tom@tromey.com>
1813
1814         * tui/tui-regs.h (struct tui_data_window): Use
1815         DISABLE_COPY_AND_ASSIGN.
1816         <regs_content>: Change type, removing unique_ptr.
1817         <tui_data_window>: Add move constructor.
1818         * tui/tui-regs.c (tui_data_window::show_registers)
1819         (tui_data_window::show_register_group)
1820         (tui_data_window::display_registers_from)
1821         (tui_data_window::display_registers_from)
1822         (tui_data_window::first_data_item_displayed)
1823         (tui_data_window::delete_data_content_windows)
1824         (tui_data_window::rerender, tui_data_window::refresh_window)
1825         (tui_data_window::check_register_values): Update.
1826
1827 2019-08-20  Tom Tromey  <tom@tromey.com>
1828
1829         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1830         show_register_group>: Declare.
1831         (tui_show_register_group): Don't declare.
1832         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1833         tui_show_registers.
1834         (tui_data_window::show_register_group): Rename from
1835         tui_show_register_group.
1836         (tui_data_window::check_register_values, tui_reg_command):
1837         Update.
1838         * tui/tui-layout.c (tui_set_layout): Update.
1839
1840 2019-08-20  Tom Tromey  <tom@tromey.com>
1841
1842         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1843         Declare.
1844         (tui_check_register_values): Don't declare.
1845         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1846         from tui_check_register_values.
1847         * tui/tui-hooks.c (tui_register_changed): Update.
1848
1849 2019-08-20  Tom Tromey  <tom@tromey.com>
1850
1851         * tui/tui-regs.c (tui_reg_layout): Move later.
1852         (tui_show_registers): Don't enable TUI mode or change layout.
1853
1854 2019-08-20  Tom Tromey  <tom@tromey.com>
1855
1856         * tui/tui-regs.h (struct tui_data_item_window)
1857         <~tui_data_item_window>: Remove.
1858         <content>: Now a unique_xmalloc_ptr.
1859         * tui/tui-regs.c (tui_register_format): Return a
1860         unique_xmalloc_ptr.
1861         (tui_get_register): Update.
1862         (~tui_data_item_window): Remove.
1863         (tui_data_window::display_registers_from, tui_display_register):
1864         Update.
1865         * tui/tui-io.h (tui_expand_tabs): Update.
1866         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1867         Remove "col" parameter.
1868
1869 2019-08-20  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1872         field.
1873         * tui/tui-regs.c (~tui_data_item_window): Update.
1874
1875 2019-08-20  Tom Tromey  <tom@tromey.com>
1876
1877         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1878         earlier.
1879
1880 2019-08-20  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1883
1884 2019-08-20  Tom Tromey  <tom@tromey.com>
1885
1886         * tui/tui-source.h (struct tui_source_window): Update.
1887         * tui/tui-regs.c (tui_show_registers): Update.
1888         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1889         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1890         (NO_REGS_STRING): Remove defines.
1891
1892 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1893
1894         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1895         unnecessary thread walk if remote doesn't support the packet.
1896
1897 2019-08-19  Tom Tromey  <tromey@adacore.com>
1898
1899         * python/py-value.c (value_has_field): Fix indentation.
1900
1901 2019-08-19  Tom Tromey  <tromey@adacore.com>
1902
1903         * printcmd.c (do_one_display, info_display_command): Update.
1904         * block.h (contained_in): Return bool.  Add allow_nested
1905         parameter.
1906         * block.c (contained_in): Return bool.  Add allow_nested
1907         parameter.
1908
1909 2019-08-19  Tom Tromey  <tom@tromey.com>
1910
1911         * configure: Rebuild.
1912         * configure.ac: Disallow the combination of -static-libstdc++ and
1913         source highlight.
1914         * source-cache.c (get_language_name): Handle rust.
1915         (source_cache::get_source_lines): Ignore highlighting exceptions.
1916
1917 2019-08-16  Tom Tromey  <tom@tromey.com>
1918
1919         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1920         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1921         (struct tui_source_window_base) <make_visible, refresh_window,
1922         resize>: Remove methods.
1923         <execution_info>: Remove field.
1924         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1925         (tui_show_source_line, tui_source_window_base)
1926         (~tui_source_window_base): Update.
1927         (tui_source_window_base::resize)
1928         (tui_source_window_base::make_visible)
1929         (tui_source_window_base::refresh_window): Remove.
1930         (tui_source_window_base::update_exec_info): Update.
1931         * tui/tui-source.c (tui_source_window::set_contents): Update.
1932         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1933
1934 2019-08-16  Tom Tromey  <tom@tromey.com>
1935
1936         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1937         deprecated_query_hook.
1938
1939 2019-08-16  Tom Tromey  <tom@tromey.com>
1940
1941         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1942         (tui_update_source_windows_with_line): Update.
1943         * tui/tui-source.h (struct tui_source_window)
1944         <show_symtab_source>: Declare.
1945         (tui_show_symtab_source): Don't declare.
1946         * tui/tui-source.c (tui_show_symtab_source): Rename from
1947         tui_show_symtab_source.
1948
1949 2019-08-16  Tom Tromey  <tom@tromey.com>
1950
1951         * tui/tui-winsource.h (struct tui_source_window_base)
1952         <set_contents>: Declare.
1953         * tui/tui-winsource.c
1954         (tui_source_window_base::update_source_window_as_is): Update.
1955         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1956         Declare.
1957         (tui_set_source_content): Don't declare.
1958         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1959         tui_set_source_content.
1960         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1961         Declare.
1962         (tui_set_disassem_content): Don't declare.
1963         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1964         tui_set_disassem_content.
1965
1966 2019-08-16  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-winsource.h (struct tui_source_window_base)
1969         <update_breakpoint_info>: Declare.
1970         (tui_update_breakpoint_info): Don't declare.
1971         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1972         (tui_update_all_breakpoint_info): Update.
1973         (tui_source_window_base::update_breakpoint_info): Rename from
1974         tui_update_breakpoint_info.
1975         (tui_source_window_base::update_exec_info): Update.
1976
1977 2019-08-16  Tom Tromey  <tom@tromey.com>
1978
1979         * tui/tui-winsource.h (struct tui_source_window_base)
1980         <update_source_window>: Declare.
1981         (tui_update_source_window): Don't declare.
1982         * tui/tui-winsource.c
1983         (tui_source_window_base::update_source_window): Rename from
1984         tui_update_source_window.
1985         (tui_source_window_base::rerender): Update.
1986         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1987         * tui/tui-disasm.c (tui_show_disassem)
1988         (tui_show_disassem_and_update_source)
1989         (tui_disasm_window::maybe_update): Update.
1990
1991 2019-08-16  Tom Tromey  <tom@tromey.com>
1992
1993         * tui/tui-winsource.h (struct tui_source_window_base)
1994         <update_source_window_as_is>: Declare.
1995         (tui_update_source_window_as_is): Don't declare.
1996         * tui/tui-winsource.c (tui_update_source_window): Update
1997         (tui_source_window_base::update_source_window_as_is): Rename from
1998         tui_update_source_window_as_is.
1999         (tui_source_window_base::refill): Update.
2000         * tui/tui-source.c (tui_show_symtab_source): Update.
2001         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2002         Update.
2003
2004 2019-08-16  Tom Tromey  <tom@tromey.com>
2005
2006         * tui/tui-winsource.h (tui_update_source_window)
2007         (tui_update_source_window_as_is): Remove "noerror" parameter.
2008         * tui/tui-winsource.c (tui_update_source_window)
2009         (tui_update_source_window_as_is): Remove "noerror" parameter.
2010         (tui_update_source_windows_with_addr)
2011         (tui_update_source_windows_with_line)
2012         (tui_source_window_base::rerender)
2013         (tui_source_window_base::refill): Update.
2014         * tui/tui-source.h (tui_set_source_content)
2015         (tui_show_symtab_source): Remove "noerror" parameter.
2016         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2017         parameter.
2018         (tui_show_symtab_source): Likewise.
2019         (tui_source_window::maybe_update): Update.
2020         * tui/tui-disasm.c (tui_show_disassem)
2021         (tui_show_disassem_and_update_source)
2022         (tui_disasm_window::do_scroll_vertical)
2023         (tui_disasm_window::maybe_update): Update.
2024
2025 2019-08-16  Tom Tromey  <tom@tromey.com>
2026
2027         * tui/tui.c (tui_is_window_visible): Update.
2028         * tui/tui-wingeneral.c (tui_make_window)
2029         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2030         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2031         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2032         (tui_set_win_height_command, parse_scrolling_args): Update.
2033         * tui/tui-source.c (tui_source_window::style_changed): Update.
2034         * tui/tui-regs.c (tui_show_registers)
2035         (tui_data_window::first_data_item_displayed)
2036         (tui_data_window::delete_data_content_windows)
2037         (tui_check_register_values, tui_reg_command): Update.
2038         * tui/tui-disasm.c (tui_show_disassem): Update.
2039         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2040         method.
2041         <is_visible>: Remove field.
2042         * tui/tui-data.c (tui_next_win, tui_prev_win)
2043         (tui_delete_invisible_windows): Update.
2044
2045 2019-08-16  Tom Tromey  <tom@tromey.com>
2046
2047         * tui/tui-winsource.h (struct tui_source_window_base)
2048         <m_has_locator>: Remove.
2049         * tui/tui-layout.c (show_source_disasm_command, show_data)
2050         (show_source_or_disasm_and_command): Update.
2051
2052 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2053
2054         * NEWS (Other MI changes): New subsection.
2055         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2056         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2057         * arch-utils.c (default_get_pc_address_flags): New function.
2058         * arch-utils.h (default_get_pc_address_flags): New declaration.
2059         * gdbarch.sh: Add get_pc_address_flags.
2060         * gdbarch.c: Regenerate.
2061         * gdbarch.h: Likewise.
2062         * stack.c (print_pc): New function.
2063         (print_frame_info) (print_frame): Call print_pc.
2064
2065 2019-08-16  Tom de Vries  <tdevries@suse.de>
2066
2067         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2068         print_objfile_section_info.
2069
2070 2019-08-15  Tom Tromey  <tom@tromey.com>
2071
2072         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2073         calling update_cmdwin_start_line.
2074         * tui/tui-winsource.h (struct tui_source_window_base)
2075         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2076         <rerender>: Declare.
2077         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2078         Call rerender.
2079         (tui_source_window_base::set_new_height): Remove.
2080         (tui_source_window_base::rerender): Rename from
2081         do_make_visible_with_new_height.
2082         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2083         resize method.
2084         (tui_win_info::make_invisible_and_set_new_height)
2085         (tui_win_info::make_visible_with_new_height): Remove.
2086         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2087         Declare.
2088         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2089         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2090         do_make_visible_with_new_height>: Don't declare.
2091         <rerender>: Declare.
2092         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2093         set_new_height.
2094         (tui_data_window::do_make_visible_with_new_height): Remove.
2095         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2096         call tui_show_locator_content.
2097         (tui_gen_win_info::resize): Call rerender.
2098         (show_source_or_disasm_and_command): Don't call
2099         tui_show_locator_content.
2100         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2101         method.
2102         (struct tui_win_info) <rerender>: Declare.
2103         <set_new_height, make_invisible_and_set_new_height,
2104         make_visible_with_new_height>: Don't declare.
2105         * tui/tui-data.c (tui_win_list::rerender): New method.
2106         * tui/tui-command.h (struct tui_cmd_window)
2107         <do_make_visible_with_new_height>: Don't declare.
2108         * tui/tui-command.c
2109         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2110
2111 2019-08-15  Tom Tromey  <tromey@adacore.com>
2112
2113         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2114         * ada-lang.c (ada_enum_name): Likewise.
2115
2116 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2117
2118         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2119         leading underscore.
2120         (GdbOutputErrorFile): Likewise.
2121         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2122         accordingly.
2123         (execute_unwinders): Rename to have a leading underscore.
2124         (auto_load_packages): Likewise.
2125         (global scope): Adjust call to auto_load_packages accordingly.
2126         (GdbSetPythonDirectory): Likewise.
2127         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2128         instead of execute_unwinders.
2129
2130 2019-08-15  Tom Tromey  <tom@tromey.com>
2131
2132         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2133         (show_data): Don't change window visibility.
2134         (tui_gen_win_info::resize): Remove special case for command
2135         window.  Use wresize, when available.
2136         (show_source_or_disasm_and_command): Don't change window
2137         visibility.
2138         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2139         <make_visible>: New method.
2140         * tui/tui-command.c (tui_cmd_window::resize): New method.
2141
2142 2019-08-15  Tom Tromey  <tom@tromey.com>
2143
2144         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2145         (struct tui_source_windows): New.
2146         * tui/tui-winsource.c (tui_display_main): Update.
2147         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2148         (new_height_ok, parse_scrolling_args): Update.
2149         * tui/tui-layout.c (show_layout, show_data): Update.
2150         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2151         (tui_add_to_source_windows): Don't declare.
2152         * tui/tui-data.c (source_windows, tui_source_windows)
2153         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2154
2155 2019-08-15  Tom Tromey  <tom@tromey.com>
2156
2157         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2158         Rename from reset.
2159         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2160         * tui/tui-layout.c (show_source_disasm_command, show_data):
2161         Update.
2162         (tui_gen_win_info::resize): Rename.
2163         (show_source_or_disasm_and_command): Update.
2164         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2165         reset.
2166
2167 2019-08-15  Tom Tromey  <tom@tromey.com>
2168
2169         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2170         * tui/tui-interp.c (tui_interp::init): Don't call
2171         tui_initialize_static_data.
2172         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2173
2174 2019-08-15  Tom Tromey  <tom@tromey.com>
2175
2176         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2177         examine tui_win_list.
2178
2179 2019-08-15  Tom Tromey  <tom@tromey.com>
2180
2181         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2182         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2183         tui_clear_source_content.
2184         (tui_clear_source_content): Remove.
2185         (tui_source_window_base::do_erase_source_content): Hoist call to
2186         content.clear().
2187         * tui/tui-stack.c (tui_show_frame_info): Don't call
2188         tui_clear_source_content.
2189
2190 2019-08-15  Tom Tromey  <tom@tromey.com>
2191
2192         * tui/tui-winsource.h (struct tui_source_window_base)
2193         <do_erase_source_content>: New method.
2194         <erase_source_content>: New method.
2195         (tui_erase_source_content): Don't declare.
2196         * tui/tui-winsource.c (tui_clear_source_content): Update.
2197         (tui_source_window_base::do_erase_source_content): Rename from
2198         tui_erase_source_content.
2199         (tui_source_window_base::show_source_content): Update.
2200         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2201         * tui/tui-source.h (struct tui_source_window)
2202         <erase_source_content>: New method.
2203         * tui/tui-disasm.h (struct tui_disasm_window)
2204         <erase_source_content>: New method.
2205
2206 2019-08-15  Tom Tromey  <tom@tromey.com>
2207
2208         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2209         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2210         constructor.
2211         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2212         * tui/tui-source.c (tui_set_source_content): Update.
2213         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2214
2215 2019-08-15  Tom Tromey  <tom@tromey.com>
2216
2217         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2218         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2219         tui-source.c.
2220         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2221         Declare.
2222         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2223         method.
2224         (tui_source_window::maybe_update): Update.
2225
2226 2019-08-15  Tom Tromey  <tom@tromey.com>
2227
2228         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2229         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2230         tui-disasm.c.
2231         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2232         Declare.
2233         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2234         method.
2235         (tui_disasm_window::maybe_update): Update.
2236
2237 2019-08-15  Tom Tromey  <tom@tromey.com>
2238
2239         * tui/tui-winsource.h (struct tui_source_window_base)
2240         <maybe_update>: Declare.
2241         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2242         method.
2243         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2244         Declare.
2245         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2246         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2247         Declare.
2248         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2249
2250 2019-08-15  Tom Tromey  <tom@tromey.com>
2251
2252         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2253
2254 2019-08-15  Tom Tromey  <tom@tromey.com>
2255
2256         * tui/tui-wingeneral.c: Include tui-stack.h.
2257         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2258         (struct tui_locator_window): Move from tui-data.h.
2259         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2260         (tui_initialize_static_data): Move from tui-data.c.
2261         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2262         (struct tui_locator_window): Move to tui-stack.c.
2263         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2264         (tui_initialize_static_data): Move to tui-stack.c.
2265
2266 2019-08-15  Tom Tromey  <tom@tromey.com>
2267
2268         * tui/tui-layout.c (show_source_disasm_command)
2269         (show_source_or_disasm_and_command): Use make_visible method, not
2270         tui_make_window.
2271         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2272         Remove.
2273
2274 2019-08-15  Tom Tromey  <tom@tromey.com>
2275
2276         * tui/tui-wingeneral.h (tui_make_window): Update.
2277         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2278         parameter.
2279         (tui_gen_win_info::make_visible): Update.
2280         * tui/tui-regs.c (tui_data_window::display_registers_from):
2281         Update.
2282         * tui/tui-layout.c (show_source_disasm_command)
2283         (show_source_or_disasm_and_command): Update.
2284         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2285         (enum tui_box): Remove.
2286         (struct tui_win_info) <can_box>: New method.
2287         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2288         method.
2289
2290 2019-08-15  Tom de Vries  <tdevries@suse.de>
2291
2292         * linux-nat-trad.c: Include gdbarch.h.
2293
2294 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2295
2296         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2297         register sizes.
2298
2299 2019-08-14  Tom Tromey  <tromey@adacore.com>
2300
2301         * darwin-nat.c: Include gdbarch.h.
2302         * darwin-nat-info.c: Include gdbarch.h.
2303
2304 2019-08-13  Tom Tromey  <tom@tromey.com>
2305
2306         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2307         Remove.
2308         * tui/tui-data.c (tui_initialize_static_data): Update.
2309
2310 2019-08-13  Tom Tromey  <tom@tromey.com>
2311
2312         * tui/tui-winsource.h (struct tui_exec_info_window)
2313         <~tui_exec_info_window, maybe_allocate_content, get_content,
2314         m_content>: Remove.
2315         (struct tui_source_window_base) <set_exec_info_content,
2316         show_exec_info_content>: Don't declare.
2317         * tui/tui-winsource.c
2318         (tui_exec_info_window::maybe_allocate_content): Remove.
2319         (tui_source_window_base::update_exec_info): Rename from
2320         set_exec_info_content.
2321         (tui_source_window_base::show_exec_info_content)
2322         (tui_source_window_base::update_exec_info): Remove.
2323
2324 2019-08-13  Tom Tromey  <tom@tromey.com>
2325
2326         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2327         declare.
2328         * tui/tui-winsource.c (tui_update_source_window_as_is)
2329         (tui_update_source_windows_with_addr, tui_erase_source_content):
2330         Update.
2331         (tui_clear_exec_info_content): Remove.
2332
2333 2019-08-13  Tom Tromey  <tom@tromey.com>
2334
2335         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2336         declare.
2337         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2338         call tui_erase_exec_info_content.
2339         (tui_clear_exec_info_content): Rename from
2340         tui_erase_exec_info_content.
2341         (tui_clear_exec_info_content): Delete.
2342
2343 2019-08-13  Tom Tromey  <tom@tromey.com>
2344
2345         * tui/tui-winsource.h (struct tui_source_window_base)
2346         <show_exec_info_content>: Declare.
2347         (tui_show_exec_info_content): Don't declare.
2348         * tui/tui-winsource.c
2349         (tui_source_window_base::show_exec_info_content): Rename from
2350         tui_show_exec_info_content.
2351         (tui_source_window_base::update_exec_info): Update.
2352
2353 2019-08-13  Tom Tromey  <tom@tromey.com>
2354
2355         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2356         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2357         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2358         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2359         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2360         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2361         ... here.
2362
2363 2019-08-13  Tom Tromey  <tom@tromey.com>
2364
2365         * tui/tui-winsource.h (struct tui_source_window_base)
2366         <update_exec_info>: Declare.
2367         (tui_update_exec_info): Don't declare.
2368         * tui/tui-winsource.c (tui_update_source_window_as_is)
2369         (tui_source_window_base::refresh_all)
2370         (tui_update_all_breakpoint_info): Update.
2371         (tui_source_window_base::update_exec_info): Rename from
2372         tui_update_exec_info.
2373         * tui/tui-stack.c (tui_show_frame_info): Update.
2374
2375 2019-08-13  Tom Tromey  <tom@tromey.com>
2376
2377         * tui/tui-winsource.h (struct tui_source_window_base)
2378         <set_exec_info_content>: Declare.
2379         (tui_set_exec_info_content): Don't declare.
2380         * tui/tui-winsource.c
2381         (tui_source_window_base::set_exec_info_content): Rename from
2382         tui_set_exec_info_content.
2383         (tui_update_exec_info): Update.
2384
2385 2019-08-13  Tom Tromey  <tom@tromey.com>
2386
2387         * tui/tui-winsource.h (struct tui_source_window_base)
2388         <show_source_content>: Declare.
2389         (tui_show_source_content): Don't declare.
2390         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2391         (tui_source_window_base::show_source_content): Rename from
2392         tui_show_source_content.
2393         (tui_source_window_base::refresh_all): Update.
2394         * tui/tui-layout.c (show_source_disasm_command)
2395         (show_source_or_disasm_and_command): Update.
2396
2397 2019-08-13  Tom Tromey  <tom@tromey.com>
2398
2399         * tui/tui-winsource.c (tui_erase_source_content)
2400         (tui_show_source_content, tui_source_window_base::refresh_all):
2401         Update.
2402         * tui/tui-wingeneral.h
2403         (tui_check_and_display_highlight_if_needed): Don't declare.
2404         * tui/tui-wingeneral.c
2405         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2406         check_and_display_highlight_if_needed.
2407         * tui/tui-win.c (tui_rehighlight_all)
2408         (tui_win_info::make_visible_with_new_height): Update.
2409         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2410         (tui_data_window::erase_data_content)
2411         (tui_data_window::display_all_data): Update.
2412         * tui/tui-data.h (struct tui_win_info)
2413         <check_and_display_highlight_if_needed>: Declare.
2414
2415 2019-08-13  Tom Tromey  <tom@tromey.com>
2416
2417         * tui/tui-win.c (tui_resize_all): Call
2418         tui_delete_invisible_windows.
2419         * tui/tui-layout.c (show_layout): Call
2420         tui_delete_invisible_windows.
2421         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2422         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2423
2424 2019-08-13  Tom Tromey  <tom@tromey.com>
2425
2426         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2427         tui_add_win_to_layout.
2428
2429 2019-08-13  Tom Tromey  <tom@tromey.com>
2430
2431         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2432         * tui/tui-layout.c (tui_default_win_height): Now static.
2433
2434 2019-08-13  Tom Tromey  <tom@tromey.com>
2435
2436         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2437         single switch.
2438         (show_source_disasm_command, show_source_or_disasm_and_command):
2439         Don't check current layout.
2440
2441 2019-08-13  Tom Tromey  <tom@tromey.com>
2442
2443         * tui/tui-wingeneral.c (make_all_visible): Remove.
2444         (tui_make_all_invisible): Simplify.
2445         * tui/tui-layout.c (tui_make_all_invisible): Move from
2446         tui-wingeneral.c; simplify.
2447         (show_layout): Hoist call to tui_make_all_invisible.
2448         (show_data): Don't call tui_make_all_invisible.
2449
2450 2019-08-13  Tom Tromey  <tom@tromey.com>
2451
2452         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2453         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2454
2455 2019-08-13  Tom Tromey  <tom@tromey.com>
2456
2457         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2458         tui-data.c.
2459         (show_source_disasm_command, show_data)
2460         (show_source_or_disasm_and_command): Don't use
2461         tui_set_current_layout_to.
2462         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2463         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2464         tui-layout.c.
2465         (tui_set_current_layout_to): Remove.
2466
2467 2019-08-13  Tom Tromey  <tom@tromey.com>
2468
2469         * tui/tui-layout.c (tui_set_layout): Update.
2470         * tui/tui-data.h (struct tui_layout_def): Remove.
2471         (tui_layout_def): Don't declare.
2472         * tui/tui-data.c (layout_def): Remove.
2473         (tui_layout_def): Remove.
2474
2475 2019-08-13  Tom Tromey  <tom@tromey.com>
2476
2477         * tui/tui-winsource.h (struct tui_source_window_base)
2478         <clear_detail>: No longer "override".
2479         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2480         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2481         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2482         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2483         Remove.
2484         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2485
2486 2019-08-13  Tom Tromey  <tromey@adacore.com>
2487
2488         * tracepoint.c: Don't include readline.h or history.h.
2489
2490 2019-08-12  Tom Tromey  <tom@tromey.com>
2491
2492         * configure: Rebuild.
2493         * configure.ac: Check for readline 7.
2494         * NEWS: Mention readline 7 requirement.
2495         * README: Update.
2496
2497 2019-08-12  Tom Tromey  <tom@tromey.com>
2498
2499         * mingw-hdep.c (gdb_select): Remove readline hack.
2500
2501 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2502
2503         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2504         when the function fails.
2505
2506 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2507
2508         * s390-tdep.c (s390_type_align): New function.
2509         (s390_gdbarch_init): Set it as type_align gdbarch method.
2510
2511 2019-08-09  Tom de Vries  <tdevries@suse.de>
2512
2513         PR gdb/24591
2514         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2515         pc_low with relocation offset.
2516
2517 2019-08-07  Tom Tromey  <tromey@adacore.com>
2518
2519         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2520         (print_frame_args): Update.
2521         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2522         Update.
2523         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2524         * frame.h (struct frame_arg): Add initializers.
2525         <error>: Now a unique_xmalloc_ptr.
2526
2527 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2528
2529         * NEWS: Expand the Pointer Authentication entry.
2530         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2531         (aarch64_frame_unmask_lr): ... to this.
2532         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2533         Call aarch64_frame_unmask_lr.
2534         * frame.c (struct frame_info): Add "masked" variable.
2535         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2536         (fprint_frame): Check for masked pc.
2537         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2538         declarations.
2539         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2540         * stack.c (print_frame): Check for masked pc.
2541
2542 2019-08-06  Tom Tromey  <tom@tromey.com>
2543
2544         * stabsread.c (patch_block_stabs, read_one_struct_field)
2545         (read_enum_type): Use obstack_strndup.
2546         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2547         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2548         * dwarf2read.c (guess_full_die_structure_name)
2549         (anonymous_struct_prefix): Use obstack_strndup.
2550         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2551         * c-exp.y (yylex): Use obstack_strndup.
2552         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2553         (write_var_or_type): Use obstack_strndup.
2554
2555 2019-08-06  Tom Tromey  <tom@tromey.com>
2556
2557         * symfile.c (reread_symbols): Use obstack_strdup.
2558         * stabsread.c (read_type): Use obstack_strdup.
2559         * gdb_obstack.h (obstack_strdup): New overload.
2560         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2561         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2562         (dwarf2_canonicalize_name): Use obstack_strdup.
2563         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2564         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2565         Use obstack_strdup.
2566
2567 2019-08-06  Tom Tromey  <tom@tromey.com>
2568
2569         * gdb_obstack.h (obstack_strdup): Define.
2570         * gdb_obstack.c (obstack_strdup): Don't define.
2571
2572 2019-08-06  Tom Tromey  <tom@tromey.com>
2573
2574         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2575         obstack_strdup.
2576         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2577         obstack_strdup.
2578         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2579         * stabsread.c (common_block_start): Use obstack_strdup.
2580         * objfiles.c (set_objfile_main_name, objfile): Use
2581         obstack_strdup.
2582         * namespace.c (add_using_directive): Use obstack_strdup.
2583         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2584         * jit.c (finalize_symtab): Use obstack_strdup.
2585         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2586         (guess_partial_die_structure_name, partial_die_info::fixup)
2587         (dwarf2_name): Use obstack_strdup.
2588         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2589         obstack_strdup.
2590         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2591         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2592         obstack_strdup.
2593         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2594
2595 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2596
2597         * unittests/help-doc-selftests.c: New file.
2598         * Makefile.in: Add the new file.
2599
2600 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2601
2602         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2603         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2604         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2605         the trailing '.' is not output, and the first character is uppercased.
2606         (print_help_for_command): Update call to print_doc_line.
2607         (print_doc_of_command): Likewise.
2608         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2609         * cli/cli-option.c (append_indented_doc): Do not append newline.
2610         (build_help_option): Append newline after first appended_indented_doc
2611         only if a second call is done.
2612         (build_help): Append 2 new lines before each option, except the first
2613         one.
2614         * compile/compile.c (_initialize_compile): Add new lines after
2615         %OPTIONS%, when not at the end of the help.
2616         Change help doc or code
2617         producing the help doc to respect the invariants.
2618         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2619         Also removed the new line after 'Options:', as all other commands
2620         do not put an empty line between 'Options:' and the first option.
2621         * printcmd.c (_initialize_printcmd): Likewise.
2622         * stack.c (_initialize_stack): Likewise.
2623         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2624         incorrectly telling COMMAND is optional.
2625         * ada-lang.c (_initialize_ada_language): Change help doc or code
2626         producing the help doc to respect the invariants.
2627         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2628         * breakpoint.c (_initialize_breakpoint): Likewise.
2629         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2630         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2631         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2632         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2633         _initialize_cli_style): Likewise.
2634         * corelow.c (core_target_info): Likewise.
2635         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2636         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2637         * filesystem.c (_initialize_filesystem): Likewise.
2638         * frame.c (_initialize_frame): Likewise.
2639         * gnu-nat.c (add_task_commands): Likewise.
2640         * infcall.c (_initialize_infcall): Likewise.
2641         * infcmd.c (_initialize_infcmd): Likewise.
2642         * interps.c (_initialize_interpreter): Likewise.
2643         * language.c (_initialize_language): Likewise.
2644         * linux-fork.c (_initialize_linux_fork): Likewise.
2645         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2646         * maint.c (_initialize_maint_cmds): Likewise.
2647         * memattr.c (_initialize_mem): Likewise.
2648         * printcmd.c (_initialize_printcmd): Likewise.
2649         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2650         _RegEx): Likewise.
2651         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2652         * record-btrace.c (_initialize_record_btrace): Likewise.
2653         * record-full.c (_initialize_record_full): Likewise.
2654         * record.c (_initialize_record): Likewise.
2655         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2656         * regcache.c (_initialize_regcache): Likewise.
2657         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2658         _initialize_remote): Likewise.
2659         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2660         * serial.c (_initialize_serial): Likewise.
2661         * skip.c (_initialize_step_skip): Likewise.
2662         * source.c (_initialize_source): Likewise.
2663         * stack.c (_initialize_stack): Likewise.
2664         * symfile.c (_initialize_symfile): Likewise.
2665         * symtab.c (_initialize_symtab): Likewise.
2666         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2667         * top.c (init_main): Likewise.
2668         * tracefile-tfile.c (tfile_target_info): Likewise.
2669         * tracepoint.c (_initialize_tracepoint): Likewise.
2670         * tui/tui-win.c (_initialize_tui_win): Likewise.
2671         * utils.c (add_internal_problem_command): Likewise.
2672         * valprint.c (value_print_option_defs): Likewise.
2673
2674 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2675
2676         PR build/24886
2677         * configure.ac: Drop enable-libmcheck support.
2678         * configure, config.in: Rebuild.
2679         * libmcheck.m4: Remove.
2680         * acinclude.m4: Don't include it.
2681         * Makefile.in: Don't distribute it.
2682         * top.c (print_gdb_configuration): Don't mention it.
2683
2684 2019-08-06  Tom Tromey  <tom@tromey.com>
2685
2686         * utils.c (set_output_style): Sometimes pass stream to
2687         emit_style_escape.
2688         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2689         * record-btrace.c (btrace_insn_history): Update.
2690         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2691         method.
2692         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2693         Update initializers.
2694         <m_uiout>: New field.
2695         <m_di>: Move lower.
2696         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2697         Remove "uiout" parameter.
2698         (dump_insns): Update.
2699         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2700         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2701
2702 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2703
2704         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2705         (error_in_psymtab_expansion): Likewise.
2706         (lookup_symbol_via_quick_fns): Likewise.
2707         (basic_lookup_transparent_type_quick): Likewise.
2708         (basic_lookup_transparent_type_1): Likewise.
2709
2710 2019-08-06  Tom Tromey  <tromey@adacore.com>
2711
2712         * source.c (last_source_error): Now bool.
2713         (print_source_lines_base): Make "noprint" bool.  Only open
2714         source file when last_source_visited changes.
2715
2716 2019-08-06  Tom Tromey  <tromey@adacore.com>
2717
2718         * annotate.c (annotate_source_line): Use g_source_cache.
2719         * source-cache.c (source_cache::get_plain_source_lines): Change
2720         parameters.  Populate m_offset_cache.
2721         (source_cache::ensure): New method.
2722         (source_cache::get_line_charpos): New method.
2723         (extract_lines): Move lower.  Change parameters.
2724         (source_cache::get_source_lines): Move lower.
2725         * source-cache.h (class source_cache): Update comment.
2726         <get_line_charpos>: New method.
2727         <get_source_lines>: Update comment.
2728         <clear>: Clear m_offset_cache.
2729         <get_plain_source_lines>: Change parameters.
2730         <ensure>: New method
2731         <m_offset_cache>: New member.
2732         * source.c (forget_cached_source_info_for_objfile): Update.
2733         (info_source_command): Use g_source_cache.
2734         (find_source_lines, open_source_file_with_line_charpos): Remove.
2735         (print_source_lines_base, search_command_helper): Use g_source_cache.
2736         * source.h (open_source_file_with_line_charpos): Don't declare.
2737         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2738         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2739         Use g_source_cache.
2740
2741 2019-08-06  Tom Tromey  <tromey@adacore.com>
2742
2743         * source-cache.c (source_cache::get_plain_source_lines):
2744         Remove "first_line" and "last_line" parameters.
2745         (source_cache::get_source_lines): Cache plain text.
2746         * source-cache.h (class source_cache)
2747         <get_plain_source_lines>: Update.
2748
2749 2019-08-06  Tom Tromey  <tromey@adacore.com>
2750
2751         * source-cache.c (extract_lines): No longer a method.
2752         Changed type of parameter.  Include final newline.
2753         (selftests::extract_lines_test): New function.
2754         (_initialize_source_cache): Likewise.
2755         * source-cache.h (class source_cache)
2756         <extract_lines>: Don't declare.
2757
2758 2019-08-06  Tom Tromey  <tromey@adacore.com>
2759
2760         * breakpoint.c (init_breakpoint_sal): Update.
2761         (breakpoint): Update.
2762         * breakpoint.h (struct breakpoint) <filter>: Now a
2763         unique_xmalloc_ptr.
2764
2765 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2766
2767         * NEWS: Mention dictionary access on blocks.
2768         * python/py-block.c (blpy_getitem): New function.
2769         (block_object_as_mapping): New struct.
2770         (block_object_type): Use new struct for tp_as_mapping field.
2771
2772 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2773
2774         * objfiles.h (objfile): Add a comment describing partial symbols.
2775
2776 2019-08-05  Tom Tromey  <tromey@adacore.com>
2777
2778         * compile/compile.c (_initialize_compile): Use _(), not N_().
2779         * thread.c (_initialize_thread): Use _(), not N_().
2780         * stack.c (_initialize_stack): Use _(), not N_().
2781         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2782
2783 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2784
2785         * dwarf2read.c (struct dw2_symtab_iterator):
2786         <want_specific_block>: Remove.
2787         <block_index>: Change type to gdb::optional.
2788         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2789         change type of BLOCK_INDEX parameter to gdb::optional.
2790         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2791         (dw2_lookup_symbol): Don't pass argument for
2792         WANT_SPECIFIC_BLOCK.
2793         (dw2_expand_symtabs_for_function): Don't pass argument for
2794         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2795         (class dw2_debug_names_iterator)
2796         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2797         parameter, change BLOCK_INDEX type to gdb::optional.
2798         <m_want_specific_block>: Remove.
2799         <m_block_index>: Change type to gdb::optional.
2800         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2801         gdb::optional.  Re-write in function of gdb::optional.
2802         (dw2_debug_names_lookup_symbol): Don't pass argument for
2803         WANT_SPECIFIC_BLOCK.
2804         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2805         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2806         BLOCK_INDEX.
2807
2808 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2809
2810         * NEWS: Mention changes to "info sources" command.
2811
2812 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2813
2814         * symtab.c (filename_partial_match_opts): New struct type.
2815         (struct output_source_filename_data): New members
2816         regexp, c_regexp, partial_match.
2817         (output_source_filename): Use new members to decide to print file.
2818         (info_sources_option_defs): New variable.
2819         (make_info_sources_options_def_group, print_info_sources_header,
2820         info_sources_command_completer):
2821         New functions.
2822         (info_sources_command): Read new optional arguments.
2823         (_initialize_symtab): Update info sources help.
2824
2825 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2826
2827         * ada-lang.c (exception_support_info_v0): Renamed from...
2828         (default_exception_support_info): ... this.  Create new
2829         definition for v1.
2830         (ada_has_this_exception_support): Look up catch_handlers_sym.
2831         (ada_exception_support_info_sniffer): Try v0 after default.
2832
2833 2019-08-01  Tom Tromey  <tromey@adacore.com>
2834
2835         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2836         gdbarch.h.
2837
2838 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2839
2840         * s12z-tdep.c: Fix include path for s12z-opc.h.
2841
2842 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2843
2844         * NEWS: Require GNU make 3.82.
2845
2846 2019-07-16  Tom Tromey  <tom@tromey.com>
2847
2848         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2849         declare.
2850
2851 2019-07-30  Tom Tromey  <tromey@adacore.com>
2852
2853         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2854
2855 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2856
2857         * printcmd.c (print_address_symbolic): Print negative offsets.
2858         (build_address_symbolic): Force signed arithmetic when computing
2859         offset.
2860
2861 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2862
2863         PR/24474: Add a function to lookup static variables.
2864         * NEWS: Mention this new function.
2865         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2866         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2867         * python/python.c (python_GdbMethods): Add new function.
2868
2869 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2870
2871         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2872         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2873         (objfpy_lookup_static_symbol): New function.
2874         (objfile_object_methods): Add new functions.
2875
2876 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2877
2878         * NEWS: Mention 'set|show print frame-info'.  Mention new
2879         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2880         backtrace argument.  Mention that python frame filtering code
2881         is now consistent with what 'backtrace' command prints.
2882
2883 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2884
2885         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2886         comments.
2887         (print_frame_info_auto, print_frame_info_source_line,
2888         print_frame_info_location, print_frame_info_source_and_location,
2889         print_frame_info_location_and_address, print_frame_info_short_location):
2890         New declarations.
2891         (struct frame_print_options): New member print_frame_info.
2892         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2893         * stack.h (get_user_print_what_frame_info): New declaration.
2894         (frame_show_address): New declaration.
2895         * stack.c (print_frame_arguments_choices): New value 'presence'.
2896         (print_frame_info_auto, print_frame_info_source_line,
2897         print_frame_info_location, print_frame_info_source_and_location,
2898         print_frame_info_location_and_address, print_frame_info_short_location,
2899         print_frame_info_choices, print_frame_info_print_what): New definitions.
2900         (print_frame_args): Only print dots for args if print frame-arguments
2901         is 'presence'.
2902         (frame_print_option_defs): New element for "frame-info".
2903         (get_user_print_what_frame_info): New function.
2904         (frame_show_address): Make non static.  Move comment to stack.h.
2905         (print_frame_info_to_print_what): New function.
2906         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2907         to decide what to print.
2908         (backtrace_command_1): Handle the new print_frame_arguments_presence
2909         value.
2910         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2911         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2912         (py_print_frame): In non-mi mode, use LOCATION as default for
2913         print_what, similarly to frame information printed directly by
2914         backtrace command. Handle frame-info user option in non MI mode.
2915
2916 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2917
2918         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2919         Add case for debugging 32-bit target on 64-bit host.  Revise
2920         comment.
2921
2922 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2923
2924         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2925         instead of find_function_entry_range_from_pc.
2926
2927 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2928
2929         * stack.c (find_frame_funname): Remove code which preferred
2930         minsym over symtab sym in "certain pathological cases".
2931
2932         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2933         parameter.  Change type of "do_demangle" to bool.
2934         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2935         Pass suitable "prefer_sym_over_minsym" flag to
2936         build_address_symbolic().  Don't output "+" for negative offsets.
2937         * printcmd.c (print_address_symbolic): Update invocation of
2938         build_address_symbolic to include a "prefer_sym_over_minsym"
2939         flag.
2940         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2941         Restrict cases in which use of minimal symbol is preferred to that
2942         of a found symbol.  Update comments.
2943
2944         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2945         for entry pc when entry pc is out of range for that FDE.
2946
2947 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2948
2949         PR gdb/24839:
2950         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2951         type.
2952
2953 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2954
2955         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2956         this function's Python signature.
2957
2958
2959 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2960
2961         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2962         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2963         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2964         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2965         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2966
2967
2968 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2969
2970         * h8300-tdep.c (h8300_register_name_common): New.
2971         h8300_register_name): Use h8300_register_name_common.
2972         (h8300s_register_name): Likewise.
2973         (h8300sx_register_name): Likewise.
2974         (h8300h_register_nam): New.
2975         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2976
2977
2978 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2979
2980         * arm-tdep.c (arm_skip_cmse_entry): New function.
2981         (arm_is_sgstubs_section): New function.
2982         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2983
2984 2019-07-22  Tom Tromey  <tom@tromey.com>
2985
2986         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2987         Don't self-assign.
2988
2989 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2990
2991         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2992         type_print.
2993
2994 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2995
2996         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2997         so that GDB doesn't match any msymbols when searching in the
2998         TYPES_DOMAIN.
2999         (print_symbol_info): Print using typedef_print or type_print based
3000         on the type of the symbol.  Add updated FIXME comment moved from...
3001         (_initialize_symtab): ... move and update FIXME comment to above.
3002
3003 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3004
3005         * NEWS: Mention adding -q option to "info types".
3006         * symtab.c (struct info_types_options): New struct.
3007         (info_types_options_defs): New variable.
3008         (make_info_types_options_def_group): New function.
3009         (info_types_command): Use gdb::option framework to parse options.
3010         (info_types_command_completer): New function.
3011         (_initialize_symtab): Extend the help text on "info types" and
3012         register command completer.
3013
3014 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3015
3016         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3017         (lookup_symbol_in_objfile): Change int to block_enum and add a
3018         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3019
3020 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3021
3022         * MAINTAINERS (Write After Approval): Add self.
3023
3024 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3025
3026         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3027         instruction to the dummy code region.
3028
3029 2019-07-19  Tom Tromey  <tromey@adacore.com>
3030
3031         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3032         (ARGSUSED, PARAMS, __func__): Remove rules.
3033
3034 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3035
3036         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3037         * features/arm/arm-with-iwmmxt.c: Remove.
3038         * features/arm/arm-with-iwmmxt.xml: Remove.
3039         * features/arm/arm-with-m-fpa-layout.c: Remove.
3040         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3041         * features/arm/arm-with-m-vfp-d16.c: Remove.
3042         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3043         * features/arm/arm-with-m.c: Remove.
3044         * features/arm/arm-with-m.xml: Remove.
3045         * features/arm/arm-with-neon.c: Remove.
3046         * features/arm/arm-with-neon.xml: Remove.
3047         * features/arm/arm-with-vfpv2.c: Remove.
3048         * features/arm/arm-with-vfpv2.xml: Remove.
3049         * features/arm/arm-with-vfpv3.c: Remove.
3050         * features/arm/arm-with-vfpv3.xml: Remove.
3051
3052 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3053
3054         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3055
3056 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3057
3058         * arch/aarch32.c (aarch32_create_target_description): Create
3059         target descriptions using features.
3060         * arch/arm.c (arm_create_target_description)
3061         (arm_create_mprofile_target_description): Likewise.
3062         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3063
3064 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3065
3066         * Makefile.in: Add new files.
3067         * aarch32-tdep.c: New file.
3068         * aarch32-tdep.h: New file.
3069         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3070         Call aarch32_read_description.
3071         * arch/aarch32.c: New file.
3072         * arch/aarch32.h: New file.
3073         * arch/arm.c (arm_create_target_description)
3074         (arm_create_mprofile_target_description): New function.
3075         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3076         (arm_create_target_description)
3077         (arm_create_mprofile_target_description): New declaration.
3078         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3079         read_description functions.
3080         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3081         Likewise.
3082         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3083         * arm-tdep.c (tdesc_arm_list): New variable.
3084         (arm_register_g_packet_guesses): Call create description functions.
3085         (arm_read_description) (arm_read_mprofile_description): New
3086         function.
3087         * arm-tdep.h (arm_read_description)
3088         (arm_read_mprofile_description): Add declaration.
3089         * configure.tgt: Add new files.
3090
3091 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3092
3093         * top.c (new_ui_command): Open specified terminal just once.
3094
3095 2019-07-18  Tom Tromey  <tromey@adacore.com>
3096
3097         * symtab.c (main_name): Constify return type.
3098         * symfile.c (set_initial_language): Update.
3099         * symtab.h (main_name): Constify return type.
3100
3101 2019-07-17  Tom Tromey  <tom@tromey.com>
3102
3103         * tui/tui-winsource.c (tui_update_source_window)
3104         (tui_update_source_window_as_is)
3105         (tui_update_source_windows_with_line): Remove return.
3106         * tui/tui-disasm.c (tui_show_disassem)
3107         (tui_show_disassem_and_update_source): Remove return.
3108         * tui/tui.c (tui_reset): Remove return.
3109         * tui/tui-wingeneral.c
3110         (tui_check_and_display_highlight_if_needed): Remove return.
3111
3112 2019-07-17  Tom Tromey  <tom@tromey.com>
3113
3114         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3115
3116 2019-07-17  Tom Tromey  <tom@tromey.com>
3117
3118         * tui/tui-winsource.h (struct tui_exec_info_window)
3119         (struct tui_source_window_base): Move from tui-data.h.
3120         * tui/tui-winsource.c: Move many method definitions from
3121         elsewhere.  Remove "structuring" comments.
3122         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3123         (tui_source_window_base::refresh_window): Move to
3124         tui-winsource.c.
3125         * tui/tui-win.c (tui_source_window_base::refresh_all)
3126         (tui_source_window_base::update_tab_width)
3127         (tui_source_window_base::set_new_height)
3128         (tui_source_window_base::do_make_visible_with_new_height): Move to
3129         tui-winsource.c.
3130         * tui/tui-source.h: Update.
3131         * tui/tui-source.c (tui_source_window_base::reset): Move to
3132         tui-winsource.c.
3133         * tui/tui-disasm.h: Update.
3134         * tui/tui-data.h (struct tui_exec_info_window): Move to
3135         tui-winsource.h.
3136         (struct tui_source_window_base): Likewise.
3137         * tui/tui-data.c (tui_source_window_base::clear_detail)
3138         (tui_source_window_base, ~tui_source_window_base): Move to
3139         tui-winsource.c.
3140
3141 2019-07-17  Tom Tromey  <tom@tromey.com>
3142
3143         * tui/tui-win.c (tui_resize_all)
3144         (tui_source_window_base::update_tab_width)
3145         (tui_adjust_win_heights): Update.
3146         (tui_win_info::make_invisible_and_set_new_height): Rename from
3147         make_invisible_and_set_new_height.
3148         * tui/tui-data.h (struct tui_win_info)
3149         <make_invisible_and_set_new_height>: New method.
3150
3151 2019-07-17  Tom Tromey  <tom@tromey.com>
3152
3153         * tui/tui.c: Update.
3154         * tui/tui-source.h (struct tui_source_window): Move from
3155         tui-data.h.
3156         * tui/tui-layout.c: Update.
3157         * tui/tui-disasm.c: Update.
3158         * tui/tui-data.h (struct tui_source_window): Move to
3159         tui-source.h.
3160
3161 2019-07-17  Tom Tromey  <tom@tromey.com>
3162
3163         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3164         tui-data.h.
3165         * tui/tui-data.h (struct tui_disasm_window): Move to
3166         tui-disasm.h.
3167
3168 2019-07-17  Tom Tromey  <tom@tromey.com>
3169
3170         * tui/tui-regs.h (struct tui_data_item_window): Move from
3171         tui-data.h.
3172         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3173         * tui/tui-data.h (struct tui_data_item_window): Move to
3174         tui-regs.h.
3175         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3176
3177 2019-07-17  Tom Tromey  <tom@tromey.com>
3178
3179         * tui/tui.c: Update.
3180         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3181         (tui_cmd_window::max_height): Move to tui-command.c.
3182         * tui/tui-layout.c: Update.
3183         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3184         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3185         tui-command.c.
3186         * tui/tui-command.h (struct tui_cmd_window): Move from
3187         tui-data.h.
3188         * tui/tui-command.c: Remove "structuring" comments.
3189         (tui_cmd_window::clear_detail)
3190         (tui_cmd_window::do_make_visible_with_new_height)
3191         (tui_cmd_window::max_height): Move from elsewhere.
3192
3193 2019-07-17  Tom Tromey  <tom@tromey.com>
3194
3195         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3196         Now static.
3197         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3198         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3199
3200 2019-07-17  Tom Tromey  <tom@tromey.com>
3201
3202         * tui/tui.c: Update.
3203         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3204         tui-regs.c.
3205         * tui/tui-windata.h: Remove file.
3206         * tui/tui-windata.c: Remove file.
3207         * tui/tui-win.c (tui_data_window::set_new_height)
3208         (tui_data_window::do_make_visible_with_new_height): Move to
3209         tui-regs.c.
3210         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3211         * tui/tui-regs.c: Remove "structuring" comments.
3212         (tui_data_window::first_data_item_displayed)
3213         (tui_data_window::delete_data_content_windows)
3214         (tui_data_window::erase_data_content)
3215         (tui_data_window::display_all_data)
3216         (tui_data_window::refresh_all)
3217         (tui_data_window::do_scroll_vertical)
3218         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3219         (tui_data_window::do_make_visible_with_new_height)
3220         (tui_data_window::refresh_window): Move from elsewhere.
3221         (_initialize_tui_regs): Move to end of file.
3222         * tui/tui-layout.c: Update.
3223         * tui/tui-hooks.c: Update.
3224         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3225         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3226         tui-regs.c.
3227         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3228
3229 2019-07-17  Tom Tromey  <tom@tromey.com>
3230
3231         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3232         seen.
3233
3234 2019-07-17  Tom Tromey  <tom@tromey.com>
3235
3236         * tui/tui-win.c (tui_source_window_base::set_new_height)
3237         (tui_source_window_base::do_make_visible_with_new_height): Use
3238         m_has_locator field directly.
3239         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3240         method.
3241         (struct tui_source_window_base) <has_locator>: Likewise.
3242
3243 2019-07-17  Tom Tromey  <tom@tromey.com>
3244
3245         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3246         Don't declare.
3247         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3248         Remove.
3249         * tui/tui-win.c (tui_source_window_base::set_new_height)
3250         (tui_source_window_base::set_new_height)
3251         (make_invisible_and_set_new_height)
3252         (tui_source_window_base::do_make_visible_with_new_height)
3253         (tui_source_window_base::do_make_visible_with_new_height):
3254         Update.
3255         * tui/tui-layout.c (show_source_disasm_command, show_data)
3256         (show_source_or_disasm_and_command): Update.
3257         * tui/tui-layout.c (show_layout): Update.
3258
3259 2019-07-17  Tom Tromey  <tom@tromey.com>
3260
3261         * tui/tui-layout.c (make_data_window): Remove.
3262         (show_data): Unify creation and re-initialization cases.
3263
3264 2019-07-17  Tom Tromey  <tom@tromey.com>
3265
3266         * tui/tui-layout.c (make_source_window, make_disasm_window):
3267         Remove.
3268         (show_data): Unify creation and re-initialization cases.
3269
3270 2019-07-17  Tom Tromey  <tom@tromey.com>
3271
3272         * tui/tui-layout.c (make_command_window): Remove.
3273         (show_source_disasm_command, show_source_or_disasm_and_command):
3274         Unify creation and re-initialization cases.
3275
3276 2019-07-17  Tom Tromey  <tom@tromey.com>
3277
3278         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3279         creation and re-initialization cases.
3280
3281 2019-07-17  Tom Tromey  <tom@tromey.com>
3282
3283         * tui/tui-regs.c (tui_get_register): Return void.
3284
3285 2019-07-17  Tom Tromey  <tom@tromey.com>
3286
3287         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3288         Simplify.
3289
3290 2019-07-17  Tom Tromey  <tom@tromey.com>
3291
3292         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3293         resetting.
3294
3295 2019-07-17  Tom Tromey  <tom@tromey.com>
3296
3297         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3298         * tui/tui-regs.c (tui_reg_layout): New function.
3299         (tui_show_registers, tui_reg_command): Use it.
3300         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3301         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3302         parameters.
3303         (tui_layout_command): Remove.
3304
3305 2019-07-17  Tom Tromey  <tom@tromey.com>
3306
3307         * tui/tui-layout.h (tui/tui-layout): Return void.
3308         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3309
3310 2019-07-17  Tom Tromey  <tom@tromey.com>
3311
3312         * tui/tui-layout.c (show_source_disasm_command, show_data):
3313         Update.
3314         (reset_locator): Remove.
3315         (show_source_or_disasm_and_command): Update.
3316
3317 2019-07-17  Tom Tromey  <tom@tromey.com>
3318
3319         * tui/tui-source.c (tui_source_window_base::reset): Remove
3320         win_type parameter.
3321         * tui/tui-layout.c (make_command_window, make_source_window)
3322         (make_disasm_window, make_data_window)
3323         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3324         (reset_locator, show_source_or_disasm_and_command): Update.
3325         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3326         win_type parameter.
3327         (struct tui_source_window_base) <reset>: Likewise.
3328
3329 2019-07-17  Tom Tromey  <tom@tromey.com>
3330
3331         * tui/tui-layout.c (show_source_disasm_command): Use
3332         reset_locator.
3333         (reset_locator): New function.
3334         (init_and_make_win): Remove.
3335         (show_source_or_disasm_and_command): Use reset_locator.
3336
3337 2019-07-17  Tom Tromey  <tom@tromey.com>
3338
3339         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3340         condition.
3341         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3342         Remove condition.
3343         * tui/tui-source.c (tui_source_window_base::reset): New method.
3344         * tui/tui-layout.c (make_command_window): Don't call
3345         init_and_make_win.
3346         (make_source_window, make_disasm_window): Don't call
3347         make_source_or_disasm_window.
3348         (make_data_window): Don't call init_and_make_win.  Change calling
3349         convention.
3350         (show_source_disasm_command, show_data): Simplify.
3351         (make_source_or_disasm_window): Remove.
3352         (show_source_or_disasm_and_command): Simplify.
3353         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3354         (struct tui_source_window_base) <reset>: Likewise.
3355         <execution_info>: Remove initializer.
3356         * tui/tui-data.c (tui_source_window_base): Initialize
3357         execution_info.
3358
3359 2019-07-17  Tom Tromey  <tom@tromey.com>
3360
3361         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3362         variable.
3363
3364 2019-07-17  Tom Tromey  <tom@tromey.com>
3365
3366         * tui/tui.c (tui_rl_other_window): Update.
3367         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3368         superclass method first.  Always iterate over regs_content.
3369         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3370         method.
3371         * tui/tui-win.c (tui_set_focus_command): Update.
3372
3373 2019-07-17  Tom Tromey  <tom@tromey.com>
3374
3375         * tui/tui-win.c (tui_set_focus_command): Rename from
3376         tui_set_focus.  Call tui_enable.
3377         (tui_set_focus_command): Remove.
3378
3379 2019-07-17  Tom Tromey  <tom@tromey.com>
3380
3381         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3382         refresh_window.
3383         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3384         touchwin.
3385         (tui_data_window::refresh_window): Call refresh_window on data
3386         items.  Always call superclass refresh_window.
3387         (tui_win_info::refresh): Remove.
3388         (tui_source_window_base::refresh_window): Update.
3389         (tui_refresh_all): Update.
3390         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3391         refresh_window.
3392         (show_source_or_disasm_and_command): Likewise.
3393         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3394         (struct tui_source_window_base) <refresh>: Likewise.
3395
3396 2019-07-17  Tom Tromey  <tom@tromey.com>
3397
3398         * tui/tui-winsource.c (tui_clear_source_content)
3399         (tui_show_source_content): Update.
3400         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3401         whether content is empty.
3402         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3403         Remove.
3404
3405 2019-07-17  Tom Tromey  <tom@tromey.com>
3406
3407         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3408         window's contents.
3409         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3410         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3411
3412 2019-07-17  Tom Tromey  <tom@tromey.com>
3413
3414         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3415         (struct tui_data_item_window): Update.
3416
3417 2019-07-17  Tom Tromey  <tom@tromey.com>
3418
3419         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3420         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3421         defines.
3422
3423 2019-07-17  Tom Tromey  <tom@tromey.com>
3424
3425         * tui/tui-winsource.h (tui_erase_source_content)
3426         (tui_clear_source_content): Remove "display_prompt" parameter.
3427         * tui/tui-winsource.c (tui_update_source_window_as_is)
3428         (tui_update_source_windows_with_addr): Update.
3429         (tui_clear_source_content): Remove "display_prompt" parameter.
3430         (tui_erase_source_content): Likewise.  Simplify.
3431         (tui_show_source_content): Update.
3432         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3433         * tui/tui-stack.c (tui_show_frame_info): Update.
3434         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3435         Remove defines.
3436
3437 2019-07-17  Tom Tromey  <tom@tromey.com>
3438
3439         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3440         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3441         parameter.
3442         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3443         parameter.
3444
3445 2019-07-17  Tom Tromey  <tom@tromey.com>
3446
3447         * tui/tui-winsource.c (tui_clear_source_content)
3448         (tui_show_source_content, tui_show_exec_info_content)
3449         (tui_clear_exec_info_content): Update.
3450         * tui/tui-stack.c (tui_show_locator_content): Update.
3451         (tui_show_frame_info): Update.
3452         * tui/tui-source.h (tui_source_window): Don't declare.
3453         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3454         from tui_source_is_displayed.
3455         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3456         Remove field.
3457         (struct tui_source_window_base) <content_in_use>: New field.  Now
3458         bool.
3459         (struct tui_source_window) <showing_source_p>: New method.
3460         (TUI_SRC_WIN): Change cast.
3461         * tui/tui-data.c (tui_initialize_static_data): Update.
3462
3463 2019-07-17  Tom Tromey  <tom@tromey.com>
3464
3465         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3466         location_matches_p.
3467         * tui/tui-source.c (tui_source_window::location_matches_p): New
3468         method.
3469         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3470         method.
3471         * tui/tui-data.h (struct tui_source_window_base)
3472         <location_matches_p>: New method.
3473         (struct tui_source_window, struct tui_disasm_window)
3474         <location_matches_p>: Likewise.
3475
3476 2019-07-17  Tom Tromey  <tom@tromey.com>
3477
3478         * tui/tui-win.c (tui_set_win_height_command): Rename from
3479         tui_set_win_height.
3480         (tui_set_win_height_command): Remove.
3481
3482 2019-07-17  Tom Tromey  <tom@tromey.com>
3483
3484         * tui/tui-source.c (tui_source_window): New constructor.  Add
3485         observer.
3486         (~tui_source_window): New destructor.
3487         (tui_source_window::style_changed): New method.
3488         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3489         (tui_attach_detach_observers): Update.
3490         * tui/tui-data.h (struct tui_source_window): Make constructor not
3491         inline.  Add destructor.
3492         (struct tui_source_window) <style_changed>: New method.
3493         <m_observable>: New member.
3494
3495 2019-07-17  Tom Tromey  <tom@tromey.com>
3496
3497         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3498         * tui/tui-win.c (tui_resize_all): Fix typo.
3499
3500 2019-07-17  Tom Tromey  <tom@tromey.com>
3501
3502         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3503         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3504         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3505         * tui/tui-win.c (window_name_completer): Use foreach.
3506         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3507         (update_tab_width): Likewise.
3508         * tui/tui-layout.c (show_layout): Update.
3509         * tui/tui-data.h (class tui_window_iterator): New.
3510         (struct all_tui_windows): New.
3511         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3512
3513 2019-07-17  Tom Tromey  <tom@tromey.com>
3514
3515         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3516         parameter.  Don't reference globals.
3517         (tui_reg_command): Update.
3518
3519 2019-07-17  Tom Tromey  <tom@tromey.com>
3520
3521         * tui/tui-regs.c (tui_show_registers): Simplify.
3522
3523 2019-07-17  Tom Tromey  <tom@tromey.com>
3524
3525         * tui/tui-regs.c (tui_show_registers): Update.
3526         (tui_show_register_group): Add win_info parameter.
3527
3528 2019-07-17  Tom Tromey  <tom@tromey.com>
3529
3530         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3531         Rename from tui_display_reg_element_at_line.
3532         (tui_data_window::display_registers_from_line): Update.
3533         * tui/tui-data.h (struct tui_data_window)
3534         <display_reg_element_at_line>: New method.
3535
3536 2019-07-17  Tom Tromey  <tom@tromey.com>
3537
3538         * tui/tui-regs.h (tui_display_registers_from)
3539         (tui_display_registers_from_line): Don't declare.
3540         * tui/tui-windata.c (tui_data_window::display_all_data)
3541         (tui_data_window::refresh_all)
3542         (tui_data_window::do_scroll_vertical): Update.
3543         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3544         from tui_display_registers_from.
3545         (tui_display_reg_element_at_line): Update.
3546         (tui_data_window::display_registers_from_line): Rename from
3547         tui_display_registers_from_line.
3548         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3549         display_registers_from_line>: New methods.
3550
3551 2019-07-17  Tom Tromey  <tom@tromey.com>
3552
3553         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3554         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3555         from tui_erase_data_content.
3556         (tui_data_window::display_all_data)
3557         (tui_data_window::refresh_all)
3558         (tui_data_window::do_scroll_vertical): Update.
3559         * tui/tui-regs.c (tui_show_registers): Update.
3560         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3561         New method.
3562
3563 2019-07-17  Tom Tromey  <tom@tromey.com>
3564
3565         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3566         declare.
3567         * tui/tui-windata.c
3568         (tui_data_window::delete_data_content_windows): Rename from
3569         tui_delete_data_content_windows.
3570         (tui_data_window::display_all_data)
3571         (tui_data_window::do_scroll_vertical): Update.
3572         * tui/tui-data.h (struct tui_data_window)
3573         <delete_data_content_windows>: New method.
3574
3575 2019-07-17  Tom Tromey  <tom@tromey.com>
3576
3577         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3578         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3579
3580 2019-07-17  Tom Tromey  <tom@tromey.com>
3581
3582         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3583         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3584         from tui_display_all_data.
3585         * tui/tui-win.c
3586         (tui_data_window::do_make_visible_with_new_height): Update.
3587         * tui/tui-regs.c (tui_show_registers): Update.
3588         * tui/tui-layout.c (tui_set_layout): Update.
3589         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3590         method.
3591
3592 2019-07-17  Tom Tromey  <tom@tromey.com>
3593
3594         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3595         * tui/tui-windata.c (tui_display_data_from): Remove.
3596         (tui_data_window::refresh_all): Update.
3597
3598 2019-07-17  Tom Tromey  <tom@tromey.com>
3599
3600         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3601         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3602         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3603         tui_display_registers_from_line.
3604         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3605         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3606         "force_display" parameter.
3607
3608 2019-07-17  Tom Tromey  <tom@tromey.com>
3609
3610         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3611         declare.
3612         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3613         Rename from tui_first_reg_element_no_inline.
3614         (tui_display_reg_element_at_line)
3615         (tui_display_registers_from_line): Update.
3616         * tui/tui-data.h (struct tui_data_window)
3617         <first_reg_element_no_inline>: New method.
3618
3619 2019-07-17  Tom Tromey  <tom@tromey.com>
3620
3621         * tui/tui-windata.c (tui_display_data_from)
3622         (tui_data_window::do_scroll_vertical): Update.
3623         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3624         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3625         Rename from tui_line_from_reg_element_no.
3626         (tui_display_registers_from_line): Update.
3627         * tui/tui-data.h (struct tui_data_window)
3628         <line_from_reg_element_no>: New method.
3629
3630 2019-07-17  Tom Tromey  <tom@tromey.com>
3631
3632         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3633         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3634         tui_last_regs_line_no.
3635         (tui_display_reg_element_at_line)
3636         (tui_display_registers_from_line): Update.
3637         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3638         method.
3639
3640 2019-07-17  Tom Tromey  <tom@tromey.com>
3641
3642         PR tui/24722:
3643         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3644         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3645         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3646         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3647         (tui_update_breakpoint_info): Likewise.
3648         * tui/tui-hooks.c (tui_event_create_breakpoint)
3649         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3650         Update.
3651
3652 2019-07-17  Tom Tromey  <tom@tromey.com>
3653
3654         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3655
3656 2019-07-17  Tom Tromey  <tom@tromey.com>
3657
3658         * tui/tui-winsource.c (tui_update_source_window_as_is)
3659         (tui_update_source_windows_with_addr): Update.
3660         * tui/tui-source.h (tui_set_source_content)
3661         (tui_show_symtab_source): Add "win_info" parameter.
3662         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3663         parameter.
3664         (tui_show_symtab_source): Likewise.
3665
3666 2019-07-17  Tom Tromey  <tom@tromey.com>
3667
3668         * tui/tui-wingeneral.c
3669         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3670
3671 2019-07-17  Tom Tromey  <tom@tromey.com>
3672
3673         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3674         (struct tui_cmd_window) <can_scroll>: New method.
3675         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3676         method.
3677
3678 2019-07-17  Tom Tromey  <tromey@adacore.com>
3679
3680         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3681         do_field_signed>: Rename.  Change type of "value".
3682         * ui-out.c (ui_out::field_signed): Rename from field_int.
3683         Change type of "value".
3684         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3685         type of "value".
3686         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3687         do_field_int.  Change type of "value".
3688         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3689         do_field_int.  Change type of "value".
3690         * tracepoint.c (trace_status_mi, tfind_1)
3691         (print_one_static_tracepoint_marker): Update.
3692         * thread.c (print_thread_info_1, print_selected_thread_frame):
3693         Update.
3694         * stack.c (print_frame, print_frame_info): Update.
3695         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3696         Update.
3697         * source.c (print_source_lines_base): Update.
3698         * skip.c (info_skip_command): Update.
3699         * record-btrace.c (btrace_ui_out_decode_error)
3700         (btrace_call_history_src_line): Update.
3701         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3702         Update.
3703         * progspace.c (print_program_space): Update.
3704         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3705         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3706         do_field_int.  Change type of "value".
3707         * mi/mi-out.c (mi_ui_out::do_table_begin)
3708         (mi_ui_out::do_table_header): Update.
3709         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3710         type of "value".
3711         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3712         (mi_cmd_data_list_changed_registers, output_register)
3713         (mi_cmd_data_read_memory, mi_load_progress)
3714         (mi_cmd_trace_frame_collected): Update.
3715         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3716         Update.
3717         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3718         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3719         (mi_cmd_var_list_children, varobj_update_one): Update.
3720         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3721         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3722         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3723         * inferior.c (print_inferior): Update.
3724         * gdb_bfd.c (print_one_bfd): Update.
3725         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3726         Update.
3727         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3728         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3729         do_field_int.  Change type of "value".
3730         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3731         do_field_int.  Change type of "value".
3732         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3733         (print_one_breakpoint_location, print_it_catch_fork)
3734         (print_one_catch_fork, print_it_catch_vfork)
3735         (print_one_catch_vfork, print_it_catch_solib)
3736         (print_it_catch_exec, print_it_ranged_breakpoint)
3737         (print_mention_watchpoint, print_mention_masked_watchpoint)
3738         (bkpt_print_it, update_static_tracepoint): Update.
3739         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3740         * break-catch-syscall.c (print_it_catch_syscall): Update.
3741         * ada-tasks.c (print_ada_task_info): Update.
3742         * ada-lang.c (print_it_exception, print_mention_exception):
3743         Update.
3744
3745 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3746
3747         PR breakpoints/24541
3748         * gdbarch.c: Regenerate.
3749         * gdbarch.h: Regenerate.
3750         * gdbarch.sh: Adjust return type and parameter types for
3751         'stap_adjust_register'.
3752         (i386_stap_adjust_register): Adjust signature and return new
3753         register name.
3754         * stap-probe.c (stap_parse_register_operand): Adjust use of
3755         'gdbarch_stap_adjust_register'.
3756
3757 2019-07-17  Tom Tromey  <tromey@adacore.com>
3758
3759         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3760         declare VEC.
3761         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3762         std::vector.
3763         (struct s390_process_info): Add initializers.
3764         (s390_add_process): Use new.
3765         (s390_linux_nat_target::low_forget_process): Use delete.
3766         (s390_linux_nat_target::low_new_fork)
3767         (s390_linux_nat_target::stopped_by_watchpoint)
3768         (s390_linux_nat_target::low_prepare_to_resume)
3769         (s390_linux_nat_target::insert_watchpoint)
3770         (s390_linux_nat_target::insert_hw_breakpoint)
3771         (s390_linux_nat_target::remove_watchpoint)
3772         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3773
3774 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3775
3776         * aarch64-fbsd-nat.c: Include regcache.h.
3777         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3778         argument.
3779         (aarch64_fbsd_nat_target::fetch_registers)
3780         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3781         variable.
3782         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3783
3784 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3785
3786         * fbsd-nat.c: Include gdbarch.h.
3787
3788 2019-07-15  Tom Tromey  <tromey@adacore.com>
3789
3790         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3791
3792 2019-07-15  Tom Tromey  <tromey@adacore.com>
3793
3794         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3795         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3796         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3797         * cli-out.c (cli_ui_out::do_field_int): New method.
3798         * ui-out.c (ui_out::field_unsigned): New method.
3799         * symfile.c (generic_load): Use field_unsigned.
3800         (print_transfer_performance): Likewise.
3801         * record-btrace.c (ui_out_field_uint): Remove.
3802         (btrace_call_history_insn_range, btrace_call_history): Use
3803         field_unsigned.
3804         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3805         field_unsigned.
3806         * ui-out.h (class ui_out) <field_unsigned>: New method.
3807         <do_field_unsigned>: Likewise.
3808
3809 2019-07-15  Tom Tromey  <tromey@adacore.com>
3810
3811         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3812         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3813         * target.c (flash_erase_command): Use field_string.
3814         * infrun.c (print_signal_received_reason): Use field_string.
3815         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3816         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3817         field_string.
3818         * ada-tasks.c (print_ada_task_info): Use field_string.
3819
3820 2019-07-15  Tom Tromey  <tromey@adacore.com>
3821
3822         * target.c (flash_erase_command): Use field_core_addr.
3823         * symfile.c (generic_load): Use field_core_addr.
3824         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3825         Use field_core_addr.
3826         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3827         field_core_addr.
3828
3829 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3830
3831         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3832         value if its desired type is smaller than a CORE_ADDR and signed.
3833
3834 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3835
3836         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3837         of changes to field names, and use new is_reference field to
3838         decide if a property is a reference or not.
3839         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3840         field.
3841         (struct dwarf2_property_baton): Update header comment, rename
3842         'referenced_type' to 'property_type' and update comments.
3843         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3844         default property type, store in property baton, update to take
3845         accound of renamed field.
3846         (read_func_scope): Update call to attr_to_dynamic_prop.
3847         (read_array_type): Likewise.
3848         (dwarf2_per_cu_addr_sized_int_type): New function.
3849         (read_subrange_index_type): Move type finding code to
3850         dwarf2_per_cu_addr_sized_int_type.
3851         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3852         (dwarf2_per_cu_addr_type): New function.
3853         (set_die_type): Update calls to attr_to_dynamic_prop.
3854
3855 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3856
3857         * dwarf2read.c (read_subrange_index_type): New function.
3858         (read_subrange_type): Move code into new function and call it.
3859         * gdbtypes.c (create_range_type): Add some asserts.
3860
3861 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3862
3863         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3864         update return statements.
3865         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3866         declaration, and update comment to match.
3867         * gdbtypes.c (resolve_dynamic_array): Update call to
3868         dwarf2_evaluate_property to match new return type.
3869
3870 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3871
3872         * valarith.c (value_subscripted_rvalue): Change lowerbound
3873         parameter type from int to LONGEST.
3874         * value.h (value_subscripted_rvalue): Likewise in declaration.
3875
3876 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3877
3878         * cli/cli-utils.c (info_print_command_completer): New function.
3879         * cli/cli-utils.h: Add 'completer.h' include, and forward
3880         declaration for 'struct cmd_list_element'.
3881         (info_print_command_completer): Declare.
3882         * stack.c (_initialize_stack): Add completer for 'info locals' and
3883         'info args'.
3884         * symtab.c (_initialize_symtab): Add completer for 'info
3885         variables' and 'info functions'.
3886         * NEWS: Mention completion for additional info commands.
3887
3888 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3889
3890         * cli/cli-utils.c (extract_info_print_args): Delete.
3891         (extract_arg_maybe_quoted): Delete.
3892         (info_print_options_defs): New variable.
3893         (make_info_print_options_def_group): New function.
3894         (extract_info_print_options): Define new function.
3895         * cli/cli-utils.h (extract_info_print_args): Delete.
3896         (struct info_print_options): New structure.
3897         (extract_info_print_options): Declare new function.
3898         * stack.c (info_locals_command): Update to use new
3899         extract_info_print_options, also add a header comment.
3900         (info_args_command): Likewise.
3901         * symtab.c (info_variables_command): Likewise.
3902         (info_functions_command): Likewise.
3903
3904 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3905
3906         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3907         to extract string arguments.
3908         * common/common-utils.c (extract_string_maybe_quoted): New function.
3909         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3910
3911 2019-07-11  Tom Tromey  <tromey@adacore.com>
3912
3913         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3914         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3915         * top.h (gdbinit): Don't declare.
3916         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3917         into...
3918         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3919         * top.c (gdb_init): Don't call init_cli_cmds.
3920         (gdbinit): Remove.
3921         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3922
3923 2019-07-11  Tom Tromey  <tromey@adacore.com>
3924
3925         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3926         after it has been moved.
3927
3928 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3929
3930         * valops.c (value_must_coerce_to_target): Change return type to
3931         bool.
3932         * value.h (value_must_coerce_to_target): Likewise.
3933
3934 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3935
3936         * breakpoint.c (is_hardware_watchpoint): Remove
3937         forward-declaration.
3938         (is_masked_watchpoint): Change return type to bool.
3939         (is_tracepoint): Likewise.
3940         (is_breakpoint): Likewise.
3941         (is_hardware_watchpoint): Likewise.
3942         (is_watchpoint): Likewise.
3943         (is_no_memory_software_watchpoint): Likewise.
3944         (is_catchpoint): Likewise.
3945         (breakpoint_1): Make FILTER parameter's return type bool.
3946         is_masked_watchpoint): Change return type to bool.
3947         (save_breakpoints): Make FILTER parameter's return type bool.
3948         * breakpoint.h (is_breakpoint): Change return type to bool.
3949         (is_watchpoint): Likewise.
3950         (is_catchpoint): Likewise.
3951         (is_tracepoint): Likewise.
3952
3953 2019-07-10  Tom Tromey  <tom@tromey.com>
3954
3955         * defs.h: Don't include gdbarch.h.
3956         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3957         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3958         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3959         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3960         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3961         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3962         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3963         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3964         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3965         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3966         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3967         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3968         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3969         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3970         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3971         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3972         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3973         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3974         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3975         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3976         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3977         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3978         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3979         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3980         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3981         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3982         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3983
3984 2019-07-10  Tom Tromey  <tromey@adacore.com>
3985
3986         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3987         * breakpoint.c (init_ada_exception_breakpoint): Register as
3988         bp_catchpoint.
3989         (print_one_breakpoint_location, print_one_breakpoint): Use
3990         is_ada_exception_catchpoint.
3991         * ada-lang.c (class ada_catchpoint_location): Pass
3992         bp_loc_software_breakpoint to bp_location constructor.
3993         (is_ada_exception_catchpoint): New function.
3994
3995 2019-07-10  Tom Tromey  <tromey@adacore.com>
3996
3997         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3998         VEC.
3999         (struct arm_exidx_entry): New method operator<.
4000         (struct arm_exidx_data) <section_maps>: Change type.
4001         (arm_exidx_data_free): Remove.
4002         (arm_exidx_data_key): Change type.  Move lower.
4003         (arm_exidx_new_objfile): Update.
4004         (arm_compare_exidx_entries): Remove.
4005         (arm_find_exidx_entry, _initialize_arm_tdep)
4006
4007 2019-07-10  Tom Tromey  <tromey@adacore.com>
4008
4009         * solib-spu.c (ocl_program_data_key): Change type.
4010         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4011         Update.
4012
4013 2019-07-10  Tom Tromey  <tromey@adacore.com>
4014
4015         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4016         (struct solib_aix_inferior_data) <library_list>: Change type.
4017         (solib_aix_inferior_data_handle): Change type.
4018         (get_solib_aix_inferior_data): Update.
4019         (solib_aix_free_library_list): Remove.
4020         (library_list_start_library): Update.
4021         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4022         return type.
4023         (solib_aix_get_library_list)
4024         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4025         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4026
4027 2019-07-10  Tom Tromey  <tromey@adacore.com>
4028
4029         * solib-dsbt.c (struct dsbt_info): Add initializers.
4030         (solib_dsbt_pspace_data): Change type.
4031         (dsbt_pspace_data_cleanup): Remove.
4032         (get_dsbt_info, _initialize_dsbt_solib): Update.
4033
4034 2019-07-10  Tom Tromey  <tromey@adacore.com>
4035
4036         * spu-tdep.c (spu_overlay_data): Change type.
4037         (spu_get_overlay_table, spu_overlay_new_objfile)
4038         (_initialize_spu_tdep): Update.
4039
4040 2019-07-10  Tom Tromey  <tromey@adacore.com>
4041
4042         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4043         destructor.
4044         (dbx_objfile_data_key): Change type and declare later.
4045         (DBX_SYMFILE_INFO): Rewrite.
4046         * dbxread.c (dbx_objfile_data_key): Change type.
4047         (dbx_symfile_init): Update.
4048         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4049         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4050         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4051
4052 2019-07-10  Tom Tromey  <tromey@adacore.com>
4053
4054         * jit.c (jit_program_space_key): Change type.  Move lower.
4055         (get_jit_program_space_data): Update.
4056         (jit_program_space_data_cleanup): Remove.
4057         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4058         Update.
4059         (struct jit_program_space_data): Add initializers.
4060
4061 2019-07-10  Tom Tromey  <tromey@adacore.com>
4062
4063         * solib-darwin.c (struct darwin_info): Add initializers.
4064         (solib_darwin_pspace_data): Change type.
4065         (darwin_pspace_data_cleanup): Remove.
4066         (get_darwin_info, _initialize_darwin_solib): Update.
4067
4068 2019-07-10  Tom Tromey  <tromey@adacore.com>
4069
4070         * remote-sim.c (struct sim_inferior_data): Add initializers,
4071         constructor, and destructor.
4072         (sim_inferior_data_key): Change type.  Move lower.
4073         (check_for_duplicate_sim_descriptor): Update.
4074         (get_sim_inferior_data): Use new.  Update.
4075         (~sim_inferior_data_cleanup): Rename from
4076         sim_inferior_data_cleanup.  Simplify.
4077         (gdbsim_close_inferior, simulator_command)
4078         (sim_command_completer, _initialize_remote_sim): Update.
4079         (next_pid, INITIAL_PID): Move earlier.
4080
4081 2019-07-10  Tom Tromey  <tromey@adacore.com>
4082
4083         * python/python-internal.h (create_thread_object): Return
4084         gdbpy_ref.
4085         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4086         * python/py-inferior.c (struct threadlist_entry): Add
4087         constructor.
4088         <thread_obj>: Now a gdbpy_ref.
4089         (thread_to_thread_object): Update.
4090         (add_thread_object): Use new.
4091         (delete_thread_object): Use delete.
4092         (infpy_threads): Update.
4093         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4094         GIL.
4095
4096 2019-07-10  Tom Tromey  <tromey@adacore.com>
4097
4098         * valops.c (value_cast): Specialize error message for Ada.
4099
4100 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4101
4102         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4103
4104 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4105
4106         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4107         bpstat_should_step): Return bool, adjust comments.
4108         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4109         bpstat_should_step): Likewise.
4110
4111 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4112
4113         * features/Makefile: Use feature target descriptions for Arm.
4114         * features/arm/arm-core.c: Generate new file.
4115         * features/arm/arm-fpa.c: Likewise.
4116         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4117         * features/arm/arm-m-profile.c: Likewise.
4118         * features/arm/arm-vfpv2.c: Likewise.
4119         * features/arm/arm-vfpv3.c: Likewise.
4120         * features/arm/xscale-iwmmxt.c: Likewise.
4121         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4122
4123 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4124
4125         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4126         ptrace earlier.
4127
4128 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4129
4130         * features/aarch64-pauth.c: Regenerate.
4131
4132 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4133
4134         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4135         bool.
4136         (bpstat_what): Use false instead of 0.
4137
4138 2019-07-09  Pedro Alves  <palves@redhat.com>
4139
4140         * break-catch-throw.c (is_exception_catchpoint): New.
4141         * breakpoint.c (print_one_breakpoint_location): New parameter
4142         'raw_loc'.  Handle it.  Use
4143         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4144         looking at the breakpoint's type.
4145         (print_one_breakpoint): If handling "maint info breakpoints", also
4146         print locations of exception catchpoints.
4147         * breakpoint.h (is_exception_catchpoint): Declare.
4148
4149 2019-07-09  Pedro Alves  <palves@redhat.com>
4150
4151         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4152         "addr" field.
4153         (allocate_location_exception_catchpoint): New.
4154         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4155         (initialize_throw_catchpoint_ops): Install
4156         allocate_location_exception_catchpoint as allocate_location
4157         method.
4158         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4159         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4160         bp_loc_other.
4161         (breakpoint_address_is_meaningful): Delete.
4162         (bl_address_is_meaningful): New.
4163         (breakpoint_locations_match): Adjust comment.
4164         (bp_location_from_bp_type): New, factored out of...
4165         (bp_location::bp_location(breakpoint *)): ... this.
4166         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4167         factored out of...
4168         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4169         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4170         breakpoint_address_is_meaningful.
4171         (bp_locations_compare): Adjust comment.
4172         (update_global_location_list): Use bl_address_is_meaningful
4173         instead of breakpoint_address_is_meaningful.
4174         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4175         explicit.
4176         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4177         * python/py-breakpoint.c (bppy_get_location): No longer check
4178         whether location is null.
4179
4180 2019-07-09  Pedro Alves  <palves@redhat.com>
4181
4182         PR c++/15468
4183         * breakpoint.c (print_one_breakpoint_location): Remove
4184         single-location assert.
4185
4186 2019-07-09  Tom Tromey  <tom@tromey.com>
4187
4188         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4189         * configure: Rebuild.
4190         * configure.ac: Change common to gdbsupport.
4191         * gdbsupport: Rename from common.
4192         * acinclude.m4: Change common to gdbsupport.
4193         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4194         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4195         gdbsupport.
4196         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4197         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4198         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4199         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4200         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4201         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4202         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4203         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4204         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4205         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4206         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4207         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4208         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4209         coff-pe-read.c, command.h, compile/compile-c-support.c,
4210         compile/compile-c.h, compile/compile-cplus-symbols.c,
4211         compile/compile-cplus-types.c, compile/compile-cplus.h,
4212         compile/compile-loc2c.c, compile/compile.c, completer.c,
4213         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4214         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4215         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4216         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4217         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4218         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4219         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4220         features/aarch64-core.c, features/aarch64-fpu.c,
4221         features/aarch64-pauth.c, features/aarch64-sve.c,
4222         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4223         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4224         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4225         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4226         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4227         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4228         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4229         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4230         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4231         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4232         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4233         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4234         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4235         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4236         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4237         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4238         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4239         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4240         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4241         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4242         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4243         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4244         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4245         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4246         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4247         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4248         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4249         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4250         minsyms.c, mips-linux-tdep.c, namespace.h,
4251         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4252         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4253         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4254         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4255         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4256         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4257         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4258         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4259         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4260         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4261         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4262         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4263         procfs.c, producer.c, progspace.h, psymtab.h,
4264         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4265         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4266         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4267         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4268         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4269         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4270         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4271         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4272         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4273         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4274         target-memory.c, target.c, target.h, target/waitstatus.c,
4275         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4276         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4277         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4278         unittests/array-view-selftests.c,
4279         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4280         unittests/common-utils-selftests.c,
4281         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4282         unittests/format_pieces-selftests.c,
4283         unittests/function-view-selftests.c,
4284         unittests/lookup_name_info-selftests.c,
4285         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4286         unittests/mkdir-recursive-selftests.c,
4287         unittests/observable-selftests.c,
4288         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4289         unittests/parse-connection-spec-selftests.c,
4290         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4291         unittests/scoped_fd-selftests.c,
4292         unittests/scoped_mmap-selftests.c,
4293         unittests/scoped_restore-selftests.c,
4294         unittests/string_view-selftests.c, unittests/style-selftests.c,
4295         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4296         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4297         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4298         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4299         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4300         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4301
4302 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4303
4304         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4305         bool value.
4306         (decode_digits_ordinary): Set explicit_line field in sal.
4307         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4308         symtab_and_line that was set on an explicit line number in
4309         assembler code.  Do always update the recorded symtab and line if
4310         we do skip the prologue.
4311
4312 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4313
4314         * breakpoint.c (set_breakpoint_location_function): Remove
4315         explicit_loc parameter.
4316         (momentary_breakpoint_from_master): Update call to
4317         set_breakpoint_location_function.
4318         (add_location_to_breakpoint): Likewise.
4319
4320 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4321
4322         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4323         required features based on default bfd type when no specific bfd
4324         is present.
4325
4326 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4327
4328         * NEWS: Mention that GDB printf and eval commands can now print
4329         C-style and Ada-style convenience var strings without
4330         calling the inferior.
4331         * printcmd.c (printf_c_string): Locally print GDB internal var
4332         instead of transiting via the inferior.
4333         (printf_wide_c_string): Likewise.
4334
4335 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4336
4337         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4338
4339 2019-07-04  Tom Tromey  <tom@tromey.com>
4340
4341         PR tui/24724:
4342         * tui/tui-winsource.c (tui_clear_source_content): Update.
4343         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4344         (tui_update_breakpoint_info): Update.
4345         (tui_set_exec_info_content): Update.
4346         * tui/tui-source.c (tui_set_source_content_nil): Update.
4347         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4348         has_break.
4349         * tui/tui-data.h (enum tui_bp_flag): New.
4350         (tui_bp_flags): New enum flags type.
4351         (struct tui_source_element) <break_mode>: Change type.  Rename
4352         from has_break.
4353         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4354         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4355         constants.
4356         * tui/tui-winsource.h: Fix comment.
4357
4358 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4359
4360         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4361         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4362         (store_fpregs_to_thread)
4363         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4364         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4365         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4366         (IWMMXT_REGS_SIZE): Add define.
4367         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4368         (fetch_vfp_regs, store_vfp_regs)
4369         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4370         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4371
4372 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4373
4374         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4375         defines.
4376         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4377         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4378         (ARM_INT_REGISTER_SIZE): ...to this.
4379         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4380         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4381         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4382         (arm_linux_collect_gregset, supply_nwfpe_register)
4383         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4384         defines.
4385         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4386         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4387         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4388         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4389         (arm_return_in_memory, arm_store_return_value)
4390         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4391         (arm_record_ld_st_multiple): Likewise.
4392         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4393         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4394
4395 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4396
4397         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4398         AARCH64_DISPLACED_MODIFIED_INSNS.
4399         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4400         (aarch64_displaced_step_copy_insn): Likewise.
4401         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4402         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4403         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4404         ARM_DISPLACED_MODIFIED_INSNS.
4405         * arm-tdep.c (arm_gdbarch_init): Likewise.
4406         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4407         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4408         (struct arm_displaced_step_closure): Use
4409         ARM_DISPLACED_MODIFIED_INSNS.
4410
4411 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4412
4413         * features/Makefile: Remove unused xml files.
4414         * features/aarch64.xml: Remove.
4415         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4416         * features/i386/amd64-avx-avx512.xml: Remove.
4417         * features/i386/amd64-avx-linux.xml: Remove.
4418         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4419         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4420         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4421         * features/i386/amd64-avx-mpx.xml: Remove.
4422         * features/i386/amd64-avx.xml: Remove.
4423         * features/i386/amd64-linux.xml: Remove.
4424         * features/i386/amd64-mpx-linux.xml: Remove.
4425         * features/i386/amd64-mpx.xml: Remove.
4426         * features/i386/amd64.xml: Remove.
4427         * features/i386/i386-avx-avx512-linux.xml: Remove.
4428         * features/i386/i386-avx-avx512.xml: Remove.
4429         * features/i386/i386-avx-linux.xml: Remove.
4430         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4431         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4432         * features/i386/i386-avx-mpx-linux.xml: Remove.
4433         * features/i386/i386-avx-mpx.xml: Remove.
4434         * features/i386/i386-avx.xml: Remove.
4435         * features/i386/i386-linux.xml: Remove.
4436         * features/i386/i386-mmx-linux.xml: Remove.
4437         * features/i386/i386-mmx.xml: Remove.
4438         * features/i386/i386-mpx-linux.xml: Remove.
4439         * features/i386/i386-mpx.xml: Remove.
4440         * features/i386/i386.xml: Remove.
4441         * features/i386/x32-avx-avx512-linux.xml: Remove.
4442         * features/i386/x32-avx-linux.xml: Remove.
4443         * features/i386/x32-linux.xml: Remove.
4444
4445 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4446
4447         * regformats/aarch64.dat: Remove.
4448         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4449         * regformats/i386/amd64-avx-linux.dat: Remove.
4450         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4451         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4452         * regformats/i386/amd64-linux.dat: Remove.
4453         * regformats/i386/amd64-mpx-linux.dat: Remove.
4454         * regformats/i386/amd64.dat: Remove.
4455         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4456         * regformats/i386/i386-avx-linux.dat: Remove.
4457         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4458         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4459         * regformats/i386/i386-linux.dat: Remove.
4460         * regformats/i386/i386-mmx-linux.dat: Remove.
4461         * regformats/i386/i386-mpx-linux.dat: Remove.
4462         * regformats/i386/i386.dat: Remove.
4463         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4464         * regformats/i386/x32-avx-linux.dat: Remove.
4465         * regformats/i386/x32-linux.dat: Remove.
4466
4467 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4468
4469         * aarch64-tdep.c: Remove xml self tests.
4470         * amd64-linux-tdep.c: Likewise.
4471         * amd64-tdep.c: Likewise.
4472         * i386-linux-tdep.c: Likewise.
4473         * i386-tdep.c: Likewise.
4474
4475 2019-07-03  Pedro Alves  <palves@redhat.com>
4476
4477         PR cli/24732
4478         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4479         (pipe_cmd_option_defs): New.
4480         (make_pipe_cmd_options_def_group): New.
4481         (pipe_command): Use gdb::option::process_options.
4482         (pipe_command_completer): New function.
4483         (_initialize_cli_cmds): Install completer for "pipe" command.
4484
4485 2019-07-03  Pedro Alves  <palves@redhat.com>
4486
4487         * cli/cli-option.c (union option_value) <string>: New field.
4488         (struct option_def_and_value): Add ctor, move ctor, dtor and
4489         use DISABLE_COPY_AND_ASSIGN.
4490         (option_def_and_value::clear_value): New.
4491         (parse_option, save_option_value_in_ctx, get_val_type_str)
4492         (add_setshow_cmds_for_options): Handle var_string.
4493         * cli-option.h (union option_def::var_address) <string>: New
4494         field.
4495         (struct string_option_def): New.
4496         * maint-test-options.c (struct test_options_opts): Add default
4497         ctor and use DISABLE_COPY_AND_ASSIGN.
4498         <string_opt>: New field.
4499         (test_options_opts::~test_options_opts): New.
4500         (test_options_opts::dump): Also dump "-string".
4501         (test_options_option_defs): Install "string.
4502
4503 2019-07-03  Pedro Alves  <palves@redhat.com>
4504
4505         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4506         option_value with a null enumeration.
4507         (complete_options): Save the option values in the context.
4508         (save_option_value_in_ctx): New, factored out from ...
4509         (process_options): ... here.
4510         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4511         of the function.
4512         * maint-test-options.c (test_options_opts::dump): New, factored
4513         out from ...
4514         (maintenance_test_options_command_mode): ... here.
4515         (maintenance_test_options_command_completion_result): Delete.
4516         (maintenance_test_options_command_completion_text): Update
4517         comment.
4518         (maintenance_show_test_options_completion_result): Change
4519         prototype.  Just print
4520         maintenance_test_options_command_completion_text.
4521         (save_completion_result): New.
4522         (maintenance_test_options_completer_mode): Pass options context to
4523         complete_options, and then save a dump.
4524         (_initialize_maint_test_options): Use add_cmd to install "maint
4525         show test-options-completion-result".
4526
4527 2019-07-03  Pedro Alves  <palves@redhat.com>
4528
4529         * NEWS (New commands): Mention "with" and "maint with".
4530         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4531         (with_command, with_command_completer): New.
4532         (pipe_command): Adjust to new repeat_previous
4533         interface.
4534         (_initialize_cli_cmds): Install the "with" command and its "w"
4535         alias.
4536         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4537         declarations.
4538         * cli/cli-setshow.c (parse_cli_var_uinteger)
4539         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4540         argument strings for all var_types.
4541         (get_setshow_command_value_string): New, factored out from ...
4542         (do_show_command): ... this.
4543         * cli/cli-setshow.h: Include <string>.
4544         (get_setshow_command_value_string): Declare.
4545         * command.h (repeat_previous): Now returns const char *.  Adjust
4546         comment.
4547         * maint.c: Include "cli/cli-cmds.h".
4548         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4549         (_initialize_maint_cmds): Register the "maintenance with" command.
4550         * top.c (repeat_previous): Move bits from pipe_command here:
4551         Return the saved command line, if any; error out if there's no
4552         command to relaunch.
4553
4554 2019-07-03  Pedro Alves  <palves@redhat.com>
4555
4556         * NEWS (New commands): Mention "maint set/show test-settings"
4557         instead of "maint test-settings".
4558         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4559         (maintenance_test_settings_set_list): Rename to ...
4560         (maintenance_set_test_settings_list): ... this.
4561         (maintenance_test_settings_show_list): Rename to  ...
4562         (maintenance_show_test_settings_list): ... this.
4563         (maintenance_test_settings_cmd): Delete.
4564         (maintenance_test_settings_set_cmd): ...
4565         (maintenance_set_test_settings_cmd): ... this.
4566         (maintenance_test_settings_show_cmd): ...
4567         (maintenance_show_test_settings_cmd): ... this.
4568         (maintenance_test_settings_show_value_cmd):
4569         (maintenance_show_test_settings_value_cmd): ... this.
4570         (_initialize_maint_test_settings): No longer install the "maint
4571         test-settings" prefix command.  Rename "maint test-settings set"
4572         to "maint set test-settings", and "maint test-settings show" to
4573         "maint show test-settings".  Adjust all subcommands.
4574
4575 2019-07-03  Pedro Alves  <palves@redhat.com>
4576
4577         * maint-test-settings.c: Fix file's intro comment.  Replace all
4578         references to "test-options" with references to "test-settings",
4579         in comments.
4580
4581 2019-07-03  Pedro Alves  <palves@redhat.com>
4582
4583         * maint-test-settings.c (maintenance_test_settings_xxx)
4584         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4585         New.
4586         (maintenance_test_settings_enums): Use them.
4587         (maintenance_test_settings_enum): Default to
4588         maintenance_test_settings_xxx.
4589         (_initialize_maint_test_settings): Initialize
4590         MAINTENANCE_TEST_SETTINGS_FILENAME.
4591
4592 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4593
4594         * breakpoint.h (remove_breakpoints_inf): Change return type to
4595         void, move function documentation here.
4596         * breakpoint.c (remove_breakpoints_inf): Change return type to
4597         void, move function documentation to header.
4598
4599 2019-07-02  Pedro Alves  <palves@redhat.com>
4600
4601         * NEWS (Completion improvements): Mention "info threads".
4602         * thread.c (struct info_threads_opts, info_threads_option_defs)
4603         (make_info_threads_options_def_group): New.
4604         (info_threads_command): Use gdb::option::process_options.
4605         (info_threads_command_completer): New.
4606         (_initialize_thread): Use gdb::option::build_help to build the
4607         help text for "info threads".
4608
4609 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4610
4611         * defs.h (generic_load): Move from here...
4612         * symfile.h (generic_load): ... to here.  Rename name parameter
4613         to args.
4614         * symfile.c (generic_load): Add comment.
4615
4616 2019-07-01  Tom Tromey  <tromey@adacore.com>
4617
4618         * dwarf2read.c
4619         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4620         declaration of without_params.  Fix formatting.
4621
4622 2019-07-01  Tom Tromey  <tromey@adacore.com>
4623
4624         * ada-exp.y (find_primitive_type): Update.
4625         * ada-lang.h (ada_lookup_symbol): Update.
4626         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4627         parameter.
4628         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4629
4630 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4631
4632         PR breakpoints/24541
4633         * gdbarch.c: Regenerate.
4634         * gdbarch.h: Regenerate.
4635         * gdbarch.sh: Add 'stap_adjust_register'.
4636         * i386-tdep.c: Include '<unordered_set>'.
4637         (i386_stap_adjust_register): New function.
4638         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4639         * stap-probe.c (stap_parse_register_operand): Call
4640         'gdbarch_stap_adjust_register'.
4641
4642 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4643
4644         PR python/24742
4645         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4646         * python/python.c (do_start_initialization): Use 'xmalloc'
4647         instead of 'PyMem_Malloc'.
4648
4649 2019-06-28  Tom Tromey  <tromey@adacore.com>
4650
4651         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4652         for Ada.
4653
4654 2019-06-27  Tom Tromey  <tromey@adacore.com>
4655
4656         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4657         objfile_key.
4658         (arm_find_mapping_symbol, arm_record_special_symbol)
4659         (_initialize_arm_tdep): Update.
4660         (arm_objfile_data_free): Remove.
4661
4662 2019-06-27  Tom Tromey  <tromey@adacore.com>
4663
4664         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4665         to cp_print_static_field.
4666
4667 2019-06-26  Tom Tromey  <tromey@adacore.com>
4668
4669         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4670         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4671         declare.
4672
4673 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4674
4675         * features/aarch64-core.c (create_feature_aarch64_core):
4676         Regenerate.
4677         * features/aarch64-core.xml: Add cpsr flags.
4678
4679 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4680
4681         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4682         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4683
4684 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4685
4686         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4687         field.
4688         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4689         use.
4690         (arm_record_special_symbol): Don't insert new symbol in sorted
4691         position, push it at the end.
4692
4693 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4694
4695         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4696         (arm_mapping_symbol_s): Remove.
4697         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4698         (arm_mapping_symbol_vec): New typedef.
4699         (struct arm_per_objfile): Add constructor.
4700         <section_maps>: Change type to
4701         std::unique_ptr<arm_mapping_symbol_vec[]>.
4702         (arm_compare_mapping_symbols): Remove.
4703         (arm_find_mapping_symbol): Adjust to section_maps type change.
4704         (arm_objfile_data_free): Call delete on arm_per_objfile.
4705         (arm_record_special_symbol): Adjust to section_maps type change.
4706         Allocate arm_per_objfile with new.
4707
4708 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4709
4710         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4711         with the command prefix.
4712
4713 2019-06-25  Tom Tromey  <tom@tromey.com>
4714
4715         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4716         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4717
4718 2019-06-25  Tom Tromey  <tom@tromey.com>
4719
4720         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4721         type.
4722         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4723         protected.
4724
4725 2019-06-25  Tom Tromey  <tom@tromey.com>
4726
4727         * tui/tui-winsource.c
4728         (tui_source_window_base::set_is_exec_point_at): Add check against
4729         LOA_ADDRESS.
4730
4731 2019-06-25  Tom Tromey  <tom@tromey.com>
4732
4733         * tui/tui-source.c (tui_set_source_content): Don't check before
4734         xfree.
4735         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4736
4737 2019-06-25  Tom Tromey  <tom@tromey.com>
4738
4739         * tui/tui-winsource.h (tui_update_source_window_as_is)
4740         (tui_alloc_source_buffer, tui_line_is_displayed)
4741         (tui_addr_is_displayed): Change type of win_info.
4742         * tui/tui-winsource.c (tui_update_source_window_as_is)
4743         (tui_clear_source_content, tui_show_source_line)
4744         (tui_show_source_content, tui_source_window_base::refill)
4745         (tui_source_window_base::set_is_exec_point_at)
4746         (tui_source_window_base::set_is_exec_point_at)
4747         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4748         (tui_alloc_source_buffer, tui_line_is_displayed)
4749         (tui_addr_is_displayed): Change type of win_info.  Update.
4750         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4751         (tui_source_window_base::do_make_visible_with_new_height):
4752         Update.
4753         * tui/tui-source.c (tui_set_source_content)
4754         (tui_set_source_content_nil)
4755         (tui_source_window::do_scroll_vertical): Update.
4756         * tui/tui-layout.c (show_layout): Update.
4757         * tui/tui-disasm.c (tui_set_disassem_content)
4758         (tui_disasm_window::do_scroll_vertical): Update.
4759         * tui/tui-data.h (tui_win_content): Remove.
4760         (struct tui_gen_win_info) <content, content_size>: Remove.
4761         (struct tui_source_element): Add initializers and destructor.
4762         (union tui_which_element, struct tui_win_element): Remove.
4763         (struct tui_source_window_base) <content>: New field.
4764         (struct tui_data_window): Remove destructor.
4765         (tui_alloc_content, tui_free_win_content)
4766         (tui_free_all_source_wins_content): Don't declare.
4767         * tui/tui-data.c (tui_initialize_static_data): Update.
4768         (init_content_element, tui_alloc_content): Remove.
4769         (~tui_gen_win_info): Update.
4770         (~tui_data_window, tui_free_all_source_wins_content)
4771         (tui_free_win_content, free_content, free_content_elements):
4772         Remove.
4773
4774 2019-06-25  Tom Tromey  <tom@tromey.com>
4775
4776         * tui/tui-winsource.h (tui_clear_source_content)
4777         (tui_erase_source_content, tui_show_source_content): Change type
4778         of win_info.
4779         * tui/tui-winsource.c (tui_clear_source_content)
4780         (tui_erase_source_content, tui_show_source_content): Change type
4781         of win_info.
4782         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4783         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4784         win_info.
4785         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4786         win_info.
4787         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4788
4789 2019-06-25  Tom Tromey  <tom@tromey.com>
4790
4791         * tui/tui-winsource.c (tui_clear_source_content)
4792         (tui_source_window_base::set_is_exec_point_at): Update.
4793         * tui/tui-source.c (tui_set_source_content_nil): Update.
4794         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4795         a bool.
4796         * tui/tui-data.c (init_content_element): Update.
4797
4798 2019-06-25  Tom Tromey  <tom@tromey.com>
4799
4800         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4801         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4802         * tui/tui-layout.c (init_and_make_win): Update.
4803         * tui/tui.h (enum tui_win_type): Update.
4804         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4805         tui_win_is_auxillary.
4806         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4807         tui_win_is_auxillary.
4808
4809 2019-06-25  Tom Tromey  <tom@tromey.com>
4810
4811         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4812         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4813         (tui_delete_data_content_windows, tui_display_all_data)
4814         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4815         Update.
4816         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4817         * tui/tui-regs.c (tui_last_regs_line_no)
4818         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4819         (tui_show_registers): Update.
4820         (tui_show_register_group): Return void.  Update.
4821         (tui_display_registers_from, tui_display_reg_element_at_line)
4822         (tui_display_registers_from_line, tui_check_register_values):
4823         Update.
4824         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4825         member.
4826         (struct tui_data_window) <regs_content>: Now a std::vector.
4827         <regs_content_count>: Remove.
4828         (tui_add_content_elements, tui_free_data_content): Don't declare.
4829         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4830         (init_content_element): Remove DATA_WIN case.  Add assert.
4831         (tui_add_content_elements): Remove.
4832         (tui_data_window): Update.
4833         (tui_free_data_content): Remove.
4834         (free_content_elements): Remove DATA_WIN case.
4835
4836 2019-06-25  Tom Tromey  <tom@tromey.com>
4837
4838         * tui/tui-data.c (tui_data_item_window): Update.
4839         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4840         * tui/tui-windata.c (tui_display_all_data)
4841         (tui_display_data_from_line): Update.
4842         (tui_check_data_values): Remove.
4843         * tui/tui-regs.c (tui_show_register_group)
4844         (tui_display_reg_element_at_line): Update.
4845         * tui/tui-hooks.c (tui_register_changed)
4846         (tui_refresh_frame_and_register_information): Call
4847         tui_check_register_values.
4848         * tui/tui-data.h (struct tui_data_window) <data_content,
4849         data_content_count, data_type>: Remove.
4850         (enum tui_data_type): Remove.
4851
4852         * tui/tui-data.c (tui_data_window::clear_detail)
4853         (~tui_data_window): Update.
4854
4855 2019-06-25  Tom Tromey  <tom@tromey.com>
4856
4857         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4858         declare.
4859         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4860         Rename from tui_first_data_item_displayed.  Update.
4861         (tui_data_window::refresh_all)
4862         (tui_data_window::do_scroll_vertical): Update.
4863         * tui/tui-data.h (struct tui_data_window)
4864         <first_data_item_displayed>: Declare new method.
4865
4866 2019-06-25  Tom Tromey  <tom@tromey.com>
4867
4868         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4869         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4870         contents...
4871         (tui_initialize_static_data): ...here.
4872
4873 2019-06-25  Tom Tromey  <tom@tromey.com>
4874
4875         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4876         (tui_display_registers_from, tui_check_register_values): Update.
4877         (tui_display_register): Remove win_info parameter; update.
4878         (tui_get_register): Change type of parameters.
4879         * tui/tui-data.h (struct tui_data_element): Remove.
4880         (union tui_which_element) <data>: Remove.
4881         <data_window>: Change type.
4882         (struct tui_data_item_window): New.
4883         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4884         case.  Add assert.
4885         (~tui_data_item_window): New destructor.
4886         (free_content_elements): Remove DATA_ITEM_WIN case.
4887
4888 2019-06-25  Tom Tromey  <tom@tromey.com>
4889
4890         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4891         Remove.
4892
4893 2019-06-25  Tom Tromey  <tom@tromey.com>
4894
4895         * tui/tui-data.h (struct tui_command_element): Remove.
4896         (union tui_which_element) <command>: Remove.
4897         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4898         assert.
4899         (free_content_elements): Remove CMD_WIN case.
4900
4901 2019-06-25  Tom Tromey  <tom@tromey.com>
4902
4903         * tui/tui-layout.c (tui_set_layout): Update.
4904         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4905         * tui/tui-data.c (layout_def): Update.
4906
4907 2019-06-25  Tom Tromey  <tom@tromey.com>
4908
4909         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4910         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4911         (tui_source_window_base::set_new_height): Update.
4912         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4913         Update.
4914         (tui_set_locator_fullname, tui_set_locator_info)
4915         (tui_show_frame_info): Update.
4916         * tui/tui-source.c (tui_set_source_content)
4917         (tui_source_is_displayed): Update.
4918         * tui/tui-layout.c (show_source_disasm_command, show_data)
4919         (show_source_or_disasm_and_command): Update.
4920         * tui/tui-disasm.c (tui_set_disassem_content)
4921         (tui_get_begin_asm_address): Update.
4922         * tui/tui-data.h (struct tui_locator_element): Remove.
4923         (union tui_which_element) <locator>: Remove.
4924         (struct tui_locator_window): New.
4925         (tui_locator_win_info_ptr): Change return type.
4926         * tui/tui-data.c (_locator): Change type.
4927         (tui_locator_win_info_ptr): Change return type.
4928         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4929         (tui_alloc_content): Add assert.
4930
4931 2019-06-25  Tom Tromey  <tom@tromey.com>
4932
4933         * tui/tui-winsource.c
4934         (tui_exec_info_window::maybe_allocate_content): New method.
4935         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4936         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4937         (make_source_or_disasm_window): Add cast.
4938         * tui/tui-data.h (union tui_which_element) <simple_string>:
4939         Remove.
4940         (struct tui_source_info): New.
4941         (struct tui_source_window_base) <execution_info>: Change type.
4942         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4943         case, and add assert.
4944         (tui_alloc_content): Add assert.
4945
4946 2019-06-25  Tom Tromey  <tom@tromey.com>
4947
4948         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4949         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4950         * tui/tui-data.c (tui_alloc_win_info): Remove.
4951
4952 2019-06-25  Tom Tromey  <tom@tromey.com>
4953
4954         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4955         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4956         can_highlight.
4957
4958 2019-06-25  Tom Tromey  <tom@tromey.com>
4959
4960         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4961         make_visible_with_new_height method.
4962         (tui_win_info::make_visible_with_new_height): New method.
4963         (tui_source_window_base::do_make_visible_with_new_height)
4964         (tui_data_window::do_make_visible_with_new_height)
4965         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4966         (make_visible_with_new_height): Remove.
4967         (tui_resize_all, tui_adjust_win_heights): Use
4968         make_visible_with_new_height method.
4969         * tui/tui-data.h (struct tui_win_info)
4970         <do_make_visible_with_new_height, make_visible_with_new_height>:
4971         New methods.
4972         (struct tui_source_window_base, struct tui_data_window)
4973         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4974         methods.
4975
4976 2019-06-25  Tom Tromey  <tom@tromey.com>
4977
4978         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4979         method.
4980         (update_tab_width): Call update_tab_width method.
4981         * tui/tui-data.h (struct tui_win_info)
4982         (struct tui_source_window_base) <update_tab_width>: New methods.
4983
4984 2019-06-25  Tom Tromey  <tom@tromey.com>
4985
4986         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4987         parameter.
4988         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4989         parameter.
4990         (tui_gen_win_info::make_visible): Update.
4991         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4992         parameter.
4993         * tui/tui-data.h (enum tui_box): New enum.
4994         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4995
4996 2019-06-25  Tom Tromey  <tom@tromey.com>
4997
4998         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4999         init_and_make_win for EXEC_INFO_WIN.
5000         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5001         longer inline.
5002         (struct tui_win_info) <~tui_win_info>: Inline.
5003         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5004         Don't declare.
5005         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5006         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5007         Remove.
5008         (tui_initialize_static_data): Update.
5009         (~tui_gen_win_info): Handle more cleanup here.
5010         (~tui_source_window_base): Delete "execution_info".
5011         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5012
5013 2019-06-25  Tom Tromey  <tom@tromey.com>
5014
5015         * tui/tui-layout.c (make_command_window): Don't set
5016         can_highlight.
5017         (show_source_disasm_command): Call the reset method.
5018         (show_data): Don't set can_highlight.  Call the reset method.
5019         (tui_gen_win_info::reset): Rename from init_gen_win_info
5020         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5021         (show_source_or_disasm_and_command): Call the reset method.
5022         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5023         (struct tui_cmd_window): Set can_highlight.
5024
5025 2019-06-25  Tom Tromey  <tom@tromey.com>
5026
5027         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5028         from make_visible.
5029         (tui_make_visible, tui_make_invisible): Rewrite.
5030         (tui_win_info::make_visible): Remove.
5031         (tui_source_window_base::make_visible): Update.
5032         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5033         method.  Moved from...
5034         (struct tui_win_info) <make_visible>: ...here.
5035
5036 2019-06-25  Tom Tromey  <tom@tromey.com>
5037
5038         * tui/tui-winsource.c
5039         (tui_source_window_base::do_scroll_horizontal): Remove direction
5040         parameter.
5041         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5042         direction parameter.
5043         * tui/tui-win.c (tui_win_info::forward_scroll)
5044         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5045         (tui_win_info::right_scroll): Update.
5046         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5047         direction parameter.
5048         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5049         direction parameter.
5050         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5051         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5052         Remove direction parameter.
5053         (struct tui_source_window_base, struct tui_source_window)
5054         (struct tui_disasm_window, struct tui_data_window)
5055         (struct tui_cmd_window): Update.
5056
5057 2019-06-25  Tom Tromey  <tom@tromey.com>
5058
5059         * tui/tui-winsource.h (tui_set_exec_info_content)
5060         (tui_show_exec_info_content, tui_erase_exec_info_content)
5061         (tui_clear_exec_info_content, tui_update_exec_info): Change
5062         argument to tui_source_window_base.
5063         * tui/tui-winsource.c (tui_set_exec_info_content)
5064         (tui_show_exec_info_content, tui_erase_exec_info_content)
5065         (tui_clear_exec_info_content, tui_update_exec_info): Change
5066         argument to tui_source_window_base.
5067
5068 2019-06-25  Tom Tromey  <tom@tromey.com>
5069
5070         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5071         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5072
5073 2019-06-25  Tom Tromey  <tom@tromey.com>
5074
5075         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5076         check.
5077
5078 2019-06-25  Tom Tromey  <tom@tromey.com>
5079
5080         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5081         type to void.
5082         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5083         type to void.
5084         * tui/tui-source.c (tui_set_source_content): Update.
5085         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5086
5087 2019-06-25  Tom Tromey  <tom@tromey.com>
5088
5089         * tui/tui-win.c (window_name_completer, tui_set_focus)
5090         (tui_all_windows_info): Use name method.
5091         * tui/tui-data.h (struct tui_gen_win_info)
5092         (struct tui_source_window, struct tui_disasm_window)
5093         (struct tui_data_window, struct tui_cmd_window) <name>: New
5094         method.
5095         (tui_win_name): Don't declare.
5096         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5097         (tui_win_name): Remove.
5098
5099 2019-06-25  Tom Tromey  <tom@tromey.com>
5100
5101         * tui/tui-winsource.h (tui_update_source_window)
5102         (tui_update_source_window_as_is): Change parameter type.
5103         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5104         to be a tui_source_window_base.
5105         (tui_update_source_window_as_is): Likewise.
5106         * tui/tui-win.c (make_visible_with_new_height): Update.
5107
5108 2019-06-25  Tom Tromey  <tom@tromey.com>
5109
5110         * tui/tui-winsource.c (tui_erase_source_content)
5111         (tui_show_source_content, tui_show_exec_info_content)
5112         (tui_erase_exec_info_content): Use refresh_window method.
5113         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5114         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5115         from tui_refresh_win.
5116         (tui_data_window::refresh_window): New method.
5117         (tui_win_info::refresh, tui_source_window_base::refresh)
5118         (tui_refresh_all): Use refresh_window method.
5119         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5120         method.
5121         * tui/tui-regs.c (tui_display_register): Call refresh_window
5122         method.
5123         * tui/tui-layout.c (show_source_disasm_command)
5124         (show_source_or_disasm_and_command): Call refresh_window method.
5125         * tui/tui-data.h (struct tui_gen_win_info)
5126         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5127         New method.
5128
5129 2019-06-25  Tom Tromey  <tom@tromey.com>
5130
5131         * tui/tui.c (tui_rl_other_window, tui_enable)
5132         (tui_is_window_visible, tui_get_command_dimension): Update.
5133         * tui/tui-winsource.c (tui_update_source_window_as_is)
5134         (tui_clear_source_content, tui_erase_source_content)
5135         (tui_show_source_line, tui_source_window_base::refill)
5136         (tui_source_window_base::do_scroll_horizontal)
5137         (tui_source_window_base::set_is_exec_point_at)
5138         (tui_update_breakpoint_info, tui_set_exec_info_content)
5139         (tui_alloc_source_buffer, tui_line_is_displayed)
5140         (tui_addr_is_displayed): Update.
5141         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5142         (tui_check_and_display_highlight_if_needed)
5143         (tui_win_info::make_visible, tui_win_info::refresh)
5144         (tui_refresh_all): Update.
5145         * tui/tui-windata.c (tui_first_data_item_displayed)
5146         (tui_delete_data_content_windows, tui_erase_data_content)
5147         (tui_display_all_data, tui_data_window::refresh_all)
5148         (tui_check_data_values): Update.
5149         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5150         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5151         (tui_win_info::backward_scroll, tui_refresh_all_win)
5152         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5153         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5154         (tui_source_window_base::set_new_height)
5155         (tui_data_window::set_new_height)
5156         (make_invisible_and_set_new_height)
5157         (make_visible_with_new_height, new_height_ok)
5158         (parse_scrolling_args): Update.
5159         * tui/tui-stack.c (tui_show_frame_info): Update.
5160         * tui/tui-source.c (tui_set_source_content)
5161         (tui_set_source_content_nil, tui_source_is_displayed)
5162         (tui_source_window::do_scroll_vertical): Update.
5163         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5164         (tui_display_registers_from, tui_display_reg_element_at_line)
5165         (tui_check_register_values, tui_reg_command): Update.
5166         * tui/tui-layout.c (tui_default_win_height)
5167         (show_source_disasm_command, show_data, init_and_make_win)
5168         (show_source_or_disasm_and_command): Update.
5169         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5170         (tui_redisplay_readline, tui_mld_flush)
5171         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5172         (tui_getc): Update.
5173         * tui/tui-disasm.c (tui_set_disassem_content)
5174         (tui_disasm_window::do_scroll_vertical): Update.
5175         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5176         Now virtual.
5177         (struct tui_win_info): Derive from tui_gen_win_info.
5178         <~tui_win_info>: Mark as override.
5179         <generic>: Remove member.
5180         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5181         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5182         (~tui_data_window, ~tui_win_info)
5183         (tui_free_all_source_wins_content): Update.
5184         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5185
5186 2019-06-25  Tom Tromey  <tom@tromey.com>
5187
5188         * tui/tui-layout.c (init_and_make_win): Use new.
5189         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5190         destructor, initializers.
5191         (tui_alloc_generic_win_info): Don't declare.
5192         * tui/tui-data.c (_locator): Add argument to constructor.
5193         (source_win, disasm_win): New globals.
5194         (exec_info): Remove.
5195         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5196         Update.
5197         (tui_alloc_generic_win_info): Remove.
5198         (init_content_element): Use new.
5199         (tui_win_info::tui_win_info): Update.
5200         (free_content_elements) <case DATA_WIN>: Use delete.
5201
5202 2019-06-25  Tom Tromey  <tom@tromey.com>
5203
5204         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5205         * tui/tui-windata.c (tui_first_data_item_displayed)
5206         (tui_delete_data_content_windows): Update.
5207         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5208         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5209         (tui_display_registers_from, tui_check_register_values): Update.
5210         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5211         pointer.
5212         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5213         window.
5214         (tui_free_data_content): Update.
5215         (free_content_elements) <case DATA_WIN>: Free the window.
5216
5217 2019-06-25  Tom Tromey  <tom@tromey.com>
5218
5219         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5220         Update.
5221         * tui/tui-layout.c (make_command_window)
5222         (show_source_disasm_command, show_data, init_and_make_win)
5223         (show_source_or_disasm_and_command): Update.
5224         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5225         method.
5226         <can_highight, is_highlighted>: Now bool.
5227         (tui_set_win_highlight): Don't declare.
5228         * tui/tui-data.c (tui_set_win_highlight): Remove.
5229
5230 2019-06-25  Tom Tromey  <tom@tromey.com>
5231
5232         * tui/tui-wingeneral.c (make_visible): Remove check of window
5233         type.
5234
5235 2019-06-25  Tom Tromey  <tom@tromey.com>
5236
5237         * tui/tui-win.c (tui_win_info::max_height)
5238         (tui_cmd_window::max_height): New methods.
5239         (new_height_ok): Call max_height.
5240         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5241         <max_height>: New method.
5242
5243 2019-06-25  Tom Tromey  <tom@tromey.com>
5244
5245         * tui/tui-win.c (tui_source_window_base::set_new_height)
5246         (tui_data_window::set_new_height): New methods.
5247         (make_invisible_and_set_new_height): Call set_new_height method.
5248         * tui/tui-data.h (struct tui_win_info)
5249         (struct tui_source_window_base, struct tui_data_window)
5250         <set_new_height>: New method.
5251
5252 2019-06-25  Tom Tromey  <tom@tromey.com>
5253
5254         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5255         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5256         tui_refresh_data_win.
5257         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5258         method.
5259         (tui_refresh_all_win): Call the refresh_all method.
5260         (tui_set_focus): Likewise.
5261         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5262         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5263         Likewise.
5264
5265 2019-06-25  Tom Tromey  <tom@tromey.com>
5266
5267         * tui/tui-winsource.h (tui_refill_source_window)
5268         (tui_set_is_exec_point_at): Don't declare.
5269         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5270         (tui_source_window_base::refill): Rename from
5271         tui_refill_source_window.
5272         (tui_source_window_base::do_scroll_horizontal): Update.
5273         (tui_source_window_base::set_is_exec_point_at): Rename from
5274         tui_set_is_exec_point_at.
5275         (tui_update_all_breakpoint_info): Update.
5276         * tui/tui-stack.c (tui_show_frame_info): Update.
5277         * tui/tui-layout.c (show_data): Add cast.
5278         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5279         * tui/tui-data.h (struct tui_source_window_base) <refill,
5280         set_is_exec_point_at>: New methods.
5281         (tui_source_windows, tui_add_to_source_windows): Update types.
5282         (tui_add_to_source_windows): Remove redundant declaration.
5283         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5284         (tui_source_windows): Change return type.
5285         (tui_clear_source_windows_detail): Update.
5286         (tui_add_to_source_windows): Change type of parameter.
5287         (tui_free_all_source_wins_content): Update.
5288
5289 2019-06-25  Tom Tromey  <tom@tromey.com>
5290
5291         * tui/tui-wingeneral.c (tui_win_info::refresh)
5292         (tui_source_window_base::refresh): New methods.
5293         (tui_refresh_all): Call the refresh method.
5294         * tui/tui-data.h (struct tui_win_info)
5295         (struct tui_source_window_base) <refresh>: New method.
5296
5297 2019-06-25  Tom Tromey  <tom@tromey.com>
5298
5299         * tui/tui.h (tui_is_window_visible): Return bool.
5300         * tui/tui.c (tui_is_window_visible): Return bool.
5301         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5302         (tui_make_visible, tui_make_invisible)
5303         (tui_win_info::make_visible)
5304         (tui_source_window_base::make_visible, make_all_visible)
5305         (tui_make_all_visible, tui_make_all_invisible): Update.
5306         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5307         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5308         bool.
5309         (struct tui_win_info, struct tui_source_window_base)
5310         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5311         * tui/tui-data.c (tui_init_generic_part): Update.
5312
5313 2019-06-25  Tom Tromey  <tom@tromey.com>
5314
5315         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5316         (tui_source_window_base::make_visible): New methods.
5317         (make_all_visible): Make method call.
5318         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5319         (struct tui_source_window_base, struct tui_cmd_window): Override
5320         make_visible.
5321         (tui_win_is_source_type): Don't declare.
5322         * tui/tui-data.c (tui_win_is_source_type): Remove.
5323
5324 2019-06-25  Tom Tromey  <tom@tromey.com>
5325
5326         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5327         NULL check.
5328
5329 2019-06-25  Tom Tromey  <tom@tromey.com>
5330
5331         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5332         Inline constructor.  Add initializers for members.
5333         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5334         constructors; now inline in class.
5335
5336 2019-06-25  Tom Tromey  <tom@tromey.com>
5337
5338         * tui/tui-regs.c (tui_show_registers): Update.
5339         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5340         bool.
5341         * tui/tui-data.c (tui_data_window::clear_detail)
5342         (tui_data_window): Update.
5343
5344 2019-06-25  Tom Tromey  <tom@tromey.com>
5345
5346         * tui/tui-windata.c (tui_display_all_data)
5347         (tui_display_data_from_line, tui_display_data_from)
5348         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5349         Update.
5350         * tui/tui-regs.c (tui_last_regs_line_no)
5351         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5352         (tui_show_registers, tui_show_register_group)
5353         (tui_display_registers_from, tui_display_reg_element_at_line)
5354         (tui_display_registers_from_line, tui_check_register_values)
5355         (tui_reg_next, tui_reg_prev): Update.
5356         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5357         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5358         tui_data_window.
5359         (struct tui_win_info) <detail>: Remove.  Add new fields from
5360         tui_data_info.
5361         (TUI_DATA_WIN): Add cast.
5362         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5363         (~tui_data_window): Simplify.
5364
5365 2019-06-25  Tom Tromey  <tom@tromey.com>
5366
5367         * tui/tui-layout.c (show_source_disasm_command)
5368         (show_source_or_disasm_and_command): Update.
5369         * tui/tui-io.c (update_cmdwin_start_line)
5370         (tui_redisplay_readline): Update.
5371         * tui/tui-data.h (struct tui_command_info): Remove.
5372         (struct tui_win_info) <detail>: Remove command_info member.
5373         (struct tui_data_window) <start_line>: New member, from
5374         tui_command_info.
5375         (TUI_CMD_WIN): Add casts.
5376
5377 2019-06-25  Tom Tromey  <tom@tromey.com>
5378
5379         * tui/tui-winsource.c (tui_update_source_window)
5380         (tui_refill_source_window)
5381         (tui_source_window_base::do_scroll_horizontal)
5382         (tui_update_breakpoint_info, tui_set_exec_info_content)
5383         (tui_show_exec_info_content, tui_erase_exec_info_content)
5384         (tui_clear_exec_info_content): Update.
5385         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5386         Update.
5387         * tui/tui-win.c (make_invisible_and_set_new_height)
5388         (make_visible_with_new_height): Update.
5389         * tui/tui-source.c (tui_set_source_content)
5390         (tui_show_symtab_source): Update.
5391         * tui/tui-layout.c (extract_display_start_addr)
5392         (show_source_disasm_command, show_data)
5393         (make_source_or_disasm_window)
5394         (show_source_or_disasm_and_command): Update.
5395         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5396         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5397         "gdbarch".
5398         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5399         to tui_source_window_base.
5400         (struct tui_win_info) <detail>: Remove source_info member.
5401         (struct tui_source_window_base) <has_locator>: Inline.
5402         Move contents from tui_source_info; rename has_locator member to
5403         m_has_locator.
5404         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5405         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5406         header file.
5407         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5408         Simplify.
5409         (tui_free_all_source_wins_content): Cast to
5410         tui_source_window_base.
5411
5412 2019-06-25  Tom Tromey  <tom@tromey.com>
5413
5414         * tui/tui-win.c (make_invisible_and_set_new_height)
5415         (make_visible_with_new_height): Call has_locator method.
5416         * tui/tui-layout.c (show_source_disasm_command, show_data)
5417         (show_source_or_disasm_and_command): Update for bool change.
5418         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5419         (tui_win_info) <has_locator>: New method.
5420         (struct tui_source_window_base) <has_locator>: New method.
5421         (tui_win_has_locator): Don't declare.
5422         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5423         from tui_win_has_locator.
5424         (tui_source_window_base): Use false, not FALSE.
5425
5426 2019-06-25  Tom Tromey  <tom@tromey.com>
5427
5428         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5429         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5430         clear_detail method directly.
5431         (tui_clear_win_detail): Remove.
5432
5433 2019-06-25  Tom Tromey  <tom@tromey.com>
5434
5435         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5436         "this", not TUI_DISASM_WIN.
5437
5438 2019-06-25  Tom Tromey  <tom@tromey.com>
5439
5440         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5441         declare.
5442         * tui/tui-winsource.c
5443         (tui_source_window_base::do_scroll_horizontal): Rename from
5444         tui_horizontal_source_scroll.
5445         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5446         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5447         from tui_vertical_data_scroll.
5448         * tui/tui-win.h (tui_scroll): Don't declare.
5449         * tui/tui-win.c (tui_win_info::forward_scroll)
5450         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5451         (tui_win_info::right_scroll): Rename and update.
5452         (tui_scroll_forward_command, tui_scroll_backward_command)
5453         (tui_scroll_left_command, tui_scroll_right_command): Update.
5454         (tui_scroll): Remove.
5455         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5456         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5457         from tui_vertical_source_scroll.
5458         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5459         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5460         from tui_vertical_disassem_scroll.
5461         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5462         do_scroll_horizontal>: New methods.
5463         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5464         Likewise.
5465         (struct tui_source_window_base): Add do_scroll_horizontal.
5466         (struct tui_source_window, struct tui_disasm_window): Add
5467         do_scroll_vertical.
5468         (struct tui_data_window, struct tui_cmd_window): Add
5469         do_scroll_horizontal and do_scroll_vertical.
5470         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5471
5472 2019-06-25  Tom Tromey  <tom@tromey.com>
5473
5474         * tui/tui-data.h (struct tui_source_window_base): New struct.
5475         (struct tui_source_window): Derive from tui_source_window_base.
5476         (struct tui_disasm_window): New struct.
5477         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5478         from tui_source_window::clear_detail.
5479         (tui_source_window_base): Rename from tui_source_window.
5480         (~tui_source_window_base): Rename from ~tui_source_window.
5481         (tui_alloc_win_info): Create a tui_disasm_window.
5482
5483 2019-06-25  Tom Tromey  <tom@tromey.com>
5484
5485         * tui/tui-data.h (struct tui_source_window)
5486         (struct tui_data_window): Declare destructors.
5487         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5488         destructors.
5489         (tui_win_info): Simplify.
5490
5491 2019-06-25  Tom Tromey  <tom@tromey.com>
5492
5493         * tui/tui-winsource.c (tui_display_main)
5494         (tui_update_source_windows_with_addr)
5495         (tui_update_all_breakpoint_info): Update.
5496         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5497         (new_height_ok, parse_scrolling_args): Update.
5498         * tui/tui-stack.c (tui_show_frame_info): Update.
5499         * tui/tui-data.h (struct tui_list): Remove.
5500         (tui_source_windows): Return a reference to a std::vector.
5501         * tui/tui-data.c (source_windows): Now a std::vector.
5502         (tui_source_windows): Change return type.
5503         (tui_clear_source_windows): Rewrite.
5504         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5505         (tui_free_all_source_wins_content): Rewrite.
5506
5507 2019-06-25  Tom Tromey  <tom@tromey.com>
5508
5509         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5510         (struct tui_data_window, struct tui_cmd_window): Declare
5511         clear_detail method.
5512         * tui/tui-data.c (tui_source_window::clear_detail)
5513         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5514         methods.
5515         (tui_clear_win_detail): Simplify.
5516
5517 2019-06-25  Tom Tromey  <tom@tromey.com>
5518
5519         * tui/tui-layout.c (make_source_window, make_disasm_window)
5520         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5521         Return the new window.
5522         (show_source_disasm_command, show_data)
5523         (show_source_or_disasm_and_command): Update.
5524
5525 2019-06-25  Tom Tromey  <tom@tromey.com>
5526
5527         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5528         parameter.  Return the new window.
5529         (show_source_disasm_command): Update and remove NULL check.
5530         (show_source_or_disasm_and_command): Update.
5531
5532 2019-06-25  Tom Tromey  <tom@tromey.com>
5533
5534         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5535
5536 2019-06-25  Tom Tromey  <tom@tromey.com>
5537
5538         * tui/tui-data.h (struct tui_win_info): Make constructor
5539         protected.  Make destructor virtual.  Add initializers.
5540         (tui_source_window, tui_data_window, tui_cmd_window): New
5541         classes.
5542         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5543         constructor.  Add "type" parameter.
5544         (tui_source_window, tui_data_window, tui_cmd_window): New
5545         constructors.
5546         (tui_alloc_win_info): Instantiate the appropriate subclass.
5547
5548 2019-06-25  Tom Tromey  <tom@tromey.com>
5549
5550         * tui/tui-win.c (tui_resize_all): Use delete.
5551         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5552         destructor.
5553         (tui_free_window): Don't declare.
5554         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5555         Update.
5556
5557 2019-06-25  Tom Tromey  <tom@tromey.com>
5558
5559         * tui/tui-data.h (struct tui_win_info): Add constructor.
5560         * tui/tui-data.c (tui_alloc_win_info): Use new.
5561         (tui_free_window): Use delete.
5562
5563 2019-06-22  Tom Tromey  <tom@tromey.com>
5564
5565         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5566         declare.
5567         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5568
5569 2019-06-22  Tom Tromey  <tom@tromey.com>
5570
5571         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5572         declare.
5573         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5574
5575 2019-06-22  Tom de Vries  <tdevries@suse.de>
5576
5577         * dwarf2read.c (create_addrmap_from_aranges)
5578         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5579         instead of '%zu'.
5580
5581 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5582
5583         * dwarf2read.h (dwarf2_section_info_def): Remove.
5584         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5585         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5586         std::vector<dwarf2_section_info>.
5587         (struct dwo_file) <~dwo_file>: Remove.
5588         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5589         types field.
5590         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5591         (dwarf2_read_debug_names): Likewise.
5592         (create_debug_types_hash_table): Change parameter type to
5593         array_view, adjust code accordingly.
5594         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5595         (partial_die_info::fixup): Likewise.
5596         (determine_prefix): Likewise.
5597         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5598
5599 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5600
5601         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5602         gdb_bfd_ref_ptr.
5603         <~dwo_file>: Remove call to gdb_bfd_unref.
5604         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5605         gdb_bfd_ref_ptr::get.
5606
5607 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5608
5609         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5610         type to htab_up.
5611         * dwarf2read.c (struct dwo_file): Initialize fields.
5612         <~dwo_file>: New.
5613         (free_dwo_file): Remove, move content to ~dwo_file.
5614         (struct dwo_file_deleter): Remove.
5615         (dwo_file_up>: Remove custom deleter.
5616         (free_dwo_files): Remove.
5617         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5618         dwo_files.
5619         (process_skeletonless_type_units): Call unique_ptr::get.
5620         (allocate_dwo_file_hash_table): Add deleter to created hash
5621         table.  Change return type to htab_up.
5622         (lookup_dwo_file_slot): Don't memset dwo_file, call
5623         unique_ptr::get.
5624         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5625         (create_dwo_unit_in_dwp_v2): Likewise.
5626         (open_and_init_dwo_file): Likewise.
5627         (free_dwo_file_from_slot): Remove.
5628
5629 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5630
5631         * dwarf2read.h (struct dwarf2_section_info) <readin,
5632         is_virtual>: Change type to bool.
5633         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5634         true instead of 1.
5635
5636 2019-06-19  Tom Tromey  <tom@tromey.com>
5637
5638         * tui/tui-data.h (tui_init_content_element): Don't declare.
5639
5640 2019-06-19  Tom Tromey  <tom@tromey.com>
5641
5642         * tui/tui-data.h (tui_init_win_info): Don't declare.
5643
5644 2019-06-19  Tom de Vries  <tdevries@suse.de>
5645
5646         * dwarf2read.h (abstract_to_concrete): Change type to
5647         std::unordered_map<sect_offset, std::vector<sect_offset>,
5648         gdb::hash_enum<sect_offset>>.
5649
5650 2019-06-19  Tom Tromey  <tromey@adacore.com>
5651
5652         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5653         EVAL_AVOID_SIDE_EFFECTS specially.
5654
5655 2019-06-19  Tom Tromey  <tromey@adacore.com>
5656
5657         * source-cache.c (highlighter): New global.
5658         (source_cache::get_source_lines): Create a highlighter on demand.
5659
5660 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5661
5662         * defs.h (deprecated_interactive_hook): Delete declaration.
5663         * interps.c (clear_interpreter_hooks): Remove use of
5664         deprecated_interactive_hook.
5665         * top.c (deprecated_interactive_hook): Delete definition.
5666         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5667
5668 2019-06-18  Tom de Vries  <tdevries@suse.de>
5669
5670         PR gdb/24515
5671         * dwarf2read.h (abstract_to_concrete): Change type from
5672         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5673         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5674         * dwarf2read.c (read_variable): Update.
5675         (dwarf2_fetch_die_loc_sect_off): Update.
5676
5677 2019-06-17  Tom de Vries  <tdevries@suse.de>
5678
5679         PR gdb/24617
5680         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5681         accessing parent[parent_len - 1].
5682
5683 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5684
5685         PR gdb/24364
5686         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5687         call dtrace_process_dof with NULL dof.
5688
5689 2019-06-16  Tom de Vries  <tdevries@suse.de>
5690
5691         PR gdb/24445
5692         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5693
5694 2019-06-16  Tom Tromey  <tom@tromey.com>
5695
5696         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5697         (make_all_visible): Use address of member.
5698
5699 2019-06-16  Tom Tromey  <tom@tromey.com>
5700
5701         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5702         (tui_free_window, free_content, free_content_elements): Remove
5703         unnecessary cast.
5704         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5705         cast.
5706         * tui/tui-regs.c (tui_show_register_group)
5707         (tui_display_registers_from, tui_display_reg_element_at_line):
5708         Remove unnecessary cast.
5709
5710 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5711
5712         * linux-nat.c (normal_mask): Delete.
5713         (_initialize_linux_nat): Don't initialise normal_mask.
5714
5715 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5716
5717         PR gdb/24445
5718         * dwarf-index-write.h (write_psymtabs_to_index): Add
5719         dwz_basename parameter.
5720         * dwarf-index-write.c (write_gdbindex): Move file writing to
5721         write_gdbindex_1.  Change return type void.
5722         (assert_file_size): Move up, remove filename parameter.
5723         (write_gdbindex_1): New function.
5724         (write_debug_names): Change return type to void, call
5725         assert_file_size.
5726         (struct index_wip_file): New struct.
5727         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5728         file logic to index_wip_file.  Write index for dwz file if
5729         needed.
5730         (save_gdb_index_command): Pass basename of dwz file, if present.
5731         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5732         build-id of dwz file, if present.
5733         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5734         (dwarf2_get_dwz_file): Likewise.
5735         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5736         (dwarf2_get_dwz_file): Likewise.
5737
5738 2019-06-16  Tom Tromey  <tom@tromey.com>
5739
5740         * coffread.c (process_coff_symbol): Use xstrdup.
5741         * value.c (create_internalvar): Use xstrdup.
5742
5743 2019-06-16  Tom Tromey  <tom@tromey.com>
5744
5745         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5746         * breakpoint.c (stopin_command, stopat_command)
5747         (until_break_command, decode_location_default): Remove unnecessary
5748         cast.
5749         * utils.c (subset_compare): Remove unnecessary cast.
5750         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5751         cast.
5752         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5753         cast.
5754         * infcmd.c (path_command): Remove unnecessary cast.
5755         * coffread.c (decode_type): Remove unnecessary cast.
5756         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5757         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5758         * tui/tui-stack.c (tui_show_locator_content)
5759         (tui_show_frame_info): Remove unnecessary cast.
5760         * tui/tui-win.c (tui_scroll_forward_command)
5761         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5762         (parse_scrolling_args): Remove unnecessary cast.
5763         * tui/tui-data.c (init_win_info, tui_del_window)
5764         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5765         (free_content_elements): Remove unnecessary cast.
5766         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5767         unnecessary cast.
5768         * tui/tui-source.c (tui_set_source_content)
5769         (tui_vertical_source_scroll): Remove unnecessary cast.
5770         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5771         cast.
5772         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5773         * tui/tui-regs.c (tui_display_registers_from)
5774         (tui_display_register): Remove unnecessary cast.
5775         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5776         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5777         (make_visible): Remove unnecessary cast.
5778         * tui/tui-winsource.c (tui_erase_source_content)
5779         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5780         unnecessary cast.
5781         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5782         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5783         * stabsread.c (read_type, read_array_type, read_range_type):
5784         Remove unnecessary cast.
5785         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5786         (parse_symbol, parse_type, upgrade_type, parse_external)
5787         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5788         unnecessary cast.
5789         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5790
5791 2019-06-16  Tom Tromey  <tom@tromey.com>
5792
5793         * tui/tui-data.c (tui_alloc_generic_win_info)
5794         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5795         checks.
5796
5797 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5798             Andrew Burgess  <andrew.burgess@embecosm.com>
5799
5800         * f-typeprint.c (f_print_type): Don't return early for not
5801         associated or not allocated types.
5802         (f_type_print_varspec_suffix): Add print_rank parameter and print
5803         ranks of array types in case they dangling.
5804         (f_type_print_base): Add print_rank parameter.
5805
5806 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5807
5808         * NEWS: Mention new MI commands.
5809         * break-catch-throw.c (enum exception_event_kind): Move to
5810         breakpoint.h.
5811         (print_mention_exception_catchpoint): Output text as a single
5812         message.
5813         (catch_exception_command_1): Rename to...
5814         (catch_exception_event): ...this, make non-static, update header
5815         command, and change some parameter types.
5816         (catch_catch_command): Update for changes to
5817         catch_exception_command_1.
5818         (catch_throw_command): Likewise.
5819         (catch_rethrow_command): Likewise.
5820         * breakpoint.c (enum exception_event_kind): Delete.
5821         * breakpoint.h (enum exception_event_kind): Moved here from
5822         break-catch-throw.c.
5823         (catch_exception_event): Declare.
5824         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5825         (mi_cmd_catch_throw): New function.
5826         (mi_cmd_catch_rethrow): New function.
5827         (mi_cmd_catch_catch): New function.
5828         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5829         'catch-catch' entries.
5830         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5831         (mi_cmd_catch_rethrow): Declare.
5832         (mi_cmd_catch_catch): Declare.
5833
5834 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5835
5836         * annotate.c (annotate_source_line): Change return type to void,
5837         update implementation to match.
5838         * annotate.h (annotate_source_line): Change return type to void,
5839         update header comment.
5840         * stack.c (print_frame_info): Don't change what frame information
5841         is printed based on whether annotations are on or not.
5842
5843 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5844
5845         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5846         (annotate_source): Make static.
5847         (annotate_source_line): Moved from source.c and renamed from
5848         identify_source_line.  Update the return type.
5849         * annotate.h (annotate_source): Delete declaration.
5850         (annotate_source_line): Declaration moved from source.h, and
5851         renamed from identify_source_line.  Return type updated.
5852         * source.c (identify_source_line): Moved to annotate.c and renamed
5853         to annotate_source_line.
5854         (info_line_command): Remove check of annotation_level.
5855         * source.h (identify_source_line): Move declaration to annotate.h
5856         and rename to annotate_source_line.
5857         * stack.c: Add 'annotate.h' include.
5858         (print_frame_info): Remove check of annotation_level before
5859         calling annotate_source_line.
5860
5861 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5862
5863         * source-cache.c (source_cache::get_plain_source_lines): Use
5864         open_source_file_with_line_charpos instead of just
5865         open_source_file, remove call to find_source_lines.
5866         (source_cache::get_source_lines): Likewise.
5867         * source.c (find_source_lines): Make static.
5868         (get_filename_and_charpos): Renamed into...
5869         (open_source_file_with_line_charpos): ..this along with changes to
5870         return a scoped_fd, and some other minor clean ups.
5871         (identify_source_line): Use open_source_file_with_line_charpos.
5872         (search_command_helper): Use open_source_file_with_line_charpos
5873         instead of just open_source_file, remove call to
5874         find_source_lines.
5875         * source.h (open_source_file_with_line_charpos): Declare new
5876         function.
5877         (find_source_lines): Delete declaration.
5878
5879 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5880
5881         * source.c (get_filename_and_charpos): Remove fullname
5882         parameter.
5883         (identify_source_line): Update call to get_filename_and_charpos.
5884
5885 2019-06-14  Tom Tromey  <tromey@adacore.com>
5886
5887         PR gdb/24502:
5888         * ui-style.h (skip_ansi_escape): Update comment.
5889         * ui-file.h (class no_terminal_escape_file): New class.
5890         * ui-file.c (no_terminal_escape_file::write)
5891         (no_terminal_escape_file::puts): New methods.
5892         * cli/cli-logging.c (handle_redirections): Use
5893         no_terminal_escape_file.
5894
5895 2019-06-14  Tom Tromey  <tromey@adacore.com>
5896
5897         * NEWS: Move convenience variable news above Python news.
5898
5899 2019-06-14  Tom Tromey  <tom@tromey.com>
5900
5901         * gnulib: Move directory to top-level.
5902         * configure.ac: Don't configure gnulib.
5903         * configure: Rebuild.
5904         * common/common-defs.h: Use new path to gnulib.
5905         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5906         (GNULIB_H): Remove.
5907         (INCGNU): Look in new gnulib location.
5908         (HFILES_NO_SRCDIR): Remove gnulib files.
5909         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5910         (generated_files): Remove GNULIB_H.
5911         ($(LIBGNU), all-lib): Remove targets.
5912         (distclean): Don't mention GNULIB_BUILDDIR.
5913         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5914
5915 2019-06-14  Tom Tromey  <tromey@adacore.com>
5916
5917         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5918         Warn if symbol file does not provide any symbols.
5919
5920 2019-06-14  Tom Tromey  <tromey@adacore.com>
5921
5922         * source.c (find_and_open_source): Respect basenames_may_differ.
5923
5924 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5925
5926         * annotate.c (annotate_breakpoints_invalid): Make use of
5927         scoped_restore_terminal_state.
5928         (annotate_frames_invalid): Likewise.
5929
5930 2019-06-14  Tom Tromey  <tromey@adacore.com>
5931
5932         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5933         allow assignment to an internalvar.
5934
5935 2019-06-14  Tom Tromey  <tromey@adacore.com>
5936
5937         * ada-lex.l: Allow "_" in attribute names.
5938
5939 2019-06-14  Tom Tromey  <tromey@adacore.com>
5940
5941         PR gdb/24653:
5942         * regcache.c (registers_changed): Don't call alloca.
5943         * top.c (execute_command): Don't call alloca.
5944
5945 2019-06-13  Pedro Alves  <palves@redhat.com>
5946
5947         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5948         'expression'.  When parsing an expression, error out if there's
5949         junk after "unlimited".
5950         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5951         (do_set_command): Adjust calls to is_unlimited_literal.
5952
5953 2019-06-13  Pedro Alves  <palves@redhat.com>
5954
5955         * compile/compile.c (make_compile_options_def_group): Add braces
5956         around array_view initializer.
5957         * thread.c (make_thread_apply_all_options_def_group)
5958         (make_thread_apply_all_options_def_group): Likewise.
5959
5960 2019-06-13  Pedro Alves  <palves@redhat.com>
5961
5962         * NEWS (New commands): Mention "maint test-options
5963         require-delimiter", "maint test-options unknown-is-error", "maint
5964         test-options unknown-is-operand" and "maint show
5965         test-options-completion-result".
5966         (New command options, command completion): New section.
5967         (Completion improvements): New section.
5968         Mention that you can abbreviate "unlimited".
5969
5970 2019-06-13  Pedro Alves  <palves@redhat.com>
5971
5972         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5973         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5974         * unittests/cli-utils-selftests.c (test_parse_flags)
5975         (test_parse_flags_qcs): Delete.
5976         (test_cli_utils): Don't call deleted functions.
5977
5978 2019-06-13  Pedro Alves  <palves@redhat.com>
5979
5980         * thread.c: Include "cli/cli-option.h".
5981         (tp_array_compar_ascending): Global.
5982         (tp_array_compar): Delete function.
5983         (tp_array_compar_ascending, tp_array_compar_descending): New
5984         functions.
5985         (ascending_option_def, qcs_flag_option_def)
5986         (thr_qcs_flags_option_defs)
5987         (make_thread_apply_all_options_def_group)
5988         (make_thread_apply_options_def_group): New.
5989         (thread_apply_all_command): Use gdb::option::process_options.
5990         (thread_apply_command_completer)
5991         (thread_apply_all_command_completer): New.
5992         (thread_apply_command): Use gdb::option::process_options.
5993         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5994         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5995         to generate help text of "thread apply".  Adjust "taas"'s help.
5996         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5997         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5998
5999 2019-06-13  Pedro Alves  <palves@redhat.com>
6000
6001         * thread.c (thread_apply_command): Check for invalid TID with
6002         isdigit instead of !isalpha.
6003
6004 2019-06-13  Pedro Alves  <palves@redhat.com>
6005
6006         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6007         (validate_flags_qcs): New.
6008         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6009         (validate_flags_qcs): Declare.
6010         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6011         (make_frame_apply_options_def_group): New.
6012         (frame_apply_command_count): Process options with
6013         gdb::option::process_options.
6014         (frame_apply_completer): New.
6015         (frame_apply_level_completer, frame_apply_all_completer)
6016         (frame_apply_completer): New.
6017         (_initialize_stack): Update help of "frame apply", "frame apply
6018         level", "frame apply all" and "faas" to mention supported options
6019         and install command completers.
6020         * stack.h (frame_apply_all_completer): Declare.
6021         * thread.c: Include "stack.h".
6022         (tfaas_command): Add "--".
6023         (_initialize_thread): Update help "tfaas" to mention supported
6024         options and install command completer.
6025
6026 2019-06-13  Pedro Alves  <palves@redhat.com>
6027
6028         * completer.c (complete_nested_command_line): New.
6029         (gdb_completion_word_break_characters_throw): Add assertion.
6030         * completer.h (complete_nested_command_line): Declare.
6031
6032 2019-06-13  Pedro Alves  <palves@redhat.com>
6033
6034         * stack.c (parse_backtrace_qualifiers): New.
6035         (backtrace_command): Use it.
6036         (backtrace_command_completer): Complete on qualifiers.
6037
6038 2019-06-13  Pedro Alves  <palves@redhat.com>
6039
6040         * frame.c: Include "cli/cli-option.h.
6041         (user_set_backtrace_options): New.
6042         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6043         Delete.
6044         (get_prev_frame): Adjust.
6045         (boolean_option_def, uinteger_option_def)
6046         (set_backtrace_option_defs): New.
6047         (_initialize_frame): Adjust and use
6048         gdb::option::add_setshow_cmds_for_options to install "set
6049         backtrace past-main" and "set backtrace past-entry".
6050         * frame.h: Include "cli/cli-option.h".
6051         (struct frame_print_options): Forward declare.
6052         (print_frame_arguments_all, print_frame_arguments_scalars)
6053         (print_frame_arguments_none): Declare.
6054         (print_entry_values): Delete declaration.
6055         (struct frame_print_options, user_frame_print_options): New.
6056         (struct set_backtrace_options): New.
6057         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6058         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6059         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6060         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6061         (list_args_or_locals): Add frame_print_options parameter.
6062         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6063         * python/py-framefilter.c (enumerate_args): Pass down
6064         USER_FRAME_PRINT_OPTIONS.
6065         * stack.c: Include "cli/cli-option.h".
6066         (print_frame_arguments_all, print_frame_arguments_scalars)
6067         (print_frame_arguments_none): Declare.
6068         (print_raw_frame_arguments, print_entry_values): Delete.
6069         (user_frame_print_options): New.
6070         (boolean_option_def, enum_option_def, frame_print_option_defs):
6071         New.
6072         (struct backtrace_cmd_options): New.
6073         (bt_flag_option_def): New.
6074         (backtrace_command_option_defs): New.
6075         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6076         (print_frame_arg, read_frame_arg, print_frame_args)
6077         (print_frame_info, print_frame): Add frame_print_options parameter
6078         and use it.
6079         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6080         (backtrace_command_1): Add frame_print_options and
6081         backtrace_cmd_options parameters and use them.
6082         (make_backtrace_options_def_group): New.
6083         (backtrace_command): Process command options with
6084         gdb::option::process_options.
6085         (backtrace_command_completer): New.
6086         (_initialize_stack): Extend "backtrace"'s help to mention
6087         supported options.  Install completer for "backtrace".
6088         Install some settings commands with add_setshow_cmds_for_options.
6089
6090 2019-06-13  Pedro Alves  <palves@redhat.com>
6091
6092         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6093         and that "set/show print raw frame-arguments" are now deprecated.
6094
6095         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6096         command.
6097         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6098         * stack.c (_initialize_stack): Install "set/show print
6099         raw-frame-arguments", and deprecate "set/show print raw
6100         frame-arguments".
6101         * valprint.c (_initialize_valprint): Deprecate "set/show print
6102         raw".
6103
6104 2019-06-13  Pedro Alves  <palves@redhat.com>
6105
6106         * compile/compile.c (struct compile_options): New.
6107         (compile_flag_option_def, compile_command_option_defs)
6108         (make_compile_options_def_group): New.
6109         (compile_file_command): Handle options with
6110         gdb::option::process_options.
6111         (compile_file_command_completer): New function.
6112         (compile_code_command): Handle options with
6113         gdb::option::process_options.
6114         (compile_code_command_completer): New function.
6115         (_initialize_compiler): Install completers for "compile code" and
6116         "compile file".  Mention available options in "compile code" and
6117         "compile code"'s help.
6118         * completer.c (advance_to_completion_word): New, factored out from
6119         ...
6120         (advance_to_expression_complete_word_point): ... this.
6121         (advance_to_filename_complete_word_point): New.
6122         * completer.h (advance_to_filename_complete_word_point): New
6123         declaration.
6124
6125 2019-06-13  Pedro Alves  <palves@redhat.com>
6126
6127         * compile/compile.c: Include "cli/cli-option.h".
6128         (compile_print_value): Scope data pointer is now a
6129         value_print_options pointer; adjust.
6130         (compile_print_command): Process options.  Scope data pointer is
6131         now a value_print_options pointer; adjust.
6132         (_initialize_compile): Update "compile print"'s help to include
6133         supported options.  Install a completer for "compile print".
6134         * cp-valprint.c (show_vtblprint, show_objectprint)
6135         (show_static_field_print): Delete.
6136         (_initialize_cp_valprint): Don't install "set print
6137         static-members", "set print vtbl", "set print object" here.
6138         * printcmd.c: Include "cli/cli-option.h" and
6139         "common/gdb_optional.h".
6140         (print_command_parse_format): Rework to fill in a
6141         value_print_options instead of a format_data.
6142         (print_value): Change parameter type from format_data pointer to
6143         value_print_options reference.  Adjust.
6144         (print_command_1): Process options.  Adjust to pass down a
6145         value_print_options.
6146         (print_command_completer): New.
6147         (_initialize_printcmd): Install print_command_completer as
6148         handle_brkchars completer for the "print" command.  Update
6149         "print"'s help to include supported options.
6150         * valprint.c: Include "cli/cli-option.h".
6151         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6152         here from cp-valprint.c.
6153         (boolean_option_def, uinteger_option_def)
6154         (value_print_option_defs, make_value_print_options_def_group):
6155         New.  Use gdb::option::add_setshow_cmds_for_options to install
6156         "set print elements", "set print null-stop", "set print repeats",
6157         "set print pretty", "set print union", "set print array", "set
6158         print address", "set print symbol", "set print array-indexes".
6159         * valprint.h: Include <string> and "cli/cli-option.h".
6160         (make_value_print_options_def_group): Declare.
6161         (print_value): Change parameter type from format_data pointer to
6162         value_print_options reference.
6163         (print_command_completer): Declare.
6164
6165 2019-06-13  Pedro Alves  <palves@redhat.com>
6166
6167         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6168         (COMMON_SFILES): Add maint-test-settings.c.
6169         * cli/cli-decode.c (boolean_enums): New global, factored out from
6170         ...
6171         (add_setshow_boolean_cmd): ... here.
6172         * cli/cli-decode.h (boolean_enums): Declare.
6173         * cli/cli-option.c: New file.
6174         * cli/cli-option.h: New file.
6175         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6176         factored out from ...
6177         (parse_cli_boolean_value(const char *)): ... this.
6178         (is_unlimited_literal): Change parameter type to pointer to
6179         pointer.  Adjust and advance ARG pointer.
6180         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6181         (parse_cli_var_enum): New, factored out from ...
6182         (do_set_command): ... this.  Adjust.
6183         * cli/cli-setshow.h (parse_cli_boolean_value)
6184         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6185         (parse_cli_var_enum): Declare.
6186         * cli/cli-utils.c: Include "cli/cli-option.h".
6187         (get_ulongest): New.
6188         * cli/cli-utils.h (get_ulongest): Declare.
6189         (check_for_argument): New overloads.
6190         * maint-test-options.c: New file.
6191
6192 2019-06-13  Pedro Alves  <palves@redhat.com>
6193
6194         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6195         parse a range if "-" is at the end of the string.
6196
6197 2019-06-13  Pedro Alves  <palves@redhat.com>
6198
6199         * cli/cli-setshow.c (parse_auto_binary_operation)
6200         (parse_cli_boolean_value): Don't allow "o".
6201
6202 2019-06-13  Pedro Alves  <palves@redhat.com>
6203
6204         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6205         * NEWS: Mention maint test-settings KIND.
6206         * maint-test-settings.c: New file.
6207
6208 2019-06-13  Pedro Alves  <palves@redhat.com>
6209
6210         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6211         completer.
6212         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6213         "set" completers.
6214
6215 2019-06-13  Pedro Alves  <palves@redhat.com>
6216
6217         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6218         after item.
6219
6220 2019-06-13  Pedro Alves  <palves@redhat.com>
6221
6222         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6223
6224 2019-06-13  Pedro Alves <palves@redhat.com>
6225
6226         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6227         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6228         call.
6229         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6230         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6231         calls.
6232         (check_for_argument): Skip spaces after argument.
6233
6234 2019-06-13  Pedro Alves  <palves@redhat.com>
6235
6236         * thread.c (thread_apply_command): Adjust TID parsing.
6237         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6238         detected before end of string.
6239         (tid_is_in_list): Error out if LIST is invalid.
6240
6241 2019-06-13  Pedro Alves  <palves@redhat.com>
6242
6243         * completer.c (complete_line_internal_1): Rewind completion word
6244         point.
6245         (completion_tracker::advance_custom_word_point_by): Change
6246         parameter type to int.
6247         * completer.h (completion_tracker::advance_custom_word_point_by):
6248         Likewise.
6249
6250 2019-06-13  Pedro Alves  <palves@redhat.com>
6251
6252         * completer.c (advance_to_completion_word): Handle delimiters.
6253
6254 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6255
6256         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6257
6258 2019-06-11  Tom Tromey  <tom@tromey.com>
6259
6260         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6261         (xmalloc_failed): Move to alloc.c.
6262         * alloc.c: New file.
6263         * Makefile.in (COMMON_SFILES): Add alloc.c.
6264
6265 2019-06-11  Tom Tromey  <tom@tromey.com>
6266
6267         * nat/linux-waitpid.c: Don't include server.h.
6268         (linux_debug): Remove.
6269         (my_waitpid): Update.
6270
6271 2019-06-11  Tom Tromey  <tromey@adacore.com>
6272
6273         * infcall.c (_initialize_infcall): Remove trailing newline from
6274         help.
6275         * user-regs.c (_initialize_user_regs): Remove trailing newline
6276         from help.
6277         * typeprint.c (_initialize_typeprint): Remove trailing newline
6278         from help.
6279         * reverse.c (_initialize_reverse): Remove trailing newlines from
6280         help.
6281         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6282         from help.
6283         * language.c (add_set_language_command): Remove trailing newline
6284         from help.
6285         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6286         help.
6287         * disasm.c (_initialize_disasm): Remove trailing newline from
6288         help.
6289         * top.c (init_main): Remove trailing newline from help.
6290         * interps.c (_initialize_interpreter): Remove trailing newline
6291         from help.
6292         * btrace.c (_initialize_btrace): Remove trailing newlines from
6293         help.
6294         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6295         from help.
6296         * python/python.c (_initialize_python): Remove trailing newline
6297         from help.
6298         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6299         help.
6300         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6301         from help.  Reformat some text.
6302         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6303         from help.
6304         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6305         newline from help.
6306
6307 2019-06-11  Tom Tromey  <tromey@adacore.com>
6308
6309         * darwin-nat.c (darwin_decode_exception_message)
6310         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6311
6312 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6313
6314         * valops.c (value_slice): Check for not allocated or not
6315         associated values.
6316
6317 2019-06-10  Tom de Vries  <tdevries@suse.de>
6318
6319         PR gdb/24618
6320         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6321         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6322         invalid.
6323
6324 2019-06-10  Tom de Vries  <tdevries@suse.de>
6325
6326         PR gdb/24611
6327         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6328         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6329
6330 2019-06-10  Tom de Vries  <tdevries@suse.de>
6331
6332         PR symtab/24545
6333         * symtab.c (struct demangled_name_entry): Add language field.
6334         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6335         static minimal symbol".  Set and use language field.
6336
6337 2019-06-10  Tom Tromey  <tromey@adacore.com>
6338
6339         * ada-lang.c (_initialize_ada_language): Update help text.
6340
6341 2019-06-10  Tom Tromey  <tromey@adacore.com>
6342
6343         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6344         with a newline.
6345         * guile/guile.c (handle_boot_error): Don't end warning with a
6346         newline.
6347         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6348         warning with a newline.
6349         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6350         newline.
6351         (s12z_frame_cache): Likewise.
6352         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6353         a newline.
6354         * solib-svr4.c (disable_probes_interface): Don't end warning with
6355         a newline.
6356         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6357         newline.
6358         * python/python.c (do_finish_initialization): Don't end warning
6359         with a newline.
6360
6361 2019-06-10  Tom Tromey  <tom@tromey.com>
6362
6363         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6364         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6365         gdbpy_enter.
6366
6367 2019-06-10  Tom Tromey  <tromey@adacore.com>
6368
6369         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6370         data.
6371         (elf_new_init): Don't call stabsread_new_init.
6372         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6373         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6374         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6375
6376 2019-06-10  Tom de Vries  <tdevries@suse.de>
6377
6378         PR symtab/16264
6379         PR symtab/24517
6380         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6381
6382 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6383
6384         * source.c (find_and_open_source): Also rewrite relative file
6385         names.
6386
6387 2019-04-26  Amos Bird  <amosbird@gmail.com>
6388
6389         * annotate.c (annotate_thread_exited): Add "thread-exited"
6390         annotation.
6391
6392 2019-06-06  Tom Tromey  <tromey@adacore.com>
6393
6394         * maint.h (class scoped_command_stats): Use
6395         DISABLE_COPY_AND_ASSIGN.
6396         <print_time>: New method.
6397         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6398         print_time.
6399         (scoped_command_stats::print_time): New method.
6400
6401 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6402
6403         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6404         instructions of lengths 6 or 8 bytes.
6405
6406 2019-06-04  Pedro Alves  <palves@redhat.com>
6407
6408         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6409
6410         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6411         * breakpoint.c (condition_completer): Likewise.
6412         * cli/cli-dump.c (scan_expression): Likewise.
6413         * common/filestuff.c (mkdir_recursive): Likewise.
6414         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6415         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6416         (gdb_abspath): Likewise.
6417         * compile/compile-cplus-types.c
6418         (compile_cplus_instance::decl_name): Likewise.
6419         * completer.c (complete_explicit_location):
6420         (signal_completer, reg_or_group_completer_1): Likewise.
6421         * cp-support.c (cp_remove_params_if_any): Likewise.
6422         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6423         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6424         * infcmd.c (strip_bg_char): Likewise.
6425         * linespec.c (copy_token_string): Likewise.
6426         * mi/mi-main.c (output_cores): Likewise.
6427         * psymtab.c (psymtab_search_name):
6428         * symfile.c (test_set_ext_lang_command): Likewise.
6429         * target.c (target_fileio_read_stralloc): Likewise.
6430         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6431         * value.c (complete_internalvar): Likewise.
6432
6433 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6434
6435         Add objfile property to gdb.Type.
6436         * NEWS: Mention Python API addition.
6437         * python/py-type.c (typy_get_objfile): New method.
6438
6439 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6440
6441         * NEWS: Mention the new set|show style [title|highlight].
6442         Mention changes to "show style", "help" and "apropos".
6443
6444 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6445
6446         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6447         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6448         instead of print_help_for_command.
6449         (print_doc_of_command): New function.
6450         (help_list): Add 'apropos -v word' suggestion.
6451         (print_help_for_command): Style the command name using title style.
6452         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6453         (_initialize_cli_cmds): Describe -v in apropos_command help.
6454
6455 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6456
6457         * cli/cli-style.h (cli_style_option): Add name in constructor,
6458         add m_name class member, add constructor with intensity,
6459         add name class function.
6460         (cli_style_option::add_setshow_commands): Remove name argument.
6461         (highlight_style, title_style): New styles.
6462         * cli/cli-style.c (do_show): New function that shows a style
6463         characteristic styling the style name with itself.
6464         (set_style_name): New function.
6465         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6466         Update all callers according to the changes in cli/cli-style.h.
6467         * utils.h (fputs_highlighted): New function.
6468         * utils.c (fputs_highlighted): Likewise.
6469
6470 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6471
6472         * NEWS: Mention new pipe command and new convenience variables.
6473
6474 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6475
6476         * cli/cli-cmds.c (pipe_command): New function.
6477         (_initialize_cli_cmds): Call add_com for pipe_command.
6478         Define | as an alias for pipe.
6479         (exit_status_set_internal_vars): New function.
6480         (shell_escape): Call exit_status_set_internal_vars.
6481         cli/cli-decode.c (find_command_name_length): Recognize | as
6482         a single character command.
6483
6484 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6485
6486         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6487         top.c (execute_command_to_ui_file): New function, mostly a copy
6488         of execute_command_to_string.
6489         (execute_command_to_string): Implement by calling
6490         execute_command_to_ui_file.
6491
6492 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6493
6494         * top.h (saved_command_line): Remove declaration.
6495         * top.c (previous_saved_command_line, previous_repeat_arguments):
6496         New variables.
6497         (saved_command_line): Make static, define together with other
6498         'repeat variables'.
6499         (dont_repeat): Clear repeat_arguments.
6500         (repeat_previous, get_saved_command_line, save_command_line):
6501         New functions.
6502         (gdb_init): Initialize saved_command_line
6503         and previous_saved_command_line.
6504         * main.c (captured_main_1): Remove saved_command_line initialization.
6505         * event-top.c (handle_line_of_input): Update to use
6506         the new 'repeat' related functions instead of direct access to
6507         saved_command_line.
6508         * command.h (repeat_previous, get_saved_command_line,
6509         save_command_line): New declarations.
6510         (dont_repeat): Add comment.
6511
6512 2019-05-30  Tom Tromey  <tromey@adacore.com>
6513
6514         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6515         Fix comment.
6516         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6517
6518 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6519
6520         PR cli/24587
6521         * completer.c (complete): Initialize variable word.
6522
6523 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6524
6525         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6526         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6527         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6528         'body' is NULL to the outter 'if', protecting the '!is_define'
6529         situation as well.
6530
6531 2019-05-29  Tom Tromey  <tromey@adacore.com>
6532
6533         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6534         (dwarf_unknown): New function.
6535         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6536         (dwarf_type_encoding_name): Use dwarf_unknown.
6537
6538 2019-05-29  Tom Tromey  <tromey@adacore.com>
6539
6540         PR c++/20020:
6541         * cp-valprint.c (cp_print_value_fields): Call
6542         cp_print_static_field inside "try".
6543
6544 2019-05-29  Tom Tromey  <tromey@adacore.com>
6545
6546         * inflow.c (struct terminal_info): Add default operator=.
6547         * configure: Rebuild.
6548         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6549         -Wdeprecated-copy-dtor, -Wredundant-move.
6550
6551 2019-05-29  Tom Tromey  <tromey@adacore.com>
6552
6553         * NEWS: Add entry.
6554         * infcmd.c (print_return_value_1): Handle finish_print
6555         option.
6556         (show_print_finish): New function.
6557         (_initialize_infcmd): Add "set/show print finish" commands.
6558         * valprint.c (user_print_options): Initialize new member.
6559         * valprint.h (struct value_print_options) <finish_print>: New
6560         member.
6561
6562 2019-05-28  Tom Tromey  <tromey@adacore.com>
6563
6564         * ada-lang.c (ada_remove_Xbn_suffix)
6565         (find_old_style_renaming_symbol)
6566         (parse_old_style_renaming): Remove.
6567         (ada_find_renaming_symbol): Don't call
6568         find_old_style_renaming_symbol.
6569         (ada_is_renaming_symbol): Rename from
6570         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6571         bool.  Now static.
6572         (ada_read_var_value): Update and simplify.
6573         * ada-exp.y (write_var_or_type): Remove old code.
6574
6575 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6576
6577         * event-top.c: Remove include comment.
6578         * inflow.c (class scoped_ignore_sigttou): Move from here...
6579         * inflow.h (class scoped_ignore_sigttou): ...to here.
6580         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6581         * top.c:  Remove include comment.
6582
6583 2019-05-27  Tom Tromey  <tom@tromey.com>
6584
6585         * NEWS: Fix typo.
6586
6587 2019-05-22  Tom Tromey  <tromey@adacore.com>
6588
6589         * target.c (target_follow_exec): Constify parameter.
6590         * target-delegates.c: Rebuild.
6591         * remote.c (remote_target::follow_exec): Constify parameter.
6592         * infrun.c (follow_exec): Constify parameter.
6593         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6594         (target_follow_exec): Likewise.
6595
6596 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6597
6598         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6599         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6600
6601 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6602
6603         * NEWS: Add debugredirect and testsuite sections.
6604
6605 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6606
6607         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6608         target descriptions using exclusively floating point register name
6609         aliases.
6610
6611 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6612
6613         PR gdb/18644:
6614         * f-lang.c (build_fortran_types): Handle the case where
6615         gdbarch_floatformat_for_type returns a nullptr.
6616
6617 2019-05-21  Tom de Vries  <tdevries@suse.de>
6618
6619         PR cli/24587
6620         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6621
6622 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6623
6624         PR gdb/18644:
6625         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6626         16-byte floats.
6627         * i386-tdep.c (i386_floatformat_for_type): Use
6628         floatformats_ia64_quad for the 16-byte floating point component
6629         within a fortran 32-byte complex number.
6630
6631 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6632
6633         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6634         delete default constructor.
6635         (find_partial_die): Update to return const struct.
6636         (partial_die_parent_scope): Move variable declaration into scope
6637         of its use and change its type to auto.
6638         (guess_partial_die_structure_name): Likewise.
6639         (partial_die_info::fixup): Likewise.
6640
6641 2019-05-17  Tom Tromey  <tromey@adacore.com>
6642
6643         * source.c (find_and_open_source): Remove cast.
6644
6645 2019-05-17  Tom Tromey  <tromey@adacore.com>
6646
6647         * annotate.c (annotate_source): Make "filename" const.
6648         * annotate.h (annotate_source): Use const.
6649
6650 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6651
6652         * disasm.c (set_disassembler_options): Send errors to stderr.
6653
6654 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6655
6656         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6657         (cli_interp_base::set_logging): Check debug_redirect.
6658         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6659         * cli/cli-logging.c (debug_redirect): Add static variable.
6660         (pop_output_files): Add default param.
6661         (handle_redirections): Print debug setting.
6662         (show_logging_command): Likewise.
6663         (_initialize_cli_logging): Add debugredirect command.
6664         * interps.c (current_interp_set_logging): Add debug_redirect
6665         parameter.
6666         * interps.h (set_logging): Add debug_redirect parameter.
6667         (current_interp_set_logging): Likewise.
6668         * mi/mi-common.h: Likewise.
6669         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6670
6671 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6672             Tom Tromey  <tromey@adacore.com>
6673
6674         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6675         directly.
6676         * cli/cli-interp.h (make_logging_output): Remove declaration.
6677         * cli/cli-logging.c (make_logging_output): Remove function.
6678         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6679         directly.
6680         * ui-file.c (tee_file::tee_file): Remove bools.
6681         (tee_file::~tee_file): Remove deletes.
6682         * ui-file.h (tee_file): Remove bools.
6683
6684 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6685
6686         * mi/mi-cmds.h (mi_cmd_complete): New function.
6687         * mi/mi-main.c (mi_cmd_complete): Likewise.
6688         * mi/mi-cmds.c: Define new MI command -complete.
6689         * NEWS: Mention new -complete command.
6690
6691 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6692
6693         * completer.h (complete): New function.
6694         * completer.c (complete): Likewise.
6695         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6696         function defined in completer.h.
6697
6698 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6699
6700         * MAINTAINERS (Write After Approval): Add myself.
6701
6702 2019-05-17  Tom de Vries  <tdevries@suse.de>
6703
6704         PR gdb/24094
6705         * dwarf2read.c (struct cu_partial_die_info): New struct.
6706         (find_partial_die): Return cu_partial_die_info.
6707         (partial_die_parent_scope, guess_partial_die_structure_name)
6708         (partial_die_info::fixup): Handle new return type of find_partial_die.
6709
6710 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6711
6712         PR breakpoints/24541
6713         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6714         "std::string", simplifying the algorithm.
6715
6716 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6717
6718         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6719         (stap_static_probe_ops::get_probes): Likewise.
6720
6721 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6722
6723         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6724         '-')" and "else if".
6725         (stap_parse_single_operand): Join checks for
6726         "gdbarch_stap_parse_special_token_p" and
6727         "gdbarch_stap_parse_special_token" in the same "if" statement.
6728         Invert check when verifying for operation on register
6729         displacement.
6730
6731 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6732
6733         * stap-probe.c (stap_get_opcode): Update comment.
6734         (stap_get_expected_argument_type): Likewise.
6735         (handle_stap_probe): Likewise.
6736
6737 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6738
6739         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6740         return type to 'bool'.  Adjust comment.  Use 'bool' when
6741         appropriate.
6742         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6743         * stap-probe.c (stap_parse_argument_1): Likewise.
6744         (stap_is_operator): Likewise.
6745         (stap_is_generic_prefix): Likewise.
6746         (stap_is_register_prefix): Likewise.
6747         (stap_is_register_indirection_prefix): Likewise.
6748         (stap_is_integer_prefix): Likewise.
6749         (stap_generic_check_suffix): Likewise.
6750         (stap_check_integer_suffix): Likewise.
6751         (stap_check_register_suffix): Likewise.
6752         (stap_check_register_indirection_suffix): Likewise.
6753         (stap_parse_register_operand): Likewise.
6754         (stap_parse_single_operand): Likewise.
6755         (stap_parse_argument_1): Likewise.
6756         (stap_probe::get_argument_count): Likewise.
6757         (stap_is_operator): Likewise.
6758
6759 2019-05-16  Tom Tromey  <tromey@adacore.com>
6760
6761         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6762         keyword to foreach.
6763
6764 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6765
6766         * linux-thread-db.c (try_thread_db_load_1): Change return type
6767         to bool.
6768         (try_thread_db_load): Likewise.
6769         (try_thread_db_load_from_pdir_1): Likewise.
6770         (try_thread_db_load_from_pdir): Likewise.
6771         (try_thread_db_load_from_sdir): Likewise.
6772         (try_thread_db_load_from_dir): Likewise.
6773         (thread_db_load_search): Likewise.
6774         (has_libpthread): Likewise.
6775         (thread_db_load): Likewise.
6776
6777 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6778
6779         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6780         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6781         NULL, and complain/return if that's the case.
6782
6783 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6784
6785         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6786         (advance, posn, abstract_read_memory): New functions.
6787         [struct mem_read_abstraction]: New struct.
6788         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6789
6790 2019-05-14  Tom Tromey  <tromey@adacore.com>
6791
6792         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6793         value is not lval_memory.
6794
6795 2019-05-14  Tom Tromey  <tromey@adacore.com>
6796
6797         * solib.c (info_sharedlibrary_command): Style the file name.
6798
6799 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6800
6801         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6802         (aarch64_vnv_type): Likewise.
6803         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6804         * common/tdesc.c: Likewise.
6805         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6806         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6807         * features/aarch64-fpu.xml: Add ieee half view.
6808         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6809         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6810         * gdbtypes.h (struct builtin_type): Likewise.
6811         (struct objfile_type): Likewise.
6812
6813 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6814
6815         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6816         typo.
6817         * location.h (string_to_event_location): Likewise.
6818
6819 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6820
6821         GDB 8.3 released.
6822
6823 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6824
6825         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6826         New variable declaration.
6827         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6828         New variable.
6829         (print_one_breakpoint): Use ui_out::test_flags and new global
6830         variable to compute use_fixed_output.
6831         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6832         Remove.
6833         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6834         (mi_multi_location_breakpoint_output_fixed): Remove.
6835         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6836         new variable.
6837         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6838         fix_multi_location_breakpoint_output flag if version >= 3.
6839         * ui-out.h (enum ui_out_flag)
6840         <fix_multi_location_breakpoint_output>: New enumerator.
6841
6842 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6843
6844         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6845
6846 2019-05-10  Tom Tromey  <tromey@adacore.com>
6847
6848         * ada-lang.c (catch_ada_completer): New function.
6849         (_initialize_ada_language): Use it.
6850
6851 2019-05-10  Tom Tromey  <tromey@adacore.com>
6852
6853         * thread.c (print_thread_info): Make "requested_threads" const.
6854         * gdbthread.h (print_thread_info): Make "requested_threads"
6855         const.
6856         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6857         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6858
6859 2019-05-08  Tom Tromey  <tom@tromey.com>
6860
6861         * gdbtypes.c (objfile_type_data): Change type.
6862         (objfile_type, _initialize_gdbtypes): Update.
6863
6864 2019-05-08  Tom Tromey  <tom@tromey.com>
6865
6866         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6867         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6868         (_initialize_dwarf2_frame): Update.
6869
6870 2019-05-08  Tom Tromey  <tom@tromey.com>
6871
6872         * objc-lang.c (objc_objfile_data): Change type.
6873         (find_methods): Update.
6874         (_initialize_objc_lang): Remove.
6875
6876 2019-05-08  Tom Tromey  <tom@tromey.com>
6877
6878         * stabsread.c (rs6000_builtin_type_data): Change type.
6879         (rs6000_builtin_type, _initialize_stabsread): Update.
6880
6881 2019-05-08  Tom Tromey  <tom@tromey.com>
6882
6883         * mips-tdep.c (mips_pdr_data): Remove.
6884         (_initialize_mips_tdep): Update.
6885
6886 2019-05-08  Tom Tromey  <tom@tromey.com>
6887
6888         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6889         (hppa_init_objfile_priv_data, read_unwind_info)
6890         (find_unwind_entry, _initialize_hppa_tdep): Update.
6891
6892 2019-05-08  Tom Tromey  <tom@tromey.com>
6893
6894         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6895         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6896         on obstack.
6897         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6898
6899 2019-05-08  Tom Tromey  <tom@tromey.com>
6900
6901         * mdebugread.c (basic_type_data): Change type.
6902         (basic_type, _initialize_mdebugread): Update.
6903
6904 2019-05-08  Tom Tromey  <tom@tromey.com>
6905
6906         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6907
6908 2019-05-08  Tom Tromey  <tom@tromey.com>
6909
6910         * nto-tdep.c (nto_inferior_data_reg): Change type.
6911         (nto_inferior_data): Update.
6912         (nto_inferior_data_cleanup, nto_new_inferior_data)
6913         (_initialize_nto_tdep): Remove.
6914         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6915
6916 2019-05-08  Tom Tromey  <tom@tromey.com>
6917
6918         * ada-lang.c (struct ada_inferior_data): Add initializers.
6919         (ada_inferior_data): Change type.
6920         (ada_inferior_data_cleanup): Remove.
6921         (get_ada_inferior_data, ada_inferior_exit)
6922         (struct ada_pspace_data): Add initializers, destructor.
6923         (ada_pspace_data_handle): Change type.
6924         (get_ada_pspace_data): Update.
6925         (ada_pspace_data_cleanup): Remove.
6926
6927 2019-05-08  Tom Tromey  <tom@tromey.com>
6928
6929         * coffread.c (struct coff_symfile_info): Add initializers.
6930         (coff_objfile_data_key): Move lower.  Change type.
6931         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6932         Update.
6933         (coff_free_info): Remove.
6934
6935 2019-05-08  Tom Tromey  <tom@tromey.com>
6936
6937         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6938         (fbsd_pspace_data_handle): Move lower.  Change type.
6939         (get_fbsd_pspace_data): Update.
6940         (fbsd_pspace_data_cleanup): Remove.
6941         (_initialize_fbsd_tdep): Update.
6942
6943 2019-05-08  Tom Tromey  <tom@tromey.com>
6944
6945         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6946         (get_ada_tasks_pspace_data): Update.
6947         (ada_tasks_pspace_data_cleanup): Remove.
6948         (_initialize_tasks): Update.
6949         (ada_tasks_inferior_data_handle): Change type.
6950         (get_ada_tasks_inferior_data): Update.
6951         (ada_tasks_inferior_data_cleanup): Remove.
6952         (struct ada_tasks_pspace_data): Add initializers.
6953
6954 2019-05-08  Tom Tromey  <tom@tromey.com>
6955
6956         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6957         * symfile-debug.c (debug_sym_get_probes): Change type.
6958         * stap-probe.c (handle_stap_probe):
6959         (stap_static_probe_ops::get_probes): Change type.
6960         * probe.h (class static_probe_ops) <get_probes>: Change type.
6961         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6962         (parse_probes_in_pspace): Update.
6963         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6964         Update.
6965         (any_static_probe_ops::get_probes): Change type.
6966         * elfread.c (elfread_data): New typedef.
6967         (probe_key): Change type.
6968         (elf_get_probes): Likewise.  Update.
6969         (probe_key_free): Remove.
6970         (_initialize_elfread): Update.
6971         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6972         Change type.
6973         (dtrace_process_dof_probe, dtrace_process_dof)
6974         (dtrace_static_probe_ops::get_probe): Change type.
6975
6976 2019-05-08  Tom Tromey  <tom@tromey.com>
6977
6978         * xcoffread.c (struct xcoff_symfile_info): Rename from
6979         coff_symfile_info.  Add initializers.
6980         (xcoff_objfile_data_key): Move lower.  Change type.
6981         (XCOFF_DATA): Rewrite.
6982         (xcoff_free_info): Remove.
6983         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6984         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6985         (xcoff_initial_scan): Update.
6986
6987 2019-05-08  Tom Tromey  <tom@tromey.com>
6988
6989         * solib-svr4.c (struct svr4_info): Add initializers and
6990         destructor.
6991         <probes_table>: Now an htab_up.
6992         (solib_svr4_pspace_data): Change type.
6993         (free_probes_table): Simplify.
6994         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6995         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6996         (probes_table_remove_objfile_probes, register_solib_event_probe)
6997         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6998         (_initialize_svr4_solib): Update.
6999
7000 2019-05-08  Tom Tromey  <tom@tromey.com>
7001
7002         * remote.c (remote_pspace_data): Change type.
7003         (remote_pspace_data_cleanup): Remove.
7004         (get_remote_exec_file, set_pspace_remote_exec_file)
7005         (_initialize_remote): Update.
7006
7007 2019-05-08  Tom Tromey  <tom@tromey.com>
7008
7009         * breakpoint.c (breakpoint_objfile_key): Change type.
7010         (get_breakpoint_objfile_data): Update.
7011         (free_breakpoint_objfile_data): Remove.
7012         (_initialize_breakpoint): Update.
7013
7014 2019-05-08  Tom Tromey  <tom@tromey.com>
7015
7016         * linux-tdep.c (struct linux_info): Add initializers.
7017         (linux_inferior_data): Move.  Change type.
7018         (invalidate_linux_cache_inf): Update.
7019         (linux_inferior_data_cleanup): Remove.
7020         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7021
7022 2019-05-08  Tom Tromey  <tom@tromey.com>
7023
7024         * auxv.c (auxv_inferior_data): Move.  Change type.
7025         (auxv_inferior_data_cleanup): Remove.
7026         (invalidate_auxv_cache_inf): Rewrite.
7027         (get_auxv_inferior_data, _initialize_auxv): Update.
7028
7029 2019-05-08  Tom Tromey  <tom@tromey.com>
7030
7031         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7032         (symfile_debug_objfile_data_key): Change type.
7033         (symfile_debug_installed, debug_qf_has_symbols)
7034         (debug_qf_find_last_source_symtab)
7035         (debug_qf_forget_cached_source_info)
7036         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7037         (debug_qf_print_stats, debug_qf_dump)
7038         (debug_qf_expand_symtabs_for_function)
7039         (debug_qf_expand_all_symtabs)
7040         (debug_qf_expand_symtabs_with_fullname)
7041         (debug_qf_map_matching_symbols)
7042         (debug_qf_expand_symtabs_matching)
7043         (debug_qf_find_pc_sect_compunit_symtab)
7044         (debug_qf_map_symbol_filenames)
7045         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7046         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7047         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7048         (debug_sym_read_linetable, debug_sym_relocate): Update.
7049         (symfile_debug_free_objfile): Remove.
7050         (install_symfile_debug_logging, _initialize_symfile_debug):
7051         Update.
7052
7053 2019-05-08  Tom Tromey  <tom@tromey.com>
7054
7055         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7056         allocate_on_obstack.
7057         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7058         (get_dwarf2_per_objfile): Update.
7059         (set_dwarf2_per_objfile): Remove.
7060         (dwarf2_has_info, dwarf2_get_section_info): Update.
7061         (dwarf2_free_objfile): Remove.
7062         (_initialize_dwarf2_read): Update.
7063
7064 2019-05-08  Tom Tromey  <tom@tromey.com>
7065
7066         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7067         initializers.
7068         <unsupported_script_warning_printed,
7069         script_not_found_warning_printed>: Now bool.
7070         (auto_load_pspace_data): Change type.
7071         (~auto_load_pspace_info): Rename from
7072         auto_load_pspace_data_cleanup.
7073         (get_auto_load_pspace_data, init_loaded_scripts_info)
7074         (clear_section_scripts, maybe_print_unsupported_script_warning)
7075         (maybe_print_script_not_found_warning, _initialize_auto_load):
7076         Update.
7077
7078 2019-05-08  Tom Tromey  <tom@tromey.com>
7079
7080         * objfiles.c (objfile_pspace_info): Add destructor and
7081         initializers.
7082         (objfiles_pspace_data): Change type.
7083         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7084         (get_objfile_pspace_data): Update.
7085         (objfiles_bfd_data): Change type.
7086         (get_objfile_bfd_data): Update.
7087         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7088
7089 2019-05-08  Tom Tromey  <tom@tromey.com>
7090
7091         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7092         Change type.
7093         (get_catch_syscall_inferior_data): Update.
7094         (catch_syscall_inferior_data_cleanup): Remove.
7095         (_initialize_break_catch_syscall): Update.
7096
7097 2019-05-08  Tom Tromey  <tom@tromey.com>
7098
7099         * inflow.c (struct terminal_info): Add destructor and
7100         initializers.
7101         (inflow_inferior_data): Change type.
7102         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7103         (get_inflow_inferior_data, inflow_inferior_exit)
7104         (swap_terminal_info, _initialize_inflow): Update.
7105
7106 2019-05-08  Tom Tromey  <tom@tromey.com>
7107
7108         * target-dcache.c (target_dcache_cleanup): Remove.
7109         (target_dcache_aspace_key): Change type.
7110         (target_dcache_init_p, target_dcache_invalidate)
7111         (target_dcache_get, target_dcache_get_or_init)
7112         (_initialize_target_dcache): Update.
7113         * dcache.h (struct dcache_deleter): New.
7114
7115 2019-05-08  Tom Tromey  <tom@tromey.com>
7116
7117         * symtab.c (struct symbol_cache): Add destructor and
7118         initializers.
7119         (symbol_cache_key): Move.  Change type.
7120         (make_symbol_cache, free_symbol_cache): Remove.
7121         (get_symbol_cache): Update.
7122         (symbol_cache_cleanup): Remove.
7123         (ALL_PSPACES, symbol_cache_flush)
7124         (maintenance_print_symbol_cache)
7125         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7126         Update.
7127
7128 2019-05-08  Tom Tromey  <tom@tromey.com>
7129
7130         * symtab.c (struct main_info): Add destructor and initializers.
7131         (main_progspace_key): Move.  Change type.
7132         (get_main_info): Update.
7133         (main_info_cleanup): Remove.
7134         (_initialize_symtab): Update.
7135
7136 2019-05-08  Tom Tromey  <tom@tromey.com>
7137
7138         * registry.h (DECLARE_REGISTRY): Define the _key class.
7139
7140 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7141
7142         * NEWS: Merge two 'New commands' sections.
7143
7144 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7145
7146         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7147         parameter and use Ada language definition instead.
7148         (ada_val_print_ptr): Remove unused language parameter.
7149         (ada_val_print_num): Remove language parameter and use Ada language
7150         definition instead.
7151         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7152         parameter.
7153         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7154         parameter and use Ada language definition instead.
7155         (ada_val_print_1): Update all ada_val_print_xxx calls.
7156         Remove language parameter.
7157         (ada_val_print): Update ada_val_print_1 call.
7158
7159 2019-05-08  Tom Tromey  <tromey@adacore.com>
7160
7161         * remote.c (remote_hw_watchpoint_limit)
7162         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7163         Now static.
7164
7165 2019-05-08  Tom Tromey  <tromey@adacore.com>
7166
7167         * maint.c (_initialize_maint_cmds): Move initialization code to
7168         remote.c.
7169         (watchdog, show_watchdog): Move to remote.c.
7170         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7171         "watchdog" static.
7172         (_initialize_remote): Move initialization code from maint.c.
7173         * defs.h (watchdog): Don't declare.
7174
7175 2019-05-08  Tom Tromey  <tromey@adacore.com>
7176
7177         * tui/tui-interp.c: Include main.h.
7178         * interps.c: Include main.h.
7179         * main.h (interpreter_p): Declare.
7180         * defs.h (interpreter_p): Don't declare.
7181
7182 2019-05-08  Tom Tromey  <tromey@adacore.com>
7183
7184         * dwarf2loc.c: Include dwarf2read.h.
7185         * defs.h (read_unsigned_leb128): Don't declare.
7186         * dwarf2read.h (read_unsigned_leb128): Declare.
7187
7188 2019-05-08  Tom Tromey  <tromey@adacore.com>
7189
7190         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7191         method.
7192
7193 2019-05-08  Tom Tromey  <tromey@adacore.com>
7194
7195         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7196         when no wrap column is set.
7197
7198 2019-05-08  Tom Tromey  <tromey@adacore.com>
7199
7200         * c-lang.c (c_get_string): Handle non-C-style arrays.
7201
7202 2019-05-08  Tom Tromey  <tromey@adacore.com>
7203
7204         * typeprint.c (print_offset_data::update): Print the bit offset,
7205         not the number of bits remaining.
7206
7207 2019-05-08  Tom Tromey  <tromey@adacore.com>
7208
7209         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7210         padding at end of comment.
7211
7212 2019-05-08  Tom Tromey  <tromey@adacore.com>
7213
7214         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7215         Compare main types.
7216
7217 2019-05-06  Tom Tromey  <tom@tromey.com>
7218
7219         * common/scoped_mmap.c: Include common-defs.h.
7220         * common/scoped_mmap.h: Don't include config.h.
7221
7222 2019-05-04  Tom Tromey  <tom@tromey.com>
7223
7224         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7225         (struct aarch64_call_info): Add initializers.
7226         <si>: Now a std::vector.
7227         (pass_on_stack, aarch64_push_dummy_call): Update.
7228
7229 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7230             Tom Tromey  <tom@tromey.com>
7231
7232         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7233         (ppc_threads): Now a std::vector.  Now static.
7234         (hwdebug_find_thread_points_by_tid)
7235         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7236         Update.
7237
7238 2019-05-04  Tom Tromey  <tom@tromey.com>
7239
7240         * arc-tdep.c (arc_tdesc_init): Return bool.
7241
7242 2019-05-04  Tom Tromey  <tom@tromey.com>
7243
7244         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7245         Use gdb_assert_not_reached.
7246
7247 2019-05-04  Tom Tromey  <tom@tromey.com>
7248
7249         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7250         "false".
7251
7252 2019-05-04  Tom Tromey  <tom@tromey.com>
7253
7254         * arc-tdep.c (arc_tdesc_init): Use bool.
7255
7256 2019-05-04  Tom Tromey  <tom@tromey.com>
7257
7258         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7259
7260 2019-05-04  Tom Tromey  <tom@tromey.com>
7261
7262         * cli/cli-cmds.c (valid_command_p): Return bool.
7263
7264 2019-05-04  Tom Tromey  <tom@tromey.com>
7265
7266         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7267         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7268
7269 2019-05-04  Raul Tambre  <raul@tambre.ee>
7270
7271         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7272         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7273         operator for comparison.
7274
7275 2019-05-04  Tom Tromey  <tom@tromey.com>
7276
7277         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7278         (lookup_partial_symbol, print_partial_symbols)
7279         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7280         (psymbol_compare): Update.
7281         (add_psymbol_to_bcache): Clear the entire psymbol.
7282         (maintenance_check_psymtabs): Update.
7283         * psympriv.h (struct partial_symbol): Don't derive from
7284         general_symbol_info.
7285         <obj_section, unrelocated_address, address,
7286         set_unrelocated_address>: Update.
7287         <ginfo>: New member.
7288         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7289         (debug_names::write_psymbols): Update.
7290
7291 2019-05-04  Tom de Vries  <tdevries@suse.de>
7292
7293         * contrib/cc-with-tweaks.sh: Support -n arg.
7294
7295 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7296
7297         * corelow.c (core_target::detach): Ensure frame cache and
7298         register caches are cleared.
7299         inferior.c (exit_inferior_1): Likewise.
7300
7301 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7302             Tom Tromey  <tom@tromey.com>
7303
7304         * dictionary.c (collate_pending_symbols_by_language): Remove
7305         "struct" from foreach.
7306         * symtab.c (lookup_global_symbol_from_objfile)
7307         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7308         foreach.
7309         * ser-tcp.c (net_open): Remove "struct" from foreach.
7310         * objfiles.c (objfile_relocate, objfile_rebase)
7311         (objfile_has_symbols): Remove "struct" from foreach.
7312         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7313         from foreach.
7314         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7315         foreach.
7316         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7317         "struct" from foreach.
7318         * ada-lang.c (create_excep_cond_exprs)
7319         (ada_exception_catchpoint_cond_string): Remove "struct" from
7320         foreach.
7321
7322 2019-05-03  Tom Tromey  <tromey@adacore.com>
7323
7324         * ada-exp.y (convert_char_literal): Check suffix of each
7325         enumerator.
7326
7327 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7328
7329         PR ada/21406:
7330         * ada-exp.y (yywrap): Don't define.
7331         * ada-lex.l (%option): Add noyywrap
7332         (yywrap): Remove.
7333
7334 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7335
7336         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7337         _WIN32_WINNT to the XP level, unless already defined to a higher
7338         level.
7339
7340         * unittests/parse-connection-spec-selftests.c:
7341         * ser-tcp.c:
7342         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7343         override.
7344
7345         * symfile.c (find_separate_debug_file): Remove colon from the
7346         drive spec of DOS/Windows file names of the target, so that the
7347         file name produced from DEBUGDIR and the target's directory will
7348         be valid on DOS/Windows systems.
7349
7350 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7351
7352         * rust-lang.c (val_print_struct): Handle printing structures
7353         containing strings.
7354
7355 2019-05-02  Tom Tromey  <tromey@adacore.com>
7356
7357         * valarith.c (_initialize_valarith): Remove.
7358
7359 2019-05-01  Tom Tromey  <tromey@adacore.com>
7360
7361         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7362         bitfields.
7363
7364 2019-05-01  Tom Tromey  <tromey@adacore.com>
7365
7366         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7367         for big-endian copies.
7368
7369 2019-04-30  Ali Tamur  <tamur@google.com>
7370         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7371         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7372         (read_3_bytes): New function.
7373
7374 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7375
7376         * windows-nat.c (main_thread_id): Delete.
7377         (handle_output_debug_string): Replace main_thread_id by
7378         current_event.dwThreadId.
7379         (fake_create_process): Likewise.
7380         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7381         Do not set main_thread_id.
7382         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7383         current_event.dwThreadId.
7384         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7385
7386 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7387
7388         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7389         Use current_event.dwThreadId instead of main_thread_id.
7390
7391 2019-04-30  Tom Tromey  <tromey@adacore.com>
7392
7393         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7394         (create_excep_cond_exprs): Iterate over program spaces.
7395         (ada_exception_catchpoint_cond_string): Examine all minimal
7396         symbols for exception types.
7397
7398 2019-04-30  Tom Tromey  <tromey@adacore.com>
7399
7400         PR c++/24470:
7401         * dwarf2read.c (process_structure_scope): Handle case where type
7402         has template parameters but no symbol was created.
7403
7404 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7405             Chris January  <chris.january@arm.com>
7406
7407         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7408         qualifier.
7409         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7410
7411 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7412
7413         * f-typeprint.c (f_print_type): Update rules for printing
7414         whitespace.
7415         (f_type_print_varspec_suffix): Likewise.
7416
7417 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7418             Chris January  <chris.january@arm.com>
7419
7420         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7421         function arguments.
7422
7423 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7424
7425         * f-lang.c (build_fortran_types): Change name of void type to
7426         lower case.
7427         * f-typeprint.c (f_type_print_base): Print the name of the void
7428         type, rather than a fixed string.
7429         * f-valprint.c (f_decorations): Use lower case void string.
7430
7431 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7432             Chris January  <chris.january@arm.com>
7433
7434         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7435         types for Fortran.
7436
7437 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7438             Chris January  <chris.january@arm.com>
7439             David Lecomber  <david.lecomber@arm.com>
7440
7441         * f-exp.y (BINOP_INTRINSIC): New token.
7442         (exp): New parser rule handling BINOP_INTRINSIC.
7443         (f77_keywords): Add new builtin procedures.
7444         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7445         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7446         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7447         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7448         (print_unop_subexp_f): New function.
7449         (print_binop_subexp_f): New function.
7450         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7451         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7452         (dump_subexp_body_f): Likewise.
7453         (operator_check_f): Likewise.
7454         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7455         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7456
7457 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7458
7459         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7460         UNOP_KIND.
7461         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7462         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7463         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7464         (operator_length_f): New fuction.
7465         (print_subexp_f): New function.
7466         (op_name_f): New function.
7467         (dump_subexp_body_f): New function.
7468         (operator_check_f): New function.
7469         (exp_descriptor_f): Replace standard expression handling functions
7470         with new functions.
7471         * gdb/fortran-operator.def: New file.
7472         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7473         * gdb/std-operator.def: Remove UNOP_KIND.
7474
7475 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7476
7477         * std-operator.def: Remove unbalanced, stray double quote
7478         character.
7479
7480 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7481             Chris January  <chris.january@arm.com>
7482             Daniel Everett  <daniel.everett@arm.com>
7483             Nick Forrington  <nick.forrington@arm.com>
7484             Richard Bunt  <richard.bunt@arm.com>
7485
7486         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7487         of depth when printing anonymous structs or unions.
7488         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7489         Don't print either the top-level value, or the children if the
7490         max-depth is exceeded.
7491         (ppscm_print_children): When printing the key of a map, allow one
7492         extra level of depth.
7493         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7494         print either the top-level value, or the children if the max-depth
7495         is exceeded.
7496         (print_children): When printing the key of a map, allow one extra
7497         level of depth.
7498         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7499         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7500         (user_print_options): Initialise max_depth field.
7501         (val_print_scalar_or_string_type_p): New function.
7502         (val_print): Check to see if the max depth has been reached.
7503         (val_print_check_max_depth): Define new function.
7504         (show_print_max_depth): New function.
7505         (_initialize_valprint): Add 'print max-depth' option.
7506         * valprint.h (struct value_print_options) <max_depth>: New field.
7507         (val_print_check_max_depth): Declare new function.
7508         * NEWS: Document new feature.
7509
7510 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7511
7512         * ada-lang.c (ada_language_defn): Initialise new field.
7513         * c-lang.c (c_is_string_type_p): New function.
7514         (c_language_defn): Initialise new field.
7515         (cplus_language_defn): Initialise new field.
7516         (asm_language_defn): Initialise new field.
7517         (minimal_language_defn): Initialise new field.
7518         * c-lang.h (c_is_string_type_p): Declare new function.
7519         * d-lang.c (d_language_defn): Initialise new field.
7520         * f-lang.c (f_is_string_type_p): New function.
7521         (f_language_defn): Initialise new field.
7522         * go-lang.c (go_is_string_type_p): New function.
7523         (go_language_defn): Initialise new field.
7524         * language.c (default_is_string_type_p): New function.
7525         (unknown_language_defn): Initialise new field.
7526         (auto_language_defn): Initialise new field.
7527         * language.h (struct language_defn) <la_is_string_type_p>: New
7528         member variable.
7529         (default_is_string_type_p): Declare new function.
7530         * m2-lang.c (m2_language_defn): Initialise new field.
7531         * objc-lang.c (objc_language_defn): Initialise new field.
7532         * opencl-lang.c (opencl_language_defn): Initialise new field.
7533         * p-lang.c (pascal_is_string_type_p): New function.
7534         (pascal_language_defn): Initialise new field.
7535         * rust-lang.c (rust_is_string_type_p): New function.
7536         (rust_language_defn): Initialise new field.
7537
7538 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7539
7540         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7541         New field.
7542         * ada-lang.c (ada_language_defn): Initialise new field.
7543         * c-lang.c (c_language_defn): Likewise.
7544         (cplus_language_defn): Likewise.
7545         (asm_language_defn): Likewise.
7546         (minimal_language_defn): Likewise.
7547         * d-lang.c (d_language_defn): Likewise.
7548         * f-lang.c (f_language_defn): Likewise.
7549         * go-lang.c (go_language_defn): Likewise.
7550         * language.c (unknown_language_defn): Likewise.
7551         (auto_language_defn): Likewise.
7552         * m2-lang.c (m2_language_defn): Likewise.
7553         * objc-lang.c (objc_language_defn): Likewise.
7554         * opencl-lang.c (opencl_language_defn): Likewise.
7555         * p-lang.c (pascal_language_defn): Likewise.
7556         * rust-lang.c (rust_language_defn): Likewise.
7557
7558 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7559
7560         * ada-lang.c (ada_is_character_type): Change return type to bool.
7561         (ada_is_string_type): Likewise.
7562         * ada-lang.h (ada_is_character_type): Update declaration
7563         (ada_is_string_type): Likewise.
7564
7565 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7566
7567         Support style in 'frame|thread apply'
7568
7569         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7570         * record.c (record_start, record_stop): Update callers of
7571         execute_command_to_string with false.
7572         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7573         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7574         methods.
7575         (class string_file): New constructor with term_out parameter.
7576         Override methods term_out and can_emit_style_escape.  New member
7577         term_out.
7578         (class stdio_file): Override can_emit_style_escape.
7579         (class tee_file): Override term_out and can_emit_style_escape.
7580         * utils.h (can_emit_style_escape): Remove.
7581         * utils.c (can_emit_style_escape): Likewise.
7582         Update all callers of can_emit_style_escape (SOMESTREAM) to
7583         SOMESTREAM->can_emit_style_escape.
7584         * source-cache.c (source_cache::get_source_lines): Likewise.
7585         * stack.c (frame_apply_command_count): Call execute_command_to_string
7586         passing the term_out characteristic of the current gdb_stdout.
7587         * thread.c (thr_try_catch_cmd): Likewise.
7588         * top.c (execute_command_to_string): pass term_out parameter
7589         to construct the string_file for the command output.
7590         * ui-file.c (term_cli_styling): New function (most code moved
7591         from utils.c can_emit_style_escape).
7592         (string_file::string_file, string_file::can_emit_style_escape,
7593         stdio_file::can_emit_style_escape, tee_file::term_out,
7594         tee_file::can_emit_style_escape): New functions.
7595
7596 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7597
7598         * NEWS: Mention the new set|show may-call-functions.
7599         * infcall.c (may_call_functions_p): New variable.
7600         (show_may_call_functions_p): New function.
7601         (call_function_by_hand_dummy): Throws an error if not
7602         may-call-functions.
7603         (_initialize_infcall): Call add_setshow_boolean_cmd for
7604         may-call-functions.
7605
7606 2019-04-25  Keith Seitz  <keiths@redhat.com>
7607
7608         PR c++/24367
7609         * cp-support.c (inspect_type): Don't attempt substitutions
7610         of symbol with the same name.
7611
7612 2019-04-25  Tom Tromey  <tromey@adacore.com>
7613
7614         PR gdb/24475:
7615         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7616         static.
7617
7618 2019-04-25  Tom Tromey  <tromey@adacore.com>
7619
7620         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7621         rvalue reference.
7622         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7623         (gdb_xml_parser::parse): Use std::move.
7624         * python/python-internal.h (gdbpy_convert_exception): Take a const
7625         reference.
7626         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7627         std::move.
7628         * python/py-utils.c (gdbpy_convert_exception): Take a const
7629         reference.
7630         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7631         Use std::move.
7632         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7633         Use std::move.
7634         * mi/mi-main.c (mi_print_exception): Take a const reference.
7635         * main.c (handle_command_errors): Take a const reference.
7636         * linespec.c (parse_linespec): Use std::move.
7637         * infcall.c (run_inferior_call): Use std::move.
7638         (call_function_by_hand_dummy): Use std::move.
7639         * exec.c (try_open_exec_file): Use std::move.
7640         * exceptions.h (exception_print, exception_fprintf)
7641         (exception_print_same): Update.
7642         * exceptions.c (print_exception, exception_print)
7643         (exception_fprintf, exception_print_same): Change parameters to
7644         const reference.
7645         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7646         * common/new-op.c: Use std::move.
7647         * common/common-exceptions.h (struct gdb_exception): Add move
7648         constructor.
7649         (struct gdb_exception_error, struct gdb_exception_quit, struct
7650         gdb_quit_bad_alloc): Change constructor to move constructor.
7651         (throw_exception): Change parameter to rvalue reference.
7652         * common/common-exceptions.c (throw_exception): Take rvalue
7653         reference.
7654         * cli/cli-interp.c (safe_execute_command): Use std::move.
7655         * breakpoint.c (insert_bp_location, location_to_sals): Use
7656         std::move.
7657
7658 2019-04-25  Tom Tromey  <tromey@adacore.com>
7659
7660         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7661         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7662         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7663         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7664         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7665         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7666         guile/scm-value.c: Use unpack.
7667         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7668         gdbscm_gdb_exception.
7669         (gdbscm_throw_gdb_exception): Likewise.
7670         (struct gdbscm_gdb_exception): New.
7671         (unpack): New function.
7672         (gdbscm_wrap): Use unpack.
7673
7674 2019-04-25  Tom Tromey  <tromey@adacore.com>
7675
7676         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7677         (gdb_rl_callback_handler): Use std::move.
7678         * common/common-exceptions.h (struct gdb_exception): Add move
7679         assignment operator.
7680         (throw_exception_sjlj): Change "exception" to const reference.
7681         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7682         (throw_exception_sjlj): Change "exception" to const reference.
7683
7684 2019-04-25  Tom Tromey  <tromey@adacore.com>
7685
7686         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7687         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7688         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7689         Update.
7690         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7691         Update.
7692         * mi/mi-interp.c (mi_interp::exec): Update.
7693         * linespec.c (parse_linespec): Update.
7694         * infcall.c (run_inferior_call): Update.
7695         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7696         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7697         (gdbscm_lookup_global_symbol): Update.
7698         * guile/scm-param.c (gdbscm_parameter_value): Update.
7699         * guile/scm-frame.c (gdbscm_frame_read_register)
7700         (gdbscm_frame_read_var): Update.
7701         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7702         * exec.c (try_open_exec_file): Update.
7703         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7704         (gdb_rl_callback_handler): Update.
7705         * common/common-exceptions.h (exception_none): Don't declare.
7706         * common/common-exceptions.c (exception_none): Don't define.
7707         (struct catcher) <exception>: Update.
7708         * cli/cli-interp.c (safe_execute_command): Update.
7709         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7710
7711 2019-04-25  Ali Tamur  <tamur@google.com>
7712
7713         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7714         (read_attribute_value): Likewise.
7715         (dwarf2_read_addr_index): Update comment.
7716         (read_str_index): Add DW_FORM_strx.
7717         (dwarf2_string_attr): Likewise.
7718         (dwarf2_const_value_attr): Likewise.
7719         (dump_die_shallow): Likewise.
7720         (dwarf2_fetch_constant_bytes): Likewise.
7721         (skip_form_bytes): Likewise.
7722         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7723
7724 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7725
7726         PR corefiles/11608
7727         PR corefiles/18187
7728         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7729         OFFSET.  Verify if current mapping contains an ELF header.
7730         (linux_find_memory_regions_full): Adjust call to
7731         dump_mapping_p.
7732
7733 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7734             Kang Li <kanglictf@gmail.com>
7735
7736         PR gdb/21600
7737
7738         * dwarf2-frame.c (read_initial_length): Be consistent about using
7739         unsigned representation of length.
7740         (decode_frame_entry_1): Likewise.  Check for wraparound of
7741         end pointer as well as buffer overflow.
7742
7743 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7744
7745         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7746         "vq".
7747
7748 2019-04-24  Tom Tromey  <tromey@adacore.com>
7749
7750         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7751
7752 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7753
7754         * s12z-tdep.c (s12z_unwind_pc): Delete.
7755         (s12z_unwind_sp): Delete.
7756         (s12z_gdbarch_init): Don't register deleted functions with
7757         gdbarch.
7758
7759 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7760
7761         * rl78-tdep.c (rl78_unwind_sp): Delete.
7762         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7763
7764 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7765
7766         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7767         (xstormy16_unwind_pc): Delete.
7768         (xstormy16_dummy_id): Delete.
7769         (xstormy16_gdbarch_init): Don't register deleted functions with
7770         gdbarch.
7771
7772 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7773
7774         * vax-tdep.c (vax_unwind_pc): Delete.
7775         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7776
7777 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7778
7779         * v850-tdep.c (v850_unwind_sp): Delete.
7780         (v850_unwind_pc): Delete.
7781         (v850_dummy_id): Delete.
7782         (v850_gdbarch_init): Don't register deleted functions with
7783         gdbarch.
7784
7785 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7786
7787         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7788         (tilegx_unwind_pc): Delete.
7789         (tilegx_unwind_dummy_id): Delete.
7790         (tilegx_gdbarch_init): Don't register deleted functions with
7791         gdbarch.
7792
7793 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7794
7795         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7796         (tic6x_dummy_id): Delete.
7797         (tic6x_gdbarch_init): Don't register deleted functions with
7798         gdbarch.
7799
7800 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7801
7802         * sparc-tdep.c (sparc_unwind_pc): Delete.
7803         (sparc32_gdbarch_init): Don't register deleted function with
7804         gdbarch.
7805
7806 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7807
7808         * sh-tdep.c (sh_unwind_sp): Delete.
7809         (sh_unwind_pc): Delete.
7810         (sh_dummy_id): Delete.
7811         (sh_gdbarch_init): Don't register deleted functions with
7812         gdbarch.
7813
7814 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7815
7816         * score-tdep.c (score_unwind_sp): Delete.
7817         (score_unwind_pc): Delete.
7818         (score_dummy_id): Delete.
7819         (score_gdbarch_init): Don't register deleted functions with
7820         gdbarch.
7821
7822 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7823
7824         * rx-tdep.c (rx_unwind_pc): Delete.
7825         (rx_unwind_sp): Delete.
7826         (rx_dummy_id): Delete.
7827         (rx_gdbarch_init): Don't register deleted functions with
7828         gdbarch.  Update comment.
7829
7830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7831
7832         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7833         (rs6000_dummy_id): Delete.
7834         (rs6000_gdbarch_init): Don't register deleted functions with
7835         gdbarch.
7836
7837 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7838
7839         * or1k-tdep.c (or1k_dummy_id): Delete.
7840         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7841
7842 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7843
7844         * nios2-tdep.c (nios2_dummy_id): Delete.
7845         (nios2_unwind_sp): Delete.
7846         (nios2_gdbarch_init): Don't register deleted functions with
7847         gdbarch.
7848
7849 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7850
7851         * nds32-tdep.c (nds32_dummy_id): Delete.
7852         (nds32_unwind_pc): Delete.
7853         (nds32_unwind_sp): Delete.
7854         (nds32_gdbarch_init): Don't register deleted functions with
7855         gdbarch.
7856
7857 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7858
7859         * msp430-tdep.c (msp430_unwind_pc): Delete.
7860         (msp430_unwind_sp): Delete.
7861         (msp430_dummy_id): Delete.
7862         (msp430_gdbarch_init): Don't register deleted functions with
7863         gdbarch.
7864
7865 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7866
7867         * moxie-tdep.c (moxie_unwind_sp): Delete.
7868         (moxie_unwind_pc): Delete.
7869         (moxie_dummy_id): Delete.
7870         (moxie_gdbarch_init): Don't register deleted functions with
7871         gdbarch.
7872
7873 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7874
7875         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7876         (mn10300_unwind_pc): Delete.
7877         (mn10300_unwind_sp): Delete.
7878         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7879         mn10300_unwind_sp.
7880         (mn10300_frame_unwind_init): Don't register deleted functions with
7881         gdbarch.
7882
7883 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7884
7885         * mep-tdep.c (mep_unwind_pc): Delete.
7886         (mep_unwind_sp): Delete.
7887         (mep_dummy_id): Delete.
7888         (mep_gdbarch_init): Don't register deleted functions with
7889         gdbarch.
7890
7891 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7892
7893         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7894         (m68hc11_unwind_sp): Delete.
7895         (m68hc11_gdbarch_init): Don't register deleted functions with
7896         gdbarch.
7897
7898 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7899
7900         * m32r-tdep.c (m32r_unwind_sp): Delete.
7901         (m32r_unwind_pc): Delete.
7902         (m32r_dummy_id): Delete.
7903         (m32r_gdbarch_init): Don't register deleted functions with
7904         gdbarch.
7905
7906 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7907
7908         * m32c-tdep.c (m32c_unwind_pc): Delete.
7909         (m32c_unwind_sp): Delete.
7910         (m32c_dummy_id): Delete.
7911         (m32c_gdbarch_init): Don't register deleted functions with
7912         gdbarch.
7913
7914 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7915
7916         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7917         (lm32_unwind_pc): Delete.
7918         (lm32_dummy_id): Delete.
7919         (lm32_gdbarch_init): Don't register deleted functions with
7920         gdbarch.
7921
7922 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7923
7924         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7925         (iq2000_unwind_pc): Delete.
7926         (iq2000_dummy_id): Delete.
7927         (iq2000_gdbarch_init): Don't register deleted functions with
7928         gdbarch.
7929
7930 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7931
7932         * nds32-tdep.c (nds32_type_align): Delete.
7933         (nds32_push_dummy_call): Use type_align instead.
7934
7935 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7936
7937         * arm-tdep.c (arm_type_align): Only handle vector override case.
7938         (arm_push_dummy_call): Use type_align.
7939         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7940
7941 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7942
7943         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7944         case.
7945         (pass_on_stack): Use type_align.
7946         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7947         function.
7948
7949 2019-04-23  Tom Tromey  <tromey@adacore.com>
7950
7951         * dwarf2read.c (line_header::file_name_at): Remove unused
7952         overload.
7953
7954 2019-04-23  Tom de Vries  <tdevries@suse.de>
7955
7956         PR gdb/24438
7957         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7958         invocation.
7959
7960
7961 2019-03-27  Ali Tamur  <tamur@google.com>
7962
7963         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7964         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7965         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7966         (dwarf_expr_context::get_addr_index): Likewise
7967         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7968         (symbol_needs_eval_context::get_addr_index): Likewise
7969         (disassemble_dwarf_expression): Add DW_OP_addrx
7970         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7971         (read_cutu_die_from_dwo): Update comment
7972         (skip_one_die): Add DW_FORM_addrx
7973         (read_attribute_value): Likewise
7974         (var_decode_location): Add DW_OP_addrx
7975         (dwarf2_const_value_attr): Add DW_FORM_addrx
7976         (dump_die_shallow): Likewise
7977         (dwarf2_fetch_constant_bytes): Likewise
7978         (decode_locdesc): Add DW_OP_addrx
7979         (skip_form_bytes): Add DW_FORM_addrx
7980
7981 2019-04-22  Ali Tamur  <tamur@google.com>
7982
7983         * MAINTAINERS (Write After Approval): Add self.
7984
7985 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7986
7987         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7988         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7989         (open_symbol_file_object): Likewise.
7990         (svr4_default_sos): Add info parameter.
7991         (svr4_read_so_list): Likewise.
7992         (svr4_current_sos_direct): Adjust functions calls to pass down
7993         info.
7994         (svr4_current_sos_1): Add info parameter.
7995         (svr4_current_sos): Call get_svr4_info, pass info down to
7996         svr4_current_sos_1.
7997         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7998         get_svr4_info.
7999         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8000         get_svr4_info.
8001         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8002         to get_svr4_info.
8003         (probes_table_remove_objfile_probes): Likewise.
8004         (register_solib_event_probe): Add info parameter.
8005         (solist_update_incremental): Pass info parameter down to
8006         svr4_read_so_list.
8007         (disable_probes_interface): Add info parameter.
8008         (svr4_handle_solib_event): Pass current_program_space to
8009         get_svr4_info.  Adjust disable_probes_interface cleanup.
8010         (svr4_create_probe_breakpoints): Add info parameter, pass it
8011         down to register_solib_event_probe.
8012         (svr4_create_solib_event_breakpoints): Add info parameter,
8013         pass it down to svr4_create_probe_breakpoints.
8014         (enable_break): Pass info down to
8015         svr4_create_solib_event_breakpoints.
8016         (svr4_solib_create_inferior_hook): Pass current_program_space to
8017         get_svr4_info.
8018         (svr4_clear_solib): Likewise.
8019
8020 2019-04-22  Pedro Alves  <palves@redhat.com>
8021
8022         * solib-svr4.c (svr4_free_objfile_observer): New.
8023         (probe_and_action::objfile): New field.
8024         (probes_table_htab_remove_objfile_probes)
8025         (probes_table_remove_objfile_probes): New functions.
8026         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8027         in the new probe_and_action.  Don't store the probe in 'lookup'.
8028         (svr4_create_probe_breakpoints): Pass objfile to
8029         register_solib_event_probe.
8030         (_initialize_svr4_solib): Register a free_objfile observer.
8031
8032 2019-04-19  Tom Tromey  <tom@tromey.com>
8033
8034         * common/queue.h: Remove.
8035
8036 2019-04-19  Tom Tromey  <tom@tromey.com>
8037
8038         * event-loop.c: Don't include "common/queue.h".
8039
8040 2019-04-19  Tom Tromey  <tom@tromey.com>
8041
8042         * remote.c (remote_target): Use delete.
8043         * remote-notif.h: Include <list>, not "common/queue.h".
8044         (notif_client_p): Remove typedef.
8045         (remote_notif_state): Add constructor, destructor, initializer.
8046         <notif_queue>: Now a std::list.
8047         (remote_notif_state_xfree): Don't declare.
8048         * remote-notif.c (remote_notif_process, handle_notification)
8049         (remote_notif_state_allocate): Update.
8050         (~remote_notif_state): Rename from remote_notif_state_xfree.
8051
8052 2019-04-19  Tom Tromey  <tom@tromey.com>
8053
8054         * symfile.c (reread_symbols): Update.
8055         * objfiles.c (objfile_register_static_link)
8056         (objfile_lookup_static_link): Update
8057         (~objfile) Don't delete static_links.
8058         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8059
8060 2019-04-19  Tom Tromey  <tom@tromey.com>
8061
8062         * type-stack.h (struct type_stack) <insert>: Constify string.
8063         * type-stack.c (type_stack::insert): Constify string.
8064         * gdbtypes.h (lookup_template_type): Update.
8065         (address_space_name_to_int): Update.
8066         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8067         const.
8068         (lookup_template_type): Make name const.
8069         * c-exp.y: Update rules.
8070         (lex_one_token, classify_name, classify_inner_name)
8071         (c_print_token): Update.
8072         * p-exp.y: Update rules.
8073         (yylex): Update.
8074         * f-exp.y: Update rules.
8075         (yylex): Update.
8076         * d-exp.y: Update rules.
8077         (lex_one_token, classify_name, classify_inner_name): Update.
8078         * parse.c (write_dollar_variable, copy_name): Return std::string.
8079         * parser-defs.h (copy_name): Change return type.
8080         * m2-exp.y: Update rules.
8081         (yylex): Update.
8082         * go-exp.y (lex_one_token): Update.
8083         Update rules.
8084         (classify_unsafe_function, classify_packaged_name)
8085         (classify_name, yylex): Update.
8086
8087 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8088
8089         * configure.ac: add --enable-source-highlight switch.
8090         * configure: Regenerate.
8091         * top.c (print_gdb_version): plumb --enable-source-highlight
8092         status to "show configuration".
8093
8094 2019-04-19  Tom Tromey  <tromey@adacore.com>
8095
8096         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8097         Check ADA_TYPE_P.
8098         (empty_record, ada_template_to_fixed_record_type_1)
8099         (template_to_static_fixed_type)
8100         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8101         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8102         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8103         macros.
8104
8105 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8106
8107         PR symtab/24423:
8108         * source.c (print_source_lines_base): Advance "iter" when a
8109         control character is seen.
8110
8111 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8112
8113         * inferior.h (struct infcall_suspend_state_deleter):
8114         Catch exception in destructor to avoid crash.
8115
8116 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8117
8118         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8119         close to the add_com "shell".
8120
8121 2019-04-18  Tom Tromey  <tromey@adacore.com>
8122
8123         * process-stratum-target.h (class process_stratum_target)
8124         <stratum>: Add "final".
8125
8126 2019-04-17  Tom Tromey  <tromey@adacore.com>
8127
8128         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8129         against nullptr before use.
8130
8131 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8132
8133         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8134
8135 2019-04-17  Jim Wilson  <jimw@sifive.com>
8136             Andrew Burgess  <andrew.burgess@embecosm.com>
8137
8138         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8139         code read might fail, assume 4-byte breakpoint in that case.
8140
8141 2019-04-15  Leszek Swirski  <leszeks@google.com>
8142
8143         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8144         rather than a hand-rolled POD check when checking for forced MEMORY
8145         classification.
8146
8147 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8148
8149         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8150         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8151         function.
8152         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8153         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8154         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8155         declaration.
8156
8157 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8158
8159         * aarch64-linux-nat.c
8160         (aarch64_linux_nat_target::thread_architecture): Add override.
8161         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8162         each VQ.
8163
8164 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8165
8166         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8167
8168 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8169
8170         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8171         target types of size 96-bits, add some additional comments, and
8172         check that the builtin type we found was the correct size.
8173
8174 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8175
8176         * utils.c (prompt_for_continue): Don't restore the styling at the
8177         end, as applied_style has the wrong value.  This fixes styling in
8178         long lists of file names that are interrupted by the "Continue?"
8179         prompt.
8180
8181 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8182
8183         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8184         * c-lang.c (c_language_defn): Likewise.
8185         (cplus_language_defn): Likewise.
8186         (asm_language_defn): Likewise.
8187         (minimal_language_defn): Likewise.
8188         * d-lang.c (d_language_defn): Likewise.
8189         * f-lang.c (f_language_defn): Likewise.
8190         * go-lang.c (go_language_defn): Likewise.
8191         * language.c (unknown_language_defn): Likewise.
8192         (auto_language_defn): Likewise.
8193         * language.h (struct language_defn): Remove la_magic field.
8194         (LANG_MAGIC): Delete.
8195         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8196         * objc-lang.c (objc_language_defn): Likewise.
8197         * opencl-lang.c (opencl_language_defn): Likewise.
8198         * p-lang.c (pascal_language_defn): Likewise.
8199         * rust-lang.c (rust_language_defn): Likewise.
8200
8201 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8202
8203         * riscv-tdep.c (riscv_type_align): New function.
8204         (riscv_type_alignment): Delete.
8205         (riscv_arg_location): Use 'type_align'.
8206         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8207
8208 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8209
8210         * gdbtypes.c (type_align): A struct with no non-static fields also
8211         has alignment of 1.
8212
8213 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8214
8215         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8216         component to 0.
8217         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8218         member.
8219         (riscv_struct_info::analyse): New implementation using new
8220         analyse_inner member function.
8221         (riscv_struct_info::field_offset): New member function.
8222         (riscv_struct_info::m_offsets): New member variable.
8223         (riscv_struct_info::analyse_inner): New private member function,
8224         takes the old implementation of riscv_struct_info::analyse but
8225         extended to track field offsets.
8226         (riscv_call_arg_struct): Update the struct folding special cases
8227         to handle cases where empty C++ structs, which are non-zero
8228         length, are found.
8229         (riscv_arg_location): Initialise the length of each location, a
8230         non-zero length now indicates the location is in use.
8231         (riscv_push_dummy_call): Allow for the first location having a
8232         non-zero offset when setting up arguments.
8233         (riscv_return_value): Likewise, but for return values.
8234
8235 2019-04-11  Tom Tromey  <tromey@adacore.com>
8236
8237         * utils.c (internal_vproblem): Make "msg" const.
8238
8239 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8240
8241         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8242         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8243         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8244         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8245
8246 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8247
8248         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8249         function.
8250         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8251         of amd64_collect_native_gregset.
8252         (amd64_linux_nat_target::store_registers): Likewise.
8253
8254 2019-04-10  Tom Tromey  <tom@tromey.com>
8255
8256         * symtab.c (lookup_global_symbol_from_objfile)
8257         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8258         * objfiles.h (class separate_debug_iterator): New.
8259         (class separate_debug_range): New.
8260         (struct objfile) <separate_debug_objfiles>: New method.
8261         (objfile_separate_debug_iterate): Don't declare.
8262         * objfiles.c (separate_debug_iterator::operator++): Rename from
8263         objfile_separate_debug_iterate.
8264         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8265         iterator.
8266         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8267         iterator.
8268
8269 2019-04-10  Tom Tromey  <tom@tromey.com>
8270
8271         * symfile.c (reread_symbols): Remove old comment.
8272         * objfiles.c (free_all_objfiles): Fix a typo.
8273
8274 2019-04-10  Tom Tromey  <tom@tromey.com>
8275
8276         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8277         * minsyms.c (lookup_minimal_symbol): Use foreach.
8278         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8279         (lookup_minimal_symbol_solib_trampoline): Likewise.
8280         * symfile.c (reread_symbols): Use foreach.
8281
8282 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8283             Tom Tromey  <tromey@adacore.com>
8284
8285         PR rust/24414:
8286         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8287         (rust_lex_int_test): Change "value" to be LONGEST.
8288         (rust_lex_tests): Add test for long integer literal.
8289
8290 2019-04-09  Tom Tromey  <tromey@adacore.com>
8291
8292         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8293         to bool.
8294         (extended_remote_target::attach): Update.
8295         (remote_target::remote_notice_new_inferior): Update.
8296         (remote_target::add_current_inferior_and_thread): Update.
8297         * inferior.c (exit_inferior_1): Use "false".
8298         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8299
8300 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8301
8302         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8303         the "start" command.
8304
8305 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8306
8307         * python/py-inferior.c (infpy_thread_from_thread_handle):
8308         Adjust comments to reflect renaming of thread_from_thread_handle
8309         to thread_from_handle.  Adjust keywords.  Fix type error message.
8310         (inferior_object_methods): Add thread_from_handle.  Retain
8311         thread_from_thread_handle, but mark it as deprecated.
8312
8313 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8314
8315         * gdbthread.h (find_thread_by_handle): Revise declaration.
8316         * thread.c (find_thread_by_handle): Likewise.  Adjust
8317         implementation too.
8318         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8319         support for buffer objects as handles.
8320
8321 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8322
8323         * python/py-infthread.c (thpy_thread_handle): New function.
8324         (thread_object_methods): Register thpy_thread_handle.
8325
8326 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8327
8328         * gdbthread.h (thread_to_thread_handle): Declare.
8329         * thread.c (gdbtypes.h): Include.
8330         (thread_to_thread_handle): New function.
8331
8332         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8333         (target_thread_info_to_thread_handle): Declare.
8334         * target.c (target_thread_info_to_thread_handle): New function.
8335         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8336         * target-delegates.c: Regenerate.
8337
8338         * linux-thread-db.c (class thread_db_target): Add method
8339         thread_info_to_thread_handle.
8340         (thread_db_target::thread_info_to_thread_handle): Define.
8341         * remote.c (class remote_target): Add new method
8342         thread_info_to_thread_handle.
8343         (remote_target::thread_info_to_thread_handle): Define.
8344
8345 2019-04-08  Pedro Alves  <palves@redhat.com>
8346
8347         * common/common-exceptions.c (throw_exception): Don't create
8348         named object to throw; throw directly.
8349         (throw_it): Likewise.  Don't initialize gdb_exception::message
8350         here, with new; pass FMT and AP to the ctor instead.
8351         * common/common-exceptions.h: Include <string>.
8352         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8353         const char *, va_list)): New ctor.  Use std::make_shared.
8354         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8355         errors)): Delete.
8356         (gdb_exception_error::gdb_exception_error(enum errors, const char
8357         *, va_list)): New.
8358         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8359         Add assertion.
8360         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8361         errors)): Delete.
8362         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8363         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8364         Add assertion.
8365
8366 2019-04-08  Tom Tromey  <tom@tromey.com>
8367
8368         * valops.c (value_rtti_indirect_type): Replace throw_exception
8369         with throw.
8370         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8371         with throw.
8372         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8373         throw.
8374         * target.c (target_translate_tls_address): Replace throw_exception
8375         with throw.
8376         * stack.c (frame_apply_command_count): Replace throw_exception
8377         with throw.
8378         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8379         throw.
8380         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8381         with throw.
8382         * rs6000-tdep.c (rs6000_frame_cache)
8383         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8384         * remote.c: Replace throw_exception with throw.
8385         * record-full.c (record_full_message, record_full_wait_1)
8386         (record_full_restore): Replace throw_exception with throw.
8387         * record-btrace.c:
8388         (get_thread_current_frame_id, record_btrace_start_replaying)
8389         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8390         (cmd_record_btrace_start): Replace throw_exception with throw.
8391         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8392         throw.
8393         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8394         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8395         * linespec.c:
8396         (find_linespec_symbols): Replace throw_exception with throw.
8397         * infrun.c (displaced_step_prepare, resume): Replace
8398         throw_exception with throw.
8399         * infcmd.c (post_create_inferior): Replace throw_exception with
8400         throw.
8401         * inf-loop.c (inferior_event_handler): Replace throw_exception
8402         with throw.
8403         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8404         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8405         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8406         (get_prev_frame_always, get_frame_pc_if_available)
8407         (get_frame_address_in_block_if_available, get_frame_language):
8408         Replace throw_exception with throw.
8409         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8410         throw_exception with throw.
8411         * eval.c (fetch_subexp_value, evaluate_var_value)
8412         (evaluate_funcall, evaluate_subexp_standard): Replace
8413         throw_exception with throw.
8414         * dwarf2loc.c (call_site_find_chain)
8415         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8416         Replace throw_exception with throw.
8417         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8418         with throw.
8419         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8420         throw.
8421         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8422         * completer.c (complete_line_internal): Replace throw_exception
8423         with throw.
8424         * compile/compile-object-run.c (compile_object_run): Replace
8425         throw_exception with throw.
8426         * cli/cli-script.c (process_next_line): Replace throw_exception
8427         with throw.
8428         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8429         (btrace_enable, btrace_maint_update_pt_packets): Replace
8430         throw_exception with throw.
8431         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8432         throw_exception with throw.
8433         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8434         throw_exception with throw.
8435         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8436         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8437         * aarch64-tdep.c (aarch64_make_prologue_cache)
8438         (aarch64_make_stub_cache): Replace throw_exception with throw.
8439
8440 2019-04-08  Tom Tromey  <tom@tromey.com>
8441
8442         * common/common-exceptions.c (throw_exception): Rename from
8443         throw_exception_cxx.  Remove old copy.  Make argument const.
8444         (throw_it): Create and throw exception objects directly.
8445         * common/common-exceptions.h (throw_exception): Make argument
8446         const.
8447         (struct gdb_exception_error): Add constructor.
8448         (struct gdb_exception_quit): Add constructor.
8449
8450 2019-04-08  Tom Tromey  <tom@tromey.com>
8451
8452         * common/common-exceptions.h (exception_rethrow): Don't declare.
8453         (TRY_SJLJ): Update comment.
8454         (TRY, CATCH, END_CATCH): Remove.
8455         * common/common-exceptions.c (exception_rethrow): Remove.
8456
8457 2019-04-08  Tom Tromey  <tom@tromey.com>
8458
8459         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8460         Remove.
8461         (gdb_exception_error): Rename from
8462         gdb_exception_RETURN_MASK_ERROR.
8463         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8464         (gdb_quit_bad_alloc): Update.
8465         * aarch64-tdep.c: Update.
8466         * ada-lang.c: Update.
8467         * ada-typeprint.c: Update.
8468         * ada-valprint.c: Update.
8469         * amd64-tdep.c: Update.
8470         * arch-utils.c: Update.
8471         * break-catch-throw.c: Update.
8472         * breakpoint.c: Update.
8473         * btrace.c: Update.
8474         * c-varobj.c: Update.
8475         * cli/cli-cmds.c: Update.
8476         * cli/cli-interp.c: Update.
8477         * cli/cli-script.c: Update.
8478         * common/common-exceptions.c: Update.
8479         * common/new-op.c: Update.
8480         * common/selftest.c: Update.
8481         * compile/compile-c-symbols.c: Update.
8482         * compile/compile-cplus-symbols.c: Update.
8483         * compile/compile-object-load.c: Update.
8484         * compile/compile-object-run.c: Update.
8485         * completer.c: Update.
8486         * corelow.c: Update.
8487         * cp-abi.c: Update.
8488         * cp-support.c: Update.
8489         * cp-valprint.c: Update.
8490         * darwin-nat.c: Update.
8491         * disasm-selftests.c: Update.
8492         * dtrace-probe.c: Update.
8493         * dwarf-index-cache.c: Update.
8494         * dwarf-index-write.c: Update.
8495         * dwarf2-frame-tailcall.c: Update.
8496         * dwarf2-frame.c: Update.
8497         * dwarf2loc.c: Update.
8498         * dwarf2read.c: Update.
8499         * eval.c: Update.
8500         * event-loop.c: Update.
8501         * event-top.c: Update.
8502         * exec.c: Update.
8503         * f-valprint.c: Update.
8504         * fbsd-tdep.c: Update.
8505         * frame-unwind.c: Update.
8506         * frame.c: Update.
8507         * gdbtypes.c: Update.
8508         * gnu-v3-abi.c: Update.
8509         * guile/guile-internal.h: Update.
8510         * guile/scm-block.c: Update.
8511         * guile/scm-breakpoint.c: Update.
8512         * guile/scm-cmd.c: Update.
8513         * guile/scm-disasm.c: Update.
8514         * guile/scm-frame.c: Update.
8515         * guile/scm-lazy-string.c: Update.
8516         * guile/scm-math.c: Update.
8517         * guile/scm-param.c: Update.
8518         * guile/scm-ports.c: Update.
8519         * guile/scm-pretty-print.c: Update.
8520         * guile/scm-symbol.c: Update.
8521         * guile/scm-symtab.c: Update.
8522         * guile/scm-type.c: Update.
8523         * guile/scm-value.c: Update.
8524         * i386-linux-tdep.c: Update.
8525         * i386-tdep.c: Update.
8526         * inf-loop.c: Update.
8527         * infcall.c: Update.
8528         * infcmd.c: Update.
8529         * infrun.c: Update.
8530         * jit.c: Update.
8531         * language.c: Update.
8532         * linespec.c: Update.
8533         * linux-fork.c: Update.
8534         * linux-nat.c: Update.
8535         * linux-tdep.c: Update.
8536         * linux-thread-db.c: Update.
8537         * main.c: Update.
8538         * mi/mi-cmd-break.c: Update.
8539         * mi/mi-cmd-stack.c: Update.
8540         * mi/mi-interp.c: Update.
8541         * mi/mi-main.c: Update.
8542         * objc-lang.c: Update.
8543         * p-valprint.c: Update.
8544         * parse.c: Update.
8545         * ppc-linux-tdep.c: Update.
8546         * printcmd.c: Update.
8547         * python/py-arch.c: Update.
8548         * python/py-breakpoint.c: Update.
8549         * python/py-cmd.c: Update.
8550         * python/py-finishbreakpoint.c: Update.
8551         * python/py-frame.c: Update.
8552         * python/py-framefilter.c: Update.
8553         * python/py-gdb-readline.c: Update.
8554         * python/py-inferior.c: Update.
8555         * python/py-infthread.c: Update.
8556         * python/py-lazy-string.c: Update.
8557         * python/py-linetable.c: Update.
8558         * python/py-objfile.c: Update.
8559         * python/py-param.c: Update.
8560         * python/py-prettyprint.c: Update.
8561         * python/py-progspace.c: Update.
8562         * python/py-record-btrace.c: Update.
8563         * python/py-record.c: Update.
8564         * python/py-symbol.c: Update.
8565         * python/py-type.c: Update.
8566         * python/py-unwind.c: Update.
8567         * python/py-utils.c: Update.
8568         * python/py-value.c: Update.
8569         * python/python.c: Update.
8570         * record-btrace.c: Update.
8571         * record-full.c: Update.
8572         * remote-fileio.c: Update.
8573         * remote.c: Update.
8574         * riscv-tdep.c: Update.
8575         * rs6000-aix-tdep.c: Update.
8576         * rs6000-tdep.c: Update.
8577         * rust-exp.y: Update.
8578         * rust-lang.c: Update.
8579         * s390-tdep.c: Update.
8580         * selftest-arch.c: Update.
8581         * solib-dsbt.c: Update.
8582         * solib-frv.c: Update.
8583         * solib-spu.c: Update.
8584         * solib-svr4.c: Update.
8585         * solib.c: Update.
8586         * sparc64-linux-tdep.c: Update.
8587         * stack.c: Update.
8588         * symfile-mem.c: Update.
8589         * symmisc.c: Update.
8590         * target.c: Update.
8591         * thread.c: Update.
8592         * top.c: Update.
8593         * tracefile-tfile.c: Update.
8594         * tui/tui.c: Update.
8595         * typeprint.c: Update.
8596         * unittests/cli-utils-selftests.c: Update.
8597         * unittests/parse-connection-spec-selftests.c: Update.
8598         * valops.c: Update.
8599         * valprint.c: Update.
8600         * value.c: Update.
8601         * varobj.c: Update.
8602         * windows-nat.c: Update.
8603         * x86-linux-nat.c: Update.
8604         * xml-support.c: Update.
8605
8606 2019-04-08  Tom Tromey  <tom@tromey.com>
8607
8608         * xml-support.c: Use C++ exception handling.
8609         * x86-linux-nat.c: Use C++ exception handling.
8610         * windows-nat.c: Use C++ exception handling.
8611         * varobj.c: Use C++ exception handling.
8612         * value.c: Use C++ exception handling.
8613         * valprint.c: Use C++ exception handling.
8614         * valops.c: Use C++ exception handling.
8615         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8616         handling.
8617         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8618         * typeprint.c: Use C++ exception handling.
8619         * tui/tui.c: Use C++ exception handling.
8620         * tracefile-tfile.c: Use C++ exception handling.
8621         * top.c: Use C++ exception handling.
8622         * thread.c: Use C++ exception handling.
8623         * target.c: Use C++ exception handling.
8624         * symmisc.c: Use C++ exception handling.
8625         * symfile-mem.c: Use C++ exception handling.
8626         * stack.c: Use C++ exception handling.
8627         * sparc64-linux-tdep.c: Use C++ exception handling.
8628         * solib.c: Use C++ exception handling.
8629         * solib-svr4.c: Use C++ exception handling.
8630         * solib-spu.c: Use C++ exception handling.
8631         * solib-frv.c: Use C++ exception handling.
8632         * solib-dsbt.c: Use C++ exception handling.
8633         * selftest-arch.c: Use C++ exception handling.
8634         * s390-tdep.c: Use C++ exception handling.
8635         * rust-lang.c: Use C++ exception handling.
8636         * rust-exp.y: Use C++ exception handling.
8637         * rs6000-tdep.c: Use C++ exception handling.
8638         * rs6000-aix-tdep.c: Use C++ exception handling.
8639         * riscv-tdep.c: Use C++ exception handling.
8640         * remote.c: Use C++ exception handling.
8641         * remote-fileio.c: Use C++ exception handling.
8642         * record-full.c: Use C++ exception handling.
8643         * record-btrace.c: Use C++ exception handling.
8644         * python/python.c: Use C++ exception handling.
8645         * python/py-value.c: Use C++ exception handling.
8646         * python/py-utils.c: Use C++ exception handling.
8647         * python/py-unwind.c: Use C++ exception handling.
8648         * python/py-type.c: Use C++ exception handling.
8649         * python/py-symbol.c: Use C++ exception handling.
8650         * python/py-record.c: Use C++ exception handling.
8651         * python/py-record-btrace.c: Use C++ exception handling.
8652         * python/py-progspace.c: Use C++ exception handling.
8653         * python/py-prettyprint.c: Use C++ exception handling.
8654         * python/py-param.c: Use C++ exception handling.
8655         * python/py-objfile.c: Use C++ exception handling.
8656         * python/py-linetable.c: Use C++ exception handling.
8657         * python/py-lazy-string.c: Use C++ exception handling.
8658         * python/py-infthread.c: Use C++ exception handling.
8659         * python/py-inferior.c: Use C++ exception handling.
8660         * python/py-gdb-readline.c: Use C++ exception handling.
8661         * python/py-framefilter.c: Use C++ exception handling.
8662         * python/py-frame.c: Use C++ exception handling.
8663         * python/py-finishbreakpoint.c: Use C++ exception handling.
8664         * python/py-cmd.c: Use C++ exception handling.
8665         * python/py-breakpoint.c: Use C++ exception handling.
8666         * python/py-arch.c: Use C++ exception handling.
8667         * printcmd.c: Use C++ exception handling.
8668         * ppc-linux-tdep.c: Use C++ exception handling.
8669         * parse.c: Use C++ exception handling.
8670         * p-valprint.c: Use C++ exception handling.
8671         * objc-lang.c: Use C++ exception handling.
8672         * mi/mi-main.c: Use C++ exception handling.
8673         * mi/mi-interp.c: Use C++ exception handling.
8674         * mi/mi-cmd-stack.c: Use C++ exception handling.
8675         * mi/mi-cmd-break.c: Use C++ exception handling.
8676         * main.c: Use C++ exception handling.
8677         * linux-thread-db.c: Use C++ exception handling.
8678         * linux-tdep.c: Use C++ exception handling.
8679         * linux-nat.c: Use C++ exception handling.
8680         * linux-fork.c: Use C++ exception handling.
8681         * linespec.c: Use C++ exception handling.
8682         * language.c: Use C++ exception handling.
8683         * jit.c: Use C++ exception handling.
8684         * infrun.c: Use C++ exception handling.
8685         * infcmd.c: Use C++ exception handling.
8686         * infcall.c: Use C++ exception handling.
8687         * inf-loop.c: Use C++ exception handling.
8688         * i386-tdep.c: Use C++ exception handling.
8689         * i386-linux-tdep.c: Use C++ exception handling.
8690         * guile/scm-value.c: Use C++ exception handling.
8691         * guile/scm-type.c: Use C++ exception handling.
8692         * guile/scm-symtab.c: Use C++ exception handling.
8693         * guile/scm-symbol.c: Use C++ exception handling.
8694         * guile/scm-pretty-print.c: Use C++ exception handling.
8695         * guile/scm-ports.c: Use C++ exception handling.
8696         * guile/scm-param.c: Use C++ exception handling.
8697         * guile/scm-math.c: Use C++ exception handling.
8698         * guile/scm-lazy-string.c: Use C++ exception handling.
8699         * guile/scm-frame.c: Use C++ exception handling.
8700         * guile/scm-disasm.c: Use C++ exception handling.
8701         * guile/scm-cmd.c: Use C++ exception handling.
8702         * guile/scm-breakpoint.c: Use C++ exception handling.
8703         * guile/scm-block.c: Use C++ exception handling.
8704         * guile/guile-internal.h: Use C++ exception handling.
8705         * gnu-v3-abi.c: Use C++ exception handling.
8706         * gdbtypes.c: Use C++ exception handling.
8707         * frame.c: Use C++ exception handling.
8708         * frame-unwind.c: Use C++ exception handling.
8709         * fbsd-tdep.c: Use C++ exception handling.
8710         * f-valprint.c: Use C++ exception handling.
8711         * exec.c: Use C++ exception handling.
8712         * event-top.c: Use C++ exception handling.
8713         * event-loop.c: Use C++ exception handling.
8714         * eval.c: Use C++ exception handling.
8715         * dwarf2read.c: Use C++ exception handling.
8716         * dwarf2loc.c: Use C++ exception handling.
8717         * dwarf2-frame.c: Use C++ exception handling.
8718         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8719         * dwarf-index-write.c: Use C++ exception handling.
8720         * dwarf-index-cache.c: Use C++ exception handling.
8721         * dtrace-probe.c: Use C++ exception handling.
8722         * disasm-selftests.c: Use C++ exception handling.
8723         * darwin-nat.c: Use C++ exception handling.
8724         * cp-valprint.c: Use C++ exception handling.
8725         * cp-support.c: Use C++ exception handling.
8726         * cp-abi.c: Use C++ exception handling.
8727         * corelow.c: Use C++ exception handling.
8728         * completer.c: Use C++ exception handling.
8729         * compile/compile-object-run.c: Use C++ exception handling.
8730         * compile/compile-object-load.c: Use C++ exception handling.
8731         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8732         * compile/compile-c-symbols.c: Use C++ exception handling.
8733         * common/selftest.c: Use C++ exception handling.
8734         * common/new-op.c: Use C++ exception handling.
8735         * cli/cli-script.c: Use C++ exception handling.
8736         * cli/cli-interp.c: Use C++ exception handling.
8737         * cli/cli-cmds.c: Use C++ exception handling.
8738         * c-varobj.c: Use C++ exception handling.
8739         * btrace.c: Use C++ exception handling.
8740         * breakpoint.c: Use C++ exception handling.
8741         * break-catch-throw.c: Use C++ exception handling.
8742         * arch-utils.c: Use C++ exception handling.
8743         * amd64-tdep.c: Use C++ exception handling.
8744         * ada-valprint.c: Use C++ exception handling.
8745         * ada-typeprint.c: Use C++ exception handling.
8746         * ada-lang.c: Use C++ exception handling.
8747         * aarch64-tdep.c: Use C++ exception handling.
8748
8749 2019-04-08  Tom Tromey  <tom@tromey.com>
8750
8751         * xml-support.c (gdb_xml_parser::parse): Update.
8752         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8753         * value.c (show_convenience): Update.
8754         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8755         (test_parse_flags_qcs): Update.
8756         * thread.c (thr_try_catch_cmd): Update.
8757         * target.c (target_translate_tls_address): Update.
8758         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8759         (info_frame_command_core, frame_apply_command_count): Update.
8760         * rust-exp.y (rust_lex_exception_test): Update.
8761         * riscv-tdep.c (riscv_print_one_register_info): Update.
8762         * remote.c (remote_target::enable_btrace): Update.
8763         * record-btrace.c (record_btrace_enable_warn): Update.
8764         * python/py-utils.c (gdbpy_convert_exception): Update.
8765         * printcmd.c (do_one_display, print_variable_and_value): Update.
8766         * mi/mi-main.c (mi_print_exception): Update.
8767         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8768         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8769         * linux-nat.c (linux_nat_target::attach): Update.
8770         * linux-fork.c (class scoped_switch_fork_info): Update.
8771         * infrun.c (displaced_step_prepare): Update.
8772         * infcall.c (call_function_by_hand_dummy): Update.
8773         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8774         * gnu-v3-abi.c (print_one_vtable): Update.
8775         * frame.c (get_prev_frame_always): Update.
8776         * f-valprint.c (info_common_command_for_block): Update.
8777         * exec.c (try_open_exec_file): Update.
8778         * exceptions.c (print_exception, exception_print)
8779         (exception_fprintf, exception_print_same): Update.
8780         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8781         * dwarf-index-cache.c (index_cache::store)
8782         (index_cache::lookup_gdb_index): Update.
8783         * darwin-nat.c (maybe_cache_shell): Update.
8784         * cp-valprint.c (cp_print_value_fields): Update.
8785         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8786         (gcc_cplus_symbol_address): Update.
8787         * compile/compile-c-symbols.c (gcc_convert_symbol)
8788         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8789         * common/selftest.c: Update.
8790         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8791         a std::string.
8792         (exception_try_scope_entry, exception_try_scope_exit): Don't
8793         declare.
8794         (struct exception_try_scope): Remove.
8795         (TRY): Don't use exception_try_scope.
8796         (struct gdb_exception): Add constructor, operator=.
8797         <what>: New method.
8798         (struct gdb_exception_RETURN_MASK_ALL)
8799         (struct gdb_exception_RETURN_MASK_ERROR)
8800         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8801         (struct gdb_quit_bad_alloc): Update.
8802         * common/common-exceptions.c (exception_none): Change
8803         initializer.
8804         (struct catcher) <state, exception>: Initialize inline.
8805         <prev>: Remove member.
8806         (current_catcher): Remove.
8807         (catchers): New global.
8808         (exceptions_state_mc_init): Simplify.
8809         (catcher_pop): Remove.
8810         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8811         (try_scope_depth, exception_try_scope_entry)
8812         (exception_try_scope_exit): Remove.
8813         (throw_exception_sjlj): Update.
8814         (exception_messages, exception_messages_size): Remove.
8815         (throw_it): Simplify.
8816         (gdb_exception_sliced_copy): Remove.
8817         (throw_exception_cxx): Update.
8818         * cli/cli-script.c (script_from_file): Update.
8819         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8820         Update.
8821         * ada-valprint.c (ada_val_print): Update.
8822         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8823         (create_excep_cond_exprs): Update.
8824
8825 2019-04-08  Tom Tromey  <tom@tromey.com>
8826
8827         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8828         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8829         (TRY, CATCH, END_CATCH): Remove some definitions.
8830         * common/common-exceptions.c: Don't use GDB_XCPT.
8831         (catcher_list_size): Remove.
8832         (throw_exception, throw_it): Simplify.
8833
8834 2019-04-05  Tom Tromey  <tom@tromey.com>
8835
8836         Revert the header-sorting patch.
8837         * ft32-tdep.c: Revert.
8838         * frv-tdep.c: Revert.
8839         * frv-linux-tdep.c: Revert.
8840         * frame.c: Revert.
8841         * frame-unwind.c: Revert.
8842         * frame-base.c: Revert.
8843         * fork-child.c: Revert.
8844         * findvar.c: Revert.
8845         * findcmd.c: Revert.
8846         * filesystem.c: Revert.
8847         * filename-seen-cache.h: Revert.
8848         * filename-seen-cache.c: Revert.
8849         * fbsd-tdep.c: Revert.
8850         * fbsd-nat.h: Revert.
8851         * fbsd-nat.c: Revert.
8852         * f-valprint.c: Revert.
8853         * f-typeprint.c: Revert.
8854         * f-lang.c: Revert.
8855         * extension.h: Revert.
8856         * extension.c: Revert.
8857         * extension-priv.h: Revert.
8858         * expprint.c: Revert.
8859         * exec.h: Revert.
8860         * exec.c: Revert.
8861         * exceptions.c: Revert.
8862         * event-top.c: Revert.
8863         * event-loop.c: Revert.
8864         * eval.c: Revert.
8865         * elfread.c: Revert.
8866         * dwarf2read.h: Revert.
8867         * dwarf2read.c: Revert.
8868         * dwarf2loc.c: Revert.
8869         * dwarf2expr.h: Revert.
8870         * dwarf2expr.c: Revert.
8871         * dwarf2-frame.c: Revert.
8872         * dwarf2-frame-tailcall.c: Revert.
8873         * dwarf-index-write.h: Revert.
8874         * dwarf-index-write.c: Revert.
8875         * dwarf-index-common.c: Revert.
8876         * dwarf-index-cache.h: Revert.
8877         * dwarf-index-cache.c: Revert.
8878         * dummy-frame.c: Revert.
8879         * dtrace-probe.c: Revert.
8880         * disasm.h: Revert.
8881         * disasm.c: Revert.
8882         * disasm-selftests.c: Revert.
8883         * dictionary.c: Revert.
8884         * dicos-tdep.c: Revert.
8885         * demangle.c: Revert.
8886         * dcache.h: Revert.
8887         * dcache.c: Revert.
8888         * darwin-nat.h: Revert.
8889         * darwin-nat.c: Revert.
8890         * darwin-nat-info.c: Revert.
8891         * d-valprint.c: Revert.
8892         * d-namespace.c: Revert.
8893         * d-lang.c: Revert.
8894         * ctf.c: Revert.
8895         * csky-tdep.c: Revert.
8896         * csky-linux-tdep.c: Revert.
8897         * cris-tdep.c: Revert.
8898         * cris-linux-tdep.c: Revert.
8899         * cp-valprint.c: Revert.
8900         * cp-support.c: Revert.
8901         * cp-namespace.c: Revert.
8902         * cp-abi.c: Revert.
8903         * corelow.c: Revert.
8904         * corefile.c: Revert.
8905         * continuations.c: Revert.
8906         * completer.h: Revert.
8907         * completer.c: Revert.
8908         * complaints.c: Revert.
8909         * coffread.c: Revert.
8910         * coff-pe-read.c: Revert.
8911         * cli-out.h: Revert.
8912         * cli-out.c: Revert.
8913         * charset.c: Revert.
8914         * c-varobj.c: Revert.
8915         * c-valprint.c: Revert.
8916         * c-typeprint.c: Revert.
8917         * c-lang.c: Revert.
8918         * buildsym.c: Revert.
8919         * buildsym-legacy.c: Revert.
8920         * build-id.h: Revert.
8921         * build-id.c: Revert.
8922         * btrace.c: Revert.
8923         * bsd-uthread.c: Revert.
8924         * breakpoint.h: Revert.
8925         * breakpoint.c: Revert.
8926         * break-catch-throw.c: Revert.
8927         * break-catch-syscall.c: Revert.
8928         * break-catch-sig.c: Revert.
8929         * blockframe.c: Revert.
8930         * block.c: Revert.
8931         * bfin-tdep.c: Revert.
8932         * bfin-linux-tdep.c: Revert.
8933         * bfd-target.c: Revert.
8934         * bcache.c: Revert.
8935         * ax-general.c: Revert.
8936         * ax-gdb.h: Revert.
8937         * ax-gdb.c: Revert.
8938         * avr-tdep.c: Revert.
8939         * auxv.c: Revert.
8940         * auto-load.c: Revert.
8941         * arm-wince-tdep.c: Revert.
8942         * arm-tdep.c: Revert.
8943         * arm-symbian-tdep.c: Revert.
8944         * arm-pikeos-tdep.c: Revert.
8945         * arm-obsd-tdep.c: Revert.
8946         * arm-nbsd-tdep.c: Revert.
8947         * arm-nbsd-nat.c: Revert.
8948         * arm-linux-tdep.c: Revert.
8949         * arm-linux-nat.c: Revert.
8950         * arm-fbsd-tdep.c: Revert.
8951         * arm-fbsd-nat.c: Revert.
8952         * arm-bsd-tdep.c: Revert.
8953         * arch-utils.c: Revert.
8954         * arc-tdep.c: Revert.
8955         * arc-newlib-tdep.c: Revert.
8956         * annotate.h: Revert.
8957         * annotate.c: Revert.
8958         * amd64-windows-tdep.c: Revert.
8959         * amd64-windows-nat.c: Revert.
8960         * amd64-tdep.c: Revert.
8961         * amd64-sol2-tdep.c: Revert.
8962         * amd64-obsd-tdep.c: Revert.
8963         * amd64-obsd-nat.c: Revert.
8964         * amd64-nbsd-tdep.c: Revert.
8965         * amd64-nbsd-nat.c: Revert.
8966         * amd64-nat.c: Revert.
8967         * amd64-linux-tdep.c: Revert.
8968         * amd64-linux-nat.c: Revert.
8969         * amd64-fbsd-tdep.c: Revert.
8970         * amd64-fbsd-nat.c: Revert.
8971         * amd64-dicos-tdep.c: Revert.
8972         * amd64-darwin-tdep.c: Revert.
8973         * amd64-bsd-nat.c: Revert.
8974         * alpha-tdep.c: Revert.
8975         * alpha-obsd-tdep.c: Revert.
8976         * alpha-nbsd-tdep.c: Revert.
8977         * alpha-mdebug-tdep.c: Revert.
8978         * alpha-linux-tdep.c: Revert.
8979         * alpha-linux-nat.c: Revert.
8980         * alpha-bsd-tdep.c: Revert.
8981         * alpha-bsd-nat.c: Revert.
8982         * aix-thread.c: Revert.
8983         * agent.c: Revert.
8984         * addrmap.c: Revert.
8985         * ada-varobj.c: Revert.
8986         * ada-valprint.c: Revert.
8987         * ada-typeprint.c: Revert.
8988         * ada-tasks.c: Revert.
8989         * ada-lang.c: Revert.
8990         * aarch64-tdep.c: Revert.
8991         * aarch64-ravenscar-thread.c: Revert.
8992         * aarch64-newlib-tdep.c: Revert.
8993         * aarch64-linux-tdep.c: Revert.
8994         * aarch64-linux-nat.c: Revert.
8995         * aarch64-fbsd-tdep.c: Revert.
8996         * aarch64-fbsd-nat.c: Revert.
8997         * aarch32-linux-nat.c: Revert.
8998
8999 2019-04-05  Tom Tromey  <tom@tromey.com>
9000
9001         * ft32-tdep.c: Sort headers.
9002         * frv-tdep.c: Sort headers.
9003         * frv-linux-tdep.c: Sort headers.
9004         * frame.c: Sort headers.
9005         * frame-unwind.c: Sort headers.
9006         * frame-base.c: Sort headers.
9007         * fork-child.c: Sort headers.
9008         * findvar.c: Sort headers.
9009         * findcmd.c: Sort headers.
9010         * filesystem.c: Sort headers.
9011         * filename-seen-cache.h: Sort headers.
9012         * filename-seen-cache.c: Sort headers.
9013         * fbsd-tdep.c: Sort headers.
9014         * fbsd-nat.h: Sort headers.
9015         * fbsd-nat.c: Sort headers.
9016         * f-valprint.c: Sort headers.
9017         * f-typeprint.c: Sort headers.
9018         * f-lang.c: Sort headers.
9019         * extension.h: Sort headers.
9020         * extension.c: Sort headers.
9021         * extension-priv.h: Sort headers.
9022         * expprint.c: Sort headers.
9023         * exec.h: Sort headers.
9024         * exec.c: Sort headers.
9025         * exceptions.c: Sort headers.
9026         * event-top.c: Sort headers.
9027         * event-loop.c: Sort headers.
9028         * eval.c: Sort headers.
9029         * elfread.c: Sort headers.
9030         * dwarf2read.h: Sort headers.
9031         * dwarf2read.c: Sort headers.
9032         * dwarf2loc.c: Sort headers.
9033         * dwarf2expr.h: Sort headers.
9034         * dwarf2expr.c: Sort headers.
9035         * dwarf2-frame.c: Sort headers.
9036         * dwarf2-frame-tailcall.c: Sort headers.
9037         * dwarf-index-write.h: Sort headers.
9038         * dwarf-index-write.c: Sort headers.
9039         * dwarf-index-common.c: Sort headers.
9040         * dwarf-index-cache.h: Sort headers.
9041         * dwarf-index-cache.c: Sort headers.
9042         * dummy-frame.c: Sort headers.
9043         * dtrace-probe.c: Sort headers.
9044         * disasm.h: Sort headers.
9045         * disasm.c: Sort headers.
9046         * disasm-selftests.c: Sort headers.
9047         * dictionary.c: Sort headers.
9048         * dicos-tdep.c: Sort headers.
9049         * demangle.c: Sort headers.
9050         * dcache.h: Sort headers.
9051         * dcache.c: Sort headers.
9052         * darwin-nat.h: Sort headers.
9053         * darwin-nat.c: Sort headers.
9054         * darwin-nat-info.c: Sort headers.
9055         * d-valprint.c: Sort headers.
9056         * d-namespace.c: Sort headers.
9057         * d-lang.c: Sort headers.
9058         * ctf.c: Sort headers.
9059         * csky-tdep.c: Sort headers.
9060         * csky-linux-tdep.c: Sort headers.
9061         * cris-tdep.c: Sort headers.
9062         * cris-linux-tdep.c: Sort headers.
9063         * cp-valprint.c: Sort headers.
9064         * cp-support.c: Sort headers.
9065         * cp-namespace.c: Sort headers.
9066         * cp-abi.c: Sort headers.
9067         * corelow.c: Sort headers.
9068         * corefile.c: Sort headers.
9069         * continuations.c: Sort headers.
9070         * completer.h: Sort headers.
9071         * completer.c: Sort headers.
9072         * complaints.c: Sort headers.
9073         * coffread.c: Sort headers.
9074         * coff-pe-read.c: Sort headers.
9075         * cli-out.h: Sort headers.
9076         * cli-out.c: Sort headers.
9077         * charset.c: Sort headers.
9078         * c-varobj.c: Sort headers.
9079         * c-valprint.c: Sort headers.
9080         * c-typeprint.c: Sort headers.
9081         * c-lang.c: Sort headers.
9082         * buildsym.c: Sort headers.
9083         * buildsym-legacy.c: Sort headers.
9084         * build-id.h: Sort headers.
9085         * build-id.c: Sort headers.
9086         * btrace.c: Sort headers.
9087         * bsd-uthread.c: Sort headers.
9088         * breakpoint.h: Sort headers.
9089         * breakpoint.c: Sort headers.
9090         * break-catch-throw.c: Sort headers.
9091         * break-catch-syscall.c: Sort headers.
9092         * break-catch-sig.c: Sort headers.
9093         * blockframe.c: Sort headers.
9094         * block.c: Sort headers.
9095         * bfin-tdep.c: Sort headers.
9096         * bfin-linux-tdep.c: Sort headers.
9097         * bfd-target.c: Sort headers.
9098         * bcache.c: Sort headers.
9099         * ax-general.c: Sort headers.
9100         * ax-gdb.h: Sort headers.
9101         * ax-gdb.c: Sort headers.
9102         * avr-tdep.c: Sort headers.
9103         * auxv.c: Sort headers.
9104         * auto-load.c: Sort headers.
9105         * arm-wince-tdep.c: Sort headers.
9106         * arm-tdep.c: Sort headers.
9107         * arm-symbian-tdep.c: Sort headers.
9108         * arm-pikeos-tdep.c: Sort headers.
9109         * arm-obsd-tdep.c: Sort headers.
9110         * arm-nbsd-tdep.c: Sort headers.
9111         * arm-nbsd-nat.c: Sort headers.
9112         * arm-linux-tdep.c: Sort headers.
9113         * arm-linux-nat.c: Sort headers.
9114         * arm-fbsd-tdep.c: Sort headers.
9115         * arm-fbsd-nat.c: Sort headers.
9116         * arm-bsd-tdep.c: Sort headers.
9117         * arch-utils.c: Sort headers.
9118         * arc-tdep.c: Sort headers.
9119         * arc-newlib-tdep.c: Sort headers.
9120         * annotate.h: Sort headers.
9121         * annotate.c: Sort headers.
9122         * amd64-windows-tdep.c: Sort headers.
9123         * amd64-windows-nat.c: Sort headers.
9124         * amd64-tdep.c: Sort headers.
9125         * amd64-sol2-tdep.c: Sort headers.
9126         * amd64-obsd-tdep.c: Sort headers.
9127         * amd64-obsd-nat.c: Sort headers.
9128         * amd64-nbsd-tdep.c: Sort headers.
9129         * amd64-nbsd-nat.c: Sort headers.
9130         * amd64-nat.c: Sort headers.
9131         * amd64-linux-tdep.c: Sort headers.
9132         * amd64-linux-nat.c: Sort headers.
9133         * amd64-fbsd-tdep.c: Sort headers.
9134         * amd64-fbsd-nat.c: Sort headers.
9135         * amd64-dicos-tdep.c: Sort headers.
9136         * amd64-darwin-tdep.c: Sort headers.
9137         * amd64-bsd-nat.c: Sort headers.
9138         * alpha-tdep.c: Sort headers.
9139         * alpha-obsd-tdep.c: Sort headers.
9140         * alpha-nbsd-tdep.c: Sort headers.
9141         * alpha-mdebug-tdep.c: Sort headers.
9142         * alpha-linux-tdep.c: Sort headers.
9143         * alpha-linux-nat.c: Sort headers.
9144         * alpha-bsd-tdep.c: Sort headers.
9145         * alpha-bsd-nat.c: Sort headers.
9146         * aix-thread.c: Sort headers.
9147         * agent.c: Sort headers.
9148         * addrmap.c: Sort headers.
9149         * ada-varobj.c: Sort headers.
9150         * ada-valprint.c: Sort headers.
9151         * ada-typeprint.c: Sort headers.
9152         * ada-tasks.c: Sort headers.
9153         * ada-lang.c: Sort headers.
9154         * aarch64-tdep.c: Sort headers.
9155         * aarch64-ravenscar-thread.c: Sort headers.
9156         * aarch64-newlib-tdep.c: Sort headers.
9157         * aarch64-linux-tdep.c: Sort headers.
9158         * aarch64-linux-nat.c: Sort headers.
9159         * aarch64-fbsd-tdep.c: Sort headers.
9160         * aarch64-fbsd-nat.c: Sort headers.
9161         * aarch32-linux-nat.c: Sort headers.
9162
9163 2019-04-04  Tom Tromey  <tom@tromey.com>
9164
9165         * varobj.c (varobj_create): Update.
9166         * rust-exp.y (struct rust_parser) <update_innermost_block,
9167         lookup_symbol>: New methods.
9168         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9169         Rename.
9170         (rust_parser::rust_lookup_type)
9171         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9172         * printcmd.c (display_command, do_one_display): Update.
9173         * parser-defs.h (struct parser_state) <parser_state>: Add
9174         "tracker" parameter.
9175         (block_tracker): New member.
9176         (class innermost_block_tracker) <innermost_block_tracker>: Add
9177         "types" parameter.
9178         <reset>: Remove method.
9179         (innermost_block): Don't declare.
9180         (null_post_parser): Update.
9181         * parse.c (innermost_block): Remove global.
9182         (write_dollar_variable): Update.
9183         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9184         Remove "tracker_types" parameter.
9185         (parse_expression): Add "tracker" parameter.
9186         (parse_expression_for_completion): Update.
9187         (null_post_parser): Add "tracker" parameter.
9188         * p-exp.y: Update rules.
9189         * m2-exp.y: Update rules.
9190         * language.h (struct language_defn) <la_post_parser>: Add
9191         "tracker" parameter.
9192         * go-exp.y: Update rules.
9193         * f-exp.y: Update rules.
9194         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9195         parameter.
9196         * d-exp.y: Update rules.
9197         * c-exp.y: Update rules.
9198         * breakpoint.c (set_breakpoint_condition): Create an
9199         innermost_block_tracker.
9200         (watch_command_1): Likewise.
9201         * ada-lang.c (resolve): Add "tracker" parameter.
9202         (resolve_subexp): Likewise.
9203         * ada-exp.y (write_var_from_sym): Update.
9204
9205 2019-04-04  Tom Tromey  <tom@tromey.com>
9206
9207         * type-stack.h: New file.
9208         * type-stack.c: New file.
9209         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9210         type-stack.h.
9211         (insert_into_type_stack, insert_type, push_type, push_type_int)
9212         (insert_type_address_space, pop_type, pop_type_int)
9213         (pop_typelist, pop_type_stack, append_type_stack)
9214         (push_type_stack, get_type_stack, push_typelist)
9215         (follow_type_instance_flags, follow_types): Don't declare.
9216         * parse.c (type_stack): Remove global.
9217         (parse_exp_in_context): Update.
9218         (insert_into_type_stack, insert_type, push_type, push_type_int)
9219         (insert_type_address_space, pop_type, pop_type_int)
9220         (pop_typelist, pop_type_stack, append_type_stack)
9221         (push_type_stack, get_type_stack, push_typelist)
9222         (follow_type_instance_flags, follow_types): Remove (moved to
9223         type-stack.c).
9224         * f-exp.y (type_stack): New global.
9225         Update rules.
9226         (push_kind_type, f_parse): Update.
9227         * d-exp.y (type_stack): New global.
9228         Update rules.
9229         (d_parse): Update.
9230         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9231         Update rules.
9232         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9233         (HFILES_NO_SRCDIR): Add type-stack.h.
9234
9235 2019-04-04  Tom Tromey  <tom@tromey.com>
9236
9237         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9238         (rust_parser::convert_ast_to_expression, rust_parse)
9239         (rust_lex_test_completion, rust_lex_tests): Update.
9240         * parser-defs.h (struct expr_completion_state): New.
9241         (struct parser_state) <parser_state>: Add completion parameter.
9242         <mark_struct_expression, mark_completion_tag>: New methods.
9243         <parse_completion, m_completion_state>: New members.
9244         (prefixify_expression, null_post_parser): Update.
9245         (mark_struct_expression, mark_completion_tag): Don't declare.
9246         * parse.c (parse_completion, expout_last_struct)
9247         (expout_tag_completion_type, expout_completion_name): Remove
9248         globals.
9249         (parser_state::mark_struct_expression)
9250         (parser_state::mark_completion_tag): Now methods.
9251         (prefixify_expression): Add last_struct parameter.
9252         (prefixify_subexp): Likewise.
9253         (parse_exp_1): Update.
9254         (parse_exp_in_context): Add cstate parameter.  Update.
9255         (parse_expression_for_completion): Create an
9256         expr_completion_state.
9257         (null_post_parser): Add "completion" parameter.
9258         * p-exp.y: Update rules.
9259         (yylex): Update.
9260         * language.h (struct language_defn) <la_post_parser>: Add
9261         "completing" parameter.
9262         * go-exp.y: Update rules.
9263         (lex_one_token): Update.
9264         * expression.h (parse_completion): Don't declare.
9265         * d-exp.y: Update rules.
9266         (lex_one_token): Update rules.
9267         * c-exp.y: Update rules.
9268         (lex_one_token): Update.
9269         * ada-lang.c (resolve): Add "parse_completion" parameter.
9270         (resolve_subexp): Likewise.
9271         (ada_resolve_function): Likewise.
9272
9273 2019-04-04  Tom Tromey  <tom@tromey.com>
9274
9275         * parser-defs.h (struct parser_state) <start_arglist,
9276         end_arglist>: New methods.
9277         <arglist_len, m_funcall_chain>: New members.
9278         (arglist_len, start_arglist, end_arglist): Don't declare.
9279         * parse.c (arglist_len, funcall_chain): Remove global.
9280         (start_arglist, end_arglist): Remove functions.
9281         (parse_exp_in_context): Update.
9282         * p-exp.y: Update rules.
9283         * m2-exp.y: Update rules.
9284         * go-exp.y: Update rules.
9285         * f-exp.y: Update rules.
9286         * d-exp.y: Update rules.
9287         * c-exp.y: Update rules.
9288
9289 2019-04-04  Tom Tromey  <tom@tromey.com>
9290
9291         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9292         lex_operator, push_back>: New methods.
9293         Update all rules.
9294         (rust_parser::lex_hex, lex_escape): Rename and update.
9295         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9296         (rust_parser::lex_operator): Rename and update.
9297         (rust_parser::lex_number, rustyylex, rustyyerror)
9298         (rust_lex_test_init, rust_lex_test_sequence)
9299         (rust_lex_test_push_back, rust_lex_tests): Update.
9300         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9301         parameter.
9302         <lexptr, prev_lexptr>: New members.
9303         (lexptr, prev_lexptr): Don't declare.
9304         * parse.c (lexptr, prev_lexptr): Remove globals.
9305         (parse_exp_in_context): Update.
9306         * p-exp.y (yylex, yyerror): Update.
9307         * m2-exp.y (parse_number, yylex, yyerror): Update.
9308         * go-exp.y (lex_one_token, yyerror): Update.
9309         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9310         * d-exp.y (lex_one_token, yyerror): Update.
9311         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9312         (lex_one_token, yyerror): Update.
9313         * ada-lex.l (YY_INPUT): Update.
9314         (rewind_to_char): Update.
9315         * ada-exp.y (yyerror): Update.
9316
9317 2019-04-04  Tom Tromey  <tom@tromey.com>
9318
9319         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9320         * parser-defs.h (struct parser_state) <parser_state>: Add new
9321         parameter.
9322         <comma_terminates>: New member.
9323         (comma_terminates): Don't declare global.
9324         * parse.c (comma_terminates): Remove global.
9325         (parse_exp_in_context): Update.
9326         * p-exp.y (yylex): Update.
9327         * m2-exp.y (yylex): Update.
9328         * go-exp.y (lex_one_token): Update.
9329         * f-exp.y (yylex): Update.
9330         * d-exp.y (lex_one_token): Update.
9331         * c-exp.y (lex_one_token): Update.
9332         * ada-lex.l: Update.
9333
9334 2019-04-04  Tom Tromey  <tom@tromey.com>
9335
9336         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9337         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9338         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9339         * parser-defs.h (paren_depth): Don't declare.
9340         * parse.c (paren_depth): Remove global.
9341         (parse_exp_in_context): Update.
9342         * p-exp.y (paren_depth): New global.
9343         (pascal_parse): Initialize it.
9344         * m2-exp.y (paren_depth): New global.
9345         (m2_parse): Initialize it.
9346         * go-exp.y (paren_depth): New global.
9347         (go_parse): Initialize it.
9348         * f-exp.y (paren_depth): New global.
9349         (f_parse): Initialize it.
9350         * d-exp.y (paren_depth): New global.
9351         (d_parse): Initialize it.
9352         * c-exp.y (paren_depth): New global.
9353         (c_parse): Initialize it.
9354         * ada-lex.l (paren_depth): New global.
9355         (lexer_init): Initialize it.
9356
9357 2019-04-04  Tom Tromey  <tom@tromey.com>
9358
9359         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9360         (rust_parser::convert_ast_to_type)
9361         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9362         * parser-defs.h (struct parser_state) <parser_state>: Add
9363         parameters.  Initialize new members.
9364         <expression_context_block, expression_context_pc>: New members.
9365         * parse.c (expression_context_block, expression_context_pc):
9366         Remove globals.
9367         (parse_exp_in_context): Update.
9368         * p-exp.y: Update all rules.
9369         (yylex): Update.
9370         * m2-exp.y: Update all rules.
9371         (yylex): Update.
9372         * go-exp.y (yylex): Update.
9373         * f-exp.y (yylex): Update.
9374         * d-exp.y: Update all rules.
9375         (yylex): Update.
9376         * c-exp.y: Update all rules.
9377         (lex_one_token, classify_name, yylex, c_parse): Update.
9378         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9379
9380 2019-04-04  Tom Tromey  <tom@tromey.com>
9381
9382         * gdbarch.h, gdbarch.c: Rebuild.
9383         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9384         * stap-probe.h:
9385         (struct stap_parse_info): Replace "parser_state" with
9386         "expr_builder".
9387         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9388         (parser_state): New class.
9389         * parse.c (expr_builder): Rename.
9390         (expr_builder::release): Rename.
9391         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9392         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9393         (write_exp_elt_longcst, write_exp_elt_floatcst)
9394         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9395         (write_exp_string_vector, write_exp_bitstring)
9396         (write_exp_msymbol, mark_struct_expression)
9397         (write_dollar_variable)
9398         (insert_type_address_space, increase_expout_size): Replace
9399         "parser_state" with "expr_builder".
9400         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9401         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9402         "parser_state" with "expr_builder".
9403
9404 2019-04-04  Tom Tromey  <tom@tromey.com>
9405
9406         * rust-exp.y: Replace "parse_language" with method call.
9407         * p-exp.y:
9408         (yylex): Replace "parse_language" with method call.
9409         * m2-exp.y:
9410         (yylex): Replace "parse_language" with method call.
9411         * go-exp.y (classify_name): Replace "parse_language" with method
9412         call.
9413         * f-exp.y (yylex): Replace "parse_language" with method call.
9414         * d-exp.y (lex_one_token): Replace "parse_language" with method
9415         call.
9416         * c-exp.y:
9417         (lex_one_token, classify_name, yylex): Replace "parse_language"
9418         with method call.
9419         * ada-exp.y (find_primitive_type, type_char)
9420         (type_system_address): Replace "parse_language" with method call.
9421
9422 2019-04-04  Tom Tromey  <tom@tromey.com>
9423
9424         * rust-exp.y: Replace "parse_gdbarch" with method call.
9425         * parse.c (write_dollar_variable, insert_type_address_space):
9426         Replace "parse_gdbarch" with method call.
9427         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9428         call.
9429         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9430         call.
9431         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9432         "parse_gdbarch" with method call.
9433         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9434         with method call.
9435         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9436         "parse_gdbarch" with method call.
9437         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9438         "parse_gdbarch" with method call.
9439         * c-exp.y (parse_type, parse_number, classify_name): Replace
9440         "parse_gdbarch" with method call.
9441         * ada-lex.l: Replace "parse_gdbarch" with method call.
9442         * ada-exp.y (parse_type, find_primitive_type, type_char)
9443         (type_system_address): Replace "parse_gdbarch" with method call.
9444
9445 2019-04-04  Tom Tromey  <tom@tromey.com>
9446
9447         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9448         * stap-probe.c (stap_parse_argument): Update.
9449         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9450         initial_size parameter.
9451         * rust-exp.y (rust_lex_tests): Update.
9452         * parse.c (parser_state): Update.
9453         (parse_exp_in_context): Update.
9454         * parser-defs.h (struct parser_state) <parser_state>: Remove
9455         "initial_size" parameter.
9456
9457 2019-04-04  Tom Tromey  <tom@tromey.com>
9458
9459         * parser-defs.h (increase_expout_size): Don't declare.
9460         * parse.c (increase_expout_size): Now static.
9461
9462 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9463
9464         * gnu-nat.c (gnu_nat_target::wait): Fix
9465         target_waitstatus_to_string call.
9466
9467 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9468
9469         * eval.c (evaluate_subexp_standard): Handle internal functions
9470         during Fortran function call handling.
9471
9472 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9473
9474         * NEWS: Mention new internal functions.
9475         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9476         (read_base_type): Use dwarf2_init_complex_target_type.
9477         * value.c (creal_internal_fn): New function.
9478         (cimag_internal_fn): New function.
9479         (_initialize_values): Register new internal functions.
9480
9481 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9482
9483         * infrun.c (stop_all_threads): If debug_infrun, always
9484         trace the wait status after wait_one, using
9485         target_waitstatus_to_string and target_pid_to_str.
9486         (handle_inferior_event): Replace various trace of
9487         wait status kind by a single trace.
9488         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9489         wait status kind image by target_waitstatus_to_string.
9490         * target/waitstatus.c (target_waitstatus_to_string): Fix
9491         obsolete comment.
9492
9493 2019-04-01  Tom Tromey  <tromey@adacore.com>
9494
9495         PR symtab/23331:
9496         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9497
9498 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9499             Pedro Alves  <palves@redhat.com>
9500
9501         * top.c (quit_force): Call 'finalize_values'.
9502         * value.c (finalize_values): New function.
9503         * value.h (finalize_values): Declare.
9504
9505 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9506
9507         * NEWS: Announce $_gdb_major and $_gdb_minor.
9508
9509         * top.c (init_gdb_version_vars): New function.
9510         (gdb_init): Call init_gdb_version_vars.
9511
9512 2019-03-29  Tom Tromey  <tromey@adacore.com>
9513
9514         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9515         help text.  Remove dead code.
9516
9517 2019-03-29  Keith Seitz  <keiths@redhat.com>
9518
9519         From Siddhesh Poyarekar:
9520         * f-lang.h (f77_get_upperbound): Return LONGEST.
9521         (f77_get_lowerbound): Likewise.
9522         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9523         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9524         print them.
9525         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9526         plongest to format print it.
9527         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9528         (f77_get_upperbound): Likewise.
9529         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9530         LOWER_BOUND to LONGEST.
9531         (f77_create_arrayprint_offset_tbl): Likewise.
9532
9533 2019-03-29  Keith Seitz  <keiths@redhat.com>
9534
9535         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9536         %s/pulongest for TYPE_LENGTH instead of %d in format
9537         strings.
9538         * ada-typerint.c (ada_print_type): Likewise.
9539         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9540         * compile/compile-c-support.c (generate_register_struct): Likewise.
9541         * gdbtypes.c (recursive_dump_type): Likewise.
9542         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9543         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9544         instead of %d in format strings.
9545         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9546         to std::min to ULONGEST.
9547         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9548         instead of %d in format strings.
9549         * tracepoint.c (info_scope_command): Likewise.
9550         * typeprint.c (print_offset_data::update)
9551         (print_offset_data::finish): Likewise.
9552         * xtensa-tdep.c (xtensa_store_return_value)
9553         (xtensa_push_dummy_call): Likewise.
9554
9555 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9556
9557         * windows-nat.c (display_selector): Fixed format specifications
9558         for 64-bit Cygwin.
9559
9560 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9561
9562         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9563
9564 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9565
9566         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9567         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9568         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9569         (nios2_linux_init_abi): Install it.
9570
9571 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9572
9573         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9574
9575 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9576
9577         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9578
9579 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9580             Tom Tromey  <tromey@adacore.com>
9581
9582         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9583
9584 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9585
9586         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9587         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9588         method to compute the bounds of range types. Also print "[evaluated]"
9589         if the bounds' values come from a dynamic evaluation.
9590
9591 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9592
9593         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9594         whitespace when pretty printing is on.
9595
9596 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9597
9598         * ppc-linux-nat.c: Add include.
9599
9600 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9601
9602         * NEWS: Mention AArch64 Pointer Authentication.
9603
9604 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9605
9606         * arm-linux-nat.c: Add include.
9607
9608 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9609
9610         * source-cache.c (source_cache::get_source_lines): Re-read
9611         fullname after calling open_source_file.
9612
9613 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9614
9615         * NEWS: Mention TLS support for FreeBSD.
9616
9617 2019-03-25  Tom Tromey  <tromey@adacore.com>
9618
9619         * minsyms.c (BUNCH_SIZE): Update comment.
9620         (~minimal_symbol_reader): Remove old comment.
9621         (compact_minimal_symbols): Update comment.
9622         (minimal_symbol_reader::install): Remove old comment.  Update
9623         other comments.
9624
9625 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9626
9627         * s390-linux-nat.c: Add include.
9628
9629 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9630
9631         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9632         Call linux_get_hwcap.
9633         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9634         Likewise.
9635         (aarch64_linux_get_hwcap): Remove function.
9636         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9637         declaration.
9638         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9639         linux_get_hwcap.
9640         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9641         * linux-tdep.c (linux_get_hwcap): Add function.
9642         (linux_get_hwcap2): Likewise.
9643         * linux-tdep.h (linux_get_hwcap): Add declaration.
9644         (linux_get_hwcap2): Likewise.
9645         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9646         (ppc_linux_get_hwcap2): Likewise.
9647         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9648         linux_get_hwcap.
9649         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9650         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9651         (ppc_linux_nat_target::read_description): Likewise.
9652         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9653         * s390-linux-nat.c: Likewise.
9654         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9655
9656 2019-03-24  Tom Tromey  <tom@tromey.com>
9657
9658         * ada-lang.c (standard_lookup): Simplify initialization.
9659         (ada_lookup_symbol_nonlocal): Simplify return.
9660         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9661         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9662         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9663         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9664         initialization.
9665         * solib.c (solib_global_lookup): Simplify.
9666         * symtab.c (null_block_symbol): Remove.
9667         (symbol_cache_lookup): Simplify returns.
9668         (lookup_language_this): Simplify returns.
9669         (lookup_symbol_aux): Simplify return.
9670         (lookup_local_symbol): Simplify returns.
9671         (lookup_global_symbol_from_objfile): Simplify return.
9672         (lookup_symbol_in_objfile_symtabs)
9673         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9674         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9675         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9676         * cp-namespace.c (cp_lookup_bare_symbol)
9677         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9678         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9679         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9680         (cp_lookup_symbol_via_imports): Simplify initialization.
9681         (find_symbol_in_baseclass): Likewise.
9682         * symtab.h (null_block_symbol): Remove.
9683         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9684         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9685         (d_lookup_symbol_module): Likewise.
9686         (find_symbol_in_baseclass): Simplify initialization.
9687
9688 2019-03-24  Tom Tromey  <tom@tromey.com>
9689
9690         * expression.h: Don't include symtab.h.
9691         (struct block): Forward declare.
9692
9693 2019-03-24  Tom Tromey  <tom@tromey.com>
9694
9695         * c-exp.y (typebase): Remove casts.
9696         * gdbtypes.c (lookup_unsigned_typename, )
9697         (lookup_signed_typename): Remove cast.
9698         * eval.c (parse_to_comma_and_eval): Remove cast.
9699         * parse.c (write_dollar_variable): Remove cast.
9700         * block.h (struct block) <superblock>: Now const.
9701         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9702         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9703         (map_block): Make "block" const.
9704         * symfile.h (struct quick_symbol_functions)
9705         <map_matching_symbols>: Constify block argument to "callback".
9706         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9707         const.
9708         (find_pc_sect_compunit_symtab): Make "b" const.
9709         (find_symbol_at_address): Likewise.
9710         (search_symbols): Likewise.
9711         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9712         (dw2_debug_names_lookup_symbol): Likewise.
9713         (dw2_map_matching_symbols): Update.
9714         * p-valprint.c (pascal_val_print): Remove "block".
9715         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9716         (aux_add_nonlocal_symbols): Make "block" const.
9717         (resolve_subexp): Remove cast.
9718         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9719         const.
9720         (iterate_over_file_blocks): Likewise.
9721         * f-exp.y (%union) <bval>: Remove.
9722         * coffread.c (patch_opaque_types): Make "b" const.
9723         * spu-tdep.c (spu_catch_start): Make "block" const.
9724         * c-valprint.c (print_unpacked_pointer): Remove "block".
9725         * symmisc.c (dump_symtab_1): Make "b" const.
9726         (block_depth): Make "block" const.
9727         * d-exp.y (%union) <bval>: Remove.
9728         * cp-support.h (cp_lookup_rtti_type): Update.
9729         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9730         * psymtab.c (psym_lookup_symbol): Make "block" const.
9731         (maintenance_check_psymtabs): Make "b" const.
9732         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9733         (enumerate_locals, enumerate_args): Update.
9734         * python/py-symtab.c (stpy_global_block): Make "block" const.
9735         (stpy_static_block): Likewise.
9736         * inline-frame.c (block_starting_point_at): Make "new_block"
9737         const.
9738         * block.c (find_block_in_blockvector): Make return type const.
9739         (blockvector_for_pc_sect): Make "b" const.
9740         (find_block_in_blockvector): Make "b" const.
9741
9742 2019-03-23  Tom Tromey  <tom@tromey.com>
9743
9744         * varobj.c (varobj_create): Update.
9745         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9746         * printcmd.c (display_command, do_one_display): Don't reset
9747         innermost_block.
9748         * parser-defs.h (enum innermost_block_tracker_type): Move to
9749         expression.h.
9750         (innermost_block): Update comment.
9751         * parse.c (parse_exp_1): Add tracker_types parameter.
9752         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9753         tracker_types parameter.  Reset innermost_block.
9754         (parse_exp_in_context): Remove.
9755         (parse_expression_for_completion): Update.
9756         * objfiles.c (~objfile): Don't reset expression_context_block or
9757         innermost_block.
9758         * expression.h (enum innermost_block_tracker_type): Move from
9759         parser-defs.h.
9760         (parse_exp_1): Add tracker_types parameter.
9761         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9762         reset innermost_block.
9763
9764 2019-03-23  Tom Tromey  <tom@tromey.com>
9765
9766         * objfiles.h: Include bcache.h.
9767
9768 2019-03-23  Tom Tromey  <tom@tromey.com>
9769
9770         * linespec.c (get_current_search_block): Use
9771         scoped_restore_current_language.
9772         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9773
9774 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9775             Jiong Wang  <jiong.wang@arm.com>
9776
9777         * aarch64-linux-tdep.c
9778         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9779         section.
9780         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9781
9782 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9783             Jiong Wang  <jiong.wang@arm.com>
9784
9785         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9786         instructions.
9787         (aarch64_analyze_prologue_test): Add PACIASP test.
9788         (aarch64_prologue_prev_register): Unmask PC value.
9789
9790 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9791             Jiong Wang  <jiong.wang@arm.com>
9792
9793         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9794         (aarch64_dwarf2_prev_register): Unmask PC value.
9795         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9796         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9797         DW_CFA_AARCH64_negate_ra_state.
9798         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9799
9800 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9801             Jiong Wang  <jiong.wang@arm.com>
9802
9803         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9804         registers.
9805         (aarch64_pseudo_register_name): Likewise.
9806         (aarch64_pseudo_register_type): Likewise.
9807         (aarch64_pseudo_register_reggroup_p): Likewise.
9808         (aarch64_gdbarch_init): Add pauth registers.
9809         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9810         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9811         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9812         (struct gdbarch_tdep): Add regnum for ra_state.
9813
9814 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9815             Jiong Wang  <jiong.wang@arm.com>
9816
9817         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9818
9819 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9820             Jiong Wang  <jiong.wang@arm.com>
9821
9822         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9823         function.
9824         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9825         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9826         (aarch64_gdbarch_init): Add puth registers.
9827         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9828         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9829         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9830
9831 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9832             Jiong Wang  <jiong.wang@arm.com>
9833
9834         * aarch64-linux-nat.c
9835         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9836         * aarch64-linux-tdep.c
9837         (aarch64_linux_core_read_description): Likewise.
9838         (aarch64_linux_get_hwcap): New function.
9839         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9840         (aarch64_linux_get_hwcap): New declaration.
9841
9842 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9843             Jiong Wang  <jiong.wang@arm.com>
9844
9845         * aarch64-linux-nat.c
9846         (aarch64_linux_nat_target::read_description): Add pauth param.
9847         * aarch64-linux-tdep.c
9848         (aarch64_linux_core_read_description): Likewise.
9849         * aarch64-tdep.c (struct target_desc): Add in pauth.
9850         (aarch64_read_description): Add pauth param.
9851         (aarch64_gdbarch_init): Likewise.
9852         * aarch64-tdep.h (aarch64_read_description): Likewise.
9853         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9854         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9855         * features/Makefile: Add new files.
9856         * features/aarch64-pauth.c: New file.
9857         * features/aarch64-pauth.xml: New file.
9858
9859 2019-03-20  Tom Tromey  <tromey@adacore.com>
9860
9861         * infrun.c (handle_inferior_event): Rename from
9862         handle_inferior_event_1.  Create a scoped_value_mark.
9863         (handle_inferior_event): Remove.
9864
9865 2019-03-19  Tom Tromey  <tromey@adacore.com>
9866
9867         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9868         * infrun.h (print_stop_event): Add "displays" parameter.
9869         * infrun.c (print_stop_event): Add "displays" parameter.
9870
9871 2019-03-19  Pedro Alves  <palves@redhat.com>
9872
9873         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9874         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9875         to -1.  Fix TABs vs spaces.
9876         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9877         * tui/tui-out.h (tui_ui_out) Add intro comments.
9878         <m_line, m_start_of_line>: In-class initialize, and add describing
9879         comment.
9880
9881 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9882
9883         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9884         variable names.
9885         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9886
9887 2019-03-18  Pedro Alves  <palves@redhat.com>
9888             Eli Zaretskii <eliz@gnu.org>
9889
9890         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9891         m_line and m_start_of_line.
9892
9893 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9894
9895         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9896         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9897         it returns a newline.  This fixes a regression in TU mode, whereby
9898         the next line is output on the same screen line as the user input.
9899
9900 2019-03-18  Tom Tromey  <tromey@adacore.com>
9901
9902         * minsyms.c (minimal_symbol_reader::install): Remove call to
9903         obstack_blank.
9904
9905 2019-03-18  Pedro Alves  <palves@redhat.com>
9906
9907         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9908         New globals.
9909         (apply_style): New, factored out from ...
9910         (apply_ansi_escape): ... this.  Handle reverse video mode.
9911         (tui_set_reverse_mode): New function.
9912         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9913         * tui/tui-winsource.c (tui_show_source_line): Use
9914         tui_set_reverse_mode instead of setting A_STANDOUT.
9915         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9916         New setter methods.
9917
9918 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9919
9920         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9921         Handle tabs.
9922
9923 2019-03-18  Tom Tromey  <tromey@adacore.com>
9924
9925         * ada-lang.c (empty_array): Add "high" parameter.
9926         (ada_evaluate_subexp): Update.
9927
9928 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9929
9930         * unittests/string_view-selftests.c: Define
9931         _initialize_string_view_selftests unconditionally.
9932
9933 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9934
9935         PR gdb/24350
9936         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9937
9938 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9939
9940         PR gdb/24351
9941         * windows-nat.c (display_selector): Fix format specifiers.
9942
9943 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9944
9945         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9946         tui_refill_source_window instead of tui_refresh_win, to update the
9947         current execution line.  This fixes redisplay of the current line
9948         when stepping through the code with "next" or "step".
9949
9950 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9951
9952         * source-cache.c (source_cache::get_source_lines): Call
9953         find_source_lines to initialize s->nlines.  This fixes vertical
9954         scrolling of TUI source window when the DOWN arrow is pressed.
9955
9956 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9957
9958         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9959         linux-thread-db.c (_initialize_thread_db): Likewise.
9960
9961 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9962
9963         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9964         wclrtoeol in tui_show_source_line".  This reverts changes made in
9965         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9966
9967 2019-03-15  Tom Tromey  <tom@tromey.com>
9968
9969         * symtab.h (struct minimal_symbol): Derive from
9970         general_symbol_info.
9971         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9972         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9973         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9974         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9975         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9976         (MSYMBOL_SEARCH_NAME): Update.
9977         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9978         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9979         * minsyms.c (minimal_symbol_reader::record_full): Update.
9980
9981 2019-03-15  Tom Tromey  <tom@tromey.com>
9982
9983         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9984
9985 2019-03-15  Tom Tromey  <tom@tromey.com>
9986
9987         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9988         unique_xmalloc_ptr.
9989         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9990         Update.
9991         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9992         (build_minimal_symbol_hash_tables)
9993         (minimal_symbol_reader::install): Update.
9994
9995 2019-03-15  Tom Tromey  <tom@tromey.com>
9996
9997         * symtab.c (create_demangled_names_hash): Update.
9998         (symbol_set_names): Update.
9999         * objfiles.h (struct objfile_per_bfd_storage)
10000         <demangled_names_hash>: Now an htab_up.
10001         * objfiles.c (objfile_per_bfd_storage): Simplify.
10002
10003 2019-03-15  Tom Tromey  <tom@tromey.com>
10004
10005         * objfiles.h (struct objfile_per_bfd_storage): Declare
10006         destructor.
10007         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10008         New.
10009         (get_objfile_bfd_data): Use new.  Don't initialize
10010         language_of_main.
10011         (free_objfile_per_bfd_storage): Remove.
10012         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10013
10014 2019-03-15  Tom Tromey  <tom@tromey.com>
10015
10016         * symfile.c (reread_symbols): Update.
10017         * objfiles.c (objfile::objfile): Update.
10018         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10019         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10020         comment.
10021         (minimal_symbol_reader::install): Update.
10022         (terminate_minimal_symbol_table): Remove.
10023         * jit.c (jit_object_close_impl): Update.
10024
10025 2019-03-15  Tom Tromey  <tom@tromey.com>
10026
10027         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10028         initializations.
10029
10030 2019-03-15  Tom Tromey  <tom@tromey.com>
10031
10032         * objfiles.h (struct objfile_per_bfd_storage)
10033         <demangled_hash_languages>: Now a bitset.
10034         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10035         (lookup_minimal_symbol): Update.
10036
10037 2019-03-15  Tom Tromey  <tom@tromey.com>
10038
10039         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10040         Don't return the symbol.
10041         * coffread.c (record_minimal_symbol): Use record_full.
10042
10043 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10044
10045         The MS-Windows port of ncurses fails to switch to a color pair if
10046         one or both of the colors are the implicit default colors.  This
10047         change records the default colors when TUI is initialized, and
10048         then specifies them explicitly when a color pair uses the default
10049         colors.  This allows color styling in TUI mode on MS-Windows.
10050
10051         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10052         ncurses_norm_attr.
10053         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10054         colors in ncurses_norm_attr.
10055         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10056         "none", replace it with the default color recorded in
10057         ncurses_norm_attr.
10058
10059 2019-03-14  Tom Tromey  <tromey@adacore.com>
10060
10061         * source-cache.h (class source_cache) <get_source_lines>: Return
10062         std::string.
10063         * source-cache.c (source_cache::extract_lines): Handle case where
10064         first_pos==npos.  Return std::string.
10065         (source_cache::get_source_lines): Update.
10066
10067 2019-03-14  Tom Tromey  <tromey@adacore.com>
10068
10069         * NEWS: Add item for "style sources" commands.
10070         * source-cache.c (source_cache::get_source_lines): Check
10071         source_styling.
10072         * cli/cli-style.c (source_styling): New global.
10073         (_initialize_cli_style): Add "style sources" commands.
10074         (show_style_sources): New function.
10075         * cli/cli-style.h (source_styling): Declare.
10076
10077 2019-03-14  Pedro Alves  <palves@redhat.com>
10078             Tom Tromey  <tromey@adacore.com>
10079
10080         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10081         * tui/tui-winsource.c (tui_refill_source_window): New function,
10082         from...
10083         (tui_horizontal_source_scroll): ... here.  Move some logic.
10084         * cli/cli-style.c (set_style_enabled): Notify new observable.
10085         * tui/tui-hooks.c (tui_redisplay_source): New function.
10086         (tui_attach_detach_observers): Attach or detach
10087         tui_redisplay_source.
10088         * observable.h (source_styling_changed): New observable.
10089         * observable.c: Define source_styling_changed observable.
10090
10091 2019-03-13  Tom Tromey  <tromey@adacore.com>
10092
10093         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10094         (i386_gnu_nat_target::store_registers): Update.
10095         * target-debug.h (target_debug_print_std_string): New macro.
10096         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10097         * windows-tdep.c (display_one_tib): Update.
10098         * tui/tui-stack.c (tui_make_status_line): Update.
10099         * top.c (print_inferior_quit_action): Update.
10100         * thread.c (thr_try_catch_cmd): Update.
10101         (add_thread_with_info): Update.
10102         (thread_target_id_str): Update.
10103         (thr_try_catch_cmd): Update.
10104         (thread_command): Update.
10105         (thread_find_command): Update.
10106         * record-btrace.c (record_btrace_target::info_record)
10107         (record_btrace_resume_thread, record_btrace_target::resume)
10108         (record_btrace_cancel_resume, record_btrace_step_thread)
10109         (record_btrace_target::wait, record_btrace_target::wait)
10110         (record_btrace_target::wait, record_btrace_target::stop): Update.
10111         * progspace.c (print_program_space): Update.
10112         * process-stratum-target.c
10113         (process_stratum_target::thread_address_space): Update.
10114         * linux-fork.c (linux_fork_mourn_inferior)
10115         (detach_checkpoint_command, info_checkpoints_command)
10116         (linux_fork_context): Update.
10117         (linux_fork_detach): Update.
10118         (class scoped_switch_fork_info): Update.
10119         (delete_checkpoint_command): Update.
10120         * infrun.c (follow_fork_inferior): Update.
10121         (follow_fork_inferior): Update.
10122         (proceed_after_vfork_done): Update.
10123         (handle_vfork_child_exec_or_exit): Update.
10124         (follow_exec): Update.
10125         (displaced_step_prepare_throw): Update.
10126         (displaced_step_restore): Update.
10127         (start_step_over): Update.
10128         (resume_1): Update.
10129         (clear_proceed_status_thread): Update.
10130         (proceed): Update.
10131         (print_target_wait_results): Update.
10132         (do_target_wait): Update.
10133         (context_switch): Update.
10134         (stop_all_threads): Update.
10135         (restart_threads): Update.
10136         (finish_step_over): Update.
10137         (handle_signal_stop): Update.
10138         (switch_back_to_stepped_thread): Update.
10139         (keep_going_pass_signal): Update.
10140         (print_exited_reason): Update.
10141         (normal_stop): Update.
10142         * inferior.c (inferior_pid_to_str): Change return type.
10143         (print_selected_inferior): Update.
10144         (add_inferior): Update.
10145         (detach_inferior): Update.
10146         * dummy-frame.c (fprint_dummy_frames): Update.
10147         * dcache.c (dcache_info_1): Update.
10148         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10149         (btrace_fetch, btrace_clear): Update.
10150         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10151         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10152         type.
10153         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10154         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10155         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10156         * gdbarch.c, gdbarch.h: Rebuild.
10157         * gdbarch.sh (core_pid_to_str): Change return type.
10158         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10159         return type.
10160         (windows_nat_target::pid_to_str): Change return type.
10161         (windows_delete_thread): Update.
10162         (windows_nat_target::attach): Update.
10163         (windows_nat_target::files_info): Update.
10164         * target-delegates.c: Rebuild.
10165         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10166         return type.
10167         (sol_thread_target::pid_to_str): Change return type.
10168         * remote.c (class remote_target) <pid_to_str>: Change return
10169         type.
10170         (remote_target::pid_to_str): Change return type.
10171         (extended_remote_target::attach, remote_target::remote_stop_ns)
10172         (remote_target::remote_notif_remove_queued_reply)
10173         (remote_target::push_stop_reply, remote_target::disable_btrace):
10174         Update.
10175         (extended_remote_target::attach): Update.
10176         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10177         type.
10178         (gdbsim_target::pid_to_str): Change return type.
10179         * ravenscar-thread.c (struct ravenscar_thread_target)
10180         <pid_to_str>: Change return type.
10181         (ravenscar_thread_target::pid_to_str): Change return type.
10182         * procfs.c (class procfs_target) <pid_to_str>: Change return
10183         type.
10184         (procfs_target::pid_to_str): Change return type.
10185         (procfs_target::attach): Update.
10186         (procfs_target::detach): Update.
10187         (procfs_target::fetch_registers): Update.
10188         (procfs_target::store_registers): Update.
10189         (procfs_target::wait): Update.
10190         (procfs_target::files_info): Update.
10191         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10192         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10193         return type.
10194         (nto_procfs_target::pid_to_str): Change return type.
10195         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10196         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10197         return type.
10198         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10199         (exit_lwp): Update.
10200         (attach_proc_task_lwp_callback, get_detach_signal)
10201         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10202         (linux_nat_target::resume, wait_lwp, stop_callback)
10203         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10204         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10205         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10206         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10207         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10208         type.
10209         (inf_ptrace_target::attach): Update.
10210         (inf_ptrace_target::files_info): Update.
10211         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10212         type.
10213         (go32_nat_target::pid_to_str): Change return type.
10214         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10215         (gnu_nat_target::wait): Update.
10216         (gnu_nat_target::wait): Update.
10217         (gnu_nat_target::resume): Update.
10218         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10219         (fbsd_nat_target::wait): Update.
10220         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10221         type.
10222         (darwin_nat_target::attach): Update.
10223         * corelow.c (class core_target) <pid_to_str>: Change return type.
10224         (core_target::pid_to_str): Change return type.
10225         * target.c (normal_pid_to_str): Change return type.
10226         (default_pid_to_str): Likewise.
10227         (target_pid_to_str): Change return type.
10228         (target_translate_tls_address): Update.
10229         (target_announce_detach): Update.
10230         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10231         return type.
10232         (bsd_uthread_target::pid_to_str): Change return type.
10233         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10234         type.
10235         (bsd_kvm_target::pid_to_str): Change return type.
10236         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10237         return type.
10238         (aix_thread_target::pid_to_str): Change return type.
10239         * target.h (struct target_ops) <pid_to_str>: Change return type.
10240         (target_pid_to_str, normal_pid_to_str): Likewise.
10241         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10242         type.
10243         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10244         type.
10245         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10246         return type.
10247         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10248         type.
10249         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10250         type.
10251         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10252         return type.
10253
10254 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10255
10256         * NEWS: Mention that the new default MI version is 3.  Mention
10257         changes to the output of commands and events that deal with
10258         multi-location breakpoints.
10259         * breakpoint.c: Include "mi/mi-out.h".
10260         (print_one_breakpoint): Change output syntax if using MI version
10261         >= 3.
10262         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10263         New.
10264         (mi_multi_location_breakpoint_output_fixed): New.
10265         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10266         (mi_cmd_fix_multi_location_breakpoint_output): New.
10267         (mi_multi_location_breakpoint_output_fixed): New.
10268         * mi/mi-cmds.c (mi_cmds): Register command
10269         -fix-multi-location-breakpoint-output.
10270         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10271         interpreter "mi".
10272
10273 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10274
10275         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10276         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10277         instantiate mi_ui_out based on interpreter name.
10278         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10279         * mi/mi-main.c (mi_load_progress): Likewise.
10280
10281 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10282
10283         * NEWS: Combine separate "New targets" sections for 8.3.
10284
10285 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10286
10287         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10288         (ppcfbsd_init_abi): Install gdbarch
10289         "fetch_tls_load_module_address" and "get_thread_local_address"
10290         methods.
10291
10292 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10293
10294         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10295         (riscv_fbsd_init_abi): Install gdbarch
10296         "fetch_tls_load_module_address" and "get_thread_local_address"
10297         methods.
10298
10299 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10300
10301         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10302         (i386fbsd_init_abi): Install gdbarch
10303         "fetch_tls_load_module_address" and "get_thread_local_address"
10304         methods.
10305
10306 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10307
10308         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10309         (amd64fbsd_init_abi): Install gdbarch
10310         "fetch_tls_load_module_address" and "get_thread_local_address"
10311         methods.
10312
10313 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10314
10315         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10316         (struct fbsd_pspace_data): New type.
10317         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10318         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10319         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10320         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10321         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10322
10323 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10324
10325         * gdbtypes.c (lookup_struct_elt): New function.
10326         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10327         * gdbtypes.h (struct struct_elt): New type.
10328         (lookup_struct_elt): New prototype.
10329
10330 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10331
10332         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10333         remove disabled code block.
10334
10335 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10336
10337         * gdbarch.sh (get_thread_local_address): New method.
10338         * gdbarch.h, gdbarch.c: Regenerate.
10339         * target.c (target_translate_tls_address): Use
10340         gdbarch_get_thread_local_address if present instead of
10341         target::get_thread_local_address.
10342
10343 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10344
10345         * target.h (target::get_thread_local_address): Update comment.
10346
10347 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10348
10349         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10350         objfile->separate_debug_objfile_backlink if not NULL.
10351
10352 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10353
10354         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10355         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10356         (amd64bsd_store_inferior_registers): Likewise.
10357         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10358         Enable segment base registers.
10359         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10360         PT_GETFSBASE and PT_GETGSBASE.
10361         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10362         PT_SETGSBASE.
10363         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10364         segment base registers.
10365         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10366
10367 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10368
10369         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10370         Update calls to i386_target_description to add 'segments'
10371         parameter.
10372         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10373         add segment base registers.
10374         * arch/i386.c (i386_create_target_description): Add 'segments'
10375         parameter to enable segment base registers.
10376         * arch/i386.h (i386_create_target_description): Likewise.
10377         * features/i386/32bit-segments.xml: New file.
10378         * features/i386/32bit-segments.c: Generate.
10379         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10380         call to i386_target_description to add 'segments' parameter.
10381         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10382         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10383         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10384         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10385         if feature is present.
10386         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10387         Add 'segments' parameter to call to i386_target_description.
10388         (i386_target_description): Add 'segments' parameter to enable
10389         segment base registers.
10390         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10391         to call to i386_target_description.
10392         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10393         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10394         Define I386_NUM_REGS.
10395         (i386_target_description): Add 'segments' parameter to enable
10396         segment base registers.
10397
10398 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10399
10400         PR/24325
10401         * source-cache.c: #undef open and close, to avoid unresolved
10402         externals during linking.
10403
10404 2019-03-12  Tom Tromey  <tromey@adacore.com>
10405
10406         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10407         const.  Add initializers.
10408         (_initialize_remote): Don't initialize ptid globals.
10409
10410 2019-03-12  Pedro Alves  <palves@redhat.com>
10411
10412         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10413
10414 2019-03-12  Pedro Alves  <palves@redhat.com>
10415
10416         * cp-name-parser.y (main): Remove unused 'len' variable.
10417
10418 2019-03-12  Tom Tromey  <tromey@adacore.com>
10419
10420         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10421         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10422
10423 2019-03-12  Tom Tromey  <tromey@adacore.com>
10424
10425         * linux-nat.c (iterate_over_lwps): Update.
10426         (stop_callback): Remove parameter.
10427         (stop_wait_callback, detach_callback, resume_set_callback)
10428         (select_singlestep_lwp_callback, set_ignore_sigint)
10429         (status_callback, resumed_callback, resume_clear_callback)
10430         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10431         data parameter.
10432         (linux_nat_target::detach, linux_nat_target::resume)
10433         (linux_stop_and_wait_all_lwps, select_event_lwp)
10434         (linux_nat_filter_event, linux_nat_wait_1)
10435         (linux_nat_target::kill, linux_nat_target::stop)
10436         (linux_nat_target::stop): Update.
10437         (linux_nat_resume_callback): Change type.
10438         (resume_stopped_resumed_lwps, count_events_callback)
10439         (select_event_lwp_callback): Likewise.
10440         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10441         * arm-linux-nat.c (struct update_registers_data): Remove.
10442         (update_registers_callback): Change type.
10443         (arm_linux_insert_hw_breakpoint1): Update.
10444         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10445         parameter.
10446         (x86_linux_dr_set_addr): Update.
10447         (x86_linux_dr_set_control): Update.
10448         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10449         (iterate_over_lwps): Use gdb::function_view.
10450         * nat/aarch64-linux-hw-point.c (struct
10451         aarch64_dr_update_callback_param): Remove.
10452         (debug_reg_change_callback): Change type.
10453         (aarch64_notify_debug_reg_change): Update.
10454         * s390-linux-nat.c (s390_refresh_per_info): Update.
10455
10456 2019-03-11  Tom Tromey  <tromey@adacore.com>
10457
10458         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10459         redundant assignment to "this_cu".
10460
10461 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10462
10463         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10464
10465 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10466
10467         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10468         from...
10469         (rank_one_type): ... this.
10470
10471 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10472
10473         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10474         from...
10475         (rank_one_type): ... this.
10476
10477 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10478
10479         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10480         from...
10481         (rank_one_type): ... this.
10482
10483 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10484
10485         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10486         from...
10487         (rank_one_type): ... this.
10488
10489 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10490
10491         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10492         from...
10493         (rank_one_type): ... this.
10494
10495 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10496
10497         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10498         from...
10499         (rank_one_type): ... this.
10500
10501 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10502
10503         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10504         from...
10505         (rank_one_type): ... this.
10506
10507 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10508
10509         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10510         from...
10511         (rank_one_type): ... this.
10512
10513 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10514
10515         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10516         from...
10517         (rank_one_type): ... this.
10518
10519 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10520
10521         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10522         from...
10523         (rank_one_type): ... this.
10524
10525 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10526
10527         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10528         from...
10529         (rank_one_type): ... this.
10530
10531 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10532
10533         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10534         from...
10535         (rank_one_type): ... this.
10536
10537 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10538
10539         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10540         inferior-events' shows the example events.
10541
10542 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10543
10544         Support styling on native MS-Windows console
10545
10546         PR/24315
10547         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10548         on MS-Windows if $TERM is not defined.
10549
10550         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10551
10552         * posix-hdep.c (gdb_console_fputs):
10553         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10554         functions.
10555         * ui-file.h (gdb_console_fputs): Add prototype.
10556
10557         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10558         back to fputs only if the former returns zero.
10559
10560 2019-03-07  Tom Tromey  <tom@tromey.com>
10561
10562         * symmisc.c (print_symbol_bcache_statistics): Update.
10563         (print_objfile_statistics): Update.
10564         * symfile.c (allocate_symtab): Update.
10565         * stabsread.c: Don't include bcache.h.
10566         * psymtab.h (struct psymbol_bcache): Don't declare.
10567         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10568         (psymbol_bcache_init, psymbol_bcache_free)
10569         (psymbol_bcache_get_bcache): Don't declare.
10570         * psymtab.c (struct psymbol_bcache): Remove.
10571         (psymtab_storage::psymtab_storage): Update.
10572         (psymtab_storage::~psymtab_storage): Update.
10573         (psymbol_bcache_init, psymbol_bcache_free)
10574         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10575         (add_psymbol_to_bcache): Update.
10576         (allocate_psymtab): Update.
10577         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10578         macro_cache>: No longer pointers.
10579         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10580         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10581         * macrotab.c (macro_bcache): Update.
10582         * macroexp.c: Don't include bcache.h.
10583         * gdbtypes.c (check_types_worklist): Update.
10584         (types_deeply_equal): Remove TRY/CATCH.  Update.
10585         * elfread.c (elf_symtab_read): Update.
10586         * dwarf2read.c: Don't include bcache.h.
10587         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10588         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10589         (print_bcache_statistics, bcache_memory_used): Don't declare.
10590         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10591         methods.  Rename all data members.
10592         * bcache.c (struct bcache): Move to bcache.h.
10593         (bcache::expand_hash_table): Rename from expand_hash_table.
10594         (bcache): Remove.
10595         (bcache::insert): Rename from bcache_full.
10596         (bcache::compare): Rename from bcache_compare.
10597         (bcache_xmalloc): Remove.
10598         (bcache::~bcache): Rename from bcache_xfree.
10599         (bcache::print_statistics): Rename from print_bcache_statistics.
10600         (bcache::memory_used): Rename from bcache_memory_used.
10601
10602 2019-03-07  Pedro Alves  <palves@redhat.com>
10603
10604         * infrun.c (normal_stop): Also check for
10605         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10606
10607 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10608
10609         * f-lang.c (value_from_host_double): Moved to...
10610         * value.c (value_from_host_double): ...here.
10611         * value.h (value_from_host_double): Declare.
10612         * guile/scm-math.c (vlscm_convert_typed_number): Use
10613         value_from_host_double.
10614         (vlscm_convert_number): Likewise.
10615         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10616         * python/py-value.c (convert_value_from_python): Likewise.
10617
10618 2019-03-06  Tom Tromey  <tom@tromey.com>
10619
10620         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10621
10622 2019-03-06  Tom Tromey  <tom@tromey.com>
10623
10624         * utils.h (free_current_contents): Don't declare.
10625         * utils.c (free_current_contents): Remove.
10626
10627 2019-03-06  Tom Tromey  <tom@tromey.com>
10628
10629         * top.c (quit_force): Update.
10630         * main.c (captured_command_loop): Update.
10631         * common/new-op.c (operator new): Update.
10632         * common/common-exceptions.c (struct catcher)
10633         <save_cleanup_chain>: Remove member.
10634         (exceptions_state_mc_init): Update.
10635         (exception_try_scope_entry): Return nullptr.
10636         (exception_try_scope_exit, exception_rethrow)
10637         (throw_exception_sjlj, throw_exception_cxx): Update.
10638         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10639         (all_cleanups, do_cleanups, discard_cleanups)
10640         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10641         (restore_cleanups, restore_final_cleanups): Don't declare.
10642         (do_final_cleanups): Remove parameter.
10643         * common/cleanups.c (cleanup_chain, make_cleanup)
10644         (make_cleanup_dtor, all_cleanups, do_cleanups)
10645         (discard_my_cleanups, discard_cleanups)
10646         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10647         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10648         (null_cleanup): Remove.
10649         (do_final_cleanups): Remove parameter.
10650
10651 2019-03-06  Tom Tromey  <tom@tromey.com>
10652
10653         * remote.c (remote_target::remote_parse_stop_reply): Use
10654         unique_xmalloc_ptr.
10655
10656 2019-03-06  Tom Tromey  <tom@tromey.com>
10657
10658         * stabsread.c (struct stabs_field_info): Rename from field_info.
10659         <list, fnlist>: Add initializers.
10660         <obstack>: New member.
10661         (read_member_functions, read_struct_fields, read_baseclasses):
10662         Allocate on obstack.  Don't use cleanups.
10663         (read_one_struct_field, read_member_functions, read_struct_fields)
10664         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10665         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10666         (read_struct_type): Update.
10667
10668 2019-03-06  Tom Tromey  <tom@tromey.com>
10669
10670         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10671         * common/filestuff.h (make_cleanup_close): Don't declare.
10672         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10673         Remove.
10674
10675 2019-03-06  Tom Tromey  <tom@tromey.com>
10676
10677         * solib-aix.c: Use make_scope_exit.
10678
10679 2019-03-06  Tom Tromey  <tom@tromey.com>
10680
10681         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10682         Use make_scope_exit.
10683
10684 2019-03-06  Tom Tromey  <tom@tromey.com>
10685
10686         * solib-svr4.c (disable_probes_interface): Remove parameter.
10687         (svr4_handle_solib_event): Use make_scope_exit.
10688
10689 2019-03-06  Tom Tromey  <tom@tromey.com>
10690
10691         * remote.c (struct stop_reply_deleter): Remove.
10692         (stop_reply_up): Update.
10693         (struct stop_reply): Derive from notif_event.  Don't typedef.
10694         <regcache>: Now a std::vector.
10695         (stop_reply_xfree): Remove.
10696         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10697         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10698         (remote_target::discard_pending_stop_replies): Use delete.
10699         (remote_target::remote_parse_stop_reply): Update.
10700         (remote_target::process_stop_reply): Update.
10701         * remote-notif.h (struct notif_event): Add virtual destructor.
10702         Remove "dtr" member.
10703         (struct notif_client) <alloc_event>: Return a unique_ptr.
10704         (notif_event_xfree): Don't declare.
10705         (notif_event_up): New typedef.
10706         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10707         (notif_event_xfree, do_notif_event_xfree): Remove.
10708         (remote_notif_state_xfree): Update.
10709
10710 2019-03-06  Tom Tromey  <tom@tromey.com>
10711
10712         * infrun.c (displaced_step_clear_cleanup): Now a
10713         forward_scope_exit type.
10714         (displaced_step_prepare_throw): Update.
10715         (displaced_step_fixup): Update.
10716
10717 2019-03-06  Tom Tromey  <tom@tromey.com>
10718
10719         * inferior.h (class inferior): Update comment.
10720         * gdbthread.h (class thread_info): Update comment.
10721
10722 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10723             Tom Tromey  <tom@tromey.com>
10724
10725         * stabsread.h (struct stab_section_list): Remove.
10726         (coffstab_build_psymtabs): Update.
10727         * dbxread.c (symbuf_sections): Now a std::vector.
10728         (sect_idx): New global.
10729         (fill_symbuf): Update.
10730         (coffstab_build_psymtabs): Change type of stabsects parameter.
10731         Update.
10732         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10733         std::vector.
10734         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10735         (coff_locate_sections): Update.
10736         (coff_symfile_read): Remove cleanups.  Update.
10737         (init_stringtab): Add storage parameter.
10738         (free_stringtab, free_stringtab_cleanup): Remove.
10739         (init_lineno): Add storage parameter.
10740         (free_linetab, free_linetab_cleanup): Remove.
10741
10742 2019-03-06  Pedro Alves  <palves@redhat.com>
10743
10744         * linux-fork.c (fork_info::clobber_regs): Delete.
10745         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10746         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10747         comment.  Adjust.
10748         (scoped_switch_fork_info::scoped_switch_fork_info)
10749         (checkpoint_command, linux_fork_context): Adjust
10750         fork_save_infrun_state calls.
10751
10752 2019-03-06  Pedro Alves  <palves@redhat.com>
10753
10754         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10755         (inf_has_multiple_threads): Return 'bool' and rewrite using
10756         inferior_info::threads().
10757
10758 2019-03-06  Pedro Alves  <palves@redhat.com>
10759
10760         * linux-fork.c: Include <list>.
10761         (fork_list): Now a std::list instance.
10762         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10763         (forks_exist_p, find_last_fork): Adjust.
10764         (new_fork): Delete.
10765         (one_fork_p): New.
10766         (add_fork): Adjust.
10767         (free_fork): Delete, folded into fork_info::~fork_info().
10768         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10769         Adjust.
10770         (init_fork_list): Delete.
10771         (linux_fork_killall, linux_fork_mourn_inferior)
10772         (linux_fork_detach, info_checkpoints_command): Adjust.
10773         (_initialize_linux_fork): No longer call init_fork_list.
10774
10775 2019-03-06  Pedro Alves  <palves@redhat.com>
10776
10777         * linux-fork.c (new_fork): New, split out of ...
10778         (add_fork): ... this.  Return void.  Move "first fork" special
10779         case from here, to ...
10780         (checkpoint_command): ... here.
10781         * linux-linux.h (add_fork): Return void.
10782
10783 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10784
10785         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10786
10787 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10788             Chris January  <chris.january@arm.com>
10789             David Lecomber  <david.lecomber@arm.com>
10790
10791         * f-exp.y: New token, UNOP_INTRINSIC.
10792         (exp): New pattern using UNOP_INTRINSIC token.
10793         (f77_keywords): Add 'abs' keyword.
10794         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10795         (value_from_host_double): New function.
10796         (evaluate_subexp_f): Support UNOP_ABS.
10797
10798 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10799
10800         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10801         types.
10802
10803 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10804
10805         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10806         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10807         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10808
10809 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10810
10811         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10812
10813 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10814             Chris January  <chris.january@arm.com>
10815
10816         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10817         * f-exp.y: Define 'KIND' token.
10818         (exp): New pattern for KIND expressions.
10819         (ptype): Handle types with a kind extension.
10820         (direct_abs_decl): Extend to spot kind extensions.
10821         (f77_keywords): Add 'kind' to the list.
10822         (push_kind_type): New function.
10823         (convert_to_kind_type): New function.
10824         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10825         * parse.c (operator_length_standard): Likewise.
10826         * parser-defs.h (enum type_pieces): Add tp_kind.
10827         * std-operator.def: Add UNOP_KIND.
10828
10829 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10830
10831         * f-exp.y (f_parse): Set yydebug.
10832
10833 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10834
10835         * f-lang.c (evaluate_subexp_f): New function.
10836         (exp_descriptor_f): New global.
10837         (f_language_defn): Use exp_descriptor_f instead of
10838         exp_descriptor_standard.
10839
10840 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10841
10842         * f-exp.y (struct token): Add comments.
10843         (dot_ops): Remove uppercase versions and the end marker.
10844         (f77_keywords): Likewise.
10845         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10846         entries in the dot_ops array are case insensitive, and use
10847         strncasecmp to compare strings.  Also some whitespace cleanup in
10848         this area.  Similar for the f77_keywords array, except entries in
10849         this list might be case sensitive.
10850
10851 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10852
10853         * f-exp.y (struct f77_boolean_val): Add comments.
10854         (boolean_values): Remove uppercase versions, and end marker.
10855         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10856         and use strncasecmp to achieve case insensitivity.  Additionally,
10857         perform whitespace cleanup around this code.
10858
10859 2019-03-06  Tom Tromey  <tromey@adacore.com>
10860
10861         * remote-sim.c (gdbsim_target_open): Use result of
10862         gdb_argv::release.
10863
10864 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10865         Dirk Schubert  <dirk.schubert@arm.com>
10866         Chris January  <chris.january@arm.com>
10867
10868         * eval.c (evaluate_subexp_standard): Call Fortran argument
10869         wrapping logic.
10870         * f-lang.c (struct value): A value which can be passed into a
10871         Fortran function call.
10872         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10873         where appropriate.
10874         (struct type): Value ready for a Fortran function call.
10875         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10876         is needed.
10877         * f-lang.h (fortran_argument_convert): Declaration.
10878         (fortran_preserve_arg_pointer): Declaration.
10879         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10880
10881 2019-03-05  Tom Tromey  <tromey@adacore.com>
10882
10883         * python/py-prettyprint.c (print_string_repr): Remove #if.
10884         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10885
10886 2019-03-05  Tom Tromey  <tromey@adacore.com>
10887
10888         * target.c (the_dummy_target): Move later.  Change type to
10889         "dummy_target".
10890         (initialize_targets): Don't initialize the_dummy_target.
10891
10892 2019-03-05  Tom Tromey  <tromey@adacore.com>
10893
10894         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10895         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10896
10897 2019-03-05  Tom Tromey  <tromey@adacore.com>
10898
10899         * windows-nat.c (windows_nat_target::attach)
10900         (windows_nat_target::detach): Don't call gdb_flush.
10901         * valprint.c (generic_val_print, val_print, val_print_string):
10902         Don't call gdb_flush.
10903         * utils.c (defaulted_query): Don't call gdb_flush.
10904         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10905         * target.c (target_announce_detach): Don't call gdb_flush.
10906         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10907         * remote.c (extended_remote_target::attach): Don't call
10908         gdb_flush.
10909         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10910         * printcmd.c (do_examine): Don't call gdb_flush.
10911         (info_display_command): Don't call gdb_flush.
10912         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10913         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10914         * memattr.c (info_mem_command): Don't call gdb_flush.
10915         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10916         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10917         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10918         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10919         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10920         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10921         (gnu_nat_target::detach): Don't call gdb_flush.
10922         * f-valprint.c (f_val_print): Don't call gdb_flush.
10923         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10924         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10925         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10926         gdb_flush.
10927         * c-valprint.c (c_val_print): Don't call gdb_flush.
10928         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10929
10930 2019-03-05  Tom Tromey  <tromey@adacore.com>
10931
10932         * varobj.c (update_dynamic_varobj_children): Update.
10933         (install_default_visualizer): Use reset, not release.
10934         * value.c (set_internalvar): Update.
10935         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10936         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10937         ATTRIBUTE_UNUSED_RESULT.
10938
10939 2019-03-05  Tom Tromey  <tromey@adacore.com>
10940
10941         * remote.c (class scoped_remote_fd) <release>: Add
10942         ATTRIBUTE_UNUSED_RESULT.
10943
10944 2019-03-05  Tom Tromey  <tromey@adacore.com>
10945
10946         * macroexp.c (struct macro_buffer) <release>: Add
10947         ATTRIBUTE_UNUSED_RESULT.
10948
10949 2019-03-05  Tom Tromey  <tromey@adacore.com>
10950
10951         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10952         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10953         ATTRIBUTE_UNUSED_RESULT.
10954
10955 2019-03-05  Tom Tromey  <tromey@adacore.com>
10956
10957         * common/scoped_fd.h (class scoped_fd) <release>: Add
10958         ATTRIBUTE_UNUSED_RESULT.
10959
10960 2019-03-05  Tom Tromey  <tromey@adacore.com>
10961
10962         * parser-defs.h (struct parser_state) <release>: Add
10963         ATTRIBUTE_UNUSED_RESULT.
10964
10965 2019-03-05  Tom Tromey  <tromey@adacore.com>
10966
10967         * utils.h (class gdb_argv) <release>: Add
10968         ATTRIBUTE_UNUSED_RESULT.
10969         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10970
10971 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10972
10973         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10974         for-loop range, to avoid compiler warnings.
10975
10976         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10977         avoid compiler warnings about unused variables.
10978
10979         * NEWS: Mention end of support for native debugging on MS-Windows
10980         before XP.
10981
10982         PR gdb/24292
10983         * common/netstuff.c:
10984         * gdbserver/gdbreplay.c
10985         * gdbserver/remote-utils.c:
10986         * ser-tcp.c:
10987         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10988         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10989         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10990         'getaddrinfo' and 'freeaddrinfo' were not available before
10991         Windows XP, and mingw.org's MinGW headers by default define
10992         _WIN32_WINNT to 0x500.
10993
10994 2019-03-01  Gary Benson <gbenson@redhat.com>
10995
10996         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10997
10998 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10999             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11000
11001         PR gdb/8527
11002         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11003         set_sigint_trap, clear_sigint_trap.
11004
11005 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11006
11007         * target.c (target_detach): Clear the regcache and the
11008         frame cache.
11009
11010 2019-02-27  Pedro Alves  <palves@redhat.com>
11011
11012         * utils.c (set_screen_size): When we cap the height/width sizes,
11013         tweak the corresponding command variable to show "unlimited":
11014
11015 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11016             Pedro Alves  <palves@redhat.com>
11017
11018         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11019         before calling rl_set_screen_size.
11020
11021 2019-02-27  Tom Tromey  <tromey@adacore.com>
11022
11023         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11024         define.
11025         * python/py-value.c: Remove Python 2.4 workaround.
11026         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11027         workaround.
11028         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11029         Python 2.4 workaround.
11030         * python/python-internal.h: Remove Python 2.4 comment.
11031         (Py_ssize_t): Don't define.
11032         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11033         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11034         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11035         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11036         * python/python.c (do_start_initialization): Remove Python 2.4
11037         workaround.
11038         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11039         (print_children): Remove Python 2.4 workaround.
11040         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11041         workaround.
11042         (CHARBUFFERPROC_NAME): Remove.
11043         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11044         Python 2.4 workaround.
11045
11046 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11047
11048         * NEWS: Note minimum Python version.
11049
11050 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11051
11052         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11053         code from these functions.  Remove corresponding ifdefs.  Use
11054         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11055         Remove gotos and target of gotos.
11056         (infpy_search_memory): Likewise.
11057
11058 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11059
11060         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11061         (hppa_gdbarch_init): Don't register deleted functions with
11062         gdbarch.
11063
11064 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11065
11066         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11067         (h8300_unwind_sp): Delete.
11068         (h8300_dummy_id): Delete.
11069         (h8300_gdbarch_init): Don't register deleted functions with
11070         gdbarch.
11071
11072 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11073
11074         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11075         (ft32_unwind_pc): Delete.
11076         (ft32_unwind_sp): Delete.
11077         (ft32_gdbarch_init): Don't register deleted functions with
11078         gdbarch.
11079
11080 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11081
11082         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11083         (frv_unwind_pc): Delete.
11084         (frv_unwind_sp): Delete.
11085         (frv_gdbarch_init): Don't register deleted functions with
11086         gdbarch.
11087
11088 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11089
11090         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11091         (riscv_unwind_pc): Delete.
11092         (riscv_unwind_sp): Delete.
11093         (riscv_gdbarch_init): Don't register deleted functions with
11094         gdbarch.
11095
11096 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11097
11098         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11099         (csky_unwind_pc): Delete.
11100         (csky_unwind_sp): Delete.
11101         (csky_gdbarch_init): Don't register deleted functions with
11102         gdbarch.
11103
11104 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11105
11106         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11107         (cris_unwind_pc): Delete.
11108         (cris_unwind_sp): Delete.
11109         (cris_gdbarch_init): Don't register deleted functions with
11110         gdbarch.
11111
11112 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11113
11114         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11115         (bfin_unwind_pc): Delete.
11116         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11117
11118 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11119
11120         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11121         (arm_unwind_pc): Delete.
11122         (arm_unwind_sp): Delete.
11123         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11124
11125 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11126
11127         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11128         (arc_unwind_pc): Delete.
11129         (arc_unwind_sp): Delete.
11130         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11131
11132 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11133
11134         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11135         (alpha_unwind_pc): Delete.
11136         (alpha_gdbarch_init): Don't register deleted functions with
11137         gdbarch.
11138
11139 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11140
11141         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11142         (aarch64_unwind_pc): Delete.
11143         (aarch64_unwind_sp): Delete.
11144         (aarch64_gdbarch_init): Don't register deleted functions with
11145         gdbarch.
11146
11147 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11148
11149         * gdbtypes.c (type_align): Don't consider static members when
11150         computing structure alignment.
11151
11152 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11153
11154         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11155         return 0 for other types.
11156         * arch-utils.c (default_type_align): Always return 0.
11157         * gdbarch.h: Regenerate.
11158         * gdbarch.sh (type_align): Extend comment.
11159         * gdbtypes.c (type_align): Add additional comments, always call
11160         gdbarch_type_align before applying the default rules.
11161         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11162         generic code will then apply a suitable default.
11163         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11164         types, return 0 for other types.
11165
11166 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11167
11168         * NEWS: Create a new section for the next release branch.
11169         Rename the section of the current branch, now that it has
11170         been cut.
11171
11172 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11173
11174         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11175         * version.in: Bump version to 8.3.50.DATE-git.
11176
11177 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11178
11179         * aix-thread.c (ptid_cmp): Remove unused variable.
11180         (get_signaled_thread): Likewise.
11181         (store_regs_user_thread): Likewise.
11182         (store_regs_kernel_thread): Likewise.
11183         (fetch_regs_kernel_thread): Remove shadowed variable.
11184
11185 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11186
11187         * features/riscv/32bit-cpu.xml: Add register numbers.
11188         * features/riscv/32bit-fpu.c: Regenerate.
11189         * features/riscv/32bit-fpu.xml: Add register numbers.
11190         * features/riscv/64bit-cpu.xml: Add register numbers.
11191         * features/riscv/64bit-fpu.c: Regenerate.
11192         * features/riscv/64bit-fpu.xml: Add register numbers.
11193
11194 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11195
11196         * NEWS: Mention two argument form of gdb.Value constructor.
11197         * python/py-value.c (convert_buffer_and_type_to_value): New
11198         function.
11199         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11200         Add support for handling an optional second argument.  Call
11201         convert_buffer_and_type_to_value as appropriate.
11202         * python/python-internal.h (Py_buffer_deleter): New struct.
11203         (Py_buffer_up): New typedef.
11204
11205 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11206
11207         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11208         instead of releasing ownership.
11209
11210 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11211
11212         * dwarf2read.c (open_and_init_dwp_file): Call
11213         elf_numsections instead of bfd_count_sections to initialize
11214         dwp_file->num_sections.
11215
11216 2019-02-25  Tom Tromey  <tromey@adacore.com>
11217
11218         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11219
11220 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11221
11222         * gcore.in: Add '--readnever' option when invoking GDB.
11223
11224 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11225
11226         * MAINTAINERS: Update my email address.
11227
11228 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11229
11230         * build-id.c (build_id_to_debug_bfd_1): New function.
11231         (build_id_to_debug_bfd): Look for separate debug file in
11232         sysroot.
11233
11234 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11235
11236         * gdbarch.sh: Update the copyright year range that is placed into
11237         generated files.
11238
11239 2019-02-22  Keith Seitz  <keiths@redhat.com>
11240
11241         PR symtab/23853
11242         * linespec.c (create_sals_line_offset): Search for the default
11243         symtab's filename instead of its fullname.
11244
11245 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11246
11247         * NEWS: Update style defaults.
11248
11249 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11250
11251         * main.c (captured_main_1): Disable styling in batch mode.
11252
11253 2019-02-20  Tom Tromey  <tom@tromey.com>
11254
11255         * symtab.c (symtab_symbol_info): Fix typos.
11256
11257 2019-02-20  Tom Tromey  <tromey@adacore.com>
11258
11259         * findcmd.c (_initialize_mem_search): Use upper case for
11260         metasyntactic variables.
11261
11262 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11263
11264         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11265         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11266
11267 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11268
11269         * top.h (source_file_name): Change to std::string.
11270         * top.c (source_file_name): Likewise.
11271         (command_line_input): Adjust.
11272         * cli/cli-script.c (script_from_file): Adjust.
11273
11274 2019-02-19  Tom Tromey  <tromey@adacore.com>
11275
11276         * ravenscar-thread.c
11277         (ravenscar_thread_target::update_thread_list): Don't call
11278         ada_build_task_list.
11279         * ada-lang.h (ada_build_task_list): Don't declare.
11280         * ada-tasks.c (struct ada_tasks_inferior_data)
11281         <task_list_valid_p>: Now bool.
11282         (read_known_tasks, ada_task_list_changed)
11283         (ada_tasks_invalidate_inferior_data): Update.
11284         (read_known_tasks_array): Return bool.
11285         (read_known_tasks_list): Likewise.
11286         (read_known_tasks): Return void.
11287         (ada_build_task_list): Now static.
11288
11289 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11290
11291         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11292         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11293
11294 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11295
11296         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11297         variant for ada_tasks_pspace_data_handle and
11298         ada_tasks_inferior_data_handle.
11299         (ada_tasks_pspace_data_cleanup): New function.
11300         (ada_tasks_inferior_data_cleanup): New function.
11301
11302 2019-02-17  Tom Tromey  <tom@tromey.com>
11303
11304         * macrotab.h (macro_source_fullname): Return a std::string.
11305         * macrotab.c (macro_include, check_for_redefinition)
11306         (macro_undef, macro_lookup_definition, foreach_macro)
11307         (foreach_macro_in_scope): Update.
11308         (macro_source_fullname): Return a std::string.
11309         * macrocmd.c (show_pp_source_pos): Update.
11310
11311 2019-02-17  Tom Tromey  <tom@tromey.com>
11312
11313         * macrocmd.c (show_pp_source_pos): Style the file names.
11314
11315 2019-02-17  Tom Tromey  <tom@tromey.com>
11316
11317         PR tui/24197:
11318         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11319
11320 2019-02-17  Tom Tromey  <tom@tromey.com>
11321
11322         * ada-lang.c (user_select_syms): Use filtered printing.
11323         * utils.c (wrap_style): New global.
11324         (desired_style): Remove.
11325         (emit_style_escape): Add stream parameter.
11326         (set_output_style, reset_terminal_style, prompt_for_continue):
11327         Update.
11328         (flush_wrap_buffer): Only flush gdb_stdout.
11329         (wrap_here): Set wrap_style.
11330         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11331         treat escape sequences as a character.  Change when wrap buffer is
11332         flushed.
11333         (fputs_styled): Do not set the output style when the default is
11334         requested.
11335         * ui-style.h (struct ui_file_style) <is_default>: New method.
11336         * source.c (print_source_lines_base): Emit escape sequences in one
11337         piece.
11338
11339 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11340
11341         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11342         integers and enumeration types.
11343
11344 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11345
11346         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11347         instead of lookup_symbol_in_language
11348         (do_exact_match): New function.
11349         (ada_get_symbol_name_matcher): Return do_exact_match when
11350         doing a verbatim match.
11351
11352 2019-02-15  Tom Tromey  <tromey@adacore.com>
11353
11354         * ravenscar-thread.c (ravenscar_thread_target::resume)
11355         (ravenscar_thread_target::wait): Special case wildcard requests.
11356
11357 2019-02-15  Tom Tromey  <tromey@adacore.com>
11358
11359         * ravenscar-thread.c (base_ptid): Remove.
11360         (struct ravenscar_thread_target) <close>: New method.
11361         <m_base_ptid>: New member.
11362         <update_inferior_ptid, active_task, task_is_currently_active,
11363         runtime_initialized>: Declare methods.
11364         <ravenscar_thread_target>: Add constructor.
11365         (ravenscar_thread_target::task_is_currently_active)
11366         (ravenscar_thread_target::update_inferior_ptid)
11367         (ravenscar_runtime_initialized): Rename.  Now methods.
11368         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11369         (ravenscar_thread_target::update_thread_list): Update.
11370         (ravenscar_thread_target::active_task): Now method.
11371         (ravenscar_thread_target::store_registers)
11372         (ravenscar_thread_target::prepare_to_store)
11373         (ravenscar_thread_target::prepare_to_store)
11374         (ravenscar_thread_target::mourn_inferior): Update.
11375         (ravenscar_inferior_created): Use "new" to create target.
11376         (ravenscar_thread_target::get_ada_task_ptid): Update.
11377         (_initialize_ravenscar): Don't initialize base_ptid.
11378         (ravenscar_ops): Remove global.
11379
11380 2019-02-15  Tom Tromey  <tromey@adacore.com>
11381
11382         * target.h (push_target): Declare new overload.
11383         * target.c (push_target): New overload, taking an rvalue reference.
11384         * remote.c (remote_target::open_1): Use push_target overload.
11385         * corelow.c (core_target_open): Use push_target overload.
11386
11387 2019-02-15  Tom Tromey  <tromey@adacore.com>
11388
11389         * ravenscar-thread.c (is_ravenscar_task)
11390         (ravenscar_task_is_currently_active): Return bool.
11391         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11392         (_initialize_ravenscar): Remove "(void)".
11393         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11394         Return bool.
11395
11396 2019-02-15  Tom Tromey  <tromey@adacore.com>
11397
11398         * ravenscar-thread.c (ravenscar_runtime_initializer)
11399         (has_ravenscar_runtime, get_running_thread_id)
11400         (ravenscar_thread_target::resume): Fix indentation.
11401
11402 2019-02-15  Tom Tromey  <tromey@adacore.com>
11403
11404         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11405         from ravenscar_arch_ops.
11406         (sparc_ravenscar_ops::fetch_registers)
11407         (sparc_ravenscar_ops::store_registers): Now methods.
11408         (sparc_ravenscar_prepare_to_store): Remove.
11409         (sparc_ravenscar_ops): Redefine.
11410         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11411         methods and destructor.  Remove members.
11412         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11413         (ravenscar_thread_target::store_registers)
11414         (ravenscar_thread_target::prepare_to_store): Update.
11415         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11416         Remove.
11417         (struct ppc_ravenscar_powerpc_ops): Derive from
11418         ravenscar_arch_ops.
11419         (ppc_ravenscar_powerpc_ops::fetch_registers)
11420         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11421         (ppc_ravenscar_powerpc_ops): Redefine.
11422         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11423         (ppc_ravenscar_e500_ops::fetch_registers)
11424         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11425         (ppc_ravenscar_e500_ops): Redefine.
11426         * aarch64-ravenscar-thread.c
11427         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11428         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11429         (aarch64_ravenscar_fetch_registers)
11430         (aarch64_ravenscar_store_registers): Now methods.
11431         (aarch64_ravenscar_ops): Redefine.
11432
11433 2019-02-15  Tom Tromey  <tromey@adacore.com>
11434
11435         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11436         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11437         (ravenscar_thread_target::stopped_by_watchpoint)
11438         (ravenscar_thread_target::stopped_data_address)
11439         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11440
11441 2019-02-15  Tom Tromey  <tromey@adacore.com>
11442
11443         * ravenscar-thread.c: Fix some typos.
11444
11445 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11446             Tom Tromey  <tromey@adacore.com>
11447
11448         * ada-lang.c (ada_exception_sal): Change addr_string to a
11449         std::string.
11450         (create_ada_exception_catchpoint): Update.
11451
11452 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11453             Tom Tromey  <tromey@adacore.com>
11454
11455         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11456         (bp_location_ops): Remove.
11457         (base_breakpoint_allocate_location): Update.
11458         (free_bp_location): Update.
11459         * ada-lang.c (class ada_catchpoint_location)
11460         <ada_catchpoint_location>: Remove ops parameter.
11461         (ada_catchpoint_location_dtor): Remove.
11462         (ada_catchpoint_location_ops): Remove.
11463         (allocate_location_exception): Update.
11464         * breakpoint.h (struct bp_location_ops): Remove.
11465         (class bp_location) <bp_location>: Remove bp_location_ops
11466         parameter.
11467         <~bp_location>: Add destructor.
11468         <ops>: Remove.
11469
11470 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11471             Pedro Alves  <palves@redhat.com>
11472
11473         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11474         'PATH_MAX'.
11475
11476 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11477             Samuel Thibault  <samuel.thibault@gnu.org>
11478             Thomas Schwinge  <thomas@codesourcery.com>
11479
11480         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11481         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11482
11483 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11484
11485         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11486         (check_empty): Use "const char *".
11487
11488         * gnu-nat.c (gnu_nat_target::detach): Instead of
11489         'detach_inferior (pid)' call
11490         'detach_inferior (find_inferior_pid (pid))'.
11491
11492         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11493         'nat/fork-inferior.o'.
11494         * gnu-nat.c: #include "nat/fork-inferior.h".
11495
11496         * gnu-nat.c (gnu_nat_target::detach): Instead of
11497         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11498         * gnu-nat.h: #include "inf-child.h".
11499         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11500         'i386_gnu_nat_target::fetch_registers'.
11501         (gnu_store_registers): Rename/move to
11502         'i386_gnu_nat_target::store_registers'.
11503
11504         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11505         * gnu-nat.h (mach_thread_info): New function.
11506         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11507
11508         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11509
11510 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11511
11512         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11513
11514 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11515
11516         * windows-nat.c (windows_add_thread): Add new parameter
11517         "main_thread_p" with default value set to false.  Update
11518         function documentation as well as all callers.
11519         (windows_delete_thread): Likewise.
11520         (fake_create_process): Update call to windows_add_thread.
11521         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11522         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11523         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11524         call to windows_delete_thread.
11525
11526 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11527
11528         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11529
11530 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11531
11532         * symfile.c (find_separate_debug_file): Use canonical path of
11533         sysroot with child_path instead of gdb_sysroot if it is valid.
11534
11535 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11536
11537         * symfile.c (find_separate_debug_file): Use child_path to
11538         determine if an object file is under a sysroot.
11539
11540 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11541
11542         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11543         unittests/child-path-selftests.c.
11544         * common/pathstuff.c (child_path): New function.
11545         * common/pathstuff.h (child_path): New prototype.
11546         * unittests/child-path-selftests.c: New file.
11547
11548 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11549
11550         * symfile.c (find_separate_debug_file): Look for separate debug
11551         files in debug directories under the sysroot.
11552
11553 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11554
11555         * symtab.h (struct minimal_symbol data_p): New const method.
11556         (struct minimal_symbol text_p): Likewise.
11557         * symtab.c (output_source_filename): Use file name style
11558         to print file name.
11559         (print_symbol_info): Likewise.
11560         (print_msymbol_info): Use address style to print addresses.
11561         Use function name style to print executable text symbols.
11562         (expand_symtab_containing_pc): Use data_p.
11563         (find_pc_sect_compunit_symtab): Likewise.
11564
11565 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11566
11567         * breakpoint.c (describe_other_breakpoints): Use address style
11568         to print addresses.
11569         (say_where): Likewise.
11570
11571 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11572
11573         * ada-typeprint.c (print_func_type): Print function name
11574         style to print function name.
11575         * c-typeprint.c (c_print_type_1): Likewise.
11576
11577 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11578
11579         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11580         for execve.
11581
11582 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11583
11584         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11585         type_stack.
11586
11587 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11588
11589         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11590         TYPE_CODE_REF types.
11591
11592 2019-02-08  Jim Wilson  <jimw@sifive.com>
11593
11594         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11595         (riscv_linux_fregset): New.
11596         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11597
11598 2019-02-07  Tom Tromey  <tom@tromey.com>
11599
11600         * thread.c (thread_cancel_execution_command): Update.
11601         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11602         methods.
11603         (struct thread_fsm_ops): Remove.
11604         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11605         (thread_fsm_should_stop, thread_fsm_return_value)
11606         (thread_fsm_set_finished, thread_fsm_finished_p)
11607         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11608         Don't declare.
11609         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11610         * infrun.c (clear_proceed_status_thread)
11611         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11612         (print_stop_event): Update.
11613         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11614         Add constructor.
11615         (step_command_fsm_ops): Remove.
11616         (new_step_command_fsm): Remove.
11617         (step_1): Update.
11618         (step_command_fsm::should_stop): Rename from
11619         step_command_fsm_should_stop.
11620         (step_command_fsm::clean_up): Rename from
11621         step_command_fsm_clean_up.
11622         (step_command_fsm::do_async_reply_reason): Rename from
11623         step_command_fsm_async_reply_reason.
11624         (struct until_next_fsm): Inherit from thread_fsm.  Add
11625         constructor.
11626         (until_next_fsm_ops): Remove.
11627         (new_until_next_fsm): Remove.
11628         (until_next_fsm::should_stop): Rename from
11629         until_next_fsm_should_stop.
11630         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11631         (until_next_fsm::do_async_reply_reason): Rename from
11632         until_next_fsm_async_reply_reason.
11633         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11634         constructor.  Change type of breakpoint.
11635         (finish_command_fsm_ops): Remove.
11636         (new_finish_command_fsm): Remove.
11637         (finish_command_fsm::should_stop): Rename from
11638         finish_command_fsm_should_stop.
11639         (finish_command_fsm::clean_up): Rename from
11640         finish_command_fsm_clean_up.
11641         (finish_command_fsm::return_value): Rename from
11642         finish_command_fsm_return_value.
11643         (finish_command_fsm::do_async_reply_reason): Rename from
11644         finish_command_fsm_async_reply_reason.
11645         (finish_command): Update.
11646         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11647         Add constructor.
11648         (call_thread_fsm_ops): Remove.
11649         (call_thread_fsm::call_thread_fsm): Rename from
11650         new_call_thread_fsm.
11651         (call_thread_fsm::should_stop): Rename from
11652         call_thread_fsm_should_stop.
11653         (call_thread_fsm::should_notify_stop): Rename from
11654         call_thread_fsm_should_notify_stop.
11655         (run_inferior_call, call_function_by_hand_dummy): Update.
11656         * cli/cli-interp.c (should_print_stop_to_console): Update.
11657         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11658         Add constructor.  Change type of location_breakpoint,
11659         caller_breakpoint.
11660         (until_break_fsm_ops): Remove.
11661         (new_until_break_fsm): Remove.
11662         (until_break_fsm::should_stop): Rename from
11663         until_break_fsm_should_stop.
11664         (until_break_fsm::clean_up): Rename from
11665         until_break_fsm_clean_up.
11666         (until_break_fsm::do_async_reply_reason): Rename from
11667         until_break_fsm_async_reply_reason.
11668         (until_break_command): Update.
11669         * thread-fsm.c: Remove.
11670         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11671
11672 2019-02-07  Tom Tromey  <tom@tromey.com>
11673
11674         * yy-remap.h: Add include guard.
11675         * xtensa-tdep.h: Add include guard.
11676         * xcoffread.h: Rename include guard.
11677         * varobj-iter.h: Add include guard.
11678         * tui/tui.h: Rename include guard.
11679         * tui/tui-winsource.h: Rename include guard.
11680         * tui/tui-wingeneral.h: Rename include guard.
11681         * tui/tui-windata.h: Rename include guard.
11682         * tui/tui-win.h: Rename include guard.
11683         * tui/tui-stack.h: Rename include guard.
11684         * tui/tui-source.h: Rename include guard.
11685         * tui/tui-regs.h: Rename include guard.
11686         * tui/tui-out.h: Rename include guard.
11687         * tui/tui-layout.h: Rename include guard.
11688         * tui/tui-io.h: Rename include guard.
11689         * tui/tui-hooks.h: Rename include guard.
11690         * tui/tui-file.h: Rename include guard.
11691         * tui/tui-disasm.h: Rename include guard.
11692         * tui/tui-data.h: Rename include guard.
11693         * tui/tui-command.h: Rename include guard.
11694         * tic6x-tdep.h: Add include guard.
11695         * target/waitstatus.h: Rename include guard.
11696         * target/wait.h: Rename include guard.
11697         * target/target.h: Rename include guard.
11698         * target/resume.h: Rename include guard.
11699         * target-float.h: Rename include guard.
11700         * stabsread.h: Add include guard.
11701         * rs6000-tdep.h: Add include guard.
11702         * riscv-fbsd-tdep.h: Add include guard.
11703         * regformats/regdef.h: Rename include guard.
11704         * record.h: Rename include guard.
11705         * python/python.h: Rename include guard.
11706         * python/python-internal.h: Rename include guard.
11707         * python/py-stopevent.h: Rename include guard.
11708         * python/py-ref.h: Rename include guard.
11709         * python/py-record.h: Rename include guard.
11710         * python/py-record-full.h: Rename include guard.
11711         * python/py-record-btrace.h: Rename include guard.
11712         * python/py-instruction.h: Rename include guard.
11713         * python/py-events.h: Rename include guard.
11714         * python/py-event.h: Rename include guard.
11715         * procfs.h: Add include guard.
11716         * proc-utils.h: Add include guard.
11717         * p-lang.h: Add include guard.
11718         * or1k-tdep.h: Rename include guard.
11719         * observable.h: Rename include guard.
11720         * nto-tdep.h: Rename include guard.
11721         * nat/x86-linux.h: Rename include guard.
11722         * nat/x86-linux-dregs.h: Rename include guard.
11723         * nat/x86-gcc-cpuid.h: Add include guard.
11724         * nat/x86-dregs.h: Rename include guard.
11725         * nat/x86-cpuid.h: Rename include guard.
11726         * nat/ppc-linux.h: Rename include guard.
11727         * nat/mips-linux-watch.h: Rename include guard.
11728         * nat/linux-waitpid.h: Rename include guard.
11729         * nat/linux-ptrace.h: Rename include guard.
11730         * nat/linux-procfs.h: Rename include guard.
11731         * nat/linux-osdata.h: Rename include guard.
11732         * nat/linux-nat.h: Rename include guard.
11733         * nat/linux-namespaces.h: Rename include guard.
11734         * nat/linux-btrace.h: Rename include guard.
11735         * nat/glibc_thread_db.h: Rename include guard.
11736         * nat/gdb_thread_db.h: Rename include guard.
11737         * nat/gdb_ptrace.h: Rename include guard.
11738         * nat/fork-inferior.h: Rename include guard.
11739         * nat/amd64-linux-siginfo.h: Rename include guard.
11740         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11741         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11742         * nat/aarch64-linux.h: Rename include guard.
11743         * nat/aarch64-linux-hw-point.h: Rename include guard.
11744         * mn10300-tdep.h: Add include guard.
11745         * mips-linux-tdep.h: Add include guard.
11746         * mi/mi-parse.h: Rename include guard.
11747         * mi/mi-out.h: Rename include guard.
11748         * mi/mi-main.h: Rename include guard.
11749         * mi/mi-interp.h: Rename include guard.
11750         * mi/mi-getopt.h: Rename include guard.
11751         * mi/mi-console.h: Rename include guard.
11752         * mi/mi-common.h: Rename include guard.
11753         * mi/mi-cmds.h: Rename include guard.
11754         * mi/mi-cmd-break.h: Rename include guard.
11755         * m2-lang.h: Add include guard.
11756         * location.h: Rename include guard.
11757         * linux-record.h: Rename include guard.
11758         * linux-nat.h: Add include guard.
11759         * linux-fork.h: Add include guard.
11760         * i386-darwin-tdep.h: Rename include guard.
11761         * hppa-linux-offsets.h: Add include guard.
11762         * guile/guile.h: Rename include guard.
11763         * guile/guile-internal.h: Rename include guard.
11764         * gnu-nat.h: Rename include guard.
11765         * gdb-stabs.h: Rename include guard.
11766         * frv-tdep.h: Add include guard.
11767         * f-lang.h: Add include guard.
11768         * event-loop.h: Add include guard.
11769         * darwin-nat.h: Rename include guard.
11770         * cp-abi.h: Rename include guard.
11771         * config/sparc/nm-sol2.h: Rename include guard.
11772         * config/nm-nto.h: Rename include guard.
11773         * config/nm-linux.h: Add include guard.
11774         * config/i386/nm-i386gnu.h: Rename include guard.
11775         * config/djgpp/nl_types.h: Rename include guard.
11776         * config/djgpp/langinfo.h: Rename include guard.
11777         * compile/gcc-cp-plugin.h: Add include guard.
11778         * compile/gcc-c-plugin.h: Add include guard.
11779         * compile/compile.h: Rename include guard.
11780         * compile/compile-object-run.h: Rename include guard.
11781         * compile/compile-object-load.h: Rename include guard.
11782         * compile/compile-internal.h: Rename include guard.
11783         * compile/compile-cplus.h: Rename include guard.
11784         * compile/compile-c.h: Rename include guard.
11785         * common/xml-utils.h: Rename include guard.
11786         * common/x86-xstate.h: Rename include guard.
11787         * common/version.h: Rename include guard.
11788         * common/vec.h: Rename include guard.
11789         * common/tdesc.h: Rename include guard.
11790         * common/selftest.h: Rename include guard.
11791         * common/scoped_restore.h: Rename include guard.
11792         * common/scoped_mmap.h: Rename include guard.
11793         * common/scoped_fd.h: Rename include guard.
11794         * common/safe-iterator.h: Rename include guard.
11795         * common/run-time-clock.h: Rename include guard.
11796         * common/refcounted-object.h: Rename include guard.
11797         * common/queue.h: Rename include guard.
11798         * common/ptid.h: Rename include guard.
11799         * common/print-utils.h: Rename include guard.
11800         * common/preprocessor.h: Rename include guard.
11801         * common/pathstuff.h: Rename include guard.
11802         * common/observable.h: Rename include guard.
11803         * common/netstuff.h: Rename include guard.
11804         * common/job-control.h: Rename include guard.
11805         * common/host-defs.h: Rename include guard.
11806         * common/gdb_wait.h: Rename include guard.
11807         * common/gdb_vecs.h: Rename include guard.
11808         * common/gdb_unlinker.h: Rename include guard.
11809         * common/gdb_unique_ptr.h: Rename include guard.
11810         * common/gdb_tilde_expand.h: Rename include guard.
11811         * common/gdb_sys_time.h: Rename include guard.
11812         * common/gdb_string_view.h: Rename include guard.
11813         * common/gdb_splay_tree.h: Rename include guard.
11814         * common/gdb_setjmp.h: Rename include guard.
11815         * common/gdb_ref_ptr.h: Rename include guard.
11816         * common/gdb_optional.h: Rename include guard.
11817         * common/gdb_locale.h: Rename include guard.
11818         * common/gdb_assert.h: Rename include guard.
11819         * common/filtered-iterator.h: Rename include guard.
11820         * common/filestuff.h: Rename include guard.
11821         * common/fileio.h: Rename include guard.
11822         * common/environ.h: Rename include guard.
11823         * common/common-utils.h: Rename include guard.
11824         * common/common-types.h: Rename include guard.
11825         * common/common-regcache.h: Rename include guard.
11826         * common/common-inferior.h: Rename include guard.
11827         * common/common-gdbthread.h: Rename include guard.
11828         * common/common-exceptions.h: Rename include guard.
11829         * common/common-defs.h: Rename include guard.
11830         * common/common-debug.h: Rename include guard.
11831         * common/cleanups.h: Rename include guard.
11832         * common/buffer.h: Rename include guard.
11833         * common/btrace-common.h: Rename include guard.
11834         * common/break-common.h: Rename include guard.
11835         * cli/cli-utils.h: Rename include guard.
11836         * cli/cli-style.h: Rename include guard.
11837         * cli/cli-setshow.h: Rename include guard.
11838         * cli/cli-script.h: Rename include guard.
11839         * cli/cli-interp.h: Rename include guard.
11840         * cli/cli-decode.h: Rename include guard.
11841         * cli/cli-cmds.h: Rename include guard.
11842         * charset-list.h: Add include guard.
11843         * buildsym-legacy.h: Rename include guard.
11844         * bfin-tdep.h: Add include guard.
11845         * ax.h: Rename include guard.
11846         * arm-linux-tdep.h: Add include guard.
11847         * arm-fbsd-tdep.h: Add include guard.
11848         * arch/xtensa.h: Rename include guard.
11849         * arch/tic6x.h: Add include guard.
11850         * arch/i386.h: Add include guard.
11851         * arch/arm.h: Rename include guard.
11852         * arch/arm-linux.h: Rename include guard.
11853         * arch/arm-get-next-pcs.h: Rename include guard.
11854         * arch/amd64.h: Add include guard.
11855         * arch/aarch64-insn.h: Rename include guard.
11856         * arch-utils.h: Rename include guard.
11857         * annotate.h: Add include guard.
11858         * amd64-darwin-tdep.h: Rename include guard.
11859         * aarch64-linux-tdep.h: Add include guard.
11860         * aarch64-fbsd-tdep.h: Add include guard.
11861         * aarch32-linux-nat.h: Add include guard.
11862
11863 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11864
11865         * macrotab.c (macro_define_internal): New function that
11866         factorizes macro_define_object_internal and macro_define_function
11867         code.
11868         (macro_define_object_internal): Use macro_define_internal.
11869         (macro_define_function): Likewise.
11870
11871 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11872
11873         * macrocmd.c (extract_identifier): Return
11874         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11875         callers.
11876
11877 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11878
11879         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11880
11881 2019-02-05  Tom Tromey  <tom@tromey.com>
11882
11883         * target.c (target_stack::unpush): Move assertion earlier.
11884
11885 2019-01-30  Tom Tromey  <tom@tromey.com>
11886
11887         PR python/23615:
11888         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11889         (gdbpy_parse_and_eval): Likewise.
11890         * python/python-internal.h (gdbpy_allow_threads): New class.
11891
11892 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11893
11894         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11895         (aarch64_fbsd_fpregmap): Move earlier.
11896         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11897         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11898         instead of individual calls to trad_frame_set_reg_addr.
11899         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11900         earlier.
11901         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11902         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11903         instead of individual calls to trad_frame_set_reg_addr.
11904
11905 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11906
11907         * CONTRIBUTE: Replace contribution list with wiki link.
11908
11909 2019-01-25  Tom Tromey  <tom@tromey.com>
11910
11911         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11912
11913 2019-01-25  Tom Tromey  <tom@tromey.com>
11914
11915         * xtensa-linux-nat.c: Fix common/ includes.
11916         * xml-support.h: Fix common/ includes.
11917         * xml-support.c: Fix common/ includes.
11918         * x86-linux-nat.c: Fix common/ includes.
11919         * windows-nat.c: Fix common/ includes.
11920         * varobj.h: Fix common/ includes.
11921         * varobj.c: Fix common/ includes.
11922         * value.c: Fix common/ includes.
11923         * valops.c: Fix common/ includes.
11924         * utils.c: Fix common/ includes.
11925         * unittests/xml-utils-selftests.c: Fix common/ includes.
11926         * unittests/utils-selftests.c: Fix common/ includes.
11927         * unittests/unpack-selftests.c: Fix common/ includes.
11928         * unittests/tracepoint-selftests.c: Fix common/ includes.
11929         * unittests/style-selftests.c: Fix common/ includes.
11930         * unittests/string_view-selftests.c: Fix common/ includes.
11931         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11932         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11933         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11934         * unittests/rsp-low-selftests.c: Fix common/ includes.
11935         * unittests/parse-connection-spec-selftests.c: Fix common/
11936         includes.
11937         * unittests/optional-selftests.c: Fix common/ includes.
11938         * unittests/offset-type-selftests.c: Fix common/ includes.
11939         * unittests/observable-selftests.c: Fix common/ includes.
11940         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11941         * unittests/memrange-selftests.c: Fix common/ includes.
11942         * unittests/memory-map-selftests.c: Fix common/ includes.
11943         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11944         * unittests/function-view-selftests.c: Fix common/ includes.
11945         * unittests/environ-selftests.c: Fix common/ includes.
11946         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11947         * unittests/common-utils-selftests.c: Fix common/ includes.
11948         * unittests/cli-utils-selftests.c: Fix common/ includes.
11949         * unittests/array-view-selftests.c: Fix common/ includes.
11950         * ui-file.c: Fix common/ includes.
11951         * tui/tui-io.c: Fix common/ includes.
11952         * tracepoint.h: Fix common/ includes.
11953         * tracepoint.c: Fix common/ includes.
11954         * tracefile-tfile.c: Fix common/ includes.
11955         * top.h: Fix common/ includes.
11956         * top.c: Fix common/ includes.
11957         * thread.c: Fix common/ includes.
11958         * target/waitstatus.h: Fix common/ includes.
11959         * target/waitstatus.c: Fix common/ includes.
11960         * target.h: Fix common/ includes.
11961         * target.c: Fix common/ includes.
11962         * target-memory.c: Fix common/ includes.
11963         * target-descriptions.c: Fix common/ includes.
11964         * symtab.h: Fix common/ includes.
11965         * symfile.c: Fix common/ includes.
11966         * stap-probe.c: Fix common/ includes.
11967         * spu-linux-nat.c: Fix common/ includes.
11968         * sparc-nat.c: Fix common/ includes.
11969         * source.c: Fix common/ includes.
11970         * solib.c: Fix common/ includes.
11971         * solib-target.c: Fix common/ includes.
11972         * ser-unix.c: Fix common/ includes.
11973         * ser-tcp.c: Fix common/ includes.
11974         * ser-pipe.c: Fix common/ includes.
11975         * ser-base.c: Fix common/ includes.
11976         * selftest-arch.c: Fix common/ includes.
11977         * s12z-tdep.c: Fix common/ includes.
11978         * rust-exp.y: Fix common/ includes.
11979         * rs6000-aix-tdep.c: Fix common/ includes.
11980         * riscv-tdep.c: Fix common/ includes.
11981         * remote.c: Fix common/ includes.
11982         * remote-notif.h: Fix common/ includes.
11983         * remote-fileio.h: Fix common/ includes.
11984         * remote-fileio.c: Fix common/ includes.
11985         * regcache.h: Fix common/ includes.
11986         * regcache.c: Fix common/ includes.
11987         * record-btrace.c: Fix common/ includes.
11988         * python/python.c: Fix common/ includes.
11989         * python/py-type.c: Fix common/ includes.
11990         * python/py-inferior.c: Fix common/ includes.
11991         * progspace.h: Fix common/ includes.
11992         * producer.c: Fix common/ includes.
11993         * procfs.c: Fix common/ includes.
11994         * proc-api.c: Fix common/ includes.
11995         * printcmd.c: Fix common/ includes.
11996         * ppc-linux-nat.c: Fix common/ includes.
11997         * parser-defs.h: Fix common/ includes.
11998         * osdata.c: Fix common/ includes.
11999         * obsd-nat.c: Fix common/ includes.
12000         * nat/x86-linux.c: Fix common/ includes.
12001         * nat/x86-linux-dregs.c: Fix common/ includes.
12002         * nat/x86-dregs.h: Fix common/ includes.
12003         * nat/x86-dregs.c: Fix common/ includes.
12004         * nat/ppc-linux.c: Fix common/ includes.
12005         * nat/mips-linux-watch.h: Fix common/ includes.
12006         * nat/mips-linux-watch.c: Fix common/ includes.
12007         * nat/linux-waitpid.c: Fix common/ includes.
12008         * nat/linux-ptrace.h: Fix common/ includes.
12009         * nat/linux-ptrace.c: Fix common/ includes.
12010         * nat/linux-procfs.c: Fix common/ includes.
12011         * nat/linux-personality.c: Fix common/ includes.
12012         * nat/linux-osdata.c: Fix common/ includes.
12013         * nat/linux-namespaces.c: Fix common/ includes.
12014         * nat/linux-btrace.h: Fix common/ includes.
12015         * nat/linux-btrace.c: Fix common/ includes.
12016         * nat/fork-inferior.c: Fix common/ includes.
12017         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12018         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12019         * nat/aarch64-linux.c: Fix common/ includes.
12020         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12021         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12022         * namespace.h: Fix common/ includes.
12023         * mips-linux-tdep.c: Fix common/ includes.
12024         * minsyms.c: Fix common/ includes.
12025         * mi/mi-parse.h: Fix common/ includes.
12026         * mi/mi-main.c: Fix common/ includes.
12027         * mi/mi-cmd-env.c: Fix common/ includes.
12028         * memrange.h: Fix common/ includes.
12029         * memattr.c: Fix common/ includes.
12030         * maint.h: Fix common/ includes.
12031         * maint.c: Fix common/ includes.
12032         * main.c: Fix common/ includes.
12033         * machoread.c: Fix common/ includes.
12034         * location.c: Fix common/ includes.
12035         * linux-thread-db.c: Fix common/ includes.
12036         * linux-nat.c: Fix common/ includes.
12037         * linux-fork.c: Fix common/ includes.
12038         * inline-frame.c: Fix common/ includes.
12039         * infrun.c: Fix common/ includes.
12040         * inflow.c: Fix common/ includes.
12041         * inferior.h: Fix common/ includes.
12042         * inferior.c: Fix common/ includes.
12043         * infcmd.c: Fix common/ includes.
12044         * inf-ptrace.c: Fix common/ includes.
12045         * inf-child.c: Fix common/ includes.
12046         * ia64-linux-nat.c: Fix common/ includes.
12047         * i387-tdep.c: Fix common/ includes.
12048         * i386-tdep.c: Fix common/ includes.
12049         * i386-linux-tdep.c: Fix common/ includes.
12050         * i386-linux-nat.c: Fix common/ includes.
12051         * i386-go32-tdep.c: Fix common/ includes.
12052         * i386-fbsd-tdep.c: Fix common/ includes.
12053         * i386-fbsd-nat.c: Fix common/ includes.
12054         * guile/scm-type.c: Fix common/ includes.
12055         * guile/guile.c: Fix common/ includes.
12056         * go32-nat.c: Fix common/ includes.
12057         * gnu-nat.c: Fix common/ includes.
12058         * gdbthread.h: Fix common/ includes.
12059         * gdbarch-selftests.c: Fix common/ includes.
12060         * gdb_usleep.c: Fix common/ includes.
12061         * gdb_select.h: Fix common/ includes.
12062         * gdb_bfd.c: Fix common/ includes.
12063         * gcore.c: Fix common/ includes.
12064         * fork-child.c: Fix common/ includes.
12065         * findvar.c: Fix common/ includes.
12066         * fbsd-nat.c: Fix common/ includes.
12067         * event-top.c: Fix common/ includes.
12068         * event-loop.c: Fix common/ includes.
12069         * dwarf2read.c: Fix common/ includes.
12070         * dwarf2loc.c: Fix common/ includes.
12071         * dwarf2-frame.c: Fix common/ includes.
12072         * dwarf-index-cache.c: Fix common/ includes.
12073         * dtrace-probe.c: Fix common/ includes.
12074         * disasm-selftests.c: Fix common/ includes.
12075         * defs.h: Fix common/ includes.
12076         * csky-tdep.c: Fix common/ includes.
12077         * cp-valprint.c: Fix common/ includes.
12078         * cp-support.h: Fix common/ includes.
12079         * cp-support.c: Fix common/ includes.
12080         * corelow.c: Fix common/ includes.
12081         * completer.h: Fix common/ includes.
12082         * completer.c: Fix common/ includes.
12083         * compile/compile.c: Fix common/ includes.
12084         * compile/compile-loc2c.c: Fix common/ includes.
12085         * compile/compile-cplus-types.c: Fix common/ includes.
12086         * compile/compile-cplus-symbols.c: Fix common/ includes.
12087         * command.h: Fix common/ includes.
12088         * cli/cli-dump.c: Fix common/ includes.
12089         * cli/cli-cmds.c: Fix common/ includes.
12090         * charset.c: Fix common/ includes.
12091         * build-id.c: Fix common/ includes.
12092         * btrace.h: Fix common/ includes.
12093         * btrace.c: Fix common/ includes.
12094         * breakpoint.h: Fix common/ includes.
12095         * breakpoint.c: Fix common/ includes.
12096         * ax.h:
12097         (enum agent_op): Fix common/ includes.
12098         * ax-general.c (struct aop_map): Fix common/ includes.
12099         * ax-gdb.c: Fix common/ includes.
12100         * auxv.c: Fix common/ includes.
12101         * auto-load.c: Fix common/ includes.
12102         * arm-tdep.c: Fix common/ includes.
12103         * arch/riscv.c: Fix common/ includes.
12104         * arch/ppc-linux-common.c: Fix common/ includes.
12105         * arch/i386.c: Fix common/ includes.
12106         * arch/arm.c: Fix common/ includes.
12107         * arch/arm-linux.c: Fix common/ includes.
12108         * arch/arm-get-next-pcs.c: Fix common/ includes.
12109         * arch/amd64.c: Fix common/ includes.
12110         * arch/aarch64.c: Fix common/ includes.
12111         * arch/aarch64-insn.c: Fix common/ includes.
12112         * arch-utils.c: Fix common/ includes.
12113         * amd64-windows-tdep.c: Fix common/ includes.
12114         * amd64-tdep.c: Fix common/ includes.
12115         * amd64-sol2-tdep.c: Fix common/ includes.
12116         * amd64-obsd-tdep.c: Fix common/ includes.
12117         * amd64-nbsd-tdep.c: Fix common/ includes.
12118         * amd64-linux-tdep.c: Fix common/ includes.
12119         * amd64-linux-nat.c: Fix common/ includes.
12120         * amd64-fbsd-tdep.c: Fix common/ includes.
12121         * amd64-fbsd-nat.c: Fix common/ includes.
12122         * amd64-dicos-tdep.c: Fix common/ includes.
12123         * amd64-darwin-tdep.c: Fix common/ includes.
12124         * agent.c: Fix common/ includes.
12125         * ada-lang.h: Fix common/ includes.
12126         * ada-lang.c: Fix common/ includes.
12127         * aarch64-tdep.c: Fix common/ includes.
12128
12129 2019-01-25  Tom Tromey  <tom@tromey.com>
12130
12131         * common/create-version.sh: Use common/version.h.
12132
12133 2019-01-24  Pedro Alves  <palves@redhat.com>
12134
12135         * infrun.c (signal_stop, signal_print, signal_program)
12136         (signal_catch, signal_pass): Now arrays instead of pointers.
12137         (update_signals_program_target, do_target_resume)
12138         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12139         * linux-nat.c (linux_nat_target::pass_signals)
12140         (linux_nat_target::create_inferior, linux_nat_target::attach):
12141         Adjust.
12142         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12143         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12144         * procfs.c (procfs_target::pass_signals): Adjust.
12145         * record-full.c (record_full_target::resume): Adjust.
12146         * remote.c (remote_target::pass_signals)
12147         (remote_target::program_signals): Adjust.
12148         * target-debug.h (target_debug_print_signals): Now takes a
12149         gdb::array_view as parameter.  Adjust.
12150         * target.h (target_ops) <pass_signals, program_signals>: Replace
12151         pointer and length parameters with gdb::array_view.
12152         (target_pass_signals, target_program_signals): Likewise.
12153         * target-delegates.c: Regenerate.
12154
12155 2019-01-24  Pedro Alves  <palves@redhat.com>
12156
12157         * common/forward-scope-exit.h
12158         (forward_scope_exit::forward_scope_exit): Pass arguments to
12159         m_bind_function directly, instead of creating a std::bind and
12160         copying that.
12161
12162 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12163
12164         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12165         for static members.
12166         (pass_in_v_vfp_candidate): Likewise.
12167
12168 2019-01-23  Tom Tromey  <tom@tromey.com>
12169             Pedro Alves  <palves@redhat.com>
12170
12171         * regcache.c (class regcache_invalidator): Remove.
12172         (regcache::raw_write): Use make_scope_exit.
12173
12174 2019-01-23  Tom Tromey  <tom@tromey.com>
12175
12176         * ui-out.h (class ui_out_emit_type): Update comment.
12177
12178 2019-01-23  Tom Tromey  <tom@tromey.com>
12179
12180         * infrun.c (fetch_inferior_event): Update comment.
12181
12182 2019-01-23  Tom Tromey  <tom@tromey.com>
12183             Pedro Alves  <palves@redhat.com>
12184
12185         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12186         parameter.
12187         (fetch_inferior_event): Use SCOPE_EXIT.
12188
12189
12190 2019-01-23  Tom Tromey  <tom@tromey.com>
12191             Pedro Alves  <palves@redhat.com>
12192
12193         * infrun.c (disable_thread_events): Delete.
12194         (stop_all_threads): Use SCOPE_EXIT.
12195
12196 2019-01-23  Tom Tromey  <tom@tromey.com>
12197             Pedro Alves  <palves@redhat.com>
12198
12199         * symfile.c: Include forward-scope-exit.h.
12200         (clear_symtab_users_cleanup): Replace forward declaration with
12201         a FORWARD_SCOPE_EXIT.
12202         (syms_from_objfile_1): Use the forward_scope_exit and
12203         gdb::optional instead of cleanup_function.
12204         (reread_symbols): Use the forward_scope_exit instead of
12205         cleanup_function.
12206         (clear_symtab_users_cleanup): Remove function.
12207
12208 2019-01-23  Tom Tromey  <tom@tromey.com>
12209             Pedro Alves  <palves@redhat.com>
12210
12211         * linux-nat.c: Include scope-exit.h.
12212         (cleanup_target_stop): Remove.
12213         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12214         SCOPE_EXIT.
12215
12216 2019-01-23  Tom Tromey  <tom@tromey.com>
12217             Pedro Alves  <palves@redhat.com>
12218
12219         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12220         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12221
12222 2019-01-23  Tom Tromey  <tom@tromey.com>
12223             Andrew Burgess  <andrew.burgess@embecosm.com>
12224             Pedro Alves  <palves@redhat.com>
12225
12226         * infrun.c (fetch_inferior_event): Use scope_exit.
12227         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12228         * top.c (execute_command): Use scope_exit.
12229         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12230         * utils.c (do_bpstat_clear_actions_cleanup)
12231         (make_bpstat_clear_actions_cleanup): Remove.
12232
12233 2019-01-23  Tom Tromey  <tom@tromey.com>
12234             Pedro Alves  <palves@redhat.com>
12235
12236         * infrun.c: Include "common/scope-exit.h"
12237         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12238         (wait_for_inferior): Use SCOPE_EXIT.
12239         (fetch_inferior_event): Use scope_exit.
12240
12241 2019-01-23  Tom Tromey  <tom@tromey.com>
12242             Pedro Alves  <palves@redhat.com>
12243
12244         * breakpoint.c (create_breakpoint): Remove cleanup.
12245
12246 2019-01-23  Tom Tromey  <tom@tromey.com>
12247             Andrew Burgess  <andrew.burgess@embecosm.com>
12248             Pedro Alves  <palves@redhat.com>
12249
12250 2019-01-23  Pedro Alves  <palves@redhat.com>
12251
12252         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12253
12254 2019-01-23  Pedro Alves  <palves@redhat.com>
12255             Andrew Burgess  <andrew.burgess@embecosm.com>
12256
12257         * gdbthread.h: Include "common/forward-scope-exit.h".
12258         (scoped_finish_thread_state): Redefine custom class in terms of
12259         forward_scope_exit.
12260
12261 2019-01-23  Pedro Alves  <palves@redhat.com>
12262             Andrew Burgess  <andrew.burgess@embecosm.com>
12263
12264         * common/forward-scope-exit.h: New file.
12265
12266 2019-01-23  Pedro Alves  <palves@redhat.com>
12267             Andrew Burgess  <andrew.burgess@embecosm.com>
12268             Tom Tromey  <tom@tromey.com>
12269
12270         * common/scope-exit.h: New file.
12271
12272 2019-01-23  Pedro Alves  <palves@redhat.com>
12273
12274         * common/preprocessor.h (ESC): Rename to ...
12275         (ESC_PARENS): ... this.
12276         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12277         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12278
12279 2019-01-23  Tom Tromey  <tom@tromey.com>
12280
12281         * language.h (class scoped_switch_to_sym_language_if_auto):
12282         Initialize m_lang in both cases.
12283
12284 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12285
12286         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12287         with XCNEW.
12288
12289 2019-01-22  Tom Tromey  <tom@tromey.com>
12290
12291         * corelow.c: Do not include sys/file.h.
12292
12293 2019-01-22  Tom Tromey  <tom@tromey.com>
12294
12295         * tui/tui-wingeneral.h: Include gdb_curses.h.
12296
12297 2019-01-22  Tom Tromey  <tom@tromey.com>
12298
12299         * source-cache.h (class source_cache) <get_source_lines,
12300         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12301
12302 2019-01-22  Tom Tromey  <tom@tromey.com>
12303
12304         * remote-fileio.h (struct remote_target): Declare.
12305
12306 2019-01-22  Tom Tromey  <tom@tromey.com>
12307
12308         * python/py-arch.c: Do not include py-ref.h.
12309         * python/py-bpevent.c: Do not include py-ref.h.
12310         * python/py-cmd.c: Do not include py-ref.h.
12311         * python/py-continueevent.c: Do not include py-ref.h.
12312         * python/py-event.h: Do not include py-ref.h.
12313         * python/py-evtregistry.c: Do not include py-ref.h.
12314         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12315         * python/py-frame.c: Do not include py-ref.h.
12316         * python/py-framefilter.c: Do not include py-ref.h.
12317         * python/py-function.c: Do not include py-ref.h.
12318         * python/py-infevents.c: Do not include py-ref.h.
12319         * python/py-linetable.c: Do not include py-ref.h.
12320         * python/py-objfile.c: Do not include py-ref.h.
12321         * python/py-param.c: Do not include py-ref.h.
12322         * python/py-prettyprint.c: Do not include py-ref.h.
12323         * python/py-progspace.c: Do not include py-ref.h.
12324         * python/py-symbol.c: Do not include py-ref.h.
12325         * python/py-symtab.c: Do not include py-ref.h.
12326         * python/py-type.c: Do not include py-ref.h.
12327         * python/py-unwind.c: Do not include py-ref.h.
12328         * python/py-utils.c: Do not include py-ref.h.
12329         * python/py-value.c: Do not include py-ref.h.
12330         * python/py-varobj.c: Do not include py-ref.h.
12331         * python/py-xmethods.c: Do not include py-ref.h.
12332         * python/python.c: Do not include py-ref.h.
12333         * varobj.c: Do not include py-ref.h.
12334
12335 2019-01-22  Tom Tromey  <tom@tromey.com>
12336
12337         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12338         keyword for bcache.
12339
12340 2019-01-22  Tom Tromey  <tom@tromey.com>
12341
12342         * compile/compile-cplus-types.c: Remove a comment by #include.
12343
12344 2019-01-22  Tom Tromey  <tom@tromey.com>
12345
12346         * compile/gcc-c-plugin.h: Include compile-internal.h.
12347
12348 2019-01-22  Tom Tromey  <tom@tromey.com>
12349
12350         * stabsread.c (EXTERN): Do not define.
12351         (symnum, next_symbol_text_func, processing_gcc_compilation)
12352         (within_function, global_sym_chain, global_stabs)
12353         (previous_stab_code, this_object_header_files)
12354         (n_this_object_header_files)
12355         (n_allocated_this_object_header_files): Define.
12356         * stabsread.h (EXTERN): Never define.  Use "extern".
12357
12358 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12359
12360         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12361         history_value.
12362
12363 2019-01-21  Tom Tromey  <tom@tromey.com>
12364
12365         * ui-out.c: Fix includes.
12366         * tui/tui-source.c: Fix includes.
12367         * target.c: Fix includes.
12368         * remote.c: Fix includes.
12369         * regcache.c: Fix includes.
12370         * python/py-block.c: Fix includes.
12371         * printcmd.c: Fix includes.
12372         * or1k-tdep.c: Fix includes.
12373         * mi/mi-main.c: Fix includes.
12374         * m32r-tdep.c: Fix includes.
12375         * csky-tdep.c: Fix includes.
12376         * compile/compile-cplus-types.c: Fix includes.
12377         * cli/cli-interp.c: Fix includes.
12378
12379 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12380
12381         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12382         for padding.
12383
12384 2019-01-16  Tom Tromey  <tom@tromey.com>
12385
12386         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12387         earlier.
12388         (struct objfile) <msymbols_range>: Move from top level.
12389         <msymbols>: New method.
12390         (class objfile_msymbols): Remove.
12391         * symtab.c (default_collect_symbol_completion_matches_break_on):
12392         Update.
12393         * symmisc.c (dump_msymbols): Update.
12394         * stabsread.c (scan_file_globals): Update.
12395         * objc-lang.c (info_selectors_command, info_classes_command)
12396         (find_methods): Update.
12397         * minsyms.c (find_solib_trampoline_target): Update.
12398         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12399         * coffread.c (coff_symfile_read): Update.
12400         * ada-lang.c (ada_lookup_simple_minsym)
12401         (ada_collect_symbol_completion_matches): Update.
12402
12403 2019-01-16  Tom Tromey  <tom@tromey.com>
12404
12405         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12406         type.  Remove no-argument constructor.
12407         <iterator::operator++>: Simplify.
12408         <begin>: Update.
12409         <end>: Use minimal_symbol_count.
12410
12411 2019-01-16  Tom Tromey  <tom@tromey.com>
12412
12413         * objfiles.h (struct objfile) <psymtabs>: New method.
12414         (class objfile_psymtabs): Remove.
12415         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12416         typedef.
12417         <range>: New method.
12418         (require_partial_symbols): Change return type.
12419         * psymtab.c (require_partial_symbols)
12420         (psym_expand_symtabs_matching): Update.
12421         * mdebugread.c (parse_partial_symbols): Update.
12422         * dbxread.c (dbx_end_psymtab): Update.
12423
12424 2019-01-15  Tom Tromey  <tom@tromey.com>
12425
12426         * symtab.c (lookup_objfile_from_block)
12427         (lookup_symbol_in_objfile_symtabs)
12428         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12429         (find_line_symtab, info_sources_command)
12430         (default_collect_symbol_completion_matches_break_on)
12431         (make_source_files_completion_list): Update.
12432         * symmisc.c (print_objfile_statistics, dump_objfile)
12433         (maintenance_print_symbols, maintenance_info_symtabs)
12434         (maintenance_check_symtabs, maintenance_info_line_tables):
12435         Update.
12436         * source.c (select_source_symtab)
12437         (forget_cached_source_info_for_objfile): Update.
12438         * objfiles.h (class objfile_compunits): Remove.
12439         (struct objfile) <compunits_range>: New typedef.
12440         (compunits): New method.
12441         * objfiles.c (objfile_relocate1): Update.
12442         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12443         * maint.c (count_symtabs_and_blocks): Update.
12444         * linespec.c (iterate_over_all_matching_symtabs): Update.
12445         * cp-support.c (add_symbol_overload_list_qualified): Update.
12446         * coffread.c (coff_symtab_read): Update.
12447         * ada-lang.c (add_nonlocal_symbols)
12448         (ada_collect_symbol_completion_matches)
12449         (ada_add_global_exceptions): Update.
12450
12451 2019-01-15  Tom Tromey  <tom@tromey.com>
12452
12453         * progspace.h (program_space) <objfiles_safe_range>: New
12454         typedef.
12455         <objfiles_safe>: New method.
12456         * objfiles.h (class all_objfiles_safe): Remove.
12457         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12458         * jit.c (jit_inferior_exit_hook): Update.
12459
12460 2019-01-17  Tom Tromey  <tom@tromey.com>
12461
12462         * progspace.h (program_space) <objfiles_range>: New typedef.
12463         <objfiles>: New method.
12464         <objfiles_head>: Rename from objfiles.
12465         (object_files): Update.
12466         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12467         * guile/scm-pretty-print.c
12468         (ppscm_find_pretty_printer_from_objfiles): Update.
12469         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12470         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12471         Update.
12472         * python/py-progspace.c (pspy_get_objfiles): Update.
12473         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12474         Update.
12475         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12476         (objfpy_lookup_objfile_by_build_id): Update.
12477         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12478         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12479         Update.
12480         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12481         (expand_symtab_containing_pc, lookup_objfile_from_block)
12482         (lookup_static_symbol, basic_lookup_transparent_type)
12483         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12484         (find_line_symtab, info_sources_command)
12485         (default_collect_symbol_completion_matches_break_on)
12486         (make_source_files_completion_list, find_main_name): Update.
12487         * symmisc.c (print_symbol_bcache_statistics)
12488         (print_objfile_statistics, maintenance_print_symbols)
12489         (maintenance_print_msymbols, maintenance_print_objfiles)
12490         (maintenance_info_symtabs, maintenance_check_symtabs)
12491         (maintenance_expand_symtabs, maintenance_info_line_tables):
12492         Update.
12493         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12494         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12495         (map_overlay_command, unmap_overlay_command)
12496         (simple_overlay_update, expand_symtabs_matching)
12497         (map_symbol_filenames): Update.
12498         * symfile-debug.c (set_debug_symfile): Update.
12499         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12500         Update.
12501         * source.c (select_source_symtab, forget_cached_source_info):
12502         Update.
12503         * solib.c (solib_read_symbols): Update.
12504         * solib-spu.c (append_ocl_sos): Update.
12505         * psymtab.c (maintenance_print_psymbols)
12506         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12507         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12508         * printcmd.c (info_symbol_command): Update.
12509         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12510         Update.
12511         * objfiles.h (class all_objfiles): Remove.
12512         * objfiles.c (have_partial_symbols, have_full_symbols)
12513         (have_minimal_symbols, qsort_cmp, update_section_map)
12514         (shared_objfile_contains_address_p)
12515         (default_iterate_over_objfiles_in_search_order): Update.
12516         * objc-lang.c (info_selectors_command, info_classes_command)
12517         (find_methods): Update.
12518         * minsyms.c (find_solib_trampoline_target): Update.
12519         * maint.c (maintenance_info_sections)
12520         (maintenance_translate_address, count_symtabs_and_blocks):
12521         Update.
12522         * main.c (captured_main_1): Update.
12523         * linux-thread-db.c (try_thread_db_load_from_pdir)
12524         (has_libpthread): Update.
12525         * linespec.c (iterate_over_all_matching_symtabs)
12526         (search_minsyms_for_name): Update.
12527         * jit.c (jit_find_objf_with_entry_addr): Update.
12528         * hppa-tdep.c (find_unwind_entry)
12529         (hppa_lookup_stub_minimal_symbol): Update.
12530         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12531         Update.
12532         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12533         (elf_gnu_ifunc_resolve_by_got): Update.
12534         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12535         * dwarf-index-write.c (save_gdb_index_command): Update.
12536         * cp-support.c (add_symbol_overload_list_qualified): Update.
12537         * breakpoint.c (create_overlay_event_breakpoint)
12538         (create_longjmp_master_breakpoint)
12539         (create_std_terminate_master_breakpoint)
12540         (create_exception_master_breakpoint): Update.
12541         * blockframe.c (find_pc_partial_function): Update.
12542         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12543         (ada_collect_symbol_completion_matches)
12544         (ada_add_global_exceptions): Update.
12545
12546 2019-01-17  Tom Tromey  <tom@tromey.com>
12547
12548         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12549         declare VEC.
12550         (solib_target_parse_libraries): Change return type.
12551         (library_list_start_segment, library_list_start_section)
12552         (library_list_end_library, library_list_start_library); Update.
12553         (solib_target_free_library_list): Remove.
12554         (solib_target_parse_libraries): Remove cleanup.  Change return
12555         type.
12556         (solib_target_current_sos): Update.
12557
12558 2019-01-17  Tom Tromey  <tromey@bapiya>
12559
12560         * valprint.c: Replace "the the" with "the".
12561         * symtab.c: Replace "the the" with "the".
12562         * solib.c: Replace "the the" with "the".
12563         * solib-dsbt.c: Replace "the the" with "the".
12564         * linespec.c: Replace "the the" with "the".
12565         * dwarf2loc.h: Replace "the the" with "the".
12566         * amd64-windows-tdep.c: Replace "the the" with "the".
12567         * aarch64-tdep.c: Replace "the the" with "the".
12568
12569 2019-01-16  Keith Seitz  <keiths@redhat.com>
12570
12571         PR gdb/23773
12572         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12573         <builder>: Rename to ..
12574         <m_builder>: ... this and make private.
12575         (dwarf2_cu::get_builder): New method.  Change all users of
12576         `builder' to use this method.
12577         (dwarf2_start_symtab): Move to ...
12578         (dwarf2_cu::start_symtab): ... here.  Update all callers
12579         (setup_type_unit_groups): Move to ...
12580         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12581         callers.
12582         (dwarf2_cu::reset_builder): New method.
12583         (process_full_compunit, process_full_type_unit): Use
12584         dwarf2_cu::reset_builder.
12585         (follow_die_offset): Record the ancestor CU if it is different
12586         from the followed DIE's CU.
12587         (follow_die_sig_1): Likewise.
12588
12589 2019-01-15  Tom Tromey  <tom@tromey.com>
12590
12591         * remote.c (class remote_state) <buf>: Now a char_vector.
12592         <buf_size>: Remove.
12593         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12594         parameter.
12595         (remote_target::getpkt_or_notif_sane_1)
12596         (remote_target::getpkt_sane)
12597         (remote_target::getpkt_or_notif_sane): Likewise.
12598         (class remote_target) <putpkt>: New overload.
12599         (remote_target::read_frame): Change type of "buf_p".  Remove
12600         sizeof_p parameter.
12601         (packet_ok): New overload.
12602         (packet_check_result): New overload.
12603         Update all uses.
12604
12605 2019-01-14  Tom Tromey  <tom@tromey.com>
12606
12607         * remote-notif.c (handle_notification, remote_notif_ack)
12608         (remote_notif_parse): Make "buf" const.
12609         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12610         const.
12611         (remote_notif_parse, remote_notif_ack, handle_notification):
12612         Likewise.
12613         * remote.c (remote_notif_stop_parse): Make "buf" const.
12614         (remote_target::remote_parse_stop_reply): Make "buf" const.
12615         (remote_notif_stop_ack): Make "buf" const.
12616
12617 2019-01-14  Tom Tromey  <tom@tromey.com>
12618
12619         * remote.c (remote_console_output): Make parameter const.
12620
12621 2019-01-14  Tom Tromey  <tom@tromey.com>
12622
12623         * target-debug.h (target_debug_print_signals): Constify.
12624         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12625         * procfs.c (procfs_target::pass_signals): Update.
12626         * linux-nat.c (linux_nat_target::pass_signals): Update.
12627         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12628         * target-delegates.c: Rebuild.
12629         * remote.c (remote_target::program_signals): Update.
12630         (remote_target::pass_signals): Update.
12631         * target.c (target_pass_signals): Constify argument.
12632         (target_program_signals): Likewise.
12633         * target.h (struct target_ops) <pass_signals, program_signals>:
12634         Constify argument.
12635         (target_pass_signals, target_program_signals): Constify argument.
12636
12637 2019-01-14  Tom Tromey  <tom@tromey.com>
12638
12639         PR tui/28819:
12640         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12641
12642 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12643
12644         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12645         field.
12646         * rs6000-tdep.c: Include reggroups.h.
12647         (IS_V_ALIAS_PSEUDOREG): Define.
12648         (rs6000_register_name): Return names for the "vX" aliases.
12649         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12650         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12651         aliases.  Call default_register_reggroup_p for all other
12652         pseudo-registers.
12653         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12654         New functions.
12655         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12656         Handle "vX" aliases.
12657         (v_alias_pseudo_register_collect): New function.
12658         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12659         (rs6000_gdbarch_init): Initialize "vX" aliases as
12660         pseudo-registers.  Restore registration of
12661         rs6000_pseudo_register_reggroup_p with
12662         set_tdesc_pseudo_register_reggroup_p.
12663
12664 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12665
12666         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12667         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12668         set_gdbarch_num_pseudo_regs.
12669
12670 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12671
12672         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12673         Remove arg prefixname, add do_set and do_show.
12674         Add member functions set_list and show_list.
12675         * cli/cli-style.c (class cli_style_option): Update accordingly.
12676         (style_set_list): Move to file scope.
12677         (style_show_list): Likewise.
12678         (set_style): Call help_list.
12679         (show_style): Call cmd_show_list.
12680         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12681         Update to use the new macro.
12682
12683 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12684
12685         * ada-lang.c (_initialize_ada_language): Expand the help text
12686         for the "catch exception" command.
12687
12688 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12689
12690         * symtab.c (matching_obj_sections): Initialize obj,
12691         declare it closer to its usage.
12692
12693 2019-01-10  Tom Tromey  <tom@tromey.com>
12694
12695         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12696         (basic_inf_threads_range): Remove.
12697         (inf_threads_range, inf_non_exited_threads_range)
12698         (safe_inf_threads_range): Use next_adapter.
12699
12700 2019-01-10  Keith Seitz  <keiths@redhat.com>
12701
12702         PR gdb/23712
12703         PR symtab/23010
12704         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12705         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12706
12707 2019-01-10  Keith Seitz  <keiths@redhat.com>
12708
12709         PR gdb/23712
12710         PR symtab/23010
12711         * dictionary.c (pending_to_vector): Remove.
12712         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12713         Remove _1 suffix, replacing functions of the same name.  Update
12714         all callers.
12715         (dict_create_hashed, dict_create_hashed_expandable)
12716         (dict_create_linear, dict_create_linear_expandable, dict_free)
12717         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12718         Make functions static.
12719
12720 2019-01-10  Keith Seitz  <keiths@redhat.com>
12721
12722         PR gdb/23712
12723         PR symtab/23010
12724         * dictionary.h (struct dictionary): Replace declaration with
12725         multidictionary.
12726         (dict_create_hashed, dict_create_hashed_expandable)
12727         (dict_create_linear, dict_create_linear_expandable)
12728         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12729         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12730         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12731         taking multidictionary argument.
12732         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12733         * block.h (struct block) <dict>: Change to multidictionary
12734         and rename `multidict'.
12735         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12736         symmisc.c: Update all dictionary references to multidictionary.
12737
12738 2019-01-10  Keith Seitz  <keiths@redhat.com>
12739
12740         PR gdb/23712
12741         PR symtab/23010
12742         * dictionary.c: Include unordered_map.
12743         (pending_to_vector): New function.
12744         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12745         Rewrite the non-"_1" functions to take vector instead
12746         of linked list.
12747         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12748         "new" _1 versions of the same name.
12749         (multidictionary): Define.
12750         (std::hash<enum language): New definition.
12751         (collate_pending_symbols_by_language, mdict_create_hashed)
12752         (mdict_create_hashed_expandable, mdict_create_linear)
12753         (mdict_create_linear_expandable, mdict_free)
12754         (find_language_dictionary, create_new_language_dictionary)
12755         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12756         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12757         (mdict_size, mdict_empty): New functions.
12758         * dictionary.h (mdict_iterator): Define.
12759
12760 2019-01-10  Pedro Alves  <palves@redhat.com>
12761
12762         * breakpoint.c (read_uploaded_action)
12763         (create_tracepoint_from_upload): Adjust to use
12764         gdb::unique_xmalloc_ptr.
12765         * ctf.c (ctf_write_uploaded_tp):
12766         (SET_ARRAY_FIELD): Use emplace_back.
12767         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12768         * tracefile-tfile.c (tfile_write_uploaded_tp):
12769         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12770         gdb::unique_xmalloc_ptr.
12771         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12772         at_string, cond_string, cmd_strings>: Replace char pointers
12773         with gdb::unique_xmalloc_ptr.
12774
12775 2019-01-10  Pedro Alves  <palves@redhat.com>
12776
12777         * solib-target.c (library_list_start_library): Don't xstrdup name.
12778
12779 2019-01-10  Pedro Alves  <palves@redhat.com>
12780
12781         * mdebugread.c (parse_partial_symbols): Use
12782         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12783
12784 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12785
12786         * linux-fork.c (scoped_switch_fork_info)
12787         <~scoped_switch_fork_info>: Fix incorrect variable name.
12788
12789 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12790
12791         * linux-fork.c (scoped_switch_fork_info)
12792         <scoped_switch_fork_info>: Make explicit.
12793         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12794
12795 2019-01-10  Tom Tromey  <tom@tromey.com>
12796
12797         * objfiles.h (objfile::reset_psymtabs): Update.
12798         * objfiles.c (objfile::objfile): Update.
12799         * psymtab.h (psymtab_storage::obstack): Update.
12800         (psymtab_storage::m_obstack): Use gdb::optional.
12801         (class psymtab_storage): Update comment.  Remove objfile
12802         parameter.
12803         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12804
12805 2019-01-10  Tom Tromey  <tom@tromey.com>
12806
12807         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12808         <free_psymtabs>: Now private.
12809         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12810         (allocate_psymtab): Use new method.
12811
12812 2019-01-10  Tom Tromey  <tom@tromey.com>
12813
12814         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12815         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12816         * mdebugread.c (parse_partial_symbols): Use
12817         allocate_dependencies.
12818         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12819         allocate_dependencies.
12820         (process_psymtab_comp_unit_reader)
12821         (build_type_psymtab_dependencies): Likewise.
12822         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12823
12824 2019-01-10  Tom Tromey  <tom@tromey.com>
12825
12826         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12827         PSYMBOL_SET_LANGUAGE.
12828         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12829
12830 2019-01-10  Tom Tromey  <tom@tromey.com>
12831
12832         * psymtab.h (psymtab_storage::obstack): New method.
12833         <m_obstack>: Rename from obstack; now private.
12834         * psymtab.c (psymtab_storage): Update.
12835         * dwarf2read.c (create_addrmap_from_index)
12836         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12837         Update.
12838
12839 2019-01-10  Tom Tromey  <tom@tromey.com>
12840
12841         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12842         * objfiles.h (objfile::reset_psymtabs): New method.
12843
12844 2019-01-10  Tom Tromey  <tom@tromey.com>
12845
12846         * symmisc.c (print_symbol_bcache_statistics): Update.
12847         (print_objfile_statistics): Update.
12848         * symfile.c (reread_symbols): Update.
12849         * psymtab.h (class psymtab_storage): New.
12850         * psymtab.c (psymtab_storage): New constructor.
12851         (~psymtab_storage): New destructor.
12852         (require_partial_symbols): Update.
12853         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12854         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12855         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12856         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12857         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12858         (start_psymtab_common, end_psymtab_common)
12859         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12860         (allocate_psymtab): Update.
12861         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12862         Update.
12863         (dump_psymtab_addrmap, maintenance_print_psymbols)
12864         (maintenance_check_psymtabs): Update.
12865         (class objfile_psymtabs): Move to objfiles.h.
12866         * psympriv.h (discard_psymtab): Now inline.
12867         (psymtab_discarder::psymtab_discarder): Update.
12868         (psymtab_discarder::~psymtab_discarder): Update.
12869         (ALL_OBJFILE_PSYMTABS): Rewrite.
12870         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12871         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12872         Remove fields.
12873         <partial_symtabs>: New field.
12874         (class objfile_psymtabs): Move from psymtab.h.  Update.
12875         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12876         psymbol_cache.
12877         (objfile::~objfile): Don't destroy psymbol_cache.
12878         * mdebugread.c (parse_partial_symbols): Update.
12879         * dwarf2read.c (create_addrmap_from_index)
12880         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12881         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12882         (add_partial_subprogram, dwarf2_ranges_read): Update.
12883         * dwarf-index-write.c (write_address_map)
12884         (write_one_signatured_type, recursively_write_psymbols)
12885         (class debug_names, class debug_names, write_psymtabs_to_index):
12886         Update.
12887
12888 2019-01-10  Tom Tromey  <tom@tromey.com>
12889
12890         * symtab.h (SYMBOL_SET_NAMES): Update.
12891         (symbol_set_names): Update.
12892         (MSYMBOL_SET_NAMES): Update.
12893         * symtab.c (symbol_set_names): Change argument to be an
12894         objfile_per_bfd_storage.
12895         * psymtab.c (add_psymbol_to_bcache): Update.
12896         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12897
12898 2019-01-10  Tom Tromey  <tom@tromey.com>
12899
12900         * symtab.c (create_demangled_names_hash): Change argument to be an
12901         objfile_per_bfd_storage.
12902         (symbol_set_names): Update.
12903
12904 2019-01-10  Tom Tromey  <tom@tromey.com>
12905
12906         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12907         init_psymbol_list.
12908         * psymtab.c (init_psymbol_list): Do nothing if already called.
12909         * psympriv.h (init_psymbol_list): Add comment.
12910         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12911         init_psymbol_list.
12912         * dbxread.c (dbx_symfile_read): Unconditionally call
12913         init_psymbol_list.
12914
12915 2019-01-10  Tom Tromey  <tom@tromey.com>
12916
12917         * xcoffread.c (scan_xcoff_symtab): Update.
12918         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12919         "where".
12920         * mdebugread.c (parse_partial_symbols)
12921         (handle_psymbol_enumerators): Update.
12922         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12923         * dbxread.c (read_dbx_symtab): Update.
12924         * psympriv.h (psymbol_placement): New enum.
12925         (add_psymbol_to_list): Update.
12926
12927 2019-01-10  Tom Tromey  <tom@tromey.com>
12928
12929         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12930         static_psymbols parameters.
12931         (scan_xcoff_symtab): Update.
12932         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12933         static_psymbols parameters.
12934         * psympriv.h (start_psymtab_common): Update.
12935         * mdebugread.c (parse_partial_symbols): Update.
12936         * dwarf2read.c (create_partial_symtab): Update.
12937         * dbxread.c (read_dbx_symtab): Update.
12938         (start_psymtab): Remove global_psymbols and static_psymbols
12939         parameters.
12940
12941 2019-01-10  Tom Tromey  <tom@tromey.com>
12942
12943         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12944         * psymtab.c (allocate_psymtab): Add comment.
12945         * psympriv.h (allocate_psymtab): Add comment.
12946         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12947         initializations.
12948         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12949
12950 2019-01-10  Tom Tromey  <tom@tromey.com>
12951
12952         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12953         Don't declare.
12954         * mipsread.c: Include mdebugread.h.
12955         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12956         Declare.
12957         * elfread.c: Include mdebugread.h.
12958
12959 2019-01-09  Tom Tromey  <tom@tromey.com>
12960
12961         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12962         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12963         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12964         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12965         (psym_lookup_symbol, psym_find_last_source_symtab)
12966         (psym_forget_cached_source_info, psym_print_stats)
12967         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12968         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12969         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12970         (psym_find_compunit_symtab_by_address)
12971         (maintenance_print_psymbols, maintenance_info_psymtabs)
12972         (maintenance_check_psymtabs): Use ranged for.
12973         * psymtab.h (class objfile_psymtabs): New.
12974         (require_partial_symbols): Return objfile_psymtabs.
12975         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12976
12977 2019-01-09  Tom Tromey  <tom@tromey.com>
12978
12979         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12980         (find_pc_mapped_section, list_overlays_command)
12981         (map_overlay_command, unmap_overlay_command)
12982         (simple_overlay_update): Use all_objfiles.
12983         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12984         * printcmd.c (info_symbol_command): Use all_objfiles.
12985         * objfiles.h (ALL_OBJSECTIONS): Remove.
12986         * maint.c (maintenance_translate_address): Use all_objfiles.
12987         * gcore.c (gcore_create_callback): Use all_objfiles.
12988         (objfile_find_memory_regions): Likewise.
12989
12990 2019-01-09  Tom Tromey  <tom@tromey.com>
12991
12992         * symtab.c (find_line_symtab, info_sources_command)
12993         (make_source_files_completion_list): Use objfile_compunits.
12994         * source.c (select_source_symtab): Use objfile_compunits.
12995         * objfiles.h (struct objfile): Update comment.
12996         (ALL_OBJFILES): Remove.
12997         (ALL_FILETABS): Remove.
12998         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12999         objfile_compunits.
13000
13001 2019-01-09  Tom Tromey  <tom@tromey.com>
13002
13003         * symmisc.c (print_objfile_statistics, dump_objfile)
13004         (maintenance_print_symbols): Use compunit_filetabs.
13005         * source.c (forget_cached_source_info_for_objfile): Use
13006         compunit_filetabs.
13007         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13008         (ALL_FILETABS): Use compunit_filetabs.
13009         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13010         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13011
13012 2019-01-09  Tom Tromey  <tom@tromey.com>
13013
13014         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13015         (compunit_filetabs): New.
13016         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13017         compunit_filetabs.
13018         (info_sources_command, make_source_files_completion_list): Remove
13019         declaration.
13020         * symmisc.c (print_objfile_statistics, dump_objfile)
13021         (maintenance_print_symbols): Remove declaration.
13022         (maintenance_info_symtabs): Use compunit_filetabs.
13023         (maintenance_info_line_tables): Likewise.
13024         * source.c (select_source_symtab): Change local variable name.
13025         (forget_cached_source_info_for_objfile): Remove declaration.
13026         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13027         * objfiles.c (objfile_relocate1): Remove declaration.
13028         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13029         declaration.
13030         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13031         * coffread.c (coff_symtab_read): Remove declaration.
13032         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13033         compunit_filetabs.
13034
13035 2019-01-09  Tom Tromey  <tom@tromey.com>
13036
13037         * symtab.c (lookup_objfile_from_block)
13038         (find_pc_sect_compunit_symtab, search_symbols)
13039         (default_collect_symbol_completion_matches_break_on): Use
13040         objfile_compunits.
13041         * objfiles.h (ALL_COMPUNITS): Remove.
13042         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13043         * cp-support.c (add_symbol_overload_list_qualified): Use
13044         objfile_compunits.
13045         * ada-lang.c (ada_collect_symbol_completion_matches)
13046         (ada_add_global_exceptions): Use objfile_compunits.
13047
13048 2019-01-09  Tom Tromey  <tom@tromey.com>
13049
13050         * source.c (select_source_symtab)
13051         (forget_cached_source_info_for_objfile): Remove declaration.
13052         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13053         declaration.
13054         * maint.c (count_symtabs_and_blocks): Remove declaration.
13055         * cp-support.c (add_symbol_overload_list_qualified): Remove
13056         declaration.
13057         * coffread.c (coff_symtab_read): Remove declaration.
13058         * symtab.c (lookup_symbol_in_objfile_symtabs)
13059         (basic_lookup_transparent_type_1): Use objfile_compunits.
13060         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13061         (info_sources_command, search_symbols)
13062         (default_collect_symbol_completion_matches_break_on)
13063         (make_source_files_completion_list): Remove declaration.
13064         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13065         (ada_collect_symbol_completion_matches)
13066         (ada_add_global_exceptions): Remove declaration.
13067         * linespec.c (iterate_over_all_matching_symtabs): Use
13068         objfile_compunits.
13069         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13070         (class objfile_compunits): New.
13071         (ALL_COMPUNITS): Use objfile_compunits.
13072         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13073         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13074         objfile_compunits.
13075         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13076
13077 2019-01-09  Tom Tromey  <tom@tromey.com>
13078
13079         * symtab.c (search_symbols)
13080         (default_collect_symbol_completion_matches_break_on): Use
13081         objfile_msymbols.
13082         * ada-lang.c (ada_lookup_simple_minsym)
13083         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13084         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13085         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13086         objfile_msymbols.
13087         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13088         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13089         * objc-lang.c (find_methods): Use objfile_msymbols.
13090         (info_selectors_command, info_classes_command): Likewise.
13091         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13092         * objfiles.h (class objfile_msymbols): New.
13093         (ALL_OBJFILE_MSYMBOLS): Remove.
13094         (ALL_MSYMBOLS): Remove.
13095
13096 2019-01-09  Tom Tromey  <tom@tromey.com>
13097
13098         * common/next-iterator.h (next_adapter): Add Iterator template
13099         parameter.
13100         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13101         (class all_objfiles_safe): New.
13102         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13103         * objfiles.c (put_objfile_before): Update comment.
13104         (add_separate_debug_objfile): Likewise.
13105         (free_all_objfiles): Use all_objfiles_safe.
13106         (objfile_purge_solibs): Likewise.
13107
13108 2019-01-09  Tom Tromey  <tom@tromey.com>
13109
13110         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13111         (expand_symtab_containing_pc, lookup_static_symbol)
13112         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13113         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13114         all_objfiles.
13115         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13116         * breakpoint.c (create_overlay_event_breakpoint)
13117         (create_longjmp_master_breakpoint)
13118         (create_std_terminate_master_breakpoint)
13119         (create_exception_master_breakpoint): Use all_objfiles.
13120         * linux-thread-db.c (try_thread_db_load_from_pdir)
13121         (has_libpthread): Use all_objfiles.
13122         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13123         * linespec.c (iterate_over_all_matching_symtabs)
13124         (search_minsyms_for_name): Use all_objfiles.
13125         * maint.c (maintenance_info_sections): Use all_objfiles.
13126         * main.c (captured_main_1): Use all_objfiles.
13127         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13128         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13129         * guile/scm-pretty-print.c
13130         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13131         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13132         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13133         (maintenance_print_msymbols): Use all_objfiles.
13134         * source.c (select_source_symtab): Use all_objfiles.
13135         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13136         * symfile.c (remove_symbol_file_command)
13137         (expand_symtabs_matching, map_symbol_filenames): Use
13138         all_objfiles.
13139         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13140         all_objfiles.
13141         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13142         * objc-lang.c (find_methods): Use all_objfiles.
13143         * objfiles.c (have_partial_symbols, have_full_symbols)
13144         (have_minimal_symbols, qsort_cmp)
13145         (default_iterate_over_objfiles_in_search_order): Use
13146         all_objfiles.
13147         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13148         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13149         (maintenance_check_psymtabs): Use all_objfiles.
13150         (ALL_PSYMTABS): Remove.
13151         * compile/compile-object-run.c (do_module_cleanup): Use
13152         all_objfiles.
13153         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13154         * cp-support.c (add_symbol_overload_list_qualified): Use
13155         all_objfiles.
13156         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13157         Use all_objfiles.
13158         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13159         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13160         all_objfiles.
13161         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13162         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13163         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13164         Uses all_objfiles.
13165         * solib.c (solib_read_symbols): Use all_objfiles
13166
13167 2019-01-09  Tom Tromey  <tom@tromey.com>
13168
13169         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13170         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13171         all_objfiles.
13172         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13173         * symmisc.c (print_symbol_bcache_statistics)
13174         (print_objfile_statistics, maintenance_print_objfiles)
13175         (maintenance_info_symtabs, maintenance_check_symtabs)
13176         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13177         all_objfiles.
13178         * source.c (forget_cached_source_info): Use all_objfiles.
13179         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13180         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13181         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13182         * objfiles.c (update_section_map): Use all_objfiles.
13183         (shared_objfile_contains_address_p): Likewise.
13184         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13185         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13186
13187 2019-01-09  Tom Tromey  <tom@tromey.com>
13188
13189         * common/next-iterator.h: New file.
13190         * objfiles.h (class all_objfiles): New.
13191         (struct objfile_iterator): New.
13192
13193 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13194
13195         * NEWS: Move the description of the changed "frame", "select-frame",
13196          and "info frame" commands to the Changed commands section.
13197
13198 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13199
13200         * gdbtypes.c (check_stub_method_group): Remove handling of old
13201         mangling schemes.
13202         * linespec.c (find_methods): Likewise.
13203         * stabsread.c (read_member_functions): Likewise.
13204         * valops.c (search_struct_method): Likewise.
13205         (value_struct_elt_for_reference): Likewise.
13206         * NEWS: Mention this change.
13207
13208 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13209
13210         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13211         print_source_lines.
13212         * source.c (print_source_lines_base): Update line number check.
13213         (print_source_lines): New function.
13214         (source_lines_range::source_lines_range): New function.
13215         * source.h (class source_lines_range): New class.
13216         (print_source_lines): New declaration.
13217
13218 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13219
13220         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13221
13222 2019-01-08  Tom Tromey  <tom@tromey.com>
13223             Simon Marchi  <simon.marchi@ericsson.com>
13224
13225         PR gdb/24060
13226         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13227         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13228         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13229         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13230         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13231         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13232
13233 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13234
13235         * source.c (select_source_symtab): Move header comment to
13236         declaration in source.h.
13237         (forget_cached_source_info_for_objfile): Likewise.
13238         (forget_cached_source_info): Likewise.
13239         (identify_source_line): Likewise.
13240         * source.h (identify_source_line): Move declaration from symtab.h
13241         and add comment from source.c
13242         (print_source_lines): Likewise.
13243         (forget_cached_source_info_for_objfile): Likewise.
13244         (forget_cached_source_info): Likewise.
13245         (select_source_symtab): Likewise.
13246         (enum print_source_lines_flag): Move definition from symtab.h.
13247         * symtab.h (identify_source_line): Move declaration to source.h.
13248         (print_source_lines): Likewise.
13249         (forget_cached_source_info_for_objfile): Likewise.
13250         (forget_cached_source_info): Likewise.
13251         (select_source_symtab): Likewise.
13252         (enum print_source_lines_flag): Move definition to source.h.
13253         * tui/tui-hooks.c: Add 'source.h' include.
13254
13255 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13256
13257         * source.c (print_source_lines_base): Handle requests to print
13258         reverse line number sequences, and guard against empty lines
13259         string.
13260
13261 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13262
13263         * source.c (print_source_lines_base): Fix skip of '\r' if next
13264         character is '\n'.
13265
13266 2019-01-06  Tom Tromey  <tom@tromey.com>
13267
13268         * c-exp.y (struct c_parse_state) <macro_original_text,
13269         expansion_obstack>: New member.
13270         (macro_original_text, expansion_obstack): Remove globals.
13271         (scan_macro_expansion, scanning_macro_expansion)
13272         (finished_macro_expansion): Update.
13273         (scan_macro_cleanup): Remove.
13274         (yylex, c_parse): Update.
13275
13276 2019-01-06  Tom Tromey  <tom@tromey.com>
13277
13278         * c-exp.y (struct c_parse_state) <strings>: New member.
13279         (operator_stoken): Update.
13280
13281 2019-01-06  Tom Tromey  <tom@tromey.com>
13282
13283         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13284         (union type_stack_elt) <typelist_val>: Now a pointer to
13285         std::vector.
13286         (type_stack_cleanup): Don't declare.
13287         (push_typelist): Update.
13288         * parse.c (pop_typelist): Return a std::vector.
13289         (push_typelist): Take a std::vector.
13290         (follow_types): Update.  Do not free args.
13291         (type_stack_cleanup): Remove.
13292         * c-exp.y (struct c_parse_state): New.
13293         (cpstate): New global.
13294         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13295         (nonempty_typelist): Update.
13296         (func_mod): Create a new vector.
13297         (c_parse): Create a c_parse_state.
13298         (check_parameter_typelist): Do not delete params.
13299         (function_method): Update.  Do not delete type_list.
13300
13301 2019-01-06  Tom Tromey  <tom@tromey.com>
13302
13303         PR gdb/28155:
13304         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13305         check_typedef.
13306         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13307         (print_return_value): Likewise.
13308
13309 2019-01-05  Tom Tromey  <tom@tromey.com>
13310
13311         * contrib/cleanup_check.py: Remove.
13312         * contrib/gcc-with-excheck: Remove.
13313         * contrib/exsummary.py: Remove.
13314         * contrib/excheck.py: Remove.
13315
13316 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13317
13318         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13319         NULL. Initialize tpprev to NULL instead of assigning it
13320         to NULL on the next statement.
13321         * windows-nat.c (windows_delete_thread): Remove check for
13322         main_thread_id before printing thread exit notifications.
13323         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13324         Remove thread ID check against main_thread_id.
13325         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13326         windows_delete_thread.
13327         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13328
13329 2019-01-04  Tom Tromey  <tom@tromey.com>
13330
13331         * compile/compile.c (_initialize_compile): Use upper case for
13332         metasyntactic variables.
13333         * symmisc.c (_initialize_symmisc): Use upper case for
13334         metasyntactic variables.
13335         * psymtab.c (_initialize_psymtab): Use upper case for
13336         metasyntactic variables.
13337         * demangle.c (demangle_command): Use upper case for metasyntactic
13338         variables.
13339         (_initialize_demangler): Likewise.
13340         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13341         variables.
13342
13343 2019-01-03  Tom Tromey  <tom@tromey.com>
13344
13345         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13346
13347 2019-01-03  Tom Tromey  <tom@tromey.com>
13348
13349         * python/py-symtab.c (salpy_str): Update.
13350         (struct salpy_sal_object) <symtab>: Now a PyObject.
13351         (salpy_dealloc): Update.
13352         (del_objfile_sal): Use gdbpy_ref.
13353
13354 2019-01-03  Tom Tromey  <tom@tromey.com>
13355
13356         * python/py-type.c (convert_field): Use new_reference.  Return
13357         gdbpy_ref.
13358         (make_fielditem): Return gdbpy_ref.
13359         (typy_fields): Update.
13360         (typy_getitem): Update.
13361         (field_name): Return gdbpy_ref.  Use new_reference.
13362         (typy_iterator_iternext): Update.
13363
13364 2019-01-03  Tom Tromey  <tom@tromey.com>
13365
13366         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13367
13368 2019-01-03  Tom Tromey  <tom@tromey.com>
13369
13370         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13371         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13372         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13373         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13374         (pspy_set_type_printers): Likewise.
13375         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13376         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13377         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13378         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13379         (objfpy_set_type_printers): Likewise.
13380
13381 2019-01-03  Tom Tromey  <tom@tromey.com>
13382
13383         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13384         (gdbpy_print_stack): Use gdbpy_err_fetch.
13385         * python/python-internal.h (class gdbpy_err_fetch): New class.
13386         (class gdbpy_enter) <m_error_type, m_error_value,
13387         m_error_traceback>: Remove.
13388         <m_error>: New member.
13389         (gdbpy_exception_to_string): Don't declare.
13390         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13391         * python/py-value.c (convert_value_from_python): Use
13392         gdbpy_err_fetch.
13393         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13394         gdbpy_exception_to_string.
13395         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13396         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13397         gdbpy_err_fetch.
13398
13399 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13400
13401         * linux-nat.c (delete_lwp_cleanup): Delete.
13402         (struct lwp_deleter): New struct.
13403         (lwp_info_up): New typedef.
13404         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13405         lwp_info_up.
13406
13407 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13408
13409         * linux-fork.c (class scoped_switch_fork_info): New class.
13410         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13411
13412 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13413
13414         * valops.c (find_overload_match): Remove use of null_cleanup, and
13415         calls to do_cleanups.
13416
13417 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13418
13419         * compile/compile-cplus-types.c
13420         (compile_cplus_instance::decl_name): Handle changes to
13421         cp_func_name.
13422         * cp-support.c (cp_func_name): Update header comment, update
13423         return type.
13424         * cp-support.h (cp_func_name): Update return type in declaration.
13425         * valops.c (find_overload_match): Move temp_func local to top
13426         level of function and change its type.  Use temp_func to hold and
13427         delete temporary string obtained from cp_func_name.
13428
13429 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13430
13431         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13432         gdb::char_vector, remove cleanup, and update uses of `msg`.
13433
13434 2019-01-03  Jim Wilson  <jimw@sifive.com>
13435
13436         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13437
13438 2019-01-02  Tom Tromey  <tom@tromey.com>
13439
13440         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13441         (tdesc_parse_xml): Remove cleanups.
13442         * target-descriptions.h (make_cleanup_free_target_description):
13443         Don't declare.
13444         (target_desc_deleter): New struct.
13445         (target_desc_up): New typedef.
13446         * target-descriptions.c (target_desc_deleter::operator()): Rename
13447         from free_target_description.
13448         (make_cleanup_free_target_description): Remove.
13449
13450 2019-01-02  Tom Tromey  <tom@tromey.com>
13451
13452         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13453         constructor, destructor.
13454         (linespec_parser): Remove typedef.
13455         (~linespec_parser): Rename from linespec_parser_delete.
13456         (linespec_lex_to_end, linespec_complete_label)
13457         (linespec_complete): Update.
13458         (decode_line_full): Remove cleanups.
13459         (decode_line_1): Update.
13460
13461 2019-01-02  Tom Tromey  <tom@tromey.com>
13462
13463         * python/python-internal.h (inferior_to_inferior_object): Change
13464         return type.
13465         * python/py-exitedevent.c (create_exited_event_object): Update.
13466         * python/py-inferior.c (inferior_to_inferior_object): Return
13467         gdbpy_ref.
13468         (python_new_inferior, python_inferior_deleted)
13469         (thread_to_thread_object, delete_thread_object)
13470         (build_inferior_list, gdbpy_selected_inferior): Update.
13471         * python/py-infthread.c (create_thread_object): Update.  Also fail
13472         if inferior_to_inferior_object fails.
13473
13474 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13475
13476         * inferior.h (class inferior) <displaced_step_state>: New field.
13477         * infrun.h (struct displaced_step_state): Move here from
13478         infrun.c.  Initialize fields, add constructor.
13479         <inf>: Remove field.
13480         <reset>: New method.
13481         * infrun.c (struct displaced_step_inferior_state): Move to
13482         infrun.h.
13483         (displaced_step_inferior_states): Remove.
13484         (get_displaced_stepping_state): Adust.
13485         (displaced_step_in_progress_any_inferior): Adjust.
13486         (displaced_step_in_progress_thread): Adjust.
13487         (displaced_step_in_progress): Adjust.
13488         (add_displaced_stepping_state): Remove.
13489         (get_displaced_step_closure_by_addr): Adjust.
13490         (remove_displaced_stepping_state): Remove.
13491         (infrun_inferior_exit): Call displaced_step_state.reset.
13492         (use_displaced_stepping): Don't check for NULL.
13493         (displaced_step_prepare_throw): Call
13494         get_displaced_stepping_state.
13495         (displaced_step_fixup): Don't check for NULL.
13496         (prepare_for_detach): Don't check for NULL.
13497
13498 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13499
13500         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13501          in case of call that did not complete.
13502
13503 2019-01-02  Andrey Utkin  <autkin@undo.io>
13504
13505         * symfile.c (find_separate_debug_file): Fix search of debug files for
13506         remote debuggee.
13507
13508 2019-01-02  Tom Tromey  <tom@tromey.com>
13509
13510         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13511         indentation.
13512         * python/py-frame.c (frapy_older): Remove cast.
13513         (frapy_newer): Likewise.
13514         * python/py-breakpoint.c (local_setattro): Remove cast.
13515         * python/py-arch.c (archpy_name): Remove local variable.
13516         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13517
13518 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13519
13520         * unittests/basic_string_view/element_access/char/empty.cc:
13521         Fix year range in copyright header.
13522
13523 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13524
13525         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13526         Delete.
13527         <operator==>: Update with for removed field.
13528         <hash>: Likewise.
13529         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13530         <isa_features>: ...this.
13531         <abi_features>: New field.
13532         (riscv_isa_flen): Update comment.
13533         (riscv_abi_xlen): New declaration.
13534         (riscv_abi_flen): New declaration.
13535         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13536         isa_features.
13537         (riscv_abi_xlen): New function.
13538         (riscv_isa_flen): Update to get answer from isa_features.
13539         (riscv_abi_flen): New function.
13540         (riscv_has_fp_abi): Update to get answer from abi_features.
13541         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13542         xlen and flen.
13543         (riscv_call_info) <xlen, flen>: Update comment.
13544         (riscv_call_arg_struct): Remove invalid assertions
13545         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13546         is removed.
13547         (riscv_gdbarch_init): Gather isa features and abi features
13548         separately, ensure both match on the gdbarch when reusing an old
13549         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13550         a target with 64-bit float hardware.
13551
13552 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13553
13554         * source.c (search_command_helper): Stop reverse search
13555         when line 1 has been searched.
13556
13557 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13558
13559         * record-full.c (record_full_base_target::close): Rewrite
13560         record_full_core_buf_list free logic.
13561
13562 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13563
13564         * break-catch-syscall.c (print_one_catch_syscall): xfree
13565         the last text.
13566
13567 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13568
13569         * top.c (print_gdb_version): Update Copyright year in version
13570         message.
13571
13572 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13573
13574         Update copyright year range in all GDB files.
13575
13576 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13577
13578         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13579
13580 For older changes see ChangeLog-2018.
13581 \f
13582 Local Variables:
13583 mode: change-log
13584 left-margin: 8
13585 fill-column: 74
13586 version-control: never
13587 coding: utf-8
13588 End:
13589