gdb/ChangeLog

   1 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * btrace.c (btrace_maint_clear): Update to handle change from VEC
   4         to std::vector.
   5         (btrace_maint_decode_pt): Likewise, and move allocation of the
   6         vector outside of the loop.
   7         (btrace_maint_update_packets): Update to handle change from VEC to
   8         std::vector.
   9         (btrace_maint_print_packets): Likewise.
  10         (maint_info_btrace_cmd): Likewise.
  11         * btrace.h: Remove use of DEF_VEC_O.
  12         (typedef btrace_pt_packet_s): Delete.
  13         (struct btrace_maint_info) <packets>: Change fromm VEC to
  14         std::vector.
  15         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
  16
  17 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  18
  19         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
  20         make accesses into the vector constant references.
  21         (btrace_add_pc): Update for std::vector.
  22         (btrace_stitch_bts): Likewise.
  23         (parse_xml_btrace_block): Likewise.
  24         (btrace_maint_update_packets): Likewise.
  25         (btrace_maint_print_packets): Likewise.
  26         (maint_info_btrace_cmd): Likewise.
  27         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
  28         std::vector.
  29         (btrace_data::empty): Likewise.
  30         (btrace_data_append): Likewise.
  31         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
  32         (typedef btrace_block_s): Delete.
  33         (struct btrace_block): Add constructor.
  34         (struct btrace_data_bts) <blocks>: Change to std::vector.
  35         * nat/linux-btrace.c (perf_event_read_bts): Update for
  36         std::vector.
  37         (linux_read_bts): Likewise.
  38
  39 2019-10-01  Tom Tromey  <tom@tromey.com>
  40
  41         * cli/cli-logging.c (show_logging_filename): Use styled_string.
  42
  43 2019-10-01  Tom Tromey  <tom@tromey.com>
  44
  45         * stack.c (print_frame, info_frame_command_core): Use
  46         styled_string.
  47         * linux-thread-db.c (try_thread_db_load_1)
  48         (try_thread_db_load_from_pdir_1): Use styled_string.
  49         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
  50         (auto_load_section_scripts, info_auto_load_local_gdbinit)
  51         (maybe_print_unsupported_script_warning)
  52         (maybe_print_script_not_found_warning): Use styled_string.
  53         * ada-lang.c (user_select_syms): Use styled_string.
  54
  55 2019-10-01  Tom Tromey  <tom@tromey.com>
  56
  57         * p-lang.c (pascal_printstr): Use metadata style.
  58         * value.c (show_convenience): Use metadata style.
  59         * valprint.c (valprint_check_validity, val_print_optimized_out)
  60         (val_print_not_saved, val_print_unavailable)
  61         (val_print_invalid_address, generic_val_print, val_print)
  62         (value_check_printable, val_print_array_elements): Use metadata
  63         style.
  64         * ui-out.h (class ui_out) <field_fmt>: New overload.
  65         <do_field_fmt>: Add style parameter.
  66         * ui-out.c (ui_out::field_fmt): New overload.
  67         * typeprint.c (type_print_unknown_return_type)
  68         (val_print_not_allocated, val_print_not_associated): Use metadata
  69         style.
  70         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
  71         parameter.
  72         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
  73         * tracepoint.c (tvariables_info_1): Use metadata style.
  74         * stack.c (print_frame_arg, print_frame_info, print_frame)
  75         (info_frame_command_core): Use metadata style.
  76         * skip.c (info_skip_command): Use metadata style.
  77         * rust-lang.c (rust_print_enum): Use metadata style.
  78         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
  79         metadata style.
  80         * python/py-framefilter.c (py_print_single_arg): Use metadata
  81         style.
  82         * printcmd.c (do_one_display, print_variable_and_value): Use
  83         metadata style.
  84         * p-valprint.c (pascal_val_print)
  85         (pascal_object_print_value_fields): Use metadata style.
  86         * p-typeprint.c (pascal_type_print_base): Use metadata style.
  87         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
  88         parameter.
  89         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
  90         * m2-valprint.c (m2_print_long_set): Use metadata style.
  91         * m2-typeprint.c (m2_print_type): Use metadata style.
  92         * infcmd.c (print_return_value_1): Use metadata style.
  93         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
  94         * f-valprint.c (info_common_command_for_block): Use metadata
  95         style.
  96         * f-typeprint.c (f_type_print_base): Use metadata style.
  97         * expprint.c (print_subexp_standard): Use metadata style.
  98         * cp-valprint.c (cp_print_value_fields): Use metadata style.
  99         * cli/cli-style.h (class cli_style_option): Add constructor.
 100         (metadata_style): Declare.
 101         * cli/cli-style.c (metadata_style): New global.
 102         (_initialize_cli_style): Register metadata style.
 103         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 104         parameter.
 105         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 106         * c-typeprint.c (c_type_print_base_struct_union)
 107         (c_type_print_base_1): Use metadata style.
 108         * breakpoint.c (watchpoint_value_print)
 109         (print_one_breakpoint_location): Use metadata style.
 110         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 111         style.
 112         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 113         style.
 114         * ada-valprint.c (val_print_packed_array_elements, printstr)
 115         (print_field_values, ada_val_print_ref, ada_val_print): Use
 116         metadata style.
 117         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 118         style.
 119         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 120         style.
 121         * ada-lang.c (user_select_syms): Use metadata style.
 122
 123 2019-10-01  Tom Tromey  <tom@tromey.com>
 124
 125         * cli/cli-cmds.c (pwd_command): Style output.
 126
 127 2019-10-01  Pedro Alves  <palves@redhat.com>
 128             Tom Tromey  <tom@tromey.com>
 129
 130         * symtab.c (print_symbol_info): Use %ps.
 131         (print_msymbol_info): Use %ps.
 132         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 133         * printcmd.c (print_variable_and_value): Use %ps.
 134         * macrocmd.c (show_pp_source_pos): Use %ps.
 135         * infrun.c (print_exited_reason): Use ui_out::message.
 136         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 137         (describe_other_breakpoints): Use ui_out::message and new
 138         formats.
 139         (say_where): Use new formats.
 140         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 141         and new formats.
 142
 143 2019-10-01  Pedro Alves  <palves@redhat.com>
 144             Tom Tromey  <tom@tromey.com>
 145
 146         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 147         (test_gdb_formats): New function.
 148         (run_tests): Call it.
 149         (test_format_specifier): Update.
 150         * utils.h (fputs_filtered): Update comment.
 151         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 152         (fputs_styled_unfiltered): Declare.
 153         * utils.c (fputs_styled_unfiltered): New function.
 154         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 155         (vfprintf_filtered): Update.
 156         (vfprintf_unfiltered, vprintf_filtered): Update.
 157         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 158         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 159         disallow_ui_out_field>: New constants.
 160         (enum class field_kind): New.
 161         (struct base_field_s, struct signed_field_s): New.
 162         (signed_field): New function.
 163         (struct string_field_s): New.
 164         (string_field): New function.
 165         (struct styled_string_s): New.
 166         (styled_string): New function.
 167         (class ui_out) <message>: Add comment.
 168         <vmessage, call_do_message>: New methods.
 169         <do_message>: Add style parameter.
 170         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 171         methods.
 172         (ui_out::message): Rewrite.
 173         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 174         parameter.
 175         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 176         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 177         gdb_extensions parameter.
 178         (class format_piece): Add parameter to constructor.
 179         (n_int_args): New field.
 180         * gdbsupport/format.c (format_pieces::format_pieces): Add
 181         gdb_extensions parameter.  Handle '*'.
 182         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 183         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 184         vfprintf_styled_no_gdbfmt.
 185         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 186         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 187         unfiltered output.
 188         * ui-style.h (struct ui_file_style) <ptr>: New method.
 189
 190 2019-10-01  Tom Tromey  <tom@tromey.com>
 191
 192         * unittests/format_pieces-selftests.c: Update.  Add final format.
 193         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 194         empty literal pieces.
 195
 196 2019-10-01  Tom Tromey  <tom@tromey.com>
 197
 198         * ui-out.h (enum class ui_out_style_kind): Remove.
 199         (class ui_out) <field_string, field_stsream, do_field_string>:
 200         Change type of "style".
 201         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 202         (ui_out::field_string): Update.
 203         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 204         of "style".
 205         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 206         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 207         * stack.c (print_frame_arg, print_frame_info, print_frame):
 208         Update.
 209         * source.c (print_source_lines_base): Update.
 210         * solib.c (info_sharedlibrary_command): Update.
 211         * skip.c (info_skip_command): Update.
 212         * record-btrace.c (btrace_call_history_src_line)
 213         (btrace_call_history): Update.
 214         * python/py-framefilter.c (py_print_frame): Update.
 215         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 216         "style".
 217         * mi/mi-out.c (mi_ui_out::do_table_header)
 218         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 219         (mi_ui_out::do_field_string): Update.
 220         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 221         Update.
 222         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 223         "style".
 224         * cli-out.c (cli_ui_out::do_table_header)
 225         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 226         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 227         (cli_ui_out::do_field_fmt): Update.
 228         * breakpoint.c (print_breakpoint_location): Update.
 229         (update_static_tracepoint): Update.
 230
 231 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 232
 233         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 234         conversion of gdb_datadir.
 235         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 236         remove not needed c_str ().
 237
 238 2019-09-30  Ali Tamur <tamur@google.com>
 239
 240         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 241         (dwarf2_string_attr): Likewise.
 242
 243 2019-09-30  Ali Tamur <tamur@google.com>
 244
 245         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 246         (process_full_type_unit): Likewise.
 247         (dump_die_shallow): Likewise.
 248         (cu_debug_loc_section): Likewise.
 249
 250 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 251
 252         * minsyms.c (compare_minimal_symbols): Rename to...
 253         (minimal_symbol_is_less_than): ...this, and adjust to STL
 254         conventions (return bool, take arguments as references)
 255         (minimal_symbol_reader::install): Call std::sort instead
 256         of qsort.
 257
 258 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 259
 260         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 261         hash and why.
 262         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 263         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 264
 265 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 266
 267         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 268         * psympriv.h (add_psymbol_to_list): Move comment here and update
 269         it.
 270
 271 2019-09-29  Tom de Vries  <tdevries@suse.de>
 272
 273         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 274         Use $tmpdir/$(basename "$output_file").dwz instead of
 275         "${output_file}.dwz".
 276
 277 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 278
 279         PR gdb/25045
 280         * hppa-linux-nat.c: Include gdbarch.h.
 281
 282 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 283
 284         * blockframe.c (find_pc_partial_function): Change return type to bool.
 285         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 286         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 287         (stub_gnu_ifunc_resolve_name): Likewise.
 288         * symtab.c (compare_filenames_for_search): Likewise.
 289         (compare_glob_filenames_for_search): Likewise.
 290         (matching_obj_sections): Likewise.
 291         (symbol_matches_domain): Likewise.
 292         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 293         (find_line_pc): Change return type to bool.
 294         (find_line_pc_range): Likewise.
 295         (producer_is_realview): Likewise.
 296         * symtab.h (symbol_matches_domain): Likewise.
 297         (find_pc_partial_function): Likewise.
 298         (find_pc_line_pc_range): Likewise.
 299         (in_gnu_ifunc_stub): Likewise.
 300         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 301         (find_line_pc): Likewise.
 302         (find_line_pc_range): Likewise.
 303         (matching_obj_sections): Likewise.
 304         (find_line_symtab): Change out parameter to bool.
 305         (producer_is_realview): Change return type to bool.
 306         (compare_filenames_for_search): Likewise.
 307         (compare_glob_filenames_for_search): Likewise.
 308
 309 2019-09-26  Tom Tromey  <tom@tromey.com>
 310
 311         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 312         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 313         * gdb_usleep.h: Remove.
 314         * gdb_usleep.c: Remove.
 315         * utils.c: Don't include gdb_usleep.h.
 316
 317 2019-09-26  Tom Tromey  <tromey@adacore.com>
 318
 319         * python/py-type.c (type_to_type_object): Call check_typedef
 320         for stub types.
 321
 322 2019-09-26  Tom Tromey  <tom@tromey.com>
 323
 324         * utils.h (initialize_utils): Don't declare.
 325         * top.c (gdb_init): Don't call initialize_utils.
 326         * utils.c (initialize_utils): Remove.  Move contents...
 327         (_initialize_utils): ... here.
 328
 329 2019-09-25  Tom Tromey  <tom@tromey.com>
 330
 331         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 332         * utils.h (make_hex_string): Don't declare.
 333         * utils.c (make_hex_string): Remove.
 334
 335 2019-09-24  Tom de Vries  <tdevries@suse.de>
 336
 337         PR gdb/23815
 338         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 339         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 340
 341 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 342
 343         * NEWS: Mention new simulator port for PRU.
 344
 345 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 346
 347         * ada-exp.y (write_object_remaining): Update.
 348         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 349         and eliminate the static buffer.
 350         (ada_decode_symbol): Update.
 351         (ada_la_decode): Update.
 352         (ada_sniff_from_mangled_name): Update.
 353         (is_valid_name_for_wild_match): Update.
 354         (ada_lookup_name_info::matches): Update and simplify.
 355         (name_matches_regex): Update.
 356         (ada_add_global_exceptions): Update.
 357         * ada-lang.h (ada_decode): Update signature.
 358         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 359         * dwarf-index-write.c (debug_names::insert): Update.
 360
 361 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 362
 363         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 364         formatting.
 365
 366 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 367
 368         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 369         Change "nonzero" to "true" in documentation.
 370
 371 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 372
 373         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 374         (_initialize_darwin_solib): Don't set
 375         darwin_so_ops.lookup_lib_global_symbol.
 376         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 377         set_gdbarch_iterate_over_objfiles_in_search_order.
 378         (elf_lookup_lib_symbol): Rename to...
 379         (svr4_iterate_over_objfiles_in_search_order): this, and update
 380         to iterate semantics.
 381         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 382         * solib.c (solib_global_lookup): Remove.
 383         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 384         (solib_global_lookup): Remove.
 385         * symtab.c (lookup_global_or_static_symbol): Remove call to
 386         solib_global_lookup.
 387
 388 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 389
 390         * NEWS: Move entries about default MI version now being
 391         version 3, and about the GDB/MI fix for multi-location
 392         breakpoints to the "since GDB 8.3" section.
 393
 394 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 395
 396         GDB 8.3.1 released.
 397
 398 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 399
 400         * NEWS: Mention that Cell/B.E. debugging support was removed.
 401         * MAINTAINERS: Remove spu target.
 402
 403         * config/djgpp/fnchange.lst: Remove entries for removed files.
 404
 405         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 406         spu-multiarch.o, and spu-tdep.o.
 407         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 408         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 409         spu-multiarch.c, and spu-tdep.c.
 410         * spu-linux-nat.c: Remove file.
 411         * spu-multiarch.c: Remove file.
 412         * spu-tdep.c: Remove file.
 413         * spu-tdep.h: Remove file.
 414         * solib-spu.c: Remove file.
 415         * solib-spu.h: Remove file.
 416
 417         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 418         * configure.nat (spu-linux): Remove.
 419         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 420         solib-multiarch.o from gdb_target_obs.
 421         (spu*-*-*): Remove.
 422
 423         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 424         feature flag.
 425         (ppc_linux_no_features): Update.
 426         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 427         Cell/B.E. support.
 428         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 429         (tdesc_powerpc_cell64l): Likewise.
 430         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 431         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 432         Cell/B.E. support.
 433         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 434         Do not include "features/rs6000/powerpc-cell32l.c" or
 435         "features/rs6000/powerpc-cell64l.c".
 436         (ppc_linux_spu_section): Remove.
 437         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 438         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 439         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 440         (ppc_linux_spe_context_lookup): Remove.
 441         (ppc_linux_spe_context_inferior_created): Remove.
 442         (ppc_linux_spe_context_solib_loaded): Remove.
 443         (ppc_linux_spe_context_solib_unloaded): Remove.
 444         (ppc_linux_spe_context): Remove.
 445         (struct ppu2spu_cache): Remove.
 446         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 447         (struct ppu2spu_data): Remove.
 448         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 449         ppu2spu_unwind): Remove.
 450         (ppc_linux_init_abi): Remove Cell/B.E. support.
 451         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 452
 453         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 454         (rs6000/powerpc-cell64l-expedite): Likewise
 455         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 456         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 457         rs6000/powerpc-cell64l.xml.
 458         * features/rs6000/powerpc-cell32l.xml: Remove.
 459         * features/rs6000/powerpc-cell64l.xml: Likewise.
 460         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 461         * features/rs6000/powerpc-cell64l.c: Likewise.
 462         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 463         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 464         * regformats/reg-spu.dat: Remove.
 465
 466         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 467         * corelow.c (struct spuid_list): Remove.
 468         (add_to_spuid_list): Remove.
 469         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 470         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 471         (remote_protocol_features): Remove associated entries.
 472         (_initialize_remote): No longer initialize them.
 473         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 474         * linux-nat.c (SPUFS_MAGIC): Remove.
 475         (linux_proc_xfer_spu): Remove.
 476         (spu_enumerate_spu_ids): Remove.
 477         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 478         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 479         (linux_make_corefile_notes): No longer call it.
 480
 481         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 482         (cooked_write_test): Likewise.
 483
 484 2019-09-20  Tom Tromey  <tom@tromey.com>
 485
 486         * NEWS: Mention case-sensitivity of TUI commands.
 487         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 488         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 489         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 490
 491 2019-09-20  Tom Tromey  <tom@tromey.com>
 492
 493         * tui/tui-source.c (tui_source_window::set_contents): Use
 494         make_unique_xstrdup.
 495         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 496         make_unique_xstrdup.
 497
 498 2019-09-20  Tom Tromey  <tom@tromey.com>
 499
 500         * tui/tui-data.c: Remove separator comments.
 501         * tui/tui-layout.c: Remove separator comments.
 502         * tui/tui-win.c: Remove separator comments.
 503         * tui/tui-wingeneral.c: Remove separator comments.
 504
 505 2019-09-20  Tom Tromey  <tom@tromey.com>
 506
 507         * tui/tui.h (strcat_to_buf): Don't declare.
 508         * tui/tui.c (strcat_to_buf): Remove.
 509
 510 2019-09-20  Tom Tromey  <tom@tromey.com>
 511
 512         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 513         from "fullname".
 514         * tui/tui-source.c (tui_source_window::set_contents)
 515         (tui_source_window::location_matches_p)
 516         (tui_source_window::maybe_update): Update.
 517
 518 2019-09-20  Tom Tromey  <tom@tromey.com>
 519
 520         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 521         Update.
 522         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 523         prefix.
 524         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 525         (tui_data_window::line_from_reg_element_no)
 526         (tui_data_window::first_reg_element_no_inline)
 527         (tui_data_window::show_registers)
 528         (tui_data_window::show_register_group)
 529         (tui_data_window::display_registers_from)
 530         (tui_data_window::display_registers_from_line)
 531         (tui_data_window::first_data_item_displayed)
 532         (tui_data_window::delete_data_content_windows)
 533         (tui_data_window::erase_data_content)
 534         (tui_data_window::do_scroll_vertical)
 535         (tui_data_window::refresh_window)
 536         (tui_data_window::check_register_values): Update.
 537
 538 2019-09-20  Tom Tromey  <tom@tromey.com>
 539
 540         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 541         (struct tui_locator_window) <full_name, proc_name>: Now
 542         std::string.
 543         * tui/tui-stack.c (tui_locator_window::make_status_line)
 544         (tui_locator_window::set_locator_fullname)
 545         (tui_locator_window::set_locator_info): Update.
 546         * tui/tui-source.c (tui_source_window::set_contents)
 547         (tui_source_window::showing_source_p): Update.
 548
 549 2019-09-20  Tom Tromey  <tom@tromey.com>
 550
 551         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 552         Don't call tui_locator_win_info_ptr.
 553
 554 2019-09-20  Tom Tromey  <tom@tromey.com>
 555
 556         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 557
 558 2019-09-20  Tom Tromey  <tom@tromey.com>
 559
 560         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 561         height for locator.
 562         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 563         * tui/tui-layout.c (show_source_disasm_command, show_data)
 564         (show_source_or_disasm_and_command): Use 1 as height for locator.
 565
 566 2019-09-20  Tom Tromey  <tom@tromey.com>
 567
 568         * tui/tui.c (tui_enable): Update.
 569         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 570         Update.
 571         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 572         Update.
 573         * tui/tui-data.c (win_resized): Now bool.
 574         (tui_win_resized): Return bool.
 575         (tui_set_win_resized_to): Accept a bool.
 576
 577 2019-09-20  Tom Tromey  <tom@tromey.com>
 578
 579         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 580         Change type of "refresh_values_only".
 581         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 582         type of "refresh_values_only".
 583
 584 2019-09-20  Tom Tromey  <tom@tromey.com>
 585
 586         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 587         std::string.
 588         (tui_disassemble): Add "pos" parameter.
 589         (tui_disasm_window::set_contents): Simplify.
 590
 591 2019-09-20  Tom Tromey  <tom@tromey.com>
 592
 593         * tui/tui-winsource.h (struct tui_source_window_base)
 594         <show_source_content>: Now private.
 595         * tui/tui-winsource.c
 596         (tui_source_window_base::show_source_content): Don't handle empty
 597         content case.
 598
 599 2019-09-20  Tom Tromey  <tom@tromey.com>
 600
 601         * tui/tui-layout.c (show_source_disasm_command)
 602         (show_source_or_disasm_and_command): Don't call
 603         show_source_content.
 604
 605 2019-09-20  Tom Tromey  <tom@tromey.com>
 606
 607         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 608         Declare.
 609         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 610         from tui_make_status_line.
 611         (tui_locator_window::rerender): Update.
 612
 613 2019-09-20  Tom Tromey  <tom@tromey.com>
 614
 615         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 616         (tui_locator_window::rerender): Update.
 617
 618 2019-09-20  Tom Tromey  <tom@tromey.com>
 619
 620         * tui/tui-winsource.h (struct tui_source_window_base)
 621         <~tui_source_window_base>: Don't declare.
 622         <fullname>: Remove.
 623         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 624         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 625         member.
 626         * tui/tui-source.c (tui_source_window::set_contents): Update.
 627         (tui_source_window::location_matches_p)
 628         (tui_source_window::maybe_update): Update.
 629
 630 2019-09-20  Tom Tromey  <tom@tromey.com>
 631
 632         * tui/tui-winsource.h (~tui_source_element): Remove.
 633         (tui_source_element): Update.
 634         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 635         * tui/tui-winsource.c (tui_show_source_line): Update.
 636         * tui/tui-source.c (tui_source_window::set_contents): Update.
 637         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 638
 639 2019-09-20  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 642         declare.
 643         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 644         tui_clear_source_windows_detail.
 645         * tui/tui-winsource.h (struct tui_source_window_base)
 646         <clear_detail>: Don't declare.
 647         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 648         Remove.
 649         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 650
 651 2019-09-20  Tom Tromey  <tromey@adacore.com>
 652
 653         PR ada/24919:
 654         * block.c (contained_in): Fix final return value.
 655
 656 2019-09-20  Alan Modra  <amodra@gmail.com>
 657
 658         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 659         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 660         (read_indirect_string_from_dwz): Use bfd accessor.
 661         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 662         * machoread.c (macho_symfile_read_all_oso): Likewise.
 663         * solib.c (solib_bfd_open): Likewise.
 664
 665 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 666
 667         * eval.c: Move declaration of overload_resolution to...
 668         * value.h: ...here.
 669
 670 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 671
 672         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 673         * arm-linux-tdep.c: Likewise.
 674         * arm-nbsd-nat.c: Likewise.
 675         * arm-tdep.h: Declare arm_apcs_32.
 676         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 677
 678 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 679
 680         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 681         * dwarf2read.h: Declare dwarf_always_disassemble.
 682
 683 2019-09-19  Tom de Vries  <tdevries@suse.de>
 684
 685         PR gdb/25009
 686         * source-cache.c (source_cache::ensure): Catch exception thrown during
 687         construction of the highlighter.
 688
 689 2019-09-18  Alan Modra  <amodra@gmail.com>
 690
 691         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 692         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 693         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 694         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 695         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 696         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 697         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 698         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 699         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 700         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 701         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 702         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 703         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 704         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 705         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 706         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 707         * mi/mi-interp.c: Update throughout for bfd section macro and
 708         function changes.
 709         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 710         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 711
 712 2019-09-18  Tom Tromey  <tom@tromey.com>
 713
 714         * NEWS: Add entry.
 715         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 716         call rl_initialize.
 717         (tui_enable): Do not call rl_initialize.
 718
 719 2019-09-18  Christian Groessler  <chris@groessler.org>
 720
 721         * alpha-linux-nat.c: Include gdbarch.h.
 722
 723 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 724
 725         * ui-file.c: Include cli/cli-style.h.
 726         (term_cli_styling): Remove cli_styling declaration.
 727
 728 2019-09-18  Alan Modra  <amodra@gmail.com>
 729
 730         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 731         to bfd_asymbol_section.
 732
 733 2019-09-18  Alan Modra  <amodra@gmail.com>
 734
 735         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 736         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 737         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 738
 739 2019-09-18  Alan Modra  <amodra@gmail.com>
 740
 741         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 742         * spu-linux-nat.c (spu_bfd_open): Likewise.
 743
 744 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 745
 746         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 747         to bool to match definition in dwarf2read.c.
 748
 749 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 750
 751         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 752         (print_signatures): Likewise.
 753         (trust_pad_over_xvs): Likewise.
 754         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 755         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 756         * arm-linux-nat.c (arm_apcs_32): Likewise.
 757         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 758         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 759         * arm-tdep.c (arm_debug): Likewise.
 760         (arm_apcs_32): Likewise.
 761         * auto-load.c (debug_auto_load): Likewise.
 762         (auto_load_gdb_scripts): Likewise.
 763         (global_auto_load): Likewise.
 764         (auto_load_local_gdbinit): Likewise.
 765         (auto_load_local_gdbinit_loaded): Likewise.
 766         * auto-load.h (global_auto_load): Likewise.
 767         (auto_load_local_gdbinit): Likewise.
 768         (auto_load_local_gdbinit_loaded): Likewise.
 769         * breakpoint.c (disconnected_dprintf): Likewise.
 770         (breakpoint_proceeded): Likewise.
 771         (automatic_hardware_breakpoints): Likewise.
 772         (always_inserted_mode): Likewise.
 773         (target_exact_watchpoints): Likewise.
 774         (_initialize_breakpoint): Update.
 775         * breakpoint.h (target_exact_watchpoints): Change to bool.
 776         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 777         * cli/cli-cmds.c (trace_commands): Likewise.
 778         * cli/cli-cmds.h (trace_commands): Likewise.
 779         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 780         to bool*.
 781         * cli/cli-logging.c (logging_overwrite): Change to bool.
 782         (logging_redirect): Likewise.
 783         (debug_redirect): Likewise.
 784         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 785         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 786         to bool.
 787         <boolean_option_def>: Update.
 788         (struct flag_option_def): Change default type of Context to bool
 789         from int.
 790         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 791         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 792         (get_setshow_command_value_string): Likewise.
 793         * cli/cli-style.c (cli_styling): Change to bool.
 794         (source_styling): Likewise.
 795         * cli/cli-style.h (source_styling): Likewise.
 796         (cli_styling): Likewise.
 797         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 798         to bool.
 799         * command.h (var_types): Update comment.
 800         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 801         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 802         bool.
 803         (debug_compile_cplus_scopes): Likewise.
 804         * compile/compile-internal.h (compile_debug): Likewise.
 805         * compile/compile.c (compile_debug): Likewise.
 806         (struct compile_options) <raw>: Likewise.
 807         * cp-support.c (catch_demangler_crashes): Likewise.
 808         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 809         (usr_cmd_cris_dwarf2_cfi): Likewise.
 810         * csky-tdep.c (csky_debug): Likewise.
 811         * darwin-nat.c (enable_mach_exceptions): Likewise.
 812         * dcache.c (dcache_enabled_p): Likewise.
 813         * defs.h (info_verbose): Likewise.
 814         * demangle.c (demangle): Likewise.
 815         (asm_demangle): Likewise.
 816         * dwarf-index-cache.c (debug_index_cache): Likewise.
 817         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 818         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 819         * dwarf2read.c (check_physname): Likewise.
 820         (use_deprecated_index_sections): Likewise.
 821         (dwarf_always_disassemble): Likewise.
 822         * eval.c (overload_resolution): Likewise.
 823         * event-top.c (set_editing_cmd_var): Likewise.
 824         (exec_done_display_p): Likewise.
 825         * event-top.h (set_editing_cmd_var): Likewise.
 826         (exec_done_display_p): Likewise.
 827         * exec.c (write_files): Likewise.
 828         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 829         (debug_fbsd_nat): Likewise.
 830         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 831         Likewise.
 832         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 833         <backtrace_past_entry> Likewise.
 834         * gdb-demangle.h (demangle): Likewise.
 835         (asm_demangle): Likewise.
 836         * gdb_bfd.c (bfd_sharing): Likewise.
 837         * gdbcore.h (write_files): Likewise.
 838         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 839         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 840         * gdbthread.h (print_thread_events): Likewise.
 841         * gdbtypes.c (opaque_type_resolution): Likewise.
 842         (strict_type_checking): Likewise.
 843         * gnu-nat.c (gnu_debug_flag): Likewise.
 844         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 845         * guile/scm-param.c (pascm_variable): Add boolval.
 846         (add_setshow_generic): Update.
 847         (pascm_param_value): Update.
 848         (pascm_set_param_value_x): Update.
 849         * hppa-tdep.c (hppa_debug): Change to bool..
 850         * infcall.c (may_call_functions_p): Likewise.
 851         (coerce_float_to_double_p): Likewise.
 852         (unwind_on_signal_p): Likewise.
 853         (unwind_on_terminating_exception_p): Likewise.
 854         * infcmd.c (startup_with_shell): Likewise.
 855         * inferior.c (print_inferior_events): Likewise.
 856         * inferior.h (startup_with_shell): Likewise.
 857         (print_inferior_events): Likewise.
 858         * infrun.c (step_stop_if_no_debug): Likewise.
 859         (detach_fork): Likewise.
 860         (debug_displaced): Likewise.
 861         (disable_randomization): Likewise.
 862         (non_stop): Likewise.
 863         (non_stop_1): Likewise.
 864         (observer_mode): Likewise.
 865         (observer_mode_1): Likewise.
 866         (set_observer_mode): Update.
 867         (sched_multi): Change to bool.
 868         * infrun.h (debug_displaced): Likewise.
 869         (sched_multi): Likewise.
 870         (step_stop_if_no_debug): Likewise.
 871         (non_stop): Likewise.
 872         (disable_randomization): Likewise.
 873         * linux-tdep.c (use_coredump_filter): Likewise.
 874         (dump_excluded_mappings): Likewise.
 875         * linux-thread-db.c (auto_load_thread_db): Likewise.
 876         (check_thread_db_on_load): Likewise.
 877         * main.c (captured_main_1): Update.
 878         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 879         xx2_opt, boolean_opt>: Change to bool.
 880         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 881         * maint.c (maintenance_profile_p): Likewise.
 882         (per_command_time): Likewise.
 883         (per_command_space): Likewise.
 884         (per_command_symtab): Likewise.
 885         * memattr.c (inaccessible_by_default): Likewise.
 886         * mi/mi-main.c (mi_async): Likewise.
 887         (mi_async_1): Likewise.
 888         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 889         * nat/fork-inferior.h (startup_with_shell): Likewise.
 890         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 891         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 892         * nios2-tdep.c (nios2_debug): Likewise.
 893         * or1k-tdep.c (or1k_debug): Likewise.
 894         * parse.c (parser_debug): Likewise.
 895         * parser-defs.h (parser_debug): Likewise.
 896         * printcmd.c (print_symbol_filename): Likewise.
 897         * proc-api.c (procfs_trace): Likewise.
 898         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 899         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 900         (set_parameter_value): Update.
 901         (add_setshow_generic): Update.
 902         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 903         to bool*.
 904         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 905         int*.
 906         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 907         * record-btrace.c (record_btrace_target::store_registers): Update.
 908         * record-full.c (record_full_memory_query): Change to bool.
 909         (record_full_stop_at_limit): Likewise.
 910         * record-full.h (record_full_memory_query): Likewise.
 911         * remote-notif.c (notif_debug): Likewise.
 912         * remote-notif.h (notif_debug): Likewise.
 913         * remote.c (use_range_stepping): Likewise.
 914         (interrupt_on_connect): Likewise.
 915         (remote_break): Likewise.
 916         * ser-tcp.c (tcp_auto_retry): Likewise.
 917         * ser-unix.c (serial_hwflow): Likewise.
 918         * skip.c (debug_skip): Likewise.
 919         * solib-aix.c (solib_aix_debug): Likewise.
 920         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 921         (spu_auto_flush_cache_p): Likewise.
 922         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 923         Likewise.
 924         (struct info_print_options) <quiet>: Likewise.
 925         * symfile-debug.c (debug_symfile): Likewise.
 926         * symfile.c (auto_solib_add): Likewise.
 927         (separate_debug_file_debug): Likewise.
 928         * symfile.h (auto_solib_add): Likewise.
 929         (separate_debug_file_debug): Likewise.
 930         * symtab.c (basenames_may_differ): Likewise.
 931         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 932         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 933         (struct info_types_options) <quiet>: Likewise.
 934         * symtab.h (demangle): Likewise.
 935         (basenames_may_differ): Likewise.
 936         * target-dcache.c (stack_cache_enabled_1): Likewise.
 937         (code_cache_enabled_1): Likewise.
 938         * target.c (trust_readonly): Likewise.
 939         (may_write_registers): Likewise.
 940         (may_write_memory): Likewise.
 941         (may_insert_breakpoints): Likewise.
 942         (may_insert_tracepoints): Likewise.
 943         (may_insert_fast_tracepoints): Likewise.
 944         (may_stop): Likewise.
 945         (auto_connect_native_target): Likewise.
 946         (target_stop_and_wait): Update.
 947         (target_async_permitted): Change to bool.
 948         (target_async_permitted_1): Likewise.
 949         (may_write_registers_1): Likewise.
 950         (may_write_memory_1): Likewise.
 951         (may_insert_breakpoints_1): Likewise.
 952         (may_insert_tracepoints_1): Likewise.
 953         (may_insert_fast_tracepoints_1): Likewise.
 954         (may_stop_1): Likewise.
 955         * target.h (target_async_permitted): Likewise.
 956         (may_write_registers): Likewise.
 957         (may_write_memory): Likewise.
 958         (may_insert_breakpoints): Likewise.
 959         (may_insert_tracepoints): Likewise.
 960         (may_insert_fast_tracepoints): Likewise.
 961         (may_stop): Likewise.
 962         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 963         (make_thread_apply_all_options_def_group): Change argument from int*
 964         to bool*.
 965         (thread_apply_all_command): Update.
 966         (print_thread_events): Change to bool.
 967         * top.c (confirm): Likewise.
 968         (command_editing_p): Likewise.
 969         (history_expansion_p): Likewise.
 970         (write_history_p): Likewise.
 971         (info_verbose): Likewise.
 972         * top.h (confirm): Likewise.
 973         (history_expansion_p): Likewise.
 974         * tracepoint.c (disconnected_tracing): Likewise.
 975         (circular_trace_buffer): Likewise.
 976         * typeprint.c (print_methods): Likewise.
 977         (print_typedefs): Likewise.
 978         * utils.c (debug_timestamp): Likewise.
 979         (sevenbit_strings): Likewise.
 980         (pagination_enabled): Likewise.
 981         * utils.h (sevenbit_strings): Likewise.
 982         (pagination_enabled): Likewise.
 983         * valops.c (overload_resolution): Likewise.
 984         * valprint.h (struct value_print_options) <prettyformat_arrays,
 985         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 986         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 987         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 988         Likewise.
 989         * windows-nat.c (new_console): Likewise.
 990         (cygwin_exceptions): Likewise.
 991         (new_group): Likewise.
 992         (debug_exec): Likewise.
 993         (debug_events): Likewise.
 994         (debug_memory): Likewise.
 995         (debug_exceptions): Likewise.
 996         (useshell): Likewise.
 997         * windows-tdep.c (maint_display_all_tib): Likewise.
 998         * xml-support.c (debug_xml): Likewise.
 999
1000 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1001
1002         * source.c (prepare_path_for_appending): New function.
1003         (openp): Make use of new function.
1004         (find_and_open_source): Search for the compilation directory and
1005         source file as a relative path beneath the directory search path.
1006
1007 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1008
1009         * source-cache.c (source_cache::get_line_charpos): Catch
1010         exceptions and return false, this matches the behaviour documented
1011         in the header file.
1012
1013 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1014
1015         * ada-tasks.c (info_task): Remove quoting of the task's name.
1016
1017 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1018
1019         * symfile.c (auto_solib_add): Replace comment with a reference
1020         to the header file.
1021
1022 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1023
1024         * NEWS: Mention that gdb can now be compiled with Python 3
1025         on Windows.
1026
1027 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1028
1029         * maint.c (maint_print_section_data::maint_print_section_data):
1030         Force use of 'float log10 (float)' by casting the argument to
1031         float.
1032
1033 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1034
1035         * maint.c: Add 'cmath' include.
1036         (struct maint_print_section_data): New structure.
1037         (print_section_index): New function.
1038         (print_bfd_section_info): Add header comment, small whitespace
1039         cleanup, and update to call new print_section_index function.
1040         (print_objfile_section_info): Likewise.
1041         (maint_obj_section_from_bfd_section): New function.
1042         (print_bfd_section_info_maybe_relocated): New function.
1043         (maintenance_info_sections): Add header comment, always use
1044         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1045
1046 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1047
1048         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1049         inner scope, add check that the objfile has psymtabs before
1050         checking psymtabs_addrmap.
1051         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1052
1053 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1054
1055         * NEWS: Announce that Ada task names are now shown at more places,
1056         and between quotes (except in info task output).
1057         * gdb/ada-tasks.c (task_to_str): New function.
1058         (display_current_task_id): Call task_to_str.
1059         (task_command_1): Likewise.
1060         (print_ada_task_info): In non-mi mode, Properly align headers and data
1061         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1062
1063 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1064
1065         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1066         prstatus.pr_lwp.pr_info instead of making it up.
1067
1068 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1069
1070         * auto-load.c (auto_load_expand_dir_vars): Update.
1071         * defs.h (gdb_datadir): Change to std::string.
1072         (python_libdir): Likewise.
1073         (relocate_gdb_directory): Change return type to std::string.
1074         * guile/guile.c (gdbscm_data_directory): Update.
1075         (initialize_scheme_side): Update.
1076         * jit.c (jit_reader_dir): Change to std::string.
1077         (jit_reader_load_command): Update.
1078         * main.c (gdb_datadir): Change to std::string.
1079         (python_libdir): Likewise.
1080         (set_gdb_data_directory): Update.
1081         (relocate_path): Change to return std::string.
1082         (relocate_gdb_directory): Change to return std::string.
1083         (relocate_gdbinit_path_maybe_in_datadir): Update.
1084         (captured_main_1): Update.
1085         * python/python.c (do_start_initialization): Update.
1086         * top.c (show_gdb_datadir): Update.
1087         * xml-syscall.c (xml_init_syscalls_info): Update.
1088         (init_syscalls_info): Update.
1089
1090 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1091
1092         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1093         out of get_init_files.
1094         (get_init_files): Update.
1095
1096 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1097
1098         * main.c (get_init_files): Change to use std::string.
1099         (captured_main_1): Update.
1100         (print_gdb_help): Update.
1101
1102 2019-09-11  Ali Tamur  <tamur@google.com>
1103
1104         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1105         implementation.
1106
1107 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1108
1109         * dbxread.c (read_dbx_symtab): Update.
1110         * dwarf2read.c (load_partial_dies): Update.
1111         * mdebugread.c (parse_partial_symbols): Update.
1112         (handle_psymbol_enumerators): Update.
1113         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1114         * psymtab.c (add_psymbol_to_bcache): Likewise.
1115         (add_psymbol_to_list): Likewise.
1116         * symtab.c (symbol_set_names): Likewise.
1117         * symtab.h (symbol_set_names): Likewise.
1118         * xcoffread.c (scan_xcoff_symtab): Update.
1119
1120 2019-09-11  Tom Tromey  <tom@tromey.com>
1121
1122         * symfile-mem.c (symbol_file_add_from_memory): Use
1123         bfd_set_filename.
1124         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1125         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1126
1127 2019-09-10  Tom Tromey  <tromey@adacore.com>
1128
1129         * dwarf-index-write.c (write_psymbols): Extend error message.
1130         (debug_names::insert): Add Ada code.
1131         (debug_names::write_psymbols): Remove Ada check.
1132         (debug_names) <m_string_obstack>: New member.
1133         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1134         (gdb_index_symbol_name_matcher::matches): Remove.
1135         (mapped_index_base::find_name_components_bounds): Add "lang"
1136         parameter.
1137         (mapped_index_base::build_name_components): Also split names
1138         according to Ada syntax.
1139         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1140         type of "match_callback".
1141         (check_match, check_find_bounds_finds)
1142         (dw2_expand_symtabs_matching): Update.
1143         (dw2_debug_names_iterator): Add new constructor.
1144         (dw2_debug_names_map_matching_symbols): New function.
1145         (dw2_debug_names_expand_symtabs_matching): Update.
1146         (dwarf2_debug_names_functions): Use
1147         dw2_debug_names_map_matching_symbols.
1148
1149 2019-09-10  Tom Tromey  <tromey@adacore.com>
1150
1151         * dwarf2read.c (dw2_get_file_names_reader): Add the
1152         CU's file name to the results.
1153
1154 2019-09-10  Tom Tromey  <tromey@adacore.com>
1155
1156         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1157         map_matching_symbols.  Update.
1158         * dwarf2read.c (dw2_map_matching_symbols): Update.
1159         * psymtab.c (match_partial_symbol): Change type; update.
1160         (psym_map_matching_symbols): Likewise.
1161         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1162         type; update.
1163         * symfile.h (struct quick_symbol_functions)
1164         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1165         Remove "match".
1166
1167 2019-09-10  Tom Tromey  <tromey@adacore.com>
1168
1169         * psymtab.c (map_block): Remove.
1170         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1171         * symtab.c (iterate_over_symbols_terminated): New function.
1172         * symtab.c (iterate_over_symbols_terminated): Declare.
1173
1174 2019-09-10  Tom Tromey  <tromey@adacore.com>
1175
1176         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1177         * language.h (struct language_defn) <la_iterate_over_symbols>:
1178         Return bool.
1179         * symtab.c (iterate_over_symbols): Return bool.
1180         * symtab.h (iterate_over_symbols): Return bool.
1181
1182 2019-09-10  Tom Tromey  <tromey@adacore.com>
1183
1184         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1185         (add_nonlocal_symbols): Update.
1186         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1187         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1188         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1189         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1190         Change type of "callback".  Remove "data".
1191
1192
1193 2019-09-09  Ali Tamur  <tamur@google.com>
1194
1195         * dwarf2read.c (comp_unit_head): Update comment.
1196         (dwarf2_dwo_name): New function declaration.
1197         (dwarf_unit_type_name): New function declaration.
1198         (read_comp_unit_head): Add support for new compilation units,
1199         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1200         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1201         (currently named as "signature") in their header. Also clarify error
1202         messages.
1203         (lookup_dwo_id): New function. Returns the dwo id of the given
1204         compile unit.
1205         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1206         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1207         functions.
1208         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1209         (dwarf2_dwo_name): Get the dwo name if present.
1210         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1211         purposes.
1212
1213 2019-09-09  Tom Tromey  <tom@tromey.com>
1214
1215         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1216
1217 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1218
1219         * python/python.c (do_start_initialization): Make progname_copy static,
1220         to avoid a leak report.
1221
1222 2019-09-08  Tom Tromey  <tom@tromey.com>
1223
1224         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1225
1226 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1227
1228         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1229         Change type to gdb::optional<block_enum>.
1230         (dw2_symtab_iter_init): Change block_index parameter type
1231         to gdb::optional<block_enum>.
1232         (dw2_lookup_symbol): Change block_index parameter
1233         type to block_enum.c
1234         (dw2_debug_names_lookup_symbol): Likewise.
1235         * psymtab.c (psym_lookup_symbol): Likewise.
1236         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1237         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1238         Likewise.
1239
1240 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1241
1242         * defs.h (relocate_gdb_directory): Change int to bool in
1243         signature and rename flag to relocatable.
1244         * main.c (relocate_path): Likewise.
1245         (relocate_gdb_directory): Likewise.
1246
1247 2019-09-06  Alan Modra  <amodra@gmail.com>
1248
1249         * coffread.c (coff_symfile_read): Constify filename variable.
1250         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1251         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1252         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1253         * solib.c (reload_shared_libraries_1): Likewise.
1254         * symfile.c (reread_symbols): Likewise.
1255         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1256         * solib-darwin.c (darwin_bfd_open): Likewise.
1257         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1258
1259 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1260
1261         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1262         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1263
1264 2019-09-03  Tom Tromey  <tromey@adacore.com>
1265
1266         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1267         types.
1268         (has_negatives): Unbias a range type bound.
1269         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1270         * gdbtypes.c (operator==): Handle new field.
1271         (create_range_type): Add "bias" parameter.
1272         (create_static_range_type, resolve_dynamic_range): Update.
1273         * gdbtypes.h (struct range_bounds) <bias>: New member.
1274         (create_range_type): Add bias parameter.
1275         * printcmd.c (print_scalar_formatted): Unbias range types.
1276         * value.c (unpack_long): Unbias range types.
1277         (pack_long): Bias range types.
1278
1279 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1280
1281         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1282         probe arguments.
1283
1284 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1285
1286         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1287         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1288         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1289         (compile_probe_arg): Likewise.
1290         * probe.h (get_argument_count): Likewise.
1291         * solib-svr4.c (solib_event_probe_action): Likewise.
1292         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1293
1294 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1295
1296         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1297         code to here...
1298         (svr4_create_solib_event_breakpoints): ...from here.
1299
1300 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1301
1302         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1303         suffix from warning message.
1304
1305 2019-08-30  Tom Tromey  <tom@tromey.com>
1306
1307         * tui/tui-winsource.h (struct tui_source_window_base)
1308         <refresh_all>: Don't declare.
1309         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1310         Remove.
1311         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1312         tui_show_locator_content.
1313         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1314         declare.
1315         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1316         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1317         declare.
1318
1319 2019-08-30  Tom Tromey  <tom@tromey.com>
1320
1321         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1322
1323 2019-08-30  Tom Tromey  <tom@tromey.com>
1324
1325         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1326         Remove unnecessary forward declarations.
1327
1328 2019-08-30  Tom Tromey  <tom@tromey.com>
1329
1330         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1331         rerender.
1332         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1333         tui_show_locator_content.
1334
1335 2019-08-30  Tom Tromey  <tom@tromey.com>
1336
1337         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1338         (tui_locator_window::rerender): Rewrite using body of previous
1339         tui_show_locator_content.
1340
1341 2019-08-30  Tom Tromey  <tom@tromey.com>
1342
1343         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1344         set_locator_fullname>: New methods.
1345         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1346         Rename from tui_set_locator_fullname.
1347         (tui_locator_window::set_locator_info): Rename from
1348         tui_set_locator_info.  Return bool.
1349         (tui_update_locator_fullname, tui_show_frame_info): Update.
1350
1351 2019-08-30  Tom Tromey  <tom@tromey.com>
1352
1353         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1354
1355 2019-08-30  Tom Tromey  <tom@tromey.com>
1356
1357         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1358         call touchwin.
1359
1360 2019-08-30  Tom Tromey  <tom@tromey.com>
1361
1362         * tui/tui-wingeneral.c (box_win): Assume win_info and
1363         win_info->handle cannot be NULL.
1364
1365 2019-08-30  Tom Tromey  <tom@tromey.com>
1366
1367         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1368         refresh_window>: Declare.
1369         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1370         resize.
1371         (tui_data_item_window::rerender): Rename from
1372         tui_display_register.
1373         (tui_data_item_window::refresh_window): New method.
1374         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1375         no-op.
1376
1377 2019-08-30  Tom Tromey  <tom@tromey.com>
1378
1379         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1380         regs_column_count, current_group>: Move later.  Now private.
1381         <get_current_group>: New method.
1382         * tui/tui-regs.c (tui_reg_command): Update.
1383         * tui/tui-layout.c (tui_set_layout): Update.
1384
1385 2019-08-30  Tom Tromey  <tom@tromey.com>
1386
1387         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1388         (tui_data_window::rerender): Don't call
1389         check_and_display_highlight_if_needed.
1390         (tui_data_window::refresh_all): Remove call to
1391         erase_data_content.
1392
1393 2019-08-30  Tom Tromey  <tom@tromey.com>
1394
1395         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1396         (tui_data_window::display_registers_from)
1397         (tui_data_window::display_reg_element_at_line)
1398         (tui_data_window::display_registers_from_line): Remove checks of
1399         "empty".
1400
1401 2019-08-30  Tom Tromey  <tom@tromey.com>
1402
1403         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1404         Don't declare.
1405         * tui/tui-regs.c (tui_data_window::show_registers): Call
1406         rerender.
1407         (tui_data_window::rerender): Rename from display_all_data.
1408         (tui_data_window::rerender): Remove old implementation.
1409
1410 2019-08-30  Tom Tromey  <tom@tromey.com>
1411
1412         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1413         text.
1414         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1415
1416 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1417             Sergio Durigan Junior  <sergiodj@redhat.com>
1418
1419         PR win32/24284
1420         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1421
1422 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1423
1424         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1425         when searching for types.
1426
1427 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1428
1429         * f-lang.c (f_language_defn): Use f_print_typedef.
1430         * f-lang.h (f_print_typedef): Declare.
1431         * f-typeprint.c (f_print_typedef): Define.
1432
1433 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1434
1435         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1436
1437 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1438
1439         * cli/cli-utils.c (info_print_options_defs): Delete.
1440         (make_info_print_options_def_group): Delete.
1441         (extract_info_print_options): Delete.
1442         (info_print_command_completer): Delete.
1443         (info_print_args_help): Add extra parameter, and optionally
1444         include text about -n flag.
1445         * cli/cli-utils.h (struct info_print_options): Delete.
1446         (extract_info_print_options): Delete declaration.
1447         (info_print_command_completer): Delete declaration.
1448         (info_print_args_help): Add extra parameter, extend header
1449         comment.
1450         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1451         search_symbols.
1452         * stack.c (struct info_print_options): New type.
1453         (info_print_options_defs): New file scoped variable.
1454         (make_info_print_options_def_group): New static function.
1455         (info_print_command_completer): New static function.
1456         (info_locals_command): Update to use new local functions.
1457         (info_args_command): Likewise.
1458         (_initialize_stack): Add extra parameter to calls to
1459         info_print_args_help.
1460         * symtab.c (search_symbols): Add extra parameter, use this to
1461         possibly excluse non-debug symbols.
1462         (symtab_symbol_info): Add extra parameter, which is passed on to
1463         search_symbols.
1464         (struct info_print_options): New type.
1465         (info_print_options_defs): New file scoped variable.
1466         (make_info_print_options_def_group): New static function.
1467         (info_print_command_completer): New static function.
1468         (info_variables_command): Update to use local functions, and pass
1469         extra parameter through to symtab_symbol_info.
1470         (info_functions_command): Likewise.
1471         (info_types_command): Pass additional argument through to
1472         symtab_symbol_info.
1473         (rbreak_command): Pass extra argument to search_symbols.
1474         (_initialize_symtab): Add extra arguments for calls to
1475         info_print_args_help, and update help text for 'info variables',
1476         'whereis', and 'info functions' commands.
1477         * symtab.h (search_symbols): Add extra argument to declaration.
1478         * NEWS: Mention new flags.
1479
1480 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1481
1482         * symtab.c (lookup_static_symbol): Call the new function (and move
1483         it down to be next to lookup_global_symbol).
1484         (struct global_sym_lookup_data): Add block_enum member and rename to...
1485         (struct global_or_static_sym_lookup_data): ...this.
1486         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1487         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1488         (lookup_symbol_global_or_static_iterator_cb): ...this.
1489         (lookup_global_or_static_symbol): New function.
1490         (lookup_global_symbol): Call new function.
1491
1492 2019-08-26  Tom de Vries  <tdevries@suse.de>
1493
1494         PR c++/24852
1495         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1496         when pc_probe.prob == NULL.
1497
1498 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1499
1500         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1501         variable symbol_linkage to symbol_linkage_.
1502
1503 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1504
1505         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1506         represent whether the symbol is static, dynamic, or we don't
1507         know.
1508
1509 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1510
1511         * gdb/rx-tdep.c (rx_register_names): New.
1512         (rx_register_name): Delete.
1513         (rx_psw_type): Delete.
1514         (rx_fpsw_type): Delete.
1515         (rx_register_type): Delete.
1516         (rx_gdbarch_init): Convert target-descriptions.
1517         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1518         * gdb/features/Makefile: Add rx.xml.
1519         * gdb/features/rx.xml: New.
1520         * gdb/features/rx.c: Generated.
1521         * gdb/NEWS: Mention target description support.
1522
1523 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1524
1525         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1526         *slot_ptr.
1527
1528 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1529
1530         * configure.ac: Don't check for 'dlfcn.h' (moved to
1531         gdbsupport/common.m4).
1532         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1533         'gdbsupport/'.
1534         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1535         * compile/compile-c-support.c: Include
1536         'gdbsupport/gdb-dlfcn.h'.
1537         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1538         * gdb-dlfcn.c: Move to...
1539         * gdbsupport/gdb-dlfcn.c: ... here.
1540         * gdb-dlfcn.h: Move to...
1541         * gdbsupport/gdb-dlfcn.h: ... here.
1542
1543 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1544
1545         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1546         the offset field signed.
1547
1548 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1549
1550         * python/lib/gdb/__init__.py (_execute_file): New function.
1551         * python/python.c (python_run_simple_file): Call gdb._execute_file
1552         on Windows.
1553
1554 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1555
1556         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1557         all uses as this was never set to anything but a zero value.
1558
1559 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1560
1561         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1562
1563 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1564
1565         * tui/tui-data.h (tui_gen_win_info): Add an =default
1566         move constructor, required by some GCC versions.
1567
1568 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1569
1570         * go32-nat.c (go32_sysinfo): Add hygon_p.
1571
1572 2019-08-20  Tom Tromey  <tom@tromey.com>
1573
1574         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1575         line_from_reg_element_no, first_reg_element_no_inline,
1576         display_all_data, delete_data_content_windows,
1577         erase_data_content>: Now private.
1578
1579 2019-08-20  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1582         (tui_unhighlight_win, tui_highlight_win)
1583         (tui_win_info::make_window): Update.
1584         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1585
1586 2019-08-20  Tom Tromey  <tom@tromey.com>
1587
1588         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1589         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1590         (MAX_PID_WIDTH): Move to tui-stack.c.
1591         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1592         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1593         (MAX_PID_WIDTH): Move from tui-data.h.
1594
1595 2019-08-20  Tom Tromey  <tom@tromey.com>
1596
1597         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1598         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1599         (box_win): Update.
1600         (tui_gen_win_info::make_window): Rename from tui_make_window.
1601         (tui_win_info::make_window): New method.
1602         (tui_gen_win_info::make_visible): Update.
1603         * tui/tui-source.c (tui_source_window::set_contents): Update.
1604         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1605         (tui_data_window::display_registers_from): Update.
1606         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1607         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1608         Declare.
1609         <can_box>: Remove.
1610         <title>: Remove.
1611         (struct tui_win_info) <make_window>: Declare.
1612         <can_box>: Now virtual.
1613         <title>: New member.
1614         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1615         * tui/tui-command.c (tui_cmd_window::resize): Update.
1616
1617 2019-08-20  Tom Tromey  <tom@tromey.com>
1618
1619         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1620         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1621         (tui_data_window::check_register_values): Update.
1622
1623 2019-08-20  Tom Tromey  <tom@tromey.com>
1624
1625         * tui/tui-regs.h (struct tui_data_window): Use
1626         DISABLE_COPY_AND_ASSIGN.
1627         <regs_content>: Change type, removing unique_ptr.
1628         <tui_data_window>: Add move constructor.
1629         * tui/tui-regs.c (tui_data_window::show_registers)
1630         (tui_data_window::show_register_group)
1631         (tui_data_window::display_registers_from)
1632         (tui_data_window::display_registers_from)
1633         (tui_data_window::first_data_item_displayed)
1634         (tui_data_window::delete_data_content_windows)
1635         (tui_data_window::rerender, tui_data_window::refresh_window)
1636         (tui_data_window::check_register_values): Update.
1637
1638 2019-08-20  Tom Tromey  <tom@tromey.com>
1639
1640         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1641         show_register_group>: Declare.
1642         (tui_show_register_group): Don't declare.
1643         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1644         tui_show_registers.
1645         (tui_data_window::show_register_group): Rename from
1646         tui_show_register_group.
1647         (tui_data_window::check_register_values, tui_reg_command):
1648         Update.
1649         * tui/tui-layout.c (tui_set_layout): Update.
1650
1651 2019-08-20  Tom Tromey  <tom@tromey.com>
1652
1653         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1654         Declare.
1655         (tui_check_register_values): Don't declare.
1656         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1657         from tui_check_register_values.
1658         * tui/tui-hooks.c (tui_register_changed): Update.
1659
1660 2019-08-20  Tom Tromey  <tom@tromey.com>
1661
1662         * tui/tui-regs.c (tui_reg_layout): Move later.
1663         (tui_show_registers): Don't enable TUI mode or change layout.
1664
1665 2019-08-20  Tom Tromey  <tom@tromey.com>
1666
1667         * tui/tui-regs.h (struct tui_data_item_window)
1668         <~tui_data_item_window>: Remove.
1669         <content>: Now a unique_xmalloc_ptr.
1670         * tui/tui-regs.c (tui_register_format): Return a
1671         unique_xmalloc_ptr.
1672         (tui_get_register): Update.
1673         (~tui_data_item_window): Remove.
1674         (tui_data_window::display_registers_from, tui_display_register):
1675         Update.
1676         * tui/tui-io.h (tui_expand_tabs): Update.
1677         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1678         Remove "col" parameter.
1679
1680 2019-08-20  Tom Tromey  <tom@tromey.com>
1681
1682         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1683         field.
1684         * tui/tui-regs.c (~tui_data_item_window): Update.
1685
1686 2019-08-20  Tom Tromey  <tom@tromey.com>
1687
1688         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1689         earlier.
1690
1691 2019-08-20  Tom Tromey  <tom@tromey.com>
1692
1693         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1694
1695 2019-08-20  Tom Tromey  <tom@tromey.com>
1696
1697         * tui/tui-source.h (struct tui_source_window): Update.
1698         * tui/tui-regs.c (tui_show_registers): Update.
1699         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1700         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1701         (NO_REGS_STRING): Remove defines.
1702
1703 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1704
1705         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1706         unnecessary thread walk if remote doesn't support the packet.
1707
1708 2019-08-19  Tom Tromey  <tromey@adacore.com>
1709
1710         * python/py-value.c (value_has_field): Fix indentation.
1711
1712 2019-08-19  Tom Tromey  <tromey@adacore.com>
1713
1714         * printcmd.c (do_one_display, info_display_command): Update.
1715         * block.h (contained_in): Return bool.  Add allow_nested
1716         parameter.
1717         * block.c (contained_in): Return bool.  Add allow_nested
1718         parameter.
1719
1720 2019-08-19  Tom Tromey  <tom@tromey.com>
1721
1722         * configure: Rebuild.
1723         * configure.ac: Disallow the combination of -static-libstdc++ and
1724         source highlight.
1725         * source-cache.c (get_language_name): Handle rust.
1726         (source_cache::get_source_lines): Ignore highlighting exceptions.
1727
1728 2019-08-16  Tom Tromey  <tom@tromey.com>
1729
1730         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1731         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1732         (struct tui_source_window_base) <make_visible, refresh_window,
1733         resize>: Remove methods.
1734         <execution_info>: Remove field.
1735         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1736         (tui_show_source_line, tui_source_window_base)
1737         (~tui_source_window_base): Update.
1738         (tui_source_window_base::resize)
1739         (tui_source_window_base::make_visible)
1740         (tui_source_window_base::refresh_window): Remove.
1741         (tui_source_window_base::update_exec_info): Update.
1742         * tui/tui-source.c (tui_source_window::set_contents): Update.
1743         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1744
1745 2019-08-16  Tom Tromey  <tom@tromey.com>
1746
1747         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1748         deprecated_query_hook.
1749
1750 2019-08-16  Tom Tromey  <tom@tromey.com>
1751
1752         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1753         (tui_update_source_windows_with_line): Update.
1754         * tui/tui-source.h (struct tui_source_window)
1755         <show_symtab_source>: Declare.
1756         (tui_show_symtab_source): Don't declare.
1757         * tui/tui-source.c (tui_show_symtab_source): Rename from
1758         tui_show_symtab_source.
1759
1760 2019-08-16  Tom Tromey  <tom@tromey.com>
1761
1762         * tui/tui-winsource.h (struct tui_source_window_base)
1763         <set_contents>: Declare.
1764         * tui/tui-winsource.c
1765         (tui_source_window_base::update_source_window_as_is): Update.
1766         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1767         Declare.
1768         (tui_set_source_content): Don't declare.
1769         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1770         tui_set_source_content.
1771         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1772         Declare.
1773         (tui_set_disassem_content): Don't declare.
1774         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1775         tui_set_disassem_content.
1776
1777 2019-08-16  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-winsource.h (struct tui_source_window_base)
1780         <update_breakpoint_info>: Declare.
1781         (tui_update_breakpoint_info): Don't declare.
1782         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1783         (tui_update_all_breakpoint_info): Update.
1784         (tui_source_window_base::update_breakpoint_info): Rename from
1785         tui_update_breakpoint_info.
1786         (tui_source_window_base::update_exec_info): Update.
1787
1788 2019-08-16  Tom Tromey  <tom@tromey.com>
1789
1790         * tui/tui-winsource.h (struct tui_source_window_base)
1791         <update_source_window>: Declare.
1792         (tui_update_source_window): Don't declare.
1793         * tui/tui-winsource.c
1794         (tui_source_window_base::update_source_window): Rename from
1795         tui_update_source_window.
1796         (tui_source_window_base::rerender): Update.
1797         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1798         * tui/tui-disasm.c (tui_show_disassem)
1799         (tui_show_disassem_and_update_source)
1800         (tui_disasm_window::maybe_update): Update.
1801
1802 2019-08-16  Tom Tromey  <tom@tromey.com>
1803
1804         * tui/tui-winsource.h (struct tui_source_window_base)
1805         <update_source_window_as_is>: Declare.
1806         (tui_update_source_window_as_is): Don't declare.
1807         * tui/tui-winsource.c (tui_update_source_window): Update
1808         (tui_source_window_base::update_source_window_as_is): Rename from
1809         tui_update_source_window_as_is.
1810         (tui_source_window_base::refill): Update.
1811         * tui/tui-source.c (tui_show_symtab_source): Update.
1812         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1813         Update.
1814
1815 2019-08-16  Tom Tromey  <tom@tromey.com>
1816
1817         * tui/tui-winsource.h (tui_update_source_window)
1818         (tui_update_source_window_as_is): Remove "noerror" parameter.
1819         * tui/tui-winsource.c (tui_update_source_window)
1820         (tui_update_source_window_as_is): Remove "noerror" parameter.
1821         (tui_update_source_windows_with_addr)
1822         (tui_update_source_windows_with_line)
1823         (tui_source_window_base::rerender)
1824         (tui_source_window_base::refill): Update.
1825         * tui/tui-source.h (tui_set_source_content)
1826         (tui_show_symtab_source): Remove "noerror" parameter.
1827         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1828         parameter.
1829         (tui_show_symtab_source): Likewise.
1830         (tui_source_window::maybe_update): Update.
1831         * tui/tui-disasm.c (tui_show_disassem)
1832         (tui_show_disassem_and_update_source)
1833         (tui_disasm_window::do_scroll_vertical)
1834         (tui_disasm_window::maybe_update): Update.
1835
1836 2019-08-16  Tom Tromey  <tom@tromey.com>
1837
1838         * tui/tui.c (tui_is_window_visible): Update.
1839         * tui/tui-wingeneral.c (tui_make_window)
1840         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1841         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1842         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1843         (tui_set_win_height_command, parse_scrolling_args): Update.
1844         * tui/tui-source.c (tui_source_window::style_changed): Update.
1845         * tui/tui-regs.c (tui_show_registers)
1846         (tui_data_window::first_data_item_displayed)
1847         (tui_data_window::delete_data_content_windows)
1848         (tui_check_register_values, tui_reg_command): Update.
1849         * tui/tui-disasm.c (tui_show_disassem): Update.
1850         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1851         method.
1852         <is_visible>: Remove field.
1853         * tui/tui-data.c (tui_next_win, tui_prev_win)
1854         (tui_delete_invisible_windows): Update.
1855
1856 2019-08-16  Tom Tromey  <tom@tromey.com>
1857
1858         * tui/tui-winsource.h (struct tui_source_window_base)
1859         <m_has_locator>: Remove.
1860         * tui/tui-layout.c (show_source_disasm_command, show_data)
1861         (show_source_or_disasm_and_command): Update.
1862
1863 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1864
1865         * NEWS (Other MI changes): New subsection.
1866         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1867         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1868         * arch-utils.c (default_get_pc_address_flags): New function.
1869         * arch-utils.h (default_get_pc_address_flags): New declaration.
1870         * gdbarch.sh: Add get_pc_address_flags.
1871         * gdbarch.c: Regenerate.
1872         * gdbarch.h: Likewise.
1873         * stack.c (print_pc): New function.
1874         (print_frame_info) (print_frame): Call print_pc.
1875
1876 2019-08-16  Tom de Vries  <tdevries@suse.de>
1877
1878         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1879         print_objfile_section_info.
1880
1881 2019-08-15  Tom Tromey  <tom@tromey.com>
1882
1883         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1884         calling update_cmdwin_start_line.
1885         * tui/tui-winsource.h (struct tui_source_window_base)
1886         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1887         <rerender>: Declare.
1888         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1889         Call rerender.
1890         (tui_source_window_base::set_new_height): Remove.
1891         (tui_source_window_base::rerender): Rename from
1892         do_make_visible_with_new_height.
1893         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1894         resize method.
1895         (tui_win_info::make_invisible_and_set_new_height)
1896         (tui_win_info::make_visible_with_new_height): Remove.
1897         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1898         Declare.
1899         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1900         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1901         do_make_visible_with_new_height>: Don't declare.
1902         <rerender>: Declare.
1903         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1904         set_new_height.
1905         (tui_data_window::do_make_visible_with_new_height): Remove.
1906         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1907         call tui_show_locator_content.
1908         (tui_gen_win_info::resize): Call rerender.
1909         (show_source_or_disasm_and_command): Don't call
1910         tui_show_locator_content.
1911         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1912         method.
1913         (struct tui_win_info) <rerender>: Declare.
1914         <set_new_height, make_invisible_and_set_new_height,
1915         make_visible_with_new_height>: Don't declare.
1916         * tui/tui-data.c (tui_win_list::rerender): New method.
1917         * tui/tui-command.h (struct tui_cmd_window)
1918         <do_make_visible_with_new_height>: Don't declare.
1919         * tui/tui-command.c
1920         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1921
1922 2019-08-15  Tom Tromey  <tromey@adacore.com>
1923
1924         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1925         * ada-lang.c (ada_enum_name): Likewise.
1926
1927 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1928
1929         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1930         leading underscore.
1931         (GdbOutputErrorFile): Likewise.
1932         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1933         accordingly.
1934         (execute_unwinders): Rename to have a leading underscore.
1935         (auto_load_packages): Likewise.
1936         (global scope): Adjust call to auto_load_packages accordingly.
1937         (GdbSetPythonDirectory): Likewise.
1938         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1939         instead of execute_unwinders.
1940
1941 2019-08-15  Tom Tromey  <tom@tromey.com>
1942
1943         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1944         (show_data): Don't change window visibility.
1945         (tui_gen_win_info::resize): Remove special case for command
1946         window.  Use wresize, when available.
1947         (show_source_or_disasm_and_command): Don't change window
1948         visibility.
1949         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1950         <make_visible>: New method.
1951         * tui/tui-command.c (tui_cmd_window::resize): New method.
1952
1953 2019-08-15  Tom Tromey  <tom@tromey.com>
1954
1955         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1956         (struct tui_source_windows): New.
1957         * tui/tui-winsource.c (tui_display_main): Update.
1958         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1959         (new_height_ok, parse_scrolling_args): Update.
1960         * tui/tui-layout.c (show_layout, show_data): Update.
1961         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1962         (tui_add_to_source_windows): Don't declare.
1963         * tui/tui-data.c (source_windows, tui_source_windows)
1964         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1965
1966 2019-08-15  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1969         Rename from reset.
1970         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1971         * tui/tui-layout.c (show_source_disasm_command, show_data):
1972         Update.
1973         (tui_gen_win_info::resize): Rename.
1974         (show_source_or_disasm_and_command): Update.
1975         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1976         reset.
1977
1978 2019-08-15  Tom Tromey  <tom@tromey.com>
1979
1980         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1981         * tui/tui-interp.c (tui_interp::init): Don't call
1982         tui_initialize_static_data.
1983         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1984
1985 2019-08-15  Tom Tromey  <tom@tromey.com>
1986
1987         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1988         examine tui_win_list.
1989
1990 2019-08-15  Tom Tromey  <tom@tromey.com>
1991
1992         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1993         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1994         tui_clear_source_content.
1995         (tui_clear_source_content): Remove.
1996         (tui_source_window_base::do_erase_source_content): Hoist call to
1997         content.clear().
1998         * tui/tui-stack.c (tui_show_frame_info): Don't call
1999         tui_clear_source_content.
2000
2001 2019-08-15  Tom Tromey  <tom@tromey.com>
2002
2003         * tui/tui-winsource.h (struct tui_source_window_base)
2004         <do_erase_source_content>: New method.
2005         <erase_source_content>: New method.
2006         (tui_erase_source_content): Don't declare.
2007         * tui/tui-winsource.c (tui_clear_source_content): Update.
2008         (tui_source_window_base::do_erase_source_content): Rename from
2009         tui_erase_source_content.
2010         (tui_source_window_base::show_source_content): Update.
2011         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2012         * tui/tui-source.h (struct tui_source_window)
2013         <erase_source_content>: New method.
2014         * tui/tui-disasm.h (struct tui_disasm_window)
2015         <erase_source_content>: New method.
2016
2017 2019-08-15  Tom Tromey  <tom@tromey.com>
2018
2019         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2020         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2021         constructor.
2022         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2023         * tui/tui-source.c (tui_set_source_content): Update.
2024         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2025
2026 2019-08-15  Tom Tromey  <tom@tromey.com>
2027
2028         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2029         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2030         tui-source.c.
2031         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2032         Declare.
2033         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2034         method.
2035         (tui_source_window::maybe_update): Update.
2036
2037 2019-08-15  Tom Tromey  <tom@tromey.com>
2038
2039         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2040         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2041         tui-disasm.c.
2042         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2043         Declare.
2044         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2045         method.
2046         (tui_disasm_window::maybe_update): Update.
2047
2048 2019-08-15  Tom Tromey  <tom@tromey.com>
2049
2050         * tui/tui-winsource.h (struct tui_source_window_base)
2051         <maybe_update>: Declare.
2052         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2053         method.
2054         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2055         Declare.
2056         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2057         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2058         Declare.
2059         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2060
2061 2019-08-15  Tom Tromey  <tom@tromey.com>
2062
2063         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2064
2065 2019-08-15  Tom Tromey  <tom@tromey.com>
2066
2067         * tui/tui-wingeneral.c: Include tui-stack.h.
2068         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2069         (struct tui_locator_window): Move from tui-data.h.
2070         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2071         (tui_initialize_static_data): Move from tui-data.c.
2072         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2073         (struct tui_locator_window): Move to tui-stack.c.
2074         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2075         (tui_initialize_static_data): Move to tui-stack.c.
2076
2077 2019-08-15  Tom Tromey  <tom@tromey.com>
2078
2079         * tui/tui-layout.c (show_source_disasm_command)
2080         (show_source_or_disasm_and_command): Use make_visible method, not
2081         tui_make_window.
2082         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2083         Remove.
2084
2085 2019-08-15  Tom Tromey  <tom@tromey.com>
2086
2087         * tui/tui-wingeneral.h (tui_make_window): Update.
2088         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2089         parameter.
2090         (tui_gen_win_info::make_visible): Update.
2091         * tui/tui-regs.c (tui_data_window::display_registers_from):
2092         Update.
2093         * tui/tui-layout.c (show_source_disasm_command)
2094         (show_source_or_disasm_and_command): Update.
2095         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2096         (enum tui_box): Remove.
2097         (struct tui_win_info) <can_box>: New method.
2098         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2099         method.
2100
2101 2019-08-15  Tom de Vries  <tdevries@suse.de>
2102
2103         * linux-nat-trad.c: Include gdbarch.h.
2104
2105 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2106
2107         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2108         register sizes.
2109
2110 2019-08-14  Tom Tromey  <tromey@adacore.com>
2111
2112         * darwin-nat.c: Include gdbarch.h.
2113         * darwin-nat-info.c: Include gdbarch.h.
2114
2115 2019-08-13  Tom Tromey  <tom@tromey.com>
2116
2117         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2118         Remove.
2119         * tui/tui-data.c (tui_initialize_static_data): Update.
2120
2121 2019-08-13  Tom Tromey  <tom@tromey.com>
2122
2123         * tui/tui-winsource.h (struct tui_exec_info_window)
2124         <~tui_exec_info_window, maybe_allocate_content, get_content,
2125         m_content>: Remove.
2126         (struct tui_source_window_base) <set_exec_info_content,
2127         show_exec_info_content>: Don't declare.
2128         * tui/tui-winsource.c
2129         (tui_exec_info_window::maybe_allocate_content): Remove.
2130         (tui_source_window_base::update_exec_info): Rename from
2131         set_exec_info_content.
2132         (tui_source_window_base::show_exec_info_content)
2133         (tui_source_window_base::update_exec_info): Remove.
2134
2135 2019-08-13  Tom Tromey  <tom@tromey.com>
2136
2137         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2138         declare.
2139         * tui/tui-winsource.c (tui_update_source_window_as_is)
2140         (tui_update_source_windows_with_addr, tui_erase_source_content):
2141         Update.
2142         (tui_clear_exec_info_content): Remove.
2143
2144 2019-08-13  Tom Tromey  <tom@tromey.com>
2145
2146         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2147         declare.
2148         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2149         call tui_erase_exec_info_content.
2150         (tui_clear_exec_info_content): Rename from
2151         tui_erase_exec_info_content.
2152         (tui_clear_exec_info_content): Delete.
2153
2154 2019-08-13  Tom Tromey  <tom@tromey.com>
2155
2156         * tui/tui-winsource.h (struct tui_source_window_base)
2157         <show_exec_info_content>: Declare.
2158         (tui_show_exec_info_content): Don't declare.
2159         * tui/tui-winsource.c
2160         (tui_source_window_base::show_exec_info_content): Rename from
2161         tui_show_exec_info_content.
2162         (tui_source_window_base::update_exec_info): Update.
2163
2164 2019-08-13  Tom Tromey  <tom@tromey.com>
2165
2166         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2167         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2168         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2169         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2170         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2171         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2172         ... here.
2173
2174 2019-08-13  Tom Tromey  <tom@tromey.com>
2175
2176         * tui/tui-winsource.h (struct tui_source_window_base)
2177         <update_exec_info>: Declare.
2178         (tui_update_exec_info): Don't declare.
2179         * tui/tui-winsource.c (tui_update_source_window_as_is)
2180         (tui_source_window_base::refresh_all)
2181         (tui_update_all_breakpoint_info): Update.
2182         (tui_source_window_base::update_exec_info): Rename from
2183         tui_update_exec_info.
2184         * tui/tui-stack.c (tui_show_frame_info): Update.
2185
2186 2019-08-13  Tom Tromey  <tom@tromey.com>
2187
2188         * tui/tui-winsource.h (struct tui_source_window_base)
2189         <set_exec_info_content>: Declare.
2190         (tui_set_exec_info_content): Don't declare.
2191         * tui/tui-winsource.c
2192         (tui_source_window_base::set_exec_info_content): Rename from
2193         tui_set_exec_info_content.
2194         (tui_update_exec_info): Update.
2195
2196 2019-08-13  Tom Tromey  <tom@tromey.com>
2197
2198         * tui/tui-winsource.h (struct tui_source_window_base)
2199         <show_source_content>: Declare.
2200         (tui_show_source_content): Don't declare.
2201         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2202         (tui_source_window_base::show_source_content): Rename from
2203         tui_show_source_content.
2204         (tui_source_window_base::refresh_all): Update.
2205         * tui/tui-layout.c (show_source_disasm_command)
2206         (show_source_or_disasm_and_command): Update.
2207
2208 2019-08-13  Tom Tromey  <tom@tromey.com>
2209
2210         * tui/tui-winsource.c (tui_erase_source_content)
2211         (tui_show_source_content, tui_source_window_base::refresh_all):
2212         Update.
2213         * tui/tui-wingeneral.h
2214         (tui_check_and_display_highlight_if_needed): Don't declare.
2215         * tui/tui-wingeneral.c
2216         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2217         check_and_display_highlight_if_needed.
2218         * tui/tui-win.c (tui_rehighlight_all)
2219         (tui_win_info::make_visible_with_new_height): Update.
2220         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2221         (tui_data_window::erase_data_content)
2222         (tui_data_window::display_all_data): Update.
2223         * tui/tui-data.h (struct tui_win_info)
2224         <check_and_display_highlight_if_needed>: Declare.
2225
2226 2019-08-13  Tom Tromey  <tom@tromey.com>
2227
2228         * tui/tui-win.c (tui_resize_all): Call
2229         tui_delete_invisible_windows.
2230         * tui/tui-layout.c (show_layout): Call
2231         tui_delete_invisible_windows.
2232         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2233         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2234
2235 2019-08-13  Tom Tromey  <tom@tromey.com>
2236
2237         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2238         tui_add_win_to_layout.
2239
2240 2019-08-13  Tom Tromey  <tom@tromey.com>
2241
2242         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2243         * tui/tui-layout.c (tui_default_win_height): Now static.
2244
2245 2019-08-13  Tom Tromey  <tom@tromey.com>
2246
2247         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2248         single switch.
2249         (show_source_disasm_command, show_source_or_disasm_and_command):
2250         Don't check current layout.
2251
2252 2019-08-13  Tom Tromey  <tom@tromey.com>
2253
2254         * tui/tui-wingeneral.c (make_all_visible): Remove.
2255         (tui_make_all_invisible): Simplify.
2256         * tui/tui-layout.c (tui_make_all_invisible): Move from
2257         tui-wingeneral.c; simplify.
2258         (show_layout): Hoist call to tui_make_all_invisible.
2259         (show_data): Don't call tui_make_all_invisible.
2260
2261 2019-08-13  Tom Tromey  <tom@tromey.com>
2262
2263         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2264         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2265
2266 2019-08-13  Tom Tromey  <tom@tromey.com>
2267
2268         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2269         tui-data.c.
2270         (show_source_disasm_command, show_data)
2271         (show_source_or_disasm_and_command): Don't use
2272         tui_set_current_layout_to.
2273         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2274         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2275         tui-layout.c.
2276         (tui_set_current_layout_to): Remove.
2277
2278 2019-08-13  Tom Tromey  <tom@tromey.com>
2279
2280         * tui/tui-layout.c (tui_set_layout): Update.
2281         * tui/tui-data.h (struct tui_layout_def): Remove.
2282         (tui_layout_def): Don't declare.
2283         * tui/tui-data.c (layout_def): Remove.
2284         (tui_layout_def): Remove.
2285
2286 2019-08-13  Tom Tromey  <tom@tromey.com>
2287
2288         * tui/tui-winsource.h (struct tui_source_window_base)
2289         <clear_detail>: No longer "override".
2290         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2291         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2292         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2293         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2294         Remove.
2295         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2296
2297 2019-08-13  Tom Tromey  <tromey@adacore.com>
2298
2299         * tracepoint.c: Don't include readline.h or history.h.
2300
2301 2019-08-12  Tom Tromey  <tom@tromey.com>
2302
2303         * configure: Rebuild.
2304         * configure.ac: Check for readline 7.
2305         * NEWS: Mention readline 7 requirement.
2306         * README: Update.
2307
2308 2019-08-12  Tom Tromey  <tom@tromey.com>
2309
2310         * mingw-hdep.c (gdb_select): Remove readline hack.
2311
2312 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2313
2314         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2315         when the function fails.
2316
2317 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2318
2319         * s390-tdep.c (s390_type_align): New function.
2320         (s390_gdbarch_init): Set it as type_align gdbarch method.
2321
2322 2019-08-09  Tom de Vries  <tdevries@suse.de>
2323
2324         PR gdb/24591
2325         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2326         pc_low with relocation offset.
2327
2328 2019-08-07  Tom Tromey  <tromey@adacore.com>
2329
2330         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2331         (print_frame_args): Update.
2332         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2333         Update.
2334         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2335         * frame.h (struct frame_arg): Add initializers.
2336         <error>: Now a unique_xmalloc_ptr.
2337
2338 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2339
2340         * NEWS: Expand the Pointer Authentication entry.
2341         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2342         (aarch64_frame_unmask_lr): ... to this.
2343         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2344         Call aarch64_frame_unmask_lr.
2345         * frame.c (struct frame_info): Add "masked" variable.
2346         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2347         (fprint_frame): Check for masked pc.
2348         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2349         declarations.
2350         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2351         * stack.c (print_frame): Check for masked pc.
2352
2353 2019-08-06  Tom Tromey  <tom@tromey.com>
2354
2355         * stabsread.c (patch_block_stabs, read_one_struct_field)
2356         (read_enum_type): Use obstack_strndup.
2357         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2358         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2359         * dwarf2read.c (guess_full_die_structure_name)
2360         (anonymous_struct_prefix): Use obstack_strndup.
2361         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2362         * c-exp.y (yylex): Use obstack_strndup.
2363         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2364         (write_var_or_type): Use obstack_strndup.
2365
2366 2019-08-06  Tom Tromey  <tom@tromey.com>
2367
2368         * symfile.c (reread_symbols): Use obstack_strdup.
2369         * stabsread.c (read_type): Use obstack_strdup.
2370         * gdb_obstack.h (obstack_strdup): New overload.
2371         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2372         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2373         (dwarf2_canonicalize_name): Use obstack_strdup.
2374         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2375         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2376         Use obstack_strdup.
2377
2378 2019-08-06  Tom Tromey  <tom@tromey.com>
2379
2380         * gdb_obstack.h (obstack_strdup): Define.
2381         * gdb_obstack.c (obstack_strdup): Don't define.
2382
2383 2019-08-06  Tom Tromey  <tom@tromey.com>
2384
2385         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2386         obstack_strdup.
2387         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2388         obstack_strdup.
2389         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2390         * stabsread.c (common_block_start): Use obstack_strdup.
2391         * objfiles.c (set_objfile_main_name, objfile): Use
2392         obstack_strdup.
2393         * namespace.c (add_using_directive): Use obstack_strdup.
2394         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2395         * jit.c (finalize_symtab): Use obstack_strdup.
2396         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2397         (guess_partial_die_structure_name, partial_die_info::fixup)
2398         (dwarf2_name): Use obstack_strdup.
2399         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2400         obstack_strdup.
2401         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2402         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2403         obstack_strdup.
2404         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2405
2406 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2407
2408         * unittests/help-doc-selftests.c: New file.
2409         * Makefile.in: Add the new file.
2410
2411 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2412
2413         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2414         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2415         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2416         the trailing '.' is not output, and the first character is uppercased.
2417         (print_help_for_command): Update call to print_doc_line.
2418         (print_doc_of_command): Likewise.
2419         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2420         * cli/cli-option.c (append_indented_doc): Do not append newline.
2421         (build_help_option): Append newline after first appended_indented_doc
2422         only if a second call is done.
2423         (build_help): Append 2 new lines before each option, except the first
2424         one.
2425         * compile/compile.c (_initialize_compile): Add new lines after
2426         %OPTIONS%, when not at the end of the help.
2427         Change help doc or code
2428         producing the help doc to respect the invariants.
2429         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2430         Also removed the new line after 'Options:', as all other commands
2431         do not put an empty line between 'Options:' and the first option.
2432         * printcmd.c (_initialize_printcmd): Likewise.
2433         * stack.c (_initialize_stack): Likewise.
2434         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2435         incorrectly telling COMMAND is optional.
2436         * ada-lang.c (_initialize_ada_language): Change help doc or code
2437         producing the help doc to respect the invariants.
2438         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2439         * breakpoint.c (_initialize_breakpoint): Likewise.
2440         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2441         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2442         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2443         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2444         _initialize_cli_style): Likewise.
2445         * corelow.c (core_target_info): Likewise.
2446         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2447         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2448         * filesystem.c (_initialize_filesystem): Likewise.
2449         * frame.c (_initialize_frame): Likewise.
2450         * gnu-nat.c (add_task_commands): Likewise.
2451         * infcall.c (_initialize_infcall): Likewise.
2452         * infcmd.c (_initialize_infcmd): Likewise.
2453         * interps.c (_initialize_interpreter): Likewise.
2454         * language.c (_initialize_language): Likewise.
2455         * linux-fork.c (_initialize_linux_fork): Likewise.
2456         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2457         * maint.c (_initialize_maint_cmds): Likewise.
2458         * memattr.c (_initialize_mem): Likewise.
2459         * printcmd.c (_initialize_printcmd): Likewise.
2460         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2461         _RegEx): Likewise.
2462         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2463         * record-btrace.c (_initialize_record_btrace): Likewise.
2464         * record-full.c (_initialize_record_full): Likewise.
2465         * record.c (_initialize_record): Likewise.
2466         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2467         * regcache.c (_initialize_regcache): Likewise.
2468         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2469         _initialize_remote): Likewise.
2470         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2471         * serial.c (_initialize_serial): Likewise.
2472         * skip.c (_initialize_step_skip): Likewise.
2473         * source.c (_initialize_source): Likewise.
2474         * stack.c (_initialize_stack): Likewise.
2475         * symfile.c (_initialize_symfile): Likewise.
2476         * symtab.c (_initialize_symtab): Likewise.
2477         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2478         * top.c (init_main): Likewise.
2479         * tracefile-tfile.c (tfile_target_info): Likewise.
2480         * tracepoint.c (_initialize_tracepoint): Likewise.
2481         * tui/tui-win.c (_initialize_tui_win): Likewise.
2482         * utils.c (add_internal_problem_command): Likewise.
2483         * valprint.c (value_print_option_defs): Likewise.
2484
2485 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2486
2487         PR build/24886
2488         * configure.ac: Drop enable-libmcheck support.
2489         * configure, config.in: Rebuild.
2490         * libmcheck.m4: Remove.
2491         * acinclude.m4: Don't include it.
2492         * Makefile.in: Don't distribute it.
2493         * top.c (print_gdb_configuration): Don't mention it.
2494
2495 2019-08-06  Tom Tromey  <tom@tromey.com>
2496
2497         * utils.c (set_output_style): Sometimes pass stream to
2498         emit_style_escape.
2499         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2500         * record-btrace.c (btrace_insn_history): Update.
2501         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2502         method.
2503         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2504         Update initializers.
2505         <m_uiout>: New field.
2506         <m_di>: Move lower.
2507         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2508         Remove "uiout" parameter.
2509         (dump_insns): Update.
2510         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2511         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2512
2513 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2514
2515         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2516         (error_in_psymtab_expansion): Likewise.
2517         (lookup_symbol_via_quick_fns): Likewise.
2518         (basic_lookup_transparent_type_quick): Likewise.
2519         (basic_lookup_transparent_type_1): Likewise.
2520
2521 2019-08-06  Tom Tromey  <tromey@adacore.com>
2522
2523         * source.c (last_source_error): Now bool.
2524         (print_source_lines_base): Make "noprint" bool.  Only open
2525         source file when last_source_visited changes.
2526
2527 2019-08-06  Tom Tromey  <tromey@adacore.com>
2528
2529         * annotate.c (annotate_source_line): Use g_source_cache.
2530         * source-cache.c (source_cache::get_plain_source_lines): Change
2531         parameters.  Populate m_offset_cache.
2532         (source_cache::ensure): New method.
2533         (source_cache::get_line_charpos): New method.
2534         (extract_lines): Move lower.  Change parameters.
2535         (source_cache::get_source_lines): Move lower.
2536         * source-cache.h (class source_cache): Update comment.
2537         <get_line_charpos>: New method.
2538         <get_source_lines>: Update comment.
2539         <clear>: Clear m_offset_cache.
2540         <get_plain_source_lines>: Change parameters.
2541         <ensure>: New method
2542         <m_offset_cache>: New member.
2543         * source.c (forget_cached_source_info_for_objfile): Update.
2544         (info_source_command): Use g_source_cache.
2545         (find_source_lines, open_source_file_with_line_charpos): Remove.
2546         (print_source_lines_base, search_command_helper): Use g_source_cache.
2547         * source.h (open_source_file_with_line_charpos): Don't declare.
2548         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2549         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2550         Use g_source_cache.
2551
2552 2019-08-06  Tom Tromey  <tromey@adacore.com>
2553
2554         * source-cache.c (source_cache::get_plain_source_lines):
2555         Remove "first_line" and "last_line" parameters.
2556         (source_cache::get_source_lines): Cache plain text.
2557         * source-cache.h (class source_cache)
2558         <get_plain_source_lines>: Update.
2559
2560 2019-08-06  Tom Tromey  <tromey@adacore.com>
2561
2562         * source-cache.c (extract_lines): No longer a method.
2563         Changed type of parameter.  Include final newline.
2564         (selftests::extract_lines_test): New function.
2565         (_initialize_source_cache): Likewise.
2566         * source-cache.h (class source_cache)
2567         <extract_lines>: Don't declare.
2568
2569 2019-08-06  Tom Tromey  <tromey@adacore.com>
2570
2571         * breakpoint.c (init_breakpoint_sal): Update.
2572         (breakpoint): Update.
2573         * breakpoint.h (struct breakpoint) <filter>: Now a
2574         unique_xmalloc_ptr.
2575
2576 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2577
2578         * NEWS: Mention dictionary access on blocks.
2579         * python/py-block.c (blpy_getitem): New function.
2580         (block_object_as_mapping): New struct.
2581         (block_object_type): Use new struct for tp_as_mapping field.
2582
2583 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2584
2585         * objfiles.h (objfile): Add a comment describing partial symbols.
2586
2587 2019-08-05  Tom Tromey  <tromey@adacore.com>
2588
2589         * compile/compile.c (_initialize_compile): Use _(), not N_().
2590         * thread.c (_initialize_thread): Use _(), not N_().
2591         * stack.c (_initialize_stack): Use _(), not N_().
2592         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2593
2594 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2595
2596         * dwarf2read.c (struct dw2_symtab_iterator):
2597         <want_specific_block>: Remove.
2598         <block_index>: Change type to gdb::optional.
2599         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2600         change type of BLOCK_INDEX parameter to gdb::optional.
2601         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2602         (dw2_lookup_symbol): Don't pass argument for
2603         WANT_SPECIFIC_BLOCK.
2604         (dw2_expand_symtabs_for_function): Don't pass argument for
2605         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2606         (class dw2_debug_names_iterator)
2607         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2608         parameter, change BLOCK_INDEX type to gdb::optional.
2609         <m_want_specific_block>: Remove.
2610         <m_block_index>: Change type to gdb::optional.
2611         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2612         gdb::optional.  Re-write in function of gdb::optional.
2613         (dw2_debug_names_lookup_symbol): Don't pass argument for
2614         WANT_SPECIFIC_BLOCK.
2615         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2616         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2617         BLOCK_INDEX.
2618
2619 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2620
2621         * NEWS: Mention changes to "info sources" command.
2622
2623 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2624
2625         * symtab.c (filename_partial_match_opts): New struct type.
2626         (struct output_source_filename_data): New members
2627         regexp, c_regexp, partial_match.
2628         (output_source_filename): Use new members to decide to print file.
2629         (info_sources_option_defs): New variable.
2630         (make_info_sources_options_def_group, print_info_sources_header,
2631         info_sources_command_completer):
2632         New functions.
2633         (info_sources_command): Read new optional arguments.
2634         (_initialize_symtab): Update info sources help.
2635
2636 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2637
2638         * ada-lang.c (exception_support_info_v0): Renamed from...
2639         (default_exception_support_info): ... this.  Create new
2640         definition for v1.
2641         (ada_has_this_exception_support): Look up catch_handlers_sym.
2642         (ada_exception_support_info_sniffer): Try v0 after default.
2643
2644 2019-08-01  Tom Tromey  <tromey@adacore.com>
2645
2646         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2647         gdbarch.h.
2648
2649 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2650
2651         * s12z-tdep.c: Fix include path for s12z-opc.h.
2652
2653 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2654
2655         * NEWS: Require GNU make 3.82.
2656
2657 2019-07-16  Tom Tromey  <tom@tromey.com>
2658
2659         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2660         declare.
2661
2662 2019-07-30  Tom Tromey  <tromey@adacore.com>
2663
2664         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2665
2666 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2667
2668         * printcmd.c (print_address_symbolic): Print negative offsets.
2669         (build_address_symbolic): Force signed arithmetic when computing
2670         offset.
2671
2672 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2673
2674         PR/24474: Add a function to lookup static variables.
2675         * NEWS: Mention this new function.
2676         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2677         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2678         * python/python.c (python_GdbMethods): Add new function.
2679
2680 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2681
2682         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2683         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2684         (objfpy_lookup_static_symbol): New function.
2685         (objfile_object_methods): Add new functions.
2686
2687 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2688
2689         * NEWS: Mention 'set|show print frame-info'.  Mention new
2690         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2691         backtrace argument.  Mention that python frame filtering code
2692         is now consistent with what 'backtrace' command prints.
2693
2694 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2695
2696         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2697         comments.
2698         (print_frame_info_auto, print_frame_info_source_line,
2699         print_frame_info_location, print_frame_info_source_and_location,
2700         print_frame_info_location_and_address, print_frame_info_short_location):
2701         New declarations.
2702         (struct frame_print_options): New member print_frame_info.
2703         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2704         * stack.h (get_user_print_what_frame_info): New declaration.
2705         (frame_show_address): New declaration.
2706         * stack.c (print_frame_arguments_choices): New value 'presence'.
2707         (print_frame_info_auto, print_frame_info_source_line,
2708         print_frame_info_location, print_frame_info_source_and_location,
2709         print_frame_info_location_and_address, print_frame_info_short_location,
2710         print_frame_info_choices, print_frame_info_print_what): New definitions.
2711         (print_frame_args): Only print dots for args if print frame-arguments
2712         is 'presence'.
2713         (frame_print_option_defs): New element for "frame-info".
2714         (get_user_print_what_frame_info): New function.
2715         (frame_show_address): Make non static.  Move comment to stack.h.
2716         (print_frame_info_to_print_what): New function.
2717         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2718         to decide what to print.
2719         (backtrace_command_1): Handle the new print_frame_arguments_presence
2720         value.
2721         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2722         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2723         (py_print_frame): In non-mi mode, use LOCATION as default for
2724         print_what, similarly to frame information printed directly by
2725         backtrace command. Handle frame-info user option in non MI mode.
2726
2727 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2728
2729         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2730         Add case for debugging 32-bit target on 64-bit host.  Revise
2731         comment.
2732
2733 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2734
2735         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2736         instead of find_function_entry_range_from_pc.
2737
2738 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2739
2740         * stack.c (find_frame_funname): Remove code which preferred
2741         minsym over symtab sym in "certain pathological cases".
2742
2743         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2744         parameter.  Change type of "do_demangle" to bool.
2745         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2746         Pass suitable "prefer_sym_over_minsym" flag to
2747         build_address_symbolic().  Don't output "+" for negative offsets.
2748         * printcmd.c (print_address_symbolic): Update invocation of
2749         build_address_symbolic to include a "prefer_sym_over_minsym"
2750         flag.
2751         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2752         Restrict cases in which use of minimal symbol is preferred to that
2753         of a found symbol.  Update comments.
2754
2755         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2756         for entry pc when entry pc is out of range for that FDE.
2757
2758 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2759
2760         PR gdb/24839:
2761         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2762         type.
2763
2764 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2765
2766         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2767         this function's Python signature.
2768
2769
2770 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2771
2772         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2773         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2774         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2775         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2776         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2777
2778
2779 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2780
2781         * h8300-tdep.c (h8300_register_name_common): New.
2782         h8300_register_name): Use h8300_register_name_common.
2783         (h8300s_register_name): Likewise.
2784         (h8300sx_register_name): Likewise.
2785         (h8300h_register_nam): New.
2786         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2787
2788
2789 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2790
2791         * arm-tdep.c (arm_skip_cmse_entry): New function.
2792         (arm_is_sgstubs_section): New function.
2793         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2794
2795 2019-07-22  Tom Tromey  <tom@tromey.com>
2796
2797         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2798         Don't self-assign.
2799
2800 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2801
2802         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2803         type_print.
2804
2805 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2806
2807         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2808         so that GDB doesn't match any msymbols when searching in the
2809         TYPES_DOMAIN.
2810         (print_symbol_info): Print using typedef_print or type_print based
2811         on the type of the symbol.  Add updated FIXME comment moved from...
2812         (_initialize_symtab): ... move and update FIXME comment to above.
2813
2814 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2815
2816         * NEWS: Mention adding -q option to "info types".
2817         * symtab.c (struct info_types_options): New struct.
2818         (info_types_options_defs): New variable.
2819         (make_info_types_options_def_group): New function.
2820         (info_types_command): Use gdb::option framework to parse options.
2821         (info_types_command_completer): New function.
2822         (_initialize_symtab): Extend the help text on "info types" and
2823         register command completer.
2824
2825 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2826
2827         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2828         (lookup_symbol_in_objfile): Change int to block_enum and add a
2829         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2830
2831 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2832
2833         * MAINTAINERS (Write After Approval): Add self.
2834
2835 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2836
2837         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2838         instruction to the dummy code region.
2839
2840 2019-07-19  Tom Tromey  <tromey@adacore.com>
2841
2842         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2843         (ARGSUSED, PARAMS, __func__): Remove rules.
2844
2845 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2846
2847         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2848         * features/arm/arm-with-iwmmxt.c: Remove.
2849         * features/arm/arm-with-iwmmxt.xml: Remove.
2850         * features/arm/arm-with-m-fpa-layout.c: Remove.
2851         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2852         * features/arm/arm-with-m-vfp-d16.c: Remove.
2853         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2854         * features/arm/arm-with-m.c: Remove.
2855         * features/arm/arm-with-m.xml: Remove.
2856         * features/arm/arm-with-neon.c: Remove.
2857         * features/arm/arm-with-neon.xml: Remove.
2858         * features/arm/arm-with-vfpv2.c: Remove.
2859         * features/arm/arm-with-vfpv2.xml: Remove.
2860         * features/arm/arm-with-vfpv3.c: Remove.
2861         * features/arm/arm-with-vfpv3.xml: Remove.
2862
2863 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2864
2865         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2866
2867 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2868
2869         * arch/aarch32.c (aarch32_create_target_description): Create
2870         target descriptions using features.
2871         * arch/arm.c (arm_create_target_description)
2872         (arm_create_mprofile_target_description): Likewise.
2873         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2874
2875 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2876
2877         * Makefile.in: Add new files.
2878         * aarch32-tdep.c: New file.
2879         * aarch32-tdep.h: New file.
2880         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2881         Call aarch32_read_description.
2882         * arch/aarch32.c: New file.
2883         * arch/aarch32.h: New file.
2884         * arch/arm.c (arm_create_target_description)
2885         (arm_create_mprofile_target_description): New function.
2886         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2887         (arm_create_target_description)
2888         (arm_create_mprofile_target_description): New declaration.
2889         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2890         read_description functions.
2891         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2892         Likewise.
2893         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2894         * arm-tdep.c (tdesc_arm_list): New variable.
2895         (arm_register_g_packet_guesses): Call create description functions.
2896         (arm_read_description) (arm_read_mprofile_description): New
2897         function.
2898         * arm-tdep.h (arm_read_description)
2899         (arm_read_mprofile_description): Add declaration.
2900         * configure.tgt: Add new files.
2901
2902 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2903
2904         * top.c (new_ui_command): Open specified terminal just once.
2905
2906 2019-07-18  Tom Tromey  <tromey@adacore.com>
2907
2908         * symtab.c (main_name): Constify return type.
2909         * symfile.c (set_initial_language): Update.
2910         * symtab.h (main_name): Constify return type.
2911
2912 2019-07-17  Tom Tromey  <tom@tromey.com>
2913
2914         * tui/tui-winsource.c (tui_update_source_window)
2915         (tui_update_source_window_as_is)
2916         (tui_update_source_windows_with_line): Remove return.
2917         * tui/tui-disasm.c (tui_show_disassem)
2918         (tui_show_disassem_and_update_source): Remove return.
2919         * tui/tui.c (tui_reset): Remove return.
2920         * tui/tui-wingeneral.c
2921         (tui_check_and_display_highlight_if_needed): Remove return.
2922
2923 2019-07-17  Tom Tromey  <tom@tromey.com>
2924
2925         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2926
2927 2019-07-17  Tom Tromey  <tom@tromey.com>
2928
2929         * tui/tui-winsource.h (struct tui_exec_info_window)
2930         (struct tui_source_window_base): Move from tui-data.h.
2931         * tui/tui-winsource.c: Move many method definitions from
2932         elsewhere.  Remove "structuring" comments.
2933         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2934         (tui_source_window_base::refresh_window): Move to
2935         tui-winsource.c.
2936         * tui/tui-win.c (tui_source_window_base::refresh_all)
2937         (tui_source_window_base::update_tab_width)
2938         (tui_source_window_base::set_new_height)
2939         (tui_source_window_base::do_make_visible_with_new_height): Move to
2940         tui-winsource.c.
2941         * tui/tui-source.h: Update.
2942         * tui/tui-source.c (tui_source_window_base::reset): Move to
2943         tui-winsource.c.
2944         * tui/tui-disasm.h: Update.
2945         * tui/tui-data.h (struct tui_exec_info_window): Move to
2946         tui-winsource.h.
2947         (struct tui_source_window_base): Likewise.
2948         * tui/tui-data.c (tui_source_window_base::clear_detail)
2949         (tui_source_window_base, ~tui_source_window_base): Move to
2950         tui-winsource.c.
2951
2952 2019-07-17  Tom Tromey  <tom@tromey.com>
2953
2954         * tui/tui-win.c (tui_resize_all)
2955         (tui_source_window_base::update_tab_width)
2956         (tui_adjust_win_heights): Update.
2957         (tui_win_info::make_invisible_and_set_new_height): Rename from
2958         make_invisible_and_set_new_height.
2959         * tui/tui-data.h (struct tui_win_info)
2960         <make_invisible_and_set_new_height>: New method.
2961
2962 2019-07-17  Tom Tromey  <tom@tromey.com>
2963
2964         * tui/tui.c: Update.
2965         * tui/tui-source.h (struct tui_source_window): Move from
2966         tui-data.h.
2967         * tui/tui-layout.c: Update.
2968         * tui/tui-disasm.c: Update.
2969         * tui/tui-data.h (struct tui_source_window): Move to
2970         tui-source.h.
2971
2972 2019-07-17  Tom Tromey  <tom@tromey.com>
2973
2974         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2975         tui-data.h.
2976         * tui/tui-data.h (struct tui_disasm_window): Move to
2977         tui-disasm.h.
2978
2979 2019-07-17  Tom Tromey  <tom@tromey.com>
2980
2981         * tui/tui-regs.h (struct tui_data_item_window): Move from
2982         tui-data.h.
2983         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2984         * tui/tui-data.h (struct tui_data_item_window): Move to
2985         tui-regs.h.
2986         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2987
2988 2019-07-17  Tom Tromey  <tom@tromey.com>
2989
2990         * tui/tui.c: Update.
2991         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2992         (tui_cmd_window::max_height): Move to tui-command.c.
2993         * tui/tui-layout.c: Update.
2994         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2995         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2996         tui-command.c.
2997         * tui/tui-command.h (struct tui_cmd_window): Move from
2998         tui-data.h.
2999         * tui/tui-command.c: Remove "structuring" comments.
3000         (tui_cmd_window::clear_detail)
3001         (tui_cmd_window::do_make_visible_with_new_height)
3002         (tui_cmd_window::max_height): Move from elsewhere.
3003
3004 2019-07-17  Tom Tromey  <tom@tromey.com>
3005
3006         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3007         Now static.
3008         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3009         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3010
3011 2019-07-17  Tom Tromey  <tom@tromey.com>
3012
3013         * tui/tui.c: Update.
3014         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3015         tui-regs.c.
3016         * tui/tui-windata.h: Remove file.
3017         * tui/tui-windata.c: Remove file.
3018         * tui/tui-win.c (tui_data_window::set_new_height)
3019         (tui_data_window::do_make_visible_with_new_height): Move to
3020         tui-regs.c.
3021         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3022         * tui/tui-regs.c: Remove "structuring" comments.
3023         (tui_data_window::first_data_item_displayed)
3024         (tui_data_window::delete_data_content_windows)
3025         (tui_data_window::erase_data_content)
3026         (tui_data_window::display_all_data)
3027         (tui_data_window::refresh_all)
3028         (tui_data_window::do_scroll_vertical)
3029         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3030         (tui_data_window::do_make_visible_with_new_height)
3031         (tui_data_window::refresh_window): Move from elsewhere.
3032         (_initialize_tui_regs): Move to end of file.
3033         * tui/tui-layout.c: Update.
3034         * tui/tui-hooks.c: Update.
3035         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3036         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3037         tui-regs.c.
3038         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3039
3040 2019-07-17  Tom Tromey  <tom@tromey.com>
3041
3042         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3043         seen.
3044
3045 2019-07-17  Tom Tromey  <tom@tromey.com>
3046
3047         * tui/tui-win.c (tui_source_window_base::set_new_height)
3048         (tui_source_window_base::do_make_visible_with_new_height): Use
3049         m_has_locator field directly.
3050         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3051         method.
3052         (struct tui_source_window_base) <has_locator>: Likewise.
3053
3054 2019-07-17  Tom Tromey  <tom@tromey.com>
3055
3056         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3057         Don't declare.
3058         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3059         Remove.
3060         * tui/tui-win.c (tui_source_window_base::set_new_height)
3061         (tui_source_window_base::set_new_height)
3062         (make_invisible_and_set_new_height)
3063         (tui_source_window_base::do_make_visible_with_new_height)
3064         (tui_source_window_base::do_make_visible_with_new_height):
3065         Update.
3066         * tui/tui-layout.c (show_source_disasm_command, show_data)
3067         (show_source_or_disasm_and_command): Update.
3068         * tui/tui-layout.c (show_layout): Update.
3069
3070 2019-07-17  Tom Tromey  <tom@tromey.com>
3071
3072         * tui/tui-layout.c (make_data_window): Remove.
3073         (show_data): Unify creation and re-initialization cases.
3074
3075 2019-07-17  Tom Tromey  <tom@tromey.com>
3076
3077         * tui/tui-layout.c (make_source_window, make_disasm_window):
3078         Remove.
3079         (show_data): Unify creation and re-initialization cases.
3080
3081 2019-07-17  Tom Tromey  <tom@tromey.com>
3082
3083         * tui/tui-layout.c (make_command_window): Remove.
3084         (show_source_disasm_command, show_source_or_disasm_and_command):
3085         Unify creation and re-initialization cases.
3086
3087 2019-07-17  Tom Tromey  <tom@tromey.com>
3088
3089         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3090         creation and re-initialization cases.
3091
3092 2019-07-17  Tom Tromey  <tom@tromey.com>
3093
3094         * tui/tui-regs.c (tui_get_register): Return void.
3095
3096 2019-07-17  Tom Tromey  <tom@tromey.com>
3097
3098         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3099         Simplify.
3100
3101 2019-07-17  Tom Tromey  <tom@tromey.com>
3102
3103         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3104         resetting.
3105
3106 2019-07-17  Tom Tromey  <tom@tromey.com>
3107
3108         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3109         * tui/tui-regs.c (tui_reg_layout): New function.
3110         (tui_show_registers, tui_reg_command): Use it.
3111         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3112         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3113         parameters.
3114         (tui_layout_command): Remove.
3115
3116 2019-07-17  Tom Tromey  <tom@tromey.com>
3117
3118         * tui/tui-layout.h (tui/tui-layout): Return void.
3119         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3120
3121 2019-07-17  Tom Tromey  <tom@tromey.com>
3122
3123         * tui/tui-layout.c (show_source_disasm_command, show_data):
3124         Update.
3125         (reset_locator): Remove.
3126         (show_source_or_disasm_and_command): Update.
3127
3128 2019-07-17  Tom Tromey  <tom@tromey.com>
3129
3130         * tui/tui-source.c (tui_source_window_base::reset): Remove
3131         win_type parameter.
3132         * tui/tui-layout.c (make_command_window, make_source_window)
3133         (make_disasm_window, make_data_window)
3134         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3135         (reset_locator, show_source_or_disasm_and_command): Update.
3136         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3137         win_type parameter.
3138         (struct tui_source_window_base) <reset>: Likewise.
3139
3140 2019-07-17  Tom Tromey  <tom@tromey.com>
3141
3142         * tui/tui-layout.c (show_source_disasm_command): Use
3143         reset_locator.
3144         (reset_locator): New function.
3145         (init_and_make_win): Remove.
3146         (show_source_or_disasm_and_command): Use reset_locator.
3147
3148 2019-07-17  Tom Tromey  <tom@tromey.com>
3149
3150         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3151         condition.
3152         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3153         Remove condition.
3154         * tui/tui-source.c (tui_source_window_base::reset): New method.
3155         * tui/tui-layout.c (make_command_window): Don't call
3156         init_and_make_win.
3157         (make_source_window, make_disasm_window): Don't call
3158         make_source_or_disasm_window.
3159         (make_data_window): Don't call init_and_make_win.  Change calling
3160         convention.
3161         (show_source_disasm_command, show_data): Simplify.
3162         (make_source_or_disasm_window): Remove.
3163         (show_source_or_disasm_and_command): Simplify.
3164         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3165         (struct tui_source_window_base) <reset>: Likewise.
3166         <execution_info>: Remove initializer.
3167         * tui/tui-data.c (tui_source_window_base): Initialize
3168         execution_info.
3169
3170 2019-07-17  Tom Tromey  <tom@tromey.com>
3171
3172         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3173         variable.
3174
3175 2019-07-17  Tom Tromey  <tom@tromey.com>
3176
3177         * tui/tui.c (tui_rl_other_window): Update.
3178         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3179         superclass method first.  Always iterate over regs_content.
3180         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3181         method.
3182         * tui/tui-win.c (tui_set_focus_command): Update.
3183
3184 2019-07-17  Tom Tromey  <tom@tromey.com>
3185
3186         * tui/tui-win.c (tui_set_focus_command): Rename from
3187         tui_set_focus.  Call tui_enable.
3188         (tui_set_focus_command): Remove.
3189
3190 2019-07-17  Tom Tromey  <tom@tromey.com>
3191
3192         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3193         refresh_window.
3194         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3195         touchwin.
3196         (tui_data_window::refresh_window): Call refresh_window on data
3197         items.  Always call superclass refresh_window.
3198         (tui_win_info::refresh): Remove.
3199         (tui_source_window_base::refresh_window): Update.
3200         (tui_refresh_all): Update.
3201         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3202         refresh_window.
3203         (show_source_or_disasm_and_command): Likewise.
3204         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3205         (struct tui_source_window_base) <refresh>: Likewise.
3206
3207 2019-07-17  Tom Tromey  <tom@tromey.com>
3208
3209         * tui/tui-winsource.c (tui_clear_source_content)
3210         (tui_show_source_content): Update.
3211         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3212         whether content is empty.
3213         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3214         Remove.
3215
3216 2019-07-17  Tom Tromey  <tom@tromey.com>
3217
3218         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3219         window's contents.
3220         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3221         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3222
3223 2019-07-17  Tom Tromey  <tom@tromey.com>
3224
3225         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3226         (struct tui_data_item_window): Update.
3227
3228 2019-07-17  Tom Tromey  <tom@tromey.com>
3229
3230         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3231         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3232         defines.
3233
3234 2019-07-17  Tom Tromey  <tom@tromey.com>
3235
3236         * tui/tui-winsource.h (tui_erase_source_content)
3237         (tui_clear_source_content): Remove "display_prompt" parameter.
3238         * tui/tui-winsource.c (tui_update_source_window_as_is)
3239         (tui_update_source_windows_with_addr): Update.
3240         (tui_clear_source_content): Remove "display_prompt" parameter.
3241         (tui_erase_source_content): Likewise.  Simplify.
3242         (tui_show_source_content): Update.
3243         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3244         * tui/tui-stack.c (tui_show_frame_info): Update.
3245         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3246         Remove defines.
3247
3248 2019-07-17  Tom Tromey  <tom@tromey.com>
3249
3250         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3251         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3252         parameter.
3253         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3254         parameter.
3255
3256 2019-07-17  Tom Tromey  <tom@tromey.com>
3257
3258         * tui/tui-winsource.c (tui_clear_source_content)
3259         (tui_show_source_content, tui_show_exec_info_content)
3260         (tui_clear_exec_info_content): Update.
3261         * tui/tui-stack.c (tui_show_locator_content): Update.
3262         (tui_show_frame_info): Update.
3263         * tui/tui-source.h (tui_source_window): Don't declare.
3264         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3265         from tui_source_is_displayed.
3266         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3267         Remove field.
3268         (struct tui_source_window_base) <content_in_use>: New field.  Now
3269         bool.
3270         (struct tui_source_window) <showing_source_p>: New method.
3271         (TUI_SRC_WIN): Change cast.
3272         * tui/tui-data.c (tui_initialize_static_data): Update.
3273
3274 2019-07-17  Tom Tromey  <tom@tromey.com>
3275
3276         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3277         location_matches_p.
3278         * tui/tui-source.c (tui_source_window::location_matches_p): New
3279         method.
3280         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3281         method.
3282         * tui/tui-data.h (struct tui_source_window_base)
3283         <location_matches_p>: New method.
3284         (struct tui_source_window, struct tui_disasm_window)
3285         <location_matches_p>: Likewise.
3286
3287 2019-07-17  Tom Tromey  <tom@tromey.com>
3288
3289         * tui/tui-win.c (tui_set_win_height_command): Rename from
3290         tui_set_win_height.
3291         (tui_set_win_height_command): Remove.
3292
3293 2019-07-17  Tom Tromey  <tom@tromey.com>
3294
3295         * tui/tui-source.c (tui_source_window): New constructor.  Add
3296         observer.
3297         (~tui_source_window): New destructor.
3298         (tui_source_window::style_changed): New method.
3299         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3300         (tui_attach_detach_observers): Update.
3301         * tui/tui-data.h (struct tui_source_window): Make constructor not
3302         inline.  Add destructor.
3303         (struct tui_source_window) <style_changed>: New method.
3304         <m_observable>: New member.
3305
3306 2019-07-17  Tom Tromey  <tom@tromey.com>
3307
3308         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3309         * tui/tui-win.c (tui_resize_all): Fix typo.
3310
3311 2019-07-17  Tom Tromey  <tom@tromey.com>
3312
3313         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3314         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3315         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3316         * tui/tui-win.c (window_name_completer): Use foreach.
3317         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3318         (update_tab_width): Likewise.
3319         * tui/tui-layout.c (show_layout): Update.
3320         * tui/tui-data.h (class tui_window_iterator): New.
3321         (struct all_tui_windows): New.
3322         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3323
3324 2019-07-17  Tom Tromey  <tom@tromey.com>
3325
3326         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3327         parameter.  Don't reference globals.
3328         (tui_reg_command): Update.
3329
3330 2019-07-17  Tom Tromey  <tom@tromey.com>
3331
3332         * tui/tui-regs.c (tui_show_registers): Simplify.
3333
3334 2019-07-17  Tom Tromey  <tom@tromey.com>
3335
3336         * tui/tui-regs.c (tui_show_registers): Update.
3337         (tui_show_register_group): Add win_info parameter.
3338
3339 2019-07-17  Tom Tromey  <tom@tromey.com>
3340
3341         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3342         Rename from tui_display_reg_element_at_line.
3343         (tui_data_window::display_registers_from_line): Update.
3344         * tui/tui-data.h (struct tui_data_window)
3345         <display_reg_element_at_line>: New method.
3346
3347 2019-07-17  Tom Tromey  <tom@tromey.com>
3348
3349         * tui/tui-regs.h (tui_display_registers_from)
3350         (tui_display_registers_from_line): Don't declare.
3351         * tui/tui-windata.c (tui_data_window::display_all_data)
3352         (tui_data_window::refresh_all)
3353         (tui_data_window::do_scroll_vertical): Update.
3354         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3355         from tui_display_registers_from.
3356         (tui_display_reg_element_at_line): Update.
3357         (tui_data_window::display_registers_from_line): Rename from
3358         tui_display_registers_from_line.
3359         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3360         display_registers_from_line>: New methods.
3361
3362 2019-07-17  Tom Tromey  <tom@tromey.com>
3363
3364         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3365         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3366         from tui_erase_data_content.
3367         (tui_data_window::display_all_data)
3368         (tui_data_window::refresh_all)
3369         (tui_data_window::do_scroll_vertical): Update.
3370         * tui/tui-regs.c (tui_show_registers): Update.
3371         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3372         New method.
3373
3374 2019-07-17  Tom Tromey  <tom@tromey.com>
3375
3376         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3377         declare.
3378         * tui/tui-windata.c
3379         (tui_data_window::delete_data_content_windows): Rename from
3380         tui_delete_data_content_windows.
3381         (tui_data_window::display_all_data)
3382         (tui_data_window::do_scroll_vertical): Update.
3383         * tui/tui-data.h (struct tui_data_window)
3384         <delete_data_content_windows>: New method.
3385
3386 2019-07-17  Tom Tromey  <tom@tromey.com>
3387
3388         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3389         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3390
3391 2019-07-17  Tom Tromey  <tom@tromey.com>
3392
3393         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3394         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3395         from tui_display_all_data.
3396         * tui/tui-win.c
3397         (tui_data_window::do_make_visible_with_new_height): Update.
3398         * tui/tui-regs.c (tui_show_registers): Update.
3399         * tui/tui-layout.c (tui_set_layout): Update.
3400         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3401         method.
3402
3403 2019-07-17  Tom Tromey  <tom@tromey.com>
3404
3405         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3406         * tui/tui-windata.c (tui_display_data_from): Remove.
3407         (tui_data_window::refresh_all): Update.
3408
3409 2019-07-17  Tom Tromey  <tom@tromey.com>
3410
3411         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3412         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3413         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3414         tui_display_registers_from_line.
3415         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3416         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3417         "force_display" parameter.
3418
3419 2019-07-17  Tom Tromey  <tom@tromey.com>
3420
3421         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3422         declare.
3423         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3424         Rename from tui_first_reg_element_no_inline.
3425         (tui_display_reg_element_at_line)
3426         (tui_display_registers_from_line): Update.
3427         * tui/tui-data.h (struct tui_data_window)
3428         <first_reg_element_no_inline>: New method.
3429
3430 2019-07-17  Tom Tromey  <tom@tromey.com>
3431
3432         * tui/tui-windata.c (tui_display_data_from)
3433         (tui_data_window::do_scroll_vertical): Update.
3434         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3435         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3436         Rename from tui_line_from_reg_element_no.
3437         (tui_display_registers_from_line): Update.
3438         * tui/tui-data.h (struct tui_data_window)
3439         <line_from_reg_element_no>: New method.
3440
3441 2019-07-17  Tom Tromey  <tom@tromey.com>
3442
3443         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3444         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3445         tui_last_regs_line_no.
3446         (tui_display_reg_element_at_line)
3447         (tui_display_registers_from_line): Update.
3448         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3449         method.
3450
3451 2019-07-17  Tom Tromey  <tom@tromey.com>
3452
3453         PR tui/24722:
3454         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3455         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3456         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3457         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3458         (tui_update_breakpoint_info): Likewise.
3459         * tui/tui-hooks.c (tui_event_create_breakpoint)
3460         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3461         Update.
3462
3463 2019-07-17  Tom Tromey  <tom@tromey.com>
3464
3465         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3466
3467 2019-07-17  Tom Tromey  <tom@tromey.com>
3468
3469         * tui/tui-winsource.c (tui_update_source_window_as_is)
3470         (tui_update_source_windows_with_addr): Update.
3471         * tui/tui-source.h (tui_set_source_content)
3472         (tui_show_symtab_source): Add "win_info" parameter.
3473         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3474         parameter.
3475         (tui_show_symtab_source): Likewise.
3476
3477 2019-07-17  Tom Tromey  <tom@tromey.com>
3478
3479         * tui/tui-wingeneral.c
3480         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3481
3482 2019-07-17  Tom Tromey  <tom@tromey.com>
3483
3484         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3485         (struct tui_cmd_window) <can_scroll>: New method.
3486         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3487         method.
3488
3489 2019-07-17  Tom Tromey  <tromey@adacore.com>
3490
3491         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3492         do_field_signed>: Rename.  Change type of "value".
3493         * ui-out.c (ui_out::field_signed): Rename from field_int.
3494         Change type of "value".
3495         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3496         type of "value".
3497         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3498         do_field_int.  Change type of "value".
3499         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3500         do_field_int.  Change type of "value".
3501         * tracepoint.c (trace_status_mi, tfind_1)
3502         (print_one_static_tracepoint_marker): Update.
3503         * thread.c (print_thread_info_1, print_selected_thread_frame):
3504         Update.
3505         * stack.c (print_frame, print_frame_info): Update.
3506         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3507         Update.
3508         * source.c (print_source_lines_base): Update.
3509         * skip.c (info_skip_command): Update.
3510         * record-btrace.c (btrace_ui_out_decode_error)
3511         (btrace_call_history_src_line): Update.
3512         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3513         Update.
3514         * progspace.c (print_program_space): Update.
3515         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3516         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3517         do_field_int.  Change type of "value".
3518         * mi/mi-out.c (mi_ui_out::do_table_begin)
3519         (mi_ui_out::do_table_header): Update.
3520         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3521         type of "value".
3522         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3523         (mi_cmd_data_list_changed_registers, output_register)
3524         (mi_cmd_data_read_memory, mi_load_progress)
3525         (mi_cmd_trace_frame_collected): Update.
3526         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3527         Update.
3528         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3529         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3530         (mi_cmd_var_list_children, varobj_update_one): Update.
3531         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3532         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3533         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3534         * inferior.c (print_inferior): Update.
3535         * gdb_bfd.c (print_one_bfd): Update.
3536         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3537         Update.
3538         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3539         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3540         do_field_int.  Change type of "value".
3541         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3542         do_field_int.  Change type of "value".
3543         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3544         (print_one_breakpoint_location, print_it_catch_fork)
3545         (print_one_catch_fork, print_it_catch_vfork)
3546         (print_one_catch_vfork, print_it_catch_solib)
3547         (print_it_catch_exec, print_it_ranged_breakpoint)
3548         (print_mention_watchpoint, print_mention_masked_watchpoint)
3549         (bkpt_print_it, update_static_tracepoint): Update.
3550         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3551         * break-catch-syscall.c (print_it_catch_syscall): Update.
3552         * ada-tasks.c (print_ada_task_info): Update.
3553         * ada-lang.c (print_it_exception, print_mention_exception):
3554         Update.
3555
3556 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3557
3558         PR breakpoints/24541
3559         * gdbarch.c: Regenerate.
3560         * gdbarch.h: Regenerate.
3561         * gdbarch.sh: Adjust return type and parameter types for
3562         'stap_adjust_register'.
3563         (i386_stap_adjust_register): Adjust signature and return new
3564         register name.
3565         * stap-probe.c (stap_parse_register_operand): Adjust use of
3566         'gdbarch_stap_adjust_register'.
3567
3568 2019-07-17  Tom Tromey  <tromey@adacore.com>
3569
3570         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3571         declare VEC.
3572         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3573         std::vector.
3574         (struct s390_process_info): Add initializers.
3575         (s390_add_process): Use new.
3576         (s390_linux_nat_target::low_forget_process): Use delete.
3577         (s390_linux_nat_target::low_new_fork)
3578         (s390_linux_nat_target::stopped_by_watchpoint)
3579         (s390_linux_nat_target::low_prepare_to_resume)
3580         (s390_linux_nat_target::insert_watchpoint)
3581         (s390_linux_nat_target::insert_hw_breakpoint)
3582         (s390_linux_nat_target::remove_watchpoint)
3583         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3584
3585 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3586
3587         * aarch64-fbsd-nat.c: Include regcache.h.
3588         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3589         argument.
3590         (aarch64_fbsd_nat_target::fetch_registers)
3591         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3592         variable.
3593         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3594
3595 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3596
3597         * fbsd-nat.c: Include gdbarch.h.
3598
3599 2019-07-15  Tom Tromey  <tromey@adacore.com>
3600
3601         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3602
3603 2019-07-15  Tom Tromey  <tromey@adacore.com>
3604
3605         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3606         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3607         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3608         * cli-out.c (cli_ui_out::do_field_int): New method.
3609         * ui-out.c (ui_out::field_unsigned): New method.
3610         * symfile.c (generic_load): Use field_unsigned.
3611         (print_transfer_performance): Likewise.
3612         * record-btrace.c (ui_out_field_uint): Remove.
3613         (btrace_call_history_insn_range, btrace_call_history): Use
3614         field_unsigned.
3615         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3616         field_unsigned.
3617         * ui-out.h (class ui_out) <field_unsigned>: New method.
3618         <do_field_unsigned>: Likewise.
3619
3620 2019-07-15  Tom Tromey  <tromey@adacore.com>
3621
3622         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3623         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3624         * target.c (flash_erase_command): Use field_string.
3625         * infrun.c (print_signal_received_reason): Use field_string.
3626         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3627         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3628         field_string.
3629         * ada-tasks.c (print_ada_task_info): Use field_string.
3630
3631 2019-07-15  Tom Tromey  <tromey@adacore.com>
3632
3633         * target.c (flash_erase_command): Use field_core_addr.
3634         * symfile.c (generic_load): Use field_core_addr.
3635         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3636         Use field_core_addr.
3637         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3638         field_core_addr.
3639
3640 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3641
3642         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3643         value if its desired type is smaller than a CORE_ADDR and signed.
3644
3645 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3646
3647         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3648         of changes to field names, and use new is_reference field to
3649         decide if a property is a reference or not.
3650         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3651         field.
3652         (struct dwarf2_property_baton): Update header comment, rename
3653         'referenced_type' to 'property_type' and update comments.
3654         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3655         default property type, store in property baton, update to take
3656         accound of renamed field.
3657         (read_func_scope): Update call to attr_to_dynamic_prop.
3658         (read_array_type): Likewise.
3659         (dwarf2_per_cu_addr_sized_int_type): New function.
3660         (read_subrange_index_type): Move type finding code to
3661         dwarf2_per_cu_addr_sized_int_type.
3662         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3663         (dwarf2_per_cu_addr_type): New function.
3664         (set_die_type): Update calls to attr_to_dynamic_prop.
3665
3666 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3667
3668         * dwarf2read.c (read_subrange_index_type): New function.
3669         (read_subrange_type): Move code into new function and call it.
3670         * gdbtypes.c (create_range_type): Add some asserts.
3671
3672 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3673
3674         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3675         update return statements.
3676         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3677         declaration, and update comment to match.
3678         * gdbtypes.c (resolve_dynamic_array): Update call to
3679         dwarf2_evaluate_property to match new return type.
3680
3681 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3682
3683         * valarith.c (value_subscripted_rvalue): Change lowerbound
3684         parameter type from int to LONGEST.
3685         * value.h (value_subscripted_rvalue): Likewise in declaration.
3686
3687 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3688
3689         * cli/cli-utils.c (info_print_command_completer): New function.
3690         * cli/cli-utils.h: Add 'completer.h' include, and forward
3691         declaration for 'struct cmd_list_element'.
3692         (info_print_command_completer): Declare.
3693         * stack.c (_initialize_stack): Add completer for 'info locals' and
3694         'info args'.
3695         * symtab.c (_initialize_symtab): Add completer for 'info
3696         variables' and 'info functions'.
3697         * NEWS: Mention completion for additional info commands.
3698
3699 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3700
3701         * cli/cli-utils.c (extract_info_print_args): Delete.
3702         (extract_arg_maybe_quoted): Delete.
3703         (info_print_options_defs): New variable.
3704         (make_info_print_options_def_group): New function.
3705         (extract_info_print_options): Define new function.
3706         * cli/cli-utils.h (extract_info_print_args): Delete.
3707         (struct info_print_options): New structure.
3708         (extract_info_print_options): Declare new function.
3709         * stack.c (info_locals_command): Update to use new
3710         extract_info_print_options, also add a header comment.
3711         (info_args_command): Likewise.
3712         * symtab.c (info_variables_command): Likewise.
3713         (info_functions_command): Likewise.
3714
3715 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3716
3717         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3718         to extract string arguments.
3719         * common/common-utils.c (extract_string_maybe_quoted): New function.
3720         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3721
3722 2019-07-11  Tom Tromey  <tromey@adacore.com>
3723
3724         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3725         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3726         * top.h (gdbinit): Don't declare.
3727         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3728         into...
3729         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3730         * top.c (gdb_init): Don't call init_cli_cmds.
3731         (gdbinit): Remove.
3732         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3733
3734 2019-07-11  Tom Tromey  <tromey@adacore.com>
3735
3736         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3737         after it has been moved.
3738
3739 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3740
3741         * valops.c (value_must_coerce_to_target): Change return type to
3742         bool.
3743         * value.h (value_must_coerce_to_target): Likewise.
3744
3745 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3746
3747         * breakpoint.c (is_hardware_watchpoint): Remove
3748         forward-declaration.
3749         (is_masked_watchpoint): Change return type to bool.
3750         (is_tracepoint): Likewise.
3751         (is_breakpoint): Likewise.
3752         (is_hardware_watchpoint): Likewise.
3753         (is_watchpoint): Likewise.
3754         (is_no_memory_software_watchpoint): Likewise.
3755         (is_catchpoint): Likewise.
3756         (breakpoint_1): Make FILTER parameter's return type bool.
3757         is_masked_watchpoint): Change return type to bool.
3758         (save_breakpoints): Make FILTER parameter's return type bool.
3759         * breakpoint.h (is_breakpoint): Change return type to bool.
3760         (is_watchpoint): Likewise.
3761         (is_catchpoint): Likewise.
3762         (is_tracepoint): Likewise.
3763
3764 2019-07-10  Tom Tromey  <tom@tromey.com>
3765
3766         * defs.h: Don't include gdbarch.h.
3767         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3768         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3769         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3770         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3771         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3772         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3773         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3774         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3775         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3776         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3777         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3778         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3779         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3780         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3781         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3782         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3783         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3784         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3785         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3786         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3787         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3788         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3789         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3790         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3791         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3792         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3793         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3794
3795 2019-07-10  Tom Tromey  <tromey@adacore.com>
3796
3797         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3798         * breakpoint.c (init_ada_exception_breakpoint): Register as
3799         bp_catchpoint.
3800         (print_one_breakpoint_location, print_one_breakpoint): Use
3801         is_ada_exception_catchpoint.
3802         * ada-lang.c (class ada_catchpoint_location): Pass
3803         bp_loc_software_breakpoint to bp_location constructor.
3804         (is_ada_exception_catchpoint): New function.
3805
3806 2019-07-10  Tom Tromey  <tromey@adacore.com>
3807
3808         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3809         VEC.
3810         (struct arm_exidx_entry): New method operator<.
3811         (struct arm_exidx_data) <section_maps>: Change type.
3812         (arm_exidx_data_free): Remove.
3813         (arm_exidx_data_key): Change type.  Move lower.
3814         (arm_exidx_new_objfile): Update.
3815         (arm_compare_exidx_entries): Remove.
3816         (arm_find_exidx_entry, _initialize_arm_tdep)
3817
3818 2019-07-10  Tom Tromey  <tromey@adacore.com>
3819
3820         * solib-spu.c (ocl_program_data_key): Change type.
3821         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3822         Update.
3823
3824 2019-07-10  Tom Tromey  <tromey@adacore.com>
3825
3826         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3827         (struct solib_aix_inferior_data) <library_list>: Change type.
3828         (solib_aix_inferior_data_handle): Change type.
3829         (get_solib_aix_inferior_data): Update.
3830         (solib_aix_free_library_list): Remove.
3831         (library_list_start_library): Update.
3832         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3833         return type.
3834         (solib_aix_get_library_list)
3835         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3836         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3837
3838 2019-07-10  Tom Tromey  <tromey@adacore.com>
3839
3840         * solib-dsbt.c (struct dsbt_info): Add initializers.
3841         (solib_dsbt_pspace_data): Change type.
3842         (dsbt_pspace_data_cleanup): Remove.
3843         (get_dsbt_info, _initialize_dsbt_solib): Update.
3844
3845 2019-07-10  Tom Tromey  <tromey@adacore.com>
3846
3847         * spu-tdep.c (spu_overlay_data): Change type.
3848         (spu_get_overlay_table, spu_overlay_new_objfile)
3849         (_initialize_spu_tdep): Update.
3850
3851 2019-07-10  Tom Tromey  <tromey@adacore.com>
3852
3853         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3854         destructor.
3855         (dbx_objfile_data_key): Change type and declare later.
3856         (DBX_SYMFILE_INFO): Rewrite.
3857         * dbxread.c (dbx_objfile_data_key): Change type.
3858         (dbx_symfile_init): Update.
3859         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3860         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3861         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3862
3863 2019-07-10  Tom Tromey  <tromey@adacore.com>
3864
3865         * jit.c (jit_program_space_key): Change type.  Move lower.
3866         (get_jit_program_space_data): Update.
3867         (jit_program_space_data_cleanup): Remove.
3868         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3869         Update.
3870         (struct jit_program_space_data): Add initializers.
3871
3872 2019-07-10  Tom Tromey  <tromey@adacore.com>
3873
3874         * solib-darwin.c (struct darwin_info): Add initializers.
3875         (solib_darwin_pspace_data): Change type.
3876         (darwin_pspace_data_cleanup): Remove.
3877         (get_darwin_info, _initialize_darwin_solib): Update.
3878
3879 2019-07-10  Tom Tromey  <tromey@adacore.com>
3880
3881         * remote-sim.c (struct sim_inferior_data): Add initializers,
3882         constructor, and destructor.
3883         (sim_inferior_data_key): Change type.  Move lower.
3884         (check_for_duplicate_sim_descriptor): Update.
3885         (get_sim_inferior_data): Use new.  Update.
3886         (~sim_inferior_data_cleanup): Rename from
3887         sim_inferior_data_cleanup.  Simplify.
3888         (gdbsim_close_inferior, simulator_command)
3889         (sim_command_completer, _initialize_remote_sim): Update.
3890         (next_pid, INITIAL_PID): Move earlier.
3891
3892 2019-07-10  Tom Tromey  <tromey@adacore.com>
3893
3894         * python/python-internal.h (create_thread_object): Return
3895         gdbpy_ref.
3896         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3897         * python/py-inferior.c (struct threadlist_entry): Add
3898         constructor.
3899         <thread_obj>: Now a gdbpy_ref.
3900         (thread_to_thread_object): Update.
3901         (add_thread_object): Use new.
3902         (delete_thread_object): Use delete.
3903         (infpy_threads): Update.
3904         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3905         GIL.
3906
3907 2019-07-10  Tom Tromey  <tromey@adacore.com>
3908
3909         * valops.c (value_cast): Specialize error message for Ada.
3910
3911 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3912
3913         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3914
3915 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3916
3917         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3918         bpstat_should_step): Return bool, adjust comments.
3919         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3920         bpstat_should_step): Likewise.
3921
3922 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3923
3924         * features/Makefile: Use feature target descriptions for Arm.
3925         * features/arm/arm-core.c: Generate new file.
3926         * features/arm/arm-fpa.c: Likewise.
3927         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3928         * features/arm/arm-m-profile.c: Likewise.
3929         * features/arm/arm-vfpv2.c: Likewise.
3930         * features/arm/arm-vfpv3.c: Likewise.
3931         * features/arm/xscale-iwmmxt.c: Likewise.
3932         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3933
3934 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3935
3936         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3937         ptrace earlier.
3938
3939 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3940
3941         * features/aarch64-pauth.c: Regenerate.
3942
3943 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3944
3945         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3946         bool.
3947         (bpstat_what): Use false instead of 0.
3948
3949 2019-07-09  Pedro Alves  <palves@redhat.com>
3950
3951         * break-catch-throw.c (is_exception_catchpoint): New.
3952         * breakpoint.c (print_one_breakpoint_location): New parameter
3953         'raw_loc'.  Handle it.  Use
3954         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3955         looking at the breakpoint's type.
3956         (print_one_breakpoint): If handling "maint info breakpoints", also
3957         print locations of exception catchpoints.
3958         * breakpoint.h (is_exception_catchpoint): Declare.
3959
3960 2019-07-09  Pedro Alves  <palves@redhat.com>
3961
3962         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3963         "addr" field.
3964         (allocate_location_exception_catchpoint): New.
3965         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3966         (initialize_throw_catchpoint_ops): Install
3967         allocate_location_exception_catchpoint as allocate_location
3968         method.
3969         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3970         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3971         bp_loc_other.
3972         (breakpoint_address_is_meaningful): Delete.
3973         (bl_address_is_meaningful): New.
3974         (breakpoint_locations_match): Adjust comment.
3975         (bp_location_from_bp_type): New, factored out of...
3976         (bp_location::bp_location(breakpoint *)): ... this.
3977         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3978         factored out of...
3979         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3980         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3981         breakpoint_address_is_meaningful.
3982         (bp_locations_compare): Adjust comment.
3983         (update_global_location_list): Use bl_address_is_meaningful
3984         instead of breakpoint_address_is_meaningful.
3985         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3986         explicit.
3987         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3988         * python/py-breakpoint.c (bppy_get_location): No longer check
3989         whether location is null.
3990
3991 2019-07-09  Pedro Alves  <palves@redhat.com>
3992
3993         PR c++/15468
3994         * breakpoint.c (print_one_breakpoint_location): Remove
3995         single-location assert.
3996
3997 2019-07-09  Tom Tromey  <tom@tromey.com>
3998
3999         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4000         * configure: Rebuild.
4001         * configure.ac: Change common to gdbsupport.
4002         * gdbsupport: Rename from common.
4003         * acinclude.m4: Change common to gdbsupport.
4004         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4005         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4006         gdbsupport.
4007         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4008         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4009         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4010         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4011         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4012         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4013         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4014         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4015         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4016         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4017         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4018         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4019         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4020         coff-pe-read.c, command.h, compile/compile-c-support.c,
4021         compile/compile-c.h, compile/compile-cplus-symbols.c,
4022         compile/compile-cplus-types.c, compile/compile-cplus.h,
4023         compile/compile-loc2c.c, compile/compile.c, completer.c,
4024         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4025         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4026         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4027         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4028         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4029         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4030         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4031         features/aarch64-core.c, features/aarch64-fpu.c,
4032         features/aarch64-pauth.c, features/aarch64-sve.c,
4033         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4034         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4035         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4036         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4037         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4038         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4039         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4040         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4041         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4042         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4043         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4044         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4045         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4046         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4047         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4048         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4049         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4050         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4051         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4052         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4053         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4054         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4055         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4056         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4057         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4058         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4059         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4060         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4061         minsyms.c, mips-linux-tdep.c, namespace.h,
4062         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4063         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4064         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4065         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4066         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4067         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4068         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4069         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4070         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4071         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4072         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4073         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4074         procfs.c, producer.c, progspace.h, psymtab.h,
4075         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4076         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4077         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4078         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4079         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4080         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4081         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4082         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4083         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4084         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4085         target-memory.c, target.c, target.h, target/waitstatus.c,
4086         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4087         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4088         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4089         unittests/array-view-selftests.c,
4090         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4091         unittests/common-utils-selftests.c,
4092         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4093         unittests/format_pieces-selftests.c,
4094         unittests/function-view-selftests.c,
4095         unittests/lookup_name_info-selftests.c,
4096         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4097         unittests/mkdir-recursive-selftests.c,
4098         unittests/observable-selftests.c,
4099         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4100         unittests/parse-connection-spec-selftests.c,
4101         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4102         unittests/scoped_fd-selftests.c,
4103         unittests/scoped_mmap-selftests.c,
4104         unittests/scoped_restore-selftests.c,
4105         unittests/string_view-selftests.c, unittests/style-selftests.c,
4106         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4107         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4108         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4109         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4110         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4111         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4112
4113 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4114
4115         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4116         bool value.
4117         (decode_digits_ordinary): Set explicit_line field in sal.
4118         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4119         symtab_and_line that was set on an explicit line number in
4120         assembler code.  Do always update the recorded symtab and line if
4121         we do skip the prologue.
4122
4123 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4124
4125         * breakpoint.c (set_breakpoint_location_function): Remove
4126         explicit_loc parameter.
4127         (momentary_breakpoint_from_master): Update call to
4128         set_breakpoint_location_function.
4129         (add_location_to_breakpoint): Likewise.
4130
4131 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4132
4133         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4134         required features based on default bfd type when no specific bfd
4135         is present.
4136
4137 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4138
4139         * NEWS: Mention that GDB printf and eval commands can now print
4140         C-style and Ada-style convenience var strings without
4141         calling the inferior.
4142         * printcmd.c (printf_c_string): Locally print GDB internal var
4143         instead of transiting via the inferior.
4144         (printf_wide_c_string): Likewise.
4145
4146 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4147
4148         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4149
4150 2019-07-04  Tom Tromey  <tom@tromey.com>
4151
4152         PR tui/24724:
4153         * tui/tui-winsource.c (tui_clear_source_content): Update.
4154         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4155         (tui_update_breakpoint_info): Update.
4156         (tui_set_exec_info_content): Update.
4157         * tui/tui-source.c (tui_set_source_content_nil): Update.
4158         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4159         has_break.
4160         * tui/tui-data.h (enum tui_bp_flag): New.
4161         (tui_bp_flags): New enum flags type.
4162         (struct tui_source_element) <break_mode>: Change type.  Rename
4163         from has_break.
4164         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4165         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4166         constants.
4167         * tui/tui-winsource.h: Fix comment.
4168
4169 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4170
4171         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4172         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4173         (store_fpregs_to_thread)
4174         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4175         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4176         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4177         (IWMMXT_REGS_SIZE): Add define.
4178         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4179         (fetch_vfp_regs, store_vfp_regs)
4180         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4181         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4182
4183 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4184
4185         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4186         defines.
4187         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4188         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4189         (ARM_INT_REGISTER_SIZE): ...to this.
4190         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4191         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4192         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4193         (arm_linux_collect_gregset, supply_nwfpe_register)
4194         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4195         defines.
4196         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4197         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4198         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4199         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4200         (arm_return_in_memory, arm_store_return_value)
4201         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4202         (arm_record_ld_st_multiple): Likewise.
4203         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4204         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4205
4206 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4207
4208         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4209         AARCH64_DISPLACED_MODIFIED_INSNS.
4210         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4211         (aarch64_displaced_step_copy_insn): Likewise.
4212         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4213         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4214         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4215         ARM_DISPLACED_MODIFIED_INSNS.
4216         * arm-tdep.c (arm_gdbarch_init): Likewise.
4217         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4218         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4219         (struct arm_displaced_step_closure): Use
4220         ARM_DISPLACED_MODIFIED_INSNS.
4221
4222 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4223
4224         * features/Makefile: Remove unused xml files.
4225         * features/aarch64.xml: Remove.
4226         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4227         * features/i386/amd64-avx-avx512.xml: Remove.
4228         * features/i386/amd64-avx-linux.xml: Remove.
4229         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4230         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4231         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4232         * features/i386/amd64-avx-mpx.xml: Remove.
4233         * features/i386/amd64-avx.xml: Remove.
4234         * features/i386/amd64-linux.xml: Remove.
4235         * features/i386/amd64-mpx-linux.xml: Remove.
4236         * features/i386/amd64-mpx.xml: Remove.
4237         * features/i386/amd64.xml: Remove.
4238         * features/i386/i386-avx-avx512-linux.xml: Remove.
4239         * features/i386/i386-avx-avx512.xml: Remove.
4240         * features/i386/i386-avx-linux.xml: Remove.
4241         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4242         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4243         * features/i386/i386-avx-mpx-linux.xml: Remove.
4244         * features/i386/i386-avx-mpx.xml: Remove.
4245         * features/i386/i386-avx.xml: Remove.
4246         * features/i386/i386-linux.xml: Remove.
4247         * features/i386/i386-mmx-linux.xml: Remove.
4248         * features/i386/i386-mmx.xml: Remove.
4249         * features/i386/i386-mpx-linux.xml: Remove.
4250         * features/i386/i386-mpx.xml: Remove.
4251         * features/i386/i386.xml: Remove.
4252         * features/i386/x32-avx-avx512-linux.xml: Remove.
4253         * features/i386/x32-avx-linux.xml: Remove.
4254         * features/i386/x32-linux.xml: Remove.
4255
4256 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4257
4258         * regformats/aarch64.dat: Remove.
4259         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4260         * regformats/i386/amd64-avx-linux.dat: Remove.
4261         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4262         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4263         * regformats/i386/amd64-linux.dat: Remove.
4264         * regformats/i386/amd64-mpx-linux.dat: Remove.
4265         * regformats/i386/amd64.dat: Remove.
4266         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4267         * regformats/i386/i386-avx-linux.dat: Remove.
4268         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4269         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4270         * regformats/i386/i386-linux.dat: Remove.
4271         * regformats/i386/i386-mmx-linux.dat: Remove.
4272         * regformats/i386/i386-mpx-linux.dat: Remove.
4273         * regformats/i386/i386.dat: Remove.
4274         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4275         * regformats/i386/x32-avx-linux.dat: Remove.
4276         * regformats/i386/x32-linux.dat: Remove.
4277
4278 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4279
4280         * aarch64-tdep.c: Remove xml self tests.
4281         * amd64-linux-tdep.c: Likewise.
4282         * amd64-tdep.c: Likewise.
4283         * i386-linux-tdep.c: Likewise.
4284         * i386-tdep.c: Likewise.
4285
4286 2019-07-03  Pedro Alves  <palves@redhat.com>
4287
4288         PR cli/24732
4289         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4290         (pipe_cmd_option_defs): New.
4291         (make_pipe_cmd_options_def_group): New.
4292         (pipe_command): Use gdb::option::process_options.
4293         (pipe_command_completer): New function.
4294         (_initialize_cli_cmds): Install completer for "pipe" command.
4295
4296 2019-07-03  Pedro Alves  <palves@redhat.com>
4297
4298         * cli/cli-option.c (union option_value) <string>: New field.
4299         (struct option_def_and_value): Add ctor, move ctor, dtor and
4300         use DISABLE_COPY_AND_ASSIGN.
4301         (option_def_and_value::clear_value): New.
4302         (parse_option, save_option_value_in_ctx, get_val_type_str)
4303         (add_setshow_cmds_for_options): Handle var_string.
4304         * cli-option.h (union option_def::var_address) <string>: New
4305         field.
4306         (struct string_option_def): New.
4307         * maint-test-options.c (struct test_options_opts): Add default
4308         ctor and use DISABLE_COPY_AND_ASSIGN.
4309         <string_opt>: New field.
4310         (test_options_opts::~test_options_opts): New.
4311         (test_options_opts::dump): Also dump "-string".
4312         (test_options_option_defs): Install "string.
4313
4314 2019-07-03  Pedro Alves  <palves@redhat.com>
4315
4316         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4317         option_value with a null enumeration.
4318         (complete_options): Save the option values in the context.
4319         (save_option_value_in_ctx): New, factored out from ...
4320         (process_options): ... here.
4321         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4322         of the function.
4323         * maint-test-options.c (test_options_opts::dump): New, factored
4324         out from ...
4325         (maintenance_test_options_command_mode): ... here.
4326         (maintenance_test_options_command_completion_result): Delete.
4327         (maintenance_test_options_command_completion_text): Update
4328         comment.
4329         (maintenance_show_test_options_completion_result): Change
4330         prototype.  Just print
4331         maintenance_test_options_command_completion_text.
4332         (save_completion_result): New.
4333         (maintenance_test_options_completer_mode): Pass options context to
4334         complete_options, and then save a dump.
4335         (_initialize_maint_test_options): Use add_cmd to install "maint
4336         show test-options-completion-result".
4337
4338 2019-07-03  Pedro Alves  <palves@redhat.com>
4339
4340         * NEWS (New commands): Mention "with" and "maint with".
4341         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4342         (with_command, with_command_completer): New.
4343         (pipe_command): Adjust to new repeat_previous
4344         interface.
4345         (_initialize_cli_cmds): Install the "with" command and its "w"
4346         alias.
4347         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4348         declarations.
4349         * cli/cli-setshow.c (parse_cli_var_uinteger)
4350         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4351         argument strings for all var_types.
4352         (get_setshow_command_value_string): New, factored out from ...
4353         (do_show_command): ... this.
4354         * cli/cli-setshow.h: Include <string>.
4355         (get_setshow_command_value_string): Declare.
4356         * command.h (repeat_previous): Now returns const char *.  Adjust
4357         comment.
4358         * maint.c: Include "cli/cli-cmds.h".
4359         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4360         (_initialize_maint_cmds): Register the "maintenance with" command.
4361         * top.c (repeat_previous): Move bits from pipe_command here:
4362         Return the saved command line, if any; error out if there's no
4363         command to relaunch.
4364
4365 2019-07-03  Pedro Alves  <palves@redhat.com>
4366
4367         * NEWS (New commands): Mention "maint set/show test-settings"
4368         instead of "maint test-settings".
4369         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4370         (maintenance_test_settings_set_list): Rename to ...
4371         (maintenance_set_test_settings_list): ... this.
4372         (maintenance_test_settings_show_list): Rename to  ...
4373         (maintenance_show_test_settings_list): ... this.
4374         (maintenance_test_settings_cmd): Delete.
4375         (maintenance_test_settings_set_cmd): ...
4376         (maintenance_set_test_settings_cmd): ... this.
4377         (maintenance_test_settings_show_cmd): ...
4378         (maintenance_show_test_settings_cmd): ... this.
4379         (maintenance_test_settings_show_value_cmd):
4380         (maintenance_show_test_settings_value_cmd): ... this.
4381         (_initialize_maint_test_settings): No longer install the "maint
4382         test-settings" prefix command.  Rename "maint test-settings set"
4383         to "maint set test-settings", and "maint test-settings show" to
4384         "maint show test-settings".  Adjust all subcommands.
4385
4386 2019-07-03  Pedro Alves  <palves@redhat.com>
4387
4388         * maint-test-settings.c: Fix file's intro comment.  Replace all
4389         references to "test-options" with references to "test-settings",
4390         in comments.
4391
4392 2019-07-03  Pedro Alves  <palves@redhat.com>
4393
4394         * maint-test-settings.c (maintenance_test_settings_xxx)
4395         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4396         New.
4397         (maintenance_test_settings_enums): Use them.
4398         (maintenance_test_settings_enum): Default to
4399         maintenance_test_settings_xxx.
4400         (_initialize_maint_test_settings): Initialize
4401         MAINTENANCE_TEST_SETTINGS_FILENAME.
4402
4403 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4404
4405         * breakpoint.h (remove_breakpoints_inf): Change return type to
4406         void, move function documentation here.
4407         * breakpoint.c (remove_breakpoints_inf): Change return type to
4408         void, move function documentation to header.
4409
4410 2019-07-02  Pedro Alves  <palves@redhat.com>
4411
4412         * NEWS (Completion improvements): Mention "info threads".
4413         * thread.c (struct info_threads_opts, info_threads_option_defs)
4414         (make_info_threads_options_def_group): New.
4415         (info_threads_command): Use gdb::option::process_options.
4416         (info_threads_command_completer): New.
4417         (_initialize_thread): Use gdb::option::build_help to build the
4418         help text for "info threads".
4419
4420 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4421
4422         * defs.h (generic_load): Move from here...
4423         * symfile.h (generic_load): ... to here.  Rename name parameter
4424         to args.
4425         * symfile.c (generic_load): Add comment.
4426
4427 2019-07-01  Tom Tromey  <tromey@adacore.com>
4428
4429         * dwarf2read.c
4430         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4431         declaration of without_params.  Fix formatting.
4432
4433 2019-07-01  Tom Tromey  <tromey@adacore.com>
4434
4435         * ada-exp.y (find_primitive_type): Update.
4436         * ada-lang.h (ada_lookup_symbol): Update.
4437         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4438         parameter.
4439         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4440
4441 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4442
4443         PR breakpoints/24541
4444         * gdbarch.c: Regenerate.
4445         * gdbarch.h: Regenerate.
4446         * gdbarch.sh: Add 'stap_adjust_register'.
4447         * i386-tdep.c: Include '<unordered_set>'.
4448         (i386_stap_adjust_register): New function.
4449         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4450         * stap-probe.c (stap_parse_register_operand): Call
4451         'gdbarch_stap_adjust_register'.
4452
4453 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4454
4455         PR python/24742
4456         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4457         * python/python.c (do_start_initialization): Use 'xmalloc'
4458         instead of 'PyMem_Malloc'.
4459
4460 2019-06-28  Tom Tromey  <tromey@adacore.com>
4461
4462         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4463         for Ada.
4464
4465 2019-06-27  Tom Tromey  <tromey@adacore.com>
4466
4467         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4468         objfile_key.
4469         (arm_find_mapping_symbol, arm_record_special_symbol)
4470         (_initialize_arm_tdep): Update.
4471         (arm_objfile_data_free): Remove.
4472
4473 2019-06-27  Tom Tromey  <tromey@adacore.com>
4474
4475         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4476         to cp_print_static_field.
4477
4478 2019-06-26  Tom Tromey  <tromey@adacore.com>
4479
4480         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4481         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4482         declare.
4483
4484 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4485
4486         * features/aarch64-core.c (create_feature_aarch64_core):
4487         Regenerate.
4488         * features/aarch64-core.xml: Add cpsr flags.
4489
4490 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4491
4492         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4493         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4494
4495 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4496
4497         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4498         field.
4499         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4500         use.
4501         (arm_record_special_symbol): Don't insert new symbol in sorted
4502         position, push it at the end.
4503
4504 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4505
4506         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4507         (arm_mapping_symbol_s): Remove.
4508         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4509         (arm_mapping_symbol_vec): New typedef.
4510         (struct arm_per_objfile): Add constructor.
4511         <section_maps>: Change type to
4512         std::unique_ptr<arm_mapping_symbol_vec[]>.
4513         (arm_compare_mapping_symbols): Remove.
4514         (arm_find_mapping_symbol): Adjust to section_maps type change.
4515         (arm_objfile_data_free): Call delete on arm_per_objfile.
4516         (arm_record_special_symbol): Adjust to section_maps type change.
4517         Allocate arm_per_objfile with new.
4518
4519 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4520
4521         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4522         with the command prefix.
4523
4524 2019-06-25  Tom Tromey  <tom@tromey.com>
4525
4526         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4527         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4528
4529 2019-06-25  Tom Tromey  <tom@tromey.com>
4530
4531         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4532         type.
4533         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4534         protected.
4535
4536 2019-06-25  Tom Tromey  <tom@tromey.com>
4537
4538         * tui/tui-winsource.c
4539         (tui_source_window_base::set_is_exec_point_at): Add check against
4540         LOA_ADDRESS.
4541
4542 2019-06-25  Tom Tromey  <tom@tromey.com>
4543
4544         * tui/tui-source.c (tui_set_source_content): Don't check before
4545         xfree.
4546         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4547
4548 2019-06-25  Tom Tromey  <tom@tromey.com>
4549
4550         * tui/tui-winsource.h (tui_update_source_window_as_is)
4551         (tui_alloc_source_buffer, tui_line_is_displayed)
4552         (tui_addr_is_displayed): Change type of win_info.
4553         * tui/tui-winsource.c (tui_update_source_window_as_is)
4554         (tui_clear_source_content, tui_show_source_line)
4555         (tui_show_source_content, tui_source_window_base::refill)
4556         (tui_source_window_base::set_is_exec_point_at)
4557         (tui_source_window_base::set_is_exec_point_at)
4558         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4559         (tui_alloc_source_buffer, tui_line_is_displayed)
4560         (tui_addr_is_displayed): Change type of win_info.  Update.
4561         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4562         (tui_source_window_base::do_make_visible_with_new_height):
4563         Update.
4564         * tui/tui-source.c (tui_set_source_content)
4565         (tui_set_source_content_nil)
4566         (tui_source_window::do_scroll_vertical): Update.
4567         * tui/tui-layout.c (show_layout): Update.
4568         * tui/tui-disasm.c (tui_set_disassem_content)
4569         (tui_disasm_window::do_scroll_vertical): Update.
4570         * tui/tui-data.h (tui_win_content): Remove.
4571         (struct tui_gen_win_info) <content, content_size>: Remove.
4572         (struct tui_source_element): Add initializers and destructor.
4573         (union tui_which_element, struct tui_win_element): Remove.
4574         (struct tui_source_window_base) <content>: New field.
4575         (struct tui_data_window): Remove destructor.
4576         (tui_alloc_content, tui_free_win_content)
4577         (tui_free_all_source_wins_content): Don't declare.
4578         * tui/tui-data.c (tui_initialize_static_data): Update.
4579         (init_content_element, tui_alloc_content): Remove.
4580         (~tui_gen_win_info): Update.
4581         (~tui_data_window, tui_free_all_source_wins_content)
4582         (tui_free_win_content, free_content, free_content_elements):
4583         Remove.
4584
4585 2019-06-25  Tom Tromey  <tom@tromey.com>
4586
4587         * tui/tui-winsource.h (tui_clear_source_content)
4588         (tui_erase_source_content, tui_show_source_content): Change type
4589         of win_info.
4590         * tui/tui-winsource.c (tui_clear_source_content)
4591         (tui_erase_source_content, tui_show_source_content): Change type
4592         of win_info.
4593         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4594         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4595         win_info.
4596         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4597         win_info.
4598         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4599
4600 2019-06-25  Tom Tromey  <tom@tromey.com>
4601
4602         * tui/tui-winsource.c (tui_clear_source_content)
4603         (tui_source_window_base::set_is_exec_point_at): Update.
4604         * tui/tui-source.c (tui_set_source_content_nil): Update.
4605         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4606         a bool.
4607         * tui/tui-data.c (init_content_element): Update.
4608
4609 2019-06-25  Tom Tromey  <tom@tromey.com>
4610
4611         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4612         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4613         * tui/tui-layout.c (init_and_make_win): Update.
4614         * tui/tui.h (enum tui_win_type): Update.
4615         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4616         tui_win_is_auxillary.
4617         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4618         tui_win_is_auxillary.
4619
4620 2019-06-25  Tom Tromey  <tom@tromey.com>
4621
4622         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4623         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4624         (tui_delete_data_content_windows, tui_display_all_data)
4625         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4626         Update.
4627         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4628         * tui/tui-regs.c (tui_last_regs_line_no)
4629         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4630         (tui_show_registers): Update.
4631         (tui_show_register_group): Return void.  Update.
4632         (tui_display_registers_from, tui_display_reg_element_at_line)
4633         (tui_display_registers_from_line, tui_check_register_values):
4634         Update.
4635         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4636         member.
4637         (struct tui_data_window) <regs_content>: Now a std::vector.
4638         <regs_content_count>: Remove.
4639         (tui_add_content_elements, tui_free_data_content): Don't declare.
4640         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4641         (init_content_element): Remove DATA_WIN case.  Add assert.
4642         (tui_add_content_elements): Remove.
4643         (tui_data_window): Update.
4644         (tui_free_data_content): Remove.
4645         (free_content_elements): Remove DATA_WIN case.
4646
4647 2019-06-25  Tom Tromey  <tom@tromey.com>
4648
4649         * tui/tui-data.c (tui_data_item_window): Update.
4650         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4651         * tui/tui-windata.c (tui_display_all_data)
4652         (tui_display_data_from_line): Update.
4653         (tui_check_data_values): Remove.
4654         * tui/tui-regs.c (tui_show_register_group)
4655         (tui_display_reg_element_at_line): Update.
4656         * tui/tui-hooks.c (tui_register_changed)
4657         (tui_refresh_frame_and_register_information): Call
4658         tui_check_register_values.
4659         * tui/tui-data.h (struct tui_data_window) <data_content,
4660         data_content_count, data_type>: Remove.
4661         (enum tui_data_type): Remove.
4662
4663         * tui/tui-data.c (tui_data_window::clear_detail)
4664         (~tui_data_window): Update.
4665
4666 2019-06-25  Tom Tromey  <tom@tromey.com>
4667
4668         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4669         declare.
4670         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4671         Rename from tui_first_data_item_displayed.  Update.
4672         (tui_data_window::refresh_all)
4673         (tui_data_window::do_scroll_vertical): Update.
4674         * tui/tui-data.h (struct tui_data_window)
4675         <first_data_item_displayed>: Declare new method.
4676
4677 2019-06-25  Tom Tromey  <tom@tromey.com>
4678
4679         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4680         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4681         contents...
4682         (tui_initialize_static_data): ...here.
4683
4684 2019-06-25  Tom Tromey  <tom@tromey.com>
4685
4686         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4687         (tui_display_registers_from, tui_check_register_values): Update.
4688         (tui_display_register): Remove win_info parameter; update.
4689         (tui_get_register): Change type of parameters.
4690         * tui/tui-data.h (struct tui_data_element): Remove.
4691         (union tui_which_element) <data>: Remove.
4692         <data_window>: Change type.
4693         (struct tui_data_item_window): New.
4694         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4695         case.  Add assert.
4696         (~tui_data_item_window): New destructor.
4697         (free_content_elements): Remove DATA_ITEM_WIN case.
4698
4699 2019-06-25  Tom Tromey  <tom@tromey.com>
4700
4701         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4702         Remove.
4703
4704 2019-06-25  Tom Tromey  <tom@tromey.com>
4705
4706         * tui/tui-data.h (struct tui_command_element): Remove.
4707         (union tui_which_element) <command>: Remove.
4708         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4709         assert.
4710         (free_content_elements): Remove CMD_WIN case.
4711
4712 2019-06-25  Tom Tromey  <tom@tromey.com>
4713
4714         * tui/tui-layout.c (tui_set_layout): Update.
4715         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4716         * tui/tui-data.c (layout_def): Update.
4717
4718 2019-06-25  Tom Tromey  <tom@tromey.com>
4719
4720         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4721         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4722         (tui_source_window_base::set_new_height): Update.
4723         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4724         Update.
4725         (tui_set_locator_fullname, tui_set_locator_info)
4726         (tui_show_frame_info): Update.
4727         * tui/tui-source.c (tui_set_source_content)
4728         (tui_source_is_displayed): Update.
4729         * tui/tui-layout.c (show_source_disasm_command, show_data)
4730         (show_source_or_disasm_and_command): Update.
4731         * tui/tui-disasm.c (tui_set_disassem_content)
4732         (tui_get_begin_asm_address): Update.
4733         * tui/tui-data.h (struct tui_locator_element): Remove.
4734         (union tui_which_element) <locator>: Remove.
4735         (struct tui_locator_window): New.
4736         (tui_locator_win_info_ptr): Change return type.
4737         * tui/tui-data.c (_locator): Change type.
4738         (tui_locator_win_info_ptr): Change return type.
4739         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4740         (tui_alloc_content): Add assert.
4741
4742 2019-06-25  Tom Tromey  <tom@tromey.com>
4743
4744         * tui/tui-winsource.c
4745         (tui_exec_info_window::maybe_allocate_content): New method.
4746         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4747         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4748         (make_source_or_disasm_window): Add cast.
4749         * tui/tui-data.h (union tui_which_element) <simple_string>:
4750         Remove.
4751         (struct tui_source_info): New.
4752         (struct tui_source_window_base) <execution_info>: Change type.
4753         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4754         case, and add assert.
4755         (tui_alloc_content): Add assert.
4756
4757 2019-06-25  Tom Tromey  <tom@tromey.com>
4758
4759         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4760         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4761         * tui/tui-data.c (tui_alloc_win_info): Remove.
4762
4763 2019-06-25  Tom Tromey  <tom@tromey.com>
4764
4765         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4766         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4767         can_highlight.
4768
4769 2019-06-25  Tom Tromey  <tom@tromey.com>
4770
4771         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4772         make_visible_with_new_height method.
4773         (tui_win_info::make_visible_with_new_height): New method.
4774         (tui_source_window_base::do_make_visible_with_new_height)
4775         (tui_data_window::do_make_visible_with_new_height)
4776         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4777         (make_visible_with_new_height): Remove.
4778         (tui_resize_all, tui_adjust_win_heights): Use
4779         make_visible_with_new_height method.
4780         * tui/tui-data.h (struct tui_win_info)
4781         <do_make_visible_with_new_height, make_visible_with_new_height>:
4782         New methods.
4783         (struct tui_source_window_base, struct tui_data_window)
4784         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4785         methods.
4786
4787 2019-06-25  Tom Tromey  <tom@tromey.com>
4788
4789         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4790         method.
4791         (update_tab_width): Call update_tab_width method.
4792         * tui/tui-data.h (struct tui_win_info)
4793         (struct tui_source_window_base) <update_tab_width>: New methods.
4794
4795 2019-06-25  Tom Tromey  <tom@tromey.com>
4796
4797         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4798         parameter.
4799         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4800         parameter.
4801         (tui_gen_win_info::make_visible): Update.
4802         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4803         parameter.
4804         * tui/tui-data.h (enum tui_box): New enum.
4805         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4806
4807 2019-06-25  Tom Tromey  <tom@tromey.com>
4808
4809         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4810         init_and_make_win for EXEC_INFO_WIN.
4811         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4812         longer inline.
4813         (struct tui_win_info) <~tui_win_info>: Inline.
4814         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4815         Don't declare.
4816         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4817         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4818         Remove.
4819         (tui_initialize_static_data): Update.
4820         (~tui_gen_win_info): Handle more cleanup here.
4821         (~tui_source_window_base): Delete "execution_info".
4822         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4823
4824 2019-06-25  Tom Tromey  <tom@tromey.com>
4825
4826         * tui/tui-layout.c (make_command_window): Don't set
4827         can_highlight.
4828         (show_source_disasm_command): Call the reset method.
4829         (show_data): Don't set can_highlight.  Call the reset method.
4830         (tui_gen_win_info::reset): Rename from init_gen_win_info
4831         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4832         (show_source_or_disasm_and_command): Call the reset method.
4833         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4834         (struct tui_cmd_window): Set can_highlight.
4835
4836 2019-06-25  Tom Tromey  <tom@tromey.com>
4837
4838         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4839         from make_visible.
4840         (tui_make_visible, tui_make_invisible): Rewrite.
4841         (tui_win_info::make_visible): Remove.
4842         (tui_source_window_base::make_visible): Update.
4843         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4844         method.  Moved from...
4845         (struct tui_win_info) <make_visible>: ...here.
4846
4847 2019-06-25  Tom Tromey  <tom@tromey.com>
4848
4849         * tui/tui-winsource.c
4850         (tui_source_window_base::do_scroll_horizontal): Remove direction
4851         parameter.
4852         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4853         direction parameter.
4854         * tui/tui-win.c (tui_win_info::forward_scroll)
4855         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4856         (tui_win_info::right_scroll): Update.
4857         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4858         direction parameter.
4859         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4860         direction parameter.
4861         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4862         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4863         Remove direction parameter.
4864         (struct tui_source_window_base, struct tui_source_window)
4865         (struct tui_disasm_window, struct tui_data_window)
4866         (struct tui_cmd_window): Update.
4867
4868 2019-06-25  Tom Tromey  <tom@tromey.com>
4869
4870         * tui/tui-winsource.h (tui_set_exec_info_content)
4871         (tui_show_exec_info_content, tui_erase_exec_info_content)
4872         (tui_clear_exec_info_content, tui_update_exec_info): Change
4873         argument to tui_source_window_base.
4874         * tui/tui-winsource.c (tui_set_exec_info_content)
4875         (tui_show_exec_info_content, tui_erase_exec_info_content)
4876         (tui_clear_exec_info_content, tui_update_exec_info): Change
4877         argument to tui_source_window_base.
4878
4879 2019-06-25  Tom Tromey  <tom@tromey.com>
4880
4881         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4882         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4883
4884 2019-06-25  Tom Tromey  <tom@tromey.com>
4885
4886         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4887         check.
4888
4889 2019-06-25  Tom Tromey  <tom@tromey.com>
4890
4891         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4892         type to void.
4893         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4894         type to void.
4895         * tui/tui-source.c (tui_set_source_content): Update.
4896         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4897
4898 2019-06-25  Tom Tromey  <tom@tromey.com>
4899
4900         * tui/tui-win.c (window_name_completer, tui_set_focus)
4901         (tui_all_windows_info): Use name method.
4902         * tui/tui-data.h (struct tui_gen_win_info)
4903         (struct tui_source_window, struct tui_disasm_window)
4904         (struct tui_data_window, struct tui_cmd_window) <name>: New
4905         method.
4906         (tui_win_name): Don't declare.
4907         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4908         (tui_win_name): Remove.
4909
4910 2019-06-25  Tom Tromey  <tom@tromey.com>
4911
4912         * tui/tui-winsource.h (tui_update_source_window)
4913         (tui_update_source_window_as_is): Change parameter type.
4914         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4915         to be a tui_source_window_base.
4916         (tui_update_source_window_as_is): Likewise.
4917         * tui/tui-win.c (make_visible_with_new_height): Update.
4918
4919 2019-06-25  Tom Tromey  <tom@tromey.com>
4920
4921         * tui/tui-winsource.c (tui_erase_source_content)
4922         (tui_show_source_content, tui_show_exec_info_content)
4923         (tui_erase_exec_info_content): Use refresh_window method.
4924         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4925         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4926         from tui_refresh_win.
4927         (tui_data_window::refresh_window): New method.
4928         (tui_win_info::refresh, tui_source_window_base::refresh)
4929         (tui_refresh_all): Use refresh_window method.
4930         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4931         method.
4932         * tui/tui-regs.c (tui_display_register): Call refresh_window
4933         method.
4934         * tui/tui-layout.c (show_source_disasm_command)
4935         (show_source_or_disasm_and_command): Call refresh_window method.
4936         * tui/tui-data.h (struct tui_gen_win_info)
4937         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4938         New method.
4939
4940 2019-06-25  Tom Tromey  <tom@tromey.com>
4941
4942         * tui/tui.c (tui_rl_other_window, tui_enable)
4943         (tui_is_window_visible, tui_get_command_dimension): Update.
4944         * tui/tui-winsource.c (tui_update_source_window_as_is)
4945         (tui_clear_source_content, tui_erase_source_content)
4946         (tui_show_source_line, tui_source_window_base::refill)
4947         (tui_source_window_base::do_scroll_horizontal)
4948         (tui_source_window_base::set_is_exec_point_at)
4949         (tui_update_breakpoint_info, tui_set_exec_info_content)
4950         (tui_alloc_source_buffer, tui_line_is_displayed)
4951         (tui_addr_is_displayed): Update.
4952         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4953         (tui_check_and_display_highlight_if_needed)
4954         (tui_win_info::make_visible, tui_win_info::refresh)
4955         (tui_refresh_all): Update.
4956         * tui/tui-windata.c (tui_first_data_item_displayed)
4957         (tui_delete_data_content_windows, tui_erase_data_content)
4958         (tui_display_all_data, tui_data_window::refresh_all)
4959         (tui_check_data_values): Update.
4960         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4961         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4962         (tui_win_info::backward_scroll, tui_refresh_all_win)
4963         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4964         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4965         (tui_source_window_base::set_new_height)
4966         (tui_data_window::set_new_height)
4967         (make_invisible_and_set_new_height)
4968         (make_visible_with_new_height, new_height_ok)
4969         (parse_scrolling_args): Update.
4970         * tui/tui-stack.c (tui_show_frame_info): Update.
4971         * tui/tui-source.c (tui_set_source_content)
4972         (tui_set_source_content_nil, tui_source_is_displayed)
4973         (tui_source_window::do_scroll_vertical): Update.
4974         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4975         (tui_display_registers_from, tui_display_reg_element_at_line)
4976         (tui_check_register_values, tui_reg_command): Update.
4977         * tui/tui-layout.c (tui_default_win_height)
4978         (show_source_disasm_command, show_data, init_and_make_win)
4979         (show_source_or_disasm_and_command): Update.
4980         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4981         (tui_redisplay_readline, tui_mld_flush)
4982         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4983         (tui_getc): Update.
4984         * tui/tui-disasm.c (tui_set_disassem_content)
4985         (tui_disasm_window::do_scroll_vertical): Update.
4986         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4987         Now virtual.
4988         (struct tui_win_info): Derive from tui_gen_win_info.
4989         <~tui_win_info>: Mark as override.
4990         <generic>: Remove member.
4991         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4992         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4993         (~tui_data_window, ~tui_win_info)
4994         (tui_free_all_source_wins_content): Update.
4995         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4996
4997 2019-06-25  Tom Tromey  <tom@tromey.com>
4998
4999         * tui/tui-layout.c (init_and_make_win): Use new.
5000         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5001         destructor, initializers.
5002         (tui_alloc_generic_win_info): Don't declare.
5003         * tui/tui-data.c (_locator): Add argument to constructor.
5004         (source_win, disasm_win): New globals.
5005         (exec_info): Remove.
5006         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5007         Update.
5008         (tui_alloc_generic_win_info): Remove.
5009         (init_content_element): Use new.
5010         (tui_win_info::tui_win_info): Update.
5011         (free_content_elements) <case DATA_WIN>: Use delete.
5012
5013 2019-06-25  Tom Tromey  <tom@tromey.com>
5014
5015         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5016         * tui/tui-windata.c (tui_first_data_item_displayed)
5017         (tui_delete_data_content_windows): Update.
5018         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5019         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5020         (tui_display_registers_from, tui_check_register_values): Update.
5021         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5022         pointer.
5023         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5024         window.
5025         (tui_free_data_content): Update.
5026         (free_content_elements) <case DATA_WIN>: Free the window.
5027
5028 2019-06-25  Tom Tromey  <tom@tromey.com>
5029
5030         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5031         Update.
5032         * tui/tui-layout.c (make_command_window)
5033         (show_source_disasm_command, show_data, init_and_make_win)
5034         (show_source_or_disasm_and_command): Update.
5035         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5036         method.
5037         <can_highight, is_highlighted>: Now bool.
5038         (tui_set_win_highlight): Don't declare.
5039         * tui/tui-data.c (tui_set_win_highlight): Remove.
5040
5041 2019-06-25  Tom Tromey  <tom@tromey.com>
5042
5043         * tui/tui-wingeneral.c (make_visible): Remove check of window
5044         type.
5045
5046 2019-06-25  Tom Tromey  <tom@tromey.com>
5047
5048         * tui/tui-win.c (tui_win_info::max_height)
5049         (tui_cmd_window::max_height): New methods.
5050         (new_height_ok): Call max_height.
5051         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5052         <max_height>: New method.
5053
5054 2019-06-25  Tom Tromey  <tom@tromey.com>
5055
5056         * tui/tui-win.c (tui_source_window_base::set_new_height)
5057         (tui_data_window::set_new_height): New methods.
5058         (make_invisible_and_set_new_height): Call set_new_height method.
5059         * tui/tui-data.h (struct tui_win_info)
5060         (struct tui_source_window_base, struct tui_data_window)
5061         <set_new_height>: New method.
5062
5063 2019-06-25  Tom Tromey  <tom@tromey.com>
5064
5065         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5066         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5067         tui_refresh_data_win.
5068         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5069         method.
5070         (tui_refresh_all_win): Call the refresh_all method.
5071         (tui_set_focus): Likewise.
5072         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5073         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5074         Likewise.
5075
5076 2019-06-25  Tom Tromey  <tom@tromey.com>
5077
5078         * tui/tui-winsource.h (tui_refill_source_window)
5079         (tui_set_is_exec_point_at): Don't declare.
5080         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5081         (tui_source_window_base::refill): Rename from
5082         tui_refill_source_window.
5083         (tui_source_window_base::do_scroll_horizontal): Update.
5084         (tui_source_window_base::set_is_exec_point_at): Rename from
5085         tui_set_is_exec_point_at.
5086         (tui_update_all_breakpoint_info): Update.
5087         * tui/tui-stack.c (tui_show_frame_info): Update.
5088         * tui/tui-layout.c (show_data): Add cast.
5089         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5090         * tui/tui-data.h (struct tui_source_window_base) <refill,
5091         set_is_exec_point_at>: New methods.
5092         (tui_source_windows, tui_add_to_source_windows): Update types.
5093         (tui_add_to_source_windows): Remove redundant declaration.
5094         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5095         (tui_source_windows): Change return type.
5096         (tui_clear_source_windows_detail): Update.
5097         (tui_add_to_source_windows): Change type of parameter.
5098         (tui_free_all_source_wins_content): Update.
5099
5100 2019-06-25  Tom Tromey  <tom@tromey.com>
5101
5102         * tui/tui-wingeneral.c (tui_win_info::refresh)
5103         (tui_source_window_base::refresh): New methods.
5104         (tui_refresh_all): Call the refresh method.
5105         * tui/tui-data.h (struct tui_win_info)
5106         (struct tui_source_window_base) <refresh>: New method.
5107
5108 2019-06-25  Tom Tromey  <tom@tromey.com>
5109
5110         * tui/tui.h (tui_is_window_visible): Return bool.
5111         * tui/tui.c (tui_is_window_visible): Return bool.
5112         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5113         (tui_make_visible, tui_make_invisible)
5114         (tui_win_info::make_visible)
5115         (tui_source_window_base::make_visible, make_all_visible)
5116         (tui_make_all_visible, tui_make_all_invisible): Update.
5117         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5118         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5119         bool.
5120         (struct tui_win_info, struct tui_source_window_base)
5121         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5122         * tui/tui-data.c (tui_init_generic_part): Update.
5123
5124 2019-06-25  Tom Tromey  <tom@tromey.com>
5125
5126         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5127         (tui_source_window_base::make_visible): New methods.
5128         (make_all_visible): Make method call.
5129         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5130         (struct tui_source_window_base, struct tui_cmd_window): Override
5131         make_visible.
5132         (tui_win_is_source_type): Don't declare.
5133         * tui/tui-data.c (tui_win_is_source_type): Remove.
5134
5135 2019-06-25  Tom Tromey  <tom@tromey.com>
5136
5137         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5138         NULL check.
5139
5140 2019-06-25  Tom Tromey  <tom@tromey.com>
5141
5142         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5143         Inline constructor.  Add initializers for members.
5144         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5145         constructors; now inline in class.
5146
5147 2019-06-25  Tom Tromey  <tom@tromey.com>
5148
5149         * tui/tui-regs.c (tui_show_registers): Update.
5150         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5151         bool.
5152         * tui/tui-data.c (tui_data_window::clear_detail)
5153         (tui_data_window): Update.
5154
5155 2019-06-25  Tom Tromey  <tom@tromey.com>
5156
5157         * tui/tui-windata.c (tui_display_all_data)
5158         (tui_display_data_from_line, tui_display_data_from)
5159         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5160         Update.
5161         * tui/tui-regs.c (tui_last_regs_line_no)
5162         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5163         (tui_show_registers, tui_show_register_group)
5164         (tui_display_registers_from, tui_display_reg_element_at_line)
5165         (tui_display_registers_from_line, tui_check_register_values)
5166         (tui_reg_next, tui_reg_prev): Update.
5167         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5168         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5169         tui_data_window.
5170         (struct tui_win_info) <detail>: Remove.  Add new fields from
5171         tui_data_info.
5172         (TUI_DATA_WIN): Add cast.
5173         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5174         (~tui_data_window): Simplify.
5175
5176 2019-06-25  Tom Tromey  <tom@tromey.com>
5177
5178         * tui/tui-layout.c (show_source_disasm_command)
5179         (show_source_or_disasm_and_command): Update.
5180         * tui/tui-io.c (update_cmdwin_start_line)
5181         (tui_redisplay_readline): Update.
5182         * tui/tui-data.h (struct tui_command_info): Remove.
5183         (struct tui_win_info) <detail>: Remove command_info member.
5184         (struct tui_data_window) <start_line>: New member, from
5185         tui_command_info.
5186         (TUI_CMD_WIN): Add casts.
5187
5188 2019-06-25  Tom Tromey  <tom@tromey.com>
5189
5190         * tui/tui-winsource.c (tui_update_source_window)
5191         (tui_refill_source_window)
5192         (tui_source_window_base::do_scroll_horizontal)
5193         (tui_update_breakpoint_info, tui_set_exec_info_content)
5194         (tui_show_exec_info_content, tui_erase_exec_info_content)
5195         (tui_clear_exec_info_content): Update.
5196         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5197         Update.
5198         * tui/tui-win.c (make_invisible_and_set_new_height)
5199         (make_visible_with_new_height): Update.
5200         * tui/tui-source.c (tui_set_source_content)
5201         (tui_show_symtab_source): Update.
5202         * tui/tui-layout.c (extract_display_start_addr)
5203         (show_source_disasm_command, show_data)
5204         (make_source_or_disasm_window)
5205         (show_source_or_disasm_and_command): Update.
5206         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5207         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5208         "gdbarch".
5209         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5210         to tui_source_window_base.
5211         (struct tui_win_info) <detail>: Remove source_info member.
5212         (struct tui_source_window_base) <has_locator>: Inline.
5213         Move contents from tui_source_info; rename has_locator member to
5214         m_has_locator.
5215         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5216         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5217         header file.
5218         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5219         Simplify.
5220         (tui_free_all_source_wins_content): Cast to
5221         tui_source_window_base.
5222
5223 2019-06-25  Tom Tromey  <tom@tromey.com>
5224
5225         * tui/tui-win.c (make_invisible_and_set_new_height)
5226         (make_visible_with_new_height): Call has_locator method.
5227         * tui/tui-layout.c (show_source_disasm_command, show_data)
5228         (show_source_or_disasm_and_command): Update for bool change.
5229         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5230         (tui_win_info) <has_locator>: New method.
5231         (struct tui_source_window_base) <has_locator>: New method.
5232         (tui_win_has_locator): Don't declare.
5233         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5234         from tui_win_has_locator.
5235         (tui_source_window_base): Use false, not FALSE.
5236
5237 2019-06-25  Tom Tromey  <tom@tromey.com>
5238
5239         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5240         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5241         clear_detail method directly.
5242         (tui_clear_win_detail): Remove.
5243
5244 2019-06-25  Tom Tromey  <tom@tromey.com>
5245
5246         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5247         "this", not TUI_DISASM_WIN.
5248
5249 2019-06-25  Tom Tromey  <tom@tromey.com>
5250
5251         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5252         declare.
5253         * tui/tui-winsource.c
5254         (tui_source_window_base::do_scroll_horizontal): Rename from
5255         tui_horizontal_source_scroll.
5256         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5257         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5258         from tui_vertical_data_scroll.
5259         * tui/tui-win.h (tui_scroll): Don't declare.
5260         * tui/tui-win.c (tui_win_info::forward_scroll)
5261         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5262         (tui_win_info::right_scroll): Rename and update.
5263         (tui_scroll_forward_command, tui_scroll_backward_command)
5264         (tui_scroll_left_command, tui_scroll_right_command): Update.
5265         (tui_scroll): Remove.
5266         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5267         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5268         from tui_vertical_source_scroll.
5269         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5270         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5271         from tui_vertical_disassem_scroll.
5272         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5273         do_scroll_horizontal>: New methods.
5274         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5275         Likewise.
5276         (struct tui_source_window_base): Add do_scroll_horizontal.
5277         (struct tui_source_window, struct tui_disasm_window): Add
5278         do_scroll_vertical.
5279         (struct tui_data_window, struct tui_cmd_window): Add
5280         do_scroll_horizontal and do_scroll_vertical.
5281         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5282
5283 2019-06-25  Tom Tromey  <tom@tromey.com>
5284
5285         * tui/tui-data.h (struct tui_source_window_base): New struct.
5286         (struct tui_source_window): Derive from tui_source_window_base.
5287         (struct tui_disasm_window): New struct.
5288         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5289         from tui_source_window::clear_detail.
5290         (tui_source_window_base): Rename from tui_source_window.
5291         (~tui_source_window_base): Rename from ~tui_source_window.
5292         (tui_alloc_win_info): Create a tui_disasm_window.
5293
5294 2019-06-25  Tom Tromey  <tom@tromey.com>
5295
5296         * tui/tui-data.h (struct tui_source_window)
5297         (struct tui_data_window): Declare destructors.
5298         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5299         destructors.
5300         (tui_win_info): Simplify.
5301
5302 2019-06-25  Tom Tromey  <tom@tromey.com>
5303
5304         * tui/tui-winsource.c (tui_display_main)
5305         (tui_update_source_windows_with_addr)
5306         (tui_update_all_breakpoint_info): Update.
5307         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5308         (new_height_ok, parse_scrolling_args): Update.
5309         * tui/tui-stack.c (tui_show_frame_info): Update.
5310         * tui/tui-data.h (struct tui_list): Remove.
5311         (tui_source_windows): Return a reference to a std::vector.
5312         * tui/tui-data.c (source_windows): Now a std::vector.
5313         (tui_source_windows): Change return type.
5314         (tui_clear_source_windows): Rewrite.
5315         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5316         (tui_free_all_source_wins_content): Rewrite.
5317
5318 2019-06-25  Tom Tromey  <tom@tromey.com>
5319
5320         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5321         (struct tui_data_window, struct tui_cmd_window): Declare
5322         clear_detail method.
5323         * tui/tui-data.c (tui_source_window::clear_detail)
5324         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5325         methods.
5326         (tui_clear_win_detail): Simplify.
5327
5328 2019-06-25  Tom Tromey  <tom@tromey.com>
5329
5330         * tui/tui-layout.c (make_source_window, make_disasm_window)
5331         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5332         Return the new window.
5333         (show_source_disasm_command, show_data)
5334         (show_source_or_disasm_and_command): Update.
5335
5336 2019-06-25  Tom Tromey  <tom@tromey.com>
5337
5338         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5339         parameter.  Return the new window.
5340         (show_source_disasm_command): Update and remove NULL check.
5341         (show_source_or_disasm_and_command): Update.
5342
5343 2019-06-25  Tom Tromey  <tom@tromey.com>
5344
5345         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5346
5347 2019-06-25  Tom Tromey  <tom@tromey.com>
5348
5349         * tui/tui-data.h (struct tui_win_info): Make constructor
5350         protected.  Make destructor virtual.  Add initializers.
5351         (tui_source_window, tui_data_window, tui_cmd_window): New
5352         classes.
5353         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5354         constructor.  Add "type" parameter.
5355         (tui_source_window, tui_data_window, tui_cmd_window): New
5356         constructors.
5357         (tui_alloc_win_info): Instantiate the appropriate subclass.
5358
5359 2019-06-25  Tom Tromey  <tom@tromey.com>
5360
5361         * tui/tui-win.c (tui_resize_all): Use delete.
5362         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5363         destructor.
5364         (tui_free_window): Don't declare.
5365         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5366         Update.
5367
5368 2019-06-25  Tom Tromey  <tom@tromey.com>
5369
5370         * tui/tui-data.h (struct tui_win_info): Add constructor.
5371         * tui/tui-data.c (tui_alloc_win_info): Use new.
5372         (tui_free_window): Use delete.
5373
5374 2019-06-22  Tom Tromey  <tom@tromey.com>
5375
5376         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5377         declare.
5378         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5379
5380 2019-06-22  Tom Tromey  <tom@tromey.com>
5381
5382         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5383         declare.
5384         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5385
5386 2019-06-22  Tom de Vries  <tdevries@suse.de>
5387
5388         * dwarf2read.c (create_addrmap_from_aranges)
5389         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5390         instead of '%zu'.
5391
5392 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5393
5394         * dwarf2read.h (dwarf2_section_info_def): Remove.
5395         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5396         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5397         std::vector<dwarf2_section_info>.
5398         (struct dwo_file) <~dwo_file>: Remove.
5399         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5400         types field.
5401         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5402         (dwarf2_read_debug_names): Likewise.
5403         (create_debug_types_hash_table): Change parameter type to
5404         array_view, adjust code accordingly.
5405         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5406         (partial_die_info::fixup): Likewise.
5407         (determine_prefix): Likewise.
5408         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5409
5410 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5411
5412         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5413         gdb_bfd_ref_ptr.
5414         <~dwo_file>: Remove call to gdb_bfd_unref.
5415         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5416         gdb_bfd_ref_ptr::get.
5417
5418 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5419
5420         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5421         type to htab_up.
5422         * dwarf2read.c (struct dwo_file): Initialize fields.
5423         <~dwo_file>: New.
5424         (free_dwo_file): Remove, move content to ~dwo_file.
5425         (struct dwo_file_deleter): Remove.
5426         (dwo_file_up>: Remove custom deleter.
5427         (free_dwo_files): Remove.
5428         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5429         dwo_files.
5430         (process_skeletonless_type_units): Call unique_ptr::get.
5431         (allocate_dwo_file_hash_table): Add deleter to created hash
5432         table.  Change return type to htab_up.
5433         (lookup_dwo_file_slot): Don't memset dwo_file, call
5434         unique_ptr::get.
5435         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5436         (create_dwo_unit_in_dwp_v2): Likewise.
5437         (open_and_init_dwo_file): Likewise.
5438         (free_dwo_file_from_slot): Remove.
5439
5440 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5441
5442         * dwarf2read.h (struct dwarf2_section_info) <readin,
5443         is_virtual>: Change type to bool.
5444         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5445         true instead of 1.
5446
5447 2019-06-19  Tom Tromey  <tom@tromey.com>
5448
5449         * tui/tui-data.h (tui_init_content_element): Don't declare.
5450
5451 2019-06-19  Tom Tromey  <tom@tromey.com>
5452
5453         * tui/tui-data.h (tui_init_win_info): Don't declare.
5454
5455 2019-06-19  Tom de Vries  <tdevries@suse.de>
5456
5457         * dwarf2read.h (abstract_to_concrete): Change type to
5458         std::unordered_map<sect_offset, std::vector<sect_offset>,
5459         gdb::hash_enum<sect_offset>>.
5460
5461 2019-06-19  Tom Tromey  <tromey@adacore.com>
5462
5463         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5464         EVAL_AVOID_SIDE_EFFECTS specially.
5465
5466 2019-06-19  Tom Tromey  <tromey@adacore.com>
5467
5468         * source-cache.c (highlighter): New global.
5469         (source_cache::get_source_lines): Create a highlighter on demand.
5470
5471 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5472
5473         * defs.h (deprecated_interactive_hook): Delete declaration.
5474         * interps.c (clear_interpreter_hooks): Remove use of
5475         deprecated_interactive_hook.
5476         * top.c (deprecated_interactive_hook): Delete definition.
5477         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5478
5479 2019-06-18  Tom de Vries  <tdevries@suse.de>
5480
5481         PR gdb/24515
5482         * dwarf2read.h (abstract_to_concrete): Change type from
5483         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5484         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5485         * dwarf2read.c (read_variable): Update.
5486         (dwarf2_fetch_die_loc_sect_off): Update.
5487
5488 2019-06-17  Tom de Vries  <tdevries@suse.de>
5489
5490         PR gdb/24617
5491         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5492         accessing parent[parent_len - 1].
5493
5494 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5495
5496         PR gdb/24364
5497         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5498         call dtrace_process_dof with NULL dof.
5499
5500 2019-06-16  Tom de Vries  <tdevries@suse.de>
5501
5502         PR gdb/24445
5503         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5504
5505 2019-06-16  Tom Tromey  <tom@tromey.com>
5506
5507         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5508         (make_all_visible): Use address of member.
5509
5510 2019-06-16  Tom Tromey  <tom@tromey.com>
5511
5512         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5513         (tui_free_window, free_content, free_content_elements): Remove
5514         unnecessary cast.
5515         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5516         cast.
5517         * tui/tui-regs.c (tui_show_register_group)
5518         (tui_display_registers_from, tui_display_reg_element_at_line):
5519         Remove unnecessary cast.
5520
5521 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5522
5523         * linux-nat.c (normal_mask): Delete.
5524         (_initialize_linux_nat): Don't initialise normal_mask.
5525
5526 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5527
5528         PR gdb/24445
5529         * dwarf-index-write.h (write_psymtabs_to_index): Add
5530         dwz_basename parameter.
5531         * dwarf-index-write.c (write_gdbindex): Move file writing to
5532         write_gdbindex_1.  Change return type void.
5533         (assert_file_size): Move up, remove filename parameter.
5534         (write_gdbindex_1): New function.
5535         (write_debug_names): Change return type to void, call
5536         assert_file_size.
5537         (struct index_wip_file): New struct.
5538         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5539         file logic to index_wip_file.  Write index for dwz file if
5540         needed.
5541         (save_gdb_index_command): Pass basename of dwz file, if present.
5542         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5543         build-id of dwz file, if present.
5544         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5545         (dwarf2_get_dwz_file): Likewise.
5546         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5547         (dwarf2_get_dwz_file): Likewise.
5548
5549 2019-06-16  Tom Tromey  <tom@tromey.com>
5550
5551         * coffread.c (process_coff_symbol): Use xstrdup.
5552         * value.c (create_internalvar): Use xstrdup.
5553
5554 2019-06-16  Tom Tromey  <tom@tromey.com>
5555
5556         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5557         * breakpoint.c (stopin_command, stopat_command)
5558         (until_break_command, decode_location_default): Remove unnecessary
5559         cast.
5560         * utils.c (subset_compare): Remove unnecessary cast.
5561         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5562         cast.
5563         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5564         cast.
5565         * infcmd.c (path_command): Remove unnecessary cast.
5566         * coffread.c (decode_type): Remove unnecessary cast.
5567         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5568         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5569         * tui/tui-stack.c (tui_show_locator_content)
5570         (tui_show_frame_info): Remove unnecessary cast.
5571         * tui/tui-win.c (tui_scroll_forward_command)
5572         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5573         (parse_scrolling_args): Remove unnecessary cast.
5574         * tui/tui-data.c (init_win_info, tui_del_window)
5575         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5576         (free_content_elements): Remove unnecessary cast.
5577         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5578         unnecessary cast.
5579         * tui/tui-source.c (tui_set_source_content)
5580         (tui_vertical_source_scroll): Remove unnecessary cast.
5581         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5582         cast.
5583         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5584         * tui/tui-regs.c (tui_display_registers_from)
5585         (tui_display_register): Remove unnecessary cast.
5586         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5587         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5588         (make_visible): Remove unnecessary cast.
5589         * tui/tui-winsource.c (tui_erase_source_content)
5590         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5591         unnecessary cast.
5592         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5593         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5594         * stabsread.c (read_type, read_array_type, read_range_type):
5595         Remove unnecessary cast.
5596         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5597         (parse_symbol, parse_type, upgrade_type, parse_external)
5598         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5599         unnecessary cast.
5600         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5601
5602 2019-06-16  Tom Tromey  <tom@tromey.com>
5603
5604         * tui/tui-data.c (tui_alloc_generic_win_info)
5605         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5606         checks.
5607
5608 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5609             Andrew Burgess  <andrew.burgess@embecosm.com>
5610
5611         * f-typeprint.c (f_print_type): Don't return early for not
5612         associated or not allocated types.
5613         (f_type_print_varspec_suffix): Add print_rank parameter and print
5614         ranks of array types in case they dangling.
5615         (f_type_print_base): Add print_rank parameter.
5616
5617 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5618
5619         * NEWS: Mention new MI commands.
5620         * break-catch-throw.c (enum exception_event_kind): Move to
5621         breakpoint.h.
5622         (print_mention_exception_catchpoint): Output text as a single
5623         message.
5624         (catch_exception_command_1): Rename to...
5625         (catch_exception_event): ...this, make non-static, update header
5626         command, and change some parameter types.
5627         (catch_catch_command): Update for changes to
5628         catch_exception_command_1.
5629         (catch_throw_command): Likewise.
5630         (catch_rethrow_command): Likewise.
5631         * breakpoint.c (enum exception_event_kind): Delete.
5632         * breakpoint.h (enum exception_event_kind): Moved here from
5633         break-catch-throw.c.
5634         (catch_exception_event): Declare.
5635         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5636         (mi_cmd_catch_throw): New function.
5637         (mi_cmd_catch_rethrow): New function.
5638         (mi_cmd_catch_catch): New function.
5639         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5640         'catch-catch' entries.
5641         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5642         (mi_cmd_catch_rethrow): Declare.
5643         (mi_cmd_catch_catch): Declare.
5644
5645 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5646
5647         * annotate.c (annotate_source_line): Change return type to void,
5648         update implementation to match.
5649         * annotate.h (annotate_source_line): Change return type to void,
5650         update header comment.
5651         * stack.c (print_frame_info): Don't change what frame information
5652         is printed based on whether annotations are on or not.
5653
5654 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5655
5656         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5657         (annotate_source): Make static.
5658         (annotate_source_line): Moved from source.c and renamed from
5659         identify_source_line.  Update the return type.
5660         * annotate.h (annotate_source): Delete declaration.
5661         (annotate_source_line): Declaration moved from source.h, and
5662         renamed from identify_source_line.  Return type updated.
5663         * source.c (identify_source_line): Moved to annotate.c and renamed
5664         to annotate_source_line.
5665         (info_line_command): Remove check of annotation_level.
5666         * source.h (identify_source_line): Move declaration to annotate.h
5667         and rename to annotate_source_line.
5668         * stack.c: Add 'annotate.h' include.
5669         (print_frame_info): Remove check of annotation_level before
5670         calling annotate_source_line.
5671
5672 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5673
5674         * source-cache.c (source_cache::get_plain_source_lines): Use
5675         open_source_file_with_line_charpos instead of just
5676         open_source_file, remove call to find_source_lines.
5677         (source_cache::get_source_lines): Likewise.
5678         * source.c (find_source_lines): Make static.
5679         (get_filename_and_charpos): Renamed into...
5680         (open_source_file_with_line_charpos): ..this along with changes to
5681         return a scoped_fd, and some other minor clean ups.
5682         (identify_source_line): Use open_source_file_with_line_charpos.
5683         (search_command_helper): Use open_source_file_with_line_charpos
5684         instead of just open_source_file, remove call to
5685         find_source_lines.
5686         * source.h (open_source_file_with_line_charpos): Declare new
5687         function.
5688         (find_source_lines): Delete declaration.
5689
5690 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5691
5692         * source.c (get_filename_and_charpos): Remove fullname
5693         parameter.
5694         (identify_source_line): Update call to get_filename_and_charpos.
5695
5696 2019-06-14  Tom Tromey  <tromey@adacore.com>
5697
5698         PR gdb/24502:
5699         * ui-style.h (skip_ansi_escape): Update comment.
5700         * ui-file.h (class no_terminal_escape_file): New class.
5701         * ui-file.c (no_terminal_escape_file::write)
5702         (no_terminal_escape_file::puts): New methods.
5703         * cli/cli-logging.c (handle_redirections): Use
5704         no_terminal_escape_file.
5705
5706 2019-06-14  Tom Tromey  <tromey@adacore.com>
5707
5708         * NEWS: Move convenience variable news above Python news.
5709
5710 2019-06-14  Tom Tromey  <tom@tromey.com>
5711
5712         * gnulib: Move directory to top-level.
5713         * configure.ac: Don't configure gnulib.
5714         * configure: Rebuild.
5715         * common/common-defs.h: Use new path to gnulib.
5716         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5717         (GNULIB_H): Remove.
5718         (INCGNU): Look in new gnulib location.
5719         (HFILES_NO_SRCDIR): Remove gnulib files.
5720         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5721         (generated_files): Remove GNULIB_H.
5722         ($(LIBGNU), all-lib): Remove targets.
5723         (distclean): Don't mention GNULIB_BUILDDIR.
5724         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5725
5726 2019-06-14  Tom Tromey  <tromey@adacore.com>
5727
5728         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5729         Warn if symbol file does not provide any symbols.
5730
5731 2019-06-14  Tom Tromey  <tromey@adacore.com>
5732
5733         * source.c (find_and_open_source): Respect basenames_may_differ.
5734
5735 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5736
5737         * annotate.c (annotate_breakpoints_invalid): Make use of
5738         scoped_restore_terminal_state.
5739         (annotate_frames_invalid): Likewise.
5740
5741 2019-06-14  Tom Tromey  <tromey@adacore.com>
5742
5743         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5744         allow assignment to an internalvar.
5745
5746 2019-06-14  Tom Tromey  <tromey@adacore.com>
5747
5748         * ada-lex.l: Allow "_" in attribute names.
5749
5750 2019-06-14  Tom Tromey  <tromey@adacore.com>
5751
5752         PR gdb/24653:
5753         * regcache.c (registers_changed): Don't call alloca.
5754         * top.c (execute_command): Don't call alloca.
5755
5756 2019-06-13  Pedro Alves  <palves@redhat.com>
5757
5758         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5759         'expression'.  When parsing an expression, error out if there's
5760         junk after "unlimited".
5761         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5762         (do_set_command): Adjust calls to is_unlimited_literal.
5763
5764 2019-06-13  Pedro Alves  <palves@redhat.com>
5765
5766         * compile/compile.c (make_compile_options_def_group): Add braces
5767         around array_view initializer.
5768         * thread.c (make_thread_apply_all_options_def_group)
5769         (make_thread_apply_all_options_def_group): Likewise.
5770
5771 2019-06-13  Pedro Alves  <palves@redhat.com>
5772
5773         * NEWS (New commands): Mention "maint test-options
5774         require-delimiter", "maint test-options unknown-is-error", "maint
5775         test-options unknown-is-operand" and "maint show
5776         test-options-completion-result".
5777         (New command options, command completion): New section.
5778         (Completion improvements): New section.
5779         Mention that you can abbreviate "unlimited".
5780
5781 2019-06-13  Pedro Alves  <palves@redhat.com>
5782
5783         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5784         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5785         * unittests/cli-utils-selftests.c (test_parse_flags)
5786         (test_parse_flags_qcs): Delete.
5787         (test_cli_utils): Don't call deleted functions.
5788
5789 2019-06-13  Pedro Alves  <palves@redhat.com>
5790
5791         * thread.c: Include "cli/cli-option.h".
5792         (tp_array_compar_ascending): Global.
5793         (tp_array_compar): Delete function.
5794         (tp_array_compar_ascending, tp_array_compar_descending): New
5795         functions.
5796         (ascending_option_def, qcs_flag_option_def)
5797         (thr_qcs_flags_option_defs)
5798         (make_thread_apply_all_options_def_group)
5799         (make_thread_apply_options_def_group): New.
5800         (thread_apply_all_command): Use gdb::option::process_options.
5801         (thread_apply_command_completer)
5802         (thread_apply_all_command_completer): New.
5803         (thread_apply_command): Use gdb::option::process_options.
5804         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5805         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5806         to generate help text of "thread apply".  Adjust "taas"'s help.
5807         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5808         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5809
5810 2019-06-13  Pedro Alves  <palves@redhat.com>
5811
5812         * thread.c (thread_apply_command): Check for invalid TID with
5813         isdigit instead of !isalpha.
5814
5815 2019-06-13  Pedro Alves  <palves@redhat.com>
5816
5817         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5818         (validate_flags_qcs): New.
5819         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5820         (validate_flags_qcs): Declare.
5821         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5822         (make_frame_apply_options_def_group): New.
5823         (frame_apply_command_count): Process options with
5824         gdb::option::process_options.
5825         (frame_apply_completer): New.
5826         (frame_apply_level_completer, frame_apply_all_completer)
5827         (frame_apply_completer): New.
5828         (_initialize_stack): Update help of "frame apply", "frame apply
5829         level", "frame apply all" and "faas" to mention supported options
5830         and install command completers.
5831         * stack.h (frame_apply_all_completer): Declare.
5832         * thread.c: Include "stack.h".
5833         (tfaas_command): Add "--".
5834         (_initialize_thread): Update help "tfaas" to mention supported
5835         options and install command completer.
5836
5837 2019-06-13  Pedro Alves  <palves@redhat.com>
5838
5839         * completer.c (complete_nested_command_line): New.
5840         (gdb_completion_word_break_characters_throw): Add assertion.
5841         * completer.h (complete_nested_command_line): Declare.
5842
5843 2019-06-13  Pedro Alves  <palves@redhat.com>
5844
5845         * stack.c (parse_backtrace_qualifiers): New.
5846         (backtrace_command): Use it.
5847         (backtrace_command_completer): Complete on qualifiers.
5848
5849 2019-06-13  Pedro Alves  <palves@redhat.com>
5850
5851         * frame.c: Include "cli/cli-option.h.
5852         (user_set_backtrace_options): New.
5853         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5854         Delete.
5855         (get_prev_frame): Adjust.
5856         (boolean_option_def, uinteger_option_def)
5857         (set_backtrace_option_defs): New.
5858         (_initialize_frame): Adjust and use
5859         gdb::option::add_setshow_cmds_for_options to install "set
5860         backtrace past-main" and "set backtrace past-entry".
5861         * frame.h: Include "cli/cli-option.h".
5862         (struct frame_print_options): Forward declare.
5863         (print_frame_arguments_all, print_frame_arguments_scalars)
5864         (print_frame_arguments_none): Declare.
5865         (print_entry_values): Delete declaration.
5866         (struct frame_print_options, user_frame_print_options): New.
5867         (struct set_backtrace_options): New.
5868         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5869         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5870         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5871         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5872         (list_args_or_locals): Add frame_print_options parameter.
5873         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5874         * python/py-framefilter.c (enumerate_args): Pass down
5875         USER_FRAME_PRINT_OPTIONS.
5876         * stack.c: Include "cli/cli-option.h".
5877         (print_frame_arguments_all, print_frame_arguments_scalars)
5878         (print_frame_arguments_none): Declare.
5879         (print_raw_frame_arguments, print_entry_values): Delete.
5880         (user_frame_print_options): New.
5881         (boolean_option_def, enum_option_def, frame_print_option_defs):
5882         New.
5883         (struct backtrace_cmd_options): New.
5884         (bt_flag_option_def): New.
5885         (backtrace_command_option_defs): New.
5886         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5887         (print_frame_arg, read_frame_arg, print_frame_args)
5888         (print_frame_info, print_frame): Add frame_print_options parameter
5889         and use it.
5890         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5891         (backtrace_command_1): Add frame_print_options and
5892         backtrace_cmd_options parameters and use them.
5893         (make_backtrace_options_def_group): New.
5894         (backtrace_command): Process command options with
5895         gdb::option::process_options.
5896         (backtrace_command_completer): New.
5897         (_initialize_stack): Extend "backtrace"'s help to mention
5898         supported options.  Install completer for "backtrace".
5899         Install some settings commands with add_setshow_cmds_for_options.
5900
5901 2019-06-13  Pedro Alves  <palves@redhat.com>
5902
5903         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5904         and that "set/show print raw frame-arguments" are now deprecated.
5905
5906         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5907         command.
5908         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5909         * stack.c (_initialize_stack): Install "set/show print
5910         raw-frame-arguments", and deprecate "set/show print raw
5911         frame-arguments".
5912         * valprint.c (_initialize_valprint): Deprecate "set/show print
5913         raw".
5914
5915 2019-06-13  Pedro Alves  <palves@redhat.com>
5916
5917         * compile/compile.c (struct compile_options): New.
5918         (compile_flag_option_def, compile_command_option_defs)
5919         (make_compile_options_def_group): New.
5920         (compile_file_command): Handle options with
5921         gdb::option::process_options.
5922         (compile_file_command_completer): New function.
5923         (compile_code_command): Handle options with
5924         gdb::option::process_options.
5925         (compile_code_command_completer): New function.
5926         (_initialize_compiler): Install completers for "compile code" and
5927         "compile file".  Mention available options in "compile code" and
5928         "compile code"'s help.
5929         * completer.c (advance_to_completion_word): New, factored out from
5930         ...
5931         (advance_to_expression_complete_word_point): ... this.
5932         (advance_to_filename_complete_word_point): New.
5933         * completer.h (advance_to_filename_complete_word_point): New
5934         declaration.
5935
5936 2019-06-13  Pedro Alves  <palves@redhat.com>
5937
5938         * compile/compile.c: Include "cli/cli-option.h".
5939         (compile_print_value): Scope data pointer is now a
5940         value_print_options pointer; adjust.
5941         (compile_print_command): Process options.  Scope data pointer is
5942         now a value_print_options pointer; adjust.
5943         (_initialize_compile): Update "compile print"'s help to include
5944         supported options.  Install a completer for "compile print".
5945         * cp-valprint.c (show_vtblprint, show_objectprint)
5946         (show_static_field_print): Delete.
5947         (_initialize_cp_valprint): Don't install "set print
5948         static-members", "set print vtbl", "set print object" here.
5949         * printcmd.c: Include "cli/cli-option.h" and
5950         "common/gdb_optional.h".
5951         (print_command_parse_format): Rework to fill in a
5952         value_print_options instead of a format_data.
5953         (print_value): Change parameter type from format_data pointer to
5954         value_print_options reference.  Adjust.
5955         (print_command_1): Process options.  Adjust to pass down a
5956         value_print_options.
5957         (print_command_completer): New.
5958         (_initialize_printcmd): Install print_command_completer as
5959         handle_brkchars completer for the "print" command.  Update
5960         "print"'s help to include supported options.
5961         * valprint.c: Include "cli/cli-option.h".
5962         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5963         here from cp-valprint.c.
5964         (boolean_option_def, uinteger_option_def)
5965         (value_print_option_defs, make_value_print_options_def_group):
5966         New.  Use gdb::option::add_setshow_cmds_for_options to install
5967         "set print elements", "set print null-stop", "set print repeats",
5968         "set print pretty", "set print union", "set print array", "set
5969         print address", "set print symbol", "set print array-indexes".
5970         * valprint.h: Include <string> and "cli/cli-option.h".
5971         (make_value_print_options_def_group): Declare.
5972         (print_value): Change parameter type from format_data pointer to
5973         value_print_options reference.
5974         (print_command_completer): Declare.
5975
5976 2019-06-13  Pedro Alves  <palves@redhat.com>
5977
5978         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5979         (COMMON_SFILES): Add maint-test-settings.c.
5980         * cli/cli-decode.c (boolean_enums): New global, factored out from
5981         ...
5982         (add_setshow_boolean_cmd): ... here.
5983         * cli/cli-decode.h (boolean_enums): Declare.
5984         * cli/cli-option.c: New file.
5985         * cli/cli-option.h: New file.
5986         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5987         factored out from ...
5988         (parse_cli_boolean_value(const char *)): ... this.
5989         (is_unlimited_literal): Change parameter type to pointer to
5990         pointer.  Adjust and advance ARG pointer.
5991         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5992         (parse_cli_var_enum): New, factored out from ...
5993         (do_set_command): ... this.  Adjust.
5994         * cli/cli-setshow.h (parse_cli_boolean_value)
5995         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5996         (parse_cli_var_enum): Declare.
5997         * cli/cli-utils.c: Include "cli/cli-option.h".
5998         (get_ulongest): New.
5999         * cli/cli-utils.h (get_ulongest): Declare.
6000         (check_for_argument): New overloads.
6001         * maint-test-options.c: New file.
6002
6003 2019-06-13  Pedro Alves  <palves@redhat.com>
6004
6005         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6006         parse a range if "-" is at the end of the string.
6007
6008 2019-06-13  Pedro Alves  <palves@redhat.com>
6009
6010         * cli/cli-setshow.c (parse_auto_binary_operation)
6011         (parse_cli_boolean_value): Don't allow "o".
6012
6013 2019-06-13  Pedro Alves  <palves@redhat.com>
6014
6015         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6016         * NEWS: Mention maint test-settings KIND.
6017         * maint-test-settings.c: New file.
6018
6019 2019-06-13  Pedro Alves  <palves@redhat.com>
6020
6021         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6022         completer.
6023         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6024         "set" completers.
6025
6026 2019-06-13  Pedro Alves  <palves@redhat.com>
6027
6028         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6029         after item.
6030
6031 2019-06-13  Pedro Alves  <palves@redhat.com>
6032
6033         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6034
6035 2019-06-13  Pedro Alves <palves@redhat.com>
6036
6037         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6038         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6039         call.
6040         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6041         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6042         calls.
6043         (check_for_argument): Skip spaces after argument.
6044
6045 2019-06-13  Pedro Alves  <palves@redhat.com>
6046
6047         * thread.c (thread_apply_command): Adjust TID parsing.
6048         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6049         detected before end of string.
6050         (tid_is_in_list): Error out if LIST is invalid.
6051
6052 2019-06-13  Pedro Alves  <palves@redhat.com>
6053
6054         * completer.c (complete_line_internal_1): Rewind completion word
6055         point.
6056         (completion_tracker::advance_custom_word_point_by): Change
6057         parameter type to int.
6058         * completer.h (completion_tracker::advance_custom_word_point_by):
6059         Likewise.
6060
6061 2019-06-13  Pedro Alves  <palves@redhat.com>
6062
6063         * completer.c (advance_to_completion_word): Handle delimiters.
6064
6065 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6066
6067         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6068
6069 2019-06-11  Tom Tromey  <tom@tromey.com>
6070
6071         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6072         (xmalloc_failed): Move to alloc.c.
6073         * alloc.c: New file.
6074         * Makefile.in (COMMON_SFILES): Add alloc.c.
6075
6076 2019-06-11  Tom Tromey  <tom@tromey.com>
6077
6078         * nat/linux-waitpid.c: Don't include server.h.
6079         (linux_debug): Remove.
6080         (my_waitpid): Update.
6081
6082 2019-06-11  Tom Tromey  <tromey@adacore.com>
6083
6084         * infcall.c (_initialize_infcall): Remove trailing newline from
6085         help.
6086         * user-regs.c (_initialize_user_regs): Remove trailing newline
6087         from help.
6088         * typeprint.c (_initialize_typeprint): Remove trailing newline
6089         from help.
6090         * reverse.c (_initialize_reverse): Remove trailing newlines from
6091         help.
6092         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6093         from help.
6094         * language.c (add_set_language_command): Remove trailing newline
6095         from help.
6096         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6097         help.
6098         * disasm.c (_initialize_disasm): Remove trailing newline from
6099         help.
6100         * top.c (init_main): Remove trailing newline from help.
6101         * interps.c (_initialize_interpreter): Remove trailing newline
6102         from help.
6103         * btrace.c (_initialize_btrace): Remove trailing newlines from
6104         help.
6105         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6106         from help.
6107         * python/python.c (_initialize_python): Remove trailing newline
6108         from help.
6109         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6110         help.
6111         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6112         from help.  Reformat some text.
6113         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6114         from help.
6115         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6116         newline from help.
6117
6118 2019-06-11  Tom Tromey  <tromey@adacore.com>
6119
6120         * darwin-nat.c (darwin_decode_exception_message)
6121         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6122
6123 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6124
6125         * valops.c (value_slice): Check for not allocated or not
6126         associated values.
6127
6128 2019-06-10  Tom de Vries  <tdevries@suse.de>
6129
6130         PR gdb/24618
6131         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6132         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6133         invalid.
6134
6135 2019-06-10  Tom de Vries  <tdevries@suse.de>
6136
6137         PR gdb/24611
6138         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6139         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6140
6141 2019-06-10  Tom de Vries  <tdevries@suse.de>
6142
6143         PR symtab/24545
6144         * symtab.c (struct demangled_name_entry): Add language field.
6145         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6146         static minimal symbol".  Set and use language field.
6147
6148 2019-06-10  Tom Tromey  <tromey@adacore.com>
6149
6150         * ada-lang.c (_initialize_ada_language): Update help text.
6151
6152 2019-06-10  Tom Tromey  <tromey@adacore.com>
6153
6154         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6155         with a newline.
6156         * guile/guile.c (handle_boot_error): Don't end warning with a
6157         newline.
6158         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6159         warning with a newline.
6160         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6161         newline.
6162         (s12z_frame_cache): Likewise.
6163         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6164         a newline.
6165         * solib-svr4.c (disable_probes_interface): Don't end warning with
6166         a newline.
6167         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6168         newline.
6169         * python/python.c (do_finish_initialization): Don't end warning
6170         with a newline.
6171
6172 2019-06-10  Tom Tromey  <tom@tromey.com>
6173
6174         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6175         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6176         gdbpy_enter.
6177
6178 2019-06-10  Tom Tromey  <tromey@adacore.com>
6179
6180         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6181         data.
6182         (elf_new_init): Don't call stabsread_new_init.
6183         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6184         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6185         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6186
6187 2019-06-10  Tom de Vries  <tdevries@suse.de>
6188
6189         PR symtab/16264
6190         PR symtab/24517
6191         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6192
6193 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6194
6195         * source.c (find_and_open_source): Also rewrite relative file
6196         names.
6197
6198 2019-04-26  Amos Bird  <amosbird@gmail.com>
6199
6200         * annotate.c (annotate_thread_exited): Add "thread-exited"
6201         annotation.
6202
6203 2019-06-06  Tom Tromey  <tromey@adacore.com>
6204
6205         * maint.h (class scoped_command_stats): Use
6206         DISABLE_COPY_AND_ASSIGN.
6207         <print_time>: New method.
6208         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6209         print_time.
6210         (scoped_command_stats::print_time): New method.
6211
6212 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6213
6214         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6215         instructions of lengths 6 or 8 bytes.
6216
6217 2019-06-04  Pedro Alves  <palves@redhat.com>
6218
6219         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6220
6221         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6222         * breakpoint.c (condition_completer): Likewise.
6223         * cli/cli-dump.c (scan_expression): Likewise.
6224         * common/filestuff.c (mkdir_recursive): Likewise.
6225         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6226         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6227         (gdb_abspath): Likewise.
6228         * compile/compile-cplus-types.c
6229         (compile_cplus_instance::decl_name): Likewise.
6230         * completer.c (complete_explicit_location):
6231         (signal_completer, reg_or_group_completer_1): Likewise.
6232         * cp-support.c (cp_remove_params_if_any): Likewise.
6233         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6234         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6235         * infcmd.c (strip_bg_char): Likewise.
6236         * linespec.c (copy_token_string): Likewise.
6237         * mi/mi-main.c (output_cores): Likewise.
6238         * psymtab.c (psymtab_search_name):
6239         * symfile.c (test_set_ext_lang_command): Likewise.
6240         * target.c (target_fileio_read_stralloc): Likewise.
6241         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6242         * value.c (complete_internalvar): Likewise.
6243
6244 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6245
6246         Add objfile property to gdb.Type.
6247         * NEWS: Mention Python API addition.
6248         * python/py-type.c (typy_get_objfile): New method.
6249
6250 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6251
6252         * NEWS: Mention the new set|show style [title|highlight].
6253         Mention changes to "show style", "help" and "apropos".
6254
6255 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6256
6257         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6258         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6259         instead of print_help_for_command.
6260         (print_doc_of_command): New function.
6261         (help_list): Add 'apropos -v word' suggestion.
6262         (print_help_for_command): Style the command name using title style.
6263         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6264         (_initialize_cli_cmds): Describe -v in apropos_command help.
6265
6266 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6267
6268         * cli/cli-style.h (cli_style_option): Add name in constructor,
6269         add m_name class member, add constructor with intensity,
6270         add name class function.
6271         (cli_style_option::add_setshow_commands): Remove name argument.
6272         (highlight_style, title_style): New styles.
6273         * cli/cli-style.c (do_show): New function that shows a style
6274         characteristic styling the style name with itself.
6275         (set_style_name): New function.
6276         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6277         Update all callers according to the changes in cli/cli-style.h.
6278         * utils.h (fputs_highlighted): New function.
6279         * utils.c (fputs_highlighted): Likewise.
6280
6281 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6282
6283         * NEWS: Mention new pipe command and new convenience variables.
6284
6285 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6286
6287         * cli/cli-cmds.c (pipe_command): New function.
6288         (_initialize_cli_cmds): Call add_com for pipe_command.
6289         Define | as an alias for pipe.
6290         (exit_status_set_internal_vars): New function.
6291         (shell_escape): Call exit_status_set_internal_vars.
6292         cli/cli-decode.c (find_command_name_length): Recognize | as
6293         a single character command.
6294
6295 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6296
6297         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6298         top.c (execute_command_to_ui_file): New function, mostly a copy
6299         of execute_command_to_string.
6300         (execute_command_to_string): Implement by calling
6301         execute_command_to_ui_file.
6302
6303 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6304
6305         * top.h (saved_command_line): Remove declaration.
6306         * top.c (previous_saved_command_line, previous_repeat_arguments):
6307         New variables.
6308         (saved_command_line): Make static, define together with other
6309         'repeat variables'.
6310         (dont_repeat): Clear repeat_arguments.
6311         (repeat_previous, get_saved_command_line, save_command_line):
6312         New functions.
6313         (gdb_init): Initialize saved_command_line
6314         and previous_saved_command_line.
6315         * main.c (captured_main_1): Remove saved_command_line initialization.
6316         * event-top.c (handle_line_of_input): Update to use
6317         the new 'repeat' related functions instead of direct access to
6318         saved_command_line.
6319         * command.h (repeat_previous, get_saved_command_line,
6320         save_command_line): New declarations.
6321         (dont_repeat): Add comment.
6322
6323 2019-05-30  Tom Tromey  <tromey@adacore.com>
6324
6325         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6326         Fix comment.
6327         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6328
6329 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6330
6331         PR cli/24587
6332         * completer.c (complete): Initialize variable word.
6333
6334 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6335
6336         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6337         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6338         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6339         'body' is NULL to the outter 'if', protecting the '!is_define'
6340         situation as well.
6341
6342 2019-05-29  Tom Tromey  <tromey@adacore.com>
6343
6344         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6345         (dwarf_unknown): New function.
6346         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6347         (dwarf_type_encoding_name): Use dwarf_unknown.
6348
6349 2019-05-29  Tom Tromey  <tromey@adacore.com>
6350
6351         PR c++/20020:
6352         * cp-valprint.c (cp_print_value_fields): Call
6353         cp_print_static_field inside "try".
6354
6355 2019-05-29  Tom Tromey  <tromey@adacore.com>
6356
6357         * inflow.c (struct terminal_info): Add default operator=.
6358         * configure: Rebuild.
6359         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6360         -Wdeprecated-copy-dtor, -Wredundant-move.
6361
6362 2019-05-29  Tom Tromey  <tromey@adacore.com>
6363
6364         * NEWS: Add entry.
6365         * infcmd.c (print_return_value_1): Handle finish_print
6366         option.
6367         (show_print_finish): New function.
6368         (_initialize_infcmd): Add "set/show print finish" commands.
6369         * valprint.c (user_print_options): Initialize new member.
6370         * valprint.h (struct value_print_options) <finish_print>: New
6371         member.
6372
6373 2019-05-28  Tom Tromey  <tromey@adacore.com>
6374
6375         * ada-lang.c (ada_remove_Xbn_suffix)
6376         (find_old_style_renaming_symbol)
6377         (parse_old_style_renaming): Remove.
6378         (ada_find_renaming_symbol): Don't call
6379         find_old_style_renaming_symbol.
6380         (ada_is_renaming_symbol): Rename from
6381         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6382         bool.  Now static.
6383         (ada_read_var_value): Update and simplify.
6384         * ada-exp.y (write_var_or_type): Remove old code.
6385
6386 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6387
6388         * event-top.c: Remove include comment.
6389         * inflow.c (class scoped_ignore_sigttou): Move from here...
6390         * inflow.h (class scoped_ignore_sigttou): ...to here.
6391         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6392         * top.c:  Remove include comment.
6393
6394 2019-05-27  Tom Tromey  <tom@tromey.com>
6395
6396         * NEWS: Fix typo.
6397
6398 2019-05-22  Tom Tromey  <tromey@adacore.com>
6399
6400         * target.c (target_follow_exec): Constify parameter.
6401         * target-delegates.c: Rebuild.
6402         * remote.c (remote_target::follow_exec): Constify parameter.
6403         * infrun.c (follow_exec): Constify parameter.
6404         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6405         (target_follow_exec): Likewise.
6406
6407 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6408
6409         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6410         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6411
6412 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6413
6414         * NEWS: Add debugredirect and testsuite sections.
6415
6416 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6417
6418         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6419         target descriptions using exclusively floating point register name
6420         aliases.
6421
6422 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6423
6424         PR gdb/18644:
6425         * f-lang.c (build_fortran_types): Handle the case where
6426         gdbarch_floatformat_for_type returns a nullptr.
6427
6428 2019-05-21  Tom de Vries  <tdevries@suse.de>
6429
6430         PR cli/24587
6431         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6432
6433 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6434
6435         PR gdb/18644:
6436         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6437         16-byte floats.
6438         * i386-tdep.c (i386_floatformat_for_type): Use
6439         floatformats_ia64_quad for the 16-byte floating point component
6440         within a fortran 32-byte complex number.
6441
6442 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6443
6444         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6445         delete default constructor.
6446         (find_partial_die): Update to return const struct.
6447         (partial_die_parent_scope): Move variable declaration into scope
6448         of its use and change its type to auto.
6449         (guess_partial_die_structure_name): Likewise.
6450         (partial_die_info::fixup): Likewise.
6451
6452 2019-05-17  Tom Tromey  <tromey@adacore.com>
6453
6454         * source.c (find_and_open_source): Remove cast.
6455
6456 2019-05-17  Tom Tromey  <tromey@adacore.com>
6457
6458         * annotate.c (annotate_source): Make "filename" const.
6459         * annotate.h (annotate_source): Use const.
6460
6461 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6462
6463         * disasm.c (set_disassembler_options): Send errors to stderr.
6464
6465 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6466
6467         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6468         (cli_interp_base::set_logging): Check debug_redirect.
6469         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6470         * cli/cli-logging.c (debug_redirect): Add static variable.
6471         (pop_output_files): Add default param.
6472         (handle_redirections): Print debug setting.
6473         (show_logging_command): Likewise.
6474         (_initialize_cli_logging): Add debugredirect command.
6475         * interps.c (current_interp_set_logging): Add debug_redirect
6476         parameter.
6477         * interps.h (set_logging): Add debug_redirect parameter.
6478         (current_interp_set_logging): Likewise.
6479         * mi/mi-common.h: Likewise.
6480         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6481
6482 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6483             Tom Tromey  <tromey@adacore.com>
6484
6485         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6486         directly.
6487         * cli/cli-interp.h (make_logging_output): Remove declaration.
6488         * cli/cli-logging.c (make_logging_output): Remove function.
6489         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6490         directly.
6491         * ui-file.c (tee_file::tee_file): Remove bools.
6492         (tee_file::~tee_file): Remove deletes.
6493         * ui-file.h (tee_file): Remove bools.
6494
6495 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6496
6497         * mi/mi-cmds.h (mi_cmd_complete): New function.
6498         * mi/mi-main.c (mi_cmd_complete): Likewise.
6499         * mi/mi-cmds.c: Define new MI command -complete.
6500         * NEWS: Mention new -complete command.
6501
6502 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6503
6504         * completer.h (complete): New function.
6505         * completer.c (complete): Likewise.
6506         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6507         function defined in completer.h.
6508
6509 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6510
6511         * MAINTAINERS (Write After Approval): Add myself.
6512
6513 2019-05-17  Tom de Vries  <tdevries@suse.de>
6514
6515         PR gdb/24094
6516         * dwarf2read.c (struct cu_partial_die_info): New struct.
6517         (find_partial_die): Return cu_partial_die_info.
6518         (partial_die_parent_scope, guess_partial_die_structure_name)
6519         (partial_die_info::fixup): Handle new return type of find_partial_die.
6520
6521 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6522
6523         PR breakpoints/24541
6524         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6525         "std::string", simplifying the algorithm.
6526
6527 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6528
6529         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6530         (stap_static_probe_ops::get_probes): Likewise.
6531
6532 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6533
6534         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6535         '-')" and "else if".
6536         (stap_parse_single_operand): Join checks for
6537         "gdbarch_stap_parse_special_token_p" and
6538         "gdbarch_stap_parse_special_token" in the same "if" statement.
6539         Invert check when verifying for operation on register
6540         displacement.
6541
6542 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6543
6544         * stap-probe.c (stap_get_opcode): Update comment.
6545         (stap_get_expected_argument_type): Likewise.
6546         (handle_stap_probe): Likewise.
6547
6548 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6549
6550         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6551         return type to 'bool'.  Adjust comment.  Use 'bool' when
6552         appropriate.
6553         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6554         * stap-probe.c (stap_parse_argument_1): Likewise.
6555         (stap_is_operator): Likewise.
6556         (stap_is_generic_prefix): Likewise.
6557         (stap_is_register_prefix): Likewise.
6558         (stap_is_register_indirection_prefix): Likewise.
6559         (stap_is_integer_prefix): Likewise.
6560         (stap_generic_check_suffix): Likewise.
6561         (stap_check_integer_suffix): Likewise.
6562         (stap_check_register_suffix): Likewise.
6563         (stap_check_register_indirection_suffix): Likewise.
6564         (stap_parse_register_operand): Likewise.
6565         (stap_parse_single_operand): Likewise.
6566         (stap_parse_argument_1): Likewise.
6567         (stap_probe::get_argument_count): Likewise.
6568         (stap_is_operator): Likewise.
6569
6570 2019-05-16  Tom Tromey  <tromey@adacore.com>
6571
6572         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6573         keyword to foreach.
6574
6575 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6576
6577         * linux-thread-db.c (try_thread_db_load_1): Change return type
6578         to bool.
6579         (try_thread_db_load): Likewise.
6580         (try_thread_db_load_from_pdir_1): Likewise.
6581         (try_thread_db_load_from_pdir): Likewise.
6582         (try_thread_db_load_from_sdir): Likewise.
6583         (try_thread_db_load_from_dir): Likewise.
6584         (thread_db_load_search): Likewise.
6585         (has_libpthread): Likewise.
6586         (thread_db_load): Likewise.
6587
6588 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6589
6590         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6591         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6592         NULL, and complain/return if that's the case.
6593
6594 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6595
6596         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6597         (advance, posn, abstract_read_memory): New functions.
6598         [struct mem_read_abstraction]: New struct.
6599         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6600
6601 2019-05-14  Tom Tromey  <tromey@adacore.com>
6602
6603         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6604         value is not lval_memory.
6605
6606 2019-05-14  Tom Tromey  <tromey@adacore.com>
6607
6608         * solib.c (info_sharedlibrary_command): Style the file name.
6609
6610 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6611
6612         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6613         (aarch64_vnv_type): Likewise.
6614         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6615         * common/tdesc.c: Likewise.
6616         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6617         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6618         * features/aarch64-fpu.xml: Add ieee half view.
6619         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6620         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6621         * gdbtypes.h (struct builtin_type): Likewise.
6622         (struct objfile_type): Likewise.
6623
6624 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6625
6626         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6627         typo.
6628         * location.h (string_to_event_location): Likewise.
6629
6630 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6631
6632         GDB 8.3 released.
6633
6634 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6635
6636         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6637         New variable declaration.
6638         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6639         New variable.
6640         (print_one_breakpoint): Use ui_out::test_flags and new global
6641         variable to compute use_fixed_output.
6642         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6643         Remove.
6644         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6645         (mi_multi_location_breakpoint_output_fixed): Remove.
6646         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6647         new variable.
6648         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6649         fix_multi_location_breakpoint_output flag if version >= 3.
6650         * ui-out.h (enum ui_out_flag)
6651         <fix_multi_location_breakpoint_output>: New enumerator.
6652
6653 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6654
6655         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6656
6657 2019-05-10  Tom Tromey  <tromey@adacore.com>
6658
6659         * ada-lang.c (catch_ada_completer): New function.
6660         (_initialize_ada_language): Use it.
6661
6662 2019-05-10  Tom Tromey  <tromey@adacore.com>
6663
6664         * thread.c (print_thread_info): Make "requested_threads" const.
6665         * gdbthread.h (print_thread_info): Make "requested_threads"
6666         const.
6667         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6668         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6669
6670 2019-05-08  Tom Tromey  <tom@tromey.com>
6671
6672         * gdbtypes.c (objfile_type_data): Change type.
6673         (objfile_type, _initialize_gdbtypes): Update.
6674
6675 2019-05-08  Tom Tromey  <tom@tromey.com>
6676
6677         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6678         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6679         (_initialize_dwarf2_frame): Update.
6680
6681 2019-05-08  Tom Tromey  <tom@tromey.com>
6682
6683         * objc-lang.c (objc_objfile_data): Change type.
6684         (find_methods): Update.
6685         (_initialize_objc_lang): Remove.
6686
6687 2019-05-08  Tom Tromey  <tom@tromey.com>
6688
6689         * stabsread.c (rs6000_builtin_type_data): Change type.
6690         (rs6000_builtin_type, _initialize_stabsread): Update.
6691
6692 2019-05-08  Tom Tromey  <tom@tromey.com>
6693
6694         * mips-tdep.c (mips_pdr_data): Remove.
6695         (_initialize_mips_tdep): Update.
6696
6697 2019-05-08  Tom Tromey  <tom@tromey.com>
6698
6699         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6700         (hppa_init_objfile_priv_data, read_unwind_info)
6701         (find_unwind_entry, _initialize_hppa_tdep): Update.
6702
6703 2019-05-08  Tom Tromey  <tom@tromey.com>
6704
6705         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6706         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6707         on obstack.
6708         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6709
6710 2019-05-08  Tom Tromey  <tom@tromey.com>
6711
6712         * mdebugread.c (basic_type_data): Change type.
6713         (basic_type, _initialize_mdebugread): Update.
6714
6715 2019-05-08  Tom Tromey  <tom@tromey.com>
6716
6717         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6718
6719 2019-05-08  Tom Tromey  <tom@tromey.com>
6720
6721         * nto-tdep.c (nto_inferior_data_reg): Change type.
6722         (nto_inferior_data): Update.
6723         (nto_inferior_data_cleanup, nto_new_inferior_data)
6724         (_initialize_nto_tdep): Remove.
6725         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6726
6727 2019-05-08  Tom Tromey  <tom@tromey.com>
6728
6729         * ada-lang.c (struct ada_inferior_data): Add initializers.
6730         (ada_inferior_data): Change type.
6731         (ada_inferior_data_cleanup): Remove.
6732         (get_ada_inferior_data, ada_inferior_exit)
6733         (struct ada_pspace_data): Add initializers, destructor.
6734         (ada_pspace_data_handle): Change type.
6735         (get_ada_pspace_data): Update.
6736         (ada_pspace_data_cleanup): Remove.
6737
6738 2019-05-08  Tom Tromey  <tom@tromey.com>
6739
6740         * coffread.c (struct coff_symfile_info): Add initializers.
6741         (coff_objfile_data_key): Move lower.  Change type.
6742         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6743         Update.
6744         (coff_free_info): Remove.
6745
6746 2019-05-08  Tom Tromey  <tom@tromey.com>
6747
6748         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6749         (fbsd_pspace_data_handle): Move lower.  Change type.
6750         (get_fbsd_pspace_data): Update.
6751         (fbsd_pspace_data_cleanup): Remove.
6752         (_initialize_fbsd_tdep): Update.
6753
6754 2019-05-08  Tom Tromey  <tom@tromey.com>
6755
6756         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6757         (get_ada_tasks_pspace_data): Update.
6758         (ada_tasks_pspace_data_cleanup): Remove.
6759         (_initialize_tasks): Update.
6760         (ada_tasks_inferior_data_handle): Change type.
6761         (get_ada_tasks_inferior_data): Update.
6762         (ada_tasks_inferior_data_cleanup): Remove.
6763         (struct ada_tasks_pspace_data): Add initializers.
6764
6765 2019-05-08  Tom Tromey  <tom@tromey.com>
6766
6767         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6768         * symfile-debug.c (debug_sym_get_probes): Change type.
6769         * stap-probe.c (handle_stap_probe):
6770         (stap_static_probe_ops::get_probes): Change type.
6771         * probe.h (class static_probe_ops) <get_probes>: Change type.
6772         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6773         (parse_probes_in_pspace): Update.
6774         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6775         Update.
6776         (any_static_probe_ops::get_probes): Change type.
6777         * elfread.c (elfread_data): New typedef.
6778         (probe_key): Change type.
6779         (elf_get_probes): Likewise.  Update.
6780         (probe_key_free): Remove.
6781         (_initialize_elfread): Update.
6782         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6783         Change type.
6784         (dtrace_process_dof_probe, dtrace_process_dof)
6785         (dtrace_static_probe_ops::get_probe): Change type.
6786
6787 2019-05-08  Tom Tromey  <tom@tromey.com>
6788
6789         * xcoffread.c (struct xcoff_symfile_info): Rename from
6790         coff_symfile_info.  Add initializers.
6791         (xcoff_objfile_data_key): Move lower.  Change type.
6792         (XCOFF_DATA): Rewrite.
6793         (xcoff_free_info): Remove.
6794         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6795         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6796         (xcoff_initial_scan): Update.
6797
6798 2019-05-08  Tom Tromey  <tom@tromey.com>
6799
6800         * solib-svr4.c (struct svr4_info): Add initializers and
6801         destructor.
6802         <probes_table>: Now an htab_up.
6803         (solib_svr4_pspace_data): Change type.
6804         (free_probes_table): Simplify.
6805         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6806         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6807         (probes_table_remove_objfile_probes, register_solib_event_probe)
6808         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6809         (_initialize_svr4_solib): Update.
6810
6811 2019-05-08  Tom Tromey  <tom@tromey.com>
6812
6813         * remote.c (remote_pspace_data): Change type.
6814         (remote_pspace_data_cleanup): Remove.
6815         (get_remote_exec_file, set_pspace_remote_exec_file)
6816         (_initialize_remote): Update.
6817
6818 2019-05-08  Tom Tromey  <tom@tromey.com>
6819
6820         * breakpoint.c (breakpoint_objfile_key): Change type.
6821         (get_breakpoint_objfile_data): Update.
6822         (free_breakpoint_objfile_data): Remove.
6823         (_initialize_breakpoint): Update.
6824
6825 2019-05-08  Tom Tromey  <tom@tromey.com>
6826
6827         * linux-tdep.c (struct linux_info): Add initializers.
6828         (linux_inferior_data): Move.  Change type.
6829         (invalidate_linux_cache_inf): Update.
6830         (linux_inferior_data_cleanup): Remove.
6831         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6832
6833 2019-05-08  Tom Tromey  <tom@tromey.com>
6834
6835         * auxv.c (auxv_inferior_data): Move.  Change type.
6836         (auxv_inferior_data_cleanup): Remove.
6837         (invalidate_auxv_cache_inf): Rewrite.
6838         (get_auxv_inferior_data, _initialize_auxv): Update.
6839
6840 2019-05-08  Tom Tromey  <tom@tromey.com>
6841
6842         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6843         (symfile_debug_objfile_data_key): Change type.
6844         (symfile_debug_installed, debug_qf_has_symbols)
6845         (debug_qf_find_last_source_symtab)
6846         (debug_qf_forget_cached_source_info)
6847         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6848         (debug_qf_print_stats, debug_qf_dump)
6849         (debug_qf_expand_symtabs_for_function)
6850         (debug_qf_expand_all_symtabs)
6851         (debug_qf_expand_symtabs_with_fullname)
6852         (debug_qf_map_matching_symbols)
6853         (debug_qf_expand_symtabs_matching)
6854         (debug_qf_find_pc_sect_compunit_symtab)
6855         (debug_qf_map_symbol_filenames)
6856         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6857         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6858         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6859         (debug_sym_read_linetable, debug_sym_relocate): Update.
6860         (symfile_debug_free_objfile): Remove.
6861         (install_symfile_debug_logging, _initialize_symfile_debug):
6862         Update.
6863
6864 2019-05-08  Tom Tromey  <tom@tromey.com>
6865
6866         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6867         allocate_on_obstack.
6868         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6869         (get_dwarf2_per_objfile): Update.
6870         (set_dwarf2_per_objfile): Remove.
6871         (dwarf2_has_info, dwarf2_get_section_info): Update.
6872         (dwarf2_free_objfile): Remove.
6873         (_initialize_dwarf2_read): Update.
6874
6875 2019-05-08  Tom Tromey  <tom@tromey.com>
6876
6877         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6878         initializers.
6879         <unsupported_script_warning_printed,
6880         script_not_found_warning_printed>: Now bool.
6881         (auto_load_pspace_data): Change type.
6882         (~auto_load_pspace_info): Rename from
6883         auto_load_pspace_data_cleanup.
6884         (get_auto_load_pspace_data, init_loaded_scripts_info)
6885         (clear_section_scripts, maybe_print_unsupported_script_warning)
6886         (maybe_print_script_not_found_warning, _initialize_auto_load):
6887         Update.
6888
6889 2019-05-08  Tom Tromey  <tom@tromey.com>
6890
6891         * objfiles.c (objfile_pspace_info): Add destructor and
6892         initializers.
6893         (objfiles_pspace_data): Change type.
6894         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6895         (get_objfile_pspace_data): Update.
6896         (objfiles_bfd_data): Change type.
6897         (get_objfile_bfd_data): Update.
6898         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6899
6900 2019-05-08  Tom Tromey  <tom@tromey.com>
6901
6902         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6903         Change type.
6904         (get_catch_syscall_inferior_data): Update.
6905         (catch_syscall_inferior_data_cleanup): Remove.
6906         (_initialize_break_catch_syscall): Update.
6907
6908 2019-05-08  Tom Tromey  <tom@tromey.com>
6909
6910         * inflow.c (struct terminal_info): Add destructor and
6911         initializers.
6912         (inflow_inferior_data): Change type.
6913         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6914         (get_inflow_inferior_data, inflow_inferior_exit)
6915         (swap_terminal_info, _initialize_inflow): Update.
6916
6917 2019-05-08  Tom Tromey  <tom@tromey.com>
6918
6919         * target-dcache.c (target_dcache_cleanup): Remove.
6920         (target_dcache_aspace_key): Change type.
6921         (target_dcache_init_p, target_dcache_invalidate)
6922         (target_dcache_get, target_dcache_get_or_init)
6923         (_initialize_target_dcache): Update.
6924         * dcache.h (struct dcache_deleter): New.
6925
6926 2019-05-08  Tom Tromey  <tom@tromey.com>
6927
6928         * symtab.c (struct symbol_cache): Add destructor and
6929         initializers.
6930         (symbol_cache_key): Move.  Change type.
6931         (make_symbol_cache, free_symbol_cache): Remove.
6932         (get_symbol_cache): Update.
6933         (symbol_cache_cleanup): Remove.
6934         (ALL_PSPACES, symbol_cache_flush)
6935         (maintenance_print_symbol_cache)
6936         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6937         Update.
6938
6939 2019-05-08  Tom Tromey  <tom@tromey.com>
6940
6941         * symtab.c (struct main_info): Add destructor and initializers.
6942         (main_progspace_key): Move.  Change type.
6943         (get_main_info): Update.
6944         (main_info_cleanup): Remove.
6945         (_initialize_symtab): Update.
6946
6947 2019-05-08  Tom Tromey  <tom@tromey.com>
6948
6949         * registry.h (DECLARE_REGISTRY): Define the _key class.
6950
6951 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6952
6953         * NEWS: Merge two 'New commands' sections.
6954
6955 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6956
6957         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6958         parameter and use Ada language definition instead.
6959         (ada_val_print_ptr): Remove unused language parameter.
6960         (ada_val_print_num): Remove language parameter and use Ada language
6961         definition instead.
6962         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6963         parameter.
6964         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6965         parameter and use Ada language definition instead.
6966         (ada_val_print_1): Update all ada_val_print_xxx calls.
6967         Remove language parameter.
6968         (ada_val_print): Update ada_val_print_1 call.
6969
6970 2019-05-08  Tom Tromey  <tromey@adacore.com>
6971
6972         * remote.c (remote_hw_watchpoint_limit)
6973         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6974         Now static.
6975
6976 2019-05-08  Tom Tromey  <tromey@adacore.com>
6977
6978         * maint.c (_initialize_maint_cmds): Move initialization code to
6979         remote.c.
6980         (watchdog, show_watchdog): Move to remote.c.
6981         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6982         "watchdog" static.
6983         (_initialize_remote): Move initialization code from maint.c.
6984         * defs.h (watchdog): Don't declare.
6985
6986 2019-05-08  Tom Tromey  <tromey@adacore.com>
6987
6988         * tui/tui-interp.c: Include main.h.
6989         * interps.c: Include main.h.
6990         * main.h (interpreter_p): Declare.
6991         * defs.h (interpreter_p): Don't declare.
6992
6993 2019-05-08  Tom Tromey  <tromey@adacore.com>
6994
6995         * dwarf2loc.c: Include dwarf2read.h.
6996         * defs.h (read_unsigned_leb128): Don't declare.
6997         * dwarf2read.h (read_unsigned_leb128): Declare.
6998
6999 2019-05-08  Tom Tromey  <tromey@adacore.com>
7000
7001         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7002         method.
7003
7004 2019-05-08  Tom Tromey  <tromey@adacore.com>
7005
7006         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7007         when no wrap column is set.
7008
7009 2019-05-08  Tom Tromey  <tromey@adacore.com>
7010
7011         * c-lang.c (c_get_string): Handle non-C-style arrays.
7012
7013 2019-05-08  Tom Tromey  <tromey@adacore.com>
7014
7015         * typeprint.c (print_offset_data::update): Print the bit offset,
7016         not the number of bits remaining.
7017
7018 2019-05-08  Tom Tromey  <tromey@adacore.com>
7019
7020         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7021         padding at end of comment.
7022
7023 2019-05-08  Tom Tromey  <tromey@adacore.com>
7024
7025         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7026         Compare main types.
7027
7028 2019-05-06  Tom Tromey  <tom@tromey.com>
7029
7030         * common/scoped_mmap.c: Include common-defs.h.
7031         * common/scoped_mmap.h: Don't include config.h.
7032
7033 2019-05-04  Tom Tromey  <tom@tromey.com>
7034
7035         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7036         (struct aarch64_call_info): Add initializers.
7037         <si>: Now a std::vector.
7038         (pass_on_stack, aarch64_push_dummy_call): Update.
7039
7040 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7041             Tom Tromey  <tom@tromey.com>
7042
7043         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7044         (ppc_threads): Now a std::vector.  Now static.
7045         (hwdebug_find_thread_points_by_tid)
7046         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7047         Update.
7048
7049 2019-05-04  Tom Tromey  <tom@tromey.com>
7050
7051         * arc-tdep.c (arc_tdesc_init): Return bool.
7052
7053 2019-05-04  Tom Tromey  <tom@tromey.com>
7054
7055         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7056         Use gdb_assert_not_reached.
7057
7058 2019-05-04  Tom Tromey  <tom@tromey.com>
7059
7060         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7061         "false".
7062
7063 2019-05-04  Tom Tromey  <tom@tromey.com>
7064
7065         * arc-tdep.c (arc_tdesc_init): Use bool.
7066
7067 2019-05-04  Tom Tromey  <tom@tromey.com>
7068
7069         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7070
7071 2019-05-04  Tom Tromey  <tom@tromey.com>
7072
7073         * cli/cli-cmds.c (valid_command_p): Return bool.
7074
7075 2019-05-04  Tom Tromey  <tom@tromey.com>
7076
7077         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7078         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7079
7080 2019-05-04  Raul Tambre  <raul@tambre.ee>
7081
7082         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7083         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7084         operator for comparison.
7085
7086 2019-05-04  Tom Tromey  <tom@tromey.com>
7087
7088         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7089         (lookup_partial_symbol, print_partial_symbols)
7090         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7091         (psymbol_compare): Update.
7092         (add_psymbol_to_bcache): Clear the entire psymbol.
7093         (maintenance_check_psymtabs): Update.
7094         * psympriv.h (struct partial_symbol): Don't derive from
7095         general_symbol_info.
7096         <obj_section, unrelocated_address, address,
7097         set_unrelocated_address>: Update.
7098         <ginfo>: New member.
7099         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7100         (debug_names::write_psymbols): Update.
7101
7102 2019-05-04  Tom de Vries  <tdevries@suse.de>
7103
7104         * contrib/cc-with-tweaks.sh: Support -n arg.
7105
7106 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7107
7108         * corelow.c (core_target::detach): Ensure frame cache and
7109         register caches are cleared.
7110         inferior.c (exit_inferior_1): Likewise.
7111
7112 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7113             Tom Tromey  <tom@tromey.com>
7114
7115         * dictionary.c (collate_pending_symbols_by_language): Remove
7116         "struct" from foreach.
7117         * symtab.c (lookup_global_symbol_from_objfile)
7118         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7119         foreach.
7120         * ser-tcp.c (net_open): Remove "struct" from foreach.
7121         * objfiles.c (objfile_relocate, objfile_rebase)
7122         (objfile_has_symbols): Remove "struct" from foreach.
7123         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7124         from foreach.
7125         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7126         foreach.
7127         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7128         "struct" from foreach.
7129         * ada-lang.c (create_excep_cond_exprs)
7130         (ada_exception_catchpoint_cond_string): Remove "struct" from
7131         foreach.
7132
7133 2019-05-03  Tom Tromey  <tromey@adacore.com>
7134
7135         * ada-exp.y (convert_char_literal): Check suffix of each
7136         enumerator.
7137
7138 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7139
7140         PR ada/21406:
7141         * ada-exp.y (yywrap): Don't define.
7142         * ada-lex.l (%option): Add noyywrap
7143         (yywrap): Remove.
7144
7145 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7146
7147         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7148         _WIN32_WINNT to the XP level, unless already defined to a higher
7149         level.
7150
7151         * unittests/parse-connection-spec-selftests.c:
7152         * ser-tcp.c:
7153         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7154         override.
7155
7156         * symfile.c (find_separate_debug_file): Remove colon from the
7157         drive spec of DOS/Windows file names of the target, so that the
7158         file name produced from DEBUGDIR and the target's directory will
7159         be valid on DOS/Windows systems.
7160
7161 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7162
7163         * rust-lang.c (val_print_struct): Handle printing structures
7164         containing strings.
7165
7166 2019-05-02  Tom Tromey  <tromey@adacore.com>
7167
7168         * valarith.c (_initialize_valarith): Remove.
7169
7170 2019-05-01  Tom Tromey  <tromey@adacore.com>
7171
7172         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7173         bitfields.
7174
7175 2019-05-01  Tom Tromey  <tromey@adacore.com>
7176
7177         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7178         for big-endian copies.
7179
7180 2019-04-30  Ali Tamur  <tamur@google.com>
7181         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7182         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7183         (read_3_bytes): New function.
7184
7185 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7186
7187         * windows-nat.c (main_thread_id): Delete.
7188         (handle_output_debug_string): Replace main_thread_id by
7189         current_event.dwThreadId.
7190         (fake_create_process): Likewise.
7191         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7192         Do not set main_thread_id.
7193         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7194         current_event.dwThreadId.
7195         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7196
7197 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7198
7199         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7200         Use current_event.dwThreadId instead of main_thread_id.
7201
7202 2019-04-30  Tom Tromey  <tromey@adacore.com>
7203
7204         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7205         (create_excep_cond_exprs): Iterate over program spaces.
7206         (ada_exception_catchpoint_cond_string): Examine all minimal
7207         symbols for exception types.
7208
7209 2019-04-30  Tom Tromey  <tromey@adacore.com>
7210
7211         PR c++/24470:
7212         * dwarf2read.c (process_structure_scope): Handle case where type
7213         has template parameters but no symbol was created.
7214
7215 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7216             Chris January  <chris.january@arm.com>
7217
7218         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7219         qualifier.
7220         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7221
7222 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7223
7224         * f-typeprint.c (f_print_type): Update rules for printing
7225         whitespace.
7226         (f_type_print_varspec_suffix): Likewise.
7227
7228 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7229             Chris January  <chris.january@arm.com>
7230
7231         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7232         function arguments.
7233
7234 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7235
7236         * f-lang.c (build_fortran_types): Change name of void type to
7237         lower case.
7238         * f-typeprint.c (f_type_print_base): Print the name of the void
7239         type, rather than a fixed string.
7240         * f-valprint.c (f_decorations): Use lower case void string.
7241
7242 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7243             Chris January  <chris.january@arm.com>
7244
7245         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7246         types for Fortran.
7247
7248 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7249             Chris January  <chris.january@arm.com>
7250             David Lecomber  <david.lecomber@arm.com>
7251
7252         * f-exp.y (BINOP_INTRINSIC): New token.
7253         (exp): New parser rule handling BINOP_INTRINSIC.
7254         (f77_keywords): Add new builtin procedures.
7255         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7256         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7257         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7258         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7259         (print_unop_subexp_f): New function.
7260         (print_binop_subexp_f): New function.
7261         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7262         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7263         (dump_subexp_body_f): Likewise.
7264         (operator_check_f): Likewise.
7265         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7266         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7267
7268 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7269
7270         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7271         UNOP_KIND.
7272         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7273         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7274         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7275         (operator_length_f): New fuction.
7276         (print_subexp_f): New function.
7277         (op_name_f): New function.
7278         (dump_subexp_body_f): New function.
7279         (operator_check_f): New function.
7280         (exp_descriptor_f): Replace standard expression handling functions
7281         with new functions.
7282         * gdb/fortran-operator.def: New file.
7283         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7284         * gdb/std-operator.def: Remove UNOP_KIND.
7285
7286 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7287
7288         * std-operator.def: Remove unbalanced, stray double quote
7289         character.
7290
7291 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7292             Chris January  <chris.january@arm.com>
7293             Daniel Everett  <daniel.everett@arm.com>
7294             Nick Forrington  <nick.forrington@arm.com>
7295             Richard Bunt  <richard.bunt@arm.com>
7296
7297         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7298         of depth when printing anonymous structs or unions.
7299         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7300         Don't print either the top-level value, or the children if the
7301         max-depth is exceeded.
7302         (ppscm_print_children): When printing the key of a map, allow one
7303         extra level of depth.
7304         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7305         print either the top-level value, or the children if the max-depth
7306         is exceeded.
7307         (print_children): When printing the key of a map, allow one extra
7308         level of depth.
7309         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7310         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7311         (user_print_options): Initialise max_depth field.
7312         (val_print_scalar_or_string_type_p): New function.
7313         (val_print): Check to see if the max depth has been reached.
7314         (val_print_check_max_depth): Define new function.
7315         (show_print_max_depth): New function.
7316         (_initialize_valprint): Add 'print max-depth' option.
7317         * valprint.h (struct value_print_options) <max_depth>: New field.
7318         (val_print_check_max_depth): Declare new function.
7319         * NEWS: Document new feature.
7320
7321 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7322
7323         * ada-lang.c (ada_language_defn): Initialise new field.
7324         * c-lang.c (c_is_string_type_p): New function.
7325         (c_language_defn): Initialise new field.
7326         (cplus_language_defn): Initialise new field.
7327         (asm_language_defn): Initialise new field.
7328         (minimal_language_defn): Initialise new field.
7329         * c-lang.h (c_is_string_type_p): Declare new function.
7330         * d-lang.c (d_language_defn): Initialise new field.
7331         * f-lang.c (f_is_string_type_p): New function.
7332         (f_language_defn): Initialise new field.
7333         * go-lang.c (go_is_string_type_p): New function.
7334         (go_language_defn): Initialise new field.
7335         * language.c (default_is_string_type_p): New function.
7336         (unknown_language_defn): Initialise new field.
7337         (auto_language_defn): Initialise new field.
7338         * language.h (struct language_defn) <la_is_string_type_p>: New
7339         member variable.
7340         (default_is_string_type_p): Declare new function.
7341         * m2-lang.c (m2_language_defn): Initialise new field.
7342         * objc-lang.c (objc_language_defn): Initialise new field.
7343         * opencl-lang.c (opencl_language_defn): Initialise new field.
7344         * p-lang.c (pascal_is_string_type_p): New function.
7345         (pascal_language_defn): Initialise new field.
7346         * rust-lang.c (rust_is_string_type_p): New function.
7347         (rust_language_defn): Initialise new field.
7348
7349 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7350
7351         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7352         New field.
7353         * ada-lang.c (ada_language_defn): Initialise new field.
7354         * c-lang.c (c_language_defn): Likewise.
7355         (cplus_language_defn): Likewise.
7356         (asm_language_defn): Likewise.
7357         (minimal_language_defn): Likewise.
7358         * d-lang.c (d_language_defn): Likewise.
7359         * f-lang.c (f_language_defn): Likewise.
7360         * go-lang.c (go_language_defn): Likewise.
7361         * language.c (unknown_language_defn): Likewise.
7362         (auto_language_defn): Likewise.
7363         * m2-lang.c (m2_language_defn): Likewise.
7364         * objc-lang.c (objc_language_defn): Likewise.
7365         * opencl-lang.c (opencl_language_defn): Likewise.
7366         * p-lang.c (pascal_language_defn): Likewise.
7367         * rust-lang.c (rust_language_defn): Likewise.
7368
7369 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7370
7371         * ada-lang.c (ada_is_character_type): Change return type to bool.
7372         (ada_is_string_type): Likewise.
7373         * ada-lang.h (ada_is_character_type): Update declaration
7374         (ada_is_string_type): Likewise.
7375
7376 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7377
7378         Support style in 'frame|thread apply'
7379
7380         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7381         * record.c (record_start, record_stop): Update callers of
7382         execute_command_to_string with false.
7383         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7384         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7385         methods.
7386         (class string_file): New constructor with term_out parameter.
7387         Override methods term_out and can_emit_style_escape.  New member
7388         term_out.
7389         (class stdio_file): Override can_emit_style_escape.
7390         (class tee_file): Override term_out and can_emit_style_escape.
7391         * utils.h (can_emit_style_escape): Remove.
7392         * utils.c (can_emit_style_escape): Likewise.
7393         Update all callers of can_emit_style_escape (SOMESTREAM) to
7394         SOMESTREAM->can_emit_style_escape.
7395         * source-cache.c (source_cache::get_source_lines): Likewise.
7396         * stack.c (frame_apply_command_count): Call execute_command_to_string
7397         passing the term_out characteristic of the current gdb_stdout.
7398         * thread.c (thr_try_catch_cmd): Likewise.
7399         * top.c (execute_command_to_string): pass term_out parameter
7400         to construct the string_file for the command output.
7401         * ui-file.c (term_cli_styling): New function (most code moved
7402         from utils.c can_emit_style_escape).
7403         (string_file::string_file, string_file::can_emit_style_escape,
7404         stdio_file::can_emit_style_escape, tee_file::term_out,
7405         tee_file::can_emit_style_escape): New functions.
7406
7407 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7408
7409         * NEWS: Mention the new set|show may-call-functions.
7410         * infcall.c (may_call_functions_p): New variable.
7411         (show_may_call_functions_p): New function.
7412         (call_function_by_hand_dummy): Throws an error if not
7413         may-call-functions.
7414         (_initialize_infcall): Call add_setshow_boolean_cmd for
7415         may-call-functions.
7416
7417 2019-04-25  Keith Seitz  <keiths@redhat.com>
7418
7419         PR c++/24367
7420         * cp-support.c (inspect_type): Don't attempt substitutions
7421         of symbol with the same name.
7422
7423 2019-04-25  Tom Tromey  <tromey@adacore.com>
7424
7425         PR gdb/24475:
7426         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7427         static.
7428
7429 2019-04-25  Tom Tromey  <tromey@adacore.com>
7430
7431         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7432         rvalue reference.
7433         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7434         (gdb_xml_parser::parse): Use std::move.
7435         * python/python-internal.h (gdbpy_convert_exception): Take a const
7436         reference.
7437         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7438         std::move.
7439         * python/py-utils.c (gdbpy_convert_exception): Take a const
7440         reference.
7441         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7442         Use std::move.
7443         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7444         Use std::move.
7445         * mi/mi-main.c (mi_print_exception): Take a const reference.
7446         * main.c (handle_command_errors): Take a const reference.
7447         * linespec.c (parse_linespec): Use std::move.
7448         * infcall.c (run_inferior_call): Use std::move.
7449         (call_function_by_hand_dummy): Use std::move.
7450         * exec.c (try_open_exec_file): Use std::move.
7451         * exceptions.h (exception_print, exception_fprintf)
7452         (exception_print_same): Update.
7453         * exceptions.c (print_exception, exception_print)
7454         (exception_fprintf, exception_print_same): Change parameters to
7455         const reference.
7456         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7457         * common/new-op.c: Use std::move.
7458         * common/common-exceptions.h (struct gdb_exception): Add move
7459         constructor.
7460         (struct gdb_exception_error, struct gdb_exception_quit, struct
7461         gdb_quit_bad_alloc): Change constructor to move constructor.
7462         (throw_exception): Change parameter to rvalue reference.
7463         * common/common-exceptions.c (throw_exception): Take rvalue
7464         reference.
7465         * cli/cli-interp.c (safe_execute_command): Use std::move.
7466         * breakpoint.c (insert_bp_location, location_to_sals): Use
7467         std::move.
7468
7469 2019-04-25  Tom Tromey  <tromey@adacore.com>
7470
7471         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7472         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7473         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7474         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7475         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7476         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7477         guile/scm-value.c: Use unpack.
7478         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7479         gdbscm_gdb_exception.
7480         (gdbscm_throw_gdb_exception): Likewise.
7481         (struct gdbscm_gdb_exception): New.
7482         (unpack): New function.
7483         (gdbscm_wrap): Use unpack.
7484
7485 2019-04-25  Tom Tromey  <tromey@adacore.com>
7486
7487         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7488         (gdb_rl_callback_handler): Use std::move.
7489         * common/common-exceptions.h (struct gdb_exception): Add move
7490         assignment operator.
7491         (throw_exception_sjlj): Change "exception" to const reference.
7492         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7493         (throw_exception_sjlj): Change "exception" to const reference.
7494
7495 2019-04-25  Tom Tromey  <tromey@adacore.com>
7496
7497         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7498         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7499         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7500         Update.
7501         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7502         Update.
7503         * mi/mi-interp.c (mi_interp::exec): Update.
7504         * linespec.c (parse_linespec): Update.
7505         * infcall.c (run_inferior_call): Update.
7506         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7507         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7508         (gdbscm_lookup_global_symbol): Update.
7509         * guile/scm-param.c (gdbscm_parameter_value): Update.
7510         * guile/scm-frame.c (gdbscm_frame_read_register)
7511         (gdbscm_frame_read_var): Update.
7512         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7513         * exec.c (try_open_exec_file): Update.
7514         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7515         (gdb_rl_callback_handler): Update.
7516         * common/common-exceptions.h (exception_none): Don't declare.
7517         * common/common-exceptions.c (exception_none): Don't define.
7518         (struct catcher) <exception>: Update.
7519         * cli/cli-interp.c (safe_execute_command): Update.
7520         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7521
7522 2019-04-25  Ali Tamur  <tamur@google.com>
7523
7524         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7525         (read_attribute_value): Likewise.
7526         (dwarf2_read_addr_index): Update comment.
7527         (read_str_index): Add DW_FORM_strx.
7528         (dwarf2_string_attr): Likewise.
7529         (dwarf2_const_value_attr): Likewise.
7530         (dump_die_shallow): Likewise.
7531         (dwarf2_fetch_constant_bytes): Likewise.
7532         (skip_form_bytes): Likewise.
7533         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7534
7535 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7536
7537         PR corefiles/11608
7538         PR corefiles/18187
7539         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7540         OFFSET.  Verify if current mapping contains an ELF header.
7541         (linux_find_memory_regions_full): Adjust call to
7542         dump_mapping_p.
7543
7544 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7545             Kang Li <kanglictf@gmail.com>
7546
7547         PR gdb/21600
7548
7549         * dwarf2-frame.c (read_initial_length): Be consistent about using
7550         unsigned representation of length.
7551         (decode_frame_entry_1): Likewise.  Check for wraparound of
7552         end pointer as well as buffer overflow.
7553
7554 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7555
7556         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7557         "vq".
7558
7559 2019-04-24  Tom Tromey  <tromey@adacore.com>
7560
7561         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7562
7563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7564
7565         * s12z-tdep.c (s12z_unwind_pc): Delete.
7566         (s12z_unwind_sp): Delete.
7567         (s12z_gdbarch_init): Don't register deleted functions with
7568         gdbarch.
7569
7570 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7571
7572         * rl78-tdep.c (rl78_unwind_sp): Delete.
7573         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7574
7575 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7576
7577         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7578         (xstormy16_unwind_pc): Delete.
7579         (xstormy16_dummy_id): Delete.
7580         (xstormy16_gdbarch_init): Don't register deleted functions with
7581         gdbarch.
7582
7583 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7584
7585         * vax-tdep.c (vax_unwind_pc): Delete.
7586         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7587
7588 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7589
7590         * v850-tdep.c (v850_unwind_sp): Delete.
7591         (v850_unwind_pc): Delete.
7592         (v850_dummy_id): Delete.
7593         (v850_gdbarch_init): Don't register deleted functions with
7594         gdbarch.
7595
7596 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7597
7598         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7599         (tilegx_unwind_pc): Delete.
7600         (tilegx_unwind_dummy_id): Delete.
7601         (tilegx_gdbarch_init): Don't register deleted functions with
7602         gdbarch.
7603
7604 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7605
7606         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7607         (tic6x_dummy_id): Delete.
7608         (tic6x_gdbarch_init): Don't register deleted functions with
7609         gdbarch.
7610
7611 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7612
7613         * sparc-tdep.c (sparc_unwind_pc): Delete.
7614         (sparc32_gdbarch_init): Don't register deleted function with
7615         gdbarch.
7616
7617 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7618
7619         * sh-tdep.c (sh_unwind_sp): Delete.
7620         (sh_unwind_pc): Delete.
7621         (sh_dummy_id): Delete.
7622         (sh_gdbarch_init): Don't register deleted functions with
7623         gdbarch.
7624
7625 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7626
7627         * score-tdep.c (score_unwind_sp): Delete.
7628         (score_unwind_pc): Delete.
7629         (score_dummy_id): Delete.
7630         (score_gdbarch_init): Don't register deleted functions with
7631         gdbarch.
7632
7633 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7634
7635         * rx-tdep.c (rx_unwind_pc): Delete.
7636         (rx_unwind_sp): Delete.
7637         (rx_dummy_id): Delete.
7638         (rx_gdbarch_init): Don't register deleted functions with
7639         gdbarch.  Update comment.
7640
7641 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7642
7643         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7644         (rs6000_dummy_id): Delete.
7645         (rs6000_gdbarch_init): Don't register deleted functions with
7646         gdbarch.
7647
7648 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7649
7650         * or1k-tdep.c (or1k_dummy_id): Delete.
7651         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7652
7653 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7654
7655         * nios2-tdep.c (nios2_dummy_id): Delete.
7656         (nios2_unwind_sp): Delete.
7657         (nios2_gdbarch_init): Don't register deleted functions with
7658         gdbarch.
7659
7660 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7661
7662         * nds32-tdep.c (nds32_dummy_id): Delete.
7663         (nds32_unwind_pc): Delete.
7664         (nds32_unwind_sp): Delete.
7665         (nds32_gdbarch_init): Don't register deleted functions with
7666         gdbarch.
7667
7668 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7669
7670         * msp430-tdep.c (msp430_unwind_pc): Delete.
7671         (msp430_unwind_sp): Delete.
7672         (msp430_dummy_id): Delete.
7673         (msp430_gdbarch_init): Don't register deleted functions with
7674         gdbarch.
7675
7676 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7677
7678         * moxie-tdep.c (moxie_unwind_sp): Delete.
7679         (moxie_unwind_pc): Delete.
7680         (moxie_dummy_id): Delete.
7681         (moxie_gdbarch_init): Don't register deleted functions with
7682         gdbarch.
7683
7684 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7685
7686         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7687         (mn10300_unwind_pc): Delete.
7688         (mn10300_unwind_sp): Delete.
7689         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7690         mn10300_unwind_sp.
7691         (mn10300_frame_unwind_init): Don't register deleted functions with
7692         gdbarch.
7693
7694 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7695
7696         * mep-tdep.c (mep_unwind_pc): Delete.
7697         (mep_unwind_sp): Delete.
7698         (mep_dummy_id): Delete.
7699         (mep_gdbarch_init): Don't register deleted functions with
7700         gdbarch.
7701
7702 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7703
7704         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7705         (m68hc11_unwind_sp): Delete.
7706         (m68hc11_gdbarch_init): Don't register deleted functions with
7707         gdbarch.
7708
7709 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7710
7711         * m32r-tdep.c (m32r_unwind_sp): Delete.
7712         (m32r_unwind_pc): Delete.
7713         (m32r_dummy_id): Delete.
7714         (m32r_gdbarch_init): Don't register deleted functions with
7715         gdbarch.
7716
7717 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7718
7719         * m32c-tdep.c (m32c_unwind_pc): Delete.
7720         (m32c_unwind_sp): Delete.
7721         (m32c_dummy_id): Delete.
7722         (m32c_gdbarch_init): Don't register deleted functions with
7723         gdbarch.
7724
7725 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7726
7727         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7728         (lm32_unwind_pc): Delete.
7729         (lm32_dummy_id): Delete.
7730         (lm32_gdbarch_init): Don't register deleted functions with
7731         gdbarch.
7732
7733 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7734
7735         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7736         (iq2000_unwind_pc): Delete.
7737         (iq2000_dummy_id): Delete.
7738         (iq2000_gdbarch_init): Don't register deleted functions with
7739         gdbarch.
7740
7741 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7742
7743         * nds32-tdep.c (nds32_type_align): Delete.
7744         (nds32_push_dummy_call): Use type_align instead.
7745
7746 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7747
7748         * arm-tdep.c (arm_type_align): Only handle vector override case.
7749         (arm_push_dummy_call): Use type_align.
7750         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7751
7752 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7753
7754         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7755         case.
7756         (pass_on_stack): Use type_align.
7757         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7758         function.
7759
7760 2019-04-23  Tom Tromey  <tromey@adacore.com>
7761
7762         * dwarf2read.c (line_header::file_name_at): Remove unused
7763         overload.
7764
7765 2019-04-23  Tom de Vries  <tdevries@suse.de>
7766
7767         PR gdb/24438
7768         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7769         invocation.
7770
7771
7772 2019-03-27  Ali Tamur  <tamur@google.com>
7773
7774         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7775         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7776         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7777         (dwarf_expr_context::get_addr_index): Likewise
7778         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7779         (symbol_needs_eval_context::get_addr_index): Likewise
7780         (disassemble_dwarf_expression): Add DW_OP_addrx
7781         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7782         (read_cutu_die_from_dwo): Update comment
7783         (skip_one_die): Add DW_FORM_addrx
7784         (read_attribute_value): Likewise
7785         (var_decode_location): Add DW_OP_addrx
7786         (dwarf2_const_value_attr): Add DW_FORM_addrx
7787         (dump_die_shallow): Likewise
7788         (dwarf2_fetch_constant_bytes): Likewise
7789         (decode_locdesc): Add DW_OP_addrx
7790         (skip_form_bytes): Add DW_FORM_addrx
7791
7792 2019-04-22  Ali Tamur  <tamur@google.com>
7793
7794         * MAINTAINERS (Write After Approval): Add self.
7795
7796 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7797
7798         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7799         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7800         (open_symbol_file_object): Likewise.
7801         (svr4_default_sos): Add info parameter.
7802         (svr4_read_so_list): Likewise.
7803         (svr4_current_sos_direct): Adjust functions calls to pass down
7804         info.
7805         (svr4_current_sos_1): Add info parameter.
7806         (svr4_current_sos): Call get_svr4_info, pass info down to
7807         svr4_current_sos_1.
7808         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7809         get_svr4_info.
7810         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7811         get_svr4_info.
7812         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7813         to get_svr4_info.
7814         (probes_table_remove_objfile_probes): Likewise.
7815         (register_solib_event_probe): Add info parameter.
7816         (solist_update_incremental): Pass info parameter down to
7817         svr4_read_so_list.
7818         (disable_probes_interface): Add info parameter.
7819         (svr4_handle_solib_event): Pass current_program_space to
7820         get_svr4_info.  Adjust disable_probes_interface cleanup.
7821         (svr4_create_probe_breakpoints): Add info parameter, pass it
7822         down to register_solib_event_probe.
7823         (svr4_create_solib_event_breakpoints): Add info parameter,
7824         pass it down to svr4_create_probe_breakpoints.
7825         (enable_break): Pass info down to
7826         svr4_create_solib_event_breakpoints.
7827         (svr4_solib_create_inferior_hook): Pass current_program_space to
7828         get_svr4_info.
7829         (svr4_clear_solib): Likewise.
7830
7831 2019-04-22  Pedro Alves  <palves@redhat.com>
7832
7833         * solib-svr4.c (svr4_free_objfile_observer): New.
7834         (probe_and_action::objfile): New field.
7835         (probes_table_htab_remove_objfile_probes)
7836         (probes_table_remove_objfile_probes): New functions.
7837         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7838         in the new probe_and_action.  Don't store the probe in 'lookup'.
7839         (svr4_create_probe_breakpoints): Pass objfile to
7840         register_solib_event_probe.
7841         (_initialize_svr4_solib): Register a free_objfile observer.
7842
7843 2019-04-19  Tom Tromey  <tom@tromey.com>
7844
7845         * common/queue.h: Remove.
7846
7847 2019-04-19  Tom Tromey  <tom@tromey.com>
7848
7849         * event-loop.c: Don't include "common/queue.h".
7850
7851 2019-04-19  Tom Tromey  <tom@tromey.com>
7852
7853         * remote.c (remote_target): Use delete.
7854         * remote-notif.h: Include <list>, not "common/queue.h".
7855         (notif_client_p): Remove typedef.
7856         (remote_notif_state): Add constructor, destructor, initializer.
7857         <notif_queue>: Now a std::list.
7858         (remote_notif_state_xfree): Don't declare.
7859         * remote-notif.c (remote_notif_process, handle_notification)
7860         (remote_notif_state_allocate): Update.
7861         (~remote_notif_state): Rename from remote_notif_state_xfree.
7862
7863 2019-04-19  Tom Tromey  <tom@tromey.com>
7864
7865         * symfile.c (reread_symbols): Update.
7866         * objfiles.c (objfile_register_static_link)
7867         (objfile_lookup_static_link): Update
7868         (~objfile) Don't delete static_links.
7869         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7870
7871 2019-04-19  Tom Tromey  <tom@tromey.com>
7872
7873         * type-stack.h (struct type_stack) <insert>: Constify string.
7874         * type-stack.c (type_stack::insert): Constify string.
7875         * gdbtypes.h (lookup_template_type): Update.
7876         (address_space_name_to_int): Update.
7877         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7878         const.
7879         (lookup_template_type): Make name const.
7880         * c-exp.y: Update rules.
7881         (lex_one_token, classify_name, classify_inner_name)
7882         (c_print_token): Update.
7883         * p-exp.y: Update rules.
7884         (yylex): Update.
7885         * f-exp.y: Update rules.
7886         (yylex): Update.
7887         * d-exp.y: Update rules.
7888         (lex_one_token, classify_name, classify_inner_name): Update.
7889         * parse.c (write_dollar_variable, copy_name): Return std::string.
7890         * parser-defs.h (copy_name): Change return type.
7891         * m2-exp.y: Update rules.
7892         (yylex): Update.
7893         * go-exp.y (lex_one_token): Update.
7894         Update rules.
7895         (classify_unsafe_function, classify_packaged_name)
7896         (classify_name, yylex): Update.
7897
7898 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7899
7900         * configure.ac: add --enable-source-highlight switch.
7901         * configure: Regenerate.
7902         * top.c (print_gdb_version): plumb --enable-source-highlight
7903         status to "show configuration".
7904
7905 2019-04-19  Tom Tromey  <tromey@adacore.com>
7906
7907         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7908         Check ADA_TYPE_P.
7909         (empty_record, ada_template_to_fixed_record_type_1)
7910         (template_to_static_fixed_type)
7911         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7912         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7913         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7914         macros.
7915
7916 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7917
7918         PR symtab/24423:
7919         * source.c (print_source_lines_base): Advance "iter" when a
7920         control character is seen.
7921
7922 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7923
7924         * inferior.h (struct infcall_suspend_state_deleter):
7925         Catch exception in destructor to avoid crash.
7926
7927 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7928
7929         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7930         close to the add_com "shell".
7931
7932 2019-04-18  Tom Tromey  <tromey@adacore.com>
7933
7934         * process-stratum-target.h (class process_stratum_target)
7935         <stratum>: Add "final".
7936
7937 2019-04-17  Tom Tromey  <tromey@adacore.com>
7938
7939         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7940         against nullptr before use.
7941
7942 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7943
7944         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7945
7946 2019-04-17  Jim Wilson  <jimw@sifive.com>
7947             Andrew Burgess  <andrew.burgess@embecosm.com>
7948
7949         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7950         code read might fail, assume 4-byte breakpoint in that case.
7951
7952 2019-04-15  Leszek Swirski  <leszeks@google.com>
7953
7954         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7955         rather than a hand-rolled POD check when checking for forced MEMORY
7956         classification.
7957
7958 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7959
7960         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7961         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7962         function.
7963         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7964         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7965         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7966         declaration.
7967
7968 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7969
7970         * aarch64-linux-nat.c
7971         (aarch64_linux_nat_target::thread_architecture): Add override.
7972         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7973         each VQ.
7974
7975 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7976
7977         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7978
7979 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7980
7981         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7982         target types of size 96-bits, add some additional comments, and
7983         check that the builtin type we found was the correct size.
7984
7985 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7986
7987         * utils.c (prompt_for_continue): Don't restore the styling at the
7988         end, as applied_style has the wrong value.  This fixes styling in
7989         long lists of file names that are interrupted by the "Continue?"
7990         prompt.
7991
7992 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7993
7994         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7995         * c-lang.c (c_language_defn): Likewise.
7996         (cplus_language_defn): Likewise.
7997         (asm_language_defn): Likewise.
7998         (minimal_language_defn): Likewise.
7999         * d-lang.c (d_language_defn): Likewise.
8000         * f-lang.c (f_language_defn): Likewise.
8001         * go-lang.c (go_language_defn): Likewise.
8002         * language.c (unknown_language_defn): Likewise.
8003         (auto_language_defn): Likewise.
8004         * language.h (struct language_defn): Remove la_magic field.
8005         (LANG_MAGIC): Delete.
8006         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8007         * objc-lang.c (objc_language_defn): Likewise.
8008         * opencl-lang.c (opencl_language_defn): Likewise.
8009         * p-lang.c (pascal_language_defn): Likewise.
8010         * rust-lang.c (rust_language_defn): Likewise.
8011
8012 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8013
8014         * riscv-tdep.c (riscv_type_align): New function.
8015         (riscv_type_alignment): Delete.
8016         (riscv_arg_location): Use 'type_align'.
8017         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8018
8019 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8020
8021         * gdbtypes.c (type_align): A struct with no non-static fields also
8022         has alignment of 1.
8023
8024 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8025
8026         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8027         component to 0.
8028         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8029         member.
8030         (riscv_struct_info::analyse): New implementation using new
8031         analyse_inner member function.
8032         (riscv_struct_info::field_offset): New member function.
8033         (riscv_struct_info::m_offsets): New member variable.
8034         (riscv_struct_info::analyse_inner): New private member function,
8035         takes the old implementation of riscv_struct_info::analyse but
8036         extended to track field offsets.
8037         (riscv_call_arg_struct): Update the struct folding special cases
8038         to handle cases where empty C++ structs, which are non-zero
8039         length, are found.
8040         (riscv_arg_location): Initialise the length of each location, a
8041         non-zero length now indicates the location is in use.
8042         (riscv_push_dummy_call): Allow for the first location having a
8043         non-zero offset when setting up arguments.
8044         (riscv_return_value): Likewise, but for return values.
8045
8046 2019-04-11  Tom Tromey  <tromey@adacore.com>
8047
8048         * utils.c (internal_vproblem): Make "msg" const.
8049
8050 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8051
8052         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8053         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8054         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8055         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8056
8057 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8058
8059         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8060         function.
8061         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8062         of amd64_collect_native_gregset.
8063         (amd64_linux_nat_target::store_registers): Likewise.
8064
8065 2019-04-10  Tom Tromey  <tom@tromey.com>
8066
8067         * symtab.c (lookup_global_symbol_from_objfile)
8068         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8069         * objfiles.h (class separate_debug_iterator): New.
8070         (class separate_debug_range): New.
8071         (struct objfile) <separate_debug_objfiles>: New method.
8072         (objfile_separate_debug_iterate): Don't declare.
8073         * objfiles.c (separate_debug_iterator::operator++): Rename from
8074         objfile_separate_debug_iterate.
8075         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8076         iterator.
8077         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8078         iterator.
8079
8080 2019-04-10  Tom Tromey  <tom@tromey.com>
8081
8082         * symfile.c (reread_symbols): Remove old comment.
8083         * objfiles.c (free_all_objfiles): Fix a typo.
8084
8085 2019-04-10  Tom Tromey  <tom@tromey.com>
8086
8087         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8088         * minsyms.c (lookup_minimal_symbol): Use foreach.
8089         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8090         (lookup_minimal_symbol_solib_trampoline): Likewise.
8091         * symfile.c (reread_symbols): Use foreach.
8092
8093 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8094             Tom Tromey  <tromey@adacore.com>
8095
8096         PR rust/24414:
8097         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8098         (rust_lex_int_test): Change "value" to be LONGEST.
8099         (rust_lex_tests): Add test for long integer literal.
8100
8101 2019-04-09  Tom Tromey  <tromey@adacore.com>
8102
8103         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8104         to bool.
8105         (extended_remote_target::attach): Update.
8106         (remote_target::remote_notice_new_inferior): Update.
8107         (remote_target::add_current_inferior_and_thread): Update.
8108         * inferior.c (exit_inferior_1): Use "false".
8109         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8110
8111 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8112
8113         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8114         the "start" command.
8115
8116 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8117
8118         * python/py-inferior.c (infpy_thread_from_thread_handle):
8119         Adjust comments to reflect renaming of thread_from_thread_handle
8120         to thread_from_handle.  Adjust keywords.  Fix type error message.
8121         (inferior_object_methods): Add thread_from_handle.  Retain
8122         thread_from_thread_handle, but mark it as deprecated.
8123
8124 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8125
8126         * gdbthread.h (find_thread_by_handle): Revise declaration.
8127         * thread.c (find_thread_by_handle): Likewise.  Adjust
8128         implementation too.
8129         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8130         support for buffer objects as handles.
8131
8132 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8133
8134         * python/py-infthread.c (thpy_thread_handle): New function.
8135         (thread_object_methods): Register thpy_thread_handle.
8136
8137 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8138
8139         * gdbthread.h (thread_to_thread_handle): Declare.
8140         * thread.c (gdbtypes.h): Include.
8141         (thread_to_thread_handle): New function.
8142
8143         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8144         (target_thread_info_to_thread_handle): Declare.
8145         * target.c (target_thread_info_to_thread_handle): New function.
8146         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8147         * target-delegates.c: Regenerate.
8148
8149         * linux-thread-db.c (class thread_db_target): Add method
8150         thread_info_to_thread_handle.
8151         (thread_db_target::thread_info_to_thread_handle): Define.
8152         * remote.c (class remote_target): Add new method
8153         thread_info_to_thread_handle.
8154         (remote_target::thread_info_to_thread_handle): Define.
8155
8156 2019-04-08  Pedro Alves  <palves@redhat.com>
8157
8158         * common/common-exceptions.c (throw_exception): Don't create
8159         named object to throw; throw directly.
8160         (throw_it): Likewise.  Don't initialize gdb_exception::message
8161         here, with new; pass FMT and AP to the ctor instead.
8162         * common/common-exceptions.h: Include <string>.
8163         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8164         const char *, va_list)): New ctor.  Use std::make_shared.
8165         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8166         errors)): Delete.
8167         (gdb_exception_error::gdb_exception_error(enum errors, const char
8168         *, va_list)): New.
8169         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8170         Add assertion.
8171         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8172         errors)): Delete.
8173         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8174         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8175         Add assertion.
8176
8177 2019-04-08  Tom Tromey  <tom@tromey.com>
8178
8179         * valops.c (value_rtti_indirect_type): Replace throw_exception
8180         with throw.
8181         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8182         with throw.
8183         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8184         throw.
8185         * target.c (target_translate_tls_address): Replace throw_exception
8186         with throw.
8187         * stack.c (frame_apply_command_count): Replace throw_exception
8188         with throw.
8189         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8190         throw.
8191         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8192         with throw.
8193         * rs6000-tdep.c (rs6000_frame_cache)
8194         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8195         * remote.c: Replace throw_exception with throw.
8196         * record-full.c (record_full_message, record_full_wait_1)
8197         (record_full_restore): Replace throw_exception with throw.
8198         * record-btrace.c:
8199         (get_thread_current_frame_id, record_btrace_start_replaying)
8200         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8201         (cmd_record_btrace_start): Replace throw_exception with throw.
8202         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8203         throw.
8204         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8205         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8206         * linespec.c:
8207         (find_linespec_symbols): Replace throw_exception with throw.
8208         * infrun.c (displaced_step_prepare, resume): Replace
8209         throw_exception with throw.
8210         * infcmd.c (post_create_inferior): Replace throw_exception with
8211         throw.
8212         * inf-loop.c (inferior_event_handler): Replace throw_exception
8213         with throw.
8214         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8215         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8216         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8217         (get_prev_frame_always, get_frame_pc_if_available)
8218         (get_frame_address_in_block_if_available, get_frame_language):
8219         Replace throw_exception with throw.
8220         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8221         throw_exception with throw.
8222         * eval.c (fetch_subexp_value, evaluate_var_value)
8223         (evaluate_funcall, evaluate_subexp_standard): Replace
8224         throw_exception with throw.
8225         * dwarf2loc.c (call_site_find_chain)
8226         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8227         Replace throw_exception with throw.
8228         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8229         with throw.
8230         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8231         throw.
8232         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8233         * completer.c (complete_line_internal): Replace throw_exception
8234         with throw.
8235         * compile/compile-object-run.c (compile_object_run): Replace
8236         throw_exception with throw.
8237         * cli/cli-script.c (process_next_line): Replace throw_exception
8238         with throw.
8239         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8240         (btrace_enable, btrace_maint_update_pt_packets): Replace
8241         throw_exception with throw.
8242         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8243         throw_exception with throw.
8244         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8245         throw_exception with throw.
8246         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8247         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8248         * aarch64-tdep.c (aarch64_make_prologue_cache)
8249         (aarch64_make_stub_cache): Replace throw_exception with throw.
8250
8251 2019-04-08  Tom Tromey  <tom@tromey.com>
8252
8253         * common/common-exceptions.c (throw_exception): Rename from
8254         throw_exception_cxx.  Remove old copy.  Make argument const.
8255         (throw_it): Create and throw exception objects directly.
8256         * common/common-exceptions.h (throw_exception): Make argument
8257         const.
8258         (struct gdb_exception_error): Add constructor.
8259         (struct gdb_exception_quit): Add constructor.
8260
8261 2019-04-08  Tom Tromey  <tom@tromey.com>
8262
8263         * common/common-exceptions.h (exception_rethrow): Don't declare.
8264         (TRY_SJLJ): Update comment.
8265         (TRY, CATCH, END_CATCH): Remove.
8266         * common/common-exceptions.c (exception_rethrow): Remove.
8267
8268 2019-04-08  Tom Tromey  <tom@tromey.com>
8269
8270         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8271         Remove.
8272         (gdb_exception_error): Rename from
8273         gdb_exception_RETURN_MASK_ERROR.
8274         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8275         (gdb_quit_bad_alloc): Update.
8276         * aarch64-tdep.c: Update.
8277         * ada-lang.c: Update.
8278         * ada-typeprint.c: Update.
8279         * ada-valprint.c: Update.
8280         * amd64-tdep.c: Update.
8281         * arch-utils.c: Update.
8282         * break-catch-throw.c: Update.
8283         * breakpoint.c: Update.
8284         * btrace.c: Update.
8285         * c-varobj.c: Update.
8286         * cli/cli-cmds.c: Update.
8287         * cli/cli-interp.c: Update.
8288         * cli/cli-script.c: Update.
8289         * common/common-exceptions.c: Update.
8290         * common/new-op.c: Update.
8291         * common/selftest.c: Update.
8292         * compile/compile-c-symbols.c: Update.
8293         * compile/compile-cplus-symbols.c: Update.
8294         * compile/compile-object-load.c: Update.
8295         * compile/compile-object-run.c: Update.
8296         * completer.c: Update.
8297         * corelow.c: Update.
8298         * cp-abi.c: Update.
8299         * cp-support.c: Update.
8300         * cp-valprint.c: Update.
8301         * darwin-nat.c: Update.
8302         * disasm-selftests.c: Update.
8303         * dtrace-probe.c: Update.
8304         * dwarf-index-cache.c: Update.
8305         * dwarf-index-write.c: Update.
8306         * dwarf2-frame-tailcall.c: Update.
8307         * dwarf2-frame.c: Update.
8308         * dwarf2loc.c: Update.
8309         * dwarf2read.c: Update.
8310         * eval.c: Update.
8311         * event-loop.c: Update.
8312         * event-top.c: Update.
8313         * exec.c: Update.
8314         * f-valprint.c: Update.
8315         * fbsd-tdep.c: Update.
8316         * frame-unwind.c: Update.
8317         * frame.c: Update.
8318         * gdbtypes.c: Update.
8319         * gnu-v3-abi.c: Update.
8320         * guile/guile-internal.h: Update.
8321         * guile/scm-block.c: Update.
8322         * guile/scm-breakpoint.c: Update.
8323         * guile/scm-cmd.c: Update.
8324         * guile/scm-disasm.c: Update.
8325         * guile/scm-frame.c: Update.
8326         * guile/scm-lazy-string.c: Update.
8327         * guile/scm-math.c: Update.
8328         * guile/scm-param.c: Update.
8329         * guile/scm-ports.c: Update.
8330         * guile/scm-pretty-print.c: Update.
8331         * guile/scm-symbol.c: Update.
8332         * guile/scm-symtab.c: Update.
8333         * guile/scm-type.c: Update.
8334         * guile/scm-value.c: Update.
8335         * i386-linux-tdep.c: Update.
8336         * i386-tdep.c: Update.
8337         * inf-loop.c: Update.
8338         * infcall.c: Update.
8339         * infcmd.c: Update.
8340         * infrun.c: Update.
8341         * jit.c: Update.
8342         * language.c: Update.
8343         * linespec.c: Update.
8344         * linux-fork.c: Update.
8345         * linux-nat.c: Update.
8346         * linux-tdep.c: Update.
8347         * linux-thread-db.c: Update.
8348         * main.c: Update.
8349         * mi/mi-cmd-break.c: Update.
8350         * mi/mi-cmd-stack.c: Update.
8351         * mi/mi-interp.c: Update.
8352         * mi/mi-main.c: Update.
8353         * objc-lang.c: Update.
8354         * p-valprint.c: Update.
8355         * parse.c: Update.
8356         * ppc-linux-tdep.c: Update.
8357         * printcmd.c: Update.
8358         * python/py-arch.c: Update.
8359         * python/py-breakpoint.c: Update.
8360         * python/py-cmd.c: Update.
8361         * python/py-finishbreakpoint.c: Update.
8362         * python/py-frame.c: Update.
8363         * python/py-framefilter.c: Update.
8364         * python/py-gdb-readline.c: Update.
8365         * python/py-inferior.c: Update.
8366         * python/py-infthread.c: Update.
8367         * python/py-lazy-string.c: Update.
8368         * python/py-linetable.c: Update.
8369         * python/py-objfile.c: Update.
8370         * python/py-param.c: Update.
8371         * python/py-prettyprint.c: Update.
8372         * python/py-progspace.c: Update.
8373         * python/py-record-btrace.c: Update.
8374         * python/py-record.c: Update.
8375         * python/py-symbol.c: Update.
8376         * python/py-type.c: Update.
8377         * python/py-unwind.c: Update.
8378         * python/py-utils.c: Update.
8379         * python/py-value.c: Update.
8380         * python/python.c: Update.
8381         * record-btrace.c: Update.
8382         * record-full.c: Update.
8383         * remote-fileio.c: Update.
8384         * remote.c: Update.
8385         * riscv-tdep.c: Update.
8386         * rs6000-aix-tdep.c: Update.
8387         * rs6000-tdep.c: Update.
8388         * rust-exp.y: Update.
8389         * rust-lang.c: Update.
8390         * s390-tdep.c: Update.
8391         * selftest-arch.c: Update.
8392         * solib-dsbt.c: Update.
8393         * solib-frv.c: Update.
8394         * solib-spu.c: Update.
8395         * solib-svr4.c: Update.
8396         * solib.c: Update.
8397         * sparc64-linux-tdep.c: Update.
8398         * stack.c: Update.
8399         * symfile-mem.c: Update.
8400         * symmisc.c: Update.
8401         * target.c: Update.
8402         * thread.c: Update.
8403         * top.c: Update.
8404         * tracefile-tfile.c: Update.
8405         * tui/tui.c: Update.
8406         * typeprint.c: Update.
8407         * unittests/cli-utils-selftests.c: Update.
8408         * unittests/parse-connection-spec-selftests.c: Update.
8409         * valops.c: Update.
8410         * valprint.c: Update.
8411         * value.c: Update.
8412         * varobj.c: Update.
8413         * windows-nat.c: Update.
8414         * x86-linux-nat.c: Update.
8415         * xml-support.c: Update.
8416
8417 2019-04-08  Tom Tromey  <tom@tromey.com>
8418
8419         * xml-support.c: Use C++ exception handling.
8420         * x86-linux-nat.c: Use C++ exception handling.
8421         * windows-nat.c: Use C++ exception handling.
8422         * varobj.c: Use C++ exception handling.
8423         * value.c: Use C++ exception handling.
8424         * valprint.c: Use C++ exception handling.
8425         * valops.c: Use C++ exception handling.
8426         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8427         handling.
8428         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8429         * typeprint.c: Use C++ exception handling.
8430         * tui/tui.c: Use C++ exception handling.
8431         * tracefile-tfile.c: Use C++ exception handling.
8432         * top.c: Use C++ exception handling.
8433         * thread.c: Use C++ exception handling.
8434         * target.c: Use C++ exception handling.
8435         * symmisc.c: Use C++ exception handling.
8436         * symfile-mem.c: Use C++ exception handling.
8437         * stack.c: Use C++ exception handling.
8438         * sparc64-linux-tdep.c: Use C++ exception handling.
8439         * solib.c: Use C++ exception handling.
8440         * solib-svr4.c: Use C++ exception handling.
8441         * solib-spu.c: Use C++ exception handling.
8442         * solib-frv.c: Use C++ exception handling.
8443         * solib-dsbt.c: Use C++ exception handling.
8444         * selftest-arch.c: Use C++ exception handling.
8445         * s390-tdep.c: Use C++ exception handling.
8446         * rust-lang.c: Use C++ exception handling.
8447         * rust-exp.y: Use C++ exception handling.
8448         * rs6000-tdep.c: Use C++ exception handling.
8449         * rs6000-aix-tdep.c: Use C++ exception handling.
8450         * riscv-tdep.c: Use C++ exception handling.
8451         * remote.c: Use C++ exception handling.
8452         * remote-fileio.c: Use C++ exception handling.
8453         * record-full.c: Use C++ exception handling.
8454         * record-btrace.c: Use C++ exception handling.
8455         * python/python.c: Use C++ exception handling.
8456         * python/py-value.c: Use C++ exception handling.
8457         * python/py-utils.c: Use C++ exception handling.
8458         * python/py-unwind.c: Use C++ exception handling.
8459         * python/py-type.c: Use C++ exception handling.
8460         * python/py-symbol.c: Use C++ exception handling.
8461         * python/py-record.c: Use C++ exception handling.
8462         * python/py-record-btrace.c: Use C++ exception handling.
8463         * python/py-progspace.c: Use C++ exception handling.
8464         * python/py-prettyprint.c: Use C++ exception handling.
8465         * python/py-param.c: Use C++ exception handling.
8466         * python/py-objfile.c: Use C++ exception handling.
8467         * python/py-linetable.c: Use C++ exception handling.
8468         * python/py-lazy-string.c: Use C++ exception handling.
8469         * python/py-infthread.c: Use C++ exception handling.
8470         * python/py-inferior.c: Use C++ exception handling.
8471         * python/py-gdb-readline.c: Use C++ exception handling.
8472         * python/py-framefilter.c: Use C++ exception handling.
8473         * python/py-frame.c: Use C++ exception handling.
8474         * python/py-finishbreakpoint.c: Use C++ exception handling.
8475         * python/py-cmd.c: Use C++ exception handling.
8476         * python/py-breakpoint.c: Use C++ exception handling.
8477         * python/py-arch.c: Use C++ exception handling.
8478         * printcmd.c: Use C++ exception handling.
8479         * ppc-linux-tdep.c: Use C++ exception handling.
8480         * parse.c: Use C++ exception handling.
8481         * p-valprint.c: Use C++ exception handling.
8482         * objc-lang.c: Use C++ exception handling.
8483         * mi/mi-main.c: Use C++ exception handling.
8484         * mi/mi-interp.c: Use C++ exception handling.
8485         * mi/mi-cmd-stack.c: Use C++ exception handling.
8486         * mi/mi-cmd-break.c: Use C++ exception handling.
8487         * main.c: Use C++ exception handling.
8488         * linux-thread-db.c: Use C++ exception handling.
8489         * linux-tdep.c: Use C++ exception handling.
8490         * linux-nat.c: Use C++ exception handling.
8491         * linux-fork.c: Use C++ exception handling.
8492         * linespec.c: Use C++ exception handling.
8493         * language.c: Use C++ exception handling.
8494         * jit.c: Use C++ exception handling.
8495         * infrun.c: Use C++ exception handling.
8496         * infcmd.c: Use C++ exception handling.
8497         * infcall.c: Use C++ exception handling.
8498         * inf-loop.c: Use C++ exception handling.
8499         * i386-tdep.c: Use C++ exception handling.
8500         * i386-linux-tdep.c: Use C++ exception handling.
8501         * guile/scm-value.c: Use C++ exception handling.
8502         * guile/scm-type.c: Use C++ exception handling.
8503         * guile/scm-symtab.c: Use C++ exception handling.
8504         * guile/scm-symbol.c: Use C++ exception handling.
8505         * guile/scm-pretty-print.c: Use C++ exception handling.
8506         * guile/scm-ports.c: Use C++ exception handling.
8507         * guile/scm-param.c: Use C++ exception handling.
8508         * guile/scm-math.c: Use C++ exception handling.
8509         * guile/scm-lazy-string.c: Use C++ exception handling.
8510         * guile/scm-frame.c: Use C++ exception handling.
8511         * guile/scm-disasm.c: Use C++ exception handling.
8512         * guile/scm-cmd.c: Use C++ exception handling.
8513         * guile/scm-breakpoint.c: Use C++ exception handling.
8514         * guile/scm-block.c: Use C++ exception handling.
8515         * guile/guile-internal.h: Use C++ exception handling.
8516         * gnu-v3-abi.c: Use C++ exception handling.
8517         * gdbtypes.c: Use C++ exception handling.
8518         * frame.c: Use C++ exception handling.
8519         * frame-unwind.c: Use C++ exception handling.
8520         * fbsd-tdep.c: Use C++ exception handling.
8521         * f-valprint.c: Use C++ exception handling.
8522         * exec.c: Use C++ exception handling.
8523         * event-top.c: Use C++ exception handling.
8524         * event-loop.c: Use C++ exception handling.
8525         * eval.c: Use C++ exception handling.
8526         * dwarf2read.c: Use C++ exception handling.
8527         * dwarf2loc.c: Use C++ exception handling.
8528         * dwarf2-frame.c: Use C++ exception handling.
8529         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8530         * dwarf-index-write.c: Use C++ exception handling.
8531         * dwarf-index-cache.c: Use C++ exception handling.
8532         * dtrace-probe.c: Use C++ exception handling.
8533         * disasm-selftests.c: Use C++ exception handling.
8534         * darwin-nat.c: Use C++ exception handling.
8535         * cp-valprint.c: Use C++ exception handling.
8536         * cp-support.c: Use C++ exception handling.
8537         * cp-abi.c: Use C++ exception handling.
8538         * corelow.c: Use C++ exception handling.
8539         * completer.c: Use C++ exception handling.
8540         * compile/compile-object-run.c: Use C++ exception handling.
8541         * compile/compile-object-load.c: Use C++ exception handling.
8542         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8543         * compile/compile-c-symbols.c: Use C++ exception handling.
8544         * common/selftest.c: Use C++ exception handling.
8545         * common/new-op.c: Use C++ exception handling.
8546         * cli/cli-script.c: Use C++ exception handling.
8547         * cli/cli-interp.c: Use C++ exception handling.
8548         * cli/cli-cmds.c: Use C++ exception handling.
8549         * c-varobj.c: Use C++ exception handling.
8550         * btrace.c: Use C++ exception handling.
8551         * breakpoint.c: Use C++ exception handling.
8552         * break-catch-throw.c: Use C++ exception handling.
8553         * arch-utils.c: Use C++ exception handling.
8554         * amd64-tdep.c: Use C++ exception handling.
8555         * ada-valprint.c: Use C++ exception handling.
8556         * ada-typeprint.c: Use C++ exception handling.
8557         * ada-lang.c: Use C++ exception handling.
8558         * aarch64-tdep.c: Use C++ exception handling.
8559
8560 2019-04-08  Tom Tromey  <tom@tromey.com>
8561
8562         * xml-support.c (gdb_xml_parser::parse): Update.
8563         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8564         * value.c (show_convenience): Update.
8565         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8566         (test_parse_flags_qcs): Update.
8567         * thread.c (thr_try_catch_cmd): Update.
8568         * target.c (target_translate_tls_address): Update.
8569         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8570         (info_frame_command_core, frame_apply_command_count): Update.
8571         * rust-exp.y (rust_lex_exception_test): Update.
8572         * riscv-tdep.c (riscv_print_one_register_info): Update.
8573         * remote.c (remote_target::enable_btrace): Update.
8574         * record-btrace.c (record_btrace_enable_warn): Update.
8575         * python/py-utils.c (gdbpy_convert_exception): Update.
8576         * printcmd.c (do_one_display, print_variable_and_value): Update.
8577         * mi/mi-main.c (mi_print_exception): Update.
8578         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8579         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8580         * linux-nat.c (linux_nat_target::attach): Update.
8581         * linux-fork.c (class scoped_switch_fork_info): Update.
8582         * infrun.c (displaced_step_prepare): Update.
8583         * infcall.c (call_function_by_hand_dummy): Update.
8584         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8585         * gnu-v3-abi.c (print_one_vtable): Update.
8586         * frame.c (get_prev_frame_always): Update.
8587         * f-valprint.c (info_common_command_for_block): Update.
8588         * exec.c (try_open_exec_file): Update.
8589         * exceptions.c (print_exception, exception_print)
8590         (exception_fprintf, exception_print_same): Update.
8591         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8592         * dwarf-index-cache.c (index_cache::store)
8593         (index_cache::lookup_gdb_index): Update.
8594         * darwin-nat.c (maybe_cache_shell): Update.
8595         * cp-valprint.c (cp_print_value_fields): Update.
8596         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8597         (gcc_cplus_symbol_address): Update.
8598         * compile/compile-c-symbols.c (gcc_convert_symbol)
8599         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8600         * common/selftest.c: Update.
8601         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8602         a std::string.
8603         (exception_try_scope_entry, exception_try_scope_exit): Don't
8604         declare.
8605         (struct exception_try_scope): Remove.
8606         (TRY): Don't use exception_try_scope.
8607         (struct gdb_exception): Add constructor, operator=.
8608         <what>: New method.
8609         (struct gdb_exception_RETURN_MASK_ALL)
8610         (struct gdb_exception_RETURN_MASK_ERROR)
8611         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8612         (struct gdb_quit_bad_alloc): Update.
8613         * common/common-exceptions.c (exception_none): Change
8614         initializer.
8615         (struct catcher) <state, exception>: Initialize inline.
8616         <prev>: Remove member.
8617         (current_catcher): Remove.
8618         (catchers): New global.
8619         (exceptions_state_mc_init): Simplify.
8620         (catcher_pop): Remove.
8621         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8622         (try_scope_depth, exception_try_scope_entry)
8623         (exception_try_scope_exit): Remove.
8624         (throw_exception_sjlj): Update.
8625         (exception_messages, exception_messages_size): Remove.
8626         (throw_it): Simplify.
8627         (gdb_exception_sliced_copy): Remove.
8628         (throw_exception_cxx): Update.
8629         * cli/cli-script.c (script_from_file): Update.
8630         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8631         Update.
8632         * ada-valprint.c (ada_val_print): Update.
8633         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8634         (create_excep_cond_exprs): Update.
8635
8636 2019-04-08  Tom Tromey  <tom@tromey.com>
8637
8638         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8639         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8640         (TRY, CATCH, END_CATCH): Remove some definitions.
8641         * common/common-exceptions.c: Don't use GDB_XCPT.
8642         (catcher_list_size): Remove.
8643         (throw_exception, throw_it): Simplify.
8644
8645 2019-04-05  Tom Tromey  <tom@tromey.com>
8646
8647         Revert the header-sorting patch.
8648         * ft32-tdep.c: Revert.
8649         * frv-tdep.c: Revert.
8650         * frv-linux-tdep.c: Revert.
8651         * frame.c: Revert.
8652         * frame-unwind.c: Revert.
8653         * frame-base.c: Revert.
8654         * fork-child.c: Revert.
8655         * findvar.c: Revert.
8656         * findcmd.c: Revert.
8657         * filesystem.c: Revert.
8658         * filename-seen-cache.h: Revert.
8659         * filename-seen-cache.c: Revert.
8660         * fbsd-tdep.c: Revert.
8661         * fbsd-nat.h: Revert.
8662         * fbsd-nat.c: Revert.
8663         * f-valprint.c: Revert.
8664         * f-typeprint.c: Revert.
8665         * f-lang.c: Revert.
8666         * extension.h: Revert.
8667         * extension.c: Revert.
8668         * extension-priv.h: Revert.
8669         * expprint.c: Revert.
8670         * exec.h: Revert.
8671         * exec.c: Revert.
8672         * exceptions.c: Revert.
8673         * event-top.c: Revert.
8674         * event-loop.c: Revert.
8675         * eval.c: Revert.
8676         * elfread.c: Revert.
8677         * dwarf2read.h: Revert.
8678         * dwarf2read.c: Revert.
8679         * dwarf2loc.c: Revert.
8680         * dwarf2expr.h: Revert.
8681         * dwarf2expr.c: Revert.
8682         * dwarf2-frame.c: Revert.
8683         * dwarf2-frame-tailcall.c: Revert.
8684         * dwarf-index-write.h: Revert.
8685         * dwarf-index-write.c: Revert.
8686         * dwarf-index-common.c: Revert.
8687         * dwarf-index-cache.h: Revert.
8688         * dwarf-index-cache.c: Revert.
8689         * dummy-frame.c: Revert.
8690         * dtrace-probe.c: Revert.
8691         * disasm.h: Revert.
8692         * disasm.c: Revert.
8693         * disasm-selftests.c: Revert.
8694         * dictionary.c: Revert.
8695         * dicos-tdep.c: Revert.
8696         * demangle.c: Revert.
8697         * dcache.h: Revert.
8698         * dcache.c: Revert.
8699         * darwin-nat.h: Revert.
8700         * darwin-nat.c: Revert.
8701         * darwin-nat-info.c: Revert.
8702         * d-valprint.c: Revert.
8703         * d-namespace.c: Revert.
8704         * d-lang.c: Revert.
8705         * ctf.c: Revert.
8706         * csky-tdep.c: Revert.
8707         * csky-linux-tdep.c: Revert.
8708         * cris-tdep.c: Revert.
8709         * cris-linux-tdep.c: Revert.
8710         * cp-valprint.c: Revert.
8711         * cp-support.c: Revert.
8712         * cp-namespace.c: Revert.
8713         * cp-abi.c: Revert.
8714         * corelow.c: Revert.
8715         * corefile.c: Revert.
8716         * continuations.c: Revert.
8717         * completer.h: Revert.
8718         * completer.c: Revert.
8719         * complaints.c: Revert.
8720         * coffread.c: Revert.
8721         * coff-pe-read.c: Revert.
8722         * cli-out.h: Revert.
8723         * cli-out.c: Revert.
8724         * charset.c: Revert.
8725         * c-varobj.c: Revert.
8726         * c-valprint.c: Revert.
8727         * c-typeprint.c: Revert.
8728         * c-lang.c: Revert.
8729         * buildsym.c: Revert.
8730         * buildsym-legacy.c: Revert.
8731         * build-id.h: Revert.
8732         * build-id.c: Revert.
8733         * btrace.c: Revert.
8734         * bsd-uthread.c: Revert.
8735         * breakpoint.h: Revert.
8736         * breakpoint.c: Revert.
8737         * break-catch-throw.c: Revert.
8738         * break-catch-syscall.c: Revert.
8739         * break-catch-sig.c: Revert.
8740         * blockframe.c: Revert.
8741         * block.c: Revert.
8742         * bfin-tdep.c: Revert.
8743         * bfin-linux-tdep.c: Revert.
8744         * bfd-target.c: Revert.
8745         * bcache.c: Revert.
8746         * ax-general.c: Revert.
8747         * ax-gdb.h: Revert.
8748         * ax-gdb.c: Revert.
8749         * avr-tdep.c: Revert.
8750         * auxv.c: Revert.
8751         * auto-load.c: Revert.
8752         * arm-wince-tdep.c: Revert.
8753         * arm-tdep.c: Revert.
8754         * arm-symbian-tdep.c: Revert.
8755         * arm-pikeos-tdep.c: Revert.
8756         * arm-obsd-tdep.c: Revert.
8757         * arm-nbsd-tdep.c: Revert.
8758         * arm-nbsd-nat.c: Revert.
8759         * arm-linux-tdep.c: Revert.
8760         * arm-linux-nat.c: Revert.
8761         * arm-fbsd-tdep.c: Revert.
8762         * arm-fbsd-nat.c: Revert.
8763         * arm-bsd-tdep.c: Revert.
8764         * arch-utils.c: Revert.
8765         * arc-tdep.c: Revert.
8766         * arc-newlib-tdep.c: Revert.
8767         * annotate.h: Revert.
8768         * annotate.c: Revert.
8769         * amd64-windows-tdep.c: Revert.
8770         * amd64-windows-nat.c: Revert.
8771         * amd64-tdep.c: Revert.
8772         * amd64-sol2-tdep.c: Revert.
8773         * amd64-obsd-tdep.c: Revert.
8774         * amd64-obsd-nat.c: Revert.
8775         * amd64-nbsd-tdep.c: Revert.
8776         * amd64-nbsd-nat.c: Revert.
8777         * amd64-nat.c: Revert.
8778         * amd64-linux-tdep.c: Revert.
8779         * amd64-linux-nat.c: Revert.
8780         * amd64-fbsd-tdep.c: Revert.
8781         * amd64-fbsd-nat.c: Revert.
8782         * amd64-dicos-tdep.c: Revert.
8783         * amd64-darwin-tdep.c: Revert.
8784         * amd64-bsd-nat.c: Revert.
8785         * alpha-tdep.c: Revert.
8786         * alpha-obsd-tdep.c: Revert.
8787         * alpha-nbsd-tdep.c: Revert.
8788         * alpha-mdebug-tdep.c: Revert.
8789         * alpha-linux-tdep.c: Revert.
8790         * alpha-linux-nat.c: Revert.
8791         * alpha-bsd-tdep.c: Revert.
8792         * alpha-bsd-nat.c: Revert.
8793         * aix-thread.c: Revert.
8794         * agent.c: Revert.
8795         * addrmap.c: Revert.
8796         * ada-varobj.c: Revert.
8797         * ada-valprint.c: Revert.
8798         * ada-typeprint.c: Revert.
8799         * ada-tasks.c: Revert.
8800         * ada-lang.c: Revert.
8801         * aarch64-tdep.c: Revert.
8802         * aarch64-ravenscar-thread.c: Revert.
8803         * aarch64-newlib-tdep.c: Revert.
8804         * aarch64-linux-tdep.c: Revert.
8805         * aarch64-linux-nat.c: Revert.
8806         * aarch64-fbsd-tdep.c: Revert.
8807         * aarch64-fbsd-nat.c: Revert.
8808         * aarch32-linux-nat.c: Revert.
8809
8810 2019-04-05  Tom Tromey  <tom@tromey.com>
8811
8812         * ft32-tdep.c: Sort headers.
8813         * frv-tdep.c: Sort headers.
8814         * frv-linux-tdep.c: Sort headers.
8815         * frame.c: Sort headers.
8816         * frame-unwind.c: Sort headers.
8817         * frame-base.c: Sort headers.
8818         * fork-child.c: Sort headers.
8819         * findvar.c: Sort headers.
8820         * findcmd.c: Sort headers.
8821         * filesystem.c: Sort headers.
8822         * filename-seen-cache.h: Sort headers.
8823         * filename-seen-cache.c: Sort headers.
8824         * fbsd-tdep.c: Sort headers.
8825         * fbsd-nat.h: Sort headers.
8826         * fbsd-nat.c: Sort headers.
8827         * f-valprint.c: Sort headers.
8828         * f-typeprint.c: Sort headers.
8829         * f-lang.c: Sort headers.
8830         * extension.h: Sort headers.
8831         * extension.c: Sort headers.
8832         * extension-priv.h: Sort headers.
8833         * expprint.c: Sort headers.
8834         * exec.h: Sort headers.
8835         * exec.c: Sort headers.
8836         * exceptions.c: Sort headers.
8837         * event-top.c: Sort headers.
8838         * event-loop.c: Sort headers.
8839         * eval.c: Sort headers.
8840         * elfread.c: Sort headers.
8841         * dwarf2read.h: Sort headers.
8842         * dwarf2read.c: Sort headers.
8843         * dwarf2loc.c: Sort headers.
8844         * dwarf2expr.h: Sort headers.
8845         * dwarf2expr.c: Sort headers.
8846         * dwarf2-frame.c: Sort headers.
8847         * dwarf2-frame-tailcall.c: Sort headers.
8848         * dwarf-index-write.h: Sort headers.
8849         * dwarf-index-write.c: Sort headers.
8850         * dwarf-index-common.c: Sort headers.
8851         * dwarf-index-cache.h: Sort headers.
8852         * dwarf-index-cache.c: Sort headers.
8853         * dummy-frame.c: Sort headers.
8854         * dtrace-probe.c: Sort headers.
8855         * disasm.h: Sort headers.
8856         * disasm.c: Sort headers.
8857         * disasm-selftests.c: Sort headers.
8858         * dictionary.c: Sort headers.
8859         * dicos-tdep.c: Sort headers.
8860         * demangle.c: Sort headers.
8861         * dcache.h: Sort headers.
8862         * dcache.c: Sort headers.
8863         * darwin-nat.h: Sort headers.
8864         * darwin-nat.c: Sort headers.
8865         * darwin-nat-info.c: Sort headers.
8866         * d-valprint.c: Sort headers.
8867         * d-namespace.c: Sort headers.
8868         * d-lang.c: Sort headers.
8869         * ctf.c: Sort headers.
8870         * csky-tdep.c: Sort headers.
8871         * csky-linux-tdep.c: Sort headers.
8872         * cris-tdep.c: Sort headers.
8873         * cris-linux-tdep.c: Sort headers.
8874         * cp-valprint.c: Sort headers.
8875         * cp-support.c: Sort headers.
8876         * cp-namespace.c: Sort headers.
8877         * cp-abi.c: Sort headers.
8878         * corelow.c: Sort headers.
8879         * corefile.c: Sort headers.
8880         * continuations.c: Sort headers.
8881         * completer.h: Sort headers.
8882         * completer.c: Sort headers.
8883         * complaints.c: Sort headers.
8884         * coffread.c: Sort headers.
8885         * coff-pe-read.c: Sort headers.
8886         * cli-out.h: Sort headers.
8887         * cli-out.c: Sort headers.
8888         * charset.c: Sort headers.
8889         * c-varobj.c: Sort headers.
8890         * c-valprint.c: Sort headers.
8891         * c-typeprint.c: Sort headers.
8892         * c-lang.c: Sort headers.
8893         * buildsym.c: Sort headers.
8894         * buildsym-legacy.c: Sort headers.
8895         * build-id.h: Sort headers.
8896         * build-id.c: Sort headers.
8897         * btrace.c: Sort headers.
8898         * bsd-uthread.c: Sort headers.
8899         * breakpoint.h: Sort headers.
8900         * breakpoint.c: Sort headers.
8901         * break-catch-throw.c: Sort headers.
8902         * break-catch-syscall.c: Sort headers.
8903         * break-catch-sig.c: Sort headers.
8904         * blockframe.c: Sort headers.
8905         * block.c: Sort headers.
8906         * bfin-tdep.c: Sort headers.
8907         * bfin-linux-tdep.c: Sort headers.
8908         * bfd-target.c: Sort headers.
8909         * bcache.c: Sort headers.
8910         * ax-general.c: Sort headers.
8911         * ax-gdb.h: Sort headers.
8912         * ax-gdb.c: Sort headers.
8913         * avr-tdep.c: Sort headers.
8914         * auxv.c: Sort headers.
8915         * auto-load.c: Sort headers.
8916         * arm-wince-tdep.c: Sort headers.
8917         * arm-tdep.c: Sort headers.
8918         * arm-symbian-tdep.c: Sort headers.
8919         * arm-pikeos-tdep.c: Sort headers.
8920         * arm-obsd-tdep.c: Sort headers.
8921         * arm-nbsd-tdep.c: Sort headers.
8922         * arm-nbsd-nat.c: Sort headers.
8923         * arm-linux-tdep.c: Sort headers.
8924         * arm-linux-nat.c: Sort headers.
8925         * arm-fbsd-tdep.c: Sort headers.
8926         * arm-fbsd-nat.c: Sort headers.
8927         * arm-bsd-tdep.c: Sort headers.
8928         * arch-utils.c: Sort headers.
8929         * arc-tdep.c: Sort headers.
8930         * arc-newlib-tdep.c: Sort headers.
8931         * annotate.h: Sort headers.
8932         * annotate.c: Sort headers.
8933         * amd64-windows-tdep.c: Sort headers.
8934         * amd64-windows-nat.c: Sort headers.
8935         * amd64-tdep.c: Sort headers.
8936         * amd64-sol2-tdep.c: Sort headers.
8937         * amd64-obsd-tdep.c: Sort headers.
8938         * amd64-obsd-nat.c: Sort headers.
8939         * amd64-nbsd-tdep.c: Sort headers.
8940         * amd64-nbsd-nat.c: Sort headers.
8941         * amd64-nat.c: Sort headers.
8942         * amd64-linux-tdep.c: Sort headers.
8943         * amd64-linux-nat.c: Sort headers.
8944         * amd64-fbsd-tdep.c: Sort headers.
8945         * amd64-fbsd-nat.c: Sort headers.
8946         * amd64-dicos-tdep.c: Sort headers.
8947         * amd64-darwin-tdep.c: Sort headers.
8948         * amd64-bsd-nat.c: Sort headers.
8949         * alpha-tdep.c: Sort headers.
8950         * alpha-obsd-tdep.c: Sort headers.
8951         * alpha-nbsd-tdep.c: Sort headers.
8952         * alpha-mdebug-tdep.c: Sort headers.
8953         * alpha-linux-tdep.c: Sort headers.
8954         * alpha-linux-nat.c: Sort headers.
8955         * alpha-bsd-tdep.c: Sort headers.
8956         * alpha-bsd-nat.c: Sort headers.
8957         * aix-thread.c: Sort headers.
8958         * agent.c: Sort headers.
8959         * addrmap.c: Sort headers.
8960         * ada-varobj.c: Sort headers.
8961         * ada-valprint.c: Sort headers.
8962         * ada-typeprint.c: Sort headers.
8963         * ada-tasks.c: Sort headers.
8964         * ada-lang.c: Sort headers.
8965         * aarch64-tdep.c: Sort headers.
8966         * aarch64-ravenscar-thread.c: Sort headers.
8967         * aarch64-newlib-tdep.c: Sort headers.
8968         * aarch64-linux-tdep.c: Sort headers.
8969         * aarch64-linux-nat.c: Sort headers.
8970         * aarch64-fbsd-tdep.c: Sort headers.
8971         * aarch64-fbsd-nat.c: Sort headers.
8972         * aarch32-linux-nat.c: Sort headers.
8973
8974 2019-04-04  Tom Tromey  <tom@tromey.com>
8975
8976         * varobj.c (varobj_create): Update.
8977         * rust-exp.y (struct rust_parser) <update_innermost_block,
8978         lookup_symbol>: New methods.
8979         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8980         Rename.
8981         (rust_parser::rust_lookup_type)
8982         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8983         * printcmd.c (display_command, do_one_display): Update.
8984         * parser-defs.h (struct parser_state) <parser_state>: Add
8985         "tracker" parameter.
8986         (block_tracker): New member.
8987         (class innermost_block_tracker) <innermost_block_tracker>: Add
8988         "types" parameter.
8989         <reset>: Remove method.
8990         (innermost_block): Don't declare.
8991         (null_post_parser): Update.
8992         * parse.c (innermost_block): Remove global.
8993         (write_dollar_variable): Update.
8994         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8995         Remove "tracker_types" parameter.
8996         (parse_expression): Add "tracker" parameter.
8997         (parse_expression_for_completion): Update.
8998         (null_post_parser): Add "tracker" parameter.
8999         * p-exp.y: Update rules.
9000         * m2-exp.y: Update rules.
9001         * language.h (struct language_defn) <la_post_parser>: Add
9002         "tracker" parameter.
9003         * go-exp.y: Update rules.
9004         * f-exp.y: Update rules.
9005         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9006         parameter.
9007         * d-exp.y: Update rules.
9008         * c-exp.y: Update rules.
9009         * breakpoint.c (set_breakpoint_condition): Create an
9010         innermost_block_tracker.
9011         (watch_command_1): Likewise.
9012         * ada-lang.c (resolve): Add "tracker" parameter.
9013         (resolve_subexp): Likewise.
9014         * ada-exp.y (write_var_from_sym): Update.
9015
9016 2019-04-04  Tom Tromey  <tom@tromey.com>
9017
9018         * type-stack.h: New file.
9019         * type-stack.c: New file.
9020         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9021         type-stack.h.
9022         (insert_into_type_stack, insert_type, push_type, push_type_int)
9023         (insert_type_address_space, pop_type, pop_type_int)
9024         (pop_typelist, pop_type_stack, append_type_stack)
9025         (push_type_stack, get_type_stack, push_typelist)
9026         (follow_type_instance_flags, follow_types): Don't declare.
9027         * parse.c (type_stack): Remove global.
9028         (parse_exp_in_context): Update.
9029         (insert_into_type_stack, insert_type, push_type, push_type_int)
9030         (insert_type_address_space, pop_type, pop_type_int)
9031         (pop_typelist, pop_type_stack, append_type_stack)
9032         (push_type_stack, get_type_stack, push_typelist)
9033         (follow_type_instance_flags, follow_types): Remove (moved to
9034         type-stack.c).
9035         * f-exp.y (type_stack): New global.
9036         Update rules.
9037         (push_kind_type, f_parse): Update.
9038         * d-exp.y (type_stack): New global.
9039         Update rules.
9040         (d_parse): Update.
9041         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9042         Update rules.
9043         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9044         (HFILES_NO_SRCDIR): Add type-stack.h.
9045
9046 2019-04-04  Tom Tromey  <tom@tromey.com>
9047
9048         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9049         (rust_parser::convert_ast_to_expression, rust_parse)
9050         (rust_lex_test_completion, rust_lex_tests): Update.
9051         * parser-defs.h (struct expr_completion_state): New.
9052         (struct parser_state) <parser_state>: Add completion parameter.
9053         <mark_struct_expression, mark_completion_tag>: New methods.
9054         <parse_completion, m_completion_state>: New members.
9055         (prefixify_expression, null_post_parser): Update.
9056         (mark_struct_expression, mark_completion_tag): Don't declare.
9057         * parse.c (parse_completion, expout_last_struct)
9058         (expout_tag_completion_type, expout_completion_name): Remove
9059         globals.
9060         (parser_state::mark_struct_expression)
9061         (parser_state::mark_completion_tag): Now methods.
9062         (prefixify_expression): Add last_struct parameter.
9063         (prefixify_subexp): Likewise.
9064         (parse_exp_1): Update.
9065         (parse_exp_in_context): Add cstate parameter.  Update.
9066         (parse_expression_for_completion): Create an
9067         expr_completion_state.
9068         (null_post_parser): Add "completion" parameter.
9069         * p-exp.y: Update rules.
9070         (yylex): Update.
9071         * language.h (struct language_defn) <la_post_parser>: Add
9072         "completing" parameter.
9073         * go-exp.y: Update rules.
9074         (lex_one_token): Update.
9075         * expression.h (parse_completion): Don't declare.
9076         * d-exp.y: Update rules.
9077         (lex_one_token): Update rules.
9078         * c-exp.y: Update rules.
9079         (lex_one_token): Update.
9080         * ada-lang.c (resolve): Add "parse_completion" parameter.
9081         (resolve_subexp): Likewise.
9082         (ada_resolve_function): Likewise.
9083
9084 2019-04-04  Tom Tromey  <tom@tromey.com>
9085
9086         * parser-defs.h (struct parser_state) <start_arglist,
9087         end_arglist>: New methods.
9088         <arglist_len, m_funcall_chain>: New members.
9089         (arglist_len, start_arglist, end_arglist): Don't declare.
9090         * parse.c (arglist_len, funcall_chain): Remove global.
9091         (start_arglist, end_arglist): Remove functions.
9092         (parse_exp_in_context): Update.
9093         * p-exp.y: Update rules.
9094         * m2-exp.y: Update rules.
9095         * go-exp.y: Update rules.
9096         * f-exp.y: Update rules.
9097         * d-exp.y: Update rules.
9098         * c-exp.y: Update rules.
9099
9100 2019-04-04  Tom Tromey  <tom@tromey.com>
9101
9102         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9103         lex_operator, push_back>: New methods.
9104         Update all rules.
9105         (rust_parser::lex_hex, lex_escape): Rename and update.
9106         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9107         (rust_parser::lex_operator): Rename and update.
9108         (rust_parser::lex_number, rustyylex, rustyyerror)
9109         (rust_lex_test_init, rust_lex_test_sequence)
9110         (rust_lex_test_push_back, rust_lex_tests): Update.
9111         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9112         parameter.
9113         <lexptr, prev_lexptr>: New members.
9114         (lexptr, prev_lexptr): Don't declare.
9115         * parse.c (lexptr, prev_lexptr): Remove globals.
9116         (parse_exp_in_context): Update.
9117         * p-exp.y (yylex, yyerror): Update.
9118         * m2-exp.y (parse_number, yylex, yyerror): Update.
9119         * go-exp.y (lex_one_token, yyerror): Update.
9120         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9121         * d-exp.y (lex_one_token, yyerror): Update.
9122         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9123         (lex_one_token, yyerror): Update.
9124         * ada-lex.l (YY_INPUT): Update.
9125         (rewind_to_char): Update.
9126         * ada-exp.y (yyerror): Update.
9127
9128 2019-04-04  Tom Tromey  <tom@tromey.com>
9129
9130         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9131         * parser-defs.h (struct parser_state) <parser_state>: Add new
9132         parameter.
9133         <comma_terminates>: New member.
9134         (comma_terminates): Don't declare global.
9135         * parse.c (comma_terminates): Remove global.
9136         (parse_exp_in_context): Update.
9137         * p-exp.y (yylex): Update.
9138         * m2-exp.y (yylex): Update.
9139         * go-exp.y (lex_one_token): Update.
9140         * f-exp.y (yylex): Update.
9141         * d-exp.y (lex_one_token): Update.
9142         * c-exp.y (lex_one_token): Update.
9143         * ada-lex.l: Update.
9144
9145 2019-04-04  Tom Tromey  <tom@tromey.com>
9146
9147         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9148         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9149         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9150         * parser-defs.h (paren_depth): Don't declare.
9151         * parse.c (paren_depth): Remove global.
9152         (parse_exp_in_context): Update.
9153         * p-exp.y (paren_depth): New global.
9154         (pascal_parse): Initialize it.
9155         * m2-exp.y (paren_depth): New global.
9156         (m2_parse): Initialize it.
9157         * go-exp.y (paren_depth): New global.
9158         (go_parse): Initialize it.
9159         * f-exp.y (paren_depth): New global.
9160         (f_parse): Initialize it.
9161         * d-exp.y (paren_depth): New global.
9162         (d_parse): Initialize it.
9163         * c-exp.y (paren_depth): New global.
9164         (c_parse): Initialize it.
9165         * ada-lex.l (paren_depth): New global.
9166         (lexer_init): Initialize it.
9167
9168 2019-04-04  Tom Tromey  <tom@tromey.com>
9169
9170         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9171         (rust_parser::convert_ast_to_type)
9172         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9173         * parser-defs.h (struct parser_state) <parser_state>: Add
9174         parameters.  Initialize new members.
9175         <expression_context_block, expression_context_pc>: New members.
9176         * parse.c (expression_context_block, expression_context_pc):
9177         Remove globals.
9178         (parse_exp_in_context): Update.
9179         * p-exp.y: Update all rules.
9180         (yylex): Update.
9181         * m2-exp.y: Update all rules.
9182         (yylex): Update.
9183         * go-exp.y (yylex): Update.
9184         * f-exp.y (yylex): Update.
9185         * d-exp.y: Update all rules.
9186         (yylex): Update.
9187         * c-exp.y: Update all rules.
9188         (lex_one_token, classify_name, yylex, c_parse): Update.
9189         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9190
9191 2019-04-04  Tom Tromey  <tom@tromey.com>
9192
9193         * gdbarch.h, gdbarch.c: Rebuild.
9194         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9195         * stap-probe.h:
9196         (struct stap_parse_info): Replace "parser_state" with
9197         "expr_builder".
9198         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9199         (parser_state): New class.
9200         * parse.c (expr_builder): Rename.
9201         (expr_builder::release): Rename.
9202         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9203         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9204         (write_exp_elt_longcst, write_exp_elt_floatcst)
9205         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9206         (write_exp_string_vector, write_exp_bitstring)
9207         (write_exp_msymbol, mark_struct_expression)
9208         (write_dollar_variable)
9209         (insert_type_address_space, increase_expout_size): Replace
9210         "parser_state" with "expr_builder".
9211         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9212         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9213         "parser_state" with "expr_builder".
9214
9215 2019-04-04  Tom Tromey  <tom@tromey.com>
9216
9217         * rust-exp.y: Replace "parse_language" with method call.
9218         * p-exp.y:
9219         (yylex): Replace "parse_language" with method call.
9220         * m2-exp.y:
9221         (yylex): Replace "parse_language" with method call.
9222         * go-exp.y (classify_name): Replace "parse_language" with method
9223         call.
9224         * f-exp.y (yylex): Replace "parse_language" with method call.
9225         * d-exp.y (lex_one_token): Replace "parse_language" with method
9226         call.
9227         * c-exp.y:
9228         (lex_one_token, classify_name, yylex): Replace "parse_language"
9229         with method call.
9230         * ada-exp.y (find_primitive_type, type_char)
9231         (type_system_address): Replace "parse_language" with method call.
9232
9233 2019-04-04  Tom Tromey  <tom@tromey.com>
9234
9235         * rust-exp.y: Replace "parse_gdbarch" with method call.
9236         * parse.c (write_dollar_variable, insert_type_address_space):
9237         Replace "parse_gdbarch" with method call.
9238         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9239         call.
9240         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9241         call.
9242         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9243         "parse_gdbarch" with method call.
9244         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9245         with method call.
9246         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9247         "parse_gdbarch" with method call.
9248         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9249         "parse_gdbarch" with method call.
9250         * c-exp.y (parse_type, parse_number, classify_name): Replace
9251         "parse_gdbarch" with method call.
9252         * ada-lex.l: Replace "parse_gdbarch" with method call.
9253         * ada-exp.y (parse_type, find_primitive_type, type_char)
9254         (type_system_address): Replace "parse_gdbarch" with method call.
9255
9256 2019-04-04  Tom Tromey  <tom@tromey.com>
9257
9258         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9259         * stap-probe.c (stap_parse_argument): Update.
9260         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9261         initial_size parameter.
9262         * rust-exp.y (rust_lex_tests): Update.
9263         * parse.c (parser_state): Update.
9264         (parse_exp_in_context): Update.
9265         * parser-defs.h (struct parser_state) <parser_state>: Remove
9266         "initial_size" parameter.
9267
9268 2019-04-04  Tom Tromey  <tom@tromey.com>
9269
9270         * parser-defs.h (increase_expout_size): Don't declare.
9271         * parse.c (increase_expout_size): Now static.
9272
9273 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9274
9275         * gnu-nat.c (gnu_nat_target::wait): Fix
9276         target_waitstatus_to_string call.
9277
9278 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9279
9280         * eval.c (evaluate_subexp_standard): Handle internal functions
9281         during Fortran function call handling.
9282
9283 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9284
9285         * NEWS: Mention new internal functions.
9286         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9287         (read_base_type): Use dwarf2_init_complex_target_type.
9288         * value.c (creal_internal_fn): New function.
9289         (cimag_internal_fn): New function.
9290         (_initialize_values): Register new internal functions.
9291
9292 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9293
9294         * infrun.c (stop_all_threads): If debug_infrun, always
9295         trace the wait status after wait_one, using
9296         target_waitstatus_to_string and target_pid_to_str.
9297         (handle_inferior_event): Replace various trace of
9298         wait status kind by a single trace.
9299         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9300         wait status kind image by target_waitstatus_to_string.
9301         * target/waitstatus.c (target_waitstatus_to_string): Fix
9302         obsolete comment.
9303
9304 2019-04-01  Tom Tromey  <tromey@adacore.com>
9305
9306         PR symtab/23331:
9307         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9308
9309 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9310             Pedro Alves  <palves@redhat.com>
9311
9312         * top.c (quit_force): Call 'finalize_values'.
9313         * value.c (finalize_values): New function.
9314         * value.h (finalize_values): Declare.
9315
9316 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9317
9318         * NEWS: Announce $_gdb_major and $_gdb_minor.
9319
9320         * top.c (init_gdb_version_vars): New function.
9321         (gdb_init): Call init_gdb_version_vars.
9322
9323 2019-03-29  Tom Tromey  <tromey@adacore.com>
9324
9325         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9326         help text.  Remove dead code.
9327
9328 2019-03-29  Keith Seitz  <keiths@redhat.com>
9329
9330         From Siddhesh Poyarekar:
9331         * f-lang.h (f77_get_upperbound): Return LONGEST.
9332         (f77_get_lowerbound): Likewise.
9333         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9334         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9335         print them.
9336         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9337         plongest to format print it.
9338         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9339         (f77_get_upperbound): Likewise.
9340         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9341         LOWER_BOUND to LONGEST.
9342         (f77_create_arrayprint_offset_tbl): Likewise.
9343
9344 2019-03-29  Keith Seitz  <keiths@redhat.com>
9345
9346         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9347         %s/pulongest for TYPE_LENGTH instead of %d in format
9348         strings.
9349         * ada-typerint.c (ada_print_type): Likewise.
9350         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9351         * compile/compile-c-support.c (generate_register_struct): Likewise.
9352         * gdbtypes.c (recursive_dump_type): Likewise.
9353         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9354         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9355         instead of %d in format strings.
9356         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9357         to std::min to ULONGEST.
9358         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9359         instead of %d in format strings.
9360         * tracepoint.c (info_scope_command): Likewise.
9361         * typeprint.c (print_offset_data::update)
9362         (print_offset_data::finish): Likewise.
9363         * xtensa-tdep.c (xtensa_store_return_value)
9364         (xtensa_push_dummy_call): Likewise.
9365
9366 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9367
9368         * windows-nat.c (display_selector): Fixed format specifications
9369         for 64-bit Cygwin.
9370
9371 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9372
9373         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9374
9375 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9376
9377         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9378         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9379         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9380         (nios2_linux_init_abi): Install it.
9381
9382 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9383
9384         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9385
9386 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9387
9388         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9389
9390 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9391             Tom Tromey  <tromey@adacore.com>
9392
9393         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9394
9395 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9396
9397         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9398         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9399         method to compute the bounds of range types. Also print "[evaluated]"
9400         if the bounds' values come from a dynamic evaluation.
9401
9402 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9403
9404         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9405         whitespace when pretty printing is on.
9406
9407 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9408
9409         * ppc-linux-nat.c: Add include.
9410
9411 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9412
9413         * NEWS: Mention AArch64 Pointer Authentication.
9414
9415 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9416
9417         * arm-linux-nat.c: Add include.
9418
9419 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9420
9421         * source-cache.c (source_cache::get_source_lines): Re-read
9422         fullname after calling open_source_file.
9423
9424 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9425
9426         * NEWS: Mention TLS support for FreeBSD.
9427
9428 2019-03-25  Tom Tromey  <tromey@adacore.com>
9429
9430         * minsyms.c (BUNCH_SIZE): Update comment.
9431         (~minimal_symbol_reader): Remove old comment.
9432         (compact_minimal_symbols): Update comment.
9433         (minimal_symbol_reader::install): Remove old comment.  Update
9434         other comments.
9435
9436 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9437
9438         * s390-linux-nat.c: Add include.
9439
9440 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9441
9442         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9443         Call linux_get_hwcap.
9444         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9445         Likewise.
9446         (aarch64_linux_get_hwcap): Remove function.
9447         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9448         declaration.
9449         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9450         linux_get_hwcap.
9451         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9452         * linux-tdep.c (linux_get_hwcap): Add function.
9453         (linux_get_hwcap2): Likewise.
9454         * linux-tdep.h (linux_get_hwcap): Add declaration.
9455         (linux_get_hwcap2): Likewise.
9456         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9457         (ppc_linux_get_hwcap2): Likewise.
9458         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9459         linux_get_hwcap.
9460         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9461         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9462         (ppc_linux_nat_target::read_description): Likewise.
9463         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9464         * s390-linux-nat.c: Likewise.
9465         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9466
9467 2019-03-24  Tom Tromey  <tom@tromey.com>
9468
9469         * ada-lang.c (standard_lookup): Simplify initialization.
9470         (ada_lookup_symbol_nonlocal): Simplify return.
9471         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9472         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9473         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9474         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9475         initialization.
9476         * solib.c (solib_global_lookup): Simplify.
9477         * symtab.c (null_block_symbol): Remove.
9478         (symbol_cache_lookup): Simplify returns.
9479         (lookup_language_this): Simplify returns.
9480         (lookup_symbol_aux): Simplify return.
9481         (lookup_local_symbol): Simplify returns.
9482         (lookup_global_symbol_from_objfile): Simplify return.
9483         (lookup_symbol_in_objfile_symtabs)
9484         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9485         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9486         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9487         * cp-namespace.c (cp_lookup_bare_symbol)
9488         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9489         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9490         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9491         (cp_lookup_symbol_via_imports): Simplify initialization.
9492         (find_symbol_in_baseclass): Likewise.
9493         * symtab.h (null_block_symbol): Remove.
9494         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9495         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9496         (d_lookup_symbol_module): Likewise.
9497         (find_symbol_in_baseclass): Simplify initialization.
9498
9499 2019-03-24  Tom Tromey  <tom@tromey.com>
9500
9501         * expression.h: Don't include symtab.h.
9502         (struct block): Forward declare.
9503
9504 2019-03-24  Tom Tromey  <tom@tromey.com>
9505
9506         * c-exp.y (typebase): Remove casts.
9507         * gdbtypes.c (lookup_unsigned_typename, )
9508         (lookup_signed_typename): Remove cast.
9509         * eval.c (parse_to_comma_and_eval): Remove cast.
9510         * parse.c (write_dollar_variable): Remove cast.
9511         * block.h (struct block) <superblock>: Now const.
9512         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9513         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9514         (map_block): Make "block" const.
9515         * symfile.h (struct quick_symbol_functions)
9516         <map_matching_symbols>: Constify block argument to "callback".
9517         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9518         const.
9519         (find_pc_sect_compunit_symtab): Make "b" const.
9520         (find_symbol_at_address): Likewise.
9521         (search_symbols): Likewise.
9522         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9523         (dw2_debug_names_lookup_symbol): Likewise.
9524         (dw2_map_matching_symbols): Update.
9525         * p-valprint.c (pascal_val_print): Remove "block".
9526         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9527         (aux_add_nonlocal_symbols): Make "block" const.
9528         (resolve_subexp): Remove cast.
9529         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9530         const.
9531         (iterate_over_file_blocks): Likewise.
9532         * f-exp.y (%union) <bval>: Remove.
9533         * coffread.c (patch_opaque_types): Make "b" const.
9534         * spu-tdep.c (spu_catch_start): Make "block" const.
9535         * c-valprint.c (print_unpacked_pointer): Remove "block".
9536         * symmisc.c (dump_symtab_1): Make "b" const.
9537         (block_depth): Make "block" const.
9538         * d-exp.y (%union) <bval>: Remove.
9539         * cp-support.h (cp_lookup_rtti_type): Update.
9540         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9541         * psymtab.c (psym_lookup_symbol): Make "block" const.
9542         (maintenance_check_psymtabs): Make "b" const.
9543         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9544         (enumerate_locals, enumerate_args): Update.
9545         * python/py-symtab.c (stpy_global_block): Make "block" const.
9546         (stpy_static_block): Likewise.
9547         * inline-frame.c (block_starting_point_at): Make "new_block"
9548         const.
9549         * block.c (find_block_in_blockvector): Make return type const.
9550         (blockvector_for_pc_sect): Make "b" const.
9551         (find_block_in_blockvector): Make "b" const.
9552
9553 2019-03-23  Tom Tromey  <tom@tromey.com>
9554
9555         * varobj.c (varobj_create): Update.
9556         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9557         * printcmd.c (display_command, do_one_display): Don't reset
9558         innermost_block.
9559         * parser-defs.h (enum innermost_block_tracker_type): Move to
9560         expression.h.
9561         (innermost_block): Update comment.
9562         * parse.c (parse_exp_1): Add tracker_types parameter.
9563         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9564         tracker_types parameter.  Reset innermost_block.
9565         (parse_exp_in_context): Remove.
9566         (parse_expression_for_completion): Update.
9567         * objfiles.c (~objfile): Don't reset expression_context_block or
9568         innermost_block.
9569         * expression.h (enum innermost_block_tracker_type): Move from
9570         parser-defs.h.
9571         (parse_exp_1): Add tracker_types parameter.
9572         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9573         reset innermost_block.
9574
9575 2019-03-23  Tom Tromey  <tom@tromey.com>
9576
9577         * objfiles.h: Include bcache.h.
9578
9579 2019-03-23  Tom Tromey  <tom@tromey.com>
9580
9581         * linespec.c (get_current_search_block): Use
9582         scoped_restore_current_language.
9583         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9584
9585 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9586             Jiong Wang  <jiong.wang@arm.com>
9587
9588         * aarch64-linux-tdep.c
9589         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9590         section.
9591         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9592
9593 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9594             Jiong Wang  <jiong.wang@arm.com>
9595
9596         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9597         instructions.
9598         (aarch64_analyze_prologue_test): Add PACIASP test.
9599         (aarch64_prologue_prev_register): Unmask PC value.
9600
9601 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9602             Jiong Wang  <jiong.wang@arm.com>
9603
9604         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9605         (aarch64_dwarf2_prev_register): Unmask PC value.
9606         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9607         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9608         DW_CFA_AARCH64_negate_ra_state.
9609         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9610
9611 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9612             Jiong Wang  <jiong.wang@arm.com>
9613
9614         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9615         registers.
9616         (aarch64_pseudo_register_name): Likewise.
9617         (aarch64_pseudo_register_type): Likewise.
9618         (aarch64_pseudo_register_reggroup_p): Likewise.
9619         (aarch64_gdbarch_init): Add pauth registers.
9620         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9621         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9622         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9623         (struct gdbarch_tdep): Add regnum for ra_state.
9624
9625 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9626             Jiong Wang  <jiong.wang@arm.com>
9627
9628         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9629
9630 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9631             Jiong Wang  <jiong.wang@arm.com>
9632
9633         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9634         function.
9635         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9636         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9637         (aarch64_gdbarch_init): Add puth registers.
9638         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9639         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9640         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9641
9642 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9643             Jiong Wang  <jiong.wang@arm.com>
9644
9645         * aarch64-linux-nat.c
9646         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9647         * aarch64-linux-tdep.c
9648         (aarch64_linux_core_read_description): Likewise.
9649         (aarch64_linux_get_hwcap): New function.
9650         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9651         (aarch64_linux_get_hwcap): New declaration.
9652
9653 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9654             Jiong Wang  <jiong.wang@arm.com>
9655
9656         * aarch64-linux-nat.c
9657         (aarch64_linux_nat_target::read_description): Add pauth param.
9658         * aarch64-linux-tdep.c
9659         (aarch64_linux_core_read_description): Likewise.
9660         * aarch64-tdep.c (struct target_desc): Add in pauth.
9661         (aarch64_read_description): Add pauth param.
9662         (aarch64_gdbarch_init): Likewise.
9663         * aarch64-tdep.h (aarch64_read_description): Likewise.
9664         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9665         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9666         * features/Makefile: Add new files.
9667         * features/aarch64-pauth.c: New file.
9668         * features/aarch64-pauth.xml: New file.
9669
9670 2019-03-20  Tom Tromey  <tromey@adacore.com>
9671
9672         * infrun.c (handle_inferior_event): Rename from
9673         handle_inferior_event_1.  Create a scoped_value_mark.
9674         (handle_inferior_event): Remove.
9675
9676 2019-03-19  Tom Tromey  <tromey@adacore.com>
9677
9678         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9679         * infrun.h (print_stop_event): Add "displays" parameter.
9680         * infrun.c (print_stop_event): Add "displays" parameter.
9681
9682 2019-03-19  Pedro Alves  <palves@redhat.com>
9683
9684         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9685         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9686         to -1.  Fix TABs vs spaces.
9687         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9688         * tui/tui-out.h (tui_ui_out) Add intro comments.
9689         <m_line, m_start_of_line>: In-class initialize, and add describing
9690         comment.
9691
9692 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9693
9694         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9695         variable names.
9696         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9697
9698 2019-03-18  Pedro Alves  <palves@redhat.com>
9699             Eli Zaretskii <eliz@gnu.org>
9700
9701         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9702         m_line and m_start_of_line.
9703
9704 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9705
9706         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9707         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9708         it returns a newline.  This fixes a regression in TU mode, whereby
9709         the next line is output on the same screen line as the user input.
9710
9711 2019-03-18  Tom Tromey  <tromey@adacore.com>
9712
9713         * minsyms.c (minimal_symbol_reader::install): Remove call to
9714         obstack_blank.
9715
9716 2019-03-18  Pedro Alves  <palves@redhat.com>
9717
9718         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9719         New globals.
9720         (apply_style): New, factored out from ...
9721         (apply_ansi_escape): ... this.  Handle reverse video mode.
9722         (tui_set_reverse_mode): New function.
9723         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9724         * tui/tui-winsource.c (tui_show_source_line): Use
9725         tui_set_reverse_mode instead of setting A_STANDOUT.
9726         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9727         New setter methods.
9728
9729 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9730
9731         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9732         Handle tabs.
9733
9734 2019-03-18  Tom Tromey  <tromey@adacore.com>
9735
9736         * ada-lang.c (empty_array): Add "high" parameter.
9737         (ada_evaluate_subexp): Update.
9738
9739 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9740
9741         * unittests/string_view-selftests.c: Define
9742         _initialize_string_view_selftests unconditionally.
9743
9744 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9745
9746         PR gdb/24350
9747         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9748
9749 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9750
9751         PR gdb/24351
9752         * windows-nat.c (display_selector): Fix format specifiers.
9753
9754 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9755
9756         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9757         tui_refill_source_window instead of tui_refresh_win, to update the
9758         current execution line.  This fixes redisplay of the current line
9759         when stepping through the code with "next" or "step".
9760
9761 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9762
9763         * source-cache.c (source_cache::get_source_lines): Call
9764         find_source_lines to initialize s->nlines.  This fixes vertical
9765         scrolling of TUI source window when the DOWN arrow is pressed.
9766
9767 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9768
9769         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9770         linux-thread-db.c (_initialize_thread_db): Likewise.
9771
9772 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9773
9774         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9775         wclrtoeol in tui_show_source_line".  This reverts changes made in
9776         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9777
9778 2019-03-15  Tom Tromey  <tom@tromey.com>
9779
9780         * symtab.h (struct minimal_symbol): Derive from
9781         general_symbol_info.
9782         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9783         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9784         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9785         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9786         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9787         (MSYMBOL_SEARCH_NAME): Update.
9788         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9789         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9790         * minsyms.c (minimal_symbol_reader::record_full): Update.
9791
9792 2019-03-15  Tom Tromey  <tom@tromey.com>
9793
9794         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9795
9796 2019-03-15  Tom Tromey  <tom@tromey.com>
9797
9798         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9799         unique_xmalloc_ptr.
9800         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9801         Update.
9802         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9803         (build_minimal_symbol_hash_tables)
9804         (minimal_symbol_reader::install): Update.
9805
9806 2019-03-15  Tom Tromey  <tom@tromey.com>
9807
9808         * symtab.c (create_demangled_names_hash): Update.
9809         (symbol_set_names): Update.
9810         * objfiles.h (struct objfile_per_bfd_storage)
9811         <demangled_names_hash>: Now an htab_up.
9812         * objfiles.c (objfile_per_bfd_storage): Simplify.
9813
9814 2019-03-15  Tom Tromey  <tom@tromey.com>
9815
9816         * objfiles.h (struct objfile_per_bfd_storage): Declare
9817         destructor.
9818         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9819         New.
9820         (get_objfile_bfd_data): Use new.  Don't initialize
9821         language_of_main.
9822         (free_objfile_per_bfd_storage): Remove.
9823         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9824
9825 2019-03-15  Tom Tromey  <tom@tromey.com>
9826
9827         * symfile.c (reread_symbols): Update.
9828         * objfiles.c (objfile::objfile): Update.
9829         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9830         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9831         comment.
9832         (minimal_symbol_reader::install): Update.
9833         (terminate_minimal_symbol_table): Remove.
9834         * jit.c (jit_object_close_impl): Update.
9835
9836 2019-03-15  Tom Tromey  <tom@tromey.com>
9837
9838         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9839         initializations.
9840
9841 2019-03-15  Tom Tromey  <tom@tromey.com>
9842
9843         * objfiles.h (struct objfile_per_bfd_storage)
9844         <demangled_hash_languages>: Now a bitset.
9845         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9846         (lookup_minimal_symbol): Update.
9847
9848 2019-03-15  Tom Tromey  <tom@tromey.com>
9849
9850         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9851         Don't return the symbol.
9852         * coffread.c (record_minimal_symbol): Use record_full.
9853
9854 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9855
9856         The MS-Windows port of ncurses fails to switch to a color pair if
9857         one or both of the colors are the implicit default colors.  This
9858         change records the default colors when TUI is initialized, and
9859         then specifies them explicitly when a color pair uses the default
9860         colors.  This allows color styling in TUI mode on MS-Windows.
9861
9862         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9863         ncurses_norm_attr.
9864         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9865         colors in ncurses_norm_attr.
9866         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9867         "none", replace it with the default color recorded in
9868         ncurses_norm_attr.
9869
9870 2019-03-14  Tom Tromey  <tromey@adacore.com>
9871
9872         * source-cache.h (class source_cache) <get_source_lines>: Return
9873         std::string.
9874         * source-cache.c (source_cache::extract_lines): Handle case where
9875         first_pos==npos.  Return std::string.
9876         (source_cache::get_source_lines): Update.
9877
9878 2019-03-14  Tom Tromey  <tromey@adacore.com>
9879
9880         * NEWS: Add item for "style sources" commands.
9881         * source-cache.c (source_cache::get_source_lines): Check
9882         source_styling.
9883         * cli/cli-style.c (source_styling): New global.
9884         (_initialize_cli_style): Add "style sources" commands.
9885         (show_style_sources): New function.
9886         * cli/cli-style.h (source_styling): Declare.
9887
9888 2019-03-14  Pedro Alves  <palves@redhat.com>
9889             Tom Tromey  <tromey@adacore.com>
9890
9891         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9892         * tui/tui-winsource.c (tui_refill_source_window): New function,
9893         from...
9894         (tui_horizontal_source_scroll): ... here.  Move some logic.
9895         * cli/cli-style.c (set_style_enabled): Notify new observable.
9896         * tui/tui-hooks.c (tui_redisplay_source): New function.
9897         (tui_attach_detach_observers): Attach or detach
9898         tui_redisplay_source.
9899         * observable.h (source_styling_changed): New observable.
9900         * observable.c: Define source_styling_changed observable.
9901
9902 2019-03-13  Tom Tromey  <tromey@adacore.com>
9903
9904         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9905         (i386_gnu_nat_target::store_registers): Update.
9906         * target-debug.h (target_debug_print_std_string): New macro.
9907         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9908         * windows-tdep.c (display_one_tib): Update.
9909         * tui/tui-stack.c (tui_make_status_line): Update.
9910         * top.c (print_inferior_quit_action): Update.
9911         * thread.c (thr_try_catch_cmd): Update.
9912         (add_thread_with_info): Update.
9913         (thread_target_id_str): Update.
9914         (thr_try_catch_cmd): Update.
9915         (thread_command): Update.
9916         (thread_find_command): Update.
9917         * record-btrace.c (record_btrace_target::info_record)
9918         (record_btrace_resume_thread, record_btrace_target::resume)
9919         (record_btrace_cancel_resume, record_btrace_step_thread)
9920         (record_btrace_target::wait, record_btrace_target::wait)
9921         (record_btrace_target::wait, record_btrace_target::stop): Update.
9922         * progspace.c (print_program_space): Update.
9923         * process-stratum-target.c
9924         (process_stratum_target::thread_address_space): Update.
9925         * linux-fork.c (linux_fork_mourn_inferior)
9926         (detach_checkpoint_command, info_checkpoints_command)
9927         (linux_fork_context): Update.
9928         (linux_fork_detach): Update.
9929         (class scoped_switch_fork_info): Update.
9930         (delete_checkpoint_command): Update.
9931         * infrun.c (follow_fork_inferior): Update.
9932         (follow_fork_inferior): Update.
9933         (proceed_after_vfork_done): Update.
9934         (handle_vfork_child_exec_or_exit): Update.
9935         (follow_exec): Update.
9936         (displaced_step_prepare_throw): Update.
9937         (displaced_step_restore): Update.
9938         (start_step_over): Update.
9939         (resume_1): Update.
9940         (clear_proceed_status_thread): Update.
9941         (proceed): Update.
9942         (print_target_wait_results): Update.
9943         (do_target_wait): Update.
9944         (context_switch): Update.
9945         (stop_all_threads): Update.
9946         (restart_threads): Update.
9947         (finish_step_over): Update.
9948         (handle_signal_stop): Update.
9949         (switch_back_to_stepped_thread): Update.
9950         (keep_going_pass_signal): Update.
9951         (print_exited_reason): Update.
9952         (normal_stop): Update.
9953         * inferior.c (inferior_pid_to_str): Change return type.
9954         (print_selected_inferior): Update.
9955         (add_inferior): Update.
9956         (detach_inferior): Update.
9957         * dummy-frame.c (fprint_dummy_frames): Update.
9958         * dcache.c (dcache_info_1): Update.
9959         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9960         (btrace_fetch, btrace_clear): Update.
9961         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9962         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9963         type.
9964         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9965         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9966         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9967         * gdbarch.c, gdbarch.h: Rebuild.
9968         * gdbarch.sh (core_pid_to_str): Change return type.
9969         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9970         return type.
9971         (windows_nat_target::pid_to_str): Change return type.
9972         (windows_delete_thread): Update.
9973         (windows_nat_target::attach): Update.
9974         (windows_nat_target::files_info): Update.
9975         * target-delegates.c: Rebuild.
9976         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9977         return type.
9978         (sol_thread_target::pid_to_str): Change return type.
9979         * remote.c (class remote_target) <pid_to_str>: Change return
9980         type.
9981         (remote_target::pid_to_str): Change return type.
9982         (extended_remote_target::attach, remote_target::remote_stop_ns)
9983         (remote_target::remote_notif_remove_queued_reply)
9984         (remote_target::push_stop_reply, remote_target::disable_btrace):
9985         Update.
9986         (extended_remote_target::attach): Update.
9987         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9988         type.
9989         (gdbsim_target::pid_to_str): Change return type.
9990         * ravenscar-thread.c (struct ravenscar_thread_target)
9991         <pid_to_str>: Change return type.
9992         (ravenscar_thread_target::pid_to_str): Change return type.
9993         * procfs.c (class procfs_target) <pid_to_str>: Change return
9994         type.
9995         (procfs_target::pid_to_str): Change return type.
9996         (procfs_target::attach): Update.
9997         (procfs_target::detach): Update.
9998         (procfs_target::fetch_registers): Update.
9999         (procfs_target::store_registers): Update.
10000         (procfs_target::wait): Update.
10001         (procfs_target::files_info): Update.
10002         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10003         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10004         return type.
10005         (nto_procfs_target::pid_to_str): Change return type.
10006         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10007         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10008         return type.
10009         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10010         (exit_lwp): Update.
10011         (attach_proc_task_lwp_callback, get_detach_signal)
10012         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10013         (linux_nat_target::resume, wait_lwp, stop_callback)
10014         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10015         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10016         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10017         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10018         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10019         type.
10020         (inf_ptrace_target::attach): Update.
10021         (inf_ptrace_target::files_info): Update.
10022         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10023         type.
10024         (go32_nat_target::pid_to_str): Change return type.
10025         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10026         (gnu_nat_target::wait): Update.
10027         (gnu_nat_target::wait): Update.
10028         (gnu_nat_target::resume): Update.
10029         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10030         (fbsd_nat_target::wait): Update.
10031         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10032         type.
10033         (darwin_nat_target::attach): Update.
10034         * corelow.c (class core_target) <pid_to_str>: Change return type.
10035         (core_target::pid_to_str): Change return type.
10036         * target.c (normal_pid_to_str): Change return type.
10037         (default_pid_to_str): Likewise.
10038         (target_pid_to_str): Change return type.
10039         (target_translate_tls_address): Update.
10040         (target_announce_detach): Update.
10041         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10042         return type.
10043         (bsd_uthread_target::pid_to_str): Change return type.
10044         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10045         type.
10046         (bsd_kvm_target::pid_to_str): Change return type.
10047         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10048         return type.
10049         (aix_thread_target::pid_to_str): Change return type.
10050         * target.h (struct target_ops) <pid_to_str>: Change return type.
10051         (target_pid_to_str, normal_pid_to_str): Likewise.
10052         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10053         type.
10054         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10055         type.
10056         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10057         return type.
10058         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10059         type.
10060         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10061         type.
10062         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10063         return type.
10064
10065 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10066
10067         * NEWS: Mention that the new default MI version is 3.  Mention
10068         changes to the output of commands and events that deal with
10069         multi-location breakpoints.
10070         * breakpoint.c: Include "mi/mi-out.h".
10071         (print_one_breakpoint): Change output syntax if using MI version
10072         >= 3.
10073         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10074         New.
10075         (mi_multi_location_breakpoint_output_fixed): New.
10076         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10077         (mi_cmd_fix_multi_location_breakpoint_output): New.
10078         (mi_multi_location_breakpoint_output_fixed): New.
10079         * mi/mi-cmds.c (mi_cmds): Register command
10080         -fix-multi-location-breakpoint-output.
10081         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10082         interpreter "mi".
10083
10084 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10085
10086         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10087         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10088         instantiate mi_ui_out based on interpreter name.
10089         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10090         * mi/mi-main.c (mi_load_progress): Likewise.
10091
10092 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10093
10094         * NEWS: Combine separate "New targets" sections for 8.3.
10095
10096 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10097
10098         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10099         (ppcfbsd_init_abi): Install gdbarch
10100         "fetch_tls_load_module_address" and "get_thread_local_address"
10101         methods.
10102
10103 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10104
10105         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10106         (riscv_fbsd_init_abi): Install gdbarch
10107         "fetch_tls_load_module_address" and "get_thread_local_address"
10108         methods.
10109
10110 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10111
10112         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10113         (i386fbsd_init_abi): Install gdbarch
10114         "fetch_tls_load_module_address" and "get_thread_local_address"
10115         methods.
10116
10117 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10118
10119         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10120         (amd64fbsd_init_abi): Install gdbarch
10121         "fetch_tls_load_module_address" and "get_thread_local_address"
10122         methods.
10123
10124 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10125
10126         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10127         (struct fbsd_pspace_data): New type.
10128         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10129         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10130         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10131         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10132         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10133
10134 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10135
10136         * gdbtypes.c (lookup_struct_elt): New function.
10137         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10138         * gdbtypes.h (struct struct_elt): New type.
10139         (lookup_struct_elt): New prototype.
10140
10141 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10142
10143         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10144         remove disabled code block.
10145
10146 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10147
10148         * gdbarch.sh (get_thread_local_address): New method.
10149         * gdbarch.h, gdbarch.c: Regenerate.
10150         * target.c (target_translate_tls_address): Use
10151         gdbarch_get_thread_local_address if present instead of
10152         target::get_thread_local_address.
10153
10154 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10155
10156         * target.h (target::get_thread_local_address): Update comment.
10157
10158 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10159
10160         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10161         objfile->separate_debug_objfile_backlink if not NULL.
10162
10163 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10164
10165         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10166         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10167         (amd64bsd_store_inferior_registers): Likewise.
10168         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10169         Enable segment base registers.
10170         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10171         PT_GETFSBASE and PT_GETGSBASE.
10172         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10173         PT_SETGSBASE.
10174         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10175         segment base registers.
10176         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10177
10178 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10179
10180         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10181         Update calls to i386_target_description to add 'segments'
10182         parameter.
10183         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10184         add segment base registers.
10185         * arch/i386.c (i386_create_target_description): Add 'segments'
10186         parameter to enable segment base registers.
10187         * arch/i386.h (i386_create_target_description): Likewise.
10188         * features/i386/32bit-segments.xml: New file.
10189         * features/i386/32bit-segments.c: Generate.
10190         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10191         call to i386_target_description to add 'segments' parameter.
10192         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10193         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10194         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10195         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10196         if feature is present.
10197         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10198         Add 'segments' parameter to call to i386_target_description.
10199         (i386_target_description): Add 'segments' parameter to enable
10200         segment base registers.
10201         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10202         to call to i386_target_description.
10203         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10204         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10205         Define I386_NUM_REGS.
10206         (i386_target_description): Add 'segments' parameter to enable
10207         segment base registers.
10208
10209 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10210
10211         PR/24325
10212         * source-cache.c: #undef open and close, to avoid unresolved
10213         externals during linking.
10214
10215 2019-03-12  Tom Tromey  <tromey@adacore.com>
10216
10217         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10218         const.  Add initializers.
10219         (_initialize_remote): Don't initialize ptid globals.
10220
10221 2019-03-12  Pedro Alves  <palves@redhat.com>
10222
10223         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10224
10225 2019-03-12  Pedro Alves  <palves@redhat.com>
10226
10227         * cp-name-parser.y (main): Remove unused 'len' variable.
10228
10229 2019-03-12  Tom Tromey  <tromey@adacore.com>
10230
10231         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10232         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10233
10234 2019-03-12  Tom Tromey  <tromey@adacore.com>
10235
10236         * linux-nat.c (iterate_over_lwps): Update.
10237         (stop_callback): Remove parameter.
10238         (stop_wait_callback, detach_callback, resume_set_callback)
10239         (select_singlestep_lwp_callback, set_ignore_sigint)
10240         (status_callback, resumed_callback, resume_clear_callback)
10241         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10242         data parameter.
10243         (linux_nat_target::detach, linux_nat_target::resume)
10244         (linux_stop_and_wait_all_lwps, select_event_lwp)
10245         (linux_nat_filter_event, linux_nat_wait_1)
10246         (linux_nat_target::kill, linux_nat_target::stop)
10247         (linux_nat_target::stop): Update.
10248         (linux_nat_resume_callback): Change type.
10249         (resume_stopped_resumed_lwps, count_events_callback)
10250         (select_event_lwp_callback): Likewise.
10251         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10252         * arm-linux-nat.c (struct update_registers_data): Remove.
10253         (update_registers_callback): Change type.
10254         (arm_linux_insert_hw_breakpoint1): Update.
10255         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10256         parameter.
10257         (x86_linux_dr_set_addr): Update.
10258         (x86_linux_dr_set_control): Update.
10259         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10260         (iterate_over_lwps): Use gdb::function_view.
10261         * nat/aarch64-linux-hw-point.c (struct
10262         aarch64_dr_update_callback_param): Remove.
10263         (debug_reg_change_callback): Change type.
10264         (aarch64_notify_debug_reg_change): Update.
10265         * s390-linux-nat.c (s390_refresh_per_info): Update.
10266
10267 2019-03-11  Tom Tromey  <tromey@adacore.com>
10268
10269         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10270         redundant assignment to "this_cu".
10271
10272 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10273
10274         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10275
10276 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10277
10278         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10279         from...
10280         (rank_one_type): ... this.
10281
10282 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10283
10284         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10285         from...
10286         (rank_one_type): ... this.
10287
10288 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10289
10290         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10291         from...
10292         (rank_one_type): ... this.
10293
10294 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10295
10296         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10297         from...
10298         (rank_one_type): ... this.
10299
10300 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10301
10302         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10303         from...
10304         (rank_one_type): ... this.
10305
10306 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10307
10308         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10309         from...
10310         (rank_one_type): ... this.
10311
10312 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10313
10314         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10315         from...
10316         (rank_one_type): ... this.
10317
10318 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10319
10320         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10321         from...
10322         (rank_one_type): ... this.
10323
10324 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10325
10326         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10327         from...
10328         (rank_one_type): ... this.
10329
10330 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10331
10332         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10333         from...
10334         (rank_one_type): ... this.
10335
10336 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10337
10338         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10339         from...
10340         (rank_one_type): ... this.
10341
10342 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10343
10344         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10345         from...
10346         (rank_one_type): ... this.
10347
10348 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10349
10350         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10351         inferior-events' shows the example events.
10352
10353 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10354
10355         Support styling on native MS-Windows console
10356
10357         PR/24315
10358         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10359         on MS-Windows if $TERM is not defined.
10360
10361         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10362
10363         * posix-hdep.c (gdb_console_fputs):
10364         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10365         functions.
10366         * ui-file.h (gdb_console_fputs): Add prototype.
10367
10368         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10369         back to fputs only if the former returns zero.
10370
10371 2019-03-07  Tom Tromey  <tom@tromey.com>
10372
10373         * symmisc.c (print_symbol_bcache_statistics): Update.
10374         (print_objfile_statistics): Update.
10375         * symfile.c (allocate_symtab): Update.
10376         * stabsread.c: Don't include bcache.h.
10377         * psymtab.h (struct psymbol_bcache): Don't declare.
10378         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10379         (psymbol_bcache_init, psymbol_bcache_free)
10380         (psymbol_bcache_get_bcache): Don't declare.
10381         * psymtab.c (struct psymbol_bcache): Remove.
10382         (psymtab_storage::psymtab_storage): Update.
10383         (psymtab_storage::~psymtab_storage): Update.
10384         (psymbol_bcache_init, psymbol_bcache_free)
10385         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10386         (add_psymbol_to_bcache): Update.
10387         (allocate_psymtab): Update.
10388         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10389         macro_cache>: No longer pointers.
10390         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10391         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10392         * macrotab.c (macro_bcache): Update.
10393         * macroexp.c: Don't include bcache.h.
10394         * gdbtypes.c (check_types_worklist): Update.
10395         (types_deeply_equal): Remove TRY/CATCH.  Update.
10396         * elfread.c (elf_symtab_read): Update.
10397         * dwarf2read.c: Don't include bcache.h.
10398         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10399         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10400         (print_bcache_statistics, bcache_memory_used): Don't declare.
10401         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10402         methods.  Rename all data members.
10403         * bcache.c (struct bcache): Move to bcache.h.
10404         (bcache::expand_hash_table): Rename from expand_hash_table.
10405         (bcache): Remove.
10406         (bcache::insert): Rename from bcache_full.
10407         (bcache::compare): Rename from bcache_compare.
10408         (bcache_xmalloc): Remove.
10409         (bcache::~bcache): Rename from bcache_xfree.
10410         (bcache::print_statistics): Rename from print_bcache_statistics.
10411         (bcache::memory_used): Rename from bcache_memory_used.
10412
10413 2019-03-07  Pedro Alves  <palves@redhat.com>
10414
10415         * infrun.c (normal_stop): Also check for
10416         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10417
10418 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10419
10420         * f-lang.c (value_from_host_double): Moved to...
10421         * value.c (value_from_host_double): ...here.
10422         * value.h (value_from_host_double): Declare.
10423         * guile/scm-math.c (vlscm_convert_typed_number): Use
10424         value_from_host_double.
10425         (vlscm_convert_number): Likewise.
10426         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10427         * python/py-value.c (convert_value_from_python): Likewise.
10428
10429 2019-03-06  Tom Tromey  <tom@tromey.com>
10430
10431         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10432
10433 2019-03-06  Tom Tromey  <tom@tromey.com>
10434
10435         * utils.h (free_current_contents): Don't declare.
10436         * utils.c (free_current_contents): Remove.
10437
10438 2019-03-06  Tom Tromey  <tom@tromey.com>
10439
10440         * top.c (quit_force): Update.
10441         * main.c (captured_command_loop): Update.
10442         * common/new-op.c (operator new): Update.
10443         * common/common-exceptions.c (struct catcher)
10444         <save_cleanup_chain>: Remove member.
10445         (exceptions_state_mc_init): Update.
10446         (exception_try_scope_entry): Return nullptr.
10447         (exception_try_scope_exit, exception_rethrow)
10448         (throw_exception_sjlj, throw_exception_cxx): Update.
10449         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10450         (all_cleanups, do_cleanups, discard_cleanups)
10451         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10452         (restore_cleanups, restore_final_cleanups): Don't declare.
10453         (do_final_cleanups): Remove parameter.
10454         * common/cleanups.c (cleanup_chain, make_cleanup)
10455         (make_cleanup_dtor, all_cleanups, do_cleanups)
10456         (discard_my_cleanups, discard_cleanups)
10457         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10458         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10459         (null_cleanup): Remove.
10460         (do_final_cleanups): Remove parameter.
10461
10462 2019-03-06  Tom Tromey  <tom@tromey.com>
10463
10464         * remote.c (remote_target::remote_parse_stop_reply): Use
10465         unique_xmalloc_ptr.
10466
10467 2019-03-06  Tom Tromey  <tom@tromey.com>
10468
10469         * stabsread.c (struct stabs_field_info): Rename from field_info.
10470         <list, fnlist>: Add initializers.
10471         <obstack>: New member.
10472         (read_member_functions, read_struct_fields, read_baseclasses):
10473         Allocate on obstack.  Don't use cleanups.
10474         (read_one_struct_field, read_member_functions, read_struct_fields)
10475         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10476         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10477         (read_struct_type): Update.
10478
10479 2019-03-06  Tom Tromey  <tom@tromey.com>
10480
10481         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10482         * common/filestuff.h (make_cleanup_close): Don't declare.
10483         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10484         Remove.
10485
10486 2019-03-06  Tom Tromey  <tom@tromey.com>
10487
10488         * solib-aix.c: Use make_scope_exit.
10489
10490 2019-03-06  Tom Tromey  <tom@tromey.com>
10491
10492         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10493         Use make_scope_exit.
10494
10495 2019-03-06  Tom Tromey  <tom@tromey.com>
10496
10497         * solib-svr4.c (disable_probes_interface): Remove parameter.
10498         (svr4_handle_solib_event): Use make_scope_exit.
10499
10500 2019-03-06  Tom Tromey  <tom@tromey.com>
10501
10502         * remote.c (struct stop_reply_deleter): Remove.
10503         (stop_reply_up): Update.
10504         (struct stop_reply): Derive from notif_event.  Don't typedef.
10505         <regcache>: Now a std::vector.
10506         (stop_reply_xfree): Remove.
10507         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10508         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10509         (remote_target::discard_pending_stop_replies): Use delete.
10510         (remote_target::remote_parse_stop_reply): Update.
10511         (remote_target::process_stop_reply): Update.
10512         * remote-notif.h (struct notif_event): Add virtual destructor.
10513         Remove "dtr" member.
10514         (struct notif_client) <alloc_event>: Return a unique_ptr.
10515         (notif_event_xfree): Don't declare.
10516         (notif_event_up): New typedef.
10517         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10518         (notif_event_xfree, do_notif_event_xfree): Remove.
10519         (remote_notif_state_xfree): Update.
10520
10521 2019-03-06  Tom Tromey  <tom@tromey.com>
10522
10523         * infrun.c (displaced_step_clear_cleanup): Now a
10524         forward_scope_exit type.
10525         (displaced_step_prepare_throw): Update.
10526         (displaced_step_fixup): Update.
10527
10528 2019-03-06  Tom Tromey  <tom@tromey.com>
10529
10530         * inferior.h (class inferior): Update comment.
10531         * gdbthread.h (class thread_info): Update comment.
10532
10533 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10534             Tom Tromey  <tom@tromey.com>
10535
10536         * stabsread.h (struct stab_section_list): Remove.
10537         (coffstab_build_psymtabs): Update.
10538         * dbxread.c (symbuf_sections): Now a std::vector.
10539         (sect_idx): New global.
10540         (fill_symbuf): Update.
10541         (coffstab_build_psymtabs): Change type of stabsects parameter.
10542         Update.
10543         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10544         std::vector.
10545         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10546         (coff_locate_sections): Update.
10547         (coff_symfile_read): Remove cleanups.  Update.
10548         (init_stringtab): Add storage parameter.
10549         (free_stringtab, free_stringtab_cleanup): Remove.
10550         (init_lineno): Add storage parameter.
10551         (free_linetab, free_linetab_cleanup): Remove.
10552
10553 2019-03-06  Pedro Alves  <palves@redhat.com>
10554
10555         * linux-fork.c (fork_info::clobber_regs): Delete.
10556         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10557         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10558         comment.  Adjust.
10559         (scoped_switch_fork_info::scoped_switch_fork_info)
10560         (checkpoint_command, linux_fork_context): Adjust
10561         fork_save_infrun_state calls.
10562
10563 2019-03-06  Pedro Alves  <palves@redhat.com>
10564
10565         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10566         (inf_has_multiple_threads): Return 'bool' and rewrite using
10567         inferior_info::threads().
10568
10569 2019-03-06  Pedro Alves  <palves@redhat.com>
10570
10571         * linux-fork.c: Include <list>.
10572         (fork_list): Now a std::list instance.
10573         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10574         (forks_exist_p, find_last_fork): Adjust.
10575         (new_fork): Delete.
10576         (one_fork_p): New.
10577         (add_fork): Adjust.
10578         (free_fork): Delete, folded into fork_info::~fork_info().
10579         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10580         Adjust.
10581         (init_fork_list): Delete.
10582         (linux_fork_killall, linux_fork_mourn_inferior)
10583         (linux_fork_detach, info_checkpoints_command): Adjust.
10584         (_initialize_linux_fork): No longer call init_fork_list.
10585
10586 2019-03-06  Pedro Alves  <palves@redhat.com>
10587
10588         * linux-fork.c (new_fork): New, split out of ...
10589         (add_fork): ... this.  Return void.  Move "first fork" special
10590         case from here, to ...
10591         (checkpoint_command): ... here.
10592         * linux-linux.h (add_fork): Return void.
10593
10594 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10595
10596         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10597
10598 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10599             Chris January  <chris.january@arm.com>
10600             David Lecomber  <david.lecomber@arm.com>
10601
10602         * f-exp.y: New token, UNOP_INTRINSIC.
10603         (exp): New pattern using UNOP_INTRINSIC token.
10604         (f77_keywords): Add 'abs' keyword.
10605         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10606         (value_from_host_double): New function.
10607         (evaluate_subexp_f): Support UNOP_ABS.
10608
10609 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10610
10611         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10612         types.
10613
10614 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10615
10616         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10617         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10618         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10619
10620 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10621
10622         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10623
10624 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10625             Chris January  <chris.january@arm.com>
10626
10627         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10628         * f-exp.y: Define 'KIND' token.
10629         (exp): New pattern for KIND expressions.
10630         (ptype): Handle types with a kind extension.
10631         (direct_abs_decl): Extend to spot kind extensions.
10632         (f77_keywords): Add 'kind' to the list.
10633         (push_kind_type): New function.
10634         (convert_to_kind_type): New function.
10635         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10636         * parse.c (operator_length_standard): Likewise.
10637         * parser-defs.h (enum type_pieces): Add tp_kind.
10638         * std-operator.def: Add UNOP_KIND.
10639
10640 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10641
10642         * f-exp.y (f_parse): Set yydebug.
10643
10644 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10645
10646         * f-lang.c (evaluate_subexp_f): New function.
10647         (exp_descriptor_f): New global.
10648         (f_language_defn): Use exp_descriptor_f instead of
10649         exp_descriptor_standard.
10650
10651 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10652
10653         * f-exp.y (struct token): Add comments.
10654         (dot_ops): Remove uppercase versions and the end marker.
10655         (f77_keywords): Likewise.
10656         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10657         entries in the dot_ops array are case insensitive, and use
10658         strncasecmp to compare strings.  Also some whitespace cleanup in
10659         this area.  Similar for the f77_keywords array, except entries in
10660         this list might be case sensitive.
10661
10662 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10663
10664         * f-exp.y (struct f77_boolean_val): Add comments.
10665         (boolean_values): Remove uppercase versions, and end marker.
10666         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10667         and use strncasecmp to achieve case insensitivity.  Additionally,
10668         perform whitespace cleanup around this code.
10669
10670 2019-03-06  Tom Tromey  <tromey@adacore.com>
10671
10672         * remote-sim.c (gdbsim_target_open): Use result of
10673         gdb_argv::release.
10674
10675 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10676         Dirk Schubert  <dirk.schubert@arm.com>
10677         Chris January  <chris.january@arm.com>
10678
10679         * eval.c (evaluate_subexp_standard): Call Fortran argument
10680         wrapping logic.
10681         * f-lang.c (struct value): A value which can be passed into a
10682         Fortran function call.
10683         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10684         where appropriate.
10685         (struct type): Value ready for a Fortran function call.
10686         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10687         is needed.
10688         * f-lang.h (fortran_argument_convert): Declaration.
10689         (fortran_preserve_arg_pointer): Declaration.
10690         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10691
10692 2019-03-05  Tom Tromey  <tromey@adacore.com>
10693
10694         * python/py-prettyprint.c (print_string_repr): Remove #if.
10695         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10696
10697 2019-03-05  Tom Tromey  <tromey@adacore.com>
10698
10699         * target.c (the_dummy_target): Move later.  Change type to
10700         "dummy_target".
10701         (initialize_targets): Don't initialize the_dummy_target.
10702
10703 2019-03-05  Tom Tromey  <tromey@adacore.com>
10704
10705         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10706         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10707
10708 2019-03-05  Tom Tromey  <tromey@adacore.com>
10709
10710         * windows-nat.c (windows_nat_target::attach)
10711         (windows_nat_target::detach): Don't call gdb_flush.
10712         * valprint.c (generic_val_print, val_print, val_print_string):
10713         Don't call gdb_flush.
10714         * utils.c (defaulted_query): Don't call gdb_flush.
10715         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10716         * target.c (target_announce_detach): Don't call gdb_flush.
10717         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10718         * remote.c (extended_remote_target::attach): Don't call
10719         gdb_flush.
10720         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10721         * printcmd.c (do_examine): Don't call gdb_flush.
10722         (info_display_command): Don't call gdb_flush.
10723         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10724         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10725         * memattr.c (info_mem_command): Don't call gdb_flush.
10726         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10727         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10728         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10729         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10730         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10731         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10732         (gnu_nat_target::detach): Don't call gdb_flush.
10733         * f-valprint.c (f_val_print): Don't call gdb_flush.
10734         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10735         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10736         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10737         gdb_flush.
10738         * c-valprint.c (c_val_print): Don't call gdb_flush.
10739         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10740
10741 2019-03-05  Tom Tromey  <tromey@adacore.com>
10742
10743         * varobj.c (update_dynamic_varobj_children): Update.
10744         (install_default_visualizer): Use reset, not release.
10745         * value.c (set_internalvar): Update.
10746         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10747         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10748         ATTRIBUTE_UNUSED_RESULT.
10749
10750 2019-03-05  Tom Tromey  <tromey@adacore.com>
10751
10752         * remote.c (class scoped_remote_fd) <release>: Add
10753         ATTRIBUTE_UNUSED_RESULT.
10754
10755 2019-03-05  Tom Tromey  <tromey@adacore.com>
10756
10757         * macroexp.c (struct macro_buffer) <release>: Add
10758         ATTRIBUTE_UNUSED_RESULT.
10759
10760 2019-03-05  Tom Tromey  <tromey@adacore.com>
10761
10762         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10763         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10764         ATTRIBUTE_UNUSED_RESULT.
10765
10766 2019-03-05  Tom Tromey  <tromey@adacore.com>
10767
10768         * common/scoped_fd.h (class scoped_fd) <release>: Add
10769         ATTRIBUTE_UNUSED_RESULT.
10770
10771 2019-03-05  Tom Tromey  <tromey@adacore.com>
10772
10773         * parser-defs.h (struct parser_state) <release>: Add
10774         ATTRIBUTE_UNUSED_RESULT.
10775
10776 2019-03-05  Tom Tromey  <tromey@adacore.com>
10777
10778         * utils.h (class gdb_argv) <release>: Add
10779         ATTRIBUTE_UNUSED_RESULT.
10780         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10781
10782 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10783
10784         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10785         for-loop range, to avoid compiler warnings.
10786
10787         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10788         avoid compiler warnings about unused variables.
10789
10790         * NEWS: Mention end of support for native debugging on MS-Windows
10791         before XP.
10792
10793         PR gdb/24292
10794         * common/netstuff.c:
10795         * gdbserver/gdbreplay.c
10796         * gdbserver/remote-utils.c:
10797         * ser-tcp.c:
10798         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10799         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10800         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10801         'getaddrinfo' and 'freeaddrinfo' were not available before
10802         Windows XP, and mingw.org's MinGW headers by default define
10803         _WIN32_WINNT to 0x500.
10804
10805 2019-03-01  Gary Benson <gbenson@redhat.com>
10806
10807         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10808
10809 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10810             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10811
10812         PR gdb/8527
10813         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10814         set_sigint_trap, clear_sigint_trap.
10815
10816 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10817
10818         * target.c (target_detach): Clear the regcache and the
10819         frame cache.
10820
10821 2019-02-27  Pedro Alves  <palves@redhat.com>
10822
10823         * utils.c (set_screen_size): When we cap the height/width sizes,
10824         tweak the corresponding command variable to show "unlimited":
10825
10826 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10827             Pedro Alves  <palves@redhat.com>
10828
10829         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10830         before calling rl_set_screen_size.
10831
10832 2019-02-27  Tom Tromey  <tromey@adacore.com>
10833
10834         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10835         define.
10836         * python/py-value.c: Remove Python 2.4 workaround.
10837         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10838         workaround.
10839         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10840         Python 2.4 workaround.
10841         * python/python-internal.h: Remove Python 2.4 comment.
10842         (Py_ssize_t): Don't define.
10843         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10844         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10845         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10846         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10847         * python/python.c (do_start_initialization): Remove Python 2.4
10848         workaround.
10849         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10850         (print_children): Remove Python 2.4 workaround.
10851         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10852         workaround.
10853         (CHARBUFFERPROC_NAME): Remove.
10854         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10855         Python 2.4 workaround.
10856
10857 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10858
10859         * NEWS: Note minimum Python version.
10860
10861 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10862
10863         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10864         code from these functions.  Remove corresponding ifdefs.  Use
10865         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10866         Remove gotos and target of gotos.
10867         (infpy_search_memory): Likewise.
10868
10869 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10870
10871         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10872         (hppa_gdbarch_init): Don't register deleted functions with
10873         gdbarch.
10874
10875 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10876
10877         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10878         (h8300_unwind_sp): Delete.
10879         (h8300_dummy_id): Delete.
10880         (h8300_gdbarch_init): Don't register deleted functions with
10881         gdbarch.
10882
10883 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10884
10885         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10886         (ft32_unwind_pc): Delete.
10887         (ft32_unwind_sp): Delete.
10888         (ft32_gdbarch_init): Don't register deleted functions with
10889         gdbarch.
10890
10891 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10892
10893         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10894         (frv_unwind_pc): Delete.
10895         (frv_unwind_sp): Delete.
10896         (frv_gdbarch_init): Don't register deleted functions with
10897         gdbarch.
10898
10899 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10900
10901         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10902         (riscv_unwind_pc): Delete.
10903         (riscv_unwind_sp): Delete.
10904         (riscv_gdbarch_init): Don't register deleted functions with
10905         gdbarch.
10906
10907 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10908
10909         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10910         (csky_unwind_pc): Delete.
10911         (csky_unwind_sp): Delete.
10912         (csky_gdbarch_init): Don't register deleted functions with
10913         gdbarch.
10914
10915 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10916
10917         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10918         (cris_unwind_pc): Delete.
10919         (cris_unwind_sp): Delete.
10920         (cris_gdbarch_init): Don't register deleted functions with
10921         gdbarch.
10922
10923 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10924
10925         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10926         (bfin_unwind_pc): Delete.
10927         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10928
10929 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10930
10931         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10932         (arm_unwind_pc): Delete.
10933         (arm_unwind_sp): Delete.
10934         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10935
10936 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10937
10938         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10939         (arc_unwind_pc): Delete.
10940         (arc_unwind_sp): Delete.
10941         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10942
10943 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10944
10945         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10946         (alpha_unwind_pc): Delete.
10947         (alpha_gdbarch_init): Don't register deleted functions with
10948         gdbarch.
10949
10950 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10951
10952         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10953         (aarch64_unwind_pc): Delete.
10954         (aarch64_unwind_sp): Delete.
10955         (aarch64_gdbarch_init): Don't register deleted functions with
10956         gdbarch.
10957
10958 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10959
10960         * gdbtypes.c (type_align): Don't consider static members when
10961         computing structure alignment.
10962
10963 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10964
10965         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10966         return 0 for other types.
10967         * arch-utils.c (default_type_align): Always return 0.
10968         * gdbarch.h: Regenerate.
10969         * gdbarch.sh (type_align): Extend comment.
10970         * gdbtypes.c (type_align): Add additional comments, always call
10971         gdbarch_type_align before applying the default rules.
10972         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10973         generic code will then apply a suitable default.
10974         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10975         types, return 0 for other types.
10976
10977 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10978
10979         * NEWS: Create a new section for the next release branch.
10980         Rename the section of the current branch, now that it has
10981         been cut.
10982
10983 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10984
10985         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10986         * version.in: Bump version to 8.3.50.DATE-git.
10987
10988 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10989
10990         * aix-thread.c (ptid_cmp): Remove unused variable.
10991         (get_signaled_thread): Likewise.
10992         (store_regs_user_thread): Likewise.
10993         (store_regs_kernel_thread): Likewise.
10994         (fetch_regs_kernel_thread): Remove shadowed variable.
10995
10996 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10997
10998         * features/riscv/32bit-cpu.xml: Add register numbers.
10999         * features/riscv/32bit-fpu.c: Regenerate.
11000         * features/riscv/32bit-fpu.xml: Add register numbers.
11001         * features/riscv/64bit-cpu.xml: Add register numbers.
11002         * features/riscv/64bit-fpu.c: Regenerate.
11003         * features/riscv/64bit-fpu.xml: Add register numbers.
11004
11005 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11006
11007         * NEWS: Mention two argument form of gdb.Value constructor.
11008         * python/py-value.c (convert_buffer_and_type_to_value): New
11009         function.
11010         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11011         Add support for handling an optional second argument.  Call
11012         convert_buffer_and_type_to_value as appropriate.
11013         * python/python-internal.h (Py_buffer_deleter): New struct.
11014         (Py_buffer_up): New typedef.
11015
11016 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11017
11018         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11019         instead of releasing ownership.
11020
11021 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11022
11023         * dwarf2read.c (open_and_init_dwp_file): Call
11024         elf_numsections instead of bfd_count_sections to initialize
11025         dwp_file->num_sections.
11026
11027 2019-02-25  Tom Tromey  <tromey@adacore.com>
11028
11029         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11030
11031 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11032
11033         * gcore.in: Add '--readnever' option when invoking GDB.
11034
11035 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11036
11037         * MAINTAINERS: Update my email address.
11038
11039 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11040
11041         * build-id.c (build_id_to_debug_bfd_1): New function.
11042         (build_id_to_debug_bfd): Look for separate debug file in
11043         sysroot.
11044
11045 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11046
11047         * gdbarch.sh: Update the copyright year range that is placed into
11048         generated files.
11049
11050 2019-02-22  Keith Seitz  <keiths@redhat.com>
11051
11052         PR symtab/23853
11053         * linespec.c (create_sals_line_offset): Search for the default
11054         symtab's filename instead of its fullname.
11055
11056 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11057
11058         * NEWS: Update style defaults.
11059
11060 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11061
11062         * main.c (captured_main_1): Disable styling in batch mode.
11063
11064 2019-02-20  Tom Tromey  <tom@tromey.com>
11065
11066         * symtab.c (symtab_symbol_info): Fix typos.
11067
11068 2019-02-20  Tom Tromey  <tromey@adacore.com>
11069
11070         * findcmd.c (_initialize_mem_search): Use upper case for
11071         metasyntactic variables.
11072
11073 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11074
11075         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11076         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11077
11078 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11079
11080         * top.h (source_file_name): Change to std::string.
11081         * top.c (source_file_name): Likewise.
11082         (command_line_input): Adjust.
11083         * cli/cli-script.c (script_from_file): Adjust.
11084
11085 2019-02-19  Tom Tromey  <tromey@adacore.com>
11086
11087         * ravenscar-thread.c
11088         (ravenscar_thread_target::update_thread_list): Don't call
11089         ada_build_task_list.
11090         * ada-lang.h (ada_build_task_list): Don't declare.
11091         * ada-tasks.c (struct ada_tasks_inferior_data)
11092         <task_list_valid_p>: Now bool.
11093         (read_known_tasks, ada_task_list_changed)
11094         (ada_tasks_invalidate_inferior_data): Update.
11095         (read_known_tasks_array): Return bool.
11096         (read_known_tasks_list): Likewise.
11097         (read_known_tasks): Return void.
11098         (ada_build_task_list): Now static.
11099
11100 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11101
11102         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11103         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11104
11105 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11106
11107         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11108         variant for ada_tasks_pspace_data_handle and
11109         ada_tasks_inferior_data_handle.
11110         (ada_tasks_pspace_data_cleanup): New function.
11111         (ada_tasks_inferior_data_cleanup): New function.
11112
11113 2019-02-17  Tom Tromey  <tom@tromey.com>
11114
11115         * macrotab.h (macro_source_fullname): Return a std::string.
11116         * macrotab.c (macro_include, check_for_redefinition)
11117         (macro_undef, macro_lookup_definition, foreach_macro)
11118         (foreach_macro_in_scope): Update.
11119         (macro_source_fullname): Return a std::string.
11120         * macrocmd.c (show_pp_source_pos): Update.
11121
11122 2019-02-17  Tom Tromey  <tom@tromey.com>
11123
11124         * macrocmd.c (show_pp_source_pos): Style the file names.
11125
11126 2019-02-17  Tom Tromey  <tom@tromey.com>
11127
11128         PR tui/24197:
11129         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11130
11131 2019-02-17  Tom Tromey  <tom@tromey.com>
11132
11133         * ada-lang.c (user_select_syms): Use filtered printing.
11134         * utils.c (wrap_style): New global.
11135         (desired_style): Remove.
11136         (emit_style_escape): Add stream parameter.
11137         (set_output_style, reset_terminal_style, prompt_for_continue):
11138         Update.
11139         (flush_wrap_buffer): Only flush gdb_stdout.
11140         (wrap_here): Set wrap_style.
11141         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11142         treat escape sequences as a character.  Change when wrap buffer is
11143         flushed.
11144         (fputs_styled): Do not set the output style when the default is
11145         requested.
11146         * ui-style.h (struct ui_file_style) <is_default>: New method.
11147         * source.c (print_source_lines_base): Emit escape sequences in one
11148         piece.
11149
11150 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11151
11152         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11153         integers and enumeration types.
11154
11155 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11156
11157         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11158         instead of lookup_symbol_in_language
11159         (do_exact_match): New function.
11160         (ada_get_symbol_name_matcher): Return do_exact_match when
11161         doing a verbatim match.
11162
11163 2019-02-15  Tom Tromey  <tromey@adacore.com>
11164
11165         * ravenscar-thread.c (ravenscar_thread_target::resume)
11166         (ravenscar_thread_target::wait): Special case wildcard requests.
11167
11168 2019-02-15  Tom Tromey  <tromey@adacore.com>
11169
11170         * ravenscar-thread.c (base_ptid): Remove.
11171         (struct ravenscar_thread_target) <close>: New method.
11172         <m_base_ptid>: New member.
11173         <update_inferior_ptid, active_task, task_is_currently_active,
11174         runtime_initialized>: Declare methods.
11175         <ravenscar_thread_target>: Add constructor.
11176         (ravenscar_thread_target::task_is_currently_active)
11177         (ravenscar_thread_target::update_inferior_ptid)
11178         (ravenscar_runtime_initialized): Rename.  Now methods.
11179         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11180         (ravenscar_thread_target::update_thread_list): Update.
11181         (ravenscar_thread_target::active_task): Now method.
11182         (ravenscar_thread_target::store_registers)
11183         (ravenscar_thread_target::prepare_to_store)
11184         (ravenscar_thread_target::prepare_to_store)
11185         (ravenscar_thread_target::mourn_inferior): Update.
11186         (ravenscar_inferior_created): Use "new" to create target.
11187         (ravenscar_thread_target::get_ada_task_ptid): Update.
11188         (_initialize_ravenscar): Don't initialize base_ptid.
11189         (ravenscar_ops): Remove global.
11190
11191 2019-02-15  Tom Tromey  <tromey@adacore.com>
11192
11193         * target.h (push_target): Declare new overload.
11194         * target.c (push_target): New overload, taking an rvalue reference.
11195         * remote.c (remote_target::open_1): Use push_target overload.
11196         * corelow.c (core_target_open): Use push_target overload.
11197
11198 2019-02-15  Tom Tromey  <tromey@adacore.com>
11199
11200         * ravenscar-thread.c (is_ravenscar_task)
11201         (ravenscar_task_is_currently_active): Return bool.
11202         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11203         (_initialize_ravenscar): Remove "(void)".
11204         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11205         Return bool.
11206
11207 2019-02-15  Tom Tromey  <tromey@adacore.com>
11208
11209         * ravenscar-thread.c (ravenscar_runtime_initializer)
11210         (has_ravenscar_runtime, get_running_thread_id)
11211         (ravenscar_thread_target::resume): Fix indentation.
11212
11213 2019-02-15  Tom Tromey  <tromey@adacore.com>
11214
11215         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11216         from ravenscar_arch_ops.
11217         (sparc_ravenscar_ops::fetch_registers)
11218         (sparc_ravenscar_ops::store_registers): Now methods.
11219         (sparc_ravenscar_prepare_to_store): Remove.
11220         (sparc_ravenscar_ops): Redefine.
11221         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11222         methods and destructor.  Remove members.
11223         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11224         (ravenscar_thread_target::store_registers)
11225         (ravenscar_thread_target::prepare_to_store): Update.
11226         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11227         Remove.
11228         (struct ppc_ravenscar_powerpc_ops): Derive from
11229         ravenscar_arch_ops.
11230         (ppc_ravenscar_powerpc_ops::fetch_registers)
11231         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11232         (ppc_ravenscar_powerpc_ops): Redefine.
11233         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11234         (ppc_ravenscar_e500_ops::fetch_registers)
11235         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11236         (ppc_ravenscar_e500_ops): Redefine.
11237         * aarch64-ravenscar-thread.c
11238         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11239         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11240         (aarch64_ravenscar_fetch_registers)
11241         (aarch64_ravenscar_store_registers): Now methods.
11242         (aarch64_ravenscar_ops): Redefine.
11243
11244 2019-02-15  Tom Tromey  <tromey@adacore.com>
11245
11246         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11247         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11248         (ravenscar_thread_target::stopped_by_watchpoint)
11249         (ravenscar_thread_target::stopped_data_address)
11250         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11251
11252 2019-02-15  Tom Tromey  <tromey@adacore.com>
11253
11254         * ravenscar-thread.c: Fix some typos.
11255
11256 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11257             Tom Tromey  <tromey@adacore.com>
11258
11259         * ada-lang.c (ada_exception_sal): Change addr_string to a
11260         std::string.
11261         (create_ada_exception_catchpoint): Update.
11262
11263 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11264             Tom Tromey  <tromey@adacore.com>
11265
11266         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11267         (bp_location_ops): Remove.
11268         (base_breakpoint_allocate_location): Update.
11269         (free_bp_location): Update.
11270         * ada-lang.c (class ada_catchpoint_location)
11271         <ada_catchpoint_location>: Remove ops parameter.
11272         (ada_catchpoint_location_dtor): Remove.
11273         (ada_catchpoint_location_ops): Remove.
11274         (allocate_location_exception): Update.
11275         * breakpoint.h (struct bp_location_ops): Remove.
11276         (class bp_location) <bp_location>: Remove bp_location_ops
11277         parameter.
11278         <~bp_location>: Add destructor.
11279         <ops>: Remove.
11280
11281 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11282             Pedro Alves  <palves@redhat.com>
11283
11284         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11285         'PATH_MAX'.
11286
11287 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11288             Samuel Thibault  <samuel.thibault@gnu.org>
11289             Thomas Schwinge  <thomas@codesourcery.com>
11290
11291         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11292         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11293
11294 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11295
11296         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11297         (check_empty): Use "const char *".
11298
11299         * gnu-nat.c (gnu_nat_target::detach): Instead of
11300         'detach_inferior (pid)' call
11301         'detach_inferior (find_inferior_pid (pid))'.
11302
11303         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11304         'nat/fork-inferior.o'.
11305         * gnu-nat.c: #include "nat/fork-inferior.h".
11306
11307         * gnu-nat.c (gnu_nat_target::detach): Instead of
11308         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11309         * gnu-nat.h: #include "inf-child.h".
11310         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11311         'i386_gnu_nat_target::fetch_registers'.
11312         (gnu_store_registers): Rename/move to
11313         'i386_gnu_nat_target::store_registers'.
11314
11315         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11316         * gnu-nat.h (mach_thread_info): New function.
11317         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11318
11319         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11320
11321 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11322
11323         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11324
11325 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11326
11327         * windows-nat.c (windows_add_thread): Add new parameter
11328         "main_thread_p" with default value set to false.  Update
11329         function documentation as well as all callers.
11330         (windows_delete_thread): Likewise.
11331         (fake_create_process): Update call to windows_add_thread.
11332         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11333         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11334         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11335         call to windows_delete_thread.
11336
11337 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11338
11339         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11340
11341 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11342
11343         * symfile.c (find_separate_debug_file): Use canonical path of
11344         sysroot with child_path instead of gdb_sysroot if it is valid.
11345
11346 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11347
11348         * symfile.c (find_separate_debug_file): Use child_path to
11349         determine if an object file is under a sysroot.
11350
11351 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11352
11353         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11354         unittests/child-path-selftests.c.
11355         * common/pathstuff.c (child_path): New function.
11356         * common/pathstuff.h (child_path): New prototype.
11357         * unittests/child-path-selftests.c: New file.
11358
11359 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11360
11361         * symfile.c (find_separate_debug_file): Look for separate debug
11362         files in debug directories under the sysroot.
11363
11364 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11365
11366         * symtab.h (struct minimal_symbol data_p): New const method.
11367         (struct minimal_symbol text_p): Likewise.
11368         * symtab.c (output_source_filename): Use file name style
11369         to print file name.
11370         (print_symbol_info): Likewise.
11371         (print_msymbol_info): Use address style to print addresses.
11372         Use function name style to print executable text symbols.
11373         (expand_symtab_containing_pc): Use data_p.
11374         (find_pc_sect_compunit_symtab): Likewise.
11375
11376 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11377
11378         * breakpoint.c (describe_other_breakpoints): Use address style
11379         to print addresses.
11380         (say_where): Likewise.
11381
11382 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11383
11384         * ada-typeprint.c (print_func_type): Print function name
11385         style to print function name.
11386         * c-typeprint.c (c_print_type_1): Likewise.
11387
11388 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11389
11390         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11391         for execve.
11392
11393 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11394
11395         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11396         type_stack.
11397
11398 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11399
11400         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11401         TYPE_CODE_REF types.
11402
11403 2019-02-08  Jim Wilson  <jimw@sifive.com>
11404
11405         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11406         (riscv_linux_fregset): New.
11407         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11408
11409 2019-02-07  Tom Tromey  <tom@tromey.com>
11410
11411         * thread.c (thread_cancel_execution_command): Update.
11412         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11413         methods.
11414         (struct thread_fsm_ops): Remove.
11415         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11416         (thread_fsm_should_stop, thread_fsm_return_value)
11417         (thread_fsm_set_finished, thread_fsm_finished_p)
11418         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11419         Don't declare.
11420         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11421         * infrun.c (clear_proceed_status_thread)
11422         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11423         (print_stop_event): Update.
11424         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11425         Add constructor.
11426         (step_command_fsm_ops): Remove.
11427         (new_step_command_fsm): Remove.
11428         (step_1): Update.
11429         (step_command_fsm::should_stop): Rename from
11430         step_command_fsm_should_stop.
11431         (step_command_fsm::clean_up): Rename from
11432         step_command_fsm_clean_up.
11433         (step_command_fsm::do_async_reply_reason): Rename from
11434         step_command_fsm_async_reply_reason.
11435         (struct until_next_fsm): Inherit from thread_fsm.  Add
11436         constructor.
11437         (until_next_fsm_ops): Remove.
11438         (new_until_next_fsm): Remove.
11439         (until_next_fsm::should_stop): Rename from
11440         until_next_fsm_should_stop.
11441         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11442         (until_next_fsm::do_async_reply_reason): Rename from
11443         until_next_fsm_async_reply_reason.
11444         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11445         constructor.  Change type of breakpoint.
11446         (finish_command_fsm_ops): Remove.
11447         (new_finish_command_fsm): Remove.
11448         (finish_command_fsm::should_stop): Rename from
11449         finish_command_fsm_should_stop.
11450         (finish_command_fsm::clean_up): Rename from
11451         finish_command_fsm_clean_up.
11452         (finish_command_fsm::return_value): Rename from
11453         finish_command_fsm_return_value.
11454         (finish_command_fsm::do_async_reply_reason): Rename from
11455         finish_command_fsm_async_reply_reason.
11456         (finish_command): Update.
11457         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11458         Add constructor.
11459         (call_thread_fsm_ops): Remove.
11460         (call_thread_fsm::call_thread_fsm): Rename from
11461         new_call_thread_fsm.
11462         (call_thread_fsm::should_stop): Rename from
11463         call_thread_fsm_should_stop.
11464         (call_thread_fsm::should_notify_stop): Rename from
11465         call_thread_fsm_should_notify_stop.
11466         (run_inferior_call, call_function_by_hand_dummy): Update.
11467         * cli/cli-interp.c (should_print_stop_to_console): Update.
11468         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11469         Add constructor.  Change type of location_breakpoint,
11470         caller_breakpoint.
11471         (until_break_fsm_ops): Remove.
11472         (new_until_break_fsm): Remove.
11473         (until_break_fsm::should_stop): Rename from
11474         until_break_fsm_should_stop.
11475         (until_break_fsm::clean_up): Rename from
11476         until_break_fsm_clean_up.
11477         (until_break_fsm::do_async_reply_reason): Rename from
11478         until_break_fsm_async_reply_reason.
11479         (until_break_command): Update.
11480         * thread-fsm.c: Remove.
11481         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11482
11483 2019-02-07  Tom Tromey  <tom@tromey.com>
11484
11485         * yy-remap.h: Add include guard.
11486         * xtensa-tdep.h: Add include guard.
11487         * xcoffread.h: Rename include guard.
11488         * varobj-iter.h: Add include guard.
11489         * tui/tui.h: Rename include guard.
11490         * tui/tui-winsource.h: Rename include guard.
11491         * tui/tui-wingeneral.h: Rename include guard.
11492         * tui/tui-windata.h: Rename include guard.
11493         * tui/tui-win.h: Rename include guard.
11494         * tui/tui-stack.h: Rename include guard.
11495         * tui/tui-source.h: Rename include guard.
11496         * tui/tui-regs.h: Rename include guard.
11497         * tui/tui-out.h: Rename include guard.
11498         * tui/tui-layout.h: Rename include guard.
11499         * tui/tui-io.h: Rename include guard.
11500         * tui/tui-hooks.h: Rename include guard.
11501         * tui/tui-file.h: Rename include guard.
11502         * tui/tui-disasm.h: Rename include guard.
11503         * tui/tui-data.h: Rename include guard.
11504         * tui/tui-command.h: Rename include guard.
11505         * tic6x-tdep.h: Add include guard.
11506         * target/waitstatus.h: Rename include guard.
11507         * target/wait.h: Rename include guard.
11508         * target/target.h: Rename include guard.
11509         * target/resume.h: Rename include guard.
11510         * target-float.h: Rename include guard.
11511         * stabsread.h: Add include guard.
11512         * rs6000-tdep.h: Add include guard.
11513         * riscv-fbsd-tdep.h: Add include guard.
11514         * regformats/regdef.h: Rename include guard.
11515         * record.h: Rename include guard.
11516         * python/python.h: Rename include guard.
11517         * python/python-internal.h: Rename include guard.
11518         * python/py-stopevent.h: Rename include guard.
11519         * python/py-ref.h: Rename include guard.
11520         * python/py-record.h: Rename include guard.
11521         * python/py-record-full.h: Rename include guard.
11522         * python/py-record-btrace.h: Rename include guard.
11523         * python/py-instruction.h: Rename include guard.
11524         * python/py-events.h: Rename include guard.
11525         * python/py-event.h: Rename include guard.
11526         * procfs.h: Add include guard.
11527         * proc-utils.h: Add include guard.
11528         * p-lang.h: Add include guard.
11529         * or1k-tdep.h: Rename include guard.
11530         * observable.h: Rename include guard.
11531         * nto-tdep.h: Rename include guard.
11532         * nat/x86-linux.h: Rename include guard.
11533         * nat/x86-linux-dregs.h: Rename include guard.
11534         * nat/x86-gcc-cpuid.h: Add include guard.
11535         * nat/x86-dregs.h: Rename include guard.
11536         * nat/x86-cpuid.h: Rename include guard.
11537         * nat/ppc-linux.h: Rename include guard.
11538         * nat/mips-linux-watch.h: Rename include guard.
11539         * nat/linux-waitpid.h: Rename include guard.
11540         * nat/linux-ptrace.h: Rename include guard.
11541         * nat/linux-procfs.h: Rename include guard.
11542         * nat/linux-osdata.h: Rename include guard.
11543         * nat/linux-nat.h: Rename include guard.
11544         * nat/linux-namespaces.h: Rename include guard.
11545         * nat/linux-btrace.h: Rename include guard.
11546         * nat/glibc_thread_db.h: Rename include guard.
11547         * nat/gdb_thread_db.h: Rename include guard.
11548         * nat/gdb_ptrace.h: Rename include guard.
11549         * nat/fork-inferior.h: Rename include guard.
11550         * nat/amd64-linux-siginfo.h: Rename include guard.
11551         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11552         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11553         * nat/aarch64-linux.h: Rename include guard.
11554         * nat/aarch64-linux-hw-point.h: Rename include guard.
11555         * mn10300-tdep.h: Add include guard.
11556         * mips-linux-tdep.h: Add include guard.
11557         * mi/mi-parse.h: Rename include guard.
11558         * mi/mi-out.h: Rename include guard.
11559         * mi/mi-main.h: Rename include guard.
11560         * mi/mi-interp.h: Rename include guard.
11561         * mi/mi-getopt.h: Rename include guard.
11562         * mi/mi-console.h: Rename include guard.
11563         * mi/mi-common.h: Rename include guard.
11564         * mi/mi-cmds.h: Rename include guard.
11565         * mi/mi-cmd-break.h: Rename include guard.
11566         * m2-lang.h: Add include guard.
11567         * location.h: Rename include guard.
11568         * linux-record.h: Rename include guard.
11569         * linux-nat.h: Add include guard.
11570         * linux-fork.h: Add include guard.
11571         * i386-darwin-tdep.h: Rename include guard.
11572         * hppa-linux-offsets.h: Add include guard.
11573         * guile/guile.h: Rename include guard.
11574         * guile/guile-internal.h: Rename include guard.
11575         * gnu-nat.h: Rename include guard.
11576         * gdb-stabs.h: Rename include guard.
11577         * frv-tdep.h: Add include guard.
11578         * f-lang.h: Add include guard.
11579         * event-loop.h: Add include guard.
11580         * darwin-nat.h: Rename include guard.
11581         * cp-abi.h: Rename include guard.
11582         * config/sparc/nm-sol2.h: Rename include guard.
11583         * config/nm-nto.h: Rename include guard.
11584         * config/nm-linux.h: Add include guard.
11585         * config/i386/nm-i386gnu.h: Rename include guard.
11586         * config/djgpp/nl_types.h: Rename include guard.
11587         * config/djgpp/langinfo.h: Rename include guard.
11588         * compile/gcc-cp-plugin.h: Add include guard.
11589         * compile/gcc-c-plugin.h: Add include guard.
11590         * compile/compile.h: Rename include guard.
11591         * compile/compile-object-run.h: Rename include guard.
11592         * compile/compile-object-load.h: Rename include guard.
11593         * compile/compile-internal.h: Rename include guard.
11594         * compile/compile-cplus.h: Rename include guard.
11595         * compile/compile-c.h: Rename include guard.
11596         * common/xml-utils.h: Rename include guard.
11597         * common/x86-xstate.h: Rename include guard.
11598         * common/version.h: Rename include guard.
11599         * common/vec.h: Rename include guard.
11600         * common/tdesc.h: Rename include guard.
11601         * common/selftest.h: Rename include guard.
11602         * common/scoped_restore.h: Rename include guard.
11603         * common/scoped_mmap.h: Rename include guard.
11604         * common/scoped_fd.h: Rename include guard.
11605         * common/safe-iterator.h: Rename include guard.
11606         * common/run-time-clock.h: Rename include guard.
11607         * common/refcounted-object.h: Rename include guard.
11608         * common/queue.h: Rename include guard.
11609         * common/ptid.h: Rename include guard.
11610         * common/print-utils.h: Rename include guard.
11611         * common/preprocessor.h: Rename include guard.
11612         * common/pathstuff.h: Rename include guard.
11613         * common/observable.h: Rename include guard.
11614         * common/netstuff.h: Rename include guard.
11615         * common/job-control.h: Rename include guard.
11616         * common/host-defs.h: Rename include guard.
11617         * common/gdb_wait.h: Rename include guard.
11618         * common/gdb_vecs.h: Rename include guard.
11619         * common/gdb_unlinker.h: Rename include guard.
11620         * common/gdb_unique_ptr.h: Rename include guard.
11621         * common/gdb_tilde_expand.h: Rename include guard.
11622         * common/gdb_sys_time.h: Rename include guard.
11623         * common/gdb_string_view.h: Rename include guard.
11624         * common/gdb_splay_tree.h: Rename include guard.
11625         * common/gdb_setjmp.h: Rename include guard.
11626         * common/gdb_ref_ptr.h: Rename include guard.
11627         * common/gdb_optional.h: Rename include guard.
11628         * common/gdb_locale.h: Rename include guard.
11629         * common/gdb_assert.h: Rename include guard.
11630         * common/filtered-iterator.h: Rename include guard.
11631         * common/filestuff.h: Rename include guard.
11632         * common/fileio.h: Rename include guard.
11633         * common/environ.h: Rename include guard.
11634         * common/common-utils.h: Rename include guard.
11635         * common/common-types.h: Rename include guard.
11636         * common/common-regcache.h: Rename include guard.
11637         * common/common-inferior.h: Rename include guard.
11638         * common/common-gdbthread.h: Rename include guard.
11639         * common/common-exceptions.h: Rename include guard.
11640         * common/common-defs.h: Rename include guard.
11641         * common/common-debug.h: Rename include guard.
11642         * common/cleanups.h: Rename include guard.
11643         * common/buffer.h: Rename include guard.
11644         * common/btrace-common.h: Rename include guard.
11645         * common/break-common.h: Rename include guard.
11646         * cli/cli-utils.h: Rename include guard.
11647         * cli/cli-style.h: Rename include guard.
11648         * cli/cli-setshow.h: Rename include guard.
11649         * cli/cli-script.h: Rename include guard.
11650         * cli/cli-interp.h: Rename include guard.
11651         * cli/cli-decode.h: Rename include guard.
11652         * cli/cli-cmds.h: Rename include guard.
11653         * charset-list.h: Add include guard.
11654         * buildsym-legacy.h: Rename include guard.
11655         * bfin-tdep.h: Add include guard.
11656         * ax.h: Rename include guard.
11657         * arm-linux-tdep.h: Add include guard.
11658         * arm-fbsd-tdep.h: Add include guard.
11659         * arch/xtensa.h: Rename include guard.
11660         * arch/tic6x.h: Add include guard.
11661         * arch/i386.h: Add include guard.
11662         * arch/arm.h: Rename include guard.
11663         * arch/arm-linux.h: Rename include guard.
11664         * arch/arm-get-next-pcs.h: Rename include guard.
11665         * arch/amd64.h: Add include guard.
11666         * arch/aarch64-insn.h: Rename include guard.
11667         * arch-utils.h: Rename include guard.
11668         * annotate.h: Add include guard.
11669         * amd64-darwin-tdep.h: Rename include guard.
11670         * aarch64-linux-tdep.h: Add include guard.
11671         * aarch64-fbsd-tdep.h: Add include guard.
11672         * aarch32-linux-nat.h: Add include guard.
11673
11674 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11675
11676         * macrotab.c (macro_define_internal): New function that
11677         factorizes macro_define_object_internal and macro_define_function
11678         code.
11679         (macro_define_object_internal): Use macro_define_internal.
11680         (macro_define_function): Likewise.
11681
11682 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11683
11684         * macrocmd.c (extract_identifier): Return
11685         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11686         callers.
11687
11688 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11689
11690         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11691
11692 2019-02-05  Tom Tromey  <tom@tromey.com>
11693
11694         * target.c (target_stack::unpush): Move assertion earlier.
11695
11696 2019-01-30  Tom Tromey  <tom@tromey.com>
11697
11698         PR python/23615:
11699         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11700         (gdbpy_parse_and_eval): Likewise.
11701         * python/python-internal.h (gdbpy_allow_threads): New class.
11702
11703 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11704
11705         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11706         (aarch64_fbsd_fpregmap): Move earlier.
11707         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11708         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11709         instead of individual calls to trad_frame_set_reg_addr.
11710         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11711         earlier.
11712         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11713         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11714         instead of individual calls to trad_frame_set_reg_addr.
11715
11716 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11717
11718         * CONTRIBUTE: Replace contribution list with wiki link.
11719
11720 2019-01-25  Tom Tromey  <tom@tromey.com>
11721
11722         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11723
11724 2019-01-25  Tom Tromey  <tom@tromey.com>
11725
11726         * xtensa-linux-nat.c: Fix common/ includes.
11727         * xml-support.h: Fix common/ includes.
11728         * xml-support.c: Fix common/ includes.
11729         * x86-linux-nat.c: Fix common/ includes.
11730         * windows-nat.c: Fix common/ includes.
11731         * varobj.h: Fix common/ includes.
11732         * varobj.c: Fix common/ includes.
11733         * value.c: Fix common/ includes.
11734         * valops.c: Fix common/ includes.
11735         * utils.c: Fix common/ includes.
11736         * unittests/xml-utils-selftests.c: Fix common/ includes.
11737         * unittests/utils-selftests.c: Fix common/ includes.
11738         * unittests/unpack-selftests.c: Fix common/ includes.
11739         * unittests/tracepoint-selftests.c: Fix common/ includes.
11740         * unittests/style-selftests.c: Fix common/ includes.
11741         * unittests/string_view-selftests.c: Fix common/ includes.
11742         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11743         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11744         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11745         * unittests/rsp-low-selftests.c: Fix common/ includes.
11746         * unittests/parse-connection-spec-selftests.c: Fix common/
11747         includes.
11748         * unittests/optional-selftests.c: Fix common/ includes.
11749         * unittests/offset-type-selftests.c: Fix common/ includes.
11750         * unittests/observable-selftests.c: Fix common/ includes.
11751         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11752         * unittests/memrange-selftests.c: Fix common/ includes.
11753         * unittests/memory-map-selftests.c: Fix common/ includes.
11754         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11755         * unittests/function-view-selftests.c: Fix common/ includes.
11756         * unittests/environ-selftests.c: Fix common/ includes.
11757         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11758         * unittests/common-utils-selftests.c: Fix common/ includes.
11759         * unittests/cli-utils-selftests.c: Fix common/ includes.
11760         * unittests/array-view-selftests.c: Fix common/ includes.
11761         * ui-file.c: Fix common/ includes.
11762         * tui/tui-io.c: Fix common/ includes.
11763         * tracepoint.h: Fix common/ includes.
11764         * tracepoint.c: Fix common/ includes.
11765         * tracefile-tfile.c: Fix common/ includes.
11766         * top.h: Fix common/ includes.
11767         * top.c: Fix common/ includes.
11768         * thread.c: Fix common/ includes.
11769         * target/waitstatus.h: Fix common/ includes.
11770         * target/waitstatus.c: Fix common/ includes.
11771         * target.h: Fix common/ includes.
11772         * target.c: Fix common/ includes.
11773         * target-memory.c: Fix common/ includes.
11774         * target-descriptions.c: Fix common/ includes.
11775         * symtab.h: Fix common/ includes.
11776         * symfile.c: Fix common/ includes.
11777         * stap-probe.c: Fix common/ includes.
11778         * spu-linux-nat.c: Fix common/ includes.
11779         * sparc-nat.c: Fix common/ includes.
11780         * source.c: Fix common/ includes.
11781         * solib.c: Fix common/ includes.
11782         * solib-target.c: Fix common/ includes.
11783         * ser-unix.c: Fix common/ includes.
11784         * ser-tcp.c: Fix common/ includes.
11785         * ser-pipe.c: Fix common/ includes.
11786         * ser-base.c: Fix common/ includes.
11787         * selftest-arch.c: Fix common/ includes.
11788         * s12z-tdep.c: Fix common/ includes.
11789         * rust-exp.y: Fix common/ includes.
11790         * rs6000-aix-tdep.c: Fix common/ includes.
11791         * riscv-tdep.c: Fix common/ includes.
11792         * remote.c: Fix common/ includes.
11793         * remote-notif.h: Fix common/ includes.
11794         * remote-fileio.h: Fix common/ includes.
11795         * remote-fileio.c: Fix common/ includes.
11796         * regcache.h: Fix common/ includes.
11797         * regcache.c: Fix common/ includes.
11798         * record-btrace.c: Fix common/ includes.
11799         * python/python.c: Fix common/ includes.
11800         * python/py-type.c: Fix common/ includes.
11801         * python/py-inferior.c: Fix common/ includes.
11802         * progspace.h: Fix common/ includes.
11803         * producer.c: Fix common/ includes.
11804         * procfs.c: Fix common/ includes.
11805         * proc-api.c: Fix common/ includes.
11806         * printcmd.c: Fix common/ includes.
11807         * ppc-linux-nat.c: Fix common/ includes.
11808         * parser-defs.h: Fix common/ includes.
11809         * osdata.c: Fix common/ includes.
11810         * obsd-nat.c: Fix common/ includes.
11811         * nat/x86-linux.c: Fix common/ includes.
11812         * nat/x86-linux-dregs.c: Fix common/ includes.
11813         * nat/x86-dregs.h: Fix common/ includes.
11814         * nat/x86-dregs.c: Fix common/ includes.
11815         * nat/ppc-linux.c: Fix common/ includes.
11816         * nat/mips-linux-watch.h: Fix common/ includes.
11817         * nat/mips-linux-watch.c: Fix common/ includes.
11818         * nat/linux-waitpid.c: Fix common/ includes.
11819         * nat/linux-ptrace.h: Fix common/ includes.
11820         * nat/linux-ptrace.c: Fix common/ includes.
11821         * nat/linux-procfs.c: Fix common/ includes.
11822         * nat/linux-personality.c: Fix common/ includes.
11823         * nat/linux-osdata.c: Fix common/ includes.
11824         * nat/linux-namespaces.c: Fix common/ includes.
11825         * nat/linux-btrace.h: Fix common/ includes.
11826         * nat/linux-btrace.c: Fix common/ includes.
11827         * nat/fork-inferior.c: Fix common/ includes.
11828         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11829         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11830         * nat/aarch64-linux.c: Fix common/ includes.
11831         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11832         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11833         * namespace.h: Fix common/ includes.
11834         * mips-linux-tdep.c: Fix common/ includes.
11835         * minsyms.c: Fix common/ includes.
11836         * mi/mi-parse.h: Fix common/ includes.
11837         * mi/mi-main.c: Fix common/ includes.
11838         * mi/mi-cmd-env.c: Fix common/ includes.
11839         * memrange.h: Fix common/ includes.
11840         * memattr.c: Fix common/ includes.
11841         * maint.h: Fix common/ includes.
11842         * maint.c: Fix common/ includes.
11843         * main.c: Fix common/ includes.
11844         * machoread.c: Fix common/ includes.
11845         * location.c: Fix common/ includes.
11846         * linux-thread-db.c: Fix common/ includes.
11847         * linux-nat.c: Fix common/ includes.
11848         * linux-fork.c: Fix common/ includes.
11849         * inline-frame.c: Fix common/ includes.
11850         * infrun.c: Fix common/ includes.
11851         * inflow.c: Fix common/ includes.
11852         * inferior.h: Fix common/ includes.
11853         * inferior.c: Fix common/ includes.
11854         * infcmd.c: Fix common/ includes.
11855         * inf-ptrace.c: Fix common/ includes.
11856         * inf-child.c: Fix common/ includes.
11857         * ia64-linux-nat.c: Fix common/ includes.
11858         * i387-tdep.c: Fix common/ includes.
11859         * i386-tdep.c: Fix common/ includes.
11860         * i386-linux-tdep.c: Fix common/ includes.
11861         * i386-linux-nat.c: Fix common/ includes.
11862         * i386-go32-tdep.c: Fix common/ includes.
11863         * i386-fbsd-tdep.c: Fix common/ includes.
11864         * i386-fbsd-nat.c: Fix common/ includes.
11865         * guile/scm-type.c: Fix common/ includes.
11866         * guile/guile.c: Fix common/ includes.
11867         * go32-nat.c: Fix common/ includes.
11868         * gnu-nat.c: Fix common/ includes.
11869         * gdbthread.h: Fix common/ includes.
11870         * gdbarch-selftests.c: Fix common/ includes.
11871         * gdb_usleep.c: Fix common/ includes.
11872         * gdb_select.h: Fix common/ includes.
11873         * gdb_bfd.c: Fix common/ includes.
11874         * gcore.c: Fix common/ includes.
11875         * fork-child.c: Fix common/ includes.
11876         * findvar.c: Fix common/ includes.
11877         * fbsd-nat.c: Fix common/ includes.
11878         * event-top.c: Fix common/ includes.
11879         * event-loop.c: Fix common/ includes.
11880         * dwarf2read.c: Fix common/ includes.
11881         * dwarf2loc.c: Fix common/ includes.
11882         * dwarf2-frame.c: Fix common/ includes.
11883         * dwarf-index-cache.c: Fix common/ includes.
11884         * dtrace-probe.c: Fix common/ includes.
11885         * disasm-selftests.c: Fix common/ includes.
11886         * defs.h: Fix common/ includes.
11887         * csky-tdep.c: Fix common/ includes.
11888         * cp-valprint.c: Fix common/ includes.
11889         * cp-support.h: Fix common/ includes.
11890         * cp-support.c: Fix common/ includes.
11891         * corelow.c: Fix common/ includes.
11892         * completer.h: Fix common/ includes.
11893         * completer.c: Fix common/ includes.
11894         * compile/compile.c: Fix common/ includes.
11895         * compile/compile-loc2c.c: Fix common/ includes.
11896         * compile/compile-cplus-types.c: Fix common/ includes.
11897         * compile/compile-cplus-symbols.c: Fix common/ includes.
11898         * command.h: Fix common/ includes.
11899         * cli/cli-dump.c: Fix common/ includes.
11900         * cli/cli-cmds.c: Fix common/ includes.
11901         * charset.c: Fix common/ includes.
11902         * build-id.c: Fix common/ includes.
11903         * btrace.h: Fix common/ includes.
11904         * btrace.c: Fix common/ includes.
11905         * breakpoint.h: Fix common/ includes.
11906         * breakpoint.c: Fix common/ includes.
11907         * ax.h:
11908         (enum agent_op): Fix common/ includes.
11909         * ax-general.c (struct aop_map): Fix common/ includes.
11910         * ax-gdb.c: Fix common/ includes.
11911         * auxv.c: Fix common/ includes.
11912         * auto-load.c: Fix common/ includes.
11913         * arm-tdep.c: Fix common/ includes.
11914         * arch/riscv.c: Fix common/ includes.
11915         * arch/ppc-linux-common.c: Fix common/ includes.
11916         * arch/i386.c: Fix common/ includes.
11917         * arch/arm.c: Fix common/ includes.
11918         * arch/arm-linux.c: Fix common/ includes.
11919         * arch/arm-get-next-pcs.c: Fix common/ includes.
11920         * arch/amd64.c: Fix common/ includes.
11921         * arch/aarch64.c: Fix common/ includes.
11922         * arch/aarch64-insn.c: Fix common/ includes.
11923         * arch-utils.c: Fix common/ includes.
11924         * amd64-windows-tdep.c: Fix common/ includes.
11925         * amd64-tdep.c: Fix common/ includes.
11926         * amd64-sol2-tdep.c: Fix common/ includes.
11927         * amd64-obsd-tdep.c: Fix common/ includes.
11928         * amd64-nbsd-tdep.c: Fix common/ includes.
11929         * amd64-linux-tdep.c: Fix common/ includes.
11930         * amd64-linux-nat.c: Fix common/ includes.
11931         * amd64-fbsd-tdep.c: Fix common/ includes.
11932         * amd64-fbsd-nat.c: Fix common/ includes.
11933         * amd64-dicos-tdep.c: Fix common/ includes.
11934         * amd64-darwin-tdep.c: Fix common/ includes.
11935         * agent.c: Fix common/ includes.
11936         * ada-lang.h: Fix common/ includes.
11937         * ada-lang.c: Fix common/ includes.
11938         * aarch64-tdep.c: Fix common/ includes.
11939
11940 2019-01-25  Tom Tromey  <tom@tromey.com>
11941
11942         * common/create-version.sh: Use common/version.h.
11943
11944 2019-01-24  Pedro Alves  <palves@redhat.com>
11945
11946         * infrun.c (signal_stop, signal_print, signal_program)
11947         (signal_catch, signal_pass): Now arrays instead of pointers.
11948         (update_signals_program_target, do_target_resume)
11949         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11950         * linux-nat.c (linux_nat_target::pass_signals)
11951         (linux_nat_target::create_inferior, linux_nat_target::attach):
11952         Adjust.
11953         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11954         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11955         * procfs.c (procfs_target::pass_signals): Adjust.
11956         * record-full.c (record_full_target::resume): Adjust.
11957         * remote.c (remote_target::pass_signals)
11958         (remote_target::program_signals): Adjust.
11959         * target-debug.h (target_debug_print_signals): Now takes a
11960         gdb::array_view as parameter.  Adjust.
11961         * target.h (target_ops) <pass_signals, program_signals>: Replace
11962         pointer and length parameters with gdb::array_view.
11963         (target_pass_signals, target_program_signals): Likewise.
11964         * target-delegates.c: Regenerate.
11965
11966 2019-01-24  Pedro Alves  <palves@redhat.com>
11967
11968         * common/forward-scope-exit.h
11969         (forward_scope_exit::forward_scope_exit): Pass arguments to
11970         m_bind_function directly, instead of creating a std::bind and
11971         copying that.
11972
11973 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11974
11975         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11976         for static members.
11977         (pass_in_v_vfp_candidate): Likewise.
11978
11979 2019-01-23  Tom Tromey  <tom@tromey.com>
11980             Pedro Alves  <palves@redhat.com>
11981
11982         * regcache.c (class regcache_invalidator): Remove.
11983         (regcache::raw_write): Use make_scope_exit.
11984
11985 2019-01-23  Tom Tromey  <tom@tromey.com>
11986
11987         * ui-out.h (class ui_out_emit_type): Update comment.
11988
11989 2019-01-23  Tom Tromey  <tom@tromey.com>
11990
11991         * infrun.c (fetch_inferior_event): Update comment.
11992
11993 2019-01-23  Tom Tromey  <tom@tromey.com>
11994             Pedro Alves  <palves@redhat.com>
11995
11996         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11997         parameter.
11998         (fetch_inferior_event): Use SCOPE_EXIT.
11999
12000
12001 2019-01-23  Tom Tromey  <tom@tromey.com>
12002             Pedro Alves  <palves@redhat.com>
12003
12004         * infrun.c (disable_thread_events): Delete.
12005         (stop_all_threads): Use SCOPE_EXIT.
12006
12007 2019-01-23  Tom Tromey  <tom@tromey.com>
12008             Pedro Alves  <palves@redhat.com>
12009
12010         * symfile.c: Include forward-scope-exit.h.
12011         (clear_symtab_users_cleanup): Replace forward declaration with
12012         a FORWARD_SCOPE_EXIT.
12013         (syms_from_objfile_1): Use the forward_scope_exit and
12014         gdb::optional instead of cleanup_function.
12015         (reread_symbols): Use the forward_scope_exit instead of
12016         cleanup_function.
12017         (clear_symtab_users_cleanup): Remove function.
12018
12019 2019-01-23  Tom Tromey  <tom@tromey.com>
12020             Pedro Alves  <palves@redhat.com>
12021
12022         * linux-nat.c: Include scope-exit.h.
12023         (cleanup_target_stop): Remove.
12024         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12025         SCOPE_EXIT.
12026
12027 2019-01-23  Tom Tromey  <tom@tromey.com>
12028             Pedro Alves  <palves@redhat.com>
12029
12030         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12031         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12032
12033 2019-01-23  Tom Tromey  <tom@tromey.com>
12034             Andrew Burgess  <andrew.burgess@embecosm.com>
12035             Pedro Alves  <palves@redhat.com>
12036
12037         * infrun.c (fetch_inferior_event): Use scope_exit.
12038         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12039         * top.c (execute_command): Use scope_exit.
12040         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12041         * utils.c (do_bpstat_clear_actions_cleanup)
12042         (make_bpstat_clear_actions_cleanup): Remove.
12043
12044 2019-01-23  Tom Tromey  <tom@tromey.com>
12045             Pedro Alves  <palves@redhat.com>
12046
12047         * infrun.c: Include "common/scope-exit.h"
12048         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12049         (wait_for_inferior): Use SCOPE_EXIT.
12050         (fetch_inferior_event): Use scope_exit.
12051
12052 2019-01-23  Tom Tromey  <tom@tromey.com>
12053             Pedro Alves  <palves@redhat.com>
12054
12055         * breakpoint.c (create_breakpoint): Remove cleanup.
12056
12057 2019-01-23  Tom Tromey  <tom@tromey.com>
12058             Andrew Burgess  <andrew.burgess@embecosm.com>
12059             Pedro Alves  <palves@redhat.com>
12060
12061 2019-01-23  Pedro Alves  <palves@redhat.com>
12062
12063         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12064
12065 2019-01-23  Pedro Alves  <palves@redhat.com>
12066             Andrew Burgess  <andrew.burgess@embecosm.com>
12067
12068         * gdbthread.h: Include "common/forward-scope-exit.h".
12069         (scoped_finish_thread_state): Redefine custom class in terms of
12070         forward_scope_exit.
12071
12072 2019-01-23  Pedro Alves  <palves@redhat.com>
12073             Andrew Burgess  <andrew.burgess@embecosm.com>
12074
12075         * common/forward-scope-exit.h: New file.
12076
12077 2019-01-23  Pedro Alves  <palves@redhat.com>
12078             Andrew Burgess  <andrew.burgess@embecosm.com>
12079             Tom Tromey  <tom@tromey.com>
12080
12081         * common/scope-exit.h: New file.
12082
12083 2019-01-23  Pedro Alves  <palves@redhat.com>
12084
12085         * common/preprocessor.h (ESC): Rename to ...
12086         (ESC_PARENS): ... this.
12087         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12088         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12089
12090 2019-01-23  Tom Tromey  <tom@tromey.com>
12091
12092         * language.h (class scoped_switch_to_sym_language_if_auto):
12093         Initialize m_lang in both cases.
12094
12095 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12096
12097         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12098         with XCNEW.
12099
12100 2019-01-22  Tom Tromey  <tom@tromey.com>
12101
12102         * corelow.c: Do not include sys/file.h.
12103
12104 2019-01-22  Tom Tromey  <tom@tromey.com>
12105
12106         * tui/tui-wingeneral.h: Include gdb_curses.h.
12107
12108 2019-01-22  Tom Tromey  <tom@tromey.com>
12109
12110         * source-cache.h (class source_cache) <get_source_lines,
12111         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12112
12113 2019-01-22  Tom Tromey  <tom@tromey.com>
12114
12115         * remote-fileio.h (struct remote_target): Declare.
12116
12117 2019-01-22  Tom Tromey  <tom@tromey.com>
12118
12119         * python/py-arch.c: Do not include py-ref.h.
12120         * python/py-bpevent.c: Do not include py-ref.h.
12121         * python/py-cmd.c: Do not include py-ref.h.
12122         * python/py-continueevent.c: Do not include py-ref.h.
12123         * python/py-event.h: Do not include py-ref.h.
12124         * python/py-evtregistry.c: Do not include py-ref.h.
12125         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12126         * python/py-frame.c: Do not include py-ref.h.
12127         * python/py-framefilter.c: Do not include py-ref.h.
12128         * python/py-function.c: Do not include py-ref.h.
12129         * python/py-infevents.c: Do not include py-ref.h.
12130         * python/py-linetable.c: Do not include py-ref.h.
12131         * python/py-objfile.c: Do not include py-ref.h.
12132         * python/py-param.c: Do not include py-ref.h.
12133         * python/py-prettyprint.c: Do not include py-ref.h.
12134         * python/py-progspace.c: Do not include py-ref.h.
12135         * python/py-symbol.c: Do not include py-ref.h.
12136         * python/py-symtab.c: Do not include py-ref.h.
12137         * python/py-type.c: Do not include py-ref.h.
12138         * python/py-unwind.c: Do not include py-ref.h.
12139         * python/py-utils.c: Do not include py-ref.h.
12140         * python/py-value.c: Do not include py-ref.h.
12141         * python/py-varobj.c: Do not include py-ref.h.
12142         * python/py-xmethods.c: Do not include py-ref.h.
12143         * python/python.c: Do not include py-ref.h.
12144         * varobj.c: Do not include py-ref.h.
12145
12146 2019-01-22  Tom Tromey  <tom@tromey.com>
12147
12148         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12149         keyword for bcache.
12150
12151 2019-01-22  Tom Tromey  <tom@tromey.com>
12152
12153         * compile/compile-cplus-types.c: Remove a comment by #include.
12154
12155 2019-01-22  Tom Tromey  <tom@tromey.com>
12156
12157         * compile/gcc-c-plugin.h: Include compile-internal.h.
12158
12159 2019-01-22  Tom Tromey  <tom@tromey.com>
12160
12161         * stabsread.c (EXTERN): Do not define.
12162         (symnum, next_symbol_text_func, processing_gcc_compilation)
12163         (within_function, global_sym_chain, global_stabs)
12164         (previous_stab_code, this_object_header_files)
12165         (n_this_object_header_files)
12166         (n_allocated_this_object_header_files): Define.
12167         * stabsread.h (EXTERN): Never define.  Use "extern".
12168
12169 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12170
12171         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12172         history_value.
12173
12174 2019-01-21  Tom Tromey  <tom@tromey.com>
12175
12176         * ui-out.c: Fix includes.
12177         * tui/tui-source.c: Fix includes.
12178         * target.c: Fix includes.
12179         * remote.c: Fix includes.
12180         * regcache.c: Fix includes.
12181         * python/py-block.c: Fix includes.
12182         * printcmd.c: Fix includes.
12183         * or1k-tdep.c: Fix includes.
12184         * mi/mi-main.c: Fix includes.
12185         * m32r-tdep.c: Fix includes.
12186         * csky-tdep.c: Fix includes.
12187         * compile/compile-cplus-types.c: Fix includes.
12188         * cli/cli-interp.c: Fix includes.
12189
12190 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12191
12192         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12193         for padding.
12194
12195 2019-01-16  Tom Tromey  <tom@tromey.com>
12196
12197         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12198         earlier.
12199         (struct objfile) <msymbols_range>: Move from top level.
12200         <msymbols>: New method.
12201         (class objfile_msymbols): Remove.
12202         * symtab.c (default_collect_symbol_completion_matches_break_on):
12203         Update.
12204         * symmisc.c (dump_msymbols): Update.
12205         * stabsread.c (scan_file_globals): Update.
12206         * objc-lang.c (info_selectors_command, info_classes_command)
12207         (find_methods): Update.
12208         * minsyms.c (find_solib_trampoline_target): Update.
12209         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12210         * coffread.c (coff_symfile_read): Update.
12211         * ada-lang.c (ada_lookup_simple_minsym)
12212         (ada_collect_symbol_completion_matches): Update.
12213
12214 2019-01-16  Tom Tromey  <tom@tromey.com>
12215
12216         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12217         type.  Remove no-argument constructor.
12218         <iterator::operator++>: Simplify.
12219         <begin>: Update.
12220         <end>: Use minimal_symbol_count.
12221
12222 2019-01-16  Tom Tromey  <tom@tromey.com>
12223
12224         * objfiles.h (struct objfile) <psymtabs>: New method.
12225         (class objfile_psymtabs): Remove.
12226         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12227         typedef.
12228         <range>: New method.
12229         (require_partial_symbols): Change return type.
12230         * psymtab.c (require_partial_symbols)
12231         (psym_expand_symtabs_matching): Update.
12232         * mdebugread.c (parse_partial_symbols): Update.
12233         * dbxread.c (dbx_end_psymtab): Update.
12234
12235 2019-01-15  Tom Tromey  <tom@tromey.com>
12236
12237         * symtab.c (lookup_objfile_from_block)
12238         (lookup_symbol_in_objfile_symtabs)
12239         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12240         (find_line_symtab, info_sources_command)
12241         (default_collect_symbol_completion_matches_break_on)
12242         (make_source_files_completion_list): Update.
12243         * symmisc.c (print_objfile_statistics, dump_objfile)
12244         (maintenance_print_symbols, maintenance_info_symtabs)
12245         (maintenance_check_symtabs, maintenance_info_line_tables):
12246         Update.
12247         * source.c (select_source_symtab)
12248         (forget_cached_source_info_for_objfile): Update.
12249         * objfiles.h (class objfile_compunits): Remove.
12250         (struct objfile) <compunits_range>: New typedef.
12251         (compunits): New method.
12252         * objfiles.c (objfile_relocate1): Update.
12253         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12254         * maint.c (count_symtabs_and_blocks): Update.
12255         * linespec.c (iterate_over_all_matching_symtabs): Update.
12256         * cp-support.c (add_symbol_overload_list_qualified): Update.
12257         * coffread.c (coff_symtab_read): Update.
12258         * ada-lang.c (add_nonlocal_symbols)
12259         (ada_collect_symbol_completion_matches)
12260         (ada_add_global_exceptions): Update.
12261
12262 2019-01-15  Tom Tromey  <tom@tromey.com>
12263
12264         * progspace.h (program_space) <objfiles_safe_range>: New
12265         typedef.
12266         <objfiles_safe>: New method.
12267         * objfiles.h (class all_objfiles_safe): Remove.
12268         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12269         * jit.c (jit_inferior_exit_hook): Update.
12270
12271 2019-01-17  Tom Tromey  <tom@tromey.com>
12272
12273         * progspace.h (program_space) <objfiles_range>: New typedef.
12274         <objfiles>: New method.
12275         <objfiles_head>: Rename from objfiles.
12276         (object_files): Update.
12277         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12278         * guile/scm-pretty-print.c
12279         (ppscm_find_pretty_printer_from_objfiles): Update.
12280         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12281         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12282         Update.
12283         * python/py-progspace.c (pspy_get_objfiles): Update.
12284         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12285         Update.
12286         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12287         (objfpy_lookup_objfile_by_build_id): Update.
12288         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12289         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12290         Update.
12291         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12292         (expand_symtab_containing_pc, lookup_objfile_from_block)
12293         (lookup_static_symbol, basic_lookup_transparent_type)
12294         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12295         (find_line_symtab, info_sources_command)
12296         (default_collect_symbol_completion_matches_break_on)
12297         (make_source_files_completion_list, find_main_name): Update.
12298         * symmisc.c (print_symbol_bcache_statistics)
12299         (print_objfile_statistics, maintenance_print_symbols)
12300         (maintenance_print_msymbols, maintenance_print_objfiles)
12301         (maintenance_info_symtabs, maintenance_check_symtabs)
12302         (maintenance_expand_symtabs, maintenance_info_line_tables):
12303         Update.
12304         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12305         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12306         (map_overlay_command, unmap_overlay_command)
12307         (simple_overlay_update, expand_symtabs_matching)
12308         (map_symbol_filenames): Update.
12309         * symfile-debug.c (set_debug_symfile): Update.
12310         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12311         Update.
12312         * source.c (select_source_symtab, forget_cached_source_info):
12313         Update.
12314         * solib.c (solib_read_symbols): Update.
12315         * solib-spu.c (append_ocl_sos): Update.
12316         * psymtab.c (maintenance_print_psymbols)
12317         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12318         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12319         * printcmd.c (info_symbol_command): Update.
12320         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12321         Update.
12322         * objfiles.h (class all_objfiles): Remove.
12323         * objfiles.c (have_partial_symbols, have_full_symbols)
12324         (have_minimal_symbols, qsort_cmp, update_section_map)
12325         (shared_objfile_contains_address_p)
12326         (default_iterate_over_objfiles_in_search_order): Update.
12327         * objc-lang.c (info_selectors_command, info_classes_command)
12328         (find_methods): Update.
12329         * minsyms.c (find_solib_trampoline_target): Update.
12330         * maint.c (maintenance_info_sections)
12331         (maintenance_translate_address, count_symtabs_and_blocks):
12332         Update.
12333         * main.c (captured_main_1): Update.
12334         * linux-thread-db.c (try_thread_db_load_from_pdir)
12335         (has_libpthread): Update.
12336         * linespec.c (iterate_over_all_matching_symtabs)
12337         (search_minsyms_for_name): Update.
12338         * jit.c (jit_find_objf_with_entry_addr): Update.
12339         * hppa-tdep.c (find_unwind_entry)
12340         (hppa_lookup_stub_minimal_symbol): Update.
12341         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12342         Update.
12343         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12344         (elf_gnu_ifunc_resolve_by_got): Update.
12345         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12346         * dwarf-index-write.c (save_gdb_index_command): Update.
12347         * cp-support.c (add_symbol_overload_list_qualified): Update.
12348         * breakpoint.c (create_overlay_event_breakpoint)
12349         (create_longjmp_master_breakpoint)
12350         (create_std_terminate_master_breakpoint)
12351         (create_exception_master_breakpoint): Update.
12352         * blockframe.c (find_pc_partial_function): Update.
12353         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12354         (ada_collect_symbol_completion_matches)
12355         (ada_add_global_exceptions): Update.
12356
12357 2019-01-17  Tom Tromey  <tom@tromey.com>
12358
12359         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12360         declare VEC.
12361         (solib_target_parse_libraries): Change return type.
12362         (library_list_start_segment, library_list_start_section)
12363         (library_list_end_library, library_list_start_library); Update.
12364         (solib_target_free_library_list): Remove.
12365         (solib_target_parse_libraries): Remove cleanup.  Change return
12366         type.
12367         (solib_target_current_sos): Update.
12368
12369 2019-01-17  Tom Tromey  <tromey@bapiya>
12370
12371         * valprint.c: Replace "the the" with "the".
12372         * symtab.c: Replace "the the" with "the".
12373         * solib.c: Replace "the the" with "the".
12374         * solib-dsbt.c: Replace "the the" with "the".
12375         * linespec.c: Replace "the the" with "the".
12376         * dwarf2loc.h: Replace "the the" with "the".
12377         * amd64-windows-tdep.c: Replace "the the" with "the".
12378         * aarch64-tdep.c: Replace "the the" with "the".
12379
12380 2019-01-16  Keith Seitz  <keiths@redhat.com>
12381
12382         PR gdb/23773
12383         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12384         <builder>: Rename to ..
12385         <m_builder>: ... this and make private.
12386         (dwarf2_cu::get_builder): New method.  Change all users of
12387         `builder' to use this method.
12388         (dwarf2_start_symtab): Move to ...
12389         (dwarf2_cu::start_symtab): ... here.  Update all callers
12390         (setup_type_unit_groups): Move to ...
12391         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12392         callers.
12393         (dwarf2_cu::reset_builder): New method.
12394         (process_full_compunit, process_full_type_unit): Use
12395         dwarf2_cu::reset_builder.
12396         (follow_die_offset): Record the ancestor CU if it is different
12397         from the followed DIE's CU.
12398         (follow_die_sig_1): Likewise.
12399
12400 2019-01-15  Tom Tromey  <tom@tromey.com>
12401
12402         * remote.c (class remote_state) <buf>: Now a char_vector.
12403         <buf_size>: Remove.
12404         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12405         parameter.
12406         (remote_target::getpkt_or_notif_sane_1)
12407         (remote_target::getpkt_sane)
12408         (remote_target::getpkt_or_notif_sane): Likewise.
12409         (class remote_target) <putpkt>: New overload.
12410         (remote_target::read_frame): Change type of "buf_p".  Remove
12411         sizeof_p parameter.
12412         (packet_ok): New overload.
12413         (packet_check_result): New overload.
12414         Update all uses.
12415
12416 2019-01-14  Tom Tromey  <tom@tromey.com>
12417
12418         * remote-notif.c (handle_notification, remote_notif_ack)
12419         (remote_notif_parse): Make "buf" const.
12420         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12421         const.
12422         (remote_notif_parse, remote_notif_ack, handle_notification):
12423         Likewise.
12424         * remote.c (remote_notif_stop_parse): Make "buf" const.
12425         (remote_target::remote_parse_stop_reply): Make "buf" const.
12426         (remote_notif_stop_ack): Make "buf" const.
12427
12428 2019-01-14  Tom Tromey  <tom@tromey.com>
12429
12430         * remote.c (remote_console_output): Make parameter const.
12431
12432 2019-01-14  Tom Tromey  <tom@tromey.com>
12433
12434         * target-debug.h (target_debug_print_signals): Constify.
12435         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12436         * procfs.c (procfs_target::pass_signals): Update.
12437         * linux-nat.c (linux_nat_target::pass_signals): Update.
12438         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12439         * target-delegates.c: Rebuild.
12440         * remote.c (remote_target::program_signals): Update.
12441         (remote_target::pass_signals): Update.
12442         * target.c (target_pass_signals): Constify argument.
12443         (target_program_signals): Likewise.
12444         * target.h (struct target_ops) <pass_signals, program_signals>:
12445         Constify argument.
12446         (target_pass_signals, target_program_signals): Constify argument.
12447
12448 2019-01-14  Tom Tromey  <tom@tromey.com>
12449
12450         PR tui/28819:
12451         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12452
12453 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12454
12455         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12456         field.
12457         * rs6000-tdep.c: Include reggroups.h.
12458         (IS_V_ALIAS_PSEUDOREG): Define.
12459         (rs6000_register_name): Return names for the "vX" aliases.
12460         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12461         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12462         aliases.  Call default_register_reggroup_p for all other
12463         pseudo-registers.
12464         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12465         New functions.
12466         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12467         Handle "vX" aliases.
12468         (v_alias_pseudo_register_collect): New function.
12469         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12470         (rs6000_gdbarch_init): Initialize "vX" aliases as
12471         pseudo-registers.  Restore registration of
12472         rs6000_pseudo_register_reggroup_p with
12473         set_tdesc_pseudo_register_reggroup_p.
12474
12475 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12476
12477         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12478         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12479         set_gdbarch_num_pseudo_regs.
12480
12481 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12482
12483         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12484         Remove arg prefixname, add do_set and do_show.
12485         Add member functions set_list and show_list.
12486         * cli/cli-style.c (class cli_style_option): Update accordingly.
12487         (style_set_list): Move to file scope.
12488         (style_show_list): Likewise.
12489         (set_style): Call help_list.
12490         (show_style): Call cmd_show_list.
12491         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12492         Update to use the new macro.
12493
12494 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12495
12496         * ada-lang.c (_initialize_ada_language): Expand the help text
12497         for the "catch exception" command.
12498
12499 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12500
12501         * symtab.c (matching_obj_sections): Initialize obj,
12502         declare it closer to its usage.
12503
12504 2019-01-10  Tom Tromey  <tom@tromey.com>
12505
12506         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12507         (basic_inf_threads_range): Remove.
12508         (inf_threads_range, inf_non_exited_threads_range)
12509         (safe_inf_threads_range): Use next_adapter.
12510
12511 2019-01-10  Keith Seitz  <keiths@redhat.com>
12512
12513         PR gdb/23712
12514         PR symtab/23010
12515         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12516         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12517
12518 2019-01-10  Keith Seitz  <keiths@redhat.com>
12519
12520         PR gdb/23712
12521         PR symtab/23010
12522         * dictionary.c (pending_to_vector): Remove.
12523         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12524         Remove _1 suffix, replacing functions of the same name.  Update
12525         all callers.
12526         (dict_create_hashed, dict_create_hashed_expandable)
12527         (dict_create_linear, dict_create_linear_expandable, dict_free)
12528         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12529         Make functions static.
12530
12531 2019-01-10  Keith Seitz  <keiths@redhat.com>
12532
12533         PR gdb/23712
12534         PR symtab/23010
12535         * dictionary.h (struct dictionary): Replace declaration with
12536         multidictionary.
12537         (dict_create_hashed, dict_create_hashed_expandable)
12538         (dict_create_linear, dict_create_linear_expandable)
12539         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12540         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12541         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12542         taking multidictionary argument.
12543         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12544         * block.h (struct block) <dict>: Change to multidictionary
12545         and rename `multidict'.
12546         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12547         symmisc.c: Update all dictionary references to multidictionary.
12548
12549 2019-01-10  Keith Seitz  <keiths@redhat.com>
12550
12551         PR gdb/23712
12552         PR symtab/23010
12553         * dictionary.c: Include unordered_map.
12554         (pending_to_vector): New function.
12555         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12556         Rewrite the non-"_1" functions to take vector instead
12557         of linked list.
12558         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12559         "new" _1 versions of the same name.
12560         (multidictionary): Define.
12561         (std::hash<enum language): New definition.
12562         (collate_pending_symbols_by_language, mdict_create_hashed)
12563         (mdict_create_hashed_expandable, mdict_create_linear)
12564         (mdict_create_linear_expandable, mdict_free)
12565         (find_language_dictionary, create_new_language_dictionary)
12566         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12567         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12568         (mdict_size, mdict_empty): New functions.
12569         * dictionary.h (mdict_iterator): Define.
12570
12571 2019-01-10  Pedro Alves  <palves@redhat.com>
12572
12573         * breakpoint.c (read_uploaded_action)
12574         (create_tracepoint_from_upload): Adjust to use
12575         gdb::unique_xmalloc_ptr.
12576         * ctf.c (ctf_write_uploaded_tp):
12577         (SET_ARRAY_FIELD): Use emplace_back.
12578         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12579         * tracefile-tfile.c (tfile_write_uploaded_tp):
12580         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12581         gdb::unique_xmalloc_ptr.
12582         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12583         at_string, cond_string, cmd_strings>: Replace char pointers
12584         with gdb::unique_xmalloc_ptr.
12585
12586 2019-01-10  Pedro Alves  <palves@redhat.com>
12587
12588         * solib-target.c (library_list_start_library): Don't xstrdup name.
12589
12590 2019-01-10  Pedro Alves  <palves@redhat.com>
12591
12592         * mdebugread.c (parse_partial_symbols): Use
12593         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12594
12595 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12596
12597         * linux-fork.c (scoped_switch_fork_info)
12598         <~scoped_switch_fork_info>: Fix incorrect variable name.
12599
12600 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12601
12602         * linux-fork.c (scoped_switch_fork_info)
12603         <scoped_switch_fork_info>: Make explicit.
12604         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12605
12606 2019-01-10  Tom Tromey  <tom@tromey.com>
12607
12608         * objfiles.h (objfile::reset_psymtabs): Update.
12609         * objfiles.c (objfile::objfile): Update.
12610         * psymtab.h (psymtab_storage::obstack): Update.
12611         (psymtab_storage::m_obstack): Use gdb::optional.
12612         (class psymtab_storage): Update comment.  Remove objfile
12613         parameter.
12614         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12615
12616 2019-01-10  Tom Tromey  <tom@tromey.com>
12617
12618         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12619         <free_psymtabs>: Now private.
12620         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12621         (allocate_psymtab): Use new method.
12622
12623 2019-01-10  Tom Tromey  <tom@tromey.com>
12624
12625         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12626         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12627         * mdebugread.c (parse_partial_symbols): Use
12628         allocate_dependencies.
12629         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12630         allocate_dependencies.
12631         (process_psymtab_comp_unit_reader)
12632         (build_type_psymtab_dependencies): Likewise.
12633         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12634
12635 2019-01-10  Tom Tromey  <tom@tromey.com>
12636
12637         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12638         PSYMBOL_SET_LANGUAGE.
12639         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12640
12641 2019-01-10  Tom Tromey  <tom@tromey.com>
12642
12643         * psymtab.h (psymtab_storage::obstack): New method.
12644         <m_obstack>: Rename from obstack; now private.
12645         * psymtab.c (psymtab_storage): Update.
12646         * dwarf2read.c (create_addrmap_from_index)
12647         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12648         Update.
12649
12650 2019-01-10  Tom Tromey  <tom@tromey.com>
12651
12652         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12653         * objfiles.h (objfile::reset_psymtabs): New method.
12654
12655 2019-01-10  Tom Tromey  <tom@tromey.com>
12656
12657         * symmisc.c (print_symbol_bcache_statistics): Update.
12658         (print_objfile_statistics): Update.
12659         * symfile.c (reread_symbols): Update.
12660         * psymtab.h (class psymtab_storage): New.
12661         * psymtab.c (psymtab_storage): New constructor.
12662         (~psymtab_storage): New destructor.
12663         (require_partial_symbols): Update.
12664         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12665         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12666         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12667         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12668         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12669         (start_psymtab_common, end_psymtab_common)
12670         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12671         (allocate_psymtab): Update.
12672         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12673         Update.
12674         (dump_psymtab_addrmap, maintenance_print_psymbols)
12675         (maintenance_check_psymtabs): Update.
12676         (class objfile_psymtabs): Move to objfiles.h.
12677         * psympriv.h (discard_psymtab): Now inline.
12678         (psymtab_discarder::psymtab_discarder): Update.
12679         (psymtab_discarder::~psymtab_discarder): Update.
12680         (ALL_OBJFILE_PSYMTABS): Rewrite.
12681         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12682         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12683         Remove fields.
12684         <partial_symtabs>: New field.
12685         (class objfile_psymtabs): Move from psymtab.h.  Update.
12686         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12687         psymbol_cache.
12688         (objfile::~objfile): Don't destroy psymbol_cache.
12689         * mdebugread.c (parse_partial_symbols): Update.
12690         * dwarf2read.c (create_addrmap_from_index)
12691         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12692         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12693         (add_partial_subprogram, dwarf2_ranges_read): Update.
12694         * dwarf-index-write.c (write_address_map)
12695         (write_one_signatured_type, recursively_write_psymbols)
12696         (class debug_names, class debug_names, write_psymtabs_to_index):
12697         Update.
12698
12699 2019-01-10  Tom Tromey  <tom@tromey.com>
12700
12701         * symtab.h (SYMBOL_SET_NAMES): Update.
12702         (symbol_set_names): Update.
12703         (MSYMBOL_SET_NAMES): Update.
12704         * symtab.c (symbol_set_names): Change argument to be an
12705         objfile_per_bfd_storage.
12706         * psymtab.c (add_psymbol_to_bcache): Update.
12707         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12708
12709 2019-01-10  Tom Tromey  <tom@tromey.com>
12710
12711         * symtab.c (create_demangled_names_hash): Change argument to be an
12712         objfile_per_bfd_storage.
12713         (symbol_set_names): Update.
12714
12715 2019-01-10  Tom Tromey  <tom@tromey.com>
12716
12717         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12718         init_psymbol_list.
12719         * psymtab.c (init_psymbol_list): Do nothing if already called.
12720         * psympriv.h (init_psymbol_list): Add comment.
12721         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12722         init_psymbol_list.
12723         * dbxread.c (dbx_symfile_read): Unconditionally call
12724         init_psymbol_list.
12725
12726 2019-01-10  Tom Tromey  <tom@tromey.com>
12727
12728         * xcoffread.c (scan_xcoff_symtab): Update.
12729         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12730         "where".
12731         * mdebugread.c (parse_partial_symbols)
12732         (handle_psymbol_enumerators): Update.
12733         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12734         * dbxread.c (read_dbx_symtab): Update.
12735         * psympriv.h (psymbol_placement): New enum.
12736         (add_psymbol_to_list): Update.
12737
12738 2019-01-10  Tom Tromey  <tom@tromey.com>
12739
12740         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12741         static_psymbols parameters.
12742         (scan_xcoff_symtab): Update.
12743         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12744         static_psymbols parameters.
12745         * psympriv.h (start_psymtab_common): Update.
12746         * mdebugread.c (parse_partial_symbols): Update.
12747         * dwarf2read.c (create_partial_symtab): Update.
12748         * dbxread.c (read_dbx_symtab): Update.
12749         (start_psymtab): Remove global_psymbols and static_psymbols
12750         parameters.
12751
12752 2019-01-10  Tom Tromey  <tom@tromey.com>
12753
12754         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12755         * psymtab.c (allocate_psymtab): Add comment.
12756         * psympriv.h (allocate_psymtab): Add comment.
12757         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12758         initializations.
12759         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12760
12761 2019-01-10  Tom Tromey  <tom@tromey.com>
12762
12763         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12764         Don't declare.
12765         * mipsread.c: Include mdebugread.h.
12766         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12767         Declare.
12768         * elfread.c: Include mdebugread.h.
12769
12770 2019-01-09  Tom Tromey  <tom@tromey.com>
12771
12772         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12773         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12774         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12775         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12776         (psym_lookup_symbol, psym_find_last_source_symtab)
12777         (psym_forget_cached_source_info, psym_print_stats)
12778         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12779         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12780         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12781         (psym_find_compunit_symtab_by_address)
12782         (maintenance_print_psymbols, maintenance_info_psymtabs)
12783         (maintenance_check_psymtabs): Use ranged for.
12784         * psymtab.h (class objfile_psymtabs): New.
12785         (require_partial_symbols): Return objfile_psymtabs.
12786         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12787
12788 2019-01-09  Tom Tromey  <tom@tromey.com>
12789
12790         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12791         (find_pc_mapped_section, list_overlays_command)
12792         (map_overlay_command, unmap_overlay_command)
12793         (simple_overlay_update): Use all_objfiles.
12794         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12795         * printcmd.c (info_symbol_command): Use all_objfiles.
12796         * objfiles.h (ALL_OBJSECTIONS): Remove.
12797         * maint.c (maintenance_translate_address): Use all_objfiles.
12798         * gcore.c (gcore_create_callback): Use all_objfiles.
12799         (objfile_find_memory_regions): Likewise.
12800
12801 2019-01-09  Tom Tromey  <tom@tromey.com>
12802
12803         * symtab.c (find_line_symtab, info_sources_command)
12804         (make_source_files_completion_list): Use objfile_compunits.
12805         * source.c (select_source_symtab): Use objfile_compunits.
12806         * objfiles.h (struct objfile): Update comment.
12807         (ALL_OBJFILES): Remove.
12808         (ALL_FILETABS): Remove.
12809         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12810         objfile_compunits.
12811
12812 2019-01-09  Tom Tromey  <tom@tromey.com>
12813
12814         * symmisc.c (print_objfile_statistics, dump_objfile)
12815         (maintenance_print_symbols): Use compunit_filetabs.
12816         * source.c (forget_cached_source_info_for_objfile): Use
12817         compunit_filetabs.
12818         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12819         (ALL_FILETABS): Use compunit_filetabs.
12820         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12821         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12822
12823 2019-01-09  Tom Tromey  <tom@tromey.com>
12824
12825         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12826         (compunit_filetabs): New.
12827         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12828         compunit_filetabs.
12829         (info_sources_command, make_source_files_completion_list): Remove
12830         declaration.
12831         * symmisc.c (print_objfile_statistics, dump_objfile)
12832         (maintenance_print_symbols): Remove declaration.
12833         (maintenance_info_symtabs): Use compunit_filetabs.
12834         (maintenance_info_line_tables): Likewise.
12835         * source.c (select_source_symtab): Change local variable name.
12836         (forget_cached_source_info_for_objfile): Remove declaration.
12837         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12838         * objfiles.c (objfile_relocate1): Remove declaration.
12839         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12840         declaration.
12841         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12842         * coffread.c (coff_symtab_read): Remove declaration.
12843         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12844         compunit_filetabs.
12845
12846 2019-01-09  Tom Tromey  <tom@tromey.com>
12847
12848         * symtab.c (lookup_objfile_from_block)
12849         (find_pc_sect_compunit_symtab, search_symbols)
12850         (default_collect_symbol_completion_matches_break_on): Use
12851         objfile_compunits.
12852         * objfiles.h (ALL_COMPUNITS): Remove.
12853         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12854         * cp-support.c (add_symbol_overload_list_qualified): Use
12855         objfile_compunits.
12856         * ada-lang.c (ada_collect_symbol_completion_matches)
12857         (ada_add_global_exceptions): Use objfile_compunits.
12858
12859 2019-01-09  Tom Tromey  <tom@tromey.com>
12860
12861         * source.c (select_source_symtab)
12862         (forget_cached_source_info_for_objfile): Remove declaration.
12863         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12864         declaration.
12865         * maint.c (count_symtabs_and_blocks): Remove declaration.
12866         * cp-support.c (add_symbol_overload_list_qualified): Remove
12867         declaration.
12868         * coffread.c (coff_symtab_read): Remove declaration.
12869         * symtab.c (lookup_symbol_in_objfile_symtabs)
12870         (basic_lookup_transparent_type_1): Use objfile_compunits.
12871         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12872         (info_sources_command, search_symbols)
12873         (default_collect_symbol_completion_matches_break_on)
12874         (make_source_files_completion_list): Remove declaration.
12875         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12876         (ada_collect_symbol_completion_matches)
12877         (ada_add_global_exceptions): Remove declaration.
12878         * linespec.c (iterate_over_all_matching_symtabs): Use
12879         objfile_compunits.
12880         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12881         (class objfile_compunits): New.
12882         (ALL_COMPUNITS): Use objfile_compunits.
12883         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12884         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12885         objfile_compunits.
12886         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12887
12888 2019-01-09  Tom Tromey  <tom@tromey.com>
12889
12890         * symtab.c (search_symbols)
12891         (default_collect_symbol_completion_matches_break_on): Use
12892         objfile_msymbols.
12893         * ada-lang.c (ada_lookup_simple_minsym)
12894         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12895         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12896         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12897         objfile_msymbols.
12898         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12899         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12900         * objc-lang.c (find_methods): Use objfile_msymbols.
12901         (info_selectors_command, info_classes_command): Likewise.
12902         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12903         * objfiles.h (class objfile_msymbols): New.
12904         (ALL_OBJFILE_MSYMBOLS): Remove.
12905         (ALL_MSYMBOLS): Remove.
12906
12907 2019-01-09  Tom Tromey  <tom@tromey.com>
12908
12909         * common/next-iterator.h (next_adapter): Add Iterator template
12910         parameter.
12911         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12912         (class all_objfiles_safe): New.
12913         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12914         * objfiles.c (put_objfile_before): Update comment.
12915         (add_separate_debug_objfile): Likewise.
12916         (free_all_objfiles): Use all_objfiles_safe.
12917         (objfile_purge_solibs): Likewise.
12918
12919 2019-01-09  Tom Tromey  <tom@tromey.com>
12920
12921         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12922         (expand_symtab_containing_pc, lookup_static_symbol)
12923         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12924         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12925         all_objfiles.
12926         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12927         * breakpoint.c (create_overlay_event_breakpoint)
12928         (create_longjmp_master_breakpoint)
12929         (create_std_terminate_master_breakpoint)
12930         (create_exception_master_breakpoint): Use all_objfiles.
12931         * linux-thread-db.c (try_thread_db_load_from_pdir)
12932         (has_libpthread): Use all_objfiles.
12933         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12934         * linespec.c (iterate_over_all_matching_symtabs)
12935         (search_minsyms_for_name): Use all_objfiles.
12936         * maint.c (maintenance_info_sections): Use all_objfiles.
12937         * main.c (captured_main_1): Use all_objfiles.
12938         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12939         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12940         * guile/scm-pretty-print.c
12941         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12942         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12943         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12944         (maintenance_print_msymbols): Use all_objfiles.
12945         * source.c (select_source_symtab): Use all_objfiles.
12946         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12947         * symfile.c (remove_symbol_file_command)
12948         (expand_symtabs_matching, map_symbol_filenames): Use
12949         all_objfiles.
12950         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12951         all_objfiles.
12952         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12953         * objc-lang.c (find_methods): Use all_objfiles.
12954         * objfiles.c (have_partial_symbols, have_full_symbols)
12955         (have_minimal_symbols, qsort_cmp)
12956         (default_iterate_over_objfiles_in_search_order): Use
12957         all_objfiles.
12958         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12959         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12960         (maintenance_check_psymtabs): Use all_objfiles.
12961         (ALL_PSYMTABS): Remove.
12962         * compile/compile-object-run.c (do_module_cleanup): Use
12963         all_objfiles.
12964         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12965         * cp-support.c (add_symbol_overload_list_qualified): Use
12966         all_objfiles.
12967         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12968         Use all_objfiles.
12969         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12970         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12971         all_objfiles.
12972         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12973         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12974         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12975         Uses all_objfiles.
12976         * solib.c (solib_read_symbols): Use all_objfiles
12977
12978 2019-01-09  Tom Tromey  <tom@tromey.com>
12979
12980         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12981         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12982         all_objfiles.
12983         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12984         * symmisc.c (print_symbol_bcache_statistics)
12985         (print_objfile_statistics, maintenance_print_objfiles)
12986         (maintenance_info_symtabs, maintenance_check_symtabs)
12987         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12988         all_objfiles.
12989         * source.c (forget_cached_source_info): Use all_objfiles.
12990         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12991         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12992         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12993         * objfiles.c (update_section_map): Use all_objfiles.
12994         (shared_objfile_contains_address_p): Likewise.
12995         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12996         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12997
12998 2019-01-09  Tom Tromey  <tom@tromey.com>
12999
13000         * common/next-iterator.h: New file.
13001         * objfiles.h (class all_objfiles): New.
13002         (struct objfile_iterator): New.
13003
13004 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13005
13006         * NEWS: Move the description of the changed "frame", "select-frame",
13007          and "info frame" commands to the Changed commands section.
13008
13009 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13010
13011         * gdbtypes.c (check_stub_method_group): Remove handling of old
13012         mangling schemes.
13013         * linespec.c (find_methods): Likewise.
13014         * stabsread.c (read_member_functions): Likewise.
13015         * valops.c (search_struct_method): Likewise.
13016         (value_struct_elt_for_reference): Likewise.
13017         * NEWS: Mention this change.
13018
13019 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13020
13021         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13022         print_source_lines.
13023         * source.c (print_source_lines_base): Update line number check.
13024         (print_source_lines): New function.
13025         (source_lines_range::source_lines_range): New function.
13026         * source.h (class source_lines_range): New class.
13027         (print_source_lines): New declaration.
13028
13029 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13030
13031         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13032
13033 2019-01-08  Tom Tromey  <tom@tromey.com>
13034             Simon Marchi  <simon.marchi@ericsson.com>
13035
13036         PR gdb/24060
13037         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13038         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13039         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13040         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13041         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13042         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13043
13044 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13045
13046         * source.c (select_source_symtab): Move header comment to
13047         declaration in source.h.
13048         (forget_cached_source_info_for_objfile): Likewise.
13049         (forget_cached_source_info): Likewise.
13050         (identify_source_line): Likewise.
13051         * source.h (identify_source_line): Move declaration from symtab.h
13052         and add comment from source.c
13053         (print_source_lines): Likewise.
13054         (forget_cached_source_info_for_objfile): Likewise.
13055         (forget_cached_source_info): Likewise.
13056         (select_source_symtab): Likewise.
13057         (enum print_source_lines_flag): Move definition from symtab.h.
13058         * symtab.h (identify_source_line): Move declaration to source.h.
13059         (print_source_lines): Likewise.
13060         (forget_cached_source_info_for_objfile): Likewise.
13061         (forget_cached_source_info): Likewise.
13062         (select_source_symtab): Likewise.
13063         (enum print_source_lines_flag): Move definition to source.h.
13064         * tui/tui-hooks.c: Add 'source.h' include.
13065
13066 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13067
13068         * source.c (print_source_lines_base): Handle requests to print
13069         reverse line number sequences, and guard against empty lines
13070         string.
13071
13072 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13073
13074         * source.c (print_source_lines_base): Fix skip of '\r' if next
13075         character is '\n'.
13076
13077 2019-01-06  Tom Tromey  <tom@tromey.com>
13078
13079         * c-exp.y (struct c_parse_state) <macro_original_text,
13080         expansion_obstack>: New member.
13081         (macro_original_text, expansion_obstack): Remove globals.
13082         (scan_macro_expansion, scanning_macro_expansion)
13083         (finished_macro_expansion): Update.
13084         (scan_macro_cleanup): Remove.
13085         (yylex, c_parse): Update.
13086
13087 2019-01-06  Tom Tromey  <tom@tromey.com>
13088
13089         * c-exp.y (struct c_parse_state) <strings>: New member.
13090         (operator_stoken): Update.
13091
13092 2019-01-06  Tom Tromey  <tom@tromey.com>
13093
13094         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13095         (union type_stack_elt) <typelist_val>: Now a pointer to
13096         std::vector.
13097         (type_stack_cleanup): Don't declare.
13098         (push_typelist): Update.
13099         * parse.c (pop_typelist): Return a std::vector.
13100         (push_typelist): Take a std::vector.
13101         (follow_types): Update.  Do not free args.
13102         (type_stack_cleanup): Remove.
13103         * c-exp.y (struct c_parse_state): New.
13104         (cpstate): New global.
13105         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13106         (nonempty_typelist): Update.
13107         (func_mod): Create a new vector.
13108         (c_parse): Create a c_parse_state.
13109         (check_parameter_typelist): Do not delete params.
13110         (function_method): Update.  Do not delete type_list.
13111
13112 2019-01-06  Tom Tromey  <tom@tromey.com>
13113
13114         PR gdb/28155:
13115         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13116         check_typedef.
13117         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13118         (print_return_value): Likewise.
13119
13120 2019-01-05  Tom Tromey  <tom@tromey.com>
13121
13122         * contrib/cleanup_check.py: Remove.
13123         * contrib/gcc-with-excheck: Remove.
13124         * contrib/exsummary.py: Remove.
13125         * contrib/excheck.py: Remove.
13126
13127 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13128
13129         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13130         NULL. Initialize tpprev to NULL instead of assigning it
13131         to NULL on the next statement.
13132         * windows-nat.c (windows_delete_thread): Remove check for
13133         main_thread_id before printing thread exit notifications.
13134         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13135         Remove thread ID check against main_thread_id.
13136         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13137         windows_delete_thread.
13138         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13139
13140 2019-01-04  Tom Tromey  <tom@tromey.com>
13141
13142         * compile/compile.c (_initialize_compile): Use upper case for
13143         metasyntactic variables.
13144         * symmisc.c (_initialize_symmisc): Use upper case for
13145         metasyntactic variables.
13146         * psymtab.c (_initialize_psymtab): Use upper case for
13147         metasyntactic variables.
13148         * demangle.c (demangle_command): Use upper case for metasyntactic
13149         variables.
13150         (_initialize_demangler): Likewise.
13151         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13152         variables.
13153
13154 2019-01-03  Tom Tromey  <tom@tromey.com>
13155
13156         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13157
13158 2019-01-03  Tom Tromey  <tom@tromey.com>
13159
13160         * python/py-symtab.c (salpy_str): Update.
13161         (struct salpy_sal_object) <symtab>: Now a PyObject.
13162         (salpy_dealloc): Update.
13163         (del_objfile_sal): Use gdbpy_ref.
13164
13165 2019-01-03  Tom Tromey  <tom@tromey.com>
13166
13167         * python/py-type.c (convert_field): Use new_reference.  Return
13168         gdbpy_ref.
13169         (make_fielditem): Return gdbpy_ref.
13170         (typy_fields): Update.
13171         (typy_getitem): Update.
13172         (field_name): Return gdbpy_ref.  Use new_reference.
13173         (typy_iterator_iternext): Update.
13174
13175 2019-01-03  Tom Tromey  <tom@tromey.com>
13176
13177         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13178
13179 2019-01-03  Tom Tromey  <tom@tromey.com>
13180
13181         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13182         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13183         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13184         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13185         (pspy_set_type_printers): Likewise.
13186         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13187         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13188         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13189         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13190         (objfpy_set_type_printers): Likewise.
13191
13192 2019-01-03  Tom Tromey  <tom@tromey.com>
13193
13194         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13195         (gdbpy_print_stack): Use gdbpy_err_fetch.
13196         * python/python-internal.h (class gdbpy_err_fetch): New class.
13197         (class gdbpy_enter) <m_error_type, m_error_value,
13198         m_error_traceback>: Remove.
13199         <m_error>: New member.
13200         (gdbpy_exception_to_string): Don't declare.
13201         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13202         * python/py-value.c (convert_value_from_python): Use
13203         gdbpy_err_fetch.
13204         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13205         gdbpy_exception_to_string.
13206         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13207         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13208         gdbpy_err_fetch.
13209
13210 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13211
13212         * linux-nat.c (delete_lwp_cleanup): Delete.
13213         (struct lwp_deleter): New struct.
13214         (lwp_info_up): New typedef.
13215         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13216         lwp_info_up.
13217
13218 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13219
13220         * linux-fork.c (class scoped_switch_fork_info): New class.
13221         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13222
13223 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13224
13225         * valops.c (find_overload_match): Remove use of null_cleanup, and
13226         calls to do_cleanups.
13227
13228 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13229
13230         * compile/compile-cplus-types.c
13231         (compile_cplus_instance::decl_name): Handle changes to
13232         cp_func_name.
13233         * cp-support.c (cp_func_name): Update header comment, update
13234         return type.
13235         * cp-support.h (cp_func_name): Update return type in declaration.
13236         * valops.c (find_overload_match): Move temp_func local to top
13237         level of function and change its type.  Use temp_func to hold and
13238         delete temporary string obtained from cp_func_name.
13239
13240 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13241
13242         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13243         gdb::char_vector, remove cleanup, and update uses of `msg`.
13244
13245 2019-01-03  Jim Wilson  <jimw@sifive.com>
13246
13247         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13248
13249 2019-01-02  Tom Tromey  <tom@tromey.com>
13250
13251         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13252         (tdesc_parse_xml): Remove cleanups.
13253         * target-descriptions.h (make_cleanup_free_target_description):
13254         Don't declare.
13255         (target_desc_deleter): New struct.
13256         (target_desc_up): New typedef.
13257         * target-descriptions.c (target_desc_deleter::operator()): Rename
13258         from free_target_description.
13259         (make_cleanup_free_target_description): Remove.
13260
13261 2019-01-02  Tom Tromey  <tom@tromey.com>
13262
13263         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13264         constructor, destructor.
13265         (linespec_parser): Remove typedef.
13266         (~linespec_parser): Rename from linespec_parser_delete.
13267         (linespec_lex_to_end, linespec_complete_label)
13268         (linespec_complete): Update.
13269         (decode_line_full): Remove cleanups.
13270         (decode_line_1): Update.
13271
13272 2019-01-02  Tom Tromey  <tom@tromey.com>
13273
13274         * python/python-internal.h (inferior_to_inferior_object): Change
13275         return type.
13276         * python/py-exitedevent.c (create_exited_event_object): Update.
13277         * python/py-inferior.c (inferior_to_inferior_object): Return
13278         gdbpy_ref.
13279         (python_new_inferior, python_inferior_deleted)
13280         (thread_to_thread_object, delete_thread_object)
13281         (build_inferior_list, gdbpy_selected_inferior): Update.
13282         * python/py-infthread.c (create_thread_object): Update.  Also fail
13283         if inferior_to_inferior_object fails.
13284
13285 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13286
13287         * inferior.h (class inferior) <displaced_step_state>: New field.
13288         * infrun.h (struct displaced_step_state): Move here from
13289         infrun.c.  Initialize fields, add constructor.
13290         <inf>: Remove field.
13291         <reset>: New method.
13292         * infrun.c (struct displaced_step_inferior_state): Move to
13293         infrun.h.
13294         (displaced_step_inferior_states): Remove.
13295         (get_displaced_stepping_state): Adust.
13296         (displaced_step_in_progress_any_inferior): Adjust.
13297         (displaced_step_in_progress_thread): Adjust.
13298         (displaced_step_in_progress): Adjust.
13299         (add_displaced_stepping_state): Remove.
13300         (get_displaced_step_closure_by_addr): Adjust.
13301         (remove_displaced_stepping_state): Remove.
13302         (infrun_inferior_exit): Call displaced_step_state.reset.
13303         (use_displaced_stepping): Don't check for NULL.
13304         (displaced_step_prepare_throw): Call
13305         get_displaced_stepping_state.
13306         (displaced_step_fixup): Don't check for NULL.
13307         (prepare_for_detach): Don't check for NULL.
13308
13309 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13310
13311         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13312          in case of call that did not complete.
13313
13314 2019-01-02  Andrey Utkin  <autkin@undo.io>
13315
13316         * symfile.c (find_separate_debug_file): Fix search of debug files for
13317         remote debuggee.
13318
13319 2019-01-02  Tom Tromey  <tom@tromey.com>
13320
13321         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13322         indentation.
13323         * python/py-frame.c (frapy_older): Remove cast.
13324         (frapy_newer): Likewise.
13325         * python/py-breakpoint.c (local_setattro): Remove cast.
13326         * python/py-arch.c (archpy_name): Remove local variable.
13327         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13328
13329 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13330
13331         * unittests/basic_string_view/element_access/char/empty.cc:
13332         Fix year range in copyright header.
13333
13334 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13335
13336         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13337         Delete.
13338         <operator==>: Update with for removed field.
13339         <hash>: Likewise.
13340         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13341         <isa_features>: ...this.
13342         <abi_features>: New field.
13343         (riscv_isa_flen): Update comment.
13344         (riscv_abi_xlen): New declaration.
13345         (riscv_abi_flen): New declaration.
13346         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13347         isa_features.
13348         (riscv_abi_xlen): New function.
13349         (riscv_isa_flen): Update to get answer from isa_features.
13350         (riscv_abi_flen): New function.
13351         (riscv_has_fp_abi): Update to get answer from abi_features.
13352         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13353         xlen and flen.
13354         (riscv_call_info) <xlen, flen>: Update comment.
13355         (riscv_call_arg_struct): Remove invalid assertions
13356         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13357         is removed.
13358         (riscv_gdbarch_init): Gather isa features and abi features
13359         separately, ensure both match on the gdbarch when reusing an old
13360         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13361         a target with 64-bit float hardware.
13362
13363 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13364
13365         * source.c (search_command_helper): Stop reverse search
13366         when line 1 has been searched.
13367
13368 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13369
13370         * record-full.c (record_full_base_target::close): Rewrite
13371         record_full_core_buf_list free logic.
13372
13373 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13374
13375         * break-catch-syscall.c (print_one_catch_syscall): xfree
13376         the last text.
13377
13378 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13379
13380         * top.c (print_gdb_version): Update Copyright year in version
13381         message.
13382
13383 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13384
13385         Update copyright year range in all GDB files.
13386
13387 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13388
13389         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13390
13391 For older changes see ChangeLog-2018.
13392 \f
13393 Local Variables:
13394 mode: change-log
13395 left-margin: 8
13396 fill-column: 74
13397 version-control: never
13398 coding: utf-8
13399 End:
13400