gdb/ChangeLog

   1 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * Makefile.in: Remove references to vec.h and vec.c.
   4         * aarch64-tdep.c: No longer include vec.h.
   5         * ada-lang.c: Likewise.
   6         * ada-lang.h: Likewise.
   7         * arm-tdep.c: Likewise.
   8         * ax.h: Likewise.
   9         * breakpoint.h: Likewise.
  10         * charset.c: Likewise.
  11         * cp-support.h: Likewise.
  12         * dtrace-probe.c: Likewise.
  13         * dwarf2read.c: Likewise.
  14         * extension.h: Likewise.
  15         * gdb_bfd.c: Likewise.
  16         * gdbsupport/gdb_vecs.h: Likewise.
  17         * gdbsupport/vec.c: Remove.
  18         * gdbsupport/vec.h: Remove.
  19         * gdbthread.h: Likewise.
  20         * guile/scm-type.c: Likewise.
  21         * inline-frame.c: Likewise.
  22         * machoread.c: Likewise.
  23         * memattr.c: Likewise.
  24         * memrange.h: Likewise.
  25         * namespace.h: Likewise.
  26         * nat/linux-btrace.h: Likewise.
  27         * osdata.c: Likewise.
  28         * parser-defs.h: Likewise.
  29         * progspace.h: Likewise.
  30         * python/py-type.c: Likewise.
  31         * record-btrace.c: Likewise.
  32         * rust-exp.y: Likewise.
  33         * solib-target.c: Likewise.
  34         * stap-probe.c: Likewise.
  35         * target-descriptions.c: Likewise.
  36         * target-memory.c: Likewise.
  37         * target.h: Likewise.
  38         * varobj.c: Likewise.
  39         * varobj.h: Likewise.
  40         * xml-support.h: Likewise.
  41
  42 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
  43
  44         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
  45         Update for new std::vector based implementation.
  46         (process_psymtab_comp_unit_reader): Likewise.
  47         (scan_partial_symbols): Likewise.
  48         (recursively_compute_inclusions): Likewise.
  49         (compute_compunit_symtab_includes): Likewise.
  50         (process_imported_unit_die): Likewise.
  51         (queue_and_load_dwo_tu): Likewise.
  52         (follow_die_sig_1): Likewise.
  53         * gdb/dwarf2read.h: Remove DEF_VEC_P.
  54         (typedef dwarf2_per_cu_ptr): Remove.
  55         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
  56         function.
  57         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
  58         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
  59         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
  60         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
  61         std::vector.
  62
  63 2019-10-15  Tom Tromey  <tromey@adacore.com>
  64
  65         * windows-nat.c (windows_nat_target::resume): Use %x when logging
  66         TID.
  67
  68 2019-10-15  Tom Tromey  <tromey@adacore.com>
  69
  70         * windows-nat.c (windows_nat_target::fetch_registers)
  71         (windows_nat_target::store_registers): Rename "pid" to "tid".
  72
  73 2019-10-15  Tom Tromey  <tromey@adacore.com>
  74
  75         * gdbarch.h, gdbarch.c: Rebuild.
  76         * gdbarch.sh (gcc_target_options): Change return type to
  77         std::string.
  78         * compile/compile.c (get_args): Update.
  79         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
  80         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
  81         std::string.
  82         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
  83         std::string.
  84         * arch-utils.c (default_gcc_target_options): Return std::string.
  85         * arch-utils.h (default_gcc_target_options): Return std::string.
  86         * s390-tdep.c (s390_gcc_target_options): Return std::string.
  87
  88 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
  89
  90         * breakpoint.c (breakpoint_chain): Make static.
  91         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
  92         of accessing breakpoint_chain.
  93
  94 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
  95
  96         * breakpoint.c (iterate_over_breakpoints): Change function pointer
  97         to a gdb::function_view and return value to bool.
  98         * breakpoint.h (iterate_over_breakpoints): Likewise.
  99         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 100         (pop_dummy_frame): Update.
 101         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 102         (gdbscm_breakpoints): Update.
 103         * python/py-breakpoint.c (build_bp_list): Update.
 104         (gdbpy_breakpoints): Update.
 105         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 106         Update.
 107         (bpfinishpy_handle_stop): Update.
 108         (bpfinishpy_handle_exit): Update.
 109         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 110         (svr4_update_solib_event_breakpoints): Update.
 111
 112 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 113
 114         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 115         when unwrapping single-field structs.
 116
 117 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 118
 119         * dwarf2read.c: Remove includes.
 120
 121 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 122
 123         * ui-out.c (ui_out::call_do_message): Silence
 124         -Wformat-nonliteral warning.
 125
 126 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 127
 128         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 129         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 130         include: readline/tilde.h.
 131
 132 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 133
 134         * remote.c (remote_target::get_trace_status): Remove declaration of
 135         trace_regblock_size.
 136
 137 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 138
 139         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 140         (show_user): Remove declaration of cmdlist.
 141         * cli/cli-cmds.h (max_user_call_depth): Declare.
 142         * cli/cli-script.c (execute_user_command): Remove declaration
 143         of max_user_call_depth.
 144
 145 2019-10-11  Jim Wilson  <jimw@sifive.com>
 146
 147         * gdbsupport/print-utils.h (pulongest): Fix comment.
 148         (plongest): Likewise.
 149         (phex): Add missing comment, mention leading zeros.
 150         (phex_nz): Add mention of no leading zeros to comment.
 151
 152         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 153         plongest instead of unsigned long long cast.
 154
 155 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 156
 157         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 158         for external_editor_command and gdbtk_test.
 159
 160 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 161
 162         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 163         * varobj.c (varobjdebug): Move comment to...
 164         * varobj.h (varobjdebug): ...here, and declare.
 165
 166 2019-10-09  Tom Tromey  <tom@tromey.com>
 167
 168         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 169         erase_data_content.
 170
 171 2019-10-09  Tom Tromey  <tom@tromey.com>
 172
 173         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 174         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 175         * tui/tui-command.c (tui_cmd_window::resize)
 176         (tui_refresh_cmd_win): Update.
 177         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 178         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 179         * tui/tui-data.c (~tui_gen_win_info): Remove.
 180         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 181         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 182         (tui_redisplay_readline, tui_mld_flush)
 183         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 184         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 185         (tui_data_window::erase_data_content)
 186         (tui_data_item_window::rerender)
 187         (tui_data_item_window::refresh_window): Update.
 188         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 189         (box_win, tui_gen_win_info::make_window)
 190         (tui_gen_win_info::make_visible): Update.
 191         (tui_delete_win): Remove.
 192         * tui/tui-winsource.c
 193         (tui_source_window_base::do_erase_source_content): Update.
 194         (tui_show_source_line, tui_source_window_base::update_tab_width)
 195         (tui_source_window_base::update_exec_info): Update.
 196         * tui/tui-data.h (struct curses_deleter): New.
 197         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 198         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 199
 200 2019-10-09  Tom Tromey  <tom@tromey.com>
 201
 202         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 203
 204 2019-10-09  Tom Tromey  <tom@tromey.com>
 205
 206         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 207         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 208
 209 2019-10-09  Tom Tromey  <tom@tromey.com>
 210
 211         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 212         window height directly.
 213         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 214         declare.
 215         * tui/tui-layout.c (tui_default_win_height): Remove.
 216         (tui_default_win_viewport_height): Remove.
 217
 218 2019-10-09  Tom Tromey  <tom@tromey.com>
 219
 220         * tui/tui.h: Remove comments.
 221
 222 2019-10-09  Tom de Vries  <tdevries@suse.de>
 223
 224         * python/lib/gdb/printer/bound_registers.py: Use
 225         '^builtin_type_bound128' as regexp argument for
 226         add_builtin_pretty_printer.
 227
 228 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 229
 230         * guile/guile.c (guile_extension_script_ops): Remove forward
 231         declaration and mark as static.
 232         (guile_script_ops): Likewise.
 233         (extension_language_guile): Move further down in the file so
 234         it can reference the definitions for guile_{extension_,}script_ops.
 235
 236 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 237
 238         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 239         except SORTL, DFLTCC, and KDSA.
 240
 241 2019-10-08  Tom Tromey  <tromey@adacore.com>
 242
 243         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 244         (struct safe_symbol_file_add_args): Remove.
 245
 246 2019-10-08  Tom Tromey  <tromey@adacore.com>
 247
 248         * windows-nat.c: Don't include buildsym-legacy.h.
 249
 250 2019-10-08  Tom Tromey  <tromey@adacore.com>
 251
 252         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 253
 254 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 255
 256         * gdbtypes.c (overload_debug): Move comment to header.
 257         * gdbtypes.h (overload_debug): Declare.
 258         * valops.c: Remove declaration of overload_debug, instead
 259         include gdbtypes.h.
 260
 261 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 262
 263         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 264         through _().
 265         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 266         move comment...
 267         * language.h (lang_frame_mismatch_warn): ... here. Also add
 268         declaration.
 269         * top.c (lang_frame_mismatch_warn): Remove declaration.
 270         (check_frame_language_change): Pass lang_frame_mismatch_warn
 271         through _().
 272
 273 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 274
 275         * c-lang.h (vtbl_ptr_name): Declare.
 276         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 277         it from the header.
 278         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 279
 280 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 281
 282         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 283         gdb_static_assert.
 284
 285 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 286
 287         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 288         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 289         * ctfread.c: New file.
 290         * ctfread.h: New file.
 291         * elfread.c: Include ctfread.h.
 292         (struct elfinfo text_p): New member ctfsect.
 293         (elf_locate_sections): Mark CTF section.
 294         (elf_symfile_read): Call elfctf_build_psymtabs.
 295         * Makefile.in (LIBCTF): Add.
 296         (CLIBS): Use it.
 297         (CDEPS): Likewise.
 298         (DIST): Add ctfread.c.
 299
 300 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 301
 302         * ctfread.c (struct nextfield): Renamed to ...
 303         (struct ctf_nextfield): ... this.
 304         (struct field_info): Renamed to ...
 305         (strut ctf_field_info): ... this.
 306         (attach_fields_to_type): Update for renamed structures.
 307         (ctf_add_member_cb): Likewise.
 308         (ctf_add_enum_member_cb): Likewise.
 309         (process_struct_members): Likewise.
 310         (process_enum_type): Likewise.
 311
 312 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 313
 314         * tracectf.h: Rename, was ctf.h.
 315         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 316         * tracefile.c: Likewise.
 317         * tracepoint.c: Remove unused include ctf.h.
 318         * mi/mi-main.c: Likewise.
 319         * Makefile.in Replace ctf.c with tracectf.c.
 320
 321 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 322
 323         * version.in: Change version number to "9.0.50.DATE-git".
 324
 325 2019-10-03  Tom Tromey  <tom@tromey.com>
 326
 327         PR rust/24976:
 328         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 329
 330 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 331
 332         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 333         cp_search_name_hash.
 334         * NEWS: Add entry about nested function support.
 335
 336 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 337             Andrew Burgess  <andrew.burgess@embecosm.com>
 338
 339         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 340         for nested static variables when searchin VAR_DOMAIN.
 341         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 342         global scope, update comment.
 343         (add_partial_subprogram): Call add_partial_subprogram recursively
 344         for nested subroutines when processinng Fortran.
 345         (load_partial_dies): Process the child entities of a subprogram
 346         when processing Fortran.
 347         (partial_die_parent_scope): Handle building scope
 348         for Fortran nested functions.
 349         (process_die): Record that nested functions have a scope.
 350         (new_symbol): Always record Fortran subprograms on the global
 351         symbol list.
 352         (determine_prefix): How to build the prefix for Fortran
 353         subprograms.
 354
 355 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 356
 357         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 358         have just sent the thread a SIGSTOP and are waiting for it to
 359         arrive.
 360
 361 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 362
 363         * btrace.c (btrace_add_pc): Remove whitespace before the template
 364         parameter in 'std::vector <...>'.
 365         (parse_xml_btrace_block): Likewise.
 366         (btrace_maint_decode_pt): Likewise.
 367         (btrace_maint_update_packets): Likewise.
 368         (btrace_maint_print_packets): Likewise.
 369         * btrace.h (struct btrace_maint_info): Likewise.
 370         * dwarf2read.c (struct type_unit_group): Likewise.
 371         (build_type_psymtabs_reader): Likewise.
 372         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 373         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 374         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 375
 376 2019-10-03  Tom de Vries  <tdevries@suse.de>
 377
 378         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 379         the first line of the help text for set/show style metadata.
 380
 381 2019-10-02  Tom Tromey  <tromey@adacore.com>
 382
 383         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 384         * gdbsupport/common-inferior.c: New file.
 385         * infcmd.c (startup_with_shell): Don't define.
 386         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 387         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 388         * inferior.h (startup_with_shell): Don't declare.
 389
 390 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 391
 392         * gdbsupport/gdb_assert.h: Include errors.h.
 393         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 394
 395 2019-10-02  Tom Tromey  <tromey@adacore.com>
 396
 397         * NEWS: Add $_ada_exception entry.
 398         * ada-lang.c (struct ada_catchpoint): Add constructor.
 399         <m_kind>: New member.
 400         (allocate_location_exception, re_set_exception): Remove
 401         "ex" parameter.
 402         (should_stop_exception): Compute $_ada_exception.
 403         (check_status_exception, print_it_exception)
 404         (print_one_exception, print_mention_exception): Remove
 405         "ex" parameter.
 406         (allocate_location_catch_exception, re_set_catch_exception)
 407         (check_status_exception, print_it_catch_exception)
 408         (print_one_catch_exception, print_mention_catch_exception)
 409         (print_recreate_catch_exception)
 410         (allocate_location_catch_exception_unhandled)
 411         (re_set_catch_exception_unhandled)
 412         (check_status_exception, print_it_catch_exception_unhandled)
 413         (print_one_catch_exception_unhandled)
 414         (print_mention_catch_exception_unhandled)
 415         (print_recreate_catch_exception_unhandled)
 416         (allocate_location_catch_assert, re_set_catch_assert)
 417         (check_status_assert, print_it_catch_assert)
 418         (print_one_catch_assert, print_mention_catch_assert)
 419         (print_recreate_catch_assert)
 420         (allocate_location_catch_handlers, re_set_catch_handlers)
 421         (check_status_handlers, print_it_catch_handlers)
 422         (print_one_catch_handlers, print_mention_catch_handlers)
 423         (print_recreate_catch_handlers): Remove.
 424         (create_ada_exception_catchpoint): Update.
 425         (initialize_ada_catchpoint_ops): Update.
 426
 427 2019-10-02  Tom Tromey  <tromey@adacore.com>
 428
 429         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 430         (create_excep_cond_exprs): Simplify exception string computation.
 431         (ada_exception_catchpoint_cond_string): Likewise.
 432
 433 2019-10-02  Tom Tromey  <tromey@adacore.com>
 434
 435         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 436         * ada-lang.c (lesseq_defined_than): Handle
 437         LOC_STATIC.
 438         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 439         parameter.
 440         (dwarf2_has_info): Likewise.
 441         (new_symbol): Set maybe_copied on symbol when
 442         appropriate.
 443         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 444         parameter.
 445         <can_copy>: New member.
 446         * elfread.c (record_minimal_symbol): Set maybe_copied
 447         on symbol when appropriate.
 448         (elf_symfile_read): Update call to dwarf2_has_info.
 449         * minsyms.c (lookup_minimal_symbol_linkage): New
 450         function.
 451         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 452         * symtab.c (get_symbol_address, get_msymbol_address):
 453         New functions.
 454         * symtab.h (get_symbol_address, get_msymbol_address):
 455         Declare.
 456         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 457         maybe_copied.
 458         (struct symbol, struct minimal_symbol) <maybe_copied>:
 459         New member.
 460
 461 2019-10-02  Tom Tromey  <tromey@adacore.com>
 462
 463         * source.c (struct current_source_location): New.
 464         (current_source_key): New global.
 465         (current_source_symtab, current_source_line)
 466         (current_source_pspace): Remove.
 467         (get_source_location): New function.
 468         (get_current_source_symtab_and_line)
 469         (set_default_source_symtab_and_line)
 470         (set_current_source_symtab_and_line)
 471         (clear_current_source_symtab_and_line, select_source_symtab)
 472         (info_source_command, print_source_lines_base)
 473         (info_line_command, search_command_helper, _initialize_source):
 474         Update.
 475
 476 2019-10-02  Tom Tromey  <tromey@adacore.com>
 477
 478         * source.c (select_source_symtab): Don't call
 479         decode_line_with_current_source.
 480
 481 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 482
 483         * symtab.c (lookup_global_symbol): Search global block.
 484
 485 2019-10-02  Tom Tromey  <tromey@adacore.com>
 486
 487         * coffread.c (process_coff_symbol): Update.
 488         * dwarf2read.c (var_decode_location, new_symbol): Update.
 489         * mdebugread.c (parse_symbol): Update.
 490         * objfiles.c (relocate_one_symbol): Update.
 491         * stabsread.c (define_symbol, fix_common_block)
 492         (scan_file_globals): Update.
 493         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 494         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 495         * xcoffread.c (process_xcoff_symbol): Update.
 496
 497 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 498
 499         * MAINTAINERS: Update my email address.
 500
 501 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 502
 503         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 504         std::vector.
 505         (build_type_psymtabs_reader): Update for std::vector.
 506         (build_type_psymtab_dependencies): Likewise.
 507         * dwarf2read.h: Remove use of DEF_VEC_P.
 508         (typedef sig_type_ptr): Delete.
 509
 510 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 511
 512         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 513         to std::vector.
 514         (btrace_maint_decode_pt): Likewise, and move allocation of the
 515         vector outside of the loop.
 516         (btrace_maint_update_packets): Update to handle change from VEC to
 517         std::vector.
 518         (btrace_maint_print_packets): Likewise.
 519         (maint_info_btrace_cmd): Likewise.
 520         * btrace.h: Remove use of DEF_VEC_O.
 521         (typedef btrace_pt_packet_s): Delete.
 522         (struct btrace_maint_info) <packets>: Change fromm VEC to
 523         std::vector.
 524         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 525
 526 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 527
 528         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 529         make accesses into the vector constant references.
 530         (btrace_add_pc): Update for std::vector.
 531         (btrace_stitch_bts): Likewise.
 532         (parse_xml_btrace_block): Likewise.
 533         (btrace_maint_update_packets): Likewise.
 534         (btrace_maint_print_packets): Likewise.
 535         (maint_info_btrace_cmd): Likewise.
 536         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 537         std::vector.
 538         (btrace_data::empty): Likewise.
 539         (btrace_data_append): Likewise.
 540         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 541         (typedef btrace_block_s): Delete.
 542         (struct btrace_block): Add constructor.
 543         (struct btrace_data_bts) <blocks>: Change to std::vector.
 544         * nat/linux-btrace.c (perf_event_read_bts): Update for
 545         std::vector.
 546         (linux_read_bts): Likewise.
 547
 548 2019-10-01  Tom Tromey  <tom@tromey.com>
 549
 550         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 551
 552 2019-10-01  Tom Tromey  <tom@tromey.com>
 553
 554         * stack.c (print_frame, info_frame_command_core): Use
 555         styled_string.
 556         * linux-thread-db.c (try_thread_db_load_1)
 557         (try_thread_db_load_from_pdir_1): Use styled_string.
 558         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 559         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 560         (maybe_print_unsupported_script_warning)
 561         (maybe_print_script_not_found_warning): Use styled_string.
 562         * ada-lang.c (user_select_syms): Use styled_string.
 563
 564 2019-10-01  Tom Tromey  <tom@tromey.com>
 565
 566         * p-lang.c (pascal_printstr): Use metadata style.
 567         * value.c (show_convenience): Use metadata style.
 568         * valprint.c (valprint_check_validity, val_print_optimized_out)
 569         (val_print_not_saved, val_print_unavailable)
 570         (val_print_invalid_address, generic_val_print, val_print)
 571         (value_check_printable, val_print_array_elements): Use metadata
 572         style.
 573         * ui-out.h (class ui_out) <field_fmt>: New overload.
 574         <do_field_fmt>: Add style parameter.
 575         * ui-out.c (ui_out::field_fmt): New overload.
 576         * typeprint.c (type_print_unknown_return_type)
 577         (val_print_not_allocated, val_print_not_associated): Use metadata
 578         style.
 579         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 580         parameter.
 581         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 582         * tracepoint.c (tvariables_info_1): Use metadata style.
 583         * stack.c (print_frame_arg, print_frame_info, print_frame)
 584         (info_frame_command_core): Use metadata style.
 585         * skip.c (info_skip_command): Use metadata style.
 586         * rust-lang.c (rust_print_enum): Use metadata style.
 587         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 588         metadata style.
 589         * python/py-framefilter.c (py_print_single_arg): Use metadata
 590         style.
 591         * printcmd.c (do_one_display, print_variable_and_value): Use
 592         metadata style.
 593         * p-valprint.c (pascal_val_print)
 594         (pascal_object_print_value_fields): Use metadata style.
 595         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 596         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 597         parameter.
 598         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 599         * m2-valprint.c (m2_print_long_set): Use metadata style.
 600         * m2-typeprint.c (m2_print_type): Use metadata style.
 601         * infcmd.c (print_return_value_1): Use metadata style.
 602         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 603         * f-valprint.c (info_common_command_for_block): Use metadata
 604         style.
 605         * f-typeprint.c (f_type_print_base): Use metadata style.
 606         * expprint.c (print_subexp_standard): Use metadata style.
 607         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 608         * cli/cli-style.h (class cli_style_option): Add constructor.
 609         (metadata_style): Declare.
 610         * cli/cli-style.c (metadata_style): New global.
 611         (_initialize_cli_style): Register metadata style.
 612         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 613         parameter.
 614         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 615         * c-typeprint.c (c_type_print_base_struct_union)
 616         (c_type_print_base_1): Use metadata style.
 617         * breakpoint.c (watchpoint_value_print)
 618         (print_one_breakpoint_location): Use metadata style.
 619         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 620         style.
 621         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 622         style.
 623         * ada-valprint.c (val_print_packed_array_elements, printstr)
 624         (print_field_values, ada_val_print_ref, ada_val_print): Use
 625         metadata style.
 626         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 627         style.
 628         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 629         style.
 630         * ada-lang.c (user_select_syms): Use metadata style.
 631
 632 2019-10-01  Tom Tromey  <tom@tromey.com>
 633
 634         * cli/cli-cmds.c (pwd_command): Style output.
 635
 636 2019-10-01  Pedro Alves  <palves@redhat.com>
 637             Tom Tromey  <tom@tromey.com>
 638
 639         * symtab.c (print_symbol_info): Use %ps.
 640         (print_msymbol_info): Use %ps.
 641         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 642         * printcmd.c (print_variable_and_value): Use %ps.
 643         * macrocmd.c (show_pp_source_pos): Use %ps.
 644         * infrun.c (print_exited_reason): Use ui_out::message.
 645         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 646         (describe_other_breakpoints): Use ui_out::message and new
 647         formats.
 648         (say_where): Use new formats.
 649         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 650         and new formats.
 651
 652 2019-10-01  Pedro Alves  <palves@redhat.com>
 653             Tom Tromey  <tom@tromey.com>
 654
 655         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 656         (test_gdb_formats): New function.
 657         (run_tests): Call it.
 658         (test_format_specifier): Update.
 659         * utils.h (fputs_filtered): Update comment.
 660         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 661         (fputs_styled_unfiltered): Declare.
 662         * utils.c (fputs_styled_unfiltered): New function.
 663         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 664         (vfprintf_filtered): Update.
 665         (vfprintf_unfiltered, vprintf_filtered): Update.
 666         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 667         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 668         disallow_ui_out_field>: New constants.
 669         (enum class field_kind): New.
 670         (struct base_field_s, struct signed_field_s): New.
 671         (signed_field): New function.
 672         (struct string_field_s): New.
 673         (string_field): New function.
 674         (struct styled_string_s): New.
 675         (styled_string): New function.
 676         (class ui_out) <message>: Add comment.
 677         <vmessage, call_do_message>: New methods.
 678         <do_message>: Add style parameter.
 679         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 680         methods.
 681         (ui_out::message): Rewrite.
 682         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 683         parameter.
 684         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 685         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 686         gdb_extensions parameter.
 687         (class format_piece): Add parameter to constructor.
 688         (n_int_args): New field.
 689         * gdbsupport/format.c (format_pieces::format_pieces): Add
 690         gdb_extensions parameter.  Handle '*'.
 691         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 692         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 693         vfprintf_styled_no_gdbfmt.
 694         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 695         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 696         unfiltered output.
 697         * ui-style.h (struct ui_file_style) <ptr>: New method.
 698
 699 2019-10-01  Tom Tromey  <tom@tromey.com>
 700
 701         * unittests/format_pieces-selftests.c: Update.  Add final format.
 702         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 703         empty literal pieces.
 704
 705 2019-10-01  Tom Tromey  <tom@tromey.com>
 706
 707         * ui-out.h (enum class ui_out_style_kind): Remove.
 708         (class ui_out) <field_string, field_stsream, do_field_string>:
 709         Change type of "style".
 710         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 711         (ui_out::field_string): Update.
 712         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 713         of "style".
 714         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 715         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 716         * stack.c (print_frame_arg, print_frame_info, print_frame):
 717         Update.
 718         * source.c (print_source_lines_base): Update.
 719         * solib.c (info_sharedlibrary_command): Update.
 720         * skip.c (info_skip_command): Update.
 721         * record-btrace.c (btrace_call_history_src_line)
 722         (btrace_call_history): Update.
 723         * python/py-framefilter.c (py_print_frame): Update.
 724         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 725         "style".
 726         * mi/mi-out.c (mi_ui_out::do_table_header)
 727         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 728         (mi_ui_out::do_field_string): Update.
 729         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 730         Update.
 731         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 732         "style".
 733         * cli-out.c (cli_ui_out::do_table_header)
 734         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 735         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 736         (cli_ui_out::do_field_fmt): Update.
 737         * breakpoint.c (print_breakpoint_location): Update.
 738         (update_static_tracepoint): Update.
 739
 740 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 741
 742         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 743         conversion of gdb_datadir.
 744         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 745         remove not needed c_str ().
 746
 747 2019-09-30  Ali Tamur <tamur@google.com>
 748
 749         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 750         (dwarf2_string_attr): Likewise.
 751
 752 2019-09-30  Ali Tamur <tamur@google.com>
 753
 754         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 755         (process_full_type_unit): Likewise.
 756         (dump_die_shallow): Likewise.
 757         (cu_debug_loc_section): Likewise.
 758
 759 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 760
 761         * minsyms.c (compare_minimal_symbols): Rename to...
 762         (minimal_symbol_is_less_than): ...this, and adjust to STL
 763         conventions (return bool, take arguments as references)
 764         (minimal_symbol_reader::install): Call std::sort instead
 765         of qsort.
 766
 767 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 768
 769         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 770         hash and why.
 771         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 772         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 773
 774 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 775
 776         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 777         * psympriv.h (add_psymbol_to_list): Move comment here and update
 778         it.
 779
 780 2019-09-29  Tom de Vries  <tdevries@suse.de>
 781
 782         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 783         Use $tmpdir/$(basename "$output_file").dwz instead of
 784         "${output_file}.dwz".
 785
 786 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 787
 788         PR gdb/25045
 789         * hppa-linux-nat.c: Include gdbarch.h.
 790
 791 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 792
 793         * blockframe.c (find_pc_partial_function): Change return type to bool.
 794         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 795         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 796         (stub_gnu_ifunc_resolve_name): Likewise.
 797         * symtab.c (compare_filenames_for_search): Likewise.
 798         (compare_glob_filenames_for_search): Likewise.
 799         (matching_obj_sections): Likewise.
 800         (symbol_matches_domain): Likewise.
 801         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 802         (find_line_pc): Change return type to bool.
 803         (find_line_pc_range): Likewise.
 804         (producer_is_realview): Likewise.
 805         * symtab.h (symbol_matches_domain): Likewise.
 806         (find_pc_partial_function): Likewise.
 807         (find_pc_line_pc_range): Likewise.
 808         (in_gnu_ifunc_stub): Likewise.
 809         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 810         (find_line_pc): Likewise.
 811         (find_line_pc_range): Likewise.
 812         (matching_obj_sections): Likewise.
 813         (find_line_symtab): Change out parameter to bool.
 814         (producer_is_realview): Change return type to bool.
 815         (compare_filenames_for_search): Likewise.
 816         (compare_glob_filenames_for_search): Likewise.
 817
 818 2019-09-26  Tom Tromey  <tom@tromey.com>
 819
 820         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 821         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 822         * gdb_usleep.h: Remove.
 823         * gdb_usleep.c: Remove.
 824         * utils.c: Don't include gdb_usleep.h.
 825
 826 2019-09-26  Tom Tromey  <tromey@adacore.com>
 827
 828         * python/py-type.c (type_to_type_object): Call check_typedef
 829         for stub types.
 830
 831 2019-09-26  Tom Tromey  <tom@tromey.com>
 832
 833         * utils.h (initialize_utils): Don't declare.
 834         * top.c (gdb_init): Don't call initialize_utils.
 835         * utils.c (initialize_utils): Remove.  Move contents...
 836         (_initialize_utils): ... here.
 837
 838 2019-09-25  Tom Tromey  <tom@tromey.com>
 839
 840         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 841         * utils.h (make_hex_string): Don't declare.
 842         * utils.c (make_hex_string): Remove.
 843
 844 2019-09-24  Tom de Vries  <tdevries@suse.de>
 845
 846         PR gdb/23815
 847         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 848         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 849
 850 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 851
 852         * NEWS: Mention new simulator port for PRU.
 853
 854 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 855
 856         * ada-exp.y (write_object_remaining): Update.
 857         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 858         and eliminate the static buffer.
 859         (ada_decode_symbol): Update.
 860         (ada_la_decode): Update.
 861         (ada_sniff_from_mangled_name): Update.
 862         (is_valid_name_for_wild_match): Update.
 863         (ada_lookup_name_info::matches): Update and simplify.
 864         (name_matches_regex): Update.
 865         (ada_add_global_exceptions): Update.
 866         * ada-lang.h (ada_decode): Update signature.
 867         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 868         * dwarf-index-write.c (debug_names::insert): Update.
 869
 870 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 871
 872         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 873         formatting.
 874
 875 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 876
 877         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 878         Change "nonzero" to "true" in documentation.
 879
 880 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 881
 882         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 883         (_initialize_darwin_solib): Don't set
 884         darwin_so_ops.lookup_lib_global_symbol.
 885         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 886         set_gdbarch_iterate_over_objfiles_in_search_order.
 887         (elf_lookup_lib_symbol): Rename to...
 888         (svr4_iterate_over_objfiles_in_search_order): this, and update
 889         to iterate semantics.
 890         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 891         * solib.c (solib_global_lookup): Remove.
 892         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 893         (solib_global_lookup): Remove.
 894         * symtab.c (lookup_global_or_static_symbol): Remove call to
 895         solib_global_lookup.
 896
 897 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 898
 899         * NEWS: Move entries about default MI version now being
 900         version 3, and about the GDB/MI fix for multi-location
 901         breakpoints to the "since GDB 8.3" section.
 902
 903 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 904
 905         GDB 8.3.1 released.
 906
 907 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 908
 909         * NEWS: Mention that Cell/B.E. debugging support was removed.
 910         * MAINTAINERS: Remove spu target.
 911
 912         * config/djgpp/fnchange.lst: Remove entries for removed files.
 913
 914         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 915         spu-multiarch.o, and spu-tdep.o.
 916         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 917         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 918         spu-multiarch.c, and spu-tdep.c.
 919         * spu-linux-nat.c: Remove file.
 920         * spu-multiarch.c: Remove file.
 921         * spu-tdep.c: Remove file.
 922         * spu-tdep.h: Remove file.
 923         * solib-spu.c: Remove file.
 924         * solib-spu.h: Remove file.
 925
 926         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 927         * configure.nat (spu-linux): Remove.
 928         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 929         solib-multiarch.o from gdb_target_obs.
 930         (spu*-*-*): Remove.
 931
 932         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 933         feature flag.
 934         (ppc_linux_no_features): Update.
 935         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 936         Cell/B.E. support.
 937         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 938         (tdesc_powerpc_cell64l): Likewise.
 939         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 940         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 941         Cell/B.E. support.
 942         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 943         Do not include "features/rs6000/powerpc-cell32l.c" or
 944         "features/rs6000/powerpc-cell64l.c".
 945         (ppc_linux_spu_section): Remove.
 946         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 947         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 948         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 949         (ppc_linux_spe_context_lookup): Remove.
 950         (ppc_linux_spe_context_inferior_created): Remove.
 951         (ppc_linux_spe_context_solib_loaded): Remove.
 952         (ppc_linux_spe_context_solib_unloaded): Remove.
 953         (ppc_linux_spe_context): Remove.
 954         (struct ppu2spu_cache): Remove.
 955         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 956         (struct ppu2spu_data): Remove.
 957         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 958         ppu2spu_unwind): Remove.
 959         (ppc_linux_init_abi): Remove Cell/B.E. support.
 960         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 961
 962         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 963         (rs6000/powerpc-cell64l-expedite): Likewise
 964         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 965         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 966         rs6000/powerpc-cell64l.xml.
 967         * features/rs6000/powerpc-cell32l.xml: Remove.
 968         * features/rs6000/powerpc-cell64l.xml: Likewise.
 969         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 970         * features/rs6000/powerpc-cell64l.c: Likewise.
 971         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 972         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 973         * regformats/reg-spu.dat: Remove.
 974
 975         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 976         * corelow.c (struct spuid_list): Remove.
 977         (add_to_spuid_list): Remove.
 978         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 979         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 980         (remote_protocol_features): Remove associated entries.
 981         (_initialize_remote): No longer initialize them.
 982         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 983         * linux-nat.c (SPUFS_MAGIC): Remove.
 984         (linux_proc_xfer_spu): Remove.
 985         (spu_enumerate_spu_ids): Remove.
 986         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 987         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 988         (linux_make_corefile_notes): No longer call it.
 989
 990         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 991         (cooked_write_test): Likewise.
 992
 993 2019-09-20  Tom Tromey  <tom@tromey.com>
 994
 995         * NEWS: Mention case-sensitivity of TUI commands.
 996         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 997         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 998         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 999
1000 2019-09-20  Tom Tromey  <tom@tromey.com>
1001
1002         * tui/tui-source.c (tui_source_window::set_contents): Use
1003         make_unique_xstrdup.
1004         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1005         make_unique_xstrdup.
1006
1007 2019-09-20  Tom Tromey  <tom@tromey.com>
1008
1009         * tui/tui-data.c: Remove separator comments.
1010         * tui/tui-layout.c: Remove separator comments.
1011         * tui/tui-win.c: Remove separator comments.
1012         * tui/tui-wingeneral.c: Remove separator comments.
1013
1014 2019-09-20  Tom Tromey  <tom@tromey.com>
1015
1016         * tui/tui.h (strcat_to_buf): Don't declare.
1017         * tui/tui.c (strcat_to_buf): Remove.
1018
1019 2019-09-20  Tom Tromey  <tom@tromey.com>
1020
1021         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1022         from "fullname".
1023         * tui/tui-source.c (tui_source_window::set_contents)
1024         (tui_source_window::location_matches_p)
1025         (tui_source_window::maybe_update): Update.
1026
1027 2019-09-20  Tom Tromey  <tom@tromey.com>
1028
1029         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1030         Update.
1031         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1032         prefix.
1033         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1034         (tui_data_window::line_from_reg_element_no)
1035         (tui_data_window::first_reg_element_no_inline)
1036         (tui_data_window::show_registers)
1037         (tui_data_window::show_register_group)
1038         (tui_data_window::display_registers_from)
1039         (tui_data_window::display_registers_from_line)
1040         (tui_data_window::first_data_item_displayed)
1041         (tui_data_window::delete_data_content_windows)
1042         (tui_data_window::erase_data_content)
1043         (tui_data_window::do_scroll_vertical)
1044         (tui_data_window::refresh_window)
1045         (tui_data_window::check_register_values): Update.
1046
1047 2019-09-20  Tom Tromey  <tom@tromey.com>
1048
1049         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1050         (struct tui_locator_window) <full_name, proc_name>: Now
1051         std::string.
1052         * tui/tui-stack.c (tui_locator_window::make_status_line)
1053         (tui_locator_window::set_locator_fullname)
1054         (tui_locator_window::set_locator_info): Update.
1055         * tui/tui-source.c (tui_source_window::set_contents)
1056         (tui_source_window::showing_source_p): Update.
1057
1058 2019-09-20  Tom Tromey  <tom@tromey.com>
1059
1060         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1061         Don't call tui_locator_win_info_ptr.
1062
1063 2019-09-20  Tom Tromey  <tom@tromey.com>
1064
1065         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1066
1067 2019-09-20  Tom Tromey  <tom@tromey.com>
1068
1069         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1070         height for locator.
1071         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1072         * tui/tui-layout.c (show_source_disasm_command, show_data)
1073         (show_source_or_disasm_and_command): Use 1 as height for locator.
1074
1075 2019-09-20  Tom Tromey  <tom@tromey.com>
1076
1077         * tui/tui.c (tui_enable): Update.
1078         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1079         Update.
1080         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1081         Update.
1082         * tui/tui-data.c (win_resized): Now bool.
1083         (tui_win_resized): Return bool.
1084         (tui_set_win_resized_to): Accept a bool.
1085
1086 2019-09-20  Tom Tromey  <tom@tromey.com>
1087
1088         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1089         Change type of "refresh_values_only".
1090         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1091         type of "refresh_values_only".
1092
1093 2019-09-20  Tom Tromey  <tom@tromey.com>
1094
1095         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1096         std::string.
1097         (tui_disassemble): Add "pos" parameter.
1098         (tui_disasm_window::set_contents): Simplify.
1099
1100 2019-09-20  Tom Tromey  <tom@tromey.com>
1101
1102         * tui/tui-winsource.h (struct tui_source_window_base)
1103         <show_source_content>: Now private.
1104         * tui/tui-winsource.c
1105         (tui_source_window_base::show_source_content): Don't handle empty
1106         content case.
1107
1108 2019-09-20  Tom Tromey  <tom@tromey.com>
1109
1110         * tui/tui-layout.c (show_source_disasm_command)
1111         (show_source_or_disasm_and_command): Don't call
1112         show_source_content.
1113
1114 2019-09-20  Tom Tromey  <tom@tromey.com>
1115
1116         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1117         Declare.
1118         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1119         from tui_make_status_line.
1120         (tui_locator_window::rerender): Update.
1121
1122 2019-09-20  Tom Tromey  <tom@tromey.com>
1123
1124         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1125         (tui_locator_window::rerender): Update.
1126
1127 2019-09-20  Tom Tromey  <tom@tromey.com>
1128
1129         * tui/tui-winsource.h (struct tui_source_window_base)
1130         <~tui_source_window_base>: Don't declare.
1131         <fullname>: Remove.
1132         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1133         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1134         member.
1135         * tui/tui-source.c (tui_source_window::set_contents): Update.
1136         (tui_source_window::location_matches_p)
1137         (tui_source_window::maybe_update): Update.
1138
1139 2019-09-20  Tom Tromey  <tom@tromey.com>
1140
1141         * tui/tui-winsource.h (~tui_source_element): Remove.
1142         (tui_source_element): Update.
1143         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1144         * tui/tui-winsource.c (tui_show_source_line): Update.
1145         * tui/tui-source.c (tui_source_window::set_contents): Update.
1146         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1147
1148 2019-09-20  Tom Tromey  <tom@tromey.com>
1149
1150         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1151         declare.
1152         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1153         tui_clear_source_windows_detail.
1154         * tui/tui-winsource.h (struct tui_source_window_base)
1155         <clear_detail>: Don't declare.
1156         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1157         Remove.
1158         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1159
1160 2019-09-20  Tom Tromey  <tromey@adacore.com>
1161
1162         PR ada/24919:
1163         * block.c (contained_in): Fix final return value.
1164
1165 2019-09-20  Alan Modra  <amodra@gmail.com>
1166
1167         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1168         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1169         (read_indirect_string_from_dwz): Use bfd accessor.
1170         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1171         * machoread.c (macho_symfile_read_all_oso): Likewise.
1172         * solib.c (solib_bfd_open): Likewise.
1173
1174 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1175
1176         * eval.c: Move declaration of overload_resolution to...
1177         * value.h: ...here.
1178
1179 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1180
1181         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1182         * arm-linux-tdep.c: Likewise.
1183         * arm-nbsd-nat.c: Likewise.
1184         * arm-tdep.h: Declare arm_apcs_32.
1185         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1186
1187 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1188
1189         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1190         * dwarf2read.h: Declare dwarf_always_disassemble.
1191
1192 2019-09-19  Tom de Vries  <tdevries@suse.de>
1193
1194         PR gdb/25009
1195         * source-cache.c (source_cache::ensure): Catch exception thrown during
1196         construction of the highlighter.
1197
1198 2019-09-18  Alan Modra  <amodra@gmail.com>
1199
1200         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1201         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1202         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1203         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1204         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1205         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1206         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1207         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1208         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1209         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1210         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1211         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1212         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1213         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1214         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1215         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1216         * mi/mi-interp.c: Update throughout for bfd section macro and
1217         function changes.
1218         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1219         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1220
1221 2019-09-18  Tom Tromey  <tom@tromey.com>
1222
1223         * NEWS: Add entry.
1224         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1225         call rl_initialize.
1226         (tui_enable): Do not call rl_initialize.
1227
1228 2019-09-18  Christian Groessler  <chris@groessler.org>
1229
1230         * alpha-linux-nat.c: Include gdbarch.h.
1231
1232 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1233
1234         * ui-file.c: Include cli/cli-style.h.
1235         (term_cli_styling): Remove cli_styling declaration.
1236
1237 2019-09-18  Alan Modra  <amodra@gmail.com>
1238
1239         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1240         to bfd_asymbol_section.
1241
1242 2019-09-18  Alan Modra  <amodra@gmail.com>
1243
1244         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1245         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1246         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1247
1248 2019-09-18  Alan Modra  <amodra@gmail.com>
1249
1250         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1251         * spu-linux-nat.c (spu_bfd_open): Likewise.
1252
1253 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1254
1255         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1256         to bool to match definition in dwarf2read.c.
1257
1258 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1259
1260         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1261         (print_signatures): Likewise.
1262         (trust_pad_over_xvs): Likewise.
1263         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1264         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1265         * arm-linux-nat.c (arm_apcs_32): Likewise.
1266         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1267         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1268         * arm-tdep.c (arm_debug): Likewise.
1269         (arm_apcs_32): Likewise.
1270         * auto-load.c (debug_auto_load): Likewise.
1271         (auto_load_gdb_scripts): Likewise.
1272         (global_auto_load): Likewise.
1273         (auto_load_local_gdbinit): Likewise.
1274         (auto_load_local_gdbinit_loaded): Likewise.
1275         * auto-load.h (global_auto_load): Likewise.
1276         (auto_load_local_gdbinit): Likewise.
1277         (auto_load_local_gdbinit_loaded): Likewise.
1278         * breakpoint.c (disconnected_dprintf): Likewise.
1279         (breakpoint_proceeded): Likewise.
1280         (automatic_hardware_breakpoints): Likewise.
1281         (always_inserted_mode): Likewise.
1282         (target_exact_watchpoints): Likewise.
1283         (_initialize_breakpoint): Update.
1284         * breakpoint.h (target_exact_watchpoints): Change to bool.
1285         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1286         * cli/cli-cmds.c (trace_commands): Likewise.
1287         * cli/cli-cmds.h (trace_commands): Likewise.
1288         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1289         to bool*.
1290         * cli/cli-logging.c (logging_overwrite): Change to bool.
1291         (logging_redirect): Likewise.
1292         (debug_redirect): Likewise.
1293         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1294         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1295         to bool.
1296         <boolean_option_def>: Update.
1297         (struct flag_option_def): Change default type of Context to bool
1298         from int.
1299         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1300         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1301         (get_setshow_command_value_string): Likewise.
1302         * cli/cli-style.c (cli_styling): Change to bool.
1303         (source_styling): Likewise.
1304         * cli/cli-style.h (source_styling): Likewise.
1305         (cli_styling): Likewise.
1306         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1307         to bool.
1308         * command.h (var_types): Update comment.
1309         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1310         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1311         bool.
1312         (debug_compile_cplus_scopes): Likewise.
1313         * compile/compile-internal.h (compile_debug): Likewise.
1314         * compile/compile.c (compile_debug): Likewise.
1315         (struct compile_options) <raw>: Likewise.
1316         * cp-support.c (catch_demangler_crashes): Likewise.
1317         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1318         (usr_cmd_cris_dwarf2_cfi): Likewise.
1319         * csky-tdep.c (csky_debug): Likewise.
1320         * darwin-nat.c (enable_mach_exceptions): Likewise.
1321         * dcache.c (dcache_enabled_p): Likewise.
1322         * defs.h (info_verbose): Likewise.
1323         * demangle.c (demangle): Likewise.
1324         (asm_demangle): Likewise.
1325         * dwarf-index-cache.c (debug_index_cache): Likewise.
1326         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1327         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1328         * dwarf2read.c (check_physname): Likewise.
1329         (use_deprecated_index_sections): Likewise.
1330         (dwarf_always_disassemble): Likewise.
1331         * eval.c (overload_resolution): Likewise.
1332         * event-top.c (set_editing_cmd_var): Likewise.
1333         (exec_done_display_p): Likewise.
1334         * event-top.h (set_editing_cmd_var): Likewise.
1335         (exec_done_display_p): Likewise.
1336         * exec.c (write_files): Likewise.
1337         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1338         (debug_fbsd_nat): Likewise.
1339         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1340         Likewise.
1341         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1342         <backtrace_past_entry> Likewise.
1343         * gdb-demangle.h (demangle): Likewise.
1344         (asm_demangle): Likewise.
1345         * gdb_bfd.c (bfd_sharing): Likewise.
1346         * gdbcore.h (write_files): Likewise.
1347         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1348         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1349         * gdbthread.h (print_thread_events): Likewise.
1350         * gdbtypes.c (opaque_type_resolution): Likewise.
1351         (strict_type_checking): Likewise.
1352         * gnu-nat.c (gnu_debug_flag): Likewise.
1353         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1354         * guile/scm-param.c (pascm_variable): Add boolval.
1355         (add_setshow_generic): Update.
1356         (pascm_param_value): Update.
1357         (pascm_set_param_value_x): Update.
1358         * hppa-tdep.c (hppa_debug): Change to bool..
1359         * infcall.c (may_call_functions_p): Likewise.
1360         (coerce_float_to_double_p): Likewise.
1361         (unwind_on_signal_p): Likewise.
1362         (unwind_on_terminating_exception_p): Likewise.
1363         * infcmd.c (startup_with_shell): Likewise.
1364         * inferior.c (print_inferior_events): Likewise.
1365         * inferior.h (startup_with_shell): Likewise.
1366         (print_inferior_events): Likewise.
1367         * infrun.c (step_stop_if_no_debug): Likewise.
1368         (detach_fork): Likewise.
1369         (debug_displaced): Likewise.
1370         (disable_randomization): Likewise.
1371         (non_stop): Likewise.
1372         (non_stop_1): Likewise.
1373         (observer_mode): Likewise.
1374         (observer_mode_1): Likewise.
1375         (set_observer_mode): Update.
1376         (sched_multi): Change to bool.
1377         * infrun.h (debug_displaced): Likewise.
1378         (sched_multi): Likewise.
1379         (step_stop_if_no_debug): Likewise.
1380         (non_stop): Likewise.
1381         (disable_randomization): Likewise.
1382         * linux-tdep.c (use_coredump_filter): Likewise.
1383         (dump_excluded_mappings): Likewise.
1384         * linux-thread-db.c (auto_load_thread_db): Likewise.
1385         (check_thread_db_on_load): Likewise.
1386         * main.c (captured_main_1): Update.
1387         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1388         xx2_opt, boolean_opt>: Change to bool.
1389         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1390         * maint.c (maintenance_profile_p): Likewise.
1391         (per_command_time): Likewise.
1392         (per_command_space): Likewise.
1393         (per_command_symtab): Likewise.
1394         * memattr.c (inaccessible_by_default): Likewise.
1395         * mi/mi-main.c (mi_async): Likewise.
1396         (mi_async_1): Likewise.
1397         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1398         * nat/fork-inferior.h (startup_with_shell): Likewise.
1399         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1400         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1401         * nios2-tdep.c (nios2_debug): Likewise.
1402         * or1k-tdep.c (or1k_debug): Likewise.
1403         * parse.c (parser_debug): Likewise.
1404         * parser-defs.h (parser_debug): Likewise.
1405         * printcmd.c (print_symbol_filename): Likewise.
1406         * proc-api.c (procfs_trace): Likewise.
1407         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1408         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1409         (set_parameter_value): Update.
1410         (add_setshow_generic): Update.
1411         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1412         to bool*.
1413         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1414         int*.
1415         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1416         * record-btrace.c (record_btrace_target::store_registers): Update.
1417         * record-full.c (record_full_memory_query): Change to bool.
1418         (record_full_stop_at_limit): Likewise.
1419         * record-full.h (record_full_memory_query): Likewise.
1420         * remote-notif.c (notif_debug): Likewise.
1421         * remote-notif.h (notif_debug): Likewise.
1422         * remote.c (use_range_stepping): Likewise.
1423         (interrupt_on_connect): Likewise.
1424         (remote_break): Likewise.
1425         * ser-tcp.c (tcp_auto_retry): Likewise.
1426         * ser-unix.c (serial_hwflow): Likewise.
1427         * skip.c (debug_skip): Likewise.
1428         * solib-aix.c (solib_aix_debug): Likewise.
1429         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1430         (spu_auto_flush_cache_p): Likewise.
1431         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1432         Likewise.
1433         (struct info_print_options) <quiet>: Likewise.
1434         * symfile-debug.c (debug_symfile): Likewise.
1435         * symfile.c (auto_solib_add): Likewise.
1436         (separate_debug_file_debug): Likewise.
1437         * symfile.h (auto_solib_add): Likewise.
1438         (separate_debug_file_debug): Likewise.
1439         * symtab.c (basenames_may_differ): Likewise.
1440         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1441         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1442         (struct info_types_options) <quiet>: Likewise.
1443         * symtab.h (demangle): Likewise.
1444         (basenames_may_differ): Likewise.
1445         * target-dcache.c (stack_cache_enabled_1): Likewise.
1446         (code_cache_enabled_1): Likewise.
1447         * target.c (trust_readonly): Likewise.
1448         (may_write_registers): Likewise.
1449         (may_write_memory): Likewise.
1450         (may_insert_breakpoints): Likewise.
1451         (may_insert_tracepoints): Likewise.
1452         (may_insert_fast_tracepoints): Likewise.
1453         (may_stop): Likewise.
1454         (auto_connect_native_target): Likewise.
1455         (target_stop_and_wait): Update.
1456         (target_async_permitted): Change to bool.
1457         (target_async_permitted_1): Likewise.
1458         (may_write_registers_1): Likewise.
1459         (may_write_memory_1): Likewise.
1460         (may_insert_breakpoints_1): Likewise.
1461         (may_insert_tracepoints_1): Likewise.
1462         (may_insert_fast_tracepoints_1): Likewise.
1463         (may_stop_1): Likewise.
1464         * target.h (target_async_permitted): Likewise.
1465         (may_write_registers): Likewise.
1466         (may_write_memory): Likewise.
1467         (may_insert_breakpoints): Likewise.
1468         (may_insert_tracepoints): Likewise.
1469         (may_insert_fast_tracepoints): Likewise.
1470         (may_stop): Likewise.
1471         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1472         (make_thread_apply_all_options_def_group): Change argument from int*
1473         to bool*.
1474         (thread_apply_all_command): Update.
1475         (print_thread_events): Change to bool.
1476         * top.c (confirm): Likewise.
1477         (command_editing_p): Likewise.
1478         (history_expansion_p): Likewise.
1479         (write_history_p): Likewise.
1480         (info_verbose): Likewise.
1481         * top.h (confirm): Likewise.
1482         (history_expansion_p): Likewise.
1483         * tracepoint.c (disconnected_tracing): Likewise.
1484         (circular_trace_buffer): Likewise.
1485         * typeprint.c (print_methods): Likewise.
1486         (print_typedefs): Likewise.
1487         * utils.c (debug_timestamp): Likewise.
1488         (sevenbit_strings): Likewise.
1489         (pagination_enabled): Likewise.
1490         * utils.h (sevenbit_strings): Likewise.
1491         (pagination_enabled): Likewise.
1492         * valops.c (overload_resolution): Likewise.
1493         * valprint.h (struct value_print_options) <prettyformat_arrays,
1494         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1495         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1496         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1497         Likewise.
1498         * windows-nat.c (new_console): Likewise.
1499         (cygwin_exceptions): Likewise.
1500         (new_group): Likewise.
1501         (debug_exec): Likewise.
1502         (debug_events): Likewise.
1503         (debug_memory): Likewise.
1504         (debug_exceptions): Likewise.
1505         (useshell): Likewise.
1506         * windows-tdep.c (maint_display_all_tib): Likewise.
1507         * xml-support.c (debug_xml): Likewise.
1508
1509 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1510
1511         * source.c (prepare_path_for_appending): New function.
1512         (openp): Make use of new function.
1513         (find_and_open_source): Search for the compilation directory and
1514         source file as a relative path beneath the directory search path.
1515
1516 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1517
1518         * source-cache.c (source_cache::get_line_charpos): Catch
1519         exceptions and return false, this matches the behaviour documented
1520         in the header file.
1521
1522 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1523
1524         * ada-tasks.c (info_task): Remove quoting of the task's name.
1525
1526 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1527
1528         * symfile.c (auto_solib_add): Replace comment with a reference
1529         to the header file.
1530
1531 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1532
1533         * NEWS: Mention that gdb can now be compiled with Python 3
1534         on Windows.
1535
1536 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1537
1538         * maint.c (maint_print_section_data::maint_print_section_data):
1539         Force use of 'float log10 (float)' by casting the argument to
1540         float.
1541
1542 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1543
1544         * maint.c: Add 'cmath' include.
1545         (struct maint_print_section_data): New structure.
1546         (print_section_index): New function.
1547         (print_bfd_section_info): Add header comment, small whitespace
1548         cleanup, and update to call new print_section_index function.
1549         (print_objfile_section_info): Likewise.
1550         (maint_obj_section_from_bfd_section): New function.
1551         (print_bfd_section_info_maybe_relocated): New function.
1552         (maintenance_info_sections): Add header comment, always use
1553         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1554
1555 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1556
1557         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1558         inner scope, add check that the objfile has psymtabs before
1559         checking psymtabs_addrmap.
1560         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1561
1562 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1563
1564         * NEWS: Announce that Ada task names are now shown at more places,
1565         and between quotes (except in info task output).
1566         * gdb/ada-tasks.c (task_to_str): New function.
1567         (display_current_task_id): Call task_to_str.
1568         (task_command_1): Likewise.
1569         (print_ada_task_info): In non-mi mode, Properly align headers and data
1570         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1571
1572 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1573
1574         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1575         prstatus.pr_lwp.pr_info instead of making it up.
1576
1577 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1578
1579         * auto-load.c (auto_load_expand_dir_vars): Update.
1580         * defs.h (gdb_datadir): Change to std::string.
1581         (python_libdir): Likewise.
1582         (relocate_gdb_directory): Change return type to std::string.
1583         * guile/guile.c (gdbscm_data_directory): Update.
1584         (initialize_scheme_side): Update.
1585         * jit.c (jit_reader_dir): Change to std::string.
1586         (jit_reader_load_command): Update.
1587         * main.c (gdb_datadir): Change to std::string.
1588         (python_libdir): Likewise.
1589         (set_gdb_data_directory): Update.
1590         (relocate_path): Change to return std::string.
1591         (relocate_gdb_directory): Change to return std::string.
1592         (relocate_gdbinit_path_maybe_in_datadir): Update.
1593         (captured_main_1): Update.
1594         * python/python.c (do_start_initialization): Update.
1595         * top.c (show_gdb_datadir): Update.
1596         * xml-syscall.c (xml_init_syscalls_info): Update.
1597         (init_syscalls_info): Update.
1598
1599 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1600
1601         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1602         out of get_init_files.
1603         (get_init_files): Update.
1604
1605 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1606
1607         * main.c (get_init_files): Change to use std::string.
1608         (captured_main_1): Update.
1609         (print_gdb_help): Update.
1610
1611 2019-09-11  Ali Tamur  <tamur@google.com>
1612
1613         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1614         implementation.
1615
1616 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1617
1618         * dbxread.c (read_dbx_symtab): Update.
1619         * dwarf2read.c (load_partial_dies): Update.
1620         * mdebugread.c (parse_partial_symbols): Update.
1621         (handle_psymbol_enumerators): Update.
1622         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1623         * psymtab.c (add_psymbol_to_bcache): Likewise.
1624         (add_psymbol_to_list): Likewise.
1625         * symtab.c (symbol_set_names): Likewise.
1626         * symtab.h (symbol_set_names): Likewise.
1627         * xcoffread.c (scan_xcoff_symtab): Update.
1628
1629 2019-09-11  Tom Tromey  <tom@tromey.com>
1630
1631         * symfile-mem.c (symbol_file_add_from_memory): Use
1632         bfd_set_filename.
1633         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1634         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1635
1636 2019-09-10  Tom Tromey  <tromey@adacore.com>
1637
1638         * dwarf-index-write.c (write_psymbols): Extend error message.
1639         (debug_names::insert): Add Ada code.
1640         (debug_names::write_psymbols): Remove Ada check.
1641         (debug_names) <m_string_obstack>: New member.
1642         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1643         (gdb_index_symbol_name_matcher::matches): Remove.
1644         (mapped_index_base::find_name_components_bounds): Add "lang"
1645         parameter.
1646         (mapped_index_base::build_name_components): Also split names
1647         according to Ada syntax.
1648         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1649         type of "match_callback".
1650         (check_match, check_find_bounds_finds)
1651         (dw2_expand_symtabs_matching): Update.
1652         (dw2_debug_names_iterator): Add new constructor.
1653         (dw2_debug_names_map_matching_symbols): New function.
1654         (dw2_debug_names_expand_symtabs_matching): Update.
1655         (dwarf2_debug_names_functions): Use
1656         dw2_debug_names_map_matching_symbols.
1657
1658 2019-09-10  Tom Tromey  <tromey@adacore.com>
1659
1660         * dwarf2read.c (dw2_get_file_names_reader): Add the
1661         CU's file name to the results.
1662
1663 2019-09-10  Tom Tromey  <tromey@adacore.com>
1664
1665         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1666         map_matching_symbols.  Update.
1667         * dwarf2read.c (dw2_map_matching_symbols): Update.
1668         * psymtab.c (match_partial_symbol): Change type; update.
1669         (psym_map_matching_symbols): Likewise.
1670         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1671         type; update.
1672         * symfile.h (struct quick_symbol_functions)
1673         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1674         Remove "match".
1675
1676 2019-09-10  Tom Tromey  <tromey@adacore.com>
1677
1678         * psymtab.c (map_block): Remove.
1679         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1680         * symtab.c (iterate_over_symbols_terminated): New function.
1681         * symtab.c (iterate_over_symbols_terminated): Declare.
1682
1683 2019-09-10  Tom Tromey  <tromey@adacore.com>
1684
1685         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1686         * language.h (struct language_defn) <la_iterate_over_symbols>:
1687         Return bool.
1688         * symtab.c (iterate_over_symbols): Return bool.
1689         * symtab.h (iterate_over_symbols): Return bool.
1690
1691 2019-09-10  Tom Tromey  <tromey@adacore.com>
1692
1693         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1694         (add_nonlocal_symbols): Update.
1695         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1696         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1697         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1698         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1699         Change type of "callback".  Remove "data".
1700
1701
1702 2019-09-09  Ali Tamur  <tamur@google.com>
1703
1704         * dwarf2read.c (comp_unit_head): Update comment.
1705         (dwarf2_dwo_name): New function declaration.
1706         (dwarf_unit_type_name): New function declaration.
1707         (read_comp_unit_head): Add support for new compilation units,
1708         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1709         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1710         (currently named as "signature") in their header. Also clarify error
1711         messages.
1712         (lookup_dwo_id): New function. Returns the dwo id of the given
1713         compile unit.
1714         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1715         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1716         functions.
1717         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1718         (dwarf2_dwo_name): Get the dwo name if present.
1719         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1720         purposes.
1721
1722 2019-09-09  Tom Tromey  <tom@tromey.com>
1723
1724         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1725
1726 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1727
1728         * python/python.c (do_start_initialization): Make progname_copy static,
1729         to avoid a leak report.
1730
1731 2019-09-08  Tom Tromey  <tom@tromey.com>
1732
1733         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1734
1735 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1736
1737         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1738         Change type to gdb::optional<block_enum>.
1739         (dw2_symtab_iter_init): Change block_index parameter type
1740         to gdb::optional<block_enum>.
1741         (dw2_lookup_symbol): Change block_index parameter
1742         type to block_enum.c
1743         (dw2_debug_names_lookup_symbol): Likewise.
1744         * psymtab.c (psym_lookup_symbol): Likewise.
1745         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1746         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1747         Likewise.
1748
1749 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1750
1751         * defs.h (relocate_gdb_directory): Change int to bool in
1752         signature and rename flag to relocatable.
1753         * main.c (relocate_path): Likewise.
1754         (relocate_gdb_directory): Likewise.
1755
1756 2019-09-06  Alan Modra  <amodra@gmail.com>
1757
1758         * coffread.c (coff_symfile_read): Constify filename variable.
1759         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1760         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1761         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1762         * solib.c (reload_shared_libraries_1): Likewise.
1763         * symfile.c (reread_symbols): Likewise.
1764         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1765         * solib-darwin.c (darwin_bfd_open): Likewise.
1766         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1767
1768 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1769
1770         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1771         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1772
1773 2019-09-03  Tom Tromey  <tromey@adacore.com>
1774
1775         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1776         types.
1777         (has_negatives): Unbias a range type bound.
1778         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1779         * gdbtypes.c (operator==): Handle new field.
1780         (create_range_type): Add "bias" parameter.
1781         (create_static_range_type, resolve_dynamic_range): Update.
1782         * gdbtypes.h (struct range_bounds) <bias>: New member.
1783         (create_range_type): Add bias parameter.
1784         * printcmd.c (print_scalar_formatted): Unbias range types.
1785         * value.c (unpack_long): Unbias range types.
1786         (pack_long): Bias range types.
1787
1788 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1789
1790         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1791         probe arguments.
1792
1793 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1794
1795         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1796         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1797         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1798         (compile_probe_arg): Likewise.
1799         * probe.h (get_argument_count): Likewise.
1800         * solib-svr4.c (solib_event_probe_action): Likewise.
1801         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1802
1803 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1804
1805         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1806         code to here...
1807         (svr4_create_solib_event_breakpoints): ...from here.
1808
1809 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1810
1811         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1812         suffix from warning message.
1813
1814 2019-08-30  Tom Tromey  <tom@tromey.com>
1815
1816         * tui/tui-winsource.h (struct tui_source_window_base)
1817         <refresh_all>: Don't declare.
1818         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1819         Remove.
1820         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1821         tui_show_locator_content.
1822         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1823         declare.
1824         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1825         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1826         declare.
1827
1828 2019-08-30  Tom Tromey  <tom@tromey.com>
1829
1830         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1831
1832 2019-08-30  Tom Tromey  <tom@tromey.com>
1833
1834         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1835         Remove unnecessary forward declarations.
1836
1837 2019-08-30  Tom Tromey  <tom@tromey.com>
1838
1839         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1840         rerender.
1841         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1842         tui_show_locator_content.
1843
1844 2019-08-30  Tom Tromey  <tom@tromey.com>
1845
1846         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1847         (tui_locator_window::rerender): Rewrite using body of previous
1848         tui_show_locator_content.
1849
1850 2019-08-30  Tom Tromey  <tom@tromey.com>
1851
1852         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1853         set_locator_fullname>: New methods.
1854         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1855         Rename from tui_set_locator_fullname.
1856         (tui_locator_window::set_locator_info): Rename from
1857         tui_set_locator_info.  Return bool.
1858         (tui_update_locator_fullname, tui_show_frame_info): Update.
1859
1860 2019-08-30  Tom Tromey  <tom@tromey.com>
1861
1862         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1863
1864 2019-08-30  Tom Tromey  <tom@tromey.com>
1865
1866         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1867         call touchwin.
1868
1869 2019-08-30  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-wingeneral.c (box_win): Assume win_info and
1872         win_info->handle cannot be NULL.
1873
1874 2019-08-30  Tom Tromey  <tom@tromey.com>
1875
1876         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1877         refresh_window>: Declare.
1878         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1879         resize.
1880         (tui_data_item_window::rerender): Rename from
1881         tui_display_register.
1882         (tui_data_item_window::refresh_window): New method.
1883         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1884         no-op.
1885
1886 2019-08-30  Tom Tromey  <tom@tromey.com>
1887
1888         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1889         regs_column_count, current_group>: Move later.  Now private.
1890         <get_current_group>: New method.
1891         * tui/tui-regs.c (tui_reg_command): Update.
1892         * tui/tui-layout.c (tui_set_layout): Update.
1893
1894 2019-08-30  Tom Tromey  <tom@tromey.com>
1895
1896         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1897         (tui_data_window::rerender): Don't call
1898         check_and_display_highlight_if_needed.
1899         (tui_data_window::refresh_all): Remove call to
1900         erase_data_content.
1901
1902 2019-08-30  Tom Tromey  <tom@tromey.com>
1903
1904         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1905         (tui_data_window::display_registers_from)
1906         (tui_data_window::display_reg_element_at_line)
1907         (tui_data_window::display_registers_from_line): Remove checks of
1908         "empty".
1909
1910 2019-08-30  Tom Tromey  <tom@tromey.com>
1911
1912         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1913         Don't declare.
1914         * tui/tui-regs.c (tui_data_window::show_registers): Call
1915         rerender.
1916         (tui_data_window::rerender): Rename from display_all_data.
1917         (tui_data_window::rerender): Remove old implementation.
1918
1919 2019-08-30  Tom Tromey  <tom@tromey.com>
1920
1921         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1922         text.
1923         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1924
1925 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1926             Sergio Durigan Junior  <sergiodj@redhat.com>
1927
1928         PR win32/24284
1929         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1930
1931 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1932
1933         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1934         when searching for types.
1935
1936 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1937
1938         * f-lang.c (f_language_defn): Use f_print_typedef.
1939         * f-lang.h (f_print_typedef): Declare.
1940         * f-typeprint.c (f_print_typedef): Define.
1941
1942 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1943
1944         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1945
1946 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1947
1948         * cli/cli-utils.c (info_print_options_defs): Delete.
1949         (make_info_print_options_def_group): Delete.
1950         (extract_info_print_options): Delete.
1951         (info_print_command_completer): Delete.
1952         (info_print_args_help): Add extra parameter, and optionally
1953         include text about -n flag.
1954         * cli/cli-utils.h (struct info_print_options): Delete.
1955         (extract_info_print_options): Delete declaration.
1956         (info_print_command_completer): Delete declaration.
1957         (info_print_args_help): Add extra parameter, extend header
1958         comment.
1959         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1960         search_symbols.
1961         * stack.c (struct info_print_options): New type.
1962         (info_print_options_defs): New file scoped variable.
1963         (make_info_print_options_def_group): New static function.
1964         (info_print_command_completer): New static function.
1965         (info_locals_command): Update to use new local functions.
1966         (info_args_command): Likewise.
1967         (_initialize_stack): Add extra parameter to calls to
1968         info_print_args_help.
1969         * symtab.c (search_symbols): Add extra parameter, use this to
1970         possibly excluse non-debug symbols.
1971         (symtab_symbol_info): Add extra parameter, which is passed on to
1972         search_symbols.
1973         (struct info_print_options): New type.
1974         (info_print_options_defs): New file scoped variable.
1975         (make_info_print_options_def_group): New static function.
1976         (info_print_command_completer): New static function.
1977         (info_variables_command): Update to use local functions, and pass
1978         extra parameter through to symtab_symbol_info.
1979         (info_functions_command): Likewise.
1980         (info_types_command): Pass additional argument through to
1981         symtab_symbol_info.
1982         (rbreak_command): Pass extra argument to search_symbols.
1983         (_initialize_symtab): Add extra arguments for calls to
1984         info_print_args_help, and update help text for 'info variables',
1985         'whereis', and 'info functions' commands.
1986         * symtab.h (search_symbols): Add extra argument to declaration.
1987         * NEWS: Mention new flags.
1988
1989 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1990
1991         * symtab.c (lookup_static_symbol): Call the new function (and move
1992         it down to be next to lookup_global_symbol).
1993         (struct global_sym_lookup_data): Add block_enum member and rename to...
1994         (struct global_or_static_sym_lookup_data): ...this.
1995         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1996         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1997         (lookup_symbol_global_or_static_iterator_cb): ...this.
1998         (lookup_global_or_static_symbol): New function.
1999         (lookup_global_symbol): Call new function.
2000
2001 2019-08-26  Tom de Vries  <tdevries@suse.de>
2002
2003         PR c++/24852
2004         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2005         when pc_probe.prob == NULL.
2006
2007 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2008
2009         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2010         variable symbol_linkage to symbol_linkage_.
2011
2012 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2013
2014         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2015         represent whether the symbol is static, dynamic, or we don't
2016         know.
2017
2018 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2019
2020         * gdb/rx-tdep.c (rx_register_names): New.
2021         (rx_register_name): Delete.
2022         (rx_psw_type): Delete.
2023         (rx_fpsw_type): Delete.
2024         (rx_register_type): Delete.
2025         (rx_gdbarch_init): Convert target-descriptions.
2026         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2027         * gdb/features/Makefile: Add rx.xml.
2028         * gdb/features/rx.xml: New.
2029         * gdb/features/rx.c: Generated.
2030         * gdb/NEWS: Mention target description support.
2031
2032 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2033
2034         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2035         *slot_ptr.
2036
2037 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2038
2039         * configure.ac: Don't check for 'dlfcn.h' (moved to
2040         gdbsupport/common.m4).
2041         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2042         'gdbsupport/'.
2043         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2044         * compile/compile-c-support.c: Include
2045         'gdbsupport/gdb-dlfcn.h'.
2046         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2047         * gdb-dlfcn.c: Move to...
2048         * gdbsupport/gdb-dlfcn.c: ... here.
2049         * gdb-dlfcn.h: Move to...
2050         * gdbsupport/gdb-dlfcn.h: ... here.
2051
2052 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2053
2054         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2055         the offset field signed.
2056
2057 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2058
2059         * python/lib/gdb/__init__.py (_execute_file): New function.
2060         * python/python.c (python_run_simple_file): Call gdb._execute_file
2061         on Windows.
2062
2063 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2064
2065         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2066         all uses as this was never set to anything but a zero value.
2067
2068 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2069
2070         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2071
2072 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2073
2074         * tui/tui-data.h (tui_gen_win_info): Add an =default
2075         move constructor, required by some GCC versions.
2076
2077 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2078
2079         * go32-nat.c (go32_sysinfo): Add hygon_p.
2080
2081 2019-08-20  Tom Tromey  <tom@tromey.com>
2082
2083         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2084         line_from_reg_element_no, first_reg_element_no_inline,
2085         display_all_data, delete_data_content_windows,
2086         erase_data_content>: Now private.
2087
2088 2019-08-20  Tom Tromey  <tom@tromey.com>
2089
2090         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2091         (tui_unhighlight_win, tui_highlight_win)
2092         (tui_win_info::make_window): Update.
2093         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2094
2095 2019-08-20  Tom Tromey  <tom@tromey.com>
2096
2097         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2098         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2099         (MAX_PID_WIDTH): Move to tui-stack.c.
2100         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2101         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2102         (MAX_PID_WIDTH): Move from tui-data.h.
2103
2104 2019-08-20  Tom Tromey  <tom@tromey.com>
2105
2106         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2107         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2108         (box_win): Update.
2109         (tui_gen_win_info::make_window): Rename from tui_make_window.
2110         (tui_win_info::make_window): New method.
2111         (tui_gen_win_info::make_visible): Update.
2112         * tui/tui-source.c (tui_source_window::set_contents): Update.
2113         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2114         (tui_data_window::display_registers_from): Update.
2115         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2116         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2117         Declare.
2118         <can_box>: Remove.
2119         <title>: Remove.
2120         (struct tui_win_info) <make_window>: Declare.
2121         <can_box>: Now virtual.
2122         <title>: New member.
2123         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2124         * tui/tui-command.c (tui_cmd_window::resize): Update.
2125
2126 2019-08-20  Tom Tromey  <tom@tromey.com>
2127
2128         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2129         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2130         (tui_data_window::check_register_values): Update.
2131
2132 2019-08-20  Tom Tromey  <tom@tromey.com>
2133
2134         * tui/tui-regs.h (struct tui_data_window): Use
2135         DISABLE_COPY_AND_ASSIGN.
2136         <regs_content>: Change type, removing unique_ptr.
2137         <tui_data_window>: Add move constructor.
2138         * tui/tui-regs.c (tui_data_window::show_registers)
2139         (tui_data_window::show_register_group)
2140         (tui_data_window::display_registers_from)
2141         (tui_data_window::display_registers_from)
2142         (tui_data_window::first_data_item_displayed)
2143         (tui_data_window::delete_data_content_windows)
2144         (tui_data_window::rerender, tui_data_window::refresh_window)
2145         (tui_data_window::check_register_values): Update.
2146
2147 2019-08-20  Tom Tromey  <tom@tromey.com>
2148
2149         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2150         show_register_group>: Declare.
2151         (tui_show_register_group): Don't declare.
2152         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2153         tui_show_registers.
2154         (tui_data_window::show_register_group): Rename from
2155         tui_show_register_group.
2156         (tui_data_window::check_register_values, tui_reg_command):
2157         Update.
2158         * tui/tui-layout.c (tui_set_layout): Update.
2159
2160 2019-08-20  Tom Tromey  <tom@tromey.com>
2161
2162         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2163         Declare.
2164         (tui_check_register_values): Don't declare.
2165         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2166         from tui_check_register_values.
2167         * tui/tui-hooks.c (tui_register_changed): Update.
2168
2169 2019-08-20  Tom Tromey  <tom@tromey.com>
2170
2171         * tui/tui-regs.c (tui_reg_layout): Move later.
2172         (tui_show_registers): Don't enable TUI mode or change layout.
2173
2174 2019-08-20  Tom Tromey  <tom@tromey.com>
2175
2176         * tui/tui-regs.h (struct tui_data_item_window)
2177         <~tui_data_item_window>: Remove.
2178         <content>: Now a unique_xmalloc_ptr.
2179         * tui/tui-regs.c (tui_register_format): Return a
2180         unique_xmalloc_ptr.
2181         (tui_get_register): Update.
2182         (~tui_data_item_window): Remove.
2183         (tui_data_window::display_registers_from, tui_display_register):
2184         Update.
2185         * tui/tui-io.h (tui_expand_tabs): Update.
2186         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2187         Remove "col" parameter.
2188
2189 2019-08-20  Tom Tromey  <tom@tromey.com>
2190
2191         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2192         field.
2193         * tui/tui-regs.c (~tui_data_item_window): Update.
2194
2195 2019-08-20  Tom Tromey  <tom@tromey.com>
2196
2197         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2198         earlier.
2199
2200 2019-08-20  Tom Tromey  <tom@tromey.com>
2201
2202         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2203
2204 2019-08-20  Tom Tromey  <tom@tromey.com>
2205
2206         * tui/tui-source.h (struct tui_source_window): Update.
2207         * tui/tui-regs.c (tui_show_registers): Update.
2208         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2209         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2210         (NO_REGS_STRING): Remove defines.
2211
2212 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2213
2214         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2215         unnecessary thread walk if remote doesn't support the packet.
2216
2217 2019-08-19  Tom Tromey  <tromey@adacore.com>
2218
2219         * python/py-value.c (value_has_field): Fix indentation.
2220
2221 2019-08-19  Tom Tromey  <tromey@adacore.com>
2222
2223         * printcmd.c (do_one_display, info_display_command): Update.
2224         * block.h (contained_in): Return bool.  Add allow_nested
2225         parameter.
2226         * block.c (contained_in): Return bool.  Add allow_nested
2227         parameter.
2228
2229 2019-08-19  Tom Tromey  <tom@tromey.com>
2230
2231         * configure: Rebuild.
2232         * configure.ac: Disallow the combination of -static-libstdc++ and
2233         source highlight.
2234         * source-cache.c (get_language_name): Handle rust.
2235         (source_cache::get_source_lines): Ignore highlighting exceptions.
2236
2237 2019-08-16  Tom Tromey  <tom@tromey.com>
2238
2239         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2240         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2241         (struct tui_source_window_base) <make_visible, refresh_window,
2242         resize>: Remove methods.
2243         <execution_info>: Remove field.
2244         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2245         (tui_show_source_line, tui_source_window_base)
2246         (~tui_source_window_base): Update.
2247         (tui_source_window_base::resize)
2248         (tui_source_window_base::make_visible)
2249         (tui_source_window_base::refresh_window): Remove.
2250         (tui_source_window_base::update_exec_info): Update.
2251         * tui/tui-source.c (tui_source_window::set_contents): Update.
2252         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2253
2254 2019-08-16  Tom Tromey  <tom@tromey.com>
2255
2256         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2257         deprecated_query_hook.
2258
2259 2019-08-16  Tom Tromey  <tom@tromey.com>
2260
2261         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2262         (tui_update_source_windows_with_line): Update.
2263         * tui/tui-source.h (struct tui_source_window)
2264         <show_symtab_source>: Declare.
2265         (tui_show_symtab_source): Don't declare.
2266         * tui/tui-source.c (tui_show_symtab_source): Rename from
2267         tui_show_symtab_source.
2268
2269 2019-08-16  Tom Tromey  <tom@tromey.com>
2270
2271         * tui/tui-winsource.h (struct tui_source_window_base)
2272         <set_contents>: Declare.
2273         * tui/tui-winsource.c
2274         (tui_source_window_base::update_source_window_as_is): Update.
2275         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2276         Declare.
2277         (tui_set_source_content): Don't declare.
2278         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2279         tui_set_source_content.
2280         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2281         Declare.
2282         (tui_set_disassem_content): Don't declare.
2283         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2284         tui_set_disassem_content.
2285
2286 2019-08-16  Tom Tromey  <tom@tromey.com>
2287
2288         * tui/tui-winsource.h (struct tui_source_window_base)
2289         <update_breakpoint_info>: Declare.
2290         (tui_update_breakpoint_info): Don't declare.
2291         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2292         (tui_update_all_breakpoint_info): Update.
2293         (tui_source_window_base::update_breakpoint_info): Rename from
2294         tui_update_breakpoint_info.
2295         (tui_source_window_base::update_exec_info): Update.
2296
2297 2019-08-16  Tom Tromey  <tom@tromey.com>
2298
2299         * tui/tui-winsource.h (struct tui_source_window_base)
2300         <update_source_window>: Declare.
2301         (tui_update_source_window): Don't declare.
2302         * tui/tui-winsource.c
2303         (tui_source_window_base::update_source_window): Rename from
2304         tui_update_source_window.
2305         (tui_source_window_base::rerender): Update.
2306         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2307         * tui/tui-disasm.c (tui_show_disassem)
2308         (tui_show_disassem_and_update_source)
2309         (tui_disasm_window::maybe_update): Update.
2310
2311 2019-08-16  Tom Tromey  <tom@tromey.com>
2312
2313         * tui/tui-winsource.h (struct tui_source_window_base)
2314         <update_source_window_as_is>: Declare.
2315         (tui_update_source_window_as_is): Don't declare.
2316         * tui/tui-winsource.c (tui_update_source_window): Update
2317         (tui_source_window_base::update_source_window_as_is): Rename from
2318         tui_update_source_window_as_is.
2319         (tui_source_window_base::refill): Update.
2320         * tui/tui-source.c (tui_show_symtab_source): Update.
2321         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2322         Update.
2323
2324 2019-08-16  Tom Tromey  <tom@tromey.com>
2325
2326         * tui/tui-winsource.h (tui_update_source_window)
2327         (tui_update_source_window_as_is): Remove "noerror" parameter.
2328         * tui/tui-winsource.c (tui_update_source_window)
2329         (tui_update_source_window_as_is): Remove "noerror" parameter.
2330         (tui_update_source_windows_with_addr)
2331         (tui_update_source_windows_with_line)
2332         (tui_source_window_base::rerender)
2333         (tui_source_window_base::refill): Update.
2334         * tui/tui-source.h (tui_set_source_content)
2335         (tui_show_symtab_source): Remove "noerror" parameter.
2336         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2337         parameter.
2338         (tui_show_symtab_source): Likewise.
2339         (tui_source_window::maybe_update): Update.
2340         * tui/tui-disasm.c (tui_show_disassem)
2341         (tui_show_disassem_and_update_source)
2342         (tui_disasm_window::do_scroll_vertical)
2343         (tui_disasm_window::maybe_update): Update.
2344
2345 2019-08-16  Tom Tromey  <tom@tromey.com>
2346
2347         * tui/tui.c (tui_is_window_visible): Update.
2348         * tui/tui-wingeneral.c (tui_make_window)
2349         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2350         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2351         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2352         (tui_set_win_height_command, parse_scrolling_args): Update.
2353         * tui/tui-source.c (tui_source_window::style_changed): Update.
2354         * tui/tui-regs.c (tui_show_registers)
2355         (tui_data_window::first_data_item_displayed)
2356         (tui_data_window::delete_data_content_windows)
2357         (tui_check_register_values, tui_reg_command): Update.
2358         * tui/tui-disasm.c (tui_show_disassem): Update.
2359         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2360         method.
2361         <is_visible>: Remove field.
2362         * tui/tui-data.c (tui_next_win, tui_prev_win)
2363         (tui_delete_invisible_windows): Update.
2364
2365 2019-08-16  Tom Tromey  <tom@tromey.com>
2366
2367         * tui/tui-winsource.h (struct tui_source_window_base)
2368         <m_has_locator>: Remove.
2369         * tui/tui-layout.c (show_source_disasm_command, show_data)
2370         (show_source_or_disasm_and_command): Update.
2371
2372 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2373
2374         * NEWS (Other MI changes): New subsection.
2375         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2376         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2377         * arch-utils.c (default_get_pc_address_flags): New function.
2378         * arch-utils.h (default_get_pc_address_flags): New declaration.
2379         * gdbarch.sh: Add get_pc_address_flags.
2380         * gdbarch.c: Regenerate.
2381         * gdbarch.h: Likewise.
2382         * stack.c (print_pc): New function.
2383         (print_frame_info) (print_frame): Call print_pc.
2384
2385 2019-08-16  Tom de Vries  <tdevries@suse.de>
2386
2387         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2388         print_objfile_section_info.
2389
2390 2019-08-15  Tom Tromey  <tom@tromey.com>
2391
2392         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2393         calling update_cmdwin_start_line.
2394         * tui/tui-winsource.h (struct tui_source_window_base)
2395         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2396         <rerender>: Declare.
2397         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2398         Call rerender.
2399         (tui_source_window_base::set_new_height): Remove.
2400         (tui_source_window_base::rerender): Rename from
2401         do_make_visible_with_new_height.
2402         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2403         resize method.
2404         (tui_win_info::make_invisible_and_set_new_height)
2405         (tui_win_info::make_visible_with_new_height): Remove.
2406         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2407         Declare.
2408         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2409         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2410         do_make_visible_with_new_height>: Don't declare.
2411         <rerender>: Declare.
2412         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2413         set_new_height.
2414         (tui_data_window::do_make_visible_with_new_height): Remove.
2415         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2416         call tui_show_locator_content.
2417         (tui_gen_win_info::resize): Call rerender.
2418         (show_source_or_disasm_and_command): Don't call
2419         tui_show_locator_content.
2420         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2421         method.
2422         (struct tui_win_info) <rerender>: Declare.
2423         <set_new_height, make_invisible_and_set_new_height,
2424         make_visible_with_new_height>: Don't declare.
2425         * tui/tui-data.c (tui_win_list::rerender): New method.
2426         * tui/tui-command.h (struct tui_cmd_window)
2427         <do_make_visible_with_new_height>: Don't declare.
2428         * tui/tui-command.c
2429         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2430
2431 2019-08-15  Tom Tromey  <tromey@adacore.com>
2432
2433         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2434         * ada-lang.c (ada_enum_name): Likewise.
2435
2436 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2437
2438         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2439         leading underscore.
2440         (GdbOutputErrorFile): Likewise.
2441         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2442         accordingly.
2443         (execute_unwinders): Rename to have a leading underscore.
2444         (auto_load_packages): Likewise.
2445         (global scope): Adjust call to auto_load_packages accordingly.
2446         (GdbSetPythonDirectory): Likewise.
2447         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2448         instead of execute_unwinders.
2449
2450 2019-08-15  Tom Tromey  <tom@tromey.com>
2451
2452         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2453         (show_data): Don't change window visibility.
2454         (tui_gen_win_info::resize): Remove special case for command
2455         window.  Use wresize, when available.
2456         (show_source_or_disasm_and_command): Don't change window
2457         visibility.
2458         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2459         <make_visible>: New method.
2460         * tui/tui-command.c (tui_cmd_window::resize): New method.
2461
2462 2019-08-15  Tom Tromey  <tom@tromey.com>
2463
2464         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2465         (struct tui_source_windows): New.
2466         * tui/tui-winsource.c (tui_display_main): Update.
2467         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2468         (new_height_ok, parse_scrolling_args): Update.
2469         * tui/tui-layout.c (show_layout, show_data): Update.
2470         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2471         (tui_add_to_source_windows): Don't declare.
2472         * tui/tui-data.c (source_windows, tui_source_windows)
2473         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2474
2475 2019-08-15  Tom Tromey  <tom@tromey.com>
2476
2477         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2478         Rename from reset.
2479         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2480         * tui/tui-layout.c (show_source_disasm_command, show_data):
2481         Update.
2482         (tui_gen_win_info::resize): Rename.
2483         (show_source_or_disasm_and_command): Update.
2484         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2485         reset.
2486
2487 2019-08-15  Tom Tromey  <tom@tromey.com>
2488
2489         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2490         * tui/tui-interp.c (tui_interp::init): Don't call
2491         tui_initialize_static_data.
2492         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2493
2494 2019-08-15  Tom Tromey  <tom@tromey.com>
2495
2496         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2497         examine tui_win_list.
2498
2499 2019-08-15  Tom Tromey  <tom@tromey.com>
2500
2501         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2502         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2503         tui_clear_source_content.
2504         (tui_clear_source_content): Remove.
2505         (tui_source_window_base::do_erase_source_content): Hoist call to
2506         content.clear().
2507         * tui/tui-stack.c (tui_show_frame_info): Don't call
2508         tui_clear_source_content.
2509
2510 2019-08-15  Tom Tromey  <tom@tromey.com>
2511
2512         * tui/tui-winsource.h (struct tui_source_window_base)
2513         <do_erase_source_content>: New method.
2514         <erase_source_content>: New method.
2515         (tui_erase_source_content): Don't declare.
2516         * tui/tui-winsource.c (tui_clear_source_content): Update.
2517         (tui_source_window_base::do_erase_source_content): Rename from
2518         tui_erase_source_content.
2519         (tui_source_window_base::show_source_content): Update.
2520         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2521         * tui/tui-source.h (struct tui_source_window)
2522         <erase_source_content>: New method.
2523         * tui/tui-disasm.h (struct tui_disasm_window)
2524         <erase_source_content>: New method.
2525
2526 2019-08-15  Tom Tromey  <tom@tromey.com>
2527
2528         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2529         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2530         constructor.
2531         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2532         * tui/tui-source.c (tui_set_source_content): Update.
2533         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2534
2535 2019-08-15  Tom Tromey  <tom@tromey.com>
2536
2537         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2538         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2539         tui-source.c.
2540         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2541         Declare.
2542         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2543         method.
2544         (tui_source_window::maybe_update): Update.
2545
2546 2019-08-15  Tom Tromey  <tom@tromey.com>
2547
2548         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2549         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2550         tui-disasm.c.
2551         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2552         Declare.
2553         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2554         method.
2555         (tui_disasm_window::maybe_update): Update.
2556
2557 2019-08-15  Tom Tromey  <tom@tromey.com>
2558
2559         * tui/tui-winsource.h (struct tui_source_window_base)
2560         <maybe_update>: Declare.
2561         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2562         method.
2563         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2564         Declare.
2565         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2566         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2567         Declare.
2568         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2569
2570 2019-08-15  Tom Tromey  <tom@tromey.com>
2571
2572         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2573
2574 2019-08-15  Tom Tromey  <tom@tromey.com>
2575
2576         * tui/tui-wingeneral.c: Include tui-stack.h.
2577         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2578         (struct tui_locator_window): Move from tui-data.h.
2579         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2580         (tui_initialize_static_data): Move from tui-data.c.
2581         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2582         (struct tui_locator_window): Move to tui-stack.c.
2583         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2584         (tui_initialize_static_data): Move to tui-stack.c.
2585
2586 2019-08-15  Tom Tromey  <tom@tromey.com>
2587
2588         * tui/tui-layout.c (show_source_disasm_command)
2589         (show_source_or_disasm_and_command): Use make_visible method, not
2590         tui_make_window.
2591         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2592         Remove.
2593
2594 2019-08-15  Tom Tromey  <tom@tromey.com>
2595
2596         * tui/tui-wingeneral.h (tui_make_window): Update.
2597         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2598         parameter.
2599         (tui_gen_win_info::make_visible): Update.
2600         * tui/tui-regs.c (tui_data_window::display_registers_from):
2601         Update.
2602         * tui/tui-layout.c (show_source_disasm_command)
2603         (show_source_or_disasm_and_command): Update.
2604         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2605         (enum tui_box): Remove.
2606         (struct tui_win_info) <can_box>: New method.
2607         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2608         method.
2609
2610 2019-08-15  Tom de Vries  <tdevries@suse.de>
2611
2612         * linux-nat-trad.c: Include gdbarch.h.
2613
2614 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2615
2616         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2617         register sizes.
2618
2619 2019-08-14  Tom Tromey  <tromey@adacore.com>
2620
2621         * darwin-nat.c: Include gdbarch.h.
2622         * darwin-nat-info.c: Include gdbarch.h.
2623
2624 2019-08-13  Tom Tromey  <tom@tromey.com>
2625
2626         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2627         Remove.
2628         * tui/tui-data.c (tui_initialize_static_data): Update.
2629
2630 2019-08-13  Tom Tromey  <tom@tromey.com>
2631
2632         * tui/tui-winsource.h (struct tui_exec_info_window)
2633         <~tui_exec_info_window, maybe_allocate_content, get_content,
2634         m_content>: Remove.
2635         (struct tui_source_window_base) <set_exec_info_content,
2636         show_exec_info_content>: Don't declare.
2637         * tui/tui-winsource.c
2638         (tui_exec_info_window::maybe_allocate_content): Remove.
2639         (tui_source_window_base::update_exec_info): Rename from
2640         set_exec_info_content.
2641         (tui_source_window_base::show_exec_info_content)
2642         (tui_source_window_base::update_exec_info): Remove.
2643
2644 2019-08-13  Tom Tromey  <tom@tromey.com>
2645
2646         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2647         declare.
2648         * tui/tui-winsource.c (tui_update_source_window_as_is)
2649         (tui_update_source_windows_with_addr, tui_erase_source_content):
2650         Update.
2651         (tui_clear_exec_info_content): Remove.
2652
2653 2019-08-13  Tom Tromey  <tom@tromey.com>
2654
2655         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2656         declare.
2657         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2658         call tui_erase_exec_info_content.
2659         (tui_clear_exec_info_content): Rename from
2660         tui_erase_exec_info_content.
2661         (tui_clear_exec_info_content): Delete.
2662
2663 2019-08-13  Tom Tromey  <tom@tromey.com>
2664
2665         * tui/tui-winsource.h (struct tui_source_window_base)
2666         <show_exec_info_content>: Declare.
2667         (tui_show_exec_info_content): Don't declare.
2668         * tui/tui-winsource.c
2669         (tui_source_window_base::show_exec_info_content): Rename from
2670         tui_show_exec_info_content.
2671         (tui_source_window_base::update_exec_info): Update.
2672
2673 2019-08-13  Tom Tromey  <tom@tromey.com>
2674
2675         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2676         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2677         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2678         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2679         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2680         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2681         ... here.
2682
2683 2019-08-13  Tom Tromey  <tom@tromey.com>
2684
2685         * tui/tui-winsource.h (struct tui_source_window_base)
2686         <update_exec_info>: Declare.
2687         (tui_update_exec_info): Don't declare.
2688         * tui/tui-winsource.c (tui_update_source_window_as_is)
2689         (tui_source_window_base::refresh_all)
2690         (tui_update_all_breakpoint_info): Update.
2691         (tui_source_window_base::update_exec_info): Rename from
2692         tui_update_exec_info.
2693         * tui/tui-stack.c (tui_show_frame_info): Update.
2694
2695 2019-08-13  Tom Tromey  <tom@tromey.com>
2696
2697         * tui/tui-winsource.h (struct tui_source_window_base)
2698         <set_exec_info_content>: Declare.
2699         (tui_set_exec_info_content): Don't declare.
2700         * tui/tui-winsource.c
2701         (tui_source_window_base::set_exec_info_content): Rename from
2702         tui_set_exec_info_content.
2703         (tui_update_exec_info): Update.
2704
2705 2019-08-13  Tom Tromey  <tom@tromey.com>
2706
2707         * tui/tui-winsource.h (struct tui_source_window_base)
2708         <show_source_content>: Declare.
2709         (tui_show_source_content): Don't declare.
2710         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2711         (tui_source_window_base::show_source_content): Rename from
2712         tui_show_source_content.
2713         (tui_source_window_base::refresh_all): Update.
2714         * tui/tui-layout.c (show_source_disasm_command)
2715         (show_source_or_disasm_and_command): Update.
2716
2717 2019-08-13  Tom Tromey  <tom@tromey.com>
2718
2719         * tui/tui-winsource.c (tui_erase_source_content)
2720         (tui_show_source_content, tui_source_window_base::refresh_all):
2721         Update.
2722         * tui/tui-wingeneral.h
2723         (tui_check_and_display_highlight_if_needed): Don't declare.
2724         * tui/tui-wingeneral.c
2725         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2726         check_and_display_highlight_if_needed.
2727         * tui/tui-win.c (tui_rehighlight_all)
2728         (tui_win_info::make_visible_with_new_height): Update.
2729         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2730         (tui_data_window::erase_data_content)
2731         (tui_data_window::display_all_data): Update.
2732         * tui/tui-data.h (struct tui_win_info)
2733         <check_and_display_highlight_if_needed>: Declare.
2734
2735 2019-08-13  Tom Tromey  <tom@tromey.com>
2736
2737         * tui/tui-win.c (tui_resize_all): Call
2738         tui_delete_invisible_windows.
2739         * tui/tui-layout.c (show_layout): Call
2740         tui_delete_invisible_windows.
2741         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2742         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2743
2744 2019-08-13  Tom Tromey  <tom@tromey.com>
2745
2746         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2747         tui_add_win_to_layout.
2748
2749 2019-08-13  Tom Tromey  <tom@tromey.com>
2750
2751         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2752         * tui/tui-layout.c (tui_default_win_height): Now static.
2753
2754 2019-08-13  Tom Tromey  <tom@tromey.com>
2755
2756         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2757         single switch.
2758         (show_source_disasm_command, show_source_or_disasm_and_command):
2759         Don't check current layout.
2760
2761 2019-08-13  Tom Tromey  <tom@tromey.com>
2762
2763         * tui/tui-wingeneral.c (make_all_visible): Remove.
2764         (tui_make_all_invisible): Simplify.
2765         * tui/tui-layout.c (tui_make_all_invisible): Move from
2766         tui-wingeneral.c; simplify.
2767         (show_layout): Hoist call to tui_make_all_invisible.
2768         (show_data): Don't call tui_make_all_invisible.
2769
2770 2019-08-13  Tom Tromey  <tom@tromey.com>
2771
2772         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2773         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2774
2775 2019-08-13  Tom Tromey  <tom@tromey.com>
2776
2777         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2778         tui-data.c.
2779         (show_source_disasm_command, show_data)
2780         (show_source_or_disasm_and_command): Don't use
2781         tui_set_current_layout_to.
2782         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2783         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2784         tui-layout.c.
2785         (tui_set_current_layout_to): Remove.
2786
2787 2019-08-13  Tom Tromey  <tom@tromey.com>
2788
2789         * tui/tui-layout.c (tui_set_layout): Update.
2790         * tui/tui-data.h (struct tui_layout_def): Remove.
2791         (tui_layout_def): Don't declare.
2792         * tui/tui-data.c (layout_def): Remove.
2793         (tui_layout_def): Remove.
2794
2795 2019-08-13  Tom Tromey  <tom@tromey.com>
2796
2797         * tui/tui-winsource.h (struct tui_source_window_base)
2798         <clear_detail>: No longer "override".
2799         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2800         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2801         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2802         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2803         Remove.
2804         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2805
2806 2019-08-13  Tom Tromey  <tromey@adacore.com>
2807
2808         * tracepoint.c: Don't include readline.h or history.h.
2809
2810 2019-08-12  Tom Tromey  <tom@tromey.com>
2811
2812         * configure: Rebuild.
2813         * configure.ac: Check for readline 7.
2814         * NEWS: Mention readline 7 requirement.
2815         * README: Update.
2816
2817 2019-08-12  Tom Tromey  <tom@tromey.com>
2818
2819         * mingw-hdep.c (gdb_select): Remove readline hack.
2820
2821 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2822
2823         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2824         when the function fails.
2825
2826 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2827
2828         * s390-tdep.c (s390_type_align): New function.
2829         (s390_gdbarch_init): Set it as type_align gdbarch method.
2830
2831 2019-08-09  Tom de Vries  <tdevries@suse.de>
2832
2833         PR gdb/24591
2834         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2835         pc_low with relocation offset.
2836
2837 2019-08-07  Tom Tromey  <tromey@adacore.com>
2838
2839         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2840         (print_frame_args): Update.
2841         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2842         Update.
2843         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2844         * frame.h (struct frame_arg): Add initializers.
2845         <error>: Now a unique_xmalloc_ptr.
2846
2847 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2848
2849         * NEWS: Expand the Pointer Authentication entry.
2850         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2851         (aarch64_frame_unmask_lr): ... to this.
2852         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2853         Call aarch64_frame_unmask_lr.
2854         * frame.c (struct frame_info): Add "masked" variable.
2855         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2856         (fprint_frame): Check for masked pc.
2857         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2858         declarations.
2859         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2860         * stack.c (print_frame): Check for masked pc.
2861
2862 2019-08-06  Tom Tromey  <tom@tromey.com>
2863
2864         * stabsread.c (patch_block_stabs, read_one_struct_field)
2865         (read_enum_type): Use obstack_strndup.
2866         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2867         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2868         * dwarf2read.c (guess_full_die_structure_name)
2869         (anonymous_struct_prefix): Use obstack_strndup.
2870         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2871         * c-exp.y (yylex): Use obstack_strndup.
2872         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2873         (write_var_or_type): Use obstack_strndup.
2874
2875 2019-08-06  Tom Tromey  <tom@tromey.com>
2876
2877         * symfile.c (reread_symbols): Use obstack_strdup.
2878         * stabsread.c (read_type): Use obstack_strdup.
2879         * gdb_obstack.h (obstack_strdup): New overload.
2880         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2881         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2882         (dwarf2_canonicalize_name): Use obstack_strdup.
2883         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2884         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2885         Use obstack_strdup.
2886
2887 2019-08-06  Tom Tromey  <tom@tromey.com>
2888
2889         * gdb_obstack.h (obstack_strdup): Define.
2890         * gdb_obstack.c (obstack_strdup): Don't define.
2891
2892 2019-08-06  Tom Tromey  <tom@tromey.com>
2893
2894         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2895         obstack_strdup.
2896         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2897         obstack_strdup.
2898         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2899         * stabsread.c (common_block_start): Use obstack_strdup.
2900         * objfiles.c (set_objfile_main_name, objfile): Use
2901         obstack_strdup.
2902         * namespace.c (add_using_directive): Use obstack_strdup.
2903         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2904         * jit.c (finalize_symtab): Use obstack_strdup.
2905         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2906         (guess_partial_die_structure_name, partial_die_info::fixup)
2907         (dwarf2_name): Use obstack_strdup.
2908         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2909         obstack_strdup.
2910         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2911         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2912         obstack_strdup.
2913         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2914
2915 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2916
2917         * unittests/help-doc-selftests.c: New file.
2918         * Makefile.in: Add the new file.
2919
2920 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2921
2922         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2923         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2924         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2925         the trailing '.' is not output, and the first character is uppercased.
2926         (print_help_for_command): Update call to print_doc_line.
2927         (print_doc_of_command): Likewise.
2928         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2929         * cli/cli-option.c (append_indented_doc): Do not append newline.
2930         (build_help_option): Append newline after first appended_indented_doc
2931         only if a second call is done.
2932         (build_help): Append 2 new lines before each option, except the first
2933         one.
2934         * compile/compile.c (_initialize_compile): Add new lines after
2935         %OPTIONS%, when not at the end of the help.
2936         Change help doc or code
2937         producing the help doc to respect the invariants.
2938         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2939         Also removed the new line after 'Options:', as all other commands
2940         do not put an empty line between 'Options:' and the first option.
2941         * printcmd.c (_initialize_printcmd): Likewise.
2942         * stack.c (_initialize_stack): Likewise.
2943         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2944         incorrectly telling COMMAND is optional.
2945         * ada-lang.c (_initialize_ada_language): Change help doc or code
2946         producing the help doc to respect the invariants.
2947         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2948         * breakpoint.c (_initialize_breakpoint): Likewise.
2949         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2950         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2951         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2952         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2953         _initialize_cli_style): Likewise.
2954         * corelow.c (core_target_info): Likewise.
2955         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2956         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2957         * filesystem.c (_initialize_filesystem): Likewise.
2958         * frame.c (_initialize_frame): Likewise.
2959         * gnu-nat.c (add_task_commands): Likewise.
2960         * infcall.c (_initialize_infcall): Likewise.
2961         * infcmd.c (_initialize_infcmd): Likewise.
2962         * interps.c (_initialize_interpreter): Likewise.
2963         * language.c (_initialize_language): Likewise.
2964         * linux-fork.c (_initialize_linux_fork): Likewise.
2965         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2966         * maint.c (_initialize_maint_cmds): Likewise.
2967         * memattr.c (_initialize_mem): Likewise.
2968         * printcmd.c (_initialize_printcmd): Likewise.
2969         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2970         _RegEx): Likewise.
2971         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2972         * record-btrace.c (_initialize_record_btrace): Likewise.
2973         * record-full.c (_initialize_record_full): Likewise.
2974         * record.c (_initialize_record): Likewise.
2975         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2976         * regcache.c (_initialize_regcache): Likewise.
2977         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2978         _initialize_remote): Likewise.
2979         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2980         * serial.c (_initialize_serial): Likewise.
2981         * skip.c (_initialize_step_skip): Likewise.
2982         * source.c (_initialize_source): Likewise.
2983         * stack.c (_initialize_stack): Likewise.
2984         * symfile.c (_initialize_symfile): Likewise.
2985         * symtab.c (_initialize_symtab): Likewise.
2986         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2987         * top.c (init_main): Likewise.
2988         * tracefile-tfile.c (tfile_target_info): Likewise.
2989         * tracepoint.c (_initialize_tracepoint): Likewise.
2990         * tui/tui-win.c (_initialize_tui_win): Likewise.
2991         * utils.c (add_internal_problem_command): Likewise.
2992         * valprint.c (value_print_option_defs): Likewise.
2993
2994 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2995
2996         PR build/24886
2997         * configure.ac: Drop enable-libmcheck support.
2998         * configure, config.in: Rebuild.
2999         * libmcheck.m4: Remove.
3000         * acinclude.m4: Don't include it.
3001         * Makefile.in: Don't distribute it.
3002         * top.c (print_gdb_configuration): Don't mention it.
3003
3004 2019-08-06  Tom Tromey  <tom@tromey.com>
3005
3006         * utils.c (set_output_style): Sometimes pass stream to
3007         emit_style_escape.
3008         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3009         * record-btrace.c (btrace_insn_history): Update.
3010         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3011         method.
3012         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3013         Update initializers.
3014         <m_uiout>: New field.
3015         <m_di>: Move lower.
3016         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3017         Remove "uiout" parameter.
3018         (dump_insns): Update.
3019         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3020         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3021
3022 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3023
3024         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3025         (error_in_psymtab_expansion): Likewise.
3026         (lookup_symbol_via_quick_fns): Likewise.
3027         (basic_lookup_transparent_type_quick): Likewise.
3028         (basic_lookup_transparent_type_1): Likewise.
3029
3030 2019-08-06  Tom Tromey  <tromey@adacore.com>
3031
3032         * source.c (last_source_error): Now bool.
3033         (print_source_lines_base): Make "noprint" bool.  Only open
3034         source file when last_source_visited changes.
3035
3036 2019-08-06  Tom Tromey  <tromey@adacore.com>
3037
3038         * annotate.c (annotate_source_line): Use g_source_cache.
3039         * source-cache.c (source_cache::get_plain_source_lines): Change
3040         parameters.  Populate m_offset_cache.
3041         (source_cache::ensure): New method.
3042         (source_cache::get_line_charpos): New method.
3043         (extract_lines): Move lower.  Change parameters.
3044         (source_cache::get_source_lines): Move lower.
3045         * source-cache.h (class source_cache): Update comment.
3046         <get_line_charpos>: New method.
3047         <get_source_lines>: Update comment.
3048         <clear>: Clear m_offset_cache.
3049         <get_plain_source_lines>: Change parameters.
3050         <ensure>: New method
3051         <m_offset_cache>: New member.
3052         * source.c (forget_cached_source_info_for_objfile): Update.
3053         (info_source_command): Use g_source_cache.
3054         (find_source_lines, open_source_file_with_line_charpos): Remove.
3055         (print_source_lines_base, search_command_helper): Use g_source_cache.
3056         * source.h (open_source_file_with_line_charpos): Don't declare.
3057         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3058         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3059         Use g_source_cache.
3060
3061 2019-08-06  Tom Tromey  <tromey@adacore.com>
3062
3063         * source-cache.c (source_cache::get_plain_source_lines):
3064         Remove "first_line" and "last_line" parameters.
3065         (source_cache::get_source_lines): Cache plain text.
3066         * source-cache.h (class source_cache)
3067         <get_plain_source_lines>: Update.
3068
3069 2019-08-06  Tom Tromey  <tromey@adacore.com>
3070
3071         * source-cache.c (extract_lines): No longer a method.
3072         Changed type of parameter.  Include final newline.
3073         (selftests::extract_lines_test): New function.
3074         (_initialize_source_cache): Likewise.
3075         * source-cache.h (class source_cache)
3076         <extract_lines>: Don't declare.
3077
3078 2019-08-06  Tom Tromey  <tromey@adacore.com>
3079
3080         * breakpoint.c (init_breakpoint_sal): Update.
3081         (breakpoint): Update.
3082         * breakpoint.h (struct breakpoint) <filter>: Now a
3083         unique_xmalloc_ptr.
3084
3085 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3086
3087         * NEWS: Mention dictionary access on blocks.
3088         * python/py-block.c (blpy_getitem): New function.
3089         (block_object_as_mapping): New struct.
3090         (block_object_type): Use new struct for tp_as_mapping field.
3091
3092 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3093
3094         * objfiles.h (objfile): Add a comment describing partial symbols.
3095
3096 2019-08-05  Tom Tromey  <tromey@adacore.com>
3097
3098         * compile/compile.c (_initialize_compile): Use _(), not N_().
3099         * thread.c (_initialize_thread): Use _(), not N_().
3100         * stack.c (_initialize_stack): Use _(), not N_().
3101         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3102
3103 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3104
3105         * dwarf2read.c (struct dw2_symtab_iterator):
3106         <want_specific_block>: Remove.
3107         <block_index>: Change type to gdb::optional.
3108         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3109         change type of BLOCK_INDEX parameter to gdb::optional.
3110         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3111         (dw2_lookup_symbol): Don't pass argument for
3112         WANT_SPECIFIC_BLOCK.
3113         (dw2_expand_symtabs_for_function): Don't pass argument for
3114         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3115         (class dw2_debug_names_iterator)
3116         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3117         parameter, change BLOCK_INDEX type to gdb::optional.
3118         <m_want_specific_block>: Remove.
3119         <m_block_index>: Change type to gdb::optional.
3120         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3121         gdb::optional.  Re-write in function of gdb::optional.
3122         (dw2_debug_names_lookup_symbol): Don't pass argument for
3123         WANT_SPECIFIC_BLOCK.
3124         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3125         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3126         BLOCK_INDEX.
3127
3128 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3129
3130         * NEWS: Mention changes to "info sources" command.
3131
3132 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3133
3134         * symtab.c (filename_partial_match_opts): New struct type.
3135         (struct output_source_filename_data): New members
3136         regexp, c_regexp, partial_match.
3137         (output_source_filename): Use new members to decide to print file.
3138         (info_sources_option_defs): New variable.
3139         (make_info_sources_options_def_group, print_info_sources_header,
3140         info_sources_command_completer):
3141         New functions.
3142         (info_sources_command): Read new optional arguments.
3143         (_initialize_symtab): Update info sources help.
3144
3145 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3146
3147         * ada-lang.c (exception_support_info_v0): Renamed from...
3148         (default_exception_support_info): ... this.  Create new
3149         definition for v1.
3150         (ada_has_this_exception_support): Look up catch_handlers_sym.
3151         (ada_exception_support_info_sniffer): Try v0 after default.
3152
3153 2019-08-01  Tom Tromey  <tromey@adacore.com>
3154
3155         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3156         gdbarch.h.
3157
3158 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3159
3160         * s12z-tdep.c: Fix include path for s12z-opc.h.
3161
3162 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3163
3164         * NEWS: Require GNU make 3.82.
3165
3166 2019-07-16  Tom Tromey  <tom@tromey.com>
3167
3168         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3169         declare.
3170
3171 2019-07-30  Tom Tromey  <tromey@adacore.com>
3172
3173         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3174
3175 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3176
3177         * printcmd.c (print_address_symbolic): Print negative offsets.
3178         (build_address_symbolic): Force signed arithmetic when computing
3179         offset.
3180
3181 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3182
3183         PR/24474: Add a function to lookup static variables.
3184         * NEWS: Mention this new function.
3185         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3186         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3187         * python/python.c (python_GdbMethods): Add new function.
3188
3189 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3190
3191         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3192         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3193         (objfpy_lookup_static_symbol): New function.
3194         (objfile_object_methods): Add new functions.
3195
3196 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3197
3198         * NEWS: Mention 'set|show print frame-info'.  Mention new
3199         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3200         backtrace argument.  Mention that python frame filtering code
3201         is now consistent with what 'backtrace' command prints.
3202
3203 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3204
3205         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3206         comments.
3207         (print_frame_info_auto, print_frame_info_source_line,
3208         print_frame_info_location, print_frame_info_source_and_location,
3209         print_frame_info_location_and_address, print_frame_info_short_location):
3210         New declarations.
3211         (struct frame_print_options): New member print_frame_info.
3212         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3213         * stack.h (get_user_print_what_frame_info): New declaration.
3214         (frame_show_address): New declaration.
3215         * stack.c (print_frame_arguments_choices): New value 'presence'.
3216         (print_frame_info_auto, print_frame_info_source_line,
3217         print_frame_info_location, print_frame_info_source_and_location,
3218         print_frame_info_location_and_address, print_frame_info_short_location,
3219         print_frame_info_choices, print_frame_info_print_what): New definitions.
3220         (print_frame_args): Only print dots for args if print frame-arguments
3221         is 'presence'.
3222         (frame_print_option_defs): New element for "frame-info".
3223         (get_user_print_what_frame_info): New function.
3224         (frame_show_address): Make non static.  Move comment to stack.h.
3225         (print_frame_info_to_print_what): New function.
3226         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3227         to decide what to print.
3228         (backtrace_command_1): Handle the new print_frame_arguments_presence
3229         value.
3230         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3231         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3232         (py_print_frame): In non-mi mode, use LOCATION as default for
3233         print_what, similarly to frame information printed directly by
3234         backtrace command. Handle frame-info user option in non MI mode.
3235
3236 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3237
3238         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3239         Add case for debugging 32-bit target on 64-bit host.  Revise
3240         comment.
3241
3242 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3243
3244         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3245         instead of find_function_entry_range_from_pc.
3246
3247 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3248
3249         * stack.c (find_frame_funname): Remove code which preferred
3250         minsym over symtab sym in "certain pathological cases".
3251
3252         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3253         parameter.  Change type of "do_demangle" to bool.
3254         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3255         Pass suitable "prefer_sym_over_minsym" flag to
3256         build_address_symbolic().  Don't output "+" for negative offsets.
3257         * printcmd.c (print_address_symbolic): Update invocation of
3258         build_address_symbolic to include a "prefer_sym_over_minsym"
3259         flag.
3260         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3261         Restrict cases in which use of minimal symbol is preferred to that
3262         of a found symbol.  Update comments.
3263
3264         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3265         for entry pc when entry pc is out of range for that FDE.
3266
3267 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3268
3269         PR gdb/24839:
3270         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3271         type.
3272
3273 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3274
3275         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3276         this function's Python signature.
3277
3278
3279 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3280
3281         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3282         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3283         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3284         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3285         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3286
3287
3288 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3289
3290         * h8300-tdep.c (h8300_register_name_common): New.
3291         h8300_register_name): Use h8300_register_name_common.
3292         (h8300s_register_name): Likewise.
3293         (h8300sx_register_name): Likewise.
3294         (h8300h_register_nam): New.
3295         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3296
3297
3298 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3299
3300         * arm-tdep.c (arm_skip_cmse_entry): New function.
3301         (arm_is_sgstubs_section): New function.
3302         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3303
3304 2019-07-22  Tom Tromey  <tom@tromey.com>
3305
3306         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3307         Don't self-assign.
3308
3309 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3310
3311         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3312         type_print.
3313
3314 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3315
3316         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3317         so that GDB doesn't match any msymbols when searching in the
3318         TYPES_DOMAIN.
3319         (print_symbol_info): Print using typedef_print or type_print based
3320         on the type of the symbol.  Add updated FIXME comment moved from...
3321         (_initialize_symtab): ... move and update FIXME comment to above.
3322
3323 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3324
3325         * NEWS: Mention adding -q option to "info types".
3326         * symtab.c (struct info_types_options): New struct.
3327         (info_types_options_defs): New variable.
3328         (make_info_types_options_def_group): New function.
3329         (info_types_command): Use gdb::option framework to parse options.
3330         (info_types_command_completer): New function.
3331         (_initialize_symtab): Extend the help text on "info types" and
3332         register command completer.
3333
3334 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3335
3336         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3337         (lookup_symbol_in_objfile): Change int to block_enum and add a
3338         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3339
3340 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3341
3342         * MAINTAINERS (Write After Approval): Add self.
3343
3344 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3345
3346         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3347         instruction to the dummy code region.
3348
3349 2019-07-19  Tom Tromey  <tromey@adacore.com>
3350
3351         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3352         (ARGSUSED, PARAMS, __func__): Remove rules.
3353
3354 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3355
3356         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3357         * features/arm/arm-with-iwmmxt.c: Remove.
3358         * features/arm/arm-with-iwmmxt.xml: Remove.
3359         * features/arm/arm-with-m-fpa-layout.c: Remove.
3360         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3361         * features/arm/arm-with-m-vfp-d16.c: Remove.
3362         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3363         * features/arm/arm-with-m.c: Remove.
3364         * features/arm/arm-with-m.xml: Remove.
3365         * features/arm/arm-with-neon.c: Remove.
3366         * features/arm/arm-with-neon.xml: Remove.
3367         * features/arm/arm-with-vfpv2.c: Remove.
3368         * features/arm/arm-with-vfpv2.xml: Remove.
3369         * features/arm/arm-with-vfpv3.c: Remove.
3370         * features/arm/arm-with-vfpv3.xml: Remove.
3371
3372 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3373
3374         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3375
3376 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3377
3378         * arch/aarch32.c (aarch32_create_target_description): Create
3379         target descriptions using features.
3380         * arch/arm.c (arm_create_target_description)
3381         (arm_create_mprofile_target_description): Likewise.
3382         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3383
3384 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3385
3386         * Makefile.in: Add new files.
3387         * aarch32-tdep.c: New file.
3388         * aarch32-tdep.h: New file.
3389         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3390         Call aarch32_read_description.
3391         * arch/aarch32.c: New file.
3392         * arch/aarch32.h: New file.
3393         * arch/arm.c (arm_create_target_description)
3394         (arm_create_mprofile_target_description): New function.
3395         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3396         (arm_create_target_description)
3397         (arm_create_mprofile_target_description): New declaration.
3398         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3399         read_description functions.
3400         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3401         Likewise.
3402         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3403         * arm-tdep.c (tdesc_arm_list): New variable.
3404         (arm_register_g_packet_guesses): Call create description functions.
3405         (arm_read_description) (arm_read_mprofile_description): New
3406         function.
3407         * arm-tdep.h (arm_read_description)
3408         (arm_read_mprofile_description): Add declaration.
3409         * configure.tgt: Add new files.
3410
3411 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3412
3413         * top.c (new_ui_command): Open specified terminal just once.
3414
3415 2019-07-18  Tom Tromey  <tromey@adacore.com>
3416
3417         * symtab.c (main_name): Constify return type.
3418         * symfile.c (set_initial_language): Update.
3419         * symtab.h (main_name): Constify return type.
3420
3421 2019-07-17  Tom Tromey  <tom@tromey.com>
3422
3423         * tui/tui-winsource.c (tui_update_source_window)
3424         (tui_update_source_window_as_is)
3425         (tui_update_source_windows_with_line): Remove return.
3426         * tui/tui-disasm.c (tui_show_disassem)
3427         (tui_show_disassem_and_update_source): Remove return.
3428         * tui/tui.c (tui_reset): Remove return.
3429         * tui/tui-wingeneral.c
3430         (tui_check_and_display_highlight_if_needed): Remove return.
3431
3432 2019-07-17  Tom Tromey  <tom@tromey.com>
3433
3434         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3435
3436 2019-07-17  Tom Tromey  <tom@tromey.com>
3437
3438         * tui/tui-winsource.h (struct tui_exec_info_window)
3439         (struct tui_source_window_base): Move from tui-data.h.
3440         * tui/tui-winsource.c: Move many method definitions from
3441         elsewhere.  Remove "structuring" comments.
3442         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3443         (tui_source_window_base::refresh_window): Move to
3444         tui-winsource.c.
3445         * tui/tui-win.c (tui_source_window_base::refresh_all)
3446         (tui_source_window_base::update_tab_width)
3447         (tui_source_window_base::set_new_height)
3448         (tui_source_window_base::do_make_visible_with_new_height): Move to
3449         tui-winsource.c.
3450         * tui/tui-source.h: Update.
3451         * tui/tui-source.c (tui_source_window_base::reset): Move to
3452         tui-winsource.c.
3453         * tui/tui-disasm.h: Update.
3454         * tui/tui-data.h (struct tui_exec_info_window): Move to
3455         tui-winsource.h.
3456         (struct tui_source_window_base): Likewise.
3457         * tui/tui-data.c (tui_source_window_base::clear_detail)
3458         (tui_source_window_base, ~tui_source_window_base): Move to
3459         tui-winsource.c.
3460
3461 2019-07-17  Tom Tromey  <tom@tromey.com>
3462
3463         * tui/tui-win.c (tui_resize_all)
3464         (tui_source_window_base::update_tab_width)
3465         (tui_adjust_win_heights): Update.
3466         (tui_win_info::make_invisible_and_set_new_height): Rename from
3467         make_invisible_and_set_new_height.
3468         * tui/tui-data.h (struct tui_win_info)
3469         <make_invisible_and_set_new_height>: New method.
3470
3471 2019-07-17  Tom Tromey  <tom@tromey.com>
3472
3473         * tui/tui.c: Update.
3474         * tui/tui-source.h (struct tui_source_window): Move from
3475         tui-data.h.
3476         * tui/tui-layout.c: Update.
3477         * tui/tui-disasm.c: Update.
3478         * tui/tui-data.h (struct tui_source_window): Move to
3479         tui-source.h.
3480
3481 2019-07-17  Tom Tromey  <tom@tromey.com>
3482
3483         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3484         tui-data.h.
3485         * tui/tui-data.h (struct tui_disasm_window): Move to
3486         tui-disasm.h.
3487
3488 2019-07-17  Tom Tromey  <tom@tromey.com>
3489
3490         * tui/tui-regs.h (struct tui_data_item_window): Move from
3491         tui-data.h.
3492         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3493         * tui/tui-data.h (struct tui_data_item_window): Move to
3494         tui-regs.h.
3495         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3496
3497 2019-07-17  Tom Tromey  <tom@tromey.com>
3498
3499         * tui/tui.c: Update.
3500         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3501         (tui_cmd_window::max_height): Move to tui-command.c.
3502         * tui/tui-layout.c: Update.
3503         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3504         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3505         tui-command.c.
3506         * tui/tui-command.h (struct tui_cmd_window): Move from
3507         tui-data.h.
3508         * tui/tui-command.c: Remove "structuring" comments.
3509         (tui_cmd_window::clear_detail)
3510         (tui_cmd_window::do_make_visible_with_new_height)
3511         (tui_cmd_window::max_height): Move from elsewhere.
3512
3513 2019-07-17  Tom Tromey  <tom@tromey.com>
3514
3515         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3516         Now static.
3517         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3518         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3519
3520 2019-07-17  Tom Tromey  <tom@tromey.com>
3521
3522         * tui/tui.c: Update.
3523         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3524         tui-regs.c.
3525         * tui/tui-windata.h: Remove file.
3526         * tui/tui-windata.c: Remove file.
3527         * tui/tui-win.c (tui_data_window::set_new_height)
3528         (tui_data_window::do_make_visible_with_new_height): Move to
3529         tui-regs.c.
3530         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3531         * tui/tui-regs.c: Remove "structuring" comments.
3532         (tui_data_window::first_data_item_displayed)
3533         (tui_data_window::delete_data_content_windows)
3534         (tui_data_window::erase_data_content)
3535         (tui_data_window::display_all_data)
3536         (tui_data_window::refresh_all)
3537         (tui_data_window::do_scroll_vertical)
3538         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3539         (tui_data_window::do_make_visible_with_new_height)
3540         (tui_data_window::refresh_window): Move from elsewhere.
3541         (_initialize_tui_regs): Move to end of file.
3542         * tui/tui-layout.c: Update.
3543         * tui/tui-hooks.c: Update.
3544         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3545         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3546         tui-regs.c.
3547         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3548
3549 2019-07-17  Tom Tromey  <tom@tromey.com>
3550
3551         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3552         seen.
3553
3554 2019-07-17  Tom Tromey  <tom@tromey.com>
3555
3556         * tui/tui-win.c (tui_source_window_base::set_new_height)
3557         (tui_source_window_base::do_make_visible_with_new_height): Use
3558         m_has_locator field directly.
3559         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3560         method.
3561         (struct tui_source_window_base) <has_locator>: Likewise.
3562
3563 2019-07-17  Tom Tromey  <tom@tromey.com>
3564
3565         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3566         Don't declare.
3567         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3568         Remove.
3569         * tui/tui-win.c (tui_source_window_base::set_new_height)
3570         (tui_source_window_base::set_new_height)
3571         (make_invisible_and_set_new_height)
3572         (tui_source_window_base::do_make_visible_with_new_height)
3573         (tui_source_window_base::do_make_visible_with_new_height):
3574         Update.
3575         * tui/tui-layout.c (show_source_disasm_command, show_data)
3576         (show_source_or_disasm_and_command): Update.
3577         * tui/tui-layout.c (show_layout): Update.
3578
3579 2019-07-17  Tom Tromey  <tom@tromey.com>
3580
3581         * tui/tui-layout.c (make_data_window): Remove.
3582         (show_data): Unify creation and re-initialization cases.
3583
3584 2019-07-17  Tom Tromey  <tom@tromey.com>
3585
3586         * tui/tui-layout.c (make_source_window, make_disasm_window):
3587         Remove.
3588         (show_data): Unify creation and re-initialization cases.
3589
3590 2019-07-17  Tom Tromey  <tom@tromey.com>
3591
3592         * tui/tui-layout.c (make_command_window): Remove.
3593         (show_source_disasm_command, show_source_or_disasm_and_command):
3594         Unify creation and re-initialization cases.
3595
3596 2019-07-17  Tom Tromey  <tom@tromey.com>
3597
3598         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3599         creation and re-initialization cases.
3600
3601 2019-07-17  Tom Tromey  <tom@tromey.com>
3602
3603         * tui/tui-regs.c (tui_get_register): Return void.
3604
3605 2019-07-17  Tom Tromey  <tom@tromey.com>
3606
3607         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3608         Simplify.
3609
3610 2019-07-17  Tom Tromey  <tom@tromey.com>
3611
3612         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3613         resetting.
3614
3615 2019-07-17  Tom Tromey  <tom@tromey.com>
3616
3617         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3618         * tui/tui-regs.c (tui_reg_layout): New function.
3619         (tui_show_registers, tui_reg_command): Use it.
3620         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3621         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3622         parameters.
3623         (tui_layout_command): Remove.
3624
3625 2019-07-17  Tom Tromey  <tom@tromey.com>
3626
3627         * tui/tui-layout.h (tui/tui-layout): Return void.
3628         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3629
3630 2019-07-17  Tom Tromey  <tom@tromey.com>
3631
3632         * tui/tui-layout.c (show_source_disasm_command, show_data):
3633         Update.
3634         (reset_locator): Remove.
3635         (show_source_or_disasm_and_command): Update.
3636
3637 2019-07-17  Tom Tromey  <tom@tromey.com>
3638
3639         * tui/tui-source.c (tui_source_window_base::reset): Remove
3640         win_type parameter.
3641         * tui/tui-layout.c (make_command_window, make_source_window)
3642         (make_disasm_window, make_data_window)
3643         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3644         (reset_locator, show_source_or_disasm_and_command): Update.
3645         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3646         win_type parameter.
3647         (struct tui_source_window_base) <reset>: Likewise.
3648
3649 2019-07-17  Tom Tromey  <tom@tromey.com>
3650
3651         * tui/tui-layout.c (show_source_disasm_command): Use
3652         reset_locator.
3653         (reset_locator): New function.
3654         (init_and_make_win): Remove.
3655         (show_source_or_disasm_and_command): Use reset_locator.
3656
3657 2019-07-17  Tom Tromey  <tom@tromey.com>
3658
3659         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3660         condition.
3661         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3662         Remove condition.
3663         * tui/tui-source.c (tui_source_window_base::reset): New method.
3664         * tui/tui-layout.c (make_command_window): Don't call
3665         init_and_make_win.
3666         (make_source_window, make_disasm_window): Don't call
3667         make_source_or_disasm_window.
3668         (make_data_window): Don't call init_and_make_win.  Change calling
3669         convention.
3670         (show_source_disasm_command, show_data): Simplify.
3671         (make_source_or_disasm_window): Remove.
3672         (show_source_or_disasm_and_command): Simplify.
3673         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3674         (struct tui_source_window_base) <reset>: Likewise.
3675         <execution_info>: Remove initializer.
3676         * tui/tui-data.c (tui_source_window_base): Initialize
3677         execution_info.
3678
3679 2019-07-17  Tom Tromey  <tom@tromey.com>
3680
3681         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3682         variable.
3683
3684 2019-07-17  Tom Tromey  <tom@tromey.com>
3685
3686         * tui/tui.c (tui_rl_other_window): Update.
3687         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3688         superclass method first.  Always iterate over regs_content.
3689         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3690         method.
3691         * tui/tui-win.c (tui_set_focus_command): Update.
3692
3693 2019-07-17  Tom Tromey  <tom@tromey.com>
3694
3695         * tui/tui-win.c (tui_set_focus_command): Rename from
3696         tui_set_focus.  Call tui_enable.
3697         (tui_set_focus_command): Remove.
3698
3699 2019-07-17  Tom Tromey  <tom@tromey.com>
3700
3701         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3702         refresh_window.
3703         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3704         touchwin.
3705         (tui_data_window::refresh_window): Call refresh_window on data
3706         items.  Always call superclass refresh_window.
3707         (tui_win_info::refresh): Remove.
3708         (tui_source_window_base::refresh_window): Update.
3709         (tui_refresh_all): Update.
3710         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3711         refresh_window.
3712         (show_source_or_disasm_and_command): Likewise.
3713         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3714         (struct tui_source_window_base) <refresh>: Likewise.
3715
3716 2019-07-17  Tom Tromey  <tom@tromey.com>
3717
3718         * tui/tui-winsource.c (tui_clear_source_content)
3719         (tui_show_source_content): Update.
3720         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3721         whether content is empty.
3722         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3723         Remove.
3724
3725 2019-07-17  Tom Tromey  <tom@tromey.com>
3726
3727         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3728         window's contents.
3729         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3730         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3731
3732 2019-07-17  Tom Tromey  <tom@tromey.com>
3733
3734         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3735         (struct tui_data_item_window): Update.
3736
3737 2019-07-17  Tom Tromey  <tom@tromey.com>
3738
3739         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3740         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3741         defines.
3742
3743 2019-07-17  Tom Tromey  <tom@tromey.com>
3744
3745         * tui/tui-winsource.h (tui_erase_source_content)
3746         (tui_clear_source_content): Remove "display_prompt" parameter.
3747         * tui/tui-winsource.c (tui_update_source_window_as_is)
3748         (tui_update_source_windows_with_addr): Update.
3749         (tui_clear_source_content): Remove "display_prompt" parameter.
3750         (tui_erase_source_content): Likewise.  Simplify.
3751         (tui_show_source_content): Update.
3752         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3753         * tui/tui-stack.c (tui_show_frame_info): Update.
3754         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3755         Remove defines.
3756
3757 2019-07-17  Tom Tromey  <tom@tromey.com>
3758
3759         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3760         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3761         parameter.
3762         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3763         parameter.
3764
3765 2019-07-17  Tom Tromey  <tom@tromey.com>
3766
3767         * tui/tui-winsource.c (tui_clear_source_content)
3768         (tui_show_source_content, tui_show_exec_info_content)
3769         (tui_clear_exec_info_content): Update.
3770         * tui/tui-stack.c (tui_show_locator_content): Update.
3771         (tui_show_frame_info): Update.
3772         * tui/tui-source.h (tui_source_window): Don't declare.
3773         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3774         from tui_source_is_displayed.
3775         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3776         Remove field.
3777         (struct tui_source_window_base) <content_in_use>: New field.  Now
3778         bool.
3779         (struct tui_source_window) <showing_source_p>: New method.
3780         (TUI_SRC_WIN): Change cast.
3781         * tui/tui-data.c (tui_initialize_static_data): Update.
3782
3783 2019-07-17  Tom Tromey  <tom@tromey.com>
3784
3785         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3786         location_matches_p.
3787         * tui/tui-source.c (tui_source_window::location_matches_p): New
3788         method.
3789         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3790         method.
3791         * tui/tui-data.h (struct tui_source_window_base)
3792         <location_matches_p>: New method.
3793         (struct tui_source_window, struct tui_disasm_window)
3794         <location_matches_p>: Likewise.
3795
3796 2019-07-17  Tom Tromey  <tom@tromey.com>
3797
3798         * tui/tui-win.c (tui_set_win_height_command): Rename from
3799         tui_set_win_height.
3800         (tui_set_win_height_command): Remove.
3801
3802 2019-07-17  Tom Tromey  <tom@tromey.com>
3803
3804         * tui/tui-source.c (tui_source_window): New constructor.  Add
3805         observer.
3806         (~tui_source_window): New destructor.
3807         (tui_source_window::style_changed): New method.
3808         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3809         (tui_attach_detach_observers): Update.
3810         * tui/tui-data.h (struct tui_source_window): Make constructor not
3811         inline.  Add destructor.
3812         (struct tui_source_window) <style_changed>: New method.
3813         <m_observable>: New member.
3814
3815 2019-07-17  Tom Tromey  <tom@tromey.com>
3816
3817         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3818         * tui/tui-win.c (tui_resize_all): Fix typo.
3819
3820 2019-07-17  Tom Tromey  <tom@tromey.com>
3821
3822         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3823         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3824         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3825         * tui/tui-win.c (window_name_completer): Use foreach.
3826         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3827         (update_tab_width): Likewise.
3828         * tui/tui-layout.c (show_layout): Update.
3829         * tui/tui-data.h (class tui_window_iterator): New.
3830         (struct all_tui_windows): New.
3831         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3832
3833 2019-07-17  Tom Tromey  <tom@tromey.com>
3834
3835         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3836         parameter.  Don't reference globals.
3837         (tui_reg_command): Update.
3838
3839 2019-07-17  Tom Tromey  <tom@tromey.com>
3840
3841         * tui/tui-regs.c (tui_show_registers): Simplify.
3842
3843 2019-07-17  Tom Tromey  <tom@tromey.com>
3844
3845         * tui/tui-regs.c (tui_show_registers): Update.
3846         (tui_show_register_group): Add win_info parameter.
3847
3848 2019-07-17  Tom Tromey  <tom@tromey.com>
3849
3850         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3851         Rename from tui_display_reg_element_at_line.
3852         (tui_data_window::display_registers_from_line): Update.
3853         * tui/tui-data.h (struct tui_data_window)
3854         <display_reg_element_at_line>: New method.
3855
3856 2019-07-17  Tom Tromey  <tom@tromey.com>
3857
3858         * tui/tui-regs.h (tui_display_registers_from)
3859         (tui_display_registers_from_line): Don't declare.
3860         * tui/tui-windata.c (tui_data_window::display_all_data)
3861         (tui_data_window::refresh_all)
3862         (tui_data_window::do_scroll_vertical): Update.
3863         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3864         from tui_display_registers_from.
3865         (tui_display_reg_element_at_line): Update.
3866         (tui_data_window::display_registers_from_line): Rename from
3867         tui_display_registers_from_line.
3868         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3869         display_registers_from_line>: New methods.
3870
3871 2019-07-17  Tom Tromey  <tom@tromey.com>
3872
3873         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3874         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3875         from tui_erase_data_content.
3876         (tui_data_window::display_all_data)
3877         (tui_data_window::refresh_all)
3878         (tui_data_window::do_scroll_vertical): Update.
3879         * tui/tui-regs.c (tui_show_registers): Update.
3880         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3881         New method.
3882
3883 2019-07-17  Tom Tromey  <tom@tromey.com>
3884
3885         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3886         declare.
3887         * tui/tui-windata.c
3888         (tui_data_window::delete_data_content_windows): Rename from
3889         tui_delete_data_content_windows.
3890         (tui_data_window::display_all_data)
3891         (tui_data_window::do_scroll_vertical): Update.
3892         * tui/tui-data.h (struct tui_data_window)
3893         <delete_data_content_windows>: New method.
3894
3895 2019-07-17  Tom Tromey  <tom@tromey.com>
3896
3897         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3898         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3899
3900 2019-07-17  Tom Tromey  <tom@tromey.com>
3901
3902         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3903         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3904         from tui_display_all_data.
3905         * tui/tui-win.c
3906         (tui_data_window::do_make_visible_with_new_height): Update.
3907         * tui/tui-regs.c (tui_show_registers): Update.
3908         * tui/tui-layout.c (tui_set_layout): Update.
3909         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3910         method.
3911
3912 2019-07-17  Tom Tromey  <tom@tromey.com>
3913
3914         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3915         * tui/tui-windata.c (tui_display_data_from): Remove.
3916         (tui_data_window::refresh_all): Update.
3917
3918 2019-07-17  Tom Tromey  <tom@tromey.com>
3919
3920         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3921         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3922         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3923         tui_display_registers_from_line.
3924         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3925         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3926         "force_display" parameter.
3927
3928 2019-07-17  Tom Tromey  <tom@tromey.com>
3929
3930         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3931         declare.
3932         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3933         Rename from tui_first_reg_element_no_inline.
3934         (tui_display_reg_element_at_line)
3935         (tui_display_registers_from_line): Update.
3936         * tui/tui-data.h (struct tui_data_window)
3937         <first_reg_element_no_inline>: New method.
3938
3939 2019-07-17  Tom Tromey  <tom@tromey.com>
3940
3941         * tui/tui-windata.c (tui_display_data_from)
3942         (tui_data_window::do_scroll_vertical): Update.
3943         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3944         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3945         Rename from tui_line_from_reg_element_no.
3946         (tui_display_registers_from_line): Update.
3947         * tui/tui-data.h (struct tui_data_window)
3948         <line_from_reg_element_no>: New method.
3949
3950 2019-07-17  Tom Tromey  <tom@tromey.com>
3951
3952         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3953         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3954         tui_last_regs_line_no.
3955         (tui_display_reg_element_at_line)
3956         (tui_display_registers_from_line): Update.
3957         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3958         method.
3959
3960 2019-07-17  Tom Tromey  <tom@tromey.com>
3961
3962         PR tui/24722:
3963         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3964         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3965         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3966         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3967         (tui_update_breakpoint_info): Likewise.
3968         * tui/tui-hooks.c (tui_event_create_breakpoint)
3969         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3970         Update.
3971
3972 2019-07-17  Tom Tromey  <tom@tromey.com>
3973
3974         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3975
3976 2019-07-17  Tom Tromey  <tom@tromey.com>
3977
3978         * tui/tui-winsource.c (tui_update_source_window_as_is)
3979         (tui_update_source_windows_with_addr): Update.
3980         * tui/tui-source.h (tui_set_source_content)
3981         (tui_show_symtab_source): Add "win_info" parameter.
3982         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3983         parameter.
3984         (tui_show_symtab_source): Likewise.
3985
3986 2019-07-17  Tom Tromey  <tom@tromey.com>
3987
3988         * tui/tui-wingeneral.c
3989         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3990
3991 2019-07-17  Tom Tromey  <tom@tromey.com>
3992
3993         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3994         (struct tui_cmd_window) <can_scroll>: New method.
3995         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3996         method.
3997
3998 2019-07-17  Tom Tromey  <tromey@adacore.com>
3999
4000         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4001         do_field_signed>: Rename.  Change type of "value".
4002         * ui-out.c (ui_out::field_signed): Rename from field_int.
4003         Change type of "value".
4004         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4005         type of "value".
4006         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4007         do_field_int.  Change type of "value".
4008         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4009         do_field_int.  Change type of "value".
4010         * tracepoint.c (trace_status_mi, tfind_1)
4011         (print_one_static_tracepoint_marker): Update.
4012         * thread.c (print_thread_info_1, print_selected_thread_frame):
4013         Update.
4014         * stack.c (print_frame, print_frame_info): Update.
4015         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4016         Update.
4017         * source.c (print_source_lines_base): Update.
4018         * skip.c (info_skip_command): Update.
4019         * record-btrace.c (btrace_ui_out_decode_error)
4020         (btrace_call_history_src_line): Update.
4021         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4022         Update.
4023         * progspace.c (print_program_space): Update.
4024         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4025         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4026         do_field_int.  Change type of "value".
4027         * mi/mi-out.c (mi_ui_out::do_table_begin)
4028         (mi_ui_out::do_table_header): Update.
4029         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4030         type of "value".
4031         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4032         (mi_cmd_data_list_changed_registers, output_register)
4033         (mi_cmd_data_read_memory, mi_load_progress)
4034         (mi_cmd_trace_frame_collected): Update.
4035         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4036         Update.
4037         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4038         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4039         (mi_cmd_var_list_children, varobj_update_one): Update.
4040         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4041         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4042         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4043         * inferior.c (print_inferior): Update.
4044         * gdb_bfd.c (print_one_bfd): Update.
4045         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4046         Update.
4047         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4048         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4049         do_field_int.  Change type of "value".
4050         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4051         do_field_int.  Change type of "value".
4052         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4053         (print_one_breakpoint_location, print_it_catch_fork)
4054         (print_one_catch_fork, print_it_catch_vfork)
4055         (print_one_catch_vfork, print_it_catch_solib)
4056         (print_it_catch_exec, print_it_ranged_breakpoint)
4057         (print_mention_watchpoint, print_mention_masked_watchpoint)
4058         (bkpt_print_it, update_static_tracepoint): Update.
4059         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4060         * break-catch-syscall.c (print_it_catch_syscall): Update.
4061         * ada-tasks.c (print_ada_task_info): Update.
4062         * ada-lang.c (print_it_exception, print_mention_exception):
4063         Update.
4064
4065 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4066
4067         PR breakpoints/24541
4068         * gdbarch.c: Regenerate.
4069         * gdbarch.h: Regenerate.
4070         * gdbarch.sh: Adjust return type and parameter types for
4071         'stap_adjust_register'.
4072         (i386_stap_adjust_register): Adjust signature and return new
4073         register name.
4074         * stap-probe.c (stap_parse_register_operand): Adjust use of
4075         'gdbarch_stap_adjust_register'.
4076
4077 2019-07-17  Tom Tromey  <tromey@adacore.com>
4078
4079         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4080         declare VEC.
4081         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4082         std::vector.
4083         (struct s390_process_info): Add initializers.
4084         (s390_add_process): Use new.
4085         (s390_linux_nat_target::low_forget_process): Use delete.
4086         (s390_linux_nat_target::low_new_fork)
4087         (s390_linux_nat_target::stopped_by_watchpoint)
4088         (s390_linux_nat_target::low_prepare_to_resume)
4089         (s390_linux_nat_target::insert_watchpoint)
4090         (s390_linux_nat_target::insert_hw_breakpoint)
4091         (s390_linux_nat_target::remove_watchpoint)
4092         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4093
4094 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4095
4096         * aarch64-fbsd-nat.c: Include regcache.h.
4097         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4098         argument.
4099         (aarch64_fbsd_nat_target::fetch_registers)
4100         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4101         variable.
4102         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4103
4104 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4105
4106         * fbsd-nat.c: Include gdbarch.h.
4107
4108 2019-07-15  Tom Tromey  <tromey@adacore.com>
4109
4110         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4111
4112 2019-07-15  Tom Tromey  <tromey@adacore.com>
4113
4114         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4115         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4116         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4117         * cli-out.c (cli_ui_out::do_field_int): New method.
4118         * ui-out.c (ui_out::field_unsigned): New method.
4119         * symfile.c (generic_load): Use field_unsigned.
4120         (print_transfer_performance): Likewise.
4121         * record-btrace.c (ui_out_field_uint): Remove.
4122         (btrace_call_history_insn_range, btrace_call_history): Use
4123         field_unsigned.
4124         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4125         field_unsigned.
4126         * ui-out.h (class ui_out) <field_unsigned>: New method.
4127         <do_field_unsigned>: Likewise.
4128
4129 2019-07-15  Tom Tromey  <tromey@adacore.com>
4130
4131         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4132         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4133         * target.c (flash_erase_command): Use field_string.
4134         * infrun.c (print_signal_received_reason): Use field_string.
4135         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4136         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4137         field_string.
4138         * ada-tasks.c (print_ada_task_info): Use field_string.
4139
4140 2019-07-15  Tom Tromey  <tromey@adacore.com>
4141
4142         * target.c (flash_erase_command): Use field_core_addr.
4143         * symfile.c (generic_load): Use field_core_addr.
4144         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4145         Use field_core_addr.
4146         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4147         field_core_addr.
4148
4149 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4150
4151         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4152         value if its desired type is smaller than a CORE_ADDR and signed.
4153
4154 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4155
4156         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4157         of changes to field names, and use new is_reference field to
4158         decide if a property is a reference or not.
4159         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4160         field.
4161         (struct dwarf2_property_baton): Update header comment, rename
4162         'referenced_type' to 'property_type' and update comments.
4163         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4164         default property type, store in property baton, update to take
4165         accound of renamed field.
4166         (read_func_scope): Update call to attr_to_dynamic_prop.
4167         (read_array_type): Likewise.
4168         (dwarf2_per_cu_addr_sized_int_type): New function.
4169         (read_subrange_index_type): Move type finding code to
4170         dwarf2_per_cu_addr_sized_int_type.
4171         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4172         (dwarf2_per_cu_addr_type): New function.
4173         (set_die_type): Update calls to attr_to_dynamic_prop.
4174
4175 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4176
4177         * dwarf2read.c (read_subrange_index_type): New function.
4178         (read_subrange_type): Move code into new function and call it.
4179         * gdbtypes.c (create_range_type): Add some asserts.
4180
4181 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4182
4183         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4184         update return statements.
4185         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4186         declaration, and update comment to match.
4187         * gdbtypes.c (resolve_dynamic_array): Update call to
4188         dwarf2_evaluate_property to match new return type.
4189
4190 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4191
4192         * valarith.c (value_subscripted_rvalue): Change lowerbound
4193         parameter type from int to LONGEST.
4194         * value.h (value_subscripted_rvalue): Likewise in declaration.
4195
4196 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4197
4198         * cli/cli-utils.c (info_print_command_completer): New function.
4199         * cli/cli-utils.h: Add 'completer.h' include, and forward
4200         declaration for 'struct cmd_list_element'.
4201         (info_print_command_completer): Declare.
4202         * stack.c (_initialize_stack): Add completer for 'info locals' and
4203         'info args'.
4204         * symtab.c (_initialize_symtab): Add completer for 'info
4205         variables' and 'info functions'.
4206         * NEWS: Mention completion for additional info commands.
4207
4208 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4209
4210         * cli/cli-utils.c (extract_info_print_args): Delete.
4211         (extract_arg_maybe_quoted): Delete.
4212         (info_print_options_defs): New variable.
4213         (make_info_print_options_def_group): New function.
4214         (extract_info_print_options): Define new function.
4215         * cli/cli-utils.h (extract_info_print_args): Delete.
4216         (struct info_print_options): New structure.
4217         (extract_info_print_options): Declare new function.
4218         * stack.c (info_locals_command): Update to use new
4219         extract_info_print_options, also add a header comment.
4220         (info_args_command): Likewise.
4221         * symtab.c (info_variables_command): Likewise.
4222         (info_functions_command): Likewise.
4223
4224 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4225
4226         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4227         to extract string arguments.
4228         * common/common-utils.c (extract_string_maybe_quoted): New function.
4229         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4230
4231 2019-07-11  Tom Tromey  <tromey@adacore.com>
4232
4233         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4234         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4235         * top.h (gdbinit): Don't declare.
4236         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4237         into...
4238         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4239         * top.c (gdb_init): Don't call init_cli_cmds.
4240         (gdbinit): Remove.
4241         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4242
4243 2019-07-11  Tom Tromey  <tromey@adacore.com>
4244
4245         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4246         after it has been moved.
4247
4248 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4249
4250         * valops.c (value_must_coerce_to_target): Change return type to
4251         bool.
4252         * value.h (value_must_coerce_to_target): Likewise.
4253
4254 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4255
4256         * breakpoint.c (is_hardware_watchpoint): Remove
4257         forward-declaration.
4258         (is_masked_watchpoint): Change return type to bool.
4259         (is_tracepoint): Likewise.
4260         (is_breakpoint): Likewise.
4261         (is_hardware_watchpoint): Likewise.
4262         (is_watchpoint): Likewise.
4263         (is_no_memory_software_watchpoint): Likewise.
4264         (is_catchpoint): Likewise.
4265         (breakpoint_1): Make FILTER parameter's return type bool.
4266         is_masked_watchpoint): Change return type to bool.
4267         (save_breakpoints): Make FILTER parameter's return type bool.
4268         * breakpoint.h (is_breakpoint): Change return type to bool.
4269         (is_watchpoint): Likewise.
4270         (is_catchpoint): Likewise.
4271         (is_tracepoint): Likewise.
4272
4273 2019-07-10  Tom Tromey  <tom@tromey.com>
4274
4275         * defs.h: Don't include gdbarch.h.
4276         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4277         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4278         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4279         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4280         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4281         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4282         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4283         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4284         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4285         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4286         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4287         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4288         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4289         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4290         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4291         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4292         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4293         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4294         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4295         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4296         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4297         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4298         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4299         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4300         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4301         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4302         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4303
4304 2019-07-10  Tom Tromey  <tromey@adacore.com>
4305
4306         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4307         * breakpoint.c (init_ada_exception_breakpoint): Register as
4308         bp_catchpoint.
4309         (print_one_breakpoint_location, print_one_breakpoint): Use
4310         is_ada_exception_catchpoint.
4311         * ada-lang.c (class ada_catchpoint_location): Pass
4312         bp_loc_software_breakpoint to bp_location constructor.
4313         (is_ada_exception_catchpoint): New function.
4314
4315 2019-07-10  Tom Tromey  <tromey@adacore.com>
4316
4317         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4318         VEC.
4319         (struct arm_exidx_entry): New method operator<.
4320         (struct arm_exidx_data) <section_maps>: Change type.
4321         (arm_exidx_data_free): Remove.
4322         (arm_exidx_data_key): Change type.  Move lower.
4323         (arm_exidx_new_objfile): Update.
4324         (arm_compare_exidx_entries): Remove.
4325         (arm_find_exidx_entry, _initialize_arm_tdep)
4326
4327 2019-07-10  Tom Tromey  <tromey@adacore.com>
4328
4329         * solib-spu.c (ocl_program_data_key): Change type.
4330         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4331         Update.
4332
4333 2019-07-10  Tom Tromey  <tromey@adacore.com>
4334
4335         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4336         (struct solib_aix_inferior_data) <library_list>: Change type.
4337         (solib_aix_inferior_data_handle): Change type.
4338         (get_solib_aix_inferior_data): Update.
4339         (solib_aix_free_library_list): Remove.
4340         (library_list_start_library): Update.
4341         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4342         return type.
4343         (solib_aix_get_library_list)
4344         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4345         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4346
4347 2019-07-10  Tom Tromey  <tromey@adacore.com>
4348
4349         * solib-dsbt.c (struct dsbt_info): Add initializers.
4350         (solib_dsbt_pspace_data): Change type.
4351         (dsbt_pspace_data_cleanup): Remove.
4352         (get_dsbt_info, _initialize_dsbt_solib): Update.
4353
4354 2019-07-10  Tom Tromey  <tromey@adacore.com>
4355
4356         * spu-tdep.c (spu_overlay_data): Change type.
4357         (spu_get_overlay_table, spu_overlay_new_objfile)
4358         (_initialize_spu_tdep): Update.
4359
4360 2019-07-10  Tom Tromey  <tromey@adacore.com>
4361
4362         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4363         destructor.
4364         (dbx_objfile_data_key): Change type and declare later.
4365         (DBX_SYMFILE_INFO): Rewrite.
4366         * dbxread.c (dbx_objfile_data_key): Change type.
4367         (dbx_symfile_init): Update.
4368         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4369         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4370         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4371
4372 2019-07-10  Tom Tromey  <tromey@adacore.com>
4373
4374         * jit.c (jit_program_space_key): Change type.  Move lower.
4375         (get_jit_program_space_data): Update.
4376         (jit_program_space_data_cleanup): Remove.
4377         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4378         Update.
4379         (struct jit_program_space_data): Add initializers.
4380
4381 2019-07-10  Tom Tromey  <tromey@adacore.com>
4382
4383         * solib-darwin.c (struct darwin_info): Add initializers.
4384         (solib_darwin_pspace_data): Change type.
4385         (darwin_pspace_data_cleanup): Remove.
4386         (get_darwin_info, _initialize_darwin_solib): Update.
4387
4388 2019-07-10  Tom Tromey  <tromey@adacore.com>
4389
4390         * remote-sim.c (struct sim_inferior_data): Add initializers,
4391         constructor, and destructor.
4392         (sim_inferior_data_key): Change type.  Move lower.
4393         (check_for_duplicate_sim_descriptor): Update.
4394         (get_sim_inferior_data): Use new.  Update.
4395         (~sim_inferior_data_cleanup): Rename from
4396         sim_inferior_data_cleanup.  Simplify.
4397         (gdbsim_close_inferior, simulator_command)
4398         (sim_command_completer, _initialize_remote_sim): Update.
4399         (next_pid, INITIAL_PID): Move earlier.
4400
4401 2019-07-10  Tom Tromey  <tromey@adacore.com>
4402
4403         * python/python-internal.h (create_thread_object): Return
4404         gdbpy_ref.
4405         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4406         * python/py-inferior.c (struct threadlist_entry): Add
4407         constructor.
4408         <thread_obj>: Now a gdbpy_ref.
4409         (thread_to_thread_object): Update.
4410         (add_thread_object): Use new.
4411         (delete_thread_object): Use delete.
4412         (infpy_threads): Update.
4413         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4414         GIL.
4415
4416 2019-07-10  Tom Tromey  <tromey@adacore.com>
4417
4418         * valops.c (value_cast): Specialize error message for Ada.
4419
4420 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4421
4422         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4423
4424 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4425
4426         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4427         bpstat_should_step): Return bool, adjust comments.
4428         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4429         bpstat_should_step): Likewise.
4430
4431 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4432
4433         * features/Makefile: Use feature target descriptions for Arm.
4434         * features/arm/arm-core.c: Generate new file.
4435         * features/arm/arm-fpa.c: Likewise.
4436         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4437         * features/arm/arm-m-profile.c: Likewise.
4438         * features/arm/arm-vfpv2.c: Likewise.
4439         * features/arm/arm-vfpv3.c: Likewise.
4440         * features/arm/xscale-iwmmxt.c: Likewise.
4441         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4442
4443 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4444
4445         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4446         ptrace earlier.
4447
4448 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4449
4450         * features/aarch64-pauth.c: Regenerate.
4451
4452 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4453
4454         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4455         bool.
4456         (bpstat_what): Use false instead of 0.
4457
4458 2019-07-09  Pedro Alves  <palves@redhat.com>
4459
4460         * break-catch-throw.c (is_exception_catchpoint): New.
4461         * breakpoint.c (print_one_breakpoint_location): New parameter
4462         'raw_loc'.  Handle it.  Use
4463         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4464         looking at the breakpoint's type.
4465         (print_one_breakpoint): If handling "maint info breakpoints", also
4466         print locations of exception catchpoints.
4467         * breakpoint.h (is_exception_catchpoint): Declare.
4468
4469 2019-07-09  Pedro Alves  <palves@redhat.com>
4470
4471         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4472         "addr" field.
4473         (allocate_location_exception_catchpoint): New.
4474         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4475         (initialize_throw_catchpoint_ops): Install
4476         allocate_location_exception_catchpoint as allocate_location
4477         method.
4478         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4479         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4480         bp_loc_other.
4481         (breakpoint_address_is_meaningful): Delete.
4482         (bl_address_is_meaningful): New.
4483         (breakpoint_locations_match): Adjust comment.
4484         (bp_location_from_bp_type): New, factored out of...
4485         (bp_location::bp_location(breakpoint *)): ... this.
4486         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4487         factored out of...
4488         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4489         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4490         breakpoint_address_is_meaningful.
4491         (bp_locations_compare): Adjust comment.
4492         (update_global_location_list): Use bl_address_is_meaningful
4493         instead of breakpoint_address_is_meaningful.
4494         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4495         explicit.
4496         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4497         * python/py-breakpoint.c (bppy_get_location): No longer check
4498         whether location is null.
4499
4500 2019-07-09  Pedro Alves  <palves@redhat.com>
4501
4502         PR c++/15468
4503         * breakpoint.c (print_one_breakpoint_location): Remove
4504         single-location assert.
4505
4506 2019-07-09  Tom Tromey  <tom@tromey.com>
4507
4508         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4509         * configure: Rebuild.
4510         * configure.ac: Change common to gdbsupport.
4511         * gdbsupport: Rename from common.
4512         * acinclude.m4: Change common to gdbsupport.
4513         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4514         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4515         gdbsupport.
4516         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4517         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4518         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4519         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4520         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4521         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4522         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4523         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4524         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4525         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4526         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4527         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4528         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4529         coff-pe-read.c, command.h, compile/compile-c-support.c,
4530         compile/compile-c.h, compile/compile-cplus-symbols.c,
4531         compile/compile-cplus-types.c, compile/compile-cplus.h,
4532         compile/compile-loc2c.c, compile/compile.c, completer.c,
4533         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4534         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4535         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4536         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4537         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4538         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4539         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4540         features/aarch64-core.c, features/aarch64-fpu.c,
4541         features/aarch64-pauth.c, features/aarch64-sve.c,
4542         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4543         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4544         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4545         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4546         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4547         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4548         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4549         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4550         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4551         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4552         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4553         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4554         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4555         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4556         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4557         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4558         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4559         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4560         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4561         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4562         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4563         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4564         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4565         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4566         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4567         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4568         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4569         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4570         minsyms.c, mips-linux-tdep.c, namespace.h,
4571         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4572         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4573         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4574         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4575         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4576         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4577         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4578         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4579         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4580         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4581         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4582         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4583         procfs.c, producer.c, progspace.h, psymtab.h,
4584         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4585         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4586         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4587         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4588         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4589         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4590         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4591         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4592         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4593         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4594         target-memory.c, target.c, target.h, target/waitstatus.c,
4595         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4596         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4597         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4598         unittests/array-view-selftests.c,
4599         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4600         unittests/common-utils-selftests.c,
4601         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4602         unittests/format_pieces-selftests.c,
4603         unittests/function-view-selftests.c,
4604         unittests/lookup_name_info-selftests.c,
4605         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4606         unittests/mkdir-recursive-selftests.c,
4607         unittests/observable-selftests.c,
4608         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4609         unittests/parse-connection-spec-selftests.c,
4610         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4611         unittests/scoped_fd-selftests.c,
4612         unittests/scoped_mmap-selftests.c,
4613         unittests/scoped_restore-selftests.c,
4614         unittests/string_view-selftests.c, unittests/style-selftests.c,
4615         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4616         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4617         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4618         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4619         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4620         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4621
4622 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4623
4624         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4625         bool value.
4626         (decode_digits_ordinary): Set explicit_line field in sal.
4627         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4628         symtab_and_line that was set on an explicit line number in
4629         assembler code.  Do always update the recorded symtab and line if
4630         we do skip the prologue.
4631
4632 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4633
4634         * breakpoint.c (set_breakpoint_location_function): Remove
4635         explicit_loc parameter.
4636         (momentary_breakpoint_from_master): Update call to
4637         set_breakpoint_location_function.
4638         (add_location_to_breakpoint): Likewise.
4639
4640 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4641
4642         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4643         required features based on default bfd type when no specific bfd
4644         is present.
4645
4646 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4647
4648         * NEWS: Mention that GDB printf and eval commands can now print
4649         C-style and Ada-style convenience var strings without
4650         calling the inferior.
4651         * printcmd.c (printf_c_string): Locally print GDB internal var
4652         instead of transiting via the inferior.
4653         (printf_wide_c_string): Likewise.
4654
4655 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4656
4657         PR breakpoints/25011
4658         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4659
4660 2019-07-04  Tom Tromey  <tom@tromey.com>
4661
4662         PR tui/24724:
4663         * tui/tui-winsource.c (tui_clear_source_content): Update.
4664         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4665         (tui_update_breakpoint_info): Update.
4666         (tui_set_exec_info_content): Update.
4667         * tui/tui-source.c (tui_set_source_content_nil): Update.
4668         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4669         has_break.
4670         * tui/tui-data.h (enum tui_bp_flag): New.
4671         (tui_bp_flags): New enum flags type.
4672         (struct tui_source_element) <break_mode>: Change type.  Rename
4673         from has_break.
4674         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4675         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4676         constants.
4677         * tui/tui-winsource.h: Fix comment.
4678
4679 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4680
4681         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4682         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4683         (store_fpregs_to_thread)
4684         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4685         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4686         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4687         (IWMMXT_REGS_SIZE): Add define.
4688         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4689         (fetch_vfp_regs, store_vfp_regs)
4690         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4691         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4692
4693 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4694
4695         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4696         defines.
4697         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4698         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4699         (ARM_INT_REGISTER_SIZE): ...to this.
4700         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4701         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4702         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4703         (arm_linux_collect_gregset, supply_nwfpe_register)
4704         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4705         defines.
4706         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4707         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4708         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4709         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4710         (arm_return_in_memory, arm_store_return_value)
4711         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4712         (arm_record_ld_st_multiple): Likewise.
4713         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4714         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4715
4716 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4717
4718         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4719         AARCH64_DISPLACED_MODIFIED_INSNS.
4720         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4721         (aarch64_displaced_step_copy_insn): Likewise.
4722         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4723         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4724         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4725         ARM_DISPLACED_MODIFIED_INSNS.
4726         * arm-tdep.c (arm_gdbarch_init): Likewise.
4727         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4728         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4729         (struct arm_displaced_step_closure): Use
4730         ARM_DISPLACED_MODIFIED_INSNS.
4731
4732 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4733
4734         * features/Makefile: Remove unused xml files.
4735         * features/aarch64.xml: Remove.
4736         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4737         * features/i386/amd64-avx-avx512.xml: Remove.
4738         * features/i386/amd64-avx-linux.xml: Remove.
4739         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4740         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4741         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4742         * features/i386/amd64-avx-mpx.xml: Remove.
4743         * features/i386/amd64-avx.xml: Remove.
4744         * features/i386/amd64-linux.xml: Remove.
4745         * features/i386/amd64-mpx-linux.xml: Remove.
4746         * features/i386/amd64-mpx.xml: Remove.
4747         * features/i386/amd64.xml: Remove.
4748         * features/i386/i386-avx-avx512-linux.xml: Remove.
4749         * features/i386/i386-avx-avx512.xml: Remove.
4750         * features/i386/i386-avx-linux.xml: Remove.
4751         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4752         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4753         * features/i386/i386-avx-mpx-linux.xml: Remove.
4754         * features/i386/i386-avx-mpx.xml: Remove.
4755         * features/i386/i386-avx.xml: Remove.
4756         * features/i386/i386-linux.xml: Remove.
4757         * features/i386/i386-mmx-linux.xml: Remove.
4758         * features/i386/i386-mmx.xml: Remove.
4759         * features/i386/i386-mpx-linux.xml: Remove.
4760         * features/i386/i386-mpx.xml: Remove.
4761         * features/i386/i386.xml: Remove.
4762         * features/i386/x32-avx-avx512-linux.xml: Remove.
4763         * features/i386/x32-avx-linux.xml: Remove.
4764         * features/i386/x32-linux.xml: Remove.
4765
4766 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4767
4768         * regformats/aarch64.dat: Remove.
4769         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4770         * regformats/i386/amd64-avx-linux.dat: Remove.
4771         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4772         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4773         * regformats/i386/amd64-linux.dat: Remove.
4774         * regformats/i386/amd64-mpx-linux.dat: Remove.
4775         * regformats/i386/amd64.dat: Remove.
4776         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4777         * regformats/i386/i386-avx-linux.dat: Remove.
4778         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4779         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4780         * regformats/i386/i386-linux.dat: Remove.
4781         * regformats/i386/i386-mmx-linux.dat: Remove.
4782         * regformats/i386/i386-mpx-linux.dat: Remove.
4783         * regformats/i386/i386.dat: Remove.
4784         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4785         * regformats/i386/x32-avx-linux.dat: Remove.
4786         * regformats/i386/x32-linux.dat: Remove.
4787
4788 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4789
4790         * aarch64-tdep.c: Remove xml self tests.
4791         * amd64-linux-tdep.c: Likewise.
4792         * amd64-tdep.c: Likewise.
4793         * i386-linux-tdep.c: Likewise.
4794         * i386-tdep.c: Likewise.
4795
4796 2019-07-03  Pedro Alves  <palves@redhat.com>
4797
4798         PR cli/24732
4799         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4800         (pipe_cmd_option_defs): New.
4801         (make_pipe_cmd_options_def_group): New.
4802         (pipe_command): Use gdb::option::process_options.
4803         (pipe_command_completer): New function.
4804         (_initialize_cli_cmds): Install completer for "pipe" command.
4805
4806 2019-07-03  Pedro Alves  <palves@redhat.com>
4807
4808         * cli/cli-option.c (union option_value) <string>: New field.
4809         (struct option_def_and_value): Add ctor, move ctor, dtor and
4810         use DISABLE_COPY_AND_ASSIGN.
4811         (option_def_and_value::clear_value): New.
4812         (parse_option, save_option_value_in_ctx, get_val_type_str)
4813         (add_setshow_cmds_for_options): Handle var_string.
4814         * cli-option.h (union option_def::var_address) <string>: New
4815         field.
4816         (struct string_option_def): New.
4817         * maint-test-options.c (struct test_options_opts): Add default
4818         ctor and use DISABLE_COPY_AND_ASSIGN.
4819         <string_opt>: New field.
4820         (test_options_opts::~test_options_opts): New.
4821         (test_options_opts::dump): Also dump "-string".
4822         (test_options_option_defs): Install "string.
4823
4824 2019-07-03  Pedro Alves  <palves@redhat.com>
4825
4826         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4827         option_value with a null enumeration.
4828         (complete_options): Save the option values in the context.
4829         (save_option_value_in_ctx): New, factored out from ...
4830         (process_options): ... here.
4831         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4832         of the function.
4833         * maint-test-options.c (test_options_opts::dump): New, factored
4834         out from ...
4835         (maintenance_test_options_command_mode): ... here.
4836         (maintenance_test_options_command_completion_result): Delete.
4837         (maintenance_test_options_command_completion_text): Update
4838         comment.
4839         (maintenance_show_test_options_completion_result): Change
4840         prototype.  Just print
4841         maintenance_test_options_command_completion_text.
4842         (save_completion_result): New.
4843         (maintenance_test_options_completer_mode): Pass options context to
4844         complete_options, and then save a dump.
4845         (_initialize_maint_test_options): Use add_cmd to install "maint
4846         show test-options-completion-result".
4847
4848 2019-07-03  Pedro Alves  <palves@redhat.com>
4849
4850         * NEWS (New commands): Mention "with" and "maint with".
4851         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4852         (with_command, with_command_completer): New.
4853         (pipe_command): Adjust to new repeat_previous
4854         interface.
4855         (_initialize_cli_cmds): Install the "with" command and its "w"
4856         alias.
4857         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4858         declarations.
4859         * cli/cli-setshow.c (parse_cli_var_uinteger)
4860         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4861         argument strings for all var_types.
4862         (get_setshow_command_value_string): New, factored out from ...
4863         (do_show_command): ... this.
4864         * cli/cli-setshow.h: Include <string>.
4865         (get_setshow_command_value_string): Declare.
4866         * command.h (repeat_previous): Now returns const char *.  Adjust
4867         comment.
4868         * maint.c: Include "cli/cli-cmds.h".
4869         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4870         (_initialize_maint_cmds): Register the "maintenance with" command.
4871         * top.c (repeat_previous): Move bits from pipe_command here:
4872         Return the saved command line, if any; error out if there's no
4873         command to relaunch.
4874
4875 2019-07-03  Pedro Alves  <palves@redhat.com>
4876
4877         * NEWS (New commands): Mention "maint set/show test-settings"
4878         instead of "maint test-settings".
4879         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4880         (maintenance_test_settings_set_list): Rename to ...
4881         (maintenance_set_test_settings_list): ... this.
4882         (maintenance_test_settings_show_list): Rename to  ...
4883         (maintenance_show_test_settings_list): ... this.
4884         (maintenance_test_settings_cmd): Delete.
4885         (maintenance_test_settings_set_cmd): ...
4886         (maintenance_set_test_settings_cmd): ... this.
4887         (maintenance_test_settings_show_cmd): ...
4888         (maintenance_show_test_settings_cmd): ... this.
4889         (maintenance_test_settings_show_value_cmd):
4890         (maintenance_show_test_settings_value_cmd): ... this.
4891         (_initialize_maint_test_settings): No longer install the "maint
4892         test-settings" prefix command.  Rename "maint test-settings set"
4893         to "maint set test-settings", and "maint test-settings show" to
4894         "maint show test-settings".  Adjust all subcommands.
4895
4896 2019-07-03  Pedro Alves  <palves@redhat.com>
4897
4898         * maint-test-settings.c: Fix file's intro comment.  Replace all
4899         references to "test-options" with references to "test-settings",
4900         in comments.
4901
4902 2019-07-03  Pedro Alves  <palves@redhat.com>
4903
4904         * maint-test-settings.c (maintenance_test_settings_xxx)
4905         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4906         New.
4907         (maintenance_test_settings_enums): Use them.
4908         (maintenance_test_settings_enum): Default to
4909         maintenance_test_settings_xxx.
4910         (_initialize_maint_test_settings): Initialize
4911         MAINTENANCE_TEST_SETTINGS_FILENAME.
4912
4913 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4914
4915         * breakpoint.h (remove_breakpoints_inf): Change return type to
4916         void, move function documentation here.
4917         * breakpoint.c (remove_breakpoints_inf): Change return type to
4918         void, move function documentation to header.
4919
4920 2019-07-02  Pedro Alves  <palves@redhat.com>
4921
4922         * NEWS (Completion improvements): Mention "info threads".
4923         * thread.c (struct info_threads_opts, info_threads_option_defs)
4924         (make_info_threads_options_def_group): New.
4925         (info_threads_command): Use gdb::option::process_options.
4926         (info_threads_command_completer): New.
4927         (_initialize_thread): Use gdb::option::build_help to build the
4928         help text for "info threads".
4929
4930 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4931
4932         * defs.h (generic_load): Move from here...
4933         * symfile.h (generic_load): ... to here.  Rename name parameter
4934         to args.
4935         * symfile.c (generic_load): Add comment.
4936
4937 2019-07-01  Tom Tromey  <tromey@adacore.com>
4938
4939         * dwarf2read.c
4940         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4941         declaration of without_params.  Fix formatting.
4942
4943 2019-07-01  Tom Tromey  <tromey@adacore.com>
4944
4945         * ada-exp.y (find_primitive_type): Update.
4946         * ada-lang.h (ada_lookup_symbol): Update.
4947         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4948         parameter.
4949         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4950
4951 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4952
4953         PR breakpoints/24541
4954         * gdbarch.c: Regenerate.
4955         * gdbarch.h: Regenerate.
4956         * gdbarch.sh: Add 'stap_adjust_register'.
4957         * i386-tdep.c: Include '<unordered_set>'.
4958         (i386_stap_adjust_register): New function.
4959         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4960         * stap-probe.c (stap_parse_register_operand): Call
4961         'gdbarch_stap_adjust_register'.
4962
4963 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4964
4965         PR python/24742
4966         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4967         * python/python.c (do_start_initialization): Use 'xmalloc'
4968         instead of 'PyMem_Malloc'.
4969
4970 2019-06-28  Tom Tromey  <tromey@adacore.com>
4971
4972         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4973         for Ada.
4974
4975 2019-06-27  Tom Tromey  <tromey@adacore.com>
4976
4977         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4978         objfile_key.
4979         (arm_find_mapping_symbol, arm_record_special_symbol)
4980         (_initialize_arm_tdep): Update.
4981         (arm_objfile_data_free): Remove.
4982
4983 2019-06-27  Tom Tromey  <tromey@adacore.com>
4984
4985         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4986         to cp_print_static_field.
4987
4988 2019-06-26  Tom Tromey  <tromey@adacore.com>
4989
4990         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4991         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4992         declare.
4993
4994 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4995
4996         * features/aarch64-core.c (create_feature_aarch64_core):
4997         Regenerate.
4998         * features/aarch64-core.xml: Add cpsr flags.
4999
5000 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5001
5002         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5003         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5004
5005 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5006
5007         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5008         field.
5009         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5010         use.
5011         (arm_record_special_symbol): Don't insert new symbol in sorted
5012         position, push it at the end.
5013
5014 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5015
5016         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5017         (arm_mapping_symbol_s): Remove.
5018         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5019         (arm_mapping_symbol_vec): New typedef.
5020         (struct arm_per_objfile): Add constructor.
5021         <section_maps>: Change type to
5022         std::unique_ptr<arm_mapping_symbol_vec[]>.
5023         (arm_compare_mapping_symbols): Remove.
5024         (arm_find_mapping_symbol): Adjust to section_maps type change.
5025         (arm_objfile_data_free): Call delete on arm_per_objfile.
5026         (arm_record_special_symbol): Adjust to section_maps type change.
5027         Allocate arm_per_objfile with new.
5028
5029 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5030
5031         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5032         with the command prefix.
5033
5034 2019-06-25  Tom Tromey  <tom@tromey.com>
5035
5036         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5037         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5038
5039 2019-06-25  Tom Tromey  <tom@tromey.com>
5040
5041         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5042         type.
5043         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5044         protected.
5045
5046 2019-06-25  Tom Tromey  <tom@tromey.com>
5047
5048         * tui/tui-winsource.c
5049         (tui_source_window_base::set_is_exec_point_at): Add check against
5050         LOA_ADDRESS.
5051
5052 2019-06-25  Tom Tromey  <tom@tromey.com>
5053
5054         * tui/tui-source.c (tui_set_source_content): Don't check before
5055         xfree.
5056         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5057
5058 2019-06-25  Tom Tromey  <tom@tromey.com>
5059
5060         * tui/tui-winsource.h (tui_update_source_window_as_is)
5061         (tui_alloc_source_buffer, tui_line_is_displayed)
5062         (tui_addr_is_displayed): Change type of win_info.
5063         * tui/tui-winsource.c (tui_update_source_window_as_is)
5064         (tui_clear_source_content, tui_show_source_line)
5065         (tui_show_source_content, tui_source_window_base::refill)
5066         (tui_source_window_base::set_is_exec_point_at)
5067         (tui_source_window_base::set_is_exec_point_at)
5068         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5069         (tui_alloc_source_buffer, tui_line_is_displayed)
5070         (tui_addr_is_displayed): Change type of win_info.  Update.
5071         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5072         (tui_source_window_base::do_make_visible_with_new_height):
5073         Update.
5074         * tui/tui-source.c (tui_set_source_content)
5075         (tui_set_source_content_nil)
5076         (tui_source_window::do_scroll_vertical): Update.
5077         * tui/tui-layout.c (show_layout): Update.
5078         * tui/tui-disasm.c (tui_set_disassem_content)
5079         (tui_disasm_window::do_scroll_vertical): Update.
5080         * tui/tui-data.h (tui_win_content): Remove.
5081         (struct tui_gen_win_info) <content, content_size>: Remove.
5082         (struct tui_source_element): Add initializers and destructor.
5083         (union tui_which_element, struct tui_win_element): Remove.
5084         (struct tui_source_window_base) <content>: New field.
5085         (struct tui_data_window): Remove destructor.
5086         (tui_alloc_content, tui_free_win_content)
5087         (tui_free_all_source_wins_content): Don't declare.
5088         * tui/tui-data.c (tui_initialize_static_data): Update.
5089         (init_content_element, tui_alloc_content): Remove.
5090         (~tui_gen_win_info): Update.
5091         (~tui_data_window, tui_free_all_source_wins_content)
5092         (tui_free_win_content, free_content, free_content_elements):
5093         Remove.
5094
5095 2019-06-25  Tom Tromey  <tom@tromey.com>
5096
5097         * tui/tui-winsource.h (tui_clear_source_content)
5098         (tui_erase_source_content, tui_show_source_content): Change type
5099         of win_info.
5100         * tui/tui-winsource.c (tui_clear_source_content)
5101         (tui_erase_source_content, tui_show_source_content): Change type
5102         of win_info.
5103         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5104         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5105         win_info.
5106         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5107         win_info.
5108         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5109
5110 2019-06-25  Tom Tromey  <tom@tromey.com>
5111
5112         * tui/tui-winsource.c (tui_clear_source_content)
5113         (tui_source_window_base::set_is_exec_point_at): Update.
5114         * tui/tui-source.c (tui_set_source_content_nil): Update.
5115         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5116         a bool.
5117         * tui/tui-data.c (init_content_element): Update.
5118
5119 2019-06-25  Tom Tromey  <tom@tromey.com>
5120
5121         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5122         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5123         * tui/tui-layout.c (init_and_make_win): Update.
5124         * tui/tui.h (enum tui_win_type): Update.
5125         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5126         tui_win_is_auxillary.
5127         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5128         tui_win_is_auxillary.
5129
5130 2019-06-25  Tom Tromey  <tom@tromey.com>
5131
5132         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5133         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5134         (tui_delete_data_content_windows, tui_display_all_data)
5135         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5136         Update.
5137         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5138         * tui/tui-regs.c (tui_last_regs_line_no)
5139         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5140         (tui_show_registers): Update.
5141         (tui_show_register_group): Return void.  Update.
5142         (tui_display_registers_from, tui_display_reg_element_at_line)
5143         (tui_display_registers_from_line, tui_check_register_values):
5144         Update.
5145         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5146         member.
5147         (struct tui_data_window) <regs_content>: Now a std::vector.
5148         <regs_content_count>: Remove.
5149         (tui_add_content_elements, tui_free_data_content): Don't declare.
5150         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5151         (init_content_element): Remove DATA_WIN case.  Add assert.
5152         (tui_add_content_elements): Remove.
5153         (tui_data_window): Update.
5154         (tui_free_data_content): Remove.
5155         (free_content_elements): Remove DATA_WIN case.
5156
5157 2019-06-25  Tom Tromey  <tom@tromey.com>
5158
5159         * tui/tui-data.c (tui_data_item_window): Update.
5160         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5161         * tui/tui-windata.c (tui_display_all_data)
5162         (tui_display_data_from_line): Update.
5163         (tui_check_data_values): Remove.
5164         * tui/tui-regs.c (tui_show_register_group)
5165         (tui_display_reg_element_at_line): Update.
5166         * tui/tui-hooks.c (tui_register_changed)
5167         (tui_refresh_frame_and_register_information): Call
5168         tui_check_register_values.
5169         * tui/tui-data.h (struct tui_data_window) <data_content,
5170         data_content_count, data_type>: Remove.
5171         (enum tui_data_type): Remove.
5172
5173         * tui/tui-data.c (tui_data_window::clear_detail)
5174         (~tui_data_window): Update.
5175
5176 2019-06-25  Tom Tromey  <tom@tromey.com>
5177
5178         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5179         declare.
5180         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5181         Rename from tui_first_data_item_displayed.  Update.
5182         (tui_data_window::refresh_all)
5183         (tui_data_window::do_scroll_vertical): Update.
5184         * tui/tui-data.h (struct tui_data_window)
5185         <first_data_item_displayed>: Declare new method.
5186
5187 2019-06-25  Tom Tromey  <tom@tromey.com>
5188
5189         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5190         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5191         contents...
5192         (tui_initialize_static_data): ...here.
5193
5194 2019-06-25  Tom Tromey  <tom@tromey.com>
5195
5196         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5197         (tui_display_registers_from, tui_check_register_values): Update.
5198         (tui_display_register): Remove win_info parameter; update.
5199         (tui_get_register): Change type of parameters.
5200         * tui/tui-data.h (struct tui_data_element): Remove.
5201         (union tui_which_element) <data>: Remove.
5202         <data_window>: Change type.
5203         (struct tui_data_item_window): New.
5204         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5205         case.  Add assert.
5206         (~tui_data_item_window): New destructor.
5207         (free_content_elements): Remove DATA_ITEM_WIN case.
5208
5209 2019-06-25  Tom Tromey  <tom@tromey.com>
5210
5211         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5212         Remove.
5213
5214 2019-06-25  Tom Tromey  <tom@tromey.com>
5215
5216         * tui/tui-data.h (struct tui_command_element): Remove.
5217         (union tui_which_element) <command>: Remove.
5218         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5219         assert.
5220         (free_content_elements): Remove CMD_WIN case.
5221
5222 2019-06-25  Tom Tromey  <tom@tromey.com>
5223
5224         * tui/tui-layout.c (tui_set_layout): Update.
5225         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5226         * tui/tui-data.c (layout_def): Update.
5227
5228 2019-06-25  Tom Tromey  <tom@tromey.com>
5229
5230         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5231         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5232         (tui_source_window_base::set_new_height): Update.
5233         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5234         Update.
5235         (tui_set_locator_fullname, tui_set_locator_info)
5236         (tui_show_frame_info): Update.
5237         * tui/tui-source.c (tui_set_source_content)
5238         (tui_source_is_displayed): Update.
5239         * tui/tui-layout.c (show_source_disasm_command, show_data)
5240         (show_source_or_disasm_and_command): Update.
5241         * tui/tui-disasm.c (tui_set_disassem_content)
5242         (tui_get_begin_asm_address): Update.
5243         * tui/tui-data.h (struct tui_locator_element): Remove.
5244         (union tui_which_element) <locator>: Remove.
5245         (struct tui_locator_window): New.
5246         (tui_locator_win_info_ptr): Change return type.
5247         * tui/tui-data.c (_locator): Change type.
5248         (tui_locator_win_info_ptr): Change return type.
5249         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5250         (tui_alloc_content): Add assert.
5251
5252 2019-06-25  Tom Tromey  <tom@tromey.com>
5253
5254         * tui/tui-winsource.c
5255         (tui_exec_info_window::maybe_allocate_content): New method.
5256         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5257         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5258         (make_source_or_disasm_window): Add cast.
5259         * tui/tui-data.h (union tui_which_element) <simple_string>:
5260         Remove.
5261         (struct tui_source_info): New.
5262         (struct tui_source_window_base) <execution_info>: Change type.
5263         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5264         case, and add assert.
5265         (tui_alloc_content): Add assert.
5266
5267 2019-06-25  Tom Tromey  <tom@tromey.com>
5268
5269         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5270         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5271         * tui/tui-data.c (tui_alloc_win_info): Remove.
5272
5273 2019-06-25  Tom Tromey  <tom@tromey.com>
5274
5275         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5276         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5277         can_highlight.
5278
5279 2019-06-25  Tom Tromey  <tom@tromey.com>
5280
5281         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5282         make_visible_with_new_height method.
5283         (tui_win_info::make_visible_with_new_height): New method.
5284         (tui_source_window_base::do_make_visible_with_new_height)
5285         (tui_data_window::do_make_visible_with_new_height)
5286         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5287         (make_visible_with_new_height): Remove.
5288         (tui_resize_all, tui_adjust_win_heights): Use
5289         make_visible_with_new_height method.
5290         * tui/tui-data.h (struct tui_win_info)
5291         <do_make_visible_with_new_height, make_visible_with_new_height>:
5292         New methods.
5293         (struct tui_source_window_base, struct tui_data_window)
5294         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5295         methods.
5296
5297 2019-06-25  Tom Tromey  <tom@tromey.com>
5298
5299         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5300         method.
5301         (update_tab_width): Call update_tab_width method.
5302         * tui/tui-data.h (struct tui_win_info)
5303         (struct tui_source_window_base) <update_tab_width>: New methods.
5304
5305 2019-06-25  Tom Tromey  <tom@tromey.com>
5306
5307         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5308         parameter.
5309         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5310         parameter.
5311         (tui_gen_win_info::make_visible): Update.
5312         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5313         parameter.
5314         * tui/tui-data.h (enum tui_box): New enum.
5315         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5316
5317 2019-06-25  Tom Tromey  <tom@tromey.com>
5318
5319         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5320         init_and_make_win for EXEC_INFO_WIN.
5321         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5322         longer inline.
5323         (struct tui_win_info) <~tui_win_info>: Inline.
5324         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5325         Don't declare.
5326         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5327         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5328         Remove.
5329         (tui_initialize_static_data): Update.
5330         (~tui_gen_win_info): Handle more cleanup here.
5331         (~tui_source_window_base): Delete "execution_info".
5332         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5333
5334 2019-06-25  Tom Tromey  <tom@tromey.com>
5335
5336         * tui/tui-layout.c (make_command_window): Don't set
5337         can_highlight.
5338         (show_source_disasm_command): Call the reset method.
5339         (show_data): Don't set can_highlight.  Call the reset method.
5340         (tui_gen_win_info::reset): Rename from init_gen_win_info
5341         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5342         (show_source_or_disasm_and_command): Call the reset method.
5343         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5344         (struct tui_cmd_window): Set can_highlight.
5345
5346 2019-06-25  Tom Tromey  <tom@tromey.com>
5347
5348         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5349         from make_visible.
5350         (tui_make_visible, tui_make_invisible): Rewrite.
5351         (tui_win_info::make_visible): Remove.
5352         (tui_source_window_base::make_visible): Update.
5353         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5354         method.  Moved from...
5355         (struct tui_win_info) <make_visible>: ...here.
5356
5357 2019-06-25  Tom Tromey  <tom@tromey.com>
5358
5359         * tui/tui-winsource.c
5360         (tui_source_window_base::do_scroll_horizontal): Remove direction
5361         parameter.
5362         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5363         direction parameter.
5364         * tui/tui-win.c (tui_win_info::forward_scroll)
5365         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5366         (tui_win_info::right_scroll): Update.
5367         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5368         direction parameter.
5369         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5370         direction parameter.
5371         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5372         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5373         Remove direction parameter.
5374         (struct tui_source_window_base, struct tui_source_window)
5375         (struct tui_disasm_window, struct tui_data_window)
5376         (struct tui_cmd_window): Update.
5377
5378 2019-06-25  Tom Tromey  <tom@tromey.com>
5379
5380         * tui/tui-winsource.h (tui_set_exec_info_content)
5381         (tui_show_exec_info_content, tui_erase_exec_info_content)
5382         (tui_clear_exec_info_content, tui_update_exec_info): Change
5383         argument to tui_source_window_base.
5384         * tui/tui-winsource.c (tui_set_exec_info_content)
5385         (tui_show_exec_info_content, tui_erase_exec_info_content)
5386         (tui_clear_exec_info_content, tui_update_exec_info): Change
5387         argument to tui_source_window_base.
5388
5389 2019-06-25  Tom Tromey  <tom@tromey.com>
5390
5391         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5392         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5393
5394 2019-06-25  Tom Tromey  <tom@tromey.com>
5395
5396         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5397         check.
5398
5399 2019-06-25  Tom Tromey  <tom@tromey.com>
5400
5401         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5402         type to void.
5403         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5404         type to void.
5405         * tui/tui-source.c (tui_set_source_content): Update.
5406         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5407
5408 2019-06-25  Tom Tromey  <tom@tromey.com>
5409
5410         * tui/tui-win.c (window_name_completer, tui_set_focus)
5411         (tui_all_windows_info): Use name method.
5412         * tui/tui-data.h (struct tui_gen_win_info)
5413         (struct tui_source_window, struct tui_disasm_window)
5414         (struct tui_data_window, struct tui_cmd_window) <name>: New
5415         method.
5416         (tui_win_name): Don't declare.
5417         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5418         (tui_win_name): Remove.
5419
5420 2019-06-25  Tom Tromey  <tom@tromey.com>
5421
5422         * tui/tui-winsource.h (tui_update_source_window)
5423         (tui_update_source_window_as_is): Change parameter type.
5424         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5425         to be a tui_source_window_base.
5426         (tui_update_source_window_as_is): Likewise.
5427         * tui/tui-win.c (make_visible_with_new_height): Update.
5428
5429 2019-06-25  Tom Tromey  <tom@tromey.com>
5430
5431         * tui/tui-winsource.c (tui_erase_source_content)
5432         (tui_show_source_content, tui_show_exec_info_content)
5433         (tui_erase_exec_info_content): Use refresh_window method.
5434         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5435         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5436         from tui_refresh_win.
5437         (tui_data_window::refresh_window): New method.
5438         (tui_win_info::refresh, tui_source_window_base::refresh)
5439         (tui_refresh_all): Use refresh_window method.
5440         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5441         method.
5442         * tui/tui-regs.c (tui_display_register): Call refresh_window
5443         method.
5444         * tui/tui-layout.c (show_source_disasm_command)
5445         (show_source_or_disasm_and_command): Call refresh_window method.
5446         * tui/tui-data.h (struct tui_gen_win_info)
5447         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5448         New method.
5449
5450 2019-06-25  Tom Tromey  <tom@tromey.com>
5451
5452         * tui/tui.c (tui_rl_other_window, tui_enable)
5453         (tui_is_window_visible, tui_get_command_dimension): Update.
5454         * tui/tui-winsource.c (tui_update_source_window_as_is)
5455         (tui_clear_source_content, tui_erase_source_content)
5456         (tui_show_source_line, tui_source_window_base::refill)
5457         (tui_source_window_base::do_scroll_horizontal)
5458         (tui_source_window_base::set_is_exec_point_at)
5459         (tui_update_breakpoint_info, tui_set_exec_info_content)
5460         (tui_alloc_source_buffer, tui_line_is_displayed)
5461         (tui_addr_is_displayed): Update.
5462         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5463         (tui_check_and_display_highlight_if_needed)
5464         (tui_win_info::make_visible, tui_win_info::refresh)
5465         (tui_refresh_all): Update.
5466         * tui/tui-windata.c (tui_first_data_item_displayed)
5467         (tui_delete_data_content_windows, tui_erase_data_content)
5468         (tui_display_all_data, tui_data_window::refresh_all)
5469         (tui_check_data_values): Update.
5470         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5471         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5472         (tui_win_info::backward_scroll, tui_refresh_all_win)
5473         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5474         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5475         (tui_source_window_base::set_new_height)
5476         (tui_data_window::set_new_height)
5477         (make_invisible_and_set_new_height)
5478         (make_visible_with_new_height, new_height_ok)
5479         (parse_scrolling_args): Update.
5480         * tui/tui-stack.c (tui_show_frame_info): Update.
5481         * tui/tui-source.c (tui_set_source_content)
5482         (tui_set_source_content_nil, tui_source_is_displayed)
5483         (tui_source_window::do_scroll_vertical): Update.
5484         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5485         (tui_display_registers_from, tui_display_reg_element_at_line)
5486         (tui_check_register_values, tui_reg_command): Update.
5487         * tui/tui-layout.c (tui_default_win_height)
5488         (show_source_disasm_command, show_data, init_and_make_win)
5489         (show_source_or_disasm_and_command): Update.
5490         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5491         (tui_redisplay_readline, tui_mld_flush)
5492         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5493         (tui_getc): Update.
5494         * tui/tui-disasm.c (tui_set_disassem_content)
5495         (tui_disasm_window::do_scroll_vertical): Update.
5496         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5497         Now virtual.
5498         (struct tui_win_info): Derive from tui_gen_win_info.
5499         <~tui_win_info>: Mark as override.
5500         <generic>: Remove member.
5501         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5502         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5503         (~tui_data_window, ~tui_win_info)
5504         (tui_free_all_source_wins_content): Update.
5505         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5506
5507 2019-06-25  Tom Tromey  <tom@tromey.com>
5508
5509         * tui/tui-layout.c (init_and_make_win): Use new.
5510         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5511         destructor, initializers.
5512         (tui_alloc_generic_win_info): Don't declare.
5513         * tui/tui-data.c (_locator): Add argument to constructor.
5514         (source_win, disasm_win): New globals.
5515         (exec_info): Remove.
5516         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5517         Update.
5518         (tui_alloc_generic_win_info): Remove.
5519         (init_content_element): Use new.
5520         (tui_win_info::tui_win_info): Update.
5521         (free_content_elements) <case DATA_WIN>: Use delete.
5522
5523 2019-06-25  Tom Tromey  <tom@tromey.com>
5524
5525         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5526         * tui/tui-windata.c (tui_first_data_item_displayed)
5527         (tui_delete_data_content_windows): Update.
5528         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5529         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5530         (tui_display_registers_from, tui_check_register_values): Update.
5531         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5532         pointer.
5533         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5534         window.
5535         (tui_free_data_content): Update.
5536         (free_content_elements) <case DATA_WIN>: Free the window.
5537
5538 2019-06-25  Tom Tromey  <tom@tromey.com>
5539
5540         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5541         Update.
5542         * tui/tui-layout.c (make_command_window)
5543         (show_source_disasm_command, show_data, init_and_make_win)
5544         (show_source_or_disasm_and_command): Update.
5545         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5546         method.
5547         <can_highight, is_highlighted>: Now bool.
5548         (tui_set_win_highlight): Don't declare.
5549         * tui/tui-data.c (tui_set_win_highlight): Remove.
5550
5551 2019-06-25  Tom Tromey  <tom@tromey.com>
5552
5553         * tui/tui-wingeneral.c (make_visible): Remove check of window
5554         type.
5555
5556 2019-06-25  Tom Tromey  <tom@tromey.com>
5557
5558         * tui/tui-win.c (tui_win_info::max_height)
5559         (tui_cmd_window::max_height): New methods.
5560         (new_height_ok): Call max_height.
5561         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5562         <max_height>: New method.
5563
5564 2019-06-25  Tom Tromey  <tom@tromey.com>
5565
5566         * tui/tui-win.c (tui_source_window_base::set_new_height)
5567         (tui_data_window::set_new_height): New methods.
5568         (make_invisible_and_set_new_height): Call set_new_height method.
5569         * tui/tui-data.h (struct tui_win_info)
5570         (struct tui_source_window_base, struct tui_data_window)
5571         <set_new_height>: New method.
5572
5573 2019-06-25  Tom Tromey  <tom@tromey.com>
5574
5575         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5576         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5577         tui_refresh_data_win.
5578         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5579         method.
5580         (tui_refresh_all_win): Call the refresh_all method.
5581         (tui_set_focus): Likewise.
5582         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5583         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5584         Likewise.
5585
5586 2019-06-25  Tom Tromey  <tom@tromey.com>
5587
5588         * tui/tui-winsource.h (tui_refill_source_window)
5589         (tui_set_is_exec_point_at): Don't declare.
5590         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5591         (tui_source_window_base::refill): Rename from
5592         tui_refill_source_window.
5593         (tui_source_window_base::do_scroll_horizontal): Update.
5594         (tui_source_window_base::set_is_exec_point_at): Rename from
5595         tui_set_is_exec_point_at.
5596         (tui_update_all_breakpoint_info): Update.
5597         * tui/tui-stack.c (tui_show_frame_info): Update.
5598         * tui/tui-layout.c (show_data): Add cast.
5599         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5600         * tui/tui-data.h (struct tui_source_window_base) <refill,
5601         set_is_exec_point_at>: New methods.
5602         (tui_source_windows, tui_add_to_source_windows): Update types.
5603         (tui_add_to_source_windows): Remove redundant declaration.
5604         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5605         (tui_source_windows): Change return type.
5606         (tui_clear_source_windows_detail): Update.
5607         (tui_add_to_source_windows): Change type of parameter.
5608         (tui_free_all_source_wins_content): Update.
5609
5610 2019-06-25  Tom Tromey  <tom@tromey.com>
5611
5612         * tui/tui-wingeneral.c (tui_win_info::refresh)
5613         (tui_source_window_base::refresh): New methods.
5614         (tui_refresh_all): Call the refresh method.
5615         * tui/tui-data.h (struct tui_win_info)
5616         (struct tui_source_window_base) <refresh>: New method.
5617
5618 2019-06-25  Tom Tromey  <tom@tromey.com>
5619
5620         * tui/tui.h (tui_is_window_visible): Return bool.
5621         * tui/tui.c (tui_is_window_visible): Return bool.
5622         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5623         (tui_make_visible, tui_make_invisible)
5624         (tui_win_info::make_visible)
5625         (tui_source_window_base::make_visible, make_all_visible)
5626         (tui_make_all_visible, tui_make_all_invisible): Update.
5627         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5628         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5629         bool.
5630         (struct tui_win_info, struct tui_source_window_base)
5631         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5632         * tui/tui-data.c (tui_init_generic_part): Update.
5633
5634 2019-06-25  Tom Tromey  <tom@tromey.com>
5635
5636         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5637         (tui_source_window_base::make_visible): New methods.
5638         (make_all_visible): Make method call.
5639         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5640         (struct tui_source_window_base, struct tui_cmd_window): Override
5641         make_visible.
5642         (tui_win_is_source_type): Don't declare.
5643         * tui/tui-data.c (tui_win_is_source_type): Remove.
5644
5645 2019-06-25  Tom Tromey  <tom@tromey.com>
5646
5647         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5648         NULL check.
5649
5650 2019-06-25  Tom Tromey  <tom@tromey.com>
5651
5652         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5653         Inline constructor.  Add initializers for members.
5654         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5655         constructors; now inline in class.
5656
5657 2019-06-25  Tom Tromey  <tom@tromey.com>
5658
5659         * tui/tui-regs.c (tui_show_registers): Update.
5660         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5661         bool.
5662         * tui/tui-data.c (tui_data_window::clear_detail)
5663         (tui_data_window): Update.
5664
5665 2019-06-25  Tom Tromey  <tom@tromey.com>
5666
5667         * tui/tui-windata.c (tui_display_all_data)
5668         (tui_display_data_from_line, tui_display_data_from)
5669         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5670         Update.
5671         * tui/tui-regs.c (tui_last_regs_line_no)
5672         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5673         (tui_show_registers, tui_show_register_group)
5674         (tui_display_registers_from, tui_display_reg_element_at_line)
5675         (tui_display_registers_from_line, tui_check_register_values)
5676         (tui_reg_next, tui_reg_prev): Update.
5677         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5678         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5679         tui_data_window.
5680         (struct tui_win_info) <detail>: Remove.  Add new fields from
5681         tui_data_info.
5682         (TUI_DATA_WIN): Add cast.
5683         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5684         (~tui_data_window): Simplify.
5685
5686 2019-06-25  Tom Tromey  <tom@tromey.com>
5687
5688         * tui/tui-layout.c (show_source_disasm_command)
5689         (show_source_or_disasm_and_command): Update.
5690         * tui/tui-io.c (update_cmdwin_start_line)
5691         (tui_redisplay_readline): Update.
5692         * tui/tui-data.h (struct tui_command_info): Remove.
5693         (struct tui_win_info) <detail>: Remove command_info member.
5694         (struct tui_data_window) <start_line>: New member, from
5695         tui_command_info.
5696         (TUI_CMD_WIN): Add casts.
5697
5698 2019-06-25  Tom Tromey  <tom@tromey.com>
5699
5700         * tui/tui-winsource.c (tui_update_source_window)
5701         (tui_refill_source_window)
5702         (tui_source_window_base::do_scroll_horizontal)
5703         (tui_update_breakpoint_info, tui_set_exec_info_content)
5704         (tui_show_exec_info_content, tui_erase_exec_info_content)
5705         (tui_clear_exec_info_content): Update.
5706         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5707         Update.
5708         * tui/tui-win.c (make_invisible_and_set_new_height)
5709         (make_visible_with_new_height): Update.
5710         * tui/tui-source.c (tui_set_source_content)
5711         (tui_show_symtab_source): Update.
5712         * tui/tui-layout.c (extract_display_start_addr)
5713         (show_source_disasm_command, show_data)
5714         (make_source_or_disasm_window)
5715         (show_source_or_disasm_and_command): Update.
5716         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5717         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5718         "gdbarch".
5719         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5720         to tui_source_window_base.
5721         (struct tui_win_info) <detail>: Remove source_info member.
5722         (struct tui_source_window_base) <has_locator>: Inline.
5723         Move contents from tui_source_info; rename has_locator member to
5724         m_has_locator.
5725         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5726         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5727         header file.
5728         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5729         Simplify.
5730         (tui_free_all_source_wins_content): Cast to
5731         tui_source_window_base.
5732
5733 2019-06-25  Tom Tromey  <tom@tromey.com>
5734
5735         * tui/tui-win.c (make_invisible_and_set_new_height)
5736         (make_visible_with_new_height): Call has_locator method.
5737         * tui/tui-layout.c (show_source_disasm_command, show_data)
5738         (show_source_or_disasm_and_command): Update for bool change.
5739         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5740         (tui_win_info) <has_locator>: New method.
5741         (struct tui_source_window_base) <has_locator>: New method.
5742         (tui_win_has_locator): Don't declare.
5743         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5744         from tui_win_has_locator.
5745         (tui_source_window_base): Use false, not FALSE.
5746
5747 2019-06-25  Tom Tromey  <tom@tromey.com>
5748
5749         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5750         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5751         clear_detail method directly.
5752         (tui_clear_win_detail): Remove.
5753
5754 2019-06-25  Tom Tromey  <tom@tromey.com>
5755
5756         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5757         "this", not TUI_DISASM_WIN.
5758
5759 2019-06-25  Tom Tromey  <tom@tromey.com>
5760
5761         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5762         declare.
5763         * tui/tui-winsource.c
5764         (tui_source_window_base::do_scroll_horizontal): Rename from
5765         tui_horizontal_source_scroll.
5766         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5767         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5768         from tui_vertical_data_scroll.
5769         * tui/tui-win.h (tui_scroll): Don't declare.
5770         * tui/tui-win.c (tui_win_info::forward_scroll)
5771         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5772         (tui_win_info::right_scroll): Rename and update.
5773         (tui_scroll_forward_command, tui_scroll_backward_command)
5774         (tui_scroll_left_command, tui_scroll_right_command): Update.
5775         (tui_scroll): Remove.
5776         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5777         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5778         from tui_vertical_source_scroll.
5779         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5780         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5781         from tui_vertical_disassem_scroll.
5782         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5783         do_scroll_horizontal>: New methods.
5784         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5785         Likewise.
5786         (struct tui_source_window_base): Add do_scroll_horizontal.
5787         (struct tui_source_window, struct tui_disasm_window): Add
5788         do_scroll_vertical.
5789         (struct tui_data_window, struct tui_cmd_window): Add
5790         do_scroll_horizontal and do_scroll_vertical.
5791         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5792
5793 2019-06-25  Tom Tromey  <tom@tromey.com>
5794
5795         * tui/tui-data.h (struct tui_source_window_base): New struct.
5796         (struct tui_source_window): Derive from tui_source_window_base.
5797         (struct tui_disasm_window): New struct.
5798         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5799         from tui_source_window::clear_detail.
5800         (tui_source_window_base): Rename from tui_source_window.
5801         (~tui_source_window_base): Rename from ~tui_source_window.
5802         (tui_alloc_win_info): Create a tui_disasm_window.
5803
5804 2019-06-25  Tom Tromey  <tom@tromey.com>
5805
5806         * tui/tui-data.h (struct tui_source_window)
5807         (struct tui_data_window): Declare destructors.
5808         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5809         destructors.
5810         (tui_win_info): Simplify.
5811
5812 2019-06-25  Tom Tromey  <tom@tromey.com>
5813
5814         * tui/tui-winsource.c (tui_display_main)
5815         (tui_update_source_windows_with_addr)
5816         (tui_update_all_breakpoint_info): Update.
5817         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5818         (new_height_ok, parse_scrolling_args): Update.
5819         * tui/tui-stack.c (tui_show_frame_info): Update.
5820         * tui/tui-data.h (struct tui_list): Remove.
5821         (tui_source_windows): Return a reference to a std::vector.
5822         * tui/tui-data.c (source_windows): Now a std::vector.
5823         (tui_source_windows): Change return type.
5824         (tui_clear_source_windows): Rewrite.
5825         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5826         (tui_free_all_source_wins_content): Rewrite.
5827
5828 2019-06-25  Tom Tromey  <tom@tromey.com>
5829
5830         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5831         (struct tui_data_window, struct tui_cmd_window): Declare
5832         clear_detail method.
5833         * tui/tui-data.c (tui_source_window::clear_detail)
5834         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5835         methods.
5836         (tui_clear_win_detail): Simplify.
5837
5838 2019-06-25  Tom Tromey  <tom@tromey.com>
5839
5840         * tui/tui-layout.c (make_source_window, make_disasm_window)
5841         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5842         Return the new window.
5843         (show_source_disasm_command, show_data)
5844         (show_source_or_disasm_and_command): Update.
5845
5846 2019-06-25  Tom Tromey  <tom@tromey.com>
5847
5848         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5849         parameter.  Return the new window.
5850         (show_source_disasm_command): Update and remove NULL check.
5851         (show_source_or_disasm_and_command): Update.
5852
5853 2019-06-25  Tom Tromey  <tom@tromey.com>
5854
5855         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5856
5857 2019-06-25  Tom Tromey  <tom@tromey.com>
5858
5859         * tui/tui-data.h (struct tui_win_info): Make constructor
5860         protected.  Make destructor virtual.  Add initializers.
5861         (tui_source_window, tui_data_window, tui_cmd_window): New
5862         classes.
5863         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5864         constructor.  Add "type" parameter.
5865         (tui_source_window, tui_data_window, tui_cmd_window): New
5866         constructors.
5867         (tui_alloc_win_info): Instantiate the appropriate subclass.
5868
5869 2019-06-25  Tom Tromey  <tom@tromey.com>
5870
5871         * tui/tui-win.c (tui_resize_all): Use delete.
5872         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5873         destructor.
5874         (tui_free_window): Don't declare.
5875         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5876         Update.
5877
5878 2019-06-25  Tom Tromey  <tom@tromey.com>
5879
5880         * tui/tui-data.h (struct tui_win_info): Add constructor.
5881         * tui/tui-data.c (tui_alloc_win_info): Use new.
5882         (tui_free_window): Use delete.
5883
5884 2019-06-22  Tom Tromey  <tom@tromey.com>
5885
5886         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5887         declare.
5888         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5889
5890 2019-06-22  Tom Tromey  <tom@tromey.com>
5891
5892         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5893         declare.
5894         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5895
5896 2019-06-22  Tom de Vries  <tdevries@suse.de>
5897
5898         * dwarf2read.c (create_addrmap_from_aranges)
5899         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5900         instead of '%zu'.
5901
5902 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5903
5904         * dwarf2read.h (dwarf2_section_info_def): Remove.
5905         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5906         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5907         std::vector<dwarf2_section_info>.
5908         (struct dwo_file) <~dwo_file>: Remove.
5909         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5910         types field.
5911         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5912         (dwarf2_read_debug_names): Likewise.
5913         (create_debug_types_hash_table): Change parameter type to
5914         array_view, adjust code accordingly.
5915         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5916         (partial_die_info::fixup): Likewise.
5917         (determine_prefix): Likewise.
5918         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5919
5920 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5921
5922         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5923         gdb_bfd_ref_ptr.
5924         <~dwo_file>: Remove call to gdb_bfd_unref.
5925         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5926         gdb_bfd_ref_ptr::get.
5927
5928 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5929
5930         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5931         type to htab_up.
5932         * dwarf2read.c (struct dwo_file): Initialize fields.
5933         <~dwo_file>: New.
5934         (free_dwo_file): Remove, move content to ~dwo_file.
5935         (struct dwo_file_deleter): Remove.
5936         (dwo_file_up>: Remove custom deleter.
5937         (free_dwo_files): Remove.
5938         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5939         dwo_files.
5940         (process_skeletonless_type_units): Call unique_ptr::get.
5941         (allocate_dwo_file_hash_table): Add deleter to created hash
5942         table.  Change return type to htab_up.
5943         (lookup_dwo_file_slot): Don't memset dwo_file, call
5944         unique_ptr::get.
5945         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5946         (create_dwo_unit_in_dwp_v2): Likewise.
5947         (open_and_init_dwo_file): Likewise.
5948         (free_dwo_file_from_slot): Remove.
5949
5950 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5951
5952         * dwarf2read.h (struct dwarf2_section_info) <readin,
5953         is_virtual>: Change type to bool.
5954         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5955         true instead of 1.
5956
5957 2019-06-19  Tom Tromey  <tom@tromey.com>
5958
5959         * tui/tui-data.h (tui_init_content_element): Don't declare.
5960
5961 2019-06-19  Tom Tromey  <tom@tromey.com>
5962
5963         * tui/tui-data.h (tui_init_win_info): Don't declare.
5964
5965 2019-06-19  Tom de Vries  <tdevries@suse.de>
5966
5967         * dwarf2read.h (abstract_to_concrete): Change type to
5968         std::unordered_map<sect_offset, std::vector<sect_offset>,
5969         gdb::hash_enum<sect_offset>>.
5970
5971 2019-06-19  Tom Tromey  <tromey@adacore.com>
5972
5973         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5974         EVAL_AVOID_SIDE_EFFECTS specially.
5975
5976 2019-06-19  Tom Tromey  <tromey@adacore.com>
5977
5978         * source-cache.c (highlighter): New global.
5979         (source_cache::get_source_lines): Create a highlighter on demand.
5980
5981 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5982
5983         * defs.h (deprecated_interactive_hook): Delete declaration.
5984         * interps.c (clear_interpreter_hooks): Remove use of
5985         deprecated_interactive_hook.
5986         * top.c (deprecated_interactive_hook): Delete definition.
5987         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5988
5989 2019-06-18  Tom de Vries  <tdevries@suse.de>
5990
5991         PR gdb/24515
5992         * dwarf2read.h (abstract_to_concrete): Change type from
5993         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5994         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5995         * dwarf2read.c (read_variable): Update.
5996         (dwarf2_fetch_die_loc_sect_off): Update.
5997
5998 2019-06-17  Tom de Vries  <tdevries@suse.de>
5999
6000         PR gdb/24617
6001         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6002         accessing parent[parent_len - 1].
6003
6004 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6005
6006         PR gdb/24364
6007         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6008         call dtrace_process_dof with NULL dof.
6009
6010 2019-06-16  Tom de Vries  <tdevries@suse.de>
6011
6012         PR gdb/24445
6013         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6014
6015 2019-06-16  Tom Tromey  <tom@tromey.com>
6016
6017         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6018         (make_all_visible): Use address of member.
6019
6020 2019-06-16  Tom Tromey  <tom@tromey.com>
6021
6022         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6023         (tui_free_window, free_content, free_content_elements): Remove
6024         unnecessary cast.
6025         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6026         cast.
6027         * tui/tui-regs.c (tui_show_register_group)
6028         (tui_display_registers_from, tui_display_reg_element_at_line):
6029         Remove unnecessary cast.
6030
6031 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6032
6033         * linux-nat.c (normal_mask): Delete.
6034         (_initialize_linux_nat): Don't initialise normal_mask.
6035
6036 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6037
6038         PR gdb/24445
6039         * dwarf-index-write.h (write_psymtabs_to_index): Add
6040         dwz_basename parameter.
6041         * dwarf-index-write.c (write_gdbindex): Move file writing to
6042         write_gdbindex_1.  Change return type void.
6043         (assert_file_size): Move up, remove filename parameter.
6044         (write_gdbindex_1): New function.
6045         (write_debug_names): Change return type to void, call
6046         assert_file_size.
6047         (struct index_wip_file): New struct.
6048         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6049         file logic to index_wip_file.  Write index for dwz file if
6050         needed.
6051         (save_gdb_index_command): Pass basename of dwz file, if present.
6052         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6053         build-id of dwz file, if present.
6054         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6055         (dwarf2_get_dwz_file): Likewise.
6056         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6057         (dwarf2_get_dwz_file): Likewise.
6058
6059 2019-06-16  Tom Tromey  <tom@tromey.com>
6060
6061         * coffread.c (process_coff_symbol): Use xstrdup.
6062         * value.c (create_internalvar): Use xstrdup.
6063
6064 2019-06-16  Tom Tromey  <tom@tromey.com>
6065
6066         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6067         * breakpoint.c (stopin_command, stopat_command)
6068         (until_break_command, decode_location_default): Remove unnecessary
6069         cast.
6070         * utils.c (subset_compare): Remove unnecessary cast.
6071         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6072         cast.
6073         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6074         cast.
6075         * infcmd.c (path_command): Remove unnecessary cast.
6076         * coffread.c (decode_type): Remove unnecessary cast.
6077         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6078         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6079         * tui/tui-stack.c (tui_show_locator_content)
6080         (tui_show_frame_info): Remove unnecessary cast.
6081         * tui/tui-win.c (tui_scroll_forward_command)
6082         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6083         (parse_scrolling_args): Remove unnecessary cast.
6084         * tui/tui-data.c (init_win_info, tui_del_window)
6085         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6086         (free_content_elements): Remove unnecessary cast.
6087         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6088         unnecessary cast.
6089         * tui/tui-source.c (tui_set_source_content)
6090         (tui_vertical_source_scroll): Remove unnecessary cast.
6091         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6092         cast.
6093         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6094         * tui/tui-regs.c (tui_display_registers_from)
6095         (tui_display_register): Remove unnecessary cast.
6096         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6097         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6098         (make_visible): Remove unnecessary cast.
6099         * tui/tui-winsource.c (tui_erase_source_content)
6100         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6101         unnecessary cast.
6102         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6103         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6104         * stabsread.c (read_type, read_array_type, read_range_type):
6105         Remove unnecessary cast.
6106         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6107         (parse_symbol, parse_type, upgrade_type, parse_external)
6108         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6109         unnecessary cast.
6110         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6111
6112 2019-06-16  Tom Tromey  <tom@tromey.com>
6113
6114         * tui/tui-data.c (tui_alloc_generic_win_info)
6115         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6116         checks.
6117
6118 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6119             Andrew Burgess  <andrew.burgess@embecosm.com>
6120
6121         * f-typeprint.c (f_print_type): Don't return early for not
6122         associated or not allocated types.
6123         (f_type_print_varspec_suffix): Add print_rank parameter and print
6124         ranks of array types in case they dangling.
6125         (f_type_print_base): Add print_rank parameter.
6126
6127 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6128
6129         * NEWS: Mention new MI commands.
6130         * break-catch-throw.c (enum exception_event_kind): Move to
6131         breakpoint.h.
6132         (print_mention_exception_catchpoint): Output text as a single
6133         message.
6134         (catch_exception_command_1): Rename to...
6135         (catch_exception_event): ...this, make non-static, update header
6136         command, and change some parameter types.
6137         (catch_catch_command): Update for changes to
6138         catch_exception_command_1.
6139         (catch_throw_command): Likewise.
6140         (catch_rethrow_command): Likewise.
6141         * breakpoint.c (enum exception_event_kind): Delete.
6142         * breakpoint.h (enum exception_event_kind): Moved here from
6143         break-catch-throw.c.
6144         (catch_exception_event): Declare.
6145         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6146         (mi_cmd_catch_throw): New function.
6147         (mi_cmd_catch_rethrow): New function.
6148         (mi_cmd_catch_catch): New function.
6149         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6150         'catch-catch' entries.
6151         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6152         (mi_cmd_catch_rethrow): Declare.
6153         (mi_cmd_catch_catch): Declare.
6154
6155 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6156
6157         * annotate.c (annotate_source_line): Change return type to void,
6158         update implementation to match.
6159         * annotate.h (annotate_source_line): Change return type to void,
6160         update header comment.
6161         * stack.c (print_frame_info): Don't change what frame information
6162         is printed based on whether annotations are on or not.
6163
6164 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6165
6166         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6167         (annotate_source): Make static.
6168         (annotate_source_line): Moved from source.c and renamed from
6169         identify_source_line.  Update the return type.
6170         * annotate.h (annotate_source): Delete declaration.
6171         (annotate_source_line): Declaration moved from source.h, and
6172         renamed from identify_source_line.  Return type updated.
6173         * source.c (identify_source_line): Moved to annotate.c and renamed
6174         to annotate_source_line.
6175         (info_line_command): Remove check of annotation_level.
6176         * source.h (identify_source_line): Move declaration to annotate.h
6177         and rename to annotate_source_line.
6178         * stack.c: Add 'annotate.h' include.
6179         (print_frame_info): Remove check of annotation_level before
6180         calling annotate_source_line.
6181
6182 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6183
6184         * source-cache.c (source_cache::get_plain_source_lines): Use
6185         open_source_file_with_line_charpos instead of just
6186         open_source_file, remove call to find_source_lines.
6187         (source_cache::get_source_lines): Likewise.
6188         * source.c (find_source_lines): Make static.
6189         (get_filename_and_charpos): Renamed into...
6190         (open_source_file_with_line_charpos): ..this along with changes to
6191         return a scoped_fd, and some other minor clean ups.
6192         (identify_source_line): Use open_source_file_with_line_charpos.
6193         (search_command_helper): Use open_source_file_with_line_charpos
6194         instead of just open_source_file, remove call to
6195         find_source_lines.
6196         * source.h (open_source_file_with_line_charpos): Declare new
6197         function.
6198         (find_source_lines): Delete declaration.
6199
6200 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6201
6202         * source.c (get_filename_and_charpos): Remove fullname
6203         parameter.
6204         (identify_source_line): Update call to get_filename_and_charpos.
6205
6206 2019-06-14  Tom Tromey  <tromey@adacore.com>
6207
6208         PR gdb/24502:
6209         * ui-style.h (skip_ansi_escape): Update comment.
6210         * ui-file.h (class no_terminal_escape_file): New class.
6211         * ui-file.c (no_terminal_escape_file::write)
6212         (no_terminal_escape_file::puts): New methods.
6213         * cli/cli-logging.c (handle_redirections): Use
6214         no_terminal_escape_file.
6215
6216 2019-06-14  Tom Tromey  <tromey@adacore.com>
6217
6218         * NEWS: Move convenience variable news above Python news.
6219
6220 2019-06-14  Tom Tromey  <tom@tromey.com>
6221
6222         * gnulib: Move directory to top-level.
6223         * configure.ac: Don't configure gnulib.
6224         * configure: Rebuild.
6225         * common/common-defs.h: Use new path to gnulib.
6226         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6227         (GNULIB_H): Remove.
6228         (INCGNU): Look in new gnulib location.
6229         (HFILES_NO_SRCDIR): Remove gnulib files.
6230         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6231         (generated_files): Remove GNULIB_H.
6232         ($(LIBGNU), all-lib): Remove targets.
6233         (distclean): Don't mention GNULIB_BUILDDIR.
6234         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6235
6236 2019-06-14  Tom Tromey  <tromey@adacore.com>
6237
6238         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6239         Warn if symbol file does not provide any symbols.
6240
6241 2019-06-14  Tom Tromey  <tromey@adacore.com>
6242
6243         * source.c (find_and_open_source): Respect basenames_may_differ.
6244
6245 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6246
6247         * annotate.c (annotate_breakpoints_invalid): Make use of
6248         scoped_restore_terminal_state.
6249         (annotate_frames_invalid): Likewise.
6250
6251 2019-06-14  Tom Tromey  <tromey@adacore.com>
6252
6253         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6254         allow assignment to an internalvar.
6255
6256 2019-06-14  Tom Tromey  <tromey@adacore.com>
6257
6258         * ada-lex.l: Allow "_" in attribute names.
6259
6260 2019-06-14  Tom Tromey  <tromey@adacore.com>
6261
6262         PR gdb/24653:
6263         * regcache.c (registers_changed): Don't call alloca.
6264         * top.c (execute_command): Don't call alloca.
6265
6266 2019-06-13  Pedro Alves  <palves@redhat.com>
6267
6268         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6269         'expression'.  When parsing an expression, error out if there's
6270         junk after "unlimited".
6271         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6272         (do_set_command): Adjust calls to is_unlimited_literal.
6273
6274 2019-06-13  Pedro Alves  <palves@redhat.com>
6275
6276         * compile/compile.c (make_compile_options_def_group): Add braces
6277         around array_view initializer.
6278         * thread.c (make_thread_apply_all_options_def_group)
6279         (make_thread_apply_all_options_def_group): Likewise.
6280
6281 2019-06-13  Pedro Alves  <palves@redhat.com>
6282
6283         * NEWS (New commands): Mention "maint test-options
6284         require-delimiter", "maint test-options unknown-is-error", "maint
6285         test-options unknown-is-operand" and "maint show
6286         test-options-completion-result".
6287         (New command options, command completion): New section.
6288         (Completion improvements): New section.
6289         Mention that you can abbreviate "unlimited".
6290
6291 2019-06-13  Pedro Alves  <palves@redhat.com>
6292
6293         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6294         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6295         * unittests/cli-utils-selftests.c (test_parse_flags)
6296         (test_parse_flags_qcs): Delete.
6297         (test_cli_utils): Don't call deleted functions.
6298
6299 2019-06-13  Pedro Alves  <palves@redhat.com>
6300
6301         * thread.c: Include "cli/cli-option.h".
6302         (tp_array_compar_ascending): Global.
6303         (tp_array_compar): Delete function.
6304         (tp_array_compar_ascending, tp_array_compar_descending): New
6305         functions.
6306         (ascending_option_def, qcs_flag_option_def)
6307         (thr_qcs_flags_option_defs)
6308         (make_thread_apply_all_options_def_group)
6309         (make_thread_apply_options_def_group): New.
6310         (thread_apply_all_command): Use gdb::option::process_options.
6311         (thread_apply_command_completer)
6312         (thread_apply_all_command_completer): New.
6313         (thread_apply_command): Use gdb::option::process_options.
6314         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6315         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6316         to generate help text of "thread apply".  Adjust "taas"'s help.
6317         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6318         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6319
6320 2019-06-13  Pedro Alves  <palves@redhat.com>
6321
6322         * thread.c (thread_apply_command): Check for invalid TID with
6323         isdigit instead of !isalpha.
6324
6325 2019-06-13  Pedro Alves  <palves@redhat.com>
6326
6327         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6328         (validate_flags_qcs): New.
6329         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6330         (validate_flags_qcs): Declare.
6331         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6332         (make_frame_apply_options_def_group): New.
6333         (frame_apply_command_count): Process options with
6334         gdb::option::process_options.
6335         (frame_apply_completer): New.
6336         (frame_apply_level_completer, frame_apply_all_completer)
6337         (frame_apply_completer): New.
6338         (_initialize_stack): Update help of "frame apply", "frame apply
6339         level", "frame apply all" and "faas" to mention supported options
6340         and install command completers.
6341         * stack.h (frame_apply_all_completer): Declare.
6342         * thread.c: Include "stack.h".
6343         (tfaas_command): Add "--".
6344         (_initialize_thread): Update help "tfaas" to mention supported
6345         options and install command completer.
6346
6347 2019-06-13  Pedro Alves  <palves@redhat.com>
6348
6349         * completer.c (complete_nested_command_line): New.
6350         (gdb_completion_word_break_characters_throw): Add assertion.
6351         * completer.h (complete_nested_command_line): Declare.
6352
6353 2019-06-13  Pedro Alves  <palves@redhat.com>
6354
6355         * stack.c (parse_backtrace_qualifiers): New.
6356         (backtrace_command): Use it.
6357         (backtrace_command_completer): Complete on qualifiers.
6358
6359 2019-06-13  Pedro Alves  <palves@redhat.com>
6360
6361         * frame.c: Include "cli/cli-option.h.
6362         (user_set_backtrace_options): New.
6363         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6364         Delete.
6365         (get_prev_frame): Adjust.
6366         (boolean_option_def, uinteger_option_def)
6367         (set_backtrace_option_defs): New.
6368         (_initialize_frame): Adjust and use
6369         gdb::option::add_setshow_cmds_for_options to install "set
6370         backtrace past-main" and "set backtrace past-entry".
6371         * frame.h: Include "cli/cli-option.h".
6372         (struct frame_print_options): Forward declare.
6373         (print_frame_arguments_all, print_frame_arguments_scalars)
6374         (print_frame_arguments_none): Declare.
6375         (print_entry_values): Delete declaration.
6376         (struct frame_print_options, user_frame_print_options): New.
6377         (struct set_backtrace_options): New.
6378         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6379         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6380         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6381         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6382         (list_args_or_locals): Add frame_print_options parameter.
6383         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6384         * python/py-framefilter.c (enumerate_args): Pass down
6385         USER_FRAME_PRINT_OPTIONS.
6386         * stack.c: Include "cli/cli-option.h".
6387         (print_frame_arguments_all, print_frame_arguments_scalars)
6388         (print_frame_arguments_none): Declare.
6389         (print_raw_frame_arguments, print_entry_values): Delete.
6390         (user_frame_print_options): New.
6391         (boolean_option_def, enum_option_def, frame_print_option_defs):
6392         New.
6393         (struct backtrace_cmd_options): New.
6394         (bt_flag_option_def): New.
6395         (backtrace_command_option_defs): New.
6396         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6397         (print_frame_arg, read_frame_arg, print_frame_args)
6398         (print_frame_info, print_frame): Add frame_print_options parameter
6399         and use it.
6400         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6401         (backtrace_command_1): Add frame_print_options and
6402         backtrace_cmd_options parameters and use them.
6403         (make_backtrace_options_def_group): New.
6404         (backtrace_command): Process command options with
6405         gdb::option::process_options.
6406         (backtrace_command_completer): New.
6407         (_initialize_stack): Extend "backtrace"'s help to mention
6408         supported options.  Install completer for "backtrace".
6409         Install some settings commands with add_setshow_cmds_for_options.
6410
6411 2019-06-13  Pedro Alves  <palves@redhat.com>
6412
6413         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6414         and that "set/show print raw frame-arguments" are now deprecated.
6415
6416         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6417         command.
6418         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6419         * stack.c (_initialize_stack): Install "set/show print
6420         raw-frame-arguments", and deprecate "set/show print raw
6421         frame-arguments".
6422         * valprint.c (_initialize_valprint): Deprecate "set/show print
6423         raw".
6424
6425 2019-06-13  Pedro Alves  <palves@redhat.com>
6426
6427         * compile/compile.c (struct compile_options): New.
6428         (compile_flag_option_def, compile_command_option_defs)
6429         (make_compile_options_def_group): New.
6430         (compile_file_command): Handle options with
6431         gdb::option::process_options.
6432         (compile_file_command_completer): New function.
6433         (compile_code_command): Handle options with
6434         gdb::option::process_options.
6435         (compile_code_command_completer): New function.
6436         (_initialize_compiler): Install completers for "compile code" and
6437         "compile file".  Mention available options in "compile code" and
6438         "compile code"'s help.
6439         * completer.c (advance_to_completion_word): New, factored out from
6440         ...
6441         (advance_to_expression_complete_word_point): ... this.
6442         (advance_to_filename_complete_word_point): New.
6443         * completer.h (advance_to_filename_complete_word_point): New
6444         declaration.
6445
6446 2019-06-13  Pedro Alves  <palves@redhat.com>
6447
6448         * compile/compile.c: Include "cli/cli-option.h".
6449         (compile_print_value): Scope data pointer is now a
6450         value_print_options pointer; adjust.
6451         (compile_print_command): Process options.  Scope data pointer is
6452         now a value_print_options pointer; adjust.
6453         (_initialize_compile): Update "compile print"'s help to include
6454         supported options.  Install a completer for "compile print".
6455         * cp-valprint.c (show_vtblprint, show_objectprint)
6456         (show_static_field_print): Delete.
6457         (_initialize_cp_valprint): Don't install "set print
6458         static-members", "set print vtbl", "set print object" here.
6459         * printcmd.c: Include "cli/cli-option.h" and
6460         "common/gdb_optional.h".
6461         (print_command_parse_format): Rework to fill in a
6462         value_print_options instead of a format_data.
6463         (print_value): Change parameter type from format_data pointer to
6464         value_print_options reference.  Adjust.
6465         (print_command_1): Process options.  Adjust to pass down a
6466         value_print_options.
6467         (print_command_completer): New.
6468         (_initialize_printcmd): Install print_command_completer as
6469         handle_brkchars completer for the "print" command.  Update
6470         "print"'s help to include supported options.
6471         * valprint.c: Include "cli/cli-option.h".
6472         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6473         here from cp-valprint.c.
6474         (boolean_option_def, uinteger_option_def)
6475         (value_print_option_defs, make_value_print_options_def_group):
6476         New.  Use gdb::option::add_setshow_cmds_for_options to install
6477         "set print elements", "set print null-stop", "set print repeats",
6478         "set print pretty", "set print union", "set print array", "set
6479         print address", "set print symbol", "set print array-indexes".
6480         * valprint.h: Include <string> and "cli/cli-option.h".
6481         (make_value_print_options_def_group): Declare.
6482         (print_value): Change parameter type from format_data pointer to
6483         value_print_options reference.
6484         (print_command_completer): Declare.
6485
6486 2019-06-13  Pedro Alves  <palves@redhat.com>
6487
6488         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6489         (COMMON_SFILES): Add maint-test-settings.c.
6490         * cli/cli-decode.c (boolean_enums): New global, factored out from
6491         ...
6492         (add_setshow_boolean_cmd): ... here.
6493         * cli/cli-decode.h (boolean_enums): Declare.
6494         * cli/cli-option.c: New file.
6495         * cli/cli-option.h: New file.
6496         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6497         factored out from ...
6498         (parse_cli_boolean_value(const char *)): ... this.
6499         (is_unlimited_literal): Change parameter type to pointer to
6500         pointer.  Adjust and advance ARG pointer.
6501         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6502         (parse_cli_var_enum): New, factored out from ...
6503         (do_set_command): ... this.  Adjust.
6504         * cli/cli-setshow.h (parse_cli_boolean_value)
6505         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6506         (parse_cli_var_enum): Declare.
6507         * cli/cli-utils.c: Include "cli/cli-option.h".
6508         (get_ulongest): New.
6509         * cli/cli-utils.h (get_ulongest): Declare.
6510         (check_for_argument): New overloads.
6511         * maint-test-options.c: New file.
6512
6513 2019-06-13  Pedro Alves  <palves@redhat.com>
6514
6515         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6516         parse a range if "-" is at the end of the string.
6517
6518 2019-06-13  Pedro Alves  <palves@redhat.com>
6519
6520         * cli/cli-setshow.c (parse_auto_binary_operation)
6521         (parse_cli_boolean_value): Don't allow "o".
6522
6523 2019-06-13  Pedro Alves  <palves@redhat.com>
6524
6525         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6526         * NEWS: Mention maint test-settings KIND.
6527         * maint-test-settings.c: New file.
6528
6529 2019-06-13  Pedro Alves  <palves@redhat.com>
6530
6531         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6532         completer.
6533         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6534         "set" completers.
6535
6536 2019-06-13  Pedro Alves  <palves@redhat.com>
6537
6538         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6539         after item.
6540
6541 2019-06-13  Pedro Alves  <palves@redhat.com>
6542
6543         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6544
6545 2019-06-13  Pedro Alves <palves@redhat.com>
6546
6547         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6548         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6549         call.
6550         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6551         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6552         calls.
6553         (check_for_argument): Skip spaces after argument.
6554
6555 2019-06-13  Pedro Alves  <palves@redhat.com>
6556
6557         * thread.c (thread_apply_command): Adjust TID parsing.
6558         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6559         detected before end of string.
6560         (tid_is_in_list): Error out if LIST is invalid.
6561
6562 2019-06-13  Pedro Alves  <palves@redhat.com>
6563
6564         * completer.c (complete_line_internal_1): Rewind completion word
6565         point.
6566         (completion_tracker::advance_custom_word_point_by): Change
6567         parameter type to int.
6568         * completer.h (completion_tracker::advance_custom_word_point_by):
6569         Likewise.
6570
6571 2019-06-13  Pedro Alves  <palves@redhat.com>
6572
6573         * completer.c (advance_to_completion_word): Handle delimiters.
6574
6575 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6576
6577         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6578
6579 2019-06-11  Tom Tromey  <tom@tromey.com>
6580
6581         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6582         (xmalloc_failed): Move to alloc.c.
6583         * alloc.c: New file.
6584         * Makefile.in (COMMON_SFILES): Add alloc.c.
6585
6586 2019-06-11  Tom Tromey  <tom@tromey.com>
6587
6588         * nat/linux-waitpid.c: Don't include server.h.
6589         (linux_debug): Remove.
6590         (my_waitpid): Update.
6591
6592 2019-06-11  Tom Tromey  <tromey@adacore.com>
6593
6594         * infcall.c (_initialize_infcall): Remove trailing newline from
6595         help.
6596         * user-regs.c (_initialize_user_regs): Remove trailing newline
6597         from help.
6598         * typeprint.c (_initialize_typeprint): Remove trailing newline
6599         from help.
6600         * reverse.c (_initialize_reverse): Remove trailing newlines from
6601         help.
6602         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6603         from help.
6604         * language.c (add_set_language_command): Remove trailing newline
6605         from help.
6606         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6607         help.
6608         * disasm.c (_initialize_disasm): Remove trailing newline from
6609         help.
6610         * top.c (init_main): Remove trailing newline from help.
6611         * interps.c (_initialize_interpreter): Remove trailing newline
6612         from help.
6613         * btrace.c (_initialize_btrace): Remove trailing newlines from
6614         help.
6615         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6616         from help.
6617         * python/python.c (_initialize_python): Remove trailing newline
6618         from help.
6619         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6620         help.
6621         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6622         from help.  Reformat some text.
6623         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6624         from help.
6625         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6626         newline from help.
6627
6628 2019-06-11  Tom Tromey  <tromey@adacore.com>
6629
6630         * darwin-nat.c (darwin_decode_exception_message)
6631         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6632
6633 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6634
6635         * valops.c (value_slice): Check for not allocated or not
6636         associated values.
6637
6638 2019-06-10  Tom de Vries  <tdevries@suse.de>
6639
6640         PR gdb/24618
6641         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6642         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6643         invalid.
6644
6645 2019-06-10  Tom de Vries  <tdevries@suse.de>
6646
6647         PR gdb/24611
6648         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6649         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6650
6651 2019-06-10  Tom de Vries  <tdevries@suse.de>
6652
6653         PR symtab/24545
6654         * symtab.c (struct demangled_name_entry): Add language field.
6655         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6656         static minimal symbol".  Set and use language field.
6657
6658 2019-06-10  Tom Tromey  <tromey@adacore.com>
6659
6660         * ada-lang.c (_initialize_ada_language): Update help text.
6661
6662 2019-06-10  Tom Tromey  <tromey@adacore.com>
6663
6664         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6665         with a newline.
6666         * guile/guile.c (handle_boot_error): Don't end warning with a
6667         newline.
6668         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6669         warning with a newline.
6670         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6671         newline.
6672         (s12z_frame_cache): Likewise.
6673         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6674         a newline.
6675         * solib-svr4.c (disable_probes_interface): Don't end warning with
6676         a newline.
6677         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6678         newline.
6679         * python/python.c (do_finish_initialization): Don't end warning
6680         with a newline.
6681
6682 2019-06-10  Tom Tromey  <tom@tromey.com>
6683
6684         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6685         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6686         gdbpy_enter.
6687
6688 2019-06-10  Tom Tromey  <tromey@adacore.com>
6689
6690         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6691         data.
6692         (elf_new_init): Don't call stabsread_new_init.
6693         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6694         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6695         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6696
6697 2019-06-10  Tom de Vries  <tdevries@suse.de>
6698
6699         PR symtab/16264
6700         PR symtab/24517
6701         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6702
6703 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6704
6705         * source.c (find_and_open_source): Also rewrite relative file
6706         names.
6707
6708 2019-04-26  Amos Bird  <amosbird@gmail.com>
6709
6710         * annotate.c (annotate_thread_exited): Add "thread-exited"
6711         annotation.
6712
6713 2019-06-06  Tom Tromey  <tromey@adacore.com>
6714
6715         * maint.h (class scoped_command_stats): Use
6716         DISABLE_COPY_AND_ASSIGN.
6717         <print_time>: New method.
6718         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6719         print_time.
6720         (scoped_command_stats::print_time): New method.
6721
6722 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6723
6724         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6725         instructions of lengths 6 or 8 bytes.
6726
6727 2019-06-04  Pedro Alves  <palves@redhat.com>
6728
6729         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6730
6731         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6732         * breakpoint.c (condition_completer): Likewise.
6733         * cli/cli-dump.c (scan_expression): Likewise.
6734         * common/filestuff.c (mkdir_recursive): Likewise.
6735         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6736         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6737         (gdb_abspath): Likewise.
6738         * compile/compile-cplus-types.c
6739         (compile_cplus_instance::decl_name): Likewise.
6740         * completer.c (complete_explicit_location):
6741         (signal_completer, reg_or_group_completer_1): Likewise.
6742         * cp-support.c (cp_remove_params_if_any): Likewise.
6743         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6744         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6745         * infcmd.c (strip_bg_char): Likewise.
6746         * linespec.c (copy_token_string): Likewise.
6747         * mi/mi-main.c (output_cores): Likewise.
6748         * psymtab.c (psymtab_search_name):
6749         * symfile.c (test_set_ext_lang_command): Likewise.
6750         * target.c (target_fileio_read_stralloc): Likewise.
6751         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6752         * value.c (complete_internalvar): Likewise.
6753
6754 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6755
6756         Add objfile property to gdb.Type.
6757         * NEWS: Mention Python API addition.
6758         * python/py-type.c (typy_get_objfile): New method.
6759
6760 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6761
6762         * NEWS: Mention the new set|show style [title|highlight].
6763         Mention changes to "show style", "help" and "apropos".
6764
6765 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6766
6767         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6768         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6769         instead of print_help_for_command.
6770         (print_doc_of_command): New function.
6771         (help_list): Add 'apropos -v word' suggestion.
6772         (print_help_for_command): Style the command name using title style.
6773         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6774         (_initialize_cli_cmds): Describe -v in apropos_command help.
6775
6776 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6777
6778         * cli/cli-style.h (cli_style_option): Add name in constructor,
6779         add m_name class member, add constructor with intensity,
6780         add name class function.
6781         (cli_style_option::add_setshow_commands): Remove name argument.
6782         (highlight_style, title_style): New styles.
6783         * cli/cli-style.c (do_show): New function that shows a style
6784         characteristic styling the style name with itself.
6785         (set_style_name): New function.
6786         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6787         Update all callers according to the changes in cli/cli-style.h.
6788         * utils.h (fputs_highlighted): New function.
6789         * utils.c (fputs_highlighted): Likewise.
6790
6791 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6792
6793         * NEWS: Mention new pipe command and new convenience variables.
6794
6795 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6796
6797         * cli/cli-cmds.c (pipe_command): New function.
6798         (_initialize_cli_cmds): Call add_com for pipe_command.
6799         Define | as an alias for pipe.
6800         (exit_status_set_internal_vars): New function.
6801         (shell_escape): Call exit_status_set_internal_vars.
6802         cli/cli-decode.c (find_command_name_length): Recognize | as
6803         a single character command.
6804
6805 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6806
6807         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6808         top.c (execute_command_to_ui_file): New function, mostly a copy
6809         of execute_command_to_string.
6810         (execute_command_to_string): Implement by calling
6811         execute_command_to_ui_file.
6812
6813 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6814
6815         * top.h (saved_command_line): Remove declaration.
6816         * top.c (previous_saved_command_line, previous_repeat_arguments):
6817         New variables.
6818         (saved_command_line): Make static, define together with other
6819         'repeat variables'.
6820         (dont_repeat): Clear repeat_arguments.
6821         (repeat_previous, get_saved_command_line, save_command_line):
6822         New functions.
6823         (gdb_init): Initialize saved_command_line
6824         and previous_saved_command_line.
6825         * main.c (captured_main_1): Remove saved_command_line initialization.
6826         * event-top.c (handle_line_of_input): Update to use
6827         the new 'repeat' related functions instead of direct access to
6828         saved_command_line.
6829         * command.h (repeat_previous, get_saved_command_line,
6830         save_command_line): New declarations.
6831         (dont_repeat): Add comment.
6832
6833 2019-05-30  Tom Tromey  <tromey@adacore.com>
6834
6835         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6836         Fix comment.
6837         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6838
6839 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6840
6841         PR cli/24587
6842         * completer.c (complete): Initialize variable word.
6843
6844 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6845
6846         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6847         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6848         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6849         'body' is NULL to the outter 'if', protecting the '!is_define'
6850         situation as well.
6851
6852 2019-05-29  Tom Tromey  <tromey@adacore.com>
6853
6854         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6855         (dwarf_unknown): New function.
6856         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6857         (dwarf_type_encoding_name): Use dwarf_unknown.
6858
6859 2019-05-29  Tom Tromey  <tromey@adacore.com>
6860
6861         PR c++/20020:
6862         * cp-valprint.c (cp_print_value_fields): Call
6863         cp_print_static_field inside "try".
6864
6865 2019-05-29  Tom Tromey  <tromey@adacore.com>
6866
6867         * inflow.c (struct terminal_info): Add default operator=.
6868         * configure: Rebuild.
6869         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6870         -Wdeprecated-copy-dtor, -Wredundant-move.
6871
6872 2019-05-29  Tom Tromey  <tromey@adacore.com>
6873
6874         * NEWS: Add entry.
6875         * infcmd.c (print_return_value_1): Handle finish_print
6876         option.
6877         (show_print_finish): New function.
6878         (_initialize_infcmd): Add "set/show print finish" commands.
6879         * valprint.c (user_print_options): Initialize new member.
6880         * valprint.h (struct value_print_options) <finish_print>: New
6881         member.
6882
6883 2019-05-28  Tom Tromey  <tromey@adacore.com>
6884
6885         * ada-lang.c (ada_remove_Xbn_suffix)
6886         (find_old_style_renaming_symbol)
6887         (parse_old_style_renaming): Remove.
6888         (ada_find_renaming_symbol): Don't call
6889         find_old_style_renaming_symbol.
6890         (ada_is_renaming_symbol): Rename from
6891         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6892         bool.  Now static.
6893         (ada_read_var_value): Update and simplify.
6894         * ada-exp.y (write_var_or_type): Remove old code.
6895
6896 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6897
6898         PR gdb/25010
6899         * event-top.c: Remove include comment.
6900         * inflow.c (class scoped_ignore_sigttou): Move from here...
6901         * inflow.h (class scoped_ignore_sigttou): ...to here.
6902         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6903         * top.c:  Remove include comment.
6904
6905 2019-05-27  Tom Tromey  <tom@tromey.com>
6906
6907         * NEWS: Fix typo.
6908
6909 2019-05-22  Tom Tromey  <tromey@adacore.com>
6910
6911         * target.c (target_follow_exec): Constify parameter.
6912         * target-delegates.c: Rebuild.
6913         * remote.c (remote_target::follow_exec): Constify parameter.
6914         * infrun.c (follow_exec): Constify parameter.
6915         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6916         (target_follow_exec): Likewise.
6917
6918 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6919
6920         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6921         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6922
6923 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6924
6925         * NEWS: Add debugredirect and testsuite sections.
6926
6927 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6928
6929         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6930         target descriptions using exclusively floating point register name
6931         aliases.
6932
6933 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6934
6935         PR gdb/18644:
6936         * f-lang.c (build_fortran_types): Handle the case where
6937         gdbarch_floatformat_for_type returns a nullptr.
6938
6939 2019-05-21  Tom de Vries  <tdevries@suse.de>
6940
6941         PR cli/24587
6942         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6943
6944 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6945
6946         PR gdb/18644:
6947         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6948         16-byte floats.
6949         * i386-tdep.c (i386_floatformat_for_type): Use
6950         floatformats_ia64_quad for the 16-byte floating point component
6951         within a fortran 32-byte complex number.
6952
6953 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6954
6955         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6956         delete default constructor.
6957         (find_partial_die): Update to return const struct.
6958         (partial_die_parent_scope): Move variable declaration into scope
6959         of its use and change its type to auto.
6960         (guess_partial_die_structure_name): Likewise.
6961         (partial_die_info::fixup): Likewise.
6962
6963 2019-05-17  Tom Tromey  <tromey@adacore.com>
6964
6965         * source.c (find_and_open_source): Remove cast.
6966
6967 2019-05-17  Tom Tromey  <tromey@adacore.com>
6968
6969         * annotate.c (annotate_source): Make "filename" const.
6970         * annotate.h (annotate_source): Use const.
6971
6972 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6973
6974         * disasm.c (set_disassembler_options): Send errors to stderr.
6975
6976 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6977
6978         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6979         (cli_interp_base::set_logging): Check debug_redirect.
6980         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6981         * cli/cli-logging.c (debug_redirect): Add static variable.
6982         (pop_output_files): Add default param.
6983         (handle_redirections): Print debug setting.
6984         (show_logging_command): Likewise.
6985         (_initialize_cli_logging): Add debugredirect command.
6986         * interps.c (current_interp_set_logging): Add debug_redirect
6987         parameter.
6988         * interps.h (set_logging): Add debug_redirect parameter.
6989         (current_interp_set_logging): Likewise.
6990         * mi/mi-common.h: Likewise.
6991         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6992
6993 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6994             Tom Tromey  <tromey@adacore.com>
6995
6996         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6997         directly.
6998         * cli/cli-interp.h (make_logging_output): Remove declaration.
6999         * cli/cli-logging.c (make_logging_output): Remove function.
7000         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7001         directly.
7002         * ui-file.c (tee_file::tee_file): Remove bools.
7003         (tee_file::~tee_file): Remove deletes.
7004         * ui-file.h (tee_file): Remove bools.
7005
7006 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7007
7008         * mi/mi-cmds.h (mi_cmd_complete): New function.
7009         * mi/mi-main.c (mi_cmd_complete): Likewise.
7010         * mi/mi-cmds.c: Define new MI command -complete.
7011         * NEWS: Mention new -complete command.
7012
7013 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7014
7015         * completer.h (complete): New function.
7016         * completer.c (complete): Likewise.
7017         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7018         function defined in completer.h.
7019
7020 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7021
7022         * MAINTAINERS (Write After Approval): Add myself.
7023
7024 2019-05-17  Tom de Vries  <tdevries@suse.de>
7025
7026         PR gdb/24094
7027         * dwarf2read.c (struct cu_partial_die_info): New struct.
7028         (find_partial_die): Return cu_partial_die_info.
7029         (partial_die_parent_scope, guess_partial_die_structure_name)
7030         (partial_die_info::fixup): Handle new return type of find_partial_die.
7031
7032 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7033
7034         PR breakpoints/24541
7035         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7036         "std::string", simplifying the algorithm.
7037
7038 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7039
7040         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7041         (stap_static_probe_ops::get_probes): Likewise.
7042
7043 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7044
7045         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7046         '-')" and "else if".
7047         (stap_parse_single_operand): Join checks for
7048         "gdbarch_stap_parse_special_token_p" and
7049         "gdbarch_stap_parse_special_token" in the same "if" statement.
7050         Invert check when verifying for operation on register
7051         displacement.
7052
7053 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7054
7055         * stap-probe.c (stap_get_opcode): Update comment.
7056         (stap_get_expected_argument_type): Likewise.
7057         (handle_stap_probe): Likewise.
7058
7059 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7060
7061         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7062         return type to 'bool'.  Adjust comment.  Use 'bool' when
7063         appropriate.
7064         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7065         * stap-probe.c (stap_parse_argument_1): Likewise.
7066         (stap_is_operator): Likewise.
7067         (stap_is_generic_prefix): Likewise.
7068         (stap_is_register_prefix): Likewise.
7069         (stap_is_register_indirection_prefix): Likewise.
7070         (stap_is_integer_prefix): Likewise.
7071         (stap_generic_check_suffix): Likewise.
7072         (stap_check_integer_suffix): Likewise.
7073         (stap_check_register_suffix): Likewise.
7074         (stap_check_register_indirection_suffix): Likewise.
7075         (stap_parse_register_operand): Likewise.
7076         (stap_parse_single_operand): Likewise.
7077         (stap_parse_argument_1): Likewise.
7078         (stap_probe::get_argument_count): Likewise.
7079         (stap_is_operator): Likewise.
7080
7081 2019-05-16  Tom Tromey  <tromey@adacore.com>
7082
7083         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7084         keyword to foreach.
7085
7086 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7087
7088         * linux-thread-db.c (try_thread_db_load_1): Change return type
7089         to bool.
7090         (try_thread_db_load): Likewise.
7091         (try_thread_db_load_from_pdir_1): Likewise.
7092         (try_thread_db_load_from_pdir): Likewise.
7093         (try_thread_db_load_from_sdir): Likewise.
7094         (try_thread_db_load_from_dir): Likewise.
7095         (thread_db_load_search): Likewise.
7096         (has_libpthread): Likewise.
7097         (thread_db_load): Likewise.
7098
7099 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7100
7101         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7102         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7103         NULL, and complain/return if that's the case.
7104
7105 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7106
7107         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7108         (advance, posn, abstract_read_memory): New functions.
7109         [struct mem_read_abstraction]: New struct.
7110         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7111
7112 2019-05-14  Tom Tromey  <tromey@adacore.com>
7113
7114         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7115         value is not lval_memory.
7116
7117 2019-05-14  Tom Tromey  <tromey@adacore.com>
7118
7119         * solib.c (info_sharedlibrary_command): Style the file name.
7120
7121 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7122
7123         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7124         (aarch64_vnv_type): Likewise.
7125         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7126         * common/tdesc.c: Likewise.
7127         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7128         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7129         * features/aarch64-fpu.xml: Add ieee half view.
7130         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7131         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7132         * gdbtypes.h (struct builtin_type): Likewise.
7133         (struct objfile_type): Likewise.
7134
7135 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7136
7137         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7138         typo.
7139         * location.h (string_to_event_location): Likewise.
7140
7141 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7142
7143         GDB 8.3 released.
7144
7145 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7146
7147         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7148         New variable declaration.
7149         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7150         New variable.
7151         (print_one_breakpoint): Use ui_out::test_flags and new global
7152         variable to compute use_fixed_output.
7153         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7154         Remove.
7155         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7156         (mi_multi_location_breakpoint_output_fixed): Remove.
7157         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7158         new variable.
7159         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7160         fix_multi_location_breakpoint_output flag if version >= 3.
7161         * ui-out.h (enum ui_out_flag)
7162         <fix_multi_location_breakpoint_output>: New enumerator.
7163
7164 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7165
7166         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7167
7168 2019-05-10  Tom Tromey  <tromey@adacore.com>
7169
7170         * ada-lang.c (catch_ada_completer): New function.
7171         (_initialize_ada_language): Use it.
7172
7173 2019-05-10  Tom Tromey  <tromey@adacore.com>
7174
7175         * thread.c (print_thread_info): Make "requested_threads" const.
7176         * gdbthread.h (print_thread_info): Make "requested_threads"
7177         const.
7178         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7179         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7180
7181 2019-05-08  Tom Tromey  <tom@tromey.com>
7182
7183         * gdbtypes.c (objfile_type_data): Change type.
7184         (objfile_type, _initialize_gdbtypes): Update.
7185
7186 2019-05-08  Tom Tromey  <tom@tromey.com>
7187
7188         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7189         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7190         (_initialize_dwarf2_frame): Update.
7191
7192 2019-05-08  Tom Tromey  <tom@tromey.com>
7193
7194         * objc-lang.c (objc_objfile_data): Change type.
7195         (find_methods): Update.
7196         (_initialize_objc_lang): Remove.
7197
7198 2019-05-08  Tom Tromey  <tom@tromey.com>
7199
7200         * stabsread.c (rs6000_builtin_type_data): Change type.
7201         (rs6000_builtin_type, _initialize_stabsread): Update.
7202
7203 2019-05-08  Tom Tromey  <tom@tromey.com>
7204
7205         * mips-tdep.c (mips_pdr_data): Remove.
7206         (_initialize_mips_tdep): Update.
7207
7208 2019-05-08  Tom Tromey  <tom@tromey.com>
7209
7210         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7211         (hppa_init_objfile_priv_data, read_unwind_info)
7212         (find_unwind_entry, _initialize_hppa_tdep): Update.
7213
7214 2019-05-08  Tom Tromey  <tom@tromey.com>
7215
7216         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7217         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7218         on obstack.
7219         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7220
7221 2019-05-08  Tom Tromey  <tom@tromey.com>
7222
7223         * mdebugread.c (basic_type_data): Change type.
7224         (basic_type, _initialize_mdebugread): Update.
7225
7226 2019-05-08  Tom Tromey  <tom@tromey.com>
7227
7228         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7229
7230 2019-05-08  Tom Tromey  <tom@tromey.com>
7231
7232         * nto-tdep.c (nto_inferior_data_reg): Change type.
7233         (nto_inferior_data): Update.
7234         (nto_inferior_data_cleanup, nto_new_inferior_data)
7235         (_initialize_nto_tdep): Remove.
7236         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7237
7238 2019-05-08  Tom Tromey  <tom@tromey.com>
7239
7240         * ada-lang.c (struct ada_inferior_data): Add initializers.
7241         (ada_inferior_data): Change type.
7242         (ada_inferior_data_cleanup): Remove.
7243         (get_ada_inferior_data, ada_inferior_exit)
7244         (struct ada_pspace_data): Add initializers, destructor.
7245         (ada_pspace_data_handle): Change type.
7246         (get_ada_pspace_data): Update.
7247         (ada_pspace_data_cleanup): Remove.
7248
7249 2019-05-08  Tom Tromey  <tom@tromey.com>
7250
7251         * coffread.c (struct coff_symfile_info): Add initializers.
7252         (coff_objfile_data_key): Move lower.  Change type.
7253         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7254         Update.
7255         (coff_free_info): Remove.
7256
7257 2019-05-08  Tom Tromey  <tom@tromey.com>
7258
7259         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7260         (fbsd_pspace_data_handle): Move lower.  Change type.
7261         (get_fbsd_pspace_data): Update.
7262         (fbsd_pspace_data_cleanup): Remove.
7263         (_initialize_fbsd_tdep): Update.
7264
7265 2019-05-08  Tom Tromey  <tom@tromey.com>
7266
7267         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7268         (get_ada_tasks_pspace_data): Update.
7269         (ada_tasks_pspace_data_cleanup): Remove.
7270         (_initialize_tasks): Update.
7271         (ada_tasks_inferior_data_handle): Change type.
7272         (get_ada_tasks_inferior_data): Update.
7273         (ada_tasks_inferior_data_cleanup): Remove.
7274         (struct ada_tasks_pspace_data): Add initializers.
7275
7276 2019-05-08  Tom Tromey  <tom@tromey.com>
7277
7278         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7279         * symfile-debug.c (debug_sym_get_probes): Change type.
7280         * stap-probe.c (handle_stap_probe):
7281         (stap_static_probe_ops::get_probes): Change type.
7282         * probe.h (class static_probe_ops) <get_probes>: Change type.
7283         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7284         (parse_probes_in_pspace): Update.
7285         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7286         Update.
7287         (any_static_probe_ops::get_probes): Change type.
7288         * elfread.c (elfread_data): New typedef.
7289         (probe_key): Change type.
7290         (elf_get_probes): Likewise.  Update.
7291         (probe_key_free): Remove.
7292         (_initialize_elfread): Update.
7293         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7294         Change type.
7295         (dtrace_process_dof_probe, dtrace_process_dof)
7296         (dtrace_static_probe_ops::get_probe): Change type.
7297
7298 2019-05-08  Tom Tromey  <tom@tromey.com>
7299
7300         * xcoffread.c (struct xcoff_symfile_info): Rename from
7301         coff_symfile_info.  Add initializers.
7302         (xcoff_objfile_data_key): Move lower.  Change type.
7303         (XCOFF_DATA): Rewrite.
7304         (xcoff_free_info): Remove.
7305         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7306         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7307         (xcoff_initial_scan): Update.
7308
7309 2019-05-08  Tom Tromey  <tom@tromey.com>
7310
7311         * solib-svr4.c (struct svr4_info): Add initializers and
7312         destructor.
7313         <probes_table>: Now an htab_up.
7314         (solib_svr4_pspace_data): Change type.
7315         (free_probes_table): Simplify.
7316         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7317         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7318         (probes_table_remove_objfile_probes, register_solib_event_probe)
7319         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7320         (_initialize_svr4_solib): Update.
7321
7322 2019-05-08  Tom Tromey  <tom@tromey.com>
7323
7324         * remote.c (remote_pspace_data): Change type.
7325         (remote_pspace_data_cleanup): Remove.
7326         (get_remote_exec_file, set_pspace_remote_exec_file)
7327         (_initialize_remote): Update.
7328
7329 2019-05-08  Tom Tromey  <tom@tromey.com>
7330
7331         * breakpoint.c (breakpoint_objfile_key): Change type.
7332         (get_breakpoint_objfile_data): Update.
7333         (free_breakpoint_objfile_data): Remove.
7334         (_initialize_breakpoint): Update.
7335
7336 2019-05-08  Tom Tromey  <tom@tromey.com>
7337
7338         * linux-tdep.c (struct linux_info): Add initializers.
7339         (linux_inferior_data): Move.  Change type.
7340         (invalidate_linux_cache_inf): Update.
7341         (linux_inferior_data_cleanup): Remove.
7342         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7343
7344 2019-05-08  Tom Tromey  <tom@tromey.com>
7345
7346         * auxv.c (auxv_inferior_data): Move.  Change type.
7347         (auxv_inferior_data_cleanup): Remove.
7348         (invalidate_auxv_cache_inf): Rewrite.
7349         (get_auxv_inferior_data, _initialize_auxv): Update.
7350
7351 2019-05-08  Tom Tromey  <tom@tromey.com>
7352
7353         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7354         (symfile_debug_objfile_data_key): Change type.
7355         (symfile_debug_installed, debug_qf_has_symbols)
7356         (debug_qf_find_last_source_symtab)
7357         (debug_qf_forget_cached_source_info)
7358         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7359         (debug_qf_print_stats, debug_qf_dump)
7360         (debug_qf_expand_symtabs_for_function)
7361         (debug_qf_expand_all_symtabs)
7362         (debug_qf_expand_symtabs_with_fullname)
7363         (debug_qf_map_matching_symbols)
7364         (debug_qf_expand_symtabs_matching)
7365         (debug_qf_find_pc_sect_compunit_symtab)
7366         (debug_qf_map_symbol_filenames)
7367         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7368         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7369         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7370         (debug_sym_read_linetable, debug_sym_relocate): Update.
7371         (symfile_debug_free_objfile): Remove.
7372         (install_symfile_debug_logging, _initialize_symfile_debug):
7373         Update.
7374
7375 2019-05-08  Tom Tromey  <tom@tromey.com>
7376
7377         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7378         allocate_on_obstack.
7379         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7380         (get_dwarf2_per_objfile): Update.
7381         (set_dwarf2_per_objfile): Remove.
7382         (dwarf2_has_info, dwarf2_get_section_info): Update.
7383         (dwarf2_free_objfile): Remove.
7384         (_initialize_dwarf2_read): Update.
7385
7386 2019-05-08  Tom Tromey  <tom@tromey.com>
7387
7388         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7389         initializers.
7390         <unsupported_script_warning_printed,
7391         script_not_found_warning_printed>: Now bool.
7392         (auto_load_pspace_data): Change type.
7393         (~auto_load_pspace_info): Rename from
7394         auto_load_pspace_data_cleanup.
7395         (get_auto_load_pspace_data, init_loaded_scripts_info)
7396         (clear_section_scripts, maybe_print_unsupported_script_warning)
7397         (maybe_print_script_not_found_warning, _initialize_auto_load):
7398         Update.
7399
7400 2019-05-08  Tom Tromey  <tom@tromey.com>
7401
7402         * objfiles.c (objfile_pspace_info): Add destructor and
7403         initializers.
7404         (objfiles_pspace_data): Change type.
7405         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7406         (get_objfile_pspace_data): Update.
7407         (objfiles_bfd_data): Change type.
7408         (get_objfile_bfd_data): Update.
7409         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7410
7411 2019-05-08  Tom Tromey  <tom@tromey.com>
7412
7413         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7414         Change type.
7415         (get_catch_syscall_inferior_data): Update.
7416         (catch_syscall_inferior_data_cleanup): Remove.
7417         (_initialize_break_catch_syscall): Update.
7418
7419 2019-05-08  Tom Tromey  <tom@tromey.com>
7420
7421         * inflow.c (struct terminal_info): Add destructor and
7422         initializers.
7423         (inflow_inferior_data): Change type.
7424         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7425         (get_inflow_inferior_data, inflow_inferior_exit)
7426         (swap_terminal_info, _initialize_inflow): Update.
7427
7428 2019-05-08  Tom Tromey  <tom@tromey.com>
7429
7430         * target-dcache.c (target_dcache_cleanup): Remove.
7431         (target_dcache_aspace_key): Change type.
7432         (target_dcache_init_p, target_dcache_invalidate)
7433         (target_dcache_get, target_dcache_get_or_init)
7434         (_initialize_target_dcache): Update.
7435         * dcache.h (struct dcache_deleter): New.
7436
7437 2019-05-08  Tom Tromey  <tom@tromey.com>
7438
7439         * symtab.c (struct symbol_cache): Add destructor and
7440         initializers.
7441         (symbol_cache_key): Move.  Change type.
7442         (make_symbol_cache, free_symbol_cache): Remove.
7443         (get_symbol_cache): Update.
7444         (symbol_cache_cleanup): Remove.
7445         (ALL_PSPACES, symbol_cache_flush)
7446         (maintenance_print_symbol_cache)
7447         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7448         Update.
7449
7450 2019-05-08  Tom Tromey  <tom@tromey.com>
7451
7452         * symtab.c (struct main_info): Add destructor and initializers.
7453         (main_progspace_key): Move.  Change type.
7454         (get_main_info): Update.
7455         (main_info_cleanup): Remove.
7456         (_initialize_symtab): Update.
7457
7458 2019-05-08  Tom Tromey  <tom@tromey.com>
7459
7460         * registry.h (DECLARE_REGISTRY): Define the _key class.
7461
7462 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7463
7464         * NEWS: Merge two 'New commands' sections.
7465
7466 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7467
7468         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7469         parameter and use Ada language definition instead.
7470         (ada_val_print_ptr): Remove unused language parameter.
7471         (ada_val_print_num): Remove language parameter and use Ada language
7472         definition instead.
7473         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7474         parameter.
7475         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7476         parameter and use Ada language definition instead.
7477         (ada_val_print_1): Update all ada_val_print_xxx calls.
7478         Remove language parameter.
7479         (ada_val_print): Update ada_val_print_1 call.
7480
7481 2019-05-08  Tom Tromey  <tromey@adacore.com>
7482
7483         * remote.c (remote_hw_watchpoint_limit)
7484         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7485         Now static.
7486
7487 2019-05-08  Tom Tromey  <tromey@adacore.com>
7488
7489         * maint.c (_initialize_maint_cmds): Move initialization code to
7490         remote.c.
7491         (watchdog, show_watchdog): Move to remote.c.
7492         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7493         "watchdog" static.
7494         (_initialize_remote): Move initialization code from maint.c.
7495         * defs.h (watchdog): Don't declare.
7496
7497 2019-05-08  Tom Tromey  <tromey@adacore.com>
7498
7499         * tui/tui-interp.c: Include main.h.
7500         * interps.c: Include main.h.
7501         * main.h (interpreter_p): Declare.
7502         * defs.h (interpreter_p): Don't declare.
7503
7504 2019-05-08  Tom Tromey  <tromey@adacore.com>
7505
7506         * dwarf2loc.c: Include dwarf2read.h.
7507         * defs.h (read_unsigned_leb128): Don't declare.
7508         * dwarf2read.h (read_unsigned_leb128): Declare.
7509
7510 2019-05-08  Tom Tromey  <tromey@adacore.com>
7511
7512         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7513         method.
7514
7515 2019-05-08  Tom Tromey  <tromey@adacore.com>
7516
7517         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7518         when no wrap column is set.
7519
7520 2019-05-08  Tom Tromey  <tromey@adacore.com>
7521
7522         * c-lang.c (c_get_string): Handle non-C-style arrays.
7523
7524 2019-05-08  Tom Tromey  <tromey@adacore.com>
7525
7526         * typeprint.c (print_offset_data::update): Print the bit offset,
7527         not the number of bits remaining.
7528
7529 2019-05-08  Tom Tromey  <tromey@adacore.com>
7530
7531         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7532         padding at end of comment.
7533
7534 2019-05-08  Tom Tromey  <tromey@adacore.com>
7535
7536         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7537         Compare main types.
7538
7539 2019-05-06  Tom Tromey  <tom@tromey.com>
7540
7541         * common/scoped_mmap.c: Include common-defs.h.
7542         * common/scoped_mmap.h: Don't include config.h.
7543
7544 2019-05-04  Tom Tromey  <tom@tromey.com>
7545
7546         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7547         (struct aarch64_call_info): Add initializers.
7548         <si>: Now a std::vector.
7549         (pass_on_stack, aarch64_push_dummy_call): Update.
7550
7551 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7552             Tom Tromey  <tom@tromey.com>
7553
7554         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7555         (ppc_threads): Now a std::vector.  Now static.
7556         (hwdebug_find_thread_points_by_tid)
7557         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7558         Update.
7559
7560 2019-05-04  Tom Tromey  <tom@tromey.com>
7561
7562         * arc-tdep.c (arc_tdesc_init): Return bool.
7563
7564 2019-05-04  Tom Tromey  <tom@tromey.com>
7565
7566         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7567         Use gdb_assert_not_reached.
7568
7569 2019-05-04  Tom Tromey  <tom@tromey.com>
7570
7571         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7572         "false".
7573
7574 2019-05-04  Tom Tromey  <tom@tromey.com>
7575
7576         * arc-tdep.c (arc_tdesc_init): Use bool.
7577
7578 2019-05-04  Tom Tromey  <tom@tromey.com>
7579
7580         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7581
7582 2019-05-04  Tom Tromey  <tom@tromey.com>
7583
7584         * cli/cli-cmds.c (valid_command_p): Return bool.
7585
7586 2019-05-04  Tom Tromey  <tom@tromey.com>
7587
7588         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7589         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7590
7591 2019-05-04  Raul Tambre  <raul@tambre.ee>
7592
7593         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7594         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7595         operator for comparison.
7596
7597 2019-05-04  Tom Tromey  <tom@tromey.com>
7598
7599         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7600         (lookup_partial_symbol, print_partial_symbols)
7601         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7602         (psymbol_compare): Update.
7603         (add_psymbol_to_bcache): Clear the entire psymbol.
7604         (maintenance_check_psymtabs): Update.
7605         * psympriv.h (struct partial_symbol): Don't derive from
7606         general_symbol_info.
7607         <obj_section, unrelocated_address, address,
7608         set_unrelocated_address>: Update.
7609         <ginfo>: New member.
7610         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7611         (debug_names::write_psymbols): Update.
7612
7613 2019-05-04  Tom de Vries  <tdevries@suse.de>
7614
7615         * contrib/cc-with-tweaks.sh: Support -n arg.
7616
7617 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7618
7619         * corelow.c (core_target::detach): Ensure frame cache and
7620         register caches are cleared.
7621         inferior.c (exit_inferior_1): Likewise.
7622
7623 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7624             Tom Tromey  <tom@tromey.com>
7625
7626         * dictionary.c (collate_pending_symbols_by_language): Remove
7627         "struct" from foreach.
7628         * symtab.c (lookup_global_symbol_from_objfile)
7629         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7630         foreach.
7631         * ser-tcp.c (net_open): Remove "struct" from foreach.
7632         * objfiles.c (objfile_relocate, objfile_rebase)
7633         (objfile_has_symbols): Remove "struct" from foreach.
7634         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7635         from foreach.
7636         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7637         foreach.
7638         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7639         "struct" from foreach.
7640         * ada-lang.c (create_excep_cond_exprs)
7641         (ada_exception_catchpoint_cond_string): Remove "struct" from
7642         foreach.
7643
7644 2019-05-03  Tom Tromey  <tromey@adacore.com>
7645
7646         * ada-exp.y (convert_char_literal): Check suffix of each
7647         enumerator.
7648
7649 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7650
7651         PR ada/21406:
7652         * ada-exp.y (yywrap): Don't define.
7653         * ada-lex.l (%option): Add noyywrap
7654         (yywrap): Remove.
7655
7656 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7657
7658         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7659         _WIN32_WINNT to the XP level, unless already defined to a higher
7660         level.
7661
7662         * unittests/parse-connection-spec-selftests.c:
7663         * ser-tcp.c:
7664         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7665         override.
7666
7667         * symfile.c (find_separate_debug_file): Remove colon from the
7668         drive spec of DOS/Windows file names of the target, so that the
7669         file name produced from DEBUGDIR and the target's directory will
7670         be valid on DOS/Windows systems.
7671
7672 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7673
7674         * rust-lang.c (val_print_struct): Handle printing structures
7675         containing strings.
7676
7677 2019-05-02  Tom Tromey  <tromey@adacore.com>
7678
7679         * valarith.c (_initialize_valarith): Remove.
7680
7681 2019-05-01  Tom Tromey  <tromey@adacore.com>
7682
7683         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7684         bitfields.
7685
7686 2019-05-01  Tom Tromey  <tromey@adacore.com>
7687
7688         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7689         for big-endian copies.
7690
7691 2019-04-30  Ali Tamur  <tamur@google.com>
7692         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7693         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7694         (read_3_bytes): New function.
7695
7696 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7697
7698         * windows-nat.c (main_thread_id): Delete.
7699         (handle_output_debug_string): Replace main_thread_id by
7700         current_event.dwThreadId.
7701         (fake_create_process): Likewise.
7702         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7703         Do not set main_thread_id.
7704         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7705         current_event.dwThreadId.
7706         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7707
7708 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7709
7710         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7711         Use current_event.dwThreadId instead of main_thread_id.
7712
7713 2019-04-30  Tom Tromey  <tromey@adacore.com>
7714
7715         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7716         (create_excep_cond_exprs): Iterate over program spaces.
7717         (ada_exception_catchpoint_cond_string): Examine all minimal
7718         symbols for exception types.
7719
7720 2019-04-30  Tom Tromey  <tromey@adacore.com>
7721
7722         PR c++/24470:
7723         * dwarf2read.c (process_structure_scope): Handle case where type
7724         has template parameters but no symbol was created.
7725
7726 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7727             Chris January  <chris.january@arm.com>
7728
7729         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7730         qualifier.
7731         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7732
7733 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7734
7735         * f-typeprint.c (f_print_type): Update rules for printing
7736         whitespace.
7737         (f_type_print_varspec_suffix): Likewise.
7738
7739 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7740             Chris January  <chris.january@arm.com>
7741
7742         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7743         function arguments.
7744
7745 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7746
7747         * f-lang.c (build_fortran_types): Change name of void type to
7748         lower case.
7749         * f-typeprint.c (f_type_print_base): Print the name of the void
7750         type, rather than a fixed string.
7751         * f-valprint.c (f_decorations): Use lower case void string.
7752
7753 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7754             Chris January  <chris.january@arm.com>
7755
7756         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7757         types for Fortran.
7758
7759 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7760             Chris January  <chris.january@arm.com>
7761             David Lecomber  <david.lecomber@arm.com>
7762
7763         * f-exp.y (BINOP_INTRINSIC): New token.
7764         (exp): New parser rule handling BINOP_INTRINSIC.
7765         (f77_keywords): Add new builtin procedures.
7766         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7767         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7768         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7769         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7770         (print_unop_subexp_f): New function.
7771         (print_binop_subexp_f): New function.
7772         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7773         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7774         (dump_subexp_body_f): Likewise.
7775         (operator_check_f): Likewise.
7776         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7777         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7778
7779 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7780
7781         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7782         UNOP_KIND.
7783         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7784         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7785         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7786         (operator_length_f): New fuction.
7787         (print_subexp_f): New function.
7788         (op_name_f): New function.
7789         (dump_subexp_body_f): New function.
7790         (operator_check_f): New function.
7791         (exp_descriptor_f): Replace standard expression handling functions
7792         with new functions.
7793         * gdb/fortran-operator.def: New file.
7794         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7795         * gdb/std-operator.def: Remove UNOP_KIND.
7796
7797 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7798
7799         * std-operator.def: Remove unbalanced, stray double quote
7800         character.
7801
7802 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7803             Chris January  <chris.january@arm.com>
7804             Daniel Everett  <daniel.everett@arm.com>
7805             Nick Forrington  <nick.forrington@arm.com>
7806             Richard Bunt  <richard.bunt@arm.com>
7807
7808         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7809         of depth when printing anonymous structs or unions.
7810         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7811         Don't print either the top-level value, or the children if the
7812         max-depth is exceeded.
7813         (ppscm_print_children): When printing the key of a map, allow one
7814         extra level of depth.
7815         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7816         print either the top-level value, or the children if the max-depth
7817         is exceeded.
7818         (print_children): When printing the key of a map, allow one extra
7819         level of depth.
7820         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7821         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7822         (user_print_options): Initialise max_depth field.
7823         (val_print_scalar_or_string_type_p): New function.
7824         (val_print): Check to see if the max depth has been reached.
7825         (val_print_check_max_depth): Define new function.
7826         (show_print_max_depth): New function.
7827         (_initialize_valprint): Add 'print max-depth' option.
7828         * valprint.h (struct value_print_options) <max_depth>: New field.
7829         (val_print_check_max_depth): Declare new function.
7830         * NEWS: Document new feature.
7831
7832 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7833
7834         * ada-lang.c (ada_language_defn): Initialise new field.
7835         * c-lang.c (c_is_string_type_p): New function.
7836         (c_language_defn): Initialise new field.
7837         (cplus_language_defn): Initialise new field.
7838         (asm_language_defn): Initialise new field.
7839         (minimal_language_defn): Initialise new field.
7840         * c-lang.h (c_is_string_type_p): Declare new function.
7841         * d-lang.c (d_language_defn): Initialise new field.
7842         * f-lang.c (f_is_string_type_p): New function.
7843         (f_language_defn): Initialise new field.
7844         * go-lang.c (go_is_string_type_p): New function.
7845         (go_language_defn): Initialise new field.
7846         * language.c (default_is_string_type_p): New function.
7847         (unknown_language_defn): Initialise new field.
7848         (auto_language_defn): Initialise new field.
7849         * language.h (struct language_defn) <la_is_string_type_p>: New
7850         member variable.
7851         (default_is_string_type_p): Declare new function.
7852         * m2-lang.c (m2_language_defn): Initialise new field.
7853         * objc-lang.c (objc_language_defn): Initialise new field.
7854         * opencl-lang.c (opencl_language_defn): Initialise new field.
7855         * p-lang.c (pascal_is_string_type_p): New function.
7856         (pascal_language_defn): Initialise new field.
7857         * rust-lang.c (rust_is_string_type_p): New function.
7858         (rust_language_defn): Initialise new field.
7859
7860 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7861
7862         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7863         New field.
7864         * ada-lang.c (ada_language_defn): Initialise new field.
7865         * c-lang.c (c_language_defn): Likewise.
7866         (cplus_language_defn): Likewise.
7867         (asm_language_defn): Likewise.
7868         (minimal_language_defn): Likewise.
7869         * d-lang.c (d_language_defn): Likewise.
7870         * f-lang.c (f_language_defn): Likewise.
7871         * go-lang.c (go_language_defn): Likewise.
7872         * language.c (unknown_language_defn): Likewise.
7873         (auto_language_defn): Likewise.
7874         * m2-lang.c (m2_language_defn): Likewise.
7875         * objc-lang.c (objc_language_defn): Likewise.
7876         * opencl-lang.c (opencl_language_defn): Likewise.
7877         * p-lang.c (pascal_language_defn): Likewise.
7878         * rust-lang.c (rust_language_defn): Likewise.
7879
7880 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7881
7882         * ada-lang.c (ada_is_character_type): Change return type to bool.
7883         (ada_is_string_type): Likewise.
7884         * ada-lang.h (ada_is_character_type): Update declaration
7885         (ada_is_string_type): Likewise.
7886
7887 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7888
7889         Support style in 'frame|thread apply'
7890
7891         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7892         * record.c (record_start, record_stop): Update callers of
7893         execute_command_to_string with false.
7894         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7895         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7896         methods.
7897         (class string_file): New constructor with term_out parameter.
7898         Override methods term_out and can_emit_style_escape.  New member
7899         term_out.
7900         (class stdio_file): Override can_emit_style_escape.
7901         (class tee_file): Override term_out and can_emit_style_escape.
7902         * utils.h (can_emit_style_escape): Remove.
7903         * utils.c (can_emit_style_escape): Likewise.
7904         Update all callers of can_emit_style_escape (SOMESTREAM) to
7905         SOMESTREAM->can_emit_style_escape.
7906         * source-cache.c (source_cache::get_source_lines): Likewise.
7907         * stack.c (frame_apply_command_count): Call execute_command_to_string
7908         passing the term_out characteristic of the current gdb_stdout.
7909         * thread.c (thr_try_catch_cmd): Likewise.
7910         * top.c (execute_command_to_string): pass term_out parameter
7911         to construct the string_file for the command output.
7912         * ui-file.c (term_cli_styling): New function (most code moved
7913         from utils.c can_emit_style_escape).
7914         (string_file::string_file, string_file::can_emit_style_escape,
7915         stdio_file::can_emit_style_escape, tee_file::term_out,
7916         tee_file::can_emit_style_escape): New functions.
7917
7918 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7919
7920         * NEWS: Mention the new set|show may-call-functions.
7921         * infcall.c (may_call_functions_p): New variable.
7922         (show_may_call_functions_p): New function.
7923         (call_function_by_hand_dummy): Throws an error if not
7924         may-call-functions.
7925         (_initialize_infcall): Call add_setshow_boolean_cmd for
7926         may-call-functions.
7927
7928 2019-04-25  Keith Seitz  <keiths@redhat.com>
7929
7930         PR c++/24367
7931         * cp-support.c (inspect_type): Don't attempt substitutions
7932         of symbol with the same name.
7933
7934 2019-04-25  Tom Tromey  <tromey@adacore.com>
7935
7936         PR gdb/24475:
7937         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7938         static.
7939
7940 2019-04-25  Tom Tromey  <tromey@adacore.com>
7941
7942         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7943         rvalue reference.
7944         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7945         (gdb_xml_parser::parse): Use std::move.
7946         * python/python-internal.h (gdbpy_convert_exception): Take a const
7947         reference.
7948         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7949         std::move.
7950         * python/py-utils.c (gdbpy_convert_exception): Take a const
7951         reference.
7952         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7953         Use std::move.
7954         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7955         Use std::move.
7956         * mi/mi-main.c (mi_print_exception): Take a const reference.
7957         * main.c (handle_command_errors): Take a const reference.
7958         * linespec.c (parse_linespec): Use std::move.
7959         * infcall.c (run_inferior_call): Use std::move.
7960         (call_function_by_hand_dummy): Use std::move.
7961         * exec.c (try_open_exec_file): Use std::move.
7962         * exceptions.h (exception_print, exception_fprintf)
7963         (exception_print_same): Update.
7964         * exceptions.c (print_exception, exception_print)
7965         (exception_fprintf, exception_print_same): Change parameters to
7966         const reference.
7967         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7968         * common/new-op.c: Use std::move.
7969         * common/common-exceptions.h (struct gdb_exception): Add move
7970         constructor.
7971         (struct gdb_exception_error, struct gdb_exception_quit, struct
7972         gdb_quit_bad_alloc): Change constructor to move constructor.
7973         (throw_exception): Change parameter to rvalue reference.
7974         * common/common-exceptions.c (throw_exception): Take rvalue
7975         reference.
7976         * cli/cli-interp.c (safe_execute_command): Use std::move.
7977         * breakpoint.c (insert_bp_location, location_to_sals): Use
7978         std::move.
7979
7980 2019-04-25  Tom Tromey  <tromey@adacore.com>
7981
7982         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7983         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7984         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7985         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7986         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7987         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7988         guile/scm-value.c: Use unpack.
7989         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7990         gdbscm_gdb_exception.
7991         (gdbscm_throw_gdb_exception): Likewise.
7992         (struct gdbscm_gdb_exception): New.
7993         (unpack): New function.
7994         (gdbscm_wrap): Use unpack.
7995
7996 2019-04-25  Tom Tromey  <tromey@adacore.com>
7997
7998         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7999         (gdb_rl_callback_handler): Use std::move.
8000         * common/common-exceptions.h (struct gdb_exception): Add move
8001         assignment operator.
8002         (throw_exception_sjlj): Change "exception" to const reference.
8003         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8004         (throw_exception_sjlj): Change "exception" to const reference.
8005
8006 2019-04-25  Tom Tromey  <tromey@adacore.com>
8007
8008         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8009         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8010         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8011         Update.
8012         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8013         Update.
8014         * mi/mi-interp.c (mi_interp::exec): Update.
8015         * linespec.c (parse_linespec): Update.
8016         * infcall.c (run_inferior_call): Update.
8017         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8018         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8019         (gdbscm_lookup_global_symbol): Update.
8020         * guile/scm-param.c (gdbscm_parameter_value): Update.
8021         * guile/scm-frame.c (gdbscm_frame_read_register)
8022         (gdbscm_frame_read_var): Update.
8023         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8024         * exec.c (try_open_exec_file): Update.
8025         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8026         (gdb_rl_callback_handler): Update.
8027         * common/common-exceptions.h (exception_none): Don't declare.
8028         * common/common-exceptions.c (exception_none): Don't define.
8029         (struct catcher) <exception>: Update.
8030         * cli/cli-interp.c (safe_execute_command): Update.
8031         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8032
8033 2019-04-25  Ali Tamur  <tamur@google.com>
8034
8035         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8036         (read_attribute_value): Likewise.
8037         (dwarf2_read_addr_index): Update comment.
8038         (read_str_index): Add DW_FORM_strx.
8039         (dwarf2_string_attr): Likewise.
8040         (dwarf2_const_value_attr): Likewise.
8041         (dump_die_shallow): Likewise.
8042         (dwarf2_fetch_constant_bytes): Likewise.
8043         (skip_form_bytes): Likewise.
8044         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8045
8046 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8047
8048         PR corefiles/11608
8049         PR corefiles/18187
8050         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8051         OFFSET.  Verify if current mapping contains an ELF header.
8052         (linux_find_memory_regions_full): Adjust call to
8053         dump_mapping_p.
8054
8055 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8056             Kang Li <kanglictf@gmail.com>
8057
8058         PR gdb/21600
8059
8060         * dwarf2-frame.c (read_initial_length): Be consistent about using
8061         unsigned representation of length.
8062         (decode_frame_entry_1): Likewise.  Check for wraparound of
8063         end pointer as well as buffer overflow.
8064
8065 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8066
8067         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8068         "vq".
8069
8070 2019-04-24  Tom Tromey  <tromey@adacore.com>
8071
8072         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8073
8074 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8075
8076         * s12z-tdep.c (s12z_unwind_pc): Delete.
8077         (s12z_unwind_sp): Delete.
8078         (s12z_gdbarch_init): Don't register deleted functions with
8079         gdbarch.
8080
8081 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8082
8083         * rl78-tdep.c (rl78_unwind_sp): Delete.
8084         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8085
8086 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8087
8088         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8089         (xstormy16_unwind_pc): Delete.
8090         (xstormy16_dummy_id): Delete.
8091         (xstormy16_gdbarch_init): Don't register deleted functions with
8092         gdbarch.
8093
8094 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8095
8096         * vax-tdep.c (vax_unwind_pc): Delete.
8097         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8098
8099 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8100
8101         * v850-tdep.c (v850_unwind_sp): Delete.
8102         (v850_unwind_pc): Delete.
8103         (v850_dummy_id): Delete.
8104         (v850_gdbarch_init): Don't register deleted functions with
8105         gdbarch.
8106
8107 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8108
8109         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8110         (tilegx_unwind_pc): Delete.
8111         (tilegx_unwind_dummy_id): Delete.
8112         (tilegx_gdbarch_init): Don't register deleted functions with
8113         gdbarch.
8114
8115 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8116
8117         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8118         (tic6x_dummy_id): Delete.
8119         (tic6x_gdbarch_init): Don't register deleted functions with
8120         gdbarch.
8121
8122 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8123
8124         * sparc-tdep.c (sparc_unwind_pc): Delete.
8125         (sparc32_gdbarch_init): Don't register deleted function with
8126         gdbarch.
8127
8128 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8129
8130         * sh-tdep.c (sh_unwind_sp): Delete.
8131         (sh_unwind_pc): Delete.
8132         (sh_dummy_id): Delete.
8133         (sh_gdbarch_init): Don't register deleted functions with
8134         gdbarch.
8135
8136 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8137
8138         * score-tdep.c (score_unwind_sp): Delete.
8139         (score_unwind_pc): Delete.
8140         (score_dummy_id): Delete.
8141         (score_gdbarch_init): Don't register deleted functions with
8142         gdbarch.
8143
8144 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8145
8146         * rx-tdep.c (rx_unwind_pc): Delete.
8147         (rx_unwind_sp): Delete.
8148         (rx_dummy_id): Delete.
8149         (rx_gdbarch_init): Don't register deleted functions with
8150         gdbarch.  Update comment.
8151
8152 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8153
8154         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8155         (rs6000_dummy_id): Delete.
8156         (rs6000_gdbarch_init): Don't register deleted functions with
8157         gdbarch.
8158
8159 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8160
8161         * or1k-tdep.c (or1k_dummy_id): Delete.
8162         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8163
8164 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8165
8166         * nios2-tdep.c (nios2_dummy_id): Delete.
8167         (nios2_unwind_sp): Delete.
8168         (nios2_gdbarch_init): Don't register deleted functions with
8169         gdbarch.
8170
8171 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8172
8173         * nds32-tdep.c (nds32_dummy_id): Delete.
8174         (nds32_unwind_pc): Delete.
8175         (nds32_unwind_sp): Delete.
8176         (nds32_gdbarch_init): Don't register deleted functions with
8177         gdbarch.
8178
8179 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8180
8181         * msp430-tdep.c (msp430_unwind_pc): Delete.
8182         (msp430_unwind_sp): Delete.
8183         (msp430_dummy_id): Delete.
8184         (msp430_gdbarch_init): Don't register deleted functions with
8185         gdbarch.
8186
8187 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8188
8189         * moxie-tdep.c (moxie_unwind_sp): Delete.
8190         (moxie_unwind_pc): Delete.
8191         (moxie_dummy_id): Delete.
8192         (moxie_gdbarch_init): Don't register deleted functions with
8193         gdbarch.
8194
8195 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8196
8197         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8198         (mn10300_unwind_pc): Delete.
8199         (mn10300_unwind_sp): Delete.
8200         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8201         mn10300_unwind_sp.
8202         (mn10300_frame_unwind_init): Don't register deleted functions with
8203         gdbarch.
8204
8205 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8206
8207         * mep-tdep.c (mep_unwind_pc): Delete.
8208         (mep_unwind_sp): Delete.
8209         (mep_dummy_id): Delete.
8210         (mep_gdbarch_init): Don't register deleted functions with
8211         gdbarch.
8212
8213 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8214
8215         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8216         (m68hc11_unwind_sp): Delete.
8217         (m68hc11_gdbarch_init): Don't register deleted functions with
8218         gdbarch.
8219
8220 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8221
8222         * m32r-tdep.c (m32r_unwind_sp): Delete.
8223         (m32r_unwind_pc): Delete.
8224         (m32r_dummy_id): Delete.
8225         (m32r_gdbarch_init): Don't register deleted functions with
8226         gdbarch.
8227
8228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8229
8230         * m32c-tdep.c (m32c_unwind_pc): Delete.
8231         (m32c_unwind_sp): Delete.
8232         (m32c_dummy_id): Delete.
8233         (m32c_gdbarch_init): Don't register deleted functions with
8234         gdbarch.
8235
8236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8237
8238         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8239         (lm32_unwind_pc): Delete.
8240         (lm32_dummy_id): Delete.
8241         (lm32_gdbarch_init): Don't register deleted functions with
8242         gdbarch.
8243
8244 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8245
8246         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8247         (iq2000_unwind_pc): Delete.
8248         (iq2000_dummy_id): Delete.
8249         (iq2000_gdbarch_init): Don't register deleted functions with
8250         gdbarch.
8251
8252 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8253
8254         * nds32-tdep.c (nds32_type_align): Delete.
8255         (nds32_push_dummy_call): Use type_align instead.
8256
8257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8258
8259         * arm-tdep.c (arm_type_align): Only handle vector override case.
8260         (arm_push_dummy_call): Use type_align.
8261         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8262
8263 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8264
8265         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8266         case.
8267         (pass_on_stack): Use type_align.
8268         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8269         function.
8270
8271 2019-04-23  Tom Tromey  <tromey@adacore.com>
8272
8273         * dwarf2read.c (line_header::file_name_at): Remove unused
8274         overload.
8275
8276 2019-04-23  Tom de Vries  <tdevries@suse.de>
8277
8278         PR gdb/24438
8279         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8280         invocation.
8281
8282
8283 2019-03-27  Ali Tamur  <tamur@google.com>
8284
8285         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8286         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8287         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8288         (dwarf_expr_context::get_addr_index): Likewise
8289         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8290         (symbol_needs_eval_context::get_addr_index): Likewise
8291         (disassemble_dwarf_expression): Add DW_OP_addrx
8292         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8293         (read_cutu_die_from_dwo): Update comment
8294         (skip_one_die): Add DW_FORM_addrx
8295         (read_attribute_value): Likewise
8296         (var_decode_location): Add DW_OP_addrx
8297         (dwarf2_const_value_attr): Add DW_FORM_addrx
8298         (dump_die_shallow): Likewise
8299         (dwarf2_fetch_constant_bytes): Likewise
8300         (decode_locdesc): Add DW_OP_addrx
8301         (skip_form_bytes): Add DW_FORM_addrx
8302
8303 2019-04-22  Ali Tamur  <tamur@google.com>
8304
8305         * MAINTAINERS (Write After Approval): Add self.
8306
8307 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8308
8309         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8310         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8311         (open_symbol_file_object): Likewise.
8312         (svr4_default_sos): Add info parameter.
8313         (svr4_read_so_list): Likewise.
8314         (svr4_current_sos_direct): Adjust functions calls to pass down
8315         info.
8316         (svr4_current_sos_1): Add info parameter.
8317         (svr4_current_sos): Call get_svr4_info, pass info down to
8318         svr4_current_sos_1.
8319         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8320         get_svr4_info.
8321         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8322         get_svr4_info.
8323         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8324         to get_svr4_info.
8325         (probes_table_remove_objfile_probes): Likewise.
8326         (register_solib_event_probe): Add info parameter.
8327         (solist_update_incremental): Pass info parameter down to
8328         svr4_read_so_list.
8329         (disable_probes_interface): Add info parameter.
8330         (svr4_handle_solib_event): Pass current_program_space to
8331         get_svr4_info.  Adjust disable_probes_interface cleanup.
8332         (svr4_create_probe_breakpoints): Add info parameter, pass it
8333         down to register_solib_event_probe.
8334         (svr4_create_solib_event_breakpoints): Add info parameter,
8335         pass it down to svr4_create_probe_breakpoints.
8336         (enable_break): Pass info down to
8337         svr4_create_solib_event_breakpoints.
8338         (svr4_solib_create_inferior_hook): Pass current_program_space to
8339         get_svr4_info.
8340         (svr4_clear_solib): Likewise.
8341
8342 2019-04-22  Pedro Alves  <palves@redhat.com>
8343
8344         * solib-svr4.c (svr4_free_objfile_observer): New.
8345         (probe_and_action::objfile): New field.
8346         (probes_table_htab_remove_objfile_probes)
8347         (probes_table_remove_objfile_probes): New functions.
8348         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8349         in the new probe_and_action.  Don't store the probe in 'lookup'.
8350         (svr4_create_probe_breakpoints): Pass objfile to
8351         register_solib_event_probe.
8352         (_initialize_svr4_solib): Register a free_objfile observer.
8353
8354 2019-04-19  Tom Tromey  <tom@tromey.com>
8355
8356         * common/queue.h: Remove.
8357
8358 2019-04-19  Tom Tromey  <tom@tromey.com>
8359
8360         * event-loop.c: Don't include "common/queue.h".
8361
8362 2019-04-19  Tom Tromey  <tom@tromey.com>
8363
8364         * remote.c (remote_target): Use delete.
8365         * remote-notif.h: Include <list>, not "common/queue.h".
8366         (notif_client_p): Remove typedef.
8367         (remote_notif_state): Add constructor, destructor, initializer.
8368         <notif_queue>: Now a std::list.
8369         (remote_notif_state_xfree): Don't declare.
8370         * remote-notif.c (remote_notif_process, handle_notification)
8371         (remote_notif_state_allocate): Update.
8372         (~remote_notif_state): Rename from remote_notif_state_xfree.
8373
8374 2019-04-19  Tom Tromey  <tom@tromey.com>
8375
8376         * symfile.c (reread_symbols): Update.
8377         * objfiles.c (objfile_register_static_link)
8378         (objfile_lookup_static_link): Update
8379         (~objfile) Don't delete static_links.
8380         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8381
8382 2019-04-19  Tom Tromey  <tom@tromey.com>
8383
8384         * type-stack.h (struct type_stack) <insert>: Constify string.
8385         * type-stack.c (type_stack::insert): Constify string.
8386         * gdbtypes.h (lookup_template_type): Update.
8387         (address_space_name_to_int): Update.
8388         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8389         const.
8390         (lookup_template_type): Make name const.
8391         * c-exp.y: Update rules.
8392         (lex_one_token, classify_name, classify_inner_name)
8393         (c_print_token): Update.
8394         * p-exp.y: Update rules.
8395         (yylex): Update.
8396         * f-exp.y: Update rules.
8397         (yylex): Update.
8398         * d-exp.y: Update rules.
8399         (lex_one_token, classify_name, classify_inner_name): Update.
8400         * parse.c (write_dollar_variable, copy_name): Return std::string.
8401         * parser-defs.h (copy_name): Change return type.
8402         * m2-exp.y: Update rules.
8403         (yylex): Update.
8404         * go-exp.y (lex_one_token): Update.
8405         Update rules.
8406         (classify_unsafe_function, classify_packaged_name)
8407         (classify_name, yylex): Update.
8408
8409 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8410
8411         * configure.ac: add --enable-source-highlight switch.
8412         * configure: Regenerate.
8413         * top.c (print_gdb_version): plumb --enable-source-highlight
8414         status to "show configuration".
8415
8416 2019-04-19  Tom Tromey  <tromey@adacore.com>
8417
8418         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8419         Check ADA_TYPE_P.
8420         (empty_record, ada_template_to_fixed_record_type_1)
8421         (template_to_static_fixed_type)
8422         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8423         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8424         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8425         macros.
8426
8427 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8428
8429         PR symtab/24423:
8430         * source.c (print_source_lines_base): Advance "iter" when a
8431         control character is seen.
8432
8433 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8434
8435         * inferior.h (struct infcall_suspend_state_deleter):
8436         Catch exception in destructor to avoid crash.
8437
8438 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8439
8440         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8441         close to the add_com "shell".
8442
8443 2019-04-18  Tom Tromey  <tromey@adacore.com>
8444
8445         * process-stratum-target.h (class process_stratum_target)
8446         <stratum>: Add "final".
8447
8448 2019-04-17  Tom Tromey  <tromey@adacore.com>
8449
8450         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8451         against nullptr before use.
8452
8453 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8454
8455         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8456
8457 2019-04-17  Jim Wilson  <jimw@sifive.com>
8458             Andrew Burgess  <andrew.burgess@embecosm.com>
8459
8460         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8461         code read might fail, assume 4-byte breakpoint in that case.
8462
8463 2019-04-15  Leszek Swirski  <leszeks@google.com>
8464
8465         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8466         rather than a hand-rolled POD check when checking for forced MEMORY
8467         classification.
8468
8469 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8470
8471         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8472         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8473         function.
8474         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8475         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8476         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8477         declaration.
8478
8479 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8480
8481         * aarch64-linux-nat.c
8482         (aarch64_linux_nat_target::thread_architecture): Add override.
8483         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8484         each VQ.
8485
8486 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8487
8488         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8489
8490 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8491
8492         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8493         target types of size 96-bits, add some additional comments, and
8494         check that the builtin type we found was the correct size.
8495
8496 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8497
8498         * utils.c (prompt_for_continue): Don't restore the styling at the
8499         end, as applied_style has the wrong value.  This fixes styling in
8500         long lists of file names that are interrupted by the "Continue?"
8501         prompt.
8502
8503 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8504
8505         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8506         * c-lang.c (c_language_defn): Likewise.
8507         (cplus_language_defn): Likewise.
8508         (asm_language_defn): Likewise.
8509         (minimal_language_defn): Likewise.
8510         * d-lang.c (d_language_defn): Likewise.
8511         * f-lang.c (f_language_defn): Likewise.
8512         * go-lang.c (go_language_defn): Likewise.
8513         * language.c (unknown_language_defn): Likewise.
8514         (auto_language_defn): Likewise.
8515         * language.h (struct language_defn): Remove la_magic field.
8516         (LANG_MAGIC): Delete.
8517         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8518         * objc-lang.c (objc_language_defn): Likewise.
8519         * opencl-lang.c (opencl_language_defn): Likewise.
8520         * p-lang.c (pascal_language_defn): Likewise.
8521         * rust-lang.c (rust_language_defn): Likewise.
8522
8523 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8524
8525         * riscv-tdep.c (riscv_type_align): New function.
8526         (riscv_type_alignment): Delete.
8527         (riscv_arg_location): Use 'type_align'.
8528         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8529
8530 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8531
8532         * gdbtypes.c (type_align): A struct with no non-static fields also
8533         has alignment of 1.
8534
8535 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8536
8537         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8538         component to 0.
8539         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8540         member.
8541         (riscv_struct_info::analyse): New implementation using new
8542         analyse_inner member function.
8543         (riscv_struct_info::field_offset): New member function.
8544         (riscv_struct_info::m_offsets): New member variable.
8545         (riscv_struct_info::analyse_inner): New private member function,
8546         takes the old implementation of riscv_struct_info::analyse but
8547         extended to track field offsets.
8548         (riscv_call_arg_struct): Update the struct folding special cases
8549         to handle cases where empty C++ structs, which are non-zero
8550         length, are found.
8551         (riscv_arg_location): Initialise the length of each location, a
8552         non-zero length now indicates the location is in use.
8553         (riscv_push_dummy_call): Allow for the first location having a
8554         non-zero offset when setting up arguments.
8555         (riscv_return_value): Likewise, but for return values.
8556
8557 2019-04-11  Tom Tromey  <tromey@adacore.com>
8558
8559         * utils.c (internal_vproblem): Make "msg" const.
8560
8561 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8562
8563         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8564         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8565         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8566         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8567
8568 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8569
8570         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8571         function.
8572         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8573         of amd64_collect_native_gregset.
8574         (amd64_linux_nat_target::store_registers): Likewise.
8575
8576 2019-04-10  Tom Tromey  <tom@tromey.com>
8577
8578         * symtab.c (lookup_global_symbol_from_objfile)
8579         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8580         * objfiles.h (class separate_debug_iterator): New.
8581         (class separate_debug_range): New.
8582         (struct objfile) <separate_debug_objfiles>: New method.
8583         (objfile_separate_debug_iterate): Don't declare.
8584         * objfiles.c (separate_debug_iterator::operator++): Rename from
8585         objfile_separate_debug_iterate.
8586         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8587         iterator.
8588         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8589         iterator.
8590
8591 2019-04-10  Tom Tromey  <tom@tromey.com>
8592
8593         * symfile.c (reread_symbols): Remove old comment.
8594         * objfiles.c (free_all_objfiles): Fix a typo.
8595
8596 2019-04-10  Tom Tromey  <tom@tromey.com>
8597
8598         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8599         * minsyms.c (lookup_minimal_symbol): Use foreach.
8600         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8601         (lookup_minimal_symbol_solib_trampoline): Likewise.
8602         * symfile.c (reread_symbols): Use foreach.
8603
8604 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8605             Tom Tromey  <tromey@adacore.com>
8606
8607         PR rust/24414:
8608         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8609         (rust_lex_int_test): Change "value" to be LONGEST.
8610         (rust_lex_tests): Add test for long integer literal.
8611
8612 2019-04-09  Tom Tromey  <tromey@adacore.com>
8613
8614         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8615         to bool.
8616         (extended_remote_target::attach): Update.
8617         (remote_target::remote_notice_new_inferior): Update.
8618         (remote_target::add_current_inferior_and_thread): Update.
8619         * inferior.c (exit_inferior_1): Use "false".
8620         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8621
8622 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8623
8624         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8625         the "start" command.
8626
8627 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8628
8629         * python/py-inferior.c (infpy_thread_from_thread_handle):
8630         Adjust comments to reflect renaming of thread_from_thread_handle
8631         to thread_from_handle.  Adjust keywords.  Fix type error message.
8632         (inferior_object_methods): Add thread_from_handle.  Retain
8633         thread_from_thread_handle, but mark it as deprecated.
8634
8635 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8636
8637         * gdbthread.h (find_thread_by_handle): Revise declaration.
8638         * thread.c (find_thread_by_handle): Likewise.  Adjust
8639         implementation too.
8640         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8641         support for buffer objects as handles.
8642
8643 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8644
8645         * python/py-infthread.c (thpy_thread_handle): New function.
8646         (thread_object_methods): Register thpy_thread_handle.
8647
8648 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8649
8650         * gdbthread.h (thread_to_thread_handle): Declare.
8651         * thread.c (gdbtypes.h): Include.
8652         (thread_to_thread_handle): New function.
8653
8654         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8655         (target_thread_info_to_thread_handle): Declare.
8656         * target.c (target_thread_info_to_thread_handle): New function.
8657         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8658         * target-delegates.c: Regenerate.
8659
8660         * linux-thread-db.c (class thread_db_target): Add method
8661         thread_info_to_thread_handle.
8662         (thread_db_target::thread_info_to_thread_handle): Define.
8663         * remote.c (class remote_target): Add new method
8664         thread_info_to_thread_handle.
8665         (remote_target::thread_info_to_thread_handle): Define.
8666
8667 2019-04-08  Pedro Alves  <palves@redhat.com>
8668
8669         * common/common-exceptions.c (throw_exception): Don't create
8670         named object to throw; throw directly.
8671         (throw_it): Likewise.  Don't initialize gdb_exception::message
8672         here, with new; pass FMT and AP to the ctor instead.
8673         * common/common-exceptions.h: Include <string>.
8674         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8675         const char *, va_list)): New ctor.  Use std::make_shared.
8676         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8677         errors)): Delete.
8678         (gdb_exception_error::gdb_exception_error(enum errors, const char
8679         *, va_list)): New.
8680         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8681         Add assertion.
8682         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8683         errors)): Delete.
8684         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8685         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8686         Add assertion.
8687
8688 2019-04-08  Tom Tromey  <tom@tromey.com>
8689
8690         * valops.c (value_rtti_indirect_type): Replace throw_exception
8691         with throw.
8692         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8693         with throw.
8694         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8695         throw.
8696         * target.c (target_translate_tls_address): Replace throw_exception
8697         with throw.
8698         * stack.c (frame_apply_command_count): Replace throw_exception
8699         with throw.
8700         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8701         throw.
8702         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8703         with throw.
8704         * rs6000-tdep.c (rs6000_frame_cache)
8705         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8706         * remote.c: Replace throw_exception with throw.
8707         * record-full.c (record_full_message, record_full_wait_1)
8708         (record_full_restore): Replace throw_exception with throw.
8709         * record-btrace.c:
8710         (get_thread_current_frame_id, record_btrace_start_replaying)
8711         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8712         (cmd_record_btrace_start): Replace throw_exception with throw.
8713         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8714         throw.
8715         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8716         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8717         * linespec.c:
8718         (find_linespec_symbols): Replace throw_exception with throw.
8719         * infrun.c (displaced_step_prepare, resume): Replace
8720         throw_exception with throw.
8721         * infcmd.c (post_create_inferior): Replace throw_exception with
8722         throw.
8723         * inf-loop.c (inferior_event_handler): Replace throw_exception
8724         with throw.
8725         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8726         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8727         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8728         (get_prev_frame_always, get_frame_pc_if_available)
8729         (get_frame_address_in_block_if_available, get_frame_language):
8730         Replace throw_exception with throw.
8731         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8732         throw_exception with throw.
8733         * eval.c (fetch_subexp_value, evaluate_var_value)
8734         (evaluate_funcall, evaluate_subexp_standard): Replace
8735         throw_exception with throw.
8736         * dwarf2loc.c (call_site_find_chain)
8737         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8738         Replace throw_exception with throw.
8739         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8740         with throw.
8741         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8742         throw.
8743         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8744         * completer.c (complete_line_internal): Replace throw_exception
8745         with throw.
8746         * compile/compile-object-run.c (compile_object_run): Replace
8747         throw_exception with throw.
8748         * cli/cli-script.c (process_next_line): Replace throw_exception
8749         with throw.
8750         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8751         (btrace_enable, btrace_maint_update_pt_packets): Replace
8752         throw_exception with throw.
8753         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8754         throw_exception with throw.
8755         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8756         throw_exception with throw.
8757         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8758         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8759         * aarch64-tdep.c (aarch64_make_prologue_cache)
8760         (aarch64_make_stub_cache): Replace throw_exception with throw.
8761
8762 2019-04-08  Tom Tromey  <tom@tromey.com>
8763
8764         * common/common-exceptions.c (throw_exception): Rename from
8765         throw_exception_cxx.  Remove old copy.  Make argument const.
8766         (throw_it): Create and throw exception objects directly.
8767         * common/common-exceptions.h (throw_exception): Make argument
8768         const.
8769         (struct gdb_exception_error): Add constructor.
8770         (struct gdb_exception_quit): Add constructor.
8771
8772 2019-04-08  Tom Tromey  <tom@tromey.com>
8773
8774         * common/common-exceptions.h (exception_rethrow): Don't declare.
8775         (TRY_SJLJ): Update comment.
8776         (TRY, CATCH, END_CATCH): Remove.
8777         * common/common-exceptions.c (exception_rethrow): Remove.
8778
8779 2019-04-08  Tom Tromey  <tom@tromey.com>
8780
8781         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8782         Remove.
8783         (gdb_exception_error): Rename from
8784         gdb_exception_RETURN_MASK_ERROR.
8785         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8786         (gdb_quit_bad_alloc): Update.
8787         * aarch64-tdep.c: Update.
8788         * ada-lang.c: Update.
8789         * ada-typeprint.c: Update.
8790         * ada-valprint.c: Update.
8791         * amd64-tdep.c: Update.
8792         * arch-utils.c: Update.
8793         * break-catch-throw.c: Update.
8794         * breakpoint.c: Update.
8795         * btrace.c: Update.
8796         * c-varobj.c: Update.
8797         * cli/cli-cmds.c: Update.
8798         * cli/cli-interp.c: Update.
8799         * cli/cli-script.c: Update.
8800         * common/common-exceptions.c: Update.
8801         * common/new-op.c: Update.
8802         * common/selftest.c: Update.
8803         * compile/compile-c-symbols.c: Update.
8804         * compile/compile-cplus-symbols.c: Update.
8805         * compile/compile-object-load.c: Update.
8806         * compile/compile-object-run.c: Update.
8807         * completer.c: Update.
8808         * corelow.c: Update.
8809         * cp-abi.c: Update.
8810         * cp-support.c: Update.
8811         * cp-valprint.c: Update.
8812         * darwin-nat.c: Update.
8813         * disasm-selftests.c: Update.
8814         * dtrace-probe.c: Update.
8815         * dwarf-index-cache.c: Update.
8816         * dwarf-index-write.c: Update.
8817         * dwarf2-frame-tailcall.c: Update.
8818         * dwarf2-frame.c: Update.
8819         * dwarf2loc.c: Update.
8820         * dwarf2read.c: Update.
8821         * eval.c: Update.
8822         * event-loop.c: Update.
8823         * event-top.c: Update.
8824         * exec.c: Update.
8825         * f-valprint.c: Update.
8826         * fbsd-tdep.c: Update.
8827         * frame-unwind.c: Update.
8828         * frame.c: Update.
8829         * gdbtypes.c: Update.
8830         * gnu-v3-abi.c: Update.
8831         * guile/guile-internal.h: Update.
8832         * guile/scm-block.c: Update.
8833         * guile/scm-breakpoint.c: Update.
8834         * guile/scm-cmd.c: Update.
8835         * guile/scm-disasm.c: Update.
8836         * guile/scm-frame.c: Update.
8837         * guile/scm-lazy-string.c: Update.
8838         * guile/scm-math.c: Update.
8839         * guile/scm-param.c: Update.
8840         * guile/scm-ports.c: Update.
8841         * guile/scm-pretty-print.c: Update.
8842         * guile/scm-symbol.c: Update.
8843         * guile/scm-symtab.c: Update.
8844         * guile/scm-type.c: Update.
8845         * guile/scm-value.c: Update.
8846         * i386-linux-tdep.c: Update.
8847         * i386-tdep.c: Update.
8848         * inf-loop.c: Update.
8849         * infcall.c: Update.
8850         * infcmd.c: Update.
8851         * infrun.c: Update.
8852         * jit.c: Update.
8853         * language.c: Update.
8854         * linespec.c: Update.
8855         * linux-fork.c: Update.
8856         * linux-nat.c: Update.
8857         * linux-tdep.c: Update.
8858         * linux-thread-db.c: Update.
8859         * main.c: Update.
8860         * mi/mi-cmd-break.c: Update.
8861         * mi/mi-cmd-stack.c: Update.
8862         * mi/mi-interp.c: Update.
8863         * mi/mi-main.c: Update.
8864         * objc-lang.c: Update.
8865         * p-valprint.c: Update.
8866         * parse.c: Update.
8867         * ppc-linux-tdep.c: Update.
8868         * printcmd.c: Update.
8869         * python/py-arch.c: Update.
8870         * python/py-breakpoint.c: Update.
8871         * python/py-cmd.c: Update.
8872         * python/py-finishbreakpoint.c: Update.
8873         * python/py-frame.c: Update.
8874         * python/py-framefilter.c: Update.
8875         * python/py-gdb-readline.c: Update.
8876         * python/py-inferior.c: Update.
8877         * python/py-infthread.c: Update.
8878         * python/py-lazy-string.c: Update.
8879         * python/py-linetable.c: Update.
8880         * python/py-objfile.c: Update.
8881         * python/py-param.c: Update.
8882         * python/py-prettyprint.c: Update.
8883         * python/py-progspace.c: Update.
8884         * python/py-record-btrace.c: Update.
8885         * python/py-record.c: Update.
8886         * python/py-symbol.c: Update.
8887         * python/py-type.c: Update.
8888         * python/py-unwind.c: Update.
8889         * python/py-utils.c: Update.
8890         * python/py-value.c: Update.
8891         * python/python.c: Update.
8892         * record-btrace.c: Update.
8893         * record-full.c: Update.
8894         * remote-fileio.c: Update.
8895         * remote.c: Update.
8896         * riscv-tdep.c: Update.
8897         * rs6000-aix-tdep.c: Update.
8898         * rs6000-tdep.c: Update.
8899         * rust-exp.y: Update.
8900         * rust-lang.c: Update.
8901         * s390-tdep.c: Update.
8902         * selftest-arch.c: Update.
8903         * solib-dsbt.c: Update.
8904         * solib-frv.c: Update.
8905         * solib-spu.c: Update.
8906         * solib-svr4.c: Update.
8907         * solib.c: Update.
8908         * sparc64-linux-tdep.c: Update.
8909         * stack.c: Update.
8910         * symfile-mem.c: Update.
8911         * symmisc.c: Update.
8912         * target.c: Update.
8913         * thread.c: Update.
8914         * top.c: Update.
8915         * tracefile-tfile.c: Update.
8916         * tui/tui.c: Update.
8917         * typeprint.c: Update.
8918         * unittests/cli-utils-selftests.c: Update.
8919         * unittests/parse-connection-spec-selftests.c: Update.
8920         * valops.c: Update.
8921         * valprint.c: Update.
8922         * value.c: Update.
8923         * varobj.c: Update.
8924         * windows-nat.c: Update.
8925         * x86-linux-nat.c: Update.
8926         * xml-support.c: Update.
8927
8928 2019-04-08  Tom Tromey  <tom@tromey.com>
8929
8930         * xml-support.c: Use C++ exception handling.
8931         * x86-linux-nat.c: Use C++ exception handling.
8932         * windows-nat.c: Use C++ exception handling.
8933         * varobj.c: Use C++ exception handling.
8934         * value.c: Use C++ exception handling.
8935         * valprint.c: Use C++ exception handling.
8936         * valops.c: Use C++ exception handling.
8937         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8938         handling.
8939         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8940         * typeprint.c: Use C++ exception handling.
8941         * tui/tui.c: Use C++ exception handling.
8942         * tracefile-tfile.c: Use C++ exception handling.
8943         * top.c: Use C++ exception handling.
8944         * thread.c: Use C++ exception handling.
8945         * target.c: Use C++ exception handling.
8946         * symmisc.c: Use C++ exception handling.
8947         * symfile-mem.c: Use C++ exception handling.
8948         * stack.c: Use C++ exception handling.
8949         * sparc64-linux-tdep.c: Use C++ exception handling.
8950         * solib.c: Use C++ exception handling.
8951         * solib-svr4.c: Use C++ exception handling.
8952         * solib-spu.c: Use C++ exception handling.
8953         * solib-frv.c: Use C++ exception handling.
8954         * solib-dsbt.c: Use C++ exception handling.
8955         * selftest-arch.c: Use C++ exception handling.
8956         * s390-tdep.c: Use C++ exception handling.
8957         * rust-lang.c: Use C++ exception handling.
8958         * rust-exp.y: Use C++ exception handling.
8959         * rs6000-tdep.c: Use C++ exception handling.
8960         * rs6000-aix-tdep.c: Use C++ exception handling.
8961         * riscv-tdep.c: Use C++ exception handling.
8962         * remote.c: Use C++ exception handling.
8963         * remote-fileio.c: Use C++ exception handling.
8964         * record-full.c: Use C++ exception handling.
8965         * record-btrace.c: Use C++ exception handling.
8966         * python/python.c: Use C++ exception handling.
8967         * python/py-value.c: Use C++ exception handling.
8968         * python/py-utils.c: Use C++ exception handling.
8969         * python/py-unwind.c: Use C++ exception handling.
8970         * python/py-type.c: Use C++ exception handling.
8971         * python/py-symbol.c: Use C++ exception handling.
8972         * python/py-record.c: Use C++ exception handling.
8973         * python/py-record-btrace.c: Use C++ exception handling.
8974         * python/py-progspace.c: Use C++ exception handling.
8975         * python/py-prettyprint.c: Use C++ exception handling.
8976         * python/py-param.c: Use C++ exception handling.
8977         * python/py-objfile.c: Use C++ exception handling.
8978         * python/py-linetable.c: Use C++ exception handling.
8979         * python/py-lazy-string.c: Use C++ exception handling.
8980         * python/py-infthread.c: Use C++ exception handling.
8981         * python/py-inferior.c: Use C++ exception handling.
8982         * python/py-gdb-readline.c: Use C++ exception handling.
8983         * python/py-framefilter.c: Use C++ exception handling.
8984         * python/py-frame.c: Use C++ exception handling.
8985         * python/py-finishbreakpoint.c: Use C++ exception handling.
8986         * python/py-cmd.c: Use C++ exception handling.
8987         * python/py-breakpoint.c: Use C++ exception handling.
8988         * python/py-arch.c: Use C++ exception handling.
8989         * printcmd.c: Use C++ exception handling.
8990         * ppc-linux-tdep.c: Use C++ exception handling.
8991         * parse.c: Use C++ exception handling.
8992         * p-valprint.c: Use C++ exception handling.
8993         * objc-lang.c: Use C++ exception handling.
8994         * mi/mi-main.c: Use C++ exception handling.
8995         * mi/mi-interp.c: Use C++ exception handling.
8996         * mi/mi-cmd-stack.c: Use C++ exception handling.
8997         * mi/mi-cmd-break.c: Use C++ exception handling.
8998         * main.c: Use C++ exception handling.
8999         * linux-thread-db.c: Use C++ exception handling.
9000         * linux-tdep.c: Use C++ exception handling.
9001         * linux-nat.c: Use C++ exception handling.
9002         * linux-fork.c: Use C++ exception handling.
9003         * linespec.c: Use C++ exception handling.
9004         * language.c: Use C++ exception handling.
9005         * jit.c: Use C++ exception handling.
9006         * infrun.c: Use C++ exception handling.
9007         * infcmd.c: Use C++ exception handling.
9008         * infcall.c: Use C++ exception handling.
9009         * inf-loop.c: Use C++ exception handling.
9010         * i386-tdep.c: Use C++ exception handling.
9011         * i386-linux-tdep.c: Use C++ exception handling.
9012         * guile/scm-value.c: Use C++ exception handling.
9013         * guile/scm-type.c: Use C++ exception handling.
9014         * guile/scm-symtab.c: Use C++ exception handling.
9015         * guile/scm-symbol.c: Use C++ exception handling.
9016         * guile/scm-pretty-print.c: Use C++ exception handling.
9017         * guile/scm-ports.c: Use C++ exception handling.
9018         * guile/scm-param.c: Use C++ exception handling.
9019         * guile/scm-math.c: Use C++ exception handling.
9020         * guile/scm-lazy-string.c: Use C++ exception handling.
9021         * guile/scm-frame.c: Use C++ exception handling.
9022         * guile/scm-disasm.c: Use C++ exception handling.
9023         * guile/scm-cmd.c: Use C++ exception handling.
9024         * guile/scm-breakpoint.c: Use C++ exception handling.
9025         * guile/scm-block.c: Use C++ exception handling.
9026         * guile/guile-internal.h: Use C++ exception handling.
9027         * gnu-v3-abi.c: Use C++ exception handling.
9028         * gdbtypes.c: Use C++ exception handling.
9029         * frame.c: Use C++ exception handling.
9030         * frame-unwind.c: Use C++ exception handling.
9031         * fbsd-tdep.c: Use C++ exception handling.
9032         * f-valprint.c: Use C++ exception handling.
9033         * exec.c: Use C++ exception handling.
9034         * event-top.c: Use C++ exception handling.
9035         * event-loop.c: Use C++ exception handling.
9036         * eval.c: Use C++ exception handling.
9037         * dwarf2read.c: Use C++ exception handling.
9038         * dwarf2loc.c: Use C++ exception handling.
9039         * dwarf2-frame.c: Use C++ exception handling.
9040         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9041         * dwarf-index-write.c: Use C++ exception handling.
9042         * dwarf-index-cache.c: Use C++ exception handling.
9043         * dtrace-probe.c: Use C++ exception handling.
9044         * disasm-selftests.c: Use C++ exception handling.
9045         * darwin-nat.c: Use C++ exception handling.
9046         * cp-valprint.c: Use C++ exception handling.
9047         * cp-support.c: Use C++ exception handling.
9048         * cp-abi.c: Use C++ exception handling.
9049         * corelow.c: Use C++ exception handling.
9050         * completer.c: Use C++ exception handling.
9051         * compile/compile-object-run.c: Use C++ exception handling.
9052         * compile/compile-object-load.c: Use C++ exception handling.
9053         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9054         * compile/compile-c-symbols.c: Use C++ exception handling.
9055         * common/selftest.c: Use C++ exception handling.
9056         * common/new-op.c: Use C++ exception handling.
9057         * cli/cli-script.c: Use C++ exception handling.
9058         * cli/cli-interp.c: Use C++ exception handling.
9059         * cli/cli-cmds.c: Use C++ exception handling.
9060         * c-varobj.c: Use C++ exception handling.
9061         * btrace.c: Use C++ exception handling.
9062         * breakpoint.c: Use C++ exception handling.
9063         * break-catch-throw.c: Use C++ exception handling.
9064         * arch-utils.c: Use C++ exception handling.
9065         * amd64-tdep.c: Use C++ exception handling.
9066         * ada-valprint.c: Use C++ exception handling.
9067         * ada-typeprint.c: Use C++ exception handling.
9068         * ada-lang.c: Use C++ exception handling.
9069         * aarch64-tdep.c: Use C++ exception handling.
9070
9071 2019-04-08  Tom Tromey  <tom@tromey.com>
9072
9073         * xml-support.c (gdb_xml_parser::parse): Update.
9074         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9075         * value.c (show_convenience): Update.
9076         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9077         (test_parse_flags_qcs): Update.
9078         * thread.c (thr_try_catch_cmd): Update.
9079         * target.c (target_translate_tls_address): Update.
9080         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9081         (info_frame_command_core, frame_apply_command_count): Update.
9082         * rust-exp.y (rust_lex_exception_test): Update.
9083         * riscv-tdep.c (riscv_print_one_register_info): Update.
9084         * remote.c (remote_target::enable_btrace): Update.
9085         * record-btrace.c (record_btrace_enable_warn): Update.
9086         * python/py-utils.c (gdbpy_convert_exception): Update.
9087         * printcmd.c (do_one_display, print_variable_and_value): Update.
9088         * mi/mi-main.c (mi_print_exception): Update.
9089         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9090         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9091         * linux-nat.c (linux_nat_target::attach): Update.
9092         * linux-fork.c (class scoped_switch_fork_info): Update.
9093         * infrun.c (displaced_step_prepare): Update.
9094         * infcall.c (call_function_by_hand_dummy): Update.
9095         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9096         * gnu-v3-abi.c (print_one_vtable): Update.
9097         * frame.c (get_prev_frame_always): Update.
9098         * f-valprint.c (info_common_command_for_block): Update.
9099         * exec.c (try_open_exec_file): Update.
9100         * exceptions.c (print_exception, exception_print)
9101         (exception_fprintf, exception_print_same): Update.
9102         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9103         * dwarf-index-cache.c (index_cache::store)
9104         (index_cache::lookup_gdb_index): Update.
9105         * darwin-nat.c (maybe_cache_shell): Update.
9106         * cp-valprint.c (cp_print_value_fields): Update.
9107         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9108         (gcc_cplus_symbol_address): Update.
9109         * compile/compile-c-symbols.c (gcc_convert_symbol)
9110         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9111         * common/selftest.c: Update.
9112         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9113         a std::string.
9114         (exception_try_scope_entry, exception_try_scope_exit): Don't
9115         declare.
9116         (struct exception_try_scope): Remove.
9117         (TRY): Don't use exception_try_scope.
9118         (struct gdb_exception): Add constructor, operator=.
9119         <what>: New method.
9120         (struct gdb_exception_RETURN_MASK_ALL)
9121         (struct gdb_exception_RETURN_MASK_ERROR)
9122         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9123         (struct gdb_quit_bad_alloc): Update.
9124         * common/common-exceptions.c (exception_none): Change
9125         initializer.
9126         (struct catcher) <state, exception>: Initialize inline.
9127         <prev>: Remove member.
9128         (current_catcher): Remove.
9129         (catchers): New global.
9130         (exceptions_state_mc_init): Simplify.
9131         (catcher_pop): Remove.
9132         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9133         (try_scope_depth, exception_try_scope_entry)
9134         (exception_try_scope_exit): Remove.
9135         (throw_exception_sjlj): Update.
9136         (exception_messages, exception_messages_size): Remove.
9137         (throw_it): Simplify.
9138         (gdb_exception_sliced_copy): Remove.
9139         (throw_exception_cxx): Update.
9140         * cli/cli-script.c (script_from_file): Update.
9141         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9142         Update.
9143         * ada-valprint.c (ada_val_print): Update.
9144         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9145         (create_excep_cond_exprs): Update.
9146
9147 2019-04-08  Tom Tromey  <tom@tromey.com>
9148
9149         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9150         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9151         (TRY, CATCH, END_CATCH): Remove some definitions.
9152         * common/common-exceptions.c: Don't use GDB_XCPT.
9153         (catcher_list_size): Remove.
9154         (throw_exception, throw_it): Simplify.
9155
9156 2019-04-05  Tom Tromey  <tom@tromey.com>
9157
9158         Revert the header-sorting patch.
9159         * ft32-tdep.c: Revert.
9160         * frv-tdep.c: Revert.
9161         * frv-linux-tdep.c: Revert.
9162         * frame.c: Revert.
9163         * frame-unwind.c: Revert.
9164         * frame-base.c: Revert.
9165         * fork-child.c: Revert.
9166         * findvar.c: Revert.
9167         * findcmd.c: Revert.
9168         * filesystem.c: Revert.
9169         * filename-seen-cache.h: Revert.
9170         * filename-seen-cache.c: Revert.
9171         * fbsd-tdep.c: Revert.
9172         * fbsd-nat.h: Revert.
9173         * fbsd-nat.c: Revert.
9174         * f-valprint.c: Revert.
9175         * f-typeprint.c: Revert.
9176         * f-lang.c: Revert.
9177         * extension.h: Revert.
9178         * extension.c: Revert.
9179         * extension-priv.h: Revert.
9180         * expprint.c: Revert.
9181         * exec.h: Revert.
9182         * exec.c: Revert.
9183         * exceptions.c: Revert.
9184         * event-top.c: Revert.
9185         * event-loop.c: Revert.
9186         * eval.c: Revert.
9187         * elfread.c: Revert.
9188         * dwarf2read.h: Revert.
9189         * dwarf2read.c: Revert.
9190         * dwarf2loc.c: Revert.
9191         * dwarf2expr.h: Revert.
9192         * dwarf2expr.c: Revert.
9193         * dwarf2-frame.c: Revert.
9194         * dwarf2-frame-tailcall.c: Revert.
9195         * dwarf-index-write.h: Revert.
9196         * dwarf-index-write.c: Revert.
9197         * dwarf-index-common.c: Revert.
9198         * dwarf-index-cache.h: Revert.
9199         * dwarf-index-cache.c: Revert.
9200         * dummy-frame.c: Revert.
9201         * dtrace-probe.c: Revert.
9202         * disasm.h: Revert.
9203         * disasm.c: Revert.
9204         * disasm-selftests.c: Revert.
9205         * dictionary.c: Revert.
9206         * dicos-tdep.c: Revert.
9207         * demangle.c: Revert.
9208         * dcache.h: Revert.
9209         * dcache.c: Revert.
9210         * darwin-nat.h: Revert.
9211         * darwin-nat.c: Revert.
9212         * darwin-nat-info.c: Revert.
9213         * d-valprint.c: Revert.
9214         * d-namespace.c: Revert.
9215         * d-lang.c: Revert.
9216         * ctf.c: Revert.
9217         * csky-tdep.c: Revert.
9218         * csky-linux-tdep.c: Revert.
9219         * cris-tdep.c: Revert.
9220         * cris-linux-tdep.c: Revert.
9221         * cp-valprint.c: Revert.
9222         * cp-support.c: Revert.
9223         * cp-namespace.c: Revert.
9224         * cp-abi.c: Revert.
9225         * corelow.c: Revert.
9226         * corefile.c: Revert.
9227         * continuations.c: Revert.
9228         * completer.h: Revert.
9229         * completer.c: Revert.
9230         * complaints.c: Revert.
9231         * coffread.c: Revert.
9232         * coff-pe-read.c: Revert.
9233         * cli-out.h: Revert.
9234         * cli-out.c: Revert.
9235         * charset.c: Revert.
9236         * c-varobj.c: Revert.
9237         * c-valprint.c: Revert.
9238         * c-typeprint.c: Revert.
9239         * c-lang.c: Revert.
9240         * buildsym.c: Revert.
9241         * buildsym-legacy.c: Revert.
9242         * build-id.h: Revert.
9243         * build-id.c: Revert.
9244         * btrace.c: Revert.
9245         * bsd-uthread.c: Revert.
9246         * breakpoint.h: Revert.
9247         * breakpoint.c: Revert.
9248         * break-catch-throw.c: Revert.
9249         * break-catch-syscall.c: Revert.
9250         * break-catch-sig.c: Revert.
9251         * blockframe.c: Revert.
9252         * block.c: Revert.
9253         * bfin-tdep.c: Revert.
9254         * bfin-linux-tdep.c: Revert.
9255         * bfd-target.c: Revert.
9256         * bcache.c: Revert.
9257         * ax-general.c: Revert.
9258         * ax-gdb.h: Revert.
9259         * ax-gdb.c: Revert.
9260         * avr-tdep.c: Revert.
9261         * auxv.c: Revert.
9262         * auto-load.c: Revert.
9263         * arm-wince-tdep.c: Revert.
9264         * arm-tdep.c: Revert.
9265         * arm-symbian-tdep.c: Revert.
9266         * arm-pikeos-tdep.c: Revert.
9267         * arm-obsd-tdep.c: Revert.
9268         * arm-nbsd-tdep.c: Revert.
9269         * arm-nbsd-nat.c: Revert.
9270         * arm-linux-tdep.c: Revert.
9271         * arm-linux-nat.c: Revert.
9272         * arm-fbsd-tdep.c: Revert.
9273         * arm-fbsd-nat.c: Revert.
9274         * arm-bsd-tdep.c: Revert.
9275         * arch-utils.c: Revert.
9276         * arc-tdep.c: Revert.
9277         * arc-newlib-tdep.c: Revert.
9278         * annotate.h: Revert.
9279         * annotate.c: Revert.
9280         * amd64-windows-tdep.c: Revert.
9281         * amd64-windows-nat.c: Revert.
9282         * amd64-tdep.c: Revert.
9283         * amd64-sol2-tdep.c: Revert.
9284         * amd64-obsd-tdep.c: Revert.
9285         * amd64-obsd-nat.c: Revert.
9286         * amd64-nbsd-tdep.c: Revert.
9287         * amd64-nbsd-nat.c: Revert.
9288         * amd64-nat.c: Revert.
9289         * amd64-linux-tdep.c: Revert.
9290         * amd64-linux-nat.c: Revert.
9291         * amd64-fbsd-tdep.c: Revert.
9292         * amd64-fbsd-nat.c: Revert.
9293         * amd64-dicos-tdep.c: Revert.
9294         * amd64-darwin-tdep.c: Revert.
9295         * amd64-bsd-nat.c: Revert.
9296         * alpha-tdep.c: Revert.
9297         * alpha-obsd-tdep.c: Revert.
9298         * alpha-nbsd-tdep.c: Revert.
9299         * alpha-mdebug-tdep.c: Revert.
9300         * alpha-linux-tdep.c: Revert.
9301         * alpha-linux-nat.c: Revert.
9302         * alpha-bsd-tdep.c: Revert.
9303         * alpha-bsd-nat.c: Revert.
9304         * aix-thread.c: Revert.
9305         * agent.c: Revert.
9306         * addrmap.c: Revert.
9307         * ada-varobj.c: Revert.
9308         * ada-valprint.c: Revert.
9309         * ada-typeprint.c: Revert.
9310         * ada-tasks.c: Revert.
9311         * ada-lang.c: Revert.
9312         * aarch64-tdep.c: Revert.
9313         * aarch64-ravenscar-thread.c: Revert.
9314         * aarch64-newlib-tdep.c: Revert.
9315         * aarch64-linux-tdep.c: Revert.
9316         * aarch64-linux-nat.c: Revert.
9317         * aarch64-fbsd-tdep.c: Revert.
9318         * aarch64-fbsd-nat.c: Revert.
9319         * aarch32-linux-nat.c: Revert.
9320
9321 2019-04-05  Tom Tromey  <tom@tromey.com>
9322
9323         * ft32-tdep.c: Sort headers.
9324         * frv-tdep.c: Sort headers.
9325         * frv-linux-tdep.c: Sort headers.
9326         * frame.c: Sort headers.
9327         * frame-unwind.c: Sort headers.
9328         * frame-base.c: Sort headers.
9329         * fork-child.c: Sort headers.
9330         * findvar.c: Sort headers.
9331         * findcmd.c: Sort headers.
9332         * filesystem.c: Sort headers.
9333         * filename-seen-cache.h: Sort headers.
9334         * filename-seen-cache.c: Sort headers.
9335         * fbsd-tdep.c: Sort headers.
9336         * fbsd-nat.h: Sort headers.
9337         * fbsd-nat.c: Sort headers.
9338         * f-valprint.c: Sort headers.
9339         * f-typeprint.c: Sort headers.
9340         * f-lang.c: Sort headers.
9341         * extension.h: Sort headers.
9342         * extension.c: Sort headers.
9343         * extension-priv.h: Sort headers.
9344         * expprint.c: Sort headers.
9345         * exec.h: Sort headers.
9346         * exec.c: Sort headers.
9347         * exceptions.c: Sort headers.
9348         * event-top.c: Sort headers.
9349         * event-loop.c: Sort headers.
9350         * eval.c: Sort headers.
9351         * elfread.c: Sort headers.
9352         * dwarf2read.h: Sort headers.
9353         * dwarf2read.c: Sort headers.
9354         * dwarf2loc.c: Sort headers.
9355         * dwarf2expr.h: Sort headers.
9356         * dwarf2expr.c: Sort headers.
9357         * dwarf2-frame.c: Sort headers.
9358         * dwarf2-frame-tailcall.c: Sort headers.
9359         * dwarf-index-write.h: Sort headers.
9360         * dwarf-index-write.c: Sort headers.
9361         * dwarf-index-common.c: Sort headers.
9362         * dwarf-index-cache.h: Sort headers.
9363         * dwarf-index-cache.c: Sort headers.
9364         * dummy-frame.c: Sort headers.
9365         * dtrace-probe.c: Sort headers.
9366         * disasm.h: Sort headers.
9367         * disasm.c: Sort headers.
9368         * disasm-selftests.c: Sort headers.
9369         * dictionary.c: Sort headers.
9370         * dicos-tdep.c: Sort headers.
9371         * demangle.c: Sort headers.
9372         * dcache.h: Sort headers.
9373         * dcache.c: Sort headers.
9374         * darwin-nat.h: Sort headers.
9375         * darwin-nat.c: Sort headers.
9376         * darwin-nat-info.c: Sort headers.
9377         * d-valprint.c: Sort headers.
9378         * d-namespace.c: Sort headers.
9379         * d-lang.c: Sort headers.
9380         * ctf.c: Sort headers.
9381         * csky-tdep.c: Sort headers.
9382         * csky-linux-tdep.c: Sort headers.
9383         * cris-tdep.c: Sort headers.
9384         * cris-linux-tdep.c: Sort headers.
9385         * cp-valprint.c: Sort headers.
9386         * cp-support.c: Sort headers.
9387         * cp-namespace.c: Sort headers.
9388         * cp-abi.c: Sort headers.
9389         * corelow.c: Sort headers.
9390         * corefile.c: Sort headers.
9391         * continuations.c: Sort headers.
9392         * completer.h: Sort headers.
9393         * completer.c: Sort headers.
9394         * complaints.c: Sort headers.
9395         * coffread.c: Sort headers.
9396         * coff-pe-read.c: Sort headers.
9397         * cli-out.h: Sort headers.
9398         * cli-out.c: Sort headers.
9399         * charset.c: Sort headers.
9400         * c-varobj.c: Sort headers.
9401         * c-valprint.c: Sort headers.
9402         * c-typeprint.c: Sort headers.
9403         * c-lang.c: Sort headers.
9404         * buildsym.c: Sort headers.
9405         * buildsym-legacy.c: Sort headers.
9406         * build-id.h: Sort headers.
9407         * build-id.c: Sort headers.
9408         * btrace.c: Sort headers.
9409         * bsd-uthread.c: Sort headers.
9410         * breakpoint.h: Sort headers.
9411         * breakpoint.c: Sort headers.
9412         * break-catch-throw.c: Sort headers.
9413         * break-catch-syscall.c: Sort headers.
9414         * break-catch-sig.c: Sort headers.
9415         * blockframe.c: Sort headers.
9416         * block.c: Sort headers.
9417         * bfin-tdep.c: Sort headers.
9418         * bfin-linux-tdep.c: Sort headers.
9419         * bfd-target.c: Sort headers.
9420         * bcache.c: Sort headers.
9421         * ax-general.c: Sort headers.
9422         * ax-gdb.h: Sort headers.
9423         * ax-gdb.c: Sort headers.
9424         * avr-tdep.c: Sort headers.
9425         * auxv.c: Sort headers.
9426         * auto-load.c: Sort headers.
9427         * arm-wince-tdep.c: Sort headers.
9428         * arm-tdep.c: Sort headers.
9429         * arm-symbian-tdep.c: Sort headers.
9430         * arm-pikeos-tdep.c: Sort headers.
9431         * arm-obsd-tdep.c: Sort headers.
9432         * arm-nbsd-tdep.c: Sort headers.
9433         * arm-nbsd-nat.c: Sort headers.
9434         * arm-linux-tdep.c: Sort headers.
9435         * arm-linux-nat.c: Sort headers.
9436         * arm-fbsd-tdep.c: Sort headers.
9437         * arm-fbsd-nat.c: Sort headers.
9438         * arm-bsd-tdep.c: Sort headers.
9439         * arch-utils.c: Sort headers.
9440         * arc-tdep.c: Sort headers.
9441         * arc-newlib-tdep.c: Sort headers.
9442         * annotate.h: Sort headers.
9443         * annotate.c: Sort headers.
9444         * amd64-windows-tdep.c: Sort headers.
9445         * amd64-windows-nat.c: Sort headers.
9446         * amd64-tdep.c: Sort headers.
9447         * amd64-sol2-tdep.c: Sort headers.
9448         * amd64-obsd-tdep.c: Sort headers.
9449         * amd64-obsd-nat.c: Sort headers.
9450         * amd64-nbsd-tdep.c: Sort headers.
9451         * amd64-nbsd-nat.c: Sort headers.
9452         * amd64-nat.c: Sort headers.
9453         * amd64-linux-tdep.c: Sort headers.
9454         * amd64-linux-nat.c: Sort headers.
9455         * amd64-fbsd-tdep.c: Sort headers.
9456         * amd64-fbsd-nat.c: Sort headers.
9457         * amd64-dicos-tdep.c: Sort headers.
9458         * amd64-darwin-tdep.c: Sort headers.
9459         * amd64-bsd-nat.c: Sort headers.
9460         * alpha-tdep.c: Sort headers.
9461         * alpha-obsd-tdep.c: Sort headers.
9462         * alpha-nbsd-tdep.c: Sort headers.
9463         * alpha-mdebug-tdep.c: Sort headers.
9464         * alpha-linux-tdep.c: Sort headers.
9465         * alpha-linux-nat.c: Sort headers.
9466         * alpha-bsd-tdep.c: Sort headers.
9467         * alpha-bsd-nat.c: Sort headers.
9468         * aix-thread.c: Sort headers.
9469         * agent.c: Sort headers.
9470         * addrmap.c: Sort headers.
9471         * ada-varobj.c: Sort headers.
9472         * ada-valprint.c: Sort headers.
9473         * ada-typeprint.c: Sort headers.
9474         * ada-tasks.c: Sort headers.
9475         * ada-lang.c: Sort headers.
9476         * aarch64-tdep.c: Sort headers.
9477         * aarch64-ravenscar-thread.c: Sort headers.
9478         * aarch64-newlib-tdep.c: Sort headers.
9479         * aarch64-linux-tdep.c: Sort headers.
9480         * aarch64-linux-nat.c: Sort headers.
9481         * aarch64-fbsd-tdep.c: Sort headers.
9482         * aarch64-fbsd-nat.c: Sort headers.
9483         * aarch32-linux-nat.c: Sort headers.
9484
9485 2019-04-04  Tom Tromey  <tom@tromey.com>
9486
9487         * varobj.c (varobj_create): Update.
9488         * rust-exp.y (struct rust_parser) <update_innermost_block,
9489         lookup_symbol>: New methods.
9490         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9491         Rename.
9492         (rust_parser::rust_lookup_type)
9493         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9494         * printcmd.c (display_command, do_one_display): Update.
9495         * parser-defs.h (struct parser_state) <parser_state>: Add
9496         "tracker" parameter.
9497         (block_tracker): New member.
9498         (class innermost_block_tracker) <innermost_block_tracker>: Add
9499         "types" parameter.
9500         <reset>: Remove method.
9501         (innermost_block): Don't declare.
9502         (null_post_parser): Update.
9503         * parse.c (innermost_block): Remove global.
9504         (write_dollar_variable): Update.
9505         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9506         Remove "tracker_types" parameter.
9507         (parse_expression): Add "tracker" parameter.
9508         (parse_expression_for_completion): Update.
9509         (null_post_parser): Add "tracker" parameter.
9510         * p-exp.y: Update rules.
9511         * m2-exp.y: Update rules.
9512         * language.h (struct language_defn) <la_post_parser>: Add
9513         "tracker" parameter.
9514         * go-exp.y: Update rules.
9515         * f-exp.y: Update rules.
9516         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9517         parameter.
9518         * d-exp.y: Update rules.
9519         * c-exp.y: Update rules.
9520         * breakpoint.c (set_breakpoint_condition): Create an
9521         innermost_block_tracker.
9522         (watch_command_1): Likewise.
9523         * ada-lang.c (resolve): Add "tracker" parameter.
9524         (resolve_subexp): Likewise.
9525         * ada-exp.y (write_var_from_sym): Update.
9526
9527 2019-04-04  Tom Tromey  <tom@tromey.com>
9528
9529         * type-stack.h: New file.
9530         * type-stack.c: New file.
9531         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9532         type-stack.h.
9533         (insert_into_type_stack, insert_type, push_type, push_type_int)
9534         (insert_type_address_space, pop_type, pop_type_int)
9535         (pop_typelist, pop_type_stack, append_type_stack)
9536         (push_type_stack, get_type_stack, push_typelist)
9537         (follow_type_instance_flags, follow_types): Don't declare.
9538         * parse.c (type_stack): Remove global.
9539         (parse_exp_in_context): Update.
9540         (insert_into_type_stack, insert_type, push_type, push_type_int)
9541         (insert_type_address_space, pop_type, pop_type_int)
9542         (pop_typelist, pop_type_stack, append_type_stack)
9543         (push_type_stack, get_type_stack, push_typelist)
9544         (follow_type_instance_flags, follow_types): Remove (moved to
9545         type-stack.c).
9546         * f-exp.y (type_stack): New global.
9547         Update rules.
9548         (push_kind_type, f_parse): Update.
9549         * d-exp.y (type_stack): New global.
9550         Update rules.
9551         (d_parse): Update.
9552         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9553         Update rules.
9554         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9555         (HFILES_NO_SRCDIR): Add type-stack.h.
9556
9557 2019-04-04  Tom Tromey  <tom@tromey.com>
9558
9559         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9560         (rust_parser::convert_ast_to_expression, rust_parse)
9561         (rust_lex_test_completion, rust_lex_tests): Update.
9562         * parser-defs.h (struct expr_completion_state): New.
9563         (struct parser_state) <parser_state>: Add completion parameter.
9564         <mark_struct_expression, mark_completion_tag>: New methods.
9565         <parse_completion, m_completion_state>: New members.
9566         (prefixify_expression, null_post_parser): Update.
9567         (mark_struct_expression, mark_completion_tag): Don't declare.
9568         * parse.c (parse_completion, expout_last_struct)
9569         (expout_tag_completion_type, expout_completion_name): Remove
9570         globals.
9571         (parser_state::mark_struct_expression)
9572         (parser_state::mark_completion_tag): Now methods.
9573         (prefixify_expression): Add last_struct parameter.
9574         (prefixify_subexp): Likewise.
9575         (parse_exp_1): Update.
9576         (parse_exp_in_context): Add cstate parameter.  Update.
9577         (parse_expression_for_completion): Create an
9578         expr_completion_state.
9579         (null_post_parser): Add "completion" parameter.
9580         * p-exp.y: Update rules.
9581         (yylex): Update.
9582         * language.h (struct language_defn) <la_post_parser>: Add
9583         "completing" parameter.
9584         * go-exp.y: Update rules.
9585         (lex_one_token): Update.
9586         * expression.h (parse_completion): Don't declare.
9587         * d-exp.y: Update rules.
9588         (lex_one_token): Update rules.
9589         * c-exp.y: Update rules.
9590         (lex_one_token): Update.
9591         * ada-lang.c (resolve): Add "parse_completion" parameter.
9592         (resolve_subexp): Likewise.
9593         (ada_resolve_function): Likewise.
9594
9595 2019-04-04  Tom Tromey  <tom@tromey.com>
9596
9597         * parser-defs.h (struct parser_state) <start_arglist,
9598         end_arglist>: New methods.
9599         <arglist_len, m_funcall_chain>: New members.
9600         (arglist_len, start_arglist, end_arglist): Don't declare.
9601         * parse.c (arglist_len, funcall_chain): Remove global.
9602         (start_arglist, end_arglist): Remove functions.
9603         (parse_exp_in_context): Update.
9604         * p-exp.y: Update rules.
9605         * m2-exp.y: Update rules.
9606         * go-exp.y: Update rules.
9607         * f-exp.y: Update rules.
9608         * d-exp.y: Update rules.
9609         * c-exp.y: Update rules.
9610
9611 2019-04-04  Tom Tromey  <tom@tromey.com>
9612
9613         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9614         lex_operator, push_back>: New methods.
9615         Update all rules.
9616         (rust_parser::lex_hex, lex_escape): Rename and update.
9617         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9618         (rust_parser::lex_operator): Rename and update.
9619         (rust_parser::lex_number, rustyylex, rustyyerror)
9620         (rust_lex_test_init, rust_lex_test_sequence)
9621         (rust_lex_test_push_back, rust_lex_tests): Update.
9622         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9623         parameter.
9624         <lexptr, prev_lexptr>: New members.
9625         (lexptr, prev_lexptr): Don't declare.
9626         * parse.c (lexptr, prev_lexptr): Remove globals.
9627         (parse_exp_in_context): Update.
9628         * p-exp.y (yylex, yyerror): Update.
9629         * m2-exp.y (parse_number, yylex, yyerror): Update.
9630         * go-exp.y (lex_one_token, yyerror): Update.
9631         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9632         * d-exp.y (lex_one_token, yyerror): Update.
9633         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9634         (lex_one_token, yyerror): Update.
9635         * ada-lex.l (YY_INPUT): Update.
9636         (rewind_to_char): Update.
9637         * ada-exp.y (yyerror): Update.
9638
9639 2019-04-04  Tom Tromey  <tom@tromey.com>
9640
9641         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9642         * parser-defs.h (struct parser_state) <parser_state>: Add new
9643         parameter.
9644         <comma_terminates>: New member.
9645         (comma_terminates): Don't declare global.
9646         * parse.c (comma_terminates): Remove global.
9647         (parse_exp_in_context): Update.
9648         * p-exp.y (yylex): Update.
9649         * m2-exp.y (yylex): Update.
9650         * go-exp.y (lex_one_token): Update.
9651         * f-exp.y (yylex): Update.
9652         * d-exp.y (lex_one_token): Update.
9653         * c-exp.y (lex_one_token): Update.
9654         * ada-lex.l: Update.
9655
9656 2019-04-04  Tom Tromey  <tom@tromey.com>
9657
9658         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9659         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9660         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9661         * parser-defs.h (paren_depth): Don't declare.
9662         * parse.c (paren_depth): Remove global.
9663         (parse_exp_in_context): Update.
9664         * p-exp.y (paren_depth): New global.
9665         (pascal_parse): Initialize it.
9666         * m2-exp.y (paren_depth): New global.
9667         (m2_parse): Initialize it.
9668         * go-exp.y (paren_depth): New global.
9669         (go_parse): Initialize it.
9670         * f-exp.y (paren_depth): New global.
9671         (f_parse): Initialize it.
9672         * d-exp.y (paren_depth): New global.
9673         (d_parse): Initialize it.
9674         * c-exp.y (paren_depth): New global.
9675         (c_parse): Initialize it.
9676         * ada-lex.l (paren_depth): New global.
9677         (lexer_init): Initialize it.
9678
9679 2019-04-04  Tom Tromey  <tom@tromey.com>
9680
9681         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9682         (rust_parser::convert_ast_to_type)
9683         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9684         * parser-defs.h (struct parser_state) <parser_state>: Add
9685         parameters.  Initialize new members.
9686         <expression_context_block, expression_context_pc>: New members.
9687         * parse.c (expression_context_block, expression_context_pc):
9688         Remove globals.
9689         (parse_exp_in_context): Update.
9690         * p-exp.y: Update all rules.
9691         (yylex): Update.
9692         * m2-exp.y: Update all rules.
9693         (yylex): Update.
9694         * go-exp.y (yylex): Update.
9695         * f-exp.y (yylex): Update.
9696         * d-exp.y: Update all rules.
9697         (yylex): Update.
9698         * c-exp.y: Update all rules.
9699         (lex_one_token, classify_name, yylex, c_parse): Update.
9700         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9701
9702 2019-04-04  Tom Tromey  <tom@tromey.com>
9703
9704         * gdbarch.h, gdbarch.c: Rebuild.
9705         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9706         * stap-probe.h:
9707         (struct stap_parse_info): Replace "parser_state" with
9708         "expr_builder".
9709         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9710         (parser_state): New class.
9711         * parse.c (expr_builder): Rename.
9712         (expr_builder::release): Rename.
9713         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9714         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9715         (write_exp_elt_longcst, write_exp_elt_floatcst)
9716         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9717         (write_exp_string_vector, write_exp_bitstring)
9718         (write_exp_msymbol, mark_struct_expression)
9719         (write_dollar_variable)
9720         (insert_type_address_space, increase_expout_size): Replace
9721         "parser_state" with "expr_builder".
9722         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9723         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9724         "parser_state" with "expr_builder".
9725
9726 2019-04-04  Tom Tromey  <tom@tromey.com>
9727
9728         * rust-exp.y: Replace "parse_language" with method call.
9729         * p-exp.y:
9730         (yylex): Replace "parse_language" with method call.
9731         * m2-exp.y:
9732         (yylex): Replace "parse_language" with method call.
9733         * go-exp.y (classify_name): Replace "parse_language" with method
9734         call.
9735         * f-exp.y (yylex): Replace "parse_language" with method call.
9736         * d-exp.y (lex_one_token): Replace "parse_language" with method
9737         call.
9738         * c-exp.y:
9739         (lex_one_token, classify_name, yylex): Replace "parse_language"
9740         with method call.
9741         * ada-exp.y (find_primitive_type, type_char)
9742         (type_system_address): Replace "parse_language" with method call.
9743
9744 2019-04-04  Tom Tromey  <tom@tromey.com>
9745
9746         * rust-exp.y: Replace "parse_gdbarch" with method call.
9747         * parse.c (write_dollar_variable, insert_type_address_space):
9748         Replace "parse_gdbarch" with method call.
9749         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9750         call.
9751         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9752         call.
9753         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9754         "parse_gdbarch" with method call.
9755         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9756         with method call.
9757         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9758         "parse_gdbarch" with method call.
9759         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9760         "parse_gdbarch" with method call.
9761         * c-exp.y (parse_type, parse_number, classify_name): Replace
9762         "parse_gdbarch" with method call.
9763         * ada-lex.l: Replace "parse_gdbarch" with method call.
9764         * ada-exp.y (parse_type, find_primitive_type, type_char)
9765         (type_system_address): Replace "parse_gdbarch" with method call.
9766
9767 2019-04-04  Tom Tromey  <tom@tromey.com>
9768
9769         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9770         * stap-probe.c (stap_parse_argument): Update.
9771         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9772         initial_size parameter.
9773         * rust-exp.y (rust_lex_tests): Update.
9774         * parse.c (parser_state): Update.
9775         (parse_exp_in_context): Update.
9776         * parser-defs.h (struct parser_state) <parser_state>: Remove
9777         "initial_size" parameter.
9778
9779 2019-04-04  Tom Tromey  <tom@tromey.com>
9780
9781         * parser-defs.h (increase_expout_size): Don't declare.
9782         * parse.c (increase_expout_size): Now static.
9783
9784 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9785
9786         * gnu-nat.c (gnu_nat_target::wait): Fix
9787         target_waitstatus_to_string call.
9788
9789 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9790
9791         * eval.c (evaluate_subexp_standard): Handle internal functions
9792         during Fortran function call handling.
9793
9794 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9795
9796         * NEWS: Mention new internal functions.
9797         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9798         (read_base_type): Use dwarf2_init_complex_target_type.
9799         * value.c (creal_internal_fn): New function.
9800         (cimag_internal_fn): New function.
9801         (_initialize_values): Register new internal functions.
9802
9803 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9804
9805         * infrun.c (stop_all_threads): If debug_infrun, always
9806         trace the wait status after wait_one, using
9807         target_waitstatus_to_string and target_pid_to_str.
9808         (handle_inferior_event): Replace various trace of
9809         wait status kind by a single trace.
9810         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9811         wait status kind image by target_waitstatus_to_string.
9812         * target/waitstatus.c (target_waitstatus_to_string): Fix
9813         obsolete comment.
9814
9815 2019-04-01  Tom Tromey  <tromey@adacore.com>
9816
9817         PR symtab/23331:
9818         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9819
9820 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9821             Pedro Alves  <palves@redhat.com>
9822
9823         * top.c (quit_force): Call 'finalize_values'.
9824         * value.c (finalize_values): New function.
9825         * value.h (finalize_values): Declare.
9826
9827 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9828
9829         * NEWS: Announce $_gdb_major and $_gdb_minor.
9830
9831         * top.c (init_gdb_version_vars): New function.
9832         (gdb_init): Call init_gdb_version_vars.
9833
9834 2019-03-29  Tom Tromey  <tromey@adacore.com>
9835
9836         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9837         help text.  Remove dead code.
9838
9839 2019-03-29  Keith Seitz  <keiths@redhat.com>
9840
9841         From Siddhesh Poyarekar:
9842         * f-lang.h (f77_get_upperbound): Return LONGEST.
9843         (f77_get_lowerbound): Likewise.
9844         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9845         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9846         print them.
9847         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9848         plongest to format print it.
9849         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9850         (f77_get_upperbound): Likewise.
9851         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9852         LOWER_BOUND to LONGEST.
9853         (f77_create_arrayprint_offset_tbl): Likewise.
9854
9855 2019-03-29  Keith Seitz  <keiths@redhat.com>
9856
9857         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9858         %s/pulongest for TYPE_LENGTH instead of %d in format
9859         strings.
9860         * ada-typerint.c (ada_print_type): Likewise.
9861         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9862         * compile/compile-c-support.c (generate_register_struct): Likewise.
9863         * gdbtypes.c (recursive_dump_type): Likewise.
9864         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9865         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9866         instead of %d in format strings.
9867         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9868         to std::min to ULONGEST.
9869         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9870         instead of %d in format strings.
9871         * tracepoint.c (info_scope_command): Likewise.
9872         * typeprint.c (print_offset_data::update)
9873         (print_offset_data::finish): Likewise.
9874         * xtensa-tdep.c (xtensa_store_return_value)
9875         (xtensa_push_dummy_call): Likewise.
9876
9877 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9878
9879         * windows-nat.c (display_selector): Fixed format specifications
9880         for 64-bit Cygwin.
9881
9882 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9883
9884         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9885
9886 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9887
9888         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9889         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9890         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9891         (nios2_linux_init_abi): Install it.
9892
9893 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9894
9895         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9896
9897 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9898
9899         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9900
9901 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9902             Tom Tromey  <tromey@adacore.com>
9903
9904         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9905
9906 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9907
9908         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9909         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9910         method to compute the bounds of range types. Also print "[evaluated]"
9911         if the bounds' values come from a dynamic evaluation.
9912
9913 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9914
9915         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9916         whitespace when pretty printing is on.
9917
9918 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9919
9920         * ppc-linux-nat.c: Add include.
9921
9922 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9923
9924         * NEWS: Mention AArch64 Pointer Authentication.
9925
9926 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9927
9928         * arm-linux-nat.c: Add include.
9929
9930 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9931
9932         * source-cache.c (source_cache::get_source_lines): Re-read
9933         fullname after calling open_source_file.
9934
9935 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9936
9937         * NEWS: Mention TLS support for FreeBSD.
9938
9939 2019-03-25  Tom Tromey  <tromey@adacore.com>
9940
9941         * minsyms.c (BUNCH_SIZE): Update comment.
9942         (~minimal_symbol_reader): Remove old comment.
9943         (compact_minimal_symbols): Update comment.
9944         (minimal_symbol_reader::install): Remove old comment.  Update
9945         other comments.
9946
9947 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9948
9949         * s390-linux-nat.c: Add include.
9950
9951 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9952
9953         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9954         Call linux_get_hwcap.
9955         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9956         Likewise.
9957         (aarch64_linux_get_hwcap): Remove function.
9958         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9959         declaration.
9960         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9961         linux_get_hwcap.
9962         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9963         * linux-tdep.c (linux_get_hwcap): Add function.
9964         (linux_get_hwcap2): Likewise.
9965         * linux-tdep.h (linux_get_hwcap): Add declaration.
9966         (linux_get_hwcap2): Likewise.
9967         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9968         (ppc_linux_get_hwcap2): Likewise.
9969         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9970         linux_get_hwcap.
9971         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9972         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9973         (ppc_linux_nat_target::read_description): Likewise.
9974         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9975         * s390-linux-nat.c: Likewise.
9976         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9977
9978 2019-03-24  Tom Tromey  <tom@tromey.com>
9979
9980         * ada-lang.c (standard_lookup): Simplify initialization.
9981         (ada_lookup_symbol_nonlocal): Simplify return.
9982         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9983         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9984         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9985         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9986         initialization.
9987         * solib.c (solib_global_lookup): Simplify.
9988         * symtab.c (null_block_symbol): Remove.
9989         (symbol_cache_lookup): Simplify returns.
9990         (lookup_language_this): Simplify returns.
9991         (lookup_symbol_aux): Simplify return.
9992         (lookup_local_symbol): Simplify returns.
9993         (lookup_global_symbol_from_objfile): Simplify return.
9994         (lookup_symbol_in_objfile_symtabs)
9995         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9996         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9997         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9998         * cp-namespace.c (cp_lookup_bare_symbol)
9999         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10000         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10001         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10002         (cp_lookup_symbol_via_imports): Simplify initialization.
10003         (find_symbol_in_baseclass): Likewise.
10004         * symtab.h (null_block_symbol): Remove.
10005         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10006         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10007         (d_lookup_symbol_module): Likewise.
10008         (find_symbol_in_baseclass): Simplify initialization.
10009
10010 2019-03-24  Tom Tromey  <tom@tromey.com>
10011
10012         * expression.h: Don't include symtab.h.
10013         (struct block): Forward declare.
10014
10015 2019-03-24  Tom Tromey  <tom@tromey.com>
10016
10017         * c-exp.y (typebase): Remove casts.
10018         * gdbtypes.c (lookup_unsigned_typename, )
10019         (lookup_signed_typename): Remove cast.
10020         * eval.c (parse_to_comma_and_eval): Remove cast.
10021         * parse.c (write_dollar_variable): Remove cast.
10022         * block.h (struct block) <superblock>: Now const.
10023         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10024         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10025         (map_block): Make "block" const.
10026         * symfile.h (struct quick_symbol_functions)
10027         <map_matching_symbols>: Constify block argument to "callback".
10028         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10029         const.
10030         (find_pc_sect_compunit_symtab): Make "b" const.
10031         (find_symbol_at_address): Likewise.
10032         (search_symbols): Likewise.
10033         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10034         (dw2_debug_names_lookup_symbol): Likewise.
10035         (dw2_map_matching_symbols): Update.
10036         * p-valprint.c (pascal_val_print): Remove "block".
10037         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10038         (aux_add_nonlocal_symbols): Make "block" const.
10039         (resolve_subexp): Remove cast.
10040         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10041         const.
10042         (iterate_over_file_blocks): Likewise.
10043         * f-exp.y (%union) <bval>: Remove.
10044         * coffread.c (patch_opaque_types): Make "b" const.
10045         * spu-tdep.c (spu_catch_start): Make "block" const.
10046         * c-valprint.c (print_unpacked_pointer): Remove "block".
10047         * symmisc.c (dump_symtab_1): Make "b" const.
10048         (block_depth): Make "block" const.
10049         * d-exp.y (%union) <bval>: Remove.
10050         * cp-support.h (cp_lookup_rtti_type): Update.
10051         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10052         * psymtab.c (psym_lookup_symbol): Make "block" const.
10053         (maintenance_check_psymtabs): Make "b" const.
10054         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10055         (enumerate_locals, enumerate_args): Update.
10056         * python/py-symtab.c (stpy_global_block): Make "block" const.
10057         (stpy_static_block): Likewise.
10058         * inline-frame.c (block_starting_point_at): Make "new_block"
10059         const.
10060         * block.c (find_block_in_blockvector): Make return type const.
10061         (blockvector_for_pc_sect): Make "b" const.
10062         (find_block_in_blockvector): Make "b" const.
10063
10064 2019-03-23  Tom Tromey  <tom@tromey.com>
10065
10066         * varobj.c (varobj_create): Update.
10067         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10068         * printcmd.c (display_command, do_one_display): Don't reset
10069         innermost_block.
10070         * parser-defs.h (enum innermost_block_tracker_type): Move to
10071         expression.h.
10072         (innermost_block): Update comment.
10073         * parse.c (parse_exp_1): Add tracker_types parameter.
10074         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10075         tracker_types parameter.  Reset innermost_block.
10076         (parse_exp_in_context): Remove.
10077         (parse_expression_for_completion): Update.
10078         * objfiles.c (~objfile): Don't reset expression_context_block or
10079         innermost_block.
10080         * expression.h (enum innermost_block_tracker_type): Move from
10081         parser-defs.h.
10082         (parse_exp_1): Add tracker_types parameter.
10083         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10084         reset innermost_block.
10085
10086 2019-03-23  Tom Tromey  <tom@tromey.com>
10087
10088         * objfiles.h: Include bcache.h.
10089
10090 2019-03-23  Tom Tromey  <tom@tromey.com>
10091
10092         * linespec.c (get_current_search_block): Use
10093         scoped_restore_current_language.
10094         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10095
10096 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10097             Jiong Wang  <jiong.wang@arm.com>
10098
10099         * aarch64-linux-tdep.c
10100         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10101         section.
10102         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10103
10104 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10105             Jiong Wang  <jiong.wang@arm.com>
10106
10107         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10108         instructions.
10109         (aarch64_analyze_prologue_test): Add PACIASP test.
10110         (aarch64_prologue_prev_register): Unmask PC value.
10111
10112 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10113             Jiong Wang  <jiong.wang@arm.com>
10114
10115         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10116         (aarch64_dwarf2_prev_register): Unmask PC value.
10117         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10118         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10119         DW_CFA_AARCH64_negate_ra_state.
10120         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10121
10122 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10123             Jiong Wang  <jiong.wang@arm.com>
10124
10125         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10126         registers.
10127         (aarch64_pseudo_register_name): Likewise.
10128         (aarch64_pseudo_register_type): Likewise.
10129         (aarch64_pseudo_register_reggroup_p): Likewise.
10130         (aarch64_gdbarch_init): Add pauth registers.
10131         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10132         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10133         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10134         (struct gdbarch_tdep): Add regnum for ra_state.
10135
10136 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10137             Jiong Wang  <jiong.wang@arm.com>
10138
10139         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10140
10141 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10142             Jiong Wang  <jiong.wang@arm.com>
10143
10144         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10145         function.
10146         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10147         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10148         (aarch64_gdbarch_init): Add puth registers.
10149         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10150         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10151         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10152
10153 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10154             Jiong Wang  <jiong.wang@arm.com>
10155
10156         * aarch64-linux-nat.c
10157         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10158         * aarch64-linux-tdep.c
10159         (aarch64_linux_core_read_description): Likewise.
10160         (aarch64_linux_get_hwcap): New function.
10161         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10162         (aarch64_linux_get_hwcap): New declaration.
10163
10164 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10165             Jiong Wang  <jiong.wang@arm.com>
10166
10167         * aarch64-linux-nat.c
10168         (aarch64_linux_nat_target::read_description): Add pauth param.
10169         * aarch64-linux-tdep.c
10170         (aarch64_linux_core_read_description): Likewise.
10171         * aarch64-tdep.c (struct target_desc): Add in pauth.
10172         (aarch64_read_description): Add pauth param.
10173         (aarch64_gdbarch_init): Likewise.
10174         * aarch64-tdep.h (aarch64_read_description): Likewise.
10175         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10176         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10177         * features/Makefile: Add new files.
10178         * features/aarch64-pauth.c: New file.
10179         * features/aarch64-pauth.xml: New file.
10180
10181 2019-03-20  Tom Tromey  <tromey@adacore.com>
10182
10183         * infrun.c (handle_inferior_event): Rename from
10184         handle_inferior_event_1.  Create a scoped_value_mark.
10185         (handle_inferior_event): Remove.
10186
10187 2019-03-19  Tom Tromey  <tromey@adacore.com>
10188
10189         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10190         * infrun.h (print_stop_event): Add "displays" parameter.
10191         * infrun.c (print_stop_event): Add "displays" parameter.
10192
10193 2019-03-19  Pedro Alves  <palves@redhat.com>
10194
10195         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10196         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10197         to -1.  Fix TABs vs spaces.
10198         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10199         * tui/tui-out.h (tui_ui_out) Add intro comments.
10200         <m_line, m_start_of_line>: In-class initialize, and add describing
10201         comment.
10202
10203 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10204
10205         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10206         variable names.
10207         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10208
10209 2019-03-18  Pedro Alves  <palves@redhat.com>
10210             Eli Zaretskii <eliz@gnu.org>
10211
10212         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10213         m_line and m_start_of_line.
10214
10215 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10216
10217         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10218         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10219         it returns a newline.  This fixes a regression in TU mode, whereby
10220         the next line is output on the same screen line as the user input.
10221
10222 2019-03-18  Tom Tromey  <tromey@adacore.com>
10223
10224         * minsyms.c (minimal_symbol_reader::install): Remove call to
10225         obstack_blank.
10226
10227 2019-03-18  Pedro Alves  <palves@redhat.com>
10228
10229         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10230         New globals.
10231         (apply_style): New, factored out from ...
10232         (apply_ansi_escape): ... this.  Handle reverse video mode.
10233         (tui_set_reverse_mode): New function.
10234         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10235         * tui/tui-winsource.c (tui_show_source_line): Use
10236         tui_set_reverse_mode instead of setting A_STANDOUT.
10237         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10238         New setter methods.
10239
10240 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10241
10242         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10243         Handle tabs.
10244
10245 2019-03-18  Tom Tromey  <tromey@adacore.com>
10246
10247         * ada-lang.c (empty_array): Add "high" parameter.
10248         (ada_evaluate_subexp): Update.
10249
10250 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10251
10252         * unittests/string_view-selftests.c: Define
10253         _initialize_string_view_selftests unconditionally.
10254
10255 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10256
10257         PR gdb/24350
10258         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10259
10260 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10261
10262         PR gdb/24351
10263         * windows-nat.c (display_selector): Fix format specifiers.
10264
10265 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10266
10267         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10268         tui_refill_source_window instead of tui_refresh_win, to update the
10269         current execution line.  This fixes redisplay of the current line
10270         when stepping through the code with "next" or "step".
10271
10272 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10273
10274         * source-cache.c (source_cache::get_source_lines): Call
10275         find_source_lines to initialize s->nlines.  This fixes vertical
10276         scrolling of TUI source window when the DOWN arrow is pressed.
10277
10278 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10279
10280         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10281         linux-thread-db.c (_initialize_thread_db): Likewise.
10282
10283 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10284
10285         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10286         wclrtoeol in tui_show_source_line".  This reverts changes made in
10287         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10288
10289 2019-03-15  Tom Tromey  <tom@tromey.com>
10290
10291         * symtab.h (struct minimal_symbol): Derive from
10292         general_symbol_info.
10293         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10294         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10295         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10296         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10297         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10298         (MSYMBOL_SEARCH_NAME): Update.
10299         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10300         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10301         * minsyms.c (minimal_symbol_reader::record_full): Update.
10302
10303 2019-03-15  Tom Tromey  <tom@tromey.com>
10304
10305         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10306
10307 2019-03-15  Tom Tromey  <tom@tromey.com>
10308
10309         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10310         unique_xmalloc_ptr.
10311         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10312         Update.
10313         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10314         (build_minimal_symbol_hash_tables)
10315         (minimal_symbol_reader::install): Update.
10316
10317 2019-03-15  Tom Tromey  <tom@tromey.com>
10318
10319         * symtab.c (create_demangled_names_hash): Update.
10320         (symbol_set_names): Update.
10321         * objfiles.h (struct objfile_per_bfd_storage)
10322         <demangled_names_hash>: Now an htab_up.
10323         * objfiles.c (objfile_per_bfd_storage): Simplify.
10324
10325 2019-03-15  Tom Tromey  <tom@tromey.com>
10326
10327         * objfiles.h (struct objfile_per_bfd_storage): Declare
10328         destructor.
10329         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10330         New.
10331         (get_objfile_bfd_data): Use new.  Don't initialize
10332         language_of_main.
10333         (free_objfile_per_bfd_storage): Remove.
10334         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10335
10336 2019-03-15  Tom Tromey  <tom@tromey.com>
10337
10338         * symfile.c (reread_symbols): Update.
10339         * objfiles.c (objfile::objfile): Update.
10340         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10341         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10342         comment.
10343         (minimal_symbol_reader::install): Update.
10344         (terminate_minimal_symbol_table): Remove.
10345         * jit.c (jit_object_close_impl): Update.
10346
10347 2019-03-15  Tom Tromey  <tom@tromey.com>
10348
10349         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10350         initializations.
10351
10352 2019-03-15  Tom Tromey  <tom@tromey.com>
10353
10354         * objfiles.h (struct objfile_per_bfd_storage)
10355         <demangled_hash_languages>: Now a bitset.
10356         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10357         (lookup_minimal_symbol): Update.
10358
10359 2019-03-15  Tom Tromey  <tom@tromey.com>
10360
10361         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10362         Don't return the symbol.
10363         * coffread.c (record_minimal_symbol): Use record_full.
10364
10365 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10366
10367         The MS-Windows port of ncurses fails to switch to a color pair if
10368         one or both of the colors are the implicit default colors.  This
10369         change records the default colors when TUI is initialized, and
10370         then specifies them explicitly when a color pair uses the default
10371         colors.  This allows color styling in TUI mode on MS-Windows.
10372
10373         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10374         ncurses_norm_attr.
10375         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10376         colors in ncurses_norm_attr.
10377         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10378         "none", replace it with the default color recorded in
10379         ncurses_norm_attr.
10380
10381 2019-03-14  Tom Tromey  <tromey@adacore.com>
10382
10383         * source-cache.h (class source_cache) <get_source_lines>: Return
10384         std::string.
10385         * source-cache.c (source_cache::extract_lines): Handle case where
10386         first_pos==npos.  Return std::string.
10387         (source_cache::get_source_lines): Update.
10388
10389 2019-03-14  Tom Tromey  <tromey@adacore.com>
10390
10391         * NEWS: Add item for "style sources" commands.
10392         * source-cache.c (source_cache::get_source_lines): Check
10393         source_styling.
10394         * cli/cli-style.c (source_styling): New global.
10395         (_initialize_cli_style): Add "style sources" commands.
10396         (show_style_sources): New function.
10397         * cli/cli-style.h (source_styling): Declare.
10398
10399 2019-03-14  Pedro Alves  <palves@redhat.com>
10400             Tom Tromey  <tromey@adacore.com>
10401
10402         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10403         * tui/tui-winsource.c (tui_refill_source_window): New function,
10404         from...
10405         (tui_horizontal_source_scroll): ... here.  Move some logic.
10406         * cli/cli-style.c (set_style_enabled): Notify new observable.
10407         * tui/tui-hooks.c (tui_redisplay_source): New function.
10408         (tui_attach_detach_observers): Attach or detach
10409         tui_redisplay_source.
10410         * observable.h (source_styling_changed): New observable.
10411         * observable.c: Define source_styling_changed observable.
10412
10413 2019-03-13  Tom Tromey  <tromey@adacore.com>
10414
10415         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10416         (i386_gnu_nat_target::store_registers): Update.
10417         * target-debug.h (target_debug_print_std_string): New macro.
10418         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10419         * windows-tdep.c (display_one_tib): Update.
10420         * tui/tui-stack.c (tui_make_status_line): Update.
10421         * top.c (print_inferior_quit_action): Update.
10422         * thread.c (thr_try_catch_cmd): Update.
10423         (add_thread_with_info): Update.
10424         (thread_target_id_str): Update.
10425         (thr_try_catch_cmd): Update.
10426         (thread_command): Update.
10427         (thread_find_command): Update.
10428         * record-btrace.c (record_btrace_target::info_record)
10429         (record_btrace_resume_thread, record_btrace_target::resume)
10430         (record_btrace_cancel_resume, record_btrace_step_thread)
10431         (record_btrace_target::wait, record_btrace_target::wait)
10432         (record_btrace_target::wait, record_btrace_target::stop): Update.
10433         * progspace.c (print_program_space): Update.
10434         * process-stratum-target.c
10435         (process_stratum_target::thread_address_space): Update.
10436         * linux-fork.c (linux_fork_mourn_inferior)
10437         (detach_checkpoint_command, info_checkpoints_command)
10438         (linux_fork_context): Update.
10439         (linux_fork_detach): Update.
10440         (class scoped_switch_fork_info): Update.
10441         (delete_checkpoint_command): Update.
10442         * infrun.c (follow_fork_inferior): Update.
10443         (follow_fork_inferior): Update.
10444         (proceed_after_vfork_done): Update.
10445         (handle_vfork_child_exec_or_exit): Update.
10446         (follow_exec): Update.
10447         (displaced_step_prepare_throw): Update.
10448         (displaced_step_restore): Update.
10449         (start_step_over): Update.
10450         (resume_1): Update.
10451         (clear_proceed_status_thread): Update.
10452         (proceed): Update.
10453         (print_target_wait_results): Update.
10454         (do_target_wait): Update.
10455         (context_switch): Update.
10456         (stop_all_threads): Update.
10457         (restart_threads): Update.
10458         (finish_step_over): Update.
10459         (handle_signal_stop): Update.
10460         (switch_back_to_stepped_thread): Update.
10461         (keep_going_pass_signal): Update.
10462         (print_exited_reason): Update.
10463         (normal_stop): Update.
10464         * inferior.c (inferior_pid_to_str): Change return type.
10465         (print_selected_inferior): Update.
10466         (add_inferior): Update.
10467         (detach_inferior): Update.
10468         * dummy-frame.c (fprint_dummy_frames): Update.
10469         * dcache.c (dcache_info_1): Update.
10470         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10471         (btrace_fetch, btrace_clear): Update.
10472         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10473         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10474         type.
10475         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10476         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10477         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10478         * gdbarch.c, gdbarch.h: Rebuild.
10479         * gdbarch.sh (core_pid_to_str): Change return type.
10480         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10481         return type.
10482         (windows_nat_target::pid_to_str): Change return type.
10483         (windows_delete_thread): Update.
10484         (windows_nat_target::attach): Update.
10485         (windows_nat_target::files_info): Update.
10486         * target-delegates.c: Rebuild.
10487         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10488         return type.
10489         (sol_thread_target::pid_to_str): Change return type.
10490         * remote.c (class remote_target) <pid_to_str>: Change return
10491         type.
10492         (remote_target::pid_to_str): Change return type.
10493         (extended_remote_target::attach, remote_target::remote_stop_ns)
10494         (remote_target::remote_notif_remove_queued_reply)
10495         (remote_target::push_stop_reply, remote_target::disable_btrace):
10496         Update.
10497         (extended_remote_target::attach): Update.
10498         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10499         type.
10500         (gdbsim_target::pid_to_str): Change return type.
10501         * ravenscar-thread.c (struct ravenscar_thread_target)
10502         <pid_to_str>: Change return type.
10503         (ravenscar_thread_target::pid_to_str): Change return type.
10504         * procfs.c (class procfs_target) <pid_to_str>: Change return
10505         type.
10506         (procfs_target::pid_to_str): Change return type.
10507         (procfs_target::attach): Update.
10508         (procfs_target::detach): Update.
10509         (procfs_target::fetch_registers): Update.
10510         (procfs_target::store_registers): Update.
10511         (procfs_target::wait): Update.
10512         (procfs_target::files_info): Update.
10513         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10514         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10515         return type.
10516         (nto_procfs_target::pid_to_str): Change return type.
10517         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10518         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10519         return type.
10520         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10521         (exit_lwp): Update.
10522         (attach_proc_task_lwp_callback, get_detach_signal)
10523         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10524         (linux_nat_target::resume, wait_lwp, stop_callback)
10525         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10526         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10527         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10528         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10529         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10530         type.
10531         (inf_ptrace_target::attach): Update.
10532         (inf_ptrace_target::files_info): Update.
10533         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10534         type.
10535         (go32_nat_target::pid_to_str): Change return type.
10536         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10537         (gnu_nat_target::wait): Update.
10538         (gnu_nat_target::wait): Update.
10539         (gnu_nat_target::resume): Update.
10540         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10541         (fbsd_nat_target::wait): Update.
10542         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10543         type.
10544         (darwin_nat_target::attach): Update.
10545         * corelow.c (class core_target) <pid_to_str>: Change return type.
10546         (core_target::pid_to_str): Change return type.
10547         * target.c (normal_pid_to_str): Change return type.
10548         (default_pid_to_str): Likewise.
10549         (target_pid_to_str): Change return type.
10550         (target_translate_tls_address): Update.
10551         (target_announce_detach): Update.
10552         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10553         return type.
10554         (bsd_uthread_target::pid_to_str): Change return type.
10555         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10556         type.
10557         (bsd_kvm_target::pid_to_str): Change return type.
10558         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10559         return type.
10560         (aix_thread_target::pid_to_str): Change return type.
10561         * target.h (struct target_ops) <pid_to_str>: Change return type.
10562         (target_pid_to_str, normal_pid_to_str): Likewise.
10563         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10564         type.
10565         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10566         type.
10567         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10568         return type.
10569         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10570         type.
10571         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10572         type.
10573         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10574         return type.
10575
10576 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10577
10578         * NEWS: Mention that the new default MI version is 3.  Mention
10579         changes to the output of commands and events that deal with
10580         multi-location breakpoints.
10581         * breakpoint.c: Include "mi/mi-out.h".
10582         (print_one_breakpoint): Change output syntax if using MI version
10583         >= 3.
10584         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10585         New.
10586         (mi_multi_location_breakpoint_output_fixed): New.
10587         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10588         (mi_cmd_fix_multi_location_breakpoint_output): New.
10589         (mi_multi_location_breakpoint_output_fixed): New.
10590         * mi/mi-cmds.c (mi_cmds): Register command
10591         -fix-multi-location-breakpoint-output.
10592         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10593         interpreter "mi".
10594
10595 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10596
10597         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10598         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10599         instantiate mi_ui_out based on interpreter name.
10600         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10601         * mi/mi-main.c (mi_load_progress): Likewise.
10602
10603 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10604
10605         * NEWS: Combine separate "New targets" sections for 8.3.
10606
10607 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10608
10609         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10610         (ppcfbsd_init_abi): Install gdbarch
10611         "fetch_tls_load_module_address" and "get_thread_local_address"
10612         methods.
10613
10614 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10615
10616         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10617         (riscv_fbsd_init_abi): Install gdbarch
10618         "fetch_tls_load_module_address" and "get_thread_local_address"
10619         methods.
10620
10621 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10622
10623         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10624         (i386fbsd_init_abi): Install gdbarch
10625         "fetch_tls_load_module_address" and "get_thread_local_address"
10626         methods.
10627
10628 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10629
10630         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10631         (amd64fbsd_init_abi): Install gdbarch
10632         "fetch_tls_load_module_address" and "get_thread_local_address"
10633         methods.
10634
10635 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10636
10637         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10638         (struct fbsd_pspace_data): New type.
10639         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10640         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10641         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10642         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10643         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10644
10645 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10646
10647         * gdbtypes.c (lookup_struct_elt): New function.
10648         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10649         * gdbtypes.h (struct struct_elt): New type.
10650         (lookup_struct_elt): New prototype.
10651
10652 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10653
10654         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10655         remove disabled code block.
10656
10657 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10658
10659         * gdbarch.sh (get_thread_local_address): New method.
10660         * gdbarch.h, gdbarch.c: Regenerate.
10661         * target.c (target_translate_tls_address): Use
10662         gdbarch_get_thread_local_address if present instead of
10663         target::get_thread_local_address.
10664
10665 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10666
10667         * target.h (target::get_thread_local_address): Update comment.
10668
10669 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10670
10671         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10672         objfile->separate_debug_objfile_backlink if not NULL.
10673
10674 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10675
10676         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10677         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10678         (amd64bsd_store_inferior_registers): Likewise.
10679         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10680         Enable segment base registers.
10681         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10682         PT_GETFSBASE and PT_GETGSBASE.
10683         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10684         PT_SETGSBASE.
10685         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10686         segment base registers.
10687         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10688
10689 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10690
10691         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10692         Update calls to i386_target_description to add 'segments'
10693         parameter.
10694         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10695         add segment base registers.
10696         * arch/i386.c (i386_create_target_description): Add 'segments'
10697         parameter to enable segment base registers.
10698         * arch/i386.h (i386_create_target_description): Likewise.
10699         * features/i386/32bit-segments.xml: New file.
10700         * features/i386/32bit-segments.c: Generate.
10701         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10702         call to i386_target_description to add 'segments' parameter.
10703         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10704         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10705         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10706         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10707         if feature is present.
10708         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10709         Add 'segments' parameter to call to i386_target_description.
10710         (i386_target_description): Add 'segments' parameter to enable
10711         segment base registers.
10712         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10713         to call to i386_target_description.
10714         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10715         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10716         Define I386_NUM_REGS.
10717         (i386_target_description): Add 'segments' parameter to enable
10718         segment base registers.
10719
10720 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10721
10722         PR/24325
10723         * source-cache.c: #undef open and close, to avoid unresolved
10724         externals during linking.
10725
10726 2019-03-12  Tom Tromey  <tromey@adacore.com>
10727
10728         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10729         const.  Add initializers.
10730         (_initialize_remote): Don't initialize ptid globals.
10731
10732 2019-03-12  Pedro Alves  <palves@redhat.com>
10733
10734         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10735
10736 2019-03-12  Pedro Alves  <palves@redhat.com>
10737
10738         * cp-name-parser.y (main): Remove unused 'len' variable.
10739
10740 2019-03-12  Tom Tromey  <tromey@adacore.com>
10741
10742         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10743         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10744
10745 2019-03-12  Tom Tromey  <tromey@adacore.com>
10746
10747         * linux-nat.c (iterate_over_lwps): Update.
10748         (stop_callback): Remove parameter.
10749         (stop_wait_callback, detach_callback, resume_set_callback)
10750         (select_singlestep_lwp_callback, set_ignore_sigint)
10751         (status_callback, resumed_callback, resume_clear_callback)
10752         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10753         data parameter.
10754         (linux_nat_target::detach, linux_nat_target::resume)
10755         (linux_stop_and_wait_all_lwps, select_event_lwp)
10756         (linux_nat_filter_event, linux_nat_wait_1)
10757         (linux_nat_target::kill, linux_nat_target::stop)
10758         (linux_nat_target::stop): Update.
10759         (linux_nat_resume_callback): Change type.
10760         (resume_stopped_resumed_lwps, count_events_callback)
10761         (select_event_lwp_callback): Likewise.
10762         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10763         * arm-linux-nat.c (struct update_registers_data): Remove.
10764         (update_registers_callback): Change type.
10765         (arm_linux_insert_hw_breakpoint1): Update.
10766         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10767         parameter.
10768         (x86_linux_dr_set_addr): Update.
10769         (x86_linux_dr_set_control): Update.
10770         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10771         (iterate_over_lwps): Use gdb::function_view.
10772         * nat/aarch64-linux-hw-point.c (struct
10773         aarch64_dr_update_callback_param): Remove.
10774         (debug_reg_change_callback): Change type.
10775         (aarch64_notify_debug_reg_change): Update.
10776         * s390-linux-nat.c (s390_refresh_per_info): Update.
10777
10778 2019-03-11  Tom Tromey  <tromey@adacore.com>
10779
10780         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10781         redundant assignment to "this_cu".
10782
10783 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10784
10785         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10786
10787 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10788
10789         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10790         from...
10791         (rank_one_type): ... this.
10792
10793 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10794
10795         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10796         from...
10797         (rank_one_type): ... this.
10798
10799 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10800
10801         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10802         from...
10803         (rank_one_type): ... this.
10804
10805 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10806
10807         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10808         from...
10809         (rank_one_type): ... this.
10810
10811 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10812
10813         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10814         from...
10815         (rank_one_type): ... this.
10816
10817 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10818
10819         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10820         from...
10821         (rank_one_type): ... this.
10822
10823 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10824
10825         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10826         from...
10827         (rank_one_type): ... this.
10828
10829 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10830
10831         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10832         from...
10833         (rank_one_type): ... this.
10834
10835 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10836
10837         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10838         from...
10839         (rank_one_type): ... this.
10840
10841 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10842
10843         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10844         from...
10845         (rank_one_type): ... this.
10846
10847 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10848
10849         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10850         from...
10851         (rank_one_type): ... this.
10852
10853 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10854
10855         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10856         from...
10857         (rank_one_type): ... this.
10858
10859 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10860
10861         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10862         inferior-events' shows the example events.
10863
10864 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10865
10866         Support styling on native MS-Windows console
10867
10868         PR/24315
10869         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10870         on MS-Windows if $TERM is not defined.
10871
10872         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10873
10874         * posix-hdep.c (gdb_console_fputs):
10875         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10876         functions.
10877         * ui-file.h (gdb_console_fputs): Add prototype.
10878
10879         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10880         back to fputs only if the former returns zero.
10881
10882 2019-03-07  Tom Tromey  <tom@tromey.com>
10883
10884         * symmisc.c (print_symbol_bcache_statistics): Update.
10885         (print_objfile_statistics): Update.
10886         * symfile.c (allocate_symtab): Update.
10887         * stabsread.c: Don't include bcache.h.
10888         * psymtab.h (struct psymbol_bcache): Don't declare.
10889         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10890         (psymbol_bcache_init, psymbol_bcache_free)
10891         (psymbol_bcache_get_bcache): Don't declare.
10892         * psymtab.c (struct psymbol_bcache): Remove.
10893         (psymtab_storage::psymtab_storage): Update.
10894         (psymtab_storage::~psymtab_storage): Update.
10895         (psymbol_bcache_init, psymbol_bcache_free)
10896         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10897         (add_psymbol_to_bcache): Update.
10898         (allocate_psymtab): Update.
10899         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10900         macro_cache>: No longer pointers.
10901         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10902         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10903         * macrotab.c (macro_bcache): Update.
10904         * macroexp.c: Don't include bcache.h.
10905         * gdbtypes.c (check_types_worklist): Update.
10906         (types_deeply_equal): Remove TRY/CATCH.  Update.
10907         * elfread.c (elf_symtab_read): Update.
10908         * dwarf2read.c: Don't include bcache.h.
10909         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10910         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10911         (print_bcache_statistics, bcache_memory_used): Don't declare.
10912         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10913         methods.  Rename all data members.
10914         * bcache.c (struct bcache): Move to bcache.h.
10915         (bcache::expand_hash_table): Rename from expand_hash_table.
10916         (bcache): Remove.
10917         (bcache::insert): Rename from bcache_full.
10918         (bcache::compare): Rename from bcache_compare.
10919         (bcache_xmalloc): Remove.
10920         (bcache::~bcache): Rename from bcache_xfree.
10921         (bcache::print_statistics): Rename from print_bcache_statistics.
10922         (bcache::memory_used): Rename from bcache_memory_used.
10923
10924 2019-03-07  Pedro Alves  <palves@redhat.com>
10925
10926         * infrun.c (normal_stop): Also check for
10927         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10928
10929 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10930
10931         * f-lang.c (value_from_host_double): Moved to...
10932         * value.c (value_from_host_double): ...here.
10933         * value.h (value_from_host_double): Declare.
10934         * guile/scm-math.c (vlscm_convert_typed_number): Use
10935         value_from_host_double.
10936         (vlscm_convert_number): Likewise.
10937         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10938         * python/py-value.c (convert_value_from_python): Likewise.
10939
10940 2019-03-06  Tom Tromey  <tom@tromey.com>
10941
10942         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10943
10944 2019-03-06  Tom Tromey  <tom@tromey.com>
10945
10946         * utils.h (free_current_contents): Don't declare.
10947         * utils.c (free_current_contents): Remove.
10948
10949 2019-03-06  Tom Tromey  <tom@tromey.com>
10950
10951         * top.c (quit_force): Update.
10952         * main.c (captured_command_loop): Update.
10953         * common/new-op.c (operator new): Update.
10954         * common/common-exceptions.c (struct catcher)
10955         <save_cleanup_chain>: Remove member.
10956         (exceptions_state_mc_init): Update.
10957         (exception_try_scope_entry): Return nullptr.
10958         (exception_try_scope_exit, exception_rethrow)
10959         (throw_exception_sjlj, throw_exception_cxx): Update.
10960         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10961         (all_cleanups, do_cleanups, discard_cleanups)
10962         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10963         (restore_cleanups, restore_final_cleanups): Don't declare.
10964         (do_final_cleanups): Remove parameter.
10965         * common/cleanups.c (cleanup_chain, make_cleanup)
10966         (make_cleanup_dtor, all_cleanups, do_cleanups)
10967         (discard_my_cleanups, discard_cleanups)
10968         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10969         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10970         (null_cleanup): Remove.
10971         (do_final_cleanups): Remove parameter.
10972
10973 2019-03-06  Tom Tromey  <tom@tromey.com>
10974
10975         * remote.c (remote_target::remote_parse_stop_reply): Use
10976         unique_xmalloc_ptr.
10977
10978 2019-03-06  Tom Tromey  <tom@tromey.com>
10979
10980         * stabsread.c (struct stabs_field_info): Rename from field_info.
10981         <list, fnlist>: Add initializers.
10982         <obstack>: New member.
10983         (read_member_functions, read_struct_fields, read_baseclasses):
10984         Allocate on obstack.  Don't use cleanups.
10985         (read_one_struct_field, read_member_functions, read_struct_fields)
10986         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10987         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10988         (read_struct_type): Update.
10989
10990 2019-03-06  Tom Tromey  <tom@tromey.com>
10991
10992         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10993         * common/filestuff.h (make_cleanup_close): Don't declare.
10994         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10995         Remove.
10996
10997 2019-03-06  Tom Tromey  <tom@tromey.com>
10998
10999         * solib-aix.c: Use make_scope_exit.
11000
11001 2019-03-06  Tom Tromey  <tom@tromey.com>
11002
11003         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11004         Use make_scope_exit.
11005
11006 2019-03-06  Tom Tromey  <tom@tromey.com>
11007
11008         * solib-svr4.c (disable_probes_interface): Remove parameter.
11009         (svr4_handle_solib_event): Use make_scope_exit.
11010
11011 2019-03-06  Tom Tromey  <tom@tromey.com>
11012
11013         * remote.c (struct stop_reply_deleter): Remove.
11014         (stop_reply_up): Update.
11015         (struct stop_reply): Derive from notif_event.  Don't typedef.
11016         <regcache>: Now a std::vector.
11017         (stop_reply_xfree): Remove.
11018         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11019         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11020         (remote_target::discard_pending_stop_replies): Use delete.
11021         (remote_target::remote_parse_stop_reply): Update.
11022         (remote_target::process_stop_reply): Update.
11023         * remote-notif.h (struct notif_event): Add virtual destructor.
11024         Remove "dtr" member.
11025         (struct notif_client) <alloc_event>: Return a unique_ptr.
11026         (notif_event_xfree): Don't declare.
11027         (notif_event_up): New typedef.
11028         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11029         (notif_event_xfree, do_notif_event_xfree): Remove.
11030         (remote_notif_state_xfree): Update.
11031
11032 2019-03-06  Tom Tromey  <tom@tromey.com>
11033
11034         * infrun.c (displaced_step_clear_cleanup): Now a
11035         forward_scope_exit type.
11036         (displaced_step_prepare_throw): Update.
11037         (displaced_step_fixup): Update.
11038
11039 2019-03-06  Tom Tromey  <tom@tromey.com>
11040
11041         * inferior.h (class inferior): Update comment.
11042         * gdbthread.h (class thread_info): Update comment.
11043
11044 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11045             Tom Tromey  <tom@tromey.com>
11046
11047         * stabsread.h (struct stab_section_list): Remove.
11048         (coffstab_build_psymtabs): Update.
11049         * dbxread.c (symbuf_sections): Now a std::vector.
11050         (sect_idx): New global.
11051         (fill_symbuf): Update.
11052         (coffstab_build_psymtabs): Change type of stabsects parameter.
11053         Update.
11054         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11055         std::vector.
11056         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11057         (coff_locate_sections): Update.
11058         (coff_symfile_read): Remove cleanups.  Update.
11059         (init_stringtab): Add storage parameter.
11060         (free_stringtab, free_stringtab_cleanup): Remove.
11061         (init_lineno): Add storage parameter.
11062         (free_linetab, free_linetab_cleanup): Remove.
11063
11064 2019-03-06  Pedro Alves  <palves@redhat.com>
11065
11066         * linux-fork.c (fork_info::clobber_regs): Delete.
11067         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11068         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11069         comment.  Adjust.
11070         (scoped_switch_fork_info::scoped_switch_fork_info)
11071         (checkpoint_command, linux_fork_context): Adjust
11072         fork_save_infrun_state calls.
11073
11074 2019-03-06  Pedro Alves  <palves@redhat.com>
11075
11076         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11077         (inf_has_multiple_threads): Return 'bool' and rewrite using
11078         inferior_info::threads().
11079
11080 2019-03-06  Pedro Alves  <palves@redhat.com>
11081
11082         * linux-fork.c: Include <list>.
11083         (fork_list): Now a std::list instance.
11084         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11085         (forks_exist_p, find_last_fork): Adjust.
11086         (new_fork): Delete.
11087         (one_fork_p): New.
11088         (add_fork): Adjust.
11089         (free_fork): Delete, folded into fork_info::~fork_info().
11090         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11091         Adjust.
11092         (init_fork_list): Delete.
11093         (linux_fork_killall, linux_fork_mourn_inferior)
11094         (linux_fork_detach, info_checkpoints_command): Adjust.
11095         (_initialize_linux_fork): No longer call init_fork_list.
11096
11097 2019-03-06  Pedro Alves  <palves@redhat.com>
11098
11099         * linux-fork.c (new_fork): New, split out of ...
11100         (add_fork): ... this.  Return void.  Move "first fork" special
11101         case from here, to ...
11102         (checkpoint_command): ... here.
11103         * linux-linux.h (add_fork): Return void.
11104
11105 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11106
11107         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11108
11109 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11110             Chris January  <chris.january@arm.com>
11111             David Lecomber  <david.lecomber@arm.com>
11112
11113         * f-exp.y: New token, UNOP_INTRINSIC.
11114         (exp): New pattern using UNOP_INTRINSIC token.
11115         (f77_keywords): Add 'abs' keyword.
11116         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11117         (value_from_host_double): New function.
11118         (evaluate_subexp_f): Support UNOP_ABS.
11119
11120 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11121
11122         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11123         types.
11124
11125 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11126
11127         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11128         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11129         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11130
11131 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11132
11133         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11134
11135 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11136             Chris January  <chris.january@arm.com>
11137
11138         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11139         * f-exp.y: Define 'KIND' token.
11140         (exp): New pattern for KIND expressions.
11141         (ptype): Handle types with a kind extension.
11142         (direct_abs_decl): Extend to spot kind extensions.
11143         (f77_keywords): Add 'kind' to the list.
11144         (push_kind_type): New function.
11145         (convert_to_kind_type): New function.
11146         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11147         * parse.c (operator_length_standard): Likewise.
11148         * parser-defs.h (enum type_pieces): Add tp_kind.
11149         * std-operator.def: Add UNOP_KIND.
11150
11151 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11152
11153         * f-exp.y (f_parse): Set yydebug.
11154
11155 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11156
11157         * f-lang.c (evaluate_subexp_f): New function.
11158         (exp_descriptor_f): New global.
11159         (f_language_defn): Use exp_descriptor_f instead of
11160         exp_descriptor_standard.
11161
11162 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11163
11164         * f-exp.y (struct token): Add comments.
11165         (dot_ops): Remove uppercase versions and the end marker.
11166         (f77_keywords): Likewise.
11167         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11168         entries in the dot_ops array are case insensitive, and use
11169         strncasecmp to compare strings.  Also some whitespace cleanup in
11170         this area.  Similar for the f77_keywords array, except entries in
11171         this list might be case sensitive.
11172
11173 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11174
11175         * f-exp.y (struct f77_boolean_val): Add comments.
11176         (boolean_values): Remove uppercase versions, and end marker.
11177         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11178         and use strncasecmp to achieve case insensitivity.  Additionally,
11179         perform whitespace cleanup around this code.
11180
11181 2019-03-06  Tom Tromey  <tromey@adacore.com>
11182
11183         * remote-sim.c (gdbsim_target_open): Use result of
11184         gdb_argv::release.
11185
11186 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11187         Dirk Schubert  <dirk.schubert@arm.com>
11188         Chris January  <chris.january@arm.com>
11189
11190         * eval.c (evaluate_subexp_standard): Call Fortran argument
11191         wrapping logic.
11192         * f-lang.c (struct value): A value which can be passed into a
11193         Fortran function call.
11194         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11195         where appropriate.
11196         (struct type): Value ready for a Fortran function call.
11197         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11198         is needed.
11199         * f-lang.h (fortran_argument_convert): Declaration.
11200         (fortran_preserve_arg_pointer): Declaration.
11201         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11202
11203 2019-03-05  Tom Tromey  <tromey@adacore.com>
11204
11205         * python/py-prettyprint.c (print_string_repr): Remove #if.
11206         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11207
11208 2019-03-05  Tom Tromey  <tromey@adacore.com>
11209
11210         * target.c (the_dummy_target): Move later.  Change type to
11211         "dummy_target".
11212         (initialize_targets): Don't initialize the_dummy_target.
11213
11214 2019-03-05  Tom Tromey  <tromey@adacore.com>
11215
11216         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11217         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11218
11219 2019-03-05  Tom Tromey  <tromey@adacore.com>
11220
11221         * windows-nat.c (windows_nat_target::attach)
11222         (windows_nat_target::detach): Don't call gdb_flush.
11223         * valprint.c (generic_val_print, val_print, val_print_string):
11224         Don't call gdb_flush.
11225         * utils.c (defaulted_query): Don't call gdb_flush.
11226         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11227         * target.c (target_announce_detach): Don't call gdb_flush.
11228         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11229         * remote.c (extended_remote_target::attach): Don't call
11230         gdb_flush.
11231         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11232         * printcmd.c (do_examine): Don't call gdb_flush.
11233         (info_display_command): Don't call gdb_flush.
11234         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11235         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11236         * memattr.c (info_mem_command): Don't call gdb_flush.
11237         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11238         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11239         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11240         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11241         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11242         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11243         (gnu_nat_target::detach): Don't call gdb_flush.
11244         * f-valprint.c (f_val_print): Don't call gdb_flush.
11245         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11246         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11247         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11248         gdb_flush.
11249         * c-valprint.c (c_val_print): Don't call gdb_flush.
11250         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11251
11252 2019-03-05  Tom Tromey  <tromey@adacore.com>
11253
11254         * varobj.c (update_dynamic_varobj_children): Update.
11255         (install_default_visualizer): Use reset, not release.
11256         * value.c (set_internalvar): Update.
11257         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11258         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11259         ATTRIBUTE_UNUSED_RESULT.
11260
11261 2019-03-05  Tom Tromey  <tromey@adacore.com>
11262
11263         * remote.c (class scoped_remote_fd) <release>: Add
11264         ATTRIBUTE_UNUSED_RESULT.
11265
11266 2019-03-05  Tom Tromey  <tromey@adacore.com>
11267
11268         * macroexp.c (struct macro_buffer) <release>: Add
11269         ATTRIBUTE_UNUSED_RESULT.
11270
11271 2019-03-05  Tom Tromey  <tromey@adacore.com>
11272
11273         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11274         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11275         ATTRIBUTE_UNUSED_RESULT.
11276
11277 2019-03-05  Tom Tromey  <tromey@adacore.com>
11278
11279         * common/scoped_fd.h (class scoped_fd) <release>: Add
11280         ATTRIBUTE_UNUSED_RESULT.
11281
11282 2019-03-05  Tom Tromey  <tromey@adacore.com>
11283
11284         * parser-defs.h (struct parser_state) <release>: Add
11285         ATTRIBUTE_UNUSED_RESULT.
11286
11287 2019-03-05  Tom Tromey  <tromey@adacore.com>
11288
11289         * utils.h (class gdb_argv) <release>: Add
11290         ATTRIBUTE_UNUSED_RESULT.
11291         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11292
11293 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11294
11295         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11296         for-loop range, to avoid compiler warnings.
11297
11298         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11299         avoid compiler warnings about unused variables.
11300
11301         * NEWS: Mention end of support for native debugging on MS-Windows
11302         before XP.
11303
11304         PR gdb/24292
11305         * common/netstuff.c:
11306         * gdbserver/gdbreplay.c
11307         * gdbserver/remote-utils.c:
11308         * ser-tcp.c:
11309         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11310         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11311         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11312         'getaddrinfo' and 'freeaddrinfo' were not available before
11313         Windows XP, and mingw.org's MinGW headers by default define
11314         _WIN32_WINNT to 0x500.
11315
11316 2019-03-01  Gary Benson <gbenson@redhat.com>
11317
11318         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11319
11320 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11321             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11322
11323         PR gdb/8527
11324         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11325         set_sigint_trap, clear_sigint_trap.
11326
11327 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11328
11329         * target.c (target_detach): Clear the regcache and the
11330         frame cache.
11331
11332 2019-02-27  Pedro Alves  <palves@redhat.com>
11333
11334         * utils.c (set_screen_size): When we cap the height/width sizes,
11335         tweak the corresponding command variable to show "unlimited":
11336
11337 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11338             Pedro Alves  <palves@redhat.com>
11339
11340         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11341         before calling rl_set_screen_size.
11342
11343 2019-02-27  Tom Tromey  <tromey@adacore.com>
11344
11345         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11346         define.
11347         * python/py-value.c: Remove Python 2.4 workaround.
11348         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11349         workaround.
11350         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11351         Python 2.4 workaround.
11352         * python/python-internal.h: Remove Python 2.4 comment.
11353         (Py_ssize_t): Don't define.
11354         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11355         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11356         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11357         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11358         * python/python.c (do_start_initialization): Remove Python 2.4
11359         workaround.
11360         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11361         (print_children): Remove Python 2.4 workaround.
11362         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11363         workaround.
11364         (CHARBUFFERPROC_NAME): Remove.
11365         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11366         Python 2.4 workaround.
11367
11368 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11369
11370         * NEWS: Note minimum Python version.
11371
11372 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11373
11374         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11375         code from these functions.  Remove corresponding ifdefs.  Use
11376         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11377         Remove gotos and target of gotos.
11378         (infpy_search_memory): Likewise.
11379
11380 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11381
11382         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11383         (hppa_gdbarch_init): Don't register deleted functions with
11384         gdbarch.
11385
11386 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11387
11388         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11389         (h8300_unwind_sp): Delete.
11390         (h8300_dummy_id): Delete.
11391         (h8300_gdbarch_init): Don't register deleted functions with
11392         gdbarch.
11393
11394 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11395
11396         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11397         (ft32_unwind_pc): Delete.
11398         (ft32_unwind_sp): Delete.
11399         (ft32_gdbarch_init): Don't register deleted functions with
11400         gdbarch.
11401
11402 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11403
11404         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11405         (frv_unwind_pc): Delete.
11406         (frv_unwind_sp): Delete.
11407         (frv_gdbarch_init): Don't register deleted functions with
11408         gdbarch.
11409
11410 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11411
11412         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11413         (riscv_unwind_pc): Delete.
11414         (riscv_unwind_sp): Delete.
11415         (riscv_gdbarch_init): Don't register deleted functions with
11416         gdbarch.
11417
11418 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11419
11420         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11421         (csky_unwind_pc): Delete.
11422         (csky_unwind_sp): Delete.
11423         (csky_gdbarch_init): Don't register deleted functions with
11424         gdbarch.
11425
11426 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11427
11428         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11429         (cris_unwind_pc): Delete.
11430         (cris_unwind_sp): Delete.
11431         (cris_gdbarch_init): Don't register deleted functions with
11432         gdbarch.
11433
11434 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11435
11436         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11437         (bfin_unwind_pc): Delete.
11438         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11439
11440 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11441
11442         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11443         (arm_unwind_pc): Delete.
11444         (arm_unwind_sp): Delete.
11445         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11446
11447 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11448
11449         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11450         (arc_unwind_pc): Delete.
11451         (arc_unwind_sp): Delete.
11452         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11453
11454 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11455
11456         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11457         (alpha_unwind_pc): Delete.
11458         (alpha_gdbarch_init): Don't register deleted functions with
11459         gdbarch.
11460
11461 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11462
11463         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11464         (aarch64_unwind_pc): Delete.
11465         (aarch64_unwind_sp): Delete.
11466         (aarch64_gdbarch_init): Don't register deleted functions with
11467         gdbarch.
11468
11469 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11470
11471         * gdbtypes.c (type_align): Don't consider static members when
11472         computing structure alignment.
11473
11474 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11475
11476         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11477         return 0 for other types.
11478         * arch-utils.c (default_type_align): Always return 0.
11479         * gdbarch.h: Regenerate.
11480         * gdbarch.sh (type_align): Extend comment.
11481         * gdbtypes.c (type_align): Add additional comments, always call
11482         gdbarch_type_align before applying the default rules.
11483         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11484         generic code will then apply a suitable default.
11485         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11486         types, return 0 for other types.
11487
11488 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11489
11490         * NEWS: Create a new section for the next release branch.
11491         Rename the section of the current branch, now that it has
11492         been cut.
11493
11494 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11495
11496         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11497         * version.in: Bump version to 8.3.50.DATE-git.
11498
11499 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11500
11501         * aix-thread.c (ptid_cmp): Remove unused variable.
11502         (get_signaled_thread): Likewise.
11503         (store_regs_user_thread): Likewise.
11504         (store_regs_kernel_thread): Likewise.
11505         (fetch_regs_kernel_thread): Remove shadowed variable.
11506
11507 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11508
11509         * features/riscv/32bit-cpu.xml: Add register numbers.
11510         * features/riscv/32bit-fpu.c: Regenerate.
11511         * features/riscv/32bit-fpu.xml: Add register numbers.
11512         * features/riscv/64bit-cpu.xml: Add register numbers.
11513         * features/riscv/64bit-fpu.c: Regenerate.
11514         * features/riscv/64bit-fpu.xml: Add register numbers.
11515
11516 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11517
11518         * NEWS: Mention two argument form of gdb.Value constructor.
11519         * python/py-value.c (convert_buffer_and_type_to_value): New
11520         function.
11521         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11522         Add support for handling an optional second argument.  Call
11523         convert_buffer_and_type_to_value as appropriate.
11524         * python/python-internal.h (Py_buffer_deleter): New struct.
11525         (Py_buffer_up): New typedef.
11526
11527 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11528
11529         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11530         instead of releasing ownership.
11531
11532 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11533
11534         * dwarf2read.c (open_and_init_dwp_file): Call
11535         elf_numsections instead of bfd_count_sections to initialize
11536         dwp_file->num_sections.
11537
11538 2019-02-25  Tom Tromey  <tromey@adacore.com>
11539
11540         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11541
11542 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11543
11544         * gcore.in: Add '--readnever' option when invoking GDB.
11545
11546 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11547
11548         * MAINTAINERS: Update my email address.
11549
11550 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11551
11552         * build-id.c (build_id_to_debug_bfd_1): New function.
11553         (build_id_to_debug_bfd): Look for separate debug file in
11554         sysroot.
11555
11556 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11557
11558         * gdbarch.sh: Update the copyright year range that is placed into
11559         generated files.
11560
11561 2019-02-22  Keith Seitz  <keiths@redhat.com>
11562
11563         PR symtab/23853
11564         * linespec.c (create_sals_line_offset): Search for the default
11565         symtab's filename instead of its fullname.
11566
11567 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11568
11569         * NEWS: Update style defaults.
11570
11571 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11572
11573         * main.c (captured_main_1): Disable styling in batch mode.
11574
11575 2019-02-20  Tom Tromey  <tom@tromey.com>
11576
11577         * symtab.c (symtab_symbol_info): Fix typos.
11578
11579 2019-02-20  Tom Tromey  <tromey@adacore.com>
11580
11581         * findcmd.c (_initialize_mem_search): Use upper case for
11582         metasyntactic variables.
11583
11584 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11585
11586         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11587         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11588
11589 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11590
11591         * top.h (source_file_name): Change to std::string.
11592         * top.c (source_file_name): Likewise.
11593         (command_line_input): Adjust.
11594         * cli/cli-script.c (script_from_file): Adjust.
11595
11596 2019-02-19  Tom Tromey  <tromey@adacore.com>
11597
11598         * ravenscar-thread.c
11599         (ravenscar_thread_target::update_thread_list): Don't call
11600         ada_build_task_list.
11601         * ada-lang.h (ada_build_task_list): Don't declare.
11602         * ada-tasks.c (struct ada_tasks_inferior_data)
11603         <task_list_valid_p>: Now bool.
11604         (read_known_tasks, ada_task_list_changed)
11605         (ada_tasks_invalidate_inferior_data): Update.
11606         (read_known_tasks_array): Return bool.
11607         (read_known_tasks_list): Likewise.
11608         (read_known_tasks): Return void.
11609         (ada_build_task_list): Now static.
11610
11611 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11612
11613         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11614         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11615
11616 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11617
11618         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11619         variant for ada_tasks_pspace_data_handle and
11620         ada_tasks_inferior_data_handle.
11621         (ada_tasks_pspace_data_cleanup): New function.
11622         (ada_tasks_inferior_data_cleanup): New function.
11623
11624 2019-02-17  Tom Tromey  <tom@tromey.com>
11625
11626         * macrotab.h (macro_source_fullname): Return a std::string.
11627         * macrotab.c (macro_include, check_for_redefinition)
11628         (macro_undef, macro_lookup_definition, foreach_macro)
11629         (foreach_macro_in_scope): Update.
11630         (macro_source_fullname): Return a std::string.
11631         * macrocmd.c (show_pp_source_pos): Update.
11632
11633 2019-02-17  Tom Tromey  <tom@tromey.com>
11634
11635         * macrocmd.c (show_pp_source_pos): Style the file names.
11636
11637 2019-02-17  Tom Tromey  <tom@tromey.com>
11638
11639         PR tui/24197:
11640         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11641
11642 2019-02-17  Tom Tromey  <tom@tromey.com>
11643
11644         * ada-lang.c (user_select_syms): Use filtered printing.
11645         * utils.c (wrap_style): New global.
11646         (desired_style): Remove.
11647         (emit_style_escape): Add stream parameter.
11648         (set_output_style, reset_terminal_style, prompt_for_continue):
11649         Update.
11650         (flush_wrap_buffer): Only flush gdb_stdout.
11651         (wrap_here): Set wrap_style.
11652         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11653         treat escape sequences as a character.  Change when wrap buffer is
11654         flushed.
11655         (fputs_styled): Do not set the output style when the default is
11656         requested.
11657         * ui-style.h (struct ui_file_style) <is_default>: New method.
11658         * source.c (print_source_lines_base): Emit escape sequences in one
11659         piece.
11660
11661 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11662
11663         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11664         integers and enumeration types.
11665
11666 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11667
11668         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11669         instead of lookup_symbol_in_language
11670         (do_exact_match): New function.
11671         (ada_get_symbol_name_matcher): Return do_exact_match when
11672         doing a verbatim match.
11673
11674 2019-02-15  Tom Tromey  <tromey@adacore.com>
11675
11676         * ravenscar-thread.c (ravenscar_thread_target::resume)
11677         (ravenscar_thread_target::wait): Special case wildcard requests.
11678
11679 2019-02-15  Tom Tromey  <tromey@adacore.com>
11680
11681         * ravenscar-thread.c (base_ptid): Remove.
11682         (struct ravenscar_thread_target) <close>: New method.
11683         <m_base_ptid>: New member.
11684         <update_inferior_ptid, active_task, task_is_currently_active,
11685         runtime_initialized>: Declare methods.
11686         <ravenscar_thread_target>: Add constructor.
11687         (ravenscar_thread_target::task_is_currently_active)
11688         (ravenscar_thread_target::update_inferior_ptid)
11689         (ravenscar_runtime_initialized): Rename.  Now methods.
11690         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11691         (ravenscar_thread_target::update_thread_list): Update.
11692         (ravenscar_thread_target::active_task): Now method.
11693         (ravenscar_thread_target::store_registers)
11694         (ravenscar_thread_target::prepare_to_store)
11695         (ravenscar_thread_target::prepare_to_store)
11696         (ravenscar_thread_target::mourn_inferior): Update.
11697         (ravenscar_inferior_created): Use "new" to create target.
11698         (ravenscar_thread_target::get_ada_task_ptid): Update.
11699         (_initialize_ravenscar): Don't initialize base_ptid.
11700         (ravenscar_ops): Remove global.
11701
11702 2019-02-15  Tom Tromey  <tromey@adacore.com>
11703
11704         * target.h (push_target): Declare new overload.
11705         * target.c (push_target): New overload, taking an rvalue reference.
11706         * remote.c (remote_target::open_1): Use push_target overload.
11707         * corelow.c (core_target_open): Use push_target overload.
11708
11709 2019-02-15  Tom Tromey  <tromey@adacore.com>
11710
11711         * ravenscar-thread.c (is_ravenscar_task)
11712         (ravenscar_task_is_currently_active): Return bool.
11713         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11714         (_initialize_ravenscar): Remove "(void)".
11715         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11716         Return bool.
11717
11718 2019-02-15  Tom Tromey  <tromey@adacore.com>
11719
11720         * ravenscar-thread.c (ravenscar_runtime_initializer)
11721         (has_ravenscar_runtime, get_running_thread_id)
11722         (ravenscar_thread_target::resume): Fix indentation.
11723
11724 2019-02-15  Tom Tromey  <tromey@adacore.com>
11725
11726         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11727         from ravenscar_arch_ops.
11728         (sparc_ravenscar_ops::fetch_registers)
11729         (sparc_ravenscar_ops::store_registers): Now methods.
11730         (sparc_ravenscar_prepare_to_store): Remove.
11731         (sparc_ravenscar_ops): Redefine.
11732         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11733         methods and destructor.  Remove members.
11734         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11735         (ravenscar_thread_target::store_registers)
11736         (ravenscar_thread_target::prepare_to_store): Update.
11737         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11738         Remove.
11739         (struct ppc_ravenscar_powerpc_ops): Derive from
11740         ravenscar_arch_ops.
11741         (ppc_ravenscar_powerpc_ops::fetch_registers)
11742         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11743         (ppc_ravenscar_powerpc_ops): Redefine.
11744         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11745         (ppc_ravenscar_e500_ops::fetch_registers)
11746         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11747         (ppc_ravenscar_e500_ops): Redefine.
11748         * aarch64-ravenscar-thread.c
11749         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11750         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11751         (aarch64_ravenscar_fetch_registers)
11752         (aarch64_ravenscar_store_registers): Now methods.
11753         (aarch64_ravenscar_ops): Redefine.
11754
11755 2019-02-15  Tom Tromey  <tromey@adacore.com>
11756
11757         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11758         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11759         (ravenscar_thread_target::stopped_by_watchpoint)
11760         (ravenscar_thread_target::stopped_data_address)
11761         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11762
11763 2019-02-15  Tom Tromey  <tromey@adacore.com>
11764
11765         * ravenscar-thread.c: Fix some typos.
11766
11767 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11768             Tom Tromey  <tromey@adacore.com>
11769
11770         * ada-lang.c (ada_exception_sal): Change addr_string to a
11771         std::string.
11772         (create_ada_exception_catchpoint): Update.
11773
11774 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11775             Tom Tromey  <tromey@adacore.com>
11776
11777         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11778         (bp_location_ops): Remove.
11779         (base_breakpoint_allocate_location): Update.
11780         (free_bp_location): Update.
11781         * ada-lang.c (class ada_catchpoint_location)
11782         <ada_catchpoint_location>: Remove ops parameter.
11783         (ada_catchpoint_location_dtor): Remove.
11784         (ada_catchpoint_location_ops): Remove.
11785         (allocate_location_exception): Update.
11786         * breakpoint.h (struct bp_location_ops): Remove.
11787         (class bp_location) <bp_location>: Remove bp_location_ops
11788         parameter.
11789         <~bp_location>: Add destructor.
11790         <ops>: Remove.
11791
11792 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11793             Pedro Alves  <palves@redhat.com>
11794
11795         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11796         'PATH_MAX'.
11797
11798 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11799             Samuel Thibault  <samuel.thibault@gnu.org>
11800             Thomas Schwinge  <thomas@codesourcery.com>
11801
11802         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11803         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11804
11805 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11806
11807         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11808         (check_empty): Use "const char *".
11809
11810         * gnu-nat.c (gnu_nat_target::detach): Instead of
11811         'detach_inferior (pid)' call
11812         'detach_inferior (find_inferior_pid (pid))'.
11813
11814         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11815         'nat/fork-inferior.o'.
11816         * gnu-nat.c: #include "nat/fork-inferior.h".
11817
11818         * gnu-nat.c (gnu_nat_target::detach): Instead of
11819         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11820         * gnu-nat.h: #include "inf-child.h".
11821         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11822         'i386_gnu_nat_target::fetch_registers'.
11823         (gnu_store_registers): Rename/move to
11824         'i386_gnu_nat_target::store_registers'.
11825
11826         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11827         * gnu-nat.h (mach_thread_info): New function.
11828         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11829
11830         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11831
11832 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11833
11834         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11835
11836 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11837
11838         * windows-nat.c (windows_add_thread): Add new parameter
11839         "main_thread_p" with default value set to false.  Update
11840         function documentation as well as all callers.
11841         (windows_delete_thread): Likewise.
11842         (fake_create_process): Update call to windows_add_thread.
11843         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11844         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11845         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11846         call to windows_delete_thread.
11847
11848 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11849
11850         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11851
11852 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11853
11854         * symfile.c (find_separate_debug_file): Use canonical path of
11855         sysroot with child_path instead of gdb_sysroot if it is valid.
11856
11857 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11858
11859         * symfile.c (find_separate_debug_file): Use child_path to
11860         determine if an object file is under a sysroot.
11861
11862 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11863
11864         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11865         unittests/child-path-selftests.c.
11866         * common/pathstuff.c (child_path): New function.
11867         * common/pathstuff.h (child_path): New prototype.
11868         * unittests/child-path-selftests.c: New file.
11869
11870 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11871
11872         * symfile.c (find_separate_debug_file): Look for separate debug
11873         files in debug directories under the sysroot.
11874
11875 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11876
11877         * symtab.h (struct minimal_symbol data_p): New const method.
11878         (struct minimal_symbol text_p): Likewise.
11879         * symtab.c (output_source_filename): Use file name style
11880         to print file name.
11881         (print_symbol_info): Likewise.
11882         (print_msymbol_info): Use address style to print addresses.
11883         Use function name style to print executable text symbols.
11884         (expand_symtab_containing_pc): Use data_p.
11885         (find_pc_sect_compunit_symtab): Likewise.
11886
11887 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11888
11889         * breakpoint.c (describe_other_breakpoints): Use address style
11890         to print addresses.
11891         (say_where): Likewise.
11892
11893 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11894
11895         * ada-typeprint.c (print_func_type): Print function name
11896         style to print function name.
11897         * c-typeprint.c (c_print_type_1): Likewise.
11898
11899 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11900
11901         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11902         for execve.
11903
11904 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11905
11906         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11907         type_stack.
11908
11909 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11910
11911         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11912         TYPE_CODE_REF types.
11913
11914 2019-02-08  Jim Wilson  <jimw@sifive.com>
11915
11916         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11917         (riscv_linux_fregset): New.
11918         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11919
11920 2019-02-07  Tom Tromey  <tom@tromey.com>
11921
11922         * thread.c (thread_cancel_execution_command): Update.
11923         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11924         methods.
11925         (struct thread_fsm_ops): Remove.
11926         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11927         (thread_fsm_should_stop, thread_fsm_return_value)
11928         (thread_fsm_set_finished, thread_fsm_finished_p)
11929         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11930         Don't declare.
11931         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11932         * infrun.c (clear_proceed_status_thread)
11933         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11934         (print_stop_event): Update.
11935         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11936         Add constructor.
11937         (step_command_fsm_ops): Remove.
11938         (new_step_command_fsm): Remove.
11939         (step_1): Update.
11940         (step_command_fsm::should_stop): Rename from
11941         step_command_fsm_should_stop.
11942         (step_command_fsm::clean_up): Rename from
11943         step_command_fsm_clean_up.
11944         (step_command_fsm::do_async_reply_reason): Rename from
11945         step_command_fsm_async_reply_reason.
11946         (struct until_next_fsm): Inherit from thread_fsm.  Add
11947         constructor.
11948         (until_next_fsm_ops): Remove.
11949         (new_until_next_fsm): Remove.
11950         (until_next_fsm::should_stop): Rename from
11951         until_next_fsm_should_stop.
11952         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11953         (until_next_fsm::do_async_reply_reason): Rename from
11954         until_next_fsm_async_reply_reason.
11955         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11956         constructor.  Change type of breakpoint.
11957         (finish_command_fsm_ops): Remove.
11958         (new_finish_command_fsm): Remove.
11959         (finish_command_fsm::should_stop): Rename from
11960         finish_command_fsm_should_stop.
11961         (finish_command_fsm::clean_up): Rename from
11962         finish_command_fsm_clean_up.
11963         (finish_command_fsm::return_value): Rename from
11964         finish_command_fsm_return_value.
11965         (finish_command_fsm::do_async_reply_reason): Rename from
11966         finish_command_fsm_async_reply_reason.
11967         (finish_command): Update.
11968         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11969         Add constructor.
11970         (call_thread_fsm_ops): Remove.
11971         (call_thread_fsm::call_thread_fsm): Rename from
11972         new_call_thread_fsm.
11973         (call_thread_fsm::should_stop): Rename from
11974         call_thread_fsm_should_stop.
11975         (call_thread_fsm::should_notify_stop): Rename from
11976         call_thread_fsm_should_notify_stop.
11977         (run_inferior_call, call_function_by_hand_dummy): Update.
11978         * cli/cli-interp.c (should_print_stop_to_console): Update.
11979         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11980         Add constructor.  Change type of location_breakpoint,
11981         caller_breakpoint.
11982         (until_break_fsm_ops): Remove.
11983         (new_until_break_fsm): Remove.
11984         (until_break_fsm::should_stop): Rename from
11985         until_break_fsm_should_stop.
11986         (until_break_fsm::clean_up): Rename from
11987         until_break_fsm_clean_up.
11988         (until_break_fsm::do_async_reply_reason): Rename from
11989         until_break_fsm_async_reply_reason.
11990         (until_break_command): Update.
11991         * thread-fsm.c: Remove.
11992         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11993
11994 2019-02-07  Tom Tromey  <tom@tromey.com>
11995
11996         * yy-remap.h: Add include guard.
11997         * xtensa-tdep.h: Add include guard.
11998         * xcoffread.h: Rename include guard.
11999         * varobj-iter.h: Add include guard.
12000         * tui/tui.h: Rename include guard.
12001         * tui/tui-winsource.h: Rename include guard.
12002         * tui/tui-wingeneral.h: Rename include guard.
12003         * tui/tui-windata.h: Rename include guard.
12004         * tui/tui-win.h: Rename include guard.
12005         * tui/tui-stack.h: Rename include guard.
12006         * tui/tui-source.h: Rename include guard.
12007         * tui/tui-regs.h: Rename include guard.
12008         * tui/tui-out.h: Rename include guard.
12009         * tui/tui-layout.h: Rename include guard.
12010         * tui/tui-io.h: Rename include guard.
12011         * tui/tui-hooks.h: Rename include guard.
12012         * tui/tui-file.h: Rename include guard.
12013         * tui/tui-disasm.h: Rename include guard.
12014         * tui/tui-data.h: Rename include guard.
12015         * tui/tui-command.h: Rename include guard.
12016         * tic6x-tdep.h: Add include guard.
12017         * target/waitstatus.h: Rename include guard.
12018         * target/wait.h: Rename include guard.
12019         * target/target.h: Rename include guard.
12020         * target/resume.h: Rename include guard.
12021         * target-float.h: Rename include guard.
12022         * stabsread.h: Add include guard.
12023         * rs6000-tdep.h: Add include guard.
12024         * riscv-fbsd-tdep.h: Add include guard.
12025         * regformats/regdef.h: Rename include guard.
12026         * record.h: Rename include guard.
12027         * python/python.h: Rename include guard.
12028         * python/python-internal.h: Rename include guard.
12029         * python/py-stopevent.h: Rename include guard.
12030         * python/py-ref.h: Rename include guard.
12031         * python/py-record.h: Rename include guard.
12032         * python/py-record-full.h: Rename include guard.
12033         * python/py-record-btrace.h: Rename include guard.
12034         * python/py-instruction.h: Rename include guard.
12035         * python/py-events.h: Rename include guard.
12036         * python/py-event.h: Rename include guard.
12037         * procfs.h: Add include guard.
12038         * proc-utils.h: Add include guard.
12039         * p-lang.h: Add include guard.
12040         * or1k-tdep.h: Rename include guard.
12041         * observable.h: Rename include guard.
12042         * nto-tdep.h: Rename include guard.
12043         * nat/x86-linux.h: Rename include guard.
12044         * nat/x86-linux-dregs.h: Rename include guard.
12045         * nat/x86-gcc-cpuid.h: Add include guard.
12046         * nat/x86-dregs.h: Rename include guard.
12047         * nat/x86-cpuid.h: Rename include guard.
12048         * nat/ppc-linux.h: Rename include guard.
12049         * nat/mips-linux-watch.h: Rename include guard.
12050         * nat/linux-waitpid.h: Rename include guard.
12051         * nat/linux-ptrace.h: Rename include guard.
12052         * nat/linux-procfs.h: Rename include guard.
12053         * nat/linux-osdata.h: Rename include guard.
12054         * nat/linux-nat.h: Rename include guard.
12055         * nat/linux-namespaces.h: Rename include guard.
12056         * nat/linux-btrace.h: Rename include guard.
12057         * nat/glibc_thread_db.h: Rename include guard.
12058         * nat/gdb_thread_db.h: Rename include guard.
12059         * nat/gdb_ptrace.h: Rename include guard.
12060         * nat/fork-inferior.h: Rename include guard.
12061         * nat/amd64-linux-siginfo.h: Rename include guard.
12062         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12063         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12064         * nat/aarch64-linux.h: Rename include guard.
12065         * nat/aarch64-linux-hw-point.h: Rename include guard.
12066         * mn10300-tdep.h: Add include guard.
12067         * mips-linux-tdep.h: Add include guard.
12068         * mi/mi-parse.h: Rename include guard.
12069         * mi/mi-out.h: Rename include guard.
12070         * mi/mi-main.h: Rename include guard.
12071         * mi/mi-interp.h: Rename include guard.
12072         * mi/mi-getopt.h: Rename include guard.
12073         * mi/mi-console.h: Rename include guard.
12074         * mi/mi-common.h: Rename include guard.
12075         * mi/mi-cmds.h: Rename include guard.
12076         * mi/mi-cmd-break.h: Rename include guard.
12077         * m2-lang.h: Add include guard.
12078         * location.h: Rename include guard.
12079         * linux-record.h: Rename include guard.
12080         * linux-nat.h: Add include guard.
12081         * linux-fork.h: Add include guard.
12082         * i386-darwin-tdep.h: Rename include guard.
12083         * hppa-linux-offsets.h: Add include guard.
12084         * guile/guile.h: Rename include guard.
12085         * guile/guile-internal.h: Rename include guard.
12086         * gnu-nat.h: Rename include guard.
12087         * gdb-stabs.h: Rename include guard.
12088         * frv-tdep.h: Add include guard.
12089         * f-lang.h: Add include guard.
12090         * event-loop.h: Add include guard.
12091         * darwin-nat.h: Rename include guard.
12092         * cp-abi.h: Rename include guard.
12093         * config/sparc/nm-sol2.h: Rename include guard.
12094         * config/nm-nto.h: Rename include guard.
12095         * config/nm-linux.h: Add include guard.
12096         * config/i386/nm-i386gnu.h: Rename include guard.
12097         * config/djgpp/nl_types.h: Rename include guard.
12098         * config/djgpp/langinfo.h: Rename include guard.
12099         * compile/gcc-cp-plugin.h: Add include guard.
12100         * compile/gcc-c-plugin.h: Add include guard.
12101         * compile/compile.h: Rename include guard.
12102         * compile/compile-object-run.h: Rename include guard.
12103         * compile/compile-object-load.h: Rename include guard.
12104         * compile/compile-internal.h: Rename include guard.
12105         * compile/compile-cplus.h: Rename include guard.
12106         * compile/compile-c.h: Rename include guard.
12107         * common/xml-utils.h: Rename include guard.
12108         * common/x86-xstate.h: Rename include guard.
12109         * common/version.h: Rename include guard.
12110         * common/vec.h: Rename include guard.
12111         * common/tdesc.h: Rename include guard.
12112         * common/selftest.h: Rename include guard.
12113         * common/scoped_restore.h: Rename include guard.
12114         * common/scoped_mmap.h: Rename include guard.
12115         * common/scoped_fd.h: Rename include guard.
12116         * common/safe-iterator.h: Rename include guard.
12117         * common/run-time-clock.h: Rename include guard.
12118         * common/refcounted-object.h: Rename include guard.
12119         * common/queue.h: Rename include guard.
12120         * common/ptid.h: Rename include guard.
12121         * common/print-utils.h: Rename include guard.
12122         * common/preprocessor.h: Rename include guard.
12123         * common/pathstuff.h: Rename include guard.
12124         * common/observable.h: Rename include guard.
12125         * common/netstuff.h: Rename include guard.
12126         * common/job-control.h: Rename include guard.
12127         * common/host-defs.h: Rename include guard.
12128         * common/gdb_wait.h: Rename include guard.
12129         * common/gdb_vecs.h: Rename include guard.
12130         * common/gdb_unlinker.h: Rename include guard.
12131         * common/gdb_unique_ptr.h: Rename include guard.
12132         * common/gdb_tilde_expand.h: Rename include guard.
12133         * common/gdb_sys_time.h: Rename include guard.
12134         * common/gdb_string_view.h: Rename include guard.
12135         * common/gdb_splay_tree.h: Rename include guard.
12136         * common/gdb_setjmp.h: Rename include guard.
12137         * common/gdb_ref_ptr.h: Rename include guard.
12138         * common/gdb_optional.h: Rename include guard.
12139         * common/gdb_locale.h: Rename include guard.
12140         * common/gdb_assert.h: Rename include guard.
12141         * common/filtered-iterator.h: Rename include guard.
12142         * common/filestuff.h: Rename include guard.
12143         * common/fileio.h: Rename include guard.
12144         * common/environ.h: Rename include guard.
12145         * common/common-utils.h: Rename include guard.
12146         * common/common-types.h: Rename include guard.
12147         * common/common-regcache.h: Rename include guard.
12148         * common/common-inferior.h: Rename include guard.
12149         * common/common-gdbthread.h: Rename include guard.
12150         * common/common-exceptions.h: Rename include guard.
12151         * common/common-defs.h: Rename include guard.
12152         * common/common-debug.h: Rename include guard.
12153         * common/cleanups.h: Rename include guard.
12154         * common/buffer.h: Rename include guard.
12155         * common/btrace-common.h: Rename include guard.
12156         * common/break-common.h: Rename include guard.
12157         * cli/cli-utils.h: Rename include guard.
12158         * cli/cli-style.h: Rename include guard.
12159         * cli/cli-setshow.h: Rename include guard.
12160         * cli/cli-script.h: Rename include guard.
12161         * cli/cli-interp.h: Rename include guard.
12162         * cli/cli-decode.h: Rename include guard.
12163         * cli/cli-cmds.h: Rename include guard.
12164         * charset-list.h: Add include guard.
12165         * buildsym-legacy.h: Rename include guard.
12166         * bfin-tdep.h: Add include guard.
12167         * ax.h: Rename include guard.
12168         * arm-linux-tdep.h: Add include guard.
12169         * arm-fbsd-tdep.h: Add include guard.
12170         * arch/xtensa.h: Rename include guard.
12171         * arch/tic6x.h: Add include guard.
12172         * arch/i386.h: Add include guard.
12173         * arch/arm.h: Rename include guard.
12174         * arch/arm-linux.h: Rename include guard.
12175         * arch/arm-get-next-pcs.h: Rename include guard.
12176         * arch/amd64.h: Add include guard.
12177         * arch/aarch64-insn.h: Rename include guard.
12178         * arch-utils.h: Rename include guard.
12179         * annotate.h: Add include guard.
12180         * amd64-darwin-tdep.h: Rename include guard.
12181         * aarch64-linux-tdep.h: Add include guard.
12182         * aarch64-fbsd-tdep.h: Add include guard.
12183         * aarch32-linux-nat.h: Add include guard.
12184
12185 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12186
12187         * macrotab.c (macro_define_internal): New function that
12188         factorizes macro_define_object_internal and macro_define_function
12189         code.
12190         (macro_define_object_internal): Use macro_define_internal.
12191         (macro_define_function): Likewise.
12192
12193 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12194
12195         * macrocmd.c (extract_identifier): Return
12196         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12197         callers.
12198
12199 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12200
12201         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12202
12203 2019-02-05  Tom Tromey  <tom@tromey.com>
12204
12205         * target.c (target_stack::unpush): Move assertion earlier.
12206
12207 2019-01-30  Tom Tromey  <tom@tromey.com>
12208
12209         PR python/23615:
12210         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12211         (gdbpy_parse_and_eval): Likewise.
12212         * python/python-internal.h (gdbpy_allow_threads): New class.
12213
12214 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12215
12216         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12217         (aarch64_fbsd_fpregmap): Move earlier.
12218         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12219         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12220         instead of individual calls to trad_frame_set_reg_addr.
12221         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12222         earlier.
12223         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12224         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12225         instead of individual calls to trad_frame_set_reg_addr.
12226
12227 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12228
12229         * CONTRIBUTE: Replace contribution list with wiki link.
12230
12231 2019-01-25  Tom Tromey  <tom@tromey.com>
12232
12233         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12234
12235 2019-01-25  Tom Tromey  <tom@tromey.com>
12236
12237         * xtensa-linux-nat.c: Fix common/ includes.
12238         * xml-support.h: Fix common/ includes.
12239         * xml-support.c: Fix common/ includes.
12240         * x86-linux-nat.c: Fix common/ includes.
12241         * windows-nat.c: Fix common/ includes.
12242         * varobj.h: Fix common/ includes.
12243         * varobj.c: Fix common/ includes.
12244         * value.c: Fix common/ includes.
12245         * valops.c: Fix common/ includes.
12246         * utils.c: Fix common/ includes.
12247         * unittests/xml-utils-selftests.c: Fix common/ includes.
12248         * unittests/utils-selftests.c: Fix common/ includes.
12249         * unittests/unpack-selftests.c: Fix common/ includes.
12250         * unittests/tracepoint-selftests.c: Fix common/ includes.
12251         * unittests/style-selftests.c: Fix common/ includes.
12252         * unittests/string_view-selftests.c: Fix common/ includes.
12253         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12254         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12255         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12256         * unittests/rsp-low-selftests.c: Fix common/ includes.
12257         * unittests/parse-connection-spec-selftests.c: Fix common/
12258         includes.
12259         * unittests/optional-selftests.c: Fix common/ includes.
12260         * unittests/offset-type-selftests.c: Fix common/ includes.
12261         * unittests/observable-selftests.c: Fix common/ includes.
12262         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12263         * unittests/memrange-selftests.c: Fix common/ includes.
12264         * unittests/memory-map-selftests.c: Fix common/ includes.
12265         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12266         * unittests/function-view-selftests.c: Fix common/ includes.
12267         * unittests/environ-selftests.c: Fix common/ includes.
12268         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12269         * unittests/common-utils-selftests.c: Fix common/ includes.
12270         * unittests/cli-utils-selftests.c: Fix common/ includes.
12271         * unittests/array-view-selftests.c: Fix common/ includes.
12272         * ui-file.c: Fix common/ includes.
12273         * tui/tui-io.c: Fix common/ includes.
12274         * tracepoint.h: Fix common/ includes.
12275         * tracepoint.c: Fix common/ includes.
12276         * tracefile-tfile.c: Fix common/ includes.
12277         * top.h: Fix common/ includes.
12278         * top.c: Fix common/ includes.
12279         * thread.c: Fix common/ includes.
12280         * target/waitstatus.h: Fix common/ includes.
12281         * target/waitstatus.c: Fix common/ includes.
12282         * target.h: Fix common/ includes.
12283         * target.c: Fix common/ includes.
12284         * target-memory.c: Fix common/ includes.
12285         * target-descriptions.c: Fix common/ includes.
12286         * symtab.h: Fix common/ includes.
12287         * symfile.c: Fix common/ includes.
12288         * stap-probe.c: Fix common/ includes.
12289         * spu-linux-nat.c: Fix common/ includes.
12290         * sparc-nat.c: Fix common/ includes.
12291         * source.c: Fix common/ includes.
12292         * solib.c: Fix common/ includes.
12293         * solib-target.c: Fix common/ includes.
12294         * ser-unix.c: Fix common/ includes.
12295         * ser-tcp.c: Fix common/ includes.
12296         * ser-pipe.c: Fix common/ includes.
12297         * ser-base.c: Fix common/ includes.
12298         * selftest-arch.c: Fix common/ includes.
12299         * s12z-tdep.c: Fix common/ includes.
12300         * rust-exp.y: Fix common/ includes.
12301         * rs6000-aix-tdep.c: Fix common/ includes.
12302         * riscv-tdep.c: Fix common/ includes.
12303         * remote.c: Fix common/ includes.
12304         * remote-notif.h: Fix common/ includes.
12305         * remote-fileio.h: Fix common/ includes.
12306         * remote-fileio.c: Fix common/ includes.
12307         * regcache.h: Fix common/ includes.
12308         * regcache.c: Fix common/ includes.
12309         * record-btrace.c: Fix common/ includes.
12310         * python/python.c: Fix common/ includes.
12311         * python/py-type.c: Fix common/ includes.
12312         * python/py-inferior.c: Fix common/ includes.
12313         * progspace.h: Fix common/ includes.
12314         * producer.c: Fix common/ includes.
12315         * procfs.c: Fix common/ includes.
12316         * proc-api.c: Fix common/ includes.
12317         * printcmd.c: Fix common/ includes.
12318         * ppc-linux-nat.c: Fix common/ includes.
12319         * parser-defs.h: Fix common/ includes.
12320         * osdata.c: Fix common/ includes.
12321         * obsd-nat.c: Fix common/ includes.
12322         * nat/x86-linux.c: Fix common/ includes.
12323         * nat/x86-linux-dregs.c: Fix common/ includes.
12324         * nat/x86-dregs.h: Fix common/ includes.
12325         * nat/x86-dregs.c: Fix common/ includes.
12326         * nat/ppc-linux.c: Fix common/ includes.
12327         * nat/mips-linux-watch.h: Fix common/ includes.
12328         * nat/mips-linux-watch.c: Fix common/ includes.
12329         * nat/linux-waitpid.c: Fix common/ includes.
12330         * nat/linux-ptrace.h: Fix common/ includes.
12331         * nat/linux-ptrace.c: Fix common/ includes.
12332         * nat/linux-procfs.c: Fix common/ includes.
12333         * nat/linux-personality.c: Fix common/ includes.
12334         * nat/linux-osdata.c: Fix common/ includes.
12335         * nat/linux-namespaces.c: Fix common/ includes.
12336         * nat/linux-btrace.h: Fix common/ includes.
12337         * nat/linux-btrace.c: Fix common/ includes.
12338         * nat/fork-inferior.c: Fix common/ includes.
12339         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12340         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12341         * nat/aarch64-linux.c: Fix common/ includes.
12342         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12343         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12344         * namespace.h: Fix common/ includes.
12345         * mips-linux-tdep.c: Fix common/ includes.
12346         * minsyms.c: Fix common/ includes.
12347         * mi/mi-parse.h: Fix common/ includes.
12348         * mi/mi-main.c: Fix common/ includes.
12349         * mi/mi-cmd-env.c: Fix common/ includes.
12350         * memrange.h: Fix common/ includes.
12351         * memattr.c: Fix common/ includes.
12352         * maint.h: Fix common/ includes.
12353         * maint.c: Fix common/ includes.
12354         * main.c: Fix common/ includes.
12355         * machoread.c: Fix common/ includes.
12356         * location.c: Fix common/ includes.
12357         * linux-thread-db.c: Fix common/ includes.
12358         * linux-nat.c: Fix common/ includes.
12359         * linux-fork.c: Fix common/ includes.
12360         * inline-frame.c: Fix common/ includes.
12361         * infrun.c: Fix common/ includes.
12362         * inflow.c: Fix common/ includes.
12363         * inferior.h: Fix common/ includes.
12364         * inferior.c: Fix common/ includes.
12365         * infcmd.c: Fix common/ includes.
12366         * inf-ptrace.c: Fix common/ includes.
12367         * inf-child.c: Fix common/ includes.
12368         * ia64-linux-nat.c: Fix common/ includes.
12369         * i387-tdep.c: Fix common/ includes.
12370         * i386-tdep.c: Fix common/ includes.
12371         * i386-linux-tdep.c: Fix common/ includes.
12372         * i386-linux-nat.c: Fix common/ includes.
12373         * i386-go32-tdep.c: Fix common/ includes.
12374         * i386-fbsd-tdep.c: Fix common/ includes.
12375         * i386-fbsd-nat.c: Fix common/ includes.
12376         * guile/scm-type.c: Fix common/ includes.
12377         * guile/guile.c: Fix common/ includes.
12378         * go32-nat.c: Fix common/ includes.
12379         * gnu-nat.c: Fix common/ includes.
12380         * gdbthread.h: Fix common/ includes.
12381         * gdbarch-selftests.c: Fix common/ includes.
12382         * gdb_usleep.c: Fix common/ includes.
12383         * gdb_select.h: Fix common/ includes.
12384         * gdb_bfd.c: Fix common/ includes.
12385         * gcore.c: Fix common/ includes.
12386         * fork-child.c: Fix common/ includes.
12387         * findvar.c: Fix common/ includes.
12388         * fbsd-nat.c: Fix common/ includes.
12389         * event-top.c: Fix common/ includes.
12390         * event-loop.c: Fix common/ includes.
12391         * dwarf2read.c: Fix common/ includes.
12392         * dwarf2loc.c: Fix common/ includes.
12393         * dwarf2-frame.c: Fix common/ includes.
12394         * dwarf-index-cache.c: Fix common/ includes.
12395         * dtrace-probe.c: Fix common/ includes.
12396         * disasm-selftests.c: Fix common/ includes.
12397         * defs.h: Fix common/ includes.
12398         * csky-tdep.c: Fix common/ includes.
12399         * cp-valprint.c: Fix common/ includes.
12400         * cp-support.h: Fix common/ includes.
12401         * cp-support.c: Fix common/ includes.
12402         * corelow.c: Fix common/ includes.
12403         * completer.h: Fix common/ includes.
12404         * completer.c: Fix common/ includes.
12405         * compile/compile.c: Fix common/ includes.
12406         * compile/compile-loc2c.c: Fix common/ includes.
12407         * compile/compile-cplus-types.c: Fix common/ includes.
12408         * compile/compile-cplus-symbols.c: Fix common/ includes.
12409         * command.h: Fix common/ includes.
12410         * cli/cli-dump.c: Fix common/ includes.
12411         * cli/cli-cmds.c: Fix common/ includes.
12412         * charset.c: Fix common/ includes.
12413         * build-id.c: Fix common/ includes.
12414         * btrace.h: Fix common/ includes.
12415         * btrace.c: Fix common/ includes.
12416         * breakpoint.h: Fix common/ includes.
12417         * breakpoint.c: Fix common/ includes.
12418         * ax.h:
12419         (enum agent_op): Fix common/ includes.
12420         * ax-general.c (struct aop_map): Fix common/ includes.
12421         * ax-gdb.c: Fix common/ includes.
12422         * auxv.c: Fix common/ includes.
12423         * auto-load.c: Fix common/ includes.
12424         * arm-tdep.c: Fix common/ includes.
12425         * arch/riscv.c: Fix common/ includes.
12426         * arch/ppc-linux-common.c: Fix common/ includes.
12427         * arch/i386.c: Fix common/ includes.
12428         * arch/arm.c: Fix common/ includes.
12429         * arch/arm-linux.c: Fix common/ includes.
12430         * arch/arm-get-next-pcs.c: Fix common/ includes.
12431         * arch/amd64.c: Fix common/ includes.
12432         * arch/aarch64.c: Fix common/ includes.
12433         * arch/aarch64-insn.c: Fix common/ includes.
12434         * arch-utils.c: Fix common/ includes.
12435         * amd64-windows-tdep.c: Fix common/ includes.
12436         * amd64-tdep.c: Fix common/ includes.
12437         * amd64-sol2-tdep.c: Fix common/ includes.
12438         * amd64-obsd-tdep.c: Fix common/ includes.
12439         * amd64-nbsd-tdep.c: Fix common/ includes.
12440         * amd64-linux-tdep.c: Fix common/ includes.
12441         * amd64-linux-nat.c: Fix common/ includes.
12442         * amd64-fbsd-tdep.c: Fix common/ includes.
12443         * amd64-fbsd-nat.c: Fix common/ includes.
12444         * amd64-dicos-tdep.c: Fix common/ includes.
12445         * amd64-darwin-tdep.c: Fix common/ includes.
12446         * agent.c: Fix common/ includes.
12447         * ada-lang.h: Fix common/ includes.
12448         * ada-lang.c: Fix common/ includes.
12449         * aarch64-tdep.c: Fix common/ includes.
12450
12451 2019-01-25  Tom Tromey  <tom@tromey.com>
12452
12453         * common/create-version.sh: Use common/version.h.
12454
12455 2019-01-24  Pedro Alves  <palves@redhat.com>
12456
12457         * infrun.c (signal_stop, signal_print, signal_program)
12458         (signal_catch, signal_pass): Now arrays instead of pointers.
12459         (update_signals_program_target, do_target_resume)
12460         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12461         * linux-nat.c (linux_nat_target::pass_signals)
12462         (linux_nat_target::create_inferior, linux_nat_target::attach):
12463         Adjust.
12464         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12465         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12466         * procfs.c (procfs_target::pass_signals): Adjust.
12467         * record-full.c (record_full_target::resume): Adjust.
12468         * remote.c (remote_target::pass_signals)
12469         (remote_target::program_signals): Adjust.
12470         * target-debug.h (target_debug_print_signals): Now takes a
12471         gdb::array_view as parameter.  Adjust.
12472         * target.h (target_ops) <pass_signals, program_signals>: Replace
12473         pointer and length parameters with gdb::array_view.
12474         (target_pass_signals, target_program_signals): Likewise.
12475         * target-delegates.c: Regenerate.
12476
12477 2019-01-24  Pedro Alves  <palves@redhat.com>
12478
12479         * common/forward-scope-exit.h
12480         (forward_scope_exit::forward_scope_exit): Pass arguments to
12481         m_bind_function directly, instead of creating a std::bind and
12482         copying that.
12483
12484 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12485
12486         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12487         for static members.
12488         (pass_in_v_vfp_candidate): Likewise.
12489
12490 2019-01-23  Tom Tromey  <tom@tromey.com>
12491             Pedro Alves  <palves@redhat.com>
12492
12493         * regcache.c (class regcache_invalidator): Remove.
12494         (regcache::raw_write): Use make_scope_exit.
12495
12496 2019-01-23  Tom Tromey  <tom@tromey.com>
12497
12498         * ui-out.h (class ui_out_emit_type): Update comment.
12499
12500 2019-01-23  Tom Tromey  <tom@tromey.com>
12501
12502         * infrun.c (fetch_inferior_event): Update comment.
12503
12504 2019-01-23  Tom Tromey  <tom@tromey.com>
12505             Pedro Alves  <palves@redhat.com>
12506
12507         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12508         parameter.
12509         (fetch_inferior_event): Use SCOPE_EXIT.
12510
12511
12512 2019-01-23  Tom Tromey  <tom@tromey.com>
12513             Pedro Alves  <palves@redhat.com>
12514
12515         * infrun.c (disable_thread_events): Delete.
12516         (stop_all_threads): Use SCOPE_EXIT.
12517
12518 2019-01-23  Tom Tromey  <tom@tromey.com>
12519             Pedro Alves  <palves@redhat.com>
12520
12521         * symfile.c: Include forward-scope-exit.h.
12522         (clear_symtab_users_cleanup): Replace forward declaration with
12523         a FORWARD_SCOPE_EXIT.
12524         (syms_from_objfile_1): Use the forward_scope_exit and
12525         gdb::optional instead of cleanup_function.
12526         (reread_symbols): Use the forward_scope_exit instead of
12527         cleanup_function.
12528         (clear_symtab_users_cleanup): Remove function.
12529
12530 2019-01-23  Tom Tromey  <tom@tromey.com>
12531             Pedro Alves  <palves@redhat.com>
12532
12533         * linux-nat.c: Include scope-exit.h.
12534         (cleanup_target_stop): Remove.
12535         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12536         SCOPE_EXIT.
12537
12538 2019-01-23  Tom Tromey  <tom@tromey.com>
12539             Pedro Alves  <palves@redhat.com>
12540
12541         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12542         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12543
12544 2019-01-23  Tom Tromey  <tom@tromey.com>
12545             Andrew Burgess  <andrew.burgess@embecosm.com>
12546             Pedro Alves  <palves@redhat.com>
12547
12548         * infrun.c (fetch_inferior_event): Use scope_exit.
12549         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12550         * top.c (execute_command): Use scope_exit.
12551         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12552         * utils.c (do_bpstat_clear_actions_cleanup)
12553         (make_bpstat_clear_actions_cleanup): Remove.
12554
12555 2019-01-23  Tom Tromey  <tom@tromey.com>
12556             Pedro Alves  <palves@redhat.com>
12557
12558         * infrun.c: Include "common/scope-exit.h"
12559         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12560         (wait_for_inferior): Use SCOPE_EXIT.
12561         (fetch_inferior_event): Use scope_exit.
12562
12563 2019-01-23  Tom Tromey  <tom@tromey.com>
12564             Pedro Alves  <palves@redhat.com>
12565
12566         * breakpoint.c (create_breakpoint): Remove cleanup.
12567
12568 2019-01-23  Tom Tromey  <tom@tromey.com>
12569             Andrew Burgess  <andrew.burgess@embecosm.com>
12570             Pedro Alves  <palves@redhat.com>
12571
12572 2019-01-23  Pedro Alves  <palves@redhat.com>
12573
12574         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12575
12576 2019-01-23  Pedro Alves  <palves@redhat.com>
12577             Andrew Burgess  <andrew.burgess@embecosm.com>
12578
12579         * gdbthread.h: Include "common/forward-scope-exit.h".
12580         (scoped_finish_thread_state): Redefine custom class in terms of
12581         forward_scope_exit.
12582
12583 2019-01-23  Pedro Alves  <palves@redhat.com>
12584             Andrew Burgess  <andrew.burgess@embecosm.com>
12585
12586         * common/forward-scope-exit.h: New file.
12587
12588 2019-01-23  Pedro Alves  <palves@redhat.com>
12589             Andrew Burgess  <andrew.burgess@embecosm.com>
12590             Tom Tromey  <tom@tromey.com>
12591
12592         * common/scope-exit.h: New file.
12593
12594 2019-01-23  Pedro Alves  <palves@redhat.com>
12595
12596         * common/preprocessor.h (ESC): Rename to ...
12597         (ESC_PARENS): ... this.
12598         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12599         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12600
12601 2019-01-23  Tom Tromey  <tom@tromey.com>
12602
12603         * language.h (class scoped_switch_to_sym_language_if_auto):
12604         Initialize m_lang in both cases.
12605
12606 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12607
12608         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12609         with XCNEW.
12610
12611 2019-01-22  Tom Tromey  <tom@tromey.com>
12612
12613         * corelow.c: Do not include sys/file.h.
12614
12615 2019-01-22  Tom Tromey  <tom@tromey.com>
12616
12617         * tui/tui-wingeneral.h: Include gdb_curses.h.
12618
12619 2019-01-22  Tom Tromey  <tom@tromey.com>
12620
12621         * source-cache.h (class source_cache) <get_source_lines,
12622         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12623
12624 2019-01-22  Tom Tromey  <tom@tromey.com>
12625
12626         * remote-fileio.h (struct remote_target): Declare.
12627
12628 2019-01-22  Tom Tromey  <tom@tromey.com>
12629
12630         * python/py-arch.c: Do not include py-ref.h.
12631         * python/py-bpevent.c: Do not include py-ref.h.
12632         * python/py-cmd.c: Do not include py-ref.h.
12633         * python/py-continueevent.c: Do not include py-ref.h.
12634         * python/py-event.h: Do not include py-ref.h.
12635         * python/py-evtregistry.c: Do not include py-ref.h.
12636         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12637         * python/py-frame.c: Do not include py-ref.h.
12638         * python/py-framefilter.c: Do not include py-ref.h.
12639         * python/py-function.c: Do not include py-ref.h.
12640         * python/py-infevents.c: Do not include py-ref.h.
12641         * python/py-linetable.c: Do not include py-ref.h.
12642         * python/py-objfile.c: Do not include py-ref.h.
12643         * python/py-param.c: Do not include py-ref.h.
12644         * python/py-prettyprint.c: Do not include py-ref.h.
12645         * python/py-progspace.c: Do not include py-ref.h.
12646         * python/py-symbol.c: Do not include py-ref.h.
12647         * python/py-symtab.c: Do not include py-ref.h.
12648         * python/py-type.c: Do not include py-ref.h.
12649         * python/py-unwind.c: Do not include py-ref.h.
12650         * python/py-utils.c: Do not include py-ref.h.
12651         * python/py-value.c: Do not include py-ref.h.
12652         * python/py-varobj.c: Do not include py-ref.h.
12653         * python/py-xmethods.c: Do not include py-ref.h.
12654         * python/python.c: Do not include py-ref.h.
12655         * varobj.c: Do not include py-ref.h.
12656
12657 2019-01-22  Tom Tromey  <tom@tromey.com>
12658
12659         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12660         keyword for bcache.
12661
12662 2019-01-22  Tom Tromey  <tom@tromey.com>
12663
12664         * compile/compile-cplus-types.c: Remove a comment by #include.
12665
12666 2019-01-22  Tom Tromey  <tom@tromey.com>
12667
12668         * compile/gcc-c-plugin.h: Include compile-internal.h.
12669
12670 2019-01-22  Tom Tromey  <tom@tromey.com>
12671
12672         * stabsread.c (EXTERN): Do not define.
12673         (symnum, next_symbol_text_func, processing_gcc_compilation)
12674         (within_function, global_sym_chain, global_stabs)
12675         (previous_stab_code, this_object_header_files)
12676         (n_this_object_header_files)
12677         (n_allocated_this_object_header_files): Define.
12678         * stabsread.h (EXTERN): Never define.  Use "extern".
12679
12680 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12681
12682         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12683         history_value.
12684
12685 2019-01-21  Tom Tromey  <tom@tromey.com>
12686
12687         * ui-out.c: Fix includes.
12688         * tui/tui-source.c: Fix includes.
12689         * target.c: Fix includes.
12690         * remote.c: Fix includes.
12691         * regcache.c: Fix includes.
12692         * python/py-block.c: Fix includes.
12693         * printcmd.c: Fix includes.
12694         * or1k-tdep.c: Fix includes.
12695         * mi/mi-main.c: Fix includes.
12696         * m32r-tdep.c: Fix includes.
12697         * csky-tdep.c: Fix includes.
12698         * compile/compile-cplus-types.c: Fix includes.
12699         * cli/cli-interp.c: Fix includes.
12700
12701 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12702
12703         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12704         for padding.
12705
12706 2019-01-16  Tom Tromey  <tom@tromey.com>
12707
12708         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12709         earlier.
12710         (struct objfile) <msymbols_range>: Move from top level.
12711         <msymbols>: New method.
12712         (class objfile_msymbols): Remove.
12713         * symtab.c (default_collect_symbol_completion_matches_break_on):
12714         Update.
12715         * symmisc.c (dump_msymbols): Update.
12716         * stabsread.c (scan_file_globals): Update.
12717         * objc-lang.c (info_selectors_command, info_classes_command)
12718         (find_methods): Update.
12719         * minsyms.c (find_solib_trampoline_target): Update.
12720         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12721         * coffread.c (coff_symfile_read): Update.
12722         * ada-lang.c (ada_lookup_simple_minsym)
12723         (ada_collect_symbol_completion_matches): Update.
12724
12725 2019-01-16  Tom Tromey  <tom@tromey.com>
12726
12727         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12728         type.  Remove no-argument constructor.
12729         <iterator::operator++>: Simplify.
12730         <begin>: Update.
12731         <end>: Use minimal_symbol_count.
12732
12733 2019-01-16  Tom Tromey  <tom@tromey.com>
12734
12735         * objfiles.h (struct objfile) <psymtabs>: New method.
12736         (class objfile_psymtabs): Remove.
12737         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12738         typedef.
12739         <range>: New method.
12740         (require_partial_symbols): Change return type.
12741         * psymtab.c (require_partial_symbols)
12742         (psym_expand_symtabs_matching): Update.
12743         * mdebugread.c (parse_partial_symbols): Update.
12744         * dbxread.c (dbx_end_psymtab): Update.
12745
12746 2019-01-15  Tom Tromey  <tom@tromey.com>
12747
12748         * symtab.c (lookup_objfile_from_block)
12749         (lookup_symbol_in_objfile_symtabs)
12750         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12751         (find_line_symtab, info_sources_command)
12752         (default_collect_symbol_completion_matches_break_on)
12753         (make_source_files_completion_list): Update.
12754         * symmisc.c (print_objfile_statistics, dump_objfile)
12755         (maintenance_print_symbols, maintenance_info_symtabs)
12756         (maintenance_check_symtabs, maintenance_info_line_tables):
12757         Update.
12758         * source.c (select_source_symtab)
12759         (forget_cached_source_info_for_objfile): Update.
12760         * objfiles.h (class objfile_compunits): Remove.
12761         (struct objfile) <compunits_range>: New typedef.
12762         (compunits): New method.
12763         * objfiles.c (objfile_relocate1): Update.
12764         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12765         * maint.c (count_symtabs_and_blocks): Update.
12766         * linespec.c (iterate_over_all_matching_symtabs): Update.
12767         * cp-support.c (add_symbol_overload_list_qualified): Update.
12768         * coffread.c (coff_symtab_read): Update.
12769         * ada-lang.c (add_nonlocal_symbols)
12770         (ada_collect_symbol_completion_matches)
12771         (ada_add_global_exceptions): Update.
12772
12773 2019-01-15  Tom Tromey  <tom@tromey.com>
12774
12775         * progspace.h (program_space) <objfiles_safe_range>: New
12776         typedef.
12777         <objfiles_safe>: New method.
12778         * objfiles.h (class all_objfiles_safe): Remove.
12779         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12780         * jit.c (jit_inferior_exit_hook): Update.
12781
12782 2019-01-17  Tom Tromey  <tom@tromey.com>
12783
12784         * progspace.h (program_space) <objfiles_range>: New typedef.
12785         <objfiles>: New method.
12786         <objfiles_head>: Rename from objfiles.
12787         (object_files): Update.
12788         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12789         * guile/scm-pretty-print.c
12790         (ppscm_find_pretty_printer_from_objfiles): Update.
12791         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12792         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12793         Update.
12794         * python/py-progspace.c (pspy_get_objfiles): Update.
12795         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12796         Update.
12797         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12798         (objfpy_lookup_objfile_by_build_id): Update.
12799         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12800         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12801         Update.
12802         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12803         (expand_symtab_containing_pc, lookup_objfile_from_block)
12804         (lookup_static_symbol, basic_lookup_transparent_type)
12805         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12806         (find_line_symtab, info_sources_command)
12807         (default_collect_symbol_completion_matches_break_on)
12808         (make_source_files_completion_list, find_main_name): Update.
12809         * symmisc.c (print_symbol_bcache_statistics)
12810         (print_objfile_statistics, maintenance_print_symbols)
12811         (maintenance_print_msymbols, maintenance_print_objfiles)
12812         (maintenance_info_symtabs, maintenance_check_symtabs)
12813         (maintenance_expand_symtabs, maintenance_info_line_tables):
12814         Update.
12815         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12816         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12817         (map_overlay_command, unmap_overlay_command)
12818         (simple_overlay_update, expand_symtabs_matching)
12819         (map_symbol_filenames): Update.
12820         * symfile-debug.c (set_debug_symfile): Update.
12821         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12822         Update.
12823         * source.c (select_source_symtab, forget_cached_source_info):
12824         Update.
12825         * solib.c (solib_read_symbols): Update.
12826         * solib-spu.c (append_ocl_sos): Update.
12827         * psymtab.c (maintenance_print_psymbols)
12828         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12829         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12830         * printcmd.c (info_symbol_command): Update.
12831         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12832         Update.
12833         * objfiles.h (class all_objfiles): Remove.
12834         * objfiles.c (have_partial_symbols, have_full_symbols)
12835         (have_minimal_symbols, qsort_cmp, update_section_map)
12836         (shared_objfile_contains_address_p)
12837         (default_iterate_over_objfiles_in_search_order): Update.
12838         * objc-lang.c (info_selectors_command, info_classes_command)
12839         (find_methods): Update.
12840         * minsyms.c (find_solib_trampoline_target): Update.
12841         * maint.c (maintenance_info_sections)
12842         (maintenance_translate_address, count_symtabs_and_blocks):
12843         Update.
12844         * main.c (captured_main_1): Update.
12845         * linux-thread-db.c (try_thread_db_load_from_pdir)
12846         (has_libpthread): Update.
12847         * linespec.c (iterate_over_all_matching_symtabs)
12848         (search_minsyms_for_name): Update.
12849         * jit.c (jit_find_objf_with_entry_addr): Update.
12850         * hppa-tdep.c (find_unwind_entry)
12851         (hppa_lookup_stub_minimal_symbol): Update.
12852         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12853         Update.
12854         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12855         (elf_gnu_ifunc_resolve_by_got): Update.
12856         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12857         * dwarf-index-write.c (save_gdb_index_command): Update.
12858         * cp-support.c (add_symbol_overload_list_qualified): Update.
12859         * breakpoint.c (create_overlay_event_breakpoint)
12860         (create_longjmp_master_breakpoint)
12861         (create_std_terminate_master_breakpoint)
12862         (create_exception_master_breakpoint): Update.
12863         * blockframe.c (find_pc_partial_function): Update.
12864         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12865         (ada_collect_symbol_completion_matches)
12866         (ada_add_global_exceptions): Update.
12867
12868 2019-01-17  Tom Tromey  <tom@tromey.com>
12869
12870         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12871         declare VEC.
12872         (solib_target_parse_libraries): Change return type.
12873         (library_list_start_segment, library_list_start_section)
12874         (library_list_end_library, library_list_start_library); Update.
12875         (solib_target_free_library_list): Remove.
12876         (solib_target_parse_libraries): Remove cleanup.  Change return
12877         type.
12878         (solib_target_current_sos): Update.
12879
12880 2019-01-17  Tom Tromey  <tromey@bapiya>
12881
12882         * valprint.c: Replace "the the" with "the".
12883         * symtab.c: Replace "the the" with "the".
12884         * solib.c: Replace "the the" with "the".
12885         * solib-dsbt.c: Replace "the the" with "the".
12886         * linespec.c: Replace "the the" with "the".
12887         * dwarf2loc.h: Replace "the the" with "the".
12888         * amd64-windows-tdep.c: Replace "the the" with "the".
12889         * aarch64-tdep.c: Replace "the the" with "the".
12890
12891 2019-01-16  Keith Seitz  <keiths@redhat.com>
12892
12893         PR gdb/23773
12894         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12895         <builder>: Rename to ..
12896         <m_builder>: ... this and make private.
12897         (dwarf2_cu::get_builder): New method.  Change all users of
12898         `builder' to use this method.
12899         (dwarf2_start_symtab): Move to ...
12900         (dwarf2_cu::start_symtab): ... here.  Update all callers
12901         (setup_type_unit_groups): Move to ...
12902         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12903         callers.
12904         (dwarf2_cu::reset_builder): New method.
12905         (process_full_compunit, process_full_type_unit): Use
12906         dwarf2_cu::reset_builder.
12907         (follow_die_offset): Record the ancestor CU if it is different
12908         from the followed DIE's CU.
12909         (follow_die_sig_1): Likewise.
12910
12911 2019-01-15  Tom Tromey  <tom@tromey.com>
12912
12913         * remote.c (class remote_state) <buf>: Now a char_vector.
12914         <buf_size>: Remove.
12915         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12916         parameter.
12917         (remote_target::getpkt_or_notif_sane_1)
12918         (remote_target::getpkt_sane)
12919         (remote_target::getpkt_or_notif_sane): Likewise.
12920         (class remote_target) <putpkt>: New overload.
12921         (remote_target::read_frame): Change type of "buf_p".  Remove
12922         sizeof_p parameter.
12923         (packet_ok): New overload.
12924         (packet_check_result): New overload.
12925         Update all uses.
12926
12927 2019-01-14  Tom Tromey  <tom@tromey.com>
12928
12929         * remote-notif.c (handle_notification, remote_notif_ack)
12930         (remote_notif_parse): Make "buf" const.
12931         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12932         const.
12933         (remote_notif_parse, remote_notif_ack, handle_notification):
12934         Likewise.
12935         * remote.c (remote_notif_stop_parse): Make "buf" const.
12936         (remote_target::remote_parse_stop_reply): Make "buf" const.
12937         (remote_notif_stop_ack): Make "buf" const.
12938
12939 2019-01-14  Tom Tromey  <tom@tromey.com>
12940
12941         * remote.c (remote_console_output): Make parameter const.
12942
12943 2019-01-14  Tom Tromey  <tom@tromey.com>
12944
12945         * target-debug.h (target_debug_print_signals): Constify.
12946         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12947         * procfs.c (procfs_target::pass_signals): Update.
12948         * linux-nat.c (linux_nat_target::pass_signals): Update.
12949         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12950         * target-delegates.c: Rebuild.
12951         * remote.c (remote_target::program_signals): Update.
12952         (remote_target::pass_signals): Update.
12953         * target.c (target_pass_signals): Constify argument.
12954         (target_program_signals): Likewise.
12955         * target.h (struct target_ops) <pass_signals, program_signals>:
12956         Constify argument.
12957         (target_pass_signals, target_program_signals): Constify argument.
12958
12959 2019-01-14  Tom Tromey  <tom@tromey.com>
12960
12961         PR tui/28819:
12962         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12963
12964 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12965
12966         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12967         field.
12968         * rs6000-tdep.c: Include reggroups.h.
12969         (IS_V_ALIAS_PSEUDOREG): Define.
12970         (rs6000_register_name): Return names for the "vX" aliases.
12971         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12972         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12973         aliases.  Call default_register_reggroup_p for all other
12974         pseudo-registers.
12975         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12976         New functions.
12977         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12978         Handle "vX" aliases.
12979         (v_alias_pseudo_register_collect): New function.
12980         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12981         (rs6000_gdbarch_init): Initialize "vX" aliases as
12982         pseudo-registers.  Restore registration of
12983         rs6000_pseudo_register_reggroup_p with
12984         set_tdesc_pseudo_register_reggroup_p.
12985
12986 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12987
12988         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12989         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12990         set_gdbarch_num_pseudo_regs.
12991
12992 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12993
12994         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12995         Remove arg prefixname, add do_set and do_show.
12996         Add member functions set_list and show_list.
12997         * cli/cli-style.c (class cli_style_option): Update accordingly.
12998         (style_set_list): Move to file scope.
12999         (style_show_list): Likewise.
13000         (set_style): Call help_list.
13001         (show_style): Call cmd_show_list.
13002         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13003         Update to use the new macro.
13004
13005 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13006
13007         * ada-lang.c (_initialize_ada_language): Expand the help text
13008         for the "catch exception" command.
13009
13010 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13011
13012         * symtab.c (matching_obj_sections): Initialize obj,
13013         declare it closer to its usage.
13014
13015 2019-01-10  Tom Tromey  <tom@tromey.com>
13016
13017         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13018         (basic_inf_threads_range): Remove.
13019         (inf_threads_range, inf_non_exited_threads_range)
13020         (safe_inf_threads_range): Use next_adapter.
13021
13022 2019-01-10  Keith Seitz  <keiths@redhat.com>
13023
13024         PR gdb/23712
13025         PR symtab/23010
13026         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13027         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13028
13029 2019-01-10  Keith Seitz  <keiths@redhat.com>
13030
13031         PR gdb/23712
13032         PR symtab/23010
13033         * dictionary.c (pending_to_vector): Remove.
13034         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13035         Remove _1 suffix, replacing functions of the same name.  Update
13036         all callers.
13037         (dict_create_hashed, dict_create_hashed_expandable)
13038         (dict_create_linear, dict_create_linear_expandable, dict_free)
13039         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13040         Make functions static.
13041
13042 2019-01-10  Keith Seitz  <keiths@redhat.com>
13043
13044         PR gdb/23712
13045         PR symtab/23010
13046         * dictionary.h (struct dictionary): Replace declaration with
13047         multidictionary.
13048         (dict_create_hashed, dict_create_hashed_expandable)
13049         (dict_create_linear, dict_create_linear_expandable)
13050         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13051         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13052         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13053         taking multidictionary argument.
13054         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13055         * block.h (struct block) <dict>: Change to multidictionary
13056         and rename `multidict'.
13057         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13058         symmisc.c: Update all dictionary references to multidictionary.
13059
13060 2019-01-10  Keith Seitz  <keiths@redhat.com>
13061
13062         PR gdb/23712
13063         PR symtab/23010
13064         * dictionary.c: Include unordered_map.
13065         (pending_to_vector): New function.
13066         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13067         Rewrite the non-"_1" functions to take vector instead
13068         of linked list.
13069         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13070         "new" _1 versions of the same name.
13071         (multidictionary): Define.
13072         (std::hash<enum language): New definition.
13073         (collate_pending_symbols_by_language, mdict_create_hashed)
13074         (mdict_create_hashed_expandable, mdict_create_linear)
13075         (mdict_create_linear_expandable, mdict_free)
13076         (find_language_dictionary, create_new_language_dictionary)
13077         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13078         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13079         (mdict_size, mdict_empty): New functions.
13080         * dictionary.h (mdict_iterator): Define.
13081
13082 2019-01-10  Pedro Alves  <palves@redhat.com>
13083
13084         * breakpoint.c (read_uploaded_action)
13085         (create_tracepoint_from_upload): Adjust to use
13086         gdb::unique_xmalloc_ptr.
13087         * ctf.c (ctf_write_uploaded_tp):
13088         (SET_ARRAY_FIELD): Use emplace_back.
13089         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13090         * tracefile-tfile.c (tfile_write_uploaded_tp):
13091         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13092         gdb::unique_xmalloc_ptr.
13093         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13094         at_string, cond_string, cmd_strings>: Replace char pointers
13095         with gdb::unique_xmalloc_ptr.
13096
13097 2019-01-10  Pedro Alves  <palves@redhat.com>
13098
13099         * solib-target.c (library_list_start_library): Don't xstrdup name.
13100
13101 2019-01-10  Pedro Alves  <palves@redhat.com>
13102
13103         * mdebugread.c (parse_partial_symbols): Use
13104         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13105
13106 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13107
13108         * linux-fork.c (scoped_switch_fork_info)
13109         <~scoped_switch_fork_info>: Fix incorrect variable name.
13110
13111 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13112
13113         * linux-fork.c (scoped_switch_fork_info)
13114         <scoped_switch_fork_info>: Make explicit.
13115         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13116
13117 2019-01-10  Tom Tromey  <tom@tromey.com>
13118
13119         * objfiles.h (objfile::reset_psymtabs): Update.
13120         * objfiles.c (objfile::objfile): Update.
13121         * psymtab.h (psymtab_storage::obstack): Update.
13122         (psymtab_storage::m_obstack): Use gdb::optional.
13123         (class psymtab_storage): Update comment.  Remove objfile
13124         parameter.
13125         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13126
13127 2019-01-10  Tom Tromey  <tom@tromey.com>
13128
13129         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13130         <free_psymtabs>: Now private.
13131         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13132         (allocate_psymtab): Use new method.
13133
13134 2019-01-10  Tom Tromey  <tom@tromey.com>
13135
13136         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13137         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13138         * mdebugread.c (parse_partial_symbols): Use
13139         allocate_dependencies.
13140         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13141         allocate_dependencies.
13142         (process_psymtab_comp_unit_reader)
13143         (build_type_psymtab_dependencies): Likewise.
13144         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13145
13146 2019-01-10  Tom Tromey  <tom@tromey.com>
13147
13148         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13149         PSYMBOL_SET_LANGUAGE.
13150         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13151
13152 2019-01-10  Tom Tromey  <tom@tromey.com>
13153
13154         * psymtab.h (psymtab_storage::obstack): New method.
13155         <m_obstack>: Rename from obstack; now private.
13156         * psymtab.c (psymtab_storage): Update.
13157         * dwarf2read.c (create_addrmap_from_index)
13158         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13159         Update.
13160
13161 2019-01-10  Tom Tromey  <tom@tromey.com>
13162
13163         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13164         * objfiles.h (objfile::reset_psymtabs): New method.
13165
13166 2019-01-10  Tom Tromey  <tom@tromey.com>
13167
13168         * symmisc.c (print_symbol_bcache_statistics): Update.
13169         (print_objfile_statistics): Update.
13170         * symfile.c (reread_symbols): Update.
13171         * psymtab.h (class psymtab_storage): New.
13172         * psymtab.c (psymtab_storage): New constructor.
13173         (~psymtab_storage): New destructor.
13174         (require_partial_symbols): Update.
13175         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13176         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13177         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13178         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13179         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13180         (start_psymtab_common, end_psymtab_common)
13181         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13182         (allocate_psymtab): Update.
13183         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13184         Update.
13185         (dump_psymtab_addrmap, maintenance_print_psymbols)
13186         (maintenance_check_psymtabs): Update.
13187         (class objfile_psymtabs): Move to objfiles.h.
13188         * psympriv.h (discard_psymtab): Now inline.
13189         (psymtab_discarder::psymtab_discarder): Update.
13190         (psymtab_discarder::~psymtab_discarder): Update.
13191         (ALL_OBJFILE_PSYMTABS): Rewrite.
13192         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13193         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13194         Remove fields.
13195         <partial_symtabs>: New field.
13196         (class objfile_psymtabs): Move from psymtab.h.  Update.
13197         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13198         psymbol_cache.
13199         (objfile::~objfile): Don't destroy psymbol_cache.
13200         * mdebugread.c (parse_partial_symbols): Update.
13201         * dwarf2read.c (create_addrmap_from_index)
13202         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13203         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13204         (add_partial_subprogram, dwarf2_ranges_read): Update.
13205         * dwarf-index-write.c (write_address_map)
13206         (write_one_signatured_type, recursively_write_psymbols)
13207         (class debug_names, class debug_names, write_psymtabs_to_index):
13208         Update.
13209
13210 2019-01-10  Tom Tromey  <tom@tromey.com>
13211
13212         * symtab.h (SYMBOL_SET_NAMES): Update.
13213         (symbol_set_names): Update.
13214         (MSYMBOL_SET_NAMES): Update.
13215         * symtab.c (symbol_set_names): Change argument to be an
13216         objfile_per_bfd_storage.
13217         * psymtab.c (add_psymbol_to_bcache): Update.
13218         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13219
13220 2019-01-10  Tom Tromey  <tom@tromey.com>
13221
13222         * symtab.c (create_demangled_names_hash): Change argument to be an
13223         objfile_per_bfd_storage.
13224         (symbol_set_names): Update.
13225
13226 2019-01-10  Tom Tromey  <tom@tromey.com>
13227
13228         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13229         init_psymbol_list.
13230         * psymtab.c (init_psymbol_list): Do nothing if already called.
13231         * psympriv.h (init_psymbol_list): Add comment.
13232         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13233         init_psymbol_list.
13234         * dbxread.c (dbx_symfile_read): Unconditionally call
13235         init_psymbol_list.
13236
13237 2019-01-10  Tom Tromey  <tom@tromey.com>
13238
13239         * xcoffread.c (scan_xcoff_symtab): Update.
13240         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13241         "where".
13242         * mdebugread.c (parse_partial_symbols)
13243         (handle_psymbol_enumerators): Update.
13244         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13245         * dbxread.c (read_dbx_symtab): Update.
13246         * psympriv.h (psymbol_placement): New enum.
13247         (add_psymbol_to_list): Update.
13248
13249 2019-01-10  Tom Tromey  <tom@tromey.com>
13250
13251         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13252         static_psymbols parameters.
13253         (scan_xcoff_symtab): Update.
13254         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13255         static_psymbols parameters.
13256         * psympriv.h (start_psymtab_common): Update.
13257         * mdebugread.c (parse_partial_symbols): Update.
13258         * dwarf2read.c (create_partial_symtab): Update.
13259         * dbxread.c (read_dbx_symtab): Update.
13260         (start_psymtab): Remove global_psymbols and static_psymbols
13261         parameters.
13262
13263 2019-01-10  Tom Tromey  <tom@tromey.com>
13264
13265         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13266         * psymtab.c (allocate_psymtab): Add comment.
13267         * psympriv.h (allocate_psymtab): Add comment.
13268         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13269         initializations.
13270         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13271
13272 2019-01-10  Tom Tromey  <tom@tromey.com>
13273
13274         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13275         Don't declare.
13276         * mipsread.c: Include mdebugread.h.
13277         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13278         Declare.
13279         * elfread.c: Include mdebugread.h.
13280
13281 2019-01-09  Tom Tromey  <tom@tromey.com>
13282
13283         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13284         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13285         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13286         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13287         (psym_lookup_symbol, psym_find_last_source_symtab)
13288         (psym_forget_cached_source_info, psym_print_stats)
13289         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13290         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13291         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13292         (psym_find_compunit_symtab_by_address)
13293         (maintenance_print_psymbols, maintenance_info_psymtabs)
13294         (maintenance_check_psymtabs): Use ranged for.
13295         * psymtab.h (class objfile_psymtabs): New.
13296         (require_partial_symbols): Return objfile_psymtabs.
13297         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13298
13299 2019-01-09  Tom Tromey  <tom@tromey.com>
13300
13301         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13302         (find_pc_mapped_section, list_overlays_command)
13303         (map_overlay_command, unmap_overlay_command)
13304         (simple_overlay_update): Use all_objfiles.
13305         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13306         * printcmd.c (info_symbol_command): Use all_objfiles.
13307         * objfiles.h (ALL_OBJSECTIONS): Remove.
13308         * maint.c (maintenance_translate_address): Use all_objfiles.
13309         * gcore.c (gcore_create_callback): Use all_objfiles.
13310         (objfile_find_memory_regions): Likewise.
13311
13312 2019-01-09  Tom Tromey  <tom@tromey.com>
13313
13314         * symtab.c (find_line_symtab, info_sources_command)
13315         (make_source_files_completion_list): Use objfile_compunits.
13316         * source.c (select_source_symtab): Use objfile_compunits.
13317         * objfiles.h (struct objfile): Update comment.
13318         (ALL_OBJFILES): Remove.
13319         (ALL_FILETABS): Remove.
13320         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13321         objfile_compunits.
13322
13323 2019-01-09  Tom Tromey  <tom@tromey.com>
13324
13325         * symmisc.c (print_objfile_statistics, dump_objfile)
13326         (maintenance_print_symbols): Use compunit_filetabs.
13327         * source.c (forget_cached_source_info_for_objfile): Use
13328         compunit_filetabs.
13329         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13330         (ALL_FILETABS): Use compunit_filetabs.
13331         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13332         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13333
13334 2019-01-09  Tom Tromey  <tom@tromey.com>
13335
13336         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13337         (compunit_filetabs): New.
13338         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13339         compunit_filetabs.
13340         (info_sources_command, make_source_files_completion_list): Remove
13341         declaration.
13342         * symmisc.c (print_objfile_statistics, dump_objfile)
13343         (maintenance_print_symbols): Remove declaration.
13344         (maintenance_info_symtabs): Use compunit_filetabs.
13345         (maintenance_info_line_tables): Likewise.
13346         * source.c (select_source_symtab): Change local variable name.
13347         (forget_cached_source_info_for_objfile): Remove declaration.
13348         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13349         * objfiles.c (objfile_relocate1): Remove declaration.
13350         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13351         declaration.
13352         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13353         * coffread.c (coff_symtab_read): Remove declaration.
13354         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13355         compunit_filetabs.
13356
13357 2019-01-09  Tom Tromey  <tom@tromey.com>
13358
13359         * symtab.c (lookup_objfile_from_block)
13360         (find_pc_sect_compunit_symtab, search_symbols)
13361         (default_collect_symbol_completion_matches_break_on): Use
13362         objfile_compunits.
13363         * objfiles.h (ALL_COMPUNITS): Remove.
13364         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13365         * cp-support.c (add_symbol_overload_list_qualified): Use
13366         objfile_compunits.
13367         * ada-lang.c (ada_collect_symbol_completion_matches)
13368         (ada_add_global_exceptions): Use objfile_compunits.
13369
13370 2019-01-09  Tom Tromey  <tom@tromey.com>
13371
13372         * source.c (select_source_symtab)
13373         (forget_cached_source_info_for_objfile): Remove declaration.
13374         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13375         declaration.
13376         * maint.c (count_symtabs_and_blocks): Remove declaration.
13377         * cp-support.c (add_symbol_overload_list_qualified): Remove
13378         declaration.
13379         * coffread.c (coff_symtab_read): Remove declaration.
13380         * symtab.c (lookup_symbol_in_objfile_symtabs)
13381         (basic_lookup_transparent_type_1): Use objfile_compunits.
13382         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13383         (info_sources_command, search_symbols)
13384         (default_collect_symbol_completion_matches_break_on)
13385         (make_source_files_completion_list): Remove declaration.
13386         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13387         (ada_collect_symbol_completion_matches)
13388         (ada_add_global_exceptions): Remove declaration.
13389         * linespec.c (iterate_over_all_matching_symtabs): Use
13390         objfile_compunits.
13391         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13392         (class objfile_compunits): New.
13393         (ALL_COMPUNITS): Use objfile_compunits.
13394         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13395         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13396         objfile_compunits.
13397         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13398
13399 2019-01-09  Tom Tromey  <tom@tromey.com>
13400
13401         * symtab.c (search_symbols)
13402         (default_collect_symbol_completion_matches_break_on): Use
13403         objfile_msymbols.
13404         * ada-lang.c (ada_lookup_simple_minsym)
13405         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13406         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13407         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13408         objfile_msymbols.
13409         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13410         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13411         * objc-lang.c (find_methods): Use objfile_msymbols.
13412         (info_selectors_command, info_classes_command): Likewise.
13413         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13414         * objfiles.h (class objfile_msymbols): New.
13415         (ALL_OBJFILE_MSYMBOLS): Remove.
13416         (ALL_MSYMBOLS): Remove.
13417
13418 2019-01-09  Tom Tromey  <tom@tromey.com>
13419
13420         * common/next-iterator.h (next_adapter): Add Iterator template
13421         parameter.
13422         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13423         (class all_objfiles_safe): New.
13424         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13425         * objfiles.c (put_objfile_before): Update comment.
13426         (add_separate_debug_objfile): Likewise.
13427         (free_all_objfiles): Use all_objfiles_safe.
13428         (objfile_purge_solibs): Likewise.
13429
13430 2019-01-09  Tom Tromey  <tom@tromey.com>
13431
13432         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13433         (expand_symtab_containing_pc, lookup_static_symbol)
13434         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13435         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13436         all_objfiles.
13437         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13438         * breakpoint.c (create_overlay_event_breakpoint)
13439         (create_longjmp_master_breakpoint)
13440         (create_std_terminate_master_breakpoint)
13441         (create_exception_master_breakpoint): Use all_objfiles.
13442         * linux-thread-db.c (try_thread_db_load_from_pdir)
13443         (has_libpthread): Use all_objfiles.
13444         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13445         * linespec.c (iterate_over_all_matching_symtabs)
13446         (search_minsyms_for_name): Use all_objfiles.
13447         * maint.c (maintenance_info_sections): Use all_objfiles.
13448         * main.c (captured_main_1): Use all_objfiles.
13449         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13450         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13451         * guile/scm-pretty-print.c
13452         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13453         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13454         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13455         (maintenance_print_msymbols): Use all_objfiles.
13456         * source.c (select_source_symtab): Use all_objfiles.
13457         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13458         * symfile.c (remove_symbol_file_command)
13459         (expand_symtabs_matching, map_symbol_filenames): Use
13460         all_objfiles.
13461         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13462         all_objfiles.
13463         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13464         * objc-lang.c (find_methods): Use all_objfiles.
13465         * objfiles.c (have_partial_symbols, have_full_symbols)
13466         (have_minimal_symbols, qsort_cmp)
13467         (default_iterate_over_objfiles_in_search_order): Use
13468         all_objfiles.
13469         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13470         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13471         (maintenance_check_psymtabs): Use all_objfiles.
13472         (ALL_PSYMTABS): Remove.
13473         * compile/compile-object-run.c (do_module_cleanup): Use
13474         all_objfiles.
13475         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13476         * cp-support.c (add_symbol_overload_list_qualified): Use
13477         all_objfiles.
13478         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13479         Use all_objfiles.
13480         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13481         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13482         all_objfiles.
13483         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13484         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13485         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13486         Uses all_objfiles.
13487         * solib.c (solib_read_symbols): Use all_objfiles
13488
13489 2019-01-09  Tom Tromey  <tom@tromey.com>
13490
13491         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13492         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13493         all_objfiles.
13494         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13495         * symmisc.c (print_symbol_bcache_statistics)
13496         (print_objfile_statistics, maintenance_print_objfiles)
13497         (maintenance_info_symtabs, maintenance_check_symtabs)
13498         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13499         all_objfiles.
13500         * source.c (forget_cached_source_info): Use all_objfiles.
13501         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13502         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13503         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13504         * objfiles.c (update_section_map): Use all_objfiles.
13505         (shared_objfile_contains_address_p): Likewise.
13506         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13507         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13508
13509 2019-01-09  Tom Tromey  <tom@tromey.com>
13510
13511         * common/next-iterator.h: New file.
13512         * objfiles.h (class all_objfiles): New.
13513         (struct objfile_iterator): New.
13514
13515 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13516
13517         * NEWS: Move the description of the changed "frame", "select-frame",
13518          and "info frame" commands to the Changed commands section.
13519
13520 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13521
13522         * gdbtypes.c (check_stub_method_group): Remove handling of old
13523         mangling schemes.
13524         * linespec.c (find_methods): Likewise.
13525         * stabsread.c (read_member_functions): Likewise.
13526         * valops.c (search_struct_method): Likewise.
13527         (value_struct_elt_for_reference): Likewise.
13528         * NEWS: Mention this change.
13529
13530 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13531
13532         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13533         print_source_lines.
13534         * source.c (print_source_lines_base): Update line number check.
13535         (print_source_lines): New function.
13536         (source_lines_range::source_lines_range): New function.
13537         * source.h (class source_lines_range): New class.
13538         (print_source_lines): New declaration.
13539
13540 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13541
13542         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13543
13544 2019-01-08  Tom Tromey  <tom@tromey.com>
13545             Simon Marchi  <simon.marchi@ericsson.com>
13546
13547         PR gdb/24060
13548         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13549         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13550         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13551         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13552         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13553         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13554
13555 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13556
13557         * source.c (select_source_symtab): Move header comment to
13558         declaration in source.h.
13559         (forget_cached_source_info_for_objfile): Likewise.
13560         (forget_cached_source_info): Likewise.
13561         (identify_source_line): Likewise.
13562         * source.h (identify_source_line): Move declaration from symtab.h
13563         and add comment from source.c
13564         (print_source_lines): Likewise.
13565         (forget_cached_source_info_for_objfile): Likewise.
13566         (forget_cached_source_info): Likewise.
13567         (select_source_symtab): Likewise.
13568         (enum print_source_lines_flag): Move definition from symtab.h.
13569         * symtab.h (identify_source_line): Move declaration to source.h.
13570         (print_source_lines): Likewise.
13571         (forget_cached_source_info_for_objfile): Likewise.
13572         (forget_cached_source_info): Likewise.
13573         (select_source_symtab): Likewise.
13574         (enum print_source_lines_flag): Move definition to source.h.
13575         * tui/tui-hooks.c: Add 'source.h' include.
13576
13577 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13578
13579         * source.c (print_source_lines_base): Handle requests to print
13580         reverse line number sequences, and guard against empty lines
13581         string.
13582
13583 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13584
13585         * source.c (print_source_lines_base): Fix skip of '\r' if next
13586         character is '\n'.
13587
13588 2019-01-06  Tom Tromey  <tom@tromey.com>
13589
13590         * c-exp.y (struct c_parse_state) <macro_original_text,
13591         expansion_obstack>: New member.
13592         (macro_original_text, expansion_obstack): Remove globals.
13593         (scan_macro_expansion, scanning_macro_expansion)
13594         (finished_macro_expansion): Update.
13595         (scan_macro_cleanup): Remove.
13596         (yylex, c_parse): Update.
13597
13598 2019-01-06  Tom Tromey  <tom@tromey.com>
13599
13600         * c-exp.y (struct c_parse_state) <strings>: New member.
13601         (operator_stoken): Update.
13602
13603 2019-01-06  Tom Tromey  <tom@tromey.com>
13604
13605         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13606         (union type_stack_elt) <typelist_val>: Now a pointer to
13607         std::vector.
13608         (type_stack_cleanup): Don't declare.
13609         (push_typelist): Update.
13610         * parse.c (pop_typelist): Return a std::vector.
13611         (push_typelist): Take a std::vector.
13612         (follow_types): Update.  Do not free args.
13613         (type_stack_cleanup): Remove.
13614         * c-exp.y (struct c_parse_state): New.
13615         (cpstate): New global.
13616         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13617         (nonempty_typelist): Update.
13618         (func_mod): Create a new vector.
13619         (c_parse): Create a c_parse_state.
13620         (check_parameter_typelist): Do not delete params.
13621         (function_method): Update.  Do not delete type_list.
13622
13623 2019-01-06  Tom Tromey  <tom@tromey.com>
13624
13625         PR gdb/28155:
13626         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13627         check_typedef.
13628         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13629         (print_return_value): Likewise.
13630
13631 2019-01-05  Tom Tromey  <tom@tromey.com>
13632
13633         * contrib/cleanup_check.py: Remove.
13634         * contrib/gcc-with-excheck: Remove.
13635         * contrib/exsummary.py: Remove.
13636         * contrib/excheck.py: Remove.
13637
13638 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13639
13640         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13641         NULL. Initialize tpprev to NULL instead of assigning it
13642         to NULL on the next statement.
13643         * windows-nat.c (windows_delete_thread): Remove check for
13644         main_thread_id before printing thread exit notifications.
13645         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13646         Remove thread ID check against main_thread_id.
13647         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13648         windows_delete_thread.
13649         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13650
13651 2019-01-04  Tom Tromey  <tom@tromey.com>
13652
13653         * compile/compile.c (_initialize_compile): Use upper case for
13654         metasyntactic variables.
13655         * symmisc.c (_initialize_symmisc): Use upper case for
13656         metasyntactic variables.
13657         * psymtab.c (_initialize_psymtab): Use upper case for
13658         metasyntactic variables.
13659         * demangle.c (demangle_command): Use upper case for metasyntactic
13660         variables.
13661         (_initialize_demangler): Likewise.
13662         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13663         variables.
13664
13665 2019-01-03  Tom Tromey  <tom@tromey.com>
13666
13667         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13668
13669 2019-01-03  Tom Tromey  <tom@tromey.com>
13670
13671         * python/py-symtab.c (salpy_str): Update.
13672         (struct salpy_sal_object) <symtab>: Now a PyObject.
13673         (salpy_dealloc): Update.
13674         (del_objfile_sal): Use gdbpy_ref.
13675
13676 2019-01-03  Tom Tromey  <tom@tromey.com>
13677
13678         * python/py-type.c (convert_field): Use new_reference.  Return
13679         gdbpy_ref.
13680         (make_fielditem): Return gdbpy_ref.
13681         (typy_fields): Update.
13682         (typy_getitem): Update.
13683         (field_name): Return gdbpy_ref.  Use new_reference.
13684         (typy_iterator_iternext): Update.
13685
13686 2019-01-03  Tom Tromey  <tom@tromey.com>
13687
13688         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13689
13690 2019-01-03  Tom Tromey  <tom@tromey.com>
13691
13692         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13693         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13694         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13695         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13696         (pspy_set_type_printers): Likewise.
13697         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13698         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13699         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13700         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13701         (objfpy_set_type_printers): Likewise.
13702
13703 2019-01-03  Tom Tromey  <tom@tromey.com>
13704
13705         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13706         (gdbpy_print_stack): Use gdbpy_err_fetch.
13707         * python/python-internal.h (class gdbpy_err_fetch): New class.
13708         (class gdbpy_enter) <m_error_type, m_error_value,
13709         m_error_traceback>: Remove.
13710         <m_error>: New member.
13711         (gdbpy_exception_to_string): Don't declare.
13712         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13713         * python/py-value.c (convert_value_from_python): Use
13714         gdbpy_err_fetch.
13715         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13716         gdbpy_exception_to_string.
13717         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13718         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13719         gdbpy_err_fetch.
13720
13721 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13722
13723         * linux-nat.c (delete_lwp_cleanup): Delete.
13724         (struct lwp_deleter): New struct.
13725         (lwp_info_up): New typedef.
13726         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13727         lwp_info_up.
13728
13729 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13730
13731         * linux-fork.c (class scoped_switch_fork_info): New class.
13732         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13733
13734 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13735
13736         * valops.c (find_overload_match): Remove use of null_cleanup, and
13737         calls to do_cleanups.
13738
13739 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13740
13741         * compile/compile-cplus-types.c
13742         (compile_cplus_instance::decl_name): Handle changes to
13743         cp_func_name.
13744         * cp-support.c (cp_func_name): Update header comment, update
13745         return type.
13746         * cp-support.h (cp_func_name): Update return type in declaration.
13747         * valops.c (find_overload_match): Move temp_func local to top
13748         level of function and change its type.  Use temp_func to hold and
13749         delete temporary string obtained from cp_func_name.
13750
13751 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13752
13753         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13754         gdb::char_vector, remove cleanup, and update uses of `msg`.
13755
13756 2019-01-03  Jim Wilson  <jimw@sifive.com>
13757
13758         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13759
13760 2019-01-02  Tom Tromey  <tom@tromey.com>
13761
13762         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13763         (tdesc_parse_xml): Remove cleanups.
13764         * target-descriptions.h (make_cleanup_free_target_description):
13765         Don't declare.
13766         (target_desc_deleter): New struct.
13767         (target_desc_up): New typedef.
13768         * target-descriptions.c (target_desc_deleter::operator()): Rename
13769         from free_target_description.
13770         (make_cleanup_free_target_description): Remove.
13771
13772 2019-01-02  Tom Tromey  <tom@tromey.com>
13773
13774         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13775         constructor, destructor.
13776         (linespec_parser): Remove typedef.
13777         (~linespec_parser): Rename from linespec_parser_delete.
13778         (linespec_lex_to_end, linespec_complete_label)
13779         (linespec_complete): Update.
13780         (decode_line_full): Remove cleanups.
13781         (decode_line_1): Update.
13782
13783 2019-01-02  Tom Tromey  <tom@tromey.com>
13784
13785         * python/python-internal.h (inferior_to_inferior_object): Change
13786         return type.
13787         * python/py-exitedevent.c (create_exited_event_object): Update.
13788         * python/py-inferior.c (inferior_to_inferior_object): Return
13789         gdbpy_ref.
13790         (python_new_inferior, python_inferior_deleted)
13791         (thread_to_thread_object, delete_thread_object)
13792         (build_inferior_list, gdbpy_selected_inferior): Update.
13793         * python/py-infthread.c (create_thread_object): Update.  Also fail
13794         if inferior_to_inferior_object fails.
13795
13796 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13797
13798         * inferior.h (class inferior) <displaced_step_state>: New field.
13799         * infrun.h (struct displaced_step_state): Move here from
13800         infrun.c.  Initialize fields, add constructor.
13801         <inf>: Remove field.
13802         <reset>: New method.
13803         * infrun.c (struct displaced_step_inferior_state): Move to
13804         infrun.h.
13805         (displaced_step_inferior_states): Remove.
13806         (get_displaced_stepping_state): Adust.
13807         (displaced_step_in_progress_any_inferior): Adjust.
13808         (displaced_step_in_progress_thread): Adjust.
13809         (displaced_step_in_progress): Adjust.
13810         (add_displaced_stepping_state): Remove.
13811         (get_displaced_step_closure_by_addr): Adjust.
13812         (remove_displaced_stepping_state): Remove.
13813         (infrun_inferior_exit): Call displaced_step_state.reset.
13814         (use_displaced_stepping): Don't check for NULL.
13815         (displaced_step_prepare_throw): Call
13816         get_displaced_stepping_state.
13817         (displaced_step_fixup): Don't check for NULL.
13818         (prepare_for_detach): Don't check for NULL.
13819
13820 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13821
13822         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13823          in case of call that did not complete.
13824
13825 2019-01-02  Andrey Utkin  <autkin@undo.io>
13826
13827         * symfile.c (find_separate_debug_file): Fix search of debug files for
13828         remote debuggee.
13829
13830 2019-01-02  Tom Tromey  <tom@tromey.com>
13831
13832         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13833         indentation.
13834         * python/py-frame.c (frapy_older): Remove cast.
13835         (frapy_newer): Likewise.
13836         * python/py-breakpoint.c (local_setattro): Remove cast.
13837         * python/py-arch.c (archpy_name): Remove local variable.
13838         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13839
13840 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13841
13842         * unittests/basic_string_view/element_access/char/empty.cc:
13843         Fix year range in copyright header.
13844
13845 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13846
13847         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13848         Delete.
13849         <operator==>: Update with for removed field.
13850         <hash>: Likewise.
13851         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13852         <isa_features>: ...this.
13853         <abi_features>: New field.
13854         (riscv_isa_flen): Update comment.
13855         (riscv_abi_xlen): New declaration.
13856         (riscv_abi_flen): New declaration.
13857         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13858         isa_features.
13859         (riscv_abi_xlen): New function.
13860         (riscv_isa_flen): Update to get answer from isa_features.
13861         (riscv_abi_flen): New function.
13862         (riscv_has_fp_abi): Update to get answer from abi_features.
13863         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13864         xlen and flen.
13865         (riscv_call_info) <xlen, flen>: Update comment.
13866         (riscv_call_arg_struct): Remove invalid assertions
13867         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13868         is removed.
13869         (riscv_gdbarch_init): Gather isa features and abi features
13870         separately, ensure both match on the gdbarch when reusing an old
13871         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13872         a target with 64-bit float hardware.
13873
13874 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13875
13876         * source.c (search_command_helper): Stop reverse search
13877         when line 1 has been searched.
13878
13879 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13880
13881         * record-full.c (record_full_base_target::close): Rewrite
13882         record_full_core_buf_list free logic.
13883
13884 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13885
13886         * break-catch-syscall.c (print_one_catch_syscall): xfree
13887         the last text.
13888
13889 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13890
13891         * top.c (print_gdb_version): Update Copyright year in version
13892         message.
13893
13894 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13895
13896         Update copyright year range in all GDB files.
13897
13898 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13899
13900         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13901
13902 For older changes see ChangeLog-2018.
13903 \f
13904 Local Variables:
13905 mode: change-log
13906 left-margin: 8
13907 fill-column: 74
13908 version-control: never
13909 coding: utf-8
13910 End:
13911