gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tromey@adacore.com>
   2
   3         * maint.c (_initialize_maint_cmds): Move initialization code to
   4         remote.c.
   5         (watchdog, show_watchdog): Move to remote.c.
   6         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
   7         "watchdog" static.
   8         (_initialize_remote): Move initialization code from maint.c.
   9         * defs.h (watchdog): Don't declare.
  10
  11 2019-05-08  Tom Tromey  <tromey@adacore.com>
  12
  13         * tui/tui-interp.c: Include main.h.
  14         * interps.c: Include main.h.
  15         * main.h (interpreter_p): Declare.
  16         * defs.h (interpreter_p): Don't declare.
  17
  18 2019-05-08  Tom Tromey  <tromey@adacore.com>
  19
  20         * dwarf2loc.c: Include dwarf2read.h.
  21         * defs.h (read_unsigned_leb128): Don't declare.
  22         * dwarf2read.h (read_unsigned_leb128): Declare.
  23
  24 2019-05-08  Tom Tromey  <tromey@adacore.com>
  25
  26         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
  27         method.
  28
  29 2019-05-08  Tom Tromey  <tromey@adacore.com>
  30
  31         * utils.c (fputs_maybe_filtered): Reset style after paging, even
  32         when no wrap column is set.
  33
  34 2019-05-08  Tom Tromey  <tromey@adacore.com>
  35
  36         * c-lang.c (c_get_string): Handle non-C-style arrays.
  37
  38 2019-05-08  Tom Tromey  <tromey@adacore.com>
  39
  40         * typeprint.c (print_offset_data::update): Print the bit offset,
  41         not the number of bits remaining.
  42
  43 2019-05-08  Tom Tromey  <tromey@adacore.com>
  44
  45         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
  46         padding at end of comment.
  47
  48 2019-05-08  Tom Tromey  <tromey@adacore.com>
  49
  50         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
  51         Compare main types.
  52
  53 2019-05-06  Tom Tromey  <tom@tromey.com>
  54
  55         * common/scoped_mmap.c: Include common-defs.h.
  56         * common/scoped_mmap.h: Don't include config.h.
  57
  58 2019-05-04  Tom Tromey  <tom@tromey.com>
  59
  60         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
  61         (struct aarch64_call_info): Add initializers.
  62         <si>: Now a std::vector.
  63         (pass_on_stack, aarch64_push_dummy_call): Update.
  64
  65 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
  66             Tom Tromey  <tom@tromey.com>
  67
  68         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
  69         (ppc_threads): Now a std::vector.  Now static.
  70         (hwdebug_find_thread_points_by_tid)
  71         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
  72         Update.
  73
  74 2019-05-04  Tom Tromey  <tom@tromey.com>
  75
  76         * arc-tdep.c (arc_tdesc_init): Return bool.
  77
  78 2019-05-04  Tom Tromey  <tom@tromey.com>
  79
  80         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
  81         Use gdb_assert_not_reached.
  82
  83 2019-05-04  Tom Tromey  <tom@tromey.com>
  84
  85         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
  86         "false".
  87
  88 2019-05-04  Tom Tromey  <tom@tromey.com>
  89
  90         * arc-tdep.c (arc_tdesc_init): Use bool.
  91
  92 2019-05-04  Tom Tromey  <tom@tromey.com>
  93
  94         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
  95
  96 2019-05-04  Tom Tromey  <tom@tromey.com>
  97
  98         * cli/cli-cmds.c (valid_command_p): Return bool.
  99
 100 2019-05-04  Tom Tromey  <tom@tromey.com>
 101
 102         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 103         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 104
 105 2019-05-04  Raul Tambre  <raul@tambre.ee>
 106
 107         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 108         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 109         operator for comparison.
 110
 111 2019-05-04  Tom Tromey  <tom@tromey.com>
 112
 113         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 114         (lookup_partial_symbol, print_partial_symbols)
 115         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 116         (psymbol_compare): Update.
 117         (add_psymbol_to_bcache): Clear the entire psymbol.
 118         (maintenance_check_psymtabs): Update.
 119         * psympriv.h (struct partial_symbol): Don't derive from
 120         general_symbol_info.
 121         <obj_section, unrelocated_address, address,
 122         set_unrelocated_address>: Update.
 123         <ginfo>: New member.
 124         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 125         (debug_names::write_psymbols): Update.
 126
 127 2019-05-04  Tom de Vries  <tdevries@suse.de>
 128
 129         * contrib/cc-with-tweaks.sh: Support -n arg.
 130
 131 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 132
 133         * corelow.c (core_target::detach): Ensure frame cache and
 134         register caches are cleared.
 135         inferior.c (exit_inferior_1): Likewise.
 136
 137 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 138             Tom Tromey  <tom@tromey.com>
 139
 140         * dictionary.c (collate_pending_symbols_by_language): Remove
 141         "struct" from foreach.
 142         * symtab.c (lookup_global_symbol_from_objfile)
 143         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 144         foreach.
 145         * ser-tcp.c (net_open): Remove "struct" from foreach.
 146         * objfiles.c (objfile_relocate, objfile_rebase)
 147         (objfile_has_symbols): Remove "struct" from foreach.
 148         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 149         from foreach.
 150         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 151         foreach.
 152         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 153         "struct" from foreach.
 154         * ada-lang.c (create_excep_cond_exprs)
 155         (ada_exception_catchpoint_cond_string): Remove "struct" from
 156         foreach.
 157
 158 2019-05-03  Tom Tromey  <tromey@adacore.com>
 159
 160         * ada-exp.y (convert_char_literal): Check suffix of each
 161         enumerator.
 162
 163 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 164
 165         PR ada/21406:
 166         * ada-exp.y (yywrap): Don't define.
 167         * ada-lex.l (%option): Add noyywrap
 168         (yywrap): Remove.
 169
 170 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 171
 172         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 173         _WIN32_WINNT to the XP level, unless already defined to a higher
 174         level.
 175
 176         * unittests/parse-connection-spec-selftests.c:
 177         * ser-tcp.c:
 178         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 179         override.
 180
 181         * symfile.c (find_separate_debug_file): Remove colon from the
 182         drive spec of DOS/Windows file names of the target, so that the
 183         file name produced from DEBUGDIR and the target's directory will
 184         be valid on DOS/Windows systems.
 185
 186 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 187
 188         * rust-lang.c (val_print_struct): Handle printing structures
 189         containing strings.
 190
 191 2019-05-02  Tom Tromey  <tromey@adacore.com>
 192
 193         * valarith.c (_initialize_valarith): Remove.
 194
 195 2019-05-01  Tom Tromey  <tromey@adacore.com>
 196
 197         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 198         bitfields.
 199
 200 2019-05-01  Tom Tromey  <tromey@adacore.com>
 201
 202         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 203         for big-endian copies.
 204
 205 2019-04-30  Ali Tamur  <tamur@google.com>
 206         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 207         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 208         (read_3_bytes): New function.
 209
 210 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 211
 212         * windows-nat.c (main_thread_id): Delete.
 213         (handle_output_debug_string): Replace main_thread_id by
 214         current_event.dwThreadId.
 215         (fake_create_process): Likewise.
 216         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 217         Do not set main_thread_id.
 218         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 219         current_event.dwThreadId.
 220         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 221
 222 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 223
 224         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 225         Use current_event.dwThreadId instead of main_thread_id.
 226
 227 2019-04-30  Tom Tromey  <tromey@adacore.com>
 228
 229         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 230         (create_excep_cond_exprs): Iterate over program spaces.
 231         (ada_exception_catchpoint_cond_string): Examine all minimal
 232         symbols for exception types.
 233
 234 2019-04-30  Tom Tromey  <tromey@adacore.com>
 235
 236         PR c++/24470:
 237         * dwarf2read.c (process_structure_scope): Handle case where type
 238         has template parameters but no symbol was created.
 239
 240 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 241             Chris January  <chris.january@arm.com>
 242
 243         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 244         qualifier.
 245         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 246
 247 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 248
 249         * f-typeprint.c (f_print_type): Update rules for printing
 250         whitespace.
 251         (f_type_print_varspec_suffix): Likewise.
 252
 253 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 254             Chris January  <chris.january@arm.com>
 255
 256         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 257         function arguments.
 258
 259 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 260
 261         * f-lang.c (build_fortran_types): Change name of void type to
 262         lower case.
 263         * f-typeprint.c (f_type_print_base): Print the name of the void
 264         type, rather than a fixed string.
 265         * f-valprint.c (f_decorations): Use lower case void string.
 266
 267 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 268             Chris January  <chris.january@arm.com>
 269
 270         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 271         types for Fortran.
 272
 273 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 274             Chris January  <chris.january@arm.com>
 275             David Lecomber  <david.lecomber@arm.com>
 276
 277         * f-exp.y (BINOP_INTRINSIC): New token.
 278         (exp): New parser rule handling BINOP_INTRINSIC.
 279         (f77_keywords): Add new builtin procedures.
 280         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 281         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 282         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 283         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 284         (print_unop_subexp_f): New function.
 285         (print_binop_subexp_f): New function.
 286         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 287         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 288         (dump_subexp_body_f): Likewise.
 289         (operator_check_f): Likewise.
 290         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 291         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 292
 293 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 294
 295         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 296         UNOP_KIND.
 297         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 298         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 299         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 300         (operator_length_f): New fuction.
 301         (print_subexp_f): New function.
 302         (op_name_f): New function.
 303         (dump_subexp_body_f): New function.
 304         (operator_check_f): New function.
 305         (exp_descriptor_f): Replace standard expression handling functions
 306         with new functions.
 307         * gdb/fortran-operator.def: New file.
 308         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 309         * gdb/std-operator.def: Remove UNOP_KIND.
 310
 311 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 312
 313         * std-operator.def: Remove unbalanced, stray double quote
 314         character.
 315
 316 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 317             Chris January  <chris.january@arm.com>
 318             Daniel Everett  <daniel.everett@arm.com>
 319             Nick Forrington  <nick.forrington@arm.com>
 320             Richard Bunt  <richard.bunt@arm.com>
 321
 322         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 323         of depth when printing anonymous structs or unions.
 324         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 325         Don't print either the top-level value, or the children if the
 326         max-depth is exceeded.
 327         (ppscm_print_children): When printing the key of a map, allow one
 328         extra level of depth.
 329         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 330         print either the top-level value, or the children if the max-depth
 331         is exceeded.
 332         (print_children): When printing the key of a map, allow one extra
 333         level of depth.
 334         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 335         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 336         (user_print_options): Initialise max_depth field.
 337         (val_print_scalar_or_string_type_p): New function.
 338         (val_print): Check to see if the max depth has been reached.
 339         (val_print_check_max_depth): Define new function.
 340         (show_print_max_depth): New function.
 341         (_initialize_valprint): Add 'print max-depth' option.
 342         * valprint.h (struct value_print_options) <max_depth>: New field.
 343         (val_print_check_max_depth): Declare new function.
 344         * NEWS: Document new feature.
 345
 346 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 347
 348         * ada-lang.c (ada_language_defn): Initialise new field.
 349         * c-lang.c (c_is_string_type_p): New function.
 350         (c_language_defn): Initialise new field.
 351         (cplus_language_defn): Initialise new field.
 352         (asm_language_defn): Initialise new field.
 353         (minimal_language_defn): Initialise new field.
 354         * c-lang.h (c_is_string_type_p): Declare new function.
 355         * d-lang.c (d_language_defn): Initialise new field.
 356         * f-lang.c (f_is_string_type_p): New function.
 357         (f_language_defn): Initialise new field.
 358         * go-lang.c (go_is_string_type_p): New function.
 359         (go_language_defn): Initialise new field.
 360         * language.c (default_is_string_type_p): New function.
 361         (unknown_language_defn): Initialise new field.
 362         (auto_language_defn): Initialise new field.
 363         * language.h (struct language_defn) <la_is_string_type_p>: New
 364         member variable.
 365         (default_is_string_type_p): Declare new function.
 366         * m2-lang.c (m2_language_defn): Initialise new field.
 367         * objc-lang.c (objc_language_defn): Initialise new field.
 368         * opencl-lang.c (opencl_language_defn): Initialise new field.
 369         * p-lang.c (pascal_is_string_type_p): New function.
 370         (pascal_language_defn): Initialise new field.
 371         * rust-lang.c (rust_is_string_type_p): New function.
 372         (rust_language_defn): Initialise new field.
 373
 374 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 375
 376         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 377         New field.
 378         * ada-lang.c (ada_language_defn): Initialise new field.
 379         * c-lang.c (c_language_defn): Likewise.
 380         (cplus_language_defn): Likewise.
 381         (asm_language_defn): Likewise.
 382         (minimal_language_defn): Likewise.
 383         * d-lang.c (d_language_defn): Likewise.
 384         * f-lang.c (f_language_defn): Likewise.
 385         * go-lang.c (go_language_defn): Likewise.
 386         * language.c (unknown_language_defn): Likewise.
 387         (auto_language_defn): Likewise.
 388         * m2-lang.c (m2_language_defn): Likewise.
 389         * objc-lang.c (objc_language_defn): Likewise.
 390         * opencl-lang.c (opencl_language_defn): Likewise.
 391         * p-lang.c (pascal_language_defn): Likewise.
 392         * rust-lang.c (rust_language_defn): Likewise.
 393
 394 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 395
 396         * ada-lang.c (ada_is_character_type): Change return type to bool.
 397         (ada_is_string_type): Likewise.
 398         * ada-lang.h (ada_is_character_type): Update declaration
 399         (ada_is_string_type): Likewise.
 400
 401 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 402
 403         Support style in 'frame|thread apply'
 404
 405         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 406         * record.c (record_start, record_stop): Update callers of
 407         execute_command_to_string with false.
 408         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 409         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 410         methods.
 411         (class string_file): New constructor with term_out parameter.
 412         Override methods term_out and can_emit_style_escape.  New member
 413         term_out.
 414         (class stdio_file): Override can_emit_style_escape.
 415         (class tee_file): Override term_out and can_emit_style_escape.
 416         * utils.h (can_emit_style_escape): Remove.
 417         * utils.c (can_emit_style_escape): Likewise.
 418         Update all callers of can_emit_style_escape (SOMESTREAM) to
 419         SOMESTREAM->can_emit_style_escape.
 420         * source-cache.c (source_cache::get_source_lines): Likewise.
 421         * stack.c (frame_apply_command_count): Call execute_command_to_string
 422         passing the term_out characteristic of the current gdb_stdout.
 423         * thread.c (thr_try_catch_cmd): Likewise.
 424         * top.c (execute_command_to_string): pass term_out parameter
 425         to construct the string_file for the command output.
 426         * ui-file.c (term_cli_styling): New function (most code moved
 427         from utils.c can_emit_style_escape).
 428         (string_file::string_file, string_file::can_emit_style_escape,
 429         stdio_file::can_emit_style_escape, tee_file::term_out,
 430         tee_file::can_emit_style_escape): New functions.
 431
 432 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 433
 434         * NEWS: Mention the new set|show may-call-functions.
 435         * infcall.c (may_call_functions_p): New variable.
 436         (show_may_call_functions_p): New function.
 437         (call_function_by_hand_dummy): Throws an error if not
 438         may-call-functions.
 439         (_initialize_infcall): Call add_setshow_boolean_cmd for
 440         may-call-functions.
 441
 442 2019-04-25  Keith Seitz  <keiths@redhat.com>
 443
 444         PR c++/24367
 445         * cp-support.c (inspect_type): Don't attempt substitutions
 446         of symbol with the same name.
 447
 448 2019-04-25  Tom Tromey  <tromey@adacore.com>
 449
 450         PR gdb/24475:
 451         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 452         static.
 453
 454 2019-04-25  Tom Tromey  <tromey@adacore.com>
 455
 456         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 457         rvalue reference.
 458         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 459         (gdb_xml_parser::parse): Use std::move.
 460         * python/python-internal.h (gdbpy_convert_exception): Take a const
 461         reference.
 462         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 463         std::move.
 464         * python/py-utils.c (gdbpy_convert_exception): Take a const
 465         reference.
 466         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 467         Use std::move.
 468         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 469         Use std::move.
 470         * mi/mi-main.c (mi_print_exception): Take a const reference.
 471         * main.c (handle_command_errors): Take a const reference.
 472         * linespec.c (parse_linespec): Use std::move.
 473         * infcall.c (run_inferior_call): Use std::move.
 474         (call_function_by_hand_dummy): Use std::move.
 475         * exec.c (try_open_exec_file): Use std::move.
 476         * exceptions.h (exception_print, exception_fprintf)
 477         (exception_print_same): Update.
 478         * exceptions.c (print_exception, exception_print)
 479         (exception_fprintf, exception_print_same): Change parameters to
 480         const reference.
 481         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 482         * common/new-op.c: Use std::move.
 483         * common/common-exceptions.h (struct gdb_exception): Add move
 484         constructor.
 485         (struct gdb_exception_error, struct gdb_exception_quit, struct
 486         gdb_quit_bad_alloc): Change constructor to move constructor.
 487         (throw_exception): Change parameter to rvalue reference.
 488         * common/common-exceptions.c (throw_exception): Take rvalue
 489         reference.
 490         * cli/cli-interp.c (safe_execute_command): Use std::move.
 491         * breakpoint.c (insert_bp_location, location_to_sals): Use
 492         std::move.
 493
 494 2019-04-25  Tom Tromey  <tromey@adacore.com>
 495
 496         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 497         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 498         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 499         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 500         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 501         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 502         guile/scm-value.c: Use unpack.
 503         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 504         gdbscm_gdb_exception.
 505         (gdbscm_throw_gdb_exception): Likewise.
 506         (struct gdbscm_gdb_exception): New.
 507         (unpack): New function.
 508         (gdbscm_wrap): Use unpack.
 509
 510 2019-04-25  Tom Tromey  <tromey@adacore.com>
 511
 512         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 513         (gdb_rl_callback_handler): Use std::move.
 514         * common/common-exceptions.h (struct gdb_exception): Add move
 515         assignment operator.
 516         (throw_exception_sjlj): Change "exception" to const reference.
 517         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 518         (throw_exception_sjlj): Change "exception" to const reference.
 519
 520 2019-04-25  Tom Tromey  <tromey@adacore.com>
 521
 522         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 523         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 524         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 525         Update.
 526         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 527         Update.
 528         * mi/mi-interp.c (mi_interp::exec): Update.
 529         * linespec.c (parse_linespec): Update.
 530         * infcall.c (run_inferior_call): Update.
 531         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 532         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 533         (gdbscm_lookup_global_symbol): Update.
 534         * guile/scm-param.c (gdbscm_parameter_value): Update.
 535         * guile/scm-frame.c (gdbscm_frame_read_register)
 536         (gdbscm_frame_read_var): Update.
 537         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 538         * exec.c (try_open_exec_file): Update.
 539         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 540         (gdb_rl_callback_handler): Update.
 541         * common/common-exceptions.h (exception_none): Don't declare.
 542         * common/common-exceptions.c (exception_none): Don't define.
 543         (struct catcher) <exception>: Update.
 544         * cli/cli-interp.c (safe_execute_command): Update.
 545         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 546
 547 2019-04-25  Ali Tamur  <tamur@google.com>
 548
 549         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 550         (read_attribute_value): Likewise.
 551         (dwarf2_read_addr_index): Update comment.
 552         (read_str_index): Add DW_FORM_strx.
 553         (dwarf2_string_attr): Likewise.
 554         (dwarf2_const_value_attr): Likewise.
 555         (dump_die_shallow): Likewise.
 556         (dwarf2_fetch_constant_bytes): Likewise.
 557         (skip_form_bytes): Likewise.
 558         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 559
 560 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 561
 562         PR corefiles/11608
 563         PR corefiles/18187
 564         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 565         OFFSET.  Verify if current mapping contains an ELF header.
 566         (linux_find_memory_regions_full): Adjust call to
 567         dump_mapping_p.
 568
 569 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 570             Kang Li <kanglictf@gmail.com>
 571
 572         PR gdb/21600
 573
 574         * dwarf2-frame.c (read_initial_length): Be consistent about using
 575         unsigned representation of length.
 576         (decode_frame_entry_1): Likewise.  Check for wraparound of
 577         end pointer as well as buffer overflow.
 578
 579 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 580
 581         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 582         "vq".
 583
 584 2019-04-24  Tom Tromey  <tromey@adacore.com>
 585
 586         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 587
 588 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 589
 590         * s12z-tdep.c (s12z_unwind_pc): Delete.
 591         (s12z_unwind_sp): Delete.
 592         (s12z_gdbarch_init): Don't register deleted functions with
 593         gdbarch.
 594
 595 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 596
 597         * rl78-tdep.c (rl78_unwind_sp): Delete.
 598         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 599
 600 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 601
 602         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 603         (xstormy16_unwind_pc): Delete.
 604         (xstormy16_dummy_id): Delete.
 605         (xstormy16_gdbarch_init): Don't register deleted functions with
 606         gdbarch.
 607
 608 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 609
 610         * vax-tdep.c (vax_unwind_pc): Delete.
 611         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 612
 613 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 614
 615         * v850-tdep.c (v850_unwind_sp): Delete.
 616         (v850_unwind_pc): Delete.
 617         (v850_dummy_id): Delete.
 618         (v850_gdbarch_init): Don't register deleted functions with
 619         gdbarch.
 620
 621 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 622
 623         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 624         (tilegx_unwind_pc): Delete.
 625         (tilegx_unwind_dummy_id): Delete.
 626         (tilegx_gdbarch_init): Don't register deleted functions with
 627         gdbarch.
 628
 629 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 630
 631         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 632         (tic6x_dummy_id): Delete.
 633         (tic6x_gdbarch_init): Don't register deleted functions with
 634         gdbarch.
 635
 636 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 637
 638         * sparc-tdep.c (sparc_unwind_pc): Delete.
 639         (sparc32_gdbarch_init): Don't register deleted function with
 640         gdbarch.
 641
 642 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 643
 644         * sh-tdep.c (sh_unwind_sp): Delete.
 645         (sh_unwind_pc): Delete.
 646         (sh_dummy_id): Delete.
 647         (sh_gdbarch_init): Don't register deleted functions with
 648         gdbarch.
 649
 650 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 651
 652         * score-tdep.c (score_unwind_sp): Delete.
 653         (score_unwind_pc): Delete.
 654         (score_dummy_id): Delete.
 655         (score_gdbarch_init): Don't register deleted functions with
 656         gdbarch.
 657
 658 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 659
 660         * rx-tdep.c (rx_unwind_pc): Delete.
 661         (rx_unwind_sp): Delete.
 662         (rx_dummy_id): Delete.
 663         (rx_gdbarch_init): Don't register deleted functions with
 664         gdbarch.  Update comment.
 665
 666 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 667
 668         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 669         (rs6000_dummy_id): Delete.
 670         (rs6000_gdbarch_init): Don't register deleted functions with
 671         gdbarch.
 672
 673 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 674
 675         * or1k-tdep.c (or1k_dummy_id): Delete.
 676         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 677
 678 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 679
 680         * nios2-tdep.c (nios2_dummy_id): Delete.
 681         (nios2_unwind_sp): Delete.
 682         (nios2_gdbarch_init): Don't register deleted functions with
 683         gdbarch.
 684
 685 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 686
 687         * nds32-tdep.c (nds32_dummy_id): Delete.
 688         (nds32_unwind_pc): Delete.
 689         (nds32_unwind_sp): Delete.
 690         (nds32_gdbarch_init): Don't register deleted functions with
 691         gdbarch.
 692
 693 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 694
 695         * msp430-tdep.c (msp430_unwind_pc): Delete.
 696         (msp430_unwind_sp): Delete.
 697         (msp430_dummy_id): Delete.
 698         (msp430_gdbarch_init): Don't register deleted functions with
 699         gdbarch.
 700
 701 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 702
 703         * moxie-tdep.c (moxie_unwind_sp): Delete.
 704         (moxie_unwind_pc): Delete.
 705         (moxie_dummy_id): Delete.
 706         (moxie_gdbarch_init): Don't register deleted functions with
 707         gdbarch.
 708
 709 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 710
 711         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 712         (mn10300_unwind_pc): Delete.
 713         (mn10300_unwind_sp): Delete.
 714         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 715         mn10300_unwind_sp.
 716         (mn10300_frame_unwind_init): Don't register deleted functions with
 717         gdbarch.
 718
 719 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 720
 721         * mep-tdep.c (mep_unwind_pc): Delete.
 722         (mep_unwind_sp): Delete.
 723         (mep_dummy_id): Delete.
 724         (mep_gdbarch_init): Don't register deleted functions with
 725         gdbarch.
 726
 727 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 728
 729         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 730         (m68hc11_unwind_sp): Delete.
 731         (m68hc11_gdbarch_init): Don't register deleted functions with
 732         gdbarch.
 733
 734 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 735
 736         * m32r-tdep.c (m32r_unwind_sp): Delete.
 737         (m32r_unwind_pc): Delete.
 738         (m32r_dummy_id): Delete.
 739         (m32r_gdbarch_init): Don't register deleted functions with
 740         gdbarch.
 741
 742 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 743
 744         * m32c-tdep.c (m32c_unwind_pc): Delete.
 745         (m32c_unwind_sp): Delete.
 746         (m32c_dummy_id): Delete.
 747         (m32c_gdbarch_init): Don't register deleted functions with
 748         gdbarch.
 749
 750 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 751
 752         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 753         (lm32_unwind_pc): Delete.
 754         (lm32_dummy_id): Delete.
 755         (lm32_gdbarch_init): Don't register deleted functions with
 756         gdbarch.
 757
 758 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 759
 760         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 761         (iq2000_unwind_pc): Delete.
 762         (iq2000_dummy_id): Delete.
 763         (iq2000_gdbarch_init): Don't register deleted functions with
 764         gdbarch.
 765
 766 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 767
 768         * nds32-tdep.c (nds32_type_align): Delete.
 769         (nds32_push_dummy_call): Use type_align instead.
 770
 771 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 772
 773         * arm-tdep.c (arm_type_align): Only handle vector override case.
 774         (arm_push_dummy_call): Use type_align.
 775         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 776
 777 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 778
 779         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 780         case.
 781         (pass_on_stack): Use type_align.
 782         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 783         function.
 784
 785 2019-04-23  Tom Tromey  <tromey@adacore.com>
 786
 787         * dwarf2read.c (line_header::file_name_at): Remove unused
 788         overload.
 789
 790 2019-04-23  Tom de Vries  <tdevries@suse.de>
 791
 792         PR gdb/24438
 793         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 794         invocation.
 795
 796
 797 2019-03-27  Ali Tamur  <tamur@google.com>
 798
 799         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 800         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 801         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 802         (dwarf_expr_context::get_addr_index): Likewise
 803         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 804         (symbol_needs_eval_context::get_addr_index): Likewise
 805         (disassemble_dwarf_expression): Add DW_OP_addrx
 806         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 807         (read_cutu_die_from_dwo): Update comment
 808         (skip_one_die): Add DW_FORM_addrx
 809         (read_attribute_value): Likewise
 810         (var_decode_location): Add DW_OP_addrx
 811         (dwarf2_const_value_attr): Add DW_FORM_addrx
 812         (dump_die_shallow): Likewise
 813         (dwarf2_fetch_constant_bytes): Likewise
 814         (decode_locdesc): Add DW_OP_addrx
 815         (skip_form_bytes): Add DW_FORM_addrx
 816
 817 2019-04-22  Ali Tamur  <tamur@google.com>
 818
 819         * MAINTAINERS (Write After Approval): Add self.
 820
 821 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 822
 823         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 824         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 825         (open_symbol_file_object): Likewise.
 826         (svr4_default_sos): Add info parameter.
 827         (svr4_read_so_list): Likewise.
 828         (svr4_current_sos_direct): Adjust functions calls to pass down
 829         info.
 830         (svr4_current_sos_1): Add info parameter.
 831         (svr4_current_sos): Call get_svr4_info, pass info down to
 832         svr4_current_sos_1.
 833         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 834         get_svr4_info.
 835         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 836         get_svr4_info.
 837         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 838         to get_svr4_info.
 839         (probes_table_remove_objfile_probes): Likewise.
 840         (register_solib_event_probe): Add info parameter.
 841         (solist_update_incremental): Pass info parameter down to
 842         svr4_read_so_list.
 843         (disable_probes_interface): Add info parameter.
 844         (svr4_handle_solib_event): Pass current_program_space to
 845         get_svr4_info.  Adjust disable_probes_interface cleanup.
 846         (svr4_create_probe_breakpoints): Add info parameter, pass it
 847         down to register_solib_event_probe.
 848         (svr4_create_solib_event_breakpoints): Add info parameter,
 849         pass it down to svr4_create_probe_breakpoints.
 850         (enable_break): Pass info down to
 851         svr4_create_solib_event_breakpoints.
 852         (svr4_solib_create_inferior_hook): Pass current_program_space to
 853         get_svr4_info.
 854         (svr4_clear_solib): Likewise.
 855
 856 2019-04-22  Pedro Alves  <palves@redhat.com>
 857
 858         * solib-svr4.c (svr4_free_objfile_observer): New.
 859         (probe_and_action::objfile): New field.
 860         (probes_table_htab_remove_objfile_probes)
 861         (probes_table_remove_objfile_probes): New functions.
 862         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 863         in the new probe_and_action.  Don't store the probe in 'lookup'.
 864         (svr4_create_probe_breakpoints): Pass objfile to
 865         register_solib_event_probe.
 866         (_initialize_svr4_solib): Register a free_objfile observer.
 867
 868 2019-04-19  Tom Tromey  <tom@tromey.com>
 869
 870         * common/queue.h: Remove.
 871
 872 2019-04-19  Tom Tromey  <tom@tromey.com>
 873
 874         * event-loop.c: Don't include "common/queue.h".
 875
 876 2019-04-19  Tom Tromey  <tom@tromey.com>
 877
 878         * remote.c (remote_target): Use delete.
 879         * remote-notif.h: Include <list>, not "common/queue.h".
 880         (notif_client_p): Remove typedef.
 881         (remote_notif_state): Add constructor, destructor, initializer.
 882         <notif_queue>: Now a std::list.
 883         (remote_notif_state_xfree): Don't declare.
 884         * remote-notif.c (remote_notif_process, handle_notification)
 885         (remote_notif_state_allocate): Update.
 886         (~remote_notif_state): Rename from remote_notif_state_xfree.
 887
 888 2019-04-19  Tom Tromey  <tom@tromey.com>
 889
 890         * symfile.c (reread_symbols): Update.
 891         * objfiles.c (objfile_register_static_link)
 892         (objfile_lookup_static_link): Update
 893         (~objfile) Don't delete static_links.
 894         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 895
 896 2019-04-19  Tom Tromey  <tom@tromey.com>
 897
 898         * type-stack.h (struct type_stack) <insert>: Constify string.
 899         * type-stack.c (type_stack::insert): Constify string.
 900         * gdbtypes.h (lookup_template_type): Update.
 901         (address_space_name_to_int): Update.
 902         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 903         const.
 904         (lookup_template_type): Make name const.
 905         * c-exp.y: Update rules.
 906         (lex_one_token, classify_name, classify_inner_name)
 907         (c_print_token): Update.
 908         * p-exp.y: Update rules.
 909         (yylex): Update.
 910         * f-exp.y: Update rules.
 911         (yylex): Update.
 912         * d-exp.y: Update rules.
 913         (lex_one_token, classify_name, classify_inner_name): Update.
 914         * parse.c (write_dollar_variable, copy_name): Return std::string.
 915         * parser-defs.h (copy_name): Change return type.
 916         * m2-exp.y: Update rules.
 917         (yylex): Update.
 918         * go-exp.y (lex_one_token): Update.
 919         Update rules.
 920         (classify_unsafe_function, classify_packaged_name)
 921         (classify_name, yylex): Update.
 922
 923 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 924
 925         * configure.ac: add --enable-source-highlight switch.
 926         * configure: Regenerate.
 927         * top.c (print_gdb_version): plumb --enable-source-highlight
 928         status to "show configuration".
 929
 930 2019-04-19  Tom Tromey  <tromey@adacore.com>
 931
 932         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 933         Check ADA_TYPE_P.
 934         (empty_record, ada_template_to_fixed_record_type_1)
 935         (template_to_static_fixed_type)
 936         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 937         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 938         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 939         macros.
 940
 941 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 942
 943         PR symtab/24423:
 944         * source.c (print_source_lines_base): Advance "iter" when a
 945         control character is seen.
 946
 947 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 948
 949         * inferior.h (struct infcall_suspend_state_deleter):
 950         Catch exception in destructor to avoid crash.
 951
 952 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 953
 954         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 955         close to the add_com "shell".
 956
 957 2019-04-18  Tom Tromey  <tromey@adacore.com>
 958
 959         * process-stratum-target.h (class process_stratum_target)
 960         <stratum>: Add "final".
 961
 962 2019-04-17  Tom Tromey  <tromey@adacore.com>
 963
 964         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 965         against nullptr before use.
 966
 967 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 968
 969         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 970
 971 2019-04-17  Jim Wilson  <jimw@sifive.com>
 972             Andrew Burgess  <andrew.burgess@embecosm.com>
 973
 974         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 975         code read might fail, assume 4-byte breakpoint in that case.
 976
 977 2019-04-15  Leszek Swirski  <leszeks@google.com>
 978
 979         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 980         rather than a hand-rolled POD check when checking for forced MEMORY
 981         classification.
 982
 983 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 984
 985         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 986         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 987         function.
 988         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 989         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 990         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 991         declaration.
 992
 993 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 994
 995         * aarch64-linux-nat.c
 996         (aarch64_linux_nat_target::thread_architecture): Add override.
 997         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 998         each VQ.
 999
1000 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1001
1002         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1003
1004 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1005
1006         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1007         target types of size 96-bits, add some additional comments, and
1008         check that the builtin type we found was the correct size.
1009
1010 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1011
1012         * utils.c (prompt_for_continue): Don't restore the styling at the
1013         end, as applied_style has the wrong value.  This fixes styling in
1014         long lists of file names that are interrupted by the "Continue?"
1015         prompt.
1016
1017 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1018
1019         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1020         * c-lang.c (c_language_defn): Likewise.
1021         (cplus_language_defn): Likewise.
1022         (asm_language_defn): Likewise.
1023         (minimal_language_defn): Likewise.
1024         * d-lang.c (d_language_defn): Likewise.
1025         * f-lang.c (f_language_defn): Likewise.
1026         * go-lang.c (go_language_defn): Likewise.
1027         * language.c (unknown_language_defn): Likewise.
1028         (auto_language_defn): Likewise.
1029         * language.h (struct language_defn): Remove la_magic field.
1030         (LANG_MAGIC): Delete.
1031         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1032         * objc-lang.c (objc_language_defn): Likewise.
1033         * opencl-lang.c (opencl_language_defn): Likewise.
1034         * p-lang.c (pascal_language_defn): Likewise.
1035         * rust-lang.c (rust_language_defn): Likewise.
1036
1037 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1038
1039         * riscv-tdep.c (riscv_type_align): New function.
1040         (riscv_type_alignment): Delete.
1041         (riscv_arg_location): Use 'type_align'.
1042         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1043
1044 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1045
1046         * gdbtypes.c (type_align): A struct with no non-static fields also
1047         has alignment of 1.
1048
1049 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1050
1051         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1052         component to 0.
1053         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1054         member.
1055         (riscv_struct_info::analyse): New implementation using new
1056         analyse_inner member function.
1057         (riscv_struct_info::field_offset): New member function.
1058         (riscv_struct_info::m_offsets): New member variable.
1059         (riscv_struct_info::analyse_inner): New private member function,
1060         takes the old implementation of riscv_struct_info::analyse but
1061         extended to track field offsets.
1062         (riscv_call_arg_struct): Update the struct folding special cases
1063         to handle cases where empty C++ structs, which are non-zero
1064         length, are found.
1065         (riscv_arg_location): Initialise the length of each location, a
1066         non-zero length now indicates the location is in use.
1067         (riscv_push_dummy_call): Allow for the first location having a
1068         non-zero offset when setting up arguments.
1069         (riscv_return_value): Likewise, but for return values.
1070
1071 2019-04-11  Tom Tromey  <tromey@adacore.com>
1072
1073         * utils.c (internal_vproblem): Make "msg" const.
1074
1075 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1076
1077         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1078         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1079         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1080         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1081
1082 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1083
1084         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1085         function.
1086         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1087         of amd64_collect_native_gregset.
1088         (amd64_linux_nat_target::store_registers): Likewise.
1089
1090 2019-04-10  Tom Tromey  <tom@tromey.com>
1091
1092         * symtab.c (lookup_global_symbol_from_objfile)
1093         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1094         * objfiles.h (class separate_debug_iterator): New.
1095         (class separate_debug_range): New.
1096         (struct objfile) <separate_debug_objfiles>: New method.
1097         (objfile_separate_debug_iterate): Don't declare.
1098         * objfiles.c (separate_debug_iterator::operator++): Rename from
1099         objfile_separate_debug_iterate.
1100         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1101         iterator.
1102         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1103         iterator.
1104
1105 2019-04-10  Tom Tromey  <tom@tromey.com>
1106
1107         * symfile.c (reread_symbols): Remove old comment.
1108         * objfiles.c (free_all_objfiles): Fix a typo.
1109
1110 2019-04-10  Tom Tromey  <tom@tromey.com>
1111
1112         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1113         * minsyms.c (lookup_minimal_symbol): Use foreach.
1114         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1115         (lookup_minimal_symbol_solib_trampoline): Likewise.
1116         * symfile.c (reread_symbols): Use foreach.
1117
1118 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1119             Tom Tromey  <tromey@adacore.com>
1120
1121         PR rust/24414:
1122         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1123         (rust_lex_int_test): Change "value" to be LONGEST.
1124         (rust_lex_tests): Add test for long integer literal.
1125
1126 2019-04-09  Tom Tromey  <tromey@adacore.com>
1127
1128         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1129         to bool.
1130         (extended_remote_target::attach): Update.
1131         (remote_target::remote_notice_new_inferior): Update.
1132         (remote_target::add_current_inferior_and_thread): Update.
1133         * inferior.c (exit_inferior_1): Use "false".
1134         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1135
1136 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1137
1138         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1139         the "start" command.
1140
1141 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1142
1143         * python/py-inferior.c (infpy_thread_from_thread_handle):
1144         Adjust comments to reflect renaming of thread_from_thread_handle
1145         to thread_from_handle.  Adjust keywords.  Fix type error message.
1146         (inferior_object_methods): Add thread_from_handle.  Retain
1147         thread_from_thread_handle, but mark it as deprecated.
1148
1149 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1150
1151         * gdbthread.h (find_thread_by_handle): Revise declaration.
1152         * thread.c (find_thread_by_handle): Likewise.  Adjust
1153         implementation too.
1154         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1155         support for buffer objects as handles.
1156
1157 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1158
1159         * python/py-infthread.c (thpy_thread_handle): New function.
1160         (thread_object_methods): Register thpy_thread_handle.
1161
1162 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1163
1164         * gdbthread.h (thread_to_thread_handle): Declare.
1165         * thread.c (gdbtypes.h): Include.
1166         (thread_to_thread_handle): New function.
1167
1168         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1169         (target_thread_info_to_thread_handle): Declare.
1170         * target.c (target_thread_info_to_thread_handle): New function.
1171         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1172         * target-delegates.c: Regenerate.
1173
1174         * linux-thread-db.c (class thread_db_target): Add method
1175         thread_info_to_thread_handle.
1176         (thread_db_target::thread_info_to_thread_handle): Define.
1177         * remote.c (class remote_target): Add new method
1178         thread_info_to_thread_handle.
1179         (remote_target::thread_info_to_thread_handle): Define.
1180
1181 2019-04-08  Pedro Alves  <palves@redhat.com>
1182
1183         * common/common-exceptions.c (throw_exception): Don't create
1184         named object to throw; throw directly.
1185         (throw_it): Likewise.  Don't initialize gdb_exception::message
1186         here, with new; pass FMT and AP to the ctor instead.
1187         * common/common-exceptions.h: Include <string>.
1188         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1189         const char *, va_list)): New ctor.  Use std::make_shared.
1190         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1191         errors)): Delete.
1192         (gdb_exception_error::gdb_exception_error(enum errors, const char
1193         *, va_list)): New.
1194         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1195         Add assertion.
1196         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1197         errors)): Delete.
1198         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1199         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1200         Add assertion.
1201
1202 2019-04-08  Tom Tromey  <tom@tromey.com>
1203
1204         * valops.c (value_rtti_indirect_type): Replace throw_exception
1205         with throw.
1206         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1207         with throw.
1208         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1209         throw.
1210         * target.c (target_translate_tls_address): Replace throw_exception
1211         with throw.
1212         * stack.c (frame_apply_command_count): Replace throw_exception
1213         with throw.
1214         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1215         throw.
1216         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1217         with throw.
1218         * rs6000-tdep.c (rs6000_frame_cache)
1219         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1220         * remote.c: Replace throw_exception with throw.
1221         * record-full.c (record_full_message, record_full_wait_1)
1222         (record_full_restore): Replace throw_exception with throw.
1223         * record-btrace.c:
1224         (get_thread_current_frame_id, record_btrace_start_replaying)
1225         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1226         (cmd_record_btrace_start): Replace throw_exception with throw.
1227         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1228         throw.
1229         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1230         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1231         * linespec.c:
1232         (find_linespec_symbols): Replace throw_exception with throw.
1233         * infrun.c (displaced_step_prepare, resume): Replace
1234         throw_exception with throw.
1235         * infcmd.c (post_create_inferior): Replace throw_exception with
1236         throw.
1237         * inf-loop.c (inferior_event_handler): Replace throw_exception
1238         with throw.
1239         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1240         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1241         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1242         (get_prev_frame_always, get_frame_pc_if_available)
1243         (get_frame_address_in_block_if_available, get_frame_language):
1244         Replace throw_exception with throw.
1245         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1246         throw_exception with throw.
1247         * eval.c (fetch_subexp_value, evaluate_var_value)
1248         (evaluate_funcall, evaluate_subexp_standard): Replace
1249         throw_exception with throw.
1250         * dwarf2loc.c (call_site_find_chain)
1251         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1252         Replace throw_exception with throw.
1253         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1254         with throw.
1255         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1256         throw.
1257         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1258         * completer.c (complete_line_internal): Replace throw_exception
1259         with throw.
1260         * compile/compile-object-run.c (compile_object_run): Replace
1261         throw_exception with throw.
1262         * cli/cli-script.c (process_next_line): Replace throw_exception
1263         with throw.
1264         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1265         (btrace_enable, btrace_maint_update_pt_packets): Replace
1266         throw_exception with throw.
1267         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1268         throw_exception with throw.
1269         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1270         throw_exception with throw.
1271         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1272         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1273         * aarch64-tdep.c (aarch64_make_prologue_cache)
1274         (aarch64_make_stub_cache): Replace throw_exception with throw.
1275
1276 2019-04-08  Tom Tromey  <tom@tromey.com>
1277
1278         * common/common-exceptions.c (throw_exception): Rename from
1279         throw_exception_cxx.  Remove old copy.  Make argument const.
1280         (throw_it): Create and throw exception objects directly.
1281         * common/common-exceptions.h (throw_exception): Make argument
1282         const.
1283         (struct gdb_exception_error): Add constructor.
1284         (struct gdb_exception_quit): Add constructor.
1285
1286 2019-04-08  Tom Tromey  <tom@tromey.com>
1287
1288         * common/common-exceptions.h (exception_rethrow): Don't declare.
1289         (TRY_SJLJ): Update comment.
1290         (TRY, CATCH, END_CATCH): Remove.
1291         * common/common-exceptions.c (exception_rethrow): Remove.
1292
1293 2019-04-08  Tom Tromey  <tom@tromey.com>
1294
1295         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1296         Remove.
1297         (gdb_exception_error): Rename from
1298         gdb_exception_RETURN_MASK_ERROR.
1299         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1300         (gdb_quit_bad_alloc): Update.
1301         * aarch64-tdep.c: Update.
1302         * ada-lang.c: Update.
1303         * ada-typeprint.c: Update.
1304         * ada-valprint.c: Update.
1305         * amd64-tdep.c: Update.
1306         * arch-utils.c: Update.
1307         * break-catch-throw.c: Update.
1308         * breakpoint.c: Update.
1309         * btrace.c: Update.
1310         * c-varobj.c: Update.
1311         * cli/cli-cmds.c: Update.
1312         * cli/cli-interp.c: Update.
1313         * cli/cli-script.c: Update.
1314         * common/common-exceptions.c: Update.
1315         * common/new-op.c: Update.
1316         * common/selftest.c: Update.
1317         * compile/compile-c-symbols.c: Update.
1318         * compile/compile-cplus-symbols.c: Update.
1319         * compile/compile-object-load.c: Update.
1320         * compile/compile-object-run.c: Update.
1321         * completer.c: Update.
1322         * corelow.c: Update.
1323         * cp-abi.c: Update.
1324         * cp-support.c: Update.
1325         * cp-valprint.c: Update.
1326         * darwin-nat.c: Update.
1327         * disasm-selftests.c: Update.
1328         * dtrace-probe.c: Update.
1329         * dwarf-index-cache.c: Update.
1330         * dwarf-index-write.c: Update.
1331         * dwarf2-frame-tailcall.c: Update.
1332         * dwarf2-frame.c: Update.
1333         * dwarf2loc.c: Update.
1334         * dwarf2read.c: Update.
1335         * eval.c: Update.
1336         * event-loop.c: Update.
1337         * event-top.c: Update.
1338         * exec.c: Update.
1339         * f-valprint.c: Update.
1340         * fbsd-tdep.c: Update.
1341         * frame-unwind.c: Update.
1342         * frame.c: Update.
1343         * gdbtypes.c: Update.
1344         * gnu-v3-abi.c: Update.
1345         * guile/guile-internal.h: Update.
1346         * guile/scm-block.c: Update.
1347         * guile/scm-breakpoint.c: Update.
1348         * guile/scm-cmd.c: Update.
1349         * guile/scm-disasm.c: Update.
1350         * guile/scm-frame.c: Update.
1351         * guile/scm-lazy-string.c: Update.
1352         * guile/scm-math.c: Update.
1353         * guile/scm-param.c: Update.
1354         * guile/scm-ports.c: Update.
1355         * guile/scm-pretty-print.c: Update.
1356         * guile/scm-symbol.c: Update.
1357         * guile/scm-symtab.c: Update.
1358         * guile/scm-type.c: Update.
1359         * guile/scm-value.c: Update.
1360         * i386-linux-tdep.c: Update.
1361         * i386-tdep.c: Update.
1362         * inf-loop.c: Update.
1363         * infcall.c: Update.
1364         * infcmd.c: Update.
1365         * infrun.c: Update.
1366         * jit.c: Update.
1367         * language.c: Update.
1368         * linespec.c: Update.
1369         * linux-fork.c: Update.
1370         * linux-nat.c: Update.
1371         * linux-tdep.c: Update.
1372         * linux-thread-db.c: Update.
1373         * main.c: Update.
1374         * mi/mi-cmd-break.c: Update.
1375         * mi/mi-cmd-stack.c: Update.
1376         * mi/mi-interp.c: Update.
1377         * mi/mi-main.c: Update.
1378         * objc-lang.c: Update.
1379         * p-valprint.c: Update.
1380         * parse.c: Update.
1381         * ppc-linux-tdep.c: Update.
1382         * printcmd.c: Update.
1383         * python/py-arch.c: Update.
1384         * python/py-breakpoint.c: Update.
1385         * python/py-cmd.c: Update.
1386         * python/py-finishbreakpoint.c: Update.
1387         * python/py-frame.c: Update.
1388         * python/py-framefilter.c: Update.
1389         * python/py-gdb-readline.c: Update.
1390         * python/py-inferior.c: Update.
1391         * python/py-infthread.c: Update.
1392         * python/py-lazy-string.c: Update.
1393         * python/py-linetable.c: Update.
1394         * python/py-objfile.c: Update.
1395         * python/py-param.c: Update.
1396         * python/py-prettyprint.c: Update.
1397         * python/py-progspace.c: Update.
1398         * python/py-record-btrace.c: Update.
1399         * python/py-record.c: Update.
1400         * python/py-symbol.c: Update.
1401         * python/py-type.c: Update.
1402         * python/py-unwind.c: Update.
1403         * python/py-utils.c: Update.
1404         * python/py-value.c: Update.
1405         * python/python.c: Update.
1406         * record-btrace.c: Update.
1407         * record-full.c: Update.
1408         * remote-fileio.c: Update.
1409         * remote.c: Update.
1410         * riscv-tdep.c: Update.
1411         * rs6000-aix-tdep.c: Update.
1412         * rs6000-tdep.c: Update.
1413         * rust-exp.y: Update.
1414         * rust-lang.c: Update.
1415         * s390-tdep.c: Update.
1416         * selftest-arch.c: Update.
1417         * solib-dsbt.c: Update.
1418         * solib-frv.c: Update.
1419         * solib-spu.c: Update.
1420         * solib-svr4.c: Update.
1421         * solib.c: Update.
1422         * sparc64-linux-tdep.c: Update.
1423         * stack.c: Update.
1424         * symfile-mem.c: Update.
1425         * symmisc.c: Update.
1426         * target.c: Update.
1427         * thread.c: Update.
1428         * top.c: Update.
1429         * tracefile-tfile.c: Update.
1430         * tui/tui.c: Update.
1431         * typeprint.c: Update.
1432         * unittests/cli-utils-selftests.c: Update.
1433         * unittests/parse-connection-spec-selftests.c: Update.
1434         * valops.c: Update.
1435         * valprint.c: Update.
1436         * value.c: Update.
1437         * varobj.c: Update.
1438         * windows-nat.c: Update.
1439         * x86-linux-nat.c: Update.
1440         * xml-support.c: Update.
1441
1442 2019-04-08  Tom Tromey  <tom@tromey.com>
1443
1444         * xml-support.c: Use C++ exception handling.
1445         * x86-linux-nat.c: Use C++ exception handling.
1446         * windows-nat.c: Use C++ exception handling.
1447         * varobj.c: Use C++ exception handling.
1448         * value.c: Use C++ exception handling.
1449         * valprint.c: Use C++ exception handling.
1450         * valops.c: Use C++ exception handling.
1451         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1452         handling.
1453         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1454         * typeprint.c: Use C++ exception handling.
1455         * tui/tui.c: Use C++ exception handling.
1456         * tracefile-tfile.c: Use C++ exception handling.
1457         * top.c: Use C++ exception handling.
1458         * thread.c: Use C++ exception handling.
1459         * target.c: Use C++ exception handling.
1460         * symmisc.c: Use C++ exception handling.
1461         * symfile-mem.c: Use C++ exception handling.
1462         * stack.c: Use C++ exception handling.
1463         * sparc64-linux-tdep.c: Use C++ exception handling.
1464         * solib.c: Use C++ exception handling.
1465         * solib-svr4.c: Use C++ exception handling.
1466         * solib-spu.c: Use C++ exception handling.
1467         * solib-frv.c: Use C++ exception handling.
1468         * solib-dsbt.c: Use C++ exception handling.
1469         * selftest-arch.c: Use C++ exception handling.
1470         * s390-tdep.c: Use C++ exception handling.
1471         * rust-lang.c: Use C++ exception handling.
1472         * rust-exp.y: Use C++ exception handling.
1473         * rs6000-tdep.c: Use C++ exception handling.
1474         * rs6000-aix-tdep.c: Use C++ exception handling.
1475         * riscv-tdep.c: Use C++ exception handling.
1476         * remote.c: Use C++ exception handling.
1477         * remote-fileio.c: Use C++ exception handling.
1478         * record-full.c: Use C++ exception handling.
1479         * record-btrace.c: Use C++ exception handling.
1480         * python/python.c: Use C++ exception handling.
1481         * python/py-value.c: Use C++ exception handling.
1482         * python/py-utils.c: Use C++ exception handling.
1483         * python/py-unwind.c: Use C++ exception handling.
1484         * python/py-type.c: Use C++ exception handling.
1485         * python/py-symbol.c: Use C++ exception handling.
1486         * python/py-record.c: Use C++ exception handling.
1487         * python/py-record-btrace.c: Use C++ exception handling.
1488         * python/py-progspace.c: Use C++ exception handling.
1489         * python/py-prettyprint.c: Use C++ exception handling.
1490         * python/py-param.c: Use C++ exception handling.
1491         * python/py-objfile.c: Use C++ exception handling.
1492         * python/py-linetable.c: Use C++ exception handling.
1493         * python/py-lazy-string.c: Use C++ exception handling.
1494         * python/py-infthread.c: Use C++ exception handling.
1495         * python/py-inferior.c: Use C++ exception handling.
1496         * python/py-gdb-readline.c: Use C++ exception handling.
1497         * python/py-framefilter.c: Use C++ exception handling.
1498         * python/py-frame.c: Use C++ exception handling.
1499         * python/py-finishbreakpoint.c: Use C++ exception handling.
1500         * python/py-cmd.c: Use C++ exception handling.
1501         * python/py-breakpoint.c: Use C++ exception handling.
1502         * python/py-arch.c: Use C++ exception handling.
1503         * printcmd.c: Use C++ exception handling.
1504         * ppc-linux-tdep.c: Use C++ exception handling.
1505         * parse.c: Use C++ exception handling.
1506         * p-valprint.c: Use C++ exception handling.
1507         * objc-lang.c: Use C++ exception handling.
1508         * mi/mi-main.c: Use C++ exception handling.
1509         * mi/mi-interp.c: Use C++ exception handling.
1510         * mi/mi-cmd-stack.c: Use C++ exception handling.
1511         * mi/mi-cmd-break.c: Use C++ exception handling.
1512         * main.c: Use C++ exception handling.
1513         * linux-thread-db.c: Use C++ exception handling.
1514         * linux-tdep.c: Use C++ exception handling.
1515         * linux-nat.c: Use C++ exception handling.
1516         * linux-fork.c: Use C++ exception handling.
1517         * linespec.c: Use C++ exception handling.
1518         * language.c: Use C++ exception handling.
1519         * jit.c: Use C++ exception handling.
1520         * infrun.c: Use C++ exception handling.
1521         * infcmd.c: Use C++ exception handling.
1522         * infcall.c: Use C++ exception handling.
1523         * inf-loop.c: Use C++ exception handling.
1524         * i386-tdep.c: Use C++ exception handling.
1525         * i386-linux-tdep.c: Use C++ exception handling.
1526         * guile/scm-value.c: Use C++ exception handling.
1527         * guile/scm-type.c: Use C++ exception handling.
1528         * guile/scm-symtab.c: Use C++ exception handling.
1529         * guile/scm-symbol.c: Use C++ exception handling.
1530         * guile/scm-pretty-print.c: Use C++ exception handling.
1531         * guile/scm-ports.c: Use C++ exception handling.
1532         * guile/scm-param.c: Use C++ exception handling.
1533         * guile/scm-math.c: Use C++ exception handling.
1534         * guile/scm-lazy-string.c: Use C++ exception handling.
1535         * guile/scm-frame.c: Use C++ exception handling.
1536         * guile/scm-disasm.c: Use C++ exception handling.
1537         * guile/scm-cmd.c: Use C++ exception handling.
1538         * guile/scm-breakpoint.c: Use C++ exception handling.
1539         * guile/scm-block.c: Use C++ exception handling.
1540         * guile/guile-internal.h: Use C++ exception handling.
1541         * gnu-v3-abi.c: Use C++ exception handling.
1542         * gdbtypes.c: Use C++ exception handling.
1543         * frame.c: Use C++ exception handling.
1544         * frame-unwind.c: Use C++ exception handling.
1545         * fbsd-tdep.c: Use C++ exception handling.
1546         * f-valprint.c: Use C++ exception handling.
1547         * exec.c: Use C++ exception handling.
1548         * event-top.c: Use C++ exception handling.
1549         * event-loop.c: Use C++ exception handling.
1550         * eval.c: Use C++ exception handling.
1551         * dwarf2read.c: Use C++ exception handling.
1552         * dwarf2loc.c: Use C++ exception handling.
1553         * dwarf2-frame.c: Use C++ exception handling.
1554         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1555         * dwarf-index-write.c: Use C++ exception handling.
1556         * dwarf-index-cache.c: Use C++ exception handling.
1557         * dtrace-probe.c: Use C++ exception handling.
1558         * disasm-selftests.c: Use C++ exception handling.
1559         * darwin-nat.c: Use C++ exception handling.
1560         * cp-valprint.c: Use C++ exception handling.
1561         * cp-support.c: Use C++ exception handling.
1562         * cp-abi.c: Use C++ exception handling.
1563         * corelow.c: Use C++ exception handling.
1564         * completer.c: Use C++ exception handling.
1565         * compile/compile-object-run.c: Use C++ exception handling.
1566         * compile/compile-object-load.c: Use C++ exception handling.
1567         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1568         * compile/compile-c-symbols.c: Use C++ exception handling.
1569         * common/selftest.c: Use C++ exception handling.
1570         * common/new-op.c: Use C++ exception handling.
1571         * cli/cli-script.c: Use C++ exception handling.
1572         * cli/cli-interp.c: Use C++ exception handling.
1573         * cli/cli-cmds.c: Use C++ exception handling.
1574         * c-varobj.c: Use C++ exception handling.
1575         * btrace.c: Use C++ exception handling.
1576         * breakpoint.c: Use C++ exception handling.
1577         * break-catch-throw.c: Use C++ exception handling.
1578         * arch-utils.c: Use C++ exception handling.
1579         * amd64-tdep.c: Use C++ exception handling.
1580         * ada-valprint.c: Use C++ exception handling.
1581         * ada-typeprint.c: Use C++ exception handling.
1582         * ada-lang.c: Use C++ exception handling.
1583         * aarch64-tdep.c: Use C++ exception handling.
1584
1585 2019-04-08  Tom Tromey  <tom@tromey.com>
1586
1587         * xml-support.c (gdb_xml_parser::parse): Update.
1588         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1589         * value.c (show_convenience): Update.
1590         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1591         (test_parse_flags_qcs): Update.
1592         * thread.c (thr_try_catch_cmd): Update.
1593         * target.c (target_translate_tls_address): Update.
1594         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1595         (info_frame_command_core, frame_apply_command_count): Update.
1596         * rust-exp.y (rust_lex_exception_test): Update.
1597         * riscv-tdep.c (riscv_print_one_register_info): Update.
1598         * remote.c (remote_target::enable_btrace): Update.
1599         * record-btrace.c (record_btrace_enable_warn): Update.
1600         * python/py-utils.c (gdbpy_convert_exception): Update.
1601         * printcmd.c (do_one_display, print_variable_and_value): Update.
1602         * mi/mi-main.c (mi_print_exception): Update.
1603         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1604         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1605         * linux-nat.c (linux_nat_target::attach): Update.
1606         * linux-fork.c (class scoped_switch_fork_info): Update.
1607         * infrun.c (displaced_step_prepare): Update.
1608         * infcall.c (call_function_by_hand_dummy): Update.
1609         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1610         * gnu-v3-abi.c (print_one_vtable): Update.
1611         * frame.c (get_prev_frame_always): Update.
1612         * f-valprint.c (info_common_command_for_block): Update.
1613         * exec.c (try_open_exec_file): Update.
1614         * exceptions.c (print_exception, exception_print)
1615         (exception_fprintf, exception_print_same): Update.
1616         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1617         * dwarf-index-cache.c (index_cache::store)
1618         (index_cache::lookup_gdb_index): Update.
1619         * darwin-nat.c (maybe_cache_shell): Update.
1620         * cp-valprint.c (cp_print_value_fields): Update.
1621         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1622         (gcc_cplus_symbol_address): Update.
1623         * compile/compile-c-symbols.c (gcc_convert_symbol)
1624         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1625         * common/selftest.c: Update.
1626         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1627         a std::string.
1628         (exception_try_scope_entry, exception_try_scope_exit): Don't
1629         declare.
1630         (struct exception_try_scope): Remove.
1631         (TRY): Don't use exception_try_scope.
1632         (struct gdb_exception): Add constructor, operator=.
1633         <what>: New method.
1634         (struct gdb_exception_RETURN_MASK_ALL)
1635         (struct gdb_exception_RETURN_MASK_ERROR)
1636         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1637         (struct gdb_quit_bad_alloc): Update.
1638         * common/common-exceptions.c (exception_none): Change
1639         initializer.
1640         (struct catcher) <state, exception>: Initialize inline.
1641         <prev>: Remove member.
1642         (current_catcher): Remove.
1643         (catchers): New global.
1644         (exceptions_state_mc_init): Simplify.
1645         (catcher_pop): Remove.
1646         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1647         (try_scope_depth, exception_try_scope_entry)
1648         (exception_try_scope_exit): Remove.
1649         (throw_exception_sjlj): Update.
1650         (exception_messages, exception_messages_size): Remove.
1651         (throw_it): Simplify.
1652         (gdb_exception_sliced_copy): Remove.
1653         (throw_exception_cxx): Update.
1654         * cli/cli-script.c (script_from_file): Update.
1655         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1656         Update.
1657         * ada-valprint.c (ada_val_print): Update.
1658         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1659         (create_excep_cond_exprs): Update.
1660
1661 2019-04-08  Tom Tromey  <tom@tromey.com>
1662
1663         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1664         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1665         (TRY, CATCH, END_CATCH): Remove some definitions.
1666         * common/common-exceptions.c: Don't use GDB_XCPT.
1667         (catcher_list_size): Remove.
1668         (throw_exception, throw_it): Simplify.
1669
1670 2019-04-05  Tom Tromey  <tom@tromey.com>
1671
1672         Revert the header-sorting patch.
1673         * ft32-tdep.c: Revert.
1674         * frv-tdep.c: Revert.
1675         * frv-linux-tdep.c: Revert.
1676         * frame.c: Revert.
1677         * frame-unwind.c: Revert.
1678         * frame-base.c: Revert.
1679         * fork-child.c: Revert.
1680         * findvar.c: Revert.
1681         * findcmd.c: Revert.
1682         * filesystem.c: Revert.
1683         * filename-seen-cache.h: Revert.
1684         * filename-seen-cache.c: Revert.
1685         * fbsd-tdep.c: Revert.
1686         * fbsd-nat.h: Revert.
1687         * fbsd-nat.c: Revert.
1688         * f-valprint.c: Revert.
1689         * f-typeprint.c: Revert.
1690         * f-lang.c: Revert.
1691         * extension.h: Revert.
1692         * extension.c: Revert.
1693         * extension-priv.h: Revert.
1694         * expprint.c: Revert.
1695         * exec.h: Revert.
1696         * exec.c: Revert.
1697         * exceptions.c: Revert.
1698         * event-top.c: Revert.
1699         * event-loop.c: Revert.
1700         * eval.c: Revert.
1701         * elfread.c: Revert.
1702         * dwarf2read.h: Revert.
1703         * dwarf2read.c: Revert.
1704         * dwarf2loc.c: Revert.
1705         * dwarf2expr.h: Revert.
1706         * dwarf2expr.c: Revert.
1707         * dwarf2-frame.c: Revert.
1708         * dwarf2-frame-tailcall.c: Revert.
1709         * dwarf-index-write.h: Revert.
1710         * dwarf-index-write.c: Revert.
1711         * dwarf-index-common.c: Revert.
1712         * dwarf-index-cache.h: Revert.
1713         * dwarf-index-cache.c: Revert.
1714         * dummy-frame.c: Revert.
1715         * dtrace-probe.c: Revert.
1716         * disasm.h: Revert.
1717         * disasm.c: Revert.
1718         * disasm-selftests.c: Revert.
1719         * dictionary.c: Revert.
1720         * dicos-tdep.c: Revert.
1721         * demangle.c: Revert.
1722         * dcache.h: Revert.
1723         * dcache.c: Revert.
1724         * darwin-nat.h: Revert.
1725         * darwin-nat.c: Revert.
1726         * darwin-nat-info.c: Revert.
1727         * d-valprint.c: Revert.
1728         * d-namespace.c: Revert.
1729         * d-lang.c: Revert.
1730         * ctf.c: Revert.
1731         * csky-tdep.c: Revert.
1732         * csky-linux-tdep.c: Revert.
1733         * cris-tdep.c: Revert.
1734         * cris-linux-tdep.c: Revert.
1735         * cp-valprint.c: Revert.
1736         * cp-support.c: Revert.
1737         * cp-namespace.c: Revert.
1738         * cp-abi.c: Revert.
1739         * corelow.c: Revert.
1740         * corefile.c: Revert.
1741         * continuations.c: Revert.
1742         * completer.h: Revert.
1743         * completer.c: Revert.
1744         * complaints.c: Revert.
1745         * coffread.c: Revert.
1746         * coff-pe-read.c: Revert.
1747         * cli-out.h: Revert.
1748         * cli-out.c: Revert.
1749         * charset.c: Revert.
1750         * c-varobj.c: Revert.
1751         * c-valprint.c: Revert.
1752         * c-typeprint.c: Revert.
1753         * c-lang.c: Revert.
1754         * buildsym.c: Revert.
1755         * buildsym-legacy.c: Revert.
1756         * build-id.h: Revert.
1757         * build-id.c: Revert.
1758         * btrace.c: Revert.
1759         * bsd-uthread.c: Revert.
1760         * breakpoint.h: Revert.
1761         * breakpoint.c: Revert.
1762         * break-catch-throw.c: Revert.
1763         * break-catch-syscall.c: Revert.
1764         * break-catch-sig.c: Revert.
1765         * blockframe.c: Revert.
1766         * block.c: Revert.
1767         * bfin-tdep.c: Revert.
1768         * bfin-linux-tdep.c: Revert.
1769         * bfd-target.c: Revert.
1770         * bcache.c: Revert.
1771         * ax-general.c: Revert.
1772         * ax-gdb.h: Revert.
1773         * ax-gdb.c: Revert.
1774         * avr-tdep.c: Revert.
1775         * auxv.c: Revert.
1776         * auto-load.c: Revert.
1777         * arm-wince-tdep.c: Revert.
1778         * arm-tdep.c: Revert.
1779         * arm-symbian-tdep.c: Revert.
1780         * arm-pikeos-tdep.c: Revert.
1781         * arm-obsd-tdep.c: Revert.
1782         * arm-nbsd-tdep.c: Revert.
1783         * arm-nbsd-nat.c: Revert.
1784         * arm-linux-tdep.c: Revert.
1785         * arm-linux-nat.c: Revert.
1786         * arm-fbsd-tdep.c: Revert.
1787         * arm-fbsd-nat.c: Revert.
1788         * arm-bsd-tdep.c: Revert.
1789         * arch-utils.c: Revert.
1790         * arc-tdep.c: Revert.
1791         * arc-newlib-tdep.c: Revert.
1792         * annotate.h: Revert.
1793         * annotate.c: Revert.
1794         * amd64-windows-tdep.c: Revert.
1795         * amd64-windows-nat.c: Revert.
1796         * amd64-tdep.c: Revert.
1797         * amd64-sol2-tdep.c: Revert.
1798         * amd64-obsd-tdep.c: Revert.
1799         * amd64-obsd-nat.c: Revert.
1800         * amd64-nbsd-tdep.c: Revert.
1801         * amd64-nbsd-nat.c: Revert.
1802         * amd64-nat.c: Revert.
1803         * amd64-linux-tdep.c: Revert.
1804         * amd64-linux-nat.c: Revert.
1805         * amd64-fbsd-tdep.c: Revert.
1806         * amd64-fbsd-nat.c: Revert.
1807         * amd64-dicos-tdep.c: Revert.
1808         * amd64-darwin-tdep.c: Revert.
1809         * amd64-bsd-nat.c: Revert.
1810         * alpha-tdep.c: Revert.
1811         * alpha-obsd-tdep.c: Revert.
1812         * alpha-nbsd-tdep.c: Revert.
1813         * alpha-mdebug-tdep.c: Revert.
1814         * alpha-linux-tdep.c: Revert.
1815         * alpha-linux-nat.c: Revert.
1816         * alpha-bsd-tdep.c: Revert.
1817         * alpha-bsd-nat.c: Revert.
1818         * aix-thread.c: Revert.
1819         * agent.c: Revert.
1820         * addrmap.c: Revert.
1821         * ada-varobj.c: Revert.
1822         * ada-valprint.c: Revert.
1823         * ada-typeprint.c: Revert.
1824         * ada-tasks.c: Revert.
1825         * ada-lang.c: Revert.
1826         * aarch64-tdep.c: Revert.
1827         * aarch64-ravenscar-thread.c: Revert.
1828         * aarch64-newlib-tdep.c: Revert.
1829         * aarch64-linux-tdep.c: Revert.
1830         * aarch64-linux-nat.c: Revert.
1831         * aarch64-fbsd-tdep.c: Revert.
1832         * aarch64-fbsd-nat.c: Revert.
1833         * aarch32-linux-nat.c: Revert.
1834
1835 2019-04-05  Tom Tromey  <tom@tromey.com>
1836
1837         * ft32-tdep.c: Sort headers.
1838         * frv-tdep.c: Sort headers.
1839         * frv-linux-tdep.c: Sort headers.
1840         * frame.c: Sort headers.
1841         * frame-unwind.c: Sort headers.
1842         * frame-base.c: Sort headers.
1843         * fork-child.c: Sort headers.
1844         * findvar.c: Sort headers.
1845         * findcmd.c: Sort headers.
1846         * filesystem.c: Sort headers.
1847         * filename-seen-cache.h: Sort headers.
1848         * filename-seen-cache.c: Sort headers.
1849         * fbsd-tdep.c: Sort headers.
1850         * fbsd-nat.h: Sort headers.
1851         * fbsd-nat.c: Sort headers.
1852         * f-valprint.c: Sort headers.
1853         * f-typeprint.c: Sort headers.
1854         * f-lang.c: Sort headers.
1855         * extension.h: Sort headers.
1856         * extension.c: Sort headers.
1857         * extension-priv.h: Sort headers.
1858         * expprint.c: Sort headers.
1859         * exec.h: Sort headers.
1860         * exec.c: Sort headers.
1861         * exceptions.c: Sort headers.
1862         * event-top.c: Sort headers.
1863         * event-loop.c: Sort headers.
1864         * eval.c: Sort headers.
1865         * elfread.c: Sort headers.
1866         * dwarf2read.h: Sort headers.
1867         * dwarf2read.c: Sort headers.
1868         * dwarf2loc.c: Sort headers.
1869         * dwarf2expr.h: Sort headers.
1870         * dwarf2expr.c: Sort headers.
1871         * dwarf2-frame.c: Sort headers.
1872         * dwarf2-frame-tailcall.c: Sort headers.
1873         * dwarf-index-write.h: Sort headers.
1874         * dwarf-index-write.c: Sort headers.
1875         * dwarf-index-common.c: Sort headers.
1876         * dwarf-index-cache.h: Sort headers.
1877         * dwarf-index-cache.c: Sort headers.
1878         * dummy-frame.c: Sort headers.
1879         * dtrace-probe.c: Sort headers.
1880         * disasm.h: Sort headers.
1881         * disasm.c: Sort headers.
1882         * disasm-selftests.c: Sort headers.
1883         * dictionary.c: Sort headers.
1884         * dicos-tdep.c: Sort headers.
1885         * demangle.c: Sort headers.
1886         * dcache.h: Sort headers.
1887         * dcache.c: Sort headers.
1888         * darwin-nat.h: Sort headers.
1889         * darwin-nat.c: Sort headers.
1890         * darwin-nat-info.c: Sort headers.
1891         * d-valprint.c: Sort headers.
1892         * d-namespace.c: Sort headers.
1893         * d-lang.c: Sort headers.
1894         * ctf.c: Sort headers.
1895         * csky-tdep.c: Sort headers.
1896         * csky-linux-tdep.c: Sort headers.
1897         * cris-tdep.c: Sort headers.
1898         * cris-linux-tdep.c: Sort headers.
1899         * cp-valprint.c: Sort headers.
1900         * cp-support.c: Sort headers.
1901         * cp-namespace.c: Sort headers.
1902         * cp-abi.c: Sort headers.
1903         * corelow.c: Sort headers.
1904         * corefile.c: Sort headers.
1905         * continuations.c: Sort headers.
1906         * completer.h: Sort headers.
1907         * completer.c: Sort headers.
1908         * complaints.c: Sort headers.
1909         * coffread.c: Sort headers.
1910         * coff-pe-read.c: Sort headers.
1911         * cli-out.h: Sort headers.
1912         * cli-out.c: Sort headers.
1913         * charset.c: Sort headers.
1914         * c-varobj.c: Sort headers.
1915         * c-valprint.c: Sort headers.
1916         * c-typeprint.c: Sort headers.
1917         * c-lang.c: Sort headers.
1918         * buildsym.c: Sort headers.
1919         * buildsym-legacy.c: Sort headers.
1920         * build-id.h: Sort headers.
1921         * build-id.c: Sort headers.
1922         * btrace.c: Sort headers.
1923         * bsd-uthread.c: Sort headers.
1924         * breakpoint.h: Sort headers.
1925         * breakpoint.c: Sort headers.
1926         * break-catch-throw.c: Sort headers.
1927         * break-catch-syscall.c: Sort headers.
1928         * break-catch-sig.c: Sort headers.
1929         * blockframe.c: Sort headers.
1930         * block.c: Sort headers.
1931         * bfin-tdep.c: Sort headers.
1932         * bfin-linux-tdep.c: Sort headers.
1933         * bfd-target.c: Sort headers.
1934         * bcache.c: Sort headers.
1935         * ax-general.c: Sort headers.
1936         * ax-gdb.h: Sort headers.
1937         * ax-gdb.c: Sort headers.
1938         * avr-tdep.c: Sort headers.
1939         * auxv.c: Sort headers.
1940         * auto-load.c: Sort headers.
1941         * arm-wince-tdep.c: Sort headers.
1942         * arm-tdep.c: Sort headers.
1943         * arm-symbian-tdep.c: Sort headers.
1944         * arm-pikeos-tdep.c: Sort headers.
1945         * arm-obsd-tdep.c: Sort headers.
1946         * arm-nbsd-tdep.c: Sort headers.
1947         * arm-nbsd-nat.c: Sort headers.
1948         * arm-linux-tdep.c: Sort headers.
1949         * arm-linux-nat.c: Sort headers.
1950         * arm-fbsd-tdep.c: Sort headers.
1951         * arm-fbsd-nat.c: Sort headers.
1952         * arm-bsd-tdep.c: Sort headers.
1953         * arch-utils.c: Sort headers.
1954         * arc-tdep.c: Sort headers.
1955         * arc-newlib-tdep.c: Sort headers.
1956         * annotate.h: Sort headers.
1957         * annotate.c: Sort headers.
1958         * amd64-windows-tdep.c: Sort headers.
1959         * amd64-windows-nat.c: Sort headers.
1960         * amd64-tdep.c: Sort headers.
1961         * amd64-sol2-tdep.c: Sort headers.
1962         * amd64-obsd-tdep.c: Sort headers.
1963         * amd64-obsd-nat.c: Sort headers.
1964         * amd64-nbsd-tdep.c: Sort headers.
1965         * amd64-nbsd-nat.c: Sort headers.
1966         * amd64-nat.c: Sort headers.
1967         * amd64-linux-tdep.c: Sort headers.
1968         * amd64-linux-nat.c: Sort headers.
1969         * amd64-fbsd-tdep.c: Sort headers.
1970         * amd64-fbsd-nat.c: Sort headers.
1971         * amd64-dicos-tdep.c: Sort headers.
1972         * amd64-darwin-tdep.c: Sort headers.
1973         * amd64-bsd-nat.c: Sort headers.
1974         * alpha-tdep.c: Sort headers.
1975         * alpha-obsd-tdep.c: Sort headers.
1976         * alpha-nbsd-tdep.c: Sort headers.
1977         * alpha-mdebug-tdep.c: Sort headers.
1978         * alpha-linux-tdep.c: Sort headers.
1979         * alpha-linux-nat.c: Sort headers.
1980         * alpha-bsd-tdep.c: Sort headers.
1981         * alpha-bsd-nat.c: Sort headers.
1982         * aix-thread.c: Sort headers.
1983         * agent.c: Sort headers.
1984         * addrmap.c: Sort headers.
1985         * ada-varobj.c: Sort headers.
1986         * ada-valprint.c: Sort headers.
1987         * ada-typeprint.c: Sort headers.
1988         * ada-tasks.c: Sort headers.
1989         * ada-lang.c: Sort headers.
1990         * aarch64-tdep.c: Sort headers.
1991         * aarch64-ravenscar-thread.c: Sort headers.
1992         * aarch64-newlib-tdep.c: Sort headers.
1993         * aarch64-linux-tdep.c: Sort headers.
1994         * aarch64-linux-nat.c: Sort headers.
1995         * aarch64-fbsd-tdep.c: Sort headers.
1996         * aarch64-fbsd-nat.c: Sort headers.
1997         * aarch32-linux-nat.c: Sort headers.
1998
1999 2019-04-04  Tom Tromey  <tom@tromey.com>
2000
2001         * varobj.c (varobj_create): Update.
2002         * rust-exp.y (struct rust_parser) <update_innermost_block,
2003         lookup_symbol>: New methods.
2004         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2005         Rename.
2006         (rust_parser::rust_lookup_type)
2007         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2008         * printcmd.c (display_command, do_one_display): Update.
2009         * parser-defs.h (struct parser_state) <parser_state>: Add
2010         "tracker" parameter.
2011         (block_tracker): New member.
2012         (class innermost_block_tracker) <innermost_block_tracker>: Add
2013         "types" parameter.
2014         <reset>: Remove method.
2015         (innermost_block): Don't declare.
2016         (null_post_parser): Update.
2017         * parse.c (innermost_block): Remove global.
2018         (write_dollar_variable): Update.
2019         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2020         Remove "tracker_types" parameter.
2021         (parse_expression): Add "tracker" parameter.
2022         (parse_expression_for_completion): Update.
2023         (null_post_parser): Add "tracker" parameter.
2024         * p-exp.y: Update rules.
2025         * m2-exp.y: Update rules.
2026         * language.h (struct language_defn) <la_post_parser>: Add
2027         "tracker" parameter.
2028         * go-exp.y: Update rules.
2029         * f-exp.y: Update rules.
2030         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2031         parameter.
2032         * d-exp.y: Update rules.
2033         * c-exp.y: Update rules.
2034         * breakpoint.c (set_breakpoint_condition): Create an
2035         innermost_block_tracker.
2036         (watch_command_1): Likewise.
2037         * ada-lang.c (resolve): Add "tracker" parameter.
2038         (resolve_subexp): Likewise.
2039         * ada-exp.y (write_var_from_sym): Update.
2040
2041 2019-04-04  Tom Tromey  <tom@tromey.com>
2042
2043         * type-stack.h: New file.
2044         * type-stack.c: New file.
2045         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2046         type-stack.h.
2047         (insert_into_type_stack, insert_type, push_type, push_type_int)
2048         (insert_type_address_space, pop_type, pop_type_int)
2049         (pop_typelist, pop_type_stack, append_type_stack)
2050         (push_type_stack, get_type_stack, push_typelist)
2051         (follow_type_instance_flags, follow_types): Don't declare.
2052         * parse.c (type_stack): Remove global.
2053         (parse_exp_in_context): Update.
2054         (insert_into_type_stack, insert_type, push_type, push_type_int)
2055         (insert_type_address_space, pop_type, pop_type_int)
2056         (pop_typelist, pop_type_stack, append_type_stack)
2057         (push_type_stack, get_type_stack, push_typelist)
2058         (follow_type_instance_flags, follow_types): Remove (moved to
2059         type-stack.c).
2060         * f-exp.y (type_stack): New global.
2061         Update rules.
2062         (push_kind_type, f_parse): Update.
2063         * d-exp.y (type_stack): New global.
2064         Update rules.
2065         (d_parse): Update.
2066         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2067         Update rules.
2068         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2069         (HFILES_NO_SRCDIR): Add type-stack.h.
2070
2071 2019-04-04  Tom Tromey  <tom@tromey.com>
2072
2073         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2074         (rust_parser::convert_ast_to_expression, rust_parse)
2075         (rust_lex_test_completion, rust_lex_tests): Update.
2076         * parser-defs.h (struct expr_completion_state): New.
2077         (struct parser_state) <parser_state>: Add completion parameter.
2078         <mark_struct_expression, mark_completion_tag>: New methods.
2079         <parse_completion, m_completion_state>: New members.
2080         (prefixify_expression, null_post_parser): Update.
2081         (mark_struct_expression, mark_completion_tag): Don't declare.
2082         * parse.c (parse_completion, expout_last_struct)
2083         (expout_tag_completion_type, expout_completion_name): Remove
2084         globals.
2085         (parser_state::mark_struct_expression)
2086         (parser_state::mark_completion_tag): Now methods.
2087         (prefixify_expression): Add last_struct parameter.
2088         (prefixify_subexp): Likewise.
2089         (parse_exp_1): Update.
2090         (parse_exp_in_context): Add cstate parameter.  Update.
2091         (parse_expression_for_completion): Create an
2092         expr_completion_state.
2093         (null_post_parser): Add "completion" parameter.
2094         * p-exp.y: Update rules.
2095         (yylex): Update.
2096         * language.h (struct language_defn) <la_post_parser>: Add
2097         "completing" parameter.
2098         * go-exp.y: Update rules.
2099         (lex_one_token): Update.
2100         * expression.h (parse_completion): Don't declare.
2101         * d-exp.y: Update rules.
2102         (lex_one_token): Update rules.
2103         * c-exp.y: Update rules.
2104         (lex_one_token): Update.
2105         * ada-lang.c (resolve): Add "parse_completion" parameter.
2106         (resolve_subexp): Likewise.
2107         (ada_resolve_function): Likewise.
2108
2109 2019-04-04  Tom Tromey  <tom@tromey.com>
2110
2111         * parser-defs.h (struct parser_state) <start_arglist,
2112         end_arglist>: New methods.
2113         <arglist_len, m_funcall_chain>: New members.
2114         (arglist_len, start_arglist, end_arglist): Don't declare.
2115         * parse.c (arglist_len, funcall_chain): Remove global.
2116         (start_arglist, end_arglist): Remove functions.
2117         (parse_exp_in_context): Update.
2118         * p-exp.y: Update rules.
2119         * m2-exp.y: Update rules.
2120         * go-exp.y: Update rules.
2121         * f-exp.y: Update rules.
2122         * d-exp.y: Update rules.
2123         * c-exp.y: Update rules.
2124
2125 2019-04-04  Tom Tromey  <tom@tromey.com>
2126
2127         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2128         lex_operator, push_back>: New methods.
2129         Update all rules.
2130         (rust_parser::lex_hex, lex_escape): Rename and update.
2131         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2132         (rust_parser::lex_operator): Rename and update.
2133         (rust_parser::lex_number, rustyylex, rustyyerror)
2134         (rust_lex_test_init, rust_lex_test_sequence)
2135         (rust_lex_test_push_back, rust_lex_tests): Update.
2136         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2137         parameter.
2138         <lexptr, prev_lexptr>: New members.
2139         (lexptr, prev_lexptr): Don't declare.
2140         * parse.c (lexptr, prev_lexptr): Remove globals.
2141         (parse_exp_in_context): Update.
2142         * p-exp.y (yylex, yyerror): Update.
2143         * m2-exp.y (parse_number, yylex, yyerror): Update.
2144         * go-exp.y (lex_one_token, yyerror): Update.
2145         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2146         * d-exp.y (lex_one_token, yyerror): Update.
2147         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2148         (lex_one_token, yyerror): Update.
2149         * ada-lex.l (YY_INPUT): Update.
2150         (rewind_to_char): Update.
2151         * ada-exp.y (yyerror): Update.
2152
2153 2019-04-04  Tom Tromey  <tom@tromey.com>
2154
2155         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2156         * parser-defs.h (struct parser_state) <parser_state>: Add new
2157         parameter.
2158         <comma_terminates>: New member.
2159         (comma_terminates): Don't declare global.
2160         * parse.c (comma_terminates): Remove global.
2161         (parse_exp_in_context): Update.
2162         * p-exp.y (yylex): Update.
2163         * m2-exp.y (yylex): Update.
2164         * go-exp.y (lex_one_token): Update.
2165         * f-exp.y (yylex): Update.
2166         * d-exp.y (lex_one_token): Update.
2167         * c-exp.y (lex_one_token): Update.
2168         * ada-lex.l: Update.
2169
2170 2019-04-04  Tom Tromey  <tom@tromey.com>
2171
2172         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2173         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2174         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2175         * parser-defs.h (paren_depth): Don't declare.
2176         * parse.c (paren_depth): Remove global.
2177         (parse_exp_in_context): Update.
2178         * p-exp.y (paren_depth): New global.
2179         (pascal_parse): Initialize it.
2180         * m2-exp.y (paren_depth): New global.
2181         (m2_parse): Initialize it.
2182         * go-exp.y (paren_depth): New global.
2183         (go_parse): Initialize it.
2184         * f-exp.y (paren_depth): New global.
2185         (f_parse): Initialize it.
2186         * d-exp.y (paren_depth): New global.
2187         (d_parse): Initialize it.
2188         * c-exp.y (paren_depth): New global.
2189         (c_parse): Initialize it.
2190         * ada-lex.l (paren_depth): New global.
2191         (lexer_init): Initialize it.
2192
2193 2019-04-04  Tom Tromey  <tom@tromey.com>
2194
2195         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2196         (rust_parser::convert_ast_to_type)
2197         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2198         * parser-defs.h (struct parser_state) <parser_state>: Add
2199         parameters.  Initialize new members.
2200         <expression_context_block, expression_context_pc>: New members.
2201         * parse.c (expression_context_block, expression_context_pc):
2202         Remove globals.
2203         (parse_exp_in_context): Update.
2204         * p-exp.y: Update all rules.
2205         (yylex): Update.
2206         * m2-exp.y: Update all rules.
2207         (yylex): Update.
2208         * go-exp.y (yylex): Update.
2209         * f-exp.y (yylex): Update.
2210         * d-exp.y: Update all rules.
2211         (yylex): Update.
2212         * c-exp.y: Update all rules.
2213         (lex_one_token, classify_name, yylex, c_parse): Update.
2214         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2215
2216 2019-04-04  Tom Tromey  <tom@tromey.com>
2217
2218         * gdbarch.h, gdbarch.c: Rebuild.
2219         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2220         * stap-probe.h:
2221         (struct stap_parse_info): Replace "parser_state" with
2222         "expr_builder".
2223         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2224         (parser_state): New class.
2225         * parse.c (expr_builder): Rename.
2226         (expr_builder::release): Rename.
2227         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2228         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2229         (write_exp_elt_longcst, write_exp_elt_floatcst)
2230         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2231         (write_exp_string_vector, write_exp_bitstring)
2232         (write_exp_msymbol, mark_struct_expression)
2233         (write_dollar_variable)
2234         (insert_type_address_space, increase_expout_size): Replace
2235         "parser_state" with "expr_builder".
2236         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2237         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2238         "parser_state" with "expr_builder".
2239
2240 2019-04-04  Tom Tromey  <tom@tromey.com>
2241
2242         * rust-exp.y: Replace "parse_language" with method call.
2243         * p-exp.y:
2244         (yylex): Replace "parse_language" with method call.
2245         * m2-exp.y:
2246         (yylex): Replace "parse_language" with method call.
2247         * go-exp.y (classify_name): Replace "parse_language" with method
2248         call.
2249         * f-exp.y (yylex): Replace "parse_language" with method call.
2250         * d-exp.y (lex_one_token): Replace "parse_language" with method
2251         call.
2252         * c-exp.y:
2253         (lex_one_token, classify_name, yylex): Replace "parse_language"
2254         with method call.
2255         * ada-exp.y (find_primitive_type, type_char)
2256         (type_system_address): Replace "parse_language" with method call.
2257
2258 2019-04-04  Tom Tromey  <tom@tromey.com>
2259
2260         * rust-exp.y: Replace "parse_gdbarch" with method call.
2261         * parse.c (write_dollar_variable, insert_type_address_space):
2262         Replace "parse_gdbarch" with method call.
2263         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2264         call.
2265         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2266         call.
2267         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2268         "parse_gdbarch" with method call.
2269         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2270         with method call.
2271         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2272         "parse_gdbarch" with method call.
2273         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2274         "parse_gdbarch" with method call.
2275         * c-exp.y (parse_type, parse_number, classify_name): Replace
2276         "parse_gdbarch" with method call.
2277         * ada-lex.l: Replace "parse_gdbarch" with method call.
2278         * ada-exp.y (parse_type, find_primitive_type, type_char)
2279         (type_system_address): Replace "parse_gdbarch" with method call.
2280
2281 2019-04-04  Tom Tromey  <tom@tromey.com>
2282
2283         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2284         * stap-probe.c (stap_parse_argument): Update.
2285         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2286         initial_size parameter.
2287         * rust-exp.y (rust_lex_tests): Update.
2288         * parse.c (parser_state): Update.
2289         (parse_exp_in_context): Update.
2290         * parser-defs.h (struct parser_state) <parser_state>: Remove
2291         "initial_size" parameter.
2292
2293 2019-04-04  Tom Tromey  <tom@tromey.com>
2294
2295         * parser-defs.h (increase_expout_size): Don't declare.
2296         * parse.c (increase_expout_size): Now static.
2297
2298 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2299
2300         * gnu-nat.c (gnu_nat_target::wait): Fix
2301         target_waitstatus_to_string call.
2302
2303 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2304
2305         * eval.c (evaluate_subexp_standard): Handle internal functions
2306         during Fortran function call handling.
2307
2308 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2309
2310         * NEWS: Mention new internal functions.
2311         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2312         (read_base_type): Use dwarf2_init_complex_target_type.
2313         * value.c (creal_internal_fn): New function.
2314         (cimag_internal_fn): New function.
2315         (_initialize_values): Register new internal functions.
2316
2317 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2318
2319         * infrun.c (stop_all_threads): If debug_infrun, always
2320         trace the wait status after wait_one, using
2321         target_waitstatus_to_string and target_pid_to_str.
2322         (handle_inferior_event): Replace various trace of
2323         wait status kind by a single trace.
2324         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2325         wait status kind image by target_waitstatus_to_string.
2326         * target/waitstatus.c (target_waitstatus_to_string): Fix
2327         obsolete comment.
2328
2329 2019-04-01  Tom Tromey  <tromey@adacore.com>
2330
2331         PR symtab/23331:
2332         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2333
2334 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2335             Pedro Alves  <palves@redhat.com>
2336
2337         * top.c (quit_force): Call 'finalize_values'.
2338         * value.c (finalize_values): New function.
2339         * value.h (finalize_values): Declare.
2340
2341 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2342
2343         * NEWS: Announce $_gdb_major and $_gdb_minor.
2344
2345         * top.c (init_gdb_version_vars): New function.
2346         (gdb_init): Call init_gdb_version_vars.
2347
2348 2019-03-29  Tom Tromey  <tromey@adacore.com>
2349
2350         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2351         help text.  Remove dead code.
2352
2353 2019-03-29  Keith Seitz  <keiths@redhat.com>
2354
2355         From Siddhesh Poyarekar:
2356         * f-lang.h (f77_get_upperbound): Return LONGEST.
2357         (f77_get_lowerbound): Likewise.
2358         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2359         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2360         print them.
2361         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2362         plongest to format print it.
2363         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2364         (f77_get_upperbound): Likewise.
2365         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2366         LOWER_BOUND to LONGEST.
2367         (f77_create_arrayprint_offset_tbl): Likewise.
2368
2369 2019-03-29  Keith Seitz  <keiths@redhat.com>
2370
2371         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2372         %s/pulongest for TYPE_LENGTH instead of %d in format
2373         strings.
2374         * ada-typerint.c (ada_print_type): Likewise.
2375         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2376         * compile/compile-c-support.c (generate_register_struct): Likewise.
2377         * gdbtypes.c (recursive_dump_type): Likewise.
2378         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2379         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2380         instead of %d in format strings.
2381         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2382         to std::min to ULONGEST.
2383         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2384         instead of %d in format strings.
2385         * tracepoint.c (info_scope_command): Likewise.
2386         * typeprint.c (print_offset_data::update)
2387         (print_offset_data::finish): Likewise.
2388         * xtensa-tdep.c (xtensa_store_return_value)
2389         (xtensa_push_dummy_call): Likewise.
2390
2391 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2392
2393         * windows-nat.c (display_selector): Fixed format specifications
2394         for 64-bit Cygwin.
2395
2396 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2397
2398         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2399
2400 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2401
2402         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2403         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2404         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2405         (nios2_linux_init_abi): Install it.
2406
2407 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2408
2409         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2410
2411 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2412
2413         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2414
2415 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2416             Tom Tromey  <tromey@adacore.com>
2417
2418         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2419
2420 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2421
2422         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2423         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2424         method to compute the bounds of range types. Also print "[evaluated]"
2425         if the bounds' values come from a dynamic evaluation.
2426
2427 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2428
2429         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2430         whitespace when pretty printing is on.
2431
2432 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2433
2434         * ppc-linux-nat.c: Add include.
2435
2436 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2437
2438         * NEWS: Mention AArch64 Pointer Authentication.
2439
2440 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2441
2442         * arm-linux-nat.c: Add include.
2443
2444 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2445
2446         * source-cache.c (source_cache::get_source_lines): Re-read
2447         fullname after calling open_source_file.
2448
2449 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2450
2451         * NEWS: Mention TLS support for FreeBSD.
2452
2453 2019-03-25  Tom Tromey  <tromey@adacore.com>
2454
2455         * minsyms.c (BUNCH_SIZE): Update comment.
2456         (~minimal_symbol_reader): Remove old comment.
2457         (compact_minimal_symbols): Update comment.
2458         (minimal_symbol_reader::install): Remove old comment.  Update
2459         other comments.
2460
2461 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2462
2463         * s390-linux-nat.c: Add include.
2464
2465 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2466
2467         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2468         Call linux_get_hwcap.
2469         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2470         Likewise.
2471         (aarch64_linux_get_hwcap): Remove function.
2472         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2473         declaration.
2474         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2475         linux_get_hwcap.
2476         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2477         * linux-tdep.c (linux_get_hwcap): Add function.
2478         (linux_get_hwcap2): Likewise.
2479         * linux-tdep.h (linux_get_hwcap): Add declaration.
2480         (linux_get_hwcap2): Likewise.
2481         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2482         (ppc_linux_get_hwcap2): Likewise.
2483         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2484         linux_get_hwcap.
2485         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2486         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2487         (ppc_linux_nat_target::read_description): Likewise.
2488         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2489         * s390-linux-nat.c: Likewise.
2490         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2491
2492 2019-03-24  Tom Tromey  <tom@tromey.com>
2493
2494         * ada-lang.c (standard_lookup): Simplify initialization.
2495         (ada_lookup_symbol_nonlocal): Simplify return.
2496         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2497         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2498         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2499         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2500         initialization.
2501         * solib.c (solib_global_lookup): Simplify.
2502         * symtab.c (null_block_symbol): Remove.
2503         (symbol_cache_lookup): Simplify returns.
2504         (lookup_language_this): Simplify returns.
2505         (lookup_symbol_aux): Simplify return.
2506         (lookup_local_symbol): Simplify returns.
2507         (lookup_global_symbol_from_objfile): Simplify return.
2508         (lookup_symbol_in_objfile_symtabs)
2509         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2510         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2511         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2512         * cp-namespace.c (cp_lookup_bare_symbol)
2513         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2514         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2515         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2516         (cp_lookup_symbol_via_imports): Simplify initialization.
2517         (find_symbol_in_baseclass): Likewise.
2518         * symtab.h (null_block_symbol): Remove.
2519         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2520         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2521         (d_lookup_symbol_module): Likewise.
2522         (find_symbol_in_baseclass): Simplify initialization.
2523
2524 2019-03-24  Tom Tromey  <tom@tromey.com>
2525
2526         * expression.h: Don't include symtab.h.
2527         (struct block): Forward declare.
2528
2529 2019-03-24  Tom Tromey  <tom@tromey.com>
2530
2531         * c-exp.y (typebase): Remove casts.
2532         * gdbtypes.c (lookup_unsigned_typename, )
2533         (lookup_signed_typename): Remove cast.
2534         * eval.c (parse_to_comma_and_eval): Remove cast.
2535         * parse.c (write_dollar_variable): Remove cast.
2536         * block.h (struct block) <superblock>: Now const.
2537         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2538         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2539         (map_block): Make "block" const.
2540         * symfile.h (struct quick_symbol_functions)
2541         <map_matching_symbols>: Constify block argument to "callback".
2542         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2543         const.
2544         (find_pc_sect_compunit_symtab): Make "b" const.
2545         (find_symbol_at_address): Likewise.
2546         (search_symbols): Likewise.
2547         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2548         (dw2_debug_names_lookup_symbol): Likewise.
2549         (dw2_map_matching_symbols): Update.
2550         * p-valprint.c (pascal_val_print): Remove "block".
2551         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2552         (aux_add_nonlocal_symbols): Make "block" const.
2553         (resolve_subexp): Remove cast.
2554         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2555         const.
2556         (iterate_over_file_blocks): Likewise.
2557         * f-exp.y (%union) <bval>: Remove.
2558         * coffread.c (patch_opaque_types): Make "b" const.
2559         * spu-tdep.c (spu_catch_start): Make "block" const.
2560         * c-valprint.c (print_unpacked_pointer): Remove "block".
2561         * symmisc.c (dump_symtab_1): Make "b" const.
2562         (block_depth): Make "block" const.
2563         * d-exp.y (%union) <bval>: Remove.
2564         * cp-support.h (cp_lookup_rtti_type): Update.
2565         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2566         * psymtab.c (psym_lookup_symbol): Make "block" const.
2567         (maintenance_check_psymtabs): Make "b" const.
2568         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2569         (enumerate_locals, enumerate_args): Update.
2570         * python/py-symtab.c (stpy_global_block): Make "block" const.
2571         (stpy_static_block): Likewise.
2572         * inline-frame.c (block_starting_point_at): Make "new_block"
2573         const.
2574         * block.c (find_block_in_blockvector): Make return type const.
2575         (blockvector_for_pc_sect): Make "b" const.
2576         (find_block_in_blockvector): Make "b" const.
2577
2578 2019-03-23  Tom Tromey  <tom@tromey.com>
2579
2580         * varobj.c (varobj_create): Update.
2581         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2582         * printcmd.c (display_command, do_one_display): Don't reset
2583         innermost_block.
2584         * parser-defs.h (enum innermost_block_tracker_type): Move to
2585         expression.h.
2586         (innermost_block): Update comment.
2587         * parse.c (parse_exp_1): Add tracker_types parameter.
2588         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2589         tracker_types parameter.  Reset innermost_block.
2590         (parse_exp_in_context): Remove.
2591         (parse_expression_for_completion): Update.
2592         * objfiles.c (~objfile): Don't reset expression_context_block or
2593         innermost_block.
2594         * expression.h (enum innermost_block_tracker_type): Move from
2595         parser-defs.h.
2596         (parse_exp_1): Add tracker_types parameter.
2597         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2598         reset innermost_block.
2599
2600 2019-03-23  Tom Tromey  <tom@tromey.com>
2601
2602         * objfiles.h: Include bcache.h.
2603
2604 2019-03-23  Tom Tromey  <tom@tromey.com>
2605
2606         * linespec.c (get_current_search_block): Use
2607         scoped_restore_current_language.
2608         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2609
2610 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2611             Jiong Wang  <jiong.wang@arm.com>
2612
2613         * aarch64-linux-tdep.c
2614         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2615         section.
2616         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2617
2618 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2619             Jiong Wang  <jiong.wang@arm.com>
2620
2621         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2622         instructions.
2623         (aarch64_analyze_prologue_test): Add PACIASP test.
2624         (aarch64_prologue_prev_register): Unmask PC value.
2625
2626 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2627             Jiong Wang  <jiong.wang@arm.com>
2628
2629         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2630         (aarch64_dwarf2_prev_register): Unmask PC value.
2631         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2632         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2633         DW_CFA_AARCH64_negate_ra_state.
2634         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2635
2636 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2637             Jiong Wang  <jiong.wang@arm.com>
2638
2639         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2640         registers.
2641         (aarch64_pseudo_register_name): Likewise.
2642         (aarch64_pseudo_register_type): Likewise.
2643         (aarch64_pseudo_register_reggroup_p): Likewise.
2644         (aarch64_gdbarch_init): Add pauth registers.
2645         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2646         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2647         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2648         (struct gdbarch_tdep): Add regnum for ra_state.
2649
2650 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2651             Jiong Wang  <jiong.wang@arm.com>
2652
2653         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2654
2655 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2656             Jiong Wang  <jiong.wang@arm.com>
2657
2658         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2659         function.
2660         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2661         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2662         (aarch64_gdbarch_init): Add puth registers.
2663         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2664         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2665         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2666
2667 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2668             Jiong Wang  <jiong.wang@arm.com>
2669
2670         * aarch64-linux-nat.c
2671         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2672         * aarch64-linux-tdep.c
2673         (aarch64_linux_core_read_description): Likewise.
2674         (aarch64_linux_get_hwcap): New function.
2675         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2676         (aarch64_linux_get_hwcap): New declaration.
2677
2678 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2679             Jiong Wang  <jiong.wang@arm.com>
2680
2681         * aarch64-linux-nat.c
2682         (aarch64_linux_nat_target::read_description): Add pauth param.
2683         * aarch64-linux-tdep.c
2684         (aarch64_linux_core_read_description): Likewise.
2685         * aarch64-tdep.c (struct target_desc): Add in pauth.
2686         (aarch64_read_description): Add pauth param.
2687         (aarch64_gdbarch_init): Likewise.
2688         * aarch64-tdep.h (aarch64_read_description): Likewise.
2689         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2690         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2691         * features/Makefile: Add new files.
2692         * features/aarch64-pauth.c: New file.
2693         * features/aarch64-pauth.xml: New file.
2694
2695 2019-03-20  Tom Tromey  <tromey@adacore.com>
2696
2697         * infrun.c (handle_inferior_event): Rename from
2698         handle_inferior_event_1.  Create a scoped_value_mark.
2699         (handle_inferior_event): Remove.
2700
2701 2019-03-19  Tom Tromey  <tromey@adacore.com>
2702
2703         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2704         * infrun.h (print_stop_event): Add "displays" parameter.
2705         * infrun.c (print_stop_event): Add "displays" parameter.
2706
2707 2019-03-19  Pedro Alves  <palves@redhat.com>
2708
2709         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2710         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2711         to -1.  Fix TABs vs spaces.
2712         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2713         * tui/tui-out.h (tui_ui_out) Add intro comments.
2714         <m_line, m_start_of_line>: In-class initialize, and add describing
2715         comment.
2716
2717 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2718
2719         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2720         variable names.
2721         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2722
2723 2019-03-18  Pedro Alves  <palves@redhat.com>
2724             Eli Zaretskii <eliz@gnu.org>
2725
2726         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2727         m_line and m_start_of_line.
2728
2729 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2730
2731         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2732         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2733         it returns a newline.  This fixes a regression in TU mode, whereby
2734         the next line is output on the same screen line as the user input.
2735
2736 2019-03-18  Tom Tromey  <tromey@adacore.com>
2737
2738         * minsyms.c (minimal_symbol_reader::install): Remove call to
2739         obstack_blank.
2740
2741 2019-03-18  Pedro Alves  <palves@redhat.com>
2742
2743         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2744         New globals.
2745         (apply_style): New, factored out from ...
2746         (apply_ansi_escape): ... this.  Handle reverse video mode.
2747         (tui_set_reverse_mode): New function.
2748         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2749         * tui/tui-winsource.c (tui_show_source_line): Use
2750         tui_set_reverse_mode instead of setting A_STANDOUT.
2751         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2752         New setter methods.
2753
2754 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2755
2756         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2757         Handle tabs.
2758
2759 2019-03-18  Tom Tromey  <tromey@adacore.com>
2760
2761         * ada-lang.c (empty_array): Add "high" parameter.
2762         (ada_evaluate_subexp): Update.
2763
2764 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2765
2766         * unittests/string_view-selftests.c: Define
2767         _initialize_string_view_selftests unconditionally.
2768
2769 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2770
2771         PR gdb/24350
2772         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2773
2774 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2775
2776         PR gdb/24351
2777         * windows-nat.c (display_selector): Fix format specifiers.
2778
2779 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2780
2781         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2782         tui_refill_source_window instead of tui_refresh_win, to update the
2783         current execution line.  This fixes redisplay of the current line
2784         when stepping through the code with "next" or "step".
2785
2786 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2787
2788         * source-cache.c (source_cache::get_source_lines): Call
2789         find_source_lines to initialize s->nlines.  This fixes vertical
2790         scrolling of TUI source window when the DOWN arrow is pressed.
2791
2792 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2793
2794         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2795         linux-thread-db.c (_initialize_thread_db): Likewise.
2796
2797 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2798
2799         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2800         wclrtoeol in tui_show_source_line".  This reverts changes made in
2801         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2802
2803 2019-03-15  Tom Tromey  <tom@tromey.com>
2804
2805         * symtab.h (struct minimal_symbol): Derive from
2806         general_symbol_info.
2807         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2808         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2809         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2810         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2811         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2812         (MSYMBOL_SEARCH_NAME): Update.
2813         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2814         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2815         * minsyms.c (minimal_symbol_reader::record_full): Update.
2816
2817 2019-03-15  Tom Tromey  <tom@tromey.com>
2818
2819         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2820
2821 2019-03-15  Tom Tromey  <tom@tromey.com>
2822
2823         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2824         unique_xmalloc_ptr.
2825         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2826         Update.
2827         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2828         (build_minimal_symbol_hash_tables)
2829         (minimal_symbol_reader::install): Update.
2830
2831 2019-03-15  Tom Tromey  <tom@tromey.com>
2832
2833         * symtab.c (create_demangled_names_hash): Update.
2834         (symbol_set_names): Update.
2835         * objfiles.h (struct objfile_per_bfd_storage)
2836         <demangled_names_hash>: Now an htab_up.
2837         * objfiles.c (objfile_per_bfd_storage): Simplify.
2838
2839 2019-03-15  Tom Tromey  <tom@tromey.com>
2840
2841         * objfiles.h (struct objfile_per_bfd_storage): Declare
2842         destructor.
2843         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2844         New.
2845         (get_objfile_bfd_data): Use new.  Don't initialize
2846         language_of_main.
2847         (free_objfile_per_bfd_storage): Remove.
2848         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2849
2850 2019-03-15  Tom Tromey  <tom@tromey.com>
2851
2852         * symfile.c (reread_symbols): Update.
2853         * objfiles.c (objfile::objfile): Update.
2854         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2855         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2856         comment.
2857         (minimal_symbol_reader::install): Update.
2858         (terminate_minimal_symbol_table): Remove.
2859         * jit.c (jit_object_close_impl): Update.
2860
2861 2019-03-15  Tom Tromey  <tom@tromey.com>
2862
2863         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2864         initializations.
2865
2866 2019-03-15  Tom Tromey  <tom@tromey.com>
2867
2868         * objfiles.h (struct objfile_per_bfd_storage)
2869         <demangled_hash_languages>: Now a bitset.
2870         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2871         (lookup_minimal_symbol): Update.
2872
2873 2019-03-15  Tom Tromey  <tom@tromey.com>
2874
2875         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2876         Don't return the symbol.
2877         * coffread.c (record_minimal_symbol): Use record_full.
2878
2879 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2880
2881         The MS-Windows port of ncurses fails to switch to a color pair if
2882         one or both of the colors are the implicit default colors.  This
2883         change records the default colors when TUI is initialized, and
2884         then specifies them explicitly when a color pair uses the default
2885         colors.  This allows color styling in TUI mode on MS-Windows.
2886
2887         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2888         ncurses_norm_attr.
2889         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2890         colors in ncurses_norm_attr.
2891         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2892         "none", replace it with the default color recorded in
2893         ncurses_norm_attr.
2894
2895 2019-03-14  Tom Tromey  <tromey@adacore.com>
2896
2897         * source-cache.h (class source_cache) <get_source_lines>: Return
2898         std::string.
2899         * source-cache.c (source_cache::extract_lines): Handle case where
2900         first_pos==npos.  Return std::string.
2901         (source_cache::get_source_lines): Update.
2902
2903 2019-03-14  Tom Tromey  <tromey@adacore.com>
2904
2905         * NEWS: Add item for "style sources" commands.
2906         * source-cache.c (source_cache::get_source_lines): Check
2907         source_styling.
2908         * cli/cli-style.c (source_styling): New global.
2909         (_initialize_cli_style): Add "style sources" commands.
2910         (show_style_sources): New function.
2911         * cli/cli-style.h (source_styling): Declare.
2912
2913 2019-03-14  Pedro Alves  <palves@redhat.com>
2914             Tom Tromey  <tromey@adacore.com>
2915
2916         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2917         * tui/tui-winsource.c (tui_refill_source_window): New function,
2918         from...
2919         (tui_horizontal_source_scroll): ... here.  Move some logic.
2920         * cli/cli-style.c (set_style_enabled): Notify new observable.
2921         * tui/tui-hooks.c (tui_redisplay_source): New function.
2922         (tui_attach_detach_observers): Attach or detach
2923         tui_redisplay_source.
2924         * observable.h (source_styling_changed): New observable.
2925         * observable.c: Define source_styling_changed observable.
2926
2927 2019-03-13  Tom Tromey  <tromey@adacore.com>
2928
2929         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2930         (i386_gnu_nat_target::store_registers): Update.
2931         * target-debug.h (target_debug_print_std_string): New macro.
2932         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2933         * windows-tdep.c (display_one_tib): Update.
2934         * tui/tui-stack.c (tui_make_status_line): Update.
2935         * top.c (print_inferior_quit_action): Update.
2936         * thread.c (thr_try_catch_cmd): Update.
2937         (add_thread_with_info): Update.
2938         (thread_target_id_str): Update.
2939         (thr_try_catch_cmd): Update.
2940         (thread_command): Update.
2941         (thread_find_command): Update.
2942         * record-btrace.c (record_btrace_target::info_record)
2943         (record_btrace_resume_thread, record_btrace_target::resume)
2944         (record_btrace_cancel_resume, record_btrace_step_thread)
2945         (record_btrace_target::wait, record_btrace_target::wait)
2946         (record_btrace_target::wait, record_btrace_target::stop): Update.
2947         * progspace.c (print_program_space): Update.
2948         * process-stratum-target.c
2949         (process_stratum_target::thread_address_space): Update.
2950         * linux-fork.c (linux_fork_mourn_inferior)
2951         (detach_checkpoint_command, info_checkpoints_command)
2952         (linux_fork_context): Update.
2953         (linux_fork_detach): Update.
2954         (class scoped_switch_fork_info): Update.
2955         (delete_checkpoint_command): Update.
2956         * infrun.c (follow_fork_inferior): Update.
2957         (follow_fork_inferior): Update.
2958         (proceed_after_vfork_done): Update.
2959         (handle_vfork_child_exec_or_exit): Update.
2960         (follow_exec): Update.
2961         (displaced_step_prepare_throw): Update.
2962         (displaced_step_restore): Update.
2963         (start_step_over): Update.
2964         (resume_1): Update.
2965         (clear_proceed_status_thread): Update.
2966         (proceed): Update.
2967         (print_target_wait_results): Update.
2968         (do_target_wait): Update.
2969         (context_switch): Update.
2970         (stop_all_threads): Update.
2971         (restart_threads): Update.
2972         (finish_step_over): Update.
2973         (handle_signal_stop): Update.
2974         (switch_back_to_stepped_thread): Update.
2975         (keep_going_pass_signal): Update.
2976         (print_exited_reason): Update.
2977         (normal_stop): Update.
2978         * inferior.c (inferior_pid_to_str): Change return type.
2979         (print_selected_inferior): Update.
2980         (add_inferior): Update.
2981         (detach_inferior): Update.
2982         * dummy-frame.c (fprint_dummy_frames): Update.
2983         * dcache.c (dcache_info_1): Update.
2984         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2985         (btrace_fetch, btrace_clear): Update.
2986         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2987         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2988         type.
2989         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2990         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2991         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2992         * gdbarch.c, gdbarch.h: Rebuild.
2993         * gdbarch.sh (core_pid_to_str): Change return type.
2994         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2995         return type.
2996         (windows_nat_target::pid_to_str): Change return type.
2997         (windows_delete_thread): Update.
2998         (windows_nat_target::attach): Update.
2999         (windows_nat_target::files_info): Update.
3000         * target-delegates.c: Rebuild.
3001         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3002         return type.
3003         (sol_thread_target::pid_to_str): Change return type.
3004         * remote.c (class remote_target) <pid_to_str>: Change return
3005         type.
3006         (remote_target::pid_to_str): Change return type.
3007         (extended_remote_target::attach, remote_target::remote_stop_ns)
3008         (remote_target::remote_notif_remove_queued_reply)
3009         (remote_target::push_stop_reply, remote_target::disable_btrace):
3010         Update.
3011         (extended_remote_target::attach): Update.
3012         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3013         type.
3014         (gdbsim_target::pid_to_str): Change return type.
3015         * ravenscar-thread.c (struct ravenscar_thread_target)
3016         <pid_to_str>: Change return type.
3017         (ravenscar_thread_target::pid_to_str): Change return type.
3018         * procfs.c (class procfs_target) <pid_to_str>: Change return
3019         type.
3020         (procfs_target::pid_to_str): Change return type.
3021         (procfs_target::attach): Update.
3022         (procfs_target::detach): Update.
3023         (procfs_target::fetch_registers): Update.
3024         (procfs_target::store_registers): Update.
3025         (procfs_target::wait): Update.
3026         (procfs_target::files_info): Update.
3027         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3028         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3029         return type.
3030         (nto_procfs_target::pid_to_str): Change return type.
3031         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3032         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3033         return type.
3034         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3035         (exit_lwp): Update.
3036         (attach_proc_task_lwp_callback, get_detach_signal)
3037         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3038         (linux_nat_target::resume, wait_lwp, stop_callback)
3039         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3040         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3041         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3042         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3043         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3044         type.
3045         (inf_ptrace_target::attach): Update.
3046         (inf_ptrace_target::files_info): Update.
3047         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3048         type.
3049         (go32_nat_target::pid_to_str): Change return type.
3050         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3051         (gnu_nat_target::wait): Update.
3052         (gnu_nat_target::wait): Update.
3053         (gnu_nat_target::resume): Update.
3054         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3055         (fbsd_nat_target::wait): Update.
3056         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3057         type.
3058         (darwin_nat_target::attach): Update.
3059         * corelow.c (class core_target) <pid_to_str>: Change return type.
3060         (core_target::pid_to_str): Change return type.
3061         * target.c (normal_pid_to_str): Change return type.
3062         (default_pid_to_str): Likewise.
3063         (target_pid_to_str): Change return type.
3064         (target_translate_tls_address): Update.
3065         (target_announce_detach): Update.
3066         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3067         return type.
3068         (bsd_uthread_target::pid_to_str): Change return type.
3069         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3070         type.
3071         (bsd_kvm_target::pid_to_str): Change return type.
3072         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3073         return type.
3074         (aix_thread_target::pid_to_str): Change return type.
3075         * target.h (struct target_ops) <pid_to_str>: Change return type.
3076         (target_pid_to_str, normal_pid_to_str): Likewise.
3077         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3078         type.
3079         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3080         type.
3081         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3082         return type.
3083         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3084         type.
3085         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3086         type.
3087         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3088         return type.
3089
3090 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3091
3092         * NEWS: Mention that the new default MI version is 3.  Mention
3093         changes to the output of commands and events that deal with
3094         multi-location breakpoints.
3095         * breakpoint.c: Include "mi/mi-out.h".
3096         (print_one_breakpoint): Change output syntax if using MI version
3097         >= 3.
3098         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3099         New.
3100         (mi_multi_location_breakpoint_output_fixed): New.
3101         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3102         (mi_cmd_fix_multi_location_breakpoint_output): New.
3103         (mi_multi_location_breakpoint_output_fixed): New.
3104         * mi/mi-cmds.c (mi_cmds): Register command
3105         -fix-multi-location-breakpoint-output.
3106         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3107         interpreter "mi".
3108
3109 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3110
3111         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3112         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3113         instantiate mi_ui_out based on interpreter name.
3114         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3115         * mi/mi-main.c (mi_load_progress): Likewise.
3116
3117 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3118
3119         * NEWS: Combine separate "New targets" sections for 8.3.
3120
3121 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3122
3123         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3124         (ppcfbsd_init_abi): Install gdbarch
3125         "fetch_tls_load_module_address" and "get_thread_local_address"
3126         methods.
3127
3128 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3129
3130         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3131         (riscv_fbsd_init_abi): Install gdbarch
3132         "fetch_tls_load_module_address" and "get_thread_local_address"
3133         methods.
3134
3135 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3136
3137         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3138         (i386fbsd_init_abi): Install gdbarch
3139         "fetch_tls_load_module_address" and "get_thread_local_address"
3140         methods.
3141
3142 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3143
3144         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3145         (amd64fbsd_init_abi): Install gdbarch
3146         "fetch_tls_load_module_address" and "get_thread_local_address"
3147         methods.
3148
3149 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3150
3151         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3152         (struct fbsd_pspace_data): New type.
3153         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3154         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3155         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3156         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3157         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3158
3159 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3160
3161         * gdbtypes.c (lookup_struct_elt): New function.
3162         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3163         * gdbtypes.h (struct struct_elt): New type.
3164         (lookup_struct_elt): New prototype.
3165
3166 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3167
3168         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3169         remove disabled code block.
3170
3171 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3172
3173         * gdbarch.sh (get_thread_local_address): New method.
3174         * gdbarch.h, gdbarch.c: Regenerate.
3175         * target.c (target_translate_tls_address): Use
3176         gdbarch_get_thread_local_address if present instead of
3177         target::get_thread_local_address.
3178
3179 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3180
3181         * target.h (target::get_thread_local_address): Update comment.
3182
3183 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3184
3185         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3186         objfile->separate_debug_objfile_backlink if not NULL.
3187
3188 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3189
3190         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3191         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3192         (amd64bsd_store_inferior_registers): Likewise.
3193         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3194         Enable segment base registers.
3195         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3196         PT_GETFSBASE and PT_GETGSBASE.
3197         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3198         PT_SETGSBASE.
3199         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3200         segment base registers.
3201         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3202
3203 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3204
3205         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3206         Update calls to i386_target_description to add 'segments'
3207         parameter.
3208         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3209         add segment base registers.
3210         * arch/i386.c (i386_create_target_description): Add 'segments'
3211         parameter to enable segment base registers.
3212         * arch/i386.h (i386_create_target_description): Likewise.
3213         * features/i386/32bit-segments.xml: New file.
3214         * features/i386/32bit-segments.c: Generate.
3215         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3216         call to i386_target_description to add 'segments' parameter.
3217         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3218         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3219         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3220         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3221         if feature is present.
3222         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3223         Add 'segments' parameter to call to i386_target_description.
3224         (i386_target_description): Add 'segments' parameter to enable
3225         segment base registers.
3226         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3227         to call to i386_target_description.
3228         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3229         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3230         Define I386_NUM_REGS.
3231         (i386_target_description): Add 'segments' parameter to enable
3232         segment base registers.
3233
3234 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3235
3236         PR/24325
3237         * source-cache.c: #undef open and close, to avoid unresolved
3238         externals during linking.
3239
3240 2019-03-12  Tom Tromey  <tromey@adacore.com>
3241
3242         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3243         const.  Add initializers.
3244         (_initialize_remote): Don't initialize ptid globals.
3245
3246 2019-03-12  Pedro Alves  <palves@redhat.com>
3247
3248         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3249
3250 2019-03-12  Pedro Alves  <palves@redhat.com>
3251
3252         * cp-name-parser.y (main): Remove unused 'len' variable.
3253
3254 2019-03-12  Tom Tromey  <tromey@adacore.com>
3255
3256         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3257         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3258
3259 2019-03-12  Tom Tromey  <tromey@adacore.com>
3260
3261         * linux-nat.c (iterate_over_lwps): Update.
3262         (stop_callback): Remove parameter.
3263         (stop_wait_callback, detach_callback, resume_set_callback)
3264         (select_singlestep_lwp_callback, set_ignore_sigint)
3265         (status_callback, resumed_callback, resume_clear_callback)
3266         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3267         data parameter.
3268         (linux_nat_target::detach, linux_nat_target::resume)
3269         (linux_stop_and_wait_all_lwps, select_event_lwp)
3270         (linux_nat_filter_event, linux_nat_wait_1)
3271         (linux_nat_target::kill, linux_nat_target::stop)
3272         (linux_nat_target::stop): Update.
3273         (linux_nat_resume_callback): Change type.
3274         (resume_stopped_resumed_lwps, count_events_callback)
3275         (select_event_lwp_callback): Likewise.
3276         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3277         * arm-linux-nat.c (struct update_registers_data): Remove.
3278         (update_registers_callback): Change type.
3279         (arm_linux_insert_hw_breakpoint1): Update.
3280         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3281         parameter.
3282         (x86_linux_dr_set_addr): Update.
3283         (x86_linux_dr_set_control): Update.
3284         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3285         (iterate_over_lwps): Use gdb::function_view.
3286         * nat/aarch64-linux-hw-point.c (struct
3287         aarch64_dr_update_callback_param): Remove.
3288         (debug_reg_change_callback): Change type.
3289         (aarch64_notify_debug_reg_change): Update.
3290         * s390-linux-nat.c (s390_refresh_per_info): Update.
3291
3292 2019-03-11  Tom Tromey  <tromey@adacore.com>
3293
3294         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3295         redundant assignment to "this_cu".
3296
3297 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3298
3299         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3300
3301 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3302
3303         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3304         from...
3305         (rank_one_type): ... this.
3306
3307 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3308
3309         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3310         from...
3311         (rank_one_type): ... this.
3312
3313 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3314
3315         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3316         from...
3317         (rank_one_type): ... this.
3318
3319 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3320
3321         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3322         from...
3323         (rank_one_type): ... this.
3324
3325 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3326
3327         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3328         from...
3329         (rank_one_type): ... this.
3330
3331 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3332
3333         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3334         from...
3335         (rank_one_type): ... this.
3336
3337 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3338
3339         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3340         from...
3341         (rank_one_type): ... this.
3342
3343 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3344
3345         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3346         from...
3347         (rank_one_type): ... this.
3348
3349 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3350
3351         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3352         from...
3353         (rank_one_type): ... this.
3354
3355 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3356
3357         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3358         from...
3359         (rank_one_type): ... this.
3360
3361 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3362
3363         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3364         from...
3365         (rank_one_type): ... this.
3366
3367 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3368
3369         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3370         from...
3371         (rank_one_type): ... this.
3372
3373 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3374
3375         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3376         inferior-events' shows the example events.
3377
3378 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3379
3380         Support styling on native MS-Windows console
3381
3382         PR/24315
3383         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3384         on MS-Windows if $TERM is not defined.
3385
3386         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3387
3388         * posix-hdep.c (gdb_console_fputs):
3389         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3390         functions.
3391         * ui-file.h (gdb_console_fputs): Add prototype.
3392
3393         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3394         back to fputs only if the former returns zero.
3395
3396 2019-03-07  Tom Tromey  <tom@tromey.com>
3397
3398         * symmisc.c (print_symbol_bcache_statistics): Update.
3399         (print_objfile_statistics): Update.
3400         * symfile.c (allocate_symtab): Update.
3401         * stabsread.c: Don't include bcache.h.
3402         * psymtab.h (struct psymbol_bcache): Don't declare.
3403         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3404         (psymbol_bcache_init, psymbol_bcache_free)
3405         (psymbol_bcache_get_bcache): Don't declare.
3406         * psymtab.c (struct psymbol_bcache): Remove.
3407         (psymtab_storage::psymtab_storage): Update.
3408         (psymtab_storage::~psymtab_storage): Update.
3409         (psymbol_bcache_init, psymbol_bcache_free)
3410         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3411         (add_psymbol_to_bcache): Update.
3412         (allocate_psymtab): Update.
3413         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3414         macro_cache>: No longer pointers.
3415         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3416         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3417         * macrotab.c (macro_bcache): Update.
3418         * macroexp.c: Don't include bcache.h.
3419         * gdbtypes.c (check_types_worklist): Update.
3420         (types_deeply_equal): Remove TRY/CATCH.  Update.
3421         * elfread.c (elf_symtab_read): Update.
3422         * dwarf2read.c: Don't include bcache.h.
3423         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3424         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3425         (print_bcache_statistics, bcache_memory_used): Don't declare.
3426         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3427         methods.  Rename all data members.
3428         * bcache.c (struct bcache): Move to bcache.h.
3429         (bcache::expand_hash_table): Rename from expand_hash_table.
3430         (bcache): Remove.
3431         (bcache::insert): Rename from bcache_full.
3432         (bcache::compare): Rename from bcache_compare.
3433         (bcache_xmalloc): Remove.
3434         (bcache::~bcache): Rename from bcache_xfree.
3435         (bcache::print_statistics): Rename from print_bcache_statistics.
3436         (bcache::memory_used): Rename from bcache_memory_used.
3437
3438 2019-03-07  Pedro Alves  <palves@redhat.com>
3439
3440         * infrun.c (normal_stop): Also check for
3441         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3442
3443 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3444
3445         * f-lang.c (value_from_host_double): Moved to...
3446         * value.c (value_from_host_double): ...here.
3447         * value.h (value_from_host_double): Declare.
3448         * guile/scm-math.c (vlscm_convert_typed_number): Use
3449         value_from_host_double.
3450         (vlscm_convert_number): Likewise.
3451         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3452         * python/py-value.c (convert_value_from_python): Likewise.
3453
3454 2019-03-06  Tom Tromey  <tom@tromey.com>
3455
3456         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3457
3458 2019-03-06  Tom Tromey  <tom@tromey.com>
3459
3460         * utils.h (free_current_contents): Don't declare.
3461         * utils.c (free_current_contents): Remove.
3462
3463 2019-03-06  Tom Tromey  <tom@tromey.com>
3464
3465         * top.c (quit_force): Update.
3466         * main.c (captured_command_loop): Update.
3467         * common/new-op.c (operator new): Update.
3468         * common/common-exceptions.c (struct catcher)
3469         <save_cleanup_chain>: Remove member.
3470         (exceptions_state_mc_init): Update.
3471         (exception_try_scope_entry): Return nullptr.
3472         (exception_try_scope_exit, exception_rethrow)
3473         (throw_exception_sjlj, throw_exception_cxx): Update.
3474         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3475         (all_cleanups, do_cleanups, discard_cleanups)
3476         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3477         (restore_cleanups, restore_final_cleanups): Don't declare.
3478         (do_final_cleanups): Remove parameter.
3479         * common/cleanups.c (cleanup_chain, make_cleanup)
3480         (make_cleanup_dtor, all_cleanups, do_cleanups)
3481         (discard_my_cleanups, discard_cleanups)
3482         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3483         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3484         (null_cleanup): Remove.
3485         (do_final_cleanups): Remove parameter.
3486
3487 2019-03-06  Tom Tromey  <tom@tromey.com>
3488
3489         * remote.c (remote_target::remote_parse_stop_reply): Use
3490         unique_xmalloc_ptr.
3491
3492 2019-03-06  Tom Tromey  <tom@tromey.com>
3493
3494         * stabsread.c (struct stabs_field_info): Rename from field_info.
3495         <list, fnlist>: Add initializers.
3496         <obstack>: New member.
3497         (read_member_functions, read_struct_fields, read_baseclasses):
3498         Allocate on obstack.  Don't use cleanups.
3499         (read_one_struct_field, read_member_functions, read_struct_fields)
3500         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3501         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3502         (read_struct_type): Update.
3503
3504 2019-03-06  Tom Tromey  <tom@tromey.com>
3505
3506         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3507         * common/filestuff.h (make_cleanup_close): Don't declare.
3508         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3509         Remove.
3510
3511 2019-03-06  Tom Tromey  <tom@tromey.com>
3512
3513         * solib-aix.c: Use make_scope_exit.
3514
3515 2019-03-06  Tom Tromey  <tom@tromey.com>
3516
3517         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3518         Use make_scope_exit.
3519
3520 2019-03-06  Tom Tromey  <tom@tromey.com>
3521
3522         * solib-svr4.c (disable_probes_interface): Remove parameter.
3523         (svr4_handle_solib_event): Use make_scope_exit.
3524
3525 2019-03-06  Tom Tromey  <tom@tromey.com>
3526
3527         * remote.c (struct stop_reply_deleter): Remove.
3528         (stop_reply_up): Update.
3529         (struct stop_reply): Derive from notif_event.  Don't typedef.
3530         <regcache>: Now a std::vector.
3531         (stop_reply_xfree): Remove.
3532         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3533         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3534         (remote_target::discard_pending_stop_replies): Use delete.
3535         (remote_target::remote_parse_stop_reply): Update.
3536         (remote_target::process_stop_reply): Update.
3537         * remote-notif.h (struct notif_event): Add virtual destructor.
3538         Remove "dtr" member.
3539         (struct notif_client) <alloc_event>: Return a unique_ptr.
3540         (notif_event_xfree): Don't declare.
3541         (notif_event_up): New typedef.
3542         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3543         (notif_event_xfree, do_notif_event_xfree): Remove.
3544         (remote_notif_state_xfree): Update.
3545
3546 2019-03-06  Tom Tromey  <tom@tromey.com>
3547
3548         * infrun.c (displaced_step_clear_cleanup): Now a
3549         forward_scope_exit type.
3550         (displaced_step_prepare_throw): Update.
3551         (displaced_step_fixup): Update.
3552
3553 2019-03-06  Tom Tromey  <tom@tromey.com>
3554
3555         * inferior.h (class inferior): Update comment.
3556         * gdbthread.h (class thread_info): Update comment.
3557
3558 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3559             Tom Tromey  <tom@tromey.com>
3560
3561         * stabsread.h (struct stab_section_list): Remove.
3562         (coffstab_build_psymtabs): Update.
3563         * dbxread.c (symbuf_sections): Now a std::vector.
3564         (sect_idx): New global.
3565         (fill_symbuf): Update.
3566         (coffstab_build_psymtabs): Change type of stabsects parameter.
3567         Update.
3568         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3569         std::vector.
3570         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3571         (coff_locate_sections): Update.
3572         (coff_symfile_read): Remove cleanups.  Update.
3573         (init_stringtab): Add storage parameter.
3574         (free_stringtab, free_stringtab_cleanup): Remove.
3575         (init_lineno): Add storage parameter.
3576         (free_linetab, free_linetab_cleanup): Remove.
3577
3578 2019-03-06  Pedro Alves  <palves@redhat.com>
3579
3580         * linux-fork.c (fork_info::clobber_regs): Delete.
3581         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3582         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3583         comment.  Adjust.
3584         (scoped_switch_fork_info::scoped_switch_fork_info)
3585         (checkpoint_command, linux_fork_context): Adjust
3586         fork_save_infrun_state calls.
3587
3588 2019-03-06  Pedro Alves  <palves@redhat.com>
3589
3590         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3591         (inf_has_multiple_threads): Return 'bool' and rewrite using
3592         inferior_info::threads().
3593
3594 2019-03-06  Pedro Alves  <palves@redhat.com>
3595
3596         * linux-fork.c: Include <list>.
3597         (fork_list): Now a std::list instance.
3598         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3599         (forks_exist_p, find_last_fork): Adjust.
3600         (new_fork): Delete.
3601         (one_fork_p): New.
3602         (add_fork): Adjust.
3603         (free_fork): Delete, folded into fork_info::~fork_info().
3604         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3605         Adjust.
3606         (init_fork_list): Delete.
3607         (linux_fork_killall, linux_fork_mourn_inferior)
3608         (linux_fork_detach, info_checkpoints_command): Adjust.
3609         (_initialize_linux_fork): No longer call init_fork_list.
3610
3611 2019-03-06  Pedro Alves  <palves@redhat.com>
3612
3613         * linux-fork.c (new_fork): New, split out of ...
3614         (add_fork): ... this.  Return void.  Move "first fork" special
3615         case from here, to ...
3616         (checkpoint_command): ... here.
3617         * linux-linux.h (add_fork): Return void.
3618
3619 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3620
3621         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3622
3623 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3624             Chris January  <chris.january@arm.com>
3625             David Lecomber  <david.lecomber@arm.com>
3626
3627         * f-exp.y: New token, UNOP_INTRINSIC.
3628         (exp): New pattern using UNOP_INTRINSIC token.
3629         (f77_keywords): Add 'abs' keyword.
3630         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3631         (value_from_host_double): New function.
3632         (evaluate_subexp_f): Support UNOP_ABS.
3633
3634 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3635
3636         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3637         types.
3638
3639 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3640
3641         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3642         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3643         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3644
3645 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3646
3647         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3648
3649 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3650             Chris January  <chris.january@arm.com>
3651
3652         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3653         * f-exp.y: Define 'KIND' token.
3654         (exp): New pattern for KIND expressions.
3655         (ptype): Handle types with a kind extension.
3656         (direct_abs_decl): Extend to spot kind extensions.
3657         (f77_keywords): Add 'kind' to the list.
3658         (push_kind_type): New function.
3659         (convert_to_kind_type): New function.
3660         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3661         * parse.c (operator_length_standard): Likewise.
3662         * parser-defs.h (enum type_pieces): Add tp_kind.
3663         * std-operator.def: Add UNOP_KIND.
3664
3665 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3666
3667         * f-exp.y (f_parse): Set yydebug.
3668
3669 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3670
3671         * f-lang.c (evaluate_subexp_f): New function.
3672         (exp_descriptor_f): New global.
3673         (f_language_defn): Use exp_descriptor_f instead of
3674         exp_descriptor_standard.
3675
3676 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3677
3678         * f-exp.y (struct token): Add comments.
3679         (dot_ops): Remove uppercase versions and the end marker.
3680         (f77_keywords): Likewise.
3681         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3682         entries in the dot_ops array are case insensitive, and use
3683         strncasecmp to compare strings.  Also some whitespace cleanup in
3684         this area.  Similar for the f77_keywords array, except entries in
3685         this list might be case sensitive.
3686
3687 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3688
3689         * f-exp.y (struct f77_boolean_val): Add comments.
3690         (boolean_values): Remove uppercase versions, and end marker.
3691         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3692         and use strncasecmp to achieve case insensitivity.  Additionally,
3693         perform whitespace cleanup around this code.
3694
3695 2019-03-06  Tom Tromey  <tromey@adacore.com>
3696
3697         * remote-sim.c (gdbsim_target_open): Use result of
3698         gdb_argv::release.
3699
3700 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3701         Dirk Schubert  <dirk.schubert@arm.com>
3702         Chris January  <chris.january@arm.com>
3703
3704         * eval.c (evaluate_subexp_standard): Call Fortran argument
3705         wrapping logic.
3706         * f-lang.c (struct value): A value which can be passed into a
3707         Fortran function call.
3708         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3709         where appropriate.
3710         (struct type): Value ready for a Fortran function call.
3711         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3712         is needed.
3713         * f-lang.h (fortran_argument_convert): Declaration.
3714         (fortran_preserve_arg_pointer): Declaration.
3715         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3716
3717 2019-03-05  Tom Tromey  <tromey@adacore.com>
3718
3719         * python/py-prettyprint.c (print_string_repr): Remove #if.
3720         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3721
3722 2019-03-05  Tom Tromey  <tromey@adacore.com>
3723
3724         * target.c (the_dummy_target): Move later.  Change type to
3725         "dummy_target".
3726         (initialize_targets): Don't initialize the_dummy_target.
3727
3728 2019-03-05  Tom Tromey  <tromey@adacore.com>
3729
3730         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3731         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3732
3733 2019-03-05  Tom Tromey  <tromey@adacore.com>
3734
3735         * windows-nat.c (windows_nat_target::attach)
3736         (windows_nat_target::detach): Don't call gdb_flush.
3737         * valprint.c (generic_val_print, val_print, val_print_string):
3738         Don't call gdb_flush.
3739         * utils.c (defaulted_query): Don't call gdb_flush.
3740         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3741         * target.c (target_announce_detach): Don't call gdb_flush.
3742         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3743         * remote.c (extended_remote_target::attach): Don't call
3744         gdb_flush.
3745         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3746         * printcmd.c (do_examine): Don't call gdb_flush.
3747         (info_display_command): Don't call gdb_flush.
3748         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3749         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3750         * memattr.c (info_mem_command): Don't call gdb_flush.
3751         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3752         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3753         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3754         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3755         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3756         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3757         (gnu_nat_target::detach): Don't call gdb_flush.
3758         * f-valprint.c (f_val_print): Don't call gdb_flush.
3759         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3760         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3761         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3762         gdb_flush.
3763         * c-valprint.c (c_val_print): Don't call gdb_flush.
3764         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3765
3766 2019-03-05  Tom Tromey  <tromey@adacore.com>
3767
3768         * varobj.c (update_dynamic_varobj_children): Update.
3769         (install_default_visualizer): Use reset, not release.
3770         * value.c (set_internalvar): Update.
3771         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3772         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3773         ATTRIBUTE_UNUSED_RESULT.
3774
3775 2019-03-05  Tom Tromey  <tromey@adacore.com>
3776
3777         * remote.c (class scoped_remote_fd) <release>: Add
3778         ATTRIBUTE_UNUSED_RESULT.
3779
3780 2019-03-05  Tom Tromey  <tromey@adacore.com>
3781
3782         * macroexp.c (struct macro_buffer) <release>: Add
3783         ATTRIBUTE_UNUSED_RESULT.
3784
3785 2019-03-05  Tom Tromey  <tromey@adacore.com>
3786
3787         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3788         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3789         ATTRIBUTE_UNUSED_RESULT.
3790
3791 2019-03-05  Tom Tromey  <tromey@adacore.com>
3792
3793         * common/scoped_fd.h (class scoped_fd) <release>: Add
3794         ATTRIBUTE_UNUSED_RESULT.
3795
3796 2019-03-05  Tom Tromey  <tromey@adacore.com>
3797
3798         * parser-defs.h (struct parser_state) <release>: Add
3799         ATTRIBUTE_UNUSED_RESULT.
3800
3801 2019-03-05  Tom Tromey  <tromey@adacore.com>
3802
3803         * utils.h (class gdb_argv) <release>: Add
3804         ATTRIBUTE_UNUSED_RESULT.
3805         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3806
3807 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3808
3809         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3810         for-loop range, to avoid compiler warnings.
3811
3812         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3813         avoid compiler warnings about unused variables.
3814
3815         * NEWS: Mention end of support for native debugging on MS-Windows
3816         before XP.
3817
3818         PR gdb/24292
3819         * common/netstuff.c:
3820         * gdbserver/gdbreplay.c
3821         * gdbserver/remote-utils.c:
3822         * ser-tcp.c:
3823         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3824         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3825         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3826         'getaddrinfo' and 'freeaddrinfo' were not available before
3827         Windows XP, and mingw.org's MinGW headers by default define
3828         _WIN32_WINNT to 0x500.
3829
3830 2019-03-01  Gary Benson <gbenson@redhat.com>
3831
3832         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3833
3834 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3835             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3836
3837         PR gdb/8527
3838         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3839         set_sigint_trap, clear_sigint_trap.
3840
3841 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3842
3843         * target.c (target_detach): Clear the regcache and the
3844         frame cache.
3845
3846 2019-02-27  Pedro Alves  <palves@redhat.com>
3847
3848         * utils.c (set_screen_size): When we cap the height/width sizes,
3849         tweak the corresponding command variable to show "unlimited":
3850
3851 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3852             Pedro Alves  <palves@redhat.com>
3853
3854         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3855         before calling rl_set_screen_size.
3856
3857 2019-02-27  Tom Tromey  <tromey@adacore.com>
3858
3859         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3860         define.
3861         * python/py-value.c: Remove Python 2.4 workaround.
3862         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3863         workaround.
3864         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3865         Python 2.4 workaround.
3866         * python/python-internal.h: Remove Python 2.4 comment.
3867         (Py_ssize_t): Don't define.
3868         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3869         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3870         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3871         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3872         * python/python.c (do_start_initialization): Remove Python 2.4
3873         workaround.
3874         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3875         (print_children): Remove Python 2.4 workaround.
3876         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3877         workaround.
3878         (CHARBUFFERPROC_NAME): Remove.
3879         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3880         Python 2.4 workaround.
3881
3882 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3883
3884         * NEWS: Note minimum Python version.
3885
3886 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3887
3888         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3889         code from these functions.  Remove corresponding ifdefs.  Use
3890         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3891         Remove gotos and target of gotos.
3892         (infpy_search_memory): Likewise.
3893
3894 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3895
3896         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3897         (hppa_gdbarch_init): Don't register deleted functions with
3898         gdbarch.
3899
3900 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3901
3902         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3903         (h8300_unwind_sp): Delete.
3904         (h8300_dummy_id): Delete.
3905         (h8300_gdbarch_init): Don't register deleted functions with
3906         gdbarch.
3907
3908 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3909
3910         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3911         (ft32_unwind_pc): Delete.
3912         (ft32_unwind_sp): Delete.
3913         (ft32_gdbarch_init): Don't register deleted functions with
3914         gdbarch.
3915
3916 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3917
3918         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3919         (frv_unwind_pc): Delete.
3920         (frv_unwind_sp): Delete.
3921         (frv_gdbarch_init): Don't register deleted functions with
3922         gdbarch.
3923
3924 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3925
3926         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3927         (riscv_unwind_pc): Delete.
3928         (riscv_unwind_sp): Delete.
3929         (riscv_gdbarch_init): Don't register deleted functions with
3930         gdbarch.
3931
3932 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3933
3934         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3935         (csky_unwind_pc): Delete.
3936         (csky_unwind_sp): Delete.
3937         (csky_gdbarch_init): Don't register deleted functions with
3938         gdbarch.
3939
3940 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3941
3942         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3943         (cris_unwind_pc): Delete.
3944         (cris_unwind_sp): Delete.
3945         (cris_gdbarch_init): Don't register deleted functions with
3946         gdbarch.
3947
3948 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3949
3950         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3951         (bfin_unwind_pc): Delete.
3952         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3953
3954 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3955
3956         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3957         (arm_unwind_pc): Delete.
3958         (arm_unwind_sp): Delete.
3959         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3960
3961 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3962
3963         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3964         (arc_unwind_pc): Delete.
3965         (arc_unwind_sp): Delete.
3966         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3967
3968 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3969
3970         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3971         (alpha_unwind_pc): Delete.
3972         (alpha_gdbarch_init): Don't register deleted functions with
3973         gdbarch.
3974
3975 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3976
3977         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3978         (aarch64_unwind_pc): Delete.
3979         (aarch64_unwind_sp): Delete.
3980         (aarch64_gdbarch_init): Don't register deleted functions with
3981         gdbarch.
3982
3983 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3984
3985         * gdbtypes.c (type_align): Don't consider static members when
3986         computing structure alignment.
3987
3988 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3989
3990         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3991         return 0 for other types.
3992         * arch-utils.c (default_type_align): Always return 0.
3993         * gdbarch.h: Regenerate.
3994         * gdbarch.sh (type_align): Extend comment.
3995         * gdbtypes.c (type_align): Add additional comments, always call
3996         gdbarch_type_align before applying the default rules.
3997         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3998         generic code will then apply a suitable default.
3999         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4000         types, return 0 for other types.
4001
4002 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4003
4004         * NEWS: Create a new section for the next release branch.
4005         Rename the section of the current branch, now that it has
4006         been cut.
4007
4008 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4009
4010         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4011         * version.in: Bump version to 8.3.50.DATE-git.
4012
4013 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4014
4015         * aix-thread.c (ptid_cmp): Remove unused variable.
4016         (get_signaled_thread): Likewise.
4017         (store_regs_user_thread): Likewise.
4018         (store_regs_kernel_thread): Likewise.
4019         (fetch_regs_kernel_thread): Remove shadowed variable.
4020
4021 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4022
4023         * features/riscv/32bit-cpu.xml: Add register numbers.
4024         * features/riscv/32bit-fpu.c: Regenerate.
4025         * features/riscv/32bit-fpu.xml: Add register numbers.
4026         * features/riscv/64bit-cpu.xml: Add register numbers.
4027         * features/riscv/64bit-fpu.c: Regenerate.
4028         * features/riscv/64bit-fpu.xml: Add register numbers.
4029
4030 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4031
4032         * NEWS: Mention two argument form of gdb.Value constructor.
4033         * python/py-value.c (convert_buffer_and_type_to_value): New
4034         function.
4035         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4036         Add support for handling an optional second argument.  Call
4037         convert_buffer_and_type_to_value as appropriate.
4038         * python/python-internal.h (Py_buffer_deleter): New struct.
4039         (Py_buffer_up): New typedef.
4040
4041 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4042
4043         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4044         instead of releasing ownership.
4045
4046 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4047
4048         * dwarf2read.c (open_and_init_dwp_file): Call
4049         elf_numsections instead of bfd_count_sections to initialize
4050         dwp_file->num_sections.
4051
4052 2019-02-25  Tom Tromey  <tromey@adacore.com>
4053
4054         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4055
4056 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4057
4058         * gcore.in: Add '--readnever' option when invoking GDB.
4059
4060 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4061
4062         * MAINTAINERS: Update my email address.
4063
4064 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4065
4066         * build-id.c (build_id_to_debug_bfd_1): New function.
4067         (build_id_to_debug_bfd): Look for separate debug file in
4068         sysroot.
4069
4070 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4071
4072         * gdbarch.sh: Update the copyright year range that is placed into
4073         generated files.
4074
4075 2019-02-22  Keith Seitz  <keiths@redhat.com>
4076
4077         PR symtab/23853
4078         * linespec.c (create_sals_line_offset): Search for the default
4079         symtab's filename instead of its fullname.
4080
4081 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4082
4083         * NEWS: Update style defaults.
4084
4085 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4086
4087         * main.c (captured_main_1): Disable styling in batch mode.
4088
4089 2019-02-20  Tom Tromey  <tom@tromey.com>
4090
4091         * symtab.c (symtab_symbol_info): Fix typos.
4092
4093 2019-02-20  Tom Tromey  <tromey@adacore.com>
4094
4095         * findcmd.c (_initialize_mem_search): Use upper case for
4096         metasyntactic variables.
4097
4098 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4099
4100         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4101         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4102
4103 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4104
4105         * top.h (source_file_name): Change to std::string.
4106         * top.c (source_file_name): Likewise.
4107         (command_line_input): Adjust.
4108         * cli/cli-script.c (script_from_file): Adjust.
4109
4110 2019-02-19  Tom Tromey  <tromey@adacore.com>
4111
4112         * ravenscar-thread.c
4113         (ravenscar_thread_target::update_thread_list): Don't call
4114         ada_build_task_list.
4115         * ada-lang.h (ada_build_task_list): Don't declare.
4116         * ada-tasks.c (struct ada_tasks_inferior_data)
4117         <task_list_valid_p>: Now bool.
4118         (read_known_tasks, ada_task_list_changed)
4119         (ada_tasks_invalidate_inferior_data): Update.
4120         (read_known_tasks_array): Return bool.
4121         (read_known_tasks_list): Likewise.
4122         (read_known_tasks): Return void.
4123         (ada_build_task_list): Now static.
4124
4125 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4126
4127         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4128         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4129
4130 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4131
4132         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4133         variant for ada_tasks_pspace_data_handle and
4134         ada_tasks_inferior_data_handle.
4135         (ada_tasks_pspace_data_cleanup): New function.
4136         (ada_tasks_inferior_data_cleanup): New function.
4137
4138 2019-02-17  Tom Tromey  <tom@tromey.com>
4139
4140         * macrotab.h (macro_source_fullname): Return a std::string.
4141         * macrotab.c (macro_include, check_for_redefinition)
4142         (macro_undef, macro_lookup_definition, foreach_macro)
4143         (foreach_macro_in_scope): Update.
4144         (macro_source_fullname): Return a std::string.
4145         * macrocmd.c (show_pp_source_pos): Update.
4146
4147 2019-02-17  Tom Tromey  <tom@tromey.com>
4148
4149         * macrocmd.c (show_pp_source_pos): Style the file names.
4150
4151 2019-02-17  Tom Tromey  <tom@tromey.com>
4152
4153         PR tui/24197:
4154         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4155
4156 2019-02-17  Tom Tromey  <tom@tromey.com>
4157
4158         * ada-lang.c (user_select_syms): Use filtered printing.
4159         * utils.c (wrap_style): New global.
4160         (desired_style): Remove.
4161         (emit_style_escape): Add stream parameter.
4162         (set_output_style, reset_terminal_style, prompt_for_continue):
4163         Update.
4164         (flush_wrap_buffer): Only flush gdb_stdout.
4165         (wrap_here): Set wrap_style.
4166         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4167         treat escape sequences as a character.  Change when wrap buffer is
4168         flushed.
4169         (fputs_styled): Do not set the output style when the default is
4170         requested.
4171         * ui-style.h (struct ui_file_style) <is_default>: New method.
4172         * source.c (print_source_lines_base): Emit escape sequences in one
4173         piece.
4174
4175 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4176
4177         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4178         integers and enumeration types.
4179
4180 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4181
4182         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4183         instead of lookup_symbol_in_language
4184         (do_exact_match): New function.
4185         (ada_get_symbol_name_matcher): Return do_exact_match when
4186         doing a verbatim match.
4187
4188 2019-02-15  Tom Tromey  <tromey@adacore.com>
4189
4190         * ravenscar-thread.c (ravenscar_thread_target::resume)
4191         (ravenscar_thread_target::wait): Special case wildcard requests.
4192
4193 2019-02-15  Tom Tromey  <tromey@adacore.com>
4194
4195         * ravenscar-thread.c (base_ptid): Remove.
4196         (struct ravenscar_thread_target) <close>: New method.
4197         <m_base_ptid>: New member.
4198         <update_inferior_ptid, active_task, task_is_currently_active,
4199         runtime_initialized>: Declare methods.
4200         <ravenscar_thread_target>: Add constructor.
4201         (ravenscar_thread_target::task_is_currently_active)
4202         (ravenscar_thread_target::update_inferior_ptid)
4203         (ravenscar_runtime_initialized): Rename.  Now methods.
4204         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4205         (ravenscar_thread_target::update_thread_list): Update.
4206         (ravenscar_thread_target::active_task): Now method.
4207         (ravenscar_thread_target::store_registers)
4208         (ravenscar_thread_target::prepare_to_store)
4209         (ravenscar_thread_target::prepare_to_store)
4210         (ravenscar_thread_target::mourn_inferior): Update.
4211         (ravenscar_inferior_created): Use "new" to create target.
4212         (ravenscar_thread_target::get_ada_task_ptid): Update.
4213         (_initialize_ravenscar): Don't initialize base_ptid.
4214         (ravenscar_ops): Remove global.
4215
4216 2019-02-15  Tom Tromey  <tromey@adacore.com>
4217
4218         * target.h (push_target): Declare new overload.
4219         * target.c (push_target): New overload, taking an rvalue reference.
4220         * remote.c (remote_target::open_1): Use push_target overload.
4221         * corelow.c (core_target_open): Use push_target overload.
4222
4223 2019-02-15  Tom Tromey  <tromey@adacore.com>
4224
4225         * ravenscar-thread.c (is_ravenscar_task)
4226         (ravenscar_task_is_currently_active): Return bool.
4227         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4228         (_initialize_ravenscar): Remove "(void)".
4229         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4230         Return bool.
4231
4232 2019-02-15  Tom Tromey  <tromey@adacore.com>
4233
4234         * ravenscar-thread.c (ravenscar_runtime_initializer)
4235         (has_ravenscar_runtime, get_running_thread_id)
4236         (ravenscar_thread_target::resume): Fix indentation.
4237
4238 2019-02-15  Tom Tromey  <tromey@adacore.com>
4239
4240         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4241         from ravenscar_arch_ops.
4242         (sparc_ravenscar_ops::fetch_registers)
4243         (sparc_ravenscar_ops::store_registers): Now methods.
4244         (sparc_ravenscar_prepare_to_store): Remove.
4245         (sparc_ravenscar_ops): Redefine.
4246         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4247         methods and destructor.  Remove members.
4248         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4249         (ravenscar_thread_target::store_registers)
4250         (ravenscar_thread_target::prepare_to_store): Update.
4251         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4252         Remove.
4253         (struct ppc_ravenscar_powerpc_ops): Derive from
4254         ravenscar_arch_ops.
4255         (ppc_ravenscar_powerpc_ops::fetch_registers)
4256         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4257         (ppc_ravenscar_powerpc_ops): Redefine.
4258         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4259         (ppc_ravenscar_e500_ops::fetch_registers)
4260         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4261         (ppc_ravenscar_e500_ops): Redefine.
4262         * aarch64-ravenscar-thread.c
4263         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4264         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4265         (aarch64_ravenscar_fetch_registers)
4266         (aarch64_ravenscar_store_registers): Now methods.
4267         (aarch64_ravenscar_ops): Redefine.
4268
4269 2019-02-15  Tom Tromey  <tromey@adacore.com>
4270
4271         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4272         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4273         (ravenscar_thread_target::stopped_by_watchpoint)
4274         (ravenscar_thread_target::stopped_data_address)
4275         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4276
4277 2019-02-15  Tom Tromey  <tromey@adacore.com>
4278
4279         * ravenscar-thread.c: Fix some typos.
4280
4281 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4282             Tom Tromey  <tromey@adacore.com>
4283
4284         * ada-lang.c (ada_exception_sal): Change addr_string to a
4285         std::string.
4286         (create_ada_exception_catchpoint): Update.
4287
4288 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4289             Tom Tromey  <tromey@adacore.com>
4290
4291         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4292         (bp_location_ops): Remove.
4293         (base_breakpoint_allocate_location): Update.
4294         (free_bp_location): Update.
4295         * ada-lang.c (class ada_catchpoint_location)
4296         <ada_catchpoint_location>: Remove ops parameter.
4297         (ada_catchpoint_location_dtor): Remove.
4298         (ada_catchpoint_location_ops): Remove.
4299         (allocate_location_exception): Update.
4300         * breakpoint.h (struct bp_location_ops): Remove.
4301         (class bp_location) <bp_location>: Remove bp_location_ops
4302         parameter.
4303         <~bp_location>: Add destructor.
4304         <ops>: Remove.
4305
4306 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4307             Pedro Alves  <palves@redhat.com>
4308
4309         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4310         'PATH_MAX'.
4311
4312 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4313             Samuel Thibault  <samuel.thibault@gnu.org>
4314             Thomas Schwinge  <thomas@codesourcery.com>
4315
4316         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4317         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4318
4319 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4320
4321         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4322         (check_empty): Use "const char *".
4323
4324         * gnu-nat.c (gnu_nat_target::detach): Instead of
4325         'detach_inferior (pid)' call
4326         'detach_inferior (find_inferior_pid (pid))'.
4327
4328         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4329         'nat/fork-inferior.o'.
4330         * gnu-nat.c: #include "nat/fork-inferior.h".
4331
4332         * gnu-nat.c (gnu_nat_target::detach): Instead of
4333         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4334         * gnu-nat.h: #include "inf-child.h".
4335         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4336         'i386_gnu_nat_target::fetch_registers'.
4337         (gnu_store_registers): Rename/move to
4338         'i386_gnu_nat_target::store_registers'.
4339
4340         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4341         * gnu-nat.h (mach_thread_info): New function.
4342         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4343
4344         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4345
4346 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4347
4348         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4349
4350 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4351
4352         * windows-nat.c (windows_add_thread): Add new parameter
4353         "main_thread_p" with default value set to false.  Update
4354         function documentation as well as all callers.
4355         (windows_delete_thread): Likewise.
4356         (fake_create_process): Update call to windows_add_thread.
4357         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4358         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4359         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4360         call to windows_delete_thread.
4361
4362 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4363
4364         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4365
4366 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4367
4368         * symfile.c (find_separate_debug_file): Use canonical path of
4369         sysroot with child_path instead of gdb_sysroot if it is valid.
4370
4371 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4372
4373         * symfile.c (find_separate_debug_file): Use child_path to
4374         determine if an object file is under a sysroot.
4375
4376 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4377
4378         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4379         unittests/child-path-selftests.c.
4380         * common/pathstuff.c (child_path): New function.
4381         * common/pathstuff.h (child_path): New prototype.
4382         * unittests/child-path-selftests.c: New file.
4383
4384 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4385
4386         * symfile.c (find_separate_debug_file): Look for separate debug
4387         files in debug directories under the sysroot.
4388
4389 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4390
4391         * symtab.h (struct minimal_symbol data_p): New const method.
4392         (struct minimal_symbol text_p): Likewise.
4393         * symtab.c (output_source_filename): Use file name style
4394         to print file name.
4395         (print_symbol_info): Likewise.
4396         (print_msymbol_info): Use address style to print addresses.
4397         Use function name style to print executable text symbols.
4398         (expand_symtab_containing_pc): Use data_p.
4399         (find_pc_sect_compunit_symtab): Likewise.
4400
4401 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4402
4403         * breakpoint.c (describe_other_breakpoints): Use address style
4404         to print addresses.
4405         (say_where): Likewise.
4406
4407 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4408
4409         * ada-typeprint.c (print_func_type): Print function name
4410         style to print function name.
4411         * c-typeprint.c (c_print_type_1): Likewise.
4412
4413 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4414
4415         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4416         for execve.
4417
4418 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4419
4420         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4421         type_stack.
4422
4423 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4424
4425         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4426         TYPE_CODE_REF types.
4427
4428 2019-02-08  Jim Wilson  <jimw@sifive.com>
4429
4430         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4431         (riscv_linux_fregset): New.
4432         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4433
4434 2019-02-07  Tom Tromey  <tom@tromey.com>
4435
4436         * thread.c (thread_cancel_execution_command): Update.
4437         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4438         methods.
4439         (struct thread_fsm_ops): Remove.
4440         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4441         (thread_fsm_should_stop, thread_fsm_return_value)
4442         (thread_fsm_set_finished, thread_fsm_finished_p)
4443         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4444         Don't declare.
4445         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4446         * infrun.c (clear_proceed_status_thread)
4447         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4448         (print_stop_event): Update.
4449         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4450         Add constructor.
4451         (step_command_fsm_ops): Remove.
4452         (new_step_command_fsm): Remove.
4453         (step_1): Update.
4454         (step_command_fsm::should_stop): Rename from
4455         step_command_fsm_should_stop.
4456         (step_command_fsm::clean_up): Rename from
4457         step_command_fsm_clean_up.
4458         (step_command_fsm::do_async_reply_reason): Rename from
4459         step_command_fsm_async_reply_reason.
4460         (struct until_next_fsm): Inherit from thread_fsm.  Add
4461         constructor.
4462         (until_next_fsm_ops): Remove.
4463         (new_until_next_fsm): Remove.
4464         (until_next_fsm::should_stop): Rename from
4465         until_next_fsm_should_stop.
4466         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4467         (until_next_fsm::do_async_reply_reason): Rename from
4468         until_next_fsm_async_reply_reason.
4469         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4470         constructor.  Change type of breakpoint.
4471         (finish_command_fsm_ops): Remove.
4472         (new_finish_command_fsm): Remove.
4473         (finish_command_fsm::should_stop): Rename from
4474         finish_command_fsm_should_stop.
4475         (finish_command_fsm::clean_up): Rename from
4476         finish_command_fsm_clean_up.
4477         (finish_command_fsm::return_value): Rename from
4478         finish_command_fsm_return_value.
4479         (finish_command_fsm::do_async_reply_reason): Rename from
4480         finish_command_fsm_async_reply_reason.
4481         (finish_command): Update.
4482         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4483         Add constructor.
4484         (call_thread_fsm_ops): Remove.
4485         (call_thread_fsm::call_thread_fsm): Rename from
4486         new_call_thread_fsm.
4487         (call_thread_fsm::should_stop): Rename from
4488         call_thread_fsm_should_stop.
4489         (call_thread_fsm::should_notify_stop): Rename from
4490         call_thread_fsm_should_notify_stop.
4491         (run_inferior_call, call_function_by_hand_dummy): Update.
4492         * cli/cli-interp.c (should_print_stop_to_console): Update.
4493         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4494         Add constructor.  Change type of location_breakpoint,
4495         caller_breakpoint.
4496         (until_break_fsm_ops): Remove.
4497         (new_until_break_fsm): Remove.
4498         (until_break_fsm::should_stop): Rename from
4499         until_break_fsm_should_stop.
4500         (until_break_fsm::clean_up): Rename from
4501         until_break_fsm_clean_up.
4502         (until_break_fsm::do_async_reply_reason): Rename from
4503         until_break_fsm_async_reply_reason.
4504         (until_break_command): Update.
4505         * thread-fsm.c: Remove.
4506         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4507
4508 2019-02-07  Tom Tromey  <tom@tromey.com>
4509
4510         * yy-remap.h: Add include guard.
4511         * xtensa-tdep.h: Add include guard.
4512         * xcoffread.h: Rename include guard.
4513         * varobj-iter.h: Add include guard.
4514         * tui/tui.h: Rename include guard.
4515         * tui/tui-winsource.h: Rename include guard.
4516         * tui/tui-wingeneral.h: Rename include guard.
4517         * tui/tui-windata.h: Rename include guard.
4518         * tui/tui-win.h: Rename include guard.
4519         * tui/tui-stack.h: Rename include guard.
4520         * tui/tui-source.h: Rename include guard.
4521         * tui/tui-regs.h: Rename include guard.
4522         * tui/tui-out.h: Rename include guard.
4523         * tui/tui-layout.h: Rename include guard.
4524         * tui/tui-io.h: Rename include guard.
4525         * tui/tui-hooks.h: Rename include guard.
4526         * tui/tui-file.h: Rename include guard.
4527         * tui/tui-disasm.h: Rename include guard.
4528         * tui/tui-data.h: Rename include guard.
4529         * tui/tui-command.h: Rename include guard.
4530         * tic6x-tdep.h: Add include guard.
4531         * target/waitstatus.h: Rename include guard.
4532         * target/wait.h: Rename include guard.
4533         * target/target.h: Rename include guard.
4534         * target/resume.h: Rename include guard.
4535         * target-float.h: Rename include guard.
4536         * stabsread.h: Add include guard.
4537         * rs6000-tdep.h: Add include guard.
4538         * riscv-fbsd-tdep.h: Add include guard.
4539         * regformats/regdef.h: Rename include guard.
4540         * record.h: Rename include guard.
4541         * python/python.h: Rename include guard.
4542         * python/python-internal.h: Rename include guard.
4543         * python/py-stopevent.h: Rename include guard.
4544         * python/py-ref.h: Rename include guard.
4545         * python/py-record.h: Rename include guard.
4546         * python/py-record-full.h: Rename include guard.
4547         * python/py-record-btrace.h: Rename include guard.
4548         * python/py-instruction.h: Rename include guard.
4549         * python/py-events.h: Rename include guard.
4550         * python/py-event.h: Rename include guard.
4551         * procfs.h: Add include guard.
4552         * proc-utils.h: Add include guard.
4553         * p-lang.h: Add include guard.
4554         * or1k-tdep.h: Rename include guard.
4555         * observable.h: Rename include guard.
4556         * nto-tdep.h: Rename include guard.
4557         * nat/x86-linux.h: Rename include guard.
4558         * nat/x86-linux-dregs.h: Rename include guard.
4559         * nat/x86-gcc-cpuid.h: Add include guard.
4560         * nat/x86-dregs.h: Rename include guard.
4561         * nat/x86-cpuid.h: Rename include guard.
4562         * nat/ppc-linux.h: Rename include guard.
4563         * nat/mips-linux-watch.h: Rename include guard.
4564         * nat/linux-waitpid.h: Rename include guard.
4565         * nat/linux-ptrace.h: Rename include guard.
4566         * nat/linux-procfs.h: Rename include guard.
4567         * nat/linux-osdata.h: Rename include guard.
4568         * nat/linux-nat.h: Rename include guard.
4569         * nat/linux-namespaces.h: Rename include guard.
4570         * nat/linux-btrace.h: Rename include guard.
4571         * nat/glibc_thread_db.h: Rename include guard.
4572         * nat/gdb_thread_db.h: Rename include guard.
4573         * nat/gdb_ptrace.h: Rename include guard.
4574         * nat/fork-inferior.h: Rename include guard.
4575         * nat/amd64-linux-siginfo.h: Rename include guard.
4576         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4577         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4578         * nat/aarch64-linux.h: Rename include guard.
4579         * nat/aarch64-linux-hw-point.h: Rename include guard.
4580         * mn10300-tdep.h: Add include guard.
4581         * mips-linux-tdep.h: Add include guard.
4582         * mi/mi-parse.h: Rename include guard.
4583         * mi/mi-out.h: Rename include guard.
4584         * mi/mi-main.h: Rename include guard.
4585         * mi/mi-interp.h: Rename include guard.
4586         * mi/mi-getopt.h: Rename include guard.
4587         * mi/mi-console.h: Rename include guard.
4588         * mi/mi-common.h: Rename include guard.
4589         * mi/mi-cmds.h: Rename include guard.
4590         * mi/mi-cmd-break.h: Rename include guard.
4591         * m2-lang.h: Add include guard.
4592         * location.h: Rename include guard.
4593         * linux-record.h: Rename include guard.
4594         * linux-nat.h: Add include guard.
4595         * linux-fork.h: Add include guard.
4596         * i386-darwin-tdep.h: Rename include guard.
4597         * hppa-linux-offsets.h: Add include guard.
4598         * guile/guile.h: Rename include guard.
4599         * guile/guile-internal.h: Rename include guard.
4600         * gnu-nat.h: Rename include guard.
4601         * gdb-stabs.h: Rename include guard.
4602         * frv-tdep.h: Add include guard.
4603         * f-lang.h: Add include guard.
4604         * event-loop.h: Add include guard.
4605         * darwin-nat.h: Rename include guard.
4606         * cp-abi.h: Rename include guard.
4607         * config/sparc/nm-sol2.h: Rename include guard.
4608         * config/nm-nto.h: Rename include guard.
4609         * config/nm-linux.h: Add include guard.
4610         * config/i386/nm-i386gnu.h: Rename include guard.
4611         * config/djgpp/nl_types.h: Rename include guard.
4612         * config/djgpp/langinfo.h: Rename include guard.
4613         * compile/gcc-cp-plugin.h: Add include guard.
4614         * compile/gcc-c-plugin.h: Add include guard.
4615         * compile/compile.h: Rename include guard.
4616         * compile/compile-object-run.h: Rename include guard.
4617         * compile/compile-object-load.h: Rename include guard.
4618         * compile/compile-internal.h: Rename include guard.
4619         * compile/compile-cplus.h: Rename include guard.
4620         * compile/compile-c.h: Rename include guard.
4621         * common/xml-utils.h: Rename include guard.
4622         * common/x86-xstate.h: Rename include guard.
4623         * common/version.h: Rename include guard.
4624         * common/vec.h: Rename include guard.
4625         * common/tdesc.h: Rename include guard.
4626         * common/selftest.h: Rename include guard.
4627         * common/scoped_restore.h: Rename include guard.
4628         * common/scoped_mmap.h: Rename include guard.
4629         * common/scoped_fd.h: Rename include guard.
4630         * common/safe-iterator.h: Rename include guard.
4631         * common/run-time-clock.h: Rename include guard.
4632         * common/refcounted-object.h: Rename include guard.
4633         * common/queue.h: Rename include guard.
4634         * common/ptid.h: Rename include guard.
4635         * common/print-utils.h: Rename include guard.
4636         * common/preprocessor.h: Rename include guard.
4637         * common/pathstuff.h: Rename include guard.
4638         * common/observable.h: Rename include guard.
4639         * common/netstuff.h: Rename include guard.
4640         * common/job-control.h: Rename include guard.
4641         * common/host-defs.h: Rename include guard.
4642         * common/gdb_wait.h: Rename include guard.
4643         * common/gdb_vecs.h: Rename include guard.
4644         * common/gdb_unlinker.h: Rename include guard.
4645         * common/gdb_unique_ptr.h: Rename include guard.
4646         * common/gdb_tilde_expand.h: Rename include guard.
4647         * common/gdb_sys_time.h: Rename include guard.
4648         * common/gdb_string_view.h: Rename include guard.
4649         * common/gdb_splay_tree.h: Rename include guard.
4650         * common/gdb_setjmp.h: Rename include guard.
4651         * common/gdb_ref_ptr.h: Rename include guard.
4652         * common/gdb_optional.h: Rename include guard.
4653         * common/gdb_locale.h: Rename include guard.
4654         * common/gdb_assert.h: Rename include guard.
4655         * common/filtered-iterator.h: Rename include guard.
4656         * common/filestuff.h: Rename include guard.
4657         * common/fileio.h: Rename include guard.
4658         * common/environ.h: Rename include guard.
4659         * common/common-utils.h: Rename include guard.
4660         * common/common-types.h: Rename include guard.
4661         * common/common-regcache.h: Rename include guard.
4662         * common/common-inferior.h: Rename include guard.
4663         * common/common-gdbthread.h: Rename include guard.
4664         * common/common-exceptions.h: Rename include guard.
4665         * common/common-defs.h: Rename include guard.
4666         * common/common-debug.h: Rename include guard.
4667         * common/cleanups.h: Rename include guard.
4668         * common/buffer.h: Rename include guard.
4669         * common/btrace-common.h: Rename include guard.
4670         * common/break-common.h: Rename include guard.
4671         * cli/cli-utils.h: Rename include guard.
4672         * cli/cli-style.h: Rename include guard.
4673         * cli/cli-setshow.h: Rename include guard.
4674         * cli/cli-script.h: Rename include guard.
4675         * cli/cli-interp.h: Rename include guard.
4676         * cli/cli-decode.h: Rename include guard.
4677         * cli/cli-cmds.h: Rename include guard.
4678         * charset-list.h: Add include guard.
4679         * buildsym-legacy.h: Rename include guard.
4680         * bfin-tdep.h: Add include guard.
4681         * ax.h: Rename include guard.
4682         * arm-linux-tdep.h: Add include guard.
4683         * arm-fbsd-tdep.h: Add include guard.
4684         * arch/xtensa.h: Rename include guard.
4685         * arch/tic6x.h: Add include guard.
4686         * arch/i386.h: Add include guard.
4687         * arch/arm.h: Rename include guard.
4688         * arch/arm-linux.h: Rename include guard.
4689         * arch/arm-get-next-pcs.h: Rename include guard.
4690         * arch/amd64.h: Add include guard.
4691         * arch/aarch64-insn.h: Rename include guard.
4692         * arch-utils.h: Rename include guard.
4693         * annotate.h: Add include guard.
4694         * amd64-darwin-tdep.h: Rename include guard.
4695         * aarch64-linux-tdep.h: Add include guard.
4696         * aarch64-fbsd-tdep.h: Add include guard.
4697         * aarch32-linux-nat.h: Add include guard.
4698
4699 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4700
4701         * macrotab.c (macro_define_internal): New function that
4702         factorizes macro_define_object_internal and macro_define_function
4703         code.
4704         (macro_define_object_internal): Use macro_define_internal.
4705         (macro_define_function): Likewise.
4706
4707 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4708
4709         * macrocmd.c (extract_identifier): Return
4710         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4711         callers.
4712
4713 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4714
4715         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4716
4717 2019-02-05  Tom Tromey  <tom@tromey.com>
4718
4719         * target.c (target_stack::unpush): Move assertion earlier.
4720
4721 2019-01-30  Tom Tromey  <tom@tromey.com>
4722
4723         PR python/23615:
4724         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4725         (gdbpy_parse_and_eval): Likewise.
4726         * python/python-internal.h (gdbpy_allow_threads): New class.
4727
4728 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4729
4730         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4731         (aarch64_fbsd_fpregmap): Move earlier.
4732         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4733         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4734         instead of individual calls to trad_frame_set_reg_addr.
4735         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4736         earlier.
4737         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4738         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4739         instead of individual calls to trad_frame_set_reg_addr.
4740
4741 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4742
4743         * CONTRIBUTE: Replace contribution list with wiki link.
4744
4745 2019-01-25  Tom Tromey  <tom@tromey.com>
4746
4747         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4748
4749 2019-01-25  Tom Tromey  <tom@tromey.com>
4750
4751         * xtensa-linux-nat.c: Fix common/ includes.
4752         * xml-support.h: Fix common/ includes.
4753         * xml-support.c: Fix common/ includes.
4754         * x86-linux-nat.c: Fix common/ includes.
4755         * windows-nat.c: Fix common/ includes.
4756         * varobj.h: Fix common/ includes.
4757         * varobj.c: Fix common/ includes.
4758         * value.c: Fix common/ includes.
4759         * valops.c: Fix common/ includes.
4760         * utils.c: Fix common/ includes.
4761         * unittests/xml-utils-selftests.c: Fix common/ includes.
4762         * unittests/utils-selftests.c: Fix common/ includes.
4763         * unittests/unpack-selftests.c: Fix common/ includes.
4764         * unittests/tracepoint-selftests.c: Fix common/ includes.
4765         * unittests/style-selftests.c: Fix common/ includes.
4766         * unittests/string_view-selftests.c: Fix common/ includes.
4767         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4768         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4769         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4770         * unittests/rsp-low-selftests.c: Fix common/ includes.
4771         * unittests/parse-connection-spec-selftests.c: Fix common/
4772         includes.
4773         * unittests/optional-selftests.c: Fix common/ includes.
4774         * unittests/offset-type-selftests.c: Fix common/ includes.
4775         * unittests/observable-selftests.c: Fix common/ includes.
4776         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4777         * unittests/memrange-selftests.c: Fix common/ includes.
4778         * unittests/memory-map-selftests.c: Fix common/ includes.
4779         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4780         * unittests/function-view-selftests.c: Fix common/ includes.
4781         * unittests/environ-selftests.c: Fix common/ includes.
4782         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4783         * unittests/common-utils-selftests.c: Fix common/ includes.
4784         * unittests/cli-utils-selftests.c: Fix common/ includes.
4785         * unittests/array-view-selftests.c: Fix common/ includes.
4786         * ui-file.c: Fix common/ includes.
4787         * tui/tui-io.c: Fix common/ includes.
4788         * tracepoint.h: Fix common/ includes.
4789         * tracepoint.c: Fix common/ includes.
4790         * tracefile-tfile.c: Fix common/ includes.
4791         * top.h: Fix common/ includes.
4792         * top.c: Fix common/ includes.
4793         * thread.c: Fix common/ includes.
4794         * target/waitstatus.h: Fix common/ includes.
4795         * target/waitstatus.c: Fix common/ includes.
4796         * target.h: Fix common/ includes.
4797         * target.c: Fix common/ includes.
4798         * target-memory.c: Fix common/ includes.
4799         * target-descriptions.c: Fix common/ includes.
4800         * symtab.h: Fix common/ includes.
4801         * symfile.c: Fix common/ includes.
4802         * stap-probe.c: Fix common/ includes.
4803         * spu-linux-nat.c: Fix common/ includes.
4804         * sparc-nat.c: Fix common/ includes.
4805         * source.c: Fix common/ includes.
4806         * solib.c: Fix common/ includes.
4807         * solib-target.c: Fix common/ includes.
4808         * ser-unix.c: Fix common/ includes.
4809         * ser-tcp.c: Fix common/ includes.
4810         * ser-pipe.c: Fix common/ includes.
4811         * ser-base.c: Fix common/ includes.
4812         * selftest-arch.c: Fix common/ includes.
4813         * s12z-tdep.c: Fix common/ includes.
4814         * rust-exp.y: Fix common/ includes.
4815         * rs6000-aix-tdep.c: Fix common/ includes.
4816         * riscv-tdep.c: Fix common/ includes.
4817         * remote.c: Fix common/ includes.
4818         * remote-notif.h: Fix common/ includes.
4819         * remote-fileio.h: Fix common/ includes.
4820         * remote-fileio.c: Fix common/ includes.
4821         * regcache.h: Fix common/ includes.
4822         * regcache.c: Fix common/ includes.
4823         * record-btrace.c: Fix common/ includes.
4824         * python/python.c: Fix common/ includes.
4825         * python/py-type.c: Fix common/ includes.
4826         * python/py-inferior.c: Fix common/ includes.
4827         * progspace.h: Fix common/ includes.
4828         * producer.c: Fix common/ includes.
4829         * procfs.c: Fix common/ includes.
4830         * proc-api.c: Fix common/ includes.
4831         * printcmd.c: Fix common/ includes.
4832         * ppc-linux-nat.c: Fix common/ includes.
4833         * parser-defs.h: Fix common/ includes.
4834         * osdata.c: Fix common/ includes.
4835         * obsd-nat.c: Fix common/ includes.
4836         * nat/x86-linux.c: Fix common/ includes.
4837         * nat/x86-linux-dregs.c: Fix common/ includes.
4838         * nat/x86-dregs.h: Fix common/ includes.
4839         * nat/x86-dregs.c: Fix common/ includes.
4840         * nat/ppc-linux.c: Fix common/ includes.
4841         * nat/mips-linux-watch.h: Fix common/ includes.
4842         * nat/mips-linux-watch.c: Fix common/ includes.
4843         * nat/linux-waitpid.c: Fix common/ includes.
4844         * nat/linux-ptrace.h: Fix common/ includes.
4845         * nat/linux-ptrace.c: Fix common/ includes.
4846         * nat/linux-procfs.c: Fix common/ includes.
4847         * nat/linux-personality.c: Fix common/ includes.
4848         * nat/linux-osdata.c: Fix common/ includes.
4849         * nat/linux-namespaces.c: Fix common/ includes.
4850         * nat/linux-btrace.h: Fix common/ includes.
4851         * nat/linux-btrace.c: Fix common/ includes.
4852         * nat/fork-inferior.c: Fix common/ includes.
4853         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4854         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4855         * nat/aarch64-linux.c: Fix common/ includes.
4856         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4857         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4858         * namespace.h: Fix common/ includes.
4859         * mips-linux-tdep.c: Fix common/ includes.
4860         * minsyms.c: Fix common/ includes.
4861         * mi/mi-parse.h: Fix common/ includes.
4862         * mi/mi-main.c: Fix common/ includes.
4863         * mi/mi-cmd-env.c: Fix common/ includes.
4864         * memrange.h: Fix common/ includes.
4865         * memattr.c: Fix common/ includes.
4866         * maint.h: Fix common/ includes.
4867         * maint.c: Fix common/ includes.
4868         * main.c: Fix common/ includes.
4869         * machoread.c: Fix common/ includes.
4870         * location.c: Fix common/ includes.
4871         * linux-thread-db.c: Fix common/ includes.
4872         * linux-nat.c: Fix common/ includes.
4873         * linux-fork.c: Fix common/ includes.
4874         * inline-frame.c: Fix common/ includes.
4875         * infrun.c: Fix common/ includes.
4876         * inflow.c: Fix common/ includes.
4877         * inferior.h: Fix common/ includes.
4878         * inferior.c: Fix common/ includes.
4879         * infcmd.c: Fix common/ includes.
4880         * inf-ptrace.c: Fix common/ includes.
4881         * inf-child.c: Fix common/ includes.
4882         * ia64-linux-nat.c: Fix common/ includes.
4883         * i387-tdep.c: Fix common/ includes.
4884         * i386-tdep.c: Fix common/ includes.
4885         * i386-linux-tdep.c: Fix common/ includes.
4886         * i386-linux-nat.c: Fix common/ includes.
4887         * i386-go32-tdep.c: Fix common/ includes.
4888         * i386-fbsd-tdep.c: Fix common/ includes.
4889         * i386-fbsd-nat.c: Fix common/ includes.
4890         * guile/scm-type.c: Fix common/ includes.
4891         * guile/guile.c: Fix common/ includes.
4892         * go32-nat.c: Fix common/ includes.
4893         * gnu-nat.c: Fix common/ includes.
4894         * gdbthread.h: Fix common/ includes.
4895         * gdbarch-selftests.c: Fix common/ includes.
4896         * gdb_usleep.c: Fix common/ includes.
4897         * gdb_select.h: Fix common/ includes.
4898         * gdb_bfd.c: Fix common/ includes.
4899         * gcore.c: Fix common/ includes.
4900         * fork-child.c: Fix common/ includes.
4901         * findvar.c: Fix common/ includes.
4902         * fbsd-nat.c: Fix common/ includes.
4903         * event-top.c: Fix common/ includes.
4904         * event-loop.c: Fix common/ includes.
4905         * dwarf2read.c: Fix common/ includes.
4906         * dwarf2loc.c: Fix common/ includes.
4907         * dwarf2-frame.c: Fix common/ includes.
4908         * dwarf-index-cache.c: Fix common/ includes.
4909         * dtrace-probe.c: Fix common/ includes.
4910         * disasm-selftests.c: Fix common/ includes.
4911         * defs.h: Fix common/ includes.
4912         * csky-tdep.c: Fix common/ includes.
4913         * cp-valprint.c: Fix common/ includes.
4914         * cp-support.h: Fix common/ includes.
4915         * cp-support.c: Fix common/ includes.
4916         * corelow.c: Fix common/ includes.
4917         * completer.h: Fix common/ includes.
4918         * completer.c: Fix common/ includes.
4919         * compile/compile.c: Fix common/ includes.
4920         * compile/compile-loc2c.c: Fix common/ includes.
4921         * compile/compile-cplus-types.c: Fix common/ includes.
4922         * compile/compile-cplus-symbols.c: Fix common/ includes.
4923         * command.h: Fix common/ includes.
4924         * cli/cli-dump.c: Fix common/ includes.
4925         * cli/cli-cmds.c: Fix common/ includes.
4926         * charset.c: Fix common/ includes.
4927         * build-id.c: Fix common/ includes.
4928         * btrace.h: Fix common/ includes.
4929         * btrace.c: Fix common/ includes.
4930         * breakpoint.h: Fix common/ includes.
4931         * breakpoint.c: Fix common/ includes.
4932         * ax.h:
4933         (enum agent_op): Fix common/ includes.
4934         * ax-general.c (struct aop_map): Fix common/ includes.
4935         * ax-gdb.c: Fix common/ includes.
4936         * auxv.c: Fix common/ includes.
4937         * auto-load.c: Fix common/ includes.
4938         * arm-tdep.c: Fix common/ includes.
4939         * arch/riscv.c: Fix common/ includes.
4940         * arch/ppc-linux-common.c: Fix common/ includes.
4941         * arch/i386.c: Fix common/ includes.
4942         * arch/arm.c: Fix common/ includes.
4943         * arch/arm-linux.c: Fix common/ includes.
4944         * arch/arm-get-next-pcs.c: Fix common/ includes.
4945         * arch/amd64.c: Fix common/ includes.
4946         * arch/aarch64.c: Fix common/ includes.
4947         * arch/aarch64-insn.c: Fix common/ includes.
4948         * arch-utils.c: Fix common/ includes.
4949         * amd64-windows-tdep.c: Fix common/ includes.
4950         * amd64-tdep.c: Fix common/ includes.
4951         * amd64-sol2-tdep.c: Fix common/ includes.
4952         * amd64-obsd-tdep.c: Fix common/ includes.
4953         * amd64-nbsd-tdep.c: Fix common/ includes.
4954         * amd64-linux-tdep.c: Fix common/ includes.
4955         * amd64-linux-nat.c: Fix common/ includes.
4956         * amd64-fbsd-tdep.c: Fix common/ includes.
4957         * amd64-fbsd-nat.c: Fix common/ includes.
4958         * amd64-dicos-tdep.c: Fix common/ includes.
4959         * amd64-darwin-tdep.c: Fix common/ includes.
4960         * agent.c: Fix common/ includes.
4961         * ada-lang.h: Fix common/ includes.
4962         * ada-lang.c: Fix common/ includes.
4963         * aarch64-tdep.c: Fix common/ includes.
4964
4965 2019-01-25  Tom Tromey  <tom@tromey.com>
4966
4967         * common/create-version.sh: Use common/version.h.
4968
4969 2019-01-24  Pedro Alves  <palves@redhat.com>
4970
4971         * infrun.c (signal_stop, signal_print, signal_program)
4972         (signal_catch, signal_pass): Now arrays instead of pointers.
4973         (update_signals_program_target, do_target_resume)
4974         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4975         * linux-nat.c (linux_nat_target::pass_signals)
4976         (linux_nat_target::create_inferior, linux_nat_target::attach):
4977         Adjust.
4978         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4979         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4980         * procfs.c (procfs_target::pass_signals): Adjust.
4981         * record-full.c (record_full_target::resume): Adjust.
4982         * remote.c (remote_target::pass_signals)
4983         (remote_target::program_signals): Adjust.
4984         * target-debug.h (target_debug_print_signals): Now takes a
4985         gdb::array_view as parameter.  Adjust.
4986         * target.h (target_ops) <pass_signals, program_signals>: Replace
4987         pointer and length parameters with gdb::array_view.
4988         (target_pass_signals, target_program_signals): Likewise.
4989         * target-delegates.c: Regenerate.
4990
4991 2019-01-24  Pedro Alves  <palves@redhat.com>
4992
4993         * common/forward-scope-exit.h
4994         (forward_scope_exit::forward_scope_exit): Pass arguments to
4995         m_bind_function directly, instead of creating a std::bind and
4996         copying that.
4997
4998 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4999
5000         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5001         for static members.
5002         (pass_in_v_vfp_candidate): Likewise.
5003
5004 2019-01-23  Tom Tromey  <tom@tromey.com>
5005             Pedro Alves  <palves@redhat.com>
5006
5007         * regcache.c (class regcache_invalidator): Remove.
5008         (regcache::raw_write): Use make_scope_exit.
5009
5010 2019-01-23  Tom Tromey  <tom@tromey.com>
5011
5012         * ui-out.h (class ui_out_emit_type): Update comment.
5013
5014 2019-01-23  Tom Tromey  <tom@tromey.com>
5015
5016         * infrun.c (fetch_inferior_event): Update comment.
5017
5018 2019-01-23  Tom Tromey  <tom@tromey.com>
5019             Pedro Alves  <palves@redhat.com>
5020
5021         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5022         parameter.
5023         (fetch_inferior_event): Use SCOPE_EXIT.
5024
5025
5026 2019-01-23  Tom Tromey  <tom@tromey.com>
5027             Pedro Alves  <palves@redhat.com>
5028
5029         * infrun.c (disable_thread_events): Delete.
5030         (stop_all_threads): Use SCOPE_EXIT.
5031
5032 2019-01-23  Tom Tromey  <tom@tromey.com>
5033             Pedro Alves  <palves@redhat.com>
5034
5035         * symfile.c: Include forward-scope-exit.h.
5036         (clear_symtab_users_cleanup): Replace forward declaration with
5037         a FORWARD_SCOPE_EXIT.
5038         (syms_from_objfile_1): Use the forward_scope_exit and
5039         gdb::optional instead of cleanup_function.
5040         (reread_symbols): Use the forward_scope_exit instead of
5041         cleanup_function.
5042         (clear_symtab_users_cleanup): Remove function.
5043
5044 2019-01-23  Tom Tromey  <tom@tromey.com>
5045             Pedro Alves  <palves@redhat.com>
5046
5047         * linux-nat.c: Include scope-exit.h.
5048         (cleanup_target_stop): Remove.
5049         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5050         SCOPE_EXIT.
5051
5052 2019-01-23  Tom Tromey  <tom@tromey.com>
5053             Pedro Alves  <palves@redhat.com>
5054
5055         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5056         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5057
5058 2019-01-23  Tom Tromey  <tom@tromey.com>
5059             Andrew Burgess  <andrew.burgess@embecosm.com>
5060             Pedro Alves  <palves@redhat.com>
5061
5062         * infrun.c (fetch_inferior_event): Use scope_exit.
5063         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5064         * top.c (execute_command): Use scope_exit.
5065         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5066         * utils.c (do_bpstat_clear_actions_cleanup)
5067         (make_bpstat_clear_actions_cleanup): Remove.
5068
5069 2019-01-23  Tom Tromey  <tom@tromey.com>
5070             Pedro Alves  <palves@redhat.com>
5071
5072         * infrun.c: Include "common/scope-exit.h"
5073         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5074         (wait_for_inferior): Use SCOPE_EXIT.
5075         (fetch_inferior_event): Use scope_exit.
5076
5077 2019-01-23  Tom Tromey  <tom@tromey.com>
5078             Pedro Alves  <palves@redhat.com>
5079
5080         * breakpoint.c (create_breakpoint): Remove cleanup.
5081
5082 2019-01-23  Tom Tromey  <tom@tromey.com>
5083             Andrew Burgess  <andrew.burgess@embecosm.com>
5084             Pedro Alves  <palves@redhat.com>
5085
5086 2019-01-23  Pedro Alves  <palves@redhat.com>
5087
5088         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5089
5090 2019-01-23  Pedro Alves  <palves@redhat.com>
5091             Andrew Burgess  <andrew.burgess@embecosm.com>
5092
5093         * gdbthread.h: Include "common/forward-scope-exit.h".
5094         (scoped_finish_thread_state): Redefine custom class in terms of
5095         forward_scope_exit.
5096
5097 2019-01-23  Pedro Alves  <palves@redhat.com>
5098             Andrew Burgess  <andrew.burgess@embecosm.com>
5099
5100         * common/forward-scope-exit.h: New file.
5101
5102 2019-01-23  Pedro Alves  <palves@redhat.com>
5103             Andrew Burgess  <andrew.burgess@embecosm.com>
5104             Tom Tromey  <tom@tromey.com>
5105
5106         * common/scope-exit.h: New file.
5107
5108 2019-01-23  Pedro Alves  <palves@redhat.com>
5109
5110         * common/preprocessor.h (ESC): Rename to ...
5111         (ESC_PARENS): ... this.
5112         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5113         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5114
5115 2019-01-23  Tom Tromey  <tom@tromey.com>
5116
5117         * language.h (class scoped_switch_to_sym_language_if_auto):
5118         Initialize m_lang in both cases.
5119
5120 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5121
5122         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5123         with XCNEW.
5124
5125 2019-01-22  Tom Tromey  <tom@tromey.com>
5126
5127         * corelow.c: Do not include sys/file.h.
5128
5129 2019-01-22  Tom Tromey  <tom@tromey.com>
5130
5131         * tui/tui-wingeneral.h: Include gdb_curses.h.
5132
5133 2019-01-22  Tom Tromey  <tom@tromey.com>
5134
5135         * source-cache.h (class source_cache) <get_source_lines,
5136         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5137
5138 2019-01-22  Tom Tromey  <tom@tromey.com>
5139
5140         * remote-fileio.h (struct remote_target): Declare.
5141
5142 2019-01-22  Tom Tromey  <tom@tromey.com>
5143
5144         * python/py-arch.c: Do not include py-ref.h.
5145         * python/py-bpevent.c: Do not include py-ref.h.
5146         * python/py-cmd.c: Do not include py-ref.h.
5147         * python/py-continueevent.c: Do not include py-ref.h.
5148         * python/py-event.h: Do not include py-ref.h.
5149         * python/py-evtregistry.c: Do not include py-ref.h.
5150         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5151         * python/py-frame.c: Do not include py-ref.h.
5152         * python/py-framefilter.c: Do not include py-ref.h.
5153         * python/py-function.c: Do not include py-ref.h.
5154         * python/py-infevents.c: Do not include py-ref.h.
5155         * python/py-linetable.c: Do not include py-ref.h.
5156         * python/py-objfile.c: Do not include py-ref.h.
5157         * python/py-param.c: Do not include py-ref.h.
5158         * python/py-prettyprint.c: Do not include py-ref.h.
5159         * python/py-progspace.c: Do not include py-ref.h.
5160         * python/py-symbol.c: Do not include py-ref.h.
5161         * python/py-symtab.c: Do not include py-ref.h.
5162         * python/py-type.c: Do not include py-ref.h.
5163         * python/py-unwind.c: Do not include py-ref.h.
5164         * python/py-utils.c: Do not include py-ref.h.
5165         * python/py-value.c: Do not include py-ref.h.
5166         * python/py-varobj.c: Do not include py-ref.h.
5167         * python/py-xmethods.c: Do not include py-ref.h.
5168         * python/python.c: Do not include py-ref.h.
5169         * varobj.c: Do not include py-ref.h.
5170
5171 2019-01-22  Tom Tromey  <tom@tromey.com>
5172
5173         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5174         keyword for bcache.
5175
5176 2019-01-22  Tom Tromey  <tom@tromey.com>
5177
5178         * compile/compile-cplus-types.c: Remove a comment by #include.
5179
5180 2019-01-22  Tom Tromey  <tom@tromey.com>
5181
5182         * compile/gcc-c-plugin.h: Include compile-internal.h.
5183
5184 2019-01-22  Tom Tromey  <tom@tromey.com>
5185
5186         * stabsread.c (EXTERN): Do not define.
5187         (symnum, next_symbol_text_func, processing_gcc_compilation)
5188         (within_function, global_sym_chain, global_stabs)
5189         (previous_stab_code, this_object_header_files)
5190         (n_this_object_header_files)
5191         (n_allocated_this_object_header_files): Define.
5192         * stabsread.h (EXTERN): Never define.  Use "extern".
5193
5194 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5195
5196         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5197         history_value.
5198
5199 2019-01-21  Tom Tromey  <tom@tromey.com>
5200
5201         * ui-out.c: Fix includes.
5202         * tui/tui-source.c: Fix includes.
5203         * target.c: Fix includes.
5204         * remote.c: Fix includes.
5205         * regcache.c: Fix includes.
5206         * python/py-block.c: Fix includes.
5207         * printcmd.c: Fix includes.
5208         * or1k-tdep.c: Fix includes.
5209         * mi/mi-main.c: Fix includes.
5210         * m32r-tdep.c: Fix includes.
5211         * csky-tdep.c: Fix includes.
5212         * compile/compile-cplus-types.c: Fix includes.
5213         * cli/cli-interp.c: Fix includes.
5214
5215 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5216
5217         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5218         for padding.
5219
5220 2019-01-16  Tom Tromey  <tom@tromey.com>
5221
5222         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5223         earlier.
5224         (struct objfile) <msymbols_range>: Move from top level.
5225         <msymbols>: New method.
5226         (class objfile_msymbols): Remove.
5227         * symtab.c (default_collect_symbol_completion_matches_break_on):
5228         Update.
5229         * symmisc.c (dump_msymbols): Update.
5230         * stabsread.c (scan_file_globals): Update.
5231         * objc-lang.c (info_selectors_command, info_classes_command)
5232         (find_methods): Update.
5233         * minsyms.c (find_solib_trampoline_target): Update.
5234         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5235         * coffread.c (coff_symfile_read): Update.
5236         * ada-lang.c (ada_lookup_simple_minsym)
5237         (ada_collect_symbol_completion_matches): Update.
5238
5239 2019-01-16  Tom Tromey  <tom@tromey.com>
5240
5241         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5242         type.  Remove no-argument constructor.
5243         <iterator::operator++>: Simplify.
5244         <begin>: Update.
5245         <end>: Use minimal_symbol_count.
5246
5247 2019-01-16  Tom Tromey  <tom@tromey.com>
5248
5249         * objfiles.h (struct objfile) <psymtabs>: New method.
5250         (class objfile_psymtabs): Remove.
5251         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5252         typedef.
5253         <range>: New method.
5254         (require_partial_symbols): Change return type.
5255         * psymtab.c (require_partial_symbols)
5256         (psym_expand_symtabs_matching): Update.
5257         * mdebugread.c (parse_partial_symbols): Update.
5258         * dbxread.c (dbx_end_psymtab): Update.
5259
5260 2019-01-15  Tom Tromey  <tom@tromey.com>
5261
5262         * symtab.c (lookup_objfile_from_block)
5263         (lookup_symbol_in_objfile_symtabs)
5264         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5265         (find_line_symtab, info_sources_command)
5266         (default_collect_symbol_completion_matches_break_on)
5267         (make_source_files_completion_list): Update.
5268         * symmisc.c (print_objfile_statistics, dump_objfile)
5269         (maintenance_print_symbols, maintenance_info_symtabs)
5270         (maintenance_check_symtabs, maintenance_info_line_tables):
5271         Update.
5272         * source.c (select_source_symtab)
5273         (forget_cached_source_info_for_objfile): Update.
5274         * objfiles.h (class objfile_compunits): Remove.
5275         (struct objfile) <compunits_range>: New typedef.
5276         (compunits): New method.
5277         * objfiles.c (objfile_relocate1): Update.
5278         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5279         * maint.c (count_symtabs_and_blocks): Update.
5280         * linespec.c (iterate_over_all_matching_symtabs): Update.
5281         * cp-support.c (add_symbol_overload_list_qualified): Update.
5282         * coffread.c (coff_symtab_read): Update.
5283         * ada-lang.c (add_nonlocal_symbols)
5284         (ada_collect_symbol_completion_matches)
5285         (ada_add_global_exceptions): Update.
5286
5287 2019-01-15  Tom Tromey  <tom@tromey.com>
5288
5289         * progspace.h (program_space) <objfiles_safe_range>: New
5290         typedef.
5291         <objfiles_safe>: New method.
5292         * objfiles.h (class all_objfiles_safe): Remove.
5293         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5294         * jit.c (jit_inferior_exit_hook): Update.
5295
5296 2019-01-17  Tom Tromey  <tom@tromey.com>
5297
5298         * progspace.h (program_space) <objfiles_range>: New typedef.
5299         <objfiles>: New method.
5300         <objfiles_head>: Rename from objfiles.
5301         (object_files): Update.
5302         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5303         * guile/scm-pretty-print.c
5304         (ppscm_find_pretty_printer_from_objfiles): Update.
5305         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5306         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5307         Update.
5308         * python/py-progspace.c (pspy_get_objfiles): Update.
5309         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5310         Update.
5311         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5312         (objfpy_lookup_objfile_by_build_id): Update.
5313         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5314         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5315         Update.
5316         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5317         (expand_symtab_containing_pc, lookup_objfile_from_block)
5318         (lookup_static_symbol, basic_lookup_transparent_type)
5319         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5320         (find_line_symtab, info_sources_command)
5321         (default_collect_symbol_completion_matches_break_on)
5322         (make_source_files_completion_list, find_main_name): Update.
5323         * symmisc.c (print_symbol_bcache_statistics)
5324         (print_objfile_statistics, maintenance_print_symbols)
5325         (maintenance_print_msymbols, maintenance_print_objfiles)
5326         (maintenance_info_symtabs, maintenance_check_symtabs)
5327         (maintenance_expand_symtabs, maintenance_info_line_tables):
5328         Update.
5329         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5330         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5331         (map_overlay_command, unmap_overlay_command)
5332         (simple_overlay_update, expand_symtabs_matching)
5333         (map_symbol_filenames): Update.
5334         * symfile-debug.c (set_debug_symfile): Update.
5335         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5336         Update.
5337         * source.c (select_source_symtab, forget_cached_source_info):
5338         Update.
5339         * solib.c (solib_read_symbols): Update.
5340         * solib-spu.c (append_ocl_sos): Update.
5341         * psymtab.c (maintenance_print_psymbols)
5342         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5343         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5344         * printcmd.c (info_symbol_command): Update.
5345         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5346         Update.
5347         * objfiles.h (class all_objfiles): Remove.
5348         * objfiles.c (have_partial_symbols, have_full_symbols)
5349         (have_minimal_symbols, qsort_cmp, update_section_map)
5350         (shared_objfile_contains_address_p)
5351         (default_iterate_over_objfiles_in_search_order): Update.
5352         * objc-lang.c (info_selectors_command, info_classes_command)
5353         (find_methods): Update.
5354         * minsyms.c (find_solib_trampoline_target): Update.
5355         * maint.c (maintenance_info_sections)
5356         (maintenance_translate_address, count_symtabs_and_blocks):
5357         Update.
5358         * main.c (captured_main_1): Update.
5359         * linux-thread-db.c (try_thread_db_load_from_pdir)
5360         (has_libpthread): Update.
5361         * linespec.c (iterate_over_all_matching_symtabs)
5362         (search_minsyms_for_name): Update.
5363         * jit.c (jit_find_objf_with_entry_addr): Update.
5364         * hppa-tdep.c (find_unwind_entry)
5365         (hppa_lookup_stub_minimal_symbol): Update.
5366         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5367         Update.
5368         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5369         (elf_gnu_ifunc_resolve_by_got): Update.
5370         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5371         * dwarf-index-write.c (save_gdb_index_command): Update.
5372         * cp-support.c (add_symbol_overload_list_qualified): Update.
5373         * breakpoint.c (create_overlay_event_breakpoint)
5374         (create_longjmp_master_breakpoint)
5375         (create_std_terminate_master_breakpoint)
5376         (create_exception_master_breakpoint): Update.
5377         * blockframe.c (find_pc_partial_function): Update.
5378         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5379         (ada_collect_symbol_completion_matches)
5380         (ada_add_global_exceptions): Update.
5381
5382 2019-01-17  Tom Tromey  <tom@tromey.com>
5383
5384         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5385         declare VEC.
5386         (solib_target_parse_libraries): Change return type.
5387         (library_list_start_segment, library_list_start_section)
5388         (library_list_end_library, library_list_start_library); Update.
5389         (solib_target_free_library_list): Remove.
5390         (solib_target_parse_libraries): Remove cleanup.  Change return
5391         type.
5392         (solib_target_current_sos): Update.
5393
5394 2019-01-17  Tom Tromey  <tromey@bapiya>
5395
5396         * valprint.c: Replace "the the" with "the".
5397         * symtab.c: Replace "the the" with "the".
5398         * solib.c: Replace "the the" with "the".
5399         * solib-dsbt.c: Replace "the the" with "the".
5400         * linespec.c: Replace "the the" with "the".
5401         * dwarf2loc.h: Replace "the the" with "the".
5402         * amd64-windows-tdep.c: Replace "the the" with "the".
5403         * aarch64-tdep.c: Replace "the the" with "the".
5404
5405 2019-01-16  Keith Seitz  <keiths@redhat.com>
5406
5407         PR gdb/23773
5408         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5409         <builder>: Rename to ..
5410         <m_builder>: ... this and make private.
5411         (dwarf2_cu::get_builder): New method.  Change all users of
5412         `builder' to use this method.
5413         (dwarf2_start_symtab): Move to ...
5414         (dwarf2_cu::start_symtab): ... here.  Update all callers
5415         (setup_type_unit_groups): Move to ...
5416         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5417         callers.
5418         (dwarf2_cu::reset_builder): New method.
5419         (process_full_compunit, process_full_type_unit): Use
5420         dwarf2_cu::reset_builder.
5421         (follow_die_offset): Record the ancestor CU if it is different
5422         from the followed DIE's CU.
5423         (follow_die_sig_1): Likewise.
5424
5425 2019-01-15  Tom Tromey  <tom@tromey.com>
5426
5427         * remote.c (class remote_state) <buf>: Now a char_vector.
5428         <buf_size>: Remove.
5429         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5430         parameter.
5431         (remote_target::getpkt_or_notif_sane_1)
5432         (remote_target::getpkt_sane)
5433         (remote_target::getpkt_or_notif_sane): Likewise.
5434         (class remote_target) <putpkt>: New overload.
5435         (remote_target::read_frame): Change type of "buf_p".  Remove
5436         sizeof_p parameter.
5437         (packet_ok): New overload.
5438         (packet_check_result): New overload.
5439         Update all uses.
5440
5441 2019-01-14  Tom Tromey  <tom@tromey.com>
5442
5443         * remote-notif.c (handle_notification, remote_notif_ack)
5444         (remote_notif_parse): Make "buf" const.
5445         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5446         const.
5447         (remote_notif_parse, remote_notif_ack, handle_notification):
5448         Likewise.
5449         * remote.c (remote_notif_stop_parse): Make "buf" const.
5450         (remote_target::remote_parse_stop_reply): Make "buf" const.
5451         (remote_notif_stop_ack): Make "buf" const.
5452
5453 2019-01-14  Tom Tromey  <tom@tromey.com>
5454
5455         * remote.c (remote_console_output): Make parameter const.
5456
5457 2019-01-14  Tom Tromey  <tom@tromey.com>
5458
5459         * target-debug.h (target_debug_print_signals): Constify.
5460         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5461         * procfs.c (procfs_target::pass_signals): Update.
5462         * linux-nat.c (linux_nat_target::pass_signals): Update.
5463         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5464         * target-delegates.c: Rebuild.
5465         * remote.c (remote_target::program_signals): Update.
5466         (remote_target::pass_signals): Update.
5467         * target.c (target_pass_signals): Constify argument.
5468         (target_program_signals): Likewise.
5469         * target.h (struct target_ops) <pass_signals, program_signals>:
5470         Constify argument.
5471         (target_pass_signals, target_program_signals): Constify argument.
5472
5473 2019-01-14  Tom Tromey  <tom@tromey.com>
5474
5475         PR tui/28819:
5476         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5477
5478 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5479
5480         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5481         field.
5482         * rs6000-tdep.c: Include reggroups.h.
5483         (IS_V_ALIAS_PSEUDOREG): Define.
5484         (rs6000_register_name): Return names for the "vX" aliases.
5485         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5486         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5487         aliases.  Call default_register_reggroup_p for all other
5488         pseudo-registers.
5489         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5490         New functions.
5491         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5492         Handle "vX" aliases.
5493         (v_alias_pseudo_register_collect): New function.
5494         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5495         (rs6000_gdbarch_init): Initialize "vX" aliases as
5496         pseudo-registers.  Restore registration of
5497         rs6000_pseudo_register_reggroup_p with
5498         set_tdesc_pseudo_register_reggroup_p.
5499
5500 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5501
5502         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5503         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5504         set_gdbarch_num_pseudo_regs.
5505
5506 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5507
5508         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5509         Remove arg prefixname, add do_set and do_show.
5510         Add member functions set_list and show_list.
5511         * cli/cli-style.c (class cli_style_option): Update accordingly.
5512         (style_set_list): Move to file scope.
5513         (style_show_list): Likewise.
5514         (set_style): Call help_list.
5515         (show_style): Call cmd_show_list.
5516         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5517         Update to use the new macro.
5518
5519 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5520
5521         * ada-lang.c (_initialize_ada_language): Expand the help text
5522         for the "catch exception" command.
5523
5524 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5525
5526         * symtab.c (matching_obj_sections): Initialize obj,
5527         declare it closer to its usage.
5528
5529 2019-01-10  Tom Tromey  <tom@tromey.com>
5530
5531         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5532         (basic_inf_threads_range): Remove.
5533         (inf_threads_range, inf_non_exited_threads_range)
5534         (safe_inf_threads_range): Use next_adapter.
5535
5536 2019-01-10  Keith Seitz  <keiths@redhat.com>
5537
5538         PR gdb/23712
5539         PR symtab/23010
5540         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5541         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5542
5543 2019-01-10  Keith Seitz  <keiths@redhat.com>
5544
5545         PR gdb/23712
5546         PR symtab/23010
5547         * dictionary.c (pending_to_vector): Remove.
5548         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5549         Remove _1 suffix, replacing functions of the same name.  Update
5550         all callers.
5551         (dict_create_hashed, dict_create_hashed_expandable)
5552         (dict_create_linear, dict_create_linear_expandable, dict_free)
5553         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5554         Make functions static.
5555
5556 2019-01-10  Keith Seitz  <keiths@redhat.com>
5557
5558         PR gdb/23712
5559         PR symtab/23010
5560         * dictionary.h (struct dictionary): Replace declaration with
5561         multidictionary.
5562         (dict_create_hashed, dict_create_hashed_expandable)
5563         (dict_create_linear, dict_create_linear_expandable)
5564         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5565         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5566         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5567         taking multidictionary argument.
5568         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5569         * block.h (struct block) <dict>: Change to multidictionary
5570         and rename `multidict'.
5571         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5572         symmisc.c: Update all dictionary references to multidictionary.
5573
5574 2019-01-10  Keith Seitz  <keiths@redhat.com>
5575
5576         PR gdb/23712
5577         PR symtab/23010
5578         * dictionary.c: Include unordered_map.
5579         (pending_to_vector): New function.
5580         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5581         Rewrite the non-"_1" functions to take vector instead
5582         of linked list.
5583         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5584         "new" _1 versions of the same name.
5585         (multidictionary): Define.
5586         (std::hash<enum language): New definition.
5587         (collate_pending_symbols_by_language, mdict_create_hashed)
5588         (mdict_create_hashed_expandable, mdict_create_linear)
5589         (mdict_create_linear_expandable, mdict_free)
5590         (find_language_dictionary, create_new_language_dictionary)
5591         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5592         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5593         (mdict_size, mdict_empty): New functions.
5594         * dictionary.h (mdict_iterator): Define.
5595
5596 2019-01-10  Pedro Alves  <palves@redhat.com>
5597
5598         * breakpoint.c (read_uploaded_action)
5599         (create_tracepoint_from_upload): Adjust to use
5600         gdb::unique_xmalloc_ptr.
5601         * ctf.c (ctf_write_uploaded_tp):
5602         (SET_ARRAY_FIELD): Use emplace_back.
5603         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5604         * tracefile-tfile.c (tfile_write_uploaded_tp):
5605         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5606         gdb::unique_xmalloc_ptr.
5607         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5608         at_string, cond_string, cmd_strings>: Replace char pointers
5609         with gdb::unique_xmalloc_ptr.
5610
5611 2019-01-10  Pedro Alves  <palves@redhat.com>
5612
5613         * solib-target.c (library_list_start_library): Don't xstrdup name.
5614
5615 2019-01-10  Pedro Alves  <palves@redhat.com>
5616
5617         * mdebugread.c (parse_partial_symbols): Use
5618         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5619
5620 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5621
5622         * linux-fork.c (scoped_switch_fork_info)
5623         <~scoped_switch_fork_info>: Fix incorrect variable name.
5624
5625 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5626
5627         * linux-fork.c (scoped_switch_fork_info)
5628         <scoped_switch_fork_info>: Make explicit.
5629         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5630
5631 2019-01-10  Tom Tromey  <tom@tromey.com>
5632
5633         * objfiles.h (objfile::reset_psymtabs): Update.
5634         * objfiles.c (objfile::objfile): Update.
5635         * psymtab.h (psymtab_storage::obstack): Update.
5636         (psymtab_storage::m_obstack): Use gdb::optional.
5637         (class psymtab_storage): Update comment.  Remove objfile
5638         parameter.
5639         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5640
5641 2019-01-10  Tom Tromey  <tom@tromey.com>
5642
5643         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5644         <free_psymtabs>: Now private.
5645         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5646         (allocate_psymtab): Use new method.
5647
5648 2019-01-10  Tom Tromey  <tom@tromey.com>
5649
5650         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5651         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5652         * mdebugread.c (parse_partial_symbols): Use
5653         allocate_dependencies.
5654         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5655         allocate_dependencies.
5656         (process_psymtab_comp_unit_reader)
5657         (build_type_psymtab_dependencies): Likewise.
5658         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5659
5660 2019-01-10  Tom Tromey  <tom@tromey.com>
5661
5662         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5663         PSYMBOL_SET_LANGUAGE.
5664         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5665
5666 2019-01-10  Tom Tromey  <tom@tromey.com>
5667
5668         * psymtab.h (psymtab_storage::obstack): New method.
5669         <m_obstack>: Rename from obstack; now private.
5670         * psymtab.c (psymtab_storage): Update.
5671         * dwarf2read.c (create_addrmap_from_index)
5672         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5673         Update.
5674
5675 2019-01-10  Tom Tromey  <tom@tromey.com>
5676
5677         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5678         * objfiles.h (objfile::reset_psymtabs): New method.
5679
5680 2019-01-10  Tom Tromey  <tom@tromey.com>
5681
5682         * symmisc.c (print_symbol_bcache_statistics): Update.
5683         (print_objfile_statistics): Update.
5684         * symfile.c (reread_symbols): Update.
5685         * psymtab.h (class psymtab_storage): New.
5686         * psymtab.c (psymtab_storage): New constructor.
5687         (~psymtab_storage): New destructor.
5688         (require_partial_symbols): Update.
5689         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5690         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5691         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5692         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5693         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5694         (start_psymtab_common, end_psymtab_common)
5695         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5696         (allocate_psymtab): Update.
5697         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5698         Update.
5699         (dump_psymtab_addrmap, maintenance_print_psymbols)
5700         (maintenance_check_psymtabs): Update.
5701         (class objfile_psymtabs): Move to objfiles.h.
5702         * psympriv.h (discard_psymtab): Now inline.
5703         (psymtab_discarder::psymtab_discarder): Update.
5704         (psymtab_discarder::~psymtab_discarder): Update.
5705         (ALL_OBJFILE_PSYMTABS): Rewrite.
5706         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5707         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5708         Remove fields.
5709         <partial_symtabs>: New field.
5710         (class objfile_psymtabs): Move from psymtab.h.  Update.
5711         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5712         psymbol_cache.
5713         (objfile::~objfile): Don't destroy psymbol_cache.
5714         * mdebugread.c (parse_partial_symbols): Update.
5715         * dwarf2read.c (create_addrmap_from_index)
5716         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5717         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5718         (add_partial_subprogram, dwarf2_ranges_read): Update.
5719         * dwarf-index-write.c (write_address_map)
5720         (write_one_signatured_type, recursively_write_psymbols)
5721         (class debug_names, class debug_names, write_psymtabs_to_index):
5722         Update.
5723
5724 2019-01-10  Tom Tromey  <tom@tromey.com>
5725
5726         * symtab.h (SYMBOL_SET_NAMES): Update.
5727         (symbol_set_names): Update.
5728         (MSYMBOL_SET_NAMES): Update.
5729         * symtab.c (symbol_set_names): Change argument to be an
5730         objfile_per_bfd_storage.
5731         * psymtab.c (add_psymbol_to_bcache): Update.
5732         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5733
5734 2019-01-10  Tom Tromey  <tom@tromey.com>
5735
5736         * symtab.c (create_demangled_names_hash): Change argument to be an
5737         objfile_per_bfd_storage.
5738         (symbol_set_names): Update.
5739
5740 2019-01-10  Tom Tromey  <tom@tromey.com>
5741
5742         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5743         init_psymbol_list.
5744         * psymtab.c (init_psymbol_list): Do nothing if already called.
5745         * psympriv.h (init_psymbol_list): Add comment.
5746         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5747         init_psymbol_list.
5748         * dbxread.c (dbx_symfile_read): Unconditionally call
5749         init_psymbol_list.
5750
5751 2019-01-10  Tom Tromey  <tom@tromey.com>
5752
5753         * xcoffread.c (scan_xcoff_symtab): Update.
5754         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5755         "where".
5756         * mdebugread.c (parse_partial_symbols)
5757         (handle_psymbol_enumerators): Update.
5758         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5759         * dbxread.c (read_dbx_symtab): Update.
5760         * psympriv.h (psymbol_placement): New enum.
5761         (add_psymbol_to_list): Update.
5762
5763 2019-01-10  Tom Tromey  <tom@tromey.com>
5764
5765         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5766         static_psymbols parameters.
5767         (scan_xcoff_symtab): Update.
5768         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5769         static_psymbols parameters.
5770         * psympriv.h (start_psymtab_common): Update.
5771         * mdebugread.c (parse_partial_symbols): Update.
5772         * dwarf2read.c (create_partial_symtab): Update.
5773         * dbxread.c (read_dbx_symtab): Update.
5774         (start_psymtab): Remove global_psymbols and static_psymbols
5775         parameters.
5776
5777 2019-01-10  Tom Tromey  <tom@tromey.com>
5778
5779         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5780         * psymtab.c (allocate_psymtab): Add comment.
5781         * psympriv.h (allocate_psymtab): Add comment.
5782         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5783         initializations.
5784         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5785
5786 2019-01-10  Tom Tromey  <tom@tromey.com>
5787
5788         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5789         Don't declare.
5790         * mipsread.c: Include mdebugread.h.
5791         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5792         Declare.
5793         * elfread.c: Include mdebugread.h.
5794
5795 2019-01-09  Tom Tromey  <tom@tromey.com>
5796
5797         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5798         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5799         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5800         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5801         (psym_lookup_symbol, psym_find_last_source_symtab)
5802         (psym_forget_cached_source_info, psym_print_stats)
5803         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5804         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5805         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5806         (psym_find_compunit_symtab_by_address)
5807         (maintenance_print_psymbols, maintenance_info_psymtabs)
5808         (maintenance_check_psymtabs): Use ranged for.
5809         * psymtab.h (class objfile_psymtabs): New.
5810         (require_partial_symbols): Return objfile_psymtabs.
5811         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5812
5813 2019-01-09  Tom Tromey  <tom@tromey.com>
5814
5815         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5816         (find_pc_mapped_section, list_overlays_command)
5817         (map_overlay_command, unmap_overlay_command)
5818         (simple_overlay_update): Use all_objfiles.
5819         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5820         * printcmd.c (info_symbol_command): Use all_objfiles.
5821         * objfiles.h (ALL_OBJSECTIONS): Remove.
5822         * maint.c (maintenance_translate_address): Use all_objfiles.
5823         * gcore.c (gcore_create_callback): Use all_objfiles.
5824         (objfile_find_memory_regions): Likewise.
5825
5826 2019-01-09  Tom Tromey  <tom@tromey.com>
5827
5828         * symtab.c (find_line_symtab, info_sources_command)
5829         (make_source_files_completion_list): Use objfile_compunits.
5830         * source.c (select_source_symtab): Use objfile_compunits.
5831         * objfiles.h (struct objfile): Update comment.
5832         (ALL_OBJFILES): Remove.
5833         (ALL_FILETABS): Remove.
5834         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5835         objfile_compunits.
5836
5837 2019-01-09  Tom Tromey  <tom@tromey.com>
5838
5839         * symmisc.c (print_objfile_statistics, dump_objfile)
5840         (maintenance_print_symbols): Use compunit_filetabs.
5841         * source.c (forget_cached_source_info_for_objfile): Use
5842         compunit_filetabs.
5843         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5844         (ALL_FILETABS): Use compunit_filetabs.
5845         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5846         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5847
5848 2019-01-09  Tom Tromey  <tom@tromey.com>
5849
5850         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5851         (compunit_filetabs): New.
5852         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5853         compunit_filetabs.
5854         (info_sources_command, make_source_files_completion_list): Remove
5855         declaration.
5856         * symmisc.c (print_objfile_statistics, dump_objfile)
5857         (maintenance_print_symbols): Remove declaration.
5858         (maintenance_info_symtabs): Use compunit_filetabs.
5859         (maintenance_info_line_tables): Likewise.
5860         * source.c (select_source_symtab): Change local variable name.
5861         (forget_cached_source_info_for_objfile): Remove declaration.
5862         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5863         * objfiles.c (objfile_relocate1): Remove declaration.
5864         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5865         declaration.
5866         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5867         * coffread.c (coff_symtab_read): Remove declaration.
5868         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5869         compunit_filetabs.
5870
5871 2019-01-09  Tom Tromey  <tom@tromey.com>
5872
5873         * symtab.c (lookup_objfile_from_block)
5874         (find_pc_sect_compunit_symtab, search_symbols)
5875         (default_collect_symbol_completion_matches_break_on): Use
5876         objfile_compunits.
5877         * objfiles.h (ALL_COMPUNITS): Remove.
5878         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5879         * cp-support.c (add_symbol_overload_list_qualified): Use
5880         objfile_compunits.
5881         * ada-lang.c (ada_collect_symbol_completion_matches)
5882         (ada_add_global_exceptions): Use objfile_compunits.
5883
5884 2019-01-09  Tom Tromey  <tom@tromey.com>
5885
5886         * source.c (select_source_symtab)
5887         (forget_cached_source_info_for_objfile): Remove declaration.
5888         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5889         declaration.
5890         * maint.c (count_symtabs_and_blocks): Remove declaration.
5891         * cp-support.c (add_symbol_overload_list_qualified): Remove
5892         declaration.
5893         * coffread.c (coff_symtab_read): Remove declaration.
5894         * symtab.c (lookup_symbol_in_objfile_symtabs)
5895         (basic_lookup_transparent_type_1): Use objfile_compunits.
5896         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5897         (info_sources_command, search_symbols)
5898         (default_collect_symbol_completion_matches_break_on)
5899         (make_source_files_completion_list): Remove declaration.
5900         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5901         (ada_collect_symbol_completion_matches)
5902         (ada_add_global_exceptions): Remove declaration.
5903         * linespec.c (iterate_over_all_matching_symtabs): Use
5904         objfile_compunits.
5905         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5906         (class objfile_compunits): New.
5907         (ALL_COMPUNITS): Use objfile_compunits.
5908         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5909         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5910         objfile_compunits.
5911         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5912
5913 2019-01-09  Tom Tromey  <tom@tromey.com>
5914
5915         * symtab.c (search_symbols)
5916         (default_collect_symbol_completion_matches_break_on): Use
5917         objfile_msymbols.
5918         * ada-lang.c (ada_lookup_simple_minsym)
5919         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5920         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5921         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5922         objfile_msymbols.
5923         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5924         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5925         * objc-lang.c (find_methods): Use objfile_msymbols.
5926         (info_selectors_command, info_classes_command): Likewise.
5927         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5928         * objfiles.h (class objfile_msymbols): New.
5929         (ALL_OBJFILE_MSYMBOLS): Remove.
5930         (ALL_MSYMBOLS): Remove.
5931
5932 2019-01-09  Tom Tromey  <tom@tromey.com>
5933
5934         * common/next-iterator.h (next_adapter): Add Iterator template
5935         parameter.
5936         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5937         (class all_objfiles_safe): New.
5938         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5939         * objfiles.c (put_objfile_before): Update comment.
5940         (add_separate_debug_objfile): Likewise.
5941         (free_all_objfiles): Use all_objfiles_safe.
5942         (objfile_purge_solibs): Likewise.
5943
5944 2019-01-09  Tom Tromey  <tom@tromey.com>
5945
5946         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5947         (expand_symtab_containing_pc, lookup_static_symbol)
5948         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5949         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5950         all_objfiles.
5951         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5952         * breakpoint.c (create_overlay_event_breakpoint)
5953         (create_longjmp_master_breakpoint)
5954         (create_std_terminate_master_breakpoint)
5955         (create_exception_master_breakpoint): Use all_objfiles.
5956         * linux-thread-db.c (try_thread_db_load_from_pdir)
5957         (has_libpthread): Use all_objfiles.
5958         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5959         * linespec.c (iterate_over_all_matching_symtabs)
5960         (search_minsyms_for_name): Use all_objfiles.
5961         * maint.c (maintenance_info_sections): Use all_objfiles.
5962         * main.c (captured_main_1): Use all_objfiles.
5963         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5964         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5965         * guile/scm-pretty-print.c
5966         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5967         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5968         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5969         (maintenance_print_msymbols): Use all_objfiles.
5970         * source.c (select_source_symtab): Use all_objfiles.
5971         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5972         * symfile.c (remove_symbol_file_command)
5973         (expand_symtabs_matching, map_symbol_filenames): Use
5974         all_objfiles.
5975         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5976         all_objfiles.
5977         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5978         * objc-lang.c (find_methods): Use all_objfiles.
5979         * objfiles.c (have_partial_symbols, have_full_symbols)
5980         (have_minimal_symbols, qsort_cmp)
5981         (default_iterate_over_objfiles_in_search_order): Use
5982         all_objfiles.
5983         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5984         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5985         (maintenance_check_psymtabs): Use all_objfiles.
5986         (ALL_PSYMTABS): Remove.
5987         * compile/compile-object-run.c (do_module_cleanup): Use
5988         all_objfiles.
5989         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5990         * cp-support.c (add_symbol_overload_list_qualified): Use
5991         all_objfiles.
5992         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5993         Use all_objfiles.
5994         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5995         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5996         all_objfiles.
5997         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5998         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5999         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6000         Uses all_objfiles.
6001         * solib.c (solib_read_symbols): Use all_objfiles
6002
6003 2019-01-09  Tom Tromey  <tom@tromey.com>
6004
6005         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6006         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6007         all_objfiles.
6008         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6009         * symmisc.c (print_symbol_bcache_statistics)
6010         (print_objfile_statistics, maintenance_print_objfiles)
6011         (maintenance_info_symtabs, maintenance_check_symtabs)
6012         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6013         all_objfiles.
6014         * source.c (forget_cached_source_info): Use all_objfiles.
6015         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6016         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6017         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6018         * objfiles.c (update_section_map): Use all_objfiles.
6019         (shared_objfile_contains_address_p): Likewise.
6020         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6021         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6022
6023 2019-01-09  Tom Tromey  <tom@tromey.com>
6024
6025         * common/next-iterator.h: New file.
6026         * objfiles.h (class all_objfiles): New.
6027         (struct objfile_iterator): New.
6028
6029 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6030
6031         * NEWS: Move the description of the changed "frame", "select-frame",
6032          and "info frame" commands to the Changed commands section.
6033
6034 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6035
6036         * gdbtypes.c (check_stub_method_group): Remove handling of old
6037         mangling schemes.
6038         * linespec.c (find_methods): Likewise.
6039         * stabsread.c (read_member_functions): Likewise.
6040         * valops.c (search_struct_method): Likewise.
6041         (value_struct_elt_for_reference): Likewise.
6042         * NEWS: Mention this change.
6043
6044 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6045
6046         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6047         print_source_lines.
6048         * source.c (print_source_lines_base): Update line number check.
6049         (print_source_lines): New function.
6050         (source_lines_range::source_lines_range): New function.
6051         * source.h (class source_lines_range): New class.
6052         (print_source_lines): New declaration.
6053
6054 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6055
6056         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6057
6058 2019-01-08  Tom Tromey  <tom@tromey.com>
6059             Simon Marchi  <simon.marchi@ericsson.com>
6060
6061         PR gdb/24060
6062         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6063         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6064         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6065         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6066         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6067         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6068
6069 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6070
6071         * source.c (select_source_symtab): Move header comment to
6072         declaration in source.h.
6073         (forget_cached_source_info_for_objfile): Likewise.
6074         (forget_cached_source_info): Likewise.
6075         (identify_source_line): Likewise.
6076         * source.h (identify_source_line): Move declaration from symtab.h
6077         and add comment from source.c
6078         (print_source_lines): Likewise.
6079         (forget_cached_source_info_for_objfile): Likewise.
6080         (forget_cached_source_info): Likewise.
6081         (select_source_symtab): Likewise.
6082         (enum print_source_lines_flag): Move definition from symtab.h.
6083         * symtab.h (identify_source_line): Move declaration to source.h.
6084         (print_source_lines): Likewise.
6085         (forget_cached_source_info_for_objfile): Likewise.
6086         (forget_cached_source_info): Likewise.
6087         (select_source_symtab): Likewise.
6088         (enum print_source_lines_flag): Move definition to source.h.
6089         * tui/tui-hooks.c: Add 'source.h' include.
6090
6091 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6092
6093         * source.c (print_source_lines_base): Handle requests to print
6094         reverse line number sequences, and guard against empty lines
6095         string.
6096
6097 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6098
6099         * source.c (print_source_lines_base): Fix skip of '\r' if next
6100         character is '\n'.
6101
6102 2019-01-06  Tom Tromey  <tom@tromey.com>
6103
6104         * c-exp.y (struct c_parse_state) <macro_original_text,
6105         expansion_obstack>: New member.
6106         (macro_original_text, expansion_obstack): Remove globals.
6107         (scan_macro_expansion, scanning_macro_expansion)
6108         (finished_macro_expansion): Update.
6109         (scan_macro_cleanup): Remove.
6110         (yylex, c_parse): Update.
6111
6112 2019-01-06  Tom Tromey  <tom@tromey.com>
6113
6114         * c-exp.y (struct c_parse_state) <strings>: New member.
6115         (operator_stoken): Update.
6116
6117 2019-01-06  Tom Tromey  <tom@tromey.com>
6118
6119         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6120         (union type_stack_elt) <typelist_val>: Now a pointer to
6121         std::vector.
6122         (type_stack_cleanup): Don't declare.
6123         (push_typelist): Update.
6124         * parse.c (pop_typelist): Return a std::vector.
6125         (push_typelist): Take a std::vector.
6126         (follow_types): Update.  Do not free args.
6127         (type_stack_cleanup): Remove.
6128         * c-exp.y (struct c_parse_state): New.
6129         (cpstate): New global.
6130         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6131         (nonempty_typelist): Update.
6132         (func_mod): Create a new vector.
6133         (c_parse): Create a c_parse_state.
6134         (check_parameter_typelist): Do not delete params.
6135         (function_method): Update.  Do not delete type_list.
6136
6137 2019-01-06  Tom Tromey  <tom@tromey.com>
6138
6139         PR gdb/28155:
6140         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6141         check_typedef.
6142         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6143         (print_return_value): Likewise.
6144
6145 2019-01-05  Tom Tromey  <tom@tromey.com>
6146
6147         * contrib/cleanup_check.py: Remove.
6148         * contrib/gcc-with-excheck: Remove.
6149         * contrib/exsummary.py: Remove.
6150         * contrib/excheck.py: Remove.
6151
6152 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6153
6154         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6155         NULL. Initialize tpprev to NULL instead of assigning it
6156         to NULL on the next statement.
6157         * windows-nat.c (windows_delete_thread): Remove check for
6158         main_thread_id before printing thread exit notifications.
6159         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6160         Remove thread ID check against main_thread_id.
6161         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6162         windows_delete_thread.
6163         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6164
6165 2019-01-04  Tom Tromey  <tom@tromey.com>
6166
6167         * compile/compile.c (_initialize_compile): Use upper case for
6168         metasyntactic variables.
6169         * symmisc.c (_initialize_symmisc): Use upper case for
6170         metasyntactic variables.
6171         * psymtab.c (_initialize_psymtab): Use upper case for
6172         metasyntactic variables.
6173         * demangle.c (demangle_command): Use upper case for metasyntactic
6174         variables.
6175         (_initialize_demangler): Likewise.
6176         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6177         variables.
6178
6179 2019-01-03  Tom Tromey  <tom@tromey.com>
6180
6181         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6182
6183 2019-01-03  Tom Tromey  <tom@tromey.com>
6184
6185         * python/py-symtab.c (salpy_str): Update.
6186         (struct salpy_sal_object) <symtab>: Now a PyObject.
6187         (salpy_dealloc): Update.
6188         (del_objfile_sal): Use gdbpy_ref.
6189
6190 2019-01-03  Tom Tromey  <tom@tromey.com>
6191
6192         * python/py-type.c (convert_field): Use new_reference.  Return
6193         gdbpy_ref.
6194         (make_fielditem): Return gdbpy_ref.
6195         (typy_fields): Update.
6196         (typy_getitem): Update.
6197         (field_name): Return gdbpy_ref.  Use new_reference.
6198         (typy_iterator_iternext): Update.
6199
6200 2019-01-03  Tom Tromey  <tom@tromey.com>
6201
6202         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6203
6204 2019-01-03  Tom Tromey  <tom@tromey.com>
6205
6206         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6207         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6208         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6209         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6210         (pspy_set_type_printers): Likewise.
6211         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6212         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6213         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6214         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6215         (objfpy_set_type_printers): Likewise.
6216
6217 2019-01-03  Tom Tromey  <tom@tromey.com>
6218
6219         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6220         (gdbpy_print_stack): Use gdbpy_err_fetch.
6221         * python/python-internal.h (class gdbpy_err_fetch): New class.
6222         (class gdbpy_enter) <m_error_type, m_error_value,
6223         m_error_traceback>: Remove.
6224         <m_error>: New member.
6225         (gdbpy_exception_to_string): Don't declare.
6226         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6227         * python/py-value.c (convert_value_from_python): Use
6228         gdbpy_err_fetch.
6229         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6230         gdbpy_exception_to_string.
6231         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6232         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6233         gdbpy_err_fetch.
6234
6235 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6236
6237         * linux-nat.c (delete_lwp_cleanup): Delete.
6238         (struct lwp_deleter): New struct.
6239         (lwp_info_up): New typedef.
6240         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6241         lwp_info_up.
6242
6243 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6244
6245         * linux-fork.c (class scoped_switch_fork_info): New class.
6246         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6247
6248 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6249
6250         * valops.c (find_overload_match): Remove use of null_cleanup, and
6251         calls to do_cleanups.
6252
6253 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6254
6255         * compile/compile-cplus-types.c
6256         (compile_cplus_instance::decl_name): Handle changes to
6257         cp_func_name.
6258         * cp-support.c (cp_func_name): Update header comment, update
6259         return type.
6260         * cp-support.h (cp_func_name): Update return type in declaration.
6261         * valops.c (find_overload_match): Move temp_func local to top
6262         level of function and change its type.  Use temp_func to hold and
6263         delete temporary string obtained from cp_func_name.
6264
6265 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6266
6267         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6268         gdb::char_vector, remove cleanup, and update uses of `msg`.
6269
6270 2019-01-03  Jim Wilson  <jimw@sifive.com>
6271
6272         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6273
6274 2019-01-02  Tom Tromey  <tom@tromey.com>
6275
6276         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6277         (tdesc_parse_xml): Remove cleanups.
6278         * target-descriptions.h (make_cleanup_free_target_description):
6279         Don't declare.
6280         (target_desc_deleter): New struct.
6281         (target_desc_up): New typedef.
6282         * target-descriptions.c (target_desc_deleter::operator()): Rename
6283         from free_target_description.
6284         (make_cleanup_free_target_description): Remove.
6285
6286 2019-01-02  Tom Tromey  <tom@tromey.com>
6287
6288         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6289         constructor, destructor.
6290         (linespec_parser): Remove typedef.
6291         (~linespec_parser): Rename from linespec_parser_delete.
6292         (linespec_lex_to_end, linespec_complete_label)
6293         (linespec_complete): Update.
6294         (decode_line_full): Remove cleanups.
6295         (decode_line_1): Update.
6296
6297 2019-01-02  Tom Tromey  <tom@tromey.com>
6298
6299         * python/python-internal.h (inferior_to_inferior_object): Change
6300         return type.
6301         * python/py-exitedevent.c (create_exited_event_object): Update.
6302         * python/py-inferior.c (inferior_to_inferior_object): Return
6303         gdbpy_ref.
6304         (python_new_inferior, python_inferior_deleted)
6305         (thread_to_thread_object, delete_thread_object)
6306         (build_inferior_list, gdbpy_selected_inferior): Update.
6307         * python/py-infthread.c (create_thread_object): Update.  Also fail
6308         if inferior_to_inferior_object fails.
6309
6310 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6311
6312         * inferior.h (class inferior) <displaced_step_state>: New field.
6313         * infrun.h (struct displaced_step_state): Move here from
6314         infrun.c.  Initialize fields, add constructor.
6315         <inf>: Remove field.
6316         <reset>: New method.
6317         * infrun.c (struct displaced_step_inferior_state): Move to
6318         infrun.h.
6319         (displaced_step_inferior_states): Remove.
6320         (get_displaced_stepping_state): Adust.
6321         (displaced_step_in_progress_any_inferior): Adjust.
6322         (displaced_step_in_progress_thread): Adjust.
6323         (displaced_step_in_progress): Adjust.
6324         (add_displaced_stepping_state): Remove.
6325         (get_displaced_step_closure_by_addr): Adjust.
6326         (remove_displaced_stepping_state): Remove.
6327         (infrun_inferior_exit): Call displaced_step_state.reset.
6328         (use_displaced_stepping): Don't check for NULL.
6329         (displaced_step_prepare_throw): Call
6330         get_displaced_stepping_state.
6331         (displaced_step_fixup): Don't check for NULL.
6332         (prepare_for_detach): Don't check for NULL.
6333
6334 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6335
6336         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6337          in case of call that did not complete.
6338
6339 2019-01-02  Andrey Utkin  <autkin@undo.io>
6340
6341         * symfile.c (find_separate_debug_file): Fix search of debug files for
6342         remote debuggee.
6343
6344 2019-01-02  Tom Tromey  <tom@tromey.com>
6345
6346         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6347         indentation.
6348         * python/py-frame.c (frapy_older): Remove cast.
6349         (frapy_newer): Likewise.
6350         * python/py-breakpoint.c (local_setattro): Remove cast.
6351         * python/py-arch.c (archpy_name): Remove local variable.
6352         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6353
6354 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6355
6356         * unittests/basic_string_view/element_access/char/empty.cc:
6357         Fix year range in copyright header.
6358
6359 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6360
6361         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6362         Delete.
6363         <operator==>: Update with for removed field.
6364         <hash>: Likewise.
6365         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6366         <isa_features>: ...this.
6367         <abi_features>: New field.
6368         (riscv_isa_flen): Update comment.
6369         (riscv_abi_xlen): New declaration.
6370         (riscv_abi_flen): New declaration.
6371         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6372         isa_features.
6373         (riscv_abi_xlen): New function.
6374         (riscv_isa_flen): Update to get answer from isa_features.
6375         (riscv_abi_flen): New function.
6376         (riscv_has_fp_abi): Update to get answer from abi_features.
6377         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6378         xlen and flen.
6379         (riscv_call_info) <xlen, flen>: Update comment.
6380         (riscv_call_arg_struct): Remove invalid assertions
6381         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6382         is removed.
6383         (riscv_gdbarch_init): Gather isa features and abi features
6384         separately, ensure both match on the gdbarch when reusing an old
6385         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6386         a target with 64-bit float hardware.
6387
6388 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6389
6390         * source.c (search_command_helper): Stop reverse search
6391         when line 1 has been searched.
6392
6393 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6394
6395         * record-full.c (record_full_base_target::close): Rewrite
6396         record_full_core_buf_list free logic.
6397
6398 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6399
6400         * break-catch-syscall.c (print_one_catch_syscall): xfree
6401         the last text.
6402
6403 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6404
6405         * top.c (print_gdb_version): Update Copyright year in version
6406         message.
6407
6408 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6409
6410         Update copyright year range in all GDB files.
6411
6412 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6413
6414         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6415
6416 For older changes see ChangeLog-2018.
6417 \f
6418 Local Variables:
6419 mode: change-log
6420 left-margin: 8
6421 fill-column: 74
6422 version-control: never
6423 coding: utf-8
6424 End:
6425