gdb/ChangeLog

   1 2019-12-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-stack.c (tui_show_frame_info): Don't call
   4         update_exec_info.
   5
   6 2019-12-20  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui.c (tui_enable): Call tui_display_main.
   9
  10 2019-12-20  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui-disasm.c (tui_get_begin_asm_address): Use
  13         get_current_source_symtab_and_line, and main_name.
  14
  15 2019-12-20  Tom Tromey  <tom@tromey.com>
  16
  17         * tui/tui.c (tui_show_source): Update.
  18         * tui/tui-winsource.h (tui_update_source_windows_with_line): Update.
  19         * tui/tui-winsource.c (tui_update_source_windows_with_line): Take
  20         a symtab_symbol_info, not a separate symtab and line.  Simplify.
  21
  22 2019-12-20  Tom Tromey  <tom@tromey.com>
  23
  24         * tui/tui-winsource.c (tui_update_source_windows_with_addr):
  25         Simplify.
  26
  27 2019-12-20  Tom Tromey  <tom@tromey.com>
  28
  29         * tui/tui-winsource.h (struct tui_source_window_base)
  30         <set_contents, update_source_window_as_is, update_source_window>:
  31         Take a sal, not a separate symtab and tui_line_or_address.
  32         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
  33         (tui_source_window_base::update_source_window_as_is): Take a sal,
  34         not a separate symtab and tui_line_or_address.
  35         (tui_update_source_windows_with_addr)
  36         (tui_update_source_windows_with_line)
  37         (tui_source_window_base::rerender)
  38         (tui_source_window_base::refill): Update.
  39         * tui/tui-source.h (struct tui_source_window) <set_contents>: Take
  40         a sal, not a separate symtab and tui_line_or_address.
  41         * tui/tui-source.c (tui_source_window::set_contents): Take a sal,
  42         not a separate symtab and tui_line_or_address.
  43         (tui_source_window::maybe_update): Update.
  44         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>: Take
  45         a sal, not a separate symtab and tui_line_or_address.
  46         * tui/tui-disasm.c (tui_disasm_window::set_contents): Take a sal,
  47         not a separate symtab and tui_line_or_address.
  48         (tui_disasm_window::do_scroll_vertical)
  49         (tui_disasm_window::maybe_update): Update.
  50
  51 2019-12-20  Tom Tromey  <tom@tromey.com>
  52
  53         * tui/tui-winsource.c (tui_source_window_base::refill): Use
  54         start_line_or_addr.
  55         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Use
  56         start_line_or_addr.
  57         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
  58         start_line_or_addr.
  59
  60 2019-12-20  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-winsource.h (struct tui_source_window_base)
  63         <set_contents>: Return bool.
  64         * tui/tui-winsource.c
  65         (tui_source_window_base::update_source_window_as_is): Update.
  66         * tui/tui-source.h (struct tui_source_window) <set_contents>:
  67         Return bool.
  68         * tui/tui-source.c (tui_source_window::set_contents): Return
  69         bool.  Simplify.
  70         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
  71         Return bool.
  72         * tui/tui-disasm.c (tui_disasm_window::set_contents): Return
  73         bool.
  74
  75 2019-12-20  Tom Tromey  <tom@tromey.com>
  76
  77         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
  78         (tui_update_source_windows_with_line): Call update_source_window.
  79         * tui/tui-source.h (struct tui_source_window)
  80         <show_symtab_source>: Don't declare.
  81         * tui/tui-source.c (tui_source_window::show_symtab_source):
  82         Remove.
  83
  84 2019-12-20  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
  87         update_source_window directly.
  88         * tui/tui-disasm.h (tui_show_disassem): Don't declare.
  89         * tui/tui-disasm.c (tui_show_disassem): Remove.
  90
  91 2019-12-20  Tom Tromey  <tom@tromey.com>
  92
  93         * tui/tui-winsource.c
  94         (tui_source_window_base::update_source_window_as_is): Don't switch focus.
  95         * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
  96
  97 2019-12-20  Tom Tromey  <tom@tromey.com>
  98
  99         * tui/tui-winsource.h (struct tui_source_window_base)
 100         <maybe_update>: Remove line_no and addr parameters.
 101         * tui/tui-stack.c (tui_show_frame_info): Set PC on sal.  Update.
 102         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 103         Update.
 104         * tui/tui-source.c (tui_source_window::maybe_update): Remove
 105         line_no and addr parameters.
 106         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 107         Update.
 108         * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
 109         line_no and addr parameters.
 110
 111 2019-12-20  Tom Tromey  <tom@tromey.com>
 112
 113         * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
 114         (tui_source_window_base::update_breakpoint_info): Remove asserts.
 115
 116 2019-12-20  Tom Tromey  <tom@tromey.com>
 117
 118         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
 119         tui_show_disassem.
 120         * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
 121         declare.
 122         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
 123
 124 2019-12-20  Tom Tromey  <tom@tromey.com>
 125
 126         * tui/tui.h (tui_show_source): Remove parameters.
 127         * tui/tui.c (tui_show_source): Remove parameters.
 128         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 129
 130 2019-12-20  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui.c (tui_show_source): Update.
 133         * tui/tui-winsource.c (tui_display_main): Update.
 134         * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
 135         to symtab.
 136         * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
 137         to symtab.
 138         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
 139
 140 2019-12-20  Tom Tromey  <tom@tromey.com>
 141
 142         PR tui/23619:
 143         * tui/tui-io.c (tui_rl_saved_prompt): Remove.
 144         (tui_redisplay_readline): Use rl_display_prompt.
 145         (tui_prep_terminal): Update.
 146
 147 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 148
 149         * configure: Regenerate.
 150         * configure.ac: Quote variable arguments of test.
 151         * gdbsupport/common.m4: Likewise.
 152
 153 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 154
 155         * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
 156         2 to pow ().
 157
 158 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 159
 160         * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
 161         log10 to double to fix Solaris 11 with gcc 5.5.
 162
 163 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 164
 165         * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
 166         "sun" to "saddr_un".
 167
 168 2019-12-19  Tom Tromey  <tromey@adacore.com>
 169
 170         * ui-out.h (enum class field_kind): Fix comment.
 171
 172 2019-12-11  Tom Tromey  <tromey@adacore.com>
 173
 174         * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
 175
 176 2019-12-18  Tom Tromey  <tromey@adacore.com>
 177
 178         PR build/25268:
 179         * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
 180         type on macOS.  Add comment.
 181
 182 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 183
 184         * c-lang.c (c_get_string, asm_language_defn): Remove space
 185         before tab.
 186
 187 2019-12-18  Tom Tromey  <tromey@adacore.com>
 188
 189         PR build/25250:
 190         * ui-out.c (ui_out::vmessage): Update.
 191         * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
 192         Rename.
 193         (string_field): Update.
 194         (signed_field): Update.
 195
 196 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 197
 198         * top.c (print_gdb_configuration): Adjust indentation.
 199
 200 2019-12-17  Christian Biesinger  <cbiesinger@google.com>
 201
 202         * bsd-kvm.c: Include gdbsupport/pathstuff.h.
 203
 204 2019-12-17  Simon Marchi  <simon.marchi@polymtl.ca>
 205
 206         * tui/tui-layout.h (class tui_layout_base): Add virtual
 207         destructor.
 208
 209 2019-12-16  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 210
 211         * infcmd.c (prepare_one_step): Step over skipped inline functions.
 212         * infrun.c (inline_frame_is_marked_for_skip): New helper function.
 213         (process_event_stop_test): Keep stepping over skipped inline functions.
 214
 215 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 216
 217         * jit.c (struct gdb_block) <next>: Remove field.
 218         (struct gdb_symtab) <~gdb_symtab>: Remove.
 219         <blocks>: Change type to std::forward_list<gdb_block>.
 220         (compare_block): Remove.
 221         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
 222         block at the beginning, don't mind about sorting.
 223         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
 224         before using it.
 225
 226 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 227
 228         * jit.c (struct gdb_block): Add constructor, initialize
 229         real_block and next fields.
 230         <name>: Change type to gdb::unique_xmalloc_ptr.
 231         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
 232         (jit_block_open_impl): Allocate gdb_block with new.
 233         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
 234
 235 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 236
 237         * jit.c: Include forward_list.
 238         (struct gdb_symtab) <next>: Remove field.
 239         (struct gdb_object) <symtabs>: Change type to
 240         std::forward_list<gdb_symtab>.
 241         (jit_object_open_impl): Allocate gdb_object with new.
 242         (jit_symtab_open_impl): Adjust to std::forward_list.
 243         (finalize_symtab): Don't delete symtab.
 244         (jit_object_close_impl):  Adjust to std::forward_list.  Free
 245         gdb_object with delete.
 246
 247 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 248
 249         * jit.c (struct gdb_symtab): Add constructor, destructor,
 250         initialize fields.
 251         <linetable>: Change type to unique_xmalloc_ptr.
 252         <file_name>: Change type to std::string.
 253         (jit_symtab_open_impl): Allocate gdb_symtab with new.
 254         (jit_symtab_line_mapping_add_impl): Adjust.
 255         (finalize_symtab): Adjust, call delete on stab.
 256
 257 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 258
 259         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
 260
 261 2019-12-16  Tom Tromey  <tromey@adacore.com>
 262
 263         * windows-nat.c (windows_nat_target::attach): Update.
 264         * remote.c (extended_remote_target::attach): Update.
 265         * procfs.c (procfs_target::attach): Update.
 266         * nto-procfs.c (nto_procfs_target::attach): Update.
 267         (nto_procfs_target::create_inferior): Update.
 268         * inf-ptrace.c (inf_ptrace_target::attach): Update.
 269         * gnu-nat.c (gnu_nat_target::attach): Update.
 270         (gnu_nat_target::detach): Update.
 271         * darwin-nat.c (darwin_nat_target::attach): Update.
 272         * corefile.c (get_exec_file): Constify result.  Remove extraneous
 273         return.
 274         * bsd-kvm.c (bsd_kvm_target_open): Update.
 275         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
 276
 277 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
 278
 279         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
 280         (we no longer need to include time.h before pathmax.h)
 281
 282 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 283
 284         * ada-exp.y (write_ambiguous_var): Update.
 285         * coffread.c (process_coff_symbol): Update.
 286         * ctfread.c (ctf_add_enum_member_cb): Update.
 287         (new_symbol): Update.
 288         * dwarf2read.c (fixup_go_packaging): Update.
 289         (new_symbol): Update.
 290         * language.c (language_alloc_type_symbol): Update.
 291         * mdebugread.c (new_symbol): Update.
 292         * minsyms.c (minimal_symbol_reader::record_full): Update.
 293         * psymtab.c (add_psymbol_to_bcache): Update.
 294         * stabsread.c (define_symbol): Update.
 295         (read_enum_type): Update.
 296         * symtab.c (symbol_set_language): Make this a member function...
 297         (general_symbol_info::set_language): ... here.
 298         * symtab.h (struct general_symbol_info) <set_language>: New function.
 299         (SYMBOL_SET_LANGUAGE): Remove.
 300         (symbol_set_language): Remove.
 301
 302 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 303
 304         * ada-lang.c (ada_add_block_symbols): Update.
 305         (ada_collect_symbol_completion_matches): Update.
 306         * ax-gdb.c (gen_expr): Update.
 307         * block.c (block_lookup_symbol): Update.
 308         (block_lookup_symbol_primary): Update.
 309         (block_find_symbol): Update.
 310         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
 311         * dbxread.c (process_one_symbol): Update.
 312         * dictionary.c (insert_symbol_hashed): Update.
 313         (collate_pending_symbols_by_language): Update.
 314         (mdict_add_symbol): Update.
 315         * dwarf-index-write.c (write_psymbols): Update.
 316         * dwarf2read.c (fixup_go_packaging): Update.
 317         * findvar.c (read_var_value): Update.
 318         * ft32-tdep.c (ft32_skip_prologue): Update.
 319         * go-lang.c (go_symbol_package_name): Update.
 320         * language.h (scoped_switch_to_sym_language_if_auto::
 321         scoped_switch_to_sym_language_if_auto): Update.
 322         * linespec.c (find_method): Update.
 323         (find_label_symbols_in_block): Update.
 324         * mdebugread.c (parse_symbol): Update.
 325         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 326         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 327         (minimal_symbol_reader::install): Update.
 328         * moxie-tdep.c (moxie_skip_prologue): Update.
 329         * parse.c (parse_exp_in_context): Update.
 330         * psymtab.c (psymbol_name_matches): Update.
 331         (match_partial_symbol): Update.
 332         (lookup_partial_symbol): Update.
 333         (psymbol_hash): Update.
 334         (psymbol_compare): Update.
 335         * python/py-framefilter.c (extract_sym): Update.
 336         (py_print_single_arg): Update.
 337         * stabsread.c (define_symbol): Update.
 338         * stack.c (print_frame_arg): Update.
 339         (find_frame_funname): Update.
 340         (info_frame_command_core): Update.
 341         * symfile.c (set_initial_language): Update.
 342         * symtab.c (symbol_set_demangled_name): Update.
 343         (symbol_get_demangled_name): Update.
 344         (symbol_set_language): Update.
 345         (symbol_find_demangled_name): Update.
 346         (symbol_set_names): Update.
 347         (general_symbol_info::natural_name): Update.
 348         (general_symbol_info::demangled_name): Update.
 349         (general_symbol_info::search_name): Update.
 350         (symbol_matches_search_name): Update.
 351         (eq_symbol_entry): Update.
 352         (iterate_over_symbols): Update.
 353         (completion_list_add_symbol): Update.
 354         (completion_list_add_msymbol): Update.
 355         (completion_list_add_fields): Update.
 356         * symtab.h (struct general_symbol_info) <language>: New function.
 357         <language>: Rename to...
 358         <m_language>: ...this.
 359         (SYMBOL_LANGUAGE): Remove.
 360         (MSYMBOL_LANGUAGE): Remove.
 361         (struct symbol) <ctor>: Update.
 362         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 363
 364 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 365
 366         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 367         set the language of sym.
 368         * language.c (language_alloc_type_symbol): Likewise.
 369
 370 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 371
 372         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 373         PR gdb/23613
 374         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 375         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 376         (core_target_open): Use 'gdb_abspath'.
 377         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 378         'current_directory == NULL' case.
 379         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 380         explain what happens when 'current_directory' is NULL.
 381         * go32-nat.c (go32_nat_target::wait): Check if
 382         'current_directory' is NULL before call to 'chdir'.
 383         * source.c (add_path): Use 'gdb_abspath'.
 384         * top.c: Include 'gdbsupport/pathstuff.h'.
 385         (init_history): Use 'gdb_abspath'.
 386         (set_history_filename): Likewise.
 387         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 388         (tfile_target_open): Use 'gdb_abspath'.
 389
 390 2019-12-13  Tom Tromey  <tromey@adacore.com>
 391
 392         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 393         warning or error.
 394
 395 2019-12-13  Tom Tromey  <tromey@adacore.com>
 396
 397         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 398
 399 2019-12-13  Tom Tromey  <tromey@adacore.com>
 400
 401         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 402
 403 2019-12-13  Tom Tromey  <tromey@adacore.com>
 404
 405         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 406
 407 2019-12-13  Tom Tromey  <tromey@adacore.com>
 408
 409         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 410         (string_vappendf): Add ARI comment.
 411
 412 2019-12-13  Tom Tromey  <tromey@adacore.com>
 413
 414         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 415         floatformat_to_double.
 416         * target-float.c (host_float_ops<T>::from_target): Add ARI
 417         comment.
 418
 419 2019-12-13  Tom Tromey  <tromey@adacore.com>
 420
 421         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 422         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 423         ARI marker to abort.
 424         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 425
 426 2019-12-13  Tom Tromey  <tromey@adacore.com>
 427
 428         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 429
 430 2019-12-13  Tom Tromey  <tromey@adacore.com>
 431
 432         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 433
 434 2019-12-13  Tom Tromey  <tromey@adacore.com>
 435
 436         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 437         checks.
 438
 439 2019-12-13  Tom Tromey  <tromey@adacore.com>
 440
 441         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 442         end>: No longer "const".
 443
 444 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 445
 446         * jit.c: Fix indentation, replace spaces with tabs where
 447         applicable.
 448
 449 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 450
 451         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 452
 453 2019-12-12  Tom Tromey  <tom@tromey.com>
 454
 455         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 456         unique_ptr.
 457
 458 2019-12-12  Tom Tromey  <tom@tromey.com>
 459
 460         * progspace.h (objfile_list): New typedef.
 461         (class unwrapping_objfile_iterator)
 462         (struct unwrapping_objfile_range): Newl
 463         (struct program_space) <objfiles_range>: Change type.
 464         <objfiles>: Change return type.
 465         <add_objfile>: Change type of "objfile" parameter.
 466         <objfiles_list>: Now a list of shared_ptr.
 467         * progspace.c (program_space::add_objfile): Change type of
 468         "objfile".  Update.
 469         (program_space::remove_objfile): Update.
 470         * objfiles.h (struct objfile) <~objfile>: Make public.
 471         * objfiles.c (objfile::make): Update.
 472         (objfile::unlink): Don't call delete.
 473
 474 2019-12-12  Tom Tromey  <tom@tromey.com>
 475
 476         * symfile.c (symbol_file_clear): Update.
 477         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 478         method.
 479         * progspace.c (program_space::free_all_objfiles): New method.
 480         * objfiles.h (free_all_objfiles): Don't declare.
 481         * objfiles.c (free_all_objfiles): Move to program_space.
 482
 483 2019-12-12  Tom Tromey  <tom@tromey.com>
 484
 485         * progspace.c (program_space::add_objfile)
 486         (program_space::remove_objfile): Update.
 487         (program_space::multi_objfile_p): Remove.
 488         * objfiles.h (struct objfile) <next>: Remove.
 489         * objfiles.c (objfile::objfile): Update.
 490         (put_objfile_before): Update.
 491         (unlink_objfile): Update.
 492         * progspace.h (object_files): Remove.
 493         (struct program_space) <objfiles_head>: Remove.
 494         <objfiles_list>: New member.
 495         <objfiles_range, objfiles_safe_range>: Change type.
 496         (objfiles): Change return type.
 497         (objfiles_safe): Update.
 498         (multi_objfile_p): Rewrite and inline.
 499         (object_files): Remove macro.
 500
 501 2019-12-12  Tom Tromey  <tom@tromey.com>
 502
 503         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 504         second constructor.
 505         (basic_safe_range): New class.
 506
 507 2019-12-12  Tom Tromey  <tom@tromey.com>
 508
 509         * progspace.c (program_space::multi_objfile_p): New method.
 510         * printcmd.c (info_symbol_command): Update.
 511         * maint.c (maintenance_translate_address): Update.
 512         * objfiles.h (MULTI_OBJFILE_P): Remove.
 513         * progspace.h (struct program_space) <multi_objfile_p>: New
 514         method.
 515
 516 2019-12-12  Tom Tromey  <tom@tromey.com>
 517
 518         * progspace.h (struct program_space) <remove_objfile>: Declare.
 519         * progspace.c (program_space::remove_objfile): New method.
 520         * objfiles.c (unlink_objfile): Remove.
 521         (objfile::unlink): Call remove_objfile.
 522         (objfile): Don't call unlink_objfile.
 523
 524 2019-12-12  Tom Tromey  <tom@tromey.com>
 525
 526         * progspace.h (struct program_space) <add_objfile>: Declare
 527         method.
 528         * progspace.c (program_space::add_objfile): New method.
 529         * objfiles.c (~objfile): Don't unlink objfile.
 530         (put_objfile_before): Remove.
 531         (add_separate_debug_objfile): Don't call put_objfile_before.
 532         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 533         the per-program-space data.
 534
 535 2019-12-12  Tom Tromey  <tom@tromey.com>
 536
 537         * symfile.c (syms_from_objfile_1): Use objfile_up.
 538         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 539         method.
 540         (reread_symbols): Use objfile_up.
 541         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 542         unlink method.
 543         * objfiles.h (struct objfile) <~objfile>: Now private.
 544         <unlink>: New method.
 545         (struct objfile_deleter): New.
 546         (objfile_up): New typedef.
 547         * objfiles.c (objfile::unlink): New method.
 548         (free_objfile_separate_debug, free_all_objfiles)
 549         (objfile_purge_solibs): Use it.
 550         * jit.c (jit_unregister_code): Remove.
 551         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 552         objfile.
 553         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 554         objfile.
 555         * compile/compile-object-load.c (compile_object_load): Use
 556         objfile_up.
 557
 558 2019-12-12  Tom Tromey  <tom@tromey.com>
 559
 560         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 561         objfile::make.
 562         * objfiles.h (struct objjfile) <make>: No longer inline.
 563         (add_separate_debug_objfile): Don't declare.
 564         * objfiles.c (add_separate_debug_objfile): Now static.
 565         (objfile::make): Move from objfiles.h.  Call
 566         add_separate_debug_objfile.  Add "parent" parameter.
 567
 568 2019-12-12  Tom Tromey  <tom@tromey.com>
 569
 570         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 571         * objfiles.h (struct objfile): Make constructor private.
 572         <make>: New static method.
 573         * jit.c (jit_object_close_impl): Update.
 574
 575 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 576
 577         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 578         gdb::byte_vector.
 579
 580 2019-12-12  Tom Tromey  <tromey@adacore.com>
 581
 582         * xml-support.c (xml_fetch_content_from_file): Don't call
 583         malloc_failure.
 584         * utils.h (class gdb_argv): Remove malloc_failure comment.
 585         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 586
 587 2019-12-12  Tom Tromey  <tromey@adacore.com>
 588
 589         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 590         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 591         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 592         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 593         * riscv-ravenscar-thread.c: New file.
 594         * riscv-ravenscar-thread.h: New file.
 595         * riscv-tdep.c (riscv_gdbarch_init): Call
 596         register_riscv_ravenscar_ops.
 597
 598 2019-12-12  Tom Tromey  <tromey@adacore.com>
 599
 600         * gdbsupport/thread-pool.c (set_thread_name): Use
 601         ATTRIBUTE_UNUSED.
 602
 603 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 604
 605         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 606         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 607         macros.
 608
 609 2019-12-11  Tom Tromey  <tom@tromey.com>
 610
 611         * tui/tui-win.c (tui_set_win_height_command): Call
 612         tui_adjust_window_height.
 613         (tui_adjust_win_heights, new_height_ok): Remove.
 614         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 615         * tui/tui-layout.c (tui_adjust_window_height): New function.
 616
 617 2019-12-11  Tom Tromey  <tom@tromey.com>
 618
 619         * tui/tui-win.c (tui_resize_all): Remove code, call
 620         tui_apply_current_layout.
 621
 622 2019-12-11  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 625         * tui/tui-layout.c (standard_layouts, applied_layout): New
 626         globals.
 627         (tui_apply_current_layout): New function.
 628         (show_layout): Set applied_layout.  Call
 629         tui_apply_current_layout.
 630         (show_source_command, show_disasm_command)
 631         (show_source_disasm_command, show_data)
 632         (show_source_or_disasm_and_command): Remove.
 633         (initialize_layouts): New function.
 634         (_initialize_tui_layout): Call initialize_layouts.
 635
 636 2019-12-11  Tom Tromey  <tom@tromey.com>
 637
 638         * tui/tui-layout.h (class tui_layout_base)
 639         (class tui_layout_window, class tui_layout_split): New.
 640         * tui/tui-layout.c (tui_get_window_by_name)
 641         (tui_layout_window::clone, tui_layout_window::apply)
 642         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 643         (tui_layout_split::add_window, tui_layout_split::clone)
 644         (tui_layout_split::get_sizes)
 645         (tui_layout_split::set_weights_from_heights)
 646         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 647         functions.
 648         (tui_layout_split::add_split, tui_layout_split::add_split)
 649         (tui_layout_split::set_weights_from_heights)
 650         (tui_layout_split::set_weights_from_heights): New functions.
 651
 652 2019-12-11  Tom Tromey  <tom@tromey.com>
 653
 654         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 655         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 656         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 657         * tui/tui-data.h (struct tui_point): Remove.
 658         (struct tui_gen_win_info) <origin>: Remove.
 659         <x, y>: New fields.
 660         * tui/tui-command.c (tui_cmd_window::resize): Update.
 661
 662 2019-12-11  Tom Tromey  <tom@tromey.com>
 663
 664         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 665         Implement.
 666         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 667         Implement.
 668         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 669         method.
 670         (struct tui_win_info) <min_height>: Implement.
 671
 672 2019-12-11  Tom Tromey  <tom@tromey.com>
 673
 674         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 675         (struct tui_win_info) <can_box>: Update.
 676
 677 2019-12-11  Tom Tromey  <tom@tromey.com>
 678
 679         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 680         method.
 681         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 682         method.
 683         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 684         method.
 685         (struct tui_win_info) <max_height>: Now override.
 686
 687 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 688
 689         * NEWS: Create a new section for the next release branch.
 690         Rename the section of the current branch, now that it has
 691         been cut.
 692
 693 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 694
 695         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 696         * version.in: Bump version to 10.0.50.DATE-git.
 697
 698 2019-12-11  Tom Tromey  <tromey@adacore.com>
 699
 700         PR build/25268:
 701         * gdbsupport/thread-pool.c (set_thread_name): New function.
 702         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 703         (thread_pool::thread_function): Call set_thread_name.
 704
 705 2019-12-11  Tom Tromey  <tromey@adacore.com>
 706
 707         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 708         bfd_get_signed_8.
 709
 710 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 711
 712         * NEWS: Document -raw-values option and the related setting commands.
 713         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 714         only set it on when /r is given.
 715         * valprint.c (value_print_option_defs): New element raw-values.
 716         * Makefile.in: Add the new file.
 717
 718 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 719
 720         * gdbsupport/safe-strerror.c: Supress the unused function warning
 721         for select_strerror_r.
 722
 723 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 724
 725         * config.in: Regenerate.
 726         * configure: Regenerate.
 727         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 728         safe_strerror instead of strerror.
 729         * gdbsupport/common.m4: Don't check for strerror.
 730         * gdbsupport/safe-strerror.c: Support both the glibc version
 731         of strerror_r and the XSI version.
 732
 733 2019-12-10  Tom Tromey  <tromey@adacore.com>
 734
 735         * ada-typeprint.c (print_choices): Use a single "?".
 736         (print_variant_part): Print "?" if the discriminant name
 737         is not known.
 738
 739 2019-12-10  George Barrett  <bob@bob131.so>
 740
 741         Fix scripted probe breakpoints.
 742         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 743         declaration forward.
 744         (breakpoint_ops_for_event_location_type)
 745         (breakpoint_ops_for_event_location): Add function definitions.
 746         (break_command_1, trace_command): Use
 747         breakpoint_ops_for_event_location.
 748         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 749         declarations.
 750         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 751         breakpoint_ops_for_event_location.
 752         * python/py-breakpoint.c (bppy_init): Use
 753         breakpoint_ops_for_event_location.
 754
 755 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 756
 757         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 758         when ranking an lvalue argument for an rvalue parameter.
 759
 760 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 761
 762         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 763         template argument for scoped_restore_tmpl from bool to int.
 764
 765 2019-12-07  Keith Seitz  <keiths@redhat.com>
 766
 767         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 768         (build_id_to_debug_bfd): Make static, rewriting to use
 769         build_id_to_bfd_suffix.
 770         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 771         adding `suffix' parameter. Append SUFFIX to file names
 772         when searching for matching files.
 773         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 774         (build_id_to_exec_bfd): Likewise.
 775         * build-id.h (build_id_to_debug_bfd): Clarify that function
 776         searches for BFD of debug info file.
 777         (build_id_to_exec_bfd): Declare.
 778         * corelow.c: Include build-id.h.
 779         (locate_exec_from_corefile_build_id): New function.
 780         (core_target_open): If no executable BFD is found,
 781         search for a core file BFD using build-id.
 782
 783 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 784
 785         * bcache.c: Put in namespace gdb.
 786         * bcache.h: Likewise.
 787         * gdbtypes.c (check_types_worklist): Update.
 788         (types_deeply_equal): Update.
 789         * macrotab.c (struct macro_table) <bcache>: Update.
 790         (new_macro_table): Update.
 791         * macrotab.h (struct bcache): Put this forward declaration
 792         inside namespace gdb.
 793         (new_macro_table): Update.
 794         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 795         Update.
 796         <macro_cache>: Update.
 797         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 798
 799 2019-12-06  Tom de Vries  <tdevries@suse.de>
 800
 801         PR symtab/24971
 802         * block.c (best_symbol, better_symbol): New function.
 803         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 804         decl.
 805
 806 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 807
 808         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 809         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 810         for ranking see-through reference cases.
 811
 812 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 813         * stack.c (faas_command): Check a command is provided.
 814         * thread.c (taas_command, tfaas_command): Likewise.
 815
 816 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 817         * inferior.c (prune_inferiors):  Only call delete_inferior,
 818         Do not modify the inferior list.
 819
 820 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 821
 822         * c-exp.y: Update calls to lookup_typename,
 823         lookup_signed_typename and lookup_unsigned_typename.
 824         * c-lang.c (evaluate_subexp_c): Likewise.
 825         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 826         Likewise.
 827         * eval.c (binop_promote): Likewise.
 828         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 829         (lookup_unsigned_typename): Likewise.
 830         (lookup_signed_typename): Likewise.
 831         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 832         (lookup_signed_typename): Likewise.
 833         (lookup_typename): Likewise.
 834         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 835         lookup_typename, lookup_signed_typename,
 836         lookup_unsigned_typename.
 837         * m2-exp.y: Likewise.
 838         * printcmd.c (printf_wide_c_string): Likewise.
 839         (ui_printf): Likewise.
 840         * python/py-type.c (typy_lookup_typename): Likewise.
 841         * python/py-xmethods.c (python_xmethod_worker::invoke):
 842         Likewise.
 843         * rust-exp.y: Likewise.
 844
 845 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 846
 847         * configure.nat (obsd64): Add missing files x86-nat.o and
 848         nat/x86-dregs.o.
 849
 850 2019-12-04  Tom Tromey  <tom@tromey.com>
 851
 852         * valprint.c (val_print_string): Use metadata_style.
 853         * go-valprint.c (print_go_string): Use metadata style.
 854         * p-valprint.c (pascal_object_print_static_field): Use metadata
 855         style.
 856         * cp-valprint.c (cp_print_static_field): Use metadata style.
 857
 858 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 859             Chris January  <chris.january@arm.com>
 860
 861         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 862         tokens.
 863         (typebase): New patterns for complex, single/double precision, and
 864         single/double complex.
 865         (f77_keywords): Change token for complex keyword, and add single,
 866         double, and precision keywords.
 867
 868 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 869
 870         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 871         "info io_registers".
 872
 873 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 874
 875         * regcache.c (cooked_read_test): Initialize thread list of
 876         mock_inferior.
 877
 878 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 879
 880         * aarch64-linux-tdep.c: Remove includes.
 881
 882 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 883
 884         * aarch64-tdep.c: Remove includes.
 885
 886 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 887
 888         * filtered-iterator.h (filtered_iterator) <operator==,
 889         operator!=>: Compare wrapped iterators, not wrapped pointers.
 890         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 891         unittests/filtered_iterator-selftests.c.
 892         * unittests/filtered_iterator-selftests.c: New file.
 893
 894 2019-12-04  Tom Tromey  <tromey@adacore.com>
 895
 896         * gdbtypes.c (create_range_type): Inherit endianity
 897         from base type.
 898
 899 2019-12-04  Tom Tromey  <tromey@adacore.com>
 900
 901         * ada-lang.c (decode_constrained_packed_array)
 902         (ada_value_assign, value_assign_to_component): Update.
 903         * dwarf2loc.c (rw_pieced_value, access_memory)
 904         (dwarf2_compile_expr_to_ax): Update.
 905         * dwarf2read.c (dwarf2_add_field): Update.
 906         * eval.c (evaluate_subexp_standard): Update.
 907         * gdbarch.c, gdbarch.h: Rebuild.
 908         * gdbarch.sh (bits_big_endian): Remove.
 909         * gdbtypes.h (union field_location): Update comment.
 910         * target-descriptions.c (make_gdb_type): Update.
 911         * valarith.c (value_bit_index): Update.
 912         * value.c (struct value) <bitpos>: Update comment.
 913         (unpack_bits_as_long, modify_field): Update.
 914         * value.h (value_bitpos): Update comment.
 915
 916 2019-12-04  Tom Tromey  <tromey@adacore.com>
 917
 918         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 919         endian-ness.
 920
 921 2019-12-04  Tom Tromey  <tromey@adacore.com>
 922
 923         * dwarf2read.c (dwarf2_init_float_type)
 924         (dwarf2_init_complex_target_type): Add byte_order parameter.
 925         (read_base_type): Compute byte order earlier.
 926         * gdbtypes.c (init_float_type): Add byte_order parameter.
 927         * gdbtypes.h (init_float_type): Add byte_order parameter.
 928
 929 2019-12-04  Tom Tromey  <tromey@adacore.com>
 930
 931         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 932
 933 2019-12-04  Tom Tromey  <tromey@adacore.com>
 934
 935         * dwarf2read.c (process_structure_scope): Initialize
 936         "discr_offset".
 937
 938 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 939
 940         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 941         add it into the search spec.
 942         (parse_max_results_option): New function.
 943         (mi_info_functions_or_variables): Parse -max-results flag and pass
 944         it to mi_symbol_info.
 945         (mi_cmd_symbol_info_modules): Likewise.
 946         (mi_cmd_symbol_info_types): Likewise.
 947         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 948         return type to bool, change result container into a set, and don't
 949         add new results if we have enough already.
 950         (global_symbol_searcher::add_matching_msymbols): Change return
 951         type to bool, and don't add new results if we have enough already.
 952         (sort_search_symbols_remove_dups): Delete.
 953         (global_symbol_searcher::search): Early exit from search loop when
 954         we have enough results.  Use a std::set to collect the results
 955         from calling add_matching_symbols.
 956         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 957         member function.
 958         (global_symbol_searcher) <m_max_search_results>: New member
 959         variable.
 960         (global_symbol_searcher) <add_matching_symbols>: Update header
 961         comment and change return type to bool.
 962         (global_symbol_searcher) <add_matching_msymbols>: Update header
 963         comment and change return type to bool.
 964
 965 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 966
 967         * symtab.c (symbol_search::compare_search_syms): Update header
 968         comment.
 969         (global_symbol_searcher::is_suitable_msymbol): New function.
 970         (global_symbol_searcher::expand_symtabs): New function.
 971         (global_symbol_searcher::add_matching_symbols): New function.
 972         (global_symbol_searcher::add_matching_msymbols): New function.
 973         (global_symbol_searcher::search): Move most of the content
 974         into the new functions above, and call them as needed.
 975         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 976         function.
 977         (global_symbol_searcher) <add_matching_symbols>: New member
 978         function.
 979         (global_symbol_searcher) <add_matching_msymbols>: New member
 980         function.
 981         (global_symbol_searcher) <is_suitable_msymbol>: New member
 982         function.
 983
 984 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 985
 986         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 987         -symbol-info-module-variables entries.
 988         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 989         (mi_cmd_symbol_info_module_variables): Declare.
 990         * mi/mi-symbol-cmds.c
 991         (module_symbol_search_iterator): New typedef.
 992         (output_module_symbols_in_single_module_and_file): New function.
 993         (output_module_symbols_in_single_module): New function.
 994         (mi_info_module_functions_or_variables): New function.
 995         (mi_cmd_symbol_info_module_functions): New function.
 996         (mi_cmd_symbol_info_module_variables): New function.
 997         * NEWS: Mention new MI command.
 998
 999 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
1000
1001         * bcache.c (hash): Remove.
1002         (hash_continue): Remove.
1003         * bcache.h (hash): Remove.
1004         (hash_continue): Remove.
1005         (struct bcache) <ctor>: Update.
1006         * psymtab.c (psymbol_hash): Update.
1007         * stabsread.c (hashname): Update.
1008         * utils.h (fast_hash): Add an argument for a start value,
1009         defaulting to zero.
1010
1011 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1012         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
1013         (destroy_block_symbol_cache): New function.
1014         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
1015         (resize_symbol_cache): Likewise.
1016
1017 2019-12-02  Tom Tromey  <tom@tromey.com>
1018
1019         * unittests/tui-selftests.c (run_tests): Make conditional.
1020         (_initialize_tui_selftest): Make conditional.
1021
1022 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
1023
1024         * aix-thread.c (debug_aix_thread): Change type to bool.
1025
1026 2019-12-02  Luis Machado  <luis.machado@linaro.org>
1027
1028         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
1029
1030 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1031
1032         * dwarf2read.c (read_tag_string_type): Read the fields required to
1033         make a dynamic string, and possibly create a dynamic range for the
1034         string.
1035         (attr_to_dynamic_prop): Setup is_reference based on the type of
1036         attribute being processed.
1037         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
1038         (resolve_dynamic_array): Rename to...
1039         (resolve_dynamic_array_or_string): ...this, update header comment,
1040         and accept TYPE_CODE_STRING.
1041         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
1042
1043 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1044
1045         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
1046         of its implementation from...
1047         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
1048         the new function.
1049
1050 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1051
1052         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
1053         create a range with stride where appropriate.
1054         * f-valprint.c: Include 'gdbarch.h'.
1055         (f77_print_array_1): Take the stride into account when walking the
1056         array.  Also convert the stride into addressable units.
1057         * gdbtypes.c (create_range_type): Initialise the stride to
1058         constant zero.
1059         (create_range_type_with_stride): New function, initialise the
1060         range as normal, and then setup the stride.
1061         (has_static_range): Include the stride here.  Also change the
1062         return type to bool.
1063         (create_array_type_with_stride): Consider the range stride if the
1064         array isn't given its own stride.
1065         (resolve_dynamic_range): Resolve the stride if needed.
1066         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
1067         (struct range_bounds) <flag_is_byte_stride>: New member variable.
1068         (TYPE_BIT_STRIDE): Define.
1069         (TYPE_ARRAY_BIT_STRIDE): Define.
1070         (create_range_type_with_stride): Declare.
1071         * valarith.c (value_subscripted_rvalue): Take range stride into
1072         account when walking the array.
1073
1074 2019-12-01  Tom Tromey  <tom@tromey.com>
1075
1076         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
1077         specially.
1078
1079 2019-12-01  Tom Tromey  <tom@tromey.com>
1080
1081         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
1082         \0.
1083         * unittests/tui-selftests.c: New file.
1084         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1085
1086 2019-12-01  Tom Tromey  <tom@tromey.com>
1087
1088         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1089
1090 2019-12-01  Tom Tromey  <tom@tromey.com>
1091
1092         * NEWS: Document new settings.
1093         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1094         * tui/tui-win.c (_initialize_tui_win): Add border style
1095         observers.
1096         * tui/tui-io.h (tui_apply_style): Declare.
1097         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
1098         longer static.
1099         (apply_ansi_escape, tui_set_reverse_mode): Update.
1100         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1101         Add "skip_intensity" parameter.
1102         <changed>: New member.
1103         <do_set_value>: Declare.
1104         (tui_border_style, tui_active_border_style): Declare.
1105         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1106         globals.
1107         (cli_style_option): Initialize "changed".
1108         (cli_style_option::do_set_value): New function.
1109         (cli_style_option::add_setshow_commands): Add "skip_intensity"
1110         parameter.  Update.
1111         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1112         (_initialize_cli_style): Update.  Create TUI border style
1113         commands.
1114
1115 2019-12-01  Tom Tromey  <tom@tromey.com>
1116
1117         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1118         parameter.
1119         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1120         parameter.
1121         * tui/tui-win.h (compact_source): Declare.
1122         * tui/tui-win.c (compact_source): New global.
1123         (tui_set_compact_source, tui_show_compact_source): New functions.
1124         (_initialize_tui_win): Add "compact-source" setting.
1125         * tui/tui-source.c (tui_source_window::set_contents): Handle
1126         compact_source setting.
1127         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1128         * NEWS: Document new setting.
1129
1130 2019-11-30  Tom Tromey  <tom@tromey.com>
1131
1132         * dwarf2read.c (dwarf2_add_field): Include field offset when
1133         computing variant part length.
1134
1135 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1136         * NEWS:  Mention define-prefix.  Tell that command names can now
1137         contain a . character.
1138
1139 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1140
1141         * command.h (valid_cmd_char_p): Declare.
1142         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1143         the check of valid command char.
1144         (find_command_name_length, valid_user_defined_cmd_name_p): Use
1145         valid_cmd_char_p.
1146         * cli/cli-script.c (validate_comname): Likewise.
1147         * completer.c (gdb_completer_command_word_break_characters):
1148         Do not remove . from the word break char, update comments.
1149         (complete_line_internal_1): Use valid_cmd_char_p.
1150         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1151         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1152
1153 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1154
1155         * cli/cli-script.c (do_define_command): Ensure a redefined
1156         prefix command is kept as a prefix command.
1157         (define_prefix_command): New function.
1158         (show_user_1): Report user defined prefixes.
1159         (_initialize_cli_script):  Create the new 'define-prefix' command.
1160         Add completers for 'define' and 'document'.
1161         * top.c (execute_command):  If command is a user-defined prefix only
1162         command, report the list of commands for this prefix command.
1163
1164 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1165
1166         * valops.c (find_oload_champ): Improve debug output.
1167
1168 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1169
1170         * valops.c (find_oload_champ): Print part of debug messages
1171         before the badness vector is std::move'd.
1172
1173 2019-11-28  Tom Tromey  <tom@tromey.com>
1174
1175         * value.c (creal_internal_fn): Fix comment.
1176
1177 2019-11-28  Tom Tromey  <tom@tromey.com>
1178
1179         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1180         flag_bound_evaluated>: Now unsigned.
1181
1182 2019-11-28  Tom Tromey  <tom@tromey.com>
1183
1184         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1185         declare.
1186
1187 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
1188
1189         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1190         debug output.
1191         * jit.c (jit_unregister_code): Add debug print to match
1192         `jit_register_code`.
1193
1194 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1195
1196         * NEWS: Mention the new multithreaded symbol loading.
1197
1198 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1199
1200         * maint.c (n_worker_threads): Default to 0.
1201         (worker_threads_disabled): New function.
1202         * maint.h (worker_threads_disabled): New function.
1203         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1204         here if worker_threads_disabled () is true.
1205         (minimal_symbol_reader::install): Skip all threading if
1206         worker_threads_disabled () is true.
1207
1208 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1209
1210         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1211         hash code if possible.
1212         (add_minsym_to_demangled_hash_table): Likewise.
1213         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1214         on the background thread.
1215         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1216         Add these fields.
1217
1218 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1219
1220         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1221         of the mangled name on the background thread.
1222         * symtab.c (symbol_set_names): Allow passing in the hash of the
1223         linkage_name.
1224         * symtab.h (symbol_set_names): Likewise.
1225
1226 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1227
1228         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1229         physnames are computed for inherited DIEs.
1230
1231 2019-11-27  Tom Tromey  <tromey@adacore.com>
1232
1233         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1234         backslashes.
1235         * cp-support.c: Remove unnecessary backslashes.
1236
1237 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1238
1239         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1240         with sym->set_linkage_name.
1241         * coffread.c (coff_read_enum_type): Likewise.
1242         * mdebugread.c (parse_symbol): Likewise.
1243         * stabsread.c (patch_block_stabs): Likewise.
1244         (define_symbol): Likewise.
1245         (read_enum_type): Likewise.
1246         (common_block_end): Likewise.
1247         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1248         function.
1249         (SYMBOL_SET_LINKAGE_NAME): Remove.
1250         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1251         with sym->set_linkage_name.
1252
1253 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1254
1255         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1256         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1257         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1258         * NEWS: Mention new MI command.
1259
1260 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1261
1262         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1263         '-symbol-info-types', and '-symbol-info-variables'.
1264         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1265         (mi_cmd_symbol_info_types): Declare.
1266         (mi_cmd_symbol_info_variables): Declare.
1267         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1268         (output_debug_symbol): New function.
1269         (output_nondebug_symbol): New function.
1270         (mi_symbol_info): New function.
1271         (mi_info_functions_or_variables): New function.
1272         (mi_cmd_symbol_info_functions): New function.
1273         (mi_cmd_symbol_info_types): New function.
1274         (mi_cmd_symbol_info_variables): New function.
1275         * NEWS: Mention new commands.
1276
1277 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1278
1279         * symtab.c (symbol_to_info_string): New function, most content
1280         moved from print_symbol_info, but updated to return a std::string.
1281         (print_symbol_info): Update to use symbol_to_info_string and print
1282         returned string.
1283         * symtab.h (symbol_to_info_string): Declare new function.
1284
1285 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1286
1287         * python/python.c (gdbpy_rbreak): Convert to using
1288         global_symbol_searcher.
1289         * symtab.c (file_matches): Convert return type to bool, change
1290         file list to std::vector, update header comment.
1291         (search_symbols): Rename to...
1292         (global_symbol_searcher::search): ...this and update now its
1293         a member function of global_symbol_searcher.  Take account of the
1294         changes to file_matches.
1295         (symtab_symbol_info): Convert to using global_symbol_searcher.
1296         (rbreak_command): Likewise.
1297         (search_module_symbols): Likewise.
1298         * symtab.h (enum symbol_search): Update comment.
1299         (search_symbols): Remove declaration.
1300         (class global_symbol_searcher): New class.
1301
1302 2019-11-26  Tom Tromey  <tromey@adacore.com>
1303
1304         * cp-support.c (_initialize_cp_support): Conditionally initialize
1305         gdb_demangle_attempt_core_dump.
1306
1307 2019-11-26  Tom Tromey  <tom@tromey.com>
1308
1309         * python/py-function.c (fnpy_init): Update.
1310         * value.h (add_internal_function): Adjust declaration.
1311         * value.c (function_destroyer): Remove.
1312         (do_add_internal_function): Don't set destroyer or copy name.
1313         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1314         Set name_allocated.
1315         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1316         (cmdpy_init): Set name_allocated.
1317         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1318         member.
1319         (~cmd_list_element): Free "name" if needed.
1320
1321 2019-11-26  Tom Tromey  <tom@tromey.com>
1322
1323         * value.h (add_internal_function): Add new overload.  Move
1324         documentation from value.h.
1325         * value.c (do_add_internal_function): New function.
1326         (add_internal_function): Use it.  Add new overload.
1327         (function_destroyer): Don't free doc.
1328         * python/py-function.c (fnpy_init): Update.
1329
1330 2019-11-26  Tom Tromey  <tom@tromey.com>
1331
1332         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1333         (cmdpy_init): Set "doc_allocated".
1334
1335 2019-11-26  Tom Tromey  <tom@tromey.com>
1336
1337         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1338         name of worker thread.
1339         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1340         pthread_setname_np.
1341         * configure, config.in: Rebuild.
1342
1343 2019-11-26  Tom Tromey  <tom@tromey.com>
1344
1345         * python/python.c (class gdbpy_gil): New.
1346         (struct gdbpy_event): Add constructor, destructor, operator().
1347         (gdbpy_post_event): Use run_on_main_thread.
1348         (gdbpy_initialize_events): Remove.
1349         (do_start_initialization): Update.
1350
1351 2019-11-26  Tom Tromey  <tom@tromey.com>
1352
1353         * NEWS: Add entry.
1354         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1355         commands.  Call update_thread_pool_size.
1356         (update_thread_pool_size, maintenance_set_worker_threads): New
1357         functions.
1358         (n_worker_threads): New global.
1359
1360 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1361             Tom Tromey  <tom@tromey.com>
1362
1363         * minsyms.c (minimal_symbol_reader::install): Use
1364         parallel_for_each.
1365         * gdbsupport/parallel-for.h: New file.
1366         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1367
1368 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1369             Tom Tromey  <tom@tromey.com>
1370
1371         * gdbsupport/thread-pool.h: New file.
1372         * gdbsupport/thread-pool.c: New file.
1373         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1374         (HFILES_NO_SRCDIR): Add thread-pool.h.
1375
1376 2019-11-26  Tom Tromey  <tom@tromey.com>
1377
1378         * event-top.h (thread_local_segv_handler): Declare.
1379         * event-top.c (thread_local_segv_handler): New global.
1380         (install_handle_sigsegv, handle_sigsegv): New functions.
1381         (async_init_signals): Install SIGSEGV handler.
1382         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1383         thread-local.
1384         (report_failed_demangle): New function.
1385         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1386         handler-setting code, instead use segv_handler.  Run warning code
1387         on main thread.
1388
1389 2019-11-26  Tom Tromey  <tom@tromey.com>
1390
1391         * run-on-main-thread.c: New file.
1392         * run-on-main-thread.h: New file.
1393         * unittests/main-thread-selftests.c: New file.
1394         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1395         main-thread-selftests.c.
1396         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1397         (COMMON_SFILES): Add run-on-main-thread.c.
1398
1399 2019-11-26  Tom Tromey  <tom@tromey.com>
1400
1401         * main.c (setup_alternate_signal_stack): Remove.
1402         (captured_main_1): Use gdb::alternate_signal_stack.
1403         * gdbsupport/alt-stack.h: New file.
1404
1405 2019-11-26  Tom Tromey  <tom@tromey.com>
1406
1407         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1408         Remove comment.
1409         (save_original_signals_state, restore_original_signals_state): Use
1410         gdb_sigmask.
1411         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1412         (_initialize_linux_nat): Use gdb_sigmask.
1413         * guile/guile.c (_initialize_guile): Use block_signals.
1414         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1415         * gdbsupport/gdb-sigmask.h: New file.
1416         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1417         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1418         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1419         pthread_sigmask.
1420         * configure, config.in: Rebuild.
1421         * gdbsupport/block-signals.h: New file.
1422
1423 2019-11-26  Tom Tromey  <tom@tromey.com>
1424
1425         * acinclude.m4: Include ax_pthread.m4.
1426         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1427         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1428         (CLIBS): Use PTHREAD_LIBS.
1429         (aclocal_m4_deps): Add ax_pthread.m4.
1430         * config.in, configure: Rebuild.
1431         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1432
1433 2019-11-26  Tom Tromey  <tom@tromey.com>
1434
1435         * symtab.h (struct minimal_symbol) <name_set>: New member.
1436         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1437         Don't call symbol_set_names.
1438         (minimal_symbol_reader::install): Call symbol_set_names.
1439
1440 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1441
1442         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1443         restore_active_ext_lang, as GIL is needed for (indirectly)
1444         called PyOS_InterruptOccurred.
1445
1446 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1447
1448         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1449         definition.
1450
1451 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1452
1453         * remote-sim.c (simulator_command): Make static, remove
1454         declaration.
1455
1456 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1457
1458         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1459         static.
1460         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1461         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1462         (main): Likewise.
1463         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1464         (main): Likewise.
1465         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1466         (main): Likewise.
1467         * unittests/basic_string_view/element_access/char/1.cc (test01):
1468         Likewise.
1469         (main): Likewise.
1470         * unittests/basic_string_view/element_access/char/empty.cc (main):
1471         Likewise.
1472         * unittests/basic_string_view/element_access/char/front_back.cc
1473         (test01): Likewise.
1474         (main): Likewise.
1475         * unittests/basic_string_view/inserters/char/2.cc (test05):
1476         Likewise.
1477         (main): Likewise.
1478         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1479         (test01): Likewise.
1480         (main): Likewise.
1481         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1482         (test01): Likewise.
1483         (main): Likewise.
1484         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1485         Likewise.
1486         * unittests/basic_string_view/operations/compare/char/1.cc
1487         (test01): Likewise.
1488         (main): Likewise.
1489         * unittests/basic_string_view/operations/compare/char/13650.cc
1490         (test01): Likewise.
1491         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1492         Likewise.
1493         (main): Likewise.
1494         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1495         Likewise.
1496         (main): Likewise.
1497         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1498         Likewise.
1499         (main): Likewise.
1500         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1501         Likewise.
1502         (main): Likewise.
1503         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1504         Likewise.
1505         (main): Likewise.
1506         * unittests/basic_string_view/operations/find/char/4.cc (main):
1507         Likewise.
1508         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1509         Likewise.
1510         (main): Likewise.
1511         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1512         Likewise.
1513         (main): Likewise.
1514         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1515         Likewise.
1516         (main): Likewise.
1517         * unittests/basic_string_view/operations/substr/char/1.cc
1518         (test01): Likewise.
1519         (main): Likewise.
1520         * unittests/basic_string_view/operators/char/2.cc (main):
1521         Likewise.
1522         * unittests/optional/assignment/1.cc (test): Likewise.
1523         * unittests/optional/assignment/2.cc (test): Likewise.
1524         * unittests/optional/assignment/3.cc (test): Likewise.
1525         * unittests/optional/assignment/4.cc (test): Likewise.
1526         * unittests/optional/assignment/5.cc (test): Likewise.
1527         * unittests/optional/assignment/6.cc (test): Likewise.
1528         * unittests/optional/assignment/7.cc (test): Likewise.
1529         * unittests/optional/cons/copy.cc (test): Likewise.
1530         * unittests/optional/cons/default.cc (test): Likewise.
1531         * unittests/optional/cons/move.cc (test): Likewise.
1532         * unittests/optional/cons/value.cc (test): Likewise.
1533         * unittests/optional/in_place.cc (test): Likewise.
1534         * unittests/optional/observers/1.cc (test): Likewise.
1535         * unittests/optional/observers/2.cc (test): Likewise.
1536
1537 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1538
1539         * tui-win.h (tui_set_var_cmd): Remove.
1540         * tui-win.c (tui_set_var_cmd): Make static.
1541
1542 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1543
1544         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1545         rbreak_command_wrapper): Remove.
1546         * symtab.c (rbreak_command_wrapper): Remove.
1547
1548 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1549
1550         * inferior.h (info_terminal_command): Remove declaration.
1551         * inflow.c (info_terminal_command): Make static.
1552
1553 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1554
1555         * inferior.c (exit_inferior_silent): Remove.
1556
1557 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1558
1559         * dictionary.c (dict_empty, mdict_empty): Remove.
1560         * dictionary.c (mdict_empty): Remove.
1561
1562 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1563
1564          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1565          (arc_insn_get_memory_offset): Likewise.
1566          (arc_insn_dump): Likewise.
1567          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1568          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1569          * dictionary.c (dict_iterator_next): Likewise.
1570          (dict_iter_match_first): Likewise.
1571          (dict_iter_match_next): Likewise.
1572          * f-lang.c (evaluate_subexp_f): Likewise.
1573          * hppa-tdep.c (hppa_read_pc): Likewise.
1574          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1575          * parse.c (write_exp_elt_msym): Likewise.
1576          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1577          * remote.c (remote_packet_size): Likewise.
1578          (remote_notif_stop_parse): Likewise.
1579          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1580          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1581          * source.c (prepare_path_for_appending): Likewise.
1582          * sparc64-linux-tdep.c
1583          (sparc64_linux_handle_segmentation_fault); Likewise.
1584          * stack.c (frame_selection_by_function_completer): Likewise.
1585
1586 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1587
1588         * completer.c (set_gdb_completion_word_break_characters):
1589         Remove.
1590
1591 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1592
1593         * dwarf-index-write.c: Include dwarf-index-write.h.
1594         * mi/mi-interp.c: Include mi/mi-interp.h.
1595
1596 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1597
1598         * aarch32-tdep.c: Include aarch32-tdep.h.
1599         * aarch32-tdep.h: Forward-declare struct target_desc.
1600
1601 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1602
1603         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1604         strerror.
1605         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1606         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1607
1608 2019-11-25  Tom de Vries  <tdevries@suse.de>
1609
1610         * contrib/words.sh: Add -c option.
1611
1612 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1613
1614         * solib.c (solib_find_1): Change int to bool.
1615         (exec_file_find): Change int to bool.
1616         (solib_find): Change int to bool.
1617         (solib_read_symbols): Change int to bool.
1618         (solib_used): Change int to bool.
1619         (solib_add): Change int to bool.
1620         (info_sharedlibrary_command): Change int to bool.
1621         (solib_contains_address_p): Change int to bool.
1622         (solib_keep_data_in_core): Change int to bool.
1623         (in_solib_dynsym_resolve_code): Change int to bool.
1624         (reload_shared_libraries_1): Change int to bool.
1625         (gdb_sysroot_changed): Change int to bool.
1626         * solib.h (solib_read_symbols): Change int to bool.
1627         (solib_contains_address_p): Change int to bool.
1628         (solib_keep_data_in_core): Change int to bool.
1629         (in_solib_dynsym_resolve_code): Change int to bool.
1630         (libpthread_name_p): Change int to bool.
1631
1632 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1633
1634         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1635         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1636         (remote_packet_max_chars): New static global.
1637         (show_remote_packet_max_chars): New function.
1638         (remote_target::putpkt_binary): Adjust to use new
1639         remote_packet_max_chars option.
1640         (remote_target::getpkt_or_notif_sane_1): Likewise.
1641         (_initialize_remote): Register new remote-packet-max-chars option.
1642
1643 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1644
1645         * m68k-linux-nat.c: Include gdbarch.h.
1646
1647 2019-11-24  Tom Tromey  <tom@tromey.com>
1648
1649         * symfile.c (read_symbols): Update.
1650         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1651         bool.
1652         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1653         (psym_lookup_symbol, psym_find_last_source_symtab)
1654         (psym_forget_cached_source_info, psym_print_stats)
1655         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1656         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1657         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1658         (psym_find_compunit_symtab_by_address)
1659         (maintenance_print_psymbols, maintenance_info_psymtabs)
1660         (maintenance_check_psymtabs): Update.
1661         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1662         bool.
1663
1664 2019-11-22  Tom Tromey  <tom@tromey.com>
1665
1666         * observable.h: Update comments.
1667
1668 2019-11-22  Tom Tromey  <tromey@adacore.com>
1669
1670         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1671         (print_ada_task_info): Don't try to fetch thread id if task is not
1672         alive.
1673
1674 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1675
1676         * ada-exp.y: Update.
1677         * ada-lang.c (sort_choices): Update.
1678         (ada_print_symbol_signature): Update.
1679         (resolve_subexp): Update.
1680         (ada_parse_renaming): Update.
1681         (ada_read_renaming_var_value): Update.
1682         (lesseq_defined_than): Update.
1683         (remove_extra_symbols): Update.
1684         (remove_irrelevant_renamings): Update.
1685         (ada_add_block_symbols): Update.
1686         (ada_collect_symbol_completion_matches): Update.
1687         (ada_is_renaming_symbol): Update.
1688         (aggregate_assign_from_choices): Update.
1689         (ada_evaluate_subexp): Update.
1690         (ada_has_this_exception_support): Update.
1691         (ada_is_non_standard_exception_sym): Update.
1692         (ada_add_exceptions_from_frame): Update.
1693         (ada_add_global_exceptions): Update.
1694         (ada_print_subexp): Update.
1695         * ax-gdb.c (gen_var_ref): Update.
1696         (gen_maybe_namespace_elt): Update.
1697         (gen_expr_for_cast): Update.
1698         (gen_expr): Update.
1699         * block.h: Update.
1700         * blockframe.c (find_pc_partial_function): Update.
1701         * breakpoint.c (print_breakpoint_location): Update.
1702         (update_static_tracepoint): Update.
1703         * btrace.c (ftrace_print_function_name): Update.
1704         (ftrace_function_switched): Update.
1705         * buildsym.c (find_symbol_in_list): Update.
1706         * c-exp.y: Update.
1707         * c-typeprint.c (c_print_typedef): Update.
1708         (c_type_print_template_args): Update.
1709         * cli/cli-cmds.c (edit_command): Update.
1710         (list_command): Update.
1711         (print_sal_location): Update.
1712         * coffread.c (patch_opaque_types): Update.
1713         (process_coff_symbol): Update.
1714         (coff_read_enum_type): Update.
1715         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1716         (convert_one_symbol): Update.
1717         (hash_symname): Update.
1718         (eq_symname): Update.
1719         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1720         * compile/compile-cplus-types.c (debug_print_scope): Update.
1721         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1722         * compile/compile-object-load.c (get_out_value_type): Update.
1723         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1724         (search_symbol_list): Update.
1725         (cp_lookup_symbol_imports_or_template): Update.
1726         * cp-support.c (overload_list_add_symbol): Update.
1727         * ctfread.c (psymtab_to_symtab): Update.
1728         * dbxread.c (cp_set_block_scope): Update.
1729         * dictionary.c (iter_match_first_hashed): Update.
1730         (iter_match_next_hashed): Update.
1731         (insert_symbol_hashed): Update.
1732         (iter_match_next_linear): Update.
1733         * dictionary.h: Update.
1734         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1735         (locexpr_describe_location_piece): Update.
1736         (locexpr_describe_location_1): Update.
1737         (locexpr_generate_c_location): Update.
1738         (loclist_describe_location): Update.
1739         (loclist_generate_c_location): Update.
1740         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1741         (read_func_scope): Update.
1742         (process_enumeration_scope): Update.
1743         (new_symbol): Update.
1744         (dwarf2_const_value): Update.
1745         (dwarf2_symbol_mark_computed): Update.
1746         * eval.c (evaluate_funcall): Update.
1747         (evaluate_subexp_standard): Update.
1748         * expprint.c (print_subexp_standard): Update.
1749         (dump_subexp_body_standard): Update.
1750         * f-valprint.c (info_common_command_for_block): Update.
1751         * findvar.c (get_hosting_frame): Update.
1752         (default_read_var_value): Update.
1753         * go-lang.c (go_symbol_package_name): Update.
1754         * guile/scm-block.c (bkscm_print_block_smob): Update.
1755         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1756         (gdbscm_symbol_name): Update.
1757         (gdbscm_symbol_linkage_name): Update.
1758         (gdbscm_symbol_print_name): Update.
1759         * infcall.c (get_function_name): Update.
1760         * infcmd.c (jump_command): Update.
1761         (finish_command): Update.
1762         * infrun.c (insert_exception_resume_breakpoint): Update.
1763         * linespec.c (canonicalize_linespec): Update.
1764         (create_sals_line_offset): Update.
1765         (convert_linespec_to_sals): Update.
1766         (complete_label): Update.
1767         (find_label_symbols_in_block): Update.
1768         * m2-typeprint.c (m2_print_typedef): Update.
1769         * mdebugread.c (mdebug_reg_to_regnum): Update.
1770         (parse_symbol): Update.
1771         (mylookup_symbol): Update.
1772         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1773         (list_args_or_locals): Update.
1774         * objc-lang.c (compare_selectors): Update.
1775         (info_selectors_command): Update.
1776         (compare_classes): Update.
1777         (info_classes_command): Update.
1778         (find_imps): Update.
1779         * p-typeprint.c (pascal_print_typedef): Update.
1780         * printcmd.c (build_address_symbolic): Update.
1781         (info_address_command): Update.
1782         (print_variable_and_value): Update.
1783         * python/py-framefilter.c (extract_sym): Update.
1784         (py_print_single_arg): Update.
1785         * python/py-symbol.c (sympy_str): Update.
1786         (sympy_get_name): Update.
1787         (sympy_get_linkage_name): Update.
1788         * python/python.c (gdbpy_rbreak): Update.
1789         * record-btrace.c (btrace_get_bfun_name): Update.
1790         (btrace_call_history): Update.
1791         * rust-lang.c (rust_print_typedef): Update.
1792         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1793         * stabsread.c (stab_reg_to_regnum): Update.
1794         (define_symbol): Update.
1795         (read_enum_type): Update.
1796         (common_block_end): Update.
1797         (cleanup_undefined_types_1): Update.
1798         (scan_file_globals): Update.
1799         * stack.c (print_frame_arg): Update.
1800         (print_frame_args): Update.
1801         (find_frame_funname): Update.
1802         (info_frame_command_core): Update.
1803         (iterate_over_block_locals): Update.
1804         (print_block_frame_labels): Update.
1805         (do_print_variable_and_value): Update.
1806         (iterate_over_block_arg_vars): Update.
1807         (return_command): Update.
1808         * symmisc.c (dump_symtab_1): Update.
1809         (print_symbol): Update.
1810         * symtab.c (eq_symbol_entry): Update.
1811         (symbol_cache_dump): Update.
1812         (lookup_language_this): Update.
1813         (find_pc_sect_line): Update.
1814         (skip_prologue_sal): Update.
1815         (symbol_search::compare_search_syms): Update.
1816         (treg_matches_sym_type_name): Update.
1817         (search_symbols): Update.
1818         (print_symbol_info): Update.
1819         (rbreak_command): Update.
1820         (completion_list_add_symbol): Update.
1821         (find_gnu_ifunc): Update.
1822         (get_symbol_address): Update.
1823         (search_module_symbols): Update.
1824         (info_module_subcommand): Update.
1825         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1826         (SYMBOL_LINKAGE_NAME): Remove.
1827         (SYMBOL_DEMANGLED_NAME): Remove.
1828         (SYMBOL_PRINT_NAME): Remove.
1829         (SYMBOL_SEARCH_NAME): Remove.
1830         * tracepoint.c (set_traceframe_context): Update.
1831         (validate_actionline): Update.
1832         (collection_list::collect_symbol): Update.
1833         (encode_actions_1): Update.
1834         (info_scope_command): Update.
1835         (print_one_static_tracepoint_marker): Update.
1836         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1837         * valops.c (address_of_variable): Update.
1838         (find_overload_match): Update.
1839         (find_oload_champ): Update.
1840
1841 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1842
1843         * ada-lang.c (ada_lookup_simple_minsym): Update.
1844         (ada_collect_symbol_completion_matches): Update.
1845         * ada-tasks.c (read_atcb): Update.
1846         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1847         (amd64_windows_skip_trampoline_code): Update.
1848         * arm-tdep.c (skip_prologue_function): Update.
1849         (arm_skip_stack_protector): Update.
1850         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1851         (arm_wince_skip_main_prologue): Update.
1852         * ax-gdb.c (gen_expr): Update.
1853         * block.c (call_site_for_pc): Update.
1854         * blockframe.c (find_pc_partial_function): Update.
1855         * breakpoint.c (set_breakpoint_location_function): Update.
1856         * btrace.c (ftrace_print_function_name): Update.
1857         (ftrace_function_switched): Update.
1858         * c-valprint.c (print_unpacked_pointer): Update.
1859         * coffread.c (coff_symfile_read): Update.
1860         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1861         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1862         * dwarf-index-write.c (write_psymbols): Update.
1863         * dwarf2loc.c (call_site_to_target_addr): Update.
1864         (func_verify_no_selftailcall): Update.
1865         (tailcall_dump): Update.
1866         (call_site_find_chain_1): Update.
1867         (dwarf_expr_reg_to_entry_parameter): Update.
1868         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1869         * eval.c (evaluate_funcall): Update.
1870         (evaluate_subexp_standard): Update.
1871         (evaluate_subexp_for_sizeof): Update.
1872         * expprint.c (print_subexp_standard): Update.
1873         (dump_subexp_body_standard): Update.
1874         * frame.c (get_prev_frame_always_1): Update.
1875         * frv-tdep.c (frv_skip_main_prologue): Update.
1876         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1877         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1878         (gnuv3_get_typename_from_type_info): Update.
1879         (gnuv3_skip_trampoline): Update.
1880         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1881         * i386-tdep.c (i386_skip_main_prologue): Update.
1882         (i386_pe_skip_trampoline_code): Update.
1883         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1884         * infcall.c (get_function_name): Update.
1885         * linespec.c (minsym_found): Update.
1886         * linux-fork.c (info_checkpoints_command): Update.
1887         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1888         (m32c_m16c_pointer_to_address): Update.
1889         * maint.c (maintenance_translate_address): Update.
1890         * minsyms.c (add_minsym_to_hash_table): Update.
1891         (add_minsym_to_demangled_hash_table): Update.
1892         (lookup_minimal_symbol_mangled): Update.
1893         (lookup_minimal_symbol_demangled): Update.
1894         (lookup_minimal_symbol_linkage): Update.
1895         (lookup_minimal_symbol_text): Update.
1896         (lookup_minimal_symbol_by_pc_name): Update.
1897         (minimal_symbol_is_less_than): Update.
1898         (compact_minimal_symbols): Update.
1899         (build_minimal_symbol_hash_tables): Update.
1900         (find_solib_trampoline_target): Update.
1901         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1902         (mips_skip_pic_trampoline_code): Update.
1903         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1904         * objc-lang.c (info_selectors_command): Update.
1905         (info_classes_command): Update.
1906         (find_methods): Update.
1907         (find_imps): Update.
1908         * p-valprint.c (pascal_val_print): Update.
1909         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1910         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1911         * printcmd.c (build_address_symbolic): Update.
1912         (info_symbol_command): Update.
1913         * psymtab.c (psymbol_name_matches): Update.
1914         (match_partial_symbol): Update.
1915         (lookup_partial_symbol): Update.
1916         (print_partial_symbols): Update.
1917         (sort_pst_symbols): Update.
1918         (maintenance_check_psymtabs): Update.
1919         * python/py-framefilter.c (py_print_frame): Update.
1920         * python/python.c (gdbpy_rbreak): Update.
1921         * record-btrace.c (btrace_get_bfun_name): Update.
1922         (btrace_call_history): Update.
1923         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1924         (rs6000_skip_trampoline_code): Update.
1925         * sol-thread.c (info_cb): Update.
1926         * stabsread.c (scan_file_globals): Update.
1927         * stack.c (find_frame_funname): Update.
1928         (info_frame_command_core): Update.
1929         * symmisc.c (dump_msymbols): Update.
1930         * symtab.c (symbol_natural_name): Rename to..,
1931         (general_symbol_info::natural_name): ...this.
1932         (symbol_demangled_name): Rename to...
1933         (general_symbol_info::demangled_name): ...this.
1934         (symbol_search_name): Rename to...
1935         (general_symbol_info::search_name): ...this.
1936         (symbol_matches_search_name): Update.
1937         (find_pc_sect_line): Update.
1938         (skip_prologue_sal): Update.
1939         (search_symbols): Update.
1940         (print_msymbol_info): Update.
1941         (rbreak_command): Update.
1942         (completion_list_add_msymbol): Update.
1943         (completion_list_objc_symbol): Update.
1944         (get_msymbol_address): Update.
1945         * symtab.h (struct general_symbol_info): Add member functions
1946         natural_name (), linkage_name (), print_name (), demangled_name (),
1947         and search_name ().
1948         (SYMBOL_NATURAL_NAME): Update.
1949         (symbol_natural_name): Move to a member function on general_symbol_info.
1950         (SYMBOL_DEMANGLED_NAME): Update.
1951         (symbol_demangled_name): Move to a member function on
1952         general_symbol_info.
1953         (SYMBOL_SEARCH_NAME): Update.
1954         (symbol_search_name): Move to a member function on general_symbol_info.
1955         (MSYMBOL_NATURAL_NAME): Remove.
1956         (MSYMBOL_LINKAGE_NAME): Remove.
1957         (MSYMBOL_PRINT_NAME): Remove.
1958         (MSYMBOL_DEMANGLED_NAME): Remove.
1959         (MSYMBOL_SEARCH_NAME): Remove.
1960         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1961
1962 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1963
1964         * symtab.c (create_demangled_names_hash): Use per_bfd->
1965         minimal_symbol_count for computing the initial size, if greater
1966         than our default size.
1967
1968 2019-11-22  Tom de Vries  <tdevries@suse.de>
1969
1970         * contrib/words.sh: Improve words extraction.
1971
1972 2019-11-22  Tom de Vries  <tdevries@suse.de>
1973
1974         * contrib/words.sh: Combine sed invocations.
1975
1976 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1977
1978         * Makefile.in: Update.
1979         * demangle.c: Rename to...
1980         * gdb-demangle.c: ..this.
1981         (is_cplus_marker): Change return type to bool.
1982         (_initialize_demangler): Rename to...
1983         (_initialize_gdb_demangle): ...this.
1984         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1985         * symtab.h (demangle): Remove declaration; instead include
1986         gdb-demangle.h.
1987
1988 2019-11-21  Tom Tromey  <tromey@adacore.com>
1989
1990         * gdbsupport/format.c (format_pieces): Parse %I64d.
1991         * unittests/format_pieces-selftests.c (test_windows_formats): New
1992         function.
1993         (run_tests): Call it.
1994
1995 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1996
1997         Byte reverse display of variables with DW_END_big, DW_END_little
1998         (DW_AT_endianity) dwarf attributes if different than the native
1999         byte order.
2000         * ada-lang.c (ada_value_binop):
2001         Use type_byte_order instead of gdbarch_byte_order.
2002         * ada-valprint.c (printstr):
2003         (ada_val_print_string):
2004         * ada-lang.c (value_pointer):
2005         (ada_value_binop):
2006         Use type_byte_order instead of gdbarch_byte_order.
2007         * c-lang.c (c_get_string):
2008         Use type_byte_order instead of gdbarch_byte_order.
2009         * c-valprint.c (c_val_print_array):
2010         Use type_byte_order instead of gdbarch_byte_order.
2011         * cp-valprint.c (cp_print_class_member):
2012         Use type_byte_order instead of gdbarch_byte_order.
2013         * dwarf2loc.c (rw_pieced_value):
2014         Use type_byte_order instead of gdbarch_byte_order.
2015         * dwarf2read.c (read_base_type): Handle DW_END_big,
2016         DW_END_little
2017         * f-lang.c (f_get_encoding):
2018         Use type_byte_order instead of gdbarch_byte_order.
2019         * findvar.c (default_read_var_value):
2020         Use type_byte_order instead of gdbarch_byte_order.
2021         * gdbtypes.c (check_types_equal):
2022         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
2023         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
2024         and TYPE_ENDIANITY_LITTLE if set.
2025         (type_byte_order): new function.
2026         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
2027         (struct main_type) <flag_endianity_not_default>:
2028         New field.
2029         (type_byte_order): New function.
2030         * infcmd.c (default_print_one_register_info):
2031         Use type_byte_order instead of gdbarch_byte_order.
2032         * p-lang.c (pascal_printstr):
2033         Use type_byte_order instead of gdbarch_byte_order.
2034         * p-valprint.c (pascal_val_print):
2035         Use type_byte_order instead of gdbarch_byte_order.
2036         * printcmd.c (print_scalar_formatted):
2037         Use type_byte_order instead of gdbarch_byte_order.
2038         * solib-darwin.c (darwin_current_sos):
2039         Use type_byte_order instead of gdbarch_byte_order.
2040         * solib-svr4.c (solib_svr4_r_ldsomap):
2041         Use type_byte_order instead of gdbarch_byte_order.
2042         * stap-probe.c (stap_modify_semaphore):
2043         Use type_byte_order instead of gdbarch_byte_order.
2044         * target-float.c (target_float_same_format_p):
2045         Use type_byte_order instead of gdbarch_byte_order.
2046         * valarith.c (scalar_binop):
2047         (value_bit_index):
2048         Use type_byte_order instead of gdbarch_byte_order.
2049         * valops.c (value_cast):
2050         Use type_byte_order instead of gdbarch_byte_order.
2051         * valprint.c (generic_emit_char):
2052         (generic_printstr):
2053         (val_print_string):
2054         Use type_byte_order instead of gdbarch_byte_order.
2055         * value.c (unpack_long):
2056         (unpack_bits_as_long):
2057         (unpack_value_bitfield):
2058         (modify_field):
2059         (pack_long):
2060         (pack_unsigned_long):
2061         Use type_byte_order instead of gdbarch_byte_order.
2062         * findvar.c (unsigned_pointer_to_address):
2063         (signed_pointer_to_address):
2064         (unsigned_address_to_pointer):
2065         (address_to_signed_pointer):
2066         (default_read_var_value):
2067         (default_value_from_register):
2068         Use type_byte_order instead of gdbarch_byte_order.
2069         * gnu-v3-abi.c (gnuv3_make_method_ptr):
2070         Use type_byte_order instead of gdbarch_byte_order.
2071         * riscv-tdep.c (riscv_print_one_register_info):
2072         Use type_byte_order instead of gdbarch_byte_order.
2073
2074 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
2075
2076         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
2077         (current_ui_gdb_stdin_ptr): Likewise.
2078         (current_ui_gdb_stderr_ptr): Likewise.
2079         (current_ui_gdb_stdlog_ptr): Likewise.
2080         (current_ui_current_uiout_ptr): Likewise.
2081         (gen_ret_current_ui_field_ptr): Remove.
2082
2083 2019-11-21  Tom de Vries  <tdevries@suse.de>
2084
2085         PR gdb/24956
2086         * cli/cli-script.c (execute_control_command): Only switch to
2087         INTERP_CONSOLE's ui_out when INTERP_MI is active.
2088
2089 2019-11-19  Tom Tromey  <tom@tromey.com>
2090
2091         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2092         Now static.  Change type of "name".
2093         (tui_set_win_height_command): Don't copy "arg".
2094         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2095         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2096
2097 2019-11-19  Ali Tamur <tamur@google.com>
2098
2099         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2100         "if (attr != nullptr)".
2101         (dwarf2_find_base_address): Likewise.
2102         (dwarf2_build_include_psymtabs): Likewise.
2103         (read_cutu_die_from_dwo): Likewise.
2104         (read_func_scope): Likewise.
2105         (read_call_site_scope): Likewise.
2106         (dwarf2_get_pc_bounds): Likewise.
2107         (dwarf2_record_block_ranges): Likewise.
2108         (dwarf2_add_field): Likewise.
2109         (dwarf2_add_member_fn): Likewise.
2110         (read_structure_type): Likewise.
2111         (read_enumeration_type): Likewise.
2112         (read_array_type): Likewise.
2113         (read_array_order): Likewise.
2114         (read_set_type): Likewise.
2115         (read_common_block): Likewise.
2116         (read_tag_reference_type): Likewise.
2117         (read_tag_string_type): Likewise.
2118         (read_subroutine_type): Likewise.
2119         (read_base_type): Likewise.
2120         (read_subrange_type): Likewise.
2121         (new_symbol): Likewise.
2122         (prepare_one_comp_unit): Likewise.
2123
2124 2019-11-19  Tom Tromey  <tromey@adacore.com>
2125
2126         * windows-nat.c (windows_nat_target::attach): Include GetLastError
2127         result in error when DebugActiveProcess fails.
2128
2129 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
2130             Pedro Alves  <palves@redhat.com>
2131
2132         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2133         * target.c (target_stack::push): Call 'unpush' if there's a
2134         target on top of the stack.
2135
2136 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2137
2138         * python/py-block.c (blpy_dealloc): Call tp_free.
2139         (blpy_block_syms_dealloc): Likewise.
2140         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2141         * python/py-inferior.c (infpy_dealloc): Likewise.
2142         * python/py-lazy-string.c (stpy_dealloc): Likewise.
2143         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2144         * python/py-symbol.c (sympy_dealloc): Likewise.
2145         * python/py-symtab.c (stpy_dealloc): Likewise.
2146         * python/py-type.c (typy_iterator_dealloc): Likewise.
2147
2148 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
2149
2150         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2151         constructor instead of using a class initializer.
2152
2153 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2154
2155         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2156         * configure: Regenerate.
2157         * configure.ac: Don't source common.host.
2158         * gdbsupport/common.host: Remove.
2159         * gdbsupport/mingw-strerror.c: Remove.
2160         * gdbsupport/posix-strerror.c: Rename to...
2161         * gdbsupport/safe-strerror.c: ...this.
2162
2163 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2164
2165         * maint.c (scoped_command_stats::print_time): Use localtime_r
2166         instead of localtime (provided through gnulib if necessary).
2167         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2168         of ctime.
2169
2170 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2171
2172         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2173         avoid compile errors.
2174
2175 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2176
2177         * config.in: Regenerate.
2178         * configure: Regenerate.
2179         * gdbsupport/common.m4: No longer check for strerror_r.
2180         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2181         POSIX version of strerror_r, now that gnulib provides it if
2182         necessary.
2183
2184 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
2185
2186         * README (`configure' options): Update.
2187
2188 2019-11-14  Tom Tromey  <tromey@adacore.com>
2189
2190         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2191         expected type for the RHS if the LHS is a convenience variable.
2192
2193 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
2194
2195         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2196         Provide explicit default and copy constructor.
2197
2198 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2199
2200         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2201         only call Py_INCREF (newbp) in the bppy_pending_object case.
2202
2203 2019-11-13  Tom Tromey  <tromey@adacore.com>
2204
2205         PR build/25182:
2206         * psympriv.h (partial_symbol): Remove static assert.
2207         * symtab.h (general_symbol_info, symbol): Remove static assert.
2208
2209 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2210
2211         * gdbsupport/format.c (format_pieces::format_pieces): Support
2212         printf 'z' size modifier.
2213         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2214         * printcmd.c (ui_printf):  Handle size_t_arg.
2215         * ui-out.c (ui_out::vmessage): Likewise.
2216         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2217         function.
2218         (run_tests): Call test_format_int_sizes.
2219
2220 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2221
2222         * ada-exp.y (write_ambiguous_var): Update.
2223         * buildsym.c (add_symbol_to_list): Update.
2224         * dwarf2read.c (read_variable): Update.
2225         (new_symbol): Update.
2226         * jit.c (finalize_symtab): Update.
2227         * language.c (language_alloc_type_symbol): Update.
2228         * symtab.c (fixup_symbol_section): Update.
2229         (initialize_objfile_symbol_1): Move code to...
2230         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2231         (allocate_symbol): Update.
2232         (allocate_template_symbol): Update.
2233         (get_symbol_address): Update.
2234         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2235         of having as a field, and add a constructor.
2236         (SYMBOL_VALUE): Update.
2237         (SYMBOL_VALUE_ADDRESS): Update.
2238         (SET_SYMBOL_VALUE_ADDRESS): Update.
2239         (SYMBOL_VALUE_BYTES): Update.
2240         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2241         (SYMBOL_BLOCK_VALUE): Update.
2242         (SYMBOL_VALUE_CHAIN): Update.
2243         (SYMBOL_LANGUAGE): Update.
2244         (SYMBOL_SECTION): Update.
2245         (SYMBOL_OBJ_SECTION): Update.
2246         (SYMBOL_SET_LANGUAGE): Update.
2247         (SYMBOL_SET_LINKAGE_NAME): Update.
2248         (SYMBOL_SET_NAMES): Update.
2249         (SYMBOL_NATURAL_NAME): Update.
2250         (SYMBOL_LINKAGE_NAME): Update.
2251         (SYMBOL_DEMANGLED_NAME): Update.
2252         (SYMBOL_SEARCH_NAME): Update.
2253         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2254         (struct symbol): Update.
2255         (struct template_symbol): Update.
2256         (struct rust_vtable_symbol): Update.
2257         * xcoffread.c (SYMBOL_DUP): Update.
2258
2259 2019-11-12  Tom Tromey  <tom@tromey.com>
2260
2261         * tui/tui-layout.c (show_layout): Set current_layout.
2262         (show_source_disasm_command, show_data)
2263         (show_source_or_disasm_and_command): Don't set current_layout.
2264
2265 2019-11-12  Tom Tromey  <tom@tromey.com>
2266
2267         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2268
2269 2019-11-12  Tom Tromey  <tom@tromey.com>
2270
2271         * tui/tui-win.c (resize_message): New global.
2272         (show_tui_resize_message): New function.
2273         (tui_async_resize_screen): Print message if requested.
2274         (_initialize_tui_win): Add tui-resize-message setting.
2275         * NEWS: Add entry for new commands.
2276
2277 2019-11-11  Tom Tromey  <tom@tromey.com>
2278
2279         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2280         functions.
2281
2282 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2283
2284         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2285
2286 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2287
2288         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2289         function.
2290         * python/python-internal.h (gdbpy_lookup_static_symbols):
2291         Declare new function.
2292         * python/python.c (python_GdbMethods): Add
2293         gdb.lookup_static_symbols method.
2294         * NEWS: Mention gdb.lookup_static_symbols.
2295
2296 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2297
2298         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2299         static block of current object file first.  Also fix typo in
2300         header comment.
2301
2302 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2303
2304         * stack.c (set_last_displayed_sal): Delete.
2305         (last_displayed_sal_valid): Delete.
2306         (last_displayed_pspace): Delete.
2307         (last_displayed_addr): Delete.
2308         (last_displayed_symtab): Delete.
2309         (last_displayed_line): Delete.
2310         (class last_displayed_symtab_info_type): New.
2311         (last_displayed_symtab_info): New static global variable.
2312         (print_frame_info): Call methods on last_displayed_symtab_info.
2313         (clear_last_displayed_sal): Update header comment, and make use of
2314         last_displayed_symtab_info.
2315         (last_displayed_sal_is_valid): Likewise.
2316         (get_last_displayed_pspace): Likewise.
2317         (get_last_displayed_addr): Likewise.
2318         (get_last_displayed_symtab): Likewise.
2319         (get_last_displayed_line): Likewise.
2320         (get_last_displayed_sal): Likewise.
2321         * stack.h (clear_last_displayed_sal): Update header comment.
2322         (last_displayed_sal_is_valid): Likewise.
2323         (get_last_displayed_pspace): Likewise.
2324         (get_last_displayed_addr): Likewise.
2325         (get_last_displayed_symtab): Likewise.
2326         (get_last_displayed_line): Likewise.
2327         (get_last_displayed_sal): Likewise.
2328
2329 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2330
2331         * stack.c (frame_show_address): Convert return type to bool.
2332         * stack.h (frame_show_address): Likewise, and update header
2333         comment.
2334
2335 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2336
2337         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2338         * unittests/vec-utils-selftests.c: New file.
2339         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2340
2341 2019-11-10  Tom Tromey  <tom@tromey.com>
2342
2343         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2344         (tui_highlight_win): Likewise.
2345         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2346         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2347         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2348         Don't set can_highlight.
2349
2350 2019-11-10  Tom Tromey  <tom@tromey.com>
2351
2352         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2353         Remove unused declaration.
2354
2355 2019-11-08  Tom Tromey  <tromey@adacore.com>
2356
2357         * top.c (read_command_file): Update.
2358         (command_line_input): Make return type const.
2359         * python/py-gdb-readline.c: Update.
2360         * linespec.c (decode_line_2): Update.
2361         * defs.h (command_line_input): Make return type const.
2362         * cli/cli-script.c (read_next_line): Make return type const.
2363         * ada-lang.c (get_selections): Update.
2364
2365 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2366
2367         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2368         * mi/mi-main.c (output_cores): Likewise.
2369         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2370         (linux_xfer_osdata_modules): Likewise.
2371         * remote.c (register_remote_support_xml): Likewise.
2372         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2373         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2374
2375 2019-11-06  Tom Tromey  <tom@tromey.com>
2376
2377         * tui/tui-interp.c: Don't include readline.h.
2378         * tui/tui-hooks.c: Don't include readline.h.
2379         * symmisc.c: Include tilde.h, not readline.h.
2380         * symfile.c: Include tilde.h, not readline.h.
2381         * source.c: Include tilde.h, not readline.h.
2382         * solib.c: Include tilde.h, not readline.h.
2383         * psymtab.c: Include tilde.h, not readline.h.
2384         * exec.c: Include tilde.h, not readline.h.
2385         * corelow.c: Include tilde.h, not readline.h.
2386         * cli/cli-dump.c: Include tilde.h, not readline.h.
2387         * cli/cli-cmds.c: Don't include readline.h.
2388
2389 2019-11-05  Tom Tromey  <tom@tromey.com>
2390
2391         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2392         (tui_disassemble): Set addr_size.
2393         (tui_disasm_window::set_contents): Use addr_size.
2394
2395 2019-11-05  Tom Tromey  <tom@tromey.com>
2396
2397         * rust-lang.c (rust_language_defn): Update.
2398         * python/py-value.c (valpy_string): Call c_get_string.
2399         * p-lang.c (pascal_language_defn): Update.
2400         * opencl-lang.c (opencl_language_defn): Update.
2401         * objc-lang.c (objc_language_defn): Update.
2402         * m2-lang.c (m2_language_defn): Update.
2403         * language.c (unknown_language_defn, auto_language_defn): Update.
2404         (default_get_string): Remove.
2405         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2406         * go-lang.c (go_language_defn): Update.
2407         * f-lang.c (f_language_defn): Update.
2408         * d-lang.c (d_language_defn): Update.
2409         * c-lang.c (c_language_defn, cplus_language_defn)
2410         (asm_language_defn, minimal_language_defn): Update.
2411         * ada-lang.c (ada_language_defn): Update.
2412         * language.h (struct language_defn) <la_get_string>: Remove.
2413         (LA_GET_STRING): Remove.
2414         (default_get_string): Don't declare.
2415
2416 2019-11-05  Tom Tromey  <tom@tromey.com>
2417
2418         * tui/tui-source.h (struct tui_source_window): Inline
2419         constructor.  Remove destructor.
2420         <style_changed, m_observable>: Move to superclass.
2421         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2422         (struct tui_source_window_base): Move private members to end.
2423         <style_changed, m_observable>: Move from tui_source_window.
2424         * tui/tui-winsource.c (tui_copy_source_line): Move from
2425         tui-source.c.  Rename from copy_source_line.  Add special handling
2426         for negative line number.
2427         (tui_source_window_base::style_changed): Move from
2428         tui_source_window.
2429         (tui_source_window_base): Register observer.
2430         (~tui_source_window_base): New.
2431         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2432         rename.
2433         (tui_source_window::set_contents): Use tui_copy_source_line.
2434         (tui_source_window::tui_source_window): Move to tui-source.h.
2435         (tui_source_window::~tui_source_window): Remove.
2436         (tui_source_window::style_changed): Move to superclass.
2437         * tui/tui-disasm.c (tui_disassemble): Create string file with
2438         styling, when possible.  Add "addr_size" parameter.
2439         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2440         Don't compute maximum size.
2441         (len_without_escapes): New function
2442
2443 2019-11-05  Tom Tromey  <tom@tromey.com>
2444
2445         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2446         std::string.
2447         * tui/tui-winsource.c (tui_show_source_line): Update.
2448         * tui/tui-source.c (tui_source_window::set_contents): Update.
2449         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2450
2451 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2452
2453         * symtab.h (gdb_static_assert): Put && operator at the beginning
2454         of the line instead of the end.
2455
2456 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2457
2458         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2459         and sizeof (symbol).
2460         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2461
2462 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2463
2464         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2465         * configure.host: Mark *-*-solaris2.10* obsolete.
2466         * configure.tgt: Mark Solaris < 11 obsolete.
2467         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2468         Update target triplet.
2469
2470 2019-11-01  Tom Tromey  <tromey@adacore.com>
2471
2472         * utils.c (print_sys_errmsg): Simplify.
2473
2474 2019-11-01  Tom Tromey  <tromey@adacore.com>
2475
2476         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2477
2478 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2479
2480         * configure: Regenerate.
2481         * configure.ac: Remove check for strerror_r.
2482         * gdbsupport/common.m4: Check for strerror_r.
2483
2484 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2485
2486         PR gdb/25124
2487
2488         * arm-tdep.c (arm_per_objfile): Rename to ...
2489         (arm_per_bfd): ... this.
2490         (arm_objfile_data_key): Rename to ...
2491         (arm_bfd_data_key): ... this.
2492         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2493         data.
2494         (arm_record_special_symbol): Likewise.
2495
2496 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2497
2498         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2499         end.
2500         * c-typeprint.c (c_print_typedef): Likewise.
2501         * f-typeprint.c (f_print_typedef): Likewise.
2502         * m2-typeprint.c (m2_print_typedef): Likewise.
2503         * p-typeprint.c (pascal_print_typedef): Likewise.
2504         * rust-lang.c (rust_print_typedef): Likewise.
2505         * symtab.c (print_symbol_info): Print a newline after calling
2506         typedef_print.
2507
2508 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2509
2510         * symtab.c (info_module_cmdlist): New variable.
2511         (info_module_command): New function.
2512         (search_module_symbols): New function.
2513         (info_module_subcommand): New function.
2514         (struct info_modules_var_func_options): New struct.
2515         (info_modules_var_func_options_defs): New variable.
2516         (make_info_modules_var_func_options_def_group): New function.
2517         (info_module_functions_command): New function.
2518         (info_module_variables_command): New function.
2519         (info_module_var_func_command_completer): New function.
2520         (_initialize_symtab): Register new 'info module functions' and
2521         'info module variables' commands.
2522         * symtab.h (typedef symbol_search_in_module): New typedef.
2523         (search_module_symbols): Declare new function.
2524         * NEWS: Mention new commands.
2525
2526 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2527
2528         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2529         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2530         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2531         MODULES_DOMAIN.
2532         (scan_partial_symbols): Only create partial module symbols for non
2533         declarations.
2534         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2535         and MODULES_DOMAIN.
2536         * symtab.c (search_domain_name): Likewise.
2537         (search_symbols): Likewise.
2538         (print_symbol_info): Likewise.
2539         (symtab_symbol_info): Likewise.
2540         (info_modules_command): New function.
2541         (_initialize_symtab): Register 'info modules' command.
2542         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2543         * NEWS: Mention new 'info modules' command.
2544
2545 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2546
2547         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2548         and $_gdb_maint_setting_str.
2549
2550 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2551
2552         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2553         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2554         (str_value_from_setting, gdb_setting_str_internal_fn)
2555         (gdb_maint_setting_str_internal_fn): New functions.
2556         (_initialize_cli_cmds): Define the new convenience functions.
2557         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2558         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2559
2560 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2561
2562         * agent.c (set_can_use_agent): When the setting is turned on,
2563         look up agent symbols if we don't have them yet.
2564         (agent_new_objfile): Don't look up agent symbols when the agent
2565         setting is off.
2566
2567 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2568
2569         * config.in: Regenerate.
2570
2571 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2572
2573         * configure: Regenerate.
2574         * configure.ac: Check for strerror_r.
2575         * gdbsupport/common-utils.h (safe_strerror): Change return value
2576         to const char * and document that this function is now threadsafe.
2577         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2578         thread_local and call strerror_r, if available.
2579         * utils.c (perror_string): Update.
2580         (print_sys_errmsg): Update.
2581
2582 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2583
2584         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2585         objfile_key.
2586         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2587         objfile to fetch per-bfd data.
2588         (arm_find_exidx_entry): Likewise.
2589
2590 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2591
2592         * gdbsupport/agent.c (debug_agent): Change type to bool.
2593         (use_agent): Likewise.
2594         (all_agent_symbols_look_up): Likewise.
2595         (agent_loaded_p): Change return value to bool.
2596         (agent_look_up_symbols): Update.
2597         (agent_capability_check): Change return value to bool.
2598         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2599         (debug_agent): Change type to bool.
2600         (use_agent): Likewise.
2601         (agent_capability_check): Change return value to bool.
2602
2603 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2604
2605         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2606         (build_minimal_symbol_hash_tables): Code to clear the table moved
2607         to clear_minimal_symbol_hash_tables.
2608         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2609         when needed.
2610
2611 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2612
2613         * infcmd.c: Remove includes.
2614         * infrun.c: Remove includes.
2615
2616 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2617
2618         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2619         (grow_vect): Remove declaration.
2620         (ada_type_of_array): Remove declaration.
2621         (ada_update_initial_language): Remove declaration.
2622         (ada_fold_name): Remove declaration.
2623         (ada_fill_in_ada_prototype): Remove declaration.
2624         (user_select_syms): Remove declaration.
2625         (get_selections): Remove declaration.
2626         (ada_tag_type): Remove declaration.
2627         (ada_value_tag): Remove declaration.
2628         (ada_is_others_clause): Remove declaration.
2629         (ada_in_variant): Remove declaration.
2630         (ada_value_struct_elt): Remove declaration.
2631         (ada_attribute_name): Remove declaration.
2632         (ada_system_address_type): Remove declaration.
2633         * ada-lang.c (ada_watch_location_expression): Make static.
2634         (GROW_VECT): Move here from ada-lang.h.
2635         (grow_vect): Make static.
2636         (ada_update_initial_language): Make static.
2637         (ada_fold_name): Make static.
2638         (ada_type_of_array): Make static.
2639         (encoded_ordered_before): Move up.
2640         (sort_choices): Move up.
2641         (print_signatures): Move up.
2642         (ada_print_symbol_signature): Move up.
2643         (get_selections): Move up and make static.
2644         (user_select_syms): Move up and make static.
2645         (ada_value_struct_elt): Move up and make static.
2646         (ada_tag_type): Make static.
2647         (ada_value_tag): Make static.
2648         (ada_is_others_clause): Make static.
2649         (ada_in_variant): Make static.
2650         (ada_attribute_name): Make static.
2651
2652 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2653
2654         * ada-lang.c: Remove includes.
2655         * ada-typeprint.c: Remove includes.
2656         * ada-valprint.c: Remove includes.
2657
2658 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2659
2660         * addrmap.c: Add static assertions of type size, moved from
2661         _initialize_addrmap.
2662         (_initialize_addrmap): Remove.
2663
2664 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2665
2666         * coffread.c (record_minimal_symbol): Update.
2667         (process_coff_symbol): Update.
2668         * dbxread.c (read_dbx_symtab): Update.
2669         * dwarf2read.c (add_partial_symbol): Update.
2670         (fixup_go_packaging): Update.
2671         (load_partial_dies): Update.
2672         (new_symbol): Update.
2673         * elfread.c (record_minimal_symbol): Change signature to use
2674         gdb::string_view instead of name+len.
2675         (elf_symtab_read): Update.
2676         (elf_rel_plt_read): Update.
2677         * mdebugread.c (parse_partial_symbols): Update.
2678         (handle_psymbol_enumerators): Update.
2679         (new_symbol): Update.
2680         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2681         to use gdb::string_view instead of name+len.
2682         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2683         * psympriv.h (add_psymbol_to_list): Likewise.
2684         * psymtab.c (add_psymbol_to_bcache): Likewise.
2685         (add_psymbol_to_list): Likewise.
2686         * stabsread.c (define_symbol): Update.
2687         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2688         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2689         (symbol_set_names): Likewise.
2690         * xcoffread.c (scan_xcoff_symtab): Update.
2691
2692 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2693
2694         * symtab.h (symbol_set_names): Document that copy_name must be
2695         set to true for non-nullterminated strings.
2696         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2697         linkage_name if the entry was not found and we need to demangle.
2698
2699 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2700
2701         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2702         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2703         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2704         * gdbsupport/gdb_binary_search.h: New file.
2705
2706 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2707
2708         * NEWS: Mention new --with-system-gdbinit-dir option.
2709         * config.in: Regenerate.
2710         * configure: Regenerate.
2711         * configure.ac: Add new option --with-system-gdbinit-dir.
2712         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2713         for a ".gdb" suffix.
2714         * main.c (get_init_files): Change system_gdbinit argument to
2715         a vector and return the files in SYSTEM_GDBINIT_DIR in
2716         addition to SYSTEM_GDBINIT.
2717         (captured_main_1): Update.
2718         (print_gdb_help): Update.
2719         * top.c (print_gdb_configuration): Also print the value of
2720         SYSTEM_GDBINIT_DIR.
2721
2722 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2723
2724         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2725         that takes gdb::string_view arguments.
2726
2727 2019-10-26  Tom de Vries  <tdevries@suse.de>
2728
2729         * aarch64-linux-tdep.c: Fix typos in comments.
2730         * aarch64-tdep.c: Same.
2731         * ada-lang.c: Same.
2732         * amd64-nat.c: Same.
2733         * arc-tdep.c: Same.
2734         * arch/aarch64-insn.c: Same.
2735         * block.c: Same.
2736         * breakpoint.h: Same.
2737         * btrace.h: Same.
2738         * c-varobj.c: Same.
2739         * cli/cli-decode.c: Same.
2740         * cli/cli-script.c: Same.
2741         * cli/cli-utils.h: Same.
2742         * coff-pe-read.c: Same.
2743         * coffread.c: Same.
2744         * compile/compile-cplus-symbols.c: Same.
2745         * compile/compile-object-run.c: Same.
2746         * completer.c: Same.
2747         * corelow.c: Same.
2748         * cp-support.c: Same.
2749         * demangle.c: Same.
2750         * dwarf-index-write.c: Same.
2751         * dwarf2-frame.c: Same.
2752         * dwarf2-frame.h: Same.
2753         * eval.c: Same.
2754         * frame-base.h: Same.
2755         * frame.h: Same.
2756         * gdbcmd.h: Same.
2757         * gdbtypes.h: Same.
2758         * gnu-nat.c: Same.
2759         * guile/scm-objfile.c: Same.
2760         * i386-tdep.c: Same.
2761         * i386-tdep.h: Same.
2762         * infcall.c: Same.
2763         * infcall.h: Same.
2764         * linux-nat.c: Same.
2765         * m68k-tdep.c: Same.
2766         * macroexp.c: Same.
2767         * memattr.c: Same.
2768         * mi/mi-cmd-disas.c: Same.
2769         * mi/mi-getopt.h: Same.
2770         * mi/mi-main.c: Same.
2771         * minsyms.c: Same.
2772         * nat/aarch64-sve-linux-sigcontext.h: Same.
2773         * objfiles.h: Same.
2774         * ppc-linux-nat.c: Same.
2775         * ppc-linux-tdep.c: Same.
2776         * ppc-tdep.h: Same.
2777         * progspace.h: Same.
2778         * prologue-value.h: Same.
2779         * python/py-evtregistry.c: Same.
2780         * python/py-instruction.h: Same.
2781         * record-btrace.c: Same.
2782         * record-full.c: Same.
2783         * remote.c: Same.
2784         * rs6000-tdep.c: Same.
2785         * ser-tcp.c: Same.
2786         * sol-thread.c: Same.
2787         * sparc-sol2-tdep.c: Same.
2788         * sparc64-tdep.c: Same.
2789         * stabsread.c: Same.
2790         * symfile.c: Same.
2791         * symtab.h: Same.
2792         * target.c: Same.
2793         * tracepoint.c: Same.
2794         * tui/tui-data.h: Same.
2795         * tui/tui-io.c: Same.
2796         * tui/tui-win.c: Same.
2797         * tui/tui.c: Same.
2798         * unittests/rsp-low-selftests.c: Same.
2799         * user-regs.h: Same.
2800         * utils.c: Same.
2801         * utils.h: Same.
2802         * valarith.c: Same.
2803         * valops.c: Same.
2804         * valprint.c: Same.
2805         * valprint.h: Same.
2806         * value.c: Same.
2807         * value.h: Same.
2808         * varobj.c: Same.
2809         * x86-nat.h: Same.
2810         * xtensa-tdep.c: Same.
2811
2812 2019-10-25  Ali Tamur <tamur@google.com>
2813
2814         * charset.c (find_charset_names): Reflect API change.
2815
2816 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2817
2818         * symtab.c (struct demangled_name_entry): Change demangled name
2819         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2820         part of the struct anymore.
2821         (symbol_set_names): No longer obstack allocate + copy the demangled
2822         name, just store the allocated name from bfd.
2823
2824 2019-10-25  Tom Tromey  <tromey@adacore.com>
2825
2826         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2827         (bsearch_cie_cmp, add_cie): Remove.
2828         (find_cie): Reimplement.
2829         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2830         (dwarf2_build_frame_info): Update.
2831
2832 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2833
2834         PR gdb/25126
2835         * symfile.c (reread_symbols): Call forget_cached_source_info to
2836         clear the stale source cache.
2837
2838 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2839
2840         * configure: Regenerate.
2841         * configure.ac: Remove code that sets python_has_threads.
2842
2843 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2844
2845         * config.in: Regenerate.
2846         * configure: Regenerate.
2847         * configure.ac: Remove the code that uses sed to get the python
2848         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2849
2850 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2851
2852         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2853         error paths.
2854
2855 2019-10-23  Tom Tromey  <tom@tromey.com>
2856
2857         * arc-tdep.c: Remove ".." from include.
2858         * frv-tdep.c: Remove ".." from include.
2859         * lm32-tdep.c: Remove ".." from include.
2860         * microblaze-tdep.c: Remove ".." from include.
2861         * or1k-tdep.h: Remove ".." from include.
2862         * s12z-tdep.c: Remove ".." from include.
2863         * Makefile.in (OPCODES_CFLAGS): Add comment.
2864         (TOP_CFLAGS): New variable.
2865         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2866
2867 2019-10-23  Tom Tromey  <tom@tromey.com>
2868
2869         * Makefile.in (READLINE_DIR): Update.
2870
2871 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2872
2873         * infcall.c (call_function_by_hand_dummy): Fix the function
2874         comment.  And extract out a code section into...
2875         (reserve_stack_space): ...this new function.
2876
2877 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2878
2879         * infcall.c (value_arg_coerce): Remove an unused parameter.
2880         (call_function_by_hand_dummy): Update the call to
2881         'value_arg_coerce'.
2882
2883 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2884
2885         * infcall.c (call_function_by_hand_dummy): Refactor.
2886
2887 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2888
2889         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2890
2891 2019-10-23  Tom Tromey  <tom@tromey.com>
2892
2893         * configure: Rebuild.
2894         * configure.ac: Don't check for sigprocmask.
2895         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2896
2897 2019-10-23  Tom Tromey  <tom@tromey.com>
2898
2899         * configure: Rebuild.
2900         * acinclude.m4: Use m4_include, not sinclude.
2901
2902 2019-10-23  Tom de Vries  <tdevries@suse.de>
2903
2904         PR breakpoints/24687
2905         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2906
2907 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2908
2909         * symtab.c (struct demangled_name_entry) <language>: Change from
2910         bitfield to regular variable.
2911
2912 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2913
2914         * symtab.c (struct demangled_name_entry): Add a constructor.
2915         (free_demangled_name_entry): New function to call the destructor
2916         for demangled_name_entry.
2917         (create_demangled_names_hash): Pass free_demangled_name_entry to
2918         htab_create_alloc.
2919         (symbol_set_names): Call placement new for demangled_name_entry.
2920         * utils.c: No longer include xxhash.h here, now that fast_hash
2921         is inlined in the header.
2922         * utils.h: Instead, include it here.
2923
2924 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2925
2926         * Makefile.in: Link with libxxhash.
2927         * config.in: Regenerate.
2928         * configure: Regenerate.
2929         * configure.ac: Search for libxxhash.
2930         * utils.c (fast_hash): Use xxhash if present.
2931
2932 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2933
2934         * utils.h (fast_hash): New function.
2935         * symtab.c (hash_demangled_name_entry): Call new function
2936         fast_hash.
2937
2938 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2939
2940         * symtab.c (struct demangled_name_entry): Change type of mangled
2941         to gdb::string_view. Also adds a constructor that takes the
2942         mangled name.
2943         (hash_demangled_name_entry): Update.
2944         (eq_demangled_name_entry): Update.
2945         (free_demangled_name_entry): New function to call the destructor
2946         now that this is not a POD anymore.
2947         (create_demangled_names_hash): Pass free_demangled_name_entry to
2948         htab_create_alloc.
2949         (symbol_set_names): Update.
2950
2951 2019-10-21  Ali Tamur  <tamu@google.com>
2952
2953         * dwarf2read.c (dir_index): Change type.
2954         (file_name_index): Likewise.
2955         (line_header::include_dir_at): Change comment and implementation on
2956         whether it is DWARF 5.
2957         (line_header::is_valid_file_index): New function.
2958         (line_header::file_name_at): Change comment and implementation on
2959         whether it is DWARF 5.
2960         (line_header::file_names): Change to private field renamed as
2961         m_file_names and introduce a new accessor method.
2962         (line_header::file_names_size): New method.
2963         (line_header::include_dirs): Change to private field and rename as
2964         m_include_dirs.
2965         (dw2_get_file_names_reader): Define local var at a smaller scope and
2966         reflect API change.
2967         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2968         (process_structure_scope): Likewise.
2969         (line_header::add_include_dir): Change message and reflect renaming.
2970         (line_header::add_file_name): Likewise.
2971         (read_formatted_entries): Handle DW_FORM_data16.
2972         (dwarf_decode_line_header): Fix line header length calculation.
2973         (psymtab_include_file_name): Change comment and API.
2974         (lnp_state_machine::m_file): Update comment and reflect type change.
2975         (lnp_state_machine::record_line): Reflect type change.
2976         (dwarf_decode_lines): Reflect API change.
2977         (file_file_name): Likewise.
2978         (file_full_name): Likewise.
2979
2980 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2981
2982         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2983
2984 2019-10-21  Tom Tromey  <tom@tromey.com>
2985
2986         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2987
2988 2019-10-21  Tom Tromey  <tom@tromey.com>
2989
2990         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2991         NM_H.   Use AC_CONFIG_LINKS.
2992         * configure: Rebuild.
2993         * Makefile.in (NM_H): New variable.
2994         (generated_files): Add NM_H.  Remove gcore.
2995         (nm.h, stamp-nmh): New targets.
2996
2997 2019-10-20  Tom Tromey  <tom@tromey.com>
2998
2999         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
3000         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
3001         obsolete comment.
3002         (put_objfile_before): Now static.
3003
3004 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
3005
3006         * gdbsupport/common-utils.h (startswith): Change return type to
3007         bool.
3008
3009 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
3010
3011         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
3012         * breakpoint.c (bp_locations_compare): Rename to...
3013         (bp_location_is_less_than): ...this, and change to std::sort semantics.
3014         (update_global_location_list): Use std::sort instead of qsort.
3015         * buildsym.c (compare_line_numbers): Rename to...
3016         (lte_is_less_than): ...this, and change to std::sort semantics.
3017         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
3018         instead of qsort.
3019         * disasm.c (compare_lines): Rename to...
3020         (line_is_less_than): ...this, and change to std::sort semantics.
3021         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
3022         of qsort.
3023         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
3024         (fde_is_less_than): ...this, and change to std::sort semantics.
3025         (dwarf2_build_frame_info): Call std::sort instead of qsort.
3026         * mdebugread.c (compare_blocks):
3027         (block_is_less_than): ...this, and change to std::sort semantics.
3028         (sort_blocks): Call std::sort instead of qsort.
3029         * objfiles.c (qsort_cmp): Rename to...
3030         (sort_cmp): ...this, and change to std::sort semantics.
3031         (update_section_map): Call std::sort instead of qsort.
3032         * remote.c (compare_pnums): Remove.
3033         (map_regcache_remote_table): Call std::sort instead of qsort.
3034         * utils.c (compare_positive_ints): Remove.
3035         * utils.h (compare_positive_ints): Remove.
3036         * xcoffread.c (compare_lte): Remove.
3037         (arrange_linetable): Call std::sort instead of qsort.
3038
3039 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
3040
3041         * symfile.c (init_entry_point_info): Fix typo.
3042         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
3043
3044 2019-10-18  Tom de Vries  <tdevries@suse.de>
3045
3046         * aarch64-tdep.c: Fix typos in comments.
3047         * ada-lang.c: Same.
3048         * ada-tasks.c: Same.
3049         * alpha-tdep.c: Same.
3050         * alpha-tdep.h: Same.
3051         * amd64-nat.c: Same.
3052         * amd64-windows-tdep.c: Same.
3053         * arc-tdep.c: Same.
3054         * arc-tdep.h: Same.
3055         * arch-utils.c: Same.
3056         * arm-nbsd-tdep.c: Same.
3057         * arm-tdep.c: Same.
3058         * ax-gdb.c: Same.
3059         * blockframe.c: Same.
3060         * btrace.c: Same.
3061         * c-varobj.c: Same.
3062         * coff-pe-read.c: Same.
3063         * coffread.c: Same.
3064         * cris-tdep.c: Same.
3065         * darwin-nat.c: Same.
3066         * dbxread.c: Same.
3067         * dcache.c: Same.
3068         * disasm.c: Same.
3069         * dtrace-probe.c: Same.
3070         * dwarf-index-write.c: Same.
3071         * dwarf2-frame-tailcall.c: Same.
3072         * dwarf2-frame.c: Same.
3073         * dwarf2read.c: Same.
3074         * eval.c: Same.
3075         * exceptions.c: Same.
3076         * fbsd-tdep.c: Same.
3077         * findvar.c: Same.
3078         * frame.c: Same.
3079         * frv-tdep.c: Same.
3080         * gnu-v3-abi.c: Same.
3081         * go32-nat.c: Same.
3082         * h8300-tdep.c: Same.
3083         * hppa-tdep.c: Same.
3084         * i386-linux-tdep.c: Same.
3085         * i386-tdep.c: Same.
3086         * ia64-libunwind-tdep.c: Same.
3087         * ia64-tdep.c: Same.
3088         * infcmd.c: Same.
3089         * infrun.c: Same.
3090         * linespec.c: Same.
3091         * linux-nat.c: Same.
3092         * linux-thread-db.c: Same.
3093         * machoread.c: Same.
3094         * mdebugread.c: Same.
3095         * mep-tdep.c: Same.
3096         * mn10300-tdep.c: Same.
3097         * namespace.c: Same.
3098         * objfiles.c: Same.
3099         * opencl-lang.c: Same.
3100         * or1k-tdep.c: Same.
3101         * osabi.c: Same.
3102         * ppc-linux-nat.c: Same.
3103         * ppc-linux-tdep.c: Same.
3104         * ppc-sysv-tdep.c: Same.
3105         * printcmd.c: Same.
3106         * procfs.c: Same.
3107         * record-btrace.c: Same.
3108         * record-full.c: Same.
3109         * remote-fileio.c: Same.
3110         * remote.c: Same.
3111         * rs6000-tdep.c: Same.
3112         * s12z-tdep.c: Same.
3113         * score-tdep.c: Same.
3114         * ser-base.c: Same.
3115         * ser-go32.c: Same.
3116         * skip.c: Same.
3117         * sol-thread.c: Same.
3118         * solib-svr4.c: Same.
3119         * solib.c: Same.
3120         * source.c: Same.
3121         * sparc-nat.c: Same.
3122         * sparc-sol2-tdep.c: Same.
3123         * sparc-tdep.c: Same.
3124         * sparc64-tdep.c: Same.
3125         * stabsread.c: Same.
3126         * stack.c: Same.
3127         * symfile.c: Same.
3128         * symtab.c: Same.
3129         * target-descriptions.c: Same.
3130         * target-float.c: Same.
3131         * thread.c: Same.
3132         * utils.c: Same.
3133         * valops.c: Same.
3134         * valprint.c: Same.
3135         * value.c: Same.
3136         * varobj.c: Same.
3137         * windows-nat.c: Same.
3138         * xcoffread.c: Same.
3139         * xstormy16-tdep.c: Same.
3140         * xtensa-tdep.c: Same.
3141
3142 2019-10-17  Tom Tromey  <tromey@adacore.com>
3143
3144         * configure: Rebuild.
3145         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
3146         in AC_CONFIG_FILES invocation.
3147         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3148         new-style config.status invocation.
3149
3150 2019-10-17  Tom de Vries  <tdevries@suse.de>
3151
3152         * arm-nbsd-nat.c: Fix typos in comments.
3153         * arm-tdep.c: Same.
3154         * darwin-nat-info.c: Same.
3155         * dwarf2read.c: Same.
3156         * elfread.c: Same.
3157         * event-top.c: Same.
3158         * findvar.c: Same.
3159         * gdbtypes.c: Same.
3160         * hppa-tdep.c: Same.
3161         * i386-tdep.c: Same.
3162         * jit.c: Same.
3163         * main.c: Same.
3164         * mdebugread.c: Same.
3165         * moxie-tdep.c: Same.
3166         * nto-procfs.c: Same.
3167         * osabi.c: Same.
3168         * ppc-linux-tdep.c: Same.
3169         * remote.c: Same.
3170         * riscv-tdep.c: Same.
3171         * s390-tdep.c: Same.
3172         * sh-tdep.c: Same.
3173         * sparc-linux-tdep.c: Same.
3174         * sparc-nat.c: Same.
3175         * stack.c: Same.
3176         * target-descriptions.c: Same.
3177         * top.c: Same.
3178         * varobj.c: Same.
3179
3180 2019-10-16  Tom Tromey  <tom@tromey.com>
3181
3182         * objfiles.h (struct objfile) <original_name>: Now const.
3183
3184 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3185
3186         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3187         pass on to sigsetjmp's second argument.
3188         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3189
3190 2019-10-16  Keith Seitz  <keiths@redhat.com>
3191
3192         PR gdb/23567
3193         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3194         sections whose size is greater than the file size.
3195
3196 2019-10-16  Jim Wilson  <jimw@sifive.com>
3197
3198         * riscv-tdep.c (riscv_gcc_target_options): New.
3199         (riscv_gnu_triplet_regexp): New.
3200         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3201         set_gdbarch_gnu_triplet_regexp.
3202
3203 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3204
3205         * Makefile.in: Add xml-builtin.h.
3206         * features/feature_to_c.sh: Add an include for xml-builtin.h
3207         to ensure that the compiler checks that the types match.
3208         * xml-builtin.h: New file.
3209         * xml-support.c (fetch_xml_builtin): Add missing const.
3210         * xml-support.h: Remove declaration of xml_builtins.
3211
3212 2019-10-16  Tom de Vries  <tdevries@suse.de>
3213
3214         PR tdep/25096
3215         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3216         (amd64_classify_aggregate): ... here.
3217         (amd64_classify_aggregate_field): Handled fiels of nested structs
3218         recursively.
3219
3220 2019-10-16  Tom de Vries  <tdevries@suse.de>
3221
3222         PR tdep/24104
3223         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3224         that handles 'theclass'.
3225
3226 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3227
3228         * linespec.c (decode_digits_ordinary): Update comment.
3229         * make-target-delegates: No longer need to handle VEC case.
3230         * memrange.c (normalize_mem_ranges): Update comment.
3231         * namespace.c (add_using_directive): Update comment.
3232         * objc-lang.c (uniquify_strings): Update comment.
3233         * ppc-linux-nat.c (struct thread_points): Update comment.
3234         * probe.h (find_probes_in_objfile): Update comment.
3235         * target.h (enum flash_preserve_mode): Update comment.
3236         * varobj.c (varobj_restrict_range): Update comment.
3237         * varobj.h (varobj_list_children): Update comment.
3238
3239 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3240
3241         * Makefile.in: Remove references to vec.h and vec.c.
3242         * aarch64-tdep.c: No longer include vec.h.
3243         * ada-lang.c: Likewise.
3244         * ada-lang.h: Likewise.
3245         * arm-tdep.c: Likewise.
3246         * ax.h: Likewise.
3247         * breakpoint.h: Likewise.
3248         * charset.c: Likewise.
3249         * cp-support.h: Likewise.
3250         * dtrace-probe.c: Likewise.
3251         * dwarf2read.c: Likewise.
3252         * extension.h: Likewise.
3253         * gdb_bfd.c: Likewise.
3254         * gdbsupport/gdb_vecs.h: Likewise.
3255         * gdbsupport/vec.c: Remove.
3256         * gdbsupport/vec.h: Remove.
3257         * gdbthread.h: Likewise.
3258         * guile/scm-type.c: Likewise.
3259         * inline-frame.c: Likewise.
3260         * machoread.c: Likewise.
3261         * memattr.c: Likewise.
3262         * memrange.h: Likewise.
3263         * namespace.h: Likewise.
3264         * nat/linux-btrace.h: Likewise.
3265         * osdata.c: Likewise.
3266         * parser-defs.h: Likewise.
3267         * progspace.h: Likewise.
3268         * python/py-type.c: Likewise.
3269         * record-btrace.c: Likewise.
3270         * rust-exp.y: Likewise.
3271         * solib-target.c: Likewise.
3272         * stap-probe.c: Likewise.
3273         * target-descriptions.c: Likewise.
3274         * target-memory.c: Likewise.
3275         * target.h: Likewise.
3276         * varobj.c: Likewise.
3277         * varobj.h: Likewise.
3278         * xml-support.h: Likewise.
3279
3280 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3281
3282         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3283         Update for new std::vector based implementation.
3284         (process_psymtab_comp_unit_reader): Likewise.
3285         (scan_partial_symbols): Likewise.
3286         (recursively_compute_inclusions): Likewise.
3287         (compute_compunit_symtab_includes): Likewise.
3288         (process_imported_unit_die): Likewise.
3289         (queue_and_load_dwo_tu): Likewise.
3290         (follow_die_sig_1): Likewise.
3291         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3292         (typedef dwarf2_per_cu_ptr): Remove.
3293         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3294         function.
3295         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3296         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3297         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3298         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3299         std::vector.
3300
3301 2019-10-15  Tom Tromey  <tromey@adacore.com>
3302
3303         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3304         TID.
3305
3306 2019-10-15  Tom Tromey  <tromey@adacore.com>
3307
3308         * windows-nat.c (windows_nat_target::fetch_registers)
3309         (windows_nat_target::store_registers): Rename "pid" to "tid".
3310
3311 2019-10-15  Tom Tromey  <tromey@adacore.com>
3312
3313         * gdbarch.h, gdbarch.c: Rebuild.
3314         * gdbarch.sh (gcc_target_options): Change return type to
3315         std::string.
3316         * compile/compile.c (get_args): Update.
3317         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3318         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3319         std::string.
3320         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3321         std::string.
3322         * arch-utils.c (default_gcc_target_options): Return std::string.
3323         * arch-utils.h (default_gcc_target_options): Return std::string.
3324         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3325
3326 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3327
3328         * breakpoint.c (breakpoint_chain): Make static.
3329         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3330         of accessing breakpoint_chain.
3331
3332 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3333
3334         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3335         to a gdb::function_view and return value to bool.
3336         * breakpoint.h (iterate_over_breakpoints): Likewise.
3337         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3338         (pop_dummy_frame): Update.
3339         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3340         (gdbscm_breakpoints): Update.
3341         * python/py-breakpoint.c (build_bp_list): Update.
3342         (gdbpy_breakpoints): Update.
3343         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3344         Update.
3345         (bpfinishpy_handle_stop): Update.
3346         (bpfinishpy_handle_exit): Update.
3347         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3348         (svr4_update_solib_event_breakpoints): Update.
3349
3350 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3351
3352         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3353         when unwrapping single-field structs.
3354
3355 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3356
3357         * dwarf2read.c: Remove includes.
3358
3359 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3360
3361         * ui-out.c (ui_out::call_do_message): Silence
3362         -Wformat-nonliteral warning.
3363
3364 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3365
3366         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3367         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3368         include: readline/tilde.h.
3369
3370 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3371
3372         * remote.c (remote_target::get_trace_status): Remove declaration of
3373         trace_regblock_size.
3374
3375 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3376
3377         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3378         (show_user): Remove declaration of cmdlist.
3379         * cli/cli-cmds.h (max_user_call_depth): Declare.
3380         * cli/cli-script.c (execute_user_command): Remove declaration
3381         of max_user_call_depth.
3382
3383 2019-10-11  Jim Wilson  <jimw@sifive.com>
3384
3385         * gdbsupport/print-utils.h (pulongest): Fix comment.
3386         (plongest): Likewise.
3387         (phex): Add missing comment, mention leading zeros.
3388         (phex_nz): Add mention of no leading zeros to comment.
3389
3390         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3391         plongest instead of unsigned long long cast.
3392
3393 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3394
3395         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3396         for external_editor_command and gdbtk_test.
3397
3398 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3399
3400         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3401         * varobj.c (varobjdebug): Move comment to...
3402         * varobj.h (varobjdebug): ...here, and declare.
3403
3404 2019-10-09  Tom Tromey  <tom@tromey.com>
3405
3406         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3407         erase_data_content.
3408
3409 2019-10-09  Tom Tromey  <tom@tromey.com>
3410
3411         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3412         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3413         * tui/tui-command.c (tui_cmd_window::resize)
3414         (tui_refresh_cmd_win): Update.
3415         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3416         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3417         * tui/tui-data.c (~tui_gen_win_info): Remove.
3418         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3419         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3420         (tui_redisplay_readline, tui_mld_flush)
3421         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3422         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3423         (tui_data_window::erase_data_content)
3424         (tui_data_item_window::rerender)
3425         (tui_data_item_window::refresh_window): Update.
3426         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3427         (box_win, tui_gen_win_info::make_window)
3428         (tui_gen_win_info::make_visible): Update.
3429         (tui_delete_win): Remove.
3430         * tui/tui-winsource.c
3431         (tui_source_window_base::do_erase_source_content): Update.
3432         (tui_show_source_line, tui_source_window_base::update_tab_width)
3433         (tui_source_window_base::update_exec_info): Update.
3434         * tui/tui-data.h (struct curses_deleter): New.
3435         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3436         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3437
3438 2019-10-09  Tom Tromey  <tom@tromey.com>
3439
3440         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3441
3442 2019-10-09  Tom Tromey  <tom@tromey.com>
3443
3444         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3445         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3446
3447 2019-10-09  Tom Tromey  <tom@tromey.com>
3448
3449         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3450         window height directly.
3451         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3452         declare.
3453         * tui/tui-layout.c (tui_default_win_height): Remove.
3454         (tui_default_win_viewport_height): Remove.
3455
3456 2019-10-09  Tom Tromey  <tom@tromey.com>
3457
3458         * tui/tui.h: Remove comments.
3459
3460 2019-10-09  Tom de Vries  <tdevries@suse.de>
3461
3462         * python/lib/gdb/printer/bound_registers.py: Use
3463         '^builtin_type_bound128' as regexp argument for
3464         add_builtin_pretty_printer.
3465
3466 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3467
3468         * guile/guile.c (guile_extension_script_ops): Remove forward
3469         declaration and mark as static.
3470         (guile_script_ops): Likewise.
3471         (extension_language_guile): Move further down in the file so
3472         it can reference the definitions for guile_{extension_,}script_ops.
3473
3474 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3475
3476         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3477         except SORTL, DFLTCC, and KDSA.
3478
3479 2019-10-08  Tom Tromey  <tromey@adacore.com>
3480
3481         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3482         (struct safe_symbol_file_add_args): Remove.
3483
3484 2019-10-08  Tom Tromey  <tromey@adacore.com>
3485
3486         * windows-nat.c: Don't include buildsym-legacy.h.
3487
3488 2019-10-08  Tom Tromey  <tromey@adacore.com>
3489
3490         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3491
3492 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3493
3494         * gdbtypes.c (overload_debug): Move comment to header.
3495         * gdbtypes.h (overload_debug): Declare.
3496         * valops.c: Remove declaration of overload_debug, instead
3497         include gdbtypes.h.
3498
3499 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3500
3501         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3502         through _().
3503         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3504         move comment...
3505         * language.h (lang_frame_mismatch_warn): ... here. Also add
3506         declaration.
3507         * top.c (lang_frame_mismatch_warn): Remove declaration.
3508         (check_frame_language_change): Pass lang_frame_mismatch_warn
3509         through _().
3510
3511 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3512
3513         * c-lang.h (vtbl_ptr_name): Declare.
3514         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3515         it from the header.
3516         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3517
3518 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3519
3520         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3521         gdb_static_assert.
3522
3523 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3524
3525         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3526         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3527         * ctfread.c: New file.
3528         * ctfread.h: New file.
3529         * elfread.c: Include ctfread.h.
3530         (struct elfinfo text_p): New member ctfsect.
3531         (elf_locate_sections): Mark CTF section.
3532         (elf_symfile_read): Call elfctf_build_psymtabs.
3533         * Makefile.in (LIBCTF): Add.
3534         (CLIBS): Use it.
3535         (CDEPS): Likewise.
3536         (DIST): Add ctfread.c.
3537
3538 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3539
3540         * ctfread.c (struct nextfield): Renamed to ...
3541         (struct ctf_nextfield): ... this.
3542         (struct field_info): Renamed to ...
3543         (strut ctf_field_info): ... this.
3544         (attach_fields_to_type): Update for renamed structures.
3545         (ctf_add_member_cb): Likewise.
3546         (ctf_add_enum_member_cb): Likewise.
3547         (process_struct_members): Likewise.
3548         (process_enum_type): Likewise.
3549
3550 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3551
3552         * tracectf.h: Rename, was ctf.h.
3553         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3554         * tracefile.c: Likewise.
3555         * tracepoint.c: Remove unused include ctf.h.
3556         * mi/mi-main.c: Likewise.
3557         * Makefile.in Replace ctf.c with tracectf.c.
3558
3559 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3560
3561         * version.in: Change version number to "9.0.50.DATE-git".
3562
3563 2019-10-03  Tom Tromey  <tom@tromey.com>
3564
3565         PR rust/24976:
3566         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3567
3568 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3569
3570         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3571         cp_search_name_hash.
3572         * NEWS: Add entry about nested function support.
3573
3574 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3575             Andrew Burgess  <andrew.burgess@embecosm.com>
3576
3577         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3578         for nested static variables when searchin VAR_DOMAIN.
3579         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3580         global scope, update comment.
3581         (add_partial_subprogram): Call add_partial_subprogram recursively
3582         for nested subroutines when processinng Fortran.
3583         (load_partial_dies): Process the child entities of a subprogram
3584         when processing Fortran.
3585         (partial_die_parent_scope): Handle building scope
3586         for Fortran nested functions.
3587         (process_die): Record that nested functions have a scope.
3588         (new_symbol): Always record Fortran subprograms on the global
3589         symbol list.
3590         (determine_prefix): How to build the prefix for Fortran
3591         subprograms.
3592
3593 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3594
3595         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3596         have just sent the thread a SIGSTOP and are waiting for it to
3597         arrive.
3598
3599 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3600
3601         * btrace.c (btrace_add_pc): Remove whitespace before the template
3602         parameter in 'std::vector <...>'.
3603         (parse_xml_btrace_block): Likewise.
3604         (btrace_maint_decode_pt): Likewise.
3605         (btrace_maint_update_packets): Likewise.
3606         (btrace_maint_print_packets): Likewise.
3607         * btrace.h (struct btrace_maint_info): Likewise.
3608         * dwarf2read.c (struct type_unit_group): Likewise.
3609         (build_type_psymtabs_reader): Likewise.
3610         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3611         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3612         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3613
3614 2019-10-03  Tom de Vries  <tdevries@suse.de>
3615
3616         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3617         the first line of the help text for set/show style metadata.
3618
3619 2019-10-02  Tom Tromey  <tromey@adacore.com>
3620
3621         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3622         * gdbsupport/common-inferior.c: New file.
3623         * infcmd.c (startup_with_shell): Don't define.
3624         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3625         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3626         * inferior.h (startup_with_shell): Don't declare.
3627
3628 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3629
3630         * gdbsupport/gdb_assert.h: Include errors.h.
3631         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3632
3633 2019-10-02  Tom Tromey  <tromey@adacore.com>
3634
3635         * NEWS: Add $_ada_exception entry.
3636         * ada-lang.c (struct ada_catchpoint): Add constructor.
3637         <m_kind>: New member.
3638         (allocate_location_exception, re_set_exception): Remove
3639         "ex" parameter.
3640         (should_stop_exception): Compute $_ada_exception.
3641         (check_status_exception, print_it_exception)
3642         (print_one_exception, print_mention_exception): Remove
3643         "ex" parameter.
3644         (allocate_location_catch_exception, re_set_catch_exception)
3645         (check_status_exception, print_it_catch_exception)
3646         (print_one_catch_exception, print_mention_catch_exception)
3647         (print_recreate_catch_exception)
3648         (allocate_location_catch_exception_unhandled)
3649         (re_set_catch_exception_unhandled)
3650         (check_status_exception, print_it_catch_exception_unhandled)
3651         (print_one_catch_exception_unhandled)
3652         (print_mention_catch_exception_unhandled)
3653         (print_recreate_catch_exception_unhandled)
3654         (allocate_location_catch_assert, re_set_catch_assert)
3655         (check_status_assert, print_it_catch_assert)
3656         (print_one_catch_assert, print_mention_catch_assert)
3657         (print_recreate_catch_assert)
3658         (allocate_location_catch_handlers, re_set_catch_handlers)
3659         (check_status_handlers, print_it_catch_handlers)
3660         (print_one_catch_handlers, print_mention_catch_handlers)
3661         (print_recreate_catch_handlers): Remove.
3662         (create_ada_exception_catchpoint): Update.
3663         (initialize_ada_catchpoint_ops): Update.
3664
3665 2019-10-02  Tom Tromey  <tromey@adacore.com>
3666
3667         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3668         (create_excep_cond_exprs): Simplify exception string computation.
3669         (ada_exception_catchpoint_cond_string): Likewise.
3670
3671 2019-10-02  Tom Tromey  <tromey@adacore.com>
3672
3673         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3674         * ada-lang.c (lesseq_defined_than): Handle
3675         LOC_STATIC.
3676         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3677         parameter.
3678         (dwarf2_has_info): Likewise.
3679         (new_symbol): Set maybe_copied on symbol when
3680         appropriate.
3681         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3682         parameter.
3683         <can_copy>: New member.
3684         * elfread.c (record_minimal_symbol): Set maybe_copied
3685         on symbol when appropriate.
3686         (elf_symfile_read): Update call to dwarf2_has_info.
3687         * minsyms.c (lookup_minimal_symbol_linkage): New
3688         function.
3689         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3690         * symtab.c (get_symbol_address, get_msymbol_address):
3691         New functions.
3692         * symtab.h (get_symbol_address, get_msymbol_address):
3693         Declare.
3694         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3695         maybe_copied.
3696         (struct symbol, struct minimal_symbol) <maybe_copied>:
3697         New member.
3698
3699 2019-10-02  Tom Tromey  <tromey@adacore.com>
3700
3701         * source.c (struct current_source_location): New.
3702         (current_source_key): New global.
3703         (current_source_symtab, current_source_line)
3704         (current_source_pspace): Remove.
3705         (get_source_location): New function.
3706         (get_current_source_symtab_and_line)
3707         (set_default_source_symtab_and_line)
3708         (set_current_source_symtab_and_line)
3709         (clear_current_source_symtab_and_line, select_source_symtab)
3710         (info_source_command, print_source_lines_base)
3711         (info_line_command, search_command_helper, _initialize_source):
3712         Update.
3713
3714 2019-10-02  Tom Tromey  <tromey@adacore.com>
3715
3716         * source.c (select_source_symtab): Don't call
3717         decode_line_with_current_source.
3718
3719 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3720
3721         * symtab.c (lookup_global_symbol): Search global block.
3722
3723 2019-10-02  Tom Tromey  <tromey@adacore.com>
3724
3725         * coffread.c (process_coff_symbol): Update.
3726         * dwarf2read.c (var_decode_location, new_symbol): Update.
3727         * mdebugread.c (parse_symbol): Update.
3728         * objfiles.c (relocate_one_symbol): Update.
3729         * stabsread.c (define_symbol, fix_common_block)
3730         (scan_file_globals): Update.
3731         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3732         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3733         * xcoffread.c (process_xcoff_symbol): Update.
3734
3735 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3736
3737         * MAINTAINERS: Update my email address.
3738
3739 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3740
3741         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3742         std::vector.
3743         (build_type_psymtabs_reader): Update for std::vector.
3744         (build_type_psymtab_dependencies): Likewise.
3745         * dwarf2read.h: Remove use of DEF_VEC_P.
3746         (typedef sig_type_ptr): Delete.
3747
3748 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3749
3750         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3751         to std::vector.
3752         (btrace_maint_decode_pt): Likewise, and move allocation of the
3753         vector outside of the loop.
3754         (btrace_maint_update_packets): Update to handle change from VEC to
3755         std::vector.
3756         (btrace_maint_print_packets): Likewise.
3757         (maint_info_btrace_cmd): Likewise.
3758         * btrace.h: Remove use of DEF_VEC_O.
3759         (typedef btrace_pt_packet_s): Delete.
3760         (struct btrace_maint_info) <packets>: Change fromm VEC to
3761         std::vector.
3762         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3763
3764 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3765
3766         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3767         make accesses into the vector constant references.
3768         (btrace_add_pc): Update for std::vector.
3769         (btrace_stitch_bts): Likewise.
3770         (parse_xml_btrace_block): Likewise.
3771         (btrace_maint_update_packets): Likewise.
3772         (btrace_maint_print_packets): Likewise.
3773         (maint_info_btrace_cmd): Likewise.
3774         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3775         std::vector.
3776         (btrace_data::empty): Likewise.
3777         (btrace_data_append): Likewise.
3778         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3779         (typedef btrace_block_s): Delete.
3780         (struct btrace_block): Add constructor.
3781         (struct btrace_data_bts) <blocks>: Change to std::vector.
3782         * nat/linux-btrace.c (perf_event_read_bts): Update for
3783         std::vector.
3784         (linux_read_bts): Likewise.
3785
3786 2019-10-01  Tom Tromey  <tom@tromey.com>
3787
3788         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3789
3790 2019-10-01  Tom Tromey  <tom@tromey.com>
3791
3792         * stack.c (print_frame, info_frame_command_core): Use
3793         styled_string.
3794         * linux-thread-db.c (try_thread_db_load_1)
3795         (try_thread_db_load_from_pdir_1): Use styled_string.
3796         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3797         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3798         (maybe_print_unsupported_script_warning)
3799         (maybe_print_script_not_found_warning): Use styled_string.
3800         * ada-lang.c (user_select_syms): Use styled_string.
3801
3802 2019-10-01  Tom Tromey  <tom@tromey.com>
3803
3804         * p-lang.c (pascal_printstr): Use metadata style.
3805         * value.c (show_convenience): Use metadata style.
3806         * valprint.c (valprint_check_validity, val_print_optimized_out)
3807         (val_print_not_saved, val_print_unavailable)
3808         (val_print_invalid_address, generic_val_print, val_print)
3809         (value_check_printable, val_print_array_elements): Use metadata
3810         style.
3811         * ui-out.h (class ui_out) <field_fmt>: New overload.
3812         <do_field_fmt>: Add style parameter.
3813         * ui-out.c (ui_out::field_fmt): New overload.
3814         * typeprint.c (type_print_unknown_return_type)
3815         (val_print_not_allocated, val_print_not_associated): Use metadata
3816         style.
3817         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3818         parameter.
3819         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3820         * tracepoint.c (tvariables_info_1): Use metadata style.
3821         * stack.c (print_frame_arg, print_frame_info, print_frame)
3822         (info_frame_command_core): Use metadata style.
3823         * skip.c (info_skip_command): Use metadata style.
3824         * rust-lang.c (rust_print_enum): Use metadata style.
3825         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3826         metadata style.
3827         * python/py-framefilter.c (py_print_single_arg): Use metadata
3828         style.
3829         * printcmd.c (do_one_display, print_variable_and_value): Use
3830         metadata style.
3831         * p-valprint.c (pascal_val_print)
3832         (pascal_object_print_value_fields): Use metadata style.
3833         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3834         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3835         parameter.
3836         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3837         * m2-valprint.c (m2_print_long_set): Use metadata style.
3838         * m2-typeprint.c (m2_print_type): Use metadata style.
3839         * infcmd.c (print_return_value_1): Use metadata style.
3840         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3841         * f-valprint.c (info_common_command_for_block): Use metadata
3842         style.
3843         * f-typeprint.c (f_type_print_base): Use metadata style.
3844         * expprint.c (print_subexp_standard): Use metadata style.
3845         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3846         * cli/cli-style.h (class cli_style_option): Add constructor.
3847         (metadata_style): Declare.
3848         * cli/cli-style.c (metadata_style): New global.
3849         (_initialize_cli_style): Register metadata style.
3850         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3851         parameter.
3852         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3853         * c-typeprint.c (c_type_print_base_struct_union)
3854         (c_type_print_base_1): Use metadata style.
3855         * breakpoint.c (watchpoint_value_print)
3856         (print_one_breakpoint_location): Use metadata style.
3857         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3858         style.
3859         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3860         style.
3861         * ada-valprint.c (val_print_packed_array_elements, printstr)
3862         (print_field_values, ada_val_print_ref, ada_val_print): Use
3863         metadata style.
3864         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3865         style.
3866         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3867         style.
3868         * ada-lang.c (user_select_syms): Use metadata style.
3869
3870 2019-10-01  Tom Tromey  <tom@tromey.com>
3871
3872         * cli/cli-cmds.c (pwd_command): Style output.
3873
3874 2019-10-01  Pedro Alves  <palves@redhat.com>
3875             Tom Tromey  <tom@tromey.com>
3876
3877         * symtab.c (print_symbol_info): Use %ps.
3878         (print_msymbol_info): Use %ps.
3879         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3880         * printcmd.c (print_variable_and_value): Use %ps.
3881         * macrocmd.c (show_pp_source_pos): Use %ps.
3882         * infrun.c (print_exited_reason): Use ui_out::message.
3883         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3884         (describe_other_breakpoints): Use ui_out::message and new
3885         formats.
3886         (say_where): Use new formats.
3887         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3888         and new formats.
3889
3890 2019-10-01  Pedro Alves  <palves@redhat.com>
3891             Tom Tromey  <tom@tromey.com>
3892
3893         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3894         (test_gdb_formats): New function.
3895         (run_tests): Call it.
3896         (test_format_specifier): Update.
3897         * utils.h (fputs_filtered): Update comment.
3898         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3899         (fputs_styled_unfiltered): Declare.
3900         * utils.c (fputs_styled_unfiltered): New function.
3901         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3902         (vfprintf_filtered): Update.
3903         (vfprintf_unfiltered, vprintf_filtered): Update.
3904         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3905         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3906         disallow_ui_out_field>: New constants.
3907         (enum class field_kind): New.
3908         (struct base_field_s, struct signed_field_s): New.
3909         (signed_field): New function.
3910         (struct string_field_s): New.
3911         (string_field): New function.
3912         (struct styled_string_s): New.
3913         (styled_string): New function.
3914         (class ui_out) <message>: Add comment.
3915         <vmessage, call_do_message>: New methods.
3916         <do_message>: Add style parameter.
3917         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3918         methods.
3919         (ui_out::message): Rewrite.
3920         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3921         parameter.
3922         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3923         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3924         gdb_extensions parameter.
3925         (class format_piece): Add parameter to constructor.
3926         (n_int_args): New field.
3927         * gdbsupport/format.c (format_pieces::format_pieces): Add
3928         gdb_extensions parameter.  Handle '*'.
3929         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3930         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3931         vfprintf_styled_no_gdbfmt.
3932         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3933         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3934         unfiltered output.
3935         * ui-style.h (struct ui_file_style) <ptr>: New method.
3936
3937 2019-10-01  Tom Tromey  <tom@tromey.com>
3938
3939         * unittests/format_pieces-selftests.c: Update.  Add final format.
3940         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3941         empty literal pieces.
3942
3943 2019-10-01  Tom Tromey  <tom@tromey.com>
3944
3945         * ui-out.h (enum class ui_out_style_kind): Remove.
3946         (class ui_out) <field_string, field_stsream, do_field_string>:
3947         Change type of "style".
3948         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3949         (ui_out::field_string): Update.
3950         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3951         of "style".
3952         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3953         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3954         * stack.c (print_frame_arg, print_frame_info, print_frame):
3955         Update.
3956         * source.c (print_source_lines_base): Update.
3957         * solib.c (info_sharedlibrary_command): Update.
3958         * skip.c (info_skip_command): Update.
3959         * record-btrace.c (btrace_call_history_src_line)
3960         (btrace_call_history): Update.
3961         * python/py-framefilter.c (py_print_frame): Update.
3962         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3963         "style".
3964         * mi/mi-out.c (mi_ui_out::do_table_header)
3965         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3966         (mi_ui_out::do_field_string): Update.
3967         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3968         Update.
3969         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3970         "style".
3971         * cli-out.c (cli_ui_out::do_table_header)
3972         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3973         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3974         (cli_ui_out::do_field_fmt): Update.
3975         * breakpoint.c (print_breakpoint_location): Update.
3976         (update_static_tracepoint): Update.
3977
3978 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3979
3980         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3981         conversion of gdb_datadir.
3982         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3983         remove not needed c_str ().
3984
3985 2019-09-30  Ali Tamur <tamur@google.com>
3986
3987         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3988         (dwarf2_string_attr): Likewise.
3989
3990 2019-09-30  Ali Tamur <tamur@google.com>
3991
3992         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3993         (process_full_type_unit): Likewise.
3994         (dump_die_shallow): Likewise.
3995         (cu_debug_loc_section): Likewise.
3996
3997 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3998
3999         * minsyms.c (compare_minimal_symbols): Rename to...
4000         (minimal_symbol_is_less_than): ...this, and adjust to STL
4001         conventions (return bool, take arguments as references)
4002         (minimal_symbol_reader::install): Call std::sort instead
4003         of qsort.
4004
4005 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
4006
4007         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
4008         hash and why.
4009         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
4010         msymbol_hash, msymbol_demangled_hash>: Improve comments.
4011
4012 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
4013
4014         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
4015         * psympriv.h (add_psymbol_to_list): Move comment here and update
4016         it.
4017
4018 2019-09-29  Tom de Vries  <tdevries@suse.de>
4019
4020         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
4021         Use $tmpdir/$(basename "$output_file").dwz instead of
4022         "${output_file}.dwz".
4023
4024 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
4025
4026         PR gdb/25045
4027         * hppa-linux-nat.c: Include gdbarch.h.
4028
4029 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
4030
4031         * blockframe.c (find_pc_partial_function): Change return type to bool.
4032         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
4033         * minsyms.c (in_gnu_ifunc_stub): Likewise.
4034         (stub_gnu_ifunc_resolve_name): Likewise.
4035         * symtab.c (compare_filenames_for_search): Likewise.
4036         (compare_glob_filenames_for_search): Likewise.
4037         (matching_obj_sections): Likewise.
4038         (symbol_matches_domain): Likewise.
4039         (find_line_symtab): Change out param EXACT_MATCH to bool *.
4040         (find_line_pc): Change return type to bool.
4041         (find_line_pc_range): Likewise.
4042         (producer_is_realview): Likewise.
4043         * symtab.h (symbol_matches_domain): Likewise.
4044         (find_pc_partial_function): Likewise.
4045         (find_pc_line_pc_range): Likewise.
4046         (in_gnu_ifunc_stub): Likewise.
4047         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
4048         (find_line_pc): Likewise.
4049         (find_line_pc_range): Likewise.
4050         (matching_obj_sections): Likewise.
4051         (find_line_symtab): Change out parameter to bool.
4052         (producer_is_realview): Change return type to bool.
4053         (compare_filenames_for_search): Likewise.
4054         (compare_glob_filenames_for_search): Likewise.
4055
4056 2019-09-26  Tom Tromey  <tom@tromey.com>
4057
4058         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
4059         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
4060         * gdb_usleep.h: Remove.
4061         * gdb_usleep.c: Remove.
4062         * utils.c: Don't include gdb_usleep.h.
4063
4064 2019-09-26  Tom Tromey  <tromey@adacore.com>
4065
4066         * python/py-type.c (type_to_type_object): Call check_typedef
4067         for stub types.
4068
4069 2019-09-26  Tom Tromey  <tom@tromey.com>
4070
4071         * utils.h (initialize_utils): Don't declare.
4072         * top.c (gdb_init): Don't call initialize_utils.
4073         * utils.c (initialize_utils): Remove.  Move contents...
4074         (_initialize_utils): ... here.
4075
4076 2019-09-25  Tom Tromey  <tom@tromey.com>
4077
4078         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
4079         * utils.h (make_hex_string): Don't declare.
4080         * utils.c (make_hex_string): Remove.
4081
4082 2019-09-24  Tom de Vries  <tdevries@suse.de>
4083
4084         PR gdb/23815
4085         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4086         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4087
4088 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
4089
4090         * NEWS: Mention new simulator port for PRU.
4091
4092 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
4093
4094         * ada-exp.y (write_object_remaining): Update.
4095         * ada-lang.c (ada_decode): Return a std::string instead of a char*
4096         and eliminate the static buffer.
4097         (ada_decode_symbol): Update.
4098         (ada_la_decode): Update.
4099         (ada_sniff_from_mangled_name): Update.
4100         (is_valid_name_for_wild_match): Update.
4101         (ada_lookup_name_info::matches): Update and simplify.
4102         (name_matches_regex): Update.
4103         (ada_add_global_exceptions): Update.
4104         * ada-lang.h (ada_decode): Update signature.
4105         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4106         * dwarf-index-write.c (debug_names::insert): Update.
4107
4108 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4109
4110         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4111         formatting.
4112
4113 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4114
4115         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4116         Change "nonzero" to "true" in documentation.
4117
4118 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
4119
4120         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4121         (_initialize_darwin_solib): Don't set
4122         darwin_so_ops.lookup_lib_global_symbol.
4123         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4124         set_gdbarch_iterate_over_objfiles_in_search_order.
4125         (elf_lookup_lib_symbol): Rename to...
4126         (svr4_iterate_over_objfiles_in_search_order): this, and update
4127         to iterate semantics.
4128         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4129         * solib.c (solib_global_lookup): Remove.
4130         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4131         (solib_global_lookup): Remove.
4132         * symtab.c (lookup_global_or_static_symbol): Remove call to
4133         solib_global_lookup.
4134
4135 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4136
4137         * NEWS: Move entries about default MI version now being
4138         version 3, and about the GDB/MI fix for multi-location
4139         breakpoints to the "since GDB 8.3" section.
4140
4141 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4142
4143         GDB 8.3.1 released.
4144
4145 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
4146
4147         * NEWS: Mention that Cell/B.E. debugging support was removed.
4148         * MAINTAINERS: Remove spu target.
4149
4150         * config/djgpp/fnchange.lst: Remove entries for removed files.
4151
4152         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4153         spu-multiarch.o, and spu-tdep.o.
4154         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4155         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4156         spu-multiarch.c, and spu-tdep.c.
4157         * spu-linux-nat.c: Remove file.
4158         * spu-multiarch.c: Remove file.
4159         * spu-tdep.c: Remove file.
4160         * spu-tdep.h: Remove file.
4161         * solib-spu.c: Remove file.
4162         * solib-spu.h: Remove file.
4163
4164         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4165         * configure.nat (spu-linux): Remove.
4166         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4167         solib-multiarch.o from gdb_target_obs.
4168         (spu*-*-*): Remove.
4169
4170         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4171         feature flag.
4172         (ppc_linux_no_features): Update.
4173         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4174         Cell/B.E. support.
4175         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4176         (tdesc_powerpc_cell64l): Likewise.
4177         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4178         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4179         Cell/B.E. support.
4180         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4181         Do not include "features/rs6000/powerpc-cell32l.c" or
4182         "features/rs6000/powerpc-cell64l.c".
4183         (ppc_linux_spu_section): Remove.
4184         (ppc_linux_core_read_description): Remove Cell/B.E. support.
4185         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4186         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4187         (ppc_linux_spe_context_lookup): Remove.
4188         (ppc_linux_spe_context_inferior_created): Remove.
4189         (ppc_linux_spe_context_solib_loaded): Remove.
4190         (ppc_linux_spe_context_solib_unloaded): Remove.
4191         (ppc_linux_spe_context): Remove.
4192         (struct ppu2spu_cache): Remove.
4193         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4194         (struct ppu2spu_data): Remove.
4195         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4196         ppu2spu_unwind): Remove.
4197         (ppc_linux_init_abi): Remove Cell/B.E. support.
4198         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4199
4200         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4201         (rs6000/powerpc-cell64l-expedite): Likewise
4202         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4203         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4204         rs6000/powerpc-cell64l.xml.
4205         * features/rs6000/powerpc-cell32l.xml: Remove.
4206         * features/rs6000/powerpc-cell64l.xml: Likewise.
4207         * features/rs6000/powerpc-cell32l.c: Remove generated file.
4208         * features/rs6000/powerpc-cell64l.c: Likewise.
4209         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4210         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4211         * regformats/reg-spu.dat: Remove.
4212
4213         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4214         * corelow.c (struct spuid_list): Remove.
4215         (add_to_spuid_list): Remove.
4216         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4217         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4218         (remote_protocol_features): Remove associated entries.
4219         (_initialize_remote): No longer initialize them.
4220         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4221         * linux-nat.c (SPUFS_MAGIC): Remove.
4222         (linux_proc_xfer_spu): Remove.
4223         (spu_enumerate_spu_ids): Remove.
4224         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4225         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4226         (linux_make_corefile_notes): No longer call it.
4227
4228         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4229         (cooked_write_test): Likewise.
4230
4231 2019-09-20  Tom Tromey  <tom@tromey.com>
4232
4233         * NEWS: Mention case-sensitivity of TUI commands.
4234         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4235         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4236         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4237
4238 2019-09-20  Tom Tromey  <tom@tromey.com>
4239
4240         * tui/tui-source.c (tui_source_window::set_contents): Use
4241         make_unique_xstrdup.
4242         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4243         make_unique_xstrdup.
4244
4245 2019-09-20  Tom Tromey  <tom@tromey.com>
4246
4247         * tui/tui-data.c: Remove separator comments.
4248         * tui/tui-layout.c: Remove separator comments.
4249         * tui/tui-win.c: Remove separator comments.
4250         * tui/tui-wingeneral.c: Remove separator comments.
4251
4252 2019-09-20  Tom Tromey  <tom@tromey.com>
4253
4254         * tui/tui.h (strcat_to_buf): Don't declare.
4255         * tui/tui.c (strcat_to_buf): Remove.
4256
4257 2019-09-20  Tom Tromey  <tom@tromey.com>
4258
4259         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4260         from "fullname".
4261         * tui/tui-source.c (tui_source_window::set_contents)
4262         (tui_source_window::location_matches_p)
4263         (tui_source_window::maybe_update): Update.
4264
4265 2019-09-20  Tom Tromey  <tom@tromey.com>
4266
4267         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4268         Update.
4269         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4270         prefix.
4271         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4272         (tui_data_window::line_from_reg_element_no)
4273         (tui_data_window::first_reg_element_no_inline)
4274         (tui_data_window::show_registers)
4275         (tui_data_window::show_register_group)
4276         (tui_data_window::display_registers_from)
4277         (tui_data_window::display_registers_from_line)
4278         (tui_data_window::first_data_item_displayed)
4279         (tui_data_window::delete_data_content_windows)
4280         (tui_data_window::erase_data_content)
4281         (tui_data_window::do_scroll_vertical)
4282         (tui_data_window::refresh_window)
4283         (tui_data_window::check_register_values): Update.
4284
4285 2019-09-20  Tom Tromey  <tom@tromey.com>
4286
4287         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4288         (struct tui_locator_window) <full_name, proc_name>: Now
4289         std::string.
4290         * tui/tui-stack.c (tui_locator_window::make_status_line)
4291         (tui_locator_window::set_locator_fullname)
4292         (tui_locator_window::set_locator_info): Update.
4293         * tui/tui-source.c (tui_source_window::set_contents)
4294         (tui_source_window::showing_source_p): Update.
4295
4296 2019-09-20  Tom Tromey  <tom@tromey.com>
4297
4298         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4299         Don't call tui_locator_win_info_ptr.
4300
4301 2019-09-20  Tom Tromey  <tom@tromey.com>
4302
4303         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4304
4305 2019-09-20  Tom Tromey  <tom@tromey.com>
4306
4307         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4308         height for locator.
4309         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4310         * tui/tui-layout.c (show_source_disasm_command, show_data)
4311         (show_source_or_disasm_and_command): Use 1 as height for locator.
4312
4313 2019-09-20  Tom Tromey  <tom@tromey.com>
4314
4315         * tui/tui.c (tui_enable): Update.
4316         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4317         Update.
4318         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4319         Update.
4320         * tui/tui-data.c (win_resized): Now bool.
4321         (tui_win_resized): Return bool.
4322         (tui_set_win_resized_to): Accept a bool.
4323
4324 2019-09-20  Tom Tromey  <tom@tromey.com>
4325
4326         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4327         Change type of "refresh_values_only".
4328         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4329         type of "refresh_values_only".
4330
4331 2019-09-20  Tom Tromey  <tom@tromey.com>
4332
4333         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4334         std::string.
4335         (tui_disassemble): Add "pos" parameter.
4336         (tui_disasm_window::set_contents): Simplify.
4337
4338 2019-09-20  Tom Tromey  <tom@tromey.com>
4339
4340         * tui/tui-winsource.h (struct tui_source_window_base)
4341         <show_source_content>: Now private.
4342         * tui/tui-winsource.c
4343         (tui_source_window_base::show_source_content): Don't handle empty
4344         content case.
4345
4346 2019-09-20  Tom Tromey  <tom@tromey.com>
4347
4348         * tui/tui-layout.c (show_source_disasm_command)
4349         (show_source_or_disasm_and_command): Don't call
4350         show_source_content.
4351
4352 2019-09-20  Tom Tromey  <tom@tromey.com>
4353
4354         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4355         Declare.
4356         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4357         from tui_make_status_line.
4358         (tui_locator_window::rerender): Update.
4359
4360 2019-09-20  Tom Tromey  <tom@tromey.com>
4361
4362         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4363         (tui_locator_window::rerender): Update.
4364
4365 2019-09-20  Tom Tromey  <tom@tromey.com>
4366
4367         * tui/tui-winsource.h (struct tui_source_window_base)
4368         <~tui_source_window_base>: Don't declare.
4369         <fullname>: Remove.
4370         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4371         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4372         member.
4373         * tui/tui-source.c (tui_source_window::set_contents): Update.
4374         (tui_source_window::location_matches_p)
4375         (tui_source_window::maybe_update): Update.
4376
4377 2019-09-20  Tom Tromey  <tom@tromey.com>
4378
4379         * tui/tui-winsource.h (~tui_source_element): Remove.
4380         (tui_source_element): Update.
4381         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4382         * tui/tui-winsource.c (tui_show_source_line): Update.
4383         * tui/tui-source.c (tui_source_window::set_contents): Update.
4384         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4385
4386 2019-09-20  Tom Tromey  <tom@tromey.com>
4387
4388         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4389         declare.
4390         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4391         tui_clear_source_windows_detail.
4392         * tui/tui-winsource.h (struct tui_source_window_base)
4393         <clear_detail>: Don't declare.
4394         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4395         Remove.
4396         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4397
4398 2019-09-20  Tom Tromey  <tromey@adacore.com>
4399
4400         PR ada/24919:
4401         * block.c (contained_in): Fix final return value.
4402
4403 2019-09-20  Alan Modra  <amodra@gmail.com>
4404
4405         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4406         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4407         (read_indirect_string_from_dwz): Use bfd accessor.
4408         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4409         * machoread.c (macho_symfile_read_all_oso): Likewise.
4410         * solib.c (solib_bfd_open): Likewise.
4411
4412 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4413
4414         * eval.c: Move declaration of overload_resolution to...
4415         * value.h: ...here.
4416
4417 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4418
4419         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4420         * arm-linux-tdep.c: Likewise.
4421         * arm-nbsd-nat.c: Likewise.
4422         * arm-tdep.h: Declare arm_apcs_32.
4423         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4424
4425 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4426
4427         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4428         * dwarf2read.h: Declare dwarf_always_disassemble.
4429
4430 2019-09-19  Tom de Vries  <tdevries@suse.de>
4431
4432         PR gdb/25009
4433         * source-cache.c (source_cache::ensure): Catch exception thrown during
4434         construction of the highlighter.
4435
4436 2019-09-18  Alan Modra  <amodra@gmail.com>
4437
4438         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4439         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4440         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4441         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4442         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4443         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4444         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4445         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4446         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4447         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4448         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4449         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4450         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4451         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4452         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4453         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4454         * mi/mi-interp.c: Update throughout for bfd section macro and
4455         function changes.
4456         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4457         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4458
4459 2019-09-18  Tom Tromey  <tom@tromey.com>
4460
4461         * NEWS: Add entry.
4462         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4463         call rl_initialize.
4464         (tui_enable): Do not call rl_initialize.
4465
4466 2019-09-18  Christian Groessler  <chris@groessler.org>
4467
4468         * alpha-linux-nat.c: Include gdbarch.h.
4469
4470 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4471
4472         * ui-file.c: Include cli/cli-style.h.
4473         (term_cli_styling): Remove cli_styling declaration.
4474
4475 2019-09-18  Alan Modra  <amodra@gmail.com>
4476
4477         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4478         to bfd_asymbol_section.
4479
4480 2019-09-18  Alan Modra  <amodra@gmail.com>
4481
4482         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4483         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4484         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4485
4486 2019-09-18  Alan Modra  <amodra@gmail.com>
4487
4488         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4489         * spu-linux-nat.c (spu_bfd_open): Likewise.
4490
4491 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4492
4493         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4494         to bool to match definition in dwarf2read.c.
4495
4496 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4497
4498         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4499         (print_signatures): Likewise.
4500         (trust_pad_over_xvs): Likewise.
4501         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4502         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4503         * arm-linux-nat.c (arm_apcs_32): Likewise.
4504         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4505         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4506         * arm-tdep.c (arm_debug): Likewise.
4507         (arm_apcs_32): Likewise.
4508         * auto-load.c (debug_auto_load): Likewise.
4509         (auto_load_gdb_scripts): Likewise.
4510         (global_auto_load): Likewise.
4511         (auto_load_local_gdbinit): Likewise.
4512         (auto_load_local_gdbinit_loaded): Likewise.
4513         * auto-load.h (global_auto_load): Likewise.
4514         (auto_load_local_gdbinit): Likewise.
4515         (auto_load_local_gdbinit_loaded): Likewise.
4516         * breakpoint.c (disconnected_dprintf): Likewise.
4517         (breakpoint_proceeded): Likewise.
4518         (automatic_hardware_breakpoints): Likewise.
4519         (always_inserted_mode): Likewise.
4520         (target_exact_watchpoints): Likewise.
4521         (_initialize_breakpoint): Update.
4522         * breakpoint.h (target_exact_watchpoints): Change to bool.
4523         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4524         * cli/cli-cmds.c (trace_commands): Likewise.
4525         * cli/cli-cmds.h (trace_commands): Likewise.
4526         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4527         to bool*.
4528         * cli/cli-logging.c (logging_overwrite): Change to bool.
4529         (logging_redirect): Likewise.
4530         (debug_redirect): Likewise.
4531         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4532         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4533         to bool.
4534         <boolean_option_def>: Update.
4535         (struct flag_option_def): Change default type of Context to bool
4536         from int.
4537         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4538         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4539         (get_setshow_command_value_string): Likewise.
4540         * cli/cli-style.c (cli_styling): Change to bool.
4541         (source_styling): Likewise.
4542         * cli/cli-style.h (source_styling): Likewise.
4543         (cli_styling): Likewise.
4544         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4545         to bool.
4546         * command.h (var_types): Update comment.
4547         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4548         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4549         bool.
4550         (debug_compile_cplus_scopes): Likewise.
4551         * compile/compile-internal.h (compile_debug): Likewise.
4552         * compile/compile.c (compile_debug): Likewise.
4553         (struct compile_options) <raw>: Likewise.
4554         * cp-support.c (catch_demangler_crashes): Likewise.
4555         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4556         (usr_cmd_cris_dwarf2_cfi): Likewise.
4557         * csky-tdep.c (csky_debug): Likewise.
4558         * darwin-nat.c (enable_mach_exceptions): Likewise.
4559         * dcache.c (dcache_enabled_p): Likewise.
4560         * defs.h (info_verbose): Likewise.
4561         * demangle.c (demangle): Likewise.
4562         (asm_demangle): Likewise.
4563         * dwarf-index-cache.c (debug_index_cache): Likewise.
4564         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4565         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4566         * dwarf2read.c (check_physname): Likewise.
4567         (use_deprecated_index_sections): Likewise.
4568         (dwarf_always_disassemble): Likewise.
4569         * eval.c (overload_resolution): Likewise.
4570         * event-top.c (set_editing_cmd_var): Likewise.
4571         (exec_done_display_p): Likewise.
4572         * event-top.h (set_editing_cmd_var): Likewise.
4573         (exec_done_display_p): Likewise.
4574         * exec.c (write_files): Likewise.
4575         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4576         (debug_fbsd_nat): Likewise.
4577         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4578         Likewise.
4579         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4580         <backtrace_past_entry> Likewise.
4581         * gdb-demangle.h (demangle): Likewise.
4582         (asm_demangle): Likewise.
4583         * gdb_bfd.c (bfd_sharing): Likewise.
4584         * gdbcore.h (write_files): Likewise.
4585         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4586         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4587         * gdbthread.h (print_thread_events): Likewise.
4588         * gdbtypes.c (opaque_type_resolution): Likewise.
4589         (strict_type_checking): Likewise.
4590         * gnu-nat.c (gnu_debug_flag): Likewise.
4591         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4592         * guile/scm-param.c (pascm_variable): Add boolval.
4593         (add_setshow_generic): Update.
4594         (pascm_param_value): Update.
4595         (pascm_set_param_value_x): Update.
4596         * hppa-tdep.c (hppa_debug): Change to bool..
4597         * infcall.c (may_call_functions_p): Likewise.
4598         (coerce_float_to_double_p): Likewise.
4599         (unwind_on_signal_p): Likewise.
4600         (unwind_on_terminating_exception_p): Likewise.
4601         * infcmd.c (startup_with_shell): Likewise.
4602         * inferior.c (print_inferior_events): Likewise.
4603         * inferior.h (startup_with_shell): Likewise.
4604         (print_inferior_events): Likewise.
4605         * infrun.c (step_stop_if_no_debug): Likewise.
4606         (detach_fork): Likewise.
4607         (debug_displaced): Likewise.
4608         (disable_randomization): Likewise.
4609         (non_stop): Likewise.
4610         (non_stop_1): Likewise.
4611         (observer_mode): Likewise.
4612         (observer_mode_1): Likewise.
4613         (set_observer_mode): Update.
4614         (sched_multi): Change to bool.
4615         * infrun.h (debug_displaced): Likewise.
4616         (sched_multi): Likewise.
4617         (step_stop_if_no_debug): Likewise.
4618         (non_stop): Likewise.
4619         (disable_randomization): Likewise.
4620         * linux-tdep.c (use_coredump_filter): Likewise.
4621         (dump_excluded_mappings): Likewise.
4622         * linux-thread-db.c (auto_load_thread_db): Likewise.
4623         (check_thread_db_on_load): Likewise.
4624         * main.c (captured_main_1): Update.
4625         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4626         xx2_opt, boolean_opt>: Change to bool.
4627         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4628         * maint.c (maintenance_profile_p): Likewise.
4629         (per_command_time): Likewise.
4630         (per_command_space): Likewise.
4631         (per_command_symtab): Likewise.
4632         * memattr.c (inaccessible_by_default): Likewise.
4633         * mi/mi-main.c (mi_async): Likewise.
4634         (mi_async_1): Likewise.
4635         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4636         * nat/fork-inferior.h (startup_with_shell): Likewise.
4637         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4638         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4639         * nios2-tdep.c (nios2_debug): Likewise.
4640         * or1k-tdep.c (or1k_debug): Likewise.
4641         * parse.c (parser_debug): Likewise.
4642         * parser-defs.h (parser_debug): Likewise.
4643         * printcmd.c (print_symbol_filename): Likewise.
4644         * proc-api.c (procfs_trace): Likewise.
4645         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4646         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4647         (set_parameter_value): Update.
4648         (add_setshow_generic): Update.
4649         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4650         to bool*.
4651         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4652         int*.
4653         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4654         * record-btrace.c (record_btrace_target::store_registers): Update.
4655         * record-full.c (record_full_memory_query): Change to bool.
4656         (record_full_stop_at_limit): Likewise.
4657         * record-full.h (record_full_memory_query): Likewise.
4658         * remote-notif.c (notif_debug): Likewise.
4659         * remote-notif.h (notif_debug): Likewise.
4660         * remote.c (use_range_stepping): Likewise.
4661         (interrupt_on_connect): Likewise.
4662         (remote_break): Likewise.
4663         * ser-tcp.c (tcp_auto_retry): Likewise.
4664         * ser-unix.c (serial_hwflow): Likewise.
4665         * skip.c (debug_skip): Likewise.
4666         * solib-aix.c (solib_aix_debug): Likewise.
4667         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4668         (spu_auto_flush_cache_p): Likewise.
4669         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4670         Likewise.
4671         (struct info_print_options) <quiet>: Likewise.
4672         * symfile-debug.c (debug_symfile): Likewise.
4673         * symfile.c (auto_solib_add): Likewise.
4674         (separate_debug_file_debug): Likewise.
4675         * symfile.h (auto_solib_add): Likewise.
4676         (separate_debug_file_debug): Likewise.
4677         * symtab.c (basenames_may_differ): Likewise.
4678         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4679         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4680         (struct info_types_options) <quiet>: Likewise.
4681         * symtab.h (demangle): Likewise.
4682         (basenames_may_differ): Likewise.
4683         * target-dcache.c (stack_cache_enabled_1): Likewise.
4684         (code_cache_enabled_1): Likewise.
4685         * target.c (trust_readonly): Likewise.
4686         (may_write_registers): Likewise.
4687         (may_write_memory): Likewise.
4688         (may_insert_breakpoints): Likewise.
4689         (may_insert_tracepoints): Likewise.
4690         (may_insert_fast_tracepoints): Likewise.
4691         (may_stop): Likewise.
4692         (auto_connect_native_target): Likewise.
4693         (target_stop_and_wait): Update.
4694         (target_async_permitted): Change to bool.
4695         (target_async_permitted_1): Likewise.
4696         (may_write_registers_1): Likewise.
4697         (may_write_memory_1): Likewise.
4698         (may_insert_breakpoints_1): Likewise.
4699         (may_insert_tracepoints_1): Likewise.
4700         (may_insert_fast_tracepoints_1): Likewise.
4701         (may_stop_1): Likewise.
4702         * target.h (target_async_permitted): Likewise.
4703         (may_write_registers): Likewise.
4704         (may_write_memory): Likewise.
4705         (may_insert_breakpoints): Likewise.
4706         (may_insert_tracepoints): Likewise.
4707         (may_insert_fast_tracepoints): Likewise.
4708         (may_stop): Likewise.
4709         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4710         (make_thread_apply_all_options_def_group): Change argument from int*
4711         to bool*.
4712         (thread_apply_all_command): Update.
4713         (print_thread_events): Change to bool.
4714         * top.c (confirm): Likewise.
4715         (command_editing_p): Likewise.
4716         (history_expansion_p): Likewise.
4717         (write_history_p): Likewise.
4718         (info_verbose): Likewise.
4719         * top.h (confirm): Likewise.
4720         (history_expansion_p): Likewise.
4721         * tracepoint.c (disconnected_tracing): Likewise.
4722         (circular_trace_buffer): Likewise.
4723         * typeprint.c (print_methods): Likewise.
4724         (print_typedefs): Likewise.
4725         * utils.c (debug_timestamp): Likewise.
4726         (sevenbit_strings): Likewise.
4727         (pagination_enabled): Likewise.
4728         * utils.h (sevenbit_strings): Likewise.
4729         (pagination_enabled): Likewise.
4730         * valops.c (overload_resolution): Likewise.
4731         * valprint.h (struct value_print_options) <prettyformat_arrays,
4732         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4733         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4734         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4735         Likewise.
4736         * windows-nat.c (new_console): Likewise.
4737         (cygwin_exceptions): Likewise.
4738         (new_group): Likewise.
4739         (debug_exec): Likewise.
4740         (debug_events): Likewise.
4741         (debug_memory): Likewise.
4742         (debug_exceptions): Likewise.
4743         (useshell): Likewise.
4744         * windows-tdep.c (maint_display_all_tib): Likewise.
4745         * xml-support.c (debug_xml): Likewise.
4746
4747 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4748
4749         * source.c (prepare_path_for_appending): New function.
4750         (openp): Make use of new function.
4751         (find_and_open_source): Search for the compilation directory and
4752         source file as a relative path beneath the directory search path.
4753
4754 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4755
4756         * source-cache.c (source_cache::get_line_charpos): Catch
4757         exceptions and return false, this matches the behaviour documented
4758         in the header file.
4759
4760 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4761
4762         * ada-tasks.c (info_task): Remove quoting of the task's name.
4763
4764 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4765
4766         * symfile.c (auto_solib_add): Replace comment with a reference
4767         to the header file.
4768
4769 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4770
4771         * NEWS: Mention that gdb can now be compiled with Python 3
4772         on Windows.
4773
4774 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4775
4776         * maint.c (maint_print_section_data::maint_print_section_data):
4777         Force use of 'float log10 (float)' by casting the argument to
4778         float.
4779
4780 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4781
4782         * maint.c: Add 'cmath' include.
4783         (struct maint_print_section_data): New structure.
4784         (print_section_index): New function.
4785         (print_bfd_section_info): Add header comment, small whitespace
4786         cleanup, and update to call new print_section_index function.
4787         (print_objfile_section_info): Likewise.
4788         (maint_obj_section_from_bfd_section): New function.
4789         (print_bfd_section_info_maybe_relocated): New function.
4790         (maintenance_info_sections): Add header comment, always use
4791         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4792
4793 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4794
4795         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4796         inner scope, add check that the objfile has psymtabs before
4797         checking psymtabs_addrmap.
4798         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4799
4800 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4801
4802         * NEWS: Announce that Ada task names are now shown at more places,
4803         and between quotes (except in info task output).
4804         * gdb/ada-tasks.c (task_to_str): New function.
4805         (display_current_task_id): Call task_to_str.
4806         (task_command_1): Likewise.
4807         (print_ada_task_info): In non-mi mode, Properly align headers and data
4808         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4809
4810 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4811
4812         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4813         prstatus.pr_lwp.pr_info instead of making it up.
4814
4815 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4816
4817         * auto-load.c (auto_load_expand_dir_vars): Update.
4818         * defs.h (gdb_datadir): Change to std::string.
4819         (python_libdir): Likewise.
4820         (relocate_gdb_directory): Change return type to std::string.
4821         * guile/guile.c (gdbscm_data_directory): Update.
4822         (initialize_scheme_side): Update.
4823         * jit.c (jit_reader_dir): Change to std::string.
4824         (jit_reader_load_command): Update.
4825         * main.c (gdb_datadir): Change to std::string.
4826         (python_libdir): Likewise.
4827         (set_gdb_data_directory): Update.
4828         (relocate_path): Change to return std::string.
4829         (relocate_gdb_directory): Change to return std::string.
4830         (relocate_gdbinit_path_maybe_in_datadir): Update.
4831         (captured_main_1): Update.
4832         * python/python.c (do_start_initialization): Update.
4833         * top.c (show_gdb_datadir): Update.
4834         * xml-syscall.c (xml_init_syscalls_info): Update.
4835         (init_syscalls_info): Update.
4836
4837 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4838
4839         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4840         out of get_init_files.
4841         (get_init_files): Update.
4842
4843 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4844
4845         * main.c (get_init_files): Change to use std::string.
4846         (captured_main_1): Update.
4847         (print_gdb_help): Update.
4848
4849 2019-09-11  Ali Tamur  <tamur@google.com>
4850
4851         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4852         implementation.
4853
4854 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4855
4856         * dbxread.c (read_dbx_symtab): Update.
4857         * dwarf2read.c (load_partial_dies): Update.
4858         * mdebugread.c (parse_partial_symbols): Update.
4859         (handle_psymbol_enumerators): Update.
4860         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4861         * psymtab.c (add_psymbol_to_bcache): Likewise.
4862         (add_psymbol_to_list): Likewise.
4863         * symtab.c (symbol_set_names): Likewise.
4864         * symtab.h (symbol_set_names): Likewise.
4865         * xcoffread.c (scan_xcoff_symtab): Update.
4866
4867 2019-09-11  Tom Tromey  <tom@tromey.com>
4868
4869         * symfile-mem.c (symbol_file_add_from_memory): Use
4870         bfd_set_filename.
4871         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4872         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4873
4874 2019-09-10  Tom Tromey  <tromey@adacore.com>
4875
4876         * dwarf-index-write.c (write_psymbols): Extend error message.
4877         (debug_names::insert): Add Ada code.
4878         (debug_names::write_psymbols): Remove Ada check.
4879         (debug_names) <m_string_obstack>: New member.
4880         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4881         (gdb_index_symbol_name_matcher::matches): Remove.
4882         (mapped_index_base::find_name_components_bounds): Add "lang"
4883         parameter.
4884         (mapped_index_base::build_name_components): Also split names
4885         according to Ada syntax.
4886         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4887         type of "match_callback".
4888         (check_match, check_find_bounds_finds)
4889         (dw2_expand_symtabs_matching): Update.
4890         (dw2_debug_names_iterator): Add new constructor.
4891         (dw2_debug_names_map_matching_symbols): New function.
4892         (dw2_debug_names_expand_symtabs_matching): Update.
4893         (dwarf2_debug_names_functions): Use
4894         dw2_debug_names_map_matching_symbols.
4895
4896 2019-09-10  Tom Tromey  <tromey@adacore.com>
4897
4898         * dwarf2read.c (dw2_get_file_names_reader): Add the
4899         CU's file name to the results.
4900
4901 2019-09-10  Tom Tromey  <tromey@adacore.com>
4902
4903         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4904         map_matching_symbols.  Update.
4905         * dwarf2read.c (dw2_map_matching_symbols): Update.
4906         * psymtab.c (match_partial_symbol): Change type; update.
4907         (psym_map_matching_symbols): Likewise.
4908         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4909         type; update.
4910         * symfile.h (struct quick_symbol_functions)
4911         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4912         Remove "match".
4913
4914 2019-09-10  Tom Tromey  <tromey@adacore.com>
4915
4916         * psymtab.c (map_block): Remove.
4917         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4918         * symtab.c (iterate_over_symbols_terminated): New function.
4919         * symtab.c (iterate_over_symbols_terminated): Declare.
4920
4921 2019-09-10  Tom Tromey  <tromey@adacore.com>
4922
4923         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4924         * language.h (struct language_defn) <la_iterate_over_symbols>:
4925         Return bool.
4926         * symtab.c (iterate_over_symbols): Return bool.
4927         * symtab.h (iterate_over_symbols): Return bool.
4928
4929 2019-09-10  Tom Tromey  <tromey@adacore.com>
4930
4931         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4932         (add_nonlocal_symbols): Update.
4933         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4934         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4935         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4936         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4937         Change type of "callback".  Remove "data".
4938
4939
4940 2019-09-09  Ali Tamur  <tamur@google.com>
4941
4942         * dwarf2read.c (comp_unit_head): Update comment.
4943         (dwarf2_dwo_name): New function declaration.
4944         (dwarf_unit_type_name): New function declaration.
4945         (read_comp_unit_head): Add support for new compilation units,
4946         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4947         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4948         (currently named as "signature") in their header. Also clarify error
4949         messages.
4950         (lookup_dwo_id): New function. Returns the dwo id of the given
4951         compile unit.
4952         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4953         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4954         functions.
4955         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4956         (dwarf2_dwo_name): Get the dwo name if present.
4957         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4958         purposes.
4959
4960 2019-09-09  Tom Tromey  <tom@tromey.com>
4961
4962         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4963
4964 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4965
4966         * python/python.c (do_start_initialization): Make progname_copy static,
4967         to avoid a leak report.
4968
4969 2019-09-08  Tom Tromey  <tom@tromey.com>
4970
4971         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4972
4973 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4974
4975         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4976         Change type to gdb::optional<block_enum>.
4977         (dw2_symtab_iter_init): Change block_index parameter type
4978         to gdb::optional<block_enum>.
4979         (dw2_lookup_symbol): Change block_index parameter
4980         type to block_enum.c
4981         (dw2_debug_names_lookup_symbol): Likewise.
4982         * psymtab.c (psym_lookup_symbol): Likewise.
4983         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4984         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4985         Likewise.
4986
4987 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4988
4989         * defs.h (relocate_gdb_directory): Change int to bool in
4990         signature and rename flag to relocatable.
4991         * main.c (relocate_path): Likewise.
4992         (relocate_gdb_directory): Likewise.
4993
4994 2019-09-06  Alan Modra  <amodra@gmail.com>
4995
4996         * coffread.c (coff_symfile_read): Constify filename variable.
4997         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4998         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4999         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
5000         * solib.c (reload_shared_libraries_1): Likewise.
5001         * symfile.c (reread_symbols): Likewise.
5002         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
5003         * solib-darwin.c (darwin_bfd_open): Likewise.
5004         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
5005
5006 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5007
5008         * psymtab.c (print_partial_symbols): Handle missing domain_enum
5009         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
5010
5011 2019-09-03  Tom Tromey  <tromey@adacore.com>
5012
5013         * ada-valprint.c (ada_val_print_num): Don't recurse for range
5014         types.
5015         (has_negatives): Unbias a range type bound.
5016         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
5017         * gdbtypes.c (operator==): Handle new field.
5018         (create_range_type): Add "bias" parameter.
5019         (create_static_range_type, resolve_dynamic_range): Update.
5020         * gdbtypes.h (struct range_bounds) <bias>: New member.
5021         (create_range_type): Add bias parameter.
5022         * printcmd.c (print_scalar_formatted): Unbias range types.
5023         * value.c (unpack_long): Unbias range types.
5024         (pack_long): Bias range types.
5025
5026 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5027
5028         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
5029         probe arguments.
5030
5031 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5032
5033         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
5034         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
5035         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
5036         (compile_probe_arg): Likewise.
5037         * probe.h (get_argument_count): Likewise.
5038         * solib-svr4.c (solib_event_probe_action): Likewise.
5039         * stap-probe.c (stap_probe::get_argument_count): Likewise.
5040
5041 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5042
5043         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
5044         code to here...
5045         (svr4_create_solib_event_breakpoints): ...from here.
5046
5047 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
5048
5049         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
5050         suffix from warning message.
5051
5052 2019-08-30  Tom Tromey  <tom@tromey.com>
5053
5054         * tui/tui-winsource.h (struct tui_source_window_base)
5055         <refresh_all>: Don't declare.
5056         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
5057         Remove.
5058         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
5059         tui_show_locator_content.
5060         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
5061         declare.
5062         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
5063         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
5064         declare.
5065
5066 2019-08-30  Tom Tromey  <tom@tromey.com>
5067
5068         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
5069
5070 2019-08-30  Tom Tromey  <tom@tromey.com>
5071
5072         * tui/tui-stack.c (_initialize_tui_stack): Move later.
5073         Remove unnecessary forward declarations.
5074
5075 2019-08-30  Tom Tromey  <tom@tromey.com>
5076
5077         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
5078         rerender.
5079         (tui_update_locator_fullname, tui_show_frame_info): Don't call
5080         tui_show_locator_content.
5081
5082 2019-08-30  Tom Tromey  <tom@tromey.com>
5083
5084         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
5085         (tui_locator_window::rerender): Rewrite using body of previous
5086         tui_show_locator_content.
5087
5088 2019-08-30  Tom Tromey  <tom@tromey.com>
5089
5090         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5091         set_locator_fullname>: New methods.
5092         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5093         Rename from tui_set_locator_fullname.
5094         (tui_locator_window::set_locator_info): Rename from
5095         tui_set_locator_info.  Return bool.
5096         (tui_update_locator_fullname, tui_show_frame_info): Update.
5097
5098 2019-08-30  Tom Tromey  <tom@tromey.com>
5099
5100         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5101
5102 2019-08-30  Tom Tromey  <tom@tromey.com>
5103
5104         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5105         call touchwin.
5106
5107 2019-08-30  Tom Tromey  <tom@tromey.com>
5108
5109         * tui/tui-wingeneral.c (box_win): Assume win_info and
5110         win_info->handle cannot be NULL.
5111
5112 2019-08-30  Tom Tromey  <tom@tromey.com>
5113
5114         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5115         refresh_window>: Declare.
5116         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5117         resize.
5118         (tui_data_item_window::rerender): Rename from
5119         tui_display_register.
5120         (tui_data_item_window::refresh_window): New method.
5121         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5122         no-op.
5123
5124 2019-08-30  Tom Tromey  <tom@tromey.com>
5125
5126         * tui/tui-regs.h (struct tui_data_window) <regs_content,
5127         regs_column_count, current_group>: Move later.  Now private.
5128         <get_current_group>: New method.
5129         * tui/tui-regs.c (tui_reg_command): Update.
5130         * tui/tui-layout.c (tui_set_layout): Update.
5131
5132 2019-08-30  Tom Tromey  <tom@tromey.com>
5133
5134         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5135         (tui_data_window::rerender): Don't call
5136         check_and_display_highlight_if_needed.
5137         (tui_data_window::refresh_all): Remove call to
5138         erase_data_content.
5139
5140 2019-08-30  Tom Tromey  <tom@tromey.com>
5141
5142         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5143         (tui_data_window::display_registers_from)
5144         (tui_data_window::display_reg_element_at_line)
5145         (tui_data_window::display_registers_from_line): Remove checks of
5146         "empty".
5147
5148 2019-08-30  Tom Tromey  <tom@tromey.com>
5149
5150         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5151         Don't declare.
5152         * tui/tui-regs.c (tui_data_window::show_registers): Call
5153         rerender.
5154         (tui_data_window::rerender): Rename from display_all_data.
5155         (tui_data_window::rerender): Remove old implementation.
5156
5157 2019-08-30  Tom Tromey  <tom@tromey.com>
5158
5159         * tui/tui-regs.c (tui_data_window::display_all_data): Change
5160         text.
5161         * tui/tui-data.h (NO_DATA_STRING): Remove define.
5162
5163 2019-08-29  Bernhard Wodok  <barto@gmx.net>
5164             Sergio Durigan Junior  <sergiodj@redhat.com>
5165
5166         PR win32/24284
5167         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5168
5169 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5170
5171         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5172         when searching for types.
5173
5174 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5175
5176         * f-lang.c (f_language_defn): Use f_print_typedef.
5177         * f-lang.h (f_print_typedef): Declare.
5178         * f-typeprint.c (f_print_typedef): Define.
5179
5180 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
5181
5182         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5183
5184 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5185
5186         * cli/cli-utils.c (info_print_options_defs): Delete.
5187         (make_info_print_options_def_group): Delete.
5188         (extract_info_print_options): Delete.
5189         (info_print_command_completer): Delete.
5190         (info_print_args_help): Add extra parameter, and optionally
5191         include text about -n flag.
5192         * cli/cli-utils.h (struct info_print_options): Delete.
5193         (extract_info_print_options): Delete declaration.
5194         (info_print_command_completer): Delete declaration.
5195         (info_print_args_help): Add extra parameter, extend header
5196         comment.
5197         * python/python.c (gdbpy_rbreak): Pass additional parameter to
5198         search_symbols.
5199         * stack.c (struct info_print_options): New type.
5200         (info_print_options_defs): New file scoped variable.
5201         (make_info_print_options_def_group): New static function.
5202         (info_print_command_completer): New static function.
5203         (info_locals_command): Update to use new local functions.
5204         (info_args_command): Likewise.
5205         (_initialize_stack): Add extra parameter to calls to
5206         info_print_args_help.
5207         * symtab.c (search_symbols): Add extra parameter, use this to
5208         possibly excluse non-debug symbols.
5209         (symtab_symbol_info): Add extra parameter, which is passed on to
5210         search_symbols.
5211         (struct info_print_options): New type.
5212         (info_print_options_defs): New file scoped variable.
5213         (make_info_print_options_def_group): New static function.
5214         (info_print_command_completer): New static function.
5215         (info_variables_command): Update to use local functions, and pass
5216         extra parameter through to symtab_symbol_info.
5217         (info_functions_command): Likewise.
5218         (info_types_command): Pass additional argument through to
5219         symtab_symbol_info.
5220         (rbreak_command): Pass extra argument to search_symbols.
5221         (_initialize_symtab): Add extra arguments for calls to
5222         info_print_args_help, and update help text for 'info variables',
5223         'whereis', and 'info functions' commands.
5224         * symtab.h (search_symbols): Add extra argument to declaration.
5225         * NEWS: Mention new flags.
5226
5227 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5228
5229         * symtab.c (lookup_static_symbol): Call the new function (and move
5230         it down to be next to lookup_global_symbol).
5231         (struct global_sym_lookup_data): Add block_enum member and rename to...
5232         (struct global_or_static_sym_lookup_data): ...this.
5233         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5234         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5235         (lookup_symbol_global_or_static_iterator_cb): ...this.
5236         (lookup_global_or_static_symbol): New function.
5237         (lookup_global_symbol): Call new function.
5238
5239 2019-08-26  Tom de Vries  <tdevries@suse.de>
5240
5241         PR c++/24852
5242         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5243         when pc_probe.prob == NULL.
5244
5245 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5246
5247         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5248         variable symbol_linkage to symbol_linkage_.
5249
5250 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5251
5252         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5253         represent whether the symbol is static, dynamic, or we don't
5254         know.
5255
5256 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5257
5258         * gdb/rx-tdep.c (rx_register_names): New.
5259         (rx_register_name): Delete.
5260         (rx_psw_type): Delete.
5261         (rx_fpsw_type): Delete.
5262         (rx_register_type): Delete.
5263         (rx_gdbarch_init): Convert target-descriptions.
5264         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5265         * gdb/features/Makefile: Add rx.xml.
5266         * gdb/features/rx.xml: New.
5267         * gdb/features/rx.c: Generated.
5268         * gdb/NEWS: Mention target description support.
5269
5270 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5271
5272         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5273         *slot_ptr.
5274
5275 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5276
5277         * configure.ac: Don't check for 'dlfcn.h' (moved to
5278         gdbsupport/common.m4).
5279         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5280         'gdbsupport/'.
5281         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5282         * compile/compile-c-support.c: Include
5283         'gdbsupport/gdb-dlfcn.h'.
5284         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5285         * gdb-dlfcn.c: Move to...
5286         * gdbsupport/gdb-dlfcn.c: ... here.
5287         * gdb-dlfcn.h: Move to...
5288         * gdbsupport/gdb-dlfcn.h: ... here.
5289
5290 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5291
5292         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5293         the offset field signed.
5294
5295 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5296
5297         * python/lib/gdb/__init__.py (_execute_file): New function.
5298         * python/python.c (python_run_simple_file): Call gdb._execute_file
5299         on Windows.
5300
5301 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5302
5303         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5304         all uses as this was never set to anything but a zero value.
5305
5306 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5307
5308         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5309
5310 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5311
5312         * tui/tui-data.h (tui_gen_win_info): Add an =default
5313         move constructor, required by some GCC versions.
5314
5315 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5316
5317         * go32-nat.c (go32_sysinfo): Add hygon_p.
5318
5319 2019-08-20  Tom Tromey  <tom@tromey.com>
5320
5321         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5322         line_from_reg_element_no, first_reg_element_no_inline,
5323         display_all_data, delete_data_content_windows,
5324         erase_data_content>: Now private.
5325
5326 2019-08-20  Tom Tromey  <tom@tromey.com>
5327
5328         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5329         (tui_unhighlight_win, tui_highlight_win)
5330         (tui_win_info::make_window): Update.
5331         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5332
5333 2019-08-20  Tom Tromey  <tom@tromey.com>
5334
5335         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5336         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5337         (MAX_PID_WIDTH): Move to tui-stack.c.
5338         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5339         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5340         (MAX_PID_WIDTH): Move from tui-data.h.
5341
5342 2019-08-20  Tom Tromey  <tom@tromey.com>
5343
5344         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5345         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5346         (box_win): Update.
5347         (tui_gen_win_info::make_window): Rename from tui_make_window.
5348         (tui_win_info::make_window): New method.
5349         (tui_gen_win_info::make_visible): Update.
5350         * tui/tui-source.c (tui_source_window::set_contents): Update.
5351         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5352         (tui_data_window::display_registers_from): Update.
5353         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5354         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5355         Declare.
5356         <can_box>: Remove.
5357         <title>: Remove.
5358         (struct tui_win_info) <make_window>: Declare.
5359         <can_box>: Now virtual.
5360         <title>: New member.
5361         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5362         * tui/tui-command.c (tui_cmd_window::resize): Update.
5363
5364 2019-08-20  Tom Tromey  <tom@tromey.com>
5365
5366         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5367         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5368         (tui_data_window::check_register_values): Update.
5369
5370 2019-08-20  Tom Tromey  <tom@tromey.com>
5371
5372         * tui/tui-regs.h (struct tui_data_window): Use
5373         DISABLE_COPY_AND_ASSIGN.
5374         <regs_content>: Change type, removing unique_ptr.
5375         <tui_data_window>: Add move constructor.
5376         * tui/tui-regs.c (tui_data_window::show_registers)
5377         (tui_data_window::show_register_group)
5378         (tui_data_window::display_registers_from)
5379         (tui_data_window::display_registers_from)
5380         (tui_data_window::first_data_item_displayed)
5381         (tui_data_window::delete_data_content_windows)
5382         (tui_data_window::rerender, tui_data_window::refresh_window)
5383         (tui_data_window::check_register_values): Update.
5384
5385 2019-08-20  Tom Tromey  <tom@tromey.com>
5386
5387         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5388         show_register_group>: Declare.
5389         (tui_show_register_group): Don't declare.
5390         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5391         tui_show_registers.
5392         (tui_data_window::show_register_group): Rename from
5393         tui_show_register_group.
5394         (tui_data_window::check_register_values, tui_reg_command):
5395         Update.
5396         * tui/tui-layout.c (tui_set_layout): Update.
5397
5398 2019-08-20  Tom Tromey  <tom@tromey.com>
5399
5400         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5401         Declare.
5402         (tui_check_register_values): Don't declare.
5403         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5404         from tui_check_register_values.
5405         * tui/tui-hooks.c (tui_register_changed): Update.
5406
5407 2019-08-20  Tom Tromey  <tom@tromey.com>
5408
5409         * tui/tui-regs.c (tui_reg_layout): Move later.
5410         (tui_show_registers): Don't enable TUI mode or change layout.
5411
5412 2019-08-20  Tom Tromey  <tom@tromey.com>
5413
5414         * tui/tui-regs.h (struct tui_data_item_window)
5415         <~tui_data_item_window>: Remove.
5416         <content>: Now a unique_xmalloc_ptr.
5417         * tui/tui-regs.c (tui_register_format): Return a
5418         unique_xmalloc_ptr.
5419         (tui_get_register): Update.
5420         (~tui_data_item_window): Remove.
5421         (tui_data_window::display_registers_from, tui_display_register):
5422         Update.
5423         * tui/tui-io.h (tui_expand_tabs): Update.
5424         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5425         Remove "col" parameter.
5426
5427 2019-08-20  Tom Tromey  <tom@tromey.com>
5428
5429         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5430         field.
5431         * tui/tui-regs.c (~tui_data_item_window): Update.
5432
5433 2019-08-20  Tom Tromey  <tom@tromey.com>
5434
5435         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5436         earlier.
5437
5438 2019-08-20  Tom Tromey  <tom@tromey.com>
5439
5440         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5441
5442 2019-08-20  Tom Tromey  <tom@tromey.com>
5443
5444         * tui/tui-source.h (struct tui_source_window): Update.
5445         * tui/tui-regs.c (tui_show_registers): Update.
5446         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5447         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5448         (NO_REGS_STRING): Remove defines.
5449
5450 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5451
5452         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5453         unnecessary thread walk if remote doesn't support the packet.
5454
5455 2019-08-19  Tom Tromey  <tromey@adacore.com>
5456
5457         * python/py-value.c (value_has_field): Fix indentation.
5458
5459 2019-08-19  Tom Tromey  <tromey@adacore.com>
5460
5461         * printcmd.c (do_one_display, info_display_command): Update.
5462         * block.h (contained_in): Return bool.  Add allow_nested
5463         parameter.
5464         * block.c (contained_in): Return bool.  Add allow_nested
5465         parameter.
5466
5467 2019-08-19  Tom Tromey  <tom@tromey.com>
5468
5469         * configure: Rebuild.
5470         * configure.ac: Disallow the combination of -static-libstdc++ and
5471         source highlight.
5472         * source-cache.c (get_language_name): Handle rust.
5473         (source_cache::get_source_lines): Ignore highlighting exceptions.
5474
5475 2019-08-16  Tom Tromey  <tom@tromey.com>
5476
5477         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5478         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5479         (struct tui_source_window_base) <make_visible, refresh_window,
5480         resize>: Remove methods.
5481         <execution_info>: Remove field.
5482         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5483         (tui_show_source_line, tui_source_window_base)
5484         (~tui_source_window_base): Update.
5485         (tui_source_window_base::resize)
5486         (tui_source_window_base::make_visible)
5487         (tui_source_window_base::refresh_window): Remove.
5488         (tui_source_window_base::update_exec_info): Update.
5489         * tui/tui-source.c (tui_source_window::set_contents): Update.
5490         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5491
5492 2019-08-16  Tom Tromey  <tom@tromey.com>
5493
5494         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5495         deprecated_query_hook.
5496
5497 2019-08-16  Tom Tromey  <tom@tromey.com>
5498
5499         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5500         (tui_update_source_windows_with_line): Update.
5501         * tui/tui-source.h (struct tui_source_window)
5502         <show_symtab_source>: Declare.
5503         (tui_show_symtab_source): Don't declare.
5504         * tui/tui-source.c (tui_show_symtab_source): Rename from
5505         tui_show_symtab_source.
5506
5507 2019-08-16  Tom Tromey  <tom@tromey.com>
5508
5509         * tui/tui-winsource.h (struct tui_source_window_base)
5510         <set_contents>: Declare.
5511         * tui/tui-winsource.c
5512         (tui_source_window_base::update_source_window_as_is): Update.
5513         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5514         Declare.
5515         (tui_set_source_content): Don't declare.
5516         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5517         tui_set_source_content.
5518         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5519         Declare.
5520         (tui_set_disassem_content): Don't declare.
5521         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5522         tui_set_disassem_content.
5523
5524 2019-08-16  Tom Tromey  <tom@tromey.com>
5525
5526         * tui/tui-winsource.h (struct tui_source_window_base)
5527         <update_breakpoint_info>: Declare.
5528         (tui_update_breakpoint_info): Don't declare.
5529         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5530         (tui_update_all_breakpoint_info): Update.
5531         (tui_source_window_base::update_breakpoint_info): Rename from
5532         tui_update_breakpoint_info.
5533         (tui_source_window_base::update_exec_info): Update.
5534
5535 2019-08-16  Tom Tromey  <tom@tromey.com>
5536
5537         * tui/tui-winsource.h (struct tui_source_window_base)
5538         <update_source_window>: Declare.
5539         (tui_update_source_window): Don't declare.
5540         * tui/tui-winsource.c
5541         (tui_source_window_base::update_source_window): Rename from
5542         tui_update_source_window.
5543         (tui_source_window_base::rerender): Update.
5544         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5545         * tui/tui-disasm.c (tui_show_disassem)
5546         (tui_show_disassem_and_update_source)
5547         (tui_disasm_window::maybe_update): Update.
5548
5549 2019-08-16  Tom Tromey  <tom@tromey.com>
5550
5551         * tui/tui-winsource.h (struct tui_source_window_base)
5552         <update_source_window_as_is>: Declare.
5553         (tui_update_source_window_as_is): Don't declare.
5554         * tui/tui-winsource.c (tui_update_source_window): Update
5555         (tui_source_window_base::update_source_window_as_is): Rename from
5556         tui_update_source_window_as_is.
5557         (tui_source_window_base::refill): Update.
5558         * tui/tui-source.c (tui_show_symtab_source): Update.
5559         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5560         Update.
5561
5562 2019-08-16  Tom Tromey  <tom@tromey.com>
5563
5564         * tui/tui-winsource.h (tui_update_source_window)
5565         (tui_update_source_window_as_is): Remove "noerror" parameter.
5566         * tui/tui-winsource.c (tui_update_source_window)
5567         (tui_update_source_window_as_is): Remove "noerror" parameter.
5568         (tui_update_source_windows_with_addr)
5569         (tui_update_source_windows_with_line)
5570         (tui_source_window_base::rerender)
5571         (tui_source_window_base::refill): Update.
5572         * tui/tui-source.h (tui_set_source_content)
5573         (tui_show_symtab_source): Remove "noerror" parameter.
5574         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5575         parameter.
5576         (tui_show_symtab_source): Likewise.
5577         (tui_source_window::maybe_update): Update.
5578         * tui/tui-disasm.c (tui_show_disassem)
5579         (tui_show_disassem_and_update_source)
5580         (tui_disasm_window::do_scroll_vertical)
5581         (tui_disasm_window::maybe_update): Update.
5582
5583 2019-08-16  Tom Tromey  <tom@tromey.com>
5584
5585         * tui/tui.c (tui_is_window_visible): Update.
5586         * tui/tui-wingeneral.c (tui_make_window)
5587         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5588         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5589         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5590         (tui_set_win_height_command, parse_scrolling_args): Update.
5591         * tui/tui-source.c (tui_source_window::style_changed): Update.
5592         * tui/tui-regs.c (tui_show_registers)
5593         (tui_data_window::first_data_item_displayed)
5594         (tui_data_window::delete_data_content_windows)
5595         (tui_check_register_values, tui_reg_command): Update.
5596         * tui/tui-disasm.c (tui_show_disassem): Update.
5597         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5598         method.
5599         <is_visible>: Remove field.
5600         * tui/tui-data.c (tui_next_win, tui_prev_win)
5601         (tui_delete_invisible_windows): Update.
5602
5603 2019-08-16  Tom Tromey  <tom@tromey.com>
5604
5605         * tui/tui-winsource.h (struct tui_source_window_base)
5606         <m_has_locator>: Remove.
5607         * tui/tui-layout.c (show_source_disasm_command, show_data)
5608         (show_source_or_disasm_and_command): Update.
5609
5610 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5611
5612         * NEWS (Other MI changes): New subsection.
5613         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5614         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5615         * arch-utils.c (default_get_pc_address_flags): New function.
5616         * arch-utils.h (default_get_pc_address_flags): New declaration.
5617         * gdbarch.sh: Add get_pc_address_flags.
5618         * gdbarch.c: Regenerate.
5619         * gdbarch.h: Likewise.
5620         * stack.c (print_pc): New function.
5621         (print_frame_info) (print_frame): Call print_pc.
5622
5623 2019-08-16  Tom de Vries  <tdevries@suse.de>
5624
5625         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5626         print_objfile_section_info.
5627
5628 2019-08-15  Tom Tromey  <tom@tromey.com>
5629
5630         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5631         calling update_cmdwin_start_line.
5632         * tui/tui-winsource.h (struct tui_source_window_base)
5633         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5634         <rerender>: Declare.
5635         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5636         Call rerender.
5637         (tui_source_window_base::set_new_height): Remove.
5638         (tui_source_window_base::rerender): Rename from
5639         do_make_visible_with_new_height.
5640         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5641         resize method.
5642         (tui_win_info::make_invisible_and_set_new_height)
5643         (tui_win_info::make_visible_with_new_height): Remove.
5644         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5645         Declare.
5646         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5647         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5648         do_make_visible_with_new_height>: Don't declare.
5649         <rerender>: Declare.
5650         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5651         set_new_height.
5652         (tui_data_window::do_make_visible_with_new_height): Remove.
5653         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5654         call tui_show_locator_content.
5655         (tui_gen_win_info::resize): Call rerender.
5656         (show_source_or_disasm_and_command): Don't call
5657         tui_show_locator_content.
5658         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5659         method.
5660         (struct tui_win_info) <rerender>: Declare.
5661         <set_new_height, make_invisible_and_set_new_height,
5662         make_visible_with_new_height>: Don't declare.
5663         * tui/tui-data.c (tui_win_list::rerender): New method.
5664         * tui/tui-command.h (struct tui_cmd_window)
5665         <do_make_visible_with_new_height>: Don't declare.
5666         * tui/tui-command.c
5667         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5668
5669 2019-08-15  Tom Tromey  <tromey@adacore.com>
5670
5671         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5672         * ada-lang.c (ada_enum_name): Likewise.
5673
5674 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5675
5676         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5677         leading underscore.
5678         (GdbOutputErrorFile): Likewise.
5679         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5680         accordingly.
5681         (execute_unwinders): Rename to have a leading underscore.
5682         (auto_load_packages): Likewise.
5683         (global scope): Adjust call to auto_load_packages accordingly.
5684         (GdbSetPythonDirectory): Likewise.
5685         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5686         instead of execute_unwinders.
5687
5688 2019-08-15  Tom Tromey  <tom@tromey.com>
5689
5690         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5691         (show_data): Don't change window visibility.
5692         (tui_gen_win_info::resize): Remove special case for command
5693         window.  Use wresize, when available.
5694         (show_source_or_disasm_and_command): Don't change window
5695         visibility.
5696         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5697         <make_visible>: New method.
5698         * tui/tui-command.c (tui_cmd_window::resize): New method.
5699
5700 2019-08-15  Tom Tromey  <tom@tromey.com>
5701
5702         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5703         (struct tui_source_windows): New.
5704         * tui/tui-winsource.c (tui_display_main): Update.
5705         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5706         (new_height_ok, parse_scrolling_args): Update.
5707         * tui/tui-layout.c (show_layout, show_data): Update.
5708         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5709         (tui_add_to_source_windows): Don't declare.
5710         * tui/tui-data.c (source_windows, tui_source_windows)
5711         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5712
5713 2019-08-15  Tom Tromey  <tom@tromey.com>
5714
5715         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5716         Rename from reset.
5717         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5718         * tui/tui-layout.c (show_source_disasm_command, show_data):
5719         Update.
5720         (tui_gen_win_info::resize): Rename.
5721         (show_source_or_disasm_and_command): Update.
5722         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5723         reset.
5724
5725 2019-08-15  Tom Tromey  <tom@tromey.com>
5726
5727         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5728         * tui/tui-interp.c (tui_interp::init): Don't call
5729         tui_initialize_static_data.
5730         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5731
5732 2019-08-15  Tom Tromey  <tom@tromey.com>
5733
5734         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5735         examine tui_win_list.
5736
5737 2019-08-15  Tom Tromey  <tom@tromey.com>
5738
5739         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5740         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5741         tui_clear_source_content.
5742         (tui_clear_source_content): Remove.
5743         (tui_source_window_base::do_erase_source_content): Hoist call to
5744         content.clear().
5745         * tui/tui-stack.c (tui_show_frame_info): Don't call
5746         tui_clear_source_content.
5747
5748 2019-08-15  Tom Tromey  <tom@tromey.com>
5749
5750         * tui/tui-winsource.h (struct tui_source_window_base)
5751         <do_erase_source_content>: New method.
5752         <erase_source_content>: New method.
5753         (tui_erase_source_content): Don't declare.
5754         * tui/tui-winsource.c (tui_clear_source_content): Update.
5755         (tui_source_window_base::do_erase_source_content): Rename from
5756         tui_erase_source_content.
5757         (tui_source_window_base::show_source_content): Update.
5758         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5759         * tui/tui-source.h (struct tui_source_window)
5760         <erase_source_content>: New method.
5761         * tui/tui-disasm.h (struct tui_disasm_window)
5762         <erase_source_content>: New method.
5763
5764 2019-08-15  Tom Tromey  <tom@tromey.com>
5765
5766         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5767         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5768         constructor.
5769         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5770         * tui/tui-source.c (tui_set_source_content): Update.
5771         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5772
5773 2019-08-15  Tom Tromey  <tom@tromey.com>
5774
5775         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5776         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5777         tui-source.c.
5778         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5779         Declare.
5780         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5781         method.
5782         (tui_source_window::maybe_update): Update.
5783
5784 2019-08-15  Tom Tromey  <tom@tromey.com>
5785
5786         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5787         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5788         tui-disasm.c.
5789         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5790         Declare.
5791         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5792         method.
5793         (tui_disasm_window::maybe_update): Update.
5794
5795 2019-08-15  Tom Tromey  <tom@tromey.com>
5796
5797         * tui/tui-winsource.h (struct tui_source_window_base)
5798         <maybe_update>: Declare.
5799         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5800         method.
5801         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5802         Declare.
5803         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5804         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5805         Declare.
5806         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5807
5808 2019-08-15  Tom Tromey  <tom@tromey.com>
5809
5810         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5811
5812 2019-08-15  Tom Tromey  <tom@tromey.com>
5813
5814         * tui/tui-wingeneral.c: Include tui-stack.h.
5815         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5816         (struct tui_locator_window): Move from tui-data.h.
5817         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5818         (tui_initialize_static_data): Move from tui-data.c.
5819         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5820         (struct tui_locator_window): Move to tui-stack.c.
5821         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5822         (tui_initialize_static_data): Move to tui-stack.c.
5823
5824 2019-08-15  Tom Tromey  <tom@tromey.com>
5825
5826         * tui/tui-layout.c (show_source_disasm_command)
5827         (show_source_or_disasm_and_command): Use make_visible method, not
5828         tui_make_window.
5829         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5830         Remove.
5831
5832 2019-08-15  Tom Tromey  <tom@tromey.com>
5833
5834         * tui/tui-wingeneral.h (tui_make_window): Update.
5835         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5836         parameter.
5837         (tui_gen_win_info::make_visible): Update.
5838         * tui/tui-regs.c (tui_data_window::display_registers_from):
5839         Update.
5840         * tui/tui-layout.c (show_source_disasm_command)
5841         (show_source_or_disasm_and_command): Update.
5842         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5843         (enum tui_box): Remove.
5844         (struct tui_win_info) <can_box>: New method.
5845         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5846         method.
5847
5848 2019-08-15  Tom de Vries  <tdevries@suse.de>
5849
5850         * linux-nat-trad.c: Include gdbarch.h.
5851
5852 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5853
5854         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5855         register sizes.
5856
5857 2019-08-14  Tom Tromey  <tromey@adacore.com>
5858
5859         * darwin-nat.c: Include gdbarch.h.
5860         * darwin-nat-info.c: Include gdbarch.h.
5861
5862 2019-08-13  Tom Tromey  <tom@tromey.com>
5863
5864         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5865         Remove.
5866         * tui/tui-data.c (tui_initialize_static_data): Update.
5867
5868 2019-08-13  Tom Tromey  <tom@tromey.com>
5869
5870         * tui/tui-winsource.h (struct tui_exec_info_window)
5871         <~tui_exec_info_window, maybe_allocate_content, get_content,
5872         m_content>: Remove.
5873         (struct tui_source_window_base) <set_exec_info_content,
5874         show_exec_info_content>: Don't declare.
5875         * tui/tui-winsource.c
5876         (tui_exec_info_window::maybe_allocate_content): Remove.
5877         (tui_source_window_base::update_exec_info): Rename from
5878         set_exec_info_content.
5879         (tui_source_window_base::show_exec_info_content)
5880         (tui_source_window_base::update_exec_info): Remove.
5881
5882 2019-08-13  Tom Tromey  <tom@tromey.com>
5883
5884         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5885         declare.
5886         * tui/tui-winsource.c (tui_update_source_window_as_is)
5887         (tui_update_source_windows_with_addr, tui_erase_source_content):
5888         Update.
5889         (tui_clear_exec_info_content): Remove.
5890
5891 2019-08-13  Tom Tromey  <tom@tromey.com>
5892
5893         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5894         declare.
5895         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5896         call tui_erase_exec_info_content.
5897         (tui_clear_exec_info_content): Rename from
5898         tui_erase_exec_info_content.
5899         (tui_clear_exec_info_content): Delete.
5900
5901 2019-08-13  Tom Tromey  <tom@tromey.com>
5902
5903         * tui/tui-winsource.h (struct tui_source_window_base)
5904         <show_exec_info_content>: Declare.
5905         (tui_show_exec_info_content): Don't declare.
5906         * tui/tui-winsource.c
5907         (tui_source_window_base::show_exec_info_content): Rename from
5908         tui_show_exec_info_content.
5909         (tui_source_window_base::update_exec_info): Update.
5910
5911 2019-08-13  Tom Tromey  <tom@tromey.com>
5912
5913         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5914         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5915         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5916         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5917         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5918         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5919         ... here.
5920
5921 2019-08-13  Tom Tromey  <tom@tromey.com>
5922
5923         * tui/tui-winsource.h (struct tui_source_window_base)
5924         <update_exec_info>: Declare.
5925         (tui_update_exec_info): Don't declare.
5926         * tui/tui-winsource.c (tui_update_source_window_as_is)
5927         (tui_source_window_base::refresh_all)
5928         (tui_update_all_breakpoint_info): Update.
5929         (tui_source_window_base::update_exec_info): Rename from
5930         tui_update_exec_info.
5931         * tui/tui-stack.c (tui_show_frame_info): Update.
5932
5933 2019-08-13  Tom Tromey  <tom@tromey.com>
5934
5935         * tui/tui-winsource.h (struct tui_source_window_base)
5936         <set_exec_info_content>: Declare.
5937         (tui_set_exec_info_content): Don't declare.
5938         * tui/tui-winsource.c
5939         (tui_source_window_base::set_exec_info_content): Rename from
5940         tui_set_exec_info_content.
5941         (tui_update_exec_info): Update.
5942
5943 2019-08-13  Tom Tromey  <tom@tromey.com>
5944
5945         * tui/tui-winsource.h (struct tui_source_window_base)
5946         <show_source_content>: Declare.
5947         (tui_show_source_content): Don't declare.
5948         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5949         (tui_source_window_base::show_source_content): Rename from
5950         tui_show_source_content.
5951         (tui_source_window_base::refresh_all): Update.
5952         * tui/tui-layout.c (show_source_disasm_command)
5953         (show_source_or_disasm_and_command): Update.
5954
5955 2019-08-13  Tom Tromey  <tom@tromey.com>
5956
5957         * tui/tui-winsource.c (tui_erase_source_content)
5958         (tui_show_source_content, tui_source_window_base::refresh_all):
5959         Update.
5960         * tui/tui-wingeneral.h
5961         (tui_check_and_display_highlight_if_needed): Don't declare.
5962         * tui/tui-wingeneral.c
5963         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5964         check_and_display_highlight_if_needed.
5965         * tui/tui-win.c (tui_rehighlight_all)
5966         (tui_win_info::make_visible_with_new_height): Update.
5967         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5968         (tui_data_window::erase_data_content)
5969         (tui_data_window::display_all_data): Update.
5970         * tui/tui-data.h (struct tui_win_info)
5971         <check_and_display_highlight_if_needed>: Declare.
5972
5973 2019-08-13  Tom Tromey  <tom@tromey.com>
5974
5975         * tui/tui-win.c (tui_resize_all): Call
5976         tui_delete_invisible_windows.
5977         * tui/tui-layout.c (show_layout): Call
5978         tui_delete_invisible_windows.
5979         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5980         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5981
5982 2019-08-13  Tom Tromey  <tom@tromey.com>
5983
5984         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5985         tui_add_win_to_layout.
5986
5987 2019-08-13  Tom Tromey  <tom@tromey.com>
5988
5989         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5990         * tui/tui-layout.c (tui_default_win_height): Now static.
5991
5992 2019-08-13  Tom Tromey  <tom@tromey.com>
5993
5994         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5995         single switch.
5996         (show_source_disasm_command, show_source_or_disasm_and_command):
5997         Don't check current layout.
5998
5999 2019-08-13  Tom Tromey  <tom@tromey.com>
6000
6001         * tui/tui-wingeneral.c (make_all_visible): Remove.
6002         (tui_make_all_invisible): Simplify.
6003         * tui/tui-layout.c (tui_make_all_invisible): Move from
6004         tui-wingeneral.c; simplify.
6005         (show_layout): Hoist call to tui_make_all_invisible.
6006         (show_data): Don't call tui_make_all_invisible.
6007
6008 2019-08-13  Tom Tromey  <tom@tromey.com>
6009
6010         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
6011         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
6012
6013 2019-08-13  Tom Tromey  <tom@tromey.com>
6014
6015         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
6016         tui-data.c.
6017         (show_source_disasm_command, show_data)
6018         (show_source_or_disasm_and_command): Don't use
6019         tui_set_current_layout_to.
6020         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
6021         * tui/tui-data.c (current_layout, tui_current_layout): Move to
6022         tui-layout.c.
6023         (tui_set_current_layout_to): Remove.
6024
6025 2019-08-13  Tom Tromey  <tom@tromey.com>
6026
6027         * tui/tui-layout.c (tui_set_layout): Update.
6028         * tui/tui-data.h (struct tui_layout_def): Remove.
6029         (tui_layout_def): Don't declare.
6030         * tui/tui-data.c (layout_def): Remove.
6031         (tui_layout_def): Remove.
6032
6033 2019-08-13  Tom Tromey  <tom@tromey.com>
6034
6035         * tui/tui-winsource.h (struct tui_source_window_base)
6036         <clear_detail>: No longer "override".
6037         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
6038         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
6039         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
6040         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
6041         Remove.
6042         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
6043
6044 2019-08-13  Tom Tromey  <tromey@adacore.com>
6045
6046         * tracepoint.c: Don't include readline.h or history.h.
6047
6048 2019-08-12  Tom Tromey  <tom@tromey.com>
6049
6050         * configure: Rebuild.
6051         * configure.ac: Check for readline 7.
6052         * NEWS: Mention readline 7 requirement.
6053         * README: Update.
6054
6055 2019-08-12  Tom Tromey  <tom@tromey.com>
6056
6057         * mingw-hdep.c (gdb_select): Remove readline hack.
6058
6059 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6060
6061         * blockframe.c (find_pc_partial_function): Set *block to nullptr
6062         when the function fails.
6063
6064 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
6065
6066         * s390-tdep.c (s390_type_align): New function.
6067         (s390_gdbarch_init): Set it as type_align gdbarch method.
6068
6069 2019-08-09  Tom de Vries  <tdevries@suse.de>
6070
6071         PR gdb/24591
6072         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
6073         pc_low with relocation offset.
6074
6075 2019-08-07  Tom Tromey  <tromey@adacore.com>
6076
6077         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6078         (print_frame_args): Update.
6079         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
6080         Update.
6081         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6082         * frame.h (struct frame_arg): Add initializers.
6083         <error>: Now a unique_xmalloc_ptr.
6084
6085 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
6086
6087         * NEWS: Expand the Pointer Authentication entry.
6088         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6089         (aarch64_frame_unmask_lr): ... to this.
6090         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6091         Call aarch64_frame_unmask_lr.
6092         * frame.c (struct frame_info): Add "masked" variable.
6093         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6094         (fprint_frame): Check for masked pc.
6095         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6096         declarations.
6097         * python/py-framefilter.c (py_print_frame): Check for masked pc.
6098         * stack.c (print_frame): Check for masked pc.
6099
6100 2019-08-06  Tom Tromey  <tom@tromey.com>
6101
6102         * stabsread.c (patch_block_stabs, read_one_struct_field)
6103         (read_enum_type): Use obstack_strndup.
6104         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6105         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6106         * dwarf2read.c (guess_full_die_structure_name)
6107         (anonymous_struct_prefix): Use obstack_strndup.
6108         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6109         * c-exp.y (yylex): Use obstack_strndup.
6110         * ada-exp.y (write_object_renaming, write_ambiguous_var)
6111         (write_var_or_type): Use obstack_strndup.
6112
6113 2019-08-06  Tom Tromey  <tom@tromey.com>
6114
6115         * symfile.c (reread_symbols): Use obstack_strdup.
6116         * stabsread.c (read_type): Use obstack_strdup.
6117         * gdb_obstack.h (obstack_strdup): New overload.
6118         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6119         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6120         (dwarf2_canonicalize_name): Use obstack_strdup.
6121         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6122         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6123         Use obstack_strdup.
6124
6125 2019-08-06  Tom Tromey  <tom@tromey.com>
6126
6127         * gdb_obstack.h (obstack_strdup): Define.
6128         * gdb_obstack.c (obstack_strdup): Don't define.
6129
6130 2019-08-06  Tom Tromey  <tom@tromey.com>
6131
6132         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6133         obstack_strdup.
6134         * typeprint.c (typedef_hash_table::find_global_typedef): Use
6135         obstack_strdup.
6136         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6137         * stabsread.c (common_block_start): Use obstack_strdup.
6138         * objfiles.c (set_objfile_main_name, objfile): Use
6139         obstack_strdup.
6140         * namespace.c (add_using_directive): Use obstack_strdup.
6141         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6142         * jit.c (finalize_symtab): Use obstack_strdup.
6143         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6144         (guess_partial_die_structure_name, partial_die_info::fixup)
6145         (dwarf2_name): Use obstack_strdup.
6146         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6147         obstack_strdup.
6148         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6149         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6150         obstack_strdup.
6151         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6152
6153 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6154
6155         * unittests/help-doc-selftests.c: New file.
6156         * Makefile.in: Add the new file.
6157
6158 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6159
6160         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6161         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
6162         the full first line, except when FOR_VALUE_PREFIX.  In this case,
6163         the trailing '.' is not output, and the first character is uppercased.
6164         (print_help_for_command): Update call to print_doc_line.
6165         (print_doc_of_command): Likewise.
6166         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6167         * cli/cli-option.c (append_indented_doc): Do not append newline.
6168         (build_help_option): Append newline after first appended_indented_doc
6169         only if a second call is done.
6170         (build_help): Append 2 new lines before each option, except the first
6171         one.
6172         * compile/compile.c (_initialize_compile): Add new lines after
6173         %OPTIONS%, when not at the end of the help.
6174         Change help doc or code
6175         producing the help doc to respect the invariants.
6176         * maint-test-options.c (_initialize_maint_test_options): Likewise.
6177         Also removed the new line after 'Options:', as all other commands
6178         do not put an empty line between 'Options:' and the first option.
6179         * printcmd.c (_initialize_printcmd): Likewise.
6180         * stack.c (_initialize_stack): Likewise.
6181         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6182         incorrectly telling COMMAND is optional.
6183         * ada-lang.c (_initialize_ada_language): Change help doc or code
6184         producing the help doc to respect the invariants.
6185         * ada-tasks.c (_initialize_ada_tasks): Likewise.
6186         * breakpoint.c (_initialize_breakpoint): Likewise.
6187         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6188         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6189         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6190         * cli/cli-style.c (cli_style_option::add_setshow_commands,
6191         _initialize_cli_style): Likewise.
6192         * corelow.c (core_target_info): Likewise.
6193         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6194         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6195         * filesystem.c (_initialize_filesystem): Likewise.
6196         * frame.c (_initialize_frame): Likewise.
6197         * gnu-nat.c (add_task_commands): Likewise.
6198         * infcall.c (_initialize_infcall): Likewise.
6199         * infcmd.c (_initialize_infcmd): Likewise.
6200         * interps.c (_initialize_interpreter): Likewise.
6201         * language.c (_initialize_language): Likewise.
6202         * linux-fork.c (_initialize_linux_fork): Likewise.
6203         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6204         * maint.c (_initialize_maint_cmds): Likewise.
6205         * memattr.c (_initialize_mem): Likewise.
6206         * printcmd.c (_initialize_printcmd): Likewise.
6207         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6208         _RegEx): Likewise.
6209         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6210         * record-btrace.c (_initialize_record_btrace): Likewise.
6211         * record-full.c (_initialize_record_full): Likewise.
6212         * record.c (_initialize_record): Likewise.
6213         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6214         * regcache.c (_initialize_regcache): Likewise.
6215         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6216         _initialize_remote): Likewise.
6217         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6218         * serial.c (_initialize_serial): Likewise.
6219         * skip.c (_initialize_step_skip): Likewise.
6220         * source.c (_initialize_source): Likewise.
6221         * stack.c (_initialize_stack): Likewise.
6222         * symfile.c (_initialize_symfile): Likewise.
6223         * symtab.c (_initialize_symtab): Likewise.
6224         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6225         * top.c (init_main): Likewise.
6226         * tracefile-tfile.c (tfile_target_info): Likewise.
6227         * tracepoint.c (_initialize_tracepoint): Likewise.
6228         * tui/tui-win.c (_initialize_tui_win): Likewise.
6229         * utils.c (add_internal_problem_command): Likewise.
6230         * valprint.c (value_print_option_defs): Likewise.
6231
6232 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6233
6234         PR build/24886
6235         * configure.ac: Drop enable-libmcheck support.
6236         * configure, config.in: Rebuild.
6237         * libmcheck.m4: Remove.
6238         * acinclude.m4: Don't include it.
6239         * Makefile.in: Don't distribute it.
6240         * top.c (print_gdb_configuration): Don't mention it.
6241
6242 2019-08-06  Tom Tromey  <tom@tromey.com>
6243
6244         * utils.c (set_output_style): Sometimes pass stream to
6245         emit_style_escape.
6246         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6247         * record-btrace.c (btrace_insn_history): Update.
6248         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6249         method.
6250         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6251         Update initializers.
6252         <m_uiout>: New field.
6253         <m_di>: Move lower.
6254         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6255         Remove "uiout" parameter.
6256         (dump_insns): Update.
6257         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6258         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6259
6260 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6261
6262         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6263         (error_in_psymtab_expansion): Likewise.
6264         (lookup_symbol_via_quick_fns): Likewise.
6265         (basic_lookup_transparent_type_quick): Likewise.
6266         (basic_lookup_transparent_type_1): Likewise.
6267
6268 2019-08-06  Tom Tromey  <tromey@adacore.com>
6269
6270         * source.c (last_source_error): Now bool.
6271         (print_source_lines_base): Make "noprint" bool.  Only open
6272         source file when last_source_visited changes.
6273
6274 2019-08-06  Tom Tromey  <tromey@adacore.com>
6275
6276         * annotate.c (annotate_source_line): Use g_source_cache.
6277         * source-cache.c (source_cache::get_plain_source_lines): Change
6278         parameters.  Populate m_offset_cache.
6279         (source_cache::ensure): New method.
6280         (source_cache::get_line_charpos): New method.
6281         (extract_lines): Move lower.  Change parameters.
6282         (source_cache::get_source_lines): Move lower.
6283         * source-cache.h (class source_cache): Update comment.
6284         <get_line_charpos>: New method.
6285         <get_source_lines>: Update comment.
6286         <clear>: Clear m_offset_cache.
6287         <get_plain_source_lines>: Change parameters.
6288         <ensure>: New method
6289         <m_offset_cache>: New member.
6290         * source.c (forget_cached_source_info_for_objfile): Update.
6291         (info_source_command): Use g_source_cache.
6292         (find_source_lines, open_source_file_with_line_charpos): Remove.
6293         (print_source_lines_base, search_command_helper): Use g_source_cache.
6294         * source.h (open_source_file_with_line_charpos): Don't declare.
6295         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6296         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6297         Use g_source_cache.
6298
6299 2019-08-06  Tom Tromey  <tromey@adacore.com>
6300
6301         * source-cache.c (source_cache::get_plain_source_lines):
6302         Remove "first_line" and "last_line" parameters.
6303         (source_cache::get_source_lines): Cache plain text.
6304         * source-cache.h (class source_cache)
6305         <get_plain_source_lines>: Update.
6306
6307 2019-08-06  Tom Tromey  <tromey@adacore.com>
6308
6309         * source-cache.c (extract_lines): No longer a method.
6310         Changed type of parameter.  Include final newline.
6311         (selftests::extract_lines_test): New function.
6312         (_initialize_source_cache): Likewise.
6313         * source-cache.h (class source_cache)
6314         <extract_lines>: Don't declare.
6315
6316 2019-08-06  Tom Tromey  <tromey@adacore.com>
6317
6318         * breakpoint.c (init_breakpoint_sal): Update.
6319         (breakpoint): Update.
6320         * breakpoint.h (struct breakpoint) <filter>: Now a
6321         unique_xmalloc_ptr.
6322
6323 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6324
6325         * NEWS: Mention dictionary access on blocks.
6326         * python/py-block.c (blpy_getitem): New function.
6327         (block_object_as_mapping): New struct.
6328         (block_object_type): Use new struct for tp_as_mapping field.
6329
6330 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6331
6332         * objfiles.h (objfile): Add a comment describing partial symbols.
6333
6334 2019-08-05  Tom Tromey  <tromey@adacore.com>
6335
6336         * compile/compile.c (_initialize_compile): Use _(), not N_().
6337         * thread.c (_initialize_thread): Use _(), not N_().
6338         * stack.c (_initialize_stack): Use _(), not N_().
6339         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6340
6341 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6342
6343         * dwarf2read.c (struct dw2_symtab_iterator):
6344         <want_specific_block>: Remove.
6345         <block_index>: Change type to gdb::optional.
6346         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6347         change type of BLOCK_INDEX parameter to gdb::optional.
6348         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6349         (dw2_lookup_symbol): Don't pass argument for
6350         WANT_SPECIFIC_BLOCK.
6351         (dw2_expand_symtabs_for_function): Don't pass argument for
6352         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6353         (class dw2_debug_names_iterator)
6354         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6355         parameter, change BLOCK_INDEX type to gdb::optional.
6356         <m_want_specific_block>: Remove.
6357         <m_block_index>: Change type to gdb::optional.
6358         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6359         gdb::optional.  Re-write in function of gdb::optional.
6360         (dw2_debug_names_lookup_symbol): Don't pass argument for
6361         WANT_SPECIFIC_BLOCK.
6362         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6363         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6364         BLOCK_INDEX.
6365
6366 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6367
6368         * NEWS: Mention changes to "info sources" command.
6369
6370 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6371
6372         * symtab.c (filename_partial_match_opts): New struct type.
6373         (struct output_source_filename_data): New members
6374         regexp, c_regexp, partial_match.
6375         (output_source_filename): Use new members to decide to print file.
6376         (info_sources_option_defs): New variable.
6377         (make_info_sources_options_def_group, print_info_sources_header,
6378         info_sources_command_completer):
6379         New functions.
6380         (info_sources_command): Read new optional arguments.
6381         (_initialize_symtab): Update info sources help.
6382
6383 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6384
6385         * ada-lang.c (exception_support_info_v0): Renamed from...
6386         (default_exception_support_info): ... this.  Create new
6387         definition for v1.
6388         (ada_has_this_exception_support): Look up catch_handlers_sym.
6389         (ada_exception_support_info_sniffer): Try v0 after default.
6390
6391 2019-08-01  Tom Tromey  <tromey@adacore.com>
6392
6393         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6394         gdbarch.h.
6395
6396 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6397
6398         * s12z-tdep.c: Fix include path for s12z-opc.h.
6399
6400 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6401
6402         * NEWS: Require GNU make 3.82.
6403
6404 2019-07-16  Tom Tromey  <tom@tromey.com>
6405
6406         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6407         declare.
6408
6409 2019-07-30  Tom Tromey  <tromey@adacore.com>
6410
6411         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6412
6413 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6414
6415         * printcmd.c (print_address_symbolic): Print negative offsets.
6416         (build_address_symbolic): Force signed arithmetic when computing
6417         offset.
6418
6419 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6420
6421         PR/24474: Add a function to lookup static variables.
6422         * NEWS: Mention this new function.
6423         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6424         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6425         * python/python.c (python_GdbMethods): Add new function.
6426
6427 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6428
6429         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6430         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6431         (objfpy_lookup_static_symbol): New function.
6432         (objfile_object_methods): Add new functions.
6433
6434 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6435
6436         * NEWS: Mention 'set|show print frame-info'.  Mention new
6437         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6438         backtrace argument.  Mention that python frame filtering code
6439         is now consistent with what 'backtrace' command prints.
6440
6441 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6442
6443         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6444         comments.
6445         (print_frame_info_auto, print_frame_info_source_line,
6446         print_frame_info_location, print_frame_info_source_and_location,
6447         print_frame_info_location_and_address, print_frame_info_short_location):
6448         New declarations.
6449         (struct frame_print_options): New member print_frame_info.
6450         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6451         * stack.h (get_user_print_what_frame_info): New declaration.
6452         (frame_show_address): New declaration.
6453         * stack.c (print_frame_arguments_choices): New value 'presence'.
6454         (print_frame_info_auto, print_frame_info_source_line,
6455         print_frame_info_location, print_frame_info_source_and_location,
6456         print_frame_info_location_and_address, print_frame_info_short_location,
6457         print_frame_info_choices, print_frame_info_print_what): New definitions.
6458         (print_frame_args): Only print dots for args if print frame-arguments
6459         is 'presence'.
6460         (frame_print_option_defs): New element for "frame-info".
6461         (get_user_print_what_frame_info): New function.
6462         (frame_show_address): Make non static.  Move comment to stack.h.
6463         (print_frame_info_to_print_what): New function.
6464         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6465         to decide what to print.
6466         (backtrace_command_1): Handle the new print_frame_arguments_presence
6467         value.
6468         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6469         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6470         (py_print_frame): In non-mi mode, use LOCATION as default for
6471         print_what, similarly to frame information printed directly by
6472         backtrace command. Handle frame-info user option in non MI mode.
6473
6474 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6475
6476         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6477         Add case for debugging 32-bit target on 64-bit host.  Revise
6478         comment.
6479
6480 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6481
6482         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6483         instead of find_function_entry_range_from_pc.
6484
6485 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6486
6487         * stack.c (find_frame_funname): Remove code which preferred
6488         minsym over symtab sym in "certain pathological cases".
6489
6490         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6491         parameter.  Change type of "do_demangle" to bool.
6492         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6493         Pass suitable "prefer_sym_over_minsym" flag to
6494         build_address_symbolic().  Don't output "+" for negative offsets.
6495         * printcmd.c (print_address_symbolic): Update invocation of
6496         build_address_symbolic to include a "prefer_sym_over_minsym"
6497         flag.
6498         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6499         Restrict cases in which use of minimal symbol is preferred to that
6500         of a found symbol.  Update comments.
6501
6502         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6503         for entry pc when entry pc is out of range for that FDE.
6504
6505 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6506
6507         PR gdb/24839:
6508         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6509         type.
6510
6511 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6512
6513         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6514         this function's Python signature.
6515
6516
6517 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6518
6519         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6520         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6521         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6522         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6523         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6524
6525
6526 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6527
6528         * h8300-tdep.c (h8300_register_name_common): New.
6529         h8300_register_name): Use h8300_register_name_common.
6530         (h8300s_register_name): Likewise.
6531         (h8300sx_register_name): Likewise.
6532         (h8300h_register_nam): New.
6533         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6534
6535
6536 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6537
6538         * arm-tdep.c (arm_skip_cmse_entry): New function.
6539         (arm_is_sgstubs_section): New function.
6540         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6541
6542 2019-07-22  Tom Tromey  <tom@tromey.com>
6543
6544         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6545         Don't self-assign.
6546
6547 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6548
6549         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6550         type_print.
6551
6552 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6553
6554         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6555         so that GDB doesn't match any msymbols when searching in the
6556         TYPES_DOMAIN.
6557         (print_symbol_info): Print using typedef_print or type_print based
6558         on the type of the symbol.  Add updated FIXME comment moved from...
6559         (_initialize_symtab): ... move and update FIXME comment to above.
6560
6561 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6562
6563         * NEWS: Mention adding -q option to "info types".
6564         * symtab.c (struct info_types_options): New struct.
6565         (info_types_options_defs): New variable.
6566         (make_info_types_options_def_group): New function.
6567         (info_types_command): Use gdb::option framework to parse options.
6568         (info_types_command_completer): New function.
6569         (_initialize_symtab): Extend the help text on "info types" and
6570         register command completer.
6571
6572 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6573
6574         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6575         (lookup_symbol_in_objfile): Change int to block_enum and add a
6576         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6577
6578 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6579
6580         * MAINTAINERS (Write After Approval): Add self.
6581
6582 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6583
6584         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6585         instruction to the dummy code region.
6586
6587 2019-07-19  Tom Tromey  <tromey@adacore.com>
6588
6589         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6590         (ARGSUSED, PARAMS, __func__): Remove rules.
6591
6592 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6593
6594         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6595         * features/arm/arm-with-iwmmxt.c: Remove.
6596         * features/arm/arm-with-iwmmxt.xml: Remove.
6597         * features/arm/arm-with-m-fpa-layout.c: Remove.
6598         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6599         * features/arm/arm-with-m-vfp-d16.c: Remove.
6600         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6601         * features/arm/arm-with-m.c: Remove.
6602         * features/arm/arm-with-m.xml: Remove.
6603         * features/arm/arm-with-neon.c: Remove.
6604         * features/arm/arm-with-neon.xml: Remove.
6605         * features/arm/arm-with-vfpv2.c: Remove.
6606         * features/arm/arm-with-vfpv2.xml: Remove.
6607         * features/arm/arm-with-vfpv3.c: Remove.
6608         * features/arm/arm-with-vfpv3.xml: Remove.
6609
6610 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6611
6612         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6613
6614 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6615
6616         * arch/aarch32.c (aarch32_create_target_description): Create
6617         target descriptions using features.
6618         * arch/arm.c (arm_create_target_description)
6619         (arm_create_mprofile_target_description): Likewise.
6620         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6621
6622 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6623
6624         * Makefile.in: Add new files.
6625         * aarch32-tdep.c: New file.
6626         * aarch32-tdep.h: New file.
6627         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6628         Call aarch32_read_description.
6629         * arch/aarch32.c: New file.
6630         * arch/aarch32.h: New file.
6631         * arch/arm.c (arm_create_target_description)
6632         (arm_create_mprofile_target_description): New function.
6633         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6634         (arm_create_target_description)
6635         (arm_create_mprofile_target_description): New declaration.
6636         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6637         read_description functions.
6638         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6639         Likewise.
6640         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6641         * arm-tdep.c (tdesc_arm_list): New variable.
6642         (arm_register_g_packet_guesses): Call create description functions.
6643         (arm_read_description) (arm_read_mprofile_description): New
6644         function.
6645         * arm-tdep.h (arm_read_description)
6646         (arm_read_mprofile_description): Add declaration.
6647         * configure.tgt: Add new files.
6648
6649 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6650
6651         * top.c (new_ui_command): Open specified terminal just once.
6652
6653 2019-07-18  Tom Tromey  <tromey@adacore.com>
6654
6655         * symtab.c (main_name): Constify return type.
6656         * symfile.c (set_initial_language): Update.
6657         * symtab.h (main_name): Constify return type.
6658
6659 2019-07-17  Tom Tromey  <tom@tromey.com>
6660
6661         * tui/tui-winsource.c (tui_update_source_window)
6662         (tui_update_source_window_as_is)
6663         (tui_update_source_windows_with_line): Remove return.
6664         * tui/tui-disasm.c (tui_show_disassem)
6665         (tui_show_disassem_and_update_source): Remove return.
6666         * tui/tui.c (tui_reset): Remove return.
6667         * tui/tui-wingeneral.c
6668         (tui_check_and_display_highlight_if_needed): Remove return.
6669
6670 2019-07-17  Tom Tromey  <tom@tromey.com>
6671
6672         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6673
6674 2019-07-17  Tom Tromey  <tom@tromey.com>
6675
6676         * tui/tui-winsource.h (struct tui_exec_info_window)
6677         (struct tui_source_window_base): Move from tui-data.h.
6678         * tui/tui-winsource.c: Move many method definitions from
6679         elsewhere.  Remove "structuring" comments.
6680         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6681         (tui_source_window_base::refresh_window): Move to
6682         tui-winsource.c.
6683         * tui/tui-win.c (tui_source_window_base::refresh_all)
6684         (tui_source_window_base::update_tab_width)
6685         (tui_source_window_base::set_new_height)
6686         (tui_source_window_base::do_make_visible_with_new_height): Move to
6687         tui-winsource.c.
6688         * tui/tui-source.h: Update.
6689         * tui/tui-source.c (tui_source_window_base::reset): Move to
6690         tui-winsource.c.
6691         * tui/tui-disasm.h: Update.
6692         * tui/tui-data.h (struct tui_exec_info_window): Move to
6693         tui-winsource.h.
6694         (struct tui_source_window_base): Likewise.
6695         * tui/tui-data.c (tui_source_window_base::clear_detail)
6696         (tui_source_window_base, ~tui_source_window_base): Move to
6697         tui-winsource.c.
6698
6699 2019-07-17  Tom Tromey  <tom@tromey.com>
6700
6701         * tui/tui-win.c (tui_resize_all)
6702         (tui_source_window_base::update_tab_width)
6703         (tui_adjust_win_heights): Update.
6704         (tui_win_info::make_invisible_and_set_new_height): Rename from
6705         make_invisible_and_set_new_height.
6706         * tui/tui-data.h (struct tui_win_info)
6707         <make_invisible_and_set_new_height>: New method.
6708
6709 2019-07-17  Tom Tromey  <tom@tromey.com>
6710
6711         * tui/tui.c: Update.
6712         * tui/tui-source.h (struct tui_source_window): Move from
6713         tui-data.h.
6714         * tui/tui-layout.c: Update.
6715         * tui/tui-disasm.c: Update.
6716         * tui/tui-data.h (struct tui_source_window): Move to
6717         tui-source.h.
6718
6719 2019-07-17  Tom Tromey  <tom@tromey.com>
6720
6721         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6722         tui-data.h.
6723         * tui/tui-data.h (struct tui_disasm_window): Move to
6724         tui-disasm.h.
6725
6726 2019-07-17  Tom Tromey  <tom@tromey.com>
6727
6728         * tui/tui-regs.h (struct tui_data_item_window): Move from
6729         tui-data.h.
6730         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6731         * tui/tui-data.h (struct tui_data_item_window): Move to
6732         tui-regs.h.
6733         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6734
6735 2019-07-17  Tom Tromey  <tom@tromey.com>
6736
6737         * tui/tui.c: Update.
6738         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6739         (tui_cmd_window::max_height): Move to tui-command.c.
6740         * tui/tui-layout.c: Update.
6741         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6742         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6743         tui-command.c.
6744         * tui/tui-command.h (struct tui_cmd_window): Move from
6745         tui-data.h.
6746         * tui/tui-command.c: Remove "structuring" comments.
6747         (tui_cmd_window::clear_detail)
6748         (tui_cmd_window::do_make_visible_with_new_height)
6749         (tui_cmd_window::max_height): Move from elsewhere.
6750
6751 2019-07-17  Tom Tromey  <tom@tromey.com>
6752
6753         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6754         Now static.
6755         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6756         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6757
6758 2019-07-17  Tom Tromey  <tom@tromey.com>
6759
6760         * tui/tui.c: Update.
6761         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6762         tui-regs.c.
6763         * tui/tui-windata.h: Remove file.
6764         * tui/tui-windata.c: Remove file.
6765         * tui/tui-win.c (tui_data_window::set_new_height)
6766         (tui_data_window::do_make_visible_with_new_height): Move to
6767         tui-regs.c.
6768         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6769         * tui/tui-regs.c: Remove "structuring" comments.
6770         (tui_data_window::first_data_item_displayed)
6771         (tui_data_window::delete_data_content_windows)
6772         (tui_data_window::erase_data_content)
6773         (tui_data_window::display_all_data)
6774         (tui_data_window::refresh_all)
6775         (tui_data_window::do_scroll_vertical)
6776         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6777         (tui_data_window::do_make_visible_with_new_height)
6778         (tui_data_window::refresh_window): Move from elsewhere.
6779         (_initialize_tui_regs): Move to end of file.
6780         * tui/tui-layout.c: Update.
6781         * tui/tui-hooks.c: Update.
6782         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6783         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6784         tui-regs.c.
6785         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6786
6787 2019-07-17  Tom Tromey  <tom@tromey.com>
6788
6789         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6790         seen.
6791
6792 2019-07-17  Tom Tromey  <tom@tromey.com>
6793
6794         * tui/tui-win.c (tui_source_window_base::set_new_height)
6795         (tui_source_window_base::do_make_visible_with_new_height): Use
6796         m_has_locator field directly.
6797         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6798         method.
6799         (struct tui_source_window_base) <has_locator>: Likewise.
6800
6801 2019-07-17  Tom Tromey  <tom@tromey.com>
6802
6803         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6804         Don't declare.
6805         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6806         Remove.
6807         * tui/tui-win.c (tui_source_window_base::set_new_height)
6808         (tui_source_window_base::set_new_height)
6809         (make_invisible_and_set_new_height)
6810         (tui_source_window_base::do_make_visible_with_new_height)
6811         (tui_source_window_base::do_make_visible_with_new_height):
6812         Update.
6813         * tui/tui-layout.c (show_source_disasm_command, show_data)
6814         (show_source_or_disasm_and_command): Update.
6815         * tui/tui-layout.c (show_layout): Update.
6816
6817 2019-07-17  Tom Tromey  <tom@tromey.com>
6818
6819         * tui/tui-layout.c (make_data_window): Remove.
6820         (show_data): Unify creation and re-initialization cases.
6821
6822 2019-07-17  Tom Tromey  <tom@tromey.com>
6823
6824         * tui/tui-layout.c (make_source_window, make_disasm_window):
6825         Remove.
6826         (show_data): Unify creation and re-initialization cases.
6827
6828 2019-07-17  Tom Tromey  <tom@tromey.com>
6829
6830         * tui/tui-layout.c (make_command_window): Remove.
6831         (show_source_disasm_command, show_source_or_disasm_and_command):
6832         Unify creation and re-initialization cases.
6833
6834 2019-07-17  Tom Tromey  <tom@tromey.com>
6835
6836         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6837         creation and re-initialization cases.
6838
6839 2019-07-17  Tom Tromey  <tom@tromey.com>
6840
6841         * tui/tui-regs.c (tui_get_register): Return void.
6842
6843 2019-07-17  Tom Tromey  <tom@tromey.com>
6844
6845         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6846         Simplify.
6847
6848 2019-07-17  Tom Tromey  <tom@tromey.com>
6849
6850         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6851         resetting.
6852
6853 2019-07-17  Tom Tromey  <tom@tromey.com>
6854
6855         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6856         * tui/tui-regs.c (tui_reg_layout): New function.
6857         (tui_show_registers, tui_reg_command): Use it.
6858         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6859         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6860         parameters.
6861         (tui_layout_command): Remove.
6862
6863 2019-07-17  Tom Tromey  <tom@tromey.com>
6864
6865         * tui/tui-layout.h (tui/tui-layout): Return void.
6866         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6867
6868 2019-07-17  Tom Tromey  <tom@tromey.com>
6869
6870         * tui/tui-layout.c (show_source_disasm_command, show_data):
6871         Update.
6872         (reset_locator): Remove.
6873         (show_source_or_disasm_and_command): Update.
6874
6875 2019-07-17  Tom Tromey  <tom@tromey.com>
6876
6877         * tui/tui-source.c (tui_source_window_base::reset): Remove
6878         win_type parameter.
6879         * tui/tui-layout.c (make_command_window, make_source_window)
6880         (make_disasm_window, make_data_window)
6881         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6882         (reset_locator, show_source_or_disasm_and_command): Update.
6883         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6884         win_type parameter.
6885         (struct tui_source_window_base) <reset>: Likewise.
6886
6887 2019-07-17  Tom Tromey  <tom@tromey.com>
6888
6889         * tui/tui-layout.c (show_source_disasm_command): Use
6890         reset_locator.
6891         (reset_locator): New function.
6892         (init_and_make_win): Remove.
6893         (show_source_or_disasm_and_command): Use reset_locator.
6894
6895 2019-07-17  Tom Tromey  <tom@tromey.com>
6896
6897         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6898         condition.
6899         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6900         Remove condition.
6901         * tui/tui-source.c (tui_source_window_base::reset): New method.
6902         * tui/tui-layout.c (make_command_window): Don't call
6903         init_and_make_win.
6904         (make_source_window, make_disasm_window): Don't call
6905         make_source_or_disasm_window.
6906         (make_data_window): Don't call init_and_make_win.  Change calling
6907         convention.
6908         (show_source_disasm_command, show_data): Simplify.
6909         (make_source_or_disasm_window): Remove.
6910         (show_source_or_disasm_and_command): Simplify.
6911         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6912         (struct tui_source_window_base) <reset>: Likewise.
6913         <execution_info>: Remove initializer.
6914         * tui/tui-data.c (tui_source_window_base): Initialize
6915         execution_info.
6916
6917 2019-07-17  Tom Tromey  <tom@tromey.com>
6918
6919         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6920         variable.
6921
6922 2019-07-17  Tom Tromey  <tom@tromey.com>
6923
6924         * tui/tui.c (tui_rl_other_window): Update.
6925         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6926         superclass method first.  Always iterate over regs_content.
6927         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6928         method.
6929         * tui/tui-win.c (tui_set_focus_command): Update.
6930
6931 2019-07-17  Tom Tromey  <tom@tromey.com>
6932
6933         * tui/tui-win.c (tui_set_focus_command): Rename from
6934         tui_set_focus.  Call tui_enable.
6935         (tui_set_focus_command): Remove.
6936
6937 2019-07-17  Tom Tromey  <tom@tromey.com>
6938
6939         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6940         refresh_window.
6941         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6942         touchwin.
6943         (tui_data_window::refresh_window): Call refresh_window on data
6944         items.  Always call superclass refresh_window.
6945         (tui_win_info::refresh): Remove.
6946         (tui_source_window_base::refresh_window): Update.
6947         (tui_refresh_all): Update.
6948         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6949         refresh_window.
6950         (show_source_or_disasm_and_command): Likewise.
6951         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6952         (struct tui_source_window_base) <refresh>: Likewise.
6953
6954 2019-07-17  Tom Tromey  <tom@tromey.com>
6955
6956         * tui/tui-winsource.c (tui_clear_source_content)
6957         (tui_show_source_content): Update.
6958         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6959         whether content is empty.
6960         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6961         Remove.
6962
6963 2019-07-17  Tom Tromey  <tom@tromey.com>
6964
6965         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6966         window's contents.
6967         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6968         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6969
6970 2019-07-17  Tom Tromey  <tom@tromey.com>
6971
6972         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6973         (struct tui_data_item_window): Update.
6974
6975 2019-07-17  Tom Tromey  <tom@tromey.com>
6976
6977         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6978         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6979         defines.
6980
6981 2019-07-17  Tom Tromey  <tom@tromey.com>
6982
6983         * tui/tui-winsource.h (tui_erase_source_content)
6984         (tui_clear_source_content): Remove "display_prompt" parameter.
6985         * tui/tui-winsource.c (tui_update_source_window_as_is)
6986         (tui_update_source_windows_with_addr): Update.
6987         (tui_clear_source_content): Remove "display_prompt" parameter.
6988         (tui_erase_source_content): Likewise.  Simplify.
6989         (tui_show_source_content): Update.
6990         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6991         * tui/tui-stack.c (tui_show_frame_info): Update.
6992         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6993         Remove defines.
6994
6995 2019-07-17  Tom Tromey  <tom@tromey.com>
6996
6997         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6998         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6999         parameter.
7000         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
7001         parameter.
7002
7003 2019-07-17  Tom Tromey  <tom@tromey.com>
7004
7005         * tui/tui-winsource.c (tui_clear_source_content)
7006         (tui_show_source_content, tui_show_exec_info_content)
7007         (tui_clear_exec_info_content): Update.
7008         * tui/tui-stack.c (tui_show_locator_content): Update.
7009         (tui_show_frame_info): Update.
7010         * tui/tui-source.h (tui_source_window): Don't declare.
7011         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
7012         from tui_source_is_displayed.
7013         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
7014         Remove field.
7015         (struct tui_source_window_base) <content_in_use>: New field.  Now
7016         bool.
7017         (struct tui_source_window) <showing_source_p>: New method.
7018         (TUI_SRC_WIN): Change cast.
7019         * tui/tui-data.c (tui_initialize_static_data): Update.
7020
7021 2019-07-17  Tom Tromey  <tom@tromey.com>
7022
7023         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
7024         location_matches_p.
7025         * tui/tui-source.c (tui_source_window::location_matches_p): New
7026         method.
7027         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
7028         method.
7029         * tui/tui-data.h (struct tui_source_window_base)
7030         <location_matches_p>: New method.
7031         (struct tui_source_window, struct tui_disasm_window)
7032         <location_matches_p>: Likewise.
7033
7034 2019-07-17  Tom Tromey  <tom@tromey.com>
7035
7036         * tui/tui-win.c (tui_set_win_height_command): Rename from
7037         tui_set_win_height.
7038         (tui_set_win_height_command): Remove.
7039
7040 2019-07-17  Tom Tromey  <tom@tromey.com>
7041
7042         * tui/tui-source.c (tui_source_window): New constructor.  Add
7043         observer.
7044         (~tui_source_window): New destructor.
7045         (tui_source_window::style_changed): New method.
7046         * tui/tui-hooks.c (tui_redisplay_source): Remove.
7047         (tui_attach_detach_observers): Update.
7048         * tui/tui-data.h (struct tui_source_window): Make constructor not
7049         inline.  Add destructor.
7050         (struct tui_source_window) <style_changed>: New method.
7051         <m_observable>: New member.
7052
7053 2019-07-17  Tom Tromey  <tom@tromey.com>
7054
7055         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
7056         * tui/tui-win.c (tui_resize_all): Fix typo.
7057
7058 2019-07-17  Tom Tromey  <tom@tromey.com>
7059
7060         * tui/tui-wingeneral.h (tui_refresh_all): Update.
7061         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
7062         (tui_refresh_all): Remove "list" parameter.  Use foreach.
7063         * tui/tui-win.c (window_name_completer): Use foreach.
7064         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
7065         (update_tab_width): Likewise.
7066         * tui/tui-layout.c (show_layout): Update.
7067         * tui/tui-data.h (class tui_window_iterator): New.
7068         (struct all_tui_windows): New.
7069         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
7070
7071 2019-07-17  Tom Tromey  <tom@tromey.com>
7072
7073         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
7074         parameter.  Don't reference globals.
7075         (tui_reg_command): Update.
7076
7077 2019-07-17  Tom Tromey  <tom@tromey.com>
7078
7079         * tui/tui-regs.c (tui_show_registers): Simplify.
7080
7081 2019-07-17  Tom Tromey  <tom@tromey.com>
7082
7083         * tui/tui-regs.c (tui_show_registers): Update.
7084         (tui_show_register_group): Add win_info parameter.
7085
7086 2019-07-17  Tom Tromey  <tom@tromey.com>
7087
7088         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7089         Rename from tui_display_reg_element_at_line.
7090         (tui_data_window::display_registers_from_line): Update.
7091         * tui/tui-data.h (struct tui_data_window)
7092         <display_reg_element_at_line>: New method.
7093
7094 2019-07-17  Tom Tromey  <tom@tromey.com>
7095
7096         * tui/tui-regs.h (tui_display_registers_from)
7097         (tui_display_registers_from_line): Don't declare.
7098         * tui/tui-windata.c (tui_data_window::display_all_data)
7099         (tui_data_window::refresh_all)
7100         (tui_data_window::do_scroll_vertical): Update.
7101         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7102         from tui_display_registers_from.
7103         (tui_display_reg_element_at_line): Update.
7104         (tui_data_window::display_registers_from_line): Rename from
7105         tui_display_registers_from_line.
7106         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7107         display_registers_from_line>: New methods.
7108
7109 2019-07-17  Tom Tromey  <tom@tromey.com>
7110
7111         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7112         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7113         from tui_erase_data_content.
7114         (tui_data_window::display_all_data)
7115         (tui_data_window::refresh_all)
7116         (tui_data_window::do_scroll_vertical): Update.
7117         * tui/tui-regs.c (tui_show_registers): Update.
7118         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7119         New method.
7120
7121 2019-07-17  Tom Tromey  <tom@tromey.com>
7122
7123         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7124         declare.
7125         * tui/tui-windata.c
7126         (tui_data_window::delete_data_content_windows): Rename from
7127         tui_delete_data_content_windows.
7128         (tui_data_window::display_all_data)
7129         (tui_data_window::do_scroll_vertical): Update.
7130         * tui/tui-data.h (struct tui_data_window)
7131         <delete_data_content_windows>: New method.
7132
7133 2019-07-17  Tom Tromey  <tom@tromey.com>
7134
7135         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7136         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7137
7138 2019-07-17  Tom Tromey  <tom@tromey.com>
7139
7140         * tui/tui-windata.h (tui_display_all_data): Don't declare.
7141         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7142         from tui_display_all_data.
7143         * tui/tui-win.c
7144         (tui_data_window::do_make_visible_with_new_height): Update.
7145         * tui/tui-regs.c (tui_show_registers): Update.
7146         * tui/tui-layout.c (tui_set_layout): Update.
7147         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7148         method.
7149
7150 2019-07-17  Tom Tromey  <tom@tromey.com>
7151
7152         * tui/tui-windata.h (tui_display_data_from): Don't declare.
7153         * tui/tui-windata.c (tui_display_data_from): Remove.
7154         (tui_data_window::refresh_all): Update.
7155
7156 2019-07-17  Tom Tromey  <tom@tromey.com>
7157
7158         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7159         * tui/tui-windata.c (tui_display_data_from_line): Remove.
7160         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7161         tui_display_registers_from_line.
7162         * tui/tui-regs.h (tui_display_registers_from_line): Update.
7163         * tui/tui-regs.c (tui_display_registers_from_line): Remove
7164         "force_display" parameter.
7165
7166 2019-07-17  Tom Tromey  <tom@tromey.com>
7167
7168         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7169         declare.
7170         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7171         Rename from tui_first_reg_element_no_inline.
7172         (tui_display_reg_element_at_line)
7173         (tui_display_registers_from_line): Update.
7174         * tui/tui-data.h (struct tui_data_window)
7175         <first_reg_element_no_inline>: New method.
7176
7177 2019-07-17  Tom Tromey  <tom@tromey.com>
7178
7179         * tui/tui-windata.c (tui_display_data_from)
7180         (tui_data_window::do_scroll_vertical): Update.
7181         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7182         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7183         Rename from tui_line_from_reg_element_no.
7184         (tui_display_registers_from_line): Update.
7185         * tui/tui-data.h (struct tui_data_window)
7186         <line_from_reg_element_no>: New method.
7187
7188 2019-07-17  Tom Tromey  <tom@tromey.com>
7189
7190         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7191         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7192         tui_last_regs_line_no.
7193         (tui_display_reg_element_at_line)
7194         (tui_display_registers_from_line): Update.
7195         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7196         method.
7197
7198 2019-07-17  Tom Tromey  <tom@tromey.com>
7199
7200         PR tui/24722:
7201         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7202         (tui_update_breakpoint_info): Add "being_deleted" parameter.
7203         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7204         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7205         (tui_update_breakpoint_info): Likewise.
7206         * tui/tui-hooks.c (tui_event_create_breakpoint)
7207         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7208         Update.
7209
7210 2019-07-17  Tom Tromey  <tom@tromey.com>
7211
7212         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7213
7214 2019-07-17  Tom Tromey  <tom@tromey.com>
7215
7216         * tui/tui-winsource.c (tui_update_source_window_as_is)
7217         (tui_update_source_windows_with_addr): Update.
7218         * tui/tui-source.h (tui_set_source_content)
7219         (tui_show_symtab_source): Add "win_info" parameter.
7220         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7221         parameter.
7222         (tui_show_symtab_source): Likewise.
7223
7224 2019-07-17  Tom Tromey  <tom@tromey.com>
7225
7226         * tui/tui-wingeneral.c
7227         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7228
7229 2019-07-17  Tom Tromey  <tom@tromey.com>
7230
7231         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7232         (struct tui_cmd_window) <can_scroll>: New method.
7233         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7234         method.
7235
7236 2019-07-17  Tom Tromey  <tromey@adacore.com>
7237
7238         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7239         do_field_signed>: Rename.  Change type of "value".
7240         * ui-out.c (ui_out::field_signed): Rename from field_int.
7241         Change type of "value".
7242         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7243         type of "value".
7244         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7245         do_field_int.  Change type of "value".
7246         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7247         do_field_int.  Change type of "value".
7248         * tracepoint.c (trace_status_mi, tfind_1)
7249         (print_one_static_tracepoint_marker): Update.
7250         * thread.c (print_thread_info_1, print_selected_thread_frame):
7251         Update.
7252         * stack.c (print_frame, print_frame_info): Update.
7253         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7254         Update.
7255         * source.c (print_source_lines_base): Update.
7256         * skip.c (info_skip_command): Update.
7257         * record-btrace.c (btrace_ui_out_decode_error)
7258         (btrace_call_history_src_line): Update.
7259         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7260         Update.
7261         * progspace.c (print_program_space): Update.
7262         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7263         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7264         do_field_int.  Change type of "value".
7265         * mi/mi-out.c (mi_ui_out::do_table_begin)
7266         (mi_ui_out::do_table_header): Update.
7267         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7268         type of "value".
7269         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7270         (mi_cmd_data_list_changed_registers, output_register)
7271         (mi_cmd_data_read_memory, mi_load_progress)
7272         (mi_cmd_trace_frame_collected): Update.
7273         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7274         Update.
7275         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7276         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7277         (mi_cmd_var_list_children, varobj_update_one): Update.
7278         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7279         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7280         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7281         * inferior.c (print_inferior): Update.
7282         * gdb_bfd.c (print_one_bfd): Update.
7283         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7284         Update.
7285         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7286         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7287         do_field_int.  Change type of "value".
7288         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7289         do_field_int.  Change type of "value".
7290         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7291         (print_one_breakpoint_location, print_it_catch_fork)
7292         (print_one_catch_fork, print_it_catch_vfork)
7293         (print_one_catch_vfork, print_it_catch_solib)
7294         (print_it_catch_exec, print_it_ranged_breakpoint)
7295         (print_mention_watchpoint, print_mention_masked_watchpoint)
7296         (bkpt_print_it, update_static_tracepoint): Update.
7297         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7298         * break-catch-syscall.c (print_it_catch_syscall): Update.
7299         * ada-tasks.c (print_ada_task_info): Update.
7300         * ada-lang.c (print_it_exception, print_mention_exception):
7301         Update.
7302
7303 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7304
7305         PR breakpoints/24541
7306         * gdbarch.c: Regenerate.
7307         * gdbarch.h: Regenerate.
7308         * gdbarch.sh: Adjust return type and parameter types for
7309         'stap_adjust_register'.
7310         (i386_stap_adjust_register): Adjust signature and return new
7311         register name.
7312         * stap-probe.c (stap_parse_register_operand): Adjust use of
7313         'gdbarch_stap_adjust_register'.
7314
7315 2019-07-17  Tom Tromey  <tromey@adacore.com>
7316
7317         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7318         declare VEC.
7319         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7320         std::vector.
7321         (struct s390_process_info): Add initializers.
7322         (s390_add_process): Use new.
7323         (s390_linux_nat_target::low_forget_process): Use delete.
7324         (s390_linux_nat_target::low_new_fork)
7325         (s390_linux_nat_target::stopped_by_watchpoint)
7326         (s390_linux_nat_target::low_prepare_to_resume)
7327         (s390_linux_nat_target::insert_watchpoint)
7328         (s390_linux_nat_target::insert_hw_breakpoint)
7329         (s390_linux_nat_target::remove_watchpoint)
7330         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7331
7332 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7333
7334         * aarch64-fbsd-nat.c: Include regcache.h.
7335         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7336         argument.
7337         (aarch64_fbsd_nat_target::fetch_registers)
7338         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7339         variable.
7340         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7341
7342 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7343
7344         * fbsd-nat.c: Include gdbarch.h.
7345
7346 2019-07-15  Tom Tromey  <tromey@adacore.com>
7347
7348         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7349
7350 2019-07-15  Tom Tromey  <tromey@adacore.com>
7351
7352         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7353         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7354         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7355         * cli-out.c (cli_ui_out::do_field_int): New method.
7356         * ui-out.c (ui_out::field_unsigned): New method.
7357         * symfile.c (generic_load): Use field_unsigned.
7358         (print_transfer_performance): Likewise.
7359         * record-btrace.c (ui_out_field_uint): Remove.
7360         (btrace_call_history_insn_range, btrace_call_history): Use
7361         field_unsigned.
7362         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7363         field_unsigned.
7364         * ui-out.h (class ui_out) <field_unsigned>: New method.
7365         <do_field_unsigned>: Likewise.
7366
7367 2019-07-15  Tom Tromey  <tromey@adacore.com>
7368
7369         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7370         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7371         * target.c (flash_erase_command): Use field_string.
7372         * infrun.c (print_signal_received_reason): Use field_string.
7373         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7374         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7375         field_string.
7376         * ada-tasks.c (print_ada_task_info): Use field_string.
7377
7378 2019-07-15  Tom Tromey  <tromey@adacore.com>
7379
7380         * target.c (flash_erase_command): Use field_core_addr.
7381         * symfile.c (generic_load): Use field_core_addr.
7382         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7383         Use field_core_addr.
7384         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7385         field_core_addr.
7386
7387 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7388
7389         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7390         value if its desired type is smaller than a CORE_ADDR and signed.
7391
7392 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7393
7394         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7395         of changes to field names, and use new is_reference field to
7396         decide if a property is a reference or not.
7397         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7398         field.
7399         (struct dwarf2_property_baton): Update header comment, rename
7400         'referenced_type' to 'property_type' and update comments.
7401         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7402         default property type, store in property baton, update to take
7403         accound of renamed field.
7404         (read_func_scope): Update call to attr_to_dynamic_prop.
7405         (read_array_type): Likewise.
7406         (dwarf2_per_cu_addr_sized_int_type): New function.
7407         (read_subrange_index_type): Move type finding code to
7408         dwarf2_per_cu_addr_sized_int_type.
7409         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7410         (dwarf2_per_cu_addr_type): New function.
7411         (set_die_type): Update calls to attr_to_dynamic_prop.
7412
7413 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7414
7415         * dwarf2read.c (read_subrange_index_type): New function.
7416         (read_subrange_type): Move code into new function and call it.
7417         * gdbtypes.c (create_range_type): Add some asserts.
7418
7419 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7420
7421         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7422         update return statements.
7423         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7424         declaration, and update comment to match.
7425         * gdbtypes.c (resolve_dynamic_array): Update call to
7426         dwarf2_evaluate_property to match new return type.
7427
7428 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7429
7430         * valarith.c (value_subscripted_rvalue): Change lowerbound
7431         parameter type from int to LONGEST.
7432         * value.h (value_subscripted_rvalue): Likewise in declaration.
7433
7434 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7435
7436         * cli/cli-utils.c (info_print_command_completer): New function.
7437         * cli/cli-utils.h: Add 'completer.h' include, and forward
7438         declaration for 'struct cmd_list_element'.
7439         (info_print_command_completer): Declare.
7440         * stack.c (_initialize_stack): Add completer for 'info locals' and
7441         'info args'.
7442         * symtab.c (_initialize_symtab): Add completer for 'info
7443         variables' and 'info functions'.
7444         * NEWS: Mention completion for additional info commands.
7445
7446 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7447
7448         * cli/cli-utils.c (extract_info_print_args): Delete.
7449         (extract_arg_maybe_quoted): Delete.
7450         (info_print_options_defs): New variable.
7451         (make_info_print_options_def_group): New function.
7452         (extract_info_print_options): Define new function.
7453         * cli/cli-utils.h (extract_info_print_args): Delete.
7454         (struct info_print_options): New structure.
7455         (extract_info_print_options): Declare new function.
7456         * stack.c (info_locals_command): Update to use new
7457         extract_info_print_options, also add a header comment.
7458         (info_args_command): Likewise.
7459         * symtab.c (info_variables_command): Likewise.
7460         (info_functions_command): Likewise.
7461
7462 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7463
7464         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7465         to extract string arguments.
7466         * common/common-utils.c (extract_string_maybe_quoted): New function.
7467         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7468
7469 2019-07-11  Tom Tromey  <tromey@adacore.com>
7470
7471         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7472         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7473         * top.h (gdbinit): Don't declare.
7474         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7475         into...
7476         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7477         * top.c (gdb_init): Don't call init_cli_cmds.
7478         (gdbinit): Remove.
7479         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7480
7481 2019-07-11  Tom Tromey  <tromey@adacore.com>
7482
7483         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7484         after it has been moved.
7485
7486 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7487
7488         * valops.c (value_must_coerce_to_target): Change return type to
7489         bool.
7490         * value.h (value_must_coerce_to_target): Likewise.
7491
7492 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7493
7494         * breakpoint.c (is_hardware_watchpoint): Remove
7495         forward-declaration.
7496         (is_masked_watchpoint): Change return type to bool.
7497         (is_tracepoint): Likewise.
7498         (is_breakpoint): Likewise.
7499         (is_hardware_watchpoint): Likewise.
7500         (is_watchpoint): Likewise.
7501         (is_no_memory_software_watchpoint): Likewise.
7502         (is_catchpoint): Likewise.
7503         (breakpoint_1): Make FILTER parameter's return type bool.
7504         is_masked_watchpoint): Change return type to bool.
7505         (save_breakpoints): Make FILTER parameter's return type bool.
7506         * breakpoint.h (is_breakpoint): Change return type to bool.
7507         (is_watchpoint): Likewise.
7508         (is_catchpoint): Likewise.
7509         (is_tracepoint): Likewise.
7510
7511 2019-07-10  Tom Tromey  <tom@tromey.com>
7512
7513         * defs.h: Don't include gdbarch.h.
7514         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7515         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7516         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7517         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7518         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7519         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7520         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7521         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7522         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7523         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7524         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7525         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7526         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7527         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7528         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7529         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7530         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7531         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7532         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7533         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7534         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7535         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7536         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7537         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7538         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7539         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7540         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7541
7542 2019-07-10  Tom Tromey  <tromey@adacore.com>
7543
7544         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7545         * breakpoint.c (init_ada_exception_breakpoint): Register as
7546         bp_catchpoint.
7547         (print_one_breakpoint_location, print_one_breakpoint): Use
7548         is_ada_exception_catchpoint.
7549         * ada-lang.c (class ada_catchpoint_location): Pass
7550         bp_loc_software_breakpoint to bp_location constructor.
7551         (is_ada_exception_catchpoint): New function.
7552
7553 2019-07-10  Tom Tromey  <tromey@adacore.com>
7554
7555         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7556         VEC.
7557         (struct arm_exidx_entry): New method operator<.
7558         (struct arm_exidx_data) <section_maps>: Change type.
7559         (arm_exidx_data_free): Remove.
7560         (arm_exidx_data_key): Change type.  Move lower.
7561         (arm_exidx_new_objfile): Update.
7562         (arm_compare_exidx_entries): Remove.
7563         (arm_find_exidx_entry, _initialize_arm_tdep)
7564
7565 2019-07-10  Tom Tromey  <tromey@adacore.com>
7566
7567         * solib-spu.c (ocl_program_data_key): Change type.
7568         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7569         Update.
7570
7571 2019-07-10  Tom Tromey  <tromey@adacore.com>
7572
7573         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7574         (struct solib_aix_inferior_data) <library_list>: Change type.
7575         (solib_aix_inferior_data_handle): Change type.
7576         (get_solib_aix_inferior_data): Update.
7577         (solib_aix_free_library_list): Remove.
7578         (library_list_start_library): Update.
7579         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7580         return type.
7581         (solib_aix_get_library_list)
7582         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7583         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7584
7585 2019-07-10  Tom Tromey  <tromey@adacore.com>
7586
7587         * solib-dsbt.c (struct dsbt_info): Add initializers.
7588         (solib_dsbt_pspace_data): Change type.
7589         (dsbt_pspace_data_cleanup): Remove.
7590         (get_dsbt_info, _initialize_dsbt_solib): Update.
7591
7592 2019-07-10  Tom Tromey  <tromey@adacore.com>
7593
7594         * spu-tdep.c (spu_overlay_data): Change type.
7595         (spu_get_overlay_table, spu_overlay_new_objfile)
7596         (_initialize_spu_tdep): Update.
7597
7598 2019-07-10  Tom Tromey  <tromey@adacore.com>
7599
7600         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7601         destructor.
7602         (dbx_objfile_data_key): Change type and declare later.
7603         (DBX_SYMFILE_INFO): Rewrite.
7604         * dbxread.c (dbx_objfile_data_key): Change type.
7605         (dbx_symfile_init): Update.
7606         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7607         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7608         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7609
7610 2019-07-10  Tom Tromey  <tromey@adacore.com>
7611
7612         * jit.c (jit_program_space_key): Change type.  Move lower.
7613         (get_jit_program_space_data): Update.
7614         (jit_program_space_data_cleanup): Remove.
7615         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7616         Update.
7617         (struct jit_program_space_data): Add initializers.
7618
7619 2019-07-10  Tom Tromey  <tromey@adacore.com>
7620
7621         * solib-darwin.c (struct darwin_info): Add initializers.
7622         (solib_darwin_pspace_data): Change type.
7623         (darwin_pspace_data_cleanup): Remove.
7624         (get_darwin_info, _initialize_darwin_solib): Update.
7625
7626 2019-07-10  Tom Tromey  <tromey@adacore.com>
7627
7628         * remote-sim.c (struct sim_inferior_data): Add initializers,
7629         constructor, and destructor.
7630         (sim_inferior_data_key): Change type.  Move lower.
7631         (check_for_duplicate_sim_descriptor): Update.
7632         (get_sim_inferior_data): Use new.  Update.
7633         (~sim_inferior_data_cleanup): Rename from
7634         sim_inferior_data_cleanup.  Simplify.
7635         (gdbsim_close_inferior, simulator_command)
7636         (sim_command_completer, _initialize_remote_sim): Update.
7637         (next_pid, INITIAL_PID): Move earlier.
7638
7639 2019-07-10  Tom Tromey  <tromey@adacore.com>
7640
7641         * python/python-internal.h (create_thread_object): Return
7642         gdbpy_ref.
7643         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7644         * python/py-inferior.c (struct threadlist_entry): Add
7645         constructor.
7646         <thread_obj>: Now a gdbpy_ref.
7647         (thread_to_thread_object): Update.
7648         (add_thread_object): Use new.
7649         (delete_thread_object): Use delete.
7650         (infpy_threads): Update.
7651         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7652         GIL.
7653
7654 2019-07-10  Tom Tromey  <tromey@adacore.com>
7655
7656         * valops.c (value_cast): Specialize error message for Ada.
7657
7658 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7659
7660         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7661
7662 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7663
7664         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7665         bpstat_should_step): Return bool, adjust comments.
7666         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7667         bpstat_should_step): Likewise.
7668
7669 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7670
7671         * features/Makefile: Use feature target descriptions for Arm.
7672         * features/arm/arm-core.c: Generate new file.
7673         * features/arm/arm-fpa.c: Likewise.
7674         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7675         * features/arm/arm-m-profile.c: Likewise.
7676         * features/arm/arm-vfpv2.c: Likewise.
7677         * features/arm/arm-vfpv3.c: Likewise.
7678         * features/arm/xscale-iwmmxt.c: Likewise.
7679         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7680
7681 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7682
7683         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7684         ptrace earlier.
7685
7686 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7687
7688         * features/aarch64-pauth.c: Regenerate.
7689
7690 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7691
7692         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7693         bool.
7694         (bpstat_what): Use false instead of 0.
7695
7696 2019-07-09  Pedro Alves  <palves@redhat.com>
7697
7698         * break-catch-throw.c (is_exception_catchpoint): New.
7699         * breakpoint.c (print_one_breakpoint_location): New parameter
7700         'raw_loc'.  Handle it.  Use
7701         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7702         looking at the breakpoint's type.
7703         (print_one_breakpoint): If handling "maint info breakpoints", also
7704         print locations of exception catchpoints.
7705         * breakpoint.h (is_exception_catchpoint): Declare.
7706
7707 2019-07-09  Pedro Alves  <palves@redhat.com>
7708
7709         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7710         "addr" field.
7711         (allocate_location_exception_catchpoint): New.
7712         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7713         (initialize_throw_catchpoint_ops): Install
7714         allocate_location_exception_catchpoint as allocate_location
7715         method.
7716         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7717         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7718         bp_loc_other.
7719         (breakpoint_address_is_meaningful): Delete.
7720         (bl_address_is_meaningful): New.
7721         (breakpoint_locations_match): Adjust comment.
7722         (bp_location_from_bp_type): New, factored out of...
7723         (bp_location::bp_location(breakpoint *)): ... this.
7724         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7725         factored out of...
7726         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7727         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7728         breakpoint_address_is_meaningful.
7729         (bp_locations_compare): Adjust comment.
7730         (update_global_location_list): Use bl_address_is_meaningful
7731         instead of breakpoint_address_is_meaningful.
7732         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7733         explicit.
7734         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7735         * python/py-breakpoint.c (bppy_get_location): No longer check
7736         whether location is null.
7737
7738 2019-07-09  Pedro Alves  <palves@redhat.com>
7739
7740         PR c++/15468
7741         * breakpoint.c (print_one_breakpoint_location): Remove
7742         single-location assert.
7743
7744 2019-07-09  Tom Tromey  <tom@tromey.com>
7745
7746         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7747         * configure: Rebuild.
7748         * configure.ac: Change common to gdbsupport.
7749         * gdbsupport: Rename from common.
7750         * acinclude.m4: Change common to gdbsupport.
7751         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7752         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7753         gdbsupport.
7754         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7755         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7756         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7757         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7758         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7759         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7760         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7761         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7762         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7763         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7764         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7765         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7766         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7767         coff-pe-read.c, command.h, compile/compile-c-support.c,
7768         compile/compile-c.h, compile/compile-cplus-symbols.c,
7769         compile/compile-cplus-types.c, compile/compile-cplus.h,
7770         compile/compile-loc2c.c, compile/compile.c, completer.c,
7771         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7772         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7773         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7774         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7775         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7776         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7777         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7778         features/aarch64-core.c, features/aarch64-fpu.c,
7779         features/aarch64-pauth.c, features/aarch64-sve.c,
7780         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7781         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7782         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7783         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7784         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7785         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7786         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7787         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7788         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7789         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7790         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7791         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7792         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7793         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7794         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7795         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7796         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7797         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7798         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7799         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7800         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7801         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7802         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7803         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7804         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7805         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7806         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7807         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7808         minsyms.c, mips-linux-tdep.c, namespace.h,
7809         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7810         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7811         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7812         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7813         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7814         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7815         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7816         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7817         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7818         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7819         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7820         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7821         procfs.c, producer.c, progspace.h, psymtab.h,
7822         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7823         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7824         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7825         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7826         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7827         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7828         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7829         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7830         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7831         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7832         target-memory.c, target.c, target.h, target/waitstatus.c,
7833         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7834         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7835         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7836         unittests/array-view-selftests.c,
7837         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7838         unittests/common-utils-selftests.c,
7839         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7840         unittests/format_pieces-selftests.c,
7841         unittests/function-view-selftests.c,
7842         unittests/lookup_name_info-selftests.c,
7843         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7844         unittests/mkdir-recursive-selftests.c,
7845         unittests/observable-selftests.c,
7846         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7847         unittests/parse-connection-spec-selftests.c,
7848         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7849         unittests/scoped_fd-selftests.c,
7850         unittests/scoped_mmap-selftests.c,
7851         unittests/scoped_restore-selftests.c,
7852         unittests/string_view-selftests.c, unittests/style-selftests.c,
7853         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7854         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7855         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7856         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7857         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7858         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7859
7860 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7861
7862         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7863         bool value.
7864         (decode_digits_ordinary): Set explicit_line field in sal.
7865         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7866         symtab_and_line that was set on an explicit line number in
7867         assembler code.  Do always update the recorded symtab and line if
7868         we do skip the prologue.
7869
7870 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7871
7872         * breakpoint.c (set_breakpoint_location_function): Remove
7873         explicit_loc parameter.
7874         (momentary_breakpoint_from_master): Update call to
7875         set_breakpoint_location_function.
7876         (add_location_to_breakpoint): Likewise.
7877
7878 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7879
7880         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7881         required features based on default bfd type when no specific bfd
7882         is present.
7883
7884 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7885
7886         * NEWS: Mention that GDB printf and eval commands can now print
7887         C-style and Ada-style convenience var strings without
7888         calling the inferior.
7889         * printcmd.c (printf_c_string): Locally print GDB internal var
7890         instead of transiting via the inferior.
7891         (printf_wide_c_string): Likewise.
7892
7893 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7894
7895         PR breakpoints/25011
7896         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7897
7898 2019-07-04  Tom Tromey  <tom@tromey.com>
7899
7900         PR tui/24724:
7901         * tui/tui-winsource.c (tui_clear_source_content): Update.
7902         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7903         (tui_update_breakpoint_info): Update.
7904         (tui_set_exec_info_content): Update.
7905         * tui/tui-source.c (tui_set_source_content_nil): Update.
7906         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7907         has_break.
7908         * tui/tui-data.h (enum tui_bp_flag): New.
7909         (tui_bp_flags): New enum flags type.
7910         (struct tui_source_element) <break_mode>: Change type.  Rename
7911         from has_break.
7912         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7913         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7914         constants.
7915         * tui/tui-winsource.h: Fix comment.
7916
7917 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7918
7919         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7920         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7921         (store_fpregs_to_thread)
7922         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7923         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7924         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7925         (IWMMXT_REGS_SIZE): Add define.
7926         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7927         (fetch_vfp_regs, store_vfp_regs)
7928         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7929         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7930
7931 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7932
7933         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7934         defines.
7935         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7936         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7937         (ARM_INT_REGISTER_SIZE): ...to this.
7938         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7939         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7940         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7941         (arm_linux_collect_gregset, supply_nwfpe_register)
7942         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7943         defines.
7944         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7945         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7946         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7947         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7948         (arm_return_in_memory, arm_store_return_value)
7949         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7950         (arm_record_ld_st_multiple): Likewise.
7951         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7952         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7953
7954 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7955
7956         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7957         AARCH64_DISPLACED_MODIFIED_INSNS.
7958         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7959         (aarch64_displaced_step_copy_insn): Likewise.
7960         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7961         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7962         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7963         ARM_DISPLACED_MODIFIED_INSNS.
7964         * arm-tdep.c (arm_gdbarch_init): Likewise.
7965         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7966         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7967         (struct arm_displaced_step_closure): Use
7968         ARM_DISPLACED_MODIFIED_INSNS.
7969
7970 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7971
7972         * features/Makefile: Remove unused xml files.
7973         * features/aarch64.xml: Remove.
7974         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7975         * features/i386/amd64-avx-avx512.xml: Remove.
7976         * features/i386/amd64-avx-linux.xml: Remove.
7977         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7978         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7979         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7980         * features/i386/amd64-avx-mpx.xml: Remove.
7981         * features/i386/amd64-avx.xml: Remove.
7982         * features/i386/amd64-linux.xml: Remove.
7983         * features/i386/amd64-mpx-linux.xml: Remove.
7984         * features/i386/amd64-mpx.xml: Remove.
7985         * features/i386/amd64.xml: Remove.
7986         * features/i386/i386-avx-avx512-linux.xml: Remove.
7987         * features/i386/i386-avx-avx512.xml: Remove.
7988         * features/i386/i386-avx-linux.xml: Remove.
7989         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7990         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7991         * features/i386/i386-avx-mpx-linux.xml: Remove.
7992         * features/i386/i386-avx-mpx.xml: Remove.
7993         * features/i386/i386-avx.xml: Remove.
7994         * features/i386/i386-linux.xml: Remove.
7995         * features/i386/i386-mmx-linux.xml: Remove.
7996         * features/i386/i386-mmx.xml: Remove.
7997         * features/i386/i386-mpx-linux.xml: Remove.
7998         * features/i386/i386-mpx.xml: Remove.
7999         * features/i386/i386.xml: Remove.
8000         * features/i386/x32-avx-avx512-linux.xml: Remove.
8001         * features/i386/x32-avx-linux.xml: Remove.
8002         * features/i386/x32-linux.xml: Remove.
8003
8004 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8005
8006         * regformats/aarch64.dat: Remove.
8007         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
8008         * regformats/i386/amd64-avx-linux.dat: Remove.
8009         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
8010         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
8011         * regformats/i386/amd64-linux.dat: Remove.
8012         * regformats/i386/amd64-mpx-linux.dat: Remove.
8013         * regformats/i386/amd64.dat: Remove.
8014         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
8015         * regformats/i386/i386-avx-linux.dat: Remove.
8016         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
8017         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
8018         * regformats/i386/i386-linux.dat: Remove.
8019         * regformats/i386/i386-mmx-linux.dat: Remove.
8020         * regformats/i386/i386-mpx-linux.dat: Remove.
8021         * regformats/i386/i386.dat: Remove.
8022         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
8023         * regformats/i386/x32-avx-linux.dat: Remove.
8024         * regformats/i386/x32-linux.dat: Remove.
8025
8026 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8027
8028         * aarch64-tdep.c: Remove xml self tests.
8029         * amd64-linux-tdep.c: Likewise.
8030         * amd64-tdep.c: Likewise.
8031         * i386-linux-tdep.c: Likewise.
8032         * i386-tdep.c: Likewise.
8033
8034 2019-07-03  Pedro Alves  <palves@redhat.com>
8035
8036         PR cli/24732
8037         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
8038         (pipe_cmd_option_defs): New.
8039         (make_pipe_cmd_options_def_group): New.
8040         (pipe_command): Use gdb::option::process_options.
8041         (pipe_command_completer): New function.
8042         (_initialize_cli_cmds): Install completer for "pipe" command.
8043
8044 2019-07-03  Pedro Alves  <palves@redhat.com>
8045
8046         * cli/cli-option.c (union option_value) <string>: New field.
8047         (struct option_def_and_value): Add ctor, move ctor, dtor and
8048         use DISABLE_COPY_AND_ASSIGN.
8049         (option_def_and_value::clear_value): New.
8050         (parse_option, save_option_value_in_ctx, get_val_type_str)
8051         (add_setshow_cmds_for_options): Handle var_string.
8052         * cli-option.h (union option_def::var_address) <string>: New
8053         field.
8054         (struct string_option_def): New.
8055         * maint-test-options.c (struct test_options_opts): Add default
8056         ctor and use DISABLE_COPY_AND_ASSIGN.
8057         <string_opt>: New field.
8058         (test_options_opts::~test_options_opts): New.
8059         (test_options_opts::dump): Also dump "-string".
8060         (test_options_option_defs): Install "string.
8061
8062 2019-07-03  Pedro Alves  <palves@redhat.com>
8063
8064         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
8065         option_value with a null enumeration.
8066         (complete_options): Save the option values in the context.
8067         (save_option_value_in_ctx): New, factored out from ...
8068         (process_options): ... here.
8069         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
8070         of the function.
8071         * maint-test-options.c (test_options_opts::dump): New, factored
8072         out from ...
8073         (maintenance_test_options_command_mode): ... here.
8074         (maintenance_test_options_command_completion_result): Delete.
8075         (maintenance_test_options_command_completion_text): Update
8076         comment.
8077         (maintenance_show_test_options_completion_result): Change
8078         prototype.  Just print
8079         maintenance_test_options_command_completion_text.
8080         (save_completion_result): New.
8081         (maintenance_test_options_completer_mode): Pass options context to
8082         complete_options, and then save a dump.
8083         (_initialize_maint_test_options): Use add_cmd to install "maint
8084         show test-options-completion-result".
8085
8086 2019-07-03  Pedro Alves  <palves@redhat.com>
8087
8088         * NEWS (New commands): Mention "with" and "maint with".
8089         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8090         (with_command, with_command_completer): New.
8091         (pipe_command): Adjust to new repeat_previous
8092         interface.
8093         (_initialize_cli_cmds): Install the "with" command and its "w"
8094         alias.
8095         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8096         declarations.
8097         * cli/cli-setshow.c (parse_cli_var_uinteger)
8098         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8099         argument strings for all var_types.
8100         (get_setshow_command_value_string): New, factored out from ...
8101         (do_show_command): ... this.
8102         * cli/cli-setshow.h: Include <string>.
8103         (get_setshow_command_value_string): Declare.
8104         * command.h (repeat_previous): Now returns const char *.  Adjust
8105         comment.
8106         * maint.c: Include "cli/cli-cmds.h".
8107         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8108         (_initialize_maint_cmds): Register the "maintenance with" command.
8109         * top.c (repeat_previous): Move bits from pipe_command here:
8110         Return the saved command line, if any; error out if there's no
8111         command to relaunch.
8112
8113 2019-07-03  Pedro Alves  <palves@redhat.com>
8114
8115         * NEWS (New commands): Mention "maint set/show test-settings"
8116         instead of "maint test-settings".
8117         * maint-test-settings.c (maintenance_test_settings_list): Delete.
8118         (maintenance_test_settings_set_list): Rename to ...
8119         (maintenance_set_test_settings_list): ... this.
8120         (maintenance_test_settings_show_list): Rename to  ...
8121         (maintenance_show_test_settings_list): ... this.
8122         (maintenance_test_settings_cmd): Delete.
8123         (maintenance_test_settings_set_cmd): ...
8124         (maintenance_set_test_settings_cmd): ... this.
8125         (maintenance_test_settings_show_cmd): ...
8126         (maintenance_show_test_settings_cmd): ... this.
8127         (maintenance_test_settings_show_value_cmd):
8128         (maintenance_show_test_settings_value_cmd): ... this.
8129         (_initialize_maint_test_settings): No longer install the "maint
8130         test-settings" prefix command.  Rename "maint test-settings set"
8131         to "maint set test-settings", and "maint test-settings show" to
8132         "maint show test-settings".  Adjust all subcommands.
8133
8134 2019-07-03  Pedro Alves  <palves@redhat.com>
8135
8136         * maint-test-settings.c: Fix file's intro comment.  Replace all
8137         references to "test-options" with references to "test-settings",
8138         in comments.
8139
8140 2019-07-03  Pedro Alves  <palves@redhat.com>
8141
8142         * maint-test-settings.c (maintenance_test_settings_xxx)
8143         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8144         New.
8145         (maintenance_test_settings_enums): Use them.
8146         (maintenance_test_settings_enum): Default to
8147         maintenance_test_settings_xxx.
8148         (_initialize_maint_test_settings): Initialize
8149         MAINTENANCE_TEST_SETTINGS_FILENAME.
8150
8151 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8152
8153         * breakpoint.h (remove_breakpoints_inf): Change return type to
8154         void, move function documentation here.
8155         * breakpoint.c (remove_breakpoints_inf): Change return type to
8156         void, move function documentation to header.
8157
8158 2019-07-02  Pedro Alves  <palves@redhat.com>
8159
8160         * NEWS (Completion improvements): Mention "info threads".
8161         * thread.c (struct info_threads_opts, info_threads_option_defs)
8162         (make_info_threads_options_def_group): New.
8163         (info_threads_command): Use gdb::option::process_options.
8164         (info_threads_command_completer): New.
8165         (_initialize_thread): Use gdb::option::build_help to build the
8166         help text for "info threads".
8167
8168 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8169
8170         * defs.h (generic_load): Move from here...
8171         * symfile.h (generic_load): ... to here.  Rename name parameter
8172         to args.
8173         * symfile.c (generic_load): Add comment.
8174
8175 2019-07-01  Tom Tromey  <tromey@adacore.com>
8176
8177         * dwarf2read.c
8178         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8179         declaration of without_params.  Fix formatting.
8180
8181 2019-07-01  Tom Tromey  <tromey@adacore.com>
8182
8183         * ada-exp.y (find_primitive_type): Update.
8184         * ada-lang.h (ada_lookup_symbol): Update.
8185         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8186         parameter.
8187         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8188
8189 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8190
8191         PR breakpoints/24541
8192         * gdbarch.c: Regenerate.
8193         * gdbarch.h: Regenerate.
8194         * gdbarch.sh: Add 'stap_adjust_register'.
8195         * i386-tdep.c: Include '<unordered_set>'.
8196         (i386_stap_adjust_register): New function.
8197         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8198         * stap-probe.c (stap_parse_register_operand): Call
8199         'gdbarch_stap_adjust_register'.
8200
8201 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8202
8203         PR python/24742
8204         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8205         * python/python.c (do_start_initialization): Use 'xmalloc'
8206         instead of 'PyMem_Malloc'.
8207
8208 2019-06-28  Tom Tromey  <tromey@adacore.com>
8209
8210         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8211         for Ada.
8212
8213 2019-06-27  Tom Tromey  <tromey@adacore.com>
8214
8215         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8216         objfile_key.
8217         (arm_find_mapping_symbol, arm_record_special_symbol)
8218         (_initialize_arm_tdep): Update.
8219         (arm_objfile_data_free): Remove.
8220
8221 2019-06-27  Tom Tromey  <tromey@adacore.com>
8222
8223         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8224         to cp_print_static_field.
8225
8226 2019-06-26  Tom Tromey  <tromey@adacore.com>
8227
8228         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8229         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8230         declare.
8231
8232 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8233
8234         * features/aarch64-core.c (create_feature_aarch64_core):
8235         Regenerate.
8236         * features/aarch64-core.xml: Add cpsr flags.
8237
8238 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8239
8240         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8241         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8242
8243 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8244
8245         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8246         field.
8247         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8248         use.
8249         (arm_record_special_symbol): Don't insert new symbol in sorted
8250         position, push it at the end.
8251
8252 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8253
8254         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8255         (arm_mapping_symbol_s): Remove.
8256         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8257         (arm_mapping_symbol_vec): New typedef.
8258         (struct arm_per_objfile): Add constructor.
8259         <section_maps>: Change type to
8260         std::unique_ptr<arm_mapping_symbol_vec[]>.
8261         (arm_compare_mapping_symbols): Remove.
8262         (arm_find_mapping_symbol): Adjust to section_maps type change.
8263         (arm_objfile_data_free): Call delete on arm_per_objfile.
8264         (arm_record_special_symbol): Adjust to section_maps type change.
8265         Allocate arm_per_objfile with new.
8266
8267 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8268
8269         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8270         with the command prefix.
8271
8272 2019-06-25  Tom Tromey  <tom@tromey.com>
8273
8274         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8275         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8276
8277 2019-06-25  Tom Tromey  <tom@tromey.com>
8278
8279         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8280         type.
8281         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8282         protected.
8283
8284 2019-06-25  Tom Tromey  <tom@tromey.com>
8285
8286         * tui/tui-winsource.c
8287         (tui_source_window_base::set_is_exec_point_at): Add check against
8288         LOA_ADDRESS.
8289
8290 2019-06-25  Tom Tromey  <tom@tromey.com>
8291
8292         * tui/tui-source.c (tui_set_source_content): Don't check before
8293         xfree.
8294         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8295
8296 2019-06-25  Tom Tromey  <tom@tromey.com>
8297
8298         * tui/tui-winsource.h (tui_update_source_window_as_is)
8299         (tui_alloc_source_buffer, tui_line_is_displayed)
8300         (tui_addr_is_displayed): Change type of win_info.
8301         * tui/tui-winsource.c (tui_update_source_window_as_is)
8302         (tui_clear_source_content, tui_show_source_line)
8303         (tui_show_source_content, tui_source_window_base::refill)
8304         (tui_source_window_base::set_is_exec_point_at)
8305         (tui_source_window_base::set_is_exec_point_at)
8306         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8307         (tui_alloc_source_buffer, tui_line_is_displayed)
8308         (tui_addr_is_displayed): Change type of win_info.  Update.
8309         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8310         (tui_source_window_base::do_make_visible_with_new_height):
8311         Update.
8312         * tui/tui-source.c (tui_set_source_content)
8313         (tui_set_source_content_nil)
8314         (tui_source_window::do_scroll_vertical): Update.
8315         * tui/tui-layout.c (show_layout): Update.
8316         * tui/tui-disasm.c (tui_set_disassem_content)
8317         (tui_disasm_window::do_scroll_vertical): Update.
8318         * tui/tui-data.h (tui_win_content): Remove.
8319         (struct tui_gen_win_info) <content, content_size>: Remove.
8320         (struct tui_source_element): Add initializers and destructor.
8321         (union tui_which_element, struct tui_win_element): Remove.
8322         (struct tui_source_window_base) <content>: New field.
8323         (struct tui_data_window): Remove destructor.
8324         (tui_alloc_content, tui_free_win_content)
8325         (tui_free_all_source_wins_content): Don't declare.
8326         * tui/tui-data.c (tui_initialize_static_data): Update.
8327         (init_content_element, tui_alloc_content): Remove.
8328         (~tui_gen_win_info): Update.
8329         (~tui_data_window, tui_free_all_source_wins_content)
8330         (tui_free_win_content, free_content, free_content_elements):
8331         Remove.
8332
8333 2019-06-25  Tom Tromey  <tom@tromey.com>
8334
8335         * tui/tui-winsource.h (tui_clear_source_content)
8336         (tui_erase_source_content, tui_show_source_content): Change type
8337         of win_info.
8338         * tui/tui-winsource.c (tui_clear_source_content)
8339         (tui_erase_source_content, tui_show_source_content): Change type
8340         of win_info.
8341         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8342         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8343         win_info.
8344         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8345         win_info.
8346         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8347
8348 2019-06-25  Tom Tromey  <tom@tromey.com>
8349
8350         * tui/tui-winsource.c (tui_clear_source_content)
8351         (tui_source_window_base::set_is_exec_point_at): Update.
8352         * tui/tui-source.c (tui_set_source_content_nil): Update.
8353         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8354         a bool.
8355         * tui/tui-data.c (init_content_element): Update.
8356
8357 2019-06-25  Tom Tromey  <tom@tromey.com>
8358
8359         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8360         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8361         * tui/tui-layout.c (init_and_make_win): Update.
8362         * tui/tui.h (enum tui_win_type): Update.
8363         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8364         tui_win_is_auxillary.
8365         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8366         tui_win_is_auxillary.
8367
8368 2019-06-25  Tom Tromey  <tom@tromey.com>
8369
8370         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8371         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8372         (tui_delete_data_content_windows, tui_display_all_data)
8373         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8374         Update.
8375         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8376         * tui/tui-regs.c (tui_last_regs_line_no)
8377         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8378         (tui_show_registers): Update.
8379         (tui_show_register_group): Return void.  Update.
8380         (tui_display_registers_from, tui_display_reg_element_at_line)
8381         (tui_display_registers_from_line, tui_check_register_values):
8382         Update.
8383         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8384         member.
8385         (struct tui_data_window) <regs_content>: Now a std::vector.
8386         <regs_content_count>: Remove.
8387         (tui_add_content_elements, tui_free_data_content): Don't declare.
8388         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8389         (init_content_element): Remove DATA_WIN case.  Add assert.
8390         (tui_add_content_elements): Remove.
8391         (tui_data_window): Update.
8392         (tui_free_data_content): Remove.
8393         (free_content_elements): Remove DATA_WIN case.
8394
8395 2019-06-25  Tom Tromey  <tom@tromey.com>
8396
8397         * tui/tui-data.c (tui_data_item_window): Update.
8398         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8399         * tui/tui-windata.c (tui_display_all_data)
8400         (tui_display_data_from_line): Update.
8401         (tui_check_data_values): Remove.
8402         * tui/tui-regs.c (tui_show_register_group)
8403         (tui_display_reg_element_at_line): Update.
8404         * tui/tui-hooks.c (tui_register_changed)
8405         (tui_refresh_frame_and_register_information): Call
8406         tui_check_register_values.
8407         * tui/tui-data.h (struct tui_data_window) <data_content,
8408         data_content_count, data_type>: Remove.
8409         (enum tui_data_type): Remove.
8410
8411         * tui/tui-data.c (tui_data_window::clear_detail)
8412         (~tui_data_window): Update.
8413
8414 2019-06-25  Tom Tromey  <tom@tromey.com>
8415
8416         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8417         declare.
8418         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8419         Rename from tui_first_data_item_displayed.  Update.
8420         (tui_data_window::refresh_all)
8421         (tui_data_window::do_scroll_vertical): Update.
8422         * tui/tui-data.h (struct tui_data_window)
8423         <first_data_item_displayed>: Declare new method.
8424
8425 2019-06-25  Tom Tromey  <tom@tromey.com>
8426
8427         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8428         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8429         contents...
8430         (tui_initialize_static_data): ...here.
8431
8432 2019-06-25  Tom Tromey  <tom@tromey.com>
8433
8434         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8435         (tui_display_registers_from, tui_check_register_values): Update.
8436         (tui_display_register): Remove win_info parameter; update.
8437         (tui_get_register): Change type of parameters.
8438         * tui/tui-data.h (struct tui_data_element): Remove.
8439         (union tui_which_element) <data>: Remove.
8440         <data_window>: Change type.
8441         (struct tui_data_item_window): New.
8442         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8443         case.  Add assert.
8444         (~tui_data_item_window): New destructor.
8445         (free_content_elements): Remove DATA_ITEM_WIN case.
8446
8447 2019-06-25  Tom Tromey  <tom@tromey.com>
8448
8449         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8450         Remove.
8451
8452 2019-06-25  Tom Tromey  <tom@tromey.com>
8453
8454         * tui/tui-data.h (struct tui_command_element): Remove.
8455         (union tui_which_element) <command>: Remove.
8456         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8457         assert.
8458         (free_content_elements): Remove CMD_WIN case.
8459
8460 2019-06-25  Tom Tromey  <tom@tromey.com>
8461
8462         * tui/tui-layout.c (tui_set_layout): Update.
8463         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8464         * tui/tui-data.c (layout_def): Update.
8465
8466 2019-06-25  Tom Tromey  <tom@tromey.com>
8467
8468         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8469         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8470         (tui_source_window_base::set_new_height): Update.
8471         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8472         Update.
8473         (tui_set_locator_fullname, tui_set_locator_info)
8474         (tui_show_frame_info): Update.
8475         * tui/tui-source.c (tui_set_source_content)
8476         (tui_source_is_displayed): Update.
8477         * tui/tui-layout.c (show_source_disasm_command, show_data)
8478         (show_source_or_disasm_and_command): Update.
8479         * tui/tui-disasm.c (tui_set_disassem_content)
8480         (tui_get_begin_asm_address): Update.
8481         * tui/tui-data.h (struct tui_locator_element): Remove.
8482         (union tui_which_element) <locator>: Remove.
8483         (struct tui_locator_window): New.
8484         (tui_locator_win_info_ptr): Change return type.
8485         * tui/tui-data.c (_locator): Change type.
8486         (tui_locator_win_info_ptr): Change return type.
8487         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8488         (tui_alloc_content): Add assert.
8489
8490 2019-06-25  Tom Tromey  <tom@tromey.com>
8491
8492         * tui/tui-winsource.c
8493         (tui_exec_info_window::maybe_allocate_content): New method.
8494         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8495         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8496         (make_source_or_disasm_window): Add cast.
8497         * tui/tui-data.h (union tui_which_element) <simple_string>:
8498         Remove.
8499         (struct tui_source_info): New.
8500         (struct tui_source_window_base) <execution_info>: Change type.
8501         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8502         case, and add assert.
8503         (tui_alloc_content): Add assert.
8504
8505 2019-06-25  Tom Tromey  <tom@tromey.com>
8506
8507         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8508         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8509         * tui/tui-data.c (tui_alloc_win_info): Remove.
8510
8511 2019-06-25  Tom Tromey  <tom@tromey.com>
8512
8513         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8514         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8515         can_highlight.
8516
8517 2019-06-25  Tom Tromey  <tom@tromey.com>
8518
8519         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8520         make_visible_with_new_height method.
8521         (tui_win_info::make_visible_with_new_height): New method.
8522         (tui_source_window_base::do_make_visible_with_new_height)
8523         (tui_data_window::do_make_visible_with_new_height)
8524         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8525         (make_visible_with_new_height): Remove.
8526         (tui_resize_all, tui_adjust_win_heights): Use
8527         make_visible_with_new_height method.
8528         * tui/tui-data.h (struct tui_win_info)
8529         <do_make_visible_with_new_height, make_visible_with_new_height>:
8530         New methods.
8531         (struct tui_source_window_base, struct tui_data_window)
8532         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8533         methods.
8534
8535 2019-06-25  Tom Tromey  <tom@tromey.com>
8536
8537         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8538         method.
8539         (update_tab_width): Call update_tab_width method.
8540         * tui/tui-data.h (struct tui_win_info)
8541         (struct tui_source_window_base) <update_tab_width>: New methods.
8542
8543 2019-06-25  Tom Tromey  <tom@tromey.com>
8544
8545         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8546         parameter.
8547         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8548         parameter.
8549         (tui_gen_win_info::make_visible): Update.
8550         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8551         parameter.
8552         * tui/tui-data.h (enum tui_box): New enum.
8553         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8554
8555 2019-06-25  Tom Tromey  <tom@tromey.com>
8556
8557         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8558         init_and_make_win for EXEC_INFO_WIN.
8559         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8560         longer inline.
8561         (struct tui_win_info) <~tui_win_info>: Inline.
8562         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8563         Don't declare.
8564         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8565         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8566         Remove.
8567         (tui_initialize_static_data): Update.
8568         (~tui_gen_win_info): Handle more cleanup here.
8569         (~tui_source_window_base): Delete "execution_info".
8570         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8571
8572 2019-06-25  Tom Tromey  <tom@tromey.com>
8573
8574         * tui/tui-layout.c (make_command_window): Don't set
8575         can_highlight.
8576         (show_source_disasm_command): Call the reset method.
8577         (show_data): Don't set can_highlight.  Call the reset method.
8578         (tui_gen_win_info::reset): Rename from init_gen_win_info
8579         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8580         (show_source_or_disasm_and_command): Call the reset method.
8581         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8582         (struct tui_cmd_window): Set can_highlight.
8583
8584 2019-06-25  Tom Tromey  <tom@tromey.com>
8585
8586         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8587         from make_visible.
8588         (tui_make_visible, tui_make_invisible): Rewrite.
8589         (tui_win_info::make_visible): Remove.
8590         (tui_source_window_base::make_visible): Update.
8591         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8592         method.  Moved from...
8593         (struct tui_win_info) <make_visible>: ...here.
8594
8595 2019-06-25  Tom Tromey  <tom@tromey.com>
8596
8597         * tui/tui-winsource.c
8598         (tui_source_window_base::do_scroll_horizontal): Remove direction
8599         parameter.
8600         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8601         direction parameter.
8602         * tui/tui-win.c (tui_win_info::forward_scroll)
8603         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8604         (tui_win_info::right_scroll): Update.
8605         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8606         direction parameter.
8607         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8608         direction parameter.
8609         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8610         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8611         Remove direction parameter.
8612         (struct tui_source_window_base, struct tui_source_window)
8613         (struct tui_disasm_window, struct tui_data_window)
8614         (struct tui_cmd_window): Update.
8615
8616 2019-06-25  Tom Tromey  <tom@tromey.com>
8617
8618         * tui/tui-winsource.h (tui_set_exec_info_content)
8619         (tui_show_exec_info_content, tui_erase_exec_info_content)
8620         (tui_clear_exec_info_content, tui_update_exec_info): Change
8621         argument to tui_source_window_base.
8622         * tui/tui-winsource.c (tui_set_exec_info_content)
8623         (tui_show_exec_info_content, tui_erase_exec_info_content)
8624         (tui_clear_exec_info_content, tui_update_exec_info): Change
8625         argument to tui_source_window_base.
8626
8627 2019-06-25  Tom Tromey  <tom@tromey.com>
8628
8629         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8630         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8631
8632 2019-06-25  Tom Tromey  <tom@tromey.com>
8633
8634         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8635         check.
8636
8637 2019-06-25  Tom Tromey  <tom@tromey.com>
8638
8639         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8640         type to void.
8641         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8642         type to void.
8643         * tui/tui-source.c (tui_set_source_content): Update.
8644         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8645
8646 2019-06-25  Tom Tromey  <tom@tromey.com>
8647
8648         * tui/tui-win.c (window_name_completer, tui_set_focus)
8649         (tui_all_windows_info): Use name method.
8650         * tui/tui-data.h (struct tui_gen_win_info)
8651         (struct tui_source_window, struct tui_disasm_window)
8652         (struct tui_data_window, struct tui_cmd_window) <name>: New
8653         method.
8654         (tui_win_name): Don't declare.
8655         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8656         (tui_win_name): Remove.
8657
8658 2019-06-25  Tom Tromey  <tom@tromey.com>
8659
8660         * tui/tui-winsource.h (tui_update_source_window)
8661         (tui_update_source_window_as_is): Change parameter type.
8662         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8663         to be a tui_source_window_base.
8664         (tui_update_source_window_as_is): Likewise.
8665         * tui/tui-win.c (make_visible_with_new_height): Update.
8666
8667 2019-06-25  Tom Tromey  <tom@tromey.com>
8668
8669         * tui/tui-winsource.c (tui_erase_source_content)
8670         (tui_show_source_content, tui_show_exec_info_content)
8671         (tui_erase_exec_info_content): Use refresh_window method.
8672         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8673         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8674         from tui_refresh_win.
8675         (tui_data_window::refresh_window): New method.
8676         (tui_win_info::refresh, tui_source_window_base::refresh)
8677         (tui_refresh_all): Use refresh_window method.
8678         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8679         method.
8680         * tui/tui-regs.c (tui_display_register): Call refresh_window
8681         method.
8682         * tui/tui-layout.c (show_source_disasm_command)
8683         (show_source_or_disasm_and_command): Call refresh_window method.
8684         * tui/tui-data.h (struct tui_gen_win_info)
8685         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8686         New method.
8687
8688 2019-06-25  Tom Tromey  <tom@tromey.com>
8689
8690         * tui/tui.c (tui_rl_other_window, tui_enable)
8691         (tui_is_window_visible, tui_get_command_dimension): Update.
8692         * tui/tui-winsource.c (tui_update_source_window_as_is)
8693         (tui_clear_source_content, tui_erase_source_content)
8694         (tui_show_source_line, tui_source_window_base::refill)
8695         (tui_source_window_base::do_scroll_horizontal)
8696         (tui_source_window_base::set_is_exec_point_at)
8697         (tui_update_breakpoint_info, tui_set_exec_info_content)
8698         (tui_alloc_source_buffer, tui_line_is_displayed)
8699         (tui_addr_is_displayed): Update.
8700         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8701         (tui_check_and_display_highlight_if_needed)
8702         (tui_win_info::make_visible, tui_win_info::refresh)
8703         (tui_refresh_all): Update.
8704         * tui/tui-windata.c (tui_first_data_item_displayed)
8705         (tui_delete_data_content_windows, tui_erase_data_content)
8706         (tui_display_all_data, tui_data_window::refresh_all)
8707         (tui_check_data_values): Update.
8708         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8709         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8710         (tui_win_info::backward_scroll, tui_refresh_all_win)
8711         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8712         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8713         (tui_source_window_base::set_new_height)
8714         (tui_data_window::set_new_height)
8715         (make_invisible_and_set_new_height)
8716         (make_visible_with_new_height, new_height_ok)
8717         (parse_scrolling_args): Update.
8718         * tui/tui-stack.c (tui_show_frame_info): Update.
8719         * tui/tui-source.c (tui_set_source_content)
8720         (tui_set_source_content_nil, tui_source_is_displayed)
8721         (tui_source_window::do_scroll_vertical): Update.
8722         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8723         (tui_display_registers_from, tui_display_reg_element_at_line)
8724         (tui_check_register_values, tui_reg_command): Update.
8725         * tui/tui-layout.c (tui_default_win_height)
8726         (show_source_disasm_command, show_data, init_and_make_win)
8727         (show_source_or_disasm_and_command): Update.
8728         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8729         (tui_redisplay_readline, tui_mld_flush)
8730         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8731         (tui_getc): Update.
8732         * tui/tui-disasm.c (tui_set_disassem_content)
8733         (tui_disasm_window::do_scroll_vertical): Update.
8734         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8735         Now virtual.
8736         (struct tui_win_info): Derive from tui_gen_win_info.
8737         <~tui_win_info>: Mark as override.
8738         <generic>: Remove member.
8739         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8740         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8741         (~tui_data_window, ~tui_win_info)
8742         (tui_free_all_source_wins_content): Update.
8743         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8744
8745 2019-06-25  Tom Tromey  <tom@tromey.com>
8746
8747         * tui/tui-layout.c (init_and_make_win): Use new.
8748         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8749         destructor, initializers.
8750         (tui_alloc_generic_win_info): Don't declare.
8751         * tui/tui-data.c (_locator): Add argument to constructor.
8752         (source_win, disasm_win): New globals.
8753         (exec_info): Remove.
8754         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8755         Update.
8756         (tui_alloc_generic_win_info): Remove.
8757         (init_content_element): Use new.
8758         (tui_win_info::tui_win_info): Update.
8759         (free_content_elements) <case DATA_WIN>: Use delete.
8760
8761 2019-06-25  Tom Tromey  <tom@tromey.com>
8762
8763         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8764         * tui/tui-windata.c (tui_first_data_item_displayed)
8765         (tui_delete_data_content_windows): Update.
8766         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8767         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8768         (tui_display_registers_from, tui_check_register_values): Update.
8769         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8770         pointer.
8771         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8772         window.
8773         (tui_free_data_content): Update.
8774         (free_content_elements) <case DATA_WIN>: Free the window.
8775
8776 2019-06-25  Tom Tromey  <tom@tromey.com>
8777
8778         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8779         Update.
8780         * tui/tui-layout.c (make_command_window)
8781         (show_source_disasm_command, show_data, init_and_make_win)
8782         (show_source_or_disasm_and_command): Update.
8783         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8784         method.
8785         <can_highight, is_highlighted>: Now bool.
8786         (tui_set_win_highlight): Don't declare.
8787         * tui/tui-data.c (tui_set_win_highlight): Remove.
8788
8789 2019-06-25  Tom Tromey  <tom@tromey.com>
8790
8791         * tui/tui-wingeneral.c (make_visible): Remove check of window
8792         type.
8793
8794 2019-06-25  Tom Tromey  <tom@tromey.com>
8795
8796         * tui/tui-win.c (tui_win_info::max_height)
8797         (tui_cmd_window::max_height): New methods.
8798         (new_height_ok): Call max_height.
8799         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8800         <max_height>: New method.
8801
8802 2019-06-25  Tom Tromey  <tom@tromey.com>
8803
8804         * tui/tui-win.c (tui_source_window_base::set_new_height)
8805         (tui_data_window::set_new_height): New methods.
8806         (make_invisible_and_set_new_height): Call set_new_height method.
8807         * tui/tui-data.h (struct tui_win_info)
8808         (struct tui_source_window_base, struct tui_data_window)
8809         <set_new_height>: New method.
8810
8811 2019-06-25  Tom Tromey  <tom@tromey.com>
8812
8813         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8814         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8815         tui_refresh_data_win.
8816         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8817         method.
8818         (tui_refresh_all_win): Call the refresh_all method.
8819         (tui_set_focus): Likewise.
8820         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8821         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8822         Likewise.
8823
8824 2019-06-25  Tom Tromey  <tom@tromey.com>
8825
8826         * tui/tui-winsource.h (tui_refill_source_window)
8827         (tui_set_is_exec_point_at): Don't declare.
8828         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8829         (tui_source_window_base::refill): Rename from
8830         tui_refill_source_window.
8831         (tui_source_window_base::do_scroll_horizontal): Update.
8832         (tui_source_window_base::set_is_exec_point_at): Rename from
8833         tui_set_is_exec_point_at.
8834         (tui_update_all_breakpoint_info): Update.
8835         * tui/tui-stack.c (tui_show_frame_info): Update.
8836         * tui/tui-layout.c (show_data): Add cast.
8837         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8838         * tui/tui-data.h (struct tui_source_window_base) <refill,
8839         set_is_exec_point_at>: New methods.
8840         (tui_source_windows, tui_add_to_source_windows): Update types.
8841         (tui_add_to_source_windows): Remove redundant declaration.
8842         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8843         (tui_source_windows): Change return type.
8844         (tui_clear_source_windows_detail): Update.
8845         (tui_add_to_source_windows): Change type of parameter.
8846         (tui_free_all_source_wins_content): Update.
8847
8848 2019-06-25  Tom Tromey  <tom@tromey.com>
8849
8850         * tui/tui-wingeneral.c (tui_win_info::refresh)
8851         (tui_source_window_base::refresh): New methods.
8852         (tui_refresh_all): Call the refresh method.
8853         * tui/tui-data.h (struct tui_win_info)
8854         (struct tui_source_window_base) <refresh>: New method.
8855
8856 2019-06-25  Tom Tromey  <tom@tromey.com>
8857
8858         * tui/tui.h (tui_is_window_visible): Return bool.
8859         * tui/tui.c (tui_is_window_visible): Return bool.
8860         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8861         (tui_make_visible, tui_make_invisible)
8862         (tui_win_info::make_visible)
8863         (tui_source_window_base::make_visible, make_all_visible)
8864         (tui_make_all_visible, tui_make_all_invisible): Update.
8865         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8866         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8867         bool.
8868         (struct tui_win_info, struct tui_source_window_base)
8869         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8870         * tui/tui-data.c (tui_init_generic_part): Update.
8871
8872 2019-06-25  Tom Tromey  <tom@tromey.com>
8873
8874         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8875         (tui_source_window_base::make_visible): New methods.
8876         (make_all_visible): Make method call.
8877         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8878         (struct tui_source_window_base, struct tui_cmd_window): Override
8879         make_visible.
8880         (tui_win_is_source_type): Don't declare.
8881         * tui/tui-data.c (tui_win_is_source_type): Remove.
8882
8883 2019-06-25  Tom Tromey  <tom@tromey.com>
8884
8885         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8886         NULL check.
8887
8888 2019-06-25  Tom Tromey  <tom@tromey.com>
8889
8890         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8891         Inline constructor.  Add initializers for members.
8892         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8893         constructors; now inline in class.
8894
8895 2019-06-25  Tom Tromey  <tom@tromey.com>
8896
8897         * tui/tui-regs.c (tui_show_registers): Update.
8898         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8899         bool.
8900         * tui/tui-data.c (tui_data_window::clear_detail)
8901         (tui_data_window): Update.
8902
8903 2019-06-25  Tom Tromey  <tom@tromey.com>
8904
8905         * tui/tui-windata.c (tui_display_all_data)
8906         (tui_display_data_from_line, tui_display_data_from)
8907         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8908         Update.
8909         * tui/tui-regs.c (tui_last_regs_line_no)
8910         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8911         (tui_show_registers, tui_show_register_group)
8912         (tui_display_registers_from, tui_display_reg_element_at_line)
8913         (tui_display_registers_from_line, tui_check_register_values)
8914         (tui_reg_next, tui_reg_prev): Update.
8915         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8916         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8917         tui_data_window.
8918         (struct tui_win_info) <detail>: Remove.  Add new fields from
8919         tui_data_info.
8920         (TUI_DATA_WIN): Add cast.
8921         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8922         (~tui_data_window): Simplify.
8923
8924 2019-06-25  Tom Tromey  <tom@tromey.com>
8925
8926         * tui/tui-layout.c (show_source_disasm_command)
8927         (show_source_or_disasm_and_command): Update.
8928         * tui/tui-io.c (update_cmdwin_start_line)
8929         (tui_redisplay_readline): Update.
8930         * tui/tui-data.h (struct tui_command_info): Remove.
8931         (struct tui_win_info) <detail>: Remove command_info member.
8932         (struct tui_data_window) <start_line>: New member, from
8933         tui_command_info.
8934         (TUI_CMD_WIN): Add casts.
8935
8936 2019-06-25  Tom Tromey  <tom@tromey.com>
8937
8938         * tui/tui-winsource.c (tui_update_source_window)
8939         (tui_refill_source_window)
8940         (tui_source_window_base::do_scroll_horizontal)
8941         (tui_update_breakpoint_info, tui_set_exec_info_content)
8942         (tui_show_exec_info_content, tui_erase_exec_info_content)
8943         (tui_clear_exec_info_content): Update.
8944         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8945         Update.
8946         * tui/tui-win.c (make_invisible_and_set_new_height)
8947         (make_visible_with_new_height): Update.
8948         * tui/tui-source.c (tui_set_source_content)
8949         (tui_show_symtab_source): Update.
8950         * tui/tui-layout.c (extract_display_start_addr)
8951         (show_source_disasm_command, show_data)
8952         (make_source_or_disasm_window)
8953         (show_source_or_disasm_and_command): Update.
8954         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8955         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8956         "gdbarch".
8957         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8958         to tui_source_window_base.
8959         (struct tui_win_info) <detail>: Remove source_info member.
8960         (struct tui_source_window_base) <has_locator>: Inline.
8961         Move contents from tui_source_info; rename has_locator member to
8962         m_has_locator.
8963         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8964         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8965         header file.
8966         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8967         Simplify.
8968         (tui_free_all_source_wins_content): Cast to
8969         tui_source_window_base.
8970
8971 2019-06-25  Tom Tromey  <tom@tromey.com>
8972
8973         * tui/tui-win.c (make_invisible_and_set_new_height)
8974         (make_visible_with_new_height): Call has_locator method.
8975         * tui/tui-layout.c (show_source_disasm_command, show_data)
8976         (show_source_or_disasm_and_command): Update for bool change.
8977         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8978         (tui_win_info) <has_locator>: New method.
8979         (struct tui_source_window_base) <has_locator>: New method.
8980         (tui_win_has_locator): Don't declare.
8981         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8982         from tui_win_has_locator.
8983         (tui_source_window_base): Use false, not FALSE.
8984
8985 2019-06-25  Tom Tromey  <tom@tromey.com>
8986
8987         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8988         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8989         clear_detail method directly.
8990         (tui_clear_win_detail): Remove.
8991
8992 2019-06-25  Tom Tromey  <tom@tromey.com>
8993
8994         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8995         "this", not TUI_DISASM_WIN.
8996
8997 2019-06-25  Tom Tromey  <tom@tromey.com>
8998
8999         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
9000         declare.
9001         * tui/tui-winsource.c
9002         (tui_source_window_base::do_scroll_horizontal): Rename from
9003         tui_horizontal_source_scroll.
9004         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
9005         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
9006         from tui_vertical_data_scroll.
9007         * tui/tui-win.h (tui_scroll): Don't declare.
9008         * tui/tui-win.c (tui_win_info::forward_scroll)
9009         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
9010         (tui_win_info::right_scroll): Rename and update.
9011         (tui_scroll_forward_command, tui_scroll_backward_command)
9012         (tui_scroll_left_command, tui_scroll_right_command): Update.
9013         (tui_scroll): Remove.
9014         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
9015         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
9016         from tui_vertical_source_scroll.
9017         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
9018         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
9019         from tui_vertical_disassem_scroll.
9020         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
9021         do_scroll_horizontal>: New methods.
9022         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
9023         Likewise.
9024         (struct tui_source_window_base): Add do_scroll_horizontal.
9025         (struct tui_source_window, struct tui_disasm_window): Add
9026         do_scroll_vertical.
9027         (struct tui_data_window, struct tui_cmd_window): Add
9028         do_scroll_horizontal and do_scroll_vertical.
9029         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
9030
9031 2019-06-25  Tom Tromey  <tom@tromey.com>
9032
9033         * tui/tui-data.h (struct tui_source_window_base): New struct.
9034         (struct tui_source_window): Derive from tui_source_window_base.
9035         (struct tui_disasm_window): New struct.
9036         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
9037         from tui_source_window::clear_detail.
9038         (tui_source_window_base): Rename from tui_source_window.
9039         (~tui_source_window_base): Rename from ~tui_source_window.
9040         (tui_alloc_win_info): Create a tui_disasm_window.
9041
9042 2019-06-25  Tom Tromey  <tom@tromey.com>
9043
9044         * tui/tui-data.h (struct tui_source_window)
9045         (struct tui_data_window): Declare destructors.
9046         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
9047         destructors.
9048         (tui_win_info): Simplify.
9049
9050 2019-06-25  Tom Tromey  <tom@tromey.com>
9051
9052         * tui/tui-winsource.c (tui_display_main)
9053         (tui_update_source_windows_with_addr)
9054         (tui_update_all_breakpoint_info): Update.
9055         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
9056         (new_height_ok, parse_scrolling_args): Update.
9057         * tui/tui-stack.c (tui_show_frame_info): Update.
9058         * tui/tui-data.h (struct tui_list): Remove.
9059         (tui_source_windows): Return a reference to a std::vector.
9060         * tui/tui-data.c (source_windows): Now a std::vector.
9061         (tui_source_windows): Change return type.
9062         (tui_clear_source_windows): Rewrite.
9063         (tui_clear_source_windows_detail, tui_add_to_source_windows)
9064         (tui_free_all_source_wins_content): Rewrite.
9065
9066 2019-06-25  Tom Tromey  <tom@tromey.com>
9067
9068         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
9069         (struct tui_data_window, struct tui_cmd_window): Declare
9070         clear_detail method.
9071         * tui/tui-data.c (tui_source_window::clear_detail)
9072         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
9073         methods.
9074         (tui_clear_win_detail): Simplify.
9075
9076 2019-06-25  Tom Tromey  <tom@tromey.com>
9077
9078         * tui/tui-layout.c (make_source_window, make_disasm_window)
9079         (make_source_or_disasm_window): Remove win_info_ptr parameter.
9080         Return the new window.
9081         (show_source_disasm_command, show_data)
9082         (show_source_or_disasm_and_command): Update.
9083
9084 2019-06-25  Tom Tromey  <tom@tromey.com>
9085
9086         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9087         parameter.  Return the new window.
9088         (show_source_disasm_command): Update and remove NULL check.
9089         (show_source_or_disasm_and_command): Update.
9090
9091 2019-06-25  Tom Tromey  <tom@tromey.com>
9092
9093         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9094
9095 2019-06-25  Tom Tromey  <tom@tromey.com>
9096
9097         * tui/tui-data.h (struct tui_win_info): Make constructor
9098         protected.  Make destructor virtual.  Add initializers.
9099         (tui_source_window, tui_data_window, tui_cmd_window): New
9100         classes.
9101         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
9102         constructor.  Add "type" parameter.
9103         (tui_source_window, tui_data_window, tui_cmd_window): New
9104         constructors.
9105         (tui_alloc_win_info): Instantiate the appropriate subclass.
9106
9107 2019-06-25  Tom Tromey  <tom@tromey.com>
9108
9109         * tui/tui-win.c (tui_resize_all): Use delete.
9110         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9111         destructor.
9112         (tui_free_window): Don't declare.
9113         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9114         Update.
9115
9116 2019-06-25  Tom Tromey  <tom@tromey.com>
9117
9118         * tui/tui-data.h (struct tui_win_info): Add constructor.
9119         * tui/tui-data.c (tui_alloc_win_info): Use new.
9120         (tui_free_window): Use delete.
9121
9122 2019-06-22  Tom Tromey  <tom@tromey.com>
9123
9124         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9125         declare.
9126         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9127
9128 2019-06-22  Tom Tromey  <tom@tromey.com>
9129
9130         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9131         declare.
9132         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9133
9134 2019-06-22  Tom de Vries  <tdevries@suse.de>
9135
9136         * dwarf2read.c (create_addrmap_from_aranges)
9137         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9138         instead of '%zu'.
9139
9140 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
9141
9142         * dwarf2read.h (dwarf2_section_info_def): Remove.
9143         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9144         * dwarf2read.c (struct dwo_sections) <types>: Change type to
9145         std::vector<dwarf2_section_info>.
9146         (struct dwo_file) <~dwo_file>: Remove.
9147         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9148         types field.
9149         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9150         (dwarf2_read_debug_names): Likewise.
9151         (create_debug_types_hash_table): Change parameter type to
9152         array_view, adjust code accordingly.
9153         (dwarf2_locate_dwo_sections): Adjust to std::vector.
9154         (partial_die_info::fixup): Likewise.
9155         (determine_prefix): Likewise.
9156         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9157
9158 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9159
9160         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9161         gdb_bfd_ref_ptr.
9162         <~dwo_file>: Remove call to gdb_bfd_unref.
9163         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9164         gdb_bfd_ref_ptr::get.
9165
9166 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9167
9168         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9169         type to htab_up.
9170         * dwarf2read.c (struct dwo_file): Initialize fields.
9171         <~dwo_file>: New.
9172         (free_dwo_file): Remove, move content to ~dwo_file.
9173         (struct dwo_file_deleter): Remove.
9174         (dwo_file_up>: Remove custom deleter.
9175         (free_dwo_files): Remove.
9176         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9177         dwo_files.
9178         (process_skeletonless_type_units): Call unique_ptr::get.
9179         (allocate_dwo_file_hash_table): Add deleter to created hash
9180         table.  Change return type to htab_up.
9181         (lookup_dwo_file_slot): Don't memset dwo_file, call
9182         unique_ptr::get.
9183         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9184         (create_dwo_unit_in_dwp_v2): Likewise.
9185         (open_and_init_dwo_file): Likewise.
9186         (free_dwo_file_from_slot): Remove.
9187
9188 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9189
9190         * dwarf2read.h (struct dwarf2_section_info) <readin,
9191         is_virtual>: Change type to bool.
9192         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9193         true instead of 1.
9194
9195 2019-06-19  Tom Tromey  <tom@tromey.com>
9196
9197         * tui/tui-data.h (tui_init_content_element): Don't declare.
9198
9199 2019-06-19  Tom Tromey  <tom@tromey.com>
9200
9201         * tui/tui-data.h (tui_init_win_info): Don't declare.
9202
9203 2019-06-19  Tom de Vries  <tdevries@suse.de>
9204
9205         * dwarf2read.h (abstract_to_concrete): Change type to
9206         std::unordered_map<sect_offset, std::vector<sect_offset>,
9207         gdb::hash_enum<sect_offset>>.
9208
9209 2019-06-19  Tom Tromey  <tromey@adacore.com>
9210
9211         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9212         EVAL_AVOID_SIDE_EFFECTS specially.
9213
9214 2019-06-19  Tom Tromey  <tromey@adacore.com>
9215
9216         * source-cache.c (highlighter): New global.
9217         (source_cache::get_source_lines): Create a highlighter on demand.
9218
9219 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9220
9221         * defs.h (deprecated_interactive_hook): Delete declaration.
9222         * interps.c (clear_interpreter_hooks): Remove use of
9223         deprecated_interactive_hook.
9224         * top.c (deprecated_interactive_hook): Delete definition.
9225         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9226
9227 2019-06-18  Tom de Vries  <tdevries@suse.de>
9228
9229         PR gdb/24515
9230         * dwarf2read.h (abstract_to_concrete): Change type from
9231         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9232         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9233         * dwarf2read.c (read_variable): Update.
9234         (dwarf2_fetch_die_loc_sect_off): Update.
9235
9236 2019-06-17  Tom de Vries  <tdevries@suse.de>
9237
9238         PR gdb/24617
9239         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9240         accessing parent[parent_len - 1].
9241
9242 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9243
9244         PR gdb/24364
9245         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9246         call dtrace_process_dof with NULL dof.
9247
9248 2019-06-16  Tom de Vries  <tdevries@suse.de>
9249
9250         PR gdb/24445
9251         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9252
9253 2019-06-16  Tom Tromey  <tom@tromey.com>
9254
9255         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9256         (make_all_visible): Use address of member.
9257
9258 2019-06-16  Tom Tromey  <tom@tromey.com>
9259
9260         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9261         (tui_free_window, free_content, free_content_elements): Remove
9262         unnecessary cast.
9263         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9264         cast.
9265         * tui/tui-regs.c (tui_show_register_group)
9266         (tui_display_registers_from, tui_display_reg_element_at_line):
9267         Remove unnecessary cast.
9268
9269 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9270
9271         * linux-nat.c (normal_mask): Delete.
9272         (_initialize_linux_nat): Don't initialise normal_mask.
9273
9274 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9275
9276         PR gdb/24445
9277         * dwarf-index-write.h (write_psymtabs_to_index): Add
9278         dwz_basename parameter.
9279         * dwarf-index-write.c (write_gdbindex): Move file writing to
9280         write_gdbindex_1.  Change return type void.
9281         (assert_file_size): Move up, remove filename parameter.
9282         (write_gdbindex_1): New function.
9283         (write_debug_names): Change return type to void, call
9284         assert_file_size.
9285         (struct index_wip_file): New struct.
9286         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9287         file logic to index_wip_file.  Write index for dwz file if
9288         needed.
9289         (save_gdb_index_command): Pass basename of dwz file, if present.
9290         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9291         build-id of dwz file, if present.
9292         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9293         (dwarf2_get_dwz_file): Likewise.
9294         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9295         (dwarf2_get_dwz_file): Likewise.
9296
9297 2019-06-16  Tom Tromey  <tom@tromey.com>
9298
9299         * coffread.c (process_coff_symbol): Use xstrdup.
9300         * value.c (create_internalvar): Use xstrdup.
9301
9302 2019-06-16  Tom Tromey  <tom@tromey.com>
9303
9304         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9305         * breakpoint.c (stopin_command, stopat_command)
9306         (until_break_command, decode_location_default): Remove unnecessary
9307         cast.
9308         * utils.c (subset_compare): Remove unnecessary cast.
9309         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9310         cast.
9311         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9312         cast.
9313         * infcmd.c (path_command): Remove unnecessary cast.
9314         * coffread.c (decode_type): Remove unnecessary cast.
9315         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9316         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9317         * tui/tui-stack.c (tui_show_locator_content)
9318         (tui_show_frame_info): Remove unnecessary cast.
9319         * tui/tui-win.c (tui_scroll_forward_command)
9320         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9321         (parse_scrolling_args): Remove unnecessary cast.
9322         * tui/tui-data.c (init_win_info, tui_del_window)
9323         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9324         (free_content_elements): Remove unnecessary cast.
9325         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9326         unnecessary cast.
9327         * tui/tui-source.c (tui_set_source_content)
9328         (tui_vertical_source_scroll): Remove unnecessary cast.
9329         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9330         cast.
9331         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9332         * tui/tui-regs.c (tui_display_registers_from)
9333         (tui_display_register): Remove unnecessary cast.
9334         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9335         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9336         (make_visible): Remove unnecessary cast.
9337         * tui/tui-winsource.c (tui_erase_source_content)
9338         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9339         unnecessary cast.
9340         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9341         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9342         * stabsread.c (read_type, read_array_type, read_range_type):
9343         Remove unnecessary cast.
9344         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9345         (parse_symbol, parse_type, upgrade_type, parse_external)
9346         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9347         unnecessary cast.
9348         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9349
9350 2019-06-16  Tom Tromey  <tom@tromey.com>
9351
9352         * tui/tui-data.c (tui_alloc_generic_win_info)
9353         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9354         checks.
9355
9356 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9357             Andrew Burgess  <andrew.burgess@embecosm.com>
9358
9359         * f-typeprint.c (f_print_type): Don't return early for not
9360         associated or not allocated types.
9361         (f_type_print_varspec_suffix): Add print_rank parameter and print
9362         ranks of array types in case they dangling.
9363         (f_type_print_base): Add print_rank parameter.
9364
9365 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9366
9367         * NEWS: Mention new MI commands.
9368         * break-catch-throw.c (enum exception_event_kind): Move to
9369         breakpoint.h.
9370         (print_mention_exception_catchpoint): Output text as a single
9371         message.
9372         (catch_exception_command_1): Rename to...
9373         (catch_exception_event): ...this, make non-static, update header
9374         command, and change some parameter types.
9375         (catch_catch_command): Update for changes to
9376         catch_exception_command_1.
9377         (catch_throw_command): Likewise.
9378         (catch_rethrow_command): Likewise.
9379         * breakpoint.c (enum exception_event_kind): Delete.
9380         * breakpoint.h (enum exception_event_kind): Moved here from
9381         break-catch-throw.c.
9382         (catch_exception_event): Declare.
9383         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9384         (mi_cmd_catch_throw): New function.
9385         (mi_cmd_catch_rethrow): New function.
9386         (mi_cmd_catch_catch): New function.
9387         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9388         'catch-catch' entries.
9389         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9390         (mi_cmd_catch_rethrow): Declare.
9391         (mi_cmd_catch_catch): Declare.
9392
9393 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9394
9395         * annotate.c (annotate_source_line): Change return type to void,
9396         update implementation to match.
9397         * annotate.h (annotate_source_line): Change return type to void,
9398         update header comment.
9399         * stack.c (print_frame_info): Don't change what frame information
9400         is printed based on whether annotations are on or not.
9401
9402 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9403
9404         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9405         (annotate_source): Make static.
9406         (annotate_source_line): Moved from source.c and renamed from
9407         identify_source_line.  Update the return type.
9408         * annotate.h (annotate_source): Delete declaration.
9409         (annotate_source_line): Declaration moved from source.h, and
9410         renamed from identify_source_line.  Return type updated.
9411         * source.c (identify_source_line): Moved to annotate.c and renamed
9412         to annotate_source_line.
9413         (info_line_command): Remove check of annotation_level.
9414         * source.h (identify_source_line): Move declaration to annotate.h
9415         and rename to annotate_source_line.
9416         * stack.c: Add 'annotate.h' include.
9417         (print_frame_info): Remove check of annotation_level before
9418         calling annotate_source_line.
9419
9420 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9421
9422         * source-cache.c (source_cache::get_plain_source_lines): Use
9423         open_source_file_with_line_charpos instead of just
9424         open_source_file, remove call to find_source_lines.
9425         (source_cache::get_source_lines): Likewise.
9426         * source.c (find_source_lines): Make static.
9427         (get_filename_and_charpos): Renamed into...
9428         (open_source_file_with_line_charpos): ..this along with changes to
9429         return a scoped_fd, and some other minor clean ups.
9430         (identify_source_line): Use open_source_file_with_line_charpos.
9431         (search_command_helper): Use open_source_file_with_line_charpos
9432         instead of just open_source_file, remove call to
9433         find_source_lines.
9434         * source.h (open_source_file_with_line_charpos): Declare new
9435         function.
9436         (find_source_lines): Delete declaration.
9437
9438 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9439
9440         * source.c (get_filename_and_charpos): Remove fullname
9441         parameter.
9442         (identify_source_line): Update call to get_filename_and_charpos.
9443
9444 2019-06-14  Tom Tromey  <tromey@adacore.com>
9445
9446         PR gdb/24502:
9447         * ui-style.h (skip_ansi_escape): Update comment.
9448         * ui-file.h (class no_terminal_escape_file): New class.
9449         * ui-file.c (no_terminal_escape_file::write)
9450         (no_terminal_escape_file::puts): New methods.
9451         * cli/cli-logging.c (handle_redirections): Use
9452         no_terminal_escape_file.
9453
9454 2019-06-14  Tom Tromey  <tromey@adacore.com>
9455
9456         * NEWS: Move convenience variable news above Python news.
9457
9458 2019-06-14  Tom Tromey  <tom@tromey.com>
9459
9460         * gnulib: Move directory to top-level.
9461         * configure.ac: Don't configure gnulib.
9462         * configure: Rebuild.
9463         * common/common-defs.h: Use new path to gnulib.
9464         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9465         (GNULIB_H): Remove.
9466         (INCGNU): Look in new gnulib location.
9467         (HFILES_NO_SRCDIR): Remove gnulib files.
9468         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9469         (generated_files): Remove GNULIB_H.
9470         ($(LIBGNU), all-lib): Remove targets.
9471         (distclean): Don't mention GNULIB_BUILDDIR.
9472         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9473
9474 2019-06-14  Tom Tromey  <tromey@adacore.com>
9475
9476         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9477         Warn if symbol file does not provide any symbols.
9478
9479 2019-06-14  Tom Tromey  <tromey@adacore.com>
9480
9481         * source.c (find_and_open_source): Respect basenames_may_differ.
9482
9483 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9484
9485         * annotate.c (annotate_breakpoints_invalid): Make use of
9486         scoped_restore_terminal_state.
9487         (annotate_frames_invalid): Likewise.
9488
9489 2019-06-14  Tom Tromey  <tromey@adacore.com>
9490
9491         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9492         allow assignment to an internalvar.
9493
9494 2019-06-14  Tom Tromey  <tromey@adacore.com>
9495
9496         * ada-lex.l: Allow "_" in attribute names.
9497
9498 2019-06-14  Tom Tromey  <tromey@adacore.com>
9499
9500         PR gdb/24653:
9501         * regcache.c (registers_changed): Don't call alloca.
9502         * top.c (execute_command): Don't call alloca.
9503
9504 2019-06-13  Pedro Alves  <palves@redhat.com>
9505
9506         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9507         'expression'.  When parsing an expression, error out if there's
9508         junk after "unlimited".
9509         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9510         (do_set_command): Adjust calls to is_unlimited_literal.
9511
9512 2019-06-13  Pedro Alves  <palves@redhat.com>
9513
9514         * compile/compile.c (make_compile_options_def_group): Add braces
9515         around array_view initializer.
9516         * thread.c (make_thread_apply_all_options_def_group)
9517         (make_thread_apply_all_options_def_group): Likewise.
9518
9519 2019-06-13  Pedro Alves  <palves@redhat.com>
9520
9521         * NEWS (New commands): Mention "maint test-options
9522         require-delimiter", "maint test-options unknown-is-error", "maint
9523         test-options unknown-is-operand" and "maint show
9524         test-options-completion-result".
9525         (New command options, command completion): New section.
9526         (Completion improvements): New section.
9527         Mention that you can abbreviate "unlimited".
9528
9529 2019-06-13  Pedro Alves  <palves@redhat.com>
9530
9531         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9532         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9533         * unittests/cli-utils-selftests.c (test_parse_flags)
9534         (test_parse_flags_qcs): Delete.
9535         (test_cli_utils): Don't call deleted functions.
9536
9537 2019-06-13  Pedro Alves  <palves@redhat.com>
9538
9539         * thread.c: Include "cli/cli-option.h".
9540         (tp_array_compar_ascending): Global.
9541         (tp_array_compar): Delete function.
9542         (tp_array_compar_ascending, tp_array_compar_descending): New
9543         functions.
9544         (ascending_option_def, qcs_flag_option_def)
9545         (thr_qcs_flags_option_defs)
9546         (make_thread_apply_all_options_def_group)
9547         (make_thread_apply_options_def_group): New.
9548         (thread_apply_all_command): Use gdb::option::process_options.
9549         (thread_apply_command_completer)
9550         (thread_apply_all_command_completer): New.
9551         (thread_apply_command): Use gdb::option::process_options.
9552         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9553         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9554         to generate help text of "thread apply".  Adjust "taas"'s help.
9555         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9556         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9557
9558 2019-06-13  Pedro Alves  <palves@redhat.com>
9559
9560         * thread.c (thread_apply_command): Check for invalid TID with
9561         isdigit instead of !isalpha.
9562
9563 2019-06-13  Pedro Alves  <palves@redhat.com>
9564
9565         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9566         (validate_flags_qcs): New.
9567         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9568         (validate_flags_qcs): Declare.
9569         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9570         (make_frame_apply_options_def_group): New.
9571         (frame_apply_command_count): Process options with
9572         gdb::option::process_options.
9573         (frame_apply_completer): New.
9574         (frame_apply_level_completer, frame_apply_all_completer)
9575         (frame_apply_completer): New.
9576         (_initialize_stack): Update help of "frame apply", "frame apply
9577         level", "frame apply all" and "faas" to mention supported options
9578         and install command completers.
9579         * stack.h (frame_apply_all_completer): Declare.
9580         * thread.c: Include "stack.h".
9581         (tfaas_command): Add "--".
9582         (_initialize_thread): Update help "tfaas" to mention supported
9583         options and install command completer.
9584
9585 2019-06-13  Pedro Alves  <palves@redhat.com>
9586
9587         * completer.c (complete_nested_command_line): New.
9588         (gdb_completion_word_break_characters_throw): Add assertion.
9589         * completer.h (complete_nested_command_line): Declare.
9590
9591 2019-06-13  Pedro Alves  <palves@redhat.com>
9592
9593         * stack.c (parse_backtrace_qualifiers): New.
9594         (backtrace_command): Use it.
9595         (backtrace_command_completer): Complete on qualifiers.
9596
9597 2019-06-13  Pedro Alves  <palves@redhat.com>
9598
9599         * frame.c: Include "cli/cli-option.h.
9600         (user_set_backtrace_options): New.
9601         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9602         Delete.
9603         (get_prev_frame): Adjust.
9604         (boolean_option_def, uinteger_option_def)
9605         (set_backtrace_option_defs): New.
9606         (_initialize_frame): Adjust and use
9607         gdb::option::add_setshow_cmds_for_options to install "set
9608         backtrace past-main" and "set backtrace past-entry".
9609         * frame.h: Include "cli/cli-option.h".
9610         (struct frame_print_options): Forward declare.
9611         (print_frame_arguments_all, print_frame_arguments_scalars)
9612         (print_frame_arguments_none): Declare.
9613         (print_entry_values): Delete declaration.
9614         (struct frame_print_options, user_frame_print_options): New.
9615         (struct set_backtrace_options): New.
9616         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9617         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9618         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9619         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9620         (list_args_or_locals): Add frame_print_options parameter.
9621         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9622         * python/py-framefilter.c (enumerate_args): Pass down
9623         USER_FRAME_PRINT_OPTIONS.
9624         * stack.c: Include "cli/cli-option.h".
9625         (print_frame_arguments_all, print_frame_arguments_scalars)
9626         (print_frame_arguments_none): Declare.
9627         (print_raw_frame_arguments, print_entry_values): Delete.
9628         (user_frame_print_options): New.
9629         (boolean_option_def, enum_option_def, frame_print_option_defs):
9630         New.
9631         (struct backtrace_cmd_options): New.
9632         (bt_flag_option_def): New.
9633         (backtrace_command_option_defs): New.
9634         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9635         (print_frame_arg, read_frame_arg, print_frame_args)
9636         (print_frame_info, print_frame): Add frame_print_options parameter
9637         and use it.
9638         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9639         (backtrace_command_1): Add frame_print_options and
9640         backtrace_cmd_options parameters and use them.
9641         (make_backtrace_options_def_group): New.
9642         (backtrace_command): Process command options with
9643         gdb::option::process_options.
9644         (backtrace_command_completer): New.
9645         (_initialize_stack): Extend "backtrace"'s help to mention
9646         supported options.  Install completer for "backtrace".
9647         Install some settings commands with add_setshow_cmds_for_options.
9648
9649 2019-06-13  Pedro Alves  <palves@redhat.com>
9650
9651         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9652         and that "set/show print raw frame-arguments" are now deprecated.
9653
9654         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9655         command.
9656         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9657         * stack.c (_initialize_stack): Install "set/show print
9658         raw-frame-arguments", and deprecate "set/show print raw
9659         frame-arguments".
9660         * valprint.c (_initialize_valprint): Deprecate "set/show print
9661         raw".
9662
9663 2019-06-13  Pedro Alves  <palves@redhat.com>
9664
9665         * compile/compile.c (struct compile_options): New.
9666         (compile_flag_option_def, compile_command_option_defs)
9667         (make_compile_options_def_group): New.
9668         (compile_file_command): Handle options with
9669         gdb::option::process_options.
9670         (compile_file_command_completer): New function.
9671         (compile_code_command): Handle options with
9672         gdb::option::process_options.
9673         (compile_code_command_completer): New function.
9674         (_initialize_compiler): Install completers for "compile code" and
9675         "compile file".  Mention available options in "compile code" and
9676         "compile code"'s help.
9677         * completer.c (advance_to_completion_word): New, factored out from
9678         ...
9679         (advance_to_expression_complete_word_point): ... this.
9680         (advance_to_filename_complete_word_point): New.
9681         * completer.h (advance_to_filename_complete_word_point): New
9682         declaration.
9683
9684 2019-06-13  Pedro Alves  <palves@redhat.com>
9685
9686         * compile/compile.c: Include "cli/cli-option.h".
9687         (compile_print_value): Scope data pointer is now a
9688         value_print_options pointer; adjust.
9689         (compile_print_command): Process options.  Scope data pointer is
9690         now a value_print_options pointer; adjust.
9691         (_initialize_compile): Update "compile print"'s help to include
9692         supported options.  Install a completer for "compile print".
9693         * cp-valprint.c (show_vtblprint, show_objectprint)
9694         (show_static_field_print): Delete.
9695         (_initialize_cp_valprint): Don't install "set print
9696         static-members", "set print vtbl", "set print object" here.
9697         * printcmd.c: Include "cli/cli-option.h" and
9698         "common/gdb_optional.h".
9699         (print_command_parse_format): Rework to fill in a
9700         value_print_options instead of a format_data.
9701         (print_value): Change parameter type from format_data pointer to
9702         value_print_options reference.  Adjust.
9703         (print_command_1): Process options.  Adjust to pass down a
9704         value_print_options.
9705         (print_command_completer): New.
9706         (_initialize_printcmd): Install print_command_completer as
9707         handle_brkchars completer for the "print" command.  Update
9708         "print"'s help to include supported options.
9709         * valprint.c: Include "cli/cli-option.h".
9710         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9711         here from cp-valprint.c.
9712         (boolean_option_def, uinteger_option_def)
9713         (value_print_option_defs, make_value_print_options_def_group):
9714         New.  Use gdb::option::add_setshow_cmds_for_options to install
9715         "set print elements", "set print null-stop", "set print repeats",
9716         "set print pretty", "set print union", "set print array", "set
9717         print address", "set print symbol", "set print array-indexes".
9718         * valprint.h: Include <string> and "cli/cli-option.h".
9719         (make_value_print_options_def_group): Declare.
9720         (print_value): Change parameter type from format_data pointer to
9721         value_print_options reference.
9722         (print_command_completer): Declare.
9723
9724 2019-06-13  Pedro Alves  <palves@redhat.com>
9725
9726         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9727         (COMMON_SFILES): Add maint-test-settings.c.
9728         * cli/cli-decode.c (boolean_enums): New global, factored out from
9729         ...
9730         (add_setshow_boolean_cmd): ... here.
9731         * cli/cli-decode.h (boolean_enums): Declare.
9732         * cli/cli-option.c: New file.
9733         * cli/cli-option.h: New file.
9734         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9735         factored out from ...
9736         (parse_cli_boolean_value(const char *)): ... this.
9737         (is_unlimited_literal): Change parameter type to pointer to
9738         pointer.  Adjust and advance ARG pointer.
9739         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9740         (parse_cli_var_enum): New, factored out from ...
9741         (do_set_command): ... this.  Adjust.
9742         * cli/cli-setshow.h (parse_cli_boolean_value)
9743         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9744         (parse_cli_var_enum): Declare.
9745         * cli/cli-utils.c: Include "cli/cli-option.h".
9746         (get_ulongest): New.
9747         * cli/cli-utils.h (get_ulongest): Declare.
9748         (check_for_argument): New overloads.
9749         * maint-test-options.c: New file.
9750
9751 2019-06-13  Pedro Alves  <palves@redhat.com>
9752
9753         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9754         parse a range if "-" is at the end of the string.
9755
9756 2019-06-13  Pedro Alves  <palves@redhat.com>
9757
9758         * cli/cli-setshow.c (parse_auto_binary_operation)
9759         (parse_cli_boolean_value): Don't allow "o".
9760
9761 2019-06-13  Pedro Alves  <palves@redhat.com>
9762
9763         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9764         * NEWS: Mention maint test-settings KIND.
9765         * maint-test-settings.c: New file.
9766
9767 2019-06-13  Pedro Alves  <palves@redhat.com>
9768
9769         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9770         completer.
9771         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9772         "set" completers.
9773
9774 2019-06-13  Pedro Alves  <palves@redhat.com>
9775
9776         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9777         after item.
9778
9779 2019-06-13  Pedro Alves  <palves@redhat.com>
9780
9781         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9782
9783 2019-06-13  Pedro Alves <palves@redhat.com>
9784
9785         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9786         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9787         call.
9788         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9789         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9790         calls.
9791         (check_for_argument): Skip spaces after argument.
9792
9793 2019-06-13  Pedro Alves  <palves@redhat.com>
9794
9795         * thread.c (thread_apply_command): Adjust TID parsing.
9796         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9797         detected before end of string.
9798         (tid_is_in_list): Error out if LIST is invalid.
9799
9800 2019-06-13  Pedro Alves  <palves@redhat.com>
9801
9802         * completer.c (complete_line_internal_1): Rewind completion word
9803         point.
9804         (completion_tracker::advance_custom_word_point_by): Change
9805         parameter type to int.
9806         * completer.h (completion_tracker::advance_custom_word_point_by):
9807         Likewise.
9808
9809 2019-06-13  Pedro Alves  <palves@redhat.com>
9810
9811         * completer.c (advance_to_completion_word): Handle delimiters.
9812
9813 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9814
9815         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9816
9817 2019-06-11  Tom Tromey  <tom@tromey.com>
9818
9819         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9820         (xmalloc_failed): Move to alloc.c.
9821         * alloc.c: New file.
9822         * Makefile.in (COMMON_SFILES): Add alloc.c.
9823
9824 2019-06-11  Tom Tromey  <tom@tromey.com>
9825
9826         * nat/linux-waitpid.c: Don't include server.h.
9827         (linux_debug): Remove.
9828         (my_waitpid): Update.
9829
9830 2019-06-11  Tom Tromey  <tromey@adacore.com>
9831
9832         * infcall.c (_initialize_infcall): Remove trailing newline from
9833         help.
9834         * user-regs.c (_initialize_user_regs): Remove trailing newline
9835         from help.
9836         * typeprint.c (_initialize_typeprint): Remove trailing newline
9837         from help.
9838         * reverse.c (_initialize_reverse): Remove trailing newlines from
9839         help.
9840         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9841         from help.
9842         * language.c (add_set_language_command): Remove trailing newline
9843         from help.
9844         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9845         help.
9846         * disasm.c (_initialize_disasm): Remove trailing newline from
9847         help.
9848         * top.c (init_main): Remove trailing newline from help.
9849         * interps.c (_initialize_interpreter): Remove trailing newline
9850         from help.
9851         * btrace.c (_initialize_btrace): Remove trailing newlines from
9852         help.
9853         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9854         from help.
9855         * python/python.c (_initialize_python): Remove trailing newline
9856         from help.
9857         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9858         help.
9859         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9860         from help.  Reformat some text.
9861         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9862         from help.
9863         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9864         newline from help.
9865
9866 2019-06-11  Tom Tromey  <tromey@adacore.com>
9867
9868         * darwin-nat.c (darwin_decode_exception_message)
9869         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9870
9871 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9872
9873         * valops.c (value_slice): Check for not allocated or not
9874         associated values.
9875
9876 2019-06-10  Tom de Vries  <tdevries@suse.de>
9877
9878         PR gdb/24618
9879         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9880         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9881         invalid.
9882
9883 2019-06-10  Tom de Vries  <tdevries@suse.de>
9884
9885         PR gdb/24611
9886         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9887         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9888
9889 2019-06-10  Tom de Vries  <tdevries@suse.de>
9890
9891         PR symtab/24545
9892         * symtab.c (struct demangled_name_entry): Add language field.
9893         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9894         static minimal symbol".  Set and use language field.
9895
9896 2019-06-10  Tom Tromey  <tromey@adacore.com>
9897
9898         * ada-lang.c (_initialize_ada_language): Update help text.
9899
9900 2019-06-10  Tom Tromey  <tromey@adacore.com>
9901
9902         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9903         with a newline.
9904         * guile/guile.c (handle_boot_error): Don't end warning with a
9905         newline.
9906         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9907         warning with a newline.
9908         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9909         newline.
9910         (s12z_frame_cache): Likewise.
9911         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9912         a newline.
9913         * solib-svr4.c (disable_probes_interface): Don't end warning with
9914         a newline.
9915         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9916         newline.
9917         * python/python.c (do_finish_initialization): Don't end warning
9918         with a newline.
9919
9920 2019-06-10  Tom Tromey  <tom@tromey.com>
9921
9922         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9923         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9924         gdbpy_enter.
9925
9926 2019-06-10  Tom Tromey  <tromey@adacore.com>
9927
9928         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9929         data.
9930         (elf_new_init): Don't call stabsread_new_init.
9931         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9932         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9933         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9934
9935 2019-06-10  Tom de Vries  <tdevries@suse.de>
9936
9937         PR symtab/16264
9938         PR symtab/24517
9939         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9940
9941 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9942
9943         * source.c (find_and_open_source): Also rewrite relative file
9944         names.
9945
9946 2019-04-26  Amos Bird  <amosbird@gmail.com>
9947
9948         * annotate.c (annotate_thread_exited): Add "thread-exited"
9949         annotation.
9950
9951 2019-06-06  Tom Tromey  <tromey@adacore.com>
9952
9953         * maint.h (class scoped_command_stats): Use
9954         DISABLE_COPY_AND_ASSIGN.
9955         <print_time>: New method.
9956         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9957         print_time.
9958         (scoped_command_stats::print_time): New method.
9959
9960 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9961
9962         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9963         instructions of lengths 6 or 8 bytes.
9964
9965 2019-06-04  Pedro Alves  <palves@redhat.com>
9966
9967         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9968
9969         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9970         * breakpoint.c (condition_completer): Likewise.
9971         * cli/cli-dump.c (scan_expression): Likewise.
9972         * common/filestuff.c (mkdir_recursive): Likewise.
9973         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9974         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9975         (gdb_abspath): Likewise.
9976         * compile/compile-cplus-types.c
9977         (compile_cplus_instance::decl_name): Likewise.
9978         * completer.c (complete_explicit_location):
9979         (signal_completer, reg_or_group_completer_1): Likewise.
9980         * cp-support.c (cp_remove_params_if_any): Likewise.
9981         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9982         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9983         * infcmd.c (strip_bg_char): Likewise.
9984         * linespec.c (copy_token_string): Likewise.
9985         * mi/mi-main.c (output_cores): Likewise.
9986         * psymtab.c (psymtab_search_name):
9987         * symfile.c (test_set_ext_lang_command): Likewise.
9988         * target.c (target_fileio_read_stralloc): Likewise.
9989         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9990         * value.c (complete_internalvar): Likewise.
9991
9992 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9993
9994         Add objfile property to gdb.Type.
9995         * NEWS: Mention Python API addition.
9996         * python/py-type.c (typy_get_objfile): New method.
9997
9998 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9999
10000         * NEWS: Mention the new set|show style [title|highlight].
10001         Mention changes to "show style", "help" and "apropos".
10002
10003 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10004
10005         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
10006         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
10007         instead of print_help_for_command.
10008         (print_doc_of_command): New function.
10009         (help_list): Add 'apropos -v word' suggestion.
10010         (print_help_for_command): Style the command name using title style.
10011         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
10012         (_initialize_cli_cmds): Describe -v in apropos_command help.
10013
10014 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10015
10016         * cli/cli-style.h (cli_style_option): Add name in constructor,
10017         add m_name class member, add constructor with intensity,
10018         add name class function.
10019         (cli_style_option::add_setshow_commands): Remove name argument.
10020         (highlight_style, title_style): New styles.
10021         * cli/cli-style.c (do_show): New function that shows a style
10022         characteristic styling the style name with itself.
10023         (set_style_name): New function.
10024         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
10025         Update all callers according to the changes in cli/cli-style.h.
10026         * utils.h (fputs_highlighted): New function.
10027         * utils.c (fputs_highlighted): Likewise.
10028
10029 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10030
10031         * NEWS: Mention new pipe command and new convenience variables.
10032
10033 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10034
10035         * cli/cli-cmds.c (pipe_command): New function.
10036         (_initialize_cli_cmds): Call add_com for pipe_command.
10037         Define | as an alias for pipe.
10038         (exit_status_set_internal_vars): New function.
10039         (shell_escape): Call exit_status_set_internal_vars.
10040         cli/cli-decode.c (find_command_name_length): Recognize | as
10041         a single character command.
10042
10043 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10044
10045         * gdbcmd.h (execute_command_to_ui_file): New declaration.
10046         top.c (execute_command_to_ui_file): New function, mostly a copy
10047         of execute_command_to_string.
10048         (execute_command_to_string): Implement by calling
10049         execute_command_to_ui_file.
10050
10051 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10052
10053         * top.h (saved_command_line): Remove declaration.
10054         * top.c (previous_saved_command_line, previous_repeat_arguments):
10055         New variables.
10056         (saved_command_line): Make static, define together with other
10057         'repeat variables'.
10058         (dont_repeat): Clear repeat_arguments.
10059         (repeat_previous, get_saved_command_line, save_command_line):
10060         New functions.
10061         (gdb_init): Initialize saved_command_line
10062         and previous_saved_command_line.
10063         * main.c (captured_main_1): Remove saved_command_line initialization.
10064         * event-top.c (handle_line_of_input): Update to use
10065         the new 'repeat' related functions instead of direct access to
10066         saved_command_line.
10067         * command.h (repeat_previous, get_saved_command_line,
10068         save_command_line): New declarations.
10069         (dont_repeat): Add comment.
10070
10071 2019-05-30  Tom Tromey  <tromey@adacore.com>
10072
10073         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
10074         Fix comment.
10075         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
10076
10077 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
10078
10079         PR cli/24587
10080         * completer.c (complete): Initialize variable word.
10081
10082 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
10083
10084         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10085         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10086         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10087         'body' is NULL to the outter 'if', protecting the '!is_define'
10088         situation as well.
10089
10090 2019-05-29  Tom Tromey  <tromey@adacore.com>
10091
10092         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10093         (dwarf_unknown): New function.
10094         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10095         (dwarf_type_encoding_name): Use dwarf_unknown.
10096
10097 2019-05-29  Tom Tromey  <tromey@adacore.com>
10098
10099         PR c++/20020:
10100         * cp-valprint.c (cp_print_value_fields): Call
10101         cp_print_static_field inside "try".
10102
10103 2019-05-29  Tom Tromey  <tromey@adacore.com>
10104
10105         * inflow.c (struct terminal_info): Add default operator=.
10106         * configure: Rebuild.
10107         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10108         -Wdeprecated-copy-dtor, -Wredundant-move.
10109
10110 2019-05-29  Tom Tromey  <tromey@adacore.com>
10111
10112         * NEWS: Add entry.
10113         * infcmd.c (print_return_value_1): Handle finish_print
10114         option.
10115         (show_print_finish): New function.
10116         (_initialize_infcmd): Add "set/show print finish" commands.
10117         * valprint.c (user_print_options): Initialize new member.
10118         * valprint.h (struct value_print_options) <finish_print>: New
10119         member.
10120
10121 2019-05-28  Tom Tromey  <tromey@adacore.com>
10122
10123         * ada-lang.c (ada_remove_Xbn_suffix)
10124         (find_old_style_renaming_symbol)
10125         (parse_old_style_renaming): Remove.
10126         (ada_find_renaming_symbol): Don't call
10127         find_old_style_renaming_symbol.
10128         (ada_is_renaming_symbol): Rename from
10129         ada_find_renaming_symbol.  Remove "block" parameter.  Return
10130         bool.  Now static.
10131         (ada_read_var_value): Update and simplify.
10132         * ada-exp.y (write_var_or_type): Remove old code.
10133
10134 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
10135
10136         PR gdb/25010
10137         * event-top.c: Remove include comment.
10138         * inflow.c (class scoped_ignore_sigttou): Move from here...
10139         * inflow.h (class scoped_ignore_sigttou): ...to here.
10140         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10141         * top.c:  Remove include comment.
10142
10143 2019-05-27  Tom Tromey  <tom@tromey.com>
10144
10145         * NEWS: Fix typo.
10146
10147 2019-05-22  Tom Tromey  <tromey@adacore.com>
10148
10149         * target.c (target_follow_exec): Constify parameter.
10150         * target-delegates.c: Rebuild.
10151         * remote.c (remote_target::follow_exec): Constify parameter.
10152         * infrun.c (follow_exec): Constify parameter.
10153         * target.h (struct target_ops) <follow_exec>: Constify parameter.
10154         (target_follow_exec): Likewise.
10155
10156 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10157
10158         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10159         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10160
10161 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10162
10163         * NEWS: Add debugredirect and testsuite sections.
10164
10165 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
10166
10167         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10168         target descriptions using exclusively floating point register name
10169         aliases.
10170
10171 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10172
10173         PR gdb/18644:
10174         * f-lang.c (build_fortran_types): Handle the case where
10175         gdbarch_floatformat_for_type returns a nullptr.
10176
10177 2019-05-21  Tom de Vries  <tdevries@suse.de>
10178
10179         PR cli/24587
10180         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10181
10182 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10183
10184         PR gdb/18644:
10185         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10186         16-byte floats.
10187         * i386-tdep.c (i386_floatformat_for_type): Use
10188         floatformats_ia64_quad for the 16-byte floating point component
10189         within a fortran 32-byte complex number.
10190
10191 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10192
10193         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10194         delete default constructor.
10195         (find_partial_die): Update to return const struct.
10196         (partial_die_parent_scope): Move variable declaration into scope
10197         of its use and change its type to auto.
10198         (guess_partial_die_structure_name): Likewise.
10199         (partial_die_info::fixup): Likewise.
10200
10201 2019-05-17  Tom Tromey  <tromey@adacore.com>
10202
10203         * source.c (find_and_open_source): Remove cast.
10204
10205 2019-05-17  Tom Tromey  <tromey@adacore.com>
10206
10207         * annotate.c (annotate_source): Make "filename" const.
10208         * annotate.h (annotate_source): Use const.
10209
10210 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10211
10212         * disasm.c (set_disassembler_options): Send errors to stderr.
10213
10214 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10215
10216         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10217         (cli_interp_base::set_logging): Check debug_redirect.
10218         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10219         * cli/cli-logging.c (debug_redirect): Add static variable.
10220         (pop_output_files): Add default param.
10221         (handle_redirections): Print debug setting.
10222         (show_logging_command): Likewise.
10223         (_initialize_cli_logging): Add debugredirect command.
10224         * interps.c (current_interp_set_logging): Add debug_redirect
10225         parameter.
10226         * interps.h (set_logging): Add debug_redirect parameter.
10227         (current_interp_set_logging): Likewise.
10228         * mi/mi-common.h: Likewise.
10229         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10230
10231 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10232             Tom Tromey  <tromey@adacore.com>
10233
10234         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10235         directly.
10236         * cli/cli-interp.h (make_logging_output): Remove declaration.
10237         * cli/cli-logging.c (make_logging_output): Remove function.
10238         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10239         directly.
10240         * ui-file.c (tee_file::tee_file): Remove bools.
10241         (tee_file::~tee_file): Remove deletes.
10242         * ui-file.h (tee_file): Remove bools.
10243
10244 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10245
10246         * mi/mi-cmds.h (mi_cmd_complete): New function.
10247         * mi/mi-main.c (mi_cmd_complete): Likewise.
10248         * mi/mi-cmds.c: Define new MI command -complete.
10249         * NEWS: Mention new -complete command.
10250
10251 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10252
10253         * completer.h (complete): New function.
10254         * completer.c (complete): Likewise.
10255         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10256         function defined in completer.h.
10257
10258 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10259
10260         * MAINTAINERS (Write After Approval): Add myself.
10261
10262 2019-05-17  Tom de Vries  <tdevries@suse.de>
10263
10264         PR gdb/24094
10265         * dwarf2read.c (struct cu_partial_die_info): New struct.
10266         (find_partial_die): Return cu_partial_die_info.
10267         (partial_die_parent_scope, guess_partial_die_structure_name)
10268         (partial_die_info::fixup): Handle new return type of find_partial_die.
10269
10270 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10271
10272         PR breakpoints/24541
10273         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10274         "std::string", simplifying the algorithm.
10275
10276 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10277
10278         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10279         (stap_static_probe_ops::get_probes): Likewise.
10280
10281 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10282
10283         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10284         '-')" and "else if".
10285         (stap_parse_single_operand): Join checks for
10286         "gdbarch_stap_parse_special_token_p" and
10287         "gdbarch_stap_parse_special_token" in the same "if" statement.
10288         Invert check when verifying for operation on register
10289         displacement.
10290
10291 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10292
10293         * stap-probe.c (stap_get_opcode): Update comment.
10294         (stap_get_expected_argument_type): Likewise.
10295         (handle_stap_probe): Likewise.
10296
10297 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10298
10299         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10300         return type to 'bool'.  Adjust comment.  Use 'bool' when
10301         appropriate.
10302         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10303         * stap-probe.c (stap_parse_argument_1): Likewise.
10304         (stap_is_operator): Likewise.
10305         (stap_is_generic_prefix): Likewise.
10306         (stap_is_register_prefix): Likewise.
10307         (stap_is_register_indirection_prefix): Likewise.
10308         (stap_is_integer_prefix): Likewise.
10309         (stap_generic_check_suffix): Likewise.
10310         (stap_check_integer_suffix): Likewise.
10311         (stap_check_register_suffix): Likewise.
10312         (stap_check_register_indirection_suffix): Likewise.
10313         (stap_parse_register_operand): Likewise.
10314         (stap_parse_single_operand): Likewise.
10315         (stap_parse_argument_1): Likewise.
10316         (stap_probe::get_argument_count): Likewise.
10317         (stap_is_operator): Likewise.
10318
10319 2019-05-16  Tom Tromey  <tromey@adacore.com>
10320
10321         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10322         keyword to foreach.
10323
10324 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10325
10326         * linux-thread-db.c (try_thread_db_load_1): Change return type
10327         to bool.
10328         (try_thread_db_load): Likewise.
10329         (try_thread_db_load_from_pdir_1): Likewise.
10330         (try_thread_db_load_from_pdir): Likewise.
10331         (try_thread_db_load_from_sdir): Likewise.
10332         (try_thread_db_load_from_dir): Likewise.
10333         (thread_db_load_search): Likewise.
10334         (has_libpthread): Likewise.
10335         (thread_db_load): Likewise.
10336
10337 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10338
10339         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10340         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10341         NULL, and complain/return if that's the case.
10342
10343 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10344
10345         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10346         (advance, posn, abstract_read_memory): New functions.
10347         [struct mem_read_abstraction]: New struct.
10348         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10349
10350 2019-05-14  Tom Tromey  <tromey@adacore.com>
10351
10352         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10353         value is not lval_memory.
10354
10355 2019-05-14  Tom Tromey  <tromey@adacore.com>
10356
10357         * solib.c (info_sharedlibrary_command): Style the file name.
10358
10359 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10360
10361         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10362         (aarch64_vnv_type): Likewise.
10363         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10364         * common/tdesc.c: Likewise.
10365         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10366         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10367         * features/aarch64-fpu.xml: Add ieee half view.
10368         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10369         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10370         * gdbtypes.h (struct builtin_type): Likewise.
10371         (struct objfile_type): Likewise.
10372
10373 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10374
10375         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10376         typo.
10377         * location.h (string_to_event_location): Likewise.
10378
10379 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10380
10381         GDB 8.3 released.
10382
10383 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10384
10385         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10386         New variable declaration.
10387         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10388         New variable.
10389         (print_one_breakpoint): Use ui_out::test_flags and new global
10390         variable to compute use_fixed_output.
10391         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10392         Remove.
10393         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10394         (mi_multi_location_breakpoint_output_fixed): Remove.
10395         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10396         new variable.
10397         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10398         fix_multi_location_breakpoint_output flag if version >= 3.
10399         * ui-out.h (enum ui_out_flag)
10400         <fix_multi_location_breakpoint_output>: New enumerator.
10401
10402 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10403
10404         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10405
10406 2019-05-10  Tom Tromey  <tromey@adacore.com>
10407
10408         * ada-lang.c (catch_ada_completer): New function.
10409         (_initialize_ada_language): Use it.
10410
10411 2019-05-10  Tom Tromey  <tromey@adacore.com>
10412
10413         * thread.c (print_thread_info): Make "requested_threads" const.
10414         * gdbthread.h (print_thread_info): Make "requested_threads"
10415         const.
10416         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10417         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10418
10419 2019-05-08  Tom Tromey  <tom@tromey.com>
10420
10421         * gdbtypes.c (objfile_type_data): Change type.
10422         (objfile_type, _initialize_gdbtypes): Update.
10423
10424 2019-05-08  Tom Tromey  <tom@tromey.com>
10425
10426         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10427         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10428         (_initialize_dwarf2_frame): Update.
10429
10430 2019-05-08  Tom Tromey  <tom@tromey.com>
10431
10432         * objc-lang.c (objc_objfile_data): Change type.
10433         (find_methods): Update.
10434         (_initialize_objc_lang): Remove.
10435
10436 2019-05-08  Tom Tromey  <tom@tromey.com>
10437
10438         * stabsread.c (rs6000_builtin_type_data): Change type.
10439         (rs6000_builtin_type, _initialize_stabsread): Update.
10440
10441 2019-05-08  Tom Tromey  <tom@tromey.com>
10442
10443         * mips-tdep.c (mips_pdr_data): Remove.
10444         (_initialize_mips_tdep): Update.
10445
10446 2019-05-08  Tom Tromey  <tom@tromey.com>
10447
10448         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10449         (hppa_init_objfile_priv_data, read_unwind_info)
10450         (find_unwind_entry, _initialize_hppa_tdep): Update.
10451
10452 2019-05-08  Tom Tromey  <tom@tromey.com>
10453
10454         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10455         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10456         on obstack.
10457         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10458
10459 2019-05-08  Tom Tromey  <tom@tromey.com>
10460
10461         * mdebugread.c (basic_type_data): Change type.
10462         (basic_type, _initialize_mdebugread): Update.
10463
10464 2019-05-08  Tom Tromey  <tom@tromey.com>
10465
10466         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10467
10468 2019-05-08  Tom Tromey  <tom@tromey.com>
10469
10470         * nto-tdep.c (nto_inferior_data_reg): Change type.
10471         (nto_inferior_data): Update.
10472         (nto_inferior_data_cleanup, nto_new_inferior_data)
10473         (_initialize_nto_tdep): Remove.
10474         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10475
10476 2019-05-08  Tom Tromey  <tom@tromey.com>
10477
10478         * ada-lang.c (struct ada_inferior_data): Add initializers.
10479         (ada_inferior_data): Change type.
10480         (ada_inferior_data_cleanup): Remove.
10481         (get_ada_inferior_data, ada_inferior_exit)
10482         (struct ada_pspace_data): Add initializers, destructor.
10483         (ada_pspace_data_handle): Change type.
10484         (get_ada_pspace_data): Update.
10485         (ada_pspace_data_cleanup): Remove.
10486
10487 2019-05-08  Tom Tromey  <tom@tromey.com>
10488
10489         * coffread.c (struct coff_symfile_info): Add initializers.
10490         (coff_objfile_data_key): Move lower.  Change type.
10491         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10492         Update.
10493         (coff_free_info): Remove.
10494
10495 2019-05-08  Tom Tromey  <tom@tromey.com>
10496
10497         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10498         (fbsd_pspace_data_handle): Move lower.  Change type.
10499         (get_fbsd_pspace_data): Update.
10500         (fbsd_pspace_data_cleanup): Remove.
10501         (_initialize_fbsd_tdep): Update.
10502
10503 2019-05-08  Tom Tromey  <tom@tromey.com>
10504
10505         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10506         (get_ada_tasks_pspace_data): Update.
10507         (ada_tasks_pspace_data_cleanup): Remove.
10508         (_initialize_tasks): Update.
10509         (ada_tasks_inferior_data_handle): Change type.
10510         (get_ada_tasks_inferior_data): Update.
10511         (ada_tasks_inferior_data_cleanup): Remove.
10512         (struct ada_tasks_pspace_data): Add initializers.
10513
10514 2019-05-08  Tom Tromey  <tom@tromey.com>
10515
10516         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10517         * symfile-debug.c (debug_sym_get_probes): Change type.
10518         * stap-probe.c (handle_stap_probe):
10519         (stap_static_probe_ops::get_probes): Change type.
10520         * probe.h (class static_probe_ops) <get_probes>: Change type.
10521         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10522         (parse_probes_in_pspace): Update.
10523         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10524         Update.
10525         (any_static_probe_ops::get_probes): Change type.
10526         * elfread.c (elfread_data): New typedef.
10527         (probe_key): Change type.
10528         (elf_get_probes): Likewise.  Update.
10529         (probe_key_free): Remove.
10530         (_initialize_elfread): Update.
10531         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10532         Change type.
10533         (dtrace_process_dof_probe, dtrace_process_dof)
10534         (dtrace_static_probe_ops::get_probe): Change type.
10535
10536 2019-05-08  Tom Tromey  <tom@tromey.com>
10537
10538         * xcoffread.c (struct xcoff_symfile_info): Rename from
10539         coff_symfile_info.  Add initializers.
10540         (xcoff_objfile_data_key): Move lower.  Change type.
10541         (XCOFF_DATA): Rewrite.
10542         (xcoff_free_info): Remove.
10543         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10544         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10545         (xcoff_initial_scan): Update.
10546
10547 2019-05-08  Tom Tromey  <tom@tromey.com>
10548
10549         * solib-svr4.c (struct svr4_info): Add initializers and
10550         destructor.
10551         <probes_table>: Now an htab_up.
10552         (solib_svr4_pspace_data): Change type.
10553         (free_probes_table): Simplify.
10554         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10555         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10556         (probes_table_remove_objfile_probes, register_solib_event_probe)
10557         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10558         (_initialize_svr4_solib): Update.
10559
10560 2019-05-08  Tom Tromey  <tom@tromey.com>
10561
10562         * remote.c (remote_pspace_data): Change type.
10563         (remote_pspace_data_cleanup): Remove.
10564         (get_remote_exec_file, set_pspace_remote_exec_file)
10565         (_initialize_remote): Update.
10566
10567 2019-05-08  Tom Tromey  <tom@tromey.com>
10568
10569         * breakpoint.c (breakpoint_objfile_key): Change type.
10570         (get_breakpoint_objfile_data): Update.
10571         (free_breakpoint_objfile_data): Remove.
10572         (_initialize_breakpoint): Update.
10573
10574 2019-05-08  Tom Tromey  <tom@tromey.com>
10575
10576         * linux-tdep.c (struct linux_info): Add initializers.
10577         (linux_inferior_data): Move.  Change type.
10578         (invalidate_linux_cache_inf): Update.
10579         (linux_inferior_data_cleanup): Remove.
10580         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10581
10582 2019-05-08  Tom Tromey  <tom@tromey.com>
10583
10584         * auxv.c (auxv_inferior_data): Move.  Change type.
10585         (auxv_inferior_data_cleanup): Remove.
10586         (invalidate_auxv_cache_inf): Rewrite.
10587         (get_auxv_inferior_data, _initialize_auxv): Update.
10588
10589 2019-05-08  Tom Tromey  <tom@tromey.com>
10590
10591         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10592         (symfile_debug_objfile_data_key): Change type.
10593         (symfile_debug_installed, debug_qf_has_symbols)
10594         (debug_qf_find_last_source_symtab)
10595         (debug_qf_forget_cached_source_info)
10596         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10597         (debug_qf_print_stats, debug_qf_dump)
10598         (debug_qf_expand_symtabs_for_function)
10599         (debug_qf_expand_all_symtabs)
10600         (debug_qf_expand_symtabs_with_fullname)
10601         (debug_qf_map_matching_symbols)
10602         (debug_qf_expand_symtabs_matching)
10603         (debug_qf_find_pc_sect_compunit_symtab)
10604         (debug_qf_map_symbol_filenames)
10605         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10606         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10607         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10608         (debug_sym_read_linetable, debug_sym_relocate): Update.
10609         (symfile_debug_free_objfile): Remove.
10610         (install_symfile_debug_logging, _initialize_symfile_debug):
10611         Update.
10612
10613 2019-05-08  Tom Tromey  <tom@tromey.com>
10614
10615         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10616         allocate_on_obstack.
10617         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10618         (get_dwarf2_per_objfile): Update.
10619         (set_dwarf2_per_objfile): Remove.
10620         (dwarf2_has_info, dwarf2_get_section_info): Update.
10621         (dwarf2_free_objfile): Remove.
10622         (_initialize_dwarf2_read): Update.
10623
10624 2019-05-08  Tom Tromey  <tom@tromey.com>
10625
10626         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10627         initializers.
10628         <unsupported_script_warning_printed,
10629         script_not_found_warning_printed>: Now bool.
10630         (auto_load_pspace_data): Change type.
10631         (~auto_load_pspace_info): Rename from
10632         auto_load_pspace_data_cleanup.
10633         (get_auto_load_pspace_data, init_loaded_scripts_info)
10634         (clear_section_scripts, maybe_print_unsupported_script_warning)
10635         (maybe_print_script_not_found_warning, _initialize_auto_load):
10636         Update.
10637
10638 2019-05-08  Tom Tromey  <tom@tromey.com>
10639
10640         * objfiles.c (objfile_pspace_info): Add destructor and
10641         initializers.
10642         (objfiles_pspace_data): Change type.
10643         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10644         (get_objfile_pspace_data): Update.
10645         (objfiles_bfd_data): Change type.
10646         (get_objfile_bfd_data): Update.
10647         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10648
10649 2019-05-08  Tom Tromey  <tom@tromey.com>
10650
10651         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10652         Change type.
10653         (get_catch_syscall_inferior_data): Update.
10654         (catch_syscall_inferior_data_cleanup): Remove.
10655         (_initialize_break_catch_syscall): Update.
10656
10657 2019-05-08  Tom Tromey  <tom@tromey.com>
10658
10659         * inflow.c (struct terminal_info): Add destructor and
10660         initializers.
10661         (inflow_inferior_data): Change type.
10662         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10663         (get_inflow_inferior_data, inflow_inferior_exit)
10664         (swap_terminal_info, _initialize_inflow): Update.
10665
10666 2019-05-08  Tom Tromey  <tom@tromey.com>
10667
10668         * target-dcache.c (target_dcache_cleanup): Remove.
10669         (target_dcache_aspace_key): Change type.
10670         (target_dcache_init_p, target_dcache_invalidate)
10671         (target_dcache_get, target_dcache_get_or_init)
10672         (_initialize_target_dcache): Update.
10673         * dcache.h (struct dcache_deleter): New.
10674
10675 2019-05-08  Tom Tromey  <tom@tromey.com>
10676
10677         * symtab.c (struct symbol_cache): Add destructor and
10678         initializers.
10679         (symbol_cache_key): Move.  Change type.
10680         (make_symbol_cache, free_symbol_cache): Remove.
10681         (get_symbol_cache): Update.
10682         (symbol_cache_cleanup): Remove.
10683         (ALL_PSPACES, symbol_cache_flush)
10684         (maintenance_print_symbol_cache)
10685         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10686         Update.
10687
10688 2019-05-08  Tom Tromey  <tom@tromey.com>
10689
10690         * symtab.c (struct main_info): Add destructor and initializers.
10691         (main_progspace_key): Move.  Change type.
10692         (get_main_info): Update.
10693         (main_info_cleanup): Remove.
10694         (_initialize_symtab): Update.
10695
10696 2019-05-08  Tom Tromey  <tom@tromey.com>
10697
10698         * registry.h (DECLARE_REGISTRY): Define the _key class.
10699
10700 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10701
10702         * NEWS: Merge two 'New commands' sections.
10703
10704 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10705
10706         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10707         parameter and use Ada language definition instead.
10708         (ada_val_print_ptr): Remove unused language parameter.
10709         (ada_val_print_num): Remove language parameter and use Ada language
10710         definition instead.
10711         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10712         parameter.
10713         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10714         parameter and use Ada language definition instead.
10715         (ada_val_print_1): Update all ada_val_print_xxx calls.
10716         Remove language parameter.
10717         (ada_val_print): Update ada_val_print_1 call.
10718
10719 2019-05-08  Tom Tromey  <tromey@adacore.com>
10720
10721         * remote.c (remote_hw_watchpoint_limit)
10722         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10723         Now static.
10724
10725 2019-05-08  Tom Tromey  <tromey@adacore.com>
10726
10727         * maint.c (_initialize_maint_cmds): Move initialization code to
10728         remote.c.
10729         (watchdog, show_watchdog): Move to remote.c.
10730         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10731         "watchdog" static.
10732         (_initialize_remote): Move initialization code from maint.c.
10733         * defs.h (watchdog): Don't declare.
10734
10735 2019-05-08  Tom Tromey  <tromey@adacore.com>
10736
10737         * tui/tui-interp.c: Include main.h.
10738         * interps.c: Include main.h.
10739         * main.h (interpreter_p): Declare.
10740         * defs.h (interpreter_p): Don't declare.
10741
10742 2019-05-08  Tom Tromey  <tromey@adacore.com>
10743
10744         * dwarf2loc.c: Include dwarf2read.h.
10745         * defs.h (read_unsigned_leb128): Don't declare.
10746         * dwarf2read.h (read_unsigned_leb128): Declare.
10747
10748 2019-05-08  Tom Tromey  <tromey@adacore.com>
10749
10750         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10751         method.
10752
10753 2019-05-08  Tom Tromey  <tromey@adacore.com>
10754
10755         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10756         when no wrap column is set.
10757
10758 2019-05-08  Tom Tromey  <tromey@adacore.com>
10759
10760         * c-lang.c (c_get_string): Handle non-C-style arrays.
10761
10762 2019-05-08  Tom Tromey  <tromey@adacore.com>
10763
10764         * typeprint.c (print_offset_data::update): Print the bit offset,
10765         not the number of bits remaining.
10766
10767 2019-05-08  Tom Tromey  <tromey@adacore.com>
10768
10769         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10770         padding at end of comment.
10771
10772 2019-05-08  Tom Tromey  <tromey@adacore.com>
10773
10774         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10775         Compare main types.
10776
10777 2019-05-06  Tom Tromey  <tom@tromey.com>
10778
10779         * common/scoped_mmap.c: Include common-defs.h.
10780         * common/scoped_mmap.h: Don't include config.h.
10781
10782 2019-05-04  Tom Tromey  <tom@tromey.com>
10783
10784         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10785         (struct aarch64_call_info): Add initializers.
10786         <si>: Now a std::vector.
10787         (pass_on_stack, aarch64_push_dummy_call): Update.
10788
10789 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10790             Tom Tromey  <tom@tromey.com>
10791
10792         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10793         (ppc_threads): Now a std::vector.  Now static.
10794         (hwdebug_find_thread_points_by_tid)
10795         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10796         Update.
10797
10798 2019-05-04  Tom Tromey  <tom@tromey.com>
10799
10800         * arc-tdep.c (arc_tdesc_init): Return bool.
10801
10802 2019-05-04  Tom Tromey  <tom@tromey.com>
10803
10804         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10805         Use gdb_assert_not_reached.
10806
10807 2019-05-04  Tom Tromey  <tom@tromey.com>
10808
10809         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10810         "false".
10811
10812 2019-05-04  Tom Tromey  <tom@tromey.com>
10813
10814         * arc-tdep.c (arc_tdesc_init): Use bool.
10815
10816 2019-05-04  Tom Tromey  <tom@tromey.com>
10817
10818         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10819
10820 2019-05-04  Tom Tromey  <tom@tromey.com>
10821
10822         * cli/cli-cmds.c (valid_command_p): Return bool.
10823
10824 2019-05-04  Tom Tromey  <tom@tromey.com>
10825
10826         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10827         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10828
10829 2019-05-04  Raul Tambre  <raul@tambre.ee>
10830
10831         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10832         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10833         operator for comparison.
10834
10835 2019-05-04  Tom Tromey  <tom@tromey.com>
10836
10837         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10838         (lookup_partial_symbol, print_partial_symbols)
10839         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10840         (psymbol_compare): Update.
10841         (add_psymbol_to_bcache): Clear the entire psymbol.
10842         (maintenance_check_psymtabs): Update.
10843         * psympriv.h (struct partial_symbol): Don't derive from
10844         general_symbol_info.
10845         <obj_section, unrelocated_address, address,
10846         set_unrelocated_address>: Update.
10847         <ginfo>: New member.
10848         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10849         (debug_names::write_psymbols): Update.
10850
10851 2019-05-04  Tom de Vries  <tdevries@suse.de>
10852
10853         * contrib/cc-with-tweaks.sh: Support -n arg.
10854
10855 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10856
10857         * corelow.c (core_target::detach): Ensure frame cache and
10858         register caches are cleared.
10859         inferior.c (exit_inferior_1): Likewise.
10860
10861 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10862             Tom Tromey  <tom@tromey.com>
10863
10864         * dictionary.c (collate_pending_symbols_by_language): Remove
10865         "struct" from foreach.
10866         * symtab.c (lookup_global_symbol_from_objfile)
10867         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10868         foreach.
10869         * ser-tcp.c (net_open): Remove "struct" from foreach.
10870         * objfiles.c (objfile_relocate, objfile_rebase)
10871         (objfile_has_symbols): Remove "struct" from foreach.
10872         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10873         from foreach.
10874         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10875         foreach.
10876         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10877         "struct" from foreach.
10878         * ada-lang.c (create_excep_cond_exprs)
10879         (ada_exception_catchpoint_cond_string): Remove "struct" from
10880         foreach.
10881
10882 2019-05-03  Tom Tromey  <tromey@adacore.com>
10883
10884         * ada-exp.y (convert_char_literal): Check suffix of each
10885         enumerator.
10886
10887 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10888
10889         PR ada/21406:
10890         * ada-exp.y (yywrap): Don't define.
10891         * ada-lex.l (%option): Add noyywrap
10892         (yywrap): Remove.
10893
10894 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10895
10896         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10897         _WIN32_WINNT to the XP level, unless already defined to a higher
10898         level.
10899
10900         * unittests/parse-connection-spec-selftests.c:
10901         * ser-tcp.c:
10902         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10903         override.
10904
10905         * symfile.c (find_separate_debug_file): Remove colon from the
10906         drive spec of DOS/Windows file names of the target, so that the
10907         file name produced from DEBUGDIR and the target's directory will
10908         be valid on DOS/Windows systems.
10909
10910 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10911
10912         * rust-lang.c (val_print_struct): Handle printing structures
10913         containing strings.
10914
10915 2019-05-02  Tom Tromey  <tromey@adacore.com>
10916
10917         * valarith.c (_initialize_valarith): Remove.
10918
10919 2019-05-01  Tom Tromey  <tromey@adacore.com>
10920
10921         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10922         bitfields.
10923
10924 2019-05-01  Tom Tromey  <tromey@adacore.com>
10925
10926         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10927         for big-endian copies.
10928
10929 2019-04-30  Ali Tamur  <tamur@google.com>
10930         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10931         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10932         (read_3_bytes): New function.
10933
10934 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10935
10936         * windows-nat.c (main_thread_id): Delete.
10937         (handle_output_debug_string): Replace main_thread_id by
10938         current_event.dwThreadId.
10939         (fake_create_process): Likewise.
10940         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10941         Do not set main_thread_id.
10942         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10943         current_event.dwThreadId.
10944         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10945
10946 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10947
10948         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10949         Use current_event.dwThreadId instead of main_thread_id.
10950
10951 2019-04-30  Tom Tromey  <tromey@adacore.com>
10952
10953         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10954         (create_excep_cond_exprs): Iterate over program spaces.
10955         (ada_exception_catchpoint_cond_string): Examine all minimal
10956         symbols for exception types.
10957
10958 2019-04-30  Tom Tromey  <tromey@adacore.com>
10959
10960         PR c++/24470:
10961         * dwarf2read.c (process_structure_scope): Handle case where type
10962         has template parameters but no symbol was created.
10963
10964 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10965             Chris January  <chris.january@arm.com>
10966
10967         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10968         qualifier.
10969         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10970
10971 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10972
10973         * f-typeprint.c (f_print_type): Update rules for printing
10974         whitespace.
10975         (f_type_print_varspec_suffix): Likewise.
10976
10977 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10978             Chris January  <chris.january@arm.com>
10979
10980         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10981         function arguments.
10982
10983 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10984
10985         * f-lang.c (build_fortran_types): Change name of void type to
10986         lower case.
10987         * f-typeprint.c (f_type_print_base): Print the name of the void
10988         type, rather than a fixed string.
10989         * f-valprint.c (f_decorations): Use lower case void string.
10990
10991 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10992             Chris January  <chris.january@arm.com>
10993
10994         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10995         types for Fortran.
10996
10997 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10998             Chris January  <chris.january@arm.com>
10999             David Lecomber  <david.lecomber@arm.com>
11000
11001         * f-exp.y (BINOP_INTRINSIC): New token.
11002         (exp): New parser rule handling BINOP_INTRINSIC.
11003         (f77_keywords): Add new builtin procedures.
11004         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
11005         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11006         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
11007         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11008         (print_unop_subexp_f): New function.
11009         (print_binop_subexp_f): New function.
11010         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11011         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11012         (dump_subexp_body_f): Likewise.
11013         (operator_check_f): Likewise.
11014         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11015         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
11016
11017 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11018
11019         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
11020         UNOP_KIND.
11021         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
11022         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
11023         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
11024         (operator_length_f): New fuction.
11025         (print_subexp_f): New function.
11026         (op_name_f): New function.
11027         (dump_subexp_body_f): New function.
11028         (operator_check_f): New function.
11029         (exp_descriptor_f): Replace standard expression handling functions
11030         with new functions.
11031         * gdb/fortran-operator.def: New file.
11032         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
11033         * gdb/std-operator.def: Remove UNOP_KIND.
11034
11035 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11036
11037         * std-operator.def: Remove unbalanced, stray double quote
11038         character.
11039
11040 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11041             Chris January  <chris.january@arm.com>
11042             Daniel Everett  <daniel.everett@arm.com>
11043             Nick Forrington  <nick.forrington@arm.com>
11044             Richard Bunt  <richard.bunt@arm.com>
11045
11046         * cp-valprint.c (cp_print_value_fields): Allow an additional level
11047         of depth when printing anonymous structs or unions.
11048         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
11049         Don't print either the top-level value, or the children if the
11050         max-depth is exceeded.
11051         (ppscm_print_children): When printing the key of a map, allow one
11052         extra level of depth.
11053         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
11054         print either the top-level value, or the children if the max-depth
11055         is exceeded.
11056         (print_children): When printing the key of a map, allow one extra
11057         level of depth.
11058         * python/py-value.c (valpy_format_string): Add max_depth keyword.
11059         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
11060         (user_print_options): Initialise max_depth field.
11061         (val_print_scalar_or_string_type_p): New function.
11062         (val_print): Check to see if the max depth has been reached.
11063         (val_print_check_max_depth): Define new function.
11064         (show_print_max_depth): New function.
11065         (_initialize_valprint): Add 'print max-depth' option.
11066         * valprint.h (struct value_print_options) <max_depth>: New field.
11067         (val_print_check_max_depth): Declare new function.
11068         * NEWS: Document new feature.
11069
11070 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11071
11072         * ada-lang.c (ada_language_defn): Initialise new field.
11073         * c-lang.c (c_is_string_type_p): New function.
11074         (c_language_defn): Initialise new field.
11075         (cplus_language_defn): Initialise new field.
11076         (asm_language_defn): Initialise new field.
11077         (minimal_language_defn): Initialise new field.
11078         * c-lang.h (c_is_string_type_p): Declare new function.
11079         * d-lang.c (d_language_defn): Initialise new field.
11080         * f-lang.c (f_is_string_type_p): New function.
11081         (f_language_defn): Initialise new field.
11082         * go-lang.c (go_is_string_type_p): New function.
11083         (go_language_defn): Initialise new field.
11084         * language.c (default_is_string_type_p): New function.
11085         (unknown_language_defn): Initialise new field.
11086         (auto_language_defn): Initialise new field.
11087         * language.h (struct language_defn) <la_is_string_type_p>: New
11088         member variable.
11089         (default_is_string_type_p): Declare new function.
11090         * m2-lang.c (m2_language_defn): Initialise new field.
11091         * objc-lang.c (objc_language_defn): Initialise new field.
11092         * opencl-lang.c (opencl_language_defn): Initialise new field.
11093         * p-lang.c (pascal_is_string_type_p): New function.
11094         (pascal_language_defn): Initialise new field.
11095         * rust-lang.c (rust_is_string_type_p): New function.
11096         (rust_language_defn): Initialise new field.
11097
11098 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11099
11100         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11101         New field.
11102         * ada-lang.c (ada_language_defn): Initialise new field.
11103         * c-lang.c (c_language_defn): Likewise.
11104         (cplus_language_defn): Likewise.
11105         (asm_language_defn): Likewise.
11106         (minimal_language_defn): Likewise.
11107         * d-lang.c (d_language_defn): Likewise.
11108         * f-lang.c (f_language_defn): Likewise.
11109         * go-lang.c (go_language_defn): Likewise.
11110         * language.c (unknown_language_defn): Likewise.
11111         (auto_language_defn): Likewise.
11112         * m2-lang.c (m2_language_defn): Likewise.
11113         * objc-lang.c (objc_language_defn): Likewise.
11114         * opencl-lang.c (opencl_language_defn): Likewise.
11115         * p-lang.c (pascal_language_defn): Likewise.
11116         * rust-lang.c (rust_language_defn): Likewise.
11117
11118 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11119
11120         * ada-lang.c (ada_is_character_type): Change return type to bool.
11121         (ada_is_string_type): Likewise.
11122         * ada-lang.h (ada_is_character_type): Update declaration
11123         (ada_is_string_type): Likewise.
11124
11125 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11126
11127         Support style in 'frame|thread apply'
11128
11129         * gdbcmd.h (execute_command_to_string): New term_out parameter.
11130         * record.c (record_start, record_stop): Update callers of
11131         execute_command_to_string with false.
11132         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11133         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11134         methods.
11135         (class string_file): New constructor with term_out parameter.
11136         Override methods term_out and can_emit_style_escape.  New member
11137         term_out.
11138         (class stdio_file): Override can_emit_style_escape.
11139         (class tee_file): Override term_out and can_emit_style_escape.
11140         * utils.h (can_emit_style_escape): Remove.
11141         * utils.c (can_emit_style_escape): Likewise.
11142         Update all callers of can_emit_style_escape (SOMESTREAM) to
11143         SOMESTREAM->can_emit_style_escape.
11144         * source-cache.c (source_cache::get_source_lines): Likewise.
11145         * stack.c (frame_apply_command_count): Call execute_command_to_string
11146         passing the term_out characteristic of the current gdb_stdout.
11147         * thread.c (thr_try_catch_cmd): Likewise.
11148         * top.c (execute_command_to_string): pass term_out parameter
11149         to construct the string_file for the command output.
11150         * ui-file.c (term_cli_styling): New function (most code moved
11151         from utils.c can_emit_style_escape).
11152         (string_file::string_file, string_file::can_emit_style_escape,
11153         stdio_file::can_emit_style_escape, tee_file::term_out,
11154         tee_file::can_emit_style_escape): New functions.
11155
11156 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11157
11158         * NEWS: Mention the new set|show may-call-functions.
11159         * infcall.c (may_call_functions_p): New variable.
11160         (show_may_call_functions_p): New function.
11161         (call_function_by_hand_dummy): Throws an error if not
11162         may-call-functions.
11163         (_initialize_infcall): Call add_setshow_boolean_cmd for
11164         may-call-functions.
11165
11166 2019-04-25  Keith Seitz  <keiths@redhat.com>
11167
11168         PR c++/24367
11169         * cp-support.c (inspect_type): Don't attempt substitutions
11170         of symbol with the same name.
11171
11172 2019-04-25  Tom Tromey  <tromey@adacore.com>
11173
11174         PR gdb/24475:
11175         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11176         static.
11177
11178 2019-04-25  Tom Tromey  <tromey@adacore.com>
11179
11180         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11181         rvalue reference.
11182         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11183         (gdb_xml_parser::parse): Use std::move.
11184         * python/python-internal.h (gdbpy_convert_exception): Take a const
11185         reference.
11186         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11187         std::move.
11188         * python/py-utils.c (gdbpy_convert_exception): Take a const
11189         reference.
11190         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11191         Use std::move.
11192         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11193         Use std::move.
11194         * mi/mi-main.c (mi_print_exception): Take a const reference.
11195         * main.c (handle_command_errors): Take a const reference.
11196         * linespec.c (parse_linespec): Use std::move.
11197         * infcall.c (run_inferior_call): Use std::move.
11198         (call_function_by_hand_dummy): Use std::move.
11199         * exec.c (try_open_exec_file): Use std::move.
11200         * exceptions.h (exception_print, exception_fprintf)
11201         (exception_print_same): Update.
11202         * exceptions.c (print_exception, exception_print)
11203         (exception_fprintf, exception_print_same): Change parameters to
11204         const reference.
11205         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11206         * common/new-op.c: Use std::move.
11207         * common/common-exceptions.h (struct gdb_exception): Add move
11208         constructor.
11209         (struct gdb_exception_error, struct gdb_exception_quit, struct
11210         gdb_quit_bad_alloc): Change constructor to move constructor.
11211         (throw_exception): Change parameter to rvalue reference.
11212         * common/common-exceptions.c (throw_exception): Take rvalue
11213         reference.
11214         * cli/cli-interp.c (safe_execute_command): Use std::move.
11215         * breakpoint.c (insert_bp_location, location_to_sals): Use
11216         std::move.
11217
11218 2019-04-25  Tom Tromey  <tromey@adacore.com>
11219
11220         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11221         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11222         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11223         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11224         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11225         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11226         guile/scm-value.c: Use unpack.
11227         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11228         gdbscm_gdb_exception.
11229         (gdbscm_throw_gdb_exception): Likewise.
11230         (struct gdbscm_gdb_exception): New.
11231         (unpack): New function.
11232         (gdbscm_wrap): Use unpack.
11233
11234 2019-04-25  Tom Tromey  <tromey@adacore.com>
11235
11236         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11237         (gdb_rl_callback_handler): Use std::move.
11238         * common/common-exceptions.h (struct gdb_exception): Add move
11239         assignment operator.
11240         (throw_exception_sjlj): Change "exception" to const reference.
11241         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11242         (throw_exception_sjlj): Change "exception" to const reference.
11243
11244 2019-04-25  Tom Tromey  <tromey@adacore.com>
11245
11246         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11247         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11248         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11249         Update.
11250         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11251         Update.
11252         * mi/mi-interp.c (mi_interp::exec): Update.
11253         * linespec.c (parse_linespec): Update.
11254         * infcall.c (run_inferior_call): Update.
11255         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11256         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11257         (gdbscm_lookup_global_symbol): Update.
11258         * guile/scm-param.c (gdbscm_parameter_value): Update.
11259         * guile/scm-frame.c (gdbscm_frame_read_register)
11260         (gdbscm_frame_read_var): Update.
11261         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11262         * exec.c (try_open_exec_file): Update.
11263         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11264         (gdb_rl_callback_handler): Update.
11265         * common/common-exceptions.h (exception_none): Don't declare.
11266         * common/common-exceptions.c (exception_none): Don't define.
11267         (struct catcher) <exception>: Update.
11268         * cli/cli-interp.c (safe_execute_command): Update.
11269         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11270
11271 2019-04-25  Ali Tamur  <tamur@google.com>
11272
11273         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11274         (read_attribute_value): Likewise.
11275         (dwarf2_read_addr_index): Update comment.
11276         (read_str_index): Add DW_FORM_strx.
11277         (dwarf2_string_attr): Likewise.
11278         (dwarf2_const_value_attr): Likewise.
11279         (dump_die_shallow): Likewise.
11280         (dwarf2_fetch_constant_bytes): Likewise.
11281         (skip_form_bytes): Likewise.
11282         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11283
11284 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11285
11286         PR corefiles/11608
11287         PR corefiles/18187
11288         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11289         OFFSET.  Verify if current mapping contains an ELF header.
11290         (linux_find_memory_regions_full): Adjust call to
11291         dump_mapping_p.
11292
11293 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11294             Kang Li <kanglictf@gmail.com>
11295
11296         PR gdb/21600
11297
11298         * dwarf2-frame.c (read_initial_length): Be consistent about using
11299         unsigned representation of length.
11300         (decode_frame_entry_1): Likewise.  Check for wraparound of
11301         end pointer as well as buffer overflow.
11302
11303 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11304
11305         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11306         "vq".
11307
11308 2019-04-24  Tom Tromey  <tromey@adacore.com>
11309
11310         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11311
11312 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11313
11314         * s12z-tdep.c (s12z_unwind_pc): Delete.
11315         (s12z_unwind_sp): Delete.
11316         (s12z_gdbarch_init): Don't register deleted functions with
11317         gdbarch.
11318
11319 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11320
11321         * rl78-tdep.c (rl78_unwind_sp): Delete.
11322         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11323
11324 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11325
11326         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11327         (xstormy16_unwind_pc): Delete.
11328         (xstormy16_dummy_id): Delete.
11329         (xstormy16_gdbarch_init): Don't register deleted functions with
11330         gdbarch.
11331
11332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11333
11334         * vax-tdep.c (vax_unwind_pc): Delete.
11335         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11336
11337 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11338
11339         * v850-tdep.c (v850_unwind_sp): Delete.
11340         (v850_unwind_pc): Delete.
11341         (v850_dummy_id): Delete.
11342         (v850_gdbarch_init): Don't register deleted functions with
11343         gdbarch.
11344
11345 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11346
11347         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11348         (tilegx_unwind_pc): Delete.
11349         (tilegx_unwind_dummy_id): Delete.
11350         (tilegx_gdbarch_init): Don't register deleted functions with
11351         gdbarch.
11352
11353 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11354
11355         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11356         (tic6x_dummy_id): Delete.
11357         (tic6x_gdbarch_init): Don't register deleted functions with
11358         gdbarch.
11359
11360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11361
11362         * sparc-tdep.c (sparc_unwind_pc): Delete.
11363         (sparc32_gdbarch_init): Don't register deleted function with
11364         gdbarch.
11365
11366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11367
11368         * sh-tdep.c (sh_unwind_sp): Delete.
11369         (sh_unwind_pc): Delete.
11370         (sh_dummy_id): Delete.
11371         (sh_gdbarch_init): Don't register deleted functions with
11372         gdbarch.
11373
11374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11375
11376         * score-tdep.c (score_unwind_sp): Delete.
11377         (score_unwind_pc): Delete.
11378         (score_dummy_id): Delete.
11379         (score_gdbarch_init): Don't register deleted functions with
11380         gdbarch.
11381
11382 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11383
11384         * rx-tdep.c (rx_unwind_pc): Delete.
11385         (rx_unwind_sp): Delete.
11386         (rx_dummy_id): Delete.
11387         (rx_gdbarch_init): Don't register deleted functions with
11388         gdbarch.  Update comment.
11389
11390 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11391
11392         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11393         (rs6000_dummy_id): Delete.
11394         (rs6000_gdbarch_init): Don't register deleted functions with
11395         gdbarch.
11396
11397 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11398
11399         * or1k-tdep.c (or1k_dummy_id): Delete.
11400         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11401
11402 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11403
11404         * nios2-tdep.c (nios2_dummy_id): Delete.
11405         (nios2_unwind_sp): Delete.
11406         (nios2_gdbarch_init): Don't register deleted functions with
11407         gdbarch.
11408
11409 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11410
11411         * nds32-tdep.c (nds32_dummy_id): Delete.
11412         (nds32_unwind_pc): Delete.
11413         (nds32_unwind_sp): Delete.
11414         (nds32_gdbarch_init): Don't register deleted functions with
11415         gdbarch.
11416
11417 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11418
11419         * msp430-tdep.c (msp430_unwind_pc): Delete.
11420         (msp430_unwind_sp): Delete.
11421         (msp430_dummy_id): Delete.
11422         (msp430_gdbarch_init): Don't register deleted functions with
11423         gdbarch.
11424
11425 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11426
11427         * moxie-tdep.c (moxie_unwind_sp): Delete.
11428         (moxie_unwind_pc): Delete.
11429         (moxie_dummy_id): Delete.
11430         (moxie_gdbarch_init): Don't register deleted functions with
11431         gdbarch.
11432
11433 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11434
11435         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11436         (mn10300_unwind_pc): Delete.
11437         (mn10300_unwind_sp): Delete.
11438         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11439         mn10300_unwind_sp.
11440         (mn10300_frame_unwind_init): Don't register deleted functions with
11441         gdbarch.
11442
11443 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11444
11445         * mep-tdep.c (mep_unwind_pc): Delete.
11446         (mep_unwind_sp): Delete.
11447         (mep_dummy_id): Delete.
11448         (mep_gdbarch_init): Don't register deleted functions with
11449         gdbarch.
11450
11451 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11452
11453         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11454         (m68hc11_unwind_sp): Delete.
11455         (m68hc11_gdbarch_init): Don't register deleted functions with
11456         gdbarch.
11457
11458 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11459
11460         * m32r-tdep.c (m32r_unwind_sp): Delete.
11461         (m32r_unwind_pc): Delete.
11462         (m32r_dummy_id): Delete.
11463         (m32r_gdbarch_init): Don't register deleted functions with
11464         gdbarch.
11465
11466 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11467
11468         * m32c-tdep.c (m32c_unwind_pc): Delete.
11469         (m32c_unwind_sp): Delete.
11470         (m32c_dummy_id): Delete.
11471         (m32c_gdbarch_init): Don't register deleted functions with
11472         gdbarch.
11473
11474 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11475
11476         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11477         (lm32_unwind_pc): Delete.
11478         (lm32_dummy_id): Delete.
11479         (lm32_gdbarch_init): Don't register deleted functions with
11480         gdbarch.
11481
11482 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11483
11484         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11485         (iq2000_unwind_pc): Delete.
11486         (iq2000_dummy_id): Delete.
11487         (iq2000_gdbarch_init): Don't register deleted functions with
11488         gdbarch.
11489
11490 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11491
11492         * nds32-tdep.c (nds32_type_align): Delete.
11493         (nds32_push_dummy_call): Use type_align instead.
11494
11495 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11496
11497         * arm-tdep.c (arm_type_align): Only handle vector override case.
11498         (arm_push_dummy_call): Use type_align.
11499         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11500
11501 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11502
11503         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11504         case.
11505         (pass_on_stack): Use type_align.
11506         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11507         function.
11508
11509 2019-04-23  Tom Tromey  <tromey@adacore.com>
11510
11511         * dwarf2read.c (line_header::file_name_at): Remove unused
11512         overload.
11513
11514 2019-04-23  Tom de Vries  <tdevries@suse.de>
11515
11516         PR gdb/24438
11517         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11518         invocation.
11519
11520
11521 2019-03-27  Ali Tamur  <tamur@google.com>
11522
11523         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11524         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11525         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11526         (dwarf_expr_context::get_addr_index): Likewise
11527         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11528         (symbol_needs_eval_context::get_addr_index): Likewise
11529         (disassemble_dwarf_expression): Add DW_OP_addrx
11530         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11531         (read_cutu_die_from_dwo): Update comment
11532         (skip_one_die): Add DW_FORM_addrx
11533         (read_attribute_value): Likewise
11534         (var_decode_location): Add DW_OP_addrx
11535         (dwarf2_const_value_attr): Add DW_FORM_addrx
11536         (dump_die_shallow): Likewise
11537         (dwarf2_fetch_constant_bytes): Likewise
11538         (decode_locdesc): Add DW_OP_addrx
11539         (skip_form_bytes): Add DW_FORM_addrx
11540
11541 2019-04-22  Ali Tamur  <tamur@google.com>
11542
11543         * MAINTAINERS (Write After Approval): Add self.
11544
11545 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11546
11547         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11548         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11549         (open_symbol_file_object): Likewise.
11550         (svr4_default_sos): Add info parameter.
11551         (svr4_read_so_list): Likewise.
11552         (svr4_current_sos_direct): Adjust functions calls to pass down
11553         info.
11554         (svr4_current_sos_1): Add info parameter.
11555         (svr4_current_sos): Call get_svr4_info, pass info down to
11556         svr4_current_sos_1.
11557         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11558         get_svr4_info.
11559         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11560         get_svr4_info.
11561         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11562         to get_svr4_info.
11563         (probes_table_remove_objfile_probes): Likewise.
11564         (register_solib_event_probe): Add info parameter.
11565         (solist_update_incremental): Pass info parameter down to
11566         svr4_read_so_list.
11567         (disable_probes_interface): Add info parameter.
11568         (svr4_handle_solib_event): Pass current_program_space to
11569         get_svr4_info.  Adjust disable_probes_interface cleanup.
11570         (svr4_create_probe_breakpoints): Add info parameter, pass it
11571         down to register_solib_event_probe.
11572         (svr4_create_solib_event_breakpoints): Add info parameter,
11573         pass it down to svr4_create_probe_breakpoints.
11574         (enable_break): Pass info down to
11575         svr4_create_solib_event_breakpoints.
11576         (svr4_solib_create_inferior_hook): Pass current_program_space to
11577         get_svr4_info.
11578         (svr4_clear_solib): Likewise.
11579
11580 2019-04-22  Pedro Alves  <palves@redhat.com>
11581
11582         * solib-svr4.c (svr4_free_objfile_observer): New.
11583         (probe_and_action::objfile): New field.
11584         (probes_table_htab_remove_objfile_probes)
11585         (probes_table_remove_objfile_probes): New functions.
11586         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11587         in the new probe_and_action.  Don't store the probe in 'lookup'.
11588         (svr4_create_probe_breakpoints): Pass objfile to
11589         register_solib_event_probe.
11590         (_initialize_svr4_solib): Register a free_objfile observer.
11591
11592 2019-04-19  Tom Tromey  <tom@tromey.com>
11593
11594         * common/queue.h: Remove.
11595
11596 2019-04-19  Tom Tromey  <tom@tromey.com>
11597
11598         * event-loop.c: Don't include "common/queue.h".
11599
11600 2019-04-19  Tom Tromey  <tom@tromey.com>
11601
11602         * remote.c (remote_target): Use delete.
11603         * remote-notif.h: Include <list>, not "common/queue.h".
11604         (notif_client_p): Remove typedef.
11605         (remote_notif_state): Add constructor, destructor, initializer.
11606         <notif_queue>: Now a std::list.
11607         (remote_notif_state_xfree): Don't declare.
11608         * remote-notif.c (remote_notif_process, handle_notification)
11609         (remote_notif_state_allocate): Update.
11610         (~remote_notif_state): Rename from remote_notif_state_xfree.
11611
11612 2019-04-19  Tom Tromey  <tom@tromey.com>
11613
11614         * symfile.c (reread_symbols): Update.
11615         * objfiles.c (objfile_register_static_link)
11616         (objfile_lookup_static_link): Update
11617         (~objfile) Don't delete static_links.
11618         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11619
11620 2019-04-19  Tom Tromey  <tom@tromey.com>
11621
11622         * type-stack.h (struct type_stack) <insert>: Constify string.
11623         * type-stack.c (type_stack::insert): Constify string.
11624         * gdbtypes.h (lookup_template_type): Update.
11625         (address_space_name_to_int): Update.
11626         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11627         const.
11628         (lookup_template_type): Make name const.
11629         * c-exp.y: Update rules.
11630         (lex_one_token, classify_name, classify_inner_name)
11631         (c_print_token): Update.
11632         * p-exp.y: Update rules.
11633         (yylex): Update.
11634         * f-exp.y: Update rules.
11635         (yylex): Update.
11636         * d-exp.y: Update rules.
11637         (lex_one_token, classify_name, classify_inner_name): Update.
11638         * parse.c (write_dollar_variable, copy_name): Return std::string.
11639         * parser-defs.h (copy_name): Change return type.
11640         * m2-exp.y: Update rules.
11641         (yylex): Update.
11642         * go-exp.y (lex_one_token): Update.
11643         Update rules.
11644         (classify_unsafe_function, classify_packaged_name)
11645         (classify_name, yylex): Update.
11646
11647 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11648
11649         * configure.ac: add --enable-source-highlight switch.
11650         * configure: Regenerate.
11651         * top.c (print_gdb_version): plumb --enable-source-highlight
11652         status to "show configuration".
11653
11654 2019-04-19  Tom Tromey  <tromey@adacore.com>
11655
11656         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11657         Check ADA_TYPE_P.
11658         (empty_record, ada_template_to_fixed_record_type_1)
11659         (template_to_static_fixed_type)
11660         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11661         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11662         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11663         macros.
11664
11665 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11666
11667         PR symtab/24423:
11668         * source.c (print_source_lines_base): Advance "iter" when a
11669         control character is seen.
11670
11671 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11672
11673         * inferior.h (struct infcall_suspend_state_deleter):
11674         Catch exception in destructor to avoid crash.
11675
11676 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11677
11678         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11679         close to the add_com "shell".
11680
11681 2019-04-18  Tom Tromey  <tromey@adacore.com>
11682
11683         * process-stratum-target.h (class process_stratum_target)
11684         <stratum>: Add "final".
11685
11686 2019-04-17  Tom Tromey  <tromey@adacore.com>
11687
11688         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11689         against nullptr before use.
11690
11691 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11692
11693         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11694
11695 2019-04-17  Jim Wilson  <jimw@sifive.com>
11696             Andrew Burgess  <andrew.burgess@embecosm.com>
11697
11698         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11699         code read might fail, assume 4-byte breakpoint in that case.
11700
11701 2019-04-15  Leszek Swirski  <leszeks@google.com>
11702
11703         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11704         rather than a hand-rolled POD check when checking for forced MEMORY
11705         classification.
11706
11707 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11708
11709         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11710         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11711         function.
11712         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11713         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11714         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11715         declaration.
11716
11717 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11718
11719         * aarch64-linux-nat.c
11720         (aarch64_linux_nat_target::thread_architecture): Add override.
11721         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11722         each VQ.
11723
11724 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11725
11726         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11727
11728 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11729
11730         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11731         target types of size 96-bits, add some additional comments, and
11732         check that the builtin type we found was the correct size.
11733
11734 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11735
11736         * utils.c (prompt_for_continue): Don't restore the styling at the
11737         end, as applied_style has the wrong value.  This fixes styling in
11738         long lists of file names that are interrupted by the "Continue?"
11739         prompt.
11740
11741 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11742
11743         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11744         * c-lang.c (c_language_defn): Likewise.
11745         (cplus_language_defn): Likewise.
11746         (asm_language_defn): Likewise.
11747         (minimal_language_defn): Likewise.
11748         * d-lang.c (d_language_defn): Likewise.
11749         * f-lang.c (f_language_defn): Likewise.
11750         * go-lang.c (go_language_defn): Likewise.
11751         * language.c (unknown_language_defn): Likewise.
11752         (auto_language_defn): Likewise.
11753         * language.h (struct language_defn): Remove la_magic field.
11754         (LANG_MAGIC): Delete.
11755         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11756         * objc-lang.c (objc_language_defn): Likewise.
11757         * opencl-lang.c (opencl_language_defn): Likewise.
11758         * p-lang.c (pascal_language_defn): Likewise.
11759         * rust-lang.c (rust_language_defn): Likewise.
11760
11761 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11762
11763         * riscv-tdep.c (riscv_type_align): New function.
11764         (riscv_type_alignment): Delete.
11765         (riscv_arg_location): Use 'type_align'.
11766         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11767
11768 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11769
11770         * gdbtypes.c (type_align): A struct with no non-static fields also
11771         has alignment of 1.
11772
11773 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11774
11775         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11776         component to 0.
11777         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11778         member.
11779         (riscv_struct_info::analyse): New implementation using new
11780         analyse_inner member function.
11781         (riscv_struct_info::field_offset): New member function.
11782         (riscv_struct_info::m_offsets): New member variable.
11783         (riscv_struct_info::analyse_inner): New private member function,
11784         takes the old implementation of riscv_struct_info::analyse but
11785         extended to track field offsets.
11786         (riscv_call_arg_struct): Update the struct folding special cases
11787         to handle cases where empty C++ structs, which are non-zero
11788         length, are found.
11789         (riscv_arg_location): Initialise the length of each location, a
11790         non-zero length now indicates the location is in use.
11791         (riscv_push_dummy_call): Allow for the first location having a
11792         non-zero offset when setting up arguments.
11793         (riscv_return_value): Likewise, but for return values.
11794
11795 2019-04-11  Tom Tromey  <tromey@adacore.com>
11796
11797         * utils.c (internal_vproblem): Make "msg" const.
11798
11799 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11800
11801         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11802         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11803         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11804         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11805
11806 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11807
11808         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11809         function.
11810         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11811         of amd64_collect_native_gregset.
11812         (amd64_linux_nat_target::store_registers): Likewise.
11813
11814 2019-04-10  Tom Tromey  <tom@tromey.com>
11815
11816         * symtab.c (lookup_global_symbol_from_objfile)
11817         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11818         * objfiles.h (class separate_debug_iterator): New.
11819         (class separate_debug_range): New.
11820         (struct objfile) <separate_debug_objfiles>: New method.
11821         (objfile_separate_debug_iterate): Don't declare.
11822         * objfiles.c (separate_debug_iterator::operator++): Rename from
11823         objfile_separate_debug_iterate.
11824         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11825         iterator.
11826         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11827         iterator.
11828
11829 2019-04-10  Tom Tromey  <tom@tromey.com>
11830
11831         * symfile.c (reread_symbols): Remove old comment.
11832         * objfiles.c (free_all_objfiles): Fix a typo.
11833
11834 2019-04-10  Tom Tromey  <tom@tromey.com>
11835
11836         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11837         * minsyms.c (lookup_minimal_symbol): Use foreach.
11838         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11839         (lookup_minimal_symbol_solib_trampoline): Likewise.
11840         * symfile.c (reread_symbols): Use foreach.
11841
11842 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11843             Tom Tromey  <tromey@adacore.com>
11844
11845         PR rust/24414:
11846         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11847         (rust_lex_int_test): Change "value" to be LONGEST.
11848         (rust_lex_tests): Add test for long integer literal.
11849
11850 2019-04-09  Tom Tromey  <tromey@adacore.com>
11851
11852         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11853         to bool.
11854         (extended_remote_target::attach): Update.
11855         (remote_target::remote_notice_new_inferior): Update.
11856         (remote_target::add_current_inferior_and_thread): Update.
11857         * inferior.c (exit_inferior_1): Use "false".
11858         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11859
11860 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11861
11862         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11863         the "start" command.
11864
11865 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11866
11867         * python/py-inferior.c (infpy_thread_from_thread_handle):
11868         Adjust comments to reflect renaming of thread_from_thread_handle
11869         to thread_from_handle.  Adjust keywords.  Fix type error message.
11870         (inferior_object_methods): Add thread_from_handle.  Retain
11871         thread_from_thread_handle, but mark it as deprecated.
11872
11873 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11874
11875         * gdbthread.h (find_thread_by_handle): Revise declaration.
11876         * thread.c (find_thread_by_handle): Likewise.  Adjust
11877         implementation too.
11878         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11879         support for buffer objects as handles.
11880
11881 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11882
11883         * python/py-infthread.c (thpy_thread_handle): New function.
11884         (thread_object_methods): Register thpy_thread_handle.
11885
11886 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11887
11888         * gdbthread.h (thread_to_thread_handle): Declare.
11889         * thread.c (gdbtypes.h): Include.
11890         (thread_to_thread_handle): New function.
11891
11892         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11893         (target_thread_info_to_thread_handle): Declare.
11894         * target.c (target_thread_info_to_thread_handle): New function.
11895         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11896         * target-delegates.c: Regenerate.
11897
11898         * linux-thread-db.c (class thread_db_target): Add method
11899         thread_info_to_thread_handle.
11900         (thread_db_target::thread_info_to_thread_handle): Define.
11901         * remote.c (class remote_target): Add new method
11902         thread_info_to_thread_handle.
11903         (remote_target::thread_info_to_thread_handle): Define.
11904
11905 2019-04-08  Pedro Alves  <palves@redhat.com>
11906
11907         * common/common-exceptions.c (throw_exception): Don't create
11908         named object to throw; throw directly.
11909         (throw_it): Likewise.  Don't initialize gdb_exception::message
11910         here, with new; pass FMT and AP to the ctor instead.
11911         * common/common-exceptions.h: Include <string>.
11912         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11913         const char *, va_list)): New ctor.  Use std::make_shared.
11914         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11915         errors)): Delete.
11916         (gdb_exception_error::gdb_exception_error(enum errors, const char
11917         *, va_list)): New.
11918         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11919         Add assertion.
11920         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11921         errors)): Delete.
11922         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11923         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11924         Add assertion.
11925
11926 2019-04-08  Tom Tromey  <tom@tromey.com>
11927
11928         * valops.c (value_rtti_indirect_type): Replace throw_exception
11929         with throw.
11930         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11931         with throw.
11932         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11933         throw.
11934         * target.c (target_translate_tls_address): Replace throw_exception
11935         with throw.
11936         * stack.c (frame_apply_command_count): Replace throw_exception
11937         with throw.
11938         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11939         throw.
11940         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11941         with throw.
11942         * rs6000-tdep.c (rs6000_frame_cache)
11943         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11944         * remote.c: Replace throw_exception with throw.
11945         * record-full.c (record_full_message, record_full_wait_1)
11946         (record_full_restore): Replace throw_exception with throw.
11947         * record-btrace.c:
11948         (get_thread_current_frame_id, record_btrace_start_replaying)
11949         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11950         (cmd_record_btrace_start): Replace throw_exception with throw.
11951         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11952         throw.
11953         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11954         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11955         * linespec.c:
11956         (find_linespec_symbols): Replace throw_exception with throw.
11957         * infrun.c (displaced_step_prepare, resume): Replace
11958         throw_exception with throw.
11959         * infcmd.c (post_create_inferior): Replace throw_exception with
11960         throw.
11961         * inf-loop.c (inferior_event_handler): Replace throw_exception
11962         with throw.
11963         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11964         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11965         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11966         (get_prev_frame_always, get_frame_pc_if_available)
11967         (get_frame_address_in_block_if_available, get_frame_language):
11968         Replace throw_exception with throw.
11969         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11970         throw_exception with throw.
11971         * eval.c (fetch_subexp_value, evaluate_var_value)
11972         (evaluate_funcall, evaluate_subexp_standard): Replace
11973         throw_exception with throw.
11974         * dwarf2loc.c (call_site_find_chain)
11975         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11976         Replace throw_exception with throw.
11977         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11978         with throw.
11979         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11980         throw.
11981         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11982         * completer.c (complete_line_internal): Replace throw_exception
11983         with throw.
11984         * compile/compile-object-run.c (compile_object_run): Replace
11985         throw_exception with throw.
11986         * cli/cli-script.c (process_next_line): Replace throw_exception
11987         with throw.
11988         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11989         (btrace_enable, btrace_maint_update_pt_packets): Replace
11990         throw_exception with throw.
11991         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11992         throw_exception with throw.
11993         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11994         throw_exception with throw.
11995         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11996         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11997         * aarch64-tdep.c (aarch64_make_prologue_cache)
11998         (aarch64_make_stub_cache): Replace throw_exception with throw.
11999
12000 2019-04-08  Tom Tromey  <tom@tromey.com>
12001
12002         * common/common-exceptions.c (throw_exception): Rename from
12003         throw_exception_cxx.  Remove old copy.  Make argument const.
12004         (throw_it): Create and throw exception objects directly.
12005         * common/common-exceptions.h (throw_exception): Make argument
12006         const.
12007         (struct gdb_exception_error): Add constructor.
12008         (struct gdb_exception_quit): Add constructor.
12009
12010 2019-04-08  Tom Tromey  <tom@tromey.com>
12011
12012         * common/common-exceptions.h (exception_rethrow): Don't declare.
12013         (TRY_SJLJ): Update comment.
12014         (TRY, CATCH, END_CATCH): Remove.
12015         * common/common-exceptions.c (exception_rethrow): Remove.
12016
12017 2019-04-08  Tom Tromey  <tom@tromey.com>
12018
12019         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
12020         Remove.
12021         (gdb_exception_error): Rename from
12022         gdb_exception_RETURN_MASK_ERROR.
12023         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
12024         (gdb_quit_bad_alloc): Update.
12025         * aarch64-tdep.c: Update.
12026         * ada-lang.c: Update.
12027         * ada-typeprint.c: Update.
12028         * ada-valprint.c: Update.
12029         * amd64-tdep.c: Update.
12030         * arch-utils.c: Update.
12031         * break-catch-throw.c: Update.
12032         * breakpoint.c: Update.
12033         * btrace.c: Update.
12034         * c-varobj.c: Update.
12035         * cli/cli-cmds.c: Update.
12036         * cli/cli-interp.c: Update.
12037         * cli/cli-script.c: Update.
12038         * common/common-exceptions.c: Update.
12039         * common/new-op.c: Update.
12040         * common/selftest.c: Update.
12041         * compile/compile-c-symbols.c: Update.
12042         * compile/compile-cplus-symbols.c: Update.
12043         * compile/compile-object-load.c: Update.
12044         * compile/compile-object-run.c: Update.
12045         * completer.c: Update.
12046         * corelow.c: Update.
12047         * cp-abi.c: Update.
12048         * cp-support.c: Update.
12049         * cp-valprint.c: Update.
12050         * darwin-nat.c: Update.
12051         * disasm-selftests.c: Update.
12052         * dtrace-probe.c: Update.
12053         * dwarf-index-cache.c: Update.
12054         * dwarf-index-write.c: Update.
12055         * dwarf2-frame-tailcall.c: Update.
12056         * dwarf2-frame.c: Update.
12057         * dwarf2loc.c: Update.
12058         * dwarf2read.c: Update.
12059         * eval.c: Update.
12060         * event-loop.c: Update.
12061         * event-top.c: Update.
12062         * exec.c: Update.
12063         * f-valprint.c: Update.
12064         * fbsd-tdep.c: Update.
12065         * frame-unwind.c: Update.
12066         * frame.c: Update.
12067         * gdbtypes.c: Update.
12068         * gnu-v3-abi.c: Update.
12069         * guile/guile-internal.h: Update.
12070         * guile/scm-block.c: Update.
12071         * guile/scm-breakpoint.c: Update.
12072         * guile/scm-cmd.c: Update.
12073         * guile/scm-disasm.c: Update.
12074         * guile/scm-frame.c: Update.
12075         * guile/scm-lazy-string.c: Update.
12076         * guile/scm-math.c: Update.
12077         * guile/scm-param.c: Update.
12078         * guile/scm-ports.c: Update.
12079         * guile/scm-pretty-print.c: Update.
12080         * guile/scm-symbol.c: Update.
12081         * guile/scm-symtab.c: Update.
12082         * guile/scm-type.c: Update.
12083         * guile/scm-value.c: Update.
12084         * i386-linux-tdep.c: Update.
12085         * i386-tdep.c: Update.
12086         * inf-loop.c: Update.
12087         * infcall.c: Update.
12088         * infcmd.c: Update.
12089         * infrun.c: Update.
12090         * jit.c: Update.
12091         * language.c: Update.
12092         * linespec.c: Update.
12093         * linux-fork.c: Update.
12094         * linux-nat.c: Update.
12095         * linux-tdep.c: Update.
12096         * linux-thread-db.c: Update.
12097         * main.c: Update.
12098         * mi/mi-cmd-break.c: Update.
12099         * mi/mi-cmd-stack.c: Update.
12100         * mi/mi-interp.c: Update.
12101         * mi/mi-main.c: Update.
12102         * objc-lang.c: Update.
12103         * p-valprint.c: Update.
12104         * parse.c: Update.
12105         * ppc-linux-tdep.c: Update.
12106         * printcmd.c: Update.
12107         * python/py-arch.c: Update.
12108         * python/py-breakpoint.c: Update.
12109         * python/py-cmd.c: Update.
12110         * python/py-finishbreakpoint.c: Update.
12111         * python/py-frame.c: Update.
12112         * python/py-framefilter.c: Update.
12113         * python/py-gdb-readline.c: Update.
12114         * python/py-inferior.c: Update.
12115         * python/py-infthread.c: Update.
12116         * python/py-lazy-string.c: Update.
12117         * python/py-linetable.c: Update.
12118         * python/py-objfile.c: Update.
12119         * python/py-param.c: Update.
12120         * python/py-prettyprint.c: Update.
12121         * python/py-progspace.c: Update.
12122         * python/py-record-btrace.c: Update.
12123         * python/py-record.c: Update.
12124         * python/py-symbol.c: Update.
12125         * python/py-type.c: Update.
12126         * python/py-unwind.c: Update.
12127         * python/py-utils.c: Update.
12128         * python/py-value.c: Update.
12129         * python/python.c: Update.
12130         * record-btrace.c: Update.
12131         * record-full.c: Update.
12132         * remote-fileio.c: Update.
12133         * remote.c: Update.
12134         * riscv-tdep.c: Update.
12135         * rs6000-aix-tdep.c: Update.
12136         * rs6000-tdep.c: Update.
12137         * rust-exp.y: Update.
12138         * rust-lang.c: Update.
12139         * s390-tdep.c: Update.
12140         * selftest-arch.c: Update.
12141         * solib-dsbt.c: Update.
12142         * solib-frv.c: Update.
12143         * solib-spu.c: Update.
12144         * solib-svr4.c: Update.
12145         * solib.c: Update.
12146         * sparc64-linux-tdep.c: Update.
12147         * stack.c: Update.
12148         * symfile-mem.c: Update.
12149         * symmisc.c: Update.
12150         * target.c: Update.
12151         * thread.c: Update.
12152         * top.c: Update.
12153         * tracefile-tfile.c: Update.
12154         * tui/tui.c: Update.
12155         * typeprint.c: Update.
12156         * unittests/cli-utils-selftests.c: Update.
12157         * unittests/parse-connection-spec-selftests.c: Update.
12158         * valops.c: Update.
12159         * valprint.c: Update.
12160         * value.c: Update.
12161         * varobj.c: Update.
12162         * windows-nat.c: Update.
12163         * x86-linux-nat.c: Update.
12164         * xml-support.c: Update.
12165
12166 2019-04-08  Tom Tromey  <tom@tromey.com>
12167
12168         * xml-support.c: Use C++ exception handling.
12169         * x86-linux-nat.c: Use C++ exception handling.
12170         * windows-nat.c: Use C++ exception handling.
12171         * varobj.c: Use C++ exception handling.
12172         * value.c: Use C++ exception handling.
12173         * valprint.c: Use C++ exception handling.
12174         * valops.c: Use C++ exception handling.
12175         * unittests/parse-connection-spec-selftests.c: Use C++ exception
12176         handling.
12177         * unittests/cli-utils-selftests.c: Use C++ exception handling.
12178         * typeprint.c: Use C++ exception handling.
12179         * tui/tui.c: Use C++ exception handling.
12180         * tracefile-tfile.c: Use C++ exception handling.
12181         * top.c: Use C++ exception handling.
12182         * thread.c: Use C++ exception handling.
12183         * target.c: Use C++ exception handling.
12184         * symmisc.c: Use C++ exception handling.
12185         * symfile-mem.c: Use C++ exception handling.
12186         * stack.c: Use C++ exception handling.
12187         * sparc64-linux-tdep.c: Use C++ exception handling.
12188         * solib.c: Use C++ exception handling.
12189         * solib-svr4.c: Use C++ exception handling.
12190         * solib-spu.c: Use C++ exception handling.
12191         * solib-frv.c: Use C++ exception handling.
12192         * solib-dsbt.c: Use C++ exception handling.
12193         * selftest-arch.c: Use C++ exception handling.
12194         * s390-tdep.c: Use C++ exception handling.
12195         * rust-lang.c: Use C++ exception handling.
12196         * rust-exp.y: Use C++ exception handling.
12197         * rs6000-tdep.c: Use C++ exception handling.
12198         * rs6000-aix-tdep.c: Use C++ exception handling.
12199         * riscv-tdep.c: Use C++ exception handling.
12200         * remote.c: Use C++ exception handling.
12201         * remote-fileio.c: Use C++ exception handling.
12202         * record-full.c: Use C++ exception handling.
12203         * record-btrace.c: Use C++ exception handling.
12204         * python/python.c: Use C++ exception handling.
12205         * python/py-value.c: Use C++ exception handling.
12206         * python/py-utils.c: Use C++ exception handling.
12207         * python/py-unwind.c: Use C++ exception handling.
12208         * python/py-type.c: Use C++ exception handling.
12209         * python/py-symbol.c: Use C++ exception handling.
12210         * python/py-record.c: Use C++ exception handling.
12211         * python/py-record-btrace.c: Use C++ exception handling.
12212         * python/py-progspace.c: Use C++ exception handling.
12213         * python/py-prettyprint.c: Use C++ exception handling.
12214         * python/py-param.c: Use C++ exception handling.
12215         * python/py-objfile.c: Use C++ exception handling.
12216         * python/py-linetable.c: Use C++ exception handling.
12217         * python/py-lazy-string.c: Use C++ exception handling.
12218         * python/py-infthread.c: Use C++ exception handling.
12219         * python/py-inferior.c: Use C++ exception handling.
12220         * python/py-gdb-readline.c: Use C++ exception handling.
12221         * python/py-framefilter.c: Use C++ exception handling.
12222         * python/py-frame.c: Use C++ exception handling.
12223         * python/py-finishbreakpoint.c: Use C++ exception handling.
12224         * python/py-cmd.c: Use C++ exception handling.
12225         * python/py-breakpoint.c: Use C++ exception handling.
12226         * python/py-arch.c: Use C++ exception handling.
12227         * printcmd.c: Use C++ exception handling.
12228         * ppc-linux-tdep.c: Use C++ exception handling.
12229         * parse.c: Use C++ exception handling.
12230         * p-valprint.c: Use C++ exception handling.
12231         * objc-lang.c: Use C++ exception handling.
12232         * mi/mi-main.c: Use C++ exception handling.
12233         * mi/mi-interp.c: Use C++ exception handling.
12234         * mi/mi-cmd-stack.c: Use C++ exception handling.
12235         * mi/mi-cmd-break.c: Use C++ exception handling.
12236         * main.c: Use C++ exception handling.
12237         * linux-thread-db.c: Use C++ exception handling.
12238         * linux-tdep.c: Use C++ exception handling.
12239         * linux-nat.c: Use C++ exception handling.
12240         * linux-fork.c: Use C++ exception handling.
12241         * linespec.c: Use C++ exception handling.
12242         * language.c: Use C++ exception handling.
12243         * jit.c: Use C++ exception handling.
12244         * infrun.c: Use C++ exception handling.
12245         * infcmd.c: Use C++ exception handling.
12246         * infcall.c: Use C++ exception handling.
12247         * inf-loop.c: Use C++ exception handling.
12248         * i386-tdep.c: Use C++ exception handling.
12249         * i386-linux-tdep.c: Use C++ exception handling.
12250         * guile/scm-value.c: Use C++ exception handling.
12251         * guile/scm-type.c: Use C++ exception handling.
12252         * guile/scm-symtab.c: Use C++ exception handling.
12253         * guile/scm-symbol.c: Use C++ exception handling.
12254         * guile/scm-pretty-print.c: Use C++ exception handling.
12255         * guile/scm-ports.c: Use C++ exception handling.
12256         * guile/scm-param.c: Use C++ exception handling.
12257         * guile/scm-math.c: Use C++ exception handling.
12258         * guile/scm-lazy-string.c: Use C++ exception handling.
12259         * guile/scm-frame.c: Use C++ exception handling.
12260         * guile/scm-disasm.c: Use C++ exception handling.
12261         * guile/scm-cmd.c: Use C++ exception handling.
12262         * guile/scm-breakpoint.c: Use C++ exception handling.
12263         * guile/scm-block.c: Use C++ exception handling.
12264         * guile/guile-internal.h: Use C++ exception handling.
12265         * gnu-v3-abi.c: Use C++ exception handling.
12266         * gdbtypes.c: Use C++ exception handling.
12267         * frame.c: Use C++ exception handling.
12268         * frame-unwind.c: Use C++ exception handling.
12269         * fbsd-tdep.c: Use C++ exception handling.
12270         * f-valprint.c: Use C++ exception handling.
12271         * exec.c: Use C++ exception handling.
12272         * event-top.c: Use C++ exception handling.
12273         * event-loop.c: Use C++ exception handling.
12274         * eval.c: Use C++ exception handling.
12275         * dwarf2read.c: Use C++ exception handling.
12276         * dwarf2loc.c: Use C++ exception handling.
12277         * dwarf2-frame.c: Use C++ exception handling.
12278         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12279         * dwarf-index-write.c: Use C++ exception handling.
12280         * dwarf-index-cache.c: Use C++ exception handling.
12281         * dtrace-probe.c: Use C++ exception handling.
12282         * disasm-selftests.c: Use C++ exception handling.
12283         * darwin-nat.c: Use C++ exception handling.
12284         * cp-valprint.c: Use C++ exception handling.
12285         * cp-support.c: Use C++ exception handling.
12286         * cp-abi.c: Use C++ exception handling.
12287         * corelow.c: Use C++ exception handling.
12288         * completer.c: Use C++ exception handling.
12289         * compile/compile-object-run.c: Use C++ exception handling.
12290         * compile/compile-object-load.c: Use C++ exception handling.
12291         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12292         * compile/compile-c-symbols.c: Use C++ exception handling.
12293         * common/selftest.c: Use C++ exception handling.
12294         * common/new-op.c: Use C++ exception handling.
12295         * cli/cli-script.c: Use C++ exception handling.
12296         * cli/cli-interp.c: Use C++ exception handling.
12297         * cli/cli-cmds.c: Use C++ exception handling.
12298         * c-varobj.c: Use C++ exception handling.
12299         * btrace.c: Use C++ exception handling.
12300         * breakpoint.c: Use C++ exception handling.
12301         * break-catch-throw.c: Use C++ exception handling.
12302         * arch-utils.c: Use C++ exception handling.
12303         * amd64-tdep.c: Use C++ exception handling.
12304         * ada-valprint.c: Use C++ exception handling.
12305         * ada-typeprint.c: Use C++ exception handling.
12306         * ada-lang.c: Use C++ exception handling.
12307         * aarch64-tdep.c: Use C++ exception handling.
12308
12309 2019-04-08  Tom Tromey  <tom@tromey.com>
12310
12311         * xml-support.c (gdb_xml_parser::parse): Update.
12312         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12313         * value.c (show_convenience): Update.
12314         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12315         (test_parse_flags_qcs): Update.
12316         * thread.c (thr_try_catch_cmd): Update.
12317         * target.c (target_translate_tls_address): Update.
12318         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12319         (info_frame_command_core, frame_apply_command_count): Update.
12320         * rust-exp.y (rust_lex_exception_test): Update.
12321         * riscv-tdep.c (riscv_print_one_register_info): Update.
12322         * remote.c (remote_target::enable_btrace): Update.
12323         * record-btrace.c (record_btrace_enable_warn): Update.
12324         * python/py-utils.c (gdbpy_convert_exception): Update.
12325         * printcmd.c (do_one_display, print_variable_and_value): Update.
12326         * mi/mi-main.c (mi_print_exception): Update.
12327         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12328         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12329         * linux-nat.c (linux_nat_target::attach): Update.
12330         * linux-fork.c (class scoped_switch_fork_info): Update.
12331         * infrun.c (displaced_step_prepare): Update.
12332         * infcall.c (call_function_by_hand_dummy): Update.
12333         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12334         * gnu-v3-abi.c (print_one_vtable): Update.
12335         * frame.c (get_prev_frame_always): Update.
12336         * f-valprint.c (info_common_command_for_block): Update.
12337         * exec.c (try_open_exec_file): Update.
12338         * exceptions.c (print_exception, exception_print)
12339         (exception_fprintf, exception_print_same): Update.
12340         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12341         * dwarf-index-cache.c (index_cache::store)
12342         (index_cache::lookup_gdb_index): Update.
12343         * darwin-nat.c (maybe_cache_shell): Update.
12344         * cp-valprint.c (cp_print_value_fields): Update.
12345         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12346         (gcc_cplus_symbol_address): Update.
12347         * compile/compile-c-symbols.c (gcc_convert_symbol)
12348         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12349         * common/selftest.c: Update.
12350         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12351         a std::string.
12352         (exception_try_scope_entry, exception_try_scope_exit): Don't
12353         declare.
12354         (struct exception_try_scope): Remove.
12355         (TRY): Don't use exception_try_scope.
12356         (struct gdb_exception): Add constructor, operator=.
12357         <what>: New method.
12358         (struct gdb_exception_RETURN_MASK_ALL)
12359         (struct gdb_exception_RETURN_MASK_ERROR)
12360         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12361         (struct gdb_quit_bad_alloc): Update.
12362         * common/common-exceptions.c (exception_none): Change
12363         initializer.
12364         (struct catcher) <state, exception>: Initialize inline.
12365         <prev>: Remove member.
12366         (current_catcher): Remove.
12367         (catchers): New global.
12368         (exceptions_state_mc_init): Simplify.
12369         (catcher_pop): Remove.
12370         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12371         (try_scope_depth, exception_try_scope_entry)
12372         (exception_try_scope_exit): Remove.
12373         (throw_exception_sjlj): Update.
12374         (exception_messages, exception_messages_size): Remove.
12375         (throw_it): Simplify.
12376         (gdb_exception_sliced_copy): Remove.
12377         (throw_exception_cxx): Update.
12378         * cli/cli-script.c (script_from_file): Update.
12379         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12380         Update.
12381         * ada-valprint.c (ada_val_print): Update.
12382         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12383         (create_excep_cond_exprs): Update.
12384
12385 2019-04-08  Tom Tromey  <tom@tromey.com>
12386
12387         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12388         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12389         (TRY, CATCH, END_CATCH): Remove some definitions.
12390         * common/common-exceptions.c: Don't use GDB_XCPT.
12391         (catcher_list_size): Remove.
12392         (throw_exception, throw_it): Simplify.
12393
12394 2019-04-05  Tom Tromey  <tom@tromey.com>
12395
12396         Revert the header-sorting patch.
12397         * ft32-tdep.c: Revert.
12398         * frv-tdep.c: Revert.
12399         * frv-linux-tdep.c: Revert.
12400         * frame.c: Revert.
12401         * frame-unwind.c: Revert.
12402         * frame-base.c: Revert.
12403         * fork-child.c: Revert.
12404         * findvar.c: Revert.
12405         * findcmd.c: Revert.
12406         * filesystem.c: Revert.
12407         * filename-seen-cache.h: Revert.
12408         * filename-seen-cache.c: Revert.
12409         * fbsd-tdep.c: Revert.
12410         * fbsd-nat.h: Revert.
12411         * fbsd-nat.c: Revert.
12412         * f-valprint.c: Revert.
12413         * f-typeprint.c: Revert.
12414         * f-lang.c: Revert.
12415         * extension.h: Revert.
12416         * extension.c: Revert.
12417         * extension-priv.h: Revert.
12418         * expprint.c: Revert.
12419         * exec.h: Revert.
12420         * exec.c: Revert.
12421         * exceptions.c: Revert.
12422         * event-top.c: Revert.
12423         * event-loop.c: Revert.
12424         * eval.c: Revert.
12425         * elfread.c: Revert.
12426         * dwarf2read.h: Revert.
12427         * dwarf2read.c: Revert.
12428         * dwarf2loc.c: Revert.
12429         * dwarf2expr.h: Revert.
12430         * dwarf2expr.c: Revert.
12431         * dwarf2-frame.c: Revert.
12432         * dwarf2-frame-tailcall.c: Revert.
12433         * dwarf-index-write.h: Revert.
12434         * dwarf-index-write.c: Revert.
12435         * dwarf-index-common.c: Revert.
12436         * dwarf-index-cache.h: Revert.
12437         * dwarf-index-cache.c: Revert.
12438         * dummy-frame.c: Revert.
12439         * dtrace-probe.c: Revert.
12440         * disasm.h: Revert.
12441         * disasm.c: Revert.
12442         * disasm-selftests.c: Revert.
12443         * dictionary.c: Revert.
12444         * dicos-tdep.c: Revert.
12445         * demangle.c: Revert.
12446         * dcache.h: Revert.
12447         * dcache.c: Revert.
12448         * darwin-nat.h: Revert.
12449         * darwin-nat.c: Revert.
12450         * darwin-nat-info.c: Revert.
12451         * d-valprint.c: Revert.
12452         * d-namespace.c: Revert.
12453         * d-lang.c: Revert.
12454         * ctf.c: Revert.
12455         * csky-tdep.c: Revert.
12456         * csky-linux-tdep.c: Revert.
12457         * cris-tdep.c: Revert.
12458         * cris-linux-tdep.c: Revert.
12459         * cp-valprint.c: Revert.
12460         * cp-support.c: Revert.
12461         * cp-namespace.c: Revert.
12462         * cp-abi.c: Revert.
12463         * corelow.c: Revert.
12464         * corefile.c: Revert.
12465         * continuations.c: Revert.
12466         * completer.h: Revert.
12467         * completer.c: Revert.
12468         * complaints.c: Revert.
12469         * coffread.c: Revert.
12470         * coff-pe-read.c: Revert.
12471         * cli-out.h: Revert.
12472         * cli-out.c: Revert.
12473         * charset.c: Revert.
12474         * c-varobj.c: Revert.
12475         * c-valprint.c: Revert.
12476         * c-typeprint.c: Revert.
12477         * c-lang.c: Revert.
12478         * buildsym.c: Revert.
12479         * buildsym-legacy.c: Revert.
12480         * build-id.h: Revert.
12481         * build-id.c: Revert.
12482         * btrace.c: Revert.
12483         * bsd-uthread.c: Revert.
12484         * breakpoint.h: Revert.
12485         * breakpoint.c: Revert.
12486         * break-catch-throw.c: Revert.
12487         * break-catch-syscall.c: Revert.
12488         * break-catch-sig.c: Revert.
12489         * blockframe.c: Revert.
12490         * block.c: Revert.
12491         * bfin-tdep.c: Revert.
12492         * bfin-linux-tdep.c: Revert.
12493         * bfd-target.c: Revert.
12494         * bcache.c: Revert.
12495         * ax-general.c: Revert.
12496         * ax-gdb.h: Revert.
12497         * ax-gdb.c: Revert.
12498         * avr-tdep.c: Revert.
12499         * auxv.c: Revert.
12500         * auto-load.c: Revert.
12501         * arm-wince-tdep.c: Revert.
12502         * arm-tdep.c: Revert.
12503         * arm-symbian-tdep.c: Revert.
12504         * arm-pikeos-tdep.c: Revert.
12505         * arm-obsd-tdep.c: Revert.
12506         * arm-nbsd-tdep.c: Revert.
12507         * arm-nbsd-nat.c: Revert.
12508         * arm-linux-tdep.c: Revert.
12509         * arm-linux-nat.c: Revert.
12510         * arm-fbsd-tdep.c: Revert.
12511         * arm-fbsd-nat.c: Revert.
12512         * arm-bsd-tdep.c: Revert.
12513         * arch-utils.c: Revert.
12514         * arc-tdep.c: Revert.
12515         * arc-newlib-tdep.c: Revert.
12516         * annotate.h: Revert.
12517         * annotate.c: Revert.
12518         * amd64-windows-tdep.c: Revert.
12519         * amd64-windows-nat.c: Revert.
12520         * amd64-tdep.c: Revert.
12521         * amd64-sol2-tdep.c: Revert.
12522         * amd64-obsd-tdep.c: Revert.
12523         * amd64-obsd-nat.c: Revert.
12524         * amd64-nbsd-tdep.c: Revert.
12525         * amd64-nbsd-nat.c: Revert.
12526         * amd64-nat.c: Revert.
12527         * amd64-linux-tdep.c: Revert.
12528         * amd64-linux-nat.c: Revert.
12529         * amd64-fbsd-tdep.c: Revert.
12530         * amd64-fbsd-nat.c: Revert.
12531         * amd64-dicos-tdep.c: Revert.
12532         * amd64-darwin-tdep.c: Revert.
12533         * amd64-bsd-nat.c: Revert.
12534         * alpha-tdep.c: Revert.
12535         * alpha-obsd-tdep.c: Revert.
12536         * alpha-nbsd-tdep.c: Revert.
12537         * alpha-mdebug-tdep.c: Revert.
12538         * alpha-linux-tdep.c: Revert.
12539         * alpha-linux-nat.c: Revert.
12540         * alpha-bsd-tdep.c: Revert.
12541         * alpha-bsd-nat.c: Revert.
12542         * aix-thread.c: Revert.
12543         * agent.c: Revert.
12544         * addrmap.c: Revert.
12545         * ada-varobj.c: Revert.
12546         * ada-valprint.c: Revert.
12547         * ada-typeprint.c: Revert.
12548         * ada-tasks.c: Revert.
12549         * ada-lang.c: Revert.
12550         * aarch64-tdep.c: Revert.
12551         * aarch64-ravenscar-thread.c: Revert.
12552         * aarch64-newlib-tdep.c: Revert.
12553         * aarch64-linux-tdep.c: Revert.
12554         * aarch64-linux-nat.c: Revert.
12555         * aarch64-fbsd-tdep.c: Revert.
12556         * aarch64-fbsd-nat.c: Revert.
12557         * aarch32-linux-nat.c: Revert.
12558
12559 2019-04-05  Tom Tromey  <tom@tromey.com>
12560
12561         * ft32-tdep.c: Sort headers.
12562         * frv-tdep.c: Sort headers.
12563         * frv-linux-tdep.c: Sort headers.
12564         * frame.c: Sort headers.
12565         * frame-unwind.c: Sort headers.
12566         * frame-base.c: Sort headers.
12567         * fork-child.c: Sort headers.
12568         * findvar.c: Sort headers.
12569         * findcmd.c: Sort headers.
12570         * filesystem.c: Sort headers.
12571         * filename-seen-cache.h: Sort headers.
12572         * filename-seen-cache.c: Sort headers.
12573         * fbsd-tdep.c: Sort headers.
12574         * fbsd-nat.h: Sort headers.
12575         * fbsd-nat.c: Sort headers.
12576         * f-valprint.c: Sort headers.
12577         * f-typeprint.c: Sort headers.
12578         * f-lang.c: Sort headers.
12579         * extension.h: Sort headers.
12580         * extension.c: Sort headers.
12581         * extension-priv.h: Sort headers.
12582         * expprint.c: Sort headers.
12583         * exec.h: Sort headers.
12584         * exec.c: Sort headers.
12585         * exceptions.c: Sort headers.
12586         * event-top.c: Sort headers.
12587         * event-loop.c: Sort headers.
12588         * eval.c: Sort headers.
12589         * elfread.c: Sort headers.
12590         * dwarf2read.h: Sort headers.
12591         * dwarf2read.c: Sort headers.
12592         * dwarf2loc.c: Sort headers.
12593         * dwarf2expr.h: Sort headers.
12594         * dwarf2expr.c: Sort headers.
12595         * dwarf2-frame.c: Sort headers.
12596         * dwarf2-frame-tailcall.c: Sort headers.
12597         * dwarf-index-write.h: Sort headers.
12598         * dwarf-index-write.c: Sort headers.
12599         * dwarf-index-common.c: Sort headers.
12600         * dwarf-index-cache.h: Sort headers.
12601         * dwarf-index-cache.c: Sort headers.
12602         * dummy-frame.c: Sort headers.
12603         * dtrace-probe.c: Sort headers.
12604         * disasm.h: Sort headers.
12605         * disasm.c: Sort headers.
12606         * disasm-selftests.c: Sort headers.
12607         * dictionary.c: Sort headers.
12608         * dicos-tdep.c: Sort headers.
12609         * demangle.c: Sort headers.
12610         * dcache.h: Sort headers.
12611         * dcache.c: Sort headers.
12612         * darwin-nat.h: Sort headers.
12613         * darwin-nat.c: Sort headers.
12614         * darwin-nat-info.c: Sort headers.
12615         * d-valprint.c: Sort headers.
12616         * d-namespace.c: Sort headers.
12617         * d-lang.c: Sort headers.
12618         * ctf.c: Sort headers.
12619         * csky-tdep.c: Sort headers.
12620         * csky-linux-tdep.c: Sort headers.
12621         * cris-tdep.c: Sort headers.
12622         * cris-linux-tdep.c: Sort headers.
12623         * cp-valprint.c: Sort headers.
12624         * cp-support.c: Sort headers.
12625         * cp-namespace.c: Sort headers.
12626         * cp-abi.c: Sort headers.
12627         * corelow.c: Sort headers.
12628         * corefile.c: Sort headers.
12629         * continuations.c: Sort headers.
12630         * completer.h: Sort headers.
12631         * completer.c: Sort headers.
12632         * complaints.c: Sort headers.
12633         * coffread.c: Sort headers.
12634         * coff-pe-read.c: Sort headers.
12635         * cli-out.h: Sort headers.
12636         * cli-out.c: Sort headers.
12637         * charset.c: Sort headers.
12638         * c-varobj.c: Sort headers.
12639         * c-valprint.c: Sort headers.
12640         * c-typeprint.c: Sort headers.
12641         * c-lang.c: Sort headers.
12642         * buildsym.c: Sort headers.
12643         * buildsym-legacy.c: Sort headers.
12644         * build-id.h: Sort headers.
12645         * build-id.c: Sort headers.
12646         * btrace.c: Sort headers.
12647         * bsd-uthread.c: Sort headers.
12648         * breakpoint.h: Sort headers.
12649         * breakpoint.c: Sort headers.
12650         * break-catch-throw.c: Sort headers.
12651         * break-catch-syscall.c: Sort headers.
12652         * break-catch-sig.c: Sort headers.
12653         * blockframe.c: Sort headers.
12654         * block.c: Sort headers.
12655         * bfin-tdep.c: Sort headers.
12656         * bfin-linux-tdep.c: Sort headers.
12657         * bfd-target.c: Sort headers.
12658         * bcache.c: Sort headers.
12659         * ax-general.c: Sort headers.
12660         * ax-gdb.h: Sort headers.
12661         * ax-gdb.c: Sort headers.
12662         * avr-tdep.c: Sort headers.
12663         * auxv.c: Sort headers.
12664         * auto-load.c: Sort headers.
12665         * arm-wince-tdep.c: Sort headers.
12666         * arm-tdep.c: Sort headers.
12667         * arm-symbian-tdep.c: Sort headers.
12668         * arm-pikeos-tdep.c: Sort headers.
12669         * arm-obsd-tdep.c: Sort headers.
12670         * arm-nbsd-tdep.c: Sort headers.
12671         * arm-nbsd-nat.c: Sort headers.
12672         * arm-linux-tdep.c: Sort headers.
12673         * arm-linux-nat.c: Sort headers.
12674         * arm-fbsd-tdep.c: Sort headers.
12675         * arm-fbsd-nat.c: Sort headers.
12676         * arm-bsd-tdep.c: Sort headers.
12677         * arch-utils.c: Sort headers.
12678         * arc-tdep.c: Sort headers.
12679         * arc-newlib-tdep.c: Sort headers.
12680         * annotate.h: Sort headers.
12681         * annotate.c: Sort headers.
12682         * amd64-windows-tdep.c: Sort headers.
12683         * amd64-windows-nat.c: Sort headers.
12684         * amd64-tdep.c: Sort headers.
12685         * amd64-sol2-tdep.c: Sort headers.
12686         * amd64-obsd-tdep.c: Sort headers.
12687         * amd64-obsd-nat.c: Sort headers.
12688         * amd64-nbsd-tdep.c: Sort headers.
12689         * amd64-nbsd-nat.c: Sort headers.
12690         * amd64-nat.c: Sort headers.
12691         * amd64-linux-tdep.c: Sort headers.
12692         * amd64-linux-nat.c: Sort headers.
12693         * amd64-fbsd-tdep.c: Sort headers.
12694         * amd64-fbsd-nat.c: Sort headers.
12695         * amd64-dicos-tdep.c: Sort headers.
12696         * amd64-darwin-tdep.c: Sort headers.
12697         * amd64-bsd-nat.c: Sort headers.
12698         * alpha-tdep.c: Sort headers.
12699         * alpha-obsd-tdep.c: Sort headers.
12700         * alpha-nbsd-tdep.c: Sort headers.
12701         * alpha-mdebug-tdep.c: Sort headers.
12702         * alpha-linux-tdep.c: Sort headers.
12703         * alpha-linux-nat.c: Sort headers.
12704         * alpha-bsd-tdep.c: Sort headers.
12705         * alpha-bsd-nat.c: Sort headers.
12706         * aix-thread.c: Sort headers.
12707         * agent.c: Sort headers.
12708         * addrmap.c: Sort headers.
12709         * ada-varobj.c: Sort headers.
12710         * ada-valprint.c: Sort headers.
12711         * ada-typeprint.c: Sort headers.
12712         * ada-tasks.c: Sort headers.
12713         * ada-lang.c: Sort headers.
12714         * aarch64-tdep.c: Sort headers.
12715         * aarch64-ravenscar-thread.c: Sort headers.
12716         * aarch64-newlib-tdep.c: Sort headers.
12717         * aarch64-linux-tdep.c: Sort headers.
12718         * aarch64-linux-nat.c: Sort headers.
12719         * aarch64-fbsd-tdep.c: Sort headers.
12720         * aarch64-fbsd-nat.c: Sort headers.
12721         * aarch32-linux-nat.c: Sort headers.
12722
12723 2019-04-04  Tom Tromey  <tom@tromey.com>
12724
12725         * varobj.c (varobj_create): Update.
12726         * rust-exp.y (struct rust_parser) <update_innermost_block,
12727         lookup_symbol>: New methods.
12728         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12729         Rename.
12730         (rust_parser::rust_lookup_type)
12731         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12732         * printcmd.c (display_command, do_one_display): Update.
12733         * parser-defs.h (struct parser_state) <parser_state>: Add
12734         "tracker" parameter.
12735         (block_tracker): New member.
12736         (class innermost_block_tracker) <innermost_block_tracker>: Add
12737         "types" parameter.
12738         <reset>: Remove method.
12739         (innermost_block): Don't declare.
12740         (null_post_parser): Update.
12741         * parse.c (innermost_block): Remove global.
12742         (write_dollar_variable): Update.
12743         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12744         Remove "tracker_types" parameter.
12745         (parse_expression): Add "tracker" parameter.
12746         (parse_expression_for_completion): Update.
12747         (null_post_parser): Add "tracker" parameter.
12748         * p-exp.y: Update rules.
12749         * m2-exp.y: Update rules.
12750         * language.h (struct language_defn) <la_post_parser>: Add
12751         "tracker" parameter.
12752         * go-exp.y: Update rules.
12753         * f-exp.y: Update rules.
12754         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12755         parameter.
12756         * d-exp.y: Update rules.
12757         * c-exp.y: Update rules.
12758         * breakpoint.c (set_breakpoint_condition): Create an
12759         innermost_block_tracker.
12760         (watch_command_1): Likewise.
12761         * ada-lang.c (resolve): Add "tracker" parameter.
12762         (resolve_subexp): Likewise.
12763         * ada-exp.y (write_var_from_sym): Update.
12764
12765 2019-04-04  Tom Tromey  <tom@tromey.com>
12766
12767         * type-stack.h: New file.
12768         * type-stack.c: New file.
12769         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12770         type-stack.h.
12771         (insert_into_type_stack, insert_type, push_type, push_type_int)
12772         (insert_type_address_space, pop_type, pop_type_int)
12773         (pop_typelist, pop_type_stack, append_type_stack)
12774         (push_type_stack, get_type_stack, push_typelist)
12775         (follow_type_instance_flags, follow_types): Don't declare.
12776         * parse.c (type_stack): Remove global.
12777         (parse_exp_in_context): Update.
12778         (insert_into_type_stack, insert_type, push_type, push_type_int)
12779         (insert_type_address_space, pop_type, pop_type_int)
12780         (pop_typelist, pop_type_stack, append_type_stack)
12781         (push_type_stack, get_type_stack, push_typelist)
12782         (follow_type_instance_flags, follow_types): Remove (moved to
12783         type-stack.c).
12784         * f-exp.y (type_stack): New global.
12785         Update rules.
12786         (push_kind_type, f_parse): Update.
12787         * d-exp.y (type_stack): New global.
12788         Update rules.
12789         (d_parse): Update.
12790         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12791         Update rules.
12792         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12793         (HFILES_NO_SRCDIR): Add type-stack.h.
12794
12795 2019-04-04  Tom Tromey  <tom@tromey.com>
12796
12797         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12798         (rust_parser::convert_ast_to_expression, rust_parse)
12799         (rust_lex_test_completion, rust_lex_tests): Update.
12800         * parser-defs.h (struct expr_completion_state): New.
12801         (struct parser_state) <parser_state>: Add completion parameter.
12802         <mark_struct_expression, mark_completion_tag>: New methods.
12803         <parse_completion, m_completion_state>: New members.
12804         (prefixify_expression, null_post_parser): Update.
12805         (mark_struct_expression, mark_completion_tag): Don't declare.
12806         * parse.c (parse_completion, expout_last_struct)
12807         (expout_tag_completion_type, expout_completion_name): Remove
12808         globals.
12809         (parser_state::mark_struct_expression)
12810         (parser_state::mark_completion_tag): Now methods.
12811         (prefixify_expression): Add last_struct parameter.
12812         (prefixify_subexp): Likewise.
12813         (parse_exp_1): Update.
12814         (parse_exp_in_context): Add cstate parameter.  Update.
12815         (parse_expression_for_completion): Create an
12816         expr_completion_state.
12817         (null_post_parser): Add "completion" parameter.
12818         * p-exp.y: Update rules.
12819         (yylex): Update.
12820         * language.h (struct language_defn) <la_post_parser>: Add
12821         "completing" parameter.
12822         * go-exp.y: Update rules.
12823         (lex_one_token): Update.
12824         * expression.h (parse_completion): Don't declare.
12825         * d-exp.y: Update rules.
12826         (lex_one_token): Update rules.
12827         * c-exp.y: Update rules.
12828         (lex_one_token): Update.
12829         * ada-lang.c (resolve): Add "parse_completion" parameter.
12830         (resolve_subexp): Likewise.
12831         (ada_resolve_function): Likewise.
12832
12833 2019-04-04  Tom Tromey  <tom@tromey.com>
12834
12835         * parser-defs.h (struct parser_state) <start_arglist,
12836         end_arglist>: New methods.
12837         <arglist_len, m_funcall_chain>: New members.
12838         (arglist_len, start_arglist, end_arglist): Don't declare.
12839         * parse.c (arglist_len, funcall_chain): Remove global.
12840         (start_arglist, end_arglist): Remove functions.
12841         (parse_exp_in_context): Update.
12842         * p-exp.y: Update rules.
12843         * m2-exp.y: Update rules.
12844         * go-exp.y: Update rules.
12845         * f-exp.y: Update rules.
12846         * d-exp.y: Update rules.
12847         * c-exp.y: Update rules.
12848
12849 2019-04-04  Tom Tromey  <tom@tromey.com>
12850
12851         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12852         lex_operator, push_back>: New methods.
12853         Update all rules.
12854         (rust_parser::lex_hex, lex_escape): Rename and update.
12855         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12856         (rust_parser::lex_operator): Rename and update.
12857         (rust_parser::lex_number, rustyylex, rustyyerror)
12858         (rust_lex_test_init, rust_lex_test_sequence)
12859         (rust_lex_test_push_back, rust_lex_tests): Update.
12860         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12861         parameter.
12862         <lexptr, prev_lexptr>: New members.
12863         (lexptr, prev_lexptr): Don't declare.
12864         * parse.c (lexptr, prev_lexptr): Remove globals.
12865         (parse_exp_in_context): Update.
12866         * p-exp.y (yylex, yyerror): Update.
12867         * m2-exp.y (parse_number, yylex, yyerror): Update.
12868         * go-exp.y (lex_one_token, yyerror): Update.
12869         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12870         * d-exp.y (lex_one_token, yyerror): Update.
12871         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12872         (lex_one_token, yyerror): Update.
12873         * ada-lex.l (YY_INPUT): Update.
12874         (rewind_to_char): Update.
12875         * ada-exp.y (yyerror): Update.
12876
12877 2019-04-04  Tom Tromey  <tom@tromey.com>
12878
12879         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12880         * parser-defs.h (struct parser_state) <parser_state>: Add new
12881         parameter.
12882         <comma_terminates>: New member.
12883         (comma_terminates): Don't declare global.
12884         * parse.c (comma_terminates): Remove global.
12885         (parse_exp_in_context): Update.
12886         * p-exp.y (yylex): Update.
12887         * m2-exp.y (yylex): Update.
12888         * go-exp.y (lex_one_token): Update.
12889         * f-exp.y (yylex): Update.
12890         * d-exp.y (lex_one_token): Update.
12891         * c-exp.y (lex_one_token): Update.
12892         * ada-lex.l: Update.
12893
12894 2019-04-04  Tom Tromey  <tom@tromey.com>
12895
12896         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12897         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12898         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12899         * parser-defs.h (paren_depth): Don't declare.
12900         * parse.c (paren_depth): Remove global.
12901         (parse_exp_in_context): Update.
12902         * p-exp.y (paren_depth): New global.
12903         (pascal_parse): Initialize it.
12904         * m2-exp.y (paren_depth): New global.
12905         (m2_parse): Initialize it.
12906         * go-exp.y (paren_depth): New global.
12907         (go_parse): Initialize it.
12908         * f-exp.y (paren_depth): New global.
12909         (f_parse): Initialize it.
12910         * d-exp.y (paren_depth): New global.
12911         (d_parse): Initialize it.
12912         * c-exp.y (paren_depth): New global.
12913         (c_parse): Initialize it.
12914         * ada-lex.l (paren_depth): New global.
12915         (lexer_init): Initialize it.
12916
12917 2019-04-04  Tom Tromey  <tom@tromey.com>
12918
12919         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12920         (rust_parser::convert_ast_to_type)
12921         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12922         * parser-defs.h (struct parser_state) <parser_state>: Add
12923         parameters.  Initialize new members.
12924         <expression_context_block, expression_context_pc>: New members.
12925         * parse.c (expression_context_block, expression_context_pc):
12926         Remove globals.
12927         (parse_exp_in_context): Update.
12928         * p-exp.y: Update all rules.
12929         (yylex): Update.
12930         * m2-exp.y: Update all rules.
12931         (yylex): Update.
12932         * go-exp.y (yylex): Update.
12933         * f-exp.y (yylex): Update.
12934         * d-exp.y: Update all rules.
12935         (yylex): Update.
12936         * c-exp.y: Update all rules.
12937         (lex_one_token, classify_name, yylex, c_parse): Update.
12938         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12939
12940 2019-04-04  Tom Tromey  <tom@tromey.com>
12941
12942         * gdbarch.h, gdbarch.c: Rebuild.
12943         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12944         * stap-probe.h:
12945         (struct stap_parse_info): Replace "parser_state" with
12946         "expr_builder".
12947         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12948         (parser_state): New class.
12949         * parse.c (expr_builder): Rename.
12950         (expr_builder::release): Rename.
12951         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12952         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12953         (write_exp_elt_longcst, write_exp_elt_floatcst)
12954         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12955         (write_exp_string_vector, write_exp_bitstring)
12956         (write_exp_msymbol, mark_struct_expression)
12957         (write_dollar_variable)
12958         (insert_type_address_space, increase_expout_size): Replace
12959         "parser_state" with "expr_builder".
12960         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12961         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12962         "parser_state" with "expr_builder".
12963
12964 2019-04-04  Tom Tromey  <tom@tromey.com>
12965
12966         * rust-exp.y: Replace "parse_language" with method call.
12967         * p-exp.y:
12968         (yylex): Replace "parse_language" with method call.
12969         * m2-exp.y:
12970         (yylex): Replace "parse_language" with method call.
12971         * go-exp.y (classify_name): Replace "parse_language" with method
12972         call.
12973         * f-exp.y (yylex): Replace "parse_language" with method call.
12974         * d-exp.y (lex_one_token): Replace "parse_language" with method
12975         call.
12976         * c-exp.y:
12977         (lex_one_token, classify_name, yylex): Replace "parse_language"
12978         with method call.
12979         * ada-exp.y (find_primitive_type, type_char)
12980         (type_system_address): Replace "parse_language" with method call.
12981
12982 2019-04-04  Tom Tromey  <tom@tromey.com>
12983
12984         * rust-exp.y: Replace "parse_gdbarch" with method call.
12985         * parse.c (write_dollar_variable, insert_type_address_space):
12986         Replace "parse_gdbarch" with method call.
12987         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12988         call.
12989         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12990         call.
12991         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12992         "parse_gdbarch" with method call.
12993         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12994         with method call.
12995         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12996         "parse_gdbarch" with method call.
12997         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12998         "parse_gdbarch" with method call.
12999         * c-exp.y (parse_type, parse_number, classify_name): Replace
13000         "parse_gdbarch" with method call.
13001         * ada-lex.l: Replace "parse_gdbarch" with method call.
13002         * ada-exp.y (parse_type, find_primitive_type, type_char)
13003         (type_system_address): Replace "parse_gdbarch" with method call.
13004
13005 2019-04-04  Tom Tromey  <tom@tromey.com>
13006
13007         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
13008         * stap-probe.c (stap_parse_argument): Update.
13009         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
13010         initial_size parameter.
13011         * rust-exp.y (rust_lex_tests): Update.
13012         * parse.c (parser_state): Update.
13013         (parse_exp_in_context): Update.
13014         * parser-defs.h (struct parser_state) <parser_state>: Remove
13015         "initial_size" parameter.
13016
13017 2019-04-04  Tom Tromey  <tom@tromey.com>
13018
13019         * parser-defs.h (increase_expout_size): Don't declare.
13020         * parse.c (increase_expout_size): Now static.
13021
13022 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
13023
13024         * gnu-nat.c (gnu_nat_target::wait): Fix
13025         target_waitstatus_to_string call.
13026
13027 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13028
13029         * eval.c (evaluate_subexp_standard): Handle internal functions
13030         during Fortran function call handling.
13031
13032 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13033
13034         * NEWS: Mention new internal functions.
13035         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
13036         (read_base_type): Use dwarf2_init_complex_target_type.
13037         * value.c (creal_internal_fn): New function.
13038         (cimag_internal_fn): New function.
13039         (_initialize_values): Register new internal functions.
13040
13041 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13042
13043         * infrun.c (stop_all_threads): If debug_infrun, always
13044         trace the wait status after wait_one, using
13045         target_waitstatus_to_string and target_pid_to_str.
13046         (handle_inferior_event): Replace various trace of
13047         wait status kind by a single trace.
13048         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
13049         wait status kind image by target_waitstatus_to_string.
13050         * target/waitstatus.c (target_waitstatus_to_string): Fix
13051         obsolete comment.
13052
13053 2019-04-01  Tom Tromey  <tromey@adacore.com>
13054
13055         PR symtab/23331:
13056         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
13057
13058 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
13059             Pedro Alves  <palves@redhat.com>
13060
13061         * top.c (quit_force): Call 'finalize_values'.
13062         * value.c (finalize_values): New function.
13063         * value.h (finalize_values): Declare.
13064
13065 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
13066
13067         * NEWS: Announce $_gdb_major and $_gdb_minor.
13068
13069         * top.c (init_gdb_version_vars): New function.
13070         (gdb_init): Call init_gdb_version_vars.
13071
13072 2019-03-29  Tom Tromey  <tromey@adacore.com>
13073
13074         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
13075         help text.  Remove dead code.
13076
13077 2019-03-29  Keith Seitz  <keiths@redhat.com>
13078
13079         From Siddhesh Poyarekar:
13080         * f-lang.h (f77_get_upperbound): Return LONGEST.
13081         (f77_get_lowerbound): Likewise.
13082         * f-typeprint.c (f_type_print_varspec_suffix): Expand
13083         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
13084         print them.
13085         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
13086         plongest to format print it.
13087         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13088         (f77_get_upperbound): Likewise.
13089         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13090         LOWER_BOUND to LONGEST.
13091         (f77_create_arrayprint_offset_tbl): Likewise.
13092
13093 2019-03-29  Keith Seitz  <keiths@redhat.com>
13094
13095         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13096         %s/pulongest for TYPE_LENGTH instead of %d in format
13097         strings.
13098         * ada-typerint.c (ada_print_type): Likewise.
13099         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13100         * compile/compile-c-support.c (generate_register_struct): Likewise.
13101         * gdbtypes.c (recursive_dump_type): Likewise.
13102         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13103         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
13104         instead of %d in format strings.
13105         * riscv-tdep.c (riscv_type_alignment): Cast second argument
13106         to std::min to ULONGEST.
13107         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13108         instead of %d in format strings.
13109         * tracepoint.c (info_scope_command): Likewise.
13110         * typeprint.c (print_offset_data::update)
13111         (print_offset_data::finish): Likewise.
13112         * xtensa-tdep.c (xtensa_store_return_value)
13113         (xtensa_push_dummy_call): Likewise.
13114
13115 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
13116
13117         * windows-nat.c (display_selector): Fixed format specifications
13118         for 64-bit Cygwin.
13119
13120 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13121
13122         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13123
13124 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
13125
13126         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13127         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13128         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13129         (nios2_linux_init_abi): Install it.
13130
13131 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13132
13133         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13134
13135 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13136
13137         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13138
13139 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13140             Tom Tromey  <tromey@adacore.com>
13141
13142         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13143
13144 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
13145
13146         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13147         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13148         method to compute the bounds of range types. Also print "[evaluated]"
13149         if the bounds' values come from a dynamic evaluation.
13150
13151 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13152
13153         * cp-valprint.c (cp_print_value_fields): Don't print trailing
13154         whitespace when pretty printing is on.
13155
13156 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13157
13158         * ppc-linux-nat.c: Add include.
13159
13160 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13161
13162         * NEWS: Mention AArch64 Pointer Authentication.
13163
13164 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13165
13166         * arm-linux-nat.c: Add include.
13167
13168 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
13169
13170         * source-cache.c (source_cache::get_source_lines): Re-read
13171         fullname after calling open_source_file.
13172
13173 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
13174
13175         * NEWS: Mention TLS support for FreeBSD.
13176
13177 2019-03-25  Tom Tromey  <tromey@adacore.com>
13178
13179         * minsyms.c (BUNCH_SIZE): Update comment.
13180         (~minimal_symbol_reader): Remove old comment.
13181         (compact_minimal_symbols): Update comment.
13182         (minimal_symbol_reader::install): Remove old comment.  Update
13183         other comments.
13184
13185 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13186
13187         * s390-linux-nat.c: Add include.
13188
13189 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13190
13191         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13192         Call linux_get_hwcap.
13193         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13194         Likewise.
13195         (aarch64_linux_get_hwcap): Remove function.
13196         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13197         declaration.
13198         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13199         linux_get_hwcap.
13200         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13201         * linux-tdep.c (linux_get_hwcap): Add function.
13202         (linux_get_hwcap2): Likewise.
13203         * linux-tdep.h (linux_get_hwcap): Add declaration.
13204         (linux_get_hwcap2): Likewise.
13205         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13206         (ppc_linux_get_hwcap2): Likewise.
13207         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13208         linux_get_hwcap.
13209         (ppc_linux_nat_target::insert_watchpoint): Likewise.
13210         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13211         (ppc_linux_nat_target::read_description): Likewise.
13212         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13213         * s390-linux-nat.c: Likewise.
13214         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13215
13216 2019-03-24  Tom Tromey  <tom@tromey.com>
13217
13218         * ada-lang.c (standard_lookup): Simplify initialization.
13219         (ada_lookup_symbol_nonlocal): Simplify return.
13220         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13221         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13222         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13223         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13224         initialization.
13225         * solib.c (solib_global_lookup): Simplify.
13226         * symtab.c (null_block_symbol): Remove.
13227         (symbol_cache_lookup): Simplify returns.
13228         (lookup_language_this): Simplify returns.
13229         (lookup_symbol_aux): Simplify return.
13230         (lookup_local_symbol): Simplify returns.
13231         (lookup_global_symbol_from_objfile): Simplify return.
13232         (lookup_symbol_in_objfile_symtabs)
13233         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13234         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13235         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13236         * cp-namespace.c (cp_lookup_bare_symbol)
13237         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13238         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13239         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13240         (cp_lookup_symbol_via_imports): Simplify initialization.
13241         (find_symbol_in_baseclass): Likewise.
13242         * symtab.h (null_block_symbol): Remove.
13243         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13244         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13245         (d_lookup_symbol_module): Likewise.
13246         (find_symbol_in_baseclass): Simplify initialization.
13247
13248 2019-03-24  Tom Tromey  <tom@tromey.com>
13249
13250         * expression.h: Don't include symtab.h.
13251         (struct block): Forward declare.
13252
13253 2019-03-24  Tom Tromey  <tom@tromey.com>
13254
13255         * c-exp.y (typebase): Remove casts.
13256         * gdbtypes.c (lookup_unsigned_typename, )
13257         (lookup_signed_typename): Remove cast.
13258         * eval.c (parse_to_comma_and_eval): Remove cast.
13259         * parse.c (write_dollar_variable): Remove cast.
13260         * block.h (struct block) <superblock>: Now const.
13261         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13262         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13263         (map_block): Make "block" const.
13264         * symfile.h (struct quick_symbol_functions)
13265         <map_matching_symbols>: Constify block argument to "callback".
13266         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13267         const.
13268         (find_pc_sect_compunit_symtab): Make "b" const.
13269         (find_symbol_at_address): Likewise.
13270         (search_symbols): Likewise.
13271         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13272         (dw2_debug_names_lookup_symbol): Likewise.
13273         (dw2_map_matching_symbols): Update.
13274         * p-valprint.c (pascal_val_print): Remove "block".
13275         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13276         (aux_add_nonlocal_symbols): Make "block" const.
13277         (resolve_subexp): Remove cast.
13278         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13279         const.
13280         (iterate_over_file_blocks): Likewise.
13281         * f-exp.y (%union) <bval>: Remove.
13282         * coffread.c (patch_opaque_types): Make "b" const.
13283         * spu-tdep.c (spu_catch_start): Make "block" const.
13284         * c-valprint.c (print_unpacked_pointer): Remove "block".
13285         * symmisc.c (dump_symtab_1): Make "b" const.
13286         (block_depth): Make "block" const.
13287         * d-exp.y (%union) <bval>: Remove.
13288         * cp-support.h (cp_lookup_rtti_type): Update.
13289         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13290         * psymtab.c (psym_lookup_symbol): Make "block" const.
13291         (maintenance_check_psymtabs): Make "b" const.
13292         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13293         (enumerate_locals, enumerate_args): Update.
13294         * python/py-symtab.c (stpy_global_block): Make "block" const.
13295         (stpy_static_block): Likewise.
13296         * inline-frame.c (block_starting_point_at): Make "new_block"
13297         const.
13298         * block.c (find_block_in_blockvector): Make return type const.
13299         (blockvector_for_pc_sect): Make "b" const.
13300         (find_block_in_blockvector): Make "b" const.
13301
13302 2019-03-23  Tom Tromey  <tom@tromey.com>
13303
13304         * varobj.c (varobj_create): Update.
13305         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13306         * printcmd.c (display_command, do_one_display): Don't reset
13307         innermost_block.
13308         * parser-defs.h (enum innermost_block_tracker_type): Move to
13309         expression.h.
13310         (innermost_block): Update comment.
13311         * parse.c (parse_exp_1): Add tracker_types parameter.
13312         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13313         tracker_types parameter.  Reset innermost_block.
13314         (parse_exp_in_context): Remove.
13315         (parse_expression_for_completion): Update.
13316         * objfiles.c (~objfile): Don't reset expression_context_block or
13317         innermost_block.
13318         * expression.h (enum innermost_block_tracker_type): Move from
13319         parser-defs.h.
13320         (parse_exp_1): Add tracker_types parameter.
13321         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13322         reset innermost_block.
13323
13324 2019-03-23  Tom Tromey  <tom@tromey.com>
13325
13326         * objfiles.h: Include bcache.h.
13327
13328 2019-03-23  Tom Tromey  <tom@tromey.com>
13329
13330         * linespec.c (get_current_search_block): Use
13331         scoped_restore_current_language.
13332         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13333
13334 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13335             Jiong Wang  <jiong.wang@arm.com>
13336
13337         * aarch64-linux-tdep.c
13338         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13339         section.
13340         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13341
13342 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13343             Jiong Wang  <jiong.wang@arm.com>
13344
13345         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13346         instructions.
13347         (aarch64_analyze_prologue_test): Add PACIASP test.
13348         (aarch64_prologue_prev_register): Unmask PC value.
13349
13350 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13351             Jiong Wang  <jiong.wang@arm.com>
13352
13353         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13354         (aarch64_dwarf2_prev_register): Unmask PC value.
13355         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13356         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13357         DW_CFA_AARCH64_negate_ra_state.
13358         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13359
13360 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13361             Jiong Wang  <jiong.wang@arm.com>
13362
13363         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13364         registers.
13365         (aarch64_pseudo_register_name): Likewise.
13366         (aarch64_pseudo_register_type): Likewise.
13367         (aarch64_pseudo_register_reggroup_p): Likewise.
13368         (aarch64_gdbarch_init): Add pauth registers.
13369         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13370         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13371         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13372         (struct gdbarch_tdep): Add regnum for ra_state.
13373
13374 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13375             Jiong Wang  <jiong.wang@arm.com>
13376
13377         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13378
13379 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13380             Jiong Wang  <jiong.wang@arm.com>
13381
13382         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13383         function.
13384         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13385         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13386         (aarch64_gdbarch_init): Add puth registers.
13387         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13388         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13389         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13390
13391 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13392             Jiong Wang  <jiong.wang@arm.com>
13393
13394         * aarch64-linux-nat.c
13395         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13396         * aarch64-linux-tdep.c
13397         (aarch64_linux_core_read_description): Likewise.
13398         (aarch64_linux_get_hwcap): New function.
13399         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13400         (aarch64_linux_get_hwcap): New declaration.
13401
13402 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13403             Jiong Wang  <jiong.wang@arm.com>
13404
13405         * aarch64-linux-nat.c
13406         (aarch64_linux_nat_target::read_description): Add pauth param.
13407         * aarch64-linux-tdep.c
13408         (aarch64_linux_core_read_description): Likewise.
13409         * aarch64-tdep.c (struct target_desc): Add in pauth.
13410         (aarch64_read_description): Add pauth param.
13411         (aarch64_gdbarch_init): Likewise.
13412         * aarch64-tdep.h (aarch64_read_description): Likewise.
13413         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13414         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13415         * features/Makefile: Add new files.
13416         * features/aarch64-pauth.c: New file.
13417         * features/aarch64-pauth.xml: New file.
13418
13419 2019-03-20  Tom Tromey  <tromey@adacore.com>
13420
13421         * infrun.c (handle_inferior_event): Rename from
13422         handle_inferior_event_1.  Create a scoped_value_mark.
13423         (handle_inferior_event): Remove.
13424
13425 2019-03-19  Tom Tromey  <tromey@adacore.com>
13426
13427         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13428         * infrun.h (print_stop_event): Add "displays" parameter.
13429         * infrun.c (print_stop_event): Add "displays" parameter.
13430
13431 2019-03-19  Pedro Alves  <palves@redhat.com>
13432
13433         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13434         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13435         to -1.  Fix TABs vs spaces.
13436         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13437         * tui/tui-out.h (tui_ui_out) Add intro comments.
13438         <m_line, m_start_of_line>: In-class initialize, and add describing
13439         comment.
13440
13441 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13442
13443         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13444         variable names.
13445         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13446
13447 2019-03-18  Pedro Alves  <palves@redhat.com>
13448             Eli Zaretskii <eliz@gnu.org>
13449
13450         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13451         m_line and m_start_of_line.
13452
13453 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13454
13455         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13456         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13457         it returns a newline.  This fixes a regression in TU mode, whereby
13458         the next line is output on the same screen line as the user input.
13459
13460 2019-03-18  Tom Tromey  <tromey@adacore.com>
13461
13462         * minsyms.c (minimal_symbol_reader::install): Remove call to
13463         obstack_blank.
13464
13465 2019-03-18  Pedro Alves  <palves@redhat.com>
13466
13467         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13468         New globals.
13469         (apply_style): New, factored out from ...
13470         (apply_ansi_escape): ... this.  Handle reverse video mode.
13471         (tui_set_reverse_mode): New function.
13472         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13473         * tui/tui-winsource.c (tui_show_source_line): Use
13474         tui_set_reverse_mode instead of setting A_STANDOUT.
13475         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13476         New setter methods.
13477
13478 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13479
13480         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13481         Handle tabs.
13482
13483 2019-03-18  Tom Tromey  <tromey@adacore.com>
13484
13485         * ada-lang.c (empty_array): Add "high" parameter.
13486         (ada_evaluate_subexp): Update.
13487
13488 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13489
13490         * unittests/string_view-selftests.c: Define
13491         _initialize_string_view_selftests unconditionally.
13492
13493 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13494
13495         PR gdb/24350
13496         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13497
13498 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13499
13500         PR gdb/24351
13501         * windows-nat.c (display_selector): Fix format specifiers.
13502
13503 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13504
13505         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13506         tui_refill_source_window instead of tui_refresh_win, to update the
13507         current execution line.  This fixes redisplay of the current line
13508         when stepping through the code with "next" or "step".
13509
13510 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13511
13512         * source-cache.c (source_cache::get_source_lines): Call
13513         find_source_lines to initialize s->nlines.  This fixes vertical
13514         scrolling of TUI source window when the DOWN arrow is pressed.
13515
13516 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13517
13518         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13519         linux-thread-db.c (_initialize_thread_db): Likewise.
13520
13521 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13522
13523         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13524         wclrtoeol in tui_show_source_line".  This reverts changes made in
13525         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13526
13527 2019-03-15  Tom Tromey  <tom@tromey.com>
13528
13529         * symtab.h (struct minimal_symbol): Derive from
13530         general_symbol_info.
13531         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13532         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13533         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13534         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13535         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13536         (MSYMBOL_SEARCH_NAME): Update.
13537         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13538         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13539         * minsyms.c (minimal_symbol_reader::record_full): Update.
13540
13541 2019-03-15  Tom Tromey  <tom@tromey.com>
13542
13543         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13544
13545 2019-03-15  Tom Tromey  <tom@tromey.com>
13546
13547         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13548         unique_xmalloc_ptr.
13549         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13550         Update.
13551         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13552         (build_minimal_symbol_hash_tables)
13553         (minimal_symbol_reader::install): Update.
13554
13555 2019-03-15  Tom Tromey  <tom@tromey.com>
13556
13557         * symtab.c (create_demangled_names_hash): Update.
13558         (symbol_set_names): Update.
13559         * objfiles.h (struct objfile_per_bfd_storage)
13560         <demangled_names_hash>: Now an htab_up.
13561         * objfiles.c (objfile_per_bfd_storage): Simplify.
13562
13563 2019-03-15  Tom Tromey  <tom@tromey.com>
13564
13565         * objfiles.h (struct objfile_per_bfd_storage): Declare
13566         destructor.
13567         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13568         New.
13569         (get_objfile_bfd_data): Use new.  Don't initialize
13570         language_of_main.
13571         (free_objfile_per_bfd_storage): Remove.
13572         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13573
13574 2019-03-15  Tom Tromey  <tom@tromey.com>
13575
13576         * symfile.c (reread_symbols): Update.
13577         * objfiles.c (objfile::objfile): Update.
13578         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13579         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13580         comment.
13581         (minimal_symbol_reader::install): Update.
13582         (terminate_minimal_symbol_table): Remove.
13583         * jit.c (jit_object_close_impl): Update.
13584
13585 2019-03-15  Tom Tromey  <tom@tromey.com>
13586
13587         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13588         initializations.
13589
13590 2019-03-15  Tom Tromey  <tom@tromey.com>
13591
13592         * objfiles.h (struct objfile_per_bfd_storage)
13593         <demangled_hash_languages>: Now a bitset.
13594         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13595         (lookup_minimal_symbol): Update.
13596
13597 2019-03-15  Tom Tromey  <tom@tromey.com>
13598
13599         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13600         Don't return the symbol.
13601         * coffread.c (record_minimal_symbol): Use record_full.
13602
13603 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13604
13605         The MS-Windows port of ncurses fails to switch to a color pair if
13606         one or both of the colors are the implicit default colors.  This
13607         change records the default colors when TUI is initialized, and
13608         then specifies them explicitly when a color pair uses the default
13609         colors.  This allows color styling in TUI mode on MS-Windows.
13610
13611         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13612         ncurses_norm_attr.
13613         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13614         colors in ncurses_norm_attr.
13615         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13616         "none", replace it with the default color recorded in
13617         ncurses_norm_attr.
13618
13619 2019-03-14  Tom Tromey  <tromey@adacore.com>
13620
13621         * source-cache.h (class source_cache) <get_source_lines>: Return
13622         std::string.
13623         * source-cache.c (source_cache::extract_lines): Handle case where
13624         first_pos==npos.  Return std::string.
13625         (source_cache::get_source_lines): Update.
13626
13627 2019-03-14  Tom Tromey  <tromey@adacore.com>
13628
13629         * NEWS: Add item for "style sources" commands.
13630         * source-cache.c (source_cache::get_source_lines): Check
13631         source_styling.
13632         * cli/cli-style.c (source_styling): New global.
13633         (_initialize_cli_style): Add "style sources" commands.
13634         (show_style_sources): New function.
13635         * cli/cli-style.h (source_styling): Declare.
13636
13637 2019-03-14  Pedro Alves  <palves@redhat.com>
13638             Tom Tromey  <tromey@adacore.com>
13639
13640         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13641         * tui/tui-winsource.c (tui_refill_source_window): New function,
13642         from...
13643         (tui_horizontal_source_scroll): ... here.  Move some logic.
13644         * cli/cli-style.c (set_style_enabled): Notify new observable.
13645         * tui/tui-hooks.c (tui_redisplay_source): New function.
13646         (tui_attach_detach_observers): Attach or detach
13647         tui_redisplay_source.
13648         * observable.h (source_styling_changed): New observable.
13649         * observable.c: Define source_styling_changed observable.
13650
13651 2019-03-13  Tom Tromey  <tromey@adacore.com>
13652
13653         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13654         (i386_gnu_nat_target::store_registers): Update.
13655         * target-debug.h (target_debug_print_std_string): New macro.
13656         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13657         * windows-tdep.c (display_one_tib): Update.
13658         * tui/tui-stack.c (tui_make_status_line): Update.
13659         * top.c (print_inferior_quit_action): Update.
13660         * thread.c (thr_try_catch_cmd): Update.
13661         (add_thread_with_info): Update.
13662         (thread_target_id_str): Update.
13663         (thr_try_catch_cmd): Update.
13664         (thread_command): Update.
13665         (thread_find_command): Update.
13666         * record-btrace.c (record_btrace_target::info_record)
13667         (record_btrace_resume_thread, record_btrace_target::resume)
13668         (record_btrace_cancel_resume, record_btrace_step_thread)
13669         (record_btrace_target::wait, record_btrace_target::wait)
13670         (record_btrace_target::wait, record_btrace_target::stop): Update.
13671         * progspace.c (print_program_space): Update.
13672         * process-stratum-target.c
13673         (process_stratum_target::thread_address_space): Update.
13674         * linux-fork.c (linux_fork_mourn_inferior)
13675         (detach_checkpoint_command, info_checkpoints_command)
13676         (linux_fork_context): Update.
13677         (linux_fork_detach): Update.
13678         (class scoped_switch_fork_info): Update.
13679         (delete_checkpoint_command): Update.
13680         * infrun.c (follow_fork_inferior): Update.
13681         (follow_fork_inferior): Update.
13682         (proceed_after_vfork_done): Update.
13683         (handle_vfork_child_exec_or_exit): Update.
13684         (follow_exec): Update.
13685         (displaced_step_prepare_throw): Update.
13686         (displaced_step_restore): Update.
13687         (start_step_over): Update.
13688         (resume_1): Update.
13689         (clear_proceed_status_thread): Update.
13690         (proceed): Update.
13691         (print_target_wait_results): Update.
13692         (do_target_wait): Update.
13693         (context_switch): Update.
13694         (stop_all_threads): Update.
13695         (restart_threads): Update.
13696         (finish_step_over): Update.
13697         (handle_signal_stop): Update.
13698         (switch_back_to_stepped_thread): Update.
13699         (keep_going_pass_signal): Update.
13700         (print_exited_reason): Update.
13701         (normal_stop): Update.
13702         * inferior.c (inferior_pid_to_str): Change return type.
13703         (print_selected_inferior): Update.
13704         (add_inferior): Update.
13705         (detach_inferior): Update.
13706         * dummy-frame.c (fprint_dummy_frames): Update.
13707         * dcache.c (dcache_info_1): Update.
13708         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13709         (btrace_fetch, btrace_clear): Update.
13710         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13711         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13712         type.
13713         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13714         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13715         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13716         * gdbarch.c, gdbarch.h: Rebuild.
13717         * gdbarch.sh (core_pid_to_str): Change return type.
13718         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13719         return type.
13720         (windows_nat_target::pid_to_str): Change return type.
13721         (windows_delete_thread): Update.
13722         (windows_nat_target::attach): Update.
13723         (windows_nat_target::files_info): Update.
13724         * target-delegates.c: Rebuild.
13725         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13726         return type.
13727         (sol_thread_target::pid_to_str): Change return type.
13728         * remote.c (class remote_target) <pid_to_str>: Change return
13729         type.
13730         (remote_target::pid_to_str): Change return type.
13731         (extended_remote_target::attach, remote_target::remote_stop_ns)
13732         (remote_target::remote_notif_remove_queued_reply)
13733         (remote_target::push_stop_reply, remote_target::disable_btrace):
13734         Update.
13735         (extended_remote_target::attach): Update.
13736         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13737         type.
13738         (gdbsim_target::pid_to_str): Change return type.
13739         * ravenscar-thread.c (struct ravenscar_thread_target)
13740         <pid_to_str>: Change return type.
13741         (ravenscar_thread_target::pid_to_str): Change return type.
13742         * procfs.c (class procfs_target) <pid_to_str>: Change return
13743         type.
13744         (procfs_target::pid_to_str): Change return type.
13745         (procfs_target::attach): Update.
13746         (procfs_target::detach): Update.
13747         (procfs_target::fetch_registers): Update.
13748         (procfs_target::store_registers): Update.
13749         (procfs_target::wait): Update.
13750         (procfs_target::files_info): Update.
13751         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13752         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13753         return type.
13754         (nto_procfs_target::pid_to_str): Change return type.
13755         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13756         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13757         return type.
13758         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13759         (exit_lwp): Update.
13760         (attach_proc_task_lwp_callback, get_detach_signal)
13761         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13762         (linux_nat_target::resume, wait_lwp, stop_callback)
13763         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13764         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13765         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13766         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13767         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13768         type.
13769         (inf_ptrace_target::attach): Update.
13770         (inf_ptrace_target::files_info): Update.
13771         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13772         type.
13773         (go32_nat_target::pid_to_str): Change return type.
13774         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13775         (gnu_nat_target::wait): Update.
13776         (gnu_nat_target::wait): Update.
13777         (gnu_nat_target::resume): Update.
13778         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13779         (fbsd_nat_target::wait): Update.
13780         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13781         type.
13782         (darwin_nat_target::attach): Update.
13783         * corelow.c (class core_target) <pid_to_str>: Change return type.
13784         (core_target::pid_to_str): Change return type.
13785         * target.c (normal_pid_to_str): Change return type.
13786         (default_pid_to_str): Likewise.
13787         (target_pid_to_str): Change return type.
13788         (target_translate_tls_address): Update.
13789         (target_announce_detach): Update.
13790         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13791         return type.
13792         (bsd_uthread_target::pid_to_str): Change return type.
13793         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13794         type.
13795         (bsd_kvm_target::pid_to_str): Change return type.
13796         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13797         return type.
13798         (aix_thread_target::pid_to_str): Change return type.
13799         * target.h (struct target_ops) <pid_to_str>: Change return type.
13800         (target_pid_to_str, normal_pid_to_str): Likewise.
13801         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13802         type.
13803         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13804         type.
13805         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13806         return type.
13807         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13808         type.
13809         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13810         type.
13811         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13812         return type.
13813
13814 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13815
13816         * NEWS: Mention that the new default MI version is 3.  Mention
13817         changes to the output of commands and events that deal with
13818         multi-location breakpoints.
13819         * breakpoint.c: Include "mi/mi-out.h".
13820         (print_one_breakpoint): Change output syntax if using MI version
13821         >= 3.
13822         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13823         New.
13824         (mi_multi_location_breakpoint_output_fixed): New.
13825         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13826         (mi_cmd_fix_multi_location_breakpoint_output): New.
13827         (mi_multi_location_breakpoint_output_fixed): New.
13828         * mi/mi-cmds.c (mi_cmds): Register command
13829         -fix-multi-location-breakpoint-output.
13830         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13831         interpreter "mi".
13832
13833 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13834
13835         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13836         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13837         instantiate mi_ui_out based on interpreter name.
13838         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13839         * mi/mi-main.c (mi_load_progress): Likewise.
13840
13841 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13842
13843         * NEWS: Combine separate "New targets" sections for 8.3.
13844
13845 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13846
13847         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13848         (ppcfbsd_init_abi): Install gdbarch
13849         "fetch_tls_load_module_address" and "get_thread_local_address"
13850         methods.
13851
13852 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13853
13854         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13855         (riscv_fbsd_init_abi): Install gdbarch
13856         "fetch_tls_load_module_address" and "get_thread_local_address"
13857         methods.
13858
13859 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13860
13861         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13862         (i386fbsd_init_abi): Install gdbarch
13863         "fetch_tls_load_module_address" and "get_thread_local_address"
13864         methods.
13865
13866 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13867
13868         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13869         (amd64fbsd_init_abi): Install gdbarch
13870         "fetch_tls_load_module_address" and "get_thread_local_address"
13871         methods.
13872
13873 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13874
13875         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13876         (struct fbsd_pspace_data): New type.
13877         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13878         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13879         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13880         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13881         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13882
13883 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13884
13885         * gdbtypes.c (lookup_struct_elt): New function.
13886         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13887         * gdbtypes.h (struct struct_elt): New type.
13888         (lookup_struct_elt): New prototype.
13889
13890 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13891
13892         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13893         remove disabled code block.
13894
13895 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13896
13897         * gdbarch.sh (get_thread_local_address): New method.
13898         * gdbarch.h, gdbarch.c: Regenerate.
13899         * target.c (target_translate_tls_address): Use
13900         gdbarch_get_thread_local_address if present instead of
13901         target::get_thread_local_address.
13902
13903 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13904
13905         * target.h (target::get_thread_local_address): Update comment.
13906
13907 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13908
13909         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13910         objfile->separate_debug_objfile_backlink if not NULL.
13911
13912 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13913
13914         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13915         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13916         (amd64bsd_store_inferior_registers): Likewise.
13917         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13918         Enable segment base registers.
13919         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13920         PT_GETFSBASE and PT_GETGSBASE.
13921         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13922         PT_SETGSBASE.
13923         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13924         segment base registers.
13925         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13926
13927 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13928
13929         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13930         Update calls to i386_target_description to add 'segments'
13931         parameter.
13932         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13933         add segment base registers.
13934         * arch/i386.c (i386_create_target_description): Add 'segments'
13935         parameter to enable segment base registers.
13936         * arch/i386.h (i386_create_target_description): Likewise.
13937         * features/i386/32bit-segments.xml: New file.
13938         * features/i386/32bit-segments.c: Generate.
13939         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13940         call to i386_target_description to add 'segments' parameter.
13941         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13942         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13943         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13944         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13945         if feature is present.
13946         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13947         Add 'segments' parameter to call to i386_target_description.
13948         (i386_target_description): Add 'segments' parameter to enable
13949         segment base registers.
13950         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13951         to call to i386_target_description.
13952         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13953         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13954         Define I386_NUM_REGS.
13955         (i386_target_description): Add 'segments' parameter to enable
13956         segment base registers.
13957
13958 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13959
13960         PR/24325
13961         * source-cache.c: #undef open and close, to avoid unresolved
13962         externals during linking.
13963
13964 2019-03-12  Tom Tromey  <tromey@adacore.com>
13965
13966         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13967         const.  Add initializers.
13968         (_initialize_remote): Don't initialize ptid globals.
13969
13970 2019-03-12  Pedro Alves  <palves@redhat.com>
13971
13972         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13973
13974 2019-03-12  Pedro Alves  <palves@redhat.com>
13975
13976         * cp-name-parser.y (main): Remove unused 'len' variable.
13977
13978 2019-03-12  Tom Tromey  <tromey@adacore.com>
13979
13980         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13981         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13982
13983 2019-03-12  Tom Tromey  <tromey@adacore.com>
13984
13985         * linux-nat.c (iterate_over_lwps): Update.
13986         (stop_callback): Remove parameter.
13987         (stop_wait_callback, detach_callback, resume_set_callback)
13988         (select_singlestep_lwp_callback, set_ignore_sigint)
13989         (status_callback, resumed_callback, resume_clear_callback)
13990         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13991         data parameter.
13992         (linux_nat_target::detach, linux_nat_target::resume)
13993         (linux_stop_and_wait_all_lwps, select_event_lwp)
13994         (linux_nat_filter_event, linux_nat_wait_1)
13995         (linux_nat_target::kill, linux_nat_target::stop)
13996         (linux_nat_target::stop): Update.
13997         (linux_nat_resume_callback): Change type.
13998         (resume_stopped_resumed_lwps, count_events_callback)
13999         (select_event_lwp_callback): Likewise.
14000         (linux_stop_lwp, linux_nat_stop_lwp): Update.
14001         * arm-linux-nat.c (struct update_registers_data): Remove.
14002         (update_registers_callback): Change type.
14003         (arm_linux_insert_hw_breakpoint1): Update.
14004         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
14005         parameter.
14006         (x86_linux_dr_set_addr): Update.
14007         (x86_linux_dr_set_control): Update.
14008         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
14009         (iterate_over_lwps): Use gdb::function_view.
14010         * nat/aarch64-linux-hw-point.c (struct
14011         aarch64_dr_update_callback_param): Remove.
14012         (debug_reg_change_callback): Change type.
14013         (aarch64_notify_debug_reg_change): Update.
14014         * s390-linux-nat.c (s390_refresh_per_info): Update.
14015
14016 2019-03-11  Tom Tromey  <tromey@adacore.com>
14017
14018         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
14019         redundant assignment to "this_cu".
14020
14021 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14022
14023         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
14024
14025 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14026
14027         * gdbtypes.c (rank_one_type_parm_set): New function extracted
14028         from...
14029         (rank_one_type): ... this.
14030
14031 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14032
14033         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
14034         from...
14035         (rank_one_type): ... this.
14036
14037 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14038
14039         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
14040         from...
14041         (rank_one_type): ... this.
14042
14043 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14044
14045         * gdbtypes.c (rank_one_type_parm_float): New function extracted
14046         from...
14047         (rank_one_type): ... this.
14048
14049 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14050
14051         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
14052         from...
14053         (rank_one_type): ... this.
14054
14055 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14056
14057         * gdbtypes.c (rank_one_type_parm_range): New function extracted
14058         from...
14059         (rank_one_type): ... this.
14060
14061 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14062
14063         * gdbtypes.c (rank_one_type_parm_char): New function extracted
14064         from...
14065         (rank_one_type): ... this.
14066
14067 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14068
14069         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
14070         from...
14071         (rank_one_type): ... this.
14072
14073 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14074
14075         * gdbtypes.c (rank_one_type_parm_int): New function extracted
14076         from...
14077         (rank_one_type): ... this.
14078
14079 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14080
14081         * gdbtypes.c (rank_one_type_parm_func): New function extracted
14082         from...
14083         (rank_one_type): ... this.
14084
14085 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14086
14087         * gdbtypes.c (rank_one_type_parm_array): New function extracted
14088         from...
14089         (rank_one_type): ... this.
14090
14091 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14092
14093         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14094         from...
14095         (rank_one_type): ... this.
14096
14097 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14098
14099         * inferior.c (initialize_inferiors): Ensure 'help set/show print
14100         inferior-events' shows the example events.
14101
14102 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
14103
14104         Support styling on native MS-Windows console
14105
14106         PR/24315
14107         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14108         on MS-Windows if $TERM is not defined.
14109
14110         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14111
14112         * posix-hdep.c (gdb_console_fputs):
14113         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14114         functions.
14115         * ui-file.h (gdb_console_fputs): Add prototype.
14116
14117         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14118         back to fputs only if the former returns zero.
14119
14120 2019-03-07  Tom Tromey  <tom@tromey.com>
14121
14122         * symmisc.c (print_symbol_bcache_statistics): Update.
14123         (print_objfile_statistics): Update.
14124         * symfile.c (allocate_symtab): Update.
14125         * stabsread.c: Don't include bcache.h.
14126         * psymtab.h (struct psymbol_bcache): Don't declare.
14127         (class psymtab_storage) <psymbol_cache>: Now a bcache.
14128         (psymbol_bcache_init, psymbol_bcache_free)
14129         (psymbol_bcache_get_bcache): Don't declare.
14130         * psymtab.c (struct psymbol_bcache): Remove.
14131         (psymtab_storage::psymtab_storage): Update.
14132         (psymtab_storage::~psymtab_storage): Update.
14133         (psymbol_bcache_init, psymbol_bcache_free)
14134         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14135         (add_psymbol_to_bcache): Update.
14136         (allocate_psymtab): Update.
14137         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14138         macro_cache>: No longer pointers.
14139         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14140         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14141         * macrotab.c (macro_bcache): Update.
14142         * macroexp.c: Don't include bcache.h.
14143         * gdbtypes.c (check_types_worklist): Update.
14144         (types_deeply_equal): Remove TRY/CATCH.  Update.
14145         * elfread.c (elf_symtab_read): Update.
14146         * dwarf2read.c: Don't include bcache.h.
14147         * buildsym.c (buildsym_compunit::get_macro_table): Update.
14148         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14149         (print_bcache_statistics, bcache_memory_used): Don't declare.
14150         (struct bcache): Move from bcache.c.  Add constructor, destructor,
14151         methods.  Rename all data members.
14152         * bcache.c (struct bcache): Move to bcache.h.
14153         (bcache::expand_hash_table): Rename from expand_hash_table.
14154         (bcache): Remove.
14155         (bcache::insert): Rename from bcache_full.
14156         (bcache::compare): Rename from bcache_compare.
14157         (bcache_xmalloc): Remove.
14158         (bcache::~bcache): Rename from bcache_xfree.
14159         (bcache::print_statistics): Rename from print_bcache_statistics.
14160         (bcache::memory_used): Rename from bcache_memory_used.
14161
14162 2019-03-07  Pedro Alves  <palves@redhat.com>
14163
14164         * infrun.c (normal_stop): Also check for
14165         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14166
14167 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
14168
14169         * f-lang.c (value_from_host_double): Moved to...
14170         * value.c (value_from_host_double): ...here.
14171         * value.h (value_from_host_double): Declare.
14172         * guile/scm-math.c (vlscm_convert_typed_number): Use
14173         value_from_host_double.
14174         (vlscm_convert_number): Likewise.
14175         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14176         * python/py-value.c (convert_value_from_python): Likewise.
14177
14178 2019-03-06  Tom Tromey  <tom@tromey.com>
14179
14180         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14181
14182 2019-03-06  Tom Tromey  <tom@tromey.com>
14183
14184         * utils.h (free_current_contents): Don't declare.
14185         * utils.c (free_current_contents): Remove.
14186
14187 2019-03-06  Tom Tromey  <tom@tromey.com>
14188
14189         * top.c (quit_force): Update.
14190         * main.c (captured_command_loop): Update.
14191         * common/new-op.c (operator new): Update.
14192         * common/common-exceptions.c (struct catcher)
14193         <save_cleanup_chain>: Remove member.
14194         (exceptions_state_mc_init): Update.
14195         (exception_try_scope_entry): Return nullptr.
14196         (exception_try_scope_exit, exception_rethrow)
14197         (throw_exception_sjlj, throw_exception_cxx): Update.
14198         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14199         (all_cleanups, do_cleanups, discard_cleanups)
14200         (discard_final_cleanups, save_cleanups, save_final_cleanups)
14201         (restore_cleanups, restore_final_cleanups): Don't declare.
14202         (do_final_cleanups): Remove parameter.
14203         * common/cleanups.c (cleanup_chain, make_cleanup)
14204         (make_cleanup_dtor, all_cleanups, do_cleanups)
14205         (discard_my_cleanups, discard_cleanups)
14206         (discard_final_cleanups, save_my_cleanups, save_cleanups)
14207         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14208         (null_cleanup): Remove.
14209         (do_final_cleanups): Remove parameter.
14210
14211 2019-03-06  Tom Tromey  <tom@tromey.com>
14212
14213         * remote.c (remote_target::remote_parse_stop_reply): Use
14214         unique_xmalloc_ptr.
14215
14216 2019-03-06  Tom Tromey  <tom@tromey.com>
14217
14218         * stabsread.c (struct stabs_field_info): Rename from field_info.
14219         <list, fnlist>: Add initializers.
14220         <obstack>: New member.
14221         (read_member_functions, read_struct_fields, read_baseclasses):
14222         Allocate on obstack.  Don't use cleanups.
14223         (read_one_struct_field, read_member_functions, read_struct_fields)
14224         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14225         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14226         (read_struct_type): Update.
14227
14228 2019-03-06  Tom Tromey  <tom@tromey.com>
14229
14230         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14231         * common/filestuff.h (make_cleanup_close): Don't declare.
14232         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14233         Remove.
14234
14235 2019-03-06  Tom Tromey  <tom@tromey.com>
14236
14237         * solib-aix.c: Use make_scope_exit.
14238
14239 2019-03-06  Tom Tromey  <tom@tromey.com>
14240
14241         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14242         Use make_scope_exit.
14243
14244 2019-03-06  Tom Tromey  <tom@tromey.com>
14245
14246         * solib-svr4.c (disable_probes_interface): Remove parameter.
14247         (svr4_handle_solib_event): Use make_scope_exit.
14248
14249 2019-03-06  Tom Tromey  <tom@tromey.com>
14250
14251         * remote.c (struct stop_reply_deleter): Remove.
14252         (stop_reply_up): Update.
14253         (struct stop_reply): Derive from notif_event.  Don't typedef.
14254         <regcache>: Now a std::vector.
14255         (stop_reply_xfree): Remove.
14256         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14257         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14258         (remote_target::discard_pending_stop_replies): Use delete.
14259         (remote_target::remote_parse_stop_reply): Update.
14260         (remote_target::process_stop_reply): Update.
14261         * remote-notif.h (struct notif_event): Add virtual destructor.
14262         Remove "dtr" member.
14263         (struct notif_client) <alloc_event>: Return a unique_ptr.
14264         (notif_event_xfree): Don't declare.
14265         (notif_event_up): New typedef.
14266         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14267         (notif_event_xfree, do_notif_event_xfree): Remove.
14268         (remote_notif_state_xfree): Update.
14269
14270 2019-03-06  Tom Tromey  <tom@tromey.com>
14271
14272         * infrun.c (displaced_step_clear_cleanup): Now a
14273         forward_scope_exit type.
14274         (displaced_step_prepare_throw): Update.
14275         (displaced_step_fixup): Update.
14276
14277 2019-03-06  Tom Tromey  <tom@tromey.com>
14278
14279         * inferior.h (class inferior): Update comment.
14280         * gdbthread.h (class thread_info): Update comment.
14281
14282 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14283             Tom Tromey  <tom@tromey.com>
14284
14285         * stabsread.h (struct stab_section_list): Remove.
14286         (coffstab_build_psymtabs): Update.
14287         * dbxread.c (symbuf_sections): Now a std::vector.
14288         (sect_idx): New global.
14289         (fill_symbuf): Update.
14290         (coffstab_build_psymtabs): Change type of stabsects parameter.
14291         Update.
14292         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14293         std::vector.
14294         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14295         (coff_locate_sections): Update.
14296         (coff_symfile_read): Remove cleanups.  Update.
14297         (init_stringtab): Add storage parameter.
14298         (free_stringtab, free_stringtab_cleanup): Remove.
14299         (init_lineno): Add storage parameter.
14300         (free_linetab, free_linetab_cleanup): Remove.
14301
14302 2019-03-06  Pedro Alves  <palves@redhat.com>
14303
14304         * linux-fork.c (fork_info::clobber_regs): Delete.
14305         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14306         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14307         comment.  Adjust.
14308         (scoped_switch_fork_info::scoped_switch_fork_info)
14309         (checkpoint_command, linux_fork_context): Adjust
14310         fork_save_infrun_state calls.
14311
14312 2019-03-06  Pedro Alves  <palves@redhat.com>
14313
14314         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14315         (inf_has_multiple_threads): Return 'bool' and rewrite using
14316         inferior_info::threads().
14317
14318 2019-03-06  Pedro Alves  <palves@redhat.com>
14319
14320         * linux-fork.c: Include <list>.
14321         (fork_list): Now a std::list instance.
14322         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14323         (forks_exist_p, find_last_fork): Adjust.
14324         (new_fork): Delete.
14325         (one_fork_p): New.
14326         (add_fork): Adjust.
14327         (free_fork): Delete, folded into fork_info::~fork_info().
14328         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14329         Adjust.
14330         (init_fork_list): Delete.
14331         (linux_fork_killall, linux_fork_mourn_inferior)
14332         (linux_fork_detach, info_checkpoints_command): Adjust.
14333         (_initialize_linux_fork): No longer call init_fork_list.
14334
14335 2019-03-06  Pedro Alves  <palves@redhat.com>
14336
14337         * linux-fork.c (new_fork): New, split out of ...
14338         (add_fork): ... this.  Return void.  Move "first fork" special
14339         case from here, to ...
14340         (checkpoint_command): ... here.
14341         * linux-linux.h (add_fork): Return void.
14342
14343 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14344
14345         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14346
14347 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14348             Chris January  <chris.january@arm.com>
14349             David Lecomber  <david.lecomber@arm.com>
14350
14351         * f-exp.y: New token, UNOP_INTRINSIC.
14352         (exp): New pattern using UNOP_INTRINSIC token.
14353         (f77_keywords): Add 'abs' keyword.
14354         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14355         (value_from_host_double): New function.
14356         (evaluate_subexp_f): Support UNOP_ABS.
14357
14358 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14359
14360         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14361         types.
14362
14363 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14364
14365         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14366         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14367         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14368
14369 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14370
14371         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14372
14373 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14374             Chris January  <chris.january@arm.com>
14375
14376         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14377         * f-exp.y: Define 'KIND' token.
14378         (exp): New pattern for KIND expressions.
14379         (ptype): Handle types with a kind extension.
14380         (direct_abs_decl): Extend to spot kind extensions.
14381         (f77_keywords): Add 'kind' to the list.
14382         (push_kind_type): New function.
14383         (convert_to_kind_type): New function.
14384         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14385         * parse.c (operator_length_standard): Likewise.
14386         * parser-defs.h (enum type_pieces): Add tp_kind.
14387         * std-operator.def: Add UNOP_KIND.
14388
14389 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14390
14391         * f-exp.y (f_parse): Set yydebug.
14392
14393 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14394
14395         * f-lang.c (evaluate_subexp_f): New function.
14396         (exp_descriptor_f): New global.
14397         (f_language_defn): Use exp_descriptor_f instead of
14398         exp_descriptor_standard.
14399
14400 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14401
14402         * f-exp.y (struct token): Add comments.
14403         (dot_ops): Remove uppercase versions and the end marker.
14404         (f77_keywords): Likewise.
14405         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14406         entries in the dot_ops array are case insensitive, and use
14407         strncasecmp to compare strings.  Also some whitespace cleanup in
14408         this area.  Similar for the f77_keywords array, except entries in
14409         this list might be case sensitive.
14410
14411 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14412
14413         * f-exp.y (struct f77_boolean_val): Add comments.
14414         (boolean_values): Remove uppercase versions, and end marker.
14415         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14416         and use strncasecmp to achieve case insensitivity.  Additionally,
14417         perform whitespace cleanup around this code.
14418
14419 2019-03-06  Tom Tromey  <tromey@adacore.com>
14420
14421         * remote-sim.c (gdbsim_target_open): Use result of
14422         gdb_argv::release.
14423
14424 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14425         Dirk Schubert  <dirk.schubert@arm.com>
14426         Chris January  <chris.january@arm.com>
14427
14428         * eval.c (evaluate_subexp_standard): Call Fortran argument
14429         wrapping logic.
14430         * f-lang.c (struct value): A value which can be passed into a
14431         Fortran function call.
14432         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14433         where appropriate.
14434         (struct type): Value ready for a Fortran function call.
14435         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14436         is needed.
14437         * f-lang.h (fortran_argument_convert): Declaration.
14438         (fortran_preserve_arg_pointer): Declaration.
14439         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14440
14441 2019-03-05  Tom Tromey  <tromey@adacore.com>
14442
14443         * python/py-prettyprint.c (print_string_repr): Remove #if.
14444         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14445
14446 2019-03-05  Tom Tromey  <tromey@adacore.com>
14447
14448         * target.c (the_dummy_target): Move later.  Change type to
14449         "dummy_target".
14450         (initialize_targets): Don't initialize the_dummy_target.
14451
14452 2019-03-05  Tom Tromey  <tromey@adacore.com>
14453
14454         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14455         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14456
14457 2019-03-05  Tom Tromey  <tromey@adacore.com>
14458
14459         * windows-nat.c (windows_nat_target::attach)
14460         (windows_nat_target::detach): Don't call gdb_flush.
14461         * valprint.c (generic_val_print, val_print, val_print_string):
14462         Don't call gdb_flush.
14463         * utils.c (defaulted_query): Don't call gdb_flush.
14464         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14465         * target.c (target_announce_detach): Don't call gdb_flush.
14466         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14467         * remote.c (extended_remote_target::attach): Don't call
14468         gdb_flush.
14469         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14470         * printcmd.c (do_examine): Don't call gdb_flush.
14471         (info_display_command): Don't call gdb_flush.
14472         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14473         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14474         * memattr.c (info_mem_command): Don't call gdb_flush.
14475         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14476         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14477         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14478         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14479         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14480         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14481         (gnu_nat_target::detach): Don't call gdb_flush.
14482         * f-valprint.c (f_val_print): Don't call gdb_flush.
14483         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14484         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14485         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14486         gdb_flush.
14487         * c-valprint.c (c_val_print): Don't call gdb_flush.
14488         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14489
14490 2019-03-05  Tom Tromey  <tromey@adacore.com>
14491
14492         * varobj.c (update_dynamic_varobj_children): Update.
14493         (install_default_visualizer): Use reset, not release.
14494         * value.c (set_internalvar): Update.
14495         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14496         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14497         ATTRIBUTE_UNUSED_RESULT.
14498
14499 2019-03-05  Tom Tromey  <tromey@adacore.com>
14500
14501         * remote.c (class scoped_remote_fd) <release>: Add
14502         ATTRIBUTE_UNUSED_RESULT.
14503
14504 2019-03-05  Tom Tromey  <tromey@adacore.com>
14505
14506         * macroexp.c (struct macro_buffer) <release>: Add
14507         ATTRIBUTE_UNUSED_RESULT.
14508
14509 2019-03-05  Tom Tromey  <tromey@adacore.com>
14510
14511         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14512         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14513         ATTRIBUTE_UNUSED_RESULT.
14514
14515 2019-03-05  Tom Tromey  <tromey@adacore.com>
14516
14517         * common/scoped_fd.h (class scoped_fd) <release>: Add
14518         ATTRIBUTE_UNUSED_RESULT.
14519
14520 2019-03-05  Tom Tromey  <tromey@adacore.com>
14521
14522         * parser-defs.h (struct parser_state) <release>: Add
14523         ATTRIBUTE_UNUSED_RESULT.
14524
14525 2019-03-05  Tom Tromey  <tromey@adacore.com>
14526
14527         * utils.h (class gdb_argv) <release>: Add
14528         ATTRIBUTE_UNUSED_RESULT.
14529         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14530
14531 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14532
14533         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14534         for-loop range, to avoid compiler warnings.
14535
14536         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14537         avoid compiler warnings about unused variables.
14538
14539         * NEWS: Mention end of support for native debugging on MS-Windows
14540         before XP.
14541
14542         PR gdb/24292
14543         * common/netstuff.c:
14544         * gdbserver/gdbreplay.c
14545         * gdbserver/remote-utils.c:
14546         * ser-tcp.c:
14547         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14548         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14549         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14550         'getaddrinfo' and 'freeaddrinfo' were not available before
14551         Windows XP, and mingw.org's MinGW headers by default define
14552         _WIN32_WINNT to 0x500.
14553
14554 2019-03-01  Gary Benson <gbenson@redhat.com>
14555
14556         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14557
14558 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14559             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14560
14561         PR gdb/8527
14562         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14563         set_sigint_trap, clear_sigint_trap.
14564
14565 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14566
14567         * target.c (target_detach): Clear the regcache and the
14568         frame cache.
14569
14570 2019-02-27  Pedro Alves  <palves@redhat.com>
14571
14572         * utils.c (set_screen_size): When we cap the height/width sizes,
14573         tweak the corresponding command variable to show "unlimited":
14574
14575 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14576             Pedro Alves  <palves@redhat.com>
14577
14578         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14579         before calling rl_set_screen_size.
14580
14581 2019-02-27  Tom Tromey  <tromey@adacore.com>
14582
14583         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14584         define.
14585         * python/py-value.c: Remove Python 2.4 workaround.
14586         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14587         workaround.
14588         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14589         Python 2.4 workaround.
14590         * python/python-internal.h: Remove Python 2.4 comment.
14591         (Py_ssize_t): Don't define.
14592         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14593         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14594         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14595         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14596         * python/python.c (do_start_initialization): Remove Python 2.4
14597         workaround.
14598         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14599         (print_children): Remove Python 2.4 workaround.
14600         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14601         workaround.
14602         (CHARBUFFERPROC_NAME): Remove.
14603         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14604         Python 2.4 workaround.
14605
14606 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14607
14608         * NEWS: Note minimum Python version.
14609
14610 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14611
14612         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14613         code from these functions.  Remove corresponding ifdefs.  Use
14614         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14615         Remove gotos and target of gotos.
14616         (infpy_search_memory): Likewise.
14617
14618 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14619
14620         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14621         (hppa_gdbarch_init): Don't register deleted functions with
14622         gdbarch.
14623
14624 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14625
14626         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14627         (h8300_unwind_sp): Delete.
14628         (h8300_dummy_id): Delete.
14629         (h8300_gdbarch_init): Don't register deleted functions with
14630         gdbarch.
14631
14632 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14633
14634         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14635         (ft32_unwind_pc): Delete.
14636         (ft32_unwind_sp): Delete.
14637         (ft32_gdbarch_init): Don't register deleted functions with
14638         gdbarch.
14639
14640 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14641
14642         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14643         (frv_unwind_pc): Delete.
14644         (frv_unwind_sp): Delete.
14645         (frv_gdbarch_init): Don't register deleted functions with
14646         gdbarch.
14647
14648 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14649
14650         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14651         (riscv_unwind_pc): Delete.
14652         (riscv_unwind_sp): Delete.
14653         (riscv_gdbarch_init): Don't register deleted functions with
14654         gdbarch.
14655
14656 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14657
14658         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14659         (csky_unwind_pc): Delete.
14660         (csky_unwind_sp): Delete.
14661         (csky_gdbarch_init): Don't register deleted functions with
14662         gdbarch.
14663
14664 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14665
14666         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14667         (cris_unwind_pc): Delete.
14668         (cris_unwind_sp): Delete.
14669         (cris_gdbarch_init): Don't register deleted functions with
14670         gdbarch.
14671
14672 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14673
14674         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14675         (bfin_unwind_pc): Delete.
14676         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14677
14678 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14679
14680         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14681         (arm_unwind_pc): Delete.
14682         (arm_unwind_sp): Delete.
14683         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14684
14685 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14686
14687         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14688         (arc_unwind_pc): Delete.
14689         (arc_unwind_sp): Delete.
14690         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14691
14692 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14693
14694         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14695         (alpha_unwind_pc): Delete.
14696         (alpha_gdbarch_init): Don't register deleted functions with
14697         gdbarch.
14698
14699 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14700
14701         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14702         (aarch64_unwind_pc): Delete.
14703         (aarch64_unwind_sp): Delete.
14704         (aarch64_gdbarch_init): Don't register deleted functions with
14705         gdbarch.
14706
14707 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14708
14709         * gdbtypes.c (type_align): Don't consider static members when
14710         computing structure alignment.
14711
14712 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14713
14714         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14715         return 0 for other types.
14716         * arch-utils.c (default_type_align): Always return 0.
14717         * gdbarch.h: Regenerate.
14718         * gdbarch.sh (type_align): Extend comment.
14719         * gdbtypes.c (type_align): Add additional comments, always call
14720         gdbarch_type_align before applying the default rules.
14721         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14722         generic code will then apply a suitable default.
14723         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14724         types, return 0 for other types.
14725
14726 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14727
14728         * NEWS: Create a new section for the next release branch.
14729         Rename the section of the current branch, now that it has
14730         been cut.
14731
14732 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14733
14734         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14735         * version.in: Bump version to 8.3.50.DATE-git.
14736
14737 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14738
14739         * aix-thread.c (ptid_cmp): Remove unused variable.
14740         (get_signaled_thread): Likewise.
14741         (store_regs_user_thread): Likewise.
14742         (store_regs_kernel_thread): Likewise.
14743         (fetch_regs_kernel_thread): Remove shadowed variable.
14744
14745 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14746
14747         * features/riscv/32bit-cpu.xml: Add register numbers.
14748         * features/riscv/32bit-fpu.c: Regenerate.
14749         * features/riscv/32bit-fpu.xml: Add register numbers.
14750         * features/riscv/64bit-cpu.xml: Add register numbers.
14751         * features/riscv/64bit-fpu.c: Regenerate.
14752         * features/riscv/64bit-fpu.xml: Add register numbers.
14753
14754 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14755
14756         * NEWS: Mention two argument form of gdb.Value constructor.
14757         * python/py-value.c (convert_buffer_and_type_to_value): New
14758         function.
14759         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14760         Add support for handling an optional second argument.  Call
14761         convert_buffer_and_type_to_value as appropriate.
14762         * python/python-internal.h (Py_buffer_deleter): New struct.
14763         (Py_buffer_up): New typedef.
14764
14765 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14766
14767         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14768         instead of releasing ownership.
14769
14770 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14771
14772         * dwarf2read.c (open_and_init_dwp_file): Call
14773         elf_numsections instead of bfd_count_sections to initialize
14774         dwp_file->num_sections.
14775
14776 2019-02-25  Tom Tromey  <tromey@adacore.com>
14777
14778         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14779
14780 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14781
14782         * gcore.in: Add '--readnever' option when invoking GDB.
14783
14784 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14785
14786         * MAINTAINERS: Update my email address.
14787
14788 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14789
14790         * build-id.c (build_id_to_debug_bfd_1): New function.
14791         (build_id_to_debug_bfd): Look for separate debug file in
14792         sysroot.
14793
14794 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14795
14796         * gdbarch.sh: Update the copyright year range that is placed into
14797         generated files.
14798
14799 2019-02-22  Keith Seitz  <keiths@redhat.com>
14800
14801         PR symtab/23853
14802         * linespec.c (create_sals_line_offset): Search for the default
14803         symtab's filename instead of its fullname.
14804
14805 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14806
14807         * NEWS: Update style defaults.
14808
14809 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14810
14811         * main.c (captured_main_1): Disable styling in batch mode.
14812
14813 2019-02-20  Tom Tromey  <tom@tromey.com>
14814
14815         * symtab.c (symtab_symbol_info): Fix typos.
14816
14817 2019-02-20  Tom Tromey  <tromey@adacore.com>
14818
14819         * findcmd.c (_initialize_mem_search): Use upper case for
14820         metasyntactic variables.
14821
14822 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14823
14824         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14825         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14826
14827 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14828
14829         * top.h (source_file_name): Change to std::string.
14830         * top.c (source_file_name): Likewise.
14831         (command_line_input): Adjust.
14832         * cli/cli-script.c (script_from_file): Adjust.
14833
14834 2019-02-19  Tom Tromey  <tromey@adacore.com>
14835
14836         * ravenscar-thread.c
14837         (ravenscar_thread_target::update_thread_list): Don't call
14838         ada_build_task_list.
14839         * ada-lang.h (ada_build_task_list): Don't declare.
14840         * ada-tasks.c (struct ada_tasks_inferior_data)
14841         <task_list_valid_p>: Now bool.
14842         (read_known_tasks, ada_task_list_changed)
14843         (ada_tasks_invalidate_inferior_data): Update.
14844         (read_known_tasks_array): Return bool.
14845         (read_known_tasks_list): Likewise.
14846         (read_known_tasks): Return void.
14847         (ada_build_task_list): Now static.
14848
14849 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14850
14851         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14852         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14853
14854 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14855
14856         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14857         variant for ada_tasks_pspace_data_handle and
14858         ada_tasks_inferior_data_handle.
14859         (ada_tasks_pspace_data_cleanup): New function.
14860         (ada_tasks_inferior_data_cleanup): New function.
14861
14862 2019-02-17  Tom Tromey  <tom@tromey.com>
14863
14864         * macrotab.h (macro_source_fullname): Return a std::string.
14865         * macrotab.c (macro_include, check_for_redefinition)
14866         (macro_undef, macro_lookup_definition, foreach_macro)
14867         (foreach_macro_in_scope): Update.
14868         (macro_source_fullname): Return a std::string.
14869         * macrocmd.c (show_pp_source_pos): Update.
14870
14871 2019-02-17  Tom Tromey  <tom@tromey.com>
14872
14873         * macrocmd.c (show_pp_source_pos): Style the file names.
14874
14875 2019-02-17  Tom Tromey  <tom@tromey.com>
14876
14877         PR tui/24197:
14878         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14879
14880 2019-02-17  Tom Tromey  <tom@tromey.com>
14881
14882         * ada-lang.c (user_select_syms): Use filtered printing.
14883         * utils.c (wrap_style): New global.
14884         (desired_style): Remove.
14885         (emit_style_escape): Add stream parameter.
14886         (set_output_style, reset_terminal_style, prompt_for_continue):
14887         Update.
14888         (flush_wrap_buffer): Only flush gdb_stdout.
14889         (wrap_here): Set wrap_style.
14890         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14891         treat escape sequences as a character.  Change when wrap buffer is
14892         flushed.
14893         (fputs_styled): Do not set the output style when the default is
14894         requested.
14895         * ui-style.h (struct ui_file_style) <is_default>: New method.
14896         * source.c (print_source_lines_base): Emit escape sequences in one
14897         piece.
14898
14899 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14900
14901         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14902         integers and enumeration types.
14903
14904 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14905
14906         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14907         instead of lookup_symbol_in_language
14908         (do_exact_match): New function.
14909         (ada_get_symbol_name_matcher): Return do_exact_match when
14910         doing a verbatim match.
14911
14912 2019-02-15  Tom Tromey  <tromey@adacore.com>
14913
14914         * ravenscar-thread.c (ravenscar_thread_target::resume)
14915         (ravenscar_thread_target::wait): Special case wildcard requests.
14916
14917 2019-02-15  Tom Tromey  <tromey@adacore.com>
14918
14919         * ravenscar-thread.c (base_ptid): Remove.
14920         (struct ravenscar_thread_target) <close>: New method.
14921         <m_base_ptid>: New member.
14922         <update_inferior_ptid, active_task, task_is_currently_active,
14923         runtime_initialized>: Declare methods.
14924         <ravenscar_thread_target>: Add constructor.
14925         (ravenscar_thread_target::task_is_currently_active)
14926         (ravenscar_thread_target::update_inferior_ptid)
14927         (ravenscar_runtime_initialized): Rename.  Now methods.
14928         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14929         (ravenscar_thread_target::update_thread_list): Update.
14930         (ravenscar_thread_target::active_task): Now method.
14931         (ravenscar_thread_target::store_registers)
14932         (ravenscar_thread_target::prepare_to_store)
14933         (ravenscar_thread_target::prepare_to_store)
14934         (ravenscar_thread_target::mourn_inferior): Update.
14935         (ravenscar_inferior_created): Use "new" to create target.
14936         (ravenscar_thread_target::get_ada_task_ptid): Update.
14937         (_initialize_ravenscar): Don't initialize base_ptid.
14938         (ravenscar_ops): Remove global.
14939
14940 2019-02-15  Tom Tromey  <tromey@adacore.com>
14941
14942         * target.h (push_target): Declare new overload.
14943         * target.c (push_target): New overload, taking an rvalue reference.
14944         * remote.c (remote_target::open_1): Use push_target overload.
14945         * corelow.c (core_target_open): Use push_target overload.
14946
14947 2019-02-15  Tom Tromey  <tromey@adacore.com>
14948
14949         * ravenscar-thread.c (is_ravenscar_task)
14950         (ravenscar_task_is_currently_active): Return bool.
14951         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14952         (_initialize_ravenscar): Remove "(void)".
14953         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14954         Return bool.
14955
14956 2019-02-15  Tom Tromey  <tromey@adacore.com>
14957
14958         * ravenscar-thread.c (ravenscar_runtime_initializer)
14959         (has_ravenscar_runtime, get_running_thread_id)
14960         (ravenscar_thread_target::resume): Fix indentation.
14961
14962 2019-02-15  Tom Tromey  <tromey@adacore.com>
14963
14964         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14965         from ravenscar_arch_ops.
14966         (sparc_ravenscar_ops::fetch_registers)
14967         (sparc_ravenscar_ops::store_registers): Now methods.
14968         (sparc_ravenscar_prepare_to_store): Remove.
14969         (sparc_ravenscar_ops): Redefine.
14970         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14971         methods and destructor.  Remove members.
14972         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14973         (ravenscar_thread_target::store_registers)
14974         (ravenscar_thread_target::prepare_to_store): Update.
14975         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14976         Remove.
14977         (struct ppc_ravenscar_powerpc_ops): Derive from
14978         ravenscar_arch_ops.
14979         (ppc_ravenscar_powerpc_ops::fetch_registers)
14980         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14981         (ppc_ravenscar_powerpc_ops): Redefine.
14982         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14983         (ppc_ravenscar_e500_ops::fetch_registers)
14984         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14985         (ppc_ravenscar_e500_ops): Redefine.
14986         * aarch64-ravenscar-thread.c
14987         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14988         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14989         (aarch64_ravenscar_fetch_registers)
14990         (aarch64_ravenscar_store_registers): Now methods.
14991         (aarch64_ravenscar_ops): Redefine.
14992
14993 2019-02-15  Tom Tromey  <tromey@adacore.com>
14994
14995         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14996         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14997         (ravenscar_thread_target::stopped_by_watchpoint)
14998         (ravenscar_thread_target::stopped_data_address)
14999         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
15000
15001 2019-02-15  Tom Tromey  <tromey@adacore.com>
15002
15003         * ravenscar-thread.c: Fix some typos.
15004
15005 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15006             Tom Tromey  <tromey@adacore.com>
15007
15008         * ada-lang.c (ada_exception_sal): Change addr_string to a
15009         std::string.
15010         (create_ada_exception_catchpoint): Update.
15011
15012 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15013             Tom Tromey  <tromey@adacore.com>
15014
15015         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
15016         (bp_location_ops): Remove.
15017         (base_breakpoint_allocate_location): Update.
15018         (free_bp_location): Update.
15019         * ada-lang.c (class ada_catchpoint_location)
15020         <ada_catchpoint_location>: Remove ops parameter.
15021         (ada_catchpoint_location_dtor): Remove.
15022         (ada_catchpoint_location_ops): Remove.
15023         (allocate_location_exception): Update.
15024         * breakpoint.h (struct bp_location_ops): Remove.
15025         (class bp_location) <bp_location>: Remove bp_location_ops
15026         parameter.
15027         <~bp_location>: Add destructor.
15028         <ops>: Remove.
15029
15030 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
15031             Pedro Alves  <palves@redhat.com>
15032
15033         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
15034         'PATH_MAX'.
15035
15036 2019-02-14  David Michael  <fedora.dm0@gmail.com>
15037             Samuel Thibault  <samuel.thibault@gnu.org>
15038             Thomas Schwinge  <thomas@codesourcery.com>
15039
15040         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
15041         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
15042
15043 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
15044
15045         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
15046         (check_empty): Use "const char *".
15047
15048         * gnu-nat.c (gnu_nat_target::detach): Instead of
15049         'detach_inferior (pid)' call
15050         'detach_inferior (find_inferior_pid (pid))'.
15051
15052         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
15053         'nat/fork-inferior.o'.
15054         * gnu-nat.c: #include "nat/fork-inferior.h".
15055
15056         * gnu-nat.c (gnu_nat_target::detach): Instead of
15057         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
15058         * gnu-nat.h: #include "inf-child.h".
15059         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15060         'i386_gnu_nat_target::fetch_registers'.
15061         (gnu_store_registers): Rename/move to
15062         'i386_gnu_nat_target::store_registers'.
15063
15064         * config/i386/nm-i386gnu.h: Don't "#include" any files.
15065         * gnu-nat.h (mach_thread_info): New function.
15066         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
15067
15068         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
15069
15070 2019-02-14  Frederic Konrad  <konrad@adacore.com>
15071
15072         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
15073
15074 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
15075
15076         * windows-nat.c (windows_add_thread): Add new parameter
15077         "main_thread_p" with default value set to false.  Update
15078         function documentation as well as all callers.
15079         (windows_delete_thread): Likewise.
15080         (fake_create_process): Update call to windows_add_thread.
15081         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
15082         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15083         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15084         call to windows_delete_thread.
15085
15086 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
15087
15088         * MAINTAINERS: Add Andrew Burgess as global maintainer.
15089
15090 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15091
15092         * symfile.c (find_separate_debug_file): Use canonical path of
15093         sysroot with child_path instead of gdb_sysroot if it is valid.
15094
15095 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15096
15097         * symfile.c (find_separate_debug_file): Use child_path to
15098         determine if an object file is under a sysroot.
15099
15100 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15101
15102         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15103         unittests/child-path-selftests.c.
15104         * common/pathstuff.c (child_path): New function.
15105         * common/pathstuff.h (child_path): New prototype.
15106         * unittests/child-path-selftests.c: New file.
15107
15108 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15109
15110         * symfile.c (find_separate_debug_file): Look for separate debug
15111         files in debug directories under the sysroot.
15112
15113 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15114
15115         * symtab.h (struct minimal_symbol data_p): New const method.
15116         (struct minimal_symbol text_p): Likewise.
15117         * symtab.c (output_source_filename): Use file name style
15118         to print file name.
15119         (print_symbol_info): Likewise.
15120         (print_msymbol_info): Use address style to print addresses.
15121         Use function name style to print executable text symbols.
15122         (expand_symtab_containing_pc): Use data_p.
15123         (find_pc_sect_compunit_symtab): Likewise.
15124
15125 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15126
15127         * breakpoint.c (describe_other_breakpoints): Use address style
15128         to print addresses.
15129         (say_where): Likewise.
15130
15131 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15132
15133         * ada-typeprint.c (print_func_type): Print function name
15134         style to print function name.
15135         * c-typeprint.c (c_print_type_1): Likewise.
15136
15137 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
15138
15139         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15140         for execve.
15141
15142 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15143
15144         * c-exp.y (direct_abs_decl): Use emplace_back to record the
15145         type_stack.
15146
15147 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
15148
15149         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15150         TYPE_CODE_REF types.
15151
15152 2019-02-08  Jim Wilson  <jimw@sifive.com>
15153
15154         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15155         (riscv_linux_fregset): New.
15156         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15157
15158 2019-02-07  Tom Tromey  <tom@tromey.com>
15159
15160         * thread.c (thread_cancel_execution_command): Update.
15161         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15162         methods.
15163         (struct thread_fsm_ops): Remove.
15164         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15165         (thread_fsm_should_stop, thread_fsm_return_value)
15166         (thread_fsm_set_finished, thread_fsm_finished_p)
15167         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15168         Don't declare.
15169         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15170         * infrun.c (clear_proceed_status_thread)
15171         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15172         (print_stop_event): Update.
15173         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15174         Add constructor.
15175         (step_command_fsm_ops): Remove.
15176         (new_step_command_fsm): Remove.
15177         (step_1): Update.
15178         (step_command_fsm::should_stop): Rename from
15179         step_command_fsm_should_stop.
15180         (step_command_fsm::clean_up): Rename from
15181         step_command_fsm_clean_up.
15182         (step_command_fsm::do_async_reply_reason): Rename from
15183         step_command_fsm_async_reply_reason.
15184         (struct until_next_fsm): Inherit from thread_fsm.  Add
15185         constructor.
15186         (until_next_fsm_ops): Remove.
15187         (new_until_next_fsm): Remove.
15188         (until_next_fsm::should_stop): Rename from
15189         until_next_fsm_should_stop.
15190         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15191         (until_next_fsm::do_async_reply_reason): Rename from
15192         until_next_fsm_async_reply_reason.
15193         (struct finish_command_fsm): Inherit from thread_fsm.  Add
15194         constructor.  Change type of breakpoint.
15195         (finish_command_fsm_ops): Remove.
15196         (new_finish_command_fsm): Remove.
15197         (finish_command_fsm::should_stop): Rename from
15198         finish_command_fsm_should_stop.
15199         (finish_command_fsm::clean_up): Rename from
15200         finish_command_fsm_clean_up.
15201         (finish_command_fsm::return_value): Rename from
15202         finish_command_fsm_return_value.
15203         (finish_command_fsm::do_async_reply_reason): Rename from
15204         finish_command_fsm_async_reply_reason.
15205         (finish_command): Update.
15206         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15207         Add constructor.
15208         (call_thread_fsm_ops): Remove.
15209         (call_thread_fsm::call_thread_fsm): Rename from
15210         new_call_thread_fsm.
15211         (call_thread_fsm::should_stop): Rename from
15212         call_thread_fsm_should_stop.
15213         (call_thread_fsm::should_notify_stop): Rename from
15214         call_thread_fsm_should_notify_stop.
15215         (run_inferior_call, call_function_by_hand_dummy): Update.
15216         * cli/cli-interp.c (should_print_stop_to_console): Update.
15217         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15218         Add constructor.  Change type of location_breakpoint,
15219         caller_breakpoint.
15220         (until_break_fsm_ops): Remove.
15221         (new_until_break_fsm): Remove.
15222         (until_break_fsm::should_stop): Rename from
15223         until_break_fsm_should_stop.
15224         (until_break_fsm::clean_up): Rename from
15225         until_break_fsm_clean_up.
15226         (until_break_fsm::do_async_reply_reason): Rename from
15227         until_break_fsm_async_reply_reason.
15228         (until_break_command): Update.
15229         * thread-fsm.c: Remove.
15230         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15231
15232 2019-02-07  Tom Tromey  <tom@tromey.com>
15233
15234         * yy-remap.h: Add include guard.
15235         * xtensa-tdep.h: Add include guard.
15236         * xcoffread.h: Rename include guard.
15237         * varobj-iter.h: Add include guard.
15238         * tui/tui.h: Rename include guard.
15239         * tui/tui-winsource.h: Rename include guard.
15240         * tui/tui-wingeneral.h: Rename include guard.
15241         * tui/tui-windata.h: Rename include guard.
15242         * tui/tui-win.h: Rename include guard.
15243         * tui/tui-stack.h: Rename include guard.
15244         * tui/tui-source.h: Rename include guard.
15245         * tui/tui-regs.h: Rename include guard.
15246         * tui/tui-out.h: Rename include guard.
15247         * tui/tui-layout.h: Rename include guard.
15248         * tui/tui-io.h: Rename include guard.
15249         * tui/tui-hooks.h: Rename include guard.
15250         * tui/tui-file.h: Rename include guard.
15251         * tui/tui-disasm.h: Rename include guard.
15252         * tui/tui-data.h: Rename include guard.
15253         * tui/tui-command.h: Rename include guard.
15254         * tic6x-tdep.h: Add include guard.
15255         * target/waitstatus.h: Rename include guard.
15256         * target/wait.h: Rename include guard.
15257         * target/target.h: Rename include guard.
15258         * target/resume.h: Rename include guard.
15259         * target-float.h: Rename include guard.
15260         * stabsread.h: Add include guard.
15261         * rs6000-tdep.h: Add include guard.
15262         * riscv-fbsd-tdep.h: Add include guard.
15263         * regformats/regdef.h: Rename include guard.
15264         * record.h: Rename include guard.
15265         * python/python.h: Rename include guard.
15266         * python/python-internal.h: Rename include guard.
15267         * python/py-stopevent.h: Rename include guard.
15268         * python/py-ref.h: Rename include guard.
15269         * python/py-record.h: Rename include guard.
15270         * python/py-record-full.h: Rename include guard.
15271         * python/py-record-btrace.h: Rename include guard.
15272         * python/py-instruction.h: Rename include guard.
15273         * python/py-events.h: Rename include guard.
15274         * python/py-event.h: Rename include guard.
15275         * procfs.h: Add include guard.
15276         * proc-utils.h: Add include guard.
15277         * p-lang.h: Add include guard.
15278         * or1k-tdep.h: Rename include guard.
15279         * observable.h: Rename include guard.
15280         * nto-tdep.h: Rename include guard.
15281         * nat/x86-linux.h: Rename include guard.
15282         * nat/x86-linux-dregs.h: Rename include guard.
15283         * nat/x86-gcc-cpuid.h: Add include guard.
15284         * nat/x86-dregs.h: Rename include guard.
15285         * nat/x86-cpuid.h: Rename include guard.
15286         * nat/ppc-linux.h: Rename include guard.
15287         * nat/mips-linux-watch.h: Rename include guard.
15288         * nat/linux-waitpid.h: Rename include guard.
15289         * nat/linux-ptrace.h: Rename include guard.
15290         * nat/linux-procfs.h: Rename include guard.
15291         * nat/linux-osdata.h: Rename include guard.
15292         * nat/linux-nat.h: Rename include guard.
15293         * nat/linux-namespaces.h: Rename include guard.
15294         * nat/linux-btrace.h: Rename include guard.
15295         * nat/glibc_thread_db.h: Rename include guard.
15296         * nat/gdb_thread_db.h: Rename include guard.
15297         * nat/gdb_ptrace.h: Rename include guard.
15298         * nat/fork-inferior.h: Rename include guard.
15299         * nat/amd64-linux-siginfo.h: Rename include guard.
15300         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15301         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15302         * nat/aarch64-linux.h: Rename include guard.
15303         * nat/aarch64-linux-hw-point.h: Rename include guard.
15304         * mn10300-tdep.h: Add include guard.
15305         * mips-linux-tdep.h: Add include guard.
15306         * mi/mi-parse.h: Rename include guard.
15307         * mi/mi-out.h: Rename include guard.
15308         * mi/mi-main.h: Rename include guard.
15309         * mi/mi-interp.h: Rename include guard.
15310         * mi/mi-getopt.h: Rename include guard.
15311         * mi/mi-console.h: Rename include guard.
15312         * mi/mi-common.h: Rename include guard.
15313         * mi/mi-cmds.h: Rename include guard.
15314         * mi/mi-cmd-break.h: Rename include guard.
15315         * m2-lang.h: Add include guard.
15316         * location.h: Rename include guard.
15317         * linux-record.h: Rename include guard.
15318         * linux-nat.h: Add include guard.
15319         * linux-fork.h: Add include guard.
15320         * i386-darwin-tdep.h: Rename include guard.
15321         * hppa-linux-offsets.h: Add include guard.
15322         * guile/guile.h: Rename include guard.
15323         * guile/guile-internal.h: Rename include guard.
15324         * gnu-nat.h: Rename include guard.
15325         * gdb-stabs.h: Rename include guard.
15326         * frv-tdep.h: Add include guard.
15327         * f-lang.h: Add include guard.
15328         * event-loop.h: Add include guard.
15329         * darwin-nat.h: Rename include guard.
15330         * cp-abi.h: Rename include guard.
15331         * config/sparc/nm-sol2.h: Rename include guard.
15332         * config/nm-nto.h: Rename include guard.
15333         * config/nm-linux.h: Add include guard.
15334         * config/i386/nm-i386gnu.h: Rename include guard.
15335         * config/djgpp/nl_types.h: Rename include guard.
15336         * config/djgpp/langinfo.h: Rename include guard.
15337         * compile/gcc-cp-plugin.h: Add include guard.
15338         * compile/gcc-c-plugin.h: Add include guard.
15339         * compile/compile.h: Rename include guard.
15340         * compile/compile-object-run.h: Rename include guard.
15341         * compile/compile-object-load.h: Rename include guard.
15342         * compile/compile-internal.h: Rename include guard.
15343         * compile/compile-cplus.h: Rename include guard.
15344         * compile/compile-c.h: Rename include guard.
15345         * common/xml-utils.h: Rename include guard.
15346         * common/x86-xstate.h: Rename include guard.
15347         * common/version.h: Rename include guard.
15348         * common/vec.h: Rename include guard.
15349         * common/tdesc.h: Rename include guard.
15350         * common/selftest.h: Rename include guard.
15351         * common/scoped_restore.h: Rename include guard.
15352         * common/scoped_mmap.h: Rename include guard.
15353         * common/scoped_fd.h: Rename include guard.
15354         * common/safe-iterator.h: Rename include guard.
15355         * common/run-time-clock.h: Rename include guard.
15356         * common/refcounted-object.h: Rename include guard.
15357         * common/queue.h: Rename include guard.
15358         * common/ptid.h: Rename include guard.
15359         * common/print-utils.h: Rename include guard.
15360         * common/preprocessor.h: Rename include guard.
15361         * common/pathstuff.h: Rename include guard.
15362         * common/observable.h: Rename include guard.
15363         * common/netstuff.h: Rename include guard.
15364         * common/job-control.h: Rename include guard.
15365         * common/host-defs.h: Rename include guard.
15366         * common/gdb_wait.h: Rename include guard.
15367         * common/gdb_vecs.h: Rename include guard.
15368         * common/gdb_unlinker.h: Rename include guard.
15369         * common/gdb_unique_ptr.h: Rename include guard.
15370         * common/gdb_tilde_expand.h: Rename include guard.
15371         * common/gdb_sys_time.h: Rename include guard.
15372         * common/gdb_string_view.h: Rename include guard.
15373         * common/gdb_splay_tree.h: Rename include guard.
15374         * common/gdb_setjmp.h: Rename include guard.
15375         * common/gdb_ref_ptr.h: Rename include guard.
15376         * common/gdb_optional.h: Rename include guard.
15377         * common/gdb_locale.h: Rename include guard.
15378         * common/gdb_assert.h: Rename include guard.
15379         * common/filtered-iterator.h: Rename include guard.
15380         * common/filestuff.h: Rename include guard.
15381         * common/fileio.h: Rename include guard.
15382         * common/environ.h: Rename include guard.
15383         * common/common-utils.h: Rename include guard.
15384         * common/common-types.h: Rename include guard.
15385         * common/common-regcache.h: Rename include guard.
15386         * common/common-inferior.h: Rename include guard.
15387         * common/common-gdbthread.h: Rename include guard.
15388         * common/common-exceptions.h: Rename include guard.
15389         * common/common-defs.h: Rename include guard.
15390         * common/common-debug.h: Rename include guard.
15391         * common/cleanups.h: Rename include guard.
15392         * common/buffer.h: Rename include guard.
15393         * common/btrace-common.h: Rename include guard.
15394         * common/break-common.h: Rename include guard.
15395         * cli/cli-utils.h: Rename include guard.
15396         * cli/cli-style.h: Rename include guard.
15397         * cli/cli-setshow.h: Rename include guard.
15398         * cli/cli-script.h: Rename include guard.
15399         * cli/cli-interp.h: Rename include guard.
15400         * cli/cli-decode.h: Rename include guard.
15401         * cli/cli-cmds.h: Rename include guard.
15402         * charset-list.h: Add include guard.
15403         * buildsym-legacy.h: Rename include guard.
15404         * bfin-tdep.h: Add include guard.
15405         * ax.h: Rename include guard.
15406         * arm-linux-tdep.h: Add include guard.
15407         * arm-fbsd-tdep.h: Add include guard.
15408         * arch/xtensa.h: Rename include guard.
15409         * arch/tic6x.h: Add include guard.
15410         * arch/i386.h: Add include guard.
15411         * arch/arm.h: Rename include guard.
15412         * arch/arm-linux.h: Rename include guard.
15413         * arch/arm-get-next-pcs.h: Rename include guard.
15414         * arch/amd64.h: Add include guard.
15415         * arch/aarch64-insn.h: Rename include guard.
15416         * arch-utils.h: Rename include guard.
15417         * annotate.h: Add include guard.
15418         * amd64-darwin-tdep.h: Rename include guard.
15419         * aarch64-linux-tdep.h: Add include guard.
15420         * aarch64-fbsd-tdep.h: Add include guard.
15421         * aarch32-linux-nat.h: Add include guard.
15422
15423 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15424
15425         * macrotab.c (macro_define_internal): New function that
15426         factorizes macro_define_object_internal and macro_define_function
15427         code.
15428         (macro_define_object_internal): Use macro_define_internal.
15429         (macro_define_function): Likewise.
15430
15431 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15432
15433         * macrocmd.c (extract_identifier): Return
15434         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15435         callers.
15436
15437 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15438
15439         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15440
15441 2019-02-05  Tom Tromey  <tom@tromey.com>
15442
15443         * target.c (target_stack::unpush): Move assertion earlier.
15444
15445 2019-01-30  Tom Tromey  <tom@tromey.com>
15446
15447         PR python/23615:
15448         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15449         (gdbpy_parse_and_eval): Likewise.
15450         * python/python-internal.h (gdbpy_allow_threads): New class.
15451
15452 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15453
15454         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15455         (aarch64_fbsd_fpregmap): Move earlier.
15456         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15457         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15458         instead of individual calls to trad_frame_set_reg_addr.
15459         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15460         earlier.
15461         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15462         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15463         instead of individual calls to trad_frame_set_reg_addr.
15464
15465 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15466
15467         * CONTRIBUTE: Replace contribution list with wiki link.
15468
15469 2019-01-25  Tom Tromey  <tom@tromey.com>
15470
15471         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15472
15473 2019-01-25  Tom Tromey  <tom@tromey.com>
15474
15475         * xtensa-linux-nat.c: Fix common/ includes.
15476         * xml-support.h: Fix common/ includes.
15477         * xml-support.c: Fix common/ includes.
15478         * x86-linux-nat.c: Fix common/ includes.
15479         * windows-nat.c: Fix common/ includes.
15480         * varobj.h: Fix common/ includes.
15481         * varobj.c: Fix common/ includes.
15482         * value.c: Fix common/ includes.
15483         * valops.c: Fix common/ includes.
15484         * utils.c: Fix common/ includes.
15485         * unittests/xml-utils-selftests.c: Fix common/ includes.
15486         * unittests/utils-selftests.c: Fix common/ includes.
15487         * unittests/unpack-selftests.c: Fix common/ includes.
15488         * unittests/tracepoint-selftests.c: Fix common/ includes.
15489         * unittests/style-selftests.c: Fix common/ includes.
15490         * unittests/string_view-selftests.c: Fix common/ includes.
15491         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15492         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15493         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15494         * unittests/rsp-low-selftests.c: Fix common/ includes.
15495         * unittests/parse-connection-spec-selftests.c: Fix common/
15496         includes.
15497         * unittests/optional-selftests.c: Fix common/ includes.
15498         * unittests/offset-type-selftests.c: Fix common/ includes.
15499         * unittests/observable-selftests.c: Fix common/ includes.
15500         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15501         * unittests/memrange-selftests.c: Fix common/ includes.
15502         * unittests/memory-map-selftests.c: Fix common/ includes.
15503         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15504         * unittests/function-view-selftests.c: Fix common/ includes.
15505         * unittests/environ-selftests.c: Fix common/ includes.
15506         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15507         * unittests/common-utils-selftests.c: Fix common/ includes.
15508         * unittests/cli-utils-selftests.c: Fix common/ includes.
15509         * unittests/array-view-selftests.c: Fix common/ includes.
15510         * ui-file.c: Fix common/ includes.
15511         * tui/tui-io.c: Fix common/ includes.
15512         * tracepoint.h: Fix common/ includes.
15513         * tracepoint.c: Fix common/ includes.
15514         * tracefile-tfile.c: Fix common/ includes.
15515         * top.h: Fix common/ includes.
15516         * top.c: Fix common/ includes.
15517         * thread.c: Fix common/ includes.
15518         * target/waitstatus.h: Fix common/ includes.
15519         * target/waitstatus.c: Fix common/ includes.
15520         * target.h: Fix common/ includes.
15521         * target.c: Fix common/ includes.
15522         * target-memory.c: Fix common/ includes.
15523         * target-descriptions.c: Fix common/ includes.
15524         * symtab.h: Fix common/ includes.
15525         * symfile.c: Fix common/ includes.
15526         * stap-probe.c: Fix common/ includes.
15527         * spu-linux-nat.c: Fix common/ includes.
15528         * sparc-nat.c: Fix common/ includes.
15529         * source.c: Fix common/ includes.
15530         * solib.c: Fix common/ includes.
15531         * solib-target.c: Fix common/ includes.
15532         * ser-unix.c: Fix common/ includes.
15533         * ser-tcp.c: Fix common/ includes.
15534         * ser-pipe.c: Fix common/ includes.
15535         * ser-base.c: Fix common/ includes.
15536         * selftest-arch.c: Fix common/ includes.
15537         * s12z-tdep.c: Fix common/ includes.
15538         * rust-exp.y: Fix common/ includes.
15539         * rs6000-aix-tdep.c: Fix common/ includes.
15540         * riscv-tdep.c: Fix common/ includes.
15541         * remote.c: Fix common/ includes.
15542         * remote-notif.h: Fix common/ includes.
15543         * remote-fileio.h: Fix common/ includes.
15544         * remote-fileio.c: Fix common/ includes.
15545         * regcache.h: Fix common/ includes.
15546         * regcache.c: Fix common/ includes.
15547         * record-btrace.c: Fix common/ includes.
15548         * python/python.c: Fix common/ includes.
15549         * python/py-type.c: Fix common/ includes.
15550         * python/py-inferior.c: Fix common/ includes.
15551         * progspace.h: Fix common/ includes.
15552         * producer.c: Fix common/ includes.
15553         * procfs.c: Fix common/ includes.
15554         * proc-api.c: Fix common/ includes.
15555         * printcmd.c: Fix common/ includes.
15556         * ppc-linux-nat.c: Fix common/ includes.
15557         * parser-defs.h: Fix common/ includes.
15558         * osdata.c: Fix common/ includes.
15559         * obsd-nat.c: Fix common/ includes.
15560         * nat/x86-linux.c: Fix common/ includes.
15561         * nat/x86-linux-dregs.c: Fix common/ includes.
15562         * nat/x86-dregs.h: Fix common/ includes.
15563         * nat/x86-dregs.c: Fix common/ includes.
15564         * nat/ppc-linux.c: Fix common/ includes.
15565         * nat/mips-linux-watch.h: Fix common/ includes.
15566         * nat/mips-linux-watch.c: Fix common/ includes.
15567         * nat/linux-waitpid.c: Fix common/ includes.
15568         * nat/linux-ptrace.h: Fix common/ includes.
15569         * nat/linux-ptrace.c: Fix common/ includes.
15570         * nat/linux-procfs.c: Fix common/ includes.
15571         * nat/linux-personality.c: Fix common/ includes.
15572         * nat/linux-osdata.c: Fix common/ includes.
15573         * nat/linux-namespaces.c: Fix common/ includes.
15574         * nat/linux-btrace.h: Fix common/ includes.
15575         * nat/linux-btrace.c: Fix common/ includes.
15576         * nat/fork-inferior.c: Fix common/ includes.
15577         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15578         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15579         * nat/aarch64-linux.c: Fix common/ includes.
15580         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15581         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15582         * namespace.h: Fix common/ includes.
15583         * mips-linux-tdep.c: Fix common/ includes.
15584         * minsyms.c: Fix common/ includes.
15585         * mi/mi-parse.h: Fix common/ includes.
15586         * mi/mi-main.c: Fix common/ includes.
15587         * mi/mi-cmd-env.c: Fix common/ includes.
15588         * memrange.h: Fix common/ includes.
15589         * memattr.c: Fix common/ includes.
15590         * maint.h: Fix common/ includes.
15591         * maint.c: Fix common/ includes.
15592         * main.c: Fix common/ includes.
15593         * machoread.c: Fix common/ includes.
15594         * location.c: Fix common/ includes.
15595         * linux-thread-db.c: Fix common/ includes.
15596         * linux-nat.c: Fix common/ includes.
15597         * linux-fork.c: Fix common/ includes.
15598         * inline-frame.c: Fix common/ includes.
15599         * infrun.c: Fix common/ includes.
15600         * inflow.c: Fix common/ includes.
15601         * inferior.h: Fix common/ includes.
15602         * inferior.c: Fix common/ includes.
15603         * infcmd.c: Fix common/ includes.
15604         * inf-ptrace.c: Fix common/ includes.
15605         * inf-child.c: Fix common/ includes.
15606         * ia64-linux-nat.c: Fix common/ includes.
15607         * i387-tdep.c: Fix common/ includes.
15608         * i386-tdep.c: Fix common/ includes.
15609         * i386-linux-tdep.c: Fix common/ includes.
15610         * i386-linux-nat.c: Fix common/ includes.
15611         * i386-go32-tdep.c: Fix common/ includes.
15612         * i386-fbsd-tdep.c: Fix common/ includes.
15613         * i386-fbsd-nat.c: Fix common/ includes.
15614         * guile/scm-type.c: Fix common/ includes.
15615         * guile/guile.c: Fix common/ includes.
15616         * go32-nat.c: Fix common/ includes.
15617         * gnu-nat.c: Fix common/ includes.
15618         * gdbthread.h: Fix common/ includes.
15619         * gdbarch-selftests.c: Fix common/ includes.
15620         * gdb_usleep.c: Fix common/ includes.
15621         * gdb_select.h: Fix common/ includes.
15622         * gdb_bfd.c: Fix common/ includes.
15623         * gcore.c: Fix common/ includes.
15624         * fork-child.c: Fix common/ includes.
15625         * findvar.c: Fix common/ includes.
15626         * fbsd-nat.c: Fix common/ includes.
15627         * event-top.c: Fix common/ includes.
15628         * event-loop.c: Fix common/ includes.
15629         * dwarf2read.c: Fix common/ includes.
15630         * dwarf2loc.c: Fix common/ includes.
15631         * dwarf2-frame.c: Fix common/ includes.
15632         * dwarf-index-cache.c: Fix common/ includes.
15633         * dtrace-probe.c: Fix common/ includes.
15634         * disasm-selftests.c: Fix common/ includes.
15635         * defs.h: Fix common/ includes.
15636         * csky-tdep.c: Fix common/ includes.
15637         * cp-valprint.c: Fix common/ includes.
15638         * cp-support.h: Fix common/ includes.
15639         * cp-support.c: Fix common/ includes.
15640         * corelow.c: Fix common/ includes.
15641         * completer.h: Fix common/ includes.
15642         * completer.c: Fix common/ includes.
15643         * compile/compile.c: Fix common/ includes.
15644         * compile/compile-loc2c.c: Fix common/ includes.
15645         * compile/compile-cplus-types.c: Fix common/ includes.
15646         * compile/compile-cplus-symbols.c: Fix common/ includes.
15647         * command.h: Fix common/ includes.
15648         * cli/cli-dump.c: Fix common/ includes.
15649         * cli/cli-cmds.c: Fix common/ includes.
15650         * charset.c: Fix common/ includes.
15651         * build-id.c: Fix common/ includes.
15652         * btrace.h: Fix common/ includes.
15653         * btrace.c: Fix common/ includes.
15654         * breakpoint.h: Fix common/ includes.
15655         * breakpoint.c: Fix common/ includes.
15656         * ax.h:
15657         (enum agent_op): Fix common/ includes.
15658         * ax-general.c (struct aop_map): Fix common/ includes.
15659         * ax-gdb.c: Fix common/ includes.
15660         * auxv.c: Fix common/ includes.
15661         * auto-load.c: Fix common/ includes.
15662         * arm-tdep.c: Fix common/ includes.
15663         * arch/riscv.c: Fix common/ includes.
15664         * arch/ppc-linux-common.c: Fix common/ includes.
15665         * arch/i386.c: Fix common/ includes.
15666         * arch/arm.c: Fix common/ includes.
15667         * arch/arm-linux.c: Fix common/ includes.
15668         * arch/arm-get-next-pcs.c: Fix common/ includes.
15669         * arch/amd64.c: Fix common/ includes.
15670         * arch/aarch64.c: Fix common/ includes.
15671         * arch/aarch64-insn.c: Fix common/ includes.
15672         * arch-utils.c: Fix common/ includes.
15673         * amd64-windows-tdep.c: Fix common/ includes.
15674         * amd64-tdep.c: Fix common/ includes.
15675         * amd64-sol2-tdep.c: Fix common/ includes.
15676         * amd64-obsd-tdep.c: Fix common/ includes.
15677         * amd64-nbsd-tdep.c: Fix common/ includes.
15678         * amd64-linux-tdep.c: Fix common/ includes.
15679         * amd64-linux-nat.c: Fix common/ includes.
15680         * amd64-fbsd-tdep.c: Fix common/ includes.
15681         * amd64-fbsd-nat.c: Fix common/ includes.
15682         * amd64-dicos-tdep.c: Fix common/ includes.
15683         * amd64-darwin-tdep.c: Fix common/ includes.
15684         * agent.c: Fix common/ includes.
15685         * ada-lang.h: Fix common/ includes.
15686         * ada-lang.c: Fix common/ includes.
15687         * aarch64-tdep.c: Fix common/ includes.
15688
15689 2019-01-25  Tom Tromey  <tom@tromey.com>
15690
15691         * common/create-version.sh: Use common/version.h.
15692
15693 2019-01-24  Pedro Alves  <palves@redhat.com>
15694
15695         * infrun.c (signal_stop, signal_print, signal_program)
15696         (signal_catch, signal_pass): Now arrays instead of pointers.
15697         (update_signals_program_target, do_target_resume)
15698         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15699         * linux-nat.c (linux_nat_target::pass_signals)
15700         (linux_nat_target::create_inferior, linux_nat_target::attach):
15701         Adjust.
15702         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15703         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15704         * procfs.c (procfs_target::pass_signals): Adjust.
15705         * record-full.c (record_full_target::resume): Adjust.
15706         * remote.c (remote_target::pass_signals)
15707         (remote_target::program_signals): Adjust.
15708         * target-debug.h (target_debug_print_signals): Now takes a
15709         gdb::array_view as parameter.  Adjust.
15710         * target.h (target_ops) <pass_signals, program_signals>: Replace
15711         pointer and length parameters with gdb::array_view.
15712         (target_pass_signals, target_program_signals): Likewise.
15713         * target-delegates.c: Regenerate.
15714
15715 2019-01-24  Pedro Alves  <palves@redhat.com>
15716
15717         * common/forward-scope-exit.h
15718         (forward_scope_exit::forward_scope_exit): Pass arguments to
15719         m_bind_function directly, instead of creating a std::bind and
15720         copying that.
15721
15722 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15723
15724         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15725         for static members.
15726         (pass_in_v_vfp_candidate): Likewise.
15727
15728 2019-01-23  Tom Tromey  <tom@tromey.com>
15729             Pedro Alves  <palves@redhat.com>
15730
15731         * regcache.c (class regcache_invalidator): Remove.
15732         (regcache::raw_write): Use make_scope_exit.
15733
15734 2019-01-23  Tom Tromey  <tom@tromey.com>
15735
15736         * ui-out.h (class ui_out_emit_type): Update comment.
15737
15738 2019-01-23  Tom Tromey  <tom@tromey.com>
15739
15740         * infrun.c (fetch_inferior_event): Update comment.
15741
15742 2019-01-23  Tom Tromey  <tom@tromey.com>
15743             Pedro Alves  <palves@redhat.com>
15744
15745         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15746         parameter.
15747         (fetch_inferior_event): Use SCOPE_EXIT.
15748
15749
15750 2019-01-23  Tom Tromey  <tom@tromey.com>
15751             Pedro Alves  <palves@redhat.com>
15752
15753         * infrun.c (disable_thread_events): Delete.
15754         (stop_all_threads): Use SCOPE_EXIT.
15755
15756 2019-01-23  Tom Tromey  <tom@tromey.com>
15757             Pedro Alves  <palves@redhat.com>
15758
15759         * symfile.c: Include forward-scope-exit.h.
15760         (clear_symtab_users_cleanup): Replace forward declaration with
15761         a FORWARD_SCOPE_EXIT.
15762         (syms_from_objfile_1): Use the forward_scope_exit and
15763         gdb::optional instead of cleanup_function.
15764         (reread_symbols): Use the forward_scope_exit instead of
15765         cleanup_function.
15766         (clear_symtab_users_cleanup): Remove function.
15767
15768 2019-01-23  Tom Tromey  <tom@tromey.com>
15769             Pedro Alves  <palves@redhat.com>
15770
15771         * linux-nat.c: Include scope-exit.h.
15772         (cleanup_target_stop): Remove.
15773         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15774         SCOPE_EXIT.
15775
15776 2019-01-23  Tom Tromey  <tom@tromey.com>
15777             Pedro Alves  <palves@redhat.com>
15778
15779         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15780         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15781
15782 2019-01-23  Tom Tromey  <tom@tromey.com>
15783             Andrew Burgess  <andrew.burgess@embecosm.com>
15784             Pedro Alves  <palves@redhat.com>
15785
15786         * infrun.c (fetch_inferior_event): Use scope_exit.
15787         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15788         * top.c (execute_command): Use scope_exit.
15789         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15790         * utils.c (do_bpstat_clear_actions_cleanup)
15791         (make_bpstat_clear_actions_cleanup): Remove.
15792
15793 2019-01-23  Tom Tromey  <tom@tromey.com>
15794             Pedro Alves  <palves@redhat.com>
15795
15796         * infrun.c: Include "common/scope-exit.h"
15797         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15798         (wait_for_inferior): Use SCOPE_EXIT.
15799         (fetch_inferior_event): Use scope_exit.
15800
15801 2019-01-23  Tom Tromey  <tom@tromey.com>
15802             Pedro Alves  <palves@redhat.com>
15803
15804         * breakpoint.c (create_breakpoint): Remove cleanup.
15805
15806 2019-01-23  Tom Tromey  <tom@tromey.com>
15807             Andrew Burgess  <andrew.burgess@embecosm.com>
15808             Pedro Alves  <palves@redhat.com>
15809
15810 2019-01-23  Pedro Alves  <palves@redhat.com>
15811
15812         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15813
15814 2019-01-23  Pedro Alves  <palves@redhat.com>
15815             Andrew Burgess  <andrew.burgess@embecosm.com>
15816
15817         * gdbthread.h: Include "common/forward-scope-exit.h".
15818         (scoped_finish_thread_state): Redefine custom class in terms of
15819         forward_scope_exit.
15820
15821 2019-01-23  Pedro Alves  <palves@redhat.com>
15822             Andrew Burgess  <andrew.burgess@embecosm.com>
15823
15824         * common/forward-scope-exit.h: New file.
15825
15826 2019-01-23  Pedro Alves  <palves@redhat.com>
15827             Andrew Burgess  <andrew.burgess@embecosm.com>
15828             Tom Tromey  <tom@tromey.com>
15829
15830         * common/scope-exit.h: New file.
15831
15832 2019-01-23  Pedro Alves  <palves@redhat.com>
15833
15834         * common/preprocessor.h (ESC): Rename to ...
15835         (ESC_PARENS): ... this.
15836         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15837         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15838
15839 2019-01-23  Tom Tromey  <tom@tromey.com>
15840
15841         * language.h (class scoped_switch_to_sym_language_if_auto):
15842         Initialize m_lang in both cases.
15843
15844 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15845
15846         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15847         with XCNEW.
15848
15849 2019-01-22  Tom Tromey  <tom@tromey.com>
15850
15851         * corelow.c: Do not include sys/file.h.
15852
15853 2019-01-22  Tom Tromey  <tom@tromey.com>
15854
15855         * tui/tui-wingeneral.h: Include gdb_curses.h.
15856
15857 2019-01-22  Tom Tromey  <tom@tromey.com>
15858
15859         * source-cache.h (class source_cache) <get_source_lines,
15860         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15861
15862 2019-01-22  Tom Tromey  <tom@tromey.com>
15863
15864         * remote-fileio.h (struct remote_target): Declare.
15865
15866 2019-01-22  Tom Tromey  <tom@tromey.com>
15867
15868         * python/py-arch.c: Do not include py-ref.h.
15869         * python/py-bpevent.c: Do not include py-ref.h.
15870         * python/py-cmd.c: Do not include py-ref.h.
15871         * python/py-continueevent.c: Do not include py-ref.h.
15872         * python/py-event.h: Do not include py-ref.h.
15873         * python/py-evtregistry.c: Do not include py-ref.h.
15874         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15875         * python/py-frame.c: Do not include py-ref.h.
15876         * python/py-framefilter.c: Do not include py-ref.h.
15877         * python/py-function.c: Do not include py-ref.h.
15878         * python/py-infevents.c: Do not include py-ref.h.
15879         * python/py-linetable.c: Do not include py-ref.h.
15880         * python/py-objfile.c: Do not include py-ref.h.
15881         * python/py-param.c: Do not include py-ref.h.
15882         * python/py-prettyprint.c: Do not include py-ref.h.
15883         * python/py-progspace.c: Do not include py-ref.h.
15884         * python/py-symbol.c: Do not include py-ref.h.
15885         * python/py-symtab.c: Do not include py-ref.h.
15886         * python/py-type.c: Do not include py-ref.h.
15887         * python/py-unwind.c: Do not include py-ref.h.
15888         * python/py-utils.c: Do not include py-ref.h.
15889         * python/py-value.c: Do not include py-ref.h.
15890         * python/py-varobj.c: Do not include py-ref.h.
15891         * python/py-xmethods.c: Do not include py-ref.h.
15892         * python/python.c: Do not include py-ref.h.
15893         * varobj.c: Do not include py-ref.h.
15894
15895 2019-01-22  Tom Tromey  <tom@tromey.com>
15896
15897         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15898         keyword for bcache.
15899
15900 2019-01-22  Tom Tromey  <tom@tromey.com>
15901
15902         * compile/compile-cplus-types.c: Remove a comment by #include.
15903
15904 2019-01-22  Tom Tromey  <tom@tromey.com>
15905
15906         * compile/gcc-c-plugin.h: Include compile-internal.h.
15907
15908 2019-01-22  Tom Tromey  <tom@tromey.com>
15909
15910         * stabsread.c (EXTERN): Do not define.
15911         (symnum, next_symbol_text_func, processing_gcc_compilation)
15912         (within_function, global_sym_chain, global_stabs)
15913         (previous_stab_code, this_object_header_files)
15914         (n_this_object_header_files)
15915         (n_allocated_this_object_header_files): Define.
15916         * stabsread.h (EXTERN): Never define.  Use "extern".
15917
15918 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15919
15920         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15921         history_value.
15922
15923 2019-01-21  Tom Tromey  <tom@tromey.com>
15924
15925         * ui-out.c: Fix includes.
15926         * tui/tui-source.c: Fix includes.
15927         * target.c: Fix includes.
15928         * remote.c: Fix includes.
15929         * regcache.c: Fix includes.
15930         * python/py-block.c: Fix includes.
15931         * printcmd.c: Fix includes.
15932         * or1k-tdep.c: Fix includes.
15933         * mi/mi-main.c: Fix includes.
15934         * m32r-tdep.c: Fix includes.
15935         * csky-tdep.c: Fix includes.
15936         * compile/compile-cplus-types.c: Fix includes.
15937         * cli/cli-interp.c: Fix includes.
15938
15939 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15940
15941         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15942         for padding.
15943
15944 2019-01-16  Tom Tromey  <tom@tromey.com>
15945
15946         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15947         earlier.
15948         (struct objfile) <msymbols_range>: Move from top level.
15949         <msymbols>: New method.
15950         (class objfile_msymbols): Remove.
15951         * symtab.c (default_collect_symbol_completion_matches_break_on):
15952         Update.
15953         * symmisc.c (dump_msymbols): Update.
15954         * stabsread.c (scan_file_globals): Update.
15955         * objc-lang.c (info_selectors_command, info_classes_command)
15956         (find_methods): Update.
15957         * minsyms.c (find_solib_trampoline_target): Update.
15958         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15959         * coffread.c (coff_symfile_read): Update.
15960         * ada-lang.c (ada_lookup_simple_minsym)
15961         (ada_collect_symbol_completion_matches): Update.
15962
15963 2019-01-16  Tom Tromey  <tom@tromey.com>
15964
15965         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15966         type.  Remove no-argument constructor.
15967         <iterator::operator++>: Simplify.
15968         <begin>: Update.
15969         <end>: Use minimal_symbol_count.
15970
15971 2019-01-16  Tom Tromey  <tom@tromey.com>
15972
15973         * objfiles.h (struct objfile) <psymtabs>: New method.
15974         (class objfile_psymtabs): Remove.
15975         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15976         typedef.
15977         <range>: New method.
15978         (require_partial_symbols): Change return type.
15979         * psymtab.c (require_partial_symbols)
15980         (psym_expand_symtabs_matching): Update.
15981         * mdebugread.c (parse_partial_symbols): Update.
15982         * dbxread.c (dbx_end_psymtab): Update.
15983
15984 2019-01-15  Tom Tromey  <tom@tromey.com>
15985
15986         * symtab.c (lookup_objfile_from_block)
15987         (lookup_symbol_in_objfile_symtabs)
15988         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15989         (find_line_symtab, info_sources_command)
15990         (default_collect_symbol_completion_matches_break_on)
15991         (make_source_files_completion_list): Update.
15992         * symmisc.c (print_objfile_statistics, dump_objfile)
15993         (maintenance_print_symbols, maintenance_info_symtabs)
15994         (maintenance_check_symtabs, maintenance_info_line_tables):
15995         Update.
15996         * source.c (select_source_symtab)
15997         (forget_cached_source_info_for_objfile): Update.
15998         * objfiles.h (class objfile_compunits): Remove.
15999         (struct objfile) <compunits_range>: New typedef.
16000         (compunits): New method.
16001         * objfiles.c (objfile_relocate1): Update.
16002         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16003         * maint.c (count_symtabs_and_blocks): Update.
16004         * linespec.c (iterate_over_all_matching_symtabs): Update.
16005         * cp-support.c (add_symbol_overload_list_qualified): Update.
16006         * coffread.c (coff_symtab_read): Update.
16007         * ada-lang.c (add_nonlocal_symbols)
16008         (ada_collect_symbol_completion_matches)
16009         (ada_add_global_exceptions): Update.
16010
16011 2019-01-15  Tom Tromey  <tom@tromey.com>
16012
16013         * progspace.h (program_space) <objfiles_safe_range>: New
16014         typedef.
16015         <objfiles_safe>: New method.
16016         * objfiles.h (class all_objfiles_safe): Remove.
16017         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
16018         * jit.c (jit_inferior_exit_hook): Update.
16019
16020 2019-01-17  Tom Tromey  <tom@tromey.com>
16021
16022         * progspace.h (program_space) <objfiles_range>: New typedef.
16023         <objfiles>: New method.
16024         <objfiles_head>: Rename from objfiles.
16025         (object_files): Update.
16026         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
16027         * guile/scm-pretty-print.c
16028         (ppscm_find_pretty_printer_from_objfiles): Update.
16029         * guile/scm-objfile.c (gdbscm_objfiles): Update.
16030         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
16031         Update.
16032         * python/py-progspace.c (pspy_get_objfiles): Update.
16033         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16034         Update.
16035         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16036         (objfpy_lookup_objfile_by_build_id): Update.
16037         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16038         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16039         Update.
16040         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16041         (expand_symtab_containing_pc, lookup_objfile_from_block)
16042         (lookup_static_symbol, basic_lookup_transparent_type)
16043         (find_pc_sect_compunit_symtab, find_symbol_at_address)
16044         (find_line_symtab, info_sources_command)
16045         (default_collect_symbol_completion_matches_break_on)
16046         (make_source_files_completion_list, find_main_name): Update.
16047         * symmisc.c (print_symbol_bcache_statistics)
16048         (print_objfile_statistics, maintenance_print_symbols)
16049         (maintenance_print_msymbols, maintenance_print_objfiles)
16050         (maintenance_info_symtabs, maintenance_check_symtabs)
16051         (maintenance_expand_symtabs, maintenance_info_line_tables):
16052         Update.
16053         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
16054         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
16055         (map_overlay_command, unmap_overlay_command)
16056         (simple_overlay_update, expand_symtabs_matching)
16057         (map_symbol_filenames): Update.
16058         * symfile-debug.c (set_debug_symfile): Update.
16059         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
16060         Update.
16061         * source.c (select_source_symtab, forget_cached_source_info):
16062         Update.
16063         * solib.c (solib_read_symbols): Update.
16064         * solib-spu.c (append_ocl_sos): Update.
16065         * psymtab.c (maintenance_print_psymbols)
16066         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
16067         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
16068         * printcmd.c (info_symbol_command): Update.
16069         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
16070         Update.
16071         * objfiles.h (class all_objfiles): Remove.
16072         * objfiles.c (have_partial_symbols, have_full_symbols)
16073         (have_minimal_symbols, qsort_cmp, update_section_map)
16074         (shared_objfile_contains_address_p)
16075         (default_iterate_over_objfiles_in_search_order): Update.
16076         * objc-lang.c (info_selectors_command, info_classes_command)
16077         (find_methods): Update.
16078         * minsyms.c (find_solib_trampoline_target): Update.
16079         * maint.c (maintenance_info_sections)
16080         (maintenance_translate_address, count_symtabs_and_blocks):
16081         Update.
16082         * main.c (captured_main_1): Update.
16083         * linux-thread-db.c (try_thread_db_load_from_pdir)
16084         (has_libpthread): Update.
16085         * linespec.c (iterate_over_all_matching_symtabs)
16086         (search_minsyms_for_name): Update.
16087         * jit.c (jit_find_objf_with_entry_addr): Update.
16088         * hppa-tdep.c (find_unwind_entry)
16089         (hppa_lookup_stub_minimal_symbol): Update.
16090         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16091         Update.
16092         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16093         (elf_gnu_ifunc_resolve_by_got): Update.
16094         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16095         * dwarf-index-write.c (save_gdb_index_command): Update.
16096         * cp-support.c (add_symbol_overload_list_qualified): Update.
16097         * breakpoint.c (create_overlay_event_breakpoint)
16098         (create_longjmp_master_breakpoint)
16099         (create_std_terminate_master_breakpoint)
16100         (create_exception_master_breakpoint): Update.
16101         * blockframe.c (find_pc_partial_function): Update.
16102         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16103         (ada_collect_symbol_completion_matches)
16104         (ada_add_global_exceptions): Update.
16105
16106 2019-01-17  Tom Tromey  <tom@tromey.com>
16107
16108         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
16109         declare VEC.
16110         (solib_target_parse_libraries): Change return type.
16111         (library_list_start_segment, library_list_start_section)
16112         (library_list_end_library, library_list_start_library); Update.
16113         (solib_target_free_library_list): Remove.
16114         (solib_target_parse_libraries): Remove cleanup.  Change return
16115         type.
16116         (solib_target_current_sos): Update.
16117
16118 2019-01-17  Tom Tromey  <tromey@bapiya>
16119
16120         * valprint.c: Replace "the the" with "the".
16121         * symtab.c: Replace "the the" with "the".
16122         * solib.c: Replace "the the" with "the".
16123         * solib-dsbt.c: Replace "the the" with "the".
16124         * linespec.c: Replace "the the" with "the".
16125         * dwarf2loc.h: Replace "the the" with "the".
16126         * amd64-windows-tdep.c: Replace "the the" with "the".
16127         * aarch64-tdep.c: Replace "the the" with "the".
16128
16129 2019-01-16  Keith Seitz  <keiths@redhat.com>
16130
16131         PR gdb/23773
16132         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16133         <builder>: Rename to ..
16134         <m_builder>: ... this and make private.
16135         (dwarf2_cu::get_builder): New method.  Change all users of
16136         `builder' to use this method.
16137         (dwarf2_start_symtab): Move to ...
16138         (dwarf2_cu::start_symtab): ... here.  Update all callers
16139         (setup_type_unit_groups): Move to ...
16140         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
16141         callers.
16142         (dwarf2_cu::reset_builder): New method.
16143         (process_full_compunit, process_full_type_unit): Use
16144         dwarf2_cu::reset_builder.
16145         (follow_die_offset): Record the ancestor CU if it is different
16146         from the followed DIE's CU.
16147         (follow_die_sig_1): Likewise.
16148
16149 2019-01-15  Tom Tromey  <tom@tromey.com>
16150
16151         * remote.c (class remote_state) <buf>: Now a char_vector.
16152         <buf_size>: Remove.
16153         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
16154         parameter.
16155         (remote_target::getpkt_or_notif_sane_1)
16156         (remote_target::getpkt_sane)
16157         (remote_target::getpkt_or_notif_sane): Likewise.
16158         (class remote_target) <putpkt>: New overload.
16159         (remote_target::read_frame): Change type of "buf_p".  Remove
16160         sizeof_p parameter.
16161         (packet_ok): New overload.
16162         (packet_check_result): New overload.
16163         Update all uses.
16164
16165 2019-01-14  Tom Tromey  <tom@tromey.com>
16166
16167         * remote-notif.c (handle_notification, remote_notif_ack)
16168         (remote_notif_parse): Make "buf" const.
16169         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16170         const.
16171         (remote_notif_parse, remote_notif_ack, handle_notification):
16172         Likewise.
16173         * remote.c (remote_notif_stop_parse): Make "buf" const.
16174         (remote_target::remote_parse_stop_reply): Make "buf" const.
16175         (remote_notif_stop_ack): Make "buf" const.
16176
16177 2019-01-14  Tom Tromey  <tom@tromey.com>
16178
16179         * remote.c (remote_console_output): Make parameter const.
16180
16181 2019-01-14  Tom Tromey  <tom@tromey.com>
16182
16183         * target-debug.h (target_debug_print_signals): Constify.
16184         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16185         * procfs.c (procfs_target::pass_signals): Update.
16186         * linux-nat.c (linux_nat_target::pass_signals): Update.
16187         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16188         * target-delegates.c: Rebuild.
16189         * remote.c (remote_target::program_signals): Update.
16190         (remote_target::pass_signals): Update.
16191         * target.c (target_pass_signals): Constify argument.
16192         (target_program_signals): Likewise.
16193         * target.h (struct target_ops) <pass_signals, program_signals>:
16194         Constify argument.
16195         (target_pass_signals, target_program_signals): Constify argument.
16196
16197 2019-01-14  Tom Tromey  <tom@tromey.com>
16198
16199         PR tui/28819:
16200         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16201
16202 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
16203
16204         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16205         field.
16206         * rs6000-tdep.c: Include reggroups.h.
16207         (IS_V_ALIAS_PSEUDOREG): Define.
16208         (rs6000_register_name): Return names for the "vX" aliases.
16209         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16210         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
16211         aliases.  Call default_register_reggroup_p for all other
16212         pseudo-registers.
16213         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16214         New functions.
16215         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16216         Handle "vX" aliases.
16217         (v_alias_pseudo_register_collect): New function.
16218         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16219         (rs6000_gdbarch_init): Initialize "vX" aliases as
16220         pseudo-registers.  Restore registration of
16221         rs6000_pseudo_register_reggroup_p with
16222         set_tdesc_pseudo_register_reggroup_p.
16223
16224 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16225
16226         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16227         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16228         set_gdbarch_num_pseudo_regs.
16229
16230 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16231
16232         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16233         Remove arg prefixname, add do_set and do_show.
16234         Add member functions set_list and show_list.
16235         * cli/cli-style.c (class cli_style_option): Update accordingly.
16236         (style_set_list): Move to file scope.
16237         (style_show_list): Likewise.
16238         (set_style): Call help_list.
16239         (show_style): Call cmd_show_list.
16240         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16241         Update to use the new macro.
16242
16243 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16244
16245         * ada-lang.c (_initialize_ada_language): Expand the help text
16246         for the "catch exception" command.
16247
16248 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16249
16250         * symtab.c (matching_obj_sections): Initialize obj,
16251         declare it closer to its usage.
16252
16253 2019-01-10  Tom Tromey  <tom@tromey.com>
16254
16255         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16256         (basic_inf_threads_range): Remove.
16257         (inf_threads_range, inf_non_exited_threads_range)
16258         (safe_inf_threads_range): Use next_adapter.
16259
16260 2019-01-10  Keith Seitz  <keiths@redhat.com>
16261
16262         PR gdb/23712
16263         PR symtab/23010
16264         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16265         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16266
16267 2019-01-10  Keith Seitz  <keiths@redhat.com>
16268
16269         PR gdb/23712
16270         PR symtab/23010
16271         * dictionary.c (pending_to_vector): Remove.
16272         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16273         Remove _1 suffix, replacing functions of the same name.  Update
16274         all callers.
16275         (dict_create_hashed, dict_create_hashed_expandable)
16276         (dict_create_linear, dict_create_linear_expandable, dict_free)
16277         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16278         Make functions static.
16279
16280 2019-01-10  Keith Seitz  <keiths@redhat.com>
16281
16282         PR gdb/23712
16283         PR symtab/23010
16284         * dictionary.h (struct dictionary): Replace declaration with
16285         multidictionary.
16286         (dict_create_hashed, dict_create_hashed_expandable)
16287         (dict_create_linear, dict_create_linear_expandable)
16288         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16289         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16290         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16291         taking multidictionary argument.
16292         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16293         * block.h (struct block) <dict>: Change to multidictionary
16294         and rename `multidict'.
16295         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16296         symmisc.c: Update all dictionary references to multidictionary.
16297
16298 2019-01-10  Keith Seitz  <keiths@redhat.com>
16299
16300         PR gdb/23712
16301         PR symtab/23010
16302         * dictionary.c: Include unordered_map.
16303         (pending_to_vector): New function.
16304         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16305         Rewrite the non-"_1" functions to take vector instead
16306         of linked list.
16307         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16308         "new" _1 versions of the same name.
16309         (multidictionary): Define.
16310         (std::hash<enum language): New definition.
16311         (collate_pending_symbols_by_language, mdict_create_hashed)
16312         (mdict_create_hashed_expandable, mdict_create_linear)
16313         (mdict_create_linear_expandable, mdict_free)
16314         (find_language_dictionary, create_new_language_dictionary)
16315         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16316         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16317         (mdict_size, mdict_empty): New functions.
16318         * dictionary.h (mdict_iterator): Define.
16319
16320 2019-01-10  Pedro Alves  <palves@redhat.com>
16321
16322         * breakpoint.c (read_uploaded_action)
16323         (create_tracepoint_from_upload): Adjust to use
16324         gdb::unique_xmalloc_ptr.
16325         * ctf.c (ctf_write_uploaded_tp):
16326         (SET_ARRAY_FIELD): Use emplace_back.
16327         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16328         * tracefile-tfile.c (tfile_write_uploaded_tp):
16329         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16330         gdb::unique_xmalloc_ptr.
16331         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16332         at_string, cond_string, cmd_strings>: Replace char pointers
16333         with gdb::unique_xmalloc_ptr.
16334
16335 2019-01-10  Pedro Alves  <palves@redhat.com>
16336
16337         * solib-target.c (library_list_start_library): Don't xstrdup name.
16338
16339 2019-01-10  Pedro Alves  <palves@redhat.com>
16340
16341         * mdebugread.c (parse_partial_symbols): Use
16342         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16343
16344 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16345
16346         * linux-fork.c (scoped_switch_fork_info)
16347         <~scoped_switch_fork_info>: Fix incorrect variable name.
16348
16349 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16350
16351         * linux-fork.c (scoped_switch_fork_info)
16352         <scoped_switch_fork_info>: Make explicit.
16353         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16354
16355 2019-01-10  Tom Tromey  <tom@tromey.com>
16356
16357         * objfiles.h (objfile::reset_psymtabs): Update.
16358         * objfiles.c (objfile::objfile): Update.
16359         * psymtab.h (psymtab_storage::obstack): Update.
16360         (psymtab_storage::m_obstack): Use gdb::optional.
16361         (class psymtab_storage): Update comment.  Remove objfile
16362         parameter.
16363         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16364
16365 2019-01-10  Tom Tromey  <tom@tromey.com>
16366
16367         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16368         <free_psymtabs>: Now private.
16369         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16370         (allocate_psymtab): Use new method.
16371
16372 2019-01-10  Tom Tromey  <tom@tromey.com>
16373
16374         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16375         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16376         * mdebugread.c (parse_partial_symbols): Use
16377         allocate_dependencies.
16378         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16379         allocate_dependencies.
16380         (process_psymtab_comp_unit_reader)
16381         (build_type_psymtab_dependencies): Likewise.
16382         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16383
16384 2019-01-10  Tom Tromey  <tom@tromey.com>
16385
16386         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16387         PSYMBOL_SET_LANGUAGE.
16388         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16389
16390 2019-01-10  Tom Tromey  <tom@tromey.com>
16391
16392         * psymtab.h (psymtab_storage::obstack): New method.
16393         <m_obstack>: Rename from obstack; now private.
16394         * psymtab.c (psymtab_storage): Update.
16395         * dwarf2read.c (create_addrmap_from_index)
16396         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16397         Update.
16398
16399 2019-01-10  Tom Tromey  <tom@tromey.com>
16400
16401         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16402         * objfiles.h (objfile::reset_psymtabs): New method.
16403
16404 2019-01-10  Tom Tromey  <tom@tromey.com>
16405
16406         * symmisc.c (print_symbol_bcache_statistics): Update.
16407         (print_objfile_statistics): Update.
16408         * symfile.c (reread_symbols): Update.
16409         * psymtab.h (class psymtab_storage): New.
16410         * psymtab.c (psymtab_storage): New constructor.
16411         (~psymtab_storage): New destructor.
16412         (require_partial_symbols): Update.
16413         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16414         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16415         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16416         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16417         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16418         (start_psymtab_common, end_psymtab_common)
16419         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16420         (allocate_psymtab): Update.
16421         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16422         Update.
16423         (dump_psymtab_addrmap, maintenance_print_psymbols)
16424         (maintenance_check_psymtabs): Update.
16425         (class objfile_psymtabs): Move to objfiles.h.
16426         * psympriv.h (discard_psymtab): Now inline.
16427         (psymtab_discarder::psymtab_discarder): Update.
16428         (psymtab_discarder::~psymtab_discarder): Update.
16429         (ALL_OBJFILE_PSYMTABS): Rewrite.
16430         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16431         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16432         Remove fields.
16433         <partial_symtabs>: New field.
16434         (class objfile_psymtabs): Move from psymtab.h.  Update.
16435         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16436         psymbol_cache.
16437         (objfile::~objfile): Don't destroy psymbol_cache.
16438         * mdebugread.c (parse_partial_symbols): Update.
16439         * dwarf2read.c (create_addrmap_from_index)
16440         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16441         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16442         (add_partial_subprogram, dwarf2_ranges_read): Update.
16443         * dwarf-index-write.c (write_address_map)
16444         (write_one_signatured_type, recursively_write_psymbols)
16445         (class debug_names, class debug_names, write_psymtabs_to_index):
16446         Update.
16447
16448 2019-01-10  Tom Tromey  <tom@tromey.com>
16449
16450         * symtab.h (SYMBOL_SET_NAMES): Update.
16451         (symbol_set_names): Update.
16452         (MSYMBOL_SET_NAMES): Update.
16453         * symtab.c (symbol_set_names): Change argument to be an
16454         objfile_per_bfd_storage.
16455         * psymtab.c (add_psymbol_to_bcache): Update.
16456         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16457
16458 2019-01-10  Tom Tromey  <tom@tromey.com>
16459
16460         * symtab.c (create_demangled_names_hash): Change argument to be an
16461         objfile_per_bfd_storage.
16462         (symbol_set_names): Update.
16463
16464 2019-01-10  Tom Tromey  <tom@tromey.com>
16465
16466         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16467         init_psymbol_list.
16468         * psymtab.c (init_psymbol_list): Do nothing if already called.
16469         * psympriv.h (init_psymbol_list): Add comment.
16470         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16471         init_psymbol_list.
16472         * dbxread.c (dbx_symfile_read): Unconditionally call
16473         init_psymbol_list.
16474
16475 2019-01-10  Tom Tromey  <tom@tromey.com>
16476
16477         * xcoffread.c (scan_xcoff_symtab): Update.
16478         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16479         "where".
16480         * mdebugread.c (parse_partial_symbols)
16481         (handle_psymbol_enumerators): Update.
16482         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16483         * dbxread.c (read_dbx_symtab): Update.
16484         * psympriv.h (psymbol_placement): New enum.
16485         (add_psymbol_to_list): Update.
16486
16487 2019-01-10  Tom Tromey  <tom@tromey.com>
16488
16489         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16490         static_psymbols parameters.
16491         (scan_xcoff_symtab): Update.
16492         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16493         static_psymbols parameters.
16494         * psympriv.h (start_psymtab_common): Update.
16495         * mdebugread.c (parse_partial_symbols): Update.
16496         * dwarf2read.c (create_partial_symtab): Update.
16497         * dbxread.c (read_dbx_symtab): Update.
16498         (start_psymtab): Remove global_psymbols and static_psymbols
16499         parameters.
16500
16501 2019-01-10  Tom Tromey  <tom@tromey.com>
16502
16503         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16504         * psymtab.c (allocate_psymtab): Add comment.
16505         * psympriv.h (allocate_psymtab): Add comment.
16506         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16507         initializations.
16508         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16509
16510 2019-01-10  Tom Tromey  <tom@tromey.com>
16511
16512         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16513         Don't declare.
16514         * mipsread.c: Include mdebugread.h.
16515         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16516         Declare.
16517         * elfread.c: Include mdebugread.h.
16518
16519 2019-01-09  Tom Tromey  <tom@tromey.com>
16520
16521         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16522         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16523         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16524         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16525         (psym_lookup_symbol, psym_find_last_source_symtab)
16526         (psym_forget_cached_source_info, psym_print_stats)
16527         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16528         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16529         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16530         (psym_find_compunit_symtab_by_address)
16531         (maintenance_print_psymbols, maintenance_info_psymtabs)
16532         (maintenance_check_psymtabs): Use ranged for.
16533         * psymtab.h (class objfile_psymtabs): New.
16534         (require_partial_symbols): Return objfile_psymtabs.
16535         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16536
16537 2019-01-09  Tom Tromey  <tom@tromey.com>
16538
16539         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16540         (find_pc_mapped_section, list_overlays_command)
16541         (map_overlay_command, unmap_overlay_command)
16542         (simple_overlay_update): Use all_objfiles.
16543         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16544         * printcmd.c (info_symbol_command): Use all_objfiles.
16545         * objfiles.h (ALL_OBJSECTIONS): Remove.
16546         * maint.c (maintenance_translate_address): Use all_objfiles.
16547         * gcore.c (gcore_create_callback): Use all_objfiles.
16548         (objfile_find_memory_regions): Likewise.
16549
16550 2019-01-09  Tom Tromey  <tom@tromey.com>
16551
16552         * symtab.c (find_line_symtab, info_sources_command)
16553         (make_source_files_completion_list): Use objfile_compunits.
16554         * source.c (select_source_symtab): Use objfile_compunits.
16555         * objfiles.h (struct objfile): Update comment.
16556         (ALL_OBJFILES): Remove.
16557         (ALL_FILETABS): Remove.
16558         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16559         objfile_compunits.
16560
16561 2019-01-09  Tom Tromey  <tom@tromey.com>
16562
16563         * symmisc.c (print_objfile_statistics, dump_objfile)
16564         (maintenance_print_symbols): Use compunit_filetabs.
16565         * source.c (forget_cached_source_info_for_objfile): Use
16566         compunit_filetabs.
16567         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16568         (ALL_FILETABS): Use compunit_filetabs.
16569         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16570         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16571
16572 2019-01-09  Tom Tromey  <tom@tromey.com>
16573
16574         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16575         (compunit_filetabs): New.
16576         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16577         compunit_filetabs.
16578         (info_sources_command, make_source_files_completion_list): Remove
16579         declaration.
16580         * symmisc.c (print_objfile_statistics, dump_objfile)
16581         (maintenance_print_symbols): Remove declaration.
16582         (maintenance_info_symtabs): Use compunit_filetabs.
16583         (maintenance_info_line_tables): Likewise.
16584         * source.c (select_source_symtab): Change local variable name.
16585         (forget_cached_source_info_for_objfile): Remove declaration.
16586         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16587         * objfiles.c (objfile_relocate1): Remove declaration.
16588         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16589         declaration.
16590         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16591         * coffread.c (coff_symtab_read): Remove declaration.
16592         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16593         compunit_filetabs.
16594
16595 2019-01-09  Tom Tromey  <tom@tromey.com>
16596
16597         * symtab.c (lookup_objfile_from_block)
16598         (find_pc_sect_compunit_symtab, search_symbols)
16599         (default_collect_symbol_completion_matches_break_on): Use
16600         objfile_compunits.
16601         * objfiles.h (ALL_COMPUNITS): Remove.
16602         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16603         * cp-support.c (add_symbol_overload_list_qualified): Use
16604         objfile_compunits.
16605         * ada-lang.c (ada_collect_symbol_completion_matches)
16606         (ada_add_global_exceptions): Use objfile_compunits.
16607
16608 2019-01-09  Tom Tromey  <tom@tromey.com>
16609
16610         * source.c (select_source_symtab)
16611         (forget_cached_source_info_for_objfile): Remove declaration.
16612         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16613         declaration.
16614         * maint.c (count_symtabs_and_blocks): Remove declaration.
16615         * cp-support.c (add_symbol_overload_list_qualified): Remove
16616         declaration.
16617         * coffread.c (coff_symtab_read): Remove declaration.
16618         * symtab.c (lookup_symbol_in_objfile_symtabs)
16619         (basic_lookup_transparent_type_1): Use objfile_compunits.
16620         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16621         (info_sources_command, search_symbols)
16622         (default_collect_symbol_completion_matches_break_on)
16623         (make_source_files_completion_list): Remove declaration.
16624         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16625         (ada_collect_symbol_completion_matches)
16626         (ada_add_global_exceptions): Remove declaration.
16627         * linespec.c (iterate_over_all_matching_symtabs): Use
16628         objfile_compunits.
16629         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16630         (class objfile_compunits): New.
16631         (ALL_COMPUNITS): Use objfile_compunits.
16632         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16633         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16634         objfile_compunits.
16635         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16636
16637 2019-01-09  Tom Tromey  <tom@tromey.com>
16638
16639         * symtab.c (search_symbols)
16640         (default_collect_symbol_completion_matches_break_on): Use
16641         objfile_msymbols.
16642         * ada-lang.c (ada_lookup_simple_minsym)
16643         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16644         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16645         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16646         objfile_msymbols.
16647         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16648         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16649         * objc-lang.c (find_methods): Use objfile_msymbols.
16650         (info_selectors_command, info_classes_command): Likewise.
16651         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16652         * objfiles.h (class objfile_msymbols): New.
16653         (ALL_OBJFILE_MSYMBOLS): Remove.
16654         (ALL_MSYMBOLS): Remove.
16655
16656 2019-01-09  Tom Tromey  <tom@tromey.com>
16657
16658         * common/next-iterator.h (next_adapter): Add Iterator template
16659         parameter.
16660         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16661         (class all_objfiles_safe): New.
16662         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16663         * objfiles.c (put_objfile_before): Update comment.
16664         (add_separate_debug_objfile): Likewise.
16665         (free_all_objfiles): Use all_objfiles_safe.
16666         (objfile_purge_solibs): Likewise.
16667
16668 2019-01-09  Tom Tromey  <tom@tromey.com>
16669
16670         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16671         (expand_symtab_containing_pc, lookup_static_symbol)
16672         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16673         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16674         all_objfiles.
16675         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16676         * breakpoint.c (create_overlay_event_breakpoint)
16677         (create_longjmp_master_breakpoint)
16678         (create_std_terminate_master_breakpoint)
16679         (create_exception_master_breakpoint): Use all_objfiles.
16680         * linux-thread-db.c (try_thread_db_load_from_pdir)
16681         (has_libpthread): Use all_objfiles.
16682         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16683         * linespec.c (iterate_over_all_matching_symtabs)
16684         (search_minsyms_for_name): Use all_objfiles.
16685         * maint.c (maintenance_info_sections): Use all_objfiles.
16686         * main.c (captured_main_1): Use all_objfiles.
16687         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16688         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16689         * guile/scm-pretty-print.c
16690         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16691         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16692         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16693         (maintenance_print_msymbols): Use all_objfiles.
16694         * source.c (select_source_symtab): Use all_objfiles.
16695         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16696         * symfile.c (remove_symbol_file_command)
16697         (expand_symtabs_matching, map_symbol_filenames): Use
16698         all_objfiles.
16699         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16700         all_objfiles.
16701         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16702         * objc-lang.c (find_methods): Use all_objfiles.
16703         * objfiles.c (have_partial_symbols, have_full_symbols)
16704         (have_minimal_symbols, qsort_cmp)
16705         (default_iterate_over_objfiles_in_search_order): Use
16706         all_objfiles.
16707         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16708         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16709         (maintenance_check_psymtabs): Use all_objfiles.
16710         (ALL_PSYMTABS): Remove.
16711         * compile/compile-object-run.c (do_module_cleanup): Use
16712         all_objfiles.
16713         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16714         * cp-support.c (add_symbol_overload_list_qualified): Use
16715         all_objfiles.
16716         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16717         Use all_objfiles.
16718         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16719         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16720         all_objfiles.
16721         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16722         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16723         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16724         Uses all_objfiles.
16725         * solib.c (solib_read_symbols): Use all_objfiles
16726
16727 2019-01-09  Tom Tromey  <tom@tromey.com>
16728
16729         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16730         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16731         all_objfiles.
16732         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16733         * symmisc.c (print_symbol_bcache_statistics)
16734         (print_objfile_statistics, maintenance_print_objfiles)
16735         (maintenance_info_symtabs, maintenance_check_symtabs)
16736         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16737         all_objfiles.
16738         * source.c (forget_cached_source_info): Use all_objfiles.
16739         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16740         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16741         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16742         * objfiles.c (update_section_map): Use all_objfiles.
16743         (shared_objfile_contains_address_p): Likewise.
16744         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16745         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16746
16747 2019-01-09  Tom Tromey  <tom@tromey.com>
16748
16749         * common/next-iterator.h: New file.
16750         * objfiles.h (class all_objfiles): New.
16751         (struct objfile_iterator): New.
16752
16753 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16754
16755         * NEWS: Move the description of the changed "frame", "select-frame",
16756          and "info frame" commands to the Changed commands section.
16757
16758 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16759
16760         * gdbtypes.c (check_stub_method_group): Remove handling of old
16761         mangling schemes.
16762         * linespec.c (find_methods): Likewise.
16763         * stabsread.c (read_member_functions): Likewise.
16764         * valops.c (search_struct_method): Likewise.
16765         (value_struct_elt_for_reference): Likewise.
16766         * NEWS: Mention this change.
16767
16768 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16769
16770         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16771         print_source_lines.
16772         * source.c (print_source_lines_base): Update line number check.
16773         (print_source_lines): New function.
16774         (source_lines_range::source_lines_range): New function.
16775         * source.h (class source_lines_range): New class.
16776         (print_source_lines): New declaration.
16777
16778 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16779
16780         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16781
16782 2019-01-08  Tom Tromey  <tom@tromey.com>
16783             Simon Marchi  <simon.marchi@ericsson.com>
16784
16785         PR gdb/24060
16786         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16787         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16788         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16789         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16790         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16791         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16792
16793 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16794
16795         * source.c (select_source_symtab): Move header comment to
16796         declaration in source.h.
16797         (forget_cached_source_info_for_objfile): Likewise.
16798         (forget_cached_source_info): Likewise.
16799         (identify_source_line): Likewise.
16800         * source.h (identify_source_line): Move declaration from symtab.h
16801         and add comment from source.c
16802         (print_source_lines): Likewise.
16803         (forget_cached_source_info_for_objfile): Likewise.
16804         (forget_cached_source_info): Likewise.
16805         (select_source_symtab): Likewise.
16806         (enum print_source_lines_flag): Move definition from symtab.h.
16807         * symtab.h (identify_source_line): Move declaration to source.h.
16808         (print_source_lines): Likewise.
16809         (forget_cached_source_info_for_objfile): Likewise.
16810         (forget_cached_source_info): Likewise.
16811         (select_source_symtab): Likewise.
16812         (enum print_source_lines_flag): Move definition to source.h.
16813         * tui/tui-hooks.c: Add 'source.h' include.
16814
16815 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16816
16817         * source.c (print_source_lines_base): Handle requests to print
16818         reverse line number sequences, and guard against empty lines
16819         string.
16820
16821 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16822
16823         * source.c (print_source_lines_base): Fix skip of '\r' if next
16824         character is '\n'.
16825
16826 2019-01-06  Tom Tromey  <tom@tromey.com>
16827
16828         * c-exp.y (struct c_parse_state) <macro_original_text,
16829         expansion_obstack>: New member.
16830         (macro_original_text, expansion_obstack): Remove globals.
16831         (scan_macro_expansion, scanning_macro_expansion)
16832         (finished_macro_expansion): Update.
16833         (scan_macro_cleanup): Remove.
16834         (yylex, c_parse): Update.
16835
16836 2019-01-06  Tom Tromey  <tom@tromey.com>
16837
16838         * c-exp.y (struct c_parse_state) <strings>: New member.
16839         (operator_stoken): Update.
16840
16841 2019-01-06  Tom Tromey  <tom@tromey.com>
16842
16843         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16844         (union type_stack_elt) <typelist_val>: Now a pointer to
16845         std::vector.
16846         (type_stack_cleanup): Don't declare.
16847         (push_typelist): Update.
16848         * parse.c (pop_typelist): Return a std::vector.
16849         (push_typelist): Take a std::vector.
16850         (follow_types): Update.  Do not free args.
16851         (type_stack_cleanup): Remove.
16852         * c-exp.y (struct c_parse_state): New.
16853         (cpstate): New global.
16854         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16855         (nonempty_typelist): Update.
16856         (func_mod): Create a new vector.
16857         (c_parse): Create a c_parse_state.
16858         (check_parameter_typelist): Do not delete params.
16859         (function_method): Update.  Do not delete type_list.
16860
16861 2019-01-06  Tom Tromey  <tom@tromey.com>
16862
16863         PR gdb/28155:
16864         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16865         check_typedef.
16866         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16867         (print_return_value): Likewise.
16868
16869 2019-01-05  Tom Tromey  <tom@tromey.com>
16870
16871         * contrib/cleanup_check.py: Remove.
16872         * contrib/gcc-with-excheck: Remove.
16873         * contrib/exsummary.py: Remove.
16874         * contrib/excheck.py: Remove.
16875
16876 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16877
16878         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16879         NULL. Initialize tpprev to NULL instead of assigning it
16880         to NULL on the next statement.
16881         * windows-nat.c (windows_delete_thread): Remove check for
16882         main_thread_id before printing thread exit notifications.
16883         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16884         Remove thread ID check against main_thread_id.
16885         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16886         windows_delete_thread.
16887         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16888
16889 2019-01-04  Tom Tromey  <tom@tromey.com>
16890
16891         * compile/compile.c (_initialize_compile): Use upper case for
16892         metasyntactic variables.
16893         * symmisc.c (_initialize_symmisc): Use upper case for
16894         metasyntactic variables.
16895         * psymtab.c (_initialize_psymtab): Use upper case for
16896         metasyntactic variables.
16897         * demangle.c (demangle_command): Use upper case for metasyntactic
16898         variables.
16899         (_initialize_demangler): Likewise.
16900         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16901         variables.
16902
16903 2019-01-03  Tom Tromey  <tom@tromey.com>
16904
16905         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16906
16907 2019-01-03  Tom Tromey  <tom@tromey.com>
16908
16909         * python/py-symtab.c (salpy_str): Update.
16910         (struct salpy_sal_object) <symtab>: Now a PyObject.
16911         (salpy_dealloc): Update.
16912         (del_objfile_sal): Use gdbpy_ref.
16913
16914 2019-01-03  Tom Tromey  <tom@tromey.com>
16915
16916         * python/py-type.c (convert_field): Use new_reference.  Return
16917         gdbpy_ref.
16918         (make_fielditem): Return gdbpy_ref.
16919         (typy_fields): Update.
16920         (typy_getitem): Update.
16921         (field_name): Return gdbpy_ref.  Use new_reference.
16922         (typy_iterator_iternext): Update.
16923
16924 2019-01-03  Tom Tromey  <tom@tromey.com>
16925
16926         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16927
16928 2019-01-03  Tom Tromey  <tom@tromey.com>
16929
16930         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16931         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16932         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16933         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16934         (pspy_set_type_printers): Likewise.
16935         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16936         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16937         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16938         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16939         (objfpy_set_type_printers): Likewise.
16940
16941 2019-01-03  Tom Tromey  <tom@tromey.com>
16942
16943         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16944         (gdbpy_print_stack): Use gdbpy_err_fetch.
16945         * python/python-internal.h (class gdbpy_err_fetch): New class.
16946         (class gdbpy_enter) <m_error_type, m_error_value,
16947         m_error_traceback>: Remove.
16948         <m_error>: New member.
16949         (gdbpy_exception_to_string): Don't declare.
16950         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16951         * python/py-value.c (convert_value_from_python): Use
16952         gdbpy_err_fetch.
16953         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16954         gdbpy_exception_to_string.
16955         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16956         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16957         gdbpy_err_fetch.
16958
16959 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16960
16961         * linux-nat.c (delete_lwp_cleanup): Delete.
16962         (struct lwp_deleter): New struct.
16963         (lwp_info_up): New typedef.
16964         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16965         lwp_info_up.
16966
16967 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16968
16969         * linux-fork.c (class scoped_switch_fork_info): New class.
16970         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16971
16972 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16973
16974         * valops.c (find_overload_match): Remove use of null_cleanup, and
16975         calls to do_cleanups.
16976
16977 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16978
16979         * compile/compile-cplus-types.c
16980         (compile_cplus_instance::decl_name): Handle changes to
16981         cp_func_name.
16982         * cp-support.c (cp_func_name): Update header comment, update
16983         return type.
16984         * cp-support.h (cp_func_name): Update return type in declaration.
16985         * valops.c (find_overload_match): Move temp_func local to top
16986         level of function and change its type.  Use temp_func to hold and
16987         delete temporary string obtained from cp_func_name.
16988
16989 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16990
16991         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16992         gdb::char_vector, remove cleanup, and update uses of `msg`.
16993
16994 2019-01-03  Jim Wilson  <jimw@sifive.com>
16995
16996         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16997
16998 2019-01-02  Tom Tromey  <tom@tromey.com>
16999
17000         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
17001         (tdesc_parse_xml): Remove cleanups.
17002         * target-descriptions.h (make_cleanup_free_target_description):
17003         Don't declare.
17004         (target_desc_deleter): New struct.
17005         (target_desc_up): New typedef.
17006         * target-descriptions.c (target_desc_deleter::operator()): Rename
17007         from free_target_description.
17008         (make_cleanup_free_target_description): Remove.
17009
17010 2019-01-02  Tom Tromey  <tom@tromey.com>
17011
17012         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
17013         constructor, destructor.
17014         (linespec_parser): Remove typedef.
17015         (~linespec_parser): Rename from linespec_parser_delete.
17016         (linespec_lex_to_end, linespec_complete_label)
17017         (linespec_complete): Update.
17018         (decode_line_full): Remove cleanups.
17019         (decode_line_1): Update.
17020
17021 2019-01-02  Tom Tromey  <tom@tromey.com>
17022
17023         * python/python-internal.h (inferior_to_inferior_object): Change
17024         return type.
17025         * python/py-exitedevent.c (create_exited_event_object): Update.
17026         * python/py-inferior.c (inferior_to_inferior_object): Return
17027         gdbpy_ref.
17028         (python_new_inferior, python_inferior_deleted)
17029         (thread_to_thread_object, delete_thread_object)
17030         (build_inferior_list, gdbpy_selected_inferior): Update.
17031         * python/py-infthread.c (create_thread_object): Update.  Also fail
17032         if inferior_to_inferior_object fails.
17033
17034 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
17035
17036         * inferior.h (class inferior) <displaced_step_state>: New field.
17037         * infrun.h (struct displaced_step_state): Move here from
17038         infrun.c.  Initialize fields, add constructor.
17039         <inf>: Remove field.
17040         <reset>: New method.
17041         * infrun.c (struct displaced_step_inferior_state): Move to
17042         infrun.h.
17043         (displaced_step_inferior_states): Remove.
17044         (get_displaced_stepping_state): Adust.
17045         (displaced_step_in_progress_any_inferior): Adjust.
17046         (displaced_step_in_progress_thread): Adjust.
17047         (displaced_step_in_progress): Adjust.
17048         (add_displaced_stepping_state): Remove.
17049         (get_displaced_step_closure_by_addr): Adjust.
17050         (remove_displaced_stepping_state): Remove.
17051         (infrun_inferior_exit): Call displaced_step_state.reset.
17052         (use_displaced_stepping): Don't check for NULL.
17053         (displaced_step_prepare_throw): Call
17054         get_displaced_stepping_state.
17055         (displaced_step_fixup): Don't check for NULL.
17056         (prepare_for_detach): Don't check for NULL.
17057
17058 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17059
17060         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
17061          in case of call that did not complete.
17062
17063 2019-01-02  Andrey Utkin  <autkin@undo.io>
17064
17065         * symfile.c (find_separate_debug_file): Fix search of debug files for
17066         remote debuggee.
17067
17068 2019-01-02  Tom Tromey  <tom@tromey.com>
17069
17070         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
17071         indentation.
17072         * python/py-frame.c (frapy_older): Remove cast.
17073         (frapy_newer): Likewise.
17074         * python/py-breakpoint.c (local_setattro): Remove cast.
17075         * python/py-arch.c (archpy_name): Remove local variable.
17076         * python/py-type.c (gdbpy_lookup_type): Remove cast.
17077
17078 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
17079
17080         * unittests/basic_string_view/element_access/char/empty.cc:
17081         Fix year range in copyright header.
17082
17083 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
17084
17085         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17086         Delete.
17087         <operator==>: Update with for removed field.
17088         <hash>: Likewise.
17089         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17090         <isa_features>: ...this.
17091         <abi_features>: New field.
17092         (riscv_isa_flen): Update comment.
17093         (riscv_abi_xlen): New declaration.
17094         (riscv_abi_flen): New declaration.
17095         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17096         isa_features.
17097         (riscv_abi_xlen): New function.
17098         (riscv_isa_flen): Update to get answer from isa_features.
17099         (riscv_abi_flen): New function.
17100         (riscv_has_fp_abi): Update to get answer from abi_features.
17101         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17102         xlen and flen.
17103         (riscv_call_info) <xlen, flen>: Update comment.
17104         (riscv_call_arg_struct): Remove invalid assertions
17105         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17106         is removed.
17107         (riscv_gdbarch_init): Gather isa features and abi features
17108         separately, ensure both match on the gdbarch when reusing an old
17109         gdbarch.  Relax an error check to allow 32-bit abi float to run on
17110         a target with 64-bit float hardware.
17111
17112 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17113
17114         * source.c (search_command_helper): Stop reverse search
17115         when line 1 has been searched.
17116
17117 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17118
17119         * record-full.c (record_full_base_target::close): Rewrite
17120         record_full_core_buf_list free logic.
17121
17122 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17123
17124         * break-catch-syscall.c (print_one_catch_syscall): xfree
17125         the last text.
17126
17127 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17128
17129         * top.c (print_gdb_version): Update Copyright year in version
17130         message.
17131
17132 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17133
17134         Update copyright year range in all GDB files.
17135
17136 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
17137
17138         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
17139
17140 For older changes see ChangeLog-2018.
17141 \f
17142 Local Variables:
17143 mode: change-log
17144 left-margin: 8
17145 fill-column: 74
17146 version-control: never
17147 coding: utf-8
17148 End:
17149