gdb/ChangeLog

   1 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * macrocmd.c (extract_identifier): Return
   4         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
   5         callers.
   6
   7 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
   8
   9         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
  10
  11 2019-02-05  Tom Tromey  <tom@tromey.com>
  12
  13         * target.c (target_stack::unpush): Move assertion earlier.
  14
  15 2019-01-30  Tom Tromey  <tom@tromey.com>
  16
  17         PR python/23615:
  18         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
  19         (gdbpy_parse_and_eval): Likewise.
  20         * python/python-internal.h (gdbpy_allow_threads): New class.
  21
  22 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
  23
  24         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
  25         (aarch64_fbsd_fpregmap): Move earlier.
  26         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
  27         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
  28         instead of individual calls to trad_frame_set_reg_addr.
  29         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
  30         earlier.
  31         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
  32         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
  33         instead of individual calls to trad_frame_set_reg_addr.
  34
  35 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
  36
  37         * CONTRIBUTE: Replace contribution list with wiki link.
  38
  39 2019-01-25  Tom Tromey  <tom@tromey.com>
  40
  41         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
  42
  43 2019-01-25  Tom Tromey  <tom@tromey.com>
  44
  45         * xtensa-linux-nat.c: Fix common/ includes.
  46         * xml-support.h: Fix common/ includes.
  47         * xml-support.c: Fix common/ includes.
  48         * x86-linux-nat.c: Fix common/ includes.
  49         * windows-nat.c: Fix common/ includes.
  50         * varobj.h: Fix common/ includes.
  51         * varobj.c: Fix common/ includes.
  52         * value.c: Fix common/ includes.
  53         * valops.c: Fix common/ includes.
  54         * utils.c: Fix common/ includes.
  55         * unittests/xml-utils-selftests.c: Fix common/ includes.
  56         * unittests/utils-selftests.c: Fix common/ includes.
  57         * unittests/unpack-selftests.c: Fix common/ includes.
  58         * unittests/tracepoint-selftests.c: Fix common/ includes.
  59         * unittests/style-selftests.c: Fix common/ includes.
  60         * unittests/string_view-selftests.c: Fix common/ includes.
  61         * unittests/scoped_restore-selftests.c: Fix common/ includes.
  62         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
  63         * unittests/scoped_fd-selftests.c: Fix common/ includes.
  64         * unittests/rsp-low-selftests.c: Fix common/ includes.
  65         * unittests/parse-connection-spec-selftests.c: Fix common/
  66         includes.
  67         * unittests/optional-selftests.c: Fix common/ includes.
  68         * unittests/offset-type-selftests.c: Fix common/ includes.
  69         * unittests/observable-selftests.c: Fix common/ includes.
  70         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
  71         * unittests/memrange-selftests.c: Fix common/ includes.
  72         * unittests/memory-map-selftests.c: Fix common/ includes.
  73         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
  74         * unittests/function-view-selftests.c: Fix common/ includes.
  75         * unittests/environ-selftests.c: Fix common/ includes.
  76         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
  77         * unittests/common-utils-selftests.c: Fix common/ includes.
  78         * unittests/cli-utils-selftests.c: Fix common/ includes.
  79         * unittests/array-view-selftests.c: Fix common/ includes.
  80         * ui-file.c: Fix common/ includes.
  81         * tui/tui-io.c: Fix common/ includes.
  82         * tracepoint.h: Fix common/ includes.
  83         * tracepoint.c: Fix common/ includes.
  84         * tracefile-tfile.c: Fix common/ includes.
  85         * top.h: Fix common/ includes.
  86         * top.c: Fix common/ includes.
  87         * thread.c: Fix common/ includes.
  88         * target/waitstatus.h: Fix common/ includes.
  89         * target/waitstatus.c: Fix common/ includes.
  90         * target.h: Fix common/ includes.
  91         * target.c: Fix common/ includes.
  92         * target-memory.c: Fix common/ includes.
  93         * target-descriptions.c: Fix common/ includes.
  94         * symtab.h: Fix common/ includes.
  95         * symfile.c: Fix common/ includes.
  96         * stap-probe.c: Fix common/ includes.
  97         * spu-linux-nat.c: Fix common/ includes.
  98         * sparc-nat.c: Fix common/ includes.
  99         * source.c: Fix common/ includes.
 100         * solib.c: Fix common/ includes.
 101         * solib-target.c: Fix common/ includes.
 102         * ser-unix.c: Fix common/ includes.
 103         * ser-tcp.c: Fix common/ includes.
 104         * ser-pipe.c: Fix common/ includes.
 105         * ser-base.c: Fix common/ includes.
 106         * selftest-arch.c: Fix common/ includes.
 107         * s12z-tdep.c: Fix common/ includes.
 108         * rust-exp.y: Fix common/ includes.
 109         * rs6000-aix-tdep.c: Fix common/ includes.
 110         * riscv-tdep.c: Fix common/ includes.
 111         * remote.c: Fix common/ includes.
 112         * remote-notif.h: Fix common/ includes.
 113         * remote-fileio.h: Fix common/ includes.
 114         * remote-fileio.c: Fix common/ includes.
 115         * regcache.h: Fix common/ includes.
 116         * regcache.c: Fix common/ includes.
 117         * record-btrace.c: Fix common/ includes.
 118         * python/python.c: Fix common/ includes.
 119         * python/py-type.c: Fix common/ includes.
 120         * python/py-inferior.c: Fix common/ includes.
 121         * progspace.h: Fix common/ includes.
 122         * producer.c: Fix common/ includes.
 123         * procfs.c: Fix common/ includes.
 124         * proc-api.c: Fix common/ includes.
 125         * printcmd.c: Fix common/ includes.
 126         * ppc-linux-nat.c: Fix common/ includes.
 127         * parser-defs.h: Fix common/ includes.
 128         * osdata.c: Fix common/ includes.
 129         * obsd-nat.c: Fix common/ includes.
 130         * nat/x86-linux.c: Fix common/ includes.
 131         * nat/x86-linux-dregs.c: Fix common/ includes.
 132         * nat/x86-dregs.h: Fix common/ includes.
 133         * nat/x86-dregs.c: Fix common/ includes.
 134         * nat/ppc-linux.c: Fix common/ includes.
 135         * nat/mips-linux-watch.h: Fix common/ includes.
 136         * nat/mips-linux-watch.c: Fix common/ includes.
 137         * nat/linux-waitpid.c: Fix common/ includes.
 138         * nat/linux-ptrace.h: Fix common/ includes.
 139         * nat/linux-ptrace.c: Fix common/ includes.
 140         * nat/linux-procfs.c: Fix common/ includes.
 141         * nat/linux-personality.c: Fix common/ includes.
 142         * nat/linux-osdata.c: Fix common/ includes.
 143         * nat/linux-namespaces.c: Fix common/ includes.
 144         * nat/linux-btrace.h: Fix common/ includes.
 145         * nat/linux-btrace.c: Fix common/ includes.
 146         * nat/fork-inferior.c: Fix common/ includes.
 147         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 148         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 149         * nat/aarch64-linux.c: Fix common/ includes.
 150         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 151         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 152         * namespace.h: Fix common/ includes.
 153         * mips-linux-tdep.c: Fix common/ includes.
 154         * minsyms.c: Fix common/ includes.
 155         * mi/mi-parse.h: Fix common/ includes.
 156         * mi/mi-main.c: Fix common/ includes.
 157         * mi/mi-cmd-env.c: Fix common/ includes.
 158         * memrange.h: Fix common/ includes.
 159         * memattr.c: Fix common/ includes.
 160         * maint.h: Fix common/ includes.
 161         * maint.c: Fix common/ includes.
 162         * main.c: Fix common/ includes.
 163         * machoread.c: Fix common/ includes.
 164         * location.c: Fix common/ includes.
 165         * linux-thread-db.c: Fix common/ includes.
 166         * linux-nat.c: Fix common/ includes.
 167         * linux-fork.c: Fix common/ includes.
 168         * inline-frame.c: Fix common/ includes.
 169         * infrun.c: Fix common/ includes.
 170         * inflow.c: Fix common/ includes.
 171         * inferior.h: Fix common/ includes.
 172         * inferior.c: Fix common/ includes.
 173         * infcmd.c: Fix common/ includes.
 174         * inf-ptrace.c: Fix common/ includes.
 175         * inf-child.c: Fix common/ includes.
 176         * ia64-linux-nat.c: Fix common/ includes.
 177         * i387-tdep.c: Fix common/ includes.
 178         * i386-tdep.c: Fix common/ includes.
 179         * i386-linux-tdep.c: Fix common/ includes.
 180         * i386-linux-nat.c: Fix common/ includes.
 181         * i386-go32-tdep.c: Fix common/ includes.
 182         * i386-fbsd-tdep.c: Fix common/ includes.
 183         * i386-fbsd-nat.c: Fix common/ includes.
 184         * guile/scm-type.c: Fix common/ includes.
 185         * guile/guile.c: Fix common/ includes.
 186         * go32-nat.c: Fix common/ includes.
 187         * gnu-nat.c: Fix common/ includes.
 188         * gdbthread.h: Fix common/ includes.
 189         * gdbarch-selftests.c: Fix common/ includes.
 190         * gdb_usleep.c: Fix common/ includes.
 191         * gdb_select.h: Fix common/ includes.
 192         * gdb_bfd.c: Fix common/ includes.
 193         * gcore.c: Fix common/ includes.
 194         * fork-child.c: Fix common/ includes.
 195         * findvar.c: Fix common/ includes.
 196         * fbsd-nat.c: Fix common/ includes.
 197         * event-top.c: Fix common/ includes.
 198         * event-loop.c: Fix common/ includes.
 199         * dwarf2read.c: Fix common/ includes.
 200         * dwarf2loc.c: Fix common/ includes.
 201         * dwarf2-frame.c: Fix common/ includes.
 202         * dwarf-index-cache.c: Fix common/ includes.
 203         * dtrace-probe.c: Fix common/ includes.
 204         * disasm-selftests.c: Fix common/ includes.
 205         * defs.h: Fix common/ includes.
 206         * csky-tdep.c: Fix common/ includes.
 207         * cp-valprint.c: Fix common/ includes.
 208         * cp-support.h: Fix common/ includes.
 209         * cp-support.c: Fix common/ includes.
 210         * corelow.c: Fix common/ includes.
 211         * completer.h: Fix common/ includes.
 212         * completer.c: Fix common/ includes.
 213         * compile/compile.c: Fix common/ includes.
 214         * compile/compile-loc2c.c: Fix common/ includes.
 215         * compile/compile-cplus-types.c: Fix common/ includes.
 216         * compile/compile-cplus-symbols.c: Fix common/ includes.
 217         * command.h: Fix common/ includes.
 218         * cli/cli-dump.c: Fix common/ includes.
 219         * cli/cli-cmds.c: Fix common/ includes.
 220         * charset.c: Fix common/ includes.
 221         * build-id.c: Fix common/ includes.
 222         * btrace.h: Fix common/ includes.
 223         * btrace.c: Fix common/ includes.
 224         * breakpoint.h: Fix common/ includes.
 225         * breakpoint.c: Fix common/ includes.
 226         * ax.h:
 227         (enum agent_op): Fix common/ includes.
 228         * ax-general.c (struct aop_map): Fix common/ includes.
 229         * ax-gdb.c: Fix common/ includes.
 230         * auxv.c: Fix common/ includes.
 231         * auto-load.c: Fix common/ includes.
 232         * arm-tdep.c: Fix common/ includes.
 233         * arch/riscv.c: Fix common/ includes.
 234         * arch/ppc-linux-common.c: Fix common/ includes.
 235         * arch/i386.c: Fix common/ includes.
 236         * arch/arm.c: Fix common/ includes.
 237         * arch/arm-linux.c: Fix common/ includes.
 238         * arch/arm-get-next-pcs.c: Fix common/ includes.
 239         * arch/amd64.c: Fix common/ includes.
 240         * arch/aarch64.c: Fix common/ includes.
 241         * arch/aarch64-insn.c: Fix common/ includes.
 242         * arch-utils.c: Fix common/ includes.
 243         * amd64-windows-tdep.c: Fix common/ includes.
 244         * amd64-tdep.c: Fix common/ includes.
 245         * amd64-sol2-tdep.c: Fix common/ includes.
 246         * amd64-obsd-tdep.c: Fix common/ includes.
 247         * amd64-nbsd-tdep.c: Fix common/ includes.
 248         * amd64-linux-tdep.c: Fix common/ includes.
 249         * amd64-linux-nat.c: Fix common/ includes.
 250         * amd64-fbsd-tdep.c: Fix common/ includes.
 251         * amd64-fbsd-nat.c: Fix common/ includes.
 252         * amd64-dicos-tdep.c: Fix common/ includes.
 253         * amd64-darwin-tdep.c: Fix common/ includes.
 254         * agent.c: Fix common/ includes.
 255         * ada-lang.h: Fix common/ includes.
 256         * ada-lang.c: Fix common/ includes.
 257         * aarch64-tdep.c: Fix common/ includes.
 258
 259 2019-01-25  Tom Tromey  <tom@tromey.com>
 260
 261         * common/create-version.sh: Use common/version.h.
 262
 263 2019-01-24  Pedro Alves  <palves@redhat.com>
 264
 265         * infrun.c (signal_stop, signal_print, signal_program)
 266         (signal_catch, signal_pass): Now arrays instead of pointers.
 267         (update_signals_program_target, do_target_resume)
 268         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 269         * linux-nat.c (linux_nat_target::pass_signals)
 270         (linux_nat_target::create_inferior, linux_nat_target::attach):
 271         Adjust.
 272         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 273         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 274         * procfs.c (procfs_target::pass_signals): Adjust.
 275         * record-full.c (record_full_target::resume): Adjust.
 276         * remote.c (remote_target::pass_signals)
 277         (remote_target::program_signals): Adjust.
 278         * target-debug.h (target_debug_print_signals): Now takes a
 279         gdb::array_view as parameter.  Adjust.
 280         * target.h (target_ops) <pass_signals, program_signals>: Replace
 281         pointer and length parameters with gdb::array_view.
 282         (target_pass_signals, target_program_signals): Likewise.
 283         * target-delegates.c: Regenerate.
 284
 285 2019-01-24  Pedro Alves  <palves@redhat.com>
 286
 287         * common/forward-scope-exit.h
 288         (forward_scope_exit::forward_scope_exit): Pass arguments to
 289         m_bind_function directly, instead of creating a std::bind and
 290         copying that.
 291
 292 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 293
 294         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 295         for static members.
 296         (pass_in_v_vfp_candidate): Likewise.
 297
 298 2019-01-23  Tom Tromey  <tom@tromey.com>
 299             Pedro Alves  <palves@redhat.com>
 300
 301         * regcache.c (class regcache_invalidator): Remove.
 302         (regcache::raw_write): Use make_scope_exit.
 303
 304 2019-01-23  Tom Tromey  <tom@tromey.com>
 305
 306         * ui-out.h (class ui_out_emit_type): Update comment.
 307
 308 2019-01-23  Tom Tromey  <tom@tromey.com>
 309
 310         * infrun.c (fetch_inferior_event): Update comment.
 311
 312 2019-01-23  Tom Tromey  <tom@tromey.com>
 313             Pedro Alves  <palves@redhat.com>
 314
 315         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 316         parameter.
 317         (fetch_inferior_event): Use SCOPE_EXIT.
 318
 319
 320 2019-01-23  Tom Tromey  <tom@tromey.com>
 321             Pedro Alves  <palves@redhat.com>
 322
 323         * infrun.c (disable_thread_events): Delete.
 324         (stop_all_threads): Use SCOPE_EXIT.
 325
 326 2019-01-23  Tom Tromey  <tom@tromey.com>
 327             Pedro Alves  <palves@redhat.com>
 328
 329         * symfile.c: Include forward-scope-exit.h.
 330         (clear_symtab_users_cleanup): Replace forward declaration with
 331         a FORWARD_SCOPE_EXIT.
 332         (syms_from_objfile_1): Use the forward_scope_exit and
 333         gdb::optional instead of cleanup_function.
 334         (reread_symbols): Use the forward_scope_exit instead of
 335         cleanup_function.
 336         (clear_symtab_users_cleanup): Remove function.
 337
 338 2019-01-23  Tom Tromey  <tom@tromey.com>
 339             Pedro Alves  <palves@redhat.com>
 340
 341         * linux-nat.c: Include scope-exit.h.
 342         (cleanup_target_stop): Remove.
 343         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 344         SCOPE_EXIT.
 345
 346 2019-01-23  Tom Tromey  <tom@tromey.com>
 347             Pedro Alves  <palves@redhat.com>
 348
 349         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 350         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 351
 352 2019-01-23  Tom Tromey  <tom@tromey.com>
 353             Andrew Burgess  <andrew.burgess@embecosm.com>
 354             Pedro Alves  <palves@redhat.com>
 355
 356         * infrun.c (fetch_inferior_event): Use scope_exit.
 357         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 358         * top.c (execute_command): Use scope_exit.
 359         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 360         * utils.c (do_bpstat_clear_actions_cleanup)
 361         (make_bpstat_clear_actions_cleanup): Remove.
 362
 363 2019-01-23  Tom Tromey  <tom@tromey.com>
 364             Pedro Alves  <palves@redhat.com>
 365
 366         * infrun.c: Include "common/scope-exit.h"
 367         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 368         (wait_for_inferior): Use SCOPE_EXIT.
 369         (fetch_inferior_event): Use scope_exit.
 370
 371 2019-01-23  Tom Tromey  <tom@tromey.com>
 372             Pedro Alves  <palves@redhat.com>
 373
 374         * breakpoint.c (create_breakpoint): Remove cleanup.
 375
 376 2019-01-23  Tom Tromey  <tom@tromey.com>
 377             Andrew Burgess  <andrew.burgess@embecosm.com>
 378             Pedro Alves  <palves@redhat.com>
 379
 380 2019-01-23  Pedro Alves  <palves@redhat.com>
 381
 382         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 383
 384 2019-01-23  Pedro Alves  <palves@redhat.com>
 385             Andrew Burgess  <andrew.burgess@embecosm.com>
 386
 387         * gdbthread.h: Include "common/forward-scope-exit.h".
 388         (scoped_finish_thread_state): Redefine custom class in terms of
 389         forward_scope_exit.
 390
 391 2019-01-23  Pedro Alves  <palves@redhat.com>
 392             Andrew Burgess  <andrew.burgess@embecosm.com>
 393
 394         * common/forward-scope-exit.h: New file.
 395
 396 2019-01-23  Pedro Alves  <palves@redhat.com>
 397             Andrew Burgess  <andrew.burgess@embecosm.com>
 398             Tom Tromey  <tom@tromey.com>
 399
 400         * common/scope-exit.h: New file.
 401
 402 2019-01-23  Pedro Alves  <palves@redhat.com>
 403
 404         * common/preprocessor.h (ESC): Rename to ...
 405         (ESC_PARENS): ... this.
 406         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 407         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 408
 409 2019-01-23  Tom Tromey  <tom@tromey.com>
 410
 411         * language.h (class scoped_switch_to_sym_language_if_auto):
 412         Initialize m_lang in both cases.
 413
 414 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 415
 416         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 417         with XCNEW.
 418
 419 2019-01-22  Tom Tromey  <tom@tromey.com>
 420
 421         * corelow.c: Do not include sys/file.h.
 422
 423 2019-01-22  Tom Tromey  <tom@tromey.com>
 424
 425         * tui/tui-wingeneral.h: Include gdb_curses.h.
 426
 427 2019-01-22  Tom Tromey  <tom@tromey.com>
 428
 429         * source-cache.h (class source_cache) <get_source_lines,
 430         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 431
 432 2019-01-22  Tom Tromey  <tom@tromey.com>
 433
 434         * remote-fileio.h (struct remote_target): Declare.
 435
 436 2019-01-22  Tom Tromey  <tom@tromey.com>
 437
 438         * python/py-arch.c: Do not include py-ref.h.
 439         * python/py-bpevent.c: Do not include py-ref.h.
 440         * python/py-cmd.c: Do not include py-ref.h.
 441         * python/py-continueevent.c: Do not include py-ref.h.
 442         * python/py-event.h: Do not include py-ref.h.
 443         * python/py-evtregistry.c: Do not include py-ref.h.
 444         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 445         * python/py-frame.c: Do not include py-ref.h.
 446         * python/py-framefilter.c: Do not include py-ref.h.
 447         * python/py-function.c: Do not include py-ref.h.
 448         * python/py-infevents.c: Do not include py-ref.h.
 449         * python/py-linetable.c: Do not include py-ref.h.
 450         * python/py-objfile.c: Do not include py-ref.h.
 451         * python/py-param.c: Do not include py-ref.h.
 452         * python/py-prettyprint.c: Do not include py-ref.h.
 453         * python/py-progspace.c: Do not include py-ref.h.
 454         * python/py-symbol.c: Do not include py-ref.h.
 455         * python/py-symtab.c: Do not include py-ref.h.
 456         * python/py-type.c: Do not include py-ref.h.
 457         * python/py-unwind.c: Do not include py-ref.h.
 458         * python/py-utils.c: Do not include py-ref.h.
 459         * python/py-value.c: Do not include py-ref.h.
 460         * python/py-varobj.c: Do not include py-ref.h.
 461         * python/py-xmethods.c: Do not include py-ref.h.
 462         * python/python.c: Do not include py-ref.h.
 463         * varobj.c: Do not include py-ref.h.
 464
 465 2019-01-22  Tom Tromey  <tom@tromey.com>
 466
 467         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 468         keyword for bcache.
 469
 470 2019-01-22  Tom Tromey  <tom@tromey.com>
 471
 472         * compile/compile-cplus-types.c: Remove a comment by #include.
 473
 474 2019-01-22  Tom Tromey  <tom@tromey.com>
 475
 476         * compile/gcc-c-plugin.h: Include compile-internal.h.
 477
 478 2019-01-22  Tom Tromey  <tom@tromey.com>
 479
 480         * stabsread.c (EXTERN): Do not define.
 481         (symnum, next_symbol_text_func, processing_gcc_compilation)
 482         (within_function, global_sym_chain, global_stabs)
 483         (previous_stab_code, this_object_header_files)
 484         (n_this_object_header_files)
 485         (n_allocated_this_object_header_files): Define.
 486         * stabsread.h (EXTERN): Never define.  Use "extern".
 487
 488 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 489
 490         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 491         history_value.
 492
 493 2019-01-21  Tom Tromey  <tom@tromey.com>
 494
 495         * ui-out.c: Fix includes.
 496         * tui/tui-source.c: Fix includes.
 497         * target.c: Fix includes.
 498         * remote.c: Fix includes.
 499         * regcache.c: Fix includes.
 500         * python/py-block.c: Fix includes.
 501         * printcmd.c: Fix includes.
 502         * or1k-tdep.c: Fix includes.
 503         * mi/mi-main.c: Fix includes.
 504         * m32r-tdep.c: Fix includes.
 505         * csky-tdep.c: Fix includes.
 506         * compile/compile-cplus-types.c: Fix includes.
 507         * cli/cli-interp.c: Fix includes.
 508
 509 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 510
 511         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 512         for padding.
 513
 514 2019-01-16  Tom Tromey  <tom@tromey.com>
 515
 516         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 517         earlier.
 518         (struct objfile) <msymbols_range>: Move from top level.
 519         <msymbols>: New method.
 520         (class objfile_msymbols): Remove.
 521         * symtab.c (default_collect_symbol_completion_matches_break_on):
 522         Update.
 523         * symmisc.c (dump_msymbols): Update.
 524         * stabsread.c (scan_file_globals): Update.
 525         * objc-lang.c (info_selectors_command, info_classes_command)
 526         (find_methods): Update.
 527         * minsyms.c (find_solib_trampoline_target): Update.
 528         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 529         * coffread.c (coff_symfile_read): Update.
 530         * ada-lang.c (ada_lookup_simple_minsym)
 531         (ada_collect_symbol_completion_matches): Update.
 532
 533 2019-01-16  Tom Tromey  <tom@tromey.com>
 534
 535         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 536         type.  Remove no-argument constructor.
 537         <iterator::operator++>: Simplify.
 538         <begin>: Update.
 539         <end>: Use minimal_symbol_count.
 540
 541 2019-01-16  Tom Tromey  <tom@tromey.com>
 542
 543         * objfiles.h (struct objfile) <psymtabs>: New method.
 544         (class objfile_psymtabs): Remove.
 545         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 546         typedef.
 547         <range>: New method.
 548         (require_partial_symbols): Change return type.
 549         * psymtab.c (require_partial_symbols)
 550         (psym_expand_symtabs_matching): Update.
 551         * mdebugread.c (parse_partial_symbols): Update.
 552         * dbxread.c (dbx_end_psymtab): Update.
 553
 554 2019-01-15  Tom Tromey  <tom@tromey.com>
 555
 556         * symtab.c (lookup_objfile_from_block)
 557         (lookup_symbol_in_objfile_symtabs)
 558         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 559         (find_line_symtab, info_sources_command)
 560         (default_collect_symbol_completion_matches_break_on)
 561         (make_source_files_completion_list): Update.
 562         * symmisc.c (print_objfile_statistics, dump_objfile)
 563         (maintenance_print_symbols, maintenance_info_symtabs)
 564         (maintenance_check_symtabs, maintenance_info_line_tables):
 565         Update.
 566         * source.c (select_source_symtab)
 567         (forget_cached_source_info_for_objfile): Update.
 568         * objfiles.h (class objfile_compunits): Remove.
 569         (struct objfile) <compunits_range>: New typedef.
 570         (compunits): New method.
 571         * objfiles.c (objfile_relocate1): Update.
 572         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 573         * maint.c (count_symtabs_and_blocks): Update.
 574         * linespec.c (iterate_over_all_matching_symtabs): Update.
 575         * cp-support.c (add_symbol_overload_list_qualified): Update.
 576         * coffread.c (coff_symtab_read): Update.
 577         * ada-lang.c (add_nonlocal_symbols)
 578         (ada_collect_symbol_completion_matches)
 579         (ada_add_global_exceptions): Update.
 580
 581 2019-01-15  Tom Tromey  <tom@tromey.com>
 582
 583         * progspace.h (program_space) <objfiles_safe_range>: New
 584         typedef.
 585         <objfiles_safe>: New method.
 586         * objfiles.h (class all_objfiles_safe): Remove.
 587         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 588         * jit.c (jit_inferior_exit_hook): Update.
 589
 590 2019-01-17  Tom Tromey  <tom@tromey.com>
 591
 592         * progspace.h (program_space) <objfiles_range>: New typedef.
 593         <objfiles>: New method.
 594         <objfiles_head>: Rename from objfiles.
 595         (object_files): Update.
 596         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 597         * guile/scm-pretty-print.c
 598         (ppscm_find_pretty_printer_from_objfiles): Update.
 599         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 600         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 601         Update.
 602         * python/py-progspace.c (pspy_get_objfiles): Update.
 603         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 604         Update.
 605         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 606         (objfpy_lookup_objfile_by_build_id): Update.
 607         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 608         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 609         Update.
 610         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 611         (expand_symtab_containing_pc, lookup_objfile_from_block)
 612         (lookup_static_symbol, basic_lookup_transparent_type)
 613         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 614         (find_line_symtab, info_sources_command)
 615         (default_collect_symbol_completion_matches_break_on)
 616         (make_source_files_completion_list, find_main_name): Update.
 617         * symmisc.c (print_symbol_bcache_statistics)
 618         (print_objfile_statistics, maintenance_print_symbols)
 619         (maintenance_print_msymbols, maintenance_print_objfiles)
 620         (maintenance_info_symtabs, maintenance_check_symtabs)
 621         (maintenance_expand_symtabs, maintenance_info_line_tables):
 622         Update.
 623         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 624         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 625         (map_overlay_command, unmap_overlay_command)
 626         (simple_overlay_update, expand_symtabs_matching)
 627         (map_symbol_filenames): Update.
 628         * symfile-debug.c (set_debug_symfile): Update.
 629         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 630         Update.
 631         * source.c (select_source_symtab, forget_cached_source_info):
 632         Update.
 633         * solib.c (solib_read_symbols): Update.
 634         * solib-spu.c (append_ocl_sos): Update.
 635         * psymtab.c (maintenance_print_psymbols)
 636         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 637         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 638         * printcmd.c (info_symbol_command): Update.
 639         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 640         Update.
 641         * objfiles.h (class all_objfiles): Remove.
 642         * objfiles.c (have_partial_symbols, have_full_symbols)
 643         (have_minimal_symbols, qsort_cmp, update_section_map)
 644         (shared_objfile_contains_address_p)
 645         (default_iterate_over_objfiles_in_search_order): Update.
 646         * objc-lang.c (info_selectors_command, info_classes_command)
 647         (find_methods): Update.
 648         * minsyms.c (find_solib_trampoline_target): Update.
 649         * maint.c (maintenance_info_sections)
 650         (maintenance_translate_address, count_symtabs_and_blocks):
 651         Update.
 652         * main.c (captured_main_1): Update.
 653         * linux-thread-db.c (try_thread_db_load_from_pdir)
 654         (has_libpthread): Update.
 655         * linespec.c (iterate_over_all_matching_symtabs)
 656         (search_minsyms_for_name): Update.
 657         * jit.c (jit_find_objf_with_entry_addr): Update.
 658         * hppa-tdep.c (find_unwind_entry)
 659         (hppa_lookup_stub_minimal_symbol): Update.
 660         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 661         Update.
 662         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 663         (elf_gnu_ifunc_resolve_by_got): Update.
 664         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 665         * dwarf-index-write.c (save_gdb_index_command): Update.
 666         * cp-support.c (add_symbol_overload_list_qualified): Update.
 667         * breakpoint.c (create_overlay_event_breakpoint)
 668         (create_longjmp_master_breakpoint)
 669         (create_std_terminate_master_breakpoint)
 670         (create_exception_master_breakpoint): Update.
 671         * blockframe.c (find_pc_partial_function): Update.
 672         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 673         (ada_collect_symbol_completion_matches)
 674         (ada_add_global_exceptions): Update.
 675
 676 2019-01-17  Tom Tromey  <tom@tromey.com>
 677
 678         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 679         declare VEC.
 680         (solib_target_parse_libraries): Change return type.
 681         (library_list_start_segment, library_list_start_section)
 682         (library_list_end_library, library_list_start_library); Update.
 683         (solib_target_free_library_list): Remove.
 684         (solib_target_parse_libraries): Remove cleanup.  Change return
 685         type.
 686         (solib_target_current_sos): Update.
 687
 688 2019-01-17  Tom Tromey  <tromey@bapiya>
 689
 690         * valprint.c: Replace "the the" with "the".
 691         * symtab.c: Replace "the the" with "the".
 692         * solib.c: Replace "the the" with "the".
 693         * solib-dsbt.c: Replace "the the" with "the".
 694         * linespec.c: Replace "the the" with "the".
 695         * dwarf2loc.h: Replace "the the" with "the".
 696         * amd64-windows-tdep.c: Replace "the the" with "the".
 697         * aarch64-tdep.c: Replace "the the" with "the".
 698
 699 2019-01-16  Keith Seitz  <keiths@redhat.com>
 700
 701         PR gdb/23773
 702         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 703         <builder>: Rename to ..
 704         <m_builder>: ... this and make private.
 705         (dwarf2_cu::get_builder): New method.  Change all users of
 706         `builder' to use this method.
 707         (dwarf2_start_symtab): Move to ...
 708         (dwarf2_cu::start_symtab): ... here.  Update all callers
 709         (setup_type_unit_groups): Move to ...
 710         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 711         callers.
 712         (dwarf2_cu::reset_builder): New method.
 713         (process_full_compunit, process_full_type_unit): Use
 714         dwarf2_cu::reset_builder.
 715         (follow_die_offset): Record the ancestor CU if it is different
 716         from the followed DIE's CU.
 717         (follow_die_sig_1): Likewise.
 718
 719 2019-01-15  Tom Tromey  <tom@tromey.com>
 720
 721         * remote.c (class remote_state) <buf>: Now a char_vector.
 722         <buf_size>: Remove.
 723         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 724         parameter.
 725         (remote_target::getpkt_or_notif_sane_1)
 726         (remote_target::getpkt_sane)
 727         (remote_target::getpkt_or_notif_sane): Likewise.
 728         (class remote_target) <putpkt>: New overload.
 729         (remote_target::read_frame): Change type of "buf_p".  Remove
 730         sizeof_p parameter.
 731         (packet_ok): New overload.
 732         (packet_check_result): New overload.
 733         Update all uses.
 734
 735 2019-01-14  Tom Tromey  <tom@tromey.com>
 736
 737         * remote-notif.c (handle_notification, remote_notif_ack)
 738         (remote_notif_parse): Make "buf" const.
 739         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 740         const.
 741         (remote_notif_parse, remote_notif_ack, handle_notification):
 742         Likewise.
 743         * remote.c (remote_notif_stop_parse): Make "buf" const.
 744         (remote_target::remote_parse_stop_reply): Make "buf" const.
 745         (remote_notif_stop_ack): Make "buf" const.
 746
 747 2019-01-14  Tom Tromey  <tom@tromey.com>
 748
 749         * remote.c (remote_console_output): Make parameter const.
 750
 751 2019-01-14  Tom Tromey  <tom@tromey.com>
 752
 753         * target-debug.h (target_debug_print_signals): Constify.
 754         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 755         * procfs.c (procfs_target::pass_signals): Update.
 756         * linux-nat.c (linux_nat_target::pass_signals): Update.
 757         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 758         * target-delegates.c: Rebuild.
 759         * remote.c (remote_target::program_signals): Update.
 760         (remote_target::pass_signals): Update.
 761         * target.c (target_pass_signals): Constify argument.
 762         (target_program_signals): Likewise.
 763         * target.h (struct target_ops) <pass_signals, program_signals>:
 764         Constify argument.
 765         (target_pass_signals, target_program_signals): Constify argument.
 766
 767 2019-01-14  Tom Tromey  <tom@tromey.com>
 768
 769         PR tui/28819:
 770         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 771
 772 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 773
 774         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 775         field.
 776         * rs6000-tdep.c: Include reggroups.h.
 777         (IS_V_ALIAS_PSEUDOREG): Define.
 778         (rs6000_register_name): Return names for the "vX" aliases.
 779         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 780         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 781         aliases.  Call default_register_reggroup_p for all other
 782         pseudo-registers.
 783         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 784         New functions.
 785         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 786         Handle "vX" aliases.
 787         (v_alias_pseudo_register_collect): New function.
 788         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 789         (rs6000_gdbarch_init): Initialize "vX" aliases as
 790         pseudo-registers.  Restore registration of
 791         rs6000_pseudo_register_reggroup_p with
 792         set_tdesc_pseudo_register_reggroup_p.
 793
 794 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 795
 796         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 797         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 798         set_gdbarch_num_pseudo_regs.
 799
 800 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 801
 802         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 803         Remove arg prefixname, add do_set and do_show.
 804         Add member functions set_list and show_list.
 805         * cli/cli-style.c (class cli_style_option): Update accordingly.
 806         (style_set_list): Move to file scope.
 807         (style_show_list): Likewise.
 808         (set_style): Call help_list.
 809         (show_style): Call cmd_show_list.
 810         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 811         Update to use the new macro.
 812
 813 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 814
 815         * ada-lang.c (_initialize_ada_language): Expand the help text
 816         for the "catch exception" command.
 817
 818 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 819
 820         * symtab.c (matching_obj_sections): Initialize obj,
 821         declare it closer to its usage.
 822
 823 2019-01-10  Tom Tromey  <tom@tromey.com>
 824
 825         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 826         (basic_inf_threads_range): Remove.
 827         (inf_threads_range, inf_non_exited_threads_range)
 828         (safe_inf_threads_range): Use next_adapter.
 829
 830 2019-01-10  Keith Seitz  <keiths@redhat.com>
 831
 832         PR gdb/23712
 833         PR symtab/23010
 834         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 835         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 836
 837 2019-01-10  Keith Seitz  <keiths@redhat.com>
 838
 839         PR gdb/23712
 840         PR symtab/23010
 841         * dictionary.c (pending_to_vector): Remove.
 842         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 843         Remove _1 suffix, replacing functions of the same name.  Update
 844         all callers.
 845         (dict_create_hashed, dict_create_hashed_expandable)
 846         (dict_create_linear, dict_create_linear_expandable, dict_free)
 847         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 848         Make functions static.
 849
 850 2019-01-10  Keith Seitz  <keiths@redhat.com>
 851
 852         PR gdb/23712
 853         PR symtab/23010
 854         * dictionary.h (struct dictionary): Replace declaration with
 855         multidictionary.
 856         (dict_create_hashed, dict_create_hashed_expandable)
 857         (dict_create_linear, dict_create_linear_expandable)
 858         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 859         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 860         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 861         taking multidictionary argument.
 862         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 863         * block.h (struct block) <dict>: Change to multidictionary
 864         and rename `multidict'.
 865         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 866         symmisc.c: Update all dictionary references to multidictionary.
 867
 868 2019-01-10  Keith Seitz  <keiths@redhat.com>
 869
 870         PR gdb/23712
 871         PR symtab/23010
 872         * dictionary.c: Include unordered_map.
 873         (pending_to_vector): New function.
 874         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 875         Rewrite the non-"_1" functions to take vector instead
 876         of linked list.
 877         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 878         "new" _1 versions of the same name.
 879         (multidictionary): Define.
 880         (std::hash<enum language): New definition.
 881         (collate_pending_symbols_by_language, mdict_create_hashed)
 882         (mdict_create_hashed_expandable, mdict_create_linear)
 883         (mdict_create_linear_expandable, mdict_free)
 884         (find_language_dictionary, create_new_language_dictionary)
 885         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 886         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 887         (mdict_size, mdict_empty): New functions.
 888         * dictionary.h (mdict_iterator): Define.
 889
 890 2019-01-10  Pedro Alves  <palves@redhat.com>
 891
 892         * breakpoint.c (read_uploaded_action)
 893         (create_tracepoint_from_upload): Adjust to use
 894         gdb::unique_xmalloc_ptr.
 895         * ctf.c (ctf_write_uploaded_tp):
 896         (SET_ARRAY_FIELD): Use emplace_back.
 897         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 898         * tracefile-tfile.c (tfile_write_uploaded_tp):
 899         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 900         gdb::unique_xmalloc_ptr.
 901         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 902         at_string, cond_string, cmd_strings>: Replace char pointers
 903         with gdb::unique_xmalloc_ptr.
 904
 905 2019-01-10  Pedro Alves  <palves@redhat.com>
 906
 907         * solib-target.c (library_list_start_library): Don't xstrdup name.
 908
 909 2019-01-10  Pedro Alves  <palves@redhat.com>
 910
 911         * mdebugread.c (parse_partial_symbols): Use
 912         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 913
 914 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 915
 916         * linux-fork.c (scoped_switch_fork_info)
 917         <~scoped_switch_fork_info>: Fix incorrect variable name.
 918
 919 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 920
 921         * linux-fork.c (scoped_switch_fork_info)
 922         <scoped_switch_fork_info>: Make explicit.
 923         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 924
 925 2019-01-10  Tom Tromey  <tom@tromey.com>
 926
 927         * objfiles.h (objfile::reset_psymtabs): Update.
 928         * objfiles.c (objfile::objfile): Update.
 929         * psymtab.h (psymtab_storage::obstack): Update.
 930         (psymtab_storage::m_obstack): Use gdb::optional.
 931         (class psymtab_storage): Update comment.  Remove objfile
 932         parameter.
 933         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 934
 935 2019-01-10  Tom Tromey  <tom@tromey.com>
 936
 937         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 938         <free_psymtabs>: Now private.
 939         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 940         (allocate_psymtab): Use new method.
 941
 942 2019-01-10  Tom Tromey  <tom@tromey.com>
 943
 944         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 945         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 946         * mdebugread.c (parse_partial_symbols): Use
 947         allocate_dependencies.
 948         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 949         allocate_dependencies.
 950         (process_psymtab_comp_unit_reader)
 951         (build_type_psymtab_dependencies): Likewise.
 952         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 953
 954 2019-01-10  Tom Tromey  <tom@tromey.com>
 955
 956         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 957         PSYMBOL_SET_LANGUAGE.
 958         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 959
 960 2019-01-10  Tom Tromey  <tom@tromey.com>
 961
 962         * psymtab.h (psymtab_storage::obstack): New method.
 963         <m_obstack>: Rename from obstack; now private.
 964         * psymtab.c (psymtab_storage): Update.
 965         * dwarf2read.c (create_addrmap_from_index)
 966         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 967         Update.
 968
 969 2019-01-10  Tom Tromey  <tom@tromey.com>
 970
 971         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 972         * objfiles.h (objfile::reset_psymtabs): New method.
 973
 974 2019-01-10  Tom Tromey  <tom@tromey.com>
 975
 976         * symmisc.c (print_symbol_bcache_statistics): Update.
 977         (print_objfile_statistics): Update.
 978         * symfile.c (reread_symbols): Update.
 979         * psymtab.h (class psymtab_storage): New.
 980         * psymtab.c (psymtab_storage): New constructor.
 981         (~psymtab_storage): New destructor.
 982         (require_partial_symbols): Update.
 983         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 984         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 985         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 986         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 987         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 988         (start_psymtab_common, end_psymtab_common)
 989         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 990         (allocate_psymtab): Update.
 991         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 992         Update.
 993         (dump_psymtab_addrmap, maintenance_print_psymbols)
 994         (maintenance_check_psymtabs): Update.
 995         (class objfile_psymtabs): Move to objfiles.h.
 996         * psympriv.h (discard_psymtab): Now inline.
 997         (psymtab_discarder::psymtab_discarder): Update.
 998         (psymtab_discarder::~psymtab_discarder): Update.
 999         (ALL_OBJFILE_PSYMTABS): Rewrite.
1000         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1001         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1002         Remove fields.
1003         <partial_symtabs>: New field.
1004         (class objfile_psymtabs): Move from psymtab.h.  Update.
1005         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1006         psymbol_cache.
1007         (objfile::~objfile): Don't destroy psymbol_cache.
1008         * mdebugread.c (parse_partial_symbols): Update.
1009         * dwarf2read.c (create_addrmap_from_index)
1010         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1011         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1012         (add_partial_subprogram, dwarf2_ranges_read): Update.
1013         * dwarf-index-write.c (write_address_map)
1014         (write_one_signatured_type, recursively_write_psymbols)
1015         (class debug_names, class debug_names, write_psymtabs_to_index):
1016         Update.
1017
1018 2019-01-10  Tom Tromey  <tom@tromey.com>
1019
1020         * symtab.h (SYMBOL_SET_NAMES): Update.
1021         (symbol_set_names): Update.
1022         (MSYMBOL_SET_NAMES): Update.
1023         * symtab.c (symbol_set_names): Change argument to be an
1024         objfile_per_bfd_storage.
1025         * psymtab.c (add_psymbol_to_bcache): Update.
1026         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1027
1028 2019-01-10  Tom Tromey  <tom@tromey.com>
1029
1030         * symtab.c (create_demangled_names_hash): Change argument to be an
1031         objfile_per_bfd_storage.
1032         (symbol_set_names): Update.
1033
1034 2019-01-10  Tom Tromey  <tom@tromey.com>
1035
1036         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1037         init_psymbol_list.
1038         * psymtab.c (init_psymbol_list): Do nothing if already called.
1039         * psympriv.h (init_psymbol_list): Add comment.
1040         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1041         init_psymbol_list.
1042         * dbxread.c (dbx_symfile_read): Unconditionally call
1043         init_psymbol_list.
1044
1045 2019-01-10  Tom Tromey  <tom@tromey.com>
1046
1047         * xcoffread.c (scan_xcoff_symtab): Update.
1048         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1049         "where".
1050         * mdebugread.c (parse_partial_symbols)
1051         (handle_psymbol_enumerators): Update.
1052         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1053         * dbxread.c (read_dbx_symtab): Update.
1054         * psympriv.h (psymbol_placement): New enum.
1055         (add_psymbol_to_list): Update.
1056
1057 2019-01-10  Tom Tromey  <tom@tromey.com>
1058
1059         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1060         static_psymbols parameters.
1061         (scan_xcoff_symtab): Update.
1062         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1063         static_psymbols parameters.
1064         * psympriv.h (start_psymtab_common): Update.
1065         * mdebugread.c (parse_partial_symbols): Update.
1066         * dwarf2read.c (create_partial_symtab): Update.
1067         * dbxread.c (read_dbx_symtab): Update.
1068         (start_psymtab): Remove global_psymbols and static_psymbols
1069         parameters.
1070
1071 2019-01-10  Tom Tromey  <tom@tromey.com>
1072
1073         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1074         * psymtab.c (allocate_psymtab): Add comment.
1075         * psympriv.h (allocate_psymtab): Add comment.
1076         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1077         initializations.
1078         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1079
1080 2019-01-10  Tom Tromey  <tom@tromey.com>
1081
1082         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1083         Don't declare.
1084         * mipsread.c: Include mdebugread.h.
1085         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1086         Declare.
1087         * elfread.c: Include mdebugread.h.
1088
1089 2019-01-09  Tom Tromey  <tom@tromey.com>
1090
1091         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1092         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1093         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1094         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1095         (psym_lookup_symbol, psym_find_last_source_symtab)
1096         (psym_forget_cached_source_info, psym_print_stats)
1097         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1098         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1099         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1100         (psym_find_compunit_symtab_by_address)
1101         (maintenance_print_psymbols, maintenance_info_psymtabs)
1102         (maintenance_check_psymtabs): Use ranged for.
1103         * psymtab.h (class objfile_psymtabs): New.
1104         (require_partial_symbols): Return objfile_psymtabs.
1105         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1106
1107 2019-01-09  Tom Tromey  <tom@tromey.com>
1108
1109         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1110         (find_pc_mapped_section, list_overlays_command)
1111         (map_overlay_command, unmap_overlay_command)
1112         (simple_overlay_update): Use all_objfiles.
1113         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1114         * printcmd.c (info_symbol_command): Use all_objfiles.
1115         * objfiles.h (ALL_OBJSECTIONS): Remove.
1116         * maint.c (maintenance_translate_address): Use all_objfiles.
1117         * gcore.c (gcore_create_callback): Use all_objfiles.
1118         (objfile_find_memory_regions): Likewise.
1119
1120 2019-01-09  Tom Tromey  <tom@tromey.com>
1121
1122         * symtab.c (find_line_symtab, info_sources_command)
1123         (make_source_files_completion_list): Use objfile_compunits.
1124         * source.c (select_source_symtab): Use objfile_compunits.
1125         * objfiles.h (struct objfile): Update comment.
1126         (ALL_OBJFILES): Remove.
1127         (ALL_FILETABS): Remove.
1128         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1129         objfile_compunits.
1130
1131 2019-01-09  Tom Tromey  <tom@tromey.com>
1132
1133         * symmisc.c (print_objfile_statistics, dump_objfile)
1134         (maintenance_print_symbols): Use compunit_filetabs.
1135         * source.c (forget_cached_source_info_for_objfile): Use
1136         compunit_filetabs.
1137         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1138         (ALL_FILETABS): Use compunit_filetabs.
1139         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1140         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1141
1142 2019-01-09  Tom Tromey  <tom@tromey.com>
1143
1144         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1145         (compunit_filetabs): New.
1146         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1147         compunit_filetabs.
1148         (info_sources_command, make_source_files_completion_list): Remove
1149         declaration.
1150         * symmisc.c (print_objfile_statistics, dump_objfile)
1151         (maintenance_print_symbols): Remove declaration.
1152         (maintenance_info_symtabs): Use compunit_filetabs.
1153         (maintenance_info_line_tables): Likewise.
1154         * source.c (select_source_symtab): Change local variable name.
1155         (forget_cached_source_info_for_objfile): Remove declaration.
1156         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1157         * objfiles.c (objfile_relocate1): Remove declaration.
1158         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1159         declaration.
1160         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1161         * coffread.c (coff_symtab_read): Remove declaration.
1162         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1163         compunit_filetabs.
1164
1165 2019-01-09  Tom Tromey  <tom@tromey.com>
1166
1167         * symtab.c (lookup_objfile_from_block)
1168         (find_pc_sect_compunit_symtab, search_symbols)
1169         (default_collect_symbol_completion_matches_break_on): Use
1170         objfile_compunits.
1171         * objfiles.h (ALL_COMPUNITS): Remove.
1172         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1173         * cp-support.c (add_symbol_overload_list_qualified): Use
1174         objfile_compunits.
1175         * ada-lang.c (ada_collect_symbol_completion_matches)
1176         (ada_add_global_exceptions): Use objfile_compunits.
1177
1178 2019-01-09  Tom Tromey  <tom@tromey.com>
1179
1180         * source.c (select_source_symtab)
1181         (forget_cached_source_info_for_objfile): Remove declaration.
1182         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1183         declaration.
1184         * maint.c (count_symtabs_and_blocks): Remove declaration.
1185         * cp-support.c (add_symbol_overload_list_qualified): Remove
1186         declaration.
1187         * coffread.c (coff_symtab_read): Remove declaration.
1188         * symtab.c (lookup_symbol_in_objfile_symtabs)
1189         (basic_lookup_transparent_type_1): Use objfile_compunits.
1190         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1191         (info_sources_command, search_symbols)
1192         (default_collect_symbol_completion_matches_break_on)
1193         (make_source_files_completion_list): Remove declaration.
1194         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1195         (ada_collect_symbol_completion_matches)
1196         (ada_add_global_exceptions): Remove declaration.
1197         * linespec.c (iterate_over_all_matching_symtabs): Use
1198         objfile_compunits.
1199         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1200         (class objfile_compunits): New.
1201         (ALL_COMPUNITS): Use objfile_compunits.
1202         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1203         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1204         objfile_compunits.
1205         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1206
1207 2019-01-09  Tom Tromey  <tom@tromey.com>
1208
1209         * symtab.c (search_symbols)
1210         (default_collect_symbol_completion_matches_break_on): Use
1211         objfile_msymbols.
1212         * ada-lang.c (ada_lookup_simple_minsym)
1213         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1214         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1215         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1216         objfile_msymbols.
1217         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1218         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1219         * objc-lang.c (find_methods): Use objfile_msymbols.
1220         (info_selectors_command, info_classes_command): Likewise.
1221         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1222         * objfiles.h (class objfile_msymbols): New.
1223         (ALL_OBJFILE_MSYMBOLS): Remove.
1224         (ALL_MSYMBOLS): Remove.
1225
1226 2019-01-09  Tom Tromey  <tom@tromey.com>
1227
1228         * common/next-iterator.h (next_adapter): Add Iterator template
1229         parameter.
1230         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1231         (class all_objfiles_safe): New.
1232         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1233         * objfiles.c (put_objfile_before): Update comment.
1234         (add_separate_debug_objfile): Likewise.
1235         (free_all_objfiles): Use all_objfiles_safe.
1236         (objfile_purge_solibs): Likewise.
1237
1238 2019-01-09  Tom Tromey  <tom@tromey.com>
1239
1240         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1241         (expand_symtab_containing_pc, lookup_static_symbol)
1242         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1243         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1244         all_objfiles.
1245         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1246         * breakpoint.c (create_overlay_event_breakpoint)
1247         (create_longjmp_master_breakpoint)
1248         (create_std_terminate_master_breakpoint)
1249         (create_exception_master_breakpoint): Use all_objfiles.
1250         * linux-thread-db.c (try_thread_db_load_from_pdir)
1251         (has_libpthread): Use all_objfiles.
1252         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1253         * linespec.c (iterate_over_all_matching_symtabs)
1254         (search_minsyms_for_name): Use all_objfiles.
1255         * maint.c (maintenance_info_sections): Use all_objfiles.
1256         * main.c (captured_main_1): Use all_objfiles.
1257         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1258         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1259         * guile/scm-pretty-print.c
1260         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1261         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1262         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1263         (maintenance_print_msymbols): Use all_objfiles.
1264         * source.c (select_source_symtab): Use all_objfiles.
1265         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1266         * symfile.c (remove_symbol_file_command)
1267         (expand_symtabs_matching, map_symbol_filenames): Use
1268         all_objfiles.
1269         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1270         all_objfiles.
1271         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1272         * objc-lang.c (find_methods): Use all_objfiles.
1273         * objfiles.c (have_partial_symbols, have_full_symbols)
1274         (have_minimal_symbols, qsort_cmp)
1275         (default_iterate_over_objfiles_in_search_order): Use
1276         all_objfiles.
1277         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1278         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1279         (maintenance_check_psymtabs): Use all_objfiles.
1280         (ALL_PSYMTABS): Remove.
1281         * compile/compile-object-run.c (do_module_cleanup): Use
1282         all_objfiles.
1283         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1284         * cp-support.c (add_symbol_overload_list_qualified): Use
1285         all_objfiles.
1286         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1287         Use all_objfiles.
1288         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1289         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1290         all_objfiles.
1291         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1292         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1293         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1294         Uses all_objfiles.
1295         * solib.c (solib_read_symbols): Use all_objfiles
1296
1297 2019-01-09  Tom Tromey  <tom@tromey.com>
1298
1299         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1300         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1301         all_objfiles.
1302         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1303         * symmisc.c (print_symbol_bcache_statistics)
1304         (print_objfile_statistics, maintenance_print_objfiles)
1305         (maintenance_info_symtabs, maintenance_check_symtabs)
1306         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1307         all_objfiles.
1308         * source.c (forget_cached_source_info): Use all_objfiles.
1309         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1310         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1311         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1312         * objfiles.c (update_section_map): Use all_objfiles.
1313         (shared_objfile_contains_address_p): Likewise.
1314         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1315         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1316
1317 2019-01-09  Tom Tromey  <tom@tromey.com>
1318
1319         * common/next-iterator.h: New file.
1320         * objfiles.h (class all_objfiles): New.
1321         (struct objfile_iterator): New.
1322
1323 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1324
1325         * NEWS: Move the description of the changed "frame", "select-frame",
1326          and "info frame" commands to the Changed commands section.
1327
1328 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1329
1330         * gdbtypes.c (check_stub_method_group): Remove handling of old
1331         mangling schemes.
1332         * linespec.c (find_methods): Likewise.
1333         * stabsread.c (read_member_functions): Likewise.
1334         * valops.c (search_struct_method): Likewise.
1335         (value_struct_elt_for_reference): Likewise.
1336         * NEWS: Mention this change.
1337
1338 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1339
1340         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1341         print_source_lines.
1342         * source.c (print_source_lines_base): Update line number check.
1343         (print_source_lines): New function.
1344         (source_lines_range::source_lines_range): New function.
1345         * source.h (class source_lines_range): New class.
1346         (print_source_lines): New declaration.
1347
1348 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1349
1350         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1351
1352 2019-01-08  Tom Tromey  <tom@tromey.com>
1353             Simon Marchi  <simon.marchi@ericsson.com>
1354
1355         PR gdb/24060
1356         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1357         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1358         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1359         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1360         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1361         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1362
1363 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1364
1365         * source.c (select_source_symtab): Move header comment to
1366         declaration in source.h.
1367         (forget_cached_source_info_for_objfile): Likewise.
1368         (forget_cached_source_info): Likewise.
1369         (identify_source_line): Likewise.
1370         * source.h (identify_source_line): Move declaration from symtab.h
1371         and add comment from source.c
1372         (print_source_lines): Likewise.
1373         (forget_cached_source_info_for_objfile): Likewise.
1374         (forget_cached_source_info): Likewise.
1375         (select_source_symtab): Likewise.
1376         (enum print_source_lines_flag): Move definition from symtab.h.
1377         * symtab.h (identify_source_line): Move declaration to source.h.
1378         (print_source_lines): Likewise.
1379         (forget_cached_source_info_for_objfile): Likewise.
1380         (forget_cached_source_info): Likewise.
1381         (select_source_symtab): Likewise.
1382         (enum print_source_lines_flag): Move definition to source.h.
1383         * tui/tui-hooks.c: Add 'source.h' include.
1384
1385 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1386
1387         * source.c (print_source_lines_base): Handle requests to print
1388         reverse line number sequences, and guard against empty lines
1389         string.
1390
1391 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1392
1393         * source.c (print_source_lines_base): Fix skip of '\r' if next
1394         character is '\n'.
1395
1396 2019-01-06  Tom Tromey  <tom@tromey.com>
1397
1398         * c-exp.y (struct c_parse_state) <macro_original_text,
1399         expansion_obstack>: New member.
1400         (macro_original_text, expansion_obstack): Remove globals.
1401         (scan_macro_expansion, scanning_macro_expansion)
1402         (finished_macro_expansion): Update.
1403         (scan_macro_cleanup): Remove.
1404         (yylex, c_parse): Update.
1405
1406 2019-01-06  Tom Tromey  <tom@tromey.com>
1407
1408         * c-exp.y (struct c_parse_state) <strings>: New member.
1409         (operator_stoken): Update.
1410
1411 2019-01-06  Tom Tromey  <tom@tromey.com>
1412
1413         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1414         (union type_stack_elt) <typelist_val>: Now a pointer to
1415         std::vector.
1416         (type_stack_cleanup): Don't declare.
1417         (push_typelist): Update.
1418         * parse.c (pop_typelist): Return a std::vector.
1419         (push_typelist): Take a std::vector.
1420         (follow_types): Update.  Do not free args.
1421         (type_stack_cleanup): Remove.
1422         * c-exp.y (struct c_parse_state): New.
1423         (cpstate): New global.
1424         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1425         (nonempty_typelist): Update.
1426         (func_mod): Create a new vector.
1427         (c_parse): Create a c_parse_state.
1428         (check_parameter_typelist): Do not delete params.
1429         (function_method): Update.  Do not delete type_list.
1430
1431 2019-01-06  Tom Tromey  <tom@tromey.com>
1432
1433         PR gdb/28155:
1434         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1435         check_typedef.
1436         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1437         (print_return_value): Likewise.
1438
1439 2019-01-05  Tom Tromey  <tom@tromey.com>
1440
1441         * contrib/cleanup_check.py: Remove.
1442         * contrib/gcc-with-excheck: Remove.
1443         * contrib/exsummary.py: Remove.
1444         * contrib/excheck.py: Remove.
1445
1446 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1447
1448         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1449         NULL. Initialize tpprev to NULL instead of assigning it
1450         to NULL on the next statement.
1451         * windows-nat.c (windows_delete_thread): Remove check for
1452         main_thread_id before printing thread exit notifications.
1453         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1454         Remove thread ID check against main_thread_id.
1455         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1456         windows_delete_thread.
1457         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1458
1459 2019-01-04  Tom Tromey  <tom@tromey.com>
1460
1461         * compile/compile.c (_initialize_compile): Use upper case for
1462         metasyntactic variables.
1463         * symmisc.c (_initialize_symmisc): Use upper case for
1464         metasyntactic variables.
1465         * psymtab.c (_initialize_psymtab): Use upper case for
1466         metasyntactic variables.
1467         * demangle.c (demangle_command): Use upper case for metasyntactic
1468         variables.
1469         (_initialize_demangler): Likewise.
1470         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1471         variables.
1472
1473 2019-01-03  Tom Tromey  <tom@tromey.com>
1474
1475         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1476
1477 2019-01-03  Tom Tromey  <tom@tromey.com>
1478
1479         * python/py-symtab.c (salpy_str): Update.
1480         (struct salpy_sal_object) <symtab>: Now a PyObject.
1481         (salpy_dealloc): Update.
1482         (del_objfile_sal): Use gdbpy_ref.
1483
1484 2019-01-03  Tom Tromey  <tom@tromey.com>
1485
1486         * python/py-type.c (convert_field): Use new_reference.  Return
1487         gdbpy_ref.
1488         (make_fielditem): Return gdbpy_ref.
1489         (typy_fields): Update.
1490         (typy_getitem): Update.
1491         (field_name): Return gdbpy_ref.  Use new_reference.
1492         (typy_iterator_iternext): Update.
1493
1494 2019-01-03  Tom Tromey  <tom@tromey.com>
1495
1496         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1497
1498 2019-01-03  Tom Tromey  <tom@tromey.com>
1499
1500         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1501         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1502         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1503         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1504         (pspy_set_type_printers): Likewise.
1505         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1506         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1507         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1508         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1509         (objfpy_set_type_printers): Likewise.
1510
1511 2019-01-03  Tom Tromey  <tom@tromey.com>
1512
1513         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1514         (gdbpy_print_stack): Use gdbpy_err_fetch.
1515         * python/python-internal.h (class gdbpy_err_fetch): New class.
1516         (class gdbpy_enter) <m_error_type, m_error_value,
1517         m_error_traceback>: Remove.
1518         <m_error>: New member.
1519         (gdbpy_exception_to_string): Don't declare.
1520         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1521         * python/py-value.c (convert_value_from_python): Use
1522         gdbpy_err_fetch.
1523         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1524         gdbpy_exception_to_string.
1525         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1526         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1527         gdbpy_err_fetch.
1528
1529 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1530
1531         * linux-nat.c (delete_lwp_cleanup): Delete.
1532         (struct lwp_deleter): New struct.
1533         (lwp_info_up): New typedef.
1534         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1535         lwp_info_up.
1536
1537 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1538
1539         * linux-fork.c (class scoped_switch_fork_info): New class.
1540         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1541
1542 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1543
1544         * valops.c (find_overload_match): Remove use of null_cleanup, and
1545         calls to do_cleanups.
1546
1547 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1548
1549         * compile/compile-cplus-types.c
1550         (compile_cplus_instance::decl_name): Handle changes to
1551         cp_func_name.
1552         * cp-support.c (cp_func_name): Update header comment, update
1553         return type.
1554         * cp-support.h (cp_func_name): Update return type in declaration.
1555         * valops.c (find_overload_match): Move temp_func local to top
1556         level of function and change its type.  Use temp_func to hold and
1557         delete temporary string obtained from cp_func_name.
1558
1559 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1560
1561         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1562         gdb::char_vector, remove cleanup, and update uses of `msg`.
1563
1564 2019-01-03  Jim Wilson  <jimw@sifive.com>
1565
1566         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1567
1568 2019-01-02  Tom Tromey  <tom@tromey.com>
1569
1570         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1571         (tdesc_parse_xml): Remove cleanups.
1572         * target-descriptions.h (make_cleanup_free_target_description):
1573         Don't declare.
1574         (target_desc_deleter): New struct.
1575         (target_desc_up): New typedef.
1576         * target-descriptions.c (target_desc_deleter::operator()): Rename
1577         from free_target_description.
1578         (make_cleanup_free_target_description): Remove.
1579
1580 2019-01-02  Tom Tromey  <tom@tromey.com>
1581
1582         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1583         constructor, destructor.
1584         (linespec_parser): Remove typedef.
1585         (~linespec_parser): Rename from linespec_parser_delete.
1586         (linespec_lex_to_end, linespec_complete_label)
1587         (linespec_complete): Update.
1588         (decode_line_full): Remove cleanups.
1589         (decode_line_1): Update.
1590
1591 2019-01-02  Tom Tromey  <tom@tromey.com>
1592
1593         * python/python-internal.h (inferior_to_inferior_object): Change
1594         return type.
1595         * python/py-exitedevent.c (create_exited_event_object): Update.
1596         * python/py-inferior.c (inferior_to_inferior_object): Return
1597         gdbpy_ref.
1598         (python_new_inferior, python_inferior_deleted)
1599         (thread_to_thread_object, delete_thread_object)
1600         (build_inferior_list, gdbpy_selected_inferior): Update.
1601         * python/py-infthread.c (create_thread_object): Update.  Also fail
1602         if inferior_to_inferior_object fails.
1603
1604 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1605
1606         * inferior.h (class inferior) <displaced_step_state>: New field.
1607         * infrun.h (struct displaced_step_state): Move here from
1608         infrun.c.  Initialize fields, add constructor.
1609         <inf>: Remove field.
1610         <reset>: New method.
1611         * infrun.c (struct displaced_step_inferior_state): Move to
1612         infrun.h.
1613         (displaced_step_inferior_states): Remove.
1614         (get_displaced_stepping_state): Adust.
1615         (displaced_step_in_progress_any_inferior): Adjust.
1616         (displaced_step_in_progress_thread): Adjust.
1617         (displaced_step_in_progress): Adjust.
1618         (add_displaced_stepping_state): Remove.
1619         (get_displaced_step_closure_by_addr): Adjust.
1620         (remove_displaced_stepping_state): Remove.
1621         (infrun_inferior_exit): Call displaced_step_state.reset.
1622         (use_displaced_stepping): Don't check for NULL.
1623         (displaced_step_prepare_throw): Call
1624         get_displaced_stepping_state.
1625         (displaced_step_fixup): Don't check for NULL.
1626         (prepare_for_detach): Don't check for NULL.
1627
1628 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1629
1630         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1631          in case of call that did not complete.
1632
1633 2019-01-02  Andrey Utkin  <autkin@undo.io>
1634
1635         * symfile.c (find_separate_debug_file): Fix search of debug files for
1636         remote debuggee.
1637
1638 2019-01-02  Tom Tromey  <tom@tromey.com>
1639
1640         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1641         indentation.
1642         * python/py-frame.c (frapy_older): Remove cast.
1643         (frapy_newer): Likewise.
1644         * python/py-breakpoint.c (local_setattro): Remove cast.
1645         * python/py-arch.c (archpy_name): Remove local variable.
1646         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1647
1648 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1649
1650         * unittests/basic_string_view/element_access/char/empty.cc:
1651         Fix year range in copyright header.
1652
1653 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1654
1655         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1656         Delete.
1657         <operator==>: Update with for removed field.
1658         <hash>: Likewise.
1659         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1660         <isa_features>: ...this.
1661         <abi_features>: New field.
1662         (riscv_isa_flen): Update comment.
1663         (riscv_abi_xlen): New declaration.
1664         (riscv_abi_flen): New declaration.
1665         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1666         isa_features.
1667         (riscv_abi_xlen): New function.
1668         (riscv_isa_flen): Update to get answer from isa_features.
1669         (riscv_abi_flen): New function.
1670         (riscv_has_fp_abi): Update to get answer from abi_features.
1671         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1672         xlen and flen.
1673         (riscv_call_info) <xlen, flen>: Update comment.
1674         (riscv_call_arg_struct): Remove invalid assertions
1675         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1676         is removed.
1677         (riscv_gdbarch_init): Gather isa features and abi features
1678         separately, ensure both match on the gdbarch when reusing an old
1679         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1680         a target with 64-bit float hardware.
1681
1682 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1683
1684         * source.c (search_command_helper): Stop reverse search
1685         when line 1 has been searched.
1686
1687 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1688
1689         * record-full.c (record_full_base_target::close): Rewrite
1690         record_full_core_buf_list free logic.
1691
1692 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1693
1694         * break-catch-syscall.c (print_one_catch_syscall): xfree
1695         the last text.
1696
1697 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1698
1699         * top.c (print_gdb_version): Update Copyright year in version
1700         message.
1701
1702 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1703
1704         Update copyright year range in all GDB files.
1705
1706 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1707
1708         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1709
1710 For older changes see ChangeLog-2018.
1711 \f
1712 Local Variables:
1713 mode: change-log
1714 left-margin: 8
1715 fill-column: 74
1716 version-control: never
1717 coding: utf-8
1718 End:
1719