gdb/ChangeLog

   1 2019-06-13  Pedro Alves  <palves@redhat.com>
   2
   3         * compile/compile.c: Include "cli/cli-option.h".
   4         (compile_print_value): Scope data pointer is now a
   5         value_print_options pointer; adjust.
   6         (compile_print_command): Process options.  Scope data pointer is
   7         now a value_print_options pointer; adjust.
   8         (_initialize_compile): Update "compile print"'s help to include
   9         supported options.  Install a completer for "compile print".
  10         * cp-valprint.c (show_vtblprint, show_objectprint)
  11         (show_static_field_print): Delete.
  12         (_initialize_cp_valprint): Don't install "set print
  13         static-members", "set print vtbl", "set print object" here.
  14         * printcmd.c: Include "cli/cli-option.h" and
  15         "common/gdb_optional.h".
  16         (print_command_parse_format): Rework to fill in a
  17         value_print_options instead of a format_data.
  18         (print_value): Change parameter type from format_data pointer to
  19         value_print_options reference.  Adjust.
  20         (print_command_1): Process options.  Adjust to pass down a
  21         value_print_options.
  22         (print_command_completer): New.
  23         (_initialize_printcmd): Install print_command_completer as
  24         handle_brkchars completer for the "print" command.  Update
  25         "print"'s help to include supported options.
  26         * valprint.c: Include "cli/cli-option.h".
  27         (show_vtblprint, show_objectprint, show_static_field_print): Moved
  28         here from cp-valprint.c.
  29         (boolean_option_def, uinteger_option_def)
  30         (value_print_option_defs, make_value_print_options_def_group):
  31         New.  Use gdb::option::add_setshow_cmds_for_options to install
  32         "set print elements", "set print null-stop", "set print repeats",
  33         "set print pretty", "set print union", "set print array", "set
  34         print address", "set print symbol", "set print array-indexes".
  35         * valprint.h: Include <string> and "cli/cli-option.h".
  36         (make_value_print_options_def_group): Declare.
  37         (print_value): Change parameter type from format_data pointer to
  38         value_print_options reference.
  39         (print_command_completer): Declare.
  40
  41 2019-06-13  Pedro Alves  <palves@redhat.com>
  42
  43         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
  44         (COMMON_SFILES): Add maint-test-settings.c.
  45         * cli/cli-decode.c (boolean_enums): New global, factored out from
  46         ...
  47         (add_setshow_boolean_cmd): ... here.
  48         * cli/cli-decode.h (boolean_enums): Declare.
  49         * cli/cli-option.c: New file.
  50         * cli/cli-option.h: New file.
  51         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
  52         factored out from ...
  53         (parse_cli_boolean_value(const char *)): ... this.
  54         (is_unlimited_literal): Change parameter type to pointer to
  55         pointer.  Adjust and advance ARG pointer.
  56         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
  57         (parse_cli_var_enum): New, factored out from ...
  58         (do_set_command): ... this.  Adjust.
  59         * cli/cli-setshow.h (parse_cli_boolean_value)
  60         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
  61         (parse_cli_var_enum): Declare.
  62         * cli/cli-utils.c: Include "cli/cli-option.h".
  63         (get_ulongest): New.
  64         * cli/cli-utils.h (get_ulongest): Declare.
  65         (check_for_argument): New overloads.
  66         * maint-test-options.c: New file.
  67
  68 2019-06-13  Pedro Alves  <palves@redhat.com>
  69
  70         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
  71         parse a range if "-" is at the end of the string.
  72
  73 2019-06-13  Pedro Alves  <palves@redhat.com>
  74
  75         * cli/cli-setshow.c (parse_auto_binary_operation)
  76         (parse_cli_boolean_value): Don't allow "o".
  77
  78 2019-06-13  Pedro Alves  <palves@redhat.com>
  79
  80         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
  81         * NEWS: Mention maint test-settings KIND.
  82         * maint-test-settings.c: New file.
  83
  84 2019-06-13  Pedro Alves  <palves@redhat.com>
  85
  86         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
  87         completer.
  88         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
  89         "set" completers.
  90
  91 2019-06-13  Pedro Alves  <palves@redhat.com>
  92
  93         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
  94         after item.
  95
  96 2019-06-13  Pedro Alves  <palves@redhat.com>
  97
  98         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
  99
 100 2019-06-13  Pedro Alves <palves@redhat.com>
 101
 102         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 103         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 104         call.
 105         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 106         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 107         calls.
 108         (check_for_argument): Skip spaces after argument.
 109
 110 2019-06-13  Pedro Alves  <palves@redhat.com>
 111
 112         * thread.c (thread_apply_command): Adjust TID parsing.
 113         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 114         detected before end of string.
 115         (tid_is_in_list): Error out if LIST is invalid.
 116
 117 2019-06-13  Pedro Alves  <palves@redhat.com>
 118
 119         * completer.c (complete_line_internal_1): Rewind completion word
 120         point.
 121         (completion_tracker::advance_custom_word_point_by): Change
 122         parameter type to int.
 123         * completer.h (completion_tracker::advance_custom_word_point_by):
 124         Likewise.
 125
 126 2019-06-13  Pedro Alves  <palves@redhat.com>
 127
 128         * completer.c (advance_to_completion_word): Handle delimiters.
 129
 130 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 131
 132         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 133
 134 2019-06-11  Tom Tromey  <tom@tromey.com>
 135
 136         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 137         (xmalloc_failed): Move to alloc.c.
 138         * alloc.c: New file.
 139         * Makefile.in (COMMON_SFILES): Add alloc.c.
 140
 141 2019-06-11  Tom Tromey  <tom@tromey.com>
 142
 143         * nat/linux-waitpid.c: Don't include server.h.
 144         (linux_debug): Remove.
 145         (my_waitpid): Update.
 146
 147 2019-06-11  Tom Tromey  <tromey@adacore.com>
 148
 149         * infcall.c (_initialize_infcall): Remove trailing newline from
 150         help.
 151         * user-regs.c (_initialize_user_regs): Remove trailing newline
 152         from help.
 153         * typeprint.c (_initialize_typeprint): Remove trailing newline
 154         from help.
 155         * reverse.c (_initialize_reverse): Remove trailing newlines from
 156         help.
 157         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 158         from help.
 159         * language.c (add_set_language_command): Remove trailing newline
 160         from help.
 161         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 162         help.
 163         * disasm.c (_initialize_disasm): Remove trailing newline from
 164         help.
 165         * top.c (init_main): Remove trailing newline from help.
 166         * interps.c (_initialize_interpreter): Remove trailing newline
 167         from help.
 168         * btrace.c (_initialize_btrace): Remove trailing newlines from
 169         help.
 170         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 171         from help.
 172         * python/python.c (_initialize_python): Remove trailing newline
 173         from help.
 174         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 175         help.
 176         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 177         from help.  Reformat some text.
 178         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 179         from help.
 180         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 181         newline from help.
 182
 183 2019-06-11  Tom Tromey  <tromey@adacore.com>
 184
 185         * darwin-nat.c (darwin_decode_exception_message)
 186         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 187
 188 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 189
 190         * valops.c (value_slice): Check for not allocated or not
 191         associated values.
 192
 193 2019-06-10  Tom de Vries  <tdevries@suse.de>
 194
 195         PR gdb/24618
 196         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 197         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 198         invalid.
 199
 200 2019-06-10  Tom de Vries  <tdevries@suse.de>
 201
 202         PR gdb/24611
 203         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 204         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 205
 206 2019-06-10  Tom de Vries  <tdevries@suse.de>
 207
 208         PR symtab/24545
 209         * symtab.c (struct demangled_name_entry): Add language field.
 210         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 211         static minimal symbol".  Set and use language field.
 212
 213 2019-06-10  Tom Tromey  <tromey@adacore.com>
 214
 215         * ada-lang.c (_initialize_ada_language): Update help text.
 216
 217 2019-06-10  Tom Tromey  <tromey@adacore.com>
 218
 219         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 220         with a newline.
 221         * guile/guile.c (handle_boot_error): Don't end warning with a
 222         newline.
 223         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 224         warning with a newline.
 225         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 226         newline.
 227         (s12z_frame_cache): Likewise.
 228         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 229         a newline.
 230         * solib-svr4.c (disable_probes_interface): Don't end warning with
 231         a newline.
 232         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 233         newline.
 234         * python/python.c (do_finish_initialization): Don't end warning
 235         with a newline.
 236
 237 2019-06-10  Tom Tromey  <tom@tromey.com>
 238
 239         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 240         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 241         gdbpy_enter.
 242
 243 2019-06-10  Tom Tromey  <tromey@adacore.com>
 244
 245         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 246         data.
 247         (elf_new_init): Don't call stabsread_new_init.
 248         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 249         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 250         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 251
 252 2019-06-10  Tom de Vries  <tdevries@suse.de>
 253
 254         PR symtab/16264
 255         PR symtab/24517
 256         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 257
 258 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 259
 260         * source.c (find_and_open_source): Also rewrite relative file
 261         names.
 262
 263 2019-04-26  Amos Bird  <amosbird@gmail.com>
 264
 265         * annotate.c (annotate_thread_exited): Add "thread-exited"
 266         annotation.
 267
 268 2019-06-06  Tom Tromey  <tromey@adacore.com>
 269
 270         * maint.h (class scoped_command_stats): Use
 271         DISABLE_COPY_AND_ASSIGN.
 272         <print_time>: New method.
 273         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 274         print_time.
 275         (scoped_command_stats::print_time): New method.
 276
 277 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 278
 279         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 280         instructions of lengths 6 or 8 bytes.
 281
 282 2019-06-04  Pedro Alves  <palves@redhat.com>
 283
 284         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 285
 286         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 287         * breakpoint.c (condition_completer): Likewise.
 288         * cli/cli-dump.c (scan_expression): Likewise.
 289         * common/filestuff.c (mkdir_recursive): Likewise.
 290         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 291         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 292         (gdb_abspath): Likewise.
 293         * compile/compile-cplus-types.c
 294         (compile_cplus_instance::decl_name): Likewise.
 295         * completer.c (complete_explicit_location):
 296         (signal_completer, reg_or_group_completer_1): Likewise.
 297         * cp-support.c (cp_remove_params_if_any): Likewise.
 298         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 299         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 300         * infcmd.c (strip_bg_char): Likewise.
 301         * linespec.c (copy_token_string): Likewise.
 302         * mi/mi-main.c (output_cores): Likewise.
 303         * psymtab.c (psymtab_search_name):
 304         * symfile.c (test_set_ext_lang_command): Likewise.
 305         * target.c (target_fileio_read_stralloc): Likewise.
 306         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 307         * value.c (complete_internalvar): Likewise.
 308
 309 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 310
 311         Add objfile property to gdb.Type.
 312         * NEWS: Mention Python API addition.
 313         * python/py-type.c (typy_get_objfile): New method.
 314
 315 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 316
 317         * NEWS: Mention the new set|show style [title|highlight].
 318         Mention changes to "show style", "help" and "apropos".
 319
 320 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 321
 322         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 323         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 324         instead of print_help_for_command.
 325         (print_doc_of_command): New function.
 326         (help_list): Add 'apropos -v word' suggestion.
 327         (print_help_for_command): Style the command name using title style.
 328         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 329         (_initialize_cli_cmds): Describe -v in apropos_command help.
 330
 331 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 332
 333         * cli/cli-style.h (cli_style_option): Add name in constructor,
 334         add m_name class member, add constructor with intensity,
 335         add name class function.
 336         (cli_style_option::add_setshow_commands): Remove name argument.
 337         (highlight_style, title_style): New styles.
 338         * cli/cli-style.c (do_show): New function that shows a style
 339         characteristic styling the style name with itself.
 340         (set_style_name): New function.
 341         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 342         Update all callers according to the changes in cli/cli-style.h.
 343         * utils.h (fputs_highlighted): New function.
 344         * utils.c (fputs_highlighted): Likewise.
 345
 346 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 347
 348         * NEWS: Mention new pipe command and new convenience variables.
 349
 350 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 351
 352         * cli/cli-cmds.c (pipe_command): New function.
 353         (_initialize_cli_cmds): Call add_com for pipe_command.
 354         Define | as an alias for pipe.
 355         (exit_status_set_internal_vars): New function.
 356         (shell_escape): Call exit_status_set_internal_vars.
 357         cli/cli-decode.c (find_command_name_length): Recognize | as
 358         a single character command.
 359
 360 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 361
 362         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 363         top.c (execute_command_to_ui_file): New function, mostly a copy
 364         of execute_command_to_string.
 365         (execute_command_to_string): Implement by calling
 366         execute_command_to_ui_file.
 367
 368 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 369
 370         * top.h (saved_command_line): Remove declaration.
 371         * top.c (previous_saved_command_line, previous_repeat_arguments):
 372         New variables.
 373         (saved_command_line): Make static, define together with other
 374         'repeat variables'.
 375         (dont_repeat): Clear repeat_arguments.
 376         (repeat_previous, get_saved_command_line, save_command_line):
 377         New functions.
 378         (gdb_init): Initialize saved_command_line
 379         and previous_saved_command_line.
 380         * main.c (captured_main_1): Remove saved_command_line initialization.
 381         * event-top.c (handle_line_of_input): Update to use
 382         the new 'repeat' related functions instead of direct access to
 383         saved_command_line.
 384         * command.h (repeat_previous, get_saved_command_line,
 385         save_command_line): New declarations.
 386         (dont_repeat): Add comment.
 387
 388 2019-05-30  Tom Tromey  <tromey@adacore.com>
 389
 390         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 391         Fix comment.
 392         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 393
 394 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 395
 396         PR cli/24587
 397         * completer.c (complete): Initialize variable word.
 398
 399 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 400
 401         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 402         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 403         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 404         'body' is NULL to the outter 'if', protecting the '!is_define'
 405         situation as well.
 406
 407 2019-05-29  Tom Tromey  <tromey@adacore.com>
 408
 409         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 410         (dwarf_unknown): New function.
 411         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 412         (dwarf_type_encoding_name): Use dwarf_unknown.
 413
 414 2019-05-29  Tom Tromey  <tromey@adacore.com>
 415
 416         PR c++/20020:
 417         * cp-valprint.c (cp_print_value_fields): Call
 418         cp_print_static_field inside "try".
 419
 420 2019-05-29  Tom Tromey  <tromey@adacore.com>
 421
 422         * inflow.c (struct terminal_info): Add default operator=.
 423         * configure: Rebuild.
 424         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 425         -Wdeprecated-copy-dtor, -Wredundant-move.
 426
 427 2019-05-29  Tom Tromey  <tromey@adacore.com>
 428
 429         * NEWS: Add entry.
 430         * infcmd.c (print_return_value_1): Handle finish_print
 431         option.
 432         (show_print_finish): New function.
 433         (_initialize_infcmd): Add "set/show print finish" commands.
 434         * valprint.c (user_print_options): Initialize new member.
 435         * valprint.h (struct value_print_options) <finish_print>: New
 436         member.
 437
 438 2019-05-28  Tom Tromey  <tromey@adacore.com>
 439
 440         * ada-lang.c (ada_remove_Xbn_suffix)
 441         (find_old_style_renaming_symbol)
 442         (parse_old_style_renaming): Remove.
 443         (ada_find_renaming_symbol): Don't call
 444         find_old_style_renaming_symbol.
 445         (ada_is_renaming_symbol): Rename from
 446         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 447         bool.  Now static.
 448         (ada_read_var_value): Update and simplify.
 449         * ada-exp.y (write_var_or_type): Remove old code.
 450
 451 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 452
 453         * event-top.c: Remove include comment.
 454         * inflow.c (class scoped_ignore_sigttou): Move from here...
 455         * inflow.h (class scoped_ignore_sigttou): ...to here.
 456         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 457         * top.c:  Remove include comment.
 458
 459 2019-05-27  Tom Tromey  <tom@tromey.com>
 460
 461         * NEWS: Fix typo.
 462
 463 2019-05-22  Tom Tromey  <tromey@adacore.com>
 464
 465         * target.c (target_follow_exec): Constify parameter.
 466         * target-delegates.c: Rebuild.
 467         * remote.c (remote_target::follow_exec): Constify parameter.
 468         * infrun.c (follow_exec): Constify parameter.
 469         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 470         (target_follow_exec): Likewise.
 471
 472 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 473
 474         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 475         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 476
 477 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 478
 479         * NEWS: Add debugredirect and testsuite sections.
 480
 481 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 482
 483         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 484         target descriptions using exclusively floating point register name
 485         aliases.
 486
 487 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 488
 489         PR gdb/18644:
 490         * f-lang.c (build_fortran_types): Handle the case where
 491         gdbarch_floatformat_for_type returns a nullptr.
 492
 493 2019-05-21  Tom de Vries  <tdevries@suse.de>
 494
 495         PR cli/24587
 496         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 497
 498 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 499
 500         PR gdb/18644:
 501         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 502         16-byte floats.
 503         * i386-tdep.c (i386_floatformat_for_type): Use
 504         floatformats_ia64_quad for the 16-byte floating point component
 505         within a fortran 32-byte complex number.
 506
 507 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 508
 509         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 510         delete default constructor.
 511         (find_partial_die): Update to return const struct.
 512         (partial_die_parent_scope): Move variable declaration into scope
 513         of its use and change its type to auto.
 514         (guess_partial_die_structure_name): Likewise.
 515         (partial_die_info::fixup): Likewise.
 516
 517 2019-05-17  Tom Tromey  <tromey@adacore.com>
 518
 519         * source.c (find_and_open_source): Remove cast.
 520
 521 2019-05-17  Tom Tromey  <tromey@adacore.com>
 522
 523         * annotate.c (annotate_source): Make "filename" const.
 524         * annotate.h (annotate_source): Use const.
 525
 526 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 527
 528         * disasm.c (set_disassembler_options): Send errors to stderr.
 529
 530 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 531
 532         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 533         (cli_interp_base::set_logging): Check debug_redirect.
 534         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 535         * cli/cli-logging.c (debug_redirect): Add static variable.
 536         (pop_output_files): Add default param.
 537         (handle_redirections): Print debug setting.
 538         (show_logging_command): Likewise.
 539         (_initialize_cli_logging): Add debugredirect command.
 540         * interps.c (current_interp_set_logging): Add debug_redirect
 541         parameter.
 542         * interps.h (set_logging): Add debug_redirect parameter.
 543         (current_interp_set_logging): Likewise.
 544         * mi/mi-common.h: Likewise.
 545         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 546
 547 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 548             Tom Tromey  <tromey@adacore.com>
 549
 550         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 551         directly.
 552         * cli/cli-interp.h (make_logging_output): Remove declaration.
 553         * cli/cli-logging.c (make_logging_output): Remove function.
 554         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 555         directly.
 556         * ui-file.c (tee_file::tee_file): Remove bools.
 557         (tee_file::~tee_file): Remove deletes.
 558         * ui-file.h (tee_file): Remove bools.
 559
 560 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 561
 562         * mi/mi-cmds.h (mi_cmd_complete): New function.
 563         * mi/mi-main.c (mi_cmd_complete): Likewise.
 564         * mi/mi-cmds.c: Define new MI command -complete.
 565         * NEWS: Mention new -complete command.
 566
 567 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 568
 569         * completer.h (complete): New function.
 570         * completer.c (complete): Likewise.
 571         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 572         function defined in completer.h.
 573
 574 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 575
 576        * MAINTAINERS (Write After Approval): Add myself.
 577
 578 2019-05-17  Tom de Vries  <tdevries@suse.de>
 579
 580         PR gdb/24094
 581         * dwarf2read.c (struct cu_partial_die_info): New struct.
 582         (find_partial_die): Return cu_partial_die_info.
 583         (partial_die_parent_scope, guess_partial_die_structure_name)
 584         (partial_die_info::fixup): Handle new return type of find_partial_die.
 585
 586 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 587
 588         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 589         "std::string", simplifying the algorithm.
 590
 591 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 592
 593         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 594         (stap_static_probe_ops::get_probes): Likewise.
 595
 596 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 597
 598         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 599         '-')" and "else if".
 600         (stap_parse_single_operand): Join checks for
 601         "gdbarch_stap_parse_special_token_p" and
 602         "gdbarch_stap_parse_special_token" in the same "if" statement.
 603         Invert check when verifying for operation on register
 604         displacement.
 605
 606 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 607
 608         * stap-probe.c (stap_get_opcode): Update comment.
 609         (stap_get_expected_argument_type): Likewise.
 610         (handle_stap_probe): Likewise.
 611
 612 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 613
 614         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 615         return type to 'bool'.  Adjust comment.  Use 'bool' when
 616         appropriate.
 617         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 618         * stap-probe.c (stap_parse_argument_1): Likewise.
 619         (stap_is_operator): Likewise.
 620         (stap_is_generic_prefix): Likewise.
 621         (stap_is_register_prefix): Likewise.
 622         (stap_is_register_indirection_prefix): Likewise.
 623         (stap_is_integer_prefix): Likewise.
 624         (stap_generic_check_suffix): Likewise.
 625         (stap_check_integer_suffix): Likewise.
 626         (stap_check_register_suffix): Likewise.
 627         (stap_check_register_indirection_suffix): Likewise.
 628         (stap_parse_register_operand): Likewise.
 629         (stap_parse_single_operand): Likewise.
 630         (stap_parse_argument_1): Likewise.
 631         (stap_probe::get_argument_count): Likewise.
 632         (stap_is_operator): Likewise.
 633
 634 2019-05-16  Tom Tromey  <tromey@adacore.com>
 635
 636         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 637         keyword to foreach.
 638
 639 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 640
 641         * linux-thread-db.c (try_thread_db_load_1): Change return type
 642         to bool.
 643         (try_thread_db_load): Likewise.
 644         (try_thread_db_load_from_pdir_1): Likewise.
 645         (try_thread_db_load_from_pdir): Likewise.
 646         (try_thread_db_load_from_sdir): Likewise.
 647         (try_thread_db_load_from_dir): Likewise.
 648         (thread_db_load_search): Likewise.
 649         (has_libpthread): Likewise.
 650         (thread_db_load): Likewise.
 651
 652 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 653
 654         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 655         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 656         NULL, and complain/return if that's the case.
 657
 658 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 659
 660         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 661         (advance, posn, abstract_read_memory): New functions.
 662         [struct mem_read_abstraction]: New struct.
 663         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 664
 665 2019-05-14  Tom Tromey  <tromey@adacore.com>
 666
 667         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 668         value is not lval_memory.
 669
 670 2019-05-14  Tom Tromey  <tromey@adacore.com>
 671
 672         * solib.c (info_sharedlibrary_command): Style the file name.
 673
 674 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 675
 676         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 677         (aarch64_vnv_type): Likewise.
 678         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 679         * common/tdesc.c: Likewise.
 680         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 681         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 682         * features/aarch64-fpu.xml: Add ieee half view.
 683         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 684         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 685         * gdbtypes.h (struct builtin_type): Likewise.
 686         (struct objfile_type): Likewise.
 687
 688 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 689
 690         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 691         typo.
 692         * location.h (string_to_event_location): Likewise.
 693
 694 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 695
 696         GDB 8.3 released.
 697
 698 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 699
 700         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 701         New variable declaration.
 702         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 703         New variable.
 704         (print_one_breakpoint): Use ui_out::test_flags and new global
 705         variable to compute use_fixed_output.
 706         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 707         Remove.
 708         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 709         (mi_multi_location_breakpoint_output_fixed): Remove.
 710         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 711         new variable.
 712         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 713         fix_multi_location_breakpoint_output flag if version >= 3.
 714         * ui-out.h (enum ui_out_flag)
 715         <fix_multi_location_breakpoint_output>: New enumerator.
 716
 717 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 718
 719         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 720
 721 2019-05-10  Tom Tromey  <tromey@adacore.com>
 722
 723         * ada-lang.c (catch_ada_completer): New function.
 724         (_initialize_ada_language): Use it.
 725
 726 2019-05-10  Tom Tromey  <tromey@adacore.com>
 727
 728         * thread.c (print_thread_info): Make "requested_threads" const.
 729         * gdbthread.h (print_thread_info): Make "requested_threads"
 730         const.
 731         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 732         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 733
 734 2019-05-08  Tom Tromey  <tom@tromey.com>
 735
 736         * gdbtypes.c (objfile_type_data): Change type.
 737         (objfile_type, _initialize_gdbtypes): Update.
 738
 739 2019-05-08  Tom Tromey  <tom@tromey.com>
 740
 741         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 742         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 743         (_initialize_dwarf2_frame): Update.
 744
 745 2019-05-08  Tom Tromey  <tom@tromey.com>
 746
 747         * objc-lang.c (objc_objfile_data): Change type.
 748         (find_methods): Update.
 749         (_initialize_objc_lang): Remove.
 750
 751 2019-05-08  Tom Tromey  <tom@tromey.com>
 752
 753         * stabsread.c (rs6000_builtin_type_data): Change type.
 754         (rs6000_builtin_type, _initialize_stabsread): Update.
 755
 756 2019-05-08  Tom Tromey  <tom@tromey.com>
 757
 758         * mips-tdep.c (mips_pdr_data): Remove.
 759         (_initialize_mips_tdep): Update.
 760
 761 2019-05-08  Tom Tromey  <tom@tromey.com>
 762
 763         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 764         (hppa_init_objfile_priv_data, read_unwind_info)
 765         (find_unwind_entry, _initialize_hppa_tdep): Update.
 766
 767 2019-05-08  Tom Tromey  <tom@tromey.com>
 768
 769         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 770         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 771         on obstack.
 772         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 773
 774 2019-05-08  Tom Tromey  <tom@tromey.com>
 775
 776         * mdebugread.c (basic_type_data): Change type.
 777         (basic_type, _initialize_mdebugread): Update.
 778
 779 2019-05-08  Tom Tromey  <tom@tromey.com>
 780
 781         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 782
 783 2019-05-08  Tom Tromey  <tom@tromey.com>
 784
 785         * nto-tdep.c (nto_inferior_data_reg): Change type.
 786         (nto_inferior_data): Update.
 787         (nto_inferior_data_cleanup, nto_new_inferior_data)
 788         (_initialize_nto_tdep): Remove.
 789         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 790
 791 2019-05-08  Tom Tromey  <tom@tromey.com>
 792
 793         * ada-lang.c (struct ada_inferior_data): Add initializers.
 794         (ada_inferior_data): Change type.
 795         (ada_inferior_data_cleanup): Remove.
 796         (get_ada_inferior_data, ada_inferior_exit)
 797         (struct ada_pspace_data): Add initializers, destructor.
 798         (ada_pspace_data_handle): Change type.
 799         (get_ada_pspace_data): Update.
 800         (ada_pspace_data_cleanup): Remove.
 801
 802 2019-05-08  Tom Tromey  <tom@tromey.com>
 803
 804         * coffread.c (struct coff_symfile_info): Add initializers.
 805         (coff_objfile_data_key): Move lower.  Change type.
 806         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 807         Update.
 808         (coff_free_info): Remove.
 809
 810 2019-05-08  Tom Tromey  <tom@tromey.com>
 811
 812         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 813         (fbsd_pspace_data_handle): Move lower.  Change type.
 814         (get_fbsd_pspace_data): Update.
 815         (fbsd_pspace_data_cleanup): Remove.
 816         (_initialize_fbsd_tdep): Update.
 817
 818 2019-05-08  Tom Tromey  <tom@tromey.com>
 819
 820         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 821         (get_ada_tasks_pspace_data): Update.
 822         (ada_tasks_pspace_data_cleanup): Remove.
 823         (_initialize_tasks): Update.
 824         (ada_tasks_inferior_data_handle): Change type.
 825         (get_ada_tasks_inferior_data): Update.
 826         (ada_tasks_inferior_data_cleanup): Remove.
 827         (struct ada_tasks_pspace_data): Add initializers.
 828
 829 2019-05-08  Tom Tromey  <tom@tromey.com>
 830
 831         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 832         * symfile-debug.c (debug_sym_get_probes): Change type.
 833         * stap-probe.c (handle_stap_probe):
 834         (stap_static_probe_ops::get_probes): Change type.
 835         * probe.h (class static_probe_ops) <get_probes>: Change type.
 836         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 837         (parse_probes_in_pspace): Update.
 838         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 839         Update.
 840         (any_static_probe_ops::get_probes): Change type.
 841         * elfread.c (elfread_data): New typedef.
 842         (probe_key): Change type.
 843         (elf_get_probes): Likewise.  Update.
 844         (probe_key_free): Remove.
 845         (_initialize_elfread): Update.
 846         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 847         Change type.
 848         (dtrace_process_dof_probe, dtrace_process_dof)
 849         (dtrace_static_probe_ops::get_probe): Change type.
 850
 851 2019-05-08  Tom Tromey  <tom@tromey.com>
 852
 853         * xcoffread.c (struct xcoff_symfile_info): Rename from
 854         coff_symfile_info.  Add initializers.
 855         (xcoff_objfile_data_key): Move lower.  Change type.
 856         (XCOFF_DATA): Rewrite.
 857         (xcoff_free_info): Remove.
 858         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 859         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 860         (xcoff_initial_scan): Update.
 861
 862 2019-05-08  Tom Tromey  <tom@tromey.com>
 863
 864         * solib-svr4.c (struct svr4_info): Add initializers and
 865         destructor.
 866         <probes_table>: Now an htab_up.
 867         (solib_svr4_pspace_data): Change type.
 868         (free_probes_table): Simplify.
 869         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 870         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 871         (probes_table_remove_objfile_probes, register_solib_event_probe)
 872         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 873         (_initialize_svr4_solib): Update.
 874
 875 2019-05-08  Tom Tromey  <tom@tromey.com>
 876
 877         * remote.c (remote_pspace_data): Change type.
 878         (remote_pspace_data_cleanup): Remove.
 879         (get_remote_exec_file, set_pspace_remote_exec_file)
 880         (_initialize_remote): Update.
 881
 882 2019-05-08  Tom Tromey  <tom@tromey.com>
 883
 884         * breakpoint.c (breakpoint_objfile_key): Change type.
 885         (get_breakpoint_objfile_data): Update.
 886         (free_breakpoint_objfile_data): Remove.
 887         (_initialize_breakpoint): Update.
 888
 889 2019-05-08  Tom Tromey  <tom@tromey.com>
 890
 891         * linux-tdep.c (struct linux_info): Add initializers.
 892         (linux_inferior_data): Move.  Change type.
 893         (invalidate_linux_cache_inf): Update.
 894         (linux_inferior_data_cleanup): Remove.
 895         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 896
 897 2019-05-08  Tom Tromey  <tom@tromey.com>
 898
 899         * auxv.c (auxv_inferior_data): Move.  Change type.
 900         (auxv_inferior_data_cleanup): Remove.
 901         (invalidate_auxv_cache_inf): Rewrite.
 902         (get_auxv_inferior_data, _initialize_auxv): Update.
 903
 904 2019-05-08  Tom Tromey  <tom@tromey.com>
 905
 906         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 907         (symfile_debug_objfile_data_key): Change type.
 908         (symfile_debug_installed, debug_qf_has_symbols)
 909         (debug_qf_find_last_source_symtab)
 910         (debug_qf_forget_cached_source_info)
 911         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 912         (debug_qf_print_stats, debug_qf_dump)
 913         (debug_qf_expand_symtabs_for_function)
 914         (debug_qf_expand_all_symtabs)
 915         (debug_qf_expand_symtabs_with_fullname)
 916         (debug_qf_map_matching_symbols)
 917         (debug_qf_expand_symtabs_matching)
 918         (debug_qf_find_pc_sect_compunit_symtab)
 919         (debug_qf_map_symbol_filenames)
 920         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 921         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 922         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 923         (debug_sym_read_linetable, debug_sym_relocate): Update.
 924         (symfile_debug_free_objfile): Remove.
 925         (install_symfile_debug_logging, _initialize_symfile_debug):
 926         Update.
 927
 928 2019-05-08  Tom Tromey  <tom@tromey.com>
 929
 930         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 931         allocate_on_obstack.
 932         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 933         (get_dwarf2_per_objfile): Update.
 934         (set_dwarf2_per_objfile): Remove.
 935         (dwarf2_has_info, dwarf2_get_section_info): Update.
 936         (dwarf2_free_objfile): Remove.
 937         (_initialize_dwarf2_read): Update.
 938
 939 2019-05-08  Tom Tromey  <tom@tromey.com>
 940
 941         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 942         initializers.
 943         <unsupported_script_warning_printed,
 944         script_not_found_warning_printed>: Now bool.
 945         (auto_load_pspace_data): Change type.
 946         (~auto_load_pspace_info): Rename from
 947         auto_load_pspace_data_cleanup.
 948         (get_auto_load_pspace_data, init_loaded_scripts_info)
 949         (clear_section_scripts, maybe_print_unsupported_script_warning)
 950         (maybe_print_script_not_found_warning, _initialize_auto_load):
 951         Update.
 952
 953 2019-05-08  Tom Tromey  <tom@tromey.com>
 954
 955         * objfiles.c (objfile_pspace_info): Add destructor and
 956         initializers.
 957         (objfiles_pspace_data): Change type.
 958         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 959         (get_objfile_pspace_data): Update.
 960         (objfiles_bfd_data): Change type.
 961         (get_objfile_bfd_data): Update.
 962         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 963
 964 2019-05-08  Tom Tromey  <tom@tromey.com>
 965
 966         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 967         Change type.
 968         (get_catch_syscall_inferior_data): Update.
 969         (catch_syscall_inferior_data_cleanup): Remove.
 970         (_initialize_break_catch_syscall): Update.
 971
 972 2019-05-08  Tom Tromey  <tom@tromey.com>
 973
 974         * inflow.c (struct terminal_info): Add destructor and
 975         initializers.
 976         (inflow_inferior_data): Change type.
 977         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 978         (get_inflow_inferior_data, inflow_inferior_exit)
 979         (swap_terminal_info, _initialize_inflow): Update.
 980
 981 2019-05-08  Tom Tromey  <tom@tromey.com>
 982
 983         * target-dcache.c (target_dcache_cleanup): Remove.
 984         (target_dcache_aspace_key): Change type.
 985         (target_dcache_init_p, target_dcache_invalidate)
 986         (target_dcache_get, target_dcache_get_or_init)
 987         (_initialize_target_dcache): Update.
 988         * dcache.h (struct dcache_deleter): New.
 989
 990 2019-05-08  Tom Tromey  <tom@tromey.com>
 991
 992         * symtab.c (struct symbol_cache): Add destructor and
 993         initializers.
 994         (symbol_cache_key): Move.  Change type.
 995         (make_symbol_cache, free_symbol_cache): Remove.
 996         (get_symbol_cache): Update.
 997         (symbol_cache_cleanup): Remove.
 998         (ALL_PSPACES, symbol_cache_flush)
 999         (maintenance_print_symbol_cache)
1000         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1001         Update.
1002
1003 2019-05-08  Tom Tromey  <tom@tromey.com>
1004
1005         * symtab.c (struct main_info): Add destructor and initializers.
1006         (main_progspace_key): Move.  Change type.
1007         (get_main_info): Update.
1008         (main_info_cleanup): Remove.
1009         (_initialize_symtab): Update.
1010
1011 2019-05-08  Tom Tromey  <tom@tromey.com>
1012
1013         * registry.h (DECLARE_REGISTRY): Define the _key class.
1014
1015 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1016
1017         * NEWS: Merge two 'New commands' sections.
1018
1019 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1020
1021         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1022         parameter and use Ada language definition instead.
1023         (ada_val_print_ptr): Remove unused language parameter.
1024         (ada_val_print_num): Remove language parameter and use Ada language
1025         definition instead.
1026         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1027         parameter.
1028         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1029         parameter and use Ada language definition instead.
1030         (ada_val_print_1): Update all ada_val_print_xxx calls.
1031         Remove language parameter.
1032         (ada_val_print): Update ada_val_print_1 call.
1033
1034 2019-05-08  Tom Tromey  <tromey@adacore.com>
1035
1036         * remote.c (remote_hw_watchpoint_limit)
1037         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1038         Now static.
1039
1040 2019-05-08  Tom Tromey  <tromey@adacore.com>
1041
1042         * maint.c (_initialize_maint_cmds): Move initialization code to
1043         remote.c.
1044         (watchdog, show_watchdog): Move to remote.c.
1045         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1046         "watchdog" static.
1047         (_initialize_remote): Move initialization code from maint.c.
1048         * defs.h (watchdog): Don't declare.
1049
1050 2019-05-08  Tom Tromey  <tromey@adacore.com>
1051
1052         * tui/tui-interp.c: Include main.h.
1053         * interps.c: Include main.h.
1054         * main.h (interpreter_p): Declare.
1055         * defs.h (interpreter_p): Don't declare.
1056
1057 2019-05-08  Tom Tromey  <tromey@adacore.com>
1058
1059         * dwarf2loc.c: Include dwarf2read.h.
1060         * defs.h (read_unsigned_leb128): Don't declare.
1061         * dwarf2read.h (read_unsigned_leb128): Declare.
1062
1063 2019-05-08  Tom Tromey  <tromey@adacore.com>
1064
1065         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1066         method.
1067
1068 2019-05-08  Tom Tromey  <tromey@adacore.com>
1069
1070         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1071         when no wrap column is set.
1072
1073 2019-05-08  Tom Tromey  <tromey@adacore.com>
1074
1075         * c-lang.c (c_get_string): Handle non-C-style arrays.
1076
1077 2019-05-08  Tom Tromey  <tromey@adacore.com>
1078
1079         * typeprint.c (print_offset_data::update): Print the bit offset,
1080         not the number of bits remaining.
1081
1082 2019-05-08  Tom Tromey  <tromey@adacore.com>
1083
1084         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1085         padding at end of comment.
1086
1087 2019-05-08  Tom Tromey  <tromey@adacore.com>
1088
1089         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1090         Compare main types.
1091
1092 2019-05-06  Tom Tromey  <tom@tromey.com>
1093
1094         * common/scoped_mmap.c: Include common-defs.h.
1095         * common/scoped_mmap.h: Don't include config.h.
1096
1097 2019-05-04  Tom Tromey  <tom@tromey.com>
1098
1099         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1100         (struct aarch64_call_info): Add initializers.
1101         <si>: Now a std::vector.
1102         (pass_on_stack, aarch64_push_dummy_call): Update.
1103
1104 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1105             Tom Tromey  <tom@tromey.com>
1106
1107         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1108         (ppc_threads): Now a std::vector.  Now static.
1109         (hwdebug_find_thread_points_by_tid)
1110         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1111         Update.
1112
1113 2019-05-04  Tom Tromey  <tom@tromey.com>
1114
1115         * arc-tdep.c (arc_tdesc_init): Return bool.
1116
1117 2019-05-04  Tom Tromey  <tom@tromey.com>
1118
1119         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1120         Use gdb_assert_not_reached.
1121
1122 2019-05-04  Tom Tromey  <tom@tromey.com>
1123
1124         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1125         "false".
1126
1127 2019-05-04  Tom Tromey  <tom@tromey.com>
1128
1129         * arc-tdep.c (arc_tdesc_init): Use bool.
1130
1131 2019-05-04  Tom Tromey  <tom@tromey.com>
1132
1133         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1134
1135 2019-05-04  Tom Tromey  <tom@tromey.com>
1136
1137         * cli/cli-cmds.c (valid_command_p): Return bool.
1138
1139 2019-05-04  Tom Tromey  <tom@tromey.com>
1140
1141         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1142         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1143
1144 2019-05-04  Raul Tambre  <raul@tambre.ee>
1145
1146         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1147         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1148         operator for comparison.
1149
1150 2019-05-04  Tom Tromey  <tom@tromey.com>
1151
1152         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1153         (lookup_partial_symbol, print_partial_symbols)
1154         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1155         (psymbol_compare): Update.
1156         (add_psymbol_to_bcache): Clear the entire psymbol.
1157         (maintenance_check_psymtabs): Update.
1158         * psympriv.h (struct partial_symbol): Don't derive from
1159         general_symbol_info.
1160         <obj_section, unrelocated_address, address,
1161         set_unrelocated_address>: Update.
1162         <ginfo>: New member.
1163         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1164         (debug_names::write_psymbols): Update.
1165
1166 2019-05-04  Tom de Vries  <tdevries@suse.de>
1167
1168         * contrib/cc-with-tweaks.sh: Support -n arg.
1169
1170 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1171
1172         * corelow.c (core_target::detach): Ensure frame cache and
1173         register caches are cleared.
1174         inferior.c (exit_inferior_1): Likewise.
1175
1176 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1177             Tom Tromey  <tom@tromey.com>
1178
1179         * dictionary.c (collate_pending_symbols_by_language): Remove
1180         "struct" from foreach.
1181         * symtab.c (lookup_global_symbol_from_objfile)
1182         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1183         foreach.
1184         * ser-tcp.c (net_open): Remove "struct" from foreach.
1185         * objfiles.c (objfile_relocate, objfile_rebase)
1186         (objfile_has_symbols): Remove "struct" from foreach.
1187         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1188         from foreach.
1189         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1190         foreach.
1191         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1192         "struct" from foreach.
1193         * ada-lang.c (create_excep_cond_exprs)
1194         (ada_exception_catchpoint_cond_string): Remove "struct" from
1195         foreach.
1196
1197 2019-05-03  Tom Tromey  <tromey@adacore.com>
1198
1199         * ada-exp.y (convert_char_literal): Check suffix of each
1200         enumerator.
1201
1202 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1203
1204         PR ada/21406:
1205         * ada-exp.y (yywrap): Don't define.
1206         * ada-lex.l (%option): Add noyywrap
1207         (yywrap): Remove.
1208
1209 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1210
1211         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1212         _WIN32_WINNT to the XP level, unless already defined to a higher
1213         level.
1214
1215         * unittests/parse-connection-spec-selftests.c:
1216         * ser-tcp.c:
1217         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1218         override.
1219
1220         * symfile.c (find_separate_debug_file): Remove colon from the
1221         drive spec of DOS/Windows file names of the target, so that the
1222         file name produced from DEBUGDIR and the target's directory will
1223         be valid on DOS/Windows systems.
1224
1225 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1226
1227         * rust-lang.c (val_print_struct): Handle printing structures
1228         containing strings.
1229
1230 2019-05-02  Tom Tromey  <tromey@adacore.com>
1231
1232         * valarith.c (_initialize_valarith): Remove.
1233
1234 2019-05-01  Tom Tromey  <tromey@adacore.com>
1235
1236         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1237         bitfields.
1238
1239 2019-05-01  Tom Tromey  <tromey@adacore.com>
1240
1241         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1242         for big-endian copies.
1243
1244 2019-04-30  Ali Tamur  <tamur@google.com>
1245         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1246         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1247         (read_3_bytes): New function.
1248
1249 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1250
1251         * windows-nat.c (main_thread_id): Delete.
1252         (handle_output_debug_string): Replace main_thread_id by
1253         current_event.dwThreadId.
1254         (fake_create_process): Likewise.
1255         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1256         Do not set main_thread_id.
1257         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1258         current_event.dwThreadId.
1259         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1260
1261 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1262
1263         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1264         Use current_event.dwThreadId instead of main_thread_id.
1265
1266 2019-04-30  Tom Tromey  <tromey@adacore.com>
1267
1268         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1269         (create_excep_cond_exprs): Iterate over program spaces.
1270         (ada_exception_catchpoint_cond_string): Examine all minimal
1271         symbols for exception types.
1272
1273 2019-04-30  Tom Tromey  <tromey@adacore.com>
1274
1275         PR c++/24470:
1276         * dwarf2read.c (process_structure_scope): Handle case where type
1277         has template parameters but no symbol was created.
1278
1279 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1280             Chris January  <chris.january@arm.com>
1281
1282         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1283         qualifier.
1284         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1285
1286 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1287
1288         * f-typeprint.c (f_print_type): Update rules for printing
1289         whitespace.
1290         (f_type_print_varspec_suffix): Likewise.
1291
1292 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1293             Chris January  <chris.january@arm.com>
1294
1295         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1296         function arguments.
1297
1298 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1299
1300         * f-lang.c (build_fortran_types): Change name of void type to
1301         lower case.
1302         * f-typeprint.c (f_type_print_base): Print the name of the void
1303         type, rather than a fixed string.
1304         * f-valprint.c (f_decorations): Use lower case void string.
1305
1306 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1307             Chris January  <chris.january@arm.com>
1308
1309         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1310         types for Fortran.
1311
1312 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1313             Chris January  <chris.january@arm.com>
1314             David Lecomber  <david.lecomber@arm.com>
1315
1316         * f-exp.y (BINOP_INTRINSIC): New token.
1317         (exp): New parser rule handling BINOP_INTRINSIC.
1318         (f77_keywords): Add new builtin procedures.
1319         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1320         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1321         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1322         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1323         (print_unop_subexp_f): New function.
1324         (print_binop_subexp_f): New function.
1325         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1326         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1327         (dump_subexp_body_f): Likewise.
1328         (operator_check_f): Likewise.
1329         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1330         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1331
1332 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1333
1334         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1335         UNOP_KIND.
1336         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1337         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1338         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1339         (operator_length_f): New fuction.
1340         (print_subexp_f): New function.
1341         (op_name_f): New function.
1342         (dump_subexp_body_f): New function.
1343         (operator_check_f): New function.
1344         (exp_descriptor_f): Replace standard expression handling functions
1345         with new functions.
1346         * gdb/fortran-operator.def: New file.
1347         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1348         * gdb/std-operator.def: Remove UNOP_KIND.
1349
1350 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1351
1352         * std-operator.def: Remove unbalanced, stray double quote
1353         character.
1354
1355 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1356             Chris January  <chris.january@arm.com>
1357             Daniel Everett  <daniel.everett@arm.com>
1358             Nick Forrington  <nick.forrington@arm.com>
1359             Richard Bunt  <richard.bunt@arm.com>
1360
1361         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1362         of depth when printing anonymous structs or unions.
1363         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1364         Don't print either the top-level value, or the children if the
1365         max-depth is exceeded.
1366         (ppscm_print_children): When printing the key of a map, allow one
1367         extra level of depth.
1368         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1369         print either the top-level value, or the children if the max-depth
1370         is exceeded.
1371         (print_children): When printing the key of a map, allow one extra
1372         level of depth.
1373         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1374         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1375         (user_print_options): Initialise max_depth field.
1376         (val_print_scalar_or_string_type_p): New function.
1377         (val_print): Check to see if the max depth has been reached.
1378         (val_print_check_max_depth): Define new function.
1379         (show_print_max_depth): New function.
1380         (_initialize_valprint): Add 'print max-depth' option.
1381         * valprint.h (struct value_print_options) <max_depth>: New field.
1382         (val_print_check_max_depth): Declare new function.
1383         * NEWS: Document new feature.
1384
1385 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1386
1387         * ada-lang.c (ada_language_defn): Initialise new field.
1388         * c-lang.c (c_is_string_type_p): New function.
1389         (c_language_defn): Initialise new field.
1390         (cplus_language_defn): Initialise new field.
1391         (asm_language_defn): Initialise new field.
1392         (minimal_language_defn): Initialise new field.
1393         * c-lang.h (c_is_string_type_p): Declare new function.
1394         * d-lang.c (d_language_defn): Initialise new field.
1395         * f-lang.c (f_is_string_type_p): New function.
1396         (f_language_defn): Initialise new field.
1397         * go-lang.c (go_is_string_type_p): New function.
1398         (go_language_defn): Initialise new field.
1399         * language.c (default_is_string_type_p): New function.
1400         (unknown_language_defn): Initialise new field.
1401         (auto_language_defn): Initialise new field.
1402         * language.h (struct language_defn) <la_is_string_type_p>: New
1403         member variable.
1404         (default_is_string_type_p): Declare new function.
1405         * m2-lang.c (m2_language_defn): Initialise new field.
1406         * objc-lang.c (objc_language_defn): Initialise new field.
1407         * opencl-lang.c (opencl_language_defn): Initialise new field.
1408         * p-lang.c (pascal_is_string_type_p): New function.
1409         (pascal_language_defn): Initialise new field.
1410         * rust-lang.c (rust_is_string_type_p): New function.
1411         (rust_language_defn): Initialise new field.
1412
1413 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1414
1415         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1416         New field.
1417         * ada-lang.c (ada_language_defn): Initialise new field.
1418         * c-lang.c (c_language_defn): Likewise.
1419         (cplus_language_defn): Likewise.
1420         (asm_language_defn): Likewise.
1421         (minimal_language_defn): Likewise.
1422         * d-lang.c (d_language_defn): Likewise.
1423         * f-lang.c (f_language_defn): Likewise.
1424         * go-lang.c (go_language_defn): Likewise.
1425         * language.c (unknown_language_defn): Likewise.
1426         (auto_language_defn): Likewise.
1427         * m2-lang.c (m2_language_defn): Likewise.
1428         * objc-lang.c (objc_language_defn): Likewise.
1429         * opencl-lang.c (opencl_language_defn): Likewise.
1430         * p-lang.c (pascal_language_defn): Likewise.
1431         * rust-lang.c (rust_language_defn): Likewise.
1432
1433 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1434
1435         * ada-lang.c (ada_is_character_type): Change return type to bool.
1436         (ada_is_string_type): Likewise.
1437         * ada-lang.h (ada_is_character_type): Update declaration
1438         (ada_is_string_type): Likewise.
1439
1440 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1441
1442         Support style in 'frame|thread apply'
1443
1444         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1445         * record.c (record_start, record_stop): Update callers of
1446         execute_command_to_string with false.
1447         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1448         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1449         methods.
1450         (class string_file): New constructor with term_out parameter.
1451         Override methods term_out and can_emit_style_escape.  New member
1452         term_out.
1453         (class stdio_file): Override can_emit_style_escape.
1454         (class tee_file): Override term_out and can_emit_style_escape.
1455         * utils.h (can_emit_style_escape): Remove.
1456         * utils.c (can_emit_style_escape): Likewise.
1457         Update all callers of can_emit_style_escape (SOMESTREAM) to
1458         SOMESTREAM->can_emit_style_escape.
1459         * source-cache.c (source_cache::get_source_lines): Likewise.
1460         * stack.c (frame_apply_command_count): Call execute_command_to_string
1461         passing the term_out characteristic of the current gdb_stdout.
1462         * thread.c (thr_try_catch_cmd): Likewise.
1463         * top.c (execute_command_to_string): pass term_out parameter
1464         to construct the string_file for the command output.
1465         * ui-file.c (term_cli_styling): New function (most code moved
1466         from utils.c can_emit_style_escape).
1467         (string_file::string_file, string_file::can_emit_style_escape,
1468         stdio_file::can_emit_style_escape, tee_file::term_out,
1469         tee_file::can_emit_style_escape): New functions.
1470
1471 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1472
1473         * NEWS: Mention the new set|show may-call-functions.
1474         * infcall.c (may_call_functions_p): New variable.
1475         (show_may_call_functions_p): New function.
1476         (call_function_by_hand_dummy): Throws an error if not
1477         may-call-functions.
1478         (_initialize_infcall): Call add_setshow_boolean_cmd for
1479         may-call-functions.
1480
1481 2019-04-25  Keith Seitz  <keiths@redhat.com>
1482
1483         PR c++/24367
1484         * cp-support.c (inspect_type): Don't attempt substitutions
1485         of symbol with the same name.
1486
1487 2019-04-25  Tom Tromey  <tromey@adacore.com>
1488
1489         PR gdb/24475:
1490         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1491         static.
1492
1493 2019-04-25  Tom Tromey  <tromey@adacore.com>
1494
1495         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1496         rvalue reference.
1497         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1498         (gdb_xml_parser::parse): Use std::move.
1499         * python/python-internal.h (gdbpy_convert_exception): Take a const
1500         reference.
1501         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1502         std::move.
1503         * python/py-utils.c (gdbpy_convert_exception): Take a const
1504         reference.
1505         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1506         Use std::move.
1507         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1508         Use std::move.
1509         * mi/mi-main.c (mi_print_exception): Take a const reference.
1510         * main.c (handle_command_errors): Take a const reference.
1511         * linespec.c (parse_linespec): Use std::move.
1512         * infcall.c (run_inferior_call): Use std::move.
1513         (call_function_by_hand_dummy): Use std::move.
1514         * exec.c (try_open_exec_file): Use std::move.
1515         * exceptions.h (exception_print, exception_fprintf)
1516         (exception_print_same): Update.
1517         * exceptions.c (print_exception, exception_print)
1518         (exception_fprintf, exception_print_same): Change parameters to
1519         const reference.
1520         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1521         * common/new-op.c: Use std::move.
1522         * common/common-exceptions.h (struct gdb_exception): Add move
1523         constructor.
1524         (struct gdb_exception_error, struct gdb_exception_quit, struct
1525         gdb_quit_bad_alloc): Change constructor to move constructor.
1526         (throw_exception): Change parameter to rvalue reference.
1527         * common/common-exceptions.c (throw_exception): Take rvalue
1528         reference.
1529         * cli/cli-interp.c (safe_execute_command): Use std::move.
1530         * breakpoint.c (insert_bp_location, location_to_sals): Use
1531         std::move.
1532
1533 2019-04-25  Tom Tromey  <tromey@adacore.com>
1534
1535         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1536         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1537         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1538         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1539         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1540         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1541         guile/scm-value.c: Use unpack.
1542         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1543         gdbscm_gdb_exception.
1544         (gdbscm_throw_gdb_exception): Likewise.
1545         (struct gdbscm_gdb_exception): New.
1546         (unpack): New function.
1547         (gdbscm_wrap): Use unpack.
1548
1549 2019-04-25  Tom Tromey  <tromey@adacore.com>
1550
1551         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1552         (gdb_rl_callback_handler): Use std::move.
1553         * common/common-exceptions.h (struct gdb_exception): Add move
1554         assignment operator.
1555         (throw_exception_sjlj): Change "exception" to const reference.
1556         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1557         (throw_exception_sjlj): Change "exception" to const reference.
1558
1559 2019-04-25  Tom Tromey  <tromey@adacore.com>
1560
1561         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1562         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1563         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1564         Update.
1565         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1566         Update.
1567         * mi/mi-interp.c (mi_interp::exec): Update.
1568         * linespec.c (parse_linespec): Update.
1569         * infcall.c (run_inferior_call): Update.
1570         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1571         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1572         (gdbscm_lookup_global_symbol): Update.
1573         * guile/scm-param.c (gdbscm_parameter_value): Update.
1574         * guile/scm-frame.c (gdbscm_frame_read_register)
1575         (gdbscm_frame_read_var): Update.
1576         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1577         * exec.c (try_open_exec_file): Update.
1578         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1579         (gdb_rl_callback_handler): Update.
1580         * common/common-exceptions.h (exception_none): Don't declare.
1581         * common/common-exceptions.c (exception_none): Don't define.
1582         (struct catcher) <exception>: Update.
1583         * cli/cli-interp.c (safe_execute_command): Update.
1584         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1585
1586 2019-04-25  Ali Tamur  <tamur@google.com>
1587
1588         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1589         (read_attribute_value): Likewise.
1590         (dwarf2_read_addr_index): Update comment.
1591         (read_str_index): Add DW_FORM_strx.
1592         (dwarf2_string_attr): Likewise.
1593         (dwarf2_const_value_attr): Likewise.
1594         (dump_die_shallow): Likewise.
1595         (dwarf2_fetch_constant_bytes): Likewise.
1596         (skip_form_bytes): Likewise.
1597         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1598
1599 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1600
1601         PR corefiles/11608
1602         PR corefiles/18187
1603         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1604         OFFSET.  Verify if current mapping contains an ELF header.
1605         (linux_find_memory_regions_full): Adjust call to
1606         dump_mapping_p.
1607
1608 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1609             Kang Li <kanglictf@gmail.com>
1610
1611         PR gdb/21600
1612
1613         * dwarf2-frame.c (read_initial_length): Be consistent about using
1614         unsigned representation of length.
1615         (decode_frame_entry_1): Likewise.  Check for wraparound of
1616         end pointer as well as buffer overflow.
1617
1618 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1619
1620         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1621         "vq".
1622
1623 2019-04-24  Tom Tromey  <tromey@adacore.com>
1624
1625         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1626
1627 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1628
1629         * s12z-tdep.c (s12z_unwind_pc): Delete.
1630         (s12z_unwind_sp): Delete.
1631         (s12z_gdbarch_init): Don't register deleted functions with
1632         gdbarch.
1633
1634 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1635
1636         * rl78-tdep.c (rl78_unwind_sp): Delete.
1637         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1638
1639 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1640
1641         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1642         (xstormy16_unwind_pc): Delete.
1643         (xstormy16_dummy_id): Delete.
1644         (xstormy16_gdbarch_init): Don't register deleted functions with
1645         gdbarch.
1646
1647 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1648
1649         * vax-tdep.c (vax_unwind_pc): Delete.
1650         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1651
1652 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1653
1654         * v850-tdep.c (v850_unwind_sp): Delete.
1655         (v850_unwind_pc): Delete.
1656         (v850_dummy_id): Delete.
1657         (v850_gdbarch_init): Don't register deleted functions with
1658         gdbarch.
1659
1660 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1661
1662         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1663         (tilegx_unwind_pc): Delete.
1664         (tilegx_unwind_dummy_id): Delete.
1665         (tilegx_gdbarch_init): Don't register deleted functions with
1666         gdbarch.
1667
1668 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1669
1670         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1671         (tic6x_dummy_id): Delete.
1672         (tic6x_gdbarch_init): Don't register deleted functions with
1673         gdbarch.
1674
1675 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1676
1677         * sparc-tdep.c (sparc_unwind_pc): Delete.
1678         (sparc32_gdbarch_init): Don't register deleted function with
1679         gdbarch.
1680
1681 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1682
1683         * sh-tdep.c (sh_unwind_sp): Delete.
1684         (sh_unwind_pc): Delete.
1685         (sh_dummy_id): Delete.
1686         (sh_gdbarch_init): Don't register deleted functions with
1687         gdbarch.
1688
1689 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1690
1691         * score-tdep.c (score_unwind_sp): Delete.
1692         (score_unwind_pc): Delete.
1693         (score_dummy_id): Delete.
1694         (score_gdbarch_init): Don't register deleted functions with
1695         gdbarch.
1696
1697 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1698
1699         * rx-tdep.c (rx_unwind_pc): Delete.
1700         (rx_unwind_sp): Delete.
1701         (rx_dummy_id): Delete.
1702         (rx_gdbarch_init): Don't register deleted functions with
1703         gdbarch.  Update comment.
1704
1705 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1706
1707         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1708         (rs6000_dummy_id): Delete.
1709         (rs6000_gdbarch_init): Don't register deleted functions with
1710         gdbarch.
1711
1712 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1713
1714         * or1k-tdep.c (or1k_dummy_id): Delete.
1715         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1716
1717 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1718
1719         * nios2-tdep.c (nios2_dummy_id): Delete.
1720         (nios2_unwind_sp): Delete.
1721         (nios2_gdbarch_init): Don't register deleted functions with
1722         gdbarch.
1723
1724 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1725
1726         * nds32-tdep.c (nds32_dummy_id): Delete.
1727         (nds32_unwind_pc): Delete.
1728         (nds32_unwind_sp): Delete.
1729         (nds32_gdbarch_init): Don't register deleted functions with
1730         gdbarch.
1731
1732 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1733
1734         * msp430-tdep.c (msp430_unwind_pc): Delete.
1735         (msp430_unwind_sp): Delete.
1736         (msp430_dummy_id): Delete.
1737         (msp430_gdbarch_init): Don't register deleted functions with
1738         gdbarch.
1739
1740 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1741
1742         * moxie-tdep.c (moxie_unwind_sp): Delete.
1743         (moxie_unwind_pc): Delete.
1744         (moxie_dummy_id): Delete.
1745         (moxie_gdbarch_init): Don't register deleted functions with
1746         gdbarch.
1747
1748 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1749
1750         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1751         (mn10300_unwind_pc): Delete.
1752         (mn10300_unwind_sp): Delete.
1753         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1754         mn10300_unwind_sp.
1755         (mn10300_frame_unwind_init): Don't register deleted functions with
1756         gdbarch.
1757
1758 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1759
1760         * mep-tdep.c (mep_unwind_pc): Delete.
1761         (mep_unwind_sp): Delete.
1762         (mep_dummy_id): Delete.
1763         (mep_gdbarch_init): Don't register deleted functions with
1764         gdbarch.
1765
1766 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1767
1768         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1769         (m68hc11_unwind_sp): Delete.
1770         (m68hc11_gdbarch_init): Don't register deleted functions with
1771         gdbarch.
1772
1773 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1774
1775         * m32r-tdep.c (m32r_unwind_sp): Delete.
1776         (m32r_unwind_pc): Delete.
1777         (m32r_dummy_id): Delete.
1778         (m32r_gdbarch_init): Don't register deleted functions with
1779         gdbarch.
1780
1781 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1782
1783         * m32c-tdep.c (m32c_unwind_pc): Delete.
1784         (m32c_unwind_sp): Delete.
1785         (m32c_dummy_id): Delete.
1786         (m32c_gdbarch_init): Don't register deleted functions with
1787         gdbarch.
1788
1789 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1790
1791         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1792         (lm32_unwind_pc): Delete.
1793         (lm32_dummy_id): Delete.
1794         (lm32_gdbarch_init): Don't register deleted functions with
1795         gdbarch.
1796
1797 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1798
1799         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1800         (iq2000_unwind_pc): Delete.
1801         (iq2000_dummy_id): Delete.
1802         (iq2000_gdbarch_init): Don't register deleted functions with
1803         gdbarch.
1804
1805 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1806
1807         * nds32-tdep.c (nds32_type_align): Delete.
1808         (nds32_push_dummy_call): Use type_align instead.
1809
1810 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1811
1812         * arm-tdep.c (arm_type_align): Only handle vector override case.
1813         (arm_push_dummy_call): Use type_align.
1814         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1815
1816 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1817
1818         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1819         case.
1820         (pass_on_stack): Use type_align.
1821         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1822         function.
1823
1824 2019-04-23  Tom Tromey  <tromey@adacore.com>
1825
1826         * dwarf2read.c (line_header::file_name_at): Remove unused
1827         overload.
1828
1829 2019-04-23  Tom de Vries  <tdevries@suse.de>
1830
1831         PR gdb/24438
1832         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1833         invocation.
1834
1835
1836 2019-03-27  Ali Tamur  <tamur@google.com>
1837
1838         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1839         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1840         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1841         (dwarf_expr_context::get_addr_index): Likewise
1842         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1843         (symbol_needs_eval_context::get_addr_index): Likewise
1844         (disassemble_dwarf_expression): Add DW_OP_addrx
1845         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1846         (read_cutu_die_from_dwo): Update comment
1847         (skip_one_die): Add DW_FORM_addrx
1848         (read_attribute_value): Likewise
1849         (var_decode_location): Add DW_OP_addrx
1850         (dwarf2_const_value_attr): Add DW_FORM_addrx
1851         (dump_die_shallow): Likewise
1852         (dwarf2_fetch_constant_bytes): Likewise
1853         (decode_locdesc): Add DW_OP_addrx
1854         (skip_form_bytes): Add DW_FORM_addrx
1855
1856 2019-04-22  Ali Tamur  <tamur@google.com>
1857
1858         * MAINTAINERS (Write After Approval): Add self.
1859
1860 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1861
1862         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1863         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1864         (open_symbol_file_object): Likewise.
1865         (svr4_default_sos): Add info parameter.
1866         (svr4_read_so_list): Likewise.
1867         (svr4_current_sos_direct): Adjust functions calls to pass down
1868         info.
1869         (svr4_current_sos_1): Add info parameter.
1870         (svr4_current_sos): Call get_svr4_info, pass info down to
1871         svr4_current_sos_1.
1872         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1873         get_svr4_info.
1874         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1875         get_svr4_info.
1876         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1877         to get_svr4_info.
1878         (probes_table_remove_objfile_probes): Likewise.
1879         (register_solib_event_probe): Add info parameter.
1880         (solist_update_incremental): Pass info parameter down to
1881         svr4_read_so_list.
1882         (disable_probes_interface): Add info parameter.
1883         (svr4_handle_solib_event): Pass current_program_space to
1884         get_svr4_info.  Adjust disable_probes_interface cleanup.
1885         (svr4_create_probe_breakpoints): Add info parameter, pass it
1886         down to register_solib_event_probe.
1887         (svr4_create_solib_event_breakpoints): Add info parameter,
1888         pass it down to svr4_create_probe_breakpoints.
1889         (enable_break): Pass info down to
1890         svr4_create_solib_event_breakpoints.
1891         (svr4_solib_create_inferior_hook): Pass current_program_space to
1892         get_svr4_info.
1893         (svr4_clear_solib): Likewise.
1894
1895 2019-04-22  Pedro Alves  <palves@redhat.com>
1896
1897         * solib-svr4.c (svr4_free_objfile_observer): New.
1898         (probe_and_action::objfile): New field.
1899         (probes_table_htab_remove_objfile_probes)
1900         (probes_table_remove_objfile_probes): New functions.
1901         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1902         in the new probe_and_action.  Don't store the probe in 'lookup'.
1903         (svr4_create_probe_breakpoints): Pass objfile to
1904         register_solib_event_probe.
1905         (_initialize_svr4_solib): Register a free_objfile observer.
1906
1907 2019-04-19  Tom Tromey  <tom@tromey.com>
1908
1909         * common/queue.h: Remove.
1910
1911 2019-04-19  Tom Tromey  <tom@tromey.com>
1912
1913         * event-loop.c: Don't include "common/queue.h".
1914
1915 2019-04-19  Tom Tromey  <tom@tromey.com>
1916
1917         * remote.c (remote_target): Use delete.
1918         * remote-notif.h: Include <list>, not "common/queue.h".
1919         (notif_client_p): Remove typedef.
1920         (remote_notif_state): Add constructor, destructor, initializer.
1921         <notif_queue>: Now a std::list.
1922         (remote_notif_state_xfree): Don't declare.
1923         * remote-notif.c (remote_notif_process, handle_notification)
1924         (remote_notif_state_allocate): Update.
1925         (~remote_notif_state): Rename from remote_notif_state_xfree.
1926
1927 2019-04-19  Tom Tromey  <tom@tromey.com>
1928
1929         * symfile.c (reread_symbols): Update.
1930         * objfiles.c (objfile_register_static_link)
1931         (objfile_lookup_static_link): Update
1932         (~objfile) Don't delete static_links.
1933         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1934
1935 2019-04-19  Tom Tromey  <tom@tromey.com>
1936
1937         * type-stack.h (struct type_stack) <insert>: Constify string.
1938         * type-stack.c (type_stack::insert): Constify string.
1939         * gdbtypes.h (lookup_template_type): Update.
1940         (address_space_name_to_int): Update.
1941         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1942         const.
1943         (lookup_template_type): Make name const.
1944         * c-exp.y: Update rules.
1945         (lex_one_token, classify_name, classify_inner_name)
1946         (c_print_token): Update.
1947         * p-exp.y: Update rules.
1948         (yylex): Update.
1949         * f-exp.y: Update rules.
1950         (yylex): Update.
1951         * d-exp.y: Update rules.
1952         (lex_one_token, classify_name, classify_inner_name): Update.
1953         * parse.c (write_dollar_variable, copy_name): Return std::string.
1954         * parser-defs.h (copy_name): Change return type.
1955         * m2-exp.y: Update rules.
1956         (yylex): Update.
1957         * go-exp.y (lex_one_token): Update.
1958         Update rules.
1959         (classify_unsafe_function, classify_packaged_name)
1960         (classify_name, yylex): Update.
1961
1962 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1963
1964         * configure.ac: add --enable-source-highlight switch.
1965         * configure: Regenerate.
1966         * top.c (print_gdb_version): plumb --enable-source-highlight
1967         status to "show configuration".
1968
1969 2019-04-19  Tom Tromey  <tromey@adacore.com>
1970
1971         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1972         Check ADA_TYPE_P.
1973         (empty_record, ada_template_to_fixed_record_type_1)
1974         (template_to_static_fixed_type)
1975         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1976         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1977         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1978         macros.
1979
1980 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1981
1982         PR symtab/24423:
1983         * source.c (print_source_lines_base): Advance "iter" when a
1984         control character is seen.
1985
1986 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1987
1988         * inferior.h (struct infcall_suspend_state_deleter):
1989         Catch exception in destructor to avoid crash.
1990
1991 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1992
1993         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1994         close to the add_com "shell".
1995
1996 2019-04-18  Tom Tromey  <tromey@adacore.com>
1997
1998         * process-stratum-target.h (class process_stratum_target)
1999         <stratum>: Add "final".
2000
2001 2019-04-17  Tom Tromey  <tromey@adacore.com>
2002
2003         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2004         against nullptr before use.
2005
2006 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2007
2008         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2009
2010 2019-04-17  Jim Wilson  <jimw@sifive.com>
2011             Andrew Burgess  <andrew.burgess@embecosm.com>
2012
2013         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2014         code read might fail, assume 4-byte breakpoint in that case.
2015
2016 2019-04-15  Leszek Swirski  <leszeks@google.com>
2017
2018         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2019         rather than a hand-rolled POD check when checking for forced MEMORY
2020         classification.
2021
2022 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2023
2024         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2025         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2026         function.
2027         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2028         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2029         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2030         declaration.
2031
2032 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2033
2034         * aarch64-linux-nat.c
2035         (aarch64_linux_nat_target::thread_architecture): Add override.
2036         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2037         each VQ.
2038
2039 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2040
2041         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2042
2043 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2044
2045         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2046         target types of size 96-bits, add some additional comments, and
2047         check that the builtin type we found was the correct size.
2048
2049 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2050
2051         * utils.c (prompt_for_continue): Don't restore the styling at the
2052         end, as applied_style has the wrong value.  This fixes styling in
2053         long lists of file names that are interrupted by the "Continue?"
2054         prompt.
2055
2056 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2057
2058         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2059         * c-lang.c (c_language_defn): Likewise.
2060         (cplus_language_defn): Likewise.
2061         (asm_language_defn): Likewise.
2062         (minimal_language_defn): Likewise.
2063         * d-lang.c (d_language_defn): Likewise.
2064         * f-lang.c (f_language_defn): Likewise.
2065         * go-lang.c (go_language_defn): Likewise.
2066         * language.c (unknown_language_defn): Likewise.
2067         (auto_language_defn): Likewise.
2068         * language.h (struct language_defn): Remove la_magic field.
2069         (LANG_MAGIC): Delete.
2070         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2071         * objc-lang.c (objc_language_defn): Likewise.
2072         * opencl-lang.c (opencl_language_defn): Likewise.
2073         * p-lang.c (pascal_language_defn): Likewise.
2074         * rust-lang.c (rust_language_defn): Likewise.
2075
2076 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2077
2078         * riscv-tdep.c (riscv_type_align): New function.
2079         (riscv_type_alignment): Delete.
2080         (riscv_arg_location): Use 'type_align'.
2081         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2082
2083 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2084
2085         * gdbtypes.c (type_align): A struct with no non-static fields also
2086         has alignment of 1.
2087
2088 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2089
2090         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2091         component to 0.
2092         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2093         member.
2094         (riscv_struct_info::analyse): New implementation using new
2095         analyse_inner member function.
2096         (riscv_struct_info::field_offset): New member function.
2097         (riscv_struct_info::m_offsets): New member variable.
2098         (riscv_struct_info::analyse_inner): New private member function,
2099         takes the old implementation of riscv_struct_info::analyse but
2100         extended to track field offsets.
2101         (riscv_call_arg_struct): Update the struct folding special cases
2102         to handle cases where empty C++ structs, which are non-zero
2103         length, are found.
2104         (riscv_arg_location): Initialise the length of each location, a
2105         non-zero length now indicates the location is in use.
2106         (riscv_push_dummy_call): Allow for the first location having a
2107         non-zero offset when setting up arguments.
2108         (riscv_return_value): Likewise, but for return values.
2109
2110 2019-04-11  Tom Tromey  <tromey@adacore.com>
2111
2112         * utils.c (internal_vproblem): Make "msg" const.
2113
2114 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2115
2116         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2117         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2118         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2119         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2120
2121 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2122
2123         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2124         function.
2125         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2126         of amd64_collect_native_gregset.
2127         (amd64_linux_nat_target::store_registers): Likewise.
2128
2129 2019-04-10  Tom Tromey  <tom@tromey.com>
2130
2131         * symtab.c (lookup_global_symbol_from_objfile)
2132         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2133         * objfiles.h (class separate_debug_iterator): New.
2134         (class separate_debug_range): New.
2135         (struct objfile) <separate_debug_objfiles>: New method.
2136         (objfile_separate_debug_iterate): Don't declare.
2137         * objfiles.c (separate_debug_iterator::operator++): Rename from
2138         objfile_separate_debug_iterate.
2139         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2140         iterator.
2141         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2142         iterator.
2143
2144 2019-04-10  Tom Tromey  <tom@tromey.com>
2145
2146         * symfile.c (reread_symbols): Remove old comment.
2147         * objfiles.c (free_all_objfiles): Fix a typo.
2148
2149 2019-04-10  Tom Tromey  <tom@tromey.com>
2150
2151         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2152         * minsyms.c (lookup_minimal_symbol): Use foreach.
2153         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2154         (lookup_minimal_symbol_solib_trampoline): Likewise.
2155         * symfile.c (reread_symbols): Use foreach.
2156
2157 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2158             Tom Tromey  <tromey@adacore.com>
2159
2160         PR rust/24414:
2161         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2162         (rust_lex_int_test): Change "value" to be LONGEST.
2163         (rust_lex_tests): Add test for long integer literal.
2164
2165 2019-04-09  Tom Tromey  <tromey@adacore.com>
2166
2167         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2168         to bool.
2169         (extended_remote_target::attach): Update.
2170         (remote_target::remote_notice_new_inferior): Update.
2171         (remote_target::add_current_inferior_and_thread): Update.
2172         * inferior.c (exit_inferior_1): Use "false".
2173         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2174
2175 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2176
2177         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2178         the "start" command.
2179
2180 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2181
2182         * python/py-inferior.c (infpy_thread_from_thread_handle):
2183         Adjust comments to reflect renaming of thread_from_thread_handle
2184         to thread_from_handle.  Adjust keywords.  Fix type error message.
2185         (inferior_object_methods): Add thread_from_handle.  Retain
2186         thread_from_thread_handle, but mark it as deprecated.
2187
2188 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2189
2190         * gdbthread.h (find_thread_by_handle): Revise declaration.
2191         * thread.c (find_thread_by_handle): Likewise.  Adjust
2192         implementation too.
2193         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2194         support for buffer objects as handles.
2195
2196 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2197
2198         * python/py-infthread.c (thpy_thread_handle): New function.
2199         (thread_object_methods): Register thpy_thread_handle.
2200
2201 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2202
2203         * gdbthread.h (thread_to_thread_handle): Declare.
2204         * thread.c (gdbtypes.h): Include.
2205         (thread_to_thread_handle): New function.
2206
2207         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2208         (target_thread_info_to_thread_handle): Declare.
2209         * target.c (target_thread_info_to_thread_handle): New function.
2210         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2211         * target-delegates.c: Regenerate.
2212
2213         * linux-thread-db.c (class thread_db_target): Add method
2214         thread_info_to_thread_handle.
2215         (thread_db_target::thread_info_to_thread_handle): Define.
2216         * remote.c (class remote_target): Add new method
2217         thread_info_to_thread_handle.
2218         (remote_target::thread_info_to_thread_handle): Define.
2219
2220 2019-04-08  Pedro Alves  <palves@redhat.com>
2221
2222         * common/common-exceptions.c (throw_exception): Don't create
2223         named object to throw; throw directly.
2224         (throw_it): Likewise.  Don't initialize gdb_exception::message
2225         here, with new; pass FMT and AP to the ctor instead.
2226         * common/common-exceptions.h: Include <string>.
2227         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2228         const char *, va_list)): New ctor.  Use std::make_shared.
2229         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2230         errors)): Delete.
2231         (gdb_exception_error::gdb_exception_error(enum errors, const char
2232         *, va_list)): New.
2233         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2234         Add assertion.
2235         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2236         errors)): Delete.
2237         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2238         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2239         Add assertion.
2240
2241 2019-04-08  Tom Tromey  <tom@tromey.com>
2242
2243         * valops.c (value_rtti_indirect_type): Replace throw_exception
2244         with throw.
2245         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2246         with throw.
2247         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2248         throw.
2249         * target.c (target_translate_tls_address): Replace throw_exception
2250         with throw.
2251         * stack.c (frame_apply_command_count): Replace throw_exception
2252         with throw.
2253         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2254         throw.
2255         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2256         with throw.
2257         * rs6000-tdep.c (rs6000_frame_cache)
2258         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2259         * remote.c: Replace throw_exception with throw.
2260         * record-full.c (record_full_message, record_full_wait_1)
2261         (record_full_restore): Replace throw_exception with throw.
2262         * record-btrace.c:
2263         (get_thread_current_frame_id, record_btrace_start_replaying)
2264         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2265         (cmd_record_btrace_start): Replace throw_exception with throw.
2266         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2267         throw.
2268         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2269         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2270         * linespec.c:
2271         (find_linespec_symbols): Replace throw_exception with throw.
2272         * infrun.c (displaced_step_prepare, resume): Replace
2273         throw_exception with throw.
2274         * infcmd.c (post_create_inferior): Replace throw_exception with
2275         throw.
2276         * inf-loop.c (inferior_event_handler): Replace throw_exception
2277         with throw.
2278         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2279         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2280         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2281         (get_prev_frame_always, get_frame_pc_if_available)
2282         (get_frame_address_in_block_if_available, get_frame_language):
2283         Replace throw_exception with throw.
2284         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2285         throw_exception with throw.
2286         * eval.c (fetch_subexp_value, evaluate_var_value)
2287         (evaluate_funcall, evaluate_subexp_standard): Replace
2288         throw_exception with throw.
2289         * dwarf2loc.c (call_site_find_chain)
2290         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2291         Replace throw_exception with throw.
2292         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2293         with throw.
2294         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2295         throw.
2296         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2297         * completer.c (complete_line_internal): Replace throw_exception
2298         with throw.
2299         * compile/compile-object-run.c (compile_object_run): Replace
2300         throw_exception with throw.
2301         * cli/cli-script.c (process_next_line): Replace throw_exception
2302         with throw.
2303         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2304         (btrace_enable, btrace_maint_update_pt_packets): Replace
2305         throw_exception with throw.
2306         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2307         throw_exception with throw.
2308         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2309         throw_exception with throw.
2310         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2311         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2312         * aarch64-tdep.c (aarch64_make_prologue_cache)
2313         (aarch64_make_stub_cache): Replace throw_exception with throw.
2314
2315 2019-04-08  Tom Tromey  <tom@tromey.com>
2316
2317         * common/common-exceptions.c (throw_exception): Rename from
2318         throw_exception_cxx.  Remove old copy.  Make argument const.
2319         (throw_it): Create and throw exception objects directly.
2320         * common/common-exceptions.h (throw_exception): Make argument
2321         const.
2322         (struct gdb_exception_error): Add constructor.
2323         (struct gdb_exception_quit): Add constructor.
2324
2325 2019-04-08  Tom Tromey  <tom@tromey.com>
2326
2327         * common/common-exceptions.h (exception_rethrow): Don't declare.
2328         (TRY_SJLJ): Update comment.
2329         (TRY, CATCH, END_CATCH): Remove.
2330         * common/common-exceptions.c (exception_rethrow): Remove.
2331
2332 2019-04-08  Tom Tromey  <tom@tromey.com>
2333
2334         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2335         Remove.
2336         (gdb_exception_error): Rename from
2337         gdb_exception_RETURN_MASK_ERROR.
2338         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2339         (gdb_quit_bad_alloc): Update.
2340         * aarch64-tdep.c: Update.
2341         * ada-lang.c: Update.
2342         * ada-typeprint.c: Update.
2343         * ada-valprint.c: Update.
2344         * amd64-tdep.c: Update.
2345         * arch-utils.c: Update.
2346         * break-catch-throw.c: Update.
2347         * breakpoint.c: Update.
2348         * btrace.c: Update.
2349         * c-varobj.c: Update.
2350         * cli/cli-cmds.c: Update.
2351         * cli/cli-interp.c: Update.
2352         * cli/cli-script.c: Update.
2353         * common/common-exceptions.c: Update.
2354         * common/new-op.c: Update.
2355         * common/selftest.c: Update.
2356         * compile/compile-c-symbols.c: Update.
2357         * compile/compile-cplus-symbols.c: Update.
2358         * compile/compile-object-load.c: Update.
2359         * compile/compile-object-run.c: Update.
2360         * completer.c: Update.
2361         * corelow.c: Update.
2362         * cp-abi.c: Update.
2363         * cp-support.c: Update.
2364         * cp-valprint.c: Update.
2365         * darwin-nat.c: Update.
2366         * disasm-selftests.c: Update.
2367         * dtrace-probe.c: Update.
2368         * dwarf-index-cache.c: Update.
2369         * dwarf-index-write.c: Update.
2370         * dwarf2-frame-tailcall.c: Update.
2371         * dwarf2-frame.c: Update.
2372         * dwarf2loc.c: Update.
2373         * dwarf2read.c: Update.
2374         * eval.c: Update.
2375         * event-loop.c: Update.
2376         * event-top.c: Update.
2377         * exec.c: Update.
2378         * f-valprint.c: Update.
2379         * fbsd-tdep.c: Update.
2380         * frame-unwind.c: Update.
2381         * frame.c: Update.
2382         * gdbtypes.c: Update.
2383         * gnu-v3-abi.c: Update.
2384         * guile/guile-internal.h: Update.
2385         * guile/scm-block.c: Update.
2386         * guile/scm-breakpoint.c: Update.
2387         * guile/scm-cmd.c: Update.
2388         * guile/scm-disasm.c: Update.
2389         * guile/scm-frame.c: Update.
2390         * guile/scm-lazy-string.c: Update.
2391         * guile/scm-math.c: Update.
2392         * guile/scm-param.c: Update.
2393         * guile/scm-ports.c: Update.
2394         * guile/scm-pretty-print.c: Update.
2395         * guile/scm-symbol.c: Update.
2396         * guile/scm-symtab.c: Update.
2397         * guile/scm-type.c: Update.
2398         * guile/scm-value.c: Update.
2399         * i386-linux-tdep.c: Update.
2400         * i386-tdep.c: Update.
2401         * inf-loop.c: Update.
2402         * infcall.c: Update.
2403         * infcmd.c: Update.
2404         * infrun.c: Update.
2405         * jit.c: Update.
2406         * language.c: Update.
2407         * linespec.c: Update.
2408         * linux-fork.c: Update.
2409         * linux-nat.c: Update.
2410         * linux-tdep.c: Update.
2411         * linux-thread-db.c: Update.
2412         * main.c: Update.
2413         * mi/mi-cmd-break.c: Update.
2414         * mi/mi-cmd-stack.c: Update.
2415         * mi/mi-interp.c: Update.
2416         * mi/mi-main.c: Update.
2417         * objc-lang.c: Update.
2418         * p-valprint.c: Update.
2419         * parse.c: Update.
2420         * ppc-linux-tdep.c: Update.
2421         * printcmd.c: Update.
2422         * python/py-arch.c: Update.
2423         * python/py-breakpoint.c: Update.
2424         * python/py-cmd.c: Update.
2425         * python/py-finishbreakpoint.c: Update.
2426         * python/py-frame.c: Update.
2427         * python/py-framefilter.c: Update.
2428         * python/py-gdb-readline.c: Update.
2429         * python/py-inferior.c: Update.
2430         * python/py-infthread.c: Update.
2431         * python/py-lazy-string.c: Update.
2432         * python/py-linetable.c: Update.
2433         * python/py-objfile.c: Update.
2434         * python/py-param.c: Update.
2435         * python/py-prettyprint.c: Update.
2436         * python/py-progspace.c: Update.
2437         * python/py-record-btrace.c: Update.
2438         * python/py-record.c: Update.
2439         * python/py-symbol.c: Update.
2440         * python/py-type.c: Update.
2441         * python/py-unwind.c: Update.
2442         * python/py-utils.c: Update.
2443         * python/py-value.c: Update.
2444         * python/python.c: Update.
2445         * record-btrace.c: Update.
2446         * record-full.c: Update.
2447         * remote-fileio.c: Update.
2448         * remote.c: Update.
2449         * riscv-tdep.c: Update.
2450         * rs6000-aix-tdep.c: Update.
2451         * rs6000-tdep.c: Update.
2452         * rust-exp.y: Update.
2453         * rust-lang.c: Update.
2454         * s390-tdep.c: Update.
2455         * selftest-arch.c: Update.
2456         * solib-dsbt.c: Update.
2457         * solib-frv.c: Update.
2458         * solib-spu.c: Update.
2459         * solib-svr4.c: Update.
2460         * solib.c: Update.
2461         * sparc64-linux-tdep.c: Update.
2462         * stack.c: Update.
2463         * symfile-mem.c: Update.
2464         * symmisc.c: Update.
2465         * target.c: Update.
2466         * thread.c: Update.
2467         * top.c: Update.
2468         * tracefile-tfile.c: Update.
2469         * tui/tui.c: Update.
2470         * typeprint.c: Update.
2471         * unittests/cli-utils-selftests.c: Update.
2472         * unittests/parse-connection-spec-selftests.c: Update.
2473         * valops.c: Update.
2474         * valprint.c: Update.
2475         * value.c: Update.
2476         * varobj.c: Update.
2477         * windows-nat.c: Update.
2478         * x86-linux-nat.c: Update.
2479         * xml-support.c: Update.
2480
2481 2019-04-08  Tom Tromey  <tom@tromey.com>
2482
2483         * xml-support.c: Use C++ exception handling.
2484         * x86-linux-nat.c: Use C++ exception handling.
2485         * windows-nat.c: Use C++ exception handling.
2486         * varobj.c: Use C++ exception handling.
2487         * value.c: Use C++ exception handling.
2488         * valprint.c: Use C++ exception handling.
2489         * valops.c: Use C++ exception handling.
2490         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2491         handling.
2492         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2493         * typeprint.c: Use C++ exception handling.
2494         * tui/tui.c: Use C++ exception handling.
2495         * tracefile-tfile.c: Use C++ exception handling.
2496         * top.c: Use C++ exception handling.
2497         * thread.c: Use C++ exception handling.
2498         * target.c: Use C++ exception handling.
2499         * symmisc.c: Use C++ exception handling.
2500         * symfile-mem.c: Use C++ exception handling.
2501         * stack.c: Use C++ exception handling.
2502         * sparc64-linux-tdep.c: Use C++ exception handling.
2503         * solib.c: Use C++ exception handling.
2504         * solib-svr4.c: Use C++ exception handling.
2505         * solib-spu.c: Use C++ exception handling.
2506         * solib-frv.c: Use C++ exception handling.
2507         * solib-dsbt.c: Use C++ exception handling.
2508         * selftest-arch.c: Use C++ exception handling.
2509         * s390-tdep.c: Use C++ exception handling.
2510         * rust-lang.c: Use C++ exception handling.
2511         * rust-exp.y: Use C++ exception handling.
2512         * rs6000-tdep.c: Use C++ exception handling.
2513         * rs6000-aix-tdep.c: Use C++ exception handling.
2514         * riscv-tdep.c: Use C++ exception handling.
2515         * remote.c: Use C++ exception handling.
2516         * remote-fileio.c: Use C++ exception handling.
2517         * record-full.c: Use C++ exception handling.
2518         * record-btrace.c: Use C++ exception handling.
2519         * python/python.c: Use C++ exception handling.
2520         * python/py-value.c: Use C++ exception handling.
2521         * python/py-utils.c: Use C++ exception handling.
2522         * python/py-unwind.c: Use C++ exception handling.
2523         * python/py-type.c: Use C++ exception handling.
2524         * python/py-symbol.c: Use C++ exception handling.
2525         * python/py-record.c: Use C++ exception handling.
2526         * python/py-record-btrace.c: Use C++ exception handling.
2527         * python/py-progspace.c: Use C++ exception handling.
2528         * python/py-prettyprint.c: Use C++ exception handling.
2529         * python/py-param.c: Use C++ exception handling.
2530         * python/py-objfile.c: Use C++ exception handling.
2531         * python/py-linetable.c: Use C++ exception handling.
2532         * python/py-lazy-string.c: Use C++ exception handling.
2533         * python/py-infthread.c: Use C++ exception handling.
2534         * python/py-inferior.c: Use C++ exception handling.
2535         * python/py-gdb-readline.c: Use C++ exception handling.
2536         * python/py-framefilter.c: Use C++ exception handling.
2537         * python/py-frame.c: Use C++ exception handling.
2538         * python/py-finishbreakpoint.c: Use C++ exception handling.
2539         * python/py-cmd.c: Use C++ exception handling.
2540         * python/py-breakpoint.c: Use C++ exception handling.
2541         * python/py-arch.c: Use C++ exception handling.
2542         * printcmd.c: Use C++ exception handling.
2543         * ppc-linux-tdep.c: Use C++ exception handling.
2544         * parse.c: Use C++ exception handling.
2545         * p-valprint.c: Use C++ exception handling.
2546         * objc-lang.c: Use C++ exception handling.
2547         * mi/mi-main.c: Use C++ exception handling.
2548         * mi/mi-interp.c: Use C++ exception handling.
2549         * mi/mi-cmd-stack.c: Use C++ exception handling.
2550         * mi/mi-cmd-break.c: Use C++ exception handling.
2551         * main.c: Use C++ exception handling.
2552         * linux-thread-db.c: Use C++ exception handling.
2553         * linux-tdep.c: Use C++ exception handling.
2554         * linux-nat.c: Use C++ exception handling.
2555         * linux-fork.c: Use C++ exception handling.
2556         * linespec.c: Use C++ exception handling.
2557         * language.c: Use C++ exception handling.
2558         * jit.c: Use C++ exception handling.
2559         * infrun.c: Use C++ exception handling.
2560         * infcmd.c: Use C++ exception handling.
2561         * infcall.c: Use C++ exception handling.
2562         * inf-loop.c: Use C++ exception handling.
2563         * i386-tdep.c: Use C++ exception handling.
2564         * i386-linux-tdep.c: Use C++ exception handling.
2565         * guile/scm-value.c: Use C++ exception handling.
2566         * guile/scm-type.c: Use C++ exception handling.
2567         * guile/scm-symtab.c: Use C++ exception handling.
2568         * guile/scm-symbol.c: Use C++ exception handling.
2569         * guile/scm-pretty-print.c: Use C++ exception handling.
2570         * guile/scm-ports.c: Use C++ exception handling.
2571         * guile/scm-param.c: Use C++ exception handling.
2572         * guile/scm-math.c: Use C++ exception handling.
2573         * guile/scm-lazy-string.c: Use C++ exception handling.
2574         * guile/scm-frame.c: Use C++ exception handling.
2575         * guile/scm-disasm.c: Use C++ exception handling.
2576         * guile/scm-cmd.c: Use C++ exception handling.
2577         * guile/scm-breakpoint.c: Use C++ exception handling.
2578         * guile/scm-block.c: Use C++ exception handling.
2579         * guile/guile-internal.h: Use C++ exception handling.
2580         * gnu-v3-abi.c: Use C++ exception handling.
2581         * gdbtypes.c: Use C++ exception handling.
2582         * frame.c: Use C++ exception handling.
2583         * frame-unwind.c: Use C++ exception handling.
2584         * fbsd-tdep.c: Use C++ exception handling.
2585         * f-valprint.c: Use C++ exception handling.
2586         * exec.c: Use C++ exception handling.
2587         * event-top.c: Use C++ exception handling.
2588         * event-loop.c: Use C++ exception handling.
2589         * eval.c: Use C++ exception handling.
2590         * dwarf2read.c: Use C++ exception handling.
2591         * dwarf2loc.c: Use C++ exception handling.
2592         * dwarf2-frame.c: Use C++ exception handling.
2593         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2594         * dwarf-index-write.c: Use C++ exception handling.
2595         * dwarf-index-cache.c: Use C++ exception handling.
2596         * dtrace-probe.c: Use C++ exception handling.
2597         * disasm-selftests.c: Use C++ exception handling.
2598         * darwin-nat.c: Use C++ exception handling.
2599         * cp-valprint.c: Use C++ exception handling.
2600         * cp-support.c: Use C++ exception handling.
2601         * cp-abi.c: Use C++ exception handling.
2602         * corelow.c: Use C++ exception handling.
2603         * completer.c: Use C++ exception handling.
2604         * compile/compile-object-run.c: Use C++ exception handling.
2605         * compile/compile-object-load.c: Use C++ exception handling.
2606         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2607         * compile/compile-c-symbols.c: Use C++ exception handling.
2608         * common/selftest.c: Use C++ exception handling.
2609         * common/new-op.c: Use C++ exception handling.
2610         * cli/cli-script.c: Use C++ exception handling.
2611         * cli/cli-interp.c: Use C++ exception handling.
2612         * cli/cli-cmds.c: Use C++ exception handling.
2613         * c-varobj.c: Use C++ exception handling.
2614         * btrace.c: Use C++ exception handling.
2615         * breakpoint.c: Use C++ exception handling.
2616         * break-catch-throw.c: Use C++ exception handling.
2617         * arch-utils.c: Use C++ exception handling.
2618         * amd64-tdep.c: Use C++ exception handling.
2619         * ada-valprint.c: Use C++ exception handling.
2620         * ada-typeprint.c: Use C++ exception handling.
2621         * ada-lang.c: Use C++ exception handling.
2622         * aarch64-tdep.c: Use C++ exception handling.
2623
2624 2019-04-08  Tom Tromey  <tom@tromey.com>
2625
2626         * xml-support.c (gdb_xml_parser::parse): Update.
2627         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2628         * value.c (show_convenience): Update.
2629         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2630         (test_parse_flags_qcs): Update.
2631         * thread.c (thr_try_catch_cmd): Update.
2632         * target.c (target_translate_tls_address): Update.
2633         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2634         (info_frame_command_core, frame_apply_command_count): Update.
2635         * rust-exp.y (rust_lex_exception_test): Update.
2636         * riscv-tdep.c (riscv_print_one_register_info): Update.
2637         * remote.c (remote_target::enable_btrace): Update.
2638         * record-btrace.c (record_btrace_enable_warn): Update.
2639         * python/py-utils.c (gdbpy_convert_exception): Update.
2640         * printcmd.c (do_one_display, print_variable_and_value): Update.
2641         * mi/mi-main.c (mi_print_exception): Update.
2642         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2643         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2644         * linux-nat.c (linux_nat_target::attach): Update.
2645         * linux-fork.c (class scoped_switch_fork_info): Update.
2646         * infrun.c (displaced_step_prepare): Update.
2647         * infcall.c (call_function_by_hand_dummy): Update.
2648         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2649         * gnu-v3-abi.c (print_one_vtable): Update.
2650         * frame.c (get_prev_frame_always): Update.
2651         * f-valprint.c (info_common_command_for_block): Update.
2652         * exec.c (try_open_exec_file): Update.
2653         * exceptions.c (print_exception, exception_print)
2654         (exception_fprintf, exception_print_same): Update.
2655         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2656         * dwarf-index-cache.c (index_cache::store)
2657         (index_cache::lookup_gdb_index): Update.
2658         * darwin-nat.c (maybe_cache_shell): Update.
2659         * cp-valprint.c (cp_print_value_fields): Update.
2660         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2661         (gcc_cplus_symbol_address): Update.
2662         * compile/compile-c-symbols.c (gcc_convert_symbol)
2663         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2664         * common/selftest.c: Update.
2665         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2666         a std::string.
2667         (exception_try_scope_entry, exception_try_scope_exit): Don't
2668         declare.
2669         (struct exception_try_scope): Remove.
2670         (TRY): Don't use exception_try_scope.
2671         (struct gdb_exception): Add constructor, operator=.
2672         <what>: New method.
2673         (struct gdb_exception_RETURN_MASK_ALL)
2674         (struct gdb_exception_RETURN_MASK_ERROR)
2675         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2676         (struct gdb_quit_bad_alloc): Update.
2677         * common/common-exceptions.c (exception_none): Change
2678         initializer.
2679         (struct catcher) <state, exception>: Initialize inline.
2680         <prev>: Remove member.
2681         (current_catcher): Remove.
2682         (catchers): New global.
2683         (exceptions_state_mc_init): Simplify.
2684         (catcher_pop): Remove.
2685         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2686         (try_scope_depth, exception_try_scope_entry)
2687         (exception_try_scope_exit): Remove.
2688         (throw_exception_sjlj): Update.
2689         (exception_messages, exception_messages_size): Remove.
2690         (throw_it): Simplify.
2691         (gdb_exception_sliced_copy): Remove.
2692         (throw_exception_cxx): Update.
2693         * cli/cli-script.c (script_from_file): Update.
2694         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2695         Update.
2696         * ada-valprint.c (ada_val_print): Update.
2697         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2698         (create_excep_cond_exprs): Update.
2699
2700 2019-04-08  Tom Tromey  <tom@tromey.com>
2701
2702         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2703         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2704         (TRY, CATCH, END_CATCH): Remove some definitions.
2705         * common/common-exceptions.c: Don't use GDB_XCPT.
2706         (catcher_list_size): Remove.
2707         (throw_exception, throw_it): Simplify.
2708
2709 2019-04-05  Tom Tromey  <tom@tromey.com>
2710
2711         Revert the header-sorting patch.
2712         * ft32-tdep.c: Revert.
2713         * frv-tdep.c: Revert.
2714         * frv-linux-tdep.c: Revert.
2715         * frame.c: Revert.
2716         * frame-unwind.c: Revert.
2717         * frame-base.c: Revert.
2718         * fork-child.c: Revert.
2719         * findvar.c: Revert.
2720         * findcmd.c: Revert.
2721         * filesystem.c: Revert.
2722         * filename-seen-cache.h: Revert.
2723         * filename-seen-cache.c: Revert.
2724         * fbsd-tdep.c: Revert.
2725         * fbsd-nat.h: Revert.
2726         * fbsd-nat.c: Revert.
2727         * f-valprint.c: Revert.
2728         * f-typeprint.c: Revert.
2729         * f-lang.c: Revert.
2730         * extension.h: Revert.
2731         * extension.c: Revert.
2732         * extension-priv.h: Revert.
2733         * expprint.c: Revert.
2734         * exec.h: Revert.
2735         * exec.c: Revert.
2736         * exceptions.c: Revert.
2737         * event-top.c: Revert.
2738         * event-loop.c: Revert.
2739         * eval.c: Revert.
2740         * elfread.c: Revert.
2741         * dwarf2read.h: Revert.
2742         * dwarf2read.c: Revert.
2743         * dwarf2loc.c: Revert.
2744         * dwarf2expr.h: Revert.
2745         * dwarf2expr.c: Revert.
2746         * dwarf2-frame.c: Revert.
2747         * dwarf2-frame-tailcall.c: Revert.
2748         * dwarf-index-write.h: Revert.
2749         * dwarf-index-write.c: Revert.
2750         * dwarf-index-common.c: Revert.
2751         * dwarf-index-cache.h: Revert.
2752         * dwarf-index-cache.c: Revert.
2753         * dummy-frame.c: Revert.
2754         * dtrace-probe.c: Revert.
2755         * disasm.h: Revert.
2756         * disasm.c: Revert.
2757         * disasm-selftests.c: Revert.
2758         * dictionary.c: Revert.
2759         * dicos-tdep.c: Revert.
2760         * demangle.c: Revert.
2761         * dcache.h: Revert.
2762         * dcache.c: Revert.
2763         * darwin-nat.h: Revert.
2764         * darwin-nat.c: Revert.
2765         * darwin-nat-info.c: Revert.
2766         * d-valprint.c: Revert.
2767         * d-namespace.c: Revert.
2768         * d-lang.c: Revert.
2769         * ctf.c: Revert.
2770         * csky-tdep.c: Revert.
2771         * csky-linux-tdep.c: Revert.
2772         * cris-tdep.c: Revert.
2773         * cris-linux-tdep.c: Revert.
2774         * cp-valprint.c: Revert.
2775         * cp-support.c: Revert.
2776         * cp-namespace.c: Revert.
2777         * cp-abi.c: Revert.
2778         * corelow.c: Revert.
2779         * corefile.c: Revert.
2780         * continuations.c: Revert.
2781         * completer.h: Revert.
2782         * completer.c: Revert.
2783         * complaints.c: Revert.
2784         * coffread.c: Revert.
2785         * coff-pe-read.c: Revert.
2786         * cli-out.h: Revert.
2787         * cli-out.c: Revert.
2788         * charset.c: Revert.
2789         * c-varobj.c: Revert.
2790         * c-valprint.c: Revert.
2791         * c-typeprint.c: Revert.
2792         * c-lang.c: Revert.
2793         * buildsym.c: Revert.
2794         * buildsym-legacy.c: Revert.
2795         * build-id.h: Revert.
2796         * build-id.c: Revert.
2797         * btrace.c: Revert.
2798         * bsd-uthread.c: Revert.
2799         * breakpoint.h: Revert.
2800         * breakpoint.c: Revert.
2801         * break-catch-throw.c: Revert.
2802         * break-catch-syscall.c: Revert.
2803         * break-catch-sig.c: Revert.
2804         * blockframe.c: Revert.
2805         * block.c: Revert.
2806         * bfin-tdep.c: Revert.
2807         * bfin-linux-tdep.c: Revert.
2808         * bfd-target.c: Revert.
2809         * bcache.c: Revert.
2810         * ax-general.c: Revert.
2811         * ax-gdb.h: Revert.
2812         * ax-gdb.c: Revert.
2813         * avr-tdep.c: Revert.
2814         * auxv.c: Revert.
2815         * auto-load.c: Revert.
2816         * arm-wince-tdep.c: Revert.
2817         * arm-tdep.c: Revert.
2818         * arm-symbian-tdep.c: Revert.
2819         * arm-pikeos-tdep.c: Revert.
2820         * arm-obsd-tdep.c: Revert.
2821         * arm-nbsd-tdep.c: Revert.
2822         * arm-nbsd-nat.c: Revert.
2823         * arm-linux-tdep.c: Revert.
2824         * arm-linux-nat.c: Revert.
2825         * arm-fbsd-tdep.c: Revert.
2826         * arm-fbsd-nat.c: Revert.
2827         * arm-bsd-tdep.c: Revert.
2828         * arch-utils.c: Revert.
2829         * arc-tdep.c: Revert.
2830         * arc-newlib-tdep.c: Revert.
2831         * annotate.h: Revert.
2832         * annotate.c: Revert.
2833         * amd64-windows-tdep.c: Revert.
2834         * amd64-windows-nat.c: Revert.
2835         * amd64-tdep.c: Revert.
2836         * amd64-sol2-tdep.c: Revert.
2837         * amd64-obsd-tdep.c: Revert.
2838         * amd64-obsd-nat.c: Revert.
2839         * amd64-nbsd-tdep.c: Revert.
2840         * amd64-nbsd-nat.c: Revert.
2841         * amd64-nat.c: Revert.
2842         * amd64-linux-tdep.c: Revert.
2843         * amd64-linux-nat.c: Revert.
2844         * amd64-fbsd-tdep.c: Revert.
2845         * amd64-fbsd-nat.c: Revert.
2846         * amd64-dicos-tdep.c: Revert.
2847         * amd64-darwin-tdep.c: Revert.
2848         * amd64-bsd-nat.c: Revert.
2849         * alpha-tdep.c: Revert.
2850         * alpha-obsd-tdep.c: Revert.
2851         * alpha-nbsd-tdep.c: Revert.
2852         * alpha-mdebug-tdep.c: Revert.
2853         * alpha-linux-tdep.c: Revert.
2854         * alpha-linux-nat.c: Revert.
2855         * alpha-bsd-tdep.c: Revert.
2856         * alpha-bsd-nat.c: Revert.
2857         * aix-thread.c: Revert.
2858         * agent.c: Revert.
2859         * addrmap.c: Revert.
2860         * ada-varobj.c: Revert.
2861         * ada-valprint.c: Revert.
2862         * ada-typeprint.c: Revert.
2863         * ada-tasks.c: Revert.
2864         * ada-lang.c: Revert.
2865         * aarch64-tdep.c: Revert.
2866         * aarch64-ravenscar-thread.c: Revert.
2867         * aarch64-newlib-tdep.c: Revert.
2868         * aarch64-linux-tdep.c: Revert.
2869         * aarch64-linux-nat.c: Revert.
2870         * aarch64-fbsd-tdep.c: Revert.
2871         * aarch64-fbsd-nat.c: Revert.
2872         * aarch32-linux-nat.c: Revert.
2873
2874 2019-04-05  Tom Tromey  <tom@tromey.com>
2875
2876         * ft32-tdep.c: Sort headers.
2877         * frv-tdep.c: Sort headers.
2878         * frv-linux-tdep.c: Sort headers.
2879         * frame.c: Sort headers.
2880         * frame-unwind.c: Sort headers.
2881         * frame-base.c: Sort headers.
2882         * fork-child.c: Sort headers.
2883         * findvar.c: Sort headers.
2884         * findcmd.c: Sort headers.
2885         * filesystem.c: Sort headers.
2886         * filename-seen-cache.h: Sort headers.
2887         * filename-seen-cache.c: Sort headers.
2888         * fbsd-tdep.c: Sort headers.
2889         * fbsd-nat.h: Sort headers.
2890         * fbsd-nat.c: Sort headers.
2891         * f-valprint.c: Sort headers.
2892         * f-typeprint.c: Sort headers.
2893         * f-lang.c: Sort headers.
2894         * extension.h: Sort headers.
2895         * extension.c: Sort headers.
2896         * extension-priv.h: Sort headers.
2897         * expprint.c: Sort headers.
2898         * exec.h: Sort headers.
2899         * exec.c: Sort headers.
2900         * exceptions.c: Sort headers.
2901         * event-top.c: Sort headers.
2902         * event-loop.c: Sort headers.
2903         * eval.c: Sort headers.
2904         * elfread.c: Sort headers.
2905         * dwarf2read.h: Sort headers.
2906         * dwarf2read.c: Sort headers.
2907         * dwarf2loc.c: Sort headers.
2908         * dwarf2expr.h: Sort headers.
2909         * dwarf2expr.c: Sort headers.
2910         * dwarf2-frame.c: Sort headers.
2911         * dwarf2-frame-tailcall.c: Sort headers.
2912         * dwarf-index-write.h: Sort headers.
2913         * dwarf-index-write.c: Sort headers.
2914         * dwarf-index-common.c: Sort headers.
2915         * dwarf-index-cache.h: Sort headers.
2916         * dwarf-index-cache.c: Sort headers.
2917         * dummy-frame.c: Sort headers.
2918         * dtrace-probe.c: Sort headers.
2919         * disasm.h: Sort headers.
2920         * disasm.c: Sort headers.
2921         * disasm-selftests.c: Sort headers.
2922         * dictionary.c: Sort headers.
2923         * dicos-tdep.c: Sort headers.
2924         * demangle.c: Sort headers.
2925         * dcache.h: Sort headers.
2926         * dcache.c: Sort headers.
2927         * darwin-nat.h: Sort headers.
2928         * darwin-nat.c: Sort headers.
2929         * darwin-nat-info.c: Sort headers.
2930         * d-valprint.c: Sort headers.
2931         * d-namespace.c: Sort headers.
2932         * d-lang.c: Sort headers.
2933         * ctf.c: Sort headers.
2934         * csky-tdep.c: Sort headers.
2935         * csky-linux-tdep.c: Sort headers.
2936         * cris-tdep.c: Sort headers.
2937         * cris-linux-tdep.c: Sort headers.
2938         * cp-valprint.c: Sort headers.
2939         * cp-support.c: Sort headers.
2940         * cp-namespace.c: Sort headers.
2941         * cp-abi.c: Sort headers.
2942         * corelow.c: Sort headers.
2943         * corefile.c: Sort headers.
2944         * continuations.c: Sort headers.
2945         * completer.h: Sort headers.
2946         * completer.c: Sort headers.
2947         * complaints.c: Sort headers.
2948         * coffread.c: Sort headers.
2949         * coff-pe-read.c: Sort headers.
2950         * cli-out.h: Sort headers.
2951         * cli-out.c: Sort headers.
2952         * charset.c: Sort headers.
2953         * c-varobj.c: Sort headers.
2954         * c-valprint.c: Sort headers.
2955         * c-typeprint.c: Sort headers.
2956         * c-lang.c: Sort headers.
2957         * buildsym.c: Sort headers.
2958         * buildsym-legacy.c: Sort headers.
2959         * build-id.h: Sort headers.
2960         * build-id.c: Sort headers.
2961         * btrace.c: Sort headers.
2962         * bsd-uthread.c: Sort headers.
2963         * breakpoint.h: Sort headers.
2964         * breakpoint.c: Sort headers.
2965         * break-catch-throw.c: Sort headers.
2966         * break-catch-syscall.c: Sort headers.
2967         * break-catch-sig.c: Sort headers.
2968         * blockframe.c: Sort headers.
2969         * block.c: Sort headers.
2970         * bfin-tdep.c: Sort headers.
2971         * bfin-linux-tdep.c: Sort headers.
2972         * bfd-target.c: Sort headers.
2973         * bcache.c: Sort headers.
2974         * ax-general.c: Sort headers.
2975         * ax-gdb.h: Sort headers.
2976         * ax-gdb.c: Sort headers.
2977         * avr-tdep.c: Sort headers.
2978         * auxv.c: Sort headers.
2979         * auto-load.c: Sort headers.
2980         * arm-wince-tdep.c: Sort headers.
2981         * arm-tdep.c: Sort headers.
2982         * arm-symbian-tdep.c: Sort headers.
2983         * arm-pikeos-tdep.c: Sort headers.
2984         * arm-obsd-tdep.c: Sort headers.
2985         * arm-nbsd-tdep.c: Sort headers.
2986         * arm-nbsd-nat.c: Sort headers.
2987         * arm-linux-tdep.c: Sort headers.
2988         * arm-linux-nat.c: Sort headers.
2989         * arm-fbsd-tdep.c: Sort headers.
2990         * arm-fbsd-nat.c: Sort headers.
2991         * arm-bsd-tdep.c: Sort headers.
2992         * arch-utils.c: Sort headers.
2993         * arc-tdep.c: Sort headers.
2994         * arc-newlib-tdep.c: Sort headers.
2995         * annotate.h: Sort headers.
2996         * annotate.c: Sort headers.
2997         * amd64-windows-tdep.c: Sort headers.
2998         * amd64-windows-nat.c: Sort headers.
2999         * amd64-tdep.c: Sort headers.
3000         * amd64-sol2-tdep.c: Sort headers.
3001         * amd64-obsd-tdep.c: Sort headers.
3002         * amd64-obsd-nat.c: Sort headers.
3003         * amd64-nbsd-tdep.c: Sort headers.
3004         * amd64-nbsd-nat.c: Sort headers.
3005         * amd64-nat.c: Sort headers.
3006         * amd64-linux-tdep.c: Sort headers.
3007         * amd64-linux-nat.c: Sort headers.
3008         * amd64-fbsd-tdep.c: Sort headers.
3009         * amd64-fbsd-nat.c: Sort headers.
3010         * amd64-dicos-tdep.c: Sort headers.
3011         * amd64-darwin-tdep.c: Sort headers.
3012         * amd64-bsd-nat.c: Sort headers.
3013         * alpha-tdep.c: Sort headers.
3014         * alpha-obsd-tdep.c: Sort headers.
3015         * alpha-nbsd-tdep.c: Sort headers.
3016         * alpha-mdebug-tdep.c: Sort headers.
3017         * alpha-linux-tdep.c: Sort headers.
3018         * alpha-linux-nat.c: Sort headers.
3019         * alpha-bsd-tdep.c: Sort headers.
3020         * alpha-bsd-nat.c: Sort headers.
3021         * aix-thread.c: Sort headers.
3022         * agent.c: Sort headers.
3023         * addrmap.c: Sort headers.
3024         * ada-varobj.c: Sort headers.
3025         * ada-valprint.c: Sort headers.
3026         * ada-typeprint.c: Sort headers.
3027         * ada-tasks.c: Sort headers.
3028         * ada-lang.c: Sort headers.
3029         * aarch64-tdep.c: Sort headers.
3030         * aarch64-ravenscar-thread.c: Sort headers.
3031         * aarch64-newlib-tdep.c: Sort headers.
3032         * aarch64-linux-tdep.c: Sort headers.
3033         * aarch64-linux-nat.c: Sort headers.
3034         * aarch64-fbsd-tdep.c: Sort headers.
3035         * aarch64-fbsd-nat.c: Sort headers.
3036         * aarch32-linux-nat.c: Sort headers.
3037
3038 2019-04-04  Tom Tromey  <tom@tromey.com>
3039
3040         * varobj.c (varobj_create): Update.
3041         * rust-exp.y (struct rust_parser) <update_innermost_block,
3042         lookup_symbol>: New methods.
3043         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3044         Rename.
3045         (rust_parser::rust_lookup_type)
3046         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3047         * printcmd.c (display_command, do_one_display): Update.
3048         * parser-defs.h (struct parser_state) <parser_state>: Add
3049         "tracker" parameter.
3050         (block_tracker): New member.
3051         (class innermost_block_tracker) <innermost_block_tracker>: Add
3052         "types" parameter.
3053         <reset>: Remove method.
3054         (innermost_block): Don't declare.
3055         (null_post_parser): Update.
3056         * parse.c (innermost_block): Remove global.
3057         (write_dollar_variable): Update.
3058         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3059         Remove "tracker_types" parameter.
3060         (parse_expression): Add "tracker" parameter.
3061         (parse_expression_for_completion): Update.
3062         (null_post_parser): Add "tracker" parameter.
3063         * p-exp.y: Update rules.
3064         * m2-exp.y: Update rules.
3065         * language.h (struct language_defn) <la_post_parser>: Add
3066         "tracker" parameter.
3067         * go-exp.y: Update rules.
3068         * f-exp.y: Update rules.
3069         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3070         parameter.
3071         * d-exp.y: Update rules.
3072         * c-exp.y: Update rules.
3073         * breakpoint.c (set_breakpoint_condition): Create an
3074         innermost_block_tracker.
3075         (watch_command_1): Likewise.
3076         * ada-lang.c (resolve): Add "tracker" parameter.
3077         (resolve_subexp): Likewise.
3078         * ada-exp.y (write_var_from_sym): Update.
3079
3080 2019-04-04  Tom Tromey  <tom@tromey.com>
3081
3082         * type-stack.h: New file.
3083         * type-stack.c: New file.
3084         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3085         type-stack.h.
3086         (insert_into_type_stack, insert_type, push_type, push_type_int)
3087         (insert_type_address_space, pop_type, pop_type_int)
3088         (pop_typelist, pop_type_stack, append_type_stack)
3089         (push_type_stack, get_type_stack, push_typelist)
3090         (follow_type_instance_flags, follow_types): Don't declare.
3091         * parse.c (type_stack): Remove global.
3092         (parse_exp_in_context): Update.
3093         (insert_into_type_stack, insert_type, push_type, push_type_int)
3094         (insert_type_address_space, pop_type, pop_type_int)
3095         (pop_typelist, pop_type_stack, append_type_stack)
3096         (push_type_stack, get_type_stack, push_typelist)
3097         (follow_type_instance_flags, follow_types): Remove (moved to
3098         type-stack.c).
3099         * f-exp.y (type_stack): New global.
3100         Update rules.
3101         (push_kind_type, f_parse): Update.
3102         * d-exp.y (type_stack): New global.
3103         Update rules.
3104         (d_parse): Update.
3105         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3106         Update rules.
3107         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3108         (HFILES_NO_SRCDIR): Add type-stack.h.
3109
3110 2019-04-04  Tom Tromey  <tom@tromey.com>
3111
3112         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3113         (rust_parser::convert_ast_to_expression, rust_parse)
3114         (rust_lex_test_completion, rust_lex_tests): Update.
3115         * parser-defs.h (struct expr_completion_state): New.
3116         (struct parser_state) <parser_state>: Add completion parameter.
3117         <mark_struct_expression, mark_completion_tag>: New methods.
3118         <parse_completion, m_completion_state>: New members.
3119         (prefixify_expression, null_post_parser): Update.
3120         (mark_struct_expression, mark_completion_tag): Don't declare.
3121         * parse.c (parse_completion, expout_last_struct)
3122         (expout_tag_completion_type, expout_completion_name): Remove
3123         globals.
3124         (parser_state::mark_struct_expression)
3125         (parser_state::mark_completion_tag): Now methods.
3126         (prefixify_expression): Add last_struct parameter.
3127         (prefixify_subexp): Likewise.
3128         (parse_exp_1): Update.
3129         (parse_exp_in_context): Add cstate parameter.  Update.
3130         (parse_expression_for_completion): Create an
3131         expr_completion_state.
3132         (null_post_parser): Add "completion" parameter.
3133         * p-exp.y: Update rules.
3134         (yylex): Update.
3135         * language.h (struct language_defn) <la_post_parser>: Add
3136         "completing" parameter.
3137         * go-exp.y: Update rules.
3138         (lex_one_token): Update.
3139         * expression.h (parse_completion): Don't declare.
3140         * d-exp.y: Update rules.
3141         (lex_one_token): Update rules.
3142         * c-exp.y: Update rules.
3143         (lex_one_token): Update.
3144         * ada-lang.c (resolve): Add "parse_completion" parameter.
3145         (resolve_subexp): Likewise.
3146         (ada_resolve_function): Likewise.
3147
3148 2019-04-04  Tom Tromey  <tom@tromey.com>
3149
3150         * parser-defs.h (struct parser_state) <start_arglist,
3151         end_arglist>: New methods.
3152         <arglist_len, m_funcall_chain>: New members.
3153         (arglist_len, start_arglist, end_arglist): Don't declare.
3154         * parse.c (arglist_len, funcall_chain): Remove global.
3155         (start_arglist, end_arglist): Remove functions.
3156         (parse_exp_in_context): Update.
3157         * p-exp.y: Update rules.
3158         * m2-exp.y: Update rules.
3159         * go-exp.y: Update rules.
3160         * f-exp.y: Update rules.
3161         * d-exp.y: Update rules.
3162         * c-exp.y: Update rules.
3163
3164 2019-04-04  Tom Tromey  <tom@tromey.com>
3165
3166         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3167         lex_operator, push_back>: New methods.
3168         Update all rules.
3169         (rust_parser::lex_hex, lex_escape): Rename and update.
3170         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3171         (rust_parser::lex_operator): Rename and update.
3172         (rust_parser::lex_number, rustyylex, rustyyerror)
3173         (rust_lex_test_init, rust_lex_test_sequence)
3174         (rust_lex_test_push_back, rust_lex_tests): Update.
3175         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3176         parameter.
3177         <lexptr, prev_lexptr>: New members.
3178         (lexptr, prev_lexptr): Don't declare.
3179         * parse.c (lexptr, prev_lexptr): Remove globals.
3180         (parse_exp_in_context): Update.
3181         * p-exp.y (yylex, yyerror): Update.
3182         * m2-exp.y (parse_number, yylex, yyerror): Update.
3183         * go-exp.y (lex_one_token, yyerror): Update.
3184         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3185         * d-exp.y (lex_one_token, yyerror): Update.
3186         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3187         (lex_one_token, yyerror): Update.
3188         * ada-lex.l (YY_INPUT): Update.
3189         (rewind_to_char): Update.
3190         * ada-exp.y (yyerror): Update.
3191
3192 2019-04-04  Tom Tromey  <tom@tromey.com>
3193
3194         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3195         * parser-defs.h (struct parser_state) <parser_state>: Add new
3196         parameter.
3197         <comma_terminates>: New member.
3198         (comma_terminates): Don't declare global.
3199         * parse.c (comma_terminates): Remove global.
3200         (parse_exp_in_context): Update.
3201         * p-exp.y (yylex): Update.
3202         * m2-exp.y (yylex): Update.
3203         * go-exp.y (lex_one_token): Update.
3204         * f-exp.y (yylex): Update.
3205         * d-exp.y (lex_one_token): Update.
3206         * c-exp.y (lex_one_token): Update.
3207         * ada-lex.l: Update.
3208
3209 2019-04-04  Tom Tromey  <tom@tromey.com>
3210
3211         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3212         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3213         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3214         * parser-defs.h (paren_depth): Don't declare.
3215         * parse.c (paren_depth): Remove global.
3216         (parse_exp_in_context): Update.
3217         * p-exp.y (paren_depth): New global.
3218         (pascal_parse): Initialize it.
3219         * m2-exp.y (paren_depth): New global.
3220         (m2_parse): Initialize it.
3221         * go-exp.y (paren_depth): New global.
3222         (go_parse): Initialize it.
3223         * f-exp.y (paren_depth): New global.
3224         (f_parse): Initialize it.
3225         * d-exp.y (paren_depth): New global.
3226         (d_parse): Initialize it.
3227         * c-exp.y (paren_depth): New global.
3228         (c_parse): Initialize it.
3229         * ada-lex.l (paren_depth): New global.
3230         (lexer_init): Initialize it.
3231
3232 2019-04-04  Tom Tromey  <tom@tromey.com>
3233
3234         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3235         (rust_parser::convert_ast_to_type)
3236         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3237         * parser-defs.h (struct parser_state) <parser_state>: Add
3238         parameters.  Initialize new members.
3239         <expression_context_block, expression_context_pc>: New members.
3240         * parse.c (expression_context_block, expression_context_pc):
3241         Remove globals.
3242         (parse_exp_in_context): Update.
3243         * p-exp.y: Update all rules.
3244         (yylex): Update.
3245         * m2-exp.y: Update all rules.
3246         (yylex): Update.
3247         * go-exp.y (yylex): Update.
3248         * f-exp.y (yylex): Update.
3249         * d-exp.y: Update all rules.
3250         (yylex): Update.
3251         * c-exp.y: Update all rules.
3252         (lex_one_token, classify_name, yylex, c_parse): Update.
3253         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3254
3255 2019-04-04  Tom Tromey  <tom@tromey.com>
3256
3257         * gdbarch.h, gdbarch.c: Rebuild.
3258         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3259         * stap-probe.h:
3260         (struct stap_parse_info): Replace "parser_state" with
3261         "expr_builder".
3262         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3263         (parser_state): New class.
3264         * parse.c (expr_builder): Rename.
3265         (expr_builder::release): Rename.
3266         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3267         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3268         (write_exp_elt_longcst, write_exp_elt_floatcst)
3269         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3270         (write_exp_string_vector, write_exp_bitstring)
3271         (write_exp_msymbol, mark_struct_expression)
3272         (write_dollar_variable)
3273         (insert_type_address_space, increase_expout_size): Replace
3274         "parser_state" with "expr_builder".
3275         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3276         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3277         "parser_state" with "expr_builder".
3278
3279 2019-04-04  Tom Tromey  <tom@tromey.com>
3280
3281         * rust-exp.y: Replace "parse_language" with method call.
3282         * p-exp.y:
3283         (yylex): Replace "parse_language" with method call.
3284         * m2-exp.y:
3285         (yylex): Replace "parse_language" with method call.
3286         * go-exp.y (classify_name): Replace "parse_language" with method
3287         call.
3288         * f-exp.y (yylex): Replace "parse_language" with method call.
3289         * d-exp.y (lex_one_token): Replace "parse_language" with method
3290         call.
3291         * c-exp.y:
3292         (lex_one_token, classify_name, yylex): Replace "parse_language"
3293         with method call.
3294         * ada-exp.y (find_primitive_type, type_char)
3295         (type_system_address): Replace "parse_language" with method call.
3296
3297 2019-04-04  Tom Tromey  <tom@tromey.com>
3298
3299         * rust-exp.y: Replace "parse_gdbarch" with method call.
3300         * parse.c (write_dollar_variable, insert_type_address_space):
3301         Replace "parse_gdbarch" with method call.
3302         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3303         call.
3304         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3305         call.
3306         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3307         "parse_gdbarch" with method call.
3308         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3309         with method call.
3310         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3311         "parse_gdbarch" with method call.
3312         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3313         "parse_gdbarch" with method call.
3314         * c-exp.y (parse_type, parse_number, classify_name): Replace
3315         "parse_gdbarch" with method call.
3316         * ada-lex.l: Replace "parse_gdbarch" with method call.
3317         * ada-exp.y (parse_type, find_primitive_type, type_char)
3318         (type_system_address): Replace "parse_gdbarch" with method call.
3319
3320 2019-04-04  Tom Tromey  <tom@tromey.com>
3321
3322         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3323         * stap-probe.c (stap_parse_argument): Update.
3324         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3325         initial_size parameter.
3326         * rust-exp.y (rust_lex_tests): Update.
3327         * parse.c (parser_state): Update.
3328         (parse_exp_in_context): Update.
3329         * parser-defs.h (struct parser_state) <parser_state>: Remove
3330         "initial_size" parameter.
3331
3332 2019-04-04  Tom Tromey  <tom@tromey.com>
3333
3334         * parser-defs.h (increase_expout_size): Don't declare.
3335         * parse.c (increase_expout_size): Now static.
3336
3337 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3338
3339         * gnu-nat.c (gnu_nat_target::wait): Fix
3340         target_waitstatus_to_string call.
3341
3342 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3343
3344         * eval.c (evaluate_subexp_standard): Handle internal functions
3345         during Fortran function call handling.
3346
3347 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3348
3349         * NEWS: Mention new internal functions.
3350         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3351         (read_base_type): Use dwarf2_init_complex_target_type.
3352         * value.c (creal_internal_fn): New function.
3353         (cimag_internal_fn): New function.
3354         (_initialize_values): Register new internal functions.
3355
3356 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3357
3358         * infrun.c (stop_all_threads): If debug_infrun, always
3359         trace the wait status after wait_one, using
3360         target_waitstatus_to_string and target_pid_to_str.
3361         (handle_inferior_event): Replace various trace of
3362         wait status kind by a single trace.
3363         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3364         wait status kind image by target_waitstatus_to_string.
3365         * target/waitstatus.c (target_waitstatus_to_string): Fix
3366         obsolete comment.
3367
3368 2019-04-01  Tom Tromey  <tromey@adacore.com>
3369
3370         PR symtab/23331:
3371         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3372
3373 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3374             Pedro Alves  <palves@redhat.com>
3375
3376         * top.c (quit_force): Call 'finalize_values'.
3377         * value.c (finalize_values): New function.
3378         * value.h (finalize_values): Declare.
3379
3380 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3381
3382         * NEWS: Announce $_gdb_major and $_gdb_minor.
3383
3384         * top.c (init_gdb_version_vars): New function.
3385         (gdb_init): Call init_gdb_version_vars.
3386
3387 2019-03-29  Tom Tromey  <tromey@adacore.com>
3388
3389         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3390         help text.  Remove dead code.
3391
3392 2019-03-29  Keith Seitz  <keiths@redhat.com>
3393
3394         From Siddhesh Poyarekar:
3395         * f-lang.h (f77_get_upperbound): Return LONGEST.
3396         (f77_get_lowerbound): Likewise.
3397         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3398         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3399         print them.
3400         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3401         plongest to format print it.
3402         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3403         (f77_get_upperbound): Likewise.
3404         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3405         LOWER_BOUND to LONGEST.
3406         (f77_create_arrayprint_offset_tbl): Likewise.
3407
3408 2019-03-29  Keith Seitz  <keiths@redhat.com>
3409
3410         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3411         %s/pulongest for TYPE_LENGTH instead of %d in format
3412         strings.
3413         * ada-typerint.c (ada_print_type): Likewise.
3414         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3415         * compile/compile-c-support.c (generate_register_struct): Likewise.
3416         * gdbtypes.c (recursive_dump_type): Likewise.
3417         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3418         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3419         instead of %d in format strings.
3420         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3421         to std::min to ULONGEST.
3422         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3423         instead of %d in format strings.
3424         * tracepoint.c (info_scope_command): Likewise.
3425         * typeprint.c (print_offset_data::update)
3426         (print_offset_data::finish): Likewise.
3427         * xtensa-tdep.c (xtensa_store_return_value)
3428         (xtensa_push_dummy_call): Likewise.
3429
3430 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3431
3432         * windows-nat.c (display_selector): Fixed format specifications
3433         for 64-bit Cygwin.
3434
3435 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3436
3437         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3438
3439 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3440
3441         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3442         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3443         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3444         (nios2_linux_init_abi): Install it.
3445
3446 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3447
3448         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3449
3450 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3451
3452         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3453
3454 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3455             Tom Tromey  <tromey@adacore.com>
3456
3457         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3458
3459 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3460
3461         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3462         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3463         method to compute the bounds of range types. Also print "[evaluated]"
3464         if the bounds' values come from a dynamic evaluation.
3465
3466 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3467
3468         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3469         whitespace when pretty printing is on.
3470
3471 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3472
3473         * ppc-linux-nat.c: Add include.
3474
3475 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3476
3477         * NEWS: Mention AArch64 Pointer Authentication.
3478
3479 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3480
3481         * arm-linux-nat.c: Add include.
3482
3483 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3484
3485         * source-cache.c (source_cache::get_source_lines): Re-read
3486         fullname after calling open_source_file.
3487
3488 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3489
3490         * NEWS: Mention TLS support for FreeBSD.
3491
3492 2019-03-25  Tom Tromey  <tromey@adacore.com>
3493
3494         * minsyms.c (BUNCH_SIZE): Update comment.
3495         (~minimal_symbol_reader): Remove old comment.
3496         (compact_minimal_symbols): Update comment.
3497         (minimal_symbol_reader::install): Remove old comment.  Update
3498         other comments.
3499
3500 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3501
3502         * s390-linux-nat.c: Add include.
3503
3504 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3505
3506         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3507         Call linux_get_hwcap.
3508         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3509         Likewise.
3510         (aarch64_linux_get_hwcap): Remove function.
3511         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3512         declaration.
3513         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3514         linux_get_hwcap.
3515         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3516         * linux-tdep.c (linux_get_hwcap): Add function.
3517         (linux_get_hwcap2): Likewise.
3518         * linux-tdep.h (linux_get_hwcap): Add declaration.
3519         (linux_get_hwcap2): Likewise.
3520         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3521         (ppc_linux_get_hwcap2): Likewise.
3522         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3523         linux_get_hwcap.
3524         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3525         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3526         (ppc_linux_nat_target::read_description): Likewise.
3527         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3528         * s390-linux-nat.c: Likewise.
3529         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3530
3531 2019-03-24  Tom Tromey  <tom@tromey.com>
3532
3533         * ada-lang.c (standard_lookup): Simplify initialization.
3534         (ada_lookup_symbol_nonlocal): Simplify return.
3535         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3536         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3537         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3538         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3539         initialization.
3540         * solib.c (solib_global_lookup): Simplify.
3541         * symtab.c (null_block_symbol): Remove.
3542         (symbol_cache_lookup): Simplify returns.
3543         (lookup_language_this): Simplify returns.
3544         (lookup_symbol_aux): Simplify return.
3545         (lookup_local_symbol): Simplify returns.
3546         (lookup_global_symbol_from_objfile): Simplify return.
3547         (lookup_symbol_in_objfile_symtabs)
3548         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3549         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3550         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3551         * cp-namespace.c (cp_lookup_bare_symbol)
3552         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3553         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3554         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3555         (cp_lookup_symbol_via_imports): Simplify initialization.
3556         (find_symbol_in_baseclass): Likewise.
3557         * symtab.h (null_block_symbol): Remove.
3558         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3559         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3560         (d_lookup_symbol_module): Likewise.
3561         (find_symbol_in_baseclass): Simplify initialization.
3562
3563 2019-03-24  Tom Tromey  <tom@tromey.com>
3564
3565         * expression.h: Don't include symtab.h.
3566         (struct block): Forward declare.
3567
3568 2019-03-24  Tom Tromey  <tom@tromey.com>
3569
3570         * c-exp.y (typebase): Remove casts.
3571         * gdbtypes.c (lookup_unsigned_typename, )
3572         (lookup_signed_typename): Remove cast.
3573         * eval.c (parse_to_comma_and_eval): Remove cast.
3574         * parse.c (write_dollar_variable): Remove cast.
3575         * block.h (struct block) <superblock>: Now const.
3576         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3577         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3578         (map_block): Make "block" const.
3579         * symfile.h (struct quick_symbol_functions)
3580         <map_matching_symbols>: Constify block argument to "callback".
3581         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3582         const.
3583         (find_pc_sect_compunit_symtab): Make "b" const.
3584         (find_symbol_at_address): Likewise.
3585         (search_symbols): Likewise.
3586         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3587         (dw2_debug_names_lookup_symbol): Likewise.
3588         (dw2_map_matching_symbols): Update.
3589         * p-valprint.c (pascal_val_print): Remove "block".
3590         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3591         (aux_add_nonlocal_symbols): Make "block" const.
3592         (resolve_subexp): Remove cast.
3593         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3594         const.
3595         (iterate_over_file_blocks): Likewise.
3596         * f-exp.y (%union) <bval>: Remove.
3597         * coffread.c (patch_opaque_types): Make "b" const.
3598         * spu-tdep.c (spu_catch_start): Make "block" const.
3599         * c-valprint.c (print_unpacked_pointer): Remove "block".
3600         * symmisc.c (dump_symtab_1): Make "b" const.
3601         (block_depth): Make "block" const.
3602         * d-exp.y (%union) <bval>: Remove.
3603         * cp-support.h (cp_lookup_rtti_type): Update.
3604         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3605         * psymtab.c (psym_lookup_symbol): Make "block" const.
3606         (maintenance_check_psymtabs): Make "b" const.
3607         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3608         (enumerate_locals, enumerate_args): Update.
3609         * python/py-symtab.c (stpy_global_block): Make "block" const.
3610         (stpy_static_block): Likewise.
3611         * inline-frame.c (block_starting_point_at): Make "new_block"
3612         const.
3613         * block.c (find_block_in_blockvector): Make return type const.
3614         (blockvector_for_pc_sect): Make "b" const.
3615         (find_block_in_blockvector): Make "b" const.
3616
3617 2019-03-23  Tom Tromey  <tom@tromey.com>
3618
3619         * varobj.c (varobj_create): Update.
3620         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3621         * printcmd.c (display_command, do_one_display): Don't reset
3622         innermost_block.
3623         * parser-defs.h (enum innermost_block_tracker_type): Move to
3624         expression.h.
3625         (innermost_block): Update comment.
3626         * parse.c (parse_exp_1): Add tracker_types parameter.
3627         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3628         tracker_types parameter.  Reset innermost_block.
3629         (parse_exp_in_context): Remove.
3630         (parse_expression_for_completion): Update.
3631         * objfiles.c (~objfile): Don't reset expression_context_block or
3632         innermost_block.
3633         * expression.h (enum innermost_block_tracker_type): Move from
3634         parser-defs.h.
3635         (parse_exp_1): Add tracker_types parameter.
3636         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3637         reset innermost_block.
3638
3639 2019-03-23  Tom Tromey  <tom@tromey.com>
3640
3641         * objfiles.h: Include bcache.h.
3642
3643 2019-03-23  Tom Tromey  <tom@tromey.com>
3644
3645         * linespec.c (get_current_search_block): Use
3646         scoped_restore_current_language.
3647         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3648
3649 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3650             Jiong Wang  <jiong.wang@arm.com>
3651
3652         * aarch64-linux-tdep.c
3653         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3654         section.
3655         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3656
3657 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3658             Jiong Wang  <jiong.wang@arm.com>
3659
3660         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3661         instructions.
3662         (aarch64_analyze_prologue_test): Add PACIASP test.
3663         (aarch64_prologue_prev_register): Unmask PC value.
3664
3665 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3666             Jiong Wang  <jiong.wang@arm.com>
3667
3668         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3669         (aarch64_dwarf2_prev_register): Unmask PC value.
3670         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3671         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3672         DW_CFA_AARCH64_negate_ra_state.
3673         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3674
3675 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3676             Jiong Wang  <jiong.wang@arm.com>
3677
3678         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3679         registers.
3680         (aarch64_pseudo_register_name): Likewise.
3681         (aarch64_pseudo_register_type): Likewise.
3682         (aarch64_pseudo_register_reggroup_p): Likewise.
3683         (aarch64_gdbarch_init): Add pauth registers.
3684         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3685         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3686         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3687         (struct gdbarch_tdep): Add regnum for ra_state.
3688
3689 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3690             Jiong Wang  <jiong.wang@arm.com>
3691
3692         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3693
3694 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3695             Jiong Wang  <jiong.wang@arm.com>
3696
3697         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3698         function.
3699         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3700         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3701         (aarch64_gdbarch_init): Add puth registers.
3702         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3703         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3704         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3705
3706 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3707             Jiong Wang  <jiong.wang@arm.com>
3708
3709         * aarch64-linux-nat.c
3710         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3711         * aarch64-linux-tdep.c
3712         (aarch64_linux_core_read_description): Likewise.
3713         (aarch64_linux_get_hwcap): New function.
3714         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3715         (aarch64_linux_get_hwcap): New declaration.
3716
3717 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3718             Jiong Wang  <jiong.wang@arm.com>
3719
3720         * aarch64-linux-nat.c
3721         (aarch64_linux_nat_target::read_description): Add pauth param.
3722         * aarch64-linux-tdep.c
3723         (aarch64_linux_core_read_description): Likewise.
3724         * aarch64-tdep.c (struct target_desc): Add in pauth.
3725         (aarch64_read_description): Add pauth param.
3726         (aarch64_gdbarch_init): Likewise.
3727         * aarch64-tdep.h (aarch64_read_description): Likewise.
3728         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3729         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3730         * features/Makefile: Add new files.
3731         * features/aarch64-pauth.c: New file.
3732         * features/aarch64-pauth.xml: New file.
3733
3734 2019-03-20  Tom Tromey  <tromey@adacore.com>
3735
3736         * infrun.c (handle_inferior_event): Rename from
3737         handle_inferior_event_1.  Create a scoped_value_mark.
3738         (handle_inferior_event): Remove.
3739
3740 2019-03-19  Tom Tromey  <tromey@adacore.com>
3741
3742         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3743         * infrun.h (print_stop_event): Add "displays" parameter.
3744         * infrun.c (print_stop_event): Add "displays" parameter.
3745
3746 2019-03-19  Pedro Alves  <palves@redhat.com>
3747
3748         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3749         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3750         to -1.  Fix TABs vs spaces.
3751         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3752         * tui/tui-out.h (tui_ui_out) Add intro comments.
3753         <m_line, m_start_of_line>: In-class initialize, and add describing
3754         comment.
3755
3756 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3757
3758         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3759         variable names.
3760         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3761
3762 2019-03-18  Pedro Alves  <palves@redhat.com>
3763             Eli Zaretskii <eliz@gnu.org>
3764
3765         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3766         m_line and m_start_of_line.
3767
3768 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3769
3770         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3771         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3772         it returns a newline.  This fixes a regression in TU mode, whereby
3773         the next line is output on the same screen line as the user input.
3774
3775 2019-03-18  Tom Tromey  <tromey@adacore.com>
3776
3777         * minsyms.c (minimal_symbol_reader::install): Remove call to
3778         obstack_blank.
3779
3780 2019-03-18  Pedro Alves  <palves@redhat.com>
3781
3782         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3783         New globals.
3784         (apply_style): New, factored out from ...
3785         (apply_ansi_escape): ... this.  Handle reverse video mode.
3786         (tui_set_reverse_mode): New function.
3787         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3788         * tui/tui-winsource.c (tui_show_source_line): Use
3789         tui_set_reverse_mode instead of setting A_STANDOUT.
3790         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3791         New setter methods.
3792
3793 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3794
3795         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3796         Handle tabs.
3797
3798 2019-03-18  Tom Tromey  <tromey@adacore.com>
3799
3800         * ada-lang.c (empty_array): Add "high" parameter.
3801         (ada_evaluate_subexp): Update.
3802
3803 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3804
3805         * unittests/string_view-selftests.c: Define
3806         _initialize_string_view_selftests unconditionally.
3807
3808 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3809
3810         PR gdb/24350
3811         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3812
3813 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3814
3815         PR gdb/24351
3816         * windows-nat.c (display_selector): Fix format specifiers.
3817
3818 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3819
3820         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3821         tui_refill_source_window instead of tui_refresh_win, to update the
3822         current execution line.  This fixes redisplay of the current line
3823         when stepping through the code with "next" or "step".
3824
3825 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3826
3827         * source-cache.c (source_cache::get_source_lines): Call
3828         find_source_lines to initialize s->nlines.  This fixes vertical
3829         scrolling of TUI source window when the DOWN arrow is pressed.
3830
3831 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3832
3833         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3834         linux-thread-db.c (_initialize_thread_db): Likewise.
3835
3836 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3837
3838         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3839         wclrtoeol in tui_show_source_line".  This reverts changes made in
3840         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3841
3842 2019-03-15  Tom Tromey  <tom@tromey.com>
3843
3844         * symtab.h (struct minimal_symbol): Derive from
3845         general_symbol_info.
3846         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3847         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3848         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3849         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3850         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3851         (MSYMBOL_SEARCH_NAME): Update.
3852         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3853         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3854         * minsyms.c (minimal_symbol_reader::record_full): Update.
3855
3856 2019-03-15  Tom Tromey  <tom@tromey.com>
3857
3858         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3859
3860 2019-03-15  Tom Tromey  <tom@tromey.com>
3861
3862         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3863         unique_xmalloc_ptr.
3864         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3865         Update.
3866         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3867         (build_minimal_symbol_hash_tables)
3868         (minimal_symbol_reader::install): Update.
3869
3870 2019-03-15  Tom Tromey  <tom@tromey.com>
3871
3872         * symtab.c (create_demangled_names_hash): Update.
3873         (symbol_set_names): Update.
3874         * objfiles.h (struct objfile_per_bfd_storage)
3875         <demangled_names_hash>: Now an htab_up.
3876         * objfiles.c (objfile_per_bfd_storage): Simplify.
3877
3878 2019-03-15  Tom Tromey  <tom@tromey.com>
3879
3880         * objfiles.h (struct objfile_per_bfd_storage): Declare
3881         destructor.
3882         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3883         New.
3884         (get_objfile_bfd_data): Use new.  Don't initialize
3885         language_of_main.
3886         (free_objfile_per_bfd_storage): Remove.
3887         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3888
3889 2019-03-15  Tom Tromey  <tom@tromey.com>
3890
3891         * symfile.c (reread_symbols): Update.
3892         * objfiles.c (objfile::objfile): Update.
3893         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3894         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3895         comment.
3896         (minimal_symbol_reader::install): Update.
3897         (terminate_minimal_symbol_table): Remove.
3898         * jit.c (jit_object_close_impl): Update.
3899
3900 2019-03-15  Tom Tromey  <tom@tromey.com>
3901
3902         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3903         initializations.
3904
3905 2019-03-15  Tom Tromey  <tom@tromey.com>
3906
3907         * objfiles.h (struct objfile_per_bfd_storage)
3908         <demangled_hash_languages>: Now a bitset.
3909         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3910         (lookup_minimal_symbol): Update.
3911
3912 2019-03-15  Tom Tromey  <tom@tromey.com>
3913
3914         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3915         Don't return the symbol.
3916         * coffread.c (record_minimal_symbol): Use record_full.
3917
3918 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3919
3920         The MS-Windows port of ncurses fails to switch to a color pair if
3921         one or both of the colors are the implicit default colors.  This
3922         change records the default colors when TUI is initialized, and
3923         then specifies them explicitly when a color pair uses the default
3924         colors.  This allows color styling in TUI mode on MS-Windows.
3925
3926         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3927         ncurses_norm_attr.
3928         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3929         colors in ncurses_norm_attr.
3930         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3931         "none", replace it with the default color recorded in
3932         ncurses_norm_attr.
3933
3934 2019-03-14  Tom Tromey  <tromey@adacore.com>
3935
3936         * source-cache.h (class source_cache) <get_source_lines>: Return
3937         std::string.
3938         * source-cache.c (source_cache::extract_lines): Handle case where
3939         first_pos==npos.  Return std::string.
3940         (source_cache::get_source_lines): Update.
3941
3942 2019-03-14  Tom Tromey  <tromey@adacore.com>
3943
3944         * NEWS: Add item for "style sources" commands.
3945         * source-cache.c (source_cache::get_source_lines): Check
3946         source_styling.
3947         * cli/cli-style.c (source_styling): New global.
3948         (_initialize_cli_style): Add "style sources" commands.
3949         (show_style_sources): New function.
3950         * cli/cli-style.h (source_styling): Declare.
3951
3952 2019-03-14  Pedro Alves  <palves@redhat.com>
3953             Tom Tromey  <tromey@adacore.com>
3954
3955         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3956         * tui/tui-winsource.c (tui_refill_source_window): New function,
3957         from...
3958         (tui_horizontal_source_scroll): ... here.  Move some logic.
3959         * cli/cli-style.c (set_style_enabled): Notify new observable.
3960         * tui/tui-hooks.c (tui_redisplay_source): New function.
3961         (tui_attach_detach_observers): Attach or detach
3962         tui_redisplay_source.
3963         * observable.h (source_styling_changed): New observable.
3964         * observable.c: Define source_styling_changed observable.
3965
3966 2019-03-13  Tom Tromey  <tromey@adacore.com>
3967
3968         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3969         (i386_gnu_nat_target::store_registers): Update.
3970         * target-debug.h (target_debug_print_std_string): New macro.
3971         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3972         * windows-tdep.c (display_one_tib): Update.
3973         * tui/tui-stack.c (tui_make_status_line): Update.
3974         * top.c (print_inferior_quit_action): Update.
3975         * thread.c (thr_try_catch_cmd): Update.
3976         (add_thread_with_info): Update.
3977         (thread_target_id_str): Update.
3978         (thr_try_catch_cmd): Update.
3979         (thread_command): Update.
3980         (thread_find_command): Update.
3981         * record-btrace.c (record_btrace_target::info_record)
3982         (record_btrace_resume_thread, record_btrace_target::resume)
3983         (record_btrace_cancel_resume, record_btrace_step_thread)
3984         (record_btrace_target::wait, record_btrace_target::wait)
3985         (record_btrace_target::wait, record_btrace_target::stop): Update.
3986         * progspace.c (print_program_space): Update.
3987         * process-stratum-target.c
3988         (process_stratum_target::thread_address_space): Update.
3989         * linux-fork.c (linux_fork_mourn_inferior)
3990         (detach_checkpoint_command, info_checkpoints_command)
3991         (linux_fork_context): Update.
3992         (linux_fork_detach): Update.
3993         (class scoped_switch_fork_info): Update.
3994         (delete_checkpoint_command): Update.
3995         * infrun.c (follow_fork_inferior): Update.
3996         (follow_fork_inferior): Update.
3997         (proceed_after_vfork_done): Update.
3998         (handle_vfork_child_exec_or_exit): Update.
3999         (follow_exec): Update.
4000         (displaced_step_prepare_throw): Update.
4001         (displaced_step_restore): Update.
4002         (start_step_over): Update.
4003         (resume_1): Update.
4004         (clear_proceed_status_thread): Update.
4005         (proceed): Update.
4006         (print_target_wait_results): Update.
4007         (do_target_wait): Update.
4008         (context_switch): Update.
4009         (stop_all_threads): Update.
4010         (restart_threads): Update.
4011         (finish_step_over): Update.
4012         (handle_signal_stop): Update.
4013         (switch_back_to_stepped_thread): Update.
4014         (keep_going_pass_signal): Update.
4015         (print_exited_reason): Update.
4016         (normal_stop): Update.
4017         * inferior.c (inferior_pid_to_str): Change return type.
4018         (print_selected_inferior): Update.
4019         (add_inferior): Update.
4020         (detach_inferior): Update.
4021         * dummy-frame.c (fprint_dummy_frames): Update.
4022         * dcache.c (dcache_info_1): Update.
4023         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4024         (btrace_fetch, btrace_clear): Update.
4025         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4026         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4027         type.
4028         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4029         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4030         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4031         * gdbarch.c, gdbarch.h: Rebuild.
4032         * gdbarch.sh (core_pid_to_str): Change return type.
4033         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4034         return type.
4035         (windows_nat_target::pid_to_str): Change return type.
4036         (windows_delete_thread): Update.
4037         (windows_nat_target::attach): Update.
4038         (windows_nat_target::files_info): Update.
4039         * target-delegates.c: Rebuild.
4040         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4041         return type.
4042         (sol_thread_target::pid_to_str): Change return type.
4043         * remote.c (class remote_target) <pid_to_str>: Change return
4044         type.
4045         (remote_target::pid_to_str): Change return type.
4046         (extended_remote_target::attach, remote_target::remote_stop_ns)
4047         (remote_target::remote_notif_remove_queued_reply)
4048         (remote_target::push_stop_reply, remote_target::disable_btrace):
4049         Update.
4050         (extended_remote_target::attach): Update.
4051         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4052         type.
4053         (gdbsim_target::pid_to_str): Change return type.
4054         * ravenscar-thread.c (struct ravenscar_thread_target)
4055         <pid_to_str>: Change return type.
4056         (ravenscar_thread_target::pid_to_str): Change return type.
4057         * procfs.c (class procfs_target) <pid_to_str>: Change return
4058         type.
4059         (procfs_target::pid_to_str): Change return type.
4060         (procfs_target::attach): Update.
4061         (procfs_target::detach): Update.
4062         (procfs_target::fetch_registers): Update.
4063         (procfs_target::store_registers): Update.
4064         (procfs_target::wait): Update.
4065         (procfs_target::files_info): Update.
4066         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4067         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4068         return type.
4069         (nto_procfs_target::pid_to_str): Change return type.
4070         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4071         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4072         return type.
4073         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4074         (exit_lwp): Update.
4075         (attach_proc_task_lwp_callback, get_detach_signal)
4076         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4077         (linux_nat_target::resume, wait_lwp, stop_callback)
4078         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4079         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4080         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4081         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4082         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4083         type.
4084         (inf_ptrace_target::attach): Update.
4085         (inf_ptrace_target::files_info): Update.
4086         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4087         type.
4088         (go32_nat_target::pid_to_str): Change return type.
4089         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4090         (gnu_nat_target::wait): Update.
4091         (gnu_nat_target::wait): Update.
4092         (gnu_nat_target::resume): Update.
4093         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4094         (fbsd_nat_target::wait): Update.
4095         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4096         type.
4097         (darwin_nat_target::attach): Update.
4098         * corelow.c (class core_target) <pid_to_str>: Change return type.
4099         (core_target::pid_to_str): Change return type.
4100         * target.c (normal_pid_to_str): Change return type.
4101         (default_pid_to_str): Likewise.
4102         (target_pid_to_str): Change return type.
4103         (target_translate_tls_address): Update.
4104         (target_announce_detach): Update.
4105         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4106         return type.
4107         (bsd_uthread_target::pid_to_str): Change return type.
4108         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4109         type.
4110         (bsd_kvm_target::pid_to_str): Change return type.
4111         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4112         return type.
4113         (aix_thread_target::pid_to_str): Change return type.
4114         * target.h (struct target_ops) <pid_to_str>: Change return type.
4115         (target_pid_to_str, normal_pid_to_str): Likewise.
4116         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4117         type.
4118         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4119         type.
4120         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4121         return type.
4122         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4123         type.
4124         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4125         type.
4126         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4127         return type.
4128
4129 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4130
4131         * NEWS: Mention that the new default MI version is 3.  Mention
4132         changes to the output of commands and events that deal with
4133         multi-location breakpoints.
4134         * breakpoint.c: Include "mi/mi-out.h".
4135         (print_one_breakpoint): Change output syntax if using MI version
4136         >= 3.
4137         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4138         New.
4139         (mi_multi_location_breakpoint_output_fixed): New.
4140         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4141         (mi_cmd_fix_multi_location_breakpoint_output): New.
4142         (mi_multi_location_breakpoint_output_fixed): New.
4143         * mi/mi-cmds.c (mi_cmds): Register command
4144         -fix-multi-location-breakpoint-output.
4145         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4146         interpreter "mi".
4147
4148 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4149
4150         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4151         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4152         instantiate mi_ui_out based on interpreter name.
4153         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4154         * mi/mi-main.c (mi_load_progress): Likewise.
4155
4156 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4157
4158         * NEWS: Combine separate "New targets" sections for 8.3.
4159
4160 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4161
4162         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4163         (ppcfbsd_init_abi): Install gdbarch
4164         "fetch_tls_load_module_address" and "get_thread_local_address"
4165         methods.
4166
4167 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4168
4169         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4170         (riscv_fbsd_init_abi): Install gdbarch
4171         "fetch_tls_load_module_address" and "get_thread_local_address"
4172         methods.
4173
4174 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4175
4176         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4177         (i386fbsd_init_abi): Install gdbarch
4178         "fetch_tls_load_module_address" and "get_thread_local_address"
4179         methods.
4180
4181 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4182
4183         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4184         (amd64fbsd_init_abi): Install gdbarch
4185         "fetch_tls_load_module_address" and "get_thread_local_address"
4186         methods.
4187
4188 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4189
4190         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4191         (struct fbsd_pspace_data): New type.
4192         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4193         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4194         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4195         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4196         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4197
4198 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4199
4200         * gdbtypes.c (lookup_struct_elt): New function.
4201         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4202         * gdbtypes.h (struct struct_elt): New type.
4203         (lookup_struct_elt): New prototype.
4204
4205 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4206
4207         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4208         remove disabled code block.
4209
4210 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4211
4212         * gdbarch.sh (get_thread_local_address): New method.
4213         * gdbarch.h, gdbarch.c: Regenerate.
4214         * target.c (target_translate_tls_address): Use
4215         gdbarch_get_thread_local_address if present instead of
4216         target::get_thread_local_address.
4217
4218 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4219
4220         * target.h (target::get_thread_local_address): Update comment.
4221
4222 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4223
4224         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4225         objfile->separate_debug_objfile_backlink if not NULL.
4226
4227 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4228
4229         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4230         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4231         (amd64bsd_store_inferior_registers): Likewise.
4232         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4233         Enable segment base registers.
4234         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4235         PT_GETFSBASE and PT_GETGSBASE.
4236         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4237         PT_SETGSBASE.
4238         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4239         segment base registers.
4240         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4241
4242 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4243
4244         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4245         Update calls to i386_target_description to add 'segments'
4246         parameter.
4247         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4248         add segment base registers.
4249         * arch/i386.c (i386_create_target_description): Add 'segments'
4250         parameter to enable segment base registers.
4251         * arch/i386.h (i386_create_target_description): Likewise.
4252         * features/i386/32bit-segments.xml: New file.
4253         * features/i386/32bit-segments.c: Generate.
4254         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4255         call to i386_target_description to add 'segments' parameter.
4256         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4257         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4258         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4259         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4260         if feature is present.
4261         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4262         Add 'segments' parameter to call to i386_target_description.
4263         (i386_target_description): Add 'segments' parameter to enable
4264         segment base registers.
4265         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4266         to call to i386_target_description.
4267         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4268         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4269         Define I386_NUM_REGS.
4270         (i386_target_description): Add 'segments' parameter to enable
4271         segment base registers.
4272
4273 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4274
4275         PR/24325
4276         * source-cache.c: #undef open and close, to avoid unresolved
4277         externals during linking.
4278
4279 2019-03-12  Tom Tromey  <tromey@adacore.com>
4280
4281         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4282         const.  Add initializers.
4283         (_initialize_remote): Don't initialize ptid globals.
4284
4285 2019-03-12  Pedro Alves  <palves@redhat.com>
4286
4287         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4288
4289 2019-03-12  Pedro Alves  <palves@redhat.com>
4290
4291         * cp-name-parser.y (main): Remove unused 'len' variable.
4292
4293 2019-03-12  Tom Tromey  <tromey@adacore.com>
4294
4295         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4296         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4297
4298 2019-03-12  Tom Tromey  <tromey@adacore.com>
4299
4300         * linux-nat.c (iterate_over_lwps): Update.
4301         (stop_callback): Remove parameter.
4302         (stop_wait_callback, detach_callback, resume_set_callback)
4303         (select_singlestep_lwp_callback, set_ignore_sigint)
4304         (status_callback, resumed_callback, resume_clear_callback)
4305         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4306         data parameter.
4307         (linux_nat_target::detach, linux_nat_target::resume)
4308         (linux_stop_and_wait_all_lwps, select_event_lwp)
4309         (linux_nat_filter_event, linux_nat_wait_1)
4310         (linux_nat_target::kill, linux_nat_target::stop)
4311         (linux_nat_target::stop): Update.
4312         (linux_nat_resume_callback): Change type.
4313         (resume_stopped_resumed_lwps, count_events_callback)
4314         (select_event_lwp_callback): Likewise.
4315         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4316         * arm-linux-nat.c (struct update_registers_data): Remove.
4317         (update_registers_callback): Change type.
4318         (arm_linux_insert_hw_breakpoint1): Update.
4319         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4320         parameter.
4321         (x86_linux_dr_set_addr): Update.
4322         (x86_linux_dr_set_control): Update.
4323         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4324         (iterate_over_lwps): Use gdb::function_view.
4325         * nat/aarch64-linux-hw-point.c (struct
4326         aarch64_dr_update_callback_param): Remove.
4327         (debug_reg_change_callback): Change type.
4328         (aarch64_notify_debug_reg_change): Update.
4329         * s390-linux-nat.c (s390_refresh_per_info): Update.
4330
4331 2019-03-11  Tom Tromey  <tromey@adacore.com>
4332
4333         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4334         redundant assignment to "this_cu".
4335
4336 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4337
4338         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4339
4340 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4341
4342         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4343         from...
4344         (rank_one_type): ... this.
4345
4346 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4347
4348         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4349         from...
4350         (rank_one_type): ... this.
4351
4352 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4353
4354         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4355         from...
4356         (rank_one_type): ... this.
4357
4358 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4359
4360         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4361         from...
4362         (rank_one_type): ... this.
4363
4364 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4365
4366         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4367         from...
4368         (rank_one_type): ... this.
4369
4370 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4371
4372         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4373         from...
4374         (rank_one_type): ... this.
4375
4376 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4377
4378         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4379         from...
4380         (rank_one_type): ... this.
4381
4382 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4383
4384         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4385         from...
4386         (rank_one_type): ... this.
4387
4388 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4389
4390         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4391         from...
4392         (rank_one_type): ... this.
4393
4394 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4395
4396         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4397         from...
4398         (rank_one_type): ... this.
4399
4400 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4401
4402         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4403         from...
4404         (rank_one_type): ... this.
4405
4406 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4407
4408         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4409         from...
4410         (rank_one_type): ... this.
4411
4412 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4413
4414         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4415         inferior-events' shows the example events.
4416
4417 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4418
4419         Support styling on native MS-Windows console
4420
4421         PR/24315
4422         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4423         on MS-Windows if $TERM is not defined.
4424
4425         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4426
4427         * posix-hdep.c (gdb_console_fputs):
4428         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4429         functions.
4430         * ui-file.h (gdb_console_fputs): Add prototype.
4431
4432         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4433         back to fputs only if the former returns zero.
4434
4435 2019-03-07  Tom Tromey  <tom@tromey.com>
4436
4437         * symmisc.c (print_symbol_bcache_statistics): Update.
4438         (print_objfile_statistics): Update.
4439         * symfile.c (allocate_symtab): Update.
4440         * stabsread.c: Don't include bcache.h.
4441         * psymtab.h (struct psymbol_bcache): Don't declare.
4442         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4443         (psymbol_bcache_init, psymbol_bcache_free)
4444         (psymbol_bcache_get_bcache): Don't declare.
4445         * psymtab.c (struct psymbol_bcache): Remove.
4446         (psymtab_storage::psymtab_storage): Update.
4447         (psymtab_storage::~psymtab_storage): Update.
4448         (psymbol_bcache_init, psymbol_bcache_free)
4449         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4450         (add_psymbol_to_bcache): Update.
4451         (allocate_psymtab): Update.
4452         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4453         macro_cache>: No longer pointers.
4454         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4455         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4456         * macrotab.c (macro_bcache): Update.
4457         * macroexp.c: Don't include bcache.h.
4458         * gdbtypes.c (check_types_worklist): Update.
4459         (types_deeply_equal): Remove TRY/CATCH.  Update.
4460         * elfread.c (elf_symtab_read): Update.
4461         * dwarf2read.c: Don't include bcache.h.
4462         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4463         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4464         (print_bcache_statistics, bcache_memory_used): Don't declare.
4465         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4466         methods.  Rename all data members.
4467         * bcache.c (struct bcache): Move to bcache.h.
4468         (bcache::expand_hash_table): Rename from expand_hash_table.
4469         (bcache): Remove.
4470         (bcache::insert): Rename from bcache_full.
4471         (bcache::compare): Rename from bcache_compare.
4472         (bcache_xmalloc): Remove.
4473         (bcache::~bcache): Rename from bcache_xfree.
4474         (bcache::print_statistics): Rename from print_bcache_statistics.
4475         (bcache::memory_used): Rename from bcache_memory_used.
4476
4477 2019-03-07  Pedro Alves  <palves@redhat.com>
4478
4479         * infrun.c (normal_stop): Also check for
4480         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4481
4482 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4483
4484         * f-lang.c (value_from_host_double): Moved to...
4485         * value.c (value_from_host_double): ...here.
4486         * value.h (value_from_host_double): Declare.
4487         * guile/scm-math.c (vlscm_convert_typed_number): Use
4488         value_from_host_double.
4489         (vlscm_convert_number): Likewise.
4490         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4491         * python/py-value.c (convert_value_from_python): Likewise.
4492
4493 2019-03-06  Tom Tromey  <tom@tromey.com>
4494
4495         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4496
4497 2019-03-06  Tom Tromey  <tom@tromey.com>
4498
4499         * utils.h (free_current_contents): Don't declare.
4500         * utils.c (free_current_contents): Remove.
4501
4502 2019-03-06  Tom Tromey  <tom@tromey.com>
4503
4504         * top.c (quit_force): Update.
4505         * main.c (captured_command_loop): Update.
4506         * common/new-op.c (operator new): Update.
4507         * common/common-exceptions.c (struct catcher)
4508         <save_cleanup_chain>: Remove member.
4509         (exceptions_state_mc_init): Update.
4510         (exception_try_scope_entry): Return nullptr.
4511         (exception_try_scope_exit, exception_rethrow)
4512         (throw_exception_sjlj, throw_exception_cxx): Update.
4513         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4514         (all_cleanups, do_cleanups, discard_cleanups)
4515         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4516         (restore_cleanups, restore_final_cleanups): Don't declare.
4517         (do_final_cleanups): Remove parameter.
4518         * common/cleanups.c (cleanup_chain, make_cleanup)
4519         (make_cleanup_dtor, all_cleanups, do_cleanups)
4520         (discard_my_cleanups, discard_cleanups)
4521         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4522         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4523         (null_cleanup): Remove.
4524         (do_final_cleanups): Remove parameter.
4525
4526 2019-03-06  Tom Tromey  <tom@tromey.com>
4527
4528         * remote.c (remote_target::remote_parse_stop_reply): Use
4529         unique_xmalloc_ptr.
4530
4531 2019-03-06  Tom Tromey  <tom@tromey.com>
4532
4533         * stabsread.c (struct stabs_field_info): Rename from field_info.
4534         <list, fnlist>: Add initializers.
4535         <obstack>: New member.
4536         (read_member_functions, read_struct_fields, read_baseclasses):
4537         Allocate on obstack.  Don't use cleanups.
4538         (read_one_struct_field, read_member_functions, read_struct_fields)
4539         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4540         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4541         (read_struct_type): Update.
4542
4543 2019-03-06  Tom Tromey  <tom@tromey.com>
4544
4545         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4546         * common/filestuff.h (make_cleanup_close): Don't declare.
4547         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4548         Remove.
4549
4550 2019-03-06  Tom Tromey  <tom@tromey.com>
4551
4552         * solib-aix.c: Use make_scope_exit.
4553
4554 2019-03-06  Tom Tromey  <tom@tromey.com>
4555
4556         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4557         Use make_scope_exit.
4558
4559 2019-03-06  Tom Tromey  <tom@tromey.com>
4560
4561         * solib-svr4.c (disable_probes_interface): Remove parameter.
4562         (svr4_handle_solib_event): Use make_scope_exit.
4563
4564 2019-03-06  Tom Tromey  <tom@tromey.com>
4565
4566         * remote.c (struct stop_reply_deleter): Remove.
4567         (stop_reply_up): Update.
4568         (struct stop_reply): Derive from notif_event.  Don't typedef.
4569         <regcache>: Now a std::vector.
4570         (stop_reply_xfree): Remove.
4571         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4572         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4573         (remote_target::discard_pending_stop_replies): Use delete.
4574         (remote_target::remote_parse_stop_reply): Update.
4575         (remote_target::process_stop_reply): Update.
4576         * remote-notif.h (struct notif_event): Add virtual destructor.
4577         Remove "dtr" member.
4578         (struct notif_client) <alloc_event>: Return a unique_ptr.
4579         (notif_event_xfree): Don't declare.
4580         (notif_event_up): New typedef.
4581         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4582         (notif_event_xfree, do_notif_event_xfree): Remove.
4583         (remote_notif_state_xfree): Update.
4584
4585 2019-03-06  Tom Tromey  <tom@tromey.com>
4586
4587         * infrun.c (displaced_step_clear_cleanup): Now a
4588         forward_scope_exit type.
4589         (displaced_step_prepare_throw): Update.
4590         (displaced_step_fixup): Update.
4591
4592 2019-03-06  Tom Tromey  <tom@tromey.com>
4593
4594         * inferior.h (class inferior): Update comment.
4595         * gdbthread.h (class thread_info): Update comment.
4596
4597 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4598             Tom Tromey  <tom@tromey.com>
4599
4600         * stabsread.h (struct stab_section_list): Remove.
4601         (coffstab_build_psymtabs): Update.
4602         * dbxread.c (symbuf_sections): Now a std::vector.
4603         (sect_idx): New global.
4604         (fill_symbuf): Update.
4605         (coffstab_build_psymtabs): Change type of stabsects parameter.
4606         Update.
4607         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4608         std::vector.
4609         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4610         (coff_locate_sections): Update.
4611         (coff_symfile_read): Remove cleanups.  Update.
4612         (init_stringtab): Add storage parameter.
4613         (free_stringtab, free_stringtab_cleanup): Remove.
4614         (init_lineno): Add storage parameter.
4615         (free_linetab, free_linetab_cleanup): Remove.
4616
4617 2019-03-06  Pedro Alves  <palves@redhat.com>
4618
4619         * linux-fork.c (fork_info::clobber_regs): Delete.
4620         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4621         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4622         comment.  Adjust.
4623         (scoped_switch_fork_info::scoped_switch_fork_info)
4624         (checkpoint_command, linux_fork_context): Adjust
4625         fork_save_infrun_state calls.
4626
4627 2019-03-06  Pedro Alves  <palves@redhat.com>
4628
4629         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4630         (inf_has_multiple_threads): Return 'bool' and rewrite using
4631         inferior_info::threads().
4632
4633 2019-03-06  Pedro Alves  <palves@redhat.com>
4634
4635         * linux-fork.c: Include <list>.
4636         (fork_list): Now a std::list instance.
4637         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4638         (forks_exist_p, find_last_fork): Adjust.
4639         (new_fork): Delete.
4640         (one_fork_p): New.
4641         (add_fork): Adjust.
4642         (free_fork): Delete, folded into fork_info::~fork_info().
4643         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4644         Adjust.
4645         (init_fork_list): Delete.
4646         (linux_fork_killall, linux_fork_mourn_inferior)
4647         (linux_fork_detach, info_checkpoints_command): Adjust.
4648         (_initialize_linux_fork): No longer call init_fork_list.
4649
4650 2019-03-06  Pedro Alves  <palves@redhat.com>
4651
4652         * linux-fork.c (new_fork): New, split out of ...
4653         (add_fork): ... this.  Return void.  Move "first fork" special
4654         case from here, to ...
4655         (checkpoint_command): ... here.
4656         * linux-linux.h (add_fork): Return void.
4657
4658 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4659
4660         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4661
4662 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4663             Chris January  <chris.january@arm.com>
4664             David Lecomber  <david.lecomber@arm.com>
4665
4666         * f-exp.y: New token, UNOP_INTRINSIC.
4667         (exp): New pattern using UNOP_INTRINSIC token.
4668         (f77_keywords): Add 'abs' keyword.
4669         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4670         (value_from_host_double): New function.
4671         (evaluate_subexp_f): Support UNOP_ABS.
4672
4673 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4674
4675         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4676         types.
4677
4678 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4679
4680         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4681         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4682         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4683
4684 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4685
4686         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4687
4688 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4689             Chris January  <chris.january@arm.com>
4690
4691         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4692         * f-exp.y: Define 'KIND' token.
4693         (exp): New pattern for KIND expressions.
4694         (ptype): Handle types with a kind extension.
4695         (direct_abs_decl): Extend to spot kind extensions.
4696         (f77_keywords): Add 'kind' to the list.
4697         (push_kind_type): New function.
4698         (convert_to_kind_type): New function.
4699         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4700         * parse.c (operator_length_standard): Likewise.
4701         * parser-defs.h (enum type_pieces): Add tp_kind.
4702         * std-operator.def: Add UNOP_KIND.
4703
4704 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4705
4706         * f-exp.y (f_parse): Set yydebug.
4707
4708 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4709
4710         * f-lang.c (evaluate_subexp_f): New function.
4711         (exp_descriptor_f): New global.
4712         (f_language_defn): Use exp_descriptor_f instead of
4713         exp_descriptor_standard.
4714
4715 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4716
4717         * f-exp.y (struct token): Add comments.
4718         (dot_ops): Remove uppercase versions and the end marker.
4719         (f77_keywords): Likewise.
4720         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4721         entries in the dot_ops array are case insensitive, and use
4722         strncasecmp to compare strings.  Also some whitespace cleanup in
4723         this area.  Similar for the f77_keywords array, except entries in
4724         this list might be case sensitive.
4725
4726 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4727
4728         * f-exp.y (struct f77_boolean_val): Add comments.
4729         (boolean_values): Remove uppercase versions, and end marker.
4730         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4731         and use strncasecmp to achieve case insensitivity.  Additionally,
4732         perform whitespace cleanup around this code.
4733
4734 2019-03-06  Tom Tromey  <tromey@adacore.com>
4735
4736         * remote-sim.c (gdbsim_target_open): Use result of
4737         gdb_argv::release.
4738
4739 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4740         Dirk Schubert  <dirk.schubert@arm.com>
4741         Chris January  <chris.january@arm.com>
4742
4743         * eval.c (evaluate_subexp_standard): Call Fortran argument
4744         wrapping logic.
4745         * f-lang.c (struct value): A value which can be passed into a
4746         Fortran function call.
4747         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4748         where appropriate.
4749         (struct type): Value ready for a Fortran function call.
4750         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4751         is needed.
4752         * f-lang.h (fortran_argument_convert): Declaration.
4753         (fortran_preserve_arg_pointer): Declaration.
4754         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4755
4756 2019-03-05  Tom Tromey  <tromey@adacore.com>
4757
4758         * python/py-prettyprint.c (print_string_repr): Remove #if.
4759         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4760
4761 2019-03-05  Tom Tromey  <tromey@adacore.com>
4762
4763         * target.c (the_dummy_target): Move later.  Change type to
4764         "dummy_target".
4765         (initialize_targets): Don't initialize the_dummy_target.
4766
4767 2019-03-05  Tom Tromey  <tromey@adacore.com>
4768
4769         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4770         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4771
4772 2019-03-05  Tom Tromey  <tromey@adacore.com>
4773
4774         * windows-nat.c (windows_nat_target::attach)
4775         (windows_nat_target::detach): Don't call gdb_flush.
4776         * valprint.c (generic_val_print, val_print, val_print_string):
4777         Don't call gdb_flush.
4778         * utils.c (defaulted_query): Don't call gdb_flush.
4779         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4780         * target.c (target_announce_detach): Don't call gdb_flush.
4781         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4782         * remote.c (extended_remote_target::attach): Don't call
4783         gdb_flush.
4784         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4785         * printcmd.c (do_examine): Don't call gdb_flush.
4786         (info_display_command): Don't call gdb_flush.
4787         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4788         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4789         * memattr.c (info_mem_command): Don't call gdb_flush.
4790         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4791         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4792         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4793         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4794         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4795         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4796         (gnu_nat_target::detach): Don't call gdb_flush.
4797         * f-valprint.c (f_val_print): Don't call gdb_flush.
4798         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4799         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4800         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4801         gdb_flush.
4802         * c-valprint.c (c_val_print): Don't call gdb_flush.
4803         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4804
4805 2019-03-05  Tom Tromey  <tromey@adacore.com>
4806
4807         * varobj.c (update_dynamic_varobj_children): Update.
4808         (install_default_visualizer): Use reset, not release.
4809         * value.c (set_internalvar): Update.
4810         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4811         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4812         ATTRIBUTE_UNUSED_RESULT.
4813
4814 2019-03-05  Tom Tromey  <tromey@adacore.com>
4815
4816         * remote.c (class scoped_remote_fd) <release>: Add
4817         ATTRIBUTE_UNUSED_RESULT.
4818
4819 2019-03-05  Tom Tromey  <tromey@adacore.com>
4820
4821         * macroexp.c (struct macro_buffer) <release>: Add
4822         ATTRIBUTE_UNUSED_RESULT.
4823
4824 2019-03-05  Tom Tromey  <tromey@adacore.com>
4825
4826         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4827         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4828         ATTRIBUTE_UNUSED_RESULT.
4829
4830 2019-03-05  Tom Tromey  <tromey@adacore.com>
4831
4832         * common/scoped_fd.h (class scoped_fd) <release>: Add
4833         ATTRIBUTE_UNUSED_RESULT.
4834
4835 2019-03-05  Tom Tromey  <tromey@adacore.com>
4836
4837         * parser-defs.h (struct parser_state) <release>: Add
4838         ATTRIBUTE_UNUSED_RESULT.
4839
4840 2019-03-05  Tom Tromey  <tromey@adacore.com>
4841
4842         * utils.h (class gdb_argv) <release>: Add
4843         ATTRIBUTE_UNUSED_RESULT.
4844         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4845
4846 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4847
4848         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4849         for-loop range, to avoid compiler warnings.
4850
4851         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4852         avoid compiler warnings about unused variables.
4853
4854         * NEWS: Mention end of support for native debugging on MS-Windows
4855         before XP.
4856
4857         PR gdb/24292
4858         * common/netstuff.c:
4859         * gdbserver/gdbreplay.c
4860         * gdbserver/remote-utils.c:
4861         * ser-tcp.c:
4862         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4863         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4864         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4865         'getaddrinfo' and 'freeaddrinfo' were not available before
4866         Windows XP, and mingw.org's MinGW headers by default define
4867         _WIN32_WINNT to 0x500.
4868
4869 2019-03-01  Gary Benson <gbenson@redhat.com>
4870
4871         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4872
4873 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4874             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4875
4876         PR gdb/8527
4877         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4878         set_sigint_trap, clear_sigint_trap.
4879
4880 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4881
4882         * target.c (target_detach): Clear the regcache and the
4883         frame cache.
4884
4885 2019-02-27  Pedro Alves  <palves@redhat.com>
4886
4887         * utils.c (set_screen_size): When we cap the height/width sizes,
4888         tweak the corresponding command variable to show "unlimited":
4889
4890 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4891             Pedro Alves  <palves@redhat.com>
4892
4893         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4894         before calling rl_set_screen_size.
4895
4896 2019-02-27  Tom Tromey  <tromey@adacore.com>
4897
4898         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4899         define.
4900         * python/py-value.c: Remove Python 2.4 workaround.
4901         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4902         workaround.
4903         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4904         Python 2.4 workaround.
4905         * python/python-internal.h: Remove Python 2.4 comment.
4906         (Py_ssize_t): Don't define.
4907         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4908         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4909         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4910         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4911         * python/python.c (do_start_initialization): Remove Python 2.4
4912         workaround.
4913         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4914         (print_children): Remove Python 2.4 workaround.
4915         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4916         workaround.
4917         (CHARBUFFERPROC_NAME): Remove.
4918         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4919         Python 2.4 workaround.
4920
4921 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4922
4923         * NEWS: Note minimum Python version.
4924
4925 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4926
4927         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4928         code from these functions.  Remove corresponding ifdefs.  Use
4929         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4930         Remove gotos and target of gotos.
4931         (infpy_search_memory): Likewise.
4932
4933 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4934
4935         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4936         (hppa_gdbarch_init): Don't register deleted functions with
4937         gdbarch.
4938
4939 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4940
4941         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4942         (h8300_unwind_sp): Delete.
4943         (h8300_dummy_id): Delete.
4944         (h8300_gdbarch_init): Don't register deleted functions with
4945         gdbarch.
4946
4947 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4948
4949         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4950         (ft32_unwind_pc): Delete.
4951         (ft32_unwind_sp): Delete.
4952         (ft32_gdbarch_init): Don't register deleted functions with
4953         gdbarch.
4954
4955 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4956
4957         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4958         (frv_unwind_pc): Delete.
4959         (frv_unwind_sp): Delete.
4960         (frv_gdbarch_init): Don't register deleted functions with
4961         gdbarch.
4962
4963 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4964
4965         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4966         (riscv_unwind_pc): Delete.
4967         (riscv_unwind_sp): Delete.
4968         (riscv_gdbarch_init): Don't register deleted functions with
4969         gdbarch.
4970
4971 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4972
4973         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4974         (csky_unwind_pc): Delete.
4975         (csky_unwind_sp): Delete.
4976         (csky_gdbarch_init): Don't register deleted functions with
4977         gdbarch.
4978
4979 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4980
4981         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4982         (cris_unwind_pc): Delete.
4983         (cris_unwind_sp): Delete.
4984         (cris_gdbarch_init): Don't register deleted functions with
4985         gdbarch.
4986
4987 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4988
4989         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4990         (bfin_unwind_pc): Delete.
4991         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4992
4993 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4994
4995         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4996         (arm_unwind_pc): Delete.
4997         (arm_unwind_sp): Delete.
4998         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4999
5000 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5001
5002         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5003         (arc_unwind_pc): Delete.
5004         (arc_unwind_sp): Delete.
5005         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5006
5007 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5008
5009         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5010         (alpha_unwind_pc): Delete.
5011         (alpha_gdbarch_init): Don't register deleted functions with
5012         gdbarch.
5013
5014 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5015
5016         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5017         (aarch64_unwind_pc): Delete.
5018         (aarch64_unwind_sp): Delete.
5019         (aarch64_gdbarch_init): Don't register deleted functions with
5020         gdbarch.
5021
5022 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5023
5024         * gdbtypes.c (type_align): Don't consider static members when
5025         computing structure alignment.
5026
5027 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5028
5029         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5030         return 0 for other types.
5031         * arch-utils.c (default_type_align): Always return 0.
5032         * gdbarch.h: Regenerate.
5033         * gdbarch.sh (type_align): Extend comment.
5034         * gdbtypes.c (type_align): Add additional comments, always call
5035         gdbarch_type_align before applying the default rules.
5036         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5037         generic code will then apply a suitable default.
5038         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5039         types, return 0 for other types.
5040
5041 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5042
5043         * NEWS: Create a new section for the next release branch.
5044         Rename the section of the current branch, now that it has
5045         been cut.
5046
5047 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5048
5049         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5050         * version.in: Bump version to 8.3.50.DATE-git.
5051
5052 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5053
5054         * aix-thread.c (ptid_cmp): Remove unused variable.
5055         (get_signaled_thread): Likewise.
5056         (store_regs_user_thread): Likewise.
5057         (store_regs_kernel_thread): Likewise.
5058         (fetch_regs_kernel_thread): Remove shadowed variable.
5059
5060 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5061
5062         * features/riscv/32bit-cpu.xml: Add register numbers.
5063         * features/riscv/32bit-fpu.c: Regenerate.
5064         * features/riscv/32bit-fpu.xml: Add register numbers.
5065         * features/riscv/64bit-cpu.xml: Add register numbers.
5066         * features/riscv/64bit-fpu.c: Regenerate.
5067         * features/riscv/64bit-fpu.xml: Add register numbers.
5068
5069 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5070
5071         * NEWS: Mention two argument form of gdb.Value constructor.
5072         * python/py-value.c (convert_buffer_and_type_to_value): New
5073         function.
5074         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5075         Add support for handling an optional second argument.  Call
5076         convert_buffer_and_type_to_value as appropriate.
5077         * python/python-internal.h (Py_buffer_deleter): New struct.
5078         (Py_buffer_up): New typedef.
5079
5080 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5081
5082         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5083         instead of releasing ownership.
5084
5085 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5086
5087         * dwarf2read.c (open_and_init_dwp_file): Call
5088         elf_numsections instead of bfd_count_sections to initialize
5089         dwp_file->num_sections.
5090
5091 2019-02-25  Tom Tromey  <tromey@adacore.com>
5092
5093         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5094
5095 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5096
5097         * gcore.in: Add '--readnever' option when invoking GDB.
5098
5099 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5100
5101         * MAINTAINERS: Update my email address.
5102
5103 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5104
5105         * build-id.c (build_id_to_debug_bfd_1): New function.
5106         (build_id_to_debug_bfd): Look for separate debug file in
5107         sysroot.
5108
5109 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5110
5111         * gdbarch.sh: Update the copyright year range that is placed into
5112         generated files.
5113
5114 2019-02-22  Keith Seitz  <keiths@redhat.com>
5115
5116         PR symtab/23853
5117         * linespec.c (create_sals_line_offset): Search for the default
5118         symtab's filename instead of its fullname.
5119
5120 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5121
5122         * NEWS: Update style defaults.
5123
5124 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5125
5126         * main.c (captured_main_1): Disable styling in batch mode.
5127
5128 2019-02-20  Tom Tromey  <tom@tromey.com>
5129
5130         * symtab.c (symtab_symbol_info): Fix typos.
5131
5132 2019-02-20  Tom Tromey  <tromey@adacore.com>
5133
5134         * findcmd.c (_initialize_mem_search): Use upper case for
5135         metasyntactic variables.
5136
5137 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5138
5139         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5140         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5141
5142 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5143
5144         * top.h (source_file_name): Change to std::string.
5145         * top.c (source_file_name): Likewise.
5146         (command_line_input): Adjust.
5147         * cli/cli-script.c (script_from_file): Adjust.
5148
5149 2019-02-19  Tom Tromey  <tromey@adacore.com>
5150
5151         * ravenscar-thread.c
5152         (ravenscar_thread_target::update_thread_list): Don't call
5153         ada_build_task_list.
5154         * ada-lang.h (ada_build_task_list): Don't declare.
5155         * ada-tasks.c (struct ada_tasks_inferior_data)
5156         <task_list_valid_p>: Now bool.
5157         (read_known_tasks, ada_task_list_changed)
5158         (ada_tasks_invalidate_inferior_data): Update.
5159         (read_known_tasks_array): Return bool.
5160         (read_known_tasks_list): Likewise.
5161         (read_known_tasks): Return void.
5162         (ada_build_task_list): Now static.
5163
5164 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5165
5166         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5167         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5168
5169 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5170
5171         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5172         variant for ada_tasks_pspace_data_handle and
5173         ada_tasks_inferior_data_handle.
5174         (ada_tasks_pspace_data_cleanup): New function.
5175         (ada_tasks_inferior_data_cleanup): New function.
5176
5177 2019-02-17  Tom Tromey  <tom@tromey.com>
5178
5179         * macrotab.h (macro_source_fullname): Return a std::string.
5180         * macrotab.c (macro_include, check_for_redefinition)
5181         (macro_undef, macro_lookup_definition, foreach_macro)
5182         (foreach_macro_in_scope): Update.
5183         (macro_source_fullname): Return a std::string.
5184         * macrocmd.c (show_pp_source_pos): Update.
5185
5186 2019-02-17  Tom Tromey  <tom@tromey.com>
5187
5188         * macrocmd.c (show_pp_source_pos): Style the file names.
5189
5190 2019-02-17  Tom Tromey  <tom@tromey.com>
5191
5192         PR tui/24197:
5193         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5194
5195 2019-02-17  Tom Tromey  <tom@tromey.com>
5196
5197         * ada-lang.c (user_select_syms): Use filtered printing.
5198         * utils.c (wrap_style): New global.
5199         (desired_style): Remove.
5200         (emit_style_escape): Add stream parameter.
5201         (set_output_style, reset_terminal_style, prompt_for_continue):
5202         Update.
5203         (flush_wrap_buffer): Only flush gdb_stdout.
5204         (wrap_here): Set wrap_style.
5205         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5206         treat escape sequences as a character.  Change when wrap buffer is
5207         flushed.
5208         (fputs_styled): Do not set the output style when the default is
5209         requested.
5210         * ui-style.h (struct ui_file_style) <is_default>: New method.
5211         * source.c (print_source_lines_base): Emit escape sequences in one
5212         piece.
5213
5214 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5215
5216         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5217         integers and enumeration types.
5218
5219 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5220
5221         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5222         instead of lookup_symbol_in_language
5223         (do_exact_match): New function.
5224         (ada_get_symbol_name_matcher): Return do_exact_match when
5225         doing a verbatim match.
5226
5227 2019-02-15  Tom Tromey  <tromey@adacore.com>
5228
5229         * ravenscar-thread.c (ravenscar_thread_target::resume)
5230         (ravenscar_thread_target::wait): Special case wildcard requests.
5231
5232 2019-02-15  Tom Tromey  <tromey@adacore.com>
5233
5234         * ravenscar-thread.c (base_ptid): Remove.
5235         (struct ravenscar_thread_target) <close>: New method.
5236         <m_base_ptid>: New member.
5237         <update_inferior_ptid, active_task, task_is_currently_active,
5238         runtime_initialized>: Declare methods.
5239         <ravenscar_thread_target>: Add constructor.
5240         (ravenscar_thread_target::task_is_currently_active)
5241         (ravenscar_thread_target::update_inferior_ptid)
5242         (ravenscar_runtime_initialized): Rename.  Now methods.
5243         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5244         (ravenscar_thread_target::update_thread_list): Update.
5245         (ravenscar_thread_target::active_task): Now method.
5246         (ravenscar_thread_target::store_registers)
5247         (ravenscar_thread_target::prepare_to_store)
5248         (ravenscar_thread_target::prepare_to_store)
5249         (ravenscar_thread_target::mourn_inferior): Update.
5250         (ravenscar_inferior_created): Use "new" to create target.
5251         (ravenscar_thread_target::get_ada_task_ptid): Update.
5252         (_initialize_ravenscar): Don't initialize base_ptid.
5253         (ravenscar_ops): Remove global.
5254
5255 2019-02-15  Tom Tromey  <tromey@adacore.com>
5256
5257         * target.h (push_target): Declare new overload.
5258         * target.c (push_target): New overload, taking an rvalue reference.
5259         * remote.c (remote_target::open_1): Use push_target overload.
5260         * corelow.c (core_target_open): Use push_target overload.
5261
5262 2019-02-15  Tom Tromey  <tromey@adacore.com>
5263
5264         * ravenscar-thread.c (is_ravenscar_task)
5265         (ravenscar_task_is_currently_active): Return bool.
5266         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5267         (_initialize_ravenscar): Remove "(void)".
5268         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5269         Return bool.
5270
5271 2019-02-15  Tom Tromey  <tromey@adacore.com>
5272
5273         * ravenscar-thread.c (ravenscar_runtime_initializer)
5274         (has_ravenscar_runtime, get_running_thread_id)
5275         (ravenscar_thread_target::resume): Fix indentation.
5276
5277 2019-02-15  Tom Tromey  <tromey@adacore.com>
5278
5279         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5280         from ravenscar_arch_ops.
5281         (sparc_ravenscar_ops::fetch_registers)
5282         (sparc_ravenscar_ops::store_registers): Now methods.
5283         (sparc_ravenscar_prepare_to_store): Remove.
5284         (sparc_ravenscar_ops): Redefine.
5285         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5286         methods and destructor.  Remove members.
5287         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5288         (ravenscar_thread_target::store_registers)
5289         (ravenscar_thread_target::prepare_to_store): Update.
5290         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5291         Remove.
5292         (struct ppc_ravenscar_powerpc_ops): Derive from
5293         ravenscar_arch_ops.
5294         (ppc_ravenscar_powerpc_ops::fetch_registers)
5295         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5296         (ppc_ravenscar_powerpc_ops): Redefine.
5297         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5298         (ppc_ravenscar_e500_ops::fetch_registers)
5299         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5300         (ppc_ravenscar_e500_ops): Redefine.
5301         * aarch64-ravenscar-thread.c
5302         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5303         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5304         (aarch64_ravenscar_fetch_registers)
5305         (aarch64_ravenscar_store_registers): Now methods.
5306         (aarch64_ravenscar_ops): Redefine.
5307
5308 2019-02-15  Tom Tromey  <tromey@adacore.com>
5309
5310         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5311         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5312         (ravenscar_thread_target::stopped_by_watchpoint)
5313         (ravenscar_thread_target::stopped_data_address)
5314         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5315
5316 2019-02-15  Tom Tromey  <tromey@adacore.com>
5317
5318         * ravenscar-thread.c: Fix some typos.
5319
5320 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5321             Tom Tromey  <tromey@adacore.com>
5322
5323         * ada-lang.c (ada_exception_sal): Change addr_string to a
5324         std::string.
5325         (create_ada_exception_catchpoint): Update.
5326
5327 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5328             Tom Tromey  <tromey@adacore.com>
5329
5330         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5331         (bp_location_ops): Remove.
5332         (base_breakpoint_allocate_location): Update.
5333         (free_bp_location): Update.
5334         * ada-lang.c (class ada_catchpoint_location)
5335         <ada_catchpoint_location>: Remove ops parameter.
5336         (ada_catchpoint_location_dtor): Remove.
5337         (ada_catchpoint_location_ops): Remove.
5338         (allocate_location_exception): Update.
5339         * breakpoint.h (struct bp_location_ops): Remove.
5340         (class bp_location) <bp_location>: Remove bp_location_ops
5341         parameter.
5342         <~bp_location>: Add destructor.
5343         <ops>: Remove.
5344
5345 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5346             Pedro Alves  <palves@redhat.com>
5347
5348         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5349         'PATH_MAX'.
5350
5351 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5352             Samuel Thibault  <samuel.thibault@gnu.org>
5353             Thomas Schwinge  <thomas@codesourcery.com>
5354
5355         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5356         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5357
5358 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5359
5360         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5361         (check_empty): Use "const char *".
5362
5363         * gnu-nat.c (gnu_nat_target::detach): Instead of
5364         'detach_inferior (pid)' call
5365         'detach_inferior (find_inferior_pid (pid))'.
5366
5367         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5368         'nat/fork-inferior.o'.
5369         * gnu-nat.c: #include "nat/fork-inferior.h".
5370
5371         * gnu-nat.c (gnu_nat_target::detach): Instead of
5372         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5373         * gnu-nat.h: #include "inf-child.h".
5374         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5375         'i386_gnu_nat_target::fetch_registers'.
5376         (gnu_store_registers): Rename/move to
5377         'i386_gnu_nat_target::store_registers'.
5378
5379         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5380         * gnu-nat.h (mach_thread_info): New function.
5381         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5382
5383         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5384
5385 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5386
5387         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5388
5389 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5390
5391         * windows-nat.c (windows_add_thread): Add new parameter
5392         "main_thread_p" with default value set to false.  Update
5393         function documentation as well as all callers.
5394         (windows_delete_thread): Likewise.
5395         (fake_create_process): Update call to windows_add_thread.
5396         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5397         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5398         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5399         call to windows_delete_thread.
5400
5401 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5402
5403         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5404
5405 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5406
5407         * symfile.c (find_separate_debug_file): Use canonical path of
5408         sysroot with child_path instead of gdb_sysroot if it is valid.
5409
5410 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5411
5412         * symfile.c (find_separate_debug_file): Use child_path to
5413         determine if an object file is under a sysroot.
5414
5415 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5416
5417         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5418         unittests/child-path-selftests.c.
5419         * common/pathstuff.c (child_path): New function.
5420         * common/pathstuff.h (child_path): New prototype.
5421         * unittests/child-path-selftests.c: New file.
5422
5423 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5424
5425         * symfile.c (find_separate_debug_file): Look for separate debug
5426         files in debug directories under the sysroot.
5427
5428 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5429
5430         * symtab.h (struct minimal_symbol data_p): New const method.
5431         (struct minimal_symbol text_p): Likewise.
5432         * symtab.c (output_source_filename): Use file name style
5433         to print file name.
5434         (print_symbol_info): Likewise.
5435         (print_msymbol_info): Use address style to print addresses.
5436         Use function name style to print executable text symbols.
5437         (expand_symtab_containing_pc): Use data_p.
5438         (find_pc_sect_compunit_symtab): Likewise.
5439
5440 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5441
5442         * breakpoint.c (describe_other_breakpoints): Use address style
5443         to print addresses.
5444         (say_where): Likewise.
5445
5446 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5447
5448         * ada-typeprint.c (print_func_type): Print function name
5449         style to print function name.
5450         * c-typeprint.c (c_print_type_1): Likewise.
5451
5452 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5453
5454         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5455         for execve.
5456
5457 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5458
5459         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5460         type_stack.
5461
5462 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5463
5464         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5465         TYPE_CODE_REF types.
5466
5467 2019-02-08  Jim Wilson  <jimw@sifive.com>
5468
5469         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5470         (riscv_linux_fregset): New.
5471         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5472
5473 2019-02-07  Tom Tromey  <tom@tromey.com>
5474
5475         * thread.c (thread_cancel_execution_command): Update.
5476         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5477         methods.
5478         (struct thread_fsm_ops): Remove.
5479         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5480         (thread_fsm_should_stop, thread_fsm_return_value)
5481         (thread_fsm_set_finished, thread_fsm_finished_p)
5482         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5483         Don't declare.
5484         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5485         * infrun.c (clear_proceed_status_thread)
5486         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5487         (print_stop_event): Update.
5488         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5489         Add constructor.
5490         (step_command_fsm_ops): Remove.
5491         (new_step_command_fsm): Remove.
5492         (step_1): Update.
5493         (step_command_fsm::should_stop): Rename from
5494         step_command_fsm_should_stop.
5495         (step_command_fsm::clean_up): Rename from
5496         step_command_fsm_clean_up.
5497         (step_command_fsm::do_async_reply_reason): Rename from
5498         step_command_fsm_async_reply_reason.
5499         (struct until_next_fsm): Inherit from thread_fsm.  Add
5500         constructor.
5501         (until_next_fsm_ops): Remove.
5502         (new_until_next_fsm): Remove.
5503         (until_next_fsm::should_stop): Rename from
5504         until_next_fsm_should_stop.
5505         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5506         (until_next_fsm::do_async_reply_reason): Rename from
5507         until_next_fsm_async_reply_reason.
5508         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5509         constructor.  Change type of breakpoint.
5510         (finish_command_fsm_ops): Remove.
5511         (new_finish_command_fsm): Remove.
5512         (finish_command_fsm::should_stop): Rename from
5513         finish_command_fsm_should_stop.
5514         (finish_command_fsm::clean_up): Rename from
5515         finish_command_fsm_clean_up.
5516         (finish_command_fsm::return_value): Rename from
5517         finish_command_fsm_return_value.
5518         (finish_command_fsm::do_async_reply_reason): Rename from
5519         finish_command_fsm_async_reply_reason.
5520         (finish_command): Update.
5521         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5522         Add constructor.
5523         (call_thread_fsm_ops): Remove.
5524         (call_thread_fsm::call_thread_fsm): Rename from
5525         new_call_thread_fsm.
5526         (call_thread_fsm::should_stop): Rename from
5527         call_thread_fsm_should_stop.
5528         (call_thread_fsm::should_notify_stop): Rename from
5529         call_thread_fsm_should_notify_stop.
5530         (run_inferior_call, call_function_by_hand_dummy): Update.
5531         * cli/cli-interp.c (should_print_stop_to_console): Update.
5532         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5533         Add constructor.  Change type of location_breakpoint,
5534         caller_breakpoint.
5535         (until_break_fsm_ops): Remove.
5536         (new_until_break_fsm): Remove.
5537         (until_break_fsm::should_stop): Rename from
5538         until_break_fsm_should_stop.
5539         (until_break_fsm::clean_up): Rename from
5540         until_break_fsm_clean_up.
5541         (until_break_fsm::do_async_reply_reason): Rename from
5542         until_break_fsm_async_reply_reason.
5543         (until_break_command): Update.
5544         * thread-fsm.c: Remove.
5545         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5546
5547 2019-02-07  Tom Tromey  <tom@tromey.com>
5548
5549         * yy-remap.h: Add include guard.
5550         * xtensa-tdep.h: Add include guard.
5551         * xcoffread.h: Rename include guard.
5552         * varobj-iter.h: Add include guard.
5553         * tui/tui.h: Rename include guard.
5554         * tui/tui-winsource.h: Rename include guard.
5555         * tui/tui-wingeneral.h: Rename include guard.
5556         * tui/tui-windata.h: Rename include guard.
5557         * tui/tui-win.h: Rename include guard.
5558         * tui/tui-stack.h: Rename include guard.
5559         * tui/tui-source.h: Rename include guard.
5560         * tui/tui-regs.h: Rename include guard.
5561         * tui/tui-out.h: Rename include guard.
5562         * tui/tui-layout.h: Rename include guard.
5563         * tui/tui-io.h: Rename include guard.
5564         * tui/tui-hooks.h: Rename include guard.
5565         * tui/tui-file.h: Rename include guard.
5566         * tui/tui-disasm.h: Rename include guard.
5567         * tui/tui-data.h: Rename include guard.
5568         * tui/tui-command.h: Rename include guard.
5569         * tic6x-tdep.h: Add include guard.
5570         * target/waitstatus.h: Rename include guard.
5571         * target/wait.h: Rename include guard.
5572         * target/target.h: Rename include guard.
5573         * target/resume.h: Rename include guard.
5574         * target-float.h: Rename include guard.
5575         * stabsread.h: Add include guard.
5576         * rs6000-tdep.h: Add include guard.
5577         * riscv-fbsd-tdep.h: Add include guard.
5578         * regformats/regdef.h: Rename include guard.
5579         * record.h: Rename include guard.
5580         * python/python.h: Rename include guard.
5581         * python/python-internal.h: Rename include guard.
5582         * python/py-stopevent.h: Rename include guard.
5583         * python/py-ref.h: Rename include guard.
5584         * python/py-record.h: Rename include guard.
5585         * python/py-record-full.h: Rename include guard.
5586         * python/py-record-btrace.h: Rename include guard.
5587         * python/py-instruction.h: Rename include guard.
5588         * python/py-events.h: Rename include guard.
5589         * python/py-event.h: Rename include guard.
5590         * procfs.h: Add include guard.
5591         * proc-utils.h: Add include guard.
5592         * p-lang.h: Add include guard.
5593         * or1k-tdep.h: Rename include guard.
5594         * observable.h: Rename include guard.
5595         * nto-tdep.h: Rename include guard.
5596         * nat/x86-linux.h: Rename include guard.
5597         * nat/x86-linux-dregs.h: Rename include guard.
5598         * nat/x86-gcc-cpuid.h: Add include guard.
5599         * nat/x86-dregs.h: Rename include guard.
5600         * nat/x86-cpuid.h: Rename include guard.
5601         * nat/ppc-linux.h: Rename include guard.
5602         * nat/mips-linux-watch.h: Rename include guard.
5603         * nat/linux-waitpid.h: Rename include guard.
5604         * nat/linux-ptrace.h: Rename include guard.
5605         * nat/linux-procfs.h: Rename include guard.
5606         * nat/linux-osdata.h: Rename include guard.
5607         * nat/linux-nat.h: Rename include guard.
5608         * nat/linux-namespaces.h: Rename include guard.
5609         * nat/linux-btrace.h: Rename include guard.
5610         * nat/glibc_thread_db.h: Rename include guard.
5611         * nat/gdb_thread_db.h: Rename include guard.
5612         * nat/gdb_ptrace.h: Rename include guard.
5613         * nat/fork-inferior.h: Rename include guard.
5614         * nat/amd64-linux-siginfo.h: Rename include guard.
5615         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5616         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5617         * nat/aarch64-linux.h: Rename include guard.
5618         * nat/aarch64-linux-hw-point.h: Rename include guard.
5619         * mn10300-tdep.h: Add include guard.
5620         * mips-linux-tdep.h: Add include guard.
5621         * mi/mi-parse.h: Rename include guard.
5622         * mi/mi-out.h: Rename include guard.
5623         * mi/mi-main.h: Rename include guard.
5624         * mi/mi-interp.h: Rename include guard.
5625         * mi/mi-getopt.h: Rename include guard.
5626         * mi/mi-console.h: Rename include guard.
5627         * mi/mi-common.h: Rename include guard.
5628         * mi/mi-cmds.h: Rename include guard.
5629         * mi/mi-cmd-break.h: Rename include guard.
5630         * m2-lang.h: Add include guard.
5631         * location.h: Rename include guard.
5632         * linux-record.h: Rename include guard.
5633         * linux-nat.h: Add include guard.
5634         * linux-fork.h: Add include guard.
5635         * i386-darwin-tdep.h: Rename include guard.
5636         * hppa-linux-offsets.h: Add include guard.
5637         * guile/guile.h: Rename include guard.
5638         * guile/guile-internal.h: Rename include guard.
5639         * gnu-nat.h: Rename include guard.
5640         * gdb-stabs.h: Rename include guard.
5641         * frv-tdep.h: Add include guard.
5642         * f-lang.h: Add include guard.
5643         * event-loop.h: Add include guard.
5644         * darwin-nat.h: Rename include guard.
5645         * cp-abi.h: Rename include guard.
5646         * config/sparc/nm-sol2.h: Rename include guard.
5647         * config/nm-nto.h: Rename include guard.
5648         * config/nm-linux.h: Add include guard.
5649         * config/i386/nm-i386gnu.h: Rename include guard.
5650         * config/djgpp/nl_types.h: Rename include guard.
5651         * config/djgpp/langinfo.h: Rename include guard.
5652         * compile/gcc-cp-plugin.h: Add include guard.
5653         * compile/gcc-c-plugin.h: Add include guard.
5654         * compile/compile.h: Rename include guard.
5655         * compile/compile-object-run.h: Rename include guard.
5656         * compile/compile-object-load.h: Rename include guard.
5657         * compile/compile-internal.h: Rename include guard.
5658         * compile/compile-cplus.h: Rename include guard.
5659         * compile/compile-c.h: Rename include guard.
5660         * common/xml-utils.h: Rename include guard.
5661         * common/x86-xstate.h: Rename include guard.
5662         * common/version.h: Rename include guard.
5663         * common/vec.h: Rename include guard.
5664         * common/tdesc.h: Rename include guard.
5665         * common/selftest.h: Rename include guard.
5666         * common/scoped_restore.h: Rename include guard.
5667         * common/scoped_mmap.h: Rename include guard.
5668         * common/scoped_fd.h: Rename include guard.
5669         * common/safe-iterator.h: Rename include guard.
5670         * common/run-time-clock.h: Rename include guard.
5671         * common/refcounted-object.h: Rename include guard.
5672         * common/queue.h: Rename include guard.
5673         * common/ptid.h: Rename include guard.
5674         * common/print-utils.h: Rename include guard.
5675         * common/preprocessor.h: Rename include guard.
5676         * common/pathstuff.h: Rename include guard.
5677         * common/observable.h: Rename include guard.
5678         * common/netstuff.h: Rename include guard.
5679         * common/job-control.h: Rename include guard.
5680         * common/host-defs.h: Rename include guard.
5681         * common/gdb_wait.h: Rename include guard.
5682         * common/gdb_vecs.h: Rename include guard.
5683         * common/gdb_unlinker.h: Rename include guard.
5684         * common/gdb_unique_ptr.h: Rename include guard.
5685         * common/gdb_tilde_expand.h: Rename include guard.
5686         * common/gdb_sys_time.h: Rename include guard.
5687         * common/gdb_string_view.h: Rename include guard.
5688         * common/gdb_splay_tree.h: Rename include guard.
5689         * common/gdb_setjmp.h: Rename include guard.
5690         * common/gdb_ref_ptr.h: Rename include guard.
5691         * common/gdb_optional.h: Rename include guard.
5692         * common/gdb_locale.h: Rename include guard.
5693         * common/gdb_assert.h: Rename include guard.
5694         * common/filtered-iterator.h: Rename include guard.
5695         * common/filestuff.h: Rename include guard.
5696         * common/fileio.h: Rename include guard.
5697         * common/environ.h: Rename include guard.
5698         * common/common-utils.h: Rename include guard.
5699         * common/common-types.h: Rename include guard.
5700         * common/common-regcache.h: Rename include guard.
5701         * common/common-inferior.h: Rename include guard.
5702         * common/common-gdbthread.h: Rename include guard.
5703         * common/common-exceptions.h: Rename include guard.
5704         * common/common-defs.h: Rename include guard.
5705         * common/common-debug.h: Rename include guard.
5706         * common/cleanups.h: Rename include guard.
5707         * common/buffer.h: Rename include guard.
5708         * common/btrace-common.h: Rename include guard.
5709         * common/break-common.h: Rename include guard.
5710         * cli/cli-utils.h: Rename include guard.
5711         * cli/cli-style.h: Rename include guard.
5712         * cli/cli-setshow.h: Rename include guard.
5713         * cli/cli-script.h: Rename include guard.
5714         * cli/cli-interp.h: Rename include guard.
5715         * cli/cli-decode.h: Rename include guard.
5716         * cli/cli-cmds.h: Rename include guard.
5717         * charset-list.h: Add include guard.
5718         * buildsym-legacy.h: Rename include guard.
5719         * bfin-tdep.h: Add include guard.
5720         * ax.h: Rename include guard.
5721         * arm-linux-tdep.h: Add include guard.
5722         * arm-fbsd-tdep.h: Add include guard.
5723         * arch/xtensa.h: Rename include guard.
5724         * arch/tic6x.h: Add include guard.
5725         * arch/i386.h: Add include guard.
5726         * arch/arm.h: Rename include guard.
5727         * arch/arm-linux.h: Rename include guard.
5728         * arch/arm-get-next-pcs.h: Rename include guard.
5729         * arch/amd64.h: Add include guard.
5730         * arch/aarch64-insn.h: Rename include guard.
5731         * arch-utils.h: Rename include guard.
5732         * annotate.h: Add include guard.
5733         * amd64-darwin-tdep.h: Rename include guard.
5734         * aarch64-linux-tdep.h: Add include guard.
5735         * aarch64-fbsd-tdep.h: Add include guard.
5736         * aarch32-linux-nat.h: Add include guard.
5737
5738 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5739
5740         * macrotab.c (macro_define_internal): New function that
5741         factorizes macro_define_object_internal and macro_define_function
5742         code.
5743         (macro_define_object_internal): Use macro_define_internal.
5744         (macro_define_function): Likewise.
5745
5746 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5747
5748         * macrocmd.c (extract_identifier): Return
5749         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5750         callers.
5751
5752 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5753
5754         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5755
5756 2019-02-05  Tom Tromey  <tom@tromey.com>
5757
5758         * target.c (target_stack::unpush): Move assertion earlier.
5759
5760 2019-01-30  Tom Tromey  <tom@tromey.com>
5761
5762         PR python/23615:
5763         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5764         (gdbpy_parse_and_eval): Likewise.
5765         * python/python-internal.h (gdbpy_allow_threads): New class.
5766
5767 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5768
5769         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5770         (aarch64_fbsd_fpregmap): Move earlier.
5771         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5772         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5773         instead of individual calls to trad_frame_set_reg_addr.
5774         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5775         earlier.
5776         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5777         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5778         instead of individual calls to trad_frame_set_reg_addr.
5779
5780 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5781
5782         * CONTRIBUTE: Replace contribution list with wiki link.
5783
5784 2019-01-25  Tom Tromey  <tom@tromey.com>
5785
5786         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5787
5788 2019-01-25  Tom Tromey  <tom@tromey.com>
5789
5790         * xtensa-linux-nat.c: Fix common/ includes.
5791         * xml-support.h: Fix common/ includes.
5792         * xml-support.c: Fix common/ includes.
5793         * x86-linux-nat.c: Fix common/ includes.
5794         * windows-nat.c: Fix common/ includes.
5795         * varobj.h: Fix common/ includes.
5796         * varobj.c: Fix common/ includes.
5797         * value.c: Fix common/ includes.
5798         * valops.c: Fix common/ includes.
5799         * utils.c: Fix common/ includes.
5800         * unittests/xml-utils-selftests.c: Fix common/ includes.
5801         * unittests/utils-selftests.c: Fix common/ includes.
5802         * unittests/unpack-selftests.c: Fix common/ includes.
5803         * unittests/tracepoint-selftests.c: Fix common/ includes.
5804         * unittests/style-selftests.c: Fix common/ includes.
5805         * unittests/string_view-selftests.c: Fix common/ includes.
5806         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5807         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5808         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5809         * unittests/rsp-low-selftests.c: Fix common/ includes.
5810         * unittests/parse-connection-spec-selftests.c: Fix common/
5811         includes.
5812         * unittests/optional-selftests.c: Fix common/ includes.
5813         * unittests/offset-type-selftests.c: Fix common/ includes.
5814         * unittests/observable-selftests.c: Fix common/ includes.
5815         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5816         * unittests/memrange-selftests.c: Fix common/ includes.
5817         * unittests/memory-map-selftests.c: Fix common/ includes.
5818         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5819         * unittests/function-view-selftests.c: Fix common/ includes.
5820         * unittests/environ-selftests.c: Fix common/ includes.
5821         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5822         * unittests/common-utils-selftests.c: Fix common/ includes.
5823         * unittests/cli-utils-selftests.c: Fix common/ includes.
5824         * unittests/array-view-selftests.c: Fix common/ includes.
5825         * ui-file.c: Fix common/ includes.
5826         * tui/tui-io.c: Fix common/ includes.
5827         * tracepoint.h: Fix common/ includes.
5828         * tracepoint.c: Fix common/ includes.
5829         * tracefile-tfile.c: Fix common/ includes.
5830         * top.h: Fix common/ includes.
5831         * top.c: Fix common/ includes.
5832         * thread.c: Fix common/ includes.
5833         * target/waitstatus.h: Fix common/ includes.
5834         * target/waitstatus.c: Fix common/ includes.
5835         * target.h: Fix common/ includes.
5836         * target.c: Fix common/ includes.
5837         * target-memory.c: Fix common/ includes.
5838         * target-descriptions.c: Fix common/ includes.
5839         * symtab.h: Fix common/ includes.
5840         * symfile.c: Fix common/ includes.
5841         * stap-probe.c: Fix common/ includes.
5842         * spu-linux-nat.c: Fix common/ includes.
5843         * sparc-nat.c: Fix common/ includes.
5844         * source.c: Fix common/ includes.
5845         * solib.c: Fix common/ includes.
5846         * solib-target.c: Fix common/ includes.
5847         * ser-unix.c: Fix common/ includes.
5848         * ser-tcp.c: Fix common/ includes.
5849         * ser-pipe.c: Fix common/ includes.
5850         * ser-base.c: Fix common/ includes.
5851         * selftest-arch.c: Fix common/ includes.
5852         * s12z-tdep.c: Fix common/ includes.
5853         * rust-exp.y: Fix common/ includes.
5854         * rs6000-aix-tdep.c: Fix common/ includes.
5855         * riscv-tdep.c: Fix common/ includes.
5856         * remote.c: Fix common/ includes.
5857         * remote-notif.h: Fix common/ includes.
5858         * remote-fileio.h: Fix common/ includes.
5859         * remote-fileio.c: Fix common/ includes.
5860         * regcache.h: Fix common/ includes.
5861         * regcache.c: Fix common/ includes.
5862         * record-btrace.c: Fix common/ includes.
5863         * python/python.c: Fix common/ includes.
5864         * python/py-type.c: Fix common/ includes.
5865         * python/py-inferior.c: Fix common/ includes.
5866         * progspace.h: Fix common/ includes.
5867         * producer.c: Fix common/ includes.
5868         * procfs.c: Fix common/ includes.
5869         * proc-api.c: Fix common/ includes.
5870         * printcmd.c: Fix common/ includes.
5871         * ppc-linux-nat.c: Fix common/ includes.
5872         * parser-defs.h: Fix common/ includes.
5873         * osdata.c: Fix common/ includes.
5874         * obsd-nat.c: Fix common/ includes.
5875         * nat/x86-linux.c: Fix common/ includes.
5876         * nat/x86-linux-dregs.c: Fix common/ includes.
5877         * nat/x86-dregs.h: Fix common/ includes.
5878         * nat/x86-dregs.c: Fix common/ includes.
5879         * nat/ppc-linux.c: Fix common/ includes.
5880         * nat/mips-linux-watch.h: Fix common/ includes.
5881         * nat/mips-linux-watch.c: Fix common/ includes.
5882         * nat/linux-waitpid.c: Fix common/ includes.
5883         * nat/linux-ptrace.h: Fix common/ includes.
5884         * nat/linux-ptrace.c: Fix common/ includes.
5885         * nat/linux-procfs.c: Fix common/ includes.
5886         * nat/linux-personality.c: Fix common/ includes.
5887         * nat/linux-osdata.c: Fix common/ includes.
5888         * nat/linux-namespaces.c: Fix common/ includes.
5889         * nat/linux-btrace.h: Fix common/ includes.
5890         * nat/linux-btrace.c: Fix common/ includes.
5891         * nat/fork-inferior.c: Fix common/ includes.
5892         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5893         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5894         * nat/aarch64-linux.c: Fix common/ includes.
5895         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5896         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5897         * namespace.h: Fix common/ includes.
5898         * mips-linux-tdep.c: Fix common/ includes.
5899         * minsyms.c: Fix common/ includes.
5900         * mi/mi-parse.h: Fix common/ includes.
5901         * mi/mi-main.c: Fix common/ includes.
5902         * mi/mi-cmd-env.c: Fix common/ includes.
5903         * memrange.h: Fix common/ includes.
5904         * memattr.c: Fix common/ includes.
5905         * maint.h: Fix common/ includes.
5906         * maint.c: Fix common/ includes.
5907         * main.c: Fix common/ includes.
5908         * machoread.c: Fix common/ includes.
5909         * location.c: Fix common/ includes.
5910         * linux-thread-db.c: Fix common/ includes.
5911         * linux-nat.c: Fix common/ includes.
5912         * linux-fork.c: Fix common/ includes.
5913         * inline-frame.c: Fix common/ includes.
5914         * infrun.c: Fix common/ includes.
5915         * inflow.c: Fix common/ includes.
5916         * inferior.h: Fix common/ includes.
5917         * inferior.c: Fix common/ includes.
5918         * infcmd.c: Fix common/ includes.
5919         * inf-ptrace.c: Fix common/ includes.
5920         * inf-child.c: Fix common/ includes.
5921         * ia64-linux-nat.c: Fix common/ includes.
5922         * i387-tdep.c: Fix common/ includes.
5923         * i386-tdep.c: Fix common/ includes.
5924         * i386-linux-tdep.c: Fix common/ includes.
5925         * i386-linux-nat.c: Fix common/ includes.
5926         * i386-go32-tdep.c: Fix common/ includes.
5927         * i386-fbsd-tdep.c: Fix common/ includes.
5928         * i386-fbsd-nat.c: Fix common/ includes.
5929         * guile/scm-type.c: Fix common/ includes.
5930         * guile/guile.c: Fix common/ includes.
5931         * go32-nat.c: Fix common/ includes.
5932         * gnu-nat.c: Fix common/ includes.
5933         * gdbthread.h: Fix common/ includes.
5934         * gdbarch-selftests.c: Fix common/ includes.
5935         * gdb_usleep.c: Fix common/ includes.
5936         * gdb_select.h: Fix common/ includes.
5937         * gdb_bfd.c: Fix common/ includes.
5938         * gcore.c: Fix common/ includes.
5939         * fork-child.c: Fix common/ includes.
5940         * findvar.c: Fix common/ includes.
5941         * fbsd-nat.c: Fix common/ includes.
5942         * event-top.c: Fix common/ includes.
5943         * event-loop.c: Fix common/ includes.
5944         * dwarf2read.c: Fix common/ includes.
5945         * dwarf2loc.c: Fix common/ includes.
5946         * dwarf2-frame.c: Fix common/ includes.
5947         * dwarf-index-cache.c: Fix common/ includes.
5948         * dtrace-probe.c: Fix common/ includes.
5949         * disasm-selftests.c: Fix common/ includes.
5950         * defs.h: Fix common/ includes.
5951         * csky-tdep.c: Fix common/ includes.
5952         * cp-valprint.c: Fix common/ includes.
5953         * cp-support.h: Fix common/ includes.
5954         * cp-support.c: Fix common/ includes.
5955         * corelow.c: Fix common/ includes.
5956         * completer.h: Fix common/ includes.
5957         * completer.c: Fix common/ includes.
5958         * compile/compile.c: Fix common/ includes.
5959         * compile/compile-loc2c.c: Fix common/ includes.
5960         * compile/compile-cplus-types.c: Fix common/ includes.
5961         * compile/compile-cplus-symbols.c: Fix common/ includes.
5962         * command.h: Fix common/ includes.
5963         * cli/cli-dump.c: Fix common/ includes.
5964         * cli/cli-cmds.c: Fix common/ includes.
5965         * charset.c: Fix common/ includes.
5966         * build-id.c: Fix common/ includes.
5967         * btrace.h: Fix common/ includes.
5968         * btrace.c: Fix common/ includes.
5969         * breakpoint.h: Fix common/ includes.
5970         * breakpoint.c: Fix common/ includes.
5971         * ax.h:
5972         (enum agent_op): Fix common/ includes.
5973         * ax-general.c (struct aop_map): Fix common/ includes.
5974         * ax-gdb.c: Fix common/ includes.
5975         * auxv.c: Fix common/ includes.
5976         * auto-load.c: Fix common/ includes.
5977         * arm-tdep.c: Fix common/ includes.
5978         * arch/riscv.c: Fix common/ includes.
5979         * arch/ppc-linux-common.c: Fix common/ includes.
5980         * arch/i386.c: Fix common/ includes.
5981         * arch/arm.c: Fix common/ includes.
5982         * arch/arm-linux.c: Fix common/ includes.
5983         * arch/arm-get-next-pcs.c: Fix common/ includes.
5984         * arch/amd64.c: Fix common/ includes.
5985         * arch/aarch64.c: Fix common/ includes.
5986         * arch/aarch64-insn.c: Fix common/ includes.
5987         * arch-utils.c: Fix common/ includes.
5988         * amd64-windows-tdep.c: Fix common/ includes.
5989         * amd64-tdep.c: Fix common/ includes.
5990         * amd64-sol2-tdep.c: Fix common/ includes.
5991         * amd64-obsd-tdep.c: Fix common/ includes.
5992         * amd64-nbsd-tdep.c: Fix common/ includes.
5993         * amd64-linux-tdep.c: Fix common/ includes.
5994         * amd64-linux-nat.c: Fix common/ includes.
5995         * amd64-fbsd-tdep.c: Fix common/ includes.
5996         * amd64-fbsd-nat.c: Fix common/ includes.
5997         * amd64-dicos-tdep.c: Fix common/ includes.
5998         * amd64-darwin-tdep.c: Fix common/ includes.
5999         * agent.c: Fix common/ includes.
6000         * ada-lang.h: Fix common/ includes.
6001         * ada-lang.c: Fix common/ includes.
6002         * aarch64-tdep.c: Fix common/ includes.
6003
6004 2019-01-25  Tom Tromey  <tom@tromey.com>
6005
6006         * common/create-version.sh: Use common/version.h.
6007
6008 2019-01-24  Pedro Alves  <palves@redhat.com>
6009
6010         * infrun.c (signal_stop, signal_print, signal_program)
6011         (signal_catch, signal_pass): Now arrays instead of pointers.
6012         (update_signals_program_target, do_target_resume)
6013         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6014         * linux-nat.c (linux_nat_target::pass_signals)
6015         (linux_nat_target::create_inferior, linux_nat_target::attach):
6016         Adjust.
6017         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6018         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6019         * procfs.c (procfs_target::pass_signals): Adjust.
6020         * record-full.c (record_full_target::resume): Adjust.
6021         * remote.c (remote_target::pass_signals)
6022         (remote_target::program_signals): Adjust.
6023         * target-debug.h (target_debug_print_signals): Now takes a
6024         gdb::array_view as parameter.  Adjust.
6025         * target.h (target_ops) <pass_signals, program_signals>: Replace
6026         pointer and length parameters with gdb::array_view.
6027         (target_pass_signals, target_program_signals): Likewise.
6028         * target-delegates.c: Regenerate.
6029
6030 2019-01-24  Pedro Alves  <palves@redhat.com>
6031
6032         * common/forward-scope-exit.h
6033         (forward_scope_exit::forward_scope_exit): Pass arguments to
6034         m_bind_function directly, instead of creating a std::bind and
6035         copying that.
6036
6037 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6038
6039         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6040         for static members.
6041         (pass_in_v_vfp_candidate): Likewise.
6042
6043 2019-01-23  Tom Tromey  <tom@tromey.com>
6044             Pedro Alves  <palves@redhat.com>
6045
6046         * regcache.c (class regcache_invalidator): Remove.
6047         (regcache::raw_write): Use make_scope_exit.
6048
6049 2019-01-23  Tom Tromey  <tom@tromey.com>
6050
6051         * ui-out.h (class ui_out_emit_type): Update comment.
6052
6053 2019-01-23  Tom Tromey  <tom@tromey.com>
6054
6055         * infrun.c (fetch_inferior_event): Update comment.
6056
6057 2019-01-23  Tom Tromey  <tom@tromey.com>
6058             Pedro Alves  <palves@redhat.com>
6059
6060         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6061         parameter.
6062         (fetch_inferior_event): Use SCOPE_EXIT.
6063
6064
6065 2019-01-23  Tom Tromey  <tom@tromey.com>
6066             Pedro Alves  <palves@redhat.com>
6067
6068         * infrun.c (disable_thread_events): Delete.
6069         (stop_all_threads): Use SCOPE_EXIT.
6070
6071 2019-01-23  Tom Tromey  <tom@tromey.com>
6072             Pedro Alves  <palves@redhat.com>
6073
6074         * symfile.c: Include forward-scope-exit.h.
6075         (clear_symtab_users_cleanup): Replace forward declaration with
6076         a FORWARD_SCOPE_EXIT.
6077         (syms_from_objfile_1): Use the forward_scope_exit and
6078         gdb::optional instead of cleanup_function.
6079         (reread_symbols): Use the forward_scope_exit instead of
6080         cleanup_function.
6081         (clear_symtab_users_cleanup): Remove function.
6082
6083 2019-01-23  Tom Tromey  <tom@tromey.com>
6084             Pedro Alves  <palves@redhat.com>
6085
6086         * linux-nat.c: Include scope-exit.h.
6087         (cleanup_target_stop): Remove.
6088         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6089         SCOPE_EXIT.
6090
6091 2019-01-23  Tom Tromey  <tom@tromey.com>
6092             Pedro Alves  <palves@redhat.com>
6093
6094         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6095         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6096
6097 2019-01-23  Tom Tromey  <tom@tromey.com>
6098             Andrew Burgess  <andrew.burgess@embecosm.com>
6099             Pedro Alves  <palves@redhat.com>
6100
6101         * infrun.c (fetch_inferior_event): Use scope_exit.
6102         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6103         * top.c (execute_command): Use scope_exit.
6104         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6105         * utils.c (do_bpstat_clear_actions_cleanup)
6106         (make_bpstat_clear_actions_cleanup): Remove.
6107
6108 2019-01-23  Tom Tromey  <tom@tromey.com>
6109             Pedro Alves  <palves@redhat.com>
6110
6111         * infrun.c: Include "common/scope-exit.h"
6112         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6113         (wait_for_inferior): Use SCOPE_EXIT.
6114         (fetch_inferior_event): Use scope_exit.
6115
6116 2019-01-23  Tom Tromey  <tom@tromey.com>
6117             Pedro Alves  <palves@redhat.com>
6118
6119         * breakpoint.c (create_breakpoint): Remove cleanup.
6120
6121 2019-01-23  Tom Tromey  <tom@tromey.com>
6122             Andrew Burgess  <andrew.burgess@embecosm.com>
6123             Pedro Alves  <palves@redhat.com>
6124
6125 2019-01-23  Pedro Alves  <palves@redhat.com>
6126
6127         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6128
6129 2019-01-23  Pedro Alves  <palves@redhat.com>
6130             Andrew Burgess  <andrew.burgess@embecosm.com>
6131
6132         * gdbthread.h: Include "common/forward-scope-exit.h".
6133         (scoped_finish_thread_state): Redefine custom class in terms of
6134         forward_scope_exit.
6135
6136 2019-01-23  Pedro Alves  <palves@redhat.com>
6137             Andrew Burgess  <andrew.burgess@embecosm.com>
6138
6139         * common/forward-scope-exit.h: New file.
6140
6141 2019-01-23  Pedro Alves  <palves@redhat.com>
6142             Andrew Burgess  <andrew.burgess@embecosm.com>
6143             Tom Tromey  <tom@tromey.com>
6144
6145         * common/scope-exit.h: New file.
6146
6147 2019-01-23  Pedro Alves  <palves@redhat.com>
6148
6149         * common/preprocessor.h (ESC): Rename to ...
6150         (ESC_PARENS): ... this.
6151         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6152         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6153
6154 2019-01-23  Tom Tromey  <tom@tromey.com>
6155
6156         * language.h (class scoped_switch_to_sym_language_if_auto):
6157         Initialize m_lang in both cases.
6158
6159 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6160
6161         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6162         with XCNEW.
6163
6164 2019-01-22  Tom Tromey  <tom@tromey.com>
6165
6166         * corelow.c: Do not include sys/file.h.
6167
6168 2019-01-22  Tom Tromey  <tom@tromey.com>
6169
6170         * tui/tui-wingeneral.h: Include gdb_curses.h.
6171
6172 2019-01-22  Tom Tromey  <tom@tromey.com>
6173
6174         * source-cache.h (class source_cache) <get_source_lines,
6175         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6176
6177 2019-01-22  Tom Tromey  <tom@tromey.com>
6178
6179         * remote-fileio.h (struct remote_target): Declare.
6180
6181 2019-01-22  Tom Tromey  <tom@tromey.com>
6182
6183         * python/py-arch.c: Do not include py-ref.h.
6184         * python/py-bpevent.c: Do not include py-ref.h.
6185         * python/py-cmd.c: Do not include py-ref.h.
6186         * python/py-continueevent.c: Do not include py-ref.h.
6187         * python/py-event.h: Do not include py-ref.h.
6188         * python/py-evtregistry.c: Do not include py-ref.h.
6189         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6190         * python/py-frame.c: Do not include py-ref.h.
6191         * python/py-framefilter.c: Do not include py-ref.h.
6192         * python/py-function.c: Do not include py-ref.h.
6193         * python/py-infevents.c: Do not include py-ref.h.
6194         * python/py-linetable.c: Do not include py-ref.h.
6195         * python/py-objfile.c: Do not include py-ref.h.
6196         * python/py-param.c: Do not include py-ref.h.
6197         * python/py-prettyprint.c: Do not include py-ref.h.
6198         * python/py-progspace.c: Do not include py-ref.h.
6199         * python/py-symbol.c: Do not include py-ref.h.
6200         * python/py-symtab.c: Do not include py-ref.h.
6201         * python/py-type.c: Do not include py-ref.h.
6202         * python/py-unwind.c: Do not include py-ref.h.
6203         * python/py-utils.c: Do not include py-ref.h.
6204         * python/py-value.c: Do not include py-ref.h.
6205         * python/py-varobj.c: Do not include py-ref.h.
6206         * python/py-xmethods.c: Do not include py-ref.h.
6207         * python/python.c: Do not include py-ref.h.
6208         * varobj.c: Do not include py-ref.h.
6209
6210 2019-01-22  Tom Tromey  <tom@tromey.com>
6211
6212         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6213         keyword for bcache.
6214
6215 2019-01-22  Tom Tromey  <tom@tromey.com>
6216
6217         * compile/compile-cplus-types.c: Remove a comment by #include.
6218
6219 2019-01-22  Tom Tromey  <tom@tromey.com>
6220
6221         * compile/gcc-c-plugin.h: Include compile-internal.h.
6222
6223 2019-01-22  Tom Tromey  <tom@tromey.com>
6224
6225         * stabsread.c (EXTERN): Do not define.
6226         (symnum, next_symbol_text_func, processing_gcc_compilation)
6227         (within_function, global_sym_chain, global_stabs)
6228         (previous_stab_code, this_object_header_files)
6229         (n_this_object_header_files)
6230         (n_allocated_this_object_header_files): Define.
6231         * stabsread.h (EXTERN): Never define.  Use "extern".
6232
6233 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6234
6235         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6236         history_value.
6237
6238 2019-01-21  Tom Tromey  <tom@tromey.com>
6239
6240         * ui-out.c: Fix includes.
6241         * tui/tui-source.c: Fix includes.
6242         * target.c: Fix includes.
6243         * remote.c: Fix includes.
6244         * regcache.c: Fix includes.
6245         * python/py-block.c: Fix includes.
6246         * printcmd.c: Fix includes.
6247         * or1k-tdep.c: Fix includes.
6248         * mi/mi-main.c: Fix includes.
6249         * m32r-tdep.c: Fix includes.
6250         * csky-tdep.c: Fix includes.
6251         * compile/compile-cplus-types.c: Fix includes.
6252         * cli/cli-interp.c: Fix includes.
6253
6254 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6255
6256         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6257         for padding.
6258
6259 2019-01-16  Tom Tromey  <tom@tromey.com>
6260
6261         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6262         earlier.
6263         (struct objfile) <msymbols_range>: Move from top level.
6264         <msymbols>: New method.
6265         (class objfile_msymbols): Remove.
6266         * symtab.c (default_collect_symbol_completion_matches_break_on):
6267         Update.
6268         * symmisc.c (dump_msymbols): Update.
6269         * stabsread.c (scan_file_globals): Update.
6270         * objc-lang.c (info_selectors_command, info_classes_command)
6271         (find_methods): Update.
6272         * minsyms.c (find_solib_trampoline_target): Update.
6273         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6274         * coffread.c (coff_symfile_read): Update.
6275         * ada-lang.c (ada_lookup_simple_minsym)
6276         (ada_collect_symbol_completion_matches): Update.
6277
6278 2019-01-16  Tom Tromey  <tom@tromey.com>
6279
6280         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6281         type.  Remove no-argument constructor.
6282         <iterator::operator++>: Simplify.
6283         <begin>: Update.
6284         <end>: Use minimal_symbol_count.
6285
6286 2019-01-16  Tom Tromey  <tom@tromey.com>
6287
6288         * objfiles.h (struct objfile) <psymtabs>: New method.
6289         (class objfile_psymtabs): Remove.
6290         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6291         typedef.
6292         <range>: New method.
6293         (require_partial_symbols): Change return type.
6294         * psymtab.c (require_partial_symbols)
6295         (psym_expand_symtabs_matching): Update.
6296         * mdebugread.c (parse_partial_symbols): Update.
6297         * dbxread.c (dbx_end_psymtab): Update.
6298
6299 2019-01-15  Tom Tromey  <tom@tromey.com>
6300
6301         * symtab.c (lookup_objfile_from_block)
6302         (lookup_symbol_in_objfile_symtabs)
6303         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6304         (find_line_symtab, info_sources_command)
6305         (default_collect_symbol_completion_matches_break_on)
6306         (make_source_files_completion_list): Update.
6307         * symmisc.c (print_objfile_statistics, dump_objfile)
6308         (maintenance_print_symbols, maintenance_info_symtabs)
6309         (maintenance_check_symtabs, maintenance_info_line_tables):
6310         Update.
6311         * source.c (select_source_symtab)
6312         (forget_cached_source_info_for_objfile): Update.
6313         * objfiles.h (class objfile_compunits): Remove.
6314         (struct objfile) <compunits_range>: New typedef.
6315         (compunits): New method.
6316         * objfiles.c (objfile_relocate1): Update.
6317         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6318         * maint.c (count_symtabs_and_blocks): Update.
6319         * linespec.c (iterate_over_all_matching_symtabs): Update.
6320         * cp-support.c (add_symbol_overload_list_qualified): Update.
6321         * coffread.c (coff_symtab_read): Update.
6322         * ada-lang.c (add_nonlocal_symbols)
6323         (ada_collect_symbol_completion_matches)
6324         (ada_add_global_exceptions): Update.
6325
6326 2019-01-15  Tom Tromey  <tom@tromey.com>
6327
6328         * progspace.h (program_space) <objfiles_safe_range>: New
6329         typedef.
6330         <objfiles_safe>: New method.
6331         * objfiles.h (class all_objfiles_safe): Remove.
6332         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6333         * jit.c (jit_inferior_exit_hook): Update.
6334
6335 2019-01-17  Tom Tromey  <tom@tromey.com>
6336
6337         * progspace.h (program_space) <objfiles_range>: New typedef.
6338         <objfiles>: New method.
6339         <objfiles_head>: Rename from objfiles.
6340         (object_files): Update.
6341         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6342         * guile/scm-pretty-print.c
6343         (ppscm_find_pretty_printer_from_objfiles): Update.
6344         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6345         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6346         Update.
6347         * python/py-progspace.c (pspy_get_objfiles): Update.
6348         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6349         Update.
6350         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6351         (objfpy_lookup_objfile_by_build_id): Update.
6352         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6353         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6354         Update.
6355         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6356         (expand_symtab_containing_pc, lookup_objfile_from_block)
6357         (lookup_static_symbol, basic_lookup_transparent_type)
6358         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6359         (find_line_symtab, info_sources_command)
6360         (default_collect_symbol_completion_matches_break_on)
6361         (make_source_files_completion_list, find_main_name): Update.
6362         * symmisc.c (print_symbol_bcache_statistics)
6363         (print_objfile_statistics, maintenance_print_symbols)
6364         (maintenance_print_msymbols, maintenance_print_objfiles)
6365         (maintenance_info_symtabs, maintenance_check_symtabs)
6366         (maintenance_expand_symtabs, maintenance_info_line_tables):
6367         Update.
6368         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6369         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6370         (map_overlay_command, unmap_overlay_command)
6371         (simple_overlay_update, expand_symtabs_matching)
6372         (map_symbol_filenames): Update.
6373         * symfile-debug.c (set_debug_symfile): Update.
6374         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6375         Update.
6376         * source.c (select_source_symtab, forget_cached_source_info):
6377         Update.
6378         * solib.c (solib_read_symbols): Update.
6379         * solib-spu.c (append_ocl_sos): Update.
6380         * psymtab.c (maintenance_print_psymbols)
6381         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6382         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6383         * printcmd.c (info_symbol_command): Update.
6384         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6385         Update.
6386         * objfiles.h (class all_objfiles): Remove.
6387         * objfiles.c (have_partial_symbols, have_full_symbols)
6388         (have_minimal_symbols, qsort_cmp, update_section_map)
6389         (shared_objfile_contains_address_p)
6390         (default_iterate_over_objfiles_in_search_order): Update.
6391         * objc-lang.c (info_selectors_command, info_classes_command)
6392         (find_methods): Update.
6393         * minsyms.c (find_solib_trampoline_target): Update.
6394         * maint.c (maintenance_info_sections)
6395         (maintenance_translate_address, count_symtabs_and_blocks):
6396         Update.
6397         * main.c (captured_main_1): Update.
6398         * linux-thread-db.c (try_thread_db_load_from_pdir)
6399         (has_libpthread): Update.
6400         * linespec.c (iterate_over_all_matching_symtabs)
6401         (search_minsyms_for_name): Update.
6402         * jit.c (jit_find_objf_with_entry_addr): Update.
6403         * hppa-tdep.c (find_unwind_entry)
6404         (hppa_lookup_stub_minimal_symbol): Update.
6405         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6406         Update.
6407         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6408         (elf_gnu_ifunc_resolve_by_got): Update.
6409         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6410         * dwarf-index-write.c (save_gdb_index_command): Update.
6411         * cp-support.c (add_symbol_overload_list_qualified): Update.
6412         * breakpoint.c (create_overlay_event_breakpoint)
6413         (create_longjmp_master_breakpoint)
6414         (create_std_terminate_master_breakpoint)
6415         (create_exception_master_breakpoint): Update.
6416         * blockframe.c (find_pc_partial_function): Update.
6417         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6418         (ada_collect_symbol_completion_matches)
6419         (ada_add_global_exceptions): Update.
6420
6421 2019-01-17  Tom Tromey  <tom@tromey.com>
6422
6423         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6424         declare VEC.
6425         (solib_target_parse_libraries): Change return type.
6426         (library_list_start_segment, library_list_start_section)
6427         (library_list_end_library, library_list_start_library); Update.
6428         (solib_target_free_library_list): Remove.
6429         (solib_target_parse_libraries): Remove cleanup.  Change return
6430         type.
6431         (solib_target_current_sos): Update.
6432
6433 2019-01-17  Tom Tromey  <tromey@bapiya>
6434
6435         * valprint.c: Replace "the the" with "the".
6436         * symtab.c: Replace "the the" with "the".
6437         * solib.c: Replace "the the" with "the".
6438         * solib-dsbt.c: Replace "the the" with "the".
6439         * linespec.c: Replace "the the" with "the".
6440         * dwarf2loc.h: Replace "the the" with "the".
6441         * amd64-windows-tdep.c: Replace "the the" with "the".
6442         * aarch64-tdep.c: Replace "the the" with "the".
6443
6444 2019-01-16  Keith Seitz  <keiths@redhat.com>
6445
6446         PR gdb/23773
6447         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6448         <builder>: Rename to ..
6449         <m_builder>: ... this and make private.
6450         (dwarf2_cu::get_builder): New method.  Change all users of
6451         `builder' to use this method.
6452         (dwarf2_start_symtab): Move to ...
6453         (dwarf2_cu::start_symtab): ... here.  Update all callers
6454         (setup_type_unit_groups): Move to ...
6455         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6456         callers.
6457         (dwarf2_cu::reset_builder): New method.
6458         (process_full_compunit, process_full_type_unit): Use
6459         dwarf2_cu::reset_builder.
6460         (follow_die_offset): Record the ancestor CU if it is different
6461         from the followed DIE's CU.
6462         (follow_die_sig_1): Likewise.
6463
6464 2019-01-15  Tom Tromey  <tom@tromey.com>
6465
6466         * remote.c (class remote_state) <buf>: Now a char_vector.
6467         <buf_size>: Remove.
6468         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6469         parameter.
6470         (remote_target::getpkt_or_notif_sane_1)
6471         (remote_target::getpkt_sane)
6472         (remote_target::getpkt_or_notif_sane): Likewise.
6473         (class remote_target) <putpkt>: New overload.
6474         (remote_target::read_frame): Change type of "buf_p".  Remove
6475         sizeof_p parameter.
6476         (packet_ok): New overload.
6477         (packet_check_result): New overload.
6478         Update all uses.
6479
6480 2019-01-14  Tom Tromey  <tom@tromey.com>
6481
6482         * remote-notif.c (handle_notification, remote_notif_ack)
6483         (remote_notif_parse): Make "buf" const.
6484         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6485         const.
6486         (remote_notif_parse, remote_notif_ack, handle_notification):
6487         Likewise.
6488         * remote.c (remote_notif_stop_parse): Make "buf" const.
6489         (remote_target::remote_parse_stop_reply): Make "buf" const.
6490         (remote_notif_stop_ack): Make "buf" const.
6491
6492 2019-01-14  Tom Tromey  <tom@tromey.com>
6493
6494         * remote.c (remote_console_output): Make parameter const.
6495
6496 2019-01-14  Tom Tromey  <tom@tromey.com>
6497
6498         * target-debug.h (target_debug_print_signals): Constify.
6499         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6500         * procfs.c (procfs_target::pass_signals): Update.
6501         * linux-nat.c (linux_nat_target::pass_signals): Update.
6502         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6503         * target-delegates.c: Rebuild.
6504         * remote.c (remote_target::program_signals): Update.
6505         (remote_target::pass_signals): Update.
6506         * target.c (target_pass_signals): Constify argument.
6507         (target_program_signals): Likewise.
6508         * target.h (struct target_ops) <pass_signals, program_signals>:
6509         Constify argument.
6510         (target_pass_signals, target_program_signals): Constify argument.
6511
6512 2019-01-14  Tom Tromey  <tom@tromey.com>
6513
6514         PR tui/28819:
6515         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6516
6517 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6518
6519         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6520         field.
6521         * rs6000-tdep.c: Include reggroups.h.
6522         (IS_V_ALIAS_PSEUDOREG): Define.
6523         (rs6000_register_name): Return names for the "vX" aliases.
6524         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6525         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6526         aliases.  Call default_register_reggroup_p for all other
6527         pseudo-registers.
6528         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6529         New functions.
6530         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6531         Handle "vX" aliases.
6532         (v_alias_pseudo_register_collect): New function.
6533         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6534         (rs6000_gdbarch_init): Initialize "vX" aliases as
6535         pseudo-registers.  Restore registration of
6536         rs6000_pseudo_register_reggroup_p with
6537         set_tdesc_pseudo_register_reggroup_p.
6538
6539 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6540
6541         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6542         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6543         set_gdbarch_num_pseudo_regs.
6544
6545 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6546
6547         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6548         Remove arg prefixname, add do_set and do_show.
6549         Add member functions set_list and show_list.
6550         * cli/cli-style.c (class cli_style_option): Update accordingly.
6551         (style_set_list): Move to file scope.
6552         (style_show_list): Likewise.
6553         (set_style): Call help_list.
6554         (show_style): Call cmd_show_list.
6555         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6556         Update to use the new macro.
6557
6558 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6559
6560         * ada-lang.c (_initialize_ada_language): Expand the help text
6561         for the "catch exception" command.
6562
6563 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6564
6565         * symtab.c (matching_obj_sections): Initialize obj,
6566         declare it closer to its usage.
6567
6568 2019-01-10  Tom Tromey  <tom@tromey.com>
6569
6570         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6571         (basic_inf_threads_range): Remove.
6572         (inf_threads_range, inf_non_exited_threads_range)
6573         (safe_inf_threads_range): Use next_adapter.
6574
6575 2019-01-10  Keith Seitz  <keiths@redhat.com>
6576
6577         PR gdb/23712
6578         PR symtab/23010
6579         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6580         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6581
6582 2019-01-10  Keith Seitz  <keiths@redhat.com>
6583
6584         PR gdb/23712
6585         PR symtab/23010
6586         * dictionary.c (pending_to_vector): Remove.
6587         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6588         Remove _1 suffix, replacing functions of the same name.  Update
6589         all callers.
6590         (dict_create_hashed, dict_create_hashed_expandable)
6591         (dict_create_linear, dict_create_linear_expandable, dict_free)
6592         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6593         Make functions static.
6594
6595 2019-01-10  Keith Seitz  <keiths@redhat.com>
6596
6597         PR gdb/23712
6598         PR symtab/23010
6599         * dictionary.h (struct dictionary): Replace declaration with
6600         multidictionary.
6601         (dict_create_hashed, dict_create_hashed_expandable)
6602         (dict_create_linear, dict_create_linear_expandable)
6603         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6604         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6605         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6606         taking multidictionary argument.
6607         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6608         * block.h (struct block) <dict>: Change to multidictionary
6609         and rename `multidict'.
6610         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6611         symmisc.c: Update all dictionary references to multidictionary.
6612
6613 2019-01-10  Keith Seitz  <keiths@redhat.com>
6614
6615         PR gdb/23712
6616         PR symtab/23010
6617         * dictionary.c: Include unordered_map.
6618         (pending_to_vector): New function.
6619         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6620         Rewrite the non-"_1" functions to take vector instead
6621         of linked list.
6622         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6623         "new" _1 versions of the same name.
6624         (multidictionary): Define.
6625         (std::hash<enum language): New definition.
6626         (collate_pending_symbols_by_language, mdict_create_hashed)
6627         (mdict_create_hashed_expandable, mdict_create_linear)
6628         (mdict_create_linear_expandable, mdict_free)
6629         (find_language_dictionary, create_new_language_dictionary)
6630         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6631         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6632         (mdict_size, mdict_empty): New functions.
6633         * dictionary.h (mdict_iterator): Define.
6634
6635 2019-01-10  Pedro Alves  <palves@redhat.com>
6636
6637         * breakpoint.c (read_uploaded_action)
6638         (create_tracepoint_from_upload): Adjust to use
6639         gdb::unique_xmalloc_ptr.
6640         * ctf.c (ctf_write_uploaded_tp):
6641         (SET_ARRAY_FIELD): Use emplace_back.
6642         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6643         * tracefile-tfile.c (tfile_write_uploaded_tp):
6644         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6645         gdb::unique_xmalloc_ptr.
6646         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6647         at_string, cond_string, cmd_strings>: Replace char pointers
6648         with gdb::unique_xmalloc_ptr.
6649
6650 2019-01-10  Pedro Alves  <palves@redhat.com>
6651
6652         * solib-target.c (library_list_start_library): Don't xstrdup name.
6653
6654 2019-01-10  Pedro Alves  <palves@redhat.com>
6655
6656         * mdebugread.c (parse_partial_symbols): Use
6657         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6658
6659 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6660
6661         * linux-fork.c (scoped_switch_fork_info)
6662         <~scoped_switch_fork_info>: Fix incorrect variable name.
6663
6664 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6665
6666         * linux-fork.c (scoped_switch_fork_info)
6667         <scoped_switch_fork_info>: Make explicit.
6668         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6669
6670 2019-01-10  Tom Tromey  <tom@tromey.com>
6671
6672         * objfiles.h (objfile::reset_psymtabs): Update.
6673         * objfiles.c (objfile::objfile): Update.
6674         * psymtab.h (psymtab_storage::obstack): Update.
6675         (psymtab_storage::m_obstack): Use gdb::optional.
6676         (class psymtab_storage): Update comment.  Remove objfile
6677         parameter.
6678         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6679
6680 2019-01-10  Tom Tromey  <tom@tromey.com>
6681
6682         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6683         <free_psymtabs>: Now private.
6684         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6685         (allocate_psymtab): Use new method.
6686
6687 2019-01-10  Tom Tromey  <tom@tromey.com>
6688
6689         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6690         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6691         * mdebugread.c (parse_partial_symbols): Use
6692         allocate_dependencies.
6693         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6694         allocate_dependencies.
6695         (process_psymtab_comp_unit_reader)
6696         (build_type_psymtab_dependencies): Likewise.
6697         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6698
6699 2019-01-10  Tom Tromey  <tom@tromey.com>
6700
6701         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6702         PSYMBOL_SET_LANGUAGE.
6703         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6704
6705 2019-01-10  Tom Tromey  <tom@tromey.com>
6706
6707         * psymtab.h (psymtab_storage::obstack): New method.
6708         <m_obstack>: Rename from obstack; now private.
6709         * psymtab.c (psymtab_storage): Update.
6710         * dwarf2read.c (create_addrmap_from_index)
6711         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6712         Update.
6713
6714 2019-01-10  Tom Tromey  <tom@tromey.com>
6715
6716         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6717         * objfiles.h (objfile::reset_psymtabs): New method.
6718
6719 2019-01-10  Tom Tromey  <tom@tromey.com>
6720
6721         * symmisc.c (print_symbol_bcache_statistics): Update.
6722         (print_objfile_statistics): Update.
6723         * symfile.c (reread_symbols): Update.
6724         * psymtab.h (class psymtab_storage): New.
6725         * psymtab.c (psymtab_storage): New constructor.
6726         (~psymtab_storage): New destructor.
6727         (require_partial_symbols): Update.
6728         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6729         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6730         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6731         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6732         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6733         (start_psymtab_common, end_psymtab_common)
6734         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6735         (allocate_psymtab): Update.
6736         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6737         Update.
6738         (dump_psymtab_addrmap, maintenance_print_psymbols)
6739         (maintenance_check_psymtabs): Update.
6740         (class objfile_psymtabs): Move to objfiles.h.
6741         * psympriv.h (discard_psymtab): Now inline.
6742         (psymtab_discarder::psymtab_discarder): Update.
6743         (psymtab_discarder::~psymtab_discarder): Update.
6744         (ALL_OBJFILE_PSYMTABS): Rewrite.
6745         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6746         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6747         Remove fields.
6748         <partial_symtabs>: New field.
6749         (class objfile_psymtabs): Move from psymtab.h.  Update.
6750         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6751         psymbol_cache.
6752         (objfile::~objfile): Don't destroy psymbol_cache.
6753         * mdebugread.c (parse_partial_symbols): Update.
6754         * dwarf2read.c (create_addrmap_from_index)
6755         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6756         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6757         (add_partial_subprogram, dwarf2_ranges_read): Update.
6758         * dwarf-index-write.c (write_address_map)
6759         (write_one_signatured_type, recursively_write_psymbols)
6760         (class debug_names, class debug_names, write_psymtabs_to_index):
6761         Update.
6762
6763 2019-01-10  Tom Tromey  <tom@tromey.com>
6764
6765         * symtab.h (SYMBOL_SET_NAMES): Update.
6766         (symbol_set_names): Update.
6767         (MSYMBOL_SET_NAMES): Update.
6768         * symtab.c (symbol_set_names): Change argument to be an
6769         objfile_per_bfd_storage.
6770         * psymtab.c (add_psymbol_to_bcache): Update.
6771         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6772
6773 2019-01-10  Tom Tromey  <tom@tromey.com>
6774
6775         * symtab.c (create_demangled_names_hash): Change argument to be an
6776         objfile_per_bfd_storage.
6777         (symbol_set_names): Update.
6778
6779 2019-01-10  Tom Tromey  <tom@tromey.com>
6780
6781         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6782         init_psymbol_list.
6783         * psymtab.c (init_psymbol_list): Do nothing if already called.
6784         * psympriv.h (init_psymbol_list): Add comment.
6785         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6786         init_psymbol_list.
6787         * dbxread.c (dbx_symfile_read): Unconditionally call
6788         init_psymbol_list.
6789
6790 2019-01-10  Tom Tromey  <tom@tromey.com>
6791
6792         * xcoffread.c (scan_xcoff_symtab): Update.
6793         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6794         "where".
6795         * mdebugread.c (parse_partial_symbols)
6796         (handle_psymbol_enumerators): Update.
6797         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6798         * dbxread.c (read_dbx_symtab): Update.
6799         * psympriv.h (psymbol_placement): New enum.
6800         (add_psymbol_to_list): Update.
6801
6802 2019-01-10  Tom Tromey  <tom@tromey.com>
6803
6804         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6805         static_psymbols parameters.
6806         (scan_xcoff_symtab): Update.
6807         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6808         static_psymbols parameters.
6809         * psympriv.h (start_psymtab_common): Update.
6810         * mdebugread.c (parse_partial_symbols): Update.
6811         * dwarf2read.c (create_partial_symtab): Update.
6812         * dbxread.c (read_dbx_symtab): Update.
6813         (start_psymtab): Remove global_psymbols and static_psymbols
6814         parameters.
6815
6816 2019-01-10  Tom Tromey  <tom@tromey.com>
6817
6818         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6819         * psymtab.c (allocate_psymtab): Add comment.
6820         * psympriv.h (allocate_psymtab): Add comment.
6821         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6822         initializations.
6823         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6824
6825 2019-01-10  Tom Tromey  <tom@tromey.com>
6826
6827         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6828         Don't declare.
6829         * mipsread.c: Include mdebugread.h.
6830         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6831         Declare.
6832         * elfread.c: Include mdebugread.h.
6833
6834 2019-01-09  Tom Tromey  <tom@tromey.com>
6835
6836         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6837         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6838         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6839         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6840         (psym_lookup_symbol, psym_find_last_source_symtab)
6841         (psym_forget_cached_source_info, psym_print_stats)
6842         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6843         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6844         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6845         (psym_find_compunit_symtab_by_address)
6846         (maintenance_print_psymbols, maintenance_info_psymtabs)
6847         (maintenance_check_psymtabs): Use ranged for.
6848         * psymtab.h (class objfile_psymtabs): New.
6849         (require_partial_symbols): Return objfile_psymtabs.
6850         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6851
6852 2019-01-09  Tom Tromey  <tom@tromey.com>
6853
6854         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6855         (find_pc_mapped_section, list_overlays_command)
6856         (map_overlay_command, unmap_overlay_command)
6857         (simple_overlay_update): Use all_objfiles.
6858         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6859         * printcmd.c (info_symbol_command): Use all_objfiles.
6860         * objfiles.h (ALL_OBJSECTIONS): Remove.
6861         * maint.c (maintenance_translate_address): Use all_objfiles.
6862         * gcore.c (gcore_create_callback): Use all_objfiles.
6863         (objfile_find_memory_regions): Likewise.
6864
6865 2019-01-09  Tom Tromey  <tom@tromey.com>
6866
6867         * symtab.c (find_line_symtab, info_sources_command)
6868         (make_source_files_completion_list): Use objfile_compunits.
6869         * source.c (select_source_symtab): Use objfile_compunits.
6870         * objfiles.h (struct objfile): Update comment.
6871         (ALL_OBJFILES): Remove.
6872         (ALL_FILETABS): Remove.
6873         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6874         objfile_compunits.
6875
6876 2019-01-09  Tom Tromey  <tom@tromey.com>
6877
6878         * symmisc.c (print_objfile_statistics, dump_objfile)
6879         (maintenance_print_symbols): Use compunit_filetabs.
6880         * source.c (forget_cached_source_info_for_objfile): Use
6881         compunit_filetabs.
6882         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6883         (ALL_FILETABS): Use compunit_filetabs.
6884         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6885         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6886
6887 2019-01-09  Tom Tromey  <tom@tromey.com>
6888
6889         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6890         (compunit_filetabs): New.
6891         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6892         compunit_filetabs.
6893         (info_sources_command, make_source_files_completion_list): Remove
6894         declaration.
6895         * symmisc.c (print_objfile_statistics, dump_objfile)
6896         (maintenance_print_symbols): Remove declaration.
6897         (maintenance_info_symtabs): Use compunit_filetabs.
6898         (maintenance_info_line_tables): Likewise.
6899         * source.c (select_source_symtab): Change local variable name.
6900         (forget_cached_source_info_for_objfile): Remove declaration.
6901         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6902         * objfiles.c (objfile_relocate1): Remove declaration.
6903         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6904         declaration.
6905         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6906         * coffread.c (coff_symtab_read): Remove declaration.
6907         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6908         compunit_filetabs.
6909
6910 2019-01-09  Tom Tromey  <tom@tromey.com>
6911
6912         * symtab.c (lookup_objfile_from_block)
6913         (find_pc_sect_compunit_symtab, search_symbols)
6914         (default_collect_symbol_completion_matches_break_on): Use
6915         objfile_compunits.
6916         * objfiles.h (ALL_COMPUNITS): Remove.
6917         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6918         * cp-support.c (add_symbol_overload_list_qualified): Use
6919         objfile_compunits.
6920         * ada-lang.c (ada_collect_symbol_completion_matches)
6921         (ada_add_global_exceptions): Use objfile_compunits.
6922
6923 2019-01-09  Tom Tromey  <tom@tromey.com>
6924
6925         * source.c (select_source_symtab)
6926         (forget_cached_source_info_for_objfile): Remove declaration.
6927         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6928         declaration.
6929         * maint.c (count_symtabs_and_blocks): Remove declaration.
6930         * cp-support.c (add_symbol_overload_list_qualified): Remove
6931         declaration.
6932         * coffread.c (coff_symtab_read): Remove declaration.
6933         * symtab.c (lookup_symbol_in_objfile_symtabs)
6934         (basic_lookup_transparent_type_1): Use objfile_compunits.
6935         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6936         (info_sources_command, search_symbols)
6937         (default_collect_symbol_completion_matches_break_on)
6938         (make_source_files_completion_list): Remove declaration.
6939         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6940         (ada_collect_symbol_completion_matches)
6941         (ada_add_global_exceptions): Remove declaration.
6942         * linespec.c (iterate_over_all_matching_symtabs): Use
6943         objfile_compunits.
6944         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6945         (class objfile_compunits): New.
6946         (ALL_COMPUNITS): Use objfile_compunits.
6947         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6948         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6949         objfile_compunits.
6950         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6951
6952 2019-01-09  Tom Tromey  <tom@tromey.com>
6953
6954         * symtab.c (search_symbols)
6955         (default_collect_symbol_completion_matches_break_on): Use
6956         objfile_msymbols.
6957         * ada-lang.c (ada_lookup_simple_minsym)
6958         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6959         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6960         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6961         objfile_msymbols.
6962         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6963         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6964         * objc-lang.c (find_methods): Use objfile_msymbols.
6965         (info_selectors_command, info_classes_command): Likewise.
6966         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6967         * objfiles.h (class objfile_msymbols): New.
6968         (ALL_OBJFILE_MSYMBOLS): Remove.
6969         (ALL_MSYMBOLS): Remove.
6970
6971 2019-01-09  Tom Tromey  <tom@tromey.com>
6972
6973         * common/next-iterator.h (next_adapter): Add Iterator template
6974         parameter.
6975         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6976         (class all_objfiles_safe): New.
6977         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6978         * objfiles.c (put_objfile_before): Update comment.
6979         (add_separate_debug_objfile): Likewise.
6980         (free_all_objfiles): Use all_objfiles_safe.
6981         (objfile_purge_solibs): Likewise.
6982
6983 2019-01-09  Tom Tromey  <tom@tromey.com>
6984
6985         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6986         (expand_symtab_containing_pc, lookup_static_symbol)
6987         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6988         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6989         all_objfiles.
6990         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6991         * breakpoint.c (create_overlay_event_breakpoint)
6992         (create_longjmp_master_breakpoint)
6993         (create_std_terminate_master_breakpoint)
6994         (create_exception_master_breakpoint): Use all_objfiles.
6995         * linux-thread-db.c (try_thread_db_load_from_pdir)
6996         (has_libpthread): Use all_objfiles.
6997         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6998         * linespec.c (iterate_over_all_matching_symtabs)
6999         (search_minsyms_for_name): Use all_objfiles.
7000         * maint.c (maintenance_info_sections): Use all_objfiles.
7001         * main.c (captured_main_1): Use all_objfiles.
7002         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7003         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7004         * guile/scm-pretty-print.c
7005         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7006         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7007         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7008         (maintenance_print_msymbols): Use all_objfiles.
7009         * source.c (select_source_symtab): Use all_objfiles.
7010         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7011         * symfile.c (remove_symbol_file_command)
7012         (expand_symtabs_matching, map_symbol_filenames): Use
7013         all_objfiles.
7014         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7015         all_objfiles.
7016         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7017         * objc-lang.c (find_methods): Use all_objfiles.
7018         * objfiles.c (have_partial_symbols, have_full_symbols)
7019         (have_minimal_symbols, qsort_cmp)
7020         (default_iterate_over_objfiles_in_search_order): Use
7021         all_objfiles.
7022         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7023         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7024         (maintenance_check_psymtabs): Use all_objfiles.
7025         (ALL_PSYMTABS): Remove.
7026         * compile/compile-object-run.c (do_module_cleanup): Use
7027         all_objfiles.
7028         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7029         * cp-support.c (add_symbol_overload_list_qualified): Use
7030         all_objfiles.
7031         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7032         Use all_objfiles.
7033         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7034         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7035         all_objfiles.
7036         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7037         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7038         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7039         Uses all_objfiles.
7040         * solib.c (solib_read_symbols): Use all_objfiles
7041
7042 2019-01-09  Tom Tromey  <tom@tromey.com>
7043
7044         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7045         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7046         all_objfiles.
7047         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7048         * symmisc.c (print_symbol_bcache_statistics)
7049         (print_objfile_statistics, maintenance_print_objfiles)
7050         (maintenance_info_symtabs, maintenance_check_symtabs)
7051         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7052         all_objfiles.
7053         * source.c (forget_cached_source_info): Use all_objfiles.
7054         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7055         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7056         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7057         * objfiles.c (update_section_map): Use all_objfiles.
7058         (shared_objfile_contains_address_p): Likewise.
7059         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7060         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7061
7062 2019-01-09  Tom Tromey  <tom@tromey.com>
7063
7064         * common/next-iterator.h: New file.
7065         * objfiles.h (class all_objfiles): New.
7066         (struct objfile_iterator): New.
7067
7068 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7069
7070         * NEWS: Move the description of the changed "frame", "select-frame",
7071          and "info frame" commands to the Changed commands section.
7072
7073 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7074
7075         * gdbtypes.c (check_stub_method_group): Remove handling of old
7076         mangling schemes.
7077         * linespec.c (find_methods): Likewise.
7078         * stabsread.c (read_member_functions): Likewise.
7079         * valops.c (search_struct_method): Likewise.
7080         (value_struct_elt_for_reference): Likewise.
7081         * NEWS: Mention this change.
7082
7083 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7084
7085         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7086         print_source_lines.
7087         * source.c (print_source_lines_base): Update line number check.
7088         (print_source_lines): New function.
7089         (source_lines_range::source_lines_range): New function.
7090         * source.h (class source_lines_range): New class.
7091         (print_source_lines): New declaration.
7092
7093 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7094
7095         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7096
7097 2019-01-08  Tom Tromey  <tom@tromey.com>
7098             Simon Marchi  <simon.marchi@ericsson.com>
7099
7100         PR gdb/24060
7101         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7102         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7103         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7104         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7105         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7106         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7107
7108 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7109
7110         * source.c (select_source_symtab): Move header comment to
7111         declaration in source.h.
7112         (forget_cached_source_info_for_objfile): Likewise.
7113         (forget_cached_source_info): Likewise.
7114         (identify_source_line): Likewise.
7115         * source.h (identify_source_line): Move declaration from symtab.h
7116         and add comment from source.c
7117         (print_source_lines): Likewise.
7118         (forget_cached_source_info_for_objfile): Likewise.
7119         (forget_cached_source_info): Likewise.
7120         (select_source_symtab): Likewise.
7121         (enum print_source_lines_flag): Move definition from symtab.h.
7122         * symtab.h (identify_source_line): Move declaration to source.h.
7123         (print_source_lines): Likewise.
7124         (forget_cached_source_info_for_objfile): Likewise.
7125         (forget_cached_source_info): Likewise.
7126         (select_source_symtab): Likewise.
7127         (enum print_source_lines_flag): Move definition to source.h.
7128         * tui/tui-hooks.c: Add 'source.h' include.
7129
7130 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7131
7132         * source.c (print_source_lines_base): Handle requests to print
7133         reverse line number sequences, and guard against empty lines
7134         string.
7135
7136 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7137
7138         * source.c (print_source_lines_base): Fix skip of '\r' if next
7139         character is '\n'.
7140
7141 2019-01-06  Tom Tromey  <tom@tromey.com>
7142
7143         * c-exp.y (struct c_parse_state) <macro_original_text,
7144         expansion_obstack>: New member.
7145         (macro_original_text, expansion_obstack): Remove globals.
7146         (scan_macro_expansion, scanning_macro_expansion)
7147         (finished_macro_expansion): Update.
7148         (scan_macro_cleanup): Remove.
7149         (yylex, c_parse): Update.
7150
7151 2019-01-06  Tom Tromey  <tom@tromey.com>
7152
7153         * c-exp.y (struct c_parse_state) <strings>: New member.
7154         (operator_stoken): Update.
7155
7156 2019-01-06  Tom Tromey  <tom@tromey.com>
7157
7158         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7159         (union type_stack_elt) <typelist_val>: Now a pointer to
7160         std::vector.
7161         (type_stack_cleanup): Don't declare.
7162         (push_typelist): Update.
7163         * parse.c (pop_typelist): Return a std::vector.
7164         (push_typelist): Take a std::vector.
7165         (follow_types): Update.  Do not free args.
7166         (type_stack_cleanup): Remove.
7167         * c-exp.y (struct c_parse_state): New.
7168         (cpstate): New global.
7169         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7170         (nonempty_typelist): Update.
7171         (func_mod): Create a new vector.
7172         (c_parse): Create a c_parse_state.
7173         (check_parameter_typelist): Do not delete params.
7174         (function_method): Update.  Do not delete type_list.
7175
7176 2019-01-06  Tom Tromey  <tom@tromey.com>
7177
7178         PR gdb/28155:
7179         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7180         check_typedef.
7181         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7182         (print_return_value): Likewise.
7183
7184 2019-01-05  Tom Tromey  <tom@tromey.com>
7185
7186         * contrib/cleanup_check.py: Remove.
7187         * contrib/gcc-with-excheck: Remove.
7188         * contrib/exsummary.py: Remove.
7189         * contrib/excheck.py: Remove.
7190
7191 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7192
7193         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7194         NULL. Initialize tpprev to NULL instead of assigning it
7195         to NULL on the next statement.
7196         * windows-nat.c (windows_delete_thread): Remove check for
7197         main_thread_id before printing thread exit notifications.
7198         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7199         Remove thread ID check against main_thread_id.
7200         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7201         windows_delete_thread.
7202         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7203
7204 2019-01-04  Tom Tromey  <tom@tromey.com>
7205
7206         * compile/compile.c (_initialize_compile): Use upper case for
7207         metasyntactic variables.
7208         * symmisc.c (_initialize_symmisc): Use upper case for
7209         metasyntactic variables.
7210         * psymtab.c (_initialize_psymtab): Use upper case for
7211         metasyntactic variables.
7212         * demangle.c (demangle_command): Use upper case for metasyntactic
7213         variables.
7214         (_initialize_demangler): Likewise.
7215         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7216         variables.
7217
7218 2019-01-03  Tom Tromey  <tom@tromey.com>
7219
7220         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7221
7222 2019-01-03  Tom Tromey  <tom@tromey.com>
7223
7224         * python/py-symtab.c (salpy_str): Update.
7225         (struct salpy_sal_object) <symtab>: Now a PyObject.
7226         (salpy_dealloc): Update.
7227         (del_objfile_sal): Use gdbpy_ref.
7228
7229 2019-01-03  Tom Tromey  <tom@tromey.com>
7230
7231         * python/py-type.c (convert_field): Use new_reference.  Return
7232         gdbpy_ref.
7233         (make_fielditem): Return gdbpy_ref.
7234         (typy_fields): Update.
7235         (typy_getitem): Update.
7236         (field_name): Return gdbpy_ref.  Use new_reference.
7237         (typy_iterator_iternext): Update.
7238
7239 2019-01-03  Tom Tromey  <tom@tromey.com>
7240
7241         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7242
7243 2019-01-03  Tom Tromey  <tom@tromey.com>
7244
7245         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7246         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7247         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7248         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7249         (pspy_set_type_printers): Likewise.
7250         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7251         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7252         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7253         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7254         (objfpy_set_type_printers): Likewise.
7255
7256 2019-01-03  Tom Tromey  <tom@tromey.com>
7257
7258         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7259         (gdbpy_print_stack): Use gdbpy_err_fetch.
7260         * python/python-internal.h (class gdbpy_err_fetch): New class.
7261         (class gdbpy_enter) <m_error_type, m_error_value,
7262         m_error_traceback>: Remove.
7263         <m_error>: New member.
7264         (gdbpy_exception_to_string): Don't declare.
7265         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7266         * python/py-value.c (convert_value_from_python): Use
7267         gdbpy_err_fetch.
7268         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7269         gdbpy_exception_to_string.
7270         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7271         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7272         gdbpy_err_fetch.
7273
7274 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7275
7276         * linux-nat.c (delete_lwp_cleanup): Delete.
7277         (struct lwp_deleter): New struct.
7278         (lwp_info_up): New typedef.
7279         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7280         lwp_info_up.
7281
7282 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7283
7284         * linux-fork.c (class scoped_switch_fork_info): New class.
7285         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7286
7287 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7288
7289         * valops.c (find_overload_match): Remove use of null_cleanup, and
7290         calls to do_cleanups.
7291
7292 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7293
7294         * compile/compile-cplus-types.c
7295         (compile_cplus_instance::decl_name): Handle changes to
7296         cp_func_name.
7297         * cp-support.c (cp_func_name): Update header comment, update
7298         return type.
7299         * cp-support.h (cp_func_name): Update return type in declaration.
7300         * valops.c (find_overload_match): Move temp_func local to top
7301         level of function and change its type.  Use temp_func to hold and
7302         delete temporary string obtained from cp_func_name.
7303
7304 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7305
7306         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7307         gdb::char_vector, remove cleanup, and update uses of `msg`.
7308
7309 2019-01-03  Jim Wilson  <jimw@sifive.com>
7310
7311         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7312
7313 2019-01-02  Tom Tromey  <tom@tromey.com>
7314
7315         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7316         (tdesc_parse_xml): Remove cleanups.
7317         * target-descriptions.h (make_cleanup_free_target_description):
7318         Don't declare.
7319         (target_desc_deleter): New struct.
7320         (target_desc_up): New typedef.
7321         * target-descriptions.c (target_desc_deleter::operator()): Rename
7322         from free_target_description.
7323         (make_cleanup_free_target_description): Remove.
7324
7325 2019-01-02  Tom Tromey  <tom@tromey.com>
7326
7327         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7328         constructor, destructor.
7329         (linespec_parser): Remove typedef.
7330         (~linespec_parser): Rename from linespec_parser_delete.
7331         (linespec_lex_to_end, linespec_complete_label)
7332         (linespec_complete): Update.
7333         (decode_line_full): Remove cleanups.
7334         (decode_line_1): Update.
7335
7336 2019-01-02  Tom Tromey  <tom@tromey.com>
7337
7338         * python/python-internal.h (inferior_to_inferior_object): Change
7339         return type.
7340         * python/py-exitedevent.c (create_exited_event_object): Update.
7341         * python/py-inferior.c (inferior_to_inferior_object): Return
7342         gdbpy_ref.
7343         (python_new_inferior, python_inferior_deleted)
7344         (thread_to_thread_object, delete_thread_object)
7345         (build_inferior_list, gdbpy_selected_inferior): Update.
7346         * python/py-infthread.c (create_thread_object): Update.  Also fail
7347         if inferior_to_inferior_object fails.
7348
7349 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7350
7351         * inferior.h (class inferior) <displaced_step_state>: New field.
7352         * infrun.h (struct displaced_step_state): Move here from
7353         infrun.c.  Initialize fields, add constructor.
7354         <inf>: Remove field.
7355         <reset>: New method.
7356         * infrun.c (struct displaced_step_inferior_state): Move to
7357         infrun.h.
7358         (displaced_step_inferior_states): Remove.
7359         (get_displaced_stepping_state): Adust.
7360         (displaced_step_in_progress_any_inferior): Adjust.
7361         (displaced_step_in_progress_thread): Adjust.
7362         (displaced_step_in_progress): Adjust.
7363         (add_displaced_stepping_state): Remove.
7364         (get_displaced_step_closure_by_addr): Adjust.
7365         (remove_displaced_stepping_state): Remove.
7366         (infrun_inferior_exit): Call displaced_step_state.reset.
7367         (use_displaced_stepping): Don't check for NULL.
7368         (displaced_step_prepare_throw): Call
7369         get_displaced_stepping_state.
7370         (displaced_step_fixup): Don't check for NULL.
7371         (prepare_for_detach): Don't check for NULL.
7372
7373 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7374
7375         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7376          in case of call that did not complete.
7377
7378 2019-01-02  Andrey Utkin  <autkin@undo.io>
7379
7380         * symfile.c (find_separate_debug_file): Fix search of debug files for
7381         remote debuggee.
7382
7383 2019-01-02  Tom Tromey  <tom@tromey.com>
7384
7385         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7386         indentation.
7387         * python/py-frame.c (frapy_older): Remove cast.
7388         (frapy_newer): Likewise.
7389         * python/py-breakpoint.c (local_setattro): Remove cast.
7390         * python/py-arch.c (archpy_name): Remove local variable.
7391         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7392
7393 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7394
7395         * unittests/basic_string_view/element_access/char/empty.cc:
7396         Fix year range in copyright header.
7397
7398 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7399
7400         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7401         Delete.
7402         <operator==>: Update with for removed field.
7403         <hash>: Likewise.
7404         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7405         <isa_features>: ...this.
7406         <abi_features>: New field.
7407         (riscv_isa_flen): Update comment.
7408         (riscv_abi_xlen): New declaration.
7409         (riscv_abi_flen): New declaration.
7410         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7411         isa_features.
7412         (riscv_abi_xlen): New function.
7413         (riscv_isa_flen): Update to get answer from isa_features.
7414         (riscv_abi_flen): New function.
7415         (riscv_has_fp_abi): Update to get answer from abi_features.
7416         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7417         xlen and flen.
7418         (riscv_call_info) <xlen, flen>: Update comment.
7419         (riscv_call_arg_struct): Remove invalid assertions
7420         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7421         is removed.
7422         (riscv_gdbarch_init): Gather isa features and abi features
7423         separately, ensure both match on the gdbarch when reusing an old
7424         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7425         a target with 64-bit float hardware.
7426
7427 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7428
7429         * source.c (search_command_helper): Stop reverse search
7430         when line 1 has been searched.
7431
7432 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7433
7434         * record-full.c (record_full_base_target::close): Rewrite
7435         record_full_core_buf_list free logic.
7436
7437 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7438
7439         * break-catch-syscall.c (print_one_catch_syscall): xfree
7440         the last text.
7441
7442 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7443
7444         * top.c (print_gdb_version): Update Copyright year in version
7445         message.
7446
7447 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7448
7449         Update copyright year range in all GDB files.
7450
7451 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7452
7453         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7454
7455 For older changes see ChangeLog-2018.
7456 \f
7457 Local Variables:
7458 mode: change-log
7459 left-margin: 8
7460 fill-column: 74
7461 version-control: never
7462 coding: utf-8
7463 End:
7464