gdb/ChangeLog

   1 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
   4         (grow_vect): Remove declaration.
   5         (ada_type_of_array): Remove declaration.
   6         (ada_update_initial_language): Remove declaration.
   7         (ada_fold_name): Remove declaration.
   8         (ada_fill_in_ada_prototype): Remove declaration.
   9         (user_select_syms): Remove declaration.
  10         (get_selections): Remove declaration.
  11         (ada_tag_type): Remove declaration.
  12         (ada_value_tag): Remove declaration.
  13         (ada_is_others_clause): Remove declaration.
  14         (ada_in_variant): Remove declaration.
  15         (ada_value_struct_elt): Remove declaration.
  16         (ada_attribute_name): Remove declaration.
  17         (ada_system_address_type): Remove declaration.
  18         * ada-lang.c (ada_watch_location_expression): Make static.
  19         (GROW_VECT): Move here from ada-lang.h.
  20         (grow_vect): Make static.
  21         (ada_update_initial_language): Make static.
  22         (ada_fold_name): Make static.
  23         (ada_type_of_array): Make static.
  24         (encoded_ordered_before): Move up.
  25         (sort_choices): Move up.
  26         (print_signatures): Move up.
  27         (ada_print_symbol_signature): Move up.
  28         (get_selections): Move up and make static.
  29         (user_select_syms): Move up and make static.
  30         (ada_value_struct_elt): Move up and make static.
  31         (ada_tag_type): Make static.
  32         (ada_value_tag): Make static.
  33         (ada_is_others_clause): Make static.
  34         (ada_in_variant): Make static.
  35         (ada_attribute_name): Make static.
  36
  37 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
  38
  39         * ada-lang.c: Remove includes.
  40         * ada-typeprint.c: Remove includes.
  41         * ada-valprint.c: Remove includes.
  42
  43 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
  44
  45         * addrmap.c: Add static assertions of type size, moved from
  46         _initialize_addrmap.
  47         (_initialize_addrmap): Remove.
  48
  49 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
  50
  51         * coffread.c (record_minimal_symbol): Update.
  52         (process_coff_symbol): Update.
  53         * dbxread.c (read_dbx_symtab): Update.
  54         * dwarf2read.c (add_partial_symbol): Update.
  55         (fixup_go_packaging): Update.
  56         (load_partial_dies): Update.
  57         (new_symbol): Update.
  58         * elfread.c (record_minimal_symbol): Change signature to use
  59         gdb::string_view instead of name+len.
  60         (elf_symtab_read): Update.
  61         (elf_rel_plt_read): Update.
  62         * mdebugread.c (parse_partial_symbols): Update.
  63         (handle_psymbol_enumerators): Update.
  64         (new_symbol): Update.
  65         * minsyms.c (minimal_symbol_reader::record_full): Change signature
  66         to use gdb::string_view instead of name+len.
  67         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
  68         * psympriv.h (add_psymbol_to_list): Likewise.
  69         * psymtab.c (add_psymbol_to_bcache): Likewise.
  70         (add_psymbol_to_list): Likewise.
  71         * stabsread.c (define_symbol): Update.
  72         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
  73         * symtab.h (SYMBOL_SET_NAMES): Likewise.
  74         (symbol_set_names): Likewise.
  75         * xcoffread.c (scan_xcoff_symtab): Update.
  76
  77 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
  78
  79         * symtab.h (symbol_set_names): Document that copy_name must be
  80         set to true for non-nullterminated strings.
  81         * symtab.c (symbol_set_names): Only make a nullterminated copy of
  82         linkage_name if the entry was not found and we need to demangle.
  83
  84 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
  85
  86         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
  87         * dwarf2-frame.c (bsearch_fde_cmp): Update.
  88         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
  89         * gdbsupport/gdb_binary_search.h: New file.
  90
  91 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
  92
  93         * NEWS: Mention new --with-system-gdbinit-dir option.
  94         * config.in: Regenerate.
  95         * configure: Regenerate.
  96         * configure.ac: Add new option --with-system-gdbinit-dir.
  97         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
  98         for a ".gdb" suffix.
  99         * main.c (get_init_files): Change system_gdbinit argument to
 100         a vector and return the files in SYSTEM_GDBINIT_DIR in
 101         addition to SYSTEM_GDBINIT.
 102         (captured_main_1): Update.
 103         (print_gdb_help): Update.
 104         * top.c (print_gdb_configuration): Also print the value of
 105         SYSTEM_GDBINIT_DIR.
 106
 107 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 108
 109         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 110         that takes gdb::string_view arguments.
 111
 112 2019-10-26  Tom de Vries  <tdevries@suse.de>
 113
 114         * aarch64-linux-tdep.c: Fix typos in comments.
 115         * aarch64-tdep.c: Same.
 116         * ada-lang.c: Same.
 117         * amd64-nat.c: Same.
 118         * arc-tdep.c: Same.
 119         * arch/aarch64-insn.c: Same.
 120         * block.c: Same.
 121         * breakpoint.h: Same.
 122         * btrace.h: Same.
 123         * c-varobj.c: Same.
 124         * cli/cli-decode.c: Same.
 125         * cli/cli-script.c: Same.
 126         * cli/cli-utils.h: Same.
 127         * coff-pe-read.c: Same.
 128         * coffread.c: Same.
 129         * compile/compile-cplus-symbols.c: Same.
 130         * compile/compile-object-run.c: Same.
 131         * completer.c: Same.
 132         * corelow.c: Same.
 133         * cp-support.c: Same.
 134         * demangle.c: Same.
 135         * dwarf-index-write.c: Same.
 136         * dwarf2-frame.c: Same.
 137         * dwarf2-frame.h: Same.
 138         * eval.c: Same.
 139         * frame-base.h: Same.
 140         * frame.h: Same.
 141         * gdbcmd.h: Same.
 142         * gdbtypes.h: Same.
 143         * gnu-nat.c: Same.
 144         * guile/scm-objfile.c: Same.
 145         * i386-tdep.c: Same.
 146         * i386-tdep.h: Same.
 147         * infcall.c: Same.
 148         * infcall.h: Same.
 149         * linux-nat.c: Same.
 150         * m68k-tdep.c: Same.
 151         * macroexp.c: Same.
 152         * memattr.c: Same.
 153         * mi/mi-cmd-disas.c: Same.
 154         * mi/mi-getopt.h: Same.
 155         * mi/mi-main.c: Same.
 156         * minsyms.c: Same.
 157         * nat/aarch64-sve-linux-sigcontext.h: Same.
 158         * objfiles.h: Same.
 159         * ppc-linux-nat.c: Same.
 160         * ppc-linux-tdep.c: Same.
 161         * ppc-tdep.h: Same.
 162         * progspace.h: Same.
 163         * prologue-value.h: Same.
 164         * python/py-evtregistry.c: Same.
 165         * python/py-instruction.h: Same.
 166         * record-btrace.c: Same.
 167         * record-full.c: Same.
 168         * remote.c: Same.
 169         * rs6000-tdep.c: Same.
 170         * ser-tcp.c: Same.
 171         * sol-thread.c: Same.
 172         * sparc-sol2-tdep.c: Same.
 173         * sparc64-tdep.c: Same.
 174         * stabsread.c: Same.
 175         * symfile.c: Same.
 176         * symtab.h: Same.
 177         * target.c: Same.
 178         * tracepoint.c: Same.
 179         * tui/tui-data.h: Same.
 180         * tui/tui-io.c: Same.
 181         * tui/tui-win.c: Same.
 182         * tui/tui.c: Same.
 183         * unittests/rsp-low-selftests.c: Same.
 184         * user-regs.h: Same.
 185         * utils.c: Same.
 186         * utils.h: Same.
 187         * valarith.c: Same.
 188         * valops.c: Same.
 189         * valprint.c: Same.
 190         * valprint.h: Same.
 191         * value.c: Same.
 192         * value.h: Same.
 193         * varobj.c: Same.
 194         * x86-nat.h: Same.
 195         * xtensa-tdep.c: Same.
 196
 197 2019-10-25  Ali Tamur <tamur@google.com>
 198
 199         * charset.c (find_charset_names): Reflect API change.
 200
 201 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 202
 203         * symtab.c (struct demangled_name_entry): Change demangled name
 204         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 205         part of the struct anymore.
 206         (symbol_set_names): No longer obstack allocate + copy the demangled
 207         name, just store the allocated name from bfd.
 208
 209 2019-10-25  Tom Tromey  <tromey@adacore.com>
 210
 211         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 212         (bsearch_cie_cmp, add_cie): Remove.
 213         (find_cie): Reimplement.
 214         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 215         (dwarf2_build_frame_info): Update.
 216
 217 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 218
 219         PR gdb/25126
 220         * symfile.c (reread_symbols): Call forget_cached_source_info to
 221         clear the stale source cache.
 222
 223 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 224
 225         * configure: Regenerate.
 226         * configure.ac: Remove code that sets python_has_threads.
 227
 228 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 229
 230         * config.in: Regenerate.
 231         * configure: Regenerate.
 232         * configure.ac: Remove the code that uses sed to get the python
 233         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 234
 235 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 236
 237         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 238         error paths.
 239
 240 2019-10-23  Tom Tromey  <tom@tromey.com>
 241
 242         * arc-tdep.c: Remove ".." from include.
 243         * frv-tdep.c: Remove ".." from include.
 244         * lm32-tdep.c: Remove ".." from include.
 245         * microblaze-tdep.c: Remove ".." from include.
 246         * or1k-tdep.h: Remove ".." from include.
 247         * s12z-tdep.c: Remove ".." from include.
 248         * Makefile.in (OPCODES_CFLAGS): Add comment.
 249         (TOP_CFLAGS): New variable.
 250         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 251
 252 2019-10-23  Tom Tromey  <tom@tromey.com>
 253
 254         * Makefile.in (READLINE_DIR): Update.
 255
 256 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 257
 258         * infcall.c (call_function_by_hand_dummy): Fix the function
 259         comment.  And extract out a code section into...
 260         (reserve_stack_space): ...this new function.
 261
 262 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 263
 264         * infcall.c (value_arg_coerce): Remove an unused parameter.
 265         (call_function_by_hand_dummy): Update the call to
 266         'value_arg_coerce'.
 267
 268 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 269
 270         * infcall.c (call_function_by_hand_dummy): Refactor.
 271
 272 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 273
 274         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 275
 276 2019-10-23  Tom Tromey  <tom@tromey.com>
 277
 278         * configure: Rebuild.
 279         * configure.ac: Don't check for sigprocmask.
 280         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 281
 282 2019-10-23  Tom Tromey  <tom@tromey.com>
 283
 284         * configure: Rebuild.
 285         * acinclude.m4: Use m4_include, not sinclude.
 286
 287 2019-10-23  Tom de Vries  <tdevries@suse.de>
 288
 289         PR breakpoints/24687
 290         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 291
 292 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 293
 294         * symtab.c (struct demangled_name_entry) <language>: Change from
 295         bitfield to regular variable.
 296
 297 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 298
 299         * symtab.c (struct demangled_name_entry): Add a constructor.
 300         (free_demangled_name_entry): New function to call the destructor
 301         for demangled_name_entry.
 302         (create_demangled_names_hash): Pass free_demangled_name_entry to
 303         htab_create_alloc.
 304         (symbol_set_names): Call placement new for demangled_name_entry.
 305         * utils.c: No longer include xxhash.h here, now that fast_hash
 306         is inlined in the header.
 307         * utils.h: Instead, include it here.
 308
 309 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 310
 311         * Makefile.in: Link with libxxhash.
 312         * config.in: Regenerate.
 313         * configure: Regenerate.
 314         * configure.ac: Search for libxxhash.
 315         * utils.c (fast_hash): Use xxhash if present.
 316
 317 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 318
 319         * utils.h (fast_hash): New function.
 320         * symtab.c (hash_demangled_name_entry): Call new function
 321         fast_hash.
 322
 323 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 324
 325         * symtab.c (struct demangled_name_entry): Change type of mangled
 326         to gdb::string_view. Also adds a constructor that takes the
 327         mangled name.
 328         (hash_demangled_name_entry): Update.
 329         (eq_demangled_name_entry): Update.
 330         (free_demangled_name_entry): New function to call the destructor
 331         now that this is not a POD anymore.
 332         (create_demangled_names_hash): Pass free_demangled_name_entry to
 333         htab_create_alloc.
 334         (symbol_set_names): Update.
 335
 336 2019-10-21  Ali Tamur  <tamu@google.com>
 337
 338         * dwarf2read.c (dir_index): Change type.
 339         (file_name_index): Likewise.
 340         (line_header::include_dir_at): Change comment and implementation on
 341         whether it is DWARF 5.
 342         (line_header::is_valid_file_index): New function.
 343         (line_header::file_name_at): Change comment and implementation on
 344         whether it is DWARF 5.
 345         (line_header::file_names): Change to private field renamed as
 346         m_file_names and introduce a new accessor method.
 347         (line_header::file_names_size): New method.
 348         (line_header::include_dirs): Change to private field and rename as
 349         m_include_dirs.
 350         (dw2_get_file_names_reader): Define local var at a smaller scope and
 351         reflect API change.
 352         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 353         (process_structure_scope): Likewise.
 354         (line_header::add_include_dir): Change message and reflect renaming.
 355         (line_header::add_file_name): Likewise.
 356         (read_formatted_entries): Handle DW_FORM_data16.
 357         (dwarf_decode_line_header): Fix line header length calculation.
 358         (psymtab_include_file_name): Change comment and API.
 359         (lnp_state_machine::m_file): Update comment and reflect type change.
 360         (lnp_state_machine::record_line): Reflect type change.
 361         (dwarf_decode_lines): Reflect API change.
 362         (file_file_name): Likewise.
 363         (file_full_name): Likewise.
 364
 365 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 366
 367         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 368
 369 2019-10-21  Tom Tromey  <tom@tromey.com>
 370
 371         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 372
 373 2019-10-21  Tom Tromey  <tom@tromey.com>
 374
 375         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 376         NM_H.   Use AC_CONFIG_LINKS.
 377         * configure: Rebuild.
 378         * Makefile.in (NM_H): New variable.
 379         (generated_files): Add NM_H.  Remove gcore.
 380         (nm.h, stamp-nmh): New targets.
 381
 382 2019-10-20  Tom Tromey  <tom@tromey.com>
 383
 384         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 385         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 386         obsolete comment.
 387         (put_objfile_before): Now static.
 388
 389 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 390
 391         * gdbsupport/common-utils.h (startswith): Change return type to
 392         bool.
 393
 394 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 395
 396         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 397         * breakpoint.c (bp_locations_compare): Rename to...
 398         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 399         (update_global_location_list): Use std::sort instead of qsort.
 400         * buildsym.c (compare_line_numbers): Rename to...
 401         (lte_is_less_than): ...this, and change to std::sort semantics.
 402         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 403         instead of qsort.
 404         * disasm.c (compare_lines): Rename to...
 405         (line_is_less_than): ...this, and change to std::sort semantics.
 406         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 407         of qsort.
 408         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 409         (fde_is_less_than): ...this, and change to std::sort semantics.
 410         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 411         * mdebugread.c (compare_blocks):
 412         (block_is_less_than): ...this, and change to std::sort semantics.
 413         (sort_blocks): Call std::sort instead of qsort.
 414         * objfiles.c (qsort_cmp): Rename to...
 415         (sort_cmp): ...this, and change to std::sort semantics.
 416         (update_section_map): Call std::sort instead of qsort.
 417         * remote.c (compare_pnums): Remove.
 418         (map_regcache_remote_table): Call std::sort instead of qsort.
 419         * utils.c (compare_positive_ints): Remove.
 420         * utils.h (compare_positive_ints): Remove.
 421         * xcoffread.c (compare_lte): Remove.
 422         (arrange_linetable): Call std::sort instead of qsort.
 423
 424 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 425
 426         * symfile.c (init_entry_point_info): Fix typo.
 427         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 428
 429 2019-10-18  Tom de Vries  <tdevries@suse.de>
 430
 431         * aarch64-tdep.c: Fix typos in comments.
 432         * ada-lang.c: Same.
 433         * ada-tasks.c: Same.
 434         * alpha-tdep.c: Same.
 435         * alpha-tdep.h: Same.
 436         * amd64-nat.c: Same.
 437         * amd64-windows-tdep.c: Same.
 438         * arc-tdep.c: Same.
 439         * arc-tdep.h: Same.
 440         * arch-utils.c: Same.
 441         * arm-nbsd-tdep.c: Same.
 442         * arm-tdep.c: Same.
 443         * ax-gdb.c: Same.
 444         * blockframe.c: Same.
 445         * btrace.c: Same.
 446         * c-varobj.c: Same.
 447         * coff-pe-read.c: Same.
 448         * coffread.c: Same.
 449         * cris-tdep.c: Same.
 450         * darwin-nat.c: Same.
 451         * dbxread.c: Same.
 452         * dcache.c: Same.
 453         * disasm.c: Same.
 454         * dtrace-probe.c: Same.
 455         * dwarf-index-write.c: Same.
 456         * dwarf2-frame-tailcall.c: Same.
 457         * dwarf2-frame.c: Same.
 458         * dwarf2read.c: Same.
 459         * eval.c: Same.
 460         * exceptions.c: Same.
 461         * fbsd-tdep.c: Same.
 462         * findvar.c: Same.
 463         * frame.c: Same.
 464         * frv-tdep.c: Same.
 465         * gnu-v3-abi.c: Same.
 466         * go32-nat.c: Same.
 467         * h8300-tdep.c: Same.
 468         * hppa-tdep.c: Same.
 469         * i386-linux-tdep.c: Same.
 470         * i386-tdep.c: Same.
 471         * ia64-libunwind-tdep.c: Same.
 472         * ia64-tdep.c: Same.
 473         * infcmd.c: Same.
 474         * infrun.c: Same.
 475         * linespec.c: Same.
 476         * linux-nat.c: Same.
 477         * linux-thread-db.c: Same.
 478         * machoread.c: Same.
 479         * mdebugread.c: Same.
 480         * mep-tdep.c: Same.
 481         * mn10300-tdep.c: Same.
 482         * namespace.c: Same.
 483         * objfiles.c: Same.
 484         * opencl-lang.c: Same.
 485         * or1k-tdep.c: Same.
 486         * osabi.c: Same.
 487         * ppc-linux-nat.c: Same.
 488         * ppc-linux-tdep.c: Same.
 489         * ppc-sysv-tdep.c: Same.
 490         * printcmd.c: Same.
 491         * procfs.c: Same.
 492         * record-btrace.c: Same.
 493         * record-full.c: Same.
 494         * remote-fileio.c: Same.
 495         * remote.c: Same.
 496         * rs6000-tdep.c: Same.
 497         * s12z-tdep.c: Same.
 498         * score-tdep.c: Same.
 499         * ser-base.c: Same.
 500         * ser-go32.c: Same.
 501         * skip.c: Same.
 502         * sol-thread.c: Same.
 503         * solib-svr4.c: Same.
 504         * solib.c: Same.
 505         * source.c: Same.
 506         * sparc-nat.c: Same.
 507         * sparc-sol2-tdep.c: Same.
 508         * sparc-tdep.c: Same.
 509         * sparc64-tdep.c: Same.
 510         * stabsread.c: Same.
 511         * stack.c: Same.
 512         * symfile.c: Same.
 513         * symtab.c: Same.
 514         * target-descriptions.c: Same.
 515         * target-float.c: Same.
 516         * thread.c: Same.
 517         * utils.c: Same.
 518         * valops.c: Same.
 519         * valprint.c: Same.
 520         * value.c: Same.
 521         * varobj.c: Same.
 522         * windows-nat.c: Same.
 523         * xcoffread.c: Same.
 524         * xstormy16-tdep.c: Same.
 525         * xtensa-tdep.c: Same.
 526
 527 2019-10-17  Tom Tromey  <tromey@adacore.com>
 528
 529         * configure: Rebuild.
 530         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 531         in AC_CONFIG_FILES invocation.
 532         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 533         new-style config.status invocation.
 534
 535 2019-10-17  Tom de Vries  <tdevries@suse.de>
 536
 537         * arm-nbsd-nat.c: Fix typos in comments.
 538         * arm-tdep.c: Same.
 539         * darwin-nat-info.c: Same.
 540         * dwarf2read.c: Same.
 541         * elfread.c: Same.
 542         * event-top.c: Same.
 543         * findvar.c: Same.
 544         * gdbtypes.c: Same.
 545         * hppa-tdep.c: Same.
 546         * i386-tdep.c: Same.
 547         * jit.c: Same.
 548         * main.c: Same.
 549         * mdebugread.c: Same.
 550         * moxie-tdep.c: Same.
 551         * nto-procfs.c: Same.
 552         * osabi.c: Same.
 553         * ppc-linux-tdep.c: Same.
 554         * remote.c: Same.
 555         * riscv-tdep.c: Same.
 556         * s390-tdep.c: Same.
 557         * sh-tdep.c: Same.
 558         * sparc-linux-tdep.c: Same.
 559         * sparc-nat.c: Same.
 560         * stack.c: Same.
 561         * target-descriptions.c: Same.
 562         * top.c: Same.
 563         * varobj.c: Same.
 564
 565 2019-10-16  Tom Tromey  <tom@tromey.com>
 566
 567         * objfiles.h (struct objfile) <original_name>: Now const.
 568
 569 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 570
 571         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 572         pass on to sigsetjmp's second argument.
 573         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 574
 575 2019-10-16  Keith Seitz  <keiths@redhat.com>
 576
 577         PR gdb/23567
 578         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 579         sections whose size is greater than the file size.
 580
 581 2019-10-16  Jim Wilson  <jimw@sifive.com>
 582
 583         * riscv-tdep.c (riscv_gcc_target_options): New.
 584         (riscv_gnu_triplet_regexp): New.
 585         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 586         set_gdbarch_gnu_triplet_regexp.
 587
 588 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 589
 590         * Makefile.in: Add xml-builtin.h.
 591         * features/feature_to_c.sh: Add an include for xml-builtin.h
 592         to ensure that the compiler checks that the types match.
 593         * xml-builtin.h: New file.
 594         * xml-support.c (fetch_xml_builtin): Add missing const.
 595         * xml-support.h: Remove declaration of xml_builtins.
 596
 597 2019-10-16  Tom de Vries  <tdevries@suse.de>
 598
 599         PR tdep/25096
 600         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 601         (amd64_classify_aggregate): ... here.
 602         (amd64_classify_aggregate_field): Handled fiels of nested structs
 603         recursively.
 604
 605 2019-10-16  Tom de Vries  <tdevries@suse.de>
 606
 607         PR tdep/24104
 608         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 609         that handles 'theclass'.
 610
 611 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 612
 613         * linespec.c (decode_digits_ordinary): Update comment.
 614         * make-target-delegates: No longer need to handle VEC case.
 615         * memrange.c (normalize_mem_ranges): Update comment.
 616         * namespace.c (add_using_directive): Update comment.
 617         * objc-lang.c (uniquify_strings): Update comment.
 618         * ppc-linux-nat.c (struct thread_points): Update comment.
 619         * probe.h (find_probes_in_objfile): Update comment.
 620         * target.h (enum flash_preserve_mode): Update comment.
 621         * varobj.c (varobj_restrict_range): Update comment.
 622         * varobj.h (varobj_list_children): Update comment.
 623
 624 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 625
 626         * Makefile.in: Remove references to vec.h and vec.c.
 627         * aarch64-tdep.c: No longer include vec.h.
 628         * ada-lang.c: Likewise.
 629         * ada-lang.h: Likewise.
 630         * arm-tdep.c: Likewise.
 631         * ax.h: Likewise.
 632         * breakpoint.h: Likewise.
 633         * charset.c: Likewise.
 634         * cp-support.h: Likewise.
 635         * dtrace-probe.c: Likewise.
 636         * dwarf2read.c: Likewise.
 637         * extension.h: Likewise.
 638         * gdb_bfd.c: Likewise.
 639         * gdbsupport/gdb_vecs.h: Likewise.
 640         * gdbsupport/vec.c: Remove.
 641         * gdbsupport/vec.h: Remove.
 642         * gdbthread.h: Likewise.
 643         * guile/scm-type.c: Likewise.
 644         * inline-frame.c: Likewise.
 645         * machoread.c: Likewise.
 646         * memattr.c: Likewise.
 647         * memrange.h: Likewise.
 648         * namespace.h: Likewise.
 649         * nat/linux-btrace.h: Likewise.
 650         * osdata.c: Likewise.
 651         * parser-defs.h: Likewise.
 652         * progspace.h: Likewise.
 653         * python/py-type.c: Likewise.
 654         * record-btrace.c: Likewise.
 655         * rust-exp.y: Likewise.
 656         * solib-target.c: Likewise.
 657         * stap-probe.c: Likewise.
 658         * target-descriptions.c: Likewise.
 659         * target-memory.c: Likewise.
 660         * target.h: Likewise.
 661         * varobj.c: Likewise.
 662         * varobj.h: Likewise.
 663         * xml-support.h: Likewise.
 664
 665 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 666
 667         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 668         Update for new std::vector based implementation.
 669         (process_psymtab_comp_unit_reader): Likewise.
 670         (scan_partial_symbols): Likewise.
 671         (recursively_compute_inclusions): Likewise.
 672         (compute_compunit_symtab_includes): Likewise.
 673         (process_imported_unit_die): Likewise.
 674         (queue_and_load_dwo_tu): Likewise.
 675         (follow_die_sig_1): Likewise.
 676         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 677         (typedef dwarf2_per_cu_ptr): Remove.
 678         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 679         function.
 680         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 681         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 682         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 683         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 684         std::vector.
 685
 686 2019-10-15  Tom Tromey  <tromey@adacore.com>
 687
 688         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 689         TID.
 690
 691 2019-10-15  Tom Tromey  <tromey@adacore.com>
 692
 693         * windows-nat.c (windows_nat_target::fetch_registers)
 694         (windows_nat_target::store_registers): Rename "pid" to "tid".
 695
 696 2019-10-15  Tom Tromey  <tromey@adacore.com>
 697
 698         * gdbarch.h, gdbarch.c: Rebuild.
 699         * gdbarch.sh (gcc_target_options): Change return type to
 700         std::string.
 701         * compile/compile.c (get_args): Update.
 702         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 703         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 704         std::string.
 705         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 706         std::string.
 707         * arch-utils.c (default_gcc_target_options): Return std::string.
 708         * arch-utils.h (default_gcc_target_options): Return std::string.
 709         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 710
 711 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 712
 713         * breakpoint.c (breakpoint_chain): Make static.
 714         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 715         of accessing breakpoint_chain.
 716
 717 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 718
 719         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 720         to a gdb::function_view and return value to bool.
 721         * breakpoint.h (iterate_over_breakpoints): Likewise.
 722         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 723         (pop_dummy_frame): Update.
 724         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 725         (gdbscm_breakpoints): Update.
 726         * python/py-breakpoint.c (build_bp_list): Update.
 727         (gdbpy_breakpoints): Update.
 728         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 729         Update.
 730         (bpfinishpy_handle_stop): Update.
 731         (bpfinishpy_handle_exit): Update.
 732         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 733         (svr4_update_solib_event_breakpoints): Update.
 734
 735 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 736
 737         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 738         when unwrapping single-field structs.
 739
 740 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 741
 742         * dwarf2read.c: Remove includes.
 743
 744 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 745
 746         * ui-out.c (ui_out::call_do_message): Silence
 747         -Wformat-nonliteral warning.
 748
 749 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 750
 751         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 752         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 753         include: readline/tilde.h.
 754
 755 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 756
 757         * remote.c (remote_target::get_trace_status): Remove declaration of
 758         trace_regblock_size.
 759
 760 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 761
 762         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 763         (show_user): Remove declaration of cmdlist.
 764         * cli/cli-cmds.h (max_user_call_depth): Declare.
 765         * cli/cli-script.c (execute_user_command): Remove declaration
 766         of max_user_call_depth.
 767
 768 2019-10-11  Jim Wilson  <jimw@sifive.com>
 769
 770         * gdbsupport/print-utils.h (pulongest): Fix comment.
 771         (plongest): Likewise.
 772         (phex): Add missing comment, mention leading zeros.
 773         (phex_nz): Add mention of no leading zeros to comment.
 774
 775         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 776         plongest instead of unsigned long long cast.
 777
 778 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 779
 780         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 781         for external_editor_command and gdbtk_test.
 782
 783 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 784
 785         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 786         * varobj.c (varobjdebug): Move comment to...
 787         * varobj.h (varobjdebug): ...here, and declare.
 788
 789 2019-10-09  Tom Tromey  <tom@tromey.com>
 790
 791         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 792         erase_data_content.
 793
 794 2019-10-09  Tom Tromey  <tom@tromey.com>
 795
 796         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 797         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 798         * tui/tui-command.c (tui_cmd_window::resize)
 799         (tui_refresh_cmd_win): Update.
 800         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 801         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 802         * tui/tui-data.c (~tui_gen_win_info): Remove.
 803         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 804         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 805         (tui_redisplay_readline, tui_mld_flush)
 806         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 807         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 808         (tui_data_window::erase_data_content)
 809         (tui_data_item_window::rerender)
 810         (tui_data_item_window::refresh_window): Update.
 811         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 812         (box_win, tui_gen_win_info::make_window)
 813         (tui_gen_win_info::make_visible): Update.
 814         (tui_delete_win): Remove.
 815         * tui/tui-winsource.c
 816         (tui_source_window_base::do_erase_source_content): Update.
 817         (tui_show_source_line, tui_source_window_base::update_tab_width)
 818         (tui_source_window_base::update_exec_info): Update.
 819         * tui/tui-data.h (struct curses_deleter): New.
 820         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 821         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 822
 823 2019-10-09  Tom Tromey  <tom@tromey.com>
 824
 825         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 826
 827 2019-10-09  Tom Tromey  <tom@tromey.com>
 828
 829         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 830         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 831
 832 2019-10-09  Tom Tromey  <tom@tromey.com>
 833
 834         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 835         window height directly.
 836         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 837         declare.
 838         * tui/tui-layout.c (tui_default_win_height): Remove.
 839         (tui_default_win_viewport_height): Remove.
 840
 841 2019-10-09  Tom Tromey  <tom@tromey.com>
 842
 843         * tui/tui.h: Remove comments.
 844
 845 2019-10-09  Tom de Vries  <tdevries@suse.de>
 846
 847         * python/lib/gdb/printer/bound_registers.py: Use
 848         '^builtin_type_bound128' as regexp argument for
 849         add_builtin_pretty_printer.
 850
 851 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 852
 853         * guile/guile.c (guile_extension_script_ops): Remove forward
 854         declaration and mark as static.
 855         (guile_script_ops): Likewise.
 856         (extension_language_guile): Move further down in the file so
 857         it can reference the definitions for guile_{extension_,}script_ops.
 858
 859 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 860
 861         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 862         except SORTL, DFLTCC, and KDSA.
 863
 864 2019-10-08  Tom Tromey  <tromey@adacore.com>
 865
 866         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 867         (struct safe_symbol_file_add_args): Remove.
 868
 869 2019-10-08  Tom Tromey  <tromey@adacore.com>
 870
 871         * windows-nat.c: Don't include buildsym-legacy.h.
 872
 873 2019-10-08  Tom Tromey  <tromey@adacore.com>
 874
 875         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 876
 877 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 878
 879         * gdbtypes.c (overload_debug): Move comment to header.
 880         * gdbtypes.h (overload_debug): Declare.
 881         * valops.c: Remove declaration of overload_debug, instead
 882         include gdbtypes.h.
 883
 884 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 885
 886         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 887         through _().
 888         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 889         move comment...
 890         * language.h (lang_frame_mismatch_warn): ... here. Also add
 891         declaration.
 892         * top.c (lang_frame_mismatch_warn): Remove declaration.
 893         (check_frame_language_change): Pass lang_frame_mismatch_warn
 894         through _().
 895
 896 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 897
 898         * c-lang.h (vtbl_ptr_name): Declare.
 899         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 900         it from the header.
 901         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 902
 903 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 904
 905         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 906         gdb_static_assert.
 907
 908 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 909
 910         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 911         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 912         * ctfread.c: New file.
 913         * ctfread.h: New file.
 914         * elfread.c: Include ctfread.h.
 915         (struct elfinfo text_p): New member ctfsect.
 916         (elf_locate_sections): Mark CTF section.
 917         (elf_symfile_read): Call elfctf_build_psymtabs.
 918         * Makefile.in (LIBCTF): Add.
 919         (CLIBS): Use it.
 920         (CDEPS): Likewise.
 921         (DIST): Add ctfread.c.
 922
 923 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 924
 925         * ctfread.c (struct nextfield): Renamed to ...
 926         (struct ctf_nextfield): ... this.
 927         (struct field_info): Renamed to ...
 928         (strut ctf_field_info): ... this.
 929         (attach_fields_to_type): Update for renamed structures.
 930         (ctf_add_member_cb): Likewise.
 931         (ctf_add_enum_member_cb): Likewise.
 932         (process_struct_members): Likewise.
 933         (process_enum_type): Likewise.
 934
 935 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 936
 937         * tracectf.h: Rename, was ctf.h.
 938         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 939         * tracefile.c: Likewise.
 940         * tracepoint.c: Remove unused include ctf.h.
 941         * mi/mi-main.c: Likewise.
 942         * Makefile.in Replace ctf.c with tracectf.c.
 943
 944 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 945
 946         * version.in: Change version number to "9.0.50.DATE-git".
 947
 948 2019-10-03  Tom Tromey  <tom@tromey.com>
 949
 950         PR rust/24976:
 951         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 952
 953 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 954
 955         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 956         cp_search_name_hash.
 957         * NEWS: Add entry about nested function support.
 958
 959 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 960             Andrew Burgess  <andrew.burgess@embecosm.com>
 961
 962         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 963         for nested static variables when searchin VAR_DOMAIN.
 964         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 965         global scope, update comment.
 966         (add_partial_subprogram): Call add_partial_subprogram recursively
 967         for nested subroutines when processinng Fortran.
 968         (load_partial_dies): Process the child entities of a subprogram
 969         when processing Fortran.
 970         (partial_die_parent_scope): Handle building scope
 971         for Fortran nested functions.
 972         (process_die): Record that nested functions have a scope.
 973         (new_symbol): Always record Fortran subprograms on the global
 974         symbol list.
 975         (determine_prefix): How to build the prefix for Fortran
 976         subprograms.
 977
 978 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 979
 980         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 981         have just sent the thread a SIGSTOP and are waiting for it to
 982         arrive.
 983
 984 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 985
 986         * btrace.c (btrace_add_pc): Remove whitespace before the template
 987         parameter in 'std::vector <...>'.
 988         (parse_xml_btrace_block): Likewise.
 989         (btrace_maint_decode_pt): Likewise.
 990         (btrace_maint_update_packets): Likewise.
 991         (btrace_maint_print_packets): Likewise.
 992         * btrace.h (struct btrace_maint_info): Likewise.
 993         * dwarf2read.c (struct type_unit_group): Likewise.
 994         (build_type_psymtabs_reader): Likewise.
 995         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 996         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 997         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 998
 999 2019-10-03  Tom de Vries  <tdevries@suse.de>
1000
1001         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1002         the first line of the help text for set/show style metadata.
1003
1004 2019-10-02  Tom Tromey  <tromey@adacore.com>
1005
1006         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1007         * gdbsupport/common-inferior.c: New file.
1008         * infcmd.c (startup_with_shell): Don't define.
1009         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1010         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1011         * inferior.h (startup_with_shell): Don't declare.
1012
1013 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1014
1015         * gdbsupport/gdb_assert.h: Include errors.h.
1016         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1017
1018 2019-10-02  Tom Tromey  <tromey@adacore.com>
1019
1020         * NEWS: Add $_ada_exception entry.
1021         * ada-lang.c (struct ada_catchpoint): Add constructor.
1022         <m_kind>: New member.
1023         (allocate_location_exception, re_set_exception): Remove
1024         "ex" parameter.
1025         (should_stop_exception): Compute $_ada_exception.
1026         (check_status_exception, print_it_exception)
1027         (print_one_exception, print_mention_exception): Remove
1028         "ex" parameter.
1029         (allocate_location_catch_exception, re_set_catch_exception)
1030         (check_status_exception, print_it_catch_exception)
1031         (print_one_catch_exception, print_mention_catch_exception)
1032         (print_recreate_catch_exception)
1033         (allocate_location_catch_exception_unhandled)
1034         (re_set_catch_exception_unhandled)
1035         (check_status_exception, print_it_catch_exception_unhandled)
1036         (print_one_catch_exception_unhandled)
1037         (print_mention_catch_exception_unhandled)
1038         (print_recreate_catch_exception_unhandled)
1039         (allocate_location_catch_assert, re_set_catch_assert)
1040         (check_status_assert, print_it_catch_assert)
1041         (print_one_catch_assert, print_mention_catch_assert)
1042         (print_recreate_catch_assert)
1043         (allocate_location_catch_handlers, re_set_catch_handlers)
1044         (check_status_handlers, print_it_catch_handlers)
1045         (print_one_catch_handlers, print_mention_catch_handlers)
1046         (print_recreate_catch_handlers): Remove.
1047         (create_ada_exception_catchpoint): Update.
1048         (initialize_ada_catchpoint_ops): Update.
1049
1050 2019-10-02  Tom Tromey  <tromey@adacore.com>
1051
1052         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1053         (create_excep_cond_exprs): Simplify exception string computation.
1054         (ada_exception_catchpoint_cond_string): Likewise.
1055
1056 2019-10-02  Tom Tromey  <tromey@adacore.com>
1057
1058         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1059         * ada-lang.c (lesseq_defined_than): Handle
1060         LOC_STATIC.
1061         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1062         parameter.
1063         (dwarf2_has_info): Likewise.
1064         (new_symbol): Set maybe_copied on symbol when
1065         appropriate.
1066         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1067         parameter.
1068         <can_copy>: New member.
1069         * elfread.c (record_minimal_symbol): Set maybe_copied
1070         on symbol when appropriate.
1071         (elf_symfile_read): Update call to dwarf2_has_info.
1072         * minsyms.c (lookup_minimal_symbol_linkage): New
1073         function.
1074         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1075         * symtab.c (get_symbol_address, get_msymbol_address):
1076         New functions.
1077         * symtab.h (get_symbol_address, get_msymbol_address):
1078         Declare.
1079         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1080         maybe_copied.
1081         (struct symbol, struct minimal_symbol) <maybe_copied>:
1082         New member.
1083
1084 2019-10-02  Tom Tromey  <tromey@adacore.com>
1085
1086         * source.c (struct current_source_location): New.
1087         (current_source_key): New global.
1088         (current_source_symtab, current_source_line)
1089         (current_source_pspace): Remove.
1090         (get_source_location): New function.
1091         (get_current_source_symtab_and_line)
1092         (set_default_source_symtab_and_line)
1093         (set_current_source_symtab_and_line)
1094         (clear_current_source_symtab_and_line, select_source_symtab)
1095         (info_source_command, print_source_lines_base)
1096         (info_line_command, search_command_helper, _initialize_source):
1097         Update.
1098
1099 2019-10-02  Tom Tromey  <tromey@adacore.com>
1100
1101         * source.c (select_source_symtab): Don't call
1102         decode_line_with_current_source.
1103
1104 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1105
1106         * symtab.c (lookup_global_symbol): Search global block.
1107
1108 2019-10-02  Tom Tromey  <tromey@adacore.com>
1109
1110         * coffread.c (process_coff_symbol): Update.
1111         * dwarf2read.c (var_decode_location, new_symbol): Update.
1112         * mdebugread.c (parse_symbol): Update.
1113         * objfiles.c (relocate_one_symbol): Update.
1114         * stabsread.c (define_symbol, fix_common_block)
1115         (scan_file_globals): Update.
1116         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1117         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1118         * xcoffread.c (process_xcoff_symbol): Update.
1119
1120 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1121
1122         * MAINTAINERS: Update my email address.
1123
1124 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1125
1126         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1127         std::vector.
1128         (build_type_psymtabs_reader): Update for std::vector.
1129         (build_type_psymtab_dependencies): Likewise.
1130         * dwarf2read.h: Remove use of DEF_VEC_P.
1131         (typedef sig_type_ptr): Delete.
1132
1133 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1134
1135         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1136         to std::vector.
1137         (btrace_maint_decode_pt): Likewise, and move allocation of the
1138         vector outside of the loop.
1139         (btrace_maint_update_packets): Update to handle change from VEC to
1140         std::vector.
1141         (btrace_maint_print_packets): Likewise.
1142         (maint_info_btrace_cmd): Likewise.
1143         * btrace.h: Remove use of DEF_VEC_O.
1144         (typedef btrace_pt_packet_s): Delete.
1145         (struct btrace_maint_info) <packets>: Change fromm VEC to
1146         std::vector.
1147         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1148
1149 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1150
1151         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1152         make accesses into the vector constant references.
1153         (btrace_add_pc): Update for std::vector.
1154         (btrace_stitch_bts): Likewise.
1155         (parse_xml_btrace_block): Likewise.
1156         (btrace_maint_update_packets): Likewise.
1157         (btrace_maint_print_packets): Likewise.
1158         (maint_info_btrace_cmd): Likewise.
1159         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1160         std::vector.
1161         (btrace_data::empty): Likewise.
1162         (btrace_data_append): Likewise.
1163         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1164         (typedef btrace_block_s): Delete.
1165         (struct btrace_block): Add constructor.
1166         (struct btrace_data_bts) <blocks>: Change to std::vector.
1167         * nat/linux-btrace.c (perf_event_read_bts): Update for
1168         std::vector.
1169         (linux_read_bts): Likewise.
1170
1171 2019-10-01  Tom Tromey  <tom@tromey.com>
1172
1173         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1174
1175 2019-10-01  Tom Tromey  <tom@tromey.com>
1176
1177         * stack.c (print_frame, info_frame_command_core): Use
1178         styled_string.
1179         * linux-thread-db.c (try_thread_db_load_1)
1180         (try_thread_db_load_from_pdir_1): Use styled_string.
1181         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1182         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1183         (maybe_print_unsupported_script_warning)
1184         (maybe_print_script_not_found_warning): Use styled_string.
1185         * ada-lang.c (user_select_syms): Use styled_string.
1186
1187 2019-10-01  Tom Tromey  <tom@tromey.com>
1188
1189         * p-lang.c (pascal_printstr): Use metadata style.
1190         * value.c (show_convenience): Use metadata style.
1191         * valprint.c (valprint_check_validity, val_print_optimized_out)
1192         (val_print_not_saved, val_print_unavailable)
1193         (val_print_invalid_address, generic_val_print, val_print)
1194         (value_check_printable, val_print_array_elements): Use metadata
1195         style.
1196         * ui-out.h (class ui_out) <field_fmt>: New overload.
1197         <do_field_fmt>: Add style parameter.
1198         * ui-out.c (ui_out::field_fmt): New overload.
1199         * typeprint.c (type_print_unknown_return_type)
1200         (val_print_not_allocated, val_print_not_associated): Use metadata
1201         style.
1202         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1203         parameter.
1204         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1205         * tracepoint.c (tvariables_info_1): Use metadata style.
1206         * stack.c (print_frame_arg, print_frame_info, print_frame)
1207         (info_frame_command_core): Use metadata style.
1208         * skip.c (info_skip_command): Use metadata style.
1209         * rust-lang.c (rust_print_enum): Use metadata style.
1210         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1211         metadata style.
1212         * python/py-framefilter.c (py_print_single_arg): Use metadata
1213         style.
1214         * printcmd.c (do_one_display, print_variable_and_value): Use
1215         metadata style.
1216         * p-valprint.c (pascal_val_print)
1217         (pascal_object_print_value_fields): Use metadata style.
1218         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1219         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1220         parameter.
1221         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1222         * m2-valprint.c (m2_print_long_set): Use metadata style.
1223         * m2-typeprint.c (m2_print_type): Use metadata style.
1224         * infcmd.c (print_return_value_1): Use metadata style.
1225         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1226         * f-valprint.c (info_common_command_for_block): Use metadata
1227         style.
1228         * f-typeprint.c (f_type_print_base): Use metadata style.
1229         * expprint.c (print_subexp_standard): Use metadata style.
1230         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1231         * cli/cli-style.h (class cli_style_option): Add constructor.
1232         (metadata_style): Declare.
1233         * cli/cli-style.c (metadata_style): New global.
1234         (_initialize_cli_style): Register metadata style.
1235         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1236         parameter.
1237         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1238         * c-typeprint.c (c_type_print_base_struct_union)
1239         (c_type_print_base_1): Use metadata style.
1240         * breakpoint.c (watchpoint_value_print)
1241         (print_one_breakpoint_location): Use metadata style.
1242         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1243         style.
1244         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1245         style.
1246         * ada-valprint.c (val_print_packed_array_elements, printstr)
1247         (print_field_values, ada_val_print_ref, ada_val_print): Use
1248         metadata style.
1249         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1250         style.
1251         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1252         style.
1253         * ada-lang.c (user_select_syms): Use metadata style.
1254
1255 2019-10-01  Tom Tromey  <tom@tromey.com>
1256
1257         * cli/cli-cmds.c (pwd_command): Style output.
1258
1259 2019-10-01  Pedro Alves  <palves@redhat.com>
1260             Tom Tromey  <tom@tromey.com>
1261
1262         * symtab.c (print_symbol_info): Use %ps.
1263         (print_msymbol_info): Use %ps.
1264         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1265         * printcmd.c (print_variable_and_value): Use %ps.
1266         * macrocmd.c (show_pp_source_pos): Use %ps.
1267         * infrun.c (print_exited_reason): Use ui_out::message.
1268         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1269         (describe_other_breakpoints): Use ui_out::message and new
1270         formats.
1271         (say_where): Use new formats.
1272         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1273         and new formats.
1274
1275 2019-10-01  Pedro Alves  <palves@redhat.com>
1276             Tom Tromey  <tom@tromey.com>
1277
1278         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1279         (test_gdb_formats): New function.
1280         (run_tests): Call it.
1281         (test_format_specifier): Update.
1282         * utils.h (fputs_filtered): Update comment.
1283         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1284         (fputs_styled_unfiltered): Declare.
1285         * utils.c (fputs_styled_unfiltered): New function.
1286         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1287         (vfprintf_filtered): Update.
1288         (vfprintf_unfiltered, vprintf_filtered): Update.
1289         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1290         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1291         disallow_ui_out_field>: New constants.
1292         (enum class field_kind): New.
1293         (struct base_field_s, struct signed_field_s): New.
1294         (signed_field): New function.
1295         (struct string_field_s): New.
1296         (string_field): New function.
1297         (struct styled_string_s): New.
1298         (styled_string): New function.
1299         (class ui_out) <message>: Add comment.
1300         <vmessage, call_do_message>: New methods.
1301         <do_message>: Add style parameter.
1302         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1303         methods.
1304         (ui_out::message): Rewrite.
1305         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1306         parameter.
1307         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1308         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1309         gdb_extensions parameter.
1310         (class format_piece): Add parameter to constructor.
1311         (n_int_args): New field.
1312         * gdbsupport/format.c (format_pieces::format_pieces): Add
1313         gdb_extensions parameter.  Handle '*'.
1314         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1315         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1316         vfprintf_styled_no_gdbfmt.
1317         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1318         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1319         unfiltered output.
1320         * ui-style.h (struct ui_file_style) <ptr>: New method.
1321
1322 2019-10-01  Tom Tromey  <tom@tromey.com>
1323
1324         * unittests/format_pieces-selftests.c: Update.  Add final format.
1325         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1326         empty literal pieces.
1327
1328 2019-10-01  Tom Tromey  <tom@tromey.com>
1329
1330         * ui-out.h (enum class ui_out_style_kind): Remove.
1331         (class ui_out) <field_string, field_stsream, do_field_string>:
1332         Change type of "style".
1333         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1334         (ui_out::field_string): Update.
1335         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1336         of "style".
1337         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1338         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1339         * stack.c (print_frame_arg, print_frame_info, print_frame):
1340         Update.
1341         * source.c (print_source_lines_base): Update.
1342         * solib.c (info_sharedlibrary_command): Update.
1343         * skip.c (info_skip_command): Update.
1344         * record-btrace.c (btrace_call_history_src_line)
1345         (btrace_call_history): Update.
1346         * python/py-framefilter.c (py_print_frame): Update.
1347         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1348         "style".
1349         * mi/mi-out.c (mi_ui_out::do_table_header)
1350         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1351         (mi_ui_out::do_field_string): Update.
1352         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1353         Update.
1354         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1355         "style".
1356         * cli-out.c (cli_ui_out::do_table_header)
1357         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1358         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1359         (cli_ui_out::do_field_fmt): Update.
1360         * breakpoint.c (print_breakpoint_location): Update.
1361         (update_static_tracepoint): Update.
1362
1363 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1364
1365         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1366         conversion of gdb_datadir.
1367         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1368         remove not needed c_str ().
1369
1370 2019-09-30  Ali Tamur <tamur@google.com>
1371
1372         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1373         (dwarf2_string_attr): Likewise.
1374
1375 2019-09-30  Ali Tamur <tamur@google.com>
1376
1377         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1378         (process_full_type_unit): Likewise.
1379         (dump_die_shallow): Likewise.
1380         (cu_debug_loc_section): Likewise.
1381
1382 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1383
1384         * minsyms.c (compare_minimal_symbols): Rename to...
1385         (minimal_symbol_is_less_than): ...this, and adjust to STL
1386         conventions (return bool, take arguments as references)
1387         (minimal_symbol_reader::install): Call std::sort instead
1388         of qsort.
1389
1390 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1391
1392         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1393         hash and why.
1394         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1395         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1396
1397 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1398
1399         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1400         * psympriv.h (add_psymbol_to_list): Move comment here and update
1401         it.
1402
1403 2019-09-29  Tom de Vries  <tdevries@suse.de>
1404
1405         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1406         Use $tmpdir/$(basename "$output_file").dwz instead of
1407         "${output_file}.dwz".
1408
1409 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1410
1411         PR gdb/25045
1412         * hppa-linux-nat.c: Include gdbarch.h.
1413
1414 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1415
1416         * blockframe.c (find_pc_partial_function): Change return type to bool.
1417         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1418         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1419         (stub_gnu_ifunc_resolve_name): Likewise.
1420         * symtab.c (compare_filenames_for_search): Likewise.
1421         (compare_glob_filenames_for_search): Likewise.
1422         (matching_obj_sections): Likewise.
1423         (symbol_matches_domain): Likewise.
1424         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1425         (find_line_pc): Change return type to bool.
1426         (find_line_pc_range): Likewise.
1427         (producer_is_realview): Likewise.
1428         * symtab.h (symbol_matches_domain): Likewise.
1429         (find_pc_partial_function): Likewise.
1430         (find_pc_line_pc_range): Likewise.
1431         (in_gnu_ifunc_stub): Likewise.
1432         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1433         (find_line_pc): Likewise.
1434         (find_line_pc_range): Likewise.
1435         (matching_obj_sections): Likewise.
1436         (find_line_symtab): Change out parameter to bool.
1437         (producer_is_realview): Change return type to bool.
1438         (compare_filenames_for_search): Likewise.
1439         (compare_glob_filenames_for_search): Likewise.
1440
1441 2019-09-26  Tom Tromey  <tom@tromey.com>
1442
1443         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1444         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1445         * gdb_usleep.h: Remove.
1446         * gdb_usleep.c: Remove.
1447         * utils.c: Don't include gdb_usleep.h.
1448
1449 2019-09-26  Tom Tromey  <tromey@adacore.com>
1450
1451         * python/py-type.c (type_to_type_object): Call check_typedef
1452         for stub types.
1453
1454 2019-09-26  Tom Tromey  <tom@tromey.com>
1455
1456         * utils.h (initialize_utils): Don't declare.
1457         * top.c (gdb_init): Don't call initialize_utils.
1458         * utils.c (initialize_utils): Remove.  Move contents...
1459         (_initialize_utils): ... here.
1460
1461 2019-09-25  Tom Tromey  <tom@tromey.com>
1462
1463         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1464         * utils.h (make_hex_string): Don't declare.
1465         * utils.c (make_hex_string): Remove.
1466
1467 2019-09-24  Tom de Vries  <tdevries@suse.de>
1468
1469         PR gdb/23815
1470         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1471         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1472
1473 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1474
1475         * NEWS: Mention new simulator port for PRU.
1476
1477 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1478
1479         * ada-exp.y (write_object_remaining): Update.
1480         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1481         and eliminate the static buffer.
1482         (ada_decode_symbol): Update.
1483         (ada_la_decode): Update.
1484         (ada_sniff_from_mangled_name): Update.
1485         (is_valid_name_for_wild_match): Update.
1486         (ada_lookup_name_info::matches): Update and simplify.
1487         (name_matches_regex): Update.
1488         (ada_add_global_exceptions): Update.
1489         * ada-lang.h (ada_decode): Update signature.
1490         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1491         * dwarf-index-write.c (debug_names::insert): Update.
1492
1493 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1494
1495         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1496         formatting.
1497
1498 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1499
1500         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1501         Change "nonzero" to "true" in documentation.
1502
1503 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1504
1505         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1506         (_initialize_darwin_solib): Don't set
1507         darwin_so_ops.lookup_lib_global_symbol.
1508         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1509         set_gdbarch_iterate_over_objfiles_in_search_order.
1510         (elf_lookup_lib_symbol): Rename to...
1511         (svr4_iterate_over_objfiles_in_search_order): this, and update
1512         to iterate semantics.
1513         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1514         * solib.c (solib_global_lookup): Remove.
1515         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1516         (solib_global_lookup): Remove.
1517         * symtab.c (lookup_global_or_static_symbol): Remove call to
1518         solib_global_lookup.
1519
1520 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1521
1522         * NEWS: Move entries about default MI version now being
1523         version 3, and about the GDB/MI fix for multi-location
1524         breakpoints to the "since GDB 8.3" section.
1525
1526 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1527
1528         GDB 8.3.1 released.
1529
1530 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1531
1532         * NEWS: Mention that Cell/B.E. debugging support was removed.
1533         * MAINTAINERS: Remove spu target.
1534
1535         * config/djgpp/fnchange.lst: Remove entries for removed files.
1536
1537         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1538         spu-multiarch.o, and spu-tdep.o.
1539         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1540         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1541         spu-multiarch.c, and spu-tdep.c.
1542         * spu-linux-nat.c: Remove file.
1543         * spu-multiarch.c: Remove file.
1544         * spu-tdep.c: Remove file.
1545         * spu-tdep.h: Remove file.
1546         * solib-spu.c: Remove file.
1547         * solib-spu.h: Remove file.
1548
1549         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1550         * configure.nat (spu-linux): Remove.
1551         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1552         solib-multiarch.o from gdb_target_obs.
1553         (spu*-*-*): Remove.
1554
1555         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1556         feature flag.
1557         (ppc_linux_no_features): Update.
1558         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1559         Cell/B.E. support.
1560         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1561         (tdesc_powerpc_cell64l): Likewise.
1562         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1563         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1564         Cell/B.E. support.
1565         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1566         Do not include "features/rs6000/powerpc-cell32l.c" or
1567         "features/rs6000/powerpc-cell64l.c".
1568         (ppc_linux_spu_section): Remove.
1569         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1570         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1571         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1572         (ppc_linux_spe_context_lookup): Remove.
1573         (ppc_linux_spe_context_inferior_created): Remove.
1574         (ppc_linux_spe_context_solib_loaded): Remove.
1575         (ppc_linux_spe_context_solib_unloaded): Remove.
1576         (ppc_linux_spe_context): Remove.
1577         (struct ppu2spu_cache): Remove.
1578         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1579         (struct ppu2spu_data): Remove.
1580         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1581         ppu2spu_unwind): Remove.
1582         (ppc_linux_init_abi): Remove Cell/B.E. support.
1583         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1584
1585         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1586         (rs6000/powerpc-cell64l-expedite): Likewise
1587         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1588         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1589         rs6000/powerpc-cell64l.xml.
1590         * features/rs6000/powerpc-cell32l.xml: Remove.
1591         * features/rs6000/powerpc-cell64l.xml: Likewise.
1592         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1593         * features/rs6000/powerpc-cell64l.c: Likewise.
1594         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1595         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1596         * regformats/reg-spu.dat: Remove.
1597
1598         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1599         * corelow.c (struct spuid_list): Remove.
1600         (add_to_spuid_list): Remove.
1601         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1602         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1603         (remote_protocol_features): Remove associated entries.
1604         (_initialize_remote): No longer initialize them.
1605         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1606         * linux-nat.c (SPUFS_MAGIC): Remove.
1607         (linux_proc_xfer_spu): Remove.
1608         (spu_enumerate_spu_ids): Remove.
1609         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1610         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1611         (linux_make_corefile_notes): No longer call it.
1612
1613         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1614         (cooked_write_test): Likewise.
1615
1616 2019-09-20  Tom Tromey  <tom@tromey.com>
1617
1618         * NEWS: Mention case-sensitivity of TUI commands.
1619         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1620         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1621         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1622
1623 2019-09-20  Tom Tromey  <tom@tromey.com>
1624
1625         * tui/tui-source.c (tui_source_window::set_contents): Use
1626         make_unique_xstrdup.
1627         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1628         make_unique_xstrdup.
1629
1630 2019-09-20  Tom Tromey  <tom@tromey.com>
1631
1632         * tui/tui-data.c: Remove separator comments.
1633         * tui/tui-layout.c: Remove separator comments.
1634         * tui/tui-win.c: Remove separator comments.
1635         * tui/tui-wingeneral.c: Remove separator comments.
1636
1637 2019-09-20  Tom Tromey  <tom@tromey.com>
1638
1639         * tui/tui.h (strcat_to_buf): Don't declare.
1640         * tui/tui.c (strcat_to_buf): Remove.
1641
1642 2019-09-20  Tom Tromey  <tom@tromey.com>
1643
1644         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1645         from "fullname".
1646         * tui/tui-source.c (tui_source_window::set_contents)
1647         (tui_source_window::location_matches_p)
1648         (tui_source_window::maybe_update): Update.
1649
1650 2019-09-20  Tom Tromey  <tom@tromey.com>
1651
1652         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1653         Update.
1654         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1655         prefix.
1656         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1657         (tui_data_window::line_from_reg_element_no)
1658         (tui_data_window::first_reg_element_no_inline)
1659         (tui_data_window::show_registers)
1660         (tui_data_window::show_register_group)
1661         (tui_data_window::display_registers_from)
1662         (tui_data_window::display_registers_from_line)
1663         (tui_data_window::first_data_item_displayed)
1664         (tui_data_window::delete_data_content_windows)
1665         (tui_data_window::erase_data_content)
1666         (tui_data_window::do_scroll_vertical)
1667         (tui_data_window::refresh_window)
1668         (tui_data_window::check_register_values): Update.
1669
1670 2019-09-20  Tom Tromey  <tom@tromey.com>
1671
1672         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1673         (struct tui_locator_window) <full_name, proc_name>: Now
1674         std::string.
1675         * tui/tui-stack.c (tui_locator_window::make_status_line)
1676         (tui_locator_window::set_locator_fullname)
1677         (tui_locator_window::set_locator_info): Update.
1678         * tui/tui-source.c (tui_source_window::set_contents)
1679         (tui_source_window::showing_source_p): Update.
1680
1681 2019-09-20  Tom Tromey  <tom@tromey.com>
1682
1683         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1684         Don't call tui_locator_win_info_ptr.
1685
1686 2019-09-20  Tom Tromey  <tom@tromey.com>
1687
1688         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1689
1690 2019-09-20  Tom Tromey  <tom@tromey.com>
1691
1692         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1693         height for locator.
1694         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1695         * tui/tui-layout.c (show_source_disasm_command, show_data)
1696         (show_source_or_disasm_and_command): Use 1 as height for locator.
1697
1698 2019-09-20  Tom Tromey  <tom@tromey.com>
1699
1700         * tui/tui.c (tui_enable): Update.
1701         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1702         Update.
1703         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1704         Update.
1705         * tui/tui-data.c (win_resized): Now bool.
1706         (tui_win_resized): Return bool.
1707         (tui_set_win_resized_to): Accept a bool.
1708
1709 2019-09-20  Tom Tromey  <tom@tromey.com>
1710
1711         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1712         Change type of "refresh_values_only".
1713         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1714         type of "refresh_values_only".
1715
1716 2019-09-20  Tom Tromey  <tom@tromey.com>
1717
1718         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1719         std::string.
1720         (tui_disassemble): Add "pos" parameter.
1721         (tui_disasm_window::set_contents): Simplify.
1722
1723 2019-09-20  Tom Tromey  <tom@tromey.com>
1724
1725         * tui/tui-winsource.h (struct tui_source_window_base)
1726         <show_source_content>: Now private.
1727         * tui/tui-winsource.c
1728         (tui_source_window_base::show_source_content): Don't handle empty
1729         content case.
1730
1731 2019-09-20  Tom Tromey  <tom@tromey.com>
1732
1733         * tui/tui-layout.c (show_source_disasm_command)
1734         (show_source_or_disasm_and_command): Don't call
1735         show_source_content.
1736
1737 2019-09-20  Tom Tromey  <tom@tromey.com>
1738
1739         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1740         Declare.
1741         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1742         from tui_make_status_line.
1743         (tui_locator_window::rerender): Update.
1744
1745 2019-09-20  Tom Tromey  <tom@tromey.com>
1746
1747         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1748         (tui_locator_window::rerender): Update.
1749
1750 2019-09-20  Tom Tromey  <tom@tromey.com>
1751
1752         * tui/tui-winsource.h (struct tui_source_window_base)
1753         <~tui_source_window_base>: Don't declare.
1754         <fullname>: Remove.
1755         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1756         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1757         member.
1758         * tui/tui-source.c (tui_source_window::set_contents): Update.
1759         (tui_source_window::location_matches_p)
1760         (tui_source_window::maybe_update): Update.
1761
1762 2019-09-20  Tom Tromey  <tom@tromey.com>
1763
1764         * tui/tui-winsource.h (~tui_source_element): Remove.
1765         (tui_source_element): Update.
1766         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1767         * tui/tui-winsource.c (tui_show_source_line): Update.
1768         * tui/tui-source.c (tui_source_window::set_contents): Update.
1769         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1770
1771 2019-09-20  Tom Tromey  <tom@tromey.com>
1772
1773         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1774         declare.
1775         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1776         tui_clear_source_windows_detail.
1777         * tui/tui-winsource.h (struct tui_source_window_base)
1778         <clear_detail>: Don't declare.
1779         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1780         Remove.
1781         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1782
1783 2019-09-20  Tom Tromey  <tromey@adacore.com>
1784
1785         PR ada/24919:
1786         * block.c (contained_in): Fix final return value.
1787
1788 2019-09-20  Alan Modra  <amodra@gmail.com>
1789
1790         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1791         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1792         (read_indirect_string_from_dwz): Use bfd accessor.
1793         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1794         * machoread.c (macho_symfile_read_all_oso): Likewise.
1795         * solib.c (solib_bfd_open): Likewise.
1796
1797 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1798
1799         * eval.c: Move declaration of overload_resolution to...
1800         * value.h: ...here.
1801
1802 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1803
1804         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1805         * arm-linux-tdep.c: Likewise.
1806         * arm-nbsd-nat.c: Likewise.
1807         * arm-tdep.h: Declare arm_apcs_32.
1808         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1809
1810 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1811
1812         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1813         * dwarf2read.h: Declare dwarf_always_disassemble.
1814
1815 2019-09-19  Tom de Vries  <tdevries@suse.de>
1816
1817         PR gdb/25009
1818         * source-cache.c (source_cache::ensure): Catch exception thrown during
1819         construction of the highlighter.
1820
1821 2019-09-18  Alan Modra  <amodra@gmail.com>
1822
1823         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1824         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1825         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1826         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1827         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1828         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1829         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1830         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1831         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1832         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1833         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1834         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1835         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1836         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1837         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1838         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1839         * mi/mi-interp.c: Update throughout for bfd section macro and
1840         function changes.
1841         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1842         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1843
1844 2019-09-18  Tom Tromey  <tom@tromey.com>
1845
1846         * NEWS: Add entry.
1847         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1848         call rl_initialize.
1849         (tui_enable): Do not call rl_initialize.
1850
1851 2019-09-18  Christian Groessler  <chris@groessler.org>
1852
1853         * alpha-linux-nat.c: Include gdbarch.h.
1854
1855 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1856
1857         * ui-file.c: Include cli/cli-style.h.
1858         (term_cli_styling): Remove cli_styling declaration.
1859
1860 2019-09-18  Alan Modra  <amodra@gmail.com>
1861
1862         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1863         to bfd_asymbol_section.
1864
1865 2019-09-18  Alan Modra  <amodra@gmail.com>
1866
1867         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1868         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1869         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1870
1871 2019-09-18  Alan Modra  <amodra@gmail.com>
1872
1873         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1874         * spu-linux-nat.c (spu_bfd_open): Likewise.
1875
1876 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1877
1878         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1879         to bool to match definition in dwarf2read.c.
1880
1881 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1882
1883         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1884         (print_signatures): Likewise.
1885         (trust_pad_over_xvs): Likewise.
1886         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1887         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1888         * arm-linux-nat.c (arm_apcs_32): Likewise.
1889         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1890         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1891         * arm-tdep.c (arm_debug): Likewise.
1892         (arm_apcs_32): Likewise.
1893         * auto-load.c (debug_auto_load): Likewise.
1894         (auto_load_gdb_scripts): Likewise.
1895         (global_auto_load): Likewise.
1896         (auto_load_local_gdbinit): Likewise.
1897         (auto_load_local_gdbinit_loaded): Likewise.
1898         * auto-load.h (global_auto_load): Likewise.
1899         (auto_load_local_gdbinit): Likewise.
1900         (auto_load_local_gdbinit_loaded): Likewise.
1901         * breakpoint.c (disconnected_dprintf): Likewise.
1902         (breakpoint_proceeded): Likewise.
1903         (automatic_hardware_breakpoints): Likewise.
1904         (always_inserted_mode): Likewise.
1905         (target_exact_watchpoints): Likewise.
1906         (_initialize_breakpoint): Update.
1907         * breakpoint.h (target_exact_watchpoints): Change to bool.
1908         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1909         * cli/cli-cmds.c (trace_commands): Likewise.
1910         * cli/cli-cmds.h (trace_commands): Likewise.
1911         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1912         to bool*.
1913         * cli/cli-logging.c (logging_overwrite): Change to bool.
1914         (logging_redirect): Likewise.
1915         (debug_redirect): Likewise.
1916         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1917         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1918         to bool.
1919         <boolean_option_def>: Update.
1920         (struct flag_option_def): Change default type of Context to bool
1921         from int.
1922         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1923         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1924         (get_setshow_command_value_string): Likewise.
1925         * cli/cli-style.c (cli_styling): Change to bool.
1926         (source_styling): Likewise.
1927         * cli/cli-style.h (source_styling): Likewise.
1928         (cli_styling): Likewise.
1929         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1930         to bool.
1931         * command.h (var_types): Update comment.
1932         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1933         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1934         bool.
1935         (debug_compile_cplus_scopes): Likewise.
1936         * compile/compile-internal.h (compile_debug): Likewise.
1937         * compile/compile.c (compile_debug): Likewise.
1938         (struct compile_options) <raw>: Likewise.
1939         * cp-support.c (catch_demangler_crashes): Likewise.
1940         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1941         (usr_cmd_cris_dwarf2_cfi): Likewise.
1942         * csky-tdep.c (csky_debug): Likewise.
1943         * darwin-nat.c (enable_mach_exceptions): Likewise.
1944         * dcache.c (dcache_enabled_p): Likewise.
1945         * defs.h (info_verbose): Likewise.
1946         * demangle.c (demangle): Likewise.
1947         (asm_demangle): Likewise.
1948         * dwarf-index-cache.c (debug_index_cache): Likewise.
1949         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1950         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1951         * dwarf2read.c (check_physname): Likewise.
1952         (use_deprecated_index_sections): Likewise.
1953         (dwarf_always_disassemble): Likewise.
1954         * eval.c (overload_resolution): Likewise.
1955         * event-top.c (set_editing_cmd_var): Likewise.
1956         (exec_done_display_p): Likewise.
1957         * event-top.h (set_editing_cmd_var): Likewise.
1958         (exec_done_display_p): Likewise.
1959         * exec.c (write_files): Likewise.
1960         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1961         (debug_fbsd_nat): Likewise.
1962         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1963         Likewise.
1964         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1965         <backtrace_past_entry> Likewise.
1966         * gdb-demangle.h (demangle): Likewise.
1967         (asm_demangle): Likewise.
1968         * gdb_bfd.c (bfd_sharing): Likewise.
1969         * gdbcore.h (write_files): Likewise.
1970         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1971         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1972         * gdbthread.h (print_thread_events): Likewise.
1973         * gdbtypes.c (opaque_type_resolution): Likewise.
1974         (strict_type_checking): Likewise.
1975         * gnu-nat.c (gnu_debug_flag): Likewise.
1976         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1977         * guile/scm-param.c (pascm_variable): Add boolval.
1978         (add_setshow_generic): Update.
1979         (pascm_param_value): Update.
1980         (pascm_set_param_value_x): Update.
1981         * hppa-tdep.c (hppa_debug): Change to bool..
1982         * infcall.c (may_call_functions_p): Likewise.
1983         (coerce_float_to_double_p): Likewise.
1984         (unwind_on_signal_p): Likewise.
1985         (unwind_on_terminating_exception_p): Likewise.
1986         * infcmd.c (startup_with_shell): Likewise.
1987         * inferior.c (print_inferior_events): Likewise.
1988         * inferior.h (startup_with_shell): Likewise.
1989         (print_inferior_events): Likewise.
1990         * infrun.c (step_stop_if_no_debug): Likewise.
1991         (detach_fork): Likewise.
1992         (debug_displaced): Likewise.
1993         (disable_randomization): Likewise.
1994         (non_stop): Likewise.
1995         (non_stop_1): Likewise.
1996         (observer_mode): Likewise.
1997         (observer_mode_1): Likewise.
1998         (set_observer_mode): Update.
1999         (sched_multi): Change to bool.
2000         * infrun.h (debug_displaced): Likewise.
2001         (sched_multi): Likewise.
2002         (step_stop_if_no_debug): Likewise.
2003         (non_stop): Likewise.
2004         (disable_randomization): Likewise.
2005         * linux-tdep.c (use_coredump_filter): Likewise.
2006         (dump_excluded_mappings): Likewise.
2007         * linux-thread-db.c (auto_load_thread_db): Likewise.
2008         (check_thread_db_on_load): Likewise.
2009         * main.c (captured_main_1): Update.
2010         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2011         xx2_opt, boolean_opt>: Change to bool.
2012         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2013         * maint.c (maintenance_profile_p): Likewise.
2014         (per_command_time): Likewise.
2015         (per_command_space): Likewise.
2016         (per_command_symtab): Likewise.
2017         * memattr.c (inaccessible_by_default): Likewise.
2018         * mi/mi-main.c (mi_async): Likewise.
2019         (mi_async_1): Likewise.
2020         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2021         * nat/fork-inferior.h (startup_with_shell): Likewise.
2022         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2023         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2024         * nios2-tdep.c (nios2_debug): Likewise.
2025         * or1k-tdep.c (or1k_debug): Likewise.
2026         * parse.c (parser_debug): Likewise.
2027         * parser-defs.h (parser_debug): Likewise.
2028         * printcmd.c (print_symbol_filename): Likewise.
2029         * proc-api.c (procfs_trace): Likewise.
2030         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2031         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2032         (set_parameter_value): Update.
2033         (add_setshow_generic): Update.
2034         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2035         to bool*.
2036         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2037         int*.
2038         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2039         * record-btrace.c (record_btrace_target::store_registers): Update.
2040         * record-full.c (record_full_memory_query): Change to bool.
2041         (record_full_stop_at_limit): Likewise.
2042         * record-full.h (record_full_memory_query): Likewise.
2043         * remote-notif.c (notif_debug): Likewise.
2044         * remote-notif.h (notif_debug): Likewise.
2045         * remote.c (use_range_stepping): Likewise.
2046         (interrupt_on_connect): Likewise.
2047         (remote_break): Likewise.
2048         * ser-tcp.c (tcp_auto_retry): Likewise.
2049         * ser-unix.c (serial_hwflow): Likewise.
2050         * skip.c (debug_skip): Likewise.
2051         * solib-aix.c (solib_aix_debug): Likewise.
2052         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2053         (spu_auto_flush_cache_p): Likewise.
2054         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2055         Likewise.
2056         (struct info_print_options) <quiet>: Likewise.
2057         * symfile-debug.c (debug_symfile): Likewise.
2058         * symfile.c (auto_solib_add): Likewise.
2059         (separate_debug_file_debug): Likewise.
2060         * symfile.h (auto_solib_add): Likewise.
2061         (separate_debug_file_debug): Likewise.
2062         * symtab.c (basenames_may_differ): Likewise.
2063         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2064         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2065         (struct info_types_options) <quiet>: Likewise.
2066         * symtab.h (demangle): Likewise.
2067         (basenames_may_differ): Likewise.
2068         * target-dcache.c (stack_cache_enabled_1): Likewise.
2069         (code_cache_enabled_1): Likewise.
2070         * target.c (trust_readonly): Likewise.
2071         (may_write_registers): Likewise.
2072         (may_write_memory): Likewise.
2073         (may_insert_breakpoints): Likewise.
2074         (may_insert_tracepoints): Likewise.
2075         (may_insert_fast_tracepoints): Likewise.
2076         (may_stop): Likewise.
2077         (auto_connect_native_target): Likewise.
2078         (target_stop_and_wait): Update.
2079         (target_async_permitted): Change to bool.
2080         (target_async_permitted_1): Likewise.
2081         (may_write_registers_1): Likewise.
2082         (may_write_memory_1): Likewise.
2083         (may_insert_breakpoints_1): Likewise.
2084         (may_insert_tracepoints_1): Likewise.
2085         (may_insert_fast_tracepoints_1): Likewise.
2086         (may_stop_1): Likewise.
2087         * target.h (target_async_permitted): Likewise.
2088         (may_write_registers): Likewise.
2089         (may_write_memory): Likewise.
2090         (may_insert_breakpoints): Likewise.
2091         (may_insert_tracepoints): Likewise.
2092         (may_insert_fast_tracepoints): Likewise.
2093         (may_stop): Likewise.
2094         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2095         (make_thread_apply_all_options_def_group): Change argument from int*
2096         to bool*.
2097         (thread_apply_all_command): Update.
2098         (print_thread_events): Change to bool.
2099         * top.c (confirm): Likewise.
2100         (command_editing_p): Likewise.
2101         (history_expansion_p): Likewise.
2102         (write_history_p): Likewise.
2103         (info_verbose): Likewise.
2104         * top.h (confirm): Likewise.
2105         (history_expansion_p): Likewise.
2106         * tracepoint.c (disconnected_tracing): Likewise.
2107         (circular_trace_buffer): Likewise.
2108         * typeprint.c (print_methods): Likewise.
2109         (print_typedefs): Likewise.
2110         * utils.c (debug_timestamp): Likewise.
2111         (sevenbit_strings): Likewise.
2112         (pagination_enabled): Likewise.
2113         * utils.h (sevenbit_strings): Likewise.
2114         (pagination_enabled): Likewise.
2115         * valops.c (overload_resolution): Likewise.
2116         * valprint.h (struct value_print_options) <prettyformat_arrays,
2117         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2118         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2119         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2120         Likewise.
2121         * windows-nat.c (new_console): Likewise.
2122         (cygwin_exceptions): Likewise.
2123         (new_group): Likewise.
2124         (debug_exec): Likewise.
2125         (debug_events): Likewise.
2126         (debug_memory): Likewise.
2127         (debug_exceptions): Likewise.
2128         (useshell): Likewise.
2129         * windows-tdep.c (maint_display_all_tib): Likewise.
2130         * xml-support.c (debug_xml): Likewise.
2131
2132 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2133
2134         * source.c (prepare_path_for_appending): New function.
2135         (openp): Make use of new function.
2136         (find_and_open_source): Search for the compilation directory and
2137         source file as a relative path beneath the directory search path.
2138
2139 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2140
2141         * source-cache.c (source_cache::get_line_charpos): Catch
2142         exceptions and return false, this matches the behaviour documented
2143         in the header file.
2144
2145 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2146
2147         * ada-tasks.c (info_task): Remove quoting of the task's name.
2148
2149 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2150
2151         * symfile.c (auto_solib_add): Replace comment with a reference
2152         to the header file.
2153
2154 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2155
2156         * NEWS: Mention that gdb can now be compiled with Python 3
2157         on Windows.
2158
2159 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2160
2161         * maint.c (maint_print_section_data::maint_print_section_data):
2162         Force use of 'float log10 (float)' by casting the argument to
2163         float.
2164
2165 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2166
2167         * maint.c: Add 'cmath' include.
2168         (struct maint_print_section_data): New structure.
2169         (print_section_index): New function.
2170         (print_bfd_section_info): Add header comment, small whitespace
2171         cleanup, and update to call new print_section_index function.
2172         (print_objfile_section_info): Likewise.
2173         (maint_obj_section_from_bfd_section): New function.
2174         (print_bfd_section_info_maybe_relocated): New function.
2175         (maintenance_info_sections): Add header comment, always use
2176         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2177
2178 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2179
2180         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2181         inner scope, add check that the objfile has psymtabs before
2182         checking psymtabs_addrmap.
2183         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2184
2185 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2186
2187         * NEWS: Announce that Ada task names are now shown at more places,
2188         and between quotes (except in info task output).
2189         * gdb/ada-tasks.c (task_to_str): New function.
2190         (display_current_task_id): Call task_to_str.
2191         (task_command_1): Likewise.
2192         (print_ada_task_info): In non-mi mode, Properly align headers and data
2193         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2194
2195 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2196
2197         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2198         prstatus.pr_lwp.pr_info instead of making it up.
2199
2200 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2201
2202         * auto-load.c (auto_load_expand_dir_vars): Update.
2203         * defs.h (gdb_datadir): Change to std::string.
2204         (python_libdir): Likewise.
2205         (relocate_gdb_directory): Change return type to std::string.
2206         * guile/guile.c (gdbscm_data_directory): Update.
2207         (initialize_scheme_side): Update.
2208         * jit.c (jit_reader_dir): Change to std::string.
2209         (jit_reader_load_command): Update.
2210         * main.c (gdb_datadir): Change to std::string.
2211         (python_libdir): Likewise.
2212         (set_gdb_data_directory): Update.
2213         (relocate_path): Change to return std::string.
2214         (relocate_gdb_directory): Change to return std::string.
2215         (relocate_gdbinit_path_maybe_in_datadir): Update.
2216         (captured_main_1): Update.
2217         * python/python.c (do_start_initialization): Update.
2218         * top.c (show_gdb_datadir): Update.
2219         * xml-syscall.c (xml_init_syscalls_info): Update.
2220         (init_syscalls_info): Update.
2221
2222 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2223
2224         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2225         out of get_init_files.
2226         (get_init_files): Update.
2227
2228 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2229
2230         * main.c (get_init_files): Change to use std::string.
2231         (captured_main_1): Update.
2232         (print_gdb_help): Update.
2233
2234 2019-09-11  Ali Tamur  <tamur@google.com>
2235
2236         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2237         implementation.
2238
2239 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2240
2241         * dbxread.c (read_dbx_symtab): Update.
2242         * dwarf2read.c (load_partial_dies): Update.
2243         * mdebugread.c (parse_partial_symbols): Update.
2244         (handle_psymbol_enumerators): Update.
2245         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2246         * psymtab.c (add_psymbol_to_bcache): Likewise.
2247         (add_psymbol_to_list): Likewise.
2248         * symtab.c (symbol_set_names): Likewise.
2249         * symtab.h (symbol_set_names): Likewise.
2250         * xcoffread.c (scan_xcoff_symtab): Update.
2251
2252 2019-09-11  Tom Tromey  <tom@tromey.com>
2253
2254         * symfile-mem.c (symbol_file_add_from_memory): Use
2255         bfd_set_filename.
2256         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2257         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2258
2259 2019-09-10  Tom Tromey  <tromey@adacore.com>
2260
2261         * dwarf-index-write.c (write_psymbols): Extend error message.
2262         (debug_names::insert): Add Ada code.
2263         (debug_names::write_psymbols): Remove Ada check.
2264         (debug_names) <m_string_obstack>: New member.
2265         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2266         (gdb_index_symbol_name_matcher::matches): Remove.
2267         (mapped_index_base::find_name_components_bounds): Add "lang"
2268         parameter.
2269         (mapped_index_base::build_name_components): Also split names
2270         according to Ada syntax.
2271         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2272         type of "match_callback".
2273         (check_match, check_find_bounds_finds)
2274         (dw2_expand_symtabs_matching): Update.
2275         (dw2_debug_names_iterator): Add new constructor.
2276         (dw2_debug_names_map_matching_symbols): New function.
2277         (dw2_debug_names_expand_symtabs_matching): Update.
2278         (dwarf2_debug_names_functions): Use
2279         dw2_debug_names_map_matching_symbols.
2280
2281 2019-09-10  Tom Tromey  <tromey@adacore.com>
2282
2283         * dwarf2read.c (dw2_get_file_names_reader): Add the
2284         CU's file name to the results.
2285
2286 2019-09-10  Tom Tromey  <tromey@adacore.com>
2287
2288         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2289         map_matching_symbols.  Update.
2290         * dwarf2read.c (dw2_map_matching_symbols): Update.
2291         * psymtab.c (match_partial_symbol): Change type; update.
2292         (psym_map_matching_symbols): Likewise.
2293         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2294         type; update.
2295         * symfile.h (struct quick_symbol_functions)
2296         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2297         Remove "match".
2298
2299 2019-09-10  Tom Tromey  <tromey@adacore.com>
2300
2301         * psymtab.c (map_block): Remove.
2302         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2303         * symtab.c (iterate_over_symbols_terminated): New function.
2304         * symtab.c (iterate_over_symbols_terminated): Declare.
2305
2306 2019-09-10  Tom Tromey  <tromey@adacore.com>
2307
2308         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2309         * language.h (struct language_defn) <la_iterate_over_symbols>:
2310         Return bool.
2311         * symtab.c (iterate_over_symbols): Return bool.
2312         * symtab.h (iterate_over_symbols): Return bool.
2313
2314 2019-09-10  Tom Tromey  <tromey@adacore.com>
2315
2316         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2317         (add_nonlocal_symbols): Update.
2318         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2319         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2320         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2321         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2322         Change type of "callback".  Remove "data".
2323
2324
2325 2019-09-09  Ali Tamur  <tamur@google.com>
2326
2327         * dwarf2read.c (comp_unit_head): Update comment.
2328         (dwarf2_dwo_name): New function declaration.
2329         (dwarf_unit_type_name): New function declaration.
2330         (read_comp_unit_head): Add support for new compilation units,
2331         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2332         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2333         (currently named as "signature") in their header. Also clarify error
2334         messages.
2335         (lookup_dwo_id): New function. Returns the dwo id of the given
2336         compile unit.
2337         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2338         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2339         functions.
2340         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2341         (dwarf2_dwo_name): Get the dwo name if present.
2342         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2343         purposes.
2344
2345 2019-09-09  Tom Tromey  <tom@tromey.com>
2346
2347         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2348
2349 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2350
2351         * python/python.c (do_start_initialization): Make progname_copy static,
2352         to avoid a leak report.
2353
2354 2019-09-08  Tom Tromey  <tom@tromey.com>
2355
2356         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2357
2358 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2359
2360         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2361         Change type to gdb::optional<block_enum>.
2362         (dw2_symtab_iter_init): Change block_index parameter type
2363         to gdb::optional<block_enum>.
2364         (dw2_lookup_symbol): Change block_index parameter
2365         type to block_enum.c
2366         (dw2_debug_names_lookup_symbol): Likewise.
2367         * psymtab.c (psym_lookup_symbol): Likewise.
2368         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2369         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2370         Likewise.
2371
2372 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2373
2374         * defs.h (relocate_gdb_directory): Change int to bool in
2375         signature and rename flag to relocatable.
2376         * main.c (relocate_path): Likewise.
2377         (relocate_gdb_directory): Likewise.
2378
2379 2019-09-06  Alan Modra  <amodra@gmail.com>
2380
2381         * coffread.c (coff_symfile_read): Constify filename variable.
2382         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2383         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2384         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2385         * solib.c (reload_shared_libraries_1): Likewise.
2386         * symfile.c (reread_symbols): Likewise.
2387         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2388         * solib-darwin.c (darwin_bfd_open): Likewise.
2389         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2390
2391 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2392
2393         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2394         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2395
2396 2019-09-03  Tom Tromey  <tromey@adacore.com>
2397
2398         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2399         types.
2400         (has_negatives): Unbias a range type bound.
2401         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2402         * gdbtypes.c (operator==): Handle new field.
2403         (create_range_type): Add "bias" parameter.
2404         (create_static_range_type, resolve_dynamic_range): Update.
2405         * gdbtypes.h (struct range_bounds) <bias>: New member.
2406         (create_range_type): Add bias parameter.
2407         * printcmd.c (print_scalar_formatted): Unbias range types.
2408         * value.c (unpack_long): Unbias range types.
2409         (pack_long): Bias range types.
2410
2411 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2412
2413         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2414         probe arguments.
2415
2416 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2417
2418         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2419         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2420         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2421         (compile_probe_arg): Likewise.
2422         * probe.h (get_argument_count): Likewise.
2423         * solib-svr4.c (solib_event_probe_action): Likewise.
2424         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2425
2426 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2427
2428         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2429         code to here...
2430         (svr4_create_solib_event_breakpoints): ...from here.
2431
2432 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2433
2434         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2435         suffix from warning message.
2436
2437 2019-08-30  Tom Tromey  <tom@tromey.com>
2438
2439         * tui/tui-winsource.h (struct tui_source_window_base)
2440         <refresh_all>: Don't declare.
2441         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2442         Remove.
2443         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2444         tui_show_locator_content.
2445         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2446         declare.
2447         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2448         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2449         declare.
2450
2451 2019-08-30  Tom Tromey  <tom@tromey.com>
2452
2453         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2454
2455 2019-08-30  Tom Tromey  <tom@tromey.com>
2456
2457         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2458         Remove unnecessary forward declarations.
2459
2460 2019-08-30  Tom Tromey  <tom@tromey.com>
2461
2462         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2463         rerender.
2464         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2465         tui_show_locator_content.
2466
2467 2019-08-30  Tom Tromey  <tom@tromey.com>
2468
2469         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2470         (tui_locator_window::rerender): Rewrite using body of previous
2471         tui_show_locator_content.
2472
2473 2019-08-30  Tom Tromey  <tom@tromey.com>
2474
2475         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2476         set_locator_fullname>: New methods.
2477         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2478         Rename from tui_set_locator_fullname.
2479         (tui_locator_window::set_locator_info): Rename from
2480         tui_set_locator_info.  Return bool.
2481         (tui_update_locator_fullname, tui_show_frame_info): Update.
2482
2483 2019-08-30  Tom Tromey  <tom@tromey.com>
2484
2485         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2486
2487 2019-08-30  Tom Tromey  <tom@tromey.com>
2488
2489         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2490         call touchwin.
2491
2492 2019-08-30  Tom Tromey  <tom@tromey.com>
2493
2494         * tui/tui-wingeneral.c (box_win): Assume win_info and
2495         win_info->handle cannot be NULL.
2496
2497 2019-08-30  Tom Tromey  <tom@tromey.com>
2498
2499         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2500         refresh_window>: Declare.
2501         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2502         resize.
2503         (tui_data_item_window::rerender): Rename from
2504         tui_display_register.
2505         (tui_data_item_window::refresh_window): New method.
2506         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2507         no-op.
2508
2509 2019-08-30  Tom Tromey  <tom@tromey.com>
2510
2511         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2512         regs_column_count, current_group>: Move later.  Now private.
2513         <get_current_group>: New method.
2514         * tui/tui-regs.c (tui_reg_command): Update.
2515         * tui/tui-layout.c (tui_set_layout): Update.
2516
2517 2019-08-30  Tom Tromey  <tom@tromey.com>
2518
2519         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2520         (tui_data_window::rerender): Don't call
2521         check_and_display_highlight_if_needed.
2522         (tui_data_window::refresh_all): Remove call to
2523         erase_data_content.
2524
2525 2019-08-30  Tom Tromey  <tom@tromey.com>
2526
2527         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2528         (tui_data_window::display_registers_from)
2529         (tui_data_window::display_reg_element_at_line)
2530         (tui_data_window::display_registers_from_line): Remove checks of
2531         "empty".
2532
2533 2019-08-30  Tom Tromey  <tom@tromey.com>
2534
2535         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2536         Don't declare.
2537         * tui/tui-regs.c (tui_data_window::show_registers): Call
2538         rerender.
2539         (tui_data_window::rerender): Rename from display_all_data.
2540         (tui_data_window::rerender): Remove old implementation.
2541
2542 2019-08-30  Tom Tromey  <tom@tromey.com>
2543
2544         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2545         text.
2546         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2547
2548 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2549             Sergio Durigan Junior  <sergiodj@redhat.com>
2550
2551         PR win32/24284
2552         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2553
2554 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2555
2556         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2557         when searching for types.
2558
2559 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2560
2561         * f-lang.c (f_language_defn): Use f_print_typedef.
2562         * f-lang.h (f_print_typedef): Declare.
2563         * f-typeprint.c (f_print_typedef): Define.
2564
2565 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2566
2567         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2568
2569 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2570
2571         * cli/cli-utils.c (info_print_options_defs): Delete.
2572         (make_info_print_options_def_group): Delete.
2573         (extract_info_print_options): Delete.
2574         (info_print_command_completer): Delete.
2575         (info_print_args_help): Add extra parameter, and optionally
2576         include text about -n flag.
2577         * cli/cli-utils.h (struct info_print_options): Delete.
2578         (extract_info_print_options): Delete declaration.
2579         (info_print_command_completer): Delete declaration.
2580         (info_print_args_help): Add extra parameter, extend header
2581         comment.
2582         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2583         search_symbols.
2584         * stack.c (struct info_print_options): New type.
2585         (info_print_options_defs): New file scoped variable.
2586         (make_info_print_options_def_group): New static function.
2587         (info_print_command_completer): New static function.
2588         (info_locals_command): Update to use new local functions.
2589         (info_args_command): Likewise.
2590         (_initialize_stack): Add extra parameter to calls to
2591         info_print_args_help.
2592         * symtab.c (search_symbols): Add extra parameter, use this to
2593         possibly excluse non-debug symbols.
2594         (symtab_symbol_info): Add extra parameter, which is passed on to
2595         search_symbols.
2596         (struct info_print_options): New type.
2597         (info_print_options_defs): New file scoped variable.
2598         (make_info_print_options_def_group): New static function.
2599         (info_print_command_completer): New static function.
2600         (info_variables_command): Update to use local functions, and pass
2601         extra parameter through to symtab_symbol_info.
2602         (info_functions_command): Likewise.
2603         (info_types_command): Pass additional argument through to
2604         symtab_symbol_info.
2605         (rbreak_command): Pass extra argument to search_symbols.
2606         (_initialize_symtab): Add extra arguments for calls to
2607         info_print_args_help, and update help text for 'info variables',
2608         'whereis', and 'info functions' commands.
2609         * symtab.h (search_symbols): Add extra argument to declaration.
2610         * NEWS: Mention new flags.
2611
2612 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2613
2614         * symtab.c (lookup_static_symbol): Call the new function (and move
2615         it down to be next to lookup_global_symbol).
2616         (struct global_sym_lookup_data): Add block_enum member and rename to...
2617         (struct global_or_static_sym_lookup_data): ...this.
2618         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2619         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2620         (lookup_symbol_global_or_static_iterator_cb): ...this.
2621         (lookup_global_or_static_symbol): New function.
2622         (lookup_global_symbol): Call new function.
2623
2624 2019-08-26  Tom de Vries  <tdevries@suse.de>
2625
2626         PR c++/24852
2627         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2628         when pc_probe.prob == NULL.
2629
2630 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2631
2632         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2633         variable symbol_linkage to symbol_linkage_.
2634
2635 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2636
2637         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2638         represent whether the symbol is static, dynamic, or we don't
2639         know.
2640
2641 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2642
2643         * gdb/rx-tdep.c (rx_register_names): New.
2644         (rx_register_name): Delete.
2645         (rx_psw_type): Delete.
2646         (rx_fpsw_type): Delete.
2647         (rx_register_type): Delete.
2648         (rx_gdbarch_init): Convert target-descriptions.
2649         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2650         * gdb/features/Makefile: Add rx.xml.
2651         * gdb/features/rx.xml: New.
2652         * gdb/features/rx.c: Generated.
2653         * gdb/NEWS: Mention target description support.
2654
2655 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2656
2657         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2658         *slot_ptr.
2659
2660 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2661
2662         * configure.ac: Don't check for 'dlfcn.h' (moved to
2663         gdbsupport/common.m4).
2664         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2665         'gdbsupport/'.
2666         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2667         * compile/compile-c-support.c: Include
2668         'gdbsupport/gdb-dlfcn.h'.
2669         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2670         * gdb-dlfcn.c: Move to...
2671         * gdbsupport/gdb-dlfcn.c: ... here.
2672         * gdb-dlfcn.h: Move to...
2673         * gdbsupport/gdb-dlfcn.h: ... here.
2674
2675 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2676
2677         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2678         the offset field signed.
2679
2680 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2681
2682         * python/lib/gdb/__init__.py (_execute_file): New function.
2683         * python/python.c (python_run_simple_file): Call gdb._execute_file
2684         on Windows.
2685
2686 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2687
2688         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2689         all uses as this was never set to anything but a zero value.
2690
2691 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2692
2693         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2694
2695 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2696
2697         * tui/tui-data.h (tui_gen_win_info): Add an =default
2698         move constructor, required by some GCC versions.
2699
2700 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2701
2702         * go32-nat.c (go32_sysinfo): Add hygon_p.
2703
2704 2019-08-20  Tom Tromey  <tom@tromey.com>
2705
2706         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2707         line_from_reg_element_no, first_reg_element_no_inline,
2708         display_all_data, delete_data_content_windows,
2709         erase_data_content>: Now private.
2710
2711 2019-08-20  Tom Tromey  <tom@tromey.com>
2712
2713         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2714         (tui_unhighlight_win, tui_highlight_win)
2715         (tui_win_info::make_window): Update.
2716         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2717
2718 2019-08-20  Tom Tromey  <tom@tromey.com>
2719
2720         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2721         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2722         (MAX_PID_WIDTH): Move to tui-stack.c.
2723         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2724         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2725         (MAX_PID_WIDTH): Move from tui-data.h.
2726
2727 2019-08-20  Tom Tromey  <tom@tromey.com>
2728
2729         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2730         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2731         (box_win): Update.
2732         (tui_gen_win_info::make_window): Rename from tui_make_window.
2733         (tui_win_info::make_window): New method.
2734         (tui_gen_win_info::make_visible): Update.
2735         * tui/tui-source.c (tui_source_window::set_contents): Update.
2736         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2737         (tui_data_window::display_registers_from): Update.
2738         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2739         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2740         Declare.
2741         <can_box>: Remove.
2742         <title>: Remove.
2743         (struct tui_win_info) <make_window>: Declare.
2744         <can_box>: Now virtual.
2745         <title>: New member.
2746         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2747         * tui/tui-command.c (tui_cmd_window::resize): Update.
2748
2749 2019-08-20  Tom Tromey  <tom@tromey.com>
2750
2751         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2752         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2753         (tui_data_window::check_register_values): Update.
2754
2755 2019-08-20  Tom Tromey  <tom@tromey.com>
2756
2757         * tui/tui-regs.h (struct tui_data_window): Use
2758         DISABLE_COPY_AND_ASSIGN.
2759         <regs_content>: Change type, removing unique_ptr.
2760         <tui_data_window>: Add move constructor.
2761         * tui/tui-regs.c (tui_data_window::show_registers)
2762         (tui_data_window::show_register_group)
2763         (tui_data_window::display_registers_from)
2764         (tui_data_window::display_registers_from)
2765         (tui_data_window::first_data_item_displayed)
2766         (tui_data_window::delete_data_content_windows)
2767         (tui_data_window::rerender, tui_data_window::refresh_window)
2768         (tui_data_window::check_register_values): Update.
2769
2770 2019-08-20  Tom Tromey  <tom@tromey.com>
2771
2772         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2773         show_register_group>: Declare.
2774         (tui_show_register_group): Don't declare.
2775         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2776         tui_show_registers.
2777         (tui_data_window::show_register_group): Rename from
2778         tui_show_register_group.
2779         (tui_data_window::check_register_values, tui_reg_command):
2780         Update.
2781         * tui/tui-layout.c (tui_set_layout): Update.
2782
2783 2019-08-20  Tom Tromey  <tom@tromey.com>
2784
2785         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2786         Declare.
2787         (tui_check_register_values): Don't declare.
2788         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2789         from tui_check_register_values.
2790         * tui/tui-hooks.c (tui_register_changed): Update.
2791
2792 2019-08-20  Tom Tromey  <tom@tromey.com>
2793
2794         * tui/tui-regs.c (tui_reg_layout): Move later.
2795         (tui_show_registers): Don't enable TUI mode or change layout.
2796
2797 2019-08-20  Tom Tromey  <tom@tromey.com>
2798
2799         * tui/tui-regs.h (struct tui_data_item_window)
2800         <~tui_data_item_window>: Remove.
2801         <content>: Now a unique_xmalloc_ptr.
2802         * tui/tui-regs.c (tui_register_format): Return a
2803         unique_xmalloc_ptr.
2804         (tui_get_register): Update.
2805         (~tui_data_item_window): Remove.
2806         (tui_data_window::display_registers_from, tui_display_register):
2807         Update.
2808         * tui/tui-io.h (tui_expand_tabs): Update.
2809         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2810         Remove "col" parameter.
2811
2812 2019-08-20  Tom Tromey  <tom@tromey.com>
2813
2814         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2815         field.
2816         * tui/tui-regs.c (~tui_data_item_window): Update.
2817
2818 2019-08-20  Tom Tromey  <tom@tromey.com>
2819
2820         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2821         earlier.
2822
2823 2019-08-20  Tom Tromey  <tom@tromey.com>
2824
2825         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2826
2827 2019-08-20  Tom Tromey  <tom@tromey.com>
2828
2829         * tui/tui-source.h (struct tui_source_window): Update.
2830         * tui/tui-regs.c (tui_show_registers): Update.
2831         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2832         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2833         (NO_REGS_STRING): Remove defines.
2834
2835 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2836
2837         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2838         unnecessary thread walk if remote doesn't support the packet.
2839
2840 2019-08-19  Tom Tromey  <tromey@adacore.com>
2841
2842         * python/py-value.c (value_has_field): Fix indentation.
2843
2844 2019-08-19  Tom Tromey  <tromey@adacore.com>
2845
2846         * printcmd.c (do_one_display, info_display_command): Update.
2847         * block.h (contained_in): Return bool.  Add allow_nested
2848         parameter.
2849         * block.c (contained_in): Return bool.  Add allow_nested
2850         parameter.
2851
2852 2019-08-19  Tom Tromey  <tom@tromey.com>
2853
2854         * configure: Rebuild.
2855         * configure.ac: Disallow the combination of -static-libstdc++ and
2856         source highlight.
2857         * source-cache.c (get_language_name): Handle rust.
2858         (source_cache::get_source_lines): Ignore highlighting exceptions.
2859
2860 2019-08-16  Tom Tromey  <tom@tromey.com>
2861
2862         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2863         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2864         (struct tui_source_window_base) <make_visible, refresh_window,
2865         resize>: Remove methods.
2866         <execution_info>: Remove field.
2867         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2868         (tui_show_source_line, tui_source_window_base)
2869         (~tui_source_window_base): Update.
2870         (tui_source_window_base::resize)
2871         (tui_source_window_base::make_visible)
2872         (tui_source_window_base::refresh_window): Remove.
2873         (tui_source_window_base::update_exec_info): Update.
2874         * tui/tui-source.c (tui_source_window::set_contents): Update.
2875         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2876
2877 2019-08-16  Tom Tromey  <tom@tromey.com>
2878
2879         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2880         deprecated_query_hook.
2881
2882 2019-08-16  Tom Tromey  <tom@tromey.com>
2883
2884         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2885         (tui_update_source_windows_with_line): Update.
2886         * tui/tui-source.h (struct tui_source_window)
2887         <show_symtab_source>: Declare.
2888         (tui_show_symtab_source): Don't declare.
2889         * tui/tui-source.c (tui_show_symtab_source): Rename from
2890         tui_show_symtab_source.
2891
2892 2019-08-16  Tom Tromey  <tom@tromey.com>
2893
2894         * tui/tui-winsource.h (struct tui_source_window_base)
2895         <set_contents>: Declare.
2896         * tui/tui-winsource.c
2897         (tui_source_window_base::update_source_window_as_is): Update.
2898         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2899         Declare.
2900         (tui_set_source_content): Don't declare.
2901         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2902         tui_set_source_content.
2903         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2904         Declare.
2905         (tui_set_disassem_content): Don't declare.
2906         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2907         tui_set_disassem_content.
2908
2909 2019-08-16  Tom Tromey  <tom@tromey.com>
2910
2911         * tui/tui-winsource.h (struct tui_source_window_base)
2912         <update_breakpoint_info>: Declare.
2913         (tui_update_breakpoint_info): Don't declare.
2914         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2915         (tui_update_all_breakpoint_info): Update.
2916         (tui_source_window_base::update_breakpoint_info): Rename from
2917         tui_update_breakpoint_info.
2918         (tui_source_window_base::update_exec_info): Update.
2919
2920 2019-08-16  Tom Tromey  <tom@tromey.com>
2921
2922         * tui/tui-winsource.h (struct tui_source_window_base)
2923         <update_source_window>: Declare.
2924         (tui_update_source_window): Don't declare.
2925         * tui/tui-winsource.c
2926         (tui_source_window_base::update_source_window): Rename from
2927         tui_update_source_window.
2928         (tui_source_window_base::rerender): Update.
2929         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2930         * tui/tui-disasm.c (tui_show_disassem)
2931         (tui_show_disassem_and_update_source)
2932         (tui_disasm_window::maybe_update): Update.
2933
2934 2019-08-16  Tom Tromey  <tom@tromey.com>
2935
2936         * tui/tui-winsource.h (struct tui_source_window_base)
2937         <update_source_window_as_is>: Declare.
2938         (tui_update_source_window_as_is): Don't declare.
2939         * tui/tui-winsource.c (tui_update_source_window): Update
2940         (tui_source_window_base::update_source_window_as_is): Rename from
2941         tui_update_source_window_as_is.
2942         (tui_source_window_base::refill): Update.
2943         * tui/tui-source.c (tui_show_symtab_source): Update.
2944         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2945         Update.
2946
2947 2019-08-16  Tom Tromey  <tom@tromey.com>
2948
2949         * tui/tui-winsource.h (tui_update_source_window)
2950         (tui_update_source_window_as_is): Remove "noerror" parameter.
2951         * tui/tui-winsource.c (tui_update_source_window)
2952         (tui_update_source_window_as_is): Remove "noerror" parameter.
2953         (tui_update_source_windows_with_addr)
2954         (tui_update_source_windows_with_line)
2955         (tui_source_window_base::rerender)
2956         (tui_source_window_base::refill): Update.
2957         * tui/tui-source.h (tui_set_source_content)
2958         (tui_show_symtab_source): Remove "noerror" parameter.
2959         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2960         parameter.
2961         (tui_show_symtab_source): Likewise.
2962         (tui_source_window::maybe_update): Update.
2963         * tui/tui-disasm.c (tui_show_disassem)
2964         (tui_show_disassem_and_update_source)
2965         (tui_disasm_window::do_scroll_vertical)
2966         (tui_disasm_window::maybe_update): Update.
2967
2968 2019-08-16  Tom Tromey  <tom@tromey.com>
2969
2970         * tui/tui.c (tui_is_window_visible): Update.
2971         * tui/tui-wingeneral.c (tui_make_window)
2972         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2973         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2974         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2975         (tui_set_win_height_command, parse_scrolling_args): Update.
2976         * tui/tui-source.c (tui_source_window::style_changed): Update.
2977         * tui/tui-regs.c (tui_show_registers)
2978         (tui_data_window::first_data_item_displayed)
2979         (tui_data_window::delete_data_content_windows)
2980         (tui_check_register_values, tui_reg_command): Update.
2981         * tui/tui-disasm.c (tui_show_disassem): Update.
2982         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2983         method.
2984         <is_visible>: Remove field.
2985         * tui/tui-data.c (tui_next_win, tui_prev_win)
2986         (tui_delete_invisible_windows): Update.
2987
2988 2019-08-16  Tom Tromey  <tom@tromey.com>
2989
2990         * tui/tui-winsource.h (struct tui_source_window_base)
2991         <m_has_locator>: Remove.
2992         * tui/tui-layout.c (show_source_disasm_command, show_data)
2993         (show_source_or_disasm_and_command): Update.
2994
2995 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2996
2997         * NEWS (Other MI changes): New subsection.
2998         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2999         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3000         * arch-utils.c (default_get_pc_address_flags): New function.
3001         * arch-utils.h (default_get_pc_address_flags): New declaration.
3002         * gdbarch.sh: Add get_pc_address_flags.
3003         * gdbarch.c: Regenerate.
3004         * gdbarch.h: Likewise.
3005         * stack.c (print_pc): New function.
3006         (print_frame_info) (print_frame): Call print_pc.
3007
3008 2019-08-16  Tom de Vries  <tdevries@suse.de>
3009
3010         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3011         print_objfile_section_info.
3012
3013 2019-08-15  Tom Tromey  <tom@tromey.com>
3014
3015         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3016         calling update_cmdwin_start_line.
3017         * tui/tui-winsource.h (struct tui_source_window_base)
3018         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3019         <rerender>: Declare.
3020         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3021         Call rerender.
3022         (tui_source_window_base::set_new_height): Remove.
3023         (tui_source_window_base::rerender): Rename from
3024         do_make_visible_with_new_height.
3025         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3026         resize method.
3027         (tui_win_info::make_invisible_and_set_new_height)
3028         (tui_win_info::make_visible_with_new_height): Remove.
3029         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3030         Declare.
3031         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3032         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3033         do_make_visible_with_new_height>: Don't declare.
3034         <rerender>: Declare.
3035         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3036         set_new_height.
3037         (tui_data_window::do_make_visible_with_new_height): Remove.
3038         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3039         call tui_show_locator_content.
3040         (tui_gen_win_info::resize): Call rerender.
3041         (show_source_or_disasm_and_command): Don't call
3042         tui_show_locator_content.
3043         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3044         method.
3045         (struct tui_win_info) <rerender>: Declare.
3046         <set_new_height, make_invisible_and_set_new_height,
3047         make_visible_with_new_height>: Don't declare.
3048         * tui/tui-data.c (tui_win_list::rerender): New method.
3049         * tui/tui-command.h (struct tui_cmd_window)
3050         <do_make_visible_with_new_height>: Don't declare.
3051         * tui/tui-command.c
3052         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3053
3054 2019-08-15  Tom Tromey  <tromey@adacore.com>
3055
3056         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3057         * ada-lang.c (ada_enum_name): Likewise.
3058
3059 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3060
3061         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3062         leading underscore.
3063         (GdbOutputErrorFile): Likewise.
3064         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3065         accordingly.
3066         (execute_unwinders): Rename to have a leading underscore.
3067         (auto_load_packages): Likewise.
3068         (global scope): Adjust call to auto_load_packages accordingly.
3069         (GdbSetPythonDirectory): Likewise.
3070         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3071         instead of execute_unwinders.
3072
3073 2019-08-15  Tom Tromey  <tom@tromey.com>
3074
3075         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3076         (show_data): Don't change window visibility.
3077         (tui_gen_win_info::resize): Remove special case for command
3078         window.  Use wresize, when available.
3079         (show_source_or_disasm_and_command): Don't change window
3080         visibility.
3081         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3082         <make_visible>: New method.
3083         * tui/tui-command.c (tui_cmd_window::resize): New method.
3084
3085 2019-08-15  Tom Tromey  <tom@tromey.com>
3086
3087         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3088         (struct tui_source_windows): New.
3089         * tui/tui-winsource.c (tui_display_main): Update.
3090         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3091         (new_height_ok, parse_scrolling_args): Update.
3092         * tui/tui-layout.c (show_layout, show_data): Update.
3093         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3094         (tui_add_to_source_windows): Don't declare.
3095         * tui/tui-data.c (source_windows, tui_source_windows)
3096         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3097
3098 2019-08-15  Tom Tromey  <tom@tromey.com>
3099
3100         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3101         Rename from reset.
3102         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3103         * tui/tui-layout.c (show_source_disasm_command, show_data):
3104         Update.
3105         (tui_gen_win_info::resize): Rename.
3106         (show_source_or_disasm_and_command): Update.
3107         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3108         reset.
3109
3110 2019-08-15  Tom Tromey  <tom@tromey.com>
3111
3112         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3113         * tui/tui-interp.c (tui_interp::init): Don't call
3114         tui_initialize_static_data.
3115         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3116
3117 2019-08-15  Tom Tromey  <tom@tromey.com>
3118
3119         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3120         examine tui_win_list.
3121
3122 2019-08-15  Tom Tromey  <tom@tromey.com>
3123
3124         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3125         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3126         tui_clear_source_content.
3127         (tui_clear_source_content): Remove.
3128         (tui_source_window_base::do_erase_source_content): Hoist call to
3129         content.clear().
3130         * tui/tui-stack.c (tui_show_frame_info): Don't call
3131         tui_clear_source_content.
3132
3133 2019-08-15  Tom Tromey  <tom@tromey.com>
3134
3135         * tui/tui-winsource.h (struct tui_source_window_base)
3136         <do_erase_source_content>: New method.
3137         <erase_source_content>: New method.
3138         (tui_erase_source_content): Don't declare.
3139         * tui/tui-winsource.c (tui_clear_source_content): Update.
3140         (tui_source_window_base::do_erase_source_content): Rename from
3141         tui_erase_source_content.
3142         (tui_source_window_base::show_source_content): Update.
3143         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3144         * tui/tui-source.h (struct tui_source_window)
3145         <erase_source_content>: New method.
3146         * tui/tui-disasm.h (struct tui_disasm_window)
3147         <erase_source_content>: New method.
3148
3149 2019-08-15  Tom Tromey  <tom@tromey.com>
3150
3151         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3152         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3153         constructor.
3154         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3155         * tui/tui-source.c (tui_set_source_content): Update.
3156         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3157
3158 2019-08-15  Tom Tromey  <tom@tromey.com>
3159
3160         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3161         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3162         tui-source.c.
3163         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3164         Declare.
3165         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3166         method.
3167         (tui_source_window::maybe_update): Update.
3168
3169 2019-08-15  Tom Tromey  <tom@tromey.com>
3170
3171         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3172         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3173         tui-disasm.c.
3174         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3175         Declare.
3176         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3177         method.
3178         (tui_disasm_window::maybe_update): Update.
3179
3180 2019-08-15  Tom Tromey  <tom@tromey.com>
3181
3182         * tui/tui-winsource.h (struct tui_source_window_base)
3183         <maybe_update>: Declare.
3184         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3185         method.
3186         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3187         Declare.
3188         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3189         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3190         Declare.
3191         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3192
3193 2019-08-15  Tom Tromey  <tom@tromey.com>
3194
3195         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3196
3197 2019-08-15  Tom Tromey  <tom@tromey.com>
3198
3199         * tui/tui-wingeneral.c: Include tui-stack.h.
3200         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3201         (struct tui_locator_window): Move from tui-data.h.
3202         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3203         (tui_initialize_static_data): Move from tui-data.c.
3204         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3205         (struct tui_locator_window): Move to tui-stack.c.
3206         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3207         (tui_initialize_static_data): Move to tui-stack.c.
3208
3209 2019-08-15  Tom Tromey  <tom@tromey.com>
3210
3211         * tui/tui-layout.c (show_source_disasm_command)
3212         (show_source_or_disasm_and_command): Use make_visible method, not
3213         tui_make_window.
3214         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3215         Remove.
3216
3217 2019-08-15  Tom Tromey  <tom@tromey.com>
3218
3219         * tui/tui-wingeneral.h (tui_make_window): Update.
3220         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3221         parameter.
3222         (tui_gen_win_info::make_visible): Update.
3223         * tui/tui-regs.c (tui_data_window::display_registers_from):
3224         Update.
3225         * tui/tui-layout.c (show_source_disasm_command)
3226         (show_source_or_disasm_and_command): Update.
3227         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3228         (enum tui_box): Remove.
3229         (struct tui_win_info) <can_box>: New method.
3230         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3231         method.
3232
3233 2019-08-15  Tom de Vries  <tdevries@suse.de>
3234
3235         * linux-nat-trad.c: Include gdbarch.h.
3236
3237 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3238
3239         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3240         register sizes.
3241
3242 2019-08-14  Tom Tromey  <tromey@adacore.com>
3243
3244         * darwin-nat.c: Include gdbarch.h.
3245         * darwin-nat-info.c: Include gdbarch.h.
3246
3247 2019-08-13  Tom Tromey  <tom@tromey.com>
3248
3249         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3250         Remove.
3251         * tui/tui-data.c (tui_initialize_static_data): Update.
3252
3253 2019-08-13  Tom Tromey  <tom@tromey.com>
3254
3255         * tui/tui-winsource.h (struct tui_exec_info_window)
3256         <~tui_exec_info_window, maybe_allocate_content, get_content,
3257         m_content>: Remove.
3258         (struct tui_source_window_base) <set_exec_info_content,
3259         show_exec_info_content>: Don't declare.
3260         * tui/tui-winsource.c
3261         (tui_exec_info_window::maybe_allocate_content): Remove.
3262         (tui_source_window_base::update_exec_info): Rename from
3263         set_exec_info_content.
3264         (tui_source_window_base::show_exec_info_content)
3265         (tui_source_window_base::update_exec_info): Remove.
3266
3267 2019-08-13  Tom Tromey  <tom@tromey.com>
3268
3269         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3270         declare.
3271         * tui/tui-winsource.c (tui_update_source_window_as_is)
3272         (tui_update_source_windows_with_addr, tui_erase_source_content):
3273         Update.
3274         (tui_clear_exec_info_content): Remove.
3275
3276 2019-08-13  Tom Tromey  <tom@tromey.com>
3277
3278         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3279         declare.
3280         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3281         call tui_erase_exec_info_content.
3282         (tui_clear_exec_info_content): Rename from
3283         tui_erase_exec_info_content.
3284         (tui_clear_exec_info_content): Delete.
3285
3286 2019-08-13  Tom Tromey  <tom@tromey.com>
3287
3288         * tui/tui-winsource.h (struct tui_source_window_base)
3289         <show_exec_info_content>: Declare.
3290         (tui_show_exec_info_content): Don't declare.
3291         * tui/tui-winsource.c
3292         (tui_source_window_base::show_exec_info_content): Rename from
3293         tui_show_exec_info_content.
3294         (tui_source_window_base::update_exec_info): Update.
3295
3296 2019-08-13  Tom Tromey  <tom@tromey.com>
3297
3298         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3299         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3300         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3301         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3302         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3303         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3304         ... here.
3305
3306 2019-08-13  Tom Tromey  <tom@tromey.com>
3307
3308         * tui/tui-winsource.h (struct tui_source_window_base)
3309         <update_exec_info>: Declare.
3310         (tui_update_exec_info): Don't declare.
3311         * tui/tui-winsource.c (tui_update_source_window_as_is)
3312         (tui_source_window_base::refresh_all)
3313         (tui_update_all_breakpoint_info): Update.
3314         (tui_source_window_base::update_exec_info): Rename from
3315         tui_update_exec_info.
3316         * tui/tui-stack.c (tui_show_frame_info): Update.
3317
3318 2019-08-13  Tom Tromey  <tom@tromey.com>
3319
3320         * tui/tui-winsource.h (struct tui_source_window_base)
3321         <set_exec_info_content>: Declare.
3322         (tui_set_exec_info_content): Don't declare.
3323         * tui/tui-winsource.c
3324         (tui_source_window_base::set_exec_info_content): Rename from
3325         tui_set_exec_info_content.
3326         (tui_update_exec_info): Update.
3327
3328 2019-08-13  Tom Tromey  <tom@tromey.com>
3329
3330         * tui/tui-winsource.h (struct tui_source_window_base)
3331         <show_source_content>: Declare.
3332         (tui_show_source_content): Don't declare.
3333         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3334         (tui_source_window_base::show_source_content): Rename from
3335         tui_show_source_content.
3336         (tui_source_window_base::refresh_all): Update.
3337         * tui/tui-layout.c (show_source_disasm_command)
3338         (show_source_or_disasm_and_command): Update.
3339
3340 2019-08-13  Tom Tromey  <tom@tromey.com>
3341
3342         * tui/tui-winsource.c (tui_erase_source_content)
3343         (tui_show_source_content, tui_source_window_base::refresh_all):
3344         Update.
3345         * tui/tui-wingeneral.h
3346         (tui_check_and_display_highlight_if_needed): Don't declare.
3347         * tui/tui-wingeneral.c
3348         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3349         check_and_display_highlight_if_needed.
3350         * tui/tui-win.c (tui_rehighlight_all)
3351         (tui_win_info::make_visible_with_new_height): Update.
3352         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3353         (tui_data_window::erase_data_content)
3354         (tui_data_window::display_all_data): Update.
3355         * tui/tui-data.h (struct tui_win_info)
3356         <check_and_display_highlight_if_needed>: Declare.
3357
3358 2019-08-13  Tom Tromey  <tom@tromey.com>
3359
3360         * tui/tui-win.c (tui_resize_all): Call
3361         tui_delete_invisible_windows.
3362         * tui/tui-layout.c (show_layout): Call
3363         tui_delete_invisible_windows.
3364         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3365         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3366
3367 2019-08-13  Tom Tromey  <tom@tromey.com>
3368
3369         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3370         tui_add_win_to_layout.
3371
3372 2019-08-13  Tom Tromey  <tom@tromey.com>
3373
3374         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3375         * tui/tui-layout.c (tui_default_win_height): Now static.
3376
3377 2019-08-13  Tom Tromey  <tom@tromey.com>
3378
3379         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3380         single switch.
3381         (show_source_disasm_command, show_source_or_disasm_and_command):
3382         Don't check current layout.
3383
3384 2019-08-13  Tom Tromey  <tom@tromey.com>
3385
3386         * tui/tui-wingeneral.c (make_all_visible): Remove.
3387         (tui_make_all_invisible): Simplify.
3388         * tui/tui-layout.c (tui_make_all_invisible): Move from
3389         tui-wingeneral.c; simplify.
3390         (show_layout): Hoist call to tui_make_all_invisible.
3391         (show_data): Don't call tui_make_all_invisible.
3392
3393 2019-08-13  Tom Tromey  <tom@tromey.com>
3394
3395         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3396         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3397
3398 2019-08-13  Tom Tromey  <tom@tromey.com>
3399
3400         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3401         tui-data.c.
3402         (show_source_disasm_command, show_data)
3403         (show_source_or_disasm_and_command): Don't use
3404         tui_set_current_layout_to.
3405         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3406         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3407         tui-layout.c.
3408         (tui_set_current_layout_to): Remove.
3409
3410 2019-08-13  Tom Tromey  <tom@tromey.com>
3411
3412         * tui/tui-layout.c (tui_set_layout): Update.
3413         * tui/tui-data.h (struct tui_layout_def): Remove.
3414         (tui_layout_def): Don't declare.
3415         * tui/tui-data.c (layout_def): Remove.
3416         (tui_layout_def): Remove.
3417
3418 2019-08-13  Tom Tromey  <tom@tromey.com>
3419
3420         * tui/tui-winsource.h (struct tui_source_window_base)
3421         <clear_detail>: No longer "override".
3422         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3423         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3424         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3425         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3426         Remove.
3427         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3428
3429 2019-08-13  Tom Tromey  <tromey@adacore.com>
3430
3431         * tracepoint.c: Don't include readline.h or history.h.
3432
3433 2019-08-12  Tom Tromey  <tom@tromey.com>
3434
3435         * configure: Rebuild.
3436         * configure.ac: Check for readline 7.
3437         * NEWS: Mention readline 7 requirement.
3438         * README: Update.
3439
3440 2019-08-12  Tom Tromey  <tom@tromey.com>
3441
3442         * mingw-hdep.c (gdb_select): Remove readline hack.
3443
3444 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3445
3446         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3447         when the function fails.
3448
3449 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3450
3451         * s390-tdep.c (s390_type_align): New function.
3452         (s390_gdbarch_init): Set it as type_align gdbarch method.
3453
3454 2019-08-09  Tom de Vries  <tdevries@suse.de>
3455
3456         PR gdb/24591
3457         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3458         pc_low with relocation offset.
3459
3460 2019-08-07  Tom Tromey  <tromey@adacore.com>
3461
3462         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3463         (print_frame_args): Update.
3464         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3465         Update.
3466         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3467         * frame.h (struct frame_arg): Add initializers.
3468         <error>: Now a unique_xmalloc_ptr.
3469
3470 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3471
3472         * NEWS: Expand the Pointer Authentication entry.
3473         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3474         (aarch64_frame_unmask_lr): ... to this.
3475         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3476         Call aarch64_frame_unmask_lr.
3477         * frame.c (struct frame_info): Add "masked" variable.
3478         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3479         (fprint_frame): Check for masked pc.
3480         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3481         declarations.
3482         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3483         * stack.c (print_frame): Check for masked pc.
3484
3485 2019-08-06  Tom Tromey  <tom@tromey.com>
3486
3487         * stabsread.c (patch_block_stabs, read_one_struct_field)
3488         (read_enum_type): Use obstack_strndup.
3489         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3490         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3491         * dwarf2read.c (guess_full_die_structure_name)
3492         (anonymous_struct_prefix): Use obstack_strndup.
3493         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3494         * c-exp.y (yylex): Use obstack_strndup.
3495         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3496         (write_var_or_type): Use obstack_strndup.
3497
3498 2019-08-06  Tom Tromey  <tom@tromey.com>
3499
3500         * symfile.c (reread_symbols): Use obstack_strdup.
3501         * stabsread.c (read_type): Use obstack_strdup.
3502         * gdb_obstack.h (obstack_strdup): New overload.
3503         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3504         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3505         (dwarf2_canonicalize_name): Use obstack_strdup.
3506         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3507         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3508         Use obstack_strdup.
3509
3510 2019-08-06  Tom Tromey  <tom@tromey.com>
3511
3512         * gdb_obstack.h (obstack_strdup): Define.
3513         * gdb_obstack.c (obstack_strdup): Don't define.
3514
3515 2019-08-06  Tom Tromey  <tom@tromey.com>
3516
3517         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3518         obstack_strdup.
3519         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3520         obstack_strdup.
3521         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3522         * stabsread.c (common_block_start): Use obstack_strdup.
3523         * objfiles.c (set_objfile_main_name, objfile): Use
3524         obstack_strdup.
3525         * namespace.c (add_using_directive): Use obstack_strdup.
3526         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3527         * jit.c (finalize_symtab): Use obstack_strdup.
3528         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3529         (guess_partial_die_structure_name, partial_die_info::fixup)
3530         (dwarf2_name): Use obstack_strdup.
3531         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3532         obstack_strdup.
3533         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3534         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3535         obstack_strdup.
3536         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3537
3538 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3539
3540         * unittests/help-doc-selftests.c: New file.
3541         * Makefile.in: Add the new file.
3542
3543 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3544
3545         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3546         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3547         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3548         the trailing '.' is not output, and the first character is uppercased.
3549         (print_help_for_command): Update call to print_doc_line.
3550         (print_doc_of_command): Likewise.
3551         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3552         * cli/cli-option.c (append_indented_doc): Do not append newline.
3553         (build_help_option): Append newline after first appended_indented_doc
3554         only if a second call is done.
3555         (build_help): Append 2 new lines before each option, except the first
3556         one.
3557         * compile/compile.c (_initialize_compile): Add new lines after
3558         %OPTIONS%, when not at the end of the help.
3559         Change help doc or code
3560         producing the help doc to respect the invariants.
3561         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3562         Also removed the new line after 'Options:', as all other commands
3563         do not put an empty line between 'Options:' and the first option.
3564         * printcmd.c (_initialize_printcmd): Likewise.
3565         * stack.c (_initialize_stack): Likewise.
3566         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3567         incorrectly telling COMMAND is optional.
3568         * ada-lang.c (_initialize_ada_language): Change help doc or code
3569         producing the help doc to respect the invariants.
3570         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3571         * breakpoint.c (_initialize_breakpoint): Likewise.
3572         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3573         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3574         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3575         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3576         _initialize_cli_style): Likewise.
3577         * corelow.c (core_target_info): Likewise.
3578         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3579         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3580         * filesystem.c (_initialize_filesystem): Likewise.
3581         * frame.c (_initialize_frame): Likewise.
3582         * gnu-nat.c (add_task_commands): Likewise.
3583         * infcall.c (_initialize_infcall): Likewise.
3584         * infcmd.c (_initialize_infcmd): Likewise.
3585         * interps.c (_initialize_interpreter): Likewise.
3586         * language.c (_initialize_language): Likewise.
3587         * linux-fork.c (_initialize_linux_fork): Likewise.
3588         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3589         * maint.c (_initialize_maint_cmds): Likewise.
3590         * memattr.c (_initialize_mem): Likewise.
3591         * printcmd.c (_initialize_printcmd): Likewise.
3592         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3593         _RegEx): Likewise.
3594         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3595         * record-btrace.c (_initialize_record_btrace): Likewise.
3596         * record-full.c (_initialize_record_full): Likewise.
3597         * record.c (_initialize_record): Likewise.
3598         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3599         * regcache.c (_initialize_regcache): Likewise.
3600         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3601         _initialize_remote): Likewise.
3602         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3603         * serial.c (_initialize_serial): Likewise.
3604         * skip.c (_initialize_step_skip): Likewise.
3605         * source.c (_initialize_source): Likewise.
3606         * stack.c (_initialize_stack): Likewise.
3607         * symfile.c (_initialize_symfile): Likewise.
3608         * symtab.c (_initialize_symtab): Likewise.
3609         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3610         * top.c (init_main): Likewise.
3611         * tracefile-tfile.c (tfile_target_info): Likewise.
3612         * tracepoint.c (_initialize_tracepoint): Likewise.
3613         * tui/tui-win.c (_initialize_tui_win): Likewise.
3614         * utils.c (add_internal_problem_command): Likewise.
3615         * valprint.c (value_print_option_defs): Likewise.
3616
3617 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3618
3619         PR build/24886
3620         * configure.ac: Drop enable-libmcheck support.
3621         * configure, config.in: Rebuild.
3622         * libmcheck.m4: Remove.
3623         * acinclude.m4: Don't include it.
3624         * Makefile.in: Don't distribute it.
3625         * top.c (print_gdb_configuration): Don't mention it.
3626
3627 2019-08-06  Tom Tromey  <tom@tromey.com>
3628
3629         * utils.c (set_output_style): Sometimes pass stream to
3630         emit_style_escape.
3631         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3632         * record-btrace.c (btrace_insn_history): Update.
3633         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3634         method.
3635         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3636         Update initializers.
3637         <m_uiout>: New field.
3638         <m_di>: Move lower.
3639         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3640         Remove "uiout" parameter.
3641         (dump_insns): Update.
3642         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3643         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3644
3645 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3646
3647         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3648         (error_in_psymtab_expansion): Likewise.
3649         (lookup_symbol_via_quick_fns): Likewise.
3650         (basic_lookup_transparent_type_quick): Likewise.
3651         (basic_lookup_transparent_type_1): Likewise.
3652
3653 2019-08-06  Tom Tromey  <tromey@adacore.com>
3654
3655         * source.c (last_source_error): Now bool.
3656         (print_source_lines_base): Make "noprint" bool.  Only open
3657         source file when last_source_visited changes.
3658
3659 2019-08-06  Tom Tromey  <tromey@adacore.com>
3660
3661         * annotate.c (annotate_source_line): Use g_source_cache.
3662         * source-cache.c (source_cache::get_plain_source_lines): Change
3663         parameters.  Populate m_offset_cache.
3664         (source_cache::ensure): New method.
3665         (source_cache::get_line_charpos): New method.
3666         (extract_lines): Move lower.  Change parameters.
3667         (source_cache::get_source_lines): Move lower.
3668         * source-cache.h (class source_cache): Update comment.
3669         <get_line_charpos>: New method.
3670         <get_source_lines>: Update comment.
3671         <clear>: Clear m_offset_cache.
3672         <get_plain_source_lines>: Change parameters.
3673         <ensure>: New method
3674         <m_offset_cache>: New member.
3675         * source.c (forget_cached_source_info_for_objfile): Update.
3676         (info_source_command): Use g_source_cache.
3677         (find_source_lines, open_source_file_with_line_charpos): Remove.
3678         (print_source_lines_base, search_command_helper): Use g_source_cache.
3679         * source.h (open_source_file_with_line_charpos): Don't declare.
3680         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3681         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3682         Use g_source_cache.
3683
3684 2019-08-06  Tom Tromey  <tromey@adacore.com>
3685
3686         * source-cache.c (source_cache::get_plain_source_lines):
3687         Remove "first_line" and "last_line" parameters.
3688         (source_cache::get_source_lines): Cache plain text.
3689         * source-cache.h (class source_cache)
3690         <get_plain_source_lines>: Update.
3691
3692 2019-08-06  Tom Tromey  <tromey@adacore.com>
3693
3694         * source-cache.c (extract_lines): No longer a method.
3695         Changed type of parameter.  Include final newline.
3696         (selftests::extract_lines_test): New function.
3697         (_initialize_source_cache): Likewise.
3698         * source-cache.h (class source_cache)
3699         <extract_lines>: Don't declare.
3700
3701 2019-08-06  Tom Tromey  <tromey@adacore.com>
3702
3703         * breakpoint.c (init_breakpoint_sal): Update.
3704         (breakpoint): Update.
3705         * breakpoint.h (struct breakpoint) <filter>: Now a
3706         unique_xmalloc_ptr.
3707
3708 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3709
3710         * NEWS: Mention dictionary access on blocks.
3711         * python/py-block.c (blpy_getitem): New function.
3712         (block_object_as_mapping): New struct.
3713         (block_object_type): Use new struct for tp_as_mapping field.
3714
3715 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3716
3717         * objfiles.h (objfile): Add a comment describing partial symbols.
3718
3719 2019-08-05  Tom Tromey  <tromey@adacore.com>
3720
3721         * compile/compile.c (_initialize_compile): Use _(), not N_().
3722         * thread.c (_initialize_thread): Use _(), not N_().
3723         * stack.c (_initialize_stack): Use _(), not N_().
3724         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3725
3726 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3727
3728         * dwarf2read.c (struct dw2_symtab_iterator):
3729         <want_specific_block>: Remove.
3730         <block_index>: Change type to gdb::optional.
3731         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3732         change type of BLOCK_INDEX parameter to gdb::optional.
3733         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3734         (dw2_lookup_symbol): Don't pass argument for
3735         WANT_SPECIFIC_BLOCK.
3736         (dw2_expand_symtabs_for_function): Don't pass argument for
3737         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3738         (class dw2_debug_names_iterator)
3739         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3740         parameter, change BLOCK_INDEX type to gdb::optional.
3741         <m_want_specific_block>: Remove.
3742         <m_block_index>: Change type to gdb::optional.
3743         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3744         gdb::optional.  Re-write in function of gdb::optional.
3745         (dw2_debug_names_lookup_symbol): Don't pass argument for
3746         WANT_SPECIFIC_BLOCK.
3747         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3748         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3749         BLOCK_INDEX.
3750
3751 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3752
3753         * NEWS: Mention changes to "info sources" command.
3754
3755 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3756
3757         * symtab.c (filename_partial_match_opts): New struct type.
3758         (struct output_source_filename_data): New members
3759         regexp, c_regexp, partial_match.
3760         (output_source_filename): Use new members to decide to print file.
3761         (info_sources_option_defs): New variable.
3762         (make_info_sources_options_def_group, print_info_sources_header,
3763         info_sources_command_completer):
3764         New functions.
3765         (info_sources_command): Read new optional arguments.
3766         (_initialize_symtab): Update info sources help.
3767
3768 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3769
3770         * ada-lang.c (exception_support_info_v0): Renamed from...
3771         (default_exception_support_info): ... this.  Create new
3772         definition for v1.
3773         (ada_has_this_exception_support): Look up catch_handlers_sym.
3774         (ada_exception_support_info_sniffer): Try v0 after default.
3775
3776 2019-08-01  Tom Tromey  <tromey@adacore.com>
3777
3778         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3779         gdbarch.h.
3780
3781 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3782
3783         * s12z-tdep.c: Fix include path for s12z-opc.h.
3784
3785 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3786
3787         * NEWS: Require GNU make 3.82.
3788
3789 2019-07-16  Tom Tromey  <tom@tromey.com>
3790
3791         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3792         declare.
3793
3794 2019-07-30  Tom Tromey  <tromey@adacore.com>
3795
3796         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3797
3798 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3799
3800         * printcmd.c (print_address_symbolic): Print negative offsets.
3801         (build_address_symbolic): Force signed arithmetic when computing
3802         offset.
3803
3804 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3805
3806         PR/24474: Add a function to lookup static variables.
3807         * NEWS: Mention this new function.
3808         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3809         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3810         * python/python.c (python_GdbMethods): Add new function.
3811
3812 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3813
3814         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3815         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3816         (objfpy_lookup_static_symbol): New function.
3817         (objfile_object_methods): Add new functions.
3818
3819 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3820
3821         * NEWS: Mention 'set|show print frame-info'.  Mention new
3822         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3823         backtrace argument.  Mention that python frame filtering code
3824         is now consistent with what 'backtrace' command prints.
3825
3826 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3827
3828         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3829         comments.
3830         (print_frame_info_auto, print_frame_info_source_line,
3831         print_frame_info_location, print_frame_info_source_and_location,
3832         print_frame_info_location_and_address, print_frame_info_short_location):
3833         New declarations.
3834         (struct frame_print_options): New member print_frame_info.
3835         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3836         * stack.h (get_user_print_what_frame_info): New declaration.
3837         (frame_show_address): New declaration.
3838         * stack.c (print_frame_arguments_choices): New value 'presence'.
3839         (print_frame_info_auto, print_frame_info_source_line,
3840         print_frame_info_location, print_frame_info_source_and_location,
3841         print_frame_info_location_and_address, print_frame_info_short_location,
3842         print_frame_info_choices, print_frame_info_print_what): New definitions.
3843         (print_frame_args): Only print dots for args if print frame-arguments
3844         is 'presence'.
3845         (frame_print_option_defs): New element for "frame-info".
3846         (get_user_print_what_frame_info): New function.
3847         (frame_show_address): Make non static.  Move comment to stack.h.
3848         (print_frame_info_to_print_what): New function.
3849         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3850         to decide what to print.
3851         (backtrace_command_1): Handle the new print_frame_arguments_presence
3852         value.
3853         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3854         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3855         (py_print_frame): In non-mi mode, use LOCATION as default for
3856         print_what, similarly to frame information printed directly by
3857         backtrace command. Handle frame-info user option in non MI mode.
3858
3859 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3860
3861         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3862         Add case for debugging 32-bit target on 64-bit host.  Revise
3863         comment.
3864
3865 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3866
3867         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3868         instead of find_function_entry_range_from_pc.
3869
3870 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3871
3872         * stack.c (find_frame_funname): Remove code which preferred
3873         minsym over symtab sym in "certain pathological cases".
3874
3875         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3876         parameter.  Change type of "do_demangle" to bool.
3877         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3878         Pass suitable "prefer_sym_over_minsym" flag to
3879         build_address_symbolic().  Don't output "+" for negative offsets.
3880         * printcmd.c (print_address_symbolic): Update invocation of
3881         build_address_symbolic to include a "prefer_sym_over_minsym"
3882         flag.
3883         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3884         Restrict cases in which use of minimal symbol is preferred to that
3885         of a found symbol.  Update comments.
3886
3887         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3888         for entry pc when entry pc is out of range for that FDE.
3889
3890 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3891
3892         PR gdb/24839:
3893         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3894         type.
3895
3896 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3897
3898         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3899         this function's Python signature.
3900
3901
3902 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3903
3904         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3905         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3906         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3907         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3908         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3909
3910
3911 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3912
3913         * h8300-tdep.c (h8300_register_name_common): New.
3914         h8300_register_name): Use h8300_register_name_common.
3915         (h8300s_register_name): Likewise.
3916         (h8300sx_register_name): Likewise.
3917         (h8300h_register_nam): New.
3918         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3919
3920
3921 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3922
3923         * arm-tdep.c (arm_skip_cmse_entry): New function.
3924         (arm_is_sgstubs_section): New function.
3925         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3926
3927 2019-07-22  Tom Tromey  <tom@tromey.com>
3928
3929         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3930         Don't self-assign.
3931
3932 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3933
3934         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3935         type_print.
3936
3937 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3938
3939         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3940         so that GDB doesn't match any msymbols when searching in the
3941         TYPES_DOMAIN.
3942         (print_symbol_info): Print using typedef_print or type_print based
3943         on the type of the symbol.  Add updated FIXME comment moved from...
3944         (_initialize_symtab): ... move and update FIXME comment to above.
3945
3946 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3947
3948         * NEWS: Mention adding -q option to "info types".
3949         * symtab.c (struct info_types_options): New struct.
3950         (info_types_options_defs): New variable.
3951         (make_info_types_options_def_group): New function.
3952         (info_types_command): Use gdb::option framework to parse options.
3953         (info_types_command_completer): New function.
3954         (_initialize_symtab): Extend the help text on "info types" and
3955         register command completer.
3956
3957 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3958
3959         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3960         (lookup_symbol_in_objfile): Change int to block_enum and add a
3961         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3962
3963 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3964
3965         * MAINTAINERS (Write After Approval): Add self.
3966
3967 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3968
3969         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3970         instruction to the dummy code region.
3971
3972 2019-07-19  Tom Tromey  <tromey@adacore.com>
3973
3974         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3975         (ARGSUSED, PARAMS, __func__): Remove rules.
3976
3977 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3978
3979         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3980         * features/arm/arm-with-iwmmxt.c: Remove.
3981         * features/arm/arm-with-iwmmxt.xml: Remove.
3982         * features/arm/arm-with-m-fpa-layout.c: Remove.
3983         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3984         * features/arm/arm-with-m-vfp-d16.c: Remove.
3985         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3986         * features/arm/arm-with-m.c: Remove.
3987         * features/arm/arm-with-m.xml: Remove.
3988         * features/arm/arm-with-neon.c: Remove.
3989         * features/arm/arm-with-neon.xml: Remove.
3990         * features/arm/arm-with-vfpv2.c: Remove.
3991         * features/arm/arm-with-vfpv2.xml: Remove.
3992         * features/arm/arm-with-vfpv3.c: Remove.
3993         * features/arm/arm-with-vfpv3.xml: Remove.
3994
3995 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3996
3997         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3998
3999 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4000
4001         * arch/aarch32.c (aarch32_create_target_description): Create
4002         target descriptions using features.
4003         * arch/arm.c (arm_create_target_description)
4004         (arm_create_mprofile_target_description): Likewise.
4005         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4006
4007 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4008
4009         * Makefile.in: Add new files.
4010         * aarch32-tdep.c: New file.
4011         * aarch32-tdep.h: New file.
4012         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4013         Call aarch32_read_description.
4014         * arch/aarch32.c: New file.
4015         * arch/aarch32.h: New file.
4016         * arch/arm.c (arm_create_target_description)
4017         (arm_create_mprofile_target_description): New function.
4018         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4019         (arm_create_target_description)
4020         (arm_create_mprofile_target_description): New declaration.
4021         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4022         read_description functions.
4023         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4024         Likewise.
4025         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4026         * arm-tdep.c (tdesc_arm_list): New variable.
4027         (arm_register_g_packet_guesses): Call create description functions.
4028         (arm_read_description) (arm_read_mprofile_description): New
4029         function.
4030         * arm-tdep.h (arm_read_description)
4031         (arm_read_mprofile_description): Add declaration.
4032         * configure.tgt: Add new files.
4033
4034 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4035
4036         * top.c (new_ui_command): Open specified terminal just once.
4037
4038 2019-07-18  Tom Tromey  <tromey@adacore.com>
4039
4040         * symtab.c (main_name): Constify return type.
4041         * symfile.c (set_initial_language): Update.
4042         * symtab.h (main_name): Constify return type.
4043
4044 2019-07-17  Tom Tromey  <tom@tromey.com>
4045
4046         * tui/tui-winsource.c (tui_update_source_window)
4047         (tui_update_source_window_as_is)
4048         (tui_update_source_windows_with_line): Remove return.
4049         * tui/tui-disasm.c (tui_show_disassem)
4050         (tui_show_disassem_and_update_source): Remove return.
4051         * tui/tui.c (tui_reset): Remove return.
4052         * tui/tui-wingeneral.c
4053         (tui_check_and_display_highlight_if_needed): Remove return.
4054
4055 2019-07-17  Tom Tromey  <tom@tromey.com>
4056
4057         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4058
4059 2019-07-17  Tom Tromey  <tom@tromey.com>
4060
4061         * tui/tui-winsource.h (struct tui_exec_info_window)
4062         (struct tui_source_window_base): Move from tui-data.h.
4063         * tui/tui-winsource.c: Move many method definitions from
4064         elsewhere.  Remove "structuring" comments.
4065         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4066         (tui_source_window_base::refresh_window): Move to
4067         tui-winsource.c.
4068         * tui/tui-win.c (tui_source_window_base::refresh_all)
4069         (tui_source_window_base::update_tab_width)
4070         (tui_source_window_base::set_new_height)
4071         (tui_source_window_base::do_make_visible_with_new_height): Move to
4072         tui-winsource.c.
4073         * tui/tui-source.h: Update.
4074         * tui/tui-source.c (tui_source_window_base::reset): Move to
4075         tui-winsource.c.
4076         * tui/tui-disasm.h: Update.
4077         * tui/tui-data.h (struct tui_exec_info_window): Move to
4078         tui-winsource.h.
4079         (struct tui_source_window_base): Likewise.
4080         * tui/tui-data.c (tui_source_window_base::clear_detail)
4081         (tui_source_window_base, ~tui_source_window_base): Move to
4082         tui-winsource.c.
4083
4084 2019-07-17  Tom Tromey  <tom@tromey.com>
4085
4086         * tui/tui-win.c (tui_resize_all)
4087         (tui_source_window_base::update_tab_width)
4088         (tui_adjust_win_heights): Update.
4089         (tui_win_info::make_invisible_and_set_new_height): Rename from
4090         make_invisible_and_set_new_height.
4091         * tui/tui-data.h (struct tui_win_info)
4092         <make_invisible_and_set_new_height>: New method.
4093
4094 2019-07-17  Tom Tromey  <tom@tromey.com>
4095
4096         * tui/tui.c: Update.
4097         * tui/tui-source.h (struct tui_source_window): Move from
4098         tui-data.h.
4099         * tui/tui-layout.c: Update.
4100         * tui/tui-disasm.c: Update.
4101         * tui/tui-data.h (struct tui_source_window): Move to
4102         tui-source.h.
4103
4104 2019-07-17  Tom Tromey  <tom@tromey.com>
4105
4106         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4107         tui-data.h.
4108         * tui/tui-data.h (struct tui_disasm_window): Move to
4109         tui-disasm.h.
4110
4111 2019-07-17  Tom Tromey  <tom@tromey.com>
4112
4113         * tui/tui-regs.h (struct tui_data_item_window): Move from
4114         tui-data.h.
4115         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4116         * tui/tui-data.h (struct tui_data_item_window): Move to
4117         tui-regs.h.
4118         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4119
4120 2019-07-17  Tom Tromey  <tom@tromey.com>
4121
4122         * tui/tui.c: Update.
4123         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4124         (tui_cmd_window::max_height): Move to tui-command.c.
4125         * tui/tui-layout.c: Update.
4126         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4127         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4128         tui-command.c.
4129         * tui/tui-command.h (struct tui_cmd_window): Move from
4130         tui-data.h.
4131         * tui/tui-command.c: Remove "structuring" comments.
4132         (tui_cmd_window::clear_detail)
4133         (tui_cmd_window::do_make_visible_with_new_height)
4134         (tui_cmd_window::max_height): Move from elsewhere.
4135
4136 2019-07-17  Tom Tromey  <tom@tromey.com>
4137
4138         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4139         Now static.
4140         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4141         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4142
4143 2019-07-17  Tom Tromey  <tom@tromey.com>
4144
4145         * tui/tui.c: Update.
4146         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4147         tui-regs.c.
4148         * tui/tui-windata.h: Remove file.
4149         * tui/tui-windata.c: Remove file.
4150         * tui/tui-win.c (tui_data_window::set_new_height)
4151         (tui_data_window::do_make_visible_with_new_height): Move to
4152         tui-regs.c.
4153         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4154         * tui/tui-regs.c: Remove "structuring" comments.
4155         (tui_data_window::first_data_item_displayed)
4156         (tui_data_window::delete_data_content_windows)
4157         (tui_data_window::erase_data_content)
4158         (tui_data_window::display_all_data)
4159         (tui_data_window::refresh_all)
4160         (tui_data_window::do_scroll_vertical)
4161         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4162         (tui_data_window::do_make_visible_with_new_height)
4163         (tui_data_window::refresh_window): Move from elsewhere.
4164         (_initialize_tui_regs): Move to end of file.
4165         * tui/tui-layout.c: Update.
4166         * tui/tui-hooks.c: Update.
4167         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4168         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4169         tui-regs.c.
4170         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4171
4172 2019-07-17  Tom Tromey  <tom@tromey.com>
4173
4174         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4175         seen.
4176
4177 2019-07-17  Tom Tromey  <tom@tromey.com>
4178
4179         * tui/tui-win.c (tui_source_window_base::set_new_height)
4180         (tui_source_window_base::do_make_visible_with_new_height): Use
4181         m_has_locator field directly.
4182         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4183         method.
4184         (struct tui_source_window_base) <has_locator>: Likewise.
4185
4186 2019-07-17  Tom Tromey  <tom@tromey.com>
4187
4188         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4189         Don't declare.
4190         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4191         Remove.
4192         * tui/tui-win.c (tui_source_window_base::set_new_height)
4193         (tui_source_window_base::set_new_height)
4194         (make_invisible_and_set_new_height)
4195         (tui_source_window_base::do_make_visible_with_new_height)
4196         (tui_source_window_base::do_make_visible_with_new_height):
4197         Update.
4198         * tui/tui-layout.c (show_source_disasm_command, show_data)
4199         (show_source_or_disasm_and_command): Update.
4200         * tui/tui-layout.c (show_layout): Update.
4201
4202 2019-07-17  Tom Tromey  <tom@tromey.com>
4203
4204         * tui/tui-layout.c (make_data_window): Remove.
4205         (show_data): Unify creation and re-initialization cases.
4206
4207 2019-07-17  Tom Tromey  <tom@tromey.com>
4208
4209         * tui/tui-layout.c (make_source_window, make_disasm_window):
4210         Remove.
4211         (show_data): Unify creation and re-initialization cases.
4212
4213 2019-07-17  Tom Tromey  <tom@tromey.com>
4214
4215         * tui/tui-layout.c (make_command_window): Remove.
4216         (show_source_disasm_command, show_source_or_disasm_and_command):
4217         Unify creation and re-initialization cases.
4218
4219 2019-07-17  Tom Tromey  <tom@tromey.com>
4220
4221         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4222         creation and re-initialization cases.
4223
4224 2019-07-17  Tom Tromey  <tom@tromey.com>
4225
4226         * tui/tui-regs.c (tui_get_register): Return void.
4227
4228 2019-07-17  Tom Tromey  <tom@tromey.com>
4229
4230         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4231         Simplify.
4232
4233 2019-07-17  Tom Tromey  <tom@tromey.com>
4234
4235         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4236         resetting.
4237
4238 2019-07-17  Tom Tromey  <tom@tromey.com>
4239
4240         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4241         * tui/tui-regs.c (tui_reg_layout): New function.
4242         (tui_show_registers, tui_reg_command): Use it.
4243         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4244         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4245         parameters.
4246         (tui_layout_command): Remove.
4247
4248 2019-07-17  Tom Tromey  <tom@tromey.com>
4249
4250         * tui/tui-layout.h (tui/tui-layout): Return void.
4251         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4252
4253 2019-07-17  Tom Tromey  <tom@tromey.com>
4254
4255         * tui/tui-layout.c (show_source_disasm_command, show_data):
4256         Update.
4257         (reset_locator): Remove.
4258         (show_source_or_disasm_and_command): Update.
4259
4260 2019-07-17  Tom Tromey  <tom@tromey.com>
4261
4262         * tui/tui-source.c (tui_source_window_base::reset): Remove
4263         win_type parameter.
4264         * tui/tui-layout.c (make_command_window, make_source_window)
4265         (make_disasm_window, make_data_window)
4266         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4267         (reset_locator, show_source_or_disasm_and_command): Update.
4268         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4269         win_type parameter.
4270         (struct tui_source_window_base) <reset>: Likewise.
4271
4272 2019-07-17  Tom Tromey  <tom@tromey.com>
4273
4274         * tui/tui-layout.c (show_source_disasm_command): Use
4275         reset_locator.
4276         (reset_locator): New function.
4277         (init_and_make_win): Remove.
4278         (show_source_or_disasm_and_command): Use reset_locator.
4279
4280 2019-07-17  Tom Tromey  <tom@tromey.com>
4281
4282         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4283         condition.
4284         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4285         Remove condition.
4286         * tui/tui-source.c (tui_source_window_base::reset): New method.
4287         * tui/tui-layout.c (make_command_window): Don't call
4288         init_and_make_win.
4289         (make_source_window, make_disasm_window): Don't call
4290         make_source_or_disasm_window.
4291         (make_data_window): Don't call init_and_make_win.  Change calling
4292         convention.
4293         (show_source_disasm_command, show_data): Simplify.
4294         (make_source_or_disasm_window): Remove.
4295         (show_source_or_disasm_and_command): Simplify.
4296         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4297         (struct tui_source_window_base) <reset>: Likewise.
4298         <execution_info>: Remove initializer.
4299         * tui/tui-data.c (tui_source_window_base): Initialize
4300         execution_info.
4301
4302 2019-07-17  Tom Tromey  <tom@tromey.com>
4303
4304         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4305         variable.
4306
4307 2019-07-17  Tom Tromey  <tom@tromey.com>
4308
4309         * tui/tui.c (tui_rl_other_window): Update.
4310         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4311         superclass method first.  Always iterate over regs_content.
4312         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4313         method.
4314         * tui/tui-win.c (tui_set_focus_command): Update.
4315
4316 2019-07-17  Tom Tromey  <tom@tromey.com>
4317
4318         * tui/tui-win.c (tui_set_focus_command): Rename from
4319         tui_set_focus.  Call tui_enable.
4320         (tui_set_focus_command): Remove.
4321
4322 2019-07-17  Tom Tromey  <tom@tromey.com>
4323
4324         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4325         refresh_window.
4326         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4327         touchwin.
4328         (tui_data_window::refresh_window): Call refresh_window on data
4329         items.  Always call superclass refresh_window.
4330         (tui_win_info::refresh): Remove.
4331         (tui_source_window_base::refresh_window): Update.
4332         (tui_refresh_all): Update.
4333         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4334         refresh_window.
4335         (show_source_or_disasm_and_command): Likewise.
4336         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4337         (struct tui_source_window_base) <refresh>: Likewise.
4338
4339 2019-07-17  Tom Tromey  <tom@tromey.com>
4340
4341         * tui/tui-winsource.c (tui_clear_source_content)
4342         (tui_show_source_content): Update.
4343         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4344         whether content is empty.
4345         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4346         Remove.
4347
4348 2019-07-17  Tom Tromey  <tom@tromey.com>
4349
4350         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4351         window's contents.
4352         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4353         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4354
4355 2019-07-17  Tom Tromey  <tom@tromey.com>
4356
4357         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4358         (struct tui_data_item_window): Update.
4359
4360 2019-07-17  Tom Tromey  <tom@tromey.com>
4361
4362         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4363         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4364         defines.
4365
4366 2019-07-17  Tom Tromey  <tom@tromey.com>
4367
4368         * tui/tui-winsource.h (tui_erase_source_content)
4369         (tui_clear_source_content): Remove "display_prompt" parameter.
4370         * tui/tui-winsource.c (tui_update_source_window_as_is)
4371         (tui_update_source_windows_with_addr): Update.
4372         (tui_clear_source_content): Remove "display_prompt" parameter.
4373         (tui_erase_source_content): Likewise.  Simplify.
4374         (tui_show_source_content): Update.
4375         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4376         * tui/tui-stack.c (tui_show_frame_info): Update.
4377         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4378         Remove defines.
4379
4380 2019-07-17  Tom Tromey  <tom@tromey.com>
4381
4382         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4383         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4384         parameter.
4385         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4386         parameter.
4387
4388 2019-07-17  Tom Tromey  <tom@tromey.com>
4389
4390         * tui/tui-winsource.c (tui_clear_source_content)
4391         (tui_show_source_content, tui_show_exec_info_content)
4392         (tui_clear_exec_info_content): Update.
4393         * tui/tui-stack.c (tui_show_locator_content): Update.
4394         (tui_show_frame_info): Update.
4395         * tui/tui-source.h (tui_source_window): Don't declare.
4396         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4397         from tui_source_is_displayed.
4398         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4399         Remove field.
4400         (struct tui_source_window_base) <content_in_use>: New field.  Now
4401         bool.
4402         (struct tui_source_window) <showing_source_p>: New method.
4403         (TUI_SRC_WIN): Change cast.
4404         * tui/tui-data.c (tui_initialize_static_data): Update.
4405
4406 2019-07-17  Tom Tromey  <tom@tromey.com>
4407
4408         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4409         location_matches_p.
4410         * tui/tui-source.c (tui_source_window::location_matches_p): New
4411         method.
4412         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4413         method.
4414         * tui/tui-data.h (struct tui_source_window_base)
4415         <location_matches_p>: New method.
4416         (struct tui_source_window, struct tui_disasm_window)
4417         <location_matches_p>: Likewise.
4418
4419 2019-07-17  Tom Tromey  <tom@tromey.com>
4420
4421         * tui/tui-win.c (tui_set_win_height_command): Rename from
4422         tui_set_win_height.
4423         (tui_set_win_height_command): Remove.
4424
4425 2019-07-17  Tom Tromey  <tom@tromey.com>
4426
4427         * tui/tui-source.c (tui_source_window): New constructor.  Add
4428         observer.
4429         (~tui_source_window): New destructor.
4430         (tui_source_window::style_changed): New method.
4431         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4432         (tui_attach_detach_observers): Update.
4433         * tui/tui-data.h (struct tui_source_window): Make constructor not
4434         inline.  Add destructor.
4435         (struct tui_source_window) <style_changed>: New method.
4436         <m_observable>: New member.
4437
4438 2019-07-17  Tom Tromey  <tom@tromey.com>
4439
4440         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4441         * tui/tui-win.c (tui_resize_all): Fix typo.
4442
4443 2019-07-17  Tom Tromey  <tom@tromey.com>
4444
4445         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4446         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4447         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4448         * tui/tui-win.c (window_name_completer): Use foreach.
4449         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4450         (update_tab_width): Likewise.
4451         * tui/tui-layout.c (show_layout): Update.
4452         * tui/tui-data.h (class tui_window_iterator): New.
4453         (struct all_tui_windows): New.
4454         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4455
4456 2019-07-17  Tom Tromey  <tom@tromey.com>
4457
4458         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4459         parameter.  Don't reference globals.
4460         (tui_reg_command): Update.
4461
4462 2019-07-17  Tom Tromey  <tom@tromey.com>
4463
4464         * tui/tui-regs.c (tui_show_registers): Simplify.
4465
4466 2019-07-17  Tom Tromey  <tom@tromey.com>
4467
4468         * tui/tui-regs.c (tui_show_registers): Update.
4469         (tui_show_register_group): Add win_info parameter.
4470
4471 2019-07-17  Tom Tromey  <tom@tromey.com>
4472
4473         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4474         Rename from tui_display_reg_element_at_line.
4475         (tui_data_window::display_registers_from_line): Update.
4476         * tui/tui-data.h (struct tui_data_window)
4477         <display_reg_element_at_line>: New method.
4478
4479 2019-07-17  Tom Tromey  <tom@tromey.com>
4480
4481         * tui/tui-regs.h (tui_display_registers_from)
4482         (tui_display_registers_from_line): Don't declare.
4483         * tui/tui-windata.c (tui_data_window::display_all_data)
4484         (tui_data_window::refresh_all)
4485         (tui_data_window::do_scroll_vertical): Update.
4486         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4487         from tui_display_registers_from.
4488         (tui_display_reg_element_at_line): Update.
4489         (tui_data_window::display_registers_from_line): Rename from
4490         tui_display_registers_from_line.
4491         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4492         display_registers_from_line>: New methods.
4493
4494 2019-07-17  Tom Tromey  <tom@tromey.com>
4495
4496         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4497         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4498         from tui_erase_data_content.
4499         (tui_data_window::display_all_data)
4500         (tui_data_window::refresh_all)
4501         (tui_data_window::do_scroll_vertical): Update.
4502         * tui/tui-regs.c (tui_show_registers): Update.
4503         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4504         New method.
4505
4506 2019-07-17  Tom Tromey  <tom@tromey.com>
4507
4508         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4509         declare.
4510         * tui/tui-windata.c
4511         (tui_data_window::delete_data_content_windows): Rename from
4512         tui_delete_data_content_windows.
4513         (tui_data_window::display_all_data)
4514         (tui_data_window::do_scroll_vertical): Update.
4515         * tui/tui-data.h (struct tui_data_window)
4516         <delete_data_content_windows>: New method.
4517
4518 2019-07-17  Tom Tromey  <tom@tromey.com>
4519
4520         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4521         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4522
4523 2019-07-17  Tom Tromey  <tom@tromey.com>
4524
4525         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4526         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4527         from tui_display_all_data.
4528         * tui/tui-win.c
4529         (tui_data_window::do_make_visible_with_new_height): Update.
4530         * tui/tui-regs.c (tui_show_registers): Update.
4531         * tui/tui-layout.c (tui_set_layout): Update.
4532         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4533         method.
4534
4535 2019-07-17  Tom Tromey  <tom@tromey.com>
4536
4537         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4538         * tui/tui-windata.c (tui_display_data_from): Remove.
4539         (tui_data_window::refresh_all): Update.
4540
4541 2019-07-17  Tom Tromey  <tom@tromey.com>
4542
4543         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4544         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4545         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4546         tui_display_registers_from_line.
4547         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4548         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4549         "force_display" parameter.
4550
4551 2019-07-17  Tom Tromey  <tom@tromey.com>
4552
4553         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4554         declare.
4555         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4556         Rename from tui_first_reg_element_no_inline.
4557         (tui_display_reg_element_at_line)
4558         (tui_display_registers_from_line): Update.
4559         * tui/tui-data.h (struct tui_data_window)
4560         <first_reg_element_no_inline>: New method.
4561
4562 2019-07-17  Tom Tromey  <tom@tromey.com>
4563
4564         * tui/tui-windata.c (tui_display_data_from)
4565         (tui_data_window::do_scroll_vertical): Update.
4566         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4567         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4568         Rename from tui_line_from_reg_element_no.
4569         (tui_display_registers_from_line): Update.
4570         * tui/tui-data.h (struct tui_data_window)
4571         <line_from_reg_element_no>: New method.
4572
4573 2019-07-17  Tom Tromey  <tom@tromey.com>
4574
4575         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4576         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4577         tui_last_regs_line_no.
4578         (tui_display_reg_element_at_line)
4579         (tui_display_registers_from_line): Update.
4580         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4581         method.
4582
4583 2019-07-17  Tom Tromey  <tom@tromey.com>
4584
4585         PR tui/24722:
4586         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4587         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4588         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4589         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4590         (tui_update_breakpoint_info): Likewise.
4591         * tui/tui-hooks.c (tui_event_create_breakpoint)
4592         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4593         Update.
4594
4595 2019-07-17  Tom Tromey  <tom@tromey.com>
4596
4597         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4598
4599 2019-07-17  Tom Tromey  <tom@tromey.com>
4600
4601         * tui/tui-winsource.c (tui_update_source_window_as_is)
4602         (tui_update_source_windows_with_addr): Update.
4603         * tui/tui-source.h (tui_set_source_content)
4604         (tui_show_symtab_source): Add "win_info" parameter.
4605         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4606         parameter.
4607         (tui_show_symtab_source): Likewise.
4608
4609 2019-07-17  Tom Tromey  <tom@tromey.com>
4610
4611         * tui/tui-wingeneral.c
4612         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4613
4614 2019-07-17  Tom Tromey  <tom@tromey.com>
4615
4616         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4617         (struct tui_cmd_window) <can_scroll>: New method.
4618         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4619         method.
4620
4621 2019-07-17  Tom Tromey  <tromey@adacore.com>
4622
4623         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4624         do_field_signed>: Rename.  Change type of "value".
4625         * ui-out.c (ui_out::field_signed): Rename from field_int.
4626         Change type of "value".
4627         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4628         type of "value".
4629         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4630         do_field_int.  Change type of "value".
4631         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4632         do_field_int.  Change type of "value".
4633         * tracepoint.c (trace_status_mi, tfind_1)
4634         (print_one_static_tracepoint_marker): Update.
4635         * thread.c (print_thread_info_1, print_selected_thread_frame):
4636         Update.
4637         * stack.c (print_frame, print_frame_info): Update.
4638         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4639         Update.
4640         * source.c (print_source_lines_base): Update.
4641         * skip.c (info_skip_command): Update.
4642         * record-btrace.c (btrace_ui_out_decode_error)
4643         (btrace_call_history_src_line): Update.
4644         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4645         Update.
4646         * progspace.c (print_program_space): Update.
4647         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4648         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4649         do_field_int.  Change type of "value".
4650         * mi/mi-out.c (mi_ui_out::do_table_begin)
4651         (mi_ui_out::do_table_header): Update.
4652         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4653         type of "value".
4654         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4655         (mi_cmd_data_list_changed_registers, output_register)
4656         (mi_cmd_data_read_memory, mi_load_progress)
4657         (mi_cmd_trace_frame_collected): Update.
4658         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4659         Update.
4660         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4661         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4662         (mi_cmd_var_list_children, varobj_update_one): Update.
4663         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4664         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4665         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4666         * inferior.c (print_inferior): Update.
4667         * gdb_bfd.c (print_one_bfd): Update.
4668         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4669         Update.
4670         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4671         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4672         do_field_int.  Change type of "value".
4673         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4674         do_field_int.  Change type of "value".
4675         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4676         (print_one_breakpoint_location, print_it_catch_fork)
4677         (print_one_catch_fork, print_it_catch_vfork)
4678         (print_one_catch_vfork, print_it_catch_solib)
4679         (print_it_catch_exec, print_it_ranged_breakpoint)
4680         (print_mention_watchpoint, print_mention_masked_watchpoint)
4681         (bkpt_print_it, update_static_tracepoint): Update.
4682         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4683         * break-catch-syscall.c (print_it_catch_syscall): Update.
4684         * ada-tasks.c (print_ada_task_info): Update.
4685         * ada-lang.c (print_it_exception, print_mention_exception):
4686         Update.
4687
4688 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4689
4690         PR breakpoints/24541
4691         * gdbarch.c: Regenerate.
4692         * gdbarch.h: Regenerate.
4693         * gdbarch.sh: Adjust return type and parameter types for
4694         'stap_adjust_register'.
4695         (i386_stap_adjust_register): Adjust signature and return new
4696         register name.
4697         * stap-probe.c (stap_parse_register_operand): Adjust use of
4698         'gdbarch_stap_adjust_register'.
4699
4700 2019-07-17  Tom Tromey  <tromey@adacore.com>
4701
4702         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4703         declare VEC.
4704         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4705         std::vector.
4706         (struct s390_process_info): Add initializers.
4707         (s390_add_process): Use new.
4708         (s390_linux_nat_target::low_forget_process): Use delete.
4709         (s390_linux_nat_target::low_new_fork)
4710         (s390_linux_nat_target::stopped_by_watchpoint)
4711         (s390_linux_nat_target::low_prepare_to_resume)
4712         (s390_linux_nat_target::insert_watchpoint)
4713         (s390_linux_nat_target::insert_hw_breakpoint)
4714         (s390_linux_nat_target::remove_watchpoint)
4715         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4716
4717 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4718
4719         * aarch64-fbsd-nat.c: Include regcache.h.
4720         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4721         argument.
4722         (aarch64_fbsd_nat_target::fetch_registers)
4723         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4724         variable.
4725         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4726
4727 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4728
4729         * fbsd-nat.c: Include gdbarch.h.
4730
4731 2019-07-15  Tom Tromey  <tromey@adacore.com>
4732
4733         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4734
4735 2019-07-15  Tom Tromey  <tromey@adacore.com>
4736
4737         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4738         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4739         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4740         * cli-out.c (cli_ui_out::do_field_int): New method.
4741         * ui-out.c (ui_out::field_unsigned): New method.
4742         * symfile.c (generic_load): Use field_unsigned.
4743         (print_transfer_performance): Likewise.
4744         * record-btrace.c (ui_out_field_uint): Remove.
4745         (btrace_call_history_insn_range, btrace_call_history): Use
4746         field_unsigned.
4747         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4748         field_unsigned.
4749         * ui-out.h (class ui_out) <field_unsigned>: New method.
4750         <do_field_unsigned>: Likewise.
4751
4752 2019-07-15  Tom Tromey  <tromey@adacore.com>
4753
4754         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4755         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4756         * target.c (flash_erase_command): Use field_string.
4757         * infrun.c (print_signal_received_reason): Use field_string.
4758         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4759         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4760         field_string.
4761         * ada-tasks.c (print_ada_task_info): Use field_string.
4762
4763 2019-07-15  Tom Tromey  <tromey@adacore.com>
4764
4765         * target.c (flash_erase_command): Use field_core_addr.
4766         * symfile.c (generic_load): Use field_core_addr.
4767         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4768         Use field_core_addr.
4769         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4770         field_core_addr.
4771
4772 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4773
4774         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4775         value if its desired type is smaller than a CORE_ADDR and signed.
4776
4777 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4778
4779         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4780         of changes to field names, and use new is_reference field to
4781         decide if a property is a reference or not.
4782         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4783         field.
4784         (struct dwarf2_property_baton): Update header comment, rename
4785         'referenced_type' to 'property_type' and update comments.
4786         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4787         default property type, store in property baton, update to take
4788         accound of renamed field.
4789         (read_func_scope): Update call to attr_to_dynamic_prop.
4790         (read_array_type): Likewise.
4791         (dwarf2_per_cu_addr_sized_int_type): New function.
4792         (read_subrange_index_type): Move type finding code to
4793         dwarf2_per_cu_addr_sized_int_type.
4794         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4795         (dwarf2_per_cu_addr_type): New function.
4796         (set_die_type): Update calls to attr_to_dynamic_prop.
4797
4798 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4799
4800         * dwarf2read.c (read_subrange_index_type): New function.
4801         (read_subrange_type): Move code into new function and call it.
4802         * gdbtypes.c (create_range_type): Add some asserts.
4803
4804 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4805
4806         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4807         update return statements.
4808         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4809         declaration, and update comment to match.
4810         * gdbtypes.c (resolve_dynamic_array): Update call to
4811         dwarf2_evaluate_property to match new return type.
4812
4813 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4814
4815         * valarith.c (value_subscripted_rvalue): Change lowerbound
4816         parameter type from int to LONGEST.
4817         * value.h (value_subscripted_rvalue): Likewise in declaration.
4818
4819 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4820
4821         * cli/cli-utils.c (info_print_command_completer): New function.
4822         * cli/cli-utils.h: Add 'completer.h' include, and forward
4823         declaration for 'struct cmd_list_element'.
4824         (info_print_command_completer): Declare.
4825         * stack.c (_initialize_stack): Add completer for 'info locals' and
4826         'info args'.
4827         * symtab.c (_initialize_symtab): Add completer for 'info
4828         variables' and 'info functions'.
4829         * NEWS: Mention completion for additional info commands.
4830
4831 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4832
4833         * cli/cli-utils.c (extract_info_print_args): Delete.
4834         (extract_arg_maybe_quoted): Delete.
4835         (info_print_options_defs): New variable.
4836         (make_info_print_options_def_group): New function.
4837         (extract_info_print_options): Define new function.
4838         * cli/cli-utils.h (extract_info_print_args): Delete.
4839         (struct info_print_options): New structure.
4840         (extract_info_print_options): Declare new function.
4841         * stack.c (info_locals_command): Update to use new
4842         extract_info_print_options, also add a header comment.
4843         (info_args_command): Likewise.
4844         * symtab.c (info_variables_command): Likewise.
4845         (info_functions_command): Likewise.
4846
4847 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4848
4849         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4850         to extract string arguments.
4851         * common/common-utils.c (extract_string_maybe_quoted): New function.
4852         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4853
4854 2019-07-11  Tom Tromey  <tromey@adacore.com>
4855
4856         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4857         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4858         * top.h (gdbinit): Don't declare.
4859         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4860         into...
4861         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4862         * top.c (gdb_init): Don't call init_cli_cmds.
4863         (gdbinit): Remove.
4864         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4865
4866 2019-07-11  Tom Tromey  <tromey@adacore.com>
4867
4868         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4869         after it has been moved.
4870
4871 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4872
4873         * valops.c (value_must_coerce_to_target): Change return type to
4874         bool.
4875         * value.h (value_must_coerce_to_target): Likewise.
4876
4877 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4878
4879         * breakpoint.c (is_hardware_watchpoint): Remove
4880         forward-declaration.
4881         (is_masked_watchpoint): Change return type to bool.
4882         (is_tracepoint): Likewise.
4883         (is_breakpoint): Likewise.
4884         (is_hardware_watchpoint): Likewise.
4885         (is_watchpoint): Likewise.
4886         (is_no_memory_software_watchpoint): Likewise.
4887         (is_catchpoint): Likewise.
4888         (breakpoint_1): Make FILTER parameter's return type bool.
4889         is_masked_watchpoint): Change return type to bool.
4890         (save_breakpoints): Make FILTER parameter's return type bool.
4891         * breakpoint.h (is_breakpoint): Change return type to bool.
4892         (is_watchpoint): Likewise.
4893         (is_catchpoint): Likewise.
4894         (is_tracepoint): Likewise.
4895
4896 2019-07-10  Tom Tromey  <tom@tromey.com>
4897
4898         * defs.h: Don't include gdbarch.h.
4899         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4900         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4901         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4902         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4903         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4904         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4905         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4906         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4907         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4908         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4909         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4910         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4911         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4912         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4913         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4914         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4915         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4916         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4917         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4918         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4919         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4920         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4921         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4922         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4923         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4924         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4925         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4926
4927 2019-07-10  Tom Tromey  <tromey@adacore.com>
4928
4929         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4930         * breakpoint.c (init_ada_exception_breakpoint): Register as
4931         bp_catchpoint.
4932         (print_one_breakpoint_location, print_one_breakpoint): Use
4933         is_ada_exception_catchpoint.
4934         * ada-lang.c (class ada_catchpoint_location): Pass
4935         bp_loc_software_breakpoint to bp_location constructor.
4936         (is_ada_exception_catchpoint): New function.
4937
4938 2019-07-10  Tom Tromey  <tromey@adacore.com>
4939
4940         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4941         VEC.
4942         (struct arm_exidx_entry): New method operator<.
4943         (struct arm_exidx_data) <section_maps>: Change type.
4944         (arm_exidx_data_free): Remove.
4945         (arm_exidx_data_key): Change type.  Move lower.
4946         (arm_exidx_new_objfile): Update.
4947         (arm_compare_exidx_entries): Remove.
4948         (arm_find_exidx_entry, _initialize_arm_tdep)
4949
4950 2019-07-10  Tom Tromey  <tromey@adacore.com>
4951
4952         * solib-spu.c (ocl_program_data_key): Change type.
4953         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4954         Update.
4955
4956 2019-07-10  Tom Tromey  <tromey@adacore.com>
4957
4958         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4959         (struct solib_aix_inferior_data) <library_list>: Change type.
4960         (solib_aix_inferior_data_handle): Change type.
4961         (get_solib_aix_inferior_data): Update.
4962         (solib_aix_free_library_list): Remove.
4963         (library_list_start_library): Update.
4964         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4965         return type.
4966         (solib_aix_get_library_list)
4967         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4968         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4969
4970 2019-07-10  Tom Tromey  <tromey@adacore.com>
4971
4972         * solib-dsbt.c (struct dsbt_info): Add initializers.
4973         (solib_dsbt_pspace_data): Change type.
4974         (dsbt_pspace_data_cleanup): Remove.
4975         (get_dsbt_info, _initialize_dsbt_solib): Update.
4976
4977 2019-07-10  Tom Tromey  <tromey@adacore.com>
4978
4979         * spu-tdep.c (spu_overlay_data): Change type.
4980         (spu_get_overlay_table, spu_overlay_new_objfile)
4981         (_initialize_spu_tdep): Update.
4982
4983 2019-07-10  Tom Tromey  <tromey@adacore.com>
4984
4985         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4986         destructor.
4987         (dbx_objfile_data_key): Change type and declare later.
4988         (DBX_SYMFILE_INFO): Rewrite.
4989         * dbxread.c (dbx_objfile_data_key): Change type.
4990         (dbx_symfile_init): Update.
4991         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4992         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4993         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4994
4995 2019-07-10  Tom Tromey  <tromey@adacore.com>
4996
4997         * jit.c (jit_program_space_key): Change type.  Move lower.
4998         (get_jit_program_space_data): Update.
4999         (jit_program_space_data_cleanup): Remove.
5000         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5001         Update.
5002         (struct jit_program_space_data): Add initializers.
5003
5004 2019-07-10  Tom Tromey  <tromey@adacore.com>
5005
5006         * solib-darwin.c (struct darwin_info): Add initializers.
5007         (solib_darwin_pspace_data): Change type.
5008         (darwin_pspace_data_cleanup): Remove.
5009         (get_darwin_info, _initialize_darwin_solib): Update.
5010
5011 2019-07-10  Tom Tromey  <tromey@adacore.com>
5012
5013         * remote-sim.c (struct sim_inferior_data): Add initializers,
5014         constructor, and destructor.
5015         (sim_inferior_data_key): Change type.  Move lower.
5016         (check_for_duplicate_sim_descriptor): Update.
5017         (get_sim_inferior_data): Use new.  Update.
5018         (~sim_inferior_data_cleanup): Rename from
5019         sim_inferior_data_cleanup.  Simplify.
5020         (gdbsim_close_inferior, simulator_command)
5021         (sim_command_completer, _initialize_remote_sim): Update.
5022         (next_pid, INITIAL_PID): Move earlier.
5023
5024 2019-07-10  Tom Tromey  <tromey@adacore.com>
5025
5026         * python/python-internal.h (create_thread_object): Return
5027         gdbpy_ref.
5028         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5029         * python/py-inferior.c (struct threadlist_entry): Add
5030         constructor.
5031         <thread_obj>: Now a gdbpy_ref.
5032         (thread_to_thread_object): Update.
5033         (add_thread_object): Use new.
5034         (delete_thread_object): Use delete.
5035         (infpy_threads): Update.
5036         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5037         GIL.
5038
5039 2019-07-10  Tom Tromey  <tromey@adacore.com>
5040
5041         * valops.c (value_cast): Specialize error message for Ada.
5042
5043 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5044
5045         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5046
5047 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5048
5049         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5050         bpstat_should_step): Return bool, adjust comments.
5051         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5052         bpstat_should_step): Likewise.
5053
5054 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5055
5056         * features/Makefile: Use feature target descriptions for Arm.
5057         * features/arm/arm-core.c: Generate new file.
5058         * features/arm/arm-fpa.c: Likewise.
5059         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5060         * features/arm/arm-m-profile.c: Likewise.
5061         * features/arm/arm-vfpv2.c: Likewise.
5062         * features/arm/arm-vfpv3.c: Likewise.
5063         * features/arm/xscale-iwmmxt.c: Likewise.
5064         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5065
5066 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5067
5068         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5069         ptrace earlier.
5070
5071 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5072
5073         * features/aarch64-pauth.c: Regenerate.
5074
5075 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5076
5077         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5078         bool.
5079         (bpstat_what): Use false instead of 0.
5080
5081 2019-07-09  Pedro Alves  <palves@redhat.com>
5082
5083         * break-catch-throw.c (is_exception_catchpoint): New.
5084         * breakpoint.c (print_one_breakpoint_location): New parameter
5085         'raw_loc'.  Handle it.  Use
5086         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5087         looking at the breakpoint's type.
5088         (print_one_breakpoint): If handling "maint info breakpoints", also
5089         print locations of exception catchpoints.
5090         * breakpoint.h (is_exception_catchpoint): Declare.
5091
5092 2019-07-09  Pedro Alves  <palves@redhat.com>
5093
5094         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5095         "addr" field.
5096         (allocate_location_exception_catchpoint): New.
5097         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5098         (initialize_throw_catchpoint_ops): Install
5099         allocate_location_exception_catchpoint as allocate_location
5100         method.
5101         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5102         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5103         bp_loc_other.
5104         (breakpoint_address_is_meaningful): Delete.
5105         (bl_address_is_meaningful): New.
5106         (breakpoint_locations_match): Adjust comment.
5107         (bp_location_from_bp_type): New, factored out of...
5108         (bp_location::bp_location(breakpoint *)): ... this.
5109         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5110         factored out of...
5111         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5112         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5113         breakpoint_address_is_meaningful.
5114         (bp_locations_compare): Adjust comment.
5115         (update_global_location_list): Use bl_address_is_meaningful
5116         instead of breakpoint_address_is_meaningful.
5117         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5118         explicit.
5119         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5120         * python/py-breakpoint.c (bppy_get_location): No longer check
5121         whether location is null.
5122
5123 2019-07-09  Pedro Alves  <palves@redhat.com>
5124
5125         PR c++/15468
5126         * breakpoint.c (print_one_breakpoint_location): Remove
5127         single-location assert.
5128
5129 2019-07-09  Tom Tromey  <tom@tromey.com>
5130
5131         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5132         * configure: Rebuild.
5133         * configure.ac: Change common to gdbsupport.
5134         * gdbsupport: Rename from common.
5135         * acinclude.m4: Change common to gdbsupport.
5136         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5137         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5138         gdbsupport.
5139         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5140         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5141         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5142         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5143         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5144         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5145         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5146         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5147         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5148         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5149         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5150         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5151         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5152         coff-pe-read.c, command.h, compile/compile-c-support.c,
5153         compile/compile-c.h, compile/compile-cplus-symbols.c,
5154         compile/compile-cplus-types.c, compile/compile-cplus.h,
5155         compile/compile-loc2c.c, compile/compile.c, completer.c,
5156         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5157         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5158         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5159         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5160         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5161         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5162         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5163         features/aarch64-core.c, features/aarch64-fpu.c,
5164         features/aarch64-pauth.c, features/aarch64-sve.c,
5165         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5166         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5167         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5168         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5169         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5170         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5171         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5172         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5173         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5174         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5175         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5176         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5177         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5178         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5179         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5180         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5181         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5182         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5183         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5184         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5185         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5186         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5187         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5188         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5189         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5190         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5191         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5192         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5193         minsyms.c, mips-linux-tdep.c, namespace.h,
5194         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5195         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5196         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5197         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5198         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5199         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5200         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5201         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5202         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5203         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5204         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5205         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5206         procfs.c, producer.c, progspace.h, psymtab.h,
5207         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5208         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5209         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5210         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5211         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5212         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5213         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5214         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5215         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5216         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5217         target-memory.c, target.c, target.h, target/waitstatus.c,
5218         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5219         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5220         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5221         unittests/array-view-selftests.c,
5222         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5223         unittests/common-utils-selftests.c,
5224         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5225         unittests/format_pieces-selftests.c,
5226         unittests/function-view-selftests.c,
5227         unittests/lookup_name_info-selftests.c,
5228         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5229         unittests/mkdir-recursive-selftests.c,
5230         unittests/observable-selftests.c,
5231         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5232         unittests/parse-connection-spec-selftests.c,
5233         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5234         unittests/scoped_fd-selftests.c,
5235         unittests/scoped_mmap-selftests.c,
5236         unittests/scoped_restore-selftests.c,
5237         unittests/string_view-selftests.c, unittests/style-selftests.c,
5238         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5239         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5240         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5241         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5242         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5243         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5244
5245 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5246
5247         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5248         bool value.
5249         (decode_digits_ordinary): Set explicit_line field in sal.
5250         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5251         symtab_and_line that was set on an explicit line number in
5252         assembler code.  Do always update the recorded symtab and line if
5253         we do skip the prologue.
5254
5255 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5256
5257         * breakpoint.c (set_breakpoint_location_function): Remove
5258         explicit_loc parameter.
5259         (momentary_breakpoint_from_master): Update call to
5260         set_breakpoint_location_function.
5261         (add_location_to_breakpoint): Likewise.
5262
5263 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5264
5265         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5266         required features based on default bfd type when no specific bfd
5267         is present.
5268
5269 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5270
5271         * NEWS: Mention that GDB printf and eval commands can now print
5272         C-style and Ada-style convenience var strings without
5273         calling the inferior.
5274         * printcmd.c (printf_c_string): Locally print GDB internal var
5275         instead of transiting via the inferior.
5276         (printf_wide_c_string): Likewise.
5277
5278 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5279
5280         PR breakpoints/25011
5281         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5282
5283 2019-07-04  Tom Tromey  <tom@tromey.com>
5284
5285         PR tui/24724:
5286         * tui/tui-winsource.c (tui_clear_source_content): Update.
5287         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5288         (tui_update_breakpoint_info): Update.
5289         (tui_set_exec_info_content): Update.
5290         * tui/tui-source.c (tui_set_source_content_nil): Update.
5291         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5292         has_break.
5293         * tui/tui-data.h (enum tui_bp_flag): New.
5294         (tui_bp_flags): New enum flags type.
5295         (struct tui_source_element) <break_mode>: Change type.  Rename
5296         from has_break.
5297         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5298         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5299         constants.
5300         * tui/tui-winsource.h: Fix comment.
5301
5302 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5303
5304         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5305         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5306         (store_fpregs_to_thread)
5307         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5308         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5309         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5310         (IWMMXT_REGS_SIZE): Add define.
5311         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5312         (fetch_vfp_regs, store_vfp_regs)
5313         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5314         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5315
5316 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5317
5318         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5319         defines.
5320         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5321         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5322         (ARM_INT_REGISTER_SIZE): ...to this.
5323         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5324         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5325         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5326         (arm_linux_collect_gregset, supply_nwfpe_register)
5327         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5328         defines.
5329         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5330         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5331         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5332         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5333         (arm_return_in_memory, arm_store_return_value)
5334         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5335         (arm_record_ld_st_multiple): Likewise.
5336         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5337         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5338
5339 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5340
5341         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5342         AARCH64_DISPLACED_MODIFIED_INSNS.
5343         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5344         (aarch64_displaced_step_copy_insn): Likewise.
5345         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5346         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5347         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5348         ARM_DISPLACED_MODIFIED_INSNS.
5349         * arm-tdep.c (arm_gdbarch_init): Likewise.
5350         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5351         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5352         (struct arm_displaced_step_closure): Use
5353         ARM_DISPLACED_MODIFIED_INSNS.
5354
5355 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5356
5357         * features/Makefile: Remove unused xml files.
5358         * features/aarch64.xml: Remove.
5359         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5360         * features/i386/amd64-avx-avx512.xml: Remove.
5361         * features/i386/amd64-avx-linux.xml: Remove.
5362         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5363         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5364         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5365         * features/i386/amd64-avx-mpx.xml: Remove.
5366         * features/i386/amd64-avx.xml: Remove.
5367         * features/i386/amd64-linux.xml: Remove.
5368         * features/i386/amd64-mpx-linux.xml: Remove.
5369         * features/i386/amd64-mpx.xml: Remove.
5370         * features/i386/amd64.xml: Remove.
5371         * features/i386/i386-avx-avx512-linux.xml: Remove.
5372         * features/i386/i386-avx-avx512.xml: Remove.
5373         * features/i386/i386-avx-linux.xml: Remove.
5374         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5375         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5376         * features/i386/i386-avx-mpx-linux.xml: Remove.
5377         * features/i386/i386-avx-mpx.xml: Remove.
5378         * features/i386/i386-avx.xml: Remove.
5379         * features/i386/i386-linux.xml: Remove.
5380         * features/i386/i386-mmx-linux.xml: Remove.
5381         * features/i386/i386-mmx.xml: Remove.
5382         * features/i386/i386-mpx-linux.xml: Remove.
5383         * features/i386/i386-mpx.xml: Remove.
5384         * features/i386/i386.xml: Remove.
5385         * features/i386/x32-avx-avx512-linux.xml: Remove.
5386         * features/i386/x32-avx-linux.xml: Remove.
5387         * features/i386/x32-linux.xml: Remove.
5388
5389 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5390
5391         * regformats/aarch64.dat: Remove.
5392         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5393         * regformats/i386/amd64-avx-linux.dat: Remove.
5394         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5395         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5396         * regformats/i386/amd64-linux.dat: Remove.
5397         * regformats/i386/amd64-mpx-linux.dat: Remove.
5398         * regformats/i386/amd64.dat: Remove.
5399         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5400         * regformats/i386/i386-avx-linux.dat: Remove.
5401         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5402         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5403         * regformats/i386/i386-linux.dat: Remove.
5404         * regformats/i386/i386-mmx-linux.dat: Remove.
5405         * regformats/i386/i386-mpx-linux.dat: Remove.
5406         * regformats/i386/i386.dat: Remove.
5407         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5408         * regformats/i386/x32-avx-linux.dat: Remove.
5409         * regformats/i386/x32-linux.dat: Remove.
5410
5411 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5412
5413         * aarch64-tdep.c: Remove xml self tests.
5414         * amd64-linux-tdep.c: Likewise.
5415         * amd64-tdep.c: Likewise.
5416         * i386-linux-tdep.c: Likewise.
5417         * i386-tdep.c: Likewise.
5418
5419 2019-07-03  Pedro Alves  <palves@redhat.com>
5420
5421         PR cli/24732
5422         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5423         (pipe_cmd_option_defs): New.
5424         (make_pipe_cmd_options_def_group): New.
5425         (pipe_command): Use gdb::option::process_options.
5426         (pipe_command_completer): New function.
5427         (_initialize_cli_cmds): Install completer for "pipe" command.
5428
5429 2019-07-03  Pedro Alves  <palves@redhat.com>
5430
5431         * cli/cli-option.c (union option_value) <string>: New field.
5432         (struct option_def_and_value): Add ctor, move ctor, dtor and
5433         use DISABLE_COPY_AND_ASSIGN.
5434         (option_def_and_value::clear_value): New.
5435         (parse_option, save_option_value_in_ctx, get_val_type_str)
5436         (add_setshow_cmds_for_options): Handle var_string.
5437         * cli-option.h (union option_def::var_address) <string>: New
5438         field.
5439         (struct string_option_def): New.
5440         * maint-test-options.c (struct test_options_opts): Add default
5441         ctor and use DISABLE_COPY_AND_ASSIGN.
5442         <string_opt>: New field.
5443         (test_options_opts::~test_options_opts): New.
5444         (test_options_opts::dump): Also dump "-string".
5445         (test_options_option_defs): Install "string.
5446
5447 2019-07-03  Pedro Alves  <palves@redhat.com>
5448
5449         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5450         option_value with a null enumeration.
5451         (complete_options): Save the option values in the context.
5452         (save_option_value_in_ctx): New, factored out from ...
5453         (process_options): ... here.
5454         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5455         of the function.
5456         * maint-test-options.c (test_options_opts::dump): New, factored
5457         out from ...
5458         (maintenance_test_options_command_mode): ... here.
5459         (maintenance_test_options_command_completion_result): Delete.
5460         (maintenance_test_options_command_completion_text): Update
5461         comment.
5462         (maintenance_show_test_options_completion_result): Change
5463         prototype.  Just print
5464         maintenance_test_options_command_completion_text.
5465         (save_completion_result): New.
5466         (maintenance_test_options_completer_mode): Pass options context to
5467         complete_options, and then save a dump.
5468         (_initialize_maint_test_options): Use add_cmd to install "maint
5469         show test-options-completion-result".
5470
5471 2019-07-03  Pedro Alves  <palves@redhat.com>
5472
5473         * NEWS (New commands): Mention "with" and "maint with".
5474         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5475         (with_command, with_command_completer): New.
5476         (pipe_command): Adjust to new repeat_previous
5477         interface.
5478         (_initialize_cli_cmds): Install the "with" command and its "w"
5479         alias.
5480         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5481         declarations.
5482         * cli/cli-setshow.c (parse_cli_var_uinteger)
5483         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5484         argument strings for all var_types.
5485         (get_setshow_command_value_string): New, factored out from ...
5486         (do_show_command): ... this.
5487         * cli/cli-setshow.h: Include <string>.
5488         (get_setshow_command_value_string): Declare.
5489         * command.h (repeat_previous): Now returns const char *.  Adjust
5490         comment.
5491         * maint.c: Include "cli/cli-cmds.h".
5492         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5493         (_initialize_maint_cmds): Register the "maintenance with" command.
5494         * top.c (repeat_previous): Move bits from pipe_command here:
5495         Return the saved command line, if any; error out if there's no
5496         command to relaunch.
5497
5498 2019-07-03  Pedro Alves  <palves@redhat.com>
5499
5500         * NEWS (New commands): Mention "maint set/show test-settings"
5501         instead of "maint test-settings".
5502         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5503         (maintenance_test_settings_set_list): Rename to ...
5504         (maintenance_set_test_settings_list): ... this.
5505         (maintenance_test_settings_show_list): Rename to  ...
5506         (maintenance_show_test_settings_list): ... this.
5507         (maintenance_test_settings_cmd): Delete.
5508         (maintenance_test_settings_set_cmd): ...
5509         (maintenance_set_test_settings_cmd): ... this.
5510         (maintenance_test_settings_show_cmd): ...
5511         (maintenance_show_test_settings_cmd): ... this.
5512         (maintenance_test_settings_show_value_cmd):
5513         (maintenance_show_test_settings_value_cmd): ... this.
5514         (_initialize_maint_test_settings): No longer install the "maint
5515         test-settings" prefix command.  Rename "maint test-settings set"
5516         to "maint set test-settings", and "maint test-settings show" to
5517         "maint show test-settings".  Adjust all subcommands.
5518
5519 2019-07-03  Pedro Alves  <palves@redhat.com>
5520
5521         * maint-test-settings.c: Fix file's intro comment.  Replace all
5522         references to "test-options" with references to "test-settings",
5523         in comments.
5524
5525 2019-07-03  Pedro Alves  <palves@redhat.com>
5526
5527         * maint-test-settings.c (maintenance_test_settings_xxx)
5528         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5529         New.
5530         (maintenance_test_settings_enums): Use them.
5531         (maintenance_test_settings_enum): Default to
5532         maintenance_test_settings_xxx.
5533         (_initialize_maint_test_settings): Initialize
5534         MAINTENANCE_TEST_SETTINGS_FILENAME.
5535
5536 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5537
5538         * breakpoint.h (remove_breakpoints_inf): Change return type to
5539         void, move function documentation here.
5540         * breakpoint.c (remove_breakpoints_inf): Change return type to
5541         void, move function documentation to header.
5542
5543 2019-07-02  Pedro Alves  <palves@redhat.com>
5544
5545         * NEWS (Completion improvements): Mention "info threads".
5546         * thread.c (struct info_threads_opts, info_threads_option_defs)
5547         (make_info_threads_options_def_group): New.
5548         (info_threads_command): Use gdb::option::process_options.
5549         (info_threads_command_completer): New.
5550         (_initialize_thread): Use gdb::option::build_help to build the
5551         help text for "info threads".
5552
5553 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5554
5555         * defs.h (generic_load): Move from here...
5556         * symfile.h (generic_load): ... to here.  Rename name parameter
5557         to args.
5558         * symfile.c (generic_load): Add comment.
5559
5560 2019-07-01  Tom Tromey  <tromey@adacore.com>
5561
5562         * dwarf2read.c
5563         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5564         declaration of without_params.  Fix formatting.
5565
5566 2019-07-01  Tom Tromey  <tromey@adacore.com>
5567
5568         * ada-exp.y (find_primitive_type): Update.
5569         * ada-lang.h (ada_lookup_symbol): Update.
5570         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5571         parameter.
5572         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5573
5574 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5575
5576         PR breakpoints/24541
5577         * gdbarch.c: Regenerate.
5578         * gdbarch.h: Regenerate.
5579         * gdbarch.sh: Add 'stap_adjust_register'.
5580         * i386-tdep.c: Include '<unordered_set>'.
5581         (i386_stap_adjust_register): New function.
5582         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5583         * stap-probe.c (stap_parse_register_operand): Call
5584         'gdbarch_stap_adjust_register'.
5585
5586 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5587
5588         PR python/24742
5589         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5590         * python/python.c (do_start_initialization): Use 'xmalloc'
5591         instead of 'PyMem_Malloc'.
5592
5593 2019-06-28  Tom Tromey  <tromey@adacore.com>
5594
5595         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5596         for Ada.
5597
5598 2019-06-27  Tom Tromey  <tromey@adacore.com>
5599
5600         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5601         objfile_key.
5602         (arm_find_mapping_symbol, arm_record_special_symbol)
5603         (_initialize_arm_tdep): Update.
5604         (arm_objfile_data_free): Remove.
5605
5606 2019-06-27  Tom Tromey  <tromey@adacore.com>
5607
5608         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5609         to cp_print_static_field.
5610
5611 2019-06-26  Tom Tromey  <tromey@adacore.com>
5612
5613         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5614         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5615         declare.
5616
5617 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5618
5619         * features/aarch64-core.c (create_feature_aarch64_core):
5620         Regenerate.
5621         * features/aarch64-core.xml: Add cpsr flags.
5622
5623 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5624
5625         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5626         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5627
5628 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5629
5630         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5631         field.
5632         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5633         use.
5634         (arm_record_special_symbol): Don't insert new symbol in sorted
5635         position, push it at the end.
5636
5637 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5638
5639         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5640         (arm_mapping_symbol_s): Remove.
5641         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5642         (arm_mapping_symbol_vec): New typedef.
5643         (struct arm_per_objfile): Add constructor.
5644         <section_maps>: Change type to
5645         std::unique_ptr<arm_mapping_symbol_vec[]>.
5646         (arm_compare_mapping_symbols): Remove.
5647         (arm_find_mapping_symbol): Adjust to section_maps type change.
5648         (arm_objfile_data_free): Call delete on arm_per_objfile.
5649         (arm_record_special_symbol): Adjust to section_maps type change.
5650         Allocate arm_per_objfile with new.
5651
5652 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5653
5654         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5655         with the command prefix.
5656
5657 2019-06-25  Tom Tromey  <tom@tromey.com>
5658
5659         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5660         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5661
5662 2019-06-25  Tom Tromey  <tom@tromey.com>
5663
5664         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5665         type.
5666         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5667         protected.
5668
5669 2019-06-25  Tom Tromey  <tom@tromey.com>
5670
5671         * tui/tui-winsource.c
5672         (tui_source_window_base::set_is_exec_point_at): Add check against
5673         LOA_ADDRESS.
5674
5675 2019-06-25  Tom Tromey  <tom@tromey.com>
5676
5677         * tui/tui-source.c (tui_set_source_content): Don't check before
5678         xfree.
5679         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5680
5681 2019-06-25  Tom Tromey  <tom@tromey.com>
5682
5683         * tui/tui-winsource.h (tui_update_source_window_as_is)
5684         (tui_alloc_source_buffer, tui_line_is_displayed)
5685         (tui_addr_is_displayed): Change type of win_info.
5686         * tui/tui-winsource.c (tui_update_source_window_as_is)
5687         (tui_clear_source_content, tui_show_source_line)
5688         (tui_show_source_content, tui_source_window_base::refill)
5689         (tui_source_window_base::set_is_exec_point_at)
5690         (tui_source_window_base::set_is_exec_point_at)
5691         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5692         (tui_alloc_source_buffer, tui_line_is_displayed)
5693         (tui_addr_is_displayed): Change type of win_info.  Update.
5694         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5695         (tui_source_window_base::do_make_visible_with_new_height):
5696         Update.
5697         * tui/tui-source.c (tui_set_source_content)
5698         (tui_set_source_content_nil)
5699         (tui_source_window::do_scroll_vertical): Update.
5700         * tui/tui-layout.c (show_layout): Update.
5701         * tui/tui-disasm.c (tui_set_disassem_content)
5702         (tui_disasm_window::do_scroll_vertical): Update.
5703         * tui/tui-data.h (tui_win_content): Remove.
5704         (struct tui_gen_win_info) <content, content_size>: Remove.
5705         (struct tui_source_element): Add initializers and destructor.
5706         (union tui_which_element, struct tui_win_element): Remove.
5707         (struct tui_source_window_base) <content>: New field.
5708         (struct tui_data_window): Remove destructor.
5709         (tui_alloc_content, tui_free_win_content)
5710         (tui_free_all_source_wins_content): Don't declare.
5711         * tui/tui-data.c (tui_initialize_static_data): Update.
5712         (init_content_element, tui_alloc_content): Remove.
5713         (~tui_gen_win_info): Update.
5714         (~tui_data_window, tui_free_all_source_wins_content)
5715         (tui_free_win_content, free_content, free_content_elements):
5716         Remove.
5717
5718 2019-06-25  Tom Tromey  <tom@tromey.com>
5719
5720         * tui/tui-winsource.h (tui_clear_source_content)
5721         (tui_erase_source_content, tui_show_source_content): Change type
5722         of win_info.
5723         * tui/tui-winsource.c (tui_clear_source_content)
5724         (tui_erase_source_content, tui_show_source_content): Change type
5725         of win_info.
5726         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5727         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5728         win_info.
5729         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5730         win_info.
5731         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5732
5733 2019-06-25  Tom Tromey  <tom@tromey.com>
5734
5735         * tui/tui-winsource.c (tui_clear_source_content)
5736         (tui_source_window_base::set_is_exec_point_at): Update.
5737         * tui/tui-source.c (tui_set_source_content_nil): Update.
5738         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5739         a bool.
5740         * tui/tui-data.c (init_content_element): Update.
5741
5742 2019-06-25  Tom Tromey  <tom@tromey.com>
5743
5744         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5745         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5746         * tui/tui-layout.c (init_and_make_win): Update.
5747         * tui/tui.h (enum tui_win_type): Update.
5748         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5749         tui_win_is_auxillary.
5750         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5751         tui_win_is_auxillary.
5752
5753 2019-06-25  Tom Tromey  <tom@tromey.com>
5754
5755         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5756         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5757         (tui_delete_data_content_windows, tui_display_all_data)
5758         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5759         Update.
5760         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5761         * tui/tui-regs.c (tui_last_regs_line_no)
5762         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5763         (tui_show_registers): Update.
5764         (tui_show_register_group): Return void.  Update.
5765         (tui_display_registers_from, tui_display_reg_element_at_line)
5766         (tui_display_registers_from_line, tui_check_register_values):
5767         Update.
5768         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5769         member.
5770         (struct tui_data_window) <regs_content>: Now a std::vector.
5771         <regs_content_count>: Remove.
5772         (tui_add_content_elements, tui_free_data_content): Don't declare.
5773         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5774         (init_content_element): Remove DATA_WIN case.  Add assert.
5775         (tui_add_content_elements): Remove.
5776         (tui_data_window): Update.
5777         (tui_free_data_content): Remove.
5778         (free_content_elements): Remove DATA_WIN case.
5779
5780 2019-06-25  Tom Tromey  <tom@tromey.com>
5781
5782         * tui/tui-data.c (tui_data_item_window): Update.
5783         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5784         * tui/tui-windata.c (tui_display_all_data)
5785         (tui_display_data_from_line): Update.
5786         (tui_check_data_values): Remove.
5787         * tui/tui-regs.c (tui_show_register_group)
5788         (tui_display_reg_element_at_line): Update.
5789         * tui/tui-hooks.c (tui_register_changed)
5790         (tui_refresh_frame_and_register_information): Call
5791         tui_check_register_values.
5792         * tui/tui-data.h (struct tui_data_window) <data_content,
5793         data_content_count, data_type>: Remove.
5794         (enum tui_data_type): Remove.
5795
5796         * tui/tui-data.c (tui_data_window::clear_detail)
5797         (~tui_data_window): Update.
5798
5799 2019-06-25  Tom Tromey  <tom@tromey.com>
5800
5801         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5802         declare.
5803         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5804         Rename from tui_first_data_item_displayed.  Update.
5805         (tui_data_window::refresh_all)
5806         (tui_data_window::do_scroll_vertical): Update.
5807         * tui/tui-data.h (struct tui_data_window)
5808         <first_data_item_displayed>: Declare new method.
5809
5810 2019-06-25  Tom Tromey  <tom@tromey.com>
5811
5812         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5813         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5814         contents...
5815         (tui_initialize_static_data): ...here.
5816
5817 2019-06-25  Tom Tromey  <tom@tromey.com>
5818
5819         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5820         (tui_display_registers_from, tui_check_register_values): Update.
5821         (tui_display_register): Remove win_info parameter; update.
5822         (tui_get_register): Change type of parameters.
5823         * tui/tui-data.h (struct tui_data_element): Remove.
5824         (union tui_which_element) <data>: Remove.
5825         <data_window>: Change type.
5826         (struct tui_data_item_window): New.
5827         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5828         case.  Add assert.
5829         (~tui_data_item_window): New destructor.
5830         (free_content_elements): Remove DATA_ITEM_WIN case.
5831
5832 2019-06-25  Tom Tromey  <tom@tromey.com>
5833
5834         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5835         Remove.
5836
5837 2019-06-25  Tom Tromey  <tom@tromey.com>
5838
5839         * tui/tui-data.h (struct tui_command_element): Remove.
5840         (union tui_which_element) <command>: Remove.
5841         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5842         assert.
5843         (free_content_elements): Remove CMD_WIN case.
5844
5845 2019-06-25  Tom Tromey  <tom@tromey.com>
5846
5847         * tui/tui-layout.c (tui_set_layout): Update.
5848         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5849         * tui/tui-data.c (layout_def): Update.
5850
5851 2019-06-25  Tom Tromey  <tom@tromey.com>
5852
5853         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5854         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5855         (tui_source_window_base::set_new_height): Update.
5856         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5857         Update.
5858         (tui_set_locator_fullname, tui_set_locator_info)
5859         (tui_show_frame_info): Update.
5860         * tui/tui-source.c (tui_set_source_content)
5861         (tui_source_is_displayed): Update.
5862         * tui/tui-layout.c (show_source_disasm_command, show_data)
5863         (show_source_or_disasm_and_command): Update.
5864         * tui/tui-disasm.c (tui_set_disassem_content)
5865         (tui_get_begin_asm_address): Update.
5866         * tui/tui-data.h (struct tui_locator_element): Remove.
5867         (union tui_which_element) <locator>: Remove.
5868         (struct tui_locator_window): New.
5869         (tui_locator_win_info_ptr): Change return type.
5870         * tui/tui-data.c (_locator): Change type.
5871         (tui_locator_win_info_ptr): Change return type.
5872         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5873         (tui_alloc_content): Add assert.
5874
5875 2019-06-25  Tom Tromey  <tom@tromey.com>
5876
5877         * tui/tui-winsource.c
5878         (tui_exec_info_window::maybe_allocate_content): New method.
5879         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5880         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5881         (make_source_or_disasm_window): Add cast.
5882         * tui/tui-data.h (union tui_which_element) <simple_string>:
5883         Remove.
5884         (struct tui_source_info): New.
5885         (struct tui_source_window_base) <execution_info>: Change type.
5886         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5887         case, and add assert.
5888         (tui_alloc_content): Add assert.
5889
5890 2019-06-25  Tom Tromey  <tom@tromey.com>
5891
5892         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5893         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5894         * tui/tui-data.c (tui_alloc_win_info): Remove.
5895
5896 2019-06-25  Tom Tromey  <tom@tromey.com>
5897
5898         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5899         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5900         can_highlight.
5901
5902 2019-06-25  Tom Tromey  <tom@tromey.com>
5903
5904         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5905         make_visible_with_new_height method.
5906         (tui_win_info::make_visible_with_new_height): New method.
5907         (tui_source_window_base::do_make_visible_with_new_height)
5908         (tui_data_window::do_make_visible_with_new_height)
5909         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5910         (make_visible_with_new_height): Remove.
5911         (tui_resize_all, tui_adjust_win_heights): Use
5912         make_visible_with_new_height method.
5913         * tui/tui-data.h (struct tui_win_info)
5914         <do_make_visible_with_new_height, make_visible_with_new_height>:
5915         New methods.
5916         (struct tui_source_window_base, struct tui_data_window)
5917         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5918         methods.
5919
5920 2019-06-25  Tom Tromey  <tom@tromey.com>
5921
5922         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5923         method.
5924         (update_tab_width): Call update_tab_width method.
5925         * tui/tui-data.h (struct tui_win_info)
5926         (struct tui_source_window_base) <update_tab_width>: New methods.
5927
5928 2019-06-25  Tom Tromey  <tom@tromey.com>
5929
5930         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5931         parameter.
5932         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5933         parameter.
5934         (tui_gen_win_info::make_visible): Update.
5935         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5936         parameter.
5937         * tui/tui-data.h (enum tui_box): New enum.
5938         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5939
5940 2019-06-25  Tom Tromey  <tom@tromey.com>
5941
5942         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5943         init_and_make_win for EXEC_INFO_WIN.
5944         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5945         longer inline.
5946         (struct tui_win_info) <~tui_win_info>: Inline.
5947         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5948         Don't declare.
5949         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5950         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5951         Remove.
5952         (tui_initialize_static_data): Update.
5953         (~tui_gen_win_info): Handle more cleanup here.
5954         (~tui_source_window_base): Delete "execution_info".
5955         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5956
5957 2019-06-25  Tom Tromey  <tom@tromey.com>
5958
5959         * tui/tui-layout.c (make_command_window): Don't set
5960         can_highlight.
5961         (show_source_disasm_command): Call the reset method.
5962         (show_data): Don't set can_highlight.  Call the reset method.
5963         (tui_gen_win_info::reset): Rename from init_gen_win_info
5964         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5965         (show_source_or_disasm_and_command): Call the reset method.
5966         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5967         (struct tui_cmd_window): Set can_highlight.
5968
5969 2019-06-25  Tom Tromey  <tom@tromey.com>
5970
5971         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5972         from make_visible.
5973         (tui_make_visible, tui_make_invisible): Rewrite.
5974         (tui_win_info::make_visible): Remove.
5975         (tui_source_window_base::make_visible): Update.
5976         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5977         method.  Moved from...
5978         (struct tui_win_info) <make_visible>: ...here.
5979
5980 2019-06-25  Tom Tromey  <tom@tromey.com>
5981
5982         * tui/tui-winsource.c
5983         (tui_source_window_base::do_scroll_horizontal): Remove direction
5984         parameter.
5985         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5986         direction parameter.
5987         * tui/tui-win.c (tui_win_info::forward_scroll)
5988         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5989         (tui_win_info::right_scroll): Update.
5990         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5991         direction parameter.
5992         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5993         direction parameter.
5994         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5995         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5996         Remove direction parameter.
5997         (struct tui_source_window_base, struct tui_source_window)
5998         (struct tui_disasm_window, struct tui_data_window)
5999         (struct tui_cmd_window): Update.
6000
6001 2019-06-25  Tom Tromey  <tom@tromey.com>
6002
6003         * tui/tui-winsource.h (tui_set_exec_info_content)
6004         (tui_show_exec_info_content, tui_erase_exec_info_content)
6005         (tui_clear_exec_info_content, tui_update_exec_info): Change
6006         argument to tui_source_window_base.
6007         * tui/tui-winsource.c (tui_set_exec_info_content)
6008         (tui_show_exec_info_content, tui_erase_exec_info_content)
6009         (tui_clear_exec_info_content, tui_update_exec_info): Change
6010         argument to tui_source_window_base.
6011
6012 2019-06-25  Tom Tromey  <tom@tromey.com>
6013
6014         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6015         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6016
6017 2019-06-25  Tom Tromey  <tom@tromey.com>
6018
6019         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6020         check.
6021
6022 2019-06-25  Tom Tromey  <tom@tromey.com>
6023
6024         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6025         type to void.
6026         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6027         type to void.
6028         * tui/tui-source.c (tui_set_source_content): Update.
6029         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6030
6031 2019-06-25  Tom Tromey  <tom@tromey.com>
6032
6033         * tui/tui-win.c (window_name_completer, tui_set_focus)
6034         (tui_all_windows_info): Use name method.
6035         * tui/tui-data.h (struct tui_gen_win_info)
6036         (struct tui_source_window, struct tui_disasm_window)
6037         (struct tui_data_window, struct tui_cmd_window) <name>: New
6038         method.
6039         (tui_win_name): Don't declare.
6040         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6041         (tui_win_name): Remove.
6042
6043 2019-06-25  Tom Tromey  <tom@tromey.com>
6044
6045         * tui/tui-winsource.h (tui_update_source_window)
6046         (tui_update_source_window_as_is): Change parameter type.
6047         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6048         to be a tui_source_window_base.
6049         (tui_update_source_window_as_is): Likewise.
6050         * tui/tui-win.c (make_visible_with_new_height): Update.
6051
6052 2019-06-25  Tom Tromey  <tom@tromey.com>
6053
6054         * tui/tui-winsource.c (tui_erase_source_content)
6055         (tui_show_source_content, tui_show_exec_info_content)
6056         (tui_erase_exec_info_content): Use refresh_window method.
6057         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6058         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6059         from tui_refresh_win.
6060         (tui_data_window::refresh_window): New method.
6061         (tui_win_info::refresh, tui_source_window_base::refresh)
6062         (tui_refresh_all): Use refresh_window method.
6063         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6064         method.
6065         * tui/tui-regs.c (tui_display_register): Call refresh_window
6066         method.
6067         * tui/tui-layout.c (show_source_disasm_command)
6068         (show_source_or_disasm_and_command): Call refresh_window method.
6069         * tui/tui-data.h (struct tui_gen_win_info)
6070         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6071         New method.
6072
6073 2019-06-25  Tom Tromey  <tom@tromey.com>
6074
6075         * tui/tui.c (tui_rl_other_window, tui_enable)
6076         (tui_is_window_visible, tui_get_command_dimension): Update.
6077         * tui/tui-winsource.c (tui_update_source_window_as_is)
6078         (tui_clear_source_content, tui_erase_source_content)
6079         (tui_show_source_line, tui_source_window_base::refill)
6080         (tui_source_window_base::do_scroll_horizontal)
6081         (tui_source_window_base::set_is_exec_point_at)
6082         (tui_update_breakpoint_info, tui_set_exec_info_content)
6083         (tui_alloc_source_buffer, tui_line_is_displayed)
6084         (tui_addr_is_displayed): Update.
6085         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6086         (tui_check_and_display_highlight_if_needed)
6087         (tui_win_info::make_visible, tui_win_info::refresh)
6088         (tui_refresh_all): Update.
6089         * tui/tui-windata.c (tui_first_data_item_displayed)
6090         (tui_delete_data_content_windows, tui_erase_data_content)
6091         (tui_display_all_data, tui_data_window::refresh_all)
6092         (tui_check_data_values): Update.
6093         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6094         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6095         (tui_win_info::backward_scroll, tui_refresh_all_win)
6096         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6097         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6098         (tui_source_window_base::set_new_height)
6099         (tui_data_window::set_new_height)
6100         (make_invisible_and_set_new_height)
6101         (make_visible_with_new_height, new_height_ok)
6102         (parse_scrolling_args): Update.
6103         * tui/tui-stack.c (tui_show_frame_info): Update.
6104         * tui/tui-source.c (tui_set_source_content)
6105         (tui_set_source_content_nil, tui_source_is_displayed)
6106         (tui_source_window::do_scroll_vertical): Update.
6107         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6108         (tui_display_registers_from, tui_display_reg_element_at_line)
6109         (tui_check_register_values, tui_reg_command): Update.
6110         * tui/tui-layout.c (tui_default_win_height)
6111         (show_source_disasm_command, show_data, init_and_make_win)
6112         (show_source_or_disasm_and_command): Update.
6113         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6114         (tui_redisplay_readline, tui_mld_flush)
6115         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6116         (tui_getc): Update.
6117         * tui/tui-disasm.c (tui_set_disassem_content)
6118         (tui_disasm_window::do_scroll_vertical): Update.
6119         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6120         Now virtual.
6121         (struct tui_win_info): Derive from tui_gen_win_info.
6122         <~tui_win_info>: Mark as override.
6123         <generic>: Remove member.
6124         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6125         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6126         (~tui_data_window, ~tui_win_info)
6127         (tui_free_all_source_wins_content): Update.
6128         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6129
6130 2019-06-25  Tom Tromey  <tom@tromey.com>
6131
6132         * tui/tui-layout.c (init_and_make_win): Use new.
6133         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6134         destructor, initializers.
6135         (tui_alloc_generic_win_info): Don't declare.
6136         * tui/tui-data.c (_locator): Add argument to constructor.
6137         (source_win, disasm_win): New globals.
6138         (exec_info): Remove.
6139         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6140         Update.
6141         (tui_alloc_generic_win_info): Remove.
6142         (init_content_element): Use new.
6143         (tui_win_info::tui_win_info): Update.
6144         (free_content_elements) <case DATA_WIN>: Use delete.
6145
6146 2019-06-25  Tom Tromey  <tom@tromey.com>
6147
6148         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6149         * tui/tui-windata.c (tui_first_data_item_displayed)
6150         (tui_delete_data_content_windows): Update.
6151         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6152         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6153         (tui_display_registers_from, tui_check_register_values): Update.
6154         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6155         pointer.
6156         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6157         window.
6158         (tui_free_data_content): Update.
6159         (free_content_elements) <case DATA_WIN>: Free the window.
6160
6161 2019-06-25  Tom Tromey  <tom@tromey.com>
6162
6163         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6164         Update.
6165         * tui/tui-layout.c (make_command_window)
6166         (show_source_disasm_command, show_data, init_and_make_win)
6167         (show_source_or_disasm_and_command): Update.
6168         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6169         method.
6170         <can_highight, is_highlighted>: Now bool.
6171         (tui_set_win_highlight): Don't declare.
6172         * tui/tui-data.c (tui_set_win_highlight): Remove.
6173
6174 2019-06-25  Tom Tromey  <tom@tromey.com>
6175
6176         * tui/tui-wingeneral.c (make_visible): Remove check of window
6177         type.
6178
6179 2019-06-25  Tom Tromey  <tom@tromey.com>
6180
6181         * tui/tui-win.c (tui_win_info::max_height)
6182         (tui_cmd_window::max_height): New methods.
6183         (new_height_ok): Call max_height.
6184         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6185         <max_height>: New method.
6186
6187 2019-06-25  Tom Tromey  <tom@tromey.com>
6188
6189         * tui/tui-win.c (tui_source_window_base::set_new_height)
6190         (tui_data_window::set_new_height): New methods.
6191         (make_invisible_and_set_new_height): Call set_new_height method.
6192         * tui/tui-data.h (struct tui_win_info)
6193         (struct tui_source_window_base, struct tui_data_window)
6194         <set_new_height>: New method.
6195
6196 2019-06-25  Tom Tromey  <tom@tromey.com>
6197
6198         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6199         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6200         tui_refresh_data_win.
6201         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6202         method.
6203         (tui_refresh_all_win): Call the refresh_all method.
6204         (tui_set_focus): Likewise.
6205         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6206         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6207         Likewise.
6208
6209 2019-06-25  Tom Tromey  <tom@tromey.com>
6210
6211         * tui/tui-winsource.h (tui_refill_source_window)
6212         (tui_set_is_exec_point_at): Don't declare.
6213         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6214         (tui_source_window_base::refill): Rename from
6215         tui_refill_source_window.
6216         (tui_source_window_base::do_scroll_horizontal): Update.
6217         (tui_source_window_base::set_is_exec_point_at): Rename from
6218         tui_set_is_exec_point_at.
6219         (tui_update_all_breakpoint_info): Update.
6220         * tui/tui-stack.c (tui_show_frame_info): Update.
6221         * tui/tui-layout.c (show_data): Add cast.
6222         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6223         * tui/tui-data.h (struct tui_source_window_base) <refill,
6224         set_is_exec_point_at>: New methods.
6225         (tui_source_windows, tui_add_to_source_windows): Update types.
6226         (tui_add_to_source_windows): Remove redundant declaration.
6227         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6228         (tui_source_windows): Change return type.
6229         (tui_clear_source_windows_detail): Update.
6230         (tui_add_to_source_windows): Change type of parameter.
6231         (tui_free_all_source_wins_content): Update.
6232
6233 2019-06-25  Tom Tromey  <tom@tromey.com>
6234
6235         * tui/tui-wingeneral.c (tui_win_info::refresh)
6236         (tui_source_window_base::refresh): New methods.
6237         (tui_refresh_all): Call the refresh method.
6238         * tui/tui-data.h (struct tui_win_info)
6239         (struct tui_source_window_base) <refresh>: New method.
6240
6241 2019-06-25  Tom Tromey  <tom@tromey.com>
6242
6243         * tui/tui.h (tui_is_window_visible): Return bool.
6244         * tui/tui.c (tui_is_window_visible): Return bool.
6245         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6246         (tui_make_visible, tui_make_invisible)
6247         (tui_win_info::make_visible)
6248         (tui_source_window_base::make_visible, make_all_visible)
6249         (tui_make_all_visible, tui_make_all_invisible): Update.
6250         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6251         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6252         bool.
6253         (struct tui_win_info, struct tui_source_window_base)
6254         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6255         * tui/tui-data.c (tui_init_generic_part): Update.
6256
6257 2019-06-25  Tom Tromey  <tom@tromey.com>
6258
6259         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6260         (tui_source_window_base::make_visible): New methods.
6261         (make_all_visible): Make method call.
6262         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6263         (struct tui_source_window_base, struct tui_cmd_window): Override
6264         make_visible.
6265         (tui_win_is_source_type): Don't declare.
6266         * tui/tui-data.c (tui_win_is_source_type): Remove.
6267
6268 2019-06-25  Tom Tromey  <tom@tromey.com>
6269
6270         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6271         NULL check.
6272
6273 2019-06-25  Tom Tromey  <tom@tromey.com>
6274
6275         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6276         Inline constructor.  Add initializers for members.
6277         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6278         constructors; now inline in class.
6279
6280 2019-06-25  Tom Tromey  <tom@tromey.com>
6281
6282         * tui/tui-regs.c (tui_show_registers): Update.
6283         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6284         bool.
6285         * tui/tui-data.c (tui_data_window::clear_detail)
6286         (tui_data_window): Update.
6287
6288 2019-06-25  Tom Tromey  <tom@tromey.com>
6289
6290         * tui/tui-windata.c (tui_display_all_data)
6291         (tui_display_data_from_line, tui_display_data_from)
6292         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6293         Update.
6294         * tui/tui-regs.c (tui_last_regs_line_no)
6295         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6296         (tui_show_registers, tui_show_register_group)
6297         (tui_display_registers_from, tui_display_reg_element_at_line)
6298         (tui_display_registers_from_line, tui_check_register_values)
6299         (tui_reg_next, tui_reg_prev): Update.
6300         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6301         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6302         tui_data_window.
6303         (struct tui_win_info) <detail>: Remove.  Add new fields from
6304         tui_data_info.
6305         (TUI_DATA_WIN): Add cast.
6306         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6307         (~tui_data_window): Simplify.
6308
6309 2019-06-25  Tom Tromey  <tom@tromey.com>
6310
6311         * tui/tui-layout.c (show_source_disasm_command)
6312         (show_source_or_disasm_and_command): Update.
6313         * tui/tui-io.c (update_cmdwin_start_line)
6314         (tui_redisplay_readline): Update.
6315         * tui/tui-data.h (struct tui_command_info): Remove.
6316         (struct tui_win_info) <detail>: Remove command_info member.
6317         (struct tui_data_window) <start_line>: New member, from
6318         tui_command_info.
6319         (TUI_CMD_WIN): Add casts.
6320
6321 2019-06-25  Tom Tromey  <tom@tromey.com>
6322
6323         * tui/tui-winsource.c (tui_update_source_window)
6324         (tui_refill_source_window)
6325         (tui_source_window_base::do_scroll_horizontal)
6326         (tui_update_breakpoint_info, tui_set_exec_info_content)
6327         (tui_show_exec_info_content, tui_erase_exec_info_content)
6328         (tui_clear_exec_info_content): Update.
6329         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6330         Update.
6331         * tui/tui-win.c (make_invisible_and_set_new_height)
6332         (make_visible_with_new_height): Update.
6333         * tui/tui-source.c (tui_set_source_content)
6334         (tui_show_symtab_source): Update.
6335         * tui/tui-layout.c (extract_display_start_addr)
6336         (show_source_disasm_command, show_data)
6337         (make_source_or_disasm_window)
6338         (show_source_or_disasm_and_command): Update.
6339         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6340         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6341         "gdbarch".
6342         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6343         to tui_source_window_base.
6344         (struct tui_win_info) <detail>: Remove source_info member.
6345         (struct tui_source_window_base) <has_locator>: Inline.
6346         Move contents from tui_source_info; rename has_locator member to
6347         m_has_locator.
6348         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6349         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6350         header file.
6351         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6352         Simplify.
6353         (tui_free_all_source_wins_content): Cast to
6354         tui_source_window_base.
6355
6356 2019-06-25  Tom Tromey  <tom@tromey.com>
6357
6358         * tui/tui-win.c (make_invisible_and_set_new_height)
6359         (make_visible_with_new_height): Call has_locator method.
6360         * tui/tui-layout.c (show_source_disasm_command, show_data)
6361         (show_source_or_disasm_and_command): Update for bool change.
6362         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6363         (tui_win_info) <has_locator>: New method.
6364         (struct tui_source_window_base) <has_locator>: New method.
6365         (tui_win_has_locator): Don't declare.
6366         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6367         from tui_win_has_locator.
6368         (tui_source_window_base): Use false, not FALSE.
6369
6370 2019-06-25  Tom Tromey  <tom@tromey.com>
6371
6372         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6373         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6374         clear_detail method directly.
6375         (tui_clear_win_detail): Remove.
6376
6377 2019-06-25  Tom Tromey  <tom@tromey.com>
6378
6379         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6380         "this", not TUI_DISASM_WIN.
6381
6382 2019-06-25  Tom Tromey  <tom@tromey.com>
6383
6384         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6385         declare.
6386         * tui/tui-winsource.c
6387         (tui_source_window_base::do_scroll_horizontal): Rename from
6388         tui_horizontal_source_scroll.
6389         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6390         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6391         from tui_vertical_data_scroll.
6392         * tui/tui-win.h (tui_scroll): Don't declare.
6393         * tui/tui-win.c (tui_win_info::forward_scroll)
6394         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6395         (tui_win_info::right_scroll): Rename and update.
6396         (tui_scroll_forward_command, tui_scroll_backward_command)
6397         (tui_scroll_left_command, tui_scroll_right_command): Update.
6398         (tui_scroll): Remove.
6399         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6400         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6401         from tui_vertical_source_scroll.
6402         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6403         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6404         from tui_vertical_disassem_scroll.
6405         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6406         do_scroll_horizontal>: New methods.
6407         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6408         Likewise.
6409         (struct tui_source_window_base): Add do_scroll_horizontal.
6410         (struct tui_source_window, struct tui_disasm_window): Add
6411         do_scroll_vertical.
6412         (struct tui_data_window, struct tui_cmd_window): Add
6413         do_scroll_horizontal and do_scroll_vertical.
6414         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6415
6416 2019-06-25  Tom Tromey  <tom@tromey.com>
6417
6418         * tui/tui-data.h (struct tui_source_window_base): New struct.
6419         (struct tui_source_window): Derive from tui_source_window_base.
6420         (struct tui_disasm_window): New struct.
6421         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6422         from tui_source_window::clear_detail.
6423         (tui_source_window_base): Rename from tui_source_window.
6424         (~tui_source_window_base): Rename from ~tui_source_window.
6425         (tui_alloc_win_info): Create a tui_disasm_window.
6426
6427 2019-06-25  Tom Tromey  <tom@tromey.com>
6428
6429         * tui/tui-data.h (struct tui_source_window)
6430         (struct tui_data_window): Declare destructors.
6431         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6432         destructors.
6433         (tui_win_info): Simplify.
6434
6435 2019-06-25  Tom Tromey  <tom@tromey.com>
6436
6437         * tui/tui-winsource.c (tui_display_main)
6438         (tui_update_source_windows_with_addr)
6439         (tui_update_all_breakpoint_info): Update.
6440         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6441         (new_height_ok, parse_scrolling_args): Update.
6442         * tui/tui-stack.c (tui_show_frame_info): Update.
6443         * tui/tui-data.h (struct tui_list): Remove.
6444         (tui_source_windows): Return a reference to a std::vector.
6445         * tui/tui-data.c (source_windows): Now a std::vector.
6446         (tui_source_windows): Change return type.
6447         (tui_clear_source_windows): Rewrite.
6448         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6449         (tui_free_all_source_wins_content): Rewrite.
6450
6451 2019-06-25  Tom Tromey  <tom@tromey.com>
6452
6453         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6454         (struct tui_data_window, struct tui_cmd_window): Declare
6455         clear_detail method.
6456         * tui/tui-data.c (tui_source_window::clear_detail)
6457         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6458         methods.
6459         (tui_clear_win_detail): Simplify.
6460
6461 2019-06-25  Tom Tromey  <tom@tromey.com>
6462
6463         * tui/tui-layout.c (make_source_window, make_disasm_window)
6464         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6465         Return the new window.
6466         (show_source_disasm_command, show_data)
6467         (show_source_or_disasm_and_command): Update.
6468
6469 2019-06-25  Tom Tromey  <tom@tromey.com>
6470
6471         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6472         parameter.  Return the new window.
6473         (show_source_disasm_command): Update and remove NULL check.
6474         (show_source_or_disasm_and_command): Update.
6475
6476 2019-06-25  Tom Tromey  <tom@tromey.com>
6477
6478         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6479
6480 2019-06-25  Tom Tromey  <tom@tromey.com>
6481
6482         * tui/tui-data.h (struct tui_win_info): Make constructor
6483         protected.  Make destructor virtual.  Add initializers.
6484         (tui_source_window, tui_data_window, tui_cmd_window): New
6485         classes.
6486         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6487         constructor.  Add "type" parameter.
6488         (tui_source_window, tui_data_window, tui_cmd_window): New
6489         constructors.
6490         (tui_alloc_win_info): Instantiate the appropriate subclass.
6491
6492 2019-06-25  Tom Tromey  <tom@tromey.com>
6493
6494         * tui/tui-win.c (tui_resize_all): Use delete.
6495         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6496         destructor.
6497         (tui_free_window): Don't declare.
6498         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6499         Update.
6500
6501 2019-06-25  Tom Tromey  <tom@tromey.com>
6502
6503         * tui/tui-data.h (struct tui_win_info): Add constructor.
6504         * tui/tui-data.c (tui_alloc_win_info): Use new.
6505         (tui_free_window): Use delete.
6506
6507 2019-06-22  Tom Tromey  <tom@tromey.com>
6508
6509         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6510         declare.
6511         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6512
6513 2019-06-22  Tom Tromey  <tom@tromey.com>
6514
6515         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6516         declare.
6517         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6518
6519 2019-06-22  Tom de Vries  <tdevries@suse.de>
6520
6521         * dwarf2read.c (create_addrmap_from_aranges)
6522         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6523         instead of '%zu'.
6524
6525 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6526
6527         * dwarf2read.h (dwarf2_section_info_def): Remove.
6528         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6529         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6530         std::vector<dwarf2_section_info>.
6531         (struct dwo_file) <~dwo_file>: Remove.
6532         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6533         types field.
6534         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6535         (dwarf2_read_debug_names): Likewise.
6536         (create_debug_types_hash_table): Change parameter type to
6537         array_view, adjust code accordingly.
6538         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6539         (partial_die_info::fixup): Likewise.
6540         (determine_prefix): Likewise.
6541         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6542
6543 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6544
6545         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6546         gdb_bfd_ref_ptr.
6547         <~dwo_file>: Remove call to gdb_bfd_unref.
6548         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6549         gdb_bfd_ref_ptr::get.
6550
6551 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6552
6553         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6554         type to htab_up.
6555         * dwarf2read.c (struct dwo_file): Initialize fields.
6556         <~dwo_file>: New.
6557         (free_dwo_file): Remove, move content to ~dwo_file.
6558         (struct dwo_file_deleter): Remove.
6559         (dwo_file_up>: Remove custom deleter.
6560         (free_dwo_files): Remove.
6561         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6562         dwo_files.
6563         (process_skeletonless_type_units): Call unique_ptr::get.
6564         (allocate_dwo_file_hash_table): Add deleter to created hash
6565         table.  Change return type to htab_up.
6566         (lookup_dwo_file_slot): Don't memset dwo_file, call
6567         unique_ptr::get.
6568         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6569         (create_dwo_unit_in_dwp_v2): Likewise.
6570         (open_and_init_dwo_file): Likewise.
6571         (free_dwo_file_from_slot): Remove.
6572
6573 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6574
6575         * dwarf2read.h (struct dwarf2_section_info) <readin,
6576         is_virtual>: Change type to bool.
6577         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6578         true instead of 1.
6579
6580 2019-06-19  Tom Tromey  <tom@tromey.com>
6581
6582         * tui/tui-data.h (tui_init_content_element): Don't declare.
6583
6584 2019-06-19  Tom Tromey  <tom@tromey.com>
6585
6586         * tui/tui-data.h (tui_init_win_info): Don't declare.
6587
6588 2019-06-19  Tom de Vries  <tdevries@suse.de>
6589
6590         * dwarf2read.h (abstract_to_concrete): Change type to
6591         std::unordered_map<sect_offset, std::vector<sect_offset>,
6592         gdb::hash_enum<sect_offset>>.
6593
6594 2019-06-19  Tom Tromey  <tromey@adacore.com>
6595
6596         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6597         EVAL_AVOID_SIDE_EFFECTS specially.
6598
6599 2019-06-19  Tom Tromey  <tromey@adacore.com>
6600
6601         * source-cache.c (highlighter): New global.
6602         (source_cache::get_source_lines): Create a highlighter on demand.
6603
6604 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6605
6606         * defs.h (deprecated_interactive_hook): Delete declaration.
6607         * interps.c (clear_interpreter_hooks): Remove use of
6608         deprecated_interactive_hook.
6609         * top.c (deprecated_interactive_hook): Delete definition.
6610         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6611
6612 2019-06-18  Tom de Vries  <tdevries@suse.de>
6613
6614         PR gdb/24515
6615         * dwarf2read.h (abstract_to_concrete): Change type from
6616         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6617         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6618         * dwarf2read.c (read_variable): Update.
6619         (dwarf2_fetch_die_loc_sect_off): Update.
6620
6621 2019-06-17  Tom de Vries  <tdevries@suse.de>
6622
6623         PR gdb/24617
6624         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6625         accessing parent[parent_len - 1].
6626
6627 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6628
6629         PR gdb/24364
6630         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6631         call dtrace_process_dof with NULL dof.
6632
6633 2019-06-16  Tom de Vries  <tdevries@suse.de>
6634
6635         PR gdb/24445
6636         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6637
6638 2019-06-16  Tom Tromey  <tom@tromey.com>
6639
6640         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6641         (make_all_visible): Use address of member.
6642
6643 2019-06-16  Tom Tromey  <tom@tromey.com>
6644
6645         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6646         (tui_free_window, free_content, free_content_elements): Remove
6647         unnecessary cast.
6648         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6649         cast.
6650         * tui/tui-regs.c (tui_show_register_group)
6651         (tui_display_registers_from, tui_display_reg_element_at_line):
6652         Remove unnecessary cast.
6653
6654 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6655
6656         * linux-nat.c (normal_mask): Delete.
6657         (_initialize_linux_nat): Don't initialise normal_mask.
6658
6659 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6660
6661         PR gdb/24445
6662         * dwarf-index-write.h (write_psymtabs_to_index): Add
6663         dwz_basename parameter.
6664         * dwarf-index-write.c (write_gdbindex): Move file writing to
6665         write_gdbindex_1.  Change return type void.
6666         (assert_file_size): Move up, remove filename parameter.
6667         (write_gdbindex_1): New function.
6668         (write_debug_names): Change return type to void, call
6669         assert_file_size.
6670         (struct index_wip_file): New struct.
6671         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6672         file logic to index_wip_file.  Write index for dwz file if
6673         needed.
6674         (save_gdb_index_command): Pass basename of dwz file, if present.
6675         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6676         build-id of dwz file, if present.
6677         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6678         (dwarf2_get_dwz_file): Likewise.
6679         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6680         (dwarf2_get_dwz_file): Likewise.
6681
6682 2019-06-16  Tom Tromey  <tom@tromey.com>
6683
6684         * coffread.c (process_coff_symbol): Use xstrdup.
6685         * value.c (create_internalvar): Use xstrdup.
6686
6687 2019-06-16  Tom Tromey  <tom@tromey.com>
6688
6689         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6690         * breakpoint.c (stopin_command, stopat_command)
6691         (until_break_command, decode_location_default): Remove unnecessary
6692         cast.
6693         * utils.c (subset_compare): Remove unnecessary cast.
6694         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6695         cast.
6696         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6697         cast.
6698         * infcmd.c (path_command): Remove unnecessary cast.
6699         * coffread.c (decode_type): Remove unnecessary cast.
6700         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6701         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6702         * tui/tui-stack.c (tui_show_locator_content)
6703         (tui_show_frame_info): Remove unnecessary cast.
6704         * tui/tui-win.c (tui_scroll_forward_command)
6705         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6706         (parse_scrolling_args): Remove unnecessary cast.
6707         * tui/tui-data.c (init_win_info, tui_del_window)
6708         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6709         (free_content_elements): Remove unnecessary cast.
6710         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6711         unnecessary cast.
6712         * tui/tui-source.c (tui_set_source_content)
6713         (tui_vertical_source_scroll): Remove unnecessary cast.
6714         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6715         cast.
6716         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6717         * tui/tui-regs.c (tui_display_registers_from)
6718         (tui_display_register): Remove unnecessary cast.
6719         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6720         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6721         (make_visible): Remove unnecessary cast.
6722         * tui/tui-winsource.c (tui_erase_source_content)
6723         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6724         unnecessary cast.
6725         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6726         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6727         * stabsread.c (read_type, read_array_type, read_range_type):
6728         Remove unnecessary cast.
6729         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6730         (parse_symbol, parse_type, upgrade_type, parse_external)
6731         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6732         unnecessary cast.
6733         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6734
6735 2019-06-16  Tom Tromey  <tom@tromey.com>
6736
6737         * tui/tui-data.c (tui_alloc_generic_win_info)
6738         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6739         checks.
6740
6741 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6742             Andrew Burgess  <andrew.burgess@embecosm.com>
6743
6744         * f-typeprint.c (f_print_type): Don't return early for not
6745         associated or not allocated types.
6746         (f_type_print_varspec_suffix): Add print_rank parameter and print
6747         ranks of array types in case they dangling.
6748         (f_type_print_base): Add print_rank parameter.
6749
6750 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6751
6752         * NEWS: Mention new MI commands.
6753         * break-catch-throw.c (enum exception_event_kind): Move to
6754         breakpoint.h.
6755         (print_mention_exception_catchpoint): Output text as a single
6756         message.
6757         (catch_exception_command_1): Rename to...
6758         (catch_exception_event): ...this, make non-static, update header
6759         command, and change some parameter types.
6760         (catch_catch_command): Update for changes to
6761         catch_exception_command_1.
6762         (catch_throw_command): Likewise.
6763         (catch_rethrow_command): Likewise.
6764         * breakpoint.c (enum exception_event_kind): Delete.
6765         * breakpoint.h (enum exception_event_kind): Moved here from
6766         break-catch-throw.c.
6767         (catch_exception_event): Declare.
6768         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6769         (mi_cmd_catch_throw): New function.
6770         (mi_cmd_catch_rethrow): New function.
6771         (mi_cmd_catch_catch): New function.
6772         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6773         'catch-catch' entries.
6774         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6775         (mi_cmd_catch_rethrow): Declare.
6776         (mi_cmd_catch_catch): Declare.
6777
6778 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6779
6780         * annotate.c (annotate_source_line): Change return type to void,
6781         update implementation to match.
6782         * annotate.h (annotate_source_line): Change return type to void,
6783         update header comment.
6784         * stack.c (print_frame_info): Don't change what frame information
6785         is printed based on whether annotations are on or not.
6786
6787 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6788
6789         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6790         (annotate_source): Make static.
6791         (annotate_source_line): Moved from source.c and renamed from
6792         identify_source_line.  Update the return type.
6793         * annotate.h (annotate_source): Delete declaration.
6794         (annotate_source_line): Declaration moved from source.h, and
6795         renamed from identify_source_line.  Return type updated.
6796         * source.c (identify_source_line): Moved to annotate.c and renamed
6797         to annotate_source_line.
6798         (info_line_command): Remove check of annotation_level.
6799         * source.h (identify_source_line): Move declaration to annotate.h
6800         and rename to annotate_source_line.
6801         * stack.c: Add 'annotate.h' include.
6802         (print_frame_info): Remove check of annotation_level before
6803         calling annotate_source_line.
6804
6805 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6806
6807         * source-cache.c (source_cache::get_plain_source_lines): Use
6808         open_source_file_with_line_charpos instead of just
6809         open_source_file, remove call to find_source_lines.
6810         (source_cache::get_source_lines): Likewise.
6811         * source.c (find_source_lines): Make static.
6812         (get_filename_and_charpos): Renamed into...
6813         (open_source_file_with_line_charpos): ..this along with changes to
6814         return a scoped_fd, and some other minor clean ups.
6815         (identify_source_line): Use open_source_file_with_line_charpos.
6816         (search_command_helper): Use open_source_file_with_line_charpos
6817         instead of just open_source_file, remove call to
6818         find_source_lines.
6819         * source.h (open_source_file_with_line_charpos): Declare new
6820         function.
6821         (find_source_lines): Delete declaration.
6822
6823 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6824
6825         * source.c (get_filename_and_charpos): Remove fullname
6826         parameter.
6827         (identify_source_line): Update call to get_filename_and_charpos.
6828
6829 2019-06-14  Tom Tromey  <tromey@adacore.com>
6830
6831         PR gdb/24502:
6832         * ui-style.h (skip_ansi_escape): Update comment.
6833         * ui-file.h (class no_terminal_escape_file): New class.
6834         * ui-file.c (no_terminal_escape_file::write)
6835         (no_terminal_escape_file::puts): New methods.
6836         * cli/cli-logging.c (handle_redirections): Use
6837         no_terminal_escape_file.
6838
6839 2019-06-14  Tom Tromey  <tromey@adacore.com>
6840
6841         * NEWS: Move convenience variable news above Python news.
6842
6843 2019-06-14  Tom Tromey  <tom@tromey.com>
6844
6845         * gnulib: Move directory to top-level.
6846         * configure.ac: Don't configure gnulib.
6847         * configure: Rebuild.
6848         * common/common-defs.h: Use new path to gnulib.
6849         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6850         (GNULIB_H): Remove.
6851         (INCGNU): Look in new gnulib location.
6852         (HFILES_NO_SRCDIR): Remove gnulib files.
6853         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6854         (generated_files): Remove GNULIB_H.
6855         ($(LIBGNU), all-lib): Remove targets.
6856         (distclean): Don't mention GNULIB_BUILDDIR.
6857         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6858
6859 2019-06-14  Tom Tromey  <tromey@adacore.com>
6860
6861         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6862         Warn if symbol file does not provide any symbols.
6863
6864 2019-06-14  Tom Tromey  <tromey@adacore.com>
6865
6866         * source.c (find_and_open_source): Respect basenames_may_differ.
6867
6868 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6869
6870         * annotate.c (annotate_breakpoints_invalid): Make use of
6871         scoped_restore_terminal_state.
6872         (annotate_frames_invalid): Likewise.
6873
6874 2019-06-14  Tom Tromey  <tromey@adacore.com>
6875
6876         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6877         allow assignment to an internalvar.
6878
6879 2019-06-14  Tom Tromey  <tromey@adacore.com>
6880
6881         * ada-lex.l: Allow "_" in attribute names.
6882
6883 2019-06-14  Tom Tromey  <tromey@adacore.com>
6884
6885         PR gdb/24653:
6886         * regcache.c (registers_changed): Don't call alloca.
6887         * top.c (execute_command): Don't call alloca.
6888
6889 2019-06-13  Pedro Alves  <palves@redhat.com>
6890
6891         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6892         'expression'.  When parsing an expression, error out if there's
6893         junk after "unlimited".
6894         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6895         (do_set_command): Adjust calls to is_unlimited_literal.
6896
6897 2019-06-13  Pedro Alves  <palves@redhat.com>
6898
6899         * compile/compile.c (make_compile_options_def_group): Add braces
6900         around array_view initializer.
6901         * thread.c (make_thread_apply_all_options_def_group)
6902         (make_thread_apply_all_options_def_group): Likewise.
6903
6904 2019-06-13  Pedro Alves  <palves@redhat.com>
6905
6906         * NEWS (New commands): Mention "maint test-options
6907         require-delimiter", "maint test-options unknown-is-error", "maint
6908         test-options unknown-is-operand" and "maint show
6909         test-options-completion-result".
6910         (New command options, command completion): New section.
6911         (Completion improvements): New section.
6912         Mention that you can abbreviate "unlimited".
6913
6914 2019-06-13  Pedro Alves  <palves@redhat.com>
6915
6916         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6917         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6918         * unittests/cli-utils-selftests.c (test_parse_flags)
6919         (test_parse_flags_qcs): Delete.
6920         (test_cli_utils): Don't call deleted functions.
6921
6922 2019-06-13  Pedro Alves  <palves@redhat.com>
6923
6924         * thread.c: Include "cli/cli-option.h".
6925         (tp_array_compar_ascending): Global.
6926         (tp_array_compar): Delete function.
6927         (tp_array_compar_ascending, tp_array_compar_descending): New
6928         functions.
6929         (ascending_option_def, qcs_flag_option_def)
6930         (thr_qcs_flags_option_defs)
6931         (make_thread_apply_all_options_def_group)
6932         (make_thread_apply_options_def_group): New.
6933         (thread_apply_all_command): Use gdb::option::process_options.
6934         (thread_apply_command_completer)
6935         (thread_apply_all_command_completer): New.
6936         (thread_apply_command): Use gdb::option::process_options.
6937         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6938         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6939         to generate help text of "thread apply".  Adjust "taas"'s help.
6940         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6941         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6942
6943 2019-06-13  Pedro Alves  <palves@redhat.com>
6944
6945         * thread.c (thread_apply_command): Check for invalid TID with
6946         isdigit instead of !isalpha.
6947
6948 2019-06-13  Pedro Alves  <palves@redhat.com>
6949
6950         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6951         (validate_flags_qcs): New.
6952         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6953         (validate_flags_qcs): Declare.
6954         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6955         (make_frame_apply_options_def_group): New.
6956         (frame_apply_command_count): Process options with
6957         gdb::option::process_options.
6958         (frame_apply_completer): New.
6959         (frame_apply_level_completer, frame_apply_all_completer)
6960         (frame_apply_completer): New.
6961         (_initialize_stack): Update help of "frame apply", "frame apply
6962         level", "frame apply all" and "faas" to mention supported options
6963         and install command completers.
6964         * stack.h (frame_apply_all_completer): Declare.
6965         * thread.c: Include "stack.h".
6966         (tfaas_command): Add "--".
6967         (_initialize_thread): Update help "tfaas" to mention supported
6968         options and install command completer.
6969
6970 2019-06-13  Pedro Alves  <palves@redhat.com>
6971
6972         * completer.c (complete_nested_command_line): New.
6973         (gdb_completion_word_break_characters_throw): Add assertion.
6974         * completer.h (complete_nested_command_line): Declare.
6975
6976 2019-06-13  Pedro Alves  <palves@redhat.com>
6977
6978         * stack.c (parse_backtrace_qualifiers): New.
6979         (backtrace_command): Use it.
6980         (backtrace_command_completer): Complete on qualifiers.
6981
6982 2019-06-13  Pedro Alves  <palves@redhat.com>
6983
6984         * frame.c: Include "cli/cli-option.h.
6985         (user_set_backtrace_options): New.
6986         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6987         Delete.
6988         (get_prev_frame): Adjust.
6989         (boolean_option_def, uinteger_option_def)
6990         (set_backtrace_option_defs): New.
6991         (_initialize_frame): Adjust and use
6992         gdb::option::add_setshow_cmds_for_options to install "set
6993         backtrace past-main" and "set backtrace past-entry".
6994         * frame.h: Include "cli/cli-option.h".
6995         (struct frame_print_options): Forward declare.
6996         (print_frame_arguments_all, print_frame_arguments_scalars)
6997         (print_frame_arguments_none): Declare.
6998         (print_entry_values): Delete declaration.
6999         (struct frame_print_options, user_frame_print_options): New.
7000         (struct set_backtrace_options): New.
7001         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7002         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7003         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7004         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7005         (list_args_or_locals): Add frame_print_options parameter.
7006         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7007         * python/py-framefilter.c (enumerate_args): Pass down
7008         USER_FRAME_PRINT_OPTIONS.
7009         * stack.c: Include "cli/cli-option.h".
7010         (print_frame_arguments_all, print_frame_arguments_scalars)
7011         (print_frame_arguments_none): Declare.
7012         (print_raw_frame_arguments, print_entry_values): Delete.
7013         (user_frame_print_options): New.
7014         (boolean_option_def, enum_option_def, frame_print_option_defs):
7015         New.
7016         (struct backtrace_cmd_options): New.
7017         (bt_flag_option_def): New.
7018         (backtrace_command_option_defs): New.
7019         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7020         (print_frame_arg, read_frame_arg, print_frame_args)
7021         (print_frame_info, print_frame): Add frame_print_options parameter
7022         and use it.
7023         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7024         (backtrace_command_1): Add frame_print_options and
7025         backtrace_cmd_options parameters and use them.
7026         (make_backtrace_options_def_group): New.
7027         (backtrace_command): Process command options with
7028         gdb::option::process_options.
7029         (backtrace_command_completer): New.
7030         (_initialize_stack): Extend "backtrace"'s help to mention
7031         supported options.  Install completer for "backtrace".
7032         Install some settings commands with add_setshow_cmds_for_options.
7033
7034 2019-06-13  Pedro Alves  <palves@redhat.com>
7035
7036         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7037         and that "set/show print raw frame-arguments" are now deprecated.
7038
7039         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7040         command.
7041         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7042         * stack.c (_initialize_stack): Install "set/show print
7043         raw-frame-arguments", and deprecate "set/show print raw
7044         frame-arguments".
7045         * valprint.c (_initialize_valprint): Deprecate "set/show print
7046         raw".
7047
7048 2019-06-13  Pedro Alves  <palves@redhat.com>
7049
7050         * compile/compile.c (struct compile_options): New.
7051         (compile_flag_option_def, compile_command_option_defs)
7052         (make_compile_options_def_group): New.
7053         (compile_file_command): Handle options with
7054         gdb::option::process_options.
7055         (compile_file_command_completer): New function.
7056         (compile_code_command): Handle options with
7057         gdb::option::process_options.
7058         (compile_code_command_completer): New function.
7059         (_initialize_compiler): Install completers for "compile code" and
7060         "compile file".  Mention available options in "compile code" and
7061         "compile code"'s help.
7062         * completer.c (advance_to_completion_word): New, factored out from
7063         ...
7064         (advance_to_expression_complete_word_point): ... this.
7065         (advance_to_filename_complete_word_point): New.
7066         * completer.h (advance_to_filename_complete_word_point): New
7067         declaration.
7068
7069 2019-06-13  Pedro Alves  <palves@redhat.com>
7070
7071         * compile/compile.c: Include "cli/cli-option.h".
7072         (compile_print_value): Scope data pointer is now a
7073         value_print_options pointer; adjust.
7074         (compile_print_command): Process options.  Scope data pointer is
7075         now a value_print_options pointer; adjust.
7076         (_initialize_compile): Update "compile print"'s help to include
7077         supported options.  Install a completer for "compile print".
7078         * cp-valprint.c (show_vtblprint, show_objectprint)
7079         (show_static_field_print): Delete.
7080         (_initialize_cp_valprint): Don't install "set print
7081         static-members", "set print vtbl", "set print object" here.
7082         * printcmd.c: Include "cli/cli-option.h" and
7083         "common/gdb_optional.h".
7084         (print_command_parse_format): Rework to fill in a
7085         value_print_options instead of a format_data.
7086         (print_value): Change parameter type from format_data pointer to
7087         value_print_options reference.  Adjust.
7088         (print_command_1): Process options.  Adjust to pass down a
7089         value_print_options.
7090         (print_command_completer): New.
7091         (_initialize_printcmd): Install print_command_completer as
7092         handle_brkchars completer for the "print" command.  Update
7093         "print"'s help to include supported options.
7094         * valprint.c: Include "cli/cli-option.h".
7095         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7096         here from cp-valprint.c.
7097         (boolean_option_def, uinteger_option_def)
7098         (value_print_option_defs, make_value_print_options_def_group):
7099         New.  Use gdb::option::add_setshow_cmds_for_options to install
7100         "set print elements", "set print null-stop", "set print repeats",
7101         "set print pretty", "set print union", "set print array", "set
7102         print address", "set print symbol", "set print array-indexes".
7103         * valprint.h: Include <string> and "cli/cli-option.h".
7104         (make_value_print_options_def_group): Declare.
7105         (print_value): Change parameter type from format_data pointer to
7106         value_print_options reference.
7107         (print_command_completer): Declare.
7108
7109 2019-06-13  Pedro Alves  <palves@redhat.com>
7110
7111         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7112         (COMMON_SFILES): Add maint-test-settings.c.
7113         * cli/cli-decode.c (boolean_enums): New global, factored out from
7114         ...
7115         (add_setshow_boolean_cmd): ... here.
7116         * cli/cli-decode.h (boolean_enums): Declare.
7117         * cli/cli-option.c: New file.
7118         * cli/cli-option.h: New file.
7119         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7120         factored out from ...
7121         (parse_cli_boolean_value(const char *)): ... this.
7122         (is_unlimited_literal): Change parameter type to pointer to
7123         pointer.  Adjust and advance ARG pointer.
7124         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7125         (parse_cli_var_enum): New, factored out from ...
7126         (do_set_command): ... this.  Adjust.
7127         * cli/cli-setshow.h (parse_cli_boolean_value)
7128         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7129         (parse_cli_var_enum): Declare.
7130         * cli/cli-utils.c: Include "cli/cli-option.h".
7131         (get_ulongest): New.
7132         * cli/cli-utils.h (get_ulongest): Declare.
7133         (check_for_argument): New overloads.
7134         * maint-test-options.c: New file.
7135
7136 2019-06-13  Pedro Alves  <palves@redhat.com>
7137
7138         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7139         parse a range if "-" is at the end of the string.
7140
7141 2019-06-13  Pedro Alves  <palves@redhat.com>
7142
7143         * cli/cli-setshow.c (parse_auto_binary_operation)
7144         (parse_cli_boolean_value): Don't allow "o".
7145
7146 2019-06-13  Pedro Alves  <palves@redhat.com>
7147
7148         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7149         * NEWS: Mention maint test-settings KIND.
7150         * maint-test-settings.c: New file.
7151
7152 2019-06-13  Pedro Alves  <palves@redhat.com>
7153
7154         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7155         completer.
7156         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7157         "set" completers.
7158
7159 2019-06-13  Pedro Alves  <palves@redhat.com>
7160
7161         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7162         after item.
7163
7164 2019-06-13  Pedro Alves  <palves@redhat.com>
7165
7166         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7167
7168 2019-06-13  Pedro Alves <palves@redhat.com>
7169
7170         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7171         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7172         call.
7173         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7174         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7175         calls.
7176         (check_for_argument): Skip spaces after argument.
7177
7178 2019-06-13  Pedro Alves  <palves@redhat.com>
7179
7180         * thread.c (thread_apply_command): Adjust TID parsing.
7181         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7182         detected before end of string.
7183         (tid_is_in_list): Error out if LIST is invalid.
7184
7185 2019-06-13  Pedro Alves  <palves@redhat.com>
7186
7187         * completer.c (complete_line_internal_1): Rewind completion word
7188         point.
7189         (completion_tracker::advance_custom_word_point_by): Change
7190         parameter type to int.
7191         * completer.h (completion_tracker::advance_custom_word_point_by):
7192         Likewise.
7193
7194 2019-06-13  Pedro Alves  <palves@redhat.com>
7195
7196         * completer.c (advance_to_completion_word): Handle delimiters.
7197
7198 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7199
7200         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7201
7202 2019-06-11  Tom Tromey  <tom@tromey.com>
7203
7204         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7205         (xmalloc_failed): Move to alloc.c.
7206         * alloc.c: New file.
7207         * Makefile.in (COMMON_SFILES): Add alloc.c.
7208
7209 2019-06-11  Tom Tromey  <tom@tromey.com>
7210
7211         * nat/linux-waitpid.c: Don't include server.h.
7212         (linux_debug): Remove.
7213         (my_waitpid): Update.
7214
7215 2019-06-11  Tom Tromey  <tromey@adacore.com>
7216
7217         * infcall.c (_initialize_infcall): Remove trailing newline from
7218         help.
7219         * user-regs.c (_initialize_user_regs): Remove trailing newline
7220         from help.
7221         * typeprint.c (_initialize_typeprint): Remove trailing newline
7222         from help.
7223         * reverse.c (_initialize_reverse): Remove trailing newlines from
7224         help.
7225         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7226         from help.
7227         * language.c (add_set_language_command): Remove trailing newline
7228         from help.
7229         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7230         help.
7231         * disasm.c (_initialize_disasm): Remove trailing newline from
7232         help.
7233         * top.c (init_main): Remove trailing newline from help.
7234         * interps.c (_initialize_interpreter): Remove trailing newline
7235         from help.
7236         * btrace.c (_initialize_btrace): Remove trailing newlines from
7237         help.
7238         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7239         from help.
7240         * python/python.c (_initialize_python): Remove trailing newline
7241         from help.
7242         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7243         help.
7244         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7245         from help.  Reformat some text.
7246         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7247         from help.
7248         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7249         newline from help.
7250
7251 2019-06-11  Tom Tromey  <tromey@adacore.com>
7252
7253         * darwin-nat.c (darwin_decode_exception_message)
7254         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7255
7256 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7257
7258         * valops.c (value_slice): Check for not allocated or not
7259         associated values.
7260
7261 2019-06-10  Tom de Vries  <tdevries@suse.de>
7262
7263         PR gdb/24618
7264         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7265         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7266         invalid.
7267
7268 2019-06-10  Tom de Vries  <tdevries@suse.de>
7269
7270         PR gdb/24611
7271         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7272         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7273
7274 2019-06-10  Tom de Vries  <tdevries@suse.de>
7275
7276         PR symtab/24545
7277         * symtab.c (struct demangled_name_entry): Add language field.
7278         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7279         static minimal symbol".  Set and use language field.
7280
7281 2019-06-10  Tom Tromey  <tromey@adacore.com>
7282
7283         * ada-lang.c (_initialize_ada_language): Update help text.
7284
7285 2019-06-10  Tom Tromey  <tromey@adacore.com>
7286
7287         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7288         with a newline.
7289         * guile/guile.c (handle_boot_error): Don't end warning with a
7290         newline.
7291         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7292         warning with a newline.
7293         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7294         newline.
7295         (s12z_frame_cache): Likewise.
7296         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7297         a newline.
7298         * solib-svr4.c (disable_probes_interface): Don't end warning with
7299         a newline.
7300         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7301         newline.
7302         * python/python.c (do_finish_initialization): Don't end warning
7303         with a newline.
7304
7305 2019-06-10  Tom Tromey  <tom@tromey.com>
7306
7307         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7308         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7309         gdbpy_enter.
7310
7311 2019-06-10  Tom Tromey  <tromey@adacore.com>
7312
7313         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7314         data.
7315         (elf_new_init): Don't call stabsread_new_init.
7316         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7317         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7318         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7319
7320 2019-06-10  Tom de Vries  <tdevries@suse.de>
7321
7322         PR symtab/16264
7323         PR symtab/24517
7324         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7325
7326 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7327
7328         * source.c (find_and_open_source): Also rewrite relative file
7329         names.
7330
7331 2019-04-26  Amos Bird  <amosbird@gmail.com>
7332
7333         * annotate.c (annotate_thread_exited): Add "thread-exited"
7334         annotation.
7335
7336 2019-06-06  Tom Tromey  <tromey@adacore.com>
7337
7338         * maint.h (class scoped_command_stats): Use
7339         DISABLE_COPY_AND_ASSIGN.
7340         <print_time>: New method.
7341         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7342         print_time.
7343         (scoped_command_stats::print_time): New method.
7344
7345 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7346
7347         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7348         instructions of lengths 6 or 8 bytes.
7349
7350 2019-06-04  Pedro Alves  <palves@redhat.com>
7351
7352         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7353
7354         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7355         * breakpoint.c (condition_completer): Likewise.
7356         * cli/cli-dump.c (scan_expression): Likewise.
7357         * common/filestuff.c (mkdir_recursive): Likewise.
7358         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7359         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7360         (gdb_abspath): Likewise.
7361         * compile/compile-cplus-types.c
7362         (compile_cplus_instance::decl_name): Likewise.
7363         * completer.c (complete_explicit_location):
7364         (signal_completer, reg_or_group_completer_1): Likewise.
7365         * cp-support.c (cp_remove_params_if_any): Likewise.
7366         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7367         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7368         * infcmd.c (strip_bg_char): Likewise.
7369         * linespec.c (copy_token_string): Likewise.
7370         * mi/mi-main.c (output_cores): Likewise.
7371         * psymtab.c (psymtab_search_name):
7372         * symfile.c (test_set_ext_lang_command): Likewise.
7373         * target.c (target_fileio_read_stralloc): Likewise.
7374         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7375         * value.c (complete_internalvar): Likewise.
7376
7377 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7378
7379         Add objfile property to gdb.Type.
7380         * NEWS: Mention Python API addition.
7381         * python/py-type.c (typy_get_objfile): New method.
7382
7383 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7384
7385         * NEWS: Mention the new set|show style [title|highlight].
7386         Mention changes to "show style", "help" and "apropos".
7387
7388 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7389
7390         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7391         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7392         instead of print_help_for_command.
7393         (print_doc_of_command): New function.
7394         (help_list): Add 'apropos -v word' suggestion.
7395         (print_help_for_command): Style the command name using title style.
7396         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7397         (_initialize_cli_cmds): Describe -v in apropos_command help.
7398
7399 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7400
7401         * cli/cli-style.h (cli_style_option): Add name in constructor,
7402         add m_name class member, add constructor with intensity,
7403         add name class function.
7404         (cli_style_option::add_setshow_commands): Remove name argument.
7405         (highlight_style, title_style): New styles.
7406         * cli/cli-style.c (do_show): New function that shows a style
7407         characteristic styling the style name with itself.
7408         (set_style_name): New function.
7409         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7410         Update all callers according to the changes in cli/cli-style.h.
7411         * utils.h (fputs_highlighted): New function.
7412         * utils.c (fputs_highlighted): Likewise.
7413
7414 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7415
7416         * NEWS: Mention new pipe command and new convenience variables.
7417
7418 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7419
7420         * cli/cli-cmds.c (pipe_command): New function.
7421         (_initialize_cli_cmds): Call add_com for pipe_command.
7422         Define | as an alias for pipe.
7423         (exit_status_set_internal_vars): New function.
7424         (shell_escape): Call exit_status_set_internal_vars.
7425         cli/cli-decode.c (find_command_name_length): Recognize | as
7426         a single character command.
7427
7428 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7429
7430         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7431         top.c (execute_command_to_ui_file): New function, mostly a copy
7432         of execute_command_to_string.
7433         (execute_command_to_string): Implement by calling
7434         execute_command_to_ui_file.
7435
7436 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7437
7438         * top.h (saved_command_line): Remove declaration.
7439         * top.c (previous_saved_command_line, previous_repeat_arguments):
7440         New variables.
7441         (saved_command_line): Make static, define together with other
7442         'repeat variables'.
7443         (dont_repeat): Clear repeat_arguments.
7444         (repeat_previous, get_saved_command_line, save_command_line):
7445         New functions.
7446         (gdb_init): Initialize saved_command_line
7447         and previous_saved_command_line.
7448         * main.c (captured_main_1): Remove saved_command_line initialization.
7449         * event-top.c (handle_line_of_input): Update to use
7450         the new 'repeat' related functions instead of direct access to
7451         saved_command_line.
7452         * command.h (repeat_previous, get_saved_command_line,
7453         save_command_line): New declarations.
7454         (dont_repeat): Add comment.
7455
7456 2019-05-30  Tom Tromey  <tromey@adacore.com>
7457
7458         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7459         Fix comment.
7460         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7461
7462 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7463
7464         PR cli/24587
7465         * completer.c (complete): Initialize variable word.
7466
7467 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7468
7469         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7470         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7471         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7472         'body' is NULL to the outter 'if', protecting the '!is_define'
7473         situation as well.
7474
7475 2019-05-29  Tom Tromey  <tromey@adacore.com>
7476
7477         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7478         (dwarf_unknown): New function.
7479         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7480         (dwarf_type_encoding_name): Use dwarf_unknown.
7481
7482 2019-05-29  Tom Tromey  <tromey@adacore.com>
7483
7484         PR c++/20020:
7485         * cp-valprint.c (cp_print_value_fields): Call
7486         cp_print_static_field inside "try".
7487
7488 2019-05-29  Tom Tromey  <tromey@adacore.com>
7489
7490         * inflow.c (struct terminal_info): Add default operator=.
7491         * configure: Rebuild.
7492         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7493         -Wdeprecated-copy-dtor, -Wredundant-move.
7494
7495 2019-05-29  Tom Tromey  <tromey@adacore.com>
7496
7497         * NEWS: Add entry.
7498         * infcmd.c (print_return_value_1): Handle finish_print
7499         option.
7500         (show_print_finish): New function.
7501         (_initialize_infcmd): Add "set/show print finish" commands.
7502         * valprint.c (user_print_options): Initialize new member.
7503         * valprint.h (struct value_print_options) <finish_print>: New
7504         member.
7505
7506 2019-05-28  Tom Tromey  <tromey@adacore.com>
7507
7508         * ada-lang.c (ada_remove_Xbn_suffix)
7509         (find_old_style_renaming_symbol)
7510         (parse_old_style_renaming): Remove.
7511         (ada_find_renaming_symbol): Don't call
7512         find_old_style_renaming_symbol.
7513         (ada_is_renaming_symbol): Rename from
7514         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7515         bool.  Now static.
7516         (ada_read_var_value): Update and simplify.
7517         * ada-exp.y (write_var_or_type): Remove old code.
7518
7519 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7520
7521         PR gdb/25010
7522         * event-top.c: Remove include comment.
7523         * inflow.c (class scoped_ignore_sigttou): Move from here...
7524         * inflow.h (class scoped_ignore_sigttou): ...to here.
7525         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7526         * top.c:  Remove include comment.
7527
7528 2019-05-27  Tom Tromey  <tom@tromey.com>
7529
7530         * NEWS: Fix typo.
7531
7532 2019-05-22  Tom Tromey  <tromey@adacore.com>
7533
7534         * target.c (target_follow_exec): Constify parameter.
7535         * target-delegates.c: Rebuild.
7536         * remote.c (remote_target::follow_exec): Constify parameter.
7537         * infrun.c (follow_exec): Constify parameter.
7538         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7539         (target_follow_exec): Likewise.
7540
7541 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7542
7543         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7544         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7545
7546 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7547
7548         * NEWS: Add debugredirect and testsuite sections.
7549
7550 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7551
7552         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7553         target descriptions using exclusively floating point register name
7554         aliases.
7555
7556 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7557
7558         PR gdb/18644:
7559         * f-lang.c (build_fortran_types): Handle the case where
7560         gdbarch_floatformat_for_type returns a nullptr.
7561
7562 2019-05-21  Tom de Vries  <tdevries@suse.de>
7563
7564         PR cli/24587
7565         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7566
7567 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7568
7569         PR gdb/18644:
7570         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7571         16-byte floats.
7572         * i386-tdep.c (i386_floatformat_for_type): Use
7573         floatformats_ia64_quad for the 16-byte floating point component
7574         within a fortran 32-byte complex number.
7575
7576 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7577
7578         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7579         delete default constructor.
7580         (find_partial_die): Update to return const struct.
7581         (partial_die_parent_scope): Move variable declaration into scope
7582         of its use and change its type to auto.
7583         (guess_partial_die_structure_name): Likewise.
7584         (partial_die_info::fixup): Likewise.
7585
7586 2019-05-17  Tom Tromey  <tromey@adacore.com>
7587
7588         * source.c (find_and_open_source): Remove cast.
7589
7590 2019-05-17  Tom Tromey  <tromey@adacore.com>
7591
7592         * annotate.c (annotate_source): Make "filename" const.
7593         * annotate.h (annotate_source): Use const.
7594
7595 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7596
7597         * disasm.c (set_disassembler_options): Send errors to stderr.
7598
7599 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7600
7601         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7602         (cli_interp_base::set_logging): Check debug_redirect.
7603         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7604         * cli/cli-logging.c (debug_redirect): Add static variable.
7605         (pop_output_files): Add default param.
7606         (handle_redirections): Print debug setting.
7607         (show_logging_command): Likewise.
7608         (_initialize_cli_logging): Add debugredirect command.
7609         * interps.c (current_interp_set_logging): Add debug_redirect
7610         parameter.
7611         * interps.h (set_logging): Add debug_redirect parameter.
7612         (current_interp_set_logging): Likewise.
7613         * mi/mi-common.h: Likewise.
7614         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7615
7616 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7617             Tom Tromey  <tromey@adacore.com>
7618
7619         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7620         directly.
7621         * cli/cli-interp.h (make_logging_output): Remove declaration.
7622         * cli/cli-logging.c (make_logging_output): Remove function.
7623         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7624         directly.
7625         * ui-file.c (tee_file::tee_file): Remove bools.
7626         (tee_file::~tee_file): Remove deletes.
7627         * ui-file.h (tee_file): Remove bools.
7628
7629 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7630
7631         * mi/mi-cmds.h (mi_cmd_complete): New function.
7632         * mi/mi-main.c (mi_cmd_complete): Likewise.
7633         * mi/mi-cmds.c: Define new MI command -complete.
7634         * NEWS: Mention new -complete command.
7635
7636 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7637
7638         * completer.h (complete): New function.
7639         * completer.c (complete): Likewise.
7640         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7641         function defined in completer.h.
7642
7643 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7644
7645         * MAINTAINERS (Write After Approval): Add myself.
7646
7647 2019-05-17  Tom de Vries  <tdevries@suse.de>
7648
7649         PR gdb/24094
7650         * dwarf2read.c (struct cu_partial_die_info): New struct.
7651         (find_partial_die): Return cu_partial_die_info.
7652         (partial_die_parent_scope, guess_partial_die_structure_name)
7653         (partial_die_info::fixup): Handle new return type of find_partial_die.
7654
7655 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7656
7657         PR breakpoints/24541
7658         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7659         "std::string", simplifying the algorithm.
7660
7661 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7662
7663         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7664         (stap_static_probe_ops::get_probes): Likewise.
7665
7666 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7667
7668         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7669         '-')" and "else if".
7670         (stap_parse_single_operand): Join checks for
7671         "gdbarch_stap_parse_special_token_p" and
7672         "gdbarch_stap_parse_special_token" in the same "if" statement.
7673         Invert check when verifying for operation on register
7674         displacement.
7675
7676 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7677
7678         * stap-probe.c (stap_get_opcode): Update comment.
7679         (stap_get_expected_argument_type): Likewise.
7680         (handle_stap_probe): Likewise.
7681
7682 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7683
7684         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7685         return type to 'bool'.  Adjust comment.  Use 'bool' when
7686         appropriate.
7687         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7688         * stap-probe.c (stap_parse_argument_1): Likewise.
7689         (stap_is_operator): Likewise.
7690         (stap_is_generic_prefix): Likewise.
7691         (stap_is_register_prefix): Likewise.
7692         (stap_is_register_indirection_prefix): Likewise.
7693         (stap_is_integer_prefix): Likewise.
7694         (stap_generic_check_suffix): Likewise.
7695         (stap_check_integer_suffix): Likewise.
7696         (stap_check_register_suffix): Likewise.
7697         (stap_check_register_indirection_suffix): Likewise.
7698         (stap_parse_register_operand): Likewise.
7699         (stap_parse_single_operand): Likewise.
7700         (stap_parse_argument_1): Likewise.
7701         (stap_probe::get_argument_count): Likewise.
7702         (stap_is_operator): Likewise.
7703
7704 2019-05-16  Tom Tromey  <tromey@adacore.com>
7705
7706         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7707         keyword to foreach.
7708
7709 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7710
7711         * linux-thread-db.c (try_thread_db_load_1): Change return type
7712         to bool.
7713         (try_thread_db_load): Likewise.
7714         (try_thread_db_load_from_pdir_1): Likewise.
7715         (try_thread_db_load_from_pdir): Likewise.
7716         (try_thread_db_load_from_sdir): Likewise.
7717         (try_thread_db_load_from_dir): Likewise.
7718         (thread_db_load_search): Likewise.
7719         (has_libpthread): Likewise.
7720         (thread_db_load): Likewise.
7721
7722 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7723
7724         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7725         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7726         NULL, and complain/return if that's the case.
7727
7728 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7729
7730         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7731         (advance, posn, abstract_read_memory): New functions.
7732         [struct mem_read_abstraction]: New struct.
7733         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7734
7735 2019-05-14  Tom Tromey  <tromey@adacore.com>
7736
7737         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7738         value is not lval_memory.
7739
7740 2019-05-14  Tom Tromey  <tromey@adacore.com>
7741
7742         * solib.c (info_sharedlibrary_command): Style the file name.
7743
7744 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7745
7746         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7747         (aarch64_vnv_type): Likewise.
7748         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7749         * common/tdesc.c: Likewise.
7750         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7751         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7752         * features/aarch64-fpu.xml: Add ieee half view.
7753         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7754         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7755         * gdbtypes.h (struct builtin_type): Likewise.
7756         (struct objfile_type): Likewise.
7757
7758 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7759
7760         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7761         typo.
7762         * location.h (string_to_event_location): Likewise.
7763
7764 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7765
7766         GDB 8.3 released.
7767
7768 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7769
7770         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7771         New variable declaration.
7772         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7773         New variable.
7774         (print_one_breakpoint): Use ui_out::test_flags and new global
7775         variable to compute use_fixed_output.
7776         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7777         Remove.
7778         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7779         (mi_multi_location_breakpoint_output_fixed): Remove.
7780         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7781         new variable.
7782         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7783         fix_multi_location_breakpoint_output flag if version >= 3.
7784         * ui-out.h (enum ui_out_flag)
7785         <fix_multi_location_breakpoint_output>: New enumerator.
7786
7787 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7788
7789         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7790
7791 2019-05-10  Tom Tromey  <tromey@adacore.com>
7792
7793         * ada-lang.c (catch_ada_completer): New function.
7794         (_initialize_ada_language): Use it.
7795
7796 2019-05-10  Tom Tromey  <tromey@adacore.com>
7797
7798         * thread.c (print_thread_info): Make "requested_threads" const.
7799         * gdbthread.h (print_thread_info): Make "requested_threads"
7800         const.
7801         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7802         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7803
7804 2019-05-08  Tom Tromey  <tom@tromey.com>
7805
7806         * gdbtypes.c (objfile_type_data): Change type.
7807         (objfile_type, _initialize_gdbtypes): Update.
7808
7809 2019-05-08  Tom Tromey  <tom@tromey.com>
7810
7811         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7812         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7813         (_initialize_dwarf2_frame): Update.
7814
7815 2019-05-08  Tom Tromey  <tom@tromey.com>
7816
7817         * objc-lang.c (objc_objfile_data): Change type.
7818         (find_methods): Update.
7819         (_initialize_objc_lang): Remove.
7820
7821 2019-05-08  Tom Tromey  <tom@tromey.com>
7822
7823         * stabsread.c (rs6000_builtin_type_data): Change type.
7824         (rs6000_builtin_type, _initialize_stabsread): Update.
7825
7826 2019-05-08  Tom Tromey  <tom@tromey.com>
7827
7828         * mips-tdep.c (mips_pdr_data): Remove.
7829         (_initialize_mips_tdep): Update.
7830
7831 2019-05-08  Tom Tromey  <tom@tromey.com>
7832
7833         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7834         (hppa_init_objfile_priv_data, read_unwind_info)
7835         (find_unwind_entry, _initialize_hppa_tdep): Update.
7836
7837 2019-05-08  Tom Tromey  <tom@tromey.com>
7838
7839         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7840         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7841         on obstack.
7842         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7843
7844 2019-05-08  Tom Tromey  <tom@tromey.com>
7845
7846         * mdebugread.c (basic_type_data): Change type.
7847         (basic_type, _initialize_mdebugread): Update.
7848
7849 2019-05-08  Tom Tromey  <tom@tromey.com>
7850
7851         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7852
7853 2019-05-08  Tom Tromey  <tom@tromey.com>
7854
7855         * nto-tdep.c (nto_inferior_data_reg): Change type.
7856         (nto_inferior_data): Update.
7857         (nto_inferior_data_cleanup, nto_new_inferior_data)
7858         (_initialize_nto_tdep): Remove.
7859         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7860
7861 2019-05-08  Tom Tromey  <tom@tromey.com>
7862
7863         * ada-lang.c (struct ada_inferior_data): Add initializers.
7864         (ada_inferior_data): Change type.
7865         (ada_inferior_data_cleanup): Remove.
7866         (get_ada_inferior_data, ada_inferior_exit)
7867         (struct ada_pspace_data): Add initializers, destructor.
7868         (ada_pspace_data_handle): Change type.
7869         (get_ada_pspace_data): Update.
7870         (ada_pspace_data_cleanup): Remove.
7871
7872 2019-05-08  Tom Tromey  <tom@tromey.com>
7873
7874         * coffread.c (struct coff_symfile_info): Add initializers.
7875         (coff_objfile_data_key): Move lower.  Change type.
7876         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7877         Update.
7878         (coff_free_info): Remove.
7879
7880 2019-05-08  Tom Tromey  <tom@tromey.com>
7881
7882         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7883         (fbsd_pspace_data_handle): Move lower.  Change type.
7884         (get_fbsd_pspace_data): Update.
7885         (fbsd_pspace_data_cleanup): Remove.
7886         (_initialize_fbsd_tdep): Update.
7887
7888 2019-05-08  Tom Tromey  <tom@tromey.com>
7889
7890         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7891         (get_ada_tasks_pspace_data): Update.
7892         (ada_tasks_pspace_data_cleanup): Remove.
7893         (_initialize_tasks): Update.
7894         (ada_tasks_inferior_data_handle): Change type.
7895         (get_ada_tasks_inferior_data): Update.
7896         (ada_tasks_inferior_data_cleanup): Remove.
7897         (struct ada_tasks_pspace_data): Add initializers.
7898
7899 2019-05-08  Tom Tromey  <tom@tromey.com>
7900
7901         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7902         * symfile-debug.c (debug_sym_get_probes): Change type.
7903         * stap-probe.c (handle_stap_probe):
7904         (stap_static_probe_ops::get_probes): Change type.
7905         * probe.h (class static_probe_ops) <get_probes>: Change type.
7906         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7907         (parse_probes_in_pspace): Update.
7908         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7909         Update.
7910         (any_static_probe_ops::get_probes): Change type.
7911         * elfread.c (elfread_data): New typedef.
7912         (probe_key): Change type.
7913         (elf_get_probes): Likewise.  Update.
7914         (probe_key_free): Remove.
7915         (_initialize_elfread): Update.
7916         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7917         Change type.
7918         (dtrace_process_dof_probe, dtrace_process_dof)
7919         (dtrace_static_probe_ops::get_probe): Change type.
7920
7921 2019-05-08  Tom Tromey  <tom@tromey.com>
7922
7923         * xcoffread.c (struct xcoff_symfile_info): Rename from
7924         coff_symfile_info.  Add initializers.
7925         (xcoff_objfile_data_key): Move lower.  Change type.
7926         (XCOFF_DATA): Rewrite.
7927         (xcoff_free_info): Remove.
7928         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7929         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7930         (xcoff_initial_scan): Update.
7931
7932 2019-05-08  Tom Tromey  <tom@tromey.com>
7933
7934         * solib-svr4.c (struct svr4_info): Add initializers and
7935         destructor.
7936         <probes_table>: Now an htab_up.
7937         (solib_svr4_pspace_data): Change type.
7938         (free_probes_table): Simplify.
7939         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7940         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7941         (probes_table_remove_objfile_probes, register_solib_event_probe)
7942         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7943         (_initialize_svr4_solib): Update.
7944
7945 2019-05-08  Tom Tromey  <tom@tromey.com>
7946
7947         * remote.c (remote_pspace_data): Change type.
7948         (remote_pspace_data_cleanup): Remove.
7949         (get_remote_exec_file, set_pspace_remote_exec_file)
7950         (_initialize_remote): Update.
7951
7952 2019-05-08  Tom Tromey  <tom@tromey.com>
7953
7954         * breakpoint.c (breakpoint_objfile_key): Change type.
7955         (get_breakpoint_objfile_data): Update.
7956         (free_breakpoint_objfile_data): Remove.
7957         (_initialize_breakpoint): Update.
7958
7959 2019-05-08  Tom Tromey  <tom@tromey.com>
7960
7961         * linux-tdep.c (struct linux_info): Add initializers.
7962         (linux_inferior_data): Move.  Change type.
7963         (invalidate_linux_cache_inf): Update.
7964         (linux_inferior_data_cleanup): Remove.
7965         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7966
7967 2019-05-08  Tom Tromey  <tom@tromey.com>
7968
7969         * auxv.c (auxv_inferior_data): Move.  Change type.
7970         (auxv_inferior_data_cleanup): Remove.
7971         (invalidate_auxv_cache_inf): Rewrite.
7972         (get_auxv_inferior_data, _initialize_auxv): Update.
7973
7974 2019-05-08  Tom Tromey  <tom@tromey.com>
7975
7976         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7977         (symfile_debug_objfile_data_key): Change type.
7978         (symfile_debug_installed, debug_qf_has_symbols)
7979         (debug_qf_find_last_source_symtab)
7980         (debug_qf_forget_cached_source_info)
7981         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7982         (debug_qf_print_stats, debug_qf_dump)
7983         (debug_qf_expand_symtabs_for_function)
7984         (debug_qf_expand_all_symtabs)
7985         (debug_qf_expand_symtabs_with_fullname)
7986         (debug_qf_map_matching_symbols)
7987         (debug_qf_expand_symtabs_matching)
7988         (debug_qf_find_pc_sect_compunit_symtab)
7989         (debug_qf_map_symbol_filenames)
7990         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7991         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7992         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7993         (debug_sym_read_linetable, debug_sym_relocate): Update.
7994         (symfile_debug_free_objfile): Remove.
7995         (install_symfile_debug_logging, _initialize_symfile_debug):
7996         Update.
7997
7998 2019-05-08  Tom Tromey  <tom@tromey.com>
7999
8000         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8001         allocate_on_obstack.
8002         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8003         (get_dwarf2_per_objfile): Update.
8004         (set_dwarf2_per_objfile): Remove.
8005         (dwarf2_has_info, dwarf2_get_section_info): Update.
8006         (dwarf2_free_objfile): Remove.
8007         (_initialize_dwarf2_read): Update.
8008
8009 2019-05-08  Tom Tromey  <tom@tromey.com>
8010
8011         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8012         initializers.
8013         <unsupported_script_warning_printed,
8014         script_not_found_warning_printed>: Now bool.
8015         (auto_load_pspace_data): Change type.
8016         (~auto_load_pspace_info): Rename from
8017         auto_load_pspace_data_cleanup.
8018         (get_auto_load_pspace_data, init_loaded_scripts_info)
8019         (clear_section_scripts, maybe_print_unsupported_script_warning)
8020         (maybe_print_script_not_found_warning, _initialize_auto_load):
8021         Update.
8022
8023 2019-05-08  Tom Tromey  <tom@tromey.com>
8024
8025         * objfiles.c (objfile_pspace_info): Add destructor and
8026         initializers.
8027         (objfiles_pspace_data): Change type.
8028         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8029         (get_objfile_pspace_data): Update.
8030         (objfiles_bfd_data): Change type.
8031         (get_objfile_bfd_data): Update.
8032         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8033
8034 2019-05-08  Tom Tromey  <tom@tromey.com>
8035
8036         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8037         Change type.
8038         (get_catch_syscall_inferior_data): Update.
8039         (catch_syscall_inferior_data_cleanup): Remove.
8040         (_initialize_break_catch_syscall): Update.
8041
8042 2019-05-08  Tom Tromey  <tom@tromey.com>
8043
8044         * inflow.c (struct terminal_info): Add destructor and
8045         initializers.
8046         (inflow_inferior_data): Change type.
8047         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8048         (get_inflow_inferior_data, inflow_inferior_exit)
8049         (swap_terminal_info, _initialize_inflow): Update.
8050
8051 2019-05-08  Tom Tromey  <tom@tromey.com>
8052
8053         * target-dcache.c (target_dcache_cleanup): Remove.
8054         (target_dcache_aspace_key): Change type.
8055         (target_dcache_init_p, target_dcache_invalidate)
8056         (target_dcache_get, target_dcache_get_or_init)
8057         (_initialize_target_dcache): Update.
8058         * dcache.h (struct dcache_deleter): New.
8059
8060 2019-05-08  Tom Tromey  <tom@tromey.com>
8061
8062         * symtab.c (struct symbol_cache): Add destructor and
8063         initializers.
8064         (symbol_cache_key): Move.  Change type.
8065         (make_symbol_cache, free_symbol_cache): Remove.
8066         (get_symbol_cache): Update.
8067         (symbol_cache_cleanup): Remove.
8068         (ALL_PSPACES, symbol_cache_flush)
8069         (maintenance_print_symbol_cache)
8070         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8071         Update.
8072
8073 2019-05-08  Tom Tromey  <tom@tromey.com>
8074
8075         * symtab.c (struct main_info): Add destructor and initializers.
8076         (main_progspace_key): Move.  Change type.
8077         (get_main_info): Update.
8078         (main_info_cleanup): Remove.
8079         (_initialize_symtab): Update.
8080
8081 2019-05-08  Tom Tromey  <tom@tromey.com>
8082
8083         * registry.h (DECLARE_REGISTRY): Define the _key class.
8084
8085 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8086
8087         * NEWS: Merge two 'New commands' sections.
8088
8089 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8090
8091         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8092         parameter and use Ada language definition instead.
8093         (ada_val_print_ptr): Remove unused language parameter.
8094         (ada_val_print_num): Remove language parameter and use Ada language
8095         definition instead.
8096         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8097         parameter.
8098         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8099         parameter and use Ada language definition instead.
8100         (ada_val_print_1): Update all ada_val_print_xxx calls.
8101         Remove language parameter.
8102         (ada_val_print): Update ada_val_print_1 call.
8103
8104 2019-05-08  Tom Tromey  <tromey@adacore.com>
8105
8106         * remote.c (remote_hw_watchpoint_limit)
8107         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8108         Now static.
8109
8110 2019-05-08  Tom Tromey  <tromey@adacore.com>
8111
8112         * maint.c (_initialize_maint_cmds): Move initialization code to
8113         remote.c.
8114         (watchdog, show_watchdog): Move to remote.c.
8115         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8116         "watchdog" static.
8117         (_initialize_remote): Move initialization code from maint.c.
8118         * defs.h (watchdog): Don't declare.
8119
8120 2019-05-08  Tom Tromey  <tromey@adacore.com>
8121
8122         * tui/tui-interp.c: Include main.h.
8123         * interps.c: Include main.h.
8124         * main.h (interpreter_p): Declare.
8125         * defs.h (interpreter_p): Don't declare.
8126
8127 2019-05-08  Tom Tromey  <tromey@adacore.com>
8128
8129         * dwarf2loc.c: Include dwarf2read.h.
8130         * defs.h (read_unsigned_leb128): Don't declare.
8131         * dwarf2read.h (read_unsigned_leb128): Declare.
8132
8133 2019-05-08  Tom Tromey  <tromey@adacore.com>
8134
8135         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8136         method.
8137
8138 2019-05-08  Tom Tromey  <tromey@adacore.com>
8139
8140         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8141         when no wrap column is set.
8142
8143 2019-05-08  Tom Tromey  <tromey@adacore.com>
8144
8145         * c-lang.c (c_get_string): Handle non-C-style arrays.
8146
8147 2019-05-08  Tom Tromey  <tromey@adacore.com>
8148
8149         * typeprint.c (print_offset_data::update): Print the bit offset,
8150         not the number of bits remaining.
8151
8152 2019-05-08  Tom Tromey  <tromey@adacore.com>
8153
8154         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8155         padding at end of comment.
8156
8157 2019-05-08  Tom Tromey  <tromey@adacore.com>
8158
8159         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8160         Compare main types.
8161
8162 2019-05-06  Tom Tromey  <tom@tromey.com>
8163
8164         * common/scoped_mmap.c: Include common-defs.h.
8165         * common/scoped_mmap.h: Don't include config.h.
8166
8167 2019-05-04  Tom Tromey  <tom@tromey.com>
8168
8169         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8170         (struct aarch64_call_info): Add initializers.
8171         <si>: Now a std::vector.
8172         (pass_on_stack, aarch64_push_dummy_call): Update.
8173
8174 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8175             Tom Tromey  <tom@tromey.com>
8176
8177         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8178         (ppc_threads): Now a std::vector.  Now static.
8179         (hwdebug_find_thread_points_by_tid)
8180         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8181         Update.
8182
8183 2019-05-04  Tom Tromey  <tom@tromey.com>
8184
8185         * arc-tdep.c (arc_tdesc_init): Return bool.
8186
8187 2019-05-04  Tom Tromey  <tom@tromey.com>
8188
8189         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8190         Use gdb_assert_not_reached.
8191
8192 2019-05-04  Tom Tromey  <tom@tromey.com>
8193
8194         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8195         "false".
8196
8197 2019-05-04  Tom Tromey  <tom@tromey.com>
8198
8199         * arc-tdep.c (arc_tdesc_init): Use bool.
8200
8201 2019-05-04  Tom Tromey  <tom@tromey.com>
8202
8203         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8204
8205 2019-05-04  Tom Tromey  <tom@tromey.com>
8206
8207         * cli/cli-cmds.c (valid_command_p): Return bool.
8208
8209 2019-05-04  Tom Tromey  <tom@tromey.com>
8210
8211         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8212         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8213
8214 2019-05-04  Raul Tambre  <raul@tambre.ee>
8215
8216         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8217         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8218         operator for comparison.
8219
8220 2019-05-04  Tom Tromey  <tom@tromey.com>
8221
8222         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8223         (lookup_partial_symbol, print_partial_symbols)
8224         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8225         (psymbol_compare): Update.
8226         (add_psymbol_to_bcache): Clear the entire psymbol.
8227         (maintenance_check_psymtabs): Update.
8228         * psympriv.h (struct partial_symbol): Don't derive from
8229         general_symbol_info.
8230         <obj_section, unrelocated_address, address,
8231         set_unrelocated_address>: Update.
8232         <ginfo>: New member.
8233         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8234         (debug_names::write_psymbols): Update.
8235
8236 2019-05-04  Tom de Vries  <tdevries@suse.de>
8237
8238         * contrib/cc-with-tweaks.sh: Support -n arg.
8239
8240 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8241
8242         * corelow.c (core_target::detach): Ensure frame cache and
8243         register caches are cleared.
8244         inferior.c (exit_inferior_1): Likewise.
8245
8246 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8247             Tom Tromey  <tom@tromey.com>
8248
8249         * dictionary.c (collate_pending_symbols_by_language): Remove
8250         "struct" from foreach.
8251         * symtab.c (lookup_global_symbol_from_objfile)
8252         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8253         foreach.
8254         * ser-tcp.c (net_open): Remove "struct" from foreach.
8255         * objfiles.c (objfile_relocate, objfile_rebase)
8256         (objfile_has_symbols): Remove "struct" from foreach.
8257         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8258         from foreach.
8259         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8260         foreach.
8261         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8262         "struct" from foreach.
8263         * ada-lang.c (create_excep_cond_exprs)
8264         (ada_exception_catchpoint_cond_string): Remove "struct" from
8265         foreach.
8266
8267 2019-05-03  Tom Tromey  <tromey@adacore.com>
8268
8269         * ada-exp.y (convert_char_literal): Check suffix of each
8270         enumerator.
8271
8272 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8273
8274         PR ada/21406:
8275         * ada-exp.y (yywrap): Don't define.
8276         * ada-lex.l (%option): Add noyywrap
8277         (yywrap): Remove.
8278
8279 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8280
8281         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8282         _WIN32_WINNT to the XP level, unless already defined to a higher
8283         level.
8284
8285         * unittests/parse-connection-spec-selftests.c:
8286         * ser-tcp.c:
8287         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8288         override.
8289
8290         * symfile.c (find_separate_debug_file): Remove colon from the
8291         drive spec of DOS/Windows file names of the target, so that the
8292         file name produced from DEBUGDIR and the target's directory will
8293         be valid on DOS/Windows systems.
8294
8295 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8296
8297         * rust-lang.c (val_print_struct): Handle printing structures
8298         containing strings.
8299
8300 2019-05-02  Tom Tromey  <tromey@adacore.com>
8301
8302         * valarith.c (_initialize_valarith): Remove.
8303
8304 2019-05-01  Tom Tromey  <tromey@adacore.com>
8305
8306         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8307         bitfields.
8308
8309 2019-05-01  Tom Tromey  <tromey@adacore.com>
8310
8311         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8312         for big-endian copies.
8313
8314 2019-04-30  Ali Tamur  <tamur@google.com>
8315         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8316         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8317         (read_3_bytes): New function.
8318
8319 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8320
8321         * windows-nat.c (main_thread_id): Delete.
8322         (handle_output_debug_string): Replace main_thread_id by
8323         current_event.dwThreadId.
8324         (fake_create_process): Likewise.
8325         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8326         Do not set main_thread_id.
8327         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8328         current_event.dwThreadId.
8329         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8330
8331 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8332
8333         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8334         Use current_event.dwThreadId instead of main_thread_id.
8335
8336 2019-04-30  Tom Tromey  <tromey@adacore.com>
8337
8338         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8339         (create_excep_cond_exprs): Iterate over program spaces.
8340         (ada_exception_catchpoint_cond_string): Examine all minimal
8341         symbols for exception types.
8342
8343 2019-04-30  Tom Tromey  <tromey@adacore.com>
8344
8345         PR c++/24470:
8346         * dwarf2read.c (process_structure_scope): Handle case where type
8347         has template parameters but no symbol was created.
8348
8349 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8350             Chris January  <chris.january@arm.com>
8351
8352         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8353         qualifier.
8354         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8355
8356 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8357
8358         * f-typeprint.c (f_print_type): Update rules for printing
8359         whitespace.
8360         (f_type_print_varspec_suffix): Likewise.
8361
8362 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8363             Chris January  <chris.january@arm.com>
8364
8365         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8366         function arguments.
8367
8368 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8369
8370         * f-lang.c (build_fortran_types): Change name of void type to
8371         lower case.
8372         * f-typeprint.c (f_type_print_base): Print the name of the void
8373         type, rather than a fixed string.
8374         * f-valprint.c (f_decorations): Use lower case void string.
8375
8376 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8377             Chris January  <chris.january@arm.com>
8378
8379         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8380         types for Fortran.
8381
8382 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8383             Chris January  <chris.january@arm.com>
8384             David Lecomber  <david.lecomber@arm.com>
8385
8386         * f-exp.y (BINOP_INTRINSIC): New token.
8387         (exp): New parser rule handling BINOP_INTRINSIC.
8388         (f77_keywords): Add new builtin procedures.
8389         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8390         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8391         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8392         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8393         (print_unop_subexp_f): New function.
8394         (print_binop_subexp_f): New function.
8395         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8396         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8397         (dump_subexp_body_f): Likewise.
8398         (operator_check_f): Likewise.
8399         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8400         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8401
8402 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8403
8404         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8405         UNOP_KIND.
8406         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8407         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8408         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8409         (operator_length_f): New fuction.
8410         (print_subexp_f): New function.
8411         (op_name_f): New function.
8412         (dump_subexp_body_f): New function.
8413         (operator_check_f): New function.
8414         (exp_descriptor_f): Replace standard expression handling functions
8415         with new functions.
8416         * gdb/fortran-operator.def: New file.
8417         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8418         * gdb/std-operator.def: Remove UNOP_KIND.
8419
8420 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8421
8422         * std-operator.def: Remove unbalanced, stray double quote
8423         character.
8424
8425 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8426             Chris January  <chris.january@arm.com>
8427             Daniel Everett  <daniel.everett@arm.com>
8428             Nick Forrington  <nick.forrington@arm.com>
8429             Richard Bunt  <richard.bunt@arm.com>
8430
8431         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8432         of depth when printing anonymous structs or unions.
8433         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8434         Don't print either the top-level value, or the children if the
8435         max-depth is exceeded.
8436         (ppscm_print_children): When printing the key of a map, allow one
8437         extra level of depth.
8438         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8439         print either the top-level value, or the children if the max-depth
8440         is exceeded.
8441         (print_children): When printing the key of a map, allow one extra
8442         level of depth.
8443         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8444         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8445         (user_print_options): Initialise max_depth field.
8446         (val_print_scalar_or_string_type_p): New function.
8447         (val_print): Check to see if the max depth has been reached.
8448         (val_print_check_max_depth): Define new function.
8449         (show_print_max_depth): New function.
8450         (_initialize_valprint): Add 'print max-depth' option.
8451         * valprint.h (struct value_print_options) <max_depth>: New field.
8452         (val_print_check_max_depth): Declare new function.
8453         * NEWS: Document new feature.
8454
8455 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8456
8457         * ada-lang.c (ada_language_defn): Initialise new field.
8458         * c-lang.c (c_is_string_type_p): New function.
8459         (c_language_defn): Initialise new field.
8460         (cplus_language_defn): Initialise new field.
8461         (asm_language_defn): Initialise new field.
8462         (minimal_language_defn): Initialise new field.
8463         * c-lang.h (c_is_string_type_p): Declare new function.
8464         * d-lang.c (d_language_defn): Initialise new field.
8465         * f-lang.c (f_is_string_type_p): New function.
8466         (f_language_defn): Initialise new field.
8467         * go-lang.c (go_is_string_type_p): New function.
8468         (go_language_defn): Initialise new field.
8469         * language.c (default_is_string_type_p): New function.
8470         (unknown_language_defn): Initialise new field.
8471         (auto_language_defn): Initialise new field.
8472         * language.h (struct language_defn) <la_is_string_type_p>: New
8473         member variable.
8474         (default_is_string_type_p): Declare new function.
8475         * m2-lang.c (m2_language_defn): Initialise new field.
8476         * objc-lang.c (objc_language_defn): Initialise new field.
8477         * opencl-lang.c (opencl_language_defn): Initialise new field.
8478         * p-lang.c (pascal_is_string_type_p): New function.
8479         (pascal_language_defn): Initialise new field.
8480         * rust-lang.c (rust_is_string_type_p): New function.
8481         (rust_language_defn): Initialise new field.
8482
8483 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8484
8485         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8486         New field.
8487         * ada-lang.c (ada_language_defn): Initialise new field.
8488         * c-lang.c (c_language_defn): Likewise.
8489         (cplus_language_defn): Likewise.
8490         (asm_language_defn): Likewise.
8491         (minimal_language_defn): Likewise.
8492         * d-lang.c (d_language_defn): Likewise.
8493         * f-lang.c (f_language_defn): Likewise.
8494         * go-lang.c (go_language_defn): Likewise.
8495         * language.c (unknown_language_defn): Likewise.
8496         (auto_language_defn): Likewise.
8497         * m2-lang.c (m2_language_defn): Likewise.
8498         * objc-lang.c (objc_language_defn): Likewise.
8499         * opencl-lang.c (opencl_language_defn): Likewise.
8500         * p-lang.c (pascal_language_defn): Likewise.
8501         * rust-lang.c (rust_language_defn): Likewise.
8502
8503 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8504
8505         * ada-lang.c (ada_is_character_type): Change return type to bool.
8506         (ada_is_string_type): Likewise.
8507         * ada-lang.h (ada_is_character_type): Update declaration
8508         (ada_is_string_type): Likewise.
8509
8510 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8511
8512         Support style in 'frame|thread apply'
8513
8514         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8515         * record.c (record_start, record_stop): Update callers of
8516         execute_command_to_string with false.
8517         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8518         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8519         methods.
8520         (class string_file): New constructor with term_out parameter.
8521         Override methods term_out and can_emit_style_escape.  New member
8522         term_out.
8523         (class stdio_file): Override can_emit_style_escape.
8524         (class tee_file): Override term_out and can_emit_style_escape.
8525         * utils.h (can_emit_style_escape): Remove.
8526         * utils.c (can_emit_style_escape): Likewise.
8527         Update all callers of can_emit_style_escape (SOMESTREAM) to
8528         SOMESTREAM->can_emit_style_escape.
8529         * source-cache.c (source_cache::get_source_lines): Likewise.
8530         * stack.c (frame_apply_command_count): Call execute_command_to_string
8531         passing the term_out characteristic of the current gdb_stdout.
8532         * thread.c (thr_try_catch_cmd): Likewise.
8533         * top.c (execute_command_to_string): pass term_out parameter
8534         to construct the string_file for the command output.
8535         * ui-file.c (term_cli_styling): New function (most code moved
8536         from utils.c can_emit_style_escape).
8537         (string_file::string_file, string_file::can_emit_style_escape,
8538         stdio_file::can_emit_style_escape, tee_file::term_out,
8539         tee_file::can_emit_style_escape): New functions.
8540
8541 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8542
8543         * NEWS: Mention the new set|show may-call-functions.
8544         * infcall.c (may_call_functions_p): New variable.
8545         (show_may_call_functions_p): New function.
8546         (call_function_by_hand_dummy): Throws an error if not
8547         may-call-functions.
8548         (_initialize_infcall): Call add_setshow_boolean_cmd for
8549         may-call-functions.
8550
8551 2019-04-25  Keith Seitz  <keiths@redhat.com>
8552
8553         PR c++/24367
8554         * cp-support.c (inspect_type): Don't attempt substitutions
8555         of symbol with the same name.
8556
8557 2019-04-25  Tom Tromey  <tromey@adacore.com>
8558
8559         PR gdb/24475:
8560         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8561         static.
8562
8563 2019-04-25  Tom Tromey  <tromey@adacore.com>
8564
8565         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8566         rvalue reference.
8567         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8568         (gdb_xml_parser::parse): Use std::move.
8569         * python/python-internal.h (gdbpy_convert_exception): Take a const
8570         reference.
8571         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8572         std::move.
8573         * python/py-utils.c (gdbpy_convert_exception): Take a const
8574         reference.
8575         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8576         Use std::move.
8577         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8578         Use std::move.
8579         * mi/mi-main.c (mi_print_exception): Take a const reference.
8580         * main.c (handle_command_errors): Take a const reference.
8581         * linespec.c (parse_linespec): Use std::move.
8582         * infcall.c (run_inferior_call): Use std::move.
8583         (call_function_by_hand_dummy): Use std::move.
8584         * exec.c (try_open_exec_file): Use std::move.
8585         * exceptions.h (exception_print, exception_fprintf)
8586         (exception_print_same): Update.
8587         * exceptions.c (print_exception, exception_print)
8588         (exception_fprintf, exception_print_same): Change parameters to
8589         const reference.
8590         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8591         * common/new-op.c: Use std::move.
8592         * common/common-exceptions.h (struct gdb_exception): Add move
8593         constructor.
8594         (struct gdb_exception_error, struct gdb_exception_quit, struct
8595         gdb_quit_bad_alloc): Change constructor to move constructor.
8596         (throw_exception): Change parameter to rvalue reference.
8597         * common/common-exceptions.c (throw_exception): Take rvalue
8598         reference.
8599         * cli/cli-interp.c (safe_execute_command): Use std::move.
8600         * breakpoint.c (insert_bp_location, location_to_sals): Use
8601         std::move.
8602
8603 2019-04-25  Tom Tromey  <tromey@adacore.com>
8604
8605         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8606         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8607         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8608         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8609         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8610         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8611         guile/scm-value.c: Use unpack.
8612         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8613         gdbscm_gdb_exception.
8614         (gdbscm_throw_gdb_exception): Likewise.
8615         (struct gdbscm_gdb_exception): New.
8616         (unpack): New function.
8617         (gdbscm_wrap): Use unpack.
8618
8619 2019-04-25  Tom Tromey  <tromey@adacore.com>
8620
8621         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8622         (gdb_rl_callback_handler): Use std::move.
8623         * common/common-exceptions.h (struct gdb_exception): Add move
8624         assignment operator.
8625         (throw_exception_sjlj): Change "exception" to const reference.
8626         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8627         (throw_exception_sjlj): Change "exception" to const reference.
8628
8629 2019-04-25  Tom Tromey  <tromey@adacore.com>
8630
8631         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8632         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8633         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8634         Update.
8635         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8636         Update.
8637         * mi/mi-interp.c (mi_interp::exec): Update.
8638         * linespec.c (parse_linespec): Update.
8639         * infcall.c (run_inferior_call): Update.
8640         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8641         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8642         (gdbscm_lookup_global_symbol): Update.
8643         * guile/scm-param.c (gdbscm_parameter_value): Update.
8644         * guile/scm-frame.c (gdbscm_frame_read_register)
8645         (gdbscm_frame_read_var): Update.
8646         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8647         * exec.c (try_open_exec_file): Update.
8648         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8649         (gdb_rl_callback_handler): Update.
8650         * common/common-exceptions.h (exception_none): Don't declare.
8651         * common/common-exceptions.c (exception_none): Don't define.
8652         (struct catcher) <exception>: Update.
8653         * cli/cli-interp.c (safe_execute_command): Update.
8654         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8655
8656 2019-04-25  Ali Tamur  <tamur@google.com>
8657
8658         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8659         (read_attribute_value): Likewise.
8660         (dwarf2_read_addr_index): Update comment.
8661         (read_str_index): Add DW_FORM_strx.
8662         (dwarf2_string_attr): Likewise.
8663         (dwarf2_const_value_attr): Likewise.
8664         (dump_die_shallow): Likewise.
8665         (dwarf2_fetch_constant_bytes): Likewise.
8666         (skip_form_bytes): Likewise.
8667         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8668
8669 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8670
8671         PR corefiles/11608
8672         PR corefiles/18187
8673         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8674         OFFSET.  Verify if current mapping contains an ELF header.
8675         (linux_find_memory_regions_full): Adjust call to
8676         dump_mapping_p.
8677
8678 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8679             Kang Li <kanglictf@gmail.com>
8680
8681         PR gdb/21600
8682
8683         * dwarf2-frame.c (read_initial_length): Be consistent about using
8684         unsigned representation of length.
8685         (decode_frame_entry_1): Likewise.  Check for wraparound of
8686         end pointer as well as buffer overflow.
8687
8688 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8689
8690         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8691         "vq".
8692
8693 2019-04-24  Tom Tromey  <tromey@adacore.com>
8694
8695         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8696
8697 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8698
8699         * s12z-tdep.c (s12z_unwind_pc): Delete.
8700         (s12z_unwind_sp): Delete.
8701         (s12z_gdbarch_init): Don't register deleted functions with
8702         gdbarch.
8703
8704 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8705
8706         * rl78-tdep.c (rl78_unwind_sp): Delete.
8707         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8708
8709 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8710
8711         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8712         (xstormy16_unwind_pc): Delete.
8713         (xstormy16_dummy_id): Delete.
8714         (xstormy16_gdbarch_init): Don't register deleted functions with
8715         gdbarch.
8716
8717 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8718
8719         * vax-tdep.c (vax_unwind_pc): Delete.
8720         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8721
8722 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8723
8724         * v850-tdep.c (v850_unwind_sp): Delete.
8725         (v850_unwind_pc): Delete.
8726         (v850_dummy_id): Delete.
8727         (v850_gdbarch_init): Don't register deleted functions with
8728         gdbarch.
8729
8730 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8731
8732         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8733         (tilegx_unwind_pc): Delete.
8734         (tilegx_unwind_dummy_id): Delete.
8735         (tilegx_gdbarch_init): Don't register deleted functions with
8736         gdbarch.
8737
8738 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8739
8740         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8741         (tic6x_dummy_id): Delete.
8742         (tic6x_gdbarch_init): Don't register deleted functions with
8743         gdbarch.
8744
8745 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8746
8747         * sparc-tdep.c (sparc_unwind_pc): Delete.
8748         (sparc32_gdbarch_init): Don't register deleted function with
8749         gdbarch.
8750
8751 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8752
8753         * sh-tdep.c (sh_unwind_sp): Delete.
8754         (sh_unwind_pc): Delete.
8755         (sh_dummy_id): Delete.
8756         (sh_gdbarch_init): Don't register deleted functions with
8757         gdbarch.
8758
8759 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8760
8761         * score-tdep.c (score_unwind_sp): Delete.
8762         (score_unwind_pc): Delete.
8763         (score_dummy_id): Delete.
8764         (score_gdbarch_init): Don't register deleted functions with
8765         gdbarch.
8766
8767 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8768
8769         * rx-tdep.c (rx_unwind_pc): Delete.
8770         (rx_unwind_sp): Delete.
8771         (rx_dummy_id): Delete.
8772         (rx_gdbarch_init): Don't register deleted functions with
8773         gdbarch.  Update comment.
8774
8775 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8776
8777         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8778         (rs6000_dummy_id): Delete.
8779         (rs6000_gdbarch_init): Don't register deleted functions with
8780         gdbarch.
8781
8782 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8783
8784         * or1k-tdep.c (or1k_dummy_id): Delete.
8785         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8786
8787 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8788
8789         * nios2-tdep.c (nios2_dummy_id): Delete.
8790         (nios2_unwind_sp): Delete.
8791         (nios2_gdbarch_init): Don't register deleted functions with
8792         gdbarch.
8793
8794 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8795
8796         * nds32-tdep.c (nds32_dummy_id): Delete.
8797         (nds32_unwind_pc): Delete.
8798         (nds32_unwind_sp): Delete.
8799         (nds32_gdbarch_init): Don't register deleted functions with
8800         gdbarch.
8801
8802 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8803
8804         * msp430-tdep.c (msp430_unwind_pc): Delete.
8805         (msp430_unwind_sp): Delete.
8806         (msp430_dummy_id): Delete.
8807         (msp430_gdbarch_init): Don't register deleted functions with
8808         gdbarch.
8809
8810 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8811
8812         * moxie-tdep.c (moxie_unwind_sp): Delete.
8813         (moxie_unwind_pc): Delete.
8814         (moxie_dummy_id): Delete.
8815         (moxie_gdbarch_init): Don't register deleted functions with
8816         gdbarch.
8817
8818 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8819
8820         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8821         (mn10300_unwind_pc): Delete.
8822         (mn10300_unwind_sp): Delete.
8823         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8824         mn10300_unwind_sp.
8825         (mn10300_frame_unwind_init): Don't register deleted functions with
8826         gdbarch.
8827
8828 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8829
8830         * mep-tdep.c (mep_unwind_pc): Delete.
8831         (mep_unwind_sp): Delete.
8832         (mep_dummy_id): Delete.
8833         (mep_gdbarch_init): Don't register deleted functions with
8834         gdbarch.
8835
8836 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8837
8838         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8839         (m68hc11_unwind_sp): Delete.
8840         (m68hc11_gdbarch_init): Don't register deleted functions with
8841         gdbarch.
8842
8843 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8844
8845         * m32r-tdep.c (m32r_unwind_sp): Delete.
8846         (m32r_unwind_pc): Delete.
8847         (m32r_dummy_id): Delete.
8848         (m32r_gdbarch_init): Don't register deleted functions with
8849         gdbarch.
8850
8851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8852
8853         * m32c-tdep.c (m32c_unwind_pc): Delete.
8854         (m32c_unwind_sp): Delete.
8855         (m32c_dummy_id): Delete.
8856         (m32c_gdbarch_init): Don't register deleted functions with
8857         gdbarch.
8858
8859 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8860
8861         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8862         (lm32_unwind_pc): Delete.
8863         (lm32_dummy_id): Delete.
8864         (lm32_gdbarch_init): Don't register deleted functions with
8865         gdbarch.
8866
8867 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8868
8869         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8870         (iq2000_unwind_pc): Delete.
8871         (iq2000_dummy_id): Delete.
8872         (iq2000_gdbarch_init): Don't register deleted functions with
8873         gdbarch.
8874
8875 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8876
8877         * nds32-tdep.c (nds32_type_align): Delete.
8878         (nds32_push_dummy_call): Use type_align instead.
8879
8880 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8881
8882         * arm-tdep.c (arm_type_align): Only handle vector override case.
8883         (arm_push_dummy_call): Use type_align.
8884         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8885
8886 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8887
8888         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8889         case.
8890         (pass_on_stack): Use type_align.
8891         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8892         function.
8893
8894 2019-04-23  Tom Tromey  <tromey@adacore.com>
8895
8896         * dwarf2read.c (line_header::file_name_at): Remove unused
8897         overload.
8898
8899 2019-04-23  Tom de Vries  <tdevries@suse.de>
8900
8901         PR gdb/24438
8902         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8903         invocation.
8904
8905
8906 2019-03-27  Ali Tamur  <tamur@google.com>
8907
8908         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8909         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8910         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8911         (dwarf_expr_context::get_addr_index): Likewise
8912         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8913         (symbol_needs_eval_context::get_addr_index): Likewise
8914         (disassemble_dwarf_expression): Add DW_OP_addrx
8915         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8916         (read_cutu_die_from_dwo): Update comment
8917         (skip_one_die): Add DW_FORM_addrx
8918         (read_attribute_value): Likewise
8919         (var_decode_location): Add DW_OP_addrx
8920         (dwarf2_const_value_attr): Add DW_FORM_addrx
8921         (dump_die_shallow): Likewise
8922         (dwarf2_fetch_constant_bytes): Likewise
8923         (decode_locdesc): Add DW_OP_addrx
8924         (skip_form_bytes): Add DW_FORM_addrx
8925
8926 2019-04-22  Ali Tamur  <tamur@google.com>
8927
8928         * MAINTAINERS (Write After Approval): Add self.
8929
8930 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8931
8932         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8933         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8934         (open_symbol_file_object): Likewise.
8935         (svr4_default_sos): Add info parameter.
8936         (svr4_read_so_list): Likewise.
8937         (svr4_current_sos_direct): Adjust functions calls to pass down
8938         info.
8939         (svr4_current_sos_1): Add info parameter.
8940         (svr4_current_sos): Call get_svr4_info, pass info down to
8941         svr4_current_sos_1.
8942         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8943         get_svr4_info.
8944         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8945         get_svr4_info.
8946         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8947         to get_svr4_info.
8948         (probes_table_remove_objfile_probes): Likewise.
8949         (register_solib_event_probe): Add info parameter.
8950         (solist_update_incremental): Pass info parameter down to
8951         svr4_read_so_list.
8952         (disable_probes_interface): Add info parameter.
8953         (svr4_handle_solib_event): Pass current_program_space to
8954         get_svr4_info.  Adjust disable_probes_interface cleanup.
8955         (svr4_create_probe_breakpoints): Add info parameter, pass it
8956         down to register_solib_event_probe.
8957         (svr4_create_solib_event_breakpoints): Add info parameter,
8958         pass it down to svr4_create_probe_breakpoints.
8959         (enable_break): Pass info down to
8960         svr4_create_solib_event_breakpoints.
8961         (svr4_solib_create_inferior_hook): Pass current_program_space to
8962         get_svr4_info.
8963         (svr4_clear_solib): Likewise.
8964
8965 2019-04-22  Pedro Alves  <palves@redhat.com>
8966
8967         * solib-svr4.c (svr4_free_objfile_observer): New.
8968         (probe_and_action::objfile): New field.
8969         (probes_table_htab_remove_objfile_probes)
8970         (probes_table_remove_objfile_probes): New functions.
8971         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8972         in the new probe_and_action.  Don't store the probe in 'lookup'.
8973         (svr4_create_probe_breakpoints): Pass objfile to
8974         register_solib_event_probe.
8975         (_initialize_svr4_solib): Register a free_objfile observer.
8976
8977 2019-04-19  Tom Tromey  <tom@tromey.com>
8978
8979         * common/queue.h: Remove.
8980
8981 2019-04-19  Tom Tromey  <tom@tromey.com>
8982
8983         * event-loop.c: Don't include "common/queue.h".
8984
8985 2019-04-19  Tom Tromey  <tom@tromey.com>
8986
8987         * remote.c (remote_target): Use delete.
8988         * remote-notif.h: Include <list>, not "common/queue.h".
8989         (notif_client_p): Remove typedef.
8990         (remote_notif_state): Add constructor, destructor, initializer.
8991         <notif_queue>: Now a std::list.
8992         (remote_notif_state_xfree): Don't declare.
8993         * remote-notif.c (remote_notif_process, handle_notification)
8994         (remote_notif_state_allocate): Update.
8995         (~remote_notif_state): Rename from remote_notif_state_xfree.
8996
8997 2019-04-19  Tom Tromey  <tom@tromey.com>
8998
8999         * symfile.c (reread_symbols): Update.
9000         * objfiles.c (objfile_register_static_link)
9001         (objfile_lookup_static_link): Update
9002         (~objfile) Don't delete static_links.
9003         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9004
9005 2019-04-19  Tom Tromey  <tom@tromey.com>
9006
9007         * type-stack.h (struct type_stack) <insert>: Constify string.
9008         * type-stack.c (type_stack::insert): Constify string.
9009         * gdbtypes.h (lookup_template_type): Update.
9010         (address_space_name_to_int): Update.
9011         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9012         const.
9013         (lookup_template_type): Make name const.
9014         * c-exp.y: Update rules.
9015         (lex_one_token, classify_name, classify_inner_name)
9016         (c_print_token): Update.
9017         * p-exp.y: Update rules.
9018         (yylex): Update.
9019         * f-exp.y: Update rules.
9020         (yylex): Update.
9021         * d-exp.y: Update rules.
9022         (lex_one_token, classify_name, classify_inner_name): Update.
9023         * parse.c (write_dollar_variable, copy_name): Return std::string.
9024         * parser-defs.h (copy_name): Change return type.
9025         * m2-exp.y: Update rules.
9026         (yylex): Update.
9027         * go-exp.y (lex_one_token): Update.
9028         Update rules.
9029         (classify_unsafe_function, classify_packaged_name)
9030         (classify_name, yylex): Update.
9031
9032 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9033
9034         * configure.ac: add --enable-source-highlight switch.
9035         * configure: Regenerate.
9036         * top.c (print_gdb_version): plumb --enable-source-highlight
9037         status to "show configuration".
9038
9039 2019-04-19  Tom Tromey  <tromey@adacore.com>
9040
9041         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9042         Check ADA_TYPE_P.
9043         (empty_record, ada_template_to_fixed_record_type_1)
9044         (template_to_static_fixed_type)
9045         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9046         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9047         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9048         macros.
9049
9050 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9051
9052         PR symtab/24423:
9053         * source.c (print_source_lines_base): Advance "iter" when a
9054         control character is seen.
9055
9056 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9057
9058         * inferior.h (struct infcall_suspend_state_deleter):
9059         Catch exception in destructor to avoid crash.
9060
9061 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9062
9063         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9064         close to the add_com "shell".
9065
9066 2019-04-18  Tom Tromey  <tromey@adacore.com>
9067
9068         * process-stratum-target.h (class process_stratum_target)
9069         <stratum>: Add "final".
9070
9071 2019-04-17  Tom Tromey  <tromey@adacore.com>
9072
9073         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9074         against nullptr before use.
9075
9076 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9077
9078         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9079
9080 2019-04-17  Jim Wilson  <jimw@sifive.com>
9081             Andrew Burgess  <andrew.burgess@embecosm.com>
9082
9083         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9084         code read might fail, assume 4-byte breakpoint in that case.
9085
9086 2019-04-15  Leszek Swirski  <leszeks@google.com>
9087
9088         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9089         rather than a hand-rolled POD check when checking for forced MEMORY
9090         classification.
9091
9092 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9093
9094         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9095         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9096         function.
9097         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9098         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9099         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9100         declaration.
9101
9102 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9103
9104         * aarch64-linux-nat.c
9105         (aarch64_linux_nat_target::thread_architecture): Add override.
9106         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9107         each VQ.
9108
9109 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9110
9111         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9112
9113 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9114
9115         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9116         target types of size 96-bits, add some additional comments, and
9117         check that the builtin type we found was the correct size.
9118
9119 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9120
9121         * utils.c (prompt_for_continue): Don't restore the styling at the
9122         end, as applied_style has the wrong value.  This fixes styling in
9123         long lists of file names that are interrupted by the "Continue?"
9124         prompt.
9125
9126 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9127
9128         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9129         * c-lang.c (c_language_defn): Likewise.
9130         (cplus_language_defn): Likewise.
9131         (asm_language_defn): Likewise.
9132         (minimal_language_defn): Likewise.
9133         * d-lang.c (d_language_defn): Likewise.
9134         * f-lang.c (f_language_defn): Likewise.
9135         * go-lang.c (go_language_defn): Likewise.
9136         * language.c (unknown_language_defn): Likewise.
9137         (auto_language_defn): Likewise.
9138         * language.h (struct language_defn): Remove la_magic field.
9139         (LANG_MAGIC): Delete.
9140         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9141         * objc-lang.c (objc_language_defn): Likewise.
9142         * opencl-lang.c (opencl_language_defn): Likewise.
9143         * p-lang.c (pascal_language_defn): Likewise.
9144         * rust-lang.c (rust_language_defn): Likewise.
9145
9146 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9147
9148         * riscv-tdep.c (riscv_type_align): New function.
9149         (riscv_type_alignment): Delete.
9150         (riscv_arg_location): Use 'type_align'.
9151         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9152
9153 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9154
9155         * gdbtypes.c (type_align): A struct with no non-static fields also
9156         has alignment of 1.
9157
9158 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9159
9160         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9161         component to 0.
9162         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9163         member.
9164         (riscv_struct_info::analyse): New implementation using new
9165         analyse_inner member function.
9166         (riscv_struct_info::field_offset): New member function.
9167         (riscv_struct_info::m_offsets): New member variable.
9168         (riscv_struct_info::analyse_inner): New private member function,
9169         takes the old implementation of riscv_struct_info::analyse but
9170         extended to track field offsets.
9171         (riscv_call_arg_struct): Update the struct folding special cases
9172         to handle cases where empty C++ structs, which are non-zero
9173         length, are found.
9174         (riscv_arg_location): Initialise the length of each location, a
9175         non-zero length now indicates the location is in use.
9176         (riscv_push_dummy_call): Allow for the first location having a
9177         non-zero offset when setting up arguments.
9178         (riscv_return_value): Likewise, but for return values.
9179
9180 2019-04-11  Tom Tromey  <tromey@adacore.com>
9181
9182         * utils.c (internal_vproblem): Make "msg" const.
9183
9184 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9185
9186         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9187         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9188         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9189         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9190
9191 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9192
9193         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9194         function.
9195         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9196         of amd64_collect_native_gregset.
9197         (amd64_linux_nat_target::store_registers): Likewise.
9198
9199 2019-04-10  Tom Tromey  <tom@tromey.com>
9200
9201         * symtab.c (lookup_global_symbol_from_objfile)
9202         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9203         * objfiles.h (class separate_debug_iterator): New.
9204         (class separate_debug_range): New.
9205         (struct objfile) <separate_debug_objfiles>: New method.
9206         (objfile_separate_debug_iterate): Don't declare.
9207         * objfiles.c (separate_debug_iterator::operator++): Rename from
9208         objfile_separate_debug_iterate.
9209         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9210         iterator.
9211         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9212         iterator.
9213
9214 2019-04-10  Tom Tromey  <tom@tromey.com>
9215
9216         * symfile.c (reread_symbols): Remove old comment.
9217         * objfiles.c (free_all_objfiles): Fix a typo.
9218
9219 2019-04-10  Tom Tromey  <tom@tromey.com>
9220
9221         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9222         * minsyms.c (lookup_minimal_symbol): Use foreach.
9223         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9224         (lookup_minimal_symbol_solib_trampoline): Likewise.
9225         * symfile.c (reread_symbols): Use foreach.
9226
9227 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9228             Tom Tromey  <tromey@adacore.com>
9229
9230         PR rust/24414:
9231         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9232         (rust_lex_int_test): Change "value" to be LONGEST.
9233         (rust_lex_tests): Add test for long integer literal.
9234
9235 2019-04-09  Tom Tromey  <tromey@adacore.com>
9236
9237         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9238         to bool.
9239         (extended_remote_target::attach): Update.
9240         (remote_target::remote_notice_new_inferior): Update.
9241         (remote_target::add_current_inferior_and_thread): Update.
9242         * inferior.c (exit_inferior_1): Use "false".
9243         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9244
9245 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9246
9247         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9248         the "start" command.
9249
9250 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9251
9252         * python/py-inferior.c (infpy_thread_from_thread_handle):
9253         Adjust comments to reflect renaming of thread_from_thread_handle
9254         to thread_from_handle.  Adjust keywords.  Fix type error message.
9255         (inferior_object_methods): Add thread_from_handle.  Retain
9256         thread_from_thread_handle, but mark it as deprecated.
9257
9258 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9259
9260         * gdbthread.h (find_thread_by_handle): Revise declaration.
9261         * thread.c (find_thread_by_handle): Likewise.  Adjust
9262         implementation too.
9263         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9264         support for buffer objects as handles.
9265
9266 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9267
9268         * python/py-infthread.c (thpy_thread_handle): New function.
9269         (thread_object_methods): Register thpy_thread_handle.
9270
9271 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9272
9273         * gdbthread.h (thread_to_thread_handle): Declare.
9274         * thread.c (gdbtypes.h): Include.
9275         (thread_to_thread_handle): New function.
9276
9277         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9278         (target_thread_info_to_thread_handle): Declare.
9279         * target.c (target_thread_info_to_thread_handle): New function.
9280         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9281         * target-delegates.c: Regenerate.
9282
9283         * linux-thread-db.c (class thread_db_target): Add method
9284         thread_info_to_thread_handle.
9285         (thread_db_target::thread_info_to_thread_handle): Define.
9286         * remote.c (class remote_target): Add new method
9287         thread_info_to_thread_handle.
9288         (remote_target::thread_info_to_thread_handle): Define.
9289
9290 2019-04-08  Pedro Alves  <palves@redhat.com>
9291
9292         * common/common-exceptions.c (throw_exception): Don't create
9293         named object to throw; throw directly.
9294         (throw_it): Likewise.  Don't initialize gdb_exception::message
9295         here, with new; pass FMT and AP to the ctor instead.
9296         * common/common-exceptions.h: Include <string>.
9297         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9298         const char *, va_list)): New ctor.  Use std::make_shared.
9299         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9300         errors)): Delete.
9301         (gdb_exception_error::gdb_exception_error(enum errors, const char
9302         *, va_list)): New.
9303         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9304         Add assertion.
9305         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9306         errors)): Delete.
9307         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9308         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9309         Add assertion.
9310
9311 2019-04-08  Tom Tromey  <tom@tromey.com>
9312
9313         * valops.c (value_rtti_indirect_type): Replace throw_exception
9314         with throw.
9315         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9316         with throw.
9317         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9318         throw.
9319         * target.c (target_translate_tls_address): Replace throw_exception
9320         with throw.
9321         * stack.c (frame_apply_command_count): Replace throw_exception
9322         with throw.
9323         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9324         throw.
9325         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9326         with throw.
9327         * rs6000-tdep.c (rs6000_frame_cache)
9328         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9329         * remote.c: Replace throw_exception with throw.
9330         * record-full.c (record_full_message, record_full_wait_1)
9331         (record_full_restore): Replace throw_exception with throw.
9332         * record-btrace.c:
9333         (get_thread_current_frame_id, record_btrace_start_replaying)
9334         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9335         (cmd_record_btrace_start): Replace throw_exception with throw.
9336         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9337         throw.
9338         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9339         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9340         * linespec.c:
9341         (find_linespec_symbols): Replace throw_exception with throw.
9342         * infrun.c (displaced_step_prepare, resume): Replace
9343         throw_exception with throw.
9344         * infcmd.c (post_create_inferior): Replace throw_exception with
9345         throw.
9346         * inf-loop.c (inferior_event_handler): Replace throw_exception
9347         with throw.
9348         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9349         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9350         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9351         (get_prev_frame_always, get_frame_pc_if_available)
9352         (get_frame_address_in_block_if_available, get_frame_language):
9353         Replace throw_exception with throw.
9354         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9355         throw_exception with throw.
9356         * eval.c (fetch_subexp_value, evaluate_var_value)
9357         (evaluate_funcall, evaluate_subexp_standard): Replace
9358         throw_exception with throw.
9359         * dwarf2loc.c (call_site_find_chain)
9360         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9361         Replace throw_exception with throw.
9362         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9363         with throw.
9364         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9365         throw.
9366         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9367         * completer.c (complete_line_internal): Replace throw_exception
9368         with throw.
9369         * compile/compile-object-run.c (compile_object_run): Replace
9370         throw_exception with throw.
9371         * cli/cli-script.c (process_next_line): Replace throw_exception
9372         with throw.
9373         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9374         (btrace_enable, btrace_maint_update_pt_packets): Replace
9375         throw_exception with throw.
9376         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9377         throw_exception with throw.
9378         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9379         throw_exception with throw.
9380         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9381         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9382         * aarch64-tdep.c (aarch64_make_prologue_cache)
9383         (aarch64_make_stub_cache): Replace throw_exception with throw.
9384
9385 2019-04-08  Tom Tromey  <tom@tromey.com>
9386
9387         * common/common-exceptions.c (throw_exception): Rename from
9388         throw_exception_cxx.  Remove old copy.  Make argument const.
9389         (throw_it): Create and throw exception objects directly.
9390         * common/common-exceptions.h (throw_exception): Make argument
9391         const.
9392         (struct gdb_exception_error): Add constructor.
9393         (struct gdb_exception_quit): Add constructor.
9394
9395 2019-04-08  Tom Tromey  <tom@tromey.com>
9396
9397         * common/common-exceptions.h (exception_rethrow): Don't declare.
9398         (TRY_SJLJ): Update comment.
9399         (TRY, CATCH, END_CATCH): Remove.
9400         * common/common-exceptions.c (exception_rethrow): Remove.
9401
9402 2019-04-08  Tom Tromey  <tom@tromey.com>
9403
9404         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9405         Remove.
9406         (gdb_exception_error): Rename from
9407         gdb_exception_RETURN_MASK_ERROR.
9408         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9409         (gdb_quit_bad_alloc): Update.
9410         * aarch64-tdep.c: Update.
9411         * ada-lang.c: Update.
9412         * ada-typeprint.c: Update.
9413         * ada-valprint.c: Update.
9414         * amd64-tdep.c: Update.
9415         * arch-utils.c: Update.
9416         * break-catch-throw.c: Update.
9417         * breakpoint.c: Update.
9418         * btrace.c: Update.
9419         * c-varobj.c: Update.
9420         * cli/cli-cmds.c: Update.
9421         * cli/cli-interp.c: Update.
9422         * cli/cli-script.c: Update.
9423         * common/common-exceptions.c: Update.
9424         * common/new-op.c: Update.
9425         * common/selftest.c: Update.
9426         * compile/compile-c-symbols.c: Update.
9427         * compile/compile-cplus-symbols.c: Update.
9428         * compile/compile-object-load.c: Update.
9429         * compile/compile-object-run.c: Update.
9430         * completer.c: Update.
9431         * corelow.c: Update.
9432         * cp-abi.c: Update.
9433         * cp-support.c: Update.
9434         * cp-valprint.c: Update.
9435         * darwin-nat.c: Update.
9436         * disasm-selftests.c: Update.
9437         * dtrace-probe.c: Update.
9438         * dwarf-index-cache.c: Update.
9439         * dwarf-index-write.c: Update.
9440         * dwarf2-frame-tailcall.c: Update.
9441         * dwarf2-frame.c: Update.
9442         * dwarf2loc.c: Update.
9443         * dwarf2read.c: Update.
9444         * eval.c: Update.
9445         * event-loop.c: Update.
9446         * event-top.c: Update.
9447         * exec.c: Update.
9448         * f-valprint.c: Update.
9449         * fbsd-tdep.c: Update.
9450         * frame-unwind.c: Update.
9451         * frame.c: Update.
9452         * gdbtypes.c: Update.
9453         * gnu-v3-abi.c: Update.
9454         * guile/guile-internal.h: Update.
9455         * guile/scm-block.c: Update.
9456         * guile/scm-breakpoint.c: Update.
9457         * guile/scm-cmd.c: Update.
9458         * guile/scm-disasm.c: Update.
9459         * guile/scm-frame.c: Update.
9460         * guile/scm-lazy-string.c: Update.
9461         * guile/scm-math.c: Update.
9462         * guile/scm-param.c: Update.
9463         * guile/scm-ports.c: Update.
9464         * guile/scm-pretty-print.c: Update.
9465         * guile/scm-symbol.c: Update.
9466         * guile/scm-symtab.c: Update.
9467         * guile/scm-type.c: Update.
9468         * guile/scm-value.c: Update.
9469         * i386-linux-tdep.c: Update.
9470         * i386-tdep.c: Update.
9471         * inf-loop.c: Update.
9472         * infcall.c: Update.
9473         * infcmd.c: Update.
9474         * infrun.c: Update.
9475         * jit.c: Update.
9476         * language.c: Update.
9477         * linespec.c: Update.
9478         * linux-fork.c: Update.
9479         * linux-nat.c: Update.
9480         * linux-tdep.c: Update.
9481         * linux-thread-db.c: Update.
9482         * main.c: Update.
9483         * mi/mi-cmd-break.c: Update.
9484         * mi/mi-cmd-stack.c: Update.
9485         * mi/mi-interp.c: Update.
9486         * mi/mi-main.c: Update.
9487         * objc-lang.c: Update.
9488         * p-valprint.c: Update.
9489         * parse.c: Update.
9490         * ppc-linux-tdep.c: Update.
9491         * printcmd.c: Update.
9492         * python/py-arch.c: Update.
9493         * python/py-breakpoint.c: Update.
9494         * python/py-cmd.c: Update.
9495         * python/py-finishbreakpoint.c: Update.
9496         * python/py-frame.c: Update.
9497         * python/py-framefilter.c: Update.
9498         * python/py-gdb-readline.c: Update.
9499         * python/py-inferior.c: Update.
9500         * python/py-infthread.c: Update.
9501         * python/py-lazy-string.c: Update.
9502         * python/py-linetable.c: Update.
9503         * python/py-objfile.c: Update.
9504         * python/py-param.c: Update.
9505         * python/py-prettyprint.c: Update.
9506         * python/py-progspace.c: Update.
9507         * python/py-record-btrace.c: Update.
9508         * python/py-record.c: Update.
9509         * python/py-symbol.c: Update.
9510         * python/py-type.c: Update.
9511         * python/py-unwind.c: Update.
9512         * python/py-utils.c: Update.
9513         * python/py-value.c: Update.
9514         * python/python.c: Update.
9515         * record-btrace.c: Update.
9516         * record-full.c: Update.
9517         * remote-fileio.c: Update.
9518         * remote.c: Update.
9519         * riscv-tdep.c: Update.
9520         * rs6000-aix-tdep.c: Update.
9521         * rs6000-tdep.c: Update.
9522         * rust-exp.y: Update.
9523         * rust-lang.c: Update.
9524         * s390-tdep.c: Update.
9525         * selftest-arch.c: Update.
9526         * solib-dsbt.c: Update.
9527         * solib-frv.c: Update.
9528         * solib-spu.c: Update.
9529         * solib-svr4.c: Update.
9530         * solib.c: Update.
9531         * sparc64-linux-tdep.c: Update.
9532         * stack.c: Update.
9533         * symfile-mem.c: Update.
9534         * symmisc.c: Update.
9535         * target.c: Update.
9536         * thread.c: Update.
9537         * top.c: Update.
9538         * tracefile-tfile.c: Update.
9539         * tui/tui.c: Update.
9540         * typeprint.c: Update.
9541         * unittests/cli-utils-selftests.c: Update.
9542         * unittests/parse-connection-spec-selftests.c: Update.
9543         * valops.c: Update.
9544         * valprint.c: Update.
9545         * value.c: Update.
9546         * varobj.c: Update.
9547         * windows-nat.c: Update.
9548         * x86-linux-nat.c: Update.
9549         * xml-support.c: Update.
9550
9551 2019-04-08  Tom Tromey  <tom@tromey.com>
9552
9553         * xml-support.c: Use C++ exception handling.
9554         * x86-linux-nat.c: Use C++ exception handling.
9555         * windows-nat.c: Use C++ exception handling.
9556         * varobj.c: Use C++ exception handling.
9557         * value.c: Use C++ exception handling.
9558         * valprint.c: Use C++ exception handling.
9559         * valops.c: Use C++ exception handling.
9560         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9561         handling.
9562         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9563         * typeprint.c: Use C++ exception handling.
9564         * tui/tui.c: Use C++ exception handling.
9565         * tracefile-tfile.c: Use C++ exception handling.
9566         * top.c: Use C++ exception handling.
9567         * thread.c: Use C++ exception handling.
9568         * target.c: Use C++ exception handling.
9569         * symmisc.c: Use C++ exception handling.
9570         * symfile-mem.c: Use C++ exception handling.
9571         * stack.c: Use C++ exception handling.
9572         * sparc64-linux-tdep.c: Use C++ exception handling.
9573         * solib.c: Use C++ exception handling.
9574         * solib-svr4.c: Use C++ exception handling.
9575         * solib-spu.c: Use C++ exception handling.
9576         * solib-frv.c: Use C++ exception handling.
9577         * solib-dsbt.c: Use C++ exception handling.
9578         * selftest-arch.c: Use C++ exception handling.
9579         * s390-tdep.c: Use C++ exception handling.
9580         * rust-lang.c: Use C++ exception handling.
9581         * rust-exp.y: Use C++ exception handling.
9582         * rs6000-tdep.c: Use C++ exception handling.
9583         * rs6000-aix-tdep.c: Use C++ exception handling.
9584         * riscv-tdep.c: Use C++ exception handling.
9585         * remote.c: Use C++ exception handling.
9586         * remote-fileio.c: Use C++ exception handling.
9587         * record-full.c: Use C++ exception handling.
9588         * record-btrace.c: Use C++ exception handling.
9589         * python/python.c: Use C++ exception handling.
9590         * python/py-value.c: Use C++ exception handling.
9591         * python/py-utils.c: Use C++ exception handling.
9592         * python/py-unwind.c: Use C++ exception handling.
9593         * python/py-type.c: Use C++ exception handling.
9594         * python/py-symbol.c: Use C++ exception handling.
9595         * python/py-record.c: Use C++ exception handling.
9596         * python/py-record-btrace.c: Use C++ exception handling.
9597         * python/py-progspace.c: Use C++ exception handling.
9598         * python/py-prettyprint.c: Use C++ exception handling.
9599         * python/py-param.c: Use C++ exception handling.
9600         * python/py-objfile.c: Use C++ exception handling.
9601         * python/py-linetable.c: Use C++ exception handling.
9602         * python/py-lazy-string.c: Use C++ exception handling.
9603         * python/py-infthread.c: Use C++ exception handling.
9604         * python/py-inferior.c: Use C++ exception handling.
9605         * python/py-gdb-readline.c: Use C++ exception handling.
9606         * python/py-framefilter.c: Use C++ exception handling.
9607         * python/py-frame.c: Use C++ exception handling.
9608         * python/py-finishbreakpoint.c: Use C++ exception handling.
9609         * python/py-cmd.c: Use C++ exception handling.
9610         * python/py-breakpoint.c: Use C++ exception handling.
9611         * python/py-arch.c: Use C++ exception handling.
9612         * printcmd.c: Use C++ exception handling.
9613         * ppc-linux-tdep.c: Use C++ exception handling.
9614         * parse.c: Use C++ exception handling.
9615         * p-valprint.c: Use C++ exception handling.
9616         * objc-lang.c: Use C++ exception handling.
9617         * mi/mi-main.c: Use C++ exception handling.
9618         * mi/mi-interp.c: Use C++ exception handling.
9619         * mi/mi-cmd-stack.c: Use C++ exception handling.
9620         * mi/mi-cmd-break.c: Use C++ exception handling.
9621         * main.c: Use C++ exception handling.
9622         * linux-thread-db.c: Use C++ exception handling.
9623         * linux-tdep.c: Use C++ exception handling.
9624         * linux-nat.c: Use C++ exception handling.
9625         * linux-fork.c: Use C++ exception handling.
9626         * linespec.c: Use C++ exception handling.
9627         * language.c: Use C++ exception handling.
9628         * jit.c: Use C++ exception handling.
9629         * infrun.c: Use C++ exception handling.
9630         * infcmd.c: Use C++ exception handling.
9631         * infcall.c: Use C++ exception handling.
9632         * inf-loop.c: Use C++ exception handling.
9633         * i386-tdep.c: Use C++ exception handling.
9634         * i386-linux-tdep.c: Use C++ exception handling.
9635         * guile/scm-value.c: Use C++ exception handling.
9636         * guile/scm-type.c: Use C++ exception handling.
9637         * guile/scm-symtab.c: Use C++ exception handling.
9638         * guile/scm-symbol.c: Use C++ exception handling.
9639         * guile/scm-pretty-print.c: Use C++ exception handling.
9640         * guile/scm-ports.c: Use C++ exception handling.
9641         * guile/scm-param.c: Use C++ exception handling.
9642         * guile/scm-math.c: Use C++ exception handling.
9643         * guile/scm-lazy-string.c: Use C++ exception handling.
9644         * guile/scm-frame.c: Use C++ exception handling.
9645         * guile/scm-disasm.c: Use C++ exception handling.
9646         * guile/scm-cmd.c: Use C++ exception handling.
9647         * guile/scm-breakpoint.c: Use C++ exception handling.
9648         * guile/scm-block.c: Use C++ exception handling.
9649         * guile/guile-internal.h: Use C++ exception handling.
9650         * gnu-v3-abi.c: Use C++ exception handling.
9651         * gdbtypes.c: Use C++ exception handling.
9652         * frame.c: Use C++ exception handling.
9653         * frame-unwind.c: Use C++ exception handling.
9654         * fbsd-tdep.c: Use C++ exception handling.
9655         * f-valprint.c: Use C++ exception handling.
9656         * exec.c: Use C++ exception handling.
9657         * event-top.c: Use C++ exception handling.
9658         * event-loop.c: Use C++ exception handling.
9659         * eval.c: Use C++ exception handling.
9660         * dwarf2read.c: Use C++ exception handling.
9661         * dwarf2loc.c: Use C++ exception handling.
9662         * dwarf2-frame.c: Use C++ exception handling.
9663         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9664         * dwarf-index-write.c: Use C++ exception handling.
9665         * dwarf-index-cache.c: Use C++ exception handling.
9666         * dtrace-probe.c: Use C++ exception handling.
9667         * disasm-selftests.c: Use C++ exception handling.
9668         * darwin-nat.c: Use C++ exception handling.
9669         * cp-valprint.c: Use C++ exception handling.
9670         * cp-support.c: Use C++ exception handling.
9671         * cp-abi.c: Use C++ exception handling.
9672         * corelow.c: Use C++ exception handling.
9673         * completer.c: Use C++ exception handling.
9674         * compile/compile-object-run.c: Use C++ exception handling.
9675         * compile/compile-object-load.c: Use C++ exception handling.
9676         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9677         * compile/compile-c-symbols.c: Use C++ exception handling.
9678         * common/selftest.c: Use C++ exception handling.
9679         * common/new-op.c: Use C++ exception handling.
9680         * cli/cli-script.c: Use C++ exception handling.
9681         * cli/cli-interp.c: Use C++ exception handling.
9682         * cli/cli-cmds.c: Use C++ exception handling.
9683         * c-varobj.c: Use C++ exception handling.
9684         * btrace.c: Use C++ exception handling.
9685         * breakpoint.c: Use C++ exception handling.
9686         * break-catch-throw.c: Use C++ exception handling.
9687         * arch-utils.c: Use C++ exception handling.
9688         * amd64-tdep.c: Use C++ exception handling.
9689         * ada-valprint.c: Use C++ exception handling.
9690         * ada-typeprint.c: Use C++ exception handling.
9691         * ada-lang.c: Use C++ exception handling.
9692         * aarch64-tdep.c: Use C++ exception handling.
9693
9694 2019-04-08  Tom Tromey  <tom@tromey.com>
9695
9696         * xml-support.c (gdb_xml_parser::parse): Update.
9697         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9698         * value.c (show_convenience): Update.
9699         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9700         (test_parse_flags_qcs): Update.
9701         * thread.c (thr_try_catch_cmd): Update.
9702         * target.c (target_translate_tls_address): Update.
9703         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9704         (info_frame_command_core, frame_apply_command_count): Update.
9705         * rust-exp.y (rust_lex_exception_test): Update.
9706         * riscv-tdep.c (riscv_print_one_register_info): Update.
9707         * remote.c (remote_target::enable_btrace): Update.
9708         * record-btrace.c (record_btrace_enable_warn): Update.
9709         * python/py-utils.c (gdbpy_convert_exception): Update.
9710         * printcmd.c (do_one_display, print_variable_and_value): Update.
9711         * mi/mi-main.c (mi_print_exception): Update.
9712         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9713         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9714         * linux-nat.c (linux_nat_target::attach): Update.
9715         * linux-fork.c (class scoped_switch_fork_info): Update.
9716         * infrun.c (displaced_step_prepare): Update.
9717         * infcall.c (call_function_by_hand_dummy): Update.
9718         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9719         * gnu-v3-abi.c (print_one_vtable): Update.
9720         * frame.c (get_prev_frame_always): Update.
9721         * f-valprint.c (info_common_command_for_block): Update.
9722         * exec.c (try_open_exec_file): Update.
9723         * exceptions.c (print_exception, exception_print)
9724         (exception_fprintf, exception_print_same): Update.
9725         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9726         * dwarf-index-cache.c (index_cache::store)
9727         (index_cache::lookup_gdb_index): Update.
9728         * darwin-nat.c (maybe_cache_shell): Update.
9729         * cp-valprint.c (cp_print_value_fields): Update.
9730         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9731         (gcc_cplus_symbol_address): Update.
9732         * compile/compile-c-symbols.c (gcc_convert_symbol)
9733         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9734         * common/selftest.c: Update.
9735         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9736         a std::string.
9737         (exception_try_scope_entry, exception_try_scope_exit): Don't
9738         declare.
9739         (struct exception_try_scope): Remove.
9740         (TRY): Don't use exception_try_scope.
9741         (struct gdb_exception): Add constructor, operator=.
9742         <what>: New method.
9743         (struct gdb_exception_RETURN_MASK_ALL)
9744         (struct gdb_exception_RETURN_MASK_ERROR)
9745         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9746         (struct gdb_quit_bad_alloc): Update.
9747         * common/common-exceptions.c (exception_none): Change
9748         initializer.
9749         (struct catcher) <state, exception>: Initialize inline.
9750         <prev>: Remove member.
9751         (current_catcher): Remove.
9752         (catchers): New global.
9753         (exceptions_state_mc_init): Simplify.
9754         (catcher_pop): Remove.
9755         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9756         (try_scope_depth, exception_try_scope_entry)
9757         (exception_try_scope_exit): Remove.
9758         (throw_exception_sjlj): Update.
9759         (exception_messages, exception_messages_size): Remove.
9760         (throw_it): Simplify.
9761         (gdb_exception_sliced_copy): Remove.
9762         (throw_exception_cxx): Update.
9763         * cli/cli-script.c (script_from_file): Update.
9764         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9765         Update.
9766         * ada-valprint.c (ada_val_print): Update.
9767         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9768         (create_excep_cond_exprs): Update.
9769
9770 2019-04-08  Tom Tromey  <tom@tromey.com>
9771
9772         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9773         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9774         (TRY, CATCH, END_CATCH): Remove some definitions.
9775         * common/common-exceptions.c: Don't use GDB_XCPT.
9776         (catcher_list_size): Remove.
9777         (throw_exception, throw_it): Simplify.
9778
9779 2019-04-05  Tom Tromey  <tom@tromey.com>
9780
9781         Revert the header-sorting patch.
9782         * ft32-tdep.c: Revert.
9783         * frv-tdep.c: Revert.
9784         * frv-linux-tdep.c: Revert.
9785         * frame.c: Revert.
9786         * frame-unwind.c: Revert.
9787         * frame-base.c: Revert.
9788         * fork-child.c: Revert.
9789         * findvar.c: Revert.
9790         * findcmd.c: Revert.
9791         * filesystem.c: Revert.
9792         * filename-seen-cache.h: Revert.
9793         * filename-seen-cache.c: Revert.
9794         * fbsd-tdep.c: Revert.
9795         * fbsd-nat.h: Revert.
9796         * fbsd-nat.c: Revert.
9797         * f-valprint.c: Revert.
9798         * f-typeprint.c: Revert.
9799         * f-lang.c: Revert.
9800         * extension.h: Revert.
9801         * extension.c: Revert.
9802         * extension-priv.h: Revert.
9803         * expprint.c: Revert.
9804         * exec.h: Revert.
9805         * exec.c: Revert.
9806         * exceptions.c: Revert.
9807         * event-top.c: Revert.
9808         * event-loop.c: Revert.
9809         * eval.c: Revert.
9810         * elfread.c: Revert.
9811         * dwarf2read.h: Revert.
9812         * dwarf2read.c: Revert.
9813         * dwarf2loc.c: Revert.
9814         * dwarf2expr.h: Revert.
9815         * dwarf2expr.c: Revert.
9816         * dwarf2-frame.c: Revert.
9817         * dwarf2-frame-tailcall.c: Revert.
9818         * dwarf-index-write.h: Revert.
9819         * dwarf-index-write.c: Revert.
9820         * dwarf-index-common.c: Revert.
9821         * dwarf-index-cache.h: Revert.
9822         * dwarf-index-cache.c: Revert.
9823         * dummy-frame.c: Revert.
9824         * dtrace-probe.c: Revert.
9825         * disasm.h: Revert.
9826         * disasm.c: Revert.
9827         * disasm-selftests.c: Revert.
9828         * dictionary.c: Revert.
9829         * dicos-tdep.c: Revert.
9830         * demangle.c: Revert.
9831         * dcache.h: Revert.
9832         * dcache.c: Revert.
9833         * darwin-nat.h: Revert.
9834         * darwin-nat.c: Revert.
9835         * darwin-nat-info.c: Revert.
9836         * d-valprint.c: Revert.
9837         * d-namespace.c: Revert.
9838         * d-lang.c: Revert.
9839         * ctf.c: Revert.
9840         * csky-tdep.c: Revert.
9841         * csky-linux-tdep.c: Revert.
9842         * cris-tdep.c: Revert.
9843         * cris-linux-tdep.c: Revert.
9844         * cp-valprint.c: Revert.
9845         * cp-support.c: Revert.
9846         * cp-namespace.c: Revert.
9847         * cp-abi.c: Revert.
9848         * corelow.c: Revert.
9849         * corefile.c: Revert.
9850         * continuations.c: Revert.
9851         * completer.h: Revert.
9852         * completer.c: Revert.
9853         * complaints.c: Revert.
9854         * coffread.c: Revert.
9855         * coff-pe-read.c: Revert.
9856         * cli-out.h: Revert.
9857         * cli-out.c: Revert.
9858         * charset.c: Revert.
9859         * c-varobj.c: Revert.
9860         * c-valprint.c: Revert.
9861         * c-typeprint.c: Revert.
9862         * c-lang.c: Revert.
9863         * buildsym.c: Revert.
9864         * buildsym-legacy.c: Revert.
9865         * build-id.h: Revert.
9866         * build-id.c: Revert.
9867         * btrace.c: Revert.
9868         * bsd-uthread.c: Revert.
9869         * breakpoint.h: Revert.
9870         * breakpoint.c: Revert.
9871         * break-catch-throw.c: Revert.
9872         * break-catch-syscall.c: Revert.
9873         * break-catch-sig.c: Revert.
9874         * blockframe.c: Revert.
9875         * block.c: Revert.
9876         * bfin-tdep.c: Revert.
9877         * bfin-linux-tdep.c: Revert.
9878         * bfd-target.c: Revert.
9879         * bcache.c: Revert.
9880         * ax-general.c: Revert.
9881         * ax-gdb.h: Revert.
9882         * ax-gdb.c: Revert.
9883         * avr-tdep.c: Revert.
9884         * auxv.c: Revert.
9885         * auto-load.c: Revert.
9886         * arm-wince-tdep.c: Revert.
9887         * arm-tdep.c: Revert.
9888         * arm-symbian-tdep.c: Revert.
9889         * arm-pikeos-tdep.c: Revert.
9890         * arm-obsd-tdep.c: Revert.
9891         * arm-nbsd-tdep.c: Revert.
9892         * arm-nbsd-nat.c: Revert.
9893         * arm-linux-tdep.c: Revert.
9894         * arm-linux-nat.c: Revert.
9895         * arm-fbsd-tdep.c: Revert.
9896         * arm-fbsd-nat.c: Revert.
9897         * arm-bsd-tdep.c: Revert.
9898         * arch-utils.c: Revert.
9899         * arc-tdep.c: Revert.
9900         * arc-newlib-tdep.c: Revert.
9901         * annotate.h: Revert.
9902         * annotate.c: Revert.
9903         * amd64-windows-tdep.c: Revert.
9904         * amd64-windows-nat.c: Revert.
9905         * amd64-tdep.c: Revert.
9906         * amd64-sol2-tdep.c: Revert.
9907         * amd64-obsd-tdep.c: Revert.
9908         * amd64-obsd-nat.c: Revert.
9909         * amd64-nbsd-tdep.c: Revert.
9910         * amd64-nbsd-nat.c: Revert.
9911         * amd64-nat.c: Revert.
9912         * amd64-linux-tdep.c: Revert.
9913         * amd64-linux-nat.c: Revert.
9914         * amd64-fbsd-tdep.c: Revert.
9915         * amd64-fbsd-nat.c: Revert.
9916         * amd64-dicos-tdep.c: Revert.
9917         * amd64-darwin-tdep.c: Revert.
9918         * amd64-bsd-nat.c: Revert.
9919         * alpha-tdep.c: Revert.
9920         * alpha-obsd-tdep.c: Revert.
9921         * alpha-nbsd-tdep.c: Revert.
9922         * alpha-mdebug-tdep.c: Revert.
9923         * alpha-linux-tdep.c: Revert.
9924         * alpha-linux-nat.c: Revert.
9925         * alpha-bsd-tdep.c: Revert.
9926         * alpha-bsd-nat.c: Revert.
9927         * aix-thread.c: Revert.
9928         * agent.c: Revert.
9929         * addrmap.c: Revert.
9930         * ada-varobj.c: Revert.
9931         * ada-valprint.c: Revert.
9932         * ada-typeprint.c: Revert.
9933         * ada-tasks.c: Revert.
9934         * ada-lang.c: Revert.
9935         * aarch64-tdep.c: Revert.
9936         * aarch64-ravenscar-thread.c: Revert.
9937         * aarch64-newlib-tdep.c: Revert.
9938         * aarch64-linux-tdep.c: Revert.
9939         * aarch64-linux-nat.c: Revert.
9940         * aarch64-fbsd-tdep.c: Revert.
9941         * aarch64-fbsd-nat.c: Revert.
9942         * aarch32-linux-nat.c: Revert.
9943
9944 2019-04-05  Tom Tromey  <tom@tromey.com>
9945
9946         * ft32-tdep.c: Sort headers.
9947         * frv-tdep.c: Sort headers.
9948         * frv-linux-tdep.c: Sort headers.
9949         * frame.c: Sort headers.
9950         * frame-unwind.c: Sort headers.
9951         * frame-base.c: Sort headers.
9952         * fork-child.c: Sort headers.
9953         * findvar.c: Sort headers.
9954         * findcmd.c: Sort headers.
9955         * filesystem.c: Sort headers.
9956         * filename-seen-cache.h: Sort headers.
9957         * filename-seen-cache.c: Sort headers.
9958         * fbsd-tdep.c: Sort headers.
9959         * fbsd-nat.h: Sort headers.
9960         * fbsd-nat.c: Sort headers.
9961         * f-valprint.c: Sort headers.
9962         * f-typeprint.c: Sort headers.
9963         * f-lang.c: Sort headers.
9964         * extension.h: Sort headers.
9965         * extension.c: Sort headers.
9966         * extension-priv.h: Sort headers.
9967         * expprint.c: Sort headers.
9968         * exec.h: Sort headers.
9969         * exec.c: Sort headers.
9970         * exceptions.c: Sort headers.
9971         * event-top.c: Sort headers.
9972         * event-loop.c: Sort headers.
9973         * eval.c: Sort headers.
9974         * elfread.c: Sort headers.
9975         * dwarf2read.h: Sort headers.
9976         * dwarf2read.c: Sort headers.
9977         * dwarf2loc.c: Sort headers.
9978         * dwarf2expr.h: Sort headers.
9979         * dwarf2expr.c: Sort headers.
9980         * dwarf2-frame.c: Sort headers.
9981         * dwarf2-frame-tailcall.c: Sort headers.
9982         * dwarf-index-write.h: Sort headers.
9983         * dwarf-index-write.c: Sort headers.
9984         * dwarf-index-common.c: Sort headers.
9985         * dwarf-index-cache.h: Sort headers.
9986         * dwarf-index-cache.c: Sort headers.
9987         * dummy-frame.c: Sort headers.
9988         * dtrace-probe.c: Sort headers.
9989         * disasm.h: Sort headers.
9990         * disasm.c: Sort headers.
9991         * disasm-selftests.c: Sort headers.
9992         * dictionary.c: Sort headers.
9993         * dicos-tdep.c: Sort headers.
9994         * demangle.c: Sort headers.
9995         * dcache.h: Sort headers.
9996         * dcache.c: Sort headers.
9997         * darwin-nat.h: Sort headers.
9998         * darwin-nat.c: Sort headers.
9999         * darwin-nat-info.c: Sort headers.
10000         * d-valprint.c: Sort headers.
10001         * d-namespace.c: Sort headers.
10002         * d-lang.c: Sort headers.
10003         * ctf.c: Sort headers.
10004         * csky-tdep.c: Sort headers.
10005         * csky-linux-tdep.c: Sort headers.
10006         * cris-tdep.c: Sort headers.
10007         * cris-linux-tdep.c: Sort headers.
10008         * cp-valprint.c: Sort headers.
10009         * cp-support.c: Sort headers.
10010         * cp-namespace.c: Sort headers.
10011         * cp-abi.c: Sort headers.
10012         * corelow.c: Sort headers.
10013         * corefile.c: Sort headers.
10014         * continuations.c: Sort headers.
10015         * completer.h: Sort headers.
10016         * completer.c: Sort headers.
10017         * complaints.c: Sort headers.
10018         * coffread.c: Sort headers.
10019         * coff-pe-read.c: Sort headers.
10020         * cli-out.h: Sort headers.
10021         * cli-out.c: Sort headers.
10022         * charset.c: Sort headers.
10023         * c-varobj.c: Sort headers.
10024         * c-valprint.c: Sort headers.
10025         * c-typeprint.c: Sort headers.
10026         * c-lang.c: Sort headers.
10027         * buildsym.c: Sort headers.
10028         * buildsym-legacy.c: Sort headers.
10029         * build-id.h: Sort headers.
10030         * build-id.c: Sort headers.
10031         * btrace.c: Sort headers.
10032         * bsd-uthread.c: Sort headers.
10033         * breakpoint.h: Sort headers.
10034         * breakpoint.c: Sort headers.
10035         * break-catch-throw.c: Sort headers.
10036         * break-catch-syscall.c: Sort headers.
10037         * break-catch-sig.c: Sort headers.
10038         * blockframe.c: Sort headers.
10039         * block.c: Sort headers.
10040         * bfin-tdep.c: Sort headers.
10041         * bfin-linux-tdep.c: Sort headers.
10042         * bfd-target.c: Sort headers.
10043         * bcache.c: Sort headers.
10044         * ax-general.c: Sort headers.
10045         * ax-gdb.h: Sort headers.
10046         * ax-gdb.c: Sort headers.
10047         * avr-tdep.c: Sort headers.
10048         * auxv.c: Sort headers.
10049         * auto-load.c: Sort headers.
10050         * arm-wince-tdep.c: Sort headers.
10051         * arm-tdep.c: Sort headers.
10052         * arm-symbian-tdep.c: Sort headers.
10053         * arm-pikeos-tdep.c: Sort headers.
10054         * arm-obsd-tdep.c: Sort headers.
10055         * arm-nbsd-tdep.c: Sort headers.
10056         * arm-nbsd-nat.c: Sort headers.
10057         * arm-linux-tdep.c: Sort headers.
10058         * arm-linux-nat.c: Sort headers.
10059         * arm-fbsd-tdep.c: Sort headers.
10060         * arm-fbsd-nat.c: Sort headers.
10061         * arm-bsd-tdep.c: Sort headers.
10062         * arch-utils.c: Sort headers.
10063         * arc-tdep.c: Sort headers.
10064         * arc-newlib-tdep.c: Sort headers.
10065         * annotate.h: Sort headers.
10066         * annotate.c: Sort headers.
10067         * amd64-windows-tdep.c: Sort headers.
10068         * amd64-windows-nat.c: Sort headers.
10069         * amd64-tdep.c: Sort headers.
10070         * amd64-sol2-tdep.c: Sort headers.
10071         * amd64-obsd-tdep.c: Sort headers.
10072         * amd64-obsd-nat.c: Sort headers.
10073         * amd64-nbsd-tdep.c: Sort headers.
10074         * amd64-nbsd-nat.c: Sort headers.
10075         * amd64-nat.c: Sort headers.
10076         * amd64-linux-tdep.c: Sort headers.
10077         * amd64-linux-nat.c: Sort headers.
10078         * amd64-fbsd-tdep.c: Sort headers.
10079         * amd64-fbsd-nat.c: Sort headers.
10080         * amd64-dicos-tdep.c: Sort headers.
10081         * amd64-darwin-tdep.c: Sort headers.
10082         * amd64-bsd-nat.c: Sort headers.
10083         * alpha-tdep.c: Sort headers.
10084         * alpha-obsd-tdep.c: Sort headers.
10085         * alpha-nbsd-tdep.c: Sort headers.
10086         * alpha-mdebug-tdep.c: Sort headers.
10087         * alpha-linux-tdep.c: Sort headers.
10088         * alpha-linux-nat.c: Sort headers.
10089         * alpha-bsd-tdep.c: Sort headers.
10090         * alpha-bsd-nat.c: Sort headers.
10091         * aix-thread.c: Sort headers.
10092         * agent.c: Sort headers.
10093         * addrmap.c: Sort headers.
10094         * ada-varobj.c: Sort headers.
10095         * ada-valprint.c: Sort headers.
10096         * ada-typeprint.c: Sort headers.
10097         * ada-tasks.c: Sort headers.
10098         * ada-lang.c: Sort headers.
10099         * aarch64-tdep.c: Sort headers.
10100         * aarch64-ravenscar-thread.c: Sort headers.
10101         * aarch64-newlib-tdep.c: Sort headers.
10102         * aarch64-linux-tdep.c: Sort headers.
10103         * aarch64-linux-nat.c: Sort headers.
10104         * aarch64-fbsd-tdep.c: Sort headers.
10105         * aarch64-fbsd-nat.c: Sort headers.
10106         * aarch32-linux-nat.c: Sort headers.
10107
10108 2019-04-04  Tom Tromey  <tom@tromey.com>
10109
10110         * varobj.c (varobj_create): Update.
10111         * rust-exp.y (struct rust_parser) <update_innermost_block,
10112         lookup_symbol>: New methods.
10113         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10114         Rename.
10115         (rust_parser::rust_lookup_type)
10116         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10117         * printcmd.c (display_command, do_one_display): Update.
10118         * parser-defs.h (struct parser_state) <parser_state>: Add
10119         "tracker" parameter.
10120         (block_tracker): New member.
10121         (class innermost_block_tracker) <innermost_block_tracker>: Add
10122         "types" parameter.
10123         <reset>: Remove method.
10124         (innermost_block): Don't declare.
10125         (null_post_parser): Update.
10126         * parse.c (innermost_block): Remove global.
10127         (write_dollar_variable): Update.
10128         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10129         Remove "tracker_types" parameter.
10130         (parse_expression): Add "tracker" parameter.
10131         (parse_expression_for_completion): Update.
10132         (null_post_parser): Add "tracker" parameter.
10133         * p-exp.y: Update rules.
10134         * m2-exp.y: Update rules.
10135         * language.h (struct language_defn) <la_post_parser>: Add
10136         "tracker" parameter.
10137         * go-exp.y: Update rules.
10138         * f-exp.y: Update rules.
10139         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10140         parameter.
10141         * d-exp.y: Update rules.
10142         * c-exp.y: Update rules.
10143         * breakpoint.c (set_breakpoint_condition): Create an
10144         innermost_block_tracker.
10145         (watch_command_1): Likewise.
10146         * ada-lang.c (resolve): Add "tracker" parameter.
10147         (resolve_subexp): Likewise.
10148         * ada-exp.y (write_var_from_sym): Update.
10149
10150 2019-04-04  Tom Tromey  <tom@tromey.com>
10151
10152         * type-stack.h: New file.
10153         * type-stack.c: New file.
10154         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10155         type-stack.h.
10156         (insert_into_type_stack, insert_type, push_type, push_type_int)
10157         (insert_type_address_space, pop_type, pop_type_int)
10158         (pop_typelist, pop_type_stack, append_type_stack)
10159         (push_type_stack, get_type_stack, push_typelist)
10160         (follow_type_instance_flags, follow_types): Don't declare.
10161         * parse.c (type_stack): Remove global.
10162         (parse_exp_in_context): Update.
10163         (insert_into_type_stack, insert_type, push_type, push_type_int)
10164         (insert_type_address_space, pop_type, pop_type_int)
10165         (pop_typelist, pop_type_stack, append_type_stack)
10166         (push_type_stack, get_type_stack, push_typelist)
10167         (follow_type_instance_flags, follow_types): Remove (moved to
10168         type-stack.c).
10169         * f-exp.y (type_stack): New global.
10170         Update rules.
10171         (push_kind_type, f_parse): Update.
10172         * d-exp.y (type_stack): New global.
10173         Update rules.
10174         (d_parse): Update.
10175         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10176         Update rules.
10177         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10178         (HFILES_NO_SRCDIR): Add type-stack.h.
10179
10180 2019-04-04  Tom Tromey  <tom@tromey.com>
10181
10182         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10183         (rust_parser::convert_ast_to_expression, rust_parse)
10184         (rust_lex_test_completion, rust_lex_tests): Update.
10185         * parser-defs.h (struct expr_completion_state): New.
10186         (struct parser_state) <parser_state>: Add completion parameter.
10187         <mark_struct_expression, mark_completion_tag>: New methods.
10188         <parse_completion, m_completion_state>: New members.
10189         (prefixify_expression, null_post_parser): Update.
10190         (mark_struct_expression, mark_completion_tag): Don't declare.
10191         * parse.c (parse_completion, expout_last_struct)
10192         (expout_tag_completion_type, expout_completion_name): Remove
10193         globals.
10194         (parser_state::mark_struct_expression)
10195         (parser_state::mark_completion_tag): Now methods.
10196         (prefixify_expression): Add last_struct parameter.
10197         (prefixify_subexp): Likewise.
10198         (parse_exp_1): Update.
10199         (parse_exp_in_context): Add cstate parameter.  Update.
10200         (parse_expression_for_completion): Create an
10201         expr_completion_state.
10202         (null_post_parser): Add "completion" parameter.
10203         * p-exp.y: Update rules.
10204         (yylex): Update.
10205         * language.h (struct language_defn) <la_post_parser>: Add
10206         "completing" parameter.
10207         * go-exp.y: Update rules.
10208         (lex_one_token): Update.
10209         * expression.h (parse_completion): Don't declare.
10210         * d-exp.y: Update rules.
10211         (lex_one_token): Update rules.
10212         * c-exp.y: Update rules.
10213         (lex_one_token): Update.
10214         * ada-lang.c (resolve): Add "parse_completion" parameter.
10215         (resolve_subexp): Likewise.
10216         (ada_resolve_function): Likewise.
10217
10218 2019-04-04  Tom Tromey  <tom@tromey.com>
10219
10220         * parser-defs.h (struct parser_state) <start_arglist,
10221         end_arglist>: New methods.
10222         <arglist_len, m_funcall_chain>: New members.
10223         (arglist_len, start_arglist, end_arglist): Don't declare.
10224         * parse.c (arglist_len, funcall_chain): Remove global.
10225         (start_arglist, end_arglist): Remove functions.
10226         (parse_exp_in_context): Update.
10227         * p-exp.y: Update rules.
10228         * m2-exp.y: Update rules.
10229         * go-exp.y: Update rules.
10230         * f-exp.y: Update rules.
10231         * d-exp.y: Update rules.
10232         * c-exp.y: Update rules.
10233
10234 2019-04-04  Tom Tromey  <tom@tromey.com>
10235
10236         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10237         lex_operator, push_back>: New methods.
10238         Update all rules.
10239         (rust_parser::lex_hex, lex_escape): Rename and update.
10240         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10241         (rust_parser::lex_operator): Rename and update.
10242         (rust_parser::lex_number, rustyylex, rustyyerror)
10243         (rust_lex_test_init, rust_lex_test_sequence)
10244         (rust_lex_test_push_back, rust_lex_tests): Update.
10245         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10246         parameter.
10247         <lexptr, prev_lexptr>: New members.
10248         (lexptr, prev_lexptr): Don't declare.
10249         * parse.c (lexptr, prev_lexptr): Remove globals.
10250         (parse_exp_in_context): Update.
10251         * p-exp.y (yylex, yyerror): Update.
10252         * m2-exp.y (parse_number, yylex, yyerror): Update.
10253         * go-exp.y (lex_one_token, yyerror): Update.
10254         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10255         * d-exp.y (lex_one_token, yyerror): Update.
10256         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10257         (lex_one_token, yyerror): Update.
10258         * ada-lex.l (YY_INPUT): Update.
10259         (rewind_to_char): Update.
10260         * ada-exp.y (yyerror): Update.
10261
10262 2019-04-04  Tom Tromey  <tom@tromey.com>
10263
10264         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10265         * parser-defs.h (struct parser_state) <parser_state>: Add new
10266         parameter.
10267         <comma_terminates>: New member.
10268         (comma_terminates): Don't declare global.
10269         * parse.c (comma_terminates): Remove global.
10270         (parse_exp_in_context): Update.
10271         * p-exp.y (yylex): Update.
10272         * m2-exp.y (yylex): Update.
10273         * go-exp.y (lex_one_token): Update.
10274         * f-exp.y (yylex): Update.
10275         * d-exp.y (lex_one_token): Update.
10276         * c-exp.y (lex_one_token): Update.
10277         * ada-lex.l: Update.
10278
10279 2019-04-04  Tom Tromey  <tom@tromey.com>
10280
10281         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10282         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10283         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10284         * parser-defs.h (paren_depth): Don't declare.
10285         * parse.c (paren_depth): Remove global.
10286         (parse_exp_in_context): Update.
10287         * p-exp.y (paren_depth): New global.
10288         (pascal_parse): Initialize it.
10289         * m2-exp.y (paren_depth): New global.
10290         (m2_parse): Initialize it.
10291         * go-exp.y (paren_depth): New global.
10292         (go_parse): Initialize it.
10293         * f-exp.y (paren_depth): New global.
10294         (f_parse): Initialize it.
10295         * d-exp.y (paren_depth): New global.
10296         (d_parse): Initialize it.
10297         * c-exp.y (paren_depth): New global.
10298         (c_parse): Initialize it.
10299         * ada-lex.l (paren_depth): New global.
10300         (lexer_init): Initialize it.
10301
10302 2019-04-04  Tom Tromey  <tom@tromey.com>
10303
10304         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10305         (rust_parser::convert_ast_to_type)
10306         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10307         * parser-defs.h (struct parser_state) <parser_state>: Add
10308         parameters.  Initialize new members.
10309         <expression_context_block, expression_context_pc>: New members.
10310         * parse.c (expression_context_block, expression_context_pc):
10311         Remove globals.
10312         (parse_exp_in_context): Update.
10313         * p-exp.y: Update all rules.
10314         (yylex): Update.
10315         * m2-exp.y: Update all rules.
10316         (yylex): Update.
10317         * go-exp.y (yylex): Update.
10318         * f-exp.y (yylex): Update.
10319         * d-exp.y: Update all rules.
10320         (yylex): Update.
10321         * c-exp.y: Update all rules.
10322         (lex_one_token, classify_name, yylex, c_parse): Update.
10323         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10324
10325 2019-04-04  Tom Tromey  <tom@tromey.com>
10326
10327         * gdbarch.h, gdbarch.c: Rebuild.
10328         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10329         * stap-probe.h:
10330         (struct stap_parse_info): Replace "parser_state" with
10331         "expr_builder".
10332         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10333         (parser_state): New class.
10334         * parse.c (expr_builder): Rename.
10335         (expr_builder::release): Rename.
10336         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10337         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10338         (write_exp_elt_longcst, write_exp_elt_floatcst)
10339         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10340         (write_exp_string_vector, write_exp_bitstring)
10341         (write_exp_msymbol, mark_struct_expression)
10342         (write_dollar_variable)
10343         (insert_type_address_space, increase_expout_size): Replace
10344         "parser_state" with "expr_builder".
10345         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10346         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10347         "parser_state" with "expr_builder".
10348
10349 2019-04-04  Tom Tromey  <tom@tromey.com>
10350
10351         * rust-exp.y: Replace "parse_language" with method call.
10352         * p-exp.y:
10353         (yylex): Replace "parse_language" with method call.
10354         * m2-exp.y:
10355         (yylex): Replace "parse_language" with method call.
10356         * go-exp.y (classify_name): Replace "parse_language" with method
10357         call.
10358         * f-exp.y (yylex): Replace "parse_language" with method call.
10359         * d-exp.y (lex_one_token): Replace "parse_language" with method
10360         call.
10361         * c-exp.y:
10362         (lex_one_token, classify_name, yylex): Replace "parse_language"
10363         with method call.
10364         * ada-exp.y (find_primitive_type, type_char)
10365         (type_system_address): Replace "parse_language" with method call.
10366
10367 2019-04-04  Tom Tromey  <tom@tromey.com>
10368
10369         * rust-exp.y: Replace "parse_gdbarch" with method call.
10370         * parse.c (write_dollar_variable, insert_type_address_space):
10371         Replace "parse_gdbarch" with method call.
10372         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10373         call.
10374         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10375         call.
10376         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10377         "parse_gdbarch" with method call.
10378         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10379         with method call.
10380         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10381         "parse_gdbarch" with method call.
10382         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10383         "parse_gdbarch" with method call.
10384         * c-exp.y (parse_type, parse_number, classify_name): Replace
10385         "parse_gdbarch" with method call.
10386         * ada-lex.l: Replace "parse_gdbarch" with method call.
10387         * ada-exp.y (parse_type, find_primitive_type, type_char)
10388         (type_system_address): Replace "parse_gdbarch" with method call.
10389
10390 2019-04-04  Tom Tromey  <tom@tromey.com>
10391
10392         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10393         * stap-probe.c (stap_parse_argument): Update.
10394         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10395         initial_size parameter.
10396         * rust-exp.y (rust_lex_tests): Update.
10397         * parse.c (parser_state): Update.
10398         (parse_exp_in_context): Update.
10399         * parser-defs.h (struct parser_state) <parser_state>: Remove
10400         "initial_size" parameter.
10401
10402 2019-04-04  Tom Tromey  <tom@tromey.com>
10403
10404         * parser-defs.h (increase_expout_size): Don't declare.
10405         * parse.c (increase_expout_size): Now static.
10406
10407 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10408
10409         * gnu-nat.c (gnu_nat_target::wait): Fix
10410         target_waitstatus_to_string call.
10411
10412 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10413
10414         * eval.c (evaluate_subexp_standard): Handle internal functions
10415         during Fortran function call handling.
10416
10417 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10418
10419         * NEWS: Mention new internal functions.
10420         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10421         (read_base_type): Use dwarf2_init_complex_target_type.
10422         * value.c (creal_internal_fn): New function.
10423         (cimag_internal_fn): New function.
10424         (_initialize_values): Register new internal functions.
10425
10426 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10427
10428         * infrun.c (stop_all_threads): If debug_infrun, always
10429         trace the wait status after wait_one, using
10430         target_waitstatus_to_string and target_pid_to_str.
10431         (handle_inferior_event): Replace various trace of
10432         wait status kind by a single trace.
10433         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10434         wait status kind image by target_waitstatus_to_string.
10435         * target/waitstatus.c (target_waitstatus_to_string): Fix
10436         obsolete comment.
10437
10438 2019-04-01  Tom Tromey  <tromey@adacore.com>
10439
10440         PR symtab/23331:
10441         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10442
10443 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10444             Pedro Alves  <palves@redhat.com>
10445
10446         * top.c (quit_force): Call 'finalize_values'.
10447         * value.c (finalize_values): New function.
10448         * value.h (finalize_values): Declare.
10449
10450 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10451
10452         * NEWS: Announce $_gdb_major and $_gdb_minor.
10453
10454         * top.c (init_gdb_version_vars): New function.
10455         (gdb_init): Call init_gdb_version_vars.
10456
10457 2019-03-29  Tom Tromey  <tromey@adacore.com>
10458
10459         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10460         help text.  Remove dead code.
10461
10462 2019-03-29  Keith Seitz  <keiths@redhat.com>
10463
10464         From Siddhesh Poyarekar:
10465         * f-lang.h (f77_get_upperbound): Return LONGEST.
10466         (f77_get_lowerbound): Likewise.
10467         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10468         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10469         print them.
10470         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10471         plongest to format print it.
10472         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10473         (f77_get_upperbound): Likewise.
10474         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10475         LOWER_BOUND to LONGEST.
10476         (f77_create_arrayprint_offset_tbl): Likewise.
10477
10478 2019-03-29  Keith Seitz  <keiths@redhat.com>
10479
10480         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10481         %s/pulongest for TYPE_LENGTH instead of %d in format
10482         strings.
10483         * ada-typerint.c (ada_print_type): Likewise.
10484         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10485         * compile/compile-c-support.c (generate_register_struct): Likewise.
10486         * gdbtypes.c (recursive_dump_type): Likewise.
10487         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10488         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10489         instead of %d in format strings.
10490         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10491         to std::min to ULONGEST.
10492         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10493         instead of %d in format strings.
10494         * tracepoint.c (info_scope_command): Likewise.
10495         * typeprint.c (print_offset_data::update)
10496         (print_offset_data::finish): Likewise.
10497         * xtensa-tdep.c (xtensa_store_return_value)
10498         (xtensa_push_dummy_call): Likewise.
10499
10500 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10501
10502         * windows-nat.c (display_selector): Fixed format specifications
10503         for 64-bit Cygwin.
10504
10505 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10506
10507         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10508
10509 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10510
10511         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10512         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10513         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10514         (nios2_linux_init_abi): Install it.
10515
10516 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10517
10518         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10519
10520 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10521
10522         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10523
10524 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10525             Tom Tromey  <tromey@adacore.com>
10526
10527         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10528
10529 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10530
10531         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10532         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10533         method to compute the bounds of range types. Also print "[evaluated]"
10534         if the bounds' values come from a dynamic evaluation.
10535
10536 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10537
10538         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10539         whitespace when pretty printing is on.
10540
10541 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10542
10543         * ppc-linux-nat.c: Add include.
10544
10545 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10546
10547         * NEWS: Mention AArch64 Pointer Authentication.
10548
10549 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10550
10551         * arm-linux-nat.c: Add include.
10552
10553 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10554
10555         * source-cache.c (source_cache::get_source_lines): Re-read
10556         fullname after calling open_source_file.
10557
10558 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10559
10560         * NEWS: Mention TLS support for FreeBSD.
10561
10562 2019-03-25  Tom Tromey  <tromey@adacore.com>
10563
10564         * minsyms.c (BUNCH_SIZE): Update comment.
10565         (~minimal_symbol_reader): Remove old comment.
10566         (compact_minimal_symbols): Update comment.
10567         (minimal_symbol_reader::install): Remove old comment.  Update
10568         other comments.
10569
10570 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10571
10572         * s390-linux-nat.c: Add include.
10573
10574 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10575
10576         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10577         Call linux_get_hwcap.
10578         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10579         Likewise.
10580         (aarch64_linux_get_hwcap): Remove function.
10581         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10582         declaration.
10583         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10584         linux_get_hwcap.
10585         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10586         * linux-tdep.c (linux_get_hwcap): Add function.
10587         (linux_get_hwcap2): Likewise.
10588         * linux-tdep.h (linux_get_hwcap): Add declaration.
10589         (linux_get_hwcap2): Likewise.
10590         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10591         (ppc_linux_get_hwcap2): Likewise.
10592         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10593         linux_get_hwcap.
10594         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10595         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10596         (ppc_linux_nat_target::read_description): Likewise.
10597         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10598         * s390-linux-nat.c: Likewise.
10599         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10600
10601 2019-03-24  Tom Tromey  <tom@tromey.com>
10602
10603         * ada-lang.c (standard_lookup): Simplify initialization.
10604         (ada_lookup_symbol_nonlocal): Simplify return.
10605         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10606         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10607         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10608         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10609         initialization.
10610         * solib.c (solib_global_lookup): Simplify.
10611         * symtab.c (null_block_symbol): Remove.
10612         (symbol_cache_lookup): Simplify returns.
10613         (lookup_language_this): Simplify returns.
10614         (lookup_symbol_aux): Simplify return.
10615         (lookup_local_symbol): Simplify returns.
10616         (lookup_global_symbol_from_objfile): Simplify return.
10617         (lookup_symbol_in_objfile_symtabs)
10618         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10619         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10620         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10621         * cp-namespace.c (cp_lookup_bare_symbol)
10622         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10623         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10624         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10625         (cp_lookup_symbol_via_imports): Simplify initialization.
10626         (find_symbol_in_baseclass): Likewise.
10627         * symtab.h (null_block_symbol): Remove.
10628         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10629         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10630         (d_lookup_symbol_module): Likewise.
10631         (find_symbol_in_baseclass): Simplify initialization.
10632
10633 2019-03-24  Tom Tromey  <tom@tromey.com>
10634
10635         * expression.h: Don't include symtab.h.
10636         (struct block): Forward declare.
10637
10638 2019-03-24  Tom Tromey  <tom@tromey.com>
10639
10640         * c-exp.y (typebase): Remove casts.
10641         * gdbtypes.c (lookup_unsigned_typename, )
10642         (lookup_signed_typename): Remove cast.
10643         * eval.c (parse_to_comma_and_eval): Remove cast.
10644         * parse.c (write_dollar_variable): Remove cast.
10645         * block.h (struct block) <superblock>: Now const.
10646         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10647         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10648         (map_block): Make "block" const.
10649         * symfile.h (struct quick_symbol_functions)
10650         <map_matching_symbols>: Constify block argument to "callback".
10651         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10652         const.
10653         (find_pc_sect_compunit_symtab): Make "b" const.
10654         (find_symbol_at_address): Likewise.
10655         (search_symbols): Likewise.
10656         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10657         (dw2_debug_names_lookup_symbol): Likewise.
10658         (dw2_map_matching_symbols): Update.
10659         * p-valprint.c (pascal_val_print): Remove "block".
10660         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10661         (aux_add_nonlocal_symbols): Make "block" const.
10662         (resolve_subexp): Remove cast.
10663         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10664         const.
10665         (iterate_over_file_blocks): Likewise.
10666         * f-exp.y (%union) <bval>: Remove.
10667         * coffread.c (patch_opaque_types): Make "b" const.
10668         * spu-tdep.c (spu_catch_start): Make "block" const.
10669         * c-valprint.c (print_unpacked_pointer): Remove "block".
10670         * symmisc.c (dump_symtab_1): Make "b" const.
10671         (block_depth): Make "block" const.
10672         * d-exp.y (%union) <bval>: Remove.
10673         * cp-support.h (cp_lookup_rtti_type): Update.
10674         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10675         * psymtab.c (psym_lookup_symbol): Make "block" const.
10676         (maintenance_check_psymtabs): Make "b" const.
10677         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10678         (enumerate_locals, enumerate_args): Update.
10679         * python/py-symtab.c (stpy_global_block): Make "block" const.
10680         (stpy_static_block): Likewise.
10681         * inline-frame.c (block_starting_point_at): Make "new_block"
10682         const.
10683         * block.c (find_block_in_blockvector): Make return type const.
10684         (blockvector_for_pc_sect): Make "b" const.
10685         (find_block_in_blockvector): Make "b" const.
10686
10687 2019-03-23  Tom Tromey  <tom@tromey.com>
10688
10689         * varobj.c (varobj_create): Update.
10690         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10691         * printcmd.c (display_command, do_one_display): Don't reset
10692         innermost_block.
10693         * parser-defs.h (enum innermost_block_tracker_type): Move to
10694         expression.h.
10695         (innermost_block): Update comment.
10696         * parse.c (parse_exp_1): Add tracker_types parameter.
10697         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10698         tracker_types parameter.  Reset innermost_block.
10699         (parse_exp_in_context): Remove.
10700         (parse_expression_for_completion): Update.
10701         * objfiles.c (~objfile): Don't reset expression_context_block or
10702         innermost_block.
10703         * expression.h (enum innermost_block_tracker_type): Move from
10704         parser-defs.h.
10705         (parse_exp_1): Add tracker_types parameter.
10706         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10707         reset innermost_block.
10708
10709 2019-03-23  Tom Tromey  <tom@tromey.com>
10710
10711         * objfiles.h: Include bcache.h.
10712
10713 2019-03-23  Tom Tromey  <tom@tromey.com>
10714
10715         * linespec.c (get_current_search_block): Use
10716         scoped_restore_current_language.
10717         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10718
10719 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10720             Jiong Wang  <jiong.wang@arm.com>
10721
10722         * aarch64-linux-tdep.c
10723         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10724         section.
10725         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10726
10727 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10728             Jiong Wang  <jiong.wang@arm.com>
10729
10730         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10731         instructions.
10732         (aarch64_analyze_prologue_test): Add PACIASP test.
10733         (aarch64_prologue_prev_register): Unmask PC value.
10734
10735 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10736             Jiong Wang  <jiong.wang@arm.com>
10737
10738         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10739         (aarch64_dwarf2_prev_register): Unmask PC value.
10740         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10741         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10742         DW_CFA_AARCH64_negate_ra_state.
10743         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10744
10745 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10746             Jiong Wang  <jiong.wang@arm.com>
10747
10748         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10749         registers.
10750         (aarch64_pseudo_register_name): Likewise.
10751         (aarch64_pseudo_register_type): Likewise.
10752         (aarch64_pseudo_register_reggroup_p): Likewise.
10753         (aarch64_gdbarch_init): Add pauth registers.
10754         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10755         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10756         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10757         (struct gdbarch_tdep): Add regnum for ra_state.
10758
10759 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10760             Jiong Wang  <jiong.wang@arm.com>
10761
10762         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10763
10764 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10765             Jiong Wang  <jiong.wang@arm.com>
10766
10767         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10768         function.
10769         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10770         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10771         (aarch64_gdbarch_init): Add puth registers.
10772         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10773         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10774         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10775
10776 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10777             Jiong Wang  <jiong.wang@arm.com>
10778
10779         * aarch64-linux-nat.c
10780         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10781         * aarch64-linux-tdep.c
10782         (aarch64_linux_core_read_description): Likewise.
10783         (aarch64_linux_get_hwcap): New function.
10784         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10785         (aarch64_linux_get_hwcap): New declaration.
10786
10787 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10788             Jiong Wang  <jiong.wang@arm.com>
10789
10790         * aarch64-linux-nat.c
10791         (aarch64_linux_nat_target::read_description): Add pauth param.
10792         * aarch64-linux-tdep.c
10793         (aarch64_linux_core_read_description): Likewise.
10794         * aarch64-tdep.c (struct target_desc): Add in pauth.
10795         (aarch64_read_description): Add pauth param.
10796         (aarch64_gdbarch_init): Likewise.
10797         * aarch64-tdep.h (aarch64_read_description): Likewise.
10798         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10799         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10800         * features/Makefile: Add new files.
10801         * features/aarch64-pauth.c: New file.
10802         * features/aarch64-pauth.xml: New file.
10803
10804 2019-03-20  Tom Tromey  <tromey@adacore.com>
10805
10806         * infrun.c (handle_inferior_event): Rename from
10807         handle_inferior_event_1.  Create a scoped_value_mark.
10808         (handle_inferior_event): Remove.
10809
10810 2019-03-19  Tom Tromey  <tromey@adacore.com>
10811
10812         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10813         * infrun.h (print_stop_event): Add "displays" parameter.
10814         * infrun.c (print_stop_event): Add "displays" parameter.
10815
10816 2019-03-19  Pedro Alves  <palves@redhat.com>
10817
10818         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10819         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10820         to -1.  Fix TABs vs spaces.
10821         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10822         * tui/tui-out.h (tui_ui_out) Add intro comments.
10823         <m_line, m_start_of_line>: In-class initialize, and add describing
10824         comment.
10825
10826 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10827
10828         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10829         variable names.
10830         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10831
10832 2019-03-18  Pedro Alves  <palves@redhat.com>
10833             Eli Zaretskii <eliz@gnu.org>
10834
10835         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10836         m_line and m_start_of_line.
10837
10838 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10839
10840         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10841         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10842         it returns a newline.  This fixes a regression in TU mode, whereby
10843         the next line is output on the same screen line as the user input.
10844
10845 2019-03-18  Tom Tromey  <tromey@adacore.com>
10846
10847         * minsyms.c (minimal_symbol_reader::install): Remove call to
10848         obstack_blank.
10849
10850 2019-03-18  Pedro Alves  <palves@redhat.com>
10851
10852         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10853         New globals.
10854         (apply_style): New, factored out from ...
10855         (apply_ansi_escape): ... this.  Handle reverse video mode.
10856         (tui_set_reverse_mode): New function.
10857         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10858         * tui/tui-winsource.c (tui_show_source_line): Use
10859         tui_set_reverse_mode instead of setting A_STANDOUT.
10860         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10861         New setter methods.
10862
10863 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10864
10865         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10866         Handle tabs.
10867
10868 2019-03-18  Tom Tromey  <tromey@adacore.com>
10869
10870         * ada-lang.c (empty_array): Add "high" parameter.
10871         (ada_evaluate_subexp): Update.
10872
10873 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10874
10875         * unittests/string_view-selftests.c: Define
10876         _initialize_string_view_selftests unconditionally.
10877
10878 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10879
10880         PR gdb/24350
10881         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10882
10883 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10884
10885         PR gdb/24351
10886         * windows-nat.c (display_selector): Fix format specifiers.
10887
10888 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10889
10890         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10891         tui_refill_source_window instead of tui_refresh_win, to update the
10892         current execution line.  This fixes redisplay of the current line
10893         when stepping through the code with "next" or "step".
10894
10895 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10896
10897         * source-cache.c (source_cache::get_source_lines): Call
10898         find_source_lines to initialize s->nlines.  This fixes vertical
10899         scrolling of TUI source window when the DOWN arrow is pressed.
10900
10901 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10902
10903         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10904         linux-thread-db.c (_initialize_thread_db): Likewise.
10905
10906 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10907
10908         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10909         wclrtoeol in tui_show_source_line".  This reverts changes made in
10910         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10911
10912 2019-03-15  Tom Tromey  <tom@tromey.com>
10913
10914         * symtab.h (struct minimal_symbol): Derive from
10915         general_symbol_info.
10916         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10917         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10918         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10919         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10920         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10921         (MSYMBOL_SEARCH_NAME): Update.
10922         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10923         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10924         * minsyms.c (minimal_symbol_reader::record_full): Update.
10925
10926 2019-03-15  Tom Tromey  <tom@tromey.com>
10927
10928         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10929
10930 2019-03-15  Tom Tromey  <tom@tromey.com>
10931
10932         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10933         unique_xmalloc_ptr.
10934         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10935         Update.
10936         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10937         (build_minimal_symbol_hash_tables)
10938         (minimal_symbol_reader::install): Update.
10939
10940 2019-03-15  Tom Tromey  <tom@tromey.com>
10941
10942         * symtab.c (create_demangled_names_hash): Update.
10943         (symbol_set_names): Update.
10944         * objfiles.h (struct objfile_per_bfd_storage)
10945         <demangled_names_hash>: Now an htab_up.
10946         * objfiles.c (objfile_per_bfd_storage): Simplify.
10947
10948 2019-03-15  Tom Tromey  <tom@tromey.com>
10949
10950         * objfiles.h (struct objfile_per_bfd_storage): Declare
10951         destructor.
10952         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10953         New.
10954         (get_objfile_bfd_data): Use new.  Don't initialize
10955         language_of_main.
10956         (free_objfile_per_bfd_storage): Remove.
10957         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10958
10959 2019-03-15  Tom Tromey  <tom@tromey.com>
10960
10961         * symfile.c (reread_symbols): Update.
10962         * objfiles.c (objfile::objfile): Update.
10963         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10964         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10965         comment.
10966         (minimal_symbol_reader::install): Update.
10967         (terminate_minimal_symbol_table): Remove.
10968         * jit.c (jit_object_close_impl): Update.
10969
10970 2019-03-15  Tom Tromey  <tom@tromey.com>
10971
10972         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10973         initializations.
10974
10975 2019-03-15  Tom Tromey  <tom@tromey.com>
10976
10977         * objfiles.h (struct objfile_per_bfd_storage)
10978         <demangled_hash_languages>: Now a bitset.
10979         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10980         (lookup_minimal_symbol): Update.
10981
10982 2019-03-15  Tom Tromey  <tom@tromey.com>
10983
10984         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10985         Don't return the symbol.
10986         * coffread.c (record_minimal_symbol): Use record_full.
10987
10988 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10989
10990         The MS-Windows port of ncurses fails to switch to a color pair if
10991         one or both of the colors are the implicit default colors.  This
10992         change records the default colors when TUI is initialized, and
10993         then specifies them explicitly when a color pair uses the default
10994         colors.  This allows color styling in TUI mode on MS-Windows.
10995
10996         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10997         ncurses_norm_attr.
10998         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10999         colors in ncurses_norm_attr.
11000         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11001         "none", replace it with the default color recorded in
11002         ncurses_norm_attr.
11003
11004 2019-03-14  Tom Tromey  <tromey@adacore.com>
11005
11006         * source-cache.h (class source_cache) <get_source_lines>: Return
11007         std::string.
11008         * source-cache.c (source_cache::extract_lines): Handle case where
11009         first_pos==npos.  Return std::string.
11010         (source_cache::get_source_lines): Update.
11011
11012 2019-03-14  Tom Tromey  <tromey@adacore.com>
11013
11014         * NEWS: Add item for "style sources" commands.
11015         * source-cache.c (source_cache::get_source_lines): Check
11016         source_styling.
11017         * cli/cli-style.c (source_styling): New global.
11018         (_initialize_cli_style): Add "style sources" commands.
11019         (show_style_sources): New function.
11020         * cli/cli-style.h (source_styling): Declare.
11021
11022 2019-03-14  Pedro Alves  <palves@redhat.com>
11023             Tom Tromey  <tromey@adacore.com>
11024
11025         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11026         * tui/tui-winsource.c (tui_refill_source_window): New function,
11027         from...
11028         (tui_horizontal_source_scroll): ... here.  Move some logic.
11029         * cli/cli-style.c (set_style_enabled): Notify new observable.
11030         * tui/tui-hooks.c (tui_redisplay_source): New function.
11031         (tui_attach_detach_observers): Attach or detach
11032         tui_redisplay_source.
11033         * observable.h (source_styling_changed): New observable.
11034         * observable.c: Define source_styling_changed observable.
11035
11036 2019-03-13  Tom Tromey  <tromey@adacore.com>
11037
11038         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11039         (i386_gnu_nat_target::store_registers): Update.
11040         * target-debug.h (target_debug_print_std_string): New macro.
11041         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11042         * windows-tdep.c (display_one_tib): Update.
11043         * tui/tui-stack.c (tui_make_status_line): Update.
11044         * top.c (print_inferior_quit_action): Update.
11045         * thread.c (thr_try_catch_cmd): Update.
11046         (add_thread_with_info): Update.
11047         (thread_target_id_str): Update.
11048         (thr_try_catch_cmd): Update.
11049         (thread_command): Update.
11050         (thread_find_command): Update.
11051         * record-btrace.c (record_btrace_target::info_record)
11052         (record_btrace_resume_thread, record_btrace_target::resume)
11053         (record_btrace_cancel_resume, record_btrace_step_thread)
11054         (record_btrace_target::wait, record_btrace_target::wait)
11055         (record_btrace_target::wait, record_btrace_target::stop): Update.
11056         * progspace.c (print_program_space): Update.
11057         * process-stratum-target.c
11058         (process_stratum_target::thread_address_space): Update.
11059         * linux-fork.c (linux_fork_mourn_inferior)
11060         (detach_checkpoint_command, info_checkpoints_command)
11061         (linux_fork_context): Update.
11062         (linux_fork_detach): Update.
11063         (class scoped_switch_fork_info): Update.
11064         (delete_checkpoint_command): Update.
11065         * infrun.c (follow_fork_inferior): Update.
11066         (follow_fork_inferior): Update.
11067         (proceed_after_vfork_done): Update.
11068         (handle_vfork_child_exec_or_exit): Update.
11069         (follow_exec): Update.
11070         (displaced_step_prepare_throw): Update.
11071         (displaced_step_restore): Update.
11072         (start_step_over): Update.
11073         (resume_1): Update.
11074         (clear_proceed_status_thread): Update.
11075         (proceed): Update.
11076         (print_target_wait_results): Update.
11077         (do_target_wait): Update.
11078         (context_switch): Update.
11079         (stop_all_threads): Update.
11080         (restart_threads): Update.
11081         (finish_step_over): Update.
11082         (handle_signal_stop): Update.
11083         (switch_back_to_stepped_thread): Update.
11084         (keep_going_pass_signal): Update.
11085         (print_exited_reason): Update.
11086         (normal_stop): Update.
11087         * inferior.c (inferior_pid_to_str): Change return type.
11088         (print_selected_inferior): Update.
11089         (add_inferior): Update.
11090         (detach_inferior): Update.
11091         * dummy-frame.c (fprint_dummy_frames): Update.
11092         * dcache.c (dcache_info_1): Update.
11093         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11094         (btrace_fetch, btrace_clear): Update.
11095         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11096         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11097         type.
11098         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11099         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11100         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11101         * gdbarch.c, gdbarch.h: Rebuild.
11102         * gdbarch.sh (core_pid_to_str): Change return type.
11103         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11104         return type.
11105         (windows_nat_target::pid_to_str): Change return type.
11106         (windows_delete_thread): Update.
11107         (windows_nat_target::attach): Update.
11108         (windows_nat_target::files_info): Update.
11109         * target-delegates.c: Rebuild.
11110         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11111         return type.
11112         (sol_thread_target::pid_to_str): Change return type.
11113         * remote.c (class remote_target) <pid_to_str>: Change return
11114         type.
11115         (remote_target::pid_to_str): Change return type.
11116         (extended_remote_target::attach, remote_target::remote_stop_ns)
11117         (remote_target::remote_notif_remove_queued_reply)
11118         (remote_target::push_stop_reply, remote_target::disable_btrace):
11119         Update.
11120         (extended_remote_target::attach): Update.
11121         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11122         type.
11123         (gdbsim_target::pid_to_str): Change return type.
11124         * ravenscar-thread.c (struct ravenscar_thread_target)
11125         <pid_to_str>: Change return type.
11126         (ravenscar_thread_target::pid_to_str): Change return type.
11127         * procfs.c (class procfs_target) <pid_to_str>: Change return
11128         type.
11129         (procfs_target::pid_to_str): Change return type.
11130         (procfs_target::attach): Update.
11131         (procfs_target::detach): Update.
11132         (procfs_target::fetch_registers): Update.
11133         (procfs_target::store_registers): Update.
11134         (procfs_target::wait): Update.
11135         (procfs_target::files_info): Update.
11136         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11137         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11138         return type.
11139         (nto_procfs_target::pid_to_str): Change return type.
11140         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11141         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11142         return type.
11143         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11144         (exit_lwp): Update.
11145         (attach_proc_task_lwp_callback, get_detach_signal)
11146         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11147         (linux_nat_target::resume, wait_lwp, stop_callback)
11148         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11149         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11150         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11151         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11152         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11153         type.
11154         (inf_ptrace_target::attach): Update.
11155         (inf_ptrace_target::files_info): Update.
11156         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11157         type.
11158         (go32_nat_target::pid_to_str): Change return type.
11159         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11160         (gnu_nat_target::wait): Update.
11161         (gnu_nat_target::wait): Update.
11162         (gnu_nat_target::resume): Update.
11163         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11164         (fbsd_nat_target::wait): Update.
11165         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11166         type.
11167         (darwin_nat_target::attach): Update.
11168         * corelow.c (class core_target) <pid_to_str>: Change return type.
11169         (core_target::pid_to_str): Change return type.
11170         * target.c (normal_pid_to_str): Change return type.
11171         (default_pid_to_str): Likewise.
11172         (target_pid_to_str): Change return type.
11173         (target_translate_tls_address): Update.
11174         (target_announce_detach): Update.
11175         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11176         return type.
11177         (bsd_uthread_target::pid_to_str): Change return type.
11178         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11179         type.
11180         (bsd_kvm_target::pid_to_str): Change return type.
11181         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11182         return type.
11183         (aix_thread_target::pid_to_str): Change return type.
11184         * target.h (struct target_ops) <pid_to_str>: Change return type.
11185         (target_pid_to_str, normal_pid_to_str): Likewise.
11186         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11187         type.
11188         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11189         type.
11190         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11191         return type.
11192         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11193         type.
11194         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11195         type.
11196         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11197         return type.
11198
11199 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11200
11201         * NEWS: Mention that the new default MI version is 3.  Mention
11202         changes to the output of commands and events that deal with
11203         multi-location breakpoints.
11204         * breakpoint.c: Include "mi/mi-out.h".
11205         (print_one_breakpoint): Change output syntax if using MI version
11206         >= 3.
11207         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11208         New.
11209         (mi_multi_location_breakpoint_output_fixed): New.
11210         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11211         (mi_cmd_fix_multi_location_breakpoint_output): New.
11212         (mi_multi_location_breakpoint_output_fixed): New.
11213         * mi/mi-cmds.c (mi_cmds): Register command
11214         -fix-multi-location-breakpoint-output.
11215         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11216         interpreter "mi".
11217
11218 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11219
11220         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11221         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11222         instantiate mi_ui_out based on interpreter name.
11223         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11224         * mi/mi-main.c (mi_load_progress): Likewise.
11225
11226 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11227
11228         * NEWS: Combine separate "New targets" sections for 8.3.
11229
11230 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11231
11232         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11233         (ppcfbsd_init_abi): Install gdbarch
11234         "fetch_tls_load_module_address" and "get_thread_local_address"
11235         methods.
11236
11237 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11238
11239         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11240         (riscv_fbsd_init_abi): Install gdbarch
11241         "fetch_tls_load_module_address" and "get_thread_local_address"
11242         methods.
11243
11244 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11245
11246         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11247         (i386fbsd_init_abi): Install gdbarch
11248         "fetch_tls_load_module_address" and "get_thread_local_address"
11249         methods.
11250
11251 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11252
11253         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11254         (amd64fbsd_init_abi): Install gdbarch
11255         "fetch_tls_load_module_address" and "get_thread_local_address"
11256         methods.
11257
11258 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11259
11260         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11261         (struct fbsd_pspace_data): New type.
11262         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11263         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11264         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11265         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11266         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11267
11268 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11269
11270         * gdbtypes.c (lookup_struct_elt): New function.
11271         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11272         * gdbtypes.h (struct struct_elt): New type.
11273         (lookup_struct_elt): New prototype.
11274
11275 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11276
11277         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11278         remove disabled code block.
11279
11280 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11281
11282         * gdbarch.sh (get_thread_local_address): New method.
11283         * gdbarch.h, gdbarch.c: Regenerate.
11284         * target.c (target_translate_tls_address): Use
11285         gdbarch_get_thread_local_address if present instead of
11286         target::get_thread_local_address.
11287
11288 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11289
11290         * target.h (target::get_thread_local_address): Update comment.
11291
11292 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11293
11294         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11295         objfile->separate_debug_objfile_backlink if not NULL.
11296
11297 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11298
11299         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11300         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11301         (amd64bsd_store_inferior_registers): Likewise.
11302         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11303         Enable segment base registers.
11304         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11305         PT_GETFSBASE and PT_GETGSBASE.
11306         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11307         PT_SETGSBASE.
11308         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11309         segment base registers.
11310         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11311
11312 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11313
11314         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11315         Update calls to i386_target_description to add 'segments'
11316         parameter.
11317         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11318         add segment base registers.
11319         * arch/i386.c (i386_create_target_description): Add 'segments'
11320         parameter to enable segment base registers.
11321         * arch/i386.h (i386_create_target_description): Likewise.
11322         * features/i386/32bit-segments.xml: New file.
11323         * features/i386/32bit-segments.c: Generate.
11324         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11325         call to i386_target_description to add 'segments' parameter.
11326         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11327         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11328         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11329         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11330         if feature is present.
11331         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11332         Add 'segments' parameter to call to i386_target_description.
11333         (i386_target_description): Add 'segments' parameter to enable
11334         segment base registers.
11335         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11336         to call to i386_target_description.
11337         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11338         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11339         Define I386_NUM_REGS.
11340         (i386_target_description): Add 'segments' parameter to enable
11341         segment base registers.
11342
11343 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11344
11345         PR/24325
11346         * source-cache.c: #undef open and close, to avoid unresolved
11347         externals during linking.
11348
11349 2019-03-12  Tom Tromey  <tromey@adacore.com>
11350
11351         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11352         const.  Add initializers.
11353         (_initialize_remote): Don't initialize ptid globals.
11354
11355 2019-03-12  Pedro Alves  <palves@redhat.com>
11356
11357         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11358
11359 2019-03-12  Pedro Alves  <palves@redhat.com>
11360
11361         * cp-name-parser.y (main): Remove unused 'len' variable.
11362
11363 2019-03-12  Tom Tromey  <tromey@adacore.com>
11364
11365         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11366         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11367
11368 2019-03-12  Tom Tromey  <tromey@adacore.com>
11369
11370         * linux-nat.c (iterate_over_lwps): Update.
11371         (stop_callback): Remove parameter.
11372         (stop_wait_callback, detach_callback, resume_set_callback)
11373         (select_singlestep_lwp_callback, set_ignore_sigint)
11374         (status_callback, resumed_callback, resume_clear_callback)
11375         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11376         data parameter.
11377         (linux_nat_target::detach, linux_nat_target::resume)
11378         (linux_stop_and_wait_all_lwps, select_event_lwp)
11379         (linux_nat_filter_event, linux_nat_wait_1)
11380         (linux_nat_target::kill, linux_nat_target::stop)
11381         (linux_nat_target::stop): Update.
11382         (linux_nat_resume_callback): Change type.
11383         (resume_stopped_resumed_lwps, count_events_callback)
11384         (select_event_lwp_callback): Likewise.
11385         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11386         * arm-linux-nat.c (struct update_registers_data): Remove.
11387         (update_registers_callback): Change type.
11388         (arm_linux_insert_hw_breakpoint1): Update.
11389         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11390         parameter.
11391         (x86_linux_dr_set_addr): Update.
11392         (x86_linux_dr_set_control): Update.
11393         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11394         (iterate_over_lwps): Use gdb::function_view.
11395         * nat/aarch64-linux-hw-point.c (struct
11396         aarch64_dr_update_callback_param): Remove.
11397         (debug_reg_change_callback): Change type.
11398         (aarch64_notify_debug_reg_change): Update.
11399         * s390-linux-nat.c (s390_refresh_per_info): Update.
11400
11401 2019-03-11  Tom Tromey  <tromey@adacore.com>
11402
11403         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11404         redundant assignment to "this_cu".
11405
11406 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11407
11408         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11409
11410 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11411
11412         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11413         from...
11414         (rank_one_type): ... this.
11415
11416 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11417
11418         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11419         from...
11420         (rank_one_type): ... this.
11421
11422 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11423
11424         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11425         from...
11426         (rank_one_type): ... this.
11427
11428 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11429
11430         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11431         from...
11432         (rank_one_type): ... this.
11433
11434 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11435
11436         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11437         from...
11438         (rank_one_type): ... this.
11439
11440 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11441
11442         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11443         from...
11444         (rank_one_type): ... this.
11445
11446 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11447
11448         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11449         from...
11450         (rank_one_type): ... this.
11451
11452 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11453
11454         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11455         from...
11456         (rank_one_type): ... this.
11457
11458 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11459
11460         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11461         from...
11462         (rank_one_type): ... this.
11463
11464 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11465
11466         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11467         from...
11468         (rank_one_type): ... this.
11469
11470 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11471
11472         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11473         from...
11474         (rank_one_type): ... this.
11475
11476 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11477
11478         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11479         from...
11480         (rank_one_type): ... this.
11481
11482 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11483
11484         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11485         inferior-events' shows the example events.
11486
11487 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11488
11489         Support styling on native MS-Windows console
11490
11491         PR/24315
11492         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11493         on MS-Windows if $TERM is not defined.
11494
11495         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11496
11497         * posix-hdep.c (gdb_console_fputs):
11498         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11499         functions.
11500         * ui-file.h (gdb_console_fputs): Add prototype.
11501
11502         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11503         back to fputs only if the former returns zero.
11504
11505 2019-03-07  Tom Tromey  <tom@tromey.com>
11506
11507         * symmisc.c (print_symbol_bcache_statistics): Update.
11508         (print_objfile_statistics): Update.
11509         * symfile.c (allocate_symtab): Update.
11510         * stabsread.c: Don't include bcache.h.
11511         * psymtab.h (struct psymbol_bcache): Don't declare.
11512         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11513         (psymbol_bcache_init, psymbol_bcache_free)
11514         (psymbol_bcache_get_bcache): Don't declare.
11515         * psymtab.c (struct psymbol_bcache): Remove.
11516         (psymtab_storage::psymtab_storage): Update.
11517         (psymtab_storage::~psymtab_storage): Update.
11518         (psymbol_bcache_init, psymbol_bcache_free)
11519         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11520         (add_psymbol_to_bcache): Update.
11521         (allocate_psymtab): Update.
11522         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11523         macro_cache>: No longer pointers.
11524         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11525         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11526         * macrotab.c (macro_bcache): Update.
11527         * macroexp.c: Don't include bcache.h.
11528         * gdbtypes.c (check_types_worklist): Update.
11529         (types_deeply_equal): Remove TRY/CATCH.  Update.
11530         * elfread.c (elf_symtab_read): Update.
11531         * dwarf2read.c: Don't include bcache.h.
11532         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11533         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11534         (print_bcache_statistics, bcache_memory_used): Don't declare.
11535         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11536         methods.  Rename all data members.
11537         * bcache.c (struct bcache): Move to bcache.h.
11538         (bcache::expand_hash_table): Rename from expand_hash_table.
11539         (bcache): Remove.
11540         (bcache::insert): Rename from bcache_full.
11541         (bcache::compare): Rename from bcache_compare.
11542         (bcache_xmalloc): Remove.
11543         (bcache::~bcache): Rename from bcache_xfree.
11544         (bcache::print_statistics): Rename from print_bcache_statistics.
11545         (bcache::memory_used): Rename from bcache_memory_used.
11546
11547 2019-03-07  Pedro Alves  <palves@redhat.com>
11548
11549         * infrun.c (normal_stop): Also check for
11550         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11551
11552 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11553
11554         * f-lang.c (value_from_host_double): Moved to...
11555         * value.c (value_from_host_double): ...here.
11556         * value.h (value_from_host_double): Declare.
11557         * guile/scm-math.c (vlscm_convert_typed_number): Use
11558         value_from_host_double.
11559         (vlscm_convert_number): Likewise.
11560         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11561         * python/py-value.c (convert_value_from_python): Likewise.
11562
11563 2019-03-06  Tom Tromey  <tom@tromey.com>
11564
11565         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11566
11567 2019-03-06  Tom Tromey  <tom@tromey.com>
11568
11569         * utils.h (free_current_contents): Don't declare.
11570         * utils.c (free_current_contents): Remove.
11571
11572 2019-03-06  Tom Tromey  <tom@tromey.com>
11573
11574         * top.c (quit_force): Update.
11575         * main.c (captured_command_loop): Update.
11576         * common/new-op.c (operator new): Update.
11577         * common/common-exceptions.c (struct catcher)
11578         <save_cleanup_chain>: Remove member.
11579         (exceptions_state_mc_init): Update.
11580         (exception_try_scope_entry): Return nullptr.
11581         (exception_try_scope_exit, exception_rethrow)
11582         (throw_exception_sjlj, throw_exception_cxx): Update.
11583         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11584         (all_cleanups, do_cleanups, discard_cleanups)
11585         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11586         (restore_cleanups, restore_final_cleanups): Don't declare.
11587         (do_final_cleanups): Remove parameter.
11588         * common/cleanups.c (cleanup_chain, make_cleanup)
11589         (make_cleanup_dtor, all_cleanups, do_cleanups)
11590         (discard_my_cleanups, discard_cleanups)
11591         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11592         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11593         (null_cleanup): Remove.
11594         (do_final_cleanups): Remove parameter.
11595
11596 2019-03-06  Tom Tromey  <tom@tromey.com>
11597
11598         * remote.c (remote_target::remote_parse_stop_reply): Use
11599         unique_xmalloc_ptr.
11600
11601 2019-03-06  Tom Tromey  <tom@tromey.com>
11602
11603         * stabsread.c (struct stabs_field_info): Rename from field_info.
11604         <list, fnlist>: Add initializers.
11605         <obstack>: New member.
11606         (read_member_functions, read_struct_fields, read_baseclasses):
11607         Allocate on obstack.  Don't use cleanups.
11608         (read_one_struct_field, read_member_functions, read_struct_fields)
11609         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11610         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11611         (read_struct_type): Update.
11612
11613 2019-03-06  Tom Tromey  <tom@tromey.com>
11614
11615         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11616         * common/filestuff.h (make_cleanup_close): Don't declare.
11617         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11618         Remove.
11619
11620 2019-03-06  Tom Tromey  <tom@tromey.com>
11621
11622         * solib-aix.c: Use make_scope_exit.
11623
11624 2019-03-06  Tom Tromey  <tom@tromey.com>
11625
11626         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11627         Use make_scope_exit.
11628
11629 2019-03-06  Tom Tromey  <tom@tromey.com>
11630
11631         * solib-svr4.c (disable_probes_interface): Remove parameter.
11632         (svr4_handle_solib_event): Use make_scope_exit.
11633
11634 2019-03-06  Tom Tromey  <tom@tromey.com>
11635
11636         * remote.c (struct stop_reply_deleter): Remove.
11637         (stop_reply_up): Update.
11638         (struct stop_reply): Derive from notif_event.  Don't typedef.
11639         <regcache>: Now a std::vector.
11640         (stop_reply_xfree): Remove.
11641         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11642         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11643         (remote_target::discard_pending_stop_replies): Use delete.
11644         (remote_target::remote_parse_stop_reply): Update.
11645         (remote_target::process_stop_reply): Update.
11646         * remote-notif.h (struct notif_event): Add virtual destructor.
11647         Remove "dtr" member.
11648         (struct notif_client) <alloc_event>: Return a unique_ptr.
11649         (notif_event_xfree): Don't declare.
11650         (notif_event_up): New typedef.
11651         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11652         (notif_event_xfree, do_notif_event_xfree): Remove.
11653         (remote_notif_state_xfree): Update.
11654
11655 2019-03-06  Tom Tromey  <tom@tromey.com>
11656
11657         * infrun.c (displaced_step_clear_cleanup): Now a
11658         forward_scope_exit type.
11659         (displaced_step_prepare_throw): Update.
11660         (displaced_step_fixup): Update.
11661
11662 2019-03-06  Tom Tromey  <tom@tromey.com>
11663
11664         * inferior.h (class inferior): Update comment.
11665         * gdbthread.h (class thread_info): Update comment.
11666
11667 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11668             Tom Tromey  <tom@tromey.com>
11669
11670         * stabsread.h (struct stab_section_list): Remove.
11671         (coffstab_build_psymtabs): Update.
11672         * dbxread.c (symbuf_sections): Now a std::vector.
11673         (sect_idx): New global.
11674         (fill_symbuf): Update.
11675         (coffstab_build_psymtabs): Change type of stabsects parameter.
11676         Update.
11677         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11678         std::vector.
11679         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11680         (coff_locate_sections): Update.
11681         (coff_symfile_read): Remove cleanups.  Update.
11682         (init_stringtab): Add storage parameter.
11683         (free_stringtab, free_stringtab_cleanup): Remove.
11684         (init_lineno): Add storage parameter.
11685         (free_linetab, free_linetab_cleanup): Remove.
11686
11687 2019-03-06  Pedro Alves  <palves@redhat.com>
11688
11689         * linux-fork.c (fork_info::clobber_regs): Delete.
11690         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11691         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11692         comment.  Adjust.
11693         (scoped_switch_fork_info::scoped_switch_fork_info)
11694         (checkpoint_command, linux_fork_context): Adjust
11695         fork_save_infrun_state calls.
11696
11697 2019-03-06  Pedro Alves  <palves@redhat.com>
11698
11699         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11700         (inf_has_multiple_threads): Return 'bool' and rewrite using
11701         inferior_info::threads().
11702
11703 2019-03-06  Pedro Alves  <palves@redhat.com>
11704
11705         * linux-fork.c: Include <list>.
11706         (fork_list): Now a std::list instance.
11707         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11708         (forks_exist_p, find_last_fork): Adjust.
11709         (new_fork): Delete.
11710         (one_fork_p): New.
11711         (add_fork): Adjust.
11712         (free_fork): Delete, folded into fork_info::~fork_info().
11713         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11714         Adjust.
11715         (init_fork_list): Delete.
11716         (linux_fork_killall, linux_fork_mourn_inferior)
11717         (linux_fork_detach, info_checkpoints_command): Adjust.
11718         (_initialize_linux_fork): No longer call init_fork_list.
11719
11720 2019-03-06  Pedro Alves  <palves@redhat.com>
11721
11722         * linux-fork.c (new_fork): New, split out of ...
11723         (add_fork): ... this.  Return void.  Move "first fork" special
11724         case from here, to ...
11725         (checkpoint_command): ... here.
11726         * linux-linux.h (add_fork): Return void.
11727
11728 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11729
11730         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11731
11732 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11733             Chris January  <chris.january@arm.com>
11734             David Lecomber  <david.lecomber@arm.com>
11735
11736         * f-exp.y: New token, UNOP_INTRINSIC.
11737         (exp): New pattern using UNOP_INTRINSIC token.
11738         (f77_keywords): Add 'abs' keyword.
11739         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11740         (value_from_host_double): New function.
11741         (evaluate_subexp_f): Support UNOP_ABS.
11742
11743 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11744
11745         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11746         types.
11747
11748 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11749
11750         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11751         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11752         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11753
11754 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11755
11756         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11757
11758 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11759             Chris January  <chris.january@arm.com>
11760
11761         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11762         * f-exp.y: Define 'KIND' token.
11763         (exp): New pattern for KIND expressions.
11764         (ptype): Handle types with a kind extension.
11765         (direct_abs_decl): Extend to spot kind extensions.
11766         (f77_keywords): Add 'kind' to the list.
11767         (push_kind_type): New function.
11768         (convert_to_kind_type): New function.
11769         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11770         * parse.c (operator_length_standard): Likewise.
11771         * parser-defs.h (enum type_pieces): Add tp_kind.
11772         * std-operator.def: Add UNOP_KIND.
11773
11774 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11775
11776         * f-exp.y (f_parse): Set yydebug.
11777
11778 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11779
11780         * f-lang.c (evaluate_subexp_f): New function.
11781         (exp_descriptor_f): New global.
11782         (f_language_defn): Use exp_descriptor_f instead of
11783         exp_descriptor_standard.
11784
11785 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11786
11787         * f-exp.y (struct token): Add comments.
11788         (dot_ops): Remove uppercase versions and the end marker.
11789         (f77_keywords): Likewise.
11790         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11791         entries in the dot_ops array are case insensitive, and use
11792         strncasecmp to compare strings.  Also some whitespace cleanup in
11793         this area.  Similar for the f77_keywords array, except entries in
11794         this list might be case sensitive.
11795
11796 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11797
11798         * f-exp.y (struct f77_boolean_val): Add comments.
11799         (boolean_values): Remove uppercase versions, and end marker.
11800         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11801         and use strncasecmp to achieve case insensitivity.  Additionally,
11802         perform whitespace cleanup around this code.
11803
11804 2019-03-06  Tom Tromey  <tromey@adacore.com>
11805
11806         * remote-sim.c (gdbsim_target_open): Use result of
11807         gdb_argv::release.
11808
11809 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11810         Dirk Schubert  <dirk.schubert@arm.com>
11811         Chris January  <chris.january@arm.com>
11812
11813         * eval.c (evaluate_subexp_standard): Call Fortran argument
11814         wrapping logic.
11815         * f-lang.c (struct value): A value which can be passed into a
11816         Fortran function call.
11817         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11818         where appropriate.
11819         (struct type): Value ready for a Fortran function call.
11820         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11821         is needed.
11822         * f-lang.h (fortran_argument_convert): Declaration.
11823         (fortran_preserve_arg_pointer): Declaration.
11824         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11825
11826 2019-03-05  Tom Tromey  <tromey@adacore.com>
11827
11828         * python/py-prettyprint.c (print_string_repr): Remove #if.
11829         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11830
11831 2019-03-05  Tom Tromey  <tromey@adacore.com>
11832
11833         * target.c (the_dummy_target): Move later.  Change type to
11834         "dummy_target".
11835         (initialize_targets): Don't initialize the_dummy_target.
11836
11837 2019-03-05  Tom Tromey  <tromey@adacore.com>
11838
11839         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11840         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11841
11842 2019-03-05  Tom Tromey  <tromey@adacore.com>
11843
11844         * windows-nat.c (windows_nat_target::attach)
11845         (windows_nat_target::detach): Don't call gdb_flush.
11846         * valprint.c (generic_val_print, val_print, val_print_string):
11847         Don't call gdb_flush.
11848         * utils.c (defaulted_query): Don't call gdb_flush.
11849         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11850         * target.c (target_announce_detach): Don't call gdb_flush.
11851         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11852         * remote.c (extended_remote_target::attach): Don't call
11853         gdb_flush.
11854         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11855         * printcmd.c (do_examine): Don't call gdb_flush.
11856         (info_display_command): Don't call gdb_flush.
11857         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11858         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11859         * memattr.c (info_mem_command): Don't call gdb_flush.
11860         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11861         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11862         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11863         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11864         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11865         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11866         (gnu_nat_target::detach): Don't call gdb_flush.
11867         * f-valprint.c (f_val_print): Don't call gdb_flush.
11868         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11869         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11870         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11871         gdb_flush.
11872         * c-valprint.c (c_val_print): Don't call gdb_flush.
11873         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11874
11875 2019-03-05  Tom Tromey  <tromey@adacore.com>
11876
11877         * varobj.c (update_dynamic_varobj_children): Update.
11878         (install_default_visualizer): Use reset, not release.
11879         * value.c (set_internalvar): Update.
11880         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11881         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11882         ATTRIBUTE_UNUSED_RESULT.
11883
11884 2019-03-05  Tom Tromey  <tromey@adacore.com>
11885
11886         * remote.c (class scoped_remote_fd) <release>: Add
11887         ATTRIBUTE_UNUSED_RESULT.
11888
11889 2019-03-05  Tom Tromey  <tromey@adacore.com>
11890
11891         * macroexp.c (struct macro_buffer) <release>: Add
11892         ATTRIBUTE_UNUSED_RESULT.
11893
11894 2019-03-05  Tom Tromey  <tromey@adacore.com>
11895
11896         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11897         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11898         ATTRIBUTE_UNUSED_RESULT.
11899
11900 2019-03-05  Tom Tromey  <tromey@adacore.com>
11901
11902         * common/scoped_fd.h (class scoped_fd) <release>: Add
11903         ATTRIBUTE_UNUSED_RESULT.
11904
11905 2019-03-05  Tom Tromey  <tromey@adacore.com>
11906
11907         * parser-defs.h (struct parser_state) <release>: Add
11908         ATTRIBUTE_UNUSED_RESULT.
11909
11910 2019-03-05  Tom Tromey  <tromey@adacore.com>
11911
11912         * utils.h (class gdb_argv) <release>: Add
11913         ATTRIBUTE_UNUSED_RESULT.
11914         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11915
11916 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11917
11918         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11919         for-loop range, to avoid compiler warnings.
11920
11921         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11922         avoid compiler warnings about unused variables.
11923
11924         * NEWS: Mention end of support for native debugging on MS-Windows
11925         before XP.
11926
11927         PR gdb/24292
11928         * common/netstuff.c:
11929         * gdbserver/gdbreplay.c
11930         * gdbserver/remote-utils.c:
11931         * ser-tcp.c:
11932         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11933         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11934         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11935         'getaddrinfo' and 'freeaddrinfo' were not available before
11936         Windows XP, and mingw.org's MinGW headers by default define
11937         _WIN32_WINNT to 0x500.
11938
11939 2019-03-01  Gary Benson <gbenson@redhat.com>
11940
11941         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11942
11943 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11944             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11945
11946         PR gdb/8527
11947         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11948         set_sigint_trap, clear_sigint_trap.
11949
11950 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11951
11952         * target.c (target_detach): Clear the regcache and the
11953         frame cache.
11954
11955 2019-02-27  Pedro Alves  <palves@redhat.com>
11956
11957         * utils.c (set_screen_size): When we cap the height/width sizes,
11958         tweak the corresponding command variable to show "unlimited":
11959
11960 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11961             Pedro Alves  <palves@redhat.com>
11962
11963         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11964         before calling rl_set_screen_size.
11965
11966 2019-02-27  Tom Tromey  <tromey@adacore.com>
11967
11968         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11969         define.
11970         * python/py-value.c: Remove Python 2.4 workaround.
11971         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11972         workaround.
11973         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11974         Python 2.4 workaround.
11975         * python/python-internal.h: Remove Python 2.4 comment.
11976         (Py_ssize_t): Don't define.
11977         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11978         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11979         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11980         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11981         * python/python.c (do_start_initialization): Remove Python 2.4
11982         workaround.
11983         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11984         (print_children): Remove Python 2.4 workaround.
11985         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11986         workaround.
11987         (CHARBUFFERPROC_NAME): Remove.
11988         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11989         Python 2.4 workaround.
11990
11991 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11992
11993         * NEWS: Note minimum Python version.
11994
11995 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11996
11997         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11998         code from these functions.  Remove corresponding ifdefs.  Use
11999         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12000         Remove gotos and target of gotos.
12001         (infpy_search_memory): Likewise.
12002
12003 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12004
12005         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12006         (hppa_gdbarch_init): Don't register deleted functions with
12007         gdbarch.
12008
12009 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12010
12011         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12012         (h8300_unwind_sp): Delete.
12013         (h8300_dummy_id): Delete.
12014         (h8300_gdbarch_init): Don't register deleted functions with
12015         gdbarch.
12016
12017 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12018
12019         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12020         (ft32_unwind_pc): Delete.
12021         (ft32_unwind_sp): Delete.
12022         (ft32_gdbarch_init): Don't register deleted functions with
12023         gdbarch.
12024
12025 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12026
12027         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12028         (frv_unwind_pc): Delete.
12029         (frv_unwind_sp): Delete.
12030         (frv_gdbarch_init): Don't register deleted functions with
12031         gdbarch.
12032
12033 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12034
12035         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12036         (riscv_unwind_pc): Delete.
12037         (riscv_unwind_sp): Delete.
12038         (riscv_gdbarch_init): Don't register deleted functions with
12039         gdbarch.
12040
12041 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12042
12043         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12044         (csky_unwind_pc): Delete.
12045         (csky_unwind_sp): Delete.
12046         (csky_gdbarch_init): Don't register deleted functions with
12047         gdbarch.
12048
12049 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12050
12051         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12052         (cris_unwind_pc): Delete.
12053         (cris_unwind_sp): Delete.
12054         (cris_gdbarch_init): Don't register deleted functions with
12055         gdbarch.
12056
12057 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12058
12059         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12060         (bfin_unwind_pc): Delete.
12061         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12062
12063 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12064
12065         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12066         (arm_unwind_pc): Delete.
12067         (arm_unwind_sp): Delete.
12068         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12069
12070 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12071
12072         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12073         (arc_unwind_pc): Delete.
12074         (arc_unwind_sp): Delete.
12075         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12076
12077 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12078
12079         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12080         (alpha_unwind_pc): Delete.
12081         (alpha_gdbarch_init): Don't register deleted functions with
12082         gdbarch.
12083
12084 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12085
12086         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12087         (aarch64_unwind_pc): Delete.
12088         (aarch64_unwind_sp): Delete.
12089         (aarch64_gdbarch_init): Don't register deleted functions with
12090         gdbarch.
12091
12092 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12093
12094         * gdbtypes.c (type_align): Don't consider static members when
12095         computing structure alignment.
12096
12097 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12098
12099         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12100         return 0 for other types.
12101         * arch-utils.c (default_type_align): Always return 0.
12102         * gdbarch.h: Regenerate.
12103         * gdbarch.sh (type_align): Extend comment.
12104         * gdbtypes.c (type_align): Add additional comments, always call
12105         gdbarch_type_align before applying the default rules.
12106         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12107         generic code will then apply a suitable default.
12108         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12109         types, return 0 for other types.
12110
12111 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12112
12113         * NEWS: Create a new section for the next release branch.
12114         Rename the section of the current branch, now that it has
12115         been cut.
12116
12117 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12118
12119         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12120         * version.in: Bump version to 8.3.50.DATE-git.
12121
12122 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12123
12124         * aix-thread.c (ptid_cmp): Remove unused variable.
12125         (get_signaled_thread): Likewise.
12126         (store_regs_user_thread): Likewise.
12127         (store_regs_kernel_thread): Likewise.
12128         (fetch_regs_kernel_thread): Remove shadowed variable.
12129
12130 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12131
12132         * features/riscv/32bit-cpu.xml: Add register numbers.
12133         * features/riscv/32bit-fpu.c: Regenerate.
12134         * features/riscv/32bit-fpu.xml: Add register numbers.
12135         * features/riscv/64bit-cpu.xml: Add register numbers.
12136         * features/riscv/64bit-fpu.c: Regenerate.
12137         * features/riscv/64bit-fpu.xml: Add register numbers.
12138
12139 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12140
12141         * NEWS: Mention two argument form of gdb.Value constructor.
12142         * python/py-value.c (convert_buffer_and_type_to_value): New
12143         function.
12144         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12145         Add support for handling an optional second argument.  Call
12146         convert_buffer_and_type_to_value as appropriate.
12147         * python/python-internal.h (Py_buffer_deleter): New struct.
12148         (Py_buffer_up): New typedef.
12149
12150 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12151
12152         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12153         instead of releasing ownership.
12154
12155 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12156
12157         * dwarf2read.c (open_and_init_dwp_file): Call
12158         elf_numsections instead of bfd_count_sections to initialize
12159         dwp_file->num_sections.
12160
12161 2019-02-25  Tom Tromey  <tromey@adacore.com>
12162
12163         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12164
12165 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12166
12167         * gcore.in: Add '--readnever' option when invoking GDB.
12168
12169 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12170
12171         * MAINTAINERS: Update my email address.
12172
12173 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12174
12175         * build-id.c (build_id_to_debug_bfd_1): New function.
12176         (build_id_to_debug_bfd): Look for separate debug file in
12177         sysroot.
12178
12179 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12180
12181         * gdbarch.sh: Update the copyright year range that is placed into
12182         generated files.
12183
12184 2019-02-22  Keith Seitz  <keiths@redhat.com>
12185
12186         PR symtab/23853
12187         * linespec.c (create_sals_line_offset): Search for the default
12188         symtab's filename instead of its fullname.
12189
12190 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12191
12192         * NEWS: Update style defaults.
12193
12194 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12195
12196         * main.c (captured_main_1): Disable styling in batch mode.
12197
12198 2019-02-20  Tom Tromey  <tom@tromey.com>
12199
12200         * symtab.c (symtab_symbol_info): Fix typos.
12201
12202 2019-02-20  Tom Tromey  <tromey@adacore.com>
12203
12204         * findcmd.c (_initialize_mem_search): Use upper case for
12205         metasyntactic variables.
12206
12207 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12208
12209         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12210         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12211
12212 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12213
12214         * top.h (source_file_name): Change to std::string.
12215         * top.c (source_file_name): Likewise.
12216         (command_line_input): Adjust.
12217         * cli/cli-script.c (script_from_file): Adjust.
12218
12219 2019-02-19  Tom Tromey  <tromey@adacore.com>
12220
12221         * ravenscar-thread.c
12222         (ravenscar_thread_target::update_thread_list): Don't call
12223         ada_build_task_list.
12224         * ada-lang.h (ada_build_task_list): Don't declare.
12225         * ada-tasks.c (struct ada_tasks_inferior_data)
12226         <task_list_valid_p>: Now bool.
12227         (read_known_tasks, ada_task_list_changed)
12228         (ada_tasks_invalidate_inferior_data): Update.
12229         (read_known_tasks_array): Return bool.
12230         (read_known_tasks_list): Likewise.
12231         (read_known_tasks): Return void.
12232         (ada_build_task_list): Now static.
12233
12234 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12235
12236         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12237         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12238
12239 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12240
12241         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12242         variant for ada_tasks_pspace_data_handle and
12243         ada_tasks_inferior_data_handle.
12244         (ada_tasks_pspace_data_cleanup): New function.
12245         (ada_tasks_inferior_data_cleanup): New function.
12246
12247 2019-02-17  Tom Tromey  <tom@tromey.com>
12248
12249         * macrotab.h (macro_source_fullname): Return a std::string.
12250         * macrotab.c (macro_include, check_for_redefinition)
12251         (macro_undef, macro_lookup_definition, foreach_macro)
12252         (foreach_macro_in_scope): Update.
12253         (macro_source_fullname): Return a std::string.
12254         * macrocmd.c (show_pp_source_pos): Update.
12255
12256 2019-02-17  Tom Tromey  <tom@tromey.com>
12257
12258         * macrocmd.c (show_pp_source_pos): Style the file names.
12259
12260 2019-02-17  Tom Tromey  <tom@tromey.com>
12261
12262         PR tui/24197:
12263         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12264
12265 2019-02-17  Tom Tromey  <tom@tromey.com>
12266
12267         * ada-lang.c (user_select_syms): Use filtered printing.
12268         * utils.c (wrap_style): New global.
12269         (desired_style): Remove.
12270         (emit_style_escape): Add stream parameter.
12271         (set_output_style, reset_terminal_style, prompt_for_continue):
12272         Update.
12273         (flush_wrap_buffer): Only flush gdb_stdout.
12274         (wrap_here): Set wrap_style.
12275         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12276         treat escape sequences as a character.  Change when wrap buffer is
12277         flushed.
12278         (fputs_styled): Do not set the output style when the default is
12279         requested.
12280         * ui-style.h (struct ui_file_style) <is_default>: New method.
12281         * source.c (print_source_lines_base): Emit escape sequences in one
12282         piece.
12283
12284 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12285
12286         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12287         integers and enumeration types.
12288
12289 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12290
12291         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12292         instead of lookup_symbol_in_language
12293         (do_exact_match): New function.
12294         (ada_get_symbol_name_matcher): Return do_exact_match when
12295         doing a verbatim match.
12296
12297 2019-02-15  Tom Tromey  <tromey@adacore.com>
12298
12299         * ravenscar-thread.c (ravenscar_thread_target::resume)
12300         (ravenscar_thread_target::wait): Special case wildcard requests.
12301
12302 2019-02-15  Tom Tromey  <tromey@adacore.com>
12303
12304         * ravenscar-thread.c (base_ptid): Remove.
12305         (struct ravenscar_thread_target) <close>: New method.
12306         <m_base_ptid>: New member.
12307         <update_inferior_ptid, active_task, task_is_currently_active,
12308         runtime_initialized>: Declare methods.
12309         <ravenscar_thread_target>: Add constructor.
12310         (ravenscar_thread_target::task_is_currently_active)
12311         (ravenscar_thread_target::update_inferior_ptid)
12312         (ravenscar_runtime_initialized): Rename.  Now methods.
12313         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12314         (ravenscar_thread_target::update_thread_list): Update.
12315         (ravenscar_thread_target::active_task): Now method.
12316         (ravenscar_thread_target::store_registers)
12317         (ravenscar_thread_target::prepare_to_store)
12318         (ravenscar_thread_target::prepare_to_store)
12319         (ravenscar_thread_target::mourn_inferior): Update.
12320         (ravenscar_inferior_created): Use "new" to create target.
12321         (ravenscar_thread_target::get_ada_task_ptid): Update.
12322         (_initialize_ravenscar): Don't initialize base_ptid.
12323         (ravenscar_ops): Remove global.
12324
12325 2019-02-15  Tom Tromey  <tromey@adacore.com>
12326
12327         * target.h (push_target): Declare new overload.
12328         * target.c (push_target): New overload, taking an rvalue reference.
12329         * remote.c (remote_target::open_1): Use push_target overload.
12330         * corelow.c (core_target_open): Use push_target overload.
12331
12332 2019-02-15  Tom Tromey  <tromey@adacore.com>
12333
12334         * ravenscar-thread.c (is_ravenscar_task)
12335         (ravenscar_task_is_currently_active): Return bool.
12336         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12337         (_initialize_ravenscar): Remove "(void)".
12338         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12339         Return bool.
12340
12341 2019-02-15  Tom Tromey  <tromey@adacore.com>
12342
12343         * ravenscar-thread.c (ravenscar_runtime_initializer)
12344         (has_ravenscar_runtime, get_running_thread_id)
12345         (ravenscar_thread_target::resume): Fix indentation.
12346
12347 2019-02-15  Tom Tromey  <tromey@adacore.com>
12348
12349         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12350         from ravenscar_arch_ops.
12351         (sparc_ravenscar_ops::fetch_registers)
12352         (sparc_ravenscar_ops::store_registers): Now methods.
12353         (sparc_ravenscar_prepare_to_store): Remove.
12354         (sparc_ravenscar_ops): Redefine.
12355         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12356         methods and destructor.  Remove members.
12357         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12358         (ravenscar_thread_target::store_registers)
12359         (ravenscar_thread_target::prepare_to_store): Update.
12360         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12361         Remove.
12362         (struct ppc_ravenscar_powerpc_ops): Derive from
12363         ravenscar_arch_ops.
12364         (ppc_ravenscar_powerpc_ops::fetch_registers)
12365         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12366         (ppc_ravenscar_powerpc_ops): Redefine.
12367         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12368         (ppc_ravenscar_e500_ops::fetch_registers)
12369         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12370         (ppc_ravenscar_e500_ops): Redefine.
12371         * aarch64-ravenscar-thread.c
12372         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12373         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12374         (aarch64_ravenscar_fetch_registers)
12375         (aarch64_ravenscar_store_registers): Now methods.
12376         (aarch64_ravenscar_ops): Redefine.
12377
12378 2019-02-15  Tom Tromey  <tromey@adacore.com>
12379
12380         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12381         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12382         (ravenscar_thread_target::stopped_by_watchpoint)
12383         (ravenscar_thread_target::stopped_data_address)
12384         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12385
12386 2019-02-15  Tom Tromey  <tromey@adacore.com>
12387
12388         * ravenscar-thread.c: Fix some typos.
12389
12390 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12391             Tom Tromey  <tromey@adacore.com>
12392
12393         * ada-lang.c (ada_exception_sal): Change addr_string to a
12394         std::string.
12395         (create_ada_exception_catchpoint): Update.
12396
12397 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12398             Tom Tromey  <tromey@adacore.com>
12399
12400         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12401         (bp_location_ops): Remove.
12402         (base_breakpoint_allocate_location): Update.
12403         (free_bp_location): Update.
12404         * ada-lang.c (class ada_catchpoint_location)
12405         <ada_catchpoint_location>: Remove ops parameter.
12406         (ada_catchpoint_location_dtor): Remove.
12407         (ada_catchpoint_location_ops): Remove.
12408         (allocate_location_exception): Update.
12409         * breakpoint.h (struct bp_location_ops): Remove.
12410         (class bp_location) <bp_location>: Remove bp_location_ops
12411         parameter.
12412         <~bp_location>: Add destructor.
12413         <ops>: Remove.
12414
12415 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12416             Pedro Alves  <palves@redhat.com>
12417
12418         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12419         'PATH_MAX'.
12420
12421 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12422             Samuel Thibault  <samuel.thibault@gnu.org>
12423             Thomas Schwinge  <thomas@codesourcery.com>
12424
12425         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12426         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12427
12428 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12429
12430         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12431         (check_empty): Use "const char *".
12432
12433         * gnu-nat.c (gnu_nat_target::detach): Instead of
12434         'detach_inferior (pid)' call
12435         'detach_inferior (find_inferior_pid (pid))'.
12436
12437         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12438         'nat/fork-inferior.o'.
12439         * gnu-nat.c: #include "nat/fork-inferior.h".
12440
12441         * gnu-nat.c (gnu_nat_target::detach): Instead of
12442         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12443         * gnu-nat.h: #include "inf-child.h".
12444         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12445         'i386_gnu_nat_target::fetch_registers'.
12446         (gnu_store_registers): Rename/move to
12447         'i386_gnu_nat_target::store_registers'.
12448
12449         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12450         * gnu-nat.h (mach_thread_info): New function.
12451         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12452
12453         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12454
12455 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12456
12457         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12458
12459 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12460
12461         * windows-nat.c (windows_add_thread): Add new parameter
12462         "main_thread_p" with default value set to false.  Update
12463         function documentation as well as all callers.
12464         (windows_delete_thread): Likewise.
12465         (fake_create_process): Update call to windows_add_thread.
12466         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12467         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12468         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12469         call to windows_delete_thread.
12470
12471 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12472
12473         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12474
12475 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12476
12477         * symfile.c (find_separate_debug_file): Use canonical path of
12478         sysroot with child_path instead of gdb_sysroot if it is valid.
12479
12480 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12481
12482         * symfile.c (find_separate_debug_file): Use child_path to
12483         determine if an object file is under a sysroot.
12484
12485 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12486
12487         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12488         unittests/child-path-selftests.c.
12489         * common/pathstuff.c (child_path): New function.
12490         * common/pathstuff.h (child_path): New prototype.
12491         * unittests/child-path-selftests.c: New file.
12492
12493 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12494
12495         * symfile.c (find_separate_debug_file): Look for separate debug
12496         files in debug directories under the sysroot.
12497
12498 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12499
12500         * symtab.h (struct minimal_symbol data_p): New const method.
12501         (struct minimal_symbol text_p): Likewise.
12502         * symtab.c (output_source_filename): Use file name style
12503         to print file name.
12504         (print_symbol_info): Likewise.
12505         (print_msymbol_info): Use address style to print addresses.
12506         Use function name style to print executable text symbols.
12507         (expand_symtab_containing_pc): Use data_p.
12508         (find_pc_sect_compunit_symtab): Likewise.
12509
12510 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12511
12512         * breakpoint.c (describe_other_breakpoints): Use address style
12513         to print addresses.
12514         (say_where): Likewise.
12515
12516 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12517
12518         * ada-typeprint.c (print_func_type): Print function name
12519         style to print function name.
12520         * c-typeprint.c (c_print_type_1): Likewise.
12521
12522 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12523
12524         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12525         for execve.
12526
12527 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12528
12529         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12530         type_stack.
12531
12532 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12533
12534         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12535         TYPE_CODE_REF types.
12536
12537 2019-02-08  Jim Wilson  <jimw@sifive.com>
12538
12539         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12540         (riscv_linux_fregset): New.
12541         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12542
12543 2019-02-07  Tom Tromey  <tom@tromey.com>
12544
12545         * thread.c (thread_cancel_execution_command): Update.
12546         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12547         methods.
12548         (struct thread_fsm_ops): Remove.
12549         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12550         (thread_fsm_should_stop, thread_fsm_return_value)
12551         (thread_fsm_set_finished, thread_fsm_finished_p)
12552         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12553         Don't declare.
12554         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12555         * infrun.c (clear_proceed_status_thread)
12556         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12557         (print_stop_event): Update.
12558         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12559         Add constructor.
12560         (step_command_fsm_ops): Remove.
12561         (new_step_command_fsm): Remove.
12562         (step_1): Update.
12563         (step_command_fsm::should_stop): Rename from
12564         step_command_fsm_should_stop.
12565         (step_command_fsm::clean_up): Rename from
12566         step_command_fsm_clean_up.
12567         (step_command_fsm::do_async_reply_reason): Rename from
12568         step_command_fsm_async_reply_reason.
12569         (struct until_next_fsm): Inherit from thread_fsm.  Add
12570         constructor.
12571         (until_next_fsm_ops): Remove.
12572         (new_until_next_fsm): Remove.
12573         (until_next_fsm::should_stop): Rename from
12574         until_next_fsm_should_stop.
12575         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12576         (until_next_fsm::do_async_reply_reason): Rename from
12577         until_next_fsm_async_reply_reason.
12578         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12579         constructor.  Change type of breakpoint.
12580         (finish_command_fsm_ops): Remove.
12581         (new_finish_command_fsm): Remove.
12582         (finish_command_fsm::should_stop): Rename from
12583         finish_command_fsm_should_stop.
12584         (finish_command_fsm::clean_up): Rename from
12585         finish_command_fsm_clean_up.
12586         (finish_command_fsm::return_value): Rename from
12587         finish_command_fsm_return_value.
12588         (finish_command_fsm::do_async_reply_reason): Rename from
12589         finish_command_fsm_async_reply_reason.
12590         (finish_command): Update.
12591         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12592         Add constructor.
12593         (call_thread_fsm_ops): Remove.
12594         (call_thread_fsm::call_thread_fsm): Rename from
12595         new_call_thread_fsm.
12596         (call_thread_fsm::should_stop): Rename from
12597         call_thread_fsm_should_stop.
12598         (call_thread_fsm::should_notify_stop): Rename from
12599         call_thread_fsm_should_notify_stop.
12600         (run_inferior_call, call_function_by_hand_dummy): Update.
12601         * cli/cli-interp.c (should_print_stop_to_console): Update.
12602         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12603         Add constructor.  Change type of location_breakpoint,
12604         caller_breakpoint.
12605         (until_break_fsm_ops): Remove.
12606         (new_until_break_fsm): Remove.
12607         (until_break_fsm::should_stop): Rename from
12608         until_break_fsm_should_stop.
12609         (until_break_fsm::clean_up): Rename from
12610         until_break_fsm_clean_up.
12611         (until_break_fsm::do_async_reply_reason): Rename from
12612         until_break_fsm_async_reply_reason.
12613         (until_break_command): Update.
12614         * thread-fsm.c: Remove.
12615         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12616
12617 2019-02-07  Tom Tromey  <tom@tromey.com>
12618
12619         * yy-remap.h: Add include guard.
12620         * xtensa-tdep.h: Add include guard.
12621         * xcoffread.h: Rename include guard.
12622         * varobj-iter.h: Add include guard.
12623         * tui/tui.h: Rename include guard.
12624         * tui/tui-winsource.h: Rename include guard.
12625         * tui/tui-wingeneral.h: Rename include guard.
12626         * tui/tui-windata.h: Rename include guard.
12627         * tui/tui-win.h: Rename include guard.
12628         * tui/tui-stack.h: Rename include guard.
12629         * tui/tui-source.h: Rename include guard.
12630         * tui/tui-regs.h: Rename include guard.
12631         * tui/tui-out.h: Rename include guard.
12632         * tui/tui-layout.h: Rename include guard.
12633         * tui/tui-io.h: Rename include guard.
12634         * tui/tui-hooks.h: Rename include guard.
12635         * tui/tui-file.h: Rename include guard.
12636         * tui/tui-disasm.h: Rename include guard.
12637         * tui/tui-data.h: Rename include guard.
12638         * tui/tui-command.h: Rename include guard.
12639         * tic6x-tdep.h: Add include guard.
12640         * target/waitstatus.h: Rename include guard.
12641         * target/wait.h: Rename include guard.
12642         * target/target.h: Rename include guard.
12643         * target/resume.h: Rename include guard.
12644         * target-float.h: Rename include guard.
12645         * stabsread.h: Add include guard.
12646         * rs6000-tdep.h: Add include guard.
12647         * riscv-fbsd-tdep.h: Add include guard.
12648         * regformats/regdef.h: Rename include guard.
12649         * record.h: Rename include guard.
12650         * python/python.h: Rename include guard.
12651         * python/python-internal.h: Rename include guard.
12652         * python/py-stopevent.h: Rename include guard.
12653         * python/py-ref.h: Rename include guard.
12654         * python/py-record.h: Rename include guard.
12655         * python/py-record-full.h: Rename include guard.
12656         * python/py-record-btrace.h: Rename include guard.
12657         * python/py-instruction.h: Rename include guard.
12658         * python/py-events.h: Rename include guard.
12659         * python/py-event.h: Rename include guard.
12660         * procfs.h: Add include guard.
12661         * proc-utils.h: Add include guard.
12662         * p-lang.h: Add include guard.
12663         * or1k-tdep.h: Rename include guard.
12664         * observable.h: Rename include guard.
12665         * nto-tdep.h: Rename include guard.
12666         * nat/x86-linux.h: Rename include guard.
12667         * nat/x86-linux-dregs.h: Rename include guard.
12668         * nat/x86-gcc-cpuid.h: Add include guard.
12669         * nat/x86-dregs.h: Rename include guard.
12670         * nat/x86-cpuid.h: Rename include guard.
12671         * nat/ppc-linux.h: Rename include guard.
12672         * nat/mips-linux-watch.h: Rename include guard.
12673         * nat/linux-waitpid.h: Rename include guard.
12674         * nat/linux-ptrace.h: Rename include guard.
12675         * nat/linux-procfs.h: Rename include guard.
12676         * nat/linux-osdata.h: Rename include guard.
12677         * nat/linux-nat.h: Rename include guard.
12678         * nat/linux-namespaces.h: Rename include guard.
12679         * nat/linux-btrace.h: Rename include guard.
12680         * nat/glibc_thread_db.h: Rename include guard.
12681         * nat/gdb_thread_db.h: Rename include guard.
12682         * nat/gdb_ptrace.h: Rename include guard.
12683         * nat/fork-inferior.h: Rename include guard.
12684         * nat/amd64-linux-siginfo.h: Rename include guard.
12685         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12686         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12687         * nat/aarch64-linux.h: Rename include guard.
12688         * nat/aarch64-linux-hw-point.h: Rename include guard.
12689         * mn10300-tdep.h: Add include guard.
12690         * mips-linux-tdep.h: Add include guard.
12691         * mi/mi-parse.h: Rename include guard.
12692         * mi/mi-out.h: Rename include guard.
12693         * mi/mi-main.h: Rename include guard.
12694         * mi/mi-interp.h: Rename include guard.
12695         * mi/mi-getopt.h: Rename include guard.
12696         * mi/mi-console.h: Rename include guard.
12697         * mi/mi-common.h: Rename include guard.
12698         * mi/mi-cmds.h: Rename include guard.
12699         * mi/mi-cmd-break.h: Rename include guard.
12700         * m2-lang.h: Add include guard.
12701         * location.h: Rename include guard.
12702         * linux-record.h: Rename include guard.
12703         * linux-nat.h: Add include guard.
12704         * linux-fork.h: Add include guard.
12705         * i386-darwin-tdep.h: Rename include guard.
12706         * hppa-linux-offsets.h: Add include guard.
12707         * guile/guile.h: Rename include guard.
12708         * guile/guile-internal.h: Rename include guard.
12709         * gnu-nat.h: Rename include guard.
12710         * gdb-stabs.h: Rename include guard.
12711         * frv-tdep.h: Add include guard.
12712         * f-lang.h: Add include guard.
12713         * event-loop.h: Add include guard.
12714         * darwin-nat.h: Rename include guard.
12715         * cp-abi.h: Rename include guard.
12716         * config/sparc/nm-sol2.h: Rename include guard.
12717         * config/nm-nto.h: Rename include guard.
12718         * config/nm-linux.h: Add include guard.
12719         * config/i386/nm-i386gnu.h: Rename include guard.
12720         * config/djgpp/nl_types.h: Rename include guard.
12721         * config/djgpp/langinfo.h: Rename include guard.
12722         * compile/gcc-cp-plugin.h: Add include guard.
12723         * compile/gcc-c-plugin.h: Add include guard.
12724         * compile/compile.h: Rename include guard.
12725         * compile/compile-object-run.h: Rename include guard.
12726         * compile/compile-object-load.h: Rename include guard.
12727         * compile/compile-internal.h: Rename include guard.
12728         * compile/compile-cplus.h: Rename include guard.
12729         * compile/compile-c.h: Rename include guard.
12730         * common/xml-utils.h: Rename include guard.
12731         * common/x86-xstate.h: Rename include guard.
12732         * common/version.h: Rename include guard.
12733         * common/vec.h: Rename include guard.
12734         * common/tdesc.h: Rename include guard.
12735         * common/selftest.h: Rename include guard.
12736         * common/scoped_restore.h: Rename include guard.
12737         * common/scoped_mmap.h: Rename include guard.
12738         * common/scoped_fd.h: Rename include guard.
12739         * common/safe-iterator.h: Rename include guard.
12740         * common/run-time-clock.h: Rename include guard.
12741         * common/refcounted-object.h: Rename include guard.
12742         * common/queue.h: Rename include guard.
12743         * common/ptid.h: Rename include guard.
12744         * common/print-utils.h: Rename include guard.
12745         * common/preprocessor.h: Rename include guard.
12746         * common/pathstuff.h: Rename include guard.
12747         * common/observable.h: Rename include guard.
12748         * common/netstuff.h: Rename include guard.
12749         * common/job-control.h: Rename include guard.
12750         * common/host-defs.h: Rename include guard.
12751         * common/gdb_wait.h: Rename include guard.
12752         * common/gdb_vecs.h: Rename include guard.
12753         * common/gdb_unlinker.h: Rename include guard.
12754         * common/gdb_unique_ptr.h: Rename include guard.
12755         * common/gdb_tilde_expand.h: Rename include guard.
12756         * common/gdb_sys_time.h: Rename include guard.
12757         * common/gdb_string_view.h: Rename include guard.
12758         * common/gdb_splay_tree.h: Rename include guard.
12759         * common/gdb_setjmp.h: Rename include guard.
12760         * common/gdb_ref_ptr.h: Rename include guard.
12761         * common/gdb_optional.h: Rename include guard.
12762         * common/gdb_locale.h: Rename include guard.
12763         * common/gdb_assert.h: Rename include guard.
12764         * common/filtered-iterator.h: Rename include guard.
12765         * common/filestuff.h: Rename include guard.
12766         * common/fileio.h: Rename include guard.
12767         * common/environ.h: Rename include guard.
12768         * common/common-utils.h: Rename include guard.
12769         * common/common-types.h: Rename include guard.
12770         * common/common-regcache.h: Rename include guard.
12771         * common/common-inferior.h: Rename include guard.
12772         * common/common-gdbthread.h: Rename include guard.
12773         * common/common-exceptions.h: Rename include guard.
12774         * common/common-defs.h: Rename include guard.
12775         * common/common-debug.h: Rename include guard.
12776         * common/cleanups.h: Rename include guard.
12777         * common/buffer.h: Rename include guard.
12778         * common/btrace-common.h: Rename include guard.
12779         * common/break-common.h: Rename include guard.
12780         * cli/cli-utils.h: Rename include guard.
12781         * cli/cli-style.h: Rename include guard.
12782         * cli/cli-setshow.h: Rename include guard.
12783         * cli/cli-script.h: Rename include guard.
12784         * cli/cli-interp.h: Rename include guard.
12785         * cli/cli-decode.h: Rename include guard.
12786         * cli/cli-cmds.h: Rename include guard.
12787         * charset-list.h: Add include guard.
12788         * buildsym-legacy.h: Rename include guard.
12789         * bfin-tdep.h: Add include guard.
12790         * ax.h: Rename include guard.
12791         * arm-linux-tdep.h: Add include guard.
12792         * arm-fbsd-tdep.h: Add include guard.
12793         * arch/xtensa.h: Rename include guard.
12794         * arch/tic6x.h: Add include guard.
12795         * arch/i386.h: Add include guard.
12796         * arch/arm.h: Rename include guard.
12797         * arch/arm-linux.h: Rename include guard.
12798         * arch/arm-get-next-pcs.h: Rename include guard.
12799         * arch/amd64.h: Add include guard.
12800         * arch/aarch64-insn.h: Rename include guard.
12801         * arch-utils.h: Rename include guard.
12802         * annotate.h: Add include guard.
12803         * amd64-darwin-tdep.h: Rename include guard.
12804         * aarch64-linux-tdep.h: Add include guard.
12805         * aarch64-fbsd-tdep.h: Add include guard.
12806         * aarch32-linux-nat.h: Add include guard.
12807
12808 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12809
12810         * macrotab.c (macro_define_internal): New function that
12811         factorizes macro_define_object_internal and macro_define_function
12812         code.
12813         (macro_define_object_internal): Use macro_define_internal.
12814         (macro_define_function): Likewise.
12815
12816 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12817
12818         * macrocmd.c (extract_identifier): Return
12819         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12820         callers.
12821
12822 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12823
12824         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12825
12826 2019-02-05  Tom Tromey  <tom@tromey.com>
12827
12828         * target.c (target_stack::unpush): Move assertion earlier.
12829
12830 2019-01-30  Tom Tromey  <tom@tromey.com>
12831
12832         PR python/23615:
12833         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12834         (gdbpy_parse_and_eval): Likewise.
12835         * python/python-internal.h (gdbpy_allow_threads): New class.
12836
12837 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12838
12839         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12840         (aarch64_fbsd_fpregmap): Move earlier.
12841         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12842         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12843         instead of individual calls to trad_frame_set_reg_addr.
12844         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12845         earlier.
12846         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12847         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12848         instead of individual calls to trad_frame_set_reg_addr.
12849
12850 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12851
12852         * CONTRIBUTE: Replace contribution list with wiki link.
12853
12854 2019-01-25  Tom Tromey  <tom@tromey.com>
12855
12856         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12857
12858 2019-01-25  Tom Tromey  <tom@tromey.com>
12859
12860         * xtensa-linux-nat.c: Fix common/ includes.
12861         * xml-support.h: Fix common/ includes.
12862         * xml-support.c: Fix common/ includes.
12863         * x86-linux-nat.c: Fix common/ includes.
12864         * windows-nat.c: Fix common/ includes.
12865         * varobj.h: Fix common/ includes.
12866         * varobj.c: Fix common/ includes.
12867         * value.c: Fix common/ includes.
12868         * valops.c: Fix common/ includes.
12869         * utils.c: Fix common/ includes.
12870         * unittests/xml-utils-selftests.c: Fix common/ includes.
12871         * unittests/utils-selftests.c: Fix common/ includes.
12872         * unittests/unpack-selftests.c: Fix common/ includes.
12873         * unittests/tracepoint-selftests.c: Fix common/ includes.
12874         * unittests/style-selftests.c: Fix common/ includes.
12875         * unittests/string_view-selftests.c: Fix common/ includes.
12876         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12877         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12878         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12879         * unittests/rsp-low-selftests.c: Fix common/ includes.
12880         * unittests/parse-connection-spec-selftests.c: Fix common/
12881         includes.
12882         * unittests/optional-selftests.c: Fix common/ includes.
12883         * unittests/offset-type-selftests.c: Fix common/ includes.
12884         * unittests/observable-selftests.c: Fix common/ includes.
12885         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12886         * unittests/memrange-selftests.c: Fix common/ includes.
12887         * unittests/memory-map-selftests.c: Fix common/ includes.
12888         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12889         * unittests/function-view-selftests.c: Fix common/ includes.
12890         * unittests/environ-selftests.c: Fix common/ includes.
12891         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12892         * unittests/common-utils-selftests.c: Fix common/ includes.
12893         * unittests/cli-utils-selftests.c: Fix common/ includes.
12894         * unittests/array-view-selftests.c: Fix common/ includes.
12895         * ui-file.c: Fix common/ includes.
12896         * tui/tui-io.c: Fix common/ includes.
12897         * tracepoint.h: Fix common/ includes.
12898         * tracepoint.c: Fix common/ includes.
12899         * tracefile-tfile.c: Fix common/ includes.
12900         * top.h: Fix common/ includes.
12901         * top.c: Fix common/ includes.
12902         * thread.c: Fix common/ includes.
12903         * target/waitstatus.h: Fix common/ includes.
12904         * target/waitstatus.c: Fix common/ includes.
12905         * target.h: Fix common/ includes.
12906         * target.c: Fix common/ includes.
12907         * target-memory.c: Fix common/ includes.
12908         * target-descriptions.c: Fix common/ includes.
12909         * symtab.h: Fix common/ includes.
12910         * symfile.c: Fix common/ includes.
12911         * stap-probe.c: Fix common/ includes.
12912         * spu-linux-nat.c: Fix common/ includes.
12913         * sparc-nat.c: Fix common/ includes.
12914         * source.c: Fix common/ includes.
12915         * solib.c: Fix common/ includes.
12916         * solib-target.c: Fix common/ includes.
12917         * ser-unix.c: Fix common/ includes.
12918         * ser-tcp.c: Fix common/ includes.
12919         * ser-pipe.c: Fix common/ includes.
12920         * ser-base.c: Fix common/ includes.
12921         * selftest-arch.c: Fix common/ includes.
12922         * s12z-tdep.c: Fix common/ includes.
12923         * rust-exp.y: Fix common/ includes.
12924         * rs6000-aix-tdep.c: Fix common/ includes.
12925         * riscv-tdep.c: Fix common/ includes.
12926         * remote.c: Fix common/ includes.
12927         * remote-notif.h: Fix common/ includes.
12928         * remote-fileio.h: Fix common/ includes.
12929         * remote-fileio.c: Fix common/ includes.
12930         * regcache.h: Fix common/ includes.
12931         * regcache.c: Fix common/ includes.
12932         * record-btrace.c: Fix common/ includes.
12933         * python/python.c: Fix common/ includes.
12934         * python/py-type.c: Fix common/ includes.
12935         * python/py-inferior.c: Fix common/ includes.
12936         * progspace.h: Fix common/ includes.
12937         * producer.c: Fix common/ includes.
12938         * procfs.c: Fix common/ includes.
12939         * proc-api.c: Fix common/ includes.
12940         * printcmd.c: Fix common/ includes.
12941         * ppc-linux-nat.c: Fix common/ includes.
12942         * parser-defs.h: Fix common/ includes.
12943         * osdata.c: Fix common/ includes.
12944         * obsd-nat.c: Fix common/ includes.
12945         * nat/x86-linux.c: Fix common/ includes.
12946         * nat/x86-linux-dregs.c: Fix common/ includes.
12947         * nat/x86-dregs.h: Fix common/ includes.
12948         * nat/x86-dregs.c: Fix common/ includes.
12949         * nat/ppc-linux.c: Fix common/ includes.
12950         * nat/mips-linux-watch.h: Fix common/ includes.
12951         * nat/mips-linux-watch.c: Fix common/ includes.
12952         * nat/linux-waitpid.c: Fix common/ includes.
12953         * nat/linux-ptrace.h: Fix common/ includes.
12954         * nat/linux-ptrace.c: Fix common/ includes.
12955         * nat/linux-procfs.c: Fix common/ includes.
12956         * nat/linux-personality.c: Fix common/ includes.
12957         * nat/linux-osdata.c: Fix common/ includes.
12958         * nat/linux-namespaces.c: Fix common/ includes.
12959         * nat/linux-btrace.h: Fix common/ includes.
12960         * nat/linux-btrace.c: Fix common/ includes.
12961         * nat/fork-inferior.c: Fix common/ includes.
12962         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12963         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12964         * nat/aarch64-linux.c: Fix common/ includes.
12965         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12966         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12967         * namespace.h: Fix common/ includes.
12968         * mips-linux-tdep.c: Fix common/ includes.
12969         * minsyms.c: Fix common/ includes.
12970         * mi/mi-parse.h: Fix common/ includes.
12971         * mi/mi-main.c: Fix common/ includes.
12972         * mi/mi-cmd-env.c: Fix common/ includes.
12973         * memrange.h: Fix common/ includes.
12974         * memattr.c: Fix common/ includes.
12975         * maint.h: Fix common/ includes.
12976         * maint.c: Fix common/ includes.
12977         * main.c: Fix common/ includes.
12978         * machoread.c: Fix common/ includes.
12979         * location.c: Fix common/ includes.
12980         * linux-thread-db.c: Fix common/ includes.
12981         * linux-nat.c: Fix common/ includes.
12982         * linux-fork.c: Fix common/ includes.
12983         * inline-frame.c: Fix common/ includes.
12984         * infrun.c: Fix common/ includes.
12985         * inflow.c: Fix common/ includes.
12986         * inferior.h: Fix common/ includes.
12987         * inferior.c: Fix common/ includes.
12988         * infcmd.c: Fix common/ includes.
12989         * inf-ptrace.c: Fix common/ includes.
12990         * inf-child.c: Fix common/ includes.
12991         * ia64-linux-nat.c: Fix common/ includes.
12992         * i387-tdep.c: Fix common/ includes.
12993         * i386-tdep.c: Fix common/ includes.
12994         * i386-linux-tdep.c: Fix common/ includes.
12995         * i386-linux-nat.c: Fix common/ includes.
12996         * i386-go32-tdep.c: Fix common/ includes.
12997         * i386-fbsd-tdep.c: Fix common/ includes.
12998         * i386-fbsd-nat.c: Fix common/ includes.
12999         * guile/scm-type.c: Fix common/ includes.
13000         * guile/guile.c: Fix common/ includes.
13001         * go32-nat.c: Fix common/ includes.
13002         * gnu-nat.c: Fix common/ includes.
13003         * gdbthread.h: Fix common/ includes.
13004         * gdbarch-selftests.c: Fix common/ includes.
13005         * gdb_usleep.c: Fix common/ includes.
13006         * gdb_select.h: Fix common/ includes.
13007         * gdb_bfd.c: Fix common/ includes.
13008         * gcore.c: Fix common/ includes.
13009         * fork-child.c: Fix common/ includes.
13010         * findvar.c: Fix common/ includes.
13011         * fbsd-nat.c: Fix common/ includes.
13012         * event-top.c: Fix common/ includes.
13013         * event-loop.c: Fix common/ includes.
13014         * dwarf2read.c: Fix common/ includes.
13015         * dwarf2loc.c: Fix common/ includes.
13016         * dwarf2-frame.c: Fix common/ includes.
13017         * dwarf-index-cache.c: Fix common/ includes.
13018         * dtrace-probe.c: Fix common/ includes.
13019         * disasm-selftests.c: Fix common/ includes.
13020         * defs.h: Fix common/ includes.
13021         * csky-tdep.c: Fix common/ includes.
13022         * cp-valprint.c: Fix common/ includes.
13023         * cp-support.h: Fix common/ includes.
13024         * cp-support.c: Fix common/ includes.
13025         * corelow.c: Fix common/ includes.
13026         * completer.h: Fix common/ includes.
13027         * completer.c: Fix common/ includes.
13028         * compile/compile.c: Fix common/ includes.
13029         * compile/compile-loc2c.c: Fix common/ includes.
13030         * compile/compile-cplus-types.c: Fix common/ includes.
13031         * compile/compile-cplus-symbols.c: Fix common/ includes.
13032         * command.h: Fix common/ includes.
13033         * cli/cli-dump.c: Fix common/ includes.
13034         * cli/cli-cmds.c: Fix common/ includes.
13035         * charset.c: Fix common/ includes.
13036         * build-id.c: Fix common/ includes.
13037         * btrace.h: Fix common/ includes.
13038         * btrace.c: Fix common/ includes.
13039         * breakpoint.h: Fix common/ includes.
13040         * breakpoint.c: Fix common/ includes.
13041         * ax.h:
13042         (enum agent_op): Fix common/ includes.
13043         * ax-general.c (struct aop_map): Fix common/ includes.
13044         * ax-gdb.c: Fix common/ includes.
13045         * auxv.c: Fix common/ includes.
13046         * auto-load.c: Fix common/ includes.
13047         * arm-tdep.c: Fix common/ includes.
13048         * arch/riscv.c: Fix common/ includes.
13049         * arch/ppc-linux-common.c: Fix common/ includes.
13050         * arch/i386.c: Fix common/ includes.
13051         * arch/arm.c: Fix common/ includes.
13052         * arch/arm-linux.c: Fix common/ includes.
13053         * arch/arm-get-next-pcs.c: Fix common/ includes.
13054         * arch/amd64.c: Fix common/ includes.
13055         * arch/aarch64.c: Fix common/ includes.
13056         * arch/aarch64-insn.c: Fix common/ includes.
13057         * arch-utils.c: Fix common/ includes.
13058         * amd64-windows-tdep.c: Fix common/ includes.
13059         * amd64-tdep.c: Fix common/ includes.
13060         * amd64-sol2-tdep.c: Fix common/ includes.
13061         * amd64-obsd-tdep.c: Fix common/ includes.
13062         * amd64-nbsd-tdep.c: Fix common/ includes.
13063         * amd64-linux-tdep.c: Fix common/ includes.
13064         * amd64-linux-nat.c: Fix common/ includes.
13065         * amd64-fbsd-tdep.c: Fix common/ includes.
13066         * amd64-fbsd-nat.c: Fix common/ includes.
13067         * amd64-dicos-tdep.c: Fix common/ includes.
13068         * amd64-darwin-tdep.c: Fix common/ includes.
13069         * agent.c: Fix common/ includes.
13070         * ada-lang.h: Fix common/ includes.
13071         * ada-lang.c: Fix common/ includes.
13072         * aarch64-tdep.c: Fix common/ includes.
13073
13074 2019-01-25  Tom Tromey  <tom@tromey.com>
13075
13076         * common/create-version.sh: Use common/version.h.
13077
13078 2019-01-24  Pedro Alves  <palves@redhat.com>
13079
13080         * infrun.c (signal_stop, signal_print, signal_program)
13081         (signal_catch, signal_pass): Now arrays instead of pointers.
13082         (update_signals_program_target, do_target_resume)
13083         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13084         * linux-nat.c (linux_nat_target::pass_signals)
13085         (linux_nat_target::create_inferior, linux_nat_target::attach):
13086         Adjust.
13087         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13088         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13089         * procfs.c (procfs_target::pass_signals): Adjust.
13090         * record-full.c (record_full_target::resume): Adjust.
13091         * remote.c (remote_target::pass_signals)
13092         (remote_target::program_signals): Adjust.
13093         * target-debug.h (target_debug_print_signals): Now takes a
13094         gdb::array_view as parameter.  Adjust.
13095         * target.h (target_ops) <pass_signals, program_signals>: Replace
13096         pointer and length parameters with gdb::array_view.
13097         (target_pass_signals, target_program_signals): Likewise.
13098         * target-delegates.c: Regenerate.
13099
13100 2019-01-24  Pedro Alves  <palves@redhat.com>
13101
13102         * common/forward-scope-exit.h
13103         (forward_scope_exit::forward_scope_exit): Pass arguments to
13104         m_bind_function directly, instead of creating a std::bind and
13105         copying that.
13106
13107 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13108
13109         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13110         for static members.
13111         (pass_in_v_vfp_candidate): Likewise.
13112
13113 2019-01-23  Tom Tromey  <tom@tromey.com>
13114             Pedro Alves  <palves@redhat.com>
13115
13116         * regcache.c (class regcache_invalidator): Remove.
13117         (regcache::raw_write): Use make_scope_exit.
13118
13119 2019-01-23  Tom Tromey  <tom@tromey.com>
13120
13121         * ui-out.h (class ui_out_emit_type): Update comment.
13122
13123 2019-01-23  Tom Tromey  <tom@tromey.com>
13124
13125         * infrun.c (fetch_inferior_event): Update comment.
13126
13127 2019-01-23  Tom Tromey  <tom@tromey.com>
13128             Pedro Alves  <palves@redhat.com>
13129
13130         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13131         parameter.
13132         (fetch_inferior_event): Use SCOPE_EXIT.
13133
13134
13135 2019-01-23  Tom Tromey  <tom@tromey.com>
13136             Pedro Alves  <palves@redhat.com>
13137
13138         * infrun.c (disable_thread_events): Delete.
13139         (stop_all_threads): Use SCOPE_EXIT.
13140
13141 2019-01-23  Tom Tromey  <tom@tromey.com>
13142             Pedro Alves  <palves@redhat.com>
13143
13144         * symfile.c: Include forward-scope-exit.h.
13145         (clear_symtab_users_cleanup): Replace forward declaration with
13146         a FORWARD_SCOPE_EXIT.
13147         (syms_from_objfile_1): Use the forward_scope_exit and
13148         gdb::optional instead of cleanup_function.
13149         (reread_symbols): Use the forward_scope_exit instead of
13150         cleanup_function.
13151         (clear_symtab_users_cleanup): Remove function.
13152
13153 2019-01-23  Tom Tromey  <tom@tromey.com>
13154             Pedro Alves  <palves@redhat.com>
13155
13156         * linux-nat.c: Include scope-exit.h.
13157         (cleanup_target_stop): Remove.
13158         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13159         SCOPE_EXIT.
13160
13161 2019-01-23  Tom Tromey  <tom@tromey.com>
13162             Pedro Alves  <palves@redhat.com>
13163
13164         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13165         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13166
13167 2019-01-23  Tom Tromey  <tom@tromey.com>
13168             Andrew Burgess  <andrew.burgess@embecosm.com>
13169             Pedro Alves  <palves@redhat.com>
13170
13171         * infrun.c (fetch_inferior_event): Use scope_exit.
13172         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13173         * top.c (execute_command): Use scope_exit.
13174         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13175         * utils.c (do_bpstat_clear_actions_cleanup)
13176         (make_bpstat_clear_actions_cleanup): Remove.
13177
13178 2019-01-23  Tom Tromey  <tom@tromey.com>
13179             Pedro Alves  <palves@redhat.com>
13180
13181         * infrun.c: Include "common/scope-exit.h"
13182         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13183         (wait_for_inferior): Use SCOPE_EXIT.
13184         (fetch_inferior_event): Use scope_exit.
13185
13186 2019-01-23  Tom Tromey  <tom@tromey.com>
13187             Pedro Alves  <palves@redhat.com>
13188
13189         * breakpoint.c (create_breakpoint): Remove cleanup.
13190
13191 2019-01-23  Tom Tromey  <tom@tromey.com>
13192             Andrew Burgess  <andrew.burgess@embecosm.com>
13193             Pedro Alves  <palves@redhat.com>
13194
13195 2019-01-23  Pedro Alves  <palves@redhat.com>
13196
13197         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13198
13199 2019-01-23  Pedro Alves  <palves@redhat.com>
13200             Andrew Burgess  <andrew.burgess@embecosm.com>
13201
13202         * gdbthread.h: Include "common/forward-scope-exit.h".
13203         (scoped_finish_thread_state): Redefine custom class in terms of
13204         forward_scope_exit.
13205
13206 2019-01-23  Pedro Alves  <palves@redhat.com>
13207             Andrew Burgess  <andrew.burgess@embecosm.com>
13208
13209         * common/forward-scope-exit.h: New file.
13210
13211 2019-01-23  Pedro Alves  <palves@redhat.com>
13212             Andrew Burgess  <andrew.burgess@embecosm.com>
13213             Tom Tromey  <tom@tromey.com>
13214
13215         * common/scope-exit.h: New file.
13216
13217 2019-01-23  Pedro Alves  <palves@redhat.com>
13218
13219         * common/preprocessor.h (ESC): Rename to ...
13220         (ESC_PARENS): ... this.
13221         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13222         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13223
13224 2019-01-23  Tom Tromey  <tom@tromey.com>
13225
13226         * language.h (class scoped_switch_to_sym_language_if_auto):
13227         Initialize m_lang in both cases.
13228
13229 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13230
13231         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13232         with XCNEW.
13233
13234 2019-01-22  Tom Tromey  <tom@tromey.com>
13235
13236         * corelow.c: Do not include sys/file.h.
13237
13238 2019-01-22  Tom Tromey  <tom@tromey.com>
13239
13240         * tui/tui-wingeneral.h: Include gdb_curses.h.
13241
13242 2019-01-22  Tom Tromey  <tom@tromey.com>
13243
13244         * source-cache.h (class source_cache) <get_source_lines,
13245         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13246
13247 2019-01-22  Tom Tromey  <tom@tromey.com>
13248
13249         * remote-fileio.h (struct remote_target): Declare.
13250
13251 2019-01-22  Tom Tromey  <tom@tromey.com>
13252
13253         * python/py-arch.c: Do not include py-ref.h.
13254         * python/py-bpevent.c: Do not include py-ref.h.
13255         * python/py-cmd.c: Do not include py-ref.h.
13256         * python/py-continueevent.c: Do not include py-ref.h.
13257         * python/py-event.h: Do not include py-ref.h.
13258         * python/py-evtregistry.c: Do not include py-ref.h.
13259         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13260         * python/py-frame.c: Do not include py-ref.h.
13261         * python/py-framefilter.c: Do not include py-ref.h.
13262         * python/py-function.c: Do not include py-ref.h.
13263         * python/py-infevents.c: Do not include py-ref.h.
13264         * python/py-linetable.c: Do not include py-ref.h.
13265         * python/py-objfile.c: Do not include py-ref.h.
13266         * python/py-param.c: Do not include py-ref.h.
13267         * python/py-prettyprint.c: Do not include py-ref.h.
13268         * python/py-progspace.c: Do not include py-ref.h.
13269         * python/py-symbol.c: Do not include py-ref.h.
13270         * python/py-symtab.c: Do not include py-ref.h.
13271         * python/py-type.c: Do not include py-ref.h.
13272         * python/py-unwind.c: Do not include py-ref.h.
13273         * python/py-utils.c: Do not include py-ref.h.
13274         * python/py-value.c: Do not include py-ref.h.
13275         * python/py-varobj.c: Do not include py-ref.h.
13276         * python/py-xmethods.c: Do not include py-ref.h.
13277         * python/python.c: Do not include py-ref.h.
13278         * varobj.c: Do not include py-ref.h.
13279
13280 2019-01-22  Tom Tromey  <tom@tromey.com>
13281
13282         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13283         keyword for bcache.
13284
13285 2019-01-22  Tom Tromey  <tom@tromey.com>
13286
13287         * compile/compile-cplus-types.c: Remove a comment by #include.
13288
13289 2019-01-22  Tom Tromey  <tom@tromey.com>
13290
13291         * compile/gcc-c-plugin.h: Include compile-internal.h.
13292
13293 2019-01-22  Tom Tromey  <tom@tromey.com>
13294
13295         * stabsread.c (EXTERN): Do not define.
13296         (symnum, next_symbol_text_func, processing_gcc_compilation)
13297         (within_function, global_sym_chain, global_stabs)
13298         (previous_stab_code, this_object_header_files)
13299         (n_this_object_header_files)
13300         (n_allocated_this_object_header_files): Define.
13301         * stabsread.h (EXTERN): Never define.  Use "extern".
13302
13303 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13304
13305         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13306         history_value.
13307
13308 2019-01-21  Tom Tromey  <tom@tromey.com>
13309
13310         * ui-out.c: Fix includes.
13311         * tui/tui-source.c: Fix includes.
13312         * target.c: Fix includes.
13313         * remote.c: Fix includes.
13314         * regcache.c: Fix includes.
13315         * python/py-block.c: Fix includes.
13316         * printcmd.c: Fix includes.
13317         * or1k-tdep.c: Fix includes.
13318         * mi/mi-main.c: Fix includes.
13319         * m32r-tdep.c: Fix includes.
13320         * csky-tdep.c: Fix includes.
13321         * compile/compile-cplus-types.c: Fix includes.
13322         * cli/cli-interp.c: Fix includes.
13323
13324 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13325
13326         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13327         for padding.
13328
13329 2019-01-16  Tom Tromey  <tom@tromey.com>
13330
13331         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13332         earlier.
13333         (struct objfile) <msymbols_range>: Move from top level.
13334         <msymbols>: New method.
13335         (class objfile_msymbols): Remove.
13336         * symtab.c (default_collect_symbol_completion_matches_break_on):
13337         Update.
13338         * symmisc.c (dump_msymbols): Update.
13339         * stabsread.c (scan_file_globals): Update.
13340         * objc-lang.c (info_selectors_command, info_classes_command)
13341         (find_methods): Update.
13342         * minsyms.c (find_solib_trampoline_target): Update.
13343         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13344         * coffread.c (coff_symfile_read): Update.
13345         * ada-lang.c (ada_lookup_simple_minsym)
13346         (ada_collect_symbol_completion_matches): Update.
13347
13348 2019-01-16  Tom Tromey  <tom@tromey.com>
13349
13350         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13351         type.  Remove no-argument constructor.
13352         <iterator::operator++>: Simplify.
13353         <begin>: Update.
13354         <end>: Use minimal_symbol_count.
13355
13356 2019-01-16  Tom Tromey  <tom@tromey.com>
13357
13358         * objfiles.h (struct objfile) <psymtabs>: New method.
13359         (class objfile_psymtabs): Remove.
13360         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13361         typedef.
13362         <range>: New method.
13363         (require_partial_symbols): Change return type.
13364         * psymtab.c (require_partial_symbols)
13365         (psym_expand_symtabs_matching): Update.
13366         * mdebugread.c (parse_partial_symbols): Update.
13367         * dbxread.c (dbx_end_psymtab): Update.
13368
13369 2019-01-15  Tom Tromey  <tom@tromey.com>
13370
13371         * symtab.c (lookup_objfile_from_block)
13372         (lookup_symbol_in_objfile_symtabs)
13373         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13374         (find_line_symtab, info_sources_command)
13375         (default_collect_symbol_completion_matches_break_on)
13376         (make_source_files_completion_list): Update.
13377         * symmisc.c (print_objfile_statistics, dump_objfile)
13378         (maintenance_print_symbols, maintenance_info_symtabs)
13379         (maintenance_check_symtabs, maintenance_info_line_tables):
13380         Update.
13381         * source.c (select_source_symtab)
13382         (forget_cached_source_info_for_objfile): Update.
13383         * objfiles.h (class objfile_compunits): Remove.
13384         (struct objfile) <compunits_range>: New typedef.
13385         (compunits): New method.
13386         * objfiles.c (objfile_relocate1): Update.
13387         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13388         * maint.c (count_symtabs_and_blocks): Update.
13389         * linespec.c (iterate_over_all_matching_symtabs): Update.
13390         * cp-support.c (add_symbol_overload_list_qualified): Update.
13391         * coffread.c (coff_symtab_read): Update.
13392         * ada-lang.c (add_nonlocal_symbols)
13393         (ada_collect_symbol_completion_matches)
13394         (ada_add_global_exceptions): Update.
13395
13396 2019-01-15  Tom Tromey  <tom@tromey.com>
13397
13398         * progspace.h (program_space) <objfiles_safe_range>: New
13399         typedef.
13400         <objfiles_safe>: New method.
13401         * objfiles.h (class all_objfiles_safe): Remove.
13402         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13403         * jit.c (jit_inferior_exit_hook): Update.
13404
13405 2019-01-17  Tom Tromey  <tom@tromey.com>
13406
13407         * progspace.h (program_space) <objfiles_range>: New typedef.
13408         <objfiles>: New method.
13409         <objfiles_head>: Rename from objfiles.
13410         (object_files): Update.
13411         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13412         * guile/scm-pretty-print.c
13413         (ppscm_find_pretty_printer_from_objfiles): Update.
13414         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13415         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13416         Update.
13417         * python/py-progspace.c (pspy_get_objfiles): Update.
13418         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13419         Update.
13420         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13421         (objfpy_lookup_objfile_by_build_id): Update.
13422         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13423         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13424         Update.
13425         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13426         (expand_symtab_containing_pc, lookup_objfile_from_block)
13427         (lookup_static_symbol, basic_lookup_transparent_type)
13428         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13429         (find_line_symtab, info_sources_command)
13430         (default_collect_symbol_completion_matches_break_on)
13431         (make_source_files_completion_list, find_main_name): Update.
13432         * symmisc.c (print_symbol_bcache_statistics)
13433         (print_objfile_statistics, maintenance_print_symbols)
13434         (maintenance_print_msymbols, maintenance_print_objfiles)
13435         (maintenance_info_symtabs, maintenance_check_symtabs)
13436         (maintenance_expand_symtabs, maintenance_info_line_tables):
13437         Update.
13438         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13439         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13440         (map_overlay_command, unmap_overlay_command)
13441         (simple_overlay_update, expand_symtabs_matching)
13442         (map_symbol_filenames): Update.
13443         * symfile-debug.c (set_debug_symfile): Update.
13444         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13445         Update.
13446         * source.c (select_source_symtab, forget_cached_source_info):
13447         Update.
13448         * solib.c (solib_read_symbols): Update.
13449         * solib-spu.c (append_ocl_sos): Update.
13450         * psymtab.c (maintenance_print_psymbols)
13451         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13452         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13453         * printcmd.c (info_symbol_command): Update.
13454         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13455         Update.
13456         * objfiles.h (class all_objfiles): Remove.
13457         * objfiles.c (have_partial_symbols, have_full_symbols)
13458         (have_minimal_symbols, qsort_cmp, update_section_map)
13459         (shared_objfile_contains_address_p)
13460         (default_iterate_over_objfiles_in_search_order): Update.
13461         * objc-lang.c (info_selectors_command, info_classes_command)
13462         (find_methods): Update.
13463         * minsyms.c (find_solib_trampoline_target): Update.
13464         * maint.c (maintenance_info_sections)
13465         (maintenance_translate_address, count_symtabs_and_blocks):
13466         Update.
13467         * main.c (captured_main_1): Update.
13468         * linux-thread-db.c (try_thread_db_load_from_pdir)
13469         (has_libpthread): Update.
13470         * linespec.c (iterate_over_all_matching_symtabs)
13471         (search_minsyms_for_name): Update.
13472         * jit.c (jit_find_objf_with_entry_addr): Update.
13473         * hppa-tdep.c (find_unwind_entry)
13474         (hppa_lookup_stub_minimal_symbol): Update.
13475         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13476         Update.
13477         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13478         (elf_gnu_ifunc_resolve_by_got): Update.
13479         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13480         * dwarf-index-write.c (save_gdb_index_command): Update.
13481         * cp-support.c (add_symbol_overload_list_qualified): Update.
13482         * breakpoint.c (create_overlay_event_breakpoint)
13483         (create_longjmp_master_breakpoint)
13484         (create_std_terminate_master_breakpoint)
13485         (create_exception_master_breakpoint): Update.
13486         * blockframe.c (find_pc_partial_function): Update.
13487         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13488         (ada_collect_symbol_completion_matches)
13489         (ada_add_global_exceptions): Update.
13490
13491 2019-01-17  Tom Tromey  <tom@tromey.com>
13492
13493         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13494         declare VEC.
13495         (solib_target_parse_libraries): Change return type.
13496         (library_list_start_segment, library_list_start_section)
13497         (library_list_end_library, library_list_start_library); Update.
13498         (solib_target_free_library_list): Remove.
13499         (solib_target_parse_libraries): Remove cleanup.  Change return
13500         type.
13501         (solib_target_current_sos): Update.
13502
13503 2019-01-17  Tom Tromey  <tromey@bapiya>
13504
13505         * valprint.c: Replace "the the" with "the".
13506         * symtab.c: Replace "the the" with "the".
13507         * solib.c: Replace "the the" with "the".
13508         * solib-dsbt.c: Replace "the the" with "the".
13509         * linespec.c: Replace "the the" with "the".
13510         * dwarf2loc.h: Replace "the the" with "the".
13511         * amd64-windows-tdep.c: Replace "the the" with "the".
13512         * aarch64-tdep.c: Replace "the the" with "the".
13513
13514 2019-01-16  Keith Seitz  <keiths@redhat.com>
13515
13516         PR gdb/23773
13517         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13518         <builder>: Rename to ..
13519         <m_builder>: ... this and make private.
13520         (dwarf2_cu::get_builder): New method.  Change all users of
13521         `builder' to use this method.
13522         (dwarf2_start_symtab): Move to ...
13523         (dwarf2_cu::start_symtab): ... here.  Update all callers
13524         (setup_type_unit_groups): Move to ...
13525         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13526         callers.
13527         (dwarf2_cu::reset_builder): New method.
13528         (process_full_compunit, process_full_type_unit): Use
13529         dwarf2_cu::reset_builder.
13530         (follow_die_offset): Record the ancestor CU if it is different
13531         from the followed DIE's CU.
13532         (follow_die_sig_1): Likewise.
13533
13534 2019-01-15  Tom Tromey  <tom@tromey.com>
13535
13536         * remote.c (class remote_state) <buf>: Now a char_vector.
13537         <buf_size>: Remove.
13538         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13539         parameter.
13540         (remote_target::getpkt_or_notif_sane_1)
13541         (remote_target::getpkt_sane)
13542         (remote_target::getpkt_or_notif_sane): Likewise.
13543         (class remote_target) <putpkt>: New overload.
13544         (remote_target::read_frame): Change type of "buf_p".  Remove
13545         sizeof_p parameter.
13546         (packet_ok): New overload.
13547         (packet_check_result): New overload.
13548         Update all uses.
13549
13550 2019-01-14  Tom Tromey  <tom@tromey.com>
13551
13552         * remote-notif.c (handle_notification, remote_notif_ack)
13553         (remote_notif_parse): Make "buf" const.
13554         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13555         const.
13556         (remote_notif_parse, remote_notif_ack, handle_notification):
13557         Likewise.
13558         * remote.c (remote_notif_stop_parse): Make "buf" const.
13559         (remote_target::remote_parse_stop_reply): Make "buf" const.
13560         (remote_notif_stop_ack): Make "buf" const.
13561
13562 2019-01-14  Tom Tromey  <tom@tromey.com>
13563
13564         * remote.c (remote_console_output): Make parameter const.
13565
13566 2019-01-14  Tom Tromey  <tom@tromey.com>
13567
13568         * target-debug.h (target_debug_print_signals): Constify.
13569         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13570         * procfs.c (procfs_target::pass_signals): Update.
13571         * linux-nat.c (linux_nat_target::pass_signals): Update.
13572         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13573         * target-delegates.c: Rebuild.
13574         * remote.c (remote_target::program_signals): Update.
13575         (remote_target::pass_signals): Update.
13576         * target.c (target_pass_signals): Constify argument.
13577         (target_program_signals): Likewise.
13578         * target.h (struct target_ops) <pass_signals, program_signals>:
13579         Constify argument.
13580         (target_pass_signals, target_program_signals): Constify argument.
13581
13582 2019-01-14  Tom Tromey  <tom@tromey.com>
13583
13584         PR tui/28819:
13585         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13586
13587 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13588
13589         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13590         field.
13591         * rs6000-tdep.c: Include reggroups.h.
13592         (IS_V_ALIAS_PSEUDOREG): Define.
13593         (rs6000_register_name): Return names for the "vX" aliases.
13594         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13595         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13596         aliases.  Call default_register_reggroup_p for all other
13597         pseudo-registers.
13598         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13599         New functions.
13600         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13601         Handle "vX" aliases.
13602         (v_alias_pseudo_register_collect): New function.
13603         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13604         (rs6000_gdbarch_init): Initialize "vX" aliases as
13605         pseudo-registers.  Restore registration of
13606         rs6000_pseudo_register_reggroup_p with
13607         set_tdesc_pseudo_register_reggroup_p.
13608
13609 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13610
13611         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13612         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13613         set_gdbarch_num_pseudo_regs.
13614
13615 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13616
13617         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13618         Remove arg prefixname, add do_set and do_show.
13619         Add member functions set_list and show_list.
13620         * cli/cli-style.c (class cli_style_option): Update accordingly.
13621         (style_set_list): Move to file scope.
13622         (style_show_list): Likewise.
13623         (set_style): Call help_list.
13624         (show_style): Call cmd_show_list.
13625         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13626         Update to use the new macro.
13627
13628 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13629
13630         * ada-lang.c (_initialize_ada_language): Expand the help text
13631         for the "catch exception" command.
13632
13633 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13634
13635         * symtab.c (matching_obj_sections): Initialize obj,
13636         declare it closer to its usage.
13637
13638 2019-01-10  Tom Tromey  <tom@tromey.com>
13639
13640         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13641         (basic_inf_threads_range): Remove.
13642         (inf_threads_range, inf_non_exited_threads_range)
13643         (safe_inf_threads_range): Use next_adapter.
13644
13645 2019-01-10  Keith Seitz  <keiths@redhat.com>
13646
13647         PR gdb/23712
13648         PR symtab/23010
13649         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13650         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13651
13652 2019-01-10  Keith Seitz  <keiths@redhat.com>
13653
13654         PR gdb/23712
13655         PR symtab/23010
13656         * dictionary.c (pending_to_vector): Remove.
13657         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13658         Remove _1 suffix, replacing functions of the same name.  Update
13659         all callers.
13660         (dict_create_hashed, dict_create_hashed_expandable)
13661         (dict_create_linear, dict_create_linear_expandable, dict_free)
13662         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13663         Make functions static.
13664
13665 2019-01-10  Keith Seitz  <keiths@redhat.com>
13666
13667         PR gdb/23712
13668         PR symtab/23010
13669         * dictionary.h (struct dictionary): Replace declaration with
13670         multidictionary.
13671         (dict_create_hashed, dict_create_hashed_expandable)
13672         (dict_create_linear, dict_create_linear_expandable)
13673         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13674         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13675         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13676         taking multidictionary argument.
13677         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13678         * block.h (struct block) <dict>: Change to multidictionary
13679         and rename `multidict'.
13680         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13681         symmisc.c: Update all dictionary references to multidictionary.
13682
13683 2019-01-10  Keith Seitz  <keiths@redhat.com>
13684
13685         PR gdb/23712
13686         PR symtab/23010
13687         * dictionary.c: Include unordered_map.
13688         (pending_to_vector): New function.
13689         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13690         Rewrite the non-"_1" functions to take vector instead
13691         of linked list.
13692         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13693         "new" _1 versions of the same name.
13694         (multidictionary): Define.
13695         (std::hash<enum language): New definition.
13696         (collate_pending_symbols_by_language, mdict_create_hashed)
13697         (mdict_create_hashed_expandable, mdict_create_linear)
13698         (mdict_create_linear_expandable, mdict_free)
13699         (find_language_dictionary, create_new_language_dictionary)
13700         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13701         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13702         (mdict_size, mdict_empty): New functions.
13703         * dictionary.h (mdict_iterator): Define.
13704
13705 2019-01-10  Pedro Alves  <palves@redhat.com>
13706
13707         * breakpoint.c (read_uploaded_action)
13708         (create_tracepoint_from_upload): Adjust to use
13709         gdb::unique_xmalloc_ptr.
13710         * ctf.c (ctf_write_uploaded_tp):
13711         (SET_ARRAY_FIELD): Use emplace_back.
13712         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13713         * tracefile-tfile.c (tfile_write_uploaded_tp):
13714         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13715         gdb::unique_xmalloc_ptr.
13716         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13717         at_string, cond_string, cmd_strings>: Replace char pointers
13718         with gdb::unique_xmalloc_ptr.
13719
13720 2019-01-10  Pedro Alves  <palves@redhat.com>
13721
13722         * solib-target.c (library_list_start_library): Don't xstrdup name.
13723
13724 2019-01-10  Pedro Alves  <palves@redhat.com>
13725
13726         * mdebugread.c (parse_partial_symbols): Use
13727         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13728
13729 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13730
13731         * linux-fork.c (scoped_switch_fork_info)
13732         <~scoped_switch_fork_info>: Fix incorrect variable name.
13733
13734 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13735
13736         * linux-fork.c (scoped_switch_fork_info)
13737         <scoped_switch_fork_info>: Make explicit.
13738         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13739
13740 2019-01-10  Tom Tromey  <tom@tromey.com>
13741
13742         * objfiles.h (objfile::reset_psymtabs): Update.
13743         * objfiles.c (objfile::objfile): Update.
13744         * psymtab.h (psymtab_storage::obstack): Update.
13745         (psymtab_storage::m_obstack): Use gdb::optional.
13746         (class psymtab_storage): Update comment.  Remove objfile
13747         parameter.
13748         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13749
13750 2019-01-10  Tom Tromey  <tom@tromey.com>
13751
13752         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13753         <free_psymtabs>: Now private.
13754         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13755         (allocate_psymtab): Use new method.
13756
13757 2019-01-10  Tom Tromey  <tom@tromey.com>
13758
13759         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13760         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13761         * mdebugread.c (parse_partial_symbols): Use
13762         allocate_dependencies.
13763         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13764         allocate_dependencies.
13765         (process_psymtab_comp_unit_reader)
13766         (build_type_psymtab_dependencies): Likewise.
13767         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13768
13769 2019-01-10  Tom Tromey  <tom@tromey.com>
13770
13771         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13772         PSYMBOL_SET_LANGUAGE.
13773         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13774
13775 2019-01-10  Tom Tromey  <tom@tromey.com>
13776
13777         * psymtab.h (psymtab_storage::obstack): New method.
13778         <m_obstack>: Rename from obstack; now private.
13779         * psymtab.c (psymtab_storage): Update.
13780         * dwarf2read.c (create_addrmap_from_index)
13781         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13782         Update.
13783
13784 2019-01-10  Tom Tromey  <tom@tromey.com>
13785
13786         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13787         * objfiles.h (objfile::reset_psymtabs): New method.
13788
13789 2019-01-10  Tom Tromey  <tom@tromey.com>
13790
13791         * symmisc.c (print_symbol_bcache_statistics): Update.
13792         (print_objfile_statistics): Update.
13793         * symfile.c (reread_symbols): Update.
13794         * psymtab.h (class psymtab_storage): New.
13795         * psymtab.c (psymtab_storage): New constructor.
13796         (~psymtab_storage): New destructor.
13797         (require_partial_symbols): Update.
13798         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13799         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13800         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13801         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13802         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13803         (start_psymtab_common, end_psymtab_common)
13804         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13805         (allocate_psymtab): Update.
13806         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13807         Update.
13808         (dump_psymtab_addrmap, maintenance_print_psymbols)
13809         (maintenance_check_psymtabs): Update.
13810         (class objfile_psymtabs): Move to objfiles.h.
13811         * psympriv.h (discard_psymtab): Now inline.
13812         (psymtab_discarder::psymtab_discarder): Update.
13813         (psymtab_discarder::~psymtab_discarder): Update.
13814         (ALL_OBJFILE_PSYMTABS): Rewrite.
13815         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13816         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13817         Remove fields.
13818         <partial_symtabs>: New field.
13819         (class objfile_psymtabs): Move from psymtab.h.  Update.
13820         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13821         psymbol_cache.
13822         (objfile::~objfile): Don't destroy psymbol_cache.
13823         * mdebugread.c (parse_partial_symbols): Update.
13824         * dwarf2read.c (create_addrmap_from_index)
13825         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13826         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13827         (add_partial_subprogram, dwarf2_ranges_read): Update.
13828         * dwarf-index-write.c (write_address_map)
13829         (write_one_signatured_type, recursively_write_psymbols)
13830         (class debug_names, class debug_names, write_psymtabs_to_index):
13831         Update.
13832
13833 2019-01-10  Tom Tromey  <tom@tromey.com>
13834
13835         * symtab.h (SYMBOL_SET_NAMES): Update.
13836         (symbol_set_names): Update.
13837         (MSYMBOL_SET_NAMES): Update.
13838         * symtab.c (symbol_set_names): Change argument to be an
13839         objfile_per_bfd_storage.
13840         * psymtab.c (add_psymbol_to_bcache): Update.
13841         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13842
13843 2019-01-10  Tom Tromey  <tom@tromey.com>
13844
13845         * symtab.c (create_demangled_names_hash): Change argument to be an
13846         objfile_per_bfd_storage.
13847         (symbol_set_names): Update.
13848
13849 2019-01-10  Tom Tromey  <tom@tromey.com>
13850
13851         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13852         init_psymbol_list.
13853         * psymtab.c (init_psymbol_list): Do nothing if already called.
13854         * psympriv.h (init_psymbol_list): Add comment.
13855         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13856         init_psymbol_list.
13857         * dbxread.c (dbx_symfile_read): Unconditionally call
13858         init_psymbol_list.
13859
13860 2019-01-10  Tom Tromey  <tom@tromey.com>
13861
13862         * xcoffread.c (scan_xcoff_symtab): Update.
13863         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13864         "where".
13865         * mdebugread.c (parse_partial_symbols)
13866         (handle_psymbol_enumerators): Update.
13867         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13868         * dbxread.c (read_dbx_symtab): Update.
13869         * psympriv.h (psymbol_placement): New enum.
13870         (add_psymbol_to_list): Update.
13871
13872 2019-01-10  Tom Tromey  <tom@tromey.com>
13873
13874         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13875         static_psymbols parameters.
13876         (scan_xcoff_symtab): Update.
13877         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13878         static_psymbols parameters.
13879         * psympriv.h (start_psymtab_common): Update.
13880         * mdebugread.c (parse_partial_symbols): Update.
13881         * dwarf2read.c (create_partial_symtab): Update.
13882         * dbxread.c (read_dbx_symtab): Update.
13883         (start_psymtab): Remove global_psymbols and static_psymbols
13884         parameters.
13885
13886 2019-01-10  Tom Tromey  <tom@tromey.com>
13887
13888         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13889         * psymtab.c (allocate_psymtab): Add comment.
13890         * psympriv.h (allocate_psymtab): Add comment.
13891         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13892         initializations.
13893         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13894
13895 2019-01-10  Tom Tromey  <tom@tromey.com>
13896
13897         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13898         Don't declare.
13899         * mipsread.c: Include mdebugread.h.
13900         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13901         Declare.
13902         * elfread.c: Include mdebugread.h.
13903
13904 2019-01-09  Tom Tromey  <tom@tromey.com>
13905
13906         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13907         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13908         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13909         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13910         (psym_lookup_symbol, psym_find_last_source_symtab)
13911         (psym_forget_cached_source_info, psym_print_stats)
13912         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13913         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13914         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13915         (psym_find_compunit_symtab_by_address)
13916         (maintenance_print_psymbols, maintenance_info_psymtabs)
13917         (maintenance_check_psymtabs): Use ranged for.
13918         * psymtab.h (class objfile_psymtabs): New.
13919         (require_partial_symbols): Return objfile_psymtabs.
13920         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13921
13922 2019-01-09  Tom Tromey  <tom@tromey.com>
13923
13924         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13925         (find_pc_mapped_section, list_overlays_command)
13926         (map_overlay_command, unmap_overlay_command)
13927         (simple_overlay_update): Use all_objfiles.
13928         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13929         * printcmd.c (info_symbol_command): Use all_objfiles.
13930         * objfiles.h (ALL_OBJSECTIONS): Remove.
13931         * maint.c (maintenance_translate_address): Use all_objfiles.
13932         * gcore.c (gcore_create_callback): Use all_objfiles.
13933         (objfile_find_memory_regions): Likewise.
13934
13935 2019-01-09  Tom Tromey  <tom@tromey.com>
13936
13937         * symtab.c (find_line_symtab, info_sources_command)
13938         (make_source_files_completion_list): Use objfile_compunits.
13939         * source.c (select_source_symtab): Use objfile_compunits.
13940         * objfiles.h (struct objfile): Update comment.
13941         (ALL_OBJFILES): Remove.
13942         (ALL_FILETABS): Remove.
13943         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13944         objfile_compunits.
13945
13946 2019-01-09  Tom Tromey  <tom@tromey.com>
13947
13948         * symmisc.c (print_objfile_statistics, dump_objfile)
13949         (maintenance_print_symbols): Use compunit_filetabs.
13950         * source.c (forget_cached_source_info_for_objfile): Use
13951         compunit_filetabs.
13952         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13953         (ALL_FILETABS): Use compunit_filetabs.
13954         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13955         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13956
13957 2019-01-09  Tom Tromey  <tom@tromey.com>
13958
13959         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13960         (compunit_filetabs): New.
13961         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13962         compunit_filetabs.
13963         (info_sources_command, make_source_files_completion_list): Remove
13964         declaration.
13965         * symmisc.c (print_objfile_statistics, dump_objfile)
13966         (maintenance_print_symbols): Remove declaration.
13967         (maintenance_info_symtabs): Use compunit_filetabs.
13968         (maintenance_info_line_tables): Likewise.
13969         * source.c (select_source_symtab): Change local variable name.
13970         (forget_cached_source_info_for_objfile): Remove declaration.
13971         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13972         * objfiles.c (objfile_relocate1): Remove declaration.
13973         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13974         declaration.
13975         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13976         * coffread.c (coff_symtab_read): Remove declaration.
13977         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13978         compunit_filetabs.
13979
13980 2019-01-09  Tom Tromey  <tom@tromey.com>
13981
13982         * symtab.c (lookup_objfile_from_block)
13983         (find_pc_sect_compunit_symtab, search_symbols)
13984         (default_collect_symbol_completion_matches_break_on): Use
13985         objfile_compunits.
13986         * objfiles.h (ALL_COMPUNITS): Remove.
13987         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13988         * cp-support.c (add_symbol_overload_list_qualified): Use
13989         objfile_compunits.
13990         * ada-lang.c (ada_collect_symbol_completion_matches)
13991         (ada_add_global_exceptions): Use objfile_compunits.
13992
13993 2019-01-09  Tom Tromey  <tom@tromey.com>
13994
13995         * source.c (select_source_symtab)
13996         (forget_cached_source_info_for_objfile): Remove declaration.
13997         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13998         declaration.
13999         * maint.c (count_symtabs_and_blocks): Remove declaration.
14000         * cp-support.c (add_symbol_overload_list_qualified): Remove
14001         declaration.
14002         * coffread.c (coff_symtab_read): Remove declaration.
14003         * symtab.c (lookup_symbol_in_objfile_symtabs)
14004         (basic_lookup_transparent_type_1): Use objfile_compunits.
14005         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14006         (info_sources_command, search_symbols)
14007         (default_collect_symbol_completion_matches_break_on)
14008         (make_source_files_completion_list): Remove declaration.
14009         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14010         (ada_collect_symbol_completion_matches)
14011         (ada_add_global_exceptions): Remove declaration.
14012         * linespec.c (iterate_over_all_matching_symtabs): Use
14013         objfile_compunits.
14014         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14015         (class objfile_compunits): New.
14016         (ALL_COMPUNITS): Use objfile_compunits.
14017         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14018         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14019         objfile_compunits.
14020         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14021
14022 2019-01-09  Tom Tromey  <tom@tromey.com>
14023
14024         * symtab.c (search_symbols)
14025         (default_collect_symbol_completion_matches_break_on): Use
14026         objfile_msymbols.
14027         * ada-lang.c (ada_lookup_simple_minsym)
14028         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14029         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14030         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14031         objfile_msymbols.
14032         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14033         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14034         * objc-lang.c (find_methods): Use objfile_msymbols.
14035         (info_selectors_command, info_classes_command): Likewise.
14036         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14037         * objfiles.h (class objfile_msymbols): New.
14038         (ALL_OBJFILE_MSYMBOLS): Remove.
14039         (ALL_MSYMBOLS): Remove.
14040
14041 2019-01-09  Tom Tromey  <tom@tromey.com>
14042
14043         * common/next-iterator.h (next_adapter): Add Iterator template
14044         parameter.
14045         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14046         (class all_objfiles_safe): New.
14047         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14048         * objfiles.c (put_objfile_before): Update comment.
14049         (add_separate_debug_objfile): Likewise.
14050         (free_all_objfiles): Use all_objfiles_safe.
14051         (objfile_purge_solibs): Likewise.
14052
14053 2019-01-09  Tom Tromey  <tom@tromey.com>
14054
14055         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14056         (expand_symtab_containing_pc, lookup_static_symbol)
14057         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14058         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14059         all_objfiles.
14060         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14061         * breakpoint.c (create_overlay_event_breakpoint)
14062         (create_longjmp_master_breakpoint)
14063         (create_std_terminate_master_breakpoint)
14064         (create_exception_master_breakpoint): Use all_objfiles.
14065         * linux-thread-db.c (try_thread_db_load_from_pdir)
14066         (has_libpthread): Use all_objfiles.
14067         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14068         * linespec.c (iterate_over_all_matching_symtabs)
14069         (search_minsyms_for_name): Use all_objfiles.
14070         * maint.c (maintenance_info_sections): Use all_objfiles.
14071         * main.c (captured_main_1): Use all_objfiles.
14072         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14073         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14074         * guile/scm-pretty-print.c
14075         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14076         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14077         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14078         (maintenance_print_msymbols): Use all_objfiles.
14079         * source.c (select_source_symtab): Use all_objfiles.
14080         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14081         * symfile.c (remove_symbol_file_command)
14082         (expand_symtabs_matching, map_symbol_filenames): Use
14083         all_objfiles.
14084         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14085         all_objfiles.
14086         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14087         * objc-lang.c (find_methods): Use all_objfiles.
14088         * objfiles.c (have_partial_symbols, have_full_symbols)
14089         (have_minimal_symbols, qsort_cmp)
14090         (default_iterate_over_objfiles_in_search_order): Use
14091         all_objfiles.
14092         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14093         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14094         (maintenance_check_psymtabs): Use all_objfiles.
14095         (ALL_PSYMTABS): Remove.
14096         * compile/compile-object-run.c (do_module_cleanup): Use
14097         all_objfiles.
14098         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14099         * cp-support.c (add_symbol_overload_list_qualified): Use
14100         all_objfiles.
14101         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14102         Use all_objfiles.
14103         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14104         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14105         all_objfiles.
14106         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14107         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14108         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14109         Uses all_objfiles.
14110         * solib.c (solib_read_symbols): Use all_objfiles
14111
14112 2019-01-09  Tom Tromey  <tom@tromey.com>
14113
14114         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14115         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14116         all_objfiles.
14117         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14118         * symmisc.c (print_symbol_bcache_statistics)
14119         (print_objfile_statistics, maintenance_print_objfiles)
14120         (maintenance_info_symtabs, maintenance_check_symtabs)
14121         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14122         all_objfiles.
14123         * source.c (forget_cached_source_info): Use all_objfiles.
14124         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14125         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14126         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14127         * objfiles.c (update_section_map): Use all_objfiles.
14128         (shared_objfile_contains_address_p): Likewise.
14129         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14130         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14131
14132 2019-01-09  Tom Tromey  <tom@tromey.com>
14133
14134         * common/next-iterator.h: New file.
14135         * objfiles.h (class all_objfiles): New.
14136         (struct objfile_iterator): New.
14137
14138 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14139
14140         * NEWS: Move the description of the changed "frame", "select-frame",
14141          and "info frame" commands to the Changed commands section.
14142
14143 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14144
14145         * gdbtypes.c (check_stub_method_group): Remove handling of old
14146         mangling schemes.
14147         * linespec.c (find_methods): Likewise.
14148         * stabsread.c (read_member_functions): Likewise.
14149         * valops.c (search_struct_method): Likewise.
14150         (value_struct_elt_for_reference): Likewise.
14151         * NEWS: Mention this change.
14152
14153 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14154
14155         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14156         print_source_lines.
14157         * source.c (print_source_lines_base): Update line number check.
14158         (print_source_lines): New function.
14159         (source_lines_range::source_lines_range): New function.
14160         * source.h (class source_lines_range): New class.
14161         (print_source_lines): New declaration.
14162
14163 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14164
14165         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14166
14167 2019-01-08  Tom Tromey  <tom@tromey.com>
14168             Simon Marchi  <simon.marchi@ericsson.com>
14169
14170         PR gdb/24060
14171         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14172         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14173         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14174         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14175         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14176         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14177
14178 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14179
14180         * source.c (select_source_symtab): Move header comment to
14181         declaration in source.h.
14182         (forget_cached_source_info_for_objfile): Likewise.
14183         (forget_cached_source_info): Likewise.
14184         (identify_source_line): Likewise.
14185         * source.h (identify_source_line): Move declaration from symtab.h
14186         and add comment from source.c
14187         (print_source_lines): Likewise.
14188         (forget_cached_source_info_for_objfile): Likewise.
14189         (forget_cached_source_info): Likewise.
14190         (select_source_symtab): Likewise.
14191         (enum print_source_lines_flag): Move definition from symtab.h.
14192         * symtab.h (identify_source_line): Move declaration to source.h.
14193         (print_source_lines): Likewise.
14194         (forget_cached_source_info_for_objfile): Likewise.
14195         (forget_cached_source_info): Likewise.
14196         (select_source_symtab): Likewise.
14197         (enum print_source_lines_flag): Move definition to source.h.
14198         * tui/tui-hooks.c: Add 'source.h' include.
14199
14200 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14201
14202         * source.c (print_source_lines_base): Handle requests to print
14203         reverse line number sequences, and guard against empty lines
14204         string.
14205
14206 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14207
14208         * source.c (print_source_lines_base): Fix skip of '\r' if next
14209         character is '\n'.
14210
14211 2019-01-06  Tom Tromey  <tom@tromey.com>
14212
14213         * c-exp.y (struct c_parse_state) <macro_original_text,
14214         expansion_obstack>: New member.
14215         (macro_original_text, expansion_obstack): Remove globals.
14216         (scan_macro_expansion, scanning_macro_expansion)
14217         (finished_macro_expansion): Update.
14218         (scan_macro_cleanup): Remove.
14219         (yylex, c_parse): Update.
14220
14221 2019-01-06  Tom Tromey  <tom@tromey.com>
14222
14223         * c-exp.y (struct c_parse_state) <strings>: New member.
14224         (operator_stoken): Update.
14225
14226 2019-01-06  Tom Tromey  <tom@tromey.com>
14227
14228         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14229         (union type_stack_elt) <typelist_val>: Now a pointer to
14230         std::vector.
14231         (type_stack_cleanup): Don't declare.
14232         (push_typelist): Update.
14233         * parse.c (pop_typelist): Return a std::vector.
14234         (push_typelist): Take a std::vector.
14235         (follow_types): Update.  Do not free args.
14236         (type_stack_cleanup): Remove.
14237         * c-exp.y (struct c_parse_state): New.
14238         (cpstate): New global.
14239         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14240         (nonempty_typelist): Update.
14241         (func_mod): Create a new vector.
14242         (c_parse): Create a c_parse_state.
14243         (check_parameter_typelist): Do not delete params.
14244         (function_method): Update.  Do not delete type_list.
14245
14246 2019-01-06  Tom Tromey  <tom@tromey.com>
14247
14248         PR gdb/28155:
14249         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14250         check_typedef.
14251         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14252         (print_return_value): Likewise.
14253
14254 2019-01-05  Tom Tromey  <tom@tromey.com>
14255
14256         * contrib/cleanup_check.py: Remove.
14257         * contrib/gcc-with-excheck: Remove.
14258         * contrib/exsummary.py: Remove.
14259         * contrib/excheck.py: Remove.
14260
14261 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14262
14263         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14264         NULL. Initialize tpprev to NULL instead of assigning it
14265         to NULL on the next statement.
14266         * windows-nat.c (windows_delete_thread): Remove check for
14267         main_thread_id before printing thread exit notifications.
14268         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14269         Remove thread ID check against main_thread_id.
14270         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14271         windows_delete_thread.
14272         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14273
14274 2019-01-04  Tom Tromey  <tom@tromey.com>
14275
14276         * compile/compile.c (_initialize_compile): Use upper case for
14277         metasyntactic variables.
14278         * symmisc.c (_initialize_symmisc): Use upper case for
14279         metasyntactic variables.
14280         * psymtab.c (_initialize_psymtab): Use upper case for
14281         metasyntactic variables.
14282         * demangle.c (demangle_command): Use upper case for metasyntactic
14283         variables.
14284         (_initialize_demangler): Likewise.
14285         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14286         variables.
14287
14288 2019-01-03  Tom Tromey  <tom@tromey.com>
14289
14290         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14291
14292 2019-01-03  Tom Tromey  <tom@tromey.com>
14293
14294         * python/py-symtab.c (salpy_str): Update.
14295         (struct salpy_sal_object) <symtab>: Now a PyObject.
14296         (salpy_dealloc): Update.
14297         (del_objfile_sal): Use gdbpy_ref.
14298
14299 2019-01-03  Tom Tromey  <tom@tromey.com>
14300
14301         * python/py-type.c (convert_field): Use new_reference.  Return
14302         gdbpy_ref.
14303         (make_fielditem): Return gdbpy_ref.
14304         (typy_fields): Update.
14305         (typy_getitem): Update.
14306         (field_name): Return gdbpy_ref.  Use new_reference.
14307         (typy_iterator_iternext): Update.
14308
14309 2019-01-03  Tom Tromey  <tom@tromey.com>
14310
14311         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14312
14313 2019-01-03  Tom Tromey  <tom@tromey.com>
14314
14315         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14316         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14317         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14318         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14319         (pspy_set_type_printers): Likewise.
14320         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14321         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14322         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14323         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14324         (objfpy_set_type_printers): Likewise.
14325
14326 2019-01-03  Tom Tromey  <tom@tromey.com>
14327
14328         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14329         (gdbpy_print_stack): Use gdbpy_err_fetch.
14330         * python/python-internal.h (class gdbpy_err_fetch): New class.
14331         (class gdbpy_enter) <m_error_type, m_error_value,
14332         m_error_traceback>: Remove.
14333         <m_error>: New member.
14334         (gdbpy_exception_to_string): Don't declare.
14335         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14336         * python/py-value.c (convert_value_from_python): Use
14337         gdbpy_err_fetch.
14338         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14339         gdbpy_exception_to_string.
14340         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14341         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14342         gdbpy_err_fetch.
14343
14344 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14345
14346         * linux-nat.c (delete_lwp_cleanup): Delete.
14347         (struct lwp_deleter): New struct.
14348         (lwp_info_up): New typedef.
14349         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14350         lwp_info_up.
14351
14352 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14353
14354         * linux-fork.c (class scoped_switch_fork_info): New class.
14355         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14356
14357 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14358
14359         * valops.c (find_overload_match): Remove use of null_cleanup, and
14360         calls to do_cleanups.
14361
14362 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14363
14364         * compile/compile-cplus-types.c
14365         (compile_cplus_instance::decl_name): Handle changes to
14366         cp_func_name.
14367         * cp-support.c (cp_func_name): Update header comment, update
14368         return type.
14369         * cp-support.h (cp_func_name): Update return type in declaration.
14370         * valops.c (find_overload_match): Move temp_func local to top
14371         level of function and change its type.  Use temp_func to hold and
14372         delete temporary string obtained from cp_func_name.
14373
14374 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14375
14376         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14377         gdb::char_vector, remove cleanup, and update uses of `msg`.
14378
14379 2019-01-03  Jim Wilson  <jimw@sifive.com>
14380
14381         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14382
14383 2019-01-02  Tom Tromey  <tom@tromey.com>
14384
14385         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14386         (tdesc_parse_xml): Remove cleanups.
14387         * target-descriptions.h (make_cleanup_free_target_description):
14388         Don't declare.
14389         (target_desc_deleter): New struct.
14390         (target_desc_up): New typedef.
14391         * target-descriptions.c (target_desc_deleter::operator()): Rename
14392         from free_target_description.
14393         (make_cleanup_free_target_description): Remove.
14394
14395 2019-01-02  Tom Tromey  <tom@tromey.com>
14396
14397         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14398         constructor, destructor.
14399         (linespec_parser): Remove typedef.
14400         (~linespec_parser): Rename from linespec_parser_delete.
14401         (linespec_lex_to_end, linespec_complete_label)
14402         (linespec_complete): Update.
14403         (decode_line_full): Remove cleanups.
14404         (decode_line_1): Update.
14405
14406 2019-01-02  Tom Tromey  <tom@tromey.com>
14407
14408         * python/python-internal.h (inferior_to_inferior_object): Change
14409         return type.
14410         * python/py-exitedevent.c (create_exited_event_object): Update.
14411         * python/py-inferior.c (inferior_to_inferior_object): Return
14412         gdbpy_ref.
14413         (python_new_inferior, python_inferior_deleted)
14414         (thread_to_thread_object, delete_thread_object)
14415         (build_inferior_list, gdbpy_selected_inferior): Update.
14416         * python/py-infthread.c (create_thread_object): Update.  Also fail
14417         if inferior_to_inferior_object fails.
14418
14419 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14420
14421         * inferior.h (class inferior) <displaced_step_state>: New field.
14422         * infrun.h (struct displaced_step_state): Move here from
14423         infrun.c.  Initialize fields, add constructor.
14424         <inf>: Remove field.
14425         <reset>: New method.
14426         * infrun.c (struct displaced_step_inferior_state): Move to
14427         infrun.h.
14428         (displaced_step_inferior_states): Remove.
14429         (get_displaced_stepping_state): Adust.
14430         (displaced_step_in_progress_any_inferior): Adjust.
14431         (displaced_step_in_progress_thread): Adjust.
14432         (displaced_step_in_progress): Adjust.
14433         (add_displaced_stepping_state): Remove.
14434         (get_displaced_step_closure_by_addr): Adjust.
14435         (remove_displaced_stepping_state): Remove.
14436         (infrun_inferior_exit): Call displaced_step_state.reset.
14437         (use_displaced_stepping): Don't check for NULL.
14438         (displaced_step_prepare_throw): Call
14439         get_displaced_stepping_state.
14440         (displaced_step_fixup): Don't check for NULL.
14441         (prepare_for_detach): Don't check for NULL.
14442
14443 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14444
14445         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14446          in case of call that did not complete.
14447
14448 2019-01-02  Andrey Utkin  <autkin@undo.io>
14449
14450         * symfile.c (find_separate_debug_file): Fix search of debug files for
14451         remote debuggee.
14452
14453 2019-01-02  Tom Tromey  <tom@tromey.com>
14454
14455         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14456         indentation.
14457         * python/py-frame.c (frapy_older): Remove cast.
14458         (frapy_newer): Likewise.
14459         * python/py-breakpoint.c (local_setattro): Remove cast.
14460         * python/py-arch.c (archpy_name): Remove local variable.
14461         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14462
14463 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14464
14465         * unittests/basic_string_view/element_access/char/empty.cc:
14466         Fix year range in copyright header.
14467
14468 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14469
14470         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14471         Delete.
14472         <operator==>: Update with for removed field.
14473         <hash>: Likewise.
14474         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14475         <isa_features>: ...this.
14476         <abi_features>: New field.
14477         (riscv_isa_flen): Update comment.
14478         (riscv_abi_xlen): New declaration.
14479         (riscv_abi_flen): New declaration.
14480         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14481         isa_features.
14482         (riscv_abi_xlen): New function.
14483         (riscv_isa_flen): Update to get answer from isa_features.
14484         (riscv_abi_flen): New function.
14485         (riscv_has_fp_abi): Update to get answer from abi_features.
14486         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14487         xlen and flen.
14488         (riscv_call_info) <xlen, flen>: Update comment.
14489         (riscv_call_arg_struct): Remove invalid assertions
14490         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14491         is removed.
14492         (riscv_gdbarch_init): Gather isa features and abi features
14493         separately, ensure both match on the gdbarch when reusing an old
14494         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14495         a target with 64-bit float hardware.
14496
14497 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14498
14499         * source.c (search_command_helper): Stop reverse search
14500         when line 1 has been searched.
14501
14502 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14503
14504         * record-full.c (record_full_base_target::close): Rewrite
14505         record_full_core_buf_list free logic.
14506
14507 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14508
14509         * break-catch-syscall.c (print_one_catch_syscall): xfree
14510         the last text.
14511
14512 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14513
14514         * top.c (print_gdb_version): Update Copyright year in version
14515         message.
14516
14517 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14518
14519         Update copyright year range in all GDB files.
14520
14521 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14522
14523         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14524
14525 For older changes see ChangeLog-2018.
14526 \f
14527 Local Variables:
14528 mode: change-log
14529 left-margin: 8
14530 fill-column: 74
14531 version-control: never
14532 coding: utf-8
14533 End:
14534