gdb/ChangeLog

   1 2019-06-13  Pedro Alves  <palves@redhat.com>
   2
   3         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
   4         (COMMON_SFILES): Add maint-test-settings.c.
   5         * cli/cli-decode.c (boolean_enums): New global, factored out from
   6         ...
   7         (add_setshow_boolean_cmd): ... here.
   8         * cli/cli-decode.h (boolean_enums): Declare.
   9         * cli/cli-option.c: New file.
  10         * cli/cli-option.h: New file.
  11         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
  12         factored out from ...
  13         (parse_cli_boolean_value(const char *)): ... this.
  14         (is_unlimited_literal): Change parameter type to pointer to
  15         pointer.  Adjust and advance ARG pointer.
  16         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
  17         (parse_cli_var_enum): New, factored out from ...
  18         (do_set_command): ... this.  Adjust.
  19         * cli/cli-setshow.h (parse_cli_boolean_value)
  20         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
  21         (parse_cli_var_enum): Declare.
  22         * cli/cli-utils.c: Include "cli/cli-option.h".
  23         (get_ulongest): New.
  24         * cli/cli-utils.h (get_ulongest): Declare.
  25         (check_for_argument): New overloads.
  26         * maint-test-options.c: New file.
  27
  28 2019-06-13  Pedro Alves  <palves@redhat.com>
  29
  30         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
  31         parse a range if "-" is at the end of the string.
  32
  33 2019-06-13  Pedro Alves  <palves@redhat.com>
  34
  35         * cli/cli-setshow.c (parse_auto_binary_operation)
  36         (parse_cli_boolean_value): Don't allow "o".
  37
  38 2019-06-13  Pedro Alves  <palves@redhat.com>
  39
  40         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
  41         * NEWS: Mention maint test-settings KIND.
  42         * maint-test-settings.c: New file.
  43
  44 2019-06-13  Pedro Alves  <palves@redhat.com>
  45
  46         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
  47         completer.
  48         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
  49         "set" completers.
  50
  51 2019-06-13  Pedro Alves  <palves@redhat.com>
  52
  53         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
  54         after item.
  55
  56 2019-06-13  Pedro Alves  <palves@redhat.com>
  57
  58         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
  59
  60 2019-06-13  Pedro Alves <palves@redhat.com>
  61
  62         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
  63         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
  64         call.
  65         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
  66         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
  67         calls.
  68         (check_for_argument): Skip spaces after argument.
  69
  70 2019-06-13  Pedro Alves  <palves@redhat.com>
  71
  72         * thread.c (thread_apply_command): Adjust TID parsing.
  73         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
  74         detected before end of string.
  75         (tid_is_in_list): Error out if LIST is invalid.
  76
  77 2019-06-13  Pedro Alves  <palves@redhat.com>
  78
  79         * completer.c (complete_line_internal_1): Rewind completion word
  80         point.
  81         (completion_tracker::advance_custom_word_point_by): Change
  82         parameter type to int.
  83         * completer.h (completion_tracker::advance_custom_word_point_by):
  84         Likewise.
  85
  86 2019-06-13  Pedro Alves  <palves@redhat.com>
  87
  88         * completer.c (advance_to_completion_word): Handle delimiters.
  89
  90 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
  91
  92         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
  93
  94 2019-06-11  Tom Tromey  <tom@tromey.com>
  95
  96         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
  97         (xmalloc_failed): Move to alloc.c.
  98         * alloc.c: New file.
  99         * Makefile.in (COMMON_SFILES): Add alloc.c.
 100
 101 2019-06-11  Tom Tromey  <tom@tromey.com>
 102
 103         * nat/linux-waitpid.c: Don't include server.h.
 104         (linux_debug): Remove.
 105         (my_waitpid): Update.
 106
 107 2019-06-11  Tom Tromey  <tromey@adacore.com>
 108
 109         * infcall.c (_initialize_infcall): Remove trailing newline from
 110         help.
 111         * user-regs.c (_initialize_user_regs): Remove trailing newline
 112         from help.
 113         * typeprint.c (_initialize_typeprint): Remove trailing newline
 114         from help.
 115         * reverse.c (_initialize_reverse): Remove trailing newlines from
 116         help.
 117         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 118         from help.
 119         * language.c (add_set_language_command): Remove trailing newline
 120         from help.
 121         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 122         help.
 123         * disasm.c (_initialize_disasm): Remove trailing newline from
 124         help.
 125         * top.c (init_main): Remove trailing newline from help.
 126         * interps.c (_initialize_interpreter): Remove trailing newline
 127         from help.
 128         * btrace.c (_initialize_btrace): Remove trailing newlines from
 129         help.
 130         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 131         from help.
 132         * python/python.c (_initialize_python): Remove trailing newline
 133         from help.
 134         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 135         help.
 136         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 137         from help.  Reformat some text.
 138         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 139         from help.
 140         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 141         newline from help.
 142
 143 2019-06-11  Tom Tromey  <tromey@adacore.com>
 144
 145         * darwin-nat.c (darwin_decode_exception_message)
 146         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 147
 148 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 149
 150         * valops.c (value_slice): Check for not allocated or not
 151         associated values.
 152
 153 2019-06-10  Tom de Vries  <tdevries@suse.de>
 154
 155         PR gdb/24618
 156         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 157         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 158         invalid.
 159
 160 2019-06-10  Tom de Vries  <tdevries@suse.de>
 161
 162         PR gdb/24611
 163         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 164         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 165
 166 2019-06-10  Tom de Vries  <tdevries@suse.de>
 167
 168         PR symtab/24545
 169         * symtab.c (struct demangled_name_entry): Add language field.
 170         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 171         static minimal symbol".  Set and use language field.
 172
 173 2019-06-10  Tom Tromey  <tromey@adacore.com>
 174
 175         * ada-lang.c (_initialize_ada_language): Update help text.
 176
 177 2019-06-10  Tom Tromey  <tromey@adacore.com>
 178
 179         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 180         with a newline.
 181         * guile/guile.c (handle_boot_error): Don't end warning with a
 182         newline.
 183         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 184         warning with a newline.
 185         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 186         newline.
 187         (s12z_frame_cache): Likewise.
 188         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 189         a newline.
 190         * solib-svr4.c (disable_probes_interface): Don't end warning with
 191         a newline.
 192         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 193         newline.
 194         * python/python.c (do_finish_initialization): Don't end warning
 195         with a newline.
 196
 197 2019-06-10  Tom Tromey  <tom@tromey.com>
 198
 199         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 200         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 201         gdbpy_enter.
 202
 203 2019-06-10  Tom Tromey  <tromey@adacore.com>
 204
 205         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 206         data.
 207         (elf_new_init): Don't call stabsread_new_init.
 208         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 209         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 210         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 211
 212 2019-06-10  Tom de Vries  <tdevries@suse.de>
 213
 214         PR symtab/16264
 215         PR symtab/24517
 216         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 217
 218 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 219
 220         * source.c (find_and_open_source): Also rewrite relative file
 221         names.
 222
 223 2019-04-26  Amos Bird  <amosbird@gmail.com>
 224
 225         * annotate.c (annotate_thread_exited): Add "thread-exited"
 226         annotation.
 227
 228 2019-06-06  Tom Tromey  <tromey@adacore.com>
 229
 230         * maint.h (class scoped_command_stats): Use
 231         DISABLE_COPY_AND_ASSIGN.
 232         <print_time>: New method.
 233         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 234         print_time.
 235         (scoped_command_stats::print_time): New method.
 236
 237 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 238
 239         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 240         instructions of lengths 6 or 8 bytes.
 241
 242 2019-06-04  Pedro Alves  <palves@redhat.com>
 243
 244         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 245
 246         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 247         * breakpoint.c (condition_completer): Likewise.
 248         * cli/cli-dump.c (scan_expression): Likewise.
 249         * common/filestuff.c (mkdir_recursive): Likewise.
 250         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 251         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 252         (gdb_abspath): Likewise.
 253         * compile/compile-cplus-types.c
 254         (compile_cplus_instance::decl_name): Likewise.
 255         * completer.c (complete_explicit_location):
 256         (signal_completer, reg_or_group_completer_1): Likewise.
 257         * cp-support.c (cp_remove_params_if_any): Likewise.
 258         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 259         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 260         * infcmd.c (strip_bg_char): Likewise.
 261         * linespec.c (copy_token_string): Likewise.
 262         * mi/mi-main.c (output_cores): Likewise.
 263         * psymtab.c (psymtab_search_name):
 264         * symfile.c (test_set_ext_lang_command): Likewise.
 265         * target.c (target_fileio_read_stralloc): Likewise.
 266         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 267         * value.c (complete_internalvar): Likewise.
 268
 269 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 270
 271         Add objfile property to gdb.Type.
 272         * NEWS: Mention Python API addition.
 273         * python/py-type.c (typy_get_objfile): New method.
 274
 275 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 276
 277         * NEWS: Mention the new set|show style [title|highlight].
 278         Mention changes to "show style", "help" and "apropos".
 279
 280 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 281
 282         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 283         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 284         instead of print_help_for_command.
 285         (print_doc_of_command): New function.
 286         (help_list): Add 'apropos -v word' suggestion.
 287         (print_help_for_command): Style the command name using title style.
 288         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 289         (_initialize_cli_cmds): Describe -v in apropos_command help.
 290
 291 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 292
 293         * cli/cli-style.h (cli_style_option): Add name in constructor,
 294         add m_name class member, add constructor with intensity,
 295         add name class function.
 296         (cli_style_option::add_setshow_commands): Remove name argument.
 297         (highlight_style, title_style): New styles.
 298         * cli/cli-style.c (do_show): New function that shows a style
 299         characteristic styling the style name with itself.
 300         (set_style_name): New function.
 301         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 302         Update all callers according to the changes in cli/cli-style.h.
 303         * utils.h (fputs_highlighted): New function.
 304         * utils.c (fputs_highlighted): Likewise.
 305
 306 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 307
 308         * NEWS: Mention new pipe command and new convenience variables.
 309
 310 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 311
 312         * cli/cli-cmds.c (pipe_command): New function.
 313         (_initialize_cli_cmds): Call add_com for pipe_command.
 314         Define | as an alias for pipe.
 315         (exit_status_set_internal_vars): New function.
 316         (shell_escape): Call exit_status_set_internal_vars.
 317         cli/cli-decode.c (find_command_name_length): Recognize | as
 318         a single character command.
 319
 320 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 321
 322         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 323         top.c (execute_command_to_ui_file): New function, mostly a copy
 324         of execute_command_to_string.
 325         (execute_command_to_string): Implement by calling
 326         execute_command_to_ui_file.
 327
 328 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 329
 330         * top.h (saved_command_line): Remove declaration.
 331         * top.c (previous_saved_command_line, previous_repeat_arguments):
 332         New variables.
 333         (saved_command_line): Make static, define together with other
 334         'repeat variables'.
 335         (dont_repeat): Clear repeat_arguments.
 336         (repeat_previous, get_saved_command_line, save_command_line):
 337         New functions.
 338         (gdb_init): Initialize saved_command_line
 339         and previous_saved_command_line.
 340         * main.c (captured_main_1): Remove saved_command_line initialization.
 341         * event-top.c (handle_line_of_input): Update to use
 342         the new 'repeat' related functions instead of direct access to
 343         saved_command_line.
 344         * command.h (repeat_previous, get_saved_command_line,
 345         save_command_line): New declarations.
 346         (dont_repeat): Add comment.
 347
 348 2019-05-30  Tom Tromey  <tromey@adacore.com>
 349
 350         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 351         Fix comment.
 352         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 353
 354 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 355
 356         PR cli/24587
 357         * completer.c (complete): Initialize variable word.
 358
 359 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 360
 361         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 362         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 363         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 364         'body' is NULL to the outter 'if', protecting the '!is_define'
 365         situation as well.
 366
 367 2019-05-29  Tom Tromey  <tromey@adacore.com>
 368
 369         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 370         (dwarf_unknown): New function.
 371         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 372         (dwarf_type_encoding_name): Use dwarf_unknown.
 373
 374 2019-05-29  Tom Tromey  <tromey@adacore.com>
 375
 376         PR c++/20020:
 377         * cp-valprint.c (cp_print_value_fields): Call
 378         cp_print_static_field inside "try".
 379
 380 2019-05-29  Tom Tromey  <tromey@adacore.com>
 381
 382         * inflow.c (struct terminal_info): Add default operator=.
 383         * configure: Rebuild.
 384         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 385         -Wdeprecated-copy-dtor, -Wredundant-move.
 386
 387 2019-05-29  Tom Tromey  <tromey@adacore.com>
 388
 389         * NEWS: Add entry.
 390         * infcmd.c (print_return_value_1): Handle finish_print
 391         option.
 392         (show_print_finish): New function.
 393         (_initialize_infcmd): Add "set/show print finish" commands.
 394         * valprint.c (user_print_options): Initialize new member.
 395         * valprint.h (struct value_print_options) <finish_print>: New
 396         member.
 397
 398 2019-05-28  Tom Tromey  <tromey@adacore.com>
 399
 400         * ada-lang.c (ada_remove_Xbn_suffix)
 401         (find_old_style_renaming_symbol)
 402         (parse_old_style_renaming): Remove.
 403         (ada_find_renaming_symbol): Don't call
 404         find_old_style_renaming_symbol.
 405         (ada_is_renaming_symbol): Rename from
 406         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 407         bool.  Now static.
 408         (ada_read_var_value): Update and simplify.
 409         * ada-exp.y (write_var_or_type): Remove old code.
 410
 411 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 412
 413         * event-top.c: Remove include comment.
 414         * inflow.c (class scoped_ignore_sigttou): Move from here...
 415         * inflow.h (class scoped_ignore_sigttou): ...to here.
 416         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 417         * top.c:  Remove include comment.
 418
 419 2019-05-27  Tom Tromey  <tom@tromey.com>
 420
 421         * NEWS: Fix typo.
 422
 423 2019-05-22  Tom Tromey  <tromey@adacore.com>
 424
 425         * target.c (target_follow_exec): Constify parameter.
 426         * target-delegates.c: Rebuild.
 427         * remote.c (remote_target::follow_exec): Constify parameter.
 428         * infrun.c (follow_exec): Constify parameter.
 429         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 430         (target_follow_exec): Likewise.
 431
 432 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 433
 434         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 435         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 436
 437 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 438
 439         * NEWS: Add debugredirect and testsuite sections.
 440
 441 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 442
 443         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 444         target descriptions using exclusively floating point register name
 445         aliases.
 446
 447 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 448
 449         PR gdb/18644:
 450         * f-lang.c (build_fortran_types): Handle the case where
 451         gdbarch_floatformat_for_type returns a nullptr.
 452
 453 2019-05-21  Tom de Vries  <tdevries@suse.de>
 454
 455         PR cli/24587
 456         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 457
 458 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 459
 460         PR gdb/18644:
 461         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 462         16-byte floats.
 463         * i386-tdep.c (i386_floatformat_for_type): Use
 464         floatformats_ia64_quad for the 16-byte floating point component
 465         within a fortran 32-byte complex number.
 466
 467 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 468
 469         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 470         delete default constructor.
 471         (find_partial_die): Update to return const struct.
 472         (partial_die_parent_scope): Move variable declaration into scope
 473         of its use and change its type to auto.
 474         (guess_partial_die_structure_name): Likewise.
 475         (partial_die_info::fixup): Likewise.
 476
 477 2019-05-17  Tom Tromey  <tromey@adacore.com>
 478
 479         * source.c (find_and_open_source): Remove cast.
 480
 481 2019-05-17  Tom Tromey  <tromey@adacore.com>
 482
 483         * annotate.c (annotate_source): Make "filename" const.
 484         * annotate.h (annotate_source): Use const.
 485
 486 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 487
 488         * disasm.c (set_disassembler_options): Send errors to stderr.
 489
 490 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 491
 492         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 493         (cli_interp_base::set_logging): Check debug_redirect.
 494         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 495         * cli/cli-logging.c (debug_redirect): Add static variable.
 496         (pop_output_files): Add default param.
 497         (handle_redirections): Print debug setting.
 498         (show_logging_command): Likewise.
 499         (_initialize_cli_logging): Add debugredirect command.
 500         * interps.c (current_interp_set_logging): Add debug_redirect
 501         parameter.
 502         * interps.h (set_logging): Add debug_redirect parameter.
 503         (current_interp_set_logging): Likewise.
 504         * mi/mi-common.h: Likewise.
 505         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 506
 507 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 508             Tom Tromey  <tromey@adacore.com>
 509
 510         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 511         directly.
 512         * cli/cli-interp.h (make_logging_output): Remove declaration.
 513         * cli/cli-logging.c (make_logging_output): Remove function.
 514         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 515         directly.
 516         * ui-file.c (tee_file::tee_file): Remove bools.
 517         (tee_file::~tee_file): Remove deletes.
 518         * ui-file.h (tee_file): Remove bools.
 519
 520 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 521
 522         * mi/mi-cmds.h (mi_cmd_complete): New function.
 523         * mi/mi-main.c (mi_cmd_complete): Likewise.
 524         * mi/mi-cmds.c: Define new MI command -complete.
 525         * NEWS: Mention new -complete command.
 526
 527 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 528
 529         * completer.h (complete): New function.
 530         * completer.c (complete): Likewise.
 531         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 532         function defined in completer.h.
 533
 534 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 535
 536        * MAINTAINERS (Write After Approval): Add myself.
 537
 538 2019-05-17  Tom de Vries  <tdevries@suse.de>
 539
 540         PR gdb/24094
 541         * dwarf2read.c (struct cu_partial_die_info): New struct.
 542         (find_partial_die): Return cu_partial_die_info.
 543         (partial_die_parent_scope, guess_partial_die_structure_name)
 544         (partial_die_info::fixup): Handle new return type of find_partial_die.
 545
 546 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 547
 548         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 549         "std::string", simplifying the algorithm.
 550
 551 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 552
 553         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 554         (stap_static_probe_ops::get_probes): Likewise.
 555
 556 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 557
 558         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 559         '-')" and "else if".
 560         (stap_parse_single_operand): Join checks for
 561         "gdbarch_stap_parse_special_token_p" and
 562         "gdbarch_stap_parse_special_token" in the same "if" statement.
 563         Invert check when verifying for operation on register
 564         displacement.
 565
 566 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 567
 568         * stap-probe.c (stap_get_opcode): Update comment.
 569         (stap_get_expected_argument_type): Likewise.
 570         (handle_stap_probe): Likewise.
 571
 572 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 573
 574         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 575         return type to 'bool'.  Adjust comment.  Use 'bool' when
 576         appropriate.
 577         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 578         * stap-probe.c (stap_parse_argument_1): Likewise.
 579         (stap_is_operator): Likewise.
 580         (stap_is_generic_prefix): Likewise.
 581         (stap_is_register_prefix): Likewise.
 582         (stap_is_register_indirection_prefix): Likewise.
 583         (stap_is_integer_prefix): Likewise.
 584         (stap_generic_check_suffix): Likewise.
 585         (stap_check_integer_suffix): Likewise.
 586         (stap_check_register_suffix): Likewise.
 587         (stap_check_register_indirection_suffix): Likewise.
 588         (stap_parse_register_operand): Likewise.
 589         (stap_parse_single_operand): Likewise.
 590         (stap_parse_argument_1): Likewise.
 591         (stap_probe::get_argument_count): Likewise.
 592         (stap_is_operator): Likewise.
 593
 594 2019-05-16  Tom Tromey  <tromey@adacore.com>
 595
 596         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 597         keyword to foreach.
 598
 599 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 600
 601         * linux-thread-db.c (try_thread_db_load_1): Change return type
 602         to bool.
 603         (try_thread_db_load): Likewise.
 604         (try_thread_db_load_from_pdir_1): Likewise.
 605         (try_thread_db_load_from_pdir): Likewise.
 606         (try_thread_db_load_from_sdir): Likewise.
 607         (try_thread_db_load_from_dir): Likewise.
 608         (thread_db_load_search): Likewise.
 609         (has_libpthread): Likewise.
 610         (thread_db_load): Likewise.
 611
 612 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 613
 614         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 615         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 616         NULL, and complain/return if that's the case.
 617
 618 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 619
 620         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 621         (advance, posn, abstract_read_memory): New functions.
 622         [struct mem_read_abstraction]: New struct.
 623         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 624
 625 2019-05-14  Tom Tromey  <tromey@adacore.com>
 626
 627         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 628         value is not lval_memory.
 629
 630 2019-05-14  Tom Tromey  <tromey@adacore.com>
 631
 632         * solib.c (info_sharedlibrary_command): Style the file name.
 633
 634 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 635
 636         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 637         (aarch64_vnv_type): Likewise.
 638         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 639         * common/tdesc.c: Likewise.
 640         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 641         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 642         * features/aarch64-fpu.xml: Add ieee half view.
 643         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 644         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 645         * gdbtypes.h (struct builtin_type): Likewise.
 646         (struct objfile_type): Likewise.
 647
 648 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 649
 650         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 651         typo.
 652         * location.h (string_to_event_location): Likewise.
 653
 654 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 655
 656         GDB 8.3 released.
 657
 658 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 659
 660         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 661         New variable declaration.
 662         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 663         New variable.
 664         (print_one_breakpoint): Use ui_out::test_flags and new global
 665         variable to compute use_fixed_output.
 666         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 667         Remove.
 668         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 669         (mi_multi_location_breakpoint_output_fixed): Remove.
 670         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 671         new variable.
 672         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 673         fix_multi_location_breakpoint_output flag if version >= 3.
 674         * ui-out.h (enum ui_out_flag)
 675         <fix_multi_location_breakpoint_output>: New enumerator.
 676
 677 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 678
 679         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 680
 681 2019-05-10  Tom Tromey  <tromey@adacore.com>
 682
 683         * ada-lang.c (catch_ada_completer): New function.
 684         (_initialize_ada_language): Use it.
 685
 686 2019-05-10  Tom Tromey  <tromey@adacore.com>
 687
 688         * thread.c (print_thread_info): Make "requested_threads" const.
 689         * gdbthread.h (print_thread_info): Make "requested_threads"
 690         const.
 691         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 692         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 693
 694 2019-05-08  Tom Tromey  <tom@tromey.com>
 695
 696         * gdbtypes.c (objfile_type_data): Change type.
 697         (objfile_type, _initialize_gdbtypes): Update.
 698
 699 2019-05-08  Tom Tromey  <tom@tromey.com>
 700
 701         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 702         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 703         (_initialize_dwarf2_frame): Update.
 704
 705 2019-05-08  Tom Tromey  <tom@tromey.com>
 706
 707         * objc-lang.c (objc_objfile_data): Change type.
 708         (find_methods): Update.
 709         (_initialize_objc_lang): Remove.
 710
 711 2019-05-08  Tom Tromey  <tom@tromey.com>
 712
 713         * stabsread.c (rs6000_builtin_type_data): Change type.
 714         (rs6000_builtin_type, _initialize_stabsread): Update.
 715
 716 2019-05-08  Tom Tromey  <tom@tromey.com>
 717
 718         * mips-tdep.c (mips_pdr_data): Remove.
 719         (_initialize_mips_tdep): Update.
 720
 721 2019-05-08  Tom Tromey  <tom@tromey.com>
 722
 723         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 724         (hppa_init_objfile_priv_data, read_unwind_info)
 725         (find_unwind_entry, _initialize_hppa_tdep): Update.
 726
 727 2019-05-08  Tom Tromey  <tom@tromey.com>
 728
 729         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 730         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 731         on obstack.
 732         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 733
 734 2019-05-08  Tom Tromey  <tom@tromey.com>
 735
 736         * mdebugread.c (basic_type_data): Change type.
 737         (basic_type, _initialize_mdebugread): Update.
 738
 739 2019-05-08  Tom Tromey  <tom@tromey.com>
 740
 741         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 742
 743 2019-05-08  Tom Tromey  <tom@tromey.com>
 744
 745         * nto-tdep.c (nto_inferior_data_reg): Change type.
 746         (nto_inferior_data): Update.
 747         (nto_inferior_data_cleanup, nto_new_inferior_data)
 748         (_initialize_nto_tdep): Remove.
 749         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 750
 751 2019-05-08  Tom Tromey  <tom@tromey.com>
 752
 753         * ada-lang.c (struct ada_inferior_data): Add initializers.
 754         (ada_inferior_data): Change type.
 755         (ada_inferior_data_cleanup): Remove.
 756         (get_ada_inferior_data, ada_inferior_exit)
 757         (struct ada_pspace_data): Add initializers, destructor.
 758         (ada_pspace_data_handle): Change type.
 759         (get_ada_pspace_data): Update.
 760         (ada_pspace_data_cleanup): Remove.
 761
 762 2019-05-08  Tom Tromey  <tom@tromey.com>
 763
 764         * coffread.c (struct coff_symfile_info): Add initializers.
 765         (coff_objfile_data_key): Move lower.  Change type.
 766         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 767         Update.
 768         (coff_free_info): Remove.
 769
 770 2019-05-08  Tom Tromey  <tom@tromey.com>
 771
 772         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 773         (fbsd_pspace_data_handle): Move lower.  Change type.
 774         (get_fbsd_pspace_data): Update.
 775         (fbsd_pspace_data_cleanup): Remove.
 776         (_initialize_fbsd_tdep): Update.
 777
 778 2019-05-08  Tom Tromey  <tom@tromey.com>
 779
 780         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 781         (get_ada_tasks_pspace_data): Update.
 782         (ada_tasks_pspace_data_cleanup): Remove.
 783         (_initialize_tasks): Update.
 784         (ada_tasks_inferior_data_handle): Change type.
 785         (get_ada_tasks_inferior_data): Update.
 786         (ada_tasks_inferior_data_cleanup): Remove.
 787         (struct ada_tasks_pspace_data): Add initializers.
 788
 789 2019-05-08  Tom Tromey  <tom@tromey.com>
 790
 791         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 792         * symfile-debug.c (debug_sym_get_probes): Change type.
 793         * stap-probe.c (handle_stap_probe):
 794         (stap_static_probe_ops::get_probes): Change type.
 795         * probe.h (class static_probe_ops) <get_probes>: Change type.
 796         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 797         (parse_probes_in_pspace): Update.
 798         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 799         Update.
 800         (any_static_probe_ops::get_probes): Change type.
 801         * elfread.c (elfread_data): New typedef.
 802         (probe_key): Change type.
 803         (elf_get_probes): Likewise.  Update.
 804         (probe_key_free): Remove.
 805         (_initialize_elfread): Update.
 806         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 807         Change type.
 808         (dtrace_process_dof_probe, dtrace_process_dof)
 809         (dtrace_static_probe_ops::get_probe): Change type.
 810
 811 2019-05-08  Tom Tromey  <tom@tromey.com>
 812
 813         * xcoffread.c (struct xcoff_symfile_info): Rename from
 814         coff_symfile_info.  Add initializers.
 815         (xcoff_objfile_data_key): Move lower.  Change type.
 816         (XCOFF_DATA): Rewrite.
 817         (xcoff_free_info): Remove.
 818         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 819         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 820         (xcoff_initial_scan): Update.
 821
 822 2019-05-08  Tom Tromey  <tom@tromey.com>
 823
 824         * solib-svr4.c (struct svr4_info): Add initializers and
 825         destructor.
 826         <probes_table>: Now an htab_up.
 827         (solib_svr4_pspace_data): Change type.
 828         (free_probes_table): Simplify.
 829         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 830         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 831         (probes_table_remove_objfile_probes, register_solib_event_probe)
 832         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 833         (_initialize_svr4_solib): Update.
 834
 835 2019-05-08  Tom Tromey  <tom@tromey.com>
 836
 837         * remote.c (remote_pspace_data): Change type.
 838         (remote_pspace_data_cleanup): Remove.
 839         (get_remote_exec_file, set_pspace_remote_exec_file)
 840         (_initialize_remote): Update.
 841
 842 2019-05-08  Tom Tromey  <tom@tromey.com>
 843
 844         * breakpoint.c (breakpoint_objfile_key): Change type.
 845         (get_breakpoint_objfile_data): Update.
 846         (free_breakpoint_objfile_data): Remove.
 847         (_initialize_breakpoint): Update.
 848
 849 2019-05-08  Tom Tromey  <tom@tromey.com>
 850
 851         * linux-tdep.c (struct linux_info): Add initializers.
 852         (linux_inferior_data): Move.  Change type.
 853         (invalidate_linux_cache_inf): Update.
 854         (linux_inferior_data_cleanup): Remove.
 855         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 856
 857 2019-05-08  Tom Tromey  <tom@tromey.com>
 858
 859         * auxv.c (auxv_inferior_data): Move.  Change type.
 860         (auxv_inferior_data_cleanup): Remove.
 861         (invalidate_auxv_cache_inf): Rewrite.
 862         (get_auxv_inferior_data, _initialize_auxv): Update.
 863
 864 2019-05-08  Tom Tromey  <tom@tromey.com>
 865
 866         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 867         (symfile_debug_objfile_data_key): Change type.
 868         (symfile_debug_installed, debug_qf_has_symbols)
 869         (debug_qf_find_last_source_symtab)
 870         (debug_qf_forget_cached_source_info)
 871         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 872         (debug_qf_print_stats, debug_qf_dump)
 873         (debug_qf_expand_symtabs_for_function)
 874         (debug_qf_expand_all_symtabs)
 875         (debug_qf_expand_symtabs_with_fullname)
 876         (debug_qf_map_matching_symbols)
 877         (debug_qf_expand_symtabs_matching)
 878         (debug_qf_find_pc_sect_compunit_symtab)
 879         (debug_qf_map_symbol_filenames)
 880         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 881         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 882         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 883         (debug_sym_read_linetable, debug_sym_relocate): Update.
 884         (symfile_debug_free_objfile): Remove.
 885         (install_symfile_debug_logging, _initialize_symfile_debug):
 886         Update.
 887
 888 2019-05-08  Tom Tromey  <tom@tromey.com>
 889
 890         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 891         allocate_on_obstack.
 892         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 893         (get_dwarf2_per_objfile): Update.
 894         (set_dwarf2_per_objfile): Remove.
 895         (dwarf2_has_info, dwarf2_get_section_info): Update.
 896         (dwarf2_free_objfile): Remove.
 897         (_initialize_dwarf2_read): Update.
 898
 899 2019-05-08  Tom Tromey  <tom@tromey.com>
 900
 901         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 902         initializers.
 903         <unsupported_script_warning_printed,
 904         script_not_found_warning_printed>: Now bool.
 905         (auto_load_pspace_data): Change type.
 906         (~auto_load_pspace_info): Rename from
 907         auto_load_pspace_data_cleanup.
 908         (get_auto_load_pspace_data, init_loaded_scripts_info)
 909         (clear_section_scripts, maybe_print_unsupported_script_warning)
 910         (maybe_print_script_not_found_warning, _initialize_auto_load):
 911         Update.
 912
 913 2019-05-08  Tom Tromey  <tom@tromey.com>
 914
 915         * objfiles.c (objfile_pspace_info): Add destructor and
 916         initializers.
 917         (objfiles_pspace_data): Change type.
 918         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 919         (get_objfile_pspace_data): Update.
 920         (objfiles_bfd_data): Change type.
 921         (get_objfile_bfd_data): Update.
 922         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 923
 924 2019-05-08  Tom Tromey  <tom@tromey.com>
 925
 926         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 927         Change type.
 928         (get_catch_syscall_inferior_data): Update.
 929         (catch_syscall_inferior_data_cleanup): Remove.
 930         (_initialize_break_catch_syscall): Update.
 931
 932 2019-05-08  Tom Tromey  <tom@tromey.com>
 933
 934         * inflow.c (struct terminal_info): Add destructor and
 935         initializers.
 936         (inflow_inferior_data): Change type.
 937         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 938         (get_inflow_inferior_data, inflow_inferior_exit)
 939         (swap_terminal_info, _initialize_inflow): Update.
 940
 941 2019-05-08  Tom Tromey  <tom@tromey.com>
 942
 943         * target-dcache.c (target_dcache_cleanup): Remove.
 944         (target_dcache_aspace_key): Change type.
 945         (target_dcache_init_p, target_dcache_invalidate)
 946         (target_dcache_get, target_dcache_get_or_init)
 947         (_initialize_target_dcache): Update.
 948         * dcache.h (struct dcache_deleter): New.
 949
 950 2019-05-08  Tom Tromey  <tom@tromey.com>
 951
 952         * symtab.c (struct symbol_cache): Add destructor and
 953         initializers.
 954         (symbol_cache_key): Move.  Change type.
 955         (make_symbol_cache, free_symbol_cache): Remove.
 956         (get_symbol_cache): Update.
 957         (symbol_cache_cleanup): Remove.
 958         (ALL_PSPACES, symbol_cache_flush)
 959         (maintenance_print_symbol_cache)
 960         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 961         Update.
 962
 963 2019-05-08  Tom Tromey  <tom@tromey.com>
 964
 965         * symtab.c (struct main_info): Add destructor and initializers.
 966         (main_progspace_key): Move.  Change type.
 967         (get_main_info): Update.
 968         (main_info_cleanup): Remove.
 969         (_initialize_symtab): Update.
 970
 971 2019-05-08  Tom Tromey  <tom@tromey.com>
 972
 973         * registry.h (DECLARE_REGISTRY): Define the _key class.
 974
 975 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 976
 977         * NEWS: Merge two 'New commands' sections.
 978
 979 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 980
 981         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 982         parameter and use Ada language definition instead.
 983         (ada_val_print_ptr): Remove unused language parameter.
 984         (ada_val_print_num): Remove language parameter and use Ada language
 985         definition instead.
 986         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 987         parameter.
 988         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 989         parameter and use Ada language definition instead.
 990         (ada_val_print_1): Update all ada_val_print_xxx calls.
 991         Remove language parameter.
 992         (ada_val_print): Update ada_val_print_1 call.
 993
 994 2019-05-08  Tom Tromey  <tromey@adacore.com>
 995
 996         * remote.c (remote_hw_watchpoint_limit)
 997         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 998         Now static.
 999
1000 2019-05-08  Tom Tromey  <tromey@adacore.com>
1001
1002         * maint.c (_initialize_maint_cmds): Move initialization code to
1003         remote.c.
1004         (watchdog, show_watchdog): Move to remote.c.
1005         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1006         "watchdog" static.
1007         (_initialize_remote): Move initialization code from maint.c.
1008         * defs.h (watchdog): Don't declare.
1009
1010 2019-05-08  Tom Tromey  <tromey@adacore.com>
1011
1012         * tui/tui-interp.c: Include main.h.
1013         * interps.c: Include main.h.
1014         * main.h (interpreter_p): Declare.
1015         * defs.h (interpreter_p): Don't declare.
1016
1017 2019-05-08  Tom Tromey  <tromey@adacore.com>
1018
1019         * dwarf2loc.c: Include dwarf2read.h.
1020         * defs.h (read_unsigned_leb128): Don't declare.
1021         * dwarf2read.h (read_unsigned_leb128): Declare.
1022
1023 2019-05-08  Tom Tromey  <tromey@adacore.com>
1024
1025         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1026         method.
1027
1028 2019-05-08  Tom Tromey  <tromey@adacore.com>
1029
1030         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1031         when no wrap column is set.
1032
1033 2019-05-08  Tom Tromey  <tromey@adacore.com>
1034
1035         * c-lang.c (c_get_string): Handle non-C-style arrays.
1036
1037 2019-05-08  Tom Tromey  <tromey@adacore.com>
1038
1039         * typeprint.c (print_offset_data::update): Print the bit offset,
1040         not the number of bits remaining.
1041
1042 2019-05-08  Tom Tromey  <tromey@adacore.com>
1043
1044         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1045         padding at end of comment.
1046
1047 2019-05-08  Tom Tromey  <tromey@adacore.com>
1048
1049         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1050         Compare main types.
1051
1052 2019-05-06  Tom Tromey  <tom@tromey.com>
1053
1054         * common/scoped_mmap.c: Include common-defs.h.
1055         * common/scoped_mmap.h: Don't include config.h.
1056
1057 2019-05-04  Tom Tromey  <tom@tromey.com>
1058
1059         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1060         (struct aarch64_call_info): Add initializers.
1061         <si>: Now a std::vector.
1062         (pass_on_stack, aarch64_push_dummy_call): Update.
1063
1064 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1065             Tom Tromey  <tom@tromey.com>
1066
1067         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1068         (ppc_threads): Now a std::vector.  Now static.
1069         (hwdebug_find_thread_points_by_tid)
1070         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1071         Update.
1072
1073 2019-05-04  Tom Tromey  <tom@tromey.com>
1074
1075         * arc-tdep.c (arc_tdesc_init): Return bool.
1076
1077 2019-05-04  Tom Tromey  <tom@tromey.com>
1078
1079         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1080         Use gdb_assert_not_reached.
1081
1082 2019-05-04  Tom Tromey  <tom@tromey.com>
1083
1084         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1085         "false".
1086
1087 2019-05-04  Tom Tromey  <tom@tromey.com>
1088
1089         * arc-tdep.c (arc_tdesc_init): Use bool.
1090
1091 2019-05-04  Tom Tromey  <tom@tromey.com>
1092
1093         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1094
1095 2019-05-04  Tom Tromey  <tom@tromey.com>
1096
1097         * cli/cli-cmds.c (valid_command_p): Return bool.
1098
1099 2019-05-04  Tom Tromey  <tom@tromey.com>
1100
1101         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1102         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1103
1104 2019-05-04  Raul Tambre  <raul@tambre.ee>
1105
1106         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1107         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1108         operator for comparison.
1109
1110 2019-05-04  Tom Tromey  <tom@tromey.com>
1111
1112         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1113         (lookup_partial_symbol, print_partial_symbols)
1114         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1115         (psymbol_compare): Update.
1116         (add_psymbol_to_bcache): Clear the entire psymbol.
1117         (maintenance_check_psymtabs): Update.
1118         * psympriv.h (struct partial_symbol): Don't derive from
1119         general_symbol_info.
1120         <obj_section, unrelocated_address, address,
1121         set_unrelocated_address>: Update.
1122         <ginfo>: New member.
1123         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1124         (debug_names::write_psymbols): Update.
1125
1126 2019-05-04  Tom de Vries  <tdevries@suse.de>
1127
1128         * contrib/cc-with-tweaks.sh: Support -n arg.
1129
1130 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1131
1132         * corelow.c (core_target::detach): Ensure frame cache and
1133         register caches are cleared.
1134         inferior.c (exit_inferior_1): Likewise.
1135
1136 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1137             Tom Tromey  <tom@tromey.com>
1138
1139         * dictionary.c (collate_pending_symbols_by_language): Remove
1140         "struct" from foreach.
1141         * symtab.c (lookup_global_symbol_from_objfile)
1142         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1143         foreach.
1144         * ser-tcp.c (net_open): Remove "struct" from foreach.
1145         * objfiles.c (objfile_relocate, objfile_rebase)
1146         (objfile_has_symbols): Remove "struct" from foreach.
1147         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1148         from foreach.
1149         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1150         foreach.
1151         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1152         "struct" from foreach.
1153         * ada-lang.c (create_excep_cond_exprs)
1154         (ada_exception_catchpoint_cond_string): Remove "struct" from
1155         foreach.
1156
1157 2019-05-03  Tom Tromey  <tromey@adacore.com>
1158
1159         * ada-exp.y (convert_char_literal): Check suffix of each
1160         enumerator.
1161
1162 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1163
1164         PR ada/21406:
1165         * ada-exp.y (yywrap): Don't define.
1166         * ada-lex.l (%option): Add noyywrap
1167         (yywrap): Remove.
1168
1169 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1170
1171         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1172         _WIN32_WINNT to the XP level, unless already defined to a higher
1173         level.
1174
1175         * unittests/parse-connection-spec-selftests.c:
1176         * ser-tcp.c:
1177         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1178         override.
1179
1180         * symfile.c (find_separate_debug_file): Remove colon from the
1181         drive spec of DOS/Windows file names of the target, so that the
1182         file name produced from DEBUGDIR and the target's directory will
1183         be valid on DOS/Windows systems.
1184
1185 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1186
1187         * rust-lang.c (val_print_struct): Handle printing structures
1188         containing strings.
1189
1190 2019-05-02  Tom Tromey  <tromey@adacore.com>
1191
1192         * valarith.c (_initialize_valarith): Remove.
1193
1194 2019-05-01  Tom Tromey  <tromey@adacore.com>
1195
1196         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1197         bitfields.
1198
1199 2019-05-01  Tom Tromey  <tromey@adacore.com>
1200
1201         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1202         for big-endian copies.
1203
1204 2019-04-30  Ali Tamur  <tamur@google.com>
1205         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1206         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1207         (read_3_bytes): New function.
1208
1209 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1210
1211         * windows-nat.c (main_thread_id): Delete.
1212         (handle_output_debug_string): Replace main_thread_id by
1213         current_event.dwThreadId.
1214         (fake_create_process): Likewise.
1215         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1216         Do not set main_thread_id.
1217         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1218         current_event.dwThreadId.
1219         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1220
1221 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1222
1223         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1224         Use current_event.dwThreadId instead of main_thread_id.
1225
1226 2019-04-30  Tom Tromey  <tromey@adacore.com>
1227
1228         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1229         (create_excep_cond_exprs): Iterate over program spaces.
1230         (ada_exception_catchpoint_cond_string): Examine all minimal
1231         symbols for exception types.
1232
1233 2019-04-30  Tom Tromey  <tromey@adacore.com>
1234
1235         PR c++/24470:
1236         * dwarf2read.c (process_structure_scope): Handle case where type
1237         has template parameters but no symbol was created.
1238
1239 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1240             Chris January  <chris.january@arm.com>
1241
1242         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1243         qualifier.
1244         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1245
1246 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1247
1248         * f-typeprint.c (f_print_type): Update rules for printing
1249         whitespace.
1250         (f_type_print_varspec_suffix): Likewise.
1251
1252 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1253             Chris January  <chris.january@arm.com>
1254
1255         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1256         function arguments.
1257
1258 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1259
1260         * f-lang.c (build_fortran_types): Change name of void type to
1261         lower case.
1262         * f-typeprint.c (f_type_print_base): Print the name of the void
1263         type, rather than a fixed string.
1264         * f-valprint.c (f_decorations): Use lower case void string.
1265
1266 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1267             Chris January  <chris.january@arm.com>
1268
1269         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1270         types for Fortran.
1271
1272 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1273             Chris January  <chris.january@arm.com>
1274             David Lecomber  <david.lecomber@arm.com>
1275
1276         * f-exp.y (BINOP_INTRINSIC): New token.
1277         (exp): New parser rule handling BINOP_INTRINSIC.
1278         (f77_keywords): Add new builtin procedures.
1279         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1280         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1281         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1282         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1283         (print_unop_subexp_f): New function.
1284         (print_binop_subexp_f): New function.
1285         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1286         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1287         (dump_subexp_body_f): Likewise.
1288         (operator_check_f): Likewise.
1289         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1290         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1291
1292 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1293
1294         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1295         UNOP_KIND.
1296         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1297         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1298         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1299         (operator_length_f): New fuction.
1300         (print_subexp_f): New function.
1301         (op_name_f): New function.
1302         (dump_subexp_body_f): New function.
1303         (operator_check_f): New function.
1304         (exp_descriptor_f): Replace standard expression handling functions
1305         with new functions.
1306         * gdb/fortran-operator.def: New file.
1307         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1308         * gdb/std-operator.def: Remove UNOP_KIND.
1309
1310 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1311
1312         * std-operator.def: Remove unbalanced, stray double quote
1313         character.
1314
1315 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1316             Chris January  <chris.january@arm.com>
1317             Daniel Everett  <daniel.everett@arm.com>
1318             Nick Forrington  <nick.forrington@arm.com>
1319             Richard Bunt  <richard.bunt@arm.com>
1320
1321         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1322         of depth when printing anonymous structs or unions.
1323         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1324         Don't print either the top-level value, or the children if the
1325         max-depth is exceeded.
1326         (ppscm_print_children): When printing the key of a map, allow one
1327         extra level of depth.
1328         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1329         print either the top-level value, or the children if the max-depth
1330         is exceeded.
1331         (print_children): When printing the key of a map, allow one extra
1332         level of depth.
1333         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1334         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1335         (user_print_options): Initialise max_depth field.
1336         (val_print_scalar_or_string_type_p): New function.
1337         (val_print): Check to see if the max depth has been reached.
1338         (val_print_check_max_depth): Define new function.
1339         (show_print_max_depth): New function.
1340         (_initialize_valprint): Add 'print max-depth' option.
1341         * valprint.h (struct value_print_options) <max_depth>: New field.
1342         (val_print_check_max_depth): Declare new function.
1343         * NEWS: Document new feature.
1344
1345 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1346
1347         * ada-lang.c (ada_language_defn): Initialise new field.
1348         * c-lang.c (c_is_string_type_p): New function.
1349         (c_language_defn): Initialise new field.
1350         (cplus_language_defn): Initialise new field.
1351         (asm_language_defn): Initialise new field.
1352         (minimal_language_defn): Initialise new field.
1353         * c-lang.h (c_is_string_type_p): Declare new function.
1354         * d-lang.c (d_language_defn): Initialise new field.
1355         * f-lang.c (f_is_string_type_p): New function.
1356         (f_language_defn): Initialise new field.
1357         * go-lang.c (go_is_string_type_p): New function.
1358         (go_language_defn): Initialise new field.
1359         * language.c (default_is_string_type_p): New function.
1360         (unknown_language_defn): Initialise new field.
1361         (auto_language_defn): Initialise new field.
1362         * language.h (struct language_defn) <la_is_string_type_p>: New
1363         member variable.
1364         (default_is_string_type_p): Declare new function.
1365         * m2-lang.c (m2_language_defn): Initialise new field.
1366         * objc-lang.c (objc_language_defn): Initialise new field.
1367         * opencl-lang.c (opencl_language_defn): Initialise new field.
1368         * p-lang.c (pascal_is_string_type_p): New function.
1369         (pascal_language_defn): Initialise new field.
1370         * rust-lang.c (rust_is_string_type_p): New function.
1371         (rust_language_defn): Initialise new field.
1372
1373 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1374
1375         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1376         New field.
1377         * ada-lang.c (ada_language_defn): Initialise new field.
1378         * c-lang.c (c_language_defn): Likewise.
1379         (cplus_language_defn): Likewise.
1380         (asm_language_defn): Likewise.
1381         (minimal_language_defn): Likewise.
1382         * d-lang.c (d_language_defn): Likewise.
1383         * f-lang.c (f_language_defn): Likewise.
1384         * go-lang.c (go_language_defn): Likewise.
1385         * language.c (unknown_language_defn): Likewise.
1386         (auto_language_defn): Likewise.
1387         * m2-lang.c (m2_language_defn): Likewise.
1388         * objc-lang.c (objc_language_defn): Likewise.
1389         * opencl-lang.c (opencl_language_defn): Likewise.
1390         * p-lang.c (pascal_language_defn): Likewise.
1391         * rust-lang.c (rust_language_defn): Likewise.
1392
1393 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1394
1395         * ada-lang.c (ada_is_character_type): Change return type to bool.
1396         (ada_is_string_type): Likewise.
1397         * ada-lang.h (ada_is_character_type): Update declaration
1398         (ada_is_string_type): Likewise.
1399
1400 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1401
1402         Support style in 'frame|thread apply'
1403
1404         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1405         * record.c (record_start, record_stop): Update callers of
1406         execute_command_to_string with false.
1407         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1408         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1409         methods.
1410         (class string_file): New constructor with term_out parameter.
1411         Override methods term_out and can_emit_style_escape.  New member
1412         term_out.
1413         (class stdio_file): Override can_emit_style_escape.
1414         (class tee_file): Override term_out and can_emit_style_escape.
1415         * utils.h (can_emit_style_escape): Remove.
1416         * utils.c (can_emit_style_escape): Likewise.
1417         Update all callers of can_emit_style_escape (SOMESTREAM) to
1418         SOMESTREAM->can_emit_style_escape.
1419         * source-cache.c (source_cache::get_source_lines): Likewise.
1420         * stack.c (frame_apply_command_count): Call execute_command_to_string
1421         passing the term_out characteristic of the current gdb_stdout.
1422         * thread.c (thr_try_catch_cmd): Likewise.
1423         * top.c (execute_command_to_string): pass term_out parameter
1424         to construct the string_file for the command output.
1425         * ui-file.c (term_cli_styling): New function (most code moved
1426         from utils.c can_emit_style_escape).
1427         (string_file::string_file, string_file::can_emit_style_escape,
1428         stdio_file::can_emit_style_escape, tee_file::term_out,
1429         tee_file::can_emit_style_escape): New functions.
1430
1431 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1432
1433         * NEWS: Mention the new set|show may-call-functions.
1434         * infcall.c (may_call_functions_p): New variable.
1435         (show_may_call_functions_p): New function.
1436         (call_function_by_hand_dummy): Throws an error if not
1437         may-call-functions.
1438         (_initialize_infcall): Call add_setshow_boolean_cmd for
1439         may-call-functions.
1440
1441 2019-04-25  Keith Seitz  <keiths@redhat.com>
1442
1443         PR c++/24367
1444         * cp-support.c (inspect_type): Don't attempt substitutions
1445         of symbol with the same name.
1446
1447 2019-04-25  Tom Tromey  <tromey@adacore.com>
1448
1449         PR gdb/24475:
1450         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1451         static.
1452
1453 2019-04-25  Tom Tromey  <tromey@adacore.com>
1454
1455         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1456         rvalue reference.
1457         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1458         (gdb_xml_parser::parse): Use std::move.
1459         * python/python-internal.h (gdbpy_convert_exception): Take a const
1460         reference.
1461         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1462         std::move.
1463         * python/py-utils.c (gdbpy_convert_exception): Take a const
1464         reference.
1465         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1466         Use std::move.
1467         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1468         Use std::move.
1469         * mi/mi-main.c (mi_print_exception): Take a const reference.
1470         * main.c (handle_command_errors): Take a const reference.
1471         * linespec.c (parse_linespec): Use std::move.
1472         * infcall.c (run_inferior_call): Use std::move.
1473         (call_function_by_hand_dummy): Use std::move.
1474         * exec.c (try_open_exec_file): Use std::move.
1475         * exceptions.h (exception_print, exception_fprintf)
1476         (exception_print_same): Update.
1477         * exceptions.c (print_exception, exception_print)
1478         (exception_fprintf, exception_print_same): Change parameters to
1479         const reference.
1480         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1481         * common/new-op.c: Use std::move.
1482         * common/common-exceptions.h (struct gdb_exception): Add move
1483         constructor.
1484         (struct gdb_exception_error, struct gdb_exception_quit, struct
1485         gdb_quit_bad_alloc): Change constructor to move constructor.
1486         (throw_exception): Change parameter to rvalue reference.
1487         * common/common-exceptions.c (throw_exception): Take rvalue
1488         reference.
1489         * cli/cli-interp.c (safe_execute_command): Use std::move.
1490         * breakpoint.c (insert_bp_location, location_to_sals): Use
1491         std::move.
1492
1493 2019-04-25  Tom Tromey  <tromey@adacore.com>
1494
1495         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1496         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1497         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1498         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1499         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1500         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1501         guile/scm-value.c: Use unpack.
1502         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1503         gdbscm_gdb_exception.
1504         (gdbscm_throw_gdb_exception): Likewise.
1505         (struct gdbscm_gdb_exception): New.
1506         (unpack): New function.
1507         (gdbscm_wrap): Use unpack.
1508
1509 2019-04-25  Tom Tromey  <tromey@adacore.com>
1510
1511         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1512         (gdb_rl_callback_handler): Use std::move.
1513         * common/common-exceptions.h (struct gdb_exception): Add move
1514         assignment operator.
1515         (throw_exception_sjlj): Change "exception" to const reference.
1516         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1517         (throw_exception_sjlj): Change "exception" to const reference.
1518
1519 2019-04-25  Tom Tromey  <tromey@adacore.com>
1520
1521         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1522         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1523         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1524         Update.
1525         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1526         Update.
1527         * mi/mi-interp.c (mi_interp::exec): Update.
1528         * linespec.c (parse_linespec): Update.
1529         * infcall.c (run_inferior_call): Update.
1530         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1531         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1532         (gdbscm_lookup_global_symbol): Update.
1533         * guile/scm-param.c (gdbscm_parameter_value): Update.
1534         * guile/scm-frame.c (gdbscm_frame_read_register)
1535         (gdbscm_frame_read_var): Update.
1536         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1537         * exec.c (try_open_exec_file): Update.
1538         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1539         (gdb_rl_callback_handler): Update.
1540         * common/common-exceptions.h (exception_none): Don't declare.
1541         * common/common-exceptions.c (exception_none): Don't define.
1542         (struct catcher) <exception>: Update.
1543         * cli/cli-interp.c (safe_execute_command): Update.
1544         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1545
1546 2019-04-25  Ali Tamur  <tamur@google.com>
1547
1548         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1549         (read_attribute_value): Likewise.
1550         (dwarf2_read_addr_index): Update comment.
1551         (read_str_index): Add DW_FORM_strx.
1552         (dwarf2_string_attr): Likewise.
1553         (dwarf2_const_value_attr): Likewise.
1554         (dump_die_shallow): Likewise.
1555         (dwarf2_fetch_constant_bytes): Likewise.
1556         (skip_form_bytes): Likewise.
1557         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1558
1559 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1560
1561         PR corefiles/11608
1562         PR corefiles/18187
1563         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1564         OFFSET.  Verify if current mapping contains an ELF header.
1565         (linux_find_memory_regions_full): Adjust call to
1566         dump_mapping_p.
1567
1568 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1569             Kang Li <kanglictf@gmail.com>
1570
1571         PR gdb/21600
1572
1573         * dwarf2-frame.c (read_initial_length): Be consistent about using
1574         unsigned representation of length.
1575         (decode_frame_entry_1): Likewise.  Check for wraparound of
1576         end pointer as well as buffer overflow.
1577
1578 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1579
1580         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1581         "vq".
1582
1583 2019-04-24  Tom Tromey  <tromey@adacore.com>
1584
1585         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1586
1587 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1588
1589         * s12z-tdep.c (s12z_unwind_pc): Delete.
1590         (s12z_unwind_sp): Delete.
1591         (s12z_gdbarch_init): Don't register deleted functions with
1592         gdbarch.
1593
1594 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1595
1596         * rl78-tdep.c (rl78_unwind_sp): Delete.
1597         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1598
1599 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1600
1601         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1602         (xstormy16_unwind_pc): Delete.
1603         (xstormy16_dummy_id): Delete.
1604         (xstormy16_gdbarch_init): Don't register deleted functions with
1605         gdbarch.
1606
1607 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1608
1609         * vax-tdep.c (vax_unwind_pc): Delete.
1610         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1611
1612 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1613
1614         * v850-tdep.c (v850_unwind_sp): Delete.
1615         (v850_unwind_pc): Delete.
1616         (v850_dummy_id): Delete.
1617         (v850_gdbarch_init): Don't register deleted functions with
1618         gdbarch.
1619
1620 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1621
1622         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1623         (tilegx_unwind_pc): Delete.
1624         (tilegx_unwind_dummy_id): Delete.
1625         (tilegx_gdbarch_init): Don't register deleted functions with
1626         gdbarch.
1627
1628 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1629
1630         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1631         (tic6x_dummy_id): Delete.
1632         (tic6x_gdbarch_init): Don't register deleted functions with
1633         gdbarch.
1634
1635 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1636
1637         * sparc-tdep.c (sparc_unwind_pc): Delete.
1638         (sparc32_gdbarch_init): Don't register deleted function with
1639         gdbarch.
1640
1641 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1642
1643         * sh-tdep.c (sh_unwind_sp): Delete.
1644         (sh_unwind_pc): Delete.
1645         (sh_dummy_id): Delete.
1646         (sh_gdbarch_init): Don't register deleted functions with
1647         gdbarch.
1648
1649 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1650
1651         * score-tdep.c (score_unwind_sp): Delete.
1652         (score_unwind_pc): Delete.
1653         (score_dummy_id): Delete.
1654         (score_gdbarch_init): Don't register deleted functions with
1655         gdbarch.
1656
1657 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1658
1659         * rx-tdep.c (rx_unwind_pc): Delete.
1660         (rx_unwind_sp): Delete.
1661         (rx_dummy_id): Delete.
1662         (rx_gdbarch_init): Don't register deleted functions with
1663         gdbarch.  Update comment.
1664
1665 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1666
1667         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1668         (rs6000_dummy_id): Delete.
1669         (rs6000_gdbarch_init): Don't register deleted functions with
1670         gdbarch.
1671
1672 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1673
1674         * or1k-tdep.c (or1k_dummy_id): Delete.
1675         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1676
1677 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1678
1679         * nios2-tdep.c (nios2_dummy_id): Delete.
1680         (nios2_unwind_sp): Delete.
1681         (nios2_gdbarch_init): Don't register deleted functions with
1682         gdbarch.
1683
1684 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1685
1686         * nds32-tdep.c (nds32_dummy_id): Delete.
1687         (nds32_unwind_pc): Delete.
1688         (nds32_unwind_sp): Delete.
1689         (nds32_gdbarch_init): Don't register deleted functions with
1690         gdbarch.
1691
1692 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1693
1694         * msp430-tdep.c (msp430_unwind_pc): Delete.
1695         (msp430_unwind_sp): Delete.
1696         (msp430_dummy_id): Delete.
1697         (msp430_gdbarch_init): Don't register deleted functions with
1698         gdbarch.
1699
1700 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1701
1702         * moxie-tdep.c (moxie_unwind_sp): Delete.
1703         (moxie_unwind_pc): Delete.
1704         (moxie_dummy_id): Delete.
1705         (moxie_gdbarch_init): Don't register deleted functions with
1706         gdbarch.
1707
1708 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1709
1710         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1711         (mn10300_unwind_pc): Delete.
1712         (mn10300_unwind_sp): Delete.
1713         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1714         mn10300_unwind_sp.
1715         (mn10300_frame_unwind_init): Don't register deleted functions with
1716         gdbarch.
1717
1718 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1719
1720         * mep-tdep.c (mep_unwind_pc): Delete.
1721         (mep_unwind_sp): Delete.
1722         (mep_dummy_id): Delete.
1723         (mep_gdbarch_init): Don't register deleted functions with
1724         gdbarch.
1725
1726 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1727
1728         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1729         (m68hc11_unwind_sp): Delete.
1730         (m68hc11_gdbarch_init): Don't register deleted functions with
1731         gdbarch.
1732
1733 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1734
1735         * m32r-tdep.c (m32r_unwind_sp): Delete.
1736         (m32r_unwind_pc): Delete.
1737         (m32r_dummy_id): Delete.
1738         (m32r_gdbarch_init): Don't register deleted functions with
1739         gdbarch.
1740
1741 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1742
1743         * m32c-tdep.c (m32c_unwind_pc): Delete.
1744         (m32c_unwind_sp): Delete.
1745         (m32c_dummy_id): Delete.
1746         (m32c_gdbarch_init): Don't register deleted functions with
1747         gdbarch.
1748
1749 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1750
1751         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1752         (lm32_unwind_pc): Delete.
1753         (lm32_dummy_id): Delete.
1754         (lm32_gdbarch_init): Don't register deleted functions with
1755         gdbarch.
1756
1757 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1758
1759         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1760         (iq2000_unwind_pc): Delete.
1761         (iq2000_dummy_id): Delete.
1762         (iq2000_gdbarch_init): Don't register deleted functions with
1763         gdbarch.
1764
1765 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1766
1767         * nds32-tdep.c (nds32_type_align): Delete.
1768         (nds32_push_dummy_call): Use type_align instead.
1769
1770 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1771
1772         * arm-tdep.c (arm_type_align): Only handle vector override case.
1773         (arm_push_dummy_call): Use type_align.
1774         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1775
1776 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1777
1778         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1779         case.
1780         (pass_on_stack): Use type_align.
1781         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1782         function.
1783
1784 2019-04-23  Tom Tromey  <tromey@adacore.com>
1785
1786         * dwarf2read.c (line_header::file_name_at): Remove unused
1787         overload.
1788
1789 2019-04-23  Tom de Vries  <tdevries@suse.de>
1790
1791         PR gdb/24438
1792         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1793         invocation.
1794
1795
1796 2019-03-27  Ali Tamur  <tamur@google.com>
1797
1798         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1799         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1800         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1801         (dwarf_expr_context::get_addr_index): Likewise
1802         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1803         (symbol_needs_eval_context::get_addr_index): Likewise
1804         (disassemble_dwarf_expression): Add DW_OP_addrx
1805         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1806         (read_cutu_die_from_dwo): Update comment
1807         (skip_one_die): Add DW_FORM_addrx
1808         (read_attribute_value): Likewise
1809         (var_decode_location): Add DW_OP_addrx
1810         (dwarf2_const_value_attr): Add DW_FORM_addrx
1811         (dump_die_shallow): Likewise
1812         (dwarf2_fetch_constant_bytes): Likewise
1813         (decode_locdesc): Add DW_OP_addrx
1814         (skip_form_bytes): Add DW_FORM_addrx
1815
1816 2019-04-22  Ali Tamur  <tamur@google.com>
1817
1818         * MAINTAINERS (Write After Approval): Add self.
1819
1820 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1821
1822         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1823         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1824         (open_symbol_file_object): Likewise.
1825         (svr4_default_sos): Add info parameter.
1826         (svr4_read_so_list): Likewise.
1827         (svr4_current_sos_direct): Adjust functions calls to pass down
1828         info.
1829         (svr4_current_sos_1): Add info parameter.
1830         (svr4_current_sos): Call get_svr4_info, pass info down to
1831         svr4_current_sos_1.
1832         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1833         get_svr4_info.
1834         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1835         get_svr4_info.
1836         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1837         to get_svr4_info.
1838         (probes_table_remove_objfile_probes): Likewise.
1839         (register_solib_event_probe): Add info parameter.
1840         (solist_update_incremental): Pass info parameter down to
1841         svr4_read_so_list.
1842         (disable_probes_interface): Add info parameter.
1843         (svr4_handle_solib_event): Pass current_program_space to
1844         get_svr4_info.  Adjust disable_probes_interface cleanup.
1845         (svr4_create_probe_breakpoints): Add info parameter, pass it
1846         down to register_solib_event_probe.
1847         (svr4_create_solib_event_breakpoints): Add info parameter,
1848         pass it down to svr4_create_probe_breakpoints.
1849         (enable_break): Pass info down to
1850         svr4_create_solib_event_breakpoints.
1851         (svr4_solib_create_inferior_hook): Pass current_program_space to
1852         get_svr4_info.
1853         (svr4_clear_solib): Likewise.
1854
1855 2019-04-22  Pedro Alves  <palves@redhat.com>
1856
1857         * solib-svr4.c (svr4_free_objfile_observer): New.
1858         (probe_and_action::objfile): New field.
1859         (probes_table_htab_remove_objfile_probes)
1860         (probes_table_remove_objfile_probes): New functions.
1861         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1862         in the new probe_and_action.  Don't store the probe in 'lookup'.
1863         (svr4_create_probe_breakpoints): Pass objfile to
1864         register_solib_event_probe.
1865         (_initialize_svr4_solib): Register a free_objfile observer.
1866
1867 2019-04-19  Tom Tromey  <tom@tromey.com>
1868
1869         * common/queue.h: Remove.
1870
1871 2019-04-19  Tom Tromey  <tom@tromey.com>
1872
1873         * event-loop.c: Don't include "common/queue.h".
1874
1875 2019-04-19  Tom Tromey  <tom@tromey.com>
1876
1877         * remote.c (remote_target): Use delete.
1878         * remote-notif.h: Include <list>, not "common/queue.h".
1879         (notif_client_p): Remove typedef.
1880         (remote_notif_state): Add constructor, destructor, initializer.
1881         <notif_queue>: Now a std::list.
1882         (remote_notif_state_xfree): Don't declare.
1883         * remote-notif.c (remote_notif_process, handle_notification)
1884         (remote_notif_state_allocate): Update.
1885         (~remote_notif_state): Rename from remote_notif_state_xfree.
1886
1887 2019-04-19  Tom Tromey  <tom@tromey.com>
1888
1889         * symfile.c (reread_symbols): Update.
1890         * objfiles.c (objfile_register_static_link)
1891         (objfile_lookup_static_link): Update
1892         (~objfile) Don't delete static_links.
1893         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1894
1895 2019-04-19  Tom Tromey  <tom@tromey.com>
1896
1897         * type-stack.h (struct type_stack) <insert>: Constify string.
1898         * type-stack.c (type_stack::insert): Constify string.
1899         * gdbtypes.h (lookup_template_type): Update.
1900         (address_space_name_to_int): Update.
1901         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1902         const.
1903         (lookup_template_type): Make name const.
1904         * c-exp.y: Update rules.
1905         (lex_one_token, classify_name, classify_inner_name)
1906         (c_print_token): Update.
1907         * p-exp.y: Update rules.
1908         (yylex): Update.
1909         * f-exp.y: Update rules.
1910         (yylex): Update.
1911         * d-exp.y: Update rules.
1912         (lex_one_token, classify_name, classify_inner_name): Update.
1913         * parse.c (write_dollar_variable, copy_name): Return std::string.
1914         * parser-defs.h (copy_name): Change return type.
1915         * m2-exp.y: Update rules.
1916         (yylex): Update.
1917         * go-exp.y (lex_one_token): Update.
1918         Update rules.
1919         (classify_unsafe_function, classify_packaged_name)
1920         (classify_name, yylex): Update.
1921
1922 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1923
1924         * configure.ac: add --enable-source-highlight switch.
1925         * configure: Regenerate.
1926         * top.c (print_gdb_version): plumb --enable-source-highlight
1927         status to "show configuration".
1928
1929 2019-04-19  Tom Tromey  <tromey@adacore.com>
1930
1931         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1932         Check ADA_TYPE_P.
1933         (empty_record, ada_template_to_fixed_record_type_1)
1934         (template_to_static_fixed_type)
1935         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1936         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1937         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1938         macros.
1939
1940 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1941
1942         PR symtab/24423:
1943         * source.c (print_source_lines_base): Advance "iter" when a
1944         control character is seen.
1945
1946 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1947
1948         * inferior.h (struct infcall_suspend_state_deleter):
1949         Catch exception in destructor to avoid crash.
1950
1951 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1952
1953         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1954         close to the add_com "shell".
1955
1956 2019-04-18  Tom Tromey  <tromey@adacore.com>
1957
1958         * process-stratum-target.h (class process_stratum_target)
1959         <stratum>: Add "final".
1960
1961 2019-04-17  Tom Tromey  <tromey@adacore.com>
1962
1963         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1964         against nullptr before use.
1965
1966 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1967
1968         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1969
1970 2019-04-17  Jim Wilson  <jimw@sifive.com>
1971             Andrew Burgess  <andrew.burgess@embecosm.com>
1972
1973         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1974         code read might fail, assume 4-byte breakpoint in that case.
1975
1976 2019-04-15  Leszek Swirski  <leszeks@google.com>
1977
1978         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1979         rather than a hand-rolled POD check when checking for forced MEMORY
1980         classification.
1981
1982 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1983
1984         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1985         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1986         function.
1987         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1988         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1989         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1990         declaration.
1991
1992 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1993
1994         * aarch64-linux-nat.c
1995         (aarch64_linux_nat_target::thread_architecture): Add override.
1996         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1997         each VQ.
1998
1999 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2000
2001         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2002
2003 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2004
2005         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2006         target types of size 96-bits, add some additional comments, and
2007         check that the builtin type we found was the correct size.
2008
2009 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2010
2011         * utils.c (prompt_for_continue): Don't restore the styling at the
2012         end, as applied_style has the wrong value.  This fixes styling in
2013         long lists of file names that are interrupted by the "Continue?"
2014         prompt.
2015
2016 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2017
2018         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2019         * c-lang.c (c_language_defn): Likewise.
2020         (cplus_language_defn): Likewise.
2021         (asm_language_defn): Likewise.
2022         (minimal_language_defn): Likewise.
2023         * d-lang.c (d_language_defn): Likewise.
2024         * f-lang.c (f_language_defn): Likewise.
2025         * go-lang.c (go_language_defn): Likewise.
2026         * language.c (unknown_language_defn): Likewise.
2027         (auto_language_defn): Likewise.
2028         * language.h (struct language_defn): Remove la_magic field.
2029         (LANG_MAGIC): Delete.
2030         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2031         * objc-lang.c (objc_language_defn): Likewise.
2032         * opencl-lang.c (opencl_language_defn): Likewise.
2033         * p-lang.c (pascal_language_defn): Likewise.
2034         * rust-lang.c (rust_language_defn): Likewise.
2035
2036 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2037
2038         * riscv-tdep.c (riscv_type_align): New function.
2039         (riscv_type_alignment): Delete.
2040         (riscv_arg_location): Use 'type_align'.
2041         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2042
2043 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2044
2045         * gdbtypes.c (type_align): A struct with no non-static fields also
2046         has alignment of 1.
2047
2048 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2049
2050         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2051         component to 0.
2052         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2053         member.
2054         (riscv_struct_info::analyse): New implementation using new
2055         analyse_inner member function.
2056         (riscv_struct_info::field_offset): New member function.
2057         (riscv_struct_info::m_offsets): New member variable.
2058         (riscv_struct_info::analyse_inner): New private member function,
2059         takes the old implementation of riscv_struct_info::analyse but
2060         extended to track field offsets.
2061         (riscv_call_arg_struct): Update the struct folding special cases
2062         to handle cases where empty C++ structs, which are non-zero
2063         length, are found.
2064         (riscv_arg_location): Initialise the length of each location, a
2065         non-zero length now indicates the location is in use.
2066         (riscv_push_dummy_call): Allow for the first location having a
2067         non-zero offset when setting up arguments.
2068         (riscv_return_value): Likewise, but for return values.
2069
2070 2019-04-11  Tom Tromey  <tromey@adacore.com>
2071
2072         * utils.c (internal_vproblem): Make "msg" const.
2073
2074 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2075
2076         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2077         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2078         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2079         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2080
2081 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2082
2083         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2084         function.
2085         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2086         of amd64_collect_native_gregset.
2087         (amd64_linux_nat_target::store_registers): Likewise.
2088
2089 2019-04-10  Tom Tromey  <tom@tromey.com>
2090
2091         * symtab.c (lookup_global_symbol_from_objfile)
2092         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2093         * objfiles.h (class separate_debug_iterator): New.
2094         (class separate_debug_range): New.
2095         (struct objfile) <separate_debug_objfiles>: New method.
2096         (objfile_separate_debug_iterate): Don't declare.
2097         * objfiles.c (separate_debug_iterator::operator++): Rename from
2098         objfile_separate_debug_iterate.
2099         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2100         iterator.
2101         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2102         iterator.
2103
2104 2019-04-10  Tom Tromey  <tom@tromey.com>
2105
2106         * symfile.c (reread_symbols): Remove old comment.
2107         * objfiles.c (free_all_objfiles): Fix a typo.
2108
2109 2019-04-10  Tom Tromey  <tom@tromey.com>
2110
2111         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2112         * minsyms.c (lookup_minimal_symbol): Use foreach.
2113         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2114         (lookup_minimal_symbol_solib_trampoline): Likewise.
2115         * symfile.c (reread_symbols): Use foreach.
2116
2117 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2118             Tom Tromey  <tromey@adacore.com>
2119
2120         PR rust/24414:
2121         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2122         (rust_lex_int_test): Change "value" to be LONGEST.
2123         (rust_lex_tests): Add test for long integer literal.
2124
2125 2019-04-09  Tom Tromey  <tromey@adacore.com>
2126
2127         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2128         to bool.
2129         (extended_remote_target::attach): Update.
2130         (remote_target::remote_notice_new_inferior): Update.
2131         (remote_target::add_current_inferior_and_thread): Update.
2132         * inferior.c (exit_inferior_1): Use "false".
2133         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2134
2135 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2136
2137         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2138         the "start" command.
2139
2140 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2141
2142         * python/py-inferior.c (infpy_thread_from_thread_handle):
2143         Adjust comments to reflect renaming of thread_from_thread_handle
2144         to thread_from_handle.  Adjust keywords.  Fix type error message.
2145         (inferior_object_methods): Add thread_from_handle.  Retain
2146         thread_from_thread_handle, but mark it as deprecated.
2147
2148 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2149
2150         * gdbthread.h (find_thread_by_handle): Revise declaration.
2151         * thread.c (find_thread_by_handle): Likewise.  Adjust
2152         implementation too.
2153         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2154         support for buffer objects as handles.
2155
2156 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2157
2158         * python/py-infthread.c (thpy_thread_handle): New function.
2159         (thread_object_methods): Register thpy_thread_handle.
2160
2161 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2162
2163         * gdbthread.h (thread_to_thread_handle): Declare.
2164         * thread.c (gdbtypes.h): Include.
2165         (thread_to_thread_handle): New function.
2166
2167         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2168         (target_thread_info_to_thread_handle): Declare.
2169         * target.c (target_thread_info_to_thread_handle): New function.
2170         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2171         * target-delegates.c: Regenerate.
2172
2173         * linux-thread-db.c (class thread_db_target): Add method
2174         thread_info_to_thread_handle.
2175         (thread_db_target::thread_info_to_thread_handle): Define.
2176         * remote.c (class remote_target): Add new method
2177         thread_info_to_thread_handle.
2178         (remote_target::thread_info_to_thread_handle): Define.
2179
2180 2019-04-08  Pedro Alves  <palves@redhat.com>
2181
2182         * common/common-exceptions.c (throw_exception): Don't create
2183         named object to throw; throw directly.
2184         (throw_it): Likewise.  Don't initialize gdb_exception::message
2185         here, with new; pass FMT and AP to the ctor instead.
2186         * common/common-exceptions.h: Include <string>.
2187         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2188         const char *, va_list)): New ctor.  Use std::make_shared.
2189         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2190         errors)): Delete.
2191         (gdb_exception_error::gdb_exception_error(enum errors, const char
2192         *, va_list)): New.
2193         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2194         Add assertion.
2195         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2196         errors)): Delete.
2197         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2198         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2199         Add assertion.
2200
2201 2019-04-08  Tom Tromey  <tom@tromey.com>
2202
2203         * valops.c (value_rtti_indirect_type): Replace throw_exception
2204         with throw.
2205         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2206         with throw.
2207         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2208         throw.
2209         * target.c (target_translate_tls_address): Replace throw_exception
2210         with throw.
2211         * stack.c (frame_apply_command_count): Replace throw_exception
2212         with throw.
2213         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2214         throw.
2215         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2216         with throw.
2217         * rs6000-tdep.c (rs6000_frame_cache)
2218         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2219         * remote.c: Replace throw_exception with throw.
2220         * record-full.c (record_full_message, record_full_wait_1)
2221         (record_full_restore): Replace throw_exception with throw.
2222         * record-btrace.c:
2223         (get_thread_current_frame_id, record_btrace_start_replaying)
2224         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2225         (cmd_record_btrace_start): Replace throw_exception with throw.
2226         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2227         throw.
2228         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2229         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2230         * linespec.c:
2231         (find_linespec_symbols): Replace throw_exception with throw.
2232         * infrun.c (displaced_step_prepare, resume): Replace
2233         throw_exception with throw.
2234         * infcmd.c (post_create_inferior): Replace throw_exception with
2235         throw.
2236         * inf-loop.c (inferior_event_handler): Replace throw_exception
2237         with throw.
2238         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2239         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2240         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2241         (get_prev_frame_always, get_frame_pc_if_available)
2242         (get_frame_address_in_block_if_available, get_frame_language):
2243         Replace throw_exception with throw.
2244         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2245         throw_exception with throw.
2246         * eval.c (fetch_subexp_value, evaluate_var_value)
2247         (evaluate_funcall, evaluate_subexp_standard): Replace
2248         throw_exception with throw.
2249         * dwarf2loc.c (call_site_find_chain)
2250         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2251         Replace throw_exception with throw.
2252         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2253         with throw.
2254         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2255         throw.
2256         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2257         * completer.c (complete_line_internal): Replace throw_exception
2258         with throw.
2259         * compile/compile-object-run.c (compile_object_run): Replace
2260         throw_exception with throw.
2261         * cli/cli-script.c (process_next_line): Replace throw_exception
2262         with throw.
2263         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2264         (btrace_enable, btrace_maint_update_pt_packets): Replace
2265         throw_exception with throw.
2266         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2267         throw_exception with throw.
2268         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2269         throw_exception with throw.
2270         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2271         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2272         * aarch64-tdep.c (aarch64_make_prologue_cache)
2273         (aarch64_make_stub_cache): Replace throw_exception with throw.
2274
2275 2019-04-08  Tom Tromey  <tom@tromey.com>
2276
2277         * common/common-exceptions.c (throw_exception): Rename from
2278         throw_exception_cxx.  Remove old copy.  Make argument const.
2279         (throw_it): Create and throw exception objects directly.
2280         * common/common-exceptions.h (throw_exception): Make argument
2281         const.
2282         (struct gdb_exception_error): Add constructor.
2283         (struct gdb_exception_quit): Add constructor.
2284
2285 2019-04-08  Tom Tromey  <tom@tromey.com>
2286
2287         * common/common-exceptions.h (exception_rethrow): Don't declare.
2288         (TRY_SJLJ): Update comment.
2289         (TRY, CATCH, END_CATCH): Remove.
2290         * common/common-exceptions.c (exception_rethrow): Remove.
2291
2292 2019-04-08  Tom Tromey  <tom@tromey.com>
2293
2294         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2295         Remove.
2296         (gdb_exception_error): Rename from
2297         gdb_exception_RETURN_MASK_ERROR.
2298         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2299         (gdb_quit_bad_alloc): Update.
2300         * aarch64-tdep.c: Update.
2301         * ada-lang.c: Update.
2302         * ada-typeprint.c: Update.
2303         * ada-valprint.c: Update.
2304         * amd64-tdep.c: Update.
2305         * arch-utils.c: Update.
2306         * break-catch-throw.c: Update.
2307         * breakpoint.c: Update.
2308         * btrace.c: Update.
2309         * c-varobj.c: Update.
2310         * cli/cli-cmds.c: Update.
2311         * cli/cli-interp.c: Update.
2312         * cli/cli-script.c: Update.
2313         * common/common-exceptions.c: Update.
2314         * common/new-op.c: Update.
2315         * common/selftest.c: Update.
2316         * compile/compile-c-symbols.c: Update.
2317         * compile/compile-cplus-symbols.c: Update.
2318         * compile/compile-object-load.c: Update.
2319         * compile/compile-object-run.c: Update.
2320         * completer.c: Update.
2321         * corelow.c: Update.
2322         * cp-abi.c: Update.
2323         * cp-support.c: Update.
2324         * cp-valprint.c: Update.
2325         * darwin-nat.c: Update.
2326         * disasm-selftests.c: Update.
2327         * dtrace-probe.c: Update.
2328         * dwarf-index-cache.c: Update.
2329         * dwarf-index-write.c: Update.
2330         * dwarf2-frame-tailcall.c: Update.
2331         * dwarf2-frame.c: Update.
2332         * dwarf2loc.c: Update.
2333         * dwarf2read.c: Update.
2334         * eval.c: Update.
2335         * event-loop.c: Update.
2336         * event-top.c: Update.
2337         * exec.c: Update.
2338         * f-valprint.c: Update.
2339         * fbsd-tdep.c: Update.
2340         * frame-unwind.c: Update.
2341         * frame.c: Update.
2342         * gdbtypes.c: Update.
2343         * gnu-v3-abi.c: Update.
2344         * guile/guile-internal.h: Update.
2345         * guile/scm-block.c: Update.
2346         * guile/scm-breakpoint.c: Update.
2347         * guile/scm-cmd.c: Update.
2348         * guile/scm-disasm.c: Update.
2349         * guile/scm-frame.c: Update.
2350         * guile/scm-lazy-string.c: Update.
2351         * guile/scm-math.c: Update.
2352         * guile/scm-param.c: Update.
2353         * guile/scm-ports.c: Update.
2354         * guile/scm-pretty-print.c: Update.
2355         * guile/scm-symbol.c: Update.
2356         * guile/scm-symtab.c: Update.
2357         * guile/scm-type.c: Update.
2358         * guile/scm-value.c: Update.
2359         * i386-linux-tdep.c: Update.
2360         * i386-tdep.c: Update.
2361         * inf-loop.c: Update.
2362         * infcall.c: Update.
2363         * infcmd.c: Update.
2364         * infrun.c: Update.
2365         * jit.c: Update.
2366         * language.c: Update.
2367         * linespec.c: Update.
2368         * linux-fork.c: Update.
2369         * linux-nat.c: Update.
2370         * linux-tdep.c: Update.
2371         * linux-thread-db.c: Update.
2372         * main.c: Update.
2373         * mi/mi-cmd-break.c: Update.
2374         * mi/mi-cmd-stack.c: Update.
2375         * mi/mi-interp.c: Update.
2376         * mi/mi-main.c: Update.
2377         * objc-lang.c: Update.
2378         * p-valprint.c: Update.
2379         * parse.c: Update.
2380         * ppc-linux-tdep.c: Update.
2381         * printcmd.c: Update.
2382         * python/py-arch.c: Update.
2383         * python/py-breakpoint.c: Update.
2384         * python/py-cmd.c: Update.
2385         * python/py-finishbreakpoint.c: Update.
2386         * python/py-frame.c: Update.
2387         * python/py-framefilter.c: Update.
2388         * python/py-gdb-readline.c: Update.
2389         * python/py-inferior.c: Update.
2390         * python/py-infthread.c: Update.
2391         * python/py-lazy-string.c: Update.
2392         * python/py-linetable.c: Update.
2393         * python/py-objfile.c: Update.
2394         * python/py-param.c: Update.
2395         * python/py-prettyprint.c: Update.
2396         * python/py-progspace.c: Update.
2397         * python/py-record-btrace.c: Update.
2398         * python/py-record.c: Update.
2399         * python/py-symbol.c: Update.
2400         * python/py-type.c: Update.
2401         * python/py-unwind.c: Update.
2402         * python/py-utils.c: Update.
2403         * python/py-value.c: Update.
2404         * python/python.c: Update.
2405         * record-btrace.c: Update.
2406         * record-full.c: Update.
2407         * remote-fileio.c: Update.
2408         * remote.c: Update.
2409         * riscv-tdep.c: Update.
2410         * rs6000-aix-tdep.c: Update.
2411         * rs6000-tdep.c: Update.
2412         * rust-exp.y: Update.
2413         * rust-lang.c: Update.
2414         * s390-tdep.c: Update.
2415         * selftest-arch.c: Update.
2416         * solib-dsbt.c: Update.
2417         * solib-frv.c: Update.
2418         * solib-spu.c: Update.
2419         * solib-svr4.c: Update.
2420         * solib.c: Update.
2421         * sparc64-linux-tdep.c: Update.
2422         * stack.c: Update.
2423         * symfile-mem.c: Update.
2424         * symmisc.c: Update.
2425         * target.c: Update.
2426         * thread.c: Update.
2427         * top.c: Update.
2428         * tracefile-tfile.c: Update.
2429         * tui/tui.c: Update.
2430         * typeprint.c: Update.
2431         * unittests/cli-utils-selftests.c: Update.
2432         * unittests/parse-connection-spec-selftests.c: Update.
2433         * valops.c: Update.
2434         * valprint.c: Update.
2435         * value.c: Update.
2436         * varobj.c: Update.
2437         * windows-nat.c: Update.
2438         * x86-linux-nat.c: Update.
2439         * xml-support.c: Update.
2440
2441 2019-04-08  Tom Tromey  <tom@tromey.com>
2442
2443         * xml-support.c: Use C++ exception handling.
2444         * x86-linux-nat.c: Use C++ exception handling.
2445         * windows-nat.c: Use C++ exception handling.
2446         * varobj.c: Use C++ exception handling.
2447         * value.c: Use C++ exception handling.
2448         * valprint.c: Use C++ exception handling.
2449         * valops.c: Use C++ exception handling.
2450         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2451         handling.
2452         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2453         * typeprint.c: Use C++ exception handling.
2454         * tui/tui.c: Use C++ exception handling.
2455         * tracefile-tfile.c: Use C++ exception handling.
2456         * top.c: Use C++ exception handling.
2457         * thread.c: Use C++ exception handling.
2458         * target.c: Use C++ exception handling.
2459         * symmisc.c: Use C++ exception handling.
2460         * symfile-mem.c: Use C++ exception handling.
2461         * stack.c: Use C++ exception handling.
2462         * sparc64-linux-tdep.c: Use C++ exception handling.
2463         * solib.c: Use C++ exception handling.
2464         * solib-svr4.c: Use C++ exception handling.
2465         * solib-spu.c: Use C++ exception handling.
2466         * solib-frv.c: Use C++ exception handling.
2467         * solib-dsbt.c: Use C++ exception handling.
2468         * selftest-arch.c: Use C++ exception handling.
2469         * s390-tdep.c: Use C++ exception handling.
2470         * rust-lang.c: Use C++ exception handling.
2471         * rust-exp.y: Use C++ exception handling.
2472         * rs6000-tdep.c: Use C++ exception handling.
2473         * rs6000-aix-tdep.c: Use C++ exception handling.
2474         * riscv-tdep.c: Use C++ exception handling.
2475         * remote.c: Use C++ exception handling.
2476         * remote-fileio.c: Use C++ exception handling.
2477         * record-full.c: Use C++ exception handling.
2478         * record-btrace.c: Use C++ exception handling.
2479         * python/python.c: Use C++ exception handling.
2480         * python/py-value.c: Use C++ exception handling.
2481         * python/py-utils.c: Use C++ exception handling.
2482         * python/py-unwind.c: Use C++ exception handling.
2483         * python/py-type.c: Use C++ exception handling.
2484         * python/py-symbol.c: Use C++ exception handling.
2485         * python/py-record.c: Use C++ exception handling.
2486         * python/py-record-btrace.c: Use C++ exception handling.
2487         * python/py-progspace.c: Use C++ exception handling.
2488         * python/py-prettyprint.c: Use C++ exception handling.
2489         * python/py-param.c: Use C++ exception handling.
2490         * python/py-objfile.c: Use C++ exception handling.
2491         * python/py-linetable.c: Use C++ exception handling.
2492         * python/py-lazy-string.c: Use C++ exception handling.
2493         * python/py-infthread.c: Use C++ exception handling.
2494         * python/py-inferior.c: Use C++ exception handling.
2495         * python/py-gdb-readline.c: Use C++ exception handling.
2496         * python/py-framefilter.c: Use C++ exception handling.
2497         * python/py-frame.c: Use C++ exception handling.
2498         * python/py-finishbreakpoint.c: Use C++ exception handling.
2499         * python/py-cmd.c: Use C++ exception handling.
2500         * python/py-breakpoint.c: Use C++ exception handling.
2501         * python/py-arch.c: Use C++ exception handling.
2502         * printcmd.c: Use C++ exception handling.
2503         * ppc-linux-tdep.c: Use C++ exception handling.
2504         * parse.c: Use C++ exception handling.
2505         * p-valprint.c: Use C++ exception handling.
2506         * objc-lang.c: Use C++ exception handling.
2507         * mi/mi-main.c: Use C++ exception handling.
2508         * mi/mi-interp.c: Use C++ exception handling.
2509         * mi/mi-cmd-stack.c: Use C++ exception handling.
2510         * mi/mi-cmd-break.c: Use C++ exception handling.
2511         * main.c: Use C++ exception handling.
2512         * linux-thread-db.c: Use C++ exception handling.
2513         * linux-tdep.c: Use C++ exception handling.
2514         * linux-nat.c: Use C++ exception handling.
2515         * linux-fork.c: Use C++ exception handling.
2516         * linespec.c: Use C++ exception handling.
2517         * language.c: Use C++ exception handling.
2518         * jit.c: Use C++ exception handling.
2519         * infrun.c: Use C++ exception handling.
2520         * infcmd.c: Use C++ exception handling.
2521         * infcall.c: Use C++ exception handling.
2522         * inf-loop.c: Use C++ exception handling.
2523         * i386-tdep.c: Use C++ exception handling.
2524         * i386-linux-tdep.c: Use C++ exception handling.
2525         * guile/scm-value.c: Use C++ exception handling.
2526         * guile/scm-type.c: Use C++ exception handling.
2527         * guile/scm-symtab.c: Use C++ exception handling.
2528         * guile/scm-symbol.c: Use C++ exception handling.
2529         * guile/scm-pretty-print.c: Use C++ exception handling.
2530         * guile/scm-ports.c: Use C++ exception handling.
2531         * guile/scm-param.c: Use C++ exception handling.
2532         * guile/scm-math.c: Use C++ exception handling.
2533         * guile/scm-lazy-string.c: Use C++ exception handling.
2534         * guile/scm-frame.c: Use C++ exception handling.
2535         * guile/scm-disasm.c: Use C++ exception handling.
2536         * guile/scm-cmd.c: Use C++ exception handling.
2537         * guile/scm-breakpoint.c: Use C++ exception handling.
2538         * guile/scm-block.c: Use C++ exception handling.
2539         * guile/guile-internal.h: Use C++ exception handling.
2540         * gnu-v3-abi.c: Use C++ exception handling.
2541         * gdbtypes.c: Use C++ exception handling.
2542         * frame.c: Use C++ exception handling.
2543         * frame-unwind.c: Use C++ exception handling.
2544         * fbsd-tdep.c: Use C++ exception handling.
2545         * f-valprint.c: Use C++ exception handling.
2546         * exec.c: Use C++ exception handling.
2547         * event-top.c: Use C++ exception handling.
2548         * event-loop.c: Use C++ exception handling.
2549         * eval.c: Use C++ exception handling.
2550         * dwarf2read.c: Use C++ exception handling.
2551         * dwarf2loc.c: Use C++ exception handling.
2552         * dwarf2-frame.c: Use C++ exception handling.
2553         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2554         * dwarf-index-write.c: Use C++ exception handling.
2555         * dwarf-index-cache.c: Use C++ exception handling.
2556         * dtrace-probe.c: Use C++ exception handling.
2557         * disasm-selftests.c: Use C++ exception handling.
2558         * darwin-nat.c: Use C++ exception handling.
2559         * cp-valprint.c: Use C++ exception handling.
2560         * cp-support.c: Use C++ exception handling.
2561         * cp-abi.c: Use C++ exception handling.
2562         * corelow.c: Use C++ exception handling.
2563         * completer.c: Use C++ exception handling.
2564         * compile/compile-object-run.c: Use C++ exception handling.
2565         * compile/compile-object-load.c: Use C++ exception handling.
2566         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2567         * compile/compile-c-symbols.c: Use C++ exception handling.
2568         * common/selftest.c: Use C++ exception handling.
2569         * common/new-op.c: Use C++ exception handling.
2570         * cli/cli-script.c: Use C++ exception handling.
2571         * cli/cli-interp.c: Use C++ exception handling.
2572         * cli/cli-cmds.c: Use C++ exception handling.
2573         * c-varobj.c: Use C++ exception handling.
2574         * btrace.c: Use C++ exception handling.
2575         * breakpoint.c: Use C++ exception handling.
2576         * break-catch-throw.c: Use C++ exception handling.
2577         * arch-utils.c: Use C++ exception handling.
2578         * amd64-tdep.c: Use C++ exception handling.
2579         * ada-valprint.c: Use C++ exception handling.
2580         * ada-typeprint.c: Use C++ exception handling.
2581         * ada-lang.c: Use C++ exception handling.
2582         * aarch64-tdep.c: Use C++ exception handling.
2583
2584 2019-04-08  Tom Tromey  <tom@tromey.com>
2585
2586         * xml-support.c (gdb_xml_parser::parse): Update.
2587         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2588         * value.c (show_convenience): Update.
2589         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2590         (test_parse_flags_qcs): Update.
2591         * thread.c (thr_try_catch_cmd): Update.
2592         * target.c (target_translate_tls_address): Update.
2593         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2594         (info_frame_command_core, frame_apply_command_count): Update.
2595         * rust-exp.y (rust_lex_exception_test): Update.
2596         * riscv-tdep.c (riscv_print_one_register_info): Update.
2597         * remote.c (remote_target::enable_btrace): Update.
2598         * record-btrace.c (record_btrace_enable_warn): Update.
2599         * python/py-utils.c (gdbpy_convert_exception): Update.
2600         * printcmd.c (do_one_display, print_variable_and_value): Update.
2601         * mi/mi-main.c (mi_print_exception): Update.
2602         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2603         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2604         * linux-nat.c (linux_nat_target::attach): Update.
2605         * linux-fork.c (class scoped_switch_fork_info): Update.
2606         * infrun.c (displaced_step_prepare): Update.
2607         * infcall.c (call_function_by_hand_dummy): Update.
2608         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2609         * gnu-v3-abi.c (print_one_vtable): Update.
2610         * frame.c (get_prev_frame_always): Update.
2611         * f-valprint.c (info_common_command_for_block): Update.
2612         * exec.c (try_open_exec_file): Update.
2613         * exceptions.c (print_exception, exception_print)
2614         (exception_fprintf, exception_print_same): Update.
2615         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2616         * dwarf-index-cache.c (index_cache::store)
2617         (index_cache::lookup_gdb_index): Update.
2618         * darwin-nat.c (maybe_cache_shell): Update.
2619         * cp-valprint.c (cp_print_value_fields): Update.
2620         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2621         (gcc_cplus_symbol_address): Update.
2622         * compile/compile-c-symbols.c (gcc_convert_symbol)
2623         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2624         * common/selftest.c: Update.
2625         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2626         a std::string.
2627         (exception_try_scope_entry, exception_try_scope_exit): Don't
2628         declare.
2629         (struct exception_try_scope): Remove.
2630         (TRY): Don't use exception_try_scope.
2631         (struct gdb_exception): Add constructor, operator=.
2632         <what>: New method.
2633         (struct gdb_exception_RETURN_MASK_ALL)
2634         (struct gdb_exception_RETURN_MASK_ERROR)
2635         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2636         (struct gdb_quit_bad_alloc): Update.
2637         * common/common-exceptions.c (exception_none): Change
2638         initializer.
2639         (struct catcher) <state, exception>: Initialize inline.
2640         <prev>: Remove member.
2641         (current_catcher): Remove.
2642         (catchers): New global.
2643         (exceptions_state_mc_init): Simplify.
2644         (catcher_pop): Remove.
2645         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2646         (try_scope_depth, exception_try_scope_entry)
2647         (exception_try_scope_exit): Remove.
2648         (throw_exception_sjlj): Update.
2649         (exception_messages, exception_messages_size): Remove.
2650         (throw_it): Simplify.
2651         (gdb_exception_sliced_copy): Remove.
2652         (throw_exception_cxx): Update.
2653         * cli/cli-script.c (script_from_file): Update.
2654         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2655         Update.
2656         * ada-valprint.c (ada_val_print): Update.
2657         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2658         (create_excep_cond_exprs): Update.
2659
2660 2019-04-08  Tom Tromey  <tom@tromey.com>
2661
2662         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2663         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2664         (TRY, CATCH, END_CATCH): Remove some definitions.
2665         * common/common-exceptions.c: Don't use GDB_XCPT.
2666         (catcher_list_size): Remove.
2667         (throw_exception, throw_it): Simplify.
2668
2669 2019-04-05  Tom Tromey  <tom@tromey.com>
2670
2671         Revert the header-sorting patch.
2672         * ft32-tdep.c: Revert.
2673         * frv-tdep.c: Revert.
2674         * frv-linux-tdep.c: Revert.
2675         * frame.c: Revert.
2676         * frame-unwind.c: Revert.
2677         * frame-base.c: Revert.
2678         * fork-child.c: Revert.
2679         * findvar.c: Revert.
2680         * findcmd.c: Revert.
2681         * filesystem.c: Revert.
2682         * filename-seen-cache.h: Revert.
2683         * filename-seen-cache.c: Revert.
2684         * fbsd-tdep.c: Revert.
2685         * fbsd-nat.h: Revert.
2686         * fbsd-nat.c: Revert.
2687         * f-valprint.c: Revert.
2688         * f-typeprint.c: Revert.
2689         * f-lang.c: Revert.
2690         * extension.h: Revert.
2691         * extension.c: Revert.
2692         * extension-priv.h: Revert.
2693         * expprint.c: Revert.
2694         * exec.h: Revert.
2695         * exec.c: Revert.
2696         * exceptions.c: Revert.
2697         * event-top.c: Revert.
2698         * event-loop.c: Revert.
2699         * eval.c: Revert.
2700         * elfread.c: Revert.
2701         * dwarf2read.h: Revert.
2702         * dwarf2read.c: Revert.
2703         * dwarf2loc.c: Revert.
2704         * dwarf2expr.h: Revert.
2705         * dwarf2expr.c: Revert.
2706         * dwarf2-frame.c: Revert.
2707         * dwarf2-frame-tailcall.c: Revert.
2708         * dwarf-index-write.h: Revert.
2709         * dwarf-index-write.c: Revert.
2710         * dwarf-index-common.c: Revert.
2711         * dwarf-index-cache.h: Revert.
2712         * dwarf-index-cache.c: Revert.
2713         * dummy-frame.c: Revert.
2714         * dtrace-probe.c: Revert.
2715         * disasm.h: Revert.
2716         * disasm.c: Revert.
2717         * disasm-selftests.c: Revert.
2718         * dictionary.c: Revert.
2719         * dicos-tdep.c: Revert.
2720         * demangle.c: Revert.
2721         * dcache.h: Revert.
2722         * dcache.c: Revert.
2723         * darwin-nat.h: Revert.
2724         * darwin-nat.c: Revert.
2725         * darwin-nat-info.c: Revert.
2726         * d-valprint.c: Revert.
2727         * d-namespace.c: Revert.
2728         * d-lang.c: Revert.
2729         * ctf.c: Revert.
2730         * csky-tdep.c: Revert.
2731         * csky-linux-tdep.c: Revert.
2732         * cris-tdep.c: Revert.
2733         * cris-linux-tdep.c: Revert.
2734         * cp-valprint.c: Revert.
2735         * cp-support.c: Revert.
2736         * cp-namespace.c: Revert.
2737         * cp-abi.c: Revert.
2738         * corelow.c: Revert.
2739         * corefile.c: Revert.
2740         * continuations.c: Revert.
2741         * completer.h: Revert.
2742         * completer.c: Revert.
2743         * complaints.c: Revert.
2744         * coffread.c: Revert.
2745         * coff-pe-read.c: Revert.
2746         * cli-out.h: Revert.
2747         * cli-out.c: Revert.
2748         * charset.c: Revert.
2749         * c-varobj.c: Revert.
2750         * c-valprint.c: Revert.
2751         * c-typeprint.c: Revert.
2752         * c-lang.c: Revert.
2753         * buildsym.c: Revert.
2754         * buildsym-legacy.c: Revert.
2755         * build-id.h: Revert.
2756         * build-id.c: Revert.
2757         * btrace.c: Revert.
2758         * bsd-uthread.c: Revert.
2759         * breakpoint.h: Revert.
2760         * breakpoint.c: Revert.
2761         * break-catch-throw.c: Revert.
2762         * break-catch-syscall.c: Revert.
2763         * break-catch-sig.c: Revert.
2764         * blockframe.c: Revert.
2765         * block.c: Revert.
2766         * bfin-tdep.c: Revert.
2767         * bfin-linux-tdep.c: Revert.
2768         * bfd-target.c: Revert.
2769         * bcache.c: Revert.
2770         * ax-general.c: Revert.
2771         * ax-gdb.h: Revert.
2772         * ax-gdb.c: Revert.
2773         * avr-tdep.c: Revert.
2774         * auxv.c: Revert.
2775         * auto-load.c: Revert.
2776         * arm-wince-tdep.c: Revert.
2777         * arm-tdep.c: Revert.
2778         * arm-symbian-tdep.c: Revert.
2779         * arm-pikeos-tdep.c: Revert.
2780         * arm-obsd-tdep.c: Revert.
2781         * arm-nbsd-tdep.c: Revert.
2782         * arm-nbsd-nat.c: Revert.
2783         * arm-linux-tdep.c: Revert.
2784         * arm-linux-nat.c: Revert.
2785         * arm-fbsd-tdep.c: Revert.
2786         * arm-fbsd-nat.c: Revert.
2787         * arm-bsd-tdep.c: Revert.
2788         * arch-utils.c: Revert.
2789         * arc-tdep.c: Revert.
2790         * arc-newlib-tdep.c: Revert.
2791         * annotate.h: Revert.
2792         * annotate.c: Revert.
2793         * amd64-windows-tdep.c: Revert.
2794         * amd64-windows-nat.c: Revert.
2795         * amd64-tdep.c: Revert.
2796         * amd64-sol2-tdep.c: Revert.
2797         * amd64-obsd-tdep.c: Revert.
2798         * amd64-obsd-nat.c: Revert.
2799         * amd64-nbsd-tdep.c: Revert.
2800         * amd64-nbsd-nat.c: Revert.
2801         * amd64-nat.c: Revert.
2802         * amd64-linux-tdep.c: Revert.
2803         * amd64-linux-nat.c: Revert.
2804         * amd64-fbsd-tdep.c: Revert.
2805         * amd64-fbsd-nat.c: Revert.
2806         * amd64-dicos-tdep.c: Revert.
2807         * amd64-darwin-tdep.c: Revert.
2808         * amd64-bsd-nat.c: Revert.
2809         * alpha-tdep.c: Revert.
2810         * alpha-obsd-tdep.c: Revert.
2811         * alpha-nbsd-tdep.c: Revert.
2812         * alpha-mdebug-tdep.c: Revert.
2813         * alpha-linux-tdep.c: Revert.
2814         * alpha-linux-nat.c: Revert.
2815         * alpha-bsd-tdep.c: Revert.
2816         * alpha-bsd-nat.c: Revert.
2817         * aix-thread.c: Revert.
2818         * agent.c: Revert.
2819         * addrmap.c: Revert.
2820         * ada-varobj.c: Revert.
2821         * ada-valprint.c: Revert.
2822         * ada-typeprint.c: Revert.
2823         * ada-tasks.c: Revert.
2824         * ada-lang.c: Revert.
2825         * aarch64-tdep.c: Revert.
2826         * aarch64-ravenscar-thread.c: Revert.
2827         * aarch64-newlib-tdep.c: Revert.
2828         * aarch64-linux-tdep.c: Revert.
2829         * aarch64-linux-nat.c: Revert.
2830         * aarch64-fbsd-tdep.c: Revert.
2831         * aarch64-fbsd-nat.c: Revert.
2832         * aarch32-linux-nat.c: Revert.
2833
2834 2019-04-05  Tom Tromey  <tom@tromey.com>
2835
2836         * ft32-tdep.c: Sort headers.
2837         * frv-tdep.c: Sort headers.
2838         * frv-linux-tdep.c: Sort headers.
2839         * frame.c: Sort headers.
2840         * frame-unwind.c: Sort headers.
2841         * frame-base.c: Sort headers.
2842         * fork-child.c: Sort headers.
2843         * findvar.c: Sort headers.
2844         * findcmd.c: Sort headers.
2845         * filesystem.c: Sort headers.
2846         * filename-seen-cache.h: Sort headers.
2847         * filename-seen-cache.c: Sort headers.
2848         * fbsd-tdep.c: Sort headers.
2849         * fbsd-nat.h: Sort headers.
2850         * fbsd-nat.c: Sort headers.
2851         * f-valprint.c: Sort headers.
2852         * f-typeprint.c: Sort headers.
2853         * f-lang.c: Sort headers.
2854         * extension.h: Sort headers.
2855         * extension.c: Sort headers.
2856         * extension-priv.h: Sort headers.
2857         * expprint.c: Sort headers.
2858         * exec.h: Sort headers.
2859         * exec.c: Sort headers.
2860         * exceptions.c: Sort headers.
2861         * event-top.c: Sort headers.
2862         * event-loop.c: Sort headers.
2863         * eval.c: Sort headers.
2864         * elfread.c: Sort headers.
2865         * dwarf2read.h: Sort headers.
2866         * dwarf2read.c: Sort headers.
2867         * dwarf2loc.c: Sort headers.
2868         * dwarf2expr.h: Sort headers.
2869         * dwarf2expr.c: Sort headers.
2870         * dwarf2-frame.c: Sort headers.
2871         * dwarf2-frame-tailcall.c: Sort headers.
2872         * dwarf-index-write.h: Sort headers.
2873         * dwarf-index-write.c: Sort headers.
2874         * dwarf-index-common.c: Sort headers.
2875         * dwarf-index-cache.h: Sort headers.
2876         * dwarf-index-cache.c: Sort headers.
2877         * dummy-frame.c: Sort headers.
2878         * dtrace-probe.c: Sort headers.
2879         * disasm.h: Sort headers.
2880         * disasm.c: Sort headers.
2881         * disasm-selftests.c: Sort headers.
2882         * dictionary.c: Sort headers.
2883         * dicos-tdep.c: Sort headers.
2884         * demangle.c: Sort headers.
2885         * dcache.h: Sort headers.
2886         * dcache.c: Sort headers.
2887         * darwin-nat.h: Sort headers.
2888         * darwin-nat.c: Sort headers.
2889         * darwin-nat-info.c: Sort headers.
2890         * d-valprint.c: Sort headers.
2891         * d-namespace.c: Sort headers.
2892         * d-lang.c: Sort headers.
2893         * ctf.c: Sort headers.
2894         * csky-tdep.c: Sort headers.
2895         * csky-linux-tdep.c: Sort headers.
2896         * cris-tdep.c: Sort headers.
2897         * cris-linux-tdep.c: Sort headers.
2898         * cp-valprint.c: Sort headers.
2899         * cp-support.c: Sort headers.
2900         * cp-namespace.c: Sort headers.
2901         * cp-abi.c: Sort headers.
2902         * corelow.c: Sort headers.
2903         * corefile.c: Sort headers.
2904         * continuations.c: Sort headers.
2905         * completer.h: Sort headers.
2906         * completer.c: Sort headers.
2907         * complaints.c: Sort headers.
2908         * coffread.c: Sort headers.
2909         * coff-pe-read.c: Sort headers.
2910         * cli-out.h: Sort headers.
2911         * cli-out.c: Sort headers.
2912         * charset.c: Sort headers.
2913         * c-varobj.c: Sort headers.
2914         * c-valprint.c: Sort headers.
2915         * c-typeprint.c: Sort headers.
2916         * c-lang.c: Sort headers.
2917         * buildsym.c: Sort headers.
2918         * buildsym-legacy.c: Sort headers.
2919         * build-id.h: Sort headers.
2920         * build-id.c: Sort headers.
2921         * btrace.c: Sort headers.
2922         * bsd-uthread.c: Sort headers.
2923         * breakpoint.h: Sort headers.
2924         * breakpoint.c: Sort headers.
2925         * break-catch-throw.c: Sort headers.
2926         * break-catch-syscall.c: Sort headers.
2927         * break-catch-sig.c: Sort headers.
2928         * blockframe.c: Sort headers.
2929         * block.c: Sort headers.
2930         * bfin-tdep.c: Sort headers.
2931         * bfin-linux-tdep.c: Sort headers.
2932         * bfd-target.c: Sort headers.
2933         * bcache.c: Sort headers.
2934         * ax-general.c: Sort headers.
2935         * ax-gdb.h: Sort headers.
2936         * ax-gdb.c: Sort headers.
2937         * avr-tdep.c: Sort headers.
2938         * auxv.c: Sort headers.
2939         * auto-load.c: Sort headers.
2940         * arm-wince-tdep.c: Sort headers.
2941         * arm-tdep.c: Sort headers.
2942         * arm-symbian-tdep.c: Sort headers.
2943         * arm-pikeos-tdep.c: Sort headers.
2944         * arm-obsd-tdep.c: Sort headers.
2945         * arm-nbsd-tdep.c: Sort headers.
2946         * arm-nbsd-nat.c: Sort headers.
2947         * arm-linux-tdep.c: Sort headers.
2948         * arm-linux-nat.c: Sort headers.
2949         * arm-fbsd-tdep.c: Sort headers.
2950         * arm-fbsd-nat.c: Sort headers.
2951         * arm-bsd-tdep.c: Sort headers.
2952         * arch-utils.c: Sort headers.
2953         * arc-tdep.c: Sort headers.
2954         * arc-newlib-tdep.c: Sort headers.
2955         * annotate.h: Sort headers.
2956         * annotate.c: Sort headers.
2957         * amd64-windows-tdep.c: Sort headers.
2958         * amd64-windows-nat.c: Sort headers.
2959         * amd64-tdep.c: Sort headers.
2960         * amd64-sol2-tdep.c: Sort headers.
2961         * amd64-obsd-tdep.c: Sort headers.
2962         * amd64-obsd-nat.c: Sort headers.
2963         * amd64-nbsd-tdep.c: Sort headers.
2964         * amd64-nbsd-nat.c: Sort headers.
2965         * amd64-nat.c: Sort headers.
2966         * amd64-linux-tdep.c: Sort headers.
2967         * amd64-linux-nat.c: Sort headers.
2968         * amd64-fbsd-tdep.c: Sort headers.
2969         * amd64-fbsd-nat.c: Sort headers.
2970         * amd64-dicos-tdep.c: Sort headers.
2971         * amd64-darwin-tdep.c: Sort headers.
2972         * amd64-bsd-nat.c: Sort headers.
2973         * alpha-tdep.c: Sort headers.
2974         * alpha-obsd-tdep.c: Sort headers.
2975         * alpha-nbsd-tdep.c: Sort headers.
2976         * alpha-mdebug-tdep.c: Sort headers.
2977         * alpha-linux-tdep.c: Sort headers.
2978         * alpha-linux-nat.c: Sort headers.
2979         * alpha-bsd-tdep.c: Sort headers.
2980         * alpha-bsd-nat.c: Sort headers.
2981         * aix-thread.c: Sort headers.
2982         * agent.c: Sort headers.
2983         * addrmap.c: Sort headers.
2984         * ada-varobj.c: Sort headers.
2985         * ada-valprint.c: Sort headers.
2986         * ada-typeprint.c: Sort headers.
2987         * ada-tasks.c: Sort headers.
2988         * ada-lang.c: Sort headers.
2989         * aarch64-tdep.c: Sort headers.
2990         * aarch64-ravenscar-thread.c: Sort headers.
2991         * aarch64-newlib-tdep.c: Sort headers.
2992         * aarch64-linux-tdep.c: Sort headers.
2993         * aarch64-linux-nat.c: Sort headers.
2994         * aarch64-fbsd-tdep.c: Sort headers.
2995         * aarch64-fbsd-nat.c: Sort headers.
2996         * aarch32-linux-nat.c: Sort headers.
2997
2998 2019-04-04  Tom Tromey  <tom@tromey.com>
2999
3000         * varobj.c (varobj_create): Update.
3001         * rust-exp.y (struct rust_parser) <update_innermost_block,
3002         lookup_symbol>: New methods.
3003         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3004         Rename.
3005         (rust_parser::rust_lookup_type)
3006         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3007         * printcmd.c (display_command, do_one_display): Update.
3008         * parser-defs.h (struct parser_state) <parser_state>: Add
3009         "tracker" parameter.
3010         (block_tracker): New member.
3011         (class innermost_block_tracker) <innermost_block_tracker>: Add
3012         "types" parameter.
3013         <reset>: Remove method.
3014         (innermost_block): Don't declare.
3015         (null_post_parser): Update.
3016         * parse.c (innermost_block): Remove global.
3017         (write_dollar_variable): Update.
3018         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3019         Remove "tracker_types" parameter.
3020         (parse_expression): Add "tracker" parameter.
3021         (parse_expression_for_completion): Update.
3022         (null_post_parser): Add "tracker" parameter.
3023         * p-exp.y: Update rules.
3024         * m2-exp.y: Update rules.
3025         * language.h (struct language_defn) <la_post_parser>: Add
3026         "tracker" parameter.
3027         * go-exp.y: Update rules.
3028         * f-exp.y: Update rules.
3029         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3030         parameter.
3031         * d-exp.y: Update rules.
3032         * c-exp.y: Update rules.
3033         * breakpoint.c (set_breakpoint_condition): Create an
3034         innermost_block_tracker.
3035         (watch_command_1): Likewise.
3036         * ada-lang.c (resolve): Add "tracker" parameter.
3037         (resolve_subexp): Likewise.
3038         * ada-exp.y (write_var_from_sym): Update.
3039
3040 2019-04-04  Tom Tromey  <tom@tromey.com>
3041
3042         * type-stack.h: New file.
3043         * type-stack.c: New file.
3044         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3045         type-stack.h.
3046         (insert_into_type_stack, insert_type, push_type, push_type_int)
3047         (insert_type_address_space, pop_type, pop_type_int)
3048         (pop_typelist, pop_type_stack, append_type_stack)
3049         (push_type_stack, get_type_stack, push_typelist)
3050         (follow_type_instance_flags, follow_types): Don't declare.
3051         * parse.c (type_stack): Remove global.
3052         (parse_exp_in_context): Update.
3053         (insert_into_type_stack, insert_type, push_type, push_type_int)
3054         (insert_type_address_space, pop_type, pop_type_int)
3055         (pop_typelist, pop_type_stack, append_type_stack)
3056         (push_type_stack, get_type_stack, push_typelist)
3057         (follow_type_instance_flags, follow_types): Remove (moved to
3058         type-stack.c).
3059         * f-exp.y (type_stack): New global.
3060         Update rules.
3061         (push_kind_type, f_parse): Update.
3062         * d-exp.y (type_stack): New global.
3063         Update rules.
3064         (d_parse): Update.
3065         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3066         Update rules.
3067         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3068         (HFILES_NO_SRCDIR): Add type-stack.h.
3069
3070 2019-04-04  Tom Tromey  <tom@tromey.com>
3071
3072         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3073         (rust_parser::convert_ast_to_expression, rust_parse)
3074         (rust_lex_test_completion, rust_lex_tests): Update.
3075         * parser-defs.h (struct expr_completion_state): New.
3076         (struct parser_state) <parser_state>: Add completion parameter.
3077         <mark_struct_expression, mark_completion_tag>: New methods.
3078         <parse_completion, m_completion_state>: New members.
3079         (prefixify_expression, null_post_parser): Update.
3080         (mark_struct_expression, mark_completion_tag): Don't declare.
3081         * parse.c (parse_completion, expout_last_struct)
3082         (expout_tag_completion_type, expout_completion_name): Remove
3083         globals.
3084         (parser_state::mark_struct_expression)
3085         (parser_state::mark_completion_tag): Now methods.
3086         (prefixify_expression): Add last_struct parameter.
3087         (prefixify_subexp): Likewise.
3088         (parse_exp_1): Update.
3089         (parse_exp_in_context): Add cstate parameter.  Update.
3090         (parse_expression_for_completion): Create an
3091         expr_completion_state.
3092         (null_post_parser): Add "completion" parameter.
3093         * p-exp.y: Update rules.
3094         (yylex): Update.
3095         * language.h (struct language_defn) <la_post_parser>: Add
3096         "completing" parameter.
3097         * go-exp.y: Update rules.
3098         (lex_one_token): Update.
3099         * expression.h (parse_completion): Don't declare.
3100         * d-exp.y: Update rules.
3101         (lex_one_token): Update rules.
3102         * c-exp.y: Update rules.
3103         (lex_one_token): Update.
3104         * ada-lang.c (resolve): Add "parse_completion" parameter.
3105         (resolve_subexp): Likewise.
3106         (ada_resolve_function): Likewise.
3107
3108 2019-04-04  Tom Tromey  <tom@tromey.com>
3109
3110         * parser-defs.h (struct parser_state) <start_arglist,
3111         end_arglist>: New methods.
3112         <arglist_len, m_funcall_chain>: New members.
3113         (arglist_len, start_arglist, end_arglist): Don't declare.
3114         * parse.c (arglist_len, funcall_chain): Remove global.
3115         (start_arglist, end_arglist): Remove functions.
3116         (parse_exp_in_context): Update.
3117         * p-exp.y: Update rules.
3118         * m2-exp.y: Update rules.
3119         * go-exp.y: Update rules.
3120         * f-exp.y: Update rules.
3121         * d-exp.y: Update rules.
3122         * c-exp.y: Update rules.
3123
3124 2019-04-04  Tom Tromey  <tom@tromey.com>
3125
3126         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3127         lex_operator, push_back>: New methods.
3128         Update all rules.
3129         (rust_parser::lex_hex, lex_escape): Rename and update.
3130         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3131         (rust_parser::lex_operator): Rename and update.
3132         (rust_parser::lex_number, rustyylex, rustyyerror)
3133         (rust_lex_test_init, rust_lex_test_sequence)
3134         (rust_lex_test_push_back, rust_lex_tests): Update.
3135         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3136         parameter.
3137         <lexptr, prev_lexptr>: New members.
3138         (lexptr, prev_lexptr): Don't declare.
3139         * parse.c (lexptr, prev_lexptr): Remove globals.
3140         (parse_exp_in_context): Update.
3141         * p-exp.y (yylex, yyerror): Update.
3142         * m2-exp.y (parse_number, yylex, yyerror): Update.
3143         * go-exp.y (lex_one_token, yyerror): Update.
3144         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3145         * d-exp.y (lex_one_token, yyerror): Update.
3146         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3147         (lex_one_token, yyerror): Update.
3148         * ada-lex.l (YY_INPUT): Update.
3149         (rewind_to_char): Update.
3150         * ada-exp.y (yyerror): Update.
3151
3152 2019-04-04  Tom Tromey  <tom@tromey.com>
3153
3154         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3155         * parser-defs.h (struct parser_state) <parser_state>: Add new
3156         parameter.
3157         <comma_terminates>: New member.
3158         (comma_terminates): Don't declare global.
3159         * parse.c (comma_terminates): Remove global.
3160         (parse_exp_in_context): Update.
3161         * p-exp.y (yylex): Update.
3162         * m2-exp.y (yylex): Update.
3163         * go-exp.y (lex_one_token): Update.
3164         * f-exp.y (yylex): Update.
3165         * d-exp.y (lex_one_token): Update.
3166         * c-exp.y (lex_one_token): Update.
3167         * ada-lex.l: Update.
3168
3169 2019-04-04  Tom Tromey  <tom@tromey.com>
3170
3171         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3172         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3173         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3174         * parser-defs.h (paren_depth): Don't declare.
3175         * parse.c (paren_depth): Remove global.
3176         (parse_exp_in_context): Update.
3177         * p-exp.y (paren_depth): New global.
3178         (pascal_parse): Initialize it.
3179         * m2-exp.y (paren_depth): New global.
3180         (m2_parse): Initialize it.
3181         * go-exp.y (paren_depth): New global.
3182         (go_parse): Initialize it.
3183         * f-exp.y (paren_depth): New global.
3184         (f_parse): Initialize it.
3185         * d-exp.y (paren_depth): New global.
3186         (d_parse): Initialize it.
3187         * c-exp.y (paren_depth): New global.
3188         (c_parse): Initialize it.
3189         * ada-lex.l (paren_depth): New global.
3190         (lexer_init): Initialize it.
3191
3192 2019-04-04  Tom Tromey  <tom@tromey.com>
3193
3194         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3195         (rust_parser::convert_ast_to_type)
3196         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3197         * parser-defs.h (struct parser_state) <parser_state>: Add
3198         parameters.  Initialize new members.
3199         <expression_context_block, expression_context_pc>: New members.
3200         * parse.c (expression_context_block, expression_context_pc):
3201         Remove globals.
3202         (parse_exp_in_context): Update.
3203         * p-exp.y: Update all rules.
3204         (yylex): Update.
3205         * m2-exp.y: Update all rules.
3206         (yylex): Update.
3207         * go-exp.y (yylex): Update.
3208         * f-exp.y (yylex): Update.
3209         * d-exp.y: Update all rules.
3210         (yylex): Update.
3211         * c-exp.y: Update all rules.
3212         (lex_one_token, classify_name, yylex, c_parse): Update.
3213         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3214
3215 2019-04-04  Tom Tromey  <tom@tromey.com>
3216
3217         * gdbarch.h, gdbarch.c: Rebuild.
3218         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3219         * stap-probe.h:
3220         (struct stap_parse_info): Replace "parser_state" with
3221         "expr_builder".
3222         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3223         (parser_state): New class.
3224         * parse.c (expr_builder): Rename.
3225         (expr_builder::release): Rename.
3226         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3227         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3228         (write_exp_elt_longcst, write_exp_elt_floatcst)
3229         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3230         (write_exp_string_vector, write_exp_bitstring)
3231         (write_exp_msymbol, mark_struct_expression)
3232         (write_dollar_variable)
3233         (insert_type_address_space, increase_expout_size): Replace
3234         "parser_state" with "expr_builder".
3235         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3236         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3237         "parser_state" with "expr_builder".
3238
3239 2019-04-04  Tom Tromey  <tom@tromey.com>
3240
3241         * rust-exp.y: Replace "parse_language" with method call.
3242         * p-exp.y:
3243         (yylex): Replace "parse_language" with method call.
3244         * m2-exp.y:
3245         (yylex): Replace "parse_language" with method call.
3246         * go-exp.y (classify_name): Replace "parse_language" with method
3247         call.
3248         * f-exp.y (yylex): Replace "parse_language" with method call.
3249         * d-exp.y (lex_one_token): Replace "parse_language" with method
3250         call.
3251         * c-exp.y:
3252         (lex_one_token, classify_name, yylex): Replace "parse_language"
3253         with method call.
3254         * ada-exp.y (find_primitive_type, type_char)
3255         (type_system_address): Replace "parse_language" with method call.
3256
3257 2019-04-04  Tom Tromey  <tom@tromey.com>
3258
3259         * rust-exp.y: Replace "parse_gdbarch" with method call.
3260         * parse.c (write_dollar_variable, insert_type_address_space):
3261         Replace "parse_gdbarch" with method call.
3262         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3263         call.
3264         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3265         call.
3266         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3267         "parse_gdbarch" with method call.
3268         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3269         with method call.
3270         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3271         "parse_gdbarch" with method call.
3272         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3273         "parse_gdbarch" with method call.
3274         * c-exp.y (parse_type, parse_number, classify_name): Replace
3275         "parse_gdbarch" with method call.
3276         * ada-lex.l: Replace "parse_gdbarch" with method call.
3277         * ada-exp.y (parse_type, find_primitive_type, type_char)
3278         (type_system_address): Replace "parse_gdbarch" with method call.
3279
3280 2019-04-04  Tom Tromey  <tom@tromey.com>
3281
3282         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3283         * stap-probe.c (stap_parse_argument): Update.
3284         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3285         initial_size parameter.
3286         * rust-exp.y (rust_lex_tests): Update.
3287         * parse.c (parser_state): Update.
3288         (parse_exp_in_context): Update.
3289         * parser-defs.h (struct parser_state) <parser_state>: Remove
3290         "initial_size" parameter.
3291
3292 2019-04-04  Tom Tromey  <tom@tromey.com>
3293
3294         * parser-defs.h (increase_expout_size): Don't declare.
3295         * parse.c (increase_expout_size): Now static.
3296
3297 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3298
3299         * gnu-nat.c (gnu_nat_target::wait): Fix
3300         target_waitstatus_to_string call.
3301
3302 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3303
3304         * eval.c (evaluate_subexp_standard): Handle internal functions
3305         during Fortran function call handling.
3306
3307 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3308
3309         * NEWS: Mention new internal functions.
3310         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3311         (read_base_type): Use dwarf2_init_complex_target_type.
3312         * value.c (creal_internal_fn): New function.
3313         (cimag_internal_fn): New function.
3314         (_initialize_values): Register new internal functions.
3315
3316 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3317
3318         * infrun.c (stop_all_threads): If debug_infrun, always
3319         trace the wait status after wait_one, using
3320         target_waitstatus_to_string and target_pid_to_str.
3321         (handle_inferior_event): Replace various trace of
3322         wait status kind by a single trace.
3323         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3324         wait status kind image by target_waitstatus_to_string.
3325         * target/waitstatus.c (target_waitstatus_to_string): Fix
3326         obsolete comment.
3327
3328 2019-04-01  Tom Tromey  <tromey@adacore.com>
3329
3330         PR symtab/23331:
3331         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3332
3333 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3334             Pedro Alves  <palves@redhat.com>
3335
3336         * top.c (quit_force): Call 'finalize_values'.
3337         * value.c (finalize_values): New function.
3338         * value.h (finalize_values): Declare.
3339
3340 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3341
3342         * NEWS: Announce $_gdb_major and $_gdb_minor.
3343
3344         * top.c (init_gdb_version_vars): New function.
3345         (gdb_init): Call init_gdb_version_vars.
3346
3347 2019-03-29  Tom Tromey  <tromey@adacore.com>
3348
3349         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3350         help text.  Remove dead code.
3351
3352 2019-03-29  Keith Seitz  <keiths@redhat.com>
3353
3354         From Siddhesh Poyarekar:
3355         * f-lang.h (f77_get_upperbound): Return LONGEST.
3356         (f77_get_lowerbound): Likewise.
3357         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3358         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3359         print them.
3360         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3361         plongest to format print it.
3362         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3363         (f77_get_upperbound): Likewise.
3364         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3365         LOWER_BOUND to LONGEST.
3366         (f77_create_arrayprint_offset_tbl): Likewise.
3367
3368 2019-03-29  Keith Seitz  <keiths@redhat.com>
3369
3370         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3371         %s/pulongest for TYPE_LENGTH instead of %d in format
3372         strings.
3373         * ada-typerint.c (ada_print_type): Likewise.
3374         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3375         * compile/compile-c-support.c (generate_register_struct): Likewise.
3376         * gdbtypes.c (recursive_dump_type): Likewise.
3377         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3378         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3379         instead of %d in format strings.
3380         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3381         to std::min to ULONGEST.
3382         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3383         instead of %d in format strings.
3384         * tracepoint.c (info_scope_command): Likewise.
3385         * typeprint.c (print_offset_data::update)
3386         (print_offset_data::finish): Likewise.
3387         * xtensa-tdep.c (xtensa_store_return_value)
3388         (xtensa_push_dummy_call): Likewise.
3389
3390 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3391
3392         * windows-nat.c (display_selector): Fixed format specifications
3393         for 64-bit Cygwin.
3394
3395 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3396
3397         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3398
3399 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3400
3401         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3402         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3403         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3404         (nios2_linux_init_abi): Install it.
3405
3406 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3407
3408         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3409
3410 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3411
3412         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3413
3414 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3415             Tom Tromey  <tromey@adacore.com>
3416
3417         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3418
3419 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3420
3421         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3422         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3423         method to compute the bounds of range types. Also print "[evaluated]"
3424         if the bounds' values come from a dynamic evaluation.
3425
3426 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3427
3428         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3429         whitespace when pretty printing is on.
3430
3431 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3432
3433         * ppc-linux-nat.c: Add include.
3434
3435 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3436
3437         * NEWS: Mention AArch64 Pointer Authentication.
3438
3439 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3440
3441         * arm-linux-nat.c: Add include.
3442
3443 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3444
3445         * source-cache.c (source_cache::get_source_lines): Re-read
3446         fullname after calling open_source_file.
3447
3448 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3449
3450         * NEWS: Mention TLS support for FreeBSD.
3451
3452 2019-03-25  Tom Tromey  <tromey@adacore.com>
3453
3454         * minsyms.c (BUNCH_SIZE): Update comment.
3455         (~minimal_symbol_reader): Remove old comment.
3456         (compact_minimal_symbols): Update comment.
3457         (minimal_symbol_reader::install): Remove old comment.  Update
3458         other comments.
3459
3460 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3461
3462         * s390-linux-nat.c: Add include.
3463
3464 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3465
3466         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3467         Call linux_get_hwcap.
3468         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3469         Likewise.
3470         (aarch64_linux_get_hwcap): Remove function.
3471         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3472         declaration.
3473         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3474         linux_get_hwcap.
3475         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3476         * linux-tdep.c (linux_get_hwcap): Add function.
3477         (linux_get_hwcap2): Likewise.
3478         * linux-tdep.h (linux_get_hwcap): Add declaration.
3479         (linux_get_hwcap2): Likewise.
3480         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3481         (ppc_linux_get_hwcap2): Likewise.
3482         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3483         linux_get_hwcap.
3484         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3485         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3486         (ppc_linux_nat_target::read_description): Likewise.
3487         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3488         * s390-linux-nat.c: Likewise.
3489         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3490
3491 2019-03-24  Tom Tromey  <tom@tromey.com>
3492
3493         * ada-lang.c (standard_lookup): Simplify initialization.
3494         (ada_lookup_symbol_nonlocal): Simplify return.
3495         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3496         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3497         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3498         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3499         initialization.
3500         * solib.c (solib_global_lookup): Simplify.
3501         * symtab.c (null_block_symbol): Remove.
3502         (symbol_cache_lookup): Simplify returns.
3503         (lookup_language_this): Simplify returns.
3504         (lookup_symbol_aux): Simplify return.
3505         (lookup_local_symbol): Simplify returns.
3506         (lookup_global_symbol_from_objfile): Simplify return.
3507         (lookup_symbol_in_objfile_symtabs)
3508         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3509         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3510         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3511         * cp-namespace.c (cp_lookup_bare_symbol)
3512         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3513         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3514         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3515         (cp_lookup_symbol_via_imports): Simplify initialization.
3516         (find_symbol_in_baseclass): Likewise.
3517         * symtab.h (null_block_symbol): Remove.
3518         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3519         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3520         (d_lookup_symbol_module): Likewise.
3521         (find_symbol_in_baseclass): Simplify initialization.
3522
3523 2019-03-24  Tom Tromey  <tom@tromey.com>
3524
3525         * expression.h: Don't include symtab.h.
3526         (struct block): Forward declare.
3527
3528 2019-03-24  Tom Tromey  <tom@tromey.com>
3529
3530         * c-exp.y (typebase): Remove casts.
3531         * gdbtypes.c (lookup_unsigned_typename, )
3532         (lookup_signed_typename): Remove cast.
3533         * eval.c (parse_to_comma_and_eval): Remove cast.
3534         * parse.c (write_dollar_variable): Remove cast.
3535         * block.h (struct block) <superblock>: Now const.
3536         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3537         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3538         (map_block): Make "block" const.
3539         * symfile.h (struct quick_symbol_functions)
3540         <map_matching_symbols>: Constify block argument to "callback".
3541         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3542         const.
3543         (find_pc_sect_compunit_symtab): Make "b" const.
3544         (find_symbol_at_address): Likewise.
3545         (search_symbols): Likewise.
3546         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3547         (dw2_debug_names_lookup_symbol): Likewise.
3548         (dw2_map_matching_symbols): Update.
3549         * p-valprint.c (pascal_val_print): Remove "block".
3550         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3551         (aux_add_nonlocal_symbols): Make "block" const.
3552         (resolve_subexp): Remove cast.
3553         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3554         const.
3555         (iterate_over_file_blocks): Likewise.
3556         * f-exp.y (%union) <bval>: Remove.
3557         * coffread.c (patch_opaque_types): Make "b" const.
3558         * spu-tdep.c (spu_catch_start): Make "block" const.
3559         * c-valprint.c (print_unpacked_pointer): Remove "block".
3560         * symmisc.c (dump_symtab_1): Make "b" const.
3561         (block_depth): Make "block" const.
3562         * d-exp.y (%union) <bval>: Remove.
3563         * cp-support.h (cp_lookup_rtti_type): Update.
3564         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3565         * psymtab.c (psym_lookup_symbol): Make "block" const.
3566         (maintenance_check_psymtabs): Make "b" const.
3567         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3568         (enumerate_locals, enumerate_args): Update.
3569         * python/py-symtab.c (stpy_global_block): Make "block" const.
3570         (stpy_static_block): Likewise.
3571         * inline-frame.c (block_starting_point_at): Make "new_block"
3572         const.
3573         * block.c (find_block_in_blockvector): Make return type const.
3574         (blockvector_for_pc_sect): Make "b" const.
3575         (find_block_in_blockvector): Make "b" const.
3576
3577 2019-03-23  Tom Tromey  <tom@tromey.com>
3578
3579         * varobj.c (varobj_create): Update.
3580         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3581         * printcmd.c (display_command, do_one_display): Don't reset
3582         innermost_block.
3583         * parser-defs.h (enum innermost_block_tracker_type): Move to
3584         expression.h.
3585         (innermost_block): Update comment.
3586         * parse.c (parse_exp_1): Add tracker_types parameter.
3587         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3588         tracker_types parameter.  Reset innermost_block.
3589         (parse_exp_in_context): Remove.
3590         (parse_expression_for_completion): Update.
3591         * objfiles.c (~objfile): Don't reset expression_context_block or
3592         innermost_block.
3593         * expression.h (enum innermost_block_tracker_type): Move from
3594         parser-defs.h.
3595         (parse_exp_1): Add tracker_types parameter.
3596         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3597         reset innermost_block.
3598
3599 2019-03-23  Tom Tromey  <tom@tromey.com>
3600
3601         * objfiles.h: Include bcache.h.
3602
3603 2019-03-23  Tom Tromey  <tom@tromey.com>
3604
3605         * linespec.c (get_current_search_block): Use
3606         scoped_restore_current_language.
3607         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3608
3609 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3610             Jiong Wang  <jiong.wang@arm.com>
3611
3612         * aarch64-linux-tdep.c
3613         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3614         section.
3615         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3616
3617 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3618             Jiong Wang  <jiong.wang@arm.com>
3619
3620         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3621         instructions.
3622         (aarch64_analyze_prologue_test): Add PACIASP test.
3623         (aarch64_prologue_prev_register): Unmask PC value.
3624
3625 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3626             Jiong Wang  <jiong.wang@arm.com>
3627
3628         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3629         (aarch64_dwarf2_prev_register): Unmask PC value.
3630         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3631         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3632         DW_CFA_AARCH64_negate_ra_state.
3633         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3634
3635 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3636             Jiong Wang  <jiong.wang@arm.com>
3637
3638         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3639         registers.
3640         (aarch64_pseudo_register_name): Likewise.
3641         (aarch64_pseudo_register_type): Likewise.
3642         (aarch64_pseudo_register_reggroup_p): Likewise.
3643         (aarch64_gdbarch_init): Add pauth registers.
3644         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3645         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3646         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3647         (struct gdbarch_tdep): Add regnum for ra_state.
3648
3649 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3650             Jiong Wang  <jiong.wang@arm.com>
3651
3652         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3653
3654 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3655             Jiong Wang  <jiong.wang@arm.com>
3656
3657         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3658         function.
3659         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3660         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3661         (aarch64_gdbarch_init): Add puth registers.
3662         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3663         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3664         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3665
3666 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3667             Jiong Wang  <jiong.wang@arm.com>
3668
3669         * aarch64-linux-nat.c
3670         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3671         * aarch64-linux-tdep.c
3672         (aarch64_linux_core_read_description): Likewise.
3673         (aarch64_linux_get_hwcap): New function.
3674         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3675         (aarch64_linux_get_hwcap): New declaration.
3676
3677 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3678             Jiong Wang  <jiong.wang@arm.com>
3679
3680         * aarch64-linux-nat.c
3681         (aarch64_linux_nat_target::read_description): Add pauth param.
3682         * aarch64-linux-tdep.c
3683         (aarch64_linux_core_read_description): Likewise.
3684         * aarch64-tdep.c (struct target_desc): Add in pauth.
3685         (aarch64_read_description): Add pauth param.
3686         (aarch64_gdbarch_init): Likewise.
3687         * aarch64-tdep.h (aarch64_read_description): Likewise.
3688         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3689         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3690         * features/Makefile: Add new files.
3691         * features/aarch64-pauth.c: New file.
3692         * features/aarch64-pauth.xml: New file.
3693
3694 2019-03-20  Tom Tromey  <tromey@adacore.com>
3695
3696         * infrun.c (handle_inferior_event): Rename from
3697         handle_inferior_event_1.  Create a scoped_value_mark.
3698         (handle_inferior_event): Remove.
3699
3700 2019-03-19  Tom Tromey  <tromey@adacore.com>
3701
3702         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3703         * infrun.h (print_stop_event): Add "displays" parameter.
3704         * infrun.c (print_stop_event): Add "displays" parameter.
3705
3706 2019-03-19  Pedro Alves  <palves@redhat.com>
3707
3708         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3709         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3710         to -1.  Fix TABs vs spaces.
3711         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3712         * tui/tui-out.h (tui_ui_out) Add intro comments.
3713         <m_line, m_start_of_line>: In-class initialize, and add describing
3714         comment.
3715
3716 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3717
3718         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3719         variable names.
3720         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3721
3722 2019-03-18  Pedro Alves  <palves@redhat.com>
3723             Eli Zaretskii <eliz@gnu.org>
3724
3725         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3726         m_line and m_start_of_line.
3727
3728 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3729
3730         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3731         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3732         it returns a newline.  This fixes a regression in TU mode, whereby
3733         the next line is output on the same screen line as the user input.
3734
3735 2019-03-18  Tom Tromey  <tromey@adacore.com>
3736
3737         * minsyms.c (minimal_symbol_reader::install): Remove call to
3738         obstack_blank.
3739
3740 2019-03-18  Pedro Alves  <palves@redhat.com>
3741
3742         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3743         New globals.
3744         (apply_style): New, factored out from ...
3745         (apply_ansi_escape): ... this.  Handle reverse video mode.
3746         (tui_set_reverse_mode): New function.
3747         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3748         * tui/tui-winsource.c (tui_show_source_line): Use
3749         tui_set_reverse_mode instead of setting A_STANDOUT.
3750         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3751         New setter methods.
3752
3753 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3754
3755         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3756         Handle tabs.
3757
3758 2019-03-18  Tom Tromey  <tromey@adacore.com>
3759
3760         * ada-lang.c (empty_array): Add "high" parameter.
3761         (ada_evaluate_subexp): Update.
3762
3763 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3764
3765         * unittests/string_view-selftests.c: Define
3766         _initialize_string_view_selftests unconditionally.
3767
3768 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3769
3770         PR gdb/24350
3771         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3772
3773 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3774
3775         PR gdb/24351
3776         * windows-nat.c (display_selector): Fix format specifiers.
3777
3778 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3779
3780         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3781         tui_refill_source_window instead of tui_refresh_win, to update the
3782         current execution line.  This fixes redisplay of the current line
3783         when stepping through the code with "next" or "step".
3784
3785 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3786
3787         * source-cache.c (source_cache::get_source_lines): Call
3788         find_source_lines to initialize s->nlines.  This fixes vertical
3789         scrolling of TUI source window when the DOWN arrow is pressed.
3790
3791 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3792
3793         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3794         linux-thread-db.c (_initialize_thread_db): Likewise.
3795
3796 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3797
3798         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3799         wclrtoeol in tui_show_source_line".  This reverts changes made in
3800         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3801
3802 2019-03-15  Tom Tromey  <tom@tromey.com>
3803
3804         * symtab.h (struct minimal_symbol): Derive from
3805         general_symbol_info.
3806         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3807         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3808         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3809         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3810         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3811         (MSYMBOL_SEARCH_NAME): Update.
3812         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3813         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3814         * minsyms.c (minimal_symbol_reader::record_full): Update.
3815
3816 2019-03-15  Tom Tromey  <tom@tromey.com>
3817
3818         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3819
3820 2019-03-15  Tom Tromey  <tom@tromey.com>
3821
3822         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3823         unique_xmalloc_ptr.
3824         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3825         Update.
3826         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3827         (build_minimal_symbol_hash_tables)
3828         (minimal_symbol_reader::install): Update.
3829
3830 2019-03-15  Tom Tromey  <tom@tromey.com>
3831
3832         * symtab.c (create_demangled_names_hash): Update.
3833         (symbol_set_names): Update.
3834         * objfiles.h (struct objfile_per_bfd_storage)
3835         <demangled_names_hash>: Now an htab_up.
3836         * objfiles.c (objfile_per_bfd_storage): Simplify.
3837
3838 2019-03-15  Tom Tromey  <tom@tromey.com>
3839
3840         * objfiles.h (struct objfile_per_bfd_storage): Declare
3841         destructor.
3842         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3843         New.
3844         (get_objfile_bfd_data): Use new.  Don't initialize
3845         language_of_main.
3846         (free_objfile_per_bfd_storage): Remove.
3847         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3848
3849 2019-03-15  Tom Tromey  <tom@tromey.com>
3850
3851         * symfile.c (reread_symbols): Update.
3852         * objfiles.c (objfile::objfile): Update.
3853         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3854         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3855         comment.
3856         (minimal_symbol_reader::install): Update.
3857         (terminate_minimal_symbol_table): Remove.
3858         * jit.c (jit_object_close_impl): Update.
3859
3860 2019-03-15  Tom Tromey  <tom@tromey.com>
3861
3862         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3863         initializations.
3864
3865 2019-03-15  Tom Tromey  <tom@tromey.com>
3866
3867         * objfiles.h (struct objfile_per_bfd_storage)
3868         <demangled_hash_languages>: Now a bitset.
3869         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3870         (lookup_minimal_symbol): Update.
3871
3872 2019-03-15  Tom Tromey  <tom@tromey.com>
3873
3874         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3875         Don't return the symbol.
3876         * coffread.c (record_minimal_symbol): Use record_full.
3877
3878 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3879
3880         The MS-Windows port of ncurses fails to switch to a color pair if
3881         one or both of the colors are the implicit default colors.  This
3882         change records the default colors when TUI is initialized, and
3883         then specifies them explicitly when a color pair uses the default
3884         colors.  This allows color styling in TUI mode on MS-Windows.
3885
3886         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3887         ncurses_norm_attr.
3888         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3889         colors in ncurses_norm_attr.
3890         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3891         "none", replace it with the default color recorded in
3892         ncurses_norm_attr.
3893
3894 2019-03-14  Tom Tromey  <tromey@adacore.com>
3895
3896         * source-cache.h (class source_cache) <get_source_lines>: Return
3897         std::string.
3898         * source-cache.c (source_cache::extract_lines): Handle case where
3899         first_pos==npos.  Return std::string.
3900         (source_cache::get_source_lines): Update.
3901
3902 2019-03-14  Tom Tromey  <tromey@adacore.com>
3903
3904         * NEWS: Add item for "style sources" commands.
3905         * source-cache.c (source_cache::get_source_lines): Check
3906         source_styling.
3907         * cli/cli-style.c (source_styling): New global.
3908         (_initialize_cli_style): Add "style sources" commands.
3909         (show_style_sources): New function.
3910         * cli/cli-style.h (source_styling): Declare.
3911
3912 2019-03-14  Pedro Alves  <palves@redhat.com>
3913             Tom Tromey  <tromey@adacore.com>
3914
3915         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3916         * tui/tui-winsource.c (tui_refill_source_window): New function,
3917         from...
3918         (tui_horizontal_source_scroll): ... here.  Move some logic.
3919         * cli/cli-style.c (set_style_enabled): Notify new observable.
3920         * tui/tui-hooks.c (tui_redisplay_source): New function.
3921         (tui_attach_detach_observers): Attach or detach
3922         tui_redisplay_source.
3923         * observable.h (source_styling_changed): New observable.
3924         * observable.c: Define source_styling_changed observable.
3925
3926 2019-03-13  Tom Tromey  <tromey@adacore.com>
3927
3928         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3929         (i386_gnu_nat_target::store_registers): Update.
3930         * target-debug.h (target_debug_print_std_string): New macro.
3931         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3932         * windows-tdep.c (display_one_tib): Update.
3933         * tui/tui-stack.c (tui_make_status_line): Update.
3934         * top.c (print_inferior_quit_action): Update.
3935         * thread.c (thr_try_catch_cmd): Update.
3936         (add_thread_with_info): Update.
3937         (thread_target_id_str): Update.
3938         (thr_try_catch_cmd): Update.
3939         (thread_command): Update.
3940         (thread_find_command): Update.
3941         * record-btrace.c (record_btrace_target::info_record)
3942         (record_btrace_resume_thread, record_btrace_target::resume)
3943         (record_btrace_cancel_resume, record_btrace_step_thread)
3944         (record_btrace_target::wait, record_btrace_target::wait)
3945         (record_btrace_target::wait, record_btrace_target::stop): Update.
3946         * progspace.c (print_program_space): Update.
3947         * process-stratum-target.c
3948         (process_stratum_target::thread_address_space): Update.
3949         * linux-fork.c (linux_fork_mourn_inferior)
3950         (detach_checkpoint_command, info_checkpoints_command)
3951         (linux_fork_context): Update.
3952         (linux_fork_detach): Update.
3953         (class scoped_switch_fork_info): Update.
3954         (delete_checkpoint_command): Update.
3955         * infrun.c (follow_fork_inferior): Update.
3956         (follow_fork_inferior): Update.
3957         (proceed_after_vfork_done): Update.
3958         (handle_vfork_child_exec_or_exit): Update.
3959         (follow_exec): Update.
3960         (displaced_step_prepare_throw): Update.
3961         (displaced_step_restore): Update.
3962         (start_step_over): Update.
3963         (resume_1): Update.
3964         (clear_proceed_status_thread): Update.
3965         (proceed): Update.
3966         (print_target_wait_results): Update.
3967         (do_target_wait): Update.
3968         (context_switch): Update.
3969         (stop_all_threads): Update.
3970         (restart_threads): Update.
3971         (finish_step_over): Update.
3972         (handle_signal_stop): Update.
3973         (switch_back_to_stepped_thread): Update.
3974         (keep_going_pass_signal): Update.
3975         (print_exited_reason): Update.
3976         (normal_stop): Update.
3977         * inferior.c (inferior_pid_to_str): Change return type.
3978         (print_selected_inferior): Update.
3979         (add_inferior): Update.
3980         (detach_inferior): Update.
3981         * dummy-frame.c (fprint_dummy_frames): Update.
3982         * dcache.c (dcache_info_1): Update.
3983         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3984         (btrace_fetch, btrace_clear): Update.
3985         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3986         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3987         type.
3988         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3989         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3990         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3991         * gdbarch.c, gdbarch.h: Rebuild.
3992         * gdbarch.sh (core_pid_to_str): Change return type.
3993         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3994         return type.
3995         (windows_nat_target::pid_to_str): Change return type.
3996         (windows_delete_thread): Update.
3997         (windows_nat_target::attach): Update.
3998         (windows_nat_target::files_info): Update.
3999         * target-delegates.c: Rebuild.
4000         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4001         return type.
4002         (sol_thread_target::pid_to_str): Change return type.
4003         * remote.c (class remote_target) <pid_to_str>: Change return
4004         type.
4005         (remote_target::pid_to_str): Change return type.
4006         (extended_remote_target::attach, remote_target::remote_stop_ns)
4007         (remote_target::remote_notif_remove_queued_reply)
4008         (remote_target::push_stop_reply, remote_target::disable_btrace):
4009         Update.
4010         (extended_remote_target::attach): Update.
4011         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4012         type.
4013         (gdbsim_target::pid_to_str): Change return type.
4014         * ravenscar-thread.c (struct ravenscar_thread_target)
4015         <pid_to_str>: Change return type.
4016         (ravenscar_thread_target::pid_to_str): Change return type.
4017         * procfs.c (class procfs_target) <pid_to_str>: Change return
4018         type.
4019         (procfs_target::pid_to_str): Change return type.
4020         (procfs_target::attach): Update.
4021         (procfs_target::detach): Update.
4022         (procfs_target::fetch_registers): Update.
4023         (procfs_target::store_registers): Update.
4024         (procfs_target::wait): Update.
4025         (procfs_target::files_info): Update.
4026         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4027         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4028         return type.
4029         (nto_procfs_target::pid_to_str): Change return type.
4030         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4031         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4032         return type.
4033         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4034         (exit_lwp): Update.
4035         (attach_proc_task_lwp_callback, get_detach_signal)
4036         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4037         (linux_nat_target::resume, wait_lwp, stop_callback)
4038         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4039         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4040         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4041         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4042         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4043         type.
4044         (inf_ptrace_target::attach): Update.
4045         (inf_ptrace_target::files_info): Update.
4046         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4047         type.
4048         (go32_nat_target::pid_to_str): Change return type.
4049         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4050         (gnu_nat_target::wait): Update.
4051         (gnu_nat_target::wait): Update.
4052         (gnu_nat_target::resume): Update.
4053         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4054         (fbsd_nat_target::wait): Update.
4055         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4056         type.
4057         (darwin_nat_target::attach): Update.
4058         * corelow.c (class core_target) <pid_to_str>: Change return type.
4059         (core_target::pid_to_str): Change return type.
4060         * target.c (normal_pid_to_str): Change return type.
4061         (default_pid_to_str): Likewise.
4062         (target_pid_to_str): Change return type.
4063         (target_translate_tls_address): Update.
4064         (target_announce_detach): Update.
4065         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4066         return type.
4067         (bsd_uthread_target::pid_to_str): Change return type.
4068         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4069         type.
4070         (bsd_kvm_target::pid_to_str): Change return type.
4071         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4072         return type.
4073         (aix_thread_target::pid_to_str): Change return type.
4074         * target.h (struct target_ops) <pid_to_str>: Change return type.
4075         (target_pid_to_str, normal_pid_to_str): Likewise.
4076         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4077         type.
4078         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4079         type.
4080         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4081         return type.
4082         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4083         type.
4084         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4085         type.
4086         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4087         return type.
4088
4089 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4090
4091         * NEWS: Mention that the new default MI version is 3.  Mention
4092         changes to the output of commands and events that deal with
4093         multi-location breakpoints.
4094         * breakpoint.c: Include "mi/mi-out.h".
4095         (print_one_breakpoint): Change output syntax if using MI version
4096         >= 3.
4097         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4098         New.
4099         (mi_multi_location_breakpoint_output_fixed): New.
4100         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4101         (mi_cmd_fix_multi_location_breakpoint_output): New.
4102         (mi_multi_location_breakpoint_output_fixed): New.
4103         * mi/mi-cmds.c (mi_cmds): Register command
4104         -fix-multi-location-breakpoint-output.
4105         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4106         interpreter "mi".
4107
4108 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4109
4110         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4111         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4112         instantiate mi_ui_out based on interpreter name.
4113         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4114         * mi/mi-main.c (mi_load_progress): Likewise.
4115
4116 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4117
4118         * NEWS: Combine separate "New targets" sections for 8.3.
4119
4120 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4121
4122         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4123         (ppcfbsd_init_abi): Install gdbarch
4124         "fetch_tls_load_module_address" and "get_thread_local_address"
4125         methods.
4126
4127 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4128
4129         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4130         (riscv_fbsd_init_abi): Install gdbarch
4131         "fetch_tls_load_module_address" and "get_thread_local_address"
4132         methods.
4133
4134 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4135
4136         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4137         (i386fbsd_init_abi): Install gdbarch
4138         "fetch_tls_load_module_address" and "get_thread_local_address"
4139         methods.
4140
4141 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4142
4143         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4144         (amd64fbsd_init_abi): Install gdbarch
4145         "fetch_tls_load_module_address" and "get_thread_local_address"
4146         methods.
4147
4148 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4149
4150         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4151         (struct fbsd_pspace_data): New type.
4152         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4153         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4154         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4155         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4156         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4157
4158 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4159
4160         * gdbtypes.c (lookup_struct_elt): New function.
4161         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4162         * gdbtypes.h (struct struct_elt): New type.
4163         (lookup_struct_elt): New prototype.
4164
4165 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4166
4167         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4168         remove disabled code block.
4169
4170 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4171
4172         * gdbarch.sh (get_thread_local_address): New method.
4173         * gdbarch.h, gdbarch.c: Regenerate.
4174         * target.c (target_translate_tls_address): Use
4175         gdbarch_get_thread_local_address if present instead of
4176         target::get_thread_local_address.
4177
4178 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4179
4180         * target.h (target::get_thread_local_address): Update comment.
4181
4182 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4183
4184         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4185         objfile->separate_debug_objfile_backlink if not NULL.
4186
4187 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4188
4189         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4190         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4191         (amd64bsd_store_inferior_registers): Likewise.
4192         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4193         Enable segment base registers.
4194         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4195         PT_GETFSBASE and PT_GETGSBASE.
4196         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4197         PT_SETGSBASE.
4198         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4199         segment base registers.
4200         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4201
4202 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4203
4204         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4205         Update calls to i386_target_description to add 'segments'
4206         parameter.
4207         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4208         add segment base registers.
4209         * arch/i386.c (i386_create_target_description): Add 'segments'
4210         parameter to enable segment base registers.
4211         * arch/i386.h (i386_create_target_description): Likewise.
4212         * features/i386/32bit-segments.xml: New file.
4213         * features/i386/32bit-segments.c: Generate.
4214         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4215         call to i386_target_description to add 'segments' parameter.
4216         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4217         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4218         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4219         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4220         if feature is present.
4221         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4222         Add 'segments' parameter to call to i386_target_description.
4223         (i386_target_description): Add 'segments' parameter to enable
4224         segment base registers.
4225         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4226         to call to i386_target_description.
4227         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4228         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4229         Define I386_NUM_REGS.
4230         (i386_target_description): Add 'segments' parameter to enable
4231         segment base registers.
4232
4233 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4234
4235         PR/24325
4236         * source-cache.c: #undef open and close, to avoid unresolved
4237         externals during linking.
4238
4239 2019-03-12  Tom Tromey  <tromey@adacore.com>
4240
4241         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4242         const.  Add initializers.
4243         (_initialize_remote): Don't initialize ptid globals.
4244
4245 2019-03-12  Pedro Alves  <palves@redhat.com>
4246
4247         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4248
4249 2019-03-12  Pedro Alves  <palves@redhat.com>
4250
4251         * cp-name-parser.y (main): Remove unused 'len' variable.
4252
4253 2019-03-12  Tom Tromey  <tromey@adacore.com>
4254
4255         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4256         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4257
4258 2019-03-12  Tom Tromey  <tromey@adacore.com>
4259
4260         * linux-nat.c (iterate_over_lwps): Update.
4261         (stop_callback): Remove parameter.
4262         (stop_wait_callback, detach_callback, resume_set_callback)
4263         (select_singlestep_lwp_callback, set_ignore_sigint)
4264         (status_callback, resumed_callback, resume_clear_callback)
4265         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4266         data parameter.
4267         (linux_nat_target::detach, linux_nat_target::resume)
4268         (linux_stop_and_wait_all_lwps, select_event_lwp)
4269         (linux_nat_filter_event, linux_nat_wait_1)
4270         (linux_nat_target::kill, linux_nat_target::stop)
4271         (linux_nat_target::stop): Update.
4272         (linux_nat_resume_callback): Change type.
4273         (resume_stopped_resumed_lwps, count_events_callback)
4274         (select_event_lwp_callback): Likewise.
4275         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4276         * arm-linux-nat.c (struct update_registers_data): Remove.
4277         (update_registers_callback): Change type.
4278         (arm_linux_insert_hw_breakpoint1): Update.
4279         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4280         parameter.
4281         (x86_linux_dr_set_addr): Update.
4282         (x86_linux_dr_set_control): Update.
4283         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4284         (iterate_over_lwps): Use gdb::function_view.
4285         * nat/aarch64-linux-hw-point.c (struct
4286         aarch64_dr_update_callback_param): Remove.
4287         (debug_reg_change_callback): Change type.
4288         (aarch64_notify_debug_reg_change): Update.
4289         * s390-linux-nat.c (s390_refresh_per_info): Update.
4290
4291 2019-03-11  Tom Tromey  <tromey@adacore.com>
4292
4293         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4294         redundant assignment to "this_cu".
4295
4296 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4297
4298         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4299
4300 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4301
4302         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4303         from...
4304         (rank_one_type): ... this.
4305
4306 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4307
4308         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4309         from...
4310         (rank_one_type): ... this.
4311
4312 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4313
4314         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4315         from...
4316         (rank_one_type): ... this.
4317
4318 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4319
4320         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4321         from...
4322         (rank_one_type): ... this.
4323
4324 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4325
4326         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4327         from...
4328         (rank_one_type): ... this.
4329
4330 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4331
4332         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4333         from...
4334         (rank_one_type): ... this.
4335
4336 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4337
4338         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4339         from...
4340         (rank_one_type): ... this.
4341
4342 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4343
4344         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4345         from...
4346         (rank_one_type): ... this.
4347
4348 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4349
4350         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4351         from...
4352         (rank_one_type): ... this.
4353
4354 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4355
4356         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4357         from...
4358         (rank_one_type): ... this.
4359
4360 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4361
4362         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4363         from...
4364         (rank_one_type): ... this.
4365
4366 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4367
4368         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4369         from...
4370         (rank_one_type): ... this.
4371
4372 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4373
4374         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4375         inferior-events' shows the example events.
4376
4377 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4378
4379         Support styling on native MS-Windows console
4380
4381         PR/24315
4382         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4383         on MS-Windows if $TERM is not defined.
4384
4385         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4386
4387         * posix-hdep.c (gdb_console_fputs):
4388         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4389         functions.
4390         * ui-file.h (gdb_console_fputs): Add prototype.
4391
4392         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4393         back to fputs only if the former returns zero.
4394
4395 2019-03-07  Tom Tromey  <tom@tromey.com>
4396
4397         * symmisc.c (print_symbol_bcache_statistics): Update.
4398         (print_objfile_statistics): Update.
4399         * symfile.c (allocate_symtab): Update.
4400         * stabsread.c: Don't include bcache.h.
4401         * psymtab.h (struct psymbol_bcache): Don't declare.
4402         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4403         (psymbol_bcache_init, psymbol_bcache_free)
4404         (psymbol_bcache_get_bcache): Don't declare.
4405         * psymtab.c (struct psymbol_bcache): Remove.
4406         (psymtab_storage::psymtab_storage): Update.
4407         (psymtab_storage::~psymtab_storage): Update.
4408         (psymbol_bcache_init, psymbol_bcache_free)
4409         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4410         (add_psymbol_to_bcache): Update.
4411         (allocate_psymtab): Update.
4412         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4413         macro_cache>: No longer pointers.
4414         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4415         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4416         * macrotab.c (macro_bcache): Update.
4417         * macroexp.c: Don't include bcache.h.
4418         * gdbtypes.c (check_types_worklist): Update.
4419         (types_deeply_equal): Remove TRY/CATCH.  Update.
4420         * elfread.c (elf_symtab_read): Update.
4421         * dwarf2read.c: Don't include bcache.h.
4422         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4423         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4424         (print_bcache_statistics, bcache_memory_used): Don't declare.
4425         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4426         methods.  Rename all data members.
4427         * bcache.c (struct bcache): Move to bcache.h.
4428         (bcache::expand_hash_table): Rename from expand_hash_table.
4429         (bcache): Remove.
4430         (bcache::insert): Rename from bcache_full.
4431         (bcache::compare): Rename from bcache_compare.
4432         (bcache_xmalloc): Remove.
4433         (bcache::~bcache): Rename from bcache_xfree.
4434         (bcache::print_statistics): Rename from print_bcache_statistics.
4435         (bcache::memory_used): Rename from bcache_memory_used.
4436
4437 2019-03-07  Pedro Alves  <palves@redhat.com>
4438
4439         * infrun.c (normal_stop): Also check for
4440         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4441
4442 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4443
4444         * f-lang.c (value_from_host_double): Moved to...
4445         * value.c (value_from_host_double): ...here.
4446         * value.h (value_from_host_double): Declare.
4447         * guile/scm-math.c (vlscm_convert_typed_number): Use
4448         value_from_host_double.
4449         (vlscm_convert_number): Likewise.
4450         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4451         * python/py-value.c (convert_value_from_python): Likewise.
4452
4453 2019-03-06  Tom Tromey  <tom@tromey.com>
4454
4455         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4456
4457 2019-03-06  Tom Tromey  <tom@tromey.com>
4458
4459         * utils.h (free_current_contents): Don't declare.
4460         * utils.c (free_current_contents): Remove.
4461
4462 2019-03-06  Tom Tromey  <tom@tromey.com>
4463
4464         * top.c (quit_force): Update.
4465         * main.c (captured_command_loop): Update.
4466         * common/new-op.c (operator new): Update.
4467         * common/common-exceptions.c (struct catcher)
4468         <save_cleanup_chain>: Remove member.
4469         (exceptions_state_mc_init): Update.
4470         (exception_try_scope_entry): Return nullptr.
4471         (exception_try_scope_exit, exception_rethrow)
4472         (throw_exception_sjlj, throw_exception_cxx): Update.
4473         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4474         (all_cleanups, do_cleanups, discard_cleanups)
4475         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4476         (restore_cleanups, restore_final_cleanups): Don't declare.
4477         (do_final_cleanups): Remove parameter.
4478         * common/cleanups.c (cleanup_chain, make_cleanup)
4479         (make_cleanup_dtor, all_cleanups, do_cleanups)
4480         (discard_my_cleanups, discard_cleanups)
4481         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4482         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4483         (null_cleanup): Remove.
4484         (do_final_cleanups): Remove parameter.
4485
4486 2019-03-06  Tom Tromey  <tom@tromey.com>
4487
4488         * remote.c (remote_target::remote_parse_stop_reply): Use
4489         unique_xmalloc_ptr.
4490
4491 2019-03-06  Tom Tromey  <tom@tromey.com>
4492
4493         * stabsread.c (struct stabs_field_info): Rename from field_info.
4494         <list, fnlist>: Add initializers.
4495         <obstack>: New member.
4496         (read_member_functions, read_struct_fields, read_baseclasses):
4497         Allocate on obstack.  Don't use cleanups.
4498         (read_one_struct_field, read_member_functions, read_struct_fields)
4499         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4500         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4501         (read_struct_type): Update.
4502
4503 2019-03-06  Tom Tromey  <tom@tromey.com>
4504
4505         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4506         * common/filestuff.h (make_cleanup_close): Don't declare.
4507         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4508         Remove.
4509
4510 2019-03-06  Tom Tromey  <tom@tromey.com>
4511
4512         * solib-aix.c: Use make_scope_exit.
4513
4514 2019-03-06  Tom Tromey  <tom@tromey.com>
4515
4516         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4517         Use make_scope_exit.
4518
4519 2019-03-06  Tom Tromey  <tom@tromey.com>
4520
4521         * solib-svr4.c (disable_probes_interface): Remove parameter.
4522         (svr4_handle_solib_event): Use make_scope_exit.
4523
4524 2019-03-06  Tom Tromey  <tom@tromey.com>
4525
4526         * remote.c (struct stop_reply_deleter): Remove.
4527         (stop_reply_up): Update.
4528         (struct stop_reply): Derive from notif_event.  Don't typedef.
4529         <regcache>: Now a std::vector.
4530         (stop_reply_xfree): Remove.
4531         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4532         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4533         (remote_target::discard_pending_stop_replies): Use delete.
4534         (remote_target::remote_parse_stop_reply): Update.
4535         (remote_target::process_stop_reply): Update.
4536         * remote-notif.h (struct notif_event): Add virtual destructor.
4537         Remove "dtr" member.
4538         (struct notif_client) <alloc_event>: Return a unique_ptr.
4539         (notif_event_xfree): Don't declare.
4540         (notif_event_up): New typedef.
4541         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4542         (notif_event_xfree, do_notif_event_xfree): Remove.
4543         (remote_notif_state_xfree): Update.
4544
4545 2019-03-06  Tom Tromey  <tom@tromey.com>
4546
4547         * infrun.c (displaced_step_clear_cleanup): Now a
4548         forward_scope_exit type.
4549         (displaced_step_prepare_throw): Update.
4550         (displaced_step_fixup): Update.
4551
4552 2019-03-06  Tom Tromey  <tom@tromey.com>
4553
4554         * inferior.h (class inferior): Update comment.
4555         * gdbthread.h (class thread_info): Update comment.
4556
4557 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4558             Tom Tromey  <tom@tromey.com>
4559
4560         * stabsread.h (struct stab_section_list): Remove.
4561         (coffstab_build_psymtabs): Update.
4562         * dbxread.c (symbuf_sections): Now a std::vector.
4563         (sect_idx): New global.
4564         (fill_symbuf): Update.
4565         (coffstab_build_psymtabs): Change type of stabsects parameter.
4566         Update.
4567         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4568         std::vector.
4569         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4570         (coff_locate_sections): Update.
4571         (coff_symfile_read): Remove cleanups.  Update.
4572         (init_stringtab): Add storage parameter.
4573         (free_stringtab, free_stringtab_cleanup): Remove.
4574         (init_lineno): Add storage parameter.
4575         (free_linetab, free_linetab_cleanup): Remove.
4576
4577 2019-03-06  Pedro Alves  <palves@redhat.com>
4578
4579         * linux-fork.c (fork_info::clobber_regs): Delete.
4580         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4581         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4582         comment.  Adjust.
4583         (scoped_switch_fork_info::scoped_switch_fork_info)
4584         (checkpoint_command, linux_fork_context): Adjust
4585         fork_save_infrun_state calls.
4586
4587 2019-03-06  Pedro Alves  <palves@redhat.com>
4588
4589         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4590         (inf_has_multiple_threads): Return 'bool' and rewrite using
4591         inferior_info::threads().
4592
4593 2019-03-06  Pedro Alves  <palves@redhat.com>
4594
4595         * linux-fork.c: Include <list>.
4596         (fork_list): Now a std::list instance.
4597         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4598         (forks_exist_p, find_last_fork): Adjust.
4599         (new_fork): Delete.
4600         (one_fork_p): New.
4601         (add_fork): Adjust.
4602         (free_fork): Delete, folded into fork_info::~fork_info().
4603         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4604         Adjust.
4605         (init_fork_list): Delete.
4606         (linux_fork_killall, linux_fork_mourn_inferior)
4607         (linux_fork_detach, info_checkpoints_command): Adjust.
4608         (_initialize_linux_fork): No longer call init_fork_list.
4609
4610 2019-03-06  Pedro Alves  <palves@redhat.com>
4611
4612         * linux-fork.c (new_fork): New, split out of ...
4613         (add_fork): ... this.  Return void.  Move "first fork" special
4614         case from here, to ...
4615         (checkpoint_command): ... here.
4616         * linux-linux.h (add_fork): Return void.
4617
4618 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4619
4620         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4621
4622 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4623             Chris January  <chris.january@arm.com>
4624             David Lecomber  <david.lecomber@arm.com>
4625
4626         * f-exp.y: New token, UNOP_INTRINSIC.
4627         (exp): New pattern using UNOP_INTRINSIC token.
4628         (f77_keywords): Add 'abs' keyword.
4629         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4630         (value_from_host_double): New function.
4631         (evaluate_subexp_f): Support UNOP_ABS.
4632
4633 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4634
4635         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4636         types.
4637
4638 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4639
4640         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4641         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4642         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4643
4644 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4645
4646         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4647
4648 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4649             Chris January  <chris.january@arm.com>
4650
4651         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4652         * f-exp.y: Define 'KIND' token.
4653         (exp): New pattern for KIND expressions.
4654         (ptype): Handle types with a kind extension.
4655         (direct_abs_decl): Extend to spot kind extensions.
4656         (f77_keywords): Add 'kind' to the list.
4657         (push_kind_type): New function.
4658         (convert_to_kind_type): New function.
4659         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4660         * parse.c (operator_length_standard): Likewise.
4661         * parser-defs.h (enum type_pieces): Add tp_kind.
4662         * std-operator.def: Add UNOP_KIND.
4663
4664 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4665
4666         * f-exp.y (f_parse): Set yydebug.
4667
4668 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4669
4670         * f-lang.c (evaluate_subexp_f): New function.
4671         (exp_descriptor_f): New global.
4672         (f_language_defn): Use exp_descriptor_f instead of
4673         exp_descriptor_standard.
4674
4675 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4676
4677         * f-exp.y (struct token): Add comments.
4678         (dot_ops): Remove uppercase versions and the end marker.
4679         (f77_keywords): Likewise.
4680         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4681         entries in the dot_ops array are case insensitive, and use
4682         strncasecmp to compare strings.  Also some whitespace cleanup in
4683         this area.  Similar for the f77_keywords array, except entries in
4684         this list might be case sensitive.
4685
4686 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4687
4688         * f-exp.y (struct f77_boolean_val): Add comments.
4689         (boolean_values): Remove uppercase versions, and end marker.
4690         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4691         and use strncasecmp to achieve case insensitivity.  Additionally,
4692         perform whitespace cleanup around this code.
4693
4694 2019-03-06  Tom Tromey  <tromey@adacore.com>
4695
4696         * remote-sim.c (gdbsim_target_open): Use result of
4697         gdb_argv::release.
4698
4699 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4700         Dirk Schubert  <dirk.schubert@arm.com>
4701         Chris January  <chris.january@arm.com>
4702
4703         * eval.c (evaluate_subexp_standard): Call Fortran argument
4704         wrapping logic.
4705         * f-lang.c (struct value): A value which can be passed into a
4706         Fortran function call.
4707         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4708         where appropriate.
4709         (struct type): Value ready for a Fortran function call.
4710         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4711         is needed.
4712         * f-lang.h (fortran_argument_convert): Declaration.
4713         (fortran_preserve_arg_pointer): Declaration.
4714         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4715
4716 2019-03-05  Tom Tromey  <tromey@adacore.com>
4717
4718         * python/py-prettyprint.c (print_string_repr): Remove #if.
4719         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4720
4721 2019-03-05  Tom Tromey  <tromey@adacore.com>
4722
4723         * target.c (the_dummy_target): Move later.  Change type to
4724         "dummy_target".
4725         (initialize_targets): Don't initialize the_dummy_target.
4726
4727 2019-03-05  Tom Tromey  <tromey@adacore.com>
4728
4729         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4730         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4731
4732 2019-03-05  Tom Tromey  <tromey@adacore.com>
4733
4734         * windows-nat.c (windows_nat_target::attach)
4735         (windows_nat_target::detach): Don't call gdb_flush.
4736         * valprint.c (generic_val_print, val_print, val_print_string):
4737         Don't call gdb_flush.
4738         * utils.c (defaulted_query): Don't call gdb_flush.
4739         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4740         * target.c (target_announce_detach): Don't call gdb_flush.
4741         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4742         * remote.c (extended_remote_target::attach): Don't call
4743         gdb_flush.
4744         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4745         * printcmd.c (do_examine): Don't call gdb_flush.
4746         (info_display_command): Don't call gdb_flush.
4747         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4748         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4749         * memattr.c (info_mem_command): Don't call gdb_flush.
4750         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4751         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4752         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4753         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4754         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4755         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4756         (gnu_nat_target::detach): Don't call gdb_flush.
4757         * f-valprint.c (f_val_print): Don't call gdb_flush.
4758         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4759         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4760         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4761         gdb_flush.
4762         * c-valprint.c (c_val_print): Don't call gdb_flush.
4763         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4764
4765 2019-03-05  Tom Tromey  <tromey@adacore.com>
4766
4767         * varobj.c (update_dynamic_varobj_children): Update.
4768         (install_default_visualizer): Use reset, not release.
4769         * value.c (set_internalvar): Update.
4770         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4771         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4772         ATTRIBUTE_UNUSED_RESULT.
4773
4774 2019-03-05  Tom Tromey  <tromey@adacore.com>
4775
4776         * remote.c (class scoped_remote_fd) <release>: Add
4777         ATTRIBUTE_UNUSED_RESULT.
4778
4779 2019-03-05  Tom Tromey  <tromey@adacore.com>
4780
4781         * macroexp.c (struct macro_buffer) <release>: Add
4782         ATTRIBUTE_UNUSED_RESULT.
4783
4784 2019-03-05  Tom Tromey  <tromey@adacore.com>
4785
4786         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4787         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4788         ATTRIBUTE_UNUSED_RESULT.
4789
4790 2019-03-05  Tom Tromey  <tromey@adacore.com>
4791
4792         * common/scoped_fd.h (class scoped_fd) <release>: Add
4793         ATTRIBUTE_UNUSED_RESULT.
4794
4795 2019-03-05  Tom Tromey  <tromey@adacore.com>
4796
4797         * parser-defs.h (struct parser_state) <release>: Add
4798         ATTRIBUTE_UNUSED_RESULT.
4799
4800 2019-03-05  Tom Tromey  <tromey@adacore.com>
4801
4802         * utils.h (class gdb_argv) <release>: Add
4803         ATTRIBUTE_UNUSED_RESULT.
4804         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4805
4806 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4807
4808         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4809         for-loop range, to avoid compiler warnings.
4810
4811         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4812         avoid compiler warnings about unused variables.
4813
4814         * NEWS: Mention end of support for native debugging on MS-Windows
4815         before XP.
4816
4817         PR gdb/24292
4818         * common/netstuff.c:
4819         * gdbserver/gdbreplay.c
4820         * gdbserver/remote-utils.c:
4821         * ser-tcp.c:
4822         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4823         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4824         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4825         'getaddrinfo' and 'freeaddrinfo' were not available before
4826         Windows XP, and mingw.org's MinGW headers by default define
4827         _WIN32_WINNT to 0x500.
4828
4829 2019-03-01  Gary Benson <gbenson@redhat.com>
4830
4831         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4832
4833 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4834             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4835
4836         PR gdb/8527
4837         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4838         set_sigint_trap, clear_sigint_trap.
4839
4840 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4841
4842         * target.c (target_detach): Clear the regcache and the
4843         frame cache.
4844
4845 2019-02-27  Pedro Alves  <palves@redhat.com>
4846
4847         * utils.c (set_screen_size): When we cap the height/width sizes,
4848         tweak the corresponding command variable to show "unlimited":
4849
4850 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4851             Pedro Alves  <palves@redhat.com>
4852
4853         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4854         before calling rl_set_screen_size.
4855
4856 2019-02-27  Tom Tromey  <tromey@adacore.com>
4857
4858         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4859         define.
4860         * python/py-value.c: Remove Python 2.4 workaround.
4861         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4862         workaround.
4863         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4864         Python 2.4 workaround.
4865         * python/python-internal.h: Remove Python 2.4 comment.
4866         (Py_ssize_t): Don't define.
4867         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4868         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4869         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4870         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4871         * python/python.c (do_start_initialization): Remove Python 2.4
4872         workaround.
4873         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4874         (print_children): Remove Python 2.4 workaround.
4875         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4876         workaround.
4877         (CHARBUFFERPROC_NAME): Remove.
4878         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4879         Python 2.4 workaround.
4880
4881 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4882
4883         * NEWS: Note minimum Python version.
4884
4885 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4886
4887         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4888         code from these functions.  Remove corresponding ifdefs.  Use
4889         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4890         Remove gotos and target of gotos.
4891         (infpy_search_memory): Likewise.
4892
4893 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4894
4895         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4896         (hppa_gdbarch_init): Don't register deleted functions with
4897         gdbarch.
4898
4899 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4900
4901         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4902         (h8300_unwind_sp): Delete.
4903         (h8300_dummy_id): Delete.
4904         (h8300_gdbarch_init): Don't register deleted functions with
4905         gdbarch.
4906
4907 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4908
4909         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4910         (ft32_unwind_pc): Delete.
4911         (ft32_unwind_sp): Delete.
4912         (ft32_gdbarch_init): Don't register deleted functions with
4913         gdbarch.
4914
4915 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4916
4917         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4918         (frv_unwind_pc): Delete.
4919         (frv_unwind_sp): Delete.
4920         (frv_gdbarch_init): Don't register deleted functions with
4921         gdbarch.
4922
4923 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4924
4925         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4926         (riscv_unwind_pc): Delete.
4927         (riscv_unwind_sp): Delete.
4928         (riscv_gdbarch_init): Don't register deleted functions with
4929         gdbarch.
4930
4931 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4932
4933         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4934         (csky_unwind_pc): Delete.
4935         (csky_unwind_sp): Delete.
4936         (csky_gdbarch_init): Don't register deleted functions with
4937         gdbarch.
4938
4939 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4940
4941         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4942         (cris_unwind_pc): Delete.
4943         (cris_unwind_sp): Delete.
4944         (cris_gdbarch_init): Don't register deleted functions with
4945         gdbarch.
4946
4947 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4948
4949         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4950         (bfin_unwind_pc): Delete.
4951         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4952
4953 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4954
4955         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4956         (arm_unwind_pc): Delete.
4957         (arm_unwind_sp): Delete.
4958         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4959
4960 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4961
4962         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4963         (arc_unwind_pc): Delete.
4964         (arc_unwind_sp): Delete.
4965         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4966
4967 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4968
4969         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4970         (alpha_unwind_pc): Delete.
4971         (alpha_gdbarch_init): Don't register deleted functions with
4972         gdbarch.
4973
4974 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4975
4976         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4977         (aarch64_unwind_pc): Delete.
4978         (aarch64_unwind_sp): Delete.
4979         (aarch64_gdbarch_init): Don't register deleted functions with
4980         gdbarch.
4981
4982 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4983
4984         * gdbtypes.c (type_align): Don't consider static members when
4985         computing structure alignment.
4986
4987 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4988
4989         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4990         return 0 for other types.
4991         * arch-utils.c (default_type_align): Always return 0.
4992         * gdbarch.h: Regenerate.
4993         * gdbarch.sh (type_align): Extend comment.
4994         * gdbtypes.c (type_align): Add additional comments, always call
4995         gdbarch_type_align before applying the default rules.
4996         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4997         generic code will then apply a suitable default.
4998         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4999         types, return 0 for other types.
5000
5001 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5002
5003         * NEWS: Create a new section for the next release branch.
5004         Rename the section of the current branch, now that it has
5005         been cut.
5006
5007 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5008
5009         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5010         * version.in: Bump version to 8.3.50.DATE-git.
5011
5012 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5013
5014         * aix-thread.c (ptid_cmp): Remove unused variable.
5015         (get_signaled_thread): Likewise.
5016         (store_regs_user_thread): Likewise.
5017         (store_regs_kernel_thread): Likewise.
5018         (fetch_regs_kernel_thread): Remove shadowed variable.
5019
5020 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5021
5022         * features/riscv/32bit-cpu.xml: Add register numbers.
5023         * features/riscv/32bit-fpu.c: Regenerate.
5024         * features/riscv/32bit-fpu.xml: Add register numbers.
5025         * features/riscv/64bit-cpu.xml: Add register numbers.
5026         * features/riscv/64bit-fpu.c: Regenerate.
5027         * features/riscv/64bit-fpu.xml: Add register numbers.
5028
5029 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5030
5031         * NEWS: Mention two argument form of gdb.Value constructor.
5032         * python/py-value.c (convert_buffer_and_type_to_value): New
5033         function.
5034         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5035         Add support for handling an optional second argument.  Call
5036         convert_buffer_and_type_to_value as appropriate.
5037         * python/python-internal.h (Py_buffer_deleter): New struct.
5038         (Py_buffer_up): New typedef.
5039
5040 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5041
5042         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5043         instead of releasing ownership.
5044
5045 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5046
5047         * dwarf2read.c (open_and_init_dwp_file): Call
5048         elf_numsections instead of bfd_count_sections to initialize
5049         dwp_file->num_sections.
5050
5051 2019-02-25  Tom Tromey  <tromey@adacore.com>
5052
5053         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5054
5055 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5056
5057         * gcore.in: Add '--readnever' option when invoking GDB.
5058
5059 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5060
5061         * MAINTAINERS: Update my email address.
5062
5063 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5064
5065         * build-id.c (build_id_to_debug_bfd_1): New function.
5066         (build_id_to_debug_bfd): Look for separate debug file in
5067         sysroot.
5068
5069 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5070
5071         * gdbarch.sh: Update the copyright year range that is placed into
5072         generated files.
5073
5074 2019-02-22  Keith Seitz  <keiths@redhat.com>
5075
5076         PR symtab/23853
5077         * linespec.c (create_sals_line_offset): Search for the default
5078         symtab's filename instead of its fullname.
5079
5080 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5081
5082         * NEWS: Update style defaults.
5083
5084 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5085
5086         * main.c (captured_main_1): Disable styling in batch mode.
5087
5088 2019-02-20  Tom Tromey  <tom@tromey.com>
5089
5090         * symtab.c (symtab_symbol_info): Fix typos.
5091
5092 2019-02-20  Tom Tromey  <tromey@adacore.com>
5093
5094         * findcmd.c (_initialize_mem_search): Use upper case for
5095         metasyntactic variables.
5096
5097 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5098
5099         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5100         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5101
5102 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5103
5104         * top.h (source_file_name): Change to std::string.
5105         * top.c (source_file_name): Likewise.
5106         (command_line_input): Adjust.
5107         * cli/cli-script.c (script_from_file): Adjust.
5108
5109 2019-02-19  Tom Tromey  <tromey@adacore.com>
5110
5111         * ravenscar-thread.c
5112         (ravenscar_thread_target::update_thread_list): Don't call
5113         ada_build_task_list.
5114         * ada-lang.h (ada_build_task_list): Don't declare.
5115         * ada-tasks.c (struct ada_tasks_inferior_data)
5116         <task_list_valid_p>: Now bool.
5117         (read_known_tasks, ada_task_list_changed)
5118         (ada_tasks_invalidate_inferior_data): Update.
5119         (read_known_tasks_array): Return bool.
5120         (read_known_tasks_list): Likewise.
5121         (read_known_tasks): Return void.
5122         (ada_build_task_list): Now static.
5123
5124 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5125
5126         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5127         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5128
5129 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5130
5131         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5132         variant for ada_tasks_pspace_data_handle and
5133         ada_tasks_inferior_data_handle.
5134         (ada_tasks_pspace_data_cleanup): New function.
5135         (ada_tasks_inferior_data_cleanup): New function.
5136
5137 2019-02-17  Tom Tromey  <tom@tromey.com>
5138
5139         * macrotab.h (macro_source_fullname): Return a std::string.
5140         * macrotab.c (macro_include, check_for_redefinition)
5141         (macro_undef, macro_lookup_definition, foreach_macro)
5142         (foreach_macro_in_scope): Update.
5143         (macro_source_fullname): Return a std::string.
5144         * macrocmd.c (show_pp_source_pos): Update.
5145
5146 2019-02-17  Tom Tromey  <tom@tromey.com>
5147
5148         * macrocmd.c (show_pp_source_pos): Style the file names.
5149
5150 2019-02-17  Tom Tromey  <tom@tromey.com>
5151
5152         PR tui/24197:
5153         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5154
5155 2019-02-17  Tom Tromey  <tom@tromey.com>
5156
5157         * ada-lang.c (user_select_syms): Use filtered printing.
5158         * utils.c (wrap_style): New global.
5159         (desired_style): Remove.
5160         (emit_style_escape): Add stream parameter.
5161         (set_output_style, reset_terminal_style, prompt_for_continue):
5162         Update.
5163         (flush_wrap_buffer): Only flush gdb_stdout.
5164         (wrap_here): Set wrap_style.
5165         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5166         treat escape sequences as a character.  Change when wrap buffer is
5167         flushed.
5168         (fputs_styled): Do not set the output style when the default is
5169         requested.
5170         * ui-style.h (struct ui_file_style) <is_default>: New method.
5171         * source.c (print_source_lines_base): Emit escape sequences in one
5172         piece.
5173
5174 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5175
5176         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5177         integers and enumeration types.
5178
5179 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5180
5181         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5182         instead of lookup_symbol_in_language
5183         (do_exact_match): New function.
5184         (ada_get_symbol_name_matcher): Return do_exact_match when
5185         doing a verbatim match.
5186
5187 2019-02-15  Tom Tromey  <tromey@adacore.com>
5188
5189         * ravenscar-thread.c (ravenscar_thread_target::resume)
5190         (ravenscar_thread_target::wait): Special case wildcard requests.
5191
5192 2019-02-15  Tom Tromey  <tromey@adacore.com>
5193
5194         * ravenscar-thread.c (base_ptid): Remove.
5195         (struct ravenscar_thread_target) <close>: New method.
5196         <m_base_ptid>: New member.
5197         <update_inferior_ptid, active_task, task_is_currently_active,
5198         runtime_initialized>: Declare methods.
5199         <ravenscar_thread_target>: Add constructor.
5200         (ravenscar_thread_target::task_is_currently_active)
5201         (ravenscar_thread_target::update_inferior_ptid)
5202         (ravenscar_runtime_initialized): Rename.  Now methods.
5203         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5204         (ravenscar_thread_target::update_thread_list): Update.
5205         (ravenscar_thread_target::active_task): Now method.
5206         (ravenscar_thread_target::store_registers)
5207         (ravenscar_thread_target::prepare_to_store)
5208         (ravenscar_thread_target::prepare_to_store)
5209         (ravenscar_thread_target::mourn_inferior): Update.
5210         (ravenscar_inferior_created): Use "new" to create target.
5211         (ravenscar_thread_target::get_ada_task_ptid): Update.
5212         (_initialize_ravenscar): Don't initialize base_ptid.
5213         (ravenscar_ops): Remove global.
5214
5215 2019-02-15  Tom Tromey  <tromey@adacore.com>
5216
5217         * target.h (push_target): Declare new overload.
5218         * target.c (push_target): New overload, taking an rvalue reference.
5219         * remote.c (remote_target::open_1): Use push_target overload.
5220         * corelow.c (core_target_open): Use push_target overload.
5221
5222 2019-02-15  Tom Tromey  <tromey@adacore.com>
5223
5224         * ravenscar-thread.c (is_ravenscar_task)
5225         (ravenscar_task_is_currently_active): Return bool.
5226         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5227         (_initialize_ravenscar): Remove "(void)".
5228         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5229         Return bool.
5230
5231 2019-02-15  Tom Tromey  <tromey@adacore.com>
5232
5233         * ravenscar-thread.c (ravenscar_runtime_initializer)
5234         (has_ravenscar_runtime, get_running_thread_id)
5235         (ravenscar_thread_target::resume): Fix indentation.
5236
5237 2019-02-15  Tom Tromey  <tromey@adacore.com>
5238
5239         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5240         from ravenscar_arch_ops.
5241         (sparc_ravenscar_ops::fetch_registers)
5242         (sparc_ravenscar_ops::store_registers): Now methods.
5243         (sparc_ravenscar_prepare_to_store): Remove.
5244         (sparc_ravenscar_ops): Redefine.
5245         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5246         methods and destructor.  Remove members.
5247         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5248         (ravenscar_thread_target::store_registers)
5249         (ravenscar_thread_target::prepare_to_store): Update.
5250         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5251         Remove.
5252         (struct ppc_ravenscar_powerpc_ops): Derive from
5253         ravenscar_arch_ops.
5254         (ppc_ravenscar_powerpc_ops::fetch_registers)
5255         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5256         (ppc_ravenscar_powerpc_ops): Redefine.
5257         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5258         (ppc_ravenscar_e500_ops::fetch_registers)
5259         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5260         (ppc_ravenscar_e500_ops): Redefine.
5261         * aarch64-ravenscar-thread.c
5262         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5263         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5264         (aarch64_ravenscar_fetch_registers)
5265         (aarch64_ravenscar_store_registers): Now methods.
5266         (aarch64_ravenscar_ops): Redefine.
5267
5268 2019-02-15  Tom Tromey  <tromey@adacore.com>
5269
5270         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5271         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5272         (ravenscar_thread_target::stopped_by_watchpoint)
5273         (ravenscar_thread_target::stopped_data_address)
5274         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5275
5276 2019-02-15  Tom Tromey  <tromey@adacore.com>
5277
5278         * ravenscar-thread.c: Fix some typos.
5279
5280 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5281             Tom Tromey  <tromey@adacore.com>
5282
5283         * ada-lang.c (ada_exception_sal): Change addr_string to a
5284         std::string.
5285         (create_ada_exception_catchpoint): Update.
5286
5287 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5288             Tom Tromey  <tromey@adacore.com>
5289
5290         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5291         (bp_location_ops): Remove.
5292         (base_breakpoint_allocate_location): Update.
5293         (free_bp_location): Update.
5294         * ada-lang.c (class ada_catchpoint_location)
5295         <ada_catchpoint_location>: Remove ops parameter.
5296         (ada_catchpoint_location_dtor): Remove.
5297         (ada_catchpoint_location_ops): Remove.
5298         (allocate_location_exception): Update.
5299         * breakpoint.h (struct bp_location_ops): Remove.
5300         (class bp_location) <bp_location>: Remove bp_location_ops
5301         parameter.
5302         <~bp_location>: Add destructor.
5303         <ops>: Remove.
5304
5305 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5306             Pedro Alves  <palves@redhat.com>
5307
5308         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5309         'PATH_MAX'.
5310
5311 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5312             Samuel Thibault  <samuel.thibault@gnu.org>
5313             Thomas Schwinge  <thomas@codesourcery.com>
5314
5315         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5316         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5317
5318 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5319
5320         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5321         (check_empty): Use "const char *".
5322
5323         * gnu-nat.c (gnu_nat_target::detach): Instead of
5324         'detach_inferior (pid)' call
5325         'detach_inferior (find_inferior_pid (pid))'.
5326
5327         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5328         'nat/fork-inferior.o'.
5329         * gnu-nat.c: #include "nat/fork-inferior.h".
5330
5331         * gnu-nat.c (gnu_nat_target::detach): Instead of
5332         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5333         * gnu-nat.h: #include "inf-child.h".
5334         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5335         'i386_gnu_nat_target::fetch_registers'.
5336         (gnu_store_registers): Rename/move to
5337         'i386_gnu_nat_target::store_registers'.
5338
5339         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5340         * gnu-nat.h (mach_thread_info): New function.
5341         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5342
5343         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5344
5345 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5346
5347         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5348
5349 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5350
5351         * windows-nat.c (windows_add_thread): Add new parameter
5352         "main_thread_p" with default value set to false.  Update
5353         function documentation as well as all callers.
5354         (windows_delete_thread): Likewise.
5355         (fake_create_process): Update call to windows_add_thread.
5356         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5357         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5358         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5359         call to windows_delete_thread.
5360
5361 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5362
5363         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5364
5365 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5366
5367         * symfile.c (find_separate_debug_file): Use canonical path of
5368         sysroot with child_path instead of gdb_sysroot if it is valid.
5369
5370 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5371
5372         * symfile.c (find_separate_debug_file): Use child_path to
5373         determine if an object file is under a sysroot.
5374
5375 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5376
5377         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5378         unittests/child-path-selftests.c.
5379         * common/pathstuff.c (child_path): New function.
5380         * common/pathstuff.h (child_path): New prototype.
5381         * unittests/child-path-selftests.c: New file.
5382
5383 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5384
5385         * symfile.c (find_separate_debug_file): Look for separate debug
5386         files in debug directories under the sysroot.
5387
5388 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5389
5390         * symtab.h (struct minimal_symbol data_p): New const method.
5391         (struct minimal_symbol text_p): Likewise.
5392         * symtab.c (output_source_filename): Use file name style
5393         to print file name.
5394         (print_symbol_info): Likewise.
5395         (print_msymbol_info): Use address style to print addresses.
5396         Use function name style to print executable text symbols.
5397         (expand_symtab_containing_pc): Use data_p.
5398         (find_pc_sect_compunit_symtab): Likewise.
5399
5400 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5401
5402         * breakpoint.c (describe_other_breakpoints): Use address style
5403         to print addresses.
5404         (say_where): Likewise.
5405
5406 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5407
5408         * ada-typeprint.c (print_func_type): Print function name
5409         style to print function name.
5410         * c-typeprint.c (c_print_type_1): Likewise.
5411
5412 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5413
5414         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5415         for execve.
5416
5417 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5418
5419         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5420         type_stack.
5421
5422 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5423
5424         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5425         TYPE_CODE_REF types.
5426
5427 2019-02-08  Jim Wilson  <jimw@sifive.com>
5428
5429         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5430         (riscv_linux_fregset): New.
5431         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5432
5433 2019-02-07  Tom Tromey  <tom@tromey.com>
5434
5435         * thread.c (thread_cancel_execution_command): Update.
5436         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5437         methods.
5438         (struct thread_fsm_ops): Remove.
5439         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5440         (thread_fsm_should_stop, thread_fsm_return_value)
5441         (thread_fsm_set_finished, thread_fsm_finished_p)
5442         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5443         Don't declare.
5444         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5445         * infrun.c (clear_proceed_status_thread)
5446         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5447         (print_stop_event): Update.
5448         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5449         Add constructor.
5450         (step_command_fsm_ops): Remove.
5451         (new_step_command_fsm): Remove.
5452         (step_1): Update.
5453         (step_command_fsm::should_stop): Rename from
5454         step_command_fsm_should_stop.
5455         (step_command_fsm::clean_up): Rename from
5456         step_command_fsm_clean_up.
5457         (step_command_fsm::do_async_reply_reason): Rename from
5458         step_command_fsm_async_reply_reason.
5459         (struct until_next_fsm): Inherit from thread_fsm.  Add
5460         constructor.
5461         (until_next_fsm_ops): Remove.
5462         (new_until_next_fsm): Remove.
5463         (until_next_fsm::should_stop): Rename from
5464         until_next_fsm_should_stop.
5465         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5466         (until_next_fsm::do_async_reply_reason): Rename from
5467         until_next_fsm_async_reply_reason.
5468         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5469         constructor.  Change type of breakpoint.
5470         (finish_command_fsm_ops): Remove.
5471         (new_finish_command_fsm): Remove.
5472         (finish_command_fsm::should_stop): Rename from
5473         finish_command_fsm_should_stop.
5474         (finish_command_fsm::clean_up): Rename from
5475         finish_command_fsm_clean_up.
5476         (finish_command_fsm::return_value): Rename from
5477         finish_command_fsm_return_value.
5478         (finish_command_fsm::do_async_reply_reason): Rename from
5479         finish_command_fsm_async_reply_reason.
5480         (finish_command): Update.
5481         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5482         Add constructor.
5483         (call_thread_fsm_ops): Remove.
5484         (call_thread_fsm::call_thread_fsm): Rename from
5485         new_call_thread_fsm.
5486         (call_thread_fsm::should_stop): Rename from
5487         call_thread_fsm_should_stop.
5488         (call_thread_fsm::should_notify_stop): Rename from
5489         call_thread_fsm_should_notify_stop.
5490         (run_inferior_call, call_function_by_hand_dummy): Update.
5491         * cli/cli-interp.c (should_print_stop_to_console): Update.
5492         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5493         Add constructor.  Change type of location_breakpoint,
5494         caller_breakpoint.
5495         (until_break_fsm_ops): Remove.
5496         (new_until_break_fsm): Remove.
5497         (until_break_fsm::should_stop): Rename from
5498         until_break_fsm_should_stop.
5499         (until_break_fsm::clean_up): Rename from
5500         until_break_fsm_clean_up.
5501         (until_break_fsm::do_async_reply_reason): Rename from
5502         until_break_fsm_async_reply_reason.
5503         (until_break_command): Update.
5504         * thread-fsm.c: Remove.
5505         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5506
5507 2019-02-07  Tom Tromey  <tom@tromey.com>
5508
5509         * yy-remap.h: Add include guard.
5510         * xtensa-tdep.h: Add include guard.
5511         * xcoffread.h: Rename include guard.
5512         * varobj-iter.h: Add include guard.
5513         * tui/tui.h: Rename include guard.
5514         * tui/tui-winsource.h: Rename include guard.
5515         * tui/tui-wingeneral.h: Rename include guard.
5516         * tui/tui-windata.h: Rename include guard.
5517         * tui/tui-win.h: Rename include guard.
5518         * tui/tui-stack.h: Rename include guard.
5519         * tui/tui-source.h: Rename include guard.
5520         * tui/tui-regs.h: Rename include guard.
5521         * tui/tui-out.h: Rename include guard.
5522         * tui/tui-layout.h: Rename include guard.
5523         * tui/tui-io.h: Rename include guard.
5524         * tui/tui-hooks.h: Rename include guard.
5525         * tui/tui-file.h: Rename include guard.
5526         * tui/tui-disasm.h: Rename include guard.
5527         * tui/tui-data.h: Rename include guard.
5528         * tui/tui-command.h: Rename include guard.
5529         * tic6x-tdep.h: Add include guard.
5530         * target/waitstatus.h: Rename include guard.
5531         * target/wait.h: Rename include guard.
5532         * target/target.h: Rename include guard.
5533         * target/resume.h: Rename include guard.
5534         * target-float.h: Rename include guard.
5535         * stabsread.h: Add include guard.
5536         * rs6000-tdep.h: Add include guard.
5537         * riscv-fbsd-tdep.h: Add include guard.
5538         * regformats/regdef.h: Rename include guard.
5539         * record.h: Rename include guard.
5540         * python/python.h: Rename include guard.
5541         * python/python-internal.h: Rename include guard.
5542         * python/py-stopevent.h: Rename include guard.
5543         * python/py-ref.h: Rename include guard.
5544         * python/py-record.h: Rename include guard.
5545         * python/py-record-full.h: Rename include guard.
5546         * python/py-record-btrace.h: Rename include guard.
5547         * python/py-instruction.h: Rename include guard.
5548         * python/py-events.h: Rename include guard.
5549         * python/py-event.h: Rename include guard.
5550         * procfs.h: Add include guard.
5551         * proc-utils.h: Add include guard.
5552         * p-lang.h: Add include guard.
5553         * or1k-tdep.h: Rename include guard.
5554         * observable.h: Rename include guard.
5555         * nto-tdep.h: Rename include guard.
5556         * nat/x86-linux.h: Rename include guard.
5557         * nat/x86-linux-dregs.h: Rename include guard.
5558         * nat/x86-gcc-cpuid.h: Add include guard.
5559         * nat/x86-dregs.h: Rename include guard.
5560         * nat/x86-cpuid.h: Rename include guard.
5561         * nat/ppc-linux.h: Rename include guard.
5562         * nat/mips-linux-watch.h: Rename include guard.
5563         * nat/linux-waitpid.h: Rename include guard.
5564         * nat/linux-ptrace.h: Rename include guard.
5565         * nat/linux-procfs.h: Rename include guard.
5566         * nat/linux-osdata.h: Rename include guard.
5567         * nat/linux-nat.h: Rename include guard.
5568         * nat/linux-namespaces.h: Rename include guard.
5569         * nat/linux-btrace.h: Rename include guard.
5570         * nat/glibc_thread_db.h: Rename include guard.
5571         * nat/gdb_thread_db.h: Rename include guard.
5572         * nat/gdb_ptrace.h: Rename include guard.
5573         * nat/fork-inferior.h: Rename include guard.
5574         * nat/amd64-linux-siginfo.h: Rename include guard.
5575         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5576         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5577         * nat/aarch64-linux.h: Rename include guard.
5578         * nat/aarch64-linux-hw-point.h: Rename include guard.
5579         * mn10300-tdep.h: Add include guard.
5580         * mips-linux-tdep.h: Add include guard.
5581         * mi/mi-parse.h: Rename include guard.
5582         * mi/mi-out.h: Rename include guard.
5583         * mi/mi-main.h: Rename include guard.
5584         * mi/mi-interp.h: Rename include guard.
5585         * mi/mi-getopt.h: Rename include guard.
5586         * mi/mi-console.h: Rename include guard.
5587         * mi/mi-common.h: Rename include guard.
5588         * mi/mi-cmds.h: Rename include guard.
5589         * mi/mi-cmd-break.h: Rename include guard.
5590         * m2-lang.h: Add include guard.
5591         * location.h: Rename include guard.
5592         * linux-record.h: Rename include guard.
5593         * linux-nat.h: Add include guard.
5594         * linux-fork.h: Add include guard.
5595         * i386-darwin-tdep.h: Rename include guard.
5596         * hppa-linux-offsets.h: Add include guard.
5597         * guile/guile.h: Rename include guard.
5598         * guile/guile-internal.h: Rename include guard.
5599         * gnu-nat.h: Rename include guard.
5600         * gdb-stabs.h: Rename include guard.
5601         * frv-tdep.h: Add include guard.
5602         * f-lang.h: Add include guard.
5603         * event-loop.h: Add include guard.
5604         * darwin-nat.h: Rename include guard.
5605         * cp-abi.h: Rename include guard.
5606         * config/sparc/nm-sol2.h: Rename include guard.
5607         * config/nm-nto.h: Rename include guard.
5608         * config/nm-linux.h: Add include guard.
5609         * config/i386/nm-i386gnu.h: Rename include guard.
5610         * config/djgpp/nl_types.h: Rename include guard.
5611         * config/djgpp/langinfo.h: Rename include guard.
5612         * compile/gcc-cp-plugin.h: Add include guard.
5613         * compile/gcc-c-plugin.h: Add include guard.
5614         * compile/compile.h: Rename include guard.
5615         * compile/compile-object-run.h: Rename include guard.
5616         * compile/compile-object-load.h: Rename include guard.
5617         * compile/compile-internal.h: Rename include guard.
5618         * compile/compile-cplus.h: Rename include guard.
5619         * compile/compile-c.h: Rename include guard.
5620         * common/xml-utils.h: Rename include guard.
5621         * common/x86-xstate.h: Rename include guard.
5622         * common/version.h: Rename include guard.
5623         * common/vec.h: Rename include guard.
5624         * common/tdesc.h: Rename include guard.
5625         * common/selftest.h: Rename include guard.
5626         * common/scoped_restore.h: Rename include guard.
5627         * common/scoped_mmap.h: Rename include guard.
5628         * common/scoped_fd.h: Rename include guard.
5629         * common/safe-iterator.h: Rename include guard.
5630         * common/run-time-clock.h: Rename include guard.
5631         * common/refcounted-object.h: Rename include guard.
5632         * common/queue.h: Rename include guard.
5633         * common/ptid.h: Rename include guard.
5634         * common/print-utils.h: Rename include guard.
5635         * common/preprocessor.h: Rename include guard.
5636         * common/pathstuff.h: Rename include guard.
5637         * common/observable.h: Rename include guard.
5638         * common/netstuff.h: Rename include guard.
5639         * common/job-control.h: Rename include guard.
5640         * common/host-defs.h: Rename include guard.
5641         * common/gdb_wait.h: Rename include guard.
5642         * common/gdb_vecs.h: Rename include guard.
5643         * common/gdb_unlinker.h: Rename include guard.
5644         * common/gdb_unique_ptr.h: Rename include guard.
5645         * common/gdb_tilde_expand.h: Rename include guard.
5646         * common/gdb_sys_time.h: Rename include guard.
5647         * common/gdb_string_view.h: Rename include guard.
5648         * common/gdb_splay_tree.h: Rename include guard.
5649         * common/gdb_setjmp.h: Rename include guard.
5650         * common/gdb_ref_ptr.h: Rename include guard.
5651         * common/gdb_optional.h: Rename include guard.
5652         * common/gdb_locale.h: Rename include guard.
5653         * common/gdb_assert.h: Rename include guard.
5654         * common/filtered-iterator.h: Rename include guard.
5655         * common/filestuff.h: Rename include guard.
5656         * common/fileio.h: Rename include guard.
5657         * common/environ.h: Rename include guard.
5658         * common/common-utils.h: Rename include guard.
5659         * common/common-types.h: Rename include guard.
5660         * common/common-regcache.h: Rename include guard.
5661         * common/common-inferior.h: Rename include guard.
5662         * common/common-gdbthread.h: Rename include guard.
5663         * common/common-exceptions.h: Rename include guard.
5664         * common/common-defs.h: Rename include guard.
5665         * common/common-debug.h: Rename include guard.
5666         * common/cleanups.h: Rename include guard.
5667         * common/buffer.h: Rename include guard.
5668         * common/btrace-common.h: Rename include guard.
5669         * common/break-common.h: Rename include guard.
5670         * cli/cli-utils.h: Rename include guard.
5671         * cli/cli-style.h: Rename include guard.
5672         * cli/cli-setshow.h: Rename include guard.
5673         * cli/cli-script.h: Rename include guard.
5674         * cli/cli-interp.h: Rename include guard.
5675         * cli/cli-decode.h: Rename include guard.
5676         * cli/cli-cmds.h: Rename include guard.
5677         * charset-list.h: Add include guard.
5678         * buildsym-legacy.h: Rename include guard.
5679         * bfin-tdep.h: Add include guard.
5680         * ax.h: Rename include guard.
5681         * arm-linux-tdep.h: Add include guard.
5682         * arm-fbsd-tdep.h: Add include guard.
5683         * arch/xtensa.h: Rename include guard.
5684         * arch/tic6x.h: Add include guard.
5685         * arch/i386.h: Add include guard.
5686         * arch/arm.h: Rename include guard.
5687         * arch/arm-linux.h: Rename include guard.
5688         * arch/arm-get-next-pcs.h: Rename include guard.
5689         * arch/amd64.h: Add include guard.
5690         * arch/aarch64-insn.h: Rename include guard.
5691         * arch-utils.h: Rename include guard.
5692         * annotate.h: Add include guard.
5693         * amd64-darwin-tdep.h: Rename include guard.
5694         * aarch64-linux-tdep.h: Add include guard.
5695         * aarch64-fbsd-tdep.h: Add include guard.
5696         * aarch32-linux-nat.h: Add include guard.
5697
5698 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5699
5700         * macrotab.c (macro_define_internal): New function that
5701         factorizes macro_define_object_internal and macro_define_function
5702         code.
5703         (macro_define_object_internal): Use macro_define_internal.
5704         (macro_define_function): Likewise.
5705
5706 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5707
5708         * macrocmd.c (extract_identifier): Return
5709         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5710         callers.
5711
5712 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5713
5714         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5715
5716 2019-02-05  Tom Tromey  <tom@tromey.com>
5717
5718         * target.c (target_stack::unpush): Move assertion earlier.
5719
5720 2019-01-30  Tom Tromey  <tom@tromey.com>
5721
5722         PR python/23615:
5723         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5724         (gdbpy_parse_and_eval): Likewise.
5725         * python/python-internal.h (gdbpy_allow_threads): New class.
5726
5727 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5728
5729         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5730         (aarch64_fbsd_fpregmap): Move earlier.
5731         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5732         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5733         instead of individual calls to trad_frame_set_reg_addr.
5734         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5735         earlier.
5736         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5737         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5738         instead of individual calls to trad_frame_set_reg_addr.
5739
5740 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5741
5742         * CONTRIBUTE: Replace contribution list with wiki link.
5743
5744 2019-01-25  Tom Tromey  <tom@tromey.com>
5745
5746         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5747
5748 2019-01-25  Tom Tromey  <tom@tromey.com>
5749
5750         * xtensa-linux-nat.c: Fix common/ includes.
5751         * xml-support.h: Fix common/ includes.
5752         * xml-support.c: Fix common/ includes.
5753         * x86-linux-nat.c: Fix common/ includes.
5754         * windows-nat.c: Fix common/ includes.
5755         * varobj.h: Fix common/ includes.
5756         * varobj.c: Fix common/ includes.
5757         * value.c: Fix common/ includes.
5758         * valops.c: Fix common/ includes.
5759         * utils.c: Fix common/ includes.
5760         * unittests/xml-utils-selftests.c: Fix common/ includes.
5761         * unittests/utils-selftests.c: Fix common/ includes.
5762         * unittests/unpack-selftests.c: Fix common/ includes.
5763         * unittests/tracepoint-selftests.c: Fix common/ includes.
5764         * unittests/style-selftests.c: Fix common/ includes.
5765         * unittests/string_view-selftests.c: Fix common/ includes.
5766         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5767         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5768         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5769         * unittests/rsp-low-selftests.c: Fix common/ includes.
5770         * unittests/parse-connection-spec-selftests.c: Fix common/
5771         includes.
5772         * unittests/optional-selftests.c: Fix common/ includes.
5773         * unittests/offset-type-selftests.c: Fix common/ includes.
5774         * unittests/observable-selftests.c: Fix common/ includes.
5775         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5776         * unittests/memrange-selftests.c: Fix common/ includes.
5777         * unittests/memory-map-selftests.c: Fix common/ includes.
5778         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5779         * unittests/function-view-selftests.c: Fix common/ includes.
5780         * unittests/environ-selftests.c: Fix common/ includes.
5781         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5782         * unittests/common-utils-selftests.c: Fix common/ includes.
5783         * unittests/cli-utils-selftests.c: Fix common/ includes.
5784         * unittests/array-view-selftests.c: Fix common/ includes.
5785         * ui-file.c: Fix common/ includes.
5786         * tui/tui-io.c: Fix common/ includes.
5787         * tracepoint.h: Fix common/ includes.
5788         * tracepoint.c: Fix common/ includes.
5789         * tracefile-tfile.c: Fix common/ includes.
5790         * top.h: Fix common/ includes.
5791         * top.c: Fix common/ includes.
5792         * thread.c: Fix common/ includes.
5793         * target/waitstatus.h: Fix common/ includes.
5794         * target/waitstatus.c: Fix common/ includes.
5795         * target.h: Fix common/ includes.
5796         * target.c: Fix common/ includes.
5797         * target-memory.c: Fix common/ includes.
5798         * target-descriptions.c: Fix common/ includes.
5799         * symtab.h: Fix common/ includes.
5800         * symfile.c: Fix common/ includes.
5801         * stap-probe.c: Fix common/ includes.
5802         * spu-linux-nat.c: Fix common/ includes.
5803         * sparc-nat.c: Fix common/ includes.
5804         * source.c: Fix common/ includes.
5805         * solib.c: Fix common/ includes.
5806         * solib-target.c: Fix common/ includes.
5807         * ser-unix.c: Fix common/ includes.
5808         * ser-tcp.c: Fix common/ includes.
5809         * ser-pipe.c: Fix common/ includes.
5810         * ser-base.c: Fix common/ includes.
5811         * selftest-arch.c: Fix common/ includes.
5812         * s12z-tdep.c: Fix common/ includes.
5813         * rust-exp.y: Fix common/ includes.
5814         * rs6000-aix-tdep.c: Fix common/ includes.
5815         * riscv-tdep.c: Fix common/ includes.
5816         * remote.c: Fix common/ includes.
5817         * remote-notif.h: Fix common/ includes.
5818         * remote-fileio.h: Fix common/ includes.
5819         * remote-fileio.c: Fix common/ includes.
5820         * regcache.h: Fix common/ includes.
5821         * regcache.c: Fix common/ includes.
5822         * record-btrace.c: Fix common/ includes.
5823         * python/python.c: Fix common/ includes.
5824         * python/py-type.c: Fix common/ includes.
5825         * python/py-inferior.c: Fix common/ includes.
5826         * progspace.h: Fix common/ includes.
5827         * producer.c: Fix common/ includes.
5828         * procfs.c: Fix common/ includes.
5829         * proc-api.c: Fix common/ includes.
5830         * printcmd.c: Fix common/ includes.
5831         * ppc-linux-nat.c: Fix common/ includes.
5832         * parser-defs.h: Fix common/ includes.
5833         * osdata.c: Fix common/ includes.
5834         * obsd-nat.c: Fix common/ includes.
5835         * nat/x86-linux.c: Fix common/ includes.
5836         * nat/x86-linux-dregs.c: Fix common/ includes.
5837         * nat/x86-dregs.h: Fix common/ includes.
5838         * nat/x86-dregs.c: Fix common/ includes.
5839         * nat/ppc-linux.c: Fix common/ includes.
5840         * nat/mips-linux-watch.h: Fix common/ includes.
5841         * nat/mips-linux-watch.c: Fix common/ includes.
5842         * nat/linux-waitpid.c: Fix common/ includes.
5843         * nat/linux-ptrace.h: Fix common/ includes.
5844         * nat/linux-ptrace.c: Fix common/ includes.
5845         * nat/linux-procfs.c: Fix common/ includes.
5846         * nat/linux-personality.c: Fix common/ includes.
5847         * nat/linux-osdata.c: Fix common/ includes.
5848         * nat/linux-namespaces.c: Fix common/ includes.
5849         * nat/linux-btrace.h: Fix common/ includes.
5850         * nat/linux-btrace.c: Fix common/ includes.
5851         * nat/fork-inferior.c: Fix common/ includes.
5852         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5853         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5854         * nat/aarch64-linux.c: Fix common/ includes.
5855         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5856         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5857         * namespace.h: Fix common/ includes.
5858         * mips-linux-tdep.c: Fix common/ includes.
5859         * minsyms.c: Fix common/ includes.
5860         * mi/mi-parse.h: Fix common/ includes.
5861         * mi/mi-main.c: Fix common/ includes.
5862         * mi/mi-cmd-env.c: Fix common/ includes.
5863         * memrange.h: Fix common/ includes.
5864         * memattr.c: Fix common/ includes.
5865         * maint.h: Fix common/ includes.
5866         * maint.c: Fix common/ includes.
5867         * main.c: Fix common/ includes.
5868         * machoread.c: Fix common/ includes.
5869         * location.c: Fix common/ includes.
5870         * linux-thread-db.c: Fix common/ includes.
5871         * linux-nat.c: Fix common/ includes.
5872         * linux-fork.c: Fix common/ includes.
5873         * inline-frame.c: Fix common/ includes.
5874         * infrun.c: Fix common/ includes.
5875         * inflow.c: Fix common/ includes.
5876         * inferior.h: Fix common/ includes.
5877         * inferior.c: Fix common/ includes.
5878         * infcmd.c: Fix common/ includes.
5879         * inf-ptrace.c: Fix common/ includes.
5880         * inf-child.c: Fix common/ includes.
5881         * ia64-linux-nat.c: Fix common/ includes.
5882         * i387-tdep.c: Fix common/ includes.
5883         * i386-tdep.c: Fix common/ includes.
5884         * i386-linux-tdep.c: Fix common/ includes.
5885         * i386-linux-nat.c: Fix common/ includes.
5886         * i386-go32-tdep.c: Fix common/ includes.
5887         * i386-fbsd-tdep.c: Fix common/ includes.
5888         * i386-fbsd-nat.c: Fix common/ includes.
5889         * guile/scm-type.c: Fix common/ includes.
5890         * guile/guile.c: Fix common/ includes.
5891         * go32-nat.c: Fix common/ includes.
5892         * gnu-nat.c: Fix common/ includes.
5893         * gdbthread.h: Fix common/ includes.
5894         * gdbarch-selftests.c: Fix common/ includes.
5895         * gdb_usleep.c: Fix common/ includes.
5896         * gdb_select.h: Fix common/ includes.
5897         * gdb_bfd.c: Fix common/ includes.
5898         * gcore.c: Fix common/ includes.
5899         * fork-child.c: Fix common/ includes.
5900         * findvar.c: Fix common/ includes.
5901         * fbsd-nat.c: Fix common/ includes.
5902         * event-top.c: Fix common/ includes.
5903         * event-loop.c: Fix common/ includes.
5904         * dwarf2read.c: Fix common/ includes.
5905         * dwarf2loc.c: Fix common/ includes.
5906         * dwarf2-frame.c: Fix common/ includes.
5907         * dwarf-index-cache.c: Fix common/ includes.
5908         * dtrace-probe.c: Fix common/ includes.
5909         * disasm-selftests.c: Fix common/ includes.
5910         * defs.h: Fix common/ includes.
5911         * csky-tdep.c: Fix common/ includes.
5912         * cp-valprint.c: Fix common/ includes.
5913         * cp-support.h: Fix common/ includes.
5914         * cp-support.c: Fix common/ includes.
5915         * corelow.c: Fix common/ includes.
5916         * completer.h: Fix common/ includes.
5917         * completer.c: Fix common/ includes.
5918         * compile/compile.c: Fix common/ includes.
5919         * compile/compile-loc2c.c: Fix common/ includes.
5920         * compile/compile-cplus-types.c: Fix common/ includes.
5921         * compile/compile-cplus-symbols.c: Fix common/ includes.
5922         * command.h: Fix common/ includes.
5923         * cli/cli-dump.c: Fix common/ includes.
5924         * cli/cli-cmds.c: Fix common/ includes.
5925         * charset.c: Fix common/ includes.
5926         * build-id.c: Fix common/ includes.
5927         * btrace.h: Fix common/ includes.
5928         * btrace.c: Fix common/ includes.
5929         * breakpoint.h: Fix common/ includes.
5930         * breakpoint.c: Fix common/ includes.
5931         * ax.h:
5932         (enum agent_op): Fix common/ includes.
5933         * ax-general.c (struct aop_map): Fix common/ includes.
5934         * ax-gdb.c: Fix common/ includes.
5935         * auxv.c: Fix common/ includes.
5936         * auto-load.c: Fix common/ includes.
5937         * arm-tdep.c: Fix common/ includes.
5938         * arch/riscv.c: Fix common/ includes.
5939         * arch/ppc-linux-common.c: Fix common/ includes.
5940         * arch/i386.c: Fix common/ includes.
5941         * arch/arm.c: Fix common/ includes.
5942         * arch/arm-linux.c: Fix common/ includes.
5943         * arch/arm-get-next-pcs.c: Fix common/ includes.
5944         * arch/amd64.c: Fix common/ includes.
5945         * arch/aarch64.c: Fix common/ includes.
5946         * arch/aarch64-insn.c: Fix common/ includes.
5947         * arch-utils.c: Fix common/ includes.
5948         * amd64-windows-tdep.c: Fix common/ includes.
5949         * amd64-tdep.c: Fix common/ includes.
5950         * amd64-sol2-tdep.c: Fix common/ includes.
5951         * amd64-obsd-tdep.c: Fix common/ includes.
5952         * amd64-nbsd-tdep.c: Fix common/ includes.
5953         * amd64-linux-tdep.c: Fix common/ includes.
5954         * amd64-linux-nat.c: Fix common/ includes.
5955         * amd64-fbsd-tdep.c: Fix common/ includes.
5956         * amd64-fbsd-nat.c: Fix common/ includes.
5957         * amd64-dicos-tdep.c: Fix common/ includes.
5958         * amd64-darwin-tdep.c: Fix common/ includes.
5959         * agent.c: Fix common/ includes.
5960         * ada-lang.h: Fix common/ includes.
5961         * ada-lang.c: Fix common/ includes.
5962         * aarch64-tdep.c: Fix common/ includes.
5963
5964 2019-01-25  Tom Tromey  <tom@tromey.com>
5965
5966         * common/create-version.sh: Use common/version.h.
5967
5968 2019-01-24  Pedro Alves  <palves@redhat.com>
5969
5970         * infrun.c (signal_stop, signal_print, signal_program)
5971         (signal_catch, signal_pass): Now arrays instead of pointers.
5972         (update_signals_program_target, do_target_resume)
5973         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5974         * linux-nat.c (linux_nat_target::pass_signals)
5975         (linux_nat_target::create_inferior, linux_nat_target::attach):
5976         Adjust.
5977         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5978         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5979         * procfs.c (procfs_target::pass_signals): Adjust.
5980         * record-full.c (record_full_target::resume): Adjust.
5981         * remote.c (remote_target::pass_signals)
5982         (remote_target::program_signals): Adjust.
5983         * target-debug.h (target_debug_print_signals): Now takes a
5984         gdb::array_view as parameter.  Adjust.
5985         * target.h (target_ops) <pass_signals, program_signals>: Replace
5986         pointer and length parameters with gdb::array_view.
5987         (target_pass_signals, target_program_signals): Likewise.
5988         * target-delegates.c: Regenerate.
5989
5990 2019-01-24  Pedro Alves  <palves@redhat.com>
5991
5992         * common/forward-scope-exit.h
5993         (forward_scope_exit::forward_scope_exit): Pass arguments to
5994         m_bind_function directly, instead of creating a std::bind and
5995         copying that.
5996
5997 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5998
5999         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6000         for static members.
6001         (pass_in_v_vfp_candidate): Likewise.
6002
6003 2019-01-23  Tom Tromey  <tom@tromey.com>
6004             Pedro Alves  <palves@redhat.com>
6005
6006         * regcache.c (class regcache_invalidator): Remove.
6007         (regcache::raw_write): Use make_scope_exit.
6008
6009 2019-01-23  Tom Tromey  <tom@tromey.com>
6010
6011         * ui-out.h (class ui_out_emit_type): Update comment.
6012
6013 2019-01-23  Tom Tromey  <tom@tromey.com>
6014
6015         * infrun.c (fetch_inferior_event): Update comment.
6016
6017 2019-01-23  Tom Tromey  <tom@tromey.com>
6018             Pedro Alves  <palves@redhat.com>
6019
6020         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6021         parameter.
6022         (fetch_inferior_event): Use SCOPE_EXIT.
6023
6024
6025 2019-01-23  Tom Tromey  <tom@tromey.com>
6026             Pedro Alves  <palves@redhat.com>
6027
6028         * infrun.c (disable_thread_events): Delete.
6029         (stop_all_threads): Use SCOPE_EXIT.
6030
6031 2019-01-23  Tom Tromey  <tom@tromey.com>
6032             Pedro Alves  <palves@redhat.com>
6033
6034         * symfile.c: Include forward-scope-exit.h.
6035         (clear_symtab_users_cleanup): Replace forward declaration with
6036         a FORWARD_SCOPE_EXIT.
6037         (syms_from_objfile_1): Use the forward_scope_exit and
6038         gdb::optional instead of cleanup_function.
6039         (reread_symbols): Use the forward_scope_exit instead of
6040         cleanup_function.
6041         (clear_symtab_users_cleanup): Remove function.
6042
6043 2019-01-23  Tom Tromey  <tom@tromey.com>
6044             Pedro Alves  <palves@redhat.com>
6045
6046         * linux-nat.c: Include scope-exit.h.
6047         (cleanup_target_stop): Remove.
6048         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6049         SCOPE_EXIT.
6050
6051 2019-01-23  Tom Tromey  <tom@tromey.com>
6052             Pedro Alves  <palves@redhat.com>
6053
6054         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6055         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6056
6057 2019-01-23  Tom Tromey  <tom@tromey.com>
6058             Andrew Burgess  <andrew.burgess@embecosm.com>
6059             Pedro Alves  <palves@redhat.com>
6060
6061         * infrun.c (fetch_inferior_event): Use scope_exit.
6062         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6063         * top.c (execute_command): Use scope_exit.
6064         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6065         * utils.c (do_bpstat_clear_actions_cleanup)
6066         (make_bpstat_clear_actions_cleanup): Remove.
6067
6068 2019-01-23  Tom Tromey  <tom@tromey.com>
6069             Pedro Alves  <palves@redhat.com>
6070
6071         * infrun.c: Include "common/scope-exit.h"
6072         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6073         (wait_for_inferior): Use SCOPE_EXIT.
6074         (fetch_inferior_event): Use scope_exit.
6075
6076 2019-01-23  Tom Tromey  <tom@tromey.com>
6077             Pedro Alves  <palves@redhat.com>
6078
6079         * breakpoint.c (create_breakpoint): Remove cleanup.
6080
6081 2019-01-23  Tom Tromey  <tom@tromey.com>
6082             Andrew Burgess  <andrew.burgess@embecosm.com>
6083             Pedro Alves  <palves@redhat.com>
6084
6085 2019-01-23  Pedro Alves  <palves@redhat.com>
6086
6087         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6088
6089 2019-01-23  Pedro Alves  <palves@redhat.com>
6090             Andrew Burgess  <andrew.burgess@embecosm.com>
6091
6092         * gdbthread.h: Include "common/forward-scope-exit.h".
6093         (scoped_finish_thread_state): Redefine custom class in terms of
6094         forward_scope_exit.
6095
6096 2019-01-23  Pedro Alves  <palves@redhat.com>
6097             Andrew Burgess  <andrew.burgess@embecosm.com>
6098
6099         * common/forward-scope-exit.h: New file.
6100
6101 2019-01-23  Pedro Alves  <palves@redhat.com>
6102             Andrew Burgess  <andrew.burgess@embecosm.com>
6103             Tom Tromey  <tom@tromey.com>
6104
6105         * common/scope-exit.h: New file.
6106
6107 2019-01-23  Pedro Alves  <palves@redhat.com>
6108
6109         * common/preprocessor.h (ESC): Rename to ...
6110         (ESC_PARENS): ... this.
6111         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6112         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6113
6114 2019-01-23  Tom Tromey  <tom@tromey.com>
6115
6116         * language.h (class scoped_switch_to_sym_language_if_auto):
6117         Initialize m_lang in both cases.
6118
6119 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6120
6121         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6122         with XCNEW.
6123
6124 2019-01-22  Tom Tromey  <tom@tromey.com>
6125
6126         * corelow.c: Do not include sys/file.h.
6127
6128 2019-01-22  Tom Tromey  <tom@tromey.com>
6129
6130         * tui/tui-wingeneral.h: Include gdb_curses.h.
6131
6132 2019-01-22  Tom Tromey  <tom@tromey.com>
6133
6134         * source-cache.h (class source_cache) <get_source_lines,
6135         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6136
6137 2019-01-22  Tom Tromey  <tom@tromey.com>
6138
6139         * remote-fileio.h (struct remote_target): Declare.
6140
6141 2019-01-22  Tom Tromey  <tom@tromey.com>
6142
6143         * python/py-arch.c: Do not include py-ref.h.
6144         * python/py-bpevent.c: Do not include py-ref.h.
6145         * python/py-cmd.c: Do not include py-ref.h.
6146         * python/py-continueevent.c: Do not include py-ref.h.
6147         * python/py-event.h: Do not include py-ref.h.
6148         * python/py-evtregistry.c: Do not include py-ref.h.
6149         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6150         * python/py-frame.c: Do not include py-ref.h.
6151         * python/py-framefilter.c: Do not include py-ref.h.
6152         * python/py-function.c: Do not include py-ref.h.
6153         * python/py-infevents.c: Do not include py-ref.h.
6154         * python/py-linetable.c: Do not include py-ref.h.
6155         * python/py-objfile.c: Do not include py-ref.h.
6156         * python/py-param.c: Do not include py-ref.h.
6157         * python/py-prettyprint.c: Do not include py-ref.h.
6158         * python/py-progspace.c: Do not include py-ref.h.
6159         * python/py-symbol.c: Do not include py-ref.h.
6160         * python/py-symtab.c: Do not include py-ref.h.
6161         * python/py-type.c: Do not include py-ref.h.
6162         * python/py-unwind.c: Do not include py-ref.h.
6163         * python/py-utils.c: Do not include py-ref.h.
6164         * python/py-value.c: Do not include py-ref.h.
6165         * python/py-varobj.c: Do not include py-ref.h.
6166         * python/py-xmethods.c: Do not include py-ref.h.
6167         * python/python.c: Do not include py-ref.h.
6168         * varobj.c: Do not include py-ref.h.
6169
6170 2019-01-22  Tom Tromey  <tom@tromey.com>
6171
6172         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6173         keyword for bcache.
6174
6175 2019-01-22  Tom Tromey  <tom@tromey.com>
6176
6177         * compile/compile-cplus-types.c: Remove a comment by #include.
6178
6179 2019-01-22  Tom Tromey  <tom@tromey.com>
6180
6181         * compile/gcc-c-plugin.h: Include compile-internal.h.
6182
6183 2019-01-22  Tom Tromey  <tom@tromey.com>
6184
6185         * stabsread.c (EXTERN): Do not define.
6186         (symnum, next_symbol_text_func, processing_gcc_compilation)
6187         (within_function, global_sym_chain, global_stabs)
6188         (previous_stab_code, this_object_header_files)
6189         (n_this_object_header_files)
6190         (n_allocated_this_object_header_files): Define.
6191         * stabsread.h (EXTERN): Never define.  Use "extern".
6192
6193 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6194
6195         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6196         history_value.
6197
6198 2019-01-21  Tom Tromey  <tom@tromey.com>
6199
6200         * ui-out.c: Fix includes.
6201         * tui/tui-source.c: Fix includes.
6202         * target.c: Fix includes.
6203         * remote.c: Fix includes.
6204         * regcache.c: Fix includes.
6205         * python/py-block.c: Fix includes.
6206         * printcmd.c: Fix includes.
6207         * or1k-tdep.c: Fix includes.
6208         * mi/mi-main.c: Fix includes.
6209         * m32r-tdep.c: Fix includes.
6210         * csky-tdep.c: Fix includes.
6211         * compile/compile-cplus-types.c: Fix includes.
6212         * cli/cli-interp.c: Fix includes.
6213
6214 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6215
6216         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6217         for padding.
6218
6219 2019-01-16  Tom Tromey  <tom@tromey.com>
6220
6221         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6222         earlier.
6223         (struct objfile) <msymbols_range>: Move from top level.
6224         <msymbols>: New method.
6225         (class objfile_msymbols): Remove.
6226         * symtab.c (default_collect_symbol_completion_matches_break_on):
6227         Update.
6228         * symmisc.c (dump_msymbols): Update.
6229         * stabsread.c (scan_file_globals): Update.
6230         * objc-lang.c (info_selectors_command, info_classes_command)
6231         (find_methods): Update.
6232         * minsyms.c (find_solib_trampoline_target): Update.
6233         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6234         * coffread.c (coff_symfile_read): Update.
6235         * ada-lang.c (ada_lookup_simple_minsym)
6236         (ada_collect_symbol_completion_matches): Update.
6237
6238 2019-01-16  Tom Tromey  <tom@tromey.com>
6239
6240         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6241         type.  Remove no-argument constructor.
6242         <iterator::operator++>: Simplify.
6243         <begin>: Update.
6244         <end>: Use minimal_symbol_count.
6245
6246 2019-01-16  Tom Tromey  <tom@tromey.com>
6247
6248         * objfiles.h (struct objfile) <psymtabs>: New method.
6249         (class objfile_psymtabs): Remove.
6250         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6251         typedef.
6252         <range>: New method.
6253         (require_partial_symbols): Change return type.
6254         * psymtab.c (require_partial_symbols)
6255         (psym_expand_symtabs_matching): Update.
6256         * mdebugread.c (parse_partial_symbols): Update.
6257         * dbxread.c (dbx_end_psymtab): Update.
6258
6259 2019-01-15  Tom Tromey  <tom@tromey.com>
6260
6261         * symtab.c (lookup_objfile_from_block)
6262         (lookup_symbol_in_objfile_symtabs)
6263         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6264         (find_line_symtab, info_sources_command)
6265         (default_collect_symbol_completion_matches_break_on)
6266         (make_source_files_completion_list): Update.
6267         * symmisc.c (print_objfile_statistics, dump_objfile)
6268         (maintenance_print_symbols, maintenance_info_symtabs)
6269         (maintenance_check_symtabs, maintenance_info_line_tables):
6270         Update.
6271         * source.c (select_source_symtab)
6272         (forget_cached_source_info_for_objfile): Update.
6273         * objfiles.h (class objfile_compunits): Remove.
6274         (struct objfile) <compunits_range>: New typedef.
6275         (compunits): New method.
6276         * objfiles.c (objfile_relocate1): Update.
6277         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6278         * maint.c (count_symtabs_and_blocks): Update.
6279         * linespec.c (iterate_over_all_matching_symtabs): Update.
6280         * cp-support.c (add_symbol_overload_list_qualified): Update.
6281         * coffread.c (coff_symtab_read): Update.
6282         * ada-lang.c (add_nonlocal_symbols)
6283         (ada_collect_symbol_completion_matches)
6284         (ada_add_global_exceptions): Update.
6285
6286 2019-01-15  Tom Tromey  <tom@tromey.com>
6287
6288         * progspace.h (program_space) <objfiles_safe_range>: New
6289         typedef.
6290         <objfiles_safe>: New method.
6291         * objfiles.h (class all_objfiles_safe): Remove.
6292         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6293         * jit.c (jit_inferior_exit_hook): Update.
6294
6295 2019-01-17  Tom Tromey  <tom@tromey.com>
6296
6297         * progspace.h (program_space) <objfiles_range>: New typedef.
6298         <objfiles>: New method.
6299         <objfiles_head>: Rename from objfiles.
6300         (object_files): Update.
6301         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6302         * guile/scm-pretty-print.c
6303         (ppscm_find_pretty_printer_from_objfiles): Update.
6304         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6305         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6306         Update.
6307         * python/py-progspace.c (pspy_get_objfiles): Update.
6308         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6309         Update.
6310         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6311         (objfpy_lookup_objfile_by_build_id): Update.
6312         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6313         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6314         Update.
6315         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6316         (expand_symtab_containing_pc, lookup_objfile_from_block)
6317         (lookup_static_symbol, basic_lookup_transparent_type)
6318         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6319         (find_line_symtab, info_sources_command)
6320         (default_collect_symbol_completion_matches_break_on)
6321         (make_source_files_completion_list, find_main_name): Update.
6322         * symmisc.c (print_symbol_bcache_statistics)
6323         (print_objfile_statistics, maintenance_print_symbols)
6324         (maintenance_print_msymbols, maintenance_print_objfiles)
6325         (maintenance_info_symtabs, maintenance_check_symtabs)
6326         (maintenance_expand_symtabs, maintenance_info_line_tables):
6327         Update.
6328         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6329         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6330         (map_overlay_command, unmap_overlay_command)
6331         (simple_overlay_update, expand_symtabs_matching)
6332         (map_symbol_filenames): Update.
6333         * symfile-debug.c (set_debug_symfile): Update.
6334         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6335         Update.
6336         * source.c (select_source_symtab, forget_cached_source_info):
6337         Update.
6338         * solib.c (solib_read_symbols): Update.
6339         * solib-spu.c (append_ocl_sos): Update.
6340         * psymtab.c (maintenance_print_psymbols)
6341         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6342         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6343         * printcmd.c (info_symbol_command): Update.
6344         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6345         Update.
6346         * objfiles.h (class all_objfiles): Remove.
6347         * objfiles.c (have_partial_symbols, have_full_symbols)
6348         (have_minimal_symbols, qsort_cmp, update_section_map)
6349         (shared_objfile_contains_address_p)
6350         (default_iterate_over_objfiles_in_search_order): Update.
6351         * objc-lang.c (info_selectors_command, info_classes_command)
6352         (find_methods): Update.
6353         * minsyms.c (find_solib_trampoline_target): Update.
6354         * maint.c (maintenance_info_sections)
6355         (maintenance_translate_address, count_symtabs_and_blocks):
6356         Update.
6357         * main.c (captured_main_1): Update.
6358         * linux-thread-db.c (try_thread_db_load_from_pdir)
6359         (has_libpthread): Update.
6360         * linespec.c (iterate_over_all_matching_symtabs)
6361         (search_minsyms_for_name): Update.
6362         * jit.c (jit_find_objf_with_entry_addr): Update.
6363         * hppa-tdep.c (find_unwind_entry)
6364         (hppa_lookup_stub_minimal_symbol): Update.
6365         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6366         Update.
6367         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6368         (elf_gnu_ifunc_resolve_by_got): Update.
6369         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6370         * dwarf-index-write.c (save_gdb_index_command): Update.
6371         * cp-support.c (add_symbol_overload_list_qualified): Update.
6372         * breakpoint.c (create_overlay_event_breakpoint)
6373         (create_longjmp_master_breakpoint)
6374         (create_std_terminate_master_breakpoint)
6375         (create_exception_master_breakpoint): Update.
6376         * blockframe.c (find_pc_partial_function): Update.
6377         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6378         (ada_collect_symbol_completion_matches)
6379         (ada_add_global_exceptions): Update.
6380
6381 2019-01-17  Tom Tromey  <tom@tromey.com>
6382
6383         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6384         declare VEC.
6385         (solib_target_parse_libraries): Change return type.
6386         (library_list_start_segment, library_list_start_section)
6387         (library_list_end_library, library_list_start_library); Update.
6388         (solib_target_free_library_list): Remove.
6389         (solib_target_parse_libraries): Remove cleanup.  Change return
6390         type.
6391         (solib_target_current_sos): Update.
6392
6393 2019-01-17  Tom Tromey  <tromey@bapiya>
6394
6395         * valprint.c: Replace "the the" with "the".
6396         * symtab.c: Replace "the the" with "the".
6397         * solib.c: Replace "the the" with "the".
6398         * solib-dsbt.c: Replace "the the" with "the".
6399         * linespec.c: Replace "the the" with "the".
6400         * dwarf2loc.h: Replace "the the" with "the".
6401         * amd64-windows-tdep.c: Replace "the the" with "the".
6402         * aarch64-tdep.c: Replace "the the" with "the".
6403
6404 2019-01-16  Keith Seitz  <keiths@redhat.com>
6405
6406         PR gdb/23773
6407         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6408         <builder>: Rename to ..
6409         <m_builder>: ... this and make private.
6410         (dwarf2_cu::get_builder): New method.  Change all users of
6411         `builder' to use this method.
6412         (dwarf2_start_symtab): Move to ...
6413         (dwarf2_cu::start_symtab): ... here.  Update all callers
6414         (setup_type_unit_groups): Move to ...
6415         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6416         callers.
6417         (dwarf2_cu::reset_builder): New method.
6418         (process_full_compunit, process_full_type_unit): Use
6419         dwarf2_cu::reset_builder.
6420         (follow_die_offset): Record the ancestor CU if it is different
6421         from the followed DIE's CU.
6422         (follow_die_sig_1): Likewise.
6423
6424 2019-01-15  Tom Tromey  <tom@tromey.com>
6425
6426         * remote.c (class remote_state) <buf>: Now a char_vector.
6427         <buf_size>: Remove.
6428         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6429         parameter.
6430         (remote_target::getpkt_or_notif_sane_1)
6431         (remote_target::getpkt_sane)
6432         (remote_target::getpkt_or_notif_sane): Likewise.
6433         (class remote_target) <putpkt>: New overload.
6434         (remote_target::read_frame): Change type of "buf_p".  Remove
6435         sizeof_p parameter.
6436         (packet_ok): New overload.
6437         (packet_check_result): New overload.
6438         Update all uses.
6439
6440 2019-01-14  Tom Tromey  <tom@tromey.com>
6441
6442         * remote-notif.c (handle_notification, remote_notif_ack)
6443         (remote_notif_parse): Make "buf" const.
6444         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6445         const.
6446         (remote_notif_parse, remote_notif_ack, handle_notification):
6447         Likewise.
6448         * remote.c (remote_notif_stop_parse): Make "buf" const.
6449         (remote_target::remote_parse_stop_reply): Make "buf" const.
6450         (remote_notif_stop_ack): Make "buf" const.
6451
6452 2019-01-14  Tom Tromey  <tom@tromey.com>
6453
6454         * remote.c (remote_console_output): Make parameter const.
6455
6456 2019-01-14  Tom Tromey  <tom@tromey.com>
6457
6458         * target-debug.h (target_debug_print_signals): Constify.
6459         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6460         * procfs.c (procfs_target::pass_signals): Update.
6461         * linux-nat.c (linux_nat_target::pass_signals): Update.
6462         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6463         * target-delegates.c: Rebuild.
6464         * remote.c (remote_target::program_signals): Update.
6465         (remote_target::pass_signals): Update.
6466         * target.c (target_pass_signals): Constify argument.
6467         (target_program_signals): Likewise.
6468         * target.h (struct target_ops) <pass_signals, program_signals>:
6469         Constify argument.
6470         (target_pass_signals, target_program_signals): Constify argument.
6471
6472 2019-01-14  Tom Tromey  <tom@tromey.com>
6473
6474         PR tui/28819:
6475         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6476
6477 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6478
6479         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6480         field.
6481         * rs6000-tdep.c: Include reggroups.h.
6482         (IS_V_ALIAS_PSEUDOREG): Define.
6483         (rs6000_register_name): Return names for the "vX" aliases.
6484         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6485         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6486         aliases.  Call default_register_reggroup_p for all other
6487         pseudo-registers.
6488         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6489         New functions.
6490         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6491         Handle "vX" aliases.
6492         (v_alias_pseudo_register_collect): New function.
6493         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6494         (rs6000_gdbarch_init): Initialize "vX" aliases as
6495         pseudo-registers.  Restore registration of
6496         rs6000_pseudo_register_reggroup_p with
6497         set_tdesc_pseudo_register_reggroup_p.
6498
6499 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6500
6501         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6502         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6503         set_gdbarch_num_pseudo_regs.
6504
6505 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6506
6507         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6508         Remove arg prefixname, add do_set and do_show.
6509         Add member functions set_list and show_list.
6510         * cli/cli-style.c (class cli_style_option): Update accordingly.
6511         (style_set_list): Move to file scope.
6512         (style_show_list): Likewise.
6513         (set_style): Call help_list.
6514         (show_style): Call cmd_show_list.
6515         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6516         Update to use the new macro.
6517
6518 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6519
6520         * ada-lang.c (_initialize_ada_language): Expand the help text
6521         for the "catch exception" command.
6522
6523 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6524
6525         * symtab.c (matching_obj_sections): Initialize obj,
6526         declare it closer to its usage.
6527
6528 2019-01-10  Tom Tromey  <tom@tromey.com>
6529
6530         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6531         (basic_inf_threads_range): Remove.
6532         (inf_threads_range, inf_non_exited_threads_range)
6533         (safe_inf_threads_range): Use next_adapter.
6534
6535 2019-01-10  Keith Seitz  <keiths@redhat.com>
6536
6537         PR gdb/23712
6538         PR symtab/23010
6539         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6540         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6541
6542 2019-01-10  Keith Seitz  <keiths@redhat.com>
6543
6544         PR gdb/23712
6545         PR symtab/23010
6546         * dictionary.c (pending_to_vector): Remove.
6547         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6548         Remove _1 suffix, replacing functions of the same name.  Update
6549         all callers.
6550         (dict_create_hashed, dict_create_hashed_expandable)
6551         (dict_create_linear, dict_create_linear_expandable, dict_free)
6552         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6553         Make functions static.
6554
6555 2019-01-10  Keith Seitz  <keiths@redhat.com>
6556
6557         PR gdb/23712
6558         PR symtab/23010
6559         * dictionary.h (struct dictionary): Replace declaration with
6560         multidictionary.
6561         (dict_create_hashed, dict_create_hashed_expandable)
6562         (dict_create_linear, dict_create_linear_expandable)
6563         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6564         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6565         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6566         taking multidictionary argument.
6567         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6568         * block.h (struct block) <dict>: Change to multidictionary
6569         and rename `multidict'.
6570         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6571         symmisc.c: Update all dictionary references to multidictionary.
6572
6573 2019-01-10  Keith Seitz  <keiths@redhat.com>
6574
6575         PR gdb/23712
6576         PR symtab/23010
6577         * dictionary.c: Include unordered_map.
6578         (pending_to_vector): New function.
6579         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6580         Rewrite the non-"_1" functions to take vector instead
6581         of linked list.
6582         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6583         "new" _1 versions of the same name.
6584         (multidictionary): Define.
6585         (std::hash<enum language): New definition.
6586         (collate_pending_symbols_by_language, mdict_create_hashed)
6587         (mdict_create_hashed_expandable, mdict_create_linear)
6588         (mdict_create_linear_expandable, mdict_free)
6589         (find_language_dictionary, create_new_language_dictionary)
6590         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6591         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6592         (mdict_size, mdict_empty): New functions.
6593         * dictionary.h (mdict_iterator): Define.
6594
6595 2019-01-10  Pedro Alves  <palves@redhat.com>
6596
6597         * breakpoint.c (read_uploaded_action)
6598         (create_tracepoint_from_upload): Adjust to use
6599         gdb::unique_xmalloc_ptr.
6600         * ctf.c (ctf_write_uploaded_tp):
6601         (SET_ARRAY_FIELD): Use emplace_back.
6602         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6603         * tracefile-tfile.c (tfile_write_uploaded_tp):
6604         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6605         gdb::unique_xmalloc_ptr.
6606         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6607         at_string, cond_string, cmd_strings>: Replace char pointers
6608         with gdb::unique_xmalloc_ptr.
6609
6610 2019-01-10  Pedro Alves  <palves@redhat.com>
6611
6612         * solib-target.c (library_list_start_library): Don't xstrdup name.
6613
6614 2019-01-10  Pedro Alves  <palves@redhat.com>
6615
6616         * mdebugread.c (parse_partial_symbols): Use
6617         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6618
6619 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6620
6621         * linux-fork.c (scoped_switch_fork_info)
6622         <~scoped_switch_fork_info>: Fix incorrect variable name.
6623
6624 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6625
6626         * linux-fork.c (scoped_switch_fork_info)
6627         <scoped_switch_fork_info>: Make explicit.
6628         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6629
6630 2019-01-10  Tom Tromey  <tom@tromey.com>
6631
6632         * objfiles.h (objfile::reset_psymtabs): Update.
6633         * objfiles.c (objfile::objfile): Update.
6634         * psymtab.h (psymtab_storage::obstack): Update.
6635         (psymtab_storage::m_obstack): Use gdb::optional.
6636         (class psymtab_storage): Update comment.  Remove objfile
6637         parameter.
6638         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6639
6640 2019-01-10  Tom Tromey  <tom@tromey.com>
6641
6642         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6643         <free_psymtabs>: Now private.
6644         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6645         (allocate_psymtab): Use new method.
6646
6647 2019-01-10  Tom Tromey  <tom@tromey.com>
6648
6649         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6650         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6651         * mdebugread.c (parse_partial_symbols): Use
6652         allocate_dependencies.
6653         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6654         allocate_dependencies.
6655         (process_psymtab_comp_unit_reader)
6656         (build_type_psymtab_dependencies): Likewise.
6657         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6658
6659 2019-01-10  Tom Tromey  <tom@tromey.com>
6660
6661         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6662         PSYMBOL_SET_LANGUAGE.
6663         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6664
6665 2019-01-10  Tom Tromey  <tom@tromey.com>
6666
6667         * psymtab.h (psymtab_storage::obstack): New method.
6668         <m_obstack>: Rename from obstack; now private.
6669         * psymtab.c (psymtab_storage): Update.
6670         * dwarf2read.c (create_addrmap_from_index)
6671         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6672         Update.
6673
6674 2019-01-10  Tom Tromey  <tom@tromey.com>
6675
6676         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6677         * objfiles.h (objfile::reset_psymtabs): New method.
6678
6679 2019-01-10  Tom Tromey  <tom@tromey.com>
6680
6681         * symmisc.c (print_symbol_bcache_statistics): Update.
6682         (print_objfile_statistics): Update.
6683         * symfile.c (reread_symbols): Update.
6684         * psymtab.h (class psymtab_storage): New.
6685         * psymtab.c (psymtab_storage): New constructor.
6686         (~psymtab_storage): New destructor.
6687         (require_partial_symbols): Update.
6688         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6689         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6690         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6691         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6692         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6693         (start_psymtab_common, end_psymtab_common)
6694         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6695         (allocate_psymtab): Update.
6696         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6697         Update.
6698         (dump_psymtab_addrmap, maintenance_print_psymbols)
6699         (maintenance_check_psymtabs): Update.
6700         (class objfile_psymtabs): Move to objfiles.h.
6701         * psympriv.h (discard_psymtab): Now inline.
6702         (psymtab_discarder::psymtab_discarder): Update.
6703         (psymtab_discarder::~psymtab_discarder): Update.
6704         (ALL_OBJFILE_PSYMTABS): Rewrite.
6705         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6706         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6707         Remove fields.
6708         <partial_symtabs>: New field.
6709         (class objfile_psymtabs): Move from psymtab.h.  Update.
6710         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6711         psymbol_cache.
6712         (objfile::~objfile): Don't destroy psymbol_cache.
6713         * mdebugread.c (parse_partial_symbols): Update.
6714         * dwarf2read.c (create_addrmap_from_index)
6715         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6716         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6717         (add_partial_subprogram, dwarf2_ranges_read): Update.
6718         * dwarf-index-write.c (write_address_map)
6719         (write_one_signatured_type, recursively_write_psymbols)
6720         (class debug_names, class debug_names, write_psymtabs_to_index):
6721         Update.
6722
6723 2019-01-10  Tom Tromey  <tom@tromey.com>
6724
6725         * symtab.h (SYMBOL_SET_NAMES): Update.
6726         (symbol_set_names): Update.
6727         (MSYMBOL_SET_NAMES): Update.
6728         * symtab.c (symbol_set_names): Change argument to be an
6729         objfile_per_bfd_storage.
6730         * psymtab.c (add_psymbol_to_bcache): Update.
6731         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6732
6733 2019-01-10  Tom Tromey  <tom@tromey.com>
6734
6735         * symtab.c (create_demangled_names_hash): Change argument to be an
6736         objfile_per_bfd_storage.
6737         (symbol_set_names): Update.
6738
6739 2019-01-10  Tom Tromey  <tom@tromey.com>
6740
6741         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6742         init_psymbol_list.
6743         * psymtab.c (init_psymbol_list): Do nothing if already called.
6744         * psympriv.h (init_psymbol_list): Add comment.
6745         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6746         init_psymbol_list.
6747         * dbxread.c (dbx_symfile_read): Unconditionally call
6748         init_psymbol_list.
6749
6750 2019-01-10  Tom Tromey  <tom@tromey.com>
6751
6752         * xcoffread.c (scan_xcoff_symtab): Update.
6753         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6754         "where".
6755         * mdebugread.c (parse_partial_symbols)
6756         (handle_psymbol_enumerators): Update.
6757         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6758         * dbxread.c (read_dbx_symtab): Update.
6759         * psympriv.h (psymbol_placement): New enum.
6760         (add_psymbol_to_list): Update.
6761
6762 2019-01-10  Tom Tromey  <tom@tromey.com>
6763
6764         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6765         static_psymbols parameters.
6766         (scan_xcoff_symtab): Update.
6767         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6768         static_psymbols parameters.
6769         * psympriv.h (start_psymtab_common): Update.
6770         * mdebugread.c (parse_partial_symbols): Update.
6771         * dwarf2read.c (create_partial_symtab): Update.
6772         * dbxread.c (read_dbx_symtab): Update.
6773         (start_psymtab): Remove global_psymbols and static_psymbols
6774         parameters.
6775
6776 2019-01-10  Tom Tromey  <tom@tromey.com>
6777
6778         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6779         * psymtab.c (allocate_psymtab): Add comment.
6780         * psympriv.h (allocate_psymtab): Add comment.
6781         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6782         initializations.
6783         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6784
6785 2019-01-10  Tom Tromey  <tom@tromey.com>
6786
6787         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6788         Don't declare.
6789         * mipsread.c: Include mdebugread.h.
6790         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6791         Declare.
6792         * elfread.c: Include mdebugread.h.
6793
6794 2019-01-09  Tom Tromey  <tom@tromey.com>
6795
6796         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6797         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6798         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6799         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6800         (psym_lookup_symbol, psym_find_last_source_symtab)
6801         (psym_forget_cached_source_info, psym_print_stats)
6802         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6803         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6804         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6805         (psym_find_compunit_symtab_by_address)
6806         (maintenance_print_psymbols, maintenance_info_psymtabs)
6807         (maintenance_check_psymtabs): Use ranged for.
6808         * psymtab.h (class objfile_psymtabs): New.
6809         (require_partial_symbols): Return objfile_psymtabs.
6810         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6811
6812 2019-01-09  Tom Tromey  <tom@tromey.com>
6813
6814         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6815         (find_pc_mapped_section, list_overlays_command)
6816         (map_overlay_command, unmap_overlay_command)
6817         (simple_overlay_update): Use all_objfiles.
6818         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6819         * printcmd.c (info_symbol_command): Use all_objfiles.
6820         * objfiles.h (ALL_OBJSECTIONS): Remove.
6821         * maint.c (maintenance_translate_address): Use all_objfiles.
6822         * gcore.c (gcore_create_callback): Use all_objfiles.
6823         (objfile_find_memory_regions): Likewise.
6824
6825 2019-01-09  Tom Tromey  <tom@tromey.com>
6826
6827         * symtab.c (find_line_symtab, info_sources_command)
6828         (make_source_files_completion_list): Use objfile_compunits.
6829         * source.c (select_source_symtab): Use objfile_compunits.
6830         * objfiles.h (struct objfile): Update comment.
6831         (ALL_OBJFILES): Remove.
6832         (ALL_FILETABS): Remove.
6833         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6834         objfile_compunits.
6835
6836 2019-01-09  Tom Tromey  <tom@tromey.com>
6837
6838         * symmisc.c (print_objfile_statistics, dump_objfile)
6839         (maintenance_print_symbols): Use compunit_filetabs.
6840         * source.c (forget_cached_source_info_for_objfile): Use
6841         compunit_filetabs.
6842         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6843         (ALL_FILETABS): Use compunit_filetabs.
6844         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6845         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6846
6847 2019-01-09  Tom Tromey  <tom@tromey.com>
6848
6849         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6850         (compunit_filetabs): New.
6851         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6852         compunit_filetabs.
6853         (info_sources_command, make_source_files_completion_list): Remove
6854         declaration.
6855         * symmisc.c (print_objfile_statistics, dump_objfile)
6856         (maintenance_print_symbols): Remove declaration.
6857         (maintenance_info_symtabs): Use compunit_filetabs.
6858         (maintenance_info_line_tables): Likewise.
6859         * source.c (select_source_symtab): Change local variable name.
6860         (forget_cached_source_info_for_objfile): Remove declaration.
6861         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6862         * objfiles.c (objfile_relocate1): Remove declaration.
6863         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6864         declaration.
6865         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6866         * coffread.c (coff_symtab_read): Remove declaration.
6867         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6868         compunit_filetabs.
6869
6870 2019-01-09  Tom Tromey  <tom@tromey.com>
6871
6872         * symtab.c (lookup_objfile_from_block)
6873         (find_pc_sect_compunit_symtab, search_symbols)
6874         (default_collect_symbol_completion_matches_break_on): Use
6875         objfile_compunits.
6876         * objfiles.h (ALL_COMPUNITS): Remove.
6877         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6878         * cp-support.c (add_symbol_overload_list_qualified): Use
6879         objfile_compunits.
6880         * ada-lang.c (ada_collect_symbol_completion_matches)
6881         (ada_add_global_exceptions): Use objfile_compunits.
6882
6883 2019-01-09  Tom Tromey  <tom@tromey.com>
6884
6885         * source.c (select_source_symtab)
6886         (forget_cached_source_info_for_objfile): Remove declaration.
6887         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6888         declaration.
6889         * maint.c (count_symtabs_and_blocks): Remove declaration.
6890         * cp-support.c (add_symbol_overload_list_qualified): Remove
6891         declaration.
6892         * coffread.c (coff_symtab_read): Remove declaration.
6893         * symtab.c (lookup_symbol_in_objfile_symtabs)
6894         (basic_lookup_transparent_type_1): Use objfile_compunits.
6895         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6896         (info_sources_command, search_symbols)
6897         (default_collect_symbol_completion_matches_break_on)
6898         (make_source_files_completion_list): Remove declaration.
6899         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6900         (ada_collect_symbol_completion_matches)
6901         (ada_add_global_exceptions): Remove declaration.
6902         * linespec.c (iterate_over_all_matching_symtabs): Use
6903         objfile_compunits.
6904         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6905         (class objfile_compunits): New.
6906         (ALL_COMPUNITS): Use objfile_compunits.
6907         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6908         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6909         objfile_compunits.
6910         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6911
6912 2019-01-09  Tom Tromey  <tom@tromey.com>
6913
6914         * symtab.c (search_symbols)
6915         (default_collect_symbol_completion_matches_break_on): Use
6916         objfile_msymbols.
6917         * ada-lang.c (ada_lookup_simple_minsym)
6918         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6919         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6920         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6921         objfile_msymbols.
6922         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6923         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6924         * objc-lang.c (find_methods): Use objfile_msymbols.
6925         (info_selectors_command, info_classes_command): Likewise.
6926         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6927         * objfiles.h (class objfile_msymbols): New.
6928         (ALL_OBJFILE_MSYMBOLS): Remove.
6929         (ALL_MSYMBOLS): Remove.
6930
6931 2019-01-09  Tom Tromey  <tom@tromey.com>
6932
6933         * common/next-iterator.h (next_adapter): Add Iterator template
6934         parameter.
6935         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6936         (class all_objfiles_safe): New.
6937         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6938         * objfiles.c (put_objfile_before): Update comment.
6939         (add_separate_debug_objfile): Likewise.
6940         (free_all_objfiles): Use all_objfiles_safe.
6941         (objfile_purge_solibs): Likewise.
6942
6943 2019-01-09  Tom Tromey  <tom@tromey.com>
6944
6945         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6946         (expand_symtab_containing_pc, lookup_static_symbol)
6947         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6948         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6949         all_objfiles.
6950         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6951         * breakpoint.c (create_overlay_event_breakpoint)
6952         (create_longjmp_master_breakpoint)
6953         (create_std_terminate_master_breakpoint)
6954         (create_exception_master_breakpoint): Use all_objfiles.
6955         * linux-thread-db.c (try_thread_db_load_from_pdir)
6956         (has_libpthread): Use all_objfiles.
6957         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6958         * linespec.c (iterate_over_all_matching_symtabs)
6959         (search_minsyms_for_name): Use all_objfiles.
6960         * maint.c (maintenance_info_sections): Use all_objfiles.
6961         * main.c (captured_main_1): Use all_objfiles.
6962         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6963         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6964         * guile/scm-pretty-print.c
6965         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6966         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6967         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6968         (maintenance_print_msymbols): Use all_objfiles.
6969         * source.c (select_source_symtab): Use all_objfiles.
6970         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6971         * symfile.c (remove_symbol_file_command)
6972         (expand_symtabs_matching, map_symbol_filenames): Use
6973         all_objfiles.
6974         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6975         all_objfiles.
6976         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6977         * objc-lang.c (find_methods): Use all_objfiles.
6978         * objfiles.c (have_partial_symbols, have_full_symbols)
6979         (have_minimal_symbols, qsort_cmp)
6980         (default_iterate_over_objfiles_in_search_order): Use
6981         all_objfiles.
6982         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6983         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6984         (maintenance_check_psymtabs): Use all_objfiles.
6985         (ALL_PSYMTABS): Remove.
6986         * compile/compile-object-run.c (do_module_cleanup): Use
6987         all_objfiles.
6988         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6989         * cp-support.c (add_symbol_overload_list_qualified): Use
6990         all_objfiles.
6991         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6992         Use all_objfiles.
6993         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6994         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6995         all_objfiles.
6996         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6997         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6998         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6999         Uses all_objfiles.
7000         * solib.c (solib_read_symbols): Use all_objfiles
7001
7002 2019-01-09  Tom Tromey  <tom@tromey.com>
7003
7004         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7005         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7006         all_objfiles.
7007         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7008         * symmisc.c (print_symbol_bcache_statistics)
7009         (print_objfile_statistics, maintenance_print_objfiles)
7010         (maintenance_info_symtabs, maintenance_check_symtabs)
7011         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7012         all_objfiles.
7013         * source.c (forget_cached_source_info): Use all_objfiles.
7014         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7015         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7016         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7017         * objfiles.c (update_section_map): Use all_objfiles.
7018         (shared_objfile_contains_address_p): Likewise.
7019         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7020         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7021
7022 2019-01-09  Tom Tromey  <tom@tromey.com>
7023
7024         * common/next-iterator.h: New file.
7025         * objfiles.h (class all_objfiles): New.
7026         (struct objfile_iterator): New.
7027
7028 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7029
7030         * NEWS: Move the description of the changed "frame", "select-frame",
7031          and "info frame" commands to the Changed commands section.
7032
7033 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7034
7035         * gdbtypes.c (check_stub_method_group): Remove handling of old
7036         mangling schemes.
7037         * linespec.c (find_methods): Likewise.
7038         * stabsread.c (read_member_functions): Likewise.
7039         * valops.c (search_struct_method): Likewise.
7040         (value_struct_elt_for_reference): Likewise.
7041         * NEWS: Mention this change.
7042
7043 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7044
7045         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7046         print_source_lines.
7047         * source.c (print_source_lines_base): Update line number check.
7048         (print_source_lines): New function.
7049         (source_lines_range::source_lines_range): New function.
7050         * source.h (class source_lines_range): New class.
7051         (print_source_lines): New declaration.
7052
7053 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7054
7055         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7056
7057 2019-01-08  Tom Tromey  <tom@tromey.com>
7058             Simon Marchi  <simon.marchi@ericsson.com>
7059
7060         PR gdb/24060
7061         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7062         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7063         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7064         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7065         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7066         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7067
7068 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7069
7070         * source.c (select_source_symtab): Move header comment to
7071         declaration in source.h.
7072         (forget_cached_source_info_for_objfile): Likewise.
7073         (forget_cached_source_info): Likewise.
7074         (identify_source_line): Likewise.
7075         * source.h (identify_source_line): Move declaration from symtab.h
7076         and add comment from source.c
7077         (print_source_lines): Likewise.
7078         (forget_cached_source_info_for_objfile): Likewise.
7079         (forget_cached_source_info): Likewise.
7080         (select_source_symtab): Likewise.
7081         (enum print_source_lines_flag): Move definition from symtab.h.
7082         * symtab.h (identify_source_line): Move declaration to source.h.
7083         (print_source_lines): Likewise.
7084         (forget_cached_source_info_for_objfile): Likewise.
7085         (forget_cached_source_info): Likewise.
7086         (select_source_symtab): Likewise.
7087         (enum print_source_lines_flag): Move definition to source.h.
7088         * tui/tui-hooks.c: Add 'source.h' include.
7089
7090 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7091
7092         * source.c (print_source_lines_base): Handle requests to print
7093         reverse line number sequences, and guard against empty lines
7094         string.
7095
7096 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7097
7098         * source.c (print_source_lines_base): Fix skip of '\r' if next
7099         character is '\n'.
7100
7101 2019-01-06  Tom Tromey  <tom@tromey.com>
7102
7103         * c-exp.y (struct c_parse_state) <macro_original_text,
7104         expansion_obstack>: New member.
7105         (macro_original_text, expansion_obstack): Remove globals.
7106         (scan_macro_expansion, scanning_macro_expansion)
7107         (finished_macro_expansion): Update.
7108         (scan_macro_cleanup): Remove.
7109         (yylex, c_parse): Update.
7110
7111 2019-01-06  Tom Tromey  <tom@tromey.com>
7112
7113         * c-exp.y (struct c_parse_state) <strings>: New member.
7114         (operator_stoken): Update.
7115
7116 2019-01-06  Tom Tromey  <tom@tromey.com>
7117
7118         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7119         (union type_stack_elt) <typelist_val>: Now a pointer to
7120         std::vector.
7121         (type_stack_cleanup): Don't declare.
7122         (push_typelist): Update.
7123         * parse.c (pop_typelist): Return a std::vector.
7124         (push_typelist): Take a std::vector.
7125         (follow_types): Update.  Do not free args.
7126         (type_stack_cleanup): Remove.
7127         * c-exp.y (struct c_parse_state): New.
7128         (cpstate): New global.
7129         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7130         (nonempty_typelist): Update.
7131         (func_mod): Create a new vector.
7132         (c_parse): Create a c_parse_state.
7133         (check_parameter_typelist): Do not delete params.
7134         (function_method): Update.  Do not delete type_list.
7135
7136 2019-01-06  Tom Tromey  <tom@tromey.com>
7137
7138         PR gdb/28155:
7139         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7140         check_typedef.
7141         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7142         (print_return_value): Likewise.
7143
7144 2019-01-05  Tom Tromey  <tom@tromey.com>
7145
7146         * contrib/cleanup_check.py: Remove.
7147         * contrib/gcc-with-excheck: Remove.
7148         * contrib/exsummary.py: Remove.
7149         * contrib/excheck.py: Remove.
7150
7151 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7152
7153         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7154         NULL. Initialize tpprev to NULL instead of assigning it
7155         to NULL on the next statement.
7156         * windows-nat.c (windows_delete_thread): Remove check for
7157         main_thread_id before printing thread exit notifications.
7158         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7159         Remove thread ID check against main_thread_id.
7160         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7161         windows_delete_thread.
7162         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7163
7164 2019-01-04  Tom Tromey  <tom@tromey.com>
7165
7166         * compile/compile.c (_initialize_compile): Use upper case for
7167         metasyntactic variables.
7168         * symmisc.c (_initialize_symmisc): Use upper case for
7169         metasyntactic variables.
7170         * psymtab.c (_initialize_psymtab): Use upper case for
7171         metasyntactic variables.
7172         * demangle.c (demangle_command): Use upper case for metasyntactic
7173         variables.
7174         (_initialize_demangler): Likewise.
7175         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7176         variables.
7177
7178 2019-01-03  Tom Tromey  <tom@tromey.com>
7179
7180         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7181
7182 2019-01-03  Tom Tromey  <tom@tromey.com>
7183
7184         * python/py-symtab.c (salpy_str): Update.
7185         (struct salpy_sal_object) <symtab>: Now a PyObject.
7186         (salpy_dealloc): Update.
7187         (del_objfile_sal): Use gdbpy_ref.
7188
7189 2019-01-03  Tom Tromey  <tom@tromey.com>
7190
7191         * python/py-type.c (convert_field): Use new_reference.  Return
7192         gdbpy_ref.
7193         (make_fielditem): Return gdbpy_ref.
7194         (typy_fields): Update.
7195         (typy_getitem): Update.
7196         (field_name): Return gdbpy_ref.  Use new_reference.
7197         (typy_iterator_iternext): Update.
7198
7199 2019-01-03  Tom Tromey  <tom@tromey.com>
7200
7201         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7202
7203 2019-01-03  Tom Tromey  <tom@tromey.com>
7204
7205         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7206         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7207         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7208         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7209         (pspy_set_type_printers): Likewise.
7210         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7211         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7212         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7213         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7214         (objfpy_set_type_printers): Likewise.
7215
7216 2019-01-03  Tom Tromey  <tom@tromey.com>
7217
7218         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7219         (gdbpy_print_stack): Use gdbpy_err_fetch.
7220         * python/python-internal.h (class gdbpy_err_fetch): New class.
7221         (class gdbpy_enter) <m_error_type, m_error_value,
7222         m_error_traceback>: Remove.
7223         <m_error>: New member.
7224         (gdbpy_exception_to_string): Don't declare.
7225         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7226         * python/py-value.c (convert_value_from_python): Use
7227         gdbpy_err_fetch.
7228         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7229         gdbpy_exception_to_string.
7230         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7231         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7232         gdbpy_err_fetch.
7233
7234 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7235
7236         * linux-nat.c (delete_lwp_cleanup): Delete.
7237         (struct lwp_deleter): New struct.
7238         (lwp_info_up): New typedef.
7239         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7240         lwp_info_up.
7241
7242 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7243
7244         * linux-fork.c (class scoped_switch_fork_info): New class.
7245         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7246
7247 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7248
7249         * valops.c (find_overload_match): Remove use of null_cleanup, and
7250         calls to do_cleanups.
7251
7252 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7253
7254         * compile/compile-cplus-types.c
7255         (compile_cplus_instance::decl_name): Handle changes to
7256         cp_func_name.
7257         * cp-support.c (cp_func_name): Update header comment, update
7258         return type.
7259         * cp-support.h (cp_func_name): Update return type in declaration.
7260         * valops.c (find_overload_match): Move temp_func local to top
7261         level of function and change its type.  Use temp_func to hold and
7262         delete temporary string obtained from cp_func_name.
7263
7264 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7265
7266         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7267         gdb::char_vector, remove cleanup, and update uses of `msg`.
7268
7269 2019-01-03  Jim Wilson  <jimw@sifive.com>
7270
7271         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7272
7273 2019-01-02  Tom Tromey  <tom@tromey.com>
7274
7275         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7276         (tdesc_parse_xml): Remove cleanups.
7277         * target-descriptions.h (make_cleanup_free_target_description):
7278         Don't declare.
7279         (target_desc_deleter): New struct.
7280         (target_desc_up): New typedef.
7281         * target-descriptions.c (target_desc_deleter::operator()): Rename
7282         from free_target_description.
7283         (make_cleanup_free_target_description): Remove.
7284
7285 2019-01-02  Tom Tromey  <tom@tromey.com>
7286
7287         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7288         constructor, destructor.
7289         (linespec_parser): Remove typedef.
7290         (~linespec_parser): Rename from linespec_parser_delete.
7291         (linespec_lex_to_end, linespec_complete_label)
7292         (linespec_complete): Update.
7293         (decode_line_full): Remove cleanups.
7294         (decode_line_1): Update.
7295
7296 2019-01-02  Tom Tromey  <tom@tromey.com>
7297
7298         * python/python-internal.h (inferior_to_inferior_object): Change
7299         return type.
7300         * python/py-exitedevent.c (create_exited_event_object): Update.
7301         * python/py-inferior.c (inferior_to_inferior_object): Return
7302         gdbpy_ref.
7303         (python_new_inferior, python_inferior_deleted)
7304         (thread_to_thread_object, delete_thread_object)
7305         (build_inferior_list, gdbpy_selected_inferior): Update.
7306         * python/py-infthread.c (create_thread_object): Update.  Also fail
7307         if inferior_to_inferior_object fails.
7308
7309 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7310
7311         * inferior.h (class inferior) <displaced_step_state>: New field.
7312         * infrun.h (struct displaced_step_state): Move here from
7313         infrun.c.  Initialize fields, add constructor.
7314         <inf>: Remove field.
7315         <reset>: New method.
7316         * infrun.c (struct displaced_step_inferior_state): Move to
7317         infrun.h.
7318         (displaced_step_inferior_states): Remove.
7319         (get_displaced_stepping_state): Adust.
7320         (displaced_step_in_progress_any_inferior): Adjust.
7321         (displaced_step_in_progress_thread): Adjust.
7322         (displaced_step_in_progress): Adjust.
7323         (add_displaced_stepping_state): Remove.
7324         (get_displaced_step_closure_by_addr): Adjust.
7325         (remove_displaced_stepping_state): Remove.
7326         (infrun_inferior_exit): Call displaced_step_state.reset.
7327         (use_displaced_stepping): Don't check for NULL.
7328         (displaced_step_prepare_throw): Call
7329         get_displaced_stepping_state.
7330         (displaced_step_fixup): Don't check for NULL.
7331         (prepare_for_detach): Don't check for NULL.
7332
7333 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7334
7335         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7336          in case of call that did not complete.
7337
7338 2019-01-02  Andrey Utkin  <autkin@undo.io>
7339
7340         * symfile.c (find_separate_debug_file): Fix search of debug files for
7341         remote debuggee.
7342
7343 2019-01-02  Tom Tromey  <tom@tromey.com>
7344
7345         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7346         indentation.
7347         * python/py-frame.c (frapy_older): Remove cast.
7348         (frapy_newer): Likewise.
7349         * python/py-breakpoint.c (local_setattro): Remove cast.
7350         * python/py-arch.c (archpy_name): Remove local variable.
7351         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7352
7353 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7354
7355         * unittests/basic_string_view/element_access/char/empty.cc:
7356         Fix year range in copyright header.
7357
7358 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7359
7360         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7361         Delete.
7362         <operator==>: Update with for removed field.
7363         <hash>: Likewise.
7364         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7365         <isa_features>: ...this.
7366         <abi_features>: New field.
7367         (riscv_isa_flen): Update comment.
7368         (riscv_abi_xlen): New declaration.
7369         (riscv_abi_flen): New declaration.
7370         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7371         isa_features.
7372         (riscv_abi_xlen): New function.
7373         (riscv_isa_flen): Update to get answer from isa_features.
7374         (riscv_abi_flen): New function.
7375         (riscv_has_fp_abi): Update to get answer from abi_features.
7376         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7377         xlen and flen.
7378         (riscv_call_info) <xlen, flen>: Update comment.
7379         (riscv_call_arg_struct): Remove invalid assertions
7380         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7381         is removed.
7382         (riscv_gdbarch_init): Gather isa features and abi features
7383         separately, ensure both match on the gdbarch when reusing an old
7384         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7385         a target with 64-bit float hardware.
7386
7387 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7388
7389         * source.c (search_command_helper): Stop reverse search
7390         when line 1 has been searched.
7391
7392 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7393
7394         * record-full.c (record_full_base_target::close): Rewrite
7395         record_full_core_buf_list free logic.
7396
7397 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7398
7399         * break-catch-syscall.c (print_one_catch_syscall): xfree
7400         the last text.
7401
7402 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7403
7404         * top.c (print_gdb_version): Update Copyright year in version
7405         message.
7406
7407 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7408
7409         Update copyright year range in all GDB files.
7410
7411 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7412
7413         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7414
7415 For older changes see ChangeLog-2018.
7416 \f
7417 Local Variables:
7418 mode: change-log
7419 left-margin: 8
7420 fill-column: 74
7421 version-control: never
7422 coding: utf-8
7423 End:
7424