gdb/ChangeLog

   1 2019-06-13  Pedro Alves  <palves@redhat.com>
   2
   3         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
   4         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
   5         * unittests/cli-utils-selftests.c (test_parse_flags)
   6         (test_parse_flags_qcs): Delete.
   7         (test_cli_utils): Don't call deleted functions.
   8
   9 2019-06-13  Pedro Alves  <palves@redhat.com>
  10
  11         * thread.c: Include "cli/cli-option.h".
  12         (tp_array_compar_ascending): Global.
  13         (tp_array_compar): Delete function.
  14         (tp_array_compar_ascending, tp_array_compar_descending): New
  15         functions.
  16         (ascending_option_def, qcs_flag_option_def)
  17         (thr_qcs_flags_option_defs)
  18         (make_thread_apply_all_options_def_group)
  19         (make_thread_apply_options_def_group): New.
  20         (thread_apply_all_command): Use gdb::option::process_options.
  21         (thread_apply_command_completer)
  22         (thread_apply_all_command_completer): New.
  23         (thread_apply_command): Use gdb::option::process_options.
  24         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
  25         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
  26         to generate help text of "thread apply".  Adjust "taas"'s help.
  27         * tid-parse.c (tid_range_parser::in_thread_range): New method.
  28         * tid-parse.h (tid_range_parser::in_thread_range): New method.
  29
  30 2019-06-13  Pedro Alves  <palves@redhat.com>
  31
  32         * thread.c (thread_apply_command): Check for invalid TID with
  33         isdigit instead of !isalpha.
  34
  35 2019-06-13  Pedro Alves  <palves@redhat.com>
  36
  37         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
  38         (validate_flags_qcs): New.
  39         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
  40         (validate_flags_qcs): Declare.
  41         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
  42         (make_frame_apply_options_def_group): New.
  43         (frame_apply_command_count): Process options with
  44         gdb::option::process_options.
  45         (frame_apply_completer): New.
  46         (frame_apply_level_completer, frame_apply_all_completer)
  47         (frame_apply_completer): New.
  48         (_initialize_stack): Update help of "frame apply", "frame apply
  49         level", "frame apply all" and "faas" to mention supported options
  50         and install command completers.
  51         * stack.h (frame_apply_all_completer): Declare.
  52         * thread.c: Include "stack.h".
  53         (tfaas_command): Add "--".
  54         (_initialize_thread): Update help "tfaas" to mention supported
  55         options and install command completer.
  56
  57 2019-06-13  Pedro Alves  <palves@redhat.com>
  58
  59         * completer.c (complete_nested_command_line): New.
  60         (gdb_completion_word_break_characters_throw): Add assertion.
  61         * completer.h (complete_nested_command_line): Declare.
  62
  63 2019-06-13  Pedro Alves  <palves@redhat.com>
  64
  65         * stack.c (parse_backtrace_qualifiers): New.
  66         (backtrace_command): Use it.
  67         (backtrace_command_completer): Complete on qualifiers.
  68
  69 2019-06-13  Pedro Alves  <palves@redhat.com>
  70
  71         * frame.c: Include "cli/cli-option.h.
  72         (user_set_backtrace_options): New.
  73         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
  74         Delete.
  75         (get_prev_frame): Adjust.
  76         (boolean_option_def, uinteger_option_def)
  77         (set_backtrace_option_defs): New.
  78         (_initialize_frame): Adjust and use
  79         gdb::option::add_setshow_cmds_for_options to install "set
  80         backtrace past-main" and "set backtrace past-entry".
  81         * frame.h: Include "cli/cli-option.h".
  82         (struct frame_print_options): Forward declare.
  83         (print_frame_arguments_all, print_frame_arguments_scalars)
  84         (print_frame_arguments_none): Declare.
  85         (print_entry_values): Delete declaration.
  86         (struct frame_print_options, user_frame_print_options): New.
  87         (struct set_backtrace_options): New.
  88         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
  89         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
  90         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
  91         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
  92         (list_args_or_locals): Add frame_print_options parameter.
  93         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
  94         * python/py-framefilter.c (enumerate_args): Pass down
  95         USER_FRAME_PRINT_OPTIONS.
  96         * stack.c: Include "cli/cli-option.h".
  97         (print_frame_arguments_all, print_frame_arguments_scalars)
  98         (print_frame_arguments_none): Declare.
  99         (print_raw_frame_arguments, print_entry_values): Delete.
 100         (user_frame_print_options): New.
 101         (boolean_option_def, enum_option_def, frame_print_option_defs):
 102         New.
 103         (struct backtrace_cmd_options): New.
 104         (bt_flag_option_def): New.
 105         (backtrace_command_option_defs): New.
 106         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 107         (print_frame_arg, read_frame_arg, print_frame_args)
 108         (print_frame_info, print_frame): Add frame_print_options parameter
 109         and use it.
 110         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 111         (backtrace_command_1): Add frame_print_options and
 112         backtrace_cmd_options parameters and use them.
 113         (make_backtrace_options_def_group): New.
 114         (backtrace_command): Process command options with
 115         gdb::option::process_options.
 116         (backtrace_command_completer): New.
 117         (_initialize_stack): Extend "backtrace"'s help to mention
 118         supported options.  Install completer for "backtrace".
 119         Install some settings commands with add_setshow_cmds_for_options.
 120
 121 2019-06-13  Pedro Alves  <palves@redhat.com>
 122
 123         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 124         and that "set/show print raw frame-arguments" are now deprecated.
 125
 126         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 127         command.
 128         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 129         * stack.c (_initialize_stack): Install "set/show print
 130         raw-frame-arguments", and deprecate "set/show print raw
 131         frame-arguments".
 132         * valprint.c (_initialize_valprint): Deprecate "set/show print
 133         raw".
 134
 135 2019-06-13  Pedro Alves  <palves@redhat.com>
 136
 137         * compile/compile.c (struct compile_options): New.
 138         (compile_flag_option_def, compile_command_option_defs)
 139         (make_compile_options_def_group): New.
 140         (compile_file_command): Handle options with
 141         gdb::option::process_options.
 142         (compile_file_command_completer): New function.
 143         (compile_code_command): Handle options with
 144         gdb::option::process_options.
 145         (compile_code_command_completer): New function.
 146         (_initialize_compiler): Install completers for "compile code" and
 147         "compile file".  Mention available options in "compile code" and
 148         "compile code"'s help.
 149         * completer.c (advance_to_completion_word): New, factored out from
 150         ...
 151         (advance_to_expression_complete_word_point): ... this.
 152         (advance_to_filename_complete_word_point): New.
 153         * completer.h (advance_to_filename_complete_word_point): New
 154         declaration.
 155
 156 2019-06-13  Pedro Alves  <palves@redhat.com>
 157
 158         * compile/compile.c: Include "cli/cli-option.h".
 159         (compile_print_value): Scope data pointer is now a
 160         value_print_options pointer; adjust.
 161         (compile_print_command): Process options.  Scope data pointer is
 162         now a value_print_options pointer; adjust.
 163         (_initialize_compile): Update "compile print"'s help to include
 164         supported options.  Install a completer for "compile print".
 165         * cp-valprint.c (show_vtblprint, show_objectprint)
 166         (show_static_field_print): Delete.
 167         (_initialize_cp_valprint): Don't install "set print
 168         static-members", "set print vtbl", "set print object" here.
 169         * printcmd.c: Include "cli/cli-option.h" and
 170         "common/gdb_optional.h".
 171         (print_command_parse_format): Rework to fill in a
 172         value_print_options instead of a format_data.
 173         (print_value): Change parameter type from format_data pointer to
 174         value_print_options reference.  Adjust.
 175         (print_command_1): Process options.  Adjust to pass down a
 176         value_print_options.
 177         (print_command_completer): New.
 178         (_initialize_printcmd): Install print_command_completer as
 179         handle_brkchars completer for the "print" command.  Update
 180         "print"'s help to include supported options.
 181         * valprint.c: Include "cli/cli-option.h".
 182         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 183         here from cp-valprint.c.
 184         (boolean_option_def, uinteger_option_def)
 185         (value_print_option_defs, make_value_print_options_def_group):
 186         New.  Use gdb::option::add_setshow_cmds_for_options to install
 187         "set print elements", "set print null-stop", "set print repeats",
 188         "set print pretty", "set print union", "set print array", "set
 189         print address", "set print symbol", "set print array-indexes".
 190         * valprint.h: Include <string> and "cli/cli-option.h".
 191         (make_value_print_options_def_group): Declare.
 192         (print_value): Change parameter type from format_data pointer to
 193         value_print_options reference.
 194         (print_command_completer): Declare.
 195
 196 2019-06-13  Pedro Alves  <palves@redhat.com>
 197
 198         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 199         (COMMON_SFILES): Add maint-test-settings.c.
 200         * cli/cli-decode.c (boolean_enums): New global, factored out from
 201         ...
 202         (add_setshow_boolean_cmd): ... here.
 203         * cli/cli-decode.h (boolean_enums): Declare.
 204         * cli/cli-option.c: New file.
 205         * cli/cli-option.h: New file.
 206         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 207         factored out from ...
 208         (parse_cli_boolean_value(const char *)): ... this.
 209         (is_unlimited_literal): Change parameter type to pointer to
 210         pointer.  Adjust and advance ARG pointer.
 211         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 212         (parse_cli_var_enum): New, factored out from ...
 213         (do_set_command): ... this.  Adjust.
 214         * cli/cli-setshow.h (parse_cli_boolean_value)
 215         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 216         (parse_cli_var_enum): Declare.
 217         * cli/cli-utils.c: Include "cli/cli-option.h".
 218         (get_ulongest): New.
 219         * cli/cli-utils.h (get_ulongest): Declare.
 220         (check_for_argument): New overloads.
 221         * maint-test-options.c: New file.
 222
 223 2019-06-13  Pedro Alves  <palves@redhat.com>
 224
 225         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 226         parse a range if "-" is at the end of the string.
 227
 228 2019-06-13  Pedro Alves  <palves@redhat.com>
 229
 230         * cli/cli-setshow.c (parse_auto_binary_operation)
 231         (parse_cli_boolean_value): Don't allow "o".
 232
 233 2019-06-13  Pedro Alves  <palves@redhat.com>
 234
 235         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 236         * NEWS: Mention maint test-settings KIND.
 237         * maint-test-settings.c: New file.
 238
 239 2019-06-13  Pedro Alves  <palves@redhat.com>
 240
 241         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 242         completer.
 243         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 244         "set" completers.
 245
 246 2019-06-13  Pedro Alves  <palves@redhat.com>
 247
 248         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 249         after item.
 250
 251 2019-06-13  Pedro Alves  <palves@redhat.com>
 252
 253         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 254
 255 2019-06-13  Pedro Alves <palves@redhat.com>
 256
 257         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 258         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 259         call.
 260         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 261         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 262         calls.
 263         (check_for_argument): Skip spaces after argument.
 264
 265 2019-06-13  Pedro Alves  <palves@redhat.com>
 266
 267         * thread.c (thread_apply_command): Adjust TID parsing.
 268         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 269         detected before end of string.
 270         (tid_is_in_list): Error out if LIST is invalid.
 271
 272 2019-06-13  Pedro Alves  <palves@redhat.com>
 273
 274         * completer.c (complete_line_internal_1): Rewind completion word
 275         point.
 276         (completion_tracker::advance_custom_word_point_by): Change
 277         parameter type to int.
 278         * completer.h (completion_tracker::advance_custom_word_point_by):
 279         Likewise.
 280
 281 2019-06-13  Pedro Alves  <palves@redhat.com>
 282
 283         * completer.c (advance_to_completion_word): Handle delimiters.
 284
 285 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 286
 287         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 288
 289 2019-06-11  Tom Tromey  <tom@tromey.com>
 290
 291         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 292         (xmalloc_failed): Move to alloc.c.
 293         * alloc.c: New file.
 294         * Makefile.in (COMMON_SFILES): Add alloc.c.
 295
 296 2019-06-11  Tom Tromey  <tom@tromey.com>
 297
 298         * nat/linux-waitpid.c: Don't include server.h.
 299         (linux_debug): Remove.
 300         (my_waitpid): Update.
 301
 302 2019-06-11  Tom Tromey  <tromey@adacore.com>
 303
 304         * infcall.c (_initialize_infcall): Remove trailing newline from
 305         help.
 306         * user-regs.c (_initialize_user_regs): Remove trailing newline
 307         from help.
 308         * typeprint.c (_initialize_typeprint): Remove trailing newline
 309         from help.
 310         * reverse.c (_initialize_reverse): Remove trailing newlines from
 311         help.
 312         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 313         from help.
 314         * language.c (add_set_language_command): Remove trailing newline
 315         from help.
 316         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 317         help.
 318         * disasm.c (_initialize_disasm): Remove trailing newline from
 319         help.
 320         * top.c (init_main): Remove trailing newline from help.
 321         * interps.c (_initialize_interpreter): Remove trailing newline
 322         from help.
 323         * btrace.c (_initialize_btrace): Remove trailing newlines from
 324         help.
 325         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 326         from help.
 327         * python/python.c (_initialize_python): Remove trailing newline
 328         from help.
 329         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 330         help.
 331         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 332         from help.  Reformat some text.
 333         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 334         from help.
 335         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 336         newline from help.
 337
 338 2019-06-11  Tom Tromey  <tromey@adacore.com>
 339
 340         * darwin-nat.c (darwin_decode_exception_message)
 341         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 342
 343 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 344
 345         * valops.c (value_slice): Check for not allocated or not
 346         associated values.
 347
 348 2019-06-10  Tom de Vries  <tdevries@suse.de>
 349
 350         PR gdb/24618
 351         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 352         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 353         invalid.
 354
 355 2019-06-10  Tom de Vries  <tdevries@suse.de>
 356
 357         PR gdb/24611
 358         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 359         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 360
 361 2019-06-10  Tom de Vries  <tdevries@suse.de>
 362
 363         PR symtab/24545
 364         * symtab.c (struct demangled_name_entry): Add language field.
 365         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 366         static minimal symbol".  Set and use language field.
 367
 368 2019-06-10  Tom Tromey  <tromey@adacore.com>
 369
 370         * ada-lang.c (_initialize_ada_language): Update help text.
 371
 372 2019-06-10  Tom Tromey  <tromey@adacore.com>
 373
 374         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 375         with a newline.
 376         * guile/guile.c (handle_boot_error): Don't end warning with a
 377         newline.
 378         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 379         warning with a newline.
 380         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 381         newline.
 382         (s12z_frame_cache): Likewise.
 383         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 384         a newline.
 385         * solib-svr4.c (disable_probes_interface): Don't end warning with
 386         a newline.
 387         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 388         newline.
 389         * python/python.c (do_finish_initialization): Don't end warning
 390         with a newline.
 391
 392 2019-06-10  Tom Tromey  <tom@tromey.com>
 393
 394         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 395         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 396         gdbpy_enter.
 397
 398 2019-06-10  Tom Tromey  <tromey@adacore.com>
 399
 400         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 401         data.
 402         (elf_new_init): Don't call stabsread_new_init.
 403         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 404         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 405         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 406
 407 2019-06-10  Tom de Vries  <tdevries@suse.de>
 408
 409         PR symtab/16264
 410         PR symtab/24517
 411         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 412
 413 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 414
 415         * source.c (find_and_open_source): Also rewrite relative file
 416         names.
 417
 418 2019-04-26  Amos Bird  <amosbird@gmail.com>
 419
 420         * annotate.c (annotate_thread_exited): Add "thread-exited"
 421         annotation.
 422
 423 2019-06-06  Tom Tromey  <tromey@adacore.com>
 424
 425         * maint.h (class scoped_command_stats): Use
 426         DISABLE_COPY_AND_ASSIGN.
 427         <print_time>: New method.
 428         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 429         print_time.
 430         (scoped_command_stats::print_time): New method.
 431
 432 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 433
 434         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 435         instructions of lengths 6 or 8 bytes.
 436
 437 2019-06-04  Pedro Alves  <palves@redhat.com>
 438
 439         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 440
 441         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 442         * breakpoint.c (condition_completer): Likewise.
 443         * cli/cli-dump.c (scan_expression): Likewise.
 444         * common/filestuff.c (mkdir_recursive): Likewise.
 445         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 446         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 447         (gdb_abspath): Likewise.
 448         * compile/compile-cplus-types.c
 449         (compile_cplus_instance::decl_name): Likewise.
 450         * completer.c (complete_explicit_location):
 451         (signal_completer, reg_or_group_completer_1): Likewise.
 452         * cp-support.c (cp_remove_params_if_any): Likewise.
 453         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 454         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 455         * infcmd.c (strip_bg_char): Likewise.
 456         * linespec.c (copy_token_string): Likewise.
 457         * mi/mi-main.c (output_cores): Likewise.
 458         * psymtab.c (psymtab_search_name):
 459         * symfile.c (test_set_ext_lang_command): Likewise.
 460         * target.c (target_fileio_read_stralloc): Likewise.
 461         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 462         * value.c (complete_internalvar): Likewise.
 463
 464 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 465
 466         Add objfile property to gdb.Type.
 467         * NEWS: Mention Python API addition.
 468         * python/py-type.c (typy_get_objfile): New method.
 469
 470 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 471
 472         * NEWS: Mention the new set|show style [title|highlight].
 473         Mention changes to "show style", "help" and "apropos".
 474
 475 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 476
 477         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 478         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 479         instead of print_help_for_command.
 480         (print_doc_of_command): New function.
 481         (help_list): Add 'apropos -v word' suggestion.
 482         (print_help_for_command): Style the command name using title style.
 483         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 484         (_initialize_cli_cmds): Describe -v in apropos_command help.
 485
 486 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 487
 488         * cli/cli-style.h (cli_style_option): Add name in constructor,
 489         add m_name class member, add constructor with intensity,
 490         add name class function.
 491         (cli_style_option::add_setshow_commands): Remove name argument.
 492         (highlight_style, title_style): New styles.
 493         * cli/cli-style.c (do_show): New function that shows a style
 494         characteristic styling the style name with itself.
 495         (set_style_name): New function.
 496         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 497         Update all callers according to the changes in cli/cli-style.h.
 498         * utils.h (fputs_highlighted): New function.
 499         * utils.c (fputs_highlighted): Likewise.
 500
 501 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 502
 503         * NEWS: Mention new pipe command and new convenience variables.
 504
 505 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 506
 507         * cli/cli-cmds.c (pipe_command): New function.
 508         (_initialize_cli_cmds): Call add_com for pipe_command.
 509         Define | as an alias for pipe.
 510         (exit_status_set_internal_vars): New function.
 511         (shell_escape): Call exit_status_set_internal_vars.
 512         cli/cli-decode.c (find_command_name_length): Recognize | as
 513         a single character command.
 514
 515 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 516
 517         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 518         top.c (execute_command_to_ui_file): New function, mostly a copy
 519         of execute_command_to_string.
 520         (execute_command_to_string): Implement by calling
 521         execute_command_to_ui_file.
 522
 523 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 524
 525         * top.h (saved_command_line): Remove declaration.
 526         * top.c (previous_saved_command_line, previous_repeat_arguments):
 527         New variables.
 528         (saved_command_line): Make static, define together with other
 529         'repeat variables'.
 530         (dont_repeat): Clear repeat_arguments.
 531         (repeat_previous, get_saved_command_line, save_command_line):
 532         New functions.
 533         (gdb_init): Initialize saved_command_line
 534         and previous_saved_command_line.
 535         * main.c (captured_main_1): Remove saved_command_line initialization.
 536         * event-top.c (handle_line_of_input): Update to use
 537         the new 'repeat' related functions instead of direct access to
 538         saved_command_line.
 539         * command.h (repeat_previous, get_saved_command_line,
 540         save_command_line): New declarations.
 541         (dont_repeat): Add comment.
 542
 543 2019-05-30  Tom Tromey  <tromey@adacore.com>
 544
 545         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 546         Fix comment.
 547         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 548
 549 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 550
 551         PR cli/24587
 552         * completer.c (complete): Initialize variable word.
 553
 554 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 555
 556         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 557         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 558         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 559         'body' is NULL to the outter 'if', protecting the '!is_define'
 560         situation as well.
 561
 562 2019-05-29  Tom Tromey  <tromey@adacore.com>
 563
 564         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 565         (dwarf_unknown): New function.
 566         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 567         (dwarf_type_encoding_name): Use dwarf_unknown.
 568
 569 2019-05-29  Tom Tromey  <tromey@adacore.com>
 570
 571         PR c++/20020:
 572         * cp-valprint.c (cp_print_value_fields): Call
 573         cp_print_static_field inside "try".
 574
 575 2019-05-29  Tom Tromey  <tromey@adacore.com>
 576
 577         * inflow.c (struct terminal_info): Add default operator=.
 578         * configure: Rebuild.
 579         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 580         -Wdeprecated-copy-dtor, -Wredundant-move.
 581
 582 2019-05-29  Tom Tromey  <tromey@adacore.com>
 583
 584         * NEWS: Add entry.
 585         * infcmd.c (print_return_value_1): Handle finish_print
 586         option.
 587         (show_print_finish): New function.
 588         (_initialize_infcmd): Add "set/show print finish" commands.
 589         * valprint.c (user_print_options): Initialize new member.
 590         * valprint.h (struct value_print_options) <finish_print>: New
 591         member.
 592
 593 2019-05-28  Tom Tromey  <tromey@adacore.com>
 594
 595         * ada-lang.c (ada_remove_Xbn_suffix)
 596         (find_old_style_renaming_symbol)
 597         (parse_old_style_renaming): Remove.
 598         (ada_find_renaming_symbol): Don't call
 599         find_old_style_renaming_symbol.
 600         (ada_is_renaming_symbol): Rename from
 601         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 602         bool.  Now static.
 603         (ada_read_var_value): Update and simplify.
 604         * ada-exp.y (write_var_or_type): Remove old code.
 605
 606 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 607
 608         * event-top.c: Remove include comment.
 609         * inflow.c (class scoped_ignore_sigttou): Move from here...
 610         * inflow.h (class scoped_ignore_sigttou): ...to here.
 611         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 612         * top.c:  Remove include comment.
 613
 614 2019-05-27  Tom Tromey  <tom@tromey.com>
 615
 616         * NEWS: Fix typo.
 617
 618 2019-05-22  Tom Tromey  <tromey@adacore.com>
 619
 620         * target.c (target_follow_exec): Constify parameter.
 621         * target-delegates.c: Rebuild.
 622         * remote.c (remote_target::follow_exec): Constify parameter.
 623         * infrun.c (follow_exec): Constify parameter.
 624         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 625         (target_follow_exec): Likewise.
 626
 627 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 628
 629         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 630         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 631
 632 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 633
 634         * NEWS: Add debugredirect and testsuite sections.
 635
 636 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 637
 638         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 639         target descriptions using exclusively floating point register name
 640         aliases.
 641
 642 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 643
 644         PR gdb/18644:
 645         * f-lang.c (build_fortran_types): Handle the case where
 646         gdbarch_floatformat_for_type returns a nullptr.
 647
 648 2019-05-21  Tom de Vries  <tdevries@suse.de>
 649
 650         PR cli/24587
 651         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 652
 653 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 654
 655         PR gdb/18644:
 656         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 657         16-byte floats.
 658         * i386-tdep.c (i386_floatformat_for_type): Use
 659         floatformats_ia64_quad for the 16-byte floating point component
 660         within a fortran 32-byte complex number.
 661
 662 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 663
 664         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 665         delete default constructor.
 666         (find_partial_die): Update to return const struct.
 667         (partial_die_parent_scope): Move variable declaration into scope
 668         of its use and change its type to auto.
 669         (guess_partial_die_structure_name): Likewise.
 670         (partial_die_info::fixup): Likewise.
 671
 672 2019-05-17  Tom Tromey  <tromey@adacore.com>
 673
 674         * source.c (find_and_open_source): Remove cast.
 675
 676 2019-05-17  Tom Tromey  <tromey@adacore.com>
 677
 678         * annotate.c (annotate_source): Make "filename" const.
 679         * annotate.h (annotate_source): Use const.
 680
 681 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 682
 683         * disasm.c (set_disassembler_options): Send errors to stderr.
 684
 685 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 686
 687         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 688         (cli_interp_base::set_logging): Check debug_redirect.
 689         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 690         * cli/cli-logging.c (debug_redirect): Add static variable.
 691         (pop_output_files): Add default param.
 692         (handle_redirections): Print debug setting.
 693         (show_logging_command): Likewise.
 694         (_initialize_cli_logging): Add debugredirect command.
 695         * interps.c (current_interp_set_logging): Add debug_redirect
 696         parameter.
 697         * interps.h (set_logging): Add debug_redirect parameter.
 698         (current_interp_set_logging): Likewise.
 699         * mi/mi-common.h: Likewise.
 700         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 701
 702 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 703             Tom Tromey  <tromey@adacore.com>
 704
 705         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 706         directly.
 707         * cli/cli-interp.h (make_logging_output): Remove declaration.
 708         * cli/cli-logging.c (make_logging_output): Remove function.
 709         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 710         directly.
 711         * ui-file.c (tee_file::tee_file): Remove bools.
 712         (tee_file::~tee_file): Remove deletes.
 713         * ui-file.h (tee_file): Remove bools.
 714
 715 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 716
 717         * mi/mi-cmds.h (mi_cmd_complete): New function.
 718         * mi/mi-main.c (mi_cmd_complete): Likewise.
 719         * mi/mi-cmds.c: Define new MI command -complete.
 720         * NEWS: Mention new -complete command.
 721
 722 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 723
 724         * completer.h (complete): New function.
 725         * completer.c (complete): Likewise.
 726         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 727         function defined in completer.h.
 728
 729 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 730
 731        * MAINTAINERS (Write After Approval): Add myself.
 732
 733 2019-05-17  Tom de Vries  <tdevries@suse.de>
 734
 735         PR gdb/24094
 736         * dwarf2read.c (struct cu_partial_die_info): New struct.
 737         (find_partial_die): Return cu_partial_die_info.
 738         (partial_die_parent_scope, guess_partial_die_structure_name)
 739         (partial_die_info::fixup): Handle new return type of find_partial_die.
 740
 741 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 742
 743         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 744         "std::string", simplifying the algorithm.
 745
 746 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 747
 748         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 749         (stap_static_probe_ops::get_probes): Likewise.
 750
 751 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 752
 753         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 754         '-')" and "else if".
 755         (stap_parse_single_operand): Join checks for
 756         "gdbarch_stap_parse_special_token_p" and
 757         "gdbarch_stap_parse_special_token" in the same "if" statement.
 758         Invert check when verifying for operation on register
 759         displacement.
 760
 761 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 762
 763         * stap-probe.c (stap_get_opcode): Update comment.
 764         (stap_get_expected_argument_type): Likewise.
 765         (handle_stap_probe): Likewise.
 766
 767 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 768
 769         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 770         return type to 'bool'.  Adjust comment.  Use 'bool' when
 771         appropriate.
 772         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 773         * stap-probe.c (stap_parse_argument_1): Likewise.
 774         (stap_is_operator): Likewise.
 775         (stap_is_generic_prefix): Likewise.
 776         (stap_is_register_prefix): Likewise.
 777         (stap_is_register_indirection_prefix): Likewise.
 778         (stap_is_integer_prefix): Likewise.
 779         (stap_generic_check_suffix): Likewise.
 780         (stap_check_integer_suffix): Likewise.
 781         (stap_check_register_suffix): Likewise.
 782         (stap_check_register_indirection_suffix): Likewise.
 783         (stap_parse_register_operand): Likewise.
 784         (stap_parse_single_operand): Likewise.
 785         (stap_parse_argument_1): Likewise.
 786         (stap_probe::get_argument_count): Likewise.
 787         (stap_is_operator): Likewise.
 788
 789 2019-05-16  Tom Tromey  <tromey@adacore.com>
 790
 791         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 792         keyword to foreach.
 793
 794 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 795
 796         * linux-thread-db.c (try_thread_db_load_1): Change return type
 797         to bool.
 798         (try_thread_db_load): Likewise.
 799         (try_thread_db_load_from_pdir_1): Likewise.
 800         (try_thread_db_load_from_pdir): Likewise.
 801         (try_thread_db_load_from_sdir): Likewise.
 802         (try_thread_db_load_from_dir): Likewise.
 803         (thread_db_load_search): Likewise.
 804         (has_libpthread): Likewise.
 805         (thread_db_load): Likewise.
 806
 807 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 808
 809         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 810         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 811         NULL, and complain/return if that's the case.
 812
 813 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 814
 815         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 816         (advance, posn, abstract_read_memory): New functions.
 817         [struct mem_read_abstraction]: New struct.
 818         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 819
 820 2019-05-14  Tom Tromey  <tromey@adacore.com>
 821
 822         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 823         value is not lval_memory.
 824
 825 2019-05-14  Tom Tromey  <tromey@adacore.com>
 826
 827         * solib.c (info_sharedlibrary_command): Style the file name.
 828
 829 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 830
 831         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 832         (aarch64_vnv_type): Likewise.
 833         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 834         * common/tdesc.c: Likewise.
 835         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 836         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 837         * features/aarch64-fpu.xml: Add ieee half view.
 838         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 839         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 840         * gdbtypes.h (struct builtin_type): Likewise.
 841         (struct objfile_type): Likewise.
 842
 843 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 844
 845         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 846         typo.
 847         * location.h (string_to_event_location): Likewise.
 848
 849 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 850
 851         GDB 8.3 released.
 852
 853 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 854
 855         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 856         New variable declaration.
 857         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 858         New variable.
 859         (print_one_breakpoint): Use ui_out::test_flags and new global
 860         variable to compute use_fixed_output.
 861         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 862         Remove.
 863         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 864         (mi_multi_location_breakpoint_output_fixed): Remove.
 865         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 866         new variable.
 867         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 868         fix_multi_location_breakpoint_output flag if version >= 3.
 869         * ui-out.h (enum ui_out_flag)
 870         <fix_multi_location_breakpoint_output>: New enumerator.
 871
 872 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 873
 874         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 875
 876 2019-05-10  Tom Tromey  <tromey@adacore.com>
 877
 878         * ada-lang.c (catch_ada_completer): New function.
 879         (_initialize_ada_language): Use it.
 880
 881 2019-05-10  Tom Tromey  <tromey@adacore.com>
 882
 883         * thread.c (print_thread_info): Make "requested_threads" const.
 884         * gdbthread.h (print_thread_info): Make "requested_threads"
 885         const.
 886         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 887         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 888
 889 2019-05-08  Tom Tromey  <tom@tromey.com>
 890
 891         * gdbtypes.c (objfile_type_data): Change type.
 892         (objfile_type, _initialize_gdbtypes): Update.
 893
 894 2019-05-08  Tom Tromey  <tom@tromey.com>
 895
 896         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 897         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 898         (_initialize_dwarf2_frame): Update.
 899
 900 2019-05-08  Tom Tromey  <tom@tromey.com>
 901
 902         * objc-lang.c (objc_objfile_data): Change type.
 903         (find_methods): Update.
 904         (_initialize_objc_lang): Remove.
 905
 906 2019-05-08  Tom Tromey  <tom@tromey.com>
 907
 908         * stabsread.c (rs6000_builtin_type_data): Change type.
 909         (rs6000_builtin_type, _initialize_stabsread): Update.
 910
 911 2019-05-08  Tom Tromey  <tom@tromey.com>
 912
 913         * mips-tdep.c (mips_pdr_data): Remove.
 914         (_initialize_mips_tdep): Update.
 915
 916 2019-05-08  Tom Tromey  <tom@tromey.com>
 917
 918         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 919         (hppa_init_objfile_priv_data, read_unwind_info)
 920         (find_unwind_entry, _initialize_hppa_tdep): Update.
 921
 922 2019-05-08  Tom Tromey  <tom@tromey.com>
 923
 924         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 925         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 926         on obstack.
 927         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 928
 929 2019-05-08  Tom Tromey  <tom@tromey.com>
 930
 931         * mdebugread.c (basic_type_data): Change type.
 932         (basic_type, _initialize_mdebugread): Update.
 933
 934 2019-05-08  Tom Tromey  <tom@tromey.com>
 935
 936         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 937
 938 2019-05-08  Tom Tromey  <tom@tromey.com>
 939
 940         * nto-tdep.c (nto_inferior_data_reg): Change type.
 941         (nto_inferior_data): Update.
 942         (nto_inferior_data_cleanup, nto_new_inferior_data)
 943         (_initialize_nto_tdep): Remove.
 944         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 945
 946 2019-05-08  Tom Tromey  <tom@tromey.com>
 947
 948         * ada-lang.c (struct ada_inferior_data): Add initializers.
 949         (ada_inferior_data): Change type.
 950         (ada_inferior_data_cleanup): Remove.
 951         (get_ada_inferior_data, ada_inferior_exit)
 952         (struct ada_pspace_data): Add initializers, destructor.
 953         (ada_pspace_data_handle): Change type.
 954         (get_ada_pspace_data): Update.
 955         (ada_pspace_data_cleanup): Remove.
 956
 957 2019-05-08  Tom Tromey  <tom@tromey.com>
 958
 959         * coffread.c (struct coff_symfile_info): Add initializers.
 960         (coff_objfile_data_key): Move lower.  Change type.
 961         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 962         Update.
 963         (coff_free_info): Remove.
 964
 965 2019-05-08  Tom Tromey  <tom@tromey.com>
 966
 967         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 968         (fbsd_pspace_data_handle): Move lower.  Change type.
 969         (get_fbsd_pspace_data): Update.
 970         (fbsd_pspace_data_cleanup): Remove.
 971         (_initialize_fbsd_tdep): Update.
 972
 973 2019-05-08  Tom Tromey  <tom@tromey.com>
 974
 975         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 976         (get_ada_tasks_pspace_data): Update.
 977         (ada_tasks_pspace_data_cleanup): Remove.
 978         (_initialize_tasks): Update.
 979         (ada_tasks_inferior_data_handle): Change type.
 980         (get_ada_tasks_inferior_data): Update.
 981         (ada_tasks_inferior_data_cleanup): Remove.
 982         (struct ada_tasks_pspace_data): Add initializers.
 983
 984 2019-05-08  Tom Tromey  <tom@tromey.com>
 985
 986         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 987         * symfile-debug.c (debug_sym_get_probes): Change type.
 988         * stap-probe.c (handle_stap_probe):
 989         (stap_static_probe_ops::get_probes): Change type.
 990         * probe.h (class static_probe_ops) <get_probes>: Change type.
 991         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 992         (parse_probes_in_pspace): Update.
 993         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 994         Update.
 995         (any_static_probe_ops::get_probes): Change type.
 996         * elfread.c (elfread_data): New typedef.
 997         (probe_key): Change type.
 998         (elf_get_probes): Likewise.  Update.
 999         (probe_key_free): Remove.
1000         (_initialize_elfread): Update.
1001         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1002         Change type.
1003         (dtrace_process_dof_probe, dtrace_process_dof)
1004         (dtrace_static_probe_ops::get_probe): Change type.
1005
1006 2019-05-08  Tom Tromey  <tom@tromey.com>
1007
1008         * xcoffread.c (struct xcoff_symfile_info): Rename from
1009         coff_symfile_info.  Add initializers.
1010         (xcoff_objfile_data_key): Move lower.  Change type.
1011         (XCOFF_DATA): Rewrite.
1012         (xcoff_free_info): Remove.
1013         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1014         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1015         (xcoff_initial_scan): Update.
1016
1017 2019-05-08  Tom Tromey  <tom@tromey.com>
1018
1019         * solib-svr4.c (struct svr4_info): Add initializers and
1020         destructor.
1021         <probes_table>: Now an htab_up.
1022         (solib_svr4_pspace_data): Change type.
1023         (free_probes_table): Simplify.
1024         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1025         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1026         (probes_table_remove_objfile_probes, register_solib_event_probe)
1027         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1028         (_initialize_svr4_solib): Update.
1029
1030 2019-05-08  Tom Tromey  <tom@tromey.com>
1031
1032         * remote.c (remote_pspace_data): Change type.
1033         (remote_pspace_data_cleanup): Remove.
1034         (get_remote_exec_file, set_pspace_remote_exec_file)
1035         (_initialize_remote): Update.
1036
1037 2019-05-08  Tom Tromey  <tom@tromey.com>
1038
1039         * breakpoint.c (breakpoint_objfile_key): Change type.
1040         (get_breakpoint_objfile_data): Update.
1041         (free_breakpoint_objfile_data): Remove.
1042         (_initialize_breakpoint): Update.
1043
1044 2019-05-08  Tom Tromey  <tom@tromey.com>
1045
1046         * linux-tdep.c (struct linux_info): Add initializers.
1047         (linux_inferior_data): Move.  Change type.
1048         (invalidate_linux_cache_inf): Update.
1049         (linux_inferior_data_cleanup): Remove.
1050         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1051
1052 2019-05-08  Tom Tromey  <tom@tromey.com>
1053
1054         * auxv.c (auxv_inferior_data): Move.  Change type.
1055         (auxv_inferior_data_cleanup): Remove.
1056         (invalidate_auxv_cache_inf): Rewrite.
1057         (get_auxv_inferior_data, _initialize_auxv): Update.
1058
1059 2019-05-08  Tom Tromey  <tom@tromey.com>
1060
1061         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1062         (symfile_debug_objfile_data_key): Change type.
1063         (symfile_debug_installed, debug_qf_has_symbols)
1064         (debug_qf_find_last_source_symtab)
1065         (debug_qf_forget_cached_source_info)
1066         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1067         (debug_qf_print_stats, debug_qf_dump)
1068         (debug_qf_expand_symtabs_for_function)
1069         (debug_qf_expand_all_symtabs)
1070         (debug_qf_expand_symtabs_with_fullname)
1071         (debug_qf_map_matching_symbols)
1072         (debug_qf_expand_symtabs_matching)
1073         (debug_qf_find_pc_sect_compunit_symtab)
1074         (debug_qf_map_symbol_filenames)
1075         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1076         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1077         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1078         (debug_sym_read_linetable, debug_sym_relocate): Update.
1079         (symfile_debug_free_objfile): Remove.
1080         (install_symfile_debug_logging, _initialize_symfile_debug):
1081         Update.
1082
1083 2019-05-08  Tom Tromey  <tom@tromey.com>
1084
1085         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1086         allocate_on_obstack.
1087         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1088         (get_dwarf2_per_objfile): Update.
1089         (set_dwarf2_per_objfile): Remove.
1090         (dwarf2_has_info, dwarf2_get_section_info): Update.
1091         (dwarf2_free_objfile): Remove.
1092         (_initialize_dwarf2_read): Update.
1093
1094 2019-05-08  Tom Tromey  <tom@tromey.com>
1095
1096         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1097         initializers.
1098         <unsupported_script_warning_printed,
1099         script_not_found_warning_printed>: Now bool.
1100         (auto_load_pspace_data): Change type.
1101         (~auto_load_pspace_info): Rename from
1102         auto_load_pspace_data_cleanup.
1103         (get_auto_load_pspace_data, init_loaded_scripts_info)
1104         (clear_section_scripts, maybe_print_unsupported_script_warning)
1105         (maybe_print_script_not_found_warning, _initialize_auto_load):
1106         Update.
1107
1108 2019-05-08  Tom Tromey  <tom@tromey.com>
1109
1110         * objfiles.c (objfile_pspace_info): Add destructor and
1111         initializers.
1112         (objfiles_pspace_data): Change type.
1113         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1114         (get_objfile_pspace_data): Update.
1115         (objfiles_bfd_data): Change type.
1116         (get_objfile_bfd_data): Update.
1117         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1118
1119 2019-05-08  Tom Tromey  <tom@tromey.com>
1120
1121         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1122         Change type.
1123         (get_catch_syscall_inferior_data): Update.
1124         (catch_syscall_inferior_data_cleanup): Remove.
1125         (_initialize_break_catch_syscall): Update.
1126
1127 2019-05-08  Tom Tromey  <tom@tromey.com>
1128
1129         * inflow.c (struct terminal_info): Add destructor and
1130         initializers.
1131         (inflow_inferior_data): Change type.
1132         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1133         (get_inflow_inferior_data, inflow_inferior_exit)
1134         (swap_terminal_info, _initialize_inflow): Update.
1135
1136 2019-05-08  Tom Tromey  <tom@tromey.com>
1137
1138         * target-dcache.c (target_dcache_cleanup): Remove.
1139         (target_dcache_aspace_key): Change type.
1140         (target_dcache_init_p, target_dcache_invalidate)
1141         (target_dcache_get, target_dcache_get_or_init)
1142         (_initialize_target_dcache): Update.
1143         * dcache.h (struct dcache_deleter): New.
1144
1145 2019-05-08  Tom Tromey  <tom@tromey.com>
1146
1147         * symtab.c (struct symbol_cache): Add destructor and
1148         initializers.
1149         (symbol_cache_key): Move.  Change type.
1150         (make_symbol_cache, free_symbol_cache): Remove.
1151         (get_symbol_cache): Update.
1152         (symbol_cache_cleanup): Remove.
1153         (ALL_PSPACES, symbol_cache_flush)
1154         (maintenance_print_symbol_cache)
1155         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1156         Update.
1157
1158 2019-05-08  Tom Tromey  <tom@tromey.com>
1159
1160         * symtab.c (struct main_info): Add destructor and initializers.
1161         (main_progspace_key): Move.  Change type.
1162         (get_main_info): Update.
1163         (main_info_cleanup): Remove.
1164         (_initialize_symtab): Update.
1165
1166 2019-05-08  Tom Tromey  <tom@tromey.com>
1167
1168         * registry.h (DECLARE_REGISTRY): Define the _key class.
1169
1170 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1171
1172         * NEWS: Merge two 'New commands' sections.
1173
1174 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1175
1176         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1177         parameter and use Ada language definition instead.
1178         (ada_val_print_ptr): Remove unused language parameter.
1179         (ada_val_print_num): Remove language parameter and use Ada language
1180         definition instead.
1181         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1182         parameter.
1183         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1184         parameter and use Ada language definition instead.
1185         (ada_val_print_1): Update all ada_val_print_xxx calls.
1186         Remove language parameter.
1187         (ada_val_print): Update ada_val_print_1 call.
1188
1189 2019-05-08  Tom Tromey  <tromey@adacore.com>
1190
1191         * remote.c (remote_hw_watchpoint_limit)
1192         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1193         Now static.
1194
1195 2019-05-08  Tom Tromey  <tromey@adacore.com>
1196
1197         * maint.c (_initialize_maint_cmds): Move initialization code to
1198         remote.c.
1199         (watchdog, show_watchdog): Move to remote.c.
1200         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1201         "watchdog" static.
1202         (_initialize_remote): Move initialization code from maint.c.
1203         * defs.h (watchdog): Don't declare.
1204
1205 2019-05-08  Tom Tromey  <tromey@adacore.com>
1206
1207         * tui/tui-interp.c: Include main.h.
1208         * interps.c: Include main.h.
1209         * main.h (interpreter_p): Declare.
1210         * defs.h (interpreter_p): Don't declare.
1211
1212 2019-05-08  Tom Tromey  <tromey@adacore.com>
1213
1214         * dwarf2loc.c: Include dwarf2read.h.
1215         * defs.h (read_unsigned_leb128): Don't declare.
1216         * dwarf2read.h (read_unsigned_leb128): Declare.
1217
1218 2019-05-08  Tom Tromey  <tromey@adacore.com>
1219
1220         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1221         method.
1222
1223 2019-05-08  Tom Tromey  <tromey@adacore.com>
1224
1225         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1226         when no wrap column is set.
1227
1228 2019-05-08  Tom Tromey  <tromey@adacore.com>
1229
1230         * c-lang.c (c_get_string): Handle non-C-style arrays.
1231
1232 2019-05-08  Tom Tromey  <tromey@adacore.com>
1233
1234         * typeprint.c (print_offset_data::update): Print the bit offset,
1235         not the number of bits remaining.
1236
1237 2019-05-08  Tom Tromey  <tromey@adacore.com>
1238
1239         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1240         padding at end of comment.
1241
1242 2019-05-08  Tom Tromey  <tromey@adacore.com>
1243
1244         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1245         Compare main types.
1246
1247 2019-05-06  Tom Tromey  <tom@tromey.com>
1248
1249         * common/scoped_mmap.c: Include common-defs.h.
1250         * common/scoped_mmap.h: Don't include config.h.
1251
1252 2019-05-04  Tom Tromey  <tom@tromey.com>
1253
1254         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1255         (struct aarch64_call_info): Add initializers.
1256         <si>: Now a std::vector.
1257         (pass_on_stack, aarch64_push_dummy_call): Update.
1258
1259 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1260             Tom Tromey  <tom@tromey.com>
1261
1262         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1263         (ppc_threads): Now a std::vector.  Now static.
1264         (hwdebug_find_thread_points_by_tid)
1265         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1266         Update.
1267
1268 2019-05-04  Tom Tromey  <tom@tromey.com>
1269
1270         * arc-tdep.c (arc_tdesc_init): Return bool.
1271
1272 2019-05-04  Tom Tromey  <tom@tromey.com>
1273
1274         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1275         Use gdb_assert_not_reached.
1276
1277 2019-05-04  Tom Tromey  <tom@tromey.com>
1278
1279         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1280         "false".
1281
1282 2019-05-04  Tom Tromey  <tom@tromey.com>
1283
1284         * arc-tdep.c (arc_tdesc_init): Use bool.
1285
1286 2019-05-04  Tom Tromey  <tom@tromey.com>
1287
1288         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1289
1290 2019-05-04  Tom Tromey  <tom@tromey.com>
1291
1292         * cli/cli-cmds.c (valid_command_p): Return bool.
1293
1294 2019-05-04  Tom Tromey  <tom@tromey.com>
1295
1296         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1297         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1298
1299 2019-05-04  Raul Tambre  <raul@tambre.ee>
1300
1301         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1302         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1303         operator for comparison.
1304
1305 2019-05-04  Tom Tromey  <tom@tromey.com>
1306
1307         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1308         (lookup_partial_symbol, print_partial_symbols)
1309         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1310         (psymbol_compare): Update.
1311         (add_psymbol_to_bcache): Clear the entire psymbol.
1312         (maintenance_check_psymtabs): Update.
1313         * psympriv.h (struct partial_symbol): Don't derive from
1314         general_symbol_info.
1315         <obj_section, unrelocated_address, address,
1316         set_unrelocated_address>: Update.
1317         <ginfo>: New member.
1318         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1319         (debug_names::write_psymbols): Update.
1320
1321 2019-05-04  Tom de Vries  <tdevries@suse.de>
1322
1323         * contrib/cc-with-tweaks.sh: Support -n arg.
1324
1325 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1326
1327         * corelow.c (core_target::detach): Ensure frame cache and
1328         register caches are cleared.
1329         inferior.c (exit_inferior_1): Likewise.
1330
1331 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1332             Tom Tromey  <tom@tromey.com>
1333
1334         * dictionary.c (collate_pending_symbols_by_language): Remove
1335         "struct" from foreach.
1336         * symtab.c (lookup_global_symbol_from_objfile)
1337         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1338         foreach.
1339         * ser-tcp.c (net_open): Remove "struct" from foreach.
1340         * objfiles.c (objfile_relocate, objfile_rebase)
1341         (objfile_has_symbols): Remove "struct" from foreach.
1342         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1343         from foreach.
1344         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1345         foreach.
1346         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1347         "struct" from foreach.
1348         * ada-lang.c (create_excep_cond_exprs)
1349         (ada_exception_catchpoint_cond_string): Remove "struct" from
1350         foreach.
1351
1352 2019-05-03  Tom Tromey  <tromey@adacore.com>
1353
1354         * ada-exp.y (convert_char_literal): Check suffix of each
1355         enumerator.
1356
1357 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1358
1359         PR ada/21406:
1360         * ada-exp.y (yywrap): Don't define.
1361         * ada-lex.l (%option): Add noyywrap
1362         (yywrap): Remove.
1363
1364 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1365
1366         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1367         _WIN32_WINNT to the XP level, unless already defined to a higher
1368         level.
1369
1370         * unittests/parse-connection-spec-selftests.c:
1371         * ser-tcp.c:
1372         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1373         override.
1374
1375         * symfile.c (find_separate_debug_file): Remove colon from the
1376         drive spec of DOS/Windows file names of the target, so that the
1377         file name produced from DEBUGDIR and the target's directory will
1378         be valid on DOS/Windows systems.
1379
1380 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1381
1382         * rust-lang.c (val_print_struct): Handle printing structures
1383         containing strings.
1384
1385 2019-05-02  Tom Tromey  <tromey@adacore.com>
1386
1387         * valarith.c (_initialize_valarith): Remove.
1388
1389 2019-05-01  Tom Tromey  <tromey@adacore.com>
1390
1391         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1392         bitfields.
1393
1394 2019-05-01  Tom Tromey  <tromey@adacore.com>
1395
1396         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1397         for big-endian copies.
1398
1399 2019-04-30  Ali Tamur  <tamur@google.com>
1400         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1401         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1402         (read_3_bytes): New function.
1403
1404 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1405
1406         * windows-nat.c (main_thread_id): Delete.
1407         (handle_output_debug_string): Replace main_thread_id by
1408         current_event.dwThreadId.
1409         (fake_create_process): Likewise.
1410         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1411         Do not set main_thread_id.
1412         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1413         current_event.dwThreadId.
1414         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1415
1416 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1417
1418         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1419         Use current_event.dwThreadId instead of main_thread_id.
1420
1421 2019-04-30  Tom Tromey  <tromey@adacore.com>
1422
1423         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1424         (create_excep_cond_exprs): Iterate over program spaces.
1425         (ada_exception_catchpoint_cond_string): Examine all minimal
1426         symbols for exception types.
1427
1428 2019-04-30  Tom Tromey  <tromey@adacore.com>
1429
1430         PR c++/24470:
1431         * dwarf2read.c (process_structure_scope): Handle case where type
1432         has template parameters but no symbol was created.
1433
1434 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1435             Chris January  <chris.january@arm.com>
1436
1437         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1438         qualifier.
1439         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1440
1441 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1442
1443         * f-typeprint.c (f_print_type): Update rules for printing
1444         whitespace.
1445         (f_type_print_varspec_suffix): Likewise.
1446
1447 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1448             Chris January  <chris.january@arm.com>
1449
1450         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1451         function arguments.
1452
1453 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1454
1455         * f-lang.c (build_fortran_types): Change name of void type to
1456         lower case.
1457         * f-typeprint.c (f_type_print_base): Print the name of the void
1458         type, rather than a fixed string.
1459         * f-valprint.c (f_decorations): Use lower case void string.
1460
1461 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1462             Chris January  <chris.january@arm.com>
1463
1464         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1465         types for Fortran.
1466
1467 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1468             Chris January  <chris.january@arm.com>
1469             David Lecomber  <david.lecomber@arm.com>
1470
1471         * f-exp.y (BINOP_INTRINSIC): New token.
1472         (exp): New parser rule handling BINOP_INTRINSIC.
1473         (f77_keywords): Add new builtin procedures.
1474         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1475         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1476         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1477         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1478         (print_unop_subexp_f): New function.
1479         (print_binop_subexp_f): New function.
1480         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1481         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1482         (dump_subexp_body_f): Likewise.
1483         (operator_check_f): Likewise.
1484         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1485         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1486
1487 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1488
1489         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1490         UNOP_KIND.
1491         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1492         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1493         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1494         (operator_length_f): New fuction.
1495         (print_subexp_f): New function.
1496         (op_name_f): New function.
1497         (dump_subexp_body_f): New function.
1498         (operator_check_f): New function.
1499         (exp_descriptor_f): Replace standard expression handling functions
1500         with new functions.
1501         * gdb/fortran-operator.def: New file.
1502         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1503         * gdb/std-operator.def: Remove UNOP_KIND.
1504
1505 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1506
1507         * std-operator.def: Remove unbalanced, stray double quote
1508         character.
1509
1510 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1511             Chris January  <chris.january@arm.com>
1512             Daniel Everett  <daniel.everett@arm.com>
1513             Nick Forrington  <nick.forrington@arm.com>
1514             Richard Bunt  <richard.bunt@arm.com>
1515
1516         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1517         of depth when printing anonymous structs or unions.
1518         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1519         Don't print either the top-level value, or the children if the
1520         max-depth is exceeded.
1521         (ppscm_print_children): When printing the key of a map, allow one
1522         extra level of depth.
1523         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1524         print either the top-level value, or the children if the max-depth
1525         is exceeded.
1526         (print_children): When printing the key of a map, allow one extra
1527         level of depth.
1528         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1529         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1530         (user_print_options): Initialise max_depth field.
1531         (val_print_scalar_or_string_type_p): New function.
1532         (val_print): Check to see if the max depth has been reached.
1533         (val_print_check_max_depth): Define new function.
1534         (show_print_max_depth): New function.
1535         (_initialize_valprint): Add 'print max-depth' option.
1536         * valprint.h (struct value_print_options) <max_depth>: New field.
1537         (val_print_check_max_depth): Declare new function.
1538         * NEWS: Document new feature.
1539
1540 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1541
1542         * ada-lang.c (ada_language_defn): Initialise new field.
1543         * c-lang.c (c_is_string_type_p): New function.
1544         (c_language_defn): Initialise new field.
1545         (cplus_language_defn): Initialise new field.
1546         (asm_language_defn): Initialise new field.
1547         (minimal_language_defn): Initialise new field.
1548         * c-lang.h (c_is_string_type_p): Declare new function.
1549         * d-lang.c (d_language_defn): Initialise new field.
1550         * f-lang.c (f_is_string_type_p): New function.
1551         (f_language_defn): Initialise new field.
1552         * go-lang.c (go_is_string_type_p): New function.
1553         (go_language_defn): Initialise new field.
1554         * language.c (default_is_string_type_p): New function.
1555         (unknown_language_defn): Initialise new field.
1556         (auto_language_defn): Initialise new field.
1557         * language.h (struct language_defn) <la_is_string_type_p>: New
1558         member variable.
1559         (default_is_string_type_p): Declare new function.
1560         * m2-lang.c (m2_language_defn): Initialise new field.
1561         * objc-lang.c (objc_language_defn): Initialise new field.
1562         * opencl-lang.c (opencl_language_defn): Initialise new field.
1563         * p-lang.c (pascal_is_string_type_p): New function.
1564         (pascal_language_defn): Initialise new field.
1565         * rust-lang.c (rust_is_string_type_p): New function.
1566         (rust_language_defn): Initialise new field.
1567
1568 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1569
1570         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1571         New field.
1572         * ada-lang.c (ada_language_defn): Initialise new field.
1573         * c-lang.c (c_language_defn): Likewise.
1574         (cplus_language_defn): Likewise.
1575         (asm_language_defn): Likewise.
1576         (minimal_language_defn): Likewise.
1577         * d-lang.c (d_language_defn): Likewise.
1578         * f-lang.c (f_language_defn): Likewise.
1579         * go-lang.c (go_language_defn): Likewise.
1580         * language.c (unknown_language_defn): Likewise.
1581         (auto_language_defn): Likewise.
1582         * m2-lang.c (m2_language_defn): Likewise.
1583         * objc-lang.c (objc_language_defn): Likewise.
1584         * opencl-lang.c (opencl_language_defn): Likewise.
1585         * p-lang.c (pascal_language_defn): Likewise.
1586         * rust-lang.c (rust_language_defn): Likewise.
1587
1588 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1589
1590         * ada-lang.c (ada_is_character_type): Change return type to bool.
1591         (ada_is_string_type): Likewise.
1592         * ada-lang.h (ada_is_character_type): Update declaration
1593         (ada_is_string_type): Likewise.
1594
1595 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1596
1597         Support style in 'frame|thread apply'
1598
1599         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1600         * record.c (record_start, record_stop): Update callers of
1601         execute_command_to_string with false.
1602         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1603         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1604         methods.
1605         (class string_file): New constructor with term_out parameter.
1606         Override methods term_out and can_emit_style_escape.  New member
1607         term_out.
1608         (class stdio_file): Override can_emit_style_escape.
1609         (class tee_file): Override term_out and can_emit_style_escape.
1610         * utils.h (can_emit_style_escape): Remove.
1611         * utils.c (can_emit_style_escape): Likewise.
1612         Update all callers of can_emit_style_escape (SOMESTREAM) to
1613         SOMESTREAM->can_emit_style_escape.
1614         * source-cache.c (source_cache::get_source_lines): Likewise.
1615         * stack.c (frame_apply_command_count): Call execute_command_to_string
1616         passing the term_out characteristic of the current gdb_stdout.
1617         * thread.c (thr_try_catch_cmd): Likewise.
1618         * top.c (execute_command_to_string): pass term_out parameter
1619         to construct the string_file for the command output.
1620         * ui-file.c (term_cli_styling): New function (most code moved
1621         from utils.c can_emit_style_escape).
1622         (string_file::string_file, string_file::can_emit_style_escape,
1623         stdio_file::can_emit_style_escape, tee_file::term_out,
1624         tee_file::can_emit_style_escape): New functions.
1625
1626 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1627
1628         * NEWS: Mention the new set|show may-call-functions.
1629         * infcall.c (may_call_functions_p): New variable.
1630         (show_may_call_functions_p): New function.
1631         (call_function_by_hand_dummy): Throws an error if not
1632         may-call-functions.
1633         (_initialize_infcall): Call add_setshow_boolean_cmd for
1634         may-call-functions.
1635
1636 2019-04-25  Keith Seitz  <keiths@redhat.com>
1637
1638         PR c++/24367
1639         * cp-support.c (inspect_type): Don't attempt substitutions
1640         of symbol with the same name.
1641
1642 2019-04-25  Tom Tromey  <tromey@adacore.com>
1643
1644         PR gdb/24475:
1645         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1646         static.
1647
1648 2019-04-25  Tom Tromey  <tromey@adacore.com>
1649
1650         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1651         rvalue reference.
1652         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1653         (gdb_xml_parser::parse): Use std::move.
1654         * python/python-internal.h (gdbpy_convert_exception): Take a const
1655         reference.
1656         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1657         std::move.
1658         * python/py-utils.c (gdbpy_convert_exception): Take a const
1659         reference.
1660         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1661         Use std::move.
1662         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1663         Use std::move.
1664         * mi/mi-main.c (mi_print_exception): Take a const reference.
1665         * main.c (handle_command_errors): Take a const reference.
1666         * linespec.c (parse_linespec): Use std::move.
1667         * infcall.c (run_inferior_call): Use std::move.
1668         (call_function_by_hand_dummy): Use std::move.
1669         * exec.c (try_open_exec_file): Use std::move.
1670         * exceptions.h (exception_print, exception_fprintf)
1671         (exception_print_same): Update.
1672         * exceptions.c (print_exception, exception_print)
1673         (exception_fprintf, exception_print_same): Change parameters to
1674         const reference.
1675         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1676         * common/new-op.c: Use std::move.
1677         * common/common-exceptions.h (struct gdb_exception): Add move
1678         constructor.
1679         (struct gdb_exception_error, struct gdb_exception_quit, struct
1680         gdb_quit_bad_alloc): Change constructor to move constructor.
1681         (throw_exception): Change parameter to rvalue reference.
1682         * common/common-exceptions.c (throw_exception): Take rvalue
1683         reference.
1684         * cli/cli-interp.c (safe_execute_command): Use std::move.
1685         * breakpoint.c (insert_bp_location, location_to_sals): Use
1686         std::move.
1687
1688 2019-04-25  Tom Tromey  <tromey@adacore.com>
1689
1690         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1691         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1692         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1693         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1694         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1695         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1696         guile/scm-value.c: Use unpack.
1697         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1698         gdbscm_gdb_exception.
1699         (gdbscm_throw_gdb_exception): Likewise.
1700         (struct gdbscm_gdb_exception): New.
1701         (unpack): New function.
1702         (gdbscm_wrap): Use unpack.
1703
1704 2019-04-25  Tom Tromey  <tromey@adacore.com>
1705
1706         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1707         (gdb_rl_callback_handler): Use std::move.
1708         * common/common-exceptions.h (struct gdb_exception): Add move
1709         assignment operator.
1710         (throw_exception_sjlj): Change "exception" to const reference.
1711         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1712         (throw_exception_sjlj): Change "exception" to const reference.
1713
1714 2019-04-25  Tom Tromey  <tromey@adacore.com>
1715
1716         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1717         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1718         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1719         Update.
1720         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1721         Update.
1722         * mi/mi-interp.c (mi_interp::exec): Update.
1723         * linespec.c (parse_linespec): Update.
1724         * infcall.c (run_inferior_call): Update.
1725         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1726         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1727         (gdbscm_lookup_global_symbol): Update.
1728         * guile/scm-param.c (gdbscm_parameter_value): Update.
1729         * guile/scm-frame.c (gdbscm_frame_read_register)
1730         (gdbscm_frame_read_var): Update.
1731         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1732         * exec.c (try_open_exec_file): Update.
1733         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1734         (gdb_rl_callback_handler): Update.
1735         * common/common-exceptions.h (exception_none): Don't declare.
1736         * common/common-exceptions.c (exception_none): Don't define.
1737         (struct catcher) <exception>: Update.
1738         * cli/cli-interp.c (safe_execute_command): Update.
1739         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1740
1741 2019-04-25  Ali Tamur  <tamur@google.com>
1742
1743         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1744         (read_attribute_value): Likewise.
1745         (dwarf2_read_addr_index): Update comment.
1746         (read_str_index): Add DW_FORM_strx.
1747         (dwarf2_string_attr): Likewise.
1748         (dwarf2_const_value_attr): Likewise.
1749         (dump_die_shallow): Likewise.
1750         (dwarf2_fetch_constant_bytes): Likewise.
1751         (skip_form_bytes): Likewise.
1752         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1753
1754 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1755
1756         PR corefiles/11608
1757         PR corefiles/18187
1758         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1759         OFFSET.  Verify if current mapping contains an ELF header.
1760         (linux_find_memory_regions_full): Adjust call to
1761         dump_mapping_p.
1762
1763 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1764             Kang Li <kanglictf@gmail.com>
1765
1766         PR gdb/21600
1767
1768         * dwarf2-frame.c (read_initial_length): Be consistent about using
1769         unsigned representation of length.
1770         (decode_frame_entry_1): Likewise.  Check for wraparound of
1771         end pointer as well as buffer overflow.
1772
1773 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1774
1775         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1776         "vq".
1777
1778 2019-04-24  Tom Tromey  <tromey@adacore.com>
1779
1780         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1781
1782 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1783
1784         * s12z-tdep.c (s12z_unwind_pc): Delete.
1785         (s12z_unwind_sp): Delete.
1786         (s12z_gdbarch_init): Don't register deleted functions with
1787         gdbarch.
1788
1789 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1790
1791         * rl78-tdep.c (rl78_unwind_sp): Delete.
1792         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1793
1794 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1795
1796         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1797         (xstormy16_unwind_pc): Delete.
1798         (xstormy16_dummy_id): Delete.
1799         (xstormy16_gdbarch_init): Don't register deleted functions with
1800         gdbarch.
1801
1802 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1803
1804         * vax-tdep.c (vax_unwind_pc): Delete.
1805         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1806
1807 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1808
1809         * v850-tdep.c (v850_unwind_sp): Delete.
1810         (v850_unwind_pc): Delete.
1811         (v850_dummy_id): Delete.
1812         (v850_gdbarch_init): Don't register deleted functions with
1813         gdbarch.
1814
1815 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1816
1817         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1818         (tilegx_unwind_pc): Delete.
1819         (tilegx_unwind_dummy_id): Delete.
1820         (tilegx_gdbarch_init): Don't register deleted functions with
1821         gdbarch.
1822
1823 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1824
1825         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1826         (tic6x_dummy_id): Delete.
1827         (tic6x_gdbarch_init): Don't register deleted functions with
1828         gdbarch.
1829
1830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1831
1832         * sparc-tdep.c (sparc_unwind_pc): Delete.
1833         (sparc32_gdbarch_init): Don't register deleted function with
1834         gdbarch.
1835
1836 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1837
1838         * sh-tdep.c (sh_unwind_sp): Delete.
1839         (sh_unwind_pc): Delete.
1840         (sh_dummy_id): Delete.
1841         (sh_gdbarch_init): Don't register deleted functions with
1842         gdbarch.
1843
1844 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1845
1846         * score-tdep.c (score_unwind_sp): Delete.
1847         (score_unwind_pc): Delete.
1848         (score_dummy_id): Delete.
1849         (score_gdbarch_init): Don't register deleted functions with
1850         gdbarch.
1851
1852 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1853
1854         * rx-tdep.c (rx_unwind_pc): Delete.
1855         (rx_unwind_sp): Delete.
1856         (rx_dummy_id): Delete.
1857         (rx_gdbarch_init): Don't register deleted functions with
1858         gdbarch.  Update comment.
1859
1860 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1861
1862         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1863         (rs6000_dummy_id): Delete.
1864         (rs6000_gdbarch_init): Don't register deleted functions with
1865         gdbarch.
1866
1867 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1868
1869         * or1k-tdep.c (or1k_dummy_id): Delete.
1870         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1871
1872 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1873
1874         * nios2-tdep.c (nios2_dummy_id): Delete.
1875         (nios2_unwind_sp): Delete.
1876         (nios2_gdbarch_init): Don't register deleted functions with
1877         gdbarch.
1878
1879 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1880
1881         * nds32-tdep.c (nds32_dummy_id): Delete.
1882         (nds32_unwind_pc): Delete.
1883         (nds32_unwind_sp): Delete.
1884         (nds32_gdbarch_init): Don't register deleted functions with
1885         gdbarch.
1886
1887 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1888
1889         * msp430-tdep.c (msp430_unwind_pc): Delete.
1890         (msp430_unwind_sp): Delete.
1891         (msp430_dummy_id): Delete.
1892         (msp430_gdbarch_init): Don't register deleted functions with
1893         gdbarch.
1894
1895 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1896
1897         * moxie-tdep.c (moxie_unwind_sp): Delete.
1898         (moxie_unwind_pc): Delete.
1899         (moxie_dummy_id): Delete.
1900         (moxie_gdbarch_init): Don't register deleted functions with
1901         gdbarch.
1902
1903 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1904
1905         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1906         (mn10300_unwind_pc): Delete.
1907         (mn10300_unwind_sp): Delete.
1908         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1909         mn10300_unwind_sp.
1910         (mn10300_frame_unwind_init): Don't register deleted functions with
1911         gdbarch.
1912
1913 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1914
1915         * mep-tdep.c (mep_unwind_pc): Delete.
1916         (mep_unwind_sp): Delete.
1917         (mep_dummy_id): Delete.
1918         (mep_gdbarch_init): Don't register deleted functions with
1919         gdbarch.
1920
1921 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1922
1923         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1924         (m68hc11_unwind_sp): Delete.
1925         (m68hc11_gdbarch_init): Don't register deleted functions with
1926         gdbarch.
1927
1928 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1929
1930         * m32r-tdep.c (m32r_unwind_sp): Delete.
1931         (m32r_unwind_pc): Delete.
1932         (m32r_dummy_id): Delete.
1933         (m32r_gdbarch_init): Don't register deleted functions with
1934         gdbarch.
1935
1936 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1937
1938         * m32c-tdep.c (m32c_unwind_pc): Delete.
1939         (m32c_unwind_sp): Delete.
1940         (m32c_dummy_id): Delete.
1941         (m32c_gdbarch_init): Don't register deleted functions with
1942         gdbarch.
1943
1944 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1945
1946         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1947         (lm32_unwind_pc): Delete.
1948         (lm32_dummy_id): Delete.
1949         (lm32_gdbarch_init): Don't register deleted functions with
1950         gdbarch.
1951
1952 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1953
1954         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1955         (iq2000_unwind_pc): Delete.
1956         (iq2000_dummy_id): Delete.
1957         (iq2000_gdbarch_init): Don't register deleted functions with
1958         gdbarch.
1959
1960 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1961
1962         * nds32-tdep.c (nds32_type_align): Delete.
1963         (nds32_push_dummy_call): Use type_align instead.
1964
1965 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1966
1967         * arm-tdep.c (arm_type_align): Only handle vector override case.
1968         (arm_push_dummy_call): Use type_align.
1969         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1970
1971 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1972
1973         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1974         case.
1975         (pass_on_stack): Use type_align.
1976         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1977         function.
1978
1979 2019-04-23  Tom Tromey  <tromey@adacore.com>
1980
1981         * dwarf2read.c (line_header::file_name_at): Remove unused
1982         overload.
1983
1984 2019-04-23  Tom de Vries  <tdevries@suse.de>
1985
1986         PR gdb/24438
1987         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1988         invocation.
1989
1990
1991 2019-03-27  Ali Tamur  <tamur@google.com>
1992
1993         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1994         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1995         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1996         (dwarf_expr_context::get_addr_index): Likewise
1997         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1998         (symbol_needs_eval_context::get_addr_index): Likewise
1999         (disassemble_dwarf_expression): Add DW_OP_addrx
2000         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2001         (read_cutu_die_from_dwo): Update comment
2002         (skip_one_die): Add DW_FORM_addrx
2003         (read_attribute_value): Likewise
2004         (var_decode_location): Add DW_OP_addrx
2005         (dwarf2_const_value_attr): Add DW_FORM_addrx
2006         (dump_die_shallow): Likewise
2007         (dwarf2_fetch_constant_bytes): Likewise
2008         (decode_locdesc): Add DW_OP_addrx
2009         (skip_form_bytes): Add DW_FORM_addrx
2010
2011 2019-04-22  Ali Tamur  <tamur@google.com>
2012
2013         * MAINTAINERS (Write After Approval): Add self.
2014
2015 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2016
2017         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2018         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2019         (open_symbol_file_object): Likewise.
2020         (svr4_default_sos): Add info parameter.
2021         (svr4_read_so_list): Likewise.
2022         (svr4_current_sos_direct): Adjust functions calls to pass down
2023         info.
2024         (svr4_current_sos_1): Add info parameter.
2025         (svr4_current_sos): Call get_svr4_info, pass info down to
2026         svr4_current_sos_1.
2027         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2028         get_svr4_info.
2029         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2030         get_svr4_info.
2031         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2032         to get_svr4_info.
2033         (probes_table_remove_objfile_probes): Likewise.
2034         (register_solib_event_probe): Add info parameter.
2035         (solist_update_incremental): Pass info parameter down to
2036         svr4_read_so_list.
2037         (disable_probes_interface): Add info parameter.
2038         (svr4_handle_solib_event): Pass current_program_space to
2039         get_svr4_info.  Adjust disable_probes_interface cleanup.
2040         (svr4_create_probe_breakpoints): Add info parameter, pass it
2041         down to register_solib_event_probe.
2042         (svr4_create_solib_event_breakpoints): Add info parameter,
2043         pass it down to svr4_create_probe_breakpoints.
2044         (enable_break): Pass info down to
2045         svr4_create_solib_event_breakpoints.
2046         (svr4_solib_create_inferior_hook): Pass current_program_space to
2047         get_svr4_info.
2048         (svr4_clear_solib): Likewise.
2049
2050 2019-04-22  Pedro Alves  <palves@redhat.com>
2051
2052         * solib-svr4.c (svr4_free_objfile_observer): New.
2053         (probe_and_action::objfile): New field.
2054         (probes_table_htab_remove_objfile_probes)
2055         (probes_table_remove_objfile_probes): New functions.
2056         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2057         in the new probe_and_action.  Don't store the probe in 'lookup'.
2058         (svr4_create_probe_breakpoints): Pass objfile to
2059         register_solib_event_probe.
2060         (_initialize_svr4_solib): Register a free_objfile observer.
2061
2062 2019-04-19  Tom Tromey  <tom@tromey.com>
2063
2064         * common/queue.h: Remove.
2065
2066 2019-04-19  Tom Tromey  <tom@tromey.com>
2067
2068         * event-loop.c: Don't include "common/queue.h".
2069
2070 2019-04-19  Tom Tromey  <tom@tromey.com>
2071
2072         * remote.c (remote_target): Use delete.
2073         * remote-notif.h: Include <list>, not "common/queue.h".
2074         (notif_client_p): Remove typedef.
2075         (remote_notif_state): Add constructor, destructor, initializer.
2076         <notif_queue>: Now a std::list.
2077         (remote_notif_state_xfree): Don't declare.
2078         * remote-notif.c (remote_notif_process, handle_notification)
2079         (remote_notif_state_allocate): Update.
2080         (~remote_notif_state): Rename from remote_notif_state_xfree.
2081
2082 2019-04-19  Tom Tromey  <tom@tromey.com>
2083
2084         * symfile.c (reread_symbols): Update.
2085         * objfiles.c (objfile_register_static_link)
2086         (objfile_lookup_static_link): Update
2087         (~objfile) Don't delete static_links.
2088         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2089
2090 2019-04-19  Tom Tromey  <tom@tromey.com>
2091
2092         * type-stack.h (struct type_stack) <insert>: Constify string.
2093         * type-stack.c (type_stack::insert): Constify string.
2094         * gdbtypes.h (lookup_template_type): Update.
2095         (address_space_name_to_int): Update.
2096         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2097         const.
2098         (lookup_template_type): Make name const.
2099         * c-exp.y: Update rules.
2100         (lex_one_token, classify_name, classify_inner_name)
2101         (c_print_token): Update.
2102         * p-exp.y: Update rules.
2103         (yylex): Update.
2104         * f-exp.y: Update rules.
2105         (yylex): Update.
2106         * d-exp.y: Update rules.
2107         (lex_one_token, classify_name, classify_inner_name): Update.
2108         * parse.c (write_dollar_variable, copy_name): Return std::string.
2109         * parser-defs.h (copy_name): Change return type.
2110         * m2-exp.y: Update rules.
2111         (yylex): Update.
2112         * go-exp.y (lex_one_token): Update.
2113         Update rules.
2114         (classify_unsafe_function, classify_packaged_name)
2115         (classify_name, yylex): Update.
2116
2117 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2118
2119         * configure.ac: add --enable-source-highlight switch.
2120         * configure: Regenerate.
2121         * top.c (print_gdb_version): plumb --enable-source-highlight
2122         status to "show configuration".
2123
2124 2019-04-19  Tom Tromey  <tromey@adacore.com>
2125
2126         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2127         Check ADA_TYPE_P.
2128         (empty_record, ada_template_to_fixed_record_type_1)
2129         (template_to_static_fixed_type)
2130         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2131         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2132         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2133         macros.
2134
2135 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2136
2137         PR symtab/24423:
2138         * source.c (print_source_lines_base): Advance "iter" when a
2139         control character is seen.
2140
2141 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2142
2143         * inferior.h (struct infcall_suspend_state_deleter):
2144         Catch exception in destructor to avoid crash.
2145
2146 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2147
2148         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2149         close to the add_com "shell".
2150
2151 2019-04-18  Tom Tromey  <tromey@adacore.com>
2152
2153         * process-stratum-target.h (class process_stratum_target)
2154         <stratum>: Add "final".
2155
2156 2019-04-17  Tom Tromey  <tromey@adacore.com>
2157
2158         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2159         against nullptr before use.
2160
2161 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2162
2163         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2164
2165 2019-04-17  Jim Wilson  <jimw@sifive.com>
2166             Andrew Burgess  <andrew.burgess@embecosm.com>
2167
2168         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2169         code read might fail, assume 4-byte breakpoint in that case.
2170
2171 2019-04-15  Leszek Swirski  <leszeks@google.com>
2172
2173         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2174         rather than a hand-rolled POD check when checking for forced MEMORY
2175         classification.
2176
2177 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2178
2179         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2180         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2181         function.
2182         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2183         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2184         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2185         declaration.
2186
2187 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2188
2189         * aarch64-linux-nat.c
2190         (aarch64_linux_nat_target::thread_architecture): Add override.
2191         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2192         each VQ.
2193
2194 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2195
2196         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2197
2198 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2199
2200         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2201         target types of size 96-bits, add some additional comments, and
2202         check that the builtin type we found was the correct size.
2203
2204 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2205
2206         * utils.c (prompt_for_continue): Don't restore the styling at the
2207         end, as applied_style has the wrong value.  This fixes styling in
2208         long lists of file names that are interrupted by the "Continue?"
2209         prompt.
2210
2211 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2212
2213         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2214         * c-lang.c (c_language_defn): Likewise.
2215         (cplus_language_defn): Likewise.
2216         (asm_language_defn): Likewise.
2217         (minimal_language_defn): Likewise.
2218         * d-lang.c (d_language_defn): Likewise.
2219         * f-lang.c (f_language_defn): Likewise.
2220         * go-lang.c (go_language_defn): Likewise.
2221         * language.c (unknown_language_defn): Likewise.
2222         (auto_language_defn): Likewise.
2223         * language.h (struct language_defn): Remove la_magic field.
2224         (LANG_MAGIC): Delete.
2225         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2226         * objc-lang.c (objc_language_defn): Likewise.
2227         * opencl-lang.c (opencl_language_defn): Likewise.
2228         * p-lang.c (pascal_language_defn): Likewise.
2229         * rust-lang.c (rust_language_defn): Likewise.
2230
2231 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2232
2233         * riscv-tdep.c (riscv_type_align): New function.
2234         (riscv_type_alignment): Delete.
2235         (riscv_arg_location): Use 'type_align'.
2236         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2237
2238 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2239
2240         * gdbtypes.c (type_align): A struct with no non-static fields also
2241         has alignment of 1.
2242
2243 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2244
2245         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2246         component to 0.
2247         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2248         member.
2249         (riscv_struct_info::analyse): New implementation using new
2250         analyse_inner member function.
2251         (riscv_struct_info::field_offset): New member function.
2252         (riscv_struct_info::m_offsets): New member variable.
2253         (riscv_struct_info::analyse_inner): New private member function,
2254         takes the old implementation of riscv_struct_info::analyse but
2255         extended to track field offsets.
2256         (riscv_call_arg_struct): Update the struct folding special cases
2257         to handle cases where empty C++ structs, which are non-zero
2258         length, are found.
2259         (riscv_arg_location): Initialise the length of each location, a
2260         non-zero length now indicates the location is in use.
2261         (riscv_push_dummy_call): Allow for the first location having a
2262         non-zero offset when setting up arguments.
2263         (riscv_return_value): Likewise, but for return values.
2264
2265 2019-04-11  Tom Tromey  <tromey@adacore.com>
2266
2267         * utils.c (internal_vproblem): Make "msg" const.
2268
2269 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2270
2271         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2272         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2273         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2274         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2275
2276 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2277
2278         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2279         function.
2280         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2281         of amd64_collect_native_gregset.
2282         (amd64_linux_nat_target::store_registers): Likewise.
2283
2284 2019-04-10  Tom Tromey  <tom@tromey.com>
2285
2286         * symtab.c (lookup_global_symbol_from_objfile)
2287         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2288         * objfiles.h (class separate_debug_iterator): New.
2289         (class separate_debug_range): New.
2290         (struct objfile) <separate_debug_objfiles>: New method.
2291         (objfile_separate_debug_iterate): Don't declare.
2292         * objfiles.c (separate_debug_iterator::operator++): Rename from
2293         objfile_separate_debug_iterate.
2294         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2295         iterator.
2296         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2297         iterator.
2298
2299 2019-04-10  Tom Tromey  <tom@tromey.com>
2300
2301         * symfile.c (reread_symbols): Remove old comment.
2302         * objfiles.c (free_all_objfiles): Fix a typo.
2303
2304 2019-04-10  Tom Tromey  <tom@tromey.com>
2305
2306         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2307         * minsyms.c (lookup_minimal_symbol): Use foreach.
2308         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2309         (lookup_minimal_symbol_solib_trampoline): Likewise.
2310         * symfile.c (reread_symbols): Use foreach.
2311
2312 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2313             Tom Tromey  <tromey@adacore.com>
2314
2315         PR rust/24414:
2316         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2317         (rust_lex_int_test): Change "value" to be LONGEST.
2318         (rust_lex_tests): Add test for long integer literal.
2319
2320 2019-04-09  Tom Tromey  <tromey@adacore.com>
2321
2322         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2323         to bool.
2324         (extended_remote_target::attach): Update.
2325         (remote_target::remote_notice_new_inferior): Update.
2326         (remote_target::add_current_inferior_and_thread): Update.
2327         * inferior.c (exit_inferior_1): Use "false".
2328         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2329
2330 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2331
2332         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2333         the "start" command.
2334
2335 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2336
2337         * python/py-inferior.c (infpy_thread_from_thread_handle):
2338         Adjust comments to reflect renaming of thread_from_thread_handle
2339         to thread_from_handle.  Adjust keywords.  Fix type error message.
2340         (inferior_object_methods): Add thread_from_handle.  Retain
2341         thread_from_thread_handle, but mark it as deprecated.
2342
2343 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2344
2345         * gdbthread.h (find_thread_by_handle): Revise declaration.
2346         * thread.c (find_thread_by_handle): Likewise.  Adjust
2347         implementation too.
2348         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2349         support for buffer objects as handles.
2350
2351 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2352
2353         * python/py-infthread.c (thpy_thread_handle): New function.
2354         (thread_object_methods): Register thpy_thread_handle.
2355
2356 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2357
2358         * gdbthread.h (thread_to_thread_handle): Declare.
2359         * thread.c (gdbtypes.h): Include.
2360         (thread_to_thread_handle): New function.
2361
2362         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2363         (target_thread_info_to_thread_handle): Declare.
2364         * target.c (target_thread_info_to_thread_handle): New function.
2365         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2366         * target-delegates.c: Regenerate.
2367
2368         * linux-thread-db.c (class thread_db_target): Add method
2369         thread_info_to_thread_handle.
2370         (thread_db_target::thread_info_to_thread_handle): Define.
2371         * remote.c (class remote_target): Add new method
2372         thread_info_to_thread_handle.
2373         (remote_target::thread_info_to_thread_handle): Define.
2374
2375 2019-04-08  Pedro Alves  <palves@redhat.com>
2376
2377         * common/common-exceptions.c (throw_exception): Don't create
2378         named object to throw; throw directly.
2379         (throw_it): Likewise.  Don't initialize gdb_exception::message
2380         here, with new; pass FMT and AP to the ctor instead.
2381         * common/common-exceptions.h: Include <string>.
2382         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2383         const char *, va_list)): New ctor.  Use std::make_shared.
2384         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2385         errors)): Delete.
2386         (gdb_exception_error::gdb_exception_error(enum errors, const char
2387         *, va_list)): New.
2388         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2389         Add assertion.
2390         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2391         errors)): Delete.
2392         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2393         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2394         Add assertion.
2395
2396 2019-04-08  Tom Tromey  <tom@tromey.com>
2397
2398         * valops.c (value_rtti_indirect_type): Replace throw_exception
2399         with throw.
2400         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2401         with throw.
2402         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2403         throw.
2404         * target.c (target_translate_tls_address): Replace throw_exception
2405         with throw.
2406         * stack.c (frame_apply_command_count): Replace throw_exception
2407         with throw.
2408         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2409         throw.
2410         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2411         with throw.
2412         * rs6000-tdep.c (rs6000_frame_cache)
2413         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2414         * remote.c: Replace throw_exception with throw.
2415         * record-full.c (record_full_message, record_full_wait_1)
2416         (record_full_restore): Replace throw_exception with throw.
2417         * record-btrace.c:
2418         (get_thread_current_frame_id, record_btrace_start_replaying)
2419         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2420         (cmd_record_btrace_start): Replace throw_exception with throw.
2421         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2422         throw.
2423         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2424         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2425         * linespec.c:
2426         (find_linespec_symbols): Replace throw_exception with throw.
2427         * infrun.c (displaced_step_prepare, resume): Replace
2428         throw_exception with throw.
2429         * infcmd.c (post_create_inferior): Replace throw_exception with
2430         throw.
2431         * inf-loop.c (inferior_event_handler): Replace throw_exception
2432         with throw.
2433         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2434         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2435         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2436         (get_prev_frame_always, get_frame_pc_if_available)
2437         (get_frame_address_in_block_if_available, get_frame_language):
2438         Replace throw_exception with throw.
2439         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2440         throw_exception with throw.
2441         * eval.c (fetch_subexp_value, evaluate_var_value)
2442         (evaluate_funcall, evaluate_subexp_standard): Replace
2443         throw_exception with throw.
2444         * dwarf2loc.c (call_site_find_chain)
2445         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2446         Replace throw_exception with throw.
2447         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2448         with throw.
2449         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2450         throw.
2451         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2452         * completer.c (complete_line_internal): Replace throw_exception
2453         with throw.
2454         * compile/compile-object-run.c (compile_object_run): Replace
2455         throw_exception with throw.
2456         * cli/cli-script.c (process_next_line): Replace throw_exception
2457         with throw.
2458         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2459         (btrace_enable, btrace_maint_update_pt_packets): Replace
2460         throw_exception with throw.
2461         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2462         throw_exception with throw.
2463         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2464         throw_exception with throw.
2465         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2466         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2467         * aarch64-tdep.c (aarch64_make_prologue_cache)
2468         (aarch64_make_stub_cache): Replace throw_exception with throw.
2469
2470 2019-04-08  Tom Tromey  <tom@tromey.com>
2471
2472         * common/common-exceptions.c (throw_exception): Rename from
2473         throw_exception_cxx.  Remove old copy.  Make argument const.
2474         (throw_it): Create and throw exception objects directly.
2475         * common/common-exceptions.h (throw_exception): Make argument
2476         const.
2477         (struct gdb_exception_error): Add constructor.
2478         (struct gdb_exception_quit): Add constructor.
2479
2480 2019-04-08  Tom Tromey  <tom@tromey.com>
2481
2482         * common/common-exceptions.h (exception_rethrow): Don't declare.
2483         (TRY_SJLJ): Update comment.
2484         (TRY, CATCH, END_CATCH): Remove.
2485         * common/common-exceptions.c (exception_rethrow): Remove.
2486
2487 2019-04-08  Tom Tromey  <tom@tromey.com>
2488
2489         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2490         Remove.
2491         (gdb_exception_error): Rename from
2492         gdb_exception_RETURN_MASK_ERROR.
2493         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2494         (gdb_quit_bad_alloc): Update.
2495         * aarch64-tdep.c: Update.
2496         * ada-lang.c: Update.
2497         * ada-typeprint.c: Update.
2498         * ada-valprint.c: Update.
2499         * amd64-tdep.c: Update.
2500         * arch-utils.c: Update.
2501         * break-catch-throw.c: Update.
2502         * breakpoint.c: Update.
2503         * btrace.c: Update.
2504         * c-varobj.c: Update.
2505         * cli/cli-cmds.c: Update.
2506         * cli/cli-interp.c: Update.
2507         * cli/cli-script.c: Update.
2508         * common/common-exceptions.c: Update.
2509         * common/new-op.c: Update.
2510         * common/selftest.c: Update.
2511         * compile/compile-c-symbols.c: Update.
2512         * compile/compile-cplus-symbols.c: Update.
2513         * compile/compile-object-load.c: Update.
2514         * compile/compile-object-run.c: Update.
2515         * completer.c: Update.
2516         * corelow.c: Update.
2517         * cp-abi.c: Update.
2518         * cp-support.c: Update.
2519         * cp-valprint.c: Update.
2520         * darwin-nat.c: Update.
2521         * disasm-selftests.c: Update.
2522         * dtrace-probe.c: Update.
2523         * dwarf-index-cache.c: Update.
2524         * dwarf-index-write.c: Update.
2525         * dwarf2-frame-tailcall.c: Update.
2526         * dwarf2-frame.c: Update.
2527         * dwarf2loc.c: Update.
2528         * dwarf2read.c: Update.
2529         * eval.c: Update.
2530         * event-loop.c: Update.
2531         * event-top.c: Update.
2532         * exec.c: Update.
2533         * f-valprint.c: Update.
2534         * fbsd-tdep.c: Update.
2535         * frame-unwind.c: Update.
2536         * frame.c: Update.
2537         * gdbtypes.c: Update.
2538         * gnu-v3-abi.c: Update.
2539         * guile/guile-internal.h: Update.
2540         * guile/scm-block.c: Update.
2541         * guile/scm-breakpoint.c: Update.
2542         * guile/scm-cmd.c: Update.
2543         * guile/scm-disasm.c: Update.
2544         * guile/scm-frame.c: Update.
2545         * guile/scm-lazy-string.c: Update.
2546         * guile/scm-math.c: Update.
2547         * guile/scm-param.c: Update.
2548         * guile/scm-ports.c: Update.
2549         * guile/scm-pretty-print.c: Update.
2550         * guile/scm-symbol.c: Update.
2551         * guile/scm-symtab.c: Update.
2552         * guile/scm-type.c: Update.
2553         * guile/scm-value.c: Update.
2554         * i386-linux-tdep.c: Update.
2555         * i386-tdep.c: Update.
2556         * inf-loop.c: Update.
2557         * infcall.c: Update.
2558         * infcmd.c: Update.
2559         * infrun.c: Update.
2560         * jit.c: Update.
2561         * language.c: Update.
2562         * linespec.c: Update.
2563         * linux-fork.c: Update.
2564         * linux-nat.c: Update.
2565         * linux-tdep.c: Update.
2566         * linux-thread-db.c: Update.
2567         * main.c: Update.
2568         * mi/mi-cmd-break.c: Update.
2569         * mi/mi-cmd-stack.c: Update.
2570         * mi/mi-interp.c: Update.
2571         * mi/mi-main.c: Update.
2572         * objc-lang.c: Update.
2573         * p-valprint.c: Update.
2574         * parse.c: Update.
2575         * ppc-linux-tdep.c: Update.
2576         * printcmd.c: Update.
2577         * python/py-arch.c: Update.
2578         * python/py-breakpoint.c: Update.
2579         * python/py-cmd.c: Update.
2580         * python/py-finishbreakpoint.c: Update.
2581         * python/py-frame.c: Update.
2582         * python/py-framefilter.c: Update.
2583         * python/py-gdb-readline.c: Update.
2584         * python/py-inferior.c: Update.
2585         * python/py-infthread.c: Update.
2586         * python/py-lazy-string.c: Update.
2587         * python/py-linetable.c: Update.
2588         * python/py-objfile.c: Update.
2589         * python/py-param.c: Update.
2590         * python/py-prettyprint.c: Update.
2591         * python/py-progspace.c: Update.
2592         * python/py-record-btrace.c: Update.
2593         * python/py-record.c: Update.
2594         * python/py-symbol.c: Update.
2595         * python/py-type.c: Update.
2596         * python/py-unwind.c: Update.
2597         * python/py-utils.c: Update.
2598         * python/py-value.c: Update.
2599         * python/python.c: Update.
2600         * record-btrace.c: Update.
2601         * record-full.c: Update.
2602         * remote-fileio.c: Update.
2603         * remote.c: Update.
2604         * riscv-tdep.c: Update.
2605         * rs6000-aix-tdep.c: Update.
2606         * rs6000-tdep.c: Update.
2607         * rust-exp.y: Update.
2608         * rust-lang.c: Update.
2609         * s390-tdep.c: Update.
2610         * selftest-arch.c: Update.
2611         * solib-dsbt.c: Update.
2612         * solib-frv.c: Update.
2613         * solib-spu.c: Update.
2614         * solib-svr4.c: Update.
2615         * solib.c: Update.
2616         * sparc64-linux-tdep.c: Update.
2617         * stack.c: Update.
2618         * symfile-mem.c: Update.
2619         * symmisc.c: Update.
2620         * target.c: Update.
2621         * thread.c: Update.
2622         * top.c: Update.
2623         * tracefile-tfile.c: Update.
2624         * tui/tui.c: Update.
2625         * typeprint.c: Update.
2626         * unittests/cli-utils-selftests.c: Update.
2627         * unittests/parse-connection-spec-selftests.c: Update.
2628         * valops.c: Update.
2629         * valprint.c: Update.
2630         * value.c: Update.
2631         * varobj.c: Update.
2632         * windows-nat.c: Update.
2633         * x86-linux-nat.c: Update.
2634         * xml-support.c: Update.
2635
2636 2019-04-08  Tom Tromey  <tom@tromey.com>
2637
2638         * xml-support.c: Use C++ exception handling.
2639         * x86-linux-nat.c: Use C++ exception handling.
2640         * windows-nat.c: Use C++ exception handling.
2641         * varobj.c: Use C++ exception handling.
2642         * value.c: Use C++ exception handling.
2643         * valprint.c: Use C++ exception handling.
2644         * valops.c: Use C++ exception handling.
2645         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2646         handling.
2647         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2648         * typeprint.c: Use C++ exception handling.
2649         * tui/tui.c: Use C++ exception handling.
2650         * tracefile-tfile.c: Use C++ exception handling.
2651         * top.c: Use C++ exception handling.
2652         * thread.c: Use C++ exception handling.
2653         * target.c: Use C++ exception handling.
2654         * symmisc.c: Use C++ exception handling.
2655         * symfile-mem.c: Use C++ exception handling.
2656         * stack.c: Use C++ exception handling.
2657         * sparc64-linux-tdep.c: Use C++ exception handling.
2658         * solib.c: Use C++ exception handling.
2659         * solib-svr4.c: Use C++ exception handling.
2660         * solib-spu.c: Use C++ exception handling.
2661         * solib-frv.c: Use C++ exception handling.
2662         * solib-dsbt.c: Use C++ exception handling.
2663         * selftest-arch.c: Use C++ exception handling.
2664         * s390-tdep.c: Use C++ exception handling.
2665         * rust-lang.c: Use C++ exception handling.
2666         * rust-exp.y: Use C++ exception handling.
2667         * rs6000-tdep.c: Use C++ exception handling.
2668         * rs6000-aix-tdep.c: Use C++ exception handling.
2669         * riscv-tdep.c: Use C++ exception handling.
2670         * remote.c: Use C++ exception handling.
2671         * remote-fileio.c: Use C++ exception handling.
2672         * record-full.c: Use C++ exception handling.
2673         * record-btrace.c: Use C++ exception handling.
2674         * python/python.c: Use C++ exception handling.
2675         * python/py-value.c: Use C++ exception handling.
2676         * python/py-utils.c: Use C++ exception handling.
2677         * python/py-unwind.c: Use C++ exception handling.
2678         * python/py-type.c: Use C++ exception handling.
2679         * python/py-symbol.c: Use C++ exception handling.
2680         * python/py-record.c: Use C++ exception handling.
2681         * python/py-record-btrace.c: Use C++ exception handling.
2682         * python/py-progspace.c: Use C++ exception handling.
2683         * python/py-prettyprint.c: Use C++ exception handling.
2684         * python/py-param.c: Use C++ exception handling.
2685         * python/py-objfile.c: Use C++ exception handling.
2686         * python/py-linetable.c: Use C++ exception handling.
2687         * python/py-lazy-string.c: Use C++ exception handling.
2688         * python/py-infthread.c: Use C++ exception handling.
2689         * python/py-inferior.c: Use C++ exception handling.
2690         * python/py-gdb-readline.c: Use C++ exception handling.
2691         * python/py-framefilter.c: Use C++ exception handling.
2692         * python/py-frame.c: Use C++ exception handling.
2693         * python/py-finishbreakpoint.c: Use C++ exception handling.
2694         * python/py-cmd.c: Use C++ exception handling.
2695         * python/py-breakpoint.c: Use C++ exception handling.
2696         * python/py-arch.c: Use C++ exception handling.
2697         * printcmd.c: Use C++ exception handling.
2698         * ppc-linux-tdep.c: Use C++ exception handling.
2699         * parse.c: Use C++ exception handling.
2700         * p-valprint.c: Use C++ exception handling.
2701         * objc-lang.c: Use C++ exception handling.
2702         * mi/mi-main.c: Use C++ exception handling.
2703         * mi/mi-interp.c: Use C++ exception handling.
2704         * mi/mi-cmd-stack.c: Use C++ exception handling.
2705         * mi/mi-cmd-break.c: Use C++ exception handling.
2706         * main.c: Use C++ exception handling.
2707         * linux-thread-db.c: Use C++ exception handling.
2708         * linux-tdep.c: Use C++ exception handling.
2709         * linux-nat.c: Use C++ exception handling.
2710         * linux-fork.c: Use C++ exception handling.
2711         * linespec.c: Use C++ exception handling.
2712         * language.c: Use C++ exception handling.
2713         * jit.c: Use C++ exception handling.
2714         * infrun.c: Use C++ exception handling.
2715         * infcmd.c: Use C++ exception handling.
2716         * infcall.c: Use C++ exception handling.
2717         * inf-loop.c: Use C++ exception handling.
2718         * i386-tdep.c: Use C++ exception handling.
2719         * i386-linux-tdep.c: Use C++ exception handling.
2720         * guile/scm-value.c: Use C++ exception handling.
2721         * guile/scm-type.c: Use C++ exception handling.
2722         * guile/scm-symtab.c: Use C++ exception handling.
2723         * guile/scm-symbol.c: Use C++ exception handling.
2724         * guile/scm-pretty-print.c: Use C++ exception handling.
2725         * guile/scm-ports.c: Use C++ exception handling.
2726         * guile/scm-param.c: Use C++ exception handling.
2727         * guile/scm-math.c: Use C++ exception handling.
2728         * guile/scm-lazy-string.c: Use C++ exception handling.
2729         * guile/scm-frame.c: Use C++ exception handling.
2730         * guile/scm-disasm.c: Use C++ exception handling.
2731         * guile/scm-cmd.c: Use C++ exception handling.
2732         * guile/scm-breakpoint.c: Use C++ exception handling.
2733         * guile/scm-block.c: Use C++ exception handling.
2734         * guile/guile-internal.h: Use C++ exception handling.
2735         * gnu-v3-abi.c: Use C++ exception handling.
2736         * gdbtypes.c: Use C++ exception handling.
2737         * frame.c: Use C++ exception handling.
2738         * frame-unwind.c: Use C++ exception handling.
2739         * fbsd-tdep.c: Use C++ exception handling.
2740         * f-valprint.c: Use C++ exception handling.
2741         * exec.c: Use C++ exception handling.
2742         * event-top.c: Use C++ exception handling.
2743         * event-loop.c: Use C++ exception handling.
2744         * eval.c: Use C++ exception handling.
2745         * dwarf2read.c: Use C++ exception handling.
2746         * dwarf2loc.c: Use C++ exception handling.
2747         * dwarf2-frame.c: Use C++ exception handling.
2748         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2749         * dwarf-index-write.c: Use C++ exception handling.
2750         * dwarf-index-cache.c: Use C++ exception handling.
2751         * dtrace-probe.c: Use C++ exception handling.
2752         * disasm-selftests.c: Use C++ exception handling.
2753         * darwin-nat.c: Use C++ exception handling.
2754         * cp-valprint.c: Use C++ exception handling.
2755         * cp-support.c: Use C++ exception handling.
2756         * cp-abi.c: Use C++ exception handling.
2757         * corelow.c: Use C++ exception handling.
2758         * completer.c: Use C++ exception handling.
2759         * compile/compile-object-run.c: Use C++ exception handling.
2760         * compile/compile-object-load.c: Use C++ exception handling.
2761         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2762         * compile/compile-c-symbols.c: Use C++ exception handling.
2763         * common/selftest.c: Use C++ exception handling.
2764         * common/new-op.c: Use C++ exception handling.
2765         * cli/cli-script.c: Use C++ exception handling.
2766         * cli/cli-interp.c: Use C++ exception handling.
2767         * cli/cli-cmds.c: Use C++ exception handling.
2768         * c-varobj.c: Use C++ exception handling.
2769         * btrace.c: Use C++ exception handling.
2770         * breakpoint.c: Use C++ exception handling.
2771         * break-catch-throw.c: Use C++ exception handling.
2772         * arch-utils.c: Use C++ exception handling.
2773         * amd64-tdep.c: Use C++ exception handling.
2774         * ada-valprint.c: Use C++ exception handling.
2775         * ada-typeprint.c: Use C++ exception handling.
2776         * ada-lang.c: Use C++ exception handling.
2777         * aarch64-tdep.c: Use C++ exception handling.
2778
2779 2019-04-08  Tom Tromey  <tom@tromey.com>
2780
2781         * xml-support.c (gdb_xml_parser::parse): Update.
2782         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2783         * value.c (show_convenience): Update.
2784         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2785         (test_parse_flags_qcs): Update.
2786         * thread.c (thr_try_catch_cmd): Update.
2787         * target.c (target_translate_tls_address): Update.
2788         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2789         (info_frame_command_core, frame_apply_command_count): Update.
2790         * rust-exp.y (rust_lex_exception_test): Update.
2791         * riscv-tdep.c (riscv_print_one_register_info): Update.
2792         * remote.c (remote_target::enable_btrace): Update.
2793         * record-btrace.c (record_btrace_enable_warn): Update.
2794         * python/py-utils.c (gdbpy_convert_exception): Update.
2795         * printcmd.c (do_one_display, print_variable_and_value): Update.
2796         * mi/mi-main.c (mi_print_exception): Update.
2797         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2798         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2799         * linux-nat.c (linux_nat_target::attach): Update.
2800         * linux-fork.c (class scoped_switch_fork_info): Update.
2801         * infrun.c (displaced_step_prepare): Update.
2802         * infcall.c (call_function_by_hand_dummy): Update.
2803         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2804         * gnu-v3-abi.c (print_one_vtable): Update.
2805         * frame.c (get_prev_frame_always): Update.
2806         * f-valprint.c (info_common_command_for_block): Update.
2807         * exec.c (try_open_exec_file): Update.
2808         * exceptions.c (print_exception, exception_print)
2809         (exception_fprintf, exception_print_same): Update.
2810         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2811         * dwarf-index-cache.c (index_cache::store)
2812         (index_cache::lookup_gdb_index): Update.
2813         * darwin-nat.c (maybe_cache_shell): Update.
2814         * cp-valprint.c (cp_print_value_fields): Update.
2815         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2816         (gcc_cplus_symbol_address): Update.
2817         * compile/compile-c-symbols.c (gcc_convert_symbol)
2818         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2819         * common/selftest.c: Update.
2820         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2821         a std::string.
2822         (exception_try_scope_entry, exception_try_scope_exit): Don't
2823         declare.
2824         (struct exception_try_scope): Remove.
2825         (TRY): Don't use exception_try_scope.
2826         (struct gdb_exception): Add constructor, operator=.
2827         <what>: New method.
2828         (struct gdb_exception_RETURN_MASK_ALL)
2829         (struct gdb_exception_RETURN_MASK_ERROR)
2830         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2831         (struct gdb_quit_bad_alloc): Update.
2832         * common/common-exceptions.c (exception_none): Change
2833         initializer.
2834         (struct catcher) <state, exception>: Initialize inline.
2835         <prev>: Remove member.
2836         (current_catcher): Remove.
2837         (catchers): New global.
2838         (exceptions_state_mc_init): Simplify.
2839         (catcher_pop): Remove.
2840         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2841         (try_scope_depth, exception_try_scope_entry)
2842         (exception_try_scope_exit): Remove.
2843         (throw_exception_sjlj): Update.
2844         (exception_messages, exception_messages_size): Remove.
2845         (throw_it): Simplify.
2846         (gdb_exception_sliced_copy): Remove.
2847         (throw_exception_cxx): Update.
2848         * cli/cli-script.c (script_from_file): Update.
2849         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2850         Update.
2851         * ada-valprint.c (ada_val_print): Update.
2852         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2853         (create_excep_cond_exprs): Update.
2854
2855 2019-04-08  Tom Tromey  <tom@tromey.com>
2856
2857         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2858         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2859         (TRY, CATCH, END_CATCH): Remove some definitions.
2860         * common/common-exceptions.c: Don't use GDB_XCPT.
2861         (catcher_list_size): Remove.
2862         (throw_exception, throw_it): Simplify.
2863
2864 2019-04-05  Tom Tromey  <tom@tromey.com>
2865
2866         Revert the header-sorting patch.
2867         * ft32-tdep.c: Revert.
2868         * frv-tdep.c: Revert.
2869         * frv-linux-tdep.c: Revert.
2870         * frame.c: Revert.
2871         * frame-unwind.c: Revert.
2872         * frame-base.c: Revert.
2873         * fork-child.c: Revert.
2874         * findvar.c: Revert.
2875         * findcmd.c: Revert.
2876         * filesystem.c: Revert.
2877         * filename-seen-cache.h: Revert.
2878         * filename-seen-cache.c: Revert.
2879         * fbsd-tdep.c: Revert.
2880         * fbsd-nat.h: Revert.
2881         * fbsd-nat.c: Revert.
2882         * f-valprint.c: Revert.
2883         * f-typeprint.c: Revert.
2884         * f-lang.c: Revert.
2885         * extension.h: Revert.
2886         * extension.c: Revert.
2887         * extension-priv.h: Revert.
2888         * expprint.c: Revert.
2889         * exec.h: Revert.
2890         * exec.c: Revert.
2891         * exceptions.c: Revert.
2892         * event-top.c: Revert.
2893         * event-loop.c: Revert.
2894         * eval.c: Revert.
2895         * elfread.c: Revert.
2896         * dwarf2read.h: Revert.
2897         * dwarf2read.c: Revert.
2898         * dwarf2loc.c: Revert.
2899         * dwarf2expr.h: Revert.
2900         * dwarf2expr.c: Revert.
2901         * dwarf2-frame.c: Revert.
2902         * dwarf2-frame-tailcall.c: Revert.
2903         * dwarf-index-write.h: Revert.
2904         * dwarf-index-write.c: Revert.
2905         * dwarf-index-common.c: Revert.
2906         * dwarf-index-cache.h: Revert.
2907         * dwarf-index-cache.c: Revert.
2908         * dummy-frame.c: Revert.
2909         * dtrace-probe.c: Revert.
2910         * disasm.h: Revert.
2911         * disasm.c: Revert.
2912         * disasm-selftests.c: Revert.
2913         * dictionary.c: Revert.
2914         * dicos-tdep.c: Revert.
2915         * demangle.c: Revert.
2916         * dcache.h: Revert.
2917         * dcache.c: Revert.
2918         * darwin-nat.h: Revert.
2919         * darwin-nat.c: Revert.
2920         * darwin-nat-info.c: Revert.
2921         * d-valprint.c: Revert.
2922         * d-namespace.c: Revert.
2923         * d-lang.c: Revert.
2924         * ctf.c: Revert.
2925         * csky-tdep.c: Revert.
2926         * csky-linux-tdep.c: Revert.
2927         * cris-tdep.c: Revert.
2928         * cris-linux-tdep.c: Revert.
2929         * cp-valprint.c: Revert.
2930         * cp-support.c: Revert.
2931         * cp-namespace.c: Revert.
2932         * cp-abi.c: Revert.
2933         * corelow.c: Revert.
2934         * corefile.c: Revert.
2935         * continuations.c: Revert.
2936         * completer.h: Revert.
2937         * completer.c: Revert.
2938         * complaints.c: Revert.
2939         * coffread.c: Revert.
2940         * coff-pe-read.c: Revert.
2941         * cli-out.h: Revert.
2942         * cli-out.c: Revert.
2943         * charset.c: Revert.
2944         * c-varobj.c: Revert.
2945         * c-valprint.c: Revert.
2946         * c-typeprint.c: Revert.
2947         * c-lang.c: Revert.
2948         * buildsym.c: Revert.
2949         * buildsym-legacy.c: Revert.
2950         * build-id.h: Revert.
2951         * build-id.c: Revert.
2952         * btrace.c: Revert.
2953         * bsd-uthread.c: Revert.
2954         * breakpoint.h: Revert.
2955         * breakpoint.c: Revert.
2956         * break-catch-throw.c: Revert.
2957         * break-catch-syscall.c: Revert.
2958         * break-catch-sig.c: Revert.
2959         * blockframe.c: Revert.
2960         * block.c: Revert.
2961         * bfin-tdep.c: Revert.
2962         * bfin-linux-tdep.c: Revert.
2963         * bfd-target.c: Revert.
2964         * bcache.c: Revert.
2965         * ax-general.c: Revert.
2966         * ax-gdb.h: Revert.
2967         * ax-gdb.c: Revert.
2968         * avr-tdep.c: Revert.
2969         * auxv.c: Revert.
2970         * auto-load.c: Revert.
2971         * arm-wince-tdep.c: Revert.
2972         * arm-tdep.c: Revert.
2973         * arm-symbian-tdep.c: Revert.
2974         * arm-pikeos-tdep.c: Revert.
2975         * arm-obsd-tdep.c: Revert.
2976         * arm-nbsd-tdep.c: Revert.
2977         * arm-nbsd-nat.c: Revert.
2978         * arm-linux-tdep.c: Revert.
2979         * arm-linux-nat.c: Revert.
2980         * arm-fbsd-tdep.c: Revert.
2981         * arm-fbsd-nat.c: Revert.
2982         * arm-bsd-tdep.c: Revert.
2983         * arch-utils.c: Revert.
2984         * arc-tdep.c: Revert.
2985         * arc-newlib-tdep.c: Revert.
2986         * annotate.h: Revert.
2987         * annotate.c: Revert.
2988         * amd64-windows-tdep.c: Revert.
2989         * amd64-windows-nat.c: Revert.
2990         * amd64-tdep.c: Revert.
2991         * amd64-sol2-tdep.c: Revert.
2992         * amd64-obsd-tdep.c: Revert.
2993         * amd64-obsd-nat.c: Revert.
2994         * amd64-nbsd-tdep.c: Revert.
2995         * amd64-nbsd-nat.c: Revert.
2996         * amd64-nat.c: Revert.
2997         * amd64-linux-tdep.c: Revert.
2998         * amd64-linux-nat.c: Revert.
2999         * amd64-fbsd-tdep.c: Revert.
3000         * amd64-fbsd-nat.c: Revert.
3001         * amd64-dicos-tdep.c: Revert.
3002         * amd64-darwin-tdep.c: Revert.
3003         * amd64-bsd-nat.c: Revert.
3004         * alpha-tdep.c: Revert.
3005         * alpha-obsd-tdep.c: Revert.
3006         * alpha-nbsd-tdep.c: Revert.
3007         * alpha-mdebug-tdep.c: Revert.
3008         * alpha-linux-tdep.c: Revert.
3009         * alpha-linux-nat.c: Revert.
3010         * alpha-bsd-tdep.c: Revert.
3011         * alpha-bsd-nat.c: Revert.
3012         * aix-thread.c: Revert.
3013         * agent.c: Revert.
3014         * addrmap.c: Revert.
3015         * ada-varobj.c: Revert.
3016         * ada-valprint.c: Revert.
3017         * ada-typeprint.c: Revert.
3018         * ada-tasks.c: Revert.
3019         * ada-lang.c: Revert.
3020         * aarch64-tdep.c: Revert.
3021         * aarch64-ravenscar-thread.c: Revert.
3022         * aarch64-newlib-tdep.c: Revert.
3023         * aarch64-linux-tdep.c: Revert.
3024         * aarch64-linux-nat.c: Revert.
3025         * aarch64-fbsd-tdep.c: Revert.
3026         * aarch64-fbsd-nat.c: Revert.
3027         * aarch32-linux-nat.c: Revert.
3028
3029 2019-04-05  Tom Tromey  <tom@tromey.com>
3030
3031         * ft32-tdep.c: Sort headers.
3032         * frv-tdep.c: Sort headers.
3033         * frv-linux-tdep.c: Sort headers.
3034         * frame.c: Sort headers.
3035         * frame-unwind.c: Sort headers.
3036         * frame-base.c: Sort headers.
3037         * fork-child.c: Sort headers.
3038         * findvar.c: Sort headers.
3039         * findcmd.c: Sort headers.
3040         * filesystem.c: Sort headers.
3041         * filename-seen-cache.h: Sort headers.
3042         * filename-seen-cache.c: Sort headers.
3043         * fbsd-tdep.c: Sort headers.
3044         * fbsd-nat.h: Sort headers.
3045         * fbsd-nat.c: Sort headers.
3046         * f-valprint.c: Sort headers.
3047         * f-typeprint.c: Sort headers.
3048         * f-lang.c: Sort headers.
3049         * extension.h: Sort headers.
3050         * extension.c: Sort headers.
3051         * extension-priv.h: Sort headers.
3052         * expprint.c: Sort headers.
3053         * exec.h: Sort headers.
3054         * exec.c: Sort headers.
3055         * exceptions.c: Sort headers.
3056         * event-top.c: Sort headers.
3057         * event-loop.c: Sort headers.
3058         * eval.c: Sort headers.
3059         * elfread.c: Sort headers.
3060         * dwarf2read.h: Sort headers.
3061         * dwarf2read.c: Sort headers.
3062         * dwarf2loc.c: Sort headers.
3063         * dwarf2expr.h: Sort headers.
3064         * dwarf2expr.c: Sort headers.
3065         * dwarf2-frame.c: Sort headers.
3066         * dwarf2-frame-tailcall.c: Sort headers.
3067         * dwarf-index-write.h: Sort headers.
3068         * dwarf-index-write.c: Sort headers.
3069         * dwarf-index-common.c: Sort headers.
3070         * dwarf-index-cache.h: Sort headers.
3071         * dwarf-index-cache.c: Sort headers.
3072         * dummy-frame.c: Sort headers.
3073         * dtrace-probe.c: Sort headers.
3074         * disasm.h: Sort headers.
3075         * disasm.c: Sort headers.
3076         * disasm-selftests.c: Sort headers.
3077         * dictionary.c: Sort headers.
3078         * dicos-tdep.c: Sort headers.
3079         * demangle.c: Sort headers.
3080         * dcache.h: Sort headers.
3081         * dcache.c: Sort headers.
3082         * darwin-nat.h: Sort headers.
3083         * darwin-nat.c: Sort headers.
3084         * darwin-nat-info.c: Sort headers.
3085         * d-valprint.c: Sort headers.
3086         * d-namespace.c: Sort headers.
3087         * d-lang.c: Sort headers.
3088         * ctf.c: Sort headers.
3089         * csky-tdep.c: Sort headers.
3090         * csky-linux-tdep.c: Sort headers.
3091         * cris-tdep.c: Sort headers.
3092         * cris-linux-tdep.c: Sort headers.
3093         * cp-valprint.c: Sort headers.
3094         * cp-support.c: Sort headers.
3095         * cp-namespace.c: Sort headers.
3096         * cp-abi.c: Sort headers.
3097         * corelow.c: Sort headers.
3098         * corefile.c: Sort headers.
3099         * continuations.c: Sort headers.
3100         * completer.h: Sort headers.
3101         * completer.c: Sort headers.
3102         * complaints.c: Sort headers.
3103         * coffread.c: Sort headers.
3104         * coff-pe-read.c: Sort headers.
3105         * cli-out.h: Sort headers.
3106         * cli-out.c: Sort headers.
3107         * charset.c: Sort headers.
3108         * c-varobj.c: Sort headers.
3109         * c-valprint.c: Sort headers.
3110         * c-typeprint.c: Sort headers.
3111         * c-lang.c: Sort headers.
3112         * buildsym.c: Sort headers.
3113         * buildsym-legacy.c: Sort headers.
3114         * build-id.h: Sort headers.
3115         * build-id.c: Sort headers.
3116         * btrace.c: Sort headers.
3117         * bsd-uthread.c: Sort headers.
3118         * breakpoint.h: Sort headers.
3119         * breakpoint.c: Sort headers.
3120         * break-catch-throw.c: Sort headers.
3121         * break-catch-syscall.c: Sort headers.
3122         * break-catch-sig.c: Sort headers.
3123         * blockframe.c: Sort headers.
3124         * block.c: Sort headers.
3125         * bfin-tdep.c: Sort headers.
3126         * bfin-linux-tdep.c: Sort headers.
3127         * bfd-target.c: Sort headers.
3128         * bcache.c: Sort headers.
3129         * ax-general.c: Sort headers.
3130         * ax-gdb.h: Sort headers.
3131         * ax-gdb.c: Sort headers.
3132         * avr-tdep.c: Sort headers.
3133         * auxv.c: Sort headers.
3134         * auto-load.c: Sort headers.
3135         * arm-wince-tdep.c: Sort headers.
3136         * arm-tdep.c: Sort headers.
3137         * arm-symbian-tdep.c: Sort headers.
3138         * arm-pikeos-tdep.c: Sort headers.
3139         * arm-obsd-tdep.c: Sort headers.
3140         * arm-nbsd-tdep.c: Sort headers.
3141         * arm-nbsd-nat.c: Sort headers.
3142         * arm-linux-tdep.c: Sort headers.
3143         * arm-linux-nat.c: Sort headers.
3144         * arm-fbsd-tdep.c: Sort headers.
3145         * arm-fbsd-nat.c: Sort headers.
3146         * arm-bsd-tdep.c: Sort headers.
3147         * arch-utils.c: Sort headers.
3148         * arc-tdep.c: Sort headers.
3149         * arc-newlib-tdep.c: Sort headers.
3150         * annotate.h: Sort headers.
3151         * annotate.c: Sort headers.
3152         * amd64-windows-tdep.c: Sort headers.
3153         * amd64-windows-nat.c: Sort headers.
3154         * amd64-tdep.c: Sort headers.
3155         * amd64-sol2-tdep.c: Sort headers.
3156         * amd64-obsd-tdep.c: Sort headers.
3157         * amd64-obsd-nat.c: Sort headers.
3158         * amd64-nbsd-tdep.c: Sort headers.
3159         * amd64-nbsd-nat.c: Sort headers.
3160         * amd64-nat.c: Sort headers.
3161         * amd64-linux-tdep.c: Sort headers.
3162         * amd64-linux-nat.c: Sort headers.
3163         * amd64-fbsd-tdep.c: Sort headers.
3164         * amd64-fbsd-nat.c: Sort headers.
3165         * amd64-dicos-tdep.c: Sort headers.
3166         * amd64-darwin-tdep.c: Sort headers.
3167         * amd64-bsd-nat.c: Sort headers.
3168         * alpha-tdep.c: Sort headers.
3169         * alpha-obsd-tdep.c: Sort headers.
3170         * alpha-nbsd-tdep.c: Sort headers.
3171         * alpha-mdebug-tdep.c: Sort headers.
3172         * alpha-linux-tdep.c: Sort headers.
3173         * alpha-linux-nat.c: Sort headers.
3174         * alpha-bsd-tdep.c: Sort headers.
3175         * alpha-bsd-nat.c: Sort headers.
3176         * aix-thread.c: Sort headers.
3177         * agent.c: Sort headers.
3178         * addrmap.c: Sort headers.
3179         * ada-varobj.c: Sort headers.
3180         * ada-valprint.c: Sort headers.
3181         * ada-typeprint.c: Sort headers.
3182         * ada-tasks.c: Sort headers.
3183         * ada-lang.c: Sort headers.
3184         * aarch64-tdep.c: Sort headers.
3185         * aarch64-ravenscar-thread.c: Sort headers.
3186         * aarch64-newlib-tdep.c: Sort headers.
3187         * aarch64-linux-tdep.c: Sort headers.
3188         * aarch64-linux-nat.c: Sort headers.
3189         * aarch64-fbsd-tdep.c: Sort headers.
3190         * aarch64-fbsd-nat.c: Sort headers.
3191         * aarch32-linux-nat.c: Sort headers.
3192
3193 2019-04-04  Tom Tromey  <tom@tromey.com>
3194
3195         * varobj.c (varobj_create): Update.
3196         * rust-exp.y (struct rust_parser) <update_innermost_block,
3197         lookup_symbol>: New methods.
3198         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3199         Rename.
3200         (rust_parser::rust_lookup_type)
3201         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3202         * printcmd.c (display_command, do_one_display): Update.
3203         * parser-defs.h (struct parser_state) <parser_state>: Add
3204         "tracker" parameter.
3205         (block_tracker): New member.
3206         (class innermost_block_tracker) <innermost_block_tracker>: Add
3207         "types" parameter.
3208         <reset>: Remove method.
3209         (innermost_block): Don't declare.
3210         (null_post_parser): Update.
3211         * parse.c (innermost_block): Remove global.
3212         (write_dollar_variable): Update.
3213         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3214         Remove "tracker_types" parameter.
3215         (parse_expression): Add "tracker" parameter.
3216         (parse_expression_for_completion): Update.
3217         (null_post_parser): Add "tracker" parameter.
3218         * p-exp.y: Update rules.
3219         * m2-exp.y: Update rules.
3220         * language.h (struct language_defn) <la_post_parser>: Add
3221         "tracker" parameter.
3222         * go-exp.y: Update rules.
3223         * f-exp.y: Update rules.
3224         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3225         parameter.
3226         * d-exp.y: Update rules.
3227         * c-exp.y: Update rules.
3228         * breakpoint.c (set_breakpoint_condition): Create an
3229         innermost_block_tracker.
3230         (watch_command_1): Likewise.
3231         * ada-lang.c (resolve): Add "tracker" parameter.
3232         (resolve_subexp): Likewise.
3233         * ada-exp.y (write_var_from_sym): Update.
3234
3235 2019-04-04  Tom Tromey  <tom@tromey.com>
3236
3237         * type-stack.h: New file.
3238         * type-stack.c: New file.
3239         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3240         type-stack.h.
3241         (insert_into_type_stack, insert_type, push_type, push_type_int)
3242         (insert_type_address_space, pop_type, pop_type_int)
3243         (pop_typelist, pop_type_stack, append_type_stack)
3244         (push_type_stack, get_type_stack, push_typelist)
3245         (follow_type_instance_flags, follow_types): Don't declare.
3246         * parse.c (type_stack): Remove global.
3247         (parse_exp_in_context): Update.
3248         (insert_into_type_stack, insert_type, push_type, push_type_int)
3249         (insert_type_address_space, pop_type, pop_type_int)
3250         (pop_typelist, pop_type_stack, append_type_stack)
3251         (push_type_stack, get_type_stack, push_typelist)
3252         (follow_type_instance_flags, follow_types): Remove (moved to
3253         type-stack.c).
3254         * f-exp.y (type_stack): New global.
3255         Update rules.
3256         (push_kind_type, f_parse): Update.
3257         * d-exp.y (type_stack): New global.
3258         Update rules.
3259         (d_parse): Update.
3260         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3261         Update rules.
3262         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3263         (HFILES_NO_SRCDIR): Add type-stack.h.
3264
3265 2019-04-04  Tom Tromey  <tom@tromey.com>
3266
3267         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3268         (rust_parser::convert_ast_to_expression, rust_parse)
3269         (rust_lex_test_completion, rust_lex_tests): Update.
3270         * parser-defs.h (struct expr_completion_state): New.
3271         (struct parser_state) <parser_state>: Add completion parameter.
3272         <mark_struct_expression, mark_completion_tag>: New methods.
3273         <parse_completion, m_completion_state>: New members.
3274         (prefixify_expression, null_post_parser): Update.
3275         (mark_struct_expression, mark_completion_tag): Don't declare.
3276         * parse.c (parse_completion, expout_last_struct)
3277         (expout_tag_completion_type, expout_completion_name): Remove
3278         globals.
3279         (parser_state::mark_struct_expression)
3280         (parser_state::mark_completion_tag): Now methods.
3281         (prefixify_expression): Add last_struct parameter.
3282         (prefixify_subexp): Likewise.
3283         (parse_exp_1): Update.
3284         (parse_exp_in_context): Add cstate parameter.  Update.
3285         (parse_expression_for_completion): Create an
3286         expr_completion_state.
3287         (null_post_parser): Add "completion" parameter.
3288         * p-exp.y: Update rules.
3289         (yylex): Update.
3290         * language.h (struct language_defn) <la_post_parser>: Add
3291         "completing" parameter.
3292         * go-exp.y: Update rules.
3293         (lex_one_token): Update.
3294         * expression.h (parse_completion): Don't declare.
3295         * d-exp.y: Update rules.
3296         (lex_one_token): Update rules.
3297         * c-exp.y: Update rules.
3298         (lex_one_token): Update.
3299         * ada-lang.c (resolve): Add "parse_completion" parameter.
3300         (resolve_subexp): Likewise.
3301         (ada_resolve_function): Likewise.
3302
3303 2019-04-04  Tom Tromey  <tom@tromey.com>
3304
3305         * parser-defs.h (struct parser_state) <start_arglist,
3306         end_arglist>: New methods.
3307         <arglist_len, m_funcall_chain>: New members.
3308         (arglist_len, start_arglist, end_arglist): Don't declare.
3309         * parse.c (arglist_len, funcall_chain): Remove global.
3310         (start_arglist, end_arglist): Remove functions.
3311         (parse_exp_in_context): Update.
3312         * p-exp.y: Update rules.
3313         * m2-exp.y: Update rules.
3314         * go-exp.y: Update rules.
3315         * f-exp.y: Update rules.
3316         * d-exp.y: Update rules.
3317         * c-exp.y: Update rules.
3318
3319 2019-04-04  Tom Tromey  <tom@tromey.com>
3320
3321         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3322         lex_operator, push_back>: New methods.
3323         Update all rules.
3324         (rust_parser::lex_hex, lex_escape): Rename and update.
3325         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3326         (rust_parser::lex_operator): Rename and update.
3327         (rust_parser::lex_number, rustyylex, rustyyerror)
3328         (rust_lex_test_init, rust_lex_test_sequence)
3329         (rust_lex_test_push_back, rust_lex_tests): Update.
3330         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3331         parameter.
3332         <lexptr, prev_lexptr>: New members.
3333         (lexptr, prev_lexptr): Don't declare.
3334         * parse.c (lexptr, prev_lexptr): Remove globals.
3335         (parse_exp_in_context): Update.
3336         * p-exp.y (yylex, yyerror): Update.
3337         * m2-exp.y (parse_number, yylex, yyerror): Update.
3338         * go-exp.y (lex_one_token, yyerror): Update.
3339         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3340         * d-exp.y (lex_one_token, yyerror): Update.
3341         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3342         (lex_one_token, yyerror): Update.
3343         * ada-lex.l (YY_INPUT): Update.
3344         (rewind_to_char): Update.
3345         * ada-exp.y (yyerror): Update.
3346
3347 2019-04-04  Tom Tromey  <tom@tromey.com>
3348
3349         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3350         * parser-defs.h (struct parser_state) <parser_state>: Add new
3351         parameter.
3352         <comma_terminates>: New member.
3353         (comma_terminates): Don't declare global.
3354         * parse.c (comma_terminates): Remove global.
3355         (parse_exp_in_context): Update.
3356         * p-exp.y (yylex): Update.
3357         * m2-exp.y (yylex): Update.
3358         * go-exp.y (lex_one_token): Update.
3359         * f-exp.y (yylex): Update.
3360         * d-exp.y (lex_one_token): Update.
3361         * c-exp.y (lex_one_token): Update.
3362         * ada-lex.l: Update.
3363
3364 2019-04-04  Tom Tromey  <tom@tromey.com>
3365
3366         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3367         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3368         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3369         * parser-defs.h (paren_depth): Don't declare.
3370         * parse.c (paren_depth): Remove global.
3371         (parse_exp_in_context): Update.
3372         * p-exp.y (paren_depth): New global.
3373         (pascal_parse): Initialize it.
3374         * m2-exp.y (paren_depth): New global.
3375         (m2_parse): Initialize it.
3376         * go-exp.y (paren_depth): New global.
3377         (go_parse): Initialize it.
3378         * f-exp.y (paren_depth): New global.
3379         (f_parse): Initialize it.
3380         * d-exp.y (paren_depth): New global.
3381         (d_parse): Initialize it.
3382         * c-exp.y (paren_depth): New global.
3383         (c_parse): Initialize it.
3384         * ada-lex.l (paren_depth): New global.
3385         (lexer_init): Initialize it.
3386
3387 2019-04-04  Tom Tromey  <tom@tromey.com>
3388
3389         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3390         (rust_parser::convert_ast_to_type)
3391         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3392         * parser-defs.h (struct parser_state) <parser_state>: Add
3393         parameters.  Initialize new members.
3394         <expression_context_block, expression_context_pc>: New members.
3395         * parse.c (expression_context_block, expression_context_pc):
3396         Remove globals.
3397         (parse_exp_in_context): Update.
3398         * p-exp.y: Update all rules.
3399         (yylex): Update.
3400         * m2-exp.y: Update all rules.
3401         (yylex): Update.
3402         * go-exp.y (yylex): Update.
3403         * f-exp.y (yylex): Update.
3404         * d-exp.y: Update all rules.
3405         (yylex): Update.
3406         * c-exp.y: Update all rules.
3407         (lex_one_token, classify_name, yylex, c_parse): Update.
3408         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3409
3410 2019-04-04  Tom Tromey  <tom@tromey.com>
3411
3412         * gdbarch.h, gdbarch.c: Rebuild.
3413         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3414         * stap-probe.h:
3415         (struct stap_parse_info): Replace "parser_state" with
3416         "expr_builder".
3417         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3418         (parser_state): New class.
3419         * parse.c (expr_builder): Rename.
3420         (expr_builder::release): Rename.
3421         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3422         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3423         (write_exp_elt_longcst, write_exp_elt_floatcst)
3424         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3425         (write_exp_string_vector, write_exp_bitstring)
3426         (write_exp_msymbol, mark_struct_expression)
3427         (write_dollar_variable)
3428         (insert_type_address_space, increase_expout_size): Replace
3429         "parser_state" with "expr_builder".
3430         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3431         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3432         "parser_state" with "expr_builder".
3433
3434 2019-04-04  Tom Tromey  <tom@tromey.com>
3435
3436         * rust-exp.y: Replace "parse_language" with method call.
3437         * p-exp.y:
3438         (yylex): Replace "parse_language" with method call.
3439         * m2-exp.y:
3440         (yylex): Replace "parse_language" with method call.
3441         * go-exp.y (classify_name): Replace "parse_language" with method
3442         call.
3443         * f-exp.y (yylex): Replace "parse_language" with method call.
3444         * d-exp.y (lex_one_token): Replace "parse_language" with method
3445         call.
3446         * c-exp.y:
3447         (lex_one_token, classify_name, yylex): Replace "parse_language"
3448         with method call.
3449         * ada-exp.y (find_primitive_type, type_char)
3450         (type_system_address): Replace "parse_language" with method call.
3451
3452 2019-04-04  Tom Tromey  <tom@tromey.com>
3453
3454         * rust-exp.y: Replace "parse_gdbarch" with method call.
3455         * parse.c (write_dollar_variable, insert_type_address_space):
3456         Replace "parse_gdbarch" with method call.
3457         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3458         call.
3459         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3460         call.
3461         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3462         "parse_gdbarch" with method call.
3463         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3464         with method call.
3465         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3466         "parse_gdbarch" with method call.
3467         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3468         "parse_gdbarch" with method call.
3469         * c-exp.y (parse_type, parse_number, classify_name): Replace
3470         "parse_gdbarch" with method call.
3471         * ada-lex.l: Replace "parse_gdbarch" with method call.
3472         * ada-exp.y (parse_type, find_primitive_type, type_char)
3473         (type_system_address): Replace "parse_gdbarch" with method call.
3474
3475 2019-04-04  Tom Tromey  <tom@tromey.com>
3476
3477         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3478         * stap-probe.c (stap_parse_argument): Update.
3479         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3480         initial_size parameter.
3481         * rust-exp.y (rust_lex_tests): Update.
3482         * parse.c (parser_state): Update.
3483         (parse_exp_in_context): Update.
3484         * parser-defs.h (struct parser_state) <parser_state>: Remove
3485         "initial_size" parameter.
3486
3487 2019-04-04  Tom Tromey  <tom@tromey.com>
3488
3489         * parser-defs.h (increase_expout_size): Don't declare.
3490         * parse.c (increase_expout_size): Now static.
3491
3492 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3493
3494         * gnu-nat.c (gnu_nat_target::wait): Fix
3495         target_waitstatus_to_string call.
3496
3497 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3498
3499         * eval.c (evaluate_subexp_standard): Handle internal functions
3500         during Fortran function call handling.
3501
3502 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3503
3504         * NEWS: Mention new internal functions.
3505         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3506         (read_base_type): Use dwarf2_init_complex_target_type.
3507         * value.c (creal_internal_fn): New function.
3508         (cimag_internal_fn): New function.
3509         (_initialize_values): Register new internal functions.
3510
3511 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3512
3513         * infrun.c (stop_all_threads): If debug_infrun, always
3514         trace the wait status after wait_one, using
3515         target_waitstatus_to_string and target_pid_to_str.
3516         (handle_inferior_event): Replace various trace of
3517         wait status kind by a single trace.
3518         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3519         wait status kind image by target_waitstatus_to_string.
3520         * target/waitstatus.c (target_waitstatus_to_string): Fix
3521         obsolete comment.
3522
3523 2019-04-01  Tom Tromey  <tromey@adacore.com>
3524
3525         PR symtab/23331:
3526         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3527
3528 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3529             Pedro Alves  <palves@redhat.com>
3530
3531         * top.c (quit_force): Call 'finalize_values'.
3532         * value.c (finalize_values): New function.
3533         * value.h (finalize_values): Declare.
3534
3535 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3536
3537         * NEWS: Announce $_gdb_major and $_gdb_minor.
3538
3539         * top.c (init_gdb_version_vars): New function.
3540         (gdb_init): Call init_gdb_version_vars.
3541
3542 2019-03-29  Tom Tromey  <tromey@adacore.com>
3543
3544         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3545         help text.  Remove dead code.
3546
3547 2019-03-29  Keith Seitz  <keiths@redhat.com>
3548
3549         From Siddhesh Poyarekar:
3550         * f-lang.h (f77_get_upperbound): Return LONGEST.
3551         (f77_get_lowerbound): Likewise.
3552         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3553         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3554         print them.
3555         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3556         plongest to format print it.
3557         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3558         (f77_get_upperbound): Likewise.
3559         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3560         LOWER_BOUND to LONGEST.
3561         (f77_create_arrayprint_offset_tbl): Likewise.
3562
3563 2019-03-29  Keith Seitz  <keiths@redhat.com>
3564
3565         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3566         %s/pulongest for TYPE_LENGTH instead of %d in format
3567         strings.
3568         * ada-typerint.c (ada_print_type): Likewise.
3569         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3570         * compile/compile-c-support.c (generate_register_struct): Likewise.
3571         * gdbtypes.c (recursive_dump_type): Likewise.
3572         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3573         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3574         instead of %d in format strings.
3575         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3576         to std::min to ULONGEST.
3577         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3578         instead of %d in format strings.
3579         * tracepoint.c (info_scope_command): Likewise.
3580         * typeprint.c (print_offset_data::update)
3581         (print_offset_data::finish): Likewise.
3582         * xtensa-tdep.c (xtensa_store_return_value)
3583         (xtensa_push_dummy_call): Likewise.
3584
3585 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3586
3587         * windows-nat.c (display_selector): Fixed format specifications
3588         for 64-bit Cygwin.
3589
3590 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3591
3592         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3593
3594 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3595
3596         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3597         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3598         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3599         (nios2_linux_init_abi): Install it.
3600
3601 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3602
3603         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3604
3605 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3606
3607         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3608
3609 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3610             Tom Tromey  <tromey@adacore.com>
3611
3612         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3613
3614 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3615
3616         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3617         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3618         method to compute the bounds of range types. Also print "[evaluated]"
3619         if the bounds' values come from a dynamic evaluation.
3620
3621 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3622
3623         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3624         whitespace when pretty printing is on.
3625
3626 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3627
3628         * ppc-linux-nat.c: Add include.
3629
3630 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3631
3632         * NEWS: Mention AArch64 Pointer Authentication.
3633
3634 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3635
3636         * arm-linux-nat.c: Add include.
3637
3638 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3639
3640         * source-cache.c (source_cache::get_source_lines): Re-read
3641         fullname after calling open_source_file.
3642
3643 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3644
3645         * NEWS: Mention TLS support for FreeBSD.
3646
3647 2019-03-25  Tom Tromey  <tromey@adacore.com>
3648
3649         * minsyms.c (BUNCH_SIZE): Update comment.
3650         (~minimal_symbol_reader): Remove old comment.
3651         (compact_minimal_symbols): Update comment.
3652         (minimal_symbol_reader::install): Remove old comment.  Update
3653         other comments.
3654
3655 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3656
3657         * s390-linux-nat.c: Add include.
3658
3659 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3660
3661         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3662         Call linux_get_hwcap.
3663         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3664         Likewise.
3665         (aarch64_linux_get_hwcap): Remove function.
3666         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3667         declaration.
3668         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3669         linux_get_hwcap.
3670         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3671         * linux-tdep.c (linux_get_hwcap): Add function.
3672         (linux_get_hwcap2): Likewise.
3673         * linux-tdep.h (linux_get_hwcap): Add declaration.
3674         (linux_get_hwcap2): Likewise.
3675         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3676         (ppc_linux_get_hwcap2): Likewise.
3677         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3678         linux_get_hwcap.
3679         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3680         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3681         (ppc_linux_nat_target::read_description): Likewise.
3682         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3683         * s390-linux-nat.c: Likewise.
3684         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3685
3686 2019-03-24  Tom Tromey  <tom@tromey.com>
3687
3688         * ada-lang.c (standard_lookup): Simplify initialization.
3689         (ada_lookup_symbol_nonlocal): Simplify return.
3690         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3691         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3692         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3693         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3694         initialization.
3695         * solib.c (solib_global_lookup): Simplify.
3696         * symtab.c (null_block_symbol): Remove.
3697         (symbol_cache_lookup): Simplify returns.
3698         (lookup_language_this): Simplify returns.
3699         (lookup_symbol_aux): Simplify return.
3700         (lookup_local_symbol): Simplify returns.
3701         (lookup_global_symbol_from_objfile): Simplify return.
3702         (lookup_symbol_in_objfile_symtabs)
3703         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3704         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3705         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3706         * cp-namespace.c (cp_lookup_bare_symbol)
3707         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3708         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3709         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3710         (cp_lookup_symbol_via_imports): Simplify initialization.
3711         (find_symbol_in_baseclass): Likewise.
3712         * symtab.h (null_block_symbol): Remove.
3713         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3714         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3715         (d_lookup_symbol_module): Likewise.
3716         (find_symbol_in_baseclass): Simplify initialization.
3717
3718 2019-03-24  Tom Tromey  <tom@tromey.com>
3719
3720         * expression.h: Don't include symtab.h.
3721         (struct block): Forward declare.
3722
3723 2019-03-24  Tom Tromey  <tom@tromey.com>
3724
3725         * c-exp.y (typebase): Remove casts.
3726         * gdbtypes.c (lookup_unsigned_typename, )
3727         (lookup_signed_typename): Remove cast.
3728         * eval.c (parse_to_comma_and_eval): Remove cast.
3729         * parse.c (write_dollar_variable): Remove cast.
3730         * block.h (struct block) <superblock>: Now const.
3731         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3732         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3733         (map_block): Make "block" const.
3734         * symfile.h (struct quick_symbol_functions)
3735         <map_matching_symbols>: Constify block argument to "callback".
3736         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3737         const.
3738         (find_pc_sect_compunit_symtab): Make "b" const.
3739         (find_symbol_at_address): Likewise.
3740         (search_symbols): Likewise.
3741         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3742         (dw2_debug_names_lookup_symbol): Likewise.
3743         (dw2_map_matching_symbols): Update.
3744         * p-valprint.c (pascal_val_print): Remove "block".
3745         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3746         (aux_add_nonlocal_symbols): Make "block" const.
3747         (resolve_subexp): Remove cast.
3748         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3749         const.
3750         (iterate_over_file_blocks): Likewise.
3751         * f-exp.y (%union) <bval>: Remove.
3752         * coffread.c (patch_opaque_types): Make "b" const.
3753         * spu-tdep.c (spu_catch_start): Make "block" const.
3754         * c-valprint.c (print_unpacked_pointer): Remove "block".
3755         * symmisc.c (dump_symtab_1): Make "b" const.
3756         (block_depth): Make "block" const.
3757         * d-exp.y (%union) <bval>: Remove.
3758         * cp-support.h (cp_lookup_rtti_type): Update.
3759         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3760         * psymtab.c (psym_lookup_symbol): Make "block" const.
3761         (maintenance_check_psymtabs): Make "b" const.
3762         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3763         (enumerate_locals, enumerate_args): Update.
3764         * python/py-symtab.c (stpy_global_block): Make "block" const.
3765         (stpy_static_block): Likewise.
3766         * inline-frame.c (block_starting_point_at): Make "new_block"
3767         const.
3768         * block.c (find_block_in_blockvector): Make return type const.
3769         (blockvector_for_pc_sect): Make "b" const.
3770         (find_block_in_blockvector): Make "b" const.
3771
3772 2019-03-23  Tom Tromey  <tom@tromey.com>
3773
3774         * varobj.c (varobj_create): Update.
3775         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3776         * printcmd.c (display_command, do_one_display): Don't reset
3777         innermost_block.
3778         * parser-defs.h (enum innermost_block_tracker_type): Move to
3779         expression.h.
3780         (innermost_block): Update comment.
3781         * parse.c (parse_exp_1): Add tracker_types parameter.
3782         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3783         tracker_types parameter.  Reset innermost_block.
3784         (parse_exp_in_context): Remove.
3785         (parse_expression_for_completion): Update.
3786         * objfiles.c (~objfile): Don't reset expression_context_block or
3787         innermost_block.
3788         * expression.h (enum innermost_block_tracker_type): Move from
3789         parser-defs.h.
3790         (parse_exp_1): Add tracker_types parameter.
3791         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3792         reset innermost_block.
3793
3794 2019-03-23  Tom Tromey  <tom@tromey.com>
3795
3796         * objfiles.h: Include bcache.h.
3797
3798 2019-03-23  Tom Tromey  <tom@tromey.com>
3799
3800         * linespec.c (get_current_search_block): Use
3801         scoped_restore_current_language.
3802         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3803
3804 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3805             Jiong Wang  <jiong.wang@arm.com>
3806
3807         * aarch64-linux-tdep.c
3808         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3809         section.
3810         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3811
3812 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3813             Jiong Wang  <jiong.wang@arm.com>
3814
3815         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3816         instructions.
3817         (aarch64_analyze_prologue_test): Add PACIASP test.
3818         (aarch64_prologue_prev_register): Unmask PC value.
3819
3820 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3821             Jiong Wang  <jiong.wang@arm.com>
3822
3823         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3824         (aarch64_dwarf2_prev_register): Unmask PC value.
3825         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3826         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3827         DW_CFA_AARCH64_negate_ra_state.
3828         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3829
3830 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3831             Jiong Wang  <jiong.wang@arm.com>
3832
3833         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3834         registers.
3835         (aarch64_pseudo_register_name): Likewise.
3836         (aarch64_pseudo_register_type): Likewise.
3837         (aarch64_pseudo_register_reggroup_p): Likewise.
3838         (aarch64_gdbarch_init): Add pauth registers.
3839         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3840         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3841         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3842         (struct gdbarch_tdep): Add regnum for ra_state.
3843
3844 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3845             Jiong Wang  <jiong.wang@arm.com>
3846
3847         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3848
3849 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3850             Jiong Wang  <jiong.wang@arm.com>
3851
3852         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3853         function.
3854         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3855         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3856         (aarch64_gdbarch_init): Add puth registers.
3857         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3858         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3859         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3860
3861 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3862             Jiong Wang  <jiong.wang@arm.com>
3863
3864         * aarch64-linux-nat.c
3865         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3866         * aarch64-linux-tdep.c
3867         (aarch64_linux_core_read_description): Likewise.
3868         (aarch64_linux_get_hwcap): New function.
3869         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3870         (aarch64_linux_get_hwcap): New declaration.
3871
3872 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3873             Jiong Wang  <jiong.wang@arm.com>
3874
3875         * aarch64-linux-nat.c
3876         (aarch64_linux_nat_target::read_description): Add pauth param.
3877         * aarch64-linux-tdep.c
3878         (aarch64_linux_core_read_description): Likewise.
3879         * aarch64-tdep.c (struct target_desc): Add in pauth.
3880         (aarch64_read_description): Add pauth param.
3881         (aarch64_gdbarch_init): Likewise.
3882         * aarch64-tdep.h (aarch64_read_description): Likewise.
3883         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3884         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3885         * features/Makefile: Add new files.
3886         * features/aarch64-pauth.c: New file.
3887         * features/aarch64-pauth.xml: New file.
3888
3889 2019-03-20  Tom Tromey  <tromey@adacore.com>
3890
3891         * infrun.c (handle_inferior_event): Rename from
3892         handle_inferior_event_1.  Create a scoped_value_mark.
3893         (handle_inferior_event): Remove.
3894
3895 2019-03-19  Tom Tromey  <tromey@adacore.com>
3896
3897         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3898         * infrun.h (print_stop_event): Add "displays" parameter.
3899         * infrun.c (print_stop_event): Add "displays" parameter.
3900
3901 2019-03-19  Pedro Alves  <palves@redhat.com>
3902
3903         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3904         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3905         to -1.  Fix TABs vs spaces.
3906         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3907         * tui/tui-out.h (tui_ui_out) Add intro comments.
3908         <m_line, m_start_of_line>: In-class initialize, and add describing
3909         comment.
3910
3911 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3912
3913         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3914         variable names.
3915         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3916
3917 2019-03-18  Pedro Alves  <palves@redhat.com>
3918             Eli Zaretskii <eliz@gnu.org>
3919
3920         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3921         m_line and m_start_of_line.
3922
3923 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3924
3925         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3926         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3927         it returns a newline.  This fixes a regression in TU mode, whereby
3928         the next line is output on the same screen line as the user input.
3929
3930 2019-03-18  Tom Tromey  <tromey@adacore.com>
3931
3932         * minsyms.c (minimal_symbol_reader::install): Remove call to
3933         obstack_blank.
3934
3935 2019-03-18  Pedro Alves  <palves@redhat.com>
3936
3937         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3938         New globals.
3939         (apply_style): New, factored out from ...
3940         (apply_ansi_escape): ... this.  Handle reverse video mode.
3941         (tui_set_reverse_mode): New function.
3942         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3943         * tui/tui-winsource.c (tui_show_source_line): Use
3944         tui_set_reverse_mode instead of setting A_STANDOUT.
3945         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3946         New setter methods.
3947
3948 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3949
3950         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3951         Handle tabs.
3952
3953 2019-03-18  Tom Tromey  <tromey@adacore.com>
3954
3955         * ada-lang.c (empty_array): Add "high" parameter.
3956         (ada_evaluate_subexp): Update.
3957
3958 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3959
3960         * unittests/string_view-selftests.c: Define
3961         _initialize_string_view_selftests unconditionally.
3962
3963 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3964
3965         PR gdb/24350
3966         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3967
3968 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3969
3970         PR gdb/24351
3971         * windows-nat.c (display_selector): Fix format specifiers.
3972
3973 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3974
3975         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3976         tui_refill_source_window instead of tui_refresh_win, to update the
3977         current execution line.  This fixes redisplay of the current line
3978         when stepping through the code with "next" or "step".
3979
3980 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3981
3982         * source-cache.c (source_cache::get_source_lines): Call
3983         find_source_lines to initialize s->nlines.  This fixes vertical
3984         scrolling of TUI source window when the DOWN arrow is pressed.
3985
3986 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3987
3988         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3989         linux-thread-db.c (_initialize_thread_db): Likewise.
3990
3991 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3992
3993         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3994         wclrtoeol in tui_show_source_line".  This reverts changes made in
3995         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3996
3997 2019-03-15  Tom Tromey  <tom@tromey.com>
3998
3999         * symtab.h (struct minimal_symbol): Derive from
4000         general_symbol_info.
4001         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4002         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4003         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4004         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4005         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4006         (MSYMBOL_SEARCH_NAME): Update.
4007         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4008         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4009         * minsyms.c (minimal_symbol_reader::record_full): Update.
4010
4011 2019-03-15  Tom Tromey  <tom@tromey.com>
4012
4013         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4014
4015 2019-03-15  Tom Tromey  <tom@tromey.com>
4016
4017         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4018         unique_xmalloc_ptr.
4019         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4020         Update.
4021         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4022         (build_minimal_symbol_hash_tables)
4023         (minimal_symbol_reader::install): Update.
4024
4025 2019-03-15  Tom Tromey  <tom@tromey.com>
4026
4027         * symtab.c (create_demangled_names_hash): Update.
4028         (symbol_set_names): Update.
4029         * objfiles.h (struct objfile_per_bfd_storage)
4030         <demangled_names_hash>: Now an htab_up.
4031         * objfiles.c (objfile_per_bfd_storage): Simplify.
4032
4033 2019-03-15  Tom Tromey  <tom@tromey.com>
4034
4035         * objfiles.h (struct objfile_per_bfd_storage): Declare
4036         destructor.
4037         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4038         New.
4039         (get_objfile_bfd_data): Use new.  Don't initialize
4040         language_of_main.
4041         (free_objfile_per_bfd_storage): Remove.
4042         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4043
4044 2019-03-15  Tom Tromey  <tom@tromey.com>
4045
4046         * symfile.c (reread_symbols): Update.
4047         * objfiles.c (objfile::objfile): Update.
4048         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4049         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4050         comment.
4051         (minimal_symbol_reader::install): Update.
4052         (terminate_minimal_symbol_table): Remove.
4053         * jit.c (jit_object_close_impl): Update.
4054
4055 2019-03-15  Tom Tromey  <tom@tromey.com>
4056
4057         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4058         initializations.
4059
4060 2019-03-15  Tom Tromey  <tom@tromey.com>
4061
4062         * objfiles.h (struct objfile_per_bfd_storage)
4063         <demangled_hash_languages>: Now a bitset.
4064         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4065         (lookup_minimal_symbol): Update.
4066
4067 2019-03-15  Tom Tromey  <tom@tromey.com>
4068
4069         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4070         Don't return the symbol.
4071         * coffread.c (record_minimal_symbol): Use record_full.
4072
4073 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4074
4075         The MS-Windows port of ncurses fails to switch to a color pair if
4076         one or both of the colors are the implicit default colors.  This
4077         change records the default colors when TUI is initialized, and
4078         then specifies them explicitly when a color pair uses the default
4079         colors.  This allows color styling in TUI mode on MS-Windows.
4080
4081         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4082         ncurses_norm_attr.
4083         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4084         colors in ncurses_norm_attr.
4085         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4086         "none", replace it with the default color recorded in
4087         ncurses_norm_attr.
4088
4089 2019-03-14  Tom Tromey  <tromey@adacore.com>
4090
4091         * source-cache.h (class source_cache) <get_source_lines>: Return
4092         std::string.
4093         * source-cache.c (source_cache::extract_lines): Handle case where
4094         first_pos==npos.  Return std::string.
4095         (source_cache::get_source_lines): Update.
4096
4097 2019-03-14  Tom Tromey  <tromey@adacore.com>
4098
4099         * NEWS: Add item for "style sources" commands.
4100         * source-cache.c (source_cache::get_source_lines): Check
4101         source_styling.
4102         * cli/cli-style.c (source_styling): New global.
4103         (_initialize_cli_style): Add "style sources" commands.
4104         (show_style_sources): New function.
4105         * cli/cli-style.h (source_styling): Declare.
4106
4107 2019-03-14  Pedro Alves  <palves@redhat.com>
4108             Tom Tromey  <tromey@adacore.com>
4109
4110         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4111         * tui/tui-winsource.c (tui_refill_source_window): New function,
4112         from...
4113         (tui_horizontal_source_scroll): ... here.  Move some logic.
4114         * cli/cli-style.c (set_style_enabled): Notify new observable.
4115         * tui/tui-hooks.c (tui_redisplay_source): New function.
4116         (tui_attach_detach_observers): Attach or detach
4117         tui_redisplay_source.
4118         * observable.h (source_styling_changed): New observable.
4119         * observable.c: Define source_styling_changed observable.
4120
4121 2019-03-13  Tom Tromey  <tromey@adacore.com>
4122
4123         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4124         (i386_gnu_nat_target::store_registers): Update.
4125         * target-debug.h (target_debug_print_std_string): New macro.
4126         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4127         * windows-tdep.c (display_one_tib): Update.
4128         * tui/tui-stack.c (tui_make_status_line): Update.
4129         * top.c (print_inferior_quit_action): Update.
4130         * thread.c (thr_try_catch_cmd): Update.
4131         (add_thread_with_info): Update.
4132         (thread_target_id_str): Update.
4133         (thr_try_catch_cmd): Update.
4134         (thread_command): Update.
4135         (thread_find_command): Update.
4136         * record-btrace.c (record_btrace_target::info_record)
4137         (record_btrace_resume_thread, record_btrace_target::resume)
4138         (record_btrace_cancel_resume, record_btrace_step_thread)
4139         (record_btrace_target::wait, record_btrace_target::wait)
4140         (record_btrace_target::wait, record_btrace_target::stop): Update.
4141         * progspace.c (print_program_space): Update.
4142         * process-stratum-target.c
4143         (process_stratum_target::thread_address_space): Update.
4144         * linux-fork.c (linux_fork_mourn_inferior)
4145         (detach_checkpoint_command, info_checkpoints_command)
4146         (linux_fork_context): Update.
4147         (linux_fork_detach): Update.
4148         (class scoped_switch_fork_info): Update.
4149         (delete_checkpoint_command): Update.
4150         * infrun.c (follow_fork_inferior): Update.
4151         (follow_fork_inferior): Update.
4152         (proceed_after_vfork_done): Update.
4153         (handle_vfork_child_exec_or_exit): Update.
4154         (follow_exec): Update.
4155         (displaced_step_prepare_throw): Update.
4156         (displaced_step_restore): Update.
4157         (start_step_over): Update.
4158         (resume_1): Update.
4159         (clear_proceed_status_thread): Update.
4160         (proceed): Update.
4161         (print_target_wait_results): Update.
4162         (do_target_wait): Update.
4163         (context_switch): Update.
4164         (stop_all_threads): Update.
4165         (restart_threads): Update.
4166         (finish_step_over): Update.
4167         (handle_signal_stop): Update.
4168         (switch_back_to_stepped_thread): Update.
4169         (keep_going_pass_signal): Update.
4170         (print_exited_reason): Update.
4171         (normal_stop): Update.
4172         * inferior.c (inferior_pid_to_str): Change return type.
4173         (print_selected_inferior): Update.
4174         (add_inferior): Update.
4175         (detach_inferior): Update.
4176         * dummy-frame.c (fprint_dummy_frames): Update.
4177         * dcache.c (dcache_info_1): Update.
4178         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4179         (btrace_fetch, btrace_clear): Update.
4180         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4181         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4182         type.
4183         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4184         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4185         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4186         * gdbarch.c, gdbarch.h: Rebuild.
4187         * gdbarch.sh (core_pid_to_str): Change return type.
4188         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4189         return type.
4190         (windows_nat_target::pid_to_str): Change return type.
4191         (windows_delete_thread): Update.
4192         (windows_nat_target::attach): Update.
4193         (windows_nat_target::files_info): Update.
4194         * target-delegates.c: Rebuild.
4195         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4196         return type.
4197         (sol_thread_target::pid_to_str): Change return type.
4198         * remote.c (class remote_target) <pid_to_str>: Change return
4199         type.
4200         (remote_target::pid_to_str): Change return type.
4201         (extended_remote_target::attach, remote_target::remote_stop_ns)
4202         (remote_target::remote_notif_remove_queued_reply)
4203         (remote_target::push_stop_reply, remote_target::disable_btrace):
4204         Update.
4205         (extended_remote_target::attach): Update.
4206         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4207         type.
4208         (gdbsim_target::pid_to_str): Change return type.
4209         * ravenscar-thread.c (struct ravenscar_thread_target)
4210         <pid_to_str>: Change return type.
4211         (ravenscar_thread_target::pid_to_str): Change return type.
4212         * procfs.c (class procfs_target) <pid_to_str>: Change return
4213         type.
4214         (procfs_target::pid_to_str): Change return type.
4215         (procfs_target::attach): Update.
4216         (procfs_target::detach): Update.
4217         (procfs_target::fetch_registers): Update.
4218         (procfs_target::store_registers): Update.
4219         (procfs_target::wait): Update.
4220         (procfs_target::files_info): Update.
4221         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4222         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4223         return type.
4224         (nto_procfs_target::pid_to_str): Change return type.
4225         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4226         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4227         return type.
4228         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4229         (exit_lwp): Update.
4230         (attach_proc_task_lwp_callback, get_detach_signal)
4231         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4232         (linux_nat_target::resume, wait_lwp, stop_callback)
4233         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4234         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4235         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4236         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4237         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4238         type.
4239         (inf_ptrace_target::attach): Update.
4240         (inf_ptrace_target::files_info): Update.
4241         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4242         type.
4243         (go32_nat_target::pid_to_str): Change return type.
4244         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4245         (gnu_nat_target::wait): Update.
4246         (gnu_nat_target::wait): Update.
4247         (gnu_nat_target::resume): Update.
4248         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4249         (fbsd_nat_target::wait): Update.
4250         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4251         type.
4252         (darwin_nat_target::attach): Update.
4253         * corelow.c (class core_target) <pid_to_str>: Change return type.
4254         (core_target::pid_to_str): Change return type.
4255         * target.c (normal_pid_to_str): Change return type.
4256         (default_pid_to_str): Likewise.
4257         (target_pid_to_str): Change return type.
4258         (target_translate_tls_address): Update.
4259         (target_announce_detach): Update.
4260         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4261         return type.
4262         (bsd_uthread_target::pid_to_str): Change return type.
4263         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4264         type.
4265         (bsd_kvm_target::pid_to_str): Change return type.
4266         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4267         return type.
4268         (aix_thread_target::pid_to_str): Change return type.
4269         * target.h (struct target_ops) <pid_to_str>: Change return type.
4270         (target_pid_to_str, normal_pid_to_str): Likewise.
4271         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4272         type.
4273         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4274         type.
4275         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4276         return type.
4277         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4278         type.
4279         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4280         type.
4281         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4282         return type.
4283
4284 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4285
4286         * NEWS: Mention that the new default MI version is 3.  Mention
4287         changes to the output of commands and events that deal with
4288         multi-location breakpoints.
4289         * breakpoint.c: Include "mi/mi-out.h".
4290         (print_one_breakpoint): Change output syntax if using MI version
4291         >= 3.
4292         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4293         New.
4294         (mi_multi_location_breakpoint_output_fixed): New.
4295         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4296         (mi_cmd_fix_multi_location_breakpoint_output): New.
4297         (mi_multi_location_breakpoint_output_fixed): New.
4298         * mi/mi-cmds.c (mi_cmds): Register command
4299         -fix-multi-location-breakpoint-output.
4300         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4301         interpreter "mi".
4302
4303 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4304
4305         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4306         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4307         instantiate mi_ui_out based on interpreter name.
4308         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4309         * mi/mi-main.c (mi_load_progress): Likewise.
4310
4311 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4312
4313         * NEWS: Combine separate "New targets" sections for 8.3.
4314
4315 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4316
4317         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4318         (ppcfbsd_init_abi): Install gdbarch
4319         "fetch_tls_load_module_address" and "get_thread_local_address"
4320         methods.
4321
4322 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4323
4324         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4325         (riscv_fbsd_init_abi): Install gdbarch
4326         "fetch_tls_load_module_address" and "get_thread_local_address"
4327         methods.
4328
4329 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4330
4331         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4332         (i386fbsd_init_abi): Install gdbarch
4333         "fetch_tls_load_module_address" and "get_thread_local_address"
4334         methods.
4335
4336 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4337
4338         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4339         (amd64fbsd_init_abi): Install gdbarch
4340         "fetch_tls_load_module_address" and "get_thread_local_address"
4341         methods.
4342
4343 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4344
4345         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4346         (struct fbsd_pspace_data): New type.
4347         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4348         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4349         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4350         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4351         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4352
4353 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4354
4355         * gdbtypes.c (lookup_struct_elt): New function.
4356         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4357         * gdbtypes.h (struct struct_elt): New type.
4358         (lookup_struct_elt): New prototype.
4359
4360 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4361
4362         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4363         remove disabled code block.
4364
4365 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4366
4367         * gdbarch.sh (get_thread_local_address): New method.
4368         * gdbarch.h, gdbarch.c: Regenerate.
4369         * target.c (target_translate_tls_address): Use
4370         gdbarch_get_thread_local_address if present instead of
4371         target::get_thread_local_address.
4372
4373 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4374
4375         * target.h (target::get_thread_local_address): Update comment.
4376
4377 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4378
4379         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4380         objfile->separate_debug_objfile_backlink if not NULL.
4381
4382 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4383
4384         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4385         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4386         (amd64bsd_store_inferior_registers): Likewise.
4387         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4388         Enable segment base registers.
4389         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4390         PT_GETFSBASE and PT_GETGSBASE.
4391         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4392         PT_SETGSBASE.
4393         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4394         segment base registers.
4395         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4396
4397 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4398
4399         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4400         Update calls to i386_target_description to add 'segments'
4401         parameter.
4402         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4403         add segment base registers.
4404         * arch/i386.c (i386_create_target_description): Add 'segments'
4405         parameter to enable segment base registers.
4406         * arch/i386.h (i386_create_target_description): Likewise.
4407         * features/i386/32bit-segments.xml: New file.
4408         * features/i386/32bit-segments.c: Generate.
4409         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4410         call to i386_target_description to add 'segments' parameter.
4411         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4412         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4413         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4414         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4415         if feature is present.
4416         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4417         Add 'segments' parameter to call to i386_target_description.
4418         (i386_target_description): Add 'segments' parameter to enable
4419         segment base registers.
4420         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4421         to call to i386_target_description.
4422         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4423         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4424         Define I386_NUM_REGS.
4425         (i386_target_description): Add 'segments' parameter to enable
4426         segment base registers.
4427
4428 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4429
4430         PR/24325
4431         * source-cache.c: #undef open and close, to avoid unresolved
4432         externals during linking.
4433
4434 2019-03-12  Tom Tromey  <tromey@adacore.com>
4435
4436         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4437         const.  Add initializers.
4438         (_initialize_remote): Don't initialize ptid globals.
4439
4440 2019-03-12  Pedro Alves  <palves@redhat.com>
4441
4442         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4443
4444 2019-03-12  Pedro Alves  <palves@redhat.com>
4445
4446         * cp-name-parser.y (main): Remove unused 'len' variable.
4447
4448 2019-03-12  Tom Tromey  <tromey@adacore.com>
4449
4450         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4451         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4452
4453 2019-03-12  Tom Tromey  <tromey@adacore.com>
4454
4455         * linux-nat.c (iterate_over_lwps): Update.
4456         (stop_callback): Remove parameter.
4457         (stop_wait_callback, detach_callback, resume_set_callback)
4458         (select_singlestep_lwp_callback, set_ignore_sigint)
4459         (status_callback, resumed_callback, resume_clear_callback)
4460         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4461         data parameter.
4462         (linux_nat_target::detach, linux_nat_target::resume)
4463         (linux_stop_and_wait_all_lwps, select_event_lwp)
4464         (linux_nat_filter_event, linux_nat_wait_1)
4465         (linux_nat_target::kill, linux_nat_target::stop)
4466         (linux_nat_target::stop): Update.
4467         (linux_nat_resume_callback): Change type.
4468         (resume_stopped_resumed_lwps, count_events_callback)
4469         (select_event_lwp_callback): Likewise.
4470         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4471         * arm-linux-nat.c (struct update_registers_data): Remove.
4472         (update_registers_callback): Change type.
4473         (arm_linux_insert_hw_breakpoint1): Update.
4474         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4475         parameter.
4476         (x86_linux_dr_set_addr): Update.
4477         (x86_linux_dr_set_control): Update.
4478         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4479         (iterate_over_lwps): Use gdb::function_view.
4480         * nat/aarch64-linux-hw-point.c (struct
4481         aarch64_dr_update_callback_param): Remove.
4482         (debug_reg_change_callback): Change type.
4483         (aarch64_notify_debug_reg_change): Update.
4484         * s390-linux-nat.c (s390_refresh_per_info): Update.
4485
4486 2019-03-11  Tom Tromey  <tromey@adacore.com>
4487
4488         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4489         redundant assignment to "this_cu".
4490
4491 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4492
4493         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4494
4495 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4496
4497         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4498         from...
4499         (rank_one_type): ... this.
4500
4501 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4502
4503         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4504         from...
4505         (rank_one_type): ... this.
4506
4507 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4508
4509         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4510         from...
4511         (rank_one_type): ... this.
4512
4513 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4514
4515         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4516         from...
4517         (rank_one_type): ... this.
4518
4519 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4520
4521         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4522         from...
4523         (rank_one_type): ... this.
4524
4525 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4526
4527         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4528         from...
4529         (rank_one_type): ... this.
4530
4531 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4532
4533         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4534         from...
4535         (rank_one_type): ... this.
4536
4537 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4538
4539         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4540         from...
4541         (rank_one_type): ... this.
4542
4543 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4544
4545         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4546         from...
4547         (rank_one_type): ... this.
4548
4549 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4550
4551         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4552         from...
4553         (rank_one_type): ... this.
4554
4555 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4556
4557         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4558         from...
4559         (rank_one_type): ... this.
4560
4561 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4562
4563         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4564         from...
4565         (rank_one_type): ... this.
4566
4567 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4568
4569         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4570         inferior-events' shows the example events.
4571
4572 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4573
4574         Support styling on native MS-Windows console
4575
4576         PR/24315
4577         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4578         on MS-Windows if $TERM is not defined.
4579
4580         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4581
4582         * posix-hdep.c (gdb_console_fputs):
4583         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4584         functions.
4585         * ui-file.h (gdb_console_fputs): Add prototype.
4586
4587         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4588         back to fputs only if the former returns zero.
4589
4590 2019-03-07  Tom Tromey  <tom@tromey.com>
4591
4592         * symmisc.c (print_symbol_bcache_statistics): Update.
4593         (print_objfile_statistics): Update.
4594         * symfile.c (allocate_symtab): Update.
4595         * stabsread.c: Don't include bcache.h.
4596         * psymtab.h (struct psymbol_bcache): Don't declare.
4597         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4598         (psymbol_bcache_init, psymbol_bcache_free)
4599         (psymbol_bcache_get_bcache): Don't declare.
4600         * psymtab.c (struct psymbol_bcache): Remove.
4601         (psymtab_storage::psymtab_storage): Update.
4602         (psymtab_storage::~psymtab_storage): Update.
4603         (psymbol_bcache_init, psymbol_bcache_free)
4604         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4605         (add_psymbol_to_bcache): Update.
4606         (allocate_psymtab): Update.
4607         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4608         macro_cache>: No longer pointers.
4609         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4610         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4611         * macrotab.c (macro_bcache): Update.
4612         * macroexp.c: Don't include bcache.h.
4613         * gdbtypes.c (check_types_worklist): Update.
4614         (types_deeply_equal): Remove TRY/CATCH.  Update.
4615         * elfread.c (elf_symtab_read): Update.
4616         * dwarf2read.c: Don't include bcache.h.
4617         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4618         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4619         (print_bcache_statistics, bcache_memory_used): Don't declare.
4620         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4621         methods.  Rename all data members.
4622         * bcache.c (struct bcache): Move to bcache.h.
4623         (bcache::expand_hash_table): Rename from expand_hash_table.
4624         (bcache): Remove.
4625         (bcache::insert): Rename from bcache_full.
4626         (bcache::compare): Rename from bcache_compare.
4627         (bcache_xmalloc): Remove.
4628         (bcache::~bcache): Rename from bcache_xfree.
4629         (bcache::print_statistics): Rename from print_bcache_statistics.
4630         (bcache::memory_used): Rename from bcache_memory_used.
4631
4632 2019-03-07  Pedro Alves  <palves@redhat.com>
4633
4634         * infrun.c (normal_stop): Also check for
4635         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4636
4637 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4638
4639         * f-lang.c (value_from_host_double): Moved to...
4640         * value.c (value_from_host_double): ...here.
4641         * value.h (value_from_host_double): Declare.
4642         * guile/scm-math.c (vlscm_convert_typed_number): Use
4643         value_from_host_double.
4644         (vlscm_convert_number): Likewise.
4645         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4646         * python/py-value.c (convert_value_from_python): Likewise.
4647
4648 2019-03-06  Tom Tromey  <tom@tromey.com>
4649
4650         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4651
4652 2019-03-06  Tom Tromey  <tom@tromey.com>
4653
4654         * utils.h (free_current_contents): Don't declare.
4655         * utils.c (free_current_contents): Remove.
4656
4657 2019-03-06  Tom Tromey  <tom@tromey.com>
4658
4659         * top.c (quit_force): Update.
4660         * main.c (captured_command_loop): Update.
4661         * common/new-op.c (operator new): Update.
4662         * common/common-exceptions.c (struct catcher)
4663         <save_cleanup_chain>: Remove member.
4664         (exceptions_state_mc_init): Update.
4665         (exception_try_scope_entry): Return nullptr.
4666         (exception_try_scope_exit, exception_rethrow)
4667         (throw_exception_sjlj, throw_exception_cxx): Update.
4668         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4669         (all_cleanups, do_cleanups, discard_cleanups)
4670         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4671         (restore_cleanups, restore_final_cleanups): Don't declare.
4672         (do_final_cleanups): Remove parameter.
4673         * common/cleanups.c (cleanup_chain, make_cleanup)
4674         (make_cleanup_dtor, all_cleanups, do_cleanups)
4675         (discard_my_cleanups, discard_cleanups)
4676         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4677         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4678         (null_cleanup): Remove.
4679         (do_final_cleanups): Remove parameter.
4680
4681 2019-03-06  Tom Tromey  <tom@tromey.com>
4682
4683         * remote.c (remote_target::remote_parse_stop_reply): Use
4684         unique_xmalloc_ptr.
4685
4686 2019-03-06  Tom Tromey  <tom@tromey.com>
4687
4688         * stabsread.c (struct stabs_field_info): Rename from field_info.
4689         <list, fnlist>: Add initializers.
4690         <obstack>: New member.
4691         (read_member_functions, read_struct_fields, read_baseclasses):
4692         Allocate on obstack.  Don't use cleanups.
4693         (read_one_struct_field, read_member_functions, read_struct_fields)
4694         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4695         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4696         (read_struct_type): Update.
4697
4698 2019-03-06  Tom Tromey  <tom@tromey.com>
4699
4700         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4701         * common/filestuff.h (make_cleanup_close): Don't declare.
4702         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4703         Remove.
4704
4705 2019-03-06  Tom Tromey  <tom@tromey.com>
4706
4707         * solib-aix.c: Use make_scope_exit.
4708
4709 2019-03-06  Tom Tromey  <tom@tromey.com>
4710
4711         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4712         Use make_scope_exit.
4713
4714 2019-03-06  Tom Tromey  <tom@tromey.com>
4715
4716         * solib-svr4.c (disable_probes_interface): Remove parameter.
4717         (svr4_handle_solib_event): Use make_scope_exit.
4718
4719 2019-03-06  Tom Tromey  <tom@tromey.com>
4720
4721         * remote.c (struct stop_reply_deleter): Remove.
4722         (stop_reply_up): Update.
4723         (struct stop_reply): Derive from notif_event.  Don't typedef.
4724         <regcache>: Now a std::vector.
4725         (stop_reply_xfree): Remove.
4726         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4727         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4728         (remote_target::discard_pending_stop_replies): Use delete.
4729         (remote_target::remote_parse_stop_reply): Update.
4730         (remote_target::process_stop_reply): Update.
4731         * remote-notif.h (struct notif_event): Add virtual destructor.
4732         Remove "dtr" member.
4733         (struct notif_client) <alloc_event>: Return a unique_ptr.
4734         (notif_event_xfree): Don't declare.
4735         (notif_event_up): New typedef.
4736         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4737         (notif_event_xfree, do_notif_event_xfree): Remove.
4738         (remote_notif_state_xfree): Update.
4739
4740 2019-03-06  Tom Tromey  <tom@tromey.com>
4741
4742         * infrun.c (displaced_step_clear_cleanup): Now a
4743         forward_scope_exit type.
4744         (displaced_step_prepare_throw): Update.
4745         (displaced_step_fixup): Update.
4746
4747 2019-03-06  Tom Tromey  <tom@tromey.com>
4748
4749         * inferior.h (class inferior): Update comment.
4750         * gdbthread.h (class thread_info): Update comment.
4751
4752 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4753             Tom Tromey  <tom@tromey.com>
4754
4755         * stabsread.h (struct stab_section_list): Remove.
4756         (coffstab_build_psymtabs): Update.
4757         * dbxread.c (symbuf_sections): Now a std::vector.
4758         (sect_idx): New global.
4759         (fill_symbuf): Update.
4760         (coffstab_build_psymtabs): Change type of stabsects parameter.
4761         Update.
4762         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4763         std::vector.
4764         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4765         (coff_locate_sections): Update.
4766         (coff_symfile_read): Remove cleanups.  Update.
4767         (init_stringtab): Add storage parameter.
4768         (free_stringtab, free_stringtab_cleanup): Remove.
4769         (init_lineno): Add storage parameter.
4770         (free_linetab, free_linetab_cleanup): Remove.
4771
4772 2019-03-06  Pedro Alves  <palves@redhat.com>
4773
4774         * linux-fork.c (fork_info::clobber_regs): Delete.
4775         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4776         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4777         comment.  Adjust.
4778         (scoped_switch_fork_info::scoped_switch_fork_info)
4779         (checkpoint_command, linux_fork_context): Adjust
4780         fork_save_infrun_state calls.
4781
4782 2019-03-06  Pedro Alves  <palves@redhat.com>
4783
4784         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4785         (inf_has_multiple_threads): Return 'bool' and rewrite using
4786         inferior_info::threads().
4787
4788 2019-03-06  Pedro Alves  <palves@redhat.com>
4789
4790         * linux-fork.c: Include <list>.
4791         (fork_list): Now a std::list instance.
4792         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4793         (forks_exist_p, find_last_fork): Adjust.
4794         (new_fork): Delete.
4795         (one_fork_p): New.
4796         (add_fork): Adjust.
4797         (free_fork): Delete, folded into fork_info::~fork_info().
4798         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4799         Adjust.
4800         (init_fork_list): Delete.
4801         (linux_fork_killall, linux_fork_mourn_inferior)
4802         (linux_fork_detach, info_checkpoints_command): Adjust.
4803         (_initialize_linux_fork): No longer call init_fork_list.
4804
4805 2019-03-06  Pedro Alves  <palves@redhat.com>
4806
4807         * linux-fork.c (new_fork): New, split out of ...
4808         (add_fork): ... this.  Return void.  Move "first fork" special
4809         case from here, to ...
4810         (checkpoint_command): ... here.
4811         * linux-linux.h (add_fork): Return void.
4812
4813 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4814
4815         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4816
4817 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4818             Chris January  <chris.january@arm.com>
4819             David Lecomber  <david.lecomber@arm.com>
4820
4821         * f-exp.y: New token, UNOP_INTRINSIC.
4822         (exp): New pattern using UNOP_INTRINSIC token.
4823         (f77_keywords): Add 'abs' keyword.
4824         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4825         (value_from_host_double): New function.
4826         (evaluate_subexp_f): Support UNOP_ABS.
4827
4828 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4829
4830         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4831         types.
4832
4833 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4834
4835         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4836         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4837         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4838
4839 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4840
4841         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4842
4843 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4844             Chris January  <chris.january@arm.com>
4845
4846         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4847         * f-exp.y: Define 'KIND' token.
4848         (exp): New pattern for KIND expressions.
4849         (ptype): Handle types with a kind extension.
4850         (direct_abs_decl): Extend to spot kind extensions.
4851         (f77_keywords): Add 'kind' to the list.
4852         (push_kind_type): New function.
4853         (convert_to_kind_type): New function.
4854         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4855         * parse.c (operator_length_standard): Likewise.
4856         * parser-defs.h (enum type_pieces): Add tp_kind.
4857         * std-operator.def: Add UNOP_KIND.
4858
4859 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4860
4861         * f-exp.y (f_parse): Set yydebug.
4862
4863 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4864
4865         * f-lang.c (evaluate_subexp_f): New function.
4866         (exp_descriptor_f): New global.
4867         (f_language_defn): Use exp_descriptor_f instead of
4868         exp_descriptor_standard.
4869
4870 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4871
4872         * f-exp.y (struct token): Add comments.
4873         (dot_ops): Remove uppercase versions and the end marker.
4874         (f77_keywords): Likewise.
4875         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4876         entries in the dot_ops array are case insensitive, and use
4877         strncasecmp to compare strings.  Also some whitespace cleanup in
4878         this area.  Similar for the f77_keywords array, except entries in
4879         this list might be case sensitive.
4880
4881 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4882
4883         * f-exp.y (struct f77_boolean_val): Add comments.
4884         (boolean_values): Remove uppercase versions, and end marker.
4885         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4886         and use strncasecmp to achieve case insensitivity.  Additionally,
4887         perform whitespace cleanup around this code.
4888
4889 2019-03-06  Tom Tromey  <tromey@adacore.com>
4890
4891         * remote-sim.c (gdbsim_target_open): Use result of
4892         gdb_argv::release.
4893
4894 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4895         Dirk Schubert  <dirk.schubert@arm.com>
4896         Chris January  <chris.january@arm.com>
4897
4898         * eval.c (evaluate_subexp_standard): Call Fortran argument
4899         wrapping logic.
4900         * f-lang.c (struct value): A value which can be passed into a
4901         Fortran function call.
4902         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4903         where appropriate.
4904         (struct type): Value ready for a Fortran function call.
4905         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4906         is needed.
4907         * f-lang.h (fortran_argument_convert): Declaration.
4908         (fortran_preserve_arg_pointer): Declaration.
4909         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4910
4911 2019-03-05  Tom Tromey  <tromey@adacore.com>
4912
4913         * python/py-prettyprint.c (print_string_repr): Remove #if.
4914         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4915
4916 2019-03-05  Tom Tromey  <tromey@adacore.com>
4917
4918         * target.c (the_dummy_target): Move later.  Change type to
4919         "dummy_target".
4920         (initialize_targets): Don't initialize the_dummy_target.
4921
4922 2019-03-05  Tom Tromey  <tromey@adacore.com>
4923
4924         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4925         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4926
4927 2019-03-05  Tom Tromey  <tromey@adacore.com>
4928
4929         * windows-nat.c (windows_nat_target::attach)
4930         (windows_nat_target::detach): Don't call gdb_flush.
4931         * valprint.c (generic_val_print, val_print, val_print_string):
4932         Don't call gdb_flush.
4933         * utils.c (defaulted_query): Don't call gdb_flush.
4934         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4935         * target.c (target_announce_detach): Don't call gdb_flush.
4936         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4937         * remote.c (extended_remote_target::attach): Don't call
4938         gdb_flush.
4939         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4940         * printcmd.c (do_examine): Don't call gdb_flush.
4941         (info_display_command): Don't call gdb_flush.
4942         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4943         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4944         * memattr.c (info_mem_command): Don't call gdb_flush.
4945         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4946         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4947         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4948         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4949         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4950         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4951         (gnu_nat_target::detach): Don't call gdb_flush.
4952         * f-valprint.c (f_val_print): Don't call gdb_flush.
4953         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4954         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4955         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4956         gdb_flush.
4957         * c-valprint.c (c_val_print): Don't call gdb_flush.
4958         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4959
4960 2019-03-05  Tom Tromey  <tromey@adacore.com>
4961
4962         * varobj.c (update_dynamic_varobj_children): Update.
4963         (install_default_visualizer): Use reset, not release.
4964         * value.c (set_internalvar): Update.
4965         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4966         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4967         ATTRIBUTE_UNUSED_RESULT.
4968
4969 2019-03-05  Tom Tromey  <tromey@adacore.com>
4970
4971         * remote.c (class scoped_remote_fd) <release>: Add
4972         ATTRIBUTE_UNUSED_RESULT.
4973
4974 2019-03-05  Tom Tromey  <tromey@adacore.com>
4975
4976         * macroexp.c (struct macro_buffer) <release>: Add
4977         ATTRIBUTE_UNUSED_RESULT.
4978
4979 2019-03-05  Tom Tromey  <tromey@adacore.com>
4980
4981         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4982         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4983         ATTRIBUTE_UNUSED_RESULT.
4984
4985 2019-03-05  Tom Tromey  <tromey@adacore.com>
4986
4987         * common/scoped_fd.h (class scoped_fd) <release>: Add
4988         ATTRIBUTE_UNUSED_RESULT.
4989
4990 2019-03-05  Tom Tromey  <tromey@adacore.com>
4991
4992         * parser-defs.h (struct parser_state) <release>: Add
4993         ATTRIBUTE_UNUSED_RESULT.
4994
4995 2019-03-05  Tom Tromey  <tromey@adacore.com>
4996
4997         * utils.h (class gdb_argv) <release>: Add
4998         ATTRIBUTE_UNUSED_RESULT.
4999         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5000
5001 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5002
5003         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5004         for-loop range, to avoid compiler warnings.
5005
5006         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5007         avoid compiler warnings about unused variables.
5008
5009         * NEWS: Mention end of support for native debugging on MS-Windows
5010         before XP.
5011
5012         PR gdb/24292
5013         * common/netstuff.c:
5014         * gdbserver/gdbreplay.c
5015         * gdbserver/remote-utils.c:
5016         * ser-tcp.c:
5017         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5018         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5019         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5020         'getaddrinfo' and 'freeaddrinfo' were not available before
5021         Windows XP, and mingw.org's MinGW headers by default define
5022         _WIN32_WINNT to 0x500.
5023
5024 2019-03-01  Gary Benson <gbenson@redhat.com>
5025
5026         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5027
5028 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5029             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5030
5031         PR gdb/8527
5032         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5033         set_sigint_trap, clear_sigint_trap.
5034
5035 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5036
5037         * target.c (target_detach): Clear the regcache and the
5038         frame cache.
5039
5040 2019-02-27  Pedro Alves  <palves@redhat.com>
5041
5042         * utils.c (set_screen_size): When we cap the height/width sizes,
5043         tweak the corresponding command variable to show "unlimited":
5044
5045 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5046             Pedro Alves  <palves@redhat.com>
5047
5048         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5049         before calling rl_set_screen_size.
5050
5051 2019-02-27  Tom Tromey  <tromey@adacore.com>
5052
5053         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5054         define.
5055         * python/py-value.c: Remove Python 2.4 workaround.
5056         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5057         workaround.
5058         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5059         Python 2.4 workaround.
5060         * python/python-internal.h: Remove Python 2.4 comment.
5061         (Py_ssize_t): Don't define.
5062         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5063         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5064         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5065         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5066         * python/python.c (do_start_initialization): Remove Python 2.4
5067         workaround.
5068         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5069         (print_children): Remove Python 2.4 workaround.
5070         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5071         workaround.
5072         (CHARBUFFERPROC_NAME): Remove.
5073         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5074         Python 2.4 workaround.
5075
5076 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5077
5078         * NEWS: Note minimum Python version.
5079
5080 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5081
5082         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5083         code from these functions.  Remove corresponding ifdefs.  Use
5084         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5085         Remove gotos and target of gotos.
5086         (infpy_search_memory): Likewise.
5087
5088 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5089
5090         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5091         (hppa_gdbarch_init): Don't register deleted functions with
5092         gdbarch.
5093
5094 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5095
5096         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5097         (h8300_unwind_sp): Delete.
5098         (h8300_dummy_id): Delete.
5099         (h8300_gdbarch_init): Don't register deleted functions with
5100         gdbarch.
5101
5102 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5103
5104         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5105         (ft32_unwind_pc): Delete.
5106         (ft32_unwind_sp): Delete.
5107         (ft32_gdbarch_init): Don't register deleted functions with
5108         gdbarch.
5109
5110 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5111
5112         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5113         (frv_unwind_pc): Delete.
5114         (frv_unwind_sp): Delete.
5115         (frv_gdbarch_init): Don't register deleted functions with
5116         gdbarch.
5117
5118 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5119
5120         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5121         (riscv_unwind_pc): Delete.
5122         (riscv_unwind_sp): Delete.
5123         (riscv_gdbarch_init): Don't register deleted functions with
5124         gdbarch.
5125
5126 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5127
5128         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5129         (csky_unwind_pc): Delete.
5130         (csky_unwind_sp): Delete.
5131         (csky_gdbarch_init): Don't register deleted functions with
5132         gdbarch.
5133
5134 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5135
5136         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5137         (cris_unwind_pc): Delete.
5138         (cris_unwind_sp): Delete.
5139         (cris_gdbarch_init): Don't register deleted functions with
5140         gdbarch.
5141
5142 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5143
5144         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5145         (bfin_unwind_pc): Delete.
5146         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5147
5148 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5149
5150         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5151         (arm_unwind_pc): Delete.
5152         (arm_unwind_sp): Delete.
5153         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5154
5155 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5156
5157         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5158         (arc_unwind_pc): Delete.
5159         (arc_unwind_sp): Delete.
5160         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5161
5162 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5163
5164         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5165         (alpha_unwind_pc): Delete.
5166         (alpha_gdbarch_init): Don't register deleted functions with
5167         gdbarch.
5168
5169 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5170
5171         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5172         (aarch64_unwind_pc): Delete.
5173         (aarch64_unwind_sp): Delete.
5174         (aarch64_gdbarch_init): Don't register deleted functions with
5175         gdbarch.
5176
5177 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5178
5179         * gdbtypes.c (type_align): Don't consider static members when
5180         computing structure alignment.
5181
5182 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5183
5184         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5185         return 0 for other types.
5186         * arch-utils.c (default_type_align): Always return 0.
5187         * gdbarch.h: Regenerate.
5188         * gdbarch.sh (type_align): Extend comment.
5189         * gdbtypes.c (type_align): Add additional comments, always call
5190         gdbarch_type_align before applying the default rules.
5191         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5192         generic code will then apply a suitable default.
5193         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5194         types, return 0 for other types.
5195
5196 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5197
5198         * NEWS: Create a new section for the next release branch.
5199         Rename the section of the current branch, now that it has
5200         been cut.
5201
5202 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5203
5204         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5205         * version.in: Bump version to 8.3.50.DATE-git.
5206
5207 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5208
5209         * aix-thread.c (ptid_cmp): Remove unused variable.
5210         (get_signaled_thread): Likewise.
5211         (store_regs_user_thread): Likewise.
5212         (store_regs_kernel_thread): Likewise.
5213         (fetch_regs_kernel_thread): Remove shadowed variable.
5214
5215 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5216
5217         * features/riscv/32bit-cpu.xml: Add register numbers.
5218         * features/riscv/32bit-fpu.c: Regenerate.
5219         * features/riscv/32bit-fpu.xml: Add register numbers.
5220         * features/riscv/64bit-cpu.xml: Add register numbers.
5221         * features/riscv/64bit-fpu.c: Regenerate.
5222         * features/riscv/64bit-fpu.xml: Add register numbers.
5223
5224 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5225
5226         * NEWS: Mention two argument form of gdb.Value constructor.
5227         * python/py-value.c (convert_buffer_and_type_to_value): New
5228         function.
5229         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5230         Add support for handling an optional second argument.  Call
5231         convert_buffer_and_type_to_value as appropriate.
5232         * python/python-internal.h (Py_buffer_deleter): New struct.
5233         (Py_buffer_up): New typedef.
5234
5235 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5236
5237         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5238         instead of releasing ownership.
5239
5240 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5241
5242         * dwarf2read.c (open_and_init_dwp_file): Call
5243         elf_numsections instead of bfd_count_sections to initialize
5244         dwp_file->num_sections.
5245
5246 2019-02-25  Tom Tromey  <tromey@adacore.com>
5247
5248         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5249
5250 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5251
5252         * gcore.in: Add '--readnever' option when invoking GDB.
5253
5254 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5255
5256         * MAINTAINERS: Update my email address.
5257
5258 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5259
5260         * build-id.c (build_id_to_debug_bfd_1): New function.
5261         (build_id_to_debug_bfd): Look for separate debug file in
5262         sysroot.
5263
5264 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5265
5266         * gdbarch.sh: Update the copyright year range that is placed into
5267         generated files.
5268
5269 2019-02-22  Keith Seitz  <keiths@redhat.com>
5270
5271         PR symtab/23853
5272         * linespec.c (create_sals_line_offset): Search for the default
5273         symtab's filename instead of its fullname.
5274
5275 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5276
5277         * NEWS: Update style defaults.
5278
5279 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5280
5281         * main.c (captured_main_1): Disable styling in batch mode.
5282
5283 2019-02-20  Tom Tromey  <tom@tromey.com>
5284
5285         * symtab.c (symtab_symbol_info): Fix typos.
5286
5287 2019-02-20  Tom Tromey  <tromey@adacore.com>
5288
5289         * findcmd.c (_initialize_mem_search): Use upper case for
5290         metasyntactic variables.
5291
5292 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5293
5294         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5295         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5296
5297 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5298
5299         * top.h (source_file_name): Change to std::string.
5300         * top.c (source_file_name): Likewise.
5301         (command_line_input): Adjust.
5302         * cli/cli-script.c (script_from_file): Adjust.
5303
5304 2019-02-19  Tom Tromey  <tromey@adacore.com>
5305
5306         * ravenscar-thread.c
5307         (ravenscar_thread_target::update_thread_list): Don't call
5308         ada_build_task_list.
5309         * ada-lang.h (ada_build_task_list): Don't declare.
5310         * ada-tasks.c (struct ada_tasks_inferior_data)
5311         <task_list_valid_p>: Now bool.
5312         (read_known_tasks, ada_task_list_changed)
5313         (ada_tasks_invalidate_inferior_data): Update.
5314         (read_known_tasks_array): Return bool.
5315         (read_known_tasks_list): Likewise.
5316         (read_known_tasks): Return void.
5317         (ada_build_task_list): Now static.
5318
5319 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5320
5321         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5322         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5323
5324 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5325
5326         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5327         variant for ada_tasks_pspace_data_handle and
5328         ada_tasks_inferior_data_handle.
5329         (ada_tasks_pspace_data_cleanup): New function.
5330         (ada_tasks_inferior_data_cleanup): New function.
5331
5332 2019-02-17  Tom Tromey  <tom@tromey.com>
5333
5334         * macrotab.h (macro_source_fullname): Return a std::string.
5335         * macrotab.c (macro_include, check_for_redefinition)
5336         (macro_undef, macro_lookup_definition, foreach_macro)
5337         (foreach_macro_in_scope): Update.
5338         (macro_source_fullname): Return a std::string.
5339         * macrocmd.c (show_pp_source_pos): Update.
5340
5341 2019-02-17  Tom Tromey  <tom@tromey.com>
5342
5343         * macrocmd.c (show_pp_source_pos): Style the file names.
5344
5345 2019-02-17  Tom Tromey  <tom@tromey.com>
5346
5347         PR tui/24197:
5348         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5349
5350 2019-02-17  Tom Tromey  <tom@tromey.com>
5351
5352         * ada-lang.c (user_select_syms): Use filtered printing.
5353         * utils.c (wrap_style): New global.
5354         (desired_style): Remove.
5355         (emit_style_escape): Add stream parameter.
5356         (set_output_style, reset_terminal_style, prompt_for_continue):
5357         Update.
5358         (flush_wrap_buffer): Only flush gdb_stdout.
5359         (wrap_here): Set wrap_style.
5360         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5361         treat escape sequences as a character.  Change when wrap buffer is
5362         flushed.
5363         (fputs_styled): Do not set the output style when the default is
5364         requested.
5365         * ui-style.h (struct ui_file_style) <is_default>: New method.
5366         * source.c (print_source_lines_base): Emit escape sequences in one
5367         piece.
5368
5369 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5370
5371         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5372         integers and enumeration types.
5373
5374 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5375
5376         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5377         instead of lookup_symbol_in_language
5378         (do_exact_match): New function.
5379         (ada_get_symbol_name_matcher): Return do_exact_match when
5380         doing a verbatim match.
5381
5382 2019-02-15  Tom Tromey  <tromey@adacore.com>
5383
5384         * ravenscar-thread.c (ravenscar_thread_target::resume)
5385         (ravenscar_thread_target::wait): Special case wildcard requests.
5386
5387 2019-02-15  Tom Tromey  <tromey@adacore.com>
5388
5389         * ravenscar-thread.c (base_ptid): Remove.
5390         (struct ravenscar_thread_target) <close>: New method.
5391         <m_base_ptid>: New member.
5392         <update_inferior_ptid, active_task, task_is_currently_active,
5393         runtime_initialized>: Declare methods.
5394         <ravenscar_thread_target>: Add constructor.
5395         (ravenscar_thread_target::task_is_currently_active)
5396         (ravenscar_thread_target::update_inferior_ptid)
5397         (ravenscar_runtime_initialized): Rename.  Now methods.
5398         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5399         (ravenscar_thread_target::update_thread_list): Update.
5400         (ravenscar_thread_target::active_task): Now method.
5401         (ravenscar_thread_target::store_registers)
5402         (ravenscar_thread_target::prepare_to_store)
5403         (ravenscar_thread_target::prepare_to_store)
5404         (ravenscar_thread_target::mourn_inferior): Update.
5405         (ravenscar_inferior_created): Use "new" to create target.
5406         (ravenscar_thread_target::get_ada_task_ptid): Update.
5407         (_initialize_ravenscar): Don't initialize base_ptid.
5408         (ravenscar_ops): Remove global.
5409
5410 2019-02-15  Tom Tromey  <tromey@adacore.com>
5411
5412         * target.h (push_target): Declare new overload.
5413         * target.c (push_target): New overload, taking an rvalue reference.
5414         * remote.c (remote_target::open_1): Use push_target overload.
5415         * corelow.c (core_target_open): Use push_target overload.
5416
5417 2019-02-15  Tom Tromey  <tromey@adacore.com>
5418
5419         * ravenscar-thread.c (is_ravenscar_task)
5420         (ravenscar_task_is_currently_active): Return bool.
5421         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5422         (_initialize_ravenscar): Remove "(void)".
5423         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5424         Return bool.
5425
5426 2019-02-15  Tom Tromey  <tromey@adacore.com>
5427
5428         * ravenscar-thread.c (ravenscar_runtime_initializer)
5429         (has_ravenscar_runtime, get_running_thread_id)
5430         (ravenscar_thread_target::resume): Fix indentation.
5431
5432 2019-02-15  Tom Tromey  <tromey@adacore.com>
5433
5434         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5435         from ravenscar_arch_ops.
5436         (sparc_ravenscar_ops::fetch_registers)
5437         (sparc_ravenscar_ops::store_registers): Now methods.
5438         (sparc_ravenscar_prepare_to_store): Remove.
5439         (sparc_ravenscar_ops): Redefine.
5440         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5441         methods and destructor.  Remove members.
5442         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5443         (ravenscar_thread_target::store_registers)
5444         (ravenscar_thread_target::prepare_to_store): Update.
5445         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5446         Remove.
5447         (struct ppc_ravenscar_powerpc_ops): Derive from
5448         ravenscar_arch_ops.
5449         (ppc_ravenscar_powerpc_ops::fetch_registers)
5450         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5451         (ppc_ravenscar_powerpc_ops): Redefine.
5452         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5453         (ppc_ravenscar_e500_ops::fetch_registers)
5454         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5455         (ppc_ravenscar_e500_ops): Redefine.
5456         * aarch64-ravenscar-thread.c
5457         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5458         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5459         (aarch64_ravenscar_fetch_registers)
5460         (aarch64_ravenscar_store_registers): Now methods.
5461         (aarch64_ravenscar_ops): Redefine.
5462
5463 2019-02-15  Tom Tromey  <tromey@adacore.com>
5464
5465         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5466         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5467         (ravenscar_thread_target::stopped_by_watchpoint)
5468         (ravenscar_thread_target::stopped_data_address)
5469         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5470
5471 2019-02-15  Tom Tromey  <tromey@adacore.com>
5472
5473         * ravenscar-thread.c: Fix some typos.
5474
5475 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5476             Tom Tromey  <tromey@adacore.com>
5477
5478         * ada-lang.c (ada_exception_sal): Change addr_string to a
5479         std::string.
5480         (create_ada_exception_catchpoint): Update.
5481
5482 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5483             Tom Tromey  <tromey@adacore.com>
5484
5485         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5486         (bp_location_ops): Remove.
5487         (base_breakpoint_allocate_location): Update.
5488         (free_bp_location): Update.
5489         * ada-lang.c (class ada_catchpoint_location)
5490         <ada_catchpoint_location>: Remove ops parameter.
5491         (ada_catchpoint_location_dtor): Remove.
5492         (ada_catchpoint_location_ops): Remove.
5493         (allocate_location_exception): Update.
5494         * breakpoint.h (struct bp_location_ops): Remove.
5495         (class bp_location) <bp_location>: Remove bp_location_ops
5496         parameter.
5497         <~bp_location>: Add destructor.
5498         <ops>: Remove.
5499
5500 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5501             Pedro Alves  <palves@redhat.com>
5502
5503         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5504         'PATH_MAX'.
5505
5506 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5507             Samuel Thibault  <samuel.thibault@gnu.org>
5508             Thomas Schwinge  <thomas@codesourcery.com>
5509
5510         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5511         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5512
5513 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5514
5515         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5516         (check_empty): Use "const char *".
5517
5518         * gnu-nat.c (gnu_nat_target::detach): Instead of
5519         'detach_inferior (pid)' call
5520         'detach_inferior (find_inferior_pid (pid))'.
5521
5522         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5523         'nat/fork-inferior.o'.
5524         * gnu-nat.c: #include "nat/fork-inferior.h".
5525
5526         * gnu-nat.c (gnu_nat_target::detach): Instead of
5527         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5528         * gnu-nat.h: #include "inf-child.h".
5529         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5530         'i386_gnu_nat_target::fetch_registers'.
5531         (gnu_store_registers): Rename/move to
5532         'i386_gnu_nat_target::store_registers'.
5533
5534         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5535         * gnu-nat.h (mach_thread_info): New function.
5536         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5537
5538         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5539
5540 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5541
5542         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5543
5544 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5545
5546         * windows-nat.c (windows_add_thread): Add new parameter
5547         "main_thread_p" with default value set to false.  Update
5548         function documentation as well as all callers.
5549         (windows_delete_thread): Likewise.
5550         (fake_create_process): Update call to windows_add_thread.
5551         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5552         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5553         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5554         call to windows_delete_thread.
5555
5556 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5557
5558         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5559
5560 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5561
5562         * symfile.c (find_separate_debug_file): Use canonical path of
5563         sysroot with child_path instead of gdb_sysroot if it is valid.
5564
5565 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5566
5567         * symfile.c (find_separate_debug_file): Use child_path to
5568         determine if an object file is under a sysroot.
5569
5570 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5571
5572         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5573         unittests/child-path-selftests.c.
5574         * common/pathstuff.c (child_path): New function.
5575         * common/pathstuff.h (child_path): New prototype.
5576         * unittests/child-path-selftests.c: New file.
5577
5578 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5579
5580         * symfile.c (find_separate_debug_file): Look for separate debug
5581         files in debug directories under the sysroot.
5582
5583 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5584
5585         * symtab.h (struct minimal_symbol data_p): New const method.
5586         (struct minimal_symbol text_p): Likewise.
5587         * symtab.c (output_source_filename): Use file name style
5588         to print file name.
5589         (print_symbol_info): Likewise.
5590         (print_msymbol_info): Use address style to print addresses.
5591         Use function name style to print executable text symbols.
5592         (expand_symtab_containing_pc): Use data_p.
5593         (find_pc_sect_compunit_symtab): Likewise.
5594
5595 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5596
5597         * breakpoint.c (describe_other_breakpoints): Use address style
5598         to print addresses.
5599         (say_where): Likewise.
5600
5601 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5602
5603         * ada-typeprint.c (print_func_type): Print function name
5604         style to print function name.
5605         * c-typeprint.c (c_print_type_1): Likewise.
5606
5607 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5608
5609         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5610         for execve.
5611
5612 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5613
5614         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5615         type_stack.
5616
5617 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5618
5619         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5620         TYPE_CODE_REF types.
5621
5622 2019-02-08  Jim Wilson  <jimw@sifive.com>
5623
5624         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5625         (riscv_linux_fregset): New.
5626         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5627
5628 2019-02-07  Tom Tromey  <tom@tromey.com>
5629
5630         * thread.c (thread_cancel_execution_command): Update.
5631         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5632         methods.
5633         (struct thread_fsm_ops): Remove.
5634         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5635         (thread_fsm_should_stop, thread_fsm_return_value)
5636         (thread_fsm_set_finished, thread_fsm_finished_p)
5637         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5638         Don't declare.
5639         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5640         * infrun.c (clear_proceed_status_thread)
5641         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5642         (print_stop_event): Update.
5643         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5644         Add constructor.
5645         (step_command_fsm_ops): Remove.
5646         (new_step_command_fsm): Remove.
5647         (step_1): Update.
5648         (step_command_fsm::should_stop): Rename from
5649         step_command_fsm_should_stop.
5650         (step_command_fsm::clean_up): Rename from
5651         step_command_fsm_clean_up.
5652         (step_command_fsm::do_async_reply_reason): Rename from
5653         step_command_fsm_async_reply_reason.
5654         (struct until_next_fsm): Inherit from thread_fsm.  Add
5655         constructor.
5656         (until_next_fsm_ops): Remove.
5657         (new_until_next_fsm): Remove.
5658         (until_next_fsm::should_stop): Rename from
5659         until_next_fsm_should_stop.
5660         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5661         (until_next_fsm::do_async_reply_reason): Rename from
5662         until_next_fsm_async_reply_reason.
5663         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5664         constructor.  Change type of breakpoint.
5665         (finish_command_fsm_ops): Remove.
5666         (new_finish_command_fsm): Remove.
5667         (finish_command_fsm::should_stop): Rename from
5668         finish_command_fsm_should_stop.
5669         (finish_command_fsm::clean_up): Rename from
5670         finish_command_fsm_clean_up.
5671         (finish_command_fsm::return_value): Rename from
5672         finish_command_fsm_return_value.
5673         (finish_command_fsm::do_async_reply_reason): Rename from
5674         finish_command_fsm_async_reply_reason.
5675         (finish_command): Update.
5676         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5677         Add constructor.
5678         (call_thread_fsm_ops): Remove.
5679         (call_thread_fsm::call_thread_fsm): Rename from
5680         new_call_thread_fsm.
5681         (call_thread_fsm::should_stop): Rename from
5682         call_thread_fsm_should_stop.
5683         (call_thread_fsm::should_notify_stop): Rename from
5684         call_thread_fsm_should_notify_stop.
5685         (run_inferior_call, call_function_by_hand_dummy): Update.
5686         * cli/cli-interp.c (should_print_stop_to_console): Update.
5687         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5688         Add constructor.  Change type of location_breakpoint,
5689         caller_breakpoint.
5690         (until_break_fsm_ops): Remove.
5691         (new_until_break_fsm): Remove.
5692         (until_break_fsm::should_stop): Rename from
5693         until_break_fsm_should_stop.
5694         (until_break_fsm::clean_up): Rename from
5695         until_break_fsm_clean_up.
5696         (until_break_fsm::do_async_reply_reason): Rename from
5697         until_break_fsm_async_reply_reason.
5698         (until_break_command): Update.
5699         * thread-fsm.c: Remove.
5700         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5701
5702 2019-02-07  Tom Tromey  <tom@tromey.com>
5703
5704         * yy-remap.h: Add include guard.
5705         * xtensa-tdep.h: Add include guard.
5706         * xcoffread.h: Rename include guard.
5707         * varobj-iter.h: Add include guard.
5708         * tui/tui.h: Rename include guard.
5709         * tui/tui-winsource.h: Rename include guard.
5710         * tui/tui-wingeneral.h: Rename include guard.
5711         * tui/tui-windata.h: Rename include guard.
5712         * tui/tui-win.h: Rename include guard.
5713         * tui/tui-stack.h: Rename include guard.
5714         * tui/tui-source.h: Rename include guard.
5715         * tui/tui-regs.h: Rename include guard.
5716         * tui/tui-out.h: Rename include guard.
5717         * tui/tui-layout.h: Rename include guard.
5718         * tui/tui-io.h: Rename include guard.
5719         * tui/tui-hooks.h: Rename include guard.
5720         * tui/tui-file.h: Rename include guard.
5721         * tui/tui-disasm.h: Rename include guard.
5722         * tui/tui-data.h: Rename include guard.
5723         * tui/tui-command.h: Rename include guard.
5724         * tic6x-tdep.h: Add include guard.
5725         * target/waitstatus.h: Rename include guard.
5726         * target/wait.h: Rename include guard.
5727         * target/target.h: Rename include guard.
5728         * target/resume.h: Rename include guard.
5729         * target-float.h: Rename include guard.
5730         * stabsread.h: Add include guard.
5731         * rs6000-tdep.h: Add include guard.
5732         * riscv-fbsd-tdep.h: Add include guard.
5733         * regformats/regdef.h: Rename include guard.
5734         * record.h: Rename include guard.
5735         * python/python.h: Rename include guard.
5736         * python/python-internal.h: Rename include guard.
5737         * python/py-stopevent.h: Rename include guard.
5738         * python/py-ref.h: Rename include guard.
5739         * python/py-record.h: Rename include guard.
5740         * python/py-record-full.h: Rename include guard.
5741         * python/py-record-btrace.h: Rename include guard.
5742         * python/py-instruction.h: Rename include guard.
5743         * python/py-events.h: Rename include guard.
5744         * python/py-event.h: Rename include guard.
5745         * procfs.h: Add include guard.
5746         * proc-utils.h: Add include guard.
5747         * p-lang.h: Add include guard.
5748         * or1k-tdep.h: Rename include guard.
5749         * observable.h: Rename include guard.
5750         * nto-tdep.h: Rename include guard.
5751         * nat/x86-linux.h: Rename include guard.
5752         * nat/x86-linux-dregs.h: Rename include guard.
5753         * nat/x86-gcc-cpuid.h: Add include guard.
5754         * nat/x86-dregs.h: Rename include guard.
5755         * nat/x86-cpuid.h: Rename include guard.
5756         * nat/ppc-linux.h: Rename include guard.
5757         * nat/mips-linux-watch.h: Rename include guard.
5758         * nat/linux-waitpid.h: Rename include guard.
5759         * nat/linux-ptrace.h: Rename include guard.
5760         * nat/linux-procfs.h: Rename include guard.
5761         * nat/linux-osdata.h: Rename include guard.
5762         * nat/linux-nat.h: Rename include guard.
5763         * nat/linux-namespaces.h: Rename include guard.
5764         * nat/linux-btrace.h: Rename include guard.
5765         * nat/glibc_thread_db.h: Rename include guard.
5766         * nat/gdb_thread_db.h: Rename include guard.
5767         * nat/gdb_ptrace.h: Rename include guard.
5768         * nat/fork-inferior.h: Rename include guard.
5769         * nat/amd64-linux-siginfo.h: Rename include guard.
5770         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5771         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5772         * nat/aarch64-linux.h: Rename include guard.
5773         * nat/aarch64-linux-hw-point.h: Rename include guard.
5774         * mn10300-tdep.h: Add include guard.
5775         * mips-linux-tdep.h: Add include guard.
5776         * mi/mi-parse.h: Rename include guard.
5777         * mi/mi-out.h: Rename include guard.
5778         * mi/mi-main.h: Rename include guard.
5779         * mi/mi-interp.h: Rename include guard.
5780         * mi/mi-getopt.h: Rename include guard.
5781         * mi/mi-console.h: Rename include guard.
5782         * mi/mi-common.h: Rename include guard.
5783         * mi/mi-cmds.h: Rename include guard.
5784         * mi/mi-cmd-break.h: Rename include guard.
5785         * m2-lang.h: Add include guard.
5786         * location.h: Rename include guard.
5787         * linux-record.h: Rename include guard.
5788         * linux-nat.h: Add include guard.
5789         * linux-fork.h: Add include guard.
5790         * i386-darwin-tdep.h: Rename include guard.
5791         * hppa-linux-offsets.h: Add include guard.
5792         * guile/guile.h: Rename include guard.
5793         * guile/guile-internal.h: Rename include guard.
5794         * gnu-nat.h: Rename include guard.
5795         * gdb-stabs.h: Rename include guard.
5796         * frv-tdep.h: Add include guard.
5797         * f-lang.h: Add include guard.
5798         * event-loop.h: Add include guard.
5799         * darwin-nat.h: Rename include guard.
5800         * cp-abi.h: Rename include guard.
5801         * config/sparc/nm-sol2.h: Rename include guard.
5802         * config/nm-nto.h: Rename include guard.
5803         * config/nm-linux.h: Add include guard.
5804         * config/i386/nm-i386gnu.h: Rename include guard.
5805         * config/djgpp/nl_types.h: Rename include guard.
5806         * config/djgpp/langinfo.h: Rename include guard.
5807         * compile/gcc-cp-plugin.h: Add include guard.
5808         * compile/gcc-c-plugin.h: Add include guard.
5809         * compile/compile.h: Rename include guard.
5810         * compile/compile-object-run.h: Rename include guard.
5811         * compile/compile-object-load.h: Rename include guard.
5812         * compile/compile-internal.h: Rename include guard.
5813         * compile/compile-cplus.h: Rename include guard.
5814         * compile/compile-c.h: Rename include guard.
5815         * common/xml-utils.h: Rename include guard.
5816         * common/x86-xstate.h: Rename include guard.
5817         * common/version.h: Rename include guard.
5818         * common/vec.h: Rename include guard.
5819         * common/tdesc.h: Rename include guard.
5820         * common/selftest.h: Rename include guard.
5821         * common/scoped_restore.h: Rename include guard.
5822         * common/scoped_mmap.h: Rename include guard.
5823         * common/scoped_fd.h: Rename include guard.
5824         * common/safe-iterator.h: Rename include guard.
5825         * common/run-time-clock.h: Rename include guard.
5826         * common/refcounted-object.h: Rename include guard.
5827         * common/queue.h: Rename include guard.
5828         * common/ptid.h: Rename include guard.
5829         * common/print-utils.h: Rename include guard.
5830         * common/preprocessor.h: Rename include guard.
5831         * common/pathstuff.h: Rename include guard.
5832         * common/observable.h: Rename include guard.
5833         * common/netstuff.h: Rename include guard.
5834         * common/job-control.h: Rename include guard.
5835         * common/host-defs.h: Rename include guard.
5836         * common/gdb_wait.h: Rename include guard.
5837         * common/gdb_vecs.h: Rename include guard.
5838         * common/gdb_unlinker.h: Rename include guard.
5839         * common/gdb_unique_ptr.h: Rename include guard.
5840         * common/gdb_tilde_expand.h: Rename include guard.
5841         * common/gdb_sys_time.h: Rename include guard.
5842         * common/gdb_string_view.h: Rename include guard.
5843         * common/gdb_splay_tree.h: Rename include guard.
5844         * common/gdb_setjmp.h: Rename include guard.
5845         * common/gdb_ref_ptr.h: Rename include guard.
5846         * common/gdb_optional.h: Rename include guard.
5847         * common/gdb_locale.h: Rename include guard.
5848         * common/gdb_assert.h: Rename include guard.
5849         * common/filtered-iterator.h: Rename include guard.
5850         * common/filestuff.h: Rename include guard.
5851         * common/fileio.h: Rename include guard.
5852         * common/environ.h: Rename include guard.
5853         * common/common-utils.h: Rename include guard.
5854         * common/common-types.h: Rename include guard.
5855         * common/common-regcache.h: Rename include guard.
5856         * common/common-inferior.h: Rename include guard.
5857         * common/common-gdbthread.h: Rename include guard.
5858         * common/common-exceptions.h: Rename include guard.
5859         * common/common-defs.h: Rename include guard.
5860         * common/common-debug.h: Rename include guard.
5861         * common/cleanups.h: Rename include guard.
5862         * common/buffer.h: Rename include guard.
5863         * common/btrace-common.h: Rename include guard.
5864         * common/break-common.h: Rename include guard.
5865         * cli/cli-utils.h: Rename include guard.
5866         * cli/cli-style.h: Rename include guard.
5867         * cli/cli-setshow.h: Rename include guard.
5868         * cli/cli-script.h: Rename include guard.
5869         * cli/cli-interp.h: Rename include guard.
5870         * cli/cli-decode.h: Rename include guard.
5871         * cli/cli-cmds.h: Rename include guard.
5872         * charset-list.h: Add include guard.
5873         * buildsym-legacy.h: Rename include guard.
5874         * bfin-tdep.h: Add include guard.
5875         * ax.h: Rename include guard.
5876         * arm-linux-tdep.h: Add include guard.
5877         * arm-fbsd-tdep.h: Add include guard.
5878         * arch/xtensa.h: Rename include guard.
5879         * arch/tic6x.h: Add include guard.
5880         * arch/i386.h: Add include guard.
5881         * arch/arm.h: Rename include guard.
5882         * arch/arm-linux.h: Rename include guard.
5883         * arch/arm-get-next-pcs.h: Rename include guard.
5884         * arch/amd64.h: Add include guard.
5885         * arch/aarch64-insn.h: Rename include guard.
5886         * arch-utils.h: Rename include guard.
5887         * annotate.h: Add include guard.
5888         * amd64-darwin-tdep.h: Rename include guard.
5889         * aarch64-linux-tdep.h: Add include guard.
5890         * aarch64-fbsd-tdep.h: Add include guard.
5891         * aarch32-linux-nat.h: Add include guard.
5892
5893 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5894
5895         * macrotab.c (macro_define_internal): New function that
5896         factorizes macro_define_object_internal and macro_define_function
5897         code.
5898         (macro_define_object_internal): Use macro_define_internal.
5899         (macro_define_function): Likewise.
5900
5901 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5902
5903         * macrocmd.c (extract_identifier): Return
5904         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5905         callers.
5906
5907 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5908
5909         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5910
5911 2019-02-05  Tom Tromey  <tom@tromey.com>
5912
5913         * target.c (target_stack::unpush): Move assertion earlier.
5914
5915 2019-01-30  Tom Tromey  <tom@tromey.com>
5916
5917         PR python/23615:
5918         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5919         (gdbpy_parse_and_eval): Likewise.
5920         * python/python-internal.h (gdbpy_allow_threads): New class.
5921
5922 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5923
5924         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5925         (aarch64_fbsd_fpregmap): Move earlier.
5926         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5927         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5928         instead of individual calls to trad_frame_set_reg_addr.
5929         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5930         earlier.
5931         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5932         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5933         instead of individual calls to trad_frame_set_reg_addr.
5934
5935 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5936
5937         * CONTRIBUTE: Replace contribution list with wiki link.
5938
5939 2019-01-25  Tom Tromey  <tom@tromey.com>
5940
5941         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5942
5943 2019-01-25  Tom Tromey  <tom@tromey.com>
5944
5945         * xtensa-linux-nat.c: Fix common/ includes.
5946         * xml-support.h: Fix common/ includes.
5947         * xml-support.c: Fix common/ includes.
5948         * x86-linux-nat.c: Fix common/ includes.
5949         * windows-nat.c: Fix common/ includes.
5950         * varobj.h: Fix common/ includes.
5951         * varobj.c: Fix common/ includes.
5952         * value.c: Fix common/ includes.
5953         * valops.c: Fix common/ includes.
5954         * utils.c: Fix common/ includes.
5955         * unittests/xml-utils-selftests.c: Fix common/ includes.
5956         * unittests/utils-selftests.c: Fix common/ includes.
5957         * unittests/unpack-selftests.c: Fix common/ includes.
5958         * unittests/tracepoint-selftests.c: Fix common/ includes.
5959         * unittests/style-selftests.c: Fix common/ includes.
5960         * unittests/string_view-selftests.c: Fix common/ includes.
5961         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5962         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5963         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5964         * unittests/rsp-low-selftests.c: Fix common/ includes.
5965         * unittests/parse-connection-spec-selftests.c: Fix common/
5966         includes.
5967         * unittests/optional-selftests.c: Fix common/ includes.
5968         * unittests/offset-type-selftests.c: Fix common/ includes.
5969         * unittests/observable-selftests.c: Fix common/ includes.
5970         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5971         * unittests/memrange-selftests.c: Fix common/ includes.
5972         * unittests/memory-map-selftests.c: Fix common/ includes.
5973         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5974         * unittests/function-view-selftests.c: Fix common/ includes.
5975         * unittests/environ-selftests.c: Fix common/ includes.
5976         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5977         * unittests/common-utils-selftests.c: Fix common/ includes.
5978         * unittests/cli-utils-selftests.c: Fix common/ includes.
5979         * unittests/array-view-selftests.c: Fix common/ includes.
5980         * ui-file.c: Fix common/ includes.
5981         * tui/tui-io.c: Fix common/ includes.
5982         * tracepoint.h: Fix common/ includes.
5983         * tracepoint.c: Fix common/ includes.
5984         * tracefile-tfile.c: Fix common/ includes.
5985         * top.h: Fix common/ includes.
5986         * top.c: Fix common/ includes.
5987         * thread.c: Fix common/ includes.
5988         * target/waitstatus.h: Fix common/ includes.
5989         * target/waitstatus.c: Fix common/ includes.
5990         * target.h: Fix common/ includes.
5991         * target.c: Fix common/ includes.
5992         * target-memory.c: Fix common/ includes.
5993         * target-descriptions.c: Fix common/ includes.
5994         * symtab.h: Fix common/ includes.
5995         * symfile.c: Fix common/ includes.
5996         * stap-probe.c: Fix common/ includes.
5997         * spu-linux-nat.c: Fix common/ includes.
5998         * sparc-nat.c: Fix common/ includes.
5999         * source.c: Fix common/ includes.
6000         * solib.c: Fix common/ includes.
6001         * solib-target.c: Fix common/ includes.
6002         * ser-unix.c: Fix common/ includes.
6003         * ser-tcp.c: Fix common/ includes.
6004         * ser-pipe.c: Fix common/ includes.
6005         * ser-base.c: Fix common/ includes.
6006         * selftest-arch.c: Fix common/ includes.
6007         * s12z-tdep.c: Fix common/ includes.
6008         * rust-exp.y: Fix common/ includes.
6009         * rs6000-aix-tdep.c: Fix common/ includes.
6010         * riscv-tdep.c: Fix common/ includes.
6011         * remote.c: Fix common/ includes.
6012         * remote-notif.h: Fix common/ includes.
6013         * remote-fileio.h: Fix common/ includes.
6014         * remote-fileio.c: Fix common/ includes.
6015         * regcache.h: Fix common/ includes.
6016         * regcache.c: Fix common/ includes.
6017         * record-btrace.c: Fix common/ includes.
6018         * python/python.c: Fix common/ includes.
6019         * python/py-type.c: Fix common/ includes.
6020         * python/py-inferior.c: Fix common/ includes.
6021         * progspace.h: Fix common/ includes.
6022         * producer.c: Fix common/ includes.
6023         * procfs.c: Fix common/ includes.
6024         * proc-api.c: Fix common/ includes.
6025         * printcmd.c: Fix common/ includes.
6026         * ppc-linux-nat.c: Fix common/ includes.
6027         * parser-defs.h: Fix common/ includes.
6028         * osdata.c: Fix common/ includes.
6029         * obsd-nat.c: Fix common/ includes.
6030         * nat/x86-linux.c: Fix common/ includes.
6031         * nat/x86-linux-dregs.c: Fix common/ includes.
6032         * nat/x86-dregs.h: Fix common/ includes.
6033         * nat/x86-dregs.c: Fix common/ includes.
6034         * nat/ppc-linux.c: Fix common/ includes.
6035         * nat/mips-linux-watch.h: Fix common/ includes.
6036         * nat/mips-linux-watch.c: Fix common/ includes.
6037         * nat/linux-waitpid.c: Fix common/ includes.
6038         * nat/linux-ptrace.h: Fix common/ includes.
6039         * nat/linux-ptrace.c: Fix common/ includes.
6040         * nat/linux-procfs.c: Fix common/ includes.
6041         * nat/linux-personality.c: Fix common/ includes.
6042         * nat/linux-osdata.c: Fix common/ includes.
6043         * nat/linux-namespaces.c: Fix common/ includes.
6044         * nat/linux-btrace.h: Fix common/ includes.
6045         * nat/linux-btrace.c: Fix common/ includes.
6046         * nat/fork-inferior.c: Fix common/ includes.
6047         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6048         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6049         * nat/aarch64-linux.c: Fix common/ includes.
6050         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6051         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6052         * namespace.h: Fix common/ includes.
6053         * mips-linux-tdep.c: Fix common/ includes.
6054         * minsyms.c: Fix common/ includes.
6055         * mi/mi-parse.h: Fix common/ includes.
6056         * mi/mi-main.c: Fix common/ includes.
6057         * mi/mi-cmd-env.c: Fix common/ includes.
6058         * memrange.h: Fix common/ includes.
6059         * memattr.c: Fix common/ includes.
6060         * maint.h: Fix common/ includes.
6061         * maint.c: Fix common/ includes.
6062         * main.c: Fix common/ includes.
6063         * machoread.c: Fix common/ includes.
6064         * location.c: Fix common/ includes.
6065         * linux-thread-db.c: Fix common/ includes.
6066         * linux-nat.c: Fix common/ includes.
6067         * linux-fork.c: Fix common/ includes.
6068         * inline-frame.c: Fix common/ includes.
6069         * infrun.c: Fix common/ includes.
6070         * inflow.c: Fix common/ includes.
6071         * inferior.h: Fix common/ includes.
6072         * inferior.c: Fix common/ includes.
6073         * infcmd.c: Fix common/ includes.
6074         * inf-ptrace.c: Fix common/ includes.
6075         * inf-child.c: Fix common/ includes.
6076         * ia64-linux-nat.c: Fix common/ includes.
6077         * i387-tdep.c: Fix common/ includes.
6078         * i386-tdep.c: Fix common/ includes.
6079         * i386-linux-tdep.c: Fix common/ includes.
6080         * i386-linux-nat.c: Fix common/ includes.
6081         * i386-go32-tdep.c: Fix common/ includes.
6082         * i386-fbsd-tdep.c: Fix common/ includes.
6083         * i386-fbsd-nat.c: Fix common/ includes.
6084         * guile/scm-type.c: Fix common/ includes.
6085         * guile/guile.c: Fix common/ includes.
6086         * go32-nat.c: Fix common/ includes.
6087         * gnu-nat.c: Fix common/ includes.
6088         * gdbthread.h: Fix common/ includes.
6089         * gdbarch-selftests.c: Fix common/ includes.
6090         * gdb_usleep.c: Fix common/ includes.
6091         * gdb_select.h: Fix common/ includes.
6092         * gdb_bfd.c: Fix common/ includes.
6093         * gcore.c: Fix common/ includes.
6094         * fork-child.c: Fix common/ includes.
6095         * findvar.c: Fix common/ includes.
6096         * fbsd-nat.c: Fix common/ includes.
6097         * event-top.c: Fix common/ includes.
6098         * event-loop.c: Fix common/ includes.
6099         * dwarf2read.c: Fix common/ includes.
6100         * dwarf2loc.c: Fix common/ includes.
6101         * dwarf2-frame.c: Fix common/ includes.
6102         * dwarf-index-cache.c: Fix common/ includes.
6103         * dtrace-probe.c: Fix common/ includes.
6104         * disasm-selftests.c: Fix common/ includes.
6105         * defs.h: Fix common/ includes.
6106         * csky-tdep.c: Fix common/ includes.
6107         * cp-valprint.c: Fix common/ includes.
6108         * cp-support.h: Fix common/ includes.
6109         * cp-support.c: Fix common/ includes.
6110         * corelow.c: Fix common/ includes.
6111         * completer.h: Fix common/ includes.
6112         * completer.c: Fix common/ includes.
6113         * compile/compile.c: Fix common/ includes.
6114         * compile/compile-loc2c.c: Fix common/ includes.
6115         * compile/compile-cplus-types.c: Fix common/ includes.
6116         * compile/compile-cplus-symbols.c: Fix common/ includes.
6117         * command.h: Fix common/ includes.
6118         * cli/cli-dump.c: Fix common/ includes.
6119         * cli/cli-cmds.c: Fix common/ includes.
6120         * charset.c: Fix common/ includes.
6121         * build-id.c: Fix common/ includes.
6122         * btrace.h: Fix common/ includes.
6123         * btrace.c: Fix common/ includes.
6124         * breakpoint.h: Fix common/ includes.
6125         * breakpoint.c: Fix common/ includes.
6126         * ax.h:
6127         (enum agent_op): Fix common/ includes.
6128         * ax-general.c (struct aop_map): Fix common/ includes.
6129         * ax-gdb.c: Fix common/ includes.
6130         * auxv.c: Fix common/ includes.
6131         * auto-load.c: Fix common/ includes.
6132         * arm-tdep.c: Fix common/ includes.
6133         * arch/riscv.c: Fix common/ includes.
6134         * arch/ppc-linux-common.c: Fix common/ includes.
6135         * arch/i386.c: Fix common/ includes.
6136         * arch/arm.c: Fix common/ includes.
6137         * arch/arm-linux.c: Fix common/ includes.
6138         * arch/arm-get-next-pcs.c: Fix common/ includes.
6139         * arch/amd64.c: Fix common/ includes.
6140         * arch/aarch64.c: Fix common/ includes.
6141         * arch/aarch64-insn.c: Fix common/ includes.
6142         * arch-utils.c: Fix common/ includes.
6143         * amd64-windows-tdep.c: Fix common/ includes.
6144         * amd64-tdep.c: Fix common/ includes.
6145         * amd64-sol2-tdep.c: Fix common/ includes.
6146         * amd64-obsd-tdep.c: Fix common/ includes.
6147         * amd64-nbsd-tdep.c: Fix common/ includes.
6148         * amd64-linux-tdep.c: Fix common/ includes.
6149         * amd64-linux-nat.c: Fix common/ includes.
6150         * amd64-fbsd-tdep.c: Fix common/ includes.
6151         * amd64-fbsd-nat.c: Fix common/ includes.
6152         * amd64-dicos-tdep.c: Fix common/ includes.
6153         * amd64-darwin-tdep.c: Fix common/ includes.
6154         * agent.c: Fix common/ includes.
6155         * ada-lang.h: Fix common/ includes.
6156         * ada-lang.c: Fix common/ includes.
6157         * aarch64-tdep.c: Fix common/ includes.
6158
6159 2019-01-25  Tom Tromey  <tom@tromey.com>
6160
6161         * common/create-version.sh: Use common/version.h.
6162
6163 2019-01-24  Pedro Alves  <palves@redhat.com>
6164
6165         * infrun.c (signal_stop, signal_print, signal_program)
6166         (signal_catch, signal_pass): Now arrays instead of pointers.
6167         (update_signals_program_target, do_target_resume)
6168         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6169         * linux-nat.c (linux_nat_target::pass_signals)
6170         (linux_nat_target::create_inferior, linux_nat_target::attach):
6171         Adjust.
6172         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6173         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6174         * procfs.c (procfs_target::pass_signals): Adjust.
6175         * record-full.c (record_full_target::resume): Adjust.
6176         * remote.c (remote_target::pass_signals)
6177         (remote_target::program_signals): Adjust.
6178         * target-debug.h (target_debug_print_signals): Now takes a
6179         gdb::array_view as parameter.  Adjust.
6180         * target.h (target_ops) <pass_signals, program_signals>: Replace
6181         pointer and length parameters with gdb::array_view.
6182         (target_pass_signals, target_program_signals): Likewise.
6183         * target-delegates.c: Regenerate.
6184
6185 2019-01-24  Pedro Alves  <palves@redhat.com>
6186
6187         * common/forward-scope-exit.h
6188         (forward_scope_exit::forward_scope_exit): Pass arguments to
6189         m_bind_function directly, instead of creating a std::bind and
6190         copying that.
6191
6192 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6193
6194         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6195         for static members.
6196         (pass_in_v_vfp_candidate): Likewise.
6197
6198 2019-01-23  Tom Tromey  <tom@tromey.com>
6199             Pedro Alves  <palves@redhat.com>
6200
6201         * regcache.c (class regcache_invalidator): Remove.
6202         (regcache::raw_write): Use make_scope_exit.
6203
6204 2019-01-23  Tom Tromey  <tom@tromey.com>
6205
6206         * ui-out.h (class ui_out_emit_type): Update comment.
6207
6208 2019-01-23  Tom Tromey  <tom@tromey.com>
6209
6210         * infrun.c (fetch_inferior_event): Update comment.
6211
6212 2019-01-23  Tom Tromey  <tom@tromey.com>
6213             Pedro Alves  <palves@redhat.com>
6214
6215         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6216         parameter.
6217         (fetch_inferior_event): Use SCOPE_EXIT.
6218
6219
6220 2019-01-23  Tom Tromey  <tom@tromey.com>
6221             Pedro Alves  <palves@redhat.com>
6222
6223         * infrun.c (disable_thread_events): Delete.
6224         (stop_all_threads): Use SCOPE_EXIT.
6225
6226 2019-01-23  Tom Tromey  <tom@tromey.com>
6227             Pedro Alves  <palves@redhat.com>
6228
6229         * symfile.c: Include forward-scope-exit.h.
6230         (clear_symtab_users_cleanup): Replace forward declaration with
6231         a FORWARD_SCOPE_EXIT.
6232         (syms_from_objfile_1): Use the forward_scope_exit and
6233         gdb::optional instead of cleanup_function.
6234         (reread_symbols): Use the forward_scope_exit instead of
6235         cleanup_function.
6236         (clear_symtab_users_cleanup): Remove function.
6237
6238 2019-01-23  Tom Tromey  <tom@tromey.com>
6239             Pedro Alves  <palves@redhat.com>
6240
6241         * linux-nat.c: Include scope-exit.h.
6242         (cleanup_target_stop): Remove.
6243         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6244         SCOPE_EXIT.
6245
6246 2019-01-23  Tom Tromey  <tom@tromey.com>
6247             Pedro Alves  <palves@redhat.com>
6248
6249         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6250         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6251
6252 2019-01-23  Tom Tromey  <tom@tromey.com>
6253             Andrew Burgess  <andrew.burgess@embecosm.com>
6254             Pedro Alves  <palves@redhat.com>
6255
6256         * infrun.c (fetch_inferior_event): Use scope_exit.
6257         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6258         * top.c (execute_command): Use scope_exit.
6259         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6260         * utils.c (do_bpstat_clear_actions_cleanup)
6261         (make_bpstat_clear_actions_cleanup): Remove.
6262
6263 2019-01-23  Tom Tromey  <tom@tromey.com>
6264             Pedro Alves  <palves@redhat.com>
6265
6266         * infrun.c: Include "common/scope-exit.h"
6267         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6268         (wait_for_inferior): Use SCOPE_EXIT.
6269         (fetch_inferior_event): Use scope_exit.
6270
6271 2019-01-23  Tom Tromey  <tom@tromey.com>
6272             Pedro Alves  <palves@redhat.com>
6273
6274         * breakpoint.c (create_breakpoint): Remove cleanup.
6275
6276 2019-01-23  Tom Tromey  <tom@tromey.com>
6277             Andrew Burgess  <andrew.burgess@embecosm.com>
6278             Pedro Alves  <palves@redhat.com>
6279
6280 2019-01-23  Pedro Alves  <palves@redhat.com>
6281
6282         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6283
6284 2019-01-23  Pedro Alves  <palves@redhat.com>
6285             Andrew Burgess  <andrew.burgess@embecosm.com>
6286
6287         * gdbthread.h: Include "common/forward-scope-exit.h".
6288         (scoped_finish_thread_state): Redefine custom class in terms of
6289         forward_scope_exit.
6290
6291 2019-01-23  Pedro Alves  <palves@redhat.com>
6292             Andrew Burgess  <andrew.burgess@embecosm.com>
6293
6294         * common/forward-scope-exit.h: New file.
6295
6296 2019-01-23  Pedro Alves  <palves@redhat.com>
6297             Andrew Burgess  <andrew.burgess@embecosm.com>
6298             Tom Tromey  <tom@tromey.com>
6299
6300         * common/scope-exit.h: New file.
6301
6302 2019-01-23  Pedro Alves  <palves@redhat.com>
6303
6304         * common/preprocessor.h (ESC): Rename to ...
6305         (ESC_PARENS): ... this.
6306         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6307         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6308
6309 2019-01-23  Tom Tromey  <tom@tromey.com>
6310
6311         * language.h (class scoped_switch_to_sym_language_if_auto):
6312         Initialize m_lang in both cases.
6313
6314 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6315
6316         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6317         with XCNEW.
6318
6319 2019-01-22  Tom Tromey  <tom@tromey.com>
6320
6321         * corelow.c: Do not include sys/file.h.
6322
6323 2019-01-22  Tom Tromey  <tom@tromey.com>
6324
6325         * tui/tui-wingeneral.h: Include gdb_curses.h.
6326
6327 2019-01-22  Tom Tromey  <tom@tromey.com>
6328
6329         * source-cache.h (class source_cache) <get_source_lines,
6330         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6331
6332 2019-01-22  Tom Tromey  <tom@tromey.com>
6333
6334         * remote-fileio.h (struct remote_target): Declare.
6335
6336 2019-01-22  Tom Tromey  <tom@tromey.com>
6337
6338         * python/py-arch.c: Do not include py-ref.h.
6339         * python/py-bpevent.c: Do not include py-ref.h.
6340         * python/py-cmd.c: Do not include py-ref.h.
6341         * python/py-continueevent.c: Do not include py-ref.h.
6342         * python/py-event.h: Do not include py-ref.h.
6343         * python/py-evtregistry.c: Do not include py-ref.h.
6344         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6345         * python/py-frame.c: Do not include py-ref.h.
6346         * python/py-framefilter.c: Do not include py-ref.h.
6347         * python/py-function.c: Do not include py-ref.h.
6348         * python/py-infevents.c: Do not include py-ref.h.
6349         * python/py-linetable.c: Do not include py-ref.h.
6350         * python/py-objfile.c: Do not include py-ref.h.
6351         * python/py-param.c: Do not include py-ref.h.
6352         * python/py-prettyprint.c: Do not include py-ref.h.
6353         * python/py-progspace.c: Do not include py-ref.h.
6354         * python/py-symbol.c: Do not include py-ref.h.
6355         * python/py-symtab.c: Do not include py-ref.h.
6356         * python/py-type.c: Do not include py-ref.h.
6357         * python/py-unwind.c: Do not include py-ref.h.
6358         * python/py-utils.c: Do not include py-ref.h.
6359         * python/py-value.c: Do not include py-ref.h.
6360         * python/py-varobj.c: Do not include py-ref.h.
6361         * python/py-xmethods.c: Do not include py-ref.h.
6362         * python/python.c: Do not include py-ref.h.
6363         * varobj.c: Do not include py-ref.h.
6364
6365 2019-01-22  Tom Tromey  <tom@tromey.com>
6366
6367         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6368         keyword for bcache.
6369
6370 2019-01-22  Tom Tromey  <tom@tromey.com>
6371
6372         * compile/compile-cplus-types.c: Remove a comment by #include.
6373
6374 2019-01-22  Tom Tromey  <tom@tromey.com>
6375
6376         * compile/gcc-c-plugin.h: Include compile-internal.h.
6377
6378 2019-01-22  Tom Tromey  <tom@tromey.com>
6379
6380         * stabsread.c (EXTERN): Do not define.
6381         (symnum, next_symbol_text_func, processing_gcc_compilation)
6382         (within_function, global_sym_chain, global_stabs)
6383         (previous_stab_code, this_object_header_files)
6384         (n_this_object_header_files)
6385         (n_allocated_this_object_header_files): Define.
6386         * stabsread.h (EXTERN): Never define.  Use "extern".
6387
6388 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6389
6390         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6391         history_value.
6392
6393 2019-01-21  Tom Tromey  <tom@tromey.com>
6394
6395         * ui-out.c: Fix includes.
6396         * tui/tui-source.c: Fix includes.
6397         * target.c: Fix includes.
6398         * remote.c: Fix includes.
6399         * regcache.c: Fix includes.
6400         * python/py-block.c: Fix includes.
6401         * printcmd.c: Fix includes.
6402         * or1k-tdep.c: Fix includes.
6403         * mi/mi-main.c: Fix includes.
6404         * m32r-tdep.c: Fix includes.
6405         * csky-tdep.c: Fix includes.
6406         * compile/compile-cplus-types.c: Fix includes.
6407         * cli/cli-interp.c: Fix includes.
6408
6409 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6410
6411         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6412         for padding.
6413
6414 2019-01-16  Tom Tromey  <tom@tromey.com>
6415
6416         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6417         earlier.
6418         (struct objfile) <msymbols_range>: Move from top level.
6419         <msymbols>: New method.
6420         (class objfile_msymbols): Remove.
6421         * symtab.c (default_collect_symbol_completion_matches_break_on):
6422         Update.
6423         * symmisc.c (dump_msymbols): Update.
6424         * stabsread.c (scan_file_globals): Update.
6425         * objc-lang.c (info_selectors_command, info_classes_command)
6426         (find_methods): Update.
6427         * minsyms.c (find_solib_trampoline_target): Update.
6428         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6429         * coffread.c (coff_symfile_read): Update.
6430         * ada-lang.c (ada_lookup_simple_minsym)
6431         (ada_collect_symbol_completion_matches): Update.
6432
6433 2019-01-16  Tom Tromey  <tom@tromey.com>
6434
6435         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6436         type.  Remove no-argument constructor.
6437         <iterator::operator++>: Simplify.
6438         <begin>: Update.
6439         <end>: Use minimal_symbol_count.
6440
6441 2019-01-16  Tom Tromey  <tom@tromey.com>
6442
6443         * objfiles.h (struct objfile) <psymtabs>: New method.
6444         (class objfile_psymtabs): Remove.
6445         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6446         typedef.
6447         <range>: New method.
6448         (require_partial_symbols): Change return type.
6449         * psymtab.c (require_partial_symbols)
6450         (psym_expand_symtabs_matching): Update.
6451         * mdebugread.c (parse_partial_symbols): Update.
6452         * dbxread.c (dbx_end_psymtab): Update.
6453
6454 2019-01-15  Tom Tromey  <tom@tromey.com>
6455
6456         * symtab.c (lookup_objfile_from_block)
6457         (lookup_symbol_in_objfile_symtabs)
6458         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6459         (find_line_symtab, info_sources_command)
6460         (default_collect_symbol_completion_matches_break_on)
6461         (make_source_files_completion_list): Update.
6462         * symmisc.c (print_objfile_statistics, dump_objfile)
6463         (maintenance_print_symbols, maintenance_info_symtabs)
6464         (maintenance_check_symtabs, maintenance_info_line_tables):
6465         Update.
6466         * source.c (select_source_symtab)
6467         (forget_cached_source_info_for_objfile): Update.
6468         * objfiles.h (class objfile_compunits): Remove.
6469         (struct objfile) <compunits_range>: New typedef.
6470         (compunits): New method.
6471         * objfiles.c (objfile_relocate1): Update.
6472         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6473         * maint.c (count_symtabs_and_blocks): Update.
6474         * linespec.c (iterate_over_all_matching_symtabs): Update.
6475         * cp-support.c (add_symbol_overload_list_qualified): Update.
6476         * coffread.c (coff_symtab_read): Update.
6477         * ada-lang.c (add_nonlocal_symbols)
6478         (ada_collect_symbol_completion_matches)
6479         (ada_add_global_exceptions): Update.
6480
6481 2019-01-15  Tom Tromey  <tom@tromey.com>
6482
6483         * progspace.h (program_space) <objfiles_safe_range>: New
6484         typedef.
6485         <objfiles_safe>: New method.
6486         * objfiles.h (class all_objfiles_safe): Remove.
6487         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6488         * jit.c (jit_inferior_exit_hook): Update.
6489
6490 2019-01-17  Tom Tromey  <tom@tromey.com>
6491
6492         * progspace.h (program_space) <objfiles_range>: New typedef.
6493         <objfiles>: New method.
6494         <objfiles_head>: Rename from objfiles.
6495         (object_files): Update.
6496         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6497         * guile/scm-pretty-print.c
6498         (ppscm_find_pretty_printer_from_objfiles): Update.
6499         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6500         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6501         Update.
6502         * python/py-progspace.c (pspy_get_objfiles): Update.
6503         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6504         Update.
6505         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6506         (objfpy_lookup_objfile_by_build_id): Update.
6507         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6508         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6509         Update.
6510         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6511         (expand_symtab_containing_pc, lookup_objfile_from_block)
6512         (lookup_static_symbol, basic_lookup_transparent_type)
6513         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6514         (find_line_symtab, info_sources_command)
6515         (default_collect_symbol_completion_matches_break_on)
6516         (make_source_files_completion_list, find_main_name): Update.
6517         * symmisc.c (print_symbol_bcache_statistics)
6518         (print_objfile_statistics, maintenance_print_symbols)
6519         (maintenance_print_msymbols, maintenance_print_objfiles)
6520         (maintenance_info_symtabs, maintenance_check_symtabs)
6521         (maintenance_expand_symtabs, maintenance_info_line_tables):
6522         Update.
6523         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6524         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6525         (map_overlay_command, unmap_overlay_command)
6526         (simple_overlay_update, expand_symtabs_matching)
6527         (map_symbol_filenames): Update.
6528         * symfile-debug.c (set_debug_symfile): Update.
6529         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6530         Update.
6531         * source.c (select_source_symtab, forget_cached_source_info):
6532         Update.
6533         * solib.c (solib_read_symbols): Update.
6534         * solib-spu.c (append_ocl_sos): Update.
6535         * psymtab.c (maintenance_print_psymbols)
6536         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6537         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6538         * printcmd.c (info_symbol_command): Update.
6539         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6540         Update.
6541         * objfiles.h (class all_objfiles): Remove.
6542         * objfiles.c (have_partial_symbols, have_full_symbols)
6543         (have_minimal_symbols, qsort_cmp, update_section_map)
6544         (shared_objfile_contains_address_p)
6545         (default_iterate_over_objfiles_in_search_order): Update.
6546         * objc-lang.c (info_selectors_command, info_classes_command)
6547         (find_methods): Update.
6548         * minsyms.c (find_solib_trampoline_target): Update.
6549         * maint.c (maintenance_info_sections)
6550         (maintenance_translate_address, count_symtabs_and_blocks):
6551         Update.
6552         * main.c (captured_main_1): Update.
6553         * linux-thread-db.c (try_thread_db_load_from_pdir)
6554         (has_libpthread): Update.
6555         * linespec.c (iterate_over_all_matching_symtabs)
6556         (search_minsyms_for_name): Update.
6557         * jit.c (jit_find_objf_with_entry_addr): Update.
6558         * hppa-tdep.c (find_unwind_entry)
6559         (hppa_lookup_stub_minimal_symbol): Update.
6560         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6561         Update.
6562         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6563         (elf_gnu_ifunc_resolve_by_got): Update.
6564         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6565         * dwarf-index-write.c (save_gdb_index_command): Update.
6566         * cp-support.c (add_symbol_overload_list_qualified): Update.
6567         * breakpoint.c (create_overlay_event_breakpoint)
6568         (create_longjmp_master_breakpoint)
6569         (create_std_terminate_master_breakpoint)
6570         (create_exception_master_breakpoint): Update.
6571         * blockframe.c (find_pc_partial_function): Update.
6572         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6573         (ada_collect_symbol_completion_matches)
6574         (ada_add_global_exceptions): Update.
6575
6576 2019-01-17  Tom Tromey  <tom@tromey.com>
6577
6578         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6579         declare VEC.
6580         (solib_target_parse_libraries): Change return type.
6581         (library_list_start_segment, library_list_start_section)
6582         (library_list_end_library, library_list_start_library); Update.
6583         (solib_target_free_library_list): Remove.
6584         (solib_target_parse_libraries): Remove cleanup.  Change return
6585         type.
6586         (solib_target_current_sos): Update.
6587
6588 2019-01-17  Tom Tromey  <tromey@bapiya>
6589
6590         * valprint.c: Replace "the the" with "the".
6591         * symtab.c: Replace "the the" with "the".
6592         * solib.c: Replace "the the" with "the".
6593         * solib-dsbt.c: Replace "the the" with "the".
6594         * linespec.c: Replace "the the" with "the".
6595         * dwarf2loc.h: Replace "the the" with "the".
6596         * amd64-windows-tdep.c: Replace "the the" with "the".
6597         * aarch64-tdep.c: Replace "the the" with "the".
6598
6599 2019-01-16  Keith Seitz  <keiths@redhat.com>
6600
6601         PR gdb/23773
6602         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6603         <builder>: Rename to ..
6604         <m_builder>: ... this and make private.
6605         (dwarf2_cu::get_builder): New method.  Change all users of
6606         `builder' to use this method.
6607         (dwarf2_start_symtab): Move to ...
6608         (dwarf2_cu::start_symtab): ... here.  Update all callers
6609         (setup_type_unit_groups): Move to ...
6610         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6611         callers.
6612         (dwarf2_cu::reset_builder): New method.
6613         (process_full_compunit, process_full_type_unit): Use
6614         dwarf2_cu::reset_builder.
6615         (follow_die_offset): Record the ancestor CU if it is different
6616         from the followed DIE's CU.
6617         (follow_die_sig_1): Likewise.
6618
6619 2019-01-15  Tom Tromey  <tom@tromey.com>
6620
6621         * remote.c (class remote_state) <buf>: Now a char_vector.
6622         <buf_size>: Remove.
6623         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6624         parameter.
6625         (remote_target::getpkt_or_notif_sane_1)
6626         (remote_target::getpkt_sane)
6627         (remote_target::getpkt_or_notif_sane): Likewise.
6628         (class remote_target) <putpkt>: New overload.
6629         (remote_target::read_frame): Change type of "buf_p".  Remove
6630         sizeof_p parameter.
6631         (packet_ok): New overload.
6632         (packet_check_result): New overload.
6633         Update all uses.
6634
6635 2019-01-14  Tom Tromey  <tom@tromey.com>
6636
6637         * remote-notif.c (handle_notification, remote_notif_ack)
6638         (remote_notif_parse): Make "buf" const.
6639         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6640         const.
6641         (remote_notif_parse, remote_notif_ack, handle_notification):
6642         Likewise.
6643         * remote.c (remote_notif_stop_parse): Make "buf" const.
6644         (remote_target::remote_parse_stop_reply): Make "buf" const.
6645         (remote_notif_stop_ack): Make "buf" const.
6646
6647 2019-01-14  Tom Tromey  <tom@tromey.com>
6648
6649         * remote.c (remote_console_output): Make parameter const.
6650
6651 2019-01-14  Tom Tromey  <tom@tromey.com>
6652
6653         * target-debug.h (target_debug_print_signals): Constify.
6654         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6655         * procfs.c (procfs_target::pass_signals): Update.
6656         * linux-nat.c (linux_nat_target::pass_signals): Update.
6657         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6658         * target-delegates.c: Rebuild.
6659         * remote.c (remote_target::program_signals): Update.
6660         (remote_target::pass_signals): Update.
6661         * target.c (target_pass_signals): Constify argument.
6662         (target_program_signals): Likewise.
6663         * target.h (struct target_ops) <pass_signals, program_signals>:
6664         Constify argument.
6665         (target_pass_signals, target_program_signals): Constify argument.
6666
6667 2019-01-14  Tom Tromey  <tom@tromey.com>
6668
6669         PR tui/28819:
6670         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6671
6672 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6673
6674         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6675         field.
6676         * rs6000-tdep.c: Include reggroups.h.
6677         (IS_V_ALIAS_PSEUDOREG): Define.
6678         (rs6000_register_name): Return names for the "vX" aliases.
6679         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6680         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6681         aliases.  Call default_register_reggroup_p for all other
6682         pseudo-registers.
6683         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6684         New functions.
6685         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6686         Handle "vX" aliases.
6687         (v_alias_pseudo_register_collect): New function.
6688         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6689         (rs6000_gdbarch_init): Initialize "vX" aliases as
6690         pseudo-registers.  Restore registration of
6691         rs6000_pseudo_register_reggroup_p with
6692         set_tdesc_pseudo_register_reggroup_p.
6693
6694 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6695
6696         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6697         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6698         set_gdbarch_num_pseudo_regs.
6699
6700 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6701
6702         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6703         Remove arg prefixname, add do_set and do_show.
6704         Add member functions set_list and show_list.
6705         * cli/cli-style.c (class cli_style_option): Update accordingly.
6706         (style_set_list): Move to file scope.
6707         (style_show_list): Likewise.
6708         (set_style): Call help_list.
6709         (show_style): Call cmd_show_list.
6710         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6711         Update to use the new macro.
6712
6713 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6714
6715         * ada-lang.c (_initialize_ada_language): Expand the help text
6716         for the "catch exception" command.
6717
6718 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6719
6720         * symtab.c (matching_obj_sections): Initialize obj,
6721         declare it closer to its usage.
6722
6723 2019-01-10  Tom Tromey  <tom@tromey.com>
6724
6725         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6726         (basic_inf_threads_range): Remove.
6727         (inf_threads_range, inf_non_exited_threads_range)
6728         (safe_inf_threads_range): Use next_adapter.
6729
6730 2019-01-10  Keith Seitz  <keiths@redhat.com>
6731
6732         PR gdb/23712
6733         PR symtab/23010
6734         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6735         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6736
6737 2019-01-10  Keith Seitz  <keiths@redhat.com>
6738
6739         PR gdb/23712
6740         PR symtab/23010
6741         * dictionary.c (pending_to_vector): Remove.
6742         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6743         Remove _1 suffix, replacing functions of the same name.  Update
6744         all callers.
6745         (dict_create_hashed, dict_create_hashed_expandable)
6746         (dict_create_linear, dict_create_linear_expandable, dict_free)
6747         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6748         Make functions static.
6749
6750 2019-01-10  Keith Seitz  <keiths@redhat.com>
6751
6752         PR gdb/23712
6753         PR symtab/23010
6754         * dictionary.h (struct dictionary): Replace declaration with
6755         multidictionary.
6756         (dict_create_hashed, dict_create_hashed_expandable)
6757         (dict_create_linear, dict_create_linear_expandable)
6758         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6759         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6760         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6761         taking multidictionary argument.
6762         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6763         * block.h (struct block) <dict>: Change to multidictionary
6764         and rename `multidict'.
6765         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6766         symmisc.c: Update all dictionary references to multidictionary.
6767
6768 2019-01-10  Keith Seitz  <keiths@redhat.com>
6769
6770         PR gdb/23712
6771         PR symtab/23010
6772         * dictionary.c: Include unordered_map.
6773         (pending_to_vector): New function.
6774         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6775         Rewrite the non-"_1" functions to take vector instead
6776         of linked list.
6777         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6778         "new" _1 versions of the same name.
6779         (multidictionary): Define.
6780         (std::hash<enum language): New definition.
6781         (collate_pending_symbols_by_language, mdict_create_hashed)
6782         (mdict_create_hashed_expandable, mdict_create_linear)
6783         (mdict_create_linear_expandable, mdict_free)
6784         (find_language_dictionary, create_new_language_dictionary)
6785         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6786         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6787         (mdict_size, mdict_empty): New functions.
6788         * dictionary.h (mdict_iterator): Define.
6789
6790 2019-01-10  Pedro Alves  <palves@redhat.com>
6791
6792         * breakpoint.c (read_uploaded_action)
6793         (create_tracepoint_from_upload): Adjust to use
6794         gdb::unique_xmalloc_ptr.
6795         * ctf.c (ctf_write_uploaded_tp):
6796         (SET_ARRAY_FIELD): Use emplace_back.
6797         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6798         * tracefile-tfile.c (tfile_write_uploaded_tp):
6799         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6800         gdb::unique_xmalloc_ptr.
6801         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6802         at_string, cond_string, cmd_strings>: Replace char pointers
6803         with gdb::unique_xmalloc_ptr.
6804
6805 2019-01-10  Pedro Alves  <palves@redhat.com>
6806
6807         * solib-target.c (library_list_start_library): Don't xstrdup name.
6808
6809 2019-01-10  Pedro Alves  <palves@redhat.com>
6810
6811         * mdebugread.c (parse_partial_symbols): Use
6812         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6813
6814 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6815
6816         * linux-fork.c (scoped_switch_fork_info)
6817         <~scoped_switch_fork_info>: Fix incorrect variable name.
6818
6819 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6820
6821         * linux-fork.c (scoped_switch_fork_info)
6822         <scoped_switch_fork_info>: Make explicit.
6823         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6824
6825 2019-01-10  Tom Tromey  <tom@tromey.com>
6826
6827         * objfiles.h (objfile::reset_psymtabs): Update.
6828         * objfiles.c (objfile::objfile): Update.
6829         * psymtab.h (psymtab_storage::obstack): Update.
6830         (psymtab_storage::m_obstack): Use gdb::optional.
6831         (class psymtab_storage): Update comment.  Remove objfile
6832         parameter.
6833         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6834
6835 2019-01-10  Tom Tromey  <tom@tromey.com>
6836
6837         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6838         <free_psymtabs>: Now private.
6839         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6840         (allocate_psymtab): Use new method.
6841
6842 2019-01-10  Tom Tromey  <tom@tromey.com>
6843
6844         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6845         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6846         * mdebugread.c (parse_partial_symbols): Use
6847         allocate_dependencies.
6848         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6849         allocate_dependencies.
6850         (process_psymtab_comp_unit_reader)
6851         (build_type_psymtab_dependencies): Likewise.
6852         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6853
6854 2019-01-10  Tom Tromey  <tom@tromey.com>
6855
6856         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6857         PSYMBOL_SET_LANGUAGE.
6858         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6859
6860 2019-01-10  Tom Tromey  <tom@tromey.com>
6861
6862         * psymtab.h (psymtab_storage::obstack): New method.
6863         <m_obstack>: Rename from obstack; now private.
6864         * psymtab.c (psymtab_storage): Update.
6865         * dwarf2read.c (create_addrmap_from_index)
6866         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6867         Update.
6868
6869 2019-01-10  Tom Tromey  <tom@tromey.com>
6870
6871         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6872         * objfiles.h (objfile::reset_psymtabs): New method.
6873
6874 2019-01-10  Tom Tromey  <tom@tromey.com>
6875
6876         * symmisc.c (print_symbol_bcache_statistics): Update.
6877         (print_objfile_statistics): Update.
6878         * symfile.c (reread_symbols): Update.
6879         * psymtab.h (class psymtab_storage): New.
6880         * psymtab.c (psymtab_storage): New constructor.
6881         (~psymtab_storage): New destructor.
6882         (require_partial_symbols): Update.
6883         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6884         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6885         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6886         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6887         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6888         (start_psymtab_common, end_psymtab_common)
6889         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6890         (allocate_psymtab): Update.
6891         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6892         Update.
6893         (dump_psymtab_addrmap, maintenance_print_psymbols)
6894         (maintenance_check_psymtabs): Update.
6895         (class objfile_psymtabs): Move to objfiles.h.
6896         * psympriv.h (discard_psymtab): Now inline.
6897         (psymtab_discarder::psymtab_discarder): Update.
6898         (psymtab_discarder::~psymtab_discarder): Update.
6899         (ALL_OBJFILE_PSYMTABS): Rewrite.
6900         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6901         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6902         Remove fields.
6903         <partial_symtabs>: New field.
6904         (class objfile_psymtabs): Move from psymtab.h.  Update.
6905         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6906         psymbol_cache.
6907         (objfile::~objfile): Don't destroy psymbol_cache.
6908         * mdebugread.c (parse_partial_symbols): Update.
6909         * dwarf2read.c (create_addrmap_from_index)
6910         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6911         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6912         (add_partial_subprogram, dwarf2_ranges_read): Update.
6913         * dwarf-index-write.c (write_address_map)
6914         (write_one_signatured_type, recursively_write_psymbols)
6915         (class debug_names, class debug_names, write_psymtabs_to_index):
6916         Update.
6917
6918 2019-01-10  Tom Tromey  <tom@tromey.com>
6919
6920         * symtab.h (SYMBOL_SET_NAMES): Update.
6921         (symbol_set_names): Update.
6922         (MSYMBOL_SET_NAMES): Update.
6923         * symtab.c (symbol_set_names): Change argument to be an
6924         objfile_per_bfd_storage.
6925         * psymtab.c (add_psymbol_to_bcache): Update.
6926         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6927
6928 2019-01-10  Tom Tromey  <tom@tromey.com>
6929
6930         * symtab.c (create_demangled_names_hash): Change argument to be an
6931         objfile_per_bfd_storage.
6932         (symbol_set_names): Update.
6933
6934 2019-01-10  Tom Tromey  <tom@tromey.com>
6935
6936         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6937         init_psymbol_list.
6938         * psymtab.c (init_psymbol_list): Do nothing if already called.
6939         * psympriv.h (init_psymbol_list): Add comment.
6940         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6941         init_psymbol_list.
6942         * dbxread.c (dbx_symfile_read): Unconditionally call
6943         init_psymbol_list.
6944
6945 2019-01-10  Tom Tromey  <tom@tromey.com>
6946
6947         * xcoffread.c (scan_xcoff_symtab): Update.
6948         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6949         "where".
6950         * mdebugread.c (parse_partial_symbols)
6951         (handle_psymbol_enumerators): Update.
6952         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6953         * dbxread.c (read_dbx_symtab): Update.
6954         * psympriv.h (psymbol_placement): New enum.
6955         (add_psymbol_to_list): Update.
6956
6957 2019-01-10  Tom Tromey  <tom@tromey.com>
6958
6959         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6960         static_psymbols parameters.
6961         (scan_xcoff_symtab): Update.
6962         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6963         static_psymbols parameters.
6964         * psympriv.h (start_psymtab_common): Update.
6965         * mdebugread.c (parse_partial_symbols): Update.
6966         * dwarf2read.c (create_partial_symtab): Update.
6967         * dbxread.c (read_dbx_symtab): Update.
6968         (start_psymtab): Remove global_psymbols and static_psymbols
6969         parameters.
6970
6971 2019-01-10  Tom Tromey  <tom@tromey.com>
6972
6973         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6974         * psymtab.c (allocate_psymtab): Add comment.
6975         * psympriv.h (allocate_psymtab): Add comment.
6976         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6977         initializations.
6978         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6979
6980 2019-01-10  Tom Tromey  <tom@tromey.com>
6981
6982         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6983         Don't declare.
6984         * mipsread.c: Include mdebugread.h.
6985         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6986         Declare.
6987         * elfread.c: Include mdebugread.h.
6988
6989 2019-01-09  Tom Tromey  <tom@tromey.com>
6990
6991         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6992         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6993         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6994         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6995         (psym_lookup_symbol, psym_find_last_source_symtab)
6996         (psym_forget_cached_source_info, psym_print_stats)
6997         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6998         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6999         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7000         (psym_find_compunit_symtab_by_address)
7001         (maintenance_print_psymbols, maintenance_info_psymtabs)
7002         (maintenance_check_psymtabs): Use ranged for.
7003         * psymtab.h (class objfile_psymtabs): New.
7004         (require_partial_symbols): Return objfile_psymtabs.
7005         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7006
7007 2019-01-09  Tom Tromey  <tom@tromey.com>
7008
7009         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7010         (find_pc_mapped_section, list_overlays_command)
7011         (map_overlay_command, unmap_overlay_command)
7012         (simple_overlay_update): Use all_objfiles.
7013         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7014         * printcmd.c (info_symbol_command): Use all_objfiles.
7015         * objfiles.h (ALL_OBJSECTIONS): Remove.
7016         * maint.c (maintenance_translate_address): Use all_objfiles.
7017         * gcore.c (gcore_create_callback): Use all_objfiles.
7018         (objfile_find_memory_regions): Likewise.
7019
7020 2019-01-09  Tom Tromey  <tom@tromey.com>
7021
7022         * symtab.c (find_line_symtab, info_sources_command)
7023         (make_source_files_completion_list): Use objfile_compunits.
7024         * source.c (select_source_symtab): Use objfile_compunits.
7025         * objfiles.h (struct objfile): Update comment.
7026         (ALL_OBJFILES): Remove.
7027         (ALL_FILETABS): Remove.
7028         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7029         objfile_compunits.
7030
7031 2019-01-09  Tom Tromey  <tom@tromey.com>
7032
7033         * symmisc.c (print_objfile_statistics, dump_objfile)
7034         (maintenance_print_symbols): Use compunit_filetabs.
7035         * source.c (forget_cached_source_info_for_objfile): Use
7036         compunit_filetabs.
7037         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7038         (ALL_FILETABS): Use compunit_filetabs.
7039         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7040         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7041
7042 2019-01-09  Tom Tromey  <tom@tromey.com>
7043
7044         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7045         (compunit_filetabs): New.
7046         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7047         compunit_filetabs.
7048         (info_sources_command, make_source_files_completion_list): Remove
7049         declaration.
7050         * symmisc.c (print_objfile_statistics, dump_objfile)
7051         (maintenance_print_symbols): Remove declaration.
7052         (maintenance_info_symtabs): Use compunit_filetabs.
7053         (maintenance_info_line_tables): Likewise.
7054         * source.c (select_source_symtab): Change local variable name.
7055         (forget_cached_source_info_for_objfile): Remove declaration.
7056         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7057         * objfiles.c (objfile_relocate1): Remove declaration.
7058         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7059         declaration.
7060         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7061         * coffread.c (coff_symtab_read): Remove declaration.
7062         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7063         compunit_filetabs.
7064
7065 2019-01-09  Tom Tromey  <tom@tromey.com>
7066
7067         * symtab.c (lookup_objfile_from_block)
7068         (find_pc_sect_compunit_symtab, search_symbols)
7069         (default_collect_symbol_completion_matches_break_on): Use
7070         objfile_compunits.
7071         * objfiles.h (ALL_COMPUNITS): Remove.
7072         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7073         * cp-support.c (add_symbol_overload_list_qualified): Use
7074         objfile_compunits.
7075         * ada-lang.c (ada_collect_symbol_completion_matches)
7076         (ada_add_global_exceptions): Use objfile_compunits.
7077
7078 2019-01-09  Tom Tromey  <tom@tromey.com>
7079
7080         * source.c (select_source_symtab)
7081         (forget_cached_source_info_for_objfile): Remove declaration.
7082         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7083         declaration.
7084         * maint.c (count_symtabs_and_blocks): Remove declaration.
7085         * cp-support.c (add_symbol_overload_list_qualified): Remove
7086         declaration.
7087         * coffread.c (coff_symtab_read): Remove declaration.
7088         * symtab.c (lookup_symbol_in_objfile_symtabs)
7089         (basic_lookup_transparent_type_1): Use objfile_compunits.
7090         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7091         (info_sources_command, search_symbols)
7092         (default_collect_symbol_completion_matches_break_on)
7093         (make_source_files_completion_list): Remove declaration.
7094         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7095         (ada_collect_symbol_completion_matches)
7096         (ada_add_global_exceptions): Remove declaration.
7097         * linespec.c (iterate_over_all_matching_symtabs): Use
7098         objfile_compunits.
7099         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7100         (class objfile_compunits): New.
7101         (ALL_COMPUNITS): Use objfile_compunits.
7102         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7103         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7104         objfile_compunits.
7105         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7106
7107 2019-01-09  Tom Tromey  <tom@tromey.com>
7108
7109         * symtab.c (search_symbols)
7110         (default_collect_symbol_completion_matches_break_on): Use
7111         objfile_msymbols.
7112         * ada-lang.c (ada_lookup_simple_minsym)
7113         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7114         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7115         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7116         objfile_msymbols.
7117         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7118         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7119         * objc-lang.c (find_methods): Use objfile_msymbols.
7120         (info_selectors_command, info_classes_command): Likewise.
7121         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7122         * objfiles.h (class objfile_msymbols): New.
7123         (ALL_OBJFILE_MSYMBOLS): Remove.
7124         (ALL_MSYMBOLS): Remove.
7125
7126 2019-01-09  Tom Tromey  <tom@tromey.com>
7127
7128         * common/next-iterator.h (next_adapter): Add Iterator template
7129         parameter.
7130         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7131         (class all_objfiles_safe): New.
7132         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7133         * objfiles.c (put_objfile_before): Update comment.
7134         (add_separate_debug_objfile): Likewise.
7135         (free_all_objfiles): Use all_objfiles_safe.
7136         (objfile_purge_solibs): Likewise.
7137
7138 2019-01-09  Tom Tromey  <tom@tromey.com>
7139
7140         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7141         (expand_symtab_containing_pc, lookup_static_symbol)
7142         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7143         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7144         all_objfiles.
7145         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7146         * breakpoint.c (create_overlay_event_breakpoint)
7147         (create_longjmp_master_breakpoint)
7148         (create_std_terminate_master_breakpoint)
7149         (create_exception_master_breakpoint): Use all_objfiles.
7150         * linux-thread-db.c (try_thread_db_load_from_pdir)
7151         (has_libpthread): Use all_objfiles.
7152         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7153         * linespec.c (iterate_over_all_matching_symtabs)
7154         (search_minsyms_for_name): Use all_objfiles.
7155         * maint.c (maintenance_info_sections): Use all_objfiles.
7156         * main.c (captured_main_1): Use all_objfiles.
7157         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7158         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7159         * guile/scm-pretty-print.c
7160         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7161         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7162         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7163         (maintenance_print_msymbols): Use all_objfiles.
7164         * source.c (select_source_symtab): Use all_objfiles.
7165         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7166         * symfile.c (remove_symbol_file_command)
7167         (expand_symtabs_matching, map_symbol_filenames): Use
7168         all_objfiles.
7169         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7170         all_objfiles.
7171         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7172         * objc-lang.c (find_methods): Use all_objfiles.
7173         * objfiles.c (have_partial_symbols, have_full_symbols)
7174         (have_minimal_symbols, qsort_cmp)
7175         (default_iterate_over_objfiles_in_search_order): Use
7176         all_objfiles.
7177         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7178         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7179         (maintenance_check_psymtabs): Use all_objfiles.
7180         (ALL_PSYMTABS): Remove.
7181         * compile/compile-object-run.c (do_module_cleanup): Use
7182         all_objfiles.
7183         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7184         * cp-support.c (add_symbol_overload_list_qualified): Use
7185         all_objfiles.
7186         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7187         Use all_objfiles.
7188         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7189         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7190         all_objfiles.
7191         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7192         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7193         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7194         Uses all_objfiles.
7195         * solib.c (solib_read_symbols): Use all_objfiles
7196
7197 2019-01-09  Tom Tromey  <tom@tromey.com>
7198
7199         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7200         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7201         all_objfiles.
7202         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7203         * symmisc.c (print_symbol_bcache_statistics)
7204         (print_objfile_statistics, maintenance_print_objfiles)
7205         (maintenance_info_symtabs, maintenance_check_symtabs)
7206         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7207         all_objfiles.
7208         * source.c (forget_cached_source_info): Use all_objfiles.
7209         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7210         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7211         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7212         * objfiles.c (update_section_map): Use all_objfiles.
7213         (shared_objfile_contains_address_p): Likewise.
7214         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7215         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7216
7217 2019-01-09  Tom Tromey  <tom@tromey.com>
7218
7219         * common/next-iterator.h: New file.
7220         * objfiles.h (class all_objfiles): New.
7221         (struct objfile_iterator): New.
7222
7223 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7224
7225         * NEWS: Move the description of the changed "frame", "select-frame",
7226          and "info frame" commands to the Changed commands section.
7227
7228 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7229
7230         * gdbtypes.c (check_stub_method_group): Remove handling of old
7231         mangling schemes.
7232         * linespec.c (find_methods): Likewise.
7233         * stabsread.c (read_member_functions): Likewise.
7234         * valops.c (search_struct_method): Likewise.
7235         (value_struct_elt_for_reference): Likewise.
7236         * NEWS: Mention this change.
7237
7238 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7239
7240         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7241         print_source_lines.
7242         * source.c (print_source_lines_base): Update line number check.
7243         (print_source_lines): New function.
7244         (source_lines_range::source_lines_range): New function.
7245         * source.h (class source_lines_range): New class.
7246         (print_source_lines): New declaration.
7247
7248 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7249
7250         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7251
7252 2019-01-08  Tom Tromey  <tom@tromey.com>
7253             Simon Marchi  <simon.marchi@ericsson.com>
7254
7255         PR gdb/24060
7256         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7257         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7258         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7259         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7260         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7261         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7262
7263 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7264
7265         * source.c (select_source_symtab): Move header comment to
7266         declaration in source.h.
7267         (forget_cached_source_info_for_objfile): Likewise.
7268         (forget_cached_source_info): Likewise.
7269         (identify_source_line): Likewise.
7270         * source.h (identify_source_line): Move declaration from symtab.h
7271         and add comment from source.c
7272         (print_source_lines): Likewise.
7273         (forget_cached_source_info_for_objfile): Likewise.
7274         (forget_cached_source_info): Likewise.
7275         (select_source_symtab): Likewise.
7276         (enum print_source_lines_flag): Move definition from symtab.h.
7277         * symtab.h (identify_source_line): Move declaration to source.h.
7278         (print_source_lines): Likewise.
7279         (forget_cached_source_info_for_objfile): Likewise.
7280         (forget_cached_source_info): Likewise.
7281         (select_source_symtab): Likewise.
7282         (enum print_source_lines_flag): Move definition to source.h.
7283         * tui/tui-hooks.c: Add 'source.h' include.
7284
7285 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7286
7287         * source.c (print_source_lines_base): Handle requests to print
7288         reverse line number sequences, and guard against empty lines
7289         string.
7290
7291 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7292
7293         * source.c (print_source_lines_base): Fix skip of '\r' if next
7294         character is '\n'.
7295
7296 2019-01-06  Tom Tromey  <tom@tromey.com>
7297
7298         * c-exp.y (struct c_parse_state) <macro_original_text,
7299         expansion_obstack>: New member.
7300         (macro_original_text, expansion_obstack): Remove globals.
7301         (scan_macro_expansion, scanning_macro_expansion)
7302         (finished_macro_expansion): Update.
7303         (scan_macro_cleanup): Remove.
7304         (yylex, c_parse): Update.
7305
7306 2019-01-06  Tom Tromey  <tom@tromey.com>
7307
7308         * c-exp.y (struct c_parse_state) <strings>: New member.
7309         (operator_stoken): Update.
7310
7311 2019-01-06  Tom Tromey  <tom@tromey.com>
7312
7313         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7314         (union type_stack_elt) <typelist_val>: Now a pointer to
7315         std::vector.
7316         (type_stack_cleanup): Don't declare.
7317         (push_typelist): Update.
7318         * parse.c (pop_typelist): Return a std::vector.
7319         (push_typelist): Take a std::vector.
7320         (follow_types): Update.  Do not free args.
7321         (type_stack_cleanup): Remove.
7322         * c-exp.y (struct c_parse_state): New.
7323         (cpstate): New global.
7324         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7325         (nonempty_typelist): Update.
7326         (func_mod): Create a new vector.
7327         (c_parse): Create a c_parse_state.
7328         (check_parameter_typelist): Do not delete params.
7329         (function_method): Update.  Do not delete type_list.
7330
7331 2019-01-06  Tom Tromey  <tom@tromey.com>
7332
7333         PR gdb/28155:
7334         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7335         check_typedef.
7336         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7337         (print_return_value): Likewise.
7338
7339 2019-01-05  Tom Tromey  <tom@tromey.com>
7340
7341         * contrib/cleanup_check.py: Remove.
7342         * contrib/gcc-with-excheck: Remove.
7343         * contrib/exsummary.py: Remove.
7344         * contrib/excheck.py: Remove.
7345
7346 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7347
7348         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7349         NULL. Initialize tpprev to NULL instead of assigning it
7350         to NULL on the next statement.
7351         * windows-nat.c (windows_delete_thread): Remove check for
7352         main_thread_id before printing thread exit notifications.
7353         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7354         Remove thread ID check against main_thread_id.
7355         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7356         windows_delete_thread.
7357         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7358
7359 2019-01-04  Tom Tromey  <tom@tromey.com>
7360
7361         * compile/compile.c (_initialize_compile): Use upper case for
7362         metasyntactic variables.
7363         * symmisc.c (_initialize_symmisc): Use upper case for
7364         metasyntactic variables.
7365         * psymtab.c (_initialize_psymtab): Use upper case for
7366         metasyntactic variables.
7367         * demangle.c (demangle_command): Use upper case for metasyntactic
7368         variables.
7369         (_initialize_demangler): Likewise.
7370         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7371         variables.
7372
7373 2019-01-03  Tom Tromey  <tom@tromey.com>
7374
7375         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7376
7377 2019-01-03  Tom Tromey  <tom@tromey.com>
7378
7379         * python/py-symtab.c (salpy_str): Update.
7380         (struct salpy_sal_object) <symtab>: Now a PyObject.
7381         (salpy_dealloc): Update.
7382         (del_objfile_sal): Use gdbpy_ref.
7383
7384 2019-01-03  Tom Tromey  <tom@tromey.com>
7385
7386         * python/py-type.c (convert_field): Use new_reference.  Return
7387         gdbpy_ref.
7388         (make_fielditem): Return gdbpy_ref.
7389         (typy_fields): Update.
7390         (typy_getitem): Update.
7391         (field_name): Return gdbpy_ref.  Use new_reference.
7392         (typy_iterator_iternext): Update.
7393
7394 2019-01-03  Tom Tromey  <tom@tromey.com>
7395
7396         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7397
7398 2019-01-03  Tom Tromey  <tom@tromey.com>
7399
7400         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7401         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7402         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7403         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7404         (pspy_set_type_printers): Likewise.
7405         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7406         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7407         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7408         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7409         (objfpy_set_type_printers): Likewise.
7410
7411 2019-01-03  Tom Tromey  <tom@tromey.com>
7412
7413         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7414         (gdbpy_print_stack): Use gdbpy_err_fetch.
7415         * python/python-internal.h (class gdbpy_err_fetch): New class.
7416         (class gdbpy_enter) <m_error_type, m_error_value,
7417         m_error_traceback>: Remove.
7418         <m_error>: New member.
7419         (gdbpy_exception_to_string): Don't declare.
7420         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7421         * python/py-value.c (convert_value_from_python): Use
7422         gdbpy_err_fetch.
7423         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7424         gdbpy_exception_to_string.
7425         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7426         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7427         gdbpy_err_fetch.
7428
7429 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7430
7431         * linux-nat.c (delete_lwp_cleanup): Delete.
7432         (struct lwp_deleter): New struct.
7433         (lwp_info_up): New typedef.
7434         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7435         lwp_info_up.
7436
7437 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7438
7439         * linux-fork.c (class scoped_switch_fork_info): New class.
7440         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7441
7442 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7443
7444         * valops.c (find_overload_match): Remove use of null_cleanup, and
7445         calls to do_cleanups.
7446
7447 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7448
7449         * compile/compile-cplus-types.c
7450         (compile_cplus_instance::decl_name): Handle changes to
7451         cp_func_name.
7452         * cp-support.c (cp_func_name): Update header comment, update
7453         return type.
7454         * cp-support.h (cp_func_name): Update return type in declaration.
7455         * valops.c (find_overload_match): Move temp_func local to top
7456         level of function and change its type.  Use temp_func to hold and
7457         delete temporary string obtained from cp_func_name.
7458
7459 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7460
7461         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7462         gdb::char_vector, remove cleanup, and update uses of `msg`.
7463
7464 2019-01-03  Jim Wilson  <jimw@sifive.com>
7465
7466         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7467
7468 2019-01-02  Tom Tromey  <tom@tromey.com>
7469
7470         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7471         (tdesc_parse_xml): Remove cleanups.
7472         * target-descriptions.h (make_cleanup_free_target_description):
7473         Don't declare.
7474         (target_desc_deleter): New struct.
7475         (target_desc_up): New typedef.
7476         * target-descriptions.c (target_desc_deleter::operator()): Rename
7477         from free_target_description.
7478         (make_cleanup_free_target_description): Remove.
7479
7480 2019-01-02  Tom Tromey  <tom@tromey.com>
7481
7482         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7483         constructor, destructor.
7484         (linespec_parser): Remove typedef.
7485         (~linespec_parser): Rename from linespec_parser_delete.
7486         (linespec_lex_to_end, linespec_complete_label)
7487         (linespec_complete): Update.
7488         (decode_line_full): Remove cleanups.
7489         (decode_line_1): Update.
7490
7491 2019-01-02  Tom Tromey  <tom@tromey.com>
7492
7493         * python/python-internal.h (inferior_to_inferior_object): Change
7494         return type.
7495         * python/py-exitedevent.c (create_exited_event_object): Update.
7496         * python/py-inferior.c (inferior_to_inferior_object): Return
7497         gdbpy_ref.
7498         (python_new_inferior, python_inferior_deleted)
7499         (thread_to_thread_object, delete_thread_object)
7500         (build_inferior_list, gdbpy_selected_inferior): Update.
7501         * python/py-infthread.c (create_thread_object): Update.  Also fail
7502         if inferior_to_inferior_object fails.
7503
7504 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7505
7506         * inferior.h (class inferior) <displaced_step_state>: New field.
7507         * infrun.h (struct displaced_step_state): Move here from
7508         infrun.c.  Initialize fields, add constructor.
7509         <inf>: Remove field.
7510         <reset>: New method.
7511         * infrun.c (struct displaced_step_inferior_state): Move to
7512         infrun.h.
7513         (displaced_step_inferior_states): Remove.
7514         (get_displaced_stepping_state): Adust.
7515         (displaced_step_in_progress_any_inferior): Adjust.
7516         (displaced_step_in_progress_thread): Adjust.
7517         (displaced_step_in_progress): Adjust.
7518         (add_displaced_stepping_state): Remove.
7519         (get_displaced_step_closure_by_addr): Adjust.
7520         (remove_displaced_stepping_state): Remove.
7521         (infrun_inferior_exit): Call displaced_step_state.reset.
7522         (use_displaced_stepping): Don't check for NULL.
7523         (displaced_step_prepare_throw): Call
7524         get_displaced_stepping_state.
7525         (displaced_step_fixup): Don't check for NULL.
7526         (prepare_for_detach): Don't check for NULL.
7527
7528 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7529
7530         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7531          in case of call that did not complete.
7532
7533 2019-01-02  Andrey Utkin  <autkin@undo.io>
7534
7535         * symfile.c (find_separate_debug_file): Fix search of debug files for
7536         remote debuggee.
7537
7538 2019-01-02  Tom Tromey  <tom@tromey.com>
7539
7540         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7541         indentation.
7542         * python/py-frame.c (frapy_older): Remove cast.
7543         (frapy_newer): Likewise.
7544         * python/py-breakpoint.c (local_setattro): Remove cast.
7545         * python/py-arch.c (archpy_name): Remove local variable.
7546         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7547
7548 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7549
7550         * unittests/basic_string_view/element_access/char/empty.cc:
7551         Fix year range in copyright header.
7552
7553 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7554
7555         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7556         Delete.
7557         <operator==>: Update with for removed field.
7558         <hash>: Likewise.
7559         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7560         <isa_features>: ...this.
7561         <abi_features>: New field.
7562         (riscv_isa_flen): Update comment.
7563         (riscv_abi_xlen): New declaration.
7564         (riscv_abi_flen): New declaration.
7565         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7566         isa_features.
7567         (riscv_abi_xlen): New function.
7568         (riscv_isa_flen): Update to get answer from isa_features.
7569         (riscv_abi_flen): New function.
7570         (riscv_has_fp_abi): Update to get answer from abi_features.
7571         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7572         xlen and flen.
7573         (riscv_call_info) <xlen, flen>: Update comment.
7574         (riscv_call_arg_struct): Remove invalid assertions
7575         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7576         is removed.
7577         (riscv_gdbarch_init): Gather isa features and abi features
7578         separately, ensure both match on the gdbarch when reusing an old
7579         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7580         a target with 64-bit float hardware.
7581
7582 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7583
7584         * source.c (search_command_helper): Stop reverse search
7585         when line 1 has been searched.
7586
7587 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7588
7589         * record-full.c (record_full_base_target::close): Rewrite
7590         record_full_core_buf_list free logic.
7591
7592 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7593
7594         * break-catch-syscall.c (print_one_catch_syscall): xfree
7595         the last text.
7596
7597 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7598
7599         * top.c (print_gdb_version): Update Copyright year in version
7600         message.
7601
7602 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7603
7604         Update copyright year range in all GDB files.
7605
7606 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7607
7608         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7609
7610 For older changes see ChangeLog-2018.
7611 \f
7612 Local Variables:
7613 mode: change-log
7614 left-margin: 8
7615 fill-column: 74
7616 version-control: never
7617 coding: utf-8
7618 End:
7619