gdb/ChangeLog

   1 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
   2
   3         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
   4
   5 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
   6
   7         * tui/tui-data.h (tui_gen_win_info): Add an =default
   8         move constructor, required by some GCC versions.
   9
  10 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
  11
  12         * go32-nat.c (go32_sysinfo): Add hygon_p.
  13
  14 2019-08-20  Tom Tromey  <tom@tromey.com>
  15
  16         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
  17         line_from_reg_element_no, first_reg_element_no_inline,
  18         display_all_data, delete_data_content_windows,
  19         erase_data_content>: Now private.
  20
  21 2019-08-20  Tom Tromey  <tom@tromey.com>
  22
  23         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
  24         (tui_unhighlight_win, tui_highlight_win)
  25         (tui_win_info::make_window): Update.
  26         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
  27
  28 2019-08-20  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
  31         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
  32         (MAX_PID_WIDTH): Move to tui-stack.c.
  33         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
  34         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
  35         (MAX_PID_WIDTH): Move from tui-data.h.
  36
  37 2019-08-20  Tom Tromey  <tom@tromey.com>
  38
  39         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
  40         * tui/tui-wingeneral.c (box_win): Change type of win_info.
  41         (box_win): Update.
  42         (tui_gen_win_info::make_window): Rename from tui_make_window.
  43         (tui_win_info::make_window): New method.
  44         (tui_gen_win_info::make_visible): Update.
  45         * tui/tui-source.c (tui_source_window::set_contents): Update.
  46         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
  47         (tui_data_window::display_registers_from): Update.
  48         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
  49         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
  50         Declare.
  51         <can_box>: Remove.
  52         <title>: Remove.
  53         (struct tui_win_info) <make_window>: Declare.
  54         <can_box>: Now virtual.
  55         <title>: New member.
  56         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
  57         * tui/tui-command.c (tui_cmd_window::resize): Update.
  58
  59 2019-08-20  Tom Tromey  <tom@tromey.com>
  60
  61         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
  62         * tui/tui-regs.c (tui_data_window::show_registers): Update.
  63         (tui_data_window::check_register_values): Update.
  64
  65 2019-08-20  Tom Tromey  <tom@tromey.com>
  66
  67         * tui/tui-regs.h (struct tui_data_window): Use
  68         DISABLE_COPY_AND_ASSIGN.
  69         <regs_content>: Change type, removing unique_ptr.
  70         <tui_data_window>: Add move constructor.
  71         * tui/tui-regs.c (tui_data_window::show_registers)
  72         (tui_data_window::show_register_group)
  73         (tui_data_window::display_registers_from)
  74         (tui_data_window::display_registers_from)
  75         (tui_data_window::first_data_item_displayed)
  76         (tui_data_window::delete_data_content_windows)
  77         (tui_data_window::rerender, tui_data_window::refresh_window)
  78         (tui_data_window::check_register_values): Update.
  79
  80 2019-08-20  Tom Tromey  <tom@tromey.com>
  81
  82         * tui/tui-regs.h (struct tui_data_window) <show_registers,
  83         show_register_group>: Declare.
  84         (tui_show_register_group): Don't declare.
  85         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
  86         tui_show_registers.
  87         (tui_data_window::show_register_group): Rename from
  88         tui_show_register_group.
  89         (tui_data_window::check_register_values, tui_reg_command):
  90         Update.
  91         * tui/tui-layout.c (tui_set_layout): Update.
  92
  93 2019-08-20  Tom Tromey  <tom@tromey.com>
  94
  95         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
  96         Declare.
  97         (tui_check_register_values): Don't declare.
  98         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
  99         from tui_check_register_values.
 100         * tui/tui-hooks.c (tui_register_changed): Update.
 101
 102 2019-08-20  Tom Tromey  <tom@tromey.com>
 103
 104         * tui/tui-regs.c (tui_reg_layout): Move later.
 105         (tui_show_registers): Don't enable TUI mode or change layout.
 106
 107 2019-08-20  Tom Tromey  <tom@tromey.com>
 108
 109         * tui/tui-regs.h (struct tui_data_item_window)
 110         <~tui_data_item_window>: Remove.
 111         <content>: Now a unique_xmalloc_ptr.
 112         * tui/tui-regs.c (tui_register_format): Return a
 113         unique_xmalloc_ptr.
 114         (tui_get_register): Update.
 115         (~tui_data_item_window): Remove.
 116         (tui_data_window::display_registers_from, tui_display_register):
 117         Update.
 118         * tui/tui-io.h (tui_expand_tabs): Update.
 119         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 120         Remove "col" parameter.
 121
 122 2019-08-20  Tom Tromey  <tom@tromey.com>
 123
 124         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 125         field.
 126         * tui/tui-regs.c (~tui_data_item_window): Update.
 127
 128 2019-08-20  Tom Tromey  <tom@tromey.com>
 129
 130         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 131         earlier.
 132
 133 2019-08-20  Tom Tromey  <tom@tromey.com>
 134
 135         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 136
 137 2019-08-20  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui-source.h (struct tui_source_window): Update.
 140         * tui/tui-regs.c (tui_show_registers): Update.
 141         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 142         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 143         (NO_REGS_STRING): Remove defines.
 144
 145 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 146
 147         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 148         unnecessary thread walk if remote doesn't support the packet.
 149
 150 2019-08-19  Tom Tromey  <tromey@adacore.com>
 151
 152         * python/py-value.c (value_has_field): Fix indentation.
 153
 154 2019-08-19  Tom Tromey  <tromey@adacore.com>
 155
 156         * printcmd.c (do_one_display, info_display_command): Update.
 157         * block.h (contained_in): Return bool.  Add allow_nested
 158         parameter.
 159         * block.c (contained_in): Return bool.  Add allow_nested
 160         parameter.
 161
 162 2019-08-19  Tom Tromey  <tom@tromey.com>
 163
 164         * configure: Rebuild.
 165         * configure.ac: Disallow the combination of -static-libstdc++ and
 166         source highlight.
 167         * source-cache.c (get_language_name): Handle rust.
 168         (source_cache::get_source_lines): Ignore highlighting exceptions.
 169
 170 2019-08-16  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 173         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 174         (struct tui_source_window_base) <make_visible, refresh_window,
 175         resize>: Remove methods.
 176         <execution_info>: Remove field.
 177         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 178         (tui_show_source_line, tui_source_window_base)
 179         (~tui_source_window_base): Update.
 180         (tui_source_window_base::resize)
 181         (tui_source_window_base::make_visible)
 182         (tui_source_window_base::refresh_window): Remove.
 183         (tui_source_window_base::update_exec_info): Update.
 184         * tui/tui-source.c (tui_source_window::set_contents): Update.
 185         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 186
 187 2019-08-16  Tom Tromey  <tom@tromey.com>
 188
 189         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 190         deprecated_query_hook.
 191
 192 2019-08-16  Tom Tromey  <tom@tromey.com>
 193
 194         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 195         (tui_update_source_windows_with_line): Update.
 196         * tui/tui-source.h (struct tui_source_window)
 197         <show_symtab_source>: Declare.
 198         (tui_show_symtab_source): Don't declare.
 199         * tui/tui-source.c (tui_show_symtab_source): Rename from
 200         tui_show_symtab_source.
 201
 202 2019-08-16  Tom Tromey  <tom@tromey.com>
 203
 204         * tui/tui-winsource.h (struct tui_source_window_base)
 205         <set_contents>: Declare.
 206         * tui/tui-winsource.c
 207         (tui_source_window_base::update_source_window_as_is): Update.
 208         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 209         Declare.
 210         (tui_set_source_content): Don't declare.
 211         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 212         tui_set_source_content.
 213         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 214         Declare.
 215         (tui_set_disassem_content): Don't declare.
 216         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 217         tui_set_disassem_content.
 218
 219 2019-08-16  Tom Tromey  <tom@tromey.com>
 220
 221         * tui/tui-winsource.h (struct tui_source_window_base)
 222         <update_breakpoint_info>: Declare.
 223         (tui_update_breakpoint_info): Don't declare.
 224         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 225         (tui_update_all_breakpoint_info): Update.
 226         (tui_source_window_base::update_breakpoint_info): Rename from
 227         tui_update_breakpoint_info.
 228         (tui_source_window_base::update_exec_info): Update.
 229
 230 2019-08-16  Tom Tromey  <tom@tromey.com>
 231
 232         * tui/tui-winsource.h (struct tui_source_window_base)
 233         <update_source_window>: Declare.
 234         (tui_update_source_window): Don't declare.
 235         * tui/tui-winsource.c
 236         (tui_source_window_base::update_source_window): Rename from
 237         tui_update_source_window.
 238         (tui_source_window_base::rerender): Update.
 239         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 240         * tui/tui-disasm.c (tui_show_disassem)
 241         (tui_show_disassem_and_update_source)
 242         (tui_disasm_window::maybe_update): Update.
 243
 244 2019-08-16  Tom Tromey  <tom@tromey.com>
 245
 246         * tui/tui-winsource.h (struct tui_source_window_base)
 247         <update_source_window_as_is>: Declare.
 248         (tui_update_source_window_as_is): Don't declare.
 249         * tui/tui-winsource.c (tui_update_source_window): Update
 250         (tui_source_window_base::update_source_window_as_is): Rename from
 251         tui_update_source_window_as_is.
 252         (tui_source_window_base::refill): Update.
 253         * tui/tui-source.c (tui_show_symtab_source): Update.
 254         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 255         Update.
 256
 257 2019-08-16  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui-winsource.h (tui_update_source_window)
 260         (tui_update_source_window_as_is): Remove "noerror" parameter.
 261         * tui/tui-winsource.c (tui_update_source_window)
 262         (tui_update_source_window_as_is): Remove "noerror" parameter.
 263         (tui_update_source_windows_with_addr)
 264         (tui_update_source_windows_with_line)
 265         (tui_source_window_base::rerender)
 266         (tui_source_window_base::refill): Update.
 267         * tui/tui-source.h (tui_set_source_content)
 268         (tui_show_symtab_source): Remove "noerror" parameter.
 269         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 270         parameter.
 271         (tui_show_symtab_source): Likewise.
 272         (tui_source_window::maybe_update): Update.
 273         * tui/tui-disasm.c (tui_show_disassem)
 274         (tui_show_disassem_and_update_source)
 275         (tui_disasm_window::do_scroll_vertical)
 276         (tui_disasm_window::maybe_update): Update.
 277
 278 2019-08-16  Tom Tromey  <tom@tromey.com>
 279
 280         * tui/tui.c (tui_is_window_visible): Update.
 281         * tui/tui-wingeneral.c (tui_make_window)
 282         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 283         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 284         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 285         (tui_set_win_height_command, parse_scrolling_args): Update.
 286         * tui/tui-source.c (tui_source_window::style_changed): Update.
 287         * tui/tui-regs.c (tui_show_registers)
 288         (tui_data_window::first_data_item_displayed)
 289         (tui_data_window::delete_data_content_windows)
 290         (tui_check_register_values, tui_reg_command): Update.
 291         * tui/tui-disasm.c (tui_show_disassem): Update.
 292         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 293         method.
 294         <is_visible>: Remove field.
 295         * tui/tui-data.c (tui_next_win, tui_prev_win)
 296         (tui_delete_invisible_windows): Update.
 297
 298 2019-08-16  Tom Tromey  <tom@tromey.com>
 299
 300         * tui/tui-winsource.h (struct tui_source_window_base)
 301         <m_has_locator>: Remove.
 302         * tui/tui-layout.c (show_source_disasm_command, show_data)
 303         (show_source_or_disasm_and_command): Update.
 304
 305 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 306
 307         * NEWS (Other MI changes): New subsection.
 308         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 309         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 310         * arch-utils.c (default_get_pc_address_flags): New function.
 311         * arch-utils.h (default_get_pc_address_flags): New declaration.
 312         * gdbarch.sh: Add get_pc_address_flags.
 313         * gdbarch.c: Regenerate.
 314         * gdbarch.h: Likewise.
 315         * stack.c (print_pc): New function.
 316         (print_frame_info) (print_frame): Call print_pc.
 317
 318 2019-08-16  Tom de Vries  <tdevries@suse.de>
 319
 320         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 321         print_objfile_section_info.
 322
 323 2019-08-15  Tom Tromey  <tom@tromey.com>
 324
 325         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 326         calling update_cmdwin_start_line.
 327         * tui/tui-winsource.h (struct tui_source_window_base)
 328         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 329         <rerender>: Declare.
 330         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 331         Call rerender.
 332         (tui_source_window_base::set_new_height): Remove.
 333         (tui_source_window_base::rerender): Rename from
 334         do_make_visible_with_new_height.
 335         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 336         resize method.
 337         (tui_win_info::make_invisible_and_set_new_height)
 338         (tui_win_info::make_visible_with_new_height): Remove.
 339         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 340         Declare.
 341         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 342         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 343         do_make_visible_with_new_height>: Don't declare.
 344         <rerender>: Declare.
 345         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 346         set_new_height.
 347         (tui_data_window::do_make_visible_with_new_height): Remove.
 348         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 349         call tui_show_locator_content.
 350         (tui_gen_win_info::resize): Call rerender.
 351         (show_source_or_disasm_and_command): Don't call
 352         tui_show_locator_content.
 353         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 354         method.
 355         (struct tui_win_info) <rerender>: Declare.
 356         <set_new_height, make_invisible_and_set_new_height,
 357         make_visible_with_new_height>: Don't declare.
 358         * tui/tui-data.c (tui_win_list::rerender): New method.
 359         * tui/tui-command.h (struct tui_cmd_window)
 360         <do_make_visible_with_new_height>: Don't declare.
 361         * tui/tui-command.c
 362         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 363
 364 2019-08-15  Tom Tromey  <tromey@adacore.com>
 365
 366         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 367         * ada-lang.c (ada_enum_name): Likewise.
 368
 369 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 370
 371         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 372         leading underscore.
 373         (GdbOutputErrorFile): Likewise.
 374         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 375         accordingly.
 376         (execute_unwinders): Rename to have a leading underscore.
 377         (auto_load_packages): Likewise.
 378         (global scope): Adjust call to auto_load_packages accordingly.
 379         (GdbSetPythonDirectory): Likewise.
 380         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 381         instead of execute_unwinders.
 382
 383 2019-08-15  Tom Tromey  <tom@tromey.com>
 384
 385         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 386         (show_data): Don't change window visibility.
 387         (tui_gen_win_info::resize): Remove special case for command
 388         window.  Use wresize, when available.
 389         (show_source_or_disasm_and_command): Don't change window
 390         visibility.
 391         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 392         <make_visible>: New method.
 393         * tui/tui-command.c (tui_cmd_window::resize): New method.
 394
 395 2019-08-15  Tom Tromey  <tom@tromey.com>
 396
 397         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 398         (struct tui_source_windows): New.
 399         * tui/tui-winsource.c (tui_display_main): Update.
 400         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 401         (new_height_ok, parse_scrolling_args): Update.
 402         * tui/tui-layout.c (show_layout, show_data): Update.
 403         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 404         (tui_add_to_source_windows): Don't declare.
 405         * tui/tui-data.c (source_windows, tui_source_windows)
 406         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 407
 408 2019-08-15  Tom Tromey  <tom@tromey.com>
 409
 410         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 411         Rename from reset.
 412         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 413         * tui/tui-layout.c (show_source_disasm_command, show_data):
 414         Update.
 415         (tui_gen_win_info::resize): Rename.
 416         (show_source_or_disasm_and_command): Update.
 417         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 418         reset.
 419
 420 2019-08-15  Tom Tromey  <tom@tromey.com>
 421
 422         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 423         * tui/tui-interp.c (tui_interp::init): Don't call
 424         tui_initialize_static_data.
 425         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 426
 427 2019-08-15  Tom Tromey  <tom@tromey.com>
 428
 429         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 430         examine tui_win_list.
 431
 432 2019-08-15  Tom Tromey  <tom@tromey.com>
 433
 434         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 435         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 436         tui_clear_source_content.
 437         (tui_clear_source_content): Remove.
 438         (tui_source_window_base::do_erase_source_content): Hoist call to
 439         content.clear().
 440         * tui/tui-stack.c (tui_show_frame_info): Don't call
 441         tui_clear_source_content.
 442
 443 2019-08-15  Tom Tromey  <tom@tromey.com>
 444
 445         * tui/tui-winsource.h (struct tui_source_window_base)
 446         <do_erase_source_content>: New method.
 447         <erase_source_content>: New method.
 448         (tui_erase_source_content): Don't declare.
 449         * tui/tui-winsource.c (tui_clear_source_content): Update.
 450         (tui_source_window_base::do_erase_source_content): Rename from
 451         tui_erase_source_content.
 452         (tui_source_window_base::show_source_content): Update.
 453         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 454         * tui/tui-source.h (struct tui_source_window)
 455         <erase_source_content>: New method.
 456         * tui/tui-disasm.h (struct tui_disasm_window)
 457         <erase_source_content>: New method.
 458
 459 2019-08-15  Tom Tromey  <tom@tromey.com>
 460
 461         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 462         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 463         constructor.
 464         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 465         * tui/tui-source.c (tui_set_source_content): Update.
 466         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 467
 468 2019-08-15  Tom Tromey  <tom@tromey.com>
 469
 470         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 471         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 472         tui-source.c.
 473         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 474         Declare.
 475         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 476         method.
 477         (tui_source_window::maybe_update): Update.
 478
 479 2019-08-15  Tom Tromey  <tom@tromey.com>
 480
 481         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 482         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 483         tui-disasm.c.
 484         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 485         Declare.
 486         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 487         method.
 488         (tui_disasm_window::maybe_update): Update.
 489
 490 2019-08-15  Tom Tromey  <tom@tromey.com>
 491
 492         * tui/tui-winsource.h (struct tui_source_window_base)
 493         <maybe_update>: Declare.
 494         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 495         method.
 496         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 497         Declare.
 498         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 499         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 500         Declare.
 501         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 502
 503 2019-08-15  Tom Tromey  <tom@tromey.com>
 504
 505         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 506
 507 2019-08-15  Tom Tromey  <tom@tromey.com>
 508
 509         * tui/tui-wingeneral.c: Include tui-stack.h.
 510         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 511         (struct tui_locator_window): Move from tui-data.h.
 512         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 513         (tui_initialize_static_data): Move from tui-data.c.
 514         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 515         (struct tui_locator_window): Move to tui-stack.c.
 516         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 517         (tui_initialize_static_data): Move to tui-stack.c.
 518
 519 2019-08-15  Tom Tromey  <tom@tromey.com>
 520
 521         * tui/tui-layout.c (show_source_disasm_command)
 522         (show_source_or_disasm_and_command): Use make_visible method, not
 523         tui_make_window.
 524         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 525         Remove.
 526
 527 2019-08-15  Tom Tromey  <tom@tromey.com>
 528
 529         * tui/tui-wingeneral.h (tui_make_window): Update.
 530         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 531         parameter.
 532         (tui_gen_win_info::make_visible): Update.
 533         * tui/tui-regs.c (tui_data_window::display_registers_from):
 534         Update.
 535         * tui/tui-layout.c (show_source_disasm_command)
 536         (show_source_or_disasm_and_command): Update.
 537         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 538         (enum tui_box): Remove.
 539         (struct tui_win_info) <can_box>: New method.
 540         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 541         method.
 542
 543 2019-08-15  Tom de Vries  <tdevries@suse.de>
 544
 545         * linux-nat-trad.c: Include gdbarch.h.
 546
 547 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 548
 549         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 550         register sizes.
 551
 552 2019-08-14  Tom Tromey  <tromey@adacore.com>
 553
 554         * darwin-nat.c: Include gdbarch.h.
 555         * darwin-nat-info.c: Include gdbarch.h.
 556
 557 2019-08-13  Tom Tromey  <tom@tromey.com>
 558
 559         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 560         Remove.
 561         * tui/tui-data.c (tui_initialize_static_data): Update.
 562
 563 2019-08-13  Tom Tromey  <tom@tromey.com>
 564
 565         * tui/tui-winsource.h (struct tui_exec_info_window)
 566         <~tui_exec_info_window, maybe_allocate_content, get_content,
 567         m_content>: Remove.
 568         (struct tui_source_window_base) <set_exec_info_content,
 569         show_exec_info_content>: Don't declare.
 570         * tui/tui-winsource.c
 571         (tui_exec_info_window::maybe_allocate_content): Remove.
 572         (tui_source_window_base::update_exec_info): Rename from
 573         set_exec_info_content.
 574         (tui_source_window_base::show_exec_info_content)
 575         (tui_source_window_base::update_exec_info): Remove.
 576
 577 2019-08-13  Tom Tromey  <tom@tromey.com>
 578
 579         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 580         declare.
 581         * tui/tui-winsource.c (tui_update_source_window_as_is)
 582         (tui_update_source_windows_with_addr, tui_erase_source_content):
 583         Update.
 584         (tui_clear_exec_info_content): Remove.
 585
 586 2019-08-13  Tom Tromey  <tom@tromey.com>
 587
 588         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 589         declare.
 590         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 591         call tui_erase_exec_info_content.
 592         (tui_clear_exec_info_content): Rename from
 593         tui_erase_exec_info_content.
 594         (tui_clear_exec_info_content): Delete.
 595
 596 2019-08-13  Tom Tromey  <tom@tromey.com>
 597
 598         * tui/tui-winsource.h (struct tui_source_window_base)
 599         <show_exec_info_content>: Declare.
 600         (tui_show_exec_info_content): Don't declare.
 601         * tui/tui-winsource.c
 602         (tui_source_window_base::show_exec_info_content): Rename from
 603         tui_show_exec_info_content.
 604         (tui_source_window_base::update_exec_info): Update.
 605
 606 2019-08-13  Tom Tromey  <tom@tromey.com>
 607
 608         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 609         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 610         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 611         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 612         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 613         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 614         ... here.
 615
 616 2019-08-13  Tom Tromey  <tom@tromey.com>
 617
 618         * tui/tui-winsource.h (struct tui_source_window_base)
 619         <update_exec_info>: Declare.
 620         (tui_update_exec_info): Don't declare.
 621         * tui/tui-winsource.c (tui_update_source_window_as_is)
 622         (tui_source_window_base::refresh_all)
 623         (tui_update_all_breakpoint_info): Update.
 624         (tui_source_window_base::update_exec_info): Rename from
 625         tui_update_exec_info.
 626         * tui/tui-stack.c (tui_show_frame_info): Update.
 627
 628 2019-08-13  Tom Tromey  <tom@tromey.com>
 629
 630         * tui/tui-winsource.h (struct tui_source_window_base)
 631         <set_exec_info_content>: Declare.
 632         (tui_set_exec_info_content): Don't declare.
 633         * tui/tui-winsource.c
 634         (tui_source_window_base::set_exec_info_content): Rename from
 635         tui_set_exec_info_content.
 636         (tui_update_exec_info): Update.
 637
 638 2019-08-13  Tom Tromey  <tom@tromey.com>
 639
 640         * tui/tui-winsource.h (struct tui_source_window_base)
 641         <show_source_content>: Declare.
 642         (tui_show_source_content): Don't declare.
 643         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 644         (tui_source_window_base::show_source_content): Rename from
 645         tui_show_source_content.
 646         (tui_source_window_base::refresh_all): Update.
 647         * tui/tui-layout.c (show_source_disasm_command)
 648         (show_source_or_disasm_and_command): Update.
 649
 650 2019-08-13  Tom Tromey  <tom@tromey.com>
 651
 652         * tui/tui-winsource.c (tui_erase_source_content)
 653         (tui_show_source_content, tui_source_window_base::refresh_all):
 654         Update.
 655         * tui/tui-wingeneral.h
 656         (tui_check_and_display_highlight_if_needed): Don't declare.
 657         * tui/tui-wingeneral.c
 658         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 659         check_and_display_highlight_if_needed.
 660         * tui/tui-win.c (tui_rehighlight_all)
 661         (tui_win_info::make_visible_with_new_height): Update.
 662         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 663         (tui_data_window::erase_data_content)
 664         (tui_data_window::display_all_data): Update.
 665         * tui/tui-data.h (struct tui_win_info)
 666         <check_and_display_highlight_if_needed>: Declare.
 667
 668 2019-08-13  Tom Tromey  <tom@tromey.com>
 669
 670         * tui/tui-win.c (tui_resize_all): Call
 671         tui_delete_invisible_windows.
 672         * tui/tui-layout.c (show_layout): Call
 673         tui_delete_invisible_windows.
 674         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 675         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 676
 677 2019-08-13  Tom Tromey  <tom@tromey.com>
 678
 679         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 680         tui_add_win_to_layout.
 681
 682 2019-08-13  Tom Tromey  <tom@tromey.com>
 683
 684         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 685         * tui/tui-layout.c (tui_default_win_height): Now static.
 686
 687 2019-08-13  Tom Tromey  <tom@tromey.com>
 688
 689         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 690         single switch.
 691         (show_source_disasm_command, show_source_or_disasm_and_command):
 692         Don't check current layout.
 693
 694 2019-08-13  Tom Tromey  <tom@tromey.com>
 695
 696         * tui/tui-wingeneral.c (make_all_visible): Remove.
 697         (tui_make_all_invisible): Simplify.
 698         * tui/tui-layout.c (tui_make_all_invisible): Move from
 699         tui-wingeneral.c; simplify.
 700         (show_layout): Hoist call to tui_make_all_invisible.
 701         (show_data): Don't call tui_make_all_invisible.
 702
 703 2019-08-13  Tom Tromey  <tom@tromey.com>
 704
 705         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 706         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 707
 708 2019-08-13  Tom Tromey  <tom@tromey.com>
 709
 710         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 711         tui-data.c.
 712         (show_source_disasm_command, show_data)
 713         (show_source_or_disasm_and_command): Don't use
 714         tui_set_current_layout_to.
 715         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 716         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 717         tui-layout.c.
 718         (tui_set_current_layout_to): Remove.
 719
 720 2019-08-13  Tom Tromey  <tom@tromey.com>
 721
 722         * tui/tui-layout.c (tui_set_layout): Update.
 723         * tui/tui-data.h (struct tui_layout_def): Remove.
 724         (tui_layout_def): Don't declare.
 725         * tui/tui-data.c (layout_def): Remove.
 726         (tui_layout_def): Remove.
 727
 728 2019-08-13  Tom Tromey  <tom@tromey.com>
 729
 730         * tui/tui-winsource.h (struct tui_source_window_base)
 731         <clear_detail>: No longer "override".
 732         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 733         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 734         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 735         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 736         Remove.
 737         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 738
 739 2019-08-13  Tom Tromey  <tromey@adacore.com>
 740
 741         * tracepoint.c: Don't include readline.h or history.h.
 742
 743 2019-08-12  Tom Tromey  <tom@tromey.com>
 744
 745         * configure: Rebuild.
 746         * configure.ac: Check for readline 7.
 747         * NEWS: Mention readline 7 requirement.
 748         * README: Update.
 749
 750 2019-08-12  Tom Tromey  <tom@tromey.com>
 751
 752         * mingw-hdep.c (gdb_select): Remove readline hack.
 753
 754 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 755
 756         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 757         when the function fails.
 758
 759 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 760
 761         * s390-tdep.c (s390_type_align): New function.
 762         (s390_gdbarch_init): Set it as type_align gdbarch method.
 763
 764 2019-08-09  Tom de Vries  <tdevries@suse.de>
 765
 766         PR gdb/24591
 767         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 768         pc_low with relocation offset.
 769
 770 2019-08-07  Tom Tromey  <tromey@adacore.com>
 771
 772         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 773         (print_frame_args): Update.
 774         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 775         Update.
 776         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 777         * frame.h (struct frame_arg): Add initializers.
 778         <error>: Now a unique_xmalloc_ptr.
 779
 780 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 781
 782         * NEWS: Expand the Pointer Authentication entry.
 783         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 784         (aarch64_frame_unmask_lr): ... to this.
 785         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 786         Call aarch64_frame_unmask_lr.
 787         * frame.c (struct frame_info): Add "masked" variable.
 788         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 789         (fprint_frame): Check for masked pc.
 790         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 791         declarations.
 792         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 793         * stack.c (print_frame): Check for masked pc.
 794
 795 2019-08-06  Tom Tromey  <tom@tromey.com>
 796
 797         * stabsread.c (patch_block_stabs, read_one_struct_field)
 798         (read_enum_type): Use obstack_strndup.
 799         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 800         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 801         * dwarf2read.c (guess_full_die_structure_name)
 802         (anonymous_struct_prefix): Use obstack_strndup.
 803         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 804         * c-exp.y (yylex): Use obstack_strndup.
 805         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 806         (write_var_or_type): Use obstack_strndup.
 807
 808 2019-08-06  Tom Tromey  <tom@tromey.com>
 809
 810         * symfile.c (reread_symbols): Use obstack_strdup.
 811         * stabsread.c (read_type): Use obstack_strdup.
 812         * gdb_obstack.h (obstack_strdup): New overload.
 813         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 814         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 815         (dwarf2_canonicalize_name): Use obstack_strdup.
 816         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 817         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 818         Use obstack_strdup.
 819
 820 2019-08-06  Tom Tromey  <tom@tromey.com>
 821
 822         * gdb_obstack.h (obstack_strdup): Define.
 823         * gdb_obstack.c (obstack_strdup): Don't define.
 824
 825 2019-08-06  Tom Tromey  <tom@tromey.com>
 826
 827         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 828         obstack_strdup.
 829         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 830         obstack_strdup.
 831         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 832         * stabsread.c (common_block_start): Use obstack_strdup.
 833         * objfiles.c (set_objfile_main_name, objfile): Use
 834         obstack_strdup.
 835         * namespace.c (add_using_directive): Use obstack_strdup.
 836         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 837         * jit.c (finalize_symtab): Use obstack_strdup.
 838         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 839         (guess_partial_die_structure_name, partial_die_info::fixup)
 840         (dwarf2_name): Use obstack_strdup.
 841         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 842         obstack_strdup.
 843         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 844         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 845         obstack_strdup.
 846         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 847
 848 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 849
 850         * unittests/help-doc-selftests.c: New file.
 851         * Makefile.in: Add the new file.
 852
 853 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 854
 855         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 856         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 857         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 858         the trailing '.' is not output, and the first character is uppercased.
 859         (print_help_for_command): Update call to print_doc_line.
 860         (print_doc_of_command): Likewise.
 861         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 862         * cli/cli-option.c (append_indented_doc): Do not append newline.
 863         (build_help_option): Append newline after first appended_indented_doc
 864         only if a second call is done.
 865         (build_help): Append 2 new lines before each option, except the first
 866         one.
 867         * compile/compile.c (_initialize_compile): Add new lines after
 868         %OPTIONS%, when not at the end of the help.
 869         Change help doc or code
 870         producing the help doc to respect the invariants.
 871         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 872         Also removed the new line after 'Options:', as all other commands
 873         do not put an empty line between 'Options:' and the first option.
 874         * printcmd.c (_initialize_printcmd): Likewise.
 875         * stack.c (_initialize_stack): Likewise.
 876         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 877         incorrectly telling COMMAND is optional.
 878         * ada-lang.c (_initialize_ada_language): Change help doc or code
 879         producing the help doc to respect the invariants.
 880         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 881         * breakpoint.c (_initialize_breakpoint): Likewise.
 882         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 883         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 884         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 885         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 886         _initialize_cli_style): Likewise.
 887         * corelow.c (core_target_info): Likewise.
 888         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 889         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 890         * filesystem.c (_initialize_filesystem): Likewise.
 891         * frame.c (_initialize_frame): Likewise.
 892         * gnu-nat.c (add_task_commands): Likewise.
 893         * infcall.c (_initialize_infcall): Likewise.
 894         * infcmd.c (_initialize_infcmd): Likewise.
 895         * interps.c (_initialize_interpreter): Likewise.
 896         * language.c (_initialize_language): Likewise.
 897         * linux-fork.c (_initialize_linux_fork): Likewise.
 898         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 899         * maint.c (_initialize_maint_cmds): Likewise.
 900         * memattr.c (_initialize_mem): Likewise.
 901         * printcmd.c (_initialize_printcmd): Likewise.
 902         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 903         _RegEx): Likewise.
 904         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 905         * record-btrace.c (_initialize_record_btrace): Likewise.
 906         * record-full.c (_initialize_record_full): Likewise.
 907         * record.c (_initialize_record): Likewise.
 908         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 909         * regcache.c (_initialize_regcache): Likewise.
 910         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 911         _initialize_remote): Likewise.
 912         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 913         * serial.c (_initialize_serial): Likewise.
 914         * skip.c (_initialize_step_skip): Likewise.
 915         * source.c (_initialize_source): Likewise.
 916         * stack.c (_initialize_stack): Likewise.
 917         * symfile.c (_initialize_symfile): Likewise.
 918         * symtab.c (_initialize_symtab): Likewise.
 919         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 920         * top.c (init_main): Likewise.
 921         * tracefile-tfile.c (tfile_target_info): Likewise.
 922         * tracepoint.c (_initialize_tracepoint): Likewise.
 923         * tui/tui-win.c (_initialize_tui_win): Likewise.
 924         * utils.c (add_internal_problem_command): Likewise.
 925         * valprint.c (value_print_option_defs): Likewise.
 926
 927 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 928
 929         PR build/24886
 930         * configure.ac: Drop enable-libmcheck support.
 931         * configure, config.in: Rebuild.
 932         * libmcheck.m4: Remove.
 933         * acinclude.m4: Don't include it.
 934         * Makefile.in: Don't distribute it.
 935         * top.c (print_gdb_configuration): Don't mention it.
 936
 937 2019-08-06  Tom Tromey  <tom@tromey.com>
 938
 939         * utils.c (set_output_style): Sometimes pass stream to
 940         emit_style_escape.
 941         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 942         * record-btrace.c (btrace_insn_history): Update.
 943         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 944         method.
 945         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 946         Update initializers.
 947         <m_uiout>: New field.
 948         <m_di>: Move lower.
 949         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 950         Remove "uiout" parameter.
 951         (dump_insns): Update.
 952         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 953         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 954
 955 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 956
 957         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 958         (error_in_psymtab_expansion): Likewise.
 959         (lookup_symbol_via_quick_fns): Likewise.
 960         (basic_lookup_transparent_type_quick): Likewise.
 961         (basic_lookup_transparent_type_1): Likewise.
 962
 963 2019-08-06  Tom Tromey  <tromey@adacore.com>
 964
 965         * source.c (last_source_error): Now bool.
 966         (print_source_lines_base): Make "noprint" bool.  Only open
 967         source file when last_source_visited changes.
 968
 969 2019-08-06  Tom Tromey  <tromey@adacore.com>
 970
 971         * annotate.c (annotate_source_line): Use g_source_cache.
 972         * source-cache.c (source_cache::get_plain_source_lines): Change
 973         parameters.  Populate m_offset_cache.
 974         (source_cache::ensure): New method.
 975         (source_cache::get_line_charpos): New method.
 976         (extract_lines): Move lower.  Change parameters.
 977         (source_cache::get_source_lines): Move lower.
 978         * source-cache.h (class source_cache): Update comment.
 979         <get_line_charpos>: New method.
 980         <get_source_lines>: Update comment.
 981         <clear>: Clear m_offset_cache.
 982         <get_plain_source_lines>: Change parameters.
 983         <ensure>: New method
 984         <m_offset_cache>: New member.
 985         * source.c (forget_cached_source_info_for_objfile): Update.
 986         (info_source_command): Use g_source_cache.
 987         (find_source_lines, open_source_file_with_line_charpos): Remove.
 988         (print_source_lines_base, search_command_helper): Use g_source_cache.
 989         * source.h (open_source_file_with_line_charpos): Don't declare.
 990         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 991         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 992         Use g_source_cache.
 993
 994 2019-08-06  Tom Tromey  <tromey@adacore.com>
 995
 996         * source-cache.c (source_cache::get_plain_source_lines):
 997         Remove "first_line" and "last_line" parameters.
 998         (source_cache::get_source_lines): Cache plain text.
 999         * source-cache.h (class source_cache)
1000         <get_plain_source_lines>: Update.
1001
1002 2019-08-06  Tom Tromey  <tromey@adacore.com>
1003
1004         * source-cache.c (extract_lines): No longer a method.
1005         Changed type of parameter.  Include final newline.
1006         (selftests::extract_lines_test): New function.
1007         (_initialize_source_cache): Likewise.
1008         * source-cache.h (class source_cache)
1009         <extract_lines>: Don't declare.
1010
1011 2019-08-06  Tom Tromey  <tromey@adacore.com>
1012
1013         * breakpoint.c (init_breakpoint_sal): Update.
1014         (breakpoint): Update.
1015         * breakpoint.h (struct breakpoint) <filter>: Now a
1016         unique_xmalloc_ptr.
1017
1018 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1019
1020         * NEWS: Mention dictionary access on blocks.
1021         * python/py-block.c (blpy_getitem): New function.
1022         (block_object_as_mapping): New struct.
1023         (block_object_type): Use new struct for tp_as_mapping field.
1024
1025 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1026
1027         * objfiles.h (objfile): Add a comment describing partial symbols.
1028
1029 2019-08-05  Tom Tromey  <tromey@adacore.com>
1030
1031         * compile/compile.c (_initialize_compile): Use _(), not N_().
1032         * thread.c (_initialize_thread): Use _(), not N_().
1033         * stack.c (_initialize_stack): Use _(), not N_().
1034         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1035
1036 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1037
1038         * dwarf2read.c (struct dw2_symtab_iterator):
1039         <want_specific_block>: Remove.
1040         <block_index>: Change type to gdb::optional.
1041         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1042         change type of BLOCK_INDEX parameter to gdb::optional.
1043         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1044         (dw2_lookup_symbol): Don't pass argument for
1045         WANT_SPECIFIC_BLOCK.
1046         (dw2_expand_symtabs_for_function): Don't pass argument for
1047         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1048         (class dw2_debug_names_iterator)
1049         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1050         parameter, change BLOCK_INDEX type to gdb::optional.
1051         <m_want_specific_block>: Remove.
1052         <m_block_index>: Change type to gdb::optional.
1053         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1054         gdb::optional.  Re-write in function of gdb::optional.
1055         (dw2_debug_names_lookup_symbol): Don't pass argument for
1056         WANT_SPECIFIC_BLOCK.
1057         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1058         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1059         BLOCK_INDEX.
1060
1061 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1062
1063         * NEWS: Mention changes to "info sources" command.
1064
1065 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1066
1067         * symtab.c (filename_partial_match_opts): New struct type.
1068         (struct output_source_filename_data): New members
1069         regexp, c_regexp, partial_match.
1070         (output_source_filename): Use new members to decide to print file.
1071         (info_sources_option_defs): New variable.
1072         (make_info_sources_options_def_group, print_info_sources_header,
1073         info_sources_command_completer):
1074         New functions.
1075         (info_sources_command): Read new optional arguments.
1076         (_initialize_symtab): Update info sources help.
1077
1078 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1079
1080         * ada-lang.c (exception_support_info_v0): Renamed from...
1081         (default_exception_support_info): ... this.  Create new
1082         definition for v1.
1083         (ada_has_this_exception_support): Look up catch_handlers_sym.
1084         (ada_exception_support_info_sniffer): Try v0 after default.
1085
1086 2019-08-01  Tom Tromey  <tromey@adacore.com>
1087
1088         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1089         gdbarch.h.
1090
1091 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1092
1093         * s12z-tdep.c: Fix include path for s12z-opc.h.
1094
1095 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1096
1097         * NEWS: Require GNU make 3.82.
1098
1099 2019-07-16  Tom Tromey  <tom@tromey.com>
1100
1101         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1102         declare.
1103
1104 2019-07-30  Tom Tromey  <tromey@adacore.com>
1105
1106         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1107
1108 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1109
1110         * printcmd.c (print_address_symbolic): Print negative offsets.
1111         (build_address_symbolic): Force signed arithmetic when computing
1112         offset.
1113
1114 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1115
1116         PR/24474: Add a function to lookup static variables.
1117         * NEWS: Mention this new function.
1118         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1119         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1120         * python/python.c (python_GdbMethods): Add new function.
1121
1122 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1123
1124         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1125         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1126         (objfpy_lookup_static_symbol): New function.
1127         (objfile_object_methods): Add new functions.
1128
1129 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1130
1131         * NEWS: Mention 'set|show print frame-info'.  Mention new
1132         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1133         backtrace argument.  Mention that python frame filtering code
1134         is now consistent with what 'backtrace' command prints.
1135
1136 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1137
1138         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1139         comments.
1140         (print_frame_info_auto, print_frame_info_source_line,
1141         print_frame_info_location, print_frame_info_source_and_location,
1142         print_frame_info_location_and_address, print_frame_info_short_location):
1143         New declarations.
1144         (struct frame_print_options): New member print_frame_info.
1145         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1146         * stack.h (get_user_print_what_frame_info): New declaration.
1147         (frame_show_address): New declaration.
1148         * stack.c (print_frame_arguments_choices): New value 'presence'.
1149         (print_frame_info_auto, print_frame_info_source_line,
1150         print_frame_info_location, print_frame_info_source_and_location,
1151         print_frame_info_location_and_address, print_frame_info_short_location,
1152         print_frame_info_choices, print_frame_info_print_what): New definitions.
1153         (print_frame_args): Only print dots for args if print frame-arguments
1154         is 'presence'.
1155         (frame_print_option_defs): New element for "frame-info".
1156         (get_user_print_what_frame_info): New function.
1157         (frame_show_address): Make non static.  Move comment to stack.h.
1158         (print_frame_info_to_print_what): New function.
1159         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1160         to decide what to print.
1161         (backtrace_command_1): Handle the new print_frame_arguments_presence
1162         value.
1163         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1164         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1165         (py_print_frame): In non-mi mode, use LOCATION as default for
1166         print_what, similarly to frame information printed directly by
1167         backtrace command. Handle frame-info user option in non MI mode.
1168
1169 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1170
1171         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1172         Add case for debugging 32-bit target on 64-bit host.  Revise
1173         comment.
1174
1175 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1176
1177         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1178         instead of find_function_entry_range_from_pc.
1179
1180 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1181
1182         * stack.c (find_frame_funname): Remove code which preferred
1183         minsym over symtab sym in "certain pathological cases".
1184
1185         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1186         parameter.  Change type of "do_demangle" to bool.
1187         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1188         Pass suitable "prefer_sym_over_minsym" flag to
1189         build_address_symbolic().  Don't output "+" for negative offsets.
1190         * printcmd.c (print_address_symbolic): Update invocation of
1191         build_address_symbolic to include a "prefer_sym_over_minsym"
1192         flag.
1193         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1194         Restrict cases in which use of minimal symbol is preferred to that
1195         of a found symbol.  Update comments.
1196
1197         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1198         for entry pc when entry pc is out of range for that FDE.
1199
1200 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1201
1202         PR gdb/24839:
1203         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1204         type.
1205
1206 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1207
1208         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1209         this function's Python signature.
1210
1211
1212 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1213
1214         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1215         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1216         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1217         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1218         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1219
1220
1221 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1222
1223         * h8300-tdep.c (h8300_register_name_common): New.
1224         h8300_register_name): Use h8300_register_name_common.
1225         (h8300s_register_name): Likewise.
1226         (h8300sx_register_name): Likewise.
1227         (h8300h_register_nam): New.
1228         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1229
1230
1231 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1232
1233         * arm-tdep.c (arm_skip_cmse_entry): New function.
1234         (arm_is_sgstubs_section): New function.
1235         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1236
1237 2019-07-22  Tom Tromey  <tom@tromey.com>
1238
1239         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1240         Don't self-assign.
1241
1242 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1243
1244         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1245         type_print.
1246
1247 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1248
1249         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1250         so that GDB doesn't match any msymbols when searching in the
1251         TYPES_DOMAIN.
1252         (print_symbol_info): Print using typedef_print or type_print based
1253         on the type of the symbol.  Add updated FIXME comment moved from...
1254         (_initialize_symtab): ... move and update FIXME comment to above.
1255
1256 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1257
1258         * NEWS: Mention adding -q option to "info types".
1259         * symtab.c (struct info_types_options): New struct.
1260         (info_types_options_defs): New variable.
1261         (make_info_types_options_def_group): New function.
1262         (info_types_command): Use gdb::option framework to parse options.
1263         (info_types_command_completer): New function.
1264         (_initialize_symtab): Extend the help text on "info types" and
1265         register command completer.
1266
1267 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1268
1269         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1270         (lookup_symbol_in_objfile): Change int to block_enum and add a
1271         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1272
1273 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1274
1275         * MAINTAINERS (Write After Approval): Add self.
1276
1277 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1278
1279         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1280         instruction to the dummy code region.
1281
1282 2019-07-19  Tom Tromey  <tromey@adacore.com>
1283
1284         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1285         (ARGSUSED, PARAMS, __func__): Remove rules.
1286
1287 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1288
1289         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1290         * features/arm/arm-with-iwmmxt.c: Remove.
1291         * features/arm/arm-with-iwmmxt.xml: Remove.
1292         * features/arm/arm-with-m-fpa-layout.c: Remove.
1293         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1294         * features/arm/arm-with-m-vfp-d16.c: Remove.
1295         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1296         * features/arm/arm-with-m.c: Remove.
1297         * features/arm/arm-with-m.xml: Remove.
1298         * features/arm/arm-with-neon.c: Remove.
1299         * features/arm/arm-with-neon.xml: Remove.
1300         * features/arm/arm-with-vfpv2.c: Remove.
1301         * features/arm/arm-with-vfpv2.xml: Remove.
1302         * features/arm/arm-with-vfpv3.c: Remove.
1303         * features/arm/arm-with-vfpv3.xml: Remove.
1304
1305 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1306
1307         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1308
1309 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1310
1311         * arch/aarch32.c (aarch32_create_target_description): Create
1312         target descriptions using features.
1313         * arch/arm.c (arm_create_target_description)
1314         (arm_create_mprofile_target_description): Likewise.
1315         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1316
1317 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1318
1319         * Makefile.in: Add new files.
1320         * aarch32-tdep.c: New file.
1321         * aarch32-tdep.h: New file.
1322         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1323         Call aarch32_read_description.
1324         * arch/aarch32.c: New file.
1325         * arch/aarch32.h: New file.
1326         * arch/arm.c (arm_create_target_description)
1327         (arm_create_mprofile_target_description): New function.
1328         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1329         (arm_create_target_description)
1330         (arm_create_mprofile_target_description): New declaration.
1331         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1332         read_description functions.
1333         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1334         Likewise.
1335         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1336         * arm-tdep.c (tdesc_arm_list): New variable.
1337         (arm_register_g_packet_guesses): Call create description functions.
1338         (arm_read_description) (arm_read_mprofile_description): New
1339         function.
1340         * arm-tdep.h (arm_read_description)
1341         (arm_read_mprofile_description): Add declaration.
1342         * configure.tgt: Add new files.
1343
1344 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1345
1346         * top.c (new_ui_command): Open specified terminal just once.
1347
1348 2019-07-18  Tom Tromey  <tromey@adacore.com>
1349
1350         * symtab.c (main_name): Constify return type.
1351         * symfile.c (set_initial_language): Update.
1352         * symtab.h (main_name): Constify return type.
1353
1354 2019-07-17  Tom Tromey  <tom@tromey.com>
1355
1356         * tui/tui-winsource.c (tui_update_source_window)
1357         (tui_update_source_window_as_is)
1358         (tui_update_source_windows_with_line): Remove return.
1359         * tui/tui-disasm.c (tui_show_disassem)
1360         (tui_show_disassem_and_update_source): Remove return.
1361         * tui/tui.c (tui_reset): Remove return.
1362         * tui/tui-wingeneral.c
1363         (tui_check_and_display_highlight_if_needed): Remove return.
1364
1365 2019-07-17  Tom Tromey  <tom@tromey.com>
1366
1367         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1368
1369 2019-07-17  Tom Tromey  <tom@tromey.com>
1370
1371         * tui/tui-winsource.h (struct tui_exec_info_window)
1372         (struct tui_source_window_base): Move from tui-data.h.
1373         * tui/tui-winsource.c: Move many method definitions from
1374         elsewhere.  Remove "structuring" comments.
1375         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1376         (tui_source_window_base::refresh_window): Move to
1377         tui-winsource.c.
1378         * tui/tui-win.c (tui_source_window_base::refresh_all)
1379         (tui_source_window_base::update_tab_width)
1380         (tui_source_window_base::set_new_height)
1381         (tui_source_window_base::do_make_visible_with_new_height): Move to
1382         tui-winsource.c.
1383         * tui/tui-source.h: Update.
1384         * tui/tui-source.c (tui_source_window_base::reset): Move to
1385         tui-winsource.c.
1386         * tui/tui-disasm.h: Update.
1387         * tui/tui-data.h (struct tui_exec_info_window): Move to
1388         tui-winsource.h.
1389         (struct tui_source_window_base): Likewise.
1390         * tui/tui-data.c (tui_source_window_base::clear_detail)
1391         (tui_source_window_base, ~tui_source_window_base): Move to
1392         tui-winsource.c.
1393
1394 2019-07-17  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-win.c (tui_resize_all)
1397         (tui_source_window_base::update_tab_width)
1398         (tui_adjust_win_heights): Update.
1399         (tui_win_info::make_invisible_and_set_new_height): Rename from
1400         make_invisible_and_set_new_height.
1401         * tui/tui-data.h (struct tui_win_info)
1402         <make_invisible_and_set_new_height>: New method.
1403
1404 2019-07-17  Tom Tromey  <tom@tromey.com>
1405
1406         * tui/tui.c: Update.
1407         * tui/tui-source.h (struct tui_source_window): Move from
1408         tui-data.h.
1409         * tui/tui-layout.c: Update.
1410         * tui/tui-disasm.c: Update.
1411         * tui/tui-data.h (struct tui_source_window): Move to
1412         tui-source.h.
1413
1414 2019-07-17  Tom Tromey  <tom@tromey.com>
1415
1416         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1417         tui-data.h.
1418         * tui/tui-data.h (struct tui_disasm_window): Move to
1419         tui-disasm.h.
1420
1421 2019-07-17  Tom Tromey  <tom@tromey.com>
1422
1423         * tui/tui-regs.h (struct tui_data_item_window): Move from
1424         tui-data.h.
1425         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1426         * tui/tui-data.h (struct tui_data_item_window): Move to
1427         tui-regs.h.
1428         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1429
1430 2019-07-17  Tom Tromey  <tom@tromey.com>
1431
1432         * tui/tui.c: Update.
1433         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1434         (tui_cmd_window::max_height): Move to tui-command.c.
1435         * tui/tui-layout.c: Update.
1436         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1437         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1438         tui-command.c.
1439         * tui/tui-command.h (struct tui_cmd_window): Move from
1440         tui-data.h.
1441         * tui/tui-command.c: Remove "structuring" comments.
1442         (tui_cmd_window::clear_detail)
1443         (tui_cmd_window::do_make_visible_with_new_height)
1444         (tui_cmd_window::max_height): Move from elsewhere.
1445
1446 2019-07-17  Tom Tromey  <tom@tromey.com>
1447
1448         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1449         Now static.
1450         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1451         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1452
1453 2019-07-17  Tom Tromey  <tom@tromey.com>
1454
1455         * tui/tui.c: Update.
1456         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1457         tui-regs.c.
1458         * tui/tui-windata.h: Remove file.
1459         * tui/tui-windata.c: Remove file.
1460         * tui/tui-win.c (tui_data_window::set_new_height)
1461         (tui_data_window::do_make_visible_with_new_height): Move to
1462         tui-regs.c.
1463         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1464         * tui/tui-regs.c: Remove "structuring" comments.
1465         (tui_data_window::first_data_item_displayed)
1466         (tui_data_window::delete_data_content_windows)
1467         (tui_data_window::erase_data_content)
1468         (tui_data_window::display_all_data)
1469         (tui_data_window::refresh_all)
1470         (tui_data_window::do_scroll_vertical)
1471         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1472         (tui_data_window::do_make_visible_with_new_height)
1473         (tui_data_window::refresh_window): Move from elsewhere.
1474         (_initialize_tui_regs): Move to end of file.
1475         * tui/tui-layout.c: Update.
1476         * tui/tui-hooks.c: Update.
1477         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1478         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1479         tui-regs.c.
1480         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1481
1482 2019-07-17  Tom Tromey  <tom@tromey.com>
1483
1484         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1485         seen.
1486
1487 2019-07-17  Tom Tromey  <tom@tromey.com>
1488
1489         * tui/tui-win.c (tui_source_window_base::set_new_height)
1490         (tui_source_window_base::do_make_visible_with_new_height): Use
1491         m_has_locator field directly.
1492         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1493         method.
1494         (struct tui_source_window_base) <has_locator>: Likewise.
1495
1496 2019-07-17  Tom Tromey  <tom@tromey.com>
1497
1498         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1499         Don't declare.
1500         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1501         Remove.
1502         * tui/tui-win.c (tui_source_window_base::set_new_height)
1503         (tui_source_window_base::set_new_height)
1504         (make_invisible_and_set_new_height)
1505         (tui_source_window_base::do_make_visible_with_new_height)
1506         (tui_source_window_base::do_make_visible_with_new_height):
1507         Update.
1508         * tui/tui-layout.c (show_source_disasm_command, show_data)
1509         (show_source_or_disasm_and_command): Update.
1510         * tui/tui-layout.c (show_layout): Update.
1511
1512 2019-07-17  Tom Tromey  <tom@tromey.com>
1513
1514         * tui/tui-layout.c (make_data_window): Remove.
1515         (show_data): Unify creation and re-initialization cases.
1516
1517 2019-07-17  Tom Tromey  <tom@tromey.com>
1518
1519         * tui/tui-layout.c (make_source_window, make_disasm_window):
1520         Remove.
1521         (show_data): Unify creation and re-initialization cases.
1522
1523 2019-07-17  Tom Tromey  <tom@tromey.com>
1524
1525         * tui/tui-layout.c (make_command_window): Remove.
1526         (show_source_disasm_command, show_source_or_disasm_and_command):
1527         Unify creation and re-initialization cases.
1528
1529 2019-07-17  Tom Tromey  <tom@tromey.com>
1530
1531         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1532         creation and re-initialization cases.
1533
1534 2019-07-17  Tom Tromey  <tom@tromey.com>
1535
1536         * tui/tui-regs.c (tui_get_register): Return void.
1537
1538 2019-07-17  Tom Tromey  <tom@tromey.com>
1539
1540         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1541         Simplify.
1542
1543 2019-07-17  Tom Tromey  <tom@tromey.com>
1544
1545         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1546         resetting.
1547
1548 2019-07-17  Tom Tromey  <tom@tromey.com>
1549
1550         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1551         * tui/tui-regs.c (tui_reg_layout): New function.
1552         (tui_show_registers, tui_reg_command): Use it.
1553         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1554         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1555         parameters.
1556         (tui_layout_command): Remove.
1557
1558 2019-07-17  Tom Tromey  <tom@tromey.com>
1559
1560         * tui/tui-layout.h (tui/tui-layout): Return void.
1561         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1562
1563 2019-07-17  Tom Tromey  <tom@tromey.com>
1564
1565         * tui/tui-layout.c (show_source_disasm_command, show_data):
1566         Update.
1567         (reset_locator): Remove.
1568         (show_source_or_disasm_and_command): Update.
1569
1570 2019-07-17  Tom Tromey  <tom@tromey.com>
1571
1572         * tui/tui-source.c (tui_source_window_base::reset): Remove
1573         win_type parameter.
1574         * tui/tui-layout.c (make_command_window, make_source_window)
1575         (make_disasm_window, make_data_window)
1576         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1577         (reset_locator, show_source_or_disasm_and_command): Update.
1578         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1579         win_type parameter.
1580         (struct tui_source_window_base) <reset>: Likewise.
1581
1582 2019-07-17  Tom Tromey  <tom@tromey.com>
1583
1584         * tui/tui-layout.c (show_source_disasm_command): Use
1585         reset_locator.
1586         (reset_locator): New function.
1587         (init_and_make_win): Remove.
1588         (show_source_or_disasm_and_command): Use reset_locator.
1589
1590 2019-07-17  Tom Tromey  <tom@tromey.com>
1591
1592         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1593         condition.
1594         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1595         Remove condition.
1596         * tui/tui-source.c (tui_source_window_base::reset): New method.
1597         * tui/tui-layout.c (make_command_window): Don't call
1598         init_and_make_win.
1599         (make_source_window, make_disasm_window): Don't call
1600         make_source_or_disasm_window.
1601         (make_data_window): Don't call init_and_make_win.  Change calling
1602         convention.
1603         (show_source_disasm_command, show_data): Simplify.
1604         (make_source_or_disasm_window): Remove.
1605         (show_source_or_disasm_and_command): Simplify.
1606         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1607         (struct tui_source_window_base) <reset>: Likewise.
1608         <execution_info>: Remove initializer.
1609         * tui/tui-data.c (tui_source_window_base): Initialize
1610         execution_info.
1611
1612 2019-07-17  Tom Tromey  <tom@tromey.com>
1613
1614         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1615         variable.
1616
1617 2019-07-17  Tom Tromey  <tom@tromey.com>
1618
1619         * tui/tui.c (tui_rl_other_window): Update.
1620         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1621         superclass method first.  Always iterate over regs_content.
1622         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1623         method.
1624         * tui/tui-win.c (tui_set_focus_command): Update.
1625
1626 2019-07-17  Tom Tromey  <tom@tromey.com>
1627
1628         * tui/tui-win.c (tui_set_focus_command): Rename from
1629         tui_set_focus.  Call tui_enable.
1630         (tui_set_focus_command): Remove.
1631
1632 2019-07-17  Tom Tromey  <tom@tromey.com>
1633
1634         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1635         refresh_window.
1636         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1637         touchwin.
1638         (tui_data_window::refresh_window): Call refresh_window on data
1639         items.  Always call superclass refresh_window.
1640         (tui_win_info::refresh): Remove.
1641         (tui_source_window_base::refresh_window): Update.
1642         (tui_refresh_all): Update.
1643         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1644         refresh_window.
1645         (show_source_or_disasm_and_command): Likewise.
1646         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1647         (struct tui_source_window_base) <refresh>: Likewise.
1648
1649 2019-07-17  Tom Tromey  <tom@tromey.com>
1650
1651         * tui/tui-winsource.c (tui_clear_source_content)
1652         (tui_show_source_content): Update.
1653         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1654         whether content is empty.
1655         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1656         Remove.
1657
1658 2019-07-17  Tom Tromey  <tom@tromey.com>
1659
1660         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1661         window's contents.
1662         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1663         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1664
1665 2019-07-17  Tom Tromey  <tom@tromey.com>
1666
1667         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1668         (struct tui_data_item_window): Update.
1669
1670 2019-07-17  Tom Tromey  <tom@tromey.com>
1671
1672         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1673         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1674         defines.
1675
1676 2019-07-17  Tom Tromey  <tom@tromey.com>
1677
1678         * tui/tui-winsource.h (tui_erase_source_content)
1679         (tui_clear_source_content): Remove "display_prompt" parameter.
1680         * tui/tui-winsource.c (tui_update_source_window_as_is)
1681         (tui_update_source_windows_with_addr): Update.
1682         (tui_clear_source_content): Remove "display_prompt" parameter.
1683         (tui_erase_source_content): Likewise.  Simplify.
1684         (tui_show_source_content): Update.
1685         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1686         * tui/tui-stack.c (tui_show_frame_info): Update.
1687         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1688         Remove defines.
1689
1690 2019-07-17  Tom Tromey  <tom@tromey.com>
1691
1692         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1693         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1694         parameter.
1695         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1696         parameter.
1697
1698 2019-07-17  Tom Tromey  <tom@tromey.com>
1699
1700         * tui/tui-winsource.c (tui_clear_source_content)
1701         (tui_show_source_content, tui_show_exec_info_content)
1702         (tui_clear_exec_info_content): Update.
1703         * tui/tui-stack.c (tui_show_locator_content): Update.
1704         (tui_show_frame_info): Update.
1705         * tui/tui-source.h (tui_source_window): Don't declare.
1706         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1707         from tui_source_is_displayed.
1708         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1709         Remove field.
1710         (struct tui_source_window_base) <content_in_use>: New field.  Now
1711         bool.
1712         (struct tui_source_window) <showing_source_p>: New method.
1713         (TUI_SRC_WIN): Change cast.
1714         * tui/tui-data.c (tui_initialize_static_data): Update.
1715
1716 2019-07-17  Tom Tromey  <tom@tromey.com>
1717
1718         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1719         location_matches_p.
1720         * tui/tui-source.c (tui_source_window::location_matches_p): New
1721         method.
1722         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1723         method.
1724         * tui/tui-data.h (struct tui_source_window_base)
1725         <location_matches_p>: New method.
1726         (struct tui_source_window, struct tui_disasm_window)
1727         <location_matches_p>: Likewise.
1728
1729 2019-07-17  Tom Tromey  <tom@tromey.com>
1730
1731         * tui/tui-win.c (tui_set_win_height_command): Rename from
1732         tui_set_win_height.
1733         (tui_set_win_height_command): Remove.
1734
1735 2019-07-17  Tom Tromey  <tom@tromey.com>
1736
1737         * tui/tui-source.c (tui_source_window): New constructor.  Add
1738         observer.
1739         (~tui_source_window): New destructor.
1740         (tui_source_window::style_changed): New method.
1741         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1742         (tui_attach_detach_observers): Update.
1743         * tui/tui-data.h (struct tui_source_window): Make constructor not
1744         inline.  Add destructor.
1745         (struct tui_source_window) <style_changed>: New method.
1746         <m_observable>: New member.
1747
1748 2019-07-17  Tom Tromey  <tom@tromey.com>
1749
1750         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1751         * tui/tui-win.c (tui_resize_all): Fix typo.
1752
1753 2019-07-17  Tom Tromey  <tom@tromey.com>
1754
1755         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1756         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1757         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1758         * tui/tui-win.c (window_name_completer): Use foreach.
1759         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1760         (update_tab_width): Likewise.
1761         * tui/tui-layout.c (show_layout): Update.
1762         * tui/tui-data.h (class tui_window_iterator): New.
1763         (struct all_tui_windows): New.
1764         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1765
1766 2019-07-17  Tom Tromey  <tom@tromey.com>
1767
1768         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1769         parameter.  Don't reference globals.
1770         (tui_reg_command): Update.
1771
1772 2019-07-17  Tom Tromey  <tom@tromey.com>
1773
1774         * tui/tui-regs.c (tui_show_registers): Simplify.
1775
1776 2019-07-17  Tom Tromey  <tom@tromey.com>
1777
1778         * tui/tui-regs.c (tui_show_registers): Update.
1779         (tui_show_register_group): Add win_info parameter.
1780
1781 2019-07-17  Tom Tromey  <tom@tromey.com>
1782
1783         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1784         Rename from tui_display_reg_element_at_line.
1785         (tui_data_window::display_registers_from_line): Update.
1786         * tui/tui-data.h (struct tui_data_window)
1787         <display_reg_element_at_line>: New method.
1788
1789 2019-07-17  Tom Tromey  <tom@tromey.com>
1790
1791         * tui/tui-regs.h (tui_display_registers_from)
1792         (tui_display_registers_from_line): Don't declare.
1793         * tui/tui-windata.c (tui_data_window::display_all_data)
1794         (tui_data_window::refresh_all)
1795         (tui_data_window::do_scroll_vertical): Update.
1796         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1797         from tui_display_registers_from.
1798         (tui_display_reg_element_at_line): Update.
1799         (tui_data_window::display_registers_from_line): Rename from
1800         tui_display_registers_from_line.
1801         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1802         display_registers_from_line>: New methods.
1803
1804 2019-07-17  Tom Tromey  <tom@tromey.com>
1805
1806         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1807         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1808         from tui_erase_data_content.
1809         (tui_data_window::display_all_data)
1810         (tui_data_window::refresh_all)
1811         (tui_data_window::do_scroll_vertical): Update.
1812         * tui/tui-regs.c (tui_show_registers): Update.
1813         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1814         New method.
1815
1816 2019-07-17  Tom Tromey  <tom@tromey.com>
1817
1818         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1819         declare.
1820         * tui/tui-windata.c
1821         (tui_data_window::delete_data_content_windows): Rename from
1822         tui_delete_data_content_windows.
1823         (tui_data_window::display_all_data)
1824         (tui_data_window::do_scroll_vertical): Update.
1825         * tui/tui-data.h (struct tui_data_window)
1826         <delete_data_content_windows>: New method.
1827
1828 2019-07-17  Tom Tromey  <tom@tromey.com>
1829
1830         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1831         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1832
1833 2019-07-17  Tom Tromey  <tom@tromey.com>
1834
1835         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1836         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1837         from tui_display_all_data.
1838         * tui/tui-win.c
1839         (tui_data_window::do_make_visible_with_new_height): Update.
1840         * tui/tui-regs.c (tui_show_registers): Update.
1841         * tui/tui-layout.c (tui_set_layout): Update.
1842         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1843         method.
1844
1845 2019-07-17  Tom Tromey  <tom@tromey.com>
1846
1847         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1848         * tui/tui-windata.c (tui_display_data_from): Remove.
1849         (tui_data_window::refresh_all): Update.
1850
1851 2019-07-17  Tom Tromey  <tom@tromey.com>
1852
1853         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1854         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1855         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1856         tui_display_registers_from_line.
1857         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1858         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1859         "force_display" parameter.
1860
1861 2019-07-17  Tom Tromey  <tom@tromey.com>
1862
1863         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1864         declare.
1865         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1866         Rename from tui_first_reg_element_no_inline.
1867         (tui_display_reg_element_at_line)
1868         (tui_display_registers_from_line): Update.
1869         * tui/tui-data.h (struct tui_data_window)
1870         <first_reg_element_no_inline>: New method.
1871
1872 2019-07-17  Tom Tromey  <tom@tromey.com>
1873
1874         * tui/tui-windata.c (tui_display_data_from)
1875         (tui_data_window::do_scroll_vertical): Update.
1876         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1877         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1878         Rename from tui_line_from_reg_element_no.
1879         (tui_display_registers_from_line): Update.
1880         * tui/tui-data.h (struct tui_data_window)
1881         <line_from_reg_element_no>: New method.
1882
1883 2019-07-17  Tom Tromey  <tom@tromey.com>
1884
1885         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1886         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1887         tui_last_regs_line_no.
1888         (tui_display_reg_element_at_line)
1889         (tui_display_registers_from_line): Update.
1890         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1891         method.
1892
1893 2019-07-17  Tom Tromey  <tom@tromey.com>
1894
1895         PR tui/24722:
1896         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1897         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1898         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1899         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1900         (tui_update_breakpoint_info): Likewise.
1901         * tui/tui-hooks.c (tui_event_create_breakpoint)
1902         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1903         Update.
1904
1905 2019-07-17  Tom Tromey  <tom@tromey.com>
1906
1907         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1908
1909 2019-07-17  Tom Tromey  <tom@tromey.com>
1910
1911         * tui/tui-winsource.c (tui_update_source_window_as_is)
1912         (tui_update_source_windows_with_addr): Update.
1913         * tui/tui-source.h (tui_set_source_content)
1914         (tui_show_symtab_source): Add "win_info" parameter.
1915         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1916         parameter.
1917         (tui_show_symtab_source): Likewise.
1918
1919 2019-07-17  Tom Tromey  <tom@tromey.com>
1920
1921         * tui/tui-wingeneral.c
1922         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1923
1924 2019-07-17  Tom Tromey  <tom@tromey.com>
1925
1926         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1927         (struct tui_cmd_window) <can_scroll>: New method.
1928         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1929         method.
1930
1931 2019-07-17  Tom Tromey  <tromey@adacore.com>
1932
1933         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1934         do_field_signed>: Rename.  Change type of "value".
1935         * ui-out.c (ui_out::field_signed): Rename from field_int.
1936         Change type of "value".
1937         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1938         type of "value".
1939         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1940         do_field_int.  Change type of "value".
1941         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1942         do_field_int.  Change type of "value".
1943         * tracepoint.c (trace_status_mi, tfind_1)
1944         (print_one_static_tracepoint_marker): Update.
1945         * thread.c (print_thread_info_1, print_selected_thread_frame):
1946         Update.
1947         * stack.c (print_frame, print_frame_info): Update.
1948         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1949         Update.
1950         * source.c (print_source_lines_base): Update.
1951         * skip.c (info_skip_command): Update.
1952         * record-btrace.c (btrace_ui_out_decode_error)
1953         (btrace_call_history_src_line): Update.
1954         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1955         Update.
1956         * progspace.c (print_program_space): Update.
1957         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1958         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1959         do_field_int.  Change type of "value".
1960         * mi/mi-out.c (mi_ui_out::do_table_begin)
1961         (mi_ui_out::do_table_header): Update.
1962         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1963         type of "value".
1964         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1965         (mi_cmd_data_list_changed_registers, output_register)
1966         (mi_cmd_data_read_memory, mi_load_progress)
1967         (mi_cmd_trace_frame_collected): Update.
1968         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1969         Update.
1970         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1971         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1972         (mi_cmd_var_list_children, varobj_update_one): Update.
1973         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1974         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1975         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1976         * inferior.c (print_inferior): Update.
1977         * gdb_bfd.c (print_one_bfd): Update.
1978         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1979         Update.
1980         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1981         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1982         do_field_int.  Change type of "value".
1983         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1984         do_field_int.  Change type of "value".
1985         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1986         (print_one_breakpoint_location, print_it_catch_fork)
1987         (print_one_catch_fork, print_it_catch_vfork)
1988         (print_one_catch_vfork, print_it_catch_solib)
1989         (print_it_catch_exec, print_it_ranged_breakpoint)
1990         (print_mention_watchpoint, print_mention_masked_watchpoint)
1991         (bkpt_print_it, update_static_tracepoint): Update.
1992         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1993         * break-catch-syscall.c (print_it_catch_syscall): Update.
1994         * ada-tasks.c (print_ada_task_info): Update.
1995         * ada-lang.c (print_it_exception, print_mention_exception):
1996         Update.
1997
1998 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1999
2000         PR breakpoints/24541
2001         * gdbarch.c: Regenerate.
2002         * gdbarch.h: Regenerate.
2003         * gdbarch.sh: Adjust return type and parameter types for
2004         'stap_adjust_register'.
2005         (i386_stap_adjust_register): Adjust signature and return new
2006         register name.
2007         * stap-probe.c (stap_parse_register_operand): Adjust use of
2008         'gdbarch_stap_adjust_register'.
2009
2010 2019-07-17  Tom Tromey  <tromey@adacore.com>
2011
2012         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2013         declare VEC.
2014         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2015         std::vector.
2016         (struct s390_process_info): Add initializers.
2017         (s390_add_process): Use new.
2018         (s390_linux_nat_target::low_forget_process): Use delete.
2019         (s390_linux_nat_target::low_new_fork)
2020         (s390_linux_nat_target::stopped_by_watchpoint)
2021         (s390_linux_nat_target::low_prepare_to_resume)
2022         (s390_linux_nat_target::insert_watchpoint)
2023         (s390_linux_nat_target::insert_hw_breakpoint)
2024         (s390_linux_nat_target::remove_watchpoint)
2025         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2026
2027 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2028
2029         * aarch64-fbsd-nat.c: Include regcache.h.
2030         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2031         argument.
2032         (aarch64_fbsd_nat_target::fetch_registers)
2033         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2034         variable.
2035         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2036
2037 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2038
2039         * fbsd-nat.c: Include gdbarch.h.
2040
2041 2019-07-15  Tom Tromey  <tromey@adacore.com>
2042
2043         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2044
2045 2019-07-15  Tom Tromey  <tromey@adacore.com>
2046
2047         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2048         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2049         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2050         * cli-out.c (cli_ui_out::do_field_int): New method.
2051         * ui-out.c (ui_out::field_unsigned): New method.
2052         * symfile.c (generic_load): Use field_unsigned.
2053         (print_transfer_performance): Likewise.
2054         * record-btrace.c (ui_out_field_uint): Remove.
2055         (btrace_call_history_insn_range, btrace_call_history): Use
2056         field_unsigned.
2057         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2058         field_unsigned.
2059         * ui-out.h (class ui_out) <field_unsigned>: New method.
2060         <do_field_unsigned>: Likewise.
2061
2062 2019-07-15  Tom Tromey  <tromey@adacore.com>
2063
2064         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2065         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2066         * target.c (flash_erase_command): Use field_string.
2067         * infrun.c (print_signal_received_reason): Use field_string.
2068         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2069         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2070         field_string.
2071         * ada-tasks.c (print_ada_task_info): Use field_string.
2072
2073 2019-07-15  Tom Tromey  <tromey@adacore.com>
2074
2075         * target.c (flash_erase_command): Use field_core_addr.
2076         * symfile.c (generic_load): Use field_core_addr.
2077         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2078         Use field_core_addr.
2079         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2080         field_core_addr.
2081
2082 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2083
2084         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2085         value if its desired type is smaller than a CORE_ADDR and signed.
2086
2087 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2088
2089         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2090         of changes to field names, and use new is_reference field to
2091         decide if a property is a reference or not.
2092         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2093         field.
2094         (struct dwarf2_property_baton): Update header comment, rename
2095         'referenced_type' to 'property_type' and update comments.
2096         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2097         default property type, store in property baton, update to take
2098         accound of renamed field.
2099         (read_func_scope): Update call to attr_to_dynamic_prop.
2100         (read_array_type): Likewise.
2101         (dwarf2_per_cu_addr_sized_int_type): New function.
2102         (read_subrange_index_type): Move type finding code to
2103         dwarf2_per_cu_addr_sized_int_type.
2104         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2105         (dwarf2_per_cu_addr_type): New function.
2106         (set_die_type): Update calls to attr_to_dynamic_prop.
2107
2108 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2109
2110         * dwarf2read.c (read_subrange_index_type): New function.
2111         (read_subrange_type): Move code into new function and call it.
2112         * gdbtypes.c (create_range_type): Add some asserts.
2113
2114 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2115
2116         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2117         update return statements.
2118         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2119         declaration, and update comment to match.
2120         * gdbtypes.c (resolve_dynamic_array): Update call to
2121         dwarf2_evaluate_property to match new return type.
2122
2123 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2124
2125         * valarith.c (value_subscripted_rvalue): Change lowerbound
2126         parameter type from int to LONGEST.
2127         * value.h (value_subscripted_rvalue): Likewise in declaration.
2128
2129 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2130
2131         * cli/cli-utils.c (info_print_command_completer): New function.
2132         * cli/cli-utils.h: Add 'completer.h' include, and forward
2133         declaration for 'struct cmd_list_element'.
2134         (info_print_command_completer): Declare.
2135         * stack.c (_initialize_stack): Add completer for 'info locals' and
2136         'info args'.
2137         * symtab.c (_initialize_symtab): Add completer for 'info
2138         variables' and 'info functions'.
2139         * NEWS: Mention completion for additional info commands.
2140
2141 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2142
2143         * cli/cli-utils.c (extract_info_print_args): Delete.
2144         (extract_arg_maybe_quoted): Delete.
2145         (info_print_options_defs): New variable.
2146         (make_info_print_options_def_group): New function.
2147         (extract_info_print_options): Define new function.
2148         * cli/cli-utils.h (extract_info_print_args): Delete.
2149         (struct info_print_options): New structure.
2150         (extract_info_print_options): Declare new function.
2151         * stack.c (info_locals_command): Update to use new
2152         extract_info_print_options, also add a header comment.
2153         (info_args_command): Likewise.
2154         * symtab.c (info_variables_command): Likewise.
2155         (info_functions_command): Likewise.
2156
2157 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2158
2159         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2160         to extract string arguments.
2161         * common/common-utils.c (extract_string_maybe_quoted): New function.
2162         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2163
2164 2019-07-11  Tom Tromey  <tromey@adacore.com>
2165
2166         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2167         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2168         * top.h (gdbinit): Don't declare.
2169         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2170         into...
2171         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2172         * top.c (gdb_init): Don't call init_cli_cmds.
2173         (gdbinit): Remove.
2174         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2175
2176 2019-07-11  Tom Tromey  <tromey@adacore.com>
2177
2178         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2179         after it has been moved.
2180
2181 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2182
2183         * valops.c (value_must_coerce_to_target): Change return type to
2184         bool.
2185         * value.h (value_must_coerce_to_target): Likewise.
2186
2187 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2188
2189         * breakpoint.c (is_hardware_watchpoint): Remove
2190         forward-declaration.
2191         (is_masked_watchpoint): Change return type to bool.
2192         (is_tracepoint): Likewise.
2193         (is_breakpoint): Likewise.
2194         (is_hardware_watchpoint): Likewise.
2195         (is_watchpoint): Likewise.
2196         (is_no_memory_software_watchpoint): Likewise.
2197         (is_catchpoint): Likewise.
2198         (breakpoint_1): Make FILTER parameter's return type bool.
2199         is_masked_watchpoint): Change return type to bool.
2200         (save_breakpoints): Make FILTER parameter's return type bool.
2201         * breakpoint.h (is_breakpoint): Change return type to bool.
2202         (is_watchpoint): Likewise.
2203         (is_catchpoint): Likewise.
2204         (is_tracepoint): Likewise.
2205
2206 2019-07-10  Tom Tromey  <tom@tromey.com>
2207
2208         * defs.h: Don't include gdbarch.h.
2209         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2210         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2211         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2212         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2213         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2214         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2215         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2216         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2217         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2218         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2219         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2220         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2221         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2222         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2223         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2224         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2225         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2226         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2227         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2228         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2229         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2230         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2231         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2232         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2233         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2234         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2235         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2236
2237 2019-07-10  Tom Tromey  <tromey@adacore.com>
2238
2239         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2240         * breakpoint.c (init_ada_exception_breakpoint): Register as
2241         bp_catchpoint.
2242         (print_one_breakpoint_location, print_one_breakpoint): Use
2243         is_ada_exception_catchpoint.
2244         * ada-lang.c (class ada_catchpoint_location): Pass
2245         bp_loc_software_breakpoint to bp_location constructor.
2246         (is_ada_exception_catchpoint): New function.
2247
2248 2019-07-10  Tom Tromey  <tromey@adacore.com>
2249
2250         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2251         VEC.
2252         (struct arm_exidx_entry): New method operator<.
2253         (struct arm_exidx_data) <section_maps>: Change type.
2254         (arm_exidx_data_free): Remove.
2255         (arm_exidx_data_key): Change type.  Move lower.
2256         (arm_exidx_new_objfile): Update.
2257         (arm_compare_exidx_entries): Remove.
2258         (arm_find_exidx_entry, _initialize_arm_tdep)
2259
2260 2019-07-10  Tom Tromey  <tromey@adacore.com>
2261
2262         * solib-spu.c (ocl_program_data_key): Change type.
2263         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2264         Update.
2265
2266 2019-07-10  Tom Tromey  <tromey@adacore.com>
2267
2268         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2269         (struct solib_aix_inferior_data) <library_list>: Change type.
2270         (solib_aix_inferior_data_handle): Change type.
2271         (get_solib_aix_inferior_data): Update.
2272         (solib_aix_free_library_list): Remove.
2273         (library_list_start_library): Update.
2274         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2275         return type.
2276         (solib_aix_get_library_list)
2277         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2278         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2279
2280 2019-07-10  Tom Tromey  <tromey@adacore.com>
2281
2282         * solib-dsbt.c (struct dsbt_info): Add initializers.
2283         (solib_dsbt_pspace_data): Change type.
2284         (dsbt_pspace_data_cleanup): Remove.
2285         (get_dsbt_info, _initialize_dsbt_solib): Update.
2286
2287 2019-07-10  Tom Tromey  <tromey@adacore.com>
2288
2289         * spu-tdep.c (spu_overlay_data): Change type.
2290         (spu_get_overlay_table, spu_overlay_new_objfile)
2291         (_initialize_spu_tdep): Update.
2292
2293 2019-07-10  Tom Tromey  <tromey@adacore.com>
2294
2295         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2296         destructor.
2297         (dbx_objfile_data_key): Change type and declare later.
2298         (DBX_SYMFILE_INFO): Rewrite.
2299         * dbxread.c (dbx_objfile_data_key): Change type.
2300         (dbx_symfile_init): Update.
2301         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2302         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2303         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2304
2305 2019-07-10  Tom Tromey  <tromey@adacore.com>
2306
2307         * jit.c (jit_program_space_key): Change type.  Move lower.
2308         (get_jit_program_space_data): Update.
2309         (jit_program_space_data_cleanup): Remove.
2310         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2311         Update.
2312         (struct jit_program_space_data): Add initializers.
2313
2314 2019-07-10  Tom Tromey  <tromey@adacore.com>
2315
2316         * solib-darwin.c (struct darwin_info): Add initializers.
2317         (solib_darwin_pspace_data): Change type.
2318         (darwin_pspace_data_cleanup): Remove.
2319         (get_darwin_info, _initialize_darwin_solib): Update.
2320
2321 2019-07-10  Tom Tromey  <tromey@adacore.com>
2322
2323         * remote-sim.c (struct sim_inferior_data): Add initializers,
2324         constructor, and destructor.
2325         (sim_inferior_data_key): Change type.  Move lower.
2326         (check_for_duplicate_sim_descriptor): Update.
2327         (get_sim_inferior_data): Use new.  Update.
2328         (~sim_inferior_data_cleanup): Rename from
2329         sim_inferior_data_cleanup.  Simplify.
2330         (gdbsim_close_inferior, simulator_command)
2331         (sim_command_completer, _initialize_remote_sim): Update.
2332         (next_pid, INITIAL_PID): Move earlier.
2333
2334 2019-07-10  Tom Tromey  <tromey@adacore.com>
2335
2336         * python/python-internal.h (create_thread_object): Return
2337         gdbpy_ref.
2338         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2339         * python/py-inferior.c (struct threadlist_entry): Add
2340         constructor.
2341         <thread_obj>: Now a gdbpy_ref.
2342         (thread_to_thread_object): Update.
2343         (add_thread_object): Use new.
2344         (delete_thread_object): Use delete.
2345         (infpy_threads): Update.
2346         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2347         GIL.
2348
2349 2019-07-10  Tom Tromey  <tromey@adacore.com>
2350
2351         * valops.c (value_cast): Specialize error message for Ada.
2352
2353 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2354
2355         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2356
2357 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2358
2359         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2360         bpstat_should_step): Return bool, adjust comments.
2361         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2362         bpstat_should_step): Likewise.
2363
2364 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2365
2366         * features/Makefile: Use feature target descriptions for Arm.
2367         * features/arm/arm-core.c: Generate new file.
2368         * features/arm/arm-fpa.c: Likewise.
2369         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2370         * features/arm/arm-m-profile.c: Likewise.
2371         * features/arm/arm-vfpv2.c: Likewise.
2372         * features/arm/arm-vfpv3.c: Likewise.
2373         * features/arm/xscale-iwmmxt.c: Likewise.
2374         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2375
2376 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2377
2378         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2379         ptrace earlier.
2380
2381 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2382
2383         * features/aarch64-pauth.c: Regenerate.
2384
2385 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2386
2387         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2388         bool.
2389         (bpstat_what): Use false instead of 0.
2390
2391 2019-07-09  Pedro Alves  <palves@redhat.com>
2392
2393         * break-catch-throw.c (is_exception_catchpoint): New.
2394         * breakpoint.c (print_one_breakpoint_location): New parameter
2395         'raw_loc'.  Handle it.  Use
2396         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2397         looking at the breakpoint's type.
2398         (print_one_breakpoint): If handling "maint info breakpoints", also
2399         print locations of exception catchpoints.
2400         * breakpoint.h (is_exception_catchpoint): Declare.
2401
2402 2019-07-09  Pedro Alves  <palves@redhat.com>
2403
2404         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2405         "addr" field.
2406         (allocate_location_exception_catchpoint): New.
2407         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2408         (initialize_throw_catchpoint_ops): Install
2409         allocate_location_exception_catchpoint as allocate_location
2410         method.
2411         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2412         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2413         bp_loc_other.
2414         (breakpoint_address_is_meaningful): Delete.
2415         (bl_address_is_meaningful): New.
2416         (breakpoint_locations_match): Adjust comment.
2417         (bp_location_from_bp_type): New, factored out of...
2418         (bp_location::bp_location(breakpoint *)): ... this.
2419         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2420         factored out of...
2421         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2422         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2423         breakpoint_address_is_meaningful.
2424         (bp_locations_compare): Adjust comment.
2425         (update_global_location_list): Use bl_address_is_meaningful
2426         instead of breakpoint_address_is_meaningful.
2427         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2428         explicit.
2429         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2430         * python/py-breakpoint.c (bppy_get_location): No longer check
2431         whether location is null.
2432
2433 2019-07-09  Pedro Alves  <palves@redhat.com>
2434
2435         PR c++/15468
2436         * breakpoint.c (print_one_breakpoint_location): Remove
2437         single-location assert.
2438
2439 2019-07-09  Tom Tromey  <tom@tromey.com>
2440
2441         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2442         * configure: Rebuild.
2443         * configure.ac: Change common to gdbsupport.
2444         * gdbsupport: Rename from common.
2445         * acinclude.m4: Change common to gdbsupport.
2446         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2447         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2448         gdbsupport.
2449         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2450         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2451         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2452         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2453         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2454         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2455         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2456         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2457         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2458         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2459         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2460         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2461         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2462         coff-pe-read.c, command.h, compile/compile-c-support.c,
2463         compile/compile-c.h, compile/compile-cplus-symbols.c,
2464         compile/compile-cplus-types.c, compile/compile-cplus.h,
2465         compile/compile-loc2c.c, compile/compile.c, completer.c,
2466         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2467         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2468         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2469         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2470         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2471         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2472         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2473         features/aarch64-core.c, features/aarch64-fpu.c,
2474         features/aarch64-pauth.c, features/aarch64-sve.c,
2475         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2476         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2477         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2478         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2479         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2480         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2481         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2482         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2483         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2484         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2485         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2486         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2487         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2488         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2489         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2490         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2491         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2492         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2493         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2494         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2495         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2496         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2497         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2498         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2499         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2500         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2501         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2502         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2503         minsyms.c, mips-linux-tdep.c, namespace.h,
2504         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2505         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2506         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2507         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2508         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2509         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2510         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2511         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2512         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2513         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2514         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2515         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2516         procfs.c, producer.c, progspace.h, psymtab.h,
2517         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2518         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2519         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2520         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2521         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2522         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2523         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2524         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2525         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2526         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2527         target-memory.c, target.c, target.h, target/waitstatus.c,
2528         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2529         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2530         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2531         unittests/array-view-selftests.c,
2532         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2533         unittests/common-utils-selftests.c,
2534         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2535         unittests/format_pieces-selftests.c,
2536         unittests/function-view-selftests.c,
2537         unittests/lookup_name_info-selftests.c,
2538         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2539         unittests/mkdir-recursive-selftests.c,
2540         unittests/observable-selftests.c,
2541         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2542         unittests/parse-connection-spec-selftests.c,
2543         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2544         unittests/scoped_fd-selftests.c,
2545         unittests/scoped_mmap-selftests.c,
2546         unittests/scoped_restore-selftests.c,
2547         unittests/string_view-selftests.c, unittests/style-selftests.c,
2548         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2549         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2550         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2551         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2552         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2553         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2554
2555 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2556
2557         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2558         bool value.
2559         (decode_digits_ordinary): Set explicit_line field in sal.
2560         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2561         symtab_and_line that was set on an explicit line number in
2562         assembler code.  Do always update the recorded symtab and line if
2563         we do skip the prologue.
2564
2565 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2566
2567         * breakpoint.c (set_breakpoint_location_function): Remove
2568         explicit_loc parameter.
2569         (momentary_breakpoint_from_master): Update call to
2570         set_breakpoint_location_function.
2571         (add_location_to_breakpoint): Likewise.
2572
2573 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2574
2575         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2576         required features based on default bfd type when no specific bfd
2577         is present.
2578
2579 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2580
2581         * NEWS: Mention that GDB printf and eval commands can now print
2582         C-style and Ada-style convenience var strings without
2583         calling the inferior.
2584         * printcmd.c (printf_c_string): Locally print GDB internal var
2585         instead of transiting via the inferior.
2586         (printf_wide_c_string): Likewise.
2587
2588 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2589
2590         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2591
2592 2019-07-04  Tom Tromey  <tom@tromey.com>
2593
2594         PR tui/24724:
2595         * tui/tui-winsource.c (tui_clear_source_content): Update.
2596         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2597         (tui_update_breakpoint_info): Update.
2598         (tui_set_exec_info_content): Update.
2599         * tui/tui-source.c (tui_set_source_content_nil): Update.
2600         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2601         has_break.
2602         * tui/tui-data.h (enum tui_bp_flag): New.
2603         (tui_bp_flags): New enum flags type.
2604         (struct tui_source_element) <break_mode>: Change type.  Rename
2605         from has_break.
2606         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2607         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2608         constants.
2609         * tui/tui-winsource.h: Fix comment.
2610
2611 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2612
2613         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2614         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2615         (store_fpregs_to_thread)
2616         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2617         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2618         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2619         (IWMMXT_REGS_SIZE): Add define.
2620         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2621         (fetch_vfp_regs, store_vfp_regs)
2622         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2623         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2624
2625 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2626
2627         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2628         defines.
2629         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2630         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2631         (ARM_INT_REGISTER_SIZE): ...to this.
2632         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2633         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2634         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2635         (arm_linux_collect_gregset, supply_nwfpe_register)
2636         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2637         defines.
2638         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2639         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2640         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2641         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2642         (arm_return_in_memory, arm_store_return_value)
2643         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2644         (arm_record_ld_st_multiple): Likewise.
2645         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2646         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2647
2648 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2649
2650         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2651         AARCH64_DISPLACED_MODIFIED_INSNS.
2652         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2653         (aarch64_displaced_step_copy_insn): Likewise.
2654         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2655         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2656         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2657         ARM_DISPLACED_MODIFIED_INSNS.
2658         * arm-tdep.c (arm_gdbarch_init): Likewise.
2659         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2660         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2661         (struct arm_displaced_step_closure): Use
2662         ARM_DISPLACED_MODIFIED_INSNS.
2663
2664 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2665
2666         * features/Makefile: Remove unused xml files.
2667         * features/aarch64.xml: Remove.
2668         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2669         * features/i386/amd64-avx-avx512.xml: Remove.
2670         * features/i386/amd64-avx-linux.xml: Remove.
2671         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2672         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2673         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2674         * features/i386/amd64-avx-mpx.xml: Remove.
2675         * features/i386/amd64-avx.xml: Remove.
2676         * features/i386/amd64-linux.xml: Remove.
2677         * features/i386/amd64-mpx-linux.xml: Remove.
2678         * features/i386/amd64-mpx.xml: Remove.
2679         * features/i386/amd64.xml: Remove.
2680         * features/i386/i386-avx-avx512-linux.xml: Remove.
2681         * features/i386/i386-avx-avx512.xml: Remove.
2682         * features/i386/i386-avx-linux.xml: Remove.
2683         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2684         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2685         * features/i386/i386-avx-mpx-linux.xml: Remove.
2686         * features/i386/i386-avx-mpx.xml: Remove.
2687         * features/i386/i386-avx.xml: Remove.
2688         * features/i386/i386-linux.xml: Remove.
2689         * features/i386/i386-mmx-linux.xml: Remove.
2690         * features/i386/i386-mmx.xml: Remove.
2691         * features/i386/i386-mpx-linux.xml: Remove.
2692         * features/i386/i386-mpx.xml: Remove.
2693         * features/i386/i386.xml: Remove.
2694         * features/i386/x32-avx-avx512-linux.xml: Remove.
2695         * features/i386/x32-avx-linux.xml: Remove.
2696         * features/i386/x32-linux.xml: Remove.
2697
2698 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2699
2700         * regformats/aarch64.dat: Remove.
2701         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2702         * regformats/i386/amd64-avx-linux.dat: Remove.
2703         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2704         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2705         * regformats/i386/amd64-linux.dat: Remove.
2706         * regformats/i386/amd64-mpx-linux.dat: Remove.
2707         * regformats/i386/amd64.dat: Remove.
2708         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2709         * regformats/i386/i386-avx-linux.dat: Remove.
2710         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2711         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2712         * regformats/i386/i386-linux.dat: Remove.
2713         * regformats/i386/i386-mmx-linux.dat: Remove.
2714         * regformats/i386/i386-mpx-linux.dat: Remove.
2715         * regformats/i386/i386.dat: Remove.
2716         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2717         * regformats/i386/x32-avx-linux.dat: Remove.
2718         * regformats/i386/x32-linux.dat: Remove.
2719
2720 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2721
2722         * aarch64-tdep.c: Remove xml self tests.
2723         * amd64-linux-tdep.c: Likewise.
2724         * amd64-tdep.c: Likewise.
2725         * i386-linux-tdep.c: Likewise.
2726         * i386-tdep.c: Likewise.
2727
2728 2019-07-03  Pedro Alves  <palves@redhat.com>
2729
2730         PR cli/24732
2731         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2732         (pipe_cmd_option_defs): New.
2733         (make_pipe_cmd_options_def_group): New.
2734         (pipe_command): Use gdb::option::process_options.
2735         (pipe_command_completer): New function.
2736         (_initialize_cli_cmds): Install completer for "pipe" command.
2737
2738 2019-07-03  Pedro Alves  <palves@redhat.com>
2739
2740         * cli/cli-option.c (union option_value) <string>: New field.
2741         (struct option_def_and_value): Add ctor, move ctor, dtor and
2742         use DISABLE_COPY_AND_ASSIGN.
2743         (option_def_and_value::clear_value): New.
2744         (parse_option, save_option_value_in_ctx, get_val_type_str)
2745         (add_setshow_cmds_for_options): Handle var_string.
2746         * cli-option.h (union option_def::var_address) <string>: New
2747         field.
2748         (struct string_option_def): New.
2749         * maint-test-options.c (struct test_options_opts): Add default
2750         ctor and use DISABLE_COPY_AND_ASSIGN.
2751         <string_opt>: New field.
2752         (test_options_opts::~test_options_opts): New.
2753         (test_options_opts::dump): Also dump "-string".
2754         (test_options_option_defs): Install "string.
2755
2756 2019-07-03  Pedro Alves  <palves@redhat.com>
2757
2758         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2759         option_value with a null enumeration.
2760         (complete_options): Save the option values in the context.
2761         (save_option_value_in_ctx): New, factored out from ...
2762         (process_options): ... here.
2763         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2764         of the function.
2765         * maint-test-options.c (test_options_opts::dump): New, factored
2766         out from ...
2767         (maintenance_test_options_command_mode): ... here.
2768         (maintenance_test_options_command_completion_result): Delete.
2769         (maintenance_test_options_command_completion_text): Update
2770         comment.
2771         (maintenance_show_test_options_completion_result): Change
2772         prototype.  Just print
2773         maintenance_test_options_command_completion_text.
2774         (save_completion_result): New.
2775         (maintenance_test_options_completer_mode): Pass options context to
2776         complete_options, and then save a dump.
2777         (_initialize_maint_test_options): Use add_cmd to install "maint
2778         show test-options-completion-result".
2779
2780 2019-07-03  Pedro Alves  <palves@redhat.com>
2781
2782         * NEWS (New commands): Mention "with" and "maint with".
2783         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2784         (with_command, with_command_completer): New.
2785         (pipe_command): Adjust to new repeat_previous
2786         interface.
2787         (_initialize_cli_cmds): Install the "with" command and its "w"
2788         alias.
2789         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2790         declarations.
2791         * cli/cli-setshow.c (parse_cli_var_uinteger)
2792         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2793         argument strings for all var_types.
2794         (get_setshow_command_value_string): New, factored out from ...
2795         (do_show_command): ... this.
2796         * cli/cli-setshow.h: Include <string>.
2797         (get_setshow_command_value_string): Declare.
2798         * command.h (repeat_previous): Now returns const char *.  Adjust
2799         comment.
2800         * maint.c: Include "cli/cli-cmds.h".
2801         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2802         (_initialize_maint_cmds): Register the "maintenance with" command.
2803         * top.c (repeat_previous): Move bits from pipe_command here:
2804         Return the saved command line, if any; error out if there's no
2805         command to relaunch.
2806
2807 2019-07-03  Pedro Alves  <palves@redhat.com>
2808
2809         * NEWS (New commands): Mention "maint set/show test-settings"
2810         instead of "maint test-settings".
2811         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2812         (maintenance_test_settings_set_list): Rename to ...
2813         (maintenance_set_test_settings_list): ... this.
2814         (maintenance_test_settings_show_list): Rename to  ...
2815         (maintenance_show_test_settings_list): ... this.
2816         (maintenance_test_settings_cmd): Delete.
2817         (maintenance_test_settings_set_cmd): ...
2818         (maintenance_set_test_settings_cmd): ... this.
2819         (maintenance_test_settings_show_cmd): ...
2820         (maintenance_show_test_settings_cmd): ... this.
2821         (maintenance_test_settings_show_value_cmd):
2822         (maintenance_show_test_settings_value_cmd): ... this.
2823         (_initialize_maint_test_settings): No longer install the "maint
2824         test-settings" prefix command.  Rename "maint test-settings set"
2825         to "maint set test-settings", and "maint test-settings show" to
2826         "maint show test-settings".  Adjust all subcommands.
2827
2828 2019-07-03  Pedro Alves  <palves@redhat.com>
2829
2830         * maint-test-settings.c: Fix file's intro comment.  Replace all
2831         references to "test-options" with references to "test-settings",
2832         in comments.
2833
2834 2019-07-03  Pedro Alves  <palves@redhat.com>
2835
2836         * maint-test-settings.c (maintenance_test_settings_xxx)
2837         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2838         New.
2839         (maintenance_test_settings_enums): Use them.
2840         (maintenance_test_settings_enum): Default to
2841         maintenance_test_settings_xxx.
2842         (_initialize_maint_test_settings): Initialize
2843         MAINTENANCE_TEST_SETTINGS_FILENAME.
2844
2845 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2846
2847         * breakpoint.h (remove_breakpoints_inf): Change return type to
2848         void, move function documentation here.
2849         * breakpoint.c (remove_breakpoints_inf): Change return type to
2850         void, move function documentation to header.
2851
2852 2019-07-02  Pedro Alves  <palves@redhat.com>
2853
2854         * NEWS (Completion improvements): Mention "info threads".
2855         * thread.c (struct info_threads_opts, info_threads_option_defs)
2856         (make_info_threads_options_def_group): New.
2857         (info_threads_command): Use gdb::option::process_options.
2858         (info_threads_command_completer): New.
2859         (_initialize_thread): Use gdb::option::build_help to build the
2860         help text for "info threads".
2861
2862 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2863
2864         * defs.h (generic_load): Move from here...
2865         * symfile.h (generic_load): ... to here.  Rename name parameter
2866         to args.
2867         * symfile.c (generic_load): Add comment.
2868
2869 2019-07-01  Tom Tromey  <tromey@adacore.com>
2870
2871         * dwarf2read.c
2872         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2873         declaration of without_params.  Fix formatting.
2874
2875 2019-07-01  Tom Tromey  <tromey@adacore.com>
2876
2877         * ada-exp.y (find_primitive_type): Update.
2878         * ada-lang.h (ada_lookup_symbol): Update.
2879         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2880         parameter.
2881         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2882
2883 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2884
2885         PR breakpoints/24541
2886         * gdbarch.c: Regenerate.
2887         * gdbarch.h: Regenerate.
2888         * gdbarch.sh: Add 'stap_adjust_register'.
2889         * i386-tdep.c: Include '<unordered_set>'.
2890         (i386_stap_adjust_register): New function.
2891         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2892         * stap-probe.c (stap_parse_register_operand): Call
2893         'gdbarch_stap_adjust_register'.
2894
2895 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2896
2897         PR python/24742
2898         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2899         * python/python.c (do_start_initialization): Use 'xmalloc'
2900         instead of 'PyMem_Malloc'.
2901
2902 2019-06-28  Tom Tromey  <tromey@adacore.com>
2903
2904         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2905         for Ada.
2906
2907 2019-06-27  Tom Tromey  <tromey@adacore.com>
2908
2909         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2910         objfile_key.
2911         (arm_find_mapping_symbol, arm_record_special_symbol)
2912         (_initialize_arm_tdep): Update.
2913         (arm_objfile_data_free): Remove.
2914
2915 2019-06-27  Tom Tromey  <tromey@adacore.com>
2916
2917         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2918         to cp_print_static_field.
2919
2920 2019-06-26  Tom Tromey  <tromey@adacore.com>
2921
2922         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2923         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2924         declare.
2925
2926 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2927
2928         * features/aarch64-core.c (create_feature_aarch64_core):
2929         Regenerate.
2930         * features/aarch64-core.xml: Add cpsr flags.
2931
2932 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2933
2934         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2935         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2936
2937 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2938
2939         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2940         field.
2941         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2942         use.
2943         (arm_record_special_symbol): Don't insert new symbol in sorted
2944         position, push it at the end.
2945
2946 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2947
2948         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2949         (arm_mapping_symbol_s): Remove.
2950         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2951         (arm_mapping_symbol_vec): New typedef.
2952         (struct arm_per_objfile): Add constructor.
2953         <section_maps>: Change type to
2954         std::unique_ptr<arm_mapping_symbol_vec[]>.
2955         (arm_compare_mapping_symbols): Remove.
2956         (arm_find_mapping_symbol): Adjust to section_maps type change.
2957         (arm_objfile_data_free): Call delete on arm_per_objfile.
2958         (arm_record_special_symbol): Adjust to section_maps type change.
2959         Allocate arm_per_objfile with new.
2960
2961 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2962
2963         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2964         with the command prefix.
2965
2966 2019-06-25  Tom Tromey  <tom@tromey.com>
2967
2968         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2969         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2970
2971 2019-06-25  Tom Tromey  <tom@tromey.com>
2972
2973         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2974         type.
2975         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2976         protected.
2977
2978 2019-06-25  Tom Tromey  <tom@tromey.com>
2979
2980         * tui/tui-winsource.c
2981         (tui_source_window_base::set_is_exec_point_at): Add check against
2982         LOA_ADDRESS.
2983
2984 2019-06-25  Tom Tromey  <tom@tromey.com>
2985
2986         * tui/tui-source.c (tui_set_source_content): Don't check before
2987         xfree.
2988         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2989
2990 2019-06-25  Tom Tromey  <tom@tromey.com>
2991
2992         * tui/tui-winsource.h (tui_update_source_window_as_is)
2993         (tui_alloc_source_buffer, tui_line_is_displayed)
2994         (tui_addr_is_displayed): Change type of win_info.
2995         * tui/tui-winsource.c (tui_update_source_window_as_is)
2996         (tui_clear_source_content, tui_show_source_line)
2997         (tui_show_source_content, tui_source_window_base::refill)
2998         (tui_source_window_base::set_is_exec_point_at)
2999         (tui_source_window_base::set_is_exec_point_at)
3000         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3001         (tui_alloc_source_buffer, tui_line_is_displayed)
3002         (tui_addr_is_displayed): Change type of win_info.  Update.
3003         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3004         (tui_source_window_base::do_make_visible_with_new_height):
3005         Update.
3006         * tui/tui-source.c (tui_set_source_content)
3007         (tui_set_source_content_nil)
3008         (tui_source_window::do_scroll_vertical): Update.
3009         * tui/tui-layout.c (show_layout): Update.
3010         * tui/tui-disasm.c (tui_set_disassem_content)
3011         (tui_disasm_window::do_scroll_vertical): Update.
3012         * tui/tui-data.h (tui_win_content): Remove.
3013         (struct tui_gen_win_info) <content, content_size>: Remove.
3014         (struct tui_source_element): Add initializers and destructor.
3015         (union tui_which_element, struct tui_win_element): Remove.
3016         (struct tui_source_window_base) <content>: New field.
3017         (struct tui_data_window): Remove destructor.
3018         (tui_alloc_content, tui_free_win_content)
3019         (tui_free_all_source_wins_content): Don't declare.
3020         * tui/tui-data.c (tui_initialize_static_data): Update.
3021         (init_content_element, tui_alloc_content): Remove.
3022         (~tui_gen_win_info): Update.
3023         (~tui_data_window, tui_free_all_source_wins_content)
3024         (tui_free_win_content, free_content, free_content_elements):
3025         Remove.
3026
3027 2019-06-25  Tom Tromey  <tom@tromey.com>
3028
3029         * tui/tui-winsource.h (tui_clear_source_content)
3030         (tui_erase_source_content, tui_show_source_content): Change type
3031         of win_info.
3032         * tui/tui-winsource.c (tui_clear_source_content)
3033         (tui_erase_source_content, tui_show_source_content): Change type
3034         of win_info.
3035         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3036         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3037         win_info.
3038         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3039         win_info.
3040         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3041
3042 2019-06-25  Tom Tromey  <tom@tromey.com>
3043
3044         * tui/tui-winsource.c (tui_clear_source_content)
3045         (tui_source_window_base::set_is_exec_point_at): Update.
3046         * tui/tui-source.c (tui_set_source_content_nil): Update.
3047         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3048         a bool.
3049         * tui/tui-data.c (init_content_element): Update.
3050
3051 2019-06-25  Tom Tromey  <tom@tromey.com>
3052
3053         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3054         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3055         * tui/tui-layout.c (init_and_make_win): Update.
3056         * tui/tui.h (enum tui_win_type): Update.
3057         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3058         tui_win_is_auxillary.
3059         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3060         tui_win_is_auxillary.
3061
3062 2019-06-25  Tom Tromey  <tom@tromey.com>
3063
3064         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3065         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3066         (tui_delete_data_content_windows, tui_display_all_data)
3067         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3068         Update.
3069         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3070         * tui/tui-regs.c (tui_last_regs_line_no)
3071         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3072         (tui_show_registers): Update.
3073         (tui_show_register_group): Return void.  Update.
3074         (tui_display_registers_from, tui_display_reg_element_at_line)
3075         (tui_display_registers_from_line, tui_check_register_values):
3076         Update.
3077         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3078         member.
3079         (struct tui_data_window) <regs_content>: Now a std::vector.
3080         <regs_content_count>: Remove.
3081         (tui_add_content_elements, tui_free_data_content): Don't declare.
3082         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3083         (init_content_element): Remove DATA_WIN case.  Add assert.
3084         (tui_add_content_elements): Remove.
3085         (tui_data_window): Update.
3086         (tui_free_data_content): Remove.
3087         (free_content_elements): Remove DATA_WIN case.
3088
3089 2019-06-25  Tom Tromey  <tom@tromey.com>
3090
3091         * tui/tui-data.c (tui_data_item_window): Update.
3092         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3093         * tui/tui-windata.c (tui_display_all_data)
3094         (tui_display_data_from_line): Update.
3095         (tui_check_data_values): Remove.
3096         * tui/tui-regs.c (tui_show_register_group)
3097         (tui_display_reg_element_at_line): Update.
3098         * tui/tui-hooks.c (tui_register_changed)
3099         (tui_refresh_frame_and_register_information): Call
3100         tui_check_register_values.
3101         * tui/tui-data.h (struct tui_data_window) <data_content,
3102         data_content_count, data_type>: Remove.
3103         (enum tui_data_type): Remove.
3104
3105         * tui/tui-data.c (tui_data_window::clear_detail)
3106         (~tui_data_window): Update.
3107
3108 2019-06-25  Tom Tromey  <tom@tromey.com>
3109
3110         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3111         declare.
3112         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3113         Rename from tui_first_data_item_displayed.  Update.
3114         (tui_data_window::refresh_all)
3115         (tui_data_window::do_scroll_vertical): Update.
3116         * tui/tui-data.h (struct tui_data_window)
3117         <first_data_item_displayed>: Declare new method.
3118
3119 2019-06-25  Tom Tromey  <tom@tromey.com>
3120
3121         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3122         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3123         contents...
3124         (tui_initialize_static_data): ...here.
3125
3126 2019-06-25  Tom Tromey  <tom@tromey.com>
3127
3128         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3129         (tui_display_registers_from, tui_check_register_values): Update.
3130         (tui_display_register): Remove win_info parameter; update.
3131         (tui_get_register): Change type of parameters.
3132         * tui/tui-data.h (struct tui_data_element): Remove.
3133         (union tui_which_element) <data>: Remove.
3134         <data_window>: Change type.
3135         (struct tui_data_item_window): New.
3136         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3137         case.  Add assert.
3138         (~tui_data_item_window): New destructor.
3139         (free_content_elements): Remove DATA_ITEM_WIN case.
3140
3141 2019-06-25  Tom Tromey  <tom@tromey.com>
3142
3143         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3144         Remove.
3145
3146 2019-06-25  Tom Tromey  <tom@tromey.com>
3147
3148         * tui/tui-data.h (struct tui_command_element): Remove.
3149         (union tui_which_element) <command>: Remove.
3150         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3151         assert.
3152         (free_content_elements): Remove CMD_WIN case.
3153
3154 2019-06-25  Tom Tromey  <tom@tromey.com>
3155
3156         * tui/tui-layout.c (tui_set_layout): Update.
3157         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3158         * tui/tui-data.c (layout_def): Update.
3159
3160 2019-06-25  Tom Tromey  <tom@tromey.com>
3161
3162         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3163         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3164         (tui_source_window_base::set_new_height): Update.
3165         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3166         Update.
3167         (tui_set_locator_fullname, tui_set_locator_info)
3168         (tui_show_frame_info): Update.
3169         * tui/tui-source.c (tui_set_source_content)
3170         (tui_source_is_displayed): Update.
3171         * tui/tui-layout.c (show_source_disasm_command, show_data)
3172         (show_source_or_disasm_and_command): Update.
3173         * tui/tui-disasm.c (tui_set_disassem_content)
3174         (tui_get_begin_asm_address): Update.
3175         * tui/tui-data.h (struct tui_locator_element): Remove.
3176         (union tui_which_element) <locator>: Remove.
3177         (struct tui_locator_window): New.
3178         (tui_locator_win_info_ptr): Change return type.
3179         * tui/tui-data.c (_locator): Change type.
3180         (tui_locator_win_info_ptr): Change return type.
3181         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3182         (tui_alloc_content): Add assert.
3183
3184 2019-06-25  Tom Tromey  <tom@tromey.com>
3185
3186         * tui/tui-winsource.c
3187         (tui_exec_info_window::maybe_allocate_content): New method.
3188         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3189         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3190         (make_source_or_disasm_window): Add cast.
3191         * tui/tui-data.h (union tui_which_element) <simple_string>:
3192         Remove.
3193         (struct tui_source_info): New.
3194         (struct tui_source_window_base) <execution_info>: Change type.
3195         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3196         case, and add assert.
3197         (tui_alloc_content): Add assert.
3198
3199 2019-06-25  Tom Tromey  <tom@tromey.com>
3200
3201         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3202         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3203         * tui/tui-data.c (tui_alloc_win_info): Remove.
3204
3205 2019-06-25  Tom Tromey  <tom@tromey.com>
3206
3207         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3208         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3209         can_highlight.
3210
3211 2019-06-25  Tom Tromey  <tom@tromey.com>
3212
3213         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3214         make_visible_with_new_height method.
3215         (tui_win_info::make_visible_with_new_height): New method.
3216         (tui_source_window_base::do_make_visible_with_new_height)
3217         (tui_data_window::do_make_visible_with_new_height)
3218         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3219         (make_visible_with_new_height): Remove.
3220         (tui_resize_all, tui_adjust_win_heights): Use
3221         make_visible_with_new_height method.
3222         * tui/tui-data.h (struct tui_win_info)
3223         <do_make_visible_with_new_height, make_visible_with_new_height>:
3224         New methods.
3225         (struct tui_source_window_base, struct tui_data_window)
3226         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3227         methods.
3228
3229 2019-06-25  Tom Tromey  <tom@tromey.com>
3230
3231         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3232         method.
3233         (update_tab_width): Call update_tab_width method.
3234         * tui/tui-data.h (struct tui_win_info)
3235         (struct tui_source_window_base) <update_tab_width>: New methods.
3236
3237 2019-06-25  Tom Tromey  <tom@tromey.com>
3238
3239         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3240         parameter.
3241         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3242         parameter.
3243         (tui_gen_win_info::make_visible): Update.
3244         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3245         parameter.
3246         * tui/tui-data.h (enum tui_box): New enum.
3247         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3248
3249 2019-06-25  Tom Tromey  <tom@tromey.com>
3250
3251         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3252         init_and_make_win for EXEC_INFO_WIN.
3253         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3254         longer inline.
3255         (struct tui_win_info) <~tui_win_info>: Inline.
3256         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3257         Don't declare.
3258         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3259         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3260         Remove.
3261         (tui_initialize_static_data): Update.
3262         (~tui_gen_win_info): Handle more cleanup here.
3263         (~tui_source_window_base): Delete "execution_info".
3264         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3265
3266 2019-06-25  Tom Tromey  <tom@tromey.com>
3267
3268         * tui/tui-layout.c (make_command_window): Don't set
3269         can_highlight.
3270         (show_source_disasm_command): Call the reset method.
3271         (show_data): Don't set can_highlight.  Call the reset method.
3272         (tui_gen_win_info::reset): Rename from init_gen_win_info
3273         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3274         (show_source_or_disasm_and_command): Call the reset method.
3275         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3276         (struct tui_cmd_window): Set can_highlight.
3277
3278 2019-06-25  Tom Tromey  <tom@tromey.com>
3279
3280         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3281         from make_visible.
3282         (tui_make_visible, tui_make_invisible): Rewrite.
3283         (tui_win_info::make_visible): Remove.
3284         (tui_source_window_base::make_visible): Update.
3285         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3286         method.  Moved from...
3287         (struct tui_win_info) <make_visible>: ...here.
3288
3289 2019-06-25  Tom Tromey  <tom@tromey.com>
3290
3291         * tui/tui-winsource.c
3292         (tui_source_window_base::do_scroll_horizontal): Remove direction
3293         parameter.
3294         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3295         direction parameter.
3296         * tui/tui-win.c (tui_win_info::forward_scroll)
3297         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3298         (tui_win_info::right_scroll): Update.
3299         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3300         direction parameter.
3301         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3302         direction parameter.
3303         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3304         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3305         Remove direction parameter.
3306         (struct tui_source_window_base, struct tui_source_window)
3307         (struct tui_disasm_window, struct tui_data_window)
3308         (struct tui_cmd_window): Update.
3309
3310 2019-06-25  Tom Tromey  <tom@tromey.com>
3311
3312         * tui/tui-winsource.h (tui_set_exec_info_content)
3313         (tui_show_exec_info_content, tui_erase_exec_info_content)
3314         (tui_clear_exec_info_content, tui_update_exec_info): Change
3315         argument to tui_source_window_base.
3316         * tui/tui-winsource.c (tui_set_exec_info_content)
3317         (tui_show_exec_info_content, tui_erase_exec_info_content)
3318         (tui_clear_exec_info_content, tui_update_exec_info): Change
3319         argument to tui_source_window_base.
3320
3321 2019-06-25  Tom Tromey  <tom@tromey.com>
3322
3323         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3324         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3325
3326 2019-06-25  Tom Tromey  <tom@tromey.com>
3327
3328         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3329         check.
3330
3331 2019-06-25  Tom Tromey  <tom@tromey.com>
3332
3333         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3334         type to void.
3335         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3336         type to void.
3337         * tui/tui-source.c (tui_set_source_content): Update.
3338         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3339
3340 2019-06-25  Tom Tromey  <tom@tromey.com>
3341
3342         * tui/tui-win.c (window_name_completer, tui_set_focus)
3343         (tui_all_windows_info): Use name method.
3344         * tui/tui-data.h (struct tui_gen_win_info)
3345         (struct tui_source_window, struct tui_disasm_window)
3346         (struct tui_data_window, struct tui_cmd_window) <name>: New
3347         method.
3348         (tui_win_name): Don't declare.
3349         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3350         (tui_win_name): Remove.
3351
3352 2019-06-25  Tom Tromey  <tom@tromey.com>
3353
3354         * tui/tui-winsource.h (tui_update_source_window)
3355         (tui_update_source_window_as_is): Change parameter type.
3356         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3357         to be a tui_source_window_base.
3358         (tui_update_source_window_as_is): Likewise.
3359         * tui/tui-win.c (make_visible_with_new_height): Update.
3360
3361 2019-06-25  Tom Tromey  <tom@tromey.com>
3362
3363         * tui/tui-winsource.c (tui_erase_source_content)
3364         (tui_show_source_content, tui_show_exec_info_content)
3365         (tui_erase_exec_info_content): Use refresh_window method.
3366         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3367         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3368         from tui_refresh_win.
3369         (tui_data_window::refresh_window): New method.
3370         (tui_win_info::refresh, tui_source_window_base::refresh)
3371         (tui_refresh_all): Use refresh_window method.
3372         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3373         method.
3374         * tui/tui-regs.c (tui_display_register): Call refresh_window
3375         method.
3376         * tui/tui-layout.c (show_source_disasm_command)
3377         (show_source_or_disasm_and_command): Call refresh_window method.
3378         * tui/tui-data.h (struct tui_gen_win_info)
3379         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3380         New method.
3381
3382 2019-06-25  Tom Tromey  <tom@tromey.com>
3383
3384         * tui/tui.c (tui_rl_other_window, tui_enable)
3385         (tui_is_window_visible, tui_get_command_dimension): Update.
3386         * tui/tui-winsource.c (tui_update_source_window_as_is)
3387         (tui_clear_source_content, tui_erase_source_content)
3388         (tui_show_source_line, tui_source_window_base::refill)
3389         (tui_source_window_base::do_scroll_horizontal)
3390         (tui_source_window_base::set_is_exec_point_at)
3391         (tui_update_breakpoint_info, tui_set_exec_info_content)
3392         (tui_alloc_source_buffer, tui_line_is_displayed)
3393         (tui_addr_is_displayed): Update.
3394         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3395         (tui_check_and_display_highlight_if_needed)
3396         (tui_win_info::make_visible, tui_win_info::refresh)
3397         (tui_refresh_all): Update.
3398         * tui/tui-windata.c (tui_first_data_item_displayed)
3399         (tui_delete_data_content_windows, tui_erase_data_content)
3400         (tui_display_all_data, tui_data_window::refresh_all)
3401         (tui_check_data_values): Update.
3402         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3403         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3404         (tui_win_info::backward_scroll, tui_refresh_all_win)
3405         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3406         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3407         (tui_source_window_base::set_new_height)
3408         (tui_data_window::set_new_height)
3409         (make_invisible_and_set_new_height)
3410         (make_visible_with_new_height, new_height_ok)
3411         (parse_scrolling_args): Update.
3412         * tui/tui-stack.c (tui_show_frame_info): Update.
3413         * tui/tui-source.c (tui_set_source_content)
3414         (tui_set_source_content_nil, tui_source_is_displayed)
3415         (tui_source_window::do_scroll_vertical): Update.
3416         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3417         (tui_display_registers_from, tui_display_reg_element_at_line)
3418         (tui_check_register_values, tui_reg_command): Update.
3419         * tui/tui-layout.c (tui_default_win_height)
3420         (show_source_disasm_command, show_data, init_and_make_win)
3421         (show_source_or_disasm_and_command): Update.
3422         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3423         (tui_redisplay_readline, tui_mld_flush)
3424         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3425         (tui_getc): Update.
3426         * tui/tui-disasm.c (tui_set_disassem_content)
3427         (tui_disasm_window::do_scroll_vertical): Update.
3428         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3429         Now virtual.
3430         (struct tui_win_info): Derive from tui_gen_win_info.
3431         <~tui_win_info>: Mark as override.
3432         <generic>: Remove member.
3433         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3434         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3435         (~tui_data_window, ~tui_win_info)
3436         (tui_free_all_source_wins_content): Update.
3437         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3438
3439 2019-06-25  Tom Tromey  <tom@tromey.com>
3440
3441         * tui/tui-layout.c (init_and_make_win): Use new.
3442         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3443         destructor, initializers.
3444         (tui_alloc_generic_win_info): Don't declare.
3445         * tui/tui-data.c (_locator): Add argument to constructor.
3446         (source_win, disasm_win): New globals.
3447         (exec_info): Remove.
3448         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3449         Update.
3450         (tui_alloc_generic_win_info): Remove.
3451         (init_content_element): Use new.
3452         (tui_win_info::tui_win_info): Update.
3453         (free_content_elements) <case DATA_WIN>: Use delete.
3454
3455 2019-06-25  Tom Tromey  <tom@tromey.com>
3456
3457         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3458         * tui/tui-windata.c (tui_first_data_item_displayed)
3459         (tui_delete_data_content_windows): Update.
3460         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3461         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3462         (tui_display_registers_from, tui_check_register_values): Update.
3463         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3464         pointer.
3465         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3466         window.
3467         (tui_free_data_content): Update.
3468         (free_content_elements) <case DATA_WIN>: Free the window.
3469
3470 2019-06-25  Tom Tromey  <tom@tromey.com>
3471
3472         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3473         Update.
3474         * tui/tui-layout.c (make_command_window)
3475         (show_source_disasm_command, show_data, init_and_make_win)
3476         (show_source_or_disasm_and_command): Update.
3477         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3478         method.
3479         <can_highight, is_highlighted>: Now bool.
3480         (tui_set_win_highlight): Don't declare.
3481         * tui/tui-data.c (tui_set_win_highlight): Remove.
3482
3483 2019-06-25  Tom Tromey  <tom@tromey.com>
3484
3485         * tui/tui-wingeneral.c (make_visible): Remove check of window
3486         type.
3487
3488 2019-06-25  Tom Tromey  <tom@tromey.com>
3489
3490         * tui/tui-win.c (tui_win_info::max_height)
3491         (tui_cmd_window::max_height): New methods.
3492         (new_height_ok): Call max_height.
3493         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3494         <max_height>: New method.
3495
3496 2019-06-25  Tom Tromey  <tom@tromey.com>
3497
3498         * tui/tui-win.c (tui_source_window_base::set_new_height)
3499         (tui_data_window::set_new_height): New methods.
3500         (make_invisible_and_set_new_height): Call set_new_height method.
3501         * tui/tui-data.h (struct tui_win_info)
3502         (struct tui_source_window_base, struct tui_data_window)
3503         <set_new_height>: New method.
3504
3505 2019-06-25  Tom Tromey  <tom@tromey.com>
3506
3507         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3508         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3509         tui_refresh_data_win.
3510         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3511         method.
3512         (tui_refresh_all_win): Call the refresh_all method.
3513         (tui_set_focus): Likewise.
3514         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3515         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3516         Likewise.
3517
3518 2019-06-25  Tom Tromey  <tom@tromey.com>
3519
3520         * tui/tui-winsource.h (tui_refill_source_window)
3521         (tui_set_is_exec_point_at): Don't declare.
3522         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3523         (tui_source_window_base::refill): Rename from
3524         tui_refill_source_window.
3525         (tui_source_window_base::do_scroll_horizontal): Update.
3526         (tui_source_window_base::set_is_exec_point_at): Rename from
3527         tui_set_is_exec_point_at.
3528         (tui_update_all_breakpoint_info): Update.
3529         * tui/tui-stack.c (tui_show_frame_info): Update.
3530         * tui/tui-layout.c (show_data): Add cast.
3531         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3532         * tui/tui-data.h (struct tui_source_window_base) <refill,
3533         set_is_exec_point_at>: New methods.
3534         (tui_source_windows, tui_add_to_source_windows): Update types.
3535         (tui_add_to_source_windows): Remove redundant declaration.
3536         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3537         (tui_source_windows): Change return type.
3538         (tui_clear_source_windows_detail): Update.
3539         (tui_add_to_source_windows): Change type of parameter.
3540         (tui_free_all_source_wins_content): Update.
3541
3542 2019-06-25  Tom Tromey  <tom@tromey.com>
3543
3544         * tui/tui-wingeneral.c (tui_win_info::refresh)
3545         (tui_source_window_base::refresh): New methods.
3546         (tui_refresh_all): Call the refresh method.
3547         * tui/tui-data.h (struct tui_win_info)
3548         (struct tui_source_window_base) <refresh>: New method.
3549
3550 2019-06-25  Tom Tromey  <tom@tromey.com>
3551
3552         * tui/tui.h (tui_is_window_visible): Return bool.
3553         * tui/tui.c (tui_is_window_visible): Return bool.
3554         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3555         (tui_make_visible, tui_make_invisible)
3556         (tui_win_info::make_visible)
3557         (tui_source_window_base::make_visible, make_all_visible)
3558         (tui_make_all_visible, tui_make_all_invisible): Update.
3559         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3560         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3561         bool.
3562         (struct tui_win_info, struct tui_source_window_base)
3563         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3564         * tui/tui-data.c (tui_init_generic_part): Update.
3565
3566 2019-06-25  Tom Tromey  <tom@tromey.com>
3567
3568         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3569         (tui_source_window_base::make_visible): New methods.
3570         (make_all_visible): Make method call.
3571         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3572         (struct tui_source_window_base, struct tui_cmd_window): Override
3573         make_visible.
3574         (tui_win_is_source_type): Don't declare.
3575         * tui/tui-data.c (tui_win_is_source_type): Remove.
3576
3577 2019-06-25  Tom Tromey  <tom@tromey.com>
3578
3579         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3580         NULL check.
3581
3582 2019-06-25  Tom Tromey  <tom@tromey.com>
3583
3584         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3585         Inline constructor.  Add initializers for members.
3586         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3587         constructors; now inline in class.
3588
3589 2019-06-25  Tom Tromey  <tom@tromey.com>
3590
3591         * tui/tui-regs.c (tui_show_registers): Update.
3592         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3593         bool.
3594         * tui/tui-data.c (tui_data_window::clear_detail)
3595         (tui_data_window): Update.
3596
3597 2019-06-25  Tom Tromey  <tom@tromey.com>
3598
3599         * tui/tui-windata.c (tui_display_all_data)
3600         (tui_display_data_from_line, tui_display_data_from)
3601         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3602         Update.
3603         * tui/tui-regs.c (tui_last_regs_line_no)
3604         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3605         (tui_show_registers, tui_show_register_group)
3606         (tui_display_registers_from, tui_display_reg_element_at_line)
3607         (tui_display_registers_from_line, tui_check_register_values)
3608         (tui_reg_next, tui_reg_prev): Update.
3609         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3610         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3611         tui_data_window.
3612         (struct tui_win_info) <detail>: Remove.  Add new fields from
3613         tui_data_info.
3614         (TUI_DATA_WIN): Add cast.
3615         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3616         (~tui_data_window): Simplify.
3617
3618 2019-06-25  Tom Tromey  <tom@tromey.com>
3619
3620         * tui/tui-layout.c (show_source_disasm_command)
3621         (show_source_or_disasm_and_command): Update.
3622         * tui/tui-io.c (update_cmdwin_start_line)
3623         (tui_redisplay_readline): Update.
3624         * tui/tui-data.h (struct tui_command_info): Remove.
3625         (struct tui_win_info) <detail>: Remove command_info member.
3626         (struct tui_data_window) <start_line>: New member, from
3627         tui_command_info.
3628         (TUI_CMD_WIN): Add casts.
3629
3630 2019-06-25  Tom Tromey  <tom@tromey.com>
3631
3632         * tui/tui-winsource.c (tui_update_source_window)
3633         (tui_refill_source_window)
3634         (tui_source_window_base::do_scroll_horizontal)
3635         (tui_update_breakpoint_info, tui_set_exec_info_content)
3636         (tui_show_exec_info_content, tui_erase_exec_info_content)
3637         (tui_clear_exec_info_content): Update.
3638         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3639         Update.
3640         * tui/tui-win.c (make_invisible_and_set_new_height)
3641         (make_visible_with_new_height): Update.
3642         * tui/tui-source.c (tui_set_source_content)
3643         (tui_show_symtab_source): Update.
3644         * tui/tui-layout.c (extract_display_start_addr)
3645         (show_source_disasm_command, show_data)
3646         (make_source_or_disasm_window)
3647         (show_source_or_disasm_and_command): Update.
3648         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3649         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3650         "gdbarch".
3651         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3652         to tui_source_window_base.
3653         (struct tui_win_info) <detail>: Remove source_info member.
3654         (struct tui_source_window_base) <has_locator>: Inline.
3655         Move contents from tui_source_info; rename has_locator member to
3656         m_has_locator.
3657         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3658         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3659         header file.
3660         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3661         Simplify.
3662         (tui_free_all_source_wins_content): Cast to
3663         tui_source_window_base.
3664
3665 2019-06-25  Tom Tromey  <tom@tromey.com>
3666
3667         * tui/tui-win.c (make_invisible_and_set_new_height)
3668         (make_visible_with_new_height): Call has_locator method.
3669         * tui/tui-layout.c (show_source_disasm_command, show_data)
3670         (show_source_or_disasm_and_command): Update for bool change.
3671         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3672         (tui_win_info) <has_locator>: New method.
3673         (struct tui_source_window_base) <has_locator>: New method.
3674         (tui_win_has_locator): Don't declare.
3675         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3676         from tui_win_has_locator.
3677         (tui_source_window_base): Use false, not FALSE.
3678
3679 2019-06-25  Tom Tromey  <tom@tromey.com>
3680
3681         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3682         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3683         clear_detail method directly.
3684         (tui_clear_win_detail): Remove.
3685
3686 2019-06-25  Tom Tromey  <tom@tromey.com>
3687
3688         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3689         "this", not TUI_DISASM_WIN.
3690
3691 2019-06-25  Tom Tromey  <tom@tromey.com>
3692
3693         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3694         declare.
3695         * tui/tui-winsource.c
3696         (tui_source_window_base::do_scroll_horizontal): Rename from
3697         tui_horizontal_source_scroll.
3698         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3699         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3700         from tui_vertical_data_scroll.
3701         * tui/tui-win.h (tui_scroll): Don't declare.
3702         * tui/tui-win.c (tui_win_info::forward_scroll)
3703         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3704         (tui_win_info::right_scroll): Rename and update.
3705         (tui_scroll_forward_command, tui_scroll_backward_command)
3706         (tui_scroll_left_command, tui_scroll_right_command): Update.
3707         (tui_scroll): Remove.
3708         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3709         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3710         from tui_vertical_source_scroll.
3711         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3712         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3713         from tui_vertical_disassem_scroll.
3714         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3715         do_scroll_horizontal>: New methods.
3716         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3717         Likewise.
3718         (struct tui_source_window_base): Add do_scroll_horizontal.
3719         (struct tui_source_window, struct tui_disasm_window): Add
3720         do_scroll_vertical.
3721         (struct tui_data_window, struct tui_cmd_window): Add
3722         do_scroll_horizontal and do_scroll_vertical.
3723         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3724
3725 2019-06-25  Tom Tromey  <tom@tromey.com>
3726
3727         * tui/tui-data.h (struct tui_source_window_base): New struct.
3728         (struct tui_source_window): Derive from tui_source_window_base.
3729         (struct tui_disasm_window): New struct.
3730         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3731         from tui_source_window::clear_detail.
3732         (tui_source_window_base): Rename from tui_source_window.
3733         (~tui_source_window_base): Rename from ~tui_source_window.
3734         (tui_alloc_win_info): Create a tui_disasm_window.
3735
3736 2019-06-25  Tom Tromey  <tom@tromey.com>
3737
3738         * tui/tui-data.h (struct tui_source_window)
3739         (struct tui_data_window): Declare destructors.
3740         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3741         destructors.
3742         (tui_win_info): Simplify.
3743
3744 2019-06-25  Tom Tromey  <tom@tromey.com>
3745
3746         * tui/tui-winsource.c (tui_display_main)
3747         (tui_update_source_windows_with_addr)
3748         (tui_update_all_breakpoint_info): Update.
3749         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3750         (new_height_ok, parse_scrolling_args): Update.
3751         * tui/tui-stack.c (tui_show_frame_info): Update.
3752         * tui/tui-data.h (struct tui_list): Remove.
3753         (tui_source_windows): Return a reference to a std::vector.
3754         * tui/tui-data.c (source_windows): Now a std::vector.
3755         (tui_source_windows): Change return type.
3756         (tui_clear_source_windows): Rewrite.
3757         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3758         (tui_free_all_source_wins_content): Rewrite.
3759
3760 2019-06-25  Tom Tromey  <tom@tromey.com>
3761
3762         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3763         (struct tui_data_window, struct tui_cmd_window): Declare
3764         clear_detail method.
3765         * tui/tui-data.c (tui_source_window::clear_detail)
3766         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3767         methods.
3768         (tui_clear_win_detail): Simplify.
3769
3770 2019-06-25  Tom Tromey  <tom@tromey.com>
3771
3772         * tui/tui-layout.c (make_source_window, make_disasm_window)
3773         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3774         Return the new window.
3775         (show_source_disasm_command, show_data)
3776         (show_source_or_disasm_and_command): Update.
3777
3778 2019-06-25  Tom Tromey  <tom@tromey.com>
3779
3780         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3781         parameter.  Return the new window.
3782         (show_source_disasm_command): Update and remove NULL check.
3783         (show_source_or_disasm_and_command): Update.
3784
3785 2019-06-25  Tom Tromey  <tom@tromey.com>
3786
3787         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3788
3789 2019-06-25  Tom Tromey  <tom@tromey.com>
3790
3791         * tui/tui-data.h (struct tui_win_info): Make constructor
3792         protected.  Make destructor virtual.  Add initializers.
3793         (tui_source_window, tui_data_window, tui_cmd_window): New
3794         classes.
3795         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3796         constructor.  Add "type" parameter.
3797         (tui_source_window, tui_data_window, tui_cmd_window): New
3798         constructors.
3799         (tui_alloc_win_info): Instantiate the appropriate subclass.
3800
3801 2019-06-25  Tom Tromey  <tom@tromey.com>
3802
3803         * tui/tui-win.c (tui_resize_all): Use delete.
3804         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3805         destructor.
3806         (tui_free_window): Don't declare.
3807         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3808         Update.
3809
3810 2019-06-25  Tom Tromey  <tom@tromey.com>
3811
3812         * tui/tui-data.h (struct tui_win_info): Add constructor.
3813         * tui/tui-data.c (tui_alloc_win_info): Use new.
3814         (tui_free_window): Use delete.
3815
3816 2019-06-22  Tom Tromey  <tom@tromey.com>
3817
3818         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3819         declare.
3820         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3821
3822 2019-06-22  Tom Tromey  <tom@tromey.com>
3823
3824         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3825         declare.
3826         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3827
3828 2019-06-22  Tom de Vries  <tdevries@suse.de>
3829
3830         * dwarf2read.c (create_addrmap_from_aranges)
3831         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3832         instead of '%zu'.
3833
3834 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3835
3836         * dwarf2read.h (dwarf2_section_info_def): Remove.
3837         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3838         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3839         std::vector<dwarf2_section_info>.
3840         (struct dwo_file) <~dwo_file>: Remove.
3841         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3842         types field.
3843         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3844         (dwarf2_read_debug_names): Likewise.
3845         (create_debug_types_hash_table): Change parameter type to
3846         array_view, adjust code accordingly.
3847         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3848         (partial_die_info::fixup): Likewise.
3849         (determine_prefix): Likewise.
3850         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3851
3852 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3853
3854         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3855         gdb_bfd_ref_ptr.
3856         <~dwo_file>: Remove call to gdb_bfd_unref.
3857         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3858         gdb_bfd_ref_ptr::get.
3859
3860 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3861
3862         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3863         type to htab_up.
3864         * dwarf2read.c (struct dwo_file): Initialize fields.
3865         <~dwo_file>: New.
3866         (free_dwo_file): Remove, move content to ~dwo_file.
3867         (struct dwo_file_deleter): Remove.
3868         (dwo_file_up>: Remove custom deleter.
3869         (free_dwo_files): Remove.
3870         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3871         dwo_files.
3872         (process_skeletonless_type_units): Call unique_ptr::get.
3873         (allocate_dwo_file_hash_table): Add deleter to created hash
3874         table.  Change return type to htab_up.
3875         (lookup_dwo_file_slot): Don't memset dwo_file, call
3876         unique_ptr::get.
3877         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3878         (create_dwo_unit_in_dwp_v2): Likewise.
3879         (open_and_init_dwo_file): Likewise.
3880         (free_dwo_file_from_slot): Remove.
3881
3882 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3883
3884         * dwarf2read.h (struct dwarf2_section_info) <readin,
3885         is_virtual>: Change type to bool.
3886         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3887         true instead of 1.
3888
3889 2019-06-19  Tom Tromey  <tom@tromey.com>
3890
3891         * tui/tui-data.h (tui_init_content_element): Don't declare.
3892
3893 2019-06-19  Tom Tromey  <tom@tromey.com>
3894
3895         * tui/tui-data.h (tui_init_win_info): Don't declare.
3896
3897 2019-06-19  Tom de Vries  <tdevries@suse.de>
3898
3899         * dwarf2read.h (abstract_to_concrete): Change type to
3900         std::unordered_map<sect_offset, std::vector<sect_offset>,
3901         gdb::hash_enum<sect_offset>>.
3902
3903 2019-06-19  Tom Tromey  <tromey@adacore.com>
3904
3905         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3906         EVAL_AVOID_SIDE_EFFECTS specially.
3907
3908 2019-06-19  Tom Tromey  <tromey@adacore.com>
3909
3910         * source-cache.c (highlighter): New global.
3911         (source_cache::get_source_lines): Create a highlighter on demand.
3912
3913 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3914
3915         * defs.h (deprecated_interactive_hook): Delete declaration.
3916         * interps.c (clear_interpreter_hooks): Remove use of
3917         deprecated_interactive_hook.
3918         * top.c (deprecated_interactive_hook): Delete definition.
3919         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3920
3921 2019-06-18  Tom de Vries  <tdevries@suse.de>
3922
3923         PR gdb/24515
3924         * dwarf2read.h (abstract_to_concrete): Change type from
3925         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3926         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3927         * dwarf2read.c (read_variable): Update.
3928         (dwarf2_fetch_die_loc_sect_off): Update.
3929
3930 2019-06-17  Tom de Vries  <tdevries@suse.de>
3931
3932         PR gdb/24617
3933         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3934         accessing parent[parent_len - 1].
3935
3936 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3937
3938         PR gdb/24364
3939         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3940         call dtrace_process_dof with NULL dof.
3941
3942 2019-06-16  Tom de Vries  <tdevries@suse.de>
3943
3944         PR gdb/24445
3945         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3946
3947 2019-06-16  Tom Tromey  <tom@tromey.com>
3948
3949         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3950         (make_all_visible): Use address of member.
3951
3952 2019-06-16  Tom Tromey  <tom@tromey.com>
3953
3954         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3955         (tui_free_window, free_content, free_content_elements): Remove
3956         unnecessary cast.
3957         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3958         cast.
3959         * tui/tui-regs.c (tui_show_register_group)
3960         (tui_display_registers_from, tui_display_reg_element_at_line):
3961         Remove unnecessary cast.
3962
3963 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3964
3965         * linux-nat.c (normal_mask): Delete.
3966         (_initialize_linux_nat): Don't initialise normal_mask.
3967
3968 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3969
3970         PR gdb/24445
3971         * dwarf-index-write.h (write_psymtabs_to_index): Add
3972         dwz_basename parameter.
3973         * dwarf-index-write.c (write_gdbindex): Move file writing to
3974         write_gdbindex_1.  Change return type void.
3975         (assert_file_size): Move up, remove filename parameter.
3976         (write_gdbindex_1): New function.
3977         (write_debug_names): Change return type to void, call
3978         assert_file_size.
3979         (struct index_wip_file): New struct.
3980         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3981         file logic to index_wip_file.  Write index for dwz file if
3982         needed.
3983         (save_gdb_index_command): Pass basename of dwz file, if present.
3984         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3985         build-id of dwz file, if present.
3986         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3987         (dwarf2_get_dwz_file): Likewise.
3988         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3989         (dwarf2_get_dwz_file): Likewise.
3990
3991 2019-06-16  Tom Tromey  <tom@tromey.com>
3992
3993         * coffread.c (process_coff_symbol): Use xstrdup.
3994         * value.c (create_internalvar): Use xstrdup.
3995
3996 2019-06-16  Tom Tromey  <tom@tromey.com>
3997
3998         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3999         * breakpoint.c (stopin_command, stopat_command)
4000         (until_break_command, decode_location_default): Remove unnecessary
4001         cast.
4002         * utils.c (subset_compare): Remove unnecessary cast.
4003         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4004         cast.
4005         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4006         cast.
4007         * infcmd.c (path_command): Remove unnecessary cast.
4008         * coffread.c (decode_type): Remove unnecessary cast.
4009         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4010         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4011         * tui/tui-stack.c (tui_show_locator_content)
4012         (tui_show_frame_info): Remove unnecessary cast.
4013         * tui/tui-win.c (tui_scroll_forward_command)
4014         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4015         (parse_scrolling_args): Remove unnecessary cast.
4016         * tui/tui-data.c (init_win_info, tui_del_window)
4017         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4018         (free_content_elements): Remove unnecessary cast.
4019         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4020         unnecessary cast.
4021         * tui/tui-source.c (tui_set_source_content)
4022         (tui_vertical_source_scroll): Remove unnecessary cast.
4023         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4024         cast.
4025         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4026         * tui/tui-regs.c (tui_display_registers_from)
4027         (tui_display_register): Remove unnecessary cast.
4028         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4029         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4030         (make_visible): Remove unnecessary cast.
4031         * tui/tui-winsource.c (tui_erase_source_content)
4032         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4033         unnecessary cast.
4034         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4035         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4036         * stabsread.c (read_type, read_array_type, read_range_type):
4037         Remove unnecessary cast.
4038         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4039         (parse_symbol, parse_type, upgrade_type, parse_external)
4040         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4041         unnecessary cast.
4042         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4043
4044 2019-06-16  Tom Tromey  <tom@tromey.com>
4045
4046         * tui/tui-data.c (tui_alloc_generic_win_info)
4047         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4048         checks.
4049
4050 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4051             Andrew Burgess  <andrew.burgess@embecosm.com>
4052
4053         * f-typeprint.c (f_print_type): Don't return early for not
4054         associated or not allocated types.
4055         (f_type_print_varspec_suffix): Add print_rank parameter and print
4056         ranks of array types in case they dangling.
4057         (f_type_print_base): Add print_rank parameter.
4058
4059 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4060
4061         * NEWS: Mention new MI commands.
4062         * break-catch-throw.c (enum exception_event_kind): Move to
4063         breakpoint.h.
4064         (print_mention_exception_catchpoint): Output text as a single
4065         message.
4066         (catch_exception_command_1): Rename to...
4067         (catch_exception_event): ...this, make non-static, update header
4068         command, and change some parameter types.
4069         (catch_catch_command): Update for changes to
4070         catch_exception_command_1.
4071         (catch_throw_command): Likewise.
4072         (catch_rethrow_command): Likewise.
4073         * breakpoint.c (enum exception_event_kind): Delete.
4074         * breakpoint.h (enum exception_event_kind): Moved here from
4075         break-catch-throw.c.
4076         (catch_exception_event): Declare.
4077         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4078         (mi_cmd_catch_throw): New function.
4079         (mi_cmd_catch_rethrow): New function.
4080         (mi_cmd_catch_catch): New function.
4081         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4082         'catch-catch' entries.
4083         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4084         (mi_cmd_catch_rethrow): Declare.
4085         (mi_cmd_catch_catch): Declare.
4086
4087 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4088
4089         * annotate.c (annotate_source_line): Change return type to void,
4090         update implementation to match.
4091         * annotate.h (annotate_source_line): Change return type to void,
4092         update header comment.
4093         * stack.c (print_frame_info): Don't change what frame information
4094         is printed based on whether annotations are on or not.
4095
4096 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4097
4098         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4099         (annotate_source): Make static.
4100         (annotate_source_line): Moved from source.c and renamed from
4101         identify_source_line.  Update the return type.
4102         * annotate.h (annotate_source): Delete declaration.
4103         (annotate_source_line): Declaration moved from source.h, and
4104         renamed from identify_source_line.  Return type updated.
4105         * source.c (identify_source_line): Moved to annotate.c and renamed
4106         to annotate_source_line.
4107         (info_line_command): Remove check of annotation_level.
4108         * source.h (identify_source_line): Move declaration to annotate.h
4109         and rename to annotate_source_line.
4110         * stack.c: Add 'annotate.h' include.
4111         (print_frame_info): Remove check of annotation_level before
4112         calling annotate_source_line.
4113
4114 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4115
4116         * source-cache.c (source_cache::get_plain_source_lines): Use
4117         open_source_file_with_line_charpos instead of just
4118         open_source_file, remove call to find_source_lines.
4119         (source_cache::get_source_lines): Likewise.
4120         * source.c (find_source_lines): Make static.
4121         (get_filename_and_charpos): Renamed into...
4122         (open_source_file_with_line_charpos): ..this along with changes to
4123         return a scoped_fd, and some other minor clean ups.
4124         (identify_source_line): Use open_source_file_with_line_charpos.
4125         (search_command_helper): Use open_source_file_with_line_charpos
4126         instead of just open_source_file, remove call to
4127         find_source_lines.
4128         * source.h (open_source_file_with_line_charpos): Declare new
4129         function.
4130         (find_source_lines): Delete declaration.
4131
4132 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4133
4134         * source.c (get_filename_and_charpos): Remove fullname
4135         parameter.
4136         (identify_source_line): Update call to get_filename_and_charpos.
4137
4138 2019-06-14  Tom Tromey  <tromey@adacore.com>
4139
4140         PR gdb/24502:
4141         * ui-style.h (skip_ansi_escape): Update comment.
4142         * ui-file.h (class no_terminal_escape_file): New class.
4143         * ui-file.c (no_terminal_escape_file::write)
4144         (no_terminal_escape_file::puts): New methods.
4145         * cli/cli-logging.c (handle_redirections): Use
4146         no_terminal_escape_file.
4147
4148 2019-06-14  Tom Tromey  <tromey@adacore.com>
4149
4150         * NEWS: Move convenience variable news above Python news.
4151
4152 2019-06-14  Tom Tromey  <tom@tromey.com>
4153
4154         * gnulib: Move directory to top-level.
4155         * configure.ac: Don't configure gnulib.
4156         * configure: Rebuild.
4157         * common/common-defs.h: Use new path to gnulib.
4158         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4159         (GNULIB_H): Remove.
4160         (INCGNU): Look in new gnulib location.
4161         (HFILES_NO_SRCDIR): Remove gnulib files.
4162         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4163         (generated_files): Remove GNULIB_H.
4164         ($(LIBGNU), all-lib): Remove targets.
4165         (distclean): Don't mention GNULIB_BUILDDIR.
4166         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4167
4168 2019-06-14  Tom Tromey  <tromey@adacore.com>
4169
4170         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4171         Warn if symbol file does not provide any symbols.
4172
4173 2019-06-14  Tom Tromey  <tromey@adacore.com>
4174
4175         * source.c (find_and_open_source): Respect basenames_may_differ.
4176
4177 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4178
4179         * annotate.c (annotate_breakpoints_invalid): Make use of
4180         scoped_restore_terminal_state.
4181         (annotate_frames_invalid): Likewise.
4182
4183 2019-06-14  Tom Tromey  <tromey@adacore.com>
4184
4185         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4186         allow assignment to an internalvar.
4187
4188 2019-06-14  Tom Tromey  <tromey@adacore.com>
4189
4190         * ada-lex.l: Allow "_" in attribute names.
4191
4192 2019-06-14  Tom Tromey  <tromey@adacore.com>
4193
4194         PR gdb/24653:
4195         * regcache.c (registers_changed): Don't call alloca.
4196         * top.c (execute_command): Don't call alloca.
4197
4198 2019-06-13  Pedro Alves  <palves@redhat.com>
4199
4200         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4201         'expression'.  When parsing an expression, error out if there's
4202         junk after "unlimited".
4203         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4204         (do_set_command): Adjust calls to is_unlimited_literal.
4205
4206 2019-06-13  Pedro Alves  <palves@redhat.com>
4207
4208         * compile/compile.c (make_compile_options_def_group): Add braces
4209         around array_view initializer.
4210         * thread.c (make_thread_apply_all_options_def_group)
4211         (make_thread_apply_all_options_def_group): Likewise.
4212
4213 2019-06-13  Pedro Alves  <palves@redhat.com>
4214
4215         * NEWS (New commands): Mention "maint test-options
4216         require-delimiter", "maint test-options unknown-is-error", "maint
4217         test-options unknown-is-operand" and "maint show
4218         test-options-completion-result".
4219         (New command options, command completion): New section.
4220         (Completion improvements): New section.
4221         Mention that you can abbreviate "unlimited".
4222
4223 2019-06-13  Pedro Alves  <palves@redhat.com>
4224
4225         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4226         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4227         * unittests/cli-utils-selftests.c (test_parse_flags)
4228         (test_parse_flags_qcs): Delete.
4229         (test_cli_utils): Don't call deleted functions.
4230
4231 2019-06-13  Pedro Alves  <palves@redhat.com>
4232
4233         * thread.c: Include "cli/cli-option.h".
4234         (tp_array_compar_ascending): Global.
4235         (tp_array_compar): Delete function.
4236         (tp_array_compar_ascending, tp_array_compar_descending): New
4237         functions.
4238         (ascending_option_def, qcs_flag_option_def)
4239         (thr_qcs_flags_option_defs)
4240         (make_thread_apply_all_options_def_group)
4241         (make_thread_apply_options_def_group): New.
4242         (thread_apply_all_command): Use gdb::option::process_options.
4243         (thread_apply_command_completer)
4244         (thread_apply_all_command_completer): New.
4245         (thread_apply_command): Use gdb::option::process_options.
4246         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4247         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4248         to generate help text of "thread apply".  Adjust "taas"'s help.
4249         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4250         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4251
4252 2019-06-13  Pedro Alves  <palves@redhat.com>
4253
4254         * thread.c (thread_apply_command): Check for invalid TID with
4255         isdigit instead of !isalpha.
4256
4257 2019-06-13  Pedro Alves  <palves@redhat.com>
4258
4259         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4260         (validate_flags_qcs): New.
4261         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4262         (validate_flags_qcs): Declare.
4263         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4264         (make_frame_apply_options_def_group): New.
4265         (frame_apply_command_count): Process options with
4266         gdb::option::process_options.
4267         (frame_apply_completer): New.
4268         (frame_apply_level_completer, frame_apply_all_completer)
4269         (frame_apply_completer): New.
4270         (_initialize_stack): Update help of "frame apply", "frame apply
4271         level", "frame apply all" and "faas" to mention supported options
4272         and install command completers.
4273         * stack.h (frame_apply_all_completer): Declare.
4274         * thread.c: Include "stack.h".
4275         (tfaas_command): Add "--".
4276         (_initialize_thread): Update help "tfaas" to mention supported
4277         options and install command completer.
4278
4279 2019-06-13  Pedro Alves  <palves@redhat.com>
4280
4281         * completer.c (complete_nested_command_line): New.
4282         (gdb_completion_word_break_characters_throw): Add assertion.
4283         * completer.h (complete_nested_command_line): Declare.
4284
4285 2019-06-13  Pedro Alves  <palves@redhat.com>
4286
4287         * stack.c (parse_backtrace_qualifiers): New.
4288         (backtrace_command): Use it.
4289         (backtrace_command_completer): Complete on qualifiers.
4290
4291 2019-06-13  Pedro Alves  <palves@redhat.com>
4292
4293         * frame.c: Include "cli/cli-option.h.
4294         (user_set_backtrace_options): New.
4295         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4296         Delete.
4297         (get_prev_frame): Adjust.
4298         (boolean_option_def, uinteger_option_def)
4299         (set_backtrace_option_defs): New.
4300         (_initialize_frame): Adjust and use
4301         gdb::option::add_setshow_cmds_for_options to install "set
4302         backtrace past-main" and "set backtrace past-entry".
4303         * frame.h: Include "cli/cli-option.h".
4304         (struct frame_print_options): Forward declare.
4305         (print_frame_arguments_all, print_frame_arguments_scalars)
4306         (print_frame_arguments_none): Declare.
4307         (print_entry_values): Delete declaration.
4308         (struct frame_print_options, user_frame_print_options): New.
4309         (struct set_backtrace_options): New.
4310         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4311         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4312         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4313         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4314         (list_args_or_locals): Add frame_print_options parameter.
4315         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4316         * python/py-framefilter.c (enumerate_args): Pass down
4317         USER_FRAME_PRINT_OPTIONS.
4318         * stack.c: Include "cli/cli-option.h".
4319         (print_frame_arguments_all, print_frame_arguments_scalars)
4320         (print_frame_arguments_none): Declare.
4321         (print_raw_frame_arguments, print_entry_values): Delete.
4322         (user_frame_print_options): New.
4323         (boolean_option_def, enum_option_def, frame_print_option_defs):
4324         New.
4325         (struct backtrace_cmd_options): New.
4326         (bt_flag_option_def): New.
4327         (backtrace_command_option_defs): New.
4328         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4329         (print_frame_arg, read_frame_arg, print_frame_args)
4330         (print_frame_info, print_frame): Add frame_print_options parameter
4331         and use it.
4332         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4333         (backtrace_command_1): Add frame_print_options and
4334         backtrace_cmd_options parameters and use them.
4335         (make_backtrace_options_def_group): New.
4336         (backtrace_command): Process command options with
4337         gdb::option::process_options.
4338         (backtrace_command_completer): New.
4339         (_initialize_stack): Extend "backtrace"'s help to mention
4340         supported options.  Install completer for "backtrace".
4341         Install some settings commands with add_setshow_cmds_for_options.
4342
4343 2019-06-13  Pedro Alves  <palves@redhat.com>
4344
4345         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4346         and that "set/show print raw frame-arguments" are now deprecated.
4347
4348         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4349         command.
4350         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4351         * stack.c (_initialize_stack): Install "set/show print
4352         raw-frame-arguments", and deprecate "set/show print raw
4353         frame-arguments".
4354         * valprint.c (_initialize_valprint): Deprecate "set/show print
4355         raw".
4356
4357 2019-06-13  Pedro Alves  <palves@redhat.com>
4358
4359         * compile/compile.c (struct compile_options): New.
4360         (compile_flag_option_def, compile_command_option_defs)
4361         (make_compile_options_def_group): New.
4362         (compile_file_command): Handle options with
4363         gdb::option::process_options.
4364         (compile_file_command_completer): New function.
4365         (compile_code_command): Handle options with
4366         gdb::option::process_options.
4367         (compile_code_command_completer): New function.
4368         (_initialize_compiler): Install completers for "compile code" and
4369         "compile file".  Mention available options in "compile code" and
4370         "compile code"'s help.
4371         * completer.c (advance_to_completion_word): New, factored out from
4372         ...
4373         (advance_to_expression_complete_word_point): ... this.
4374         (advance_to_filename_complete_word_point): New.
4375         * completer.h (advance_to_filename_complete_word_point): New
4376         declaration.
4377
4378 2019-06-13  Pedro Alves  <palves@redhat.com>
4379
4380         * compile/compile.c: Include "cli/cli-option.h".
4381         (compile_print_value): Scope data pointer is now a
4382         value_print_options pointer; adjust.
4383         (compile_print_command): Process options.  Scope data pointer is
4384         now a value_print_options pointer; adjust.
4385         (_initialize_compile): Update "compile print"'s help to include
4386         supported options.  Install a completer for "compile print".
4387         * cp-valprint.c (show_vtblprint, show_objectprint)
4388         (show_static_field_print): Delete.
4389         (_initialize_cp_valprint): Don't install "set print
4390         static-members", "set print vtbl", "set print object" here.
4391         * printcmd.c: Include "cli/cli-option.h" and
4392         "common/gdb_optional.h".
4393         (print_command_parse_format): Rework to fill in a
4394         value_print_options instead of a format_data.
4395         (print_value): Change parameter type from format_data pointer to
4396         value_print_options reference.  Adjust.
4397         (print_command_1): Process options.  Adjust to pass down a
4398         value_print_options.
4399         (print_command_completer): New.
4400         (_initialize_printcmd): Install print_command_completer as
4401         handle_brkchars completer for the "print" command.  Update
4402         "print"'s help to include supported options.
4403         * valprint.c: Include "cli/cli-option.h".
4404         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4405         here from cp-valprint.c.
4406         (boolean_option_def, uinteger_option_def)
4407         (value_print_option_defs, make_value_print_options_def_group):
4408         New.  Use gdb::option::add_setshow_cmds_for_options to install
4409         "set print elements", "set print null-stop", "set print repeats",
4410         "set print pretty", "set print union", "set print array", "set
4411         print address", "set print symbol", "set print array-indexes".
4412         * valprint.h: Include <string> and "cli/cli-option.h".
4413         (make_value_print_options_def_group): Declare.
4414         (print_value): Change parameter type from format_data pointer to
4415         value_print_options reference.
4416         (print_command_completer): Declare.
4417
4418 2019-06-13  Pedro Alves  <palves@redhat.com>
4419
4420         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4421         (COMMON_SFILES): Add maint-test-settings.c.
4422         * cli/cli-decode.c (boolean_enums): New global, factored out from
4423         ...
4424         (add_setshow_boolean_cmd): ... here.
4425         * cli/cli-decode.h (boolean_enums): Declare.
4426         * cli/cli-option.c: New file.
4427         * cli/cli-option.h: New file.
4428         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4429         factored out from ...
4430         (parse_cli_boolean_value(const char *)): ... this.
4431         (is_unlimited_literal): Change parameter type to pointer to
4432         pointer.  Adjust and advance ARG pointer.
4433         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4434         (parse_cli_var_enum): New, factored out from ...
4435         (do_set_command): ... this.  Adjust.
4436         * cli/cli-setshow.h (parse_cli_boolean_value)
4437         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4438         (parse_cli_var_enum): Declare.
4439         * cli/cli-utils.c: Include "cli/cli-option.h".
4440         (get_ulongest): New.
4441         * cli/cli-utils.h (get_ulongest): Declare.
4442         (check_for_argument): New overloads.
4443         * maint-test-options.c: New file.
4444
4445 2019-06-13  Pedro Alves  <palves@redhat.com>
4446
4447         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4448         parse a range if "-" is at the end of the string.
4449
4450 2019-06-13  Pedro Alves  <palves@redhat.com>
4451
4452         * cli/cli-setshow.c (parse_auto_binary_operation)
4453         (parse_cli_boolean_value): Don't allow "o".
4454
4455 2019-06-13  Pedro Alves  <palves@redhat.com>
4456
4457         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4458         * NEWS: Mention maint test-settings KIND.
4459         * maint-test-settings.c: New file.
4460
4461 2019-06-13  Pedro Alves  <palves@redhat.com>
4462
4463         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4464         completer.
4465         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4466         "set" completers.
4467
4468 2019-06-13  Pedro Alves  <palves@redhat.com>
4469
4470         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4471         after item.
4472
4473 2019-06-13  Pedro Alves  <palves@redhat.com>
4474
4475         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4476
4477 2019-06-13  Pedro Alves <palves@redhat.com>
4478
4479         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4480         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4481         call.
4482         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4483         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4484         calls.
4485         (check_for_argument): Skip spaces after argument.
4486
4487 2019-06-13  Pedro Alves  <palves@redhat.com>
4488
4489         * thread.c (thread_apply_command): Adjust TID parsing.
4490         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4491         detected before end of string.
4492         (tid_is_in_list): Error out if LIST is invalid.
4493
4494 2019-06-13  Pedro Alves  <palves@redhat.com>
4495
4496         * completer.c (complete_line_internal_1): Rewind completion word
4497         point.
4498         (completion_tracker::advance_custom_word_point_by): Change
4499         parameter type to int.
4500         * completer.h (completion_tracker::advance_custom_word_point_by):
4501         Likewise.
4502
4503 2019-06-13  Pedro Alves  <palves@redhat.com>
4504
4505         * completer.c (advance_to_completion_word): Handle delimiters.
4506
4507 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4508
4509         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4510
4511 2019-06-11  Tom Tromey  <tom@tromey.com>
4512
4513         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4514         (xmalloc_failed): Move to alloc.c.
4515         * alloc.c: New file.
4516         * Makefile.in (COMMON_SFILES): Add alloc.c.
4517
4518 2019-06-11  Tom Tromey  <tom@tromey.com>
4519
4520         * nat/linux-waitpid.c: Don't include server.h.
4521         (linux_debug): Remove.
4522         (my_waitpid): Update.
4523
4524 2019-06-11  Tom Tromey  <tromey@adacore.com>
4525
4526         * infcall.c (_initialize_infcall): Remove trailing newline from
4527         help.
4528         * user-regs.c (_initialize_user_regs): Remove trailing newline
4529         from help.
4530         * typeprint.c (_initialize_typeprint): Remove trailing newline
4531         from help.
4532         * reverse.c (_initialize_reverse): Remove trailing newlines from
4533         help.
4534         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4535         from help.
4536         * language.c (add_set_language_command): Remove trailing newline
4537         from help.
4538         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4539         help.
4540         * disasm.c (_initialize_disasm): Remove trailing newline from
4541         help.
4542         * top.c (init_main): Remove trailing newline from help.
4543         * interps.c (_initialize_interpreter): Remove trailing newline
4544         from help.
4545         * btrace.c (_initialize_btrace): Remove trailing newlines from
4546         help.
4547         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4548         from help.
4549         * python/python.c (_initialize_python): Remove trailing newline
4550         from help.
4551         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4552         help.
4553         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4554         from help.  Reformat some text.
4555         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4556         from help.
4557         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4558         newline from help.
4559
4560 2019-06-11  Tom Tromey  <tromey@adacore.com>
4561
4562         * darwin-nat.c (darwin_decode_exception_message)
4563         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4564
4565 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4566
4567         * valops.c (value_slice): Check for not allocated or not
4568         associated values.
4569
4570 2019-06-10  Tom de Vries  <tdevries@suse.de>
4571
4572         PR gdb/24618
4573         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4574         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4575         invalid.
4576
4577 2019-06-10  Tom de Vries  <tdevries@suse.de>
4578
4579         PR gdb/24611
4580         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4581         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4582
4583 2019-06-10  Tom de Vries  <tdevries@suse.de>
4584
4585         PR symtab/24545
4586         * symtab.c (struct demangled_name_entry): Add language field.
4587         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4588         static minimal symbol".  Set and use language field.
4589
4590 2019-06-10  Tom Tromey  <tromey@adacore.com>
4591
4592         * ada-lang.c (_initialize_ada_language): Update help text.
4593
4594 2019-06-10  Tom Tromey  <tromey@adacore.com>
4595
4596         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4597         with a newline.
4598         * guile/guile.c (handle_boot_error): Don't end warning with a
4599         newline.
4600         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4601         warning with a newline.
4602         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4603         newline.
4604         (s12z_frame_cache): Likewise.
4605         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4606         a newline.
4607         * solib-svr4.c (disable_probes_interface): Don't end warning with
4608         a newline.
4609         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4610         newline.
4611         * python/python.c (do_finish_initialization): Don't end warning
4612         with a newline.
4613
4614 2019-06-10  Tom Tromey  <tom@tromey.com>
4615
4616         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4617         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4618         gdbpy_enter.
4619
4620 2019-06-10  Tom Tromey  <tromey@adacore.com>
4621
4622         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4623         data.
4624         (elf_new_init): Don't call stabsread_new_init.
4625         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4626         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4627         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4628
4629 2019-06-10  Tom de Vries  <tdevries@suse.de>
4630
4631         PR symtab/16264
4632         PR symtab/24517
4633         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4634
4635 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4636
4637         * source.c (find_and_open_source): Also rewrite relative file
4638         names.
4639
4640 2019-04-26  Amos Bird  <amosbird@gmail.com>
4641
4642         * annotate.c (annotate_thread_exited): Add "thread-exited"
4643         annotation.
4644
4645 2019-06-06  Tom Tromey  <tromey@adacore.com>
4646
4647         * maint.h (class scoped_command_stats): Use
4648         DISABLE_COPY_AND_ASSIGN.
4649         <print_time>: New method.
4650         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4651         print_time.
4652         (scoped_command_stats::print_time): New method.
4653
4654 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4655
4656         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4657         instructions of lengths 6 or 8 bytes.
4658
4659 2019-06-04  Pedro Alves  <palves@redhat.com>
4660
4661         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4662
4663         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4664         * breakpoint.c (condition_completer): Likewise.
4665         * cli/cli-dump.c (scan_expression): Likewise.
4666         * common/filestuff.c (mkdir_recursive): Likewise.
4667         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4668         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4669         (gdb_abspath): Likewise.
4670         * compile/compile-cplus-types.c
4671         (compile_cplus_instance::decl_name): Likewise.
4672         * completer.c (complete_explicit_location):
4673         (signal_completer, reg_or_group_completer_1): Likewise.
4674         * cp-support.c (cp_remove_params_if_any): Likewise.
4675         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4676         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4677         * infcmd.c (strip_bg_char): Likewise.
4678         * linespec.c (copy_token_string): Likewise.
4679         * mi/mi-main.c (output_cores): Likewise.
4680         * psymtab.c (psymtab_search_name):
4681         * symfile.c (test_set_ext_lang_command): Likewise.
4682         * target.c (target_fileio_read_stralloc): Likewise.
4683         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4684         * value.c (complete_internalvar): Likewise.
4685
4686 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4687
4688         Add objfile property to gdb.Type.
4689         * NEWS: Mention Python API addition.
4690         * python/py-type.c (typy_get_objfile): New method.
4691
4692 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4693
4694         * NEWS: Mention the new set|show style [title|highlight].
4695         Mention changes to "show style", "help" and "apropos".
4696
4697 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4698
4699         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4700         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4701         instead of print_help_for_command.
4702         (print_doc_of_command): New function.
4703         (help_list): Add 'apropos -v word' suggestion.
4704         (print_help_for_command): Style the command name using title style.
4705         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4706         (_initialize_cli_cmds): Describe -v in apropos_command help.
4707
4708 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4709
4710         * cli/cli-style.h (cli_style_option): Add name in constructor,
4711         add m_name class member, add constructor with intensity,
4712         add name class function.
4713         (cli_style_option::add_setshow_commands): Remove name argument.
4714         (highlight_style, title_style): New styles.
4715         * cli/cli-style.c (do_show): New function that shows a style
4716         characteristic styling the style name with itself.
4717         (set_style_name): New function.
4718         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4719         Update all callers according to the changes in cli/cli-style.h.
4720         * utils.h (fputs_highlighted): New function.
4721         * utils.c (fputs_highlighted): Likewise.
4722
4723 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4724
4725         * NEWS: Mention new pipe command and new convenience variables.
4726
4727 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4728
4729         * cli/cli-cmds.c (pipe_command): New function.
4730         (_initialize_cli_cmds): Call add_com for pipe_command.
4731         Define | as an alias for pipe.
4732         (exit_status_set_internal_vars): New function.
4733         (shell_escape): Call exit_status_set_internal_vars.
4734         cli/cli-decode.c (find_command_name_length): Recognize | as
4735         a single character command.
4736
4737 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4738
4739         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4740         top.c (execute_command_to_ui_file): New function, mostly a copy
4741         of execute_command_to_string.
4742         (execute_command_to_string): Implement by calling
4743         execute_command_to_ui_file.
4744
4745 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4746
4747         * top.h (saved_command_line): Remove declaration.
4748         * top.c (previous_saved_command_line, previous_repeat_arguments):
4749         New variables.
4750         (saved_command_line): Make static, define together with other
4751         'repeat variables'.
4752         (dont_repeat): Clear repeat_arguments.
4753         (repeat_previous, get_saved_command_line, save_command_line):
4754         New functions.
4755         (gdb_init): Initialize saved_command_line
4756         and previous_saved_command_line.
4757         * main.c (captured_main_1): Remove saved_command_line initialization.
4758         * event-top.c (handle_line_of_input): Update to use
4759         the new 'repeat' related functions instead of direct access to
4760         saved_command_line.
4761         * command.h (repeat_previous, get_saved_command_line,
4762         save_command_line): New declarations.
4763         (dont_repeat): Add comment.
4764
4765 2019-05-30  Tom Tromey  <tromey@adacore.com>
4766
4767         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4768         Fix comment.
4769         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4770
4771 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4772
4773         PR cli/24587
4774         * completer.c (complete): Initialize variable word.
4775
4776 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4777
4778         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4779         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4780         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4781         'body' is NULL to the outter 'if', protecting the '!is_define'
4782         situation as well.
4783
4784 2019-05-29  Tom Tromey  <tromey@adacore.com>
4785
4786         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4787         (dwarf_unknown): New function.
4788         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4789         (dwarf_type_encoding_name): Use dwarf_unknown.
4790
4791 2019-05-29  Tom Tromey  <tromey@adacore.com>
4792
4793         PR c++/20020:
4794         * cp-valprint.c (cp_print_value_fields): Call
4795         cp_print_static_field inside "try".
4796
4797 2019-05-29  Tom Tromey  <tromey@adacore.com>
4798
4799         * inflow.c (struct terminal_info): Add default operator=.
4800         * configure: Rebuild.
4801         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4802         -Wdeprecated-copy-dtor, -Wredundant-move.
4803
4804 2019-05-29  Tom Tromey  <tromey@adacore.com>
4805
4806         * NEWS: Add entry.
4807         * infcmd.c (print_return_value_1): Handle finish_print
4808         option.
4809         (show_print_finish): New function.
4810         (_initialize_infcmd): Add "set/show print finish" commands.
4811         * valprint.c (user_print_options): Initialize new member.
4812         * valprint.h (struct value_print_options) <finish_print>: New
4813         member.
4814
4815 2019-05-28  Tom Tromey  <tromey@adacore.com>
4816
4817         * ada-lang.c (ada_remove_Xbn_suffix)
4818         (find_old_style_renaming_symbol)
4819         (parse_old_style_renaming): Remove.
4820         (ada_find_renaming_symbol): Don't call
4821         find_old_style_renaming_symbol.
4822         (ada_is_renaming_symbol): Rename from
4823         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4824         bool.  Now static.
4825         (ada_read_var_value): Update and simplify.
4826         * ada-exp.y (write_var_or_type): Remove old code.
4827
4828 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4829
4830         * event-top.c: Remove include comment.
4831         * inflow.c (class scoped_ignore_sigttou): Move from here...
4832         * inflow.h (class scoped_ignore_sigttou): ...to here.
4833         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4834         * top.c:  Remove include comment.
4835
4836 2019-05-27  Tom Tromey  <tom@tromey.com>
4837
4838         * NEWS: Fix typo.
4839
4840 2019-05-22  Tom Tromey  <tromey@adacore.com>
4841
4842         * target.c (target_follow_exec): Constify parameter.
4843         * target-delegates.c: Rebuild.
4844         * remote.c (remote_target::follow_exec): Constify parameter.
4845         * infrun.c (follow_exec): Constify parameter.
4846         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4847         (target_follow_exec): Likewise.
4848
4849 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4850
4851         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4852         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4853
4854 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4855
4856         * NEWS: Add debugredirect and testsuite sections.
4857
4858 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4859
4860         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4861         target descriptions using exclusively floating point register name
4862         aliases.
4863
4864 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4865
4866         PR gdb/18644:
4867         * f-lang.c (build_fortran_types): Handle the case where
4868         gdbarch_floatformat_for_type returns a nullptr.
4869
4870 2019-05-21  Tom de Vries  <tdevries@suse.de>
4871
4872         PR cli/24587
4873         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4874
4875 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4876
4877         PR gdb/18644:
4878         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4879         16-byte floats.
4880         * i386-tdep.c (i386_floatformat_for_type): Use
4881         floatformats_ia64_quad for the 16-byte floating point component
4882         within a fortran 32-byte complex number.
4883
4884 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4885
4886         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4887         delete default constructor.
4888         (find_partial_die): Update to return const struct.
4889         (partial_die_parent_scope): Move variable declaration into scope
4890         of its use and change its type to auto.
4891         (guess_partial_die_structure_name): Likewise.
4892         (partial_die_info::fixup): Likewise.
4893
4894 2019-05-17  Tom Tromey  <tromey@adacore.com>
4895
4896         * source.c (find_and_open_source): Remove cast.
4897
4898 2019-05-17  Tom Tromey  <tromey@adacore.com>
4899
4900         * annotate.c (annotate_source): Make "filename" const.
4901         * annotate.h (annotate_source): Use const.
4902
4903 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4904
4905         * disasm.c (set_disassembler_options): Send errors to stderr.
4906
4907 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4908
4909         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4910         (cli_interp_base::set_logging): Check debug_redirect.
4911         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4912         * cli/cli-logging.c (debug_redirect): Add static variable.
4913         (pop_output_files): Add default param.
4914         (handle_redirections): Print debug setting.
4915         (show_logging_command): Likewise.
4916         (_initialize_cli_logging): Add debugredirect command.
4917         * interps.c (current_interp_set_logging): Add debug_redirect
4918         parameter.
4919         * interps.h (set_logging): Add debug_redirect parameter.
4920         (current_interp_set_logging): Likewise.
4921         * mi/mi-common.h: Likewise.
4922         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4923
4924 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4925             Tom Tromey  <tromey@adacore.com>
4926
4927         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4928         directly.
4929         * cli/cli-interp.h (make_logging_output): Remove declaration.
4930         * cli/cli-logging.c (make_logging_output): Remove function.
4931         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4932         directly.
4933         * ui-file.c (tee_file::tee_file): Remove bools.
4934         (tee_file::~tee_file): Remove deletes.
4935         * ui-file.h (tee_file): Remove bools.
4936
4937 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4938
4939         * mi/mi-cmds.h (mi_cmd_complete): New function.
4940         * mi/mi-main.c (mi_cmd_complete): Likewise.
4941         * mi/mi-cmds.c: Define new MI command -complete.
4942         * NEWS: Mention new -complete command.
4943
4944 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4945
4946         * completer.h (complete): New function.
4947         * completer.c (complete): Likewise.
4948         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4949         function defined in completer.h.
4950
4951 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4952
4953         * MAINTAINERS (Write After Approval): Add myself.
4954
4955 2019-05-17  Tom de Vries  <tdevries@suse.de>
4956
4957         PR gdb/24094
4958         * dwarf2read.c (struct cu_partial_die_info): New struct.
4959         (find_partial_die): Return cu_partial_die_info.
4960         (partial_die_parent_scope, guess_partial_die_structure_name)
4961         (partial_die_info::fixup): Handle new return type of find_partial_die.
4962
4963 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4964
4965         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4966         "std::string", simplifying the algorithm.
4967
4968 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4969
4970         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4971         (stap_static_probe_ops::get_probes): Likewise.
4972
4973 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4974
4975         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4976         '-')" and "else if".
4977         (stap_parse_single_operand): Join checks for
4978         "gdbarch_stap_parse_special_token_p" and
4979         "gdbarch_stap_parse_special_token" in the same "if" statement.
4980         Invert check when verifying for operation on register
4981         displacement.
4982
4983 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4984
4985         * stap-probe.c (stap_get_opcode): Update comment.
4986         (stap_get_expected_argument_type): Likewise.
4987         (handle_stap_probe): Likewise.
4988
4989 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4990
4991         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4992         return type to 'bool'.  Adjust comment.  Use 'bool' when
4993         appropriate.
4994         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4995         * stap-probe.c (stap_parse_argument_1): Likewise.
4996         (stap_is_operator): Likewise.
4997         (stap_is_generic_prefix): Likewise.
4998         (stap_is_register_prefix): Likewise.
4999         (stap_is_register_indirection_prefix): Likewise.
5000         (stap_is_integer_prefix): Likewise.
5001         (stap_generic_check_suffix): Likewise.
5002         (stap_check_integer_suffix): Likewise.
5003         (stap_check_register_suffix): Likewise.
5004         (stap_check_register_indirection_suffix): Likewise.
5005         (stap_parse_register_operand): Likewise.
5006         (stap_parse_single_operand): Likewise.
5007         (stap_parse_argument_1): Likewise.
5008         (stap_probe::get_argument_count): Likewise.
5009         (stap_is_operator): Likewise.
5010
5011 2019-05-16  Tom Tromey  <tromey@adacore.com>
5012
5013         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5014         keyword to foreach.
5015
5016 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5017
5018         * linux-thread-db.c (try_thread_db_load_1): Change return type
5019         to bool.
5020         (try_thread_db_load): Likewise.
5021         (try_thread_db_load_from_pdir_1): Likewise.
5022         (try_thread_db_load_from_pdir): Likewise.
5023         (try_thread_db_load_from_sdir): Likewise.
5024         (try_thread_db_load_from_dir): Likewise.
5025         (thread_db_load_search): Likewise.
5026         (has_libpthread): Likewise.
5027         (thread_db_load): Likewise.
5028
5029 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5030
5031         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5032         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5033         NULL, and complain/return if that's the case.
5034
5035 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5036
5037         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5038         (advance, posn, abstract_read_memory): New functions.
5039         [struct mem_read_abstraction]: New struct.
5040         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5041
5042 2019-05-14  Tom Tromey  <tromey@adacore.com>
5043
5044         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5045         value is not lval_memory.
5046
5047 2019-05-14  Tom Tromey  <tromey@adacore.com>
5048
5049         * solib.c (info_sharedlibrary_command): Style the file name.
5050
5051 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5052
5053         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5054         (aarch64_vnv_type): Likewise.
5055         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5056         * common/tdesc.c: Likewise.
5057         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5058         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5059         * features/aarch64-fpu.xml: Add ieee half view.
5060         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5061         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5062         * gdbtypes.h (struct builtin_type): Likewise.
5063         (struct objfile_type): Likewise.
5064
5065 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5066
5067         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5068         typo.
5069         * location.h (string_to_event_location): Likewise.
5070
5071 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5072
5073         GDB 8.3 released.
5074
5075 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5076
5077         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5078         New variable declaration.
5079         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5080         New variable.
5081         (print_one_breakpoint): Use ui_out::test_flags and new global
5082         variable to compute use_fixed_output.
5083         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5084         Remove.
5085         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5086         (mi_multi_location_breakpoint_output_fixed): Remove.
5087         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5088         new variable.
5089         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5090         fix_multi_location_breakpoint_output flag if version >= 3.
5091         * ui-out.h (enum ui_out_flag)
5092         <fix_multi_location_breakpoint_output>: New enumerator.
5093
5094 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5095
5096         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5097
5098 2019-05-10  Tom Tromey  <tromey@adacore.com>
5099
5100         * ada-lang.c (catch_ada_completer): New function.
5101         (_initialize_ada_language): Use it.
5102
5103 2019-05-10  Tom Tromey  <tromey@adacore.com>
5104
5105         * thread.c (print_thread_info): Make "requested_threads" const.
5106         * gdbthread.h (print_thread_info): Make "requested_threads"
5107         const.
5108         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5109         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5110
5111 2019-05-08  Tom Tromey  <tom@tromey.com>
5112
5113         * gdbtypes.c (objfile_type_data): Change type.
5114         (objfile_type, _initialize_gdbtypes): Update.
5115
5116 2019-05-08  Tom Tromey  <tom@tromey.com>
5117
5118         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5119         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5120         (_initialize_dwarf2_frame): Update.
5121
5122 2019-05-08  Tom Tromey  <tom@tromey.com>
5123
5124         * objc-lang.c (objc_objfile_data): Change type.
5125         (find_methods): Update.
5126         (_initialize_objc_lang): Remove.
5127
5128 2019-05-08  Tom Tromey  <tom@tromey.com>
5129
5130         * stabsread.c (rs6000_builtin_type_data): Change type.
5131         (rs6000_builtin_type, _initialize_stabsread): Update.
5132
5133 2019-05-08  Tom Tromey  <tom@tromey.com>
5134
5135         * mips-tdep.c (mips_pdr_data): Remove.
5136         (_initialize_mips_tdep): Update.
5137
5138 2019-05-08  Tom Tromey  <tom@tromey.com>
5139
5140         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5141         (hppa_init_objfile_priv_data, read_unwind_info)
5142         (find_unwind_entry, _initialize_hppa_tdep): Update.
5143
5144 2019-05-08  Tom Tromey  <tom@tromey.com>
5145
5146         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5147         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5148         on obstack.
5149         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5150
5151 2019-05-08  Tom Tromey  <tom@tromey.com>
5152
5153         * mdebugread.c (basic_type_data): Change type.
5154         (basic_type, _initialize_mdebugread): Update.
5155
5156 2019-05-08  Tom Tromey  <tom@tromey.com>
5157
5158         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5159
5160 2019-05-08  Tom Tromey  <tom@tromey.com>
5161
5162         * nto-tdep.c (nto_inferior_data_reg): Change type.
5163         (nto_inferior_data): Update.
5164         (nto_inferior_data_cleanup, nto_new_inferior_data)
5165         (_initialize_nto_tdep): Remove.
5166         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5167
5168 2019-05-08  Tom Tromey  <tom@tromey.com>
5169
5170         * ada-lang.c (struct ada_inferior_data): Add initializers.
5171         (ada_inferior_data): Change type.
5172         (ada_inferior_data_cleanup): Remove.
5173         (get_ada_inferior_data, ada_inferior_exit)
5174         (struct ada_pspace_data): Add initializers, destructor.
5175         (ada_pspace_data_handle): Change type.
5176         (get_ada_pspace_data): Update.
5177         (ada_pspace_data_cleanup): Remove.
5178
5179 2019-05-08  Tom Tromey  <tom@tromey.com>
5180
5181         * coffread.c (struct coff_symfile_info): Add initializers.
5182         (coff_objfile_data_key): Move lower.  Change type.
5183         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5184         Update.
5185         (coff_free_info): Remove.
5186
5187 2019-05-08  Tom Tromey  <tom@tromey.com>
5188
5189         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5190         (fbsd_pspace_data_handle): Move lower.  Change type.
5191         (get_fbsd_pspace_data): Update.
5192         (fbsd_pspace_data_cleanup): Remove.
5193         (_initialize_fbsd_tdep): Update.
5194
5195 2019-05-08  Tom Tromey  <tom@tromey.com>
5196
5197         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5198         (get_ada_tasks_pspace_data): Update.
5199         (ada_tasks_pspace_data_cleanup): Remove.
5200         (_initialize_tasks): Update.
5201         (ada_tasks_inferior_data_handle): Change type.
5202         (get_ada_tasks_inferior_data): Update.
5203         (ada_tasks_inferior_data_cleanup): Remove.
5204         (struct ada_tasks_pspace_data): Add initializers.
5205
5206 2019-05-08  Tom Tromey  <tom@tromey.com>
5207
5208         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5209         * symfile-debug.c (debug_sym_get_probes): Change type.
5210         * stap-probe.c (handle_stap_probe):
5211         (stap_static_probe_ops::get_probes): Change type.
5212         * probe.h (class static_probe_ops) <get_probes>: Change type.
5213         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5214         (parse_probes_in_pspace): Update.
5215         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5216         Update.
5217         (any_static_probe_ops::get_probes): Change type.
5218         * elfread.c (elfread_data): New typedef.
5219         (probe_key): Change type.
5220         (elf_get_probes): Likewise.  Update.
5221         (probe_key_free): Remove.
5222         (_initialize_elfread): Update.
5223         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5224         Change type.
5225         (dtrace_process_dof_probe, dtrace_process_dof)
5226         (dtrace_static_probe_ops::get_probe): Change type.
5227
5228 2019-05-08  Tom Tromey  <tom@tromey.com>
5229
5230         * xcoffread.c (struct xcoff_symfile_info): Rename from
5231         coff_symfile_info.  Add initializers.
5232         (xcoff_objfile_data_key): Move lower.  Change type.
5233         (XCOFF_DATA): Rewrite.
5234         (xcoff_free_info): Remove.
5235         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5236         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5237         (xcoff_initial_scan): Update.
5238
5239 2019-05-08  Tom Tromey  <tom@tromey.com>
5240
5241         * solib-svr4.c (struct svr4_info): Add initializers and
5242         destructor.
5243         <probes_table>: Now an htab_up.
5244         (solib_svr4_pspace_data): Change type.
5245         (free_probes_table): Simplify.
5246         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5247         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5248         (probes_table_remove_objfile_probes, register_solib_event_probe)
5249         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5250         (_initialize_svr4_solib): Update.
5251
5252 2019-05-08  Tom Tromey  <tom@tromey.com>
5253
5254         * remote.c (remote_pspace_data): Change type.
5255         (remote_pspace_data_cleanup): Remove.
5256         (get_remote_exec_file, set_pspace_remote_exec_file)
5257         (_initialize_remote): Update.
5258
5259 2019-05-08  Tom Tromey  <tom@tromey.com>
5260
5261         * breakpoint.c (breakpoint_objfile_key): Change type.
5262         (get_breakpoint_objfile_data): Update.
5263         (free_breakpoint_objfile_data): Remove.
5264         (_initialize_breakpoint): Update.
5265
5266 2019-05-08  Tom Tromey  <tom@tromey.com>
5267
5268         * linux-tdep.c (struct linux_info): Add initializers.
5269         (linux_inferior_data): Move.  Change type.
5270         (invalidate_linux_cache_inf): Update.
5271         (linux_inferior_data_cleanup): Remove.
5272         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5273
5274 2019-05-08  Tom Tromey  <tom@tromey.com>
5275
5276         * auxv.c (auxv_inferior_data): Move.  Change type.
5277         (auxv_inferior_data_cleanup): Remove.
5278         (invalidate_auxv_cache_inf): Rewrite.
5279         (get_auxv_inferior_data, _initialize_auxv): Update.
5280
5281 2019-05-08  Tom Tromey  <tom@tromey.com>
5282
5283         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5284         (symfile_debug_objfile_data_key): Change type.
5285         (symfile_debug_installed, debug_qf_has_symbols)
5286         (debug_qf_find_last_source_symtab)
5287         (debug_qf_forget_cached_source_info)
5288         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5289         (debug_qf_print_stats, debug_qf_dump)
5290         (debug_qf_expand_symtabs_for_function)
5291         (debug_qf_expand_all_symtabs)
5292         (debug_qf_expand_symtabs_with_fullname)
5293         (debug_qf_map_matching_symbols)
5294         (debug_qf_expand_symtabs_matching)
5295         (debug_qf_find_pc_sect_compunit_symtab)
5296         (debug_qf_map_symbol_filenames)
5297         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5298         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5299         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5300         (debug_sym_read_linetable, debug_sym_relocate): Update.
5301         (symfile_debug_free_objfile): Remove.
5302         (install_symfile_debug_logging, _initialize_symfile_debug):
5303         Update.
5304
5305 2019-05-08  Tom Tromey  <tom@tromey.com>
5306
5307         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5308         allocate_on_obstack.
5309         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5310         (get_dwarf2_per_objfile): Update.
5311         (set_dwarf2_per_objfile): Remove.
5312         (dwarf2_has_info, dwarf2_get_section_info): Update.
5313         (dwarf2_free_objfile): Remove.
5314         (_initialize_dwarf2_read): Update.
5315
5316 2019-05-08  Tom Tromey  <tom@tromey.com>
5317
5318         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5319         initializers.
5320         <unsupported_script_warning_printed,
5321         script_not_found_warning_printed>: Now bool.
5322         (auto_load_pspace_data): Change type.
5323         (~auto_load_pspace_info): Rename from
5324         auto_load_pspace_data_cleanup.
5325         (get_auto_load_pspace_data, init_loaded_scripts_info)
5326         (clear_section_scripts, maybe_print_unsupported_script_warning)
5327         (maybe_print_script_not_found_warning, _initialize_auto_load):
5328         Update.
5329
5330 2019-05-08  Tom Tromey  <tom@tromey.com>
5331
5332         * objfiles.c (objfile_pspace_info): Add destructor and
5333         initializers.
5334         (objfiles_pspace_data): Change type.
5335         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5336         (get_objfile_pspace_data): Update.
5337         (objfiles_bfd_data): Change type.
5338         (get_objfile_bfd_data): Update.
5339         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5340
5341 2019-05-08  Tom Tromey  <tom@tromey.com>
5342
5343         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5344         Change type.
5345         (get_catch_syscall_inferior_data): Update.
5346         (catch_syscall_inferior_data_cleanup): Remove.
5347         (_initialize_break_catch_syscall): Update.
5348
5349 2019-05-08  Tom Tromey  <tom@tromey.com>
5350
5351         * inflow.c (struct terminal_info): Add destructor and
5352         initializers.
5353         (inflow_inferior_data): Change type.
5354         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5355         (get_inflow_inferior_data, inflow_inferior_exit)
5356         (swap_terminal_info, _initialize_inflow): Update.
5357
5358 2019-05-08  Tom Tromey  <tom@tromey.com>
5359
5360         * target-dcache.c (target_dcache_cleanup): Remove.
5361         (target_dcache_aspace_key): Change type.
5362         (target_dcache_init_p, target_dcache_invalidate)
5363         (target_dcache_get, target_dcache_get_or_init)
5364         (_initialize_target_dcache): Update.
5365         * dcache.h (struct dcache_deleter): New.
5366
5367 2019-05-08  Tom Tromey  <tom@tromey.com>
5368
5369         * symtab.c (struct symbol_cache): Add destructor and
5370         initializers.
5371         (symbol_cache_key): Move.  Change type.
5372         (make_symbol_cache, free_symbol_cache): Remove.
5373         (get_symbol_cache): Update.
5374         (symbol_cache_cleanup): Remove.
5375         (ALL_PSPACES, symbol_cache_flush)
5376         (maintenance_print_symbol_cache)
5377         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5378         Update.
5379
5380 2019-05-08  Tom Tromey  <tom@tromey.com>
5381
5382         * symtab.c (struct main_info): Add destructor and initializers.
5383         (main_progspace_key): Move.  Change type.
5384         (get_main_info): Update.
5385         (main_info_cleanup): Remove.
5386         (_initialize_symtab): Update.
5387
5388 2019-05-08  Tom Tromey  <tom@tromey.com>
5389
5390         * registry.h (DECLARE_REGISTRY): Define the _key class.
5391
5392 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5393
5394         * NEWS: Merge two 'New commands' sections.
5395
5396 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5397
5398         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5399         parameter and use Ada language definition instead.
5400         (ada_val_print_ptr): Remove unused language parameter.
5401         (ada_val_print_num): Remove language parameter and use Ada language
5402         definition instead.
5403         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5404         parameter.
5405         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5406         parameter and use Ada language definition instead.
5407         (ada_val_print_1): Update all ada_val_print_xxx calls.
5408         Remove language parameter.
5409         (ada_val_print): Update ada_val_print_1 call.
5410
5411 2019-05-08  Tom Tromey  <tromey@adacore.com>
5412
5413         * remote.c (remote_hw_watchpoint_limit)
5414         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5415         Now static.
5416
5417 2019-05-08  Tom Tromey  <tromey@adacore.com>
5418
5419         * maint.c (_initialize_maint_cmds): Move initialization code to
5420         remote.c.
5421         (watchdog, show_watchdog): Move to remote.c.
5422         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5423         "watchdog" static.
5424         (_initialize_remote): Move initialization code from maint.c.
5425         * defs.h (watchdog): Don't declare.
5426
5427 2019-05-08  Tom Tromey  <tromey@adacore.com>
5428
5429         * tui/tui-interp.c: Include main.h.
5430         * interps.c: Include main.h.
5431         * main.h (interpreter_p): Declare.
5432         * defs.h (interpreter_p): Don't declare.
5433
5434 2019-05-08  Tom Tromey  <tromey@adacore.com>
5435
5436         * dwarf2loc.c: Include dwarf2read.h.
5437         * defs.h (read_unsigned_leb128): Don't declare.
5438         * dwarf2read.h (read_unsigned_leb128): Declare.
5439
5440 2019-05-08  Tom Tromey  <tromey@adacore.com>
5441
5442         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5443         method.
5444
5445 2019-05-08  Tom Tromey  <tromey@adacore.com>
5446
5447         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5448         when no wrap column is set.
5449
5450 2019-05-08  Tom Tromey  <tromey@adacore.com>
5451
5452         * c-lang.c (c_get_string): Handle non-C-style arrays.
5453
5454 2019-05-08  Tom Tromey  <tromey@adacore.com>
5455
5456         * typeprint.c (print_offset_data::update): Print the bit offset,
5457         not the number of bits remaining.
5458
5459 2019-05-08  Tom Tromey  <tromey@adacore.com>
5460
5461         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5462         padding at end of comment.
5463
5464 2019-05-08  Tom Tromey  <tromey@adacore.com>
5465
5466         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5467         Compare main types.
5468
5469 2019-05-06  Tom Tromey  <tom@tromey.com>
5470
5471         * common/scoped_mmap.c: Include common-defs.h.
5472         * common/scoped_mmap.h: Don't include config.h.
5473
5474 2019-05-04  Tom Tromey  <tom@tromey.com>
5475
5476         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5477         (struct aarch64_call_info): Add initializers.
5478         <si>: Now a std::vector.
5479         (pass_on_stack, aarch64_push_dummy_call): Update.
5480
5481 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5482             Tom Tromey  <tom@tromey.com>
5483
5484         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5485         (ppc_threads): Now a std::vector.  Now static.
5486         (hwdebug_find_thread_points_by_tid)
5487         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5488         Update.
5489
5490 2019-05-04  Tom Tromey  <tom@tromey.com>
5491
5492         * arc-tdep.c (arc_tdesc_init): Return bool.
5493
5494 2019-05-04  Tom Tromey  <tom@tromey.com>
5495
5496         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5497         Use gdb_assert_not_reached.
5498
5499 2019-05-04  Tom Tromey  <tom@tromey.com>
5500
5501         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5502         "false".
5503
5504 2019-05-04  Tom Tromey  <tom@tromey.com>
5505
5506         * arc-tdep.c (arc_tdesc_init): Use bool.
5507
5508 2019-05-04  Tom Tromey  <tom@tromey.com>
5509
5510         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5511
5512 2019-05-04  Tom Tromey  <tom@tromey.com>
5513
5514         * cli/cli-cmds.c (valid_command_p): Return bool.
5515
5516 2019-05-04  Tom Tromey  <tom@tromey.com>
5517
5518         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5519         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5520
5521 2019-05-04  Raul Tambre  <raul@tambre.ee>
5522
5523         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5524         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5525         operator for comparison.
5526
5527 2019-05-04  Tom Tromey  <tom@tromey.com>
5528
5529         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5530         (lookup_partial_symbol, print_partial_symbols)
5531         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5532         (psymbol_compare): Update.
5533         (add_psymbol_to_bcache): Clear the entire psymbol.
5534         (maintenance_check_psymtabs): Update.
5535         * psympriv.h (struct partial_symbol): Don't derive from
5536         general_symbol_info.
5537         <obj_section, unrelocated_address, address,
5538         set_unrelocated_address>: Update.
5539         <ginfo>: New member.
5540         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5541         (debug_names::write_psymbols): Update.
5542
5543 2019-05-04  Tom de Vries  <tdevries@suse.de>
5544
5545         * contrib/cc-with-tweaks.sh: Support -n arg.
5546
5547 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5548
5549         * corelow.c (core_target::detach): Ensure frame cache and
5550         register caches are cleared.
5551         inferior.c (exit_inferior_1): Likewise.
5552
5553 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5554             Tom Tromey  <tom@tromey.com>
5555
5556         * dictionary.c (collate_pending_symbols_by_language): Remove
5557         "struct" from foreach.
5558         * symtab.c (lookup_global_symbol_from_objfile)
5559         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5560         foreach.
5561         * ser-tcp.c (net_open): Remove "struct" from foreach.
5562         * objfiles.c (objfile_relocate, objfile_rebase)
5563         (objfile_has_symbols): Remove "struct" from foreach.
5564         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5565         from foreach.
5566         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5567         foreach.
5568         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5569         "struct" from foreach.
5570         * ada-lang.c (create_excep_cond_exprs)
5571         (ada_exception_catchpoint_cond_string): Remove "struct" from
5572         foreach.
5573
5574 2019-05-03  Tom Tromey  <tromey@adacore.com>
5575
5576         * ada-exp.y (convert_char_literal): Check suffix of each
5577         enumerator.
5578
5579 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5580
5581         PR ada/21406:
5582         * ada-exp.y (yywrap): Don't define.
5583         * ada-lex.l (%option): Add noyywrap
5584         (yywrap): Remove.
5585
5586 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5587
5588         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5589         _WIN32_WINNT to the XP level, unless already defined to a higher
5590         level.
5591
5592         * unittests/parse-connection-spec-selftests.c:
5593         * ser-tcp.c:
5594         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5595         override.
5596
5597         * symfile.c (find_separate_debug_file): Remove colon from the
5598         drive spec of DOS/Windows file names of the target, so that the
5599         file name produced from DEBUGDIR and the target's directory will
5600         be valid on DOS/Windows systems.
5601
5602 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5603
5604         * rust-lang.c (val_print_struct): Handle printing structures
5605         containing strings.
5606
5607 2019-05-02  Tom Tromey  <tromey@adacore.com>
5608
5609         * valarith.c (_initialize_valarith): Remove.
5610
5611 2019-05-01  Tom Tromey  <tromey@adacore.com>
5612
5613         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5614         bitfields.
5615
5616 2019-05-01  Tom Tromey  <tromey@adacore.com>
5617
5618         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5619         for big-endian copies.
5620
5621 2019-04-30  Ali Tamur  <tamur@google.com>
5622         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5623         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5624         (read_3_bytes): New function.
5625
5626 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5627
5628         * windows-nat.c (main_thread_id): Delete.
5629         (handle_output_debug_string): Replace main_thread_id by
5630         current_event.dwThreadId.
5631         (fake_create_process): Likewise.
5632         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5633         Do not set main_thread_id.
5634         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5635         current_event.dwThreadId.
5636         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5637
5638 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5639
5640         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5641         Use current_event.dwThreadId instead of main_thread_id.
5642
5643 2019-04-30  Tom Tromey  <tromey@adacore.com>
5644
5645         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5646         (create_excep_cond_exprs): Iterate over program spaces.
5647         (ada_exception_catchpoint_cond_string): Examine all minimal
5648         symbols for exception types.
5649
5650 2019-04-30  Tom Tromey  <tromey@adacore.com>
5651
5652         PR c++/24470:
5653         * dwarf2read.c (process_structure_scope): Handle case where type
5654         has template parameters but no symbol was created.
5655
5656 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5657             Chris January  <chris.january@arm.com>
5658
5659         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5660         qualifier.
5661         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5662
5663 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5664
5665         * f-typeprint.c (f_print_type): Update rules for printing
5666         whitespace.
5667         (f_type_print_varspec_suffix): Likewise.
5668
5669 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5670             Chris January  <chris.january@arm.com>
5671
5672         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5673         function arguments.
5674
5675 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5676
5677         * f-lang.c (build_fortran_types): Change name of void type to
5678         lower case.
5679         * f-typeprint.c (f_type_print_base): Print the name of the void
5680         type, rather than a fixed string.
5681         * f-valprint.c (f_decorations): Use lower case void string.
5682
5683 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5684             Chris January  <chris.january@arm.com>
5685
5686         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5687         types for Fortran.
5688
5689 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5690             Chris January  <chris.january@arm.com>
5691             David Lecomber  <david.lecomber@arm.com>
5692
5693         * f-exp.y (BINOP_INTRINSIC): New token.
5694         (exp): New parser rule handling BINOP_INTRINSIC.
5695         (f77_keywords): Add new builtin procedures.
5696         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5697         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5698         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5699         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5700         (print_unop_subexp_f): New function.
5701         (print_binop_subexp_f): New function.
5702         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5703         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5704         (dump_subexp_body_f): Likewise.
5705         (operator_check_f): Likewise.
5706         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5707         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5708
5709 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5710
5711         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5712         UNOP_KIND.
5713         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5714         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5715         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5716         (operator_length_f): New fuction.
5717         (print_subexp_f): New function.
5718         (op_name_f): New function.
5719         (dump_subexp_body_f): New function.
5720         (operator_check_f): New function.
5721         (exp_descriptor_f): Replace standard expression handling functions
5722         with new functions.
5723         * gdb/fortran-operator.def: New file.
5724         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5725         * gdb/std-operator.def: Remove UNOP_KIND.
5726
5727 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5728
5729         * std-operator.def: Remove unbalanced, stray double quote
5730         character.
5731
5732 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5733             Chris January  <chris.january@arm.com>
5734             Daniel Everett  <daniel.everett@arm.com>
5735             Nick Forrington  <nick.forrington@arm.com>
5736             Richard Bunt  <richard.bunt@arm.com>
5737
5738         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5739         of depth when printing anonymous structs or unions.
5740         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5741         Don't print either the top-level value, or the children if the
5742         max-depth is exceeded.
5743         (ppscm_print_children): When printing the key of a map, allow one
5744         extra level of depth.
5745         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5746         print either the top-level value, or the children if the max-depth
5747         is exceeded.
5748         (print_children): When printing the key of a map, allow one extra
5749         level of depth.
5750         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5751         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5752         (user_print_options): Initialise max_depth field.
5753         (val_print_scalar_or_string_type_p): New function.
5754         (val_print): Check to see if the max depth has been reached.
5755         (val_print_check_max_depth): Define new function.
5756         (show_print_max_depth): New function.
5757         (_initialize_valprint): Add 'print max-depth' option.
5758         * valprint.h (struct value_print_options) <max_depth>: New field.
5759         (val_print_check_max_depth): Declare new function.
5760         * NEWS: Document new feature.
5761
5762 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5763
5764         * ada-lang.c (ada_language_defn): Initialise new field.
5765         * c-lang.c (c_is_string_type_p): New function.
5766         (c_language_defn): Initialise new field.
5767         (cplus_language_defn): Initialise new field.
5768         (asm_language_defn): Initialise new field.
5769         (minimal_language_defn): Initialise new field.
5770         * c-lang.h (c_is_string_type_p): Declare new function.
5771         * d-lang.c (d_language_defn): Initialise new field.
5772         * f-lang.c (f_is_string_type_p): New function.
5773         (f_language_defn): Initialise new field.
5774         * go-lang.c (go_is_string_type_p): New function.
5775         (go_language_defn): Initialise new field.
5776         * language.c (default_is_string_type_p): New function.
5777         (unknown_language_defn): Initialise new field.
5778         (auto_language_defn): Initialise new field.
5779         * language.h (struct language_defn) <la_is_string_type_p>: New
5780         member variable.
5781         (default_is_string_type_p): Declare new function.
5782         * m2-lang.c (m2_language_defn): Initialise new field.
5783         * objc-lang.c (objc_language_defn): Initialise new field.
5784         * opencl-lang.c (opencl_language_defn): Initialise new field.
5785         * p-lang.c (pascal_is_string_type_p): New function.
5786         (pascal_language_defn): Initialise new field.
5787         * rust-lang.c (rust_is_string_type_p): New function.
5788         (rust_language_defn): Initialise new field.
5789
5790 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5791
5792         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5793         New field.
5794         * ada-lang.c (ada_language_defn): Initialise new field.
5795         * c-lang.c (c_language_defn): Likewise.
5796         (cplus_language_defn): Likewise.
5797         (asm_language_defn): Likewise.
5798         (minimal_language_defn): Likewise.
5799         * d-lang.c (d_language_defn): Likewise.
5800         * f-lang.c (f_language_defn): Likewise.
5801         * go-lang.c (go_language_defn): Likewise.
5802         * language.c (unknown_language_defn): Likewise.
5803         (auto_language_defn): Likewise.
5804         * m2-lang.c (m2_language_defn): Likewise.
5805         * objc-lang.c (objc_language_defn): Likewise.
5806         * opencl-lang.c (opencl_language_defn): Likewise.
5807         * p-lang.c (pascal_language_defn): Likewise.
5808         * rust-lang.c (rust_language_defn): Likewise.
5809
5810 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5811
5812         * ada-lang.c (ada_is_character_type): Change return type to bool.
5813         (ada_is_string_type): Likewise.
5814         * ada-lang.h (ada_is_character_type): Update declaration
5815         (ada_is_string_type): Likewise.
5816
5817 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5818
5819         Support style in 'frame|thread apply'
5820
5821         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5822         * record.c (record_start, record_stop): Update callers of
5823         execute_command_to_string with false.
5824         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5825         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5826         methods.
5827         (class string_file): New constructor with term_out parameter.
5828         Override methods term_out and can_emit_style_escape.  New member
5829         term_out.
5830         (class stdio_file): Override can_emit_style_escape.
5831         (class tee_file): Override term_out and can_emit_style_escape.
5832         * utils.h (can_emit_style_escape): Remove.
5833         * utils.c (can_emit_style_escape): Likewise.
5834         Update all callers of can_emit_style_escape (SOMESTREAM) to
5835         SOMESTREAM->can_emit_style_escape.
5836         * source-cache.c (source_cache::get_source_lines): Likewise.
5837         * stack.c (frame_apply_command_count): Call execute_command_to_string
5838         passing the term_out characteristic of the current gdb_stdout.
5839         * thread.c (thr_try_catch_cmd): Likewise.
5840         * top.c (execute_command_to_string): pass term_out parameter
5841         to construct the string_file for the command output.
5842         * ui-file.c (term_cli_styling): New function (most code moved
5843         from utils.c can_emit_style_escape).
5844         (string_file::string_file, string_file::can_emit_style_escape,
5845         stdio_file::can_emit_style_escape, tee_file::term_out,
5846         tee_file::can_emit_style_escape): New functions.
5847
5848 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5849
5850         * NEWS: Mention the new set|show may-call-functions.
5851         * infcall.c (may_call_functions_p): New variable.
5852         (show_may_call_functions_p): New function.
5853         (call_function_by_hand_dummy): Throws an error if not
5854         may-call-functions.
5855         (_initialize_infcall): Call add_setshow_boolean_cmd for
5856         may-call-functions.
5857
5858 2019-04-25  Keith Seitz  <keiths@redhat.com>
5859
5860         PR c++/24367
5861         * cp-support.c (inspect_type): Don't attempt substitutions
5862         of symbol with the same name.
5863
5864 2019-04-25  Tom Tromey  <tromey@adacore.com>
5865
5866         PR gdb/24475:
5867         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5868         static.
5869
5870 2019-04-25  Tom Tromey  <tromey@adacore.com>
5871
5872         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5873         rvalue reference.
5874         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5875         (gdb_xml_parser::parse): Use std::move.
5876         * python/python-internal.h (gdbpy_convert_exception): Take a const
5877         reference.
5878         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5879         std::move.
5880         * python/py-utils.c (gdbpy_convert_exception): Take a const
5881         reference.
5882         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5883         Use std::move.
5884         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5885         Use std::move.
5886         * mi/mi-main.c (mi_print_exception): Take a const reference.
5887         * main.c (handle_command_errors): Take a const reference.
5888         * linespec.c (parse_linespec): Use std::move.
5889         * infcall.c (run_inferior_call): Use std::move.
5890         (call_function_by_hand_dummy): Use std::move.
5891         * exec.c (try_open_exec_file): Use std::move.
5892         * exceptions.h (exception_print, exception_fprintf)
5893         (exception_print_same): Update.
5894         * exceptions.c (print_exception, exception_print)
5895         (exception_fprintf, exception_print_same): Change parameters to
5896         const reference.
5897         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5898         * common/new-op.c: Use std::move.
5899         * common/common-exceptions.h (struct gdb_exception): Add move
5900         constructor.
5901         (struct gdb_exception_error, struct gdb_exception_quit, struct
5902         gdb_quit_bad_alloc): Change constructor to move constructor.
5903         (throw_exception): Change parameter to rvalue reference.
5904         * common/common-exceptions.c (throw_exception): Take rvalue
5905         reference.
5906         * cli/cli-interp.c (safe_execute_command): Use std::move.
5907         * breakpoint.c (insert_bp_location, location_to_sals): Use
5908         std::move.
5909
5910 2019-04-25  Tom Tromey  <tromey@adacore.com>
5911
5912         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5913         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5914         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5915         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5916         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5917         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5918         guile/scm-value.c: Use unpack.
5919         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5920         gdbscm_gdb_exception.
5921         (gdbscm_throw_gdb_exception): Likewise.
5922         (struct gdbscm_gdb_exception): New.
5923         (unpack): New function.
5924         (gdbscm_wrap): Use unpack.
5925
5926 2019-04-25  Tom Tromey  <tromey@adacore.com>
5927
5928         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5929         (gdb_rl_callback_handler): Use std::move.
5930         * common/common-exceptions.h (struct gdb_exception): Add move
5931         assignment operator.
5932         (throw_exception_sjlj): Change "exception" to const reference.
5933         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5934         (throw_exception_sjlj): Change "exception" to const reference.
5935
5936 2019-04-25  Tom Tromey  <tromey@adacore.com>
5937
5938         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5939         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5940         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5941         Update.
5942         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5943         Update.
5944         * mi/mi-interp.c (mi_interp::exec): Update.
5945         * linespec.c (parse_linespec): Update.
5946         * infcall.c (run_inferior_call): Update.
5947         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5948         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5949         (gdbscm_lookup_global_symbol): Update.
5950         * guile/scm-param.c (gdbscm_parameter_value): Update.
5951         * guile/scm-frame.c (gdbscm_frame_read_register)
5952         (gdbscm_frame_read_var): Update.
5953         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5954         * exec.c (try_open_exec_file): Update.
5955         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5956         (gdb_rl_callback_handler): Update.
5957         * common/common-exceptions.h (exception_none): Don't declare.
5958         * common/common-exceptions.c (exception_none): Don't define.
5959         (struct catcher) <exception>: Update.
5960         * cli/cli-interp.c (safe_execute_command): Update.
5961         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5962
5963 2019-04-25  Ali Tamur  <tamur@google.com>
5964
5965         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5966         (read_attribute_value): Likewise.
5967         (dwarf2_read_addr_index): Update comment.
5968         (read_str_index): Add DW_FORM_strx.
5969         (dwarf2_string_attr): Likewise.
5970         (dwarf2_const_value_attr): Likewise.
5971         (dump_die_shallow): Likewise.
5972         (dwarf2_fetch_constant_bytes): Likewise.
5973         (skip_form_bytes): Likewise.
5974         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5975
5976 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5977
5978         PR corefiles/11608
5979         PR corefiles/18187
5980         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5981         OFFSET.  Verify if current mapping contains an ELF header.
5982         (linux_find_memory_regions_full): Adjust call to
5983         dump_mapping_p.
5984
5985 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5986             Kang Li <kanglictf@gmail.com>
5987
5988         PR gdb/21600
5989
5990         * dwarf2-frame.c (read_initial_length): Be consistent about using
5991         unsigned representation of length.
5992         (decode_frame_entry_1): Likewise.  Check for wraparound of
5993         end pointer as well as buffer overflow.
5994
5995 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5996
5997         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5998         "vq".
5999
6000 2019-04-24  Tom Tromey  <tromey@adacore.com>
6001
6002         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6003
6004 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6005
6006         * s12z-tdep.c (s12z_unwind_pc): Delete.
6007         (s12z_unwind_sp): Delete.
6008         (s12z_gdbarch_init): Don't register deleted functions with
6009         gdbarch.
6010
6011 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6012
6013         * rl78-tdep.c (rl78_unwind_sp): Delete.
6014         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6015
6016 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6017
6018         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6019         (xstormy16_unwind_pc): Delete.
6020         (xstormy16_dummy_id): Delete.
6021         (xstormy16_gdbarch_init): Don't register deleted functions with
6022         gdbarch.
6023
6024 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6025
6026         * vax-tdep.c (vax_unwind_pc): Delete.
6027         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6028
6029 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6030
6031         * v850-tdep.c (v850_unwind_sp): Delete.
6032         (v850_unwind_pc): Delete.
6033         (v850_dummy_id): Delete.
6034         (v850_gdbarch_init): Don't register deleted functions with
6035         gdbarch.
6036
6037 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6038
6039         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6040         (tilegx_unwind_pc): Delete.
6041         (tilegx_unwind_dummy_id): Delete.
6042         (tilegx_gdbarch_init): Don't register deleted functions with
6043         gdbarch.
6044
6045 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6046
6047         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6048         (tic6x_dummy_id): Delete.
6049         (tic6x_gdbarch_init): Don't register deleted functions with
6050         gdbarch.
6051
6052 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6053
6054         * sparc-tdep.c (sparc_unwind_pc): Delete.
6055         (sparc32_gdbarch_init): Don't register deleted function with
6056         gdbarch.
6057
6058 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6059
6060         * sh-tdep.c (sh_unwind_sp): Delete.
6061         (sh_unwind_pc): Delete.
6062         (sh_dummy_id): Delete.
6063         (sh_gdbarch_init): Don't register deleted functions with
6064         gdbarch.
6065
6066 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6067
6068         * score-tdep.c (score_unwind_sp): Delete.
6069         (score_unwind_pc): Delete.
6070         (score_dummy_id): Delete.
6071         (score_gdbarch_init): Don't register deleted functions with
6072         gdbarch.
6073
6074 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6075
6076         * rx-tdep.c (rx_unwind_pc): Delete.
6077         (rx_unwind_sp): Delete.
6078         (rx_dummy_id): Delete.
6079         (rx_gdbarch_init): Don't register deleted functions with
6080         gdbarch.  Update comment.
6081
6082 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6083
6084         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6085         (rs6000_dummy_id): Delete.
6086         (rs6000_gdbarch_init): Don't register deleted functions with
6087         gdbarch.
6088
6089 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6090
6091         * or1k-tdep.c (or1k_dummy_id): Delete.
6092         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6093
6094 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6095
6096         * nios2-tdep.c (nios2_dummy_id): Delete.
6097         (nios2_unwind_sp): Delete.
6098         (nios2_gdbarch_init): Don't register deleted functions with
6099         gdbarch.
6100
6101 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6102
6103         * nds32-tdep.c (nds32_dummy_id): Delete.
6104         (nds32_unwind_pc): Delete.
6105         (nds32_unwind_sp): Delete.
6106         (nds32_gdbarch_init): Don't register deleted functions with
6107         gdbarch.
6108
6109 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6110
6111         * msp430-tdep.c (msp430_unwind_pc): Delete.
6112         (msp430_unwind_sp): Delete.
6113         (msp430_dummy_id): Delete.
6114         (msp430_gdbarch_init): Don't register deleted functions with
6115         gdbarch.
6116
6117 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6118
6119         * moxie-tdep.c (moxie_unwind_sp): Delete.
6120         (moxie_unwind_pc): Delete.
6121         (moxie_dummy_id): Delete.
6122         (moxie_gdbarch_init): Don't register deleted functions with
6123         gdbarch.
6124
6125 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6126
6127         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6128         (mn10300_unwind_pc): Delete.
6129         (mn10300_unwind_sp): Delete.
6130         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6131         mn10300_unwind_sp.
6132         (mn10300_frame_unwind_init): Don't register deleted functions with
6133         gdbarch.
6134
6135 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6136
6137         * mep-tdep.c (mep_unwind_pc): Delete.
6138         (mep_unwind_sp): Delete.
6139         (mep_dummy_id): Delete.
6140         (mep_gdbarch_init): Don't register deleted functions with
6141         gdbarch.
6142
6143 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6144
6145         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6146         (m68hc11_unwind_sp): Delete.
6147         (m68hc11_gdbarch_init): Don't register deleted functions with
6148         gdbarch.
6149
6150 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6151
6152         * m32r-tdep.c (m32r_unwind_sp): Delete.
6153         (m32r_unwind_pc): Delete.
6154         (m32r_dummy_id): Delete.
6155         (m32r_gdbarch_init): Don't register deleted functions with
6156         gdbarch.
6157
6158 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6159
6160         * m32c-tdep.c (m32c_unwind_pc): Delete.
6161         (m32c_unwind_sp): Delete.
6162         (m32c_dummy_id): Delete.
6163         (m32c_gdbarch_init): Don't register deleted functions with
6164         gdbarch.
6165
6166 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6167
6168         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6169         (lm32_unwind_pc): Delete.
6170         (lm32_dummy_id): Delete.
6171         (lm32_gdbarch_init): Don't register deleted functions with
6172         gdbarch.
6173
6174 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6175
6176         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6177         (iq2000_unwind_pc): Delete.
6178         (iq2000_dummy_id): Delete.
6179         (iq2000_gdbarch_init): Don't register deleted functions with
6180         gdbarch.
6181
6182 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6183
6184         * nds32-tdep.c (nds32_type_align): Delete.
6185         (nds32_push_dummy_call): Use type_align instead.
6186
6187 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6188
6189         * arm-tdep.c (arm_type_align): Only handle vector override case.
6190         (arm_push_dummy_call): Use type_align.
6191         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6192
6193 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6194
6195         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6196         case.
6197         (pass_on_stack): Use type_align.
6198         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6199         function.
6200
6201 2019-04-23  Tom Tromey  <tromey@adacore.com>
6202
6203         * dwarf2read.c (line_header::file_name_at): Remove unused
6204         overload.
6205
6206 2019-04-23  Tom de Vries  <tdevries@suse.de>
6207
6208         PR gdb/24438
6209         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6210         invocation.
6211
6212
6213 2019-03-27  Ali Tamur  <tamur@google.com>
6214
6215         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6216         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6217         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6218         (dwarf_expr_context::get_addr_index): Likewise
6219         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6220         (symbol_needs_eval_context::get_addr_index): Likewise
6221         (disassemble_dwarf_expression): Add DW_OP_addrx
6222         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6223         (read_cutu_die_from_dwo): Update comment
6224         (skip_one_die): Add DW_FORM_addrx
6225         (read_attribute_value): Likewise
6226         (var_decode_location): Add DW_OP_addrx
6227         (dwarf2_const_value_attr): Add DW_FORM_addrx
6228         (dump_die_shallow): Likewise
6229         (dwarf2_fetch_constant_bytes): Likewise
6230         (decode_locdesc): Add DW_OP_addrx
6231         (skip_form_bytes): Add DW_FORM_addrx
6232
6233 2019-04-22  Ali Tamur  <tamur@google.com>
6234
6235         * MAINTAINERS (Write After Approval): Add self.
6236
6237 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6238
6239         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6240         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6241         (open_symbol_file_object): Likewise.
6242         (svr4_default_sos): Add info parameter.
6243         (svr4_read_so_list): Likewise.
6244         (svr4_current_sos_direct): Adjust functions calls to pass down
6245         info.
6246         (svr4_current_sos_1): Add info parameter.
6247         (svr4_current_sos): Call get_svr4_info, pass info down to
6248         svr4_current_sos_1.
6249         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6250         get_svr4_info.
6251         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6252         get_svr4_info.
6253         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6254         to get_svr4_info.
6255         (probes_table_remove_objfile_probes): Likewise.
6256         (register_solib_event_probe): Add info parameter.
6257         (solist_update_incremental): Pass info parameter down to
6258         svr4_read_so_list.
6259         (disable_probes_interface): Add info parameter.
6260         (svr4_handle_solib_event): Pass current_program_space to
6261         get_svr4_info.  Adjust disable_probes_interface cleanup.
6262         (svr4_create_probe_breakpoints): Add info parameter, pass it
6263         down to register_solib_event_probe.
6264         (svr4_create_solib_event_breakpoints): Add info parameter,
6265         pass it down to svr4_create_probe_breakpoints.
6266         (enable_break): Pass info down to
6267         svr4_create_solib_event_breakpoints.
6268         (svr4_solib_create_inferior_hook): Pass current_program_space to
6269         get_svr4_info.
6270         (svr4_clear_solib): Likewise.
6271
6272 2019-04-22  Pedro Alves  <palves@redhat.com>
6273
6274         * solib-svr4.c (svr4_free_objfile_observer): New.
6275         (probe_and_action::objfile): New field.
6276         (probes_table_htab_remove_objfile_probes)
6277         (probes_table_remove_objfile_probes): New functions.
6278         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6279         in the new probe_and_action.  Don't store the probe in 'lookup'.
6280         (svr4_create_probe_breakpoints): Pass objfile to
6281         register_solib_event_probe.
6282         (_initialize_svr4_solib): Register a free_objfile observer.
6283
6284 2019-04-19  Tom Tromey  <tom@tromey.com>
6285
6286         * common/queue.h: Remove.
6287
6288 2019-04-19  Tom Tromey  <tom@tromey.com>
6289
6290         * event-loop.c: Don't include "common/queue.h".
6291
6292 2019-04-19  Tom Tromey  <tom@tromey.com>
6293
6294         * remote.c (remote_target): Use delete.
6295         * remote-notif.h: Include <list>, not "common/queue.h".
6296         (notif_client_p): Remove typedef.
6297         (remote_notif_state): Add constructor, destructor, initializer.
6298         <notif_queue>: Now a std::list.
6299         (remote_notif_state_xfree): Don't declare.
6300         * remote-notif.c (remote_notif_process, handle_notification)
6301         (remote_notif_state_allocate): Update.
6302         (~remote_notif_state): Rename from remote_notif_state_xfree.
6303
6304 2019-04-19  Tom Tromey  <tom@tromey.com>
6305
6306         * symfile.c (reread_symbols): Update.
6307         * objfiles.c (objfile_register_static_link)
6308         (objfile_lookup_static_link): Update
6309         (~objfile) Don't delete static_links.
6310         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6311
6312 2019-04-19  Tom Tromey  <tom@tromey.com>
6313
6314         * type-stack.h (struct type_stack) <insert>: Constify string.
6315         * type-stack.c (type_stack::insert): Constify string.
6316         * gdbtypes.h (lookup_template_type): Update.
6317         (address_space_name_to_int): Update.
6318         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6319         const.
6320         (lookup_template_type): Make name const.
6321         * c-exp.y: Update rules.
6322         (lex_one_token, classify_name, classify_inner_name)
6323         (c_print_token): Update.
6324         * p-exp.y: Update rules.
6325         (yylex): Update.
6326         * f-exp.y: Update rules.
6327         (yylex): Update.
6328         * d-exp.y: Update rules.
6329         (lex_one_token, classify_name, classify_inner_name): Update.
6330         * parse.c (write_dollar_variable, copy_name): Return std::string.
6331         * parser-defs.h (copy_name): Change return type.
6332         * m2-exp.y: Update rules.
6333         (yylex): Update.
6334         * go-exp.y (lex_one_token): Update.
6335         Update rules.
6336         (classify_unsafe_function, classify_packaged_name)
6337         (classify_name, yylex): Update.
6338
6339 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6340
6341         * configure.ac: add --enable-source-highlight switch.
6342         * configure: Regenerate.
6343         * top.c (print_gdb_version): plumb --enable-source-highlight
6344         status to "show configuration".
6345
6346 2019-04-19  Tom Tromey  <tromey@adacore.com>
6347
6348         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6349         Check ADA_TYPE_P.
6350         (empty_record, ada_template_to_fixed_record_type_1)
6351         (template_to_static_fixed_type)
6352         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6353         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6354         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6355         macros.
6356
6357 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6358
6359         PR symtab/24423:
6360         * source.c (print_source_lines_base): Advance "iter" when a
6361         control character is seen.
6362
6363 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6364
6365         * inferior.h (struct infcall_suspend_state_deleter):
6366         Catch exception in destructor to avoid crash.
6367
6368 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6369
6370         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6371         close to the add_com "shell".
6372
6373 2019-04-18  Tom Tromey  <tromey@adacore.com>
6374
6375         * process-stratum-target.h (class process_stratum_target)
6376         <stratum>: Add "final".
6377
6378 2019-04-17  Tom Tromey  <tromey@adacore.com>
6379
6380         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6381         against nullptr before use.
6382
6383 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6384
6385         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6386
6387 2019-04-17  Jim Wilson  <jimw@sifive.com>
6388             Andrew Burgess  <andrew.burgess@embecosm.com>
6389
6390         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6391         code read might fail, assume 4-byte breakpoint in that case.
6392
6393 2019-04-15  Leszek Swirski  <leszeks@google.com>
6394
6395         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6396         rather than a hand-rolled POD check when checking for forced MEMORY
6397         classification.
6398
6399 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6400
6401         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6402         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6403         function.
6404         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6405         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6406         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6407         declaration.
6408
6409 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6410
6411         * aarch64-linux-nat.c
6412         (aarch64_linux_nat_target::thread_architecture): Add override.
6413         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6414         each VQ.
6415
6416 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6417
6418         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6419
6420 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6421
6422         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6423         target types of size 96-bits, add some additional comments, and
6424         check that the builtin type we found was the correct size.
6425
6426 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6427
6428         * utils.c (prompt_for_continue): Don't restore the styling at the
6429         end, as applied_style has the wrong value.  This fixes styling in
6430         long lists of file names that are interrupted by the "Continue?"
6431         prompt.
6432
6433 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6434
6435         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6436         * c-lang.c (c_language_defn): Likewise.
6437         (cplus_language_defn): Likewise.
6438         (asm_language_defn): Likewise.
6439         (minimal_language_defn): Likewise.
6440         * d-lang.c (d_language_defn): Likewise.
6441         * f-lang.c (f_language_defn): Likewise.
6442         * go-lang.c (go_language_defn): Likewise.
6443         * language.c (unknown_language_defn): Likewise.
6444         (auto_language_defn): Likewise.
6445         * language.h (struct language_defn): Remove la_magic field.
6446         (LANG_MAGIC): Delete.
6447         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6448         * objc-lang.c (objc_language_defn): Likewise.
6449         * opencl-lang.c (opencl_language_defn): Likewise.
6450         * p-lang.c (pascal_language_defn): Likewise.
6451         * rust-lang.c (rust_language_defn): Likewise.
6452
6453 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6454
6455         * riscv-tdep.c (riscv_type_align): New function.
6456         (riscv_type_alignment): Delete.
6457         (riscv_arg_location): Use 'type_align'.
6458         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6459
6460 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6461
6462         * gdbtypes.c (type_align): A struct with no non-static fields also
6463         has alignment of 1.
6464
6465 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6466
6467         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6468         component to 0.
6469         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6470         member.
6471         (riscv_struct_info::analyse): New implementation using new
6472         analyse_inner member function.
6473         (riscv_struct_info::field_offset): New member function.
6474         (riscv_struct_info::m_offsets): New member variable.
6475         (riscv_struct_info::analyse_inner): New private member function,
6476         takes the old implementation of riscv_struct_info::analyse but
6477         extended to track field offsets.
6478         (riscv_call_arg_struct): Update the struct folding special cases
6479         to handle cases where empty C++ structs, which are non-zero
6480         length, are found.
6481         (riscv_arg_location): Initialise the length of each location, a
6482         non-zero length now indicates the location is in use.
6483         (riscv_push_dummy_call): Allow for the first location having a
6484         non-zero offset when setting up arguments.
6485         (riscv_return_value): Likewise, but for return values.
6486
6487 2019-04-11  Tom Tromey  <tromey@adacore.com>
6488
6489         * utils.c (internal_vproblem): Make "msg" const.
6490
6491 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6492
6493         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6494         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6495         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6496         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6497
6498 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6499
6500         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6501         function.
6502         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6503         of amd64_collect_native_gregset.
6504         (amd64_linux_nat_target::store_registers): Likewise.
6505
6506 2019-04-10  Tom Tromey  <tom@tromey.com>
6507
6508         * symtab.c (lookup_global_symbol_from_objfile)
6509         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6510         * objfiles.h (class separate_debug_iterator): New.
6511         (class separate_debug_range): New.
6512         (struct objfile) <separate_debug_objfiles>: New method.
6513         (objfile_separate_debug_iterate): Don't declare.
6514         * objfiles.c (separate_debug_iterator::operator++): Rename from
6515         objfile_separate_debug_iterate.
6516         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6517         iterator.
6518         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6519         iterator.
6520
6521 2019-04-10  Tom Tromey  <tom@tromey.com>
6522
6523         * symfile.c (reread_symbols): Remove old comment.
6524         * objfiles.c (free_all_objfiles): Fix a typo.
6525
6526 2019-04-10  Tom Tromey  <tom@tromey.com>
6527
6528         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6529         * minsyms.c (lookup_minimal_symbol): Use foreach.
6530         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6531         (lookup_minimal_symbol_solib_trampoline): Likewise.
6532         * symfile.c (reread_symbols): Use foreach.
6533
6534 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6535             Tom Tromey  <tromey@adacore.com>
6536
6537         PR rust/24414:
6538         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6539         (rust_lex_int_test): Change "value" to be LONGEST.
6540         (rust_lex_tests): Add test for long integer literal.
6541
6542 2019-04-09  Tom Tromey  <tromey@adacore.com>
6543
6544         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6545         to bool.
6546         (extended_remote_target::attach): Update.
6547         (remote_target::remote_notice_new_inferior): Update.
6548         (remote_target::add_current_inferior_and_thread): Update.
6549         * inferior.c (exit_inferior_1): Use "false".
6550         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6551
6552 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6553
6554         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6555         the "start" command.
6556
6557 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6558
6559         * python/py-inferior.c (infpy_thread_from_thread_handle):
6560         Adjust comments to reflect renaming of thread_from_thread_handle
6561         to thread_from_handle.  Adjust keywords.  Fix type error message.
6562         (inferior_object_methods): Add thread_from_handle.  Retain
6563         thread_from_thread_handle, but mark it as deprecated.
6564
6565 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6566
6567         * gdbthread.h (find_thread_by_handle): Revise declaration.
6568         * thread.c (find_thread_by_handle): Likewise.  Adjust
6569         implementation too.
6570         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6571         support for buffer objects as handles.
6572
6573 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6574
6575         * python/py-infthread.c (thpy_thread_handle): New function.
6576         (thread_object_methods): Register thpy_thread_handle.
6577
6578 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6579
6580         * gdbthread.h (thread_to_thread_handle): Declare.
6581         * thread.c (gdbtypes.h): Include.
6582         (thread_to_thread_handle): New function.
6583
6584         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6585         (target_thread_info_to_thread_handle): Declare.
6586         * target.c (target_thread_info_to_thread_handle): New function.
6587         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6588         * target-delegates.c: Regenerate.
6589
6590         * linux-thread-db.c (class thread_db_target): Add method
6591         thread_info_to_thread_handle.
6592         (thread_db_target::thread_info_to_thread_handle): Define.
6593         * remote.c (class remote_target): Add new method
6594         thread_info_to_thread_handle.
6595         (remote_target::thread_info_to_thread_handle): Define.
6596
6597 2019-04-08  Pedro Alves  <palves@redhat.com>
6598
6599         * common/common-exceptions.c (throw_exception): Don't create
6600         named object to throw; throw directly.
6601         (throw_it): Likewise.  Don't initialize gdb_exception::message
6602         here, with new; pass FMT and AP to the ctor instead.
6603         * common/common-exceptions.h: Include <string>.
6604         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6605         const char *, va_list)): New ctor.  Use std::make_shared.
6606         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6607         errors)): Delete.
6608         (gdb_exception_error::gdb_exception_error(enum errors, const char
6609         *, va_list)): New.
6610         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6611         Add assertion.
6612         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6613         errors)): Delete.
6614         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6615         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6616         Add assertion.
6617
6618 2019-04-08  Tom Tromey  <tom@tromey.com>
6619
6620         * valops.c (value_rtti_indirect_type): Replace throw_exception
6621         with throw.
6622         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6623         with throw.
6624         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6625         throw.
6626         * target.c (target_translate_tls_address): Replace throw_exception
6627         with throw.
6628         * stack.c (frame_apply_command_count): Replace throw_exception
6629         with throw.
6630         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6631         throw.
6632         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6633         with throw.
6634         * rs6000-tdep.c (rs6000_frame_cache)
6635         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6636         * remote.c: Replace throw_exception with throw.
6637         * record-full.c (record_full_message, record_full_wait_1)
6638         (record_full_restore): Replace throw_exception with throw.
6639         * record-btrace.c:
6640         (get_thread_current_frame_id, record_btrace_start_replaying)
6641         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6642         (cmd_record_btrace_start): Replace throw_exception with throw.
6643         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6644         throw.
6645         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6646         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6647         * linespec.c:
6648         (find_linespec_symbols): Replace throw_exception with throw.
6649         * infrun.c (displaced_step_prepare, resume): Replace
6650         throw_exception with throw.
6651         * infcmd.c (post_create_inferior): Replace throw_exception with
6652         throw.
6653         * inf-loop.c (inferior_event_handler): Replace throw_exception
6654         with throw.
6655         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6656         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6657         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6658         (get_prev_frame_always, get_frame_pc_if_available)
6659         (get_frame_address_in_block_if_available, get_frame_language):
6660         Replace throw_exception with throw.
6661         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6662         throw_exception with throw.
6663         * eval.c (fetch_subexp_value, evaluate_var_value)
6664         (evaluate_funcall, evaluate_subexp_standard): Replace
6665         throw_exception with throw.
6666         * dwarf2loc.c (call_site_find_chain)
6667         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6668         Replace throw_exception with throw.
6669         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6670         with throw.
6671         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6672         throw.
6673         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6674         * completer.c (complete_line_internal): Replace throw_exception
6675         with throw.
6676         * compile/compile-object-run.c (compile_object_run): Replace
6677         throw_exception with throw.
6678         * cli/cli-script.c (process_next_line): Replace throw_exception
6679         with throw.
6680         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6681         (btrace_enable, btrace_maint_update_pt_packets): Replace
6682         throw_exception with throw.
6683         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6684         throw_exception with throw.
6685         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6686         throw_exception with throw.
6687         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6688         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6689         * aarch64-tdep.c (aarch64_make_prologue_cache)
6690         (aarch64_make_stub_cache): Replace throw_exception with throw.
6691
6692 2019-04-08  Tom Tromey  <tom@tromey.com>
6693
6694         * common/common-exceptions.c (throw_exception): Rename from
6695         throw_exception_cxx.  Remove old copy.  Make argument const.
6696         (throw_it): Create and throw exception objects directly.
6697         * common/common-exceptions.h (throw_exception): Make argument
6698         const.
6699         (struct gdb_exception_error): Add constructor.
6700         (struct gdb_exception_quit): Add constructor.
6701
6702 2019-04-08  Tom Tromey  <tom@tromey.com>
6703
6704         * common/common-exceptions.h (exception_rethrow): Don't declare.
6705         (TRY_SJLJ): Update comment.
6706         (TRY, CATCH, END_CATCH): Remove.
6707         * common/common-exceptions.c (exception_rethrow): Remove.
6708
6709 2019-04-08  Tom Tromey  <tom@tromey.com>
6710
6711         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6712         Remove.
6713         (gdb_exception_error): Rename from
6714         gdb_exception_RETURN_MASK_ERROR.
6715         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6716         (gdb_quit_bad_alloc): Update.
6717         * aarch64-tdep.c: Update.
6718         * ada-lang.c: Update.
6719         * ada-typeprint.c: Update.
6720         * ada-valprint.c: Update.
6721         * amd64-tdep.c: Update.
6722         * arch-utils.c: Update.
6723         * break-catch-throw.c: Update.
6724         * breakpoint.c: Update.
6725         * btrace.c: Update.
6726         * c-varobj.c: Update.
6727         * cli/cli-cmds.c: Update.
6728         * cli/cli-interp.c: Update.
6729         * cli/cli-script.c: Update.
6730         * common/common-exceptions.c: Update.
6731         * common/new-op.c: Update.
6732         * common/selftest.c: Update.
6733         * compile/compile-c-symbols.c: Update.
6734         * compile/compile-cplus-symbols.c: Update.
6735         * compile/compile-object-load.c: Update.
6736         * compile/compile-object-run.c: Update.
6737         * completer.c: Update.
6738         * corelow.c: Update.
6739         * cp-abi.c: Update.
6740         * cp-support.c: Update.
6741         * cp-valprint.c: Update.
6742         * darwin-nat.c: Update.
6743         * disasm-selftests.c: Update.
6744         * dtrace-probe.c: Update.
6745         * dwarf-index-cache.c: Update.
6746         * dwarf-index-write.c: Update.
6747         * dwarf2-frame-tailcall.c: Update.
6748         * dwarf2-frame.c: Update.
6749         * dwarf2loc.c: Update.
6750         * dwarf2read.c: Update.
6751         * eval.c: Update.
6752         * event-loop.c: Update.
6753         * event-top.c: Update.
6754         * exec.c: Update.
6755         * f-valprint.c: Update.
6756         * fbsd-tdep.c: Update.
6757         * frame-unwind.c: Update.
6758         * frame.c: Update.
6759         * gdbtypes.c: Update.
6760         * gnu-v3-abi.c: Update.
6761         * guile/guile-internal.h: Update.
6762         * guile/scm-block.c: Update.
6763         * guile/scm-breakpoint.c: Update.
6764         * guile/scm-cmd.c: Update.
6765         * guile/scm-disasm.c: Update.
6766         * guile/scm-frame.c: Update.
6767         * guile/scm-lazy-string.c: Update.
6768         * guile/scm-math.c: Update.
6769         * guile/scm-param.c: Update.
6770         * guile/scm-ports.c: Update.
6771         * guile/scm-pretty-print.c: Update.
6772         * guile/scm-symbol.c: Update.
6773         * guile/scm-symtab.c: Update.
6774         * guile/scm-type.c: Update.
6775         * guile/scm-value.c: Update.
6776         * i386-linux-tdep.c: Update.
6777         * i386-tdep.c: Update.
6778         * inf-loop.c: Update.
6779         * infcall.c: Update.
6780         * infcmd.c: Update.
6781         * infrun.c: Update.
6782         * jit.c: Update.
6783         * language.c: Update.
6784         * linespec.c: Update.
6785         * linux-fork.c: Update.
6786         * linux-nat.c: Update.
6787         * linux-tdep.c: Update.
6788         * linux-thread-db.c: Update.
6789         * main.c: Update.
6790         * mi/mi-cmd-break.c: Update.
6791         * mi/mi-cmd-stack.c: Update.
6792         * mi/mi-interp.c: Update.
6793         * mi/mi-main.c: Update.
6794         * objc-lang.c: Update.
6795         * p-valprint.c: Update.
6796         * parse.c: Update.
6797         * ppc-linux-tdep.c: Update.
6798         * printcmd.c: Update.
6799         * python/py-arch.c: Update.
6800         * python/py-breakpoint.c: Update.
6801         * python/py-cmd.c: Update.
6802         * python/py-finishbreakpoint.c: Update.
6803         * python/py-frame.c: Update.
6804         * python/py-framefilter.c: Update.
6805         * python/py-gdb-readline.c: Update.
6806         * python/py-inferior.c: Update.
6807         * python/py-infthread.c: Update.
6808         * python/py-lazy-string.c: Update.
6809         * python/py-linetable.c: Update.
6810         * python/py-objfile.c: Update.
6811         * python/py-param.c: Update.
6812         * python/py-prettyprint.c: Update.
6813         * python/py-progspace.c: Update.
6814         * python/py-record-btrace.c: Update.
6815         * python/py-record.c: Update.
6816         * python/py-symbol.c: Update.
6817         * python/py-type.c: Update.
6818         * python/py-unwind.c: Update.
6819         * python/py-utils.c: Update.
6820         * python/py-value.c: Update.
6821         * python/python.c: Update.
6822         * record-btrace.c: Update.
6823         * record-full.c: Update.
6824         * remote-fileio.c: Update.
6825         * remote.c: Update.
6826         * riscv-tdep.c: Update.
6827         * rs6000-aix-tdep.c: Update.
6828         * rs6000-tdep.c: Update.
6829         * rust-exp.y: Update.
6830         * rust-lang.c: Update.
6831         * s390-tdep.c: Update.
6832         * selftest-arch.c: Update.
6833         * solib-dsbt.c: Update.
6834         * solib-frv.c: Update.
6835         * solib-spu.c: Update.
6836         * solib-svr4.c: Update.
6837         * solib.c: Update.
6838         * sparc64-linux-tdep.c: Update.
6839         * stack.c: Update.
6840         * symfile-mem.c: Update.
6841         * symmisc.c: Update.
6842         * target.c: Update.
6843         * thread.c: Update.
6844         * top.c: Update.
6845         * tracefile-tfile.c: Update.
6846         * tui/tui.c: Update.
6847         * typeprint.c: Update.
6848         * unittests/cli-utils-selftests.c: Update.
6849         * unittests/parse-connection-spec-selftests.c: Update.
6850         * valops.c: Update.
6851         * valprint.c: Update.
6852         * value.c: Update.
6853         * varobj.c: Update.
6854         * windows-nat.c: Update.
6855         * x86-linux-nat.c: Update.
6856         * xml-support.c: Update.
6857
6858 2019-04-08  Tom Tromey  <tom@tromey.com>
6859
6860         * xml-support.c: Use C++ exception handling.
6861         * x86-linux-nat.c: Use C++ exception handling.
6862         * windows-nat.c: Use C++ exception handling.
6863         * varobj.c: Use C++ exception handling.
6864         * value.c: Use C++ exception handling.
6865         * valprint.c: Use C++ exception handling.
6866         * valops.c: Use C++ exception handling.
6867         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6868         handling.
6869         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6870         * typeprint.c: Use C++ exception handling.
6871         * tui/tui.c: Use C++ exception handling.
6872         * tracefile-tfile.c: Use C++ exception handling.
6873         * top.c: Use C++ exception handling.
6874         * thread.c: Use C++ exception handling.
6875         * target.c: Use C++ exception handling.
6876         * symmisc.c: Use C++ exception handling.
6877         * symfile-mem.c: Use C++ exception handling.
6878         * stack.c: Use C++ exception handling.
6879         * sparc64-linux-tdep.c: Use C++ exception handling.
6880         * solib.c: Use C++ exception handling.
6881         * solib-svr4.c: Use C++ exception handling.
6882         * solib-spu.c: Use C++ exception handling.
6883         * solib-frv.c: Use C++ exception handling.
6884         * solib-dsbt.c: Use C++ exception handling.
6885         * selftest-arch.c: Use C++ exception handling.
6886         * s390-tdep.c: Use C++ exception handling.
6887         * rust-lang.c: Use C++ exception handling.
6888         * rust-exp.y: Use C++ exception handling.
6889         * rs6000-tdep.c: Use C++ exception handling.
6890         * rs6000-aix-tdep.c: Use C++ exception handling.
6891         * riscv-tdep.c: Use C++ exception handling.
6892         * remote.c: Use C++ exception handling.
6893         * remote-fileio.c: Use C++ exception handling.
6894         * record-full.c: Use C++ exception handling.
6895         * record-btrace.c: Use C++ exception handling.
6896         * python/python.c: Use C++ exception handling.
6897         * python/py-value.c: Use C++ exception handling.
6898         * python/py-utils.c: Use C++ exception handling.
6899         * python/py-unwind.c: Use C++ exception handling.
6900         * python/py-type.c: Use C++ exception handling.
6901         * python/py-symbol.c: Use C++ exception handling.
6902         * python/py-record.c: Use C++ exception handling.
6903         * python/py-record-btrace.c: Use C++ exception handling.
6904         * python/py-progspace.c: Use C++ exception handling.
6905         * python/py-prettyprint.c: Use C++ exception handling.
6906         * python/py-param.c: Use C++ exception handling.
6907         * python/py-objfile.c: Use C++ exception handling.
6908         * python/py-linetable.c: Use C++ exception handling.
6909         * python/py-lazy-string.c: Use C++ exception handling.
6910         * python/py-infthread.c: Use C++ exception handling.
6911         * python/py-inferior.c: Use C++ exception handling.
6912         * python/py-gdb-readline.c: Use C++ exception handling.
6913         * python/py-framefilter.c: Use C++ exception handling.
6914         * python/py-frame.c: Use C++ exception handling.
6915         * python/py-finishbreakpoint.c: Use C++ exception handling.
6916         * python/py-cmd.c: Use C++ exception handling.
6917         * python/py-breakpoint.c: Use C++ exception handling.
6918         * python/py-arch.c: Use C++ exception handling.
6919         * printcmd.c: Use C++ exception handling.
6920         * ppc-linux-tdep.c: Use C++ exception handling.
6921         * parse.c: Use C++ exception handling.
6922         * p-valprint.c: Use C++ exception handling.
6923         * objc-lang.c: Use C++ exception handling.
6924         * mi/mi-main.c: Use C++ exception handling.
6925         * mi/mi-interp.c: Use C++ exception handling.
6926         * mi/mi-cmd-stack.c: Use C++ exception handling.
6927         * mi/mi-cmd-break.c: Use C++ exception handling.
6928         * main.c: Use C++ exception handling.
6929         * linux-thread-db.c: Use C++ exception handling.
6930         * linux-tdep.c: Use C++ exception handling.
6931         * linux-nat.c: Use C++ exception handling.
6932         * linux-fork.c: Use C++ exception handling.
6933         * linespec.c: Use C++ exception handling.
6934         * language.c: Use C++ exception handling.
6935         * jit.c: Use C++ exception handling.
6936         * infrun.c: Use C++ exception handling.
6937         * infcmd.c: Use C++ exception handling.
6938         * infcall.c: Use C++ exception handling.
6939         * inf-loop.c: Use C++ exception handling.
6940         * i386-tdep.c: Use C++ exception handling.
6941         * i386-linux-tdep.c: Use C++ exception handling.
6942         * guile/scm-value.c: Use C++ exception handling.
6943         * guile/scm-type.c: Use C++ exception handling.
6944         * guile/scm-symtab.c: Use C++ exception handling.
6945         * guile/scm-symbol.c: Use C++ exception handling.
6946         * guile/scm-pretty-print.c: Use C++ exception handling.
6947         * guile/scm-ports.c: Use C++ exception handling.
6948         * guile/scm-param.c: Use C++ exception handling.
6949         * guile/scm-math.c: Use C++ exception handling.
6950         * guile/scm-lazy-string.c: Use C++ exception handling.
6951         * guile/scm-frame.c: Use C++ exception handling.
6952         * guile/scm-disasm.c: Use C++ exception handling.
6953         * guile/scm-cmd.c: Use C++ exception handling.
6954         * guile/scm-breakpoint.c: Use C++ exception handling.
6955         * guile/scm-block.c: Use C++ exception handling.
6956         * guile/guile-internal.h: Use C++ exception handling.
6957         * gnu-v3-abi.c: Use C++ exception handling.
6958         * gdbtypes.c: Use C++ exception handling.
6959         * frame.c: Use C++ exception handling.
6960         * frame-unwind.c: Use C++ exception handling.
6961         * fbsd-tdep.c: Use C++ exception handling.
6962         * f-valprint.c: Use C++ exception handling.
6963         * exec.c: Use C++ exception handling.
6964         * event-top.c: Use C++ exception handling.
6965         * event-loop.c: Use C++ exception handling.
6966         * eval.c: Use C++ exception handling.
6967         * dwarf2read.c: Use C++ exception handling.
6968         * dwarf2loc.c: Use C++ exception handling.
6969         * dwarf2-frame.c: Use C++ exception handling.
6970         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6971         * dwarf-index-write.c: Use C++ exception handling.
6972         * dwarf-index-cache.c: Use C++ exception handling.
6973         * dtrace-probe.c: Use C++ exception handling.
6974         * disasm-selftests.c: Use C++ exception handling.
6975         * darwin-nat.c: Use C++ exception handling.
6976         * cp-valprint.c: Use C++ exception handling.
6977         * cp-support.c: Use C++ exception handling.
6978         * cp-abi.c: Use C++ exception handling.
6979         * corelow.c: Use C++ exception handling.
6980         * completer.c: Use C++ exception handling.
6981         * compile/compile-object-run.c: Use C++ exception handling.
6982         * compile/compile-object-load.c: Use C++ exception handling.
6983         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6984         * compile/compile-c-symbols.c: Use C++ exception handling.
6985         * common/selftest.c: Use C++ exception handling.
6986         * common/new-op.c: Use C++ exception handling.
6987         * cli/cli-script.c: Use C++ exception handling.
6988         * cli/cli-interp.c: Use C++ exception handling.
6989         * cli/cli-cmds.c: Use C++ exception handling.
6990         * c-varobj.c: Use C++ exception handling.
6991         * btrace.c: Use C++ exception handling.
6992         * breakpoint.c: Use C++ exception handling.
6993         * break-catch-throw.c: Use C++ exception handling.
6994         * arch-utils.c: Use C++ exception handling.
6995         * amd64-tdep.c: Use C++ exception handling.
6996         * ada-valprint.c: Use C++ exception handling.
6997         * ada-typeprint.c: Use C++ exception handling.
6998         * ada-lang.c: Use C++ exception handling.
6999         * aarch64-tdep.c: Use C++ exception handling.
7000
7001 2019-04-08  Tom Tromey  <tom@tromey.com>
7002
7003         * xml-support.c (gdb_xml_parser::parse): Update.
7004         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7005         * value.c (show_convenience): Update.
7006         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7007         (test_parse_flags_qcs): Update.
7008         * thread.c (thr_try_catch_cmd): Update.
7009         * target.c (target_translate_tls_address): Update.
7010         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7011         (info_frame_command_core, frame_apply_command_count): Update.
7012         * rust-exp.y (rust_lex_exception_test): Update.
7013         * riscv-tdep.c (riscv_print_one_register_info): Update.
7014         * remote.c (remote_target::enable_btrace): Update.
7015         * record-btrace.c (record_btrace_enable_warn): Update.
7016         * python/py-utils.c (gdbpy_convert_exception): Update.
7017         * printcmd.c (do_one_display, print_variable_and_value): Update.
7018         * mi/mi-main.c (mi_print_exception): Update.
7019         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7020         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7021         * linux-nat.c (linux_nat_target::attach): Update.
7022         * linux-fork.c (class scoped_switch_fork_info): Update.
7023         * infrun.c (displaced_step_prepare): Update.
7024         * infcall.c (call_function_by_hand_dummy): Update.
7025         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7026         * gnu-v3-abi.c (print_one_vtable): Update.
7027         * frame.c (get_prev_frame_always): Update.
7028         * f-valprint.c (info_common_command_for_block): Update.
7029         * exec.c (try_open_exec_file): Update.
7030         * exceptions.c (print_exception, exception_print)
7031         (exception_fprintf, exception_print_same): Update.
7032         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7033         * dwarf-index-cache.c (index_cache::store)
7034         (index_cache::lookup_gdb_index): Update.
7035         * darwin-nat.c (maybe_cache_shell): Update.
7036         * cp-valprint.c (cp_print_value_fields): Update.
7037         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7038         (gcc_cplus_symbol_address): Update.
7039         * compile/compile-c-symbols.c (gcc_convert_symbol)
7040         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7041         * common/selftest.c: Update.
7042         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7043         a std::string.
7044         (exception_try_scope_entry, exception_try_scope_exit): Don't
7045         declare.
7046         (struct exception_try_scope): Remove.
7047         (TRY): Don't use exception_try_scope.
7048         (struct gdb_exception): Add constructor, operator=.
7049         <what>: New method.
7050         (struct gdb_exception_RETURN_MASK_ALL)
7051         (struct gdb_exception_RETURN_MASK_ERROR)
7052         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7053         (struct gdb_quit_bad_alloc): Update.
7054         * common/common-exceptions.c (exception_none): Change
7055         initializer.
7056         (struct catcher) <state, exception>: Initialize inline.
7057         <prev>: Remove member.
7058         (current_catcher): Remove.
7059         (catchers): New global.
7060         (exceptions_state_mc_init): Simplify.
7061         (catcher_pop): Remove.
7062         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7063         (try_scope_depth, exception_try_scope_entry)
7064         (exception_try_scope_exit): Remove.
7065         (throw_exception_sjlj): Update.
7066         (exception_messages, exception_messages_size): Remove.
7067         (throw_it): Simplify.
7068         (gdb_exception_sliced_copy): Remove.
7069         (throw_exception_cxx): Update.
7070         * cli/cli-script.c (script_from_file): Update.
7071         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7072         Update.
7073         * ada-valprint.c (ada_val_print): Update.
7074         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7075         (create_excep_cond_exprs): Update.
7076
7077 2019-04-08  Tom Tromey  <tom@tromey.com>
7078
7079         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7080         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7081         (TRY, CATCH, END_CATCH): Remove some definitions.
7082         * common/common-exceptions.c: Don't use GDB_XCPT.
7083         (catcher_list_size): Remove.
7084         (throw_exception, throw_it): Simplify.
7085
7086 2019-04-05  Tom Tromey  <tom@tromey.com>
7087
7088         Revert the header-sorting patch.
7089         * ft32-tdep.c: Revert.
7090         * frv-tdep.c: Revert.
7091         * frv-linux-tdep.c: Revert.
7092         * frame.c: Revert.
7093         * frame-unwind.c: Revert.
7094         * frame-base.c: Revert.
7095         * fork-child.c: Revert.
7096         * findvar.c: Revert.
7097         * findcmd.c: Revert.
7098         * filesystem.c: Revert.
7099         * filename-seen-cache.h: Revert.
7100         * filename-seen-cache.c: Revert.
7101         * fbsd-tdep.c: Revert.
7102         * fbsd-nat.h: Revert.
7103         * fbsd-nat.c: Revert.
7104         * f-valprint.c: Revert.
7105         * f-typeprint.c: Revert.
7106         * f-lang.c: Revert.
7107         * extension.h: Revert.
7108         * extension.c: Revert.
7109         * extension-priv.h: Revert.
7110         * expprint.c: Revert.
7111         * exec.h: Revert.
7112         * exec.c: Revert.
7113         * exceptions.c: Revert.
7114         * event-top.c: Revert.
7115         * event-loop.c: Revert.
7116         * eval.c: Revert.
7117         * elfread.c: Revert.
7118         * dwarf2read.h: Revert.
7119         * dwarf2read.c: Revert.
7120         * dwarf2loc.c: Revert.
7121         * dwarf2expr.h: Revert.
7122         * dwarf2expr.c: Revert.
7123         * dwarf2-frame.c: Revert.
7124         * dwarf2-frame-tailcall.c: Revert.
7125         * dwarf-index-write.h: Revert.
7126         * dwarf-index-write.c: Revert.
7127         * dwarf-index-common.c: Revert.
7128         * dwarf-index-cache.h: Revert.
7129         * dwarf-index-cache.c: Revert.
7130         * dummy-frame.c: Revert.
7131         * dtrace-probe.c: Revert.
7132         * disasm.h: Revert.
7133         * disasm.c: Revert.
7134         * disasm-selftests.c: Revert.
7135         * dictionary.c: Revert.
7136         * dicos-tdep.c: Revert.
7137         * demangle.c: Revert.
7138         * dcache.h: Revert.
7139         * dcache.c: Revert.
7140         * darwin-nat.h: Revert.
7141         * darwin-nat.c: Revert.
7142         * darwin-nat-info.c: Revert.
7143         * d-valprint.c: Revert.
7144         * d-namespace.c: Revert.
7145         * d-lang.c: Revert.
7146         * ctf.c: Revert.
7147         * csky-tdep.c: Revert.
7148         * csky-linux-tdep.c: Revert.
7149         * cris-tdep.c: Revert.
7150         * cris-linux-tdep.c: Revert.
7151         * cp-valprint.c: Revert.
7152         * cp-support.c: Revert.
7153         * cp-namespace.c: Revert.
7154         * cp-abi.c: Revert.
7155         * corelow.c: Revert.
7156         * corefile.c: Revert.
7157         * continuations.c: Revert.
7158         * completer.h: Revert.
7159         * completer.c: Revert.
7160         * complaints.c: Revert.
7161         * coffread.c: Revert.
7162         * coff-pe-read.c: Revert.
7163         * cli-out.h: Revert.
7164         * cli-out.c: Revert.
7165         * charset.c: Revert.
7166         * c-varobj.c: Revert.
7167         * c-valprint.c: Revert.
7168         * c-typeprint.c: Revert.
7169         * c-lang.c: Revert.
7170         * buildsym.c: Revert.
7171         * buildsym-legacy.c: Revert.
7172         * build-id.h: Revert.
7173         * build-id.c: Revert.
7174         * btrace.c: Revert.
7175         * bsd-uthread.c: Revert.
7176         * breakpoint.h: Revert.
7177         * breakpoint.c: Revert.
7178         * break-catch-throw.c: Revert.
7179         * break-catch-syscall.c: Revert.
7180         * break-catch-sig.c: Revert.
7181         * blockframe.c: Revert.
7182         * block.c: Revert.
7183         * bfin-tdep.c: Revert.
7184         * bfin-linux-tdep.c: Revert.
7185         * bfd-target.c: Revert.
7186         * bcache.c: Revert.
7187         * ax-general.c: Revert.
7188         * ax-gdb.h: Revert.
7189         * ax-gdb.c: Revert.
7190         * avr-tdep.c: Revert.
7191         * auxv.c: Revert.
7192         * auto-load.c: Revert.
7193         * arm-wince-tdep.c: Revert.
7194         * arm-tdep.c: Revert.
7195         * arm-symbian-tdep.c: Revert.
7196         * arm-pikeos-tdep.c: Revert.
7197         * arm-obsd-tdep.c: Revert.
7198         * arm-nbsd-tdep.c: Revert.
7199         * arm-nbsd-nat.c: Revert.
7200         * arm-linux-tdep.c: Revert.
7201         * arm-linux-nat.c: Revert.
7202         * arm-fbsd-tdep.c: Revert.
7203         * arm-fbsd-nat.c: Revert.
7204         * arm-bsd-tdep.c: Revert.
7205         * arch-utils.c: Revert.
7206         * arc-tdep.c: Revert.
7207         * arc-newlib-tdep.c: Revert.
7208         * annotate.h: Revert.
7209         * annotate.c: Revert.
7210         * amd64-windows-tdep.c: Revert.
7211         * amd64-windows-nat.c: Revert.
7212         * amd64-tdep.c: Revert.
7213         * amd64-sol2-tdep.c: Revert.
7214         * amd64-obsd-tdep.c: Revert.
7215         * amd64-obsd-nat.c: Revert.
7216         * amd64-nbsd-tdep.c: Revert.
7217         * amd64-nbsd-nat.c: Revert.
7218         * amd64-nat.c: Revert.
7219         * amd64-linux-tdep.c: Revert.
7220         * amd64-linux-nat.c: Revert.
7221         * amd64-fbsd-tdep.c: Revert.
7222         * amd64-fbsd-nat.c: Revert.
7223         * amd64-dicos-tdep.c: Revert.
7224         * amd64-darwin-tdep.c: Revert.
7225         * amd64-bsd-nat.c: Revert.
7226         * alpha-tdep.c: Revert.
7227         * alpha-obsd-tdep.c: Revert.
7228         * alpha-nbsd-tdep.c: Revert.
7229         * alpha-mdebug-tdep.c: Revert.
7230         * alpha-linux-tdep.c: Revert.
7231         * alpha-linux-nat.c: Revert.
7232         * alpha-bsd-tdep.c: Revert.
7233         * alpha-bsd-nat.c: Revert.
7234         * aix-thread.c: Revert.
7235         * agent.c: Revert.
7236         * addrmap.c: Revert.
7237         * ada-varobj.c: Revert.
7238         * ada-valprint.c: Revert.
7239         * ada-typeprint.c: Revert.
7240         * ada-tasks.c: Revert.
7241         * ada-lang.c: Revert.
7242         * aarch64-tdep.c: Revert.
7243         * aarch64-ravenscar-thread.c: Revert.
7244         * aarch64-newlib-tdep.c: Revert.
7245         * aarch64-linux-tdep.c: Revert.
7246         * aarch64-linux-nat.c: Revert.
7247         * aarch64-fbsd-tdep.c: Revert.
7248         * aarch64-fbsd-nat.c: Revert.
7249         * aarch32-linux-nat.c: Revert.
7250
7251 2019-04-05  Tom Tromey  <tom@tromey.com>
7252
7253         * ft32-tdep.c: Sort headers.
7254         * frv-tdep.c: Sort headers.
7255         * frv-linux-tdep.c: Sort headers.
7256         * frame.c: Sort headers.
7257         * frame-unwind.c: Sort headers.
7258         * frame-base.c: Sort headers.
7259         * fork-child.c: Sort headers.
7260         * findvar.c: Sort headers.
7261         * findcmd.c: Sort headers.
7262         * filesystem.c: Sort headers.
7263         * filename-seen-cache.h: Sort headers.
7264         * filename-seen-cache.c: Sort headers.
7265         * fbsd-tdep.c: Sort headers.
7266         * fbsd-nat.h: Sort headers.
7267         * fbsd-nat.c: Sort headers.
7268         * f-valprint.c: Sort headers.
7269         * f-typeprint.c: Sort headers.
7270         * f-lang.c: Sort headers.
7271         * extension.h: Sort headers.
7272         * extension.c: Sort headers.
7273         * extension-priv.h: Sort headers.
7274         * expprint.c: Sort headers.
7275         * exec.h: Sort headers.
7276         * exec.c: Sort headers.
7277         * exceptions.c: Sort headers.
7278         * event-top.c: Sort headers.
7279         * event-loop.c: Sort headers.
7280         * eval.c: Sort headers.
7281         * elfread.c: Sort headers.
7282         * dwarf2read.h: Sort headers.
7283         * dwarf2read.c: Sort headers.
7284         * dwarf2loc.c: Sort headers.
7285         * dwarf2expr.h: Sort headers.
7286         * dwarf2expr.c: Sort headers.
7287         * dwarf2-frame.c: Sort headers.
7288         * dwarf2-frame-tailcall.c: Sort headers.
7289         * dwarf-index-write.h: Sort headers.
7290         * dwarf-index-write.c: Sort headers.
7291         * dwarf-index-common.c: Sort headers.
7292         * dwarf-index-cache.h: Sort headers.
7293         * dwarf-index-cache.c: Sort headers.
7294         * dummy-frame.c: Sort headers.
7295         * dtrace-probe.c: Sort headers.
7296         * disasm.h: Sort headers.
7297         * disasm.c: Sort headers.
7298         * disasm-selftests.c: Sort headers.
7299         * dictionary.c: Sort headers.
7300         * dicos-tdep.c: Sort headers.
7301         * demangle.c: Sort headers.
7302         * dcache.h: Sort headers.
7303         * dcache.c: Sort headers.
7304         * darwin-nat.h: Sort headers.
7305         * darwin-nat.c: Sort headers.
7306         * darwin-nat-info.c: Sort headers.
7307         * d-valprint.c: Sort headers.
7308         * d-namespace.c: Sort headers.
7309         * d-lang.c: Sort headers.
7310         * ctf.c: Sort headers.
7311         * csky-tdep.c: Sort headers.
7312         * csky-linux-tdep.c: Sort headers.
7313         * cris-tdep.c: Sort headers.
7314         * cris-linux-tdep.c: Sort headers.
7315         * cp-valprint.c: Sort headers.
7316         * cp-support.c: Sort headers.
7317         * cp-namespace.c: Sort headers.
7318         * cp-abi.c: Sort headers.
7319         * corelow.c: Sort headers.
7320         * corefile.c: Sort headers.
7321         * continuations.c: Sort headers.
7322         * completer.h: Sort headers.
7323         * completer.c: Sort headers.
7324         * complaints.c: Sort headers.
7325         * coffread.c: Sort headers.
7326         * coff-pe-read.c: Sort headers.
7327         * cli-out.h: Sort headers.
7328         * cli-out.c: Sort headers.
7329         * charset.c: Sort headers.
7330         * c-varobj.c: Sort headers.
7331         * c-valprint.c: Sort headers.
7332         * c-typeprint.c: Sort headers.
7333         * c-lang.c: Sort headers.
7334         * buildsym.c: Sort headers.
7335         * buildsym-legacy.c: Sort headers.
7336         * build-id.h: Sort headers.
7337         * build-id.c: Sort headers.
7338         * btrace.c: Sort headers.
7339         * bsd-uthread.c: Sort headers.
7340         * breakpoint.h: Sort headers.
7341         * breakpoint.c: Sort headers.
7342         * break-catch-throw.c: Sort headers.
7343         * break-catch-syscall.c: Sort headers.
7344         * break-catch-sig.c: Sort headers.
7345         * blockframe.c: Sort headers.
7346         * block.c: Sort headers.
7347         * bfin-tdep.c: Sort headers.
7348         * bfin-linux-tdep.c: Sort headers.
7349         * bfd-target.c: Sort headers.
7350         * bcache.c: Sort headers.
7351         * ax-general.c: Sort headers.
7352         * ax-gdb.h: Sort headers.
7353         * ax-gdb.c: Sort headers.
7354         * avr-tdep.c: Sort headers.
7355         * auxv.c: Sort headers.
7356         * auto-load.c: Sort headers.
7357         * arm-wince-tdep.c: Sort headers.
7358         * arm-tdep.c: Sort headers.
7359         * arm-symbian-tdep.c: Sort headers.
7360         * arm-pikeos-tdep.c: Sort headers.
7361         * arm-obsd-tdep.c: Sort headers.
7362         * arm-nbsd-tdep.c: Sort headers.
7363         * arm-nbsd-nat.c: Sort headers.
7364         * arm-linux-tdep.c: Sort headers.
7365         * arm-linux-nat.c: Sort headers.
7366         * arm-fbsd-tdep.c: Sort headers.
7367         * arm-fbsd-nat.c: Sort headers.
7368         * arm-bsd-tdep.c: Sort headers.
7369         * arch-utils.c: Sort headers.
7370         * arc-tdep.c: Sort headers.
7371         * arc-newlib-tdep.c: Sort headers.
7372         * annotate.h: Sort headers.
7373         * annotate.c: Sort headers.
7374         * amd64-windows-tdep.c: Sort headers.
7375         * amd64-windows-nat.c: Sort headers.
7376         * amd64-tdep.c: Sort headers.
7377         * amd64-sol2-tdep.c: Sort headers.
7378         * amd64-obsd-tdep.c: Sort headers.
7379         * amd64-obsd-nat.c: Sort headers.
7380         * amd64-nbsd-tdep.c: Sort headers.
7381         * amd64-nbsd-nat.c: Sort headers.
7382         * amd64-nat.c: Sort headers.
7383         * amd64-linux-tdep.c: Sort headers.
7384         * amd64-linux-nat.c: Sort headers.
7385         * amd64-fbsd-tdep.c: Sort headers.
7386         * amd64-fbsd-nat.c: Sort headers.
7387         * amd64-dicos-tdep.c: Sort headers.
7388         * amd64-darwin-tdep.c: Sort headers.
7389         * amd64-bsd-nat.c: Sort headers.
7390         * alpha-tdep.c: Sort headers.
7391         * alpha-obsd-tdep.c: Sort headers.
7392         * alpha-nbsd-tdep.c: Sort headers.
7393         * alpha-mdebug-tdep.c: Sort headers.
7394         * alpha-linux-tdep.c: Sort headers.
7395         * alpha-linux-nat.c: Sort headers.
7396         * alpha-bsd-tdep.c: Sort headers.
7397         * alpha-bsd-nat.c: Sort headers.
7398         * aix-thread.c: Sort headers.
7399         * agent.c: Sort headers.
7400         * addrmap.c: Sort headers.
7401         * ada-varobj.c: Sort headers.
7402         * ada-valprint.c: Sort headers.
7403         * ada-typeprint.c: Sort headers.
7404         * ada-tasks.c: Sort headers.
7405         * ada-lang.c: Sort headers.
7406         * aarch64-tdep.c: Sort headers.
7407         * aarch64-ravenscar-thread.c: Sort headers.
7408         * aarch64-newlib-tdep.c: Sort headers.
7409         * aarch64-linux-tdep.c: Sort headers.
7410         * aarch64-linux-nat.c: Sort headers.
7411         * aarch64-fbsd-tdep.c: Sort headers.
7412         * aarch64-fbsd-nat.c: Sort headers.
7413         * aarch32-linux-nat.c: Sort headers.
7414
7415 2019-04-04  Tom Tromey  <tom@tromey.com>
7416
7417         * varobj.c (varobj_create): Update.
7418         * rust-exp.y (struct rust_parser) <update_innermost_block,
7419         lookup_symbol>: New methods.
7420         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7421         Rename.
7422         (rust_parser::rust_lookup_type)
7423         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7424         * printcmd.c (display_command, do_one_display): Update.
7425         * parser-defs.h (struct parser_state) <parser_state>: Add
7426         "tracker" parameter.
7427         (block_tracker): New member.
7428         (class innermost_block_tracker) <innermost_block_tracker>: Add
7429         "types" parameter.
7430         <reset>: Remove method.
7431         (innermost_block): Don't declare.
7432         (null_post_parser): Update.
7433         * parse.c (innermost_block): Remove global.
7434         (write_dollar_variable): Update.
7435         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7436         Remove "tracker_types" parameter.
7437         (parse_expression): Add "tracker" parameter.
7438         (parse_expression_for_completion): Update.
7439         (null_post_parser): Add "tracker" parameter.
7440         * p-exp.y: Update rules.
7441         * m2-exp.y: Update rules.
7442         * language.h (struct language_defn) <la_post_parser>: Add
7443         "tracker" parameter.
7444         * go-exp.y: Update rules.
7445         * f-exp.y: Update rules.
7446         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7447         parameter.
7448         * d-exp.y: Update rules.
7449         * c-exp.y: Update rules.
7450         * breakpoint.c (set_breakpoint_condition): Create an
7451         innermost_block_tracker.
7452         (watch_command_1): Likewise.
7453         * ada-lang.c (resolve): Add "tracker" parameter.
7454         (resolve_subexp): Likewise.
7455         * ada-exp.y (write_var_from_sym): Update.
7456
7457 2019-04-04  Tom Tromey  <tom@tromey.com>
7458
7459         * type-stack.h: New file.
7460         * type-stack.c: New file.
7461         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7462         type-stack.h.
7463         (insert_into_type_stack, insert_type, push_type, push_type_int)
7464         (insert_type_address_space, pop_type, pop_type_int)
7465         (pop_typelist, pop_type_stack, append_type_stack)
7466         (push_type_stack, get_type_stack, push_typelist)
7467         (follow_type_instance_flags, follow_types): Don't declare.
7468         * parse.c (type_stack): Remove global.
7469         (parse_exp_in_context): Update.
7470         (insert_into_type_stack, insert_type, push_type, push_type_int)
7471         (insert_type_address_space, pop_type, pop_type_int)
7472         (pop_typelist, pop_type_stack, append_type_stack)
7473         (push_type_stack, get_type_stack, push_typelist)
7474         (follow_type_instance_flags, follow_types): Remove (moved to
7475         type-stack.c).
7476         * f-exp.y (type_stack): New global.
7477         Update rules.
7478         (push_kind_type, f_parse): Update.
7479         * d-exp.y (type_stack): New global.
7480         Update rules.
7481         (d_parse): Update.
7482         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7483         Update rules.
7484         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7485         (HFILES_NO_SRCDIR): Add type-stack.h.
7486
7487 2019-04-04  Tom Tromey  <tom@tromey.com>
7488
7489         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7490         (rust_parser::convert_ast_to_expression, rust_parse)
7491         (rust_lex_test_completion, rust_lex_tests): Update.
7492         * parser-defs.h (struct expr_completion_state): New.
7493         (struct parser_state) <parser_state>: Add completion parameter.
7494         <mark_struct_expression, mark_completion_tag>: New methods.
7495         <parse_completion, m_completion_state>: New members.
7496         (prefixify_expression, null_post_parser): Update.
7497         (mark_struct_expression, mark_completion_tag): Don't declare.
7498         * parse.c (parse_completion, expout_last_struct)
7499         (expout_tag_completion_type, expout_completion_name): Remove
7500         globals.
7501         (parser_state::mark_struct_expression)
7502         (parser_state::mark_completion_tag): Now methods.
7503         (prefixify_expression): Add last_struct parameter.
7504         (prefixify_subexp): Likewise.
7505         (parse_exp_1): Update.
7506         (parse_exp_in_context): Add cstate parameter.  Update.
7507         (parse_expression_for_completion): Create an
7508         expr_completion_state.
7509         (null_post_parser): Add "completion" parameter.
7510         * p-exp.y: Update rules.
7511         (yylex): Update.
7512         * language.h (struct language_defn) <la_post_parser>: Add
7513         "completing" parameter.
7514         * go-exp.y: Update rules.
7515         (lex_one_token): Update.
7516         * expression.h (parse_completion): Don't declare.
7517         * d-exp.y: Update rules.
7518         (lex_one_token): Update rules.
7519         * c-exp.y: Update rules.
7520         (lex_one_token): Update.
7521         * ada-lang.c (resolve): Add "parse_completion" parameter.
7522         (resolve_subexp): Likewise.
7523         (ada_resolve_function): Likewise.
7524
7525 2019-04-04  Tom Tromey  <tom@tromey.com>
7526
7527         * parser-defs.h (struct parser_state) <start_arglist,
7528         end_arglist>: New methods.
7529         <arglist_len, m_funcall_chain>: New members.
7530         (arglist_len, start_arglist, end_arglist): Don't declare.
7531         * parse.c (arglist_len, funcall_chain): Remove global.
7532         (start_arglist, end_arglist): Remove functions.
7533         (parse_exp_in_context): Update.
7534         * p-exp.y: Update rules.
7535         * m2-exp.y: Update rules.
7536         * go-exp.y: Update rules.
7537         * f-exp.y: Update rules.
7538         * d-exp.y: Update rules.
7539         * c-exp.y: Update rules.
7540
7541 2019-04-04  Tom Tromey  <tom@tromey.com>
7542
7543         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7544         lex_operator, push_back>: New methods.
7545         Update all rules.
7546         (rust_parser::lex_hex, lex_escape): Rename and update.
7547         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7548         (rust_parser::lex_operator): Rename and update.
7549         (rust_parser::lex_number, rustyylex, rustyyerror)
7550         (rust_lex_test_init, rust_lex_test_sequence)
7551         (rust_lex_test_push_back, rust_lex_tests): Update.
7552         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7553         parameter.
7554         <lexptr, prev_lexptr>: New members.
7555         (lexptr, prev_lexptr): Don't declare.
7556         * parse.c (lexptr, prev_lexptr): Remove globals.
7557         (parse_exp_in_context): Update.
7558         * p-exp.y (yylex, yyerror): Update.
7559         * m2-exp.y (parse_number, yylex, yyerror): Update.
7560         * go-exp.y (lex_one_token, yyerror): Update.
7561         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7562         * d-exp.y (lex_one_token, yyerror): Update.
7563         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7564         (lex_one_token, yyerror): Update.
7565         * ada-lex.l (YY_INPUT): Update.
7566         (rewind_to_char): Update.
7567         * ada-exp.y (yyerror): Update.
7568
7569 2019-04-04  Tom Tromey  <tom@tromey.com>
7570
7571         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7572         * parser-defs.h (struct parser_state) <parser_state>: Add new
7573         parameter.
7574         <comma_terminates>: New member.
7575         (comma_terminates): Don't declare global.
7576         * parse.c (comma_terminates): Remove global.
7577         (parse_exp_in_context): Update.
7578         * p-exp.y (yylex): Update.
7579         * m2-exp.y (yylex): Update.
7580         * go-exp.y (lex_one_token): Update.
7581         * f-exp.y (yylex): Update.
7582         * d-exp.y (lex_one_token): Update.
7583         * c-exp.y (lex_one_token): Update.
7584         * ada-lex.l: Update.
7585
7586 2019-04-04  Tom Tromey  <tom@tromey.com>
7587
7588         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7589         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7590         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7591         * parser-defs.h (paren_depth): Don't declare.
7592         * parse.c (paren_depth): Remove global.
7593         (parse_exp_in_context): Update.
7594         * p-exp.y (paren_depth): New global.
7595         (pascal_parse): Initialize it.
7596         * m2-exp.y (paren_depth): New global.
7597         (m2_parse): Initialize it.
7598         * go-exp.y (paren_depth): New global.
7599         (go_parse): Initialize it.
7600         * f-exp.y (paren_depth): New global.
7601         (f_parse): Initialize it.
7602         * d-exp.y (paren_depth): New global.
7603         (d_parse): Initialize it.
7604         * c-exp.y (paren_depth): New global.
7605         (c_parse): Initialize it.
7606         * ada-lex.l (paren_depth): New global.
7607         (lexer_init): Initialize it.
7608
7609 2019-04-04  Tom Tromey  <tom@tromey.com>
7610
7611         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7612         (rust_parser::convert_ast_to_type)
7613         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7614         * parser-defs.h (struct parser_state) <parser_state>: Add
7615         parameters.  Initialize new members.
7616         <expression_context_block, expression_context_pc>: New members.
7617         * parse.c (expression_context_block, expression_context_pc):
7618         Remove globals.
7619         (parse_exp_in_context): Update.
7620         * p-exp.y: Update all rules.
7621         (yylex): Update.
7622         * m2-exp.y: Update all rules.
7623         (yylex): Update.
7624         * go-exp.y (yylex): Update.
7625         * f-exp.y (yylex): Update.
7626         * d-exp.y: Update all rules.
7627         (yylex): Update.
7628         * c-exp.y: Update all rules.
7629         (lex_one_token, classify_name, yylex, c_parse): Update.
7630         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7631
7632 2019-04-04  Tom Tromey  <tom@tromey.com>
7633
7634         * gdbarch.h, gdbarch.c: Rebuild.
7635         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7636         * stap-probe.h:
7637         (struct stap_parse_info): Replace "parser_state" with
7638         "expr_builder".
7639         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7640         (parser_state): New class.
7641         * parse.c (expr_builder): Rename.
7642         (expr_builder::release): Rename.
7643         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7644         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7645         (write_exp_elt_longcst, write_exp_elt_floatcst)
7646         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7647         (write_exp_string_vector, write_exp_bitstring)
7648         (write_exp_msymbol, mark_struct_expression)
7649         (write_dollar_variable)
7650         (insert_type_address_space, increase_expout_size): Replace
7651         "parser_state" with "expr_builder".
7652         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7653         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7654         "parser_state" with "expr_builder".
7655
7656 2019-04-04  Tom Tromey  <tom@tromey.com>
7657
7658         * rust-exp.y: Replace "parse_language" with method call.
7659         * p-exp.y:
7660         (yylex): Replace "parse_language" with method call.
7661         * m2-exp.y:
7662         (yylex): Replace "parse_language" with method call.
7663         * go-exp.y (classify_name): Replace "parse_language" with method
7664         call.
7665         * f-exp.y (yylex): Replace "parse_language" with method call.
7666         * d-exp.y (lex_one_token): Replace "parse_language" with method
7667         call.
7668         * c-exp.y:
7669         (lex_one_token, classify_name, yylex): Replace "parse_language"
7670         with method call.
7671         * ada-exp.y (find_primitive_type, type_char)
7672         (type_system_address): Replace "parse_language" with method call.
7673
7674 2019-04-04  Tom Tromey  <tom@tromey.com>
7675
7676         * rust-exp.y: Replace "parse_gdbarch" with method call.
7677         * parse.c (write_dollar_variable, insert_type_address_space):
7678         Replace "parse_gdbarch" with method call.
7679         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7680         call.
7681         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7682         call.
7683         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7684         "parse_gdbarch" with method call.
7685         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7686         with method call.
7687         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7688         "parse_gdbarch" with method call.
7689         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7690         "parse_gdbarch" with method call.
7691         * c-exp.y (parse_type, parse_number, classify_name): Replace
7692         "parse_gdbarch" with method call.
7693         * ada-lex.l: Replace "parse_gdbarch" with method call.
7694         * ada-exp.y (parse_type, find_primitive_type, type_char)
7695         (type_system_address): Replace "parse_gdbarch" with method call.
7696
7697 2019-04-04  Tom Tromey  <tom@tromey.com>
7698
7699         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7700         * stap-probe.c (stap_parse_argument): Update.
7701         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7702         initial_size parameter.
7703         * rust-exp.y (rust_lex_tests): Update.
7704         * parse.c (parser_state): Update.
7705         (parse_exp_in_context): Update.
7706         * parser-defs.h (struct parser_state) <parser_state>: Remove
7707         "initial_size" parameter.
7708
7709 2019-04-04  Tom Tromey  <tom@tromey.com>
7710
7711         * parser-defs.h (increase_expout_size): Don't declare.
7712         * parse.c (increase_expout_size): Now static.
7713
7714 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7715
7716         * gnu-nat.c (gnu_nat_target::wait): Fix
7717         target_waitstatus_to_string call.
7718
7719 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7720
7721         * eval.c (evaluate_subexp_standard): Handle internal functions
7722         during Fortran function call handling.
7723
7724 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7725
7726         * NEWS: Mention new internal functions.
7727         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7728         (read_base_type): Use dwarf2_init_complex_target_type.
7729         * value.c (creal_internal_fn): New function.
7730         (cimag_internal_fn): New function.
7731         (_initialize_values): Register new internal functions.
7732
7733 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7734
7735         * infrun.c (stop_all_threads): If debug_infrun, always
7736         trace the wait status after wait_one, using
7737         target_waitstatus_to_string and target_pid_to_str.
7738         (handle_inferior_event): Replace various trace of
7739         wait status kind by a single trace.
7740         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7741         wait status kind image by target_waitstatus_to_string.
7742         * target/waitstatus.c (target_waitstatus_to_string): Fix
7743         obsolete comment.
7744
7745 2019-04-01  Tom Tromey  <tromey@adacore.com>
7746
7747         PR symtab/23331:
7748         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7749
7750 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7751             Pedro Alves  <palves@redhat.com>
7752
7753         * top.c (quit_force): Call 'finalize_values'.
7754         * value.c (finalize_values): New function.
7755         * value.h (finalize_values): Declare.
7756
7757 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7758
7759         * NEWS: Announce $_gdb_major and $_gdb_minor.
7760
7761         * top.c (init_gdb_version_vars): New function.
7762         (gdb_init): Call init_gdb_version_vars.
7763
7764 2019-03-29  Tom Tromey  <tromey@adacore.com>
7765
7766         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7767         help text.  Remove dead code.
7768
7769 2019-03-29  Keith Seitz  <keiths@redhat.com>
7770
7771         From Siddhesh Poyarekar:
7772         * f-lang.h (f77_get_upperbound): Return LONGEST.
7773         (f77_get_lowerbound): Likewise.
7774         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7775         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7776         print them.
7777         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7778         plongest to format print it.
7779         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7780         (f77_get_upperbound): Likewise.
7781         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7782         LOWER_BOUND to LONGEST.
7783         (f77_create_arrayprint_offset_tbl): Likewise.
7784
7785 2019-03-29  Keith Seitz  <keiths@redhat.com>
7786
7787         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7788         %s/pulongest for TYPE_LENGTH instead of %d in format
7789         strings.
7790         * ada-typerint.c (ada_print_type): Likewise.
7791         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7792         * compile/compile-c-support.c (generate_register_struct): Likewise.
7793         * gdbtypes.c (recursive_dump_type): Likewise.
7794         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7795         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7796         instead of %d in format strings.
7797         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7798         to std::min to ULONGEST.
7799         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7800         instead of %d in format strings.
7801         * tracepoint.c (info_scope_command): Likewise.
7802         * typeprint.c (print_offset_data::update)
7803         (print_offset_data::finish): Likewise.
7804         * xtensa-tdep.c (xtensa_store_return_value)
7805         (xtensa_push_dummy_call): Likewise.
7806
7807 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7808
7809         * windows-nat.c (display_selector): Fixed format specifications
7810         for 64-bit Cygwin.
7811
7812 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7813
7814         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7815
7816 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7817
7818         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7819         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7820         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7821         (nios2_linux_init_abi): Install it.
7822
7823 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7824
7825         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7826
7827 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7828
7829         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7830
7831 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7832             Tom Tromey  <tromey@adacore.com>
7833
7834         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7835
7836 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7837
7838         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7839         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7840         method to compute the bounds of range types. Also print "[evaluated]"
7841         if the bounds' values come from a dynamic evaluation.
7842
7843 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7844
7845         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7846         whitespace when pretty printing is on.
7847
7848 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7849
7850         * ppc-linux-nat.c: Add include.
7851
7852 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7853
7854         * NEWS: Mention AArch64 Pointer Authentication.
7855
7856 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7857
7858         * arm-linux-nat.c: Add include.
7859
7860 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7861
7862         * source-cache.c (source_cache::get_source_lines): Re-read
7863         fullname after calling open_source_file.
7864
7865 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7866
7867         * NEWS: Mention TLS support for FreeBSD.
7868
7869 2019-03-25  Tom Tromey  <tromey@adacore.com>
7870
7871         * minsyms.c (BUNCH_SIZE): Update comment.
7872         (~minimal_symbol_reader): Remove old comment.
7873         (compact_minimal_symbols): Update comment.
7874         (minimal_symbol_reader::install): Remove old comment.  Update
7875         other comments.
7876
7877 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7878
7879         * s390-linux-nat.c: Add include.
7880
7881 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7882
7883         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7884         Call linux_get_hwcap.
7885         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7886         Likewise.
7887         (aarch64_linux_get_hwcap): Remove function.
7888         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7889         declaration.
7890         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7891         linux_get_hwcap.
7892         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7893         * linux-tdep.c (linux_get_hwcap): Add function.
7894         (linux_get_hwcap2): Likewise.
7895         * linux-tdep.h (linux_get_hwcap): Add declaration.
7896         (linux_get_hwcap2): Likewise.
7897         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7898         (ppc_linux_get_hwcap2): Likewise.
7899         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7900         linux_get_hwcap.
7901         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7902         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7903         (ppc_linux_nat_target::read_description): Likewise.
7904         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7905         * s390-linux-nat.c: Likewise.
7906         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7907
7908 2019-03-24  Tom Tromey  <tom@tromey.com>
7909
7910         * ada-lang.c (standard_lookup): Simplify initialization.
7911         (ada_lookup_symbol_nonlocal): Simplify return.
7912         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7913         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7914         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7915         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7916         initialization.
7917         * solib.c (solib_global_lookup): Simplify.
7918         * symtab.c (null_block_symbol): Remove.
7919         (symbol_cache_lookup): Simplify returns.
7920         (lookup_language_this): Simplify returns.
7921         (lookup_symbol_aux): Simplify return.
7922         (lookup_local_symbol): Simplify returns.
7923         (lookup_global_symbol_from_objfile): Simplify return.
7924         (lookup_symbol_in_objfile_symtabs)
7925         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7926         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7927         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7928         * cp-namespace.c (cp_lookup_bare_symbol)
7929         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7930         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7931         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7932         (cp_lookup_symbol_via_imports): Simplify initialization.
7933         (find_symbol_in_baseclass): Likewise.
7934         * symtab.h (null_block_symbol): Remove.
7935         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7936         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7937         (d_lookup_symbol_module): Likewise.
7938         (find_symbol_in_baseclass): Simplify initialization.
7939
7940 2019-03-24  Tom Tromey  <tom@tromey.com>
7941
7942         * expression.h: Don't include symtab.h.
7943         (struct block): Forward declare.
7944
7945 2019-03-24  Tom Tromey  <tom@tromey.com>
7946
7947         * c-exp.y (typebase): Remove casts.
7948         * gdbtypes.c (lookup_unsigned_typename, )
7949         (lookup_signed_typename): Remove cast.
7950         * eval.c (parse_to_comma_and_eval): Remove cast.
7951         * parse.c (write_dollar_variable): Remove cast.
7952         * block.h (struct block) <superblock>: Now const.
7953         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7954         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7955         (map_block): Make "block" const.
7956         * symfile.h (struct quick_symbol_functions)
7957         <map_matching_symbols>: Constify block argument to "callback".
7958         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7959         const.
7960         (find_pc_sect_compunit_symtab): Make "b" const.
7961         (find_symbol_at_address): Likewise.
7962         (search_symbols): Likewise.
7963         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7964         (dw2_debug_names_lookup_symbol): Likewise.
7965         (dw2_map_matching_symbols): Update.
7966         * p-valprint.c (pascal_val_print): Remove "block".
7967         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7968         (aux_add_nonlocal_symbols): Make "block" const.
7969         (resolve_subexp): Remove cast.
7970         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7971         const.
7972         (iterate_over_file_blocks): Likewise.
7973         * f-exp.y (%union) <bval>: Remove.
7974         * coffread.c (patch_opaque_types): Make "b" const.
7975         * spu-tdep.c (spu_catch_start): Make "block" const.
7976         * c-valprint.c (print_unpacked_pointer): Remove "block".
7977         * symmisc.c (dump_symtab_1): Make "b" const.
7978         (block_depth): Make "block" const.
7979         * d-exp.y (%union) <bval>: Remove.
7980         * cp-support.h (cp_lookup_rtti_type): Update.
7981         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7982         * psymtab.c (psym_lookup_symbol): Make "block" const.
7983         (maintenance_check_psymtabs): Make "b" const.
7984         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7985         (enumerate_locals, enumerate_args): Update.
7986         * python/py-symtab.c (stpy_global_block): Make "block" const.
7987         (stpy_static_block): Likewise.
7988         * inline-frame.c (block_starting_point_at): Make "new_block"
7989         const.
7990         * block.c (find_block_in_blockvector): Make return type const.
7991         (blockvector_for_pc_sect): Make "b" const.
7992         (find_block_in_blockvector): Make "b" const.
7993
7994 2019-03-23  Tom Tromey  <tom@tromey.com>
7995
7996         * varobj.c (varobj_create): Update.
7997         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7998         * printcmd.c (display_command, do_one_display): Don't reset
7999         innermost_block.
8000         * parser-defs.h (enum innermost_block_tracker_type): Move to
8001         expression.h.
8002         (innermost_block): Update comment.
8003         * parse.c (parse_exp_1): Add tracker_types parameter.
8004         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8005         tracker_types parameter.  Reset innermost_block.
8006         (parse_exp_in_context): Remove.
8007         (parse_expression_for_completion): Update.
8008         * objfiles.c (~objfile): Don't reset expression_context_block or
8009         innermost_block.
8010         * expression.h (enum innermost_block_tracker_type): Move from
8011         parser-defs.h.
8012         (parse_exp_1): Add tracker_types parameter.
8013         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8014         reset innermost_block.
8015
8016 2019-03-23  Tom Tromey  <tom@tromey.com>
8017
8018         * objfiles.h: Include bcache.h.
8019
8020 2019-03-23  Tom Tromey  <tom@tromey.com>
8021
8022         * linespec.c (get_current_search_block): Use
8023         scoped_restore_current_language.
8024         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8025
8026 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8027             Jiong Wang  <jiong.wang@arm.com>
8028
8029         * aarch64-linux-tdep.c
8030         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8031         section.
8032         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8033
8034 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8035             Jiong Wang  <jiong.wang@arm.com>
8036
8037         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8038         instructions.
8039         (aarch64_analyze_prologue_test): Add PACIASP test.
8040         (aarch64_prologue_prev_register): Unmask PC value.
8041
8042 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8043             Jiong Wang  <jiong.wang@arm.com>
8044
8045         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8046         (aarch64_dwarf2_prev_register): Unmask PC value.
8047         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8048         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8049         DW_CFA_AARCH64_negate_ra_state.
8050         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8051
8052 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8053             Jiong Wang  <jiong.wang@arm.com>
8054
8055         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8056         registers.
8057         (aarch64_pseudo_register_name): Likewise.
8058         (aarch64_pseudo_register_type): Likewise.
8059         (aarch64_pseudo_register_reggroup_p): Likewise.
8060         (aarch64_gdbarch_init): Add pauth registers.
8061         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8062         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8063         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8064         (struct gdbarch_tdep): Add regnum for ra_state.
8065
8066 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8067             Jiong Wang  <jiong.wang@arm.com>
8068
8069         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8070
8071 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8072             Jiong Wang  <jiong.wang@arm.com>
8073
8074         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8075         function.
8076         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8077         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8078         (aarch64_gdbarch_init): Add puth registers.
8079         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8080         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8081         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8082
8083 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8084             Jiong Wang  <jiong.wang@arm.com>
8085
8086         * aarch64-linux-nat.c
8087         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8088         * aarch64-linux-tdep.c
8089         (aarch64_linux_core_read_description): Likewise.
8090         (aarch64_linux_get_hwcap): New function.
8091         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8092         (aarch64_linux_get_hwcap): New declaration.
8093
8094 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8095             Jiong Wang  <jiong.wang@arm.com>
8096
8097         * aarch64-linux-nat.c
8098         (aarch64_linux_nat_target::read_description): Add pauth param.
8099         * aarch64-linux-tdep.c
8100         (aarch64_linux_core_read_description): Likewise.
8101         * aarch64-tdep.c (struct target_desc): Add in pauth.
8102         (aarch64_read_description): Add pauth param.
8103         (aarch64_gdbarch_init): Likewise.
8104         * aarch64-tdep.h (aarch64_read_description): Likewise.
8105         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8106         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8107         * features/Makefile: Add new files.
8108         * features/aarch64-pauth.c: New file.
8109         * features/aarch64-pauth.xml: New file.
8110
8111 2019-03-20  Tom Tromey  <tromey@adacore.com>
8112
8113         * infrun.c (handle_inferior_event): Rename from
8114         handle_inferior_event_1.  Create a scoped_value_mark.
8115         (handle_inferior_event): Remove.
8116
8117 2019-03-19  Tom Tromey  <tromey@adacore.com>
8118
8119         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8120         * infrun.h (print_stop_event): Add "displays" parameter.
8121         * infrun.c (print_stop_event): Add "displays" parameter.
8122
8123 2019-03-19  Pedro Alves  <palves@redhat.com>
8124
8125         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8126         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8127         to -1.  Fix TABs vs spaces.
8128         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8129         * tui/tui-out.h (tui_ui_out) Add intro comments.
8130         <m_line, m_start_of_line>: In-class initialize, and add describing
8131         comment.
8132
8133 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8134
8135         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8136         variable names.
8137         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8138
8139 2019-03-18  Pedro Alves  <palves@redhat.com>
8140             Eli Zaretskii <eliz@gnu.org>
8141
8142         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8143         m_line and m_start_of_line.
8144
8145 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8146
8147         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8148         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8149         it returns a newline.  This fixes a regression in TU mode, whereby
8150         the next line is output on the same screen line as the user input.
8151
8152 2019-03-18  Tom Tromey  <tromey@adacore.com>
8153
8154         * minsyms.c (minimal_symbol_reader::install): Remove call to
8155         obstack_blank.
8156
8157 2019-03-18  Pedro Alves  <palves@redhat.com>
8158
8159         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8160         New globals.
8161         (apply_style): New, factored out from ...
8162         (apply_ansi_escape): ... this.  Handle reverse video mode.
8163         (tui_set_reverse_mode): New function.
8164         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8165         * tui/tui-winsource.c (tui_show_source_line): Use
8166         tui_set_reverse_mode instead of setting A_STANDOUT.
8167         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8168         New setter methods.
8169
8170 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8171
8172         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8173         Handle tabs.
8174
8175 2019-03-18  Tom Tromey  <tromey@adacore.com>
8176
8177         * ada-lang.c (empty_array): Add "high" parameter.
8178         (ada_evaluate_subexp): Update.
8179
8180 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8181
8182         * unittests/string_view-selftests.c: Define
8183         _initialize_string_view_selftests unconditionally.
8184
8185 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8186
8187         PR gdb/24350
8188         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8189
8190 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8191
8192         PR gdb/24351
8193         * windows-nat.c (display_selector): Fix format specifiers.
8194
8195 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8196
8197         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8198         tui_refill_source_window instead of tui_refresh_win, to update the
8199         current execution line.  This fixes redisplay of the current line
8200         when stepping through the code with "next" or "step".
8201
8202 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8203
8204         * source-cache.c (source_cache::get_source_lines): Call
8205         find_source_lines to initialize s->nlines.  This fixes vertical
8206         scrolling of TUI source window when the DOWN arrow is pressed.
8207
8208 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8209
8210         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8211         linux-thread-db.c (_initialize_thread_db): Likewise.
8212
8213 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8214
8215         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8216         wclrtoeol in tui_show_source_line".  This reverts changes made in
8217         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8218
8219 2019-03-15  Tom Tromey  <tom@tromey.com>
8220
8221         * symtab.h (struct minimal_symbol): Derive from
8222         general_symbol_info.
8223         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8224         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8225         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8226         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8227         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8228         (MSYMBOL_SEARCH_NAME): Update.
8229         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8230         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8231         * minsyms.c (minimal_symbol_reader::record_full): Update.
8232
8233 2019-03-15  Tom Tromey  <tom@tromey.com>
8234
8235         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8236
8237 2019-03-15  Tom Tromey  <tom@tromey.com>
8238
8239         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8240         unique_xmalloc_ptr.
8241         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8242         Update.
8243         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8244         (build_minimal_symbol_hash_tables)
8245         (minimal_symbol_reader::install): Update.
8246
8247 2019-03-15  Tom Tromey  <tom@tromey.com>
8248
8249         * symtab.c (create_demangled_names_hash): Update.
8250         (symbol_set_names): Update.
8251         * objfiles.h (struct objfile_per_bfd_storage)
8252         <demangled_names_hash>: Now an htab_up.
8253         * objfiles.c (objfile_per_bfd_storage): Simplify.
8254
8255 2019-03-15  Tom Tromey  <tom@tromey.com>
8256
8257         * objfiles.h (struct objfile_per_bfd_storage): Declare
8258         destructor.
8259         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8260         New.
8261         (get_objfile_bfd_data): Use new.  Don't initialize
8262         language_of_main.
8263         (free_objfile_per_bfd_storage): Remove.
8264         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8265
8266 2019-03-15  Tom Tromey  <tom@tromey.com>
8267
8268         * symfile.c (reread_symbols): Update.
8269         * objfiles.c (objfile::objfile): Update.
8270         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8271         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8272         comment.
8273         (minimal_symbol_reader::install): Update.
8274         (terminate_minimal_symbol_table): Remove.
8275         * jit.c (jit_object_close_impl): Update.
8276
8277 2019-03-15  Tom Tromey  <tom@tromey.com>
8278
8279         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8280         initializations.
8281
8282 2019-03-15  Tom Tromey  <tom@tromey.com>
8283
8284         * objfiles.h (struct objfile_per_bfd_storage)
8285         <demangled_hash_languages>: Now a bitset.
8286         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8287         (lookup_minimal_symbol): Update.
8288
8289 2019-03-15  Tom Tromey  <tom@tromey.com>
8290
8291         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8292         Don't return the symbol.
8293         * coffread.c (record_minimal_symbol): Use record_full.
8294
8295 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8296
8297         The MS-Windows port of ncurses fails to switch to a color pair if
8298         one or both of the colors are the implicit default colors.  This
8299         change records the default colors when TUI is initialized, and
8300         then specifies them explicitly when a color pair uses the default
8301         colors.  This allows color styling in TUI mode on MS-Windows.
8302
8303         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8304         ncurses_norm_attr.
8305         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8306         colors in ncurses_norm_attr.
8307         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8308         "none", replace it with the default color recorded in
8309         ncurses_norm_attr.
8310
8311 2019-03-14  Tom Tromey  <tromey@adacore.com>
8312
8313         * source-cache.h (class source_cache) <get_source_lines>: Return
8314         std::string.
8315         * source-cache.c (source_cache::extract_lines): Handle case where
8316         first_pos==npos.  Return std::string.
8317         (source_cache::get_source_lines): Update.
8318
8319 2019-03-14  Tom Tromey  <tromey@adacore.com>
8320
8321         * NEWS: Add item for "style sources" commands.
8322         * source-cache.c (source_cache::get_source_lines): Check
8323         source_styling.
8324         * cli/cli-style.c (source_styling): New global.
8325         (_initialize_cli_style): Add "style sources" commands.
8326         (show_style_sources): New function.
8327         * cli/cli-style.h (source_styling): Declare.
8328
8329 2019-03-14  Pedro Alves  <palves@redhat.com>
8330             Tom Tromey  <tromey@adacore.com>
8331
8332         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8333         * tui/tui-winsource.c (tui_refill_source_window): New function,
8334         from...
8335         (tui_horizontal_source_scroll): ... here.  Move some logic.
8336         * cli/cli-style.c (set_style_enabled): Notify new observable.
8337         * tui/tui-hooks.c (tui_redisplay_source): New function.
8338         (tui_attach_detach_observers): Attach or detach
8339         tui_redisplay_source.
8340         * observable.h (source_styling_changed): New observable.
8341         * observable.c: Define source_styling_changed observable.
8342
8343 2019-03-13  Tom Tromey  <tromey@adacore.com>
8344
8345         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8346         (i386_gnu_nat_target::store_registers): Update.
8347         * target-debug.h (target_debug_print_std_string): New macro.
8348         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8349         * windows-tdep.c (display_one_tib): Update.
8350         * tui/tui-stack.c (tui_make_status_line): Update.
8351         * top.c (print_inferior_quit_action): Update.
8352         * thread.c (thr_try_catch_cmd): Update.
8353         (add_thread_with_info): Update.
8354         (thread_target_id_str): Update.
8355         (thr_try_catch_cmd): Update.
8356         (thread_command): Update.
8357         (thread_find_command): Update.
8358         * record-btrace.c (record_btrace_target::info_record)
8359         (record_btrace_resume_thread, record_btrace_target::resume)
8360         (record_btrace_cancel_resume, record_btrace_step_thread)
8361         (record_btrace_target::wait, record_btrace_target::wait)
8362         (record_btrace_target::wait, record_btrace_target::stop): Update.
8363         * progspace.c (print_program_space): Update.
8364         * process-stratum-target.c
8365         (process_stratum_target::thread_address_space): Update.
8366         * linux-fork.c (linux_fork_mourn_inferior)
8367         (detach_checkpoint_command, info_checkpoints_command)
8368         (linux_fork_context): Update.
8369         (linux_fork_detach): Update.
8370         (class scoped_switch_fork_info): Update.
8371         (delete_checkpoint_command): Update.
8372         * infrun.c (follow_fork_inferior): Update.
8373         (follow_fork_inferior): Update.
8374         (proceed_after_vfork_done): Update.
8375         (handle_vfork_child_exec_or_exit): Update.
8376         (follow_exec): Update.
8377         (displaced_step_prepare_throw): Update.
8378         (displaced_step_restore): Update.
8379         (start_step_over): Update.
8380         (resume_1): Update.
8381         (clear_proceed_status_thread): Update.
8382         (proceed): Update.
8383         (print_target_wait_results): Update.
8384         (do_target_wait): Update.
8385         (context_switch): Update.
8386         (stop_all_threads): Update.
8387         (restart_threads): Update.
8388         (finish_step_over): Update.
8389         (handle_signal_stop): Update.
8390         (switch_back_to_stepped_thread): Update.
8391         (keep_going_pass_signal): Update.
8392         (print_exited_reason): Update.
8393         (normal_stop): Update.
8394         * inferior.c (inferior_pid_to_str): Change return type.
8395         (print_selected_inferior): Update.
8396         (add_inferior): Update.
8397         (detach_inferior): Update.
8398         * dummy-frame.c (fprint_dummy_frames): Update.
8399         * dcache.c (dcache_info_1): Update.
8400         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8401         (btrace_fetch, btrace_clear): Update.
8402         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8403         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8404         type.
8405         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8406         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8407         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8408         * gdbarch.c, gdbarch.h: Rebuild.
8409         * gdbarch.sh (core_pid_to_str): Change return type.
8410         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8411         return type.
8412         (windows_nat_target::pid_to_str): Change return type.
8413         (windows_delete_thread): Update.
8414         (windows_nat_target::attach): Update.
8415         (windows_nat_target::files_info): Update.
8416         * target-delegates.c: Rebuild.
8417         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8418         return type.
8419         (sol_thread_target::pid_to_str): Change return type.
8420         * remote.c (class remote_target) <pid_to_str>: Change return
8421         type.
8422         (remote_target::pid_to_str): Change return type.
8423         (extended_remote_target::attach, remote_target::remote_stop_ns)
8424         (remote_target::remote_notif_remove_queued_reply)
8425         (remote_target::push_stop_reply, remote_target::disable_btrace):
8426         Update.
8427         (extended_remote_target::attach): Update.
8428         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8429         type.
8430         (gdbsim_target::pid_to_str): Change return type.
8431         * ravenscar-thread.c (struct ravenscar_thread_target)
8432         <pid_to_str>: Change return type.
8433         (ravenscar_thread_target::pid_to_str): Change return type.
8434         * procfs.c (class procfs_target) <pid_to_str>: Change return
8435         type.
8436         (procfs_target::pid_to_str): Change return type.
8437         (procfs_target::attach): Update.
8438         (procfs_target::detach): Update.
8439         (procfs_target::fetch_registers): Update.
8440         (procfs_target::store_registers): Update.
8441         (procfs_target::wait): Update.
8442         (procfs_target::files_info): Update.
8443         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8444         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8445         return type.
8446         (nto_procfs_target::pid_to_str): Change return type.
8447         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8448         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8449         return type.
8450         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8451         (exit_lwp): Update.
8452         (attach_proc_task_lwp_callback, get_detach_signal)
8453         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8454         (linux_nat_target::resume, wait_lwp, stop_callback)
8455         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8456         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8457         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8458         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8459         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8460         type.
8461         (inf_ptrace_target::attach): Update.
8462         (inf_ptrace_target::files_info): Update.
8463         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8464         type.
8465         (go32_nat_target::pid_to_str): Change return type.
8466         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8467         (gnu_nat_target::wait): Update.
8468         (gnu_nat_target::wait): Update.
8469         (gnu_nat_target::resume): Update.
8470         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8471         (fbsd_nat_target::wait): Update.
8472         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8473         type.
8474         (darwin_nat_target::attach): Update.
8475         * corelow.c (class core_target) <pid_to_str>: Change return type.
8476         (core_target::pid_to_str): Change return type.
8477         * target.c (normal_pid_to_str): Change return type.
8478         (default_pid_to_str): Likewise.
8479         (target_pid_to_str): Change return type.
8480         (target_translate_tls_address): Update.
8481         (target_announce_detach): Update.
8482         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8483         return type.
8484         (bsd_uthread_target::pid_to_str): Change return type.
8485         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8486         type.
8487         (bsd_kvm_target::pid_to_str): Change return type.
8488         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8489         return type.
8490         (aix_thread_target::pid_to_str): Change return type.
8491         * target.h (struct target_ops) <pid_to_str>: Change return type.
8492         (target_pid_to_str, normal_pid_to_str): Likewise.
8493         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8494         type.
8495         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8496         type.
8497         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8498         return type.
8499         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8500         type.
8501         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8502         type.
8503         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8504         return type.
8505
8506 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8507
8508         * NEWS: Mention that the new default MI version is 3.  Mention
8509         changes to the output of commands and events that deal with
8510         multi-location breakpoints.
8511         * breakpoint.c: Include "mi/mi-out.h".
8512         (print_one_breakpoint): Change output syntax if using MI version
8513         >= 3.
8514         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8515         New.
8516         (mi_multi_location_breakpoint_output_fixed): New.
8517         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8518         (mi_cmd_fix_multi_location_breakpoint_output): New.
8519         (mi_multi_location_breakpoint_output_fixed): New.
8520         * mi/mi-cmds.c (mi_cmds): Register command
8521         -fix-multi-location-breakpoint-output.
8522         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8523         interpreter "mi".
8524
8525 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8526
8527         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8528         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8529         instantiate mi_ui_out based on interpreter name.
8530         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8531         * mi/mi-main.c (mi_load_progress): Likewise.
8532
8533 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8534
8535         * NEWS: Combine separate "New targets" sections for 8.3.
8536
8537 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8538
8539         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8540         (ppcfbsd_init_abi): Install gdbarch
8541         "fetch_tls_load_module_address" and "get_thread_local_address"
8542         methods.
8543
8544 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8545
8546         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8547         (riscv_fbsd_init_abi): Install gdbarch
8548         "fetch_tls_load_module_address" and "get_thread_local_address"
8549         methods.
8550
8551 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8552
8553         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8554         (i386fbsd_init_abi): Install gdbarch
8555         "fetch_tls_load_module_address" and "get_thread_local_address"
8556         methods.
8557
8558 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8559
8560         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8561         (amd64fbsd_init_abi): Install gdbarch
8562         "fetch_tls_load_module_address" and "get_thread_local_address"
8563         methods.
8564
8565 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8566
8567         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8568         (struct fbsd_pspace_data): New type.
8569         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8570         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8571         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8572         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8573         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8574
8575 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8576
8577         * gdbtypes.c (lookup_struct_elt): New function.
8578         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8579         * gdbtypes.h (struct struct_elt): New type.
8580         (lookup_struct_elt): New prototype.
8581
8582 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8583
8584         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8585         remove disabled code block.
8586
8587 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8588
8589         * gdbarch.sh (get_thread_local_address): New method.
8590         * gdbarch.h, gdbarch.c: Regenerate.
8591         * target.c (target_translate_tls_address): Use
8592         gdbarch_get_thread_local_address if present instead of
8593         target::get_thread_local_address.
8594
8595 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8596
8597         * target.h (target::get_thread_local_address): Update comment.
8598
8599 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8600
8601         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8602         objfile->separate_debug_objfile_backlink if not NULL.
8603
8604 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8605
8606         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8607         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8608         (amd64bsd_store_inferior_registers): Likewise.
8609         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8610         Enable segment base registers.
8611         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8612         PT_GETFSBASE and PT_GETGSBASE.
8613         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8614         PT_SETGSBASE.
8615         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8616         segment base registers.
8617         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8618
8619 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8620
8621         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8622         Update calls to i386_target_description to add 'segments'
8623         parameter.
8624         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8625         add segment base registers.
8626         * arch/i386.c (i386_create_target_description): Add 'segments'
8627         parameter to enable segment base registers.
8628         * arch/i386.h (i386_create_target_description): Likewise.
8629         * features/i386/32bit-segments.xml: New file.
8630         * features/i386/32bit-segments.c: Generate.
8631         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8632         call to i386_target_description to add 'segments' parameter.
8633         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8634         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8635         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8636         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8637         if feature is present.
8638         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8639         Add 'segments' parameter to call to i386_target_description.
8640         (i386_target_description): Add 'segments' parameter to enable
8641         segment base registers.
8642         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8643         to call to i386_target_description.
8644         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8645         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8646         Define I386_NUM_REGS.
8647         (i386_target_description): Add 'segments' parameter to enable
8648         segment base registers.
8649
8650 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8651
8652         PR/24325
8653         * source-cache.c: #undef open and close, to avoid unresolved
8654         externals during linking.
8655
8656 2019-03-12  Tom Tromey  <tromey@adacore.com>
8657
8658         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8659         const.  Add initializers.
8660         (_initialize_remote): Don't initialize ptid globals.
8661
8662 2019-03-12  Pedro Alves  <palves@redhat.com>
8663
8664         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8665
8666 2019-03-12  Pedro Alves  <palves@redhat.com>
8667
8668         * cp-name-parser.y (main): Remove unused 'len' variable.
8669
8670 2019-03-12  Tom Tromey  <tromey@adacore.com>
8671
8672         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8673         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8674
8675 2019-03-12  Tom Tromey  <tromey@adacore.com>
8676
8677         * linux-nat.c (iterate_over_lwps): Update.
8678         (stop_callback): Remove parameter.
8679         (stop_wait_callback, detach_callback, resume_set_callback)
8680         (select_singlestep_lwp_callback, set_ignore_sigint)
8681         (status_callback, resumed_callback, resume_clear_callback)
8682         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8683         data parameter.
8684         (linux_nat_target::detach, linux_nat_target::resume)
8685         (linux_stop_and_wait_all_lwps, select_event_lwp)
8686         (linux_nat_filter_event, linux_nat_wait_1)
8687         (linux_nat_target::kill, linux_nat_target::stop)
8688         (linux_nat_target::stop): Update.
8689         (linux_nat_resume_callback): Change type.
8690         (resume_stopped_resumed_lwps, count_events_callback)
8691         (select_event_lwp_callback): Likewise.
8692         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8693         * arm-linux-nat.c (struct update_registers_data): Remove.
8694         (update_registers_callback): Change type.
8695         (arm_linux_insert_hw_breakpoint1): Update.
8696         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8697         parameter.
8698         (x86_linux_dr_set_addr): Update.
8699         (x86_linux_dr_set_control): Update.
8700         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8701         (iterate_over_lwps): Use gdb::function_view.
8702         * nat/aarch64-linux-hw-point.c (struct
8703         aarch64_dr_update_callback_param): Remove.
8704         (debug_reg_change_callback): Change type.
8705         (aarch64_notify_debug_reg_change): Update.
8706         * s390-linux-nat.c (s390_refresh_per_info): Update.
8707
8708 2019-03-11  Tom Tromey  <tromey@adacore.com>
8709
8710         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8711         redundant assignment to "this_cu".
8712
8713 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8714
8715         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8716
8717 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8718
8719         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8720         from...
8721         (rank_one_type): ... this.
8722
8723 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8724
8725         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8726         from...
8727         (rank_one_type): ... this.
8728
8729 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8730
8731         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8732         from...
8733         (rank_one_type): ... this.
8734
8735 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8736
8737         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8738         from...
8739         (rank_one_type): ... this.
8740
8741 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8742
8743         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8744         from...
8745         (rank_one_type): ... this.
8746
8747 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8748
8749         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8750         from...
8751         (rank_one_type): ... this.
8752
8753 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8754
8755         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8756         from...
8757         (rank_one_type): ... this.
8758
8759 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8760
8761         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8762         from...
8763         (rank_one_type): ... this.
8764
8765 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8766
8767         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8768         from...
8769         (rank_one_type): ... this.
8770
8771 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8772
8773         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8774         from...
8775         (rank_one_type): ... this.
8776
8777 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8778
8779         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8780         from...
8781         (rank_one_type): ... this.
8782
8783 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8784
8785         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8786         from...
8787         (rank_one_type): ... this.
8788
8789 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8790
8791         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8792         inferior-events' shows the example events.
8793
8794 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8795
8796         Support styling on native MS-Windows console
8797
8798         PR/24315
8799         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8800         on MS-Windows if $TERM is not defined.
8801
8802         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8803
8804         * posix-hdep.c (gdb_console_fputs):
8805         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8806         functions.
8807         * ui-file.h (gdb_console_fputs): Add prototype.
8808
8809         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8810         back to fputs only if the former returns zero.
8811
8812 2019-03-07  Tom Tromey  <tom@tromey.com>
8813
8814         * symmisc.c (print_symbol_bcache_statistics): Update.
8815         (print_objfile_statistics): Update.
8816         * symfile.c (allocate_symtab): Update.
8817         * stabsread.c: Don't include bcache.h.
8818         * psymtab.h (struct psymbol_bcache): Don't declare.
8819         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8820         (psymbol_bcache_init, psymbol_bcache_free)
8821         (psymbol_bcache_get_bcache): Don't declare.
8822         * psymtab.c (struct psymbol_bcache): Remove.
8823         (psymtab_storage::psymtab_storage): Update.
8824         (psymtab_storage::~psymtab_storage): Update.
8825         (psymbol_bcache_init, psymbol_bcache_free)
8826         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8827         (add_psymbol_to_bcache): Update.
8828         (allocate_psymtab): Update.
8829         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8830         macro_cache>: No longer pointers.
8831         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8832         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8833         * macrotab.c (macro_bcache): Update.
8834         * macroexp.c: Don't include bcache.h.
8835         * gdbtypes.c (check_types_worklist): Update.
8836         (types_deeply_equal): Remove TRY/CATCH.  Update.
8837         * elfread.c (elf_symtab_read): Update.
8838         * dwarf2read.c: Don't include bcache.h.
8839         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8840         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8841         (print_bcache_statistics, bcache_memory_used): Don't declare.
8842         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8843         methods.  Rename all data members.
8844         * bcache.c (struct bcache): Move to bcache.h.
8845         (bcache::expand_hash_table): Rename from expand_hash_table.
8846         (bcache): Remove.
8847         (bcache::insert): Rename from bcache_full.
8848         (bcache::compare): Rename from bcache_compare.
8849         (bcache_xmalloc): Remove.
8850         (bcache::~bcache): Rename from bcache_xfree.
8851         (bcache::print_statistics): Rename from print_bcache_statistics.
8852         (bcache::memory_used): Rename from bcache_memory_used.
8853
8854 2019-03-07  Pedro Alves  <palves@redhat.com>
8855
8856         * infrun.c (normal_stop): Also check for
8857         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8858
8859 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8860
8861         * f-lang.c (value_from_host_double): Moved to...
8862         * value.c (value_from_host_double): ...here.
8863         * value.h (value_from_host_double): Declare.
8864         * guile/scm-math.c (vlscm_convert_typed_number): Use
8865         value_from_host_double.
8866         (vlscm_convert_number): Likewise.
8867         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8868         * python/py-value.c (convert_value_from_python): Likewise.
8869
8870 2019-03-06  Tom Tromey  <tom@tromey.com>
8871
8872         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8873
8874 2019-03-06  Tom Tromey  <tom@tromey.com>
8875
8876         * utils.h (free_current_contents): Don't declare.
8877         * utils.c (free_current_contents): Remove.
8878
8879 2019-03-06  Tom Tromey  <tom@tromey.com>
8880
8881         * top.c (quit_force): Update.
8882         * main.c (captured_command_loop): Update.
8883         * common/new-op.c (operator new): Update.
8884         * common/common-exceptions.c (struct catcher)
8885         <save_cleanup_chain>: Remove member.
8886         (exceptions_state_mc_init): Update.
8887         (exception_try_scope_entry): Return nullptr.
8888         (exception_try_scope_exit, exception_rethrow)
8889         (throw_exception_sjlj, throw_exception_cxx): Update.
8890         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8891         (all_cleanups, do_cleanups, discard_cleanups)
8892         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8893         (restore_cleanups, restore_final_cleanups): Don't declare.
8894         (do_final_cleanups): Remove parameter.
8895         * common/cleanups.c (cleanup_chain, make_cleanup)
8896         (make_cleanup_dtor, all_cleanups, do_cleanups)
8897         (discard_my_cleanups, discard_cleanups)
8898         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8899         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8900         (null_cleanup): Remove.
8901         (do_final_cleanups): Remove parameter.
8902
8903 2019-03-06  Tom Tromey  <tom@tromey.com>
8904
8905         * remote.c (remote_target::remote_parse_stop_reply): Use
8906         unique_xmalloc_ptr.
8907
8908 2019-03-06  Tom Tromey  <tom@tromey.com>
8909
8910         * stabsread.c (struct stabs_field_info): Rename from field_info.
8911         <list, fnlist>: Add initializers.
8912         <obstack>: New member.
8913         (read_member_functions, read_struct_fields, read_baseclasses):
8914         Allocate on obstack.  Don't use cleanups.
8915         (read_one_struct_field, read_member_functions, read_struct_fields)
8916         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8917         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8918         (read_struct_type): Update.
8919
8920 2019-03-06  Tom Tromey  <tom@tromey.com>
8921
8922         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8923         * common/filestuff.h (make_cleanup_close): Don't declare.
8924         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8925         Remove.
8926
8927 2019-03-06  Tom Tromey  <tom@tromey.com>
8928
8929         * solib-aix.c: Use make_scope_exit.
8930
8931 2019-03-06  Tom Tromey  <tom@tromey.com>
8932
8933         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8934         Use make_scope_exit.
8935
8936 2019-03-06  Tom Tromey  <tom@tromey.com>
8937
8938         * solib-svr4.c (disable_probes_interface): Remove parameter.
8939         (svr4_handle_solib_event): Use make_scope_exit.
8940
8941 2019-03-06  Tom Tromey  <tom@tromey.com>
8942
8943         * remote.c (struct stop_reply_deleter): Remove.
8944         (stop_reply_up): Update.
8945         (struct stop_reply): Derive from notif_event.  Don't typedef.
8946         <regcache>: Now a std::vector.
8947         (stop_reply_xfree): Remove.
8948         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8949         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8950         (remote_target::discard_pending_stop_replies): Use delete.
8951         (remote_target::remote_parse_stop_reply): Update.
8952         (remote_target::process_stop_reply): Update.
8953         * remote-notif.h (struct notif_event): Add virtual destructor.
8954         Remove "dtr" member.
8955         (struct notif_client) <alloc_event>: Return a unique_ptr.
8956         (notif_event_xfree): Don't declare.
8957         (notif_event_up): New typedef.
8958         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8959         (notif_event_xfree, do_notif_event_xfree): Remove.
8960         (remote_notif_state_xfree): Update.
8961
8962 2019-03-06  Tom Tromey  <tom@tromey.com>
8963
8964         * infrun.c (displaced_step_clear_cleanup): Now a
8965         forward_scope_exit type.
8966         (displaced_step_prepare_throw): Update.
8967         (displaced_step_fixup): Update.
8968
8969 2019-03-06  Tom Tromey  <tom@tromey.com>
8970
8971         * inferior.h (class inferior): Update comment.
8972         * gdbthread.h (class thread_info): Update comment.
8973
8974 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8975             Tom Tromey  <tom@tromey.com>
8976
8977         * stabsread.h (struct stab_section_list): Remove.
8978         (coffstab_build_psymtabs): Update.
8979         * dbxread.c (symbuf_sections): Now a std::vector.
8980         (sect_idx): New global.
8981         (fill_symbuf): Update.
8982         (coffstab_build_psymtabs): Change type of stabsects parameter.
8983         Update.
8984         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8985         std::vector.
8986         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8987         (coff_locate_sections): Update.
8988         (coff_symfile_read): Remove cleanups.  Update.
8989         (init_stringtab): Add storage parameter.
8990         (free_stringtab, free_stringtab_cleanup): Remove.
8991         (init_lineno): Add storage parameter.
8992         (free_linetab, free_linetab_cleanup): Remove.
8993
8994 2019-03-06  Pedro Alves  <palves@redhat.com>
8995
8996         * linux-fork.c (fork_info::clobber_regs): Delete.
8997         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8998         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8999         comment.  Adjust.
9000         (scoped_switch_fork_info::scoped_switch_fork_info)
9001         (checkpoint_command, linux_fork_context): Adjust
9002         fork_save_infrun_state calls.
9003
9004 2019-03-06  Pedro Alves  <palves@redhat.com>
9005
9006         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9007         (inf_has_multiple_threads): Return 'bool' and rewrite using
9008         inferior_info::threads().
9009
9010 2019-03-06  Pedro Alves  <palves@redhat.com>
9011
9012         * linux-fork.c: Include <list>.
9013         (fork_list): Now a std::list instance.
9014         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9015         (forks_exist_p, find_last_fork): Adjust.
9016         (new_fork): Delete.
9017         (one_fork_p): New.
9018         (add_fork): Adjust.
9019         (free_fork): Delete, folded into fork_info::~fork_info().
9020         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9021         Adjust.
9022         (init_fork_list): Delete.
9023         (linux_fork_killall, linux_fork_mourn_inferior)
9024         (linux_fork_detach, info_checkpoints_command): Adjust.
9025         (_initialize_linux_fork): No longer call init_fork_list.
9026
9027 2019-03-06  Pedro Alves  <palves@redhat.com>
9028
9029         * linux-fork.c (new_fork): New, split out of ...
9030         (add_fork): ... this.  Return void.  Move "first fork" special
9031         case from here, to ...
9032         (checkpoint_command): ... here.
9033         * linux-linux.h (add_fork): Return void.
9034
9035 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9036
9037         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9038
9039 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9040             Chris January  <chris.january@arm.com>
9041             David Lecomber  <david.lecomber@arm.com>
9042
9043         * f-exp.y: New token, UNOP_INTRINSIC.
9044         (exp): New pattern using UNOP_INTRINSIC token.
9045         (f77_keywords): Add 'abs' keyword.
9046         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9047         (value_from_host_double): New function.
9048         (evaluate_subexp_f): Support UNOP_ABS.
9049
9050 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9051
9052         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9053         types.
9054
9055 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9056
9057         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9058         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9059         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9060
9061 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9062
9063         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9064
9065 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9066             Chris January  <chris.january@arm.com>
9067
9068         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9069         * f-exp.y: Define 'KIND' token.
9070         (exp): New pattern for KIND expressions.
9071         (ptype): Handle types with a kind extension.
9072         (direct_abs_decl): Extend to spot kind extensions.
9073         (f77_keywords): Add 'kind' to the list.
9074         (push_kind_type): New function.
9075         (convert_to_kind_type): New function.
9076         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9077         * parse.c (operator_length_standard): Likewise.
9078         * parser-defs.h (enum type_pieces): Add tp_kind.
9079         * std-operator.def: Add UNOP_KIND.
9080
9081 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9082
9083         * f-exp.y (f_parse): Set yydebug.
9084
9085 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9086
9087         * f-lang.c (evaluate_subexp_f): New function.
9088         (exp_descriptor_f): New global.
9089         (f_language_defn): Use exp_descriptor_f instead of
9090         exp_descriptor_standard.
9091
9092 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9093
9094         * f-exp.y (struct token): Add comments.
9095         (dot_ops): Remove uppercase versions and the end marker.
9096         (f77_keywords): Likewise.
9097         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9098         entries in the dot_ops array are case insensitive, and use
9099         strncasecmp to compare strings.  Also some whitespace cleanup in
9100         this area.  Similar for the f77_keywords array, except entries in
9101         this list might be case sensitive.
9102
9103 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9104
9105         * f-exp.y (struct f77_boolean_val): Add comments.
9106         (boolean_values): Remove uppercase versions, and end marker.
9107         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9108         and use strncasecmp to achieve case insensitivity.  Additionally,
9109         perform whitespace cleanup around this code.
9110
9111 2019-03-06  Tom Tromey  <tromey@adacore.com>
9112
9113         * remote-sim.c (gdbsim_target_open): Use result of
9114         gdb_argv::release.
9115
9116 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9117         Dirk Schubert  <dirk.schubert@arm.com>
9118         Chris January  <chris.january@arm.com>
9119
9120         * eval.c (evaluate_subexp_standard): Call Fortran argument
9121         wrapping logic.
9122         * f-lang.c (struct value): A value which can be passed into a
9123         Fortran function call.
9124         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9125         where appropriate.
9126         (struct type): Value ready for a Fortran function call.
9127         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9128         is needed.
9129         * f-lang.h (fortran_argument_convert): Declaration.
9130         (fortran_preserve_arg_pointer): Declaration.
9131         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9132
9133 2019-03-05  Tom Tromey  <tromey@adacore.com>
9134
9135         * python/py-prettyprint.c (print_string_repr): Remove #if.
9136         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9137
9138 2019-03-05  Tom Tromey  <tromey@adacore.com>
9139
9140         * target.c (the_dummy_target): Move later.  Change type to
9141         "dummy_target".
9142         (initialize_targets): Don't initialize the_dummy_target.
9143
9144 2019-03-05  Tom Tromey  <tromey@adacore.com>
9145
9146         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9147         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9148
9149 2019-03-05  Tom Tromey  <tromey@adacore.com>
9150
9151         * windows-nat.c (windows_nat_target::attach)
9152         (windows_nat_target::detach): Don't call gdb_flush.
9153         * valprint.c (generic_val_print, val_print, val_print_string):
9154         Don't call gdb_flush.
9155         * utils.c (defaulted_query): Don't call gdb_flush.
9156         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9157         * target.c (target_announce_detach): Don't call gdb_flush.
9158         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9159         * remote.c (extended_remote_target::attach): Don't call
9160         gdb_flush.
9161         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9162         * printcmd.c (do_examine): Don't call gdb_flush.
9163         (info_display_command): Don't call gdb_flush.
9164         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9165         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9166         * memattr.c (info_mem_command): Don't call gdb_flush.
9167         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9168         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9169         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9170         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9171         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9172         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9173         (gnu_nat_target::detach): Don't call gdb_flush.
9174         * f-valprint.c (f_val_print): Don't call gdb_flush.
9175         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9176         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9177         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9178         gdb_flush.
9179         * c-valprint.c (c_val_print): Don't call gdb_flush.
9180         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9181
9182 2019-03-05  Tom Tromey  <tromey@adacore.com>
9183
9184         * varobj.c (update_dynamic_varobj_children): Update.
9185         (install_default_visualizer): Use reset, not release.
9186         * value.c (set_internalvar): Update.
9187         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9188         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9189         ATTRIBUTE_UNUSED_RESULT.
9190
9191 2019-03-05  Tom Tromey  <tromey@adacore.com>
9192
9193         * remote.c (class scoped_remote_fd) <release>: Add
9194         ATTRIBUTE_UNUSED_RESULT.
9195
9196 2019-03-05  Tom Tromey  <tromey@adacore.com>
9197
9198         * macroexp.c (struct macro_buffer) <release>: Add
9199         ATTRIBUTE_UNUSED_RESULT.
9200
9201 2019-03-05  Tom Tromey  <tromey@adacore.com>
9202
9203         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9204         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9205         ATTRIBUTE_UNUSED_RESULT.
9206
9207 2019-03-05  Tom Tromey  <tromey@adacore.com>
9208
9209         * common/scoped_fd.h (class scoped_fd) <release>: Add
9210         ATTRIBUTE_UNUSED_RESULT.
9211
9212 2019-03-05  Tom Tromey  <tromey@adacore.com>
9213
9214         * parser-defs.h (struct parser_state) <release>: Add
9215         ATTRIBUTE_UNUSED_RESULT.
9216
9217 2019-03-05  Tom Tromey  <tromey@adacore.com>
9218
9219         * utils.h (class gdb_argv) <release>: Add
9220         ATTRIBUTE_UNUSED_RESULT.
9221         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9222
9223 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9224
9225         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9226         for-loop range, to avoid compiler warnings.
9227
9228         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9229         avoid compiler warnings about unused variables.
9230
9231         * NEWS: Mention end of support for native debugging on MS-Windows
9232         before XP.
9233
9234         PR gdb/24292
9235         * common/netstuff.c:
9236         * gdbserver/gdbreplay.c
9237         * gdbserver/remote-utils.c:
9238         * ser-tcp.c:
9239         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9240         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9241         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9242         'getaddrinfo' and 'freeaddrinfo' were not available before
9243         Windows XP, and mingw.org's MinGW headers by default define
9244         _WIN32_WINNT to 0x500.
9245
9246 2019-03-01  Gary Benson <gbenson@redhat.com>
9247
9248         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9249
9250 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9251             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9252
9253         PR gdb/8527
9254         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9255         set_sigint_trap, clear_sigint_trap.
9256
9257 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9258
9259         * target.c (target_detach): Clear the regcache and the
9260         frame cache.
9261
9262 2019-02-27  Pedro Alves  <palves@redhat.com>
9263
9264         * utils.c (set_screen_size): When we cap the height/width sizes,
9265         tweak the corresponding command variable to show "unlimited":
9266
9267 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9268             Pedro Alves  <palves@redhat.com>
9269
9270         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9271         before calling rl_set_screen_size.
9272
9273 2019-02-27  Tom Tromey  <tromey@adacore.com>
9274
9275         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9276         define.
9277         * python/py-value.c: Remove Python 2.4 workaround.
9278         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9279         workaround.
9280         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9281         Python 2.4 workaround.
9282         * python/python-internal.h: Remove Python 2.4 comment.
9283         (Py_ssize_t): Don't define.
9284         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9285         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9286         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9287         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9288         * python/python.c (do_start_initialization): Remove Python 2.4
9289         workaround.
9290         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9291         (print_children): Remove Python 2.4 workaround.
9292         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9293         workaround.
9294         (CHARBUFFERPROC_NAME): Remove.
9295         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9296         Python 2.4 workaround.
9297
9298 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9299
9300         * NEWS: Note minimum Python version.
9301
9302 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9303
9304         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9305         code from these functions.  Remove corresponding ifdefs.  Use
9306         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9307         Remove gotos and target of gotos.
9308         (infpy_search_memory): Likewise.
9309
9310 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9311
9312         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9313         (hppa_gdbarch_init): Don't register deleted functions with
9314         gdbarch.
9315
9316 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9317
9318         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9319         (h8300_unwind_sp): Delete.
9320         (h8300_dummy_id): Delete.
9321         (h8300_gdbarch_init): Don't register deleted functions with
9322         gdbarch.
9323
9324 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9325
9326         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9327         (ft32_unwind_pc): Delete.
9328         (ft32_unwind_sp): Delete.
9329         (ft32_gdbarch_init): Don't register deleted functions with
9330         gdbarch.
9331
9332 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9333
9334         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9335         (frv_unwind_pc): Delete.
9336         (frv_unwind_sp): Delete.
9337         (frv_gdbarch_init): Don't register deleted functions with
9338         gdbarch.
9339
9340 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9341
9342         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9343         (riscv_unwind_pc): Delete.
9344         (riscv_unwind_sp): Delete.
9345         (riscv_gdbarch_init): Don't register deleted functions with
9346         gdbarch.
9347
9348 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9349
9350         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9351         (csky_unwind_pc): Delete.
9352         (csky_unwind_sp): Delete.
9353         (csky_gdbarch_init): Don't register deleted functions with
9354         gdbarch.
9355
9356 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9357
9358         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9359         (cris_unwind_pc): Delete.
9360         (cris_unwind_sp): Delete.
9361         (cris_gdbarch_init): Don't register deleted functions with
9362         gdbarch.
9363
9364 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9365
9366         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9367         (bfin_unwind_pc): Delete.
9368         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9369
9370 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9371
9372         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9373         (arm_unwind_pc): Delete.
9374         (arm_unwind_sp): Delete.
9375         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9376
9377 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9378
9379         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9380         (arc_unwind_pc): Delete.
9381         (arc_unwind_sp): Delete.
9382         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9383
9384 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9385
9386         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9387         (alpha_unwind_pc): Delete.
9388         (alpha_gdbarch_init): Don't register deleted functions with
9389         gdbarch.
9390
9391 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9392
9393         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9394         (aarch64_unwind_pc): Delete.
9395         (aarch64_unwind_sp): Delete.
9396         (aarch64_gdbarch_init): Don't register deleted functions with
9397         gdbarch.
9398
9399 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9400
9401         * gdbtypes.c (type_align): Don't consider static members when
9402         computing structure alignment.
9403
9404 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9405
9406         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9407         return 0 for other types.
9408         * arch-utils.c (default_type_align): Always return 0.
9409         * gdbarch.h: Regenerate.
9410         * gdbarch.sh (type_align): Extend comment.
9411         * gdbtypes.c (type_align): Add additional comments, always call
9412         gdbarch_type_align before applying the default rules.
9413         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9414         generic code will then apply a suitable default.
9415         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9416         types, return 0 for other types.
9417
9418 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9419
9420         * NEWS: Create a new section for the next release branch.
9421         Rename the section of the current branch, now that it has
9422         been cut.
9423
9424 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9425
9426         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9427         * version.in: Bump version to 8.3.50.DATE-git.
9428
9429 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9430
9431         * aix-thread.c (ptid_cmp): Remove unused variable.
9432         (get_signaled_thread): Likewise.
9433         (store_regs_user_thread): Likewise.
9434         (store_regs_kernel_thread): Likewise.
9435         (fetch_regs_kernel_thread): Remove shadowed variable.
9436
9437 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9438
9439         * features/riscv/32bit-cpu.xml: Add register numbers.
9440         * features/riscv/32bit-fpu.c: Regenerate.
9441         * features/riscv/32bit-fpu.xml: Add register numbers.
9442         * features/riscv/64bit-cpu.xml: Add register numbers.
9443         * features/riscv/64bit-fpu.c: Regenerate.
9444         * features/riscv/64bit-fpu.xml: Add register numbers.
9445
9446 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9447
9448         * NEWS: Mention two argument form of gdb.Value constructor.
9449         * python/py-value.c (convert_buffer_and_type_to_value): New
9450         function.
9451         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9452         Add support for handling an optional second argument.  Call
9453         convert_buffer_and_type_to_value as appropriate.
9454         * python/python-internal.h (Py_buffer_deleter): New struct.
9455         (Py_buffer_up): New typedef.
9456
9457 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9458
9459         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9460         instead of releasing ownership.
9461
9462 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9463
9464         * dwarf2read.c (open_and_init_dwp_file): Call
9465         elf_numsections instead of bfd_count_sections to initialize
9466         dwp_file->num_sections.
9467
9468 2019-02-25  Tom Tromey  <tromey@adacore.com>
9469
9470         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9471
9472 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9473
9474         * gcore.in: Add '--readnever' option when invoking GDB.
9475
9476 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9477
9478         * MAINTAINERS: Update my email address.
9479
9480 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9481
9482         * build-id.c (build_id_to_debug_bfd_1): New function.
9483         (build_id_to_debug_bfd): Look for separate debug file in
9484         sysroot.
9485
9486 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9487
9488         * gdbarch.sh: Update the copyright year range that is placed into
9489         generated files.
9490
9491 2019-02-22  Keith Seitz  <keiths@redhat.com>
9492
9493         PR symtab/23853
9494         * linespec.c (create_sals_line_offset): Search for the default
9495         symtab's filename instead of its fullname.
9496
9497 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9498
9499         * NEWS: Update style defaults.
9500
9501 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9502
9503         * main.c (captured_main_1): Disable styling in batch mode.
9504
9505 2019-02-20  Tom Tromey  <tom@tromey.com>
9506
9507         * symtab.c (symtab_symbol_info): Fix typos.
9508
9509 2019-02-20  Tom Tromey  <tromey@adacore.com>
9510
9511         * findcmd.c (_initialize_mem_search): Use upper case for
9512         metasyntactic variables.
9513
9514 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9515
9516         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9517         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9518
9519 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9520
9521         * top.h (source_file_name): Change to std::string.
9522         * top.c (source_file_name): Likewise.
9523         (command_line_input): Adjust.
9524         * cli/cli-script.c (script_from_file): Adjust.
9525
9526 2019-02-19  Tom Tromey  <tromey@adacore.com>
9527
9528         * ravenscar-thread.c
9529         (ravenscar_thread_target::update_thread_list): Don't call
9530         ada_build_task_list.
9531         * ada-lang.h (ada_build_task_list): Don't declare.
9532         * ada-tasks.c (struct ada_tasks_inferior_data)
9533         <task_list_valid_p>: Now bool.
9534         (read_known_tasks, ada_task_list_changed)
9535         (ada_tasks_invalidate_inferior_data): Update.
9536         (read_known_tasks_array): Return bool.
9537         (read_known_tasks_list): Likewise.
9538         (read_known_tasks): Return void.
9539         (ada_build_task_list): Now static.
9540
9541 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9542
9543         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9544         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9545
9546 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9547
9548         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9549         variant for ada_tasks_pspace_data_handle and
9550         ada_tasks_inferior_data_handle.
9551         (ada_tasks_pspace_data_cleanup): New function.
9552         (ada_tasks_inferior_data_cleanup): New function.
9553
9554 2019-02-17  Tom Tromey  <tom@tromey.com>
9555
9556         * macrotab.h (macro_source_fullname): Return a std::string.
9557         * macrotab.c (macro_include, check_for_redefinition)
9558         (macro_undef, macro_lookup_definition, foreach_macro)
9559         (foreach_macro_in_scope): Update.
9560         (macro_source_fullname): Return a std::string.
9561         * macrocmd.c (show_pp_source_pos): Update.
9562
9563 2019-02-17  Tom Tromey  <tom@tromey.com>
9564
9565         * macrocmd.c (show_pp_source_pos): Style the file names.
9566
9567 2019-02-17  Tom Tromey  <tom@tromey.com>
9568
9569         PR tui/24197:
9570         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9571
9572 2019-02-17  Tom Tromey  <tom@tromey.com>
9573
9574         * ada-lang.c (user_select_syms): Use filtered printing.
9575         * utils.c (wrap_style): New global.
9576         (desired_style): Remove.
9577         (emit_style_escape): Add stream parameter.
9578         (set_output_style, reset_terminal_style, prompt_for_continue):
9579         Update.
9580         (flush_wrap_buffer): Only flush gdb_stdout.
9581         (wrap_here): Set wrap_style.
9582         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9583         treat escape sequences as a character.  Change when wrap buffer is
9584         flushed.
9585         (fputs_styled): Do not set the output style when the default is
9586         requested.
9587         * ui-style.h (struct ui_file_style) <is_default>: New method.
9588         * source.c (print_source_lines_base): Emit escape sequences in one
9589         piece.
9590
9591 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9592
9593         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9594         integers and enumeration types.
9595
9596 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9597
9598         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9599         instead of lookup_symbol_in_language
9600         (do_exact_match): New function.
9601         (ada_get_symbol_name_matcher): Return do_exact_match when
9602         doing a verbatim match.
9603
9604 2019-02-15  Tom Tromey  <tromey@adacore.com>
9605
9606         * ravenscar-thread.c (ravenscar_thread_target::resume)
9607         (ravenscar_thread_target::wait): Special case wildcard requests.
9608
9609 2019-02-15  Tom Tromey  <tromey@adacore.com>
9610
9611         * ravenscar-thread.c (base_ptid): Remove.
9612         (struct ravenscar_thread_target) <close>: New method.
9613         <m_base_ptid>: New member.
9614         <update_inferior_ptid, active_task, task_is_currently_active,
9615         runtime_initialized>: Declare methods.
9616         <ravenscar_thread_target>: Add constructor.
9617         (ravenscar_thread_target::task_is_currently_active)
9618         (ravenscar_thread_target::update_inferior_ptid)
9619         (ravenscar_runtime_initialized): Rename.  Now methods.
9620         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9621         (ravenscar_thread_target::update_thread_list): Update.
9622         (ravenscar_thread_target::active_task): Now method.
9623         (ravenscar_thread_target::store_registers)
9624         (ravenscar_thread_target::prepare_to_store)
9625         (ravenscar_thread_target::prepare_to_store)
9626         (ravenscar_thread_target::mourn_inferior): Update.
9627         (ravenscar_inferior_created): Use "new" to create target.
9628         (ravenscar_thread_target::get_ada_task_ptid): Update.
9629         (_initialize_ravenscar): Don't initialize base_ptid.
9630         (ravenscar_ops): Remove global.
9631
9632 2019-02-15  Tom Tromey  <tromey@adacore.com>
9633
9634         * target.h (push_target): Declare new overload.
9635         * target.c (push_target): New overload, taking an rvalue reference.
9636         * remote.c (remote_target::open_1): Use push_target overload.
9637         * corelow.c (core_target_open): Use push_target overload.
9638
9639 2019-02-15  Tom Tromey  <tromey@adacore.com>
9640
9641         * ravenscar-thread.c (is_ravenscar_task)
9642         (ravenscar_task_is_currently_active): Return bool.
9643         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9644         (_initialize_ravenscar): Remove "(void)".
9645         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9646         Return bool.
9647
9648 2019-02-15  Tom Tromey  <tromey@adacore.com>
9649
9650         * ravenscar-thread.c (ravenscar_runtime_initializer)
9651         (has_ravenscar_runtime, get_running_thread_id)
9652         (ravenscar_thread_target::resume): Fix indentation.
9653
9654 2019-02-15  Tom Tromey  <tromey@adacore.com>
9655
9656         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9657         from ravenscar_arch_ops.
9658         (sparc_ravenscar_ops::fetch_registers)
9659         (sparc_ravenscar_ops::store_registers): Now methods.
9660         (sparc_ravenscar_prepare_to_store): Remove.
9661         (sparc_ravenscar_ops): Redefine.
9662         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9663         methods and destructor.  Remove members.
9664         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9665         (ravenscar_thread_target::store_registers)
9666         (ravenscar_thread_target::prepare_to_store): Update.
9667         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9668         Remove.
9669         (struct ppc_ravenscar_powerpc_ops): Derive from
9670         ravenscar_arch_ops.
9671         (ppc_ravenscar_powerpc_ops::fetch_registers)
9672         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9673         (ppc_ravenscar_powerpc_ops): Redefine.
9674         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9675         (ppc_ravenscar_e500_ops::fetch_registers)
9676         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9677         (ppc_ravenscar_e500_ops): Redefine.
9678         * aarch64-ravenscar-thread.c
9679         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9680         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9681         (aarch64_ravenscar_fetch_registers)
9682         (aarch64_ravenscar_store_registers): Now methods.
9683         (aarch64_ravenscar_ops): Redefine.
9684
9685 2019-02-15  Tom Tromey  <tromey@adacore.com>
9686
9687         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9688         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9689         (ravenscar_thread_target::stopped_by_watchpoint)
9690         (ravenscar_thread_target::stopped_data_address)
9691         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9692
9693 2019-02-15  Tom Tromey  <tromey@adacore.com>
9694
9695         * ravenscar-thread.c: Fix some typos.
9696
9697 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9698             Tom Tromey  <tromey@adacore.com>
9699
9700         * ada-lang.c (ada_exception_sal): Change addr_string to a
9701         std::string.
9702         (create_ada_exception_catchpoint): Update.
9703
9704 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9705             Tom Tromey  <tromey@adacore.com>
9706
9707         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9708         (bp_location_ops): Remove.
9709         (base_breakpoint_allocate_location): Update.
9710         (free_bp_location): Update.
9711         * ada-lang.c (class ada_catchpoint_location)
9712         <ada_catchpoint_location>: Remove ops parameter.
9713         (ada_catchpoint_location_dtor): Remove.
9714         (ada_catchpoint_location_ops): Remove.
9715         (allocate_location_exception): Update.
9716         * breakpoint.h (struct bp_location_ops): Remove.
9717         (class bp_location) <bp_location>: Remove bp_location_ops
9718         parameter.
9719         <~bp_location>: Add destructor.
9720         <ops>: Remove.
9721
9722 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9723             Pedro Alves  <palves@redhat.com>
9724
9725         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9726         'PATH_MAX'.
9727
9728 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9729             Samuel Thibault  <samuel.thibault@gnu.org>
9730             Thomas Schwinge  <thomas@codesourcery.com>
9731
9732         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9733         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9734
9735 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9736
9737         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9738         (check_empty): Use "const char *".
9739
9740         * gnu-nat.c (gnu_nat_target::detach): Instead of
9741         'detach_inferior (pid)' call
9742         'detach_inferior (find_inferior_pid (pid))'.
9743
9744         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9745         'nat/fork-inferior.o'.
9746         * gnu-nat.c: #include "nat/fork-inferior.h".
9747
9748         * gnu-nat.c (gnu_nat_target::detach): Instead of
9749         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9750         * gnu-nat.h: #include "inf-child.h".
9751         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9752         'i386_gnu_nat_target::fetch_registers'.
9753         (gnu_store_registers): Rename/move to
9754         'i386_gnu_nat_target::store_registers'.
9755
9756         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9757         * gnu-nat.h (mach_thread_info): New function.
9758         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9759
9760         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9761
9762 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9763
9764         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9765
9766 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9767
9768         * windows-nat.c (windows_add_thread): Add new parameter
9769         "main_thread_p" with default value set to false.  Update
9770         function documentation as well as all callers.
9771         (windows_delete_thread): Likewise.
9772         (fake_create_process): Update call to windows_add_thread.
9773         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9774         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9775         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9776         call to windows_delete_thread.
9777
9778 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9779
9780         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9781
9782 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9783
9784         * symfile.c (find_separate_debug_file): Use canonical path of
9785         sysroot with child_path instead of gdb_sysroot if it is valid.
9786
9787 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9788
9789         * symfile.c (find_separate_debug_file): Use child_path to
9790         determine if an object file is under a sysroot.
9791
9792 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9793
9794         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9795         unittests/child-path-selftests.c.
9796         * common/pathstuff.c (child_path): New function.
9797         * common/pathstuff.h (child_path): New prototype.
9798         * unittests/child-path-selftests.c: New file.
9799
9800 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9801
9802         * symfile.c (find_separate_debug_file): Look for separate debug
9803         files in debug directories under the sysroot.
9804
9805 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9806
9807         * symtab.h (struct minimal_symbol data_p): New const method.
9808         (struct minimal_symbol text_p): Likewise.
9809         * symtab.c (output_source_filename): Use file name style
9810         to print file name.
9811         (print_symbol_info): Likewise.
9812         (print_msymbol_info): Use address style to print addresses.
9813         Use function name style to print executable text symbols.
9814         (expand_symtab_containing_pc): Use data_p.
9815         (find_pc_sect_compunit_symtab): Likewise.
9816
9817 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9818
9819         * breakpoint.c (describe_other_breakpoints): Use address style
9820         to print addresses.
9821         (say_where): Likewise.
9822
9823 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9824
9825         * ada-typeprint.c (print_func_type): Print function name
9826         style to print function name.
9827         * c-typeprint.c (c_print_type_1): Likewise.
9828
9829 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9830
9831         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9832         for execve.
9833
9834 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9835
9836         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9837         type_stack.
9838
9839 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9840
9841         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9842         TYPE_CODE_REF types.
9843
9844 2019-02-08  Jim Wilson  <jimw@sifive.com>
9845
9846         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9847         (riscv_linux_fregset): New.
9848         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9849
9850 2019-02-07  Tom Tromey  <tom@tromey.com>
9851
9852         * thread.c (thread_cancel_execution_command): Update.
9853         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9854         methods.
9855         (struct thread_fsm_ops): Remove.
9856         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9857         (thread_fsm_should_stop, thread_fsm_return_value)
9858         (thread_fsm_set_finished, thread_fsm_finished_p)
9859         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9860         Don't declare.
9861         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9862         * infrun.c (clear_proceed_status_thread)
9863         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9864         (print_stop_event): Update.
9865         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9866         Add constructor.
9867         (step_command_fsm_ops): Remove.
9868         (new_step_command_fsm): Remove.
9869         (step_1): Update.
9870         (step_command_fsm::should_stop): Rename from
9871         step_command_fsm_should_stop.
9872         (step_command_fsm::clean_up): Rename from
9873         step_command_fsm_clean_up.
9874         (step_command_fsm::do_async_reply_reason): Rename from
9875         step_command_fsm_async_reply_reason.
9876         (struct until_next_fsm): Inherit from thread_fsm.  Add
9877         constructor.
9878         (until_next_fsm_ops): Remove.
9879         (new_until_next_fsm): Remove.
9880         (until_next_fsm::should_stop): Rename from
9881         until_next_fsm_should_stop.
9882         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9883         (until_next_fsm::do_async_reply_reason): Rename from
9884         until_next_fsm_async_reply_reason.
9885         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9886         constructor.  Change type of breakpoint.
9887         (finish_command_fsm_ops): Remove.
9888         (new_finish_command_fsm): Remove.
9889         (finish_command_fsm::should_stop): Rename from
9890         finish_command_fsm_should_stop.
9891         (finish_command_fsm::clean_up): Rename from
9892         finish_command_fsm_clean_up.
9893         (finish_command_fsm::return_value): Rename from
9894         finish_command_fsm_return_value.
9895         (finish_command_fsm::do_async_reply_reason): Rename from
9896         finish_command_fsm_async_reply_reason.
9897         (finish_command): Update.
9898         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9899         Add constructor.
9900         (call_thread_fsm_ops): Remove.
9901         (call_thread_fsm::call_thread_fsm): Rename from
9902         new_call_thread_fsm.
9903         (call_thread_fsm::should_stop): Rename from
9904         call_thread_fsm_should_stop.
9905         (call_thread_fsm::should_notify_stop): Rename from
9906         call_thread_fsm_should_notify_stop.
9907         (run_inferior_call, call_function_by_hand_dummy): Update.
9908         * cli/cli-interp.c (should_print_stop_to_console): Update.
9909         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9910         Add constructor.  Change type of location_breakpoint,
9911         caller_breakpoint.
9912         (until_break_fsm_ops): Remove.
9913         (new_until_break_fsm): Remove.
9914         (until_break_fsm::should_stop): Rename from
9915         until_break_fsm_should_stop.
9916         (until_break_fsm::clean_up): Rename from
9917         until_break_fsm_clean_up.
9918         (until_break_fsm::do_async_reply_reason): Rename from
9919         until_break_fsm_async_reply_reason.
9920         (until_break_command): Update.
9921         * thread-fsm.c: Remove.
9922         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9923
9924 2019-02-07  Tom Tromey  <tom@tromey.com>
9925
9926         * yy-remap.h: Add include guard.
9927         * xtensa-tdep.h: Add include guard.
9928         * xcoffread.h: Rename include guard.
9929         * varobj-iter.h: Add include guard.
9930         * tui/tui.h: Rename include guard.
9931         * tui/tui-winsource.h: Rename include guard.
9932         * tui/tui-wingeneral.h: Rename include guard.
9933         * tui/tui-windata.h: Rename include guard.
9934         * tui/tui-win.h: Rename include guard.
9935         * tui/tui-stack.h: Rename include guard.
9936         * tui/tui-source.h: Rename include guard.
9937         * tui/tui-regs.h: Rename include guard.
9938         * tui/tui-out.h: Rename include guard.
9939         * tui/tui-layout.h: Rename include guard.
9940         * tui/tui-io.h: Rename include guard.
9941         * tui/tui-hooks.h: Rename include guard.
9942         * tui/tui-file.h: Rename include guard.
9943         * tui/tui-disasm.h: Rename include guard.
9944         * tui/tui-data.h: Rename include guard.
9945         * tui/tui-command.h: Rename include guard.
9946         * tic6x-tdep.h: Add include guard.
9947         * target/waitstatus.h: Rename include guard.
9948         * target/wait.h: Rename include guard.
9949         * target/target.h: Rename include guard.
9950         * target/resume.h: Rename include guard.
9951         * target-float.h: Rename include guard.
9952         * stabsread.h: Add include guard.
9953         * rs6000-tdep.h: Add include guard.
9954         * riscv-fbsd-tdep.h: Add include guard.
9955         * regformats/regdef.h: Rename include guard.
9956         * record.h: Rename include guard.
9957         * python/python.h: Rename include guard.
9958         * python/python-internal.h: Rename include guard.
9959         * python/py-stopevent.h: Rename include guard.
9960         * python/py-ref.h: Rename include guard.
9961         * python/py-record.h: Rename include guard.
9962         * python/py-record-full.h: Rename include guard.
9963         * python/py-record-btrace.h: Rename include guard.
9964         * python/py-instruction.h: Rename include guard.
9965         * python/py-events.h: Rename include guard.
9966         * python/py-event.h: Rename include guard.
9967         * procfs.h: Add include guard.
9968         * proc-utils.h: Add include guard.
9969         * p-lang.h: Add include guard.
9970         * or1k-tdep.h: Rename include guard.
9971         * observable.h: Rename include guard.
9972         * nto-tdep.h: Rename include guard.
9973         * nat/x86-linux.h: Rename include guard.
9974         * nat/x86-linux-dregs.h: Rename include guard.
9975         * nat/x86-gcc-cpuid.h: Add include guard.
9976         * nat/x86-dregs.h: Rename include guard.
9977         * nat/x86-cpuid.h: Rename include guard.
9978         * nat/ppc-linux.h: Rename include guard.
9979         * nat/mips-linux-watch.h: Rename include guard.
9980         * nat/linux-waitpid.h: Rename include guard.
9981         * nat/linux-ptrace.h: Rename include guard.
9982         * nat/linux-procfs.h: Rename include guard.
9983         * nat/linux-osdata.h: Rename include guard.
9984         * nat/linux-nat.h: Rename include guard.
9985         * nat/linux-namespaces.h: Rename include guard.
9986         * nat/linux-btrace.h: Rename include guard.
9987         * nat/glibc_thread_db.h: Rename include guard.
9988         * nat/gdb_thread_db.h: Rename include guard.
9989         * nat/gdb_ptrace.h: Rename include guard.
9990         * nat/fork-inferior.h: Rename include guard.
9991         * nat/amd64-linux-siginfo.h: Rename include guard.
9992         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9993         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9994         * nat/aarch64-linux.h: Rename include guard.
9995         * nat/aarch64-linux-hw-point.h: Rename include guard.
9996         * mn10300-tdep.h: Add include guard.
9997         * mips-linux-tdep.h: Add include guard.
9998         * mi/mi-parse.h: Rename include guard.
9999         * mi/mi-out.h: Rename include guard.
10000         * mi/mi-main.h: Rename include guard.
10001         * mi/mi-interp.h: Rename include guard.
10002         * mi/mi-getopt.h: Rename include guard.
10003         * mi/mi-console.h: Rename include guard.
10004         * mi/mi-common.h: Rename include guard.
10005         * mi/mi-cmds.h: Rename include guard.
10006         * mi/mi-cmd-break.h: Rename include guard.
10007         * m2-lang.h: Add include guard.
10008         * location.h: Rename include guard.
10009         * linux-record.h: Rename include guard.
10010         * linux-nat.h: Add include guard.
10011         * linux-fork.h: Add include guard.
10012         * i386-darwin-tdep.h: Rename include guard.
10013         * hppa-linux-offsets.h: Add include guard.
10014         * guile/guile.h: Rename include guard.
10015         * guile/guile-internal.h: Rename include guard.
10016         * gnu-nat.h: Rename include guard.
10017         * gdb-stabs.h: Rename include guard.
10018         * frv-tdep.h: Add include guard.
10019         * f-lang.h: Add include guard.
10020         * event-loop.h: Add include guard.
10021         * darwin-nat.h: Rename include guard.
10022         * cp-abi.h: Rename include guard.
10023         * config/sparc/nm-sol2.h: Rename include guard.
10024         * config/nm-nto.h: Rename include guard.
10025         * config/nm-linux.h: Add include guard.
10026         * config/i386/nm-i386gnu.h: Rename include guard.
10027         * config/djgpp/nl_types.h: Rename include guard.
10028         * config/djgpp/langinfo.h: Rename include guard.
10029         * compile/gcc-cp-plugin.h: Add include guard.
10030         * compile/gcc-c-plugin.h: Add include guard.
10031         * compile/compile.h: Rename include guard.
10032         * compile/compile-object-run.h: Rename include guard.
10033         * compile/compile-object-load.h: Rename include guard.
10034         * compile/compile-internal.h: Rename include guard.
10035         * compile/compile-cplus.h: Rename include guard.
10036         * compile/compile-c.h: Rename include guard.
10037         * common/xml-utils.h: Rename include guard.
10038         * common/x86-xstate.h: Rename include guard.
10039         * common/version.h: Rename include guard.
10040         * common/vec.h: Rename include guard.
10041         * common/tdesc.h: Rename include guard.
10042         * common/selftest.h: Rename include guard.
10043         * common/scoped_restore.h: Rename include guard.
10044         * common/scoped_mmap.h: Rename include guard.
10045         * common/scoped_fd.h: Rename include guard.
10046         * common/safe-iterator.h: Rename include guard.
10047         * common/run-time-clock.h: Rename include guard.
10048         * common/refcounted-object.h: Rename include guard.
10049         * common/queue.h: Rename include guard.
10050         * common/ptid.h: Rename include guard.
10051         * common/print-utils.h: Rename include guard.
10052         * common/preprocessor.h: Rename include guard.
10053         * common/pathstuff.h: Rename include guard.
10054         * common/observable.h: Rename include guard.
10055         * common/netstuff.h: Rename include guard.
10056         * common/job-control.h: Rename include guard.
10057         * common/host-defs.h: Rename include guard.
10058         * common/gdb_wait.h: Rename include guard.
10059         * common/gdb_vecs.h: Rename include guard.
10060         * common/gdb_unlinker.h: Rename include guard.
10061         * common/gdb_unique_ptr.h: Rename include guard.
10062         * common/gdb_tilde_expand.h: Rename include guard.
10063         * common/gdb_sys_time.h: Rename include guard.
10064         * common/gdb_string_view.h: Rename include guard.
10065         * common/gdb_splay_tree.h: Rename include guard.
10066         * common/gdb_setjmp.h: Rename include guard.
10067         * common/gdb_ref_ptr.h: Rename include guard.
10068         * common/gdb_optional.h: Rename include guard.
10069         * common/gdb_locale.h: Rename include guard.
10070         * common/gdb_assert.h: Rename include guard.
10071         * common/filtered-iterator.h: Rename include guard.
10072         * common/filestuff.h: Rename include guard.
10073         * common/fileio.h: Rename include guard.
10074         * common/environ.h: Rename include guard.
10075         * common/common-utils.h: Rename include guard.
10076         * common/common-types.h: Rename include guard.
10077         * common/common-regcache.h: Rename include guard.
10078         * common/common-inferior.h: Rename include guard.
10079         * common/common-gdbthread.h: Rename include guard.
10080         * common/common-exceptions.h: Rename include guard.
10081         * common/common-defs.h: Rename include guard.
10082         * common/common-debug.h: Rename include guard.
10083         * common/cleanups.h: Rename include guard.
10084         * common/buffer.h: Rename include guard.
10085         * common/btrace-common.h: Rename include guard.
10086         * common/break-common.h: Rename include guard.
10087         * cli/cli-utils.h: Rename include guard.
10088         * cli/cli-style.h: Rename include guard.
10089         * cli/cli-setshow.h: Rename include guard.
10090         * cli/cli-script.h: Rename include guard.
10091         * cli/cli-interp.h: Rename include guard.
10092         * cli/cli-decode.h: Rename include guard.
10093         * cli/cli-cmds.h: Rename include guard.
10094         * charset-list.h: Add include guard.
10095         * buildsym-legacy.h: Rename include guard.
10096         * bfin-tdep.h: Add include guard.
10097         * ax.h: Rename include guard.
10098         * arm-linux-tdep.h: Add include guard.
10099         * arm-fbsd-tdep.h: Add include guard.
10100         * arch/xtensa.h: Rename include guard.
10101         * arch/tic6x.h: Add include guard.
10102         * arch/i386.h: Add include guard.
10103         * arch/arm.h: Rename include guard.
10104         * arch/arm-linux.h: Rename include guard.
10105         * arch/arm-get-next-pcs.h: Rename include guard.
10106         * arch/amd64.h: Add include guard.
10107         * arch/aarch64-insn.h: Rename include guard.
10108         * arch-utils.h: Rename include guard.
10109         * annotate.h: Add include guard.
10110         * amd64-darwin-tdep.h: Rename include guard.
10111         * aarch64-linux-tdep.h: Add include guard.
10112         * aarch64-fbsd-tdep.h: Add include guard.
10113         * aarch32-linux-nat.h: Add include guard.
10114
10115 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10116
10117         * macrotab.c (macro_define_internal): New function that
10118         factorizes macro_define_object_internal and macro_define_function
10119         code.
10120         (macro_define_object_internal): Use macro_define_internal.
10121         (macro_define_function): Likewise.
10122
10123 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10124
10125         * macrocmd.c (extract_identifier): Return
10126         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10127         callers.
10128
10129 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10130
10131         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10132
10133 2019-02-05  Tom Tromey  <tom@tromey.com>
10134
10135         * target.c (target_stack::unpush): Move assertion earlier.
10136
10137 2019-01-30  Tom Tromey  <tom@tromey.com>
10138
10139         PR python/23615:
10140         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10141         (gdbpy_parse_and_eval): Likewise.
10142         * python/python-internal.h (gdbpy_allow_threads): New class.
10143
10144 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10145
10146         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10147         (aarch64_fbsd_fpregmap): Move earlier.
10148         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10149         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10150         instead of individual calls to trad_frame_set_reg_addr.
10151         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10152         earlier.
10153         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10154         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10155         instead of individual calls to trad_frame_set_reg_addr.
10156
10157 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10158
10159         * CONTRIBUTE: Replace contribution list with wiki link.
10160
10161 2019-01-25  Tom Tromey  <tom@tromey.com>
10162
10163         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10164
10165 2019-01-25  Tom Tromey  <tom@tromey.com>
10166
10167         * xtensa-linux-nat.c: Fix common/ includes.
10168         * xml-support.h: Fix common/ includes.
10169         * xml-support.c: Fix common/ includes.
10170         * x86-linux-nat.c: Fix common/ includes.
10171         * windows-nat.c: Fix common/ includes.
10172         * varobj.h: Fix common/ includes.
10173         * varobj.c: Fix common/ includes.
10174         * value.c: Fix common/ includes.
10175         * valops.c: Fix common/ includes.
10176         * utils.c: Fix common/ includes.
10177         * unittests/xml-utils-selftests.c: Fix common/ includes.
10178         * unittests/utils-selftests.c: Fix common/ includes.
10179         * unittests/unpack-selftests.c: Fix common/ includes.
10180         * unittests/tracepoint-selftests.c: Fix common/ includes.
10181         * unittests/style-selftests.c: Fix common/ includes.
10182         * unittests/string_view-selftests.c: Fix common/ includes.
10183         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10184         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10185         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10186         * unittests/rsp-low-selftests.c: Fix common/ includes.
10187         * unittests/parse-connection-spec-selftests.c: Fix common/
10188         includes.
10189         * unittests/optional-selftests.c: Fix common/ includes.
10190         * unittests/offset-type-selftests.c: Fix common/ includes.
10191         * unittests/observable-selftests.c: Fix common/ includes.
10192         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10193         * unittests/memrange-selftests.c: Fix common/ includes.
10194         * unittests/memory-map-selftests.c: Fix common/ includes.
10195         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10196         * unittests/function-view-selftests.c: Fix common/ includes.
10197         * unittests/environ-selftests.c: Fix common/ includes.
10198         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10199         * unittests/common-utils-selftests.c: Fix common/ includes.
10200         * unittests/cli-utils-selftests.c: Fix common/ includes.
10201         * unittests/array-view-selftests.c: Fix common/ includes.
10202         * ui-file.c: Fix common/ includes.
10203         * tui/tui-io.c: Fix common/ includes.
10204         * tracepoint.h: Fix common/ includes.
10205         * tracepoint.c: Fix common/ includes.
10206         * tracefile-tfile.c: Fix common/ includes.
10207         * top.h: Fix common/ includes.
10208         * top.c: Fix common/ includes.
10209         * thread.c: Fix common/ includes.
10210         * target/waitstatus.h: Fix common/ includes.
10211         * target/waitstatus.c: Fix common/ includes.
10212         * target.h: Fix common/ includes.
10213         * target.c: Fix common/ includes.
10214         * target-memory.c: Fix common/ includes.
10215         * target-descriptions.c: Fix common/ includes.
10216         * symtab.h: Fix common/ includes.
10217         * symfile.c: Fix common/ includes.
10218         * stap-probe.c: Fix common/ includes.
10219         * spu-linux-nat.c: Fix common/ includes.
10220         * sparc-nat.c: Fix common/ includes.
10221         * source.c: Fix common/ includes.
10222         * solib.c: Fix common/ includes.
10223         * solib-target.c: Fix common/ includes.
10224         * ser-unix.c: Fix common/ includes.
10225         * ser-tcp.c: Fix common/ includes.
10226         * ser-pipe.c: Fix common/ includes.
10227         * ser-base.c: Fix common/ includes.
10228         * selftest-arch.c: Fix common/ includes.
10229         * s12z-tdep.c: Fix common/ includes.
10230         * rust-exp.y: Fix common/ includes.
10231         * rs6000-aix-tdep.c: Fix common/ includes.
10232         * riscv-tdep.c: Fix common/ includes.
10233         * remote.c: Fix common/ includes.
10234         * remote-notif.h: Fix common/ includes.
10235         * remote-fileio.h: Fix common/ includes.
10236         * remote-fileio.c: Fix common/ includes.
10237         * regcache.h: Fix common/ includes.
10238         * regcache.c: Fix common/ includes.
10239         * record-btrace.c: Fix common/ includes.
10240         * python/python.c: Fix common/ includes.
10241         * python/py-type.c: Fix common/ includes.
10242         * python/py-inferior.c: Fix common/ includes.
10243         * progspace.h: Fix common/ includes.
10244         * producer.c: Fix common/ includes.
10245         * procfs.c: Fix common/ includes.
10246         * proc-api.c: Fix common/ includes.
10247         * printcmd.c: Fix common/ includes.
10248         * ppc-linux-nat.c: Fix common/ includes.
10249         * parser-defs.h: Fix common/ includes.
10250         * osdata.c: Fix common/ includes.
10251         * obsd-nat.c: Fix common/ includes.
10252         * nat/x86-linux.c: Fix common/ includes.
10253         * nat/x86-linux-dregs.c: Fix common/ includes.
10254         * nat/x86-dregs.h: Fix common/ includes.
10255         * nat/x86-dregs.c: Fix common/ includes.
10256         * nat/ppc-linux.c: Fix common/ includes.
10257         * nat/mips-linux-watch.h: Fix common/ includes.
10258         * nat/mips-linux-watch.c: Fix common/ includes.
10259         * nat/linux-waitpid.c: Fix common/ includes.
10260         * nat/linux-ptrace.h: Fix common/ includes.
10261         * nat/linux-ptrace.c: Fix common/ includes.
10262         * nat/linux-procfs.c: Fix common/ includes.
10263         * nat/linux-personality.c: Fix common/ includes.
10264         * nat/linux-osdata.c: Fix common/ includes.
10265         * nat/linux-namespaces.c: Fix common/ includes.
10266         * nat/linux-btrace.h: Fix common/ includes.
10267         * nat/linux-btrace.c: Fix common/ includes.
10268         * nat/fork-inferior.c: Fix common/ includes.
10269         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10270         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10271         * nat/aarch64-linux.c: Fix common/ includes.
10272         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10273         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10274         * namespace.h: Fix common/ includes.
10275         * mips-linux-tdep.c: Fix common/ includes.
10276         * minsyms.c: Fix common/ includes.
10277         * mi/mi-parse.h: Fix common/ includes.
10278         * mi/mi-main.c: Fix common/ includes.
10279         * mi/mi-cmd-env.c: Fix common/ includes.
10280         * memrange.h: Fix common/ includes.
10281         * memattr.c: Fix common/ includes.
10282         * maint.h: Fix common/ includes.
10283         * maint.c: Fix common/ includes.
10284         * main.c: Fix common/ includes.
10285         * machoread.c: Fix common/ includes.
10286         * location.c: Fix common/ includes.
10287         * linux-thread-db.c: Fix common/ includes.
10288         * linux-nat.c: Fix common/ includes.
10289         * linux-fork.c: Fix common/ includes.
10290         * inline-frame.c: Fix common/ includes.
10291         * infrun.c: Fix common/ includes.
10292         * inflow.c: Fix common/ includes.
10293         * inferior.h: Fix common/ includes.
10294         * inferior.c: Fix common/ includes.
10295         * infcmd.c: Fix common/ includes.
10296         * inf-ptrace.c: Fix common/ includes.
10297         * inf-child.c: Fix common/ includes.
10298         * ia64-linux-nat.c: Fix common/ includes.
10299         * i387-tdep.c: Fix common/ includes.
10300         * i386-tdep.c: Fix common/ includes.
10301         * i386-linux-tdep.c: Fix common/ includes.
10302         * i386-linux-nat.c: Fix common/ includes.
10303         * i386-go32-tdep.c: Fix common/ includes.
10304         * i386-fbsd-tdep.c: Fix common/ includes.
10305         * i386-fbsd-nat.c: Fix common/ includes.
10306         * guile/scm-type.c: Fix common/ includes.
10307         * guile/guile.c: Fix common/ includes.
10308         * go32-nat.c: Fix common/ includes.
10309         * gnu-nat.c: Fix common/ includes.
10310         * gdbthread.h: Fix common/ includes.
10311         * gdbarch-selftests.c: Fix common/ includes.
10312         * gdb_usleep.c: Fix common/ includes.
10313         * gdb_select.h: Fix common/ includes.
10314         * gdb_bfd.c: Fix common/ includes.
10315         * gcore.c: Fix common/ includes.
10316         * fork-child.c: Fix common/ includes.
10317         * findvar.c: Fix common/ includes.
10318         * fbsd-nat.c: Fix common/ includes.
10319         * event-top.c: Fix common/ includes.
10320         * event-loop.c: Fix common/ includes.
10321         * dwarf2read.c: Fix common/ includes.
10322         * dwarf2loc.c: Fix common/ includes.
10323         * dwarf2-frame.c: Fix common/ includes.
10324         * dwarf-index-cache.c: Fix common/ includes.
10325         * dtrace-probe.c: Fix common/ includes.
10326         * disasm-selftests.c: Fix common/ includes.
10327         * defs.h: Fix common/ includes.
10328         * csky-tdep.c: Fix common/ includes.
10329         * cp-valprint.c: Fix common/ includes.
10330         * cp-support.h: Fix common/ includes.
10331         * cp-support.c: Fix common/ includes.
10332         * corelow.c: Fix common/ includes.
10333         * completer.h: Fix common/ includes.
10334         * completer.c: Fix common/ includes.
10335         * compile/compile.c: Fix common/ includes.
10336         * compile/compile-loc2c.c: Fix common/ includes.
10337         * compile/compile-cplus-types.c: Fix common/ includes.
10338         * compile/compile-cplus-symbols.c: Fix common/ includes.
10339         * command.h: Fix common/ includes.
10340         * cli/cli-dump.c: Fix common/ includes.
10341         * cli/cli-cmds.c: Fix common/ includes.
10342         * charset.c: Fix common/ includes.
10343         * build-id.c: Fix common/ includes.
10344         * btrace.h: Fix common/ includes.
10345         * btrace.c: Fix common/ includes.
10346         * breakpoint.h: Fix common/ includes.
10347         * breakpoint.c: Fix common/ includes.
10348         * ax.h:
10349         (enum agent_op): Fix common/ includes.
10350         * ax-general.c (struct aop_map): Fix common/ includes.
10351         * ax-gdb.c: Fix common/ includes.
10352         * auxv.c: Fix common/ includes.
10353         * auto-load.c: Fix common/ includes.
10354         * arm-tdep.c: Fix common/ includes.
10355         * arch/riscv.c: Fix common/ includes.
10356         * arch/ppc-linux-common.c: Fix common/ includes.
10357         * arch/i386.c: Fix common/ includes.
10358         * arch/arm.c: Fix common/ includes.
10359         * arch/arm-linux.c: Fix common/ includes.
10360         * arch/arm-get-next-pcs.c: Fix common/ includes.
10361         * arch/amd64.c: Fix common/ includes.
10362         * arch/aarch64.c: Fix common/ includes.
10363         * arch/aarch64-insn.c: Fix common/ includes.
10364         * arch-utils.c: Fix common/ includes.
10365         * amd64-windows-tdep.c: Fix common/ includes.
10366         * amd64-tdep.c: Fix common/ includes.
10367         * amd64-sol2-tdep.c: Fix common/ includes.
10368         * amd64-obsd-tdep.c: Fix common/ includes.
10369         * amd64-nbsd-tdep.c: Fix common/ includes.
10370         * amd64-linux-tdep.c: Fix common/ includes.
10371         * amd64-linux-nat.c: Fix common/ includes.
10372         * amd64-fbsd-tdep.c: Fix common/ includes.
10373         * amd64-fbsd-nat.c: Fix common/ includes.
10374         * amd64-dicos-tdep.c: Fix common/ includes.
10375         * amd64-darwin-tdep.c: Fix common/ includes.
10376         * agent.c: Fix common/ includes.
10377         * ada-lang.h: Fix common/ includes.
10378         * ada-lang.c: Fix common/ includes.
10379         * aarch64-tdep.c: Fix common/ includes.
10380
10381 2019-01-25  Tom Tromey  <tom@tromey.com>
10382
10383         * common/create-version.sh: Use common/version.h.
10384
10385 2019-01-24  Pedro Alves  <palves@redhat.com>
10386
10387         * infrun.c (signal_stop, signal_print, signal_program)
10388         (signal_catch, signal_pass): Now arrays instead of pointers.
10389         (update_signals_program_target, do_target_resume)
10390         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10391         * linux-nat.c (linux_nat_target::pass_signals)
10392         (linux_nat_target::create_inferior, linux_nat_target::attach):
10393         Adjust.
10394         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10395         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10396         * procfs.c (procfs_target::pass_signals): Adjust.
10397         * record-full.c (record_full_target::resume): Adjust.
10398         * remote.c (remote_target::pass_signals)
10399         (remote_target::program_signals): Adjust.
10400         * target-debug.h (target_debug_print_signals): Now takes a
10401         gdb::array_view as parameter.  Adjust.
10402         * target.h (target_ops) <pass_signals, program_signals>: Replace
10403         pointer and length parameters with gdb::array_view.
10404         (target_pass_signals, target_program_signals): Likewise.
10405         * target-delegates.c: Regenerate.
10406
10407 2019-01-24  Pedro Alves  <palves@redhat.com>
10408
10409         * common/forward-scope-exit.h
10410         (forward_scope_exit::forward_scope_exit): Pass arguments to
10411         m_bind_function directly, instead of creating a std::bind and
10412         copying that.
10413
10414 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10415
10416         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10417         for static members.
10418         (pass_in_v_vfp_candidate): Likewise.
10419
10420 2019-01-23  Tom Tromey  <tom@tromey.com>
10421             Pedro Alves  <palves@redhat.com>
10422
10423         * regcache.c (class regcache_invalidator): Remove.
10424         (regcache::raw_write): Use make_scope_exit.
10425
10426 2019-01-23  Tom Tromey  <tom@tromey.com>
10427
10428         * ui-out.h (class ui_out_emit_type): Update comment.
10429
10430 2019-01-23  Tom Tromey  <tom@tromey.com>
10431
10432         * infrun.c (fetch_inferior_event): Update comment.
10433
10434 2019-01-23  Tom Tromey  <tom@tromey.com>
10435             Pedro Alves  <palves@redhat.com>
10436
10437         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10438         parameter.
10439         (fetch_inferior_event): Use SCOPE_EXIT.
10440
10441
10442 2019-01-23  Tom Tromey  <tom@tromey.com>
10443             Pedro Alves  <palves@redhat.com>
10444
10445         * infrun.c (disable_thread_events): Delete.
10446         (stop_all_threads): Use SCOPE_EXIT.
10447
10448 2019-01-23  Tom Tromey  <tom@tromey.com>
10449             Pedro Alves  <palves@redhat.com>
10450
10451         * symfile.c: Include forward-scope-exit.h.
10452         (clear_symtab_users_cleanup): Replace forward declaration with
10453         a FORWARD_SCOPE_EXIT.
10454         (syms_from_objfile_1): Use the forward_scope_exit and
10455         gdb::optional instead of cleanup_function.
10456         (reread_symbols): Use the forward_scope_exit instead of
10457         cleanup_function.
10458         (clear_symtab_users_cleanup): Remove function.
10459
10460 2019-01-23  Tom Tromey  <tom@tromey.com>
10461             Pedro Alves  <palves@redhat.com>
10462
10463         * linux-nat.c: Include scope-exit.h.
10464         (cleanup_target_stop): Remove.
10465         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10466         SCOPE_EXIT.
10467
10468 2019-01-23  Tom Tromey  <tom@tromey.com>
10469             Pedro Alves  <palves@redhat.com>
10470
10471         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10472         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10473
10474 2019-01-23  Tom Tromey  <tom@tromey.com>
10475             Andrew Burgess  <andrew.burgess@embecosm.com>
10476             Pedro Alves  <palves@redhat.com>
10477
10478         * infrun.c (fetch_inferior_event): Use scope_exit.
10479         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10480         * top.c (execute_command): Use scope_exit.
10481         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10482         * utils.c (do_bpstat_clear_actions_cleanup)
10483         (make_bpstat_clear_actions_cleanup): Remove.
10484
10485 2019-01-23  Tom Tromey  <tom@tromey.com>
10486             Pedro Alves  <palves@redhat.com>
10487
10488         * infrun.c: Include "common/scope-exit.h"
10489         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10490         (wait_for_inferior): Use SCOPE_EXIT.
10491         (fetch_inferior_event): Use scope_exit.
10492
10493 2019-01-23  Tom Tromey  <tom@tromey.com>
10494             Pedro Alves  <palves@redhat.com>
10495
10496         * breakpoint.c (create_breakpoint): Remove cleanup.
10497
10498 2019-01-23  Tom Tromey  <tom@tromey.com>
10499             Andrew Burgess  <andrew.burgess@embecosm.com>
10500             Pedro Alves  <palves@redhat.com>
10501
10502 2019-01-23  Pedro Alves  <palves@redhat.com>
10503
10504         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10505
10506 2019-01-23  Pedro Alves  <palves@redhat.com>
10507             Andrew Burgess  <andrew.burgess@embecosm.com>
10508
10509         * gdbthread.h: Include "common/forward-scope-exit.h".
10510         (scoped_finish_thread_state): Redefine custom class in terms of
10511         forward_scope_exit.
10512
10513 2019-01-23  Pedro Alves  <palves@redhat.com>
10514             Andrew Burgess  <andrew.burgess@embecosm.com>
10515
10516         * common/forward-scope-exit.h: New file.
10517
10518 2019-01-23  Pedro Alves  <palves@redhat.com>
10519             Andrew Burgess  <andrew.burgess@embecosm.com>
10520             Tom Tromey  <tom@tromey.com>
10521
10522         * common/scope-exit.h: New file.
10523
10524 2019-01-23  Pedro Alves  <palves@redhat.com>
10525
10526         * common/preprocessor.h (ESC): Rename to ...
10527         (ESC_PARENS): ... this.
10528         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10529         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10530
10531 2019-01-23  Tom Tromey  <tom@tromey.com>
10532
10533         * language.h (class scoped_switch_to_sym_language_if_auto):
10534         Initialize m_lang in both cases.
10535
10536 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10537
10538         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10539         with XCNEW.
10540
10541 2019-01-22  Tom Tromey  <tom@tromey.com>
10542
10543         * corelow.c: Do not include sys/file.h.
10544
10545 2019-01-22  Tom Tromey  <tom@tromey.com>
10546
10547         * tui/tui-wingeneral.h: Include gdb_curses.h.
10548
10549 2019-01-22  Tom Tromey  <tom@tromey.com>
10550
10551         * source-cache.h (class source_cache) <get_source_lines,
10552         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10553
10554 2019-01-22  Tom Tromey  <tom@tromey.com>
10555
10556         * remote-fileio.h (struct remote_target): Declare.
10557
10558 2019-01-22  Tom Tromey  <tom@tromey.com>
10559
10560         * python/py-arch.c: Do not include py-ref.h.
10561         * python/py-bpevent.c: Do not include py-ref.h.
10562         * python/py-cmd.c: Do not include py-ref.h.
10563         * python/py-continueevent.c: Do not include py-ref.h.
10564         * python/py-event.h: Do not include py-ref.h.
10565         * python/py-evtregistry.c: Do not include py-ref.h.
10566         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10567         * python/py-frame.c: Do not include py-ref.h.
10568         * python/py-framefilter.c: Do not include py-ref.h.
10569         * python/py-function.c: Do not include py-ref.h.
10570         * python/py-infevents.c: Do not include py-ref.h.
10571         * python/py-linetable.c: Do not include py-ref.h.
10572         * python/py-objfile.c: Do not include py-ref.h.
10573         * python/py-param.c: Do not include py-ref.h.
10574         * python/py-prettyprint.c: Do not include py-ref.h.
10575         * python/py-progspace.c: Do not include py-ref.h.
10576         * python/py-symbol.c: Do not include py-ref.h.
10577         * python/py-symtab.c: Do not include py-ref.h.
10578         * python/py-type.c: Do not include py-ref.h.
10579         * python/py-unwind.c: Do not include py-ref.h.
10580         * python/py-utils.c: Do not include py-ref.h.
10581         * python/py-value.c: Do not include py-ref.h.
10582         * python/py-varobj.c: Do not include py-ref.h.
10583         * python/py-xmethods.c: Do not include py-ref.h.
10584         * python/python.c: Do not include py-ref.h.
10585         * varobj.c: Do not include py-ref.h.
10586
10587 2019-01-22  Tom Tromey  <tom@tromey.com>
10588
10589         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10590         keyword for bcache.
10591
10592 2019-01-22  Tom Tromey  <tom@tromey.com>
10593
10594         * compile/compile-cplus-types.c: Remove a comment by #include.
10595
10596 2019-01-22  Tom Tromey  <tom@tromey.com>
10597
10598         * compile/gcc-c-plugin.h: Include compile-internal.h.
10599
10600 2019-01-22  Tom Tromey  <tom@tromey.com>
10601
10602         * stabsread.c (EXTERN): Do not define.
10603         (symnum, next_symbol_text_func, processing_gcc_compilation)
10604         (within_function, global_sym_chain, global_stabs)
10605         (previous_stab_code, this_object_header_files)
10606         (n_this_object_header_files)
10607         (n_allocated_this_object_header_files): Define.
10608         * stabsread.h (EXTERN): Never define.  Use "extern".
10609
10610 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10611
10612         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10613         history_value.
10614
10615 2019-01-21  Tom Tromey  <tom@tromey.com>
10616
10617         * ui-out.c: Fix includes.
10618         * tui/tui-source.c: Fix includes.
10619         * target.c: Fix includes.
10620         * remote.c: Fix includes.
10621         * regcache.c: Fix includes.
10622         * python/py-block.c: Fix includes.
10623         * printcmd.c: Fix includes.
10624         * or1k-tdep.c: Fix includes.
10625         * mi/mi-main.c: Fix includes.
10626         * m32r-tdep.c: Fix includes.
10627         * csky-tdep.c: Fix includes.
10628         * compile/compile-cplus-types.c: Fix includes.
10629         * cli/cli-interp.c: Fix includes.
10630
10631 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10632
10633         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10634         for padding.
10635
10636 2019-01-16  Tom Tromey  <tom@tromey.com>
10637
10638         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10639         earlier.
10640         (struct objfile) <msymbols_range>: Move from top level.
10641         <msymbols>: New method.
10642         (class objfile_msymbols): Remove.
10643         * symtab.c (default_collect_symbol_completion_matches_break_on):
10644         Update.
10645         * symmisc.c (dump_msymbols): Update.
10646         * stabsread.c (scan_file_globals): Update.
10647         * objc-lang.c (info_selectors_command, info_classes_command)
10648         (find_methods): Update.
10649         * minsyms.c (find_solib_trampoline_target): Update.
10650         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10651         * coffread.c (coff_symfile_read): Update.
10652         * ada-lang.c (ada_lookup_simple_minsym)
10653         (ada_collect_symbol_completion_matches): Update.
10654
10655 2019-01-16  Tom Tromey  <tom@tromey.com>
10656
10657         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10658         type.  Remove no-argument constructor.
10659         <iterator::operator++>: Simplify.
10660         <begin>: Update.
10661         <end>: Use minimal_symbol_count.
10662
10663 2019-01-16  Tom Tromey  <tom@tromey.com>
10664
10665         * objfiles.h (struct objfile) <psymtabs>: New method.
10666         (class objfile_psymtabs): Remove.
10667         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10668         typedef.
10669         <range>: New method.
10670         (require_partial_symbols): Change return type.
10671         * psymtab.c (require_partial_symbols)
10672         (psym_expand_symtabs_matching): Update.
10673         * mdebugread.c (parse_partial_symbols): Update.
10674         * dbxread.c (dbx_end_psymtab): Update.
10675
10676 2019-01-15  Tom Tromey  <tom@tromey.com>
10677
10678         * symtab.c (lookup_objfile_from_block)
10679         (lookup_symbol_in_objfile_symtabs)
10680         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10681         (find_line_symtab, info_sources_command)
10682         (default_collect_symbol_completion_matches_break_on)
10683         (make_source_files_completion_list): Update.
10684         * symmisc.c (print_objfile_statistics, dump_objfile)
10685         (maintenance_print_symbols, maintenance_info_symtabs)
10686         (maintenance_check_symtabs, maintenance_info_line_tables):
10687         Update.
10688         * source.c (select_source_symtab)
10689         (forget_cached_source_info_for_objfile): Update.
10690         * objfiles.h (class objfile_compunits): Remove.
10691         (struct objfile) <compunits_range>: New typedef.
10692         (compunits): New method.
10693         * objfiles.c (objfile_relocate1): Update.
10694         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10695         * maint.c (count_symtabs_and_blocks): Update.
10696         * linespec.c (iterate_over_all_matching_symtabs): Update.
10697         * cp-support.c (add_symbol_overload_list_qualified): Update.
10698         * coffread.c (coff_symtab_read): Update.
10699         * ada-lang.c (add_nonlocal_symbols)
10700         (ada_collect_symbol_completion_matches)
10701         (ada_add_global_exceptions): Update.
10702
10703 2019-01-15  Tom Tromey  <tom@tromey.com>
10704
10705         * progspace.h (program_space) <objfiles_safe_range>: New
10706         typedef.
10707         <objfiles_safe>: New method.
10708         * objfiles.h (class all_objfiles_safe): Remove.
10709         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10710         * jit.c (jit_inferior_exit_hook): Update.
10711
10712 2019-01-17  Tom Tromey  <tom@tromey.com>
10713
10714         * progspace.h (program_space) <objfiles_range>: New typedef.
10715         <objfiles>: New method.
10716         <objfiles_head>: Rename from objfiles.
10717         (object_files): Update.
10718         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10719         * guile/scm-pretty-print.c
10720         (ppscm_find_pretty_printer_from_objfiles): Update.
10721         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10722         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10723         Update.
10724         * python/py-progspace.c (pspy_get_objfiles): Update.
10725         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10726         Update.
10727         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10728         (objfpy_lookup_objfile_by_build_id): Update.
10729         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10730         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10731         Update.
10732         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10733         (expand_symtab_containing_pc, lookup_objfile_from_block)
10734         (lookup_static_symbol, basic_lookup_transparent_type)
10735         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10736         (find_line_symtab, info_sources_command)
10737         (default_collect_symbol_completion_matches_break_on)
10738         (make_source_files_completion_list, find_main_name): Update.
10739         * symmisc.c (print_symbol_bcache_statistics)
10740         (print_objfile_statistics, maintenance_print_symbols)
10741         (maintenance_print_msymbols, maintenance_print_objfiles)
10742         (maintenance_info_symtabs, maintenance_check_symtabs)
10743         (maintenance_expand_symtabs, maintenance_info_line_tables):
10744         Update.
10745         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10746         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10747         (map_overlay_command, unmap_overlay_command)
10748         (simple_overlay_update, expand_symtabs_matching)
10749         (map_symbol_filenames): Update.
10750         * symfile-debug.c (set_debug_symfile): Update.
10751         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10752         Update.
10753         * source.c (select_source_symtab, forget_cached_source_info):
10754         Update.
10755         * solib.c (solib_read_symbols): Update.
10756         * solib-spu.c (append_ocl_sos): Update.
10757         * psymtab.c (maintenance_print_psymbols)
10758         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10759         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10760         * printcmd.c (info_symbol_command): Update.
10761         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10762         Update.
10763         * objfiles.h (class all_objfiles): Remove.
10764         * objfiles.c (have_partial_symbols, have_full_symbols)
10765         (have_minimal_symbols, qsort_cmp, update_section_map)
10766         (shared_objfile_contains_address_p)
10767         (default_iterate_over_objfiles_in_search_order): Update.
10768         * objc-lang.c (info_selectors_command, info_classes_command)
10769         (find_methods): Update.
10770         * minsyms.c (find_solib_trampoline_target): Update.
10771         * maint.c (maintenance_info_sections)
10772         (maintenance_translate_address, count_symtabs_and_blocks):
10773         Update.
10774         * main.c (captured_main_1): Update.
10775         * linux-thread-db.c (try_thread_db_load_from_pdir)
10776         (has_libpthread): Update.
10777         * linespec.c (iterate_over_all_matching_symtabs)
10778         (search_minsyms_for_name): Update.
10779         * jit.c (jit_find_objf_with_entry_addr): Update.
10780         * hppa-tdep.c (find_unwind_entry)
10781         (hppa_lookup_stub_minimal_symbol): Update.
10782         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10783         Update.
10784         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10785         (elf_gnu_ifunc_resolve_by_got): Update.
10786         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10787         * dwarf-index-write.c (save_gdb_index_command): Update.
10788         * cp-support.c (add_symbol_overload_list_qualified): Update.
10789         * breakpoint.c (create_overlay_event_breakpoint)
10790         (create_longjmp_master_breakpoint)
10791         (create_std_terminate_master_breakpoint)
10792         (create_exception_master_breakpoint): Update.
10793         * blockframe.c (find_pc_partial_function): Update.
10794         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10795         (ada_collect_symbol_completion_matches)
10796         (ada_add_global_exceptions): Update.
10797
10798 2019-01-17  Tom Tromey  <tom@tromey.com>
10799
10800         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10801         declare VEC.
10802         (solib_target_parse_libraries): Change return type.
10803         (library_list_start_segment, library_list_start_section)
10804         (library_list_end_library, library_list_start_library); Update.
10805         (solib_target_free_library_list): Remove.
10806         (solib_target_parse_libraries): Remove cleanup.  Change return
10807         type.
10808         (solib_target_current_sos): Update.
10809
10810 2019-01-17  Tom Tromey  <tromey@bapiya>
10811
10812         * valprint.c: Replace "the the" with "the".
10813         * symtab.c: Replace "the the" with "the".
10814         * solib.c: Replace "the the" with "the".
10815         * solib-dsbt.c: Replace "the the" with "the".
10816         * linespec.c: Replace "the the" with "the".
10817         * dwarf2loc.h: Replace "the the" with "the".
10818         * amd64-windows-tdep.c: Replace "the the" with "the".
10819         * aarch64-tdep.c: Replace "the the" with "the".
10820
10821 2019-01-16  Keith Seitz  <keiths@redhat.com>
10822
10823         PR gdb/23773
10824         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10825         <builder>: Rename to ..
10826         <m_builder>: ... this and make private.
10827         (dwarf2_cu::get_builder): New method.  Change all users of
10828         `builder' to use this method.
10829         (dwarf2_start_symtab): Move to ...
10830         (dwarf2_cu::start_symtab): ... here.  Update all callers
10831         (setup_type_unit_groups): Move to ...
10832         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10833         callers.
10834         (dwarf2_cu::reset_builder): New method.
10835         (process_full_compunit, process_full_type_unit): Use
10836         dwarf2_cu::reset_builder.
10837         (follow_die_offset): Record the ancestor CU if it is different
10838         from the followed DIE's CU.
10839         (follow_die_sig_1): Likewise.
10840
10841 2019-01-15  Tom Tromey  <tom@tromey.com>
10842
10843         * remote.c (class remote_state) <buf>: Now a char_vector.
10844         <buf_size>: Remove.
10845         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10846         parameter.
10847         (remote_target::getpkt_or_notif_sane_1)
10848         (remote_target::getpkt_sane)
10849         (remote_target::getpkt_or_notif_sane): Likewise.
10850         (class remote_target) <putpkt>: New overload.
10851         (remote_target::read_frame): Change type of "buf_p".  Remove
10852         sizeof_p parameter.
10853         (packet_ok): New overload.
10854         (packet_check_result): New overload.
10855         Update all uses.
10856
10857 2019-01-14  Tom Tromey  <tom@tromey.com>
10858
10859         * remote-notif.c (handle_notification, remote_notif_ack)
10860         (remote_notif_parse): Make "buf" const.
10861         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10862         const.
10863         (remote_notif_parse, remote_notif_ack, handle_notification):
10864         Likewise.
10865         * remote.c (remote_notif_stop_parse): Make "buf" const.
10866         (remote_target::remote_parse_stop_reply): Make "buf" const.
10867         (remote_notif_stop_ack): Make "buf" const.
10868
10869 2019-01-14  Tom Tromey  <tom@tromey.com>
10870
10871         * remote.c (remote_console_output): Make parameter const.
10872
10873 2019-01-14  Tom Tromey  <tom@tromey.com>
10874
10875         * target-debug.h (target_debug_print_signals): Constify.
10876         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10877         * procfs.c (procfs_target::pass_signals): Update.
10878         * linux-nat.c (linux_nat_target::pass_signals): Update.
10879         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10880         * target-delegates.c: Rebuild.
10881         * remote.c (remote_target::program_signals): Update.
10882         (remote_target::pass_signals): Update.
10883         * target.c (target_pass_signals): Constify argument.
10884         (target_program_signals): Likewise.
10885         * target.h (struct target_ops) <pass_signals, program_signals>:
10886         Constify argument.
10887         (target_pass_signals, target_program_signals): Constify argument.
10888
10889 2019-01-14  Tom Tromey  <tom@tromey.com>
10890
10891         PR tui/28819:
10892         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10893
10894 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10895
10896         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10897         field.
10898         * rs6000-tdep.c: Include reggroups.h.
10899         (IS_V_ALIAS_PSEUDOREG): Define.
10900         (rs6000_register_name): Return names for the "vX" aliases.
10901         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10902         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10903         aliases.  Call default_register_reggroup_p for all other
10904         pseudo-registers.
10905         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10906         New functions.
10907         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10908         Handle "vX" aliases.
10909         (v_alias_pseudo_register_collect): New function.
10910         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10911         (rs6000_gdbarch_init): Initialize "vX" aliases as
10912         pseudo-registers.  Restore registration of
10913         rs6000_pseudo_register_reggroup_p with
10914         set_tdesc_pseudo_register_reggroup_p.
10915
10916 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10917
10918         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10919         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10920         set_gdbarch_num_pseudo_regs.
10921
10922 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10923
10924         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10925         Remove arg prefixname, add do_set and do_show.
10926         Add member functions set_list and show_list.
10927         * cli/cli-style.c (class cli_style_option): Update accordingly.
10928         (style_set_list): Move to file scope.
10929         (style_show_list): Likewise.
10930         (set_style): Call help_list.
10931         (show_style): Call cmd_show_list.
10932         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10933         Update to use the new macro.
10934
10935 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10936
10937         * ada-lang.c (_initialize_ada_language): Expand the help text
10938         for the "catch exception" command.
10939
10940 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10941
10942         * symtab.c (matching_obj_sections): Initialize obj,
10943         declare it closer to its usage.
10944
10945 2019-01-10  Tom Tromey  <tom@tromey.com>
10946
10947         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10948         (basic_inf_threads_range): Remove.
10949         (inf_threads_range, inf_non_exited_threads_range)
10950         (safe_inf_threads_range): Use next_adapter.
10951
10952 2019-01-10  Keith Seitz  <keiths@redhat.com>
10953
10954         PR gdb/23712
10955         PR symtab/23010
10956         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10957         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10958
10959 2019-01-10  Keith Seitz  <keiths@redhat.com>
10960
10961         PR gdb/23712
10962         PR symtab/23010
10963         * dictionary.c (pending_to_vector): Remove.
10964         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10965         Remove _1 suffix, replacing functions of the same name.  Update
10966         all callers.
10967         (dict_create_hashed, dict_create_hashed_expandable)
10968         (dict_create_linear, dict_create_linear_expandable, dict_free)
10969         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10970         Make functions static.
10971
10972 2019-01-10  Keith Seitz  <keiths@redhat.com>
10973
10974         PR gdb/23712
10975         PR symtab/23010
10976         * dictionary.h (struct dictionary): Replace declaration with
10977         multidictionary.
10978         (dict_create_hashed, dict_create_hashed_expandable)
10979         (dict_create_linear, dict_create_linear_expandable)
10980         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10981         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10982         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10983         taking multidictionary argument.
10984         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10985         * block.h (struct block) <dict>: Change to multidictionary
10986         and rename `multidict'.
10987         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10988         symmisc.c: Update all dictionary references to multidictionary.
10989
10990 2019-01-10  Keith Seitz  <keiths@redhat.com>
10991
10992         PR gdb/23712
10993         PR symtab/23010
10994         * dictionary.c: Include unordered_map.
10995         (pending_to_vector): New function.
10996         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10997         Rewrite the non-"_1" functions to take vector instead
10998         of linked list.
10999         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11000         "new" _1 versions of the same name.
11001         (multidictionary): Define.
11002         (std::hash<enum language): New definition.
11003         (collate_pending_symbols_by_language, mdict_create_hashed)
11004         (mdict_create_hashed_expandable, mdict_create_linear)
11005         (mdict_create_linear_expandable, mdict_free)
11006         (find_language_dictionary, create_new_language_dictionary)
11007         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11008         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11009         (mdict_size, mdict_empty): New functions.
11010         * dictionary.h (mdict_iterator): Define.
11011
11012 2019-01-10  Pedro Alves  <palves@redhat.com>
11013
11014         * breakpoint.c (read_uploaded_action)
11015         (create_tracepoint_from_upload): Adjust to use
11016         gdb::unique_xmalloc_ptr.
11017         * ctf.c (ctf_write_uploaded_tp):
11018         (SET_ARRAY_FIELD): Use emplace_back.
11019         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11020         * tracefile-tfile.c (tfile_write_uploaded_tp):
11021         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11022         gdb::unique_xmalloc_ptr.
11023         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11024         at_string, cond_string, cmd_strings>: Replace char pointers
11025         with gdb::unique_xmalloc_ptr.
11026
11027 2019-01-10  Pedro Alves  <palves@redhat.com>
11028
11029         * solib-target.c (library_list_start_library): Don't xstrdup name.
11030
11031 2019-01-10  Pedro Alves  <palves@redhat.com>
11032
11033         * mdebugread.c (parse_partial_symbols): Use
11034         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11035
11036 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11037
11038         * linux-fork.c (scoped_switch_fork_info)
11039         <~scoped_switch_fork_info>: Fix incorrect variable name.
11040
11041 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11042
11043         * linux-fork.c (scoped_switch_fork_info)
11044         <scoped_switch_fork_info>: Make explicit.
11045         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11046
11047 2019-01-10  Tom Tromey  <tom@tromey.com>
11048
11049         * objfiles.h (objfile::reset_psymtabs): Update.
11050         * objfiles.c (objfile::objfile): Update.
11051         * psymtab.h (psymtab_storage::obstack): Update.
11052         (psymtab_storage::m_obstack): Use gdb::optional.
11053         (class psymtab_storage): Update comment.  Remove objfile
11054         parameter.
11055         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11056
11057 2019-01-10  Tom Tromey  <tom@tromey.com>
11058
11059         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11060         <free_psymtabs>: Now private.
11061         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11062         (allocate_psymtab): Use new method.
11063
11064 2019-01-10  Tom Tromey  <tom@tromey.com>
11065
11066         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11067         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11068         * mdebugread.c (parse_partial_symbols): Use
11069         allocate_dependencies.
11070         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11071         allocate_dependencies.
11072         (process_psymtab_comp_unit_reader)
11073         (build_type_psymtab_dependencies): Likewise.
11074         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11075
11076 2019-01-10  Tom Tromey  <tom@tromey.com>
11077
11078         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11079         PSYMBOL_SET_LANGUAGE.
11080         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11081
11082 2019-01-10  Tom Tromey  <tom@tromey.com>
11083
11084         * psymtab.h (psymtab_storage::obstack): New method.
11085         <m_obstack>: Rename from obstack; now private.
11086         * psymtab.c (psymtab_storage): Update.
11087         * dwarf2read.c (create_addrmap_from_index)
11088         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11089         Update.
11090
11091 2019-01-10  Tom Tromey  <tom@tromey.com>
11092
11093         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11094         * objfiles.h (objfile::reset_psymtabs): New method.
11095
11096 2019-01-10  Tom Tromey  <tom@tromey.com>
11097
11098         * symmisc.c (print_symbol_bcache_statistics): Update.
11099         (print_objfile_statistics): Update.
11100         * symfile.c (reread_symbols): Update.
11101         * psymtab.h (class psymtab_storage): New.
11102         * psymtab.c (psymtab_storage): New constructor.
11103         (~psymtab_storage): New destructor.
11104         (require_partial_symbols): Update.
11105         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11106         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11107         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11108         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11109         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11110         (start_psymtab_common, end_psymtab_common)
11111         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11112         (allocate_psymtab): Update.
11113         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11114         Update.
11115         (dump_psymtab_addrmap, maintenance_print_psymbols)
11116         (maintenance_check_psymtabs): Update.
11117         (class objfile_psymtabs): Move to objfiles.h.
11118         * psympriv.h (discard_psymtab): Now inline.
11119         (psymtab_discarder::psymtab_discarder): Update.
11120         (psymtab_discarder::~psymtab_discarder): Update.
11121         (ALL_OBJFILE_PSYMTABS): Rewrite.
11122         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11123         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11124         Remove fields.
11125         <partial_symtabs>: New field.
11126         (class objfile_psymtabs): Move from psymtab.h.  Update.
11127         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11128         psymbol_cache.
11129         (objfile::~objfile): Don't destroy psymbol_cache.
11130         * mdebugread.c (parse_partial_symbols): Update.
11131         * dwarf2read.c (create_addrmap_from_index)
11132         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11133         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11134         (add_partial_subprogram, dwarf2_ranges_read): Update.
11135         * dwarf-index-write.c (write_address_map)
11136         (write_one_signatured_type, recursively_write_psymbols)
11137         (class debug_names, class debug_names, write_psymtabs_to_index):
11138         Update.
11139
11140 2019-01-10  Tom Tromey  <tom@tromey.com>
11141
11142         * symtab.h (SYMBOL_SET_NAMES): Update.
11143         (symbol_set_names): Update.
11144         (MSYMBOL_SET_NAMES): Update.
11145         * symtab.c (symbol_set_names): Change argument to be an
11146         objfile_per_bfd_storage.
11147         * psymtab.c (add_psymbol_to_bcache): Update.
11148         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11149
11150 2019-01-10  Tom Tromey  <tom@tromey.com>
11151
11152         * symtab.c (create_demangled_names_hash): Change argument to be an
11153         objfile_per_bfd_storage.
11154         (symbol_set_names): Update.
11155
11156 2019-01-10  Tom Tromey  <tom@tromey.com>
11157
11158         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11159         init_psymbol_list.
11160         * psymtab.c (init_psymbol_list): Do nothing if already called.
11161         * psympriv.h (init_psymbol_list): Add comment.
11162         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11163         init_psymbol_list.
11164         * dbxread.c (dbx_symfile_read): Unconditionally call
11165         init_psymbol_list.
11166
11167 2019-01-10  Tom Tromey  <tom@tromey.com>
11168
11169         * xcoffread.c (scan_xcoff_symtab): Update.
11170         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11171         "where".
11172         * mdebugread.c (parse_partial_symbols)
11173         (handle_psymbol_enumerators): Update.
11174         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11175         * dbxread.c (read_dbx_symtab): Update.
11176         * psympriv.h (psymbol_placement): New enum.
11177         (add_psymbol_to_list): Update.
11178
11179 2019-01-10  Tom Tromey  <tom@tromey.com>
11180
11181         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11182         static_psymbols parameters.
11183         (scan_xcoff_symtab): Update.
11184         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11185         static_psymbols parameters.
11186         * psympriv.h (start_psymtab_common): Update.
11187         * mdebugread.c (parse_partial_symbols): Update.
11188         * dwarf2read.c (create_partial_symtab): Update.
11189         * dbxread.c (read_dbx_symtab): Update.
11190         (start_psymtab): Remove global_psymbols and static_psymbols
11191         parameters.
11192
11193 2019-01-10  Tom Tromey  <tom@tromey.com>
11194
11195         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11196         * psymtab.c (allocate_psymtab): Add comment.
11197         * psympriv.h (allocate_psymtab): Add comment.
11198         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11199         initializations.
11200         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11201
11202 2019-01-10  Tom Tromey  <tom@tromey.com>
11203
11204         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11205         Don't declare.
11206         * mipsread.c: Include mdebugread.h.
11207         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11208         Declare.
11209         * elfread.c: Include mdebugread.h.
11210
11211 2019-01-09  Tom Tromey  <tom@tromey.com>
11212
11213         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11214         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11215         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11216         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11217         (psym_lookup_symbol, psym_find_last_source_symtab)
11218         (psym_forget_cached_source_info, psym_print_stats)
11219         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11220         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11221         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11222         (psym_find_compunit_symtab_by_address)
11223         (maintenance_print_psymbols, maintenance_info_psymtabs)
11224         (maintenance_check_psymtabs): Use ranged for.
11225         * psymtab.h (class objfile_psymtabs): New.
11226         (require_partial_symbols): Return objfile_psymtabs.
11227         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11228
11229 2019-01-09  Tom Tromey  <tom@tromey.com>
11230
11231         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11232         (find_pc_mapped_section, list_overlays_command)
11233         (map_overlay_command, unmap_overlay_command)
11234         (simple_overlay_update): Use all_objfiles.
11235         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11236         * printcmd.c (info_symbol_command): Use all_objfiles.
11237         * objfiles.h (ALL_OBJSECTIONS): Remove.
11238         * maint.c (maintenance_translate_address): Use all_objfiles.
11239         * gcore.c (gcore_create_callback): Use all_objfiles.
11240         (objfile_find_memory_regions): Likewise.
11241
11242 2019-01-09  Tom Tromey  <tom@tromey.com>
11243
11244         * symtab.c (find_line_symtab, info_sources_command)
11245         (make_source_files_completion_list): Use objfile_compunits.
11246         * source.c (select_source_symtab): Use objfile_compunits.
11247         * objfiles.h (struct objfile): Update comment.
11248         (ALL_OBJFILES): Remove.
11249         (ALL_FILETABS): Remove.
11250         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11251         objfile_compunits.
11252
11253 2019-01-09  Tom Tromey  <tom@tromey.com>
11254
11255         * symmisc.c (print_objfile_statistics, dump_objfile)
11256         (maintenance_print_symbols): Use compunit_filetabs.
11257         * source.c (forget_cached_source_info_for_objfile): Use
11258         compunit_filetabs.
11259         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11260         (ALL_FILETABS): Use compunit_filetabs.
11261         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11262         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11263
11264 2019-01-09  Tom Tromey  <tom@tromey.com>
11265
11266         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11267         (compunit_filetabs): New.
11268         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11269         compunit_filetabs.
11270         (info_sources_command, make_source_files_completion_list): Remove
11271         declaration.
11272         * symmisc.c (print_objfile_statistics, dump_objfile)
11273         (maintenance_print_symbols): Remove declaration.
11274         (maintenance_info_symtabs): Use compunit_filetabs.
11275         (maintenance_info_line_tables): Likewise.
11276         * source.c (select_source_symtab): Change local variable name.
11277         (forget_cached_source_info_for_objfile): Remove declaration.
11278         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11279         * objfiles.c (objfile_relocate1): Remove declaration.
11280         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11281         declaration.
11282         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11283         * coffread.c (coff_symtab_read): Remove declaration.
11284         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11285         compunit_filetabs.
11286
11287 2019-01-09  Tom Tromey  <tom@tromey.com>
11288
11289         * symtab.c (lookup_objfile_from_block)
11290         (find_pc_sect_compunit_symtab, search_symbols)
11291         (default_collect_symbol_completion_matches_break_on): Use
11292         objfile_compunits.
11293         * objfiles.h (ALL_COMPUNITS): Remove.
11294         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11295         * cp-support.c (add_symbol_overload_list_qualified): Use
11296         objfile_compunits.
11297         * ada-lang.c (ada_collect_symbol_completion_matches)
11298         (ada_add_global_exceptions): Use objfile_compunits.
11299
11300 2019-01-09  Tom Tromey  <tom@tromey.com>
11301
11302         * source.c (select_source_symtab)
11303         (forget_cached_source_info_for_objfile): Remove declaration.
11304         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11305         declaration.
11306         * maint.c (count_symtabs_and_blocks): Remove declaration.
11307         * cp-support.c (add_symbol_overload_list_qualified): Remove
11308         declaration.
11309         * coffread.c (coff_symtab_read): Remove declaration.
11310         * symtab.c (lookup_symbol_in_objfile_symtabs)
11311         (basic_lookup_transparent_type_1): Use objfile_compunits.
11312         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11313         (info_sources_command, search_symbols)
11314         (default_collect_symbol_completion_matches_break_on)
11315         (make_source_files_completion_list): Remove declaration.
11316         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11317         (ada_collect_symbol_completion_matches)
11318         (ada_add_global_exceptions): Remove declaration.
11319         * linespec.c (iterate_over_all_matching_symtabs): Use
11320         objfile_compunits.
11321         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11322         (class objfile_compunits): New.
11323         (ALL_COMPUNITS): Use objfile_compunits.
11324         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11325         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11326         objfile_compunits.
11327         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11328
11329 2019-01-09  Tom Tromey  <tom@tromey.com>
11330
11331         * symtab.c (search_symbols)
11332         (default_collect_symbol_completion_matches_break_on): Use
11333         objfile_msymbols.
11334         * ada-lang.c (ada_lookup_simple_minsym)
11335         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11336         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11337         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11338         objfile_msymbols.
11339         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11340         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11341         * objc-lang.c (find_methods): Use objfile_msymbols.
11342         (info_selectors_command, info_classes_command): Likewise.
11343         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11344         * objfiles.h (class objfile_msymbols): New.
11345         (ALL_OBJFILE_MSYMBOLS): Remove.
11346         (ALL_MSYMBOLS): Remove.
11347
11348 2019-01-09  Tom Tromey  <tom@tromey.com>
11349
11350         * common/next-iterator.h (next_adapter): Add Iterator template
11351         parameter.
11352         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11353         (class all_objfiles_safe): New.
11354         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11355         * objfiles.c (put_objfile_before): Update comment.
11356         (add_separate_debug_objfile): Likewise.
11357         (free_all_objfiles): Use all_objfiles_safe.
11358         (objfile_purge_solibs): Likewise.
11359
11360 2019-01-09  Tom Tromey  <tom@tromey.com>
11361
11362         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11363         (expand_symtab_containing_pc, lookup_static_symbol)
11364         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11365         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11366         all_objfiles.
11367         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11368         * breakpoint.c (create_overlay_event_breakpoint)
11369         (create_longjmp_master_breakpoint)
11370         (create_std_terminate_master_breakpoint)
11371         (create_exception_master_breakpoint): Use all_objfiles.
11372         * linux-thread-db.c (try_thread_db_load_from_pdir)
11373         (has_libpthread): Use all_objfiles.
11374         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11375         * linespec.c (iterate_over_all_matching_symtabs)
11376         (search_minsyms_for_name): Use all_objfiles.
11377         * maint.c (maintenance_info_sections): Use all_objfiles.
11378         * main.c (captured_main_1): Use all_objfiles.
11379         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11380         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11381         * guile/scm-pretty-print.c
11382         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11383         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11384         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11385         (maintenance_print_msymbols): Use all_objfiles.
11386         * source.c (select_source_symtab): Use all_objfiles.
11387         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11388         * symfile.c (remove_symbol_file_command)
11389         (expand_symtabs_matching, map_symbol_filenames): Use
11390         all_objfiles.
11391         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11392         all_objfiles.
11393         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11394         * objc-lang.c (find_methods): Use all_objfiles.
11395         * objfiles.c (have_partial_symbols, have_full_symbols)
11396         (have_minimal_symbols, qsort_cmp)
11397         (default_iterate_over_objfiles_in_search_order): Use
11398         all_objfiles.
11399         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11400         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11401         (maintenance_check_psymtabs): Use all_objfiles.
11402         (ALL_PSYMTABS): Remove.
11403         * compile/compile-object-run.c (do_module_cleanup): Use
11404         all_objfiles.
11405         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11406         * cp-support.c (add_symbol_overload_list_qualified): Use
11407         all_objfiles.
11408         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11409         Use all_objfiles.
11410         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11411         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11412         all_objfiles.
11413         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11414         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11415         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11416         Uses all_objfiles.
11417         * solib.c (solib_read_symbols): Use all_objfiles
11418
11419 2019-01-09  Tom Tromey  <tom@tromey.com>
11420
11421         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11422         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11423         all_objfiles.
11424         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11425         * symmisc.c (print_symbol_bcache_statistics)
11426         (print_objfile_statistics, maintenance_print_objfiles)
11427         (maintenance_info_symtabs, maintenance_check_symtabs)
11428         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11429         all_objfiles.
11430         * source.c (forget_cached_source_info): Use all_objfiles.
11431         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11432         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11433         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11434         * objfiles.c (update_section_map): Use all_objfiles.
11435         (shared_objfile_contains_address_p): Likewise.
11436         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11437         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11438
11439 2019-01-09  Tom Tromey  <tom@tromey.com>
11440
11441         * common/next-iterator.h: New file.
11442         * objfiles.h (class all_objfiles): New.
11443         (struct objfile_iterator): New.
11444
11445 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11446
11447         * NEWS: Move the description of the changed "frame", "select-frame",
11448          and "info frame" commands to the Changed commands section.
11449
11450 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11451
11452         * gdbtypes.c (check_stub_method_group): Remove handling of old
11453         mangling schemes.
11454         * linespec.c (find_methods): Likewise.
11455         * stabsread.c (read_member_functions): Likewise.
11456         * valops.c (search_struct_method): Likewise.
11457         (value_struct_elt_for_reference): Likewise.
11458         * NEWS: Mention this change.
11459
11460 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11461
11462         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11463         print_source_lines.
11464         * source.c (print_source_lines_base): Update line number check.
11465         (print_source_lines): New function.
11466         (source_lines_range::source_lines_range): New function.
11467         * source.h (class source_lines_range): New class.
11468         (print_source_lines): New declaration.
11469
11470 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11471
11472         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11473
11474 2019-01-08  Tom Tromey  <tom@tromey.com>
11475             Simon Marchi  <simon.marchi@ericsson.com>
11476
11477         PR gdb/24060
11478         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11479         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11480         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11481         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11482         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11483         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11484
11485 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11486
11487         * source.c (select_source_symtab): Move header comment to
11488         declaration in source.h.
11489         (forget_cached_source_info_for_objfile): Likewise.
11490         (forget_cached_source_info): Likewise.
11491         (identify_source_line): Likewise.
11492         * source.h (identify_source_line): Move declaration from symtab.h
11493         and add comment from source.c
11494         (print_source_lines): Likewise.
11495         (forget_cached_source_info_for_objfile): Likewise.
11496         (forget_cached_source_info): Likewise.
11497         (select_source_symtab): Likewise.
11498         (enum print_source_lines_flag): Move definition from symtab.h.
11499         * symtab.h (identify_source_line): Move declaration to source.h.
11500         (print_source_lines): Likewise.
11501         (forget_cached_source_info_for_objfile): Likewise.
11502         (forget_cached_source_info): Likewise.
11503         (select_source_symtab): Likewise.
11504         (enum print_source_lines_flag): Move definition to source.h.
11505         * tui/tui-hooks.c: Add 'source.h' include.
11506
11507 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11508
11509         * source.c (print_source_lines_base): Handle requests to print
11510         reverse line number sequences, and guard against empty lines
11511         string.
11512
11513 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11514
11515         * source.c (print_source_lines_base): Fix skip of '\r' if next
11516         character is '\n'.
11517
11518 2019-01-06  Tom Tromey  <tom@tromey.com>
11519
11520         * c-exp.y (struct c_parse_state) <macro_original_text,
11521         expansion_obstack>: New member.
11522         (macro_original_text, expansion_obstack): Remove globals.
11523         (scan_macro_expansion, scanning_macro_expansion)
11524         (finished_macro_expansion): Update.
11525         (scan_macro_cleanup): Remove.
11526         (yylex, c_parse): Update.
11527
11528 2019-01-06  Tom Tromey  <tom@tromey.com>
11529
11530         * c-exp.y (struct c_parse_state) <strings>: New member.
11531         (operator_stoken): Update.
11532
11533 2019-01-06  Tom Tromey  <tom@tromey.com>
11534
11535         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11536         (union type_stack_elt) <typelist_val>: Now a pointer to
11537         std::vector.
11538         (type_stack_cleanup): Don't declare.
11539         (push_typelist): Update.
11540         * parse.c (pop_typelist): Return a std::vector.
11541         (push_typelist): Take a std::vector.
11542         (follow_types): Update.  Do not free args.
11543         (type_stack_cleanup): Remove.
11544         * c-exp.y (struct c_parse_state): New.
11545         (cpstate): New global.
11546         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11547         (nonempty_typelist): Update.
11548         (func_mod): Create a new vector.
11549         (c_parse): Create a c_parse_state.
11550         (check_parameter_typelist): Do not delete params.
11551         (function_method): Update.  Do not delete type_list.
11552
11553 2019-01-06  Tom Tromey  <tom@tromey.com>
11554
11555         PR gdb/28155:
11556         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11557         check_typedef.
11558         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11559         (print_return_value): Likewise.
11560
11561 2019-01-05  Tom Tromey  <tom@tromey.com>
11562
11563         * contrib/cleanup_check.py: Remove.
11564         * contrib/gcc-with-excheck: Remove.
11565         * contrib/exsummary.py: Remove.
11566         * contrib/excheck.py: Remove.
11567
11568 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11569
11570         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11571         NULL. Initialize tpprev to NULL instead of assigning it
11572         to NULL on the next statement.
11573         * windows-nat.c (windows_delete_thread): Remove check for
11574         main_thread_id before printing thread exit notifications.
11575         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11576         Remove thread ID check against main_thread_id.
11577         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11578         windows_delete_thread.
11579         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11580
11581 2019-01-04  Tom Tromey  <tom@tromey.com>
11582
11583         * compile/compile.c (_initialize_compile): Use upper case for
11584         metasyntactic variables.
11585         * symmisc.c (_initialize_symmisc): Use upper case for
11586         metasyntactic variables.
11587         * psymtab.c (_initialize_psymtab): Use upper case for
11588         metasyntactic variables.
11589         * demangle.c (demangle_command): Use upper case for metasyntactic
11590         variables.
11591         (_initialize_demangler): Likewise.
11592         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11593         variables.
11594
11595 2019-01-03  Tom Tromey  <tom@tromey.com>
11596
11597         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11598
11599 2019-01-03  Tom Tromey  <tom@tromey.com>
11600
11601         * python/py-symtab.c (salpy_str): Update.
11602         (struct salpy_sal_object) <symtab>: Now a PyObject.
11603         (salpy_dealloc): Update.
11604         (del_objfile_sal): Use gdbpy_ref.
11605
11606 2019-01-03  Tom Tromey  <tom@tromey.com>
11607
11608         * python/py-type.c (convert_field): Use new_reference.  Return
11609         gdbpy_ref.
11610         (make_fielditem): Return gdbpy_ref.
11611         (typy_fields): Update.
11612         (typy_getitem): Update.
11613         (field_name): Return gdbpy_ref.  Use new_reference.
11614         (typy_iterator_iternext): Update.
11615
11616 2019-01-03  Tom Tromey  <tom@tromey.com>
11617
11618         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11619
11620 2019-01-03  Tom Tromey  <tom@tromey.com>
11621
11622         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11623         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11624         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11625         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11626         (pspy_set_type_printers): Likewise.
11627         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11628         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11629         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11630         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11631         (objfpy_set_type_printers): Likewise.
11632
11633 2019-01-03  Tom Tromey  <tom@tromey.com>
11634
11635         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11636         (gdbpy_print_stack): Use gdbpy_err_fetch.
11637         * python/python-internal.h (class gdbpy_err_fetch): New class.
11638         (class gdbpy_enter) <m_error_type, m_error_value,
11639         m_error_traceback>: Remove.
11640         <m_error>: New member.
11641         (gdbpy_exception_to_string): Don't declare.
11642         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11643         * python/py-value.c (convert_value_from_python): Use
11644         gdbpy_err_fetch.
11645         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11646         gdbpy_exception_to_string.
11647         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11648         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11649         gdbpy_err_fetch.
11650
11651 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11652
11653         * linux-nat.c (delete_lwp_cleanup): Delete.
11654         (struct lwp_deleter): New struct.
11655         (lwp_info_up): New typedef.
11656         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11657         lwp_info_up.
11658
11659 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11660
11661         * linux-fork.c (class scoped_switch_fork_info): New class.
11662         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11663
11664 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11665
11666         * valops.c (find_overload_match): Remove use of null_cleanup, and
11667         calls to do_cleanups.
11668
11669 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11670
11671         * compile/compile-cplus-types.c
11672         (compile_cplus_instance::decl_name): Handle changes to
11673         cp_func_name.
11674         * cp-support.c (cp_func_name): Update header comment, update
11675         return type.
11676         * cp-support.h (cp_func_name): Update return type in declaration.
11677         * valops.c (find_overload_match): Move temp_func local to top
11678         level of function and change its type.  Use temp_func to hold and
11679         delete temporary string obtained from cp_func_name.
11680
11681 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11682
11683         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11684         gdb::char_vector, remove cleanup, and update uses of `msg`.
11685
11686 2019-01-03  Jim Wilson  <jimw@sifive.com>
11687
11688         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11689
11690 2019-01-02  Tom Tromey  <tom@tromey.com>
11691
11692         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11693         (tdesc_parse_xml): Remove cleanups.
11694         * target-descriptions.h (make_cleanup_free_target_description):
11695         Don't declare.
11696         (target_desc_deleter): New struct.
11697         (target_desc_up): New typedef.
11698         * target-descriptions.c (target_desc_deleter::operator()): Rename
11699         from free_target_description.
11700         (make_cleanup_free_target_description): Remove.
11701
11702 2019-01-02  Tom Tromey  <tom@tromey.com>
11703
11704         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11705         constructor, destructor.
11706         (linespec_parser): Remove typedef.
11707         (~linespec_parser): Rename from linespec_parser_delete.
11708         (linespec_lex_to_end, linespec_complete_label)
11709         (linespec_complete): Update.
11710         (decode_line_full): Remove cleanups.
11711         (decode_line_1): Update.
11712
11713 2019-01-02  Tom Tromey  <tom@tromey.com>
11714
11715         * python/python-internal.h (inferior_to_inferior_object): Change
11716         return type.
11717         * python/py-exitedevent.c (create_exited_event_object): Update.
11718         * python/py-inferior.c (inferior_to_inferior_object): Return
11719         gdbpy_ref.
11720         (python_new_inferior, python_inferior_deleted)
11721         (thread_to_thread_object, delete_thread_object)
11722         (build_inferior_list, gdbpy_selected_inferior): Update.
11723         * python/py-infthread.c (create_thread_object): Update.  Also fail
11724         if inferior_to_inferior_object fails.
11725
11726 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11727
11728         * inferior.h (class inferior) <displaced_step_state>: New field.
11729         * infrun.h (struct displaced_step_state): Move here from
11730         infrun.c.  Initialize fields, add constructor.
11731         <inf>: Remove field.
11732         <reset>: New method.
11733         * infrun.c (struct displaced_step_inferior_state): Move to
11734         infrun.h.
11735         (displaced_step_inferior_states): Remove.
11736         (get_displaced_stepping_state): Adust.
11737         (displaced_step_in_progress_any_inferior): Adjust.
11738         (displaced_step_in_progress_thread): Adjust.
11739         (displaced_step_in_progress): Adjust.
11740         (add_displaced_stepping_state): Remove.
11741         (get_displaced_step_closure_by_addr): Adjust.
11742         (remove_displaced_stepping_state): Remove.
11743         (infrun_inferior_exit): Call displaced_step_state.reset.
11744         (use_displaced_stepping): Don't check for NULL.
11745         (displaced_step_prepare_throw): Call
11746         get_displaced_stepping_state.
11747         (displaced_step_fixup): Don't check for NULL.
11748         (prepare_for_detach): Don't check for NULL.
11749
11750 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11751
11752         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11753          in case of call that did not complete.
11754
11755 2019-01-02  Andrey Utkin  <autkin@undo.io>
11756
11757         * symfile.c (find_separate_debug_file): Fix search of debug files for
11758         remote debuggee.
11759
11760 2019-01-02  Tom Tromey  <tom@tromey.com>
11761
11762         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11763         indentation.
11764         * python/py-frame.c (frapy_older): Remove cast.
11765         (frapy_newer): Likewise.
11766         * python/py-breakpoint.c (local_setattro): Remove cast.
11767         * python/py-arch.c (archpy_name): Remove local variable.
11768         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11769
11770 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11771
11772         * unittests/basic_string_view/element_access/char/empty.cc:
11773         Fix year range in copyright header.
11774
11775 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11776
11777         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11778         Delete.
11779         <operator==>: Update with for removed field.
11780         <hash>: Likewise.
11781         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11782         <isa_features>: ...this.
11783         <abi_features>: New field.
11784         (riscv_isa_flen): Update comment.
11785         (riscv_abi_xlen): New declaration.
11786         (riscv_abi_flen): New declaration.
11787         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11788         isa_features.
11789         (riscv_abi_xlen): New function.
11790         (riscv_isa_flen): Update to get answer from isa_features.
11791         (riscv_abi_flen): New function.
11792         (riscv_has_fp_abi): Update to get answer from abi_features.
11793         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11794         xlen and flen.
11795         (riscv_call_info) <xlen, flen>: Update comment.
11796         (riscv_call_arg_struct): Remove invalid assertions
11797         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11798         is removed.
11799         (riscv_gdbarch_init): Gather isa features and abi features
11800         separately, ensure both match on the gdbarch when reusing an old
11801         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11802         a target with 64-bit float hardware.
11803
11804 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11805
11806         * source.c (search_command_helper): Stop reverse search
11807         when line 1 has been searched.
11808
11809 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11810
11811         * record-full.c (record_full_base_target::close): Rewrite
11812         record_full_core_buf_list free logic.
11813
11814 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11815
11816         * break-catch-syscall.c (print_one_catch_syscall): xfree
11817         the last text.
11818
11819 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11820
11821         * top.c (print_gdb_version): Update Copyright year in version
11822         message.
11823
11824 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11825
11826         Update copyright year range in all GDB files.
11827
11828 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11829
11830         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11831
11832 For older changes see ChangeLog-2018.
11833 \f
11834 Local Variables:
11835 mode: change-log
11836 left-margin: 8
11837 fill-column: 74
11838 version-control: never
11839 coding: utf-8
11840 End:
11841