gdb/ChangeLog

   1 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * NEWS: Announce that Ada task names are now shown at more places,
   4         and between quotes (except in info task output).
   5         * gdb/ada-tasks.c (task_to_str): New function.
   6         (display_current_task_id): Call task_to_str.
   7         (task_command_1): Likewise.
   8         (print_ada_task_info): In non-mi mode, Properly align headers and data
   9         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
  10
  11 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
  12
  13         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
  14         prstatus.pr_lwp.pr_info instead of making it up.
  15
  16 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
  17
  18         * auto-load.c (auto_load_expand_dir_vars): Update.
  19         * defs.h (gdb_datadir): Change to std::string.
  20         (python_libdir): Likewise.
  21         (relocate_gdb_directory): Change return type to std::string.
  22         * guile/guile.c (gdbscm_data_directory): Update.
  23         (initialize_scheme_side): Update.
  24         * jit.c (jit_reader_dir): Change to std::string.
  25         (jit_reader_load_command): Update.
  26         * main.c (gdb_datadir): Change to std::string.
  27         (python_libdir): Likewise.
  28         (set_gdb_data_directory): Update.
  29         (relocate_path): Change to return std::string.
  30         (relocate_gdb_directory): Change to return std::string.
  31         (relocate_gdbinit_path_maybe_in_datadir): Update.
  32         (captured_main_1): Update.
  33         * python/python.c (do_start_initialization): Update.
  34         * top.c (show_gdb_datadir): Update.
  35         * xml-syscall.c (xml_init_syscalls_info): Update.
  36         (init_syscalls_info): Update.
  37
  38 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
  39
  40         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
  41         out of get_init_files.
  42         (get_init_files): Update.
  43
  44 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
  45
  46         * main.c (get_init_files): Change to use std::string.
  47         (captured_main_1): Update.
  48         (print_gdb_help): Update.
  49
  50 2019-09-11  Ali Tamur  <tamur@google.com>
  51
  52         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
  53         implementation.
  54
  55 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
  56
  57         * dbxread.c (read_dbx_symtab): Update.
  58         * dwarf2read.c (load_partial_dies): Update.
  59         * mdebugread.c (parse_partial_symbols): Update.
  60         (handle_psymbol_enumerators): Update.
  61         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
  62         * psymtab.c (add_psymbol_to_bcache): Likewise.
  63         (add_psymbol_to_list): Likewise.
  64         * symtab.c (symbol_set_names): Likewise.
  65         * symtab.h (symbol_set_names): Likewise.
  66         * xcoffread.c (scan_xcoff_symtab): Update.
  67
  68 2019-09-11  Tom Tromey  <tom@tromey.com>
  69
  70         * symfile-mem.c (symbol_file_add_from_memory): Use
  71         bfd_set_filename.
  72         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
  73         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
  74
  75 2019-09-10  Tom Tromey  <tromey@adacore.com>
  76
  77         * dwarf-index-write.c (write_psymbols): Extend error message.
  78         (debug_names::insert): Add Ada code.
  79         (debug_names::write_psymbols): Remove Ada check.
  80         (debug_names) <m_string_obstack>: New member.
  81         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
  82         (gdb_index_symbol_name_matcher::matches): Remove.
  83         (mapped_index_base::find_name_components_bounds): Add "lang"
  84         parameter.
  85         (mapped_index_base::build_name_components): Also split names
  86         according to Ada syntax.
  87         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
  88         type of "match_callback".
  89         (check_match, check_find_bounds_finds)
  90         (dw2_expand_symtabs_matching): Update.
  91         (dw2_debug_names_iterator): Add new constructor.
  92         (dw2_debug_names_map_matching_symbols): New function.
  93         (dw2_debug_names_expand_symtabs_matching): Update.
  94         (dwarf2_debug_names_functions): Use
  95         dw2_debug_names_map_matching_symbols.
  96
  97 2019-09-10  Tom Tromey  <tromey@adacore.com>
  98
  99         * dwarf2read.c (dw2_get_file_names_reader): Add the
 100         CU's file name to the results.
 101
 102 2019-09-10  Tom Tromey  <tromey@adacore.com>
 103
 104         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 105         map_matching_symbols.  Update.
 106         * dwarf2read.c (dw2_map_matching_symbols): Update.
 107         * psymtab.c (match_partial_symbol): Change type; update.
 108         (psym_map_matching_symbols): Likewise.
 109         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 110         type; update.
 111         * symfile.h (struct quick_symbol_functions)
 112         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 113         Remove "match".
 114
 115 2019-09-10  Tom Tromey  <tromey@adacore.com>
 116
 117         * psymtab.c (map_block): Remove.
 118         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 119         * symtab.c (iterate_over_symbols_terminated): New function.
 120         * symtab.c (iterate_over_symbols_terminated): Declare.
 121
 122 2019-09-10  Tom Tromey  <tromey@adacore.com>
 123
 124         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 125         * language.h (struct language_defn) <la_iterate_over_symbols>:
 126         Return bool.
 127         * symtab.c (iterate_over_symbols): Return bool.
 128         * symtab.h (iterate_over_symbols): Return bool.
 129
 130 2019-09-10  Tom Tromey  <tromey@adacore.com>
 131
 132         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 133         (add_nonlocal_symbols): Update.
 134         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 135         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 136         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 137         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 138         Change type of "callback".  Remove "data".
 139
 140
 141 2019-09-09  Ali Tamur  <tamur@google.com>
 142
 143         * dwarf2read.c (comp_unit_head): Update comment.
 144         (dwarf2_dwo_name): New function declaration.
 145         (dwarf_unit_type_name): New function declaration.
 146         (read_comp_unit_head): Add support for new compilation units,
 147         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 148         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 149         (currently named as "signature") in their header. Also clarify error
 150         messages.
 151         (lookup_dwo_id): New function. Returns the dwo id of the given
 152         compile unit.
 153         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 154         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 155         functions.
 156         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 157         (dwarf2_dwo_name): Get the dwo name if present.
 158         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 159         purposes.
 160
 161 2019-09-09  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 164
 165 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 166
 167         * python/python.c (do_start_initialization): Make progname_copy static,
 168         to avoid a leak report.
 169
 170 2019-09-08  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 173
 174 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 175
 176         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 177         Change type to gdb::optional<block_enum>.
 178         (dw2_symtab_iter_init): Change block_index parameter type
 179         to gdb::optional<block_enum>.
 180         (dw2_lookup_symbol): Change block_index parameter
 181         type to block_enum.c
 182         (dw2_debug_names_lookup_symbol): Likewise.
 183         * psymtab.c (psym_lookup_symbol): Likewise.
 184         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 185         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 186         Likewise.
 187
 188 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 189
 190         * defs.h (relocate_gdb_directory): Change int to bool in
 191         signature and rename flag to relocatable.
 192         * main.c (relocate_path): Likewise.
 193         (relocate_gdb_directory): Likewise.
 194
 195 2019-09-06  Alan Modra  <amodra@gmail.com>
 196
 197         * coffread.c (coff_symfile_read): Constify filename variable.
 198         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 199         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 200         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 201         * solib.c (reload_shared_libraries_1): Likewise.
 202         * symfile.c (reread_symbols): Likewise.
 203         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 204         * solib-darwin.c (darwin_bfd_open): Likewise.
 205         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 206
 207 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 208
 209         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 210         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 211
 212 2019-09-03  Tom Tromey  <tromey@adacore.com>
 213
 214         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 215         types.
 216         (has_negatives): Unbias a range type bound.
 217         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 218         * gdbtypes.c (operator==): Handle new field.
 219         (create_range_type): Add "bias" parameter.
 220         (create_static_range_type, resolve_dynamic_range): Update.
 221         * gdbtypes.h (struct range_bounds) <bias>: New member.
 222         (create_range_type): Add bias parameter.
 223         * printcmd.c (print_scalar_formatted): Unbias range types.
 224         * value.c (unpack_long): Unbias range types.
 225         (pack_long): Bias range types.
 226
 227 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 228
 229         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 230         probe arguments.
 231
 232 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 233
 234         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 235         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 236         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 237         (compile_probe_arg): Likewise.
 238         * probe.h (get_argument_count): Likewise.
 239         * solib-svr4.c (solib_event_probe_action): Likewise.
 240         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 241
 242 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 243
 244         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 245         code to here...
 246         (svr4_create_solib_event_breakpoints): ...from here.
 247
 248 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 249
 250         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 251         suffix from warning message.
 252
 253 2019-08-30  Tom Tromey  <tom@tromey.com>
 254
 255         * tui/tui-winsource.h (struct tui_source_window_base)
 256         <refresh_all>: Don't declare.
 257         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 258         Remove.
 259         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 260         tui_show_locator_content.
 261         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 262         declare.
 263         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 264         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 265         declare.
 266
 267 2019-08-30  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 270
 271 2019-08-30  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 274         Remove unnecessary forward declarations.
 275
 276 2019-08-30  Tom Tromey  <tom@tromey.com>
 277
 278         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 279         rerender.
 280         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 281         tui_show_locator_content.
 282
 283 2019-08-30  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 286         (tui_locator_window::rerender): Rewrite using body of previous
 287         tui_show_locator_content.
 288
 289 2019-08-30  Tom Tromey  <tom@tromey.com>
 290
 291         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 292         set_locator_fullname>: New methods.
 293         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 294         Rename from tui_set_locator_fullname.
 295         (tui_locator_window::set_locator_info): Rename from
 296         tui_set_locator_info.  Return bool.
 297         (tui_update_locator_fullname, tui_show_frame_info): Update.
 298
 299 2019-08-30  Tom Tromey  <tom@tromey.com>
 300
 301         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 302
 303 2019-08-30  Tom Tromey  <tom@tromey.com>
 304
 305         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 306         call touchwin.
 307
 308 2019-08-30  Tom Tromey  <tom@tromey.com>
 309
 310         * tui/tui-wingeneral.c (box_win): Assume win_info and
 311         win_info->handle cannot be NULL.
 312
 313 2019-08-30  Tom Tromey  <tom@tromey.com>
 314
 315         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 316         refresh_window>: Declare.
 317         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 318         resize.
 319         (tui_data_item_window::rerender): Rename from
 320         tui_display_register.
 321         (tui_data_item_window::refresh_window): New method.
 322         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 323         no-op.
 324
 325 2019-08-30  Tom Tromey  <tom@tromey.com>
 326
 327         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 328         regs_column_count, current_group>: Move later.  Now private.
 329         <get_current_group>: New method.
 330         * tui/tui-regs.c (tui_reg_command): Update.
 331         * tui/tui-layout.c (tui_set_layout): Update.
 332
 333 2019-08-30  Tom Tromey  <tom@tromey.com>
 334
 335         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 336         (tui_data_window::rerender): Don't call
 337         check_and_display_highlight_if_needed.
 338         (tui_data_window::refresh_all): Remove call to
 339         erase_data_content.
 340
 341 2019-08-30  Tom Tromey  <tom@tromey.com>
 342
 343         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 344         (tui_data_window::display_registers_from)
 345         (tui_data_window::display_reg_element_at_line)
 346         (tui_data_window::display_registers_from_line): Remove checks of
 347         "empty".
 348
 349 2019-08-30  Tom Tromey  <tom@tromey.com>
 350
 351         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 352         Don't declare.
 353         * tui/tui-regs.c (tui_data_window::show_registers): Call
 354         rerender.
 355         (tui_data_window::rerender): Rename from display_all_data.
 356         (tui_data_window::rerender): Remove old implementation.
 357
 358 2019-08-30  Tom Tromey  <tom@tromey.com>
 359
 360         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 361         text.
 362         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 363
 364 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 365             Sergio Durigan Junior  <sergiodj@redhat.com>
 366
 367         PR win32/24284
 368         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 369
 370 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 371
 372         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 373         when searching for types.
 374
 375 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 376
 377         * f-lang.c (f_language_defn): Use f_print_typedef.
 378         * f-lang.h (f_print_typedef): Declare.
 379         * f-typeprint.c (f_print_typedef): Define.
 380
 381 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 382
 383         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 384
 385 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 386
 387         * cli/cli-utils.c (info_print_options_defs): Delete.
 388         (make_info_print_options_def_group): Delete.
 389         (extract_info_print_options): Delete.
 390         (info_print_command_completer): Delete.
 391         (info_print_args_help): Add extra parameter, and optionally
 392         include text about -n flag.
 393         * cli/cli-utils.h (struct info_print_options): Delete.
 394         (extract_info_print_options): Delete declaration.
 395         (info_print_command_completer): Delete declaration.
 396         (info_print_args_help): Add extra parameter, extend header
 397         comment.
 398         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 399         search_symbols.
 400         * stack.c (struct info_print_options): New type.
 401         (info_print_options_defs): New file scoped variable.
 402         (make_info_print_options_def_group): New static function.
 403         (info_print_command_completer): New static function.
 404         (info_locals_command): Update to use new local functions.
 405         (info_args_command): Likewise.
 406         (_initialize_stack): Add extra parameter to calls to
 407         info_print_args_help.
 408         * symtab.c (search_symbols): Add extra parameter, use this to
 409         possibly excluse non-debug symbols.
 410         (symtab_symbol_info): Add extra parameter, which is passed on to
 411         search_symbols.
 412         (struct info_print_options): New type.
 413         (info_print_options_defs): New file scoped variable.
 414         (make_info_print_options_def_group): New static function.
 415         (info_print_command_completer): New static function.
 416         (info_variables_command): Update to use local functions, and pass
 417         extra parameter through to symtab_symbol_info.
 418         (info_functions_command): Likewise.
 419         (info_types_command): Pass additional argument through to
 420         symtab_symbol_info.
 421         (rbreak_command): Pass extra argument to search_symbols.
 422         (_initialize_symtab): Add extra arguments for calls to
 423         info_print_args_help, and update help text for 'info variables',
 424         'whereis', and 'info functions' commands.
 425         * symtab.h (search_symbols): Add extra argument to declaration.
 426         * NEWS: Mention new flags.
 427
 428 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 429
 430         * symtab.c (lookup_static_symbol): Call the new function (and move
 431         it down to be next to lookup_global_symbol).
 432         (struct global_sym_lookup_data): Add block_enum member and rename to...
 433         (struct global_or_static_sym_lookup_data): ...this.
 434         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 435         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 436         (lookup_symbol_global_or_static_iterator_cb): ...this.
 437         (lookup_global_or_static_symbol): New function.
 438         (lookup_global_symbol): Call new function.
 439
 440 2019-08-26  Tom de Vries  <tdevries@suse.de>
 441
 442         PR c++/24852
 443         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 444         when pc_probe.prob == NULL.
 445
 446 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 447
 448         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 449         variable symbol_linkage to symbol_linkage_.
 450
 451 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 452
 453         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 454         represent whether the symbol is static, dynamic, or we don't
 455         know.
 456
 457 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 458
 459         * gdb/rx-tdep.c (rx_register_names): New.
 460         (rx_register_name): Delete.
 461         (rx_psw_type): Delete.
 462         (rx_fpsw_type): Delete.
 463         (rx_register_type): Delete.
 464         (rx_gdbarch_init): Convert target-descriptions.
 465         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 466         * gdb/features/Makefile: Add rx.xml.
 467         * gdb/features/rx.xml: New.
 468         * gdb/features/rx.c: Generated.
 469         * gdb/NEWS: Mention target description support.
 470
 471 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 472
 473         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 474         *slot_ptr.
 475
 476 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 477
 478         * configure.ac: Don't check for 'dlfcn.h' (moved to
 479         gdbsupport/common.m4).
 480         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 481         'gdbsupport/'.
 482         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 483         * compile/compile-c-support.c: Include
 484         'gdbsupport/gdb-dlfcn.h'.
 485         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 486         * gdb-dlfcn.c: Move to...
 487         * gdbsupport/gdb-dlfcn.c: ... here.
 488         * gdb-dlfcn.h: Move to...
 489         * gdbsupport/gdb-dlfcn.h: ... here.
 490
 491 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 492
 493         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 494         the offset field signed.
 495
 496 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 497
 498         * python/lib/gdb/__init__.py (_execute_file): New function.
 499         * python/python.c (python_run_simple_file): Call gdb._execute_file
 500         on Windows.
 501
 502 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 503
 504         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 505         all uses as this was never set to anything but a zero value.
 506
 507 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 508
 509         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 510
 511 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 512
 513         * tui/tui-data.h (tui_gen_win_info): Add an =default
 514         move constructor, required by some GCC versions.
 515
 516 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 517
 518         * go32-nat.c (go32_sysinfo): Add hygon_p.
 519
 520 2019-08-20  Tom Tromey  <tom@tromey.com>
 521
 522         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 523         line_from_reg_element_no, first_reg_element_no_inline,
 524         display_all_data, delete_data_content_windows,
 525         erase_data_content>: Now private.
 526
 527 2019-08-20  Tom Tromey  <tom@tromey.com>
 528
 529         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 530         (tui_unhighlight_win, tui_highlight_win)
 531         (tui_win_info::make_window): Update.
 532         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 533
 534 2019-08-20  Tom Tromey  <tom@tromey.com>
 535
 536         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 537         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 538         (MAX_PID_WIDTH): Move to tui-stack.c.
 539         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 540         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 541         (MAX_PID_WIDTH): Move from tui-data.h.
 542
 543 2019-08-20  Tom Tromey  <tom@tromey.com>
 544
 545         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 546         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 547         (box_win): Update.
 548         (tui_gen_win_info::make_window): Rename from tui_make_window.
 549         (tui_win_info::make_window): New method.
 550         (tui_gen_win_info::make_visible): Update.
 551         * tui/tui-source.c (tui_source_window::set_contents): Update.
 552         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 553         (tui_data_window::display_registers_from): Update.
 554         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 555         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 556         Declare.
 557         <can_box>: Remove.
 558         <title>: Remove.
 559         (struct tui_win_info) <make_window>: Declare.
 560         <can_box>: Now virtual.
 561         <title>: New member.
 562         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 563         * tui/tui-command.c (tui_cmd_window::resize): Update.
 564
 565 2019-08-20  Tom Tromey  <tom@tromey.com>
 566
 567         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 568         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 569         (tui_data_window::check_register_values): Update.
 570
 571 2019-08-20  Tom Tromey  <tom@tromey.com>
 572
 573         * tui/tui-regs.h (struct tui_data_window): Use
 574         DISABLE_COPY_AND_ASSIGN.
 575         <regs_content>: Change type, removing unique_ptr.
 576         <tui_data_window>: Add move constructor.
 577         * tui/tui-regs.c (tui_data_window::show_registers)
 578         (tui_data_window::show_register_group)
 579         (tui_data_window::display_registers_from)
 580         (tui_data_window::display_registers_from)
 581         (tui_data_window::first_data_item_displayed)
 582         (tui_data_window::delete_data_content_windows)
 583         (tui_data_window::rerender, tui_data_window::refresh_window)
 584         (tui_data_window::check_register_values): Update.
 585
 586 2019-08-20  Tom Tromey  <tom@tromey.com>
 587
 588         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 589         show_register_group>: Declare.
 590         (tui_show_register_group): Don't declare.
 591         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 592         tui_show_registers.
 593         (tui_data_window::show_register_group): Rename from
 594         tui_show_register_group.
 595         (tui_data_window::check_register_values, tui_reg_command):
 596         Update.
 597         * tui/tui-layout.c (tui_set_layout): Update.
 598
 599 2019-08-20  Tom Tromey  <tom@tromey.com>
 600
 601         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 602         Declare.
 603         (tui_check_register_values): Don't declare.
 604         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 605         from tui_check_register_values.
 606         * tui/tui-hooks.c (tui_register_changed): Update.
 607
 608 2019-08-20  Tom Tromey  <tom@tromey.com>
 609
 610         * tui/tui-regs.c (tui_reg_layout): Move later.
 611         (tui_show_registers): Don't enable TUI mode or change layout.
 612
 613 2019-08-20  Tom Tromey  <tom@tromey.com>
 614
 615         * tui/tui-regs.h (struct tui_data_item_window)
 616         <~tui_data_item_window>: Remove.
 617         <content>: Now a unique_xmalloc_ptr.
 618         * tui/tui-regs.c (tui_register_format): Return a
 619         unique_xmalloc_ptr.
 620         (tui_get_register): Update.
 621         (~tui_data_item_window): Remove.
 622         (tui_data_window::display_registers_from, tui_display_register):
 623         Update.
 624         * tui/tui-io.h (tui_expand_tabs): Update.
 625         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 626         Remove "col" parameter.
 627
 628 2019-08-20  Tom Tromey  <tom@tromey.com>
 629
 630         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 631         field.
 632         * tui/tui-regs.c (~tui_data_item_window): Update.
 633
 634 2019-08-20  Tom Tromey  <tom@tromey.com>
 635
 636         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 637         earlier.
 638
 639 2019-08-20  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 642
 643 2019-08-20  Tom Tromey  <tom@tromey.com>
 644
 645         * tui/tui-source.h (struct tui_source_window): Update.
 646         * tui/tui-regs.c (tui_show_registers): Update.
 647         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 648         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 649         (NO_REGS_STRING): Remove defines.
 650
 651 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 652
 653         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 654         unnecessary thread walk if remote doesn't support the packet.
 655
 656 2019-08-19  Tom Tromey  <tromey@adacore.com>
 657
 658         * python/py-value.c (value_has_field): Fix indentation.
 659
 660 2019-08-19  Tom Tromey  <tromey@adacore.com>
 661
 662         * printcmd.c (do_one_display, info_display_command): Update.
 663         * block.h (contained_in): Return bool.  Add allow_nested
 664         parameter.
 665         * block.c (contained_in): Return bool.  Add allow_nested
 666         parameter.
 667
 668 2019-08-19  Tom Tromey  <tom@tromey.com>
 669
 670         * configure: Rebuild.
 671         * configure.ac: Disallow the combination of -static-libstdc++ and
 672         source highlight.
 673         * source-cache.c (get_language_name): Handle rust.
 674         (source_cache::get_source_lines): Ignore highlighting exceptions.
 675
 676 2019-08-16  Tom Tromey  <tom@tromey.com>
 677
 678         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 679         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 680         (struct tui_source_window_base) <make_visible, refresh_window,
 681         resize>: Remove methods.
 682         <execution_info>: Remove field.
 683         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 684         (tui_show_source_line, tui_source_window_base)
 685         (~tui_source_window_base): Update.
 686         (tui_source_window_base::resize)
 687         (tui_source_window_base::make_visible)
 688         (tui_source_window_base::refresh_window): Remove.
 689         (tui_source_window_base::update_exec_info): Update.
 690         * tui/tui-source.c (tui_source_window::set_contents): Update.
 691         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 692
 693 2019-08-16  Tom Tromey  <tom@tromey.com>
 694
 695         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 696         deprecated_query_hook.
 697
 698 2019-08-16  Tom Tromey  <tom@tromey.com>
 699
 700         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 701         (tui_update_source_windows_with_line): Update.
 702         * tui/tui-source.h (struct tui_source_window)
 703         <show_symtab_source>: Declare.
 704         (tui_show_symtab_source): Don't declare.
 705         * tui/tui-source.c (tui_show_symtab_source): Rename from
 706         tui_show_symtab_source.
 707
 708 2019-08-16  Tom Tromey  <tom@tromey.com>
 709
 710         * tui/tui-winsource.h (struct tui_source_window_base)
 711         <set_contents>: Declare.
 712         * tui/tui-winsource.c
 713         (tui_source_window_base::update_source_window_as_is): Update.
 714         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 715         Declare.
 716         (tui_set_source_content): Don't declare.
 717         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 718         tui_set_source_content.
 719         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 720         Declare.
 721         (tui_set_disassem_content): Don't declare.
 722         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 723         tui_set_disassem_content.
 724
 725 2019-08-16  Tom Tromey  <tom@tromey.com>
 726
 727         * tui/tui-winsource.h (struct tui_source_window_base)
 728         <update_breakpoint_info>: Declare.
 729         (tui_update_breakpoint_info): Don't declare.
 730         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 731         (tui_update_all_breakpoint_info): Update.
 732         (tui_source_window_base::update_breakpoint_info): Rename from
 733         tui_update_breakpoint_info.
 734         (tui_source_window_base::update_exec_info): Update.
 735
 736 2019-08-16  Tom Tromey  <tom@tromey.com>
 737
 738         * tui/tui-winsource.h (struct tui_source_window_base)
 739         <update_source_window>: Declare.
 740         (tui_update_source_window): Don't declare.
 741         * tui/tui-winsource.c
 742         (tui_source_window_base::update_source_window): Rename from
 743         tui_update_source_window.
 744         (tui_source_window_base::rerender): Update.
 745         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 746         * tui/tui-disasm.c (tui_show_disassem)
 747         (tui_show_disassem_and_update_source)
 748         (tui_disasm_window::maybe_update): Update.
 749
 750 2019-08-16  Tom Tromey  <tom@tromey.com>
 751
 752         * tui/tui-winsource.h (struct tui_source_window_base)
 753         <update_source_window_as_is>: Declare.
 754         (tui_update_source_window_as_is): Don't declare.
 755         * tui/tui-winsource.c (tui_update_source_window): Update
 756         (tui_source_window_base::update_source_window_as_is): Rename from
 757         tui_update_source_window_as_is.
 758         (tui_source_window_base::refill): Update.
 759         * tui/tui-source.c (tui_show_symtab_source): Update.
 760         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 761         Update.
 762
 763 2019-08-16  Tom Tromey  <tom@tromey.com>
 764
 765         * tui/tui-winsource.h (tui_update_source_window)
 766         (tui_update_source_window_as_is): Remove "noerror" parameter.
 767         * tui/tui-winsource.c (tui_update_source_window)
 768         (tui_update_source_window_as_is): Remove "noerror" parameter.
 769         (tui_update_source_windows_with_addr)
 770         (tui_update_source_windows_with_line)
 771         (tui_source_window_base::rerender)
 772         (tui_source_window_base::refill): Update.
 773         * tui/tui-source.h (tui_set_source_content)
 774         (tui_show_symtab_source): Remove "noerror" parameter.
 775         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 776         parameter.
 777         (tui_show_symtab_source): Likewise.
 778         (tui_source_window::maybe_update): Update.
 779         * tui/tui-disasm.c (tui_show_disassem)
 780         (tui_show_disassem_and_update_source)
 781         (tui_disasm_window::do_scroll_vertical)
 782         (tui_disasm_window::maybe_update): Update.
 783
 784 2019-08-16  Tom Tromey  <tom@tromey.com>
 785
 786         * tui/tui.c (tui_is_window_visible): Update.
 787         * tui/tui-wingeneral.c (tui_make_window)
 788         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 789         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 790         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 791         (tui_set_win_height_command, parse_scrolling_args): Update.
 792         * tui/tui-source.c (tui_source_window::style_changed): Update.
 793         * tui/tui-regs.c (tui_show_registers)
 794         (tui_data_window::first_data_item_displayed)
 795         (tui_data_window::delete_data_content_windows)
 796         (tui_check_register_values, tui_reg_command): Update.
 797         * tui/tui-disasm.c (tui_show_disassem): Update.
 798         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 799         method.
 800         <is_visible>: Remove field.
 801         * tui/tui-data.c (tui_next_win, tui_prev_win)
 802         (tui_delete_invisible_windows): Update.
 803
 804 2019-08-16  Tom Tromey  <tom@tromey.com>
 805
 806         * tui/tui-winsource.h (struct tui_source_window_base)
 807         <m_has_locator>: Remove.
 808         * tui/tui-layout.c (show_source_disasm_command, show_data)
 809         (show_source_or_disasm_and_command): Update.
 810
 811 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 812
 813         * NEWS (Other MI changes): New subsection.
 814         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 815         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 816         * arch-utils.c (default_get_pc_address_flags): New function.
 817         * arch-utils.h (default_get_pc_address_flags): New declaration.
 818         * gdbarch.sh: Add get_pc_address_flags.
 819         * gdbarch.c: Regenerate.
 820         * gdbarch.h: Likewise.
 821         * stack.c (print_pc): New function.
 822         (print_frame_info) (print_frame): Call print_pc.
 823
 824 2019-08-16  Tom de Vries  <tdevries@suse.de>
 825
 826         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 827         print_objfile_section_info.
 828
 829 2019-08-15  Tom Tromey  <tom@tromey.com>
 830
 831         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 832         calling update_cmdwin_start_line.
 833         * tui/tui-winsource.h (struct tui_source_window_base)
 834         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 835         <rerender>: Declare.
 836         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 837         Call rerender.
 838         (tui_source_window_base::set_new_height): Remove.
 839         (tui_source_window_base::rerender): Rename from
 840         do_make_visible_with_new_height.
 841         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 842         resize method.
 843         (tui_win_info::make_invisible_and_set_new_height)
 844         (tui_win_info::make_visible_with_new_height): Remove.
 845         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 846         Declare.
 847         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 848         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 849         do_make_visible_with_new_height>: Don't declare.
 850         <rerender>: Declare.
 851         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 852         set_new_height.
 853         (tui_data_window::do_make_visible_with_new_height): Remove.
 854         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 855         call tui_show_locator_content.
 856         (tui_gen_win_info::resize): Call rerender.
 857         (show_source_or_disasm_and_command): Don't call
 858         tui_show_locator_content.
 859         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 860         method.
 861         (struct tui_win_info) <rerender>: Declare.
 862         <set_new_height, make_invisible_and_set_new_height,
 863         make_visible_with_new_height>: Don't declare.
 864         * tui/tui-data.c (tui_win_list::rerender): New method.
 865         * tui/tui-command.h (struct tui_cmd_window)
 866         <do_make_visible_with_new_height>: Don't declare.
 867         * tui/tui-command.c
 868         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 869
 870 2019-08-15  Tom Tromey  <tromey@adacore.com>
 871
 872         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 873         * ada-lang.c (ada_enum_name): Likewise.
 874
 875 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 876
 877         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 878         leading underscore.
 879         (GdbOutputErrorFile): Likewise.
 880         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 881         accordingly.
 882         (execute_unwinders): Rename to have a leading underscore.
 883         (auto_load_packages): Likewise.
 884         (global scope): Adjust call to auto_load_packages accordingly.
 885         (GdbSetPythonDirectory): Likewise.
 886         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 887         instead of execute_unwinders.
 888
 889 2019-08-15  Tom Tromey  <tom@tromey.com>
 890
 891         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 892         (show_data): Don't change window visibility.
 893         (tui_gen_win_info::resize): Remove special case for command
 894         window.  Use wresize, when available.
 895         (show_source_or_disasm_and_command): Don't change window
 896         visibility.
 897         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 898         <make_visible>: New method.
 899         * tui/tui-command.c (tui_cmd_window::resize): New method.
 900
 901 2019-08-15  Tom Tromey  <tom@tromey.com>
 902
 903         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 904         (struct tui_source_windows): New.
 905         * tui/tui-winsource.c (tui_display_main): Update.
 906         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 907         (new_height_ok, parse_scrolling_args): Update.
 908         * tui/tui-layout.c (show_layout, show_data): Update.
 909         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 910         (tui_add_to_source_windows): Don't declare.
 911         * tui/tui-data.c (source_windows, tui_source_windows)
 912         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 913
 914 2019-08-15  Tom Tromey  <tom@tromey.com>
 915
 916         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 917         Rename from reset.
 918         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 919         * tui/tui-layout.c (show_source_disasm_command, show_data):
 920         Update.
 921         (tui_gen_win_info::resize): Rename.
 922         (show_source_or_disasm_and_command): Update.
 923         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 924         reset.
 925
 926 2019-08-15  Tom Tromey  <tom@tromey.com>
 927
 928         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 929         * tui/tui-interp.c (tui_interp::init): Don't call
 930         tui_initialize_static_data.
 931         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 932
 933 2019-08-15  Tom Tromey  <tom@tromey.com>
 934
 935         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 936         examine tui_win_list.
 937
 938 2019-08-15  Tom Tromey  <tom@tromey.com>
 939
 940         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 941         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 942         tui_clear_source_content.
 943         (tui_clear_source_content): Remove.
 944         (tui_source_window_base::do_erase_source_content): Hoist call to
 945         content.clear().
 946         * tui/tui-stack.c (tui_show_frame_info): Don't call
 947         tui_clear_source_content.
 948
 949 2019-08-15  Tom Tromey  <tom@tromey.com>
 950
 951         * tui/tui-winsource.h (struct tui_source_window_base)
 952         <do_erase_source_content>: New method.
 953         <erase_source_content>: New method.
 954         (tui_erase_source_content): Don't declare.
 955         * tui/tui-winsource.c (tui_clear_source_content): Update.
 956         (tui_source_window_base::do_erase_source_content): Rename from
 957         tui_erase_source_content.
 958         (tui_source_window_base::show_source_content): Update.
 959         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 960         * tui/tui-source.h (struct tui_source_window)
 961         <erase_source_content>: New method.
 962         * tui/tui-disasm.h (struct tui_disasm_window)
 963         <erase_source_content>: New method.
 964
 965 2019-08-15  Tom Tromey  <tom@tromey.com>
 966
 967         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 968         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 969         constructor.
 970         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 971         * tui/tui-source.c (tui_set_source_content): Update.
 972         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 973
 974 2019-08-15  Tom Tromey  <tom@tromey.com>
 975
 976         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 977         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 978         tui-source.c.
 979         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 980         Declare.
 981         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 982         method.
 983         (tui_source_window::maybe_update): Update.
 984
 985 2019-08-15  Tom Tromey  <tom@tromey.com>
 986
 987         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 988         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 989         tui-disasm.c.
 990         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 991         Declare.
 992         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 993         method.
 994         (tui_disasm_window::maybe_update): Update.
 995
 996 2019-08-15  Tom Tromey  <tom@tromey.com>
 997
 998         * tui/tui-winsource.h (struct tui_source_window_base)
 999         <maybe_update>: Declare.
1000         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1001         method.
1002         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1003         Declare.
1004         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1005         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1006         Declare.
1007         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1008
1009 2019-08-15  Tom Tromey  <tom@tromey.com>
1010
1011         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1012
1013 2019-08-15  Tom Tromey  <tom@tromey.com>
1014
1015         * tui/tui-wingeneral.c: Include tui-stack.h.
1016         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1017         (struct tui_locator_window): Move from tui-data.h.
1018         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1019         (tui_initialize_static_data): Move from tui-data.c.
1020         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1021         (struct tui_locator_window): Move to tui-stack.c.
1022         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1023         (tui_initialize_static_data): Move to tui-stack.c.
1024
1025 2019-08-15  Tom Tromey  <tom@tromey.com>
1026
1027         * tui/tui-layout.c (show_source_disasm_command)
1028         (show_source_or_disasm_and_command): Use make_visible method, not
1029         tui_make_window.
1030         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1031         Remove.
1032
1033 2019-08-15  Tom Tromey  <tom@tromey.com>
1034
1035         * tui/tui-wingeneral.h (tui_make_window): Update.
1036         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1037         parameter.
1038         (tui_gen_win_info::make_visible): Update.
1039         * tui/tui-regs.c (tui_data_window::display_registers_from):
1040         Update.
1041         * tui/tui-layout.c (show_source_disasm_command)
1042         (show_source_or_disasm_and_command): Update.
1043         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1044         (enum tui_box): Remove.
1045         (struct tui_win_info) <can_box>: New method.
1046         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1047         method.
1048
1049 2019-08-15  Tom de Vries  <tdevries@suse.de>
1050
1051         * linux-nat-trad.c: Include gdbarch.h.
1052
1053 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1054
1055         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1056         register sizes.
1057
1058 2019-08-14  Tom Tromey  <tromey@adacore.com>
1059
1060         * darwin-nat.c: Include gdbarch.h.
1061         * darwin-nat-info.c: Include gdbarch.h.
1062
1063 2019-08-13  Tom Tromey  <tom@tromey.com>
1064
1065         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1066         Remove.
1067         * tui/tui-data.c (tui_initialize_static_data): Update.
1068
1069 2019-08-13  Tom Tromey  <tom@tromey.com>
1070
1071         * tui/tui-winsource.h (struct tui_exec_info_window)
1072         <~tui_exec_info_window, maybe_allocate_content, get_content,
1073         m_content>: Remove.
1074         (struct tui_source_window_base) <set_exec_info_content,
1075         show_exec_info_content>: Don't declare.
1076         * tui/tui-winsource.c
1077         (tui_exec_info_window::maybe_allocate_content): Remove.
1078         (tui_source_window_base::update_exec_info): Rename from
1079         set_exec_info_content.
1080         (tui_source_window_base::show_exec_info_content)
1081         (tui_source_window_base::update_exec_info): Remove.
1082
1083 2019-08-13  Tom Tromey  <tom@tromey.com>
1084
1085         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1086         declare.
1087         * tui/tui-winsource.c (tui_update_source_window_as_is)
1088         (tui_update_source_windows_with_addr, tui_erase_source_content):
1089         Update.
1090         (tui_clear_exec_info_content): Remove.
1091
1092 2019-08-13  Tom Tromey  <tom@tromey.com>
1093
1094         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1095         declare.
1096         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1097         call tui_erase_exec_info_content.
1098         (tui_clear_exec_info_content): Rename from
1099         tui_erase_exec_info_content.
1100         (tui_clear_exec_info_content): Delete.
1101
1102 2019-08-13  Tom Tromey  <tom@tromey.com>
1103
1104         * tui/tui-winsource.h (struct tui_source_window_base)
1105         <show_exec_info_content>: Declare.
1106         (tui_show_exec_info_content): Don't declare.
1107         * tui/tui-winsource.c
1108         (tui_source_window_base::show_exec_info_content): Rename from
1109         tui_show_exec_info_content.
1110         (tui_source_window_base::update_exec_info): Update.
1111
1112 2019-08-13  Tom Tromey  <tom@tromey.com>
1113
1114         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1115         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1116         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1117         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1118         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1119         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1120         ... here.
1121
1122 2019-08-13  Tom Tromey  <tom@tromey.com>
1123
1124         * tui/tui-winsource.h (struct tui_source_window_base)
1125         <update_exec_info>: Declare.
1126         (tui_update_exec_info): Don't declare.
1127         * tui/tui-winsource.c (tui_update_source_window_as_is)
1128         (tui_source_window_base::refresh_all)
1129         (tui_update_all_breakpoint_info): Update.
1130         (tui_source_window_base::update_exec_info): Rename from
1131         tui_update_exec_info.
1132         * tui/tui-stack.c (tui_show_frame_info): Update.
1133
1134 2019-08-13  Tom Tromey  <tom@tromey.com>
1135
1136         * tui/tui-winsource.h (struct tui_source_window_base)
1137         <set_exec_info_content>: Declare.
1138         (tui_set_exec_info_content): Don't declare.
1139         * tui/tui-winsource.c
1140         (tui_source_window_base::set_exec_info_content): Rename from
1141         tui_set_exec_info_content.
1142         (tui_update_exec_info): Update.
1143
1144 2019-08-13  Tom Tromey  <tom@tromey.com>
1145
1146         * tui/tui-winsource.h (struct tui_source_window_base)
1147         <show_source_content>: Declare.
1148         (tui_show_source_content): Don't declare.
1149         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1150         (tui_source_window_base::show_source_content): Rename from
1151         tui_show_source_content.
1152         (tui_source_window_base::refresh_all): Update.
1153         * tui/tui-layout.c (show_source_disasm_command)
1154         (show_source_or_disasm_and_command): Update.
1155
1156 2019-08-13  Tom Tromey  <tom@tromey.com>
1157
1158         * tui/tui-winsource.c (tui_erase_source_content)
1159         (tui_show_source_content, tui_source_window_base::refresh_all):
1160         Update.
1161         * tui/tui-wingeneral.h
1162         (tui_check_and_display_highlight_if_needed): Don't declare.
1163         * tui/tui-wingeneral.c
1164         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1165         check_and_display_highlight_if_needed.
1166         * tui/tui-win.c (tui_rehighlight_all)
1167         (tui_win_info::make_visible_with_new_height): Update.
1168         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1169         (tui_data_window::erase_data_content)
1170         (tui_data_window::display_all_data): Update.
1171         * tui/tui-data.h (struct tui_win_info)
1172         <check_and_display_highlight_if_needed>: Declare.
1173
1174 2019-08-13  Tom Tromey  <tom@tromey.com>
1175
1176         * tui/tui-win.c (tui_resize_all): Call
1177         tui_delete_invisible_windows.
1178         * tui/tui-layout.c (show_layout): Call
1179         tui_delete_invisible_windows.
1180         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1181         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1182
1183 2019-08-13  Tom Tromey  <tom@tromey.com>
1184
1185         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1186         tui_add_win_to_layout.
1187
1188 2019-08-13  Tom Tromey  <tom@tromey.com>
1189
1190         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1191         * tui/tui-layout.c (tui_default_win_height): Now static.
1192
1193 2019-08-13  Tom Tromey  <tom@tromey.com>
1194
1195         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1196         single switch.
1197         (show_source_disasm_command, show_source_or_disasm_and_command):
1198         Don't check current layout.
1199
1200 2019-08-13  Tom Tromey  <tom@tromey.com>
1201
1202         * tui/tui-wingeneral.c (make_all_visible): Remove.
1203         (tui_make_all_invisible): Simplify.
1204         * tui/tui-layout.c (tui_make_all_invisible): Move from
1205         tui-wingeneral.c; simplify.
1206         (show_layout): Hoist call to tui_make_all_invisible.
1207         (show_data): Don't call tui_make_all_invisible.
1208
1209 2019-08-13  Tom Tromey  <tom@tromey.com>
1210
1211         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1212         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1213
1214 2019-08-13  Tom Tromey  <tom@tromey.com>
1215
1216         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1217         tui-data.c.
1218         (show_source_disasm_command, show_data)
1219         (show_source_or_disasm_and_command): Don't use
1220         tui_set_current_layout_to.
1221         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1222         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1223         tui-layout.c.
1224         (tui_set_current_layout_to): Remove.
1225
1226 2019-08-13  Tom Tromey  <tom@tromey.com>
1227
1228         * tui/tui-layout.c (tui_set_layout): Update.
1229         * tui/tui-data.h (struct tui_layout_def): Remove.
1230         (tui_layout_def): Don't declare.
1231         * tui/tui-data.c (layout_def): Remove.
1232         (tui_layout_def): Remove.
1233
1234 2019-08-13  Tom Tromey  <tom@tromey.com>
1235
1236         * tui/tui-winsource.h (struct tui_source_window_base)
1237         <clear_detail>: No longer "override".
1238         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1239         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1240         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1241         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1242         Remove.
1243         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1244
1245 2019-08-13  Tom Tromey  <tromey@adacore.com>
1246
1247         * tracepoint.c: Don't include readline.h or history.h.
1248
1249 2019-08-12  Tom Tromey  <tom@tromey.com>
1250
1251         * configure: Rebuild.
1252         * configure.ac: Check for readline 7.
1253         * NEWS: Mention readline 7 requirement.
1254         * README: Update.
1255
1256 2019-08-12  Tom Tromey  <tom@tromey.com>
1257
1258         * mingw-hdep.c (gdb_select): Remove readline hack.
1259
1260 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1261
1262         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1263         when the function fails.
1264
1265 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1266
1267         * s390-tdep.c (s390_type_align): New function.
1268         (s390_gdbarch_init): Set it as type_align gdbarch method.
1269
1270 2019-08-09  Tom de Vries  <tdevries@suse.de>
1271
1272         PR gdb/24591
1273         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1274         pc_low with relocation offset.
1275
1276 2019-08-07  Tom Tromey  <tromey@adacore.com>
1277
1278         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1279         (print_frame_args): Update.
1280         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1281         Update.
1282         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1283         * frame.h (struct frame_arg): Add initializers.
1284         <error>: Now a unique_xmalloc_ptr.
1285
1286 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1287
1288         * NEWS: Expand the Pointer Authentication entry.
1289         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1290         (aarch64_frame_unmask_lr): ... to this.
1291         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1292         Call aarch64_frame_unmask_lr.
1293         * frame.c (struct frame_info): Add "masked" variable.
1294         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1295         (fprint_frame): Check for masked pc.
1296         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1297         declarations.
1298         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1299         * stack.c (print_frame): Check for masked pc.
1300
1301 2019-08-06  Tom Tromey  <tom@tromey.com>
1302
1303         * stabsread.c (patch_block_stabs, read_one_struct_field)
1304         (read_enum_type): Use obstack_strndup.
1305         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1306         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1307         * dwarf2read.c (guess_full_die_structure_name)
1308         (anonymous_struct_prefix): Use obstack_strndup.
1309         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1310         * c-exp.y (yylex): Use obstack_strndup.
1311         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1312         (write_var_or_type): Use obstack_strndup.
1313
1314 2019-08-06  Tom Tromey  <tom@tromey.com>
1315
1316         * symfile.c (reread_symbols): Use obstack_strdup.
1317         * stabsread.c (read_type): Use obstack_strdup.
1318         * gdb_obstack.h (obstack_strdup): New overload.
1319         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1320         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1321         (dwarf2_canonicalize_name): Use obstack_strdup.
1322         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1323         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1324         Use obstack_strdup.
1325
1326 2019-08-06  Tom Tromey  <tom@tromey.com>
1327
1328         * gdb_obstack.h (obstack_strdup): Define.
1329         * gdb_obstack.c (obstack_strdup): Don't define.
1330
1331 2019-08-06  Tom Tromey  <tom@tromey.com>
1332
1333         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1334         obstack_strdup.
1335         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1336         obstack_strdup.
1337         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1338         * stabsread.c (common_block_start): Use obstack_strdup.
1339         * objfiles.c (set_objfile_main_name, objfile): Use
1340         obstack_strdup.
1341         * namespace.c (add_using_directive): Use obstack_strdup.
1342         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1343         * jit.c (finalize_symtab): Use obstack_strdup.
1344         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1345         (guess_partial_die_structure_name, partial_die_info::fixup)
1346         (dwarf2_name): Use obstack_strdup.
1347         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1348         obstack_strdup.
1349         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1350         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1351         obstack_strdup.
1352         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1353
1354 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1355
1356         * unittests/help-doc-selftests.c: New file.
1357         * Makefile.in: Add the new file.
1358
1359 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1360
1361         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1362         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1363         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1364         the trailing '.' is not output, and the first character is uppercased.
1365         (print_help_for_command): Update call to print_doc_line.
1366         (print_doc_of_command): Likewise.
1367         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1368         * cli/cli-option.c (append_indented_doc): Do not append newline.
1369         (build_help_option): Append newline after first appended_indented_doc
1370         only if a second call is done.
1371         (build_help): Append 2 new lines before each option, except the first
1372         one.
1373         * compile/compile.c (_initialize_compile): Add new lines after
1374         %OPTIONS%, when not at the end of the help.
1375         Change help doc or code
1376         producing the help doc to respect the invariants.
1377         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1378         Also removed the new line after 'Options:', as all other commands
1379         do not put an empty line between 'Options:' and the first option.
1380         * printcmd.c (_initialize_printcmd): Likewise.
1381         * stack.c (_initialize_stack): Likewise.
1382         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1383         incorrectly telling COMMAND is optional.
1384         * ada-lang.c (_initialize_ada_language): Change help doc or code
1385         producing the help doc to respect the invariants.
1386         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1387         * breakpoint.c (_initialize_breakpoint): Likewise.
1388         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1389         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1390         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1391         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1392         _initialize_cli_style): Likewise.
1393         * corelow.c (core_target_info): Likewise.
1394         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1395         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1396         * filesystem.c (_initialize_filesystem): Likewise.
1397         * frame.c (_initialize_frame): Likewise.
1398         * gnu-nat.c (add_task_commands): Likewise.
1399         * infcall.c (_initialize_infcall): Likewise.
1400         * infcmd.c (_initialize_infcmd): Likewise.
1401         * interps.c (_initialize_interpreter): Likewise.
1402         * language.c (_initialize_language): Likewise.
1403         * linux-fork.c (_initialize_linux_fork): Likewise.
1404         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1405         * maint.c (_initialize_maint_cmds): Likewise.
1406         * memattr.c (_initialize_mem): Likewise.
1407         * printcmd.c (_initialize_printcmd): Likewise.
1408         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1409         _RegEx): Likewise.
1410         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1411         * record-btrace.c (_initialize_record_btrace): Likewise.
1412         * record-full.c (_initialize_record_full): Likewise.
1413         * record.c (_initialize_record): Likewise.
1414         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1415         * regcache.c (_initialize_regcache): Likewise.
1416         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1417         _initialize_remote): Likewise.
1418         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1419         * serial.c (_initialize_serial): Likewise.
1420         * skip.c (_initialize_step_skip): Likewise.
1421         * source.c (_initialize_source): Likewise.
1422         * stack.c (_initialize_stack): Likewise.
1423         * symfile.c (_initialize_symfile): Likewise.
1424         * symtab.c (_initialize_symtab): Likewise.
1425         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1426         * top.c (init_main): Likewise.
1427         * tracefile-tfile.c (tfile_target_info): Likewise.
1428         * tracepoint.c (_initialize_tracepoint): Likewise.
1429         * tui/tui-win.c (_initialize_tui_win): Likewise.
1430         * utils.c (add_internal_problem_command): Likewise.
1431         * valprint.c (value_print_option_defs): Likewise.
1432
1433 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1434
1435         PR build/24886
1436         * configure.ac: Drop enable-libmcheck support.
1437         * configure, config.in: Rebuild.
1438         * libmcheck.m4: Remove.
1439         * acinclude.m4: Don't include it.
1440         * Makefile.in: Don't distribute it.
1441         * top.c (print_gdb_configuration): Don't mention it.
1442
1443 2019-08-06  Tom Tromey  <tom@tromey.com>
1444
1445         * utils.c (set_output_style): Sometimes pass stream to
1446         emit_style_escape.
1447         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1448         * record-btrace.c (btrace_insn_history): Update.
1449         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1450         method.
1451         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1452         Update initializers.
1453         <m_uiout>: New field.
1454         <m_di>: Move lower.
1455         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1456         Remove "uiout" parameter.
1457         (dump_insns): Update.
1458         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1459         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1460
1461 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1462
1463         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1464         (error_in_psymtab_expansion): Likewise.
1465         (lookup_symbol_via_quick_fns): Likewise.
1466         (basic_lookup_transparent_type_quick): Likewise.
1467         (basic_lookup_transparent_type_1): Likewise.
1468
1469 2019-08-06  Tom Tromey  <tromey@adacore.com>
1470
1471         * source.c (last_source_error): Now bool.
1472         (print_source_lines_base): Make "noprint" bool.  Only open
1473         source file when last_source_visited changes.
1474
1475 2019-08-06  Tom Tromey  <tromey@adacore.com>
1476
1477         * annotate.c (annotate_source_line): Use g_source_cache.
1478         * source-cache.c (source_cache::get_plain_source_lines): Change
1479         parameters.  Populate m_offset_cache.
1480         (source_cache::ensure): New method.
1481         (source_cache::get_line_charpos): New method.
1482         (extract_lines): Move lower.  Change parameters.
1483         (source_cache::get_source_lines): Move lower.
1484         * source-cache.h (class source_cache): Update comment.
1485         <get_line_charpos>: New method.
1486         <get_source_lines>: Update comment.
1487         <clear>: Clear m_offset_cache.
1488         <get_plain_source_lines>: Change parameters.
1489         <ensure>: New method
1490         <m_offset_cache>: New member.
1491         * source.c (forget_cached_source_info_for_objfile): Update.
1492         (info_source_command): Use g_source_cache.
1493         (find_source_lines, open_source_file_with_line_charpos): Remove.
1494         (print_source_lines_base, search_command_helper): Use g_source_cache.
1495         * source.h (open_source_file_with_line_charpos): Don't declare.
1496         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1497         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1498         Use g_source_cache.
1499
1500 2019-08-06  Tom Tromey  <tromey@adacore.com>
1501
1502         * source-cache.c (source_cache::get_plain_source_lines):
1503         Remove "first_line" and "last_line" parameters.
1504         (source_cache::get_source_lines): Cache plain text.
1505         * source-cache.h (class source_cache)
1506         <get_plain_source_lines>: Update.
1507
1508 2019-08-06  Tom Tromey  <tromey@adacore.com>
1509
1510         * source-cache.c (extract_lines): No longer a method.
1511         Changed type of parameter.  Include final newline.
1512         (selftests::extract_lines_test): New function.
1513         (_initialize_source_cache): Likewise.
1514         * source-cache.h (class source_cache)
1515         <extract_lines>: Don't declare.
1516
1517 2019-08-06  Tom Tromey  <tromey@adacore.com>
1518
1519         * breakpoint.c (init_breakpoint_sal): Update.
1520         (breakpoint): Update.
1521         * breakpoint.h (struct breakpoint) <filter>: Now a
1522         unique_xmalloc_ptr.
1523
1524 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1525
1526         * NEWS: Mention dictionary access on blocks.
1527         * python/py-block.c (blpy_getitem): New function.
1528         (block_object_as_mapping): New struct.
1529         (block_object_type): Use new struct for tp_as_mapping field.
1530
1531 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1532
1533         * objfiles.h (objfile): Add a comment describing partial symbols.
1534
1535 2019-08-05  Tom Tromey  <tromey@adacore.com>
1536
1537         * compile/compile.c (_initialize_compile): Use _(), not N_().
1538         * thread.c (_initialize_thread): Use _(), not N_().
1539         * stack.c (_initialize_stack): Use _(), not N_().
1540         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1541
1542 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1543
1544         * dwarf2read.c (struct dw2_symtab_iterator):
1545         <want_specific_block>: Remove.
1546         <block_index>: Change type to gdb::optional.
1547         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1548         change type of BLOCK_INDEX parameter to gdb::optional.
1549         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1550         (dw2_lookup_symbol): Don't pass argument for
1551         WANT_SPECIFIC_BLOCK.
1552         (dw2_expand_symtabs_for_function): Don't pass argument for
1553         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1554         (class dw2_debug_names_iterator)
1555         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1556         parameter, change BLOCK_INDEX type to gdb::optional.
1557         <m_want_specific_block>: Remove.
1558         <m_block_index>: Change type to gdb::optional.
1559         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1560         gdb::optional.  Re-write in function of gdb::optional.
1561         (dw2_debug_names_lookup_symbol): Don't pass argument for
1562         WANT_SPECIFIC_BLOCK.
1563         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1564         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1565         BLOCK_INDEX.
1566
1567 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1568
1569         * NEWS: Mention changes to "info sources" command.
1570
1571 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1572
1573         * symtab.c (filename_partial_match_opts): New struct type.
1574         (struct output_source_filename_data): New members
1575         regexp, c_regexp, partial_match.
1576         (output_source_filename): Use new members to decide to print file.
1577         (info_sources_option_defs): New variable.
1578         (make_info_sources_options_def_group, print_info_sources_header,
1579         info_sources_command_completer):
1580         New functions.
1581         (info_sources_command): Read new optional arguments.
1582         (_initialize_symtab): Update info sources help.
1583
1584 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1585
1586         * ada-lang.c (exception_support_info_v0): Renamed from...
1587         (default_exception_support_info): ... this.  Create new
1588         definition for v1.
1589         (ada_has_this_exception_support): Look up catch_handlers_sym.
1590         (ada_exception_support_info_sniffer): Try v0 after default.
1591
1592 2019-08-01  Tom Tromey  <tromey@adacore.com>
1593
1594         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1595         gdbarch.h.
1596
1597 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1598
1599         * s12z-tdep.c: Fix include path for s12z-opc.h.
1600
1601 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1602
1603         * NEWS: Require GNU make 3.82.
1604
1605 2019-07-16  Tom Tromey  <tom@tromey.com>
1606
1607         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1608         declare.
1609
1610 2019-07-30  Tom Tromey  <tromey@adacore.com>
1611
1612         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1613
1614 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1615
1616         * printcmd.c (print_address_symbolic): Print negative offsets.
1617         (build_address_symbolic): Force signed arithmetic when computing
1618         offset.
1619
1620 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1621
1622         PR/24474: Add a function to lookup static variables.
1623         * NEWS: Mention this new function.
1624         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1625         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1626         * python/python.c (python_GdbMethods): Add new function.
1627
1628 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1629
1630         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1631         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1632         (objfpy_lookup_static_symbol): New function.
1633         (objfile_object_methods): Add new functions.
1634
1635 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1636
1637         * NEWS: Mention 'set|show print frame-info'.  Mention new
1638         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1639         backtrace argument.  Mention that python frame filtering code
1640         is now consistent with what 'backtrace' command prints.
1641
1642 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1643
1644         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1645         comments.
1646         (print_frame_info_auto, print_frame_info_source_line,
1647         print_frame_info_location, print_frame_info_source_and_location,
1648         print_frame_info_location_and_address, print_frame_info_short_location):
1649         New declarations.
1650         (struct frame_print_options): New member print_frame_info.
1651         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1652         * stack.h (get_user_print_what_frame_info): New declaration.
1653         (frame_show_address): New declaration.
1654         * stack.c (print_frame_arguments_choices): New value 'presence'.
1655         (print_frame_info_auto, print_frame_info_source_line,
1656         print_frame_info_location, print_frame_info_source_and_location,
1657         print_frame_info_location_and_address, print_frame_info_short_location,
1658         print_frame_info_choices, print_frame_info_print_what): New definitions.
1659         (print_frame_args): Only print dots for args if print frame-arguments
1660         is 'presence'.
1661         (frame_print_option_defs): New element for "frame-info".
1662         (get_user_print_what_frame_info): New function.
1663         (frame_show_address): Make non static.  Move comment to stack.h.
1664         (print_frame_info_to_print_what): New function.
1665         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1666         to decide what to print.
1667         (backtrace_command_1): Handle the new print_frame_arguments_presence
1668         value.
1669         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1670         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1671         (py_print_frame): In non-mi mode, use LOCATION as default for
1672         print_what, similarly to frame information printed directly by
1673         backtrace command. Handle frame-info user option in non MI mode.
1674
1675 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1676
1677         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1678         Add case for debugging 32-bit target on 64-bit host.  Revise
1679         comment.
1680
1681 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1682
1683         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1684         instead of find_function_entry_range_from_pc.
1685
1686 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1687
1688         * stack.c (find_frame_funname): Remove code which preferred
1689         minsym over symtab sym in "certain pathological cases".
1690
1691         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1692         parameter.  Change type of "do_demangle" to bool.
1693         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1694         Pass suitable "prefer_sym_over_minsym" flag to
1695         build_address_symbolic().  Don't output "+" for negative offsets.
1696         * printcmd.c (print_address_symbolic): Update invocation of
1697         build_address_symbolic to include a "prefer_sym_over_minsym"
1698         flag.
1699         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1700         Restrict cases in which use of minimal symbol is preferred to that
1701         of a found symbol.  Update comments.
1702
1703         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1704         for entry pc when entry pc is out of range for that FDE.
1705
1706 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1707
1708         PR gdb/24839:
1709         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1710         type.
1711
1712 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1713
1714         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1715         this function's Python signature.
1716
1717
1718 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1719
1720         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1721         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1722         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1723         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1724         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1725
1726
1727 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1728
1729         * h8300-tdep.c (h8300_register_name_common): New.
1730         h8300_register_name): Use h8300_register_name_common.
1731         (h8300s_register_name): Likewise.
1732         (h8300sx_register_name): Likewise.
1733         (h8300h_register_nam): New.
1734         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1735
1736
1737 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1738
1739         * arm-tdep.c (arm_skip_cmse_entry): New function.
1740         (arm_is_sgstubs_section): New function.
1741         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1742
1743 2019-07-22  Tom Tromey  <tom@tromey.com>
1744
1745         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1746         Don't self-assign.
1747
1748 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1749
1750         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1751         type_print.
1752
1753 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1754
1755         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1756         so that GDB doesn't match any msymbols when searching in the
1757         TYPES_DOMAIN.
1758         (print_symbol_info): Print using typedef_print or type_print based
1759         on the type of the symbol.  Add updated FIXME comment moved from...
1760         (_initialize_symtab): ... move and update FIXME comment to above.
1761
1762 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1763
1764         * NEWS: Mention adding -q option to "info types".
1765         * symtab.c (struct info_types_options): New struct.
1766         (info_types_options_defs): New variable.
1767         (make_info_types_options_def_group): New function.
1768         (info_types_command): Use gdb::option framework to parse options.
1769         (info_types_command_completer): New function.
1770         (_initialize_symtab): Extend the help text on "info types" and
1771         register command completer.
1772
1773 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1774
1775         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1776         (lookup_symbol_in_objfile): Change int to block_enum and add a
1777         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1778
1779 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1780
1781         * MAINTAINERS (Write After Approval): Add self.
1782
1783 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1784
1785         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1786         instruction to the dummy code region.
1787
1788 2019-07-19  Tom Tromey  <tromey@adacore.com>
1789
1790         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1791         (ARGSUSED, PARAMS, __func__): Remove rules.
1792
1793 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1794
1795         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1796         * features/arm/arm-with-iwmmxt.c: Remove.
1797         * features/arm/arm-with-iwmmxt.xml: Remove.
1798         * features/arm/arm-with-m-fpa-layout.c: Remove.
1799         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1800         * features/arm/arm-with-m-vfp-d16.c: Remove.
1801         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1802         * features/arm/arm-with-m.c: Remove.
1803         * features/arm/arm-with-m.xml: Remove.
1804         * features/arm/arm-with-neon.c: Remove.
1805         * features/arm/arm-with-neon.xml: Remove.
1806         * features/arm/arm-with-vfpv2.c: Remove.
1807         * features/arm/arm-with-vfpv2.xml: Remove.
1808         * features/arm/arm-with-vfpv3.c: Remove.
1809         * features/arm/arm-with-vfpv3.xml: Remove.
1810
1811 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1812
1813         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1814
1815 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1816
1817         * arch/aarch32.c (aarch32_create_target_description): Create
1818         target descriptions using features.
1819         * arch/arm.c (arm_create_target_description)
1820         (arm_create_mprofile_target_description): Likewise.
1821         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1822
1823 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1824
1825         * Makefile.in: Add new files.
1826         * aarch32-tdep.c: New file.
1827         * aarch32-tdep.h: New file.
1828         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1829         Call aarch32_read_description.
1830         * arch/aarch32.c: New file.
1831         * arch/aarch32.h: New file.
1832         * arch/arm.c (arm_create_target_description)
1833         (arm_create_mprofile_target_description): New function.
1834         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1835         (arm_create_target_description)
1836         (arm_create_mprofile_target_description): New declaration.
1837         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1838         read_description functions.
1839         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1840         Likewise.
1841         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1842         * arm-tdep.c (tdesc_arm_list): New variable.
1843         (arm_register_g_packet_guesses): Call create description functions.
1844         (arm_read_description) (arm_read_mprofile_description): New
1845         function.
1846         * arm-tdep.h (arm_read_description)
1847         (arm_read_mprofile_description): Add declaration.
1848         * configure.tgt: Add new files.
1849
1850 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1851
1852         * top.c (new_ui_command): Open specified terminal just once.
1853
1854 2019-07-18  Tom Tromey  <tromey@adacore.com>
1855
1856         * symtab.c (main_name): Constify return type.
1857         * symfile.c (set_initial_language): Update.
1858         * symtab.h (main_name): Constify return type.
1859
1860 2019-07-17  Tom Tromey  <tom@tromey.com>
1861
1862         * tui/tui-winsource.c (tui_update_source_window)
1863         (tui_update_source_window_as_is)
1864         (tui_update_source_windows_with_line): Remove return.
1865         * tui/tui-disasm.c (tui_show_disassem)
1866         (tui_show_disassem_and_update_source): Remove return.
1867         * tui/tui.c (tui_reset): Remove return.
1868         * tui/tui-wingeneral.c
1869         (tui_check_and_display_highlight_if_needed): Remove return.
1870
1871 2019-07-17  Tom Tromey  <tom@tromey.com>
1872
1873         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1874
1875 2019-07-17  Tom Tromey  <tom@tromey.com>
1876
1877         * tui/tui-winsource.h (struct tui_exec_info_window)
1878         (struct tui_source_window_base): Move from tui-data.h.
1879         * tui/tui-winsource.c: Move many method definitions from
1880         elsewhere.  Remove "structuring" comments.
1881         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1882         (tui_source_window_base::refresh_window): Move to
1883         tui-winsource.c.
1884         * tui/tui-win.c (tui_source_window_base::refresh_all)
1885         (tui_source_window_base::update_tab_width)
1886         (tui_source_window_base::set_new_height)
1887         (tui_source_window_base::do_make_visible_with_new_height): Move to
1888         tui-winsource.c.
1889         * tui/tui-source.h: Update.
1890         * tui/tui-source.c (tui_source_window_base::reset): Move to
1891         tui-winsource.c.
1892         * tui/tui-disasm.h: Update.
1893         * tui/tui-data.h (struct tui_exec_info_window): Move to
1894         tui-winsource.h.
1895         (struct tui_source_window_base): Likewise.
1896         * tui/tui-data.c (tui_source_window_base::clear_detail)
1897         (tui_source_window_base, ~tui_source_window_base): Move to
1898         tui-winsource.c.
1899
1900 2019-07-17  Tom Tromey  <tom@tromey.com>
1901
1902         * tui/tui-win.c (tui_resize_all)
1903         (tui_source_window_base::update_tab_width)
1904         (tui_adjust_win_heights): Update.
1905         (tui_win_info::make_invisible_and_set_new_height): Rename from
1906         make_invisible_and_set_new_height.
1907         * tui/tui-data.h (struct tui_win_info)
1908         <make_invisible_and_set_new_height>: New method.
1909
1910 2019-07-17  Tom Tromey  <tom@tromey.com>
1911
1912         * tui/tui.c: Update.
1913         * tui/tui-source.h (struct tui_source_window): Move from
1914         tui-data.h.
1915         * tui/tui-layout.c: Update.
1916         * tui/tui-disasm.c: Update.
1917         * tui/tui-data.h (struct tui_source_window): Move to
1918         tui-source.h.
1919
1920 2019-07-17  Tom Tromey  <tom@tromey.com>
1921
1922         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1923         tui-data.h.
1924         * tui/tui-data.h (struct tui_disasm_window): Move to
1925         tui-disasm.h.
1926
1927 2019-07-17  Tom Tromey  <tom@tromey.com>
1928
1929         * tui/tui-regs.h (struct tui_data_item_window): Move from
1930         tui-data.h.
1931         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1932         * tui/tui-data.h (struct tui_data_item_window): Move to
1933         tui-regs.h.
1934         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1935
1936 2019-07-17  Tom Tromey  <tom@tromey.com>
1937
1938         * tui/tui.c: Update.
1939         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1940         (tui_cmd_window::max_height): Move to tui-command.c.
1941         * tui/tui-layout.c: Update.
1942         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1943         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1944         tui-command.c.
1945         * tui/tui-command.h (struct tui_cmd_window): Move from
1946         tui-data.h.
1947         * tui/tui-command.c: Remove "structuring" comments.
1948         (tui_cmd_window::clear_detail)
1949         (tui_cmd_window::do_make_visible_with_new_height)
1950         (tui_cmd_window::max_height): Move from elsewhere.
1951
1952 2019-07-17  Tom Tromey  <tom@tromey.com>
1953
1954         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1955         Now static.
1956         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1957         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1958
1959 2019-07-17  Tom Tromey  <tom@tromey.com>
1960
1961         * tui/tui.c: Update.
1962         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1963         tui-regs.c.
1964         * tui/tui-windata.h: Remove file.
1965         * tui/tui-windata.c: Remove file.
1966         * tui/tui-win.c (tui_data_window::set_new_height)
1967         (tui_data_window::do_make_visible_with_new_height): Move to
1968         tui-regs.c.
1969         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1970         * tui/tui-regs.c: Remove "structuring" comments.
1971         (tui_data_window::first_data_item_displayed)
1972         (tui_data_window::delete_data_content_windows)
1973         (tui_data_window::erase_data_content)
1974         (tui_data_window::display_all_data)
1975         (tui_data_window::refresh_all)
1976         (tui_data_window::do_scroll_vertical)
1977         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1978         (tui_data_window::do_make_visible_with_new_height)
1979         (tui_data_window::refresh_window): Move from elsewhere.
1980         (_initialize_tui_regs): Move to end of file.
1981         * tui/tui-layout.c: Update.
1982         * tui/tui-hooks.c: Update.
1983         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1984         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1985         tui-regs.c.
1986         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1987
1988 2019-07-17  Tom Tromey  <tom@tromey.com>
1989
1990         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1991         seen.
1992
1993 2019-07-17  Tom Tromey  <tom@tromey.com>
1994
1995         * tui/tui-win.c (tui_source_window_base::set_new_height)
1996         (tui_source_window_base::do_make_visible_with_new_height): Use
1997         m_has_locator field directly.
1998         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1999         method.
2000         (struct tui_source_window_base) <has_locator>: Likewise.
2001
2002 2019-07-17  Tom Tromey  <tom@tromey.com>
2003
2004         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2005         Don't declare.
2006         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2007         Remove.
2008         * tui/tui-win.c (tui_source_window_base::set_new_height)
2009         (tui_source_window_base::set_new_height)
2010         (make_invisible_and_set_new_height)
2011         (tui_source_window_base::do_make_visible_with_new_height)
2012         (tui_source_window_base::do_make_visible_with_new_height):
2013         Update.
2014         * tui/tui-layout.c (show_source_disasm_command, show_data)
2015         (show_source_or_disasm_and_command): Update.
2016         * tui/tui-layout.c (show_layout): Update.
2017
2018 2019-07-17  Tom Tromey  <tom@tromey.com>
2019
2020         * tui/tui-layout.c (make_data_window): Remove.
2021         (show_data): Unify creation and re-initialization cases.
2022
2023 2019-07-17  Tom Tromey  <tom@tromey.com>
2024
2025         * tui/tui-layout.c (make_source_window, make_disasm_window):
2026         Remove.
2027         (show_data): Unify creation and re-initialization cases.
2028
2029 2019-07-17  Tom Tromey  <tom@tromey.com>
2030
2031         * tui/tui-layout.c (make_command_window): Remove.
2032         (show_source_disasm_command, show_source_or_disasm_and_command):
2033         Unify creation and re-initialization cases.
2034
2035 2019-07-17  Tom Tromey  <tom@tromey.com>
2036
2037         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2038         creation and re-initialization cases.
2039
2040 2019-07-17  Tom Tromey  <tom@tromey.com>
2041
2042         * tui/tui-regs.c (tui_get_register): Return void.
2043
2044 2019-07-17  Tom Tromey  <tom@tromey.com>
2045
2046         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2047         Simplify.
2048
2049 2019-07-17  Tom Tromey  <tom@tromey.com>
2050
2051         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2052         resetting.
2053
2054 2019-07-17  Tom Tromey  <tom@tromey.com>
2055
2056         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2057         * tui/tui-regs.c (tui_reg_layout): New function.
2058         (tui_show_registers, tui_reg_command): Use it.
2059         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2060         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2061         parameters.
2062         (tui_layout_command): Remove.
2063
2064 2019-07-17  Tom Tromey  <tom@tromey.com>
2065
2066         * tui/tui-layout.h (tui/tui-layout): Return void.
2067         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2068
2069 2019-07-17  Tom Tromey  <tom@tromey.com>
2070
2071         * tui/tui-layout.c (show_source_disasm_command, show_data):
2072         Update.
2073         (reset_locator): Remove.
2074         (show_source_or_disasm_and_command): Update.
2075
2076 2019-07-17  Tom Tromey  <tom@tromey.com>
2077
2078         * tui/tui-source.c (tui_source_window_base::reset): Remove
2079         win_type parameter.
2080         * tui/tui-layout.c (make_command_window, make_source_window)
2081         (make_disasm_window, make_data_window)
2082         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2083         (reset_locator, show_source_or_disasm_and_command): Update.
2084         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2085         win_type parameter.
2086         (struct tui_source_window_base) <reset>: Likewise.
2087
2088 2019-07-17  Tom Tromey  <tom@tromey.com>
2089
2090         * tui/tui-layout.c (show_source_disasm_command): Use
2091         reset_locator.
2092         (reset_locator): New function.
2093         (init_and_make_win): Remove.
2094         (show_source_or_disasm_and_command): Use reset_locator.
2095
2096 2019-07-17  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2099         condition.
2100         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2101         Remove condition.
2102         * tui/tui-source.c (tui_source_window_base::reset): New method.
2103         * tui/tui-layout.c (make_command_window): Don't call
2104         init_and_make_win.
2105         (make_source_window, make_disasm_window): Don't call
2106         make_source_or_disasm_window.
2107         (make_data_window): Don't call init_and_make_win.  Change calling
2108         convention.
2109         (show_source_disasm_command, show_data): Simplify.
2110         (make_source_or_disasm_window): Remove.
2111         (show_source_or_disasm_and_command): Simplify.
2112         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2113         (struct tui_source_window_base) <reset>: Likewise.
2114         <execution_info>: Remove initializer.
2115         * tui/tui-data.c (tui_source_window_base): Initialize
2116         execution_info.
2117
2118 2019-07-17  Tom Tromey  <tom@tromey.com>
2119
2120         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2121         variable.
2122
2123 2019-07-17  Tom Tromey  <tom@tromey.com>
2124
2125         * tui/tui.c (tui_rl_other_window): Update.
2126         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2127         superclass method first.  Always iterate over regs_content.
2128         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2129         method.
2130         * tui/tui-win.c (tui_set_focus_command): Update.
2131
2132 2019-07-17  Tom Tromey  <tom@tromey.com>
2133
2134         * tui/tui-win.c (tui_set_focus_command): Rename from
2135         tui_set_focus.  Call tui_enable.
2136         (tui_set_focus_command): Remove.
2137
2138 2019-07-17  Tom Tromey  <tom@tromey.com>
2139
2140         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2141         refresh_window.
2142         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2143         touchwin.
2144         (tui_data_window::refresh_window): Call refresh_window on data
2145         items.  Always call superclass refresh_window.
2146         (tui_win_info::refresh): Remove.
2147         (tui_source_window_base::refresh_window): Update.
2148         (tui_refresh_all): Update.
2149         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2150         refresh_window.
2151         (show_source_or_disasm_and_command): Likewise.
2152         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2153         (struct tui_source_window_base) <refresh>: Likewise.
2154
2155 2019-07-17  Tom Tromey  <tom@tromey.com>
2156
2157         * tui/tui-winsource.c (tui_clear_source_content)
2158         (tui_show_source_content): Update.
2159         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2160         whether content is empty.
2161         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2162         Remove.
2163
2164 2019-07-17  Tom Tromey  <tom@tromey.com>
2165
2166         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2167         window's contents.
2168         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2169         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2170
2171 2019-07-17  Tom Tromey  <tom@tromey.com>
2172
2173         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2174         (struct tui_data_item_window): Update.
2175
2176 2019-07-17  Tom Tromey  <tom@tromey.com>
2177
2178         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2179         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2180         defines.
2181
2182 2019-07-17  Tom Tromey  <tom@tromey.com>
2183
2184         * tui/tui-winsource.h (tui_erase_source_content)
2185         (tui_clear_source_content): Remove "display_prompt" parameter.
2186         * tui/tui-winsource.c (tui_update_source_window_as_is)
2187         (tui_update_source_windows_with_addr): Update.
2188         (tui_clear_source_content): Remove "display_prompt" parameter.
2189         (tui_erase_source_content): Likewise.  Simplify.
2190         (tui_show_source_content): Update.
2191         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2192         * tui/tui-stack.c (tui_show_frame_info): Update.
2193         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2194         Remove defines.
2195
2196 2019-07-17  Tom Tromey  <tom@tromey.com>
2197
2198         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2199         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2200         parameter.
2201         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2202         parameter.
2203
2204 2019-07-17  Tom Tromey  <tom@tromey.com>
2205
2206         * tui/tui-winsource.c (tui_clear_source_content)
2207         (tui_show_source_content, tui_show_exec_info_content)
2208         (tui_clear_exec_info_content): Update.
2209         * tui/tui-stack.c (tui_show_locator_content): Update.
2210         (tui_show_frame_info): Update.
2211         * tui/tui-source.h (tui_source_window): Don't declare.
2212         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2213         from tui_source_is_displayed.
2214         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2215         Remove field.
2216         (struct tui_source_window_base) <content_in_use>: New field.  Now
2217         bool.
2218         (struct tui_source_window) <showing_source_p>: New method.
2219         (TUI_SRC_WIN): Change cast.
2220         * tui/tui-data.c (tui_initialize_static_data): Update.
2221
2222 2019-07-17  Tom Tromey  <tom@tromey.com>
2223
2224         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2225         location_matches_p.
2226         * tui/tui-source.c (tui_source_window::location_matches_p): New
2227         method.
2228         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2229         method.
2230         * tui/tui-data.h (struct tui_source_window_base)
2231         <location_matches_p>: New method.
2232         (struct tui_source_window, struct tui_disasm_window)
2233         <location_matches_p>: Likewise.
2234
2235 2019-07-17  Tom Tromey  <tom@tromey.com>
2236
2237         * tui/tui-win.c (tui_set_win_height_command): Rename from
2238         tui_set_win_height.
2239         (tui_set_win_height_command): Remove.
2240
2241 2019-07-17  Tom Tromey  <tom@tromey.com>
2242
2243         * tui/tui-source.c (tui_source_window): New constructor.  Add
2244         observer.
2245         (~tui_source_window): New destructor.
2246         (tui_source_window::style_changed): New method.
2247         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2248         (tui_attach_detach_observers): Update.
2249         * tui/tui-data.h (struct tui_source_window): Make constructor not
2250         inline.  Add destructor.
2251         (struct tui_source_window) <style_changed>: New method.
2252         <m_observable>: New member.
2253
2254 2019-07-17  Tom Tromey  <tom@tromey.com>
2255
2256         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2257         * tui/tui-win.c (tui_resize_all): Fix typo.
2258
2259 2019-07-17  Tom Tromey  <tom@tromey.com>
2260
2261         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2262         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2263         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2264         * tui/tui-win.c (window_name_completer): Use foreach.
2265         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2266         (update_tab_width): Likewise.
2267         * tui/tui-layout.c (show_layout): Update.
2268         * tui/tui-data.h (class tui_window_iterator): New.
2269         (struct all_tui_windows): New.
2270         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2271
2272 2019-07-17  Tom Tromey  <tom@tromey.com>
2273
2274         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2275         parameter.  Don't reference globals.
2276         (tui_reg_command): Update.
2277
2278 2019-07-17  Tom Tromey  <tom@tromey.com>
2279
2280         * tui/tui-regs.c (tui_show_registers): Simplify.
2281
2282 2019-07-17  Tom Tromey  <tom@tromey.com>
2283
2284         * tui/tui-regs.c (tui_show_registers): Update.
2285         (tui_show_register_group): Add win_info parameter.
2286
2287 2019-07-17  Tom Tromey  <tom@tromey.com>
2288
2289         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2290         Rename from tui_display_reg_element_at_line.
2291         (tui_data_window::display_registers_from_line): Update.
2292         * tui/tui-data.h (struct tui_data_window)
2293         <display_reg_element_at_line>: New method.
2294
2295 2019-07-17  Tom Tromey  <tom@tromey.com>
2296
2297         * tui/tui-regs.h (tui_display_registers_from)
2298         (tui_display_registers_from_line): Don't declare.
2299         * tui/tui-windata.c (tui_data_window::display_all_data)
2300         (tui_data_window::refresh_all)
2301         (tui_data_window::do_scroll_vertical): Update.
2302         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2303         from tui_display_registers_from.
2304         (tui_display_reg_element_at_line): Update.
2305         (tui_data_window::display_registers_from_line): Rename from
2306         tui_display_registers_from_line.
2307         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2308         display_registers_from_line>: New methods.
2309
2310 2019-07-17  Tom Tromey  <tom@tromey.com>
2311
2312         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2313         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2314         from tui_erase_data_content.
2315         (tui_data_window::display_all_data)
2316         (tui_data_window::refresh_all)
2317         (tui_data_window::do_scroll_vertical): Update.
2318         * tui/tui-regs.c (tui_show_registers): Update.
2319         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2320         New method.
2321
2322 2019-07-17  Tom Tromey  <tom@tromey.com>
2323
2324         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2325         declare.
2326         * tui/tui-windata.c
2327         (tui_data_window::delete_data_content_windows): Rename from
2328         tui_delete_data_content_windows.
2329         (tui_data_window::display_all_data)
2330         (tui_data_window::do_scroll_vertical): Update.
2331         * tui/tui-data.h (struct tui_data_window)
2332         <delete_data_content_windows>: New method.
2333
2334 2019-07-17  Tom Tromey  <tom@tromey.com>
2335
2336         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2337         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2338
2339 2019-07-17  Tom Tromey  <tom@tromey.com>
2340
2341         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2342         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2343         from tui_display_all_data.
2344         * tui/tui-win.c
2345         (tui_data_window::do_make_visible_with_new_height): Update.
2346         * tui/tui-regs.c (tui_show_registers): Update.
2347         * tui/tui-layout.c (tui_set_layout): Update.
2348         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2349         method.
2350
2351 2019-07-17  Tom Tromey  <tom@tromey.com>
2352
2353         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2354         * tui/tui-windata.c (tui_display_data_from): Remove.
2355         (tui_data_window::refresh_all): Update.
2356
2357 2019-07-17  Tom Tromey  <tom@tromey.com>
2358
2359         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2360         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2361         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2362         tui_display_registers_from_line.
2363         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2364         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2365         "force_display" parameter.
2366
2367 2019-07-17  Tom Tromey  <tom@tromey.com>
2368
2369         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2370         declare.
2371         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2372         Rename from tui_first_reg_element_no_inline.
2373         (tui_display_reg_element_at_line)
2374         (tui_display_registers_from_line): Update.
2375         * tui/tui-data.h (struct tui_data_window)
2376         <first_reg_element_no_inline>: New method.
2377
2378 2019-07-17  Tom Tromey  <tom@tromey.com>
2379
2380         * tui/tui-windata.c (tui_display_data_from)
2381         (tui_data_window::do_scroll_vertical): Update.
2382         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2383         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2384         Rename from tui_line_from_reg_element_no.
2385         (tui_display_registers_from_line): Update.
2386         * tui/tui-data.h (struct tui_data_window)
2387         <line_from_reg_element_no>: New method.
2388
2389 2019-07-17  Tom Tromey  <tom@tromey.com>
2390
2391         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2392         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2393         tui_last_regs_line_no.
2394         (tui_display_reg_element_at_line)
2395         (tui_display_registers_from_line): Update.
2396         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2397         method.
2398
2399 2019-07-17  Tom Tromey  <tom@tromey.com>
2400
2401         PR tui/24722:
2402         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2403         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2404         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2405         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2406         (tui_update_breakpoint_info): Likewise.
2407         * tui/tui-hooks.c (tui_event_create_breakpoint)
2408         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2409         Update.
2410
2411 2019-07-17  Tom Tromey  <tom@tromey.com>
2412
2413         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2414
2415 2019-07-17  Tom Tromey  <tom@tromey.com>
2416
2417         * tui/tui-winsource.c (tui_update_source_window_as_is)
2418         (tui_update_source_windows_with_addr): Update.
2419         * tui/tui-source.h (tui_set_source_content)
2420         (tui_show_symtab_source): Add "win_info" parameter.
2421         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2422         parameter.
2423         (tui_show_symtab_source): Likewise.
2424
2425 2019-07-17  Tom Tromey  <tom@tromey.com>
2426
2427         * tui/tui-wingeneral.c
2428         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2429
2430 2019-07-17  Tom Tromey  <tom@tromey.com>
2431
2432         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2433         (struct tui_cmd_window) <can_scroll>: New method.
2434         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2435         method.
2436
2437 2019-07-17  Tom Tromey  <tromey@adacore.com>
2438
2439         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2440         do_field_signed>: Rename.  Change type of "value".
2441         * ui-out.c (ui_out::field_signed): Rename from field_int.
2442         Change type of "value".
2443         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2444         type of "value".
2445         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2446         do_field_int.  Change type of "value".
2447         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2448         do_field_int.  Change type of "value".
2449         * tracepoint.c (trace_status_mi, tfind_1)
2450         (print_one_static_tracepoint_marker): Update.
2451         * thread.c (print_thread_info_1, print_selected_thread_frame):
2452         Update.
2453         * stack.c (print_frame, print_frame_info): Update.
2454         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2455         Update.
2456         * source.c (print_source_lines_base): Update.
2457         * skip.c (info_skip_command): Update.
2458         * record-btrace.c (btrace_ui_out_decode_error)
2459         (btrace_call_history_src_line): Update.
2460         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2461         Update.
2462         * progspace.c (print_program_space): Update.
2463         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2464         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2465         do_field_int.  Change type of "value".
2466         * mi/mi-out.c (mi_ui_out::do_table_begin)
2467         (mi_ui_out::do_table_header): Update.
2468         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2469         type of "value".
2470         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2471         (mi_cmd_data_list_changed_registers, output_register)
2472         (mi_cmd_data_read_memory, mi_load_progress)
2473         (mi_cmd_trace_frame_collected): Update.
2474         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2475         Update.
2476         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2477         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2478         (mi_cmd_var_list_children, varobj_update_one): Update.
2479         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2480         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2481         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2482         * inferior.c (print_inferior): Update.
2483         * gdb_bfd.c (print_one_bfd): Update.
2484         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2485         Update.
2486         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2487         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2488         do_field_int.  Change type of "value".
2489         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2490         do_field_int.  Change type of "value".
2491         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2492         (print_one_breakpoint_location, print_it_catch_fork)
2493         (print_one_catch_fork, print_it_catch_vfork)
2494         (print_one_catch_vfork, print_it_catch_solib)
2495         (print_it_catch_exec, print_it_ranged_breakpoint)
2496         (print_mention_watchpoint, print_mention_masked_watchpoint)
2497         (bkpt_print_it, update_static_tracepoint): Update.
2498         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2499         * break-catch-syscall.c (print_it_catch_syscall): Update.
2500         * ada-tasks.c (print_ada_task_info): Update.
2501         * ada-lang.c (print_it_exception, print_mention_exception):
2502         Update.
2503
2504 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2505
2506         PR breakpoints/24541
2507         * gdbarch.c: Regenerate.
2508         * gdbarch.h: Regenerate.
2509         * gdbarch.sh: Adjust return type and parameter types for
2510         'stap_adjust_register'.
2511         (i386_stap_adjust_register): Adjust signature and return new
2512         register name.
2513         * stap-probe.c (stap_parse_register_operand): Adjust use of
2514         'gdbarch_stap_adjust_register'.
2515
2516 2019-07-17  Tom Tromey  <tromey@adacore.com>
2517
2518         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2519         declare VEC.
2520         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2521         std::vector.
2522         (struct s390_process_info): Add initializers.
2523         (s390_add_process): Use new.
2524         (s390_linux_nat_target::low_forget_process): Use delete.
2525         (s390_linux_nat_target::low_new_fork)
2526         (s390_linux_nat_target::stopped_by_watchpoint)
2527         (s390_linux_nat_target::low_prepare_to_resume)
2528         (s390_linux_nat_target::insert_watchpoint)
2529         (s390_linux_nat_target::insert_hw_breakpoint)
2530         (s390_linux_nat_target::remove_watchpoint)
2531         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2532
2533 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2534
2535         * aarch64-fbsd-nat.c: Include regcache.h.
2536         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2537         argument.
2538         (aarch64_fbsd_nat_target::fetch_registers)
2539         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2540         variable.
2541         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2542
2543 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2544
2545         * fbsd-nat.c: Include gdbarch.h.
2546
2547 2019-07-15  Tom Tromey  <tromey@adacore.com>
2548
2549         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2550
2551 2019-07-15  Tom Tromey  <tromey@adacore.com>
2552
2553         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2554         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2555         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2556         * cli-out.c (cli_ui_out::do_field_int): New method.
2557         * ui-out.c (ui_out::field_unsigned): New method.
2558         * symfile.c (generic_load): Use field_unsigned.
2559         (print_transfer_performance): Likewise.
2560         * record-btrace.c (ui_out_field_uint): Remove.
2561         (btrace_call_history_insn_range, btrace_call_history): Use
2562         field_unsigned.
2563         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2564         field_unsigned.
2565         * ui-out.h (class ui_out) <field_unsigned>: New method.
2566         <do_field_unsigned>: Likewise.
2567
2568 2019-07-15  Tom Tromey  <tromey@adacore.com>
2569
2570         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2571         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2572         * target.c (flash_erase_command): Use field_string.
2573         * infrun.c (print_signal_received_reason): Use field_string.
2574         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2575         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2576         field_string.
2577         * ada-tasks.c (print_ada_task_info): Use field_string.
2578
2579 2019-07-15  Tom Tromey  <tromey@adacore.com>
2580
2581         * target.c (flash_erase_command): Use field_core_addr.
2582         * symfile.c (generic_load): Use field_core_addr.
2583         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2584         Use field_core_addr.
2585         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2586         field_core_addr.
2587
2588 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2589
2590         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2591         value if its desired type is smaller than a CORE_ADDR and signed.
2592
2593 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2594
2595         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2596         of changes to field names, and use new is_reference field to
2597         decide if a property is a reference or not.
2598         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2599         field.
2600         (struct dwarf2_property_baton): Update header comment, rename
2601         'referenced_type' to 'property_type' and update comments.
2602         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2603         default property type, store in property baton, update to take
2604         accound of renamed field.
2605         (read_func_scope): Update call to attr_to_dynamic_prop.
2606         (read_array_type): Likewise.
2607         (dwarf2_per_cu_addr_sized_int_type): New function.
2608         (read_subrange_index_type): Move type finding code to
2609         dwarf2_per_cu_addr_sized_int_type.
2610         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2611         (dwarf2_per_cu_addr_type): New function.
2612         (set_die_type): Update calls to attr_to_dynamic_prop.
2613
2614 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2615
2616         * dwarf2read.c (read_subrange_index_type): New function.
2617         (read_subrange_type): Move code into new function and call it.
2618         * gdbtypes.c (create_range_type): Add some asserts.
2619
2620 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2621
2622         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2623         update return statements.
2624         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2625         declaration, and update comment to match.
2626         * gdbtypes.c (resolve_dynamic_array): Update call to
2627         dwarf2_evaluate_property to match new return type.
2628
2629 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2630
2631         * valarith.c (value_subscripted_rvalue): Change lowerbound
2632         parameter type from int to LONGEST.
2633         * value.h (value_subscripted_rvalue): Likewise in declaration.
2634
2635 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2636
2637         * cli/cli-utils.c (info_print_command_completer): New function.
2638         * cli/cli-utils.h: Add 'completer.h' include, and forward
2639         declaration for 'struct cmd_list_element'.
2640         (info_print_command_completer): Declare.
2641         * stack.c (_initialize_stack): Add completer for 'info locals' and
2642         'info args'.
2643         * symtab.c (_initialize_symtab): Add completer for 'info
2644         variables' and 'info functions'.
2645         * NEWS: Mention completion for additional info commands.
2646
2647 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2648
2649         * cli/cli-utils.c (extract_info_print_args): Delete.
2650         (extract_arg_maybe_quoted): Delete.
2651         (info_print_options_defs): New variable.
2652         (make_info_print_options_def_group): New function.
2653         (extract_info_print_options): Define new function.
2654         * cli/cli-utils.h (extract_info_print_args): Delete.
2655         (struct info_print_options): New structure.
2656         (extract_info_print_options): Declare new function.
2657         * stack.c (info_locals_command): Update to use new
2658         extract_info_print_options, also add a header comment.
2659         (info_args_command): Likewise.
2660         * symtab.c (info_variables_command): Likewise.
2661         (info_functions_command): Likewise.
2662
2663 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2664
2665         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2666         to extract string arguments.
2667         * common/common-utils.c (extract_string_maybe_quoted): New function.
2668         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2669
2670 2019-07-11  Tom Tromey  <tromey@adacore.com>
2671
2672         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2673         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2674         * top.h (gdbinit): Don't declare.
2675         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2676         into...
2677         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2678         * top.c (gdb_init): Don't call init_cli_cmds.
2679         (gdbinit): Remove.
2680         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2681
2682 2019-07-11  Tom Tromey  <tromey@adacore.com>
2683
2684         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2685         after it has been moved.
2686
2687 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2688
2689         * valops.c (value_must_coerce_to_target): Change return type to
2690         bool.
2691         * value.h (value_must_coerce_to_target): Likewise.
2692
2693 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2694
2695         * breakpoint.c (is_hardware_watchpoint): Remove
2696         forward-declaration.
2697         (is_masked_watchpoint): Change return type to bool.
2698         (is_tracepoint): Likewise.
2699         (is_breakpoint): Likewise.
2700         (is_hardware_watchpoint): Likewise.
2701         (is_watchpoint): Likewise.
2702         (is_no_memory_software_watchpoint): Likewise.
2703         (is_catchpoint): Likewise.
2704         (breakpoint_1): Make FILTER parameter's return type bool.
2705         is_masked_watchpoint): Change return type to bool.
2706         (save_breakpoints): Make FILTER parameter's return type bool.
2707         * breakpoint.h (is_breakpoint): Change return type to bool.
2708         (is_watchpoint): Likewise.
2709         (is_catchpoint): Likewise.
2710         (is_tracepoint): Likewise.
2711
2712 2019-07-10  Tom Tromey  <tom@tromey.com>
2713
2714         * defs.h: Don't include gdbarch.h.
2715         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2716         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2717         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2718         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2719         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2720         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2721         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2722         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2723         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2724         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2725         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2726         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2727         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2728         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2729         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2730         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2731         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2732         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2733         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2734         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2735         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2736         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2737         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2738         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2739         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2740         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2741         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2742
2743 2019-07-10  Tom Tromey  <tromey@adacore.com>
2744
2745         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2746         * breakpoint.c (init_ada_exception_breakpoint): Register as
2747         bp_catchpoint.
2748         (print_one_breakpoint_location, print_one_breakpoint): Use
2749         is_ada_exception_catchpoint.
2750         * ada-lang.c (class ada_catchpoint_location): Pass
2751         bp_loc_software_breakpoint to bp_location constructor.
2752         (is_ada_exception_catchpoint): New function.
2753
2754 2019-07-10  Tom Tromey  <tromey@adacore.com>
2755
2756         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2757         VEC.
2758         (struct arm_exidx_entry): New method operator<.
2759         (struct arm_exidx_data) <section_maps>: Change type.
2760         (arm_exidx_data_free): Remove.
2761         (arm_exidx_data_key): Change type.  Move lower.
2762         (arm_exidx_new_objfile): Update.
2763         (arm_compare_exidx_entries): Remove.
2764         (arm_find_exidx_entry, _initialize_arm_tdep)
2765
2766 2019-07-10  Tom Tromey  <tromey@adacore.com>
2767
2768         * solib-spu.c (ocl_program_data_key): Change type.
2769         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2770         Update.
2771
2772 2019-07-10  Tom Tromey  <tromey@adacore.com>
2773
2774         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2775         (struct solib_aix_inferior_data) <library_list>: Change type.
2776         (solib_aix_inferior_data_handle): Change type.
2777         (get_solib_aix_inferior_data): Update.
2778         (solib_aix_free_library_list): Remove.
2779         (library_list_start_library): Update.
2780         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2781         return type.
2782         (solib_aix_get_library_list)
2783         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2784         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2785
2786 2019-07-10  Tom Tromey  <tromey@adacore.com>
2787
2788         * solib-dsbt.c (struct dsbt_info): Add initializers.
2789         (solib_dsbt_pspace_data): Change type.
2790         (dsbt_pspace_data_cleanup): Remove.
2791         (get_dsbt_info, _initialize_dsbt_solib): Update.
2792
2793 2019-07-10  Tom Tromey  <tromey@adacore.com>
2794
2795         * spu-tdep.c (spu_overlay_data): Change type.
2796         (spu_get_overlay_table, spu_overlay_new_objfile)
2797         (_initialize_spu_tdep): Update.
2798
2799 2019-07-10  Tom Tromey  <tromey@adacore.com>
2800
2801         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2802         destructor.
2803         (dbx_objfile_data_key): Change type and declare later.
2804         (DBX_SYMFILE_INFO): Rewrite.
2805         * dbxread.c (dbx_objfile_data_key): Change type.
2806         (dbx_symfile_init): Update.
2807         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2808         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2809         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2810
2811 2019-07-10  Tom Tromey  <tromey@adacore.com>
2812
2813         * jit.c (jit_program_space_key): Change type.  Move lower.
2814         (get_jit_program_space_data): Update.
2815         (jit_program_space_data_cleanup): Remove.
2816         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2817         Update.
2818         (struct jit_program_space_data): Add initializers.
2819
2820 2019-07-10  Tom Tromey  <tromey@adacore.com>
2821
2822         * solib-darwin.c (struct darwin_info): Add initializers.
2823         (solib_darwin_pspace_data): Change type.
2824         (darwin_pspace_data_cleanup): Remove.
2825         (get_darwin_info, _initialize_darwin_solib): Update.
2826
2827 2019-07-10  Tom Tromey  <tromey@adacore.com>
2828
2829         * remote-sim.c (struct sim_inferior_data): Add initializers,
2830         constructor, and destructor.
2831         (sim_inferior_data_key): Change type.  Move lower.
2832         (check_for_duplicate_sim_descriptor): Update.
2833         (get_sim_inferior_data): Use new.  Update.
2834         (~sim_inferior_data_cleanup): Rename from
2835         sim_inferior_data_cleanup.  Simplify.
2836         (gdbsim_close_inferior, simulator_command)
2837         (sim_command_completer, _initialize_remote_sim): Update.
2838         (next_pid, INITIAL_PID): Move earlier.
2839
2840 2019-07-10  Tom Tromey  <tromey@adacore.com>
2841
2842         * python/python-internal.h (create_thread_object): Return
2843         gdbpy_ref.
2844         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2845         * python/py-inferior.c (struct threadlist_entry): Add
2846         constructor.
2847         <thread_obj>: Now a gdbpy_ref.
2848         (thread_to_thread_object): Update.
2849         (add_thread_object): Use new.
2850         (delete_thread_object): Use delete.
2851         (infpy_threads): Update.
2852         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2853         GIL.
2854
2855 2019-07-10  Tom Tromey  <tromey@adacore.com>
2856
2857         * valops.c (value_cast): Specialize error message for Ada.
2858
2859 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2860
2861         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2862
2863 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2864
2865         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2866         bpstat_should_step): Return bool, adjust comments.
2867         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2868         bpstat_should_step): Likewise.
2869
2870 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2871
2872         * features/Makefile: Use feature target descriptions for Arm.
2873         * features/arm/arm-core.c: Generate new file.
2874         * features/arm/arm-fpa.c: Likewise.
2875         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2876         * features/arm/arm-m-profile.c: Likewise.
2877         * features/arm/arm-vfpv2.c: Likewise.
2878         * features/arm/arm-vfpv3.c: Likewise.
2879         * features/arm/xscale-iwmmxt.c: Likewise.
2880         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2881
2882 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2883
2884         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2885         ptrace earlier.
2886
2887 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2888
2889         * features/aarch64-pauth.c: Regenerate.
2890
2891 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2892
2893         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2894         bool.
2895         (bpstat_what): Use false instead of 0.
2896
2897 2019-07-09  Pedro Alves  <palves@redhat.com>
2898
2899         * break-catch-throw.c (is_exception_catchpoint): New.
2900         * breakpoint.c (print_one_breakpoint_location): New parameter
2901         'raw_loc'.  Handle it.  Use
2902         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2903         looking at the breakpoint's type.
2904         (print_one_breakpoint): If handling "maint info breakpoints", also
2905         print locations of exception catchpoints.
2906         * breakpoint.h (is_exception_catchpoint): Declare.
2907
2908 2019-07-09  Pedro Alves  <palves@redhat.com>
2909
2910         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2911         "addr" field.
2912         (allocate_location_exception_catchpoint): New.
2913         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2914         (initialize_throw_catchpoint_ops): Install
2915         allocate_location_exception_catchpoint as allocate_location
2916         method.
2917         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2918         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2919         bp_loc_other.
2920         (breakpoint_address_is_meaningful): Delete.
2921         (bl_address_is_meaningful): New.
2922         (breakpoint_locations_match): Adjust comment.
2923         (bp_location_from_bp_type): New, factored out of...
2924         (bp_location::bp_location(breakpoint *)): ... this.
2925         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2926         factored out of...
2927         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2928         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2929         breakpoint_address_is_meaningful.
2930         (bp_locations_compare): Adjust comment.
2931         (update_global_location_list): Use bl_address_is_meaningful
2932         instead of breakpoint_address_is_meaningful.
2933         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2934         explicit.
2935         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2936         * python/py-breakpoint.c (bppy_get_location): No longer check
2937         whether location is null.
2938
2939 2019-07-09  Pedro Alves  <palves@redhat.com>
2940
2941         PR c++/15468
2942         * breakpoint.c (print_one_breakpoint_location): Remove
2943         single-location assert.
2944
2945 2019-07-09  Tom Tromey  <tom@tromey.com>
2946
2947         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2948         * configure: Rebuild.
2949         * configure.ac: Change common to gdbsupport.
2950         * gdbsupport: Rename from common.
2951         * acinclude.m4: Change common to gdbsupport.
2952         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2953         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2954         gdbsupport.
2955         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2956         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2957         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2958         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2959         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2960         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2961         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2962         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2963         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2964         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2965         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2966         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2967         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2968         coff-pe-read.c, command.h, compile/compile-c-support.c,
2969         compile/compile-c.h, compile/compile-cplus-symbols.c,
2970         compile/compile-cplus-types.c, compile/compile-cplus.h,
2971         compile/compile-loc2c.c, compile/compile.c, completer.c,
2972         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2973         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2974         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2975         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2976         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2977         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2978         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2979         features/aarch64-core.c, features/aarch64-fpu.c,
2980         features/aarch64-pauth.c, features/aarch64-sve.c,
2981         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2982         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2983         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2984         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2985         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2986         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2987         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2988         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2989         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2990         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2991         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2992         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2993         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2994         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2995         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2996         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2997         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2998         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2999         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3000         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3001         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3002         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3003         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3004         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3005         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3006         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3007         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3008         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3009         minsyms.c, mips-linux-tdep.c, namespace.h,
3010         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3011         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3012         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3013         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3014         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3015         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3016         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3017         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3018         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3019         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3020         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3021         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3022         procfs.c, producer.c, progspace.h, psymtab.h,
3023         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3024         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3025         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3026         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3027         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3028         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3029         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3030         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3031         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3032         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3033         target-memory.c, target.c, target.h, target/waitstatus.c,
3034         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3035         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3036         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3037         unittests/array-view-selftests.c,
3038         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3039         unittests/common-utils-selftests.c,
3040         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3041         unittests/format_pieces-selftests.c,
3042         unittests/function-view-selftests.c,
3043         unittests/lookup_name_info-selftests.c,
3044         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3045         unittests/mkdir-recursive-selftests.c,
3046         unittests/observable-selftests.c,
3047         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3048         unittests/parse-connection-spec-selftests.c,
3049         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3050         unittests/scoped_fd-selftests.c,
3051         unittests/scoped_mmap-selftests.c,
3052         unittests/scoped_restore-selftests.c,
3053         unittests/string_view-selftests.c, unittests/style-selftests.c,
3054         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3055         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3056         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3057         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3058         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3059         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3060
3061 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3062
3063         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3064         bool value.
3065         (decode_digits_ordinary): Set explicit_line field in sal.
3066         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3067         symtab_and_line that was set on an explicit line number in
3068         assembler code.  Do always update the recorded symtab and line if
3069         we do skip the prologue.
3070
3071 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3072
3073         * breakpoint.c (set_breakpoint_location_function): Remove
3074         explicit_loc parameter.
3075         (momentary_breakpoint_from_master): Update call to
3076         set_breakpoint_location_function.
3077         (add_location_to_breakpoint): Likewise.
3078
3079 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3080
3081         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3082         required features based on default bfd type when no specific bfd
3083         is present.
3084
3085 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3086
3087         * NEWS: Mention that GDB printf and eval commands can now print
3088         C-style and Ada-style convenience var strings without
3089         calling the inferior.
3090         * printcmd.c (printf_c_string): Locally print GDB internal var
3091         instead of transiting via the inferior.
3092         (printf_wide_c_string): Likewise.
3093
3094 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3095
3096         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3097
3098 2019-07-04  Tom Tromey  <tom@tromey.com>
3099
3100         PR tui/24724:
3101         * tui/tui-winsource.c (tui_clear_source_content): Update.
3102         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3103         (tui_update_breakpoint_info): Update.
3104         (tui_set_exec_info_content): Update.
3105         * tui/tui-source.c (tui_set_source_content_nil): Update.
3106         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3107         has_break.
3108         * tui/tui-data.h (enum tui_bp_flag): New.
3109         (tui_bp_flags): New enum flags type.
3110         (struct tui_source_element) <break_mode>: Change type.  Rename
3111         from has_break.
3112         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3113         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3114         constants.
3115         * tui/tui-winsource.h: Fix comment.
3116
3117 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3118
3119         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3120         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3121         (store_fpregs_to_thread)
3122         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3123         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3124         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3125         (IWMMXT_REGS_SIZE): Add define.
3126         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3127         (fetch_vfp_regs, store_vfp_regs)
3128         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3129         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3130
3131 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3132
3133         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3134         defines.
3135         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3136         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3137         (ARM_INT_REGISTER_SIZE): ...to this.
3138         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3139         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3140         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3141         (arm_linux_collect_gregset, supply_nwfpe_register)
3142         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3143         defines.
3144         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3145         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3146         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3147         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3148         (arm_return_in_memory, arm_store_return_value)
3149         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3150         (arm_record_ld_st_multiple): Likewise.
3151         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3152         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3153
3154 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3155
3156         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3157         AARCH64_DISPLACED_MODIFIED_INSNS.
3158         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3159         (aarch64_displaced_step_copy_insn): Likewise.
3160         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3161         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3162         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3163         ARM_DISPLACED_MODIFIED_INSNS.
3164         * arm-tdep.c (arm_gdbarch_init): Likewise.
3165         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3166         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3167         (struct arm_displaced_step_closure): Use
3168         ARM_DISPLACED_MODIFIED_INSNS.
3169
3170 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3171
3172         * features/Makefile: Remove unused xml files.
3173         * features/aarch64.xml: Remove.
3174         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3175         * features/i386/amd64-avx-avx512.xml: Remove.
3176         * features/i386/amd64-avx-linux.xml: Remove.
3177         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3178         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3179         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3180         * features/i386/amd64-avx-mpx.xml: Remove.
3181         * features/i386/amd64-avx.xml: Remove.
3182         * features/i386/amd64-linux.xml: Remove.
3183         * features/i386/amd64-mpx-linux.xml: Remove.
3184         * features/i386/amd64-mpx.xml: Remove.
3185         * features/i386/amd64.xml: Remove.
3186         * features/i386/i386-avx-avx512-linux.xml: Remove.
3187         * features/i386/i386-avx-avx512.xml: Remove.
3188         * features/i386/i386-avx-linux.xml: Remove.
3189         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3190         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3191         * features/i386/i386-avx-mpx-linux.xml: Remove.
3192         * features/i386/i386-avx-mpx.xml: Remove.
3193         * features/i386/i386-avx.xml: Remove.
3194         * features/i386/i386-linux.xml: Remove.
3195         * features/i386/i386-mmx-linux.xml: Remove.
3196         * features/i386/i386-mmx.xml: Remove.
3197         * features/i386/i386-mpx-linux.xml: Remove.
3198         * features/i386/i386-mpx.xml: Remove.
3199         * features/i386/i386.xml: Remove.
3200         * features/i386/x32-avx-avx512-linux.xml: Remove.
3201         * features/i386/x32-avx-linux.xml: Remove.
3202         * features/i386/x32-linux.xml: Remove.
3203
3204 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3205
3206         * regformats/aarch64.dat: Remove.
3207         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3208         * regformats/i386/amd64-avx-linux.dat: Remove.
3209         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3210         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3211         * regformats/i386/amd64-linux.dat: Remove.
3212         * regformats/i386/amd64-mpx-linux.dat: Remove.
3213         * regformats/i386/amd64.dat: Remove.
3214         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3215         * regformats/i386/i386-avx-linux.dat: Remove.
3216         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3217         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3218         * regformats/i386/i386-linux.dat: Remove.
3219         * regformats/i386/i386-mmx-linux.dat: Remove.
3220         * regformats/i386/i386-mpx-linux.dat: Remove.
3221         * regformats/i386/i386.dat: Remove.
3222         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3223         * regformats/i386/x32-avx-linux.dat: Remove.
3224         * regformats/i386/x32-linux.dat: Remove.
3225
3226 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3227
3228         * aarch64-tdep.c: Remove xml self tests.
3229         * amd64-linux-tdep.c: Likewise.
3230         * amd64-tdep.c: Likewise.
3231         * i386-linux-tdep.c: Likewise.
3232         * i386-tdep.c: Likewise.
3233
3234 2019-07-03  Pedro Alves  <palves@redhat.com>
3235
3236         PR cli/24732
3237         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3238         (pipe_cmd_option_defs): New.
3239         (make_pipe_cmd_options_def_group): New.
3240         (pipe_command): Use gdb::option::process_options.
3241         (pipe_command_completer): New function.
3242         (_initialize_cli_cmds): Install completer for "pipe" command.
3243
3244 2019-07-03  Pedro Alves  <palves@redhat.com>
3245
3246         * cli/cli-option.c (union option_value) <string>: New field.
3247         (struct option_def_and_value): Add ctor, move ctor, dtor and
3248         use DISABLE_COPY_AND_ASSIGN.
3249         (option_def_and_value::clear_value): New.
3250         (parse_option, save_option_value_in_ctx, get_val_type_str)
3251         (add_setshow_cmds_for_options): Handle var_string.
3252         * cli-option.h (union option_def::var_address) <string>: New
3253         field.
3254         (struct string_option_def): New.
3255         * maint-test-options.c (struct test_options_opts): Add default
3256         ctor and use DISABLE_COPY_AND_ASSIGN.
3257         <string_opt>: New field.
3258         (test_options_opts::~test_options_opts): New.
3259         (test_options_opts::dump): Also dump "-string".
3260         (test_options_option_defs): Install "string.
3261
3262 2019-07-03  Pedro Alves  <palves@redhat.com>
3263
3264         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3265         option_value with a null enumeration.
3266         (complete_options): Save the option values in the context.
3267         (save_option_value_in_ctx): New, factored out from ...
3268         (process_options): ... here.
3269         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3270         of the function.
3271         * maint-test-options.c (test_options_opts::dump): New, factored
3272         out from ...
3273         (maintenance_test_options_command_mode): ... here.
3274         (maintenance_test_options_command_completion_result): Delete.
3275         (maintenance_test_options_command_completion_text): Update
3276         comment.
3277         (maintenance_show_test_options_completion_result): Change
3278         prototype.  Just print
3279         maintenance_test_options_command_completion_text.
3280         (save_completion_result): New.
3281         (maintenance_test_options_completer_mode): Pass options context to
3282         complete_options, and then save a dump.
3283         (_initialize_maint_test_options): Use add_cmd to install "maint
3284         show test-options-completion-result".
3285
3286 2019-07-03  Pedro Alves  <palves@redhat.com>
3287
3288         * NEWS (New commands): Mention "with" and "maint with".
3289         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3290         (with_command, with_command_completer): New.
3291         (pipe_command): Adjust to new repeat_previous
3292         interface.
3293         (_initialize_cli_cmds): Install the "with" command and its "w"
3294         alias.
3295         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3296         declarations.
3297         * cli/cli-setshow.c (parse_cli_var_uinteger)
3298         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3299         argument strings for all var_types.
3300         (get_setshow_command_value_string): New, factored out from ...
3301         (do_show_command): ... this.
3302         * cli/cli-setshow.h: Include <string>.
3303         (get_setshow_command_value_string): Declare.
3304         * command.h (repeat_previous): Now returns const char *.  Adjust
3305         comment.
3306         * maint.c: Include "cli/cli-cmds.h".
3307         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3308         (_initialize_maint_cmds): Register the "maintenance with" command.
3309         * top.c (repeat_previous): Move bits from pipe_command here:
3310         Return the saved command line, if any; error out if there's no
3311         command to relaunch.
3312
3313 2019-07-03  Pedro Alves  <palves@redhat.com>
3314
3315         * NEWS (New commands): Mention "maint set/show test-settings"
3316         instead of "maint test-settings".
3317         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3318         (maintenance_test_settings_set_list): Rename to ...
3319         (maintenance_set_test_settings_list): ... this.
3320         (maintenance_test_settings_show_list): Rename to  ...
3321         (maintenance_show_test_settings_list): ... this.
3322         (maintenance_test_settings_cmd): Delete.
3323         (maintenance_test_settings_set_cmd): ...
3324         (maintenance_set_test_settings_cmd): ... this.
3325         (maintenance_test_settings_show_cmd): ...
3326         (maintenance_show_test_settings_cmd): ... this.
3327         (maintenance_test_settings_show_value_cmd):
3328         (maintenance_show_test_settings_value_cmd): ... this.
3329         (_initialize_maint_test_settings): No longer install the "maint
3330         test-settings" prefix command.  Rename "maint test-settings set"
3331         to "maint set test-settings", and "maint test-settings show" to
3332         "maint show test-settings".  Adjust all subcommands.
3333
3334 2019-07-03  Pedro Alves  <palves@redhat.com>
3335
3336         * maint-test-settings.c: Fix file's intro comment.  Replace all
3337         references to "test-options" with references to "test-settings",
3338         in comments.
3339
3340 2019-07-03  Pedro Alves  <palves@redhat.com>
3341
3342         * maint-test-settings.c (maintenance_test_settings_xxx)
3343         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3344         New.
3345         (maintenance_test_settings_enums): Use them.
3346         (maintenance_test_settings_enum): Default to
3347         maintenance_test_settings_xxx.
3348         (_initialize_maint_test_settings): Initialize
3349         MAINTENANCE_TEST_SETTINGS_FILENAME.
3350
3351 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3352
3353         * breakpoint.h (remove_breakpoints_inf): Change return type to
3354         void, move function documentation here.
3355         * breakpoint.c (remove_breakpoints_inf): Change return type to
3356         void, move function documentation to header.
3357
3358 2019-07-02  Pedro Alves  <palves@redhat.com>
3359
3360         * NEWS (Completion improvements): Mention "info threads".
3361         * thread.c (struct info_threads_opts, info_threads_option_defs)
3362         (make_info_threads_options_def_group): New.
3363         (info_threads_command): Use gdb::option::process_options.
3364         (info_threads_command_completer): New.
3365         (_initialize_thread): Use gdb::option::build_help to build the
3366         help text for "info threads".
3367
3368 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3369
3370         * defs.h (generic_load): Move from here...
3371         * symfile.h (generic_load): ... to here.  Rename name parameter
3372         to args.
3373         * symfile.c (generic_load): Add comment.
3374
3375 2019-07-01  Tom Tromey  <tromey@adacore.com>
3376
3377         * dwarf2read.c
3378         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3379         declaration of without_params.  Fix formatting.
3380
3381 2019-07-01  Tom Tromey  <tromey@adacore.com>
3382
3383         * ada-exp.y (find_primitive_type): Update.
3384         * ada-lang.h (ada_lookup_symbol): Update.
3385         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3386         parameter.
3387         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3388
3389 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3390
3391         PR breakpoints/24541
3392         * gdbarch.c: Regenerate.
3393         * gdbarch.h: Regenerate.
3394         * gdbarch.sh: Add 'stap_adjust_register'.
3395         * i386-tdep.c: Include '<unordered_set>'.
3396         (i386_stap_adjust_register): New function.
3397         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3398         * stap-probe.c (stap_parse_register_operand): Call
3399         'gdbarch_stap_adjust_register'.
3400
3401 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3402
3403         PR python/24742
3404         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3405         * python/python.c (do_start_initialization): Use 'xmalloc'
3406         instead of 'PyMem_Malloc'.
3407
3408 2019-06-28  Tom Tromey  <tromey@adacore.com>
3409
3410         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3411         for Ada.
3412
3413 2019-06-27  Tom Tromey  <tromey@adacore.com>
3414
3415         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3416         objfile_key.
3417         (arm_find_mapping_symbol, arm_record_special_symbol)
3418         (_initialize_arm_tdep): Update.
3419         (arm_objfile_data_free): Remove.
3420
3421 2019-06-27  Tom Tromey  <tromey@adacore.com>
3422
3423         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3424         to cp_print_static_field.
3425
3426 2019-06-26  Tom Tromey  <tromey@adacore.com>
3427
3428         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3429         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3430         declare.
3431
3432 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3433
3434         * features/aarch64-core.c (create_feature_aarch64_core):
3435         Regenerate.
3436         * features/aarch64-core.xml: Add cpsr flags.
3437
3438 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3439
3440         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3441         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3442
3443 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3444
3445         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3446         field.
3447         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3448         use.
3449         (arm_record_special_symbol): Don't insert new symbol in sorted
3450         position, push it at the end.
3451
3452 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3453
3454         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3455         (arm_mapping_symbol_s): Remove.
3456         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3457         (arm_mapping_symbol_vec): New typedef.
3458         (struct arm_per_objfile): Add constructor.
3459         <section_maps>: Change type to
3460         std::unique_ptr<arm_mapping_symbol_vec[]>.
3461         (arm_compare_mapping_symbols): Remove.
3462         (arm_find_mapping_symbol): Adjust to section_maps type change.
3463         (arm_objfile_data_free): Call delete on arm_per_objfile.
3464         (arm_record_special_symbol): Adjust to section_maps type change.
3465         Allocate arm_per_objfile with new.
3466
3467 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3468
3469         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3470         with the command prefix.
3471
3472 2019-06-25  Tom Tromey  <tom@tromey.com>
3473
3474         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3475         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3476
3477 2019-06-25  Tom Tromey  <tom@tromey.com>
3478
3479         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3480         type.
3481         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3482         protected.
3483
3484 2019-06-25  Tom Tromey  <tom@tromey.com>
3485
3486         * tui/tui-winsource.c
3487         (tui_source_window_base::set_is_exec_point_at): Add check against
3488         LOA_ADDRESS.
3489
3490 2019-06-25  Tom Tromey  <tom@tromey.com>
3491
3492         * tui/tui-source.c (tui_set_source_content): Don't check before
3493         xfree.
3494         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3495
3496 2019-06-25  Tom Tromey  <tom@tromey.com>
3497
3498         * tui/tui-winsource.h (tui_update_source_window_as_is)
3499         (tui_alloc_source_buffer, tui_line_is_displayed)
3500         (tui_addr_is_displayed): Change type of win_info.
3501         * tui/tui-winsource.c (tui_update_source_window_as_is)
3502         (tui_clear_source_content, tui_show_source_line)
3503         (tui_show_source_content, tui_source_window_base::refill)
3504         (tui_source_window_base::set_is_exec_point_at)
3505         (tui_source_window_base::set_is_exec_point_at)
3506         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3507         (tui_alloc_source_buffer, tui_line_is_displayed)
3508         (tui_addr_is_displayed): Change type of win_info.  Update.
3509         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3510         (tui_source_window_base::do_make_visible_with_new_height):
3511         Update.
3512         * tui/tui-source.c (tui_set_source_content)
3513         (tui_set_source_content_nil)
3514         (tui_source_window::do_scroll_vertical): Update.
3515         * tui/tui-layout.c (show_layout): Update.
3516         * tui/tui-disasm.c (tui_set_disassem_content)
3517         (tui_disasm_window::do_scroll_vertical): Update.
3518         * tui/tui-data.h (tui_win_content): Remove.
3519         (struct tui_gen_win_info) <content, content_size>: Remove.
3520         (struct tui_source_element): Add initializers and destructor.
3521         (union tui_which_element, struct tui_win_element): Remove.
3522         (struct tui_source_window_base) <content>: New field.
3523         (struct tui_data_window): Remove destructor.
3524         (tui_alloc_content, tui_free_win_content)
3525         (tui_free_all_source_wins_content): Don't declare.
3526         * tui/tui-data.c (tui_initialize_static_data): Update.
3527         (init_content_element, tui_alloc_content): Remove.
3528         (~tui_gen_win_info): Update.
3529         (~tui_data_window, tui_free_all_source_wins_content)
3530         (tui_free_win_content, free_content, free_content_elements):
3531         Remove.
3532
3533 2019-06-25  Tom Tromey  <tom@tromey.com>
3534
3535         * tui/tui-winsource.h (tui_clear_source_content)
3536         (tui_erase_source_content, tui_show_source_content): Change type
3537         of win_info.
3538         * tui/tui-winsource.c (tui_clear_source_content)
3539         (tui_erase_source_content, tui_show_source_content): Change type
3540         of win_info.
3541         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3542         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3543         win_info.
3544         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3545         win_info.
3546         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3547
3548 2019-06-25  Tom Tromey  <tom@tromey.com>
3549
3550         * tui/tui-winsource.c (tui_clear_source_content)
3551         (tui_source_window_base::set_is_exec_point_at): Update.
3552         * tui/tui-source.c (tui_set_source_content_nil): Update.
3553         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3554         a bool.
3555         * tui/tui-data.c (init_content_element): Update.
3556
3557 2019-06-25  Tom Tromey  <tom@tromey.com>
3558
3559         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3560         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3561         * tui/tui-layout.c (init_and_make_win): Update.
3562         * tui/tui.h (enum tui_win_type): Update.
3563         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3564         tui_win_is_auxillary.
3565         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3566         tui_win_is_auxillary.
3567
3568 2019-06-25  Tom Tromey  <tom@tromey.com>
3569
3570         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3571         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3572         (tui_delete_data_content_windows, tui_display_all_data)
3573         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3574         Update.
3575         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3576         * tui/tui-regs.c (tui_last_regs_line_no)
3577         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3578         (tui_show_registers): Update.
3579         (tui_show_register_group): Return void.  Update.
3580         (tui_display_registers_from, tui_display_reg_element_at_line)
3581         (tui_display_registers_from_line, tui_check_register_values):
3582         Update.
3583         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3584         member.
3585         (struct tui_data_window) <regs_content>: Now a std::vector.
3586         <regs_content_count>: Remove.
3587         (tui_add_content_elements, tui_free_data_content): Don't declare.
3588         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3589         (init_content_element): Remove DATA_WIN case.  Add assert.
3590         (tui_add_content_elements): Remove.
3591         (tui_data_window): Update.
3592         (tui_free_data_content): Remove.
3593         (free_content_elements): Remove DATA_WIN case.
3594
3595 2019-06-25  Tom Tromey  <tom@tromey.com>
3596
3597         * tui/tui-data.c (tui_data_item_window): Update.
3598         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3599         * tui/tui-windata.c (tui_display_all_data)
3600         (tui_display_data_from_line): Update.
3601         (tui_check_data_values): Remove.
3602         * tui/tui-regs.c (tui_show_register_group)
3603         (tui_display_reg_element_at_line): Update.
3604         * tui/tui-hooks.c (tui_register_changed)
3605         (tui_refresh_frame_and_register_information): Call
3606         tui_check_register_values.
3607         * tui/tui-data.h (struct tui_data_window) <data_content,
3608         data_content_count, data_type>: Remove.
3609         (enum tui_data_type): Remove.
3610
3611         * tui/tui-data.c (tui_data_window::clear_detail)
3612         (~tui_data_window): Update.
3613
3614 2019-06-25  Tom Tromey  <tom@tromey.com>
3615
3616         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3617         declare.
3618         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3619         Rename from tui_first_data_item_displayed.  Update.
3620         (tui_data_window::refresh_all)
3621         (tui_data_window::do_scroll_vertical): Update.
3622         * tui/tui-data.h (struct tui_data_window)
3623         <first_data_item_displayed>: Declare new method.
3624
3625 2019-06-25  Tom Tromey  <tom@tromey.com>
3626
3627         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3628         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3629         contents...
3630         (tui_initialize_static_data): ...here.
3631
3632 2019-06-25  Tom Tromey  <tom@tromey.com>
3633
3634         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3635         (tui_display_registers_from, tui_check_register_values): Update.
3636         (tui_display_register): Remove win_info parameter; update.
3637         (tui_get_register): Change type of parameters.
3638         * tui/tui-data.h (struct tui_data_element): Remove.
3639         (union tui_which_element) <data>: Remove.
3640         <data_window>: Change type.
3641         (struct tui_data_item_window): New.
3642         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3643         case.  Add assert.
3644         (~tui_data_item_window): New destructor.
3645         (free_content_elements): Remove DATA_ITEM_WIN case.
3646
3647 2019-06-25  Tom Tromey  <tom@tromey.com>
3648
3649         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3650         Remove.
3651
3652 2019-06-25  Tom Tromey  <tom@tromey.com>
3653
3654         * tui/tui-data.h (struct tui_command_element): Remove.
3655         (union tui_which_element) <command>: Remove.
3656         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3657         assert.
3658         (free_content_elements): Remove CMD_WIN case.
3659
3660 2019-06-25  Tom Tromey  <tom@tromey.com>
3661
3662         * tui/tui-layout.c (tui_set_layout): Update.
3663         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3664         * tui/tui-data.c (layout_def): Update.
3665
3666 2019-06-25  Tom Tromey  <tom@tromey.com>
3667
3668         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3669         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3670         (tui_source_window_base::set_new_height): Update.
3671         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3672         Update.
3673         (tui_set_locator_fullname, tui_set_locator_info)
3674         (tui_show_frame_info): Update.
3675         * tui/tui-source.c (tui_set_source_content)
3676         (tui_source_is_displayed): Update.
3677         * tui/tui-layout.c (show_source_disasm_command, show_data)
3678         (show_source_or_disasm_and_command): Update.
3679         * tui/tui-disasm.c (tui_set_disassem_content)
3680         (tui_get_begin_asm_address): Update.
3681         * tui/tui-data.h (struct tui_locator_element): Remove.
3682         (union tui_which_element) <locator>: Remove.
3683         (struct tui_locator_window): New.
3684         (tui_locator_win_info_ptr): Change return type.
3685         * tui/tui-data.c (_locator): Change type.
3686         (tui_locator_win_info_ptr): Change return type.
3687         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3688         (tui_alloc_content): Add assert.
3689
3690 2019-06-25  Tom Tromey  <tom@tromey.com>
3691
3692         * tui/tui-winsource.c
3693         (tui_exec_info_window::maybe_allocate_content): New method.
3694         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3695         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3696         (make_source_or_disasm_window): Add cast.
3697         * tui/tui-data.h (union tui_which_element) <simple_string>:
3698         Remove.
3699         (struct tui_source_info): New.
3700         (struct tui_source_window_base) <execution_info>: Change type.
3701         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3702         case, and add assert.
3703         (tui_alloc_content): Add assert.
3704
3705 2019-06-25  Tom Tromey  <tom@tromey.com>
3706
3707         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3708         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3709         * tui/tui-data.c (tui_alloc_win_info): Remove.
3710
3711 2019-06-25  Tom Tromey  <tom@tromey.com>
3712
3713         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3714         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3715         can_highlight.
3716
3717 2019-06-25  Tom Tromey  <tom@tromey.com>
3718
3719         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3720         make_visible_with_new_height method.
3721         (tui_win_info::make_visible_with_new_height): New method.
3722         (tui_source_window_base::do_make_visible_with_new_height)
3723         (tui_data_window::do_make_visible_with_new_height)
3724         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3725         (make_visible_with_new_height): Remove.
3726         (tui_resize_all, tui_adjust_win_heights): Use
3727         make_visible_with_new_height method.
3728         * tui/tui-data.h (struct tui_win_info)
3729         <do_make_visible_with_new_height, make_visible_with_new_height>:
3730         New methods.
3731         (struct tui_source_window_base, struct tui_data_window)
3732         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3733         methods.
3734
3735 2019-06-25  Tom Tromey  <tom@tromey.com>
3736
3737         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3738         method.
3739         (update_tab_width): Call update_tab_width method.
3740         * tui/tui-data.h (struct tui_win_info)
3741         (struct tui_source_window_base) <update_tab_width>: New methods.
3742
3743 2019-06-25  Tom Tromey  <tom@tromey.com>
3744
3745         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3746         parameter.
3747         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3748         parameter.
3749         (tui_gen_win_info::make_visible): Update.
3750         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3751         parameter.
3752         * tui/tui-data.h (enum tui_box): New enum.
3753         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3754
3755 2019-06-25  Tom Tromey  <tom@tromey.com>
3756
3757         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3758         init_and_make_win for EXEC_INFO_WIN.
3759         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3760         longer inline.
3761         (struct tui_win_info) <~tui_win_info>: Inline.
3762         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3763         Don't declare.
3764         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3765         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3766         Remove.
3767         (tui_initialize_static_data): Update.
3768         (~tui_gen_win_info): Handle more cleanup here.
3769         (~tui_source_window_base): Delete "execution_info".
3770         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3771
3772 2019-06-25  Tom Tromey  <tom@tromey.com>
3773
3774         * tui/tui-layout.c (make_command_window): Don't set
3775         can_highlight.
3776         (show_source_disasm_command): Call the reset method.
3777         (show_data): Don't set can_highlight.  Call the reset method.
3778         (tui_gen_win_info::reset): Rename from init_gen_win_info
3779         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3780         (show_source_or_disasm_and_command): Call the reset method.
3781         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3782         (struct tui_cmd_window): Set can_highlight.
3783
3784 2019-06-25  Tom Tromey  <tom@tromey.com>
3785
3786         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3787         from make_visible.
3788         (tui_make_visible, tui_make_invisible): Rewrite.
3789         (tui_win_info::make_visible): Remove.
3790         (tui_source_window_base::make_visible): Update.
3791         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3792         method.  Moved from...
3793         (struct tui_win_info) <make_visible>: ...here.
3794
3795 2019-06-25  Tom Tromey  <tom@tromey.com>
3796
3797         * tui/tui-winsource.c
3798         (tui_source_window_base::do_scroll_horizontal): Remove direction
3799         parameter.
3800         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3801         direction parameter.
3802         * tui/tui-win.c (tui_win_info::forward_scroll)
3803         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3804         (tui_win_info::right_scroll): Update.
3805         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3806         direction parameter.
3807         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3808         direction parameter.
3809         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3810         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3811         Remove direction parameter.
3812         (struct tui_source_window_base, struct tui_source_window)
3813         (struct tui_disasm_window, struct tui_data_window)
3814         (struct tui_cmd_window): Update.
3815
3816 2019-06-25  Tom Tromey  <tom@tromey.com>
3817
3818         * tui/tui-winsource.h (tui_set_exec_info_content)
3819         (tui_show_exec_info_content, tui_erase_exec_info_content)
3820         (tui_clear_exec_info_content, tui_update_exec_info): Change
3821         argument to tui_source_window_base.
3822         * tui/tui-winsource.c (tui_set_exec_info_content)
3823         (tui_show_exec_info_content, tui_erase_exec_info_content)
3824         (tui_clear_exec_info_content, tui_update_exec_info): Change
3825         argument to tui_source_window_base.
3826
3827 2019-06-25  Tom Tromey  <tom@tromey.com>
3828
3829         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3830         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3831
3832 2019-06-25  Tom Tromey  <tom@tromey.com>
3833
3834         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3835         check.
3836
3837 2019-06-25  Tom Tromey  <tom@tromey.com>
3838
3839         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3840         type to void.
3841         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3842         type to void.
3843         * tui/tui-source.c (tui_set_source_content): Update.
3844         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3845
3846 2019-06-25  Tom Tromey  <tom@tromey.com>
3847
3848         * tui/tui-win.c (window_name_completer, tui_set_focus)
3849         (tui_all_windows_info): Use name method.
3850         * tui/tui-data.h (struct tui_gen_win_info)
3851         (struct tui_source_window, struct tui_disasm_window)
3852         (struct tui_data_window, struct tui_cmd_window) <name>: New
3853         method.
3854         (tui_win_name): Don't declare.
3855         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3856         (tui_win_name): Remove.
3857
3858 2019-06-25  Tom Tromey  <tom@tromey.com>
3859
3860         * tui/tui-winsource.h (tui_update_source_window)
3861         (tui_update_source_window_as_is): Change parameter type.
3862         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3863         to be a tui_source_window_base.
3864         (tui_update_source_window_as_is): Likewise.
3865         * tui/tui-win.c (make_visible_with_new_height): Update.
3866
3867 2019-06-25  Tom Tromey  <tom@tromey.com>
3868
3869         * tui/tui-winsource.c (tui_erase_source_content)
3870         (tui_show_source_content, tui_show_exec_info_content)
3871         (tui_erase_exec_info_content): Use refresh_window method.
3872         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3873         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3874         from tui_refresh_win.
3875         (tui_data_window::refresh_window): New method.
3876         (tui_win_info::refresh, tui_source_window_base::refresh)
3877         (tui_refresh_all): Use refresh_window method.
3878         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3879         method.
3880         * tui/tui-regs.c (tui_display_register): Call refresh_window
3881         method.
3882         * tui/tui-layout.c (show_source_disasm_command)
3883         (show_source_or_disasm_and_command): Call refresh_window method.
3884         * tui/tui-data.h (struct tui_gen_win_info)
3885         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3886         New method.
3887
3888 2019-06-25  Tom Tromey  <tom@tromey.com>
3889
3890         * tui/tui.c (tui_rl_other_window, tui_enable)
3891         (tui_is_window_visible, tui_get_command_dimension): Update.
3892         * tui/tui-winsource.c (tui_update_source_window_as_is)
3893         (tui_clear_source_content, tui_erase_source_content)
3894         (tui_show_source_line, tui_source_window_base::refill)
3895         (tui_source_window_base::do_scroll_horizontal)
3896         (tui_source_window_base::set_is_exec_point_at)
3897         (tui_update_breakpoint_info, tui_set_exec_info_content)
3898         (tui_alloc_source_buffer, tui_line_is_displayed)
3899         (tui_addr_is_displayed): Update.
3900         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3901         (tui_check_and_display_highlight_if_needed)
3902         (tui_win_info::make_visible, tui_win_info::refresh)
3903         (tui_refresh_all): Update.
3904         * tui/tui-windata.c (tui_first_data_item_displayed)
3905         (tui_delete_data_content_windows, tui_erase_data_content)
3906         (tui_display_all_data, tui_data_window::refresh_all)
3907         (tui_check_data_values): Update.
3908         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3909         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3910         (tui_win_info::backward_scroll, tui_refresh_all_win)
3911         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3912         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3913         (tui_source_window_base::set_new_height)
3914         (tui_data_window::set_new_height)
3915         (make_invisible_and_set_new_height)
3916         (make_visible_with_new_height, new_height_ok)
3917         (parse_scrolling_args): Update.
3918         * tui/tui-stack.c (tui_show_frame_info): Update.
3919         * tui/tui-source.c (tui_set_source_content)
3920         (tui_set_source_content_nil, tui_source_is_displayed)
3921         (tui_source_window::do_scroll_vertical): Update.
3922         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3923         (tui_display_registers_from, tui_display_reg_element_at_line)
3924         (tui_check_register_values, tui_reg_command): Update.
3925         * tui/tui-layout.c (tui_default_win_height)
3926         (show_source_disasm_command, show_data, init_and_make_win)
3927         (show_source_or_disasm_and_command): Update.
3928         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3929         (tui_redisplay_readline, tui_mld_flush)
3930         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3931         (tui_getc): Update.
3932         * tui/tui-disasm.c (tui_set_disassem_content)
3933         (tui_disasm_window::do_scroll_vertical): Update.
3934         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3935         Now virtual.
3936         (struct tui_win_info): Derive from tui_gen_win_info.
3937         <~tui_win_info>: Mark as override.
3938         <generic>: Remove member.
3939         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3940         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3941         (~tui_data_window, ~tui_win_info)
3942         (tui_free_all_source_wins_content): Update.
3943         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3944
3945 2019-06-25  Tom Tromey  <tom@tromey.com>
3946
3947         * tui/tui-layout.c (init_and_make_win): Use new.
3948         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3949         destructor, initializers.
3950         (tui_alloc_generic_win_info): Don't declare.
3951         * tui/tui-data.c (_locator): Add argument to constructor.
3952         (source_win, disasm_win): New globals.
3953         (exec_info): Remove.
3954         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3955         Update.
3956         (tui_alloc_generic_win_info): Remove.
3957         (init_content_element): Use new.
3958         (tui_win_info::tui_win_info): Update.
3959         (free_content_elements) <case DATA_WIN>: Use delete.
3960
3961 2019-06-25  Tom Tromey  <tom@tromey.com>
3962
3963         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3964         * tui/tui-windata.c (tui_first_data_item_displayed)
3965         (tui_delete_data_content_windows): Update.
3966         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3967         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3968         (tui_display_registers_from, tui_check_register_values): Update.
3969         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3970         pointer.
3971         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3972         window.
3973         (tui_free_data_content): Update.
3974         (free_content_elements) <case DATA_WIN>: Free the window.
3975
3976 2019-06-25  Tom Tromey  <tom@tromey.com>
3977
3978         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3979         Update.
3980         * tui/tui-layout.c (make_command_window)
3981         (show_source_disasm_command, show_data, init_and_make_win)
3982         (show_source_or_disasm_and_command): Update.
3983         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3984         method.
3985         <can_highight, is_highlighted>: Now bool.
3986         (tui_set_win_highlight): Don't declare.
3987         * tui/tui-data.c (tui_set_win_highlight): Remove.
3988
3989 2019-06-25  Tom Tromey  <tom@tromey.com>
3990
3991         * tui/tui-wingeneral.c (make_visible): Remove check of window
3992         type.
3993
3994 2019-06-25  Tom Tromey  <tom@tromey.com>
3995
3996         * tui/tui-win.c (tui_win_info::max_height)
3997         (tui_cmd_window::max_height): New methods.
3998         (new_height_ok): Call max_height.
3999         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4000         <max_height>: New method.
4001
4002 2019-06-25  Tom Tromey  <tom@tromey.com>
4003
4004         * tui/tui-win.c (tui_source_window_base::set_new_height)
4005         (tui_data_window::set_new_height): New methods.
4006         (make_invisible_and_set_new_height): Call set_new_height method.
4007         * tui/tui-data.h (struct tui_win_info)
4008         (struct tui_source_window_base, struct tui_data_window)
4009         <set_new_height>: New method.
4010
4011 2019-06-25  Tom Tromey  <tom@tromey.com>
4012
4013         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4014         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4015         tui_refresh_data_win.
4016         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4017         method.
4018         (tui_refresh_all_win): Call the refresh_all method.
4019         (tui_set_focus): Likewise.
4020         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4021         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4022         Likewise.
4023
4024 2019-06-25  Tom Tromey  <tom@tromey.com>
4025
4026         * tui/tui-winsource.h (tui_refill_source_window)
4027         (tui_set_is_exec_point_at): Don't declare.
4028         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4029         (tui_source_window_base::refill): Rename from
4030         tui_refill_source_window.
4031         (tui_source_window_base::do_scroll_horizontal): Update.
4032         (tui_source_window_base::set_is_exec_point_at): Rename from
4033         tui_set_is_exec_point_at.
4034         (tui_update_all_breakpoint_info): Update.
4035         * tui/tui-stack.c (tui_show_frame_info): Update.
4036         * tui/tui-layout.c (show_data): Add cast.
4037         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4038         * tui/tui-data.h (struct tui_source_window_base) <refill,
4039         set_is_exec_point_at>: New methods.
4040         (tui_source_windows, tui_add_to_source_windows): Update types.
4041         (tui_add_to_source_windows): Remove redundant declaration.
4042         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4043         (tui_source_windows): Change return type.
4044         (tui_clear_source_windows_detail): Update.
4045         (tui_add_to_source_windows): Change type of parameter.
4046         (tui_free_all_source_wins_content): Update.
4047
4048 2019-06-25  Tom Tromey  <tom@tromey.com>
4049
4050         * tui/tui-wingeneral.c (tui_win_info::refresh)
4051         (tui_source_window_base::refresh): New methods.
4052         (tui_refresh_all): Call the refresh method.
4053         * tui/tui-data.h (struct tui_win_info)
4054         (struct tui_source_window_base) <refresh>: New method.
4055
4056 2019-06-25  Tom Tromey  <tom@tromey.com>
4057
4058         * tui/tui.h (tui_is_window_visible): Return bool.
4059         * tui/tui.c (tui_is_window_visible): Return bool.
4060         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4061         (tui_make_visible, tui_make_invisible)
4062         (tui_win_info::make_visible)
4063         (tui_source_window_base::make_visible, make_all_visible)
4064         (tui_make_all_visible, tui_make_all_invisible): Update.
4065         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4066         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4067         bool.
4068         (struct tui_win_info, struct tui_source_window_base)
4069         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4070         * tui/tui-data.c (tui_init_generic_part): Update.
4071
4072 2019-06-25  Tom Tromey  <tom@tromey.com>
4073
4074         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4075         (tui_source_window_base::make_visible): New methods.
4076         (make_all_visible): Make method call.
4077         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4078         (struct tui_source_window_base, struct tui_cmd_window): Override
4079         make_visible.
4080         (tui_win_is_source_type): Don't declare.
4081         * tui/tui-data.c (tui_win_is_source_type): Remove.
4082
4083 2019-06-25  Tom Tromey  <tom@tromey.com>
4084
4085         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4086         NULL check.
4087
4088 2019-06-25  Tom Tromey  <tom@tromey.com>
4089
4090         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4091         Inline constructor.  Add initializers for members.
4092         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4093         constructors; now inline in class.
4094
4095 2019-06-25  Tom Tromey  <tom@tromey.com>
4096
4097         * tui/tui-regs.c (tui_show_registers): Update.
4098         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4099         bool.
4100         * tui/tui-data.c (tui_data_window::clear_detail)
4101         (tui_data_window): Update.
4102
4103 2019-06-25  Tom Tromey  <tom@tromey.com>
4104
4105         * tui/tui-windata.c (tui_display_all_data)
4106         (tui_display_data_from_line, tui_display_data_from)
4107         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4108         Update.
4109         * tui/tui-regs.c (tui_last_regs_line_no)
4110         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4111         (tui_show_registers, tui_show_register_group)
4112         (tui_display_registers_from, tui_display_reg_element_at_line)
4113         (tui_display_registers_from_line, tui_check_register_values)
4114         (tui_reg_next, tui_reg_prev): Update.
4115         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4116         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4117         tui_data_window.
4118         (struct tui_win_info) <detail>: Remove.  Add new fields from
4119         tui_data_info.
4120         (TUI_DATA_WIN): Add cast.
4121         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4122         (~tui_data_window): Simplify.
4123
4124 2019-06-25  Tom Tromey  <tom@tromey.com>
4125
4126         * tui/tui-layout.c (show_source_disasm_command)
4127         (show_source_or_disasm_and_command): Update.
4128         * tui/tui-io.c (update_cmdwin_start_line)
4129         (tui_redisplay_readline): Update.
4130         * tui/tui-data.h (struct tui_command_info): Remove.
4131         (struct tui_win_info) <detail>: Remove command_info member.
4132         (struct tui_data_window) <start_line>: New member, from
4133         tui_command_info.
4134         (TUI_CMD_WIN): Add casts.
4135
4136 2019-06-25  Tom Tromey  <tom@tromey.com>
4137
4138         * tui/tui-winsource.c (tui_update_source_window)
4139         (tui_refill_source_window)
4140         (tui_source_window_base::do_scroll_horizontal)
4141         (tui_update_breakpoint_info, tui_set_exec_info_content)
4142         (tui_show_exec_info_content, tui_erase_exec_info_content)
4143         (tui_clear_exec_info_content): Update.
4144         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4145         Update.
4146         * tui/tui-win.c (make_invisible_and_set_new_height)
4147         (make_visible_with_new_height): Update.
4148         * tui/tui-source.c (tui_set_source_content)
4149         (tui_show_symtab_source): Update.
4150         * tui/tui-layout.c (extract_display_start_addr)
4151         (show_source_disasm_command, show_data)
4152         (make_source_or_disasm_window)
4153         (show_source_or_disasm_and_command): Update.
4154         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4155         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4156         "gdbarch".
4157         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4158         to tui_source_window_base.
4159         (struct tui_win_info) <detail>: Remove source_info member.
4160         (struct tui_source_window_base) <has_locator>: Inline.
4161         Move contents from tui_source_info; rename has_locator member to
4162         m_has_locator.
4163         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4164         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4165         header file.
4166         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4167         Simplify.
4168         (tui_free_all_source_wins_content): Cast to
4169         tui_source_window_base.
4170
4171 2019-06-25  Tom Tromey  <tom@tromey.com>
4172
4173         * tui/tui-win.c (make_invisible_and_set_new_height)
4174         (make_visible_with_new_height): Call has_locator method.
4175         * tui/tui-layout.c (show_source_disasm_command, show_data)
4176         (show_source_or_disasm_and_command): Update for bool change.
4177         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4178         (tui_win_info) <has_locator>: New method.
4179         (struct tui_source_window_base) <has_locator>: New method.
4180         (tui_win_has_locator): Don't declare.
4181         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4182         from tui_win_has_locator.
4183         (tui_source_window_base): Use false, not FALSE.
4184
4185 2019-06-25  Tom Tromey  <tom@tromey.com>
4186
4187         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4188         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4189         clear_detail method directly.
4190         (tui_clear_win_detail): Remove.
4191
4192 2019-06-25  Tom Tromey  <tom@tromey.com>
4193
4194         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4195         "this", not TUI_DISASM_WIN.
4196
4197 2019-06-25  Tom Tromey  <tom@tromey.com>
4198
4199         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4200         declare.
4201         * tui/tui-winsource.c
4202         (tui_source_window_base::do_scroll_horizontal): Rename from
4203         tui_horizontal_source_scroll.
4204         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4205         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4206         from tui_vertical_data_scroll.
4207         * tui/tui-win.h (tui_scroll): Don't declare.
4208         * tui/tui-win.c (tui_win_info::forward_scroll)
4209         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4210         (tui_win_info::right_scroll): Rename and update.
4211         (tui_scroll_forward_command, tui_scroll_backward_command)
4212         (tui_scroll_left_command, tui_scroll_right_command): Update.
4213         (tui_scroll): Remove.
4214         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4215         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4216         from tui_vertical_source_scroll.
4217         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4218         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4219         from tui_vertical_disassem_scroll.
4220         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4221         do_scroll_horizontal>: New methods.
4222         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4223         Likewise.
4224         (struct tui_source_window_base): Add do_scroll_horizontal.
4225         (struct tui_source_window, struct tui_disasm_window): Add
4226         do_scroll_vertical.
4227         (struct tui_data_window, struct tui_cmd_window): Add
4228         do_scroll_horizontal and do_scroll_vertical.
4229         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4230
4231 2019-06-25  Tom Tromey  <tom@tromey.com>
4232
4233         * tui/tui-data.h (struct tui_source_window_base): New struct.
4234         (struct tui_source_window): Derive from tui_source_window_base.
4235         (struct tui_disasm_window): New struct.
4236         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4237         from tui_source_window::clear_detail.
4238         (tui_source_window_base): Rename from tui_source_window.
4239         (~tui_source_window_base): Rename from ~tui_source_window.
4240         (tui_alloc_win_info): Create a tui_disasm_window.
4241
4242 2019-06-25  Tom Tromey  <tom@tromey.com>
4243
4244         * tui/tui-data.h (struct tui_source_window)
4245         (struct tui_data_window): Declare destructors.
4246         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4247         destructors.
4248         (tui_win_info): Simplify.
4249
4250 2019-06-25  Tom Tromey  <tom@tromey.com>
4251
4252         * tui/tui-winsource.c (tui_display_main)
4253         (tui_update_source_windows_with_addr)
4254         (tui_update_all_breakpoint_info): Update.
4255         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4256         (new_height_ok, parse_scrolling_args): Update.
4257         * tui/tui-stack.c (tui_show_frame_info): Update.
4258         * tui/tui-data.h (struct tui_list): Remove.
4259         (tui_source_windows): Return a reference to a std::vector.
4260         * tui/tui-data.c (source_windows): Now a std::vector.
4261         (tui_source_windows): Change return type.
4262         (tui_clear_source_windows): Rewrite.
4263         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4264         (tui_free_all_source_wins_content): Rewrite.
4265
4266 2019-06-25  Tom Tromey  <tom@tromey.com>
4267
4268         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4269         (struct tui_data_window, struct tui_cmd_window): Declare
4270         clear_detail method.
4271         * tui/tui-data.c (tui_source_window::clear_detail)
4272         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4273         methods.
4274         (tui_clear_win_detail): Simplify.
4275
4276 2019-06-25  Tom Tromey  <tom@tromey.com>
4277
4278         * tui/tui-layout.c (make_source_window, make_disasm_window)
4279         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4280         Return the new window.
4281         (show_source_disasm_command, show_data)
4282         (show_source_or_disasm_and_command): Update.
4283
4284 2019-06-25  Tom Tromey  <tom@tromey.com>
4285
4286         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4287         parameter.  Return the new window.
4288         (show_source_disasm_command): Update and remove NULL check.
4289         (show_source_or_disasm_and_command): Update.
4290
4291 2019-06-25  Tom Tromey  <tom@tromey.com>
4292
4293         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4294
4295 2019-06-25  Tom Tromey  <tom@tromey.com>
4296
4297         * tui/tui-data.h (struct tui_win_info): Make constructor
4298         protected.  Make destructor virtual.  Add initializers.
4299         (tui_source_window, tui_data_window, tui_cmd_window): New
4300         classes.
4301         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4302         constructor.  Add "type" parameter.
4303         (tui_source_window, tui_data_window, tui_cmd_window): New
4304         constructors.
4305         (tui_alloc_win_info): Instantiate the appropriate subclass.
4306
4307 2019-06-25  Tom Tromey  <tom@tromey.com>
4308
4309         * tui/tui-win.c (tui_resize_all): Use delete.
4310         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4311         destructor.
4312         (tui_free_window): Don't declare.
4313         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4314         Update.
4315
4316 2019-06-25  Tom Tromey  <tom@tromey.com>
4317
4318         * tui/tui-data.h (struct tui_win_info): Add constructor.
4319         * tui/tui-data.c (tui_alloc_win_info): Use new.
4320         (tui_free_window): Use delete.
4321
4322 2019-06-22  Tom Tromey  <tom@tromey.com>
4323
4324         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4325         declare.
4326         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4327
4328 2019-06-22  Tom Tromey  <tom@tromey.com>
4329
4330         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4331         declare.
4332         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4333
4334 2019-06-22  Tom de Vries  <tdevries@suse.de>
4335
4336         * dwarf2read.c (create_addrmap_from_aranges)
4337         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4338         instead of '%zu'.
4339
4340 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4341
4342         * dwarf2read.h (dwarf2_section_info_def): Remove.
4343         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4344         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4345         std::vector<dwarf2_section_info>.
4346         (struct dwo_file) <~dwo_file>: Remove.
4347         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4348         types field.
4349         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4350         (dwarf2_read_debug_names): Likewise.
4351         (create_debug_types_hash_table): Change parameter type to
4352         array_view, adjust code accordingly.
4353         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4354         (partial_die_info::fixup): Likewise.
4355         (determine_prefix): Likewise.
4356         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4357
4358 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4359
4360         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4361         gdb_bfd_ref_ptr.
4362         <~dwo_file>: Remove call to gdb_bfd_unref.
4363         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4364         gdb_bfd_ref_ptr::get.
4365
4366 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4367
4368         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4369         type to htab_up.
4370         * dwarf2read.c (struct dwo_file): Initialize fields.
4371         <~dwo_file>: New.
4372         (free_dwo_file): Remove, move content to ~dwo_file.
4373         (struct dwo_file_deleter): Remove.
4374         (dwo_file_up>: Remove custom deleter.
4375         (free_dwo_files): Remove.
4376         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4377         dwo_files.
4378         (process_skeletonless_type_units): Call unique_ptr::get.
4379         (allocate_dwo_file_hash_table): Add deleter to created hash
4380         table.  Change return type to htab_up.
4381         (lookup_dwo_file_slot): Don't memset dwo_file, call
4382         unique_ptr::get.
4383         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4384         (create_dwo_unit_in_dwp_v2): Likewise.
4385         (open_and_init_dwo_file): Likewise.
4386         (free_dwo_file_from_slot): Remove.
4387
4388 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4389
4390         * dwarf2read.h (struct dwarf2_section_info) <readin,
4391         is_virtual>: Change type to bool.
4392         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4393         true instead of 1.
4394
4395 2019-06-19  Tom Tromey  <tom@tromey.com>
4396
4397         * tui/tui-data.h (tui_init_content_element): Don't declare.
4398
4399 2019-06-19  Tom Tromey  <tom@tromey.com>
4400
4401         * tui/tui-data.h (tui_init_win_info): Don't declare.
4402
4403 2019-06-19  Tom de Vries  <tdevries@suse.de>
4404
4405         * dwarf2read.h (abstract_to_concrete): Change type to
4406         std::unordered_map<sect_offset, std::vector<sect_offset>,
4407         gdb::hash_enum<sect_offset>>.
4408
4409 2019-06-19  Tom Tromey  <tromey@adacore.com>
4410
4411         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4412         EVAL_AVOID_SIDE_EFFECTS specially.
4413
4414 2019-06-19  Tom Tromey  <tromey@adacore.com>
4415
4416         * source-cache.c (highlighter): New global.
4417         (source_cache::get_source_lines): Create a highlighter on demand.
4418
4419 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4420
4421         * defs.h (deprecated_interactive_hook): Delete declaration.
4422         * interps.c (clear_interpreter_hooks): Remove use of
4423         deprecated_interactive_hook.
4424         * top.c (deprecated_interactive_hook): Delete definition.
4425         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4426
4427 2019-06-18  Tom de Vries  <tdevries@suse.de>
4428
4429         PR gdb/24515
4430         * dwarf2read.h (abstract_to_concrete): Change type from
4431         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4432         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4433         * dwarf2read.c (read_variable): Update.
4434         (dwarf2_fetch_die_loc_sect_off): Update.
4435
4436 2019-06-17  Tom de Vries  <tdevries@suse.de>
4437
4438         PR gdb/24617
4439         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4440         accessing parent[parent_len - 1].
4441
4442 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4443
4444         PR gdb/24364
4445         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4446         call dtrace_process_dof with NULL dof.
4447
4448 2019-06-16  Tom de Vries  <tdevries@suse.de>
4449
4450         PR gdb/24445
4451         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4452
4453 2019-06-16  Tom Tromey  <tom@tromey.com>
4454
4455         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4456         (make_all_visible): Use address of member.
4457
4458 2019-06-16  Tom Tromey  <tom@tromey.com>
4459
4460         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4461         (tui_free_window, free_content, free_content_elements): Remove
4462         unnecessary cast.
4463         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4464         cast.
4465         * tui/tui-regs.c (tui_show_register_group)
4466         (tui_display_registers_from, tui_display_reg_element_at_line):
4467         Remove unnecessary cast.
4468
4469 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4470
4471         * linux-nat.c (normal_mask): Delete.
4472         (_initialize_linux_nat): Don't initialise normal_mask.
4473
4474 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4475
4476         PR gdb/24445
4477         * dwarf-index-write.h (write_psymtabs_to_index): Add
4478         dwz_basename parameter.
4479         * dwarf-index-write.c (write_gdbindex): Move file writing to
4480         write_gdbindex_1.  Change return type void.
4481         (assert_file_size): Move up, remove filename parameter.
4482         (write_gdbindex_1): New function.
4483         (write_debug_names): Change return type to void, call
4484         assert_file_size.
4485         (struct index_wip_file): New struct.
4486         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4487         file logic to index_wip_file.  Write index for dwz file if
4488         needed.
4489         (save_gdb_index_command): Pass basename of dwz file, if present.
4490         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4491         build-id of dwz file, if present.
4492         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4493         (dwarf2_get_dwz_file): Likewise.
4494         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4495         (dwarf2_get_dwz_file): Likewise.
4496
4497 2019-06-16  Tom Tromey  <tom@tromey.com>
4498
4499         * coffread.c (process_coff_symbol): Use xstrdup.
4500         * value.c (create_internalvar): Use xstrdup.
4501
4502 2019-06-16  Tom Tromey  <tom@tromey.com>
4503
4504         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4505         * breakpoint.c (stopin_command, stopat_command)
4506         (until_break_command, decode_location_default): Remove unnecessary
4507         cast.
4508         * utils.c (subset_compare): Remove unnecessary cast.
4509         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4510         cast.
4511         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4512         cast.
4513         * infcmd.c (path_command): Remove unnecessary cast.
4514         * coffread.c (decode_type): Remove unnecessary cast.
4515         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4516         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4517         * tui/tui-stack.c (tui_show_locator_content)
4518         (tui_show_frame_info): Remove unnecessary cast.
4519         * tui/tui-win.c (tui_scroll_forward_command)
4520         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4521         (parse_scrolling_args): Remove unnecessary cast.
4522         * tui/tui-data.c (init_win_info, tui_del_window)
4523         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4524         (free_content_elements): Remove unnecessary cast.
4525         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4526         unnecessary cast.
4527         * tui/tui-source.c (tui_set_source_content)
4528         (tui_vertical_source_scroll): Remove unnecessary cast.
4529         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4530         cast.
4531         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4532         * tui/tui-regs.c (tui_display_registers_from)
4533         (tui_display_register): Remove unnecessary cast.
4534         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4535         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4536         (make_visible): Remove unnecessary cast.
4537         * tui/tui-winsource.c (tui_erase_source_content)
4538         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4539         unnecessary cast.
4540         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4541         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4542         * stabsread.c (read_type, read_array_type, read_range_type):
4543         Remove unnecessary cast.
4544         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4545         (parse_symbol, parse_type, upgrade_type, parse_external)
4546         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4547         unnecessary cast.
4548         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4549
4550 2019-06-16  Tom Tromey  <tom@tromey.com>
4551
4552         * tui/tui-data.c (tui_alloc_generic_win_info)
4553         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4554         checks.
4555
4556 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4557             Andrew Burgess  <andrew.burgess@embecosm.com>
4558
4559         * f-typeprint.c (f_print_type): Don't return early for not
4560         associated or not allocated types.
4561         (f_type_print_varspec_suffix): Add print_rank parameter and print
4562         ranks of array types in case they dangling.
4563         (f_type_print_base): Add print_rank parameter.
4564
4565 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4566
4567         * NEWS: Mention new MI commands.
4568         * break-catch-throw.c (enum exception_event_kind): Move to
4569         breakpoint.h.
4570         (print_mention_exception_catchpoint): Output text as a single
4571         message.
4572         (catch_exception_command_1): Rename to...
4573         (catch_exception_event): ...this, make non-static, update header
4574         command, and change some parameter types.
4575         (catch_catch_command): Update for changes to
4576         catch_exception_command_1.
4577         (catch_throw_command): Likewise.
4578         (catch_rethrow_command): Likewise.
4579         * breakpoint.c (enum exception_event_kind): Delete.
4580         * breakpoint.h (enum exception_event_kind): Moved here from
4581         break-catch-throw.c.
4582         (catch_exception_event): Declare.
4583         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4584         (mi_cmd_catch_throw): New function.
4585         (mi_cmd_catch_rethrow): New function.
4586         (mi_cmd_catch_catch): New function.
4587         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4588         'catch-catch' entries.
4589         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4590         (mi_cmd_catch_rethrow): Declare.
4591         (mi_cmd_catch_catch): Declare.
4592
4593 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4594
4595         * annotate.c (annotate_source_line): Change return type to void,
4596         update implementation to match.
4597         * annotate.h (annotate_source_line): Change return type to void,
4598         update header comment.
4599         * stack.c (print_frame_info): Don't change what frame information
4600         is printed based on whether annotations are on or not.
4601
4602 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4603
4604         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4605         (annotate_source): Make static.
4606         (annotate_source_line): Moved from source.c and renamed from
4607         identify_source_line.  Update the return type.
4608         * annotate.h (annotate_source): Delete declaration.
4609         (annotate_source_line): Declaration moved from source.h, and
4610         renamed from identify_source_line.  Return type updated.
4611         * source.c (identify_source_line): Moved to annotate.c and renamed
4612         to annotate_source_line.
4613         (info_line_command): Remove check of annotation_level.
4614         * source.h (identify_source_line): Move declaration to annotate.h
4615         and rename to annotate_source_line.
4616         * stack.c: Add 'annotate.h' include.
4617         (print_frame_info): Remove check of annotation_level before
4618         calling annotate_source_line.
4619
4620 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4621
4622         * source-cache.c (source_cache::get_plain_source_lines): Use
4623         open_source_file_with_line_charpos instead of just
4624         open_source_file, remove call to find_source_lines.
4625         (source_cache::get_source_lines): Likewise.
4626         * source.c (find_source_lines): Make static.
4627         (get_filename_and_charpos): Renamed into...
4628         (open_source_file_with_line_charpos): ..this along with changes to
4629         return a scoped_fd, and some other minor clean ups.
4630         (identify_source_line): Use open_source_file_with_line_charpos.
4631         (search_command_helper): Use open_source_file_with_line_charpos
4632         instead of just open_source_file, remove call to
4633         find_source_lines.
4634         * source.h (open_source_file_with_line_charpos): Declare new
4635         function.
4636         (find_source_lines): Delete declaration.
4637
4638 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4639
4640         * source.c (get_filename_and_charpos): Remove fullname
4641         parameter.
4642         (identify_source_line): Update call to get_filename_and_charpos.
4643
4644 2019-06-14  Tom Tromey  <tromey@adacore.com>
4645
4646         PR gdb/24502:
4647         * ui-style.h (skip_ansi_escape): Update comment.
4648         * ui-file.h (class no_terminal_escape_file): New class.
4649         * ui-file.c (no_terminal_escape_file::write)
4650         (no_terminal_escape_file::puts): New methods.
4651         * cli/cli-logging.c (handle_redirections): Use
4652         no_terminal_escape_file.
4653
4654 2019-06-14  Tom Tromey  <tromey@adacore.com>
4655
4656         * NEWS: Move convenience variable news above Python news.
4657
4658 2019-06-14  Tom Tromey  <tom@tromey.com>
4659
4660         * gnulib: Move directory to top-level.
4661         * configure.ac: Don't configure gnulib.
4662         * configure: Rebuild.
4663         * common/common-defs.h: Use new path to gnulib.
4664         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4665         (GNULIB_H): Remove.
4666         (INCGNU): Look in new gnulib location.
4667         (HFILES_NO_SRCDIR): Remove gnulib files.
4668         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4669         (generated_files): Remove GNULIB_H.
4670         ($(LIBGNU), all-lib): Remove targets.
4671         (distclean): Don't mention GNULIB_BUILDDIR.
4672         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4673
4674 2019-06-14  Tom Tromey  <tromey@adacore.com>
4675
4676         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4677         Warn if symbol file does not provide any symbols.
4678
4679 2019-06-14  Tom Tromey  <tromey@adacore.com>
4680
4681         * source.c (find_and_open_source): Respect basenames_may_differ.
4682
4683 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4684
4685         * annotate.c (annotate_breakpoints_invalid): Make use of
4686         scoped_restore_terminal_state.
4687         (annotate_frames_invalid): Likewise.
4688
4689 2019-06-14  Tom Tromey  <tromey@adacore.com>
4690
4691         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4692         allow assignment to an internalvar.
4693
4694 2019-06-14  Tom Tromey  <tromey@adacore.com>
4695
4696         * ada-lex.l: Allow "_" in attribute names.
4697
4698 2019-06-14  Tom Tromey  <tromey@adacore.com>
4699
4700         PR gdb/24653:
4701         * regcache.c (registers_changed): Don't call alloca.
4702         * top.c (execute_command): Don't call alloca.
4703
4704 2019-06-13  Pedro Alves  <palves@redhat.com>
4705
4706         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4707         'expression'.  When parsing an expression, error out if there's
4708         junk after "unlimited".
4709         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4710         (do_set_command): Adjust calls to is_unlimited_literal.
4711
4712 2019-06-13  Pedro Alves  <palves@redhat.com>
4713
4714         * compile/compile.c (make_compile_options_def_group): Add braces
4715         around array_view initializer.
4716         * thread.c (make_thread_apply_all_options_def_group)
4717         (make_thread_apply_all_options_def_group): Likewise.
4718
4719 2019-06-13  Pedro Alves  <palves@redhat.com>
4720
4721         * NEWS (New commands): Mention "maint test-options
4722         require-delimiter", "maint test-options unknown-is-error", "maint
4723         test-options unknown-is-operand" and "maint show
4724         test-options-completion-result".
4725         (New command options, command completion): New section.
4726         (Completion improvements): New section.
4727         Mention that you can abbreviate "unlimited".
4728
4729 2019-06-13  Pedro Alves  <palves@redhat.com>
4730
4731         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4732         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4733         * unittests/cli-utils-selftests.c (test_parse_flags)
4734         (test_parse_flags_qcs): Delete.
4735         (test_cli_utils): Don't call deleted functions.
4736
4737 2019-06-13  Pedro Alves  <palves@redhat.com>
4738
4739         * thread.c: Include "cli/cli-option.h".
4740         (tp_array_compar_ascending): Global.
4741         (tp_array_compar): Delete function.
4742         (tp_array_compar_ascending, tp_array_compar_descending): New
4743         functions.
4744         (ascending_option_def, qcs_flag_option_def)
4745         (thr_qcs_flags_option_defs)
4746         (make_thread_apply_all_options_def_group)
4747         (make_thread_apply_options_def_group): New.
4748         (thread_apply_all_command): Use gdb::option::process_options.
4749         (thread_apply_command_completer)
4750         (thread_apply_all_command_completer): New.
4751         (thread_apply_command): Use gdb::option::process_options.
4752         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4753         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4754         to generate help text of "thread apply".  Adjust "taas"'s help.
4755         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4756         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4757
4758 2019-06-13  Pedro Alves  <palves@redhat.com>
4759
4760         * thread.c (thread_apply_command): Check for invalid TID with
4761         isdigit instead of !isalpha.
4762
4763 2019-06-13  Pedro Alves  <palves@redhat.com>
4764
4765         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4766         (validate_flags_qcs): New.
4767         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4768         (validate_flags_qcs): Declare.
4769         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4770         (make_frame_apply_options_def_group): New.
4771         (frame_apply_command_count): Process options with
4772         gdb::option::process_options.
4773         (frame_apply_completer): New.
4774         (frame_apply_level_completer, frame_apply_all_completer)
4775         (frame_apply_completer): New.
4776         (_initialize_stack): Update help of "frame apply", "frame apply
4777         level", "frame apply all" and "faas" to mention supported options
4778         and install command completers.
4779         * stack.h (frame_apply_all_completer): Declare.
4780         * thread.c: Include "stack.h".
4781         (tfaas_command): Add "--".
4782         (_initialize_thread): Update help "tfaas" to mention supported
4783         options and install command completer.
4784
4785 2019-06-13  Pedro Alves  <palves@redhat.com>
4786
4787         * completer.c (complete_nested_command_line): New.
4788         (gdb_completion_word_break_characters_throw): Add assertion.
4789         * completer.h (complete_nested_command_line): Declare.
4790
4791 2019-06-13  Pedro Alves  <palves@redhat.com>
4792
4793         * stack.c (parse_backtrace_qualifiers): New.
4794         (backtrace_command): Use it.
4795         (backtrace_command_completer): Complete on qualifiers.
4796
4797 2019-06-13  Pedro Alves  <palves@redhat.com>
4798
4799         * frame.c: Include "cli/cli-option.h.
4800         (user_set_backtrace_options): New.
4801         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4802         Delete.
4803         (get_prev_frame): Adjust.
4804         (boolean_option_def, uinteger_option_def)
4805         (set_backtrace_option_defs): New.
4806         (_initialize_frame): Adjust and use
4807         gdb::option::add_setshow_cmds_for_options to install "set
4808         backtrace past-main" and "set backtrace past-entry".
4809         * frame.h: Include "cli/cli-option.h".
4810         (struct frame_print_options): Forward declare.
4811         (print_frame_arguments_all, print_frame_arguments_scalars)
4812         (print_frame_arguments_none): Declare.
4813         (print_entry_values): Delete declaration.
4814         (struct frame_print_options, user_frame_print_options): New.
4815         (struct set_backtrace_options): New.
4816         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4817         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4818         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4819         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4820         (list_args_or_locals): Add frame_print_options parameter.
4821         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4822         * python/py-framefilter.c (enumerate_args): Pass down
4823         USER_FRAME_PRINT_OPTIONS.
4824         * stack.c: Include "cli/cli-option.h".
4825         (print_frame_arguments_all, print_frame_arguments_scalars)
4826         (print_frame_arguments_none): Declare.
4827         (print_raw_frame_arguments, print_entry_values): Delete.
4828         (user_frame_print_options): New.
4829         (boolean_option_def, enum_option_def, frame_print_option_defs):
4830         New.
4831         (struct backtrace_cmd_options): New.
4832         (bt_flag_option_def): New.
4833         (backtrace_command_option_defs): New.
4834         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4835         (print_frame_arg, read_frame_arg, print_frame_args)
4836         (print_frame_info, print_frame): Add frame_print_options parameter
4837         and use it.
4838         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4839         (backtrace_command_1): Add frame_print_options and
4840         backtrace_cmd_options parameters and use them.
4841         (make_backtrace_options_def_group): New.
4842         (backtrace_command): Process command options with
4843         gdb::option::process_options.
4844         (backtrace_command_completer): New.
4845         (_initialize_stack): Extend "backtrace"'s help to mention
4846         supported options.  Install completer for "backtrace".
4847         Install some settings commands with add_setshow_cmds_for_options.
4848
4849 2019-06-13  Pedro Alves  <palves@redhat.com>
4850
4851         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4852         and that "set/show print raw frame-arguments" are now deprecated.
4853
4854         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4855         command.
4856         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4857         * stack.c (_initialize_stack): Install "set/show print
4858         raw-frame-arguments", and deprecate "set/show print raw
4859         frame-arguments".
4860         * valprint.c (_initialize_valprint): Deprecate "set/show print
4861         raw".
4862
4863 2019-06-13  Pedro Alves  <palves@redhat.com>
4864
4865         * compile/compile.c (struct compile_options): New.
4866         (compile_flag_option_def, compile_command_option_defs)
4867         (make_compile_options_def_group): New.
4868         (compile_file_command): Handle options with
4869         gdb::option::process_options.
4870         (compile_file_command_completer): New function.
4871         (compile_code_command): Handle options with
4872         gdb::option::process_options.
4873         (compile_code_command_completer): New function.
4874         (_initialize_compiler): Install completers for "compile code" and
4875         "compile file".  Mention available options in "compile code" and
4876         "compile code"'s help.
4877         * completer.c (advance_to_completion_word): New, factored out from
4878         ...
4879         (advance_to_expression_complete_word_point): ... this.
4880         (advance_to_filename_complete_word_point): New.
4881         * completer.h (advance_to_filename_complete_word_point): New
4882         declaration.
4883
4884 2019-06-13  Pedro Alves  <palves@redhat.com>
4885
4886         * compile/compile.c: Include "cli/cli-option.h".
4887         (compile_print_value): Scope data pointer is now a
4888         value_print_options pointer; adjust.
4889         (compile_print_command): Process options.  Scope data pointer is
4890         now a value_print_options pointer; adjust.
4891         (_initialize_compile): Update "compile print"'s help to include
4892         supported options.  Install a completer for "compile print".
4893         * cp-valprint.c (show_vtblprint, show_objectprint)
4894         (show_static_field_print): Delete.
4895         (_initialize_cp_valprint): Don't install "set print
4896         static-members", "set print vtbl", "set print object" here.
4897         * printcmd.c: Include "cli/cli-option.h" and
4898         "common/gdb_optional.h".
4899         (print_command_parse_format): Rework to fill in a
4900         value_print_options instead of a format_data.
4901         (print_value): Change parameter type from format_data pointer to
4902         value_print_options reference.  Adjust.
4903         (print_command_1): Process options.  Adjust to pass down a
4904         value_print_options.
4905         (print_command_completer): New.
4906         (_initialize_printcmd): Install print_command_completer as
4907         handle_brkchars completer for the "print" command.  Update
4908         "print"'s help to include supported options.
4909         * valprint.c: Include "cli/cli-option.h".
4910         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4911         here from cp-valprint.c.
4912         (boolean_option_def, uinteger_option_def)
4913         (value_print_option_defs, make_value_print_options_def_group):
4914         New.  Use gdb::option::add_setshow_cmds_for_options to install
4915         "set print elements", "set print null-stop", "set print repeats",
4916         "set print pretty", "set print union", "set print array", "set
4917         print address", "set print symbol", "set print array-indexes".
4918         * valprint.h: Include <string> and "cli/cli-option.h".
4919         (make_value_print_options_def_group): Declare.
4920         (print_value): Change parameter type from format_data pointer to
4921         value_print_options reference.
4922         (print_command_completer): Declare.
4923
4924 2019-06-13  Pedro Alves  <palves@redhat.com>
4925
4926         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4927         (COMMON_SFILES): Add maint-test-settings.c.
4928         * cli/cli-decode.c (boolean_enums): New global, factored out from
4929         ...
4930         (add_setshow_boolean_cmd): ... here.
4931         * cli/cli-decode.h (boolean_enums): Declare.
4932         * cli/cli-option.c: New file.
4933         * cli/cli-option.h: New file.
4934         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4935         factored out from ...
4936         (parse_cli_boolean_value(const char *)): ... this.
4937         (is_unlimited_literal): Change parameter type to pointer to
4938         pointer.  Adjust and advance ARG pointer.
4939         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4940         (parse_cli_var_enum): New, factored out from ...
4941         (do_set_command): ... this.  Adjust.
4942         * cli/cli-setshow.h (parse_cli_boolean_value)
4943         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4944         (parse_cli_var_enum): Declare.
4945         * cli/cli-utils.c: Include "cli/cli-option.h".
4946         (get_ulongest): New.
4947         * cli/cli-utils.h (get_ulongest): Declare.
4948         (check_for_argument): New overloads.
4949         * maint-test-options.c: New file.
4950
4951 2019-06-13  Pedro Alves  <palves@redhat.com>
4952
4953         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4954         parse a range if "-" is at the end of the string.
4955
4956 2019-06-13  Pedro Alves  <palves@redhat.com>
4957
4958         * cli/cli-setshow.c (parse_auto_binary_operation)
4959         (parse_cli_boolean_value): Don't allow "o".
4960
4961 2019-06-13  Pedro Alves  <palves@redhat.com>
4962
4963         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4964         * NEWS: Mention maint test-settings KIND.
4965         * maint-test-settings.c: New file.
4966
4967 2019-06-13  Pedro Alves  <palves@redhat.com>
4968
4969         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4970         completer.
4971         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4972         "set" completers.
4973
4974 2019-06-13  Pedro Alves  <palves@redhat.com>
4975
4976         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4977         after item.
4978
4979 2019-06-13  Pedro Alves  <palves@redhat.com>
4980
4981         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4982
4983 2019-06-13  Pedro Alves <palves@redhat.com>
4984
4985         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4986         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4987         call.
4988         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4989         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4990         calls.
4991         (check_for_argument): Skip spaces after argument.
4992
4993 2019-06-13  Pedro Alves  <palves@redhat.com>
4994
4995         * thread.c (thread_apply_command): Adjust TID parsing.
4996         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4997         detected before end of string.
4998         (tid_is_in_list): Error out if LIST is invalid.
4999
5000 2019-06-13  Pedro Alves  <palves@redhat.com>
5001
5002         * completer.c (complete_line_internal_1): Rewind completion word
5003         point.
5004         (completion_tracker::advance_custom_word_point_by): Change
5005         parameter type to int.
5006         * completer.h (completion_tracker::advance_custom_word_point_by):
5007         Likewise.
5008
5009 2019-06-13  Pedro Alves  <palves@redhat.com>
5010
5011         * completer.c (advance_to_completion_word): Handle delimiters.
5012
5013 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5014
5015         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5016
5017 2019-06-11  Tom Tromey  <tom@tromey.com>
5018
5019         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5020         (xmalloc_failed): Move to alloc.c.
5021         * alloc.c: New file.
5022         * Makefile.in (COMMON_SFILES): Add alloc.c.
5023
5024 2019-06-11  Tom Tromey  <tom@tromey.com>
5025
5026         * nat/linux-waitpid.c: Don't include server.h.
5027         (linux_debug): Remove.
5028         (my_waitpid): Update.
5029
5030 2019-06-11  Tom Tromey  <tromey@adacore.com>
5031
5032         * infcall.c (_initialize_infcall): Remove trailing newline from
5033         help.
5034         * user-regs.c (_initialize_user_regs): Remove trailing newline
5035         from help.
5036         * typeprint.c (_initialize_typeprint): Remove trailing newline
5037         from help.
5038         * reverse.c (_initialize_reverse): Remove trailing newlines from
5039         help.
5040         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5041         from help.
5042         * language.c (add_set_language_command): Remove trailing newline
5043         from help.
5044         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5045         help.
5046         * disasm.c (_initialize_disasm): Remove trailing newline from
5047         help.
5048         * top.c (init_main): Remove trailing newline from help.
5049         * interps.c (_initialize_interpreter): Remove trailing newline
5050         from help.
5051         * btrace.c (_initialize_btrace): Remove trailing newlines from
5052         help.
5053         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5054         from help.
5055         * python/python.c (_initialize_python): Remove trailing newline
5056         from help.
5057         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5058         help.
5059         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5060         from help.  Reformat some text.
5061         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5062         from help.
5063         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5064         newline from help.
5065
5066 2019-06-11  Tom Tromey  <tromey@adacore.com>
5067
5068         * darwin-nat.c (darwin_decode_exception_message)
5069         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5070
5071 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5072
5073         * valops.c (value_slice): Check for not allocated or not
5074         associated values.
5075
5076 2019-06-10  Tom de Vries  <tdevries@suse.de>
5077
5078         PR gdb/24618
5079         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5080         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5081         invalid.
5082
5083 2019-06-10  Tom de Vries  <tdevries@suse.de>
5084
5085         PR gdb/24611
5086         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5087         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5088
5089 2019-06-10  Tom de Vries  <tdevries@suse.de>
5090
5091         PR symtab/24545
5092         * symtab.c (struct demangled_name_entry): Add language field.
5093         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5094         static minimal symbol".  Set and use language field.
5095
5096 2019-06-10  Tom Tromey  <tromey@adacore.com>
5097
5098         * ada-lang.c (_initialize_ada_language): Update help text.
5099
5100 2019-06-10  Tom Tromey  <tromey@adacore.com>
5101
5102         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5103         with a newline.
5104         * guile/guile.c (handle_boot_error): Don't end warning with a
5105         newline.
5106         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5107         warning with a newline.
5108         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5109         newline.
5110         (s12z_frame_cache): Likewise.
5111         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5112         a newline.
5113         * solib-svr4.c (disable_probes_interface): Don't end warning with
5114         a newline.
5115         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5116         newline.
5117         * python/python.c (do_finish_initialization): Don't end warning
5118         with a newline.
5119
5120 2019-06-10  Tom Tromey  <tom@tromey.com>
5121
5122         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5123         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5124         gdbpy_enter.
5125
5126 2019-06-10  Tom Tromey  <tromey@adacore.com>
5127
5128         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5129         data.
5130         (elf_new_init): Don't call stabsread_new_init.
5131         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5132         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5133         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5134
5135 2019-06-10  Tom de Vries  <tdevries@suse.de>
5136
5137         PR symtab/16264
5138         PR symtab/24517
5139         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5140
5141 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5142
5143         * source.c (find_and_open_source): Also rewrite relative file
5144         names.
5145
5146 2019-04-26  Amos Bird  <amosbird@gmail.com>
5147
5148         * annotate.c (annotate_thread_exited): Add "thread-exited"
5149         annotation.
5150
5151 2019-06-06  Tom Tromey  <tromey@adacore.com>
5152
5153         * maint.h (class scoped_command_stats): Use
5154         DISABLE_COPY_AND_ASSIGN.
5155         <print_time>: New method.
5156         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5157         print_time.
5158         (scoped_command_stats::print_time): New method.
5159
5160 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5161
5162         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5163         instructions of lengths 6 or 8 bytes.
5164
5165 2019-06-04  Pedro Alves  <palves@redhat.com>
5166
5167         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5168
5169         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5170         * breakpoint.c (condition_completer): Likewise.
5171         * cli/cli-dump.c (scan_expression): Likewise.
5172         * common/filestuff.c (mkdir_recursive): Likewise.
5173         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5174         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5175         (gdb_abspath): Likewise.
5176         * compile/compile-cplus-types.c
5177         (compile_cplus_instance::decl_name): Likewise.
5178         * completer.c (complete_explicit_location):
5179         (signal_completer, reg_or_group_completer_1): Likewise.
5180         * cp-support.c (cp_remove_params_if_any): Likewise.
5181         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5182         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5183         * infcmd.c (strip_bg_char): Likewise.
5184         * linespec.c (copy_token_string): Likewise.
5185         * mi/mi-main.c (output_cores): Likewise.
5186         * psymtab.c (psymtab_search_name):
5187         * symfile.c (test_set_ext_lang_command): Likewise.
5188         * target.c (target_fileio_read_stralloc): Likewise.
5189         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5190         * value.c (complete_internalvar): Likewise.
5191
5192 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5193
5194         Add objfile property to gdb.Type.
5195         * NEWS: Mention Python API addition.
5196         * python/py-type.c (typy_get_objfile): New method.
5197
5198 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5199
5200         * NEWS: Mention the new set|show style [title|highlight].
5201         Mention changes to "show style", "help" and "apropos".
5202
5203 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5204
5205         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5206         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5207         instead of print_help_for_command.
5208         (print_doc_of_command): New function.
5209         (help_list): Add 'apropos -v word' suggestion.
5210         (print_help_for_command): Style the command name using title style.
5211         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5212         (_initialize_cli_cmds): Describe -v in apropos_command help.
5213
5214 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5215
5216         * cli/cli-style.h (cli_style_option): Add name in constructor,
5217         add m_name class member, add constructor with intensity,
5218         add name class function.
5219         (cli_style_option::add_setshow_commands): Remove name argument.
5220         (highlight_style, title_style): New styles.
5221         * cli/cli-style.c (do_show): New function that shows a style
5222         characteristic styling the style name with itself.
5223         (set_style_name): New function.
5224         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5225         Update all callers according to the changes in cli/cli-style.h.
5226         * utils.h (fputs_highlighted): New function.
5227         * utils.c (fputs_highlighted): Likewise.
5228
5229 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5230
5231         * NEWS: Mention new pipe command and new convenience variables.
5232
5233 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5234
5235         * cli/cli-cmds.c (pipe_command): New function.
5236         (_initialize_cli_cmds): Call add_com for pipe_command.
5237         Define | as an alias for pipe.
5238         (exit_status_set_internal_vars): New function.
5239         (shell_escape): Call exit_status_set_internal_vars.
5240         cli/cli-decode.c (find_command_name_length): Recognize | as
5241         a single character command.
5242
5243 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5244
5245         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5246         top.c (execute_command_to_ui_file): New function, mostly a copy
5247         of execute_command_to_string.
5248         (execute_command_to_string): Implement by calling
5249         execute_command_to_ui_file.
5250
5251 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5252
5253         * top.h (saved_command_line): Remove declaration.
5254         * top.c (previous_saved_command_line, previous_repeat_arguments):
5255         New variables.
5256         (saved_command_line): Make static, define together with other
5257         'repeat variables'.
5258         (dont_repeat): Clear repeat_arguments.
5259         (repeat_previous, get_saved_command_line, save_command_line):
5260         New functions.
5261         (gdb_init): Initialize saved_command_line
5262         and previous_saved_command_line.
5263         * main.c (captured_main_1): Remove saved_command_line initialization.
5264         * event-top.c (handle_line_of_input): Update to use
5265         the new 'repeat' related functions instead of direct access to
5266         saved_command_line.
5267         * command.h (repeat_previous, get_saved_command_line,
5268         save_command_line): New declarations.
5269         (dont_repeat): Add comment.
5270
5271 2019-05-30  Tom Tromey  <tromey@adacore.com>
5272
5273         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5274         Fix comment.
5275         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5276
5277 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5278
5279         PR cli/24587
5280         * completer.c (complete): Initialize variable word.
5281
5282 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5283
5284         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5285         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5286         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5287         'body' is NULL to the outter 'if', protecting the '!is_define'
5288         situation as well.
5289
5290 2019-05-29  Tom Tromey  <tromey@adacore.com>
5291
5292         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5293         (dwarf_unknown): New function.
5294         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5295         (dwarf_type_encoding_name): Use dwarf_unknown.
5296
5297 2019-05-29  Tom Tromey  <tromey@adacore.com>
5298
5299         PR c++/20020:
5300         * cp-valprint.c (cp_print_value_fields): Call
5301         cp_print_static_field inside "try".
5302
5303 2019-05-29  Tom Tromey  <tromey@adacore.com>
5304
5305         * inflow.c (struct terminal_info): Add default operator=.
5306         * configure: Rebuild.
5307         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5308         -Wdeprecated-copy-dtor, -Wredundant-move.
5309
5310 2019-05-29  Tom Tromey  <tromey@adacore.com>
5311
5312         * NEWS: Add entry.
5313         * infcmd.c (print_return_value_1): Handle finish_print
5314         option.
5315         (show_print_finish): New function.
5316         (_initialize_infcmd): Add "set/show print finish" commands.
5317         * valprint.c (user_print_options): Initialize new member.
5318         * valprint.h (struct value_print_options) <finish_print>: New
5319         member.
5320
5321 2019-05-28  Tom Tromey  <tromey@adacore.com>
5322
5323         * ada-lang.c (ada_remove_Xbn_suffix)
5324         (find_old_style_renaming_symbol)
5325         (parse_old_style_renaming): Remove.
5326         (ada_find_renaming_symbol): Don't call
5327         find_old_style_renaming_symbol.
5328         (ada_is_renaming_symbol): Rename from
5329         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5330         bool.  Now static.
5331         (ada_read_var_value): Update and simplify.
5332         * ada-exp.y (write_var_or_type): Remove old code.
5333
5334 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5335
5336         * event-top.c: Remove include comment.
5337         * inflow.c (class scoped_ignore_sigttou): Move from here...
5338         * inflow.h (class scoped_ignore_sigttou): ...to here.
5339         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5340         * top.c:  Remove include comment.
5341
5342 2019-05-27  Tom Tromey  <tom@tromey.com>
5343
5344         * NEWS: Fix typo.
5345
5346 2019-05-22  Tom Tromey  <tromey@adacore.com>
5347
5348         * target.c (target_follow_exec): Constify parameter.
5349         * target-delegates.c: Rebuild.
5350         * remote.c (remote_target::follow_exec): Constify parameter.
5351         * infrun.c (follow_exec): Constify parameter.
5352         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5353         (target_follow_exec): Likewise.
5354
5355 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5356
5357         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5358         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5359
5360 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5361
5362         * NEWS: Add debugredirect and testsuite sections.
5363
5364 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5365
5366         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5367         target descriptions using exclusively floating point register name
5368         aliases.
5369
5370 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5371
5372         PR gdb/18644:
5373         * f-lang.c (build_fortran_types): Handle the case where
5374         gdbarch_floatformat_for_type returns a nullptr.
5375
5376 2019-05-21  Tom de Vries  <tdevries@suse.de>
5377
5378         PR cli/24587
5379         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5380
5381 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5382
5383         PR gdb/18644:
5384         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5385         16-byte floats.
5386         * i386-tdep.c (i386_floatformat_for_type): Use
5387         floatformats_ia64_quad for the 16-byte floating point component
5388         within a fortran 32-byte complex number.
5389
5390 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5391
5392         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5393         delete default constructor.
5394         (find_partial_die): Update to return const struct.
5395         (partial_die_parent_scope): Move variable declaration into scope
5396         of its use and change its type to auto.
5397         (guess_partial_die_structure_name): Likewise.
5398         (partial_die_info::fixup): Likewise.
5399
5400 2019-05-17  Tom Tromey  <tromey@adacore.com>
5401
5402         * source.c (find_and_open_source): Remove cast.
5403
5404 2019-05-17  Tom Tromey  <tromey@adacore.com>
5405
5406         * annotate.c (annotate_source): Make "filename" const.
5407         * annotate.h (annotate_source): Use const.
5408
5409 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5410
5411         * disasm.c (set_disassembler_options): Send errors to stderr.
5412
5413 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5414
5415         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5416         (cli_interp_base::set_logging): Check debug_redirect.
5417         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5418         * cli/cli-logging.c (debug_redirect): Add static variable.
5419         (pop_output_files): Add default param.
5420         (handle_redirections): Print debug setting.
5421         (show_logging_command): Likewise.
5422         (_initialize_cli_logging): Add debugredirect command.
5423         * interps.c (current_interp_set_logging): Add debug_redirect
5424         parameter.
5425         * interps.h (set_logging): Add debug_redirect parameter.
5426         (current_interp_set_logging): Likewise.
5427         * mi/mi-common.h: Likewise.
5428         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5429
5430 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5431             Tom Tromey  <tromey@adacore.com>
5432
5433         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5434         directly.
5435         * cli/cli-interp.h (make_logging_output): Remove declaration.
5436         * cli/cli-logging.c (make_logging_output): Remove function.
5437         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5438         directly.
5439         * ui-file.c (tee_file::tee_file): Remove bools.
5440         (tee_file::~tee_file): Remove deletes.
5441         * ui-file.h (tee_file): Remove bools.
5442
5443 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5444
5445         * mi/mi-cmds.h (mi_cmd_complete): New function.
5446         * mi/mi-main.c (mi_cmd_complete): Likewise.
5447         * mi/mi-cmds.c: Define new MI command -complete.
5448         * NEWS: Mention new -complete command.
5449
5450 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5451
5452         * completer.h (complete): New function.
5453         * completer.c (complete): Likewise.
5454         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5455         function defined in completer.h.
5456
5457 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5458
5459         * MAINTAINERS (Write After Approval): Add myself.
5460
5461 2019-05-17  Tom de Vries  <tdevries@suse.de>
5462
5463         PR gdb/24094
5464         * dwarf2read.c (struct cu_partial_die_info): New struct.
5465         (find_partial_die): Return cu_partial_die_info.
5466         (partial_die_parent_scope, guess_partial_die_structure_name)
5467         (partial_die_info::fixup): Handle new return type of find_partial_die.
5468
5469 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5470
5471         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5472         "std::string", simplifying the algorithm.
5473
5474 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5475
5476         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5477         (stap_static_probe_ops::get_probes): Likewise.
5478
5479 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5480
5481         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5482         '-')" and "else if".
5483         (stap_parse_single_operand): Join checks for
5484         "gdbarch_stap_parse_special_token_p" and
5485         "gdbarch_stap_parse_special_token" in the same "if" statement.
5486         Invert check when verifying for operation on register
5487         displacement.
5488
5489 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5490
5491         * stap-probe.c (stap_get_opcode): Update comment.
5492         (stap_get_expected_argument_type): Likewise.
5493         (handle_stap_probe): Likewise.
5494
5495 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5496
5497         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5498         return type to 'bool'.  Adjust comment.  Use 'bool' when
5499         appropriate.
5500         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5501         * stap-probe.c (stap_parse_argument_1): Likewise.
5502         (stap_is_operator): Likewise.
5503         (stap_is_generic_prefix): Likewise.
5504         (stap_is_register_prefix): Likewise.
5505         (stap_is_register_indirection_prefix): Likewise.
5506         (stap_is_integer_prefix): Likewise.
5507         (stap_generic_check_suffix): Likewise.
5508         (stap_check_integer_suffix): Likewise.
5509         (stap_check_register_suffix): Likewise.
5510         (stap_check_register_indirection_suffix): Likewise.
5511         (stap_parse_register_operand): Likewise.
5512         (stap_parse_single_operand): Likewise.
5513         (stap_parse_argument_1): Likewise.
5514         (stap_probe::get_argument_count): Likewise.
5515         (stap_is_operator): Likewise.
5516
5517 2019-05-16  Tom Tromey  <tromey@adacore.com>
5518
5519         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5520         keyword to foreach.
5521
5522 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5523
5524         * linux-thread-db.c (try_thread_db_load_1): Change return type
5525         to bool.
5526         (try_thread_db_load): Likewise.
5527         (try_thread_db_load_from_pdir_1): Likewise.
5528         (try_thread_db_load_from_pdir): Likewise.
5529         (try_thread_db_load_from_sdir): Likewise.
5530         (try_thread_db_load_from_dir): Likewise.
5531         (thread_db_load_search): Likewise.
5532         (has_libpthread): Likewise.
5533         (thread_db_load): Likewise.
5534
5535 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5536
5537         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5538         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5539         NULL, and complain/return if that's the case.
5540
5541 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5542
5543         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5544         (advance, posn, abstract_read_memory): New functions.
5545         [struct mem_read_abstraction]: New struct.
5546         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5547
5548 2019-05-14  Tom Tromey  <tromey@adacore.com>
5549
5550         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5551         value is not lval_memory.
5552
5553 2019-05-14  Tom Tromey  <tromey@adacore.com>
5554
5555         * solib.c (info_sharedlibrary_command): Style the file name.
5556
5557 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5558
5559         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5560         (aarch64_vnv_type): Likewise.
5561         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5562         * common/tdesc.c: Likewise.
5563         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5564         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5565         * features/aarch64-fpu.xml: Add ieee half view.
5566         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5567         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5568         * gdbtypes.h (struct builtin_type): Likewise.
5569         (struct objfile_type): Likewise.
5570
5571 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5572
5573         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5574         typo.
5575         * location.h (string_to_event_location): Likewise.
5576
5577 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5578
5579         GDB 8.3 released.
5580
5581 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5582
5583         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5584         New variable declaration.
5585         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5586         New variable.
5587         (print_one_breakpoint): Use ui_out::test_flags and new global
5588         variable to compute use_fixed_output.
5589         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5590         Remove.
5591         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5592         (mi_multi_location_breakpoint_output_fixed): Remove.
5593         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5594         new variable.
5595         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5596         fix_multi_location_breakpoint_output flag if version >= 3.
5597         * ui-out.h (enum ui_out_flag)
5598         <fix_multi_location_breakpoint_output>: New enumerator.
5599
5600 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5601
5602         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5603
5604 2019-05-10  Tom Tromey  <tromey@adacore.com>
5605
5606         * ada-lang.c (catch_ada_completer): New function.
5607         (_initialize_ada_language): Use it.
5608
5609 2019-05-10  Tom Tromey  <tromey@adacore.com>
5610
5611         * thread.c (print_thread_info): Make "requested_threads" const.
5612         * gdbthread.h (print_thread_info): Make "requested_threads"
5613         const.
5614         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5615         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5616
5617 2019-05-08  Tom Tromey  <tom@tromey.com>
5618
5619         * gdbtypes.c (objfile_type_data): Change type.
5620         (objfile_type, _initialize_gdbtypes): Update.
5621
5622 2019-05-08  Tom Tromey  <tom@tromey.com>
5623
5624         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5625         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5626         (_initialize_dwarf2_frame): Update.
5627
5628 2019-05-08  Tom Tromey  <tom@tromey.com>
5629
5630         * objc-lang.c (objc_objfile_data): Change type.
5631         (find_methods): Update.
5632         (_initialize_objc_lang): Remove.
5633
5634 2019-05-08  Tom Tromey  <tom@tromey.com>
5635
5636         * stabsread.c (rs6000_builtin_type_data): Change type.
5637         (rs6000_builtin_type, _initialize_stabsread): Update.
5638
5639 2019-05-08  Tom Tromey  <tom@tromey.com>
5640
5641         * mips-tdep.c (mips_pdr_data): Remove.
5642         (_initialize_mips_tdep): Update.
5643
5644 2019-05-08  Tom Tromey  <tom@tromey.com>
5645
5646         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5647         (hppa_init_objfile_priv_data, read_unwind_info)
5648         (find_unwind_entry, _initialize_hppa_tdep): Update.
5649
5650 2019-05-08  Tom Tromey  <tom@tromey.com>
5651
5652         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5653         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5654         on obstack.
5655         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5656
5657 2019-05-08  Tom Tromey  <tom@tromey.com>
5658
5659         * mdebugread.c (basic_type_data): Change type.
5660         (basic_type, _initialize_mdebugread): Update.
5661
5662 2019-05-08  Tom Tromey  <tom@tromey.com>
5663
5664         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5665
5666 2019-05-08  Tom Tromey  <tom@tromey.com>
5667
5668         * nto-tdep.c (nto_inferior_data_reg): Change type.
5669         (nto_inferior_data): Update.
5670         (nto_inferior_data_cleanup, nto_new_inferior_data)
5671         (_initialize_nto_tdep): Remove.
5672         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5673
5674 2019-05-08  Tom Tromey  <tom@tromey.com>
5675
5676         * ada-lang.c (struct ada_inferior_data): Add initializers.
5677         (ada_inferior_data): Change type.
5678         (ada_inferior_data_cleanup): Remove.
5679         (get_ada_inferior_data, ada_inferior_exit)
5680         (struct ada_pspace_data): Add initializers, destructor.
5681         (ada_pspace_data_handle): Change type.
5682         (get_ada_pspace_data): Update.
5683         (ada_pspace_data_cleanup): Remove.
5684
5685 2019-05-08  Tom Tromey  <tom@tromey.com>
5686
5687         * coffread.c (struct coff_symfile_info): Add initializers.
5688         (coff_objfile_data_key): Move lower.  Change type.
5689         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5690         Update.
5691         (coff_free_info): Remove.
5692
5693 2019-05-08  Tom Tromey  <tom@tromey.com>
5694
5695         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5696         (fbsd_pspace_data_handle): Move lower.  Change type.
5697         (get_fbsd_pspace_data): Update.
5698         (fbsd_pspace_data_cleanup): Remove.
5699         (_initialize_fbsd_tdep): Update.
5700
5701 2019-05-08  Tom Tromey  <tom@tromey.com>
5702
5703         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5704         (get_ada_tasks_pspace_data): Update.
5705         (ada_tasks_pspace_data_cleanup): Remove.
5706         (_initialize_tasks): Update.
5707         (ada_tasks_inferior_data_handle): Change type.
5708         (get_ada_tasks_inferior_data): Update.
5709         (ada_tasks_inferior_data_cleanup): Remove.
5710         (struct ada_tasks_pspace_data): Add initializers.
5711
5712 2019-05-08  Tom Tromey  <tom@tromey.com>
5713
5714         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5715         * symfile-debug.c (debug_sym_get_probes): Change type.
5716         * stap-probe.c (handle_stap_probe):
5717         (stap_static_probe_ops::get_probes): Change type.
5718         * probe.h (class static_probe_ops) <get_probes>: Change type.
5719         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5720         (parse_probes_in_pspace): Update.
5721         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5722         Update.
5723         (any_static_probe_ops::get_probes): Change type.
5724         * elfread.c (elfread_data): New typedef.
5725         (probe_key): Change type.
5726         (elf_get_probes): Likewise.  Update.
5727         (probe_key_free): Remove.
5728         (_initialize_elfread): Update.
5729         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5730         Change type.
5731         (dtrace_process_dof_probe, dtrace_process_dof)
5732         (dtrace_static_probe_ops::get_probe): Change type.
5733
5734 2019-05-08  Tom Tromey  <tom@tromey.com>
5735
5736         * xcoffread.c (struct xcoff_symfile_info): Rename from
5737         coff_symfile_info.  Add initializers.
5738         (xcoff_objfile_data_key): Move lower.  Change type.
5739         (XCOFF_DATA): Rewrite.
5740         (xcoff_free_info): Remove.
5741         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5742         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5743         (xcoff_initial_scan): Update.
5744
5745 2019-05-08  Tom Tromey  <tom@tromey.com>
5746
5747         * solib-svr4.c (struct svr4_info): Add initializers and
5748         destructor.
5749         <probes_table>: Now an htab_up.
5750         (solib_svr4_pspace_data): Change type.
5751         (free_probes_table): Simplify.
5752         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5753         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5754         (probes_table_remove_objfile_probes, register_solib_event_probe)
5755         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5756         (_initialize_svr4_solib): Update.
5757
5758 2019-05-08  Tom Tromey  <tom@tromey.com>
5759
5760         * remote.c (remote_pspace_data): Change type.
5761         (remote_pspace_data_cleanup): Remove.
5762         (get_remote_exec_file, set_pspace_remote_exec_file)
5763         (_initialize_remote): Update.
5764
5765 2019-05-08  Tom Tromey  <tom@tromey.com>
5766
5767         * breakpoint.c (breakpoint_objfile_key): Change type.
5768         (get_breakpoint_objfile_data): Update.
5769         (free_breakpoint_objfile_data): Remove.
5770         (_initialize_breakpoint): Update.
5771
5772 2019-05-08  Tom Tromey  <tom@tromey.com>
5773
5774         * linux-tdep.c (struct linux_info): Add initializers.
5775         (linux_inferior_data): Move.  Change type.
5776         (invalidate_linux_cache_inf): Update.
5777         (linux_inferior_data_cleanup): Remove.
5778         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5779
5780 2019-05-08  Tom Tromey  <tom@tromey.com>
5781
5782         * auxv.c (auxv_inferior_data): Move.  Change type.
5783         (auxv_inferior_data_cleanup): Remove.
5784         (invalidate_auxv_cache_inf): Rewrite.
5785         (get_auxv_inferior_data, _initialize_auxv): Update.
5786
5787 2019-05-08  Tom Tromey  <tom@tromey.com>
5788
5789         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5790         (symfile_debug_objfile_data_key): Change type.
5791         (symfile_debug_installed, debug_qf_has_symbols)
5792         (debug_qf_find_last_source_symtab)
5793         (debug_qf_forget_cached_source_info)
5794         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5795         (debug_qf_print_stats, debug_qf_dump)
5796         (debug_qf_expand_symtabs_for_function)
5797         (debug_qf_expand_all_symtabs)
5798         (debug_qf_expand_symtabs_with_fullname)
5799         (debug_qf_map_matching_symbols)
5800         (debug_qf_expand_symtabs_matching)
5801         (debug_qf_find_pc_sect_compunit_symtab)
5802         (debug_qf_map_symbol_filenames)
5803         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5804         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5805         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5806         (debug_sym_read_linetable, debug_sym_relocate): Update.
5807         (symfile_debug_free_objfile): Remove.
5808         (install_symfile_debug_logging, _initialize_symfile_debug):
5809         Update.
5810
5811 2019-05-08  Tom Tromey  <tom@tromey.com>
5812
5813         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5814         allocate_on_obstack.
5815         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5816         (get_dwarf2_per_objfile): Update.
5817         (set_dwarf2_per_objfile): Remove.
5818         (dwarf2_has_info, dwarf2_get_section_info): Update.
5819         (dwarf2_free_objfile): Remove.
5820         (_initialize_dwarf2_read): Update.
5821
5822 2019-05-08  Tom Tromey  <tom@tromey.com>
5823
5824         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5825         initializers.
5826         <unsupported_script_warning_printed,
5827         script_not_found_warning_printed>: Now bool.
5828         (auto_load_pspace_data): Change type.
5829         (~auto_load_pspace_info): Rename from
5830         auto_load_pspace_data_cleanup.
5831         (get_auto_load_pspace_data, init_loaded_scripts_info)
5832         (clear_section_scripts, maybe_print_unsupported_script_warning)
5833         (maybe_print_script_not_found_warning, _initialize_auto_load):
5834         Update.
5835
5836 2019-05-08  Tom Tromey  <tom@tromey.com>
5837
5838         * objfiles.c (objfile_pspace_info): Add destructor and
5839         initializers.
5840         (objfiles_pspace_data): Change type.
5841         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5842         (get_objfile_pspace_data): Update.
5843         (objfiles_bfd_data): Change type.
5844         (get_objfile_bfd_data): Update.
5845         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5846
5847 2019-05-08  Tom Tromey  <tom@tromey.com>
5848
5849         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5850         Change type.
5851         (get_catch_syscall_inferior_data): Update.
5852         (catch_syscall_inferior_data_cleanup): Remove.
5853         (_initialize_break_catch_syscall): Update.
5854
5855 2019-05-08  Tom Tromey  <tom@tromey.com>
5856
5857         * inflow.c (struct terminal_info): Add destructor and
5858         initializers.
5859         (inflow_inferior_data): Change type.
5860         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5861         (get_inflow_inferior_data, inflow_inferior_exit)
5862         (swap_terminal_info, _initialize_inflow): Update.
5863
5864 2019-05-08  Tom Tromey  <tom@tromey.com>
5865
5866         * target-dcache.c (target_dcache_cleanup): Remove.
5867         (target_dcache_aspace_key): Change type.
5868         (target_dcache_init_p, target_dcache_invalidate)
5869         (target_dcache_get, target_dcache_get_or_init)
5870         (_initialize_target_dcache): Update.
5871         * dcache.h (struct dcache_deleter): New.
5872
5873 2019-05-08  Tom Tromey  <tom@tromey.com>
5874
5875         * symtab.c (struct symbol_cache): Add destructor and
5876         initializers.
5877         (symbol_cache_key): Move.  Change type.
5878         (make_symbol_cache, free_symbol_cache): Remove.
5879         (get_symbol_cache): Update.
5880         (symbol_cache_cleanup): Remove.
5881         (ALL_PSPACES, symbol_cache_flush)
5882         (maintenance_print_symbol_cache)
5883         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5884         Update.
5885
5886 2019-05-08  Tom Tromey  <tom@tromey.com>
5887
5888         * symtab.c (struct main_info): Add destructor and initializers.
5889         (main_progspace_key): Move.  Change type.
5890         (get_main_info): Update.
5891         (main_info_cleanup): Remove.
5892         (_initialize_symtab): Update.
5893
5894 2019-05-08  Tom Tromey  <tom@tromey.com>
5895
5896         * registry.h (DECLARE_REGISTRY): Define the _key class.
5897
5898 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5899
5900         * NEWS: Merge two 'New commands' sections.
5901
5902 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5903
5904         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5905         parameter and use Ada language definition instead.
5906         (ada_val_print_ptr): Remove unused language parameter.
5907         (ada_val_print_num): Remove language parameter and use Ada language
5908         definition instead.
5909         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5910         parameter.
5911         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5912         parameter and use Ada language definition instead.
5913         (ada_val_print_1): Update all ada_val_print_xxx calls.
5914         Remove language parameter.
5915         (ada_val_print): Update ada_val_print_1 call.
5916
5917 2019-05-08  Tom Tromey  <tromey@adacore.com>
5918
5919         * remote.c (remote_hw_watchpoint_limit)
5920         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5921         Now static.
5922
5923 2019-05-08  Tom Tromey  <tromey@adacore.com>
5924
5925         * maint.c (_initialize_maint_cmds): Move initialization code to
5926         remote.c.
5927         (watchdog, show_watchdog): Move to remote.c.
5928         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5929         "watchdog" static.
5930         (_initialize_remote): Move initialization code from maint.c.
5931         * defs.h (watchdog): Don't declare.
5932
5933 2019-05-08  Tom Tromey  <tromey@adacore.com>
5934
5935         * tui/tui-interp.c: Include main.h.
5936         * interps.c: Include main.h.
5937         * main.h (interpreter_p): Declare.
5938         * defs.h (interpreter_p): Don't declare.
5939
5940 2019-05-08  Tom Tromey  <tromey@adacore.com>
5941
5942         * dwarf2loc.c: Include dwarf2read.h.
5943         * defs.h (read_unsigned_leb128): Don't declare.
5944         * dwarf2read.h (read_unsigned_leb128): Declare.
5945
5946 2019-05-08  Tom Tromey  <tromey@adacore.com>
5947
5948         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5949         method.
5950
5951 2019-05-08  Tom Tromey  <tromey@adacore.com>
5952
5953         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5954         when no wrap column is set.
5955
5956 2019-05-08  Tom Tromey  <tromey@adacore.com>
5957
5958         * c-lang.c (c_get_string): Handle non-C-style arrays.
5959
5960 2019-05-08  Tom Tromey  <tromey@adacore.com>
5961
5962         * typeprint.c (print_offset_data::update): Print the bit offset,
5963         not the number of bits remaining.
5964
5965 2019-05-08  Tom Tromey  <tromey@adacore.com>
5966
5967         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5968         padding at end of comment.
5969
5970 2019-05-08  Tom Tromey  <tromey@adacore.com>
5971
5972         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5973         Compare main types.
5974
5975 2019-05-06  Tom Tromey  <tom@tromey.com>
5976
5977         * common/scoped_mmap.c: Include common-defs.h.
5978         * common/scoped_mmap.h: Don't include config.h.
5979
5980 2019-05-04  Tom Tromey  <tom@tromey.com>
5981
5982         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5983         (struct aarch64_call_info): Add initializers.
5984         <si>: Now a std::vector.
5985         (pass_on_stack, aarch64_push_dummy_call): Update.
5986
5987 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5988             Tom Tromey  <tom@tromey.com>
5989
5990         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5991         (ppc_threads): Now a std::vector.  Now static.
5992         (hwdebug_find_thread_points_by_tid)
5993         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5994         Update.
5995
5996 2019-05-04  Tom Tromey  <tom@tromey.com>
5997
5998         * arc-tdep.c (arc_tdesc_init): Return bool.
5999
6000 2019-05-04  Tom Tromey  <tom@tromey.com>
6001
6002         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6003         Use gdb_assert_not_reached.
6004
6005 2019-05-04  Tom Tromey  <tom@tromey.com>
6006
6007         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6008         "false".
6009
6010 2019-05-04  Tom Tromey  <tom@tromey.com>
6011
6012         * arc-tdep.c (arc_tdesc_init): Use bool.
6013
6014 2019-05-04  Tom Tromey  <tom@tromey.com>
6015
6016         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6017
6018 2019-05-04  Tom Tromey  <tom@tromey.com>
6019
6020         * cli/cli-cmds.c (valid_command_p): Return bool.
6021
6022 2019-05-04  Tom Tromey  <tom@tromey.com>
6023
6024         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6025         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6026
6027 2019-05-04  Raul Tambre  <raul@tambre.ee>
6028
6029         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6030         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6031         operator for comparison.
6032
6033 2019-05-04  Tom Tromey  <tom@tromey.com>
6034
6035         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6036         (lookup_partial_symbol, print_partial_symbols)
6037         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6038         (psymbol_compare): Update.
6039         (add_psymbol_to_bcache): Clear the entire psymbol.
6040         (maintenance_check_psymtabs): Update.
6041         * psympriv.h (struct partial_symbol): Don't derive from
6042         general_symbol_info.
6043         <obj_section, unrelocated_address, address,
6044         set_unrelocated_address>: Update.
6045         <ginfo>: New member.
6046         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6047         (debug_names::write_psymbols): Update.
6048
6049 2019-05-04  Tom de Vries  <tdevries@suse.de>
6050
6051         * contrib/cc-with-tweaks.sh: Support -n arg.
6052
6053 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6054
6055         * corelow.c (core_target::detach): Ensure frame cache and
6056         register caches are cleared.
6057         inferior.c (exit_inferior_1): Likewise.
6058
6059 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6060             Tom Tromey  <tom@tromey.com>
6061
6062         * dictionary.c (collate_pending_symbols_by_language): Remove
6063         "struct" from foreach.
6064         * symtab.c (lookup_global_symbol_from_objfile)
6065         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6066         foreach.
6067         * ser-tcp.c (net_open): Remove "struct" from foreach.
6068         * objfiles.c (objfile_relocate, objfile_rebase)
6069         (objfile_has_symbols): Remove "struct" from foreach.
6070         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6071         from foreach.
6072         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6073         foreach.
6074         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6075         "struct" from foreach.
6076         * ada-lang.c (create_excep_cond_exprs)
6077         (ada_exception_catchpoint_cond_string): Remove "struct" from
6078         foreach.
6079
6080 2019-05-03  Tom Tromey  <tromey@adacore.com>
6081
6082         * ada-exp.y (convert_char_literal): Check suffix of each
6083         enumerator.
6084
6085 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6086
6087         PR ada/21406:
6088         * ada-exp.y (yywrap): Don't define.
6089         * ada-lex.l (%option): Add noyywrap
6090         (yywrap): Remove.
6091
6092 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6093
6094         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6095         _WIN32_WINNT to the XP level, unless already defined to a higher
6096         level.
6097
6098         * unittests/parse-connection-spec-selftests.c:
6099         * ser-tcp.c:
6100         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6101         override.
6102
6103         * symfile.c (find_separate_debug_file): Remove colon from the
6104         drive spec of DOS/Windows file names of the target, so that the
6105         file name produced from DEBUGDIR and the target's directory will
6106         be valid on DOS/Windows systems.
6107
6108 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6109
6110         * rust-lang.c (val_print_struct): Handle printing structures
6111         containing strings.
6112
6113 2019-05-02  Tom Tromey  <tromey@adacore.com>
6114
6115         * valarith.c (_initialize_valarith): Remove.
6116
6117 2019-05-01  Tom Tromey  <tromey@adacore.com>
6118
6119         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6120         bitfields.
6121
6122 2019-05-01  Tom Tromey  <tromey@adacore.com>
6123
6124         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6125         for big-endian copies.
6126
6127 2019-04-30  Ali Tamur  <tamur@google.com>
6128         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6129         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6130         (read_3_bytes): New function.
6131
6132 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6133
6134         * windows-nat.c (main_thread_id): Delete.
6135         (handle_output_debug_string): Replace main_thread_id by
6136         current_event.dwThreadId.
6137         (fake_create_process): Likewise.
6138         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6139         Do not set main_thread_id.
6140         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6141         current_event.dwThreadId.
6142         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6143
6144 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6145
6146         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6147         Use current_event.dwThreadId instead of main_thread_id.
6148
6149 2019-04-30  Tom Tromey  <tromey@adacore.com>
6150
6151         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6152         (create_excep_cond_exprs): Iterate over program spaces.
6153         (ada_exception_catchpoint_cond_string): Examine all minimal
6154         symbols for exception types.
6155
6156 2019-04-30  Tom Tromey  <tromey@adacore.com>
6157
6158         PR c++/24470:
6159         * dwarf2read.c (process_structure_scope): Handle case where type
6160         has template parameters but no symbol was created.
6161
6162 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6163             Chris January  <chris.january@arm.com>
6164
6165         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6166         qualifier.
6167         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6168
6169 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6170
6171         * f-typeprint.c (f_print_type): Update rules for printing
6172         whitespace.
6173         (f_type_print_varspec_suffix): Likewise.
6174
6175 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6176             Chris January  <chris.january@arm.com>
6177
6178         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6179         function arguments.
6180
6181 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6182
6183         * f-lang.c (build_fortran_types): Change name of void type to
6184         lower case.
6185         * f-typeprint.c (f_type_print_base): Print the name of the void
6186         type, rather than a fixed string.
6187         * f-valprint.c (f_decorations): Use lower case void string.
6188
6189 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6190             Chris January  <chris.january@arm.com>
6191
6192         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6193         types for Fortran.
6194
6195 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6196             Chris January  <chris.january@arm.com>
6197             David Lecomber  <david.lecomber@arm.com>
6198
6199         * f-exp.y (BINOP_INTRINSIC): New token.
6200         (exp): New parser rule handling BINOP_INTRINSIC.
6201         (f77_keywords): Add new builtin procedures.
6202         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6203         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6204         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6205         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6206         (print_unop_subexp_f): New function.
6207         (print_binop_subexp_f): New function.
6208         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6209         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6210         (dump_subexp_body_f): Likewise.
6211         (operator_check_f): Likewise.
6212         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6213         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6214
6215 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6216
6217         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6218         UNOP_KIND.
6219         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6220         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6221         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6222         (operator_length_f): New fuction.
6223         (print_subexp_f): New function.
6224         (op_name_f): New function.
6225         (dump_subexp_body_f): New function.
6226         (operator_check_f): New function.
6227         (exp_descriptor_f): Replace standard expression handling functions
6228         with new functions.
6229         * gdb/fortran-operator.def: New file.
6230         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6231         * gdb/std-operator.def: Remove UNOP_KIND.
6232
6233 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6234
6235         * std-operator.def: Remove unbalanced, stray double quote
6236         character.
6237
6238 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6239             Chris January  <chris.january@arm.com>
6240             Daniel Everett  <daniel.everett@arm.com>
6241             Nick Forrington  <nick.forrington@arm.com>
6242             Richard Bunt  <richard.bunt@arm.com>
6243
6244         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6245         of depth when printing anonymous structs or unions.
6246         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6247         Don't print either the top-level value, or the children if the
6248         max-depth is exceeded.
6249         (ppscm_print_children): When printing the key of a map, allow one
6250         extra level of depth.
6251         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6252         print either the top-level value, or the children if the max-depth
6253         is exceeded.
6254         (print_children): When printing the key of a map, allow one extra
6255         level of depth.
6256         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6257         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6258         (user_print_options): Initialise max_depth field.
6259         (val_print_scalar_or_string_type_p): New function.
6260         (val_print): Check to see if the max depth has been reached.
6261         (val_print_check_max_depth): Define new function.
6262         (show_print_max_depth): New function.
6263         (_initialize_valprint): Add 'print max-depth' option.
6264         * valprint.h (struct value_print_options) <max_depth>: New field.
6265         (val_print_check_max_depth): Declare new function.
6266         * NEWS: Document new feature.
6267
6268 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6269
6270         * ada-lang.c (ada_language_defn): Initialise new field.
6271         * c-lang.c (c_is_string_type_p): New function.
6272         (c_language_defn): Initialise new field.
6273         (cplus_language_defn): Initialise new field.
6274         (asm_language_defn): Initialise new field.
6275         (minimal_language_defn): Initialise new field.
6276         * c-lang.h (c_is_string_type_p): Declare new function.
6277         * d-lang.c (d_language_defn): Initialise new field.
6278         * f-lang.c (f_is_string_type_p): New function.
6279         (f_language_defn): Initialise new field.
6280         * go-lang.c (go_is_string_type_p): New function.
6281         (go_language_defn): Initialise new field.
6282         * language.c (default_is_string_type_p): New function.
6283         (unknown_language_defn): Initialise new field.
6284         (auto_language_defn): Initialise new field.
6285         * language.h (struct language_defn) <la_is_string_type_p>: New
6286         member variable.
6287         (default_is_string_type_p): Declare new function.
6288         * m2-lang.c (m2_language_defn): Initialise new field.
6289         * objc-lang.c (objc_language_defn): Initialise new field.
6290         * opencl-lang.c (opencl_language_defn): Initialise new field.
6291         * p-lang.c (pascal_is_string_type_p): New function.
6292         (pascal_language_defn): Initialise new field.
6293         * rust-lang.c (rust_is_string_type_p): New function.
6294         (rust_language_defn): Initialise new field.
6295
6296 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6297
6298         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6299         New field.
6300         * ada-lang.c (ada_language_defn): Initialise new field.
6301         * c-lang.c (c_language_defn): Likewise.
6302         (cplus_language_defn): Likewise.
6303         (asm_language_defn): Likewise.
6304         (minimal_language_defn): Likewise.
6305         * d-lang.c (d_language_defn): Likewise.
6306         * f-lang.c (f_language_defn): Likewise.
6307         * go-lang.c (go_language_defn): Likewise.
6308         * language.c (unknown_language_defn): Likewise.
6309         (auto_language_defn): Likewise.
6310         * m2-lang.c (m2_language_defn): Likewise.
6311         * objc-lang.c (objc_language_defn): Likewise.
6312         * opencl-lang.c (opencl_language_defn): Likewise.
6313         * p-lang.c (pascal_language_defn): Likewise.
6314         * rust-lang.c (rust_language_defn): Likewise.
6315
6316 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6317
6318         * ada-lang.c (ada_is_character_type): Change return type to bool.
6319         (ada_is_string_type): Likewise.
6320         * ada-lang.h (ada_is_character_type): Update declaration
6321         (ada_is_string_type): Likewise.
6322
6323 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6324
6325         Support style in 'frame|thread apply'
6326
6327         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6328         * record.c (record_start, record_stop): Update callers of
6329         execute_command_to_string with false.
6330         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6331         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6332         methods.
6333         (class string_file): New constructor with term_out parameter.
6334         Override methods term_out and can_emit_style_escape.  New member
6335         term_out.
6336         (class stdio_file): Override can_emit_style_escape.
6337         (class tee_file): Override term_out and can_emit_style_escape.
6338         * utils.h (can_emit_style_escape): Remove.
6339         * utils.c (can_emit_style_escape): Likewise.
6340         Update all callers of can_emit_style_escape (SOMESTREAM) to
6341         SOMESTREAM->can_emit_style_escape.
6342         * source-cache.c (source_cache::get_source_lines): Likewise.
6343         * stack.c (frame_apply_command_count): Call execute_command_to_string
6344         passing the term_out characteristic of the current gdb_stdout.
6345         * thread.c (thr_try_catch_cmd): Likewise.
6346         * top.c (execute_command_to_string): pass term_out parameter
6347         to construct the string_file for the command output.
6348         * ui-file.c (term_cli_styling): New function (most code moved
6349         from utils.c can_emit_style_escape).
6350         (string_file::string_file, string_file::can_emit_style_escape,
6351         stdio_file::can_emit_style_escape, tee_file::term_out,
6352         tee_file::can_emit_style_escape): New functions.
6353
6354 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6355
6356         * NEWS: Mention the new set|show may-call-functions.
6357         * infcall.c (may_call_functions_p): New variable.
6358         (show_may_call_functions_p): New function.
6359         (call_function_by_hand_dummy): Throws an error if not
6360         may-call-functions.
6361         (_initialize_infcall): Call add_setshow_boolean_cmd for
6362         may-call-functions.
6363
6364 2019-04-25  Keith Seitz  <keiths@redhat.com>
6365
6366         PR c++/24367
6367         * cp-support.c (inspect_type): Don't attempt substitutions
6368         of symbol with the same name.
6369
6370 2019-04-25  Tom Tromey  <tromey@adacore.com>
6371
6372         PR gdb/24475:
6373         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6374         static.
6375
6376 2019-04-25  Tom Tromey  <tromey@adacore.com>
6377
6378         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6379         rvalue reference.
6380         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6381         (gdb_xml_parser::parse): Use std::move.
6382         * python/python-internal.h (gdbpy_convert_exception): Take a const
6383         reference.
6384         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6385         std::move.
6386         * python/py-utils.c (gdbpy_convert_exception): Take a const
6387         reference.
6388         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6389         Use std::move.
6390         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6391         Use std::move.
6392         * mi/mi-main.c (mi_print_exception): Take a const reference.
6393         * main.c (handle_command_errors): Take a const reference.
6394         * linespec.c (parse_linespec): Use std::move.
6395         * infcall.c (run_inferior_call): Use std::move.
6396         (call_function_by_hand_dummy): Use std::move.
6397         * exec.c (try_open_exec_file): Use std::move.
6398         * exceptions.h (exception_print, exception_fprintf)
6399         (exception_print_same): Update.
6400         * exceptions.c (print_exception, exception_print)
6401         (exception_fprintf, exception_print_same): Change parameters to
6402         const reference.
6403         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6404         * common/new-op.c: Use std::move.
6405         * common/common-exceptions.h (struct gdb_exception): Add move
6406         constructor.
6407         (struct gdb_exception_error, struct gdb_exception_quit, struct
6408         gdb_quit_bad_alloc): Change constructor to move constructor.
6409         (throw_exception): Change parameter to rvalue reference.
6410         * common/common-exceptions.c (throw_exception): Take rvalue
6411         reference.
6412         * cli/cli-interp.c (safe_execute_command): Use std::move.
6413         * breakpoint.c (insert_bp_location, location_to_sals): Use
6414         std::move.
6415
6416 2019-04-25  Tom Tromey  <tromey@adacore.com>
6417
6418         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6419         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6420         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6421         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6422         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6423         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6424         guile/scm-value.c: Use unpack.
6425         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6426         gdbscm_gdb_exception.
6427         (gdbscm_throw_gdb_exception): Likewise.
6428         (struct gdbscm_gdb_exception): New.
6429         (unpack): New function.
6430         (gdbscm_wrap): Use unpack.
6431
6432 2019-04-25  Tom Tromey  <tromey@adacore.com>
6433
6434         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6435         (gdb_rl_callback_handler): Use std::move.
6436         * common/common-exceptions.h (struct gdb_exception): Add move
6437         assignment operator.
6438         (throw_exception_sjlj): Change "exception" to const reference.
6439         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6440         (throw_exception_sjlj): Change "exception" to const reference.
6441
6442 2019-04-25  Tom Tromey  <tromey@adacore.com>
6443
6444         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6445         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6446         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6447         Update.
6448         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6449         Update.
6450         * mi/mi-interp.c (mi_interp::exec): Update.
6451         * linespec.c (parse_linespec): Update.
6452         * infcall.c (run_inferior_call): Update.
6453         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6454         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6455         (gdbscm_lookup_global_symbol): Update.
6456         * guile/scm-param.c (gdbscm_parameter_value): Update.
6457         * guile/scm-frame.c (gdbscm_frame_read_register)
6458         (gdbscm_frame_read_var): Update.
6459         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6460         * exec.c (try_open_exec_file): Update.
6461         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6462         (gdb_rl_callback_handler): Update.
6463         * common/common-exceptions.h (exception_none): Don't declare.
6464         * common/common-exceptions.c (exception_none): Don't define.
6465         (struct catcher) <exception>: Update.
6466         * cli/cli-interp.c (safe_execute_command): Update.
6467         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6468
6469 2019-04-25  Ali Tamur  <tamur@google.com>
6470
6471         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6472         (read_attribute_value): Likewise.
6473         (dwarf2_read_addr_index): Update comment.
6474         (read_str_index): Add DW_FORM_strx.
6475         (dwarf2_string_attr): Likewise.
6476         (dwarf2_const_value_attr): Likewise.
6477         (dump_die_shallow): Likewise.
6478         (dwarf2_fetch_constant_bytes): Likewise.
6479         (skip_form_bytes): Likewise.
6480         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6481
6482 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6483
6484         PR corefiles/11608
6485         PR corefiles/18187
6486         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6487         OFFSET.  Verify if current mapping contains an ELF header.
6488         (linux_find_memory_regions_full): Adjust call to
6489         dump_mapping_p.
6490
6491 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6492             Kang Li <kanglictf@gmail.com>
6493
6494         PR gdb/21600
6495
6496         * dwarf2-frame.c (read_initial_length): Be consistent about using
6497         unsigned representation of length.
6498         (decode_frame_entry_1): Likewise.  Check for wraparound of
6499         end pointer as well as buffer overflow.
6500
6501 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6502
6503         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6504         "vq".
6505
6506 2019-04-24  Tom Tromey  <tromey@adacore.com>
6507
6508         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6509
6510 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6511
6512         * s12z-tdep.c (s12z_unwind_pc): Delete.
6513         (s12z_unwind_sp): Delete.
6514         (s12z_gdbarch_init): Don't register deleted functions with
6515         gdbarch.
6516
6517 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6518
6519         * rl78-tdep.c (rl78_unwind_sp): Delete.
6520         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6521
6522 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6523
6524         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6525         (xstormy16_unwind_pc): Delete.
6526         (xstormy16_dummy_id): Delete.
6527         (xstormy16_gdbarch_init): Don't register deleted functions with
6528         gdbarch.
6529
6530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6531
6532         * vax-tdep.c (vax_unwind_pc): Delete.
6533         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6534
6535 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6536
6537         * v850-tdep.c (v850_unwind_sp): Delete.
6538         (v850_unwind_pc): Delete.
6539         (v850_dummy_id): Delete.
6540         (v850_gdbarch_init): Don't register deleted functions with
6541         gdbarch.
6542
6543 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6544
6545         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6546         (tilegx_unwind_pc): Delete.
6547         (tilegx_unwind_dummy_id): Delete.
6548         (tilegx_gdbarch_init): Don't register deleted functions with
6549         gdbarch.
6550
6551 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6552
6553         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6554         (tic6x_dummy_id): Delete.
6555         (tic6x_gdbarch_init): Don't register deleted functions with
6556         gdbarch.
6557
6558 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6559
6560         * sparc-tdep.c (sparc_unwind_pc): Delete.
6561         (sparc32_gdbarch_init): Don't register deleted function with
6562         gdbarch.
6563
6564 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6565
6566         * sh-tdep.c (sh_unwind_sp): Delete.
6567         (sh_unwind_pc): Delete.
6568         (sh_dummy_id): Delete.
6569         (sh_gdbarch_init): Don't register deleted functions with
6570         gdbarch.
6571
6572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6573
6574         * score-tdep.c (score_unwind_sp): Delete.
6575         (score_unwind_pc): Delete.
6576         (score_dummy_id): Delete.
6577         (score_gdbarch_init): Don't register deleted functions with
6578         gdbarch.
6579
6580 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6581
6582         * rx-tdep.c (rx_unwind_pc): Delete.
6583         (rx_unwind_sp): Delete.
6584         (rx_dummy_id): Delete.
6585         (rx_gdbarch_init): Don't register deleted functions with
6586         gdbarch.  Update comment.
6587
6588 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6589
6590         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6591         (rs6000_dummy_id): Delete.
6592         (rs6000_gdbarch_init): Don't register deleted functions with
6593         gdbarch.
6594
6595 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6596
6597         * or1k-tdep.c (or1k_dummy_id): Delete.
6598         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6599
6600 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6601
6602         * nios2-tdep.c (nios2_dummy_id): Delete.
6603         (nios2_unwind_sp): Delete.
6604         (nios2_gdbarch_init): Don't register deleted functions with
6605         gdbarch.
6606
6607 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6608
6609         * nds32-tdep.c (nds32_dummy_id): Delete.
6610         (nds32_unwind_pc): Delete.
6611         (nds32_unwind_sp): Delete.
6612         (nds32_gdbarch_init): Don't register deleted functions with
6613         gdbarch.
6614
6615 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6616
6617         * msp430-tdep.c (msp430_unwind_pc): Delete.
6618         (msp430_unwind_sp): Delete.
6619         (msp430_dummy_id): Delete.
6620         (msp430_gdbarch_init): Don't register deleted functions with
6621         gdbarch.
6622
6623 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6624
6625         * moxie-tdep.c (moxie_unwind_sp): Delete.
6626         (moxie_unwind_pc): Delete.
6627         (moxie_dummy_id): Delete.
6628         (moxie_gdbarch_init): Don't register deleted functions with
6629         gdbarch.
6630
6631 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6632
6633         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6634         (mn10300_unwind_pc): Delete.
6635         (mn10300_unwind_sp): Delete.
6636         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6637         mn10300_unwind_sp.
6638         (mn10300_frame_unwind_init): Don't register deleted functions with
6639         gdbarch.
6640
6641 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6642
6643         * mep-tdep.c (mep_unwind_pc): Delete.
6644         (mep_unwind_sp): Delete.
6645         (mep_dummy_id): Delete.
6646         (mep_gdbarch_init): Don't register deleted functions with
6647         gdbarch.
6648
6649 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6650
6651         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6652         (m68hc11_unwind_sp): Delete.
6653         (m68hc11_gdbarch_init): Don't register deleted functions with
6654         gdbarch.
6655
6656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6657
6658         * m32r-tdep.c (m32r_unwind_sp): Delete.
6659         (m32r_unwind_pc): Delete.
6660         (m32r_dummy_id): Delete.
6661         (m32r_gdbarch_init): Don't register deleted functions with
6662         gdbarch.
6663
6664 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6665
6666         * m32c-tdep.c (m32c_unwind_pc): Delete.
6667         (m32c_unwind_sp): Delete.
6668         (m32c_dummy_id): Delete.
6669         (m32c_gdbarch_init): Don't register deleted functions with
6670         gdbarch.
6671
6672 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6673
6674         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6675         (lm32_unwind_pc): Delete.
6676         (lm32_dummy_id): Delete.
6677         (lm32_gdbarch_init): Don't register deleted functions with
6678         gdbarch.
6679
6680 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6681
6682         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6683         (iq2000_unwind_pc): Delete.
6684         (iq2000_dummy_id): Delete.
6685         (iq2000_gdbarch_init): Don't register deleted functions with
6686         gdbarch.
6687
6688 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6689
6690         * nds32-tdep.c (nds32_type_align): Delete.
6691         (nds32_push_dummy_call): Use type_align instead.
6692
6693 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6694
6695         * arm-tdep.c (arm_type_align): Only handle vector override case.
6696         (arm_push_dummy_call): Use type_align.
6697         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6698
6699 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6700
6701         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6702         case.
6703         (pass_on_stack): Use type_align.
6704         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6705         function.
6706
6707 2019-04-23  Tom Tromey  <tromey@adacore.com>
6708
6709         * dwarf2read.c (line_header::file_name_at): Remove unused
6710         overload.
6711
6712 2019-04-23  Tom de Vries  <tdevries@suse.de>
6713
6714         PR gdb/24438
6715         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6716         invocation.
6717
6718
6719 2019-03-27  Ali Tamur  <tamur@google.com>
6720
6721         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6722         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6723         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6724         (dwarf_expr_context::get_addr_index): Likewise
6725         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6726         (symbol_needs_eval_context::get_addr_index): Likewise
6727         (disassemble_dwarf_expression): Add DW_OP_addrx
6728         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6729         (read_cutu_die_from_dwo): Update comment
6730         (skip_one_die): Add DW_FORM_addrx
6731         (read_attribute_value): Likewise
6732         (var_decode_location): Add DW_OP_addrx
6733         (dwarf2_const_value_attr): Add DW_FORM_addrx
6734         (dump_die_shallow): Likewise
6735         (dwarf2_fetch_constant_bytes): Likewise
6736         (decode_locdesc): Add DW_OP_addrx
6737         (skip_form_bytes): Add DW_FORM_addrx
6738
6739 2019-04-22  Ali Tamur  <tamur@google.com>
6740
6741         * MAINTAINERS (Write After Approval): Add self.
6742
6743 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6744
6745         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6746         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6747         (open_symbol_file_object): Likewise.
6748         (svr4_default_sos): Add info parameter.
6749         (svr4_read_so_list): Likewise.
6750         (svr4_current_sos_direct): Adjust functions calls to pass down
6751         info.
6752         (svr4_current_sos_1): Add info parameter.
6753         (svr4_current_sos): Call get_svr4_info, pass info down to
6754         svr4_current_sos_1.
6755         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6756         get_svr4_info.
6757         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6758         get_svr4_info.
6759         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6760         to get_svr4_info.
6761         (probes_table_remove_objfile_probes): Likewise.
6762         (register_solib_event_probe): Add info parameter.
6763         (solist_update_incremental): Pass info parameter down to
6764         svr4_read_so_list.
6765         (disable_probes_interface): Add info parameter.
6766         (svr4_handle_solib_event): Pass current_program_space to
6767         get_svr4_info.  Adjust disable_probes_interface cleanup.
6768         (svr4_create_probe_breakpoints): Add info parameter, pass it
6769         down to register_solib_event_probe.
6770         (svr4_create_solib_event_breakpoints): Add info parameter,
6771         pass it down to svr4_create_probe_breakpoints.
6772         (enable_break): Pass info down to
6773         svr4_create_solib_event_breakpoints.
6774         (svr4_solib_create_inferior_hook): Pass current_program_space to
6775         get_svr4_info.
6776         (svr4_clear_solib): Likewise.
6777
6778 2019-04-22  Pedro Alves  <palves@redhat.com>
6779
6780         * solib-svr4.c (svr4_free_objfile_observer): New.
6781         (probe_and_action::objfile): New field.
6782         (probes_table_htab_remove_objfile_probes)
6783         (probes_table_remove_objfile_probes): New functions.
6784         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6785         in the new probe_and_action.  Don't store the probe in 'lookup'.
6786         (svr4_create_probe_breakpoints): Pass objfile to
6787         register_solib_event_probe.
6788         (_initialize_svr4_solib): Register a free_objfile observer.
6789
6790 2019-04-19  Tom Tromey  <tom@tromey.com>
6791
6792         * common/queue.h: Remove.
6793
6794 2019-04-19  Tom Tromey  <tom@tromey.com>
6795
6796         * event-loop.c: Don't include "common/queue.h".
6797
6798 2019-04-19  Tom Tromey  <tom@tromey.com>
6799
6800         * remote.c (remote_target): Use delete.
6801         * remote-notif.h: Include <list>, not "common/queue.h".
6802         (notif_client_p): Remove typedef.
6803         (remote_notif_state): Add constructor, destructor, initializer.
6804         <notif_queue>: Now a std::list.
6805         (remote_notif_state_xfree): Don't declare.
6806         * remote-notif.c (remote_notif_process, handle_notification)
6807         (remote_notif_state_allocate): Update.
6808         (~remote_notif_state): Rename from remote_notif_state_xfree.
6809
6810 2019-04-19  Tom Tromey  <tom@tromey.com>
6811
6812         * symfile.c (reread_symbols): Update.
6813         * objfiles.c (objfile_register_static_link)
6814         (objfile_lookup_static_link): Update
6815         (~objfile) Don't delete static_links.
6816         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6817
6818 2019-04-19  Tom Tromey  <tom@tromey.com>
6819
6820         * type-stack.h (struct type_stack) <insert>: Constify string.
6821         * type-stack.c (type_stack::insert): Constify string.
6822         * gdbtypes.h (lookup_template_type): Update.
6823         (address_space_name_to_int): Update.
6824         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6825         const.
6826         (lookup_template_type): Make name const.
6827         * c-exp.y: Update rules.
6828         (lex_one_token, classify_name, classify_inner_name)
6829         (c_print_token): Update.
6830         * p-exp.y: Update rules.
6831         (yylex): Update.
6832         * f-exp.y: Update rules.
6833         (yylex): Update.
6834         * d-exp.y: Update rules.
6835         (lex_one_token, classify_name, classify_inner_name): Update.
6836         * parse.c (write_dollar_variable, copy_name): Return std::string.
6837         * parser-defs.h (copy_name): Change return type.
6838         * m2-exp.y: Update rules.
6839         (yylex): Update.
6840         * go-exp.y (lex_one_token): Update.
6841         Update rules.
6842         (classify_unsafe_function, classify_packaged_name)
6843         (classify_name, yylex): Update.
6844
6845 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6846
6847         * configure.ac: add --enable-source-highlight switch.
6848         * configure: Regenerate.
6849         * top.c (print_gdb_version): plumb --enable-source-highlight
6850         status to "show configuration".
6851
6852 2019-04-19  Tom Tromey  <tromey@adacore.com>
6853
6854         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6855         Check ADA_TYPE_P.
6856         (empty_record, ada_template_to_fixed_record_type_1)
6857         (template_to_static_fixed_type)
6858         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6859         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6860         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6861         macros.
6862
6863 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6864
6865         PR symtab/24423:
6866         * source.c (print_source_lines_base): Advance "iter" when a
6867         control character is seen.
6868
6869 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6870
6871         * inferior.h (struct infcall_suspend_state_deleter):
6872         Catch exception in destructor to avoid crash.
6873
6874 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6875
6876         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6877         close to the add_com "shell".
6878
6879 2019-04-18  Tom Tromey  <tromey@adacore.com>
6880
6881         * process-stratum-target.h (class process_stratum_target)
6882         <stratum>: Add "final".
6883
6884 2019-04-17  Tom Tromey  <tromey@adacore.com>
6885
6886         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6887         against nullptr before use.
6888
6889 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6890
6891         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6892
6893 2019-04-17  Jim Wilson  <jimw@sifive.com>
6894             Andrew Burgess  <andrew.burgess@embecosm.com>
6895
6896         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6897         code read might fail, assume 4-byte breakpoint in that case.
6898
6899 2019-04-15  Leszek Swirski  <leszeks@google.com>
6900
6901         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6902         rather than a hand-rolled POD check when checking for forced MEMORY
6903         classification.
6904
6905 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6906
6907         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6908         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6909         function.
6910         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6911         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6912         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6913         declaration.
6914
6915 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6916
6917         * aarch64-linux-nat.c
6918         (aarch64_linux_nat_target::thread_architecture): Add override.
6919         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6920         each VQ.
6921
6922 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6923
6924         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6925
6926 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6927
6928         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6929         target types of size 96-bits, add some additional comments, and
6930         check that the builtin type we found was the correct size.
6931
6932 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6933
6934         * utils.c (prompt_for_continue): Don't restore the styling at the
6935         end, as applied_style has the wrong value.  This fixes styling in
6936         long lists of file names that are interrupted by the "Continue?"
6937         prompt.
6938
6939 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6940
6941         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6942         * c-lang.c (c_language_defn): Likewise.
6943         (cplus_language_defn): Likewise.
6944         (asm_language_defn): Likewise.
6945         (minimal_language_defn): Likewise.
6946         * d-lang.c (d_language_defn): Likewise.
6947         * f-lang.c (f_language_defn): Likewise.
6948         * go-lang.c (go_language_defn): Likewise.
6949         * language.c (unknown_language_defn): Likewise.
6950         (auto_language_defn): Likewise.
6951         * language.h (struct language_defn): Remove la_magic field.
6952         (LANG_MAGIC): Delete.
6953         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6954         * objc-lang.c (objc_language_defn): Likewise.
6955         * opencl-lang.c (opencl_language_defn): Likewise.
6956         * p-lang.c (pascal_language_defn): Likewise.
6957         * rust-lang.c (rust_language_defn): Likewise.
6958
6959 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6960
6961         * riscv-tdep.c (riscv_type_align): New function.
6962         (riscv_type_alignment): Delete.
6963         (riscv_arg_location): Use 'type_align'.
6964         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6965
6966 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6967
6968         * gdbtypes.c (type_align): A struct with no non-static fields also
6969         has alignment of 1.
6970
6971 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6972
6973         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6974         component to 0.
6975         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6976         member.
6977         (riscv_struct_info::analyse): New implementation using new
6978         analyse_inner member function.
6979         (riscv_struct_info::field_offset): New member function.
6980         (riscv_struct_info::m_offsets): New member variable.
6981         (riscv_struct_info::analyse_inner): New private member function,
6982         takes the old implementation of riscv_struct_info::analyse but
6983         extended to track field offsets.
6984         (riscv_call_arg_struct): Update the struct folding special cases
6985         to handle cases where empty C++ structs, which are non-zero
6986         length, are found.
6987         (riscv_arg_location): Initialise the length of each location, a
6988         non-zero length now indicates the location is in use.
6989         (riscv_push_dummy_call): Allow for the first location having a
6990         non-zero offset when setting up arguments.
6991         (riscv_return_value): Likewise, but for return values.
6992
6993 2019-04-11  Tom Tromey  <tromey@adacore.com>
6994
6995         * utils.c (internal_vproblem): Make "msg" const.
6996
6997 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6998
6999         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7000         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7001         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7002         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7003
7004 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7005
7006         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7007         function.
7008         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7009         of amd64_collect_native_gregset.
7010         (amd64_linux_nat_target::store_registers): Likewise.
7011
7012 2019-04-10  Tom Tromey  <tom@tromey.com>
7013
7014         * symtab.c (lookup_global_symbol_from_objfile)
7015         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7016         * objfiles.h (class separate_debug_iterator): New.
7017         (class separate_debug_range): New.
7018         (struct objfile) <separate_debug_objfiles>: New method.
7019         (objfile_separate_debug_iterate): Don't declare.
7020         * objfiles.c (separate_debug_iterator::operator++): Rename from
7021         objfile_separate_debug_iterate.
7022         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7023         iterator.
7024         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7025         iterator.
7026
7027 2019-04-10  Tom Tromey  <tom@tromey.com>
7028
7029         * symfile.c (reread_symbols): Remove old comment.
7030         * objfiles.c (free_all_objfiles): Fix a typo.
7031
7032 2019-04-10  Tom Tromey  <tom@tromey.com>
7033
7034         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7035         * minsyms.c (lookup_minimal_symbol): Use foreach.
7036         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7037         (lookup_minimal_symbol_solib_trampoline): Likewise.
7038         * symfile.c (reread_symbols): Use foreach.
7039
7040 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7041             Tom Tromey  <tromey@adacore.com>
7042
7043         PR rust/24414:
7044         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7045         (rust_lex_int_test): Change "value" to be LONGEST.
7046         (rust_lex_tests): Add test for long integer literal.
7047
7048 2019-04-09  Tom Tromey  <tromey@adacore.com>
7049
7050         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7051         to bool.
7052         (extended_remote_target::attach): Update.
7053         (remote_target::remote_notice_new_inferior): Update.
7054         (remote_target::add_current_inferior_and_thread): Update.
7055         * inferior.c (exit_inferior_1): Use "false".
7056         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7057
7058 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7059
7060         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7061         the "start" command.
7062
7063 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7064
7065         * python/py-inferior.c (infpy_thread_from_thread_handle):
7066         Adjust comments to reflect renaming of thread_from_thread_handle
7067         to thread_from_handle.  Adjust keywords.  Fix type error message.
7068         (inferior_object_methods): Add thread_from_handle.  Retain
7069         thread_from_thread_handle, but mark it as deprecated.
7070
7071 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7072
7073         * gdbthread.h (find_thread_by_handle): Revise declaration.
7074         * thread.c (find_thread_by_handle): Likewise.  Adjust
7075         implementation too.
7076         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7077         support for buffer objects as handles.
7078
7079 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7080
7081         * python/py-infthread.c (thpy_thread_handle): New function.
7082         (thread_object_methods): Register thpy_thread_handle.
7083
7084 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7085
7086         * gdbthread.h (thread_to_thread_handle): Declare.
7087         * thread.c (gdbtypes.h): Include.
7088         (thread_to_thread_handle): New function.
7089
7090         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7091         (target_thread_info_to_thread_handle): Declare.
7092         * target.c (target_thread_info_to_thread_handle): New function.
7093         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7094         * target-delegates.c: Regenerate.
7095
7096         * linux-thread-db.c (class thread_db_target): Add method
7097         thread_info_to_thread_handle.
7098         (thread_db_target::thread_info_to_thread_handle): Define.
7099         * remote.c (class remote_target): Add new method
7100         thread_info_to_thread_handle.
7101         (remote_target::thread_info_to_thread_handle): Define.
7102
7103 2019-04-08  Pedro Alves  <palves@redhat.com>
7104
7105         * common/common-exceptions.c (throw_exception): Don't create
7106         named object to throw; throw directly.
7107         (throw_it): Likewise.  Don't initialize gdb_exception::message
7108         here, with new; pass FMT and AP to the ctor instead.
7109         * common/common-exceptions.h: Include <string>.
7110         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7111         const char *, va_list)): New ctor.  Use std::make_shared.
7112         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7113         errors)): Delete.
7114         (gdb_exception_error::gdb_exception_error(enum errors, const char
7115         *, va_list)): New.
7116         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7117         Add assertion.
7118         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7119         errors)): Delete.
7120         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7121         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7122         Add assertion.
7123
7124 2019-04-08  Tom Tromey  <tom@tromey.com>
7125
7126         * valops.c (value_rtti_indirect_type): Replace throw_exception
7127         with throw.
7128         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7129         with throw.
7130         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7131         throw.
7132         * target.c (target_translate_tls_address): Replace throw_exception
7133         with throw.
7134         * stack.c (frame_apply_command_count): Replace throw_exception
7135         with throw.
7136         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7137         throw.
7138         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7139         with throw.
7140         * rs6000-tdep.c (rs6000_frame_cache)
7141         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7142         * remote.c: Replace throw_exception with throw.
7143         * record-full.c (record_full_message, record_full_wait_1)
7144         (record_full_restore): Replace throw_exception with throw.
7145         * record-btrace.c:
7146         (get_thread_current_frame_id, record_btrace_start_replaying)
7147         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7148         (cmd_record_btrace_start): Replace throw_exception with throw.
7149         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7150         throw.
7151         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7152         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7153         * linespec.c:
7154         (find_linespec_symbols): Replace throw_exception with throw.
7155         * infrun.c (displaced_step_prepare, resume): Replace
7156         throw_exception with throw.
7157         * infcmd.c (post_create_inferior): Replace throw_exception with
7158         throw.
7159         * inf-loop.c (inferior_event_handler): Replace throw_exception
7160         with throw.
7161         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7162         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7163         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7164         (get_prev_frame_always, get_frame_pc_if_available)
7165         (get_frame_address_in_block_if_available, get_frame_language):
7166         Replace throw_exception with throw.
7167         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7168         throw_exception with throw.
7169         * eval.c (fetch_subexp_value, evaluate_var_value)
7170         (evaluate_funcall, evaluate_subexp_standard): Replace
7171         throw_exception with throw.
7172         * dwarf2loc.c (call_site_find_chain)
7173         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7174         Replace throw_exception with throw.
7175         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7176         with throw.
7177         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7178         throw.
7179         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7180         * completer.c (complete_line_internal): Replace throw_exception
7181         with throw.
7182         * compile/compile-object-run.c (compile_object_run): Replace
7183         throw_exception with throw.
7184         * cli/cli-script.c (process_next_line): Replace throw_exception
7185         with throw.
7186         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7187         (btrace_enable, btrace_maint_update_pt_packets): Replace
7188         throw_exception with throw.
7189         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7190         throw_exception with throw.
7191         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7192         throw_exception with throw.
7193         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7194         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7195         * aarch64-tdep.c (aarch64_make_prologue_cache)
7196         (aarch64_make_stub_cache): Replace throw_exception with throw.
7197
7198 2019-04-08  Tom Tromey  <tom@tromey.com>
7199
7200         * common/common-exceptions.c (throw_exception): Rename from
7201         throw_exception_cxx.  Remove old copy.  Make argument const.
7202         (throw_it): Create and throw exception objects directly.
7203         * common/common-exceptions.h (throw_exception): Make argument
7204         const.
7205         (struct gdb_exception_error): Add constructor.
7206         (struct gdb_exception_quit): Add constructor.
7207
7208 2019-04-08  Tom Tromey  <tom@tromey.com>
7209
7210         * common/common-exceptions.h (exception_rethrow): Don't declare.
7211         (TRY_SJLJ): Update comment.
7212         (TRY, CATCH, END_CATCH): Remove.
7213         * common/common-exceptions.c (exception_rethrow): Remove.
7214
7215 2019-04-08  Tom Tromey  <tom@tromey.com>
7216
7217         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7218         Remove.
7219         (gdb_exception_error): Rename from
7220         gdb_exception_RETURN_MASK_ERROR.
7221         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7222         (gdb_quit_bad_alloc): Update.
7223         * aarch64-tdep.c: Update.
7224         * ada-lang.c: Update.
7225         * ada-typeprint.c: Update.
7226         * ada-valprint.c: Update.
7227         * amd64-tdep.c: Update.
7228         * arch-utils.c: Update.
7229         * break-catch-throw.c: Update.
7230         * breakpoint.c: Update.
7231         * btrace.c: Update.
7232         * c-varobj.c: Update.
7233         * cli/cli-cmds.c: Update.
7234         * cli/cli-interp.c: Update.
7235         * cli/cli-script.c: Update.
7236         * common/common-exceptions.c: Update.
7237         * common/new-op.c: Update.
7238         * common/selftest.c: Update.
7239         * compile/compile-c-symbols.c: Update.
7240         * compile/compile-cplus-symbols.c: Update.
7241         * compile/compile-object-load.c: Update.
7242         * compile/compile-object-run.c: Update.
7243         * completer.c: Update.
7244         * corelow.c: Update.
7245         * cp-abi.c: Update.
7246         * cp-support.c: Update.
7247         * cp-valprint.c: Update.
7248         * darwin-nat.c: Update.
7249         * disasm-selftests.c: Update.
7250         * dtrace-probe.c: Update.
7251         * dwarf-index-cache.c: Update.
7252         * dwarf-index-write.c: Update.
7253         * dwarf2-frame-tailcall.c: Update.
7254         * dwarf2-frame.c: Update.
7255         * dwarf2loc.c: Update.
7256         * dwarf2read.c: Update.
7257         * eval.c: Update.
7258         * event-loop.c: Update.
7259         * event-top.c: Update.
7260         * exec.c: Update.
7261         * f-valprint.c: Update.
7262         * fbsd-tdep.c: Update.
7263         * frame-unwind.c: Update.
7264         * frame.c: Update.
7265         * gdbtypes.c: Update.
7266         * gnu-v3-abi.c: Update.
7267         * guile/guile-internal.h: Update.
7268         * guile/scm-block.c: Update.
7269         * guile/scm-breakpoint.c: Update.
7270         * guile/scm-cmd.c: Update.
7271         * guile/scm-disasm.c: Update.
7272         * guile/scm-frame.c: Update.
7273         * guile/scm-lazy-string.c: Update.
7274         * guile/scm-math.c: Update.
7275         * guile/scm-param.c: Update.
7276         * guile/scm-ports.c: Update.
7277         * guile/scm-pretty-print.c: Update.
7278         * guile/scm-symbol.c: Update.
7279         * guile/scm-symtab.c: Update.
7280         * guile/scm-type.c: Update.
7281         * guile/scm-value.c: Update.
7282         * i386-linux-tdep.c: Update.
7283         * i386-tdep.c: Update.
7284         * inf-loop.c: Update.
7285         * infcall.c: Update.
7286         * infcmd.c: Update.
7287         * infrun.c: Update.
7288         * jit.c: Update.
7289         * language.c: Update.
7290         * linespec.c: Update.
7291         * linux-fork.c: Update.
7292         * linux-nat.c: Update.
7293         * linux-tdep.c: Update.
7294         * linux-thread-db.c: Update.
7295         * main.c: Update.
7296         * mi/mi-cmd-break.c: Update.
7297         * mi/mi-cmd-stack.c: Update.
7298         * mi/mi-interp.c: Update.
7299         * mi/mi-main.c: Update.
7300         * objc-lang.c: Update.
7301         * p-valprint.c: Update.
7302         * parse.c: Update.
7303         * ppc-linux-tdep.c: Update.
7304         * printcmd.c: Update.
7305         * python/py-arch.c: Update.
7306         * python/py-breakpoint.c: Update.
7307         * python/py-cmd.c: Update.
7308         * python/py-finishbreakpoint.c: Update.
7309         * python/py-frame.c: Update.
7310         * python/py-framefilter.c: Update.
7311         * python/py-gdb-readline.c: Update.
7312         * python/py-inferior.c: Update.
7313         * python/py-infthread.c: Update.
7314         * python/py-lazy-string.c: Update.
7315         * python/py-linetable.c: Update.
7316         * python/py-objfile.c: Update.
7317         * python/py-param.c: Update.
7318         * python/py-prettyprint.c: Update.
7319         * python/py-progspace.c: Update.
7320         * python/py-record-btrace.c: Update.
7321         * python/py-record.c: Update.
7322         * python/py-symbol.c: Update.
7323         * python/py-type.c: Update.
7324         * python/py-unwind.c: Update.
7325         * python/py-utils.c: Update.
7326         * python/py-value.c: Update.
7327         * python/python.c: Update.
7328         * record-btrace.c: Update.
7329         * record-full.c: Update.
7330         * remote-fileio.c: Update.
7331         * remote.c: Update.
7332         * riscv-tdep.c: Update.
7333         * rs6000-aix-tdep.c: Update.
7334         * rs6000-tdep.c: Update.
7335         * rust-exp.y: Update.
7336         * rust-lang.c: Update.
7337         * s390-tdep.c: Update.
7338         * selftest-arch.c: Update.
7339         * solib-dsbt.c: Update.
7340         * solib-frv.c: Update.
7341         * solib-spu.c: Update.
7342         * solib-svr4.c: Update.
7343         * solib.c: Update.
7344         * sparc64-linux-tdep.c: Update.
7345         * stack.c: Update.
7346         * symfile-mem.c: Update.
7347         * symmisc.c: Update.
7348         * target.c: Update.
7349         * thread.c: Update.
7350         * top.c: Update.
7351         * tracefile-tfile.c: Update.
7352         * tui/tui.c: Update.
7353         * typeprint.c: Update.
7354         * unittests/cli-utils-selftests.c: Update.
7355         * unittests/parse-connection-spec-selftests.c: Update.
7356         * valops.c: Update.
7357         * valprint.c: Update.
7358         * value.c: Update.
7359         * varobj.c: Update.
7360         * windows-nat.c: Update.
7361         * x86-linux-nat.c: Update.
7362         * xml-support.c: Update.
7363
7364 2019-04-08  Tom Tromey  <tom@tromey.com>
7365
7366         * xml-support.c: Use C++ exception handling.
7367         * x86-linux-nat.c: Use C++ exception handling.
7368         * windows-nat.c: Use C++ exception handling.
7369         * varobj.c: Use C++ exception handling.
7370         * value.c: Use C++ exception handling.
7371         * valprint.c: Use C++ exception handling.
7372         * valops.c: Use C++ exception handling.
7373         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7374         handling.
7375         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7376         * typeprint.c: Use C++ exception handling.
7377         * tui/tui.c: Use C++ exception handling.
7378         * tracefile-tfile.c: Use C++ exception handling.
7379         * top.c: Use C++ exception handling.
7380         * thread.c: Use C++ exception handling.
7381         * target.c: Use C++ exception handling.
7382         * symmisc.c: Use C++ exception handling.
7383         * symfile-mem.c: Use C++ exception handling.
7384         * stack.c: Use C++ exception handling.
7385         * sparc64-linux-tdep.c: Use C++ exception handling.
7386         * solib.c: Use C++ exception handling.
7387         * solib-svr4.c: Use C++ exception handling.
7388         * solib-spu.c: Use C++ exception handling.
7389         * solib-frv.c: Use C++ exception handling.
7390         * solib-dsbt.c: Use C++ exception handling.
7391         * selftest-arch.c: Use C++ exception handling.
7392         * s390-tdep.c: Use C++ exception handling.
7393         * rust-lang.c: Use C++ exception handling.
7394         * rust-exp.y: Use C++ exception handling.
7395         * rs6000-tdep.c: Use C++ exception handling.
7396         * rs6000-aix-tdep.c: Use C++ exception handling.
7397         * riscv-tdep.c: Use C++ exception handling.
7398         * remote.c: Use C++ exception handling.
7399         * remote-fileio.c: Use C++ exception handling.
7400         * record-full.c: Use C++ exception handling.
7401         * record-btrace.c: Use C++ exception handling.
7402         * python/python.c: Use C++ exception handling.
7403         * python/py-value.c: Use C++ exception handling.
7404         * python/py-utils.c: Use C++ exception handling.
7405         * python/py-unwind.c: Use C++ exception handling.
7406         * python/py-type.c: Use C++ exception handling.
7407         * python/py-symbol.c: Use C++ exception handling.
7408         * python/py-record.c: Use C++ exception handling.
7409         * python/py-record-btrace.c: Use C++ exception handling.
7410         * python/py-progspace.c: Use C++ exception handling.
7411         * python/py-prettyprint.c: Use C++ exception handling.
7412         * python/py-param.c: Use C++ exception handling.
7413         * python/py-objfile.c: Use C++ exception handling.
7414         * python/py-linetable.c: Use C++ exception handling.
7415         * python/py-lazy-string.c: Use C++ exception handling.
7416         * python/py-infthread.c: Use C++ exception handling.
7417         * python/py-inferior.c: Use C++ exception handling.
7418         * python/py-gdb-readline.c: Use C++ exception handling.
7419         * python/py-framefilter.c: Use C++ exception handling.
7420         * python/py-frame.c: Use C++ exception handling.
7421         * python/py-finishbreakpoint.c: Use C++ exception handling.
7422         * python/py-cmd.c: Use C++ exception handling.
7423         * python/py-breakpoint.c: Use C++ exception handling.
7424         * python/py-arch.c: Use C++ exception handling.
7425         * printcmd.c: Use C++ exception handling.
7426         * ppc-linux-tdep.c: Use C++ exception handling.
7427         * parse.c: Use C++ exception handling.
7428         * p-valprint.c: Use C++ exception handling.
7429         * objc-lang.c: Use C++ exception handling.
7430         * mi/mi-main.c: Use C++ exception handling.
7431         * mi/mi-interp.c: Use C++ exception handling.
7432         * mi/mi-cmd-stack.c: Use C++ exception handling.
7433         * mi/mi-cmd-break.c: Use C++ exception handling.
7434         * main.c: Use C++ exception handling.
7435         * linux-thread-db.c: Use C++ exception handling.
7436         * linux-tdep.c: Use C++ exception handling.
7437         * linux-nat.c: Use C++ exception handling.
7438         * linux-fork.c: Use C++ exception handling.
7439         * linespec.c: Use C++ exception handling.
7440         * language.c: Use C++ exception handling.
7441         * jit.c: Use C++ exception handling.
7442         * infrun.c: Use C++ exception handling.
7443         * infcmd.c: Use C++ exception handling.
7444         * infcall.c: Use C++ exception handling.
7445         * inf-loop.c: Use C++ exception handling.
7446         * i386-tdep.c: Use C++ exception handling.
7447         * i386-linux-tdep.c: Use C++ exception handling.
7448         * guile/scm-value.c: Use C++ exception handling.
7449         * guile/scm-type.c: Use C++ exception handling.
7450         * guile/scm-symtab.c: Use C++ exception handling.
7451         * guile/scm-symbol.c: Use C++ exception handling.
7452         * guile/scm-pretty-print.c: Use C++ exception handling.
7453         * guile/scm-ports.c: Use C++ exception handling.
7454         * guile/scm-param.c: Use C++ exception handling.
7455         * guile/scm-math.c: Use C++ exception handling.
7456         * guile/scm-lazy-string.c: Use C++ exception handling.
7457         * guile/scm-frame.c: Use C++ exception handling.
7458         * guile/scm-disasm.c: Use C++ exception handling.
7459         * guile/scm-cmd.c: Use C++ exception handling.
7460         * guile/scm-breakpoint.c: Use C++ exception handling.
7461         * guile/scm-block.c: Use C++ exception handling.
7462         * guile/guile-internal.h: Use C++ exception handling.
7463         * gnu-v3-abi.c: Use C++ exception handling.
7464         * gdbtypes.c: Use C++ exception handling.
7465         * frame.c: Use C++ exception handling.
7466         * frame-unwind.c: Use C++ exception handling.
7467         * fbsd-tdep.c: Use C++ exception handling.
7468         * f-valprint.c: Use C++ exception handling.
7469         * exec.c: Use C++ exception handling.
7470         * event-top.c: Use C++ exception handling.
7471         * event-loop.c: Use C++ exception handling.
7472         * eval.c: Use C++ exception handling.
7473         * dwarf2read.c: Use C++ exception handling.
7474         * dwarf2loc.c: Use C++ exception handling.
7475         * dwarf2-frame.c: Use C++ exception handling.
7476         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7477         * dwarf-index-write.c: Use C++ exception handling.
7478         * dwarf-index-cache.c: Use C++ exception handling.
7479         * dtrace-probe.c: Use C++ exception handling.
7480         * disasm-selftests.c: Use C++ exception handling.
7481         * darwin-nat.c: Use C++ exception handling.
7482         * cp-valprint.c: Use C++ exception handling.
7483         * cp-support.c: Use C++ exception handling.
7484         * cp-abi.c: Use C++ exception handling.
7485         * corelow.c: Use C++ exception handling.
7486         * completer.c: Use C++ exception handling.
7487         * compile/compile-object-run.c: Use C++ exception handling.
7488         * compile/compile-object-load.c: Use C++ exception handling.
7489         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7490         * compile/compile-c-symbols.c: Use C++ exception handling.
7491         * common/selftest.c: Use C++ exception handling.
7492         * common/new-op.c: Use C++ exception handling.
7493         * cli/cli-script.c: Use C++ exception handling.
7494         * cli/cli-interp.c: Use C++ exception handling.
7495         * cli/cli-cmds.c: Use C++ exception handling.
7496         * c-varobj.c: Use C++ exception handling.
7497         * btrace.c: Use C++ exception handling.
7498         * breakpoint.c: Use C++ exception handling.
7499         * break-catch-throw.c: Use C++ exception handling.
7500         * arch-utils.c: Use C++ exception handling.
7501         * amd64-tdep.c: Use C++ exception handling.
7502         * ada-valprint.c: Use C++ exception handling.
7503         * ada-typeprint.c: Use C++ exception handling.
7504         * ada-lang.c: Use C++ exception handling.
7505         * aarch64-tdep.c: Use C++ exception handling.
7506
7507 2019-04-08  Tom Tromey  <tom@tromey.com>
7508
7509         * xml-support.c (gdb_xml_parser::parse): Update.
7510         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7511         * value.c (show_convenience): Update.
7512         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7513         (test_parse_flags_qcs): Update.
7514         * thread.c (thr_try_catch_cmd): Update.
7515         * target.c (target_translate_tls_address): Update.
7516         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7517         (info_frame_command_core, frame_apply_command_count): Update.
7518         * rust-exp.y (rust_lex_exception_test): Update.
7519         * riscv-tdep.c (riscv_print_one_register_info): Update.
7520         * remote.c (remote_target::enable_btrace): Update.
7521         * record-btrace.c (record_btrace_enable_warn): Update.
7522         * python/py-utils.c (gdbpy_convert_exception): Update.
7523         * printcmd.c (do_one_display, print_variable_and_value): Update.
7524         * mi/mi-main.c (mi_print_exception): Update.
7525         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7526         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7527         * linux-nat.c (linux_nat_target::attach): Update.
7528         * linux-fork.c (class scoped_switch_fork_info): Update.
7529         * infrun.c (displaced_step_prepare): Update.
7530         * infcall.c (call_function_by_hand_dummy): Update.
7531         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7532         * gnu-v3-abi.c (print_one_vtable): Update.
7533         * frame.c (get_prev_frame_always): Update.
7534         * f-valprint.c (info_common_command_for_block): Update.
7535         * exec.c (try_open_exec_file): Update.
7536         * exceptions.c (print_exception, exception_print)
7537         (exception_fprintf, exception_print_same): Update.
7538         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7539         * dwarf-index-cache.c (index_cache::store)
7540         (index_cache::lookup_gdb_index): Update.
7541         * darwin-nat.c (maybe_cache_shell): Update.
7542         * cp-valprint.c (cp_print_value_fields): Update.
7543         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7544         (gcc_cplus_symbol_address): Update.
7545         * compile/compile-c-symbols.c (gcc_convert_symbol)
7546         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7547         * common/selftest.c: Update.
7548         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7549         a std::string.
7550         (exception_try_scope_entry, exception_try_scope_exit): Don't
7551         declare.
7552         (struct exception_try_scope): Remove.
7553         (TRY): Don't use exception_try_scope.
7554         (struct gdb_exception): Add constructor, operator=.
7555         <what>: New method.
7556         (struct gdb_exception_RETURN_MASK_ALL)
7557         (struct gdb_exception_RETURN_MASK_ERROR)
7558         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7559         (struct gdb_quit_bad_alloc): Update.
7560         * common/common-exceptions.c (exception_none): Change
7561         initializer.
7562         (struct catcher) <state, exception>: Initialize inline.
7563         <prev>: Remove member.
7564         (current_catcher): Remove.
7565         (catchers): New global.
7566         (exceptions_state_mc_init): Simplify.
7567         (catcher_pop): Remove.
7568         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7569         (try_scope_depth, exception_try_scope_entry)
7570         (exception_try_scope_exit): Remove.
7571         (throw_exception_sjlj): Update.
7572         (exception_messages, exception_messages_size): Remove.
7573         (throw_it): Simplify.
7574         (gdb_exception_sliced_copy): Remove.
7575         (throw_exception_cxx): Update.
7576         * cli/cli-script.c (script_from_file): Update.
7577         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7578         Update.
7579         * ada-valprint.c (ada_val_print): Update.
7580         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7581         (create_excep_cond_exprs): Update.
7582
7583 2019-04-08  Tom Tromey  <tom@tromey.com>
7584
7585         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7586         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7587         (TRY, CATCH, END_CATCH): Remove some definitions.
7588         * common/common-exceptions.c: Don't use GDB_XCPT.
7589         (catcher_list_size): Remove.
7590         (throw_exception, throw_it): Simplify.
7591
7592 2019-04-05  Tom Tromey  <tom@tromey.com>
7593
7594         Revert the header-sorting patch.
7595         * ft32-tdep.c: Revert.
7596         * frv-tdep.c: Revert.
7597         * frv-linux-tdep.c: Revert.
7598         * frame.c: Revert.
7599         * frame-unwind.c: Revert.
7600         * frame-base.c: Revert.
7601         * fork-child.c: Revert.
7602         * findvar.c: Revert.
7603         * findcmd.c: Revert.
7604         * filesystem.c: Revert.
7605         * filename-seen-cache.h: Revert.
7606         * filename-seen-cache.c: Revert.
7607         * fbsd-tdep.c: Revert.
7608         * fbsd-nat.h: Revert.
7609         * fbsd-nat.c: Revert.
7610         * f-valprint.c: Revert.
7611         * f-typeprint.c: Revert.
7612         * f-lang.c: Revert.
7613         * extension.h: Revert.
7614         * extension.c: Revert.
7615         * extension-priv.h: Revert.
7616         * expprint.c: Revert.
7617         * exec.h: Revert.
7618         * exec.c: Revert.
7619         * exceptions.c: Revert.
7620         * event-top.c: Revert.
7621         * event-loop.c: Revert.
7622         * eval.c: Revert.
7623         * elfread.c: Revert.
7624         * dwarf2read.h: Revert.
7625         * dwarf2read.c: Revert.
7626         * dwarf2loc.c: Revert.
7627         * dwarf2expr.h: Revert.
7628         * dwarf2expr.c: Revert.
7629         * dwarf2-frame.c: Revert.
7630         * dwarf2-frame-tailcall.c: Revert.
7631         * dwarf-index-write.h: Revert.
7632         * dwarf-index-write.c: Revert.
7633         * dwarf-index-common.c: Revert.
7634         * dwarf-index-cache.h: Revert.
7635         * dwarf-index-cache.c: Revert.
7636         * dummy-frame.c: Revert.
7637         * dtrace-probe.c: Revert.
7638         * disasm.h: Revert.
7639         * disasm.c: Revert.
7640         * disasm-selftests.c: Revert.
7641         * dictionary.c: Revert.
7642         * dicos-tdep.c: Revert.
7643         * demangle.c: Revert.
7644         * dcache.h: Revert.
7645         * dcache.c: Revert.
7646         * darwin-nat.h: Revert.
7647         * darwin-nat.c: Revert.
7648         * darwin-nat-info.c: Revert.
7649         * d-valprint.c: Revert.
7650         * d-namespace.c: Revert.
7651         * d-lang.c: Revert.
7652         * ctf.c: Revert.
7653         * csky-tdep.c: Revert.
7654         * csky-linux-tdep.c: Revert.
7655         * cris-tdep.c: Revert.
7656         * cris-linux-tdep.c: Revert.
7657         * cp-valprint.c: Revert.
7658         * cp-support.c: Revert.
7659         * cp-namespace.c: Revert.
7660         * cp-abi.c: Revert.
7661         * corelow.c: Revert.
7662         * corefile.c: Revert.
7663         * continuations.c: Revert.
7664         * completer.h: Revert.
7665         * completer.c: Revert.
7666         * complaints.c: Revert.
7667         * coffread.c: Revert.
7668         * coff-pe-read.c: Revert.
7669         * cli-out.h: Revert.
7670         * cli-out.c: Revert.
7671         * charset.c: Revert.
7672         * c-varobj.c: Revert.
7673         * c-valprint.c: Revert.
7674         * c-typeprint.c: Revert.
7675         * c-lang.c: Revert.
7676         * buildsym.c: Revert.
7677         * buildsym-legacy.c: Revert.
7678         * build-id.h: Revert.
7679         * build-id.c: Revert.
7680         * btrace.c: Revert.
7681         * bsd-uthread.c: Revert.
7682         * breakpoint.h: Revert.
7683         * breakpoint.c: Revert.
7684         * break-catch-throw.c: Revert.
7685         * break-catch-syscall.c: Revert.
7686         * break-catch-sig.c: Revert.
7687         * blockframe.c: Revert.
7688         * block.c: Revert.
7689         * bfin-tdep.c: Revert.
7690         * bfin-linux-tdep.c: Revert.
7691         * bfd-target.c: Revert.
7692         * bcache.c: Revert.
7693         * ax-general.c: Revert.
7694         * ax-gdb.h: Revert.
7695         * ax-gdb.c: Revert.
7696         * avr-tdep.c: Revert.
7697         * auxv.c: Revert.
7698         * auto-load.c: Revert.
7699         * arm-wince-tdep.c: Revert.
7700         * arm-tdep.c: Revert.
7701         * arm-symbian-tdep.c: Revert.
7702         * arm-pikeos-tdep.c: Revert.
7703         * arm-obsd-tdep.c: Revert.
7704         * arm-nbsd-tdep.c: Revert.
7705         * arm-nbsd-nat.c: Revert.
7706         * arm-linux-tdep.c: Revert.
7707         * arm-linux-nat.c: Revert.
7708         * arm-fbsd-tdep.c: Revert.
7709         * arm-fbsd-nat.c: Revert.
7710         * arm-bsd-tdep.c: Revert.
7711         * arch-utils.c: Revert.
7712         * arc-tdep.c: Revert.
7713         * arc-newlib-tdep.c: Revert.
7714         * annotate.h: Revert.
7715         * annotate.c: Revert.
7716         * amd64-windows-tdep.c: Revert.
7717         * amd64-windows-nat.c: Revert.
7718         * amd64-tdep.c: Revert.
7719         * amd64-sol2-tdep.c: Revert.
7720         * amd64-obsd-tdep.c: Revert.
7721         * amd64-obsd-nat.c: Revert.
7722         * amd64-nbsd-tdep.c: Revert.
7723         * amd64-nbsd-nat.c: Revert.
7724         * amd64-nat.c: Revert.
7725         * amd64-linux-tdep.c: Revert.
7726         * amd64-linux-nat.c: Revert.
7727         * amd64-fbsd-tdep.c: Revert.
7728         * amd64-fbsd-nat.c: Revert.
7729         * amd64-dicos-tdep.c: Revert.
7730         * amd64-darwin-tdep.c: Revert.
7731         * amd64-bsd-nat.c: Revert.
7732         * alpha-tdep.c: Revert.
7733         * alpha-obsd-tdep.c: Revert.
7734         * alpha-nbsd-tdep.c: Revert.
7735         * alpha-mdebug-tdep.c: Revert.
7736         * alpha-linux-tdep.c: Revert.
7737         * alpha-linux-nat.c: Revert.
7738         * alpha-bsd-tdep.c: Revert.
7739         * alpha-bsd-nat.c: Revert.
7740         * aix-thread.c: Revert.
7741         * agent.c: Revert.
7742         * addrmap.c: Revert.
7743         * ada-varobj.c: Revert.
7744         * ada-valprint.c: Revert.
7745         * ada-typeprint.c: Revert.
7746         * ada-tasks.c: Revert.
7747         * ada-lang.c: Revert.
7748         * aarch64-tdep.c: Revert.
7749         * aarch64-ravenscar-thread.c: Revert.
7750         * aarch64-newlib-tdep.c: Revert.
7751         * aarch64-linux-tdep.c: Revert.
7752         * aarch64-linux-nat.c: Revert.
7753         * aarch64-fbsd-tdep.c: Revert.
7754         * aarch64-fbsd-nat.c: Revert.
7755         * aarch32-linux-nat.c: Revert.
7756
7757 2019-04-05  Tom Tromey  <tom@tromey.com>
7758
7759         * ft32-tdep.c: Sort headers.
7760         * frv-tdep.c: Sort headers.
7761         * frv-linux-tdep.c: Sort headers.
7762         * frame.c: Sort headers.
7763         * frame-unwind.c: Sort headers.
7764         * frame-base.c: Sort headers.
7765         * fork-child.c: Sort headers.
7766         * findvar.c: Sort headers.
7767         * findcmd.c: Sort headers.
7768         * filesystem.c: Sort headers.
7769         * filename-seen-cache.h: Sort headers.
7770         * filename-seen-cache.c: Sort headers.
7771         * fbsd-tdep.c: Sort headers.
7772         * fbsd-nat.h: Sort headers.
7773         * fbsd-nat.c: Sort headers.
7774         * f-valprint.c: Sort headers.
7775         * f-typeprint.c: Sort headers.
7776         * f-lang.c: Sort headers.
7777         * extension.h: Sort headers.
7778         * extension.c: Sort headers.
7779         * extension-priv.h: Sort headers.
7780         * expprint.c: Sort headers.
7781         * exec.h: Sort headers.
7782         * exec.c: Sort headers.
7783         * exceptions.c: Sort headers.
7784         * event-top.c: Sort headers.
7785         * event-loop.c: Sort headers.
7786         * eval.c: Sort headers.
7787         * elfread.c: Sort headers.
7788         * dwarf2read.h: Sort headers.
7789         * dwarf2read.c: Sort headers.
7790         * dwarf2loc.c: Sort headers.
7791         * dwarf2expr.h: Sort headers.
7792         * dwarf2expr.c: Sort headers.
7793         * dwarf2-frame.c: Sort headers.
7794         * dwarf2-frame-tailcall.c: Sort headers.
7795         * dwarf-index-write.h: Sort headers.
7796         * dwarf-index-write.c: Sort headers.
7797         * dwarf-index-common.c: Sort headers.
7798         * dwarf-index-cache.h: Sort headers.
7799         * dwarf-index-cache.c: Sort headers.
7800         * dummy-frame.c: Sort headers.
7801         * dtrace-probe.c: Sort headers.
7802         * disasm.h: Sort headers.
7803         * disasm.c: Sort headers.
7804         * disasm-selftests.c: Sort headers.
7805         * dictionary.c: Sort headers.
7806         * dicos-tdep.c: Sort headers.
7807         * demangle.c: Sort headers.
7808         * dcache.h: Sort headers.
7809         * dcache.c: Sort headers.
7810         * darwin-nat.h: Sort headers.
7811         * darwin-nat.c: Sort headers.
7812         * darwin-nat-info.c: Sort headers.
7813         * d-valprint.c: Sort headers.
7814         * d-namespace.c: Sort headers.
7815         * d-lang.c: Sort headers.
7816         * ctf.c: Sort headers.
7817         * csky-tdep.c: Sort headers.
7818         * csky-linux-tdep.c: Sort headers.
7819         * cris-tdep.c: Sort headers.
7820         * cris-linux-tdep.c: Sort headers.
7821         * cp-valprint.c: Sort headers.
7822         * cp-support.c: Sort headers.
7823         * cp-namespace.c: Sort headers.
7824         * cp-abi.c: Sort headers.
7825         * corelow.c: Sort headers.
7826         * corefile.c: Sort headers.
7827         * continuations.c: Sort headers.
7828         * completer.h: Sort headers.
7829         * completer.c: Sort headers.
7830         * complaints.c: Sort headers.
7831         * coffread.c: Sort headers.
7832         * coff-pe-read.c: Sort headers.
7833         * cli-out.h: Sort headers.
7834         * cli-out.c: Sort headers.
7835         * charset.c: Sort headers.
7836         * c-varobj.c: Sort headers.
7837         * c-valprint.c: Sort headers.
7838         * c-typeprint.c: Sort headers.
7839         * c-lang.c: Sort headers.
7840         * buildsym.c: Sort headers.
7841         * buildsym-legacy.c: Sort headers.
7842         * build-id.h: Sort headers.
7843         * build-id.c: Sort headers.
7844         * btrace.c: Sort headers.
7845         * bsd-uthread.c: Sort headers.
7846         * breakpoint.h: Sort headers.
7847         * breakpoint.c: Sort headers.
7848         * break-catch-throw.c: Sort headers.
7849         * break-catch-syscall.c: Sort headers.
7850         * break-catch-sig.c: Sort headers.
7851         * blockframe.c: Sort headers.
7852         * block.c: Sort headers.
7853         * bfin-tdep.c: Sort headers.
7854         * bfin-linux-tdep.c: Sort headers.
7855         * bfd-target.c: Sort headers.
7856         * bcache.c: Sort headers.
7857         * ax-general.c: Sort headers.
7858         * ax-gdb.h: Sort headers.
7859         * ax-gdb.c: Sort headers.
7860         * avr-tdep.c: Sort headers.
7861         * auxv.c: Sort headers.
7862         * auto-load.c: Sort headers.
7863         * arm-wince-tdep.c: Sort headers.
7864         * arm-tdep.c: Sort headers.
7865         * arm-symbian-tdep.c: Sort headers.
7866         * arm-pikeos-tdep.c: Sort headers.
7867         * arm-obsd-tdep.c: Sort headers.
7868         * arm-nbsd-tdep.c: Sort headers.
7869         * arm-nbsd-nat.c: Sort headers.
7870         * arm-linux-tdep.c: Sort headers.
7871         * arm-linux-nat.c: Sort headers.
7872         * arm-fbsd-tdep.c: Sort headers.
7873         * arm-fbsd-nat.c: Sort headers.
7874         * arm-bsd-tdep.c: Sort headers.
7875         * arch-utils.c: Sort headers.
7876         * arc-tdep.c: Sort headers.
7877         * arc-newlib-tdep.c: Sort headers.
7878         * annotate.h: Sort headers.
7879         * annotate.c: Sort headers.
7880         * amd64-windows-tdep.c: Sort headers.
7881         * amd64-windows-nat.c: Sort headers.
7882         * amd64-tdep.c: Sort headers.
7883         * amd64-sol2-tdep.c: Sort headers.
7884         * amd64-obsd-tdep.c: Sort headers.
7885         * amd64-obsd-nat.c: Sort headers.
7886         * amd64-nbsd-tdep.c: Sort headers.
7887         * amd64-nbsd-nat.c: Sort headers.
7888         * amd64-nat.c: Sort headers.
7889         * amd64-linux-tdep.c: Sort headers.
7890         * amd64-linux-nat.c: Sort headers.
7891         * amd64-fbsd-tdep.c: Sort headers.
7892         * amd64-fbsd-nat.c: Sort headers.
7893         * amd64-dicos-tdep.c: Sort headers.
7894         * amd64-darwin-tdep.c: Sort headers.
7895         * amd64-bsd-nat.c: Sort headers.
7896         * alpha-tdep.c: Sort headers.
7897         * alpha-obsd-tdep.c: Sort headers.
7898         * alpha-nbsd-tdep.c: Sort headers.
7899         * alpha-mdebug-tdep.c: Sort headers.
7900         * alpha-linux-tdep.c: Sort headers.
7901         * alpha-linux-nat.c: Sort headers.
7902         * alpha-bsd-tdep.c: Sort headers.
7903         * alpha-bsd-nat.c: Sort headers.
7904         * aix-thread.c: Sort headers.
7905         * agent.c: Sort headers.
7906         * addrmap.c: Sort headers.
7907         * ada-varobj.c: Sort headers.
7908         * ada-valprint.c: Sort headers.
7909         * ada-typeprint.c: Sort headers.
7910         * ada-tasks.c: Sort headers.
7911         * ada-lang.c: Sort headers.
7912         * aarch64-tdep.c: Sort headers.
7913         * aarch64-ravenscar-thread.c: Sort headers.
7914         * aarch64-newlib-tdep.c: Sort headers.
7915         * aarch64-linux-tdep.c: Sort headers.
7916         * aarch64-linux-nat.c: Sort headers.
7917         * aarch64-fbsd-tdep.c: Sort headers.
7918         * aarch64-fbsd-nat.c: Sort headers.
7919         * aarch32-linux-nat.c: Sort headers.
7920
7921 2019-04-04  Tom Tromey  <tom@tromey.com>
7922
7923         * varobj.c (varobj_create): Update.
7924         * rust-exp.y (struct rust_parser) <update_innermost_block,
7925         lookup_symbol>: New methods.
7926         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7927         Rename.
7928         (rust_parser::rust_lookup_type)
7929         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7930         * printcmd.c (display_command, do_one_display): Update.
7931         * parser-defs.h (struct parser_state) <parser_state>: Add
7932         "tracker" parameter.
7933         (block_tracker): New member.
7934         (class innermost_block_tracker) <innermost_block_tracker>: Add
7935         "types" parameter.
7936         <reset>: Remove method.
7937         (innermost_block): Don't declare.
7938         (null_post_parser): Update.
7939         * parse.c (innermost_block): Remove global.
7940         (write_dollar_variable): Update.
7941         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7942         Remove "tracker_types" parameter.
7943         (parse_expression): Add "tracker" parameter.
7944         (parse_expression_for_completion): Update.
7945         (null_post_parser): Add "tracker" parameter.
7946         * p-exp.y: Update rules.
7947         * m2-exp.y: Update rules.
7948         * language.h (struct language_defn) <la_post_parser>: Add
7949         "tracker" parameter.
7950         * go-exp.y: Update rules.
7951         * f-exp.y: Update rules.
7952         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7953         parameter.
7954         * d-exp.y: Update rules.
7955         * c-exp.y: Update rules.
7956         * breakpoint.c (set_breakpoint_condition): Create an
7957         innermost_block_tracker.
7958         (watch_command_1): Likewise.
7959         * ada-lang.c (resolve): Add "tracker" parameter.
7960         (resolve_subexp): Likewise.
7961         * ada-exp.y (write_var_from_sym): Update.
7962
7963 2019-04-04  Tom Tromey  <tom@tromey.com>
7964
7965         * type-stack.h: New file.
7966         * type-stack.c: New file.
7967         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7968         type-stack.h.
7969         (insert_into_type_stack, insert_type, push_type, push_type_int)
7970         (insert_type_address_space, pop_type, pop_type_int)
7971         (pop_typelist, pop_type_stack, append_type_stack)
7972         (push_type_stack, get_type_stack, push_typelist)
7973         (follow_type_instance_flags, follow_types): Don't declare.
7974         * parse.c (type_stack): Remove global.
7975         (parse_exp_in_context): Update.
7976         (insert_into_type_stack, insert_type, push_type, push_type_int)
7977         (insert_type_address_space, pop_type, pop_type_int)
7978         (pop_typelist, pop_type_stack, append_type_stack)
7979         (push_type_stack, get_type_stack, push_typelist)
7980         (follow_type_instance_flags, follow_types): Remove (moved to
7981         type-stack.c).
7982         * f-exp.y (type_stack): New global.
7983         Update rules.
7984         (push_kind_type, f_parse): Update.
7985         * d-exp.y (type_stack): New global.
7986         Update rules.
7987         (d_parse): Update.
7988         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7989         Update rules.
7990         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7991         (HFILES_NO_SRCDIR): Add type-stack.h.
7992
7993 2019-04-04  Tom Tromey  <tom@tromey.com>
7994
7995         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7996         (rust_parser::convert_ast_to_expression, rust_parse)
7997         (rust_lex_test_completion, rust_lex_tests): Update.
7998         * parser-defs.h (struct expr_completion_state): New.
7999         (struct parser_state) <parser_state>: Add completion parameter.
8000         <mark_struct_expression, mark_completion_tag>: New methods.
8001         <parse_completion, m_completion_state>: New members.
8002         (prefixify_expression, null_post_parser): Update.
8003         (mark_struct_expression, mark_completion_tag): Don't declare.
8004         * parse.c (parse_completion, expout_last_struct)
8005         (expout_tag_completion_type, expout_completion_name): Remove
8006         globals.
8007         (parser_state::mark_struct_expression)
8008         (parser_state::mark_completion_tag): Now methods.
8009         (prefixify_expression): Add last_struct parameter.
8010         (prefixify_subexp): Likewise.
8011         (parse_exp_1): Update.
8012         (parse_exp_in_context): Add cstate parameter.  Update.
8013         (parse_expression_for_completion): Create an
8014         expr_completion_state.
8015         (null_post_parser): Add "completion" parameter.
8016         * p-exp.y: Update rules.
8017         (yylex): Update.
8018         * language.h (struct language_defn) <la_post_parser>: Add
8019         "completing" parameter.
8020         * go-exp.y: Update rules.
8021         (lex_one_token): Update.
8022         * expression.h (parse_completion): Don't declare.
8023         * d-exp.y: Update rules.
8024         (lex_one_token): Update rules.
8025         * c-exp.y: Update rules.
8026         (lex_one_token): Update.
8027         * ada-lang.c (resolve): Add "parse_completion" parameter.
8028         (resolve_subexp): Likewise.
8029         (ada_resolve_function): Likewise.
8030
8031 2019-04-04  Tom Tromey  <tom@tromey.com>
8032
8033         * parser-defs.h (struct parser_state) <start_arglist,
8034         end_arglist>: New methods.
8035         <arglist_len, m_funcall_chain>: New members.
8036         (arglist_len, start_arglist, end_arglist): Don't declare.
8037         * parse.c (arglist_len, funcall_chain): Remove global.
8038         (start_arglist, end_arglist): Remove functions.
8039         (parse_exp_in_context): Update.
8040         * p-exp.y: Update rules.
8041         * m2-exp.y: Update rules.
8042         * go-exp.y: Update rules.
8043         * f-exp.y: Update rules.
8044         * d-exp.y: Update rules.
8045         * c-exp.y: Update rules.
8046
8047 2019-04-04  Tom Tromey  <tom@tromey.com>
8048
8049         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8050         lex_operator, push_back>: New methods.
8051         Update all rules.
8052         (rust_parser::lex_hex, lex_escape): Rename and update.
8053         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8054         (rust_parser::lex_operator): Rename and update.
8055         (rust_parser::lex_number, rustyylex, rustyyerror)
8056         (rust_lex_test_init, rust_lex_test_sequence)
8057         (rust_lex_test_push_back, rust_lex_tests): Update.
8058         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8059         parameter.
8060         <lexptr, prev_lexptr>: New members.
8061         (lexptr, prev_lexptr): Don't declare.
8062         * parse.c (lexptr, prev_lexptr): Remove globals.
8063         (parse_exp_in_context): Update.
8064         * p-exp.y (yylex, yyerror): Update.
8065         * m2-exp.y (parse_number, yylex, yyerror): Update.
8066         * go-exp.y (lex_one_token, yyerror): Update.
8067         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8068         * d-exp.y (lex_one_token, yyerror): Update.
8069         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8070         (lex_one_token, yyerror): Update.
8071         * ada-lex.l (YY_INPUT): Update.
8072         (rewind_to_char): Update.
8073         * ada-exp.y (yyerror): Update.
8074
8075 2019-04-04  Tom Tromey  <tom@tromey.com>
8076
8077         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8078         * parser-defs.h (struct parser_state) <parser_state>: Add new
8079         parameter.
8080         <comma_terminates>: New member.
8081         (comma_terminates): Don't declare global.
8082         * parse.c (comma_terminates): Remove global.
8083         (parse_exp_in_context): Update.
8084         * p-exp.y (yylex): Update.
8085         * m2-exp.y (yylex): Update.
8086         * go-exp.y (lex_one_token): Update.
8087         * f-exp.y (yylex): Update.
8088         * d-exp.y (lex_one_token): Update.
8089         * c-exp.y (lex_one_token): Update.
8090         * ada-lex.l: Update.
8091
8092 2019-04-04  Tom Tromey  <tom@tromey.com>
8093
8094         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8095         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8096         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8097         * parser-defs.h (paren_depth): Don't declare.
8098         * parse.c (paren_depth): Remove global.
8099         (parse_exp_in_context): Update.
8100         * p-exp.y (paren_depth): New global.
8101         (pascal_parse): Initialize it.
8102         * m2-exp.y (paren_depth): New global.
8103         (m2_parse): Initialize it.
8104         * go-exp.y (paren_depth): New global.
8105         (go_parse): Initialize it.
8106         * f-exp.y (paren_depth): New global.
8107         (f_parse): Initialize it.
8108         * d-exp.y (paren_depth): New global.
8109         (d_parse): Initialize it.
8110         * c-exp.y (paren_depth): New global.
8111         (c_parse): Initialize it.
8112         * ada-lex.l (paren_depth): New global.
8113         (lexer_init): Initialize it.
8114
8115 2019-04-04  Tom Tromey  <tom@tromey.com>
8116
8117         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8118         (rust_parser::convert_ast_to_type)
8119         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8120         * parser-defs.h (struct parser_state) <parser_state>: Add
8121         parameters.  Initialize new members.
8122         <expression_context_block, expression_context_pc>: New members.
8123         * parse.c (expression_context_block, expression_context_pc):
8124         Remove globals.
8125         (parse_exp_in_context): Update.
8126         * p-exp.y: Update all rules.
8127         (yylex): Update.
8128         * m2-exp.y: Update all rules.
8129         (yylex): Update.
8130         * go-exp.y (yylex): Update.
8131         * f-exp.y (yylex): Update.
8132         * d-exp.y: Update all rules.
8133         (yylex): Update.
8134         * c-exp.y: Update all rules.
8135         (lex_one_token, classify_name, yylex, c_parse): Update.
8136         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8137
8138 2019-04-04  Tom Tromey  <tom@tromey.com>
8139
8140         * gdbarch.h, gdbarch.c: Rebuild.
8141         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8142         * stap-probe.h:
8143         (struct stap_parse_info): Replace "parser_state" with
8144         "expr_builder".
8145         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8146         (parser_state): New class.
8147         * parse.c (expr_builder): Rename.
8148         (expr_builder::release): Rename.
8149         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8150         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8151         (write_exp_elt_longcst, write_exp_elt_floatcst)
8152         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8153         (write_exp_string_vector, write_exp_bitstring)
8154         (write_exp_msymbol, mark_struct_expression)
8155         (write_dollar_variable)
8156         (insert_type_address_space, increase_expout_size): Replace
8157         "parser_state" with "expr_builder".
8158         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8159         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8160         "parser_state" with "expr_builder".
8161
8162 2019-04-04  Tom Tromey  <tom@tromey.com>
8163
8164         * rust-exp.y: Replace "parse_language" with method call.
8165         * p-exp.y:
8166         (yylex): Replace "parse_language" with method call.
8167         * m2-exp.y:
8168         (yylex): Replace "parse_language" with method call.
8169         * go-exp.y (classify_name): Replace "parse_language" with method
8170         call.
8171         * f-exp.y (yylex): Replace "parse_language" with method call.
8172         * d-exp.y (lex_one_token): Replace "parse_language" with method
8173         call.
8174         * c-exp.y:
8175         (lex_one_token, classify_name, yylex): Replace "parse_language"
8176         with method call.
8177         * ada-exp.y (find_primitive_type, type_char)
8178         (type_system_address): Replace "parse_language" with method call.
8179
8180 2019-04-04  Tom Tromey  <tom@tromey.com>
8181
8182         * rust-exp.y: Replace "parse_gdbarch" with method call.
8183         * parse.c (write_dollar_variable, insert_type_address_space):
8184         Replace "parse_gdbarch" with method call.
8185         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8186         call.
8187         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8188         call.
8189         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8190         "parse_gdbarch" with method call.
8191         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8192         with method call.
8193         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8194         "parse_gdbarch" with method call.
8195         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8196         "parse_gdbarch" with method call.
8197         * c-exp.y (parse_type, parse_number, classify_name): Replace
8198         "parse_gdbarch" with method call.
8199         * ada-lex.l: Replace "parse_gdbarch" with method call.
8200         * ada-exp.y (parse_type, find_primitive_type, type_char)
8201         (type_system_address): Replace "parse_gdbarch" with method call.
8202
8203 2019-04-04  Tom Tromey  <tom@tromey.com>
8204
8205         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8206         * stap-probe.c (stap_parse_argument): Update.
8207         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8208         initial_size parameter.
8209         * rust-exp.y (rust_lex_tests): Update.
8210         * parse.c (parser_state): Update.
8211         (parse_exp_in_context): Update.
8212         * parser-defs.h (struct parser_state) <parser_state>: Remove
8213         "initial_size" parameter.
8214
8215 2019-04-04  Tom Tromey  <tom@tromey.com>
8216
8217         * parser-defs.h (increase_expout_size): Don't declare.
8218         * parse.c (increase_expout_size): Now static.
8219
8220 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8221
8222         * gnu-nat.c (gnu_nat_target::wait): Fix
8223         target_waitstatus_to_string call.
8224
8225 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8226
8227         * eval.c (evaluate_subexp_standard): Handle internal functions
8228         during Fortran function call handling.
8229
8230 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8231
8232         * NEWS: Mention new internal functions.
8233         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8234         (read_base_type): Use dwarf2_init_complex_target_type.
8235         * value.c (creal_internal_fn): New function.
8236         (cimag_internal_fn): New function.
8237         (_initialize_values): Register new internal functions.
8238
8239 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8240
8241         * infrun.c (stop_all_threads): If debug_infrun, always
8242         trace the wait status after wait_one, using
8243         target_waitstatus_to_string and target_pid_to_str.
8244         (handle_inferior_event): Replace various trace of
8245         wait status kind by a single trace.
8246         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8247         wait status kind image by target_waitstatus_to_string.
8248         * target/waitstatus.c (target_waitstatus_to_string): Fix
8249         obsolete comment.
8250
8251 2019-04-01  Tom Tromey  <tromey@adacore.com>
8252
8253         PR symtab/23331:
8254         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8255
8256 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8257             Pedro Alves  <palves@redhat.com>
8258
8259         * top.c (quit_force): Call 'finalize_values'.
8260         * value.c (finalize_values): New function.
8261         * value.h (finalize_values): Declare.
8262
8263 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8264
8265         * NEWS: Announce $_gdb_major and $_gdb_minor.
8266
8267         * top.c (init_gdb_version_vars): New function.
8268         (gdb_init): Call init_gdb_version_vars.
8269
8270 2019-03-29  Tom Tromey  <tromey@adacore.com>
8271
8272         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8273         help text.  Remove dead code.
8274
8275 2019-03-29  Keith Seitz  <keiths@redhat.com>
8276
8277         From Siddhesh Poyarekar:
8278         * f-lang.h (f77_get_upperbound): Return LONGEST.
8279         (f77_get_lowerbound): Likewise.
8280         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8281         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8282         print them.
8283         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8284         plongest to format print it.
8285         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8286         (f77_get_upperbound): Likewise.
8287         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8288         LOWER_BOUND to LONGEST.
8289         (f77_create_arrayprint_offset_tbl): Likewise.
8290
8291 2019-03-29  Keith Seitz  <keiths@redhat.com>
8292
8293         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8294         %s/pulongest for TYPE_LENGTH instead of %d in format
8295         strings.
8296         * ada-typerint.c (ada_print_type): Likewise.
8297         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8298         * compile/compile-c-support.c (generate_register_struct): Likewise.
8299         * gdbtypes.c (recursive_dump_type): Likewise.
8300         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8301         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8302         instead of %d in format strings.
8303         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8304         to std::min to ULONGEST.
8305         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8306         instead of %d in format strings.
8307         * tracepoint.c (info_scope_command): Likewise.
8308         * typeprint.c (print_offset_data::update)
8309         (print_offset_data::finish): Likewise.
8310         * xtensa-tdep.c (xtensa_store_return_value)
8311         (xtensa_push_dummy_call): Likewise.
8312
8313 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8314
8315         * windows-nat.c (display_selector): Fixed format specifications
8316         for 64-bit Cygwin.
8317
8318 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8319
8320         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8321
8322 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8323
8324         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8325         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8326         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8327         (nios2_linux_init_abi): Install it.
8328
8329 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8330
8331         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8332
8333 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8334
8335         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8336
8337 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8338             Tom Tromey  <tromey@adacore.com>
8339
8340         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8341
8342 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8343
8344         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8345         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8346         method to compute the bounds of range types. Also print "[evaluated]"
8347         if the bounds' values come from a dynamic evaluation.
8348
8349 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8350
8351         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8352         whitespace when pretty printing is on.
8353
8354 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8355
8356         * ppc-linux-nat.c: Add include.
8357
8358 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8359
8360         * NEWS: Mention AArch64 Pointer Authentication.
8361
8362 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8363
8364         * arm-linux-nat.c: Add include.
8365
8366 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8367
8368         * source-cache.c (source_cache::get_source_lines): Re-read
8369         fullname after calling open_source_file.
8370
8371 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8372
8373         * NEWS: Mention TLS support for FreeBSD.
8374
8375 2019-03-25  Tom Tromey  <tromey@adacore.com>
8376
8377         * minsyms.c (BUNCH_SIZE): Update comment.
8378         (~minimal_symbol_reader): Remove old comment.
8379         (compact_minimal_symbols): Update comment.
8380         (minimal_symbol_reader::install): Remove old comment.  Update
8381         other comments.
8382
8383 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8384
8385         * s390-linux-nat.c: Add include.
8386
8387 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8388
8389         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8390         Call linux_get_hwcap.
8391         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8392         Likewise.
8393         (aarch64_linux_get_hwcap): Remove function.
8394         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8395         declaration.
8396         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8397         linux_get_hwcap.
8398         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8399         * linux-tdep.c (linux_get_hwcap): Add function.
8400         (linux_get_hwcap2): Likewise.
8401         * linux-tdep.h (linux_get_hwcap): Add declaration.
8402         (linux_get_hwcap2): Likewise.
8403         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8404         (ppc_linux_get_hwcap2): Likewise.
8405         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8406         linux_get_hwcap.
8407         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8408         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8409         (ppc_linux_nat_target::read_description): Likewise.
8410         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8411         * s390-linux-nat.c: Likewise.
8412         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8413
8414 2019-03-24  Tom Tromey  <tom@tromey.com>
8415
8416         * ada-lang.c (standard_lookup): Simplify initialization.
8417         (ada_lookup_symbol_nonlocal): Simplify return.
8418         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8419         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8420         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8421         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8422         initialization.
8423         * solib.c (solib_global_lookup): Simplify.
8424         * symtab.c (null_block_symbol): Remove.
8425         (symbol_cache_lookup): Simplify returns.
8426         (lookup_language_this): Simplify returns.
8427         (lookup_symbol_aux): Simplify return.
8428         (lookup_local_symbol): Simplify returns.
8429         (lookup_global_symbol_from_objfile): Simplify return.
8430         (lookup_symbol_in_objfile_symtabs)
8431         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8432         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8433         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8434         * cp-namespace.c (cp_lookup_bare_symbol)
8435         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8436         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8437         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8438         (cp_lookup_symbol_via_imports): Simplify initialization.
8439         (find_symbol_in_baseclass): Likewise.
8440         * symtab.h (null_block_symbol): Remove.
8441         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8442         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8443         (d_lookup_symbol_module): Likewise.
8444         (find_symbol_in_baseclass): Simplify initialization.
8445
8446 2019-03-24  Tom Tromey  <tom@tromey.com>
8447
8448         * expression.h: Don't include symtab.h.
8449         (struct block): Forward declare.
8450
8451 2019-03-24  Tom Tromey  <tom@tromey.com>
8452
8453         * c-exp.y (typebase): Remove casts.
8454         * gdbtypes.c (lookup_unsigned_typename, )
8455         (lookup_signed_typename): Remove cast.
8456         * eval.c (parse_to_comma_and_eval): Remove cast.
8457         * parse.c (write_dollar_variable): Remove cast.
8458         * block.h (struct block) <superblock>: Now const.
8459         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8460         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8461         (map_block): Make "block" const.
8462         * symfile.h (struct quick_symbol_functions)
8463         <map_matching_symbols>: Constify block argument to "callback".
8464         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8465         const.
8466         (find_pc_sect_compunit_symtab): Make "b" const.
8467         (find_symbol_at_address): Likewise.
8468         (search_symbols): Likewise.
8469         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8470         (dw2_debug_names_lookup_symbol): Likewise.
8471         (dw2_map_matching_symbols): Update.
8472         * p-valprint.c (pascal_val_print): Remove "block".
8473         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8474         (aux_add_nonlocal_symbols): Make "block" const.
8475         (resolve_subexp): Remove cast.
8476         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8477         const.
8478         (iterate_over_file_blocks): Likewise.
8479         * f-exp.y (%union) <bval>: Remove.
8480         * coffread.c (patch_opaque_types): Make "b" const.
8481         * spu-tdep.c (spu_catch_start): Make "block" const.
8482         * c-valprint.c (print_unpacked_pointer): Remove "block".
8483         * symmisc.c (dump_symtab_1): Make "b" const.
8484         (block_depth): Make "block" const.
8485         * d-exp.y (%union) <bval>: Remove.
8486         * cp-support.h (cp_lookup_rtti_type): Update.
8487         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8488         * psymtab.c (psym_lookup_symbol): Make "block" const.
8489         (maintenance_check_psymtabs): Make "b" const.
8490         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8491         (enumerate_locals, enumerate_args): Update.
8492         * python/py-symtab.c (stpy_global_block): Make "block" const.
8493         (stpy_static_block): Likewise.
8494         * inline-frame.c (block_starting_point_at): Make "new_block"
8495         const.
8496         * block.c (find_block_in_blockvector): Make return type const.
8497         (blockvector_for_pc_sect): Make "b" const.
8498         (find_block_in_blockvector): Make "b" const.
8499
8500 2019-03-23  Tom Tromey  <tom@tromey.com>
8501
8502         * varobj.c (varobj_create): Update.
8503         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8504         * printcmd.c (display_command, do_one_display): Don't reset
8505         innermost_block.
8506         * parser-defs.h (enum innermost_block_tracker_type): Move to
8507         expression.h.
8508         (innermost_block): Update comment.
8509         * parse.c (parse_exp_1): Add tracker_types parameter.
8510         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8511         tracker_types parameter.  Reset innermost_block.
8512         (parse_exp_in_context): Remove.
8513         (parse_expression_for_completion): Update.
8514         * objfiles.c (~objfile): Don't reset expression_context_block or
8515         innermost_block.
8516         * expression.h (enum innermost_block_tracker_type): Move from
8517         parser-defs.h.
8518         (parse_exp_1): Add tracker_types parameter.
8519         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8520         reset innermost_block.
8521
8522 2019-03-23  Tom Tromey  <tom@tromey.com>
8523
8524         * objfiles.h: Include bcache.h.
8525
8526 2019-03-23  Tom Tromey  <tom@tromey.com>
8527
8528         * linespec.c (get_current_search_block): Use
8529         scoped_restore_current_language.
8530         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8531
8532 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8533             Jiong Wang  <jiong.wang@arm.com>
8534
8535         * aarch64-linux-tdep.c
8536         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8537         section.
8538         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8539
8540 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8541             Jiong Wang  <jiong.wang@arm.com>
8542
8543         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8544         instructions.
8545         (aarch64_analyze_prologue_test): Add PACIASP test.
8546         (aarch64_prologue_prev_register): Unmask PC value.
8547
8548 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8549             Jiong Wang  <jiong.wang@arm.com>
8550
8551         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8552         (aarch64_dwarf2_prev_register): Unmask PC value.
8553         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8554         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8555         DW_CFA_AARCH64_negate_ra_state.
8556         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8557
8558 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8559             Jiong Wang  <jiong.wang@arm.com>
8560
8561         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8562         registers.
8563         (aarch64_pseudo_register_name): Likewise.
8564         (aarch64_pseudo_register_type): Likewise.
8565         (aarch64_pseudo_register_reggroup_p): Likewise.
8566         (aarch64_gdbarch_init): Add pauth registers.
8567         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8568         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8569         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8570         (struct gdbarch_tdep): Add regnum for ra_state.
8571
8572 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8573             Jiong Wang  <jiong.wang@arm.com>
8574
8575         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8576
8577 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8578             Jiong Wang  <jiong.wang@arm.com>
8579
8580         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8581         function.
8582         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8583         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8584         (aarch64_gdbarch_init): Add puth registers.
8585         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8586         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8587         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8588
8589 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8590             Jiong Wang  <jiong.wang@arm.com>
8591
8592         * aarch64-linux-nat.c
8593         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8594         * aarch64-linux-tdep.c
8595         (aarch64_linux_core_read_description): Likewise.
8596         (aarch64_linux_get_hwcap): New function.
8597         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8598         (aarch64_linux_get_hwcap): New declaration.
8599
8600 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8601             Jiong Wang  <jiong.wang@arm.com>
8602
8603         * aarch64-linux-nat.c
8604         (aarch64_linux_nat_target::read_description): Add pauth param.
8605         * aarch64-linux-tdep.c
8606         (aarch64_linux_core_read_description): Likewise.
8607         * aarch64-tdep.c (struct target_desc): Add in pauth.
8608         (aarch64_read_description): Add pauth param.
8609         (aarch64_gdbarch_init): Likewise.
8610         * aarch64-tdep.h (aarch64_read_description): Likewise.
8611         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8612         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8613         * features/Makefile: Add new files.
8614         * features/aarch64-pauth.c: New file.
8615         * features/aarch64-pauth.xml: New file.
8616
8617 2019-03-20  Tom Tromey  <tromey@adacore.com>
8618
8619         * infrun.c (handle_inferior_event): Rename from
8620         handle_inferior_event_1.  Create a scoped_value_mark.
8621         (handle_inferior_event): Remove.
8622
8623 2019-03-19  Tom Tromey  <tromey@adacore.com>
8624
8625         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8626         * infrun.h (print_stop_event): Add "displays" parameter.
8627         * infrun.c (print_stop_event): Add "displays" parameter.
8628
8629 2019-03-19  Pedro Alves  <palves@redhat.com>
8630
8631         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8632         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8633         to -1.  Fix TABs vs spaces.
8634         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8635         * tui/tui-out.h (tui_ui_out) Add intro comments.
8636         <m_line, m_start_of_line>: In-class initialize, and add describing
8637         comment.
8638
8639 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8640
8641         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8642         variable names.
8643         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8644
8645 2019-03-18  Pedro Alves  <palves@redhat.com>
8646             Eli Zaretskii <eliz@gnu.org>
8647
8648         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8649         m_line and m_start_of_line.
8650
8651 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8652
8653         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8654         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8655         it returns a newline.  This fixes a regression in TU mode, whereby
8656         the next line is output on the same screen line as the user input.
8657
8658 2019-03-18  Tom Tromey  <tromey@adacore.com>
8659
8660         * minsyms.c (minimal_symbol_reader::install): Remove call to
8661         obstack_blank.
8662
8663 2019-03-18  Pedro Alves  <palves@redhat.com>
8664
8665         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8666         New globals.
8667         (apply_style): New, factored out from ...
8668         (apply_ansi_escape): ... this.  Handle reverse video mode.
8669         (tui_set_reverse_mode): New function.
8670         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8671         * tui/tui-winsource.c (tui_show_source_line): Use
8672         tui_set_reverse_mode instead of setting A_STANDOUT.
8673         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8674         New setter methods.
8675
8676 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8677
8678         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8679         Handle tabs.
8680
8681 2019-03-18  Tom Tromey  <tromey@adacore.com>
8682
8683         * ada-lang.c (empty_array): Add "high" parameter.
8684         (ada_evaluate_subexp): Update.
8685
8686 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8687
8688         * unittests/string_view-selftests.c: Define
8689         _initialize_string_view_selftests unconditionally.
8690
8691 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8692
8693         PR gdb/24350
8694         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8695
8696 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8697
8698         PR gdb/24351
8699         * windows-nat.c (display_selector): Fix format specifiers.
8700
8701 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8702
8703         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8704         tui_refill_source_window instead of tui_refresh_win, to update the
8705         current execution line.  This fixes redisplay of the current line
8706         when stepping through the code with "next" or "step".
8707
8708 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8709
8710         * source-cache.c (source_cache::get_source_lines): Call
8711         find_source_lines to initialize s->nlines.  This fixes vertical
8712         scrolling of TUI source window when the DOWN arrow is pressed.
8713
8714 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8715
8716         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8717         linux-thread-db.c (_initialize_thread_db): Likewise.
8718
8719 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8720
8721         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8722         wclrtoeol in tui_show_source_line".  This reverts changes made in
8723         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8724
8725 2019-03-15  Tom Tromey  <tom@tromey.com>
8726
8727         * symtab.h (struct minimal_symbol): Derive from
8728         general_symbol_info.
8729         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8730         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8731         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8732         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8733         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8734         (MSYMBOL_SEARCH_NAME): Update.
8735         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8736         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8737         * minsyms.c (minimal_symbol_reader::record_full): Update.
8738
8739 2019-03-15  Tom Tromey  <tom@tromey.com>
8740
8741         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8742
8743 2019-03-15  Tom Tromey  <tom@tromey.com>
8744
8745         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8746         unique_xmalloc_ptr.
8747         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8748         Update.
8749         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8750         (build_minimal_symbol_hash_tables)
8751         (minimal_symbol_reader::install): Update.
8752
8753 2019-03-15  Tom Tromey  <tom@tromey.com>
8754
8755         * symtab.c (create_demangled_names_hash): Update.
8756         (symbol_set_names): Update.
8757         * objfiles.h (struct objfile_per_bfd_storage)
8758         <demangled_names_hash>: Now an htab_up.
8759         * objfiles.c (objfile_per_bfd_storage): Simplify.
8760
8761 2019-03-15  Tom Tromey  <tom@tromey.com>
8762
8763         * objfiles.h (struct objfile_per_bfd_storage): Declare
8764         destructor.
8765         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8766         New.
8767         (get_objfile_bfd_data): Use new.  Don't initialize
8768         language_of_main.
8769         (free_objfile_per_bfd_storage): Remove.
8770         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8771
8772 2019-03-15  Tom Tromey  <tom@tromey.com>
8773
8774         * symfile.c (reread_symbols): Update.
8775         * objfiles.c (objfile::objfile): Update.
8776         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8777         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8778         comment.
8779         (minimal_symbol_reader::install): Update.
8780         (terminate_minimal_symbol_table): Remove.
8781         * jit.c (jit_object_close_impl): Update.
8782
8783 2019-03-15  Tom Tromey  <tom@tromey.com>
8784
8785         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8786         initializations.
8787
8788 2019-03-15  Tom Tromey  <tom@tromey.com>
8789
8790         * objfiles.h (struct objfile_per_bfd_storage)
8791         <demangled_hash_languages>: Now a bitset.
8792         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8793         (lookup_minimal_symbol): Update.
8794
8795 2019-03-15  Tom Tromey  <tom@tromey.com>
8796
8797         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8798         Don't return the symbol.
8799         * coffread.c (record_minimal_symbol): Use record_full.
8800
8801 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8802
8803         The MS-Windows port of ncurses fails to switch to a color pair if
8804         one or both of the colors are the implicit default colors.  This
8805         change records the default colors when TUI is initialized, and
8806         then specifies them explicitly when a color pair uses the default
8807         colors.  This allows color styling in TUI mode on MS-Windows.
8808
8809         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8810         ncurses_norm_attr.
8811         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8812         colors in ncurses_norm_attr.
8813         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8814         "none", replace it with the default color recorded in
8815         ncurses_norm_attr.
8816
8817 2019-03-14  Tom Tromey  <tromey@adacore.com>
8818
8819         * source-cache.h (class source_cache) <get_source_lines>: Return
8820         std::string.
8821         * source-cache.c (source_cache::extract_lines): Handle case where
8822         first_pos==npos.  Return std::string.
8823         (source_cache::get_source_lines): Update.
8824
8825 2019-03-14  Tom Tromey  <tromey@adacore.com>
8826
8827         * NEWS: Add item for "style sources" commands.
8828         * source-cache.c (source_cache::get_source_lines): Check
8829         source_styling.
8830         * cli/cli-style.c (source_styling): New global.
8831         (_initialize_cli_style): Add "style sources" commands.
8832         (show_style_sources): New function.
8833         * cli/cli-style.h (source_styling): Declare.
8834
8835 2019-03-14  Pedro Alves  <palves@redhat.com>
8836             Tom Tromey  <tromey@adacore.com>
8837
8838         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8839         * tui/tui-winsource.c (tui_refill_source_window): New function,
8840         from...
8841         (tui_horizontal_source_scroll): ... here.  Move some logic.
8842         * cli/cli-style.c (set_style_enabled): Notify new observable.
8843         * tui/tui-hooks.c (tui_redisplay_source): New function.
8844         (tui_attach_detach_observers): Attach or detach
8845         tui_redisplay_source.
8846         * observable.h (source_styling_changed): New observable.
8847         * observable.c: Define source_styling_changed observable.
8848
8849 2019-03-13  Tom Tromey  <tromey@adacore.com>
8850
8851         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8852         (i386_gnu_nat_target::store_registers): Update.
8853         * target-debug.h (target_debug_print_std_string): New macro.
8854         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8855         * windows-tdep.c (display_one_tib): Update.
8856         * tui/tui-stack.c (tui_make_status_line): Update.
8857         * top.c (print_inferior_quit_action): Update.
8858         * thread.c (thr_try_catch_cmd): Update.
8859         (add_thread_with_info): Update.
8860         (thread_target_id_str): Update.
8861         (thr_try_catch_cmd): Update.
8862         (thread_command): Update.
8863         (thread_find_command): Update.
8864         * record-btrace.c (record_btrace_target::info_record)
8865         (record_btrace_resume_thread, record_btrace_target::resume)
8866         (record_btrace_cancel_resume, record_btrace_step_thread)
8867         (record_btrace_target::wait, record_btrace_target::wait)
8868         (record_btrace_target::wait, record_btrace_target::stop): Update.
8869         * progspace.c (print_program_space): Update.
8870         * process-stratum-target.c
8871         (process_stratum_target::thread_address_space): Update.
8872         * linux-fork.c (linux_fork_mourn_inferior)
8873         (detach_checkpoint_command, info_checkpoints_command)
8874         (linux_fork_context): Update.
8875         (linux_fork_detach): Update.
8876         (class scoped_switch_fork_info): Update.
8877         (delete_checkpoint_command): Update.
8878         * infrun.c (follow_fork_inferior): Update.
8879         (follow_fork_inferior): Update.
8880         (proceed_after_vfork_done): Update.
8881         (handle_vfork_child_exec_or_exit): Update.
8882         (follow_exec): Update.
8883         (displaced_step_prepare_throw): Update.
8884         (displaced_step_restore): Update.
8885         (start_step_over): Update.
8886         (resume_1): Update.
8887         (clear_proceed_status_thread): Update.
8888         (proceed): Update.
8889         (print_target_wait_results): Update.
8890         (do_target_wait): Update.
8891         (context_switch): Update.
8892         (stop_all_threads): Update.
8893         (restart_threads): Update.
8894         (finish_step_over): Update.
8895         (handle_signal_stop): Update.
8896         (switch_back_to_stepped_thread): Update.
8897         (keep_going_pass_signal): Update.
8898         (print_exited_reason): Update.
8899         (normal_stop): Update.
8900         * inferior.c (inferior_pid_to_str): Change return type.
8901         (print_selected_inferior): Update.
8902         (add_inferior): Update.
8903         (detach_inferior): Update.
8904         * dummy-frame.c (fprint_dummy_frames): Update.
8905         * dcache.c (dcache_info_1): Update.
8906         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8907         (btrace_fetch, btrace_clear): Update.
8908         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8909         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8910         type.
8911         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8912         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8913         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8914         * gdbarch.c, gdbarch.h: Rebuild.
8915         * gdbarch.sh (core_pid_to_str): Change return type.
8916         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8917         return type.
8918         (windows_nat_target::pid_to_str): Change return type.
8919         (windows_delete_thread): Update.
8920         (windows_nat_target::attach): Update.
8921         (windows_nat_target::files_info): Update.
8922         * target-delegates.c: Rebuild.
8923         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8924         return type.
8925         (sol_thread_target::pid_to_str): Change return type.
8926         * remote.c (class remote_target) <pid_to_str>: Change return
8927         type.
8928         (remote_target::pid_to_str): Change return type.
8929         (extended_remote_target::attach, remote_target::remote_stop_ns)
8930         (remote_target::remote_notif_remove_queued_reply)
8931         (remote_target::push_stop_reply, remote_target::disable_btrace):
8932         Update.
8933         (extended_remote_target::attach): Update.
8934         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8935         type.
8936         (gdbsim_target::pid_to_str): Change return type.
8937         * ravenscar-thread.c (struct ravenscar_thread_target)
8938         <pid_to_str>: Change return type.
8939         (ravenscar_thread_target::pid_to_str): Change return type.
8940         * procfs.c (class procfs_target) <pid_to_str>: Change return
8941         type.
8942         (procfs_target::pid_to_str): Change return type.
8943         (procfs_target::attach): Update.
8944         (procfs_target::detach): Update.
8945         (procfs_target::fetch_registers): Update.
8946         (procfs_target::store_registers): Update.
8947         (procfs_target::wait): Update.
8948         (procfs_target::files_info): Update.
8949         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8950         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8951         return type.
8952         (nto_procfs_target::pid_to_str): Change return type.
8953         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8954         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8955         return type.
8956         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8957         (exit_lwp): Update.
8958         (attach_proc_task_lwp_callback, get_detach_signal)
8959         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8960         (linux_nat_target::resume, wait_lwp, stop_callback)
8961         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8962         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8963         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8964         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8965         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8966         type.
8967         (inf_ptrace_target::attach): Update.
8968         (inf_ptrace_target::files_info): Update.
8969         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8970         type.
8971         (go32_nat_target::pid_to_str): Change return type.
8972         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8973         (gnu_nat_target::wait): Update.
8974         (gnu_nat_target::wait): Update.
8975         (gnu_nat_target::resume): Update.
8976         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8977         (fbsd_nat_target::wait): Update.
8978         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8979         type.
8980         (darwin_nat_target::attach): Update.
8981         * corelow.c (class core_target) <pid_to_str>: Change return type.
8982         (core_target::pid_to_str): Change return type.
8983         * target.c (normal_pid_to_str): Change return type.
8984         (default_pid_to_str): Likewise.
8985         (target_pid_to_str): Change return type.
8986         (target_translate_tls_address): Update.
8987         (target_announce_detach): Update.
8988         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8989         return type.
8990         (bsd_uthread_target::pid_to_str): Change return type.
8991         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8992         type.
8993         (bsd_kvm_target::pid_to_str): Change return type.
8994         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8995         return type.
8996         (aix_thread_target::pid_to_str): Change return type.
8997         * target.h (struct target_ops) <pid_to_str>: Change return type.
8998         (target_pid_to_str, normal_pid_to_str): Likewise.
8999         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9000         type.
9001         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9002         type.
9003         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9004         return type.
9005         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9006         type.
9007         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9008         type.
9009         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9010         return type.
9011
9012 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9013
9014         * NEWS: Mention that the new default MI version is 3.  Mention
9015         changes to the output of commands and events that deal with
9016         multi-location breakpoints.
9017         * breakpoint.c: Include "mi/mi-out.h".
9018         (print_one_breakpoint): Change output syntax if using MI version
9019         >= 3.
9020         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9021         New.
9022         (mi_multi_location_breakpoint_output_fixed): New.
9023         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9024         (mi_cmd_fix_multi_location_breakpoint_output): New.
9025         (mi_multi_location_breakpoint_output_fixed): New.
9026         * mi/mi-cmds.c (mi_cmds): Register command
9027         -fix-multi-location-breakpoint-output.
9028         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9029         interpreter "mi".
9030
9031 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9032
9033         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9034         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9035         instantiate mi_ui_out based on interpreter name.
9036         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9037         * mi/mi-main.c (mi_load_progress): Likewise.
9038
9039 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9040
9041         * NEWS: Combine separate "New targets" sections for 8.3.
9042
9043 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9044
9045         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9046         (ppcfbsd_init_abi): Install gdbarch
9047         "fetch_tls_load_module_address" and "get_thread_local_address"
9048         methods.
9049
9050 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9051
9052         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9053         (riscv_fbsd_init_abi): Install gdbarch
9054         "fetch_tls_load_module_address" and "get_thread_local_address"
9055         methods.
9056
9057 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9058
9059         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9060         (i386fbsd_init_abi): Install gdbarch
9061         "fetch_tls_load_module_address" and "get_thread_local_address"
9062         methods.
9063
9064 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9065
9066         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9067         (amd64fbsd_init_abi): Install gdbarch
9068         "fetch_tls_load_module_address" and "get_thread_local_address"
9069         methods.
9070
9071 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9072
9073         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9074         (struct fbsd_pspace_data): New type.
9075         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9076         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9077         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9078         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9079         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9080
9081 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9082
9083         * gdbtypes.c (lookup_struct_elt): New function.
9084         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9085         * gdbtypes.h (struct struct_elt): New type.
9086         (lookup_struct_elt): New prototype.
9087
9088 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9089
9090         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9091         remove disabled code block.
9092
9093 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9094
9095         * gdbarch.sh (get_thread_local_address): New method.
9096         * gdbarch.h, gdbarch.c: Regenerate.
9097         * target.c (target_translate_tls_address): Use
9098         gdbarch_get_thread_local_address if present instead of
9099         target::get_thread_local_address.
9100
9101 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9102
9103         * target.h (target::get_thread_local_address): Update comment.
9104
9105 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9106
9107         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9108         objfile->separate_debug_objfile_backlink if not NULL.
9109
9110 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9111
9112         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9113         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9114         (amd64bsd_store_inferior_registers): Likewise.
9115         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9116         Enable segment base registers.
9117         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9118         PT_GETFSBASE and PT_GETGSBASE.
9119         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9120         PT_SETGSBASE.
9121         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9122         segment base registers.
9123         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9124
9125 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9126
9127         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9128         Update calls to i386_target_description to add 'segments'
9129         parameter.
9130         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9131         add segment base registers.
9132         * arch/i386.c (i386_create_target_description): Add 'segments'
9133         parameter to enable segment base registers.
9134         * arch/i386.h (i386_create_target_description): Likewise.
9135         * features/i386/32bit-segments.xml: New file.
9136         * features/i386/32bit-segments.c: Generate.
9137         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9138         call to i386_target_description to add 'segments' parameter.
9139         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9140         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9141         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9142         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9143         if feature is present.
9144         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9145         Add 'segments' parameter to call to i386_target_description.
9146         (i386_target_description): Add 'segments' parameter to enable
9147         segment base registers.
9148         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9149         to call to i386_target_description.
9150         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9151         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9152         Define I386_NUM_REGS.
9153         (i386_target_description): Add 'segments' parameter to enable
9154         segment base registers.
9155
9156 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9157
9158         PR/24325
9159         * source-cache.c: #undef open and close, to avoid unresolved
9160         externals during linking.
9161
9162 2019-03-12  Tom Tromey  <tromey@adacore.com>
9163
9164         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9165         const.  Add initializers.
9166         (_initialize_remote): Don't initialize ptid globals.
9167
9168 2019-03-12  Pedro Alves  <palves@redhat.com>
9169
9170         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9171
9172 2019-03-12  Pedro Alves  <palves@redhat.com>
9173
9174         * cp-name-parser.y (main): Remove unused 'len' variable.
9175
9176 2019-03-12  Tom Tromey  <tromey@adacore.com>
9177
9178         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9179         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9180
9181 2019-03-12  Tom Tromey  <tromey@adacore.com>
9182
9183         * linux-nat.c (iterate_over_lwps): Update.
9184         (stop_callback): Remove parameter.
9185         (stop_wait_callback, detach_callback, resume_set_callback)
9186         (select_singlestep_lwp_callback, set_ignore_sigint)
9187         (status_callback, resumed_callback, resume_clear_callback)
9188         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9189         data parameter.
9190         (linux_nat_target::detach, linux_nat_target::resume)
9191         (linux_stop_and_wait_all_lwps, select_event_lwp)
9192         (linux_nat_filter_event, linux_nat_wait_1)
9193         (linux_nat_target::kill, linux_nat_target::stop)
9194         (linux_nat_target::stop): Update.
9195         (linux_nat_resume_callback): Change type.
9196         (resume_stopped_resumed_lwps, count_events_callback)
9197         (select_event_lwp_callback): Likewise.
9198         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9199         * arm-linux-nat.c (struct update_registers_data): Remove.
9200         (update_registers_callback): Change type.
9201         (arm_linux_insert_hw_breakpoint1): Update.
9202         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9203         parameter.
9204         (x86_linux_dr_set_addr): Update.
9205         (x86_linux_dr_set_control): Update.
9206         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9207         (iterate_over_lwps): Use gdb::function_view.
9208         * nat/aarch64-linux-hw-point.c (struct
9209         aarch64_dr_update_callback_param): Remove.
9210         (debug_reg_change_callback): Change type.
9211         (aarch64_notify_debug_reg_change): Update.
9212         * s390-linux-nat.c (s390_refresh_per_info): Update.
9213
9214 2019-03-11  Tom Tromey  <tromey@adacore.com>
9215
9216         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9217         redundant assignment to "this_cu".
9218
9219 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9220
9221         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9222
9223 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9224
9225         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9226         from...
9227         (rank_one_type): ... this.
9228
9229 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9230
9231         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9232         from...
9233         (rank_one_type): ... this.
9234
9235 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9236
9237         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9238         from...
9239         (rank_one_type): ... this.
9240
9241 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9242
9243         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9244         from...
9245         (rank_one_type): ... this.
9246
9247 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9248
9249         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9250         from...
9251         (rank_one_type): ... this.
9252
9253 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9254
9255         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9256         from...
9257         (rank_one_type): ... this.
9258
9259 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9260
9261         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9262         from...
9263         (rank_one_type): ... this.
9264
9265 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9266
9267         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9268         from...
9269         (rank_one_type): ... this.
9270
9271 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9272
9273         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9274         from...
9275         (rank_one_type): ... this.
9276
9277 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9278
9279         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9280         from...
9281         (rank_one_type): ... this.
9282
9283 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9284
9285         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9286         from...
9287         (rank_one_type): ... this.
9288
9289 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9290
9291         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9292         from...
9293         (rank_one_type): ... this.
9294
9295 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9296
9297         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9298         inferior-events' shows the example events.
9299
9300 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9301
9302         Support styling on native MS-Windows console
9303
9304         PR/24315
9305         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9306         on MS-Windows if $TERM is not defined.
9307
9308         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9309
9310         * posix-hdep.c (gdb_console_fputs):
9311         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9312         functions.
9313         * ui-file.h (gdb_console_fputs): Add prototype.
9314
9315         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9316         back to fputs only if the former returns zero.
9317
9318 2019-03-07  Tom Tromey  <tom@tromey.com>
9319
9320         * symmisc.c (print_symbol_bcache_statistics): Update.
9321         (print_objfile_statistics): Update.
9322         * symfile.c (allocate_symtab): Update.
9323         * stabsread.c: Don't include bcache.h.
9324         * psymtab.h (struct psymbol_bcache): Don't declare.
9325         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9326         (psymbol_bcache_init, psymbol_bcache_free)
9327         (psymbol_bcache_get_bcache): Don't declare.
9328         * psymtab.c (struct psymbol_bcache): Remove.
9329         (psymtab_storage::psymtab_storage): Update.
9330         (psymtab_storage::~psymtab_storage): Update.
9331         (psymbol_bcache_init, psymbol_bcache_free)
9332         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9333         (add_psymbol_to_bcache): Update.
9334         (allocate_psymtab): Update.
9335         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9336         macro_cache>: No longer pointers.
9337         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9338         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9339         * macrotab.c (macro_bcache): Update.
9340         * macroexp.c: Don't include bcache.h.
9341         * gdbtypes.c (check_types_worklist): Update.
9342         (types_deeply_equal): Remove TRY/CATCH.  Update.
9343         * elfread.c (elf_symtab_read): Update.
9344         * dwarf2read.c: Don't include bcache.h.
9345         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9346         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9347         (print_bcache_statistics, bcache_memory_used): Don't declare.
9348         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9349         methods.  Rename all data members.
9350         * bcache.c (struct bcache): Move to bcache.h.
9351         (bcache::expand_hash_table): Rename from expand_hash_table.
9352         (bcache): Remove.
9353         (bcache::insert): Rename from bcache_full.
9354         (bcache::compare): Rename from bcache_compare.
9355         (bcache_xmalloc): Remove.
9356         (bcache::~bcache): Rename from bcache_xfree.
9357         (bcache::print_statistics): Rename from print_bcache_statistics.
9358         (bcache::memory_used): Rename from bcache_memory_used.
9359
9360 2019-03-07  Pedro Alves  <palves@redhat.com>
9361
9362         * infrun.c (normal_stop): Also check for
9363         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9364
9365 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9366
9367         * f-lang.c (value_from_host_double): Moved to...
9368         * value.c (value_from_host_double): ...here.
9369         * value.h (value_from_host_double): Declare.
9370         * guile/scm-math.c (vlscm_convert_typed_number): Use
9371         value_from_host_double.
9372         (vlscm_convert_number): Likewise.
9373         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9374         * python/py-value.c (convert_value_from_python): Likewise.
9375
9376 2019-03-06  Tom Tromey  <tom@tromey.com>
9377
9378         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9379
9380 2019-03-06  Tom Tromey  <tom@tromey.com>
9381
9382         * utils.h (free_current_contents): Don't declare.
9383         * utils.c (free_current_contents): Remove.
9384
9385 2019-03-06  Tom Tromey  <tom@tromey.com>
9386
9387         * top.c (quit_force): Update.
9388         * main.c (captured_command_loop): Update.
9389         * common/new-op.c (operator new): Update.
9390         * common/common-exceptions.c (struct catcher)
9391         <save_cleanup_chain>: Remove member.
9392         (exceptions_state_mc_init): Update.
9393         (exception_try_scope_entry): Return nullptr.
9394         (exception_try_scope_exit, exception_rethrow)
9395         (throw_exception_sjlj, throw_exception_cxx): Update.
9396         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9397         (all_cleanups, do_cleanups, discard_cleanups)
9398         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9399         (restore_cleanups, restore_final_cleanups): Don't declare.
9400         (do_final_cleanups): Remove parameter.
9401         * common/cleanups.c (cleanup_chain, make_cleanup)
9402         (make_cleanup_dtor, all_cleanups, do_cleanups)
9403         (discard_my_cleanups, discard_cleanups)
9404         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9405         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9406         (null_cleanup): Remove.
9407         (do_final_cleanups): Remove parameter.
9408
9409 2019-03-06  Tom Tromey  <tom@tromey.com>
9410
9411         * remote.c (remote_target::remote_parse_stop_reply): Use
9412         unique_xmalloc_ptr.
9413
9414 2019-03-06  Tom Tromey  <tom@tromey.com>
9415
9416         * stabsread.c (struct stabs_field_info): Rename from field_info.
9417         <list, fnlist>: Add initializers.
9418         <obstack>: New member.
9419         (read_member_functions, read_struct_fields, read_baseclasses):
9420         Allocate on obstack.  Don't use cleanups.
9421         (read_one_struct_field, read_member_functions, read_struct_fields)
9422         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9423         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9424         (read_struct_type): Update.
9425
9426 2019-03-06  Tom Tromey  <tom@tromey.com>
9427
9428         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9429         * common/filestuff.h (make_cleanup_close): Don't declare.
9430         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9431         Remove.
9432
9433 2019-03-06  Tom Tromey  <tom@tromey.com>
9434
9435         * solib-aix.c: Use make_scope_exit.
9436
9437 2019-03-06  Tom Tromey  <tom@tromey.com>
9438
9439         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9440         Use make_scope_exit.
9441
9442 2019-03-06  Tom Tromey  <tom@tromey.com>
9443
9444         * solib-svr4.c (disable_probes_interface): Remove parameter.
9445         (svr4_handle_solib_event): Use make_scope_exit.
9446
9447 2019-03-06  Tom Tromey  <tom@tromey.com>
9448
9449         * remote.c (struct stop_reply_deleter): Remove.
9450         (stop_reply_up): Update.
9451         (struct stop_reply): Derive from notif_event.  Don't typedef.
9452         <regcache>: Now a std::vector.
9453         (stop_reply_xfree): Remove.
9454         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9455         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9456         (remote_target::discard_pending_stop_replies): Use delete.
9457         (remote_target::remote_parse_stop_reply): Update.
9458         (remote_target::process_stop_reply): Update.
9459         * remote-notif.h (struct notif_event): Add virtual destructor.
9460         Remove "dtr" member.
9461         (struct notif_client) <alloc_event>: Return a unique_ptr.
9462         (notif_event_xfree): Don't declare.
9463         (notif_event_up): New typedef.
9464         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9465         (notif_event_xfree, do_notif_event_xfree): Remove.
9466         (remote_notif_state_xfree): Update.
9467
9468 2019-03-06  Tom Tromey  <tom@tromey.com>
9469
9470         * infrun.c (displaced_step_clear_cleanup): Now a
9471         forward_scope_exit type.
9472         (displaced_step_prepare_throw): Update.
9473         (displaced_step_fixup): Update.
9474
9475 2019-03-06  Tom Tromey  <tom@tromey.com>
9476
9477         * inferior.h (class inferior): Update comment.
9478         * gdbthread.h (class thread_info): Update comment.
9479
9480 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9481             Tom Tromey  <tom@tromey.com>
9482
9483         * stabsread.h (struct stab_section_list): Remove.
9484         (coffstab_build_psymtabs): Update.
9485         * dbxread.c (symbuf_sections): Now a std::vector.
9486         (sect_idx): New global.
9487         (fill_symbuf): Update.
9488         (coffstab_build_psymtabs): Change type of stabsects parameter.
9489         Update.
9490         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9491         std::vector.
9492         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9493         (coff_locate_sections): Update.
9494         (coff_symfile_read): Remove cleanups.  Update.
9495         (init_stringtab): Add storage parameter.
9496         (free_stringtab, free_stringtab_cleanup): Remove.
9497         (init_lineno): Add storage parameter.
9498         (free_linetab, free_linetab_cleanup): Remove.
9499
9500 2019-03-06  Pedro Alves  <palves@redhat.com>
9501
9502         * linux-fork.c (fork_info::clobber_regs): Delete.
9503         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9504         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9505         comment.  Adjust.
9506         (scoped_switch_fork_info::scoped_switch_fork_info)
9507         (checkpoint_command, linux_fork_context): Adjust
9508         fork_save_infrun_state calls.
9509
9510 2019-03-06  Pedro Alves  <palves@redhat.com>
9511
9512         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9513         (inf_has_multiple_threads): Return 'bool' and rewrite using
9514         inferior_info::threads().
9515
9516 2019-03-06  Pedro Alves  <palves@redhat.com>
9517
9518         * linux-fork.c: Include <list>.
9519         (fork_list): Now a std::list instance.
9520         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9521         (forks_exist_p, find_last_fork): Adjust.
9522         (new_fork): Delete.
9523         (one_fork_p): New.
9524         (add_fork): Adjust.
9525         (free_fork): Delete, folded into fork_info::~fork_info().
9526         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9527         Adjust.
9528         (init_fork_list): Delete.
9529         (linux_fork_killall, linux_fork_mourn_inferior)
9530         (linux_fork_detach, info_checkpoints_command): Adjust.
9531         (_initialize_linux_fork): No longer call init_fork_list.
9532
9533 2019-03-06  Pedro Alves  <palves@redhat.com>
9534
9535         * linux-fork.c (new_fork): New, split out of ...
9536         (add_fork): ... this.  Return void.  Move "first fork" special
9537         case from here, to ...
9538         (checkpoint_command): ... here.
9539         * linux-linux.h (add_fork): Return void.
9540
9541 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9542
9543         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9544
9545 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9546             Chris January  <chris.january@arm.com>
9547             David Lecomber  <david.lecomber@arm.com>
9548
9549         * f-exp.y: New token, UNOP_INTRINSIC.
9550         (exp): New pattern using UNOP_INTRINSIC token.
9551         (f77_keywords): Add 'abs' keyword.
9552         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9553         (value_from_host_double): New function.
9554         (evaluate_subexp_f): Support UNOP_ABS.
9555
9556 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9557
9558         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9559         types.
9560
9561 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9562
9563         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9564         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9565         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9566
9567 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9568
9569         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9570
9571 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9572             Chris January  <chris.january@arm.com>
9573
9574         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9575         * f-exp.y: Define 'KIND' token.
9576         (exp): New pattern for KIND expressions.
9577         (ptype): Handle types with a kind extension.
9578         (direct_abs_decl): Extend to spot kind extensions.
9579         (f77_keywords): Add 'kind' to the list.
9580         (push_kind_type): New function.
9581         (convert_to_kind_type): New function.
9582         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9583         * parse.c (operator_length_standard): Likewise.
9584         * parser-defs.h (enum type_pieces): Add tp_kind.
9585         * std-operator.def: Add UNOP_KIND.
9586
9587 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9588
9589         * f-exp.y (f_parse): Set yydebug.
9590
9591 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9592
9593         * f-lang.c (evaluate_subexp_f): New function.
9594         (exp_descriptor_f): New global.
9595         (f_language_defn): Use exp_descriptor_f instead of
9596         exp_descriptor_standard.
9597
9598 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9599
9600         * f-exp.y (struct token): Add comments.
9601         (dot_ops): Remove uppercase versions and the end marker.
9602         (f77_keywords): Likewise.
9603         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9604         entries in the dot_ops array are case insensitive, and use
9605         strncasecmp to compare strings.  Also some whitespace cleanup in
9606         this area.  Similar for the f77_keywords array, except entries in
9607         this list might be case sensitive.
9608
9609 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9610
9611         * f-exp.y (struct f77_boolean_val): Add comments.
9612         (boolean_values): Remove uppercase versions, and end marker.
9613         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9614         and use strncasecmp to achieve case insensitivity.  Additionally,
9615         perform whitespace cleanup around this code.
9616
9617 2019-03-06  Tom Tromey  <tromey@adacore.com>
9618
9619         * remote-sim.c (gdbsim_target_open): Use result of
9620         gdb_argv::release.
9621
9622 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9623         Dirk Schubert  <dirk.schubert@arm.com>
9624         Chris January  <chris.january@arm.com>
9625
9626         * eval.c (evaluate_subexp_standard): Call Fortran argument
9627         wrapping logic.
9628         * f-lang.c (struct value): A value which can be passed into a
9629         Fortran function call.
9630         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9631         where appropriate.
9632         (struct type): Value ready for a Fortran function call.
9633         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9634         is needed.
9635         * f-lang.h (fortran_argument_convert): Declaration.
9636         (fortran_preserve_arg_pointer): Declaration.
9637         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9638
9639 2019-03-05  Tom Tromey  <tromey@adacore.com>
9640
9641         * python/py-prettyprint.c (print_string_repr): Remove #if.
9642         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9643
9644 2019-03-05  Tom Tromey  <tromey@adacore.com>
9645
9646         * target.c (the_dummy_target): Move later.  Change type to
9647         "dummy_target".
9648         (initialize_targets): Don't initialize the_dummy_target.
9649
9650 2019-03-05  Tom Tromey  <tromey@adacore.com>
9651
9652         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9653         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9654
9655 2019-03-05  Tom Tromey  <tromey@adacore.com>
9656
9657         * windows-nat.c (windows_nat_target::attach)
9658         (windows_nat_target::detach): Don't call gdb_flush.
9659         * valprint.c (generic_val_print, val_print, val_print_string):
9660         Don't call gdb_flush.
9661         * utils.c (defaulted_query): Don't call gdb_flush.
9662         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9663         * target.c (target_announce_detach): Don't call gdb_flush.
9664         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9665         * remote.c (extended_remote_target::attach): Don't call
9666         gdb_flush.
9667         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9668         * printcmd.c (do_examine): Don't call gdb_flush.
9669         (info_display_command): Don't call gdb_flush.
9670         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9671         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9672         * memattr.c (info_mem_command): Don't call gdb_flush.
9673         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9674         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9675         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9676         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9677         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9678         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9679         (gnu_nat_target::detach): Don't call gdb_flush.
9680         * f-valprint.c (f_val_print): Don't call gdb_flush.
9681         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9682         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9683         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9684         gdb_flush.
9685         * c-valprint.c (c_val_print): Don't call gdb_flush.
9686         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9687
9688 2019-03-05  Tom Tromey  <tromey@adacore.com>
9689
9690         * varobj.c (update_dynamic_varobj_children): Update.
9691         (install_default_visualizer): Use reset, not release.
9692         * value.c (set_internalvar): Update.
9693         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9694         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9695         ATTRIBUTE_UNUSED_RESULT.
9696
9697 2019-03-05  Tom Tromey  <tromey@adacore.com>
9698
9699         * remote.c (class scoped_remote_fd) <release>: Add
9700         ATTRIBUTE_UNUSED_RESULT.
9701
9702 2019-03-05  Tom Tromey  <tromey@adacore.com>
9703
9704         * macroexp.c (struct macro_buffer) <release>: Add
9705         ATTRIBUTE_UNUSED_RESULT.
9706
9707 2019-03-05  Tom Tromey  <tromey@adacore.com>
9708
9709         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9710         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9711         ATTRIBUTE_UNUSED_RESULT.
9712
9713 2019-03-05  Tom Tromey  <tromey@adacore.com>
9714
9715         * common/scoped_fd.h (class scoped_fd) <release>: Add
9716         ATTRIBUTE_UNUSED_RESULT.
9717
9718 2019-03-05  Tom Tromey  <tromey@adacore.com>
9719
9720         * parser-defs.h (struct parser_state) <release>: Add
9721         ATTRIBUTE_UNUSED_RESULT.
9722
9723 2019-03-05  Tom Tromey  <tromey@adacore.com>
9724
9725         * utils.h (class gdb_argv) <release>: Add
9726         ATTRIBUTE_UNUSED_RESULT.
9727         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9728
9729 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9730
9731         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9732         for-loop range, to avoid compiler warnings.
9733
9734         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9735         avoid compiler warnings about unused variables.
9736
9737         * NEWS: Mention end of support for native debugging on MS-Windows
9738         before XP.
9739
9740         PR gdb/24292
9741         * common/netstuff.c:
9742         * gdbserver/gdbreplay.c
9743         * gdbserver/remote-utils.c:
9744         * ser-tcp.c:
9745         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9746         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9747         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9748         'getaddrinfo' and 'freeaddrinfo' were not available before
9749         Windows XP, and mingw.org's MinGW headers by default define
9750         _WIN32_WINNT to 0x500.
9751
9752 2019-03-01  Gary Benson <gbenson@redhat.com>
9753
9754         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9755
9756 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9757             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9758
9759         PR gdb/8527
9760         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9761         set_sigint_trap, clear_sigint_trap.
9762
9763 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9764
9765         * target.c (target_detach): Clear the regcache and the
9766         frame cache.
9767
9768 2019-02-27  Pedro Alves  <palves@redhat.com>
9769
9770         * utils.c (set_screen_size): When we cap the height/width sizes,
9771         tweak the corresponding command variable to show "unlimited":
9772
9773 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9774             Pedro Alves  <palves@redhat.com>
9775
9776         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9777         before calling rl_set_screen_size.
9778
9779 2019-02-27  Tom Tromey  <tromey@adacore.com>
9780
9781         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9782         define.
9783         * python/py-value.c: Remove Python 2.4 workaround.
9784         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9785         workaround.
9786         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9787         Python 2.4 workaround.
9788         * python/python-internal.h: Remove Python 2.4 comment.
9789         (Py_ssize_t): Don't define.
9790         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9791         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9792         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9793         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9794         * python/python.c (do_start_initialization): Remove Python 2.4
9795         workaround.
9796         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9797         (print_children): Remove Python 2.4 workaround.
9798         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9799         workaround.
9800         (CHARBUFFERPROC_NAME): Remove.
9801         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9802         Python 2.4 workaround.
9803
9804 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9805
9806         * NEWS: Note minimum Python version.
9807
9808 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9809
9810         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9811         code from these functions.  Remove corresponding ifdefs.  Use
9812         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9813         Remove gotos and target of gotos.
9814         (infpy_search_memory): Likewise.
9815
9816 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9817
9818         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9819         (hppa_gdbarch_init): Don't register deleted functions with
9820         gdbarch.
9821
9822 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9823
9824         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9825         (h8300_unwind_sp): Delete.
9826         (h8300_dummy_id): Delete.
9827         (h8300_gdbarch_init): Don't register deleted functions with
9828         gdbarch.
9829
9830 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9831
9832         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9833         (ft32_unwind_pc): Delete.
9834         (ft32_unwind_sp): Delete.
9835         (ft32_gdbarch_init): Don't register deleted functions with
9836         gdbarch.
9837
9838 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9839
9840         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9841         (frv_unwind_pc): Delete.
9842         (frv_unwind_sp): Delete.
9843         (frv_gdbarch_init): Don't register deleted functions with
9844         gdbarch.
9845
9846 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9847
9848         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9849         (riscv_unwind_pc): Delete.
9850         (riscv_unwind_sp): Delete.
9851         (riscv_gdbarch_init): Don't register deleted functions with
9852         gdbarch.
9853
9854 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9855
9856         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9857         (csky_unwind_pc): Delete.
9858         (csky_unwind_sp): Delete.
9859         (csky_gdbarch_init): Don't register deleted functions with
9860         gdbarch.
9861
9862 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9863
9864         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9865         (cris_unwind_pc): Delete.
9866         (cris_unwind_sp): Delete.
9867         (cris_gdbarch_init): Don't register deleted functions with
9868         gdbarch.
9869
9870 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9871
9872         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9873         (bfin_unwind_pc): Delete.
9874         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9875
9876 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9877
9878         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9879         (arm_unwind_pc): Delete.
9880         (arm_unwind_sp): Delete.
9881         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9882
9883 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9884
9885         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9886         (arc_unwind_pc): Delete.
9887         (arc_unwind_sp): Delete.
9888         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9889
9890 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9891
9892         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9893         (alpha_unwind_pc): Delete.
9894         (alpha_gdbarch_init): Don't register deleted functions with
9895         gdbarch.
9896
9897 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9898
9899         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9900         (aarch64_unwind_pc): Delete.
9901         (aarch64_unwind_sp): Delete.
9902         (aarch64_gdbarch_init): Don't register deleted functions with
9903         gdbarch.
9904
9905 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9906
9907         * gdbtypes.c (type_align): Don't consider static members when
9908         computing structure alignment.
9909
9910 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9911
9912         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9913         return 0 for other types.
9914         * arch-utils.c (default_type_align): Always return 0.
9915         * gdbarch.h: Regenerate.
9916         * gdbarch.sh (type_align): Extend comment.
9917         * gdbtypes.c (type_align): Add additional comments, always call
9918         gdbarch_type_align before applying the default rules.
9919         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9920         generic code will then apply a suitable default.
9921         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9922         types, return 0 for other types.
9923
9924 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9925
9926         * NEWS: Create a new section for the next release branch.
9927         Rename the section of the current branch, now that it has
9928         been cut.
9929
9930 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9931
9932         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9933         * version.in: Bump version to 8.3.50.DATE-git.
9934
9935 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9936
9937         * aix-thread.c (ptid_cmp): Remove unused variable.
9938         (get_signaled_thread): Likewise.
9939         (store_regs_user_thread): Likewise.
9940         (store_regs_kernel_thread): Likewise.
9941         (fetch_regs_kernel_thread): Remove shadowed variable.
9942
9943 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9944
9945         * features/riscv/32bit-cpu.xml: Add register numbers.
9946         * features/riscv/32bit-fpu.c: Regenerate.
9947         * features/riscv/32bit-fpu.xml: Add register numbers.
9948         * features/riscv/64bit-cpu.xml: Add register numbers.
9949         * features/riscv/64bit-fpu.c: Regenerate.
9950         * features/riscv/64bit-fpu.xml: Add register numbers.
9951
9952 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9953
9954         * NEWS: Mention two argument form of gdb.Value constructor.
9955         * python/py-value.c (convert_buffer_and_type_to_value): New
9956         function.
9957         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9958         Add support for handling an optional second argument.  Call
9959         convert_buffer_and_type_to_value as appropriate.
9960         * python/python-internal.h (Py_buffer_deleter): New struct.
9961         (Py_buffer_up): New typedef.
9962
9963 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9964
9965         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9966         instead of releasing ownership.
9967
9968 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9969
9970         * dwarf2read.c (open_and_init_dwp_file): Call
9971         elf_numsections instead of bfd_count_sections to initialize
9972         dwp_file->num_sections.
9973
9974 2019-02-25  Tom Tromey  <tromey@adacore.com>
9975
9976         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9977
9978 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9979
9980         * gcore.in: Add '--readnever' option when invoking GDB.
9981
9982 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9983
9984         * MAINTAINERS: Update my email address.
9985
9986 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9987
9988         * build-id.c (build_id_to_debug_bfd_1): New function.
9989         (build_id_to_debug_bfd): Look for separate debug file in
9990         sysroot.
9991
9992 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9993
9994         * gdbarch.sh: Update the copyright year range that is placed into
9995         generated files.
9996
9997 2019-02-22  Keith Seitz  <keiths@redhat.com>
9998
9999         PR symtab/23853
10000         * linespec.c (create_sals_line_offset): Search for the default
10001         symtab's filename instead of its fullname.
10002
10003 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10004
10005         * NEWS: Update style defaults.
10006
10007 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10008
10009         * main.c (captured_main_1): Disable styling in batch mode.
10010
10011 2019-02-20  Tom Tromey  <tom@tromey.com>
10012
10013         * symtab.c (symtab_symbol_info): Fix typos.
10014
10015 2019-02-20  Tom Tromey  <tromey@adacore.com>
10016
10017         * findcmd.c (_initialize_mem_search): Use upper case for
10018         metasyntactic variables.
10019
10020 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10021
10022         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10023         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10024
10025 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10026
10027         * top.h (source_file_name): Change to std::string.
10028         * top.c (source_file_name): Likewise.
10029         (command_line_input): Adjust.
10030         * cli/cli-script.c (script_from_file): Adjust.
10031
10032 2019-02-19  Tom Tromey  <tromey@adacore.com>
10033
10034         * ravenscar-thread.c
10035         (ravenscar_thread_target::update_thread_list): Don't call
10036         ada_build_task_list.
10037         * ada-lang.h (ada_build_task_list): Don't declare.
10038         * ada-tasks.c (struct ada_tasks_inferior_data)
10039         <task_list_valid_p>: Now bool.
10040         (read_known_tasks, ada_task_list_changed)
10041         (ada_tasks_invalidate_inferior_data): Update.
10042         (read_known_tasks_array): Return bool.
10043         (read_known_tasks_list): Likewise.
10044         (read_known_tasks): Return void.
10045         (ada_build_task_list): Now static.
10046
10047 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10048
10049         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10050         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10051
10052 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10053
10054         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10055         variant for ada_tasks_pspace_data_handle and
10056         ada_tasks_inferior_data_handle.
10057         (ada_tasks_pspace_data_cleanup): New function.
10058         (ada_tasks_inferior_data_cleanup): New function.
10059
10060 2019-02-17  Tom Tromey  <tom@tromey.com>
10061
10062         * macrotab.h (macro_source_fullname): Return a std::string.
10063         * macrotab.c (macro_include, check_for_redefinition)
10064         (macro_undef, macro_lookup_definition, foreach_macro)
10065         (foreach_macro_in_scope): Update.
10066         (macro_source_fullname): Return a std::string.
10067         * macrocmd.c (show_pp_source_pos): Update.
10068
10069 2019-02-17  Tom Tromey  <tom@tromey.com>
10070
10071         * macrocmd.c (show_pp_source_pos): Style the file names.
10072
10073 2019-02-17  Tom Tromey  <tom@tromey.com>
10074
10075         PR tui/24197:
10076         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10077
10078 2019-02-17  Tom Tromey  <tom@tromey.com>
10079
10080         * ada-lang.c (user_select_syms): Use filtered printing.
10081         * utils.c (wrap_style): New global.
10082         (desired_style): Remove.
10083         (emit_style_escape): Add stream parameter.
10084         (set_output_style, reset_terminal_style, prompt_for_continue):
10085         Update.
10086         (flush_wrap_buffer): Only flush gdb_stdout.
10087         (wrap_here): Set wrap_style.
10088         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10089         treat escape sequences as a character.  Change when wrap buffer is
10090         flushed.
10091         (fputs_styled): Do not set the output style when the default is
10092         requested.
10093         * ui-style.h (struct ui_file_style) <is_default>: New method.
10094         * source.c (print_source_lines_base): Emit escape sequences in one
10095         piece.
10096
10097 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10098
10099         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10100         integers and enumeration types.
10101
10102 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10103
10104         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10105         instead of lookup_symbol_in_language
10106         (do_exact_match): New function.
10107         (ada_get_symbol_name_matcher): Return do_exact_match when
10108         doing a verbatim match.
10109
10110 2019-02-15  Tom Tromey  <tromey@adacore.com>
10111
10112         * ravenscar-thread.c (ravenscar_thread_target::resume)
10113         (ravenscar_thread_target::wait): Special case wildcard requests.
10114
10115 2019-02-15  Tom Tromey  <tromey@adacore.com>
10116
10117         * ravenscar-thread.c (base_ptid): Remove.
10118         (struct ravenscar_thread_target) <close>: New method.
10119         <m_base_ptid>: New member.
10120         <update_inferior_ptid, active_task, task_is_currently_active,
10121         runtime_initialized>: Declare methods.
10122         <ravenscar_thread_target>: Add constructor.
10123         (ravenscar_thread_target::task_is_currently_active)
10124         (ravenscar_thread_target::update_inferior_ptid)
10125         (ravenscar_runtime_initialized): Rename.  Now methods.
10126         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10127         (ravenscar_thread_target::update_thread_list): Update.
10128         (ravenscar_thread_target::active_task): Now method.
10129         (ravenscar_thread_target::store_registers)
10130         (ravenscar_thread_target::prepare_to_store)
10131         (ravenscar_thread_target::prepare_to_store)
10132         (ravenscar_thread_target::mourn_inferior): Update.
10133         (ravenscar_inferior_created): Use "new" to create target.
10134         (ravenscar_thread_target::get_ada_task_ptid): Update.
10135         (_initialize_ravenscar): Don't initialize base_ptid.
10136         (ravenscar_ops): Remove global.
10137
10138 2019-02-15  Tom Tromey  <tromey@adacore.com>
10139
10140         * target.h (push_target): Declare new overload.
10141         * target.c (push_target): New overload, taking an rvalue reference.
10142         * remote.c (remote_target::open_1): Use push_target overload.
10143         * corelow.c (core_target_open): Use push_target overload.
10144
10145 2019-02-15  Tom Tromey  <tromey@adacore.com>
10146
10147         * ravenscar-thread.c (is_ravenscar_task)
10148         (ravenscar_task_is_currently_active): Return bool.
10149         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10150         (_initialize_ravenscar): Remove "(void)".
10151         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10152         Return bool.
10153
10154 2019-02-15  Tom Tromey  <tromey@adacore.com>
10155
10156         * ravenscar-thread.c (ravenscar_runtime_initializer)
10157         (has_ravenscar_runtime, get_running_thread_id)
10158         (ravenscar_thread_target::resume): Fix indentation.
10159
10160 2019-02-15  Tom Tromey  <tromey@adacore.com>
10161
10162         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10163         from ravenscar_arch_ops.
10164         (sparc_ravenscar_ops::fetch_registers)
10165         (sparc_ravenscar_ops::store_registers): Now methods.
10166         (sparc_ravenscar_prepare_to_store): Remove.
10167         (sparc_ravenscar_ops): Redefine.
10168         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10169         methods and destructor.  Remove members.
10170         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10171         (ravenscar_thread_target::store_registers)
10172         (ravenscar_thread_target::prepare_to_store): Update.
10173         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10174         Remove.
10175         (struct ppc_ravenscar_powerpc_ops): Derive from
10176         ravenscar_arch_ops.
10177         (ppc_ravenscar_powerpc_ops::fetch_registers)
10178         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10179         (ppc_ravenscar_powerpc_ops): Redefine.
10180         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10181         (ppc_ravenscar_e500_ops::fetch_registers)
10182         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10183         (ppc_ravenscar_e500_ops): Redefine.
10184         * aarch64-ravenscar-thread.c
10185         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10186         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10187         (aarch64_ravenscar_fetch_registers)
10188         (aarch64_ravenscar_store_registers): Now methods.
10189         (aarch64_ravenscar_ops): Redefine.
10190
10191 2019-02-15  Tom Tromey  <tromey@adacore.com>
10192
10193         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10194         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10195         (ravenscar_thread_target::stopped_by_watchpoint)
10196         (ravenscar_thread_target::stopped_data_address)
10197         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10198
10199 2019-02-15  Tom Tromey  <tromey@adacore.com>
10200
10201         * ravenscar-thread.c: Fix some typos.
10202
10203 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10204             Tom Tromey  <tromey@adacore.com>
10205
10206         * ada-lang.c (ada_exception_sal): Change addr_string to a
10207         std::string.
10208         (create_ada_exception_catchpoint): Update.
10209
10210 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10211             Tom Tromey  <tromey@adacore.com>
10212
10213         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10214         (bp_location_ops): Remove.
10215         (base_breakpoint_allocate_location): Update.
10216         (free_bp_location): Update.
10217         * ada-lang.c (class ada_catchpoint_location)
10218         <ada_catchpoint_location>: Remove ops parameter.
10219         (ada_catchpoint_location_dtor): Remove.
10220         (ada_catchpoint_location_ops): Remove.
10221         (allocate_location_exception): Update.
10222         * breakpoint.h (struct bp_location_ops): Remove.
10223         (class bp_location) <bp_location>: Remove bp_location_ops
10224         parameter.
10225         <~bp_location>: Add destructor.
10226         <ops>: Remove.
10227
10228 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10229             Pedro Alves  <palves@redhat.com>
10230
10231         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10232         'PATH_MAX'.
10233
10234 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10235             Samuel Thibault  <samuel.thibault@gnu.org>
10236             Thomas Schwinge  <thomas@codesourcery.com>
10237
10238         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10239         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10240
10241 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10242
10243         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10244         (check_empty): Use "const char *".
10245
10246         * gnu-nat.c (gnu_nat_target::detach): Instead of
10247         'detach_inferior (pid)' call
10248         'detach_inferior (find_inferior_pid (pid))'.
10249
10250         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10251         'nat/fork-inferior.o'.
10252         * gnu-nat.c: #include "nat/fork-inferior.h".
10253
10254         * gnu-nat.c (gnu_nat_target::detach): Instead of
10255         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10256         * gnu-nat.h: #include "inf-child.h".
10257         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10258         'i386_gnu_nat_target::fetch_registers'.
10259         (gnu_store_registers): Rename/move to
10260         'i386_gnu_nat_target::store_registers'.
10261
10262         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10263         * gnu-nat.h (mach_thread_info): New function.
10264         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10265
10266         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10267
10268 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10269
10270         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10271
10272 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10273
10274         * windows-nat.c (windows_add_thread): Add new parameter
10275         "main_thread_p" with default value set to false.  Update
10276         function documentation as well as all callers.
10277         (windows_delete_thread): Likewise.
10278         (fake_create_process): Update call to windows_add_thread.
10279         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10280         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10281         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10282         call to windows_delete_thread.
10283
10284 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10285
10286         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10287
10288 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10289
10290         * symfile.c (find_separate_debug_file): Use canonical path of
10291         sysroot with child_path instead of gdb_sysroot if it is valid.
10292
10293 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10294
10295         * symfile.c (find_separate_debug_file): Use child_path to
10296         determine if an object file is under a sysroot.
10297
10298 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10299
10300         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10301         unittests/child-path-selftests.c.
10302         * common/pathstuff.c (child_path): New function.
10303         * common/pathstuff.h (child_path): New prototype.
10304         * unittests/child-path-selftests.c: New file.
10305
10306 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10307
10308         * symfile.c (find_separate_debug_file): Look for separate debug
10309         files in debug directories under the sysroot.
10310
10311 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10312
10313         * symtab.h (struct minimal_symbol data_p): New const method.
10314         (struct minimal_symbol text_p): Likewise.
10315         * symtab.c (output_source_filename): Use file name style
10316         to print file name.
10317         (print_symbol_info): Likewise.
10318         (print_msymbol_info): Use address style to print addresses.
10319         Use function name style to print executable text symbols.
10320         (expand_symtab_containing_pc): Use data_p.
10321         (find_pc_sect_compunit_symtab): Likewise.
10322
10323 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10324
10325         * breakpoint.c (describe_other_breakpoints): Use address style
10326         to print addresses.
10327         (say_where): Likewise.
10328
10329 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10330
10331         * ada-typeprint.c (print_func_type): Print function name
10332         style to print function name.
10333         * c-typeprint.c (c_print_type_1): Likewise.
10334
10335 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10336
10337         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10338         for execve.
10339
10340 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10341
10342         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10343         type_stack.
10344
10345 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10346
10347         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10348         TYPE_CODE_REF types.
10349
10350 2019-02-08  Jim Wilson  <jimw@sifive.com>
10351
10352         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10353         (riscv_linux_fregset): New.
10354         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10355
10356 2019-02-07  Tom Tromey  <tom@tromey.com>
10357
10358         * thread.c (thread_cancel_execution_command): Update.
10359         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10360         methods.
10361         (struct thread_fsm_ops): Remove.
10362         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10363         (thread_fsm_should_stop, thread_fsm_return_value)
10364         (thread_fsm_set_finished, thread_fsm_finished_p)
10365         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10366         Don't declare.
10367         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10368         * infrun.c (clear_proceed_status_thread)
10369         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10370         (print_stop_event): Update.
10371         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10372         Add constructor.
10373         (step_command_fsm_ops): Remove.
10374         (new_step_command_fsm): Remove.
10375         (step_1): Update.
10376         (step_command_fsm::should_stop): Rename from
10377         step_command_fsm_should_stop.
10378         (step_command_fsm::clean_up): Rename from
10379         step_command_fsm_clean_up.
10380         (step_command_fsm::do_async_reply_reason): Rename from
10381         step_command_fsm_async_reply_reason.
10382         (struct until_next_fsm): Inherit from thread_fsm.  Add
10383         constructor.
10384         (until_next_fsm_ops): Remove.
10385         (new_until_next_fsm): Remove.
10386         (until_next_fsm::should_stop): Rename from
10387         until_next_fsm_should_stop.
10388         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10389         (until_next_fsm::do_async_reply_reason): Rename from
10390         until_next_fsm_async_reply_reason.
10391         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10392         constructor.  Change type of breakpoint.
10393         (finish_command_fsm_ops): Remove.
10394         (new_finish_command_fsm): Remove.
10395         (finish_command_fsm::should_stop): Rename from
10396         finish_command_fsm_should_stop.
10397         (finish_command_fsm::clean_up): Rename from
10398         finish_command_fsm_clean_up.
10399         (finish_command_fsm::return_value): Rename from
10400         finish_command_fsm_return_value.
10401         (finish_command_fsm::do_async_reply_reason): Rename from
10402         finish_command_fsm_async_reply_reason.
10403         (finish_command): Update.
10404         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10405         Add constructor.
10406         (call_thread_fsm_ops): Remove.
10407         (call_thread_fsm::call_thread_fsm): Rename from
10408         new_call_thread_fsm.
10409         (call_thread_fsm::should_stop): Rename from
10410         call_thread_fsm_should_stop.
10411         (call_thread_fsm::should_notify_stop): Rename from
10412         call_thread_fsm_should_notify_stop.
10413         (run_inferior_call, call_function_by_hand_dummy): Update.
10414         * cli/cli-interp.c (should_print_stop_to_console): Update.
10415         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10416         Add constructor.  Change type of location_breakpoint,
10417         caller_breakpoint.
10418         (until_break_fsm_ops): Remove.
10419         (new_until_break_fsm): Remove.
10420         (until_break_fsm::should_stop): Rename from
10421         until_break_fsm_should_stop.
10422         (until_break_fsm::clean_up): Rename from
10423         until_break_fsm_clean_up.
10424         (until_break_fsm::do_async_reply_reason): Rename from
10425         until_break_fsm_async_reply_reason.
10426         (until_break_command): Update.
10427         * thread-fsm.c: Remove.
10428         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10429
10430 2019-02-07  Tom Tromey  <tom@tromey.com>
10431
10432         * yy-remap.h: Add include guard.
10433         * xtensa-tdep.h: Add include guard.
10434         * xcoffread.h: Rename include guard.
10435         * varobj-iter.h: Add include guard.
10436         * tui/tui.h: Rename include guard.
10437         * tui/tui-winsource.h: Rename include guard.
10438         * tui/tui-wingeneral.h: Rename include guard.
10439         * tui/tui-windata.h: Rename include guard.
10440         * tui/tui-win.h: Rename include guard.
10441         * tui/tui-stack.h: Rename include guard.
10442         * tui/tui-source.h: Rename include guard.
10443         * tui/tui-regs.h: Rename include guard.
10444         * tui/tui-out.h: Rename include guard.
10445         * tui/tui-layout.h: Rename include guard.
10446         * tui/tui-io.h: Rename include guard.
10447         * tui/tui-hooks.h: Rename include guard.
10448         * tui/tui-file.h: Rename include guard.
10449         * tui/tui-disasm.h: Rename include guard.
10450         * tui/tui-data.h: Rename include guard.
10451         * tui/tui-command.h: Rename include guard.
10452         * tic6x-tdep.h: Add include guard.
10453         * target/waitstatus.h: Rename include guard.
10454         * target/wait.h: Rename include guard.
10455         * target/target.h: Rename include guard.
10456         * target/resume.h: Rename include guard.
10457         * target-float.h: Rename include guard.
10458         * stabsread.h: Add include guard.
10459         * rs6000-tdep.h: Add include guard.
10460         * riscv-fbsd-tdep.h: Add include guard.
10461         * regformats/regdef.h: Rename include guard.
10462         * record.h: Rename include guard.
10463         * python/python.h: Rename include guard.
10464         * python/python-internal.h: Rename include guard.
10465         * python/py-stopevent.h: Rename include guard.
10466         * python/py-ref.h: Rename include guard.
10467         * python/py-record.h: Rename include guard.
10468         * python/py-record-full.h: Rename include guard.
10469         * python/py-record-btrace.h: Rename include guard.
10470         * python/py-instruction.h: Rename include guard.
10471         * python/py-events.h: Rename include guard.
10472         * python/py-event.h: Rename include guard.
10473         * procfs.h: Add include guard.
10474         * proc-utils.h: Add include guard.
10475         * p-lang.h: Add include guard.
10476         * or1k-tdep.h: Rename include guard.
10477         * observable.h: Rename include guard.
10478         * nto-tdep.h: Rename include guard.
10479         * nat/x86-linux.h: Rename include guard.
10480         * nat/x86-linux-dregs.h: Rename include guard.
10481         * nat/x86-gcc-cpuid.h: Add include guard.
10482         * nat/x86-dregs.h: Rename include guard.
10483         * nat/x86-cpuid.h: Rename include guard.
10484         * nat/ppc-linux.h: Rename include guard.
10485         * nat/mips-linux-watch.h: Rename include guard.
10486         * nat/linux-waitpid.h: Rename include guard.
10487         * nat/linux-ptrace.h: Rename include guard.
10488         * nat/linux-procfs.h: Rename include guard.
10489         * nat/linux-osdata.h: Rename include guard.
10490         * nat/linux-nat.h: Rename include guard.
10491         * nat/linux-namespaces.h: Rename include guard.
10492         * nat/linux-btrace.h: Rename include guard.
10493         * nat/glibc_thread_db.h: Rename include guard.
10494         * nat/gdb_thread_db.h: Rename include guard.
10495         * nat/gdb_ptrace.h: Rename include guard.
10496         * nat/fork-inferior.h: Rename include guard.
10497         * nat/amd64-linux-siginfo.h: Rename include guard.
10498         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10499         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10500         * nat/aarch64-linux.h: Rename include guard.
10501         * nat/aarch64-linux-hw-point.h: Rename include guard.
10502         * mn10300-tdep.h: Add include guard.
10503         * mips-linux-tdep.h: Add include guard.
10504         * mi/mi-parse.h: Rename include guard.
10505         * mi/mi-out.h: Rename include guard.
10506         * mi/mi-main.h: Rename include guard.
10507         * mi/mi-interp.h: Rename include guard.
10508         * mi/mi-getopt.h: Rename include guard.
10509         * mi/mi-console.h: Rename include guard.
10510         * mi/mi-common.h: Rename include guard.
10511         * mi/mi-cmds.h: Rename include guard.
10512         * mi/mi-cmd-break.h: Rename include guard.
10513         * m2-lang.h: Add include guard.
10514         * location.h: Rename include guard.
10515         * linux-record.h: Rename include guard.
10516         * linux-nat.h: Add include guard.
10517         * linux-fork.h: Add include guard.
10518         * i386-darwin-tdep.h: Rename include guard.
10519         * hppa-linux-offsets.h: Add include guard.
10520         * guile/guile.h: Rename include guard.
10521         * guile/guile-internal.h: Rename include guard.
10522         * gnu-nat.h: Rename include guard.
10523         * gdb-stabs.h: Rename include guard.
10524         * frv-tdep.h: Add include guard.
10525         * f-lang.h: Add include guard.
10526         * event-loop.h: Add include guard.
10527         * darwin-nat.h: Rename include guard.
10528         * cp-abi.h: Rename include guard.
10529         * config/sparc/nm-sol2.h: Rename include guard.
10530         * config/nm-nto.h: Rename include guard.
10531         * config/nm-linux.h: Add include guard.
10532         * config/i386/nm-i386gnu.h: Rename include guard.
10533         * config/djgpp/nl_types.h: Rename include guard.
10534         * config/djgpp/langinfo.h: Rename include guard.
10535         * compile/gcc-cp-plugin.h: Add include guard.
10536         * compile/gcc-c-plugin.h: Add include guard.
10537         * compile/compile.h: Rename include guard.
10538         * compile/compile-object-run.h: Rename include guard.
10539         * compile/compile-object-load.h: Rename include guard.
10540         * compile/compile-internal.h: Rename include guard.
10541         * compile/compile-cplus.h: Rename include guard.
10542         * compile/compile-c.h: Rename include guard.
10543         * common/xml-utils.h: Rename include guard.
10544         * common/x86-xstate.h: Rename include guard.
10545         * common/version.h: Rename include guard.
10546         * common/vec.h: Rename include guard.
10547         * common/tdesc.h: Rename include guard.
10548         * common/selftest.h: Rename include guard.
10549         * common/scoped_restore.h: Rename include guard.
10550         * common/scoped_mmap.h: Rename include guard.
10551         * common/scoped_fd.h: Rename include guard.
10552         * common/safe-iterator.h: Rename include guard.
10553         * common/run-time-clock.h: Rename include guard.
10554         * common/refcounted-object.h: Rename include guard.
10555         * common/queue.h: Rename include guard.
10556         * common/ptid.h: Rename include guard.
10557         * common/print-utils.h: Rename include guard.
10558         * common/preprocessor.h: Rename include guard.
10559         * common/pathstuff.h: Rename include guard.
10560         * common/observable.h: Rename include guard.
10561         * common/netstuff.h: Rename include guard.
10562         * common/job-control.h: Rename include guard.
10563         * common/host-defs.h: Rename include guard.
10564         * common/gdb_wait.h: Rename include guard.
10565         * common/gdb_vecs.h: Rename include guard.
10566         * common/gdb_unlinker.h: Rename include guard.
10567         * common/gdb_unique_ptr.h: Rename include guard.
10568         * common/gdb_tilde_expand.h: Rename include guard.
10569         * common/gdb_sys_time.h: Rename include guard.
10570         * common/gdb_string_view.h: Rename include guard.
10571         * common/gdb_splay_tree.h: Rename include guard.
10572         * common/gdb_setjmp.h: Rename include guard.
10573         * common/gdb_ref_ptr.h: Rename include guard.
10574         * common/gdb_optional.h: Rename include guard.
10575         * common/gdb_locale.h: Rename include guard.
10576         * common/gdb_assert.h: Rename include guard.
10577         * common/filtered-iterator.h: Rename include guard.
10578         * common/filestuff.h: Rename include guard.
10579         * common/fileio.h: Rename include guard.
10580         * common/environ.h: Rename include guard.
10581         * common/common-utils.h: Rename include guard.
10582         * common/common-types.h: Rename include guard.
10583         * common/common-regcache.h: Rename include guard.
10584         * common/common-inferior.h: Rename include guard.
10585         * common/common-gdbthread.h: Rename include guard.
10586         * common/common-exceptions.h: Rename include guard.
10587         * common/common-defs.h: Rename include guard.
10588         * common/common-debug.h: Rename include guard.
10589         * common/cleanups.h: Rename include guard.
10590         * common/buffer.h: Rename include guard.
10591         * common/btrace-common.h: Rename include guard.
10592         * common/break-common.h: Rename include guard.
10593         * cli/cli-utils.h: Rename include guard.
10594         * cli/cli-style.h: Rename include guard.
10595         * cli/cli-setshow.h: Rename include guard.
10596         * cli/cli-script.h: Rename include guard.
10597         * cli/cli-interp.h: Rename include guard.
10598         * cli/cli-decode.h: Rename include guard.
10599         * cli/cli-cmds.h: Rename include guard.
10600         * charset-list.h: Add include guard.
10601         * buildsym-legacy.h: Rename include guard.
10602         * bfin-tdep.h: Add include guard.
10603         * ax.h: Rename include guard.
10604         * arm-linux-tdep.h: Add include guard.
10605         * arm-fbsd-tdep.h: Add include guard.
10606         * arch/xtensa.h: Rename include guard.
10607         * arch/tic6x.h: Add include guard.
10608         * arch/i386.h: Add include guard.
10609         * arch/arm.h: Rename include guard.
10610         * arch/arm-linux.h: Rename include guard.
10611         * arch/arm-get-next-pcs.h: Rename include guard.
10612         * arch/amd64.h: Add include guard.
10613         * arch/aarch64-insn.h: Rename include guard.
10614         * arch-utils.h: Rename include guard.
10615         * annotate.h: Add include guard.
10616         * amd64-darwin-tdep.h: Rename include guard.
10617         * aarch64-linux-tdep.h: Add include guard.
10618         * aarch64-fbsd-tdep.h: Add include guard.
10619         * aarch32-linux-nat.h: Add include guard.
10620
10621 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10622
10623         * macrotab.c (macro_define_internal): New function that
10624         factorizes macro_define_object_internal and macro_define_function
10625         code.
10626         (macro_define_object_internal): Use macro_define_internal.
10627         (macro_define_function): Likewise.
10628
10629 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10630
10631         * macrocmd.c (extract_identifier): Return
10632         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10633         callers.
10634
10635 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10636
10637         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10638
10639 2019-02-05  Tom Tromey  <tom@tromey.com>
10640
10641         * target.c (target_stack::unpush): Move assertion earlier.
10642
10643 2019-01-30  Tom Tromey  <tom@tromey.com>
10644
10645         PR python/23615:
10646         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10647         (gdbpy_parse_and_eval): Likewise.
10648         * python/python-internal.h (gdbpy_allow_threads): New class.
10649
10650 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10651
10652         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10653         (aarch64_fbsd_fpregmap): Move earlier.
10654         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10655         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10656         instead of individual calls to trad_frame_set_reg_addr.
10657         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10658         earlier.
10659         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10660         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10661         instead of individual calls to trad_frame_set_reg_addr.
10662
10663 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10664
10665         * CONTRIBUTE: Replace contribution list with wiki link.
10666
10667 2019-01-25  Tom Tromey  <tom@tromey.com>
10668
10669         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10670
10671 2019-01-25  Tom Tromey  <tom@tromey.com>
10672
10673         * xtensa-linux-nat.c: Fix common/ includes.
10674         * xml-support.h: Fix common/ includes.
10675         * xml-support.c: Fix common/ includes.
10676         * x86-linux-nat.c: Fix common/ includes.
10677         * windows-nat.c: Fix common/ includes.
10678         * varobj.h: Fix common/ includes.
10679         * varobj.c: Fix common/ includes.
10680         * value.c: Fix common/ includes.
10681         * valops.c: Fix common/ includes.
10682         * utils.c: Fix common/ includes.
10683         * unittests/xml-utils-selftests.c: Fix common/ includes.
10684         * unittests/utils-selftests.c: Fix common/ includes.
10685         * unittests/unpack-selftests.c: Fix common/ includes.
10686         * unittests/tracepoint-selftests.c: Fix common/ includes.
10687         * unittests/style-selftests.c: Fix common/ includes.
10688         * unittests/string_view-selftests.c: Fix common/ includes.
10689         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10690         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10691         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10692         * unittests/rsp-low-selftests.c: Fix common/ includes.
10693         * unittests/parse-connection-spec-selftests.c: Fix common/
10694         includes.
10695         * unittests/optional-selftests.c: Fix common/ includes.
10696         * unittests/offset-type-selftests.c: Fix common/ includes.
10697         * unittests/observable-selftests.c: Fix common/ includes.
10698         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10699         * unittests/memrange-selftests.c: Fix common/ includes.
10700         * unittests/memory-map-selftests.c: Fix common/ includes.
10701         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10702         * unittests/function-view-selftests.c: Fix common/ includes.
10703         * unittests/environ-selftests.c: Fix common/ includes.
10704         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10705         * unittests/common-utils-selftests.c: Fix common/ includes.
10706         * unittests/cli-utils-selftests.c: Fix common/ includes.
10707         * unittests/array-view-selftests.c: Fix common/ includes.
10708         * ui-file.c: Fix common/ includes.
10709         * tui/tui-io.c: Fix common/ includes.
10710         * tracepoint.h: Fix common/ includes.
10711         * tracepoint.c: Fix common/ includes.
10712         * tracefile-tfile.c: Fix common/ includes.
10713         * top.h: Fix common/ includes.
10714         * top.c: Fix common/ includes.
10715         * thread.c: Fix common/ includes.
10716         * target/waitstatus.h: Fix common/ includes.
10717         * target/waitstatus.c: Fix common/ includes.
10718         * target.h: Fix common/ includes.
10719         * target.c: Fix common/ includes.
10720         * target-memory.c: Fix common/ includes.
10721         * target-descriptions.c: Fix common/ includes.
10722         * symtab.h: Fix common/ includes.
10723         * symfile.c: Fix common/ includes.
10724         * stap-probe.c: Fix common/ includes.
10725         * spu-linux-nat.c: Fix common/ includes.
10726         * sparc-nat.c: Fix common/ includes.
10727         * source.c: Fix common/ includes.
10728         * solib.c: Fix common/ includes.
10729         * solib-target.c: Fix common/ includes.
10730         * ser-unix.c: Fix common/ includes.
10731         * ser-tcp.c: Fix common/ includes.
10732         * ser-pipe.c: Fix common/ includes.
10733         * ser-base.c: Fix common/ includes.
10734         * selftest-arch.c: Fix common/ includes.
10735         * s12z-tdep.c: Fix common/ includes.
10736         * rust-exp.y: Fix common/ includes.
10737         * rs6000-aix-tdep.c: Fix common/ includes.
10738         * riscv-tdep.c: Fix common/ includes.
10739         * remote.c: Fix common/ includes.
10740         * remote-notif.h: Fix common/ includes.
10741         * remote-fileio.h: Fix common/ includes.
10742         * remote-fileio.c: Fix common/ includes.
10743         * regcache.h: Fix common/ includes.
10744         * regcache.c: Fix common/ includes.
10745         * record-btrace.c: Fix common/ includes.
10746         * python/python.c: Fix common/ includes.
10747         * python/py-type.c: Fix common/ includes.
10748         * python/py-inferior.c: Fix common/ includes.
10749         * progspace.h: Fix common/ includes.
10750         * producer.c: Fix common/ includes.
10751         * procfs.c: Fix common/ includes.
10752         * proc-api.c: Fix common/ includes.
10753         * printcmd.c: Fix common/ includes.
10754         * ppc-linux-nat.c: Fix common/ includes.
10755         * parser-defs.h: Fix common/ includes.
10756         * osdata.c: Fix common/ includes.
10757         * obsd-nat.c: Fix common/ includes.
10758         * nat/x86-linux.c: Fix common/ includes.
10759         * nat/x86-linux-dregs.c: Fix common/ includes.
10760         * nat/x86-dregs.h: Fix common/ includes.
10761         * nat/x86-dregs.c: Fix common/ includes.
10762         * nat/ppc-linux.c: Fix common/ includes.
10763         * nat/mips-linux-watch.h: Fix common/ includes.
10764         * nat/mips-linux-watch.c: Fix common/ includes.
10765         * nat/linux-waitpid.c: Fix common/ includes.
10766         * nat/linux-ptrace.h: Fix common/ includes.
10767         * nat/linux-ptrace.c: Fix common/ includes.
10768         * nat/linux-procfs.c: Fix common/ includes.
10769         * nat/linux-personality.c: Fix common/ includes.
10770         * nat/linux-osdata.c: Fix common/ includes.
10771         * nat/linux-namespaces.c: Fix common/ includes.
10772         * nat/linux-btrace.h: Fix common/ includes.
10773         * nat/linux-btrace.c: Fix common/ includes.
10774         * nat/fork-inferior.c: Fix common/ includes.
10775         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10776         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10777         * nat/aarch64-linux.c: Fix common/ includes.
10778         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10779         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10780         * namespace.h: Fix common/ includes.
10781         * mips-linux-tdep.c: Fix common/ includes.
10782         * minsyms.c: Fix common/ includes.
10783         * mi/mi-parse.h: Fix common/ includes.
10784         * mi/mi-main.c: Fix common/ includes.
10785         * mi/mi-cmd-env.c: Fix common/ includes.
10786         * memrange.h: Fix common/ includes.
10787         * memattr.c: Fix common/ includes.
10788         * maint.h: Fix common/ includes.
10789         * maint.c: Fix common/ includes.
10790         * main.c: Fix common/ includes.
10791         * machoread.c: Fix common/ includes.
10792         * location.c: Fix common/ includes.
10793         * linux-thread-db.c: Fix common/ includes.
10794         * linux-nat.c: Fix common/ includes.
10795         * linux-fork.c: Fix common/ includes.
10796         * inline-frame.c: Fix common/ includes.
10797         * infrun.c: Fix common/ includes.
10798         * inflow.c: Fix common/ includes.
10799         * inferior.h: Fix common/ includes.
10800         * inferior.c: Fix common/ includes.
10801         * infcmd.c: Fix common/ includes.
10802         * inf-ptrace.c: Fix common/ includes.
10803         * inf-child.c: Fix common/ includes.
10804         * ia64-linux-nat.c: Fix common/ includes.
10805         * i387-tdep.c: Fix common/ includes.
10806         * i386-tdep.c: Fix common/ includes.
10807         * i386-linux-tdep.c: Fix common/ includes.
10808         * i386-linux-nat.c: Fix common/ includes.
10809         * i386-go32-tdep.c: Fix common/ includes.
10810         * i386-fbsd-tdep.c: Fix common/ includes.
10811         * i386-fbsd-nat.c: Fix common/ includes.
10812         * guile/scm-type.c: Fix common/ includes.
10813         * guile/guile.c: Fix common/ includes.
10814         * go32-nat.c: Fix common/ includes.
10815         * gnu-nat.c: Fix common/ includes.
10816         * gdbthread.h: Fix common/ includes.
10817         * gdbarch-selftests.c: Fix common/ includes.
10818         * gdb_usleep.c: Fix common/ includes.
10819         * gdb_select.h: Fix common/ includes.
10820         * gdb_bfd.c: Fix common/ includes.
10821         * gcore.c: Fix common/ includes.
10822         * fork-child.c: Fix common/ includes.
10823         * findvar.c: Fix common/ includes.
10824         * fbsd-nat.c: Fix common/ includes.
10825         * event-top.c: Fix common/ includes.
10826         * event-loop.c: Fix common/ includes.
10827         * dwarf2read.c: Fix common/ includes.
10828         * dwarf2loc.c: Fix common/ includes.
10829         * dwarf2-frame.c: Fix common/ includes.
10830         * dwarf-index-cache.c: Fix common/ includes.
10831         * dtrace-probe.c: Fix common/ includes.
10832         * disasm-selftests.c: Fix common/ includes.
10833         * defs.h: Fix common/ includes.
10834         * csky-tdep.c: Fix common/ includes.
10835         * cp-valprint.c: Fix common/ includes.
10836         * cp-support.h: Fix common/ includes.
10837         * cp-support.c: Fix common/ includes.
10838         * corelow.c: Fix common/ includes.
10839         * completer.h: Fix common/ includes.
10840         * completer.c: Fix common/ includes.
10841         * compile/compile.c: Fix common/ includes.
10842         * compile/compile-loc2c.c: Fix common/ includes.
10843         * compile/compile-cplus-types.c: Fix common/ includes.
10844         * compile/compile-cplus-symbols.c: Fix common/ includes.
10845         * command.h: Fix common/ includes.
10846         * cli/cli-dump.c: Fix common/ includes.
10847         * cli/cli-cmds.c: Fix common/ includes.
10848         * charset.c: Fix common/ includes.
10849         * build-id.c: Fix common/ includes.
10850         * btrace.h: Fix common/ includes.
10851         * btrace.c: Fix common/ includes.
10852         * breakpoint.h: Fix common/ includes.
10853         * breakpoint.c: Fix common/ includes.
10854         * ax.h:
10855         (enum agent_op): Fix common/ includes.
10856         * ax-general.c (struct aop_map): Fix common/ includes.
10857         * ax-gdb.c: Fix common/ includes.
10858         * auxv.c: Fix common/ includes.
10859         * auto-load.c: Fix common/ includes.
10860         * arm-tdep.c: Fix common/ includes.
10861         * arch/riscv.c: Fix common/ includes.
10862         * arch/ppc-linux-common.c: Fix common/ includes.
10863         * arch/i386.c: Fix common/ includes.
10864         * arch/arm.c: Fix common/ includes.
10865         * arch/arm-linux.c: Fix common/ includes.
10866         * arch/arm-get-next-pcs.c: Fix common/ includes.
10867         * arch/amd64.c: Fix common/ includes.
10868         * arch/aarch64.c: Fix common/ includes.
10869         * arch/aarch64-insn.c: Fix common/ includes.
10870         * arch-utils.c: Fix common/ includes.
10871         * amd64-windows-tdep.c: Fix common/ includes.
10872         * amd64-tdep.c: Fix common/ includes.
10873         * amd64-sol2-tdep.c: Fix common/ includes.
10874         * amd64-obsd-tdep.c: Fix common/ includes.
10875         * amd64-nbsd-tdep.c: Fix common/ includes.
10876         * amd64-linux-tdep.c: Fix common/ includes.
10877         * amd64-linux-nat.c: Fix common/ includes.
10878         * amd64-fbsd-tdep.c: Fix common/ includes.
10879         * amd64-fbsd-nat.c: Fix common/ includes.
10880         * amd64-dicos-tdep.c: Fix common/ includes.
10881         * amd64-darwin-tdep.c: Fix common/ includes.
10882         * agent.c: Fix common/ includes.
10883         * ada-lang.h: Fix common/ includes.
10884         * ada-lang.c: Fix common/ includes.
10885         * aarch64-tdep.c: Fix common/ includes.
10886
10887 2019-01-25  Tom Tromey  <tom@tromey.com>
10888
10889         * common/create-version.sh: Use common/version.h.
10890
10891 2019-01-24  Pedro Alves  <palves@redhat.com>
10892
10893         * infrun.c (signal_stop, signal_print, signal_program)
10894         (signal_catch, signal_pass): Now arrays instead of pointers.
10895         (update_signals_program_target, do_target_resume)
10896         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10897         * linux-nat.c (linux_nat_target::pass_signals)
10898         (linux_nat_target::create_inferior, linux_nat_target::attach):
10899         Adjust.
10900         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10901         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10902         * procfs.c (procfs_target::pass_signals): Adjust.
10903         * record-full.c (record_full_target::resume): Adjust.
10904         * remote.c (remote_target::pass_signals)
10905         (remote_target::program_signals): Adjust.
10906         * target-debug.h (target_debug_print_signals): Now takes a
10907         gdb::array_view as parameter.  Adjust.
10908         * target.h (target_ops) <pass_signals, program_signals>: Replace
10909         pointer and length parameters with gdb::array_view.
10910         (target_pass_signals, target_program_signals): Likewise.
10911         * target-delegates.c: Regenerate.
10912
10913 2019-01-24  Pedro Alves  <palves@redhat.com>
10914
10915         * common/forward-scope-exit.h
10916         (forward_scope_exit::forward_scope_exit): Pass arguments to
10917         m_bind_function directly, instead of creating a std::bind and
10918         copying that.
10919
10920 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10921
10922         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10923         for static members.
10924         (pass_in_v_vfp_candidate): Likewise.
10925
10926 2019-01-23  Tom Tromey  <tom@tromey.com>
10927             Pedro Alves  <palves@redhat.com>
10928
10929         * regcache.c (class regcache_invalidator): Remove.
10930         (regcache::raw_write): Use make_scope_exit.
10931
10932 2019-01-23  Tom Tromey  <tom@tromey.com>
10933
10934         * ui-out.h (class ui_out_emit_type): Update comment.
10935
10936 2019-01-23  Tom Tromey  <tom@tromey.com>
10937
10938         * infrun.c (fetch_inferior_event): Update comment.
10939
10940 2019-01-23  Tom Tromey  <tom@tromey.com>
10941             Pedro Alves  <palves@redhat.com>
10942
10943         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10944         parameter.
10945         (fetch_inferior_event): Use SCOPE_EXIT.
10946
10947
10948 2019-01-23  Tom Tromey  <tom@tromey.com>
10949             Pedro Alves  <palves@redhat.com>
10950
10951         * infrun.c (disable_thread_events): Delete.
10952         (stop_all_threads): Use SCOPE_EXIT.
10953
10954 2019-01-23  Tom Tromey  <tom@tromey.com>
10955             Pedro Alves  <palves@redhat.com>
10956
10957         * symfile.c: Include forward-scope-exit.h.
10958         (clear_symtab_users_cleanup): Replace forward declaration with
10959         a FORWARD_SCOPE_EXIT.
10960         (syms_from_objfile_1): Use the forward_scope_exit and
10961         gdb::optional instead of cleanup_function.
10962         (reread_symbols): Use the forward_scope_exit instead of
10963         cleanup_function.
10964         (clear_symtab_users_cleanup): Remove function.
10965
10966 2019-01-23  Tom Tromey  <tom@tromey.com>
10967             Pedro Alves  <palves@redhat.com>
10968
10969         * linux-nat.c: Include scope-exit.h.
10970         (cleanup_target_stop): Remove.
10971         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10972         SCOPE_EXIT.
10973
10974 2019-01-23  Tom Tromey  <tom@tromey.com>
10975             Pedro Alves  <palves@redhat.com>
10976
10977         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10978         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10979
10980 2019-01-23  Tom Tromey  <tom@tromey.com>
10981             Andrew Burgess  <andrew.burgess@embecosm.com>
10982             Pedro Alves  <palves@redhat.com>
10983
10984         * infrun.c (fetch_inferior_event): Use scope_exit.
10985         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10986         * top.c (execute_command): Use scope_exit.
10987         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10988         * utils.c (do_bpstat_clear_actions_cleanup)
10989         (make_bpstat_clear_actions_cleanup): Remove.
10990
10991 2019-01-23  Tom Tromey  <tom@tromey.com>
10992             Pedro Alves  <palves@redhat.com>
10993
10994         * infrun.c: Include "common/scope-exit.h"
10995         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10996         (wait_for_inferior): Use SCOPE_EXIT.
10997         (fetch_inferior_event): Use scope_exit.
10998
10999 2019-01-23  Tom Tromey  <tom@tromey.com>
11000             Pedro Alves  <palves@redhat.com>
11001
11002         * breakpoint.c (create_breakpoint): Remove cleanup.
11003
11004 2019-01-23  Tom Tromey  <tom@tromey.com>
11005             Andrew Burgess  <andrew.burgess@embecosm.com>
11006             Pedro Alves  <palves@redhat.com>
11007
11008 2019-01-23  Pedro Alves  <palves@redhat.com>
11009
11010         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11011
11012 2019-01-23  Pedro Alves  <palves@redhat.com>
11013             Andrew Burgess  <andrew.burgess@embecosm.com>
11014
11015         * gdbthread.h: Include "common/forward-scope-exit.h".
11016         (scoped_finish_thread_state): Redefine custom class in terms of
11017         forward_scope_exit.
11018
11019 2019-01-23  Pedro Alves  <palves@redhat.com>
11020             Andrew Burgess  <andrew.burgess@embecosm.com>
11021
11022         * common/forward-scope-exit.h: New file.
11023
11024 2019-01-23  Pedro Alves  <palves@redhat.com>
11025             Andrew Burgess  <andrew.burgess@embecosm.com>
11026             Tom Tromey  <tom@tromey.com>
11027
11028         * common/scope-exit.h: New file.
11029
11030 2019-01-23  Pedro Alves  <palves@redhat.com>
11031
11032         * common/preprocessor.h (ESC): Rename to ...
11033         (ESC_PARENS): ... this.
11034         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11035         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11036
11037 2019-01-23  Tom Tromey  <tom@tromey.com>
11038
11039         * language.h (class scoped_switch_to_sym_language_if_auto):
11040         Initialize m_lang in both cases.
11041
11042 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11043
11044         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11045         with XCNEW.
11046
11047 2019-01-22  Tom Tromey  <tom@tromey.com>
11048
11049         * corelow.c: Do not include sys/file.h.
11050
11051 2019-01-22  Tom Tromey  <tom@tromey.com>
11052
11053         * tui/tui-wingeneral.h: Include gdb_curses.h.
11054
11055 2019-01-22  Tom Tromey  <tom@tromey.com>
11056
11057         * source-cache.h (class source_cache) <get_source_lines,
11058         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11059
11060 2019-01-22  Tom Tromey  <tom@tromey.com>
11061
11062         * remote-fileio.h (struct remote_target): Declare.
11063
11064 2019-01-22  Tom Tromey  <tom@tromey.com>
11065
11066         * python/py-arch.c: Do not include py-ref.h.
11067         * python/py-bpevent.c: Do not include py-ref.h.
11068         * python/py-cmd.c: Do not include py-ref.h.
11069         * python/py-continueevent.c: Do not include py-ref.h.
11070         * python/py-event.h: Do not include py-ref.h.
11071         * python/py-evtregistry.c: Do not include py-ref.h.
11072         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11073         * python/py-frame.c: Do not include py-ref.h.
11074         * python/py-framefilter.c: Do not include py-ref.h.
11075         * python/py-function.c: Do not include py-ref.h.
11076         * python/py-infevents.c: Do not include py-ref.h.
11077         * python/py-linetable.c: Do not include py-ref.h.
11078         * python/py-objfile.c: Do not include py-ref.h.
11079         * python/py-param.c: Do not include py-ref.h.
11080         * python/py-prettyprint.c: Do not include py-ref.h.
11081         * python/py-progspace.c: Do not include py-ref.h.
11082         * python/py-symbol.c: Do not include py-ref.h.
11083         * python/py-symtab.c: Do not include py-ref.h.
11084         * python/py-type.c: Do not include py-ref.h.
11085         * python/py-unwind.c: Do not include py-ref.h.
11086         * python/py-utils.c: Do not include py-ref.h.
11087         * python/py-value.c: Do not include py-ref.h.
11088         * python/py-varobj.c: Do not include py-ref.h.
11089         * python/py-xmethods.c: Do not include py-ref.h.
11090         * python/python.c: Do not include py-ref.h.
11091         * varobj.c: Do not include py-ref.h.
11092
11093 2019-01-22  Tom Tromey  <tom@tromey.com>
11094
11095         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11096         keyword for bcache.
11097
11098 2019-01-22  Tom Tromey  <tom@tromey.com>
11099
11100         * compile/compile-cplus-types.c: Remove a comment by #include.
11101
11102 2019-01-22  Tom Tromey  <tom@tromey.com>
11103
11104         * compile/gcc-c-plugin.h: Include compile-internal.h.
11105
11106 2019-01-22  Tom Tromey  <tom@tromey.com>
11107
11108         * stabsread.c (EXTERN): Do not define.
11109         (symnum, next_symbol_text_func, processing_gcc_compilation)
11110         (within_function, global_sym_chain, global_stabs)
11111         (previous_stab_code, this_object_header_files)
11112         (n_this_object_header_files)
11113         (n_allocated_this_object_header_files): Define.
11114         * stabsread.h (EXTERN): Never define.  Use "extern".
11115
11116 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11117
11118         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11119         history_value.
11120
11121 2019-01-21  Tom Tromey  <tom@tromey.com>
11122
11123         * ui-out.c: Fix includes.
11124         * tui/tui-source.c: Fix includes.
11125         * target.c: Fix includes.
11126         * remote.c: Fix includes.
11127         * regcache.c: Fix includes.
11128         * python/py-block.c: Fix includes.
11129         * printcmd.c: Fix includes.
11130         * or1k-tdep.c: Fix includes.
11131         * mi/mi-main.c: Fix includes.
11132         * m32r-tdep.c: Fix includes.
11133         * csky-tdep.c: Fix includes.
11134         * compile/compile-cplus-types.c: Fix includes.
11135         * cli/cli-interp.c: Fix includes.
11136
11137 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11138
11139         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11140         for padding.
11141
11142 2019-01-16  Tom Tromey  <tom@tromey.com>
11143
11144         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11145         earlier.
11146         (struct objfile) <msymbols_range>: Move from top level.
11147         <msymbols>: New method.
11148         (class objfile_msymbols): Remove.
11149         * symtab.c (default_collect_symbol_completion_matches_break_on):
11150         Update.
11151         * symmisc.c (dump_msymbols): Update.
11152         * stabsread.c (scan_file_globals): Update.
11153         * objc-lang.c (info_selectors_command, info_classes_command)
11154         (find_methods): Update.
11155         * minsyms.c (find_solib_trampoline_target): Update.
11156         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11157         * coffread.c (coff_symfile_read): Update.
11158         * ada-lang.c (ada_lookup_simple_minsym)
11159         (ada_collect_symbol_completion_matches): Update.
11160
11161 2019-01-16  Tom Tromey  <tom@tromey.com>
11162
11163         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11164         type.  Remove no-argument constructor.
11165         <iterator::operator++>: Simplify.
11166         <begin>: Update.
11167         <end>: Use minimal_symbol_count.
11168
11169 2019-01-16  Tom Tromey  <tom@tromey.com>
11170
11171         * objfiles.h (struct objfile) <psymtabs>: New method.
11172         (class objfile_psymtabs): Remove.
11173         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11174         typedef.
11175         <range>: New method.
11176         (require_partial_symbols): Change return type.
11177         * psymtab.c (require_partial_symbols)
11178         (psym_expand_symtabs_matching): Update.
11179         * mdebugread.c (parse_partial_symbols): Update.
11180         * dbxread.c (dbx_end_psymtab): Update.
11181
11182 2019-01-15  Tom Tromey  <tom@tromey.com>
11183
11184         * symtab.c (lookup_objfile_from_block)
11185         (lookup_symbol_in_objfile_symtabs)
11186         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11187         (find_line_symtab, info_sources_command)
11188         (default_collect_symbol_completion_matches_break_on)
11189         (make_source_files_completion_list): Update.
11190         * symmisc.c (print_objfile_statistics, dump_objfile)
11191         (maintenance_print_symbols, maintenance_info_symtabs)
11192         (maintenance_check_symtabs, maintenance_info_line_tables):
11193         Update.
11194         * source.c (select_source_symtab)
11195         (forget_cached_source_info_for_objfile): Update.
11196         * objfiles.h (class objfile_compunits): Remove.
11197         (struct objfile) <compunits_range>: New typedef.
11198         (compunits): New method.
11199         * objfiles.c (objfile_relocate1): Update.
11200         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11201         * maint.c (count_symtabs_and_blocks): Update.
11202         * linespec.c (iterate_over_all_matching_symtabs): Update.
11203         * cp-support.c (add_symbol_overload_list_qualified): Update.
11204         * coffread.c (coff_symtab_read): Update.
11205         * ada-lang.c (add_nonlocal_symbols)
11206         (ada_collect_symbol_completion_matches)
11207         (ada_add_global_exceptions): Update.
11208
11209 2019-01-15  Tom Tromey  <tom@tromey.com>
11210
11211         * progspace.h (program_space) <objfiles_safe_range>: New
11212         typedef.
11213         <objfiles_safe>: New method.
11214         * objfiles.h (class all_objfiles_safe): Remove.
11215         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11216         * jit.c (jit_inferior_exit_hook): Update.
11217
11218 2019-01-17  Tom Tromey  <tom@tromey.com>
11219
11220         * progspace.h (program_space) <objfiles_range>: New typedef.
11221         <objfiles>: New method.
11222         <objfiles_head>: Rename from objfiles.
11223         (object_files): Update.
11224         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11225         * guile/scm-pretty-print.c
11226         (ppscm_find_pretty_printer_from_objfiles): Update.
11227         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11228         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11229         Update.
11230         * python/py-progspace.c (pspy_get_objfiles): Update.
11231         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11232         Update.
11233         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11234         (objfpy_lookup_objfile_by_build_id): Update.
11235         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11236         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11237         Update.
11238         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11239         (expand_symtab_containing_pc, lookup_objfile_from_block)
11240         (lookup_static_symbol, basic_lookup_transparent_type)
11241         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11242         (find_line_symtab, info_sources_command)
11243         (default_collect_symbol_completion_matches_break_on)
11244         (make_source_files_completion_list, find_main_name): Update.
11245         * symmisc.c (print_symbol_bcache_statistics)
11246         (print_objfile_statistics, maintenance_print_symbols)
11247         (maintenance_print_msymbols, maintenance_print_objfiles)
11248         (maintenance_info_symtabs, maintenance_check_symtabs)
11249         (maintenance_expand_symtabs, maintenance_info_line_tables):
11250         Update.
11251         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11252         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11253         (map_overlay_command, unmap_overlay_command)
11254         (simple_overlay_update, expand_symtabs_matching)
11255         (map_symbol_filenames): Update.
11256         * symfile-debug.c (set_debug_symfile): Update.
11257         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11258         Update.
11259         * source.c (select_source_symtab, forget_cached_source_info):
11260         Update.
11261         * solib.c (solib_read_symbols): Update.
11262         * solib-spu.c (append_ocl_sos): Update.
11263         * psymtab.c (maintenance_print_psymbols)
11264         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11265         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11266         * printcmd.c (info_symbol_command): Update.
11267         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11268         Update.
11269         * objfiles.h (class all_objfiles): Remove.
11270         * objfiles.c (have_partial_symbols, have_full_symbols)
11271         (have_minimal_symbols, qsort_cmp, update_section_map)
11272         (shared_objfile_contains_address_p)
11273         (default_iterate_over_objfiles_in_search_order): Update.
11274         * objc-lang.c (info_selectors_command, info_classes_command)
11275         (find_methods): Update.
11276         * minsyms.c (find_solib_trampoline_target): Update.
11277         * maint.c (maintenance_info_sections)
11278         (maintenance_translate_address, count_symtabs_and_blocks):
11279         Update.
11280         * main.c (captured_main_1): Update.
11281         * linux-thread-db.c (try_thread_db_load_from_pdir)
11282         (has_libpthread): Update.
11283         * linespec.c (iterate_over_all_matching_symtabs)
11284         (search_minsyms_for_name): Update.
11285         * jit.c (jit_find_objf_with_entry_addr): Update.
11286         * hppa-tdep.c (find_unwind_entry)
11287         (hppa_lookup_stub_minimal_symbol): Update.
11288         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11289         Update.
11290         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11291         (elf_gnu_ifunc_resolve_by_got): Update.
11292         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11293         * dwarf-index-write.c (save_gdb_index_command): Update.
11294         * cp-support.c (add_symbol_overload_list_qualified): Update.
11295         * breakpoint.c (create_overlay_event_breakpoint)
11296         (create_longjmp_master_breakpoint)
11297         (create_std_terminate_master_breakpoint)
11298         (create_exception_master_breakpoint): Update.
11299         * blockframe.c (find_pc_partial_function): Update.
11300         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11301         (ada_collect_symbol_completion_matches)
11302         (ada_add_global_exceptions): Update.
11303
11304 2019-01-17  Tom Tromey  <tom@tromey.com>
11305
11306         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11307         declare VEC.
11308         (solib_target_parse_libraries): Change return type.
11309         (library_list_start_segment, library_list_start_section)
11310         (library_list_end_library, library_list_start_library); Update.
11311         (solib_target_free_library_list): Remove.
11312         (solib_target_parse_libraries): Remove cleanup.  Change return
11313         type.
11314         (solib_target_current_sos): Update.
11315
11316 2019-01-17  Tom Tromey  <tromey@bapiya>
11317
11318         * valprint.c: Replace "the the" with "the".
11319         * symtab.c: Replace "the the" with "the".
11320         * solib.c: Replace "the the" with "the".
11321         * solib-dsbt.c: Replace "the the" with "the".
11322         * linespec.c: Replace "the the" with "the".
11323         * dwarf2loc.h: Replace "the the" with "the".
11324         * amd64-windows-tdep.c: Replace "the the" with "the".
11325         * aarch64-tdep.c: Replace "the the" with "the".
11326
11327 2019-01-16  Keith Seitz  <keiths@redhat.com>
11328
11329         PR gdb/23773
11330         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11331         <builder>: Rename to ..
11332         <m_builder>: ... this and make private.
11333         (dwarf2_cu::get_builder): New method.  Change all users of
11334         `builder' to use this method.
11335         (dwarf2_start_symtab): Move to ...
11336         (dwarf2_cu::start_symtab): ... here.  Update all callers
11337         (setup_type_unit_groups): Move to ...
11338         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11339         callers.
11340         (dwarf2_cu::reset_builder): New method.
11341         (process_full_compunit, process_full_type_unit): Use
11342         dwarf2_cu::reset_builder.
11343         (follow_die_offset): Record the ancestor CU if it is different
11344         from the followed DIE's CU.
11345         (follow_die_sig_1): Likewise.
11346
11347 2019-01-15  Tom Tromey  <tom@tromey.com>
11348
11349         * remote.c (class remote_state) <buf>: Now a char_vector.
11350         <buf_size>: Remove.
11351         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11352         parameter.
11353         (remote_target::getpkt_or_notif_sane_1)
11354         (remote_target::getpkt_sane)
11355         (remote_target::getpkt_or_notif_sane): Likewise.
11356         (class remote_target) <putpkt>: New overload.
11357         (remote_target::read_frame): Change type of "buf_p".  Remove
11358         sizeof_p parameter.
11359         (packet_ok): New overload.
11360         (packet_check_result): New overload.
11361         Update all uses.
11362
11363 2019-01-14  Tom Tromey  <tom@tromey.com>
11364
11365         * remote-notif.c (handle_notification, remote_notif_ack)
11366         (remote_notif_parse): Make "buf" const.
11367         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11368         const.
11369         (remote_notif_parse, remote_notif_ack, handle_notification):
11370         Likewise.
11371         * remote.c (remote_notif_stop_parse): Make "buf" const.
11372         (remote_target::remote_parse_stop_reply): Make "buf" const.
11373         (remote_notif_stop_ack): Make "buf" const.
11374
11375 2019-01-14  Tom Tromey  <tom@tromey.com>
11376
11377         * remote.c (remote_console_output): Make parameter const.
11378
11379 2019-01-14  Tom Tromey  <tom@tromey.com>
11380
11381         * target-debug.h (target_debug_print_signals): Constify.
11382         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11383         * procfs.c (procfs_target::pass_signals): Update.
11384         * linux-nat.c (linux_nat_target::pass_signals): Update.
11385         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11386         * target-delegates.c: Rebuild.
11387         * remote.c (remote_target::program_signals): Update.
11388         (remote_target::pass_signals): Update.
11389         * target.c (target_pass_signals): Constify argument.
11390         (target_program_signals): Likewise.
11391         * target.h (struct target_ops) <pass_signals, program_signals>:
11392         Constify argument.
11393         (target_pass_signals, target_program_signals): Constify argument.
11394
11395 2019-01-14  Tom Tromey  <tom@tromey.com>
11396
11397         PR tui/28819:
11398         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11399
11400 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11401
11402         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11403         field.
11404         * rs6000-tdep.c: Include reggroups.h.
11405         (IS_V_ALIAS_PSEUDOREG): Define.
11406         (rs6000_register_name): Return names for the "vX" aliases.
11407         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11408         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11409         aliases.  Call default_register_reggroup_p for all other
11410         pseudo-registers.
11411         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11412         New functions.
11413         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11414         Handle "vX" aliases.
11415         (v_alias_pseudo_register_collect): New function.
11416         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11417         (rs6000_gdbarch_init): Initialize "vX" aliases as
11418         pseudo-registers.  Restore registration of
11419         rs6000_pseudo_register_reggroup_p with
11420         set_tdesc_pseudo_register_reggroup_p.
11421
11422 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11423
11424         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11425         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11426         set_gdbarch_num_pseudo_regs.
11427
11428 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11429
11430         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11431         Remove arg prefixname, add do_set and do_show.
11432         Add member functions set_list and show_list.
11433         * cli/cli-style.c (class cli_style_option): Update accordingly.
11434         (style_set_list): Move to file scope.
11435         (style_show_list): Likewise.
11436         (set_style): Call help_list.
11437         (show_style): Call cmd_show_list.
11438         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11439         Update to use the new macro.
11440
11441 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11442
11443         * ada-lang.c (_initialize_ada_language): Expand the help text
11444         for the "catch exception" command.
11445
11446 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11447
11448         * symtab.c (matching_obj_sections): Initialize obj,
11449         declare it closer to its usage.
11450
11451 2019-01-10  Tom Tromey  <tom@tromey.com>
11452
11453         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11454         (basic_inf_threads_range): Remove.
11455         (inf_threads_range, inf_non_exited_threads_range)
11456         (safe_inf_threads_range): Use next_adapter.
11457
11458 2019-01-10  Keith Seitz  <keiths@redhat.com>
11459
11460         PR gdb/23712
11461         PR symtab/23010
11462         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11463         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11464
11465 2019-01-10  Keith Seitz  <keiths@redhat.com>
11466
11467         PR gdb/23712
11468         PR symtab/23010
11469         * dictionary.c (pending_to_vector): Remove.
11470         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11471         Remove _1 suffix, replacing functions of the same name.  Update
11472         all callers.
11473         (dict_create_hashed, dict_create_hashed_expandable)
11474         (dict_create_linear, dict_create_linear_expandable, dict_free)
11475         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11476         Make functions static.
11477
11478 2019-01-10  Keith Seitz  <keiths@redhat.com>
11479
11480         PR gdb/23712
11481         PR symtab/23010
11482         * dictionary.h (struct dictionary): Replace declaration with
11483         multidictionary.
11484         (dict_create_hashed, dict_create_hashed_expandable)
11485         (dict_create_linear, dict_create_linear_expandable)
11486         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11487         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11488         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11489         taking multidictionary argument.
11490         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11491         * block.h (struct block) <dict>: Change to multidictionary
11492         and rename `multidict'.
11493         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11494         symmisc.c: Update all dictionary references to multidictionary.
11495
11496 2019-01-10  Keith Seitz  <keiths@redhat.com>
11497
11498         PR gdb/23712
11499         PR symtab/23010
11500         * dictionary.c: Include unordered_map.
11501         (pending_to_vector): New function.
11502         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11503         Rewrite the non-"_1" functions to take vector instead
11504         of linked list.
11505         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11506         "new" _1 versions of the same name.
11507         (multidictionary): Define.
11508         (std::hash<enum language): New definition.
11509         (collate_pending_symbols_by_language, mdict_create_hashed)
11510         (mdict_create_hashed_expandable, mdict_create_linear)
11511         (mdict_create_linear_expandable, mdict_free)
11512         (find_language_dictionary, create_new_language_dictionary)
11513         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11514         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11515         (mdict_size, mdict_empty): New functions.
11516         * dictionary.h (mdict_iterator): Define.
11517
11518 2019-01-10  Pedro Alves  <palves@redhat.com>
11519
11520         * breakpoint.c (read_uploaded_action)
11521         (create_tracepoint_from_upload): Adjust to use
11522         gdb::unique_xmalloc_ptr.
11523         * ctf.c (ctf_write_uploaded_tp):
11524         (SET_ARRAY_FIELD): Use emplace_back.
11525         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11526         * tracefile-tfile.c (tfile_write_uploaded_tp):
11527         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11528         gdb::unique_xmalloc_ptr.
11529         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11530         at_string, cond_string, cmd_strings>: Replace char pointers
11531         with gdb::unique_xmalloc_ptr.
11532
11533 2019-01-10  Pedro Alves  <palves@redhat.com>
11534
11535         * solib-target.c (library_list_start_library): Don't xstrdup name.
11536
11537 2019-01-10  Pedro Alves  <palves@redhat.com>
11538
11539         * mdebugread.c (parse_partial_symbols): Use
11540         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11541
11542 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11543
11544         * linux-fork.c (scoped_switch_fork_info)
11545         <~scoped_switch_fork_info>: Fix incorrect variable name.
11546
11547 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11548
11549         * linux-fork.c (scoped_switch_fork_info)
11550         <scoped_switch_fork_info>: Make explicit.
11551         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11552
11553 2019-01-10  Tom Tromey  <tom@tromey.com>
11554
11555         * objfiles.h (objfile::reset_psymtabs): Update.
11556         * objfiles.c (objfile::objfile): Update.
11557         * psymtab.h (psymtab_storage::obstack): Update.
11558         (psymtab_storage::m_obstack): Use gdb::optional.
11559         (class psymtab_storage): Update comment.  Remove objfile
11560         parameter.
11561         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11562
11563 2019-01-10  Tom Tromey  <tom@tromey.com>
11564
11565         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11566         <free_psymtabs>: Now private.
11567         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11568         (allocate_psymtab): Use new method.
11569
11570 2019-01-10  Tom Tromey  <tom@tromey.com>
11571
11572         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11573         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11574         * mdebugread.c (parse_partial_symbols): Use
11575         allocate_dependencies.
11576         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11577         allocate_dependencies.
11578         (process_psymtab_comp_unit_reader)
11579         (build_type_psymtab_dependencies): Likewise.
11580         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11581
11582 2019-01-10  Tom Tromey  <tom@tromey.com>
11583
11584         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11585         PSYMBOL_SET_LANGUAGE.
11586         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11587
11588 2019-01-10  Tom Tromey  <tom@tromey.com>
11589
11590         * psymtab.h (psymtab_storage::obstack): New method.
11591         <m_obstack>: Rename from obstack; now private.
11592         * psymtab.c (psymtab_storage): Update.
11593         * dwarf2read.c (create_addrmap_from_index)
11594         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11595         Update.
11596
11597 2019-01-10  Tom Tromey  <tom@tromey.com>
11598
11599         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11600         * objfiles.h (objfile::reset_psymtabs): New method.
11601
11602 2019-01-10  Tom Tromey  <tom@tromey.com>
11603
11604         * symmisc.c (print_symbol_bcache_statistics): Update.
11605         (print_objfile_statistics): Update.
11606         * symfile.c (reread_symbols): Update.
11607         * psymtab.h (class psymtab_storage): New.
11608         * psymtab.c (psymtab_storage): New constructor.
11609         (~psymtab_storage): New destructor.
11610         (require_partial_symbols): Update.
11611         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11612         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11613         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11614         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11615         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11616         (start_psymtab_common, end_psymtab_common)
11617         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11618         (allocate_psymtab): Update.
11619         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11620         Update.
11621         (dump_psymtab_addrmap, maintenance_print_psymbols)
11622         (maintenance_check_psymtabs): Update.
11623         (class objfile_psymtabs): Move to objfiles.h.
11624         * psympriv.h (discard_psymtab): Now inline.
11625         (psymtab_discarder::psymtab_discarder): Update.
11626         (psymtab_discarder::~psymtab_discarder): Update.
11627         (ALL_OBJFILE_PSYMTABS): Rewrite.
11628         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11629         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11630         Remove fields.
11631         <partial_symtabs>: New field.
11632         (class objfile_psymtabs): Move from psymtab.h.  Update.
11633         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11634         psymbol_cache.
11635         (objfile::~objfile): Don't destroy psymbol_cache.
11636         * mdebugread.c (parse_partial_symbols): Update.
11637         * dwarf2read.c (create_addrmap_from_index)
11638         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11639         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11640         (add_partial_subprogram, dwarf2_ranges_read): Update.
11641         * dwarf-index-write.c (write_address_map)
11642         (write_one_signatured_type, recursively_write_psymbols)
11643         (class debug_names, class debug_names, write_psymtabs_to_index):
11644         Update.
11645
11646 2019-01-10  Tom Tromey  <tom@tromey.com>
11647
11648         * symtab.h (SYMBOL_SET_NAMES): Update.
11649         (symbol_set_names): Update.
11650         (MSYMBOL_SET_NAMES): Update.
11651         * symtab.c (symbol_set_names): Change argument to be an
11652         objfile_per_bfd_storage.
11653         * psymtab.c (add_psymbol_to_bcache): Update.
11654         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11655
11656 2019-01-10  Tom Tromey  <tom@tromey.com>
11657
11658         * symtab.c (create_demangled_names_hash): Change argument to be an
11659         objfile_per_bfd_storage.
11660         (symbol_set_names): Update.
11661
11662 2019-01-10  Tom Tromey  <tom@tromey.com>
11663
11664         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11665         init_psymbol_list.
11666         * psymtab.c (init_psymbol_list): Do nothing if already called.
11667         * psympriv.h (init_psymbol_list): Add comment.
11668         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11669         init_psymbol_list.
11670         * dbxread.c (dbx_symfile_read): Unconditionally call
11671         init_psymbol_list.
11672
11673 2019-01-10  Tom Tromey  <tom@tromey.com>
11674
11675         * xcoffread.c (scan_xcoff_symtab): Update.
11676         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11677         "where".
11678         * mdebugread.c (parse_partial_symbols)
11679         (handle_psymbol_enumerators): Update.
11680         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11681         * dbxread.c (read_dbx_symtab): Update.
11682         * psympriv.h (psymbol_placement): New enum.
11683         (add_psymbol_to_list): Update.
11684
11685 2019-01-10  Tom Tromey  <tom@tromey.com>
11686
11687         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11688         static_psymbols parameters.
11689         (scan_xcoff_symtab): Update.
11690         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11691         static_psymbols parameters.
11692         * psympriv.h (start_psymtab_common): Update.
11693         * mdebugread.c (parse_partial_symbols): Update.
11694         * dwarf2read.c (create_partial_symtab): Update.
11695         * dbxread.c (read_dbx_symtab): Update.
11696         (start_psymtab): Remove global_psymbols and static_psymbols
11697         parameters.
11698
11699 2019-01-10  Tom Tromey  <tom@tromey.com>
11700
11701         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11702         * psymtab.c (allocate_psymtab): Add comment.
11703         * psympriv.h (allocate_psymtab): Add comment.
11704         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11705         initializations.
11706         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11707
11708 2019-01-10  Tom Tromey  <tom@tromey.com>
11709
11710         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11711         Don't declare.
11712         * mipsread.c: Include mdebugread.h.
11713         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11714         Declare.
11715         * elfread.c: Include mdebugread.h.
11716
11717 2019-01-09  Tom Tromey  <tom@tromey.com>
11718
11719         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11720         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11721         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11722         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11723         (psym_lookup_symbol, psym_find_last_source_symtab)
11724         (psym_forget_cached_source_info, psym_print_stats)
11725         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11726         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11727         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11728         (psym_find_compunit_symtab_by_address)
11729         (maintenance_print_psymbols, maintenance_info_psymtabs)
11730         (maintenance_check_psymtabs): Use ranged for.
11731         * psymtab.h (class objfile_psymtabs): New.
11732         (require_partial_symbols): Return objfile_psymtabs.
11733         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11734
11735 2019-01-09  Tom Tromey  <tom@tromey.com>
11736
11737         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11738         (find_pc_mapped_section, list_overlays_command)
11739         (map_overlay_command, unmap_overlay_command)
11740         (simple_overlay_update): Use all_objfiles.
11741         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11742         * printcmd.c (info_symbol_command): Use all_objfiles.
11743         * objfiles.h (ALL_OBJSECTIONS): Remove.
11744         * maint.c (maintenance_translate_address): Use all_objfiles.
11745         * gcore.c (gcore_create_callback): Use all_objfiles.
11746         (objfile_find_memory_regions): Likewise.
11747
11748 2019-01-09  Tom Tromey  <tom@tromey.com>
11749
11750         * symtab.c (find_line_symtab, info_sources_command)
11751         (make_source_files_completion_list): Use objfile_compunits.
11752         * source.c (select_source_symtab): Use objfile_compunits.
11753         * objfiles.h (struct objfile): Update comment.
11754         (ALL_OBJFILES): Remove.
11755         (ALL_FILETABS): Remove.
11756         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11757         objfile_compunits.
11758
11759 2019-01-09  Tom Tromey  <tom@tromey.com>
11760
11761         * symmisc.c (print_objfile_statistics, dump_objfile)
11762         (maintenance_print_symbols): Use compunit_filetabs.
11763         * source.c (forget_cached_source_info_for_objfile): Use
11764         compunit_filetabs.
11765         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11766         (ALL_FILETABS): Use compunit_filetabs.
11767         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11768         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11769
11770 2019-01-09  Tom Tromey  <tom@tromey.com>
11771
11772         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11773         (compunit_filetabs): New.
11774         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11775         compunit_filetabs.
11776         (info_sources_command, make_source_files_completion_list): Remove
11777         declaration.
11778         * symmisc.c (print_objfile_statistics, dump_objfile)
11779         (maintenance_print_symbols): Remove declaration.
11780         (maintenance_info_symtabs): Use compunit_filetabs.
11781         (maintenance_info_line_tables): Likewise.
11782         * source.c (select_source_symtab): Change local variable name.
11783         (forget_cached_source_info_for_objfile): Remove declaration.
11784         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11785         * objfiles.c (objfile_relocate1): Remove declaration.
11786         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11787         declaration.
11788         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11789         * coffread.c (coff_symtab_read): Remove declaration.
11790         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11791         compunit_filetabs.
11792
11793 2019-01-09  Tom Tromey  <tom@tromey.com>
11794
11795         * symtab.c (lookup_objfile_from_block)
11796         (find_pc_sect_compunit_symtab, search_symbols)
11797         (default_collect_symbol_completion_matches_break_on): Use
11798         objfile_compunits.
11799         * objfiles.h (ALL_COMPUNITS): Remove.
11800         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11801         * cp-support.c (add_symbol_overload_list_qualified): Use
11802         objfile_compunits.
11803         * ada-lang.c (ada_collect_symbol_completion_matches)
11804         (ada_add_global_exceptions): Use objfile_compunits.
11805
11806 2019-01-09  Tom Tromey  <tom@tromey.com>
11807
11808         * source.c (select_source_symtab)
11809         (forget_cached_source_info_for_objfile): Remove declaration.
11810         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11811         declaration.
11812         * maint.c (count_symtabs_and_blocks): Remove declaration.
11813         * cp-support.c (add_symbol_overload_list_qualified): Remove
11814         declaration.
11815         * coffread.c (coff_symtab_read): Remove declaration.
11816         * symtab.c (lookup_symbol_in_objfile_symtabs)
11817         (basic_lookup_transparent_type_1): Use objfile_compunits.
11818         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11819         (info_sources_command, search_symbols)
11820         (default_collect_symbol_completion_matches_break_on)
11821         (make_source_files_completion_list): Remove declaration.
11822         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11823         (ada_collect_symbol_completion_matches)
11824         (ada_add_global_exceptions): Remove declaration.
11825         * linespec.c (iterate_over_all_matching_symtabs): Use
11826         objfile_compunits.
11827         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11828         (class objfile_compunits): New.
11829         (ALL_COMPUNITS): Use objfile_compunits.
11830         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11831         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11832         objfile_compunits.
11833         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11834
11835 2019-01-09  Tom Tromey  <tom@tromey.com>
11836
11837         * symtab.c (search_symbols)
11838         (default_collect_symbol_completion_matches_break_on): Use
11839         objfile_msymbols.
11840         * ada-lang.c (ada_lookup_simple_minsym)
11841         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11842         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11843         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11844         objfile_msymbols.
11845         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11846         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11847         * objc-lang.c (find_methods): Use objfile_msymbols.
11848         (info_selectors_command, info_classes_command): Likewise.
11849         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11850         * objfiles.h (class objfile_msymbols): New.
11851         (ALL_OBJFILE_MSYMBOLS): Remove.
11852         (ALL_MSYMBOLS): Remove.
11853
11854 2019-01-09  Tom Tromey  <tom@tromey.com>
11855
11856         * common/next-iterator.h (next_adapter): Add Iterator template
11857         parameter.
11858         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11859         (class all_objfiles_safe): New.
11860         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11861         * objfiles.c (put_objfile_before): Update comment.
11862         (add_separate_debug_objfile): Likewise.
11863         (free_all_objfiles): Use all_objfiles_safe.
11864         (objfile_purge_solibs): Likewise.
11865
11866 2019-01-09  Tom Tromey  <tom@tromey.com>
11867
11868         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11869         (expand_symtab_containing_pc, lookup_static_symbol)
11870         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11871         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11872         all_objfiles.
11873         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11874         * breakpoint.c (create_overlay_event_breakpoint)
11875         (create_longjmp_master_breakpoint)
11876         (create_std_terminate_master_breakpoint)
11877         (create_exception_master_breakpoint): Use all_objfiles.
11878         * linux-thread-db.c (try_thread_db_load_from_pdir)
11879         (has_libpthread): Use all_objfiles.
11880         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11881         * linespec.c (iterate_over_all_matching_symtabs)
11882         (search_minsyms_for_name): Use all_objfiles.
11883         * maint.c (maintenance_info_sections): Use all_objfiles.
11884         * main.c (captured_main_1): Use all_objfiles.
11885         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11886         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11887         * guile/scm-pretty-print.c
11888         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11889         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11890         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11891         (maintenance_print_msymbols): Use all_objfiles.
11892         * source.c (select_source_symtab): Use all_objfiles.
11893         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11894         * symfile.c (remove_symbol_file_command)
11895         (expand_symtabs_matching, map_symbol_filenames): Use
11896         all_objfiles.
11897         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11898         all_objfiles.
11899         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11900         * objc-lang.c (find_methods): Use all_objfiles.
11901         * objfiles.c (have_partial_symbols, have_full_symbols)
11902         (have_minimal_symbols, qsort_cmp)
11903         (default_iterate_over_objfiles_in_search_order): Use
11904         all_objfiles.
11905         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11906         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11907         (maintenance_check_psymtabs): Use all_objfiles.
11908         (ALL_PSYMTABS): Remove.
11909         * compile/compile-object-run.c (do_module_cleanup): Use
11910         all_objfiles.
11911         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11912         * cp-support.c (add_symbol_overload_list_qualified): Use
11913         all_objfiles.
11914         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11915         Use all_objfiles.
11916         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11917         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11918         all_objfiles.
11919         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11920         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11921         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11922         Uses all_objfiles.
11923         * solib.c (solib_read_symbols): Use all_objfiles
11924
11925 2019-01-09  Tom Tromey  <tom@tromey.com>
11926
11927         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11928         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11929         all_objfiles.
11930         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11931         * symmisc.c (print_symbol_bcache_statistics)
11932         (print_objfile_statistics, maintenance_print_objfiles)
11933         (maintenance_info_symtabs, maintenance_check_symtabs)
11934         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11935         all_objfiles.
11936         * source.c (forget_cached_source_info): Use all_objfiles.
11937         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11938         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11939         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11940         * objfiles.c (update_section_map): Use all_objfiles.
11941         (shared_objfile_contains_address_p): Likewise.
11942         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11943         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11944
11945 2019-01-09  Tom Tromey  <tom@tromey.com>
11946
11947         * common/next-iterator.h: New file.
11948         * objfiles.h (class all_objfiles): New.
11949         (struct objfile_iterator): New.
11950
11951 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11952
11953         * NEWS: Move the description of the changed "frame", "select-frame",
11954          and "info frame" commands to the Changed commands section.
11955
11956 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11957
11958         * gdbtypes.c (check_stub_method_group): Remove handling of old
11959         mangling schemes.
11960         * linespec.c (find_methods): Likewise.
11961         * stabsread.c (read_member_functions): Likewise.
11962         * valops.c (search_struct_method): Likewise.
11963         (value_struct_elt_for_reference): Likewise.
11964         * NEWS: Mention this change.
11965
11966 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11967
11968         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11969         print_source_lines.
11970         * source.c (print_source_lines_base): Update line number check.
11971         (print_source_lines): New function.
11972         (source_lines_range::source_lines_range): New function.
11973         * source.h (class source_lines_range): New class.
11974         (print_source_lines): New declaration.
11975
11976 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11977
11978         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11979
11980 2019-01-08  Tom Tromey  <tom@tromey.com>
11981             Simon Marchi  <simon.marchi@ericsson.com>
11982
11983         PR gdb/24060
11984         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11985         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11986         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11987         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11988         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11989         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11990
11991 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11992
11993         * source.c (select_source_symtab): Move header comment to
11994         declaration in source.h.
11995         (forget_cached_source_info_for_objfile): Likewise.
11996         (forget_cached_source_info): Likewise.
11997         (identify_source_line): Likewise.
11998         * source.h (identify_source_line): Move declaration from symtab.h
11999         and add comment from source.c
12000         (print_source_lines): Likewise.
12001         (forget_cached_source_info_for_objfile): Likewise.
12002         (forget_cached_source_info): Likewise.
12003         (select_source_symtab): Likewise.
12004         (enum print_source_lines_flag): Move definition from symtab.h.
12005         * symtab.h (identify_source_line): Move declaration to source.h.
12006         (print_source_lines): Likewise.
12007         (forget_cached_source_info_for_objfile): Likewise.
12008         (forget_cached_source_info): Likewise.
12009         (select_source_symtab): Likewise.
12010         (enum print_source_lines_flag): Move definition to source.h.
12011         * tui/tui-hooks.c: Add 'source.h' include.
12012
12013 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12014
12015         * source.c (print_source_lines_base): Handle requests to print
12016         reverse line number sequences, and guard against empty lines
12017         string.
12018
12019 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12020
12021         * source.c (print_source_lines_base): Fix skip of '\r' if next
12022         character is '\n'.
12023
12024 2019-01-06  Tom Tromey  <tom@tromey.com>
12025
12026         * c-exp.y (struct c_parse_state) <macro_original_text,
12027         expansion_obstack>: New member.
12028         (macro_original_text, expansion_obstack): Remove globals.
12029         (scan_macro_expansion, scanning_macro_expansion)
12030         (finished_macro_expansion): Update.
12031         (scan_macro_cleanup): Remove.
12032         (yylex, c_parse): Update.
12033
12034 2019-01-06  Tom Tromey  <tom@tromey.com>
12035
12036         * c-exp.y (struct c_parse_state) <strings>: New member.
12037         (operator_stoken): Update.
12038
12039 2019-01-06  Tom Tromey  <tom@tromey.com>
12040
12041         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12042         (union type_stack_elt) <typelist_val>: Now a pointer to
12043         std::vector.
12044         (type_stack_cleanup): Don't declare.
12045         (push_typelist): Update.
12046         * parse.c (pop_typelist): Return a std::vector.
12047         (push_typelist): Take a std::vector.
12048         (follow_types): Update.  Do not free args.
12049         (type_stack_cleanup): Remove.
12050         * c-exp.y (struct c_parse_state): New.
12051         (cpstate): New global.
12052         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12053         (nonempty_typelist): Update.
12054         (func_mod): Create a new vector.
12055         (c_parse): Create a c_parse_state.
12056         (check_parameter_typelist): Do not delete params.
12057         (function_method): Update.  Do not delete type_list.
12058
12059 2019-01-06  Tom Tromey  <tom@tromey.com>
12060
12061         PR gdb/28155:
12062         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12063         check_typedef.
12064         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12065         (print_return_value): Likewise.
12066
12067 2019-01-05  Tom Tromey  <tom@tromey.com>
12068
12069         * contrib/cleanup_check.py: Remove.
12070         * contrib/gcc-with-excheck: Remove.
12071         * contrib/exsummary.py: Remove.
12072         * contrib/excheck.py: Remove.
12073
12074 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12075
12076         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12077         NULL. Initialize tpprev to NULL instead of assigning it
12078         to NULL on the next statement.
12079         * windows-nat.c (windows_delete_thread): Remove check for
12080         main_thread_id before printing thread exit notifications.
12081         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12082         Remove thread ID check against main_thread_id.
12083         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12084         windows_delete_thread.
12085         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12086
12087 2019-01-04  Tom Tromey  <tom@tromey.com>
12088
12089         * compile/compile.c (_initialize_compile): Use upper case for
12090         metasyntactic variables.
12091         * symmisc.c (_initialize_symmisc): Use upper case for
12092         metasyntactic variables.
12093         * psymtab.c (_initialize_psymtab): Use upper case for
12094         metasyntactic variables.
12095         * demangle.c (demangle_command): Use upper case for metasyntactic
12096         variables.
12097         (_initialize_demangler): Likewise.
12098         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12099         variables.
12100
12101 2019-01-03  Tom Tromey  <tom@tromey.com>
12102
12103         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12104
12105 2019-01-03  Tom Tromey  <tom@tromey.com>
12106
12107         * python/py-symtab.c (salpy_str): Update.
12108         (struct salpy_sal_object) <symtab>: Now a PyObject.
12109         (salpy_dealloc): Update.
12110         (del_objfile_sal): Use gdbpy_ref.
12111
12112 2019-01-03  Tom Tromey  <tom@tromey.com>
12113
12114         * python/py-type.c (convert_field): Use new_reference.  Return
12115         gdbpy_ref.
12116         (make_fielditem): Return gdbpy_ref.
12117         (typy_fields): Update.
12118         (typy_getitem): Update.
12119         (field_name): Return gdbpy_ref.  Use new_reference.
12120         (typy_iterator_iternext): Update.
12121
12122 2019-01-03  Tom Tromey  <tom@tromey.com>
12123
12124         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12125
12126 2019-01-03  Tom Tromey  <tom@tromey.com>
12127
12128         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12129         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12130         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12131         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12132         (pspy_set_type_printers): Likewise.
12133         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12134         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12135         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12136         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12137         (objfpy_set_type_printers): Likewise.
12138
12139 2019-01-03  Tom Tromey  <tom@tromey.com>
12140
12141         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12142         (gdbpy_print_stack): Use gdbpy_err_fetch.
12143         * python/python-internal.h (class gdbpy_err_fetch): New class.
12144         (class gdbpy_enter) <m_error_type, m_error_value,
12145         m_error_traceback>: Remove.
12146         <m_error>: New member.
12147         (gdbpy_exception_to_string): Don't declare.
12148         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12149         * python/py-value.c (convert_value_from_python): Use
12150         gdbpy_err_fetch.
12151         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12152         gdbpy_exception_to_string.
12153         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12154         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12155         gdbpy_err_fetch.
12156
12157 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12158
12159         * linux-nat.c (delete_lwp_cleanup): Delete.
12160         (struct lwp_deleter): New struct.
12161         (lwp_info_up): New typedef.
12162         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12163         lwp_info_up.
12164
12165 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12166
12167         * linux-fork.c (class scoped_switch_fork_info): New class.
12168         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12169
12170 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12171
12172         * valops.c (find_overload_match): Remove use of null_cleanup, and
12173         calls to do_cleanups.
12174
12175 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12176
12177         * compile/compile-cplus-types.c
12178         (compile_cplus_instance::decl_name): Handle changes to
12179         cp_func_name.
12180         * cp-support.c (cp_func_name): Update header comment, update
12181         return type.
12182         * cp-support.h (cp_func_name): Update return type in declaration.
12183         * valops.c (find_overload_match): Move temp_func local to top
12184         level of function and change its type.  Use temp_func to hold and
12185         delete temporary string obtained from cp_func_name.
12186
12187 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12188
12189         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12190         gdb::char_vector, remove cleanup, and update uses of `msg`.
12191
12192 2019-01-03  Jim Wilson  <jimw@sifive.com>
12193
12194         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12195
12196 2019-01-02  Tom Tromey  <tom@tromey.com>
12197
12198         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12199         (tdesc_parse_xml): Remove cleanups.
12200         * target-descriptions.h (make_cleanup_free_target_description):
12201         Don't declare.
12202         (target_desc_deleter): New struct.
12203         (target_desc_up): New typedef.
12204         * target-descriptions.c (target_desc_deleter::operator()): Rename
12205         from free_target_description.
12206         (make_cleanup_free_target_description): Remove.
12207
12208 2019-01-02  Tom Tromey  <tom@tromey.com>
12209
12210         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12211         constructor, destructor.
12212         (linespec_parser): Remove typedef.
12213         (~linespec_parser): Rename from linespec_parser_delete.
12214         (linespec_lex_to_end, linespec_complete_label)
12215         (linespec_complete): Update.
12216         (decode_line_full): Remove cleanups.
12217         (decode_line_1): Update.
12218
12219 2019-01-02  Tom Tromey  <tom@tromey.com>
12220
12221         * python/python-internal.h (inferior_to_inferior_object): Change
12222         return type.
12223         * python/py-exitedevent.c (create_exited_event_object): Update.
12224         * python/py-inferior.c (inferior_to_inferior_object): Return
12225         gdbpy_ref.
12226         (python_new_inferior, python_inferior_deleted)
12227         (thread_to_thread_object, delete_thread_object)
12228         (build_inferior_list, gdbpy_selected_inferior): Update.
12229         * python/py-infthread.c (create_thread_object): Update.  Also fail
12230         if inferior_to_inferior_object fails.
12231
12232 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12233
12234         * inferior.h (class inferior) <displaced_step_state>: New field.
12235         * infrun.h (struct displaced_step_state): Move here from
12236         infrun.c.  Initialize fields, add constructor.
12237         <inf>: Remove field.
12238         <reset>: New method.
12239         * infrun.c (struct displaced_step_inferior_state): Move to
12240         infrun.h.
12241         (displaced_step_inferior_states): Remove.
12242         (get_displaced_stepping_state): Adust.
12243         (displaced_step_in_progress_any_inferior): Adjust.
12244         (displaced_step_in_progress_thread): Adjust.
12245         (displaced_step_in_progress): Adjust.
12246         (add_displaced_stepping_state): Remove.
12247         (get_displaced_step_closure_by_addr): Adjust.
12248         (remove_displaced_stepping_state): Remove.
12249         (infrun_inferior_exit): Call displaced_step_state.reset.
12250         (use_displaced_stepping): Don't check for NULL.
12251         (displaced_step_prepare_throw): Call
12252         get_displaced_stepping_state.
12253         (displaced_step_fixup): Don't check for NULL.
12254         (prepare_for_detach): Don't check for NULL.
12255
12256 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12257
12258         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12259          in case of call that did not complete.
12260
12261 2019-01-02  Andrey Utkin  <autkin@undo.io>
12262
12263         * symfile.c (find_separate_debug_file): Fix search of debug files for
12264         remote debuggee.
12265
12266 2019-01-02  Tom Tromey  <tom@tromey.com>
12267
12268         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12269         indentation.
12270         * python/py-frame.c (frapy_older): Remove cast.
12271         (frapy_newer): Likewise.
12272         * python/py-breakpoint.c (local_setattro): Remove cast.
12273         * python/py-arch.c (archpy_name): Remove local variable.
12274         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12275
12276 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12277
12278         * unittests/basic_string_view/element_access/char/empty.cc:
12279         Fix year range in copyright header.
12280
12281 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12282
12283         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12284         Delete.
12285         <operator==>: Update with for removed field.
12286         <hash>: Likewise.
12287         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12288         <isa_features>: ...this.
12289         <abi_features>: New field.
12290         (riscv_isa_flen): Update comment.
12291         (riscv_abi_xlen): New declaration.
12292         (riscv_abi_flen): New declaration.
12293         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12294         isa_features.
12295         (riscv_abi_xlen): New function.
12296         (riscv_isa_flen): Update to get answer from isa_features.
12297         (riscv_abi_flen): New function.
12298         (riscv_has_fp_abi): Update to get answer from abi_features.
12299         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12300         xlen and flen.
12301         (riscv_call_info) <xlen, flen>: Update comment.
12302         (riscv_call_arg_struct): Remove invalid assertions
12303         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12304         is removed.
12305         (riscv_gdbarch_init): Gather isa features and abi features
12306         separately, ensure both match on the gdbarch when reusing an old
12307         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12308         a target with 64-bit float hardware.
12309
12310 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12311
12312         * source.c (search_command_helper): Stop reverse search
12313         when line 1 has been searched.
12314
12315 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12316
12317         * record-full.c (record_full_base_target::close): Rewrite
12318         record_full_core_buf_list free logic.
12319
12320 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12321
12322         * break-catch-syscall.c (print_one_catch_syscall): xfree
12323         the last text.
12324
12325 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12326
12327         * top.c (print_gdb_version): Update Copyright year in version
12328         message.
12329
12330 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12331
12332         Update copyright year range in all GDB files.
12333
12334 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12335
12336         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12337
12338 For older changes see ChangeLog-2018.
12339 \f
12340 Local Variables:
12341 mode: change-log
12342 left-margin: 8
12343 fill-column: 74
12344 version-control: never
12345 coding: utf-8
12346 End:
12347