gdb/ChangeLog

   1 2020-04-08  Tom Tromey  <tromey@adacore.com>
   2
   3         * windows-nat.c (windows_nat::handle_load_dll)
   4         (windows_nat::handle_unload_dll): Rename.  No longer static.
   5         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
   6         Declare.
   7
   8 2020-04-08  Tom Tromey  <tromey@adacore.com>
   9
  10         * complaints.h (stop_whining): Declare at top-level.
  11         (complaint): Don't declare stop_whining.
  12
  13 2020-04-08  Tom Tromey  <tromey@adacore.com>
  14
  15         * windows-nat.c (windows_nat::handle_output_debug_string):
  16         Rename.  No longer static.
  17         * nat/windows-nat.h (handle_output_debug_string): Declare.
  18
  19 2020-04-08  Tom Tromey  <tromey@adacore.com>
  20
  21         * windows-nat.c (current_process_handle, current_process_id)
  22         (main_thread_id, last_sig, current_event, last_wait_event)
  23         (current_windows_thread, desired_stop_thread_id, pending_stops)
  24         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
  25         (display_selectors, fake_create_process)
  26         (get_windows_debug_event): Update.
  27         * nat/windows-nat.h (current_process_handle, current_process_id)
  28         (main_thread_id, last_sig, current_event, last_wait_event)
  29         (current_windows_thread, desired_stop_thread_id, pending_stops)
  30         (struct pending_stop, siginfo_er): Move from windows-nat.c.
  31         * nat/windows-nat.c (current_process_handle, current_process_id)
  32         (main_thread_id, last_sig, current_event, last_wait_event)
  33         (current_windows_thread, desired_stop_thread_id, pending_stops)
  34         (siginfo_er): New globals.  Move from windows-nat.c.
  35
  36 2020-04-08  Tom Tromey  <tromey@adacore.com>
  37
  38         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
  39         (handle_load_dll): Update.
  40         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
  41
  42 2020-04-08  Tom Tromey  <tromey@adacore.com>
  43
  44         * windows-nat.c (enum thread_disposition_type): Move to
  45         nat/windows-nat.h.
  46         (windows_nat::thread_rec): Rename from thread_rec.  No longer
  47         static.
  48         (windows_add_thread, windows_nat_target::fetch_registers)
  49         (windows_nat_target::store_registers, handle_exception)
  50         (windows_nat_target::resume, get_windows_debug_event)
  51         (windows_nat_target::get_tib_address)
  52         (windows_nat_target::thread_name)
  53         (windows_nat_target::thread_alive): Update.
  54         * nat/windows-nat.h (enum thread_disposition_type): Move from
  55         windows-nat.c.
  56         (thread_rec): Declare.
  57
  58 2020-04-08  Tom Tromey  <tromey@adacore.com>
  59
  60         * windows-nat.c: Add "using namespace".
  61         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
  62         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
  63
  64 2020-04-08  Tom Tromey  <tromey@adacore.com>
  65
  66         * nat/windows-nat.h (struct windows_thread_info): Declare
  67         destructor.
  68         * nat/windows-nat.c (~windows_thread_info): New.
  69
  70 2020-04-08  Tom Tromey  <tromey@adacore.com>
  71
  72         PR gdb/22992
  73         * windows-nat.c (current_event): Update comment.
  74         (last_wait_event, desired_stop_thread_id): New globals.
  75         (struct pending_stop): New.
  76         (pending_stops): New global.
  77         (windows_nat_target) <stopped_by_sw_breakpoint>
  78         <supports_stopped_by_sw_breakpoint>: New methods.
  79         (windows_fetch_one_register): Add assertions.  Adjust PC.
  80         (windows_continue): Handle pending stops.  Suspend other threads
  81         when stepping.  Use last_wait_event
  82         (wait_for_debug_event): New function.
  83         (get_windows_debug_event): Use wait_for_debug_event.  Handle
  84         pending stops.  Queue spurious stops.
  85         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
  86         (windows_nat_target::kill): Use wait_for_debug_event.
  87         * nat/windows-nat.h (struct windows_thread_info)
  88         <stopped_at_software_breakpoint>: New field.
  89         * nat/windows-nat.c (windows_thread_info::resume): Clear
  90         stopped_at_software_breakpoint.
  91
  92 2020-04-08  Tom Tromey  <tromey@adacore.com>
  93
  94         * windows-nat.c (enum thread_disposition_type): New.
  95         (thread_rec): Replace "get_context" parameter with "disposition";
  96         change type.
  97         (windows_add_thread, windows_nat_target::fetch_registers)
  98         (windows_nat_target::store_registers, handle_exception)
  99         (windows_nat_target::resume, get_windows_debug_event)
 100         (windows_nat_target::get_tib_address)
 101         (windows_nat_target::thread_name)
 102         (windows_nat_target::thread_alive): Update.
 103
 104 2020-04-08  Tom Tromey  <tromey@adacore.com>
 105
 106         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
 107         (windows_continue): Use windows_continue::resume.
 108         * nat/windows-nat.h (struct windows_thread_info) <suspend,
 109         resume>: Declare new methods.
 110         * nat/windows-nat.c: New file.
 111         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
 112
 113 2020-04-08  Tom Tromey  <tromey@adacore.com>
 114
 115         * windows-nat.c (windows_add_thread, windows_delete_thread)
 116         (windows_nat_target::fetch_registers)
 117         (windows_nat_target::store_registers, fake_create_process)
 118         (windows_nat_target::resume, windows_nat_target::resume)
 119         (get_windows_debug_event, windows_nat_target::wait)
 120         (windows_nat_target::pid_to_str)
 121         (windows_nat_target::get_tib_address)
 122         (windows_nat_target::get_ada_task_ptid)
 123         (windows_nat_target::thread_name)
 124         (windows_nat_target::thread_alive): Use lwp, not tid.
 125
 126 2020-04-08  Tom Tromey  <tromey@adacore.com>
 127
 128         * windows-nat.c (handle_exception)
 129         (windows_nat_target::thread_name): Update.
 130         * nat/windows-nat.h (windows_thread_info): Remove destructor.
 131         <name>: Now unique_xmalloc_ptr.
 132
 133 2020-04-08  Tom Tromey  <tromey@adacore.com>
 134
 135         * windows-nat.c (thread_rec)
 136         (windows_nat_target::fetch_registers): Update.
 137         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
 138         Update comment.
 139         <debug_registers_changed, reload_context>: Now bool.
 140
 141 2020-04-08  Tom Tromey  <tromey@adacore.com>
 142
 143         * windows-nat.c (windows_add_thread): Use new.
 144         (windows_init_thread_list, windows_delete_thread): Use delete.
 145         (get_windows_debug_event): Update.
 146         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
 147         destructor, and initializers.
 148
 149 2020-04-08  Tom Tromey  <tromey@adacore.com>
 150
 151         * windows-nat.c (struct windows_thread_info): Remove.
 152         * nat/windows-nat.h: New file.
 153
 154 2020-04-08  Tom Tromey  <tromey@adacore.com>
 155
 156         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
 157         (thread_rec, windows_add_thread, windows_delete_thread)
 158         (windows_continue): Update.
 159
 160 2020-04-08  Tom Tromey  <tromey@adacore.com>
 161
 162         * windows-nat.c (struct windows_thread_info): Remove typedef.
 163         (thread_head): Remove.
 164         (thread_list): New global.
 165         (thread_rec, windows_add_thread, windows_init_thread_list)
 166         (windows_delete_thread, windows_continue): Update.
 167
 168 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
 169
 170         * windows-tdep.h (windows_init_abi): Add comment.
 171         (cygwin_init_abi): New declaration.
 172         * windows-tdep.c: Split signal enumeration in two, one for
 173         Windows and one for Cygwin.
 174         (windows_gdb_signal_to_target): Only deal with signal of the
 175         Windows OS ABI.
 176         (cygwin_gdb_signal_to_target): New function.
 177         (windows_init_abi): Rename to windows_init_abi_common, don't set
 178         gdb_signal_to_target gdbarch method.  Add new new function with
 179         this name.
 180         (cygwin_init_abi): New function.
 181         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
 182         comment.  Don't call windows_init_abi.
 183         (amd64_windows_init_abi): Add comment, call windows_init_abi.
 184         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
 185         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
 186         i386_windows_init_abi_common, don't call windows_init_abi.  Add
 187         a new function of this name.
 188         (i386_cygwin_init_abi): New function.
 189         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
 190         OS ABI Cygwin.
 191
 192 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
 193
 194         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
 195         parameter.c.
 196         (dwarf2_read_gdb_index): Update.
 197
 198 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
 199
 200         * nbsd-tdep.c: Include "objfiles.h".
 201         (nbsd_skip_solib_resolver): New.
 202         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
 203
 204 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
 205
 206         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
 207         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
 208         with DW_LLE_base_addressx are being emitted in DWARFv5.
 209         Add the newly added kind DW_LOC_OFFSET_PAIR also.
 210         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
 211         unsigned integer.
 212
 213 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
 214
 215         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
 216         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
 217         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
 218         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
 219         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
 220         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
 221         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
 222
 223
 224 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
 225
 226         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
 227         (read_loclist_index): New function definition.
 228         (lookup_loclist_base): New function definition.
 229         (read_loclist_header): New function definition.
 230         (dwarf2_cu): Add loclist_base and loclist_header field.
 231         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
 232         (read_full_die_1): Read the value of DW_AT_loclists_base.
 233         (read_attribute_reprocess): Handle DW_FORM_loclistx.
 234         (read_attribute_value): Handle DW_FORM_loclistx.
 235         (skip_one_die): Handle DW_FORM_loclistx.
 236         (loclist_header): New structure declaration.
 237         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
 238
 239 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
 240
 241         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
 242         constructor.  Remove `addr` parameter from other constructor and
 243         add `per_cu` parameter.
 244         * dwarf2/read.c (create_partial_symtab): Update.
 245
 246 2020-04-07  Tom de Vries  <tdevries@suse.de>
 247
 248         PR symtab/25796
 249         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
 250         (partial_die_info::fixup): Inherit has_const_value.
 251
 252 2020-04-07  Tom de Vries  <tdevries@suse.de>
 253
 254         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
 255         symbols without address.
 256
 257 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
 258
 259         * nbsd-nat.h (struct thread_info): Add forward declaration.
 260         (nbsd_nat_target::thread_alive): Add.
 261         (nbsd_nat_target::thread_name): Likewise.
 262         (nbsd_nat_target::update_thread_list): Likewise.
 263         (update_thread_list::post_attach): Likewise.
 264         (post_attach::pid_to_str): Likewise.
 265         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
 266         (nbsd_thread_lister): Add.
 267         (nbsd_nat_target::thread_alive): Likewise.
 268         (nbsd_nat_target::thread_name): Likewise.
 269         (nbsd_add_threads): Likewise.
 270         (update_thread_list::post_attach): Likewise.
 271         (nbsd_nat_target::update_thread_list): Likewise.
 272         (post_attach::pid_to_str): Likewise.
 273
 274 2020-04-06  Tom Tromey  <tromey@adacore.com>
 275
 276         * ada-valprint.c (print_variant_part): Extract the variant field.
 277         (print_field_values): Use the field as the outer value when
 278         recursing.
 279
 280 2020-04-06  Tom Tromey  <tromey@adacore.com>
 281
 282         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
 283         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
 284         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
 285         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
 286         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
 287
 288 2020-04-06  Tom Tromey  <tromey@adacore.com>
 289
 290         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
 291         TYPE_CODE_ERROR.
 292
 293 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
 294
 295         * nbsd-tdep.c: Include "gdbarch.h".
 296         Define enum with NetBSD signal numbers.
 297         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
 298         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
 299         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
 300         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
 301         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
 302         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
 303         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
 304         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
 305         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
 306         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
 307         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
 308         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
 309
 310 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
 311
 312         PR gdb/25325
 313         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
 314
 315 2020-04-03  Tom Tromey  <tromey@adacore.com>
 316
 317         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
 318         Read constant block.
 319
 320 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
 321
 322         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
 323         (gdb_bfd_get_full_section_contents): New declaration.
 324         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
 325         * windows-tdep.c (is_linked_with_cygwin_dll): Use
 326         gdb_bfd_get_full_section_contents.
 327
 328 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
 329
 330         * exec.c (build_section_table): Replace internal_error with
 331         gdb_assert.
 332         (section_table_xfer_memory_partial): Likewise.
 333         * mdebugread.c (parse_partial_symbols): Likewise.
 334         * psymtab.c (lookup_partial_symbol): Likewise.
 335         * utils.c (wrap_here): Likewise.
 336
 337 2020-04-02  Tom Tromey  <tromey@adacore.com>
 338
 339         * f-lang.c (build_fortran_types): Use arch_type to initialize
 340         builtin_complex_s32 in the TYPE_CODE_ERROR case.
 341
 342 2020-04-02  Tom Tromey  <tromey@adacore.com>
 343
 344         * dwarf2/read.c (partial_die_info::read): Do not create a vector
 345         of attributes.
 346
 347 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 348             Bernd Edlinger <bernd.edlinger@hotmail.de>
 349             Tom Tromey  <tromey@adacore.com>
 350
 351         * buildsym.c (buildsym_compunit::record_line): Remove
 352         deduplication code.
 353
 354 2020-04-02  Tom de Vries  <tdevries@suse.de>
 355
 356         PR ada/24671
 357         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
 358
 359 2020-04-02  Tom de Vries  <tdevries@suse.de>
 360
 361         * dwarf2/read.c (dwarf2_gdb_index_functions,
 362         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
 363         NULL.
 364         * psymtab.c (psym_lookup_global_symbol_language): New function.
 365         (psym_functions): Init psym_lookup_global_symbol_language with
 366         psym_lookup_global_symbol_language.
 367         * symfile-debug.c (debug_sym_quick_functions): Init
 368         lookup_global_symbol_language with NULL.
 369         * symfile.c (set_initial_language): Remove fixme comment.
 370         * symfile.h (struct quick_symbol_functions): Add
 371         lookup_global_symbol_language.
 372         * symtab.c (find_quick_global_symbol_language): New function.
 373         (find_main_name): Use find_quick_global_symbol_language.
 374
 375 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
 376
 377         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
 378
 379 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 380
 381         * buildsym.c (record_line): Fix undefined behavior and preserve
 382         lines at eof.
 383
 384 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 385
 386         * buildsym.c (record_line): Fix the resizing condition.
 387
 388 2020-04-01  Tom Tromey  <tom@tromey.com>
 389
 390         * value.h (value_literal_complex): Add comment.
 391         * valops.c (value_literal_complex): Refer to value.h.
 392
 393 2020-04-01  Tom Tromey  <tom@tromey.com>
 394
 395         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
 396         (scalar_type): New rule, from typebase.
 397         (typebase): Use scalar_type.  Recognize complex types.
 398         (field_name): Handle FLOAT_KEYWORD.
 399         (ident_tokens): Add _Complex and __complex__.
 400
 401 2020-04-01  Tom Tromey  <tom@tromey.com>
 402
 403         PR exp/25299:
 404         * valarith.c (promotion_type, complex_binop): New functions.
 405         (scalar_binop): Handle complex numbers.  Use promotion_type.
 406         (value_pos, value_neg, value_complement): Handle complex numbers.
 407
 408 2020-04-01  Tom Tromey  <tom@tromey.com>
 409
 410         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
 411         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
 412         (parse_number): Handle complex numbers.
 413
 414 2020-04-01  Tom Tromey  <tom@tromey.com>
 415
 416         * c-valprint.c (c_decorations): Change complex suffix to "i".
 417
 418 2020-04-01  Tom Tromey  <tom@tromey.com>
 419
 420         * valprint.c (generic_value_print_complex): Use accessors.
 421         * value.h (value_real_part, value_imaginary_part): Declare.
 422         * valops.c (value_real_part, value_imaginary_part): New
 423         functions.
 424         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
 425
 426 2020-04-01  Tom Tromey  <tom@tromey.com>
 427
 428         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
 429         (read_range_type): Update.
 430         * mdebugread.c (basic_type): Update.
 431         * go-lang.c (build_go_types): Use init_complex_type.
 432         * gdbtypes.h (struct main_type) <complex_type>: New member.
 433         (init_complex_type): Update.
 434         (arch_complex_type): Don't declare.
 435         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
 436         Make name if none given.  Use alloc_type_copy.  Look for cached
 437         complex type.
 438         (arch_complex_type): Remove.
 439         (gdbtypes_post_init): Use init_complex_type.
 440         * f-lang.c (build_fortran_types): Use init_complex_type.
 441         * dwarf2/read.c (read_base_type): Update.
 442         * d-lang.c (build_d_types): Use init_complex_type.
 443         * ctfread.c (read_base_type): Update.
 444
 445 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 446
 447         * infrun.c (stop_all_threads): Update assertion, plus when
 448         stopping threads, take into account that we might be trying
 449         to stop an all-stop target.
 450         (stop_waiting): Call 'stop_all_threads' if there exists a
 451         non-stop target.
 452
 453 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 454
 455         * target.h (exists_non_stop_target): New function declaration.
 456         * target.c (exists_non_stop_target): New function.
 457
 458 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
 459
 460         PR gdb/24789
 461         * eval.c (is_integral_or_integral_reference): New function.
 462         (evaluate_subexp_standard): Allow integer references in
 463         pointer arithmetic.
 464
 465 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 466
 467         * remote.c (remote_target::remote_parse_stop_reply): Remove the
 468         check for no ptid in the stop reply when the target is non-stop.
 469
 470 2020-04-01  Tom Tromey  <tromey@adacore.com>
 471
 472         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
 473         "name" parameter to rvalue reference.  Initialize m_name_holder.
 474         <lookup_name_info>: New overloads.
 475         <name>: Return gdb::string_view.
 476         <c_str>: New method.
 477         <make_ignore_params>: Update.
 478         <search_name_hash>: Update.
 479         <language_lookup_name>: Return const char *.
 480         <m_name>: Change type.
 481         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
 482         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
 483         (lookup_name_info::match_any): Update.
 484         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
 485         Update.
 486         * minsyms.c (linkage_name_str): Update.
 487         * language.c (default_symbol_name_matcher): Update.
 488         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
 489         Update.
 490         * ada-lang.c (ada_fold_name): Change parameter to string_view.
 491         (ada_lookup_name_info::ada_lookup_name_info): Update.
 492         (literal_symbol_name_matcher): Update.
 493
 494 2020-04-01  Tom Tromey  <tromey@adacore.com>
 495
 496         * psymtab.c (psymtab_search_name): Remove function.
 497         (psym_lookup_symbol): Create search name and lookup name here.
 498         (lookup_partial_symbol): Remove "name" parameter; add
 499         lookup_name.
 500         (psym_expand_symtabs_for_function): Update.
 501
 502 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
 503
 504         PR tui/25597:
 505         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
 506
 507 2020-03-31  Tom Tromey  <tromey@adacore.com>
 508
 509         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
 510         memcpy.
 511
 512 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
 513
 514         * features/riscv/32bit-csr.xml: Regenerated.
 515         * features/riscv/64bit-csr.xml: Regenerated.
 516
 517 2020-03-30  Tom Tromey  <tromey@adacore.com>
 518
 519         * ada-valprint.c (print_variant_part): Update.
 520         * ada-lang.h (ada_which_variant_applies): Update.
 521         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
 522         outer_valaddr parameters; replace with "outer" value parameter.
 523         (to_fixed_variant_branch_type): Update.
 524
 525 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 526
 527         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
 528         <list>.  Remove inclusion of observable.h.
 529         (PPC_DEBUG_CURRENT_VERSION): Move up define.
 530         (struct arch_lwp_info): New struct.
 531         (class ppc_linux_dreg_interface): New class.
 532         (struct ppc_linux_process_info): New struct.
 533         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
 534         <low_new_clone, low_forget_process, low_prepare_to_resume>
 535         <copy_thread_dreg_state, mark_thread_stale>
 536         <mark_debug_registers_changed, register_hw_breakpoint>
 537         <clear_hw_breakpoint, register_wp, clear_wp>
 538         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
 539         <num_memory_accesses, get_trigger_type>
 540         <create_watchpoint_request, hwdebug_point_cmp>
 541         <init_arch_lwp_info, get_arch_lwp_info>
 542         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
 543         methods.
 544         <struct ptid_hash>: New inner struct.
 545         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
 546         members.
 547         (saved_dabr_value, hwdebug_info, max_slots_number)
 548         (struct hw_break_tuple, struct thread_points, ppc_threads)
 549         (have_ptrace_hwdebug_interface)
 550         (hwdebug_find_thread_points_by_tid)
 551         (hwdebug_insert_point, hwdebug_remove_point): Remove.
 552         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
 553         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
 554         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
 555         use m_dreg_interface.
 556         (hwdebug_point_cmp): Change to...
 557         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
 558         reference arguments instead of pointers.
 559         (ppc_linux_nat_target::ranged_break_num_registers): Use
 560         m_dreg_interface.
 561         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
 562         m_dreg_interface.  Call register_hw_breakpoint.
 563         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
 564         m_dreg_interface.  Call clear_hw_breakpoint.
 565         (get_trigger_type): Change to...
 566         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
 567         comment.
 568         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
 569         use m_dreg_interface.  Call register_hw_breakpoint.
 570         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
 571         use m_dreg_interface.  Call clear_hw_breakpoint.
 572         (can_use_watchpoint_cond_accel): Change to...
 573         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
 574         method.  Update comment, use m_dreg_interface and
 575         m_process_info.
 576         (calculate_dvc): Change to...
 577         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
 578         m_dreg_interface.
 579         (num_memory_accesses): Change to...
 580         (ppc_linux_nat_target::num_memory_accesses): ...this method.
 581         (check_condition): Change to...
 582         (ppc_linux_nat_target::check_condition): ...this method.
 583         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
 584         comment, use m_dreg_interface.
 585         (create_watchpoint_request): Change to...
 586         (ppc_linux_nat_target::create_watchpoint_request): ...this
 587         method.  Use m_dreg_interface.
 588         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
 589         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
 590         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
 591         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
 592         (ppc_linux_nat_target::low_forget_process)
 593         (ppc_linux_nat_target::low_new_fork)
 594         (ppc_linux_nat_target::low_new_clone)
 595         (ppc_linux_nat_target::low_delete_thread)
 596         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
 597         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
 598         only call mark_thread_stale.
 599         (ppc_linux_thread_exit): Remove.
 600         (ppc_linux_nat_target::stopped_data_address): Change to...
 601         (ppc_linux_nat_target::low_stopped_data_address): This. Add
 602         comment, use m_dreg_interface and m_thread_hw_breakpoints.
 603         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
 604         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
 605         comment.  Call low_stopped_data_address.
 606         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
 607         m_dreg_interface.
 608         (ppc_linux_nat_target::masked_watch_num_registers): Use
 609         m_dreg_interface.
 610         (ppc_linux_nat_target::copy_thread_dreg_state)
 611         (ppc_linux_nat_target::mark_thread_stale)
 612         (ppc_linux_nat_target::mark_debug_registers_changed)
 613         (ppc_linux_nat_target::register_hw_breakpoint)
 614         (ppc_linux_nat_target::clear_hw_breakpoint)
 615         (ppc_linux_nat_target::register_wp)
 616         (ppc_linux_nat_target::clear_wp)
 617         (ppc_linux_nat_target::init_arch_lwp_info)
 618         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
 619         (_initialize_ppc_linux_nat): Remove observer callback.
 620
 621 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 622
 623         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
 624         (ppc_linux_nat_target::auxv_parse)
 625         (ppc_linux_nat_target::read_description)
 626         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
 627         Move up.
 628
 629 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 630
 631         * linux-nat.h (low_new_clone): New method.
 632         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
 633
 634 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
 635
 636         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
 637         (dbx_expand_psymtab): ... this.
 638         (start_psymtab): Update.
 639         * mdebugread.c (psymtab_to_symtab_1): Rename to...
 640         (mdebug_expand_psymtab): ... this.
 641         (parse_partial_symbols): Update.
 642         (new_psymtab): Update.
 643         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
 644         (xcoff_expand_psymtab): ... this.
 645         (xcoff_start_psymtab): Update.
 646
 647 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
 648
 649         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
 650         <expand_dependencies>: ... this.
 651         * psymtab.c (partial_symtab::read_dependencies): Rename to...
 652         (partial_symtab::expand_dependencies): ... this.
 653         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
 654         Update.
 655         (dwarf2_psymtab::expand_psymtab): Update.
 656         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
 657         * mdebugread.c (psymtab_to_symtab_1): Update.
 658         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
 659
 660 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
 661
 662         * psympriv.h (discard_psymtab): Remove.
 663         * dbxread.c (dbx_end_psymtab): Update.
 664         * xcoffread.c (xcoff_end_psymtab): Update.
 665
 666 2020-03-28  Tom Tromey  <tom@tromey.com>
 667
 668         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
 669         comment.
 670
 671 2020-03-28  Tom Tromey  <tom@tromey.com>
 672
 673         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
 674
 675 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
 676
 677         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
 678
 679 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
 680
 681         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
 682
 683 2020-03-26  Tom Tromey  <tom@tromey.com>
 684
 685         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
 686         (mark_common_block_symbol_computed, read_tag_string_type)
 687         (attr_to_dynamic_prop, read_subrange_type): Update.
 688         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
 689         to be methods on struct attribute.
 690         (skip_one_die, process_imported_unit_die, read_namespace_alias)
 691         (read_call_site_scope, partial_die_info::read)
 692         (partial_die_info::read, lookup_die_type, follow_die_ref):
 693         Update.
 694         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
 695         from dwarf2_get_ref_die_offset.
 696         (attribute::constant_value): New method, from
 697         dwarf2_get_attr_constant_value.
 698         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
 699         Declare method.
 700         <constant_value>: New method.
 701
 702 2020-03-26  Tom Tromey  <tom@tromey.com>
 703
 704         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
 705         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
 706         (dwarf_type_encoding_name): Move to stringify.c.
 707         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
 708         * dwarf2/stringify.c: New file.
 709         * dwarf2/stringify.h: New file.
 710
 711 2020-03-26  Tom Tromey  <tom@tromey.com>
 712
 713         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
 714         Rewrite.
 715
 716 2020-03-26  Tom Tromey  <tom@tromey.com>
 717
 718         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
 719         methods.
 720         * dwarf2/read.c (lookup_addr_base): Move to die.h.
 721         (lookup_ranges_base): Likewise.
 722         (read_cutu_die_from_dwo, read_full_die_1): Update.
 723
 724 2020-03-26  Tom Tromey  <tom@tromey.com>
 725
 726         * dwarf2/read.c (read_import_statement, read_file_scope)
 727         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
 728         (read_lexical_block_scope, read_call_site_scope)
 729         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
 730         (handle_struct_member_die, process_structure_scope)
 731         (update_enumeration_type_from_children)
 732         (process_enumeration_scope, read_array_type, read_common_block)
 733         (read_namespace, read_module, read_subroutine_type): Update.
 734         (sibling_die): Remove.
 735
 736 2020-03-26  Tom Tromey  <tom@tromey.com>
 737
 738         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
 739         (build_type_psymtabs_reader, read_structure_type)
 740         (read_enumeration_type, read_full_die_1): Update.
 741         (dwarf2_attr_no_follow): Move to die.h.
 742         * dwarf2/die.h (struct die_info) <attr>: New method.
 743
 744 2020-03-26  Tom Tromey  <tom@tromey.com>
 745
 746         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
 747         <base_address>: Now an optional.
 748         (dwarf2_find_base_address, dwarf2_rnglists_process)
 749         (dwarf2_ranges_process, fill_in_loclist_baton)
 750         (dwarf2_symbol_mark_computed): Update.
 751
 752 2020-03-26  Tom Tromey  <tom@tromey.com>
 753
 754         * dwarf2/read.c (struct die_info): Move to die.h.
 755         * dwarf2/die.h: New file.
 756
 757 2020-03-26  Tom Tromey  <tom@tromey.com>
 758
 759         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
 760         * dwarf2/read.c
 761         (dwarf2_statement_list_fits_in_line_number_section_complaint):
 762         Move to line-header.c.
 763         (read_checked_initial_length_and_offset, read_formatted_entries):
 764         Likewise.
 765         (dwarf_decode_line_header): Split into two.
 766         * dwarf2/line-header.c
 767         (dwarf2_statement_list_fits_in_line_number_section_complaint):
 768         Move from read.c.
 769         (read_checked_initial_length_and_offset, read_formatted_entries):
 770         Likewise.
 771         (dwarf_decode_line_header): New function, split from read.c.
 772
 773 2020-03-26  Tom Tromey  <tom@tromey.com>
 774
 775         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
 776         Declare method.
 777         * dwarf2/read.c (read_attribute_value): Update.
 778         (dwarf2_per_objfile::read_line_string): Rename from
 779         read_indirect_line_string.
 780         (read_formatted_entries): Update.
 781
 782 2020-03-26  Tom Tromey  <tom@tromey.com>
 783
 784         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
 785         variable.
 786
 787 2020-03-26  Tom Tromey  <tom@tromey.com>
 788
 789         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
 790         const.
 791         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
 792         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
 793         parameter const.
 794
 795 2020-03-26  Tom Tromey  <tom@tromey.com>
 796
 797         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
 798         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
 799         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
 800         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
 801
 802 2020-03-26  Tom Tromey  <tom@tromey.com>
 803
 804         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
 805         file_names_size, file_full_name, file_file_name>: Use const.
 806         <file_name_at, file_names>: Add const overload.
 807         * dwarf2/line-header.c (line_header::file_file_name)
 808         (line_header::file_full_name): Update.
 809
 810 2020-03-26  Tom Tromey  <tom@tromey.com>
 811
 812         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
 813         (macro_start_file, consume_improper_spaces)
 814         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
 815         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
 816         (dwarf_decode_macros): Move to macro.c.
 817         * dwarf2/macro.c: New file.
 818         * dwarf2/macro.h: New file.
 819         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
 820
 821 2020-03-26  Tom Tromey  <tom@tromey.com>
 822
 823         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
 824         method.
 825         * dwarf2/section.c: New method.  From
 826         read_indirect_string_at_offset_from.
 827         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
 828         (read_indirect_string_at_offset_from): Move to section.c.
 829         (read_indirect_string_at_offset): Rewrite.
 830         (read_indirect_line_string_at_offset): Remove.
 831         (read_indirect_string, read_indirect_line_string)
 832         (dwarf_decode_macro_bytes): Update.
 833
 834 2020-03-26  Tom Tromey  <tom@tromey.com>
 835
 836         * dwarf2/section.h (struct dwarf2_section_info)
 837         <overload_complaint>: Declare.
 838         (dwarf2_section_buffer_overflow_complaint): Don't declare.
 839         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
 840         Rename from dwarf2_section_buffer_overflow_complaint.
 841         * dwarf2/read.c (skip_one_die, partial_die_info::read)
 842         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
 843
 844 2020-03-26  Tom Tromey  <tom@tromey.com>
 845
 846         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
 847         Declare.
 848         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
 849         Move from read.c.
 850         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
 851         to section.c.
 852
 853 2020-03-26  Tom Tromey  <tom@tromey.com>
 854
 855         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
 856
 857 2020-03-26  Tom Tromey  <tom@tromey.com>
 858
 859         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
 860         "builder".
 861         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
 862         parameter.
 863         (dwarf_decode_macros): Update.
 864
 865 2020-03-26  Tom Tromey  <tom@tromey.com>
 866
 867         * dwarf2/read.c (read_attribute_value): Update.
 868         (read_indirect_string_from_dwz): Move to dwz.c; change into
 869         method.
 870         (dwarf_decode_macro_bytes): Update.
 871         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
 872         * dwarf2/dwz.c: New file.
 873         * Makefile.in (COMMON_SFILES): Add dwz.c.
 874
 875 2020-03-26  Tom Tromey  <tom@tromey.com>
 876
 877         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
 878         * dwarf2/read.c: Add include.
 879         * dwarf2/index-write.c: Add include.
 880         * dwarf2/index-cache.c: Add include.
 881         * dwarf2/dwz.h: New file.
 882
 883 2020-03-25  Tom Tromey  <tom@tromey.com>
 884
 885         * compile/compile-object-load.c (get_out_value_type): Mention
 886         correct symbol name in error message.
 887
 888 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
 889
 890         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
 891
 892 2020-03-25  Tom de Vries  <tdevries@suse.de>
 893
 894         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
 895         * symmisc.c (dump_symtab_1): Print user and includes fields.
 896         (maintenance_info_symtabs): Same.
 897
 898 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 899
 900         PR gdb/25534
 901         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
 902         (riscv_regcache_cooked_write): New function.
 903         (riscv_push_dummy_call): Use new function.
 904         (riscv_return_value): Likewise.
 905
 906 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
 907
 908         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
 909         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
 910         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
 911         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
 912         * infrun.c (follow_fork): Likewise.
 913         (follow_fork_inferior): Likewise.
 914         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
 915         * linux-nat.h (class linux_nat_target): Likewise.
 916         * remote.c (class remote_target) <follow_fork>: Likewise.
 917         (remote_target::follow_fork): Likewise.
 918         * target-delegates.c: Re-generate.
 919         * target.c (default_follow_fork): Likewise.
 920         (target_follow_fork): Likewise.
 921         * target.h (struct target_ops) <follow_fork>: Likewise.
 922         (target_follow_fork): Likewise.
 923
 924 2020-03-24  Tom de Vries  <tdevries@suse.de>
 925
 926         * psymtab.c (maintenance_info_psymtabs): Print user field.
 927
 928 2020-03-20  Tom Tromey  <tromey@adacore.com>
 929
 930         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
 931         const.
 932         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
 933         const.
 934
 935 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
 936
 937         * ptrace.m4: Don't check for ptrace declaration.
 938         * config.in: Re-generate.
 939         * configure: Re-generate.
 940         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
 941         not defined.
 942
 943 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
 944
 945         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
 946         `PTRACE_TYPE_RET'.
 947         * i386-bsd-nat.c (gdb_ptrace): Likewise.
 948         * sparc-nat.c (gdb_ptrace): Likewise.
 949         * x86-bsd-nat.c (gdb_ptrace): Likewise.
 950
 951 2020-03-20  Tom Tromey  <tromey@adacore.com>
 952
 953         * c-exp.y (lex_one_token): Fix assert.
 954
 955 2020-03-20  Tom Tromey  <tromey@adacore.com>
 956
 957         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
 958         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
 959         strncpy call.
 960
 961 2020-03-20  Tom Tromey  <tromey@adacore.com>
 962
 963         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
 964
 965 2020-03-20  Tom Tromey  <tromey@adacore.com>
 966
 967         * ada-valprint.c (print_variant_part): Remove parameters; switch
 968         to value-based API.
 969         (print_field_values): Likewise.
 970         (ada_val_print_struct_union): Likewise.
 971         (ada_value_print_1): Update.
 972
 973 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
 974
 975         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
 976         nbsd_nat_target instead of inf_ptrace_target.
 977         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
 978         nbsd_nat_target.
 979
 980 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
 981
 982         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
 983         it to the ptrace call.
 984         * (store_registers): Likewise.
 985
 986 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
 987
 988         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
 989         it to the ptrace call.
 990         * (store_registers): Likewise.
 991
 992 2020-03-19  Luis Machado  <luis.machado@linaro.org>
 993
 994         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
 995         valid, fetch vg value from ptrace.
 996
 997 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
 998         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
 999         * inf-ptrace.c: Likewise.
1000         * (gdb_ptrace): Add.
1001         * (inf_ptrace_target::resume): Update.
1002         * (inf_ptrace_target::xfer_partial): Likewise.
1003         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
1004         * (inf_ptrace_peek_poke): Update.
1005
1006 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
1007
1008         * x86-bsd-nat.c (gdb_ptrace): New.
1009         * (x86bsd_dr_set): Add new argument `ptid'.
1010         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
1011         x86bsd_dr_set_addr): Update.
1012
1013 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1014
1015         * remote.c (remote_target::process_stop_reply): Handle events for
1016         all threads differently.
1017
1018 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1019
1020         * completer.c (completion_tracker::remove_completion): Define new
1021         function.
1022         * completer.h (completion_tracker::remove_completion): Declare new
1023         function.
1024         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
1025         when adding a C++ function symbol.
1026
1027 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1028
1029         * completer.c (completion_tracker::completion_hash_entry): Define
1030         new class.
1031         (advance_to_filename_complete_word_point): Call
1032         recompute_lowest_common_denominator.
1033         (completion_tracker::completion_tracker): Call discard_completions
1034         to setup the hash table.
1035         (completion_tracker::discard_completions): Allow for being called
1036         from the constructor, pass new equal function, and element deleter
1037         when constructing the hash table.  Initialise new class member
1038         variables.
1039         (completion_tracker::maybe_add_completion): Remove use of
1040         m_entries_vec, and store more information into m_entries_hash.
1041         (completion_tracker::recompute_lcd_visitor): New function, most
1042         content taken from...
1043         (completion_tracker::recompute_lowest_common_denominator):
1044         ...here, this now just visits each item in the hash calling the
1045         above visitor.
1046         (completion_tracker::build_completion_result): Remove use of
1047         m_entries_vec, call recompute_lowest_common_denominator.
1048         * completer.h (completion_tracker::have_completions): Remove use
1049         of m_entries_vec.
1050         (completion_tracker::completion_hash_entry): Declare new class.
1051         (completion_tracker::recompute_lowest_common_denominator): Change
1052         function signature.
1053         (completion_tracker::recompute_lcd_visitor): Declare new function.
1054         (completion_tracker::m_entries_vec): Delete.
1055         (completion_tracker::m_entries_hash): Initialize to NULL.
1056         (completion_tracker::m_lowest_common_denominator_valid): New
1057         member variable.
1058         (completion_tracker::m_lowest_common_denominator_max_length): New
1059         member variable.
1060
1061 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1062
1063         * regformats/regdef.h: Put reg in gdb namespace.
1064
1065 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1066
1067         * i386-bsd-nat.c (gdb_ptrace): New.
1068         * (i386bsd_fetch_inferior_registers,
1069         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
1070         * (i386bsd_fetch_inferior_registers,
1071         i386bsd_store_inferior_registers) Use gdb_ptrace.
1072
1073 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1074
1075         * amd64-bsd-nat.c (gdb_ptrace): New.
1076         * (amd64bsd_fetch_inferior_registers,
1077         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
1078         * (amd64bsd_fetch_inferior_registers,
1079         amd64bsd_store_inferior_registers) Use gdb_ptrace.
1080
1081 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1082
1083         * user-regs.c (user_reg::read): Rename to...
1084         (user_reg::xread): ...this.
1085         * (append_user_reg): Rename argument `read' to `xread'.
1086         * (user_reg_add_builtin): Likewise.
1087         * (user_reg_add): Likewise.
1088         * (value_of_user_reg): Likewise.
1089
1090 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1091
1092         * sparc-nat.c (gdb_ptrace): New.
1093         * sparc-nat.c (sparc_fetch_inferior_registers)
1094         (sparc_store_inferior_registers) Remove obsolete comment.
1095         * sparc-nat.c (sparc_fetch_inferior_registers)
1096         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
1097         * sparc-nat.c (sparc_fetch_inferior_registers)
1098         (sparc_store_inferior_registers) Use gdb_ptrace.
1099
1100 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1101
1102         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
1103         it to the ptrace call.
1104         * sh-nbsd-nat.c (store_registers): Likewise.
1105
1106 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1107
1108         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
1109         nbsd_nat_target instead of inf_ptrace_target.
1110         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
1111         nbsd_nat_target.
1112
1113 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1114
1115         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
1116
1117 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1118
1119         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
1120         <sys/sysctl.h>.
1121         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
1122
1123 2020-03-17  Tom de Vries  <tdevries@suse.de>
1124
1125         PR gdb/23710
1126         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
1127         fields.
1128         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
1129         fields.
1130         (process_imported_unit_die): Skip import of c++ CUs.
1131
1132 2020-03-16  Tom Tromey  <tom@tromey.com>
1133
1134         * p-valprint.c (pascal_object_print_value): Initialize
1135         base_value.
1136
1137 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
1138             Shahab Vahedi  <shahab@synopsys.com>
1139
1140         * Makefile.in: Add arch/arc.o
1141         * configure.tgt: Likewise.
1142         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
1143         (_initialize_arc_tdep): Don't initialize old target descriptions.
1144         (arc_read_description): New function to cache target descriptions.
1145         * arc-tdep.h (arc_read_description): Add proto type.
1146         * arch/arc.c: New file.
1147         * arch/arc.h: Likewise.
1148         * features/Makefile: Replace old target descriptions with new.
1149         * features/arc-arcompact.c: Remove.
1150         * features/arc-arcompact.xml: Likewise.
1151         * features/arc-v2.c: Likewise
1152         * features/arc-v2.xml: Likewise
1153         * features/arc/aux-arcompact.xml: New file.
1154         * features/arc/aux-v2.xml: Likewise.
1155         * features/arc/core-arcompact.xml: Likewise.
1156         * features/arc/core-v2.xml: Likewise.
1157         * features/arc/aux-arcompact.c: Generate.
1158         * features/arc/aux-v2.c: Likewise.
1159         * features/arc/core-arcompact.c: Likewise.
1160         * features/arc/core-v2.c: Likewise.
1161         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
1162
1163 2020-03-16  Tom Tromey  <tromey@adacore.com>
1164
1165         PR gdb/25663:
1166         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
1167         putting value into bcache.
1168
1169 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1170
1171         PR gdb/21500
1172         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
1173         to...
1174         (amd64_windows_init_abi_common): ... this.  Don't set size of
1175         long type.
1176         (amd64_windows_init_abi): New function.
1177         (amd64_cygwin_init_abi): New function.
1178         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
1179         the Cygwin OS ABI.
1180         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
1181         comment.
1182
1183 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1184
1185         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
1186         * windows-tdep.c (CYGWIN_DLL_NAME): New.
1187         (pe_import_directory_entry): New struct type.
1188         (is_linked_with_cygwin_dll): New function.
1189         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
1190         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
1191         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
1192
1193 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1194
1195         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
1196         i386_cygwin_core_osabi_sniffer.
1197
1198 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1199
1200         * i386-cygwin-tdep.c: Rename to...
1201         * i386-windows-tdep.c: ... this.
1202         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
1203         i386-windows-tdep.c.
1204         * configure.tgt: Likewise.
1205
1206 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1207
1208         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
1209         * osabi.c (gdb_osabi_names): Add "Windows".
1210         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
1211         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
1212         (i386_cygwin_core_osabi_sniffer): New function, extracted from
1213         i386_cygwin_osabi_sniffer.
1214         (_initialize_i386_cygwin_tdep): Register OS ABI
1215         GDB_OSABI_WINDOWS for i386.
1216         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
1217         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
1218         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
1219         for x86-64.
1220         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
1221         when the target matches '*-*-mingw*'.
1222
1223 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1224
1225         * defs.h (enum gdb_osabi): Move to...
1226         * osabi.h (enum gdb_osabi): ... here.
1227         * gdbarch.sh: Include osabi.h in gdbarch.h.
1228         * gdbarch.h: Re-generate.
1229
1230 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1231
1232         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
1233         function.
1234         (_initialize_amd64_windows_tdep): Register osabi sniffer.
1235
1236 2020-03-14  Tom Tromey  <tom@tromey.com>
1237
1238         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
1239         for C++.
1240         (c_type_print_modifier): Likewise.  Add "language" parameter.
1241         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
1242         (c_type_print_base_1): Update.
1243         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
1244         constants.
1245         * type-stack.c (type_stack::insert): Handle tp_atomic and
1246         tp_restrict.
1247         (type_stack::follow_type_instance_flags): Likewise.
1248         (type_stack::follow_types): Likewise.  Merge type-following code.
1249         * c-exp.y (RESTRICT, ATOMIC): New tokens.
1250         (space_identifier, cv_with_space_id)
1251         (const_or_volatile_or_space_identifier_noopt)
1252         (const_or_volatile_or_space_identifier): Remove.
1253         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
1254         rules.
1255         (ptr_operator, typebase): Update.
1256         (enum token_flag) <FLAG_C>: New constant.
1257         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
1258         "_Atomic".
1259         (lex_one_token): Handle FLAG_C.
1260
1261 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1262
1263         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
1264         it to the ptrace call.
1265         * m68k-bsd-nat.c (store_registers): Likewise.
1266
1267 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1268
1269         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
1270         gdb_byte *.
1271         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
1272         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
1273         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
1274
1275 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1276
1277         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
1278         nbsd_nat_target instead of inf_ptrace_target.
1279         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
1280         nbsd_nat_target.
1281
1282 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1283
1284         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
1285         register_t.
1286
1287 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1288
1289         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
1290         it to the ptrace call.
1291         * alpha-bsd-nat.c (store_registers): Likewise.
1292
1293 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1294
1295         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
1296         includes.
1297         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
1298         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
1299         fill_fpregset): Likewise.
1300
1301 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1302
1303         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
1304         nbsd_nat_target instead of inf_ptrace_target.
1305         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
1306         nbsd_nat_target.
1307
1308 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1309
1310         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
1311         register_t.
1312
1313 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1314
1315         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
1316         it to the ptrace call.
1317         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
1318         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
1319         * arm-nbsd-nat.c (store_register): Likewise.
1320         * arm-nbsd-nat.c (store_regs): Likewise.
1321         * arm-nbsd-nat.c (store_fp_register): Likewise.
1322         * arm-nbsd-nat.c (store_fp_regs): Likewise.
1323
1324 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1325
1326         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
1327         nbsd_nat_target instead of inf_ptrace_target.
1328         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
1329         nbsd_nat_target.
1330
1331 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1332
1333         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
1334         it to the ptrace call.
1335         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
1336
1337 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1338
1339         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
1340         it to the ptrace call.
1341         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
1342
1343 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1344
1345         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
1346         gdb_byte *.
1347         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
1348
1349 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1350
1351         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
1352         instead of inf_ptrace_target.
1353         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
1354         nbsd_nat_target.
1355
1356 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1357
1358         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
1359         register_t.
1360
1361 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1362
1363         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
1364         register_t.
1365
1366 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1367
1368         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
1369         register_t.
1370
1371 2020-03-13  Tom Tromey  <tom@tromey.com>
1372
1373         * value.h (val_print): Don't declare.
1374         * valprint.h (val_print_array_elements)
1375         (val_print_scalar_formatted, generic_val_print): Don't declare.
1376         * valprint.c (generic_val_print_array): Take a struct value.
1377         (generic_val_print_ptr, generic_val_print_memberptr)
1378         (generic_val_print_bool, generic_val_print_int)
1379         (generic_val_print_char, generic_val_print_complex)
1380         (generic_val_print): Remove.
1381         (generic_value_print): Update.
1382         (do_val_print): Remove unused parameters.  Don't call
1383         la_val_print.
1384         (val_print): Remove.
1385         (common_val_print): Update.  Don't call value_check_printable.
1386         (val_print_scalar_formatted, val_print_array_elements): Remove.
1387         * rust-lang.c (rust_val_print): Remove.
1388         (rust_language_defn): Update.
1389         * p-valprint.c (pascal_val_print): Remove.
1390         (pascal_value_print_inner): Update.
1391         (pascal_object_print_val_fields, pascal_object_print_val):
1392         Remove.
1393         (pascal_object_print_static_field): Update.
1394         * p-lang.h (pascal_val_print): Don't declare.
1395         * p-lang.c (pascal_language_defn): Update.
1396         * opencl-lang.c (opencl_language_defn): Update.
1397         * objc-lang.c (objc_language_defn): Update.
1398         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
1399         * m2-lang.h (m2_val_print): Don't declare.
1400         * m2-lang.c (m2_language_defn): Update.
1401         * language.h (struct language_defn) <la_val_print>: Remove.
1402         * language.c (unk_lang_value_print_inner): Rename.  Change
1403         argument types.
1404         (unknown_language_defn, auto_language_defn): Update.
1405         * go-valprint.c (go_val_print): Remove.
1406         * go-lang.h (go_val_print): Don't declare.
1407         * go-lang.c (go_language_defn): Update.
1408         * f-valprint.c (f_val_print): Remove.
1409         * f-lang.h (f_value_print): Don't declare.
1410         * f-lang.c (f_language_defn): Update.
1411         * d-valprint.c (d_val_print): Remove.
1412         * d-lang.h (d_value_print): Don't declare.
1413         * d-lang.c (d_language_defn): Update.
1414         * cp-valprint.c (cp_print_value_fields)
1415         (cp_print_value_fields_rtti, cp_print_value): Remove.
1416         (cp_print_static_field): Update.
1417         * c-valprint.c (c_val_print_array, c_val_print_ptr)
1418         (c_val_print_struct, c_val_print_union, c_val_print_int)
1419         (c_val_print_memberptr, c_val_print): Remove.
1420         * c-lang.h (c_val_print_array, cp_print_value_fields)
1421         (cp_print_value_fields_rtti): Don't declare.
1422         * c-lang.c (c_language_defn, cplus_language_defn)
1423         (asm_language_defn, minimal_language_defn): Update.
1424         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
1425         (ada_val_print_enum): Take a struct value.
1426         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
1427         (ada_val_print): Remove.
1428         (ada_value_print_1): Update.
1429         (printable_val_type): Remove.
1430         * ada-lang.h (ada_val_print): Don't declare.
1431         * ada-lang.c (ada_language_defn): Update.
1432
1433 2020-03-13  Tom Tromey  <tom@tromey.com>
1434
1435         * valprint.c (do_val_print): Update.
1436         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
1437         a struct value.
1438         (value_to_value_object_no_release): Declare.
1439         * python/py-value.c (value_to_value_object_no_release): New
1440         function.
1441         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
1442         struct value.
1443         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
1444         function.
1445         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
1446         a struct value.
1447         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
1448         Declare.
1449         (gdbscm_apply_val_pretty_printer): Take a struct value.
1450         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
1451         value.
1452         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
1453         value.
1454         * extension-priv.h (struct extension_language_ops)
1455         <apply_val_pretty_printer>: Take a struct value.
1456         * cp-valprint.c (cp_print_value): Create a struct value.
1457         (cp_print_value): Update.
1458
1459 2020-03-13  Tom Tromey  <tom@tromey.com>
1460
1461         * ada-valprint.c (print_field_values): Call common_val_print.
1462
1463 2020-03-13  Tom Tromey  <tom@tromey.com>
1464
1465         * ada-valprint.c (val_print_packed_array_elements): Remove
1466         bitoffset and val parameters.  Call common_val_print.
1467         (ada_val_print_string): Remove offset, address, and original_value
1468         parameters.
1469         (ada_val_print_array): Update.
1470         (ada_value_print_array): New function.
1471         (ada_value_print_1): Call it.
1472
1473 2020-03-13  Tom Tromey  <tom@tromey.com>
1474
1475         * ada-valprint.c (ada_value_print): Use common_val_print.
1476
1477 2020-03-13  Tom Tromey  <tom@tromey.com>
1478
1479         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
1480
1481 2020-03-13  Tom Tromey  <tom@tromey.com>
1482
1483         * ada-valprint.c (ada_value_print_num): New function.
1484         (ada_value_print_1): Use it.
1485
1486 2020-03-13  Tom Tromey  <tom@tromey.com>
1487
1488         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
1489
1490 2020-03-13  Tom Tromey  <tom@tromey.com>
1491
1492         * ada-valprint.c (ada_value_print_ptr): New function.
1493         (ada_value_print_1): Use it.
1494
1495 2020-03-13  Tom Tromey  <tom@tromey.com>
1496
1497         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
1498         call common_val_print.
1499         (ada_val_print_1): Update.
1500         (ada_value_print_1): New function.
1501         (ada_value_print_inner): Rewrite.
1502
1503 2020-03-13  Tom Tromey  <tom@tromey.com>
1504
1505         * cp-valprint.c (cp_print_value_fields): Update.
1506         (cp_print_value): New function.
1507
1508 2020-03-13  Tom Tromey  <tom@tromey.com>
1509
1510         * m2-valprint.c (m2_value_print_inner): Use
1511         cp_print_value_fields.
1512         * cp-valprint.c (cp_print_value_fields): New function.
1513         * c-valprint.c (c_value_print_struct): New function.
1514         (c_value_print_inner): Use c_value_print_struct.
1515         * c-lang.h (cp_print_value_fields): Declare.
1516
1517 2020-03-13  Tom Tromey  <tom@tromey.com>
1518
1519         * c-valprint.c (c_value_print_array): New function.
1520         (c_value_print_inner): Use it.
1521
1522 2020-03-13  Tom Tromey  <tom@tromey.com>
1523
1524         * c-valprint.c (c_value_print_memberptr): New function.
1525         (c_value_print_inner): Use it.
1526
1527 2020-03-13  Tom Tromey  <tom@tromey.com>
1528
1529         * c-valprint.c (c_value_print_int): New function.
1530         (c_value_print_inner): Use it.
1531
1532 2020-03-13  Tom Tromey  <tom@tromey.com>
1533
1534         * c-valprint.c (c_value_print_ptr): New function.
1535         (c_value_print_inner): Use it.
1536
1537 2020-03-13  Tom Tromey  <tom@tromey.com>
1538
1539         * c-valprint.c (c_value_print_inner): Rewrite.
1540
1541 2020-03-13  Tom Tromey  <tom@tromey.com>
1542
1543         * valprint.c (generic_value_print_complex): New function.
1544         (generic_value_print): Use it.
1545
1546 2020-03-13  Tom Tromey  <tom@tromey.com>
1547
1548         * valprint.c (generic_val_print_float): Don't call
1549         val_print_scalar_formatted.
1550         (generic_val_print, generic_value_print): Update.
1551
1552 2020-03-13  Tom Tromey  <tom@tromey.com>
1553
1554         * valprint.c (generic_value_print_char): New function
1555         (generic_value_print): Use it.
1556
1557 2020-03-13  Tom Tromey  <tom@tromey.com>
1558
1559         * valprint.c (generic_value_print_int): New function.
1560         (generic_value_print): Use it.
1561
1562 2020-03-13  Tom Tromey  <tom@tromey.com>
1563
1564         * valprint.c (generic_value_print_bool): New function.
1565         (generic_value_print): Use it.
1566
1567 2020-03-13  Tom Tromey  <tom@tromey.com>
1568
1569         * valprint.c (generic_val_print_func): Simplify.
1570         (generic_val_print, generic_value_print): Update.
1571
1572 2020-03-13  Tom Tromey  <tom@tromey.com>
1573
1574         * valprint.c (generic_val_print_flags): Remove.
1575         (generic_val_print, generic_value_print): Update.
1576         (val_print_type_code_flags): Add original_value parameter.
1577
1578 2020-03-13  Tom Tromey  <tom@tromey.com>
1579
1580         * valprint.c (generic_val_print): Update.
1581         (generic_value_print): Update.
1582         * valprint.c (generic_val_print_enum): Don't call
1583         val_print_scalar_formatted.
1584
1585 2020-03-13  Tom Tromey  <tom@tromey.com>
1586
1587         * valprint.c (generic_value_print): Call generic_value_print_ptr.
1588         * valprint.c (generic_value_print_ptr): New function.
1589
1590 2020-03-13  Tom Tromey  <tom@tromey.com>
1591
1592         * valprint.c (generic_value_print): Rewrite.
1593
1594 2020-03-13  Tom Tromey  <tom@tromey.com>
1595
1596         * p-valprint.c (pascal_object_print_value_fields)
1597         (pascal_object_print_value): New functions.
1598
1599 2020-03-13  Tom Tromey  <tom@tromey.com>
1600
1601         * p-valprint.c (pascal_value_print_inner): Rewrite.
1602
1603 2020-03-13  Tom Tromey  <tom@tromey.com>
1604
1605         * f-valprint.c (f_value_print_innner): Rewrite.
1606
1607 2020-03-13  Tom Tromey  <tom@tromey.com>
1608
1609         * m2-valprint.c (m2_print_unbounded_array): New overload.
1610         (m2_print_unbounded_array): Update.
1611         (m2_print_array_contents): Take a struct value.
1612         (m2_value_print_inner): Rewrite.
1613
1614 2020-03-13  Tom Tromey  <tom@tromey.com>
1615
1616         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
1617         (d_value_print_inner): New function.
1618         * d-lang.h (d_value_print_inner): Declare.
1619         * d-lang.c (d_language_defn): Use d_value_print_inner.
1620
1621 2020-03-13  Tom Tromey  <tom@tromey.com>
1622
1623         * go-valprint.c (go_value_print_inner): New function.
1624         * go-lang.h (go_value_print_inner): Declare.
1625         * go-lang.c (go_language_defn): Use go_value_print_inner.
1626
1627 2020-03-13  Tom Tromey  <tom@tromey.com>
1628
1629         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
1630         API.
1631         (rust_val_print): Rewrite.
1632         (rust_value_print_inner): New function, from rust_val_print.
1633         (rust_language_defn): Use rust_value_print_inner.
1634
1635 2020-03-13  Tom Tromey  <tom@tromey.com>
1636
1637         * ada-valprint.c (ada_value_print_inner): New function.
1638         * ada-lang.h (ada_value_print_inner): Declare.
1639         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
1640
1641 2020-03-13  Tom Tromey  <tom@tromey.com>
1642
1643         * f-valprint.c (f_value_print_innner): New function.
1644         * f-lang.h (f_value_print_innner): Declare.
1645         * f-lang.c (f_language_defn): Use f_value_print_innner.
1646
1647 2020-03-13  Tom Tromey  <tom@tromey.com>
1648
1649         * p-valprint.c (pascal_value_print_inner): New function.
1650         * p-lang.h (pascal_value_print_inner): Declare.
1651         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
1652
1653 2020-03-13  Tom Tromey  <tom@tromey.com>
1654
1655         * m2-valprint.c (m2_value_print_inner): New function.
1656         * m2-lang.h (m2_value_print_inner): Declare.
1657         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
1658
1659 2020-03-13  Tom Tromey  <tom@tromey.com>
1660
1661         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
1662         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
1663         * c-valprint.c (c_value_print_inner): New function.
1664         * c-lang.h (c_value_print_inner): Declare.
1665         * c-lang.c (c_language_defn, cplus_language_defn)
1666         (asm_language_defn, minimal_language_defn): Use
1667         c_value_print_inner.
1668
1669 2020-03-13  Tom Tromey  <tom@tromey.com>
1670
1671         * p-valprint.c (pascal_object_print_value_fields): Now static.
1672         * p-lang.h (pascal_object_print_value_fields): Don't declare.
1673
1674 2020-03-13  Tom Tromey  <tom@tromey.com>
1675
1676         * c-valprint.c (c_val_print_array): Simplify.
1677
1678 2020-03-13  Tom Tromey  <tom@tromey.com>
1679
1680         * valprint.c (value_print_array_elements): New function.
1681         * valprint.h (value_print_array_elements): Declare.
1682
1683 2020-03-13  Tom Tromey  <tom@tromey.com>
1684
1685         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
1686         * mips-tdep.c (mips_print_register): Use
1687         value_print_scalar_formatted.
1688
1689 2020-03-13  Tom Tromey  <tom@tromey.com>
1690
1691         * valprint.h (value_print_scalar_formatted): Declare.
1692         * valprint.c (value_print_scalar_formatted): New function.
1693
1694 2020-03-13  Tom Tromey  <tom@tromey.com>
1695
1696         * valprint.h (generic_value_print): Declare.
1697         * valprint.c (generic_value_print): New function.
1698
1699 2020-03-13  Tom Tromey  <tom@tromey.com>
1700
1701         * valprint.c (do_val_print): Call la_value_print_inner, if
1702         available.
1703         * rust-lang.c (rust_language_defn): Update.
1704         * p-lang.c (pascal_language_defn): Update.
1705         * opencl-lang.c (opencl_language_defn): Update.
1706         * objc-lang.c (objc_language_defn): Update.
1707         * m2-lang.c (m2_language_defn): Update.
1708         * language.h (struct language_defn) <la_value_print_inner>: New
1709         member.
1710         * language.c (unknown_language_defn, auto_language_defn): Update.
1711         * go-lang.c (go_language_defn): Update.
1712         * f-lang.c (f_language_defn): Update.
1713         * d-lang.c (d_language_defn): Update.
1714         * c-lang.c (c_language_defn, cplus_language_defn)
1715         (asm_language_defn, minimal_language_defn): Update.
1716         * ada-lang.c (ada_language_defn): Update.
1717
1718 2020-03-13  Tom Tromey  <tom@tromey.com>
1719
1720         * c-valprint.c (c_value_print): Use common_val_print.
1721
1722 2020-03-13  Tom Tromey  <tom@tromey.com>
1723
1724         * cp-valprint.c (cp_print_static_field): Use common_val_print.
1725
1726 2020-03-13  Tom Tromey  <tom@tromey.com>
1727
1728         * f-valprint.c (f77_print_array_1, f_val_print): Use
1729         common_val_print.
1730
1731 2020-03-13  Tom Tromey  <tom@tromey.com>
1732
1733         * riscv-tdep.c (riscv_print_one_register_info): Use
1734         common_val_print.
1735
1736 2020-03-13  Tom Tromey  <tom@tromey.com>
1737
1738         * mi/mi-main.c (output_register): Use common_val_print.
1739
1740 2020-03-13  Tom Tromey  <tom@tromey.com>
1741
1742         * infcmd.c (default_print_one_register_info): Use
1743         common_val_print.
1744
1745 2020-03-13  Tom Tromey  <tom@tromey.com>
1746
1747         * valprint.h (common_val_print_checked): Declare.
1748         * valprint.c (common_val_print_checked): New function.
1749         * stack.c (print_frame_arg): Use common_val_print_checked.
1750
1751 2020-03-13  Tom Tromey  <tom@tromey.com>
1752
1753         * valprint.c (do_val_print): New function, from val_print.
1754         (val_print): Use do_val_print.
1755         (common_val_print): Use do_val_print.
1756
1757 2020-03-13  Tom Tromey  <tom@tromey.com>
1758
1759         * valprint.c (value_print): Use scoped_value_mark.
1760
1761 2020-03-13  Tom de Vries  <tdevries@suse.de>
1762
1763         PR symtab/25646
1764         * psymtab.c (partial_symtab::partial_symtab): Don't set
1765         globals_offset and statics_offset.  Push element onto
1766         current_global_psymbols and current_static_psymbols stacks.
1767         (concat): New function.
1768         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
1769         element from current_global_psymbols and current_static_psymbols
1770         stacks.  Concat popped elements to global_psymbols and
1771         static_symbols.
1772         (add_psymbol_to_list): Use current_global_psymbols and
1773         current_static_psymbols stacks.
1774         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
1775         current_static_psymbols fields.
1776
1777 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
1778
1779         * corelow.c (sniff_core_bfd): Remove.
1780         (class core_target) <m_core_vec>: Remove.
1781         (core_target::core_target): Update.
1782         (core_file_fns): Remove.
1783         (deprecated_add_core_fns): Remove.
1784         (default_core_sniffer): Remove.
1785         (sniff_core_bfd): Remove.
1786         (default_check_format): Remove.
1787         (gdb_check_format): Remove.
1788         (core_target_open): Update.
1789         (core_target::get_core_register_section): Update.
1790         (get_core_registers_cb): Update.
1791         (core_target::fetch_registers): Update.
1792         * gdbcore.h (struct core_fns): Remove.
1793         (deprecated_add_core_fns): Remove.
1794         (default_core_sniffer): Remove.
1795         (default_check_format): Remove.
1796
1797 2020-03-12  Tom Tromey  <tom@tromey.com>
1798
1799         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
1800         CORE_ADDR.
1801         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
1802
1803 2020-03-12  Tom Tromey  <tom@tromey.com>
1804
1805         * remote.c (remote_target::download_tracepoint)
1806         (remote_target::enable_tracepoint)
1807         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
1808         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
1809         sprintf_vma.
1810
1811 2020-03-12  Tom Tromey  <tom@tromey.com>
1812
1813         * symfile-mem.c: Update CORE_ADDR size assert.
1814
1815 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
1816
1817         * selftest.m4: Move to gdbsupport/.
1818         * acinclude.m4: Update path to selftest.m4.
1819
1820 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
1821
1822         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
1823         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
1824         gdbarch-selfselftests.c and selftest-arch.c.
1825         (SUBDIR_UNITTESTS_OBS): Rename to...
1826         (SELFTESTS_OBS): ... this.
1827         (COMMON_SFILES): Remove disasm-selftests.c and
1828         gdbarch-selftests.c.
1829         * configure.ac: Don't add selftest-arch.{c,o} to
1830         CONFIG_{SRCS,OBS}.
1831         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
1832         preprocessor conditions.
1833
1834 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
1835
1836         * configure.ac: Don't source bfd/development.sh.
1837         * selftest.m4: Modify comment.
1838         * configure: Re-generate.
1839
1840 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
1841
1842         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
1843         not "true" or "false".
1844         * configure: Re-generate.
1845
1846 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
1847
1848         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
1849         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
1850         renamed to arm_nbsd_supply_gregset.
1851         (fetch_register): Update to call arm_nbsd_supply_gregset.
1852         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
1853         (arm_netbsd_nat_target::fetch_registers): Update.
1854         (fetch_elfcore_registers): Removed.
1855         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
1856         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
1857         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
1858         not require NetBSD system headers.
1859         (arm_nbsd_regset): New struct.
1860         (arm_nbsd_iterate_over_regset_sections): New function.
1861         (arm_netbsd_init_abi_common): Updated to call
1862         set_gdbarch_iterate_over_regset_sections.
1863         * arm-nbsd-tdep.h: New file.
1864
1865 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
1866
1867         * symtab.c (find_pc_sect_line): Add check which prevents infinite
1868         recursion.
1869
1870 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
1871
1872         * configure: Re-generate.
1873
1874 2020-03-11  Tom Tromey  <tromey@adacore.com>
1875
1876         * ada-typeprint.c (print_choices): Fix comment.
1877
1878 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1879
1880         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
1881         previous item in the list, when the list has no items.
1882
1883 2020-03-11  Tom de Vries  <tdevries@suse.de>
1884
1885         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
1886         PROP_LOCLIST handling code.
1887
1888 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1889
1890         * buildsym-legacy.c (record_line): Pass extra parameter to
1891         record_line.
1892         * buildsym.c (buildsym_compunit::record_line): Take an extra
1893         parameter, reduce duplication in the line table, and record the
1894         is_stmt flag in the line table.
1895         * buildsym.h (buildsym_compunit::record_line): Add extra
1896         parameter.
1897         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
1898         non-statement lines.
1899         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
1900         this to the symtab builder.
1901         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
1902         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
1903         through to dwarf_record_line_1.
1904         * infrun.c (process_event_stop_test): When stepping, don't stop at
1905         a non-statement instruction, and only refresh the step info when
1906         we land in the middle of a line's range.  Also add an extra
1907         comment.
1908         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
1909         field.
1910         * record-btrace.c (btrace_find_line_range): Only record lines
1911         marked as is-statement.
1912         * stack.c (frame_show_address): Show the frame address if we are
1913         in a non-statement sal.
1914         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
1915         (maintenance_print_one_line_table): Print a header for the is_stmt
1916         column, and include is_stmt information in the output.
1917         * symtab.c (find_pc_sect_line): Find lines marked as statements in
1918         preference to non-statements.
1919         (find_pcs_for_symtab_line): Prefer is-statement entries.
1920         (find_line_common): Likewise.
1921         * symtab.h (struct linetable_entry): Add is_stmt field.
1922         (struct symtab_and_line): Likewise.
1923         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
1924         arranging the line table.
1925
1926 2020-03-07  Tom de Vries  <tdevries@suse.de>
1927
1928         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
1929         DIE.
1930
1931 2020-03-07  Tom Tromey  <tom@tromey.com>
1932
1933         * valops.c (value_literal_complex): Remove obsolete comment.
1934         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
1935         comment.
1936
1937 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
1938
1939         * infrun.h: Forward-declare thread_info.
1940         (set_step_info): Add thread_info parameter, add doc.
1941         * infrun.c (set_step_info): Add thread_info parameter, move doc
1942         to header.
1943         * infrun.c (process_event_stop_test): Pass thread to
1944         set_step_info call.
1945         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
1946         set_step_info.
1947         (prepare_one_step): Add thread_info parameter, pass it to
1948         set_step_frame and prepare_one_step (recursive) call.
1949         (step_1): Pass thread to prepare_one_step call.
1950         (step_command_fsm::should_stop): Pass thread to
1951         prepare_one_step.
1952         (until_next_fsm): Pass thread to set_step_frame call.
1953         (finish_command): Pass thread to set_step_info call.
1954
1955 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
1956
1957         * windows-tdep.c (windows_solib_create_inferior_hook):
1958         Check if inferior is running.
1959
1960 2020-03-06  Tom de Vries  <tdevries@suse.de>
1961
1962         * NEWS: Fix "the the".
1963         * ctfread.c: Same.
1964
1965 2020-03-06  Tom de Vries  <tdevries@suse.de>
1966
1967         * psymtab.c (psymtab_to_symtab): Don't print "done.".
1968
1969 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1970
1971         * .dir-locals.el: Add a comment referencing the other copies of
1972         this file.
1973
1974 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
1975
1976         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
1977         psargs.
1978
1979 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1980
1981         * .gitattributes: New file.
1982
1983 2020-03-04  Tom Tromey  <tom@tromey.com>
1984
1985         * symmisc.c (print_symbol_bcache_statistics)
1986         (print_objfile_statistics): Update.
1987         * symfile.c (allocate_symtab): Use intern.
1988         * psymtab.c (partial_symtab::partial_symtab): Use intern.
1989         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1990         macro_cache>: Remove.
1991         <string_cache>: New member.
1992         (struct objfile) <intern>: New methods.
1993         * elfread.c (elf_symtab_read): Use intern.
1994         * dwarf2/read.c (fixup_go_packaging): Intern package name.
1995         (dwarf2_compute_name, dwarf2_physname)
1996         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
1997         names.
1998         (guess_partial_die_structure_name): Update.
1999         (partial_die_info::fixup): Intern name.
2000         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
2001         name.
2002         (dwarf2_name): Intern name.  Update.
2003         * buildsym.c (buildsym_compunit::get_macro_table): Use
2004         string_cache.
2005
2006 2020-03-04  Tom Tromey  <tom@tromey.com>
2007
2008         * jit.c (bfd_open_from_target_memory): Make "target" const.
2009         * corefile.c (gnutarget): Now const.
2010         * gdbcore.h (gnutarget): Now const.
2011
2012 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
2013
2014         * NEWS: Mention support for WOW64 processes.
2015         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
2016         (amd64_windows_segment_register_p): Remove static.
2017         (_initialize_amd64_windows_nat): Update.
2018         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
2019         * i386-windows-nat.c (context_offset): Update.
2020         (i386_mappings): Rename and remove static.
2021         (i386_windows_segment_register_p): Remove static.
2022         (_initialize_i386_windows_nat): Update.
2023         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
2024         (STATUS_WX86_SINGLE_STEP): New macro.
2025         (EnumProcessModulesEx): New macro.
2026         (Wow64SuspendThread): New macro.
2027         (Wow64GetThreadContext): New macro.
2028         (Wow64SetThreadContext): New macro.
2029         (Wow64GetThreadSelectorEntry): New macro.
2030         (windows_set_context_register_offsets): Add static.
2031         (windows_set_segment_register_p): Likewise.
2032         (windows_add_thread): Adapt for WOW64 processes.
2033         (windows_fetch_one_register): Likewise.
2034         (windows_nat_target::fetch_registers): Likewise.
2035         (windows_store_one_register): Likewise.
2036         (display_selector): Likewise.
2037         (display_selectors): Likewise.
2038         (handle_exception): Likewise.
2039         (windows_continue): Likewise.
2040         (windows_nat_target::resume): Likewise.
2041         (windows_add_all_dlls): Likewise.
2042         (do_initial_windows_stuff): Likewise.
2043         (windows_nat_target::attach): Likewise.
2044         (windows_get_exec_module_filename): Likewise.
2045         (windows_nat_target::create_inferior): Likewise.
2046         (windows_xfer_siginfo): Likewise.
2047         (_initialize_loadable): Initialize Wow64SuspendThread,
2048         Wow64GetThreadContext, Wow64SetThreadContext,
2049         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
2050         * windows-nat.h (windows_set_context_register_offsets):
2051         Remove declaration.
2052         (windows_set_segment_register_p): Likewise.
2053         (i386_windows_segment_register_p): Add declaration.
2054         (amd64_windows_segment_register_p): Likewise.
2055
2056 2020-03-04  Luis Machado  <luis.machado@linaro.org>
2057
2058         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
2059         in "info registers" for AArch64/ARM.
2060
2061         The change caused "info registers" to not print GPR's.
2062
2063         gdb/ChangeLog:
2064
2065         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
2066
2067         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
2068         when reg->group is empty and reggroup is not.
2069
2070 2020-03-03  Tom Tromey  <tromey@adacore.com>
2071
2072         * dwarf2/frame.c (struct dwarf2_frame_cache)
2073         <checked_tailcall_bottom, entry_cfa_sp_offset,
2074         entry_cfa_sp_offset_p>: Remove members.
2075         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
2076         (dwarf2_frame_prev_register): Don't call
2077         dwarf2_tailcall_sniffer_first.
2078         (dwarf2_append_unwinders): Don't append tailcall unwinder.
2079         * frame-unwind.c (add_unwinder): New fuction.
2080         (frame_unwind_init): Use it.  Add tailcall unwinder.
2081
2082 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2083             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
2084
2085         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
2086         value should be printed as true.
2087
2088 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
2089
2090         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
2091         (windows_init_abi): Set and use windows_so_ops.
2092
2093 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
2094
2095         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
2096         when verifying if dealing with a convenience variable.
2097
2098 2020-03-03  Luis Machado  <luis.machado@linaro.org>
2099
2100         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
2101
2102 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
2103
2104         * infrun.c (gdbarch_supports_displaced_stepping): New.
2105         (use_displaced_stepping): Break up conditions in smaller pieces.
2106         Use gdbarch_supports_displaced_stepping.
2107         (displaced_step_prepare_throw): Use
2108         gdbarch_supports_displaced_stepping.
2109
2110 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2111
2112         * NEWS: Mention new behaviour of the history filename.
2113         * top.c (write_history_p): Add comment.
2114         (show_write_history_p): Add header comment, give a different
2115         message when history writing is on, but the history filename is
2116         empty.
2117         (history_filename): Add comment.
2118         (history_filename_empty): New function.
2119         (show_history_filename): Add header comment, give a different
2120         message when the filename is empty.
2121         (init_history): Compare history_filename against nullptr, and only
2122         read history if the filename is not empty.
2123         (set_history_filename): Add header comment, and only make
2124         non-empty filenames absolute.
2125         (init_main): Make the filename argument to 'set history filename'
2126         optional.
2127
2128 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
2129
2130         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
2131         (arm_supply_vfpregset): ...this, and update to use VFP registers.
2132         (fetch_fp_register): Update.
2133         (fetch_fp_regs): Update.
2134         (store_fp_register): Update.
2135         (store_fp_regs): Update.
2136         (arm_netbsd_nat_target::read_description): New function.
2137         (fetch_elfcore_registers): Update.
2138
2139 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2140
2141         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
2142         general_thread if the stop reply is missing a thread-id.
2143         (remote_target::process_stop_reply): Use the first non-exited
2144         thread if the target didn't pass a thread-id.
2145         * infrun.c (do_target_wait): Move call to
2146         switch_to_inferior_no_thread to ....
2147         (do_target_wait_1): ... here.
2148
2149 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
2150
2151         * debuginfod-support.c: Include defs.h first.
2152
2153 2020-02-28  Tom de Vries  <tdevries@suse.de>
2154
2155         * symfile.c (set_initial_language): Use default language for lookup.
2156
2157 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
2158
2159         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
2160         reader variable, pass `this` to read_cutu_die_from_dwo.
2161
2162 2020-02-27  Aaron Merey  <amerey@redhat.com>
2163
2164         * source.c (open_source_file): Check for nullptr when computing
2165         srcpath.
2166
2167 2020-02-27  Tom Tromey  <tromey@adacore.com>
2168
2169         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
2170         member.
2171         (dwarf2_add_field): Don't update nfields.
2172         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
2173
2174 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2175
2176         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
2177         abs.
2178
2179 2020-02-26  Tom Tromey  <tom@tromey.com>
2180
2181         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
2182         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
2183         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
2184         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
2185         per_cu_data.
2186
2187 2020-02-26  Tom Tromey  <tom@tromey.com>
2188
2189         * dwarf2/index-write.c (psym_index_map): Change type.
2190         (add_address_entry_worker, write_one_signatured_type)
2191         (recursively_count_psymbols, recursively_write_psymbols)
2192         (class debug_names, psyms_seen_size, write_gdbindex)
2193         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
2194
2195 2020-02-26  Aaron Merey  <amerey@redhat.com>
2196
2197         * Makefile.in: Handle optional debuginfod support.
2198         * NEWS: Update.
2199         * README: Add --with-debuginfod summary.
2200         * config.in: Regenerate.
2201         * configure: Regenerate.
2202         * configure.ac: Handle optional debuginfod support.
2203         * debuginfod-support.c: debuginfod helper functions.
2204         * debuginfod-support.h: Ditto.
2205         * doc/gdb.texinfo: Add --with-debuginfod to configure options
2206         summary.
2207         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
2208         when a dwz file cannot be found.
2209         * elfread.c (elf_symfile_read): Query debuginfod servers when a
2210         debuginfo file cannot be found.
2211         * source.c (open_source_file): Query debuginfod servers when a
2212         source file cannot be found.
2213         * top.c (print_gdb_configuration): Include
2214         --{with,without}-debuginfod in the output.
2215
2216 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
2217
2218         * thread.c (thr_try_catch_cmd): Print thread name.
2219
2220 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
2221
2222         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
2223         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2224         dwarf2_fetch_die_type_sect_off): Move to...
2225         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
2226         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2227         dwarf2_fetch_die_type_sect_off): ... here.
2228         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
2229         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2230         dwarf2_fetch_die_type_sect_off): Move doc to header file.
2231
2232 2020-02-26  Tom de Vries  <tdevries@suse.de>
2233
2234         PR gdb/25603
2235         * symfile.c (set_initial_language): Exit-early if
2236         language_mode == language_mode_manual.
2237
2238 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
2239
2240         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
2241         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
2242         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
2243
2244 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
2245
2246         * gdbtypes.c (create_array_type_with_stride): Handle negative
2247         array strides.
2248         * valarith.c (value_subscripted_rvalue): Likewise.
2249
2250 2020-02-25  Luis Machado  <luis.machado@linaro.org>
2251
2252         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
2253
2254 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
2255
2256         * loc.h (dwarf2_get_die_type): Move to...
2257         * read.h (dwarf2_get_die_type): ... here.
2258         * read.c (dwarf2_get_die_type): Move doc to header.
2259
2260 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
2261
2262         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
2263         'gnulib/Makefile.in' to the list.
2264
2265 2020-02-24  Tom Tromey  <tom@tromey.com>
2266
2267         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
2268         Remove.
2269         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
2270         XOBNEWVEC.
2271
2272 2020-02-24  Tom Tromey  <tom@tromey.com>
2273
2274         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
2275         New method.
2276         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
2277         (dw2_do_instantiate_symtab, dw2_get_file_names)
2278         (build_type_psymtab_dependencies, load_full_type_unit): Update.
2279
2280 2020-02-24  Tom Tromey  <tom@tromey.com>
2281
2282         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
2283         make_scoped_restore.
2284         (dwarf2_psymtab::read_symtab): Don't clear
2285         reading_partial_symbols.
2286
2287 2020-02-24  Tom de Vries  <tdevries@suse.de>
2288
2289         PR gdb/25592
2290         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
2291
2292 2020-02-24  Tom de Vries  <tdevries@suse.de>
2293
2294         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
2295         commands layout next/prev/regs.
2296
2297 2020-02-22  Tom Tromey  <tom@tromey.com>
2298
2299         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
2300         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
2301
2302 2020-02-22  Tom Tromey  <tom@tromey.com>
2303
2304         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
2305
2306 2020-02-22  Tom Tromey  <tom@tromey.com>
2307
2308         * tui/tui-win.c (_initialize_tui_win): Add usage text.
2309         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
2310         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
2311         * tui/tui.c (_initialize_tui): Add usage text.
2312
2313 2020-02-22  Tom Tromey  <tom@tromey.com>
2314
2315         * tui/tui-win.c (tui_set_focus_command)
2316         (tui_set_win_height_command): Use error_no_arg.
2317         (_initialize_tui_win): Update help text.
2318         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
2319
2320 2020-02-22  Tom Tromey  <tom@tromey.com>
2321
2322         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
2323         * tui/tui-disasm.h (struct tui_disasm_window)
2324         <display_start_addr>: Declare.
2325         * tui/tui-source.h (struct tui_source_window)
2326         <display_start_addr>: Declare.
2327         * tui/tui-winsource.h (struct tui_source_window_base)
2328         <show_source_line, display_start_addr>: New methods.
2329         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
2330         Rename and move to protected section.
2331         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
2332         (tui_source_window_base::do_erase_source_content): Update.
2333         (tui_source_window_base::show_source_line): Now a method.
2334         (tui_source_window_base::show_source_content)
2335         (tui_source_window_base::tui_source_window_base)
2336         (tui_source_window_base::rerender)
2337         (tui_source_window_base::refill)
2338         (tui_source_window_base::do_scroll_horizontal)
2339         (tui_source_window_base::set_is_exec_point_at)
2340         (tui_source_window_base::update_breakpoint_info)
2341         (tui_source_window_base::update_exec_info): Update.
2342         * tui/tui-source.c (tui_source_window::set_contents)
2343         (tui_source_window::showing_source_p)
2344         (tui_source_window::do_scroll_vertical)
2345         (tui_source_window::location_matches_p)
2346         (tui_source_window::line_is_displayed): Update.
2347         (tui_source_window::display_start_addr): New method.
2348         * tui/tui-disasm.c (tui_disasm_window::set_contents)
2349         (tui_disasm_window::do_scroll_vertical)
2350         (tui_disasm_window::location_matches_p): Update.
2351         (tui_disasm_window::display_start_addr): New method.
2352
2353 2020-02-22  Tom Tromey  <tom@tromey.com>
2354
2355         * NEWS: Add entry for gdb.register_window_type.
2356         * tui/tui-layout.h (window_factory): New typedef.
2357         (tui_register_window): Declare.
2358         * tui/tui-layout.c (saved_tui_windows): New global.
2359         (tui_apply_current_layout): Use it.
2360         (tui_register_window): New function.
2361         * python/python.c (do_start_initialization): Call
2362         gdbpy_initialize_tui.
2363         (python_GdbMethods): Add "register_window_type" function.
2364         * python/python-internal.h (gdbpy_register_tui_window)
2365         (gdbpy_initialize_tui): Declare.
2366         * python/py-tui.c: New file.
2367         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
2368
2369 2020-02-22  Tom Tromey  <tom@tromey.com>
2370
2371         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
2372
2373 2020-02-22  Tom Tromey  <tom@tromey.com>
2374
2375         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
2376         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
2377         * tui/tui-data.c (tui_set_win_with_focus): Remove.
2378         (tui_set_win_focus_to): Move from tui-win.c.
2379
2380 2020-02-22  Tom Tromey  <tom@tromey.com>
2381
2382         * tui/tui-layout.c (make_standard_window, get_locator_window): New
2383         functions.
2384         (known_window_types): New global.
2385         (tui_get_window_by_name): Reimplement.
2386         (initialize_known_windows): New function.
2387         (validate_window_name): Rewrite.
2388         (_initialize_tui_layout): Call initialize_known_windows.
2389
2390 2020-02-22  Tom Tromey  <tom@tromey.com>
2391
2392         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
2393         Remove constants.
2394         * tui/tui-winsource.h (struct tui_source_window_base)
2395         <tui_source_window_base>: Remove parameter.
2396         * tui/tui-winsource.c
2397         (tui_source_window_base::tui_source_window_base): Remove
2398         parameter.
2399         (tui_source_window_base::refill): Update.
2400         * tui/tui-stack.h (struct tui_locator_window)
2401         <tui_locator_window>: Update.
2402         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
2403         Default the constructor.
2404         * tui/tui-regs.h (struct tui_data_item_window)
2405         <tui_data_item_window>: Default the constructor.
2406         (struct tui_data_window) <tui_data_window>: Likewise.
2407         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
2408         Default the constructor.
2409         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
2410         Default the constructor.
2411         <type>: Remove.
2412         (struct tui_win_info) <tui_win_info>: Default the constructor.
2413         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
2414         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2415         Default the constructor.
2416
2417 2020-02-22  Tom Tromey  <tom@tromey.com>
2418
2419         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
2420         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
2421         * tui/tui-win.c (tui_resize_all): Don't call
2422         tui_delete_invisible_windows.
2423         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
2424         done.
2425         (tui_set_layout): Update.
2426         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
2427         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
2428         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
2429
2430 2020-02-22  Tom Tromey  <tom@tromey.com>
2431
2432         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
2433         correctly.
2434
2435 2020-02-22  Tom Tromey  <tom@tromey.com>
2436
2437         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
2438
2439 2020-02-22  Tom Tromey  <tom@tromey.com>
2440
2441         * tui/tui-winsource.h (struct tui_source_window_iterator)
2442         <inner_iterator>: New etytypedef.
2443         <tui_source_window_iterator>: Take "end" parameter.
2444         <tui_source_window_iterator>: Take iterator.
2445         <operator*, advance>: Update.
2446         <m_iter>: Change type.
2447         <m_end>: New field.
2448         (struct tui_source_windows) <begin, end>: Update.
2449         * tui/tui-layout.c (tui_windows): New global.
2450         (tui_apply_current_layout): Clear tui_windows.
2451         (tui_layout_window::apply): Update tui_windows.
2452         * tui/tui-data.h (tui_windows): Declare.
2453         (all_tui_windows): Now inline function.
2454         (class tui_window_iterator, struct all_tui_windows): Remove.
2455
2456 2020-02-22  Tom Tromey  <tom@tromey.com>
2457
2458         PR tui/17850:
2459         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
2460         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
2461         "height" argument.
2462         (class tui_layout_window) <get_sizes>: Likewise.
2463         (class tui_layout_split) <tui_layout_split>: Add "vertical"
2464         argument.
2465         <get_sizes>: Add "height" argument.
2466         <m_vertical>: New field.
2467         * tui/tui-layout.c (tui_layout_split::clone): Update.
2468         (tui_layout_split::get_sizes): Add "height" argument.
2469         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
2470         (tui_new_layout_command): Parse "-horizontal".
2471         (_initialize_tui_layout): Update help string.
2472         (tui_layout_split::specification): Add "-horizontal" when needed.
2473         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
2474         argument.
2475         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
2476         New methods.
2477
2478 2020-02-22  Tom Tromey  <tom@tromey.com>
2479
2480         * tui/tui-layout.h (enum tui_adjust_result): New.
2481         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
2482         (class tui_layout_window) <adjust_size>: Return
2483         tui_adjust_result.  Rewrite.
2484         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
2485         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
2486
2487 2020-02-22  Tom Tromey  <tom@tromey.com>
2488
2489         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
2490         parameter and return types.
2491         (class tui_layout_base) <specification>: Add "depth".
2492         (class tui_layout_window) <specification>: Add "depth".
2493         (class tui_layout_split) <specification>: Add "depth".
2494         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
2495         and return types.
2496         (tui_new_layout_command): Parse sub-layouts.
2497         (_initialize_tui_layout): Update help string.
2498         (tui_layout_window::specification): Add "depth".
2499         (add_layout_command): Update.
2500
2501 2020-02-22  Tom Tromey  <tom@tromey.com>
2502
2503         * NEWS: Add "tui new-layout" item.
2504         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
2505         Add new-layout command to help text.
2506         (validate_window_name): New function.
2507         (tui_new_layout_command): New function.
2508         (_initialize_tui_layout): Register "new-layout".
2509         (tui_layout_window::specification): New method.
2510         (tui_layout_window::specification): New method.
2511         * tui/tui-layout.h (class tui_layout_base) <specification>: New
2512         method.
2513         (class tui_layout_window) <specification>: New method.
2514         (class tui_layout_split) <specification>: New method.
2515
2516 2020-02-22  Tom Tromey  <tom@tromey.com>
2517
2518         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
2519         * tui/tui-win.c (window_name_completer): Update comment.
2520         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
2521         Declare method.
2522         (class tui_layout_window) <replace_window>: Likewise.
2523         (class tui_layout_split) <replace_window>: Likewise.
2524         (tui_set_layout): Don't declare.
2525         (tui_set_initial_layout): Declare function.
2526         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
2527         (asm_regs_layout): New globals.
2528         (tui_current_layout, show_layout): Remove.
2529         (tui_set_layout, tui_add_win_to_layout): Rewrite.
2530         (find_layout, tui_apply_layout): New function.
2531         (layout_completer): Remove.
2532         (tui_next_layout): Reimplement.
2533         (tui_next_layout_command): New function.
2534         (tui_set_initial_layout, tui_prev_layout_command): New functions.
2535         (tui_regs_layout): Reimplement.
2536         (tui_regs_layout_command): New function.
2537         (extract_display_start_addr): Rewrite.
2538         (next_layout, prev_layout): Remove.
2539         (tui_layout_window::replace_window): New method.
2540         (tui_layout_split::replace_window): New method.
2541         (destroy_layout): New function.
2542         (layout_list): New global.
2543         (add_layout_command): New function.
2544         (initialize_layouts): Update.
2545         (tui_layout_command): New function.
2546         (_initialize_tui_layout): Install "layout" commands.
2547         * tui/tui-data.h (enum tui_layout_type): Remove.
2548         (tui_current_layout): Don't declare.
2549
2550 2020-02-22  Tom Tromey  <tom@tromey.com>
2551
2552         * tui/tui-regs.c (tui_reg_layout): Remove.
2553         (tui_reg_command): Use tui_regs_layout.
2554         * tui/tui-layout.h (tui_reg_command): Declare.
2555         * tui/tui-layout.c (tui_reg_command): New function.
2556
2557 2020-02-22  Tom Tromey  <tom@tromey.com>
2558
2559         * tui/tui.c (tui_rl_delete_other_windows): Call
2560         tui_remove_some_windows.
2561         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
2562         Declare method.
2563         (class tui_layout_window) <remove_windows>: New method.
2564         (class tui_layout_split) <remove_windows>: Declare.
2565         (tui_remove_some_windows): Declare.
2566         * tui/tui-layout.c (tui_remove_some_windows): New function.
2567         (tui_layout_split::remove_windows): New method.
2568
2569 2020-02-22  Tom Tromey  <tom@tromey.com>
2570
2571         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
2572         * tui/tui-layout.h (tui_next_layout): Declare.
2573         * tui/tui-layout.c (tui_next_layout): New function.
2574
2575 2020-02-22  Tom Tromey  <tom@tromey.com>
2576
2577         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
2578         correct coordinates.
2579
2580 2020-02-22  Tom Tromey  <tom@tromey.com>
2581
2582         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
2583         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
2584         DATA_WIN case.
2585
2586 2020-02-22  Tom Tromey  <tom@tromey.com>
2587
2588         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
2589         TUI_DISASM_WIN, not tui_win_list.
2590
2591 2020-02-22  Tom Tromey  <tom@tromey.com>
2592
2593         * valprint.c (generic_val_print_enum_1)
2594         (val_print_type_code_flags): Style member names.
2595         * rust-lang.c (val_print_struct, rust_print_enum)
2596         (rust_print_struct_def, rust_internal_print_type): Style member
2597         names.
2598         * p-valprint.c (pascal_object_print_value_fields): Style member
2599         names.  Only call fprintf_symbol_filtered for static members.
2600         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
2601         * f-valprint.c (f_val_print): Style member names.
2602         * f-typeprint.c (f_type_print_base): Style member names.
2603         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
2604         call fprintf_symbol_filtered for static members.
2605         (cp_print_class_member): Style member names.
2606         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
2607         member names.
2608         * ada-valprint.c (ada_print_scalar): Style enum names.
2609         (ada_val_print_enum): Likewise.
2610         * ada-typeprint.c (print_enum_type): Style enum names.
2611
2612 2020-02-21  Tom Tromey  <tom@tromey.com>
2613
2614         * psympriv.h (struct partial_symtab): Update comment.
2615
2616 2020-02-21  Tom Tromey  <tromey@adacore.com>
2617
2618         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
2619         type is CORE_ADDR.
2620
2621 2020-02-21  Tom de Vries  <tdevries@suse.de>
2622
2623         PR gdb/25534
2624         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
2625         if dependencies[i]->user != NULL.
2626
2627 2020-02-21  Ali Tamur  <tamur@google.com>
2628
2629         * dwarf2/read.c (dwarf2_name): Add null check.
2630
2631 2020-02-20  Tom Tromey  <tom@tromey.com>
2632
2633         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
2634         ">=", in binary search.
2635         (dwarf2_find_containing_comp_unit): New overload.
2636         (run_test): New self-test.
2637         (_initialize_dwarf2_read): Register new test.
2638
2639 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
2640
2641         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
2642         * riscv-tdep.h: Likewise.
2643         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
2644         rv32-only CSR.
2645         * features/riscv/64bit-csr.xml: Regenerated.
2646
2647 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
2648             Tom Tromey  <tom@tromey.com>
2649
2650         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
2651         of 'fputc_unfiltered'.
2652         (putchar_unfiltered): Call 'fputc_unfiltered'.
2653         (fputc_unfiltered): Call 'fputs_unfiltered'.
2654
2655 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
2656
2657         * config.in: Regenerate.
2658         * configure: Regenerate.
2659         * configure.ac: Add --with-python-libdir option.
2660         * main.c: Use WITH_PYTHON_LIBDIR.
2661
2662 2020-02-19  Tom Tromey  <tom@tromey.com>
2663
2664         * symtab.c (general_symbol_info::compute_and_set_names): Use
2665         obstack_strndup.  Simplify call to symbol_set_demangled_name.
2666
2667 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
2668
2669         * dwarf2/read.c (allocate_signatured_type_table,
2670         allocate_dwo_unit_table, allocate_type_unit_groups_table,
2671         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
2672         Remove objfile parameter, update all callers.
2673
2674 2020-02-19  Doug Evans  <dje@google.com>
2675
2676         PR rust/25535
2677         * rust-lang.c (rust_print_enum): Apply embedded_offset to
2678         rust_enum_variant calculation.
2679
2680 2020-02-19  Tom Tromey  <tromey@adacore.com>
2681
2682         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
2683
2684 2020-02-19  Tom Tromey  <tromey@adacore.com>
2685
2686         * ada-lang.c (cache_symbol): Use obstack_strdup.
2687
2688 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2689
2690         * configure: Regenerate.
2691
2692 2020-02-19  Tom Tromey  <tromey@adacore.com>
2693
2694         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
2695         NULL check.
2696
2697 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
2698
2699         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
2700
2701 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2702
2703         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
2704         if GDBSERVER is not defined.
2705         (riscv_tdesc_cache): Likewise, also store const target_desc.
2706         (STATIC_IN_GDB): Define.
2707         (riscv_create_target_description): Update declaration with
2708         STATIC_IN_GDB.
2709         (riscv_lookup_target_description): New function, only define if
2710         GDBSERVER is not defined.
2711         * arch/riscv.h (riscv_create_target_description): Declare only
2712         when GDBSERVER is defined.
2713         (riscv_lookup_target_description): New declaration when GDBSERVER
2714         is not defined.
2715         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
2716         (riscv_linux_read_features): ...this, and return
2717         riscv_gdbarch_features instead of target_desc.
2718         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
2719         (riscv_linux_read_description): Rename to...
2720         (riscv_linux_read_features): ...this.
2721         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
2722         Update to use riscv_gdbarch_features and
2723         riscv_lookup_target_description.
2724         * riscv-tdep.c (riscv_find_default_target_description): Use
2725         riscv_lookup_target_description instead of
2726         riscv_create_target_description.
2727
2728 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
2729
2730         * valprint.c (generic_val_print_enum_1): When printing a flag
2731         enum with value 0 and there is no enumerator with value 0, print
2732         just "0" instead of "(unknown: 0x0)".
2733
2734 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
2735
2736         * valprint.c (generic_val_print_enum_1): Print unknown part of
2737         flag enum in hex.
2738
2739 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
2740
2741         * dwarf2/read.c (update_enumeration_type_from_children): Allow
2742         flag enums to contain duplicate enumerators.
2743         * valprint.c (generic_val_print_enum_1): Update comment.
2744
2745 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
2746
2747         * dwarf2/read.c: Include "count-one-bits.h".
2748         (update_enumeration_type_from_children): If an enumerator has
2749         multiple bits set, don't treat the enumeration as a "flag enum".
2750         * valprint.c (generic_val_print_enum_1): Assert that enumerators
2751         of flag enums have 0 or 1 bit set.
2752
2753 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
2754
2755         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
2756         conversion.
2757         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
2758         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
2759         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
2760         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
2761         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
2762
2763 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
2764
2765         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
2766
2767 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
2768
2769         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
2770         displaced_step_closure_up.
2771         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
2772         (struct displaced_step_closure_up):
2773         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
2774         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
2775         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
2776         Likewise.
2777         * gdbarch.sh (displaced_step_copy_insn): Likewise.
2778         * gdbarch.c, gdbarch.h: Re-generate.
2779         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
2780         displaced_step_closure_up.
2781         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
2782         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
2783         * infrun.h (displaced_step_closure_up): New type alias.
2784         (struct displaced_step_inferior_state) <step_closure>: Change
2785         type to displaced_step_closure_up.
2786         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
2787         displaced_step_closure_up.
2788         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
2789
2790 2020-02-14  Tom Tromey  <tom@tromey.com>
2791
2792         * minidebug.c (gnu_debug_key): New global.
2793         (find_separate_debug_file_in_section): Use it.
2794
2795 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
2796
2797         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
2798         std::unique_ptr.
2799         * gdbarch.c: Re-generate.
2800         * gdbarch.h: Re-generate.
2801         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
2802         change.
2803         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
2804         type to std::unique_ptr.
2805         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
2806         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
2807         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
2808         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
2809         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
2810         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
2811         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
2812         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
2813         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
2814
2815 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
2816
2817         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
2818         std::unique_ptr.
2819         (displaced_step_clear): Rename to...
2820         (displaced_step_reset): ... this.  Just call displaced->reset ().
2821         (displaced_step_clear_cleanup): Rename to...
2822         (displaced_step_reset_cleanup): ... this.
2823         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
2824         (displaced_step_fixup): Likewise.
2825         (resume_1): Likewise.
2826         (handle_inferior_event): Restore child's memory before calling
2827         displaced_step_fixup on the parent.
2828         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
2829         to std::unique_ptr.
2830         <step_closure>: Change type to std::unique_ptr.
2831
2832 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
2833
2834         * arm-tdep.c: Include count-one-bits.h.
2835         (cleanup_block_store_pc): Use count_one_bits.
2836         (cleanup_block_load_pc): Use count_one_bits.
2837         (arm_copy_block_xfer): Use count_one_bits.
2838         (thumb2_copy_block_xfer): Use count_one_bits.
2839         (thumb_copy_pop_pc_16bit): Use count_one_bits.
2840         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
2841         (thumb_get_next_pcs_raw): Use count_one_bits.
2842         (arm_get_next_pcs_raw): Use count_one_bits_l.
2843         * arch/arm.c (bitcount): Remove.
2844         * arch/arm.h (bitcount): Remove.
2845
2846 2020-02-14  Tom Tromey  <tromey@adacore.com>
2847
2848         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
2849         Update.
2850         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
2851         * dwarf2/loc.c (call_site_find_chain_1): Return
2852         unique_xmalloc_ptr.
2853         (call_site_find_chain): Likewise.
2854
2855 2020-02-14  Richard Biener  <rguenther@suse.de>
2856
2857         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
2858         on expression with division operators.
2859
2860 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
2861
2862         * MAINTAINERS (Write After Approval): Adding myself.
2863
2864 2020-02-12  Tom Tromey  <tom@tromey.com>
2865
2866         * event-loop.c (event_data, gdb_event, event_handler_func):
2867         Remove.
2868
2869 2020-02-12  Tom Tromey  <tom@tromey.com>
2870
2871         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
2872         (dwarf2_frame_objfile_data): Add comment.
2873         (find_comp_unit, set_comp_unit): New functions.
2874         (dwarf2_frame_find_fde): Use find_comp_unit.
2875         (dwarf2_build_frame_info): Use set_comp_unit.
2876
2877 2020-02-12  Tom Tromey  <tom@tromey.com>
2878
2879         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
2880         (comp_unit): Don't initialize objfile.
2881         (execute_cfa_program): Add text_offset parameter.
2882         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
2883         (dwarf2_frame_cache): Update.
2884         (dwarf2_build_frame_info): Don't set "objfile" member.
2885
2886 2020-02-12  Tom Tromey  <tom@tromey.com>
2887
2888         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
2889         (decode_frame_entry): Likewise.
2890         (dwarf2_build_frame_info): Update.
2891
2892 2020-02-12  Tom Tromey  <tom@tromey.com>
2893
2894         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
2895         (decode_frame_entry_1): Use the comp_unit obstack.
2896
2897 2020-02-12  Tom Tromey  <tom@tromey.com>
2898
2899         * dwarf2/frame.c (struct comp_unit): Add initializers and
2900         constructor.
2901         (dwarf2_frame_objfile_data): Store a comp_unit.
2902         (dwarf2_frame_find_fde): Update.
2903         (dwarf2_build_frame_info): Use "new".
2904
2905 2020-02-12  Tom Tromey  <tom@tromey.com>
2906
2907         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
2908         (dwarf2_fde_table): Typedef for std::vector.
2909         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
2910         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
2911         (decode_frame_entry): Update.
2912         (dwarf2_build_frame_info): Use "new".
2913
2914 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
2915
2916         * arm-tdep.c (arm_gdbarch_init): Update.
2917         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
2918         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
2919         have_neon, is_m>: Change to bool.
2920
2921 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
2922
2923         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
2924
2925 2020-02-12  Tom Tromey  <tom@tromey.com>
2926
2927         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
2928
2929 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
2930
2931         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
2932         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
2933
2934 2020-02-11  Tom Tromey  <tom@tromey.com>
2935
2936         * psymtab.h: Update comment.
2937
2938 2020-02-11  Tom Tromey  <tom@tromey.com>
2939
2940         * gdb_obstack.h (struct auto_obstack): Use
2941         DISABLE_COPY_AND_ASSIGN.
2942
2943 2020-02-11  Tom Tromey  <tom@tromey.com>
2944
2945         * dwarf2/frame.h (struct objfile): Don't forward declare.
2946
2947 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
2948
2949         * cris-tdep.c (cris_supply_gregset): Change signature to match
2950         what struct regset expects.
2951         (cris_regset): New struct.
2952         (fetch_core_registers): Remove.
2953         (cris_iterate_over_regset_sections): New function.
2954         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
2955         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
2956
2957 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
2958
2959         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
2960         registers.
2961
2962 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
2963
2964         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
2965
2966 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
2967
2968         * configure: Re-generate.
2969
2970 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
2971
2972         * configure: Re-generate.
2973
2974 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
2975
2976         * acinclude: Update warning.m4 path.
2977         * warning.m4: Move to gdbsupport.
2978
2979 2020-02-11  Tom Tromey  <tromey@adacore.com>
2980
2981         * remote.c (remote_console_output): Update.
2982         * printcmd.c (printf_command): Update.
2983         * event-loop.c (gdb_wait_for_event): Update.
2984         * linux-nat.c (sigchld_handler): Update.
2985         * remote-sim.c (gdb_os_write_stdout): Update.
2986         (gdb_os_flush_stdout): Update.
2987         (gdb_os_flush_stderr): Update.
2988         (gdb_os_write_stderr): Update.
2989         * exceptions.c (print_exception): Update.
2990         * remote-fileio.c (remote_fileio_func_read): Update.
2991         (remote_fileio_func_write): Update.
2992         * tui/tui.c (tui_enable): Update.
2993         * tui/tui-interp.c (tui_interp::init): Update.
2994         * utils.c (init_page_info): Update.
2995         (putchar_unfiltered, fputc_unfiltered): Update.
2996         (gdb_flush): Update.
2997         (emit_style_escape): Update.
2998         (flush_wrap_buffer, fputs_maybe_filtered): Update.
2999         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
3000         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
3001         (stderr_file::write): Update.
3002         (stderr_file::puts): Update.
3003         * ui-file.h (ui_file_isatty, ui_file_write)
3004         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
3005         (ui_file_puts): Don't declare.
3006
3007 2020-02-10  Tom de Vries  <tdevries@suse.de>
3008
3009         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
3010         sentinel to char *.
3011
3012 2020-02-09  Tom de Vries  <tdevries@suse.de>
3013
3014         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
3015         filename if it matches "<artificial>".
3016
3017 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
3018
3019         * windows-tdep.c (struct enum_value_name): New struct.
3020         (create_enum): New function.
3021         (windows_get_siginfo_type): Create and use enum types.
3022
3023 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
3024
3025         * NEWS: Mention $_siginfo support for Windows.
3026         * windows-nat.c (handle_exception): Set siginfo_er.
3027         (windows_nat_target::mourn_inferior): Reset siginfo_er.
3028         (windows_xfer_siginfo): New function.
3029         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
3030         * windows-tdep.c (struct windows_gdbarch_data): New struct.
3031         (init_windows_gdbarch_data): New function.
3032         (get_windows_gdbarch_data): New function.
3033         (windows_get_siginfo_type): New function.
3034         (windows_init_abi): Register windows_get_siginfo_type.
3035         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
3036
3037 2020-02-08  Tom Tromey  <tom@tromey.com>
3038
3039         * dwarf2/read.c (class cutu_reader) <cutu_reader,
3040         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
3041         <keep>: Declare method.
3042         <m_keep>: Remove member.
3043         <~cutu_reader>: Remove.
3044         (cutu_reader::init_tu_and_read_dwo_dies): Update.
3045         (cutu_reader::cutu_reader): Update.
3046         (cutu_reader::keep): Rename from ~cutu_reader.
3047         (process_psymtab_comp_unit, build_type_psymtabs_1)
3048         (process_skeletonless_type_unit, load_partial_comp_unit)
3049         (load_full_comp_unit, dwarf2_read_addr_index)
3050         (read_signatured_type): Update.
3051
3052 2020-02-08  Tom Tromey  <tom@tromey.com>
3053
3054         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
3055         "want_partial_unit" parameter.
3056         (process_psymtab_comp_unit): Change want_partial_unit to bool.
3057         Inline check for DW_TAG_partial_unit.
3058         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
3059
3060 2020-02-08  Tom Tromey  <tom@tromey.com>
3061
3062         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
3063         read.c.
3064         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
3065         read.c.
3066
3067 2020-02-08  Tom Tromey  <tom@tromey.com>
3068
3069         * dwarf2/read.c (read_address): Move to comp-unit.c.
3070         (dwarf2_rnglists_process, dwarf2_ranges_process)
3071         (read_attribute_value, dwarf_decode_lines_1)
3072         (var_decode_location, decode_locdesc): Update.
3073         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
3074         read.c.  Remove "cu" parameter.
3075         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
3076         method.
3077
3078 2020-02-08  Tom Tromey  <tom@tromey.com>
3079
3080         * dwarf2/read.c (read_attribute_value, read_indirect_string)
3081         (read_indirect_line_string): Update.
3082         * dwarf2/comp-unit.c (read_offset): Remove.
3083         (read_comp_unit_head): Update.
3084         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
3085         method.
3086         (read_offset): Don't declare.
3087
3088 2020-02-08  Tom Tromey  <tom@tromey.com>
3089
3090         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
3091         * dwarf2/read.c (struct comp_unit_head): Move to
3092         dwarf2/comp-unit.h.
3093         (enum class rcuh_kind): Move to comp-unit.h.
3094         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
3095         (read_comp_unit_head, error_check_comp_unit_head)
3096         (read_and_check_comp_unit_head): Move to comp-unit.c.
3097         (read_offset, dwarf_unit_type_name): Likewise.
3098         (create_debug_type_hash_table, read_cutu_die_from_dwo)
3099         (cutu_reader::cutu_reader, read_call_site_scope)
3100         (find_partial_die, follow_die_offset): Update.
3101         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
3102
3103 2020-02-08  Tom Tromey  <tom@tromey.com>
3104
3105         * dwarf2/read.c (read_offset_1): Move to leb.c.
3106         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
3107         (dwarf_decode_macro_bytes): Update.
3108         * dwarf2/leb.c (read_offset): Rename; move from read.c.
3109         * dwarf2/leb.h (read_offset): Declare.
3110
3111 2020-02-08  Tom Tromey  <tom@tromey.com>
3112
3113         * dwarf2/read.c (dwarf2_section_size): Remove.
3114         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
3115         Update.
3116         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
3117
3118 2020-02-08  Tom Tromey  <tom@tromey.com>
3119
3120         * dwarf2/read.c (read_initial_length): Move to leb.c.
3121         * dwarf2/leb.h (read_initial_length): Declare.
3122         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
3123         handle_nonstd parameter.
3124         * dwarf2/frame.c (read_initial_length): Remove.
3125         (decode_frame_entry_1): Update.
3126
3127 2020-02-08  Tom Tromey  <tom@tromey.com>
3128
3129         * dwarf2/loc.c (dwarf2_find_location_expression)
3130         (dwarf_evaluate_loc_desc::get_tls_address)
3131         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
3132         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
3133         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
3134         (dwarf2_compile_property_to_c)
3135         (dwarf2_loc_desc_get_symbol_read_needs)
3136         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
3137         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
3138         (loclist_describe_location, loclist_tracepoint_var_ref)
3139         (loclist_generate_c_location): Update.
3140         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
3141         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
3142         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
3143         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
3144         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
3145         (dwarf2_per_cu_data::addr_size)
3146         (dwarf2_per_cu_data::ref_addr_size)
3147         (dwarf2_per_cu_data::text_offset)
3148         (dwarf2_per_cu_data::addr_type): Now methods.
3149         (per_cu_header_read_in): Make per_cu "const".
3150         (dwarf2_version): Remove.
3151         (dwarf2_per_cu_data::int_type): Now a method.
3152         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
3153         (set_die_type, read_array_type, read_subrange_index_type)
3154         (read_tag_string_type, read_subrange_type): Update.
3155         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
3156         offset_size, ref_addr_size, text_offset, addr_type, version,
3157         objfile, int_type, addr_sized_int_type>: Declare methods.
3158
3159 2020-02-08  Tom Tromey  <tom@tromey.com>
3160
3161         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
3162         Move earlier.
3163
3164 2020-02-08  Tom Tromey  <tom@tromey.com>
3165
3166         * dwarf2/read.h (dwarf_line_debug): Declare.
3167         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
3168         * dwarf2/read.c: Move line_header code to new files.
3169         (dwarf_line_debug): No longer static.
3170         * dwarf2/line-header.c: New file.
3171         * dwarf2/line-header.h: New file.
3172
3173 2020-02-08  Tom Tromey  <tom@tromey.com>
3174
3175         * dwarf2/read.c (struct line_header) <file_full_name,
3176         file_file_name>: Return unique_xmalloc_ptr.
3177         (line_header::file_file_name): Update.
3178         (line_header::file_full_name): Update.
3179         (dw2_get_file_names_reader): Update.
3180         (macro_start_file): Update.
3181
3182 2020-02-08  Tom Tromey  <tom@tromey.com>
3183
3184         * dwarf2/read.c (struct line_header) <file_full_name,
3185         file_file_name>: Declare methods.
3186         (dw2_get_file_names_reader): Update.
3187         (file_file_name): Now a method.
3188         (file_full_name): Likewise.
3189         (macro_start_file): Update.
3190
3191 2020-02-08  Tom Tromey  <tom@tromey.com>
3192
3193         * dwarf2/read.c (dwarf_always_disassemble)
3194         (show_dwarf_always_disassemble): Move to loc.c.
3195         (_initialize_dwarf2_read): Move "always-disassemble" registration
3196         to loc.c.
3197         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
3198         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
3199         static.
3200         (show_dwarf_always_disassemble): Move from read.c.
3201         (_initialize_dwarf2loc): Move always-disassemble from read.c.
3202
3203 2020-02-08  Tom Tromey  <tom@tromey.com>
3204
3205         * dwarf2/read.c (~dwarf2_per_objfile): Update.
3206         (create_quick_file_names_table): Return htab_up.
3207         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
3208         Update.
3209         * dwarf2/read.h (struct dwarf2_per_objfile)
3210         <quick_file_names_table>: Now htab_up.
3211
3212 2020-02-08  Tom Tromey  <tom@tromey.com>
3213
3214         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
3215
3216 2020-02-08  Tom Tromey  <tom@tromey.com>
3217
3218         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
3219         Rewrite.
3220         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
3221         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
3222         (abbrev_table::abbrev_table): No longer inline.
3223         (ABBREV_HASH_SIZE): Remove.
3224         (abbrev_table::m_abbrevs): Now an htab_up.
3225
3226 2020-02-08  Tom Tromey  <tom@tromey.com>
3227
3228         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
3229         (cutu_reader): Update.
3230         (build_type_psymtabs_1): Update.
3231         * dwarf2/abbrev.c (abbrev_table::read): Rename.
3232         (abbrev_table::alloc_abbrev): Update.
3233         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
3234         (abbrev_table::read): New static method, renamed from
3235         abbrev_table_read_table.
3236         (abbrev_table::alloc_abbrev)
3237         (abbrev_table::add_abbrev): Now private.
3238         (abbrev_table::abbrev_table): Now private.
3239         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
3240
3241 2020-02-08  Tom Tromey  <tom@tromey.com>
3242
3243         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
3244         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
3245         htab_up.
3246
3247 2020-02-08  Tom Tromey  <tom@tromey.com>
3248
3249         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
3250         htab_up.
3251         (lookup_dwo_unit_in_dwp): Update.
3252         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
3253         on obstack.
3254
3255 2020-02-08  Tom Tromey  <tom@tromey.com>
3256
3257         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
3258         obstack.
3259
3260 2020-02-08  Tom Tromey  <tom@tromey.com>
3261
3262         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
3263         line_header_hash.
3264         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
3265         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
3266         Change type to htab_up.
3267
3268 2020-02-08  Tom Tromey  <tom@tromey.com>
3269
3270         * dwarf2/read.c (allocate_type_unit_groups_table): Return
3271         htab_up.  Don't allocate on obstack.
3272         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
3273         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
3274         Change type to htab_up.
3275
3276 2020-02-08  Tom Tromey  <tom@tromey.com>
3277
3278         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
3279         Change type to htab_up.
3280         * dwarf2/read.c (create_signatured_type_table_from_index)
3281         (create_signatured_type_table_from_debug_names)
3282         (create_all_type_units, add_type_unit)
3283         (lookup_dwo_signatured_type, lookup_signatured_type)
3284         (process_skeletonless_type_unit): Update.
3285         (create_debug_type_hash_table, create_debug_types_hash_table):
3286         Change type of types_htab.
3287         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
3288         htab_up.  Don't allocate on obstack.
3289         (create_cus_hash_table): Change type of cus_htab parameter.
3290         (struct dwo_file) <cus, tus>: Now htab_up.
3291         (lookup_dwo_signatured_type, lookup_dwo_cutu)
3292         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
3293         (queue_and_load_all_dwo_tus): Update.
3294         * dwarf2/index-write.c (write_gdbindex): Update.
3295         (write_debug_names): Update.
3296
3297 2020-02-08  Tom Tromey  <tom@tromey.com>
3298
3299         * dwarf2/read.h (struct dwarf2_queue_item): Move from
3300         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
3301         destructor.
3302         (struct dwarf2_per_objfile) <queue>: New member.
3303         * dwarf2/read.c (struct dwarf2_queue_item): Move to
3304         dwarf2/read.h.
3305         (dwarf2_queue, dwarf2_queue_tail): Remove.
3306         (class dwarf2_queue_guard): Add parameter to constructor.  Use
3307         DISABLE_COPY_AND_ASSIGN.
3308         <m_per_objfile>: New member.
3309         <~dwarf2_queue_guard>: Rewrite.
3310         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
3311         Update.
3312         (~dwarf2_queue_item): New.
3313
3314 2020-02-08  Tom Tromey  <tom@tromey.com>
3315
3316         * dwarf2/read.c (struct die_info) <has_children>: New member.
3317         (dw2_get_file_names_reader): Remove has_children.
3318         (dw2_get_file_names): Update.
3319         (read_cutu_die_from_dwo): Remove has_children.
3320         (cutu_reader::init_tu_and_read_dwo_dies)
3321         (cutu_reader::cutu_reader): Update.
3322         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
3323         Remove has_children.
3324         (build_type_psymtabs_1, process_skeletonless_type_unit)
3325         (load_partial_comp_unit, load_full_comp_unit): Update.
3326         (create_dwo_cu_reader): Remove has_children.
3327         (create_cus_hash_table, read_die_and_children): Update.
3328         (read_full_die_1,read_full_die): Remove has_children.
3329         (read_signatured_type): Update.
3330         (class cutu_reader) <has_children>: Remove.
3331
3332 2020-02-08  Tom Tromey  <tom@tromey.com>
3333
3334         * dwarf2/expr.c: Rename from dwarf2expr.c.
3335         * dwarf2/expr.h: Rename from dwarf2expr.h.
3336         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
3337         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
3338         * dwarf2/frame.c: Rename from dwarf2-frame.c.
3339         * dwarf2/frame.h: Rename from dwarf2-frame.h.
3340         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
3341         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
3342         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
3343         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
3344         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
3345         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
3346         * dwarf2/loc.c: Rename from dwarf2loc.c.
3347         * dwarf2/loc.h: Rename from dwarf2loc.h.
3348         * dwarf2/read.c: Rename from dwarf2read.c.
3349         * dwarf2/read.h: Rename from dwarf2read.h.
3350         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
3351         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
3352         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
3353         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
3354         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
3355         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
3356         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
3357         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
3358         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
3359         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
3360         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
3361         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
3362         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
3363         Update.
3364         * Makefile.in (COMMON_SFILES): Update.
3365         (HFILES_NO_SRCDIR): Update.
3366
3367 2020-02-08  Tom Tromey  <tom@tromey.com>
3368
3369         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
3370         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
3371
3372 2020-02-08  Tom Tromey  <tom@tromey.com>
3373
3374         * dwarf2read.h (struct die_info): Don't declare.
3375
3376 2020-02-08  Tom Tromey  <tom@tromey.com>
3377
3378         * dwarf2read.h (die_info_ptr): Remove typedef.
3379
3380 2020-02-08  Tom Tromey  <tom@tromey.com>
3381
3382         * dwarf2read.c (read_call_site_scope)
3383         (handle_data_member_location, dwarf2_add_member_fn)
3384         (mark_common_block_symbol_computed, read_common_block)
3385         (attr_to_dynamic_prop, partial_die_info::read)
3386         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
3387         (dwarf2_symbol_mark_computed, set_die_type): Update.
3388         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
3389         method.
3390         (attr_form_is_block): Don't declare.
3391         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
3392
3393 2020-02-08  Tom Tromey  <tom@tromey.com>
3394
3395         * dwarf2read.c (dwarf2_find_base_address, )
3396         (read_call_site_scope, rust_containing_type)
3397         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
3398         (handle_data_member_location, dwarf2_add_member_fn)
3399         (get_alignment, read_structure_type, process_structure_scope)
3400         (mark_common_block_symbol_computed, read_common_block)
3401         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
3402         (partial_die_info::read, read_attribute_value, new_symbol)
3403         (lookup_die_type, dwarf2_get_ref_die_offset)
3404         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
3405         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
3406         (dwarf2_symbol_mark_computed): Update.
3407         * dwarf2/attribute.h (struct attribute) <value_as_address,
3408         form_is_section_offset, form_is_constant, form_is_ref>: Declare
3409         methods.
3410         (value_as_address, attr_form_is_section_offset)
3411         (attr_form_is_constant, attr_form_is_ref): Don't declare.
3412         * dwarf2/attribute.c (attribute::value_as_address)
3413         (attribute::form_is_section_offset, attribute::form_is_constant)
3414         (attribute::form_is_ref): Now methods.
3415
3416 2020-02-08  Tom Tromey  <tom@tromey.com>
3417
3418         * dwarf2read.c (struct attribute, DW_STRING)
3419         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
3420         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
3421         (attr_form_is_block, attr_form_is_section_offset)
3422         (attr_form_is_constant, attr_form_is_ref): Move.
3423         * dwarf2/attribute.h: New file.
3424         * dwarf2/attribute.c: New file, from dwarf2read.c.
3425         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
3426
3427 2020-02-08  Tom Tromey  <tom@tromey.com>
3428
3429         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
3430         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
3431         Move.
3432         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
3433         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
3434         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
3435         abbrev.c.
3436         * dwarf2/abbrev.h: New file.
3437         * dwarf2/abbrev.c: New file, from dwarf2read.c.
3438         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
3439
3440 2020-02-08  Tom Tromey  <tom@tromey.com>
3441
3442         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
3443         (dwarf2_section_size, dwarf2_get_section_info)
3444         (create_signatured_type_table_from_debug_names)
3445         (create_addrmap_from_aranges, read_debug_names_from_section)
3446         (get_gdb_index_contents_from_section, read_comp_unit_head)
3447         (error_check_comp_unit_head, read_abbrev_offset)
3448         (create_debug_type_hash_table, init_cu_die_reader)
3449         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
3450         (read_comp_units_from_section, create_cus_hash_table)
3451         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
3452         (create_dwp_v2_section, dwarf2_rnglists_process)
3453         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
3454         (abbrev_table_read_table, read_indirect_string_at_offset_from)
3455         (read_indirect_string_from_dwz, read_addr_index_1)
3456         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
3457         (dwarf_decode_macro_bytes, dwarf_decode_macros)
3458         (fill_in_loclist_baton): Update.
3459         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
3460         get_containing_section, get_bfd_owner, get_bfd_section,
3461         get_file_name, get_id, get_flags, empty, read>: Declare methods.
3462         (dwarf2_read_section, get_section_name, get_section_file_name)
3463         (get_containing_section, get_section_bfd_owner)
3464         (get_section_bfd_section, get_section_name, get_section_file_name)
3465         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
3466         declare.
3467         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
3468         (dwarf2_section_info::get_bfd_owner)
3469         (dwarf2_section_info::get_bfd_section)
3470         (dwarf2_section_info::get_name)
3471         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
3472         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
3473         (dwarf2_section_info::read): Now methods.
3474         * dwarf-index-write.c (class debug_names): Update.
3475
3476 2020-02-08  Tom Tromey  <tom@tromey.com>
3477
3478         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
3479         Move to dwarf2/section.h.
3480         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
3481         (get_section_bfd_section, get_section_name)
3482         (get_section_file_name, get_section_id, get_section_flags)
3483         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
3484         dwarf2/section.c.
3485         * dwarf2/section.h: New file.
3486         * dwarf2/section.c: New file, from dwarf2read.c.
3487         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
3488
3489 2020-02-08  Tom Tromey  <tom@tromey.com>
3490
3491         * dwarf2read.h (read_unsigned_leb128): Don't declare.
3492         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
3493         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
3494         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
3495         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
3496         * dwarf2/leb.h: New file, from dwarf2read.c.
3497         * dwarf2/leb.c: New file, from dwarf2read.c.
3498         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
3499         Remove.
3500         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
3501         (COMMON_SFILES): Add dwarf2/leb.c.
3502
3503 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
3504
3505         GDB 9.1 released.
3506
3507 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
3508
3509         PR gdb/25190:
3510         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
3511         * gdb/remote.c (remote_console_output): Update.
3512         * gdb/ui-file.c (fputs_unfiltered): Rename to...
3513         (ui_file_puts): ...this.
3514         * gdb/ui-file.h (ui_file_puts): Add declaration.
3515         * gdb/utils.c (emit_style_escape): Update.
3516         (flush_wrap_buffer): Update.
3517         (fputs_maybe_filtered): Update.
3518         (fputs_unfiltered): Add function.
3519
3520 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
3521
3522         * gdb/event-loop.c (gdb_wait_for_event): Update.
3523         * gdb/printcmd.c (printf_command): Update.
3524         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
3525         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
3526         (gdb_os_flush_stderr): Update.
3527         * gdb/remote.c (remote_console_output): Update.
3528         * gdb/ui-file.c (gdb_flush): Rename to...
3529         (ui_file_flush): ...this.
3530         (stderr_file::write): Update.
3531         (stderr_file::puts): Update.
3532         * gdb/ui-file.h (gdb_flush): Rename to...
3533         (ui_file_flush): ...this.
3534         * gdb/utils.c (gdb_flush): Add function.
3535         * gdb/utils.h (gdb_flush): Add declaration.
3536
3537 2020-02-07  Tom Tromey  <tromey@adacore.com>
3538
3539         PR breakpoints/24915:
3540         * source.c (find_and_open_source): Do not check basenames_may_differ.
3541
3542 2020-02-07  Tom Tromey  <tom@tromey.com>
3543
3544         * README: Update gdbserver documentation.
3545         * gdbserver: Move to top level.
3546         * configure.tgt (build_gdbserver): Remove.
3547         * configure.ac: Remove --enable-gdbserver.
3548         * configure: Rebuild.
3549         * Makefile.in (distclean): Don't mention gdbserver.
3550
3551 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
3552
3553         * source-cache.c (source_cache::ensure): Surround
3554         get_plain_source_lines with a try/catch.
3555         (source_cache::get_line_charpos): Get rid of try/catch
3556         and only check for the return value of "ensure".
3557         * tui/tui-source.c (tui_source_window::set_contents):
3558         Simplify "nlines" calculation.
3559
3560 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
3561
3562         * MAINTAINERS (Write After Approval): Add myself.
3563
3564 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
3565
3566         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
3567         function call.
3568
3569 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
3570
3571         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
3572
3573 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
3574
3575         * nat/riscv-linux-tdesc.h: New file.
3576         * nat/riscv-linux-tdesc.c: New file, taking code from...
3577         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
3578         ... here.
3579         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
3580         NATDEPFILES.
3581
3582 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
3583
3584         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
3585         we don't set the fake simulator ptid to the null_ptid.
3586
3587 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
3588
3589         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
3590         * gdbthread.h (class thread_info) <resumed>: Likewise.
3591         * infrun.c (resume_1): Likewise.
3592         (proceed): Likewise.
3593         (infrun_thread_stop_requested): Likewise.
3594         (stop_all_threads): Likewise.
3595         (handle_inferior_event): Likewise.
3596         (restart_threads): Likewise.
3597         (finish_step_over): Likewise.
3598         (keep_going_stepped_thread): Likewise.
3599         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
3600         (linux_handle_extended_wait): Likewise.
3601         * record-btrace.c (get_thread_current_frame_id): Likewise.
3602         * record-full.c (record_full_wait_1): Likewise.
3603         * remote.c (remote_target::process_initial_stop_replies): Likewise.
3604         * target.c (target_resume): Likewise.
3605         * thread.c (set_running_thread): Likewise.
3606
3607 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
3608
3609         * f-valprint.c (f77_print_array_1): Changed datatype of index
3610         variable to LONGEST from int to enable it to contain bound
3611         values correctly.
3612
3613 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
3614
3615         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
3616         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
3617         offsets according to FLEN determined.
3618         (riscv_linux_nat_target::read_description): Determine FLEN
3619         dynamically.
3620         (riscv_linux_nat_target::fetch_registers): Size regset buffer
3621         according to FLEN determined.
3622         (riscv_linux_nat_target::store_registers): Likewise.
3623
3624 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
3625
3626         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
3627         when reg->group is empty and reggroup is not.
3628
3629 2020-01-31  Tom Tromey  <tromey@adacore.com>
3630
3631         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
3632         Call beneath target's mourn_inferior after unpushing.
3633
3634 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
3635
3636         PR tui/9765
3637         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
3638         have enough lines to fill the screen, still return the lowest
3639         address we found.
3640
3641 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
3642
3643         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
3644         '-', '<', and '>' commands.
3645
3646 2020-01-29  Pedro Alves  <palves@redhat.com>
3647             Sergio Durigan Junior  <sergiodj@redhat.com>
3648
3649         * infcmd.c (construct_inferior_arguments): Assert that
3650         'argc' is greater than 0.
3651
3652 2020-01-29  Luis Machado  <luis.machado@linaro.org>
3653
3654         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
3655         (BRK_INSN_MASK): Define to 0xd4200000.
3656         (aarch64_program_breakpoint_here_p): New function.
3657         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
3658         * arch-utils.c (default_program_breakpoint_here_p): Moved from
3659         breakpoint.c.
3660         * arch-utils.h (default_program_breakpoint_here_p): Moved from
3661         breakpoint.h
3662         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
3663         call gdbarch_program_breakpoint_here_p.
3664         (program_breakpoint_here): Moved to arch-utils.c, renamed to
3665         default_program_breakpoint_here_p, changed return type to bool and
3666         simplified.
3667         * breakpoint.h (program_breakpoint_here): Moved prototype to
3668         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
3669         return type to bool.
3670         * gdbarch.c: Regenerate.
3671         * gdbarch.h: Regenerate.
3672         * gdbarch.sh (program_breakpoint_here_p): New method.
3673         * infrun.c (handle_signal_stop): Call
3674         gdbarch_program_breakpoint_here_p.
3675
3676 2020-01-26  Tom Tromey  <tom@tromey.com>
3677
3678         * ctfread.c (struct ctf_fp_info): Reindent.
3679         (_initialize_ctfread): Remove.
3680
3681 2020-01-26  Tom Tromey  <tom@tromey.com>
3682
3683         * psymtab.c (partial_map_expand_apply)
3684         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
3685         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
3686         (psym_print_stats, psym_expand_symtabs_for_function)
3687         (psym_map_symbol_filenames, psym_map_matching_symbols)
3688         (psym_expand_symtabs_matching)
3689         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
3690         (maintenance_check_psymtabs): Use new methods.
3691         * psympriv.h (struct partial_symtab) <readin_p,
3692         get_compunit_symtab>: New methods.
3693         <readin, compunit_symtab>: Remove members.
3694         (struct standard_psymtab): New.
3695         (struct legacy_psymtab): Derive from standard_psymtab.
3696         * dwarf2read.h (struct dwarf2_psymtab): Derive from
3697         standard_psymtab.
3698         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
3699
3700 2020-01-26  Tom Tromey  <tom@tromey.com>
3701
3702         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
3703         read_dependencies.  Add assert.
3704         * psymtab.c (partial_symtab::read_dependencies): New method.
3705         * psympriv.h (struct partial_symtab) <read_dependencies>: New
3706         method.
3707         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
3708         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
3709         read_dependencies.
3710         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
3711         Add assert.
3712
3713 2020-01-26  Tom Tromey  <tom@tromey.com>
3714
3715         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
3716         Call expand_psymtab.
3717         (xcoff_read_symtab): Call expand_psymtab.
3718         (xcoff_start_psymtab, xcoff_end_psymtab): Set
3719         legacy_expand_psymtab.
3720         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
3721         method.
3722         (struct legacy_psymtab) <expand_psymtab>: Implement.
3723         <legacy_expand_psymtab>: New member.
3724         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
3725         (parse_partial_symbols): Set legacy_expand_psymtab.
3726         (psymtab_to_symtab_1): Change argument order.  Call
3727         expand_psymtab.
3728         (new_psymtab): Set legacy_expand_psymtab.
3729         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
3730         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
3731         expand_psymtab.
3732         (dwarf2_psymtab::expand_psymtab): Rename from
3733         psymtab_to_symtab_1.  Call expand_psymtab.
3734         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
3735         (dbx_end_psymtab): Likewise.
3736         (dbx_psymtab_to_symtab_1): Change argument order. Call
3737         expand_psymtab.
3738         (dbx_read_symtab): Call expand_psymtab.
3739         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
3740         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
3741         (ctf_psymtab::read_symtab): Call expand_psymtab.
3742
3743 2020-01-26  Tom Tromey  <tom@tromey.com>
3744
3745         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
3746         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
3747         messages.
3748         * mdebugread.c (mdebug_read_symtab): Remove prints.
3749         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
3750         assert.
3751         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
3752
3753 2020-01-26  Tom Tromey  <tom@tromey.com>
3754
3755         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
3756         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
3757         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
3758         legacy_symtab.
3759         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
3760         * psymtab.c (psymtab_to_symtab): Call method.
3761         (dump_psymtab): Update.
3762         * psympriv.h (struct partial_symtab): Add virtual destructor.
3763         <read_symtab>: New method.
3764         (struct legacy_symtab): New.
3765         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
3766         (struct pst_map) <pst>: Now a legacy_psymtab.
3767         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
3768         (new_psymtab): Use legacy_psymtab.
3769         * dwarf2read.h (struct dwarf2_psymtab): New.
3770         (struct dwarf2_per_cu_data) <psymtab>: Use it.
3771         * dwarf2read.c (dwarf2_create_include_psymtab)
3772         (dwarf2_build_include_psymtabs, create_type_unit_group)
3773         (create_partial_symtab, process_psymtab_comp_unit_reader)
3774         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
3775         (set_partial_user): Use dwarf2_psymtab.
3776         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
3777         (psymtab_to_symtab_1, process_full_comp_unit)
3778         (process_full_type_unit, dwarf2_ranges_read)
3779         (dwarf2_get_pc_bounds, psymtab_include_file_name)
3780         (dwarf_decode_lines): Use dwarf2_psymtab.
3781         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
3782         (add_address_entry_worker, write_one_signatured_type)
3783         (recursively_count_psymbols, recursively_write_psymbols)
3784         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
3785         (write_debug_names): Likewise.
3786         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
3787         <pst>: Now a legacy_psymtab.
3788         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
3789         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
3790         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
3791         * ctfread.c (struct ctf_psymtab): New.
3792         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
3793         ctf_psymtab.
3794         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
3795         (create_partial_symtab): Return a ctf_psymtab.
3796         (scan_partial_symbols): Update.
3797
3798 2020-01-26  Tom Tromey  <tom@tromey.com>
3799
3800         * xcoffread.c (xcoff_start_psymtab): Use new.
3801         * psymtab.c (partial_symtab::partial_symtab): New constructor,
3802         renamed from start_psymtab_common.
3803         * psympriv.h (struct partial_symtab): Add new constructor.
3804         (start_psymtab_common): Don't declare.
3805         * mdebugread.c (parse_partial_symbols): Use new.
3806         * dwarf2read.c (create_partial_symtab): Use new.
3807         * dbxread.c (start_psymtab): Use new.
3808         * ctfread.c (create_partial_symtab): Use new.
3809
3810 2020-01-26  Tom Tromey  <tom@tromey.com>
3811
3812         * xcoffread.c (xcoff_end_psymtab): Use new.
3813         * psymtab.c (start_psymtab_common): Use new.
3814         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
3815         Update.
3816         * psympriv.h (struct partial_symtab): Add parameters to
3817         constructor.  Don't inline.
3818         (allocate_psymtab): Don't declare.
3819         * mdebugread.c (new_psymtab): Use new.
3820         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
3821         * dbxread.c (dbx_end_psymtab): Use new.
3822
3823 2020-01-26  Tom Tromey  <tom@tromey.com>
3824
3825         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
3826         allocate_psymtab.  Update documentation.
3827         * psymtab.c (psymtab_storage::install_psymtab): Rename from
3828         allocate_psymtab.  Do not use new.
3829         (allocate_psymtab): Use new.  Update.
3830
3831 2020-01-26  Tom Tromey  <tom@tromey.com>
3832
3833         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
3834         * psymtab.c (psym_print_stats): Update.
3835         * psympriv.h (struct partial_symtab) <readin,
3836         psymtabs_addrmap_supported, anonymous>: Now bool.
3837         * mdebugread.c (psymtab_to_symtab_1): Update.
3838         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
3839         (build_type_psymtabs_reader, psymtab_to_symtab_1)
3840         (process_full_comp_unit, process_full_type_unit): Update.
3841         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
3842         * ctfread.c (psymtab_to_symtab): Update.
3843
3844 2020-01-26  Tom Tromey  <tom@tromey.com>
3845
3846         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
3847         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
3848         * psymtab.c (psymtab_storage): Delete psymtabs.
3849         (psymtab_storage::allocate_psymtab): Use new.
3850         (psymtab_storage::discard_psymtab): Use delete.
3851         * psympriv.h (struct partial_symtab): Add constructor and
3852         initializers.
3853
3854 2020-01-26  Tom Tromey  <tom@tromey.com>
3855
3856         * machoread.c: Do not include psympriv.h.
3857
3858 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3859
3860         * NEWS: Mention the new option and the set/show commands.
3861
3862 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3863
3864         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
3865         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
3866         (validate_exec_file): New variables, enums, functions.
3867         (exec_file_locate_attach, print_section_info): Style the filenames.
3868         (_initialize_exec): Install show_exec_file_mismatch_command and
3869          set_exec_file_mismatch_command.
3870         * gdbcore.h (validate_exec_file): Declare.
3871         * infcmd.c (attach_command): Call validate_exec_file.
3872         * remote.c ( remote_target::remote_add_inferior): Likewise.
3873
3874 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3875
3876         * frame.c (find_frame_sal): Move call to get_next_frame into more
3877         inner scope.
3878         * inline-frame.c (inilne_state) <inline_state>: Update argument
3879         types.
3880         (inilne_state) <skipped_symbol>: Rename to...
3881         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
3882         (skip_inline_frames): Build vector of skipped symbols and use this
3883         to reate the inline_state.
3884         (inline_skipped_symbol): Add a comment and some assertions, fetch
3885         skipped symbol from the list.
3886
3887 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3888
3889         * buildsym.c (lte_is_less_than): Delete.
3890         (buildsym_compunit::end_symtab_with_blockvector): Create local
3891         lambda function to sort line table entries, and use
3892         std::stable_sort instead of std::sort.
3893         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
3894         markers when looking for a previous line.
3895
3896 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3897
3898         * dwarf2read.c (lnp_state_machine::record_line): Include
3899         end_sequence parameter in debug print out.  Record the line if we
3900         are at an end_sequence marker even if it's not the start of a
3901         statement.
3902         * symmisc.c (maintenance_print_one_line_table): Print end of
3903         sequence markers with 'END' not '0'.
3904
3905 2020-01-24  Pedro Alves  <palves@redhat.com>
3906
3907         PR gdb/25410
3908         * thread.c (scoped_restore_current_thread::restore): Use
3909         switch_to_inferior_no_thread.
3910         * exec.c: Include "progspace-and-thread.h".
3911         (add_target_sections, remove_target_sections):
3912         scoped_restore_current_pspace_and_thread instead of
3913         scoped_restore_current_thread.
3914         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
3915         and aspace to the inferior before calling clone_program_space.
3916         Remove stale comment.
3917
3918 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
3919
3920         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
3921         (arm_netbsd_nat_target::fetch_registers): ...this.
3922         (arm_nbsd_nat_target::store_registers): Rename to...
3923         (arm_netbsd_nat_target::store_registers): ...this.
3924
3925 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
3926
3927         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
3928         register_t.
3929
3930 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
3931
3932         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
3933         Update comment.
3934         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
3935         Likewise.
3936         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
3937         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
3938         the correct replacement (iterate_over_regset_sections).
3939         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
3940         Update comment.
3941
3942 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
3943
3944         PR gdb/23718
3945         * gdb/python/python.c (execute_gdb_command): Call
3946         async_enable_stdin in catch block.
3947
3948 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3949
3950         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
3951         SWITCH_THRU_ALL_UIS.
3952
3953 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3954
3955         PR tui/9765
3956         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
3957         comment, add extra parameter, and update to store previous symbol
3958         when appropriate.
3959         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
3960         add extra parameter.
3961         * tui/tui-disasm.c (tui_disassemble): Update header comment,
3962         remove unneeded parameter, add try/catch around gdb_print_insn,
3963         rewrite to add items to asm_lines vector.
3964         (tui_find_backward_disassembly_start_address): New function.
3965         (tui_find_disassembly_address): Updated throughout.
3966         (tui_disasm_window::set_contents): Update for changes to
3967         tui_disassemble.
3968         (tui_disasm_window::do_scroll_vertical): No need to adjust the
3969         number of lines to scroll.
3970
3971 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
3972
3973         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
3974         (SECT_OFF_DATA): Likewise.
3975         (SECT_OFF_RODATA): Likewise.
3976         (SECT_OFF_TEXT): Likewise.
3977         (SECT_OFF_BSS): Likewise.
3978         (struct objfile) <text_section_offset, data_section_offset>: New
3979         methods.
3980         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
3981         objfile::text_section_offset.
3982         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
3983         * coffread.c (coff_symtab_read): Likewise.
3984         (enter_linenos): Likewise.
3985         (process_coff_symbol): Likewise.
3986         * ctfread.c (get_objfile_text_range): Likewise.
3987         * dtrace-probe.c (dtrace_probe::get_relocated_address):
3988         Use objfile::data_section_offset.
3989         * dwarf2-frame.c (execute_cfa_program): Use
3990         objfile::text_section_offset.
3991         (dwarf2_frame_find_fde): Likewise.
3992         * dwarf2read.c (create_addrmap_from_index): Likewise.
3993         (create_addrmap_from_aranges): Likewise.
3994         (dw2_find_pc_sect_compunit_symtab): Likewise.
3995         (process_psymtab_comp_unit_reader): Likewise.
3996         (add_partial_symbol): Likewise.
3997         (add_partial_subprogram): Likewise.
3998         (process_full_comp_unit): Likewise.
3999         (read_file_scope): Likewise.
4000         (read_func_scope): Likewise.
4001         (read_lexical_block_scope): Likewise.
4002         (read_call_site_scope): Likewise.
4003         (dwarf2_rnglists_process): Likewise.
4004         (dwarf2_ranges_process): Likewise.
4005         (dwarf2_ranges_read): Likewise.
4006         (dwarf_decode_lines_1): Likewise.
4007         (new_symbol): Likewise.
4008         (dwarf2_fetch_die_loc_sect_off): Likewise.
4009         (dwarf2_per_cu_text_offset): Likewise.
4010         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
4011         * hppa-tdep.c (read_unwind_info): Likewise.
4012         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
4013         * psympriv.h (struct partial_symtab): Likewise.
4014         * psymtab.c (find_pc_sect_psymtab): Likewise.
4015         * solib-svr4.c (enable_break): Likewise.
4016         * stap-probe.c (relocate_address): Use
4017         objfile::data_section_offset.
4018         * xcoffread.c (enter_line_range): Use
4019         objfile::text_section_offset.
4020         (read_xcoff_symtab): Likewise.
4021
4022 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
4023
4024         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
4025         declaration to narrower scopes.
4026
4027 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
4028
4029         * darwin-nat.h (struct darwin_exception_msg, enum
4030         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
4031         Move up.
4032         (class darwin_nat_target) <wait_1, check_new_threads,
4033         decode_exception_message, decode_message, stop_inferior,
4034         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
4035         * darwin-nat.c (darwin_check_new_threads): Rename to...
4036         (darwin_nat_target::check_new_threads): ... this.
4037         (darwin_suspend_inferior_it): Remove.
4038         (darwin_decode_exception_message): Rename to...
4039         (darwin_nat_target::decode_exception_message): ... this.
4040         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
4041         (darwin_decode_message): Rename to...
4042         (darwin_nat_target::decode_message): ... this.
4043         (cancel_breakpoint): Rename to...
4044         (darwin_nat_target::cancel_breakpoint): ... this.
4045         (darwin_wait): Rename to...
4046         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
4047         instead of iterate_over_inferiors.
4048         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
4049         (darwin_stop_inferior): Rename to...
4050         (darwin_nat_target::stop_inferior): ... this.
4051         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
4052         (darwin_init_thread_list): Rename to...
4053         (darwin_nat_target::init_thread_list): ... this.
4054         (darwin_ptrace_him): Rename to...
4055         (darwin_nat_target::ptrace_him): ... this.
4056         (darwin_nat_target::create_inferior): Pass lambda function to
4057         fork_inferior.
4058         (darwin_nat_target::detach): Call stop_inferior instead of
4059         darwin_stop_inferior.
4060         * fork-inferior.h (fork_inferior): Change init_trace_fun
4061         parameter to gdb::function_view.
4062         * fork-inferior.c (fork_inferior): Likewise.
4063
4064 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
4065
4066         * i386-cygwin-tdep.c (core_process_module_section): Update.
4067         * windows-nat.c (struct lm_info_windows): Add text_offset.
4068         (windows_xfer_shared_libraries): Update.
4069         * windows-tdep.c (windows_xfer_shared_library):
4070         Add text_offset_cached argument.
4071         * windows-tdep.h (windows_xfer_shared_library): Update.
4072
4073 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
4074
4075         * gdbarch.sh: Add declaration for _initialize_gdbarch.
4076
4077 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
4078
4079         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
4080         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
4081         replace with range-based for.
4082         (gdbsim_interrupt_inferior): Remove.
4083         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
4084         with a range-based for.  Inline code from
4085         gdbsim_interrupt_inferior.
4086
4087 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
4088
4089         * infrun.c (proceed): Fix indentation.
4090
4091 2020-01-21  Tom Tromey  <tromey@adacore.com>
4092
4093         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
4094         * python/python.c (python_extension_ops): Update.
4095         (gdbpy_colorize): New function.
4096         * python/lib/gdb/__init__.py (colorize): New function.
4097         * extension.h (ext_lang_colorize): Declare.
4098         * extension.c (ext_lang_colorize): New function.
4099         * extension-priv.h (struct extension_language_ops) <colorize>: New
4100         member.
4101         * cli/cli-style.c (_initialize_cli_style): Update help text.
4102
4103 2020-01-21  Luis Machado  <luis.machado@linaro.org>
4104
4105         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
4106         <cond>: Change type to bool.
4107         (aarch64_displaced_step_b_cond): Update cond to use bool type.
4108         (aarch64_displaced_step_cb): Likewise.
4109         (aarch64_displaced_step_tb): Likewise.
4110
4111 2020-01-21  Luis Machado  <luis.machado@linaro.org>
4112
4113         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
4114         output.
4115
4116 2020-01-21  Luis Machado  <luis.machado@linaro.org>
4117
4118         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
4119         <pc_adjust>: Adjust the documentation.
4120         (aarch64_displaced_step_fixup): Check if PC really moved before
4121         adjusting it.
4122
4123 2020-01-19  Tom Tromey  <tom@tromey.com>
4124
4125         * disasm.c (~gdb_disassembler): New destructor.
4126         (gdb_buffered_insn_length): Call disassemble_free_target.
4127         * disasm.h (class gdb_disassembler): Declare destructor.  Use
4128         DISABLE_COPY_AND_ASSIGN.
4129
4130 2020-01-19  Tom Tromey  <tom@tromey.com>
4131
4132         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
4133         (die_reader_func_ftype): Remove.
4134         (cutu_reader): New class.
4135         (dw2_get_file_names_reader): Remove "data" parameter.
4136         (dw2_get_file_names): Use cutu_reader.
4137         (create_debug_type_hash_table): Update.
4138         (read_cutu_die_from_dwo): Update comment.
4139         (lookup_dwo_unit): Add dwo_name parameter.
4140         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
4141         die_reader_func_ftype and data parameters.
4142         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
4143         Remove die_reader_func_ftype and data parameters.
4144         (~cutu_reader): New; from init_cutu_and_read_dies.
4145         (cutu_reader::cutu_reader): Rename from
4146         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
4147         and data parameters.
4148         (init_cutu_and_read_dies_simple): Remove.
4149         (struct process_psymtab_comp_unit_data): Remove.
4150         (process_psymtab_comp_unit_reader): Remove data parameter; add
4151         want_partial_unit and pretend_language parameters.
4152         (process_psymtab_comp_unit): Use cutu_reader.
4153         (build_type_psymtabs_reader): Remove data parameter.
4154         (build_type_psymtabs_1): Use cutu_reader.
4155         (process_skeletonless_type_unit): Likewise.
4156         (load_partial_comp_unit_reader): Remove.
4157         (load_partial_comp_unit): Use cutu_reader.
4158         (load_full_comp_unit_reader): Remove.
4159         (load_full_comp_unit): Use cutu_reader.
4160         (struct create_dwo_cu_data): Remove.
4161         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
4162         dwo_unit parameters.
4163         (create_cus_hash_table): Use cutu_reader.
4164         (struct dwarf2_read_addr_index_data): Remove.
4165         (dwarf2_read_addr_index_reader): Remove.
4166         (dwarf2_read_addr_index): Use cutu_reader.
4167         (read_signatured_type_reader): Remove.
4168         (read_signatured_type): Use cutu_reader.
4169
4170 2020-01-19  Tom Tromey  <tom@tromey.com>
4171
4172         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
4173         * tui/tui-wingeneral.h (class tui_suppress_output): New.
4174         (tui_wrefresh): Declare.
4175         * tui/tui-wingeneral.c (suppress_output): New global.
4176         (tui_suppress_output, ~tui_suppress_output): New constructor and
4177         destructor.
4178         (tui_wrefresh): New function.
4179         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
4180         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
4181         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
4182         method.
4183         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
4184         tui_wrefresh.
4185         (tui_data_window::no_refresh): New method.
4186         (tui_data_item_window::refresh_window): Call tui_wrefresh.
4187         (tui_reg_command): Use tui_suppress_output
4188         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
4189         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
4190         method.
4191         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
4192
4193 2020-01-19  Tom Tromey  <tom@tromey.com>
4194
4195         * tui/tui-winsource.c (tui_update_source_windows_with_line):
4196         Handle case where symtab is null.
4197
4198 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
4199
4200         * linux-fork.c (one_fork_p): Simplify.
4201
4202 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
4203
4204         * top.c (struct qt_args): Remove.
4205         (kill_or_detach): Change return type to void, replace `void *`
4206         parameter with a proper one.
4207         (print_inferior_quit_action):  Likewise.
4208         (quit_confirm): Use range-based for loop to iterate over inferiors.
4209         (quit_force): Likewise.
4210
4211 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
4212
4213         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
4214         `void *` parameter with proper parameters.
4215         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
4216         (print_one_inferior): Change return type to void, replace `void *`
4217         parameter with proper parameters.
4218         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
4219         inferiors.
4220         (get_other_inferior): Remove.
4221         (mi_cmd_remove_inferior): Use range-based loop to iterate over
4222         inferiors.
4223
4224 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
4225
4226         * mi/mi-interp.c (report_initial_inferior): Remove.
4227         (mi_interp::init): Use range-based for to iterate over inferiors.
4228
4229 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
4230
4231         * python/py-inferior.c (build_inferior_list): Remove.
4232         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
4233
4234 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
4235
4236         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
4237         (btrace_stitch_trace): Likewise.
4238         * charset.c (intermediate_encoding): Likewise (vaild).
4239         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
4240         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
4241         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
4242
4243 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
4244
4245         * windows-tdep.c (windows_get_tlb_type):
4246         Add rtl_user_process_parameters type.
4247
4248 2020-01-16  Pedro Alves  <palves@redhat.com>
4249             Norbert Lange  <nolange79@gmail.com>
4250
4251         PR build/24805
4252         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
4253         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
4254         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
4255         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
4256         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
4257         (ps_plog): Redeclare exported functions with default visibility.
4258
4259 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
4260
4261         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
4262         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
4263
4264 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
4265
4266         * infcmd.c (post_create_inferior): Use get_thread_regcache
4267         instead of get_current_regcache.
4268
4269 2020-01-14  Tom Tromey  <tom@tromey.com>
4270
4271         PR symtab/12535:
4272         * python/python.c (gdbpy_decode_line): Treat empty string the same
4273         as no argument.
4274
4275 2020-01-14  Tom Tromey  <tom@tromey.com>
4276
4277         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
4278
4279 2020-01-14  Tom Tromey  <tom@tromey.com>
4280
4281         * nat/linux-btrace.c: Don't include <config.h>.
4282         * nat/linux-ptrace.c: Don't include <config.h>.
4283         * nat/x86-linux-dregs.c: Don't include <config.h>.
4284
4285 2020-01-14  Tom Tromey  <tom@tromey.com>
4286
4287         * configure: Rebuild.
4288         * configure.ac: Move many checks to ../gdbsupport/common.m4.
4289
4290 2020-01-14  Tom Tromey  <tom@tromey.com>
4291
4292         * nat/x86-linux-dregs.c: Include configh.h.
4293         * nat/linux-ptrace.c: Include configh.h.
4294         * nat/linux-btrace.c: Include configh.h.
4295         * defs.h: Include config.h, bfd.h.
4296         * configure.ac: Don't source common.host.
4297         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
4298         * configure: Rebuild.
4299         * acinclude.m4: Update path.
4300         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
4301         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
4302         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
4303         (CLIBS): Add LIBSUPPORT.
4304         (CDEPS): Likewise.
4305         (COMMON_SFILES): Remove gdbsupport files.
4306         (HFILES_NO_SRCDIR): Likewise.
4307         (stamp-version): Update path to create-version.sh.
4308         (ALLDEPFILES): Remove gdbsupport files.
4309
4310 2020-01-14  Tom Tromey  <tom@tromey.com>
4311
4312         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
4313         USE_WIN32API when needed.
4314         * configure.ac (USE_WIN32API): Don't define.
4315         (WIN32LIBS): Use WIN32APILIBS.
4316         * configure: Rebuild.
4317
4318 2020-01-14  Tom Tromey  <tom@tromey.com>
4319
4320         * configure: Rebuild.
4321         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
4322
4323 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4324
4325         * skip.c (skip_function_command): Make skip w/o arguments use the
4326         name of the inlined function if pc is inside any inlined function.
4327
4328 2020-01-14  Luis Machado  <luis.machado@linaro.org>
4329
4330         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
4331         * infrun.c (resume_1): Likewise.
4332         (handle_inferior_event): Remove stale comment.
4333         * linux-nat.c (linux_nat_target::resume): Update comments.
4334         (save_stop_reason): Likewise.
4335         (linux_nat_filter_event): Likewise.
4336         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
4337
4338 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4339
4340         * elfread.c (record_minimal_symbol): Set section index to 0 for
4341         non-allocatable sections.
4342
4343
4344 2020-01-13  Ali Tamur <tamur@google.com>
4345
4346         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
4347         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
4348         to gdb::optional.  Update comments.
4349         (dwo_file): Update comments.
4350         (read_attribute): Update API to take an additional out parameter,
4351         need_reprocess.  This is used to mark attributes that need other
4352         attributes (e.g. str_offsets_base) for correct computation which may not
4353         have been read yet.
4354         (read_attribute_reprocess): New function declaration.
4355         (read_addr_index): Likewise.
4356         (read_dwo_str_index): Likewise.
4357         (read_stub_str_index): Likewise.
4358         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
4359         (lookup_addr_base): New function definition.
4360         (lookup_ranges_base): Likewise.
4361         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
4362         lookup_ranges_base.
4363         (init_cutu_and_read_dies): Update comments.
4364         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
4365         unit.  This is used to inherit parent's str_offsets_base and addr_base.
4366         Update comments.
4367         (init_cutu_and_read_dies_simple): Reflect API changes.
4368         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
4369         (create_cus_hash_table): Change API to take parent compile unit.
4370         Reflect API changes.
4371         (open_and_init_dwo_file): Reflect API changes.
4372         (dwarf2_get_pc_bounds): Update comments.
4373         (dwarf2_record_block_ranges): Likewise.
4374         (read_full_die_1): Change implementation to reprocess attributes that
4375         need str_offsets_base and addr_base.
4376         (partial_die_info::read): Likewise.
4377         (read_attribute_reprocess): New function definition.
4378         (read_attribute_value): Change API to take an additional out parameter,
4379         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
4380         when a non-dwo compile unit has index based attributes.
4381         (read_attribute): Reflect API changes.
4382         (read_addr_index_1): Reflect API changes.  Update comments.
4383         (dwarf2_read_addr_index_data): Reflect API changes.
4384         (dwarf2_read_addr_index): Likewise.
4385         (read_str_index): Change API and implementation.  This becomes a helper
4386         to be used by the new string index related methods.  Update error
4387         message and comments.
4388         (read_dwo_str_index): New function definition.
4389         (read_stub_str_index): Likewise.
4390         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
4391         * symfile.h (dwarf2_debug_sections): Likewise.
4392         * xcoffread.c (dwarf2_debug_sections): Likewise.
4393
4394 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
4395
4396         * gdbcore.h (struct core_fns) <core_read_registers>: Change
4397         core_reg_sect type to gdb_byte *.
4398         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
4399         * cris-tdep.c (fetch_core_registers): Likewise.
4400         * corelow.c (core_target::get_core_register_section): Change
4401         type of `contents` to gdb::byte_vector.
4402
4403 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4404
4405         * tui/tui-wingeneral.c (box_win): Position the title in the center
4406         of the border.
4407
4408 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
4409
4410         * corelow.c (core_target::get_core_register_section): Use
4411           std::vector instead of alloca.
4412
4413 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
4414
4415         * warning.m4: Add -Wmissing-declarations to build_warnings.
4416         * configure: Re-generate.
4417
4418 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
4419
4420         * python/python.c (init__gdb_module): Add declaration.
4421
4422 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
4423
4424         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
4425         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
4426         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
4427         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
4428         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
4429         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
4430         * ada-exp.y (_initialize_ada_exp): Add declaration.
4431         * ada-lang.c (_initialize_ada_language): Add declaration.
4432         * ada-tasks.c (_initialize_tasks): Add declaration.
4433         * agent.c (_initialize_agent): Add declaration.
4434         * aix-thread.c (_initialize_aix_thread): Add declaration.
4435         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
4436         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
4437         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
4438         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
4439         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
4440         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
4441         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
4442         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
4443         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
4444         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
4445         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
4446         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
4447         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
4448         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
4449         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
4450         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
4451         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
4452         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
4453         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
4454         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
4455         * annotate.c (_initialize_annotate): Add declaration.
4456         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
4457         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
4458         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
4459         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
4460         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
4461         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
4462         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
4463         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
4464         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
4465         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
4466         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
4467         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
4468         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
4469         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
4470         * auto-load.c (_initialize_auto_load): Add declaration.
4471         * auxv.c (_initialize_auxv): Add declaration.
4472         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
4473         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
4474         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
4475         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
4476         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
4477         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
4478         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
4479         * breakpoint.c (_initialize_breakpoint): Add declaration.
4480         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
4481         * btrace.c (_initialize_btrace): Add declaration.
4482         * charset.c (_initialize_charset): Add declaration.
4483         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
4484         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
4485         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
4486         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
4487         * cli/cli-script.c (_initialize_cli_script): Add declaration.
4488         * cli/cli-style.c (_initialize_cli_style): Add declaration.
4489         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
4490         * coffread.c (_initialize_coffread): Add declaration.
4491         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
4492         * compile/compile.c (_initialize_compile): Add declaration.
4493         * complaints.c (_initialize_complaints): Add declaration.
4494         * completer.c (_initialize_completer): Add declaration.
4495         * copying.c (_initialize_copying): Add declaration.
4496         * corefile.c (_initialize_core): Add declaration.
4497         * corelow.c (_initialize_corelow): Add declaration.
4498         * cp-abi.c (_initialize_cp_abi): Add declaration.
4499         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
4500         * cp-support.c (_initialize_cp_support): Add declaration.
4501         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
4502         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
4503         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
4504         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
4505         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
4506         * ctfread.c (_initialize_ctfread): Add declaration.
4507         * d-lang.c (_initialize_d_language): Add declaration.
4508         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
4509         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
4510         * dbxread.c (_initialize_dbxread): Add declaration.
4511         * dcache.c (_initialize_dcache): Add declaration.
4512         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
4513         * disasm.c (_initialize_disasm): Add declaration.
4514         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
4515         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
4516         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
4517         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
4518         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
4519         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
4520         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
4521         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
4522         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
4523         * elfread.c (_initialize_elfread): Add declaration.
4524         * exec.c (_initialize_exec): Add declaration.
4525         * extension.c (_initialize_extension): Add declaration.
4526         * f-lang.c (_initialize_f_language): Add declaration.
4527         * f-valprint.c (_initialize_f_valprint): Add declaration.
4528         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
4529         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
4530         * filesystem.c (_initialize_filesystem): Add declaration.
4531         * findcmd.c (_initialize_mem_search): Add declaration.
4532         * findvar.c (_initialize_findvar): Add declaration.
4533         * fork-child.c (_initialize_fork_child): Add declaration.
4534         * frame-base.c (_initialize_frame_base): Add declaration.
4535         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
4536         * frame.c (_initialize_frame): Add declaration.
4537         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
4538         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
4539         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
4540         * gcore.c (_initialize_gcore): Add declaration.
4541         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
4542         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
4543         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
4544         * gdbarch.c (_initialize_gdbarch): Add declaration.
4545         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
4546         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
4547         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
4548         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
4549         * go-lang.c (_initialize_go_language): Add declaration.
4550         * go32-nat.c (_initialize_go32_nat): Add declaration.
4551         * guile/guile.c (_initialize_guile): Add declaration.
4552         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
4553         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
4554         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
4555         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
4556         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
4557         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
4558         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
4559         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
4560         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
4561         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
4562         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
4563         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
4564         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
4565         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
4566         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
4567         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
4568         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
4569         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
4570         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
4571         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
4572         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
4573         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
4574         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
4575         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
4576         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
4577         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
4578         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
4579         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
4580         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
4581         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
4582         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
4583         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
4584         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
4585         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
4586         * infcall.c (_initialize_infcall): Add declaration.
4587         * infcmd.c (_initialize_infcmd): Add declaration.
4588         * inflow.c (_initialize_inflow): Add declaration.
4589         * infrun.c (_initialize_infrun): Add declaration.
4590         * interps.c (_initialize_interpreter): Add declaration.
4591         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
4592         * jit.c (_initialize_jit): Add declaration.
4593         * language.c (_initialize_language): Add declaration.
4594         * linux-fork.c (_initialize_linux_fork): Add declaration.
4595         * linux-nat.c (_initialize_linux_nat): Add declaration.
4596         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
4597         * linux-thread-db.c (_initialize_thread_db): Add declaration.
4598         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
4599         * m2-lang.c (_initialize_m2_language): Add declaration.
4600         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
4601         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
4602         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
4603         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
4604         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
4605         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
4606         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
4607         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
4608         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
4609         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
4610         * machoread.c (_initialize_machoread): Add declaration.
4611         * macrocmd.c (_initialize_macrocmd): Add declaration.
4612         * macroscope.c (_initialize_macroscope): Add declaration.
4613         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
4614         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
4615         * maint.c (_initialize_maint_cmds): Add declaration.
4616         * mdebugread.c (_initialize_mdebugread): Add declaration.
4617         * memattr.c (_initialize_mem): Add declaration.
4618         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
4619         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
4620         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
4621         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
4622         * mi/mi-main.c (_initialize_mi_main): Add declaration.
4623         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
4624         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
4625         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
4626         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
4627         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
4628         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
4629         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
4630         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
4631         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
4632         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
4633         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
4634         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
4635         * mipsread.c (_initialize_mipsread): Add declaration.
4636         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
4637         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
4638         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
4639         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
4640         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
4641         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
4642         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
4643         * nto-procfs.c (_initialize_procfs): Add declaration.
4644         * objc-lang.c (_initialize_objc_language): Add declaration.
4645         * observable.c (_initialize_observer): Add declaration.
4646         * opencl-lang.c (_initialize_opencl_language): Add declaration.
4647         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
4648         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
4649         * osabi.c (_initialize_gdb_osabi): Add declaration.
4650         * osdata.c (_initialize_osdata): Add declaration.
4651         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
4652         * parse.c (_initialize_parse): Add declaration.
4653         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
4654         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
4655         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
4656         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
4657         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
4658         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
4659         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
4660         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
4661         * printcmd.c (_initialize_printcmd): Add declaration.
4662         * probe.c (_initialize_probe): Add declaration.
4663         * proc-api.c (_initialize_proc_api): Add declaration.
4664         * proc-events.c (_initialize_proc_events): Add declaration.
4665         * proc-service.c (_initialize_proc_service): Add declaration.
4666         * procfs.c (_initialize_procfs): Add declaration.
4667         * producer.c (_initialize_producer): Add declaration.
4668         * psymtab.c (_initialize_psymtab): Add declaration.
4669         * python/python.c (_initialize_python): Add declaration.
4670         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
4671         * record-btrace.c (_initialize_record_btrace): Add declaration.
4672         * record-full.c (_initialize_record_full): Add declaration.
4673         * record.c (_initialize_record): Add declaration.
4674         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
4675         * regcache.c (_initialize_regcache): Add declaration.
4676         * reggroups.c (_initialize_reggroup): Add declaration.
4677         * remote-notif.c (_initialize_notif): Add declaration.
4678         * remote-sim.c (_initialize_remote_sim): Add declaration.
4679         * remote.c (_initialize_remote): Add declaration.
4680         * reverse.c (_initialize_reverse): Add declaration.
4681         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
4682         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
4683         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
4684         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
4685         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
4686         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
4687         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
4688         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
4689         Add declaration.
4690         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
4691         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
4692         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
4693         * rust-exp.y (_initialize_rust_exp): Add declaration.
4694         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
4695         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
4696         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
4697         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
4698         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
4699         * score-tdep.c (_initialize_score_tdep): Add declaration.
4700         * ser-go32.c (_initialize_ser_dos): Add declaration.
4701         * ser-mingw.c (_initialize_ser_windows): Add declaration.
4702         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
4703         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
4704         * ser-uds.c (_initialize_ser_socket): Add declaration.
4705         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
4706         * serial.c (_initialize_serial): Add declaration.
4707         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
4708         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
4709         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
4710         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
4711         * skip.c (_initialize_step_skip): Add declaration.
4712         * sol-thread.c (_initialize_sol_thread): Add declaration.
4713         * solib-aix.c (_initialize_solib_aix): Add declaration.
4714         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
4715         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
4716         * solib-frv.c (_initialize_frv_solib): Add declaration.
4717         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
4718         * solib-target.c (_initialize_solib_target): Add declaration.
4719         * solib.c (_initialize_solib): Add declaration.
4720         * source-cache.c (_initialize_source_cache): Add declaration.
4721         * source.c (_initialize_source): Add declaration.
4722         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
4723         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
4724         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
4725         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
4726         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
4727         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
4728         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
4729         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
4730         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
4731         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
4732         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
4733         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
4734         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
4735         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
4736         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
4737         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
4738         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
4739         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
4740         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
4741         * stabsread.c (_initialize_stabsread): Add declaration.
4742         * stack.c (_initialize_stack): Add declaration.
4743         * stap-probe.c (_initialize_stap_probe): Add declaration.
4744         * std-regs.c (_initialize_frame_reg): Add declaration.
4745         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
4746         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
4747         * symfile.c (_initialize_symfile): Add declaration.
4748         * symmisc.c (_initialize_symmisc): Add declaration.
4749         * symtab.c (_initialize_symtab): Add declaration.
4750         * target.c (_initialize_target): Add declaration.
4751         * target-connection.c (_initialize_target_connection): Add
4752         declaration.
4753         * target-dcache.c (_initialize_target_dcache): Add declaration.
4754         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
4755         * thread.c (_initialize_thread): Add declaration.
4756         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
4757         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
4758         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
4759         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
4760         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
4761         * tracectf.c (_initialize_ctf): Add declaration.
4762         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
4763         * tracefile.c (_initialize_tracefile): Add declaration.
4764         * tracepoint.c (_initialize_tracepoint): Add declaration.
4765         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
4766         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
4767         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
4768         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
4769         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
4770         * tui/tui-win.c (_initialize_tui_win): Add declaration.
4771         * tui/tui.c (_initialize_tui): Add declaration.
4772         * typeprint.c (_initialize_typeprint): Add declaration.
4773         * ui-style.c (_initialize_ui_style): Add declaration.
4774         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
4775         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
4776         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
4777         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
4778         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
4779         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
4780         * unittests/filtered_iterator-selftests.c
4781         (_initialize_filtered_iterator_selftests): Add declaration.
4782         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
4783         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
4784         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
4785         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
4786         * unittests/main-thread-selftests.c
4787         (_initialize_main_thread_selftests): Add declaration.
4788         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
4789         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
4790         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
4791         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
4792         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
4793         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
4794         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
4795         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
4796         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
4797         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
4798         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
4799         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
4800         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
4801         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
4802         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
4803         declaration.
4804         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
4805         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
4806         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
4807         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
4808         * user-regs.c (_initialize_user_regs): Add declaration.
4809         * utils.c (_initialize_utils): Add declaration.
4810         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
4811         * valops.c (_initialize_valops): Add declaration.
4812         * valprint.c (_initialize_valprint): Add declaration.
4813         * value.c (_initialize_values): Add declaration.
4814         * varobj.c (_initialize_varobj): Add declaration.
4815         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
4816         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
4817         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
4818         * windows-nat.c (_initialize_windows_nat): Add declaration.
4819         (_initialize_check_for_gdb_ini): Add declaration.
4820         (_initialize_loadable): Add declaration.
4821         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
4822         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
4823         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
4824         * xcoffread.c (_initialize_xcoffread): Add declaration.
4825         * xml-support.c (_initialize_xml_support): Add declaration.
4826         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
4827         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
4828         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
4829         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
4830
4831 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
4832
4833         * regformats/regdat.sh: Generate declaration for init function.
4834
4835 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
4836
4837         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
4838         up.
4839         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
4840         close_one_inferior>: New methods.
4841         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
4842         pass down target to find_inferior_pid.
4843         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
4844         Pass down target to find_inferior_ptid.
4845         (gdbsim_target::create_inferior): Pass down target to
4846         add_thread_silent.
4847         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
4848         target down to find_inferior_ptid and switch_to_thread.
4849         (gdbsim_target::close): Update to call close_one_inferior.
4850         (struct resume_data): Remove.
4851         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
4852         directly, rather than through a void pointer.
4853         (gdbsim_target::resume): Update to call resume_one_inferior.
4854
4855 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
4856
4857         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
4858
4859 2020-01-12  Pedro Alves  <palves@redhat.com>
4860
4861         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
4862         directly for the current inferior instead of
4863         discard_all_inferiors.
4864         (discard_all_inferiors): Delete.
4865
4866 2020-01-11  Tom Tromey  <tom@tromey.com>
4867
4868         * tui/tui-wingeneral.c (box_win): Check cli_styling.
4869         * tui/tui-winsource.c (tui_source_window_base::refill): Use
4870         deprecated_safe_get_selected_frame.
4871
4872 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4873
4874         * inferior.c (print_inferior): Switch inferior before printing it.
4875
4876 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
4877             Pedro Alves  <palves@redhat.com>
4878
4879         * progspace-and-thread.c (switch_to_program_space_and_thread):
4880         Assert there's an inferior for PSPACE.  Use
4881         switch_to_inferior_no_thread to switch the inferior too.
4882         * progspace.c (program_space::~program_space): Call
4883         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
4884         (program_space::free_all_objfiles): Don't call clear_symtab_users
4885         here.
4886         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
4887
4888 2020-01-10  Pedro Alves  <palves@redhat.com>
4889
4890         * NEWS: Mention multi-target debugging, "info connections", and
4891         "add-inferior -no-connection".
4892
4893 2020-01-10  Pedro Alves  <palves@redhat.com>
4894
4895         * infrun.c: Include "target-connection.h".
4896         (check_multi_target_resumption): New.
4897         (proceed): Call it.
4898         * target-connection.c (make_target_connection_string): Make
4899         extern.
4900         * target-connection.h (make_target_connection_string): Declare.
4901
4902 2020-01-10  Pedro Alves  <palves@redhat.com>
4903
4904         * Makefile.in (COMMON_SFILES): Add target-connection.c.
4905         * inferior.c (uiout_field_connection): New function.
4906         (print_inferior): Add new "connection-id" column.
4907         (add_inferior_command): Show connection number/string of added
4908         inferior.
4909         * process-stratum-target.h
4910         (process_stratum_target::connection_string): New virtual method.
4911         (process_stratum_target::connection_number): New field.
4912         * remote.c (remote_target::connection_string): New override.
4913         * target-connection.c: New file.
4914         * target-connection.h: New file.
4915         * target.c (decref_target): Remove process_stratum targets from
4916         the connection list.
4917         (target_stack::push): Add process_stratum targets to the
4918         connection list.
4919
4920 2020-01-10  Pedro Alves  <palves@redhat.com>
4921
4922         Revert:
4923         2016-04-12  Pedro Alves  <palves@redhat.com>
4924         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
4925         Remove references to name.
4926         * serial.h (struct serial) <name>: Delete.
4927
4928 2020-01-10  Pedro Alves  <palves@redhat.com>
4929
4930         * gdbarch-selftests.c (register_to_value_test): Remove "target
4931         already pushed" check.
4932
4933 2020-01-10  Pedro Alves  <palves@redhat.com>
4934             John Baldwin  <jhb@FreeBSD.org>
4935
4936         * aarch64-linux-nat.c
4937         (aarch64_linux_nat_target::thread_architecture): Adjust.
4938         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
4939         (task_command_1): Likewise.
4940         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
4941         (aix_thread_target::wait, aix_thread_target::fetch_registers)
4942         (aix_thread_target::store_registers)
4943         (aix_thread_target::thread_alive): Adjust.
4944         * amd64-fbsd-tdep.c: Include "inferior.h".
4945         (amd64fbsd_get_thread_local_address): Pass down target.
4946         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
4947         thread's gdbarch instead of target_gdbarch.
4948         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
4949         get_last_target_status.
4950         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
4951         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
4952         inferiors.
4953         (update_inserted_breakpoint_locations): Skip if inferiors with no
4954         execution.
4955         (update_global_location_list): When handling moribund locations,
4956         find representative inferior for location's pspace, and use thread
4957         count of its process_stratum target.
4958         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
4959         * bsd-uthread.c (bsd_uthread_target::wait): Use
4960         as_process_stratum_target and adjust thread_change_ptid and
4961         add_thread calls.
4962         (bsd_uthread_target::update_thread_list): Use
4963         as_process_stratum_target and adjust find_thread_ptid,
4964         thread_change_ptid and add_thread calls.
4965         * btrace.c (maint_btrace_packet_history_cmd): Adjust
4966         find_thread_ptid call.
4967         * corelow.c (add_to_thread_list): Adjust add_thread call.
4968         (core_target_open): Adjust add_thread_silent and thread_count
4969         calls.
4970         (core_target::pid_to_str): Adjust find_inferior_ptid call.
4971         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
4972         * event-top.c (async_disconnect): Pop targets from all inferiors.
4973         * exec.c (add_target_sections): Push exec target on all inferiors
4974         sharing the program space.
4975         (remove_target_sections): Remove the exec target from all
4976         inferiors sharing the program space.
4977         (exec_on_vfork): New.
4978         * exec.h (exec_on_vfork): Declare.
4979         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
4980         Pass it down.
4981         (fbsd_nat_target::update_thread_list): Adjust.
4982         (fbsd_nat_target::resume): Adjust.
4983         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
4984         down.
4985         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
4986         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
4987         get_thread_arch_regcache call.
4988         * fork-child.c (gdb_startup_inferior): Pass target down to
4989         startup_inferior and set_executing.
4990         * gdbthread.h (struct process_stratum_target): Forward declare.
4991         (add_thread, add_thread_silent, add_thread_with_info)
4992         (in_thread_list): Add process_stratum_target parameter.
4993         (find_thread_ptid(inferior*, ptid_t)): New overload.
4994         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
4995         parameter.
4996         (all_threads()): Delete overload.
4997         (all_threads, all_non_exited_threads): Add process_stratum_target
4998         parameter.
4999         (all_threads_safe): Use brace initialization.
5000         (thread_count): Add process_stratum_target parameter.
5001         (set_resumed, set_running, set_stop_requested, set_executing)
5002         (threads_are_executing, finish_thread_state): Add
5003         process_stratum_target parameter.
5004         (switch_to_thread): Use is_current_thread.
5005         * i386-fbsd-tdep.c: Include "inferior.h".
5006         (i386fbsd_get_thread_local_address): Pass down target.
5007         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
5008         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
5009         have_inferiors check.
5010         * inf-ptrace.c (inf_ptrace_target::create_inferior)
5011         (inf_ptrace_target::attach): Adjust.
5012         * infcall.c (run_inferior_call): Adjust.
5013         * infcmd.c (run_command_1): Pass target to
5014         scoped_finish_thread_state.
5015         (proceed_thread_callback): Skip inferiors with no execution.
5016         (continue_command): Rename 'all_threads' local to avoid hiding
5017         'all_threads' function.  Adjust get_last_target_status call.
5018         (prepare_one_step): Adjust set_running call.
5019         (signal_command): Use user_visible_resume_target.  Compare thread
5020         pointers instead of inferior_ptid.
5021         (info_program_command): Adjust to pass down target.
5022         (attach_command): Mark target's 'thread_executing' flag.
5023         (stop_current_target_threads_ns): New, factored out from ...
5024         (interrupt_target_1): ... this.  Switch inferior before making
5025         target calls.
5026         * inferior-iter.h
5027         (struct all_inferiors_iterator, struct all_inferiors_range)
5028         (struct all_inferiors_safe_range)
5029         (struct all_non_exited_inferiors_range): Filter on
5030         process_stratum_target too.  Remove explicit.
5031         * inferior.c (inferior::inferior): Push dummy target on target
5032         stack.
5033         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
5034         Add process_stratum_target parameter, and pass it down.
5035         (have_live_inferiors): Adjust.
5036         (switch_to_inferior_and_push_target): New.
5037         (add_inferior_command, clone_inferior_command): Handle
5038         "-no-connection" parameter.  Use
5039         switch_to_inferior_and_push_target.
5040         (_initialize_inferior): Mention "-no-connection" option in
5041         the help of "add-inferior" and "clone-inferior" commands.
5042         * inferior.h: Include "process-stratum-target.h".
5043         (interrupt_target_1): Use bool.
5044         (struct inferior) <push_target, unpush_target, target_is_pushed,
5045         find_target_beneath, top_target, process_target, target_at,
5046         m_stack>: New.
5047         (discard_all_inferiors): Delete.
5048         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
5049         (all_inferiors, all_non_exited_inferiors): Add
5050         process_stratum_target parameter.
5051         * infrun.c: Include "gdb_select.h" and <unordered_map>.
5052         (target_last_proc_target): New global.
5053         (follow_fork_inferior): Push target on new inferior.  Pass target
5054         to add_thread_silent.  Call exec_on_vfork.  Handle target's
5055         reference count.
5056         (follow_fork): Adjust get_last_target_status call.  Also consider
5057         target.
5058         (follow_exec): Push target on new inferior.
5059         (struct execution_control_state) <target>: New field.
5060         (user_visible_resume_target): New.
5061         (do_target_resume): Call target_async.
5062         (resume_1): Set target's threads_executing flag.  Consider resume
5063         target.
5064         (commit_resume_all_targets): New.
5065         (proceed): Also consider resume target.  Skip threads of inferiors
5066         with no execution.  Commit resumtion in all targets.
5067         (start_remote): Pass current inferior to wait_for_inferior.
5068         (infrun_thread_stop_requested): Consider target as well.  Pass
5069         thread_info pointer to clear_inline_frame_state instead of ptid.
5070         (infrun_thread_thread_exit): Consider target as well.
5071         (random_pending_event_thread): New inferior parameter.  Use it.
5072         (do_target_wait): Rename to ...
5073         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
5074         down.
5075         (threads_are_resumed_pending_p, do_target_wait): New.
5076         (prepare_for_detach): Adjust calls.
5077         (wait_for_inferior): New inferior parameter.  Handle it.  Use
5078         do_target_wait_1 instead of do_target_wait.
5079         (fetch_inferior_event): Adjust.  Switch to representative
5080         inferior.  Pass target down.
5081         (set_last_target_status): Add process_stratum_target parameter.
5082         Save target in global.
5083         (get_last_target_status): Add process_stratum_target parameter and
5084         handle it.
5085         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
5086         (context_switch): Check inferior_ptid == null_ptid before calling
5087         inferior_thread().
5088         (get_inferior_stop_soon): Pass down target.
5089         (wait_one): Rename to ...
5090         (poll_one_curr_target): ... this.
5091         (struct wait_one_event): New.
5092         (wait_one): New.
5093         (stop_all_threads): Adjust.
5094         (handle_no_resumed, handle_inferior_event): Adjust to consider the
5095         event's target.
5096         (switch_back_to_stepped_thread): Also consider target.
5097         (print_stop_event): Update.
5098         (normal_stop): Update.  Also consider the resume target.
5099         * infrun.h (wait_for_inferior): Remove declaration.
5100         (user_visible_resume_target): New declaration.
5101         (get_last_target_status, set_last_target_status): New
5102         process_stratum_target parameter.
5103         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
5104         process_stratum_target parameter, and use it.
5105         (clear_inline_frame_state (thread_info*)): New.
5106         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
5107         process_stratum_target parameter.
5108         (clear_inline_frame_state (thread_info*)): Declare.
5109         * linux-fork.c (delete_checkpoint_command): Pass target down to
5110         find_thread_ptid.
5111         (checkpoint_command): Adjust.
5112         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
5113         instead of just tweaking inferior_ptid.
5114         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
5115         (exit_lwp): Pass target down to find_thread_ptid.
5116         (attach_proc_task_lwp_callback): Pass target down to
5117         add_thread/set_running/set_executing.
5118         (linux_nat_target::attach): Pass target down to
5119         thread_change_ptid.
5120         (get_detach_signal): Pass target down to find_thread_ptid.
5121         Consider last target status's target.
5122         (linux_resume_one_lwp_throw, resume_lwp)
5123         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
5124         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
5125         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
5126         (linux_nat_target::async_wait_fd): New.
5127         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
5128         target down.
5129         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
5130         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
5131         * linux-thread-db.c (struct thread_db_info::process_target): New
5132         field.
5133         (add_thread_db_info): Save target.
5134         (get_thread_db_info): New process_stratum_target parameter.  Also
5135         match target.
5136         (delete_thread_db_info): New process_stratum_target parameter.
5137         Also match target.
5138         (thread_from_lwp): Adjust to pass down target.
5139         (thread_db_notice_clone): Pass down target.
5140         (check_thread_db_callback): Pass down target.
5141         (try_thread_db_load_1): Always push the thread_db target.
5142         (try_thread_db_load, record_thread): Pass target down.
5143         (thread_db_target::detach): Pass target down.  Always unpush the
5144         thread_db target.
5145         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
5146         target down.  Always unpush the thread_db target.
5147         (find_new_threads_callback, thread_db_find_new_threads_2)
5148         (thread_db_target::update_thread_list): Pass target down.
5149         (thread_db_target::pid_to_str): Pass current inferior down.
5150         (thread_db_target::get_thread_local_address): Pass target down.
5151         (thread_db_target::resume, maintenance_check_libthread_db): Pass
5152         target down.
5153         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
5154         * procfs.c (procfs_target::procfs_init_inferior): Declare.
5155         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
5156         (procfs_init_inferior): Rename to ...
5157         (procfs_target::procfs_init_inferior): ... this and adjust.
5158         (procfs_target::create_inferior, procfs_notice_thread)
5159         (procfs_do_thread_registers): Adjust.
5160         * ppc-fbsd-tdep.c: Include "inferior.h".
5161         (ppcfbsd_get_thread_local_address): Pass down target.
5162         * proc-service.c (ps_xfer_memory): Switch current inferior and
5163         program space as well.
5164         (get_ps_regcache): Pass target down.
5165         * process-stratum-target.c
5166         (process_stratum_target::thread_address_space)
5167         (process_stratum_target::thread_architecture): Pass target down.
5168         * process-stratum-target.h
5169         (process_stratum_target::threads_executing): New field.
5170         (as_process_stratum_target): New.
5171         * ravenscar-thread.c
5172         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
5173         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
5174         down.
5175         * record-btrace.c (record_btrace_target::info_record): Adjust.
5176         (record_btrace_target::record_method)
5177         (record_btrace_target::record_is_replaying)
5178         (record_btrace_target::fetch_registers)
5179         (get_thread_current_frame_id, record_btrace_target::resume)
5180         (record_btrace_target::wait, record_btrace_target::stop): Pass
5181         target down.
5182         * record-full.c (record_full_wait_1): Switch to event thread.
5183         Pass target down.
5184         * regcache.c (regcache::regcache)
5185         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
5186         process_stratum_target parameter and handle it.
5187         (current_thread_target): New global.
5188         (get_thread_regcache): Add process_stratum_target parameter and
5189         handle it.  Switch inferior before calling target method.
5190         (get_thread_regcache): Pass target down.
5191         (get_thread_regcache_for_ptid): Pass target down.
5192         (registers_changed_ptid): Add process_stratum_target parameter and
5193         handle it.
5194         (registers_changed_thread, registers_changed): Pass target down.
5195         (test_get_thread_arch_aspace_regcache): New.
5196         (current_regcache_test): Define a couple local test_target_ops
5197         instances and use them for testing.
5198         (readwrite_regcache): Pass process_stratum_target parameter.
5199         (cooked_read_test, cooked_write_test): Pass mock_target down.
5200         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
5201         (get_thread_arch_aspace_regcache): Add process_stratum_target
5202         parameter.
5203         (regcache::target): New method.
5204         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
5205         (regcache::registers_changed_ptid): Add process_stratum_target
5206         parameter.
5207         (regcache::m_target): New field.
5208         (registers_changed_ptid): Add process_stratum_target parameter.
5209         * remote.c (remote_state::supports_vCont_probed): New field.
5210         (remote_target::async_wait_fd): New method.
5211         (remote_unpush_and_throw): Add remote_target parameter.
5212         (get_current_remote_target): Adjust.
5213         (remote_target::remote_add_inferior): Push target.
5214         (remote_target::remote_add_thread)
5215         (remote_target::remote_notice_new_inferior)
5216         (get_remote_thread_info): Pass target down.
5217         (remote_target::update_thread_list): Skip threads of inferiors
5218         bound to other targets.  (remote_target::close): Don't discard
5219         inferiors.  (remote_target::add_current_inferior_and_thread)
5220         (remote_target::process_initial_stop_replies)
5221         (remote_target::start_remote)
5222         (remote_target::remote_serial_quit_handler): Pass down target.
5223         (remote_target::remote_unpush_target): New remote_target
5224         parameter.  Unpush the target from all inferiors.
5225         (remote_target::remote_unpush_and_throw): New remote_target
5226         parameter.  Pass it down.
5227         (remote_target::open_1): Check whether the current inferior has
5228         execution instead of checking whether any inferior is live.  Pass
5229         target down.
5230         (remote_target::remote_detach_1): Pass down target.  Use
5231         remote_unpush_target.
5232         (extended_remote_target::attach): Pass down target.
5233         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
5234         (remote_target::append_resumption): Pass down target.
5235         (remote_target::append_pending_thread_resumptions)
5236         (remote_target::remote_resume_with_hc, remote_target::resume)
5237         (remote_target::commit_resume): Pass down target.
5238         (remote_target::remote_stop_ns): Check supports_vCont_probed.
5239         (remote_target::interrupt_query)
5240         (remote_target::remove_new_fork_children)
5241         (remote_target::check_pending_events_prevent_wildcard_vcont)
5242         (remote_target::remote_parse_stop_reply)
5243         (remote_target::process_stop_reply): Pass down target.
5244         (first_remote_resumed_thread): New remote_target parameter.  Pass
5245         it down.
5246         (remote_target::wait_as): Pass down target.
5247         (unpush_and_perror): New remote_target parameter.  Pass it down.
5248         (remote_target::readchar, remote_target::remote_serial_write)
5249         (remote_target::getpkt_or_notif_sane_1)
5250         (remote_target::kill_new_fork_children, remote_target::kill): Pass
5251         down target.
5252         (remote_target::mourn_inferior): Pass down target.  Use
5253         remote_unpush_target.
5254         (remote_target::core_of_thread)
5255         (remote_target::remote_btrace_maybe_reopen): Pass down target.
5256         (remote_target::pid_to_exec_file)
5257         (remote_target::thread_handle_to_thread_info): Pass down target.
5258         (remote_target::async_wait_fd): New.
5259         * riscv-fbsd-tdep.c: Include "inferior.h".
5260         (riscv_fbsd_get_thread_local_address): Pass down target.
5261         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
5262         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
5263         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
5264         Adjust.
5265         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
5266         * solib-svr4.c (enable_break): Pass down target.
5267         * spu-multiarch.c (parse_spufs_run): Pass down target.
5268         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
5269         * target-delegates.c: Regenerate.
5270         * target.c (g_target_stack): Delete.
5271         (current_top_target): Return the current inferior's top target.
5272         (target_has_execution_1): Refer to the passed-in inferior's top
5273         target.
5274         (target_supports_terminal_ours): Check whether the initial
5275         inferior was already created.
5276         (decref_target): New.
5277         (target_stack::push): Incref/decref the target.
5278         (push_target, push_target, unpush_target): Adjust.
5279         (target_stack::unpush): Defref target.
5280         (target_is_pushed): Return bool.  Adjust to refer to the current
5281         inferior's target stack.
5282         (dispose_inferior): Delete, and inline parts ...
5283         (target_preopen): ... here.  Only dispose of the current inferior.
5284         (target_detach): Hold strong target reference while detaching.
5285         Pass target down.
5286         (target_thread_name): Add assertion.
5287         (target_resume): Pass down target.
5288         (target_ops::beneath, find_target_at): Adjust to refer to the
5289         current inferior's target stack.
5290         (get_dummy_target): New.
5291         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
5292         has a thread running.
5293         (initialize_targets): Rename to ...
5294         (_initialize_target): ... this.
5295         * target.h: Include "gdbsupport/refcounted-object.h".
5296         (struct target_ops): Inherit refcounted_object.
5297         (target_ops::shortname, target_ops::longname): Make const.
5298         (target_ops::async_wait_fd): New method.
5299         (decref_target): Declare.
5300         (struct target_ops_ref_policy): New.
5301         (target_ops_ref): New typedef.
5302         (get_dummy_target): Declare function.
5303         (target_is_pushed): Return bool.
5304         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
5305         (all_matching_threads_iterator::all_matching_threads_iterator):
5306         Handle filter target.
5307         * thread-iter.h (struct all_matching_threads_iterator, struct
5308         all_matching_threads_range, class all_non_exited_threads_range):
5309         Filter by target too.  Remove explicit.
5310         * thread.c (threads_executing): Delete.
5311         (inferior_thread): Pass down current inferior.
5312         (clear_thread_inferior_resources): Pass down thread pointer
5313         instead of ptid_t.
5314         (add_thread_silent, add_thread_with_info, add_thread): Add
5315         process_stratum_target parameter.  Use it for thread and inferior
5316         searches.
5317         (is_current_thread): New.
5318         (thread_info::deletable): Use it.
5319         (find_thread_ptid, thread_count, in_thread_list)
5320         (thread_change_ptid, set_resumed, set_running): New
5321         process_stratum_target parameter.  Pass it down.
5322         (set_executing): New process_stratum_target parameter.  Pass it
5323         down.  Adjust reference to 'threads_executing'.
5324         (threads_are_executing): New process_stratum_target parameter.
5325         Adjust reference to 'threads_executing'.
5326         (set_stop_requested, finish_thread_state): New
5327         process_stratum_target parameter.  Pass it down.
5328         (switch_to_thread): Also match inferior.
5329         (switch_to_thread): New process_stratum_target parameter.  Pass it
5330         down.
5331         (update_threads_executing): Reimplement.
5332         * top.c (quit_force): Pop targets from all inferior.
5333         (gdb_init): Don't call initialize_targets.
5334         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
5335         Declare.
5336         (windows_add_thread, windows_delete_thread): Adjust.
5337         (get_windows_debug_event): Rename to ...
5338         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
5339         * tracefile-tfile.c (tfile_target_open): Pass down target.
5340         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
5341         Forward declare.
5342         (switch_to_thread): Add process_stratum_target parameter.
5343         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
5344         parameter.  Use it.
5345         (mi_on_resume): Pass target down.
5346         * nat/fork-inferior.c (startup_inferior): Add
5347         process_stratum_target parameter.  Pass it down.
5348         * nat/fork-inferior.h (startup_inferior): Add
5349         process_stratum_target parameter.
5350         * python/py-threadevent.c (py_get_event_thread): Pass target down.
5351
5352 2020-01-10  Pedro Alves  <palves@redhat.com>
5353
5354         * remote.c (remote_target::start_remote): Don't set inferior_ptid
5355         directly.  Instead find the first thread in the thread list and
5356         use switch_to_thread.
5357
5358 2020-01-10  Pedro Alves  <palves@redhat.com>
5359
5360         * remote.c (remote_target::remote_add_inferior): Don't bind a
5361         process to the current inferior if the current inferior is already
5362         bound to a process.
5363
5364 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5365             Pedro Alves  <palves@redhat.com>
5366
5367         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
5368         If no process is specified, return null_ptid instead of
5369         inferior_ptid.
5370         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
5371         TARGET_WAITKIND_SIGNALLED with no pid.
5372
5373 2020-01-10  Pedro Alves  <palves@redhat.com>
5374
5375         * remote.c (first_remote_resumed_thread): New.
5376         (remote_target::wait_as): Use it as default event_ptid instead of
5377         inferior_ptid.
5378
5379 2020-01-10  Pedro Alves  <palves@redhat.com>
5380
5381         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
5382
5383 2020-01-10  Pedro Alves  <palves@redhat.com>
5384
5385         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
5386         not -1.
5387
5388 2020-01-10  Pedro Alves  <palves@redhat.com>
5389
5390         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
5391         ptid to get_last_target_status.
5392         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
5393         ptid to get_last_target_status.
5394         * infcmd.c (continue_command): Don't pass a target_waitstatus to
5395         get_last_target_status.
5396         (info_program_command): Don't pass a target_waitstatus to
5397         get_last_target_status.
5398         * infrun.c (init_wait_for_inferior): Use
5399         nullify_last_target_wait_ptid.
5400         (get_last_target_status): Handle nullptr arguments.
5401         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
5402         (print_stop_event): Don't pass a ptid to get_last_target_status.
5403         (normal_stop): Don't pass a ptid to get_last_target_status.
5404         * infrun.h (get_last_target_status, set_last_target_status): Move
5405         comments here and update.
5406         (nullify_last_target_wait_ptid): Declare.
5407         * linux-fork.c (fork_load_infrun_state): Remove local extern
5408         declaration of nullify_last_target_wait_ptid.
5409         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
5410         to get_last_target_status.
5411
5412 2020-01-10  Pedro Alves  <palves@redhat.com>
5413
5414         * gdbthread.h (scoped_restore_current_thread)
5415         <dont_restore, restore, m_dont_restore>: Declare.
5416         * thread.c (thread_alive): Add assertion.  Return bool.
5417         (switch_to_thread_if_alive): New.
5418         (prune_threads): Switch inferior/thread.
5419         (print_thread_info_1): Switch thread before calling target methods.
5420         (scoped_restore_current_thread::restore): New, factored out from
5421         ...
5422         (scoped_restore_current_thread::~scoped_restore_current_thread):
5423         ... this.
5424         (scoped_restore_current_thread::scoped_restore_current_thread):
5425         Add assertion.
5426         (thread_apply_all_command, thread_select): Use
5427         switch_to_thread_if_alive.
5428         * infrun.c (proceed, restart_threads, handle_signal_stop)
5429         (switch_back_to_stepped_thread): Switch current thread before
5430         calling target methods.
5431
5432 2020-01-10  Pedro Alves <palves@redhat.com>
5433
5434         * inferior.c (switch_to_inferior_no_thread): New function,
5435         factored out from ...
5436         (inferior_command): ... here.
5437         * inferior.h (switch_to_inferior_no_thread): Declare.
5438         * mi/mi-main.c (run_one_inferior): Use
5439         switch_to_inferior_no_thread.
5440
5441 2020-01-10  Pedro Alves  <palves@redhat.com>
5442
5443         * infcmd.c (kill_command): Remove dead code.
5444
5445 2020-01-10  Pedro Alves  <palves@redhat.com>
5446
5447         * remote.c (remote_target::mourn_inferior): No longer check
5448         whether the target is running.
5449
5450 2020-01-10  Pedro Alves  <palves@redhat.com>
5451
5452         * corelow.c (core_target::has_execution): Change parameter type to
5453         inferior pointer.
5454         * inferior.c (number_of_live_inferiors): Use
5455         inferior::has_execution instead of target_has_execution_1.
5456         * inferior.h (inferior::has_execution): New.
5457         * linux-thread-db.c (thread_db_target::update_thread_list): Use
5458         inferior::has_execution instead of target_has_execution_1.
5459         * process-stratum-target.c
5460         (process_stratum_target::has_execution): Change parameter type to
5461         inferior pointer.  Check the inferior's PID instead of
5462         inferior_ptid.
5463         * process-stratum-target.h
5464         (process_stratum_target::has_execution): Change parameter type to
5465         inferior pointer.
5466         * record-full.c (record_full_core_target::has_execution): Change
5467         parameter type to inferior pointer.
5468         * target.c (target_has_execution_1): Change parameter type to
5469         inferior pointer.
5470         (target_has_execution_current): Adjust.
5471         * target.h (target_ops::has_execution): Change parameter type to
5472         inferior pointer.
5473         (target_has_execution_1): Change parameter type to inferior
5474         pointer.  Change return type to bool.
5475         * tracefile.h (tracefile_target::has_execution): Change parameter
5476         type to inferior pointer.
5477
5478 2020-01-10  Pedro Alves  <palves@redhat.com>
5479
5480         * exceptions.c (print_flush): Remove current_top_target() check.
5481
5482 2020-01-10  Pedro Alves  <palves@redhat.com>
5483
5484         * remote.c (show_remote_exec_file): Show the current inferior's
5485         exec-file instead of the command variable's value.
5486
5487 2020-01-10  Pedro Alves  <palves@redhat.com>
5488
5489         * record-full.c (record_full_resume_ptid): New global.
5490         (record_full_target::resume): Set it.
5491         (record_full_wait_1): Use record_full_resume_ptid instead of
5492         inferior_ptid.
5493
5494 2020-01-10  Pedro Alves  <palves@redhat.com>
5495
5496         * gdbthread.h (scoped_restore_current_thread)
5497         <dont_restore, restore, m_dont_restore>: Declare.
5498         * thread.c (thread_alive): Add assertion.  Return bool.
5499         (switch_to_thread_if_alive): New.
5500         (prune_threads): Switch inferior/thread.
5501         (print_thread_info_1): Switch thread before calling target methods.
5502         (scoped_restore_current_thread::restore): New, factored out from
5503         ...
5504         (scoped_restore_current_thread::~scoped_restore_current_thread):
5505         ... this.
5506         (scoped_restore_current_thread::scoped_restore_current_thread):
5507         Add assertion.
5508         (thread_apply_all_command, thread_select): Use
5509         switch_to_thread_if_alive.
5510
5511 2020-01-10  George Barrett  <bob@bob131.so>
5512
5513         * stap-probe.c (stap_modify_semaphore): Don't check for null
5514         semaphores.
5515         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
5516         for null semaphores.
5517
5518 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5519
5520         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
5521         all source windows, and maintain horizontal scroll status while
5522         doing so.
5523
5524 2020-01-09  Tom Tromey  <tom@tromey.com>
5525
5526         PR tui/18932:
5527         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
5528         update_source_window, not print_source_lines.
5529
5530 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5531
5532         * tui/tui.c (tui_enable): Register tui hooks after calling
5533         tui_display_main.
5534
5535 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
5536
5537         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
5538
5539 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
5540
5541         * thread.c (print_thread_info_1): Fix indentation.
5542
5543 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
5544
5545         * symtab.c (general_symbol_info::compute_and_set_names): Move the
5546         unique_xmalloc_ptr outside the if to always free the demangled name.
5547
5548 2020-01-08  Tom Tromey  <tromey@adacore.com>
5549
5550         * xcoffread.c (enter_line_range, read_xcoff_symtab)
5551         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
5552         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
5553         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
5554         Remove.
5555         (section_offsets): New typedef.
5556         * symtab.c (fixup_section, get_msymbol_address): Update.
5557         * symmisc.c (dump_msymbols): Update.
5558         * symfile.h (relative_addr_info_to_section_offsets)
5559         (symfile_map_offsets_to_segments): Update.
5560         * symfile.c (build_section_addr_info_from_objfile)
5561         (init_objfile_sect_indices): Update.
5562         (struct place_section_arg): Change type of "offsets".
5563         (place_section): Update.
5564         (relative_addr_info_to_section_offsets): Change type of
5565         "section_offsets".  Remove "num_sections" parameter.
5566         (default_symfile_offsets, syms_from_objfile_1)
5567         (set_objfile_default_section_offset): Update.
5568         (reread_symbols): No need to preserve section offsets by hand.
5569         (symfile_map_offsets_to_segments): Change type of "offsets".
5570         * stap-probe.c (relocate_address): Update.
5571         * stabsread.h (process_one_symbol): Update.
5572         * solib-target.c (struct lm_info_target) <offsets>: Change type.
5573         (solib_target_relocate_section_addresses): Update.
5574         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
5575         Update.
5576         * solib-frv.c (frv_relocate_main_executable): Update.
5577         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
5578         * solib-aix.c (solib_aix_get_section_offsets): Change return
5579         type.
5580         (solib_aix_solib_create_inferior_hook): Update.
5581         * remote.c (remote_target::get_offsets): Update.
5582         * psymtab.c (find_pc_sect_psymtab): Update.
5583         * psympriv.h (struct partial_symbol) <address, text_low,
5584         text_high>: Update.
5585         * objfiles.h (obj_section_offset): Update.
5586         (struct objfile) <section_offsets>: Change type.
5587         <num_sections>: Remove.
5588         (objfile_relocate): Update.
5589         * objfiles.c (entry_point_address_query): Update
5590         (relocate_one_symbol): Change type of "section_offsets".
5591         (objfile_relocate1, objfile_relocate1): Change type of
5592         "new_offsets".
5593         (objfile_rebase1): Update.
5594         * mipsread.c (mipscoff_symfile_read): Update.
5595         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
5596         parameter.
5597         * mdebugread.c (parse_symbol): Change type of "section_offsets".
5598         (parse_external, psymtab_to_symtab_1): Update.
5599         * machoread.c (macho_symfile_offsets): Update.
5600         * ia64-tdep.c (ia64_find_unwind_table): Update.
5601         * hppa-tdep.c (read_unwind_info): Update.
5602         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
5603         * dwarf2read.c (create_addrmap_from_index)
5604         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5605         (process_psymtab_comp_unit_reader, add_partial_symbol)
5606         (add_partial_subprogram, process_full_comp_unit)
5607         (read_file_scope, read_func_scope, read_lexical_block_scope)
5608         (read_call_site_scope, dwarf2_rnglists_process)
5609         (dwarf2_ranges_process, dwarf2_ranges_read)
5610         (dwarf_decode_lines_1, var_decode_location, new_symbol)
5611         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
5612         Update.
5613         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
5614         Update.
5615         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
5616         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
5617         (process_one_symbol): Change type of "section_offsets".
5618         * ctfread.c (get_objfile_text_range): Update.
5619         * coffread.c (coff_symtab_read, enter_linenos)
5620         (process_coff_symbol): Update.
5621         * coff-pe-read.c (add_pe_forwarded_sym): Update.
5622         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
5623
5624 2020-01-08  Tom Tromey  <tromey@adacore.com>
5625
5626         * dwarf2read.c (parse_macro_definition): Use std::string.
5627         (parse_macro_definition): Likewise.
5628
5629 2020-01-08  Tom Tromey  <tromey@adacore.com>
5630
5631         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
5632         (ATTR_ALLOC_CHUNK): Remove.
5633
5634 2020-01-08  Tom Tromey  <tromey@adacore.com>
5635
5636         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
5637
5638 2020-01-08  Tom Tromey  <tromey@adacore.com>
5639
5640         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
5641         (dwarf2_compute_name, open_dwo_file): Likewise.
5642         (process_enumeration_scope): Use std::vector.
5643         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
5644         (partial_die_info::fixup, dwarf2_start_subfile)
5645         (guess_full_die_structure_name, dwarf2_name): Likewise.
5646         (determine_prefix): Update.
5647         (guess_full_die_structure_name): Make return type const.
5648         (partial_die_full_name): Return unique_xmalloc_ptr.
5649         (DW_FIELD_ALLOC_CHUNK): Remove.
5650
5651 2020-01-07  Tom Tromey  <tromey@adacore.com>
5652
5653         PR build/24937:
5654         * stap-probe.c (class stap_static_probe_ops): Add constructor.
5655
5656 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
5657
5658         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
5659
5660 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5661
5662         * stack.c (print_frame_info): Move disassemble_next_line code
5663         inside source_print block.
5664
5665 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
5666
5667         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
5668         gdb/signals.h, as we are now using native signal symbols.
5669
5670 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
5671
5672         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
5673         overflow by an early check of content vs threshold.
5674         * tui/tui-source.c (tui_source_window::line_is_displayed):
5675         Likewise.
5676
5677 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
5678
5679         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
5680
5681 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
5682
5683         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
5684         export table if no section contains it's RVA.
5685
5686 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
5687
5688         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
5689
5690 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
5691
5692         * source.c (print_source_lines_base): Set last_line_listed.
5693
5694 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
5695
5696         * tui/tui-disasm.c: Remove trailing spaces.
5697
5698 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
5699             Pedro Alves  <palves@redhat.com>
5700
5701         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
5702         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
5703         (windows_gdb_signal_to_target): New function, uses the above
5704         enumeration to convert GDB internal signal codes to equivalent
5705         Windows codes.
5706         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
5707         * windows-nat.c: Include "gdb_wait.h".
5708         (get_windows_debug_event): Extract the fatal exception from the
5709         exit status and convert to the equivalent Posix signal number.
5710         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
5711         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
5712         * gdbsupport/gdb_wait.c: New file, implements
5713         windows_status_to_termsig.
5714         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
5715         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
5716
5717 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5718
5719         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
5720         show_layout.
5721
5722 2020-01-05  Luis Machado  <luis.machado@linaro.org>
5723
5724         * aarch64-linux-nat.c
5725         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
5726         and bfd_mach_aarch64.
5727
5728 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5729
5730         * ui-file.c (stdio_file::can_emit_style_escape)
5731         (tee_file::can_emit_style_escape): Ensure style is used also on
5732         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
5733         to gdb_stdout.
5734         * main.c (set_gdb_data_directory): Use file style to output the
5735         warning that the given pathname is not a directory.
5736         * top.c (show_history_filename, gdb_safe_append_history)
5737         (show_gdb_datadir): Use file style.
5738
5739 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
5740
5741         * solib-target.c (struct lm_info_target):
5742         Change offsets to be a unique_xmalloc_ptr.
5743         (solib_target_relocate_section_addresses): Update.
5744
5745 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
5746
5747         * windows-nat.c (windows_clear_solib): Free so_list linked list.
5748
5749 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5750
5751         * MAINTAINERS (Write After Approval): Add myself.
5752
5753 2020-01-02  Luis Machado  <luis.machado@linaro.org>
5754
5755         * proc-service.c (get_ps_regcache): Remove reference to obsolete
5756         Cell BE architecture.
5757         * target.h (struct target_ops) <thread_architecture>: Likewise.
5758
5759 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
5760
5761         * Makefile.in: Use INSTALL_PROGRAM_ENV.
5762
5763 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
5764
5765         * MAINTAINERS (Write After Approval): Add myself.
5766
5767 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5768
5769         * gdbarch.sh: Update copyright year range of generated files.
5770
5771 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5772
5773         Update copyright year range in all GDB files.
5774
5775 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5776
5777         * copyright.py: Convert to Python 3.
5778
5779 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5780
5781         * copyright.py: Adapt after move of gnulib directory from gdb
5782         directory to toplevel directory.
5783
5784 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5785
5786         * copyright.py (main): Exit if run from the wrong directory.
5787
5788 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5789
5790         * top.c (print_gdb_version): Change copyright year to 2020.
5791
5792 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5793
5794         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
5795
5796 For older changes see ChangeLog-2019.
5797 \f
5798 Local Variables:
5799 mode: change-log
5800 left-margin: 8
5801 fill-column: 74
5802 version-control: never
5803 coding: utf-8
5804 End: