gdb/ChangeLog

   1 2019-12-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (struct tui_source_window_base)
   4         <maybe_update>: Remove line_no and addr parameters.
   5         * tui/tui-stack.c (tui_show_frame_info): Set PC on sal.  Update.
   6         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
   7         Update.
   8         * tui/tui-source.c (tui_source_window::maybe_update): Remove
   9         line_no and addr parameters.
  10         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
  11         Update.
  12         * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
  13         line_no and addr parameters.
  14
  15 2019-12-20  Tom Tromey  <tom@tromey.com>
  16
  17         * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
  18         (tui_source_window_base::update_breakpoint_info): Remove asserts.
  19
  20 2019-12-20  Tom Tromey  <tom@tromey.com>
  21
  22         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
  23         tui_show_disassem.
  24         * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
  25         declare.
  26         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
  27
  28 2019-12-20  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui.h (tui_show_source): Remove parameters.
  31         * tui/tui.c (tui_show_source): Remove parameters.
  32         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
  33
  34 2019-12-20  Tom Tromey  <tom@tromey.com>
  35
  36         * tui/tui.c (tui_show_source): Update.
  37         * tui/tui-winsource.c (tui_display_main): Update.
  38         * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
  39         to symtab.
  40         * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
  41         to symtab.
  42         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
  43
  44 2019-12-20  Tom Tromey  <tom@tromey.com>
  45
  46         PR tui/23619:
  47         * tui/tui-io.c (tui_rl_saved_prompt): Remove.
  48         (tui_redisplay_readline): Use rl_display_prompt.
  49         (tui_prep_terminal): Update.
  50
  51 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
  52
  53         * configure: Regenerate.
  54         * configure.ac: Quote variable arguments of test.
  55         * gdbsupport/common.m4: Likewise.
  56
  57 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
  58
  59         * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
  60         2 to pow ().
  61
  62 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
  63
  64         * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
  65         log10 to double to fix Solaris 11 with gcc 5.5.
  66
  67 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
  68
  69         * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
  70         "sun" to "saddr_un".
  71
  72 2019-12-19  Tom Tromey  <tromey@adacore.com>
  73
  74         * ui-out.h (enum class field_kind): Fix comment.
  75
  76 2019-12-11  Tom Tromey  <tromey@adacore.com>
  77
  78         * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
  79
  80 2019-12-18  Tom Tromey  <tromey@adacore.com>
  81
  82         PR build/25268:
  83         * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
  84         type on macOS.  Add comment.
  85
  86 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
  87
  88         * c-lang.c (c_get_string, asm_language_defn): Remove space
  89         before tab.
  90
  91 2019-12-18  Tom Tromey  <tromey@adacore.com>
  92
  93         PR build/25250:
  94         * ui-out.c (ui_out::vmessage): Update.
  95         * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
  96         Rename.
  97         (string_field): Update.
  98         (signed_field): Update.
  99
 100 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 101
 102         * top.c (print_gdb_configuration): Adjust indentation.
 103
 104 2019-12-17  Christian Biesinger  <cbiesinger@google.com>
 105
 106         * bsd-kvm.c: Include gdbsupport/pathstuff.h.
 107
 108 2019-12-17  Simon Marchi  <simon.marchi@polymtl.ca>
 109
 110         * tui/tui-layout.h (class tui_layout_base): Add virtual
 111         destructor.
 112
 113 2019-12-16  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 114
 115         * infcmd.c (prepare_one_step): Step over skipped inline functions.
 116         * infrun.c (inline_frame_is_marked_for_skip): New helper function.
 117         (process_event_stop_test): Keep stepping over skipped inline functions.
 118
 119 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 120
 121         * jit.c (struct gdb_block) <next>: Remove field.
 122         (struct gdb_symtab) <~gdb_symtab>: Remove.
 123         <blocks>: Change type to std::forward_list<gdb_block>.
 124         (compare_block): Remove.
 125         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
 126         block at the beginning, don't mind about sorting.
 127         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
 128         before using it.
 129
 130 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 131
 132         * jit.c (struct gdb_block): Add constructor, initialize
 133         real_block and next fields.
 134         <name>: Change type to gdb::unique_xmalloc_ptr.
 135         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
 136         (jit_block_open_impl): Allocate gdb_block with new.
 137         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
 138
 139 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 140
 141         * jit.c: Include forward_list.
 142         (struct gdb_symtab) <next>: Remove field.
 143         (struct gdb_object) <symtabs>: Change type to
 144         std::forward_list<gdb_symtab>.
 145         (jit_object_open_impl): Allocate gdb_object with new.
 146         (jit_symtab_open_impl): Adjust to std::forward_list.
 147         (finalize_symtab): Don't delete symtab.
 148         (jit_object_close_impl):  Adjust to std::forward_list.  Free
 149         gdb_object with delete.
 150
 151 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 152
 153         * jit.c (struct gdb_symtab): Add constructor, destructor,
 154         initialize fields.
 155         <linetable>: Change type to unique_xmalloc_ptr.
 156         <file_name>: Change type to std::string.
 157         (jit_symtab_open_impl): Allocate gdb_symtab with new.
 158         (jit_symtab_line_mapping_add_impl): Adjust.
 159         (finalize_symtab): Adjust, call delete on stab.
 160
 161 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 162
 163         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
 164
 165 2019-12-16  Tom Tromey  <tromey@adacore.com>
 166
 167         * windows-nat.c (windows_nat_target::attach): Update.
 168         * remote.c (extended_remote_target::attach): Update.
 169         * procfs.c (procfs_target::attach): Update.
 170         * nto-procfs.c (nto_procfs_target::attach): Update.
 171         (nto_procfs_target::create_inferior): Update.
 172         * inf-ptrace.c (inf_ptrace_target::attach): Update.
 173         * gnu-nat.c (gnu_nat_target::attach): Update.
 174         (gnu_nat_target::detach): Update.
 175         * darwin-nat.c (darwin_nat_target::attach): Update.
 176         * corefile.c (get_exec_file): Constify result.  Remove extraneous
 177         return.
 178         * bsd-kvm.c (bsd_kvm_target_open): Update.
 179         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
 180
 181 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
 182
 183         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
 184         (we no longer need to include time.h before pathmax.h)
 185
 186 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 187
 188         * ada-exp.y (write_ambiguous_var): Update.
 189         * coffread.c (process_coff_symbol): Update.
 190         * ctfread.c (ctf_add_enum_member_cb): Update.
 191         (new_symbol): Update.
 192         * dwarf2read.c (fixup_go_packaging): Update.
 193         (new_symbol): Update.
 194         * language.c (language_alloc_type_symbol): Update.
 195         * mdebugread.c (new_symbol): Update.
 196         * minsyms.c (minimal_symbol_reader::record_full): Update.
 197         * psymtab.c (add_psymbol_to_bcache): Update.
 198         * stabsread.c (define_symbol): Update.
 199         (read_enum_type): Update.
 200         * symtab.c (symbol_set_language): Make this a member function...
 201         (general_symbol_info::set_language): ... here.
 202         * symtab.h (struct general_symbol_info) <set_language>: New function.
 203         (SYMBOL_SET_LANGUAGE): Remove.
 204         (symbol_set_language): Remove.
 205
 206 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 207
 208         * ada-lang.c (ada_add_block_symbols): Update.
 209         (ada_collect_symbol_completion_matches): Update.
 210         * ax-gdb.c (gen_expr): Update.
 211         * block.c (block_lookup_symbol): Update.
 212         (block_lookup_symbol_primary): Update.
 213         (block_find_symbol): Update.
 214         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
 215         * dbxread.c (process_one_symbol): Update.
 216         * dictionary.c (insert_symbol_hashed): Update.
 217         (collate_pending_symbols_by_language): Update.
 218         (mdict_add_symbol): Update.
 219         * dwarf-index-write.c (write_psymbols): Update.
 220         * dwarf2read.c (fixup_go_packaging): Update.
 221         * findvar.c (read_var_value): Update.
 222         * ft32-tdep.c (ft32_skip_prologue): Update.
 223         * go-lang.c (go_symbol_package_name): Update.
 224         * language.h (scoped_switch_to_sym_language_if_auto::
 225         scoped_switch_to_sym_language_if_auto): Update.
 226         * linespec.c (find_method): Update.
 227         (find_label_symbols_in_block): Update.
 228         * mdebugread.c (parse_symbol): Update.
 229         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 230         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 231         (minimal_symbol_reader::install): Update.
 232         * moxie-tdep.c (moxie_skip_prologue): Update.
 233         * parse.c (parse_exp_in_context): Update.
 234         * psymtab.c (psymbol_name_matches): Update.
 235         (match_partial_symbol): Update.
 236         (lookup_partial_symbol): Update.
 237         (psymbol_hash): Update.
 238         (psymbol_compare): Update.
 239         * python/py-framefilter.c (extract_sym): Update.
 240         (py_print_single_arg): Update.
 241         * stabsread.c (define_symbol): Update.
 242         * stack.c (print_frame_arg): Update.
 243         (find_frame_funname): Update.
 244         (info_frame_command_core): Update.
 245         * symfile.c (set_initial_language): Update.
 246         * symtab.c (symbol_set_demangled_name): Update.
 247         (symbol_get_demangled_name): Update.
 248         (symbol_set_language): Update.
 249         (symbol_find_demangled_name): Update.
 250         (symbol_set_names): Update.
 251         (general_symbol_info::natural_name): Update.
 252         (general_symbol_info::demangled_name): Update.
 253         (general_symbol_info::search_name): Update.
 254         (symbol_matches_search_name): Update.
 255         (eq_symbol_entry): Update.
 256         (iterate_over_symbols): Update.
 257         (completion_list_add_symbol): Update.
 258         (completion_list_add_msymbol): Update.
 259         (completion_list_add_fields): Update.
 260         * symtab.h (struct general_symbol_info) <language>: New function.
 261         <language>: Rename to...
 262         <m_language>: ...this.
 263         (SYMBOL_LANGUAGE): Remove.
 264         (MSYMBOL_LANGUAGE): Remove.
 265         (struct symbol) <ctor>: Update.
 266         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 267
 268 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 269
 270         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 271         set the language of sym.
 272         * language.c (language_alloc_type_symbol): Likewise.
 273
 274 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 275
 276         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 277         PR gdb/23613
 278         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 279         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 280         (core_target_open): Use 'gdb_abspath'.
 281         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 282         'current_directory == NULL' case.
 283         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 284         explain what happens when 'current_directory' is NULL.
 285         * go32-nat.c (go32_nat_target::wait): Check if
 286         'current_directory' is NULL before call to 'chdir'.
 287         * source.c (add_path): Use 'gdb_abspath'.
 288         * top.c: Include 'gdbsupport/pathstuff.h'.
 289         (init_history): Use 'gdb_abspath'.
 290         (set_history_filename): Likewise.
 291         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 292         (tfile_target_open): Use 'gdb_abspath'.
 293
 294 2019-12-13  Tom Tromey  <tromey@adacore.com>
 295
 296         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 297         warning or error.
 298
 299 2019-12-13  Tom Tromey  <tromey@adacore.com>
 300
 301         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 302
 303 2019-12-13  Tom Tromey  <tromey@adacore.com>
 304
 305         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 306
 307 2019-12-13  Tom Tromey  <tromey@adacore.com>
 308
 309         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 310
 311 2019-12-13  Tom Tromey  <tromey@adacore.com>
 312
 313         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 314         (string_vappendf): Add ARI comment.
 315
 316 2019-12-13  Tom Tromey  <tromey@adacore.com>
 317
 318         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 319         floatformat_to_double.
 320         * target-float.c (host_float_ops<T>::from_target): Add ARI
 321         comment.
 322
 323 2019-12-13  Tom Tromey  <tromey@adacore.com>
 324
 325         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 326         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 327         ARI marker to abort.
 328         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 329
 330 2019-12-13  Tom Tromey  <tromey@adacore.com>
 331
 332         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 333
 334 2019-12-13  Tom Tromey  <tromey@adacore.com>
 335
 336         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 337
 338 2019-12-13  Tom Tromey  <tromey@adacore.com>
 339
 340         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 341         checks.
 342
 343 2019-12-13  Tom Tromey  <tromey@adacore.com>
 344
 345         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 346         end>: No longer "const".
 347
 348 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 349
 350         * jit.c: Fix indentation, replace spaces with tabs where
 351         applicable.
 352
 353 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 354
 355         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 356
 357 2019-12-12  Tom Tromey  <tom@tromey.com>
 358
 359         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 360         unique_ptr.
 361
 362 2019-12-12  Tom Tromey  <tom@tromey.com>
 363
 364         * progspace.h (objfile_list): New typedef.
 365         (class unwrapping_objfile_iterator)
 366         (struct unwrapping_objfile_range): Newl
 367         (struct program_space) <objfiles_range>: Change type.
 368         <objfiles>: Change return type.
 369         <add_objfile>: Change type of "objfile" parameter.
 370         <objfiles_list>: Now a list of shared_ptr.
 371         * progspace.c (program_space::add_objfile): Change type of
 372         "objfile".  Update.
 373         (program_space::remove_objfile): Update.
 374         * objfiles.h (struct objfile) <~objfile>: Make public.
 375         * objfiles.c (objfile::make): Update.
 376         (objfile::unlink): Don't call delete.
 377
 378 2019-12-12  Tom Tromey  <tom@tromey.com>
 379
 380         * symfile.c (symbol_file_clear): Update.
 381         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 382         method.
 383         * progspace.c (program_space::free_all_objfiles): New method.
 384         * objfiles.h (free_all_objfiles): Don't declare.
 385         * objfiles.c (free_all_objfiles): Move to program_space.
 386
 387 2019-12-12  Tom Tromey  <tom@tromey.com>
 388
 389         * progspace.c (program_space::add_objfile)
 390         (program_space::remove_objfile): Update.
 391         (program_space::multi_objfile_p): Remove.
 392         * objfiles.h (struct objfile) <next>: Remove.
 393         * objfiles.c (objfile::objfile): Update.
 394         (put_objfile_before): Update.
 395         (unlink_objfile): Update.
 396         * progspace.h (object_files): Remove.
 397         (struct program_space) <objfiles_head>: Remove.
 398         <objfiles_list>: New member.
 399         <objfiles_range, objfiles_safe_range>: Change type.
 400         (objfiles): Change return type.
 401         (objfiles_safe): Update.
 402         (multi_objfile_p): Rewrite and inline.
 403         (object_files): Remove macro.
 404
 405 2019-12-12  Tom Tromey  <tom@tromey.com>
 406
 407         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 408         second constructor.
 409         (basic_safe_range): New class.
 410
 411 2019-12-12  Tom Tromey  <tom@tromey.com>
 412
 413         * progspace.c (program_space::multi_objfile_p): New method.
 414         * printcmd.c (info_symbol_command): Update.
 415         * maint.c (maintenance_translate_address): Update.
 416         * objfiles.h (MULTI_OBJFILE_P): Remove.
 417         * progspace.h (struct program_space) <multi_objfile_p>: New
 418         method.
 419
 420 2019-12-12  Tom Tromey  <tom@tromey.com>
 421
 422         * progspace.h (struct program_space) <remove_objfile>: Declare.
 423         * progspace.c (program_space::remove_objfile): New method.
 424         * objfiles.c (unlink_objfile): Remove.
 425         (objfile::unlink): Call remove_objfile.
 426         (objfile): Don't call unlink_objfile.
 427
 428 2019-12-12  Tom Tromey  <tom@tromey.com>
 429
 430         * progspace.h (struct program_space) <add_objfile>: Declare
 431         method.
 432         * progspace.c (program_space::add_objfile): New method.
 433         * objfiles.c (~objfile): Don't unlink objfile.
 434         (put_objfile_before): Remove.
 435         (add_separate_debug_objfile): Don't call put_objfile_before.
 436         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 437         the per-program-space data.
 438
 439 2019-12-12  Tom Tromey  <tom@tromey.com>
 440
 441         * symfile.c (syms_from_objfile_1): Use objfile_up.
 442         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 443         method.
 444         (reread_symbols): Use objfile_up.
 445         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 446         unlink method.
 447         * objfiles.h (struct objfile) <~objfile>: Now private.
 448         <unlink>: New method.
 449         (struct objfile_deleter): New.
 450         (objfile_up): New typedef.
 451         * objfiles.c (objfile::unlink): New method.
 452         (free_objfile_separate_debug, free_all_objfiles)
 453         (objfile_purge_solibs): Use it.
 454         * jit.c (jit_unregister_code): Remove.
 455         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 456         objfile.
 457         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 458         objfile.
 459         * compile/compile-object-load.c (compile_object_load): Use
 460         objfile_up.
 461
 462 2019-12-12  Tom Tromey  <tom@tromey.com>
 463
 464         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 465         objfile::make.
 466         * objfiles.h (struct objjfile) <make>: No longer inline.
 467         (add_separate_debug_objfile): Don't declare.
 468         * objfiles.c (add_separate_debug_objfile): Now static.
 469         (objfile::make): Move from objfiles.h.  Call
 470         add_separate_debug_objfile.  Add "parent" parameter.
 471
 472 2019-12-12  Tom Tromey  <tom@tromey.com>
 473
 474         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 475         * objfiles.h (struct objfile): Make constructor private.
 476         <make>: New static method.
 477         * jit.c (jit_object_close_impl): Update.
 478
 479 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 480
 481         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 482         gdb::byte_vector.
 483
 484 2019-12-12  Tom Tromey  <tromey@adacore.com>
 485
 486         * xml-support.c (xml_fetch_content_from_file): Don't call
 487         malloc_failure.
 488         * utils.h (class gdb_argv): Remove malloc_failure comment.
 489         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 490
 491 2019-12-12  Tom Tromey  <tromey@adacore.com>
 492
 493         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 494         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 495         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 496         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 497         * riscv-ravenscar-thread.c: New file.
 498         * riscv-ravenscar-thread.h: New file.
 499         * riscv-tdep.c (riscv_gdbarch_init): Call
 500         register_riscv_ravenscar_ops.
 501
 502 2019-12-12  Tom Tromey  <tromey@adacore.com>
 503
 504         * gdbsupport/thread-pool.c (set_thread_name): Use
 505         ATTRIBUTE_UNUSED.
 506
 507 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 508
 509         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 510         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 511         macros.
 512
 513 2019-12-11  Tom Tromey  <tom@tromey.com>
 514
 515         * tui/tui-win.c (tui_set_win_height_command): Call
 516         tui_adjust_window_height.
 517         (tui_adjust_win_heights, new_height_ok): Remove.
 518         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 519         * tui/tui-layout.c (tui_adjust_window_height): New function.
 520
 521 2019-12-11  Tom Tromey  <tom@tromey.com>
 522
 523         * tui/tui-win.c (tui_resize_all): Remove code, call
 524         tui_apply_current_layout.
 525
 526 2019-12-11  Tom Tromey  <tom@tromey.com>
 527
 528         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 529         * tui/tui-layout.c (standard_layouts, applied_layout): New
 530         globals.
 531         (tui_apply_current_layout): New function.
 532         (show_layout): Set applied_layout.  Call
 533         tui_apply_current_layout.
 534         (show_source_command, show_disasm_command)
 535         (show_source_disasm_command, show_data)
 536         (show_source_or_disasm_and_command): Remove.
 537         (initialize_layouts): New function.
 538         (_initialize_tui_layout): Call initialize_layouts.
 539
 540 2019-12-11  Tom Tromey  <tom@tromey.com>
 541
 542         * tui/tui-layout.h (class tui_layout_base)
 543         (class tui_layout_window, class tui_layout_split): New.
 544         * tui/tui-layout.c (tui_get_window_by_name)
 545         (tui_layout_window::clone, tui_layout_window::apply)
 546         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 547         (tui_layout_split::add_window, tui_layout_split::clone)
 548         (tui_layout_split::get_sizes)
 549         (tui_layout_split::set_weights_from_heights)
 550         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 551         functions.
 552         (tui_layout_split::add_split, tui_layout_split::add_split)
 553         (tui_layout_split::set_weights_from_heights)
 554         (tui_layout_split::set_weights_from_heights): New functions.
 555
 556 2019-12-11  Tom Tromey  <tom@tromey.com>
 557
 558         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 559         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 560         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 561         * tui/tui-data.h (struct tui_point): Remove.
 562         (struct tui_gen_win_info) <origin>: Remove.
 563         <x, y>: New fields.
 564         * tui/tui-command.c (tui_cmd_window::resize): Update.
 565
 566 2019-12-11  Tom Tromey  <tom@tromey.com>
 567
 568         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 569         Implement.
 570         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 571         Implement.
 572         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 573         method.
 574         (struct tui_win_info) <min_height>: Implement.
 575
 576 2019-12-11  Tom Tromey  <tom@tromey.com>
 577
 578         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 579         (struct tui_win_info) <can_box>: Update.
 580
 581 2019-12-11  Tom Tromey  <tom@tromey.com>
 582
 583         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 584         method.
 585         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 586         method.
 587         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 588         method.
 589         (struct tui_win_info) <max_height>: Now override.
 590
 591 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 592
 593         * NEWS: Create a new section for the next release branch.
 594         Rename the section of the current branch, now that it has
 595         been cut.
 596
 597 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 598
 599         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 600         * version.in: Bump version to 10.0.50.DATE-git.
 601
 602 2019-12-11  Tom Tromey  <tromey@adacore.com>
 603
 604         PR build/25268:
 605         * gdbsupport/thread-pool.c (set_thread_name): New function.
 606         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 607         (thread_pool::thread_function): Call set_thread_name.
 608
 609 2019-12-11  Tom Tromey  <tromey@adacore.com>
 610
 611         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 612         bfd_get_signed_8.
 613
 614 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 615
 616         * NEWS: Document -raw-values option and the related setting commands.
 617         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 618         only set it on when /r is given.
 619         * valprint.c (value_print_option_defs): New element raw-values.
 620         * Makefile.in: Add the new file.
 621
 622 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 623
 624         * gdbsupport/safe-strerror.c: Supress the unused function warning
 625         for select_strerror_r.
 626
 627 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 628
 629         * config.in: Regenerate.
 630         * configure: Regenerate.
 631         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 632         safe_strerror instead of strerror.
 633         * gdbsupport/common.m4: Don't check for strerror.
 634         * gdbsupport/safe-strerror.c: Support both the glibc version
 635         of strerror_r and the XSI version.
 636
 637 2019-12-10  Tom Tromey  <tromey@adacore.com>
 638
 639         * ada-typeprint.c (print_choices): Use a single "?".
 640         (print_variant_part): Print "?" if the discriminant name
 641         is not known.
 642
 643 2019-12-10  George Barrett  <bob@bob131.so>
 644
 645         Fix scripted probe breakpoints.
 646         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 647         declaration forward.
 648         (breakpoint_ops_for_event_location_type)
 649         (breakpoint_ops_for_event_location): Add function definitions.
 650         (break_command_1, trace_command): Use
 651         breakpoint_ops_for_event_location.
 652         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 653         declarations.
 654         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 655         breakpoint_ops_for_event_location.
 656         * python/py-breakpoint.c (bppy_init): Use
 657         breakpoint_ops_for_event_location.
 658
 659 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 660
 661         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 662         when ranking an lvalue argument for an rvalue parameter.
 663
 664 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 665
 666         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 667         template argument for scoped_restore_tmpl from bool to int.
 668
 669 2019-12-07  Keith Seitz  <keiths@redhat.com>
 670
 671         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 672         (build_id_to_debug_bfd): Make static, rewriting to use
 673         build_id_to_bfd_suffix.
 674         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 675         adding `suffix' parameter. Append SUFFIX to file names
 676         when searching for matching files.
 677         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 678         (build_id_to_exec_bfd): Likewise.
 679         * build-id.h (build_id_to_debug_bfd): Clarify that function
 680         searches for BFD of debug info file.
 681         (build_id_to_exec_bfd): Declare.
 682         * corelow.c: Include build-id.h.
 683         (locate_exec_from_corefile_build_id): New function.
 684         (core_target_open): If no executable BFD is found,
 685         search for a core file BFD using build-id.
 686
 687 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 688
 689         * bcache.c: Put in namespace gdb.
 690         * bcache.h: Likewise.
 691         * gdbtypes.c (check_types_worklist): Update.
 692         (types_deeply_equal): Update.
 693         * macrotab.c (struct macro_table) <bcache>: Update.
 694         (new_macro_table): Update.
 695         * macrotab.h (struct bcache): Put this forward declaration
 696         inside namespace gdb.
 697         (new_macro_table): Update.
 698         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 699         Update.
 700         <macro_cache>: Update.
 701         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 702
 703 2019-12-06  Tom de Vries  <tdevries@suse.de>
 704
 705         PR symtab/24971
 706         * block.c (best_symbol, better_symbol): New function.
 707         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 708         decl.
 709
 710 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 711
 712         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 713         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 714         for ranking see-through reference cases.
 715
 716 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 717         * stack.c (faas_command): Check a command is provided.
 718         * thread.c (taas_command, tfaas_command): Likewise.
 719
 720 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 721         * inferior.c (prune_inferiors):  Only call delete_inferior,
 722         Do not modify the inferior list.
 723
 724 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 725
 726         * c-exp.y: Update calls to lookup_typename,
 727         lookup_signed_typename and lookup_unsigned_typename.
 728         * c-lang.c (evaluate_subexp_c): Likewise.
 729         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 730         Likewise.
 731         * eval.c (binop_promote): Likewise.
 732         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 733         (lookup_unsigned_typename): Likewise.
 734         (lookup_signed_typename): Likewise.
 735         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 736         (lookup_signed_typename): Likewise.
 737         (lookup_typename): Likewise.
 738         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 739         lookup_typename, lookup_signed_typename,
 740         lookup_unsigned_typename.
 741         * m2-exp.y: Likewise.
 742         * printcmd.c (printf_wide_c_string): Likewise.
 743         (ui_printf): Likewise.
 744         * python/py-type.c (typy_lookup_typename): Likewise.
 745         * python/py-xmethods.c (python_xmethod_worker::invoke):
 746         Likewise.
 747         * rust-exp.y: Likewise.
 748
 749 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 750
 751         * configure.nat (obsd64): Add missing files x86-nat.o and
 752         nat/x86-dregs.o.
 753
 754 2019-12-04  Tom Tromey  <tom@tromey.com>
 755
 756         * valprint.c (val_print_string): Use metadata_style.
 757         * go-valprint.c (print_go_string): Use metadata style.
 758         * p-valprint.c (pascal_object_print_static_field): Use metadata
 759         style.
 760         * cp-valprint.c (cp_print_static_field): Use metadata style.
 761
 762 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 763             Chris January  <chris.january@arm.com>
 764
 765         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 766         tokens.
 767         (typebase): New patterns for complex, single/double precision, and
 768         single/double complex.
 769         (f77_keywords): Change token for complex keyword, and add single,
 770         double, and precision keywords.
 771
 772 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 773
 774         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 775         "info io_registers".
 776
 777 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 778
 779         * regcache.c (cooked_read_test): Initialize thread list of
 780         mock_inferior.
 781
 782 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 783
 784         * aarch64-linux-tdep.c: Remove includes.
 785
 786 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 787
 788         * aarch64-tdep.c: Remove includes.
 789
 790 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 791
 792         * filtered-iterator.h (filtered_iterator) <operator==,
 793         operator!=>: Compare wrapped iterators, not wrapped pointers.
 794         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 795         unittests/filtered_iterator-selftests.c.
 796         * unittests/filtered_iterator-selftests.c: New file.
 797
 798 2019-12-04  Tom Tromey  <tromey@adacore.com>
 799
 800         * gdbtypes.c (create_range_type): Inherit endianity
 801         from base type.
 802
 803 2019-12-04  Tom Tromey  <tromey@adacore.com>
 804
 805         * ada-lang.c (decode_constrained_packed_array)
 806         (ada_value_assign, value_assign_to_component): Update.
 807         * dwarf2loc.c (rw_pieced_value, access_memory)
 808         (dwarf2_compile_expr_to_ax): Update.
 809         * dwarf2read.c (dwarf2_add_field): Update.
 810         * eval.c (evaluate_subexp_standard): Update.
 811         * gdbarch.c, gdbarch.h: Rebuild.
 812         * gdbarch.sh (bits_big_endian): Remove.
 813         * gdbtypes.h (union field_location): Update comment.
 814         * target-descriptions.c (make_gdb_type): Update.
 815         * valarith.c (value_bit_index): Update.
 816         * value.c (struct value) <bitpos>: Update comment.
 817         (unpack_bits_as_long, modify_field): Update.
 818         * value.h (value_bitpos): Update comment.
 819
 820 2019-12-04  Tom Tromey  <tromey@adacore.com>
 821
 822         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 823         endian-ness.
 824
 825 2019-12-04  Tom Tromey  <tromey@adacore.com>
 826
 827         * dwarf2read.c (dwarf2_init_float_type)
 828         (dwarf2_init_complex_target_type): Add byte_order parameter.
 829         (read_base_type): Compute byte order earlier.
 830         * gdbtypes.c (init_float_type): Add byte_order parameter.
 831         * gdbtypes.h (init_float_type): Add byte_order parameter.
 832
 833 2019-12-04  Tom Tromey  <tromey@adacore.com>
 834
 835         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 836
 837 2019-12-04  Tom Tromey  <tromey@adacore.com>
 838
 839         * dwarf2read.c (process_structure_scope): Initialize
 840         "discr_offset".
 841
 842 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 843
 844         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 845         add it into the search spec.
 846         (parse_max_results_option): New function.
 847         (mi_info_functions_or_variables): Parse -max-results flag and pass
 848         it to mi_symbol_info.
 849         (mi_cmd_symbol_info_modules): Likewise.
 850         (mi_cmd_symbol_info_types): Likewise.
 851         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 852         return type to bool, change result container into a set, and don't
 853         add new results if we have enough already.
 854         (global_symbol_searcher::add_matching_msymbols): Change return
 855         type to bool, and don't add new results if we have enough already.
 856         (sort_search_symbols_remove_dups): Delete.
 857         (global_symbol_searcher::search): Early exit from search loop when
 858         we have enough results.  Use a std::set to collect the results
 859         from calling add_matching_symbols.
 860         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 861         member function.
 862         (global_symbol_searcher) <m_max_search_results>: New member
 863         variable.
 864         (global_symbol_searcher) <add_matching_symbols>: Update header
 865         comment and change return type to bool.
 866         (global_symbol_searcher) <add_matching_msymbols>: Update header
 867         comment and change return type to bool.
 868
 869 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 870
 871         * symtab.c (symbol_search::compare_search_syms): Update header
 872         comment.
 873         (global_symbol_searcher::is_suitable_msymbol): New function.
 874         (global_symbol_searcher::expand_symtabs): New function.
 875         (global_symbol_searcher::add_matching_symbols): New function.
 876         (global_symbol_searcher::add_matching_msymbols): New function.
 877         (global_symbol_searcher::search): Move most of the content
 878         into the new functions above, and call them as needed.
 879         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 880         function.
 881         (global_symbol_searcher) <add_matching_symbols>: New member
 882         function.
 883         (global_symbol_searcher) <add_matching_msymbols>: New member
 884         function.
 885         (global_symbol_searcher) <is_suitable_msymbol>: New member
 886         function.
 887
 888 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 889
 890         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 891         -symbol-info-module-variables entries.
 892         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 893         (mi_cmd_symbol_info_module_variables): Declare.
 894         * mi/mi-symbol-cmds.c
 895         (module_symbol_search_iterator): New typedef.
 896         (output_module_symbols_in_single_module_and_file): New function.
 897         (output_module_symbols_in_single_module): New function.
 898         (mi_info_module_functions_or_variables): New function.
 899         (mi_cmd_symbol_info_module_functions): New function.
 900         (mi_cmd_symbol_info_module_variables): New function.
 901         * NEWS: Mention new MI command.
 902
 903 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 904
 905         * bcache.c (hash): Remove.
 906         (hash_continue): Remove.
 907         * bcache.h (hash): Remove.
 908         (hash_continue): Remove.
 909         (struct bcache) <ctor>: Update.
 910         * psymtab.c (psymbol_hash): Update.
 911         * stabsread.c (hashname): Update.
 912         * utils.h (fast_hash): Add an argument for a start value,
 913         defaulting to zero.
 914
 915 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 916         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 917         (destroy_block_symbol_cache): New function.
 918         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 919         (resize_symbol_cache): Likewise.
 920
 921 2019-12-02  Tom Tromey  <tom@tromey.com>
 922
 923         * unittests/tui-selftests.c (run_tests): Make conditional.
 924         (_initialize_tui_selftest): Make conditional.
 925
 926 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 927
 928         * aix-thread.c (debug_aix_thread): Change type to bool.
 929
 930 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 931
 932         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 933
 934 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 935
 936         * dwarf2read.c (read_tag_string_type): Read the fields required to
 937         make a dynamic string, and possibly create a dynamic range for the
 938         string.
 939         (attr_to_dynamic_prop): Setup is_reference based on the type of
 940         attribute being processed.
 941         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 942         (resolve_dynamic_array): Rename to...
 943         (resolve_dynamic_array_or_string): ...this, update header comment,
 944         and accept TYPE_CODE_STRING.
 945         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 946
 947 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 948
 949         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 950         of its implementation from...
 951         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 952         the new function.
 953
 954 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 955
 956         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
 957         create a range with stride where appropriate.
 958         * f-valprint.c: Include 'gdbarch.h'.
 959         (f77_print_array_1): Take the stride into account when walking the
 960         array.  Also convert the stride into addressable units.
 961         * gdbtypes.c (create_range_type): Initialise the stride to
 962         constant zero.
 963         (create_range_type_with_stride): New function, initialise the
 964         range as normal, and then setup the stride.
 965         (has_static_range): Include the stride here.  Also change the
 966         return type to bool.
 967         (create_array_type_with_stride): Consider the range stride if the
 968         array isn't given its own stride.
 969         (resolve_dynamic_range): Resolve the stride if needed.
 970         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
 971         (struct range_bounds) <flag_is_byte_stride>: New member variable.
 972         (TYPE_BIT_STRIDE): Define.
 973         (TYPE_ARRAY_BIT_STRIDE): Define.
 974         (create_range_type_with_stride): Declare.
 975         * valarith.c (value_subscripted_rvalue): Take range stride into
 976         account when walking the array.
 977
 978 2019-12-01  Tom Tromey  <tom@tromey.com>
 979
 980         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
 981         specially.
 982
 983 2019-12-01  Tom Tromey  <tom@tromey.com>
 984
 985         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 986         \0.
 987         * unittests/tui-selftests.c: New file.
 988         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
 989
 990 2019-12-01  Tom Tromey  <tom@tromey.com>
 991
 992         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
 993
 994 2019-12-01  Tom Tromey  <tom@tromey.com>
 995
 996         * NEWS: Document new settings.
 997         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 998         * tui/tui-win.c (_initialize_tui_win): Add border style
 999         observers.
1000         * tui/tui-io.h (tui_apply_style): Declare.
1001         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
1002         longer static.
1003         (apply_ansi_escape, tui_set_reverse_mode): Update.
1004         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1005         Add "skip_intensity" parameter.
1006         <changed>: New member.
1007         <do_set_value>: Declare.
1008         (tui_border_style, tui_active_border_style): Declare.
1009         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1010         globals.
1011         (cli_style_option): Initialize "changed".
1012         (cli_style_option::do_set_value): New function.
1013         (cli_style_option::add_setshow_commands): Add "skip_intensity"
1014         parameter.  Update.
1015         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1016         (_initialize_cli_style): Update.  Create TUI border style
1017         commands.
1018
1019 2019-12-01  Tom Tromey  <tom@tromey.com>
1020
1021         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1022         parameter.
1023         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1024         parameter.
1025         * tui/tui-win.h (compact_source): Declare.
1026         * tui/tui-win.c (compact_source): New global.
1027         (tui_set_compact_source, tui_show_compact_source): New functions.
1028         (_initialize_tui_win): Add "compact-source" setting.
1029         * tui/tui-source.c (tui_source_window::set_contents): Handle
1030         compact_source setting.
1031         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1032         * NEWS: Document new setting.
1033
1034 2019-11-30  Tom Tromey  <tom@tromey.com>
1035
1036         * dwarf2read.c (dwarf2_add_field): Include field offset when
1037         computing variant part length.
1038
1039 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1040         * NEWS:  Mention define-prefix.  Tell that command names can now
1041         contain a . character.
1042
1043 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1044
1045         * command.h (valid_cmd_char_p): Declare.
1046         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1047         the check of valid command char.
1048         (find_command_name_length, valid_user_defined_cmd_name_p): Use
1049         valid_cmd_char_p.
1050         * cli/cli-script.c (validate_comname): Likewise.
1051         * completer.c (gdb_completer_command_word_break_characters):
1052         Do not remove . from the word break char, update comments.
1053         (complete_line_internal_1): Use valid_cmd_char_p.
1054         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1055         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1056
1057 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1058
1059         * cli/cli-script.c (do_define_command): Ensure a redefined
1060         prefix command is kept as a prefix command.
1061         (define_prefix_command): New function.
1062         (show_user_1): Report user defined prefixes.
1063         (_initialize_cli_script):  Create the new 'define-prefix' command.
1064         Add completers for 'define' and 'document'.
1065         * top.c (execute_command):  If command is a user-defined prefix only
1066         command, report the list of commands for this prefix command.
1067
1068 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1069
1070         * valops.c (find_oload_champ): Improve debug output.
1071
1072 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1073
1074         * valops.c (find_oload_champ): Print part of debug messages
1075         before the badness vector is std::move'd.
1076
1077 2019-11-28  Tom Tromey  <tom@tromey.com>
1078
1079         * value.c (creal_internal_fn): Fix comment.
1080
1081 2019-11-28  Tom Tromey  <tom@tromey.com>
1082
1083         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1084         flag_bound_evaluated>: Now unsigned.
1085
1086 2019-11-28  Tom Tromey  <tom@tromey.com>
1087
1088         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1089         declare.
1090
1091 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
1092
1093         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1094         debug output.
1095         * jit.c (jit_unregister_code): Add debug print to match
1096         `jit_register_code`.
1097
1098 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1099
1100         * NEWS: Mention the new multithreaded symbol loading.
1101
1102 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1103
1104         * maint.c (n_worker_threads): Default to 0.
1105         (worker_threads_disabled): New function.
1106         * maint.h (worker_threads_disabled): New function.
1107         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1108         here if worker_threads_disabled () is true.
1109         (minimal_symbol_reader::install): Skip all threading if
1110         worker_threads_disabled () is true.
1111
1112 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1113
1114         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1115         hash code if possible.
1116         (add_minsym_to_demangled_hash_table): Likewise.
1117         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1118         on the background thread.
1119         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1120         Add these fields.
1121
1122 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1123
1124         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1125         of the mangled name on the background thread.
1126         * symtab.c (symbol_set_names): Allow passing in the hash of the
1127         linkage_name.
1128         * symtab.h (symbol_set_names): Likewise.
1129
1130 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1131
1132         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1133         physnames are computed for inherited DIEs.
1134
1135 2019-11-27  Tom Tromey  <tromey@adacore.com>
1136
1137         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1138         backslashes.
1139         * cp-support.c: Remove unnecessary backslashes.
1140
1141 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1142
1143         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1144         with sym->set_linkage_name.
1145         * coffread.c (coff_read_enum_type): Likewise.
1146         * mdebugread.c (parse_symbol): Likewise.
1147         * stabsread.c (patch_block_stabs): Likewise.
1148         (define_symbol): Likewise.
1149         (read_enum_type): Likewise.
1150         (common_block_end): Likewise.
1151         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1152         function.
1153         (SYMBOL_SET_LINKAGE_NAME): Remove.
1154         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1155         with sym->set_linkage_name.
1156
1157 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1158
1159         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1160         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1161         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1162         * NEWS: Mention new MI command.
1163
1164 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1165
1166         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1167         '-symbol-info-types', and '-symbol-info-variables'.
1168         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1169         (mi_cmd_symbol_info_types): Declare.
1170         (mi_cmd_symbol_info_variables): Declare.
1171         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1172         (output_debug_symbol): New function.
1173         (output_nondebug_symbol): New function.
1174         (mi_symbol_info): New function.
1175         (mi_info_functions_or_variables): New function.
1176         (mi_cmd_symbol_info_functions): New function.
1177         (mi_cmd_symbol_info_types): New function.
1178         (mi_cmd_symbol_info_variables): New function.
1179         * NEWS: Mention new commands.
1180
1181 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1182
1183         * symtab.c (symbol_to_info_string): New function, most content
1184         moved from print_symbol_info, but updated to return a std::string.
1185         (print_symbol_info): Update to use symbol_to_info_string and print
1186         returned string.
1187         * symtab.h (symbol_to_info_string): Declare new function.
1188
1189 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1190
1191         * python/python.c (gdbpy_rbreak): Convert to using
1192         global_symbol_searcher.
1193         * symtab.c (file_matches): Convert return type to bool, change
1194         file list to std::vector, update header comment.
1195         (search_symbols): Rename to...
1196         (global_symbol_searcher::search): ...this and update now its
1197         a member function of global_symbol_searcher.  Take account of the
1198         changes to file_matches.
1199         (symtab_symbol_info): Convert to using global_symbol_searcher.
1200         (rbreak_command): Likewise.
1201         (search_module_symbols): Likewise.
1202         * symtab.h (enum symbol_search): Update comment.
1203         (search_symbols): Remove declaration.
1204         (class global_symbol_searcher): New class.
1205
1206 2019-11-26  Tom Tromey  <tromey@adacore.com>
1207
1208         * cp-support.c (_initialize_cp_support): Conditionally initialize
1209         gdb_demangle_attempt_core_dump.
1210
1211 2019-11-26  Tom Tromey  <tom@tromey.com>
1212
1213         * python/py-function.c (fnpy_init): Update.
1214         * value.h (add_internal_function): Adjust declaration.
1215         * value.c (function_destroyer): Remove.
1216         (do_add_internal_function): Don't set destroyer or copy name.
1217         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1218         Set name_allocated.
1219         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1220         (cmdpy_init): Set name_allocated.
1221         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1222         member.
1223         (~cmd_list_element): Free "name" if needed.
1224
1225 2019-11-26  Tom Tromey  <tom@tromey.com>
1226
1227         * value.h (add_internal_function): Add new overload.  Move
1228         documentation from value.h.
1229         * value.c (do_add_internal_function): New function.
1230         (add_internal_function): Use it.  Add new overload.
1231         (function_destroyer): Don't free doc.
1232         * python/py-function.c (fnpy_init): Update.
1233
1234 2019-11-26  Tom Tromey  <tom@tromey.com>
1235
1236         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1237         (cmdpy_init): Set "doc_allocated".
1238
1239 2019-11-26  Tom Tromey  <tom@tromey.com>
1240
1241         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1242         name of worker thread.
1243         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1244         pthread_setname_np.
1245         * configure, config.in: Rebuild.
1246
1247 2019-11-26  Tom Tromey  <tom@tromey.com>
1248
1249         * python/python.c (class gdbpy_gil): New.
1250         (struct gdbpy_event): Add constructor, destructor, operator().
1251         (gdbpy_post_event): Use run_on_main_thread.
1252         (gdbpy_initialize_events): Remove.
1253         (do_start_initialization): Update.
1254
1255 2019-11-26  Tom Tromey  <tom@tromey.com>
1256
1257         * NEWS: Add entry.
1258         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1259         commands.  Call update_thread_pool_size.
1260         (update_thread_pool_size, maintenance_set_worker_threads): New
1261         functions.
1262         (n_worker_threads): New global.
1263
1264 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1265             Tom Tromey  <tom@tromey.com>
1266
1267         * minsyms.c (minimal_symbol_reader::install): Use
1268         parallel_for_each.
1269         * gdbsupport/parallel-for.h: New file.
1270         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1271
1272 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1273             Tom Tromey  <tom@tromey.com>
1274
1275         * gdbsupport/thread-pool.h: New file.
1276         * gdbsupport/thread-pool.c: New file.
1277         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1278         (HFILES_NO_SRCDIR): Add thread-pool.h.
1279
1280 2019-11-26  Tom Tromey  <tom@tromey.com>
1281
1282         * event-top.h (thread_local_segv_handler): Declare.
1283         * event-top.c (thread_local_segv_handler): New global.
1284         (install_handle_sigsegv, handle_sigsegv): New functions.
1285         (async_init_signals): Install SIGSEGV handler.
1286         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1287         thread-local.
1288         (report_failed_demangle): New function.
1289         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1290         handler-setting code, instead use segv_handler.  Run warning code
1291         on main thread.
1292
1293 2019-11-26  Tom Tromey  <tom@tromey.com>
1294
1295         * run-on-main-thread.c: New file.
1296         * run-on-main-thread.h: New file.
1297         * unittests/main-thread-selftests.c: New file.
1298         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1299         main-thread-selftests.c.
1300         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1301         (COMMON_SFILES): Add run-on-main-thread.c.
1302
1303 2019-11-26  Tom Tromey  <tom@tromey.com>
1304
1305         * main.c (setup_alternate_signal_stack): Remove.
1306         (captured_main_1): Use gdb::alternate_signal_stack.
1307         * gdbsupport/alt-stack.h: New file.
1308
1309 2019-11-26  Tom Tromey  <tom@tromey.com>
1310
1311         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1312         Remove comment.
1313         (save_original_signals_state, restore_original_signals_state): Use
1314         gdb_sigmask.
1315         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1316         (_initialize_linux_nat): Use gdb_sigmask.
1317         * guile/guile.c (_initialize_guile): Use block_signals.
1318         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1319         * gdbsupport/gdb-sigmask.h: New file.
1320         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1321         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1322         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1323         pthread_sigmask.
1324         * configure, config.in: Rebuild.
1325         * gdbsupport/block-signals.h: New file.
1326
1327 2019-11-26  Tom Tromey  <tom@tromey.com>
1328
1329         * acinclude.m4: Include ax_pthread.m4.
1330         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1331         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1332         (CLIBS): Use PTHREAD_LIBS.
1333         (aclocal_m4_deps): Add ax_pthread.m4.
1334         * config.in, configure: Rebuild.
1335         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1336
1337 2019-11-26  Tom Tromey  <tom@tromey.com>
1338
1339         * symtab.h (struct minimal_symbol) <name_set>: New member.
1340         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1341         Don't call symbol_set_names.
1342         (minimal_symbol_reader::install): Call symbol_set_names.
1343
1344 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1345
1346         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1347         restore_active_ext_lang, as GIL is needed for (indirectly)
1348         called PyOS_InterruptOccurred.
1349
1350 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1351
1352         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1353         definition.
1354
1355 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1356
1357         * remote-sim.c (simulator_command): Make static, remove
1358         declaration.
1359
1360 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1361
1362         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1363         static.
1364         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1365         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1366         (main): Likewise.
1367         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1368         (main): Likewise.
1369         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1370         (main): Likewise.
1371         * unittests/basic_string_view/element_access/char/1.cc (test01):
1372         Likewise.
1373         (main): Likewise.
1374         * unittests/basic_string_view/element_access/char/empty.cc (main):
1375         Likewise.
1376         * unittests/basic_string_view/element_access/char/front_back.cc
1377         (test01): Likewise.
1378         (main): Likewise.
1379         * unittests/basic_string_view/inserters/char/2.cc (test05):
1380         Likewise.
1381         (main): Likewise.
1382         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1383         (test01): Likewise.
1384         (main): Likewise.
1385         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1386         (test01): Likewise.
1387         (main): Likewise.
1388         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1389         Likewise.
1390         * unittests/basic_string_view/operations/compare/char/1.cc
1391         (test01): Likewise.
1392         (main): Likewise.
1393         * unittests/basic_string_view/operations/compare/char/13650.cc
1394         (test01): Likewise.
1395         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1396         Likewise.
1397         (main): Likewise.
1398         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1399         Likewise.
1400         (main): Likewise.
1401         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1402         Likewise.
1403         (main): Likewise.
1404         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1405         Likewise.
1406         (main): Likewise.
1407         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1408         Likewise.
1409         (main): Likewise.
1410         * unittests/basic_string_view/operations/find/char/4.cc (main):
1411         Likewise.
1412         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1413         Likewise.
1414         (main): Likewise.
1415         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1416         Likewise.
1417         (main): Likewise.
1418         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1419         Likewise.
1420         (main): Likewise.
1421         * unittests/basic_string_view/operations/substr/char/1.cc
1422         (test01): Likewise.
1423         (main): Likewise.
1424         * unittests/basic_string_view/operators/char/2.cc (main):
1425         Likewise.
1426         * unittests/optional/assignment/1.cc (test): Likewise.
1427         * unittests/optional/assignment/2.cc (test): Likewise.
1428         * unittests/optional/assignment/3.cc (test): Likewise.
1429         * unittests/optional/assignment/4.cc (test): Likewise.
1430         * unittests/optional/assignment/5.cc (test): Likewise.
1431         * unittests/optional/assignment/6.cc (test): Likewise.
1432         * unittests/optional/assignment/7.cc (test): Likewise.
1433         * unittests/optional/cons/copy.cc (test): Likewise.
1434         * unittests/optional/cons/default.cc (test): Likewise.
1435         * unittests/optional/cons/move.cc (test): Likewise.
1436         * unittests/optional/cons/value.cc (test): Likewise.
1437         * unittests/optional/in_place.cc (test): Likewise.
1438         * unittests/optional/observers/1.cc (test): Likewise.
1439         * unittests/optional/observers/2.cc (test): Likewise.
1440
1441 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1442
1443         * tui-win.h (tui_set_var_cmd): Remove.
1444         * tui-win.c (tui_set_var_cmd): Make static.
1445
1446 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1447
1448         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1449         rbreak_command_wrapper): Remove.
1450         * symtab.c (rbreak_command_wrapper): Remove.
1451
1452 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1453
1454         * inferior.h (info_terminal_command): Remove declaration.
1455         * inflow.c (info_terminal_command): Make static.
1456
1457 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1458
1459         * inferior.c (exit_inferior_silent): Remove.
1460
1461 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1462
1463         * dictionary.c (dict_empty, mdict_empty): Remove.
1464         * dictionary.c (mdict_empty): Remove.
1465
1466 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1467
1468          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1469          (arc_insn_get_memory_offset): Likewise.
1470          (arc_insn_dump): Likewise.
1471          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1472          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1473          * dictionary.c (dict_iterator_next): Likewise.
1474          (dict_iter_match_first): Likewise.
1475          (dict_iter_match_next): Likewise.
1476          * f-lang.c (evaluate_subexp_f): Likewise.
1477          * hppa-tdep.c (hppa_read_pc): Likewise.
1478          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1479          * parse.c (write_exp_elt_msym): Likewise.
1480          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1481          * remote.c (remote_packet_size): Likewise.
1482          (remote_notif_stop_parse): Likewise.
1483          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1484          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1485          * source.c (prepare_path_for_appending): Likewise.
1486          * sparc64-linux-tdep.c
1487          (sparc64_linux_handle_segmentation_fault); Likewise.
1488          * stack.c (frame_selection_by_function_completer): Likewise.
1489
1490 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1491
1492         * completer.c (set_gdb_completion_word_break_characters):
1493         Remove.
1494
1495 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1496
1497         * dwarf-index-write.c: Include dwarf-index-write.h.
1498         * mi/mi-interp.c: Include mi/mi-interp.h.
1499
1500 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1501
1502         * aarch32-tdep.c: Include aarch32-tdep.h.
1503         * aarch32-tdep.h: Forward-declare struct target_desc.
1504
1505 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1506
1507         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1508         strerror.
1509         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1510         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1511
1512 2019-11-25  Tom de Vries  <tdevries@suse.de>
1513
1514         * contrib/words.sh: Add -c option.
1515
1516 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1517
1518         * solib.c (solib_find_1): Change int to bool.
1519         (exec_file_find): Change int to bool.
1520         (solib_find): Change int to bool.
1521         (solib_read_symbols): Change int to bool.
1522         (solib_used): Change int to bool.
1523         (solib_add): Change int to bool.
1524         (info_sharedlibrary_command): Change int to bool.
1525         (solib_contains_address_p): Change int to bool.
1526         (solib_keep_data_in_core): Change int to bool.
1527         (in_solib_dynsym_resolve_code): Change int to bool.
1528         (reload_shared_libraries_1): Change int to bool.
1529         (gdb_sysroot_changed): Change int to bool.
1530         * solib.h (solib_read_symbols): Change int to bool.
1531         (solib_contains_address_p): Change int to bool.
1532         (solib_keep_data_in_core): Change int to bool.
1533         (in_solib_dynsym_resolve_code): Change int to bool.
1534         (libpthread_name_p): Change int to bool.
1535
1536 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1537
1538         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1539         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1540         (remote_packet_max_chars): New static global.
1541         (show_remote_packet_max_chars): New function.
1542         (remote_target::putpkt_binary): Adjust to use new
1543         remote_packet_max_chars option.
1544         (remote_target::getpkt_or_notif_sane_1): Likewise.
1545         (_initialize_remote): Register new remote-packet-max-chars option.
1546
1547 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1548
1549         * m68k-linux-nat.c: Include gdbarch.h.
1550
1551 2019-11-24  Tom Tromey  <tom@tromey.com>
1552
1553         * symfile.c (read_symbols): Update.
1554         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1555         bool.
1556         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1557         (psym_lookup_symbol, psym_find_last_source_symtab)
1558         (psym_forget_cached_source_info, psym_print_stats)
1559         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1560         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1561         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1562         (psym_find_compunit_symtab_by_address)
1563         (maintenance_print_psymbols, maintenance_info_psymtabs)
1564         (maintenance_check_psymtabs): Update.
1565         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1566         bool.
1567
1568 2019-11-22  Tom Tromey  <tom@tromey.com>
1569
1570         * observable.h: Update comments.
1571
1572 2019-11-22  Tom Tromey  <tromey@adacore.com>
1573
1574         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1575         (print_ada_task_info): Don't try to fetch thread id if task is not
1576         alive.
1577
1578 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1579
1580         * ada-exp.y: Update.
1581         * ada-lang.c (sort_choices): Update.
1582         (ada_print_symbol_signature): Update.
1583         (resolve_subexp): Update.
1584         (ada_parse_renaming): Update.
1585         (ada_read_renaming_var_value): Update.
1586         (lesseq_defined_than): Update.
1587         (remove_extra_symbols): Update.
1588         (remove_irrelevant_renamings): Update.
1589         (ada_add_block_symbols): Update.
1590         (ada_collect_symbol_completion_matches): Update.
1591         (ada_is_renaming_symbol): Update.
1592         (aggregate_assign_from_choices): Update.
1593         (ada_evaluate_subexp): Update.
1594         (ada_has_this_exception_support): Update.
1595         (ada_is_non_standard_exception_sym): Update.
1596         (ada_add_exceptions_from_frame): Update.
1597         (ada_add_global_exceptions): Update.
1598         (ada_print_subexp): Update.
1599         * ax-gdb.c (gen_var_ref): Update.
1600         (gen_maybe_namespace_elt): Update.
1601         (gen_expr_for_cast): Update.
1602         (gen_expr): Update.
1603         * block.h: Update.
1604         * blockframe.c (find_pc_partial_function): Update.
1605         * breakpoint.c (print_breakpoint_location): Update.
1606         (update_static_tracepoint): Update.
1607         * btrace.c (ftrace_print_function_name): Update.
1608         (ftrace_function_switched): Update.
1609         * buildsym.c (find_symbol_in_list): Update.
1610         * c-exp.y: Update.
1611         * c-typeprint.c (c_print_typedef): Update.
1612         (c_type_print_template_args): Update.
1613         * cli/cli-cmds.c (edit_command): Update.
1614         (list_command): Update.
1615         (print_sal_location): Update.
1616         * coffread.c (patch_opaque_types): Update.
1617         (process_coff_symbol): Update.
1618         (coff_read_enum_type): Update.
1619         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1620         (convert_one_symbol): Update.
1621         (hash_symname): Update.
1622         (eq_symname): Update.
1623         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1624         * compile/compile-cplus-types.c (debug_print_scope): Update.
1625         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1626         * compile/compile-object-load.c (get_out_value_type): Update.
1627         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1628         (search_symbol_list): Update.
1629         (cp_lookup_symbol_imports_or_template): Update.
1630         * cp-support.c (overload_list_add_symbol): Update.
1631         * ctfread.c (psymtab_to_symtab): Update.
1632         * dbxread.c (cp_set_block_scope): Update.
1633         * dictionary.c (iter_match_first_hashed): Update.
1634         (iter_match_next_hashed): Update.
1635         (insert_symbol_hashed): Update.
1636         (iter_match_next_linear): Update.
1637         * dictionary.h: Update.
1638         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1639         (locexpr_describe_location_piece): Update.
1640         (locexpr_describe_location_1): Update.
1641         (locexpr_generate_c_location): Update.
1642         (loclist_describe_location): Update.
1643         (loclist_generate_c_location): Update.
1644         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1645         (read_func_scope): Update.
1646         (process_enumeration_scope): Update.
1647         (new_symbol): Update.
1648         (dwarf2_const_value): Update.
1649         (dwarf2_symbol_mark_computed): Update.
1650         * eval.c (evaluate_funcall): Update.
1651         (evaluate_subexp_standard): Update.
1652         * expprint.c (print_subexp_standard): Update.
1653         (dump_subexp_body_standard): Update.
1654         * f-valprint.c (info_common_command_for_block): Update.
1655         * findvar.c (get_hosting_frame): Update.
1656         (default_read_var_value): Update.
1657         * go-lang.c (go_symbol_package_name): Update.
1658         * guile/scm-block.c (bkscm_print_block_smob): Update.
1659         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1660         (gdbscm_symbol_name): Update.
1661         (gdbscm_symbol_linkage_name): Update.
1662         (gdbscm_symbol_print_name): Update.
1663         * infcall.c (get_function_name): Update.
1664         * infcmd.c (jump_command): Update.
1665         (finish_command): Update.
1666         * infrun.c (insert_exception_resume_breakpoint): Update.
1667         * linespec.c (canonicalize_linespec): Update.
1668         (create_sals_line_offset): Update.
1669         (convert_linespec_to_sals): Update.
1670         (complete_label): Update.
1671         (find_label_symbols_in_block): Update.
1672         * m2-typeprint.c (m2_print_typedef): Update.
1673         * mdebugread.c (mdebug_reg_to_regnum): Update.
1674         (parse_symbol): Update.
1675         (mylookup_symbol): Update.
1676         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1677         (list_args_or_locals): Update.
1678         * objc-lang.c (compare_selectors): Update.
1679         (info_selectors_command): Update.
1680         (compare_classes): Update.
1681         (info_classes_command): Update.
1682         (find_imps): Update.
1683         * p-typeprint.c (pascal_print_typedef): Update.
1684         * printcmd.c (build_address_symbolic): Update.
1685         (info_address_command): Update.
1686         (print_variable_and_value): Update.
1687         * python/py-framefilter.c (extract_sym): Update.
1688         (py_print_single_arg): Update.
1689         * python/py-symbol.c (sympy_str): Update.
1690         (sympy_get_name): Update.
1691         (sympy_get_linkage_name): Update.
1692         * python/python.c (gdbpy_rbreak): Update.
1693         * record-btrace.c (btrace_get_bfun_name): Update.
1694         (btrace_call_history): Update.
1695         * rust-lang.c (rust_print_typedef): Update.
1696         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1697         * stabsread.c (stab_reg_to_regnum): Update.
1698         (define_symbol): Update.
1699         (read_enum_type): Update.
1700         (common_block_end): Update.
1701         (cleanup_undefined_types_1): Update.
1702         (scan_file_globals): Update.
1703         * stack.c (print_frame_arg): Update.
1704         (print_frame_args): Update.
1705         (find_frame_funname): Update.
1706         (info_frame_command_core): Update.
1707         (iterate_over_block_locals): Update.
1708         (print_block_frame_labels): Update.
1709         (do_print_variable_and_value): Update.
1710         (iterate_over_block_arg_vars): Update.
1711         (return_command): Update.
1712         * symmisc.c (dump_symtab_1): Update.
1713         (print_symbol): Update.
1714         * symtab.c (eq_symbol_entry): Update.
1715         (symbol_cache_dump): Update.
1716         (lookup_language_this): Update.
1717         (find_pc_sect_line): Update.
1718         (skip_prologue_sal): Update.
1719         (symbol_search::compare_search_syms): Update.
1720         (treg_matches_sym_type_name): Update.
1721         (search_symbols): Update.
1722         (print_symbol_info): Update.
1723         (rbreak_command): Update.
1724         (completion_list_add_symbol): Update.
1725         (find_gnu_ifunc): Update.
1726         (get_symbol_address): Update.
1727         (search_module_symbols): Update.
1728         (info_module_subcommand): Update.
1729         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1730         (SYMBOL_LINKAGE_NAME): Remove.
1731         (SYMBOL_DEMANGLED_NAME): Remove.
1732         (SYMBOL_PRINT_NAME): Remove.
1733         (SYMBOL_SEARCH_NAME): Remove.
1734         * tracepoint.c (set_traceframe_context): Update.
1735         (validate_actionline): Update.
1736         (collection_list::collect_symbol): Update.
1737         (encode_actions_1): Update.
1738         (info_scope_command): Update.
1739         (print_one_static_tracepoint_marker): Update.
1740         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1741         * valops.c (address_of_variable): Update.
1742         (find_overload_match): Update.
1743         (find_oload_champ): Update.
1744
1745 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1746
1747         * ada-lang.c (ada_lookup_simple_minsym): Update.
1748         (ada_collect_symbol_completion_matches): Update.
1749         * ada-tasks.c (read_atcb): Update.
1750         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1751         (amd64_windows_skip_trampoline_code): Update.
1752         * arm-tdep.c (skip_prologue_function): Update.
1753         (arm_skip_stack_protector): Update.
1754         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1755         (arm_wince_skip_main_prologue): Update.
1756         * ax-gdb.c (gen_expr): Update.
1757         * block.c (call_site_for_pc): Update.
1758         * blockframe.c (find_pc_partial_function): Update.
1759         * breakpoint.c (set_breakpoint_location_function): Update.
1760         * btrace.c (ftrace_print_function_name): Update.
1761         (ftrace_function_switched): Update.
1762         * c-valprint.c (print_unpacked_pointer): Update.
1763         * coffread.c (coff_symfile_read): Update.
1764         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1765         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1766         * dwarf-index-write.c (write_psymbols): Update.
1767         * dwarf2loc.c (call_site_to_target_addr): Update.
1768         (func_verify_no_selftailcall): Update.
1769         (tailcall_dump): Update.
1770         (call_site_find_chain_1): Update.
1771         (dwarf_expr_reg_to_entry_parameter): Update.
1772         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1773         * eval.c (evaluate_funcall): Update.
1774         (evaluate_subexp_standard): Update.
1775         (evaluate_subexp_for_sizeof): Update.
1776         * expprint.c (print_subexp_standard): Update.
1777         (dump_subexp_body_standard): Update.
1778         * frame.c (get_prev_frame_always_1): Update.
1779         * frv-tdep.c (frv_skip_main_prologue): Update.
1780         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1781         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1782         (gnuv3_get_typename_from_type_info): Update.
1783         (gnuv3_skip_trampoline): Update.
1784         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1785         * i386-tdep.c (i386_skip_main_prologue): Update.
1786         (i386_pe_skip_trampoline_code): Update.
1787         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1788         * infcall.c (get_function_name): Update.
1789         * linespec.c (minsym_found): Update.
1790         * linux-fork.c (info_checkpoints_command): Update.
1791         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1792         (m32c_m16c_pointer_to_address): Update.
1793         * maint.c (maintenance_translate_address): Update.
1794         * minsyms.c (add_minsym_to_hash_table): Update.
1795         (add_minsym_to_demangled_hash_table): Update.
1796         (lookup_minimal_symbol_mangled): Update.
1797         (lookup_minimal_symbol_demangled): Update.
1798         (lookup_minimal_symbol_linkage): Update.
1799         (lookup_minimal_symbol_text): Update.
1800         (lookup_minimal_symbol_by_pc_name): Update.
1801         (minimal_symbol_is_less_than): Update.
1802         (compact_minimal_symbols): Update.
1803         (build_minimal_symbol_hash_tables): Update.
1804         (find_solib_trampoline_target): Update.
1805         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1806         (mips_skip_pic_trampoline_code): Update.
1807         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1808         * objc-lang.c (info_selectors_command): Update.
1809         (info_classes_command): Update.
1810         (find_methods): Update.
1811         (find_imps): Update.
1812         * p-valprint.c (pascal_val_print): Update.
1813         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1814         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1815         * printcmd.c (build_address_symbolic): Update.
1816         (info_symbol_command): Update.
1817         * psymtab.c (psymbol_name_matches): Update.
1818         (match_partial_symbol): Update.
1819         (lookup_partial_symbol): Update.
1820         (print_partial_symbols): Update.
1821         (sort_pst_symbols): Update.
1822         (maintenance_check_psymtabs): Update.
1823         * python/py-framefilter.c (py_print_frame): Update.
1824         * python/python.c (gdbpy_rbreak): Update.
1825         * record-btrace.c (btrace_get_bfun_name): Update.
1826         (btrace_call_history): Update.
1827         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1828         (rs6000_skip_trampoline_code): Update.
1829         * sol-thread.c (info_cb): Update.
1830         * stabsread.c (scan_file_globals): Update.
1831         * stack.c (find_frame_funname): Update.
1832         (info_frame_command_core): Update.
1833         * symmisc.c (dump_msymbols): Update.
1834         * symtab.c (symbol_natural_name): Rename to..,
1835         (general_symbol_info::natural_name): ...this.
1836         (symbol_demangled_name): Rename to...
1837         (general_symbol_info::demangled_name): ...this.
1838         (symbol_search_name): Rename to...
1839         (general_symbol_info::search_name): ...this.
1840         (symbol_matches_search_name): Update.
1841         (find_pc_sect_line): Update.
1842         (skip_prologue_sal): Update.
1843         (search_symbols): Update.
1844         (print_msymbol_info): Update.
1845         (rbreak_command): Update.
1846         (completion_list_add_msymbol): Update.
1847         (completion_list_objc_symbol): Update.
1848         (get_msymbol_address): Update.
1849         * symtab.h (struct general_symbol_info): Add member functions
1850         natural_name (), linkage_name (), print_name (), demangled_name (),
1851         and search_name ().
1852         (SYMBOL_NATURAL_NAME): Update.
1853         (symbol_natural_name): Move to a member function on general_symbol_info.
1854         (SYMBOL_DEMANGLED_NAME): Update.
1855         (symbol_demangled_name): Move to a member function on
1856         general_symbol_info.
1857         (SYMBOL_SEARCH_NAME): Update.
1858         (symbol_search_name): Move to a member function on general_symbol_info.
1859         (MSYMBOL_NATURAL_NAME): Remove.
1860         (MSYMBOL_LINKAGE_NAME): Remove.
1861         (MSYMBOL_PRINT_NAME): Remove.
1862         (MSYMBOL_DEMANGLED_NAME): Remove.
1863         (MSYMBOL_SEARCH_NAME): Remove.
1864         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1865
1866 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1867
1868         * symtab.c (create_demangled_names_hash): Use per_bfd->
1869         minimal_symbol_count for computing the initial size, if greater
1870         than our default size.
1871
1872 2019-11-22  Tom de Vries  <tdevries@suse.de>
1873
1874         * contrib/words.sh: Improve words extraction.
1875
1876 2019-11-22  Tom de Vries  <tdevries@suse.de>
1877
1878         * contrib/words.sh: Combine sed invocations.
1879
1880 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1881
1882         * Makefile.in: Update.
1883         * demangle.c: Rename to...
1884         * gdb-demangle.c: ..this.
1885         (is_cplus_marker): Change return type to bool.
1886         (_initialize_demangler): Rename to...
1887         (_initialize_gdb_demangle): ...this.
1888         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1889         * symtab.h (demangle): Remove declaration; instead include
1890         gdb-demangle.h.
1891
1892 2019-11-21  Tom Tromey  <tromey@adacore.com>
1893
1894         * gdbsupport/format.c (format_pieces): Parse %I64d.
1895         * unittests/format_pieces-selftests.c (test_windows_formats): New
1896         function.
1897         (run_tests): Call it.
1898
1899 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1900
1901         Byte reverse display of variables with DW_END_big, DW_END_little
1902         (DW_AT_endianity) dwarf attributes if different than the native
1903         byte order.
1904         * ada-lang.c (ada_value_binop):
1905         Use type_byte_order instead of gdbarch_byte_order.
1906         * ada-valprint.c (printstr):
1907         (ada_val_print_string):
1908         * ada-lang.c (value_pointer):
1909         (ada_value_binop):
1910         Use type_byte_order instead of gdbarch_byte_order.
1911         * c-lang.c (c_get_string):
1912         Use type_byte_order instead of gdbarch_byte_order.
1913         * c-valprint.c (c_val_print_array):
1914         Use type_byte_order instead of gdbarch_byte_order.
1915         * cp-valprint.c (cp_print_class_member):
1916         Use type_byte_order instead of gdbarch_byte_order.
1917         * dwarf2loc.c (rw_pieced_value):
1918         Use type_byte_order instead of gdbarch_byte_order.
1919         * dwarf2read.c (read_base_type): Handle DW_END_big,
1920         DW_END_little
1921         * f-lang.c (f_get_encoding):
1922         Use type_byte_order instead of gdbarch_byte_order.
1923         * findvar.c (default_read_var_value):
1924         Use type_byte_order instead of gdbarch_byte_order.
1925         * gdbtypes.c (check_types_equal):
1926         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1927         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1928         and TYPE_ENDIANITY_LITTLE if set.
1929         (type_byte_order): new function.
1930         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1931         (struct main_type) <flag_endianity_not_default>:
1932         New field.
1933         (type_byte_order): New function.
1934         * infcmd.c (default_print_one_register_info):
1935         Use type_byte_order instead of gdbarch_byte_order.
1936         * p-lang.c (pascal_printstr):
1937         Use type_byte_order instead of gdbarch_byte_order.
1938         * p-valprint.c (pascal_val_print):
1939         Use type_byte_order instead of gdbarch_byte_order.
1940         * printcmd.c (print_scalar_formatted):
1941         Use type_byte_order instead of gdbarch_byte_order.
1942         * solib-darwin.c (darwin_current_sos):
1943         Use type_byte_order instead of gdbarch_byte_order.
1944         * solib-svr4.c (solib_svr4_r_ldsomap):
1945         Use type_byte_order instead of gdbarch_byte_order.
1946         * stap-probe.c (stap_modify_semaphore):
1947         Use type_byte_order instead of gdbarch_byte_order.
1948         * target-float.c (target_float_same_format_p):
1949         Use type_byte_order instead of gdbarch_byte_order.
1950         * valarith.c (scalar_binop):
1951         (value_bit_index):
1952         Use type_byte_order instead of gdbarch_byte_order.
1953         * valops.c (value_cast):
1954         Use type_byte_order instead of gdbarch_byte_order.
1955         * valprint.c (generic_emit_char):
1956         (generic_printstr):
1957         (val_print_string):
1958         Use type_byte_order instead of gdbarch_byte_order.
1959         * value.c (unpack_long):
1960         (unpack_bits_as_long):
1961         (unpack_value_bitfield):
1962         (modify_field):
1963         (pack_long):
1964         (pack_unsigned_long):
1965         Use type_byte_order instead of gdbarch_byte_order.
1966         * findvar.c (unsigned_pointer_to_address):
1967         (signed_pointer_to_address):
1968         (unsigned_address_to_pointer):
1969         (address_to_signed_pointer):
1970         (default_read_var_value):
1971         (default_value_from_register):
1972         Use type_byte_order instead of gdbarch_byte_order.
1973         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1974         Use type_byte_order instead of gdbarch_byte_order.
1975         * riscv-tdep.c (riscv_print_one_register_info):
1976         Use type_byte_order instead of gdbarch_byte_order.
1977
1978 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1979
1980         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1981         (current_ui_gdb_stdin_ptr): Likewise.
1982         (current_ui_gdb_stderr_ptr): Likewise.
1983         (current_ui_gdb_stdlog_ptr): Likewise.
1984         (current_ui_current_uiout_ptr): Likewise.
1985         (gen_ret_current_ui_field_ptr): Remove.
1986
1987 2019-11-21  Tom de Vries  <tdevries@suse.de>
1988
1989         PR gdb/24956
1990         * cli/cli-script.c (execute_control_command): Only switch to
1991         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1992
1993 2019-11-19  Tom Tromey  <tom@tromey.com>
1994
1995         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1996         Now static.  Change type of "name".
1997         (tui_set_win_height_command): Don't copy "arg".
1998         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1999         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2000
2001 2019-11-19  Ali Tamur <tamur@google.com>
2002
2003         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2004         "if (attr != nullptr)".
2005         (dwarf2_find_base_address): Likewise.
2006         (dwarf2_build_include_psymtabs): Likewise.
2007         (read_cutu_die_from_dwo): Likewise.
2008         (read_func_scope): Likewise.
2009         (read_call_site_scope): Likewise.
2010         (dwarf2_get_pc_bounds): Likewise.
2011         (dwarf2_record_block_ranges): Likewise.
2012         (dwarf2_add_field): Likewise.
2013         (dwarf2_add_member_fn): Likewise.
2014         (read_structure_type): Likewise.
2015         (read_enumeration_type): Likewise.
2016         (read_array_type): Likewise.
2017         (read_array_order): Likewise.
2018         (read_set_type): Likewise.
2019         (read_common_block): Likewise.
2020         (read_tag_reference_type): Likewise.
2021         (read_tag_string_type): Likewise.
2022         (read_subroutine_type): Likewise.
2023         (read_base_type): Likewise.
2024         (read_subrange_type): Likewise.
2025         (new_symbol): Likewise.
2026         (prepare_one_comp_unit): Likewise.
2027
2028 2019-11-19  Tom Tromey  <tromey@adacore.com>
2029
2030         * windows-nat.c (windows_nat_target::attach): Include GetLastError
2031         result in error when DebugActiveProcess fails.
2032
2033 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
2034             Pedro Alves  <palves@redhat.com>
2035
2036         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2037         * target.c (target_stack::push): Call 'unpush' if there's a
2038         target on top of the stack.
2039
2040 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2041
2042         * python/py-block.c (blpy_dealloc): Call tp_free.
2043         (blpy_block_syms_dealloc): Likewise.
2044         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2045         * python/py-inferior.c (infpy_dealloc): Likewise.
2046         * python/py-lazy-string.c (stpy_dealloc): Likewise.
2047         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2048         * python/py-symbol.c (sympy_dealloc): Likewise.
2049         * python/py-symtab.c (stpy_dealloc): Likewise.
2050         * python/py-type.c (typy_iterator_dealloc): Likewise.
2051
2052 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
2053
2054         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2055         constructor instead of using a class initializer.
2056
2057 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2058
2059         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2060         * configure: Regenerate.
2061         * configure.ac: Don't source common.host.
2062         * gdbsupport/common.host: Remove.
2063         * gdbsupport/mingw-strerror.c: Remove.
2064         * gdbsupport/posix-strerror.c: Rename to...
2065         * gdbsupport/safe-strerror.c: ...this.
2066
2067 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2068
2069         * maint.c (scoped_command_stats::print_time): Use localtime_r
2070         instead of localtime (provided through gnulib if necessary).
2071         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2072         of ctime.
2073
2074 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2075
2076         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2077         avoid compile errors.
2078
2079 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2080
2081         * config.in: Regenerate.
2082         * configure: Regenerate.
2083         * gdbsupport/common.m4: No longer check for strerror_r.
2084         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2085         POSIX version of strerror_r, now that gnulib provides it if
2086         necessary.
2087
2088 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
2089
2090         * README (`configure' options): Update.
2091
2092 2019-11-14  Tom Tromey  <tromey@adacore.com>
2093
2094         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2095         expected type for the RHS if the LHS is a convenience variable.
2096
2097 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
2098
2099         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2100         Provide explicit default and copy constructor.
2101
2102 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2103
2104         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2105         only call Py_INCREF (newbp) in the bppy_pending_object case.
2106
2107 2019-11-13  Tom Tromey  <tromey@adacore.com>
2108
2109         PR build/25182:
2110         * psympriv.h (partial_symbol): Remove static assert.
2111         * symtab.h (general_symbol_info, symbol): Remove static assert.
2112
2113 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2114
2115         * gdbsupport/format.c (format_pieces::format_pieces): Support
2116         printf 'z' size modifier.
2117         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2118         * printcmd.c (ui_printf):  Handle size_t_arg.
2119         * ui-out.c (ui_out::vmessage): Likewise.
2120         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2121         function.
2122         (run_tests): Call test_format_int_sizes.
2123
2124 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2125
2126         * ada-exp.y (write_ambiguous_var): Update.
2127         * buildsym.c (add_symbol_to_list): Update.
2128         * dwarf2read.c (read_variable): Update.
2129         (new_symbol): Update.
2130         * jit.c (finalize_symtab): Update.
2131         * language.c (language_alloc_type_symbol): Update.
2132         * symtab.c (fixup_symbol_section): Update.
2133         (initialize_objfile_symbol_1): Move code to...
2134         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2135         (allocate_symbol): Update.
2136         (allocate_template_symbol): Update.
2137         (get_symbol_address): Update.
2138         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2139         of having as a field, and add a constructor.
2140         (SYMBOL_VALUE): Update.
2141         (SYMBOL_VALUE_ADDRESS): Update.
2142         (SET_SYMBOL_VALUE_ADDRESS): Update.
2143         (SYMBOL_VALUE_BYTES): Update.
2144         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2145         (SYMBOL_BLOCK_VALUE): Update.
2146         (SYMBOL_VALUE_CHAIN): Update.
2147         (SYMBOL_LANGUAGE): Update.
2148         (SYMBOL_SECTION): Update.
2149         (SYMBOL_OBJ_SECTION): Update.
2150         (SYMBOL_SET_LANGUAGE): Update.
2151         (SYMBOL_SET_LINKAGE_NAME): Update.
2152         (SYMBOL_SET_NAMES): Update.
2153         (SYMBOL_NATURAL_NAME): Update.
2154         (SYMBOL_LINKAGE_NAME): Update.
2155         (SYMBOL_DEMANGLED_NAME): Update.
2156         (SYMBOL_SEARCH_NAME): Update.
2157         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2158         (struct symbol): Update.
2159         (struct template_symbol): Update.
2160         (struct rust_vtable_symbol): Update.
2161         * xcoffread.c (SYMBOL_DUP): Update.
2162
2163 2019-11-12  Tom Tromey  <tom@tromey.com>
2164
2165         * tui/tui-layout.c (show_layout): Set current_layout.
2166         (show_source_disasm_command, show_data)
2167         (show_source_or_disasm_and_command): Don't set current_layout.
2168
2169 2019-11-12  Tom Tromey  <tom@tromey.com>
2170
2171         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2172
2173 2019-11-12  Tom Tromey  <tom@tromey.com>
2174
2175         * tui/tui-win.c (resize_message): New global.
2176         (show_tui_resize_message): New function.
2177         (tui_async_resize_screen): Print message if requested.
2178         (_initialize_tui_win): Add tui-resize-message setting.
2179         * NEWS: Add entry for new commands.
2180
2181 2019-11-11  Tom Tromey  <tom@tromey.com>
2182
2183         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2184         functions.
2185
2186 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2187
2188         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2189
2190 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2191
2192         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2193         function.
2194         * python/python-internal.h (gdbpy_lookup_static_symbols):
2195         Declare new function.
2196         * python/python.c (python_GdbMethods): Add
2197         gdb.lookup_static_symbols method.
2198         * NEWS: Mention gdb.lookup_static_symbols.
2199
2200 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2201
2202         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2203         static block of current object file first.  Also fix typo in
2204         header comment.
2205
2206 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2207
2208         * stack.c (set_last_displayed_sal): Delete.
2209         (last_displayed_sal_valid): Delete.
2210         (last_displayed_pspace): Delete.
2211         (last_displayed_addr): Delete.
2212         (last_displayed_symtab): Delete.
2213         (last_displayed_line): Delete.
2214         (class last_displayed_symtab_info_type): New.
2215         (last_displayed_symtab_info): New static global variable.
2216         (print_frame_info): Call methods on last_displayed_symtab_info.
2217         (clear_last_displayed_sal): Update header comment, and make use of
2218         last_displayed_symtab_info.
2219         (last_displayed_sal_is_valid): Likewise.
2220         (get_last_displayed_pspace): Likewise.
2221         (get_last_displayed_addr): Likewise.
2222         (get_last_displayed_symtab): Likewise.
2223         (get_last_displayed_line): Likewise.
2224         (get_last_displayed_sal): Likewise.
2225         * stack.h (clear_last_displayed_sal): Update header comment.
2226         (last_displayed_sal_is_valid): Likewise.
2227         (get_last_displayed_pspace): Likewise.
2228         (get_last_displayed_addr): Likewise.
2229         (get_last_displayed_symtab): Likewise.
2230         (get_last_displayed_line): Likewise.
2231         (get_last_displayed_sal): Likewise.
2232
2233 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2234
2235         * stack.c (frame_show_address): Convert return type to bool.
2236         * stack.h (frame_show_address): Likewise, and update header
2237         comment.
2238
2239 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2240
2241         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2242         * unittests/vec-utils-selftests.c: New file.
2243         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2244
2245 2019-11-10  Tom Tromey  <tom@tromey.com>
2246
2247         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2248         (tui_highlight_win): Likewise.
2249         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2250         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2251         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2252         Don't set can_highlight.
2253
2254 2019-11-10  Tom Tromey  <tom@tromey.com>
2255
2256         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2257         Remove unused declaration.
2258
2259 2019-11-08  Tom Tromey  <tromey@adacore.com>
2260
2261         * top.c (read_command_file): Update.
2262         (command_line_input): Make return type const.
2263         * python/py-gdb-readline.c: Update.
2264         * linespec.c (decode_line_2): Update.
2265         * defs.h (command_line_input): Make return type const.
2266         * cli/cli-script.c (read_next_line): Make return type const.
2267         * ada-lang.c (get_selections): Update.
2268
2269 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2270
2271         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2272         * mi/mi-main.c (output_cores): Likewise.
2273         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2274         (linux_xfer_osdata_modules): Likewise.
2275         * remote.c (register_remote_support_xml): Likewise.
2276         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2277         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2278
2279 2019-11-06  Tom Tromey  <tom@tromey.com>
2280
2281         * tui/tui-interp.c: Don't include readline.h.
2282         * tui/tui-hooks.c: Don't include readline.h.
2283         * symmisc.c: Include tilde.h, not readline.h.
2284         * symfile.c: Include tilde.h, not readline.h.
2285         * source.c: Include tilde.h, not readline.h.
2286         * solib.c: Include tilde.h, not readline.h.
2287         * psymtab.c: Include tilde.h, not readline.h.
2288         * exec.c: Include tilde.h, not readline.h.
2289         * corelow.c: Include tilde.h, not readline.h.
2290         * cli/cli-dump.c: Include tilde.h, not readline.h.
2291         * cli/cli-cmds.c: Don't include readline.h.
2292
2293 2019-11-05  Tom Tromey  <tom@tromey.com>
2294
2295         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2296         (tui_disassemble): Set addr_size.
2297         (tui_disasm_window::set_contents): Use addr_size.
2298
2299 2019-11-05  Tom Tromey  <tom@tromey.com>
2300
2301         * rust-lang.c (rust_language_defn): Update.
2302         * python/py-value.c (valpy_string): Call c_get_string.
2303         * p-lang.c (pascal_language_defn): Update.
2304         * opencl-lang.c (opencl_language_defn): Update.
2305         * objc-lang.c (objc_language_defn): Update.
2306         * m2-lang.c (m2_language_defn): Update.
2307         * language.c (unknown_language_defn, auto_language_defn): Update.
2308         (default_get_string): Remove.
2309         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2310         * go-lang.c (go_language_defn): Update.
2311         * f-lang.c (f_language_defn): Update.
2312         * d-lang.c (d_language_defn): Update.
2313         * c-lang.c (c_language_defn, cplus_language_defn)
2314         (asm_language_defn, minimal_language_defn): Update.
2315         * ada-lang.c (ada_language_defn): Update.
2316         * language.h (struct language_defn) <la_get_string>: Remove.
2317         (LA_GET_STRING): Remove.
2318         (default_get_string): Don't declare.
2319
2320 2019-11-05  Tom Tromey  <tom@tromey.com>
2321
2322         * tui/tui-source.h (struct tui_source_window): Inline
2323         constructor.  Remove destructor.
2324         <style_changed, m_observable>: Move to superclass.
2325         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2326         (struct tui_source_window_base): Move private members to end.
2327         <style_changed, m_observable>: Move from tui_source_window.
2328         * tui/tui-winsource.c (tui_copy_source_line): Move from
2329         tui-source.c.  Rename from copy_source_line.  Add special handling
2330         for negative line number.
2331         (tui_source_window_base::style_changed): Move from
2332         tui_source_window.
2333         (tui_source_window_base): Register observer.
2334         (~tui_source_window_base): New.
2335         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2336         rename.
2337         (tui_source_window::set_contents): Use tui_copy_source_line.
2338         (tui_source_window::tui_source_window): Move to tui-source.h.
2339         (tui_source_window::~tui_source_window): Remove.
2340         (tui_source_window::style_changed): Move to superclass.
2341         * tui/tui-disasm.c (tui_disassemble): Create string file with
2342         styling, when possible.  Add "addr_size" parameter.
2343         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2344         Don't compute maximum size.
2345         (len_without_escapes): New function
2346
2347 2019-11-05  Tom Tromey  <tom@tromey.com>
2348
2349         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2350         std::string.
2351         * tui/tui-winsource.c (tui_show_source_line): Update.
2352         * tui/tui-source.c (tui_source_window::set_contents): Update.
2353         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2354
2355 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2356
2357         * symtab.h (gdb_static_assert): Put && operator at the beginning
2358         of the line instead of the end.
2359
2360 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2361
2362         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2363         and sizeof (symbol).
2364         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2365
2366 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2367
2368         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2369         * configure.host: Mark *-*-solaris2.10* obsolete.
2370         * configure.tgt: Mark Solaris < 11 obsolete.
2371         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2372         Update target triplet.
2373
2374 2019-11-01  Tom Tromey  <tromey@adacore.com>
2375
2376         * utils.c (print_sys_errmsg): Simplify.
2377
2378 2019-11-01  Tom Tromey  <tromey@adacore.com>
2379
2380         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2381
2382 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2383
2384         * configure: Regenerate.
2385         * configure.ac: Remove check for strerror_r.
2386         * gdbsupport/common.m4: Check for strerror_r.
2387
2388 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2389
2390         PR gdb/25124
2391
2392         * arm-tdep.c (arm_per_objfile): Rename to ...
2393         (arm_per_bfd): ... this.
2394         (arm_objfile_data_key): Rename to ...
2395         (arm_bfd_data_key): ... this.
2396         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2397         data.
2398         (arm_record_special_symbol): Likewise.
2399
2400 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2401
2402         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2403         end.
2404         * c-typeprint.c (c_print_typedef): Likewise.
2405         * f-typeprint.c (f_print_typedef): Likewise.
2406         * m2-typeprint.c (m2_print_typedef): Likewise.
2407         * p-typeprint.c (pascal_print_typedef): Likewise.
2408         * rust-lang.c (rust_print_typedef): Likewise.
2409         * symtab.c (print_symbol_info): Print a newline after calling
2410         typedef_print.
2411
2412 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2413
2414         * symtab.c (info_module_cmdlist): New variable.
2415         (info_module_command): New function.
2416         (search_module_symbols): New function.
2417         (info_module_subcommand): New function.
2418         (struct info_modules_var_func_options): New struct.
2419         (info_modules_var_func_options_defs): New variable.
2420         (make_info_modules_var_func_options_def_group): New function.
2421         (info_module_functions_command): New function.
2422         (info_module_variables_command): New function.
2423         (info_module_var_func_command_completer): New function.
2424         (_initialize_symtab): Register new 'info module functions' and
2425         'info module variables' commands.
2426         * symtab.h (typedef symbol_search_in_module): New typedef.
2427         (search_module_symbols): Declare new function.
2428         * NEWS: Mention new commands.
2429
2430 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2431
2432         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2433         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2434         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2435         MODULES_DOMAIN.
2436         (scan_partial_symbols): Only create partial module symbols for non
2437         declarations.
2438         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2439         and MODULES_DOMAIN.
2440         * symtab.c (search_domain_name): Likewise.
2441         (search_symbols): Likewise.
2442         (print_symbol_info): Likewise.
2443         (symtab_symbol_info): Likewise.
2444         (info_modules_command): New function.
2445         (_initialize_symtab): Register 'info modules' command.
2446         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2447         * NEWS: Mention new 'info modules' command.
2448
2449 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2450
2451         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2452         and $_gdb_maint_setting_str.
2453
2454 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2455
2456         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2457         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2458         (str_value_from_setting, gdb_setting_str_internal_fn)
2459         (gdb_maint_setting_str_internal_fn): New functions.
2460         (_initialize_cli_cmds): Define the new convenience functions.
2461         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2462         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2463
2464 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2465
2466         * agent.c (set_can_use_agent): When the setting is turned on,
2467         look up agent symbols if we don't have them yet.
2468         (agent_new_objfile): Don't look up agent symbols when the agent
2469         setting is off.
2470
2471 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2472
2473         * config.in: Regenerate.
2474
2475 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2476
2477         * configure: Regenerate.
2478         * configure.ac: Check for strerror_r.
2479         * gdbsupport/common-utils.h (safe_strerror): Change return value
2480         to const char * and document that this function is now threadsafe.
2481         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2482         thread_local and call strerror_r, if available.
2483         * utils.c (perror_string): Update.
2484         (print_sys_errmsg): Update.
2485
2486 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2487
2488         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2489         objfile_key.
2490         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2491         objfile to fetch per-bfd data.
2492         (arm_find_exidx_entry): Likewise.
2493
2494 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2495
2496         * gdbsupport/agent.c (debug_agent): Change type to bool.
2497         (use_agent): Likewise.
2498         (all_agent_symbols_look_up): Likewise.
2499         (agent_loaded_p): Change return value to bool.
2500         (agent_look_up_symbols): Update.
2501         (agent_capability_check): Change return value to bool.
2502         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2503         (debug_agent): Change type to bool.
2504         (use_agent): Likewise.
2505         (agent_capability_check): Change return value to bool.
2506
2507 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2508
2509         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2510         (build_minimal_symbol_hash_tables): Code to clear the table moved
2511         to clear_minimal_symbol_hash_tables.
2512         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2513         when needed.
2514
2515 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2516
2517         * infcmd.c: Remove includes.
2518         * infrun.c: Remove includes.
2519
2520 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2521
2522         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2523         (grow_vect): Remove declaration.
2524         (ada_type_of_array): Remove declaration.
2525         (ada_update_initial_language): Remove declaration.
2526         (ada_fold_name): Remove declaration.
2527         (ada_fill_in_ada_prototype): Remove declaration.
2528         (user_select_syms): Remove declaration.
2529         (get_selections): Remove declaration.
2530         (ada_tag_type): Remove declaration.
2531         (ada_value_tag): Remove declaration.
2532         (ada_is_others_clause): Remove declaration.
2533         (ada_in_variant): Remove declaration.
2534         (ada_value_struct_elt): Remove declaration.
2535         (ada_attribute_name): Remove declaration.
2536         (ada_system_address_type): Remove declaration.
2537         * ada-lang.c (ada_watch_location_expression): Make static.
2538         (GROW_VECT): Move here from ada-lang.h.
2539         (grow_vect): Make static.
2540         (ada_update_initial_language): Make static.
2541         (ada_fold_name): Make static.
2542         (ada_type_of_array): Make static.
2543         (encoded_ordered_before): Move up.
2544         (sort_choices): Move up.
2545         (print_signatures): Move up.
2546         (ada_print_symbol_signature): Move up.
2547         (get_selections): Move up and make static.
2548         (user_select_syms): Move up and make static.
2549         (ada_value_struct_elt): Move up and make static.
2550         (ada_tag_type): Make static.
2551         (ada_value_tag): Make static.
2552         (ada_is_others_clause): Make static.
2553         (ada_in_variant): Make static.
2554         (ada_attribute_name): Make static.
2555
2556 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2557
2558         * ada-lang.c: Remove includes.
2559         * ada-typeprint.c: Remove includes.
2560         * ada-valprint.c: Remove includes.
2561
2562 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2563
2564         * addrmap.c: Add static assertions of type size, moved from
2565         _initialize_addrmap.
2566         (_initialize_addrmap): Remove.
2567
2568 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2569
2570         * coffread.c (record_minimal_symbol): Update.
2571         (process_coff_symbol): Update.
2572         * dbxread.c (read_dbx_symtab): Update.
2573         * dwarf2read.c (add_partial_symbol): Update.
2574         (fixup_go_packaging): Update.
2575         (load_partial_dies): Update.
2576         (new_symbol): Update.
2577         * elfread.c (record_minimal_symbol): Change signature to use
2578         gdb::string_view instead of name+len.
2579         (elf_symtab_read): Update.
2580         (elf_rel_plt_read): Update.
2581         * mdebugread.c (parse_partial_symbols): Update.
2582         (handle_psymbol_enumerators): Update.
2583         (new_symbol): Update.
2584         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2585         to use gdb::string_view instead of name+len.
2586         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2587         * psympriv.h (add_psymbol_to_list): Likewise.
2588         * psymtab.c (add_psymbol_to_bcache): Likewise.
2589         (add_psymbol_to_list): Likewise.
2590         * stabsread.c (define_symbol): Update.
2591         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2592         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2593         (symbol_set_names): Likewise.
2594         * xcoffread.c (scan_xcoff_symtab): Update.
2595
2596 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2597
2598         * symtab.h (symbol_set_names): Document that copy_name must be
2599         set to true for non-nullterminated strings.
2600         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2601         linkage_name if the entry was not found and we need to demangle.
2602
2603 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2604
2605         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2606         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2607         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2608         * gdbsupport/gdb_binary_search.h: New file.
2609
2610 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2611
2612         * NEWS: Mention new --with-system-gdbinit-dir option.
2613         * config.in: Regenerate.
2614         * configure: Regenerate.
2615         * configure.ac: Add new option --with-system-gdbinit-dir.
2616         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2617         for a ".gdb" suffix.
2618         * main.c (get_init_files): Change system_gdbinit argument to
2619         a vector and return the files in SYSTEM_GDBINIT_DIR in
2620         addition to SYSTEM_GDBINIT.
2621         (captured_main_1): Update.
2622         (print_gdb_help): Update.
2623         * top.c (print_gdb_configuration): Also print the value of
2624         SYSTEM_GDBINIT_DIR.
2625
2626 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2627
2628         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2629         that takes gdb::string_view arguments.
2630
2631 2019-10-26  Tom de Vries  <tdevries@suse.de>
2632
2633         * aarch64-linux-tdep.c: Fix typos in comments.
2634         * aarch64-tdep.c: Same.
2635         * ada-lang.c: Same.
2636         * amd64-nat.c: Same.
2637         * arc-tdep.c: Same.
2638         * arch/aarch64-insn.c: Same.
2639         * block.c: Same.
2640         * breakpoint.h: Same.
2641         * btrace.h: Same.
2642         * c-varobj.c: Same.
2643         * cli/cli-decode.c: Same.
2644         * cli/cli-script.c: Same.
2645         * cli/cli-utils.h: Same.
2646         * coff-pe-read.c: Same.
2647         * coffread.c: Same.
2648         * compile/compile-cplus-symbols.c: Same.
2649         * compile/compile-object-run.c: Same.
2650         * completer.c: Same.
2651         * corelow.c: Same.
2652         * cp-support.c: Same.
2653         * demangle.c: Same.
2654         * dwarf-index-write.c: Same.
2655         * dwarf2-frame.c: Same.
2656         * dwarf2-frame.h: Same.
2657         * eval.c: Same.
2658         * frame-base.h: Same.
2659         * frame.h: Same.
2660         * gdbcmd.h: Same.
2661         * gdbtypes.h: Same.
2662         * gnu-nat.c: Same.
2663         * guile/scm-objfile.c: Same.
2664         * i386-tdep.c: Same.
2665         * i386-tdep.h: Same.
2666         * infcall.c: Same.
2667         * infcall.h: Same.
2668         * linux-nat.c: Same.
2669         * m68k-tdep.c: Same.
2670         * macroexp.c: Same.
2671         * memattr.c: Same.
2672         * mi/mi-cmd-disas.c: Same.
2673         * mi/mi-getopt.h: Same.
2674         * mi/mi-main.c: Same.
2675         * minsyms.c: Same.
2676         * nat/aarch64-sve-linux-sigcontext.h: Same.
2677         * objfiles.h: Same.
2678         * ppc-linux-nat.c: Same.
2679         * ppc-linux-tdep.c: Same.
2680         * ppc-tdep.h: Same.
2681         * progspace.h: Same.
2682         * prologue-value.h: Same.
2683         * python/py-evtregistry.c: Same.
2684         * python/py-instruction.h: Same.
2685         * record-btrace.c: Same.
2686         * record-full.c: Same.
2687         * remote.c: Same.
2688         * rs6000-tdep.c: Same.
2689         * ser-tcp.c: Same.
2690         * sol-thread.c: Same.
2691         * sparc-sol2-tdep.c: Same.
2692         * sparc64-tdep.c: Same.
2693         * stabsread.c: Same.
2694         * symfile.c: Same.
2695         * symtab.h: Same.
2696         * target.c: Same.
2697         * tracepoint.c: Same.
2698         * tui/tui-data.h: Same.
2699         * tui/tui-io.c: Same.
2700         * tui/tui-win.c: Same.
2701         * tui/tui.c: Same.
2702         * unittests/rsp-low-selftests.c: Same.
2703         * user-regs.h: Same.
2704         * utils.c: Same.
2705         * utils.h: Same.
2706         * valarith.c: Same.
2707         * valops.c: Same.
2708         * valprint.c: Same.
2709         * valprint.h: Same.
2710         * value.c: Same.
2711         * value.h: Same.
2712         * varobj.c: Same.
2713         * x86-nat.h: Same.
2714         * xtensa-tdep.c: Same.
2715
2716 2019-10-25  Ali Tamur <tamur@google.com>
2717
2718         * charset.c (find_charset_names): Reflect API change.
2719
2720 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2721
2722         * symtab.c (struct demangled_name_entry): Change demangled name
2723         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2724         part of the struct anymore.
2725         (symbol_set_names): No longer obstack allocate + copy the demangled
2726         name, just store the allocated name from bfd.
2727
2728 2019-10-25  Tom Tromey  <tromey@adacore.com>
2729
2730         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2731         (bsearch_cie_cmp, add_cie): Remove.
2732         (find_cie): Reimplement.
2733         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2734         (dwarf2_build_frame_info): Update.
2735
2736 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2737
2738         PR gdb/25126
2739         * symfile.c (reread_symbols): Call forget_cached_source_info to
2740         clear the stale source cache.
2741
2742 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2743
2744         * configure: Regenerate.
2745         * configure.ac: Remove code that sets python_has_threads.
2746
2747 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2748
2749         * config.in: Regenerate.
2750         * configure: Regenerate.
2751         * configure.ac: Remove the code that uses sed to get the python
2752         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2753
2754 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2755
2756         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2757         error paths.
2758
2759 2019-10-23  Tom Tromey  <tom@tromey.com>
2760
2761         * arc-tdep.c: Remove ".." from include.
2762         * frv-tdep.c: Remove ".." from include.
2763         * lm32-tdep.c: Remove ".." from include.
2764         * microblaze-tdep.c: Remove ".." from include.
2765         * or1k-tdep.h: Remove ".." from include.
2766         * s12z-tdep.c: Remove ".." from include.
2767         * Makefile.in (OPCODES_CFLAGS): Add comment.
2768         (TOP_CFLAGS): New variable.
2769         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2770
2771 2019-10-23  Tom Tromey  <tom@tromey.com>
2772
2773         * Makefile.in (READLINE_DIR): Update.
2774
2775 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2776
2777         * infcall.c (call_function_by_hand_dummy): Fix the function
2778         comment.  And extract out a code section into...
2779         (reserve_stack_space): ...this new function.
2780
2781 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2782
2783         * infcall.c (value_arg_coerce): Remove an unused parameter.
2784         (call_function_by_hand_dummy): Update the call to
2785         'value_arg_coerce'.
2786
2787 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2788
2789         * infcall.c (call_function_by_hand_dummy): Refactor.
2790
2791 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2792
2793         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2794
2795 2019-10-23  Tom Tromey  <tom@tromey.com>
2796
2797         * configure: Rebuild.
2798         * configure.ac: Don't check for sigprocmask.
2799         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2800
2801 2019-10-23  Tom Tromey  <tom@tromey.com>
2802
2803         * configure: Rebuild.
2804         * acinclude.m4: Use m4_include, not sinclude.
2805
2806 2019-10-23  Tom de Vries  <tdevries@suse.de>
2807
2808         PR breakpoints/24687
2809         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2810
2811 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2812
2813         * symtab.c (struct demangled_name_entry) <language>: Change from
2814         bitfield to regular variable.
2815
2816 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2817
2818         * symtab.c (struct demangled_name_entry): Add a constructor.
2819         (free_demangled_name_entry): New function to call the destructor
2820         for demangled_name_entry.
2821         (create_demangled_names_hash): Pass free_demangled_name_entry to
2822         htab_create_alloc.
2823         (symbol_set_names): Call placement new for demangled_name_entry.
2824         * utils.c: No longer include xxhash.h here, now that fast_hash
2825         is inlined in the header.
2826         * utils.h: Instead, include it here.
2827
2828 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2829
2830         * Makefile.in: Link with libxxhash.
2831         * config.in: Regenerate.
2832         * configure: Regenerate.
2833         * configure.ac: Search for libxxhash.
2834         * utils.c (fast_hash): Use xxhash if present.
2835
2836 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2837
2838         * utils.h (fast_hash): New function.
2839         * symtab.c (hash_demangled_name_entry): Call new function
2840         fast_hash.
2841
2842 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2843
2844         * symtab.c (struct demangled_name_entry): Change type of mangled
2845         to gdb::string_view. Also adds a constructor that takes the
2846         mangled name.
2847         (hash_demangled_name_entry): Update.
2848         (eq_demangled_name_entry): Update.
2849         (free_demangled_name_entry): New function to call the destructor
2850         now that this is not a POD anymore.
2851         (create_demangled_names_hash): Pass free_demangled_name_entry to
2852         htab_create_alloc.
2853         (symbol_set_names): Update.
2854
2855 2019-10-21  Ali Tamur  <tamu@google.com>
2856
2857         * dwarf2read.c (dir_index): Change type.
2858         (file_name_index): Likewise.
2859         (line_header::include_dir_at): Change comment and implementation on
2860         whether it is DWARF 5.
2861         (line_header::is_valid_file_index): New function.
2862         (line_header::file_name_at): Change comment and implementation on
2863         whether it is DWARF 5.
2864         (line_header::file_names): Change to private field renamed as
2865         m_file_names and introduce a new accessor method.
2866         (line_header::file_names_size): New method.
2867         (line_header::include_dirs): Change to private field and rename as
2868         m_include_dirs.
2869         (dw2_get_file_names_reader): Define local var at a smaller scope and
2870         reflect API change.
2871         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2872         (process_structure_scope): Likewise.
2873         (line_header::add_include_dir): Change message and reflect renaming.
2874         (line_header::add_file_name): Likewise.
2875         (read_formatted_entries): Handle DW_FORM_data16.
2876         (dwarf_decode_line_header): Fix line header length calculation.
2877         (psymtab_include_file_name): Change comment and API.
2878         (lnp_state_machine::m_file): Update comment and reflect type change.
2879         (lnp_state_machine::record_line): Reflect type change.
2880         (dwarf_decode_lines): Reflect API change.
2881         (file_file_name): Likewise.
2882         (file_full_name): Likewise.
2883
2884 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2885
2886         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2887
2888 2019-10-21  Tom Tromey  <tom@tromey.com>
2889
2890         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2891
2892 2019-10-21  Tom Tromey  <tom@tromey.com>
2893
2894         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2895         NM_H.   Use AC_CONFIG_LINKS.
2896         * configure: Rebuild.
2897         * Makefile.in (NM_H): New variable.
2898         (generated_files): Add NM_H.  Remove gcore.
2899         (nm.h, stamp-nmh): New targets.
2900
2901 2019-10-20  Tom Tromey  <tom@tromey.com>
2902
2903         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2904         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2905         obsolete comment.
2906         (put_objfile_before): Now static.
2907
2908 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2909
2910         * gdbsupport/common-utils.h (startswith): Change return type to
2911         bool.
2912
2913 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2914
2915         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2916         * breakpoint.c (bp_locations_compare): Rename to...
2917         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2918         (update_global_location_list): Use std::sort instead of qsort.
2919         * buildsym.c (compare_line_numbers): Rename to...
2920         (lte_is_less_than): ...this, and change to std::sort semantics.
2921         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2922         instead of qsort.
2923         * disasm.c (compare_lines): Rename to...
2924         (line_is_less_than): ...this, and change to std::sort semantics.
2925         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2926         of qsort.
2927         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2928         (fde_is_less_than): ...this, and change to std::sort semantics.
2929         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2930         * mdebugread.c (compare_blocks):
2931         (block_is_less_than): ...this, and change to std::sort semantics.
2932         (sort_blocks): Call std::sort instead of qsort.
2933         * objfiles.c (qsort_cmp): Rename to...
2934         (sort_cmp): ...this, and change to std::sort semantics.
2935         (update_section_map): Call std::sort instead of qsort.
2936         * remote.c (compare_pnums): Remove.
2937         (map_regcache_remote_table): Call std::sort instead of qsort.
2938         * utils.c (compare_positive_ints): Remove.
2939         * utils.h (compare_positive_ints): Remove.
2940         * xcoffread.c (compare_lte): Remove.
2941         (arrange_linetable): Call std::sort instead of qsort.
2942
2943 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2944
2945         * symfile.c (init_entry_point_info): Fix typo.
2946         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2947
2948 2019-10-18  Tom de Vries  <tdevries@suse.de>
2949
2950         * aarch64-tdep.c: Fix typos in comments.
2951         * ada-lang.c: Same.
2952         * ada-tasks.c: Same.
2953         * alpha-tdep.c: Same.
2954         * alpha-tdep.h: Same.
2955         * amd64-nat.c: Same.
2956         * amd64-windows-tdep.c: Same.
2957         * arc-tdep.c: Same.
2958         * arc-tdep.h: Same.
2959         * arch-utils.c: Same.
2960         * arm-nbsd-tdep.c: Same.
2961         * arm-tdep.c: Same.
2962         * ax-gdb.c: Same.
2963         * blockframe.c: Same.
2964         * btrace.c: Same.
2965         * c-varobj.c: Same.
2966         * coff-pe-read.c: Same.
2967         * coffread.c: Same.
2968         * cris-tdep.c: Same.
2969         * darwin-nat.c: Same.
2970         * dbxread.c: Same.
2971         * dcache.c: Same.
2972         * disasm.c: Same.
2973         * dtrace-probe.c: Same.
2974         * dwarf-index-write.c: Same.
2975         * dwarf2-frame-tailcall.c: Same.
2976         * dwarf2-frame.c: Same.
2977         * dwarf2read.c: Same.
2978         * eval.c: Same.
2979         * exceptions.c: Same.
2980         * fbsd-tdep.c: Same.
2981         * findvar.c: Same.
2982         * frame.c: Same.
2983         * frv-tdep.c: Same.
2984         * gnu-v3-abi.c: Same.
2985         * go32-nat.c: Same.
2986         * h8300-tdep.c: Same.
2987         * hppa-tdep.c: Same.
2988         * i386-linux-tdep.c: Same.
2989         * i386-tdep.c: Same.
2990         * ia64-libunwind-tdep.c: Same.
2991         * ia64-tdep.c: Same.
2992         * infcmd.c: Same.
2993         * infrun.c: Same.
2994         * linespec.c: Same.
2995         * linux-nat.c: Same.
2996         * linux-thread-db.c: Same.
2997         * machoread.c: Same.
2998         * mdebugread.c: Same.
2999         * mep-tdep.c: Same.
3000         * mn10300-tdep.c: Same.
3001         * namespace.c: Same.
3002         * objfiles.c: Same.
3003         * opencl-lang.c: Same.
3004         * or1k-tdep.c: Same.
3005         * osabi.c: Same.
3006         * ppc-linux-nat.c: Same.
3007         * ppc-linux-tdep.c: Same.
3008         * ppc-sysv-tdep.c: Same.
3009         * printcmd.c: Same.
3010         * procfs.c: Same.
3011         * record-btrace.c: Same.
3012         * record-full.c: Same.
3013         * remote-fileio.c: Same.
3014         * remote.c: Same.
3015         * rs6000-tdep.c: Same.
3016         * s12z-tdep.c: Same.
3017         * score-tdep.c: Same.
3018         * ser-base.c: Same.
3019         * ser-go32.c: Same.
3020         * skip.c: Same.
3021         * sol-thread.c: Same.
3022         * solib-svr4.c: Same.
3023         * solib.c: Same.
3024         * source.c: Same.
3025         * sparc-nat.c: Same.
3026         * sparc-sol2-tdep.c: Same.
3027         * sparc-tdep.c: Same.
3028         * sparc64-tdep.c: Same.
3029         * stabsread.c: Same.
3030         * stack.c: Same.
3031         * symfile.c: Same.
3032         * symtab.c: Same.
3033         * target-descriptions.c: Same.
3034         * target-float.c: Same.
3035         * thread.c: Same.
3036         * utils.c: Same.
3037         * valops.c: Same.
3038         * valprint.c: Same.
3039         * value.c: Same.
3040         * varobj.c: Same.
3041         * windows-nat.c: Same.
3042         * xcoffread.c: Same.
3043         * xstormy16-tdep.c: Same.
3044         * xtensa-tdep.c: Same.
3045
3046 2019-10-17  Tom Tromey  <tromey@adacore.com>
3047
3048         * configure: Rebuild.
3049         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
3050         in AC_CONFIG_FILES invocation.
3051         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3052         new-style config.status invocation.
3053
3054 2019-10-17  Tom de Vries  <tdevries@suse.de>
3055
3056         * arm-nbsd-nat.c: Fix typos in comments.
3057         * arm-tdep.c: Same.
3058         * darwin-nat-info.c: Same.
3059         * dwarf2read.c: Same.
3060         * elfread.c: Same.
3061         * event-top.c: Same.
3062         * findvar.c: Same.
3063         * gdbtypes.c: Same.
3064         * hppa-tdep.c: Same.
3065         * i386-tdep.c: Same.
3066         * jit.c: Same.
3067         * main.c: Same.
3068         * mdebugread.c: Same.
3069         * moxie-tdep.c: Same.
3070         * nto-procfs.c: Same.
3071         * osabi.c: Same.
3072         * ppc-linux-tdep.c: Same.
3073         * remote.c: Same.
3074         * riscv-tdep.c: Same.
3075         * s390-tdep.c: Same.
3076         * sh-tdep.c: Same.
3077         * sparc-linux-tdep.c: Same.
3078         * sparc-nat.c: Same.
3079         * stack.c: Same.
3080         * target-descriptions.c: Same.
3081         * top.c: Same.
3082         * varobj.c: Same.
3083
3084 2019-10-16  Tom Tromey  <tom@tromey.com>
3085
3086         * objfiles.h (struct objfile) <original_name>: Now const.
3087
3088 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3089
3090         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3091         pass on to sigsetjmp's second argument.
3092         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3093
3094 2019-10-16  Keith Seitz  <keiths@redhat.com>
3095
3096         PR gdb/23567
3097         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3098         sections whose size is greater than the file size.
3099
3100 2019-10-16  Jim Wilson  <jimw@sifive.com>
3101
3102         * riscv-tdep.c (riscv_gcc_target_options): New.
3103         (riscv_gnu_triplet_regexp): New.
3104         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3105         set_gdbarch_gnu_triplet_regexp.
3106
3107 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3108
3109         * Makefile.in: Add xml-builtin.h.
3110         * features/feature_to_c.sh: Add an include for xml-builtin.h
3111         to ensure that the compiler checks that the types match.
3112         * xml-builtin.h: New file.
3113         * xml-support.c (fetch_xml_builtin): Add missing const.
3114         * xml-support.h: Remove declaration of xml_builtins.
3115
3116 2019-10-16  Tom de Vries  <tdevries@suse.de>
3117
3118         PR tdep/25096
3119         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3120         (amd64_classify_aggregate): ... here.
3121         (amd64_classify_aggregate_field): Handled fiels of nested structs
3122         recursively.
3123
3124 2019-10-16  Tom de Vries  <tdevries@suse.de>
3125
3126         PR tdep/24104
3127         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3128         that handles 'theclass'.
3129
3130 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3131
3132         * linespec.c (decode_digits_ordinary): Update comment.
3133         * make-target-delegates: No longer need to handle VEC case.
3134         * memrange.c (normalize_mem_ranges): Update comment.
3135         * namespace.c (add_using_directive): Update comment.
3136         * objc-lang.c (uniquify_strings): Update comment.
3137         * ppc-linux-nat.c (struct thread_points): Update comment.
3138         * probe.h (find_probes_in_objfile): Update comment.
3139         * target.h (enum flash_preserve_mode): Update comment.
3140         * varobj.c (varobj_restrict_range): Update comment.
3141         * varobj.h (varobj_list_children): Update comment.
3142
3143 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3144
3145         * Makefile.in: Remove references to vec.h and vec.c.
3146         * aarch64-tdep.c: No longer include vec.h.
3147         * ada-lang.c: Likewise.
3148         * ada-lang.h: Likewise.
3149         * arm-tdep.c: Likewise.
3150         * ax.h: Likewise.
3151         * breakpoint.h: Likewise.
3152         * charset.c: Likewise.
3153         * cp-support.h: Likewise.
3154         * dtrace-probe.c: Likewise.
3155         * dwarf2read.c: Likewise.
3156         * extension.h: Likewise.
3157         * gdb_bfd.c: Likewise.
3158         * gdbsupport/gdb_vecs.h: Likewise.
3159         * gdbsupport/vec.c: Remove.
3160         * gdbsupport/vec.h: Remove.
3161         * gdbthread.h: Likewise.
3162         * guile/scm-type.c: Likewise.
3163         * inline-frame.c: Likewise.
3164         * machoread.c: Likewise.
3165         * memattr.c: Likewise.
3166         * memrange.h: Likewise.
3167         * namespace.h: Likewise.
3168         * nat/linux-btrace.h: Likewise.
3169         * osdata.c: Likewise.
3170         * parser-defs.h: Likewise.
3171         * progspace.h: Likewise.
3172         * python/py-type.c: Likewise.
3173         * record-btrace.c: Likewise.
3174         * rust-exp.y: Likewise.
3175         * solib-target.c: Likewise.
3176         * stap-probe.c: Likewise.
3177         * target-descriptions.c: Likewise.
3178         * target-memory.c: Likewise.
3179         * target.h: Likewise.
3180         * varobj.c: Likewise.
3181         * varobj.h: Likewise.
3182         * xml-support.h: Likewise.
3183
3184 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3185
3186         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3187         Update for new std::vector based implementation.
3188         (process_psymtab_comp_unit_reader): Likewise.
3189         (scan_partial_symbols): Likewise.
3190         (recursively_compute_inclusions): Likewise.
3191         (compute_compunit_symtab_includes): Likewise.
3192         (process_imported_unit_die): Likewise.
3193         (queue_and_load_dwo_tu): Likewise.
3194         (follow_die_sig_1): Likewise.
3195         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3196         (typedef dwarf2_per_cu_ptr): Remove.
3197         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3198         function.
3199         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3200         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3201         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3202         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3203         std::vector.
3204
3205 2019-10-15  Tom Tromey  <tromey@adacore.com>
3206
3207         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3208         TID.
3209
3210 2019-10-15  Tom Tromey  <tromey@adacore.com>
3211
3212         * windows-nat.c (windows_nat_target::fetch_registers)
3213         (windows_nat_target::store_registers): Rename "pid" to "tid".
3214
3215 2019-10-15  Tom Tromey  <tromey@adacore.com>
3216
3217         * gdbarch.h, gdbarch.c: Rebuild.
3218         * gdbarch.sh (gcc_target_options): Change return type to
3219         std::string.
3220         * compile/compile.c (get_args): Update.
3221         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3222         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3223         std::string.
3224         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3225         std::string.
3226         * arch-utils.c (default_gcc_target_options): Return std::string.
3227         * arch-utils.h (default_gcc_target_options): Return std::string.
3228         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3229
3230 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3231
3232         * breakpoint.c (breakpoint_chain): Make static.
3233         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3234         of accessing breakpoint_chain.
3235
3236 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3237
3238         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3239         to a gdb::function_view and return value to bool.
3240         * breakpoint.h (iterate_over_breakpoints): Likewise.
3241         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3242         (pop_dummy_frame): Update.
3243         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3244         (gdbscm_breakpoints): Update.
3245         * python/py-breakpoint.c (build_bp_list): Update.
3246         (gdbpy_breakpoints): Update.
3247         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3248         Update.
3249         (bpfinishpy_handle_stop): Update.
3250         (bpfinishpy_handle_exit): Update.
3251         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3252         (svr4_update_solib_event_breakpoints): Update.
3253
3254 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3255
3256         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3257         when unwrapping single-field structs.
3258
3259 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3260
3261         * dwarf2read.c: Remove includes.
3262
3263 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3264
3265         * ui-out.c (ui_out::call_do_message): Silence
3266         -Wformat-nonliteral warning.
3267
3268 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3269
3270         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3271         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3272         include: readline/tilde.h.
3273
3274 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3275
3276         * remote.c (remote_target::get_trace_status): Remove declaration of
3277         trace_regblock_size.
3278
3279 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3280
3281         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3282         (show_user): Remove declaration of cmdlist.
3283         * cli/cli-cmds.h (max_user_call_depth): Declare.
3284         * cli/cli-script.c (execute_user_command): Remove declaration
3285         of max_user_call_depth.
3286
3287 2019-10-11  Jim Wilson  <jimw@sifive.com>
3288
3289         * gdbsupport/print-utils.h (pulongest): Fix comment.
3290         (plongest): Likewise.
3291         (phex): Add missing comment, mention leading zeros.
3292         (phex_nz): Add mention of no leading zeros to comment.
3293
3294         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3295         plongest instead of unsigned long long cast.
3296
3297 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3298
3299         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3300         for external_editor_command and gdbtk_test.
3301
3302 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3303
3304         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3305         * varobj.c (varobjdebug): Move comment to...
3306         * varobj.h (varobjdebug): ...here, and declare.
3307
3308 2019-10-09  Tom Tromey  <tom@tromey.com>
3309
3310         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3311         erase_data_content.
3312
3313 2019-10-09  Tom Tromey  <tom@tromey.com>
3314
3315         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3316         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3317         * tui/tui-command.c (tui_cmd_window::resize)
3318         (tui_refresh_cmd_win): Update.
3319         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3320         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3321         * tui/tui-data.c (~tui_gen_win_info): Remove.
3322         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3323         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3324         (tui_redisplay_readline, tui_mld_flush)
3325         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3326         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3327         (tui_data_window::erase_data_content)
3328         (tui_data_item_window::rerender)
3329         (tui_data_item_window::refresh_window): Update.
3330         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3331         (box_win, tui_gen_win_info::make_window)
3332         (tui_gen_win_info::make_visible): Update.
3333         (tui_delete_win): Remove.
3334         * tui/tui-winsource.c
3335         (tui_source_window_base::do_erase_source_content): Update.
3336         (tui_show_source_line, tui_source_window_base::update_tab_width)
3337         (tui_source_window_base::update_exec_info): Update.
3338         * tui/tui-data.h (struct curses_deleter): New.
3339         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3340         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3341
3342 2019-10-09  Tom Tromey  <tom@tromey.com>
3343
3344         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3345
3346 2019-10-09  Tom Tromey  <tom@tromey.com>
3347
3348         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3349         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3350
3351 2019-10-09  Tom Tromey  <tom@tromey.com>
3352
3353         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3354         window height directly.
3355         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3356         declare.
3357         * tui/tui-layout.c (tui_default_win_height): Remove.
3358         (tui_default_win_viewport_height): Remove.
3359
3360 2019-10-09  Tom Tromey  <tom@tromey.com>
3361
3362         * tui/tui.h: Remove comments.
3363
3364 2019-10-09  Tom de Vries  <tdevries@suse.de>
3365
3366         * python/lib/gdb/printer/bound_registers.py: Use
3367         '^builtin_type_bound128' as regexp argument for
3368         add_builtin_pretty_printer.
3369
3370 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3371
3372         * guile/guile.c (guile_extension_script_ops): Remove forward
3373         declaration and mark as static.
3374         (guile_script_ops): Likewise.
3375         (extension_language_guile): Move further down in the file so
3376         it can reference the definitions for guile_{extension_,}script_ops.
3377
3378 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3379
3380         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3381         except SORTL, DFLTCC, and KDSA.
3382
3383 2019-10-08  Tom Tromey  <tromey@adacore.com>
3384
3385         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3386         (struct safe_symbol_file_add_args): Remove.
3387
3388 2019-10-08  Tom Tromey  <tromey@adacore.com>
3389
3390         * windows-nat.c: Don't include buildsym-legacy.h.
3391
3392 2019-10-08  Tom Tromey  <tromey@adacore.com>
3393
3394         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3395
3396 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3397
3398         * gdbtypes.c (overload_debug): Move comment to header.
3399         * gdbtypes.h (overload_debug): Declare.
3400         * valops.c: Remove declaration of overload_debug, instead
3401         include gdbtypes.h.
3402
3403 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3404
3405         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3406         through _().
3407         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3408         move comment...
3409         * language.h (lang_frame_mismatch_warn): ... here. Also add
3410         declaration.
3411         * top.c (lang_frame_mismatch_warn): Remove declaration.
3412         (check_frame_language_change): Pass lang_frame_mismatch_warn
3413         through _().
3414
3415 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3416
3417         * c-lang.h (vtbl_ptr_name): Declare.
3418         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3419         it from the header.
3420         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3421
3422 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3423
3424         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3425         gdb_static_assert.
3426
3427 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3428
3429         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3430         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3431         * ctfread.c: New file.
3432         * ctfread.h: New file.
3433         * elfread.c: Include ctfread.h.
3434         (struct elfinfo text_p): New member ctfsect.
3435         (elf_locate_sections): Mark CTF section.
3436         (elf_symfile_read): Call elfctf_build_psymtabs.
3437         * Makefile.in (LIBCTF): Add.
3438         (CLIBS): Use it.
3439         (CDEPS): Likewise.
3440         (DIST): Add ctfread.c.
3441
3442 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3443
3444         * ctfread.c (struct nextfield): Renamed to ...
3445         (struct ctf_nextfield): ... this.
3446         (struct field_info): Renamed to ...
3447         (strut ctf_field_info): ... this.
3448         (attach_fields_to_type): Update for renamed structures.
3449         (ctf_add_member_cb): Likewise.
3450         (ctf_add_enum_member_cb): Likewise.
3451         (process_struct_members): Likewise.
3452         (process_enum_type): Likewise.
3453
3454 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3455
3456         * tracectf.h: Rename, was ctf.h.
3457         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3458         * tracefile.c: Likewise.
3459         * tracepoint.c: Remove unused include ctf.h.
3460         * mi/mi-main.c: Likewise.
3461         * Makefile.in Replace ctf.c with tracectf.c.
3462
3463 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3464
3465         * version.in: Change version number to "9.0.50.DATE-git".
3466
3467 2019-10-03  Tom Tromey  <tom@tromey.com>
3468
3469         PR rust/24976:
3470         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3471
3472 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3473
3474         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3475         cp_search_name_hash.
3476         * NEWS: Add entry about nested function support.
3477
3478 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3479             Andrew Burgess  <andrew.burgess@embecosm.com>
3480
3481         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3482         for nested static variables when searchin VAR_DOMAIN.
3483         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3484         global scope, update comment.
3485         (add_partial_subprogram): Call add_partial_subprogram recursively
3486         for nested subroutines when processinng Fortran.
3487         (load_partial_dies): Process the child entities of a subprogram
3488         when processing Fortran.
3489         (partial_die_parent_scope): Handle building scope
3490         for Fortran nested functions.
3491         (process_die): Record that nested functions have a scope.
3492         (new_symbol): Always record Fortran subprograms on the global
3493         symbol list.
3494         (determine_prefix): How to build the prefix for Fortran
3495         subprograms.
3496
3497 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3498
3499         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3500         have just sent the thread a SIGSTOP and are waiting for it to
3501         arrive.
3502
3503 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3504
3505         * btrace.c (btrace_add_pc): Remove whitespace before the template
3506         parameter in 'std::vector <...>'.
3507         (parse_xml_btrace_block): Likewise.
3508         (btrace_maint_decode_pt): Likewise.
3509         (btrace_maint_update_packets): Likewise.
3510         (btrace_maint_print_packets): Likewise.
3511         * btrace.h (struct btrace_maint_info): Likewise.
3512         * dwarf2read.c (struct type_unit_group): Likewise.
3513         (build_type_psymtabs_reader): Likewise.
3514         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3515         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3516         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3517
3518 2019-10-03  Tom de Vries  <tdevries@suse.de>
3519
3520         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3521         the first line of the help text for set/show style metadata.
3522
3523 2019-10-02  Tom Tromey  <tromey@adacore.com>
3524
3525         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3526         * gdbsupport/common-inferior.c: New file.
3527         * infcmd.c (startup_with_shell): Don't define.
3528         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3529         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3530         * inferior.h (startup_with_shell): Don't declare.
3531
3532 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3533
3534         * gdbsupport/gdb_assert.h: Include errors.h.
3535         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3536
3537 2019-10-02  Tom Tromey  <tromey@adacore.com>
3538
3539         * NEWS: Add $_ada_exception entry.
3540         * ada-lang.c (struct ada_catchpoint): Add constructor.
3541         <m_kind>: New member.
3542         (allocate_location_exception, re_set_exception): Remove
3543         "ex" parameter.
3544         (should_stop_exception): Compute $_ada_exception.
3545         (check_status_exception, print_it_exception)
3546         (print_one_exception, print_mention_exception): Remove
3547         "ex" parameter.
3548         (allocate_location_catch_exception, re_set_catch_exception)
3549         (check_status_exception, print_it_catch_exception)
3550         (print_one_catch_exception, print_mention_catch_exception)
3551         (print_recreate_catch_exception)
3552         (allocate_location_catch_exception_unhandled)
3553         (re_set_catch_exception_unhandled)
3554         (check_status_exception, print_it_catch_exception_unhandled)
3555         (print_one_catch_exception_unhandled)
3556         (print_mention_catch_exception_unhandled)
3557         (print_recreate_catch_exception_unhandled)
3558         (allocate_location_catch_assert, re_set_catch_assert)
3559         (check_status_assert, print_it_catch_assert)
3560         (print_one_catch_assert, print_mention_catch_assert)
3561         (print_recreate_catch_assert)
3562         (allocate_location_catch_handlers, re_set_catch_handlers)
3563         (check_status_handlers, print_it_catch_handlers)
3564         (print_one_catch_handlers, print_mention_catch_handlers)
3565         (print_recreate_catch_handlers): Remove.
3566         (create_ada_exception_catchpoint): Update.
3567         (initialize_ada_catchpoint_ops): Update.
3568
3569 2019-10-02  Tom Tromey  <tromey@adacore.com>
3570
3571         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3572         (create_excep_cond_exprs): Simplify exception string computation.
3573         (ada_exception_catchpoint_cond_string): Likewise.
3574
3575 2019-10-02  Tom Tromey  <tromey@adacore.com>
3576
3577         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3578         * ada-lang.c (lesseq_defined_than): Handle
3579         LOC_STATIC.
3580         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3581         parameter.
3582         (dwarf2_has_info): Likewise.
3583         (new_symbol): Set maybe_copied on symbol when
3584         appropriate.
3585         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3586         parameter.
3587         <can_copy>: New member.
3588         * elfread.c (record_minimal_symbol): Set maybe_copied
3589         on symbol when appropriate.
3590         (elf_symfile_read): Update call to dwarf2_has_info.
3591         * minsyms.c (lookup_minimal_symbol_linkage): New
3592         function.
3593         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3594         * symtab.c (get_symbol_address, get_msymbol_address):
3595         New functions.
3596         * symtab.h (get_symbol_address, get_msymbol_address):
3597         Declare.
3598         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3599         maybe_copied.
3600         (struct symbol, struct minimal_symbol) <maybe_copied>:
3601         New member.
3602
3603 2019-10-02  Tom Tromey  <tromey@adacore.com>
3604
3605         * source.c (struct current_source_location): New.
3606         (current_source_key): New global.
3607         (current_source_symtab, current_source_line)
3608         (current_source_pspace): Remove.
3609         (get_source_location): New function.
3610         (get_current_source_symtab_and_line)
3611         (set_default_source_symtab_and_line)
3612         (set_current_source_symtab_and_line)
3613         (clear_current_source_symtab_and_line, select_source_symtab)
3614         (info_source_command, print_source_lines_base)
3615         (info_line_command, search_command_helper, _initialize_source):
3616         Update.
3617
3618 2019-10-02  Tom Tromey  <tromey@adacore.com>
3619
3620         * source.c (select_source_symtab): Don't call
3621         decode_line_with_current_source.
3622
3623 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3624
3625         * symtab.c (lookup_global_symbol): Search global block.
3626
3627 2019-10-02  Tom Tromey  <tromey@adacore.com>
3628
3629         * coffread.c (process_coff_symbol): Update.
3630         * dwarf2read.c (var_decode_location, new_symbol): Update.
3631         * mdebugread.c (parse_symbol): Update.
3632         * objfiles.c (relocate_one_symbol): Update.
3633         * stabsread.c (define_symbol, fix_common_block)
3634         (scan_file_globals): Update.
3635         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3636         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3637         * xcoffread.c (process_xcoff_symbol): Update.
3638
3639 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3640
3641         * MAINTAINERS: Update my email address.
3642
3643 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3644
3645         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3646         std::vector.
3647         (build_type_psymtabs_reader): Update for std::vector.
3648         (build_type_psymtab_dependencies): Likewise.
3649         * dwarf2read.h: Remove use of DEF_VEC_P.
3650         (typedef sig_type_ptr): Delete.
3651
3652 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3653
3654         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3655         to std::vector.
3656         (btrace_maint_decode_pt): Likewise, and move allocation of the
3657         vector outside of the loop.
3658         (btrace_maint_update_packets): Update to handle change from VEC to
3659         std::vector.
3660         (btrace_maint_print_packets): Likewise.
3661         (maint_info_btrace_cmd): Likewise.
3662         * btrace.h: Remove use of DEF_VEC_O.
3663         (typedef btrace_pt_packet_s): Delete.
3664         (struct btrace_maint_info) <packets>: Change fromm VEC to
3665         std::vector.
3666         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3667
3668 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3669
3670         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3671         make accesses into the vector constant references.
3672         (btrace_add_pc): Update for std::vector.
3673         (btrace_stitch_bts): Likewise.
3674         (parse_xml_btrace_block): Likewise.
3675         (btrace_maint_update_packets): Likewise.
3676         (btrace_maint_print_packets): Likewise.
3677         (maint_info_btrace_cmd): Likewise.
3678         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3679         std::vector.
3680         (btrace_data::empty): Likewise.
3681         (btrace_data_append): Likewise.
3682         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3683         (typedef btrace_block_s): Delete.
3684         (struct btrace_block): Add constructor.
3685         (struct btrace_data_bts) <blocks>: Change to std::vector.
3686         * nat/linux-btrace.c (perf_event_read_bts): Update for
3687         std::vector.
3688         (linux_read_bts): Likewise.
3689
3690 2019-10-01  Tom Tromey  <tom@tromey.com>
3691
3692         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3693
3694 2019-10-01  Tom Tromey  <tom@tromey.com>
3695
3696         * stack.c (print_frame, info_frame_command_core): Use
3697         styled_string.
3698         * linux-thread-db.c (try_thread_db_load_1)
3699         (try_thread_db_load_from_pdir_1): Use styled_string.
3700         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3701         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3702         (maybe_print_unsupported_script_warning)
3703         (maybe_print_script_not_found_warning): Use styled_string.
3704         * ada-lang.c (user_select_syms): Use styled_string.
3705
3706 2019-10-01  Tom Tromey  <tom@tromey.com>
3707
3708         * p-lang.c (pascal_printstr): Use metadata style.
3709         * value.c (show_convenience): Use metadata style.
3710         * valprint.c (valprint_check_validity, val_print_optimized_out)
3711         (val_print_not_saved, val_print_unavailable)
3712         (val_print_invalid_address, generic_val_print, val_print)
3713         (value_check_printable, val_print_array_elements): Use metadata
3714         style.
3715         * ui-out.h (class ui_out) <field_fmt>: New overload.
3716         <do_field_fmt>: Add style parameter.
3717         * ui-out.c (ui_out::field_fmt): New overload.
3718         * typeprint.c (type_print_unknown_return_type)
3719         (val_print_not_allocated, val_print_not_associated): Use metadata
3720         style.
3721         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3722         parameter.
3723         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3724         * tracepoint.c (tvariables_info_1): Use metadata style.
3725         * stack.c (print_frame_arg, print_frame_info, print_frame)
3726         (info_frame_command_core): Use metadata style.
3727         * skip.c (info_skip_command): Use metadata style.
3728         * rust-lang.c (rust_print_enum): Use metadata style.
3729         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3730         metadata style.
3731         * python/py-framefilter.c (py_print_single_arg): Use metadata
3732         style.
3733         * printcmd.c (do_one_display, print_variable_and_value): Use
3734         metadata style.
3735         * p-valprint.c (pascal_val_print)
3736         (pascal_object_print_value_fields): Use metadata style.
3737         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3738         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3739         parameter.
3740         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3741         * m2-valprint.c (m2_print_long_set): Use metadata style.
3742         * m2-typeprint.c (m2_print_type): Use metadata style.
3743         * infcmd.c (print_return_value_1): Use metadata style.
3744         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3745         * f-valprint.c (info_common_command_for_block): Use metadata
3746         style.
3747         * f-typeprint.c (f_type_print_base): Use metadata style.
3748         * expprint.c (print_subexp_standard): Use metadata style.
3749         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3750         * cli/cli-style.h (class cli_style_option): Add constructor.
3751         (metadata_style): Declare.
3752         * cli/cli-style.c (metadata_style): New global.
3753         (_initialize_cli_style): Register metadata style.
3754         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3755         parameter.
3756         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3757         * c-typeprint.c (c_type_print_base_struct_union)
3758         (c_type_print_base_1): Use metadata style.
3759         * breakpoint.c (watchpoint_value_print)
3760         (print_one_breakpoint_location): Use metadata style.
3761         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3762         style.
3763         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3764         style.
3765         * ada-valprint.c (val_print_packed_array_elements, printstr)
3766         (print_field_values, ada_val_print_ref, ada_val_print): Use
3767         metadata style.
3768         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3769         style.
3770         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3771         style.
3772         * ada-lang.c (user_select_syms): Use metadata style.
3773
3774 2019-10-01  Tom Tromey  <tom@tromey.com>
3775
3776         * cli/cli-cmds.c (pwd_command): Style output.
3777
3778 2019-10-01  Pedro Alves  <palves@redhat.com>
3779             Tom Tromey  <tom@tromey.com>
3780
3781         * symtab.c (print_symbol_info): Use %ps.
3782         (print_msymbol_info): Use %ps.
3783         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3784         * printcmd.c (print_variable_and_value): Use %ps.
3785         * macrocmd.c (show_pp_source_pos): Use %ps.
3786         * infrun.c (print_exited_reason): Use ui_out::message.
3787         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3788         (describe_other_breakpoints): Use ui_out::message and new
3789         formats.
3790         (say_where): Use new formats.
3791         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3792         and new formats.
3793
3794 2019-10-01  Pedro Alves  <palves@redhat.com>
3795             Tom Tromey  <tom@tromey.com>
3796
3797         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3798         (test_gdb_formats): New function.
3799         (run_tests): Call it.
3800         (test_format_specifier): Update.
3801         * utils.h (fputs_filtered): Update comment.
3802         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3803         (fputs_styled_unfiltered): Declare.
3804         * utils.c (fputs_styled_unfiltered): New function.
3805         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3806         (vfprintf_filtered): Update.
3807         (vfprintf_unfiltered, vprintf_filtered): Update.
3808         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3809         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3810         disallow_ui_out_field>: New constants.
3811         (enum class field_kind): New.
3812         (struct base_field_s, struct signed_field_s): New.
3813         (signed_field): New function.
3814         (struct string_field_s): New.
3815         (string_field): New function.
3816         (struct styled_string_s): New.
3817         (styled_string): New function.
3818         (class ui_out) <message>: Add comment.
3819         <vmessage, call_do_message>: New methods.
3820         <do_message>: Add style parameter.
3821         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3822         methods.
3823         (ui_out::message): Rewrite.
3824         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3825         parameter.
3826         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3827         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3828         gdb_extensions parameter.
3829         (class format_piece): Add parameter to constructor.
3830         (n_int_args): New field.
3831         * gdbsupport/format.c (format_pieces::format_pieces): Add
3832         gdb_extensions parameter.  Handle '*'.
3833         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3834         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3835         vfprintf_styled_no_gdbfmt.
3836         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3837         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3838         unfiltered output.
3839         * ui-style.h (struct ui_file_style) <ptr>: New method.
3840
3841 2019-10-01  Tom Tromey  <tom@tromey.com>
3842
3843         * unittests/format_pieces-selftests.c: Update.  Add final format.
3844         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3845         empty literal pieces.
3846
3847 2019-10-01  Tom Tromey  <tom@tromey.com>
3848
3849         * ui-out.h (enum class ui_out_style_kind): Remove.
3850         (class ui_out) <field_string, field_stsream, do_field_string>:
3851         Change type of "style".
3852         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3853         (ui_out::field_string): Update.
3854         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3855         of "style".
3856         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3857         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3858         * stack.c (print_frame_arg, print_frame_info, print_frame):
3859         Update.
3860         * source.c (print_source_lines_base): Update.
3861         * solib.c (info_sharedlibrary_command): Update.
3862         * skip.c (info_skip_command): Update.
3863         * record-btrace.c (btrace_call_history_src_line)
3864         (btrace_call_history): Update.
3865         * python/py-framefilter.c (py_print_frame): Update.
3866         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3867         "style".
3868         * mi/mi-out.c (mi_ui_out::do_table_header)
3869         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3870         (mi_ui_out::do_field_string): Update.
3871         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3872         Update.
3873         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3874         "style".
3875         * cli-out.c (cli_ui_out::do_table_header)
3876         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3877         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3878         (cli_ui_out::do_field_fmt): Update.
3879         * breakpoint.c (print_breakpoint_location): Update.
3880         (update_static_tracepoint): Update.
3881
3882 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3883
3884         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3885         conversion of gdb_datadir.
3886         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3887         remove not needed c_str ().
3888
3889 2019-09-30  Ali Tamur <tamur@google.com>
3890
3891         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3892         (dwarf2_string_attr): Likewise.
3893
3894 2019-09-30  Ali Tamur <tamur@google.com>
3895
3896         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3897         (process_full_type_unit): Likewise.
3898         (dump_die_shallow): Likewise.
3899         (cu_debug_loc_section): Likewise.
3900
3901 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3902
3903         * minsyms.c (compare_minimal_symbols): Rename to...
3904         (minimal_symbol_is_less_than): ...this, and adjust to STL
3905         conventions (return bool, take arguments as references)
3906         (minimal_symbol_reader::install): Call std::sort instead
3907         of qsort.
3908
3909 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3910
3911         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3912         hash and why.
3913         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3914         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3915
3916 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3917
3918         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3919         * psympriv.h (add_psymbol_to_list): Move comment here and update
3920         it.
3921
3922 2019-09-29  Tom de Vries  <tdevries@suse.de>
3923
3924         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3925         Use $tmpdir/$(basename "$output_file").dwz instead of
3926         "${output_file}.dwz".
3927
3928 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3929
3930         PR gdb/25045
3931         * hppa-linux-nat.c: Include gdbarch.h.
3932
3933 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3934
3935         * blockframe.c (find_pc_partial_function): Change return type to bool.
3936         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3937         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3938         (stub_gnu_ifunc_resolve_name): Likewise.
3939         * symtab.c (compare_filenames_for_search): Likewise.
3940         (compare_glob_filenames_for_search): Likewise.
3941         (matching_obj_sections): Likewise.
3942         (symbol_matches_domain): Likewise.
3943         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3944         (find_line_pc): Change return type to bool.
3945         (find_line_pc_range): Likewise.
3946         (producer_is_realview): Likewise.
3947         * symtab.h (symbol_matches_domain): Likewise.
3948         (find_pc_partial_function): Likewise.
3949         (find_pc_line_pc_range): Likewise.
3950         (in_gnu_ifunc_stub): Likewise.
3951         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3952         (find_line_pc): Likewise.
3953         (find_line_pc_range): Likewise.
3954         (matching_obj_sections): Likewise.
3955         (find_line_symtab): Change out parameter to bool.
3956         (producer_is_realview): Change return type to bool.
3957         (compare_filenames_for_search): Likewise.
3958         (compare_glob_filenames_for_search): Likewise.
3959
3960 2019-09-26  Tom Tromey  <tom@tromey.com>
3961
3962         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3963         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3964         * gdb_usleep.h: Remove.
3965         * gdb_usleep.c: Remove.
3966         * utils.c: Don't include gdb_usleep.h.
3967
3968 2019-09-26  Tom Tromey  <tromey@adacore.com>
3969
3970         * python/py-type.c (type_to_type_object): Call check_typedef
3971         for stub types.
3972
3973 2019-09-26  Tom Tromey  <tom@tromey.com>
3974
3975         * utils.h (initialize_utils): Don't declare.
3976         * top.c (gdb_init): Don't call initialize_utils.
3977         * utils.c (initialize_utils): Remove.  Move contents...
3978         (_initialize_utils): ... here.
3979
3980 2019-09-25  Tom Tromey  <tom@tromey.com>
3981
3982         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3983         * utils.h (make_hex_string): Don't declare.
3984         * utils.c (make_hex_string): Remove.
3985
3986 2019-09-24  Tom de Vries  <tdevries@suse.de>
3987
3988         PR gdb/23815
3989         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3990         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3991
3992 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3993
3994         * NEWS: Mention new simulator port for PRU.
3995
3996 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3997
3998         * ada-exp.y (write_object_remaining): Update.
3999         * ada-lang.c (ada_decode): Return a std::string instead of a char*
4000         and eliminate the static buffer.
4001         (ada_decode_symbol): Update.
4002         (ada_la_decode): Update.
4003         (ada_sniff_from_mangled_name): Update.
4004         (is_valid_name_for_wild_match): Update.
4005         (ada_lookup_name_info::matches): Update and simplify.
4006         (name_matches_regex): Update.
4007         (ada_add_global_exceptions): Update.
4008         * ada-lang.h (ada_decode): Update signature.
4009         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4010         * dwarf-index-write.c (debug_names::insert): Update.
4011
4012 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4013
4014         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4015         formatting.
4016
4017 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4018
4019         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4020         Change "nonzero" to "true" in documentation.
4021
4022 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
4023
4024         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4025         (_initialize_darwin_solib): Don't set
4026         darwin_so_ops.lookup_lib_global_symbol.
4027         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4028         set_gdbarch_iterate_over_objfiles_in_search_order.
4029         (elf_lookup_lib_symbol): Rename to...
4030         (svr4_iterate_over_objfiles_in_search_order): this, and update
4031         to iterate semantics.
4032         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4033         * solib.c (solib_global_lookup): Remove.
4034         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4035         (solib_global_lookup): Remove.
4036         * symtab.c (lookup_global_or_static_symbol): Remove call to
4037         solib_global_lookup.
4038
4039 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4040
4041         * NEWS: Move entries about default MI version now being
4042         version 3, and about the GDB/MI fix for multi-location
4043         breakpoints to the "since GDB 8.3" section.
4044
4045 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4046
4047         GDB 8.3.1 released.
4048
4049 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
4050
4051         * NEWS: Mention that Cell/B.E. debugging support was removed.
4052         * MAINTAINERS: Remove spu target.
4053
4054         * config/djgpp/fnchange.lst: Remove entries for removed files.
4055
4056         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4057         spu-multiarch.o, and spu-tdep.o.
4058         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4059         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4060         spu-multiarch.c, and spu-tdep.c.
4061         * spu-linux-nat.c: Remove file.
4062         * spu-multiarch.c: Remove file.
4063         * spu-tdep.c: Remove file.
4064         * spu-tdep.h: Remove file.
4065         * solib-spu.c: Remove file.
4066         * solib-spu.h: Remove file.
4067
4068         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4069         * configure.nat (spu-linux): Remove.
4070         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4071         solib-multiarch.o from gdb_target_obs.
4072         (spu*-*-*): Remove.
4073
4074         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4075         feature flag.
4076         (ppc_linux_no_features): Update.
4077         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4078         Cell/B.E. support.
4079         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4080         (tdesc_powerpc_cell64l): Likewise.
4081         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4082         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4083         Cell/B.E. support.
4084         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4085         Do not include "features/rs6000/powerpc-cell32l.c" or
4086         "features/rs6000/powerpc-cell64l.c".
4087         (ppc_linux_spu_section): Remove.
4088         (ppc_linux_core_read_description): Remove Cell/B.E. support.
4089         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4090         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4091         (ppc_linux_spe_context_lookup): Remove.
4092         (ppc_linux_spe_context_inferior_created): Remove.
4093         (ppc_linux_spe_context_solib_loaded): Remove.
4094         (ppc_linux_spe_context_solib_unloaded): Remove.
4095         (ppc_linux_spe_context): Remove.
4096         (struct ppu2spu_cache): Remove.
4097         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4098         (struct ppu2spu_data): Remove.
4099         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4100         ppu2spu_unwind): Remove.
4101         (ppc_linux_init_abi): Remove Cell/B.E. support.
4102         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4103
4104         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4105         (rs6000/powerpc-cell64l-expedite): Likewise
4106         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4107         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4108         rs6000/powerpc-cell64l.xml.
4109         * features/rs6000/powerpc-cell32l.xml: Remove.
4110         * features/rs6000/powerpc-cell64l.xml: Likewise.
4111         * features/rs6000/powerpc-cell32l.c: Remove generated file.
4112         * features/rs6000/powerpc-cell64l.c: Likewise.
4113         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4114         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4115         * regformats/reg-spu.dat: Remove.
4116
4117         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4118         * corelow.c (struct spuid_list): Remove.
4119         (add_to_spuid_list): Remove.
4120         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4121         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4122         (remote_protocol_features): Remove associated entries.
4123         (_initialize_remote): No longer initialize them.
4124         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4125         * linux-nat.c (SPUFS_MAGIC): Remove.
4126         (linux_proc_xfer_spu): Remove.
4127         (spu_enumerate_spu_ids): Remove.
4128         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4129         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4130         (linux_make_corefile_notes): No longer call it.
4131
4132         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4133         (cooked_write_test): Likewise.
4134
4135 2019-09-20  Tom Tromey  <tom@tromey.com>
4136
4137         * NEWS: Mention case-sensitivity of TUI commands.
4138         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4139         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4140         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4141
4142 2019-09-20  Tom Tromey  <tom@tromey.com>
4143
4144         * tui/tui-source.c (tui_source_window::set_contents): Use
4145         make_unique_xstrdup.
4146         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4147         make_unique_xstrdup.
4148
4149 2019-09-20  Tom Tromey  <tom@tromey.com>
4150
4151         * tui/tui-data.c: Remove separator comments.
4152         * tui/tui-layout.c: Remove separator comments.
4153         * tui/tui-win.c: Remove separator comments.
4154         * tui/tui-wingeneral.c: Remove separator comments.
4155
4156 2019-09-20  Tom Tromey  <tom@tromey.com>
4157
4158         * tui/tui.h (strcat_to_buf): Don't declare.
4159         * tui/tui.c (strcat_to_buf): Remove.
4160
4161 2019-09-20  Tom Tromey  <tom@tromey.com>
4162
4163         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4164         from "fullname".
4165         * tui/tui-source.c (tui_source_window::set_contents)
4166         (tui_source_window::location_matches_p)
4167         (tui_source_window::maybe_update): Update.
4168
4169 2019-09-20  Tom Tromey  <tom@tromey.com>
4170
4171         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4172         Update.
4173         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4174         prefix.
4175         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4176         (tui_data_window::line_from_reg_element_no)
4177         (tui_data_window::first_reg_element_no_inline)
4178         (tui_data_window::show_registers)
4179         (tui_data_window::show_register_group)
4180         (tui_data_window::display_registers_from)
4181         (tui_data_window::display_registers_from_line)
4182         (tui_data_window::first_data_item_displayed)
4183         (tui_data_window::delete_data_content_windows)
4184         (tui_data_window::erase_data_content)
4185         (tui_data_window::do_scroll_vertical)
4186         (tui_data_window::refresh_window)
4187         (tui_data_window::check_register_values): Update.
4188
4189 2019-09-20  Tom Tromey  <tom@tromey.com>
4190
4191         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4192         (struct tui_locator_window) <full_name, proc_name>: Now
4193         std::string.
4194         * tui/tui-stack.c (tui_locator_window::make_status_line)
4195         (tui_locator_window::set_locator_fullname)
4196         (tui_locator_window::set_locator_info): Update.
4197         * tui/tui-source.c (tui_source_window::set_contents)
4198         (tui_source_window::showing_source_p): Update.
4199
4200 2019-09-20  Tom Tromey  <tom@tromey.com>
4201
4202         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4203         Don't call tui_locator_win_info_ptr.
4204
4205 2019-09-20  Tom Tromey  <tom@tromey.com>
4206
4207         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4208
4209 2019-09-20  Tom Tromey  <tom@tromey.com>
4210
4211         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4212         height for locator.
4213         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4214         * tui/tui-layout.c (show_source_disasm_command, show_data)
4215         (show_source_or_disasm_and_command): Use 1 as height for locator.
4216
4217 2019-09-20  Tom Tromey  <tom@tromey.com>
4218
4219         * tui/tui.c (tui_enable): Update.
4220         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4221         Update.
4222         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4223         Update.
4224         * tui/tui-data.c (win_resized): Now bool.
4225         (tui_win_resized): Return bool.
4226         (tui_set_win_resized_to): Accept a bool.
4227
4228 2019-09-20  Tom Tromey  <tom@tromey.com>
4229
4230         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4231         Change type of "refresh_values_only".
4232         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4233         type of "refresh_values_only".
4234
4235 2019-09-20  Tom Tromey  <tom@tromey.com>
4236
4237         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4238         std::string.
4239         (tui_disassemble): Add "pos" parameter.
4240         (tui_disasm_window::set_contents): Simplify.
4241
4242 2019-09-20  Tom Tromey  <tom@tromey.com>
4243
4244         * tui/tui-winsource.h (struct tui_source_window_base)
4245         <show_source_content>: Now private.
4246         * tui/tui-winsource.c
4247         (tui_source_window_base::show_source_content): Don't handle empty
4248         content case.
4249
4250 2019-09-20  Tom Tromey  <tom@tromey.com>
4251
4252         * tui/tui-layout.c (show_source_disasm_command)
4253         (show_source_or_disasm_and_command): Don't call
4254         show_source_content.
4255
4256 2019-09-20  Tom Tromey  <tom@tromey.com>
4257
4258         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4259         Declare.
4260         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4261         from tui_make_status_line.
4262         (tui_locator_window::rerender): Update.
4263
4264 2019-09-20  Tom Tromey  <tom@tromey.com>
4265
4266         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4267         (tui_locator_window::rerender): Update.
4268
4269 2019-09-20  Tom Tromey  <tom@tromey.com>
4270
4271         * tui/tui-winsource.h (struct tui_source_window_base)
4272         <~tui_source_window_base>: Don't declare.
4273         <fullname>: Remove.
4274         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4275         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4276         member.
4277         * tui/tui-source.c (tui_source_window::set_contents): Update.
4278         (tui_source_window::location_matches_p)
4279         (tui_source_window::maybe_update): Update.
4280
4281 2019-09-20  Tom Tromey  <tom@tromey.com>
4282
4283         * tui/tui-winsource.h (~tui_source_element): Remove.
4284         (tui_source_element): Update.
4285         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4286         * tui/tui-winsource.c (tui_show_source_line): Update.
4287         * tui/tui-source.c (tui_source_window::set_contents): Update.
4288         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4289
4290 2019-09-20  Tom Tromey  <tom@tromey.com>
4291
4292         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4293         declare.
4294         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4295         tui_clear_source_windows_detail.
4296         * tui/tui-winsource.h (struct tui_source_window_base)
4297         <clear_detail>: Don't declare.
4298         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4299         Remove.
4300         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4301
4302 2019-09-20  Tom Tromey  <tromey@adacore.com>
4303
4304         PR ada/24919:
4305         * block.c (contained_in): Fix final return value.
4306
4307 2019-09-20  Alan Modra  <amodra@gmail.com>
4308
4309         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4310         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4311         (read_indirect_string_from_dwz): Use bfd accessor.
4312         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4313         * machoread.c (macho_symfile_read_all_oso): Likewise.
4314         * solib.c (solib_bfd_open): Likewise.
4315
4316 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4317
4318         * eval.c: Move declaration of overload_resolution to...
4319         * value.h: ...here.
4320
4321 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4322
4323         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4324         * arm-linux-tdep.c: Likewise.
4325         * arm-nbsd-nat.c: Likewise.
4326         * arm-tdep.h: Declare arm_apcs_32.
4327         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4328
4329 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4330
4331         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4332         * dwarf2read.h: Declare dwarf_always_disassemble.
4333
4334 2019-09-19  Tom de Vries  <tdevries@suse.de>
4335
4336         PR gdb/25009
4337         * source-cache.c (source_cache::ensure): Catch exception thrown during
4338         construction of the highlighter.
4339
4340 2019-09-18  Alan Modra  <amodra@gmail.com>
4341
4342         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4343         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4344         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4345         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4346         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4347         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4348         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4349         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4350         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4351         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4352         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4353         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4354         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4355         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4356         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4357         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4358         * mi/mi-interp.c: Update throughout for bfd section macro and
4359         function changes.
4360         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4361         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4362
4363 2019-09-18  Tom Tromey  <tom@tromey.com>
4364
4365         * NEWS: Add entry.
4366         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4367         call rl_initialize.
4368         (tui_enable): Do not call rl_initialize.
4369
4370 2019-09-18  Christian Groessler  <chris@groessler.org>
4371
4372         * alpha-linux-nat.c: Include gdbarch.h.
4373
4374 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4375
4376         * ui-file.c: Include cli/cli-style.h.
4377         (term_cli_styling): Remove cli_styling declaration.
4378
4379 2019-09-18  Alan Modra  <amodra@gmail.com>
4380
4381         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4382         to bfd_asymbol_section.
4383
4384 2019-09-18  Alan Modra  <amodra@gmail.com>
4385
4386         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4387         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4388         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4389
4390 2019-09-18  Alan Modra  <amodra@gmail.com>
4391
4392         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4393         * spu-linux-nat.c (spu_bfd_open): Likewise.
4394
4395 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4396
4397         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4398         to bool to match definition in dwarf2read.c.
4399
4400 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4401
4402         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4403         (print_signatures): Likewise.
4404         (trust_pad_over_xvs): Likewise.
4405         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4406         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4407         * arm-linux-nat.c (arm_apcs_32): Likewise.
4408         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4409         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4410         * arm-tdep.c (arm_debug): Likewise.
4411         (arm_apcs_32): Likewise.
4412         * auto-load.c (debug_auto_load): Likewise.
4413         (auto_load_gdb_scripts): Likewise.
4414         (global_auto_load): Likewise.
4415         (auto_load_local_gdbinit): Likewise.
4416         (auto_load_local_gdbinit_loaded): Likewise.
4417         * auto-load.h (global_auto_load): Likewise.
4418         (auto_load_local_gdbinit): Likewise.
4419         (auto_load_local_gdbinit_loaded): Likewise.
4420         * breakpoint.c (disconnected_dprintf): Likewise.
4421         (breakpoint_proceeded): Likewise.
4422         (automatic_hardware_breakpoints): Likewise.
4423         (always_inserted_mode): Likewise.
4424         (target_exact_watchpoints): Likewise.
4425         (_initialize_breakpoint): Update.
4426         * breakpoint.h (target_exact_watchpoints): Change to bool.
4427         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4428         * cli/cli-cmds.c (trace_commands): Likewise.
4429         * cli/cli-cmds.h (trace_commands): Likewise.
4430         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4431         to bool*.
4432         * cli/cli-logging.c (logging_overwrite): Change to bool.
4433         (logging_redirect): Likewise.
4434         (debug_redirect): Likewise.
4435         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4436         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4437         to bool.
4438         <boolean_option_def>: Update.
4439         (struct flag_option_def): Change default type of Context to bool
4440         from int.
4441         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4442         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4443         (get_setshow_command_value_string): Likewise.
4444         * cli/cli-style.c (cli_styling): Change to bool.
4445         (source_styling): Likewise.
4446         * cli/cli-style.h (source_styling): Likewise.
4447         (cli_styling): Likewise.
4448         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4449         to bool.
4450         * command.h (var_types): Update comment.
4451         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4452         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4453         bool.
4454         (debug_compile_cplus_scopes): Likewise.
4455         * compile/compile-internal.h (compile_debug): Likewise.
4456         * compile/compile.c (compile_debug): Likewise.
4457         (struct compile_options) <raw>: Likewise.
4458         * cp-support.c (catch_demangler_crashes): Likewise.
4459         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4460         (usr_cmd_cris_dwarf2_cfi): Likewise.
4461         * csky-tdep.c (csky_debug): Likewise.
4462         * darwin-nat.c (enable_mach_exceptions): Likewise.
4463         * dcache.c (dcache_enabled_p): Likewise.
4464         * defs.h (info_verbose): Likewise.
4465         * demangle.c (demangle): Likewise.
4466         (asm_demangle): Likewise.
4467         * dwarf-index-cache.c (debug_index_cache): Likewise.
4468         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4469         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4470         * dwarf2read.c (check_physname): Likewise.
4471         (use_deprecated_index_sections): Likewise.
4472         (dwarf_always_disassemble): Likewise.
4473         * eval.c (overload_resolution): Likewise.
4474         * event-top.c (set_editing_cmd_var): Likewise.
4475         (exec_done_display_p): Likewise.
4476         * event-top.h (set_editing_cmd_var): Likewise.
4477         (exec_done_display_p): Likewise.
4478         * exec.c (write_files): Likewise.
4479         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4480         (debug_fbsd_nat): Likewise.
4481         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4482         Likewise.
4483         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4484         <backtrace_past_entry> Likewise.
4485         * gdb-demangle.h (demangle): Likewise.
4486         (asm_demangle): Likewise.
4487         * gdb_bfd.c (bfd_sharing): Likewise.
4488         * gdbcore.h (write_files): Likewise.
4489         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4490         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4491         * gdbthread.h (print_thread_events): Likewise.
4492         * gdbtypes.c (opaque_type_resolution): Likewise.
4493         (strict_type_checking): Likewise.
4494         * gnu-nat.c (gnu_debug_flag): Likewise.
4495         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4496         * guile/scm-param.c (pascm_variable): Add boolval.
4497         (add_setshow_generic): Update.
4498         (pascm_param_value): Update.
4499         (pascm_set_param_value_x): Update.
4500         * hppa-tdep.c (hppa_debug): Change to bool..
4501         * infcall.c (may_call_functions_p): Likewise.
4502         (coerce_float_to_double_p): Likewise.
4503         (unwind_on_signal_p): Likewise.
4504         (unwind_on_terminating_exception_p): Likewise.
4505         * infcmd.c (startup_with_shell): Likewise.
4506         * inferior.c (print_inferior_events): Likewise.
4507         * inferior.h (startup_with_shell): Likewise.
4508         (print_inferior_events): Likewise.
4509         * infrun.c (step_stop_if_no_debug): Likewise.
4510         (detach_fork): Likewise.
4511         (debug_displaced): Likewise.
4512         (disable_randomization): Likewise.
4513         (non_stop): Likewise.
4514         (non_stop_1): Likewise.
4515         (observer_mode): Likewise.
4516         (observer_mode_1): Likewise.
4517         (set_observer_mode): Update.
4518         (sched_multi): Change to bool.
4519         * infrun.h (debug_displaced): Likewise.
4520         (sched_multi): Likewise.
4521         (step_stop_if_no_debug): Likewise.
4522         (non_stop): Likewise.
4523         (disable_randomization): Likewise.
4524         * linux-tdep.c (use_coredump_filter): Likewise.
4525         (dump_excluded_mappings): Likewise.
4526         * linux-thread-db.c (auto_load_thread_db): Likewise.
4527         (check_thread_db_on_load): Likewise.
4528         * main.c (captured_main_1): Update.
4529         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4530         xx2_opt, boolean_opt>: Change to bool.
4531         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4532         * maint.c (maintenance_profile_p): Likewise.
4533         (per_command_time): Likewise.
4534         (per_command_space): Likewise.
4535         (per_command_symtab): Likewise.
4536         * memattr.c (inaccessible_by_default): Likewise.
4537         * mi/mi-main.c (mi_async): Likewise.
4538         (mi_async_1): Likewise.
4539         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4540         * nat/fork-inferior.h (startup_with_shell): Likewise.
4541         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4542         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4543         * nios2-tdep.c (nios2_debug): Likewise.
4544         * or1k-tdep.c (or1k_debug): Likewise.
4545         * parse.c (parser_debug): Likewise.
4546         * parser-defs.h (parser_debug): Likewise.
4547         * printcmd.c (print_symbol_filename): Likewise.
4548         * proc-api.c (procfs_trace): Likewise.
4549         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4550         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4551         (set_parameter_value): Update.
4552         (add_setshow_generic): Update.
4553         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4554         to bool*.
4555         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4556         int*.
4557         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4558         * record-btrace.c (record_btrace_target::store_registers): Update.
4559         * record-full.c (record_full_memory_query): Change to bool.
4560         (record_full_stop_at_limit): Likewise.
4561         * record-full.h (record_full_memory_query): Likewise.
4562         * remote-notif.c (notif_debug): Likewise.
4563         * remote-notif.h (notif_debug): Likewise.
4564         * remote.c (use_range_stepping): Likewise.
4565         (interrupt_on_connect): Likewise.
4566         (remote_break): Likewise.
4567         * ser-tcp.c (tcp_auto_retry): Likewise.
4568         * ser-unix.c (serial_hwflow): Likewise.
4569         * skip.c (debug_skip): Likewise.
4570         * solib-aix.c (solib_aix_debug): Likewise.
4571         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4572         (spu_auto_flush_cache_p): Likewise.
4573         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4574         Likewise.
4575         (struct info_print_options) <quiet>: Likewise.
4576         * symfile-debug.c (debug_symfile): Likewise.
4577         * symfile.c (auto_solib_add): Likewise.
4578         (separate_debug_file_debug): Likewise.
4579         * symfile.h (auto_solib_add): Likewise.
4580         (separate_debug_file_debug): Likewise.
4581         * symtab.c (basenames_may_differ): Likewise.
4582         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4583         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4584         (struct info_types_options) <quiet>: Likewise.
4585         * symtab.h (demangle): Likewise.
4586         (basenames_may_differ): Likewise.
4587         * target-dcache.c (stack_cache_enabled_1): Likewise.
4588         (code_cache_enabled_1): Likewise.
4589         * target.c (trust_readonly): Likewise.
4590         (may_write_registers): Likewise.
4591         (may_write_memory): Likewise.
4592         (may_insert_breakpoints): Likewise.
4593         (may_insert_tracepoints): Likewise.
4594         (may_insert_fast_tracepoints): Likewise.
4595         (may_stop): Likewise.
4596         (auto_connect_native_target): Likewise.
4597         (target_stop_and_wait): Update.
4598         (target_async_permitted): Change to bool.
4599         (target_async_permitted_1): Likewise.
4600         (may_write_registers_1): Likewise.
4601         (may_write_memory_1): Likewise.
4602         (may_insert_breakpoints_1): Likewise.
4603         (may_insert_tracepoints_1): Likewise.
4604         (may_insert_fast_tracepoints_1): Likewise.
4605         (may_stop_1): Likewise.
4606         * target.h (target_async_permitted): Likewise.
4607         (may_write_registers): Likewise.
4608         (may_write_memory): Likewise.
4609         (may_insert_breakpoints): Likewise.
4610         (may_insert_tracepoints): Likewise.
4611         (may_insert_fast_tracepoints): Likewise.
4612         (may_stop): Likewise.
4613         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4614         (make_thread_apply_all_options_def_group): Change argument from int*
4615         to bool*.
4616         (thread_apply_all_command): Update.
4617         (print_thread_events): Change to bool.
4618         * top.c (confirm): Likewise.
4619         (command_editing_p): Likewise.
4620         (history_expansion_p): Likewise.
4621         (write_history_p): Likewise.
4622         (info_verbose): Likewise.
4623         * top.h (confirm): Likewise.
4624         (history_expansion_p): Likewise.
4625         * tracepoint.c (disconnected_tracing): Likewise.
4626         (circular_trace_buffer): Likewise.
4627         * typeprint.c (print_methods): Likewise.
4628         (print_typedefs): Likewise.
4629         * utils.c (debug_timestamp): Likewise.
4630         (sevenbit_strings): Likewise.
4631         (pagination_enabled): Likewise.
4632         * utils.h (sevenbit_strings): Likewise.
4633         (pagination_enabled): Likewise.
4634         * valops.c (overload_resolution): Likewise.
4635         * valprint.h (struct value_print_options) <prettyformat_arrays,
4636         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4637         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4638         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4639         Likewise.
4640         * windows-nat.c (new_console): Likewise.
4641         (cygwin_exceptions): Likewise.
4642         (new_group): Likewise.
4643         (debug_exec): Likewise.
4644         (debug_events): Likewise.
4645         (debug_memory): Likewise.
4646         (debug_exceptions): Likewise.
4647         (useshell): Likewise.
4648         * windows-tdep.c (maint_display_all_tib): Likewise.
4649         * xml-support.c (debug_xml): Likewise.
4650
4651 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4652
4653         * source.c (prepare_path_for_appending): New function.
4654         (openp): Make use of new function.
4655         (find_and_open_source): Search for the compilation directory and
4656         source file as a relative path beneath the directory search path.
4657
4658 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4659
4660         * source-cache.c (source_cache::get_line_charpos): Catch
4661         exceptions and return false, this matches the behaviour documented
4662         in the header file.
4663
4664 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4665
4666         * ada-tasks.c (info_task): Remove quoting of the task's name.
4667
4668 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4669
4670         * symfile.c (auto_solib_add): Replace comment with a reference
4671         to the header file.
4672
4673 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4674
4675         * NEWS: Mention that gdb can now be compiled with Python 3
4676         on Windows.
4677
4678 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4679
4680         * maint.c (maint_print_section_data::maint_print_section_data):
4681         Force use of 'float log10 (float)' by casting the argument to
4682         float.
4683
4684 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4685
4686         * maint.c: Add 'cmath' include.
4687         (struct maint_print_section_data): New structure.
4688         (print_section_index): New function.
4689         (print_bfd_section_info): Add header comment, small whitespace
4690         cleanup, and update to call new print_section_index function.
4691         (print_objfile_section_info): Likewise.
4692         (maint_obj_section_from_bfd_section): New function.
4693         (print_bfd_section_info_maybe_relocated): New function.
4694         (maintenance_info_sections): Add header comment, always use
4695         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4696
4697 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4698
4699         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4700         inner scope, add check that the objfile has psymtabs before
4701         checking psymtabs_addrmap.
4702         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4703
4704 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4705
4706         * NEWS: Announce that Ada task names are now shown at more places,
4707         and between quotes (except in info task output).
4708         * gdb/ada-tasks.c (task_to_str): New function.
4709         (display_current_task_id): Call task_to_str.
4710         (task_command_1): Likewise.
4711         (print_ada_task_info): In non-mi mode, Properly align headers and data
4712         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4713
4714 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4715
4716         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4717         prstatus.pr_lwp.pr_info instead of making it up.
4718
4719 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4720
4721         * auto-load.c (auto_load_expand_dir_vars): Update.
4722         * defs.h (gdb_datadir): Change to std::string.
4723         (python_libdir): Likewise.
4724         (relocate_gdb_directory): Change return type to std::string.
4725         * guile/guile.c (gdbscm_data_directory): Update.
4726         (initialize_scheme_side): Update.
4727         * jit.c (jit_reader_dir): Change to std::string.
4728         (jit_reader_load_command): Update.
4729         * main.c (gdb_datadir): Change to std::string.
4730         (python_libdir): Likewise.
4731         (set_gdb_data_directory): Update.
4732         (relocate_path): Change to return std::string.
4733         (relocate_gdb_directory): Change to return std::string.
4734         (relocate_gdbinit_path_maybe_in_datadir): Update.
4735         (captured_main_1): Update.
4736         * python/python.c (do_start_initialization): Update.
4737         * top.c (show_gdb_datadir): Update.
4738         * xml-syscall.c (xml_init_syscalls_info): Update.
4739         (init_syscalls_info): Update.
4740
4741 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4742
4743         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4744         out of get_init_files.
4745         (get_init_files): Update.
4746
4747 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4748
4749         * main.c (get_init_files): Change to use std::string.
4750         (captured_main_1): Update.
4751         (print_gdb_help): Update.
4752
4753 2019-09-11  Ali Tamur  <tamur@google.com>
4754
4755         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4756         implementation.
4757
4758 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4759
4760         * dbxread.c (read_dbx_symtab): Update.
4761         * dwarf2read.c (load_partial_dies): Update.
4762         * mdebugread.c (parse_partial_symbols): Update.
4763         (handle_psymbol_enumerators): Update.
4764         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4765         * psymtab.c (add_psymbol_to_bcache): Likewise.
4766         (add_psymbol_to_list): Likewise.
4767         * symtab.c (symbol_set_names): Likewise.
4768         * symtab.h (symbol_set_names): Likewise.
4769         * xcoffread.c (scan_xcoff_symtab): Update.
4770
4771 2019-09-11  Tom Tromey  <tom@tromey.com>
4772
4773         * symfile-mem.c (symbol_file_add_from_memory): Use
4774         bfd_set_filename.
4775         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4776         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4777
4778 2019-09-10  Tom Tromey  <tromey@adacore.com>
4779
4780         * dwarf-index-write.c (write_psymbols): Extend error message.
4781         (debug_names::insert): Add Ada code.
4782         (debug_names::write_psymbols): Remove Ada check.
4783         (debug_names) <m_string_obstack>: New member.
4784         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4785         (gdb_index_symbol_name_matcher::matches): Remove.
4786         (mapped_index_base::find_name_components_bounds): Add "lang"
4787         parameter.
4788         (mapped_index_base::build_name_components): Also split names
4789         according to Ada syntax.
4790         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4791         type of "match_callback".
4792         (check_match, check_find_bounds_finds)
4793         (dw2_expand_symtabs_matching): Update.
4794         (dw2_debug_names_iterator): Add new constructor.
4795         (dw2_debug_names_map_matching_symbols): New function.
4796         (dw2_debug_names_expand_symtabs_matching): Update.
4797         (dwarf2_debug_names_functions): Use
4798         dw2_debug_names_map_matching_symbols.
4799
4800 2019-09-10  Tom Tromey  <tromey@adacore.com>
4801
4802         * dwarf2read.c (dw2_get_file_names_reader): Add the
4803         CU's file name to the results.
4804
4805 2019-09-10  Tom Tromey  <tromey@adacore.com>
4806
4807         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4808         map_matching_symbols.  Update.
4809         * dwarf2read.c (dw2_map_matching_symbols): Update.
4810         * psymtab.c (match_partial_symbol): Change type; update.
4811         (psym_map_matching_symbols): Likewise.
4812         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4813         type; update.
4814         * symfile.h (struct quick_symbol_functions)
4815         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4816         Remove "match".
4817
4818 2019-09-10  Tom Tromey  <tromey@adacore.com>
4819
4820         * psymtab.c (map_block): Remove.
4821         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4822         * symtab.c (iterate_over_symbols_terminated): New function.
4823         * symtab.c (iterate_over_symbols_terminated): Declare.
4824
4825 2019-09-10  Tom Tromey  <tromey@adacore.com>
4826
4827         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4828         * language.h (struct language_defn) <la_iterate_over_symbols>:
4829         Return bool.
4830         * symtab.c (iterate_over_symbols): Return bool.
4831         * symtab.h (iterate_over_symbols): Return bool.
4832
4833 2019-09-10  Tom Tromey  <tromey@adacore.com>
4834
4835         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4836         (add_nonlocal_symbols): Update.
4837         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4838         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4839         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4840         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4841         Change type of "callback".  Remove "data".
4842
4843
4844 2019-09-09  Ali Tamur  <tamur@google.com>
4845
4846         * dwarf2read.c (comp_unit_head): Update comment.
4847         (dwarf2_dwo_name): New function declaration.
4848         (dwarf_unit_type_name): New function declaration.
4849         (read_comp_unit_head): Add support for new compilation units,
4850         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4851         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4852         (currently named as "signature") in their header. Also clarify error
4853         messages.
4854         (lookup_dwo_id): New function. Returns the dwo id of the given
4855         compile unit.
4856         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4857         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4858         functions.
4859         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4860         (dwarf2_dwo_name): Get the dwo name if present.
4861         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4862         purposes.
4863
4864 2019-09-09  Tom Tromey  <tom@tromey.com>
4865
4866         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4867
4868 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4869
4870         * python/python.c (do_start_initialization): Make progname_copy static,
4871         to avoid a leak report.
4872
4873 2019-09-08  Tom Tromey  <tom@tromey.com>
4874
4875         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4876
4877 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4878
4879         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4880         Change type to gdb::optional<block_enum>.
4881         (dw2_symtab_iter_init): Change block_index parameter type
4882         to gdb::optional<block_enum>.
4883         (dw2_lookup_symbol): Change block_index parameter
4884         type to block_enum.c
4885         (dw2_debug_names_lookup_symbol): Likewise.
4886         * psymtab.c (psym_lookup_symbol): Likewise.
4887         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4888         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4889         Likewise.
4890
4891 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4892
4893         * defs.h (relocate_gdb_directory): Change int to bool in
4894         signature and rename flag to relocatable.
4895         * main.c (relocate_path): Likewise.
4896         (relocate_gdb_directory): Likewise.
4897
4898 2019-09-06  Alan Modra  <amodra@gmail.com>
4899
4900         * coffread.c (coff_symfile_read): Constify filename variable.
4901         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4902         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4903         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4904         * solib.c (reload_shared_libraries_1): Likewise.
4905         * symfile.c (reread_symbols): Likewise.
4906         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4907         * solib-darwin.c (darwin_bfd_open): Likewise.
4908         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4909
4910 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4911
4912         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4913         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4914
4915 2019-09-03  Tom Tromey  <tromey@adacore.com>
4916
4917         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4918         types.
4919         (has_negatives): Unbias a range type bound.
4920         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4921         * gdbtypes.c (operator==): Handle new field.
4922         (create_range_type): Add "bias" parameter.
4923         (create_static_range_type, resolve_dynamic_range): Update.
4924         * gdbtypes.h (struct range_bounds) <bias>: New member.
4925         (create_range_type): Add bias parameter.
4926         * printcmd.c (print_scalar_formatted): Unbias range types.
4927         * value.c (unpack_long): Unbias range types.
4928         (pack_long): Bias range types.
4929
4930 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4931
4932         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4933         probe arguments.
4934
4935 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4936
4937         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4938         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4939         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4940         (compile_probe_arg): Likewise.
4941         * probe.h (get_argument_count): Likewise.
4942         * solib-svr4.c (solib_event_probe_action): Likewise.
4943         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4944
4945 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4946
4947         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4948         code to here...
4949         (svr4_create_solib_event_breakpoints): ...from here.
4950
4951 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4952
4953         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4954         suffix from warning message.
4955
4956 2019-08-30  Tom Tromey  <tom@tromey.com>
4957
4958         * tui/tui-winsource.h (struct tui_source_window_base)
4959         <refresh_all>: Don't declare.
4960         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4961         Remove.
4962         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4963         tui_show_locator_content.
4964         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4965         declare.
4966         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4967         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4968         declare.
4969
4970 2019-08-30  Tom Tromey  <tom@tromey.com>
4971
4972         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4973
4974 2019-08-30  Tom Tromey  <tom@tromey.com>
4975
4976         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4977         Remove unnecessary forward declarations.
4978
4979 2019-08-30  Tom Tromey  <tom@tromey.com>
4980
4981         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4982         rerender.
4983         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4984         tui_show_locator_content.
4985
4986 2019-08-30  Tom Tromey  <tom@tromey.com>
4987
4988         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4989         (tui_locator_window::rerender): Rewrite using body of previous
4990         tui_show_locator_content.
4991
4992 2019-08-30  Tom Tromey  <tom@tromey.com>
4993
4994         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4995         set_locator_fullname>: New methods.
4996         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4997         Rename from tui_set_locator_fullname.
4998         (tui_locator_window::set_locator_info): Rename from
4999         tui_set_locator_info.  Return bool.
5000         (tui_update_locator_fullname, tui_show_frame_info): Update.
5001
5002 2019-08-30  Tom Tromey  <tom@tromey.com>
5003
5004         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5005
5006 2019-08-30  Tom Tromey  <tom@tromey.com>
5007
5008         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5009         call touchwin.
5010
5011 2019-08-30  Tom Tromey  <tom@tromey.com>
5012
5013         * tui/tui-wingeneral.c (box_win): Assume win_info and
5014         win_info->handle cannot be NULL.
5015
5016 2019-08-30  Tom Tromey  <tom@tromey.com>
5017
5018         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5019         refresh_window>: Declare.
5020         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5021         resize.
5022         (tui_data_item_window::rerender): Rename from
5023         tui_display_register.
5024         (tui_data_item_window::refresh_window): New method.
5025         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5026         no-op.
5027
5028 2019-08-30  Tom Tromey  <tom@tromey.com>
5029
5030         * tui/tui-regs.h (struct tui_data_window) <regs_content,
5031         regs_column_count, current_group>: Move later.  Now private.
5032         <get_current_group>: New method.
5033         * tui/tui-regs.c (tui_reg_command): Update.
5034         * tui/tui-layout.c (tui_set_layout): Update.
5035
5036 2019-08-30  Tom Tromey  <tom@tromey.com>
5037
5038         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5039         (tui_data_window::rerender): Don't call
5040         check_and_display_highlight_if_needed.
5041         (tui_data_window::refresh_all): Remove call to
5042         erase_data_content.
5043
5044 2019-08-30  Tom Tromey  <tom@tromey.com>
5045
5046         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5047         (tui_data_window::display_registers_from)
5048         (tui_data_window::display_reg_element_at_line)
5049         (tui_data_window::display_registers_from_line): Remove checks of
5050         "empty".
5051
5052 2019-08-30  Tom Tromey  <tom@tromey.com>
5053
5054         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5055         Don't declare.
5056         * tui/tui-regs.c (tui_data_window::show_registers): Call
5057         rerender.
5058         (tui_data_window::rerender): Rename from display_all_data.
5059         (tui_data_window::rerender): Remove old implementation.
5060
5061 2019-08-30  Tom Tromey  <tom@tromey.com>
5062
5063         * tui/tui-regs.c (tui_data_window::display_all_data): Change
5064         text.
5065         * tui/tui-data.h (NO_DATA_STRING): Remove define.
5066
5067 2019-08-29  Bernhard Wodok  <barto@gmx.net>
5068             Sergio Durigan Junior  <sergiodj@redhat.com>
5069
5070         PR win32/24284
5071         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5072
5073 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5074
5075         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5076         when searching for types.
5077
5078 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5079
5080         * f-lang.c (f_language_defn): Use f_print_typedef.
5081         * f-lang.h (f_print_typedef): Declare.
5082         * f-typeprint.c (f_print_typedef): Define.
5083
5084 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
5085
5086         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5087
5088 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5089
5090         * cli/cli-utils.c (info_print_options_defs): Delete.
5091         (make_info_print_options_def_group): Delete.
5092         (extract_info_print_options): Delete.
5093         (info_print_command_completer): Delete.
5094         (info_print_args_help): Add extra parameter, and optionally
5095         include text about -n flag.
5096         * cli/cli-utils.h (struct info_print_options): Delete.
5097         (extract_info_print_options): Delete declaration.
5098         (info_print_command_completer): Delete declaration.
5099         (info_print_args_help): Add extra parameter, extend header
5100         comment.
5101         * python/python.c (gdbpy_rbreak): Pass additional parameter to
5102         search_symbols.
5103         * stack.c (struct info_print_options): New type.
5104         (info_print_options_defs): New file scoped variable.
5105         (make_info_print_options_def_group): New static function.
5106         (info_print_command_completer): New static function.
5107         (info_locals_command): Update to use new local functions.
5108         (info_args_command): Likewise.
5109         (_initialize_stack): Add extra parameter to calls to
5110         info_print_args_help.
5111         * symtab.c (search_symbols): Add extra parameter, use this to
5112         possibly excluse non-debug symbols.
5113         (symtab_symbol_info): Add extra parameter, which is passed on to
5114         search_symbols.
5115         (struct info_print_options): New type.
5116         (info_print_options_defs): New file scoped variable.
5117         (make_info_print_options_def_group): New static function.
5118         (info_print_command_completer): New static function.
5119         (info_variables_command): Update to use local functions, and pass
5120         extra parameter through to symtab_symbol_info.
5121         (info_functions_command): Likewise.
5122         (info_types_command): Pass additional argument through to
5123         symtab_symbol_info.
5124         (rbreak_command): Pass extra argument to search_symbols.
5125         (_initialize_symtab): Add extra arguments for calls to
5126         info_print_args_help, and update help text for 'info variables',
5127         'whereis', and 'info functions' commands.
5128         * symtab.h (search_symbols): Add extra argument to declaration.
5129         * NEWS: Mention new flags.
5130
5131 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5132
5133         * symtab.c (lookup_static_symbol): Call the new function (and move
5134         it down to be next to lookup_global_symbol).
5135         (struct global_sym_lookup_data): Add block_enum member and rename to...
5136         (struct global_or_static_sym_lookup_data): ...this.
5137         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5138         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5139         (lookup_symbol_global_or_static_iterator_cb): ...this.
5140         (lookup_global_or_static_symbol): New function.
5141         (lookup_global_symbol): Call new function.
5142
5143 2019-08-26  Tom de Vries  <tdevries@suse.de>
5144
5145         PR c++/24852
5146         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5147         when pc_probe.prob == NULL.
5148
5149 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5150
5151         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5152         variable symbol_linkage to symbol_linkage_.
5153
5154 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5155
5156         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5157         represent whether the symbol is static, dynamic, or we don't
5158         know.
5159
5160 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5161
5162         * gdb/rx-tdep.c (rx_register_names): New.
5163         (rx_register_name): Delete.
5164         (rx_psw_type): Delete.
5165         (rx_fpsw_type): Delete.
5166         (rx_register_type): Delete.
5167         (rx_gdbarch_init): Convert target-descriptions.
5168         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5169         * gdb/features/Makefile: Add rx.xml.
5170         * gdb/features/rx.xml: New.
5171         * gdb/features/rx.c: Generated.
5172         * gdb/NEWS: Mention target description support.
5173
5174 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5175
5176         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5177         *slot_ptr.
5178
5179 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5180
5181         * configure.ac: Don't check for 'dlfcn.h' (moved to
5182         gdbsupport/common.m4).
5183         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5184         'gdbsupport/'.
5185         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5186         * compile/compile-c-support.c: Include
5187         'gdbsupport/gdb-dlfcn.h'.
5188         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5189         * gdb-dlfcn.c: Move to...
5190         * gdbsupport/gdb-dlfcn.c: ... here.
5191         * gdb-dlfcn.h: Move to...
5192         * gdbsupport/gdb-dlfcn.h: ... here.
5193
5194 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5195
5196         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5197         the offset field signed.
5198
5199 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5200
5201         * python/lib/gdb/__init__.py (_execute_file): New function.
5202         * python/python.c (python_run_simple_file): Call gdb._execute_file
5203         on Windows.
5204
5205 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5206
5207         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5208         all uses as this was never set to anything but a zero value.
5209
5210 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5211
5212         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5213
5214 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5215
5216         * tui/tui-data.h (tui_gen_win_info): Add an =default
5217         move constructor, required by some GCC versions.
5218
5219 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5220
5221         * go32-nat.c (go32_sysinfo): Add hygon_p.
5222
5223 2019-08-20  Tom Tromey  <tom@tromey.com>
5224
5225         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5226         line_from_reg_element_no, first_reg_element_no_inline,
5227         display_all_data, delete_data_content_windows,
5228         erase_data_content>: Now private.
5229
5230 2019-08-20  Tom Tromey  <tom@tromey.com>
5231
5232         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5233         (tui_unhighlight_win, tui_highlight_win)
5234         (tui_win_info::make_window): Update.
5235         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5236
5237 2019-08-20  Tom Tromey  <tom@tromey.com>
5238
5239         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5240         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5241         (MAX_PID_WIDTH): Move to tui-stack.c.
5242         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5243         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5244         (MAX_PID_WIDTH): Move from tui-data.h.
5245
5246 2019-08-20  Tom Tromey  <tom@tromey.com>
5247
5248         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5249         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5250         (box_win): Update.
5251         (tui_gen_win_info::make_window): Rename from tui_make_window.
5252         (tui_win_info::make_window): New method.
5253         (tui_gen_win_info::make_visible): Update.
5254         * tui/tui-source.c (tui_source_window::set_contents): Update.
5255         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5256         (tui_data_window::display_registers_from): Update.
5257         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5258         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5259         Declare.
5260         <can_box>: Remove.
5261         <title>: Remove.
5262         (struct tui_win_info) <make_window>: Declare.
5263         <can_box>: Now virtual.
5264         <title>: New member.
5265         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5266         * tui/tui-command.c (tui_cmd_window::resize): Update.
5267
5268 2019-08-20  Tom Tromey  <tom@tromey.com>
5269
5270         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5271         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5272         (tui_data_window::check_register_values): Update.
5273
5274 2019-08-20  Tom Tromey  <tom@tromey.com>
5275
5276         * tui/tui-regs.h (struct tui_data_window): Use
5277         DISABLE_COPY_AND_ASSIGN.
5278         <regs_content>: Change type, removing unique_ptr.
5279         <tui_data_window>: Add move constructor.
5280         * tui/tui-regs.c (tui_data_window::show_registers)
5281         (tui_data_window::show_register_group)
5282         (tui_data_window::display_registers_from)
5283         (tui_data_window::display_registers_from)
5284         (tui_data_window::first_data_item_displayed)
5285         (tui_data_window::delete_data_content_windows)
5286         (tui_data_window::rerender, tui_data_window::refresh_window)
5287         (tui_data_window::check_register_values): Update.
5288
5289 2019-08-20  Tom Tromey  <tom@tromey.com>
5290
5291         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5292         show_register_group>: Declare.
5293         (tui_show_register_group): Don't declare.
5294         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5295         tui_show_registers.
5296         (tui_data_window::show_register_group): Rename from
5297         tui_show_register_group.
5298         (tui_data_window::check_register_values, tui_reg_command):
5299         Update.
5300         * tui/tui-layout.c (tui_set_layout): Update.
5301
5302 2019-08-20  Tom Tromey  <tom@tromey.com>
5303
5304         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5305         Declare.
5306         (tui_check_register_values): Don't declare.
5307         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5308         from tui_check_register_values.
5309         * tui/tui-hooks.c (tui_register_changed): Update.
5310
5311 2019-08-20  Tom Tromey  <tom@tromey.com>
5312
5313         * tui/tui-regs.c (tui_reg_layout): Move later.
5314         (tui_show_registers): Don't enable TUI mode or change layout.
5315
5316 2019-08-20  Tom Tromey  <tom@tromey.com>
5317
5318         * tui/tui-regs.h (struct tui_data_item_window)
5319         <~tui_data_item_window>: Remove.
5320         <content>: Now a unique_xmalloc_ptr.
5321         * tui/tui-regs.c (tui_register_format): Return a
5322         unique_xmalloc_ptr.
5323         (tui_get_register): Update.
5324         (~tui_data_item_window): Remove.
5325         (tui_data_window::display_registers_from, tui_display_register):
5326         Update.
5327         * tui/tui-io.h (tui_expand_tabs): Update.
5328         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5329         Remove "col" parameter.
5330
5331 2019-08-20  Tom Tromey  <tom@tromey.com>
5332
5333         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5334         field.
5335         * tui/tui-regs.c (~tui_data_item_window): Update.
5336
5337 2019-08-20  Tom Tromey  <tom@tromey.com>
5338
5339         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5340         earlier.
5341
5342 2019-08-20  Tom Tromey  <tom@tromey.com>
5343
5344         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5345
5346 2019-08-20  Tom Tromey  <tom@tromey.com>
5347
5348         * tui/tui-source.h (struct tui_source_window): Update.
5349         * tui/tui-regs.c (tui_show_registers): Update.
5350         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5351         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5352         (NO_REGS_STRING): Remove defines.
5353
5354 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5355
5356         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5357         unnecessary thread walk if remote doesn't support the packet.
5358
5359 2019-08-19  Tom Tromey  <tromey@adacore.com>
5360
5361         * python/py-value.c (value_has_field): Fix indentation.
5362
5363 2019-08-19  Tom Tromey  <tromey@adacore.com>
5364
5365         * printcmd.c (do_one_display, info_display_command): Update.
5366         * block.h (contained_in): Return bool.  Add allow_nested
5367         parameter.
5368         * block.c (contained_in): Return bool.  Add allow_nested
5369         parameter.
5370
5371 2019-08-19  Tom Tromey  <tom@tromey.com>
5372
5373         * configure: Rebuild.
5374         * configure.ac: Disallow the combination of -static-libstdc++ and
5375         source highlight.
5376         * source-cache.c (get_language_name): Handle rust.
5377         (source_cache::get_source_lines): Ignore highlighting exceptions.
5378
5379 2019-08-16  Tom Tromey  <tom@tromey.com>
5380
5381         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5382         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5383         (struct tui_source_window_base) <make_visible, refresh_window,
5384         resize>: Remove methods.
5385         <execution_info>: Remove field.
5386         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5387         (tui_show_source_line, tui_source_window_base)
5388         (~tui_source_window_base): Update.
5389         (tui_source_window_base::resize)
5390         (tui_source_window_base::make_visible)
5391         (tui_source_window_base::refresh_window): Remove.
5392         (tui_source_window_base::update_exec_info): Update.
5393         * tui/tui-source.c (tui_source_window::set_contents): Update.
5394         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5395
5396 2019-08-16  Tom Tromey  <tom@tromey.com>
5397
5398         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5399         deprecated_query_hook.
5400
5401 2019-08-16  Tom Tromey  <tom@tromey.com>
5402
5403         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5404         (tui_update_source_windows_with_line): Update.
5405         * tui/tui-source.h (struct tui_source_window)
5406         <show_symtab_source>: Declare.
5407         (tui_show_symtab_source): Don't declare.
5408         * tui/tui-source.c (tui_show_symtab_source): Rename from
5409         tui_show_symtab_source.
5410
5411 2019-08-16  Tom Tromey  <tom@tromey.com>
5412
5413         * tui/tui-winsource.h (struct tui_source_window_base)
5414         <set_contents>: Declare.
5415         * tui/tui-winsource.c
5416         (tui_source_window_base::update_source_window_as_is): Update.
5417         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5418         Declare.
5419         (tui_set_source_content): Don't declare.
5420         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5421         tui_set_source_content.
5422         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5423         Declare.
5424         (tui_set_disassem_content): Don't declare.
5425         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5426         tui_set_disassem_content.
5427
5428 2019-08-16  Tom Tromey  <tom@tromey.com>
5429
5430         * tui/tui-winsource.h (struct tui_source_window_base)
5431         <update_breakpoint_info>: Declare.
5432         (tui_update_breakpoint_info): Don't declare.
5433         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5434         (tui_update_all_breakpoint_info): Update.
5435         (tui_source_window_base::update_breakpoint_info): Rename from
5436         tui_update_breakpoint_info.
5437         (tui_source_window_base::update_exec_info): Update.
5438
5439 2019-08-16  Tom Tromey  <tom@tromey.com>
5440
5441         * tui/tui-winsource.h (struct tui_source_window_base)
5442         <update_source_window>: Declare.
5443         (tui_update_source_window): Don't declare.
5444         * tui/tui-winsource.c
5445         (tui_source_window_base::update_source_window): Rename from
5446         tui_update_source_window.
5447         (tui_source_window_base::rerender): Update.
5448         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5449         * tui/tui-disasm.c (tui_show_disassem)
5450         (tui_show_disassem_and_update_source)
5451         (tui_disasm_window::maybe_update): Update.
5452
5453 2019-08-16  Tom Tromey  <tom@tromey.com>
5454
5455         * tui/tui-winsource.h (struct tui_source_window_base)
5456         <update_source_window_as_is>: Declare.
5457         (tui_update_source_window_as_is): Don't declare.
5458         * tui/tui-winsource.c (tui_update_source_window): Update
5459         (tui_source_window_base::update_source_window_as_is): Rename from
5460         tui_update_source_window_as_is.
5461         (tui_source_window_base::refill): Update.
5462         * tui/tui-source.c (tui_show_symtab_source): Update.
5463         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5464         Update.
5465
5466 2019-08-16  Tom Tromey  <tom@tromey.com>
5467
5468         * tui/tui-winsource.h (tui_update_source_window)
5469         (tui_update_source_window_as_is): Remove "noerror" parameter.
5470         * tui/tui-winsource.c (tui_update_source_window)
5471         (tui_update_source_window_as_is): Remove "noerror" parameter.
5472         (tui_update_source_windows_with_addr)
5473         (tui_update_source_windows_with_line)
5474         (tui_source_window_base::rerender)
5475         (tui_source_window_base::refill): Update.
5476         * tui/tui-source.h (tui_set_source_content)
5477         (tui_show_symtab_source): Remove "noerror" parameter.
5478         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5479         parameter.
5480         (tui_show_symtab_source): Likewise.
5481         (tui_source_window::maybe_update): Update.
5482         * tui/tui-disasm.c (tui_show_disassem)
5483         (tui_show_disassem_and_update_source)
5484         (tui_disasm_window::do_scroll_vertical)
5485         (tui_disasm_window::maybe_update): Update.
5486
5487 2019-08-16  Tom Tromey  <tom@tromey.com>
5488
5489         * tui/tui.c (tui_is_window_visible): Update.
5490         * tui/tui-wingeneral.c (tui_make_window)
5491         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5492         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5493         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5494         (tui_set_win_height_command, parse_scrolling_args): Update.
5495         * tui/tui-source.c (tui_source_window::style_changed): Update.
5496         * tui/tui-regs.c (tui_show_registers)
5497         (tui_data_window::first_data_item_displayed)
5498         (tui_data_window::delete_data_content_windows)
5499         (tui_check_register_values, tui_reg_command): Update.
5500         * tui/tui-disasm.c (tui_show_disassem): Update.
5501         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5502         method.
5503         <is_visible>: Remove field.
5504         * tui/tui-data.c (tui_next_win, tui_prev_win)
5505         (tui_delete_invisible_windows): Update.
5506
5507 2019-08-16  Tom Tromey  <tom@tromey.com>
5508
5509         * tui/tui-winsource.h (struct tui_source_window_base)
5510         <m_has_locator>: Remove.
5511         * tui/tui-layout.c (show_source_disasm_command, show_data)
5512         (show_source_or_disasm_and_command): Update.
5513
5514 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5515
5516         * NEWS (Other MI changes): New subsection.
5517         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5518         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5519         * arch-utils.c (default_get_pc_address_flags): New function.
5520         * arch-utils.h (default_get_pc_address_flags): New declaration.
5521         * gdbarch.sh: Add get_pc_address_flags.
5522         * gdbarch.c: Regenerate.
5523         * gdbarch.h: Likewise.
5524         * stack.c (print_pc): New function.
5525         (print_frame_info) (print_frame): Call print_pc.
5526
5527 2019-08-16  Tom de Vries  <tdevries@suse.de>
5528
5529         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5530         print_objfile_section_info.
5531
5532 2019-08-15  Tom Tromey  <tom@tromey.com>
5533
5534         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5535         calling update_cmdwin_start_line.
5536         * tui/tui-winsource.h (struct tui_source_window_base)
5537         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5538         <rerender>: Declare.
5539         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5540         Call rerender.
5541         (tui_source_window_base::set_new_height): Remove.
5542         (tui_source_window_base::rerender): Rename from
5543         do_make_visible_with_new_height.
5544         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5545         resize method.
5546         (tui_win_info::make_invisible_and_set_new_height)
5547         (tui_win_info::make_visible_with_new_height): Remove.
5548         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5549         Declare.
5550         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5551         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5552         do_make_visible_with_new_height>: Don't declare.
5553         <rerender>: Declare.
5554         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5555         set_new_height.
5556         (tui_data_window::do_make_visible_with_new_height): Remove.
5557         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5558         call tui_show_locator_content.
5559         (tui_gen_win_info::resize): Call rerender.
5560         (show_source_or_disasm_and_command): Don't call
5561         tui_show_locator_content.
5562         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5563         method.
5564         (struct tui_win_info) <rerender>: Declare.
5565         <set_new_height, make_invisible_and_set_new_height,
5566         make_visible_with_new_height>: Don't declare.
5567         * tui/tui-data.c (tui_win_list::rerender): New method.
5568         * tui/tui-command.h (struct tui_cmd_window)
5569         <do_make_visible_with_new_height>: Don't declare.
5570         * tui/tui-command.c
5571         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5572
5573 2019-08-15  Tom Tromey  <tromey@adacore.com>
5574
5575         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5576         * ada-lang.c (ada_enum_name): Likewise.
5577
5578 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5579
5580         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5581         leading underscore.
5582         (GdbOutputErrorFile): Likewise.
5583         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5584         accordingly.
5585         (execute_unwinders): Rename to have a leading underscore.
5586         (auto_load_packages): Likewise.
5587         (global scope): Adjust call to auto_load_packages accordingly.
5588         (GdbSetPythonDirectory): Likewise.
5589         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5590         instead of execute_unwinders.
5591
5592 2019-08-15  Tom Tromey  <tom@tromey.com>
5593
5594         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5595         (show_data): Don't change window visibility.
5596         (tui_gen_win_info::resize): Remove special case for command
5597         window.  Use wresize, when available.
5598         (show_source_or_disasm_and_command): Don't change window
5599         visibility.
5600         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5601         <make_visible>: New method.
5602         * tui/tui-command.c (tui_cmd_window::resize): New method.
5603
5604 2019-08-15  Tom Tromey  <tom@tromey.com>
5605
5606         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5607         (struct tui_source_windows): New.
5608         * tui/tui-winsource.c (tui_display_main): Update.
5609         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5610         (new_height_ok, parse_scrolling_args): Update.
5611         * tui/tui-layout.c (show_layout, show_data): Update.
5612         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5613         (tui_add_to_source_windows): Don't declare.
5614         * tui/tui-data.c (source_windows, tui_source_windows)
5615         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5616
5617 2019-08-15  Tom Tromey  <tom@tromey.com>
5618
5619         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5620         Rename from reset.
5621         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5622         * tui/tui-layout.c (show_source_disasm_command, show_data):
5623         Update.
5624         (tui_gen_win_info::resize): Rename.
5625         (show_source_or_disasm_and_command): Update.
5626         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5627         reset.
5628
5629 2019-08-15  Tom Tromey  <tom@tromey.com>
5630
5631         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5632         * tui/tui-interp.c (tui_interp::init): Don't call
5633         tui_initialize_static_data.
5634         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5635
5636 2019-08-15  Tom Tromey  <tom@tromey.com>
5637
5638         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5639         examine tui_win_list.
5640
5641 2019-08-15  Tom Tromey  <tom@tromey.com>
5642
5643         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5644         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5645         tui_clear_source_content.
5646         (tui_clear_source_content): Remove.
5647         (tui_source_window_base::do_erase_source_content): Hoist call to
5648         content.clear().
5649         * tui/tui-stack.c (tui_show_frame_info): Don't call
5650         tui_clear_source_content.
5651
5652 2019-08-15  Tom Tromey  <tom@tromey.com>
5653
5654         * tui/tui-winsource.h (struct tui_source_window_base)
5655         <do_erase_source_content>: New method.
5656         <erase_source_content>: New method.
5657         (tui_erase_source_content): Don't declare.
5658         * tui/tui-winsource.c (tui_clear_source_content): Update.
5659         (tui_source_window_base::do_erase_source_content): Rename from
5660         tui_erase_source_content.
5661         (tui_source_window_base::show_source_content): Update.
5662         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5663         * tui/tui-source.h (struct tui_source_window)
5664         <erase_source_content>: New method.
5665         * tui/tui-disasm.h (struct tui_disasm_window)
5666         <erase_source_content>: New method.
5667
5668 2019-08-15  Tom Tromey  <tom@tromey.com>
5669
5670         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5671         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5672         constructor.
5673         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5674         * tui/tui-source.c (tui_set_source_content): Update.
5675         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5676
5677 2019-08-15  Tom Tromey  <tom@tromey.com>
5678
5679         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5680         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5681         tui-source.c.
5682         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5683         Declare.
5684         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5685         method.
5686         (tui_source_window::maybe_update): Update.
5687
5688 2019-08-15  Tom Tromey  <tom@tromey.com>
5689
5690         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5691         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5692         tui-disasm.c.
5693         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5694         Declare.
5695         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5696         method.
5697         (tui_disasm_window::maybe_update): Update.
5698
5699 2019-08-15  Tom Tromey  <tom@tromey.com>
5700
5701         * tui/tui-winsource.h (struct tui_source_window_base)
5702         <maybe_update>: Declare.
5703         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5704         method.
5705         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5706         Declare.
5707         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5708         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5709         Declare.
5710         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5711
5712 2019-08-15  Tom Tromey  <tom@tromey.com>
5713
5714         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5715
5716 2019-08-15  Tom Tromey  <tom@tromey.com>
5717
5718         * tui/tui-wingeneral.c: Include tui-stack.h.
5719         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5720         (struct tui_locator_window): Move from tui-data.h.
5721         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5722         (tui_initialize_static_data): Move from tui-data.c.
5723         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5724         (struct tui_locator_window): Move to tui-stack.c.
5725         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5726         (tui_initialize_static_data): Move to tui-stack.c.
5727
5728 2019-08-15  Tom Tromey  <tom@tromey.com>
5729
5730         * tui/tui-layout.c (show_source_disasm_command)
5731         (show_source_or_disasm_and_command): Use make_visible method, not
5732         tui_make_window.
5733         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5734         Remove.
5735
5736 2019-08-15  Tom Tromey  <tom@tromey.com>
5737
5738         * tui/tui-wingeneral.h (tui_make_window): Update.
5739         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5740         parameter.
5741         (tui_gen_win_info::make_visible): Update.
5742         * tui/tui-regs.c (tui_data_window::display_registers_from):
5743         Update.
5744         * tui/tui-layout.c (show_source_disasm_command)
5745         (show_source_or_disasm_and_command): Update.
5746         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5747         (enum tui_box): Remove.
5748         (struct tui_win_info) <can_box>: New method.
5749         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5750         method.
5751
5752 2019-08-15  Tom de Vries  <tdevries@suse.de>
5753
5754         * linux-nat-trad.c: Include gdbarch.h.
5755
5756 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5757
5758         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5759         register sizes.
5760
5761 2019-08-14  Tom Tromey  <tromey@adacore.com>
5762
5763         * darwin-nat.c: Include gdbarch.h.
5764         * darwin-nat-info.c: Include gdbarch.h.
5765
5766 2019-08-13  Tom Tromey  <tom@tromey.com>
5767
5768         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5769         Remove.
5770         * tui/tui-data.c (tui_initialize_static_data): Update.
5771
5772 2019-08-13  Tom Tromey  <tom@tromey.com>
5773
5774         * tui/tui-winsource.h (struct tui_exec_info_window)
5775         <~tui_exec_info_window, maybe_allocate_content, get_content,
5776         m_content>: Remove.
5777         (struct tui_source_window_base) <set_exec_info_content,
5778         show_exec_info_content>: Don't declare.
5779         * tui/tui-winsource.c
5780         (tui_exec_info_window::maybe_allocate_content): Remove.
5781         (tui_source_window_base::update_exec_info): Rename from
5782         set_exec_info_content.
5783         (tui_source_window_base::show_exec_info_content)
5784         (tui_source_window_base::update_exec_info): Remove.
5785
5786 2019-08-13  Tom Tromey  <tom@tromey.com>
5787
5788         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5789         declare.
5790         * tui/tui-winsource.c (tui_update_source_window_as_is)
5791         (tui_update_source_windows_with_addr, tui_erase_source_content):
5792         Update.
5793         (tui_clear_exec_info_content): Remove.
5794
5795 2019-08-13  Tom Tromey  <tom@tromey.com>
5796
5797         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5798         declare.
5799         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5800         call tui_erase_exec_info_content.
5801         (tui_clear_exec_info_content): Rename from
5802         tui_erase_exec_info_content.
5803         (tui_clear_exec_info_content): Delete.
5804
5805 2019-08-13  Tom Tromey  <tom@tromey.com>
5806
5807         * tui/tui-winsource.h (struct tui_source_window_base)
5808         <show_exec_info_content>: Declare.
5809         (tui_show_exec_info_content): Don't declare.
5810         * tui/tui-winsource.c
5811         (tui_source_window_base::show_exec_info_content): Rename from
5812         tui_show_exec_info_content.
5813         (tui_source_window_base::update_exec_info): Update.
5814
5815 2019-08-13  Tom Tromey  <tom@tromey.com>
5816
5817         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5818         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5819         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5820         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5821         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5822         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5823         ... here.
5824
5825 2019-08-13  Tom Tromey  <tom@tromey.com>
5826
5827         * tui/tui-winsource.h (struct tui_source_window_base)
5828         <update_exec_info>: Declare.
5829         (tui_update_exec_info): Don't declare.
5830         * tui/tui-winsource.c (tui_update_source_window_as_is)
5831         (tui_source_window_base::refresh_all)
5832         (tui_update_all_breakpoint_info): Update.
5833         (tui_source_window_base::update_exec_info): Rename from
5834         tui_update_exec_info.
5835         * tui/tui-stack.c (tui_show_frame_info): Update.
5836
5837 2019-08-13  Tom Tromey  <tom@tromey.com>
5838
5839         * tui/tui-winsource.h (struct tui_source_window_base)
5840         <set_exec_info_content>: Declare.
5841         (tui_set_exec_info_content): Don't declare.
5842         * tui/tui-winsource.c
5843         (tui_source_window_base::set_exec_info_content): Rename from
5844         tui_set_exec_info_content.
5845         (tui_update_exec_info): Update.
5846
5847 2019-08-13  Tom Tromey  <tom@tromey.com>
5848
5849         * tui/tui-winsource.h (struct tui_source_window_base)
5850         <show_source_content>: Declare.
5851         (tui_show_source_content): Don't declare.
5852         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5853         (tui_source_window_base::show_source_content): Rename from
5854         tui_show_source_content.
5855         (tui_source_window_base::refresh_all): Update.
5856         * tui/tui-layout.c (show_source_disasm_command)
5857         (show_source_or_disasm_and_command): Update.
5858
5859 2019-08-13  Tom Tromey  <tom@tromey.com>
5860
5861         * tui/tui-winsource.c (tui_erase_source_content)
5862         (tui_show_source_content, tui_source_window_base::refresh_all):
5863         Update.
5864         * tui/tui-wingeneral.h
5865         (tui_check_and_display_highlight_if_needed): Don't declare.
5866         * tui/tui-wingeneral.c
5867         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5868         check_and_display_highlight_if_needed.
5869         * tui/tui-win.c (tui_rehighlight_all)
5870         (tui_win_info::make_visible_with_new_height): Update.
5871         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5872         (tui_data_window::erase_data_content)
5873         (tui_data_window::display_all_data): Update.
5874         * tui/tui-data.h (struct tui_win_info)
5875         <check_and_display_highlight_if_needed>: Declare.
5876
5877 2019-08-13  Tom Tromey  <tom@tromey.com>
5878
5879         * tui/tui-win.c (tui_resize_all): Call
5880         tui_delete_invisible_windows.
5881         * tui/tui-layout.c (show_layout): Call
5882         tui_delete_invisible_windows.
5883         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5884         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5885
5886 2019-08-13  Tom Tromey  <tom@tromey.com>
5887
5888         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5889         tui_add_win_to_layout.
5890
5891 2019-08-13  Tom Tromey  <tom@tromey.com>
5892
5893         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5894         * tui/tui-layout.c (tui_default_win_height): Now static.
5895
5896 2019-08-13  Tom Tromey  <tom@tromey.com>
5897
5898         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5899         single switch.
5900         (show_source_disasm_command, show_source_or_disasm_and_command):
5901         Don't check current layout.
5902
5903 2019-08-13  Tom Tromey  <tom@tromey.com>
5904
5905         * tui/tui-wingeneral.c (make_all_visible): Remove.
5906         (tui_make_all_invisible): Simplify.
5907         * tui/tui-layout.c (tui_make_all_invisible): Move from
5908         tui-wingeneral.c; simplify.
5909         (show_layout): Hoist call to tui_make_all_invisible.
5910         (show_data): Don't call tui_make_all_invisible.
5911
5912 2019-08-13  Tom Tromey  <tom@tromey.com>
5913
5914         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5915         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5916
5917 2019-08-13  Tom Tromey  <tom@tromey.com>
5918
5919         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5920         tui-data.c.
5921         (show_source_disasm_command, show_data)
5922         (show_source_or_disasm_and_command): Don't use
5923         tui_set_current_layout_to.
5924         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5925         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5926         tui-layout.c.
5927         (tui_set_current_layout_to): Remove.
5928
5929 2019-08-13  Tom Tromey  <tom@tromey.com>
5930
5931         * tui/tui-layout.c (tui_set_layout): Update.
5932         * tui/tui-data.h (struct tui_layout_def): Remove.
5933         (tui_layout_def): Don't declare.
5934         * tui/tui-data.c (layout_def): Remove.
5935         (tui_layout_def): Remove.
5936
5937 2019-08-13  Tom Tromey  <tom@tromey.com>
5938
5939         * tui/tui-winsource.h (struct tui_source_window_base)
5940         <clear_detail>: No longer "override".
5941         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5942         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5943         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5944         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5945         Remove.
5946         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5947
5948 2019-08-13  Tom Tromey  <tromey@adacore.com>
5949
5950         * tracepoint.c: Don't include readline.h or history.h.
5951
5952 2019-08-12  Tom Tromey  <tom@tromey.com>
5953
5954         * configure: Rebuild.
5955         * configure.ac: Check for readline 7.
5956         * NEWS: Mention readline 7 requirement.
5957         * README: Update.
5958
5959 2019-08-12  Tom Tromey  <tom@tromey.com>
5960
5961         * mingw-hdep.c (gdb_select): Remove readline hack.
5962
5963 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5964
5965         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5966         when the function fails.
5967
5968 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
5969
5970         * s390-tdep.c (s390_type_align): New function.
5971         (s390_gdbarch_init): Set it as type_align gdbarch method.
5972
5973 2019-08-09  Tom de Vries  <tdevries@suse.de>
5974
5975         PR gdb/24591
5976         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5977         pc_low with relocation offset.
5978
5979 2019-08-07  Tom Tromey  <tromey@adacore.com>
5980
5981         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5982         (print_frame_args): Update.
5983         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5984         Update.
5985         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5986         * frame.h (struct frame_arg): Add initializers.
5987         <error>: Now a unique_xmalloc_ptr.
5988
5989 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5990
5991         * NEWS: Expand the Pointer Authentication entry.
5992         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5993         (aarch64_frame_unmask_lr): ... to this.
5994         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5995         Call aarch64_frame_unmask_lr.
5996         * frame.c (struct frame_info): Add "masked" variable.
5997         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5998         (fprint_frame): Check for masked pc.
5999         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6000         declarations.
6001         * python/py-framefilter.c (py_print_frame): Check for masked pc.
6002         * stack.c (print_frame): Check for masked pc.
6003
6004 2019-08-06  Tom Tromey  <tom@tromey.com>
6005
6006         * stabsread.c (patch_block_stabs, read_one_struct_field)
6007         (read_enum_type): Use obstack_strndup.
6008         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6009         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6010         * dwarf2read.c (guess_full_die_structure_name)
6011         (anonymous_struct_prefix): Use obstack_strndup.
6012         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6013         * c-exp.y (yylex): Use obstack_strndup.
6014         * ada-exp.y (write_object_renaming, write_ambiguous_var)
6015         (write_var_or_type): Use obstack_strndup.
6016
6017 2019-08-06  Tom Tromey  <tom@tromey.com>
6018
6019         * symfile.c (reread_symbols): Use obstack_strdup.
6020         * stabsread.c (read_type): Use obstack_strdup.
6021         * gdb_obstack.h (obstack_strdup): New overload.
6022         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6023         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6024         (dwarf2_canonicalize_name): Use obstack_strdup.
6025         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6026         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6027         Use obstack_strdup.
6028
6029 2019-08-06  Tom Tromey  <tom@tromey.com>
6030
6031         * gdb_obstack.h (obstack_strdup): Define.
6032         * gdb_obstack.c (obstack_strdup): Don't define.
6033
6034 2019-08-06  Tom Tromey  <tom@tromey.com>
6035
6036         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6037         obstack_strdup.
6038         * typeprint.c (typedef_hash_table::find_global_typedef): Use
6039         obstack_strdup.
6040         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6041         * stabsread.c (common_block_start): Use obstack_strdup.
6042         * objfiles.c (set_objfile_main_name, objfile): Use
6043         obstack_strdup.
6044         * namespace.c (add_using_directive): Use obstack_strdup.
6045         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6046         * jit.c (finalize_symtab): Use obstack_strdup.
6047         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6048         (guess_partial_die_structure_name, partial_die_info::fixup)
6049         (dwarf2_name): Use obstack_strdup.
6050         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6051         obstack_strdup.
6052         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6053         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6054         obstack_strdup.
6055         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6056
6057 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6058
6059         * unittests/help-doc-selftests.c: New file.
6060         * Makefile.in: Add the new file.
6061
6062 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6063
6064         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6065         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
6066         the full first line, except when FOR_VALUE_PREFIX.  In this case,
6067         the trailing '.' is not output, and the first character is uppercased.
6068         (print_help_for_command): Update call to print_doc_line.
6069         (print_doc_of_command): Likewise.
6070         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6071         * cli/cli-option.c (append_indented_doc): Do not append newline.
6072         (build_help_option): Append newline after first appended_indented_doc
6073         only if a second call is done.
6074         (build_help): Append 2 new lines before each option, except the first
6075         one.
6076         * compile/compile.c (_initialize_compile): Add new lines after
6077         %OPTIONS%, when not at the end of the help.
6078         Change help doc or code
6079         producing the help doc to respect the invariants.
6080         * maint-test-options.c (_initialize_maint_test_options): Likewise.
6081         Also removed the new line after 'Options:', as all other commands
6082         do not put an empty line between 'Options:' and the first option.
6083         * printcmd.c (_initialize_printcmd): Likewise.
6084         * stack.c (_initialize_stack): Likewise.
6085         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6086         incorrectly telling COMMAND is optional.
6087         * ada-lang.c (_initialize_ada_language): Change help doc or code
6088         producing the help doc to respect the invariants.
6089         * ada-tasks.c (_initialize_ada_tasks): Likewise.
6090         * breakpoint.c (_initialize_breakpoint): Likewise.
6091         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6092         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6093         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6094         * cli/cli-style.c (cli_style_option::add_setshow_commands,
6095         _initialize_cli_style): Likewise.
6096         * corelow.c (core_target_info): Likewise.
6097         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6098         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6099         * filesystem.c (_initialize_filesystem): Likewise.
6100         * frame.c (_initialize_frame): Likewise.
6101         * gnu-nat.c (add_task_commands): Likewise.
6102         * infcall.c (_initialize_infcall): Likewise.
6103         * infcmd.c (_initialize_infcmd): Likewise.
6104         * interps.c (_initialize_interpreter): Likewise.
6105         * language.c (_initialize_language): Likewise.
6106         * linux-fork.c (_initialize_linux_fork): Likewise.
6107         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6108         * maint.c (_initialize_maint_cmds): Likewise.
6109         * memattr.c (_initialize_mem): Likewise.
6110         * printcmd.c (_initialize_printcmd): Likewise.
6111         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6112         _RegEx): Likewise.
6113         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6114         * record-btrace.c (_initialize_record_btrace): Likewise.
6115         * record-full.c (_initialize_record_full): Likewise.
6116         * record.c (_initialize_record): Likewise.
6117         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6118         * regcache.c (_initialize_regcache): Likewise.
6119         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6120         _initialize_remote): Likewise.
6121         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6122         * serial.c (_initialize_serial): Likewise.
6123         * skip.c (_initialize_step_skip): Likewise.
6124         * source.c (_initialize_source): Likewise.
6125         * stack.c (_initialize_stack): Likewise.
6126         * symfile.c (_initialize_symfile): Likewise.
6127         * symtab.c (_initialize_symtab): Likewise.
6128         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6129         * top.c (init_main): Likewise.
6130         * tracefile-tfile.c (tfile_target_info): Likewise.
6131         * tracepoint.c (_initialize_tracepoint): Likewise.
6132         * tui/tui-win.c (_initialize_tui_win): Likewise.
6133         * utils.c (add_internal_problem_command): Likewise.
6134         * valprint.c (value_print_option_defs): Likewise.
6135
6136 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6137
6138         PR build/24886
6139         * configure.ac: Drop enable-libmcheck support.
6140         * configure, config.in: Rebuild.
6141         * libmcheck.m4: Remove.
6142         * acinclude.m4: Don't include it.
6143         * Makefile.in: Don't distribute it.
6144         * top.c (print_gdb_configuration): Don't mention it.
6145
6146 2019-08-06  Tom Tromey  <tom@tromey.com>
6147
6148         * utils.c (set_output_style): Sometimes pass stream to
6149         emit_style_escape.
6150         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6151         * record-btrace.c (btrace_insn_history): Update.
6152         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6153         method.
6154         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6155         Update initializers.
6156         <m_uiout>: New field.
6157         <m_di>: Move lower.
6158         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6159         Remove "uiout" parameter.
6160         (dump_insns): Update.
6161         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6162         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6163
6164 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6165
6166         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6167         (error_in_psymtab_expansion): Likewise.
6168         (lookup_symbol_via_quick_fns): Likewise.
6169         (basic_lookup_transparent_type_quick): Likewise.
6170         (basic_lookup_transparent_type_1): Likewise.
6171
6172 2019-08-06  Tom Tromey  <tromey@adacore.com>
6173
6174         * source.c (last_source_error): Now bool.
6175         (print_source_lines_base): Make "noprint" bool.  Only open
6176         source file when last_source_visited changes.
6177
6178 2019-08-06  Tom Tromey  <tromey@adacore.com>
6179
6180         * annotate.c (annotate_source_line): Use g_source_cache.
6181         * source-cache.c (source_cache::get_plain_source_lines): Change
6182         parameters.  Populate m_offset_cache.
6183         (source_cache::ensure): New method.
6184         (source_cache::get_line_charpos): New method.
6185         (extract_lines): Move lower.  Change parameters.
6186         (source_cache::get_source_lines): Move lower.
6187         * source-cache.h (class source_cache): Update comment.
6188         <get_line_charpos>: New method.
6189         <get_source_lines>: Update comment.
6190         <clear>: Clear m_offset_cache.
6191         <get_plain_source_lines>: Change parameters.
6192         <ensure>: New method
6193         <m_offset_cache>: New member.
6194         * source.c (forget_cached_source_info_for_objfile): Update.
6195         (info_source_command): Use g_source_cache.
6196         (find_source_lines, open_source_file_with_line_charpos): Remove.
6197         (print_source_lines_base, search_command_helper): Use g_source_cache.
6198         * source.h (open_source_file_with_line_charpos): Don't declare.
6199         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6200         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6201         Use g_source_cache.
6202
6203 2019-08-06  Tom Tromey  <tromey@adacore.com>
6204
6205         * source-cache.c (source_cache::get_plain_source_lines):
6206         Remove "first_line" and "last_line" parameters.
6207         (source_cache::get_source_lines): Cache plain text.
6208         * source-cache.h (class source_cache)
6209         <get_plain_source_lines>: Update.
6210
6211 2019-08-06  Tom Tromey  <tromey@adacore.com>
6212
6213         * source-cache.c (extract_lines): No longer a method.
6214         Changed type of parameter.  Include final newline.
6215         (selftests::extract_lines_test): New function.
6216         (_initialize_source_cache): Likewise.
6217         * source-cache.h (class source_cache)
6218         <extract_lines>: Don't declare.
6219
6220 2019-08-06  Tom Tromey  <tromey@adacore.com>
6221
6222         * breakpoint.c (init_breakpoint_sal): Update.
6223         (breakpoint): Update.
6224         * breakpoint.h (struct breakpoint) <filter>: Now a
6225         unique_xmalloc_ptr.
6226
6227 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6228
6229         * NEWS: Mention dictionary access on blocks.
6230         * python/py-block.c (blpy_getitem): New function.
6231         (block_object_as_mapping): New struct.
6232         (block_object_type): Use new struct for tp_as_mapping field.
6233
6234 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6235
6236         * objfiles.h (objfile): Add a comment describing partial symbols.
6237
6238 2019-08-05  Tom Tromey  <tromey@adacore.com>
6239
6240         * compile/compile.c (_initialize_compile): Use _(), not N_().
6241         * thread.c (_initialize_thread): Use _(), not N_().
6242         * stack.c (_initialize_stack): Use _(), not N_().
6243         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6244
6245 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6246
6247         * dwarf2read.c (struct dw2_symtab_iterator):
6248         <want_specific_block>: Remove.
6249         <block_index>: Change type to gdb::optional.
6250         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6251         change type of BLOCK_INDEX parameter to gdb::optional.
6252         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6253         (dw2_lookup_symbol): Don't pass argument for
6254         WANT_SPECIFIC_BLOCK.
6255         (dw2_expand_symtabs_for_function): Don't pass argument for
6256         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6257         (class dw2_debug_names_iterator)
6258         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6259         parameter, change BLOCK_INDEX type to gdb::optional.
6260         <m_want_specific_block>: Remove.
6261         <m_block_index>: Change type to gdb::optional.
6262         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6263         gdb::optional.  Re-write in function of gdb::optional.
6264         (dw2_debug_names_lookup_symbol): Don't pass argument for
6265         WANT_SPECIFIC_BLOCK.
6266         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6267         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6268         BLOCK_INDEX.
6269
6270 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6271
6272         * NEWS: Mention changes to "info sources" command.
6273
6274 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6275
6276         * symtab.c (filename_partial_match_opts): New struct type.
6277         (struct output_source_filename_data): New members
6278         regexp, c_regexp, partial_match.
6279         (output_source_filename): Use new members to decide to print file.
6280         (info_sources_option_defs): New variable.
6281         (make_info_sources_options_def_group, print_info_sources_header,
6282         info_sources_command_completer):
6283         New functions.
6284         (info_sources_command): Read new optional arguments.
6285         (_initialize_symtab): Update info sources help.
6286
6287 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6288
6289         * ada-lang.c (exception_support_info_v0): Renamed from...
6290         (default_exception_support_info): ... this.  Create new
6291         definition for v1.
6292         (ada_has_this_exception_support): Look up catch_handlers_sym.
6293         (ada_exception_support_info_sniffer): Try v0 after default.
6294
6295 2019-08-01  Tom Tromey  <tromey@adacore.com>
6296
6297         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6298         gdbarch.h.
6299
6300 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6301
6302         * s12z-tdep.c: Fix include path for s12z-opc.h.
6303
6304 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6305
6306         * NEWS: Require GNU make 3.82.
6307
6308 2019-07-16  Tom Tromey  <tom@tromey.com>
6309
6310         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6311         declare.
6312
6313 2019-07-30  Tom Tromey  <tromey@adacore.com>
6314
6315         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6316
6317 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6318
6319         * printcmd.c (print_address_symbolic): Print negative offsets.
6320         (build_address_symbolic): Force signed arithmetic when computing
6321         offset.
6322
6323 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6324
6325         PR/24474: Add a function to lookup static variables.
6326         * NEWS: Mention this new function.
6327         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6328         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6329         * python/python.c (python_GdbMethods): Add new function.
6330
6331 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6332
6333         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6334         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6335         (objfpy_lookup_static_symbol): New function.
6336         (objfile_object_methods): Add new functions.
6337
6338 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6339
6340         * NEWS: Mention 'set|show print frame-info'.  Mention new
6341         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6342         backtrace argument.  Mention that python frame filtering code
6343         is now consistent with what 'backtrace' command prints.
6344
6345 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6346
6347         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6348         comments.
6349         (print_frame_info_auto, print_frame_info_source_line,
6350         print_frame_info_location, print_frame_info_source_and_location,
6351         print_frame_info_location_and_address, print_frame_info_short_location):
6352         New declarations.
6353         (struct frame_print_options): New member print_frame_info.
6354         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6355         * stack.h (get_user_print_what_frame_info): New declaration.
6356         (frame_show_address): New declaration.
6357         * stack.c (print_frame_arguments_choices): New value 'presence'.
6358         (print_frame_info_auto, print_frame_info_source_line,
6359         print_frame_info_location, print_frame_info_source_and_location,
6360         print_frame_info_location_and_address, print_frame_info_short_location,
6361         print_frame_info_choices, print_frame_info_print_what): New definitions.
6362         (print_frame_args): Only print dots for args if print frame-arguments
6363         is 'presence'.
6364         (frame_print_option_defs): New element for "frame-info".
6365         (get_user_print_what_frame_info): New function.
6366         (frame_show_address): Make non static.  Move comment to stack.h.
6367         (print_frame_info_to_print_what): New function.
6368         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6369         to decide what to print.
6370         (backtrace_command_1): Handle the new print_frame_arguments_presence
6371         value.
6372         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6373         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6374         (py_print_frame): In non-mi mode, use LOCATION as default for
6375         print_what, similarly to frame information printed directly by
6376         backtrace command. Handle frame-info user option in non MI mode.
6377
6378 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6379
6380         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6381         Add case for debugging 32-bit target on 64-bit host.  Revise
6382         comment.
6383
6384 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6385
6386         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6387         instead of find_function_entry_range_from_pc.
6388
6389 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6390
6391         * stack.c (find_frame_funname): Remove code which preferred
6392         minsym over symtab sym in "certain pathological cases".
6393
6394         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6395         parameter.  Change type of "do_demangle" to bool.
6396         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6397         Pass suitable "prefer_sym_over_minsym" flag to
6398         build_address_symbolic().  Don't output "+" for negative offsets.
6399         * printcmd.c (print_address_symbolic): Update invocation of
6400         build_address_symbolic to include a "prefer_sym_over_minsym"
6401         flag.
6402         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6403         Restrict cases in which use of minimal symbol is preferred to that
6404         of a found symbol.  Update comments.
6405
6406         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6407         for entry pc when entry pc is out of range for that FDE.
6408
6409 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6410
6411         PR gdb/24839:
6412         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6413         type.
6414
6415 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6416
6417         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6418         this function's Python signature.
6419
6420
6421 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6422
6423         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6424         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6425         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6426         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6427         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6428
6429
6430 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6431
6432         * h8300-tdep.c (h8300_register_name_common): New.
6433         h8300_register_name): Use h8300_register_name_common.
6434         (h8300s_register_name): Likewise.
6435         (h8300sx_register_name): Likewise.
6436         (h8300h_register_nam): New.
6437         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6438
6439
6440 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6441
6442         * arm-tdep.c (arm_skip_cmse_entry): New function.
6443         (arm_is_sgstubs_section): New function.
6444         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6445
6446 2019-07-22  Tom Tromey  <tom@tromey.com>
6447
6448         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6449         Don't self-assign.
6450
6451 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6452
6453         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6454         type_print.
6455
6456 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6457
6458         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6459         so that GDB doesn't match any msymbols when searching in the
6460         TYPES_DOMAIN.
6461         (print_symbol_info): Print using typedef_print or type_print based
6462         on the type of the symbol.  Add updated FIXME comment moved from...
6463         (_initialize_symtab): ... move and update FIXME comment to above.
6464
6465 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6466
6467         * NEWS: Mention adding -q option to "info types".
6468         * symtab.c (struct info_types_options): New struct.
6469         (info_types_options_defs): New variable.
6470         (make_info_types_options_def_group): New function.
6471         (info_types_command): Use gdb::option framework to parse options.
6472         (info_types_command_completer): New function.
6473         (_initialize_symtab): Extend the help text on "info types" and
6474         register command completer.
6475
6476 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6477
6478         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6479         (lookup_symbol_in_objfile): Change int to block_enum and add a
6480         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6481
6482 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6483
6484         * MAINTAINERS (Write After Approval): Add self.
6485
6486 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6487
6488         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6489         instruction to the dummy code region.
6490
6491 2019-07-19  Tom Tromey  <tromey@adacore.com>
6492
6493         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6494         (ARGSUSED, PARAMS, __func__): Remove rules.
6495
6496 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6497
6498         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6499         * features/arm/arm-with-iwmmxt.c: Remove.
6500         * features/arm/arm-with-iwmmxt.xml: Remove.
6501         * features/arm/arm-with-m-fpa-layout.c: Remove.
6502         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6503         * features/arm/arm-with-m-vfp-d16.c: Remove.
6504         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6505         * features/arm/arm-with-m.c: Remove.
6506         * features/arm/arm-with-m.xml: Remove.
6507         * features/arm/arm-with-neon.c: Remove.
6508         * features/arm/arm-with-neon.xml: Remove.
6509         * features/arm/arm-with-vfpv2.c: Remove.
6510         * features/arm/arm-with-vfpv2.xml: Remove.
6511         * features/arm/arm-with-vfpv3.c: Remove.
6512         * features/arm/arm-with-vfpv3.xml: Remove.
6513
6514 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6515
6516         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6517
6518 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6519
6520         * arch/aarch32.c (aarch32_create_target_description): Create
6521         target descriptions using features.
6522         * arch/arm.c (arm_create_target_description)
6523         (arm_create_mprofile_target_description): Likewise.
6524         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6525
6526 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6527
6528         * Makefile.in: Add new files.
6529         * aarch32-tdep.c: New file.
6530         * aarch32-tdep.h: New file.
6531         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6532         Call aarch32_read_description.
6533         * arch/aarch32.c: New file.
6534         * arch/aarch32.h: New file.
6535         * arch/arm.c (arm_create_target_description)
6536         (arm_create_mprofile_target_description): New function.
6537         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6538         (arm_create_target_description)
6539         (arm_create_mprofile_target_description): New declaration.
6540         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6541         read_description functions.
6542         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6543         Likewise.
6544         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6545         * arm-tdep.c (tdesc_arm_list): New variable.
6546         (arm_register_g_packet_guesses): Call create description functions.
6547         (arm_read_description) (arm_read_mprofile_description): New
6548         function.
6549         * arm-tdep.h (arm_read_description)
6550         (arm_read_mprofile_description): Add declaration.
6551         * configure.tgt: Add new files.
6552
6553 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6554
6555         * top.c (new_ui_command): Open specified terminal just once.
6556
6557 2019-07-18  Tom Tromey  <tromey@adacore.com>
6558
6559         * symtab.c (main_name): Constify return type.
6560         * symfile.c (set_initial_language): Update.
6561         * symtab.h (main_name): Constify return type.
6562
6563 2019-07-17  Tom Tromey  <tom@tromey.com>
6564
6565         * tui/tui-winsource.c (tui_update_source_window)
6566         (tui_update_source_window_as_is)
6567         (tui_update_source_windows_with_line): Remove return.
6568         * tui/tui-disasm.c (tui_show_disassem)
6569         (tui_show_disassem_and_update_source): Remove return.
6570         * tui/tui.c (tui_reset): Remove return.
6571         * tui/tui-wingeneral.c
6572         (tui_check_and_display_highlight_if_needed): Remove return.
6573
6574 2019-07-17  Tom Tromey  <tom@tromey.com>
6575
6576         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6577
6578 2019-07-17  Tom Tromey  <tom@tromey.com>
6579
6580         * tui/tui-winsource.h (struct tui_exec_info_window)
6581         (struct tui_source_window_base): Move from tui-data.h.
6582         * tui/tui-winsource.c: Move many method definitions from
6583         elsewhere.  Remove "structuring" comments.
6584         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6585         (tui_source_window_base::refresh_window): Move to
6586         tui-winsource.c.
6587         * tui/tui-win.c (tui_source_window_base::refresh_all)
6588         (tui_source_window_base::update_tab_width)
6589         (tui_source_window_base::set_new_height)
6590         (tui_source_window_base::do_make_visible_with_new_height): Move to
6591         tui-winsource.c.
6592         * tui/tui-source.h: Update.
6593         * tui/tui-source.c (tui_source_window_base::reset): Move to
6594         tui-winsource.c.
6595         * tui/tui-disasm.h: Update.
6596         * tui/tui-data.h (struct tui_exec_info_window): Move to
6597         tui-winsource.h.
6598         (struct tui_source_window_base): Likewise.
6599         * tui/tui-data.c (tui_source_window_base::clear_detail)
6600         (tui_source_window_base, ~tui_source_window_base): Move to
6601         tui-winsource.c.
6602
6603 2019-07-17  Tom Tromey  <tom@tromey.com>
6604
6605         * tui/tui-win.c (tui_resize_all)
6606         (tui_source_window_base::update_tab_width)
6607         (tui_adjust_win_heights): Update.
6608         (tui_win_info::make_invisible_and_set_new_height): Rename from
6609         make_invisible_and_set_new_height.
6610         * tui/tui-data.h (struct tui_win_info)
6611         <make_invisible_and_set_new_height>: New method.
6612
6613 2019-07-17  Tom Tromey  <tom@tromey.com>
6614
6615         * tui/tui.c: Update.
6616         * tui/tui-source.h (struct tui_source_window): Move from
6617         tui-data.h.
6618         * tui/tui-layout.c: Update.
6619         * tui/tui-disasm.c: Update.
6620         * tui/tui-data.h (struct tui_source_window): Move to
6621         tui-source.h.
6622
6623 2019-07-17  Tom Tromey  <tom@tromey.com>
6624
6625         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6626         tui-data.h.
6627         * tui/tui-data.h (struct tui_disasm_window): Move to
6628         tui-disasm.h.
6629
6630 2019-07-17  Tom Tromey  <tom@tromey.com>
6631
6632         * tui/tui-regs.h (struct tui_data_item_window): Move from
6633         tui-data.h.
6634         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6635         * tui/tui-data.h (struct tui_data_item_window): Move to
6636         tui-regs.h.
6637         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6638
6639 2019-07-17  Tom Tromey  <tom@tromey.com>
6640
6641         * tui/tui.c: Update.
6642         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6643         (tui_cmd_window::max_height): Move to tui-command.c.
6644         * tui/tui-layout.c: Update.
6645         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6646         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6647         tui-command.c.
6648         * tui/tui-command.h (struct tui_cmd_window): Move from
6649         tui-data.h.
6650         * tui/tui-command.c: Remove "structuring" comments.
6651         (tui_cmd_window::clear_detail)
6652         (tui_cmd_window::do_make_visible_with_new_height)
6653         (tui_cmd_window::max_height): Move from elsewhere.
6654
6655 2019-07-17  Tom Tromey  <tom@tromey.com>
6656
6657         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6658         Now static.
6659         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6660         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6661
6662 2019-07-17  Tom Tromey  <tom@tromey.com>
6663
6664         * tui/tui.c: Update.
6665         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6666         tui-regs.c.
6667         * tui/tui-windata.h: Remove file.
6668         * tui/tui-windata.c: Remove file.
6669         * tui/tui-win.c (tui_data_window::set_new_height)
6670         (tui_data_window::do_make_visible_with_new_height): Move to
6671         tui-regs.c.
6672         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6673         * tui/tui-regs.c: Remove "structuring" comments.
6674         (tui_data_window::first_data_item_displayed)
6675         (tui_data_window::delete_data_content_windows)
6676         (tui_data_window::erase_data_content)
6677         (tui_data_window::display_all_data)
6678         (tui_data_window::refresh_all)
6679         (tui_data_window::do_scroll_vertical)
6680         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6681         (tui_data_window::do_make_visible_with_new_height)
6682         (tui_data_window::refresh_window): Move from elsewhere.
6683         (_initialize_tui_regs): Move to end of file.
6684         * tui/tui-layout.c: Update.
6685         * tui/tui-hooks.c: Update.
6686         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6687         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6688         tui-regs.c.
6689         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6690
6691 2019-07-17  Tom Tromey  <tom@tromey.com>
6692
6693         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6694         seen.
6695
6696 2019-07-17  Tom Tromey  <tom@tromey.com>
6697
6698         * tui/tui-win.c (tui_source_window_base::set_new_height)
6699         (tui_source_window_base::do_make_visible_with_new_height): Use
6700         m_has_locator field directly.
6701         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6702         method.
6703         (struct tui_source_window_base) <has_locator>: Likewise.
6704
6705 2019-07-17  Tom Tromey  <tom@tromey.com>
6706
6707         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6708         Don't declare.
6709         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6710         Remove.
6711         * tui/tui-win.c (tui_source_window_base::set_new_height)
6712         (tui_source_window_base::set_new_height)
6713         (make_invisible_and_set_new_height)
6714         (tui_source_window_base::do_make_visible_with_new_height)
6715         (tui_source_window_base::do_make_visible_with_new_height):
6716         Update.
6717         * tui/tui-layout.c (show_source_disasm_command, show_data)
6718         (show_source_or_disasm_and_command): Update.
6719         * tui/tui-layout.c (show_layout): Update.
6720
6721 2019-07-17  Tom Tromey  <tom@tromey.com>
6722
6723         * tui/tui-layout.c (make_data_window): Remove.
6724         (show_data): Unify creation and re-initialization cases.
6725
6726 2019-07-17  Tom Tromey  <tom@tromey.com>
6727
6728         * tui/tui-layout.c (make_source_window, make_disasm_window):
6729         Remove.
6730         (show_data): Unify creation and re-initialization cases.
6731
6732 2019-07-17  Tom Tromey  <tom@tromey.com>
6733
6734         * tui/tui-layout.c (make_command_window): Remove.
6735         (show_source_disasm_command, show_source_or_disasm_and_command):
6736         Unify creation and re-initialization cases.
6737
6738 2019-07-17  Tom Tromey  <tom@tromey.com>
6739
6740         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6741         creation and re-initialization cases.
6742
6743 2019-07-17  Tom Tromey  <tom@tromey.com>
6744
6745         * tui/tui-regs.c (tui_get_register): Return void.
6746
6747 2019-07-17  Tom Tromey  <tom@tromey.com>
6748
6749         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6750         Simplify.
6751
6752 2019-07-17  Tom Tromey  <tom@tromey.com>
6753
6754         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6755         resetting.
6756
6757 2019-07-17  Tom Tromey  <tom@tromey.com>
6758
6759         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6760         * tui/tui-regs.c (tui_reg_layout): New function.
6761         (tui_show_registers, tui_reg_command): Use it.
6762         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6763         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6764         parameters.
6765         (tui_layout_command): Remove.
6766
6767 2019-07-17  Tom Tromey  <tom@tromey.com>
6768
6769         * tui/tui-layout.h (tui/tui-layout): Return void.
6770         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6771
6772 2019-07-17  Tom Tromey  <tom@tromey.com>
6773
6774         * tui/tui-layout.c (show_source_disasm_command, show_data):
6775         Update.
6776         (reset_locator): Remove.
6777         (show_source_or_disasm_and_command): Update.
6778
6779 2019-07-17  Tom Tromey  <tom@tromey.com>
6780
6781         * tui/tui-source.c (tui_source_window_base::reset): Remove
6782         win_type parameter.
6783         * tui/tui-layout.c (make_command_window, make_source_window)
6784         (make_disasm_window, make_data_window)
6785         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6786         (reset_locator, show_source_or_disasm_and_command): Update.
6787         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6788         win_type parameter.
6789         (struct tui_source_window_base) <reset>: Likewise.
6790
6791 2019-07-17  Tom Tromey  <tom@tromey.com>
6792
6793         * tui/tui-layout.c (show_source_disasm_command): Use
6794         reset_locator.
6795         (reset_locator): New function.
6796         (init_and_make_win): Remove.
6797         (show_source_or_disasm_and_command): Use reset_locator.
6798
6799 2019-07-17  Tom Tromey  <tom@tromey.com>
6800
6801         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6802         condition.
6803         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6804         Remove condition.
6805         * tui/tui-source.c (tui_source_window_base::reset): New method.
6806         * tui/tui-layout.c (make_command_window): Don't call
6807         init_and_make_win.
6808         (make_source_window, make_disasm_window): Don't call
6809         make_source_or_disasm_window.
6810         (make_data_window): Don't call init_and_make_win.  Change calling
6811         convention.
6812         (show_source_disasm_command, show_data): Simplify.
6813         (make_source_or_disasm_window): Remove.
6814         (show_source_or_disasm_and_command): Simplify.
6815         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6816         (struct tui_source_window_base) <reset>: Likewise.
6817         <execution_info>: Remove initializer.
6818         * tui/tui-data.c (tui_source_window_base): Initialize
6819         execution_info.
6820
6821 2019-07-17  Tom Tromey  <tom@tromey.com>
6822
6823         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6824         variable.
6825
6826 2019-07-17  Tom Tromey  <tom@tromey.com>
6827
6828         * tui/tui.c (tui_rl_other_window): Update.
6829         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6830         superclass method first.  Always iterate over regs_content.
6831         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6832         method.
6833         * tui/tui-win.c (tui_set_focus_command): Update.
6834
6835 2019-07-17  Tom Tromey  <tom@tromey.com>
6836
6837         * tui/tui-win.c (tui_set_focus_command): Rename from
6838         tui_set_focus.  Call tui_enable.
6839         (tui_set_focus_command): Remove.
6840
6841 2019-07-17  Tom Tromey  <tom@tromey.com>
6842
6843         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6844         refresh_window.
6845         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6846         touchwin.
6847         (tui_data_window::refresh_window): Call refresh_window on data
6848         items.  Always call superclass refresh_window.
6849         (tui_win_info::refresh): Remove.
6850         (tui_source_window_base::refresh_window): Update.
6851         (tui_refresh_all): Update.
6852         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6853         refresh_window.
6854         (show_source_or_disasm_and_command): Likewise.
6855         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6856         (struct tui_source_window_base) <refresh>: Likewise.
6857
6858 2019-07-17  Tom Tromey  <tom@tromey.com>
6859
6860         * tui/tui-winsource.c (tui_clear_source_content)
6861         (tui_show_source_content): Update.
6862         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6863         whether content is empty.
6864         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6865         Remove.
6866
6867 2019-07-17  Tom Tromey  <tom@tromey.com>
6868
6869         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6870         window's contents.
6871         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6872         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6873
6874 2019-07-17  Tom Tromey  <tom@tromey.com>
6875
6876         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6877         (struct tui_data_item_window): Update.
6878
6879 2019-07-17  Tom Tromey  <tom@tromey.com>
6880
6881         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6882         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6883         defines.
6884
6885 2019-07-17  Tom Tromey  <tom@tromey.com>
6886
6887         * tui/tui-winsource.h (tui_erase_source_content)
6888         (tui_clear_source_content): Remove "display_prompt" parameter.
6889         * tui/tui-winsource.c (tui_update_source_window_as_is)
6890         (tui_update_source_windows_with_addr): Update.
6891         (tui_clear_source_content): Remove "display_prompt" parameter.
6892         (tui_erase_source_content): Likewise.  Simplify.
6893         (tui_show_source_content): Update.
6894         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6895         * tui/tui-stack.c (tui_show_frame_info): Update.
6896         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6897         Remove defines.
6898
6899 2019-07-17  Tom Tromey  <tom@tromey.com>
6900
6901         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6902         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6903         parameter.
6904         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6905         parameter.
6906
6907 2019-07-17  Tom Tromey  <tom@tromey.com>
6908
6909         * tui/tui-winsource.c (tui_clear_source_content)
6910         (tui_show_source_content, tui_show_exec_info_content)
6911         (tui_clear_exec_info_content): Update.
6912         * tui/tui-stack.c (tui_show_locator_content): Update.
6913         (tui_show_frame_info): Update.
6914         * tui/tui-source.h (tui_source_window): Don't declare.
6915         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6916         from tui_source_is_displayed.
6917         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6918         Remove field.
6919         (struct tui_source_window_base) <content_in_use>: New field.  Now
6920         bool.
6921         (struct tui_source_window) <showing_source_p>: New method.
6922         (TUI_SRC_WIN): Change cast.
6923         * tui/tui-data.c (tui_initialize_static_data): Update.
6924
6925 2019-07-17  Tom Tromey  <tom@tromey.com>
6926
6927         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6928         location_matches_p.
6929         * tui/tui-source.c (tui_source_window::location_matches_p): New
6930         method.
6931         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6932         method.
6933         * tui/tui-data.h (struct tui_source_window_base)
6934         <location_matches_p>: New method.
6935         (struct tui_source_window, struct tui_disasm_window)
6936         <location_matches_p>: Likewise.
6937
6938 2019-07-17  Tom Tromey  <tom@tromey.com>
6939
6940         * tui/tui-win.c (tui_set_win_height_command): Rename from
6941         tui_set_win_height.
6942         (tui_set_win_height_command): Remove.
6943
6944 2019-07-17  Tom Tromey  <tom@tromey.com>
6945
6946         * tui/tui-source.c (tui_source_window): New constructor.  Add
6947         observer.
6948         (~tui_source_window): New destructor.
6949         (tui_source_window::style_changed): New method.
6950         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6951         (tui_attach_detach_observers): Update.
6952         * tui/tui-data.h (struct tui_source_window): Make constructor not
6953         inline.  Add destructor.
6954         (struct tui_source_window) <style_changed>: New method.
6955         <m_observable>: New member.
6956
6957 2019-07-17  Tom Tromey  <tom@tromey.com>
6958
6959         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6960         * tui/tui-win.c (tui_resize_all): Fix typo.
6961
6962 2019-07-17  Tom Tromey  <tom@tromey.com>
6963
6964         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6965         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6966         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6967         * tui/tui-win.c (window_name_completer): Use foreach.
6968         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6969         (update_tab_width): Likewise.
6970         * tui/tui-layout.c (show_layout): Update.
6971         * tui/tui-data.h (class tui_window_iterator): New.
6972         (struct all_tui_windows): New.
6973         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6974
6975 2019-07-17  Tom Tromey  <tom@tromey.com>
6976
6977         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6978         parameter.  Don't reference globals.
6979         (tui_reg_command): Update.
6980
6981 2019-07-17  Tom Tromey  <tom@tromey.com>
6982
6983         * tui/tui-regs.c (tui_show_registers): Simplify.
6984
6985 2019-07-17  Tom Tromey  <tom@tromey.com>
6986
6987         * tui/tui-regs.c (tui_show_registers): Update.
6988         (tui_show_register_group): Add win_info parameter.
6989
6990 2019-07-17  Tom Tromey  <tom@tromey.com>
6991
6992         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6993         Rename from tui_display_reg_element_at_line.
6994         (tui_data_window::display_registers_from_line): Update.
6995         * tui/tui-data.h (struct tui_data_window)
6996         <display_reg_element_at_line>: New method.
6997
6998 2019-07-17  Tom Tromey  <tom@tromey.com>
6999
7000         * tui/tui-regs.h (tui_display_registers_from)
7001         (tui_display_registers_from_line): Don't declare.
7002         * tui/tui-windata.c (tui_data_window::display_all_data)
7003         (tui_data_window::refresh_all)
7004         (tui_data_window::do_scroll_vertical): Update.
7005         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7006         from tui_display_registers_from.
7007         (tui_display_reg_element_at_line): Update.
7008         (tui_data_window::display_registers_from_line): Rename from
7009         tui_display_registers_from_line.
7010         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7011         display_registers_from_line>: New methods.
7012
7013 2019-07-17  Tom Tromey  <tom@tromey.com>
7014
7015         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7016         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7017         from tui_erase_data_content.
7018         (tui_data_window::display_all_data)
7019         (tui_data_window::refresh_all)
7020         (tui_data_window::do_scroll_vertical): Update.
7021         * tui/tui-regs.c (tui_show_registers): Update.
7022         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7023         New method.
7024
7025 2019-07-17  Tom Tromey  <tom@tromey.com>
7026
7027         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7028         declare.
7029         * tui/tui-windata.c
7030         (tui_data_window::delete_data_content_windows): Rename from
7031         tui_delete_data_content_windows.
7032         (tui_data_window::display_all_data)
7033         (tui_data_window::do_scroll_vertical): Update.
7034         * tui/tui-data.h (struct tui_data_window)
7035         <delete_data_content_windows>: New method.
7036
7037 2019-07-17  Tom Tromey  <tom@tromey.com>
7038
7039         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7040         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7041
7042 2019-07-17  Tom Tromey  <tom@tromey.com>
7043
7044         * tui/tui-windata.h (tui_display_all_data): Don't declare.
7045         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7046         from tui_display_all_data.
7047         * tui/tui-win.c
7048         (tui_data_window::do_make_visible_with_new_height): Update.
7049         * tui/tui-regs.c (tui_show_registers): Update.
7050         * tui/tui-layout.c (tui_set_layout): Update.
7051         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7052         method.
7053
7054 2019-07-17  Tom Tromey  <tom@tromey.com>
7055
7056         * tui/tui-windata.h (tui_display_data_from): Don't declare.
7057         * tui/tui-windata.c (tui_display_data_from): Remove.
7058         (tui_data_window::refresh_all): Update.
7059
7060 2019-07-17  Tom Tromey  <tom@tromey.com>
7061
7062         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7063         * tui/tui-windata.c (tui_display_data_from_line): Remove.
7064         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7065         tui_display_registers_from_line.
7066         * tui/tui-regs.h (tui_display_registers_from_line): Update.
7067         * tui/tui-regs.c (tui_display_registers_from_line): Remove
7068         "force_display" parameter.
7069
7070 2019-07-17  Tom Tromey  <tom@tromey.com>
7071
7072         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7073         declare.
7074         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7075         Rename from tui_first_reg_element_no_inline.
7076         (tui_display_reg_element_at_line)
7077         (tui_display_registers_from_line): Update.
7078         * tui/tui-data.h (struct tui_data_window)
7079         <first_reg_element_no_inline>: New method.
7080
7081 2019-07-17  Tom Tromey  <tom@tromey.com>
7082
7083         * tui/tui-windata.c (tui_display_data_from)
7084         (tui_data_window::do_scroll_vertical): Update.
7085         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7086         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7087         Rename from tui_line_from_reg_element_no.
7088         (tui_display_registers_from_line): Update.
7089         * tui/tui-data.h (struct tui_data_window)
7090         <line_from_reg_element_no>: New method.
7091
7092 2019-07-17  Tom Tromey  <tom@tromey.com>
7093
7094         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7095         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7096         tui_last_regs_line_no.
7097         (tui_display_reg_element_at_line)
7098         (tui_display_registers_from_line): Update.
7099         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7100         method.
7101
7102 2019-07-17  Tom Tromey  <tom@tromey.com>
7103
7104         PR tui/24722:
7105         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7106         (tui_update_breakpoint_info): Add "being_deleted" parameter.
7107         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7108         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7109         (tui_update_breakpoint_info): Likewise.
7110         * tui/tui-hooks.c (tui_event_create_breakpoint)
7111         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7112         Update.
7113
7114 2019-07-17  Tom Tromey  <tom@tromey.com>
7115
7116         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7117
7118 2019-07-17  Tom Tromey  <tom@tromey.com>
7119
7120         * tui/tui-winsource.c (tui_update_source_window_as_is)
7121         (tui_update_source_windows_with_addr): Update.
7122         * tui/tui-source.h (tui_set_source_content)
7123         (tui_show_symtab_source): Add "win_info" parameter.
7124         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7125         parameter.
7126         (tui_show_symtab_source): Likewise.
7127
7128 2019-07-17  Tom Tromey  <tom@tromey.com>
7129
7130         * tui/tui-wingeneral.c
7131         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7132
7133 2019-07-17  Tom Tromey  <tom@tromey.com>
7134
7135         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7136         (struct tui_cmd_window) <can_scroll>: New method.
7137         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7138         method.
7139
7140 2019-07-17  Tom Tromey  <tromey@adacore.com>
7141
7142         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7143         do_field_signed>: Rename.  Change type of "value".
7144         * ui-out.c (ui_out::field_signed): Rename from field_int.
7145         Change type of "value".
7146         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7147         type of "value".
7148         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7149         do_field_int.  Change type of "value".
7150         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7151         do_field_int.  Change type of "value".
7152         * tracepoint.c (trace_status_mi, tfind_1)
7153         (print_one_static_tracepoint_marker): Update.
7154         * thread.c (print_thread_info_1, print_selected_thread_frame):
7155         Update.
7156         * stack.c (print_frame, print_frame_info): Update.
7157         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7158         Update.
7159         * source.c (print_source_lines_base): Update.
7160         * skip.c (info_skip_command): Update.
7161         * record-btrace.c (btrace_ui_out_decode_error)
7162         (btrace_call_history_src_line): Update.
7163         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7164         Update.
7165         * progspace.c (print_program_space): Update.
7166         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7167         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7168         do_field_int.  Change type of "value".
7169         * mi/mi-out.c (mi_ui_out::do_table_begin)
7170         (mi_ui_out::do_table_header): Update.
7171         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7172         type of "value".
7173         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7174         (mi_cmd_data_list_changed_registers, output_register)
7175         (mi_cmd_data_read_memory, mi_load_progress)
7176         (mi_cmd_trace_frame_collected): Update.
7177         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7178         Update.
7179         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7180         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7181         (mi_cmd_var_list_children, varobj_update_one): Update.
7182         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7183         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7184         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7185         * inferior.c (print_inferior): Update.
7186         * gdb_bfd.c (print_one_bfd): Update.
7187         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7188         Update.
7189         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7190         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7191         do_field_int.  Change type of "value".
7192         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7193         do_field_int.  Change type of "value".
7194         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7195         (print_one_breakpoint_location, print_it_catch_fork)
7196         (print_one_catch_fork, print_it_catch_vfork)
7197         (print_one_catch_vfork, print_it_catch_solib)
7198         (print_it_catch_exec, print_it_ranged_breakpoint)
7199         (print_mention_watchpoint, print_mention_masked_watchpoint)
7200         (bkpt_print_it, update_static_tracepoint): Update.
7201         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7202         * break-catch-syscall.c (print_it_catch_syscall): Update.
7203         * ada-tasks.c (print_ada_task_info): Update.
7204         * ada-lang.c (print_it_exception, print_mention_exception):
7205         Update.
7206
7207 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7208
7209         PR breakpoints/24541
7210         * gdbarch.c: Regenerate.
7211         * gdbarch.h: Regenerate.
7212         * gdbarch.sh: Adjust return type and parameter types for
7213         'stap_adjust_register'.
7214         (i386_stap_adjust_register): Adjust signature and return new
7215         register name.
7216         * stap-probe.c (stap_parse_register_operand): Adjust use of
7217         'gdbarch_stap_adjust_register'.
7218
7219 2019-07-17  Tom Tromey  <tromey@adacore.com>
7220
7221         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7222         declare VEC.
7223         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7224         std::vector.
7225         (struct s390_process_info): Add initializers.
7226         (s390_add_process): Use new.
7227         (s390_linux_nat_target::low_forget_process): Use delete.
7228         (s390_linux_nat_target::low_new_fork)
7229         (s390_linux_nat_target::stopped_by_watchpoint)
7230         (s390_linux_nat_target::low_prepare_to_resume)
7231         (s390_linux_nat_target::insert_watchpoint)
7232         (s390_linux_nat_target::insert_hw_breakpoint)
7233         (s390_linux_nat_target::remove_watchpoint)
7234         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7235
7236 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7237
7238         * aarch64-fbsd-nat.c: Include regcache.h.
7239         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7240         argument.
7241         (aarch64_fbsd_nat_target::fetch_registers)
7242         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7243         variable.
7244         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7245
7246 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7247
7248         * fbsd-nat.c: Include gdbarch.h.
7249
7250 2019-07-15  Tom Tromey  <tromey@adacore.com>
7251
7252         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7253
7254 2019-07-15  Tom Tromey  <tromey@adacore.com>
7255
7256         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7257         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7258         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7259         * cli-out.c (cli_ui_out::do_field_int): New method.
7260         * ui-out.c (ui_out::field_unsigned): New method.
7261         * symfile.c (generic_load): Use field_unsigned.
7262         (print_transfer_performance): Likewise.
7263         * record-btrace.c (ui_out_field_uint): Remove.
7264         (btrace_call_history_insn_range, btrace_call_history): Use
7265         field_unsigned.
7266         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7267         field_unsigned.
7268         * ui-out.h (class ui_out) <field_unsigned>: New method.
7269         <do_field_unsigned>: Likewise.
7270
7271 2019-07-15  Tom Tromey  <tromey@adacore.com>
7272
7273         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7274         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7275         * target.c (flash_erase_command): Use field_string.
7276         * infrun.c (print_signal_received_reason): Use field_string.
7277         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7278         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7279         field_string.
7280         * ada-tasks.c (print_ada_task_info): Use field_string.
7281
7282 2019-07-15  Tom Tromey  <tromey@adacore.com>
7283
7284         * target.c (flash_erase_command): Use field_core_addr.
7285         * symfile.c (generic_load): Use field_core_addr.
7286         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7287         Use field_core_addr.
7288         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7289         field_core_addr.
7290
7291 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7292
7293         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7294         value if its desired type is smaller than a CORE_ADDR and signed.
7295
7296 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7297
7298         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7299         of changes to field names, and use new is_reference field to
7300         decide if a property is a reference or not.
7301         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7302         field.
7303         (struct dwarf2_property_baton): Update header comment, rename
7304         'referenced_type' to 'property_type' and update comments.
7305         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7306         default property type, store in property baton, update to take
7307         accound of renamed field.
7308         (read_func_scope): Update call to attr_to_dynamic_prop.
7309         (read_array_type): Likewise.
7310         (dwarf2_per_cu_addr_sized_int_type): New function.
7311         (read_subrange_index_type): Move type finding code to
7312         dwarf2_per_cu_addr_sized_int_type.
7313         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7314         (dwarf2_per_cu_addr_type): New function.
7315         (set_die_type): Update calls to attr_to_dynamic_prop.
7316
7317 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7318
7319         * dwarf2read.c (read_subrange_index_type): New function.
7320         (read_subrange_type): Move code into new function and call it.
7321         * gdbtypes.c (create_range_type): Add some asserts.
7322
7323 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7324
7325         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7326         update return statements.
7327         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7328         declaration, and update comment to match.
7329         * gdbtypes.c (resolve_dynamic_array): Update call to
7330         dwarf2_evaluate_property to match new return type.
7331
7332 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7333
7334         * valarith.c (value_subscripted_rvalue): Change lowerbound
7335         parameter type from int to LONGEST.
7336         * value.h (value_subscripted_rvalue): Likewise in declaration.
7337
7338 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7339
7340         * cli/cli-utils.c (info_print_command_completer): New function.
7341         * cli/cli-utils.h: Add 'completer.h' include, and forward
7342         declaration for 'struct cmd_list_element'.
7343         (info_print_command_completer): Declare.
7344         * stack.c (_initialize_stack): Add completer for 'info locals' and
7345         'info args'.
7346         * symtab.c (_initialize_symtab): Add completer for 'info
7347         variables' and 'info functions'.
7348         * NEWS: Mention completion for additional info commands.
7349
7350 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7351
7352         * cli/cli-utils.c (extract_info_print_args): Delete.
7353         (extract_arg_maybe_quoted): Delete.
7354         (info_print_options_defs): New variable.
7355         (make_info_print_options_def_group): New function.
7356         (extract_info_print_options): Define new function.
7357         * cli/cli-utils.h (extract_info_print_args): Delete.
7358         (struct info_print_options): New structure.
7359         (extract_info_print_options): Declare new function.
7360         * stack.c (info_locals_command): Update to use new
7361         extract_info_print_options, also add a header comment.
7362         (info_args_command): Likewise.
7363         * symtab.c (info_variables_command): Likewise.
7364         (info_functions_command): Likewise.
7365
7366 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7367
7368         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7369         to extract string arguments.
7370         * common/common-utils.c (extract_string_maybe_quoted): New function.
7371         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7372
7373 2019-07-11  Tom Tromey  <tromey@adacore.com>
7374
7375         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7376         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7377         * top.h (gdbinit): Don't declare.
7378         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7379         into...
7380         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7381         * top.c (gdb_init): Don't call init_cli_cmds.
7382         (gdbinit): Remove.
7383         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7384
7385 2019-07-11  Tom Tromey  <tromey@adacore.com>
7386
7387         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7388         after it has been moved.
7389
7390 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7391
7392         * valops.c (value_must_coerce_to_target): Change return type to
7393         bool.
7394         * value.h (value_must_coerce_to_target): Likewise.
7395
7396 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7397
7398         * breakpoint.c (is_hardware_watchpoint): Remove
7399         forward-declaration.
7400         (is_masked_watchpoint): Change return type to bool.
7401         (is_tracepoint): Likewise.
7402         (is_breakpoint): Likewise.
7403         (is_hardware_watchpoint): Likewise.
7404         (is_watchpoint): Likewise.
7405         (is_no_memory_software_watchpoint): Likewise.
7406         (is_catchpoint): Likewise.
7407         (breakpoint_1): Make FILTER parameter's return type bool.
7408         is_masked_watchpoint): Change return type to bool.
7409         (save_breakpoints): Make FILTER parameter's return type bool.
7410         * breakpoint.h (is_breakpoint): Change return type to bool.
7411         (is_watchpoint): Likewise.
7412         (is_catchpoint): Likewise.
7413         (is_tracepoint): Likewise.
7414
7415 2019-07-10  Tom Tromey  <tom@tromey.com>
7416
7417         * defs.h: Don't include gdbarch.h.
7418         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7419         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7420         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7421         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7422         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7423         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7424         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7425         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7426         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7427         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7428         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7429         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7430         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7431         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7432         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7433         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7434         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7435         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7436         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7437         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7438         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7439         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7440         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7441         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7442         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7443         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7444         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7445
7446 2019-07-10  Tom Tromey  <tromey@adacore.com>
7447
7448         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7449         * breakpoint.c (init_ada_exception_breakpoint): Register as
7450         bp_catchpoint.
7451         (print_one_breakpoint_location, print_one_breakpoint): Use
7452         is_ada_exception_catchpoint.
7453         * ada-lang.c (class ada_catchpoint_location): Pass
7454         bp_loc_software_breakpoint to bp_location constructor.
7455         (is_ada_exception_catchpoint): New function.
7456
7457 2019-07-10  Tom Tromey  <tromey@adacore.com>
7458
7459         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7460         VEC.
7461         (struct arm_exidx_entry): New method operator<.
7462         (struct arm_exidx_data) <section_maps>: Change type.
7463         (arm_exidx_data_free): Remove.
7464         (arm_exidx_data_key): Change type.  Move lower.
7465         (arm_exidx_new_objfile): Update.
7466         (arm_compare_exidx_entries): Remove.
7467         (arm_find_exidx_entry, _initialize_arm_tdep)
7468
7469 2019-07-10  Tom Tromey  <tromey@adacore.com>
7470
7471         * solib-spu.c (ocl_program_data_key): Change type.
7472         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7473         Update.
7474
7475 2019-07-10  Tom Tromey  <tromey@adacore.com>
7476
7477         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7478         (struct solib_aix_inferior_data) <library_list>: Change type.
7479         (solib_aix_inferior_data_handle): Change type.
7480         (get_solib_aix_inferior_data): Update.
7481         (solib_aix_free_library_list): Remove.
7482         (library_list_start_library): Update.
7483         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7484         return type.
7485         (solib_aix_get_library_list)
7486         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7487         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7488
7489 2019-07-10  Tom Tromey  <tromey@adacore.com>
7490
7491         * solib-dsbt.c (struct dsbt_info): Add initializers.
7492         (solib_dsbt_pspace_data): Change type.
7493         (dsbt_pspace_data_cleanup): Remove.
7494         (get_dsbt_info, _initialize_dsbt_solib): Update.
7495
7496 2019-07-10  Tom Tromey  <tromey@adacore.com>
7497
7498         * spu-tdep.c (spu_overlay_data): Change type.
7499         (spu_get_overlay_table, spu_overlay_new_objfile)
7500         (_initialize_spu_tdep): Update.
7501
7502 2019-07-10  Tom Tromey  <tromey@adacore.com>
7503
7504         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7505         destructor.
7506         (dbx_objfile_data_key): Change type and declare later.
7507         (DBX_SYMFILE_INFO): Rewrite.
7508         * dbxread.c (dbx_objfile_data_key): Change type.
7509         (dbx_symfile_init): Update.
7510         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7511         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7512         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7513
7514 2019-07-10  Tom Tromey  <tromey@adacore.com>
7515
7516         * jit.c (jit_program_space_key): Change type.  Move lower.
7517         (get_jit_program_space_data): Update.
7518         (jit_program_space_data_cleanup): Remove.
7519         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7520         Update.
7521         (struct jit_program_space_data): Add initializers.
7522
7523 2019-07-10  Tom Tromey  <tromey@adacore.com>
7524
7525         * solib-darwin.c (struct darwin_info): Add initializers.
7526         (solib_darwin_pspace_data): Change type.
7527         (darwin_pspace_data_cleanup): Remove.
7528         (get_darwin_info, _initialize_darwin_solib): Update.
7529
7530 2019-07-10  Tom Tromey  <tromey@adacore.com>
7531
7532         * remote-sim.c (struct sim_inferior_data): Add initializers,
7533         constructor, and destructor.
7534         (sim_inferior_data_key): Change type.  Move lower.
7535         (check_for_duplicate_sim_descriptor): Update.
7536         (get_sim_inferior_data): Use new.  Update.
7537         (~sim_inferior_data_cleanup): Rename from
7538         sim_inferior_data_cleanup.  Simplify.
7539         (gdbsim_close_inferior, simulator_command)
7540         (sim_command_completer, _initialize_remote_sim): Update.
7541         (next_pid, INITIAL_PID): Move earlier.
7542
7543 2019-07-10  Tom Tromey  <tromey@adacore.com>
7544
7545         * python/python-internal.h (create_thread_object): Return
7546         gdbpy_ref.
7547         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7548         * python/py-inferior.c (struct threadlist_entry): Add
7549         constructor.
7550         <thread_obj>: Now a gdbpy_ref.
7551         (thread_to_thread_object): Update.
7552         (add_thread_object): Use new.
7553         (delete_thread_object): Use delete.
7554         (infpy_threads): Update.
7555         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7556         GIL.
7557
7558 2019-07-10  Tom Tromey  <tromey@adacore.com>
7559
7560         * valops.c (value_cast): Specialize error message for Ada.
7561
7562 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7563
7564         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7565
7566 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7567
7568         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7569         bpstat_should_step): Return bool, adjust comments.
7570         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7571         bpstat_should_step): Likewise.
7572
7573 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7574
7575         * features/Makefile: Use feature target descriptions for Arm.
7576         * features/arm/arm-core.c: Generate new file.
7577         * features/arm/arm-fpa.c: Likewise.
7578         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7579         * features/arm/arm-m-profile.c: Likewise.
7580         * features/arm/arm-vfpv2.c: Likewise.
7581         * features/arm/arm-vfpv3.c: Likewise.
7582         * features/arm/xscale-iwmmxt.c: Likewise.
7583         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7584
7585 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7586
7587         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7588         ptrace earlier.
7589
7590 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7591
7592         * features/aarch64-pauth.c: Regenerate.
7593
7594 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7595
7596         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7597         bool.
7598         (bpstat_what): Use false instead of 0.
7599
7600 2019-07-09  Pedro Alves  <palves@redhat.com>
7601
7602         * break-catch-throw.c (is_exception_catchpoint): New.
7603         * breakpoint.c (print_one_breakpoint_location): New parameter
7604         'raw_loc'.  Handle it.  Use
7605         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7606         looking at the breakpoint's type.
7607         (print_one_breakpoint): If handling "maint info breakpoints", also
7608         print locations of exception catchpoints.
7609         * breakpoint.h (is_exception_catchpoint): Declare.
7610
7611 2019-07-09  Pedro Alves  <palves@redhat.com>
7612
7613         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7614         "addr" field.
7615         (allocate_location_exception_catchpoint): New.
7616         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7617         (initialize_throw_catchpoint_ops): Install
7618         allocate_location_exception_catchpoint as allocate_location
7619         method.
7620         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7621         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7622         bp_loc_other.
7623         (breakpoint_address_is_meaningful): Delete.
7624         (bl_address_is_meaningful): New.
7625         (breakpoint_locations_match): Adjust comment.
7626         (bp_location_from_bp_type): New, factored out of...
7627         (bp_location::bp_location(breakpoint *)): ... this.
7628         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7629         factored out of...
7630         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7631         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7632         breakpoint_address_is_meaningful.
7633         (bp_locations_compare): Adjust comment.
7634         (update_global_location_list): Use bl_address_is_meaningful
7635         instead of breakpoint_address_is_meaningful.
7636         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7637         explicit.
7638         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7639         * python/py-breakpoint.c (bppy_get_location): No longer check
7640         whether location is null.
7641
7642 2019-07-09  Pedro Alves  <palves@redhat.com>
7643
7644         PR c++/15468
7645         * breakpoint.c (print_one_breakpoint_location): Remove
7646         single-location assert.
7647
7648 2019-07-09  Tom Tromey  <tom@tromey.com>
7649
7650         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7651         * configure: Rebuild.
7652         * configure.ac: Change common to gdbsupport.
7653         * gdbsupport: Rename from common.
7654         * acinclude.m4: Change common to gdbsupport.
7655         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7656         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7657         gdbsupport.
7658         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7659         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7660         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7661         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7662         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7663         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7664         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7665         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7666         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7667         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7668         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7669         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7670         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7671         coff-pe-read.c, command.h, compile/compile-c-support.c,
7672         compile/compile-c.h, compile/compile-cplus-symbols.c,
7673         compile/compile-cplus-types.c, compile/compile-cplus.h,
7674         compile/compile-loc2c.c, compile/compile.c, completer.c,
7675         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7676         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7677         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7678         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7679         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7680         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7681         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7682         features/aarch64-core.c, features/aarch64-fpu.c,
7683         features/aarch64-pauth.c, features/aarch64-sve.c,
7684         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7685         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7686         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7687         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7688         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7689         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7690         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7691         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7692         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7693         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7694         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7695         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7696         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7697         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7698         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7699         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7700         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7701         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7702         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7703         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7704         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7705         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7706         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7707         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7708         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7709         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7710         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7711         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7712         minsyms.c, mips-linux-tdep.c, namespace.h,
7713         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7714         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7715         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7716         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7717         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7718         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7719         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7720         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7721         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7722         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7723         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7724         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7725         procfs.c, producer.c, progspace.h, psymtab.h,
7726         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7727         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7728         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7729         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7730         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7731         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7732         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7733         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7734         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7735         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7736         target-memory.c, target.c, target.h, target/waitstatus.c,
7737         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7738         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7739         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7740         unittests/array-view-selftests.c,
7741         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7742         unittests/common-utils-selftests.c,
7743         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7744         unittests/format_pieces-selftests.c,
7745         unittests/function-view-selftests.c,
7746         unittests/lookup_name_info-selftests.c,
7747         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7748         unittests/mkdir-recursive-selftests.c,
7749         unittests/observable-selftests.c,
7750         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7751         unittests/parse-connection-spec-selftests.c,
7752         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7753         unittests/scoped_fd-selftests.c,
7754         unittests/scoped_mmap-selftests.c,
7755         unittests/scoped_restore-selftests.c,
7756         unittests/string_view-selftests.c, unittests/style-selftests.c,
7757         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7758         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7759         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7760         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7761         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7762         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7763
7764 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7765
7766         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7767         bool value.
7768         (decode_digits_ordinary): Set explicit_line field in sal.
7769         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7770         symtab_and_line that was set on an explicit line number in
7771         assembler code.  Do always update the recorded symtab and line if
7772         we do skip the prologue.
7773
7774 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7775
7776         * breakpoint.c (set_breakpoint_location_function): Remove
7777         explicit_loc parameter.
7778         (momentary_breakpoint_from_master): Update call to
7779         set_breakpoint_location_function.
7780         (add_location_to_breakpoint): Likewise.
7781
7782 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7783
7784         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7785         required features based on default bfd type when no specific bfd
7786         is present.
7787
7788 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7789
7790         * NEWS: Mention that GDB printf and eval commands can now print
7791         C-style and Ada-style convenience var strings without
7792         calling the inferior.
7793         * printcmd.c (printf_c_string): Locally print GDB internal var
7794         instead of transiting via the inferior.
7795         (printf_wide_c_string): Likewise.
7796
7797 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7798
7799         PR breakpoints/25011
7800         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7801
7802 2019-07-04  Tom Tromey  <tom@tromey.com>
7803
7804         PR tui/24724:
7805         * tui/tui-winsource.c (tui_clear_source_content): Update.
7806         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7807         (tui_update_breakpoint_info): Update.
7808         (tui_set_exec_info_content): Update.
7809         * tui/tui-source.c (tui_set_source_content_nil): Update.
7810         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7811         has_break.
7812         * tui/tui-data.h (enum tui_bp_flag): New.
7813         (tui_bp_flags): New enum flags type.
7814         (struct tui_source_element) <break_mode>: Change type.  Rename
7815         from has_break.
7816         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7817         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7818         constants.
7819         * tui/tui-winsource.h: Fix comment.
7820
7821 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7822
7823         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7824         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7825         (store_fpregs_to_thread)
7826         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7827         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7828         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7829         (IWMMXT_REGS_SIZE): Add define.
7830         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7831         (fetch_vfp_regs, store_vfp_regs)
7832         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7833         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7834
7835 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7836
7837         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7838         defines.
7839         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7840         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7841         (ARM_INT_REGISTER_SIZE): ...to this.
7842         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7843         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7844         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7845         (arm_linux_collect_gregset, supply_nwfpe_register)
7846         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7847         defines.
7848         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7849         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7850         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7851         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7852         (arm_return_in_memory, arm_store_return_value)
7853         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7854         (arm_record_ld_st_multiple): Likewise.
7855         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7856         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7857
7858 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7859
7860         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7861         AARCH64_DISPLACED_MODIFIED_INSNS.
7862         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7863         (aarch64_displaced_step_copy_insn): Likewise.
7864         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7865         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7866         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7867         ARM_DISPLACED_MODIFIED_INSNS.
7868         * arm-tdep.c (arm_gdbarch_init): Likewise.
7869         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7870         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7871         (struct arm_displaced_step_closure): Use
7872         ARM_DISPLACED_MODIFIED_INSNS.
7873
7874 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7875
7876         * features/Makefile: Remove unused xml files.
7877         * features/aarch64.xml: Remove.
7878         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7879         * features/i386/amd64-avx-avx512.xml: Remove.
7880         * features/i386/amd64-avx-linux.xml: Remove.
7881         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7882         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7883         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7884         * features/i386/amd64-avx-mpx.xml: Remove.
7885         * features/i386/amd64-avx.xml: Remove.
7886         * features/i386/amd64-linux.xml: Remove.
7887         * features/i386/amd64-mpx-linux.xml: Remove.
7888         * features/i386/amd64-mpx.xml: Remove.
7889         * features/i386/amd64.xml: Remove.
7890         * features/i386/i386-avx-avx512-linux.xml: Remove.
7891         * features/i386/i386-avx-avx512.xml: Remove.
7892         * features/i386/i386-avx-linux.xml: Remove.
7893         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7894         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7895         * features/i386/i386-avx-mpx-linux.xml: Remove.
7896         * features/i386/i386-avx-mpx.xml: Remove.
7897         * features/i386/i386-avx.xml: Remove.
7898         * features/i386/i386-linux.xml: Remove.
7899         * features/i386/i386-mmx-linux.xml: Remove.
7900         * features/i386/i386-mmx.xml: Remove.
7901         * features/i386/i386-mpx-linux.xml: Remove.
7902         * features/i386/i386-mpx.xml: Remove.
7903         * features/i386/i386.xml: Remove.
7904         * features/i386/x32-avx-avx512-linux.xml: Remove.
7905         * features/i386/x32-avx-linux.xml: Remove.
7906         * features/i386/x32-linux.xml: Remove.
7907
7908 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7909
7910         * regformats/aarch64.dat: Remove.
7911         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7912         * regformats/i386/amd64-avx-linux.dat: Remove.
7913         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7914         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7915         * regformats/i386/amd64-linux.dat: Remove.
7916         * regformats/i386/amd64-mpx-linux.dat: Remove.
7917         * regformats/i386/amd64.dat: Remove.
7918         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7919         * regformats/i386/i386-avx-linux.dat: Remove.
7920         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7921         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7922         * regformats/i386/i386-linux.dat: Remove.
7923         * regformats/i386/i386-mmx-linux.dat: Remove.
7924         * regformats/i386/i386-mpx-linux.dat: Remove.
7925         * regformats/i386/i386.dat: Remove.
7926         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7927         * regformats/i386/x32-avx-linux.dat: Remove.
7928         * regformats/i386/x32-linux.dat: Remove.
7929
7930 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7931
7932         * aarch64-tdep.c: Remove xml self tests.
7933         * amd64-linux-tdep.c: Likewise.
7934         * amd64-tdep.c: Likewise.
7935         * i386-linux-tdep.c: Likewise.
7936         * i386-tdep.c: Likewise.
7937
7938 2019-07-03  Pedro Alves  <palves@redhat.com>
7939
7940         PR cli/24732
7941         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7942         (pipe_cmd_option_defs): New.
7943         (make_pipe_cmd_options_def_group): New.
7944         (pipe_command): Use gdb::option::process_options.
7945         (pipe_command_completer): New function.
7946         (_initialize_cli_cmds): Install completer for "pipe" command.
7947
7948 2019-07-03  Pedro Alves  <palves@redhat.com>
7949
7950         * cli/cli-option.c (union option_value) <string>: New field.
7951         (struct option_def_and_value): Add ctor, move ctor, dtor and
7952         use DISABLE_COPY_AND_ASSIGN.
7953         (option_def_and_value::clear_value): New.
7954         (parse_option, save_option_value_in_ctx, get_val_type_str)
7955         (add_setshow_cmds_for_options): Handle var_string.
7956         * cli-option.h (union option_def::var_address) <string>: New
7957         field.
7958         (struct string_option_def): New.
7959         * maint-test-options.c (struct test_options_opts): Add default
7960         ctor and use DISABLE_COPY_AND_ASSIGN.
7961         <string_opt>: New field.
7962         (test_options_opts::~test_options_opts): New.
7963         (test_options_opts::dump): Also dump "-string".
7964         (test_options_option_defs): Install "string.
7965
7966 2019-07-03  Pedro Alves  <palves@redhat.com>
7967
7968         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7969         option_value with a null enumeration.
7970         (complete_options): Save the option values in the context.
7971         (save_option_value_in_ctx): New, factored out from ...
7972         (process_options): ... here.
7973         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7974         of the function.
7975         * maint-test-options.c (test_options_opts::dump): New, factored
7976         out from ...
7977         (maintenance_test_options_command_mode): ... here.
7978         (maintenance_test_options_command_completion_result): Delete.
7979         (maintenance_test_options_command_completion_text): Update
7980         comment.
7981         (maintenance_show_test_options_completion_result): Change
7982         prototype.  Just print
7983         maintenance_test_options_command_completion_text.
7984         (save_completion_result): New.
7985         (maintenance_test_options_completer_mode): Pass options context to
7986         complete_options, and then save a dump.
7987         (_initialize_maint_test_options): Use add_cmd to install "maint
7988         show test-options-completion-result".
7989
7990 2019-07-03  Pedro Alves  <palves@redhat.com>
7991
7992         * NEWS (New commands): Mention "with" and "maint with".
7993         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7994         (with_command, with_command_completer): New.
7995         (pipe_command): Adjust to new repeat_previous
7996         interface.
7997         (_initialize_cli_cmds): Install the "with" command and its "w"
7998         alias.
7999         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8000         declarations.
8001         * cli/cli-setshow.c (parse_cli_var_uinteger)
8002         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8003         argument strings for all var_types.
8004         (get_setshow_command_value_string): New, factored out from ...
8005         (do_show_command): ... this.
8006         * cli/cli-setshow.h: Include <string>.
8007         (get_setshow_command_value_string): Declare.
8008         * command.h (repeat_previous): Now returns const char *.  Adjust
8009         comment.
8010         * maint.c: Include "cli/cli-cmds.h".
8011         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8012         (_initialize_maint_cmds): Register the "maintenance with" command.
8013         * top.c (repeat_previous): Move bits from pipe_command here:
8014         Return the saved command line, if any; error out if there's no
8015         command to relaunch.
8016
8017 2019-07-03  Pedro Alves  <palves@redhat.com>
8018
8019         * NEWS (New commands): Mention "maint set/show test-settings"
8020         instead of "maint test-settings".
8021         * maint-test-settings.c (maintenance_test_settings_list): Delete.
8022         (maintenance_test_settings_set_list): Rename to ...
8023         (maintenance_set_test_settings_list): ... this.
8024         (maintenance_test_settings_show_list): Rename to  ...
8025         (maintenance_show_test_settings_list): ... this.
8026         (maintenance_test_settings_cmd): Delete.
8027         (maintenance_test_settings_set_cmd): ...
8028         (maintenance_set_test_settings_cmd): ... this.
8029         (maintenance_test_settings_show_cmd): ...
8030         (maintenance_show_test_settings_cmd): ... this.
8031         (maintenance_test_settings_show_value_cmd):
8032         (maintenance_show_test_settings_value_cmd): ... this.
8033         (_initialize_maint_test_settings): No longer install the "maint
8034         test-settings" prefix command.  Rename "maint test-settings set"
8035         to "maint set test-settings", and "maint test-settings show" to
8036         "maint show test-settings".  Adjust all subcommands.
8037
8038 2019-07-03  Pedro Alves  <palves@redhat.com>
8039
8040         * maint-test-settings.c: Fix file's intro comment.  Replace all
8041         references to "test-options" with references to "test-settings",
8042         in comments.
8043
8044 2019-07-03  Pedro Alves  <palves@redhat.com>
8045
8046         * maint-test-settings.c (maintenance_test_settings_xxx)
8047         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8048         New.
8049         (maintenance_test_settings_enums): Use them.
8050         (maintenance_test_settings_enum): Default to
8051         maintenance_test_settings_xxx.
8052         (_initialize_maint_test_settings): Initialize
8053         MAINTENANCE_TEST_SETTINGS_FILENAME.
8054
8055 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8056
8057         * breakpoint.h (remove_breakpoints_inf): Change return type to
8058         void, move function documentation here.
8059         * breakpoint.c (remove_breakpoints_inf): Change return type to
8060         void, move function documentation to header.
8061
8062 2019-07-02  Pedro Alves  <palves@redhat.com>
8063
8064         * NEWS (Completion improvements): Mention "info threads".
8065         * thread.c (struct info_threads_opts, info_threads_option_defs)
8066         (make_info_threads_options_def_group): New.
8067         (info_threads_command): Use gdb::option::process_options.
8068         (info_threads_command_completer): New.
8069         (_initialize_thread): Use gdb::option::build_help to build the
8070         help text for "info threads".
8071
8072 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8073
8074         * defs.h (generic_load): Move from here...
8075         * symfile.h (generic_load): ... to here.  Rename name parameter
8076         to args.
8077         * symfile.c (generic_load): Add comment.
8078
8079 2019-07-01  Tom Tromey  <tromey@adacore.com>
8080
8081         * dwarf2read.c
8082         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8083         declaration of without_params.  Fix formatting.
8084
8085 2019-07-01  Tom Tromey  <tromey@adacore.com>
8086
8087         * ada-exp.y (find_primitive_type): Update.
8088         * ada-lang.h (ada_lookup_symbol): Update.
8089         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8090         parameter.
8091         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8092
8093 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8094
8095         PR breakpoints/24541
8096         * gdbarch.c: Regenerate.
8097         * gdbarch.h: Regenerate.
8098         * gdbarch.sh: Add 'stap_adjust_register'.
8099         * i386-tdep.c: Include '<unordered_set>'.
8100         (i386_stap_adjust_register): New function.
8101         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8102         * stap-probe.c (stap_parse_register_operand): Call
8103         'gdbarch_stap_adjust_register'.
8104
8105 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8106
8107         PR python/24742
8108         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8109         * python/python.c (do_start_initialization): Use 'xmalloc'
8110         instead of 'PyMem_Malloc'.
8111
8112 2019-06-28  Tom Tromey  <tromey@adacore.com>
8113
8114         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8115         for Ada.
8116
8117 2019-06-27  Tom Tromey  <tromey@adacore.com>
8118
8119         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8120         objfile_key.
8121         (arm_find_mapping_symbol, arm_record_special_symbol)
8122         (_initialize_arm_tdep): Update.
8123         (arm_objfile_data_free): Remove.
8124
8125 2019-06-27  Tom Tromey  <tromey@adacore.com>
8126
8127         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8128         to cp_print_static_field.
8129
8130 2019-06-26  Tom Tromey  <tromey@adacore.com>
8131
8132         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8133         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8134         declare.
8135
8136 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8137
8138         * features/aarch64-core.c (create_feature_aarch64_core):
8139         Regenerate.
8140         * features/aarch64-core.xml: Add cpsr flags.
8141
8142 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8143
8144         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8145         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8146
8147 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8148
8149         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8150         field.
8151         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8152         use.
8153         (arm_record_special_symbol): Don't insert new symbol in sorted
8154         position, push it at the end.
8155
8156 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8157
8158         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8159         (arm_mapping_symbol_s): Remove.
8160         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8161         (arm_mapping_symbol_vec): New typedef.
8162         (struct arm_per_objfile): Add constructor.
8163         <section_maps>: Change type to
8164         std::unique_ptr<arm_mapping_symbol_vec[]>.
8165         (arm_compare_mapping_symbols): Remove.
8166         (arm_find_mapping_symbol): Adjust to section_maps type change.
8167         (arm_objfile_data_free): Call delete on arm_per_objfile.
8168         (arm_record_special_symbol): Adjust to section_maps type change.
8169         Allocate arm_per_objfile with new.
8170
8171 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8172
8173         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8174         with the command prefix.
8175
8176 2019-06-25  Tom Tromey  <tom@tromey.com>
8177
8178         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8179         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8180
8181 2019-06-25  Tom Tromey  <tom@tromey.com>
8182
8183         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8184         type.
8185         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8186         protected.
8187
8188 2019-06-25  Tom Tromey  <tom@tromey.com>
8189
8190         * tui/tui-winsource.c
8191         (tui_source_window_base::set_is_exec_point_at): Add check against
8192         LOA_ADDRESS.
8193
8194 2019-06-25  Tom Tromey  <tom@tromey.com>
8195
8196         * tui/tui-source.c (tui_set_source_content): Don't check before
8197         xfree.
8198         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8199
8200 2019-06-25  Tom Tromey  <tom@tromey.com>
8201
8202         * tui/tui-winsource.h (tui_update_source_window_as_is)
8203         (tui_alloc_source_buffer, tui_line_is_displayed)
8204         (tui_addr_is_displayed): Change type of win_info.
8205         * tui/tui-winsource.c (tui_update_source_window_as_is)
8206         (tui_clear_source_content, tui_show_source_line)
8207         (tui_show_source_content, tui_source_window_base::refill)
8208         (tui_source_window_base::set_is_exec_point_at)
8209         (tui_source_window_base::set_is_exec_point_at)
8210         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8211         (tui_alloc_source_buffer, tui_line_is_displayed)
8212         (tui_addr_is_displayed): Change type of win_info.  Update.
8213         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8214         (tui_source_window_base::do_make_visible_with_new_height):
8215         Update.
8216         * tui/tui-source.c (tui_set_source_content)
8217         (tui_set_source_content_nil)
8218         (tui_source_window::do_scroll_vertical): Update.
8219         * tui/tui-layout.c (show_layout): Update.
8220         * tui/tui-disasm.c (tui_set_disassem_content)
8221         (tui_disasm_window::do_scroll_vertical): Update.
8222         * tui/tui-data.h (tui_win_content): Remove.
8223         (struct tui_gen_win_info) <content, content_size>: Remove.
8224         (struct tui_source_element): Add initializers and destructor.
8225         (union tui_which_element, struct tui_win_element): Remove.
8226         (struct tui_source_window_base) <content>: New field.
8227         (struct tui_data_window): Remove destructor.
8228         (tui_alloc_content, tui_free_win_content)
8229         (tui_free_all_source_wins_content): Don't declare.
8230         * tui/tui-data.c (tui_initialize_static_data): Update.
8231         (init_content_element, tui_alloc_content): Remove.
8232         (~tui_gen_win_info): Update.
8233         (~tui_data_window, tui_free_all_source_wins_content)
8234         (tui_free_win_content, free_content, free_content_elements):
8235         Remove.
8236
8237 2019-06-25  Tom Tromey  <tom@tromey.com>
8238
8239         * tui/tui-winsource.h (tui_clear_source_content)
8240         (tui_erase_source_content, tui_show_source_content): Change type
8241         of win_info.
8242         * tui/tui-winsource.c (tui_clear_source_content)
8243         (tui_erase_source_content, tui_show_source_content): Change type
8244         of win_info.
8245         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8246         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8247         win_info.
8248         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8249         win_info.
8250         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8251
8252 2019-06-25  Tom Tromey  <tom@tromey.com>
8253
8254         * tui/tui-winsource.c (tui_clear_source_content)
8255         (tui_source_window_base::set_is_exec_point_at): Update.
8256         * tui/tui-source.c (tui_set_source_content_nil): Update.
8257         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8258         a bool.
8259         * tui/tui-data.c (init_content_element): Update.
8260
8261 2019-06-25  Tom Tromey  <tom@tromey.com>
8262
8263         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8264         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8265         * tui/tui-layout.c (init_and_make_win): Update.
8266         * tui/tui.h (enum tui_win_type): Update.
8267         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8268         tui_win_is_auxillary.
8269         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8270         tui_win_is_auxillary.
8271
8272 2019-06-25  Tom Tromey  <tom@tromey.com>
8273
8274         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8275         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8276         (tui_delete_data_content_windows, tui_display_all_data)
8277         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8278         Update.
8279         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8280         * tui/tui-regs.c (tui_last_regs_line_no)
8281         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8282         (tui_show_registers): Update.
8283         (tui_show_register_group): Return void.  Update.
8284         (tui_display_registers_from, tui_display_reg_element_at_line)
8285         (tui_display_registers_from_line, tui_check_register_values):
8286         Update.
8287         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8288         member.
8289         (struct tui_data_window) <regs_content>: Now a std::vector.
8290         <regs_content_count>: Remove.
8291         (tui_add_content_elements, tui_free_data_content): Don't declare.
8292         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8293         (init_content_element): Remove DATA_WIN case.  Add assert.
8294         (tui_add_content_elements): Remove.
8295         (tui_data_window): Update.
8296         (tui_free_data_content): Remove.
8297         (free_content_elements): Remove DATA_WIN case.
8298
8299 2019-06-25  Tom Tromey  <tom@tromey.com>
8300
8301         * tui/tui-data.c (tui_data_item_window): Update.
8302         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8303         * tui/tui-windata.c (tui_display_all_data)
8304         (tui_display_data_from_line): Update.
8305         (tui_check_data_values): Remove.
8306         * tui/tui-regs.c (tui_show_register_group)
8307         (tui_display_reg_element_at_line): Update.
8308         * tui/tui-hooks.c (tui_register_changed)
8309         (tui_refresh_frame_and_register_information): Call
8310         tui_check_register_values.
8311         * tui/tui-data.h (struct tui_data_window) <data_content,
8312         data_content_count, data_type>: Remove.
8313         (enum tui_data_type): Remove.
8314
8315         * tui/tui-data.c (tui_data_window::clear_detail)
8316         (~tui_data_window): Update.
8317
8318 2019-06-25  Tom Tromey  <tom@tromey.com>
8319
8320         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8321         declare.
8322         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8323         Rename from tui_first_data_item_displayed.  Update.
8324         (tui_data_window::refresh_all)
8325         (tui_data_window::do_scroll_vertical): Update.
8326         * tui/tui-data.h (struct tui_data_window)
8327         <first_data_item_displayed>: Declare new method.
8328
8329 2019-06-25  Tom Tromey  <tom@tromey.com>
8330
8331         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8332         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8333         contents...
8334         (tui_initialize_static_data): ...here.
8335
8336 2019-06-25  Tom Tromey  <tom@tromey.com>
8337
8338         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8339         (tui_display_registers_from, tui_check_register_values): Update.
8340         (tui_display_register): Remove win_info parameter; update.
8341         (tui_get_register): Change type of parameters.
8342         * tui/tui-data.h (struct tui_data_element): Remove.
8343         (union tui_which_element) <data>: Remove.
8344         <data_window>: Change type.
8345         (struct tui_data_item_window): New.
8346         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8347         case.  Add assert.
8348         (~tui_data_item_window): New destructor.
8349         (free_content_elements): Remove DATA_ITEM_WIN case.
8350
8351 2019-06-25  Tom Tromey  <tom@tromey.com>
8352
8353         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8354         Remove.
8355
8356 2019-06-25  Tom Tromey  <tom@tromey.com>
8357
8358         * tui/tui-data.h (struct tui_command_element): Remove.
8359         (union tui_which_element) <command>: Remove.
8360         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8361         assert.
8362         (free_content_elements): Remove CMD_WIN case.
8363
8364 2019-06-25  Tom Tromey  <tom@tromey.com>
8365
8366         * tui/tui-layout.c (tui_set_layout): Update.
8367         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8368         * tui/tui-data.c (layout_def): Update.
8369
8370 2019-06-25  Tom Tromey  <tom@tromey.com>
8371
8372         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8373         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8374         (tui_source_window_base::set_new_height): Update.
8375         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8376         Update.
8377         (tui_set_locator_fullname, tui_set_locator_info)
8378         (tui_show_frame_info): Update.
8379         * tui/tui-source.c (tui_set_source_content)
8380         (tui_source_is_displayed): Update.
8381         * tui/tui-layout.c (show_source_disasm_command, show_data)
8382         (show_source_or_disasm_and_command): Update.
8383         * tui/tui-disasm.c (tui_set_disassem_content)
8384         (tui_get_begin_asm_address): Update.
8385         * tui/tui-data.h (struct tui_locator_element): Remove.
8386         (union tui_which_element) <locator>: Remove.
8387         (struct tui_locator_window): New.
8388         (tui_locator_win_info_ptr): Change return type.
8389         * tui/tui-data.c (_locator): Change type.
8390         (tui_locator_win_info_ptr): Change return type.
8391         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8392         (tui_alloc_content): Add assert.
8393
8394 2019-06-25  Tom Tromey  <tom@tromey.com>
8395
8396         * tui/tui-winsource.c
8397         (tui_exec_info_window::maybe_allocate_content): New method.
8398         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8399         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8400         (make_source_or_disasm_window): Add cast.
8401         * tui/tui-data.h (union tui_which_element) <simple_string>:
8402         Remove.
8403         (struct tui_source_info): New.
8404         (struct tui_source_window_base) <execution_info>: Change type.
8405         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8406         case, and add assert.
8407         (tui_alloc_content): Add assert.
8408
8409 2019-06-25  Tom Tromey  <tom@tromey.com>
8410
8411         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8412         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8413         * tui/tui-data.c (tui_alloc_win_info): Remove.
8414
8415 2019-06-25  Tom Tromey  <tom@tromey.com>
8416
8417         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8418         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8419         can_highlight.
8420
8421 2019-06-25  Tom Tromey  <tom@tromey.com>
8422
8423         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8424         make_visible_with_new_height method.
8425         (tui_win_info::make_visible_with_new_height): New method.
8426         (tui_source_window_base::do_make_visible_with_new_height)
8427         (tui_data_window::do_make_visible_with_new_height)
8428         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8429         (make_visible_with_new_height): Remove.
8430         (tui_resize_all, tui_adjust_win_heights): Use
8431         make_visible_with_new_height method.
8432         * tui/tui-data.h (struct tui_win_info)
8433         <do_make_visible_with_new_height, make_visible_with_new_height>:
8434         New methods.
8435         (struct tui_source_window_base, struct tui_data_window)
8436         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8437         methods.
8438
8439 2019-06-25  Tom Tromey  <tom@tromey.com>
8440
8441         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8442         method.
8443         (update_tab_width): Call update_tab_width method.
8444         * tui/tui-data.h (struct tui_win_info)
8445         (struct tui_source_window_base) <update_tab_width>: New methods.
8446
8447 2019-06-25  Tom Tromey  <tom@tromey.com>
8448
8449         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8450         parameter.
8451         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8452         parameter.
8453         (tui_gen_win_info::make_visible): Update.
8454         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8455         parameter.
8456         * tui/tui-data.h (enum tui_box): New enum.
8457         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8458
8459 2019-06-25  Tom Tromey  <tom@tromey.com>
8460
8461         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8462         init_and_make_win for EXEC_INFO_WIN.
8463         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8464         longer inline.
8465         (struct tui_win_info) <~tui_win_info>: Inline.
8466         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8467         Don't declare.
8468         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8469         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8470         Remove.
8471         (tui_initialize_static_data): Update.
8472         (~tui_gen_win_info): Handle more cleanup here.
8473         (~tui_source_window_base): Delete "execution_info".
8474         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8475
8476 2019-06-25  Tom Tromey  <tom@tromey.com>
8477
8478         * tui/tui-layout.c (make_command_window): Don't set
8479         can_highlight.
8480         (show_source_disasm_command): Call the reset method.
8481         (show_data): Don't set can_highlight.  Call the reset method.
8482         (tui_gen_win_info::reset): Rename from init_gen_win_info
8483         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8484         (show_source_or_disasm_and_command): Call the reset method.
8485         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8486         (struct tui_cmd_window): Set can_highlight.
8487
8488 2019-06-25  Tom Tromey  <tom@tromey.com>
8489
8490         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8491         from make_visible.
8492         (tui_make_visible, tui_make_invisible): Rewrite.
8493         (tui_win_info::make_visible): Remove.
8494         (tui_source_window_base::make_visible): Update.
8495         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8496         method.  Moved from...
8497         (struct tui_win_info) <make_visible>: ...here.
8498
8499 2019-06-25  Tom Tromey  <tom@tromey.com>
8500
8501         * tui/tui-winsource.c
8502         (tui_source_window_base::do_scroll_horizontal): Remove direction
8503         parameter.
8504         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8505         direction parameter.
8506         * tui/tui-win.c (tui_win_info::forward_scroll)
8507         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8508         (tui_win_info::right_scroll): Update.
8509         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8510         direction parameter.
8511         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8512         direction parameter.
8513         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8514         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8515         Remove direction parameter.
8516         (struct tui_source_window_base, struct tui_source_window)
8517         (struct tui_disasm_window, struct tui_data_window)
8518         (struct tui_cmd_window): Update.
8519
8520 2019-06-25  Tom Tromey  <tom@tromey.com>
8521
8522         * tui/tui-winsource.h (tui_set_exec_info_content)
8523         (tui_show_exec_info_content, tui_erase_exec_info_content)
8524         (tui_clear_exec_info_content, tui_update_exec_info): Change
8525         argument to tui_source_window_base.
8526         * tui/tui-winsource.c (tui_set_exec_info_content)
8527         (tui_show_exec_info_content, tui_erase_exec_info_content)
8528         (tui_clear_exec_info_content, tui_update_exec_info): Change
8529         argument to tui_source_window_base.
8530
8531 2019-06-25  Tom Tromey  <tom@tromey.com>
8532
8533         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8534         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8535
8536 2019-06-25  Tom Tromey  <tom@tromey.com>
8537
8538         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8539         check.
8540
8541 2019-06-25  Tom Tromey  <tom@tromey.com>
8542
8543         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8544         type to void.
8545         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8546         type to void.
8547         * tui/tui-source.c (tui_set_source_content): Update.
8548         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8549
8550 2019-06-25  Tom Tromey  <tom@tromey.com>
8551
8552         * tui/tui-win.c (window_name_completer, tui_set_focus)
8553         (tui_all_windows_info): Use name method.
8554         * tui/tui-data.h (struct tui_gen_win_info)
8555         (struct tui_source_window, struct tui_disasm_window)
8556         (struct tui_data_window, struct tui_cmd_window) <name>: New
8557         method.
8558         (tui_win_name): Don't declare.
8559         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8560         (tui_win_name): Remove.
8561
8562 2019-06-25  Tom Tromey  <tom@tromey.com>
8563
8564         * tui/tui-winsource.h (tui_update_source_window)
8565         (tui_update_source_window_as_is): Change parameter type.
8566         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8567         to be a tui_source_window_base.
8568         (tui_update_source_window_as_is): Likewise.
8569         * tui/tui-win.c (make_visible_with_new_height): Update.
8570
8571 2019-06-25  Tom Tromey  <tom@tromey.com>
8572
8573         * tui/tui-winsource.c (tui_erase_source_content)
8574         (tui_show_source_content, tui_show_exec_info_content)
8575         (tui_erase_exec_info_content): Use refresh_window method.
8576         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8577         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8578         from tui_refresh_win.
8579         (tui_data_window::refresh_window): New method.
8580         (tui_win_info::refresh, tui_source_window_base::refresh)
8581         (tui_refresh_all): Use refresh_window method.
8582         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8583         method.
8584         * tui/tui-regs.c (tui_display_register): Call refresh_window
8585         method.
8586         * tui/tui-layout.c (show_source_disasm_command)
8587         (show_source_or_disasm_and_command): Call refresh_window method.
8588         * tui/tui-data.h (struct tui_gen_win_info)
8589         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8590         New method.
8591
8592 2019-06-25  Tom Tromey  <tom@tromey.com>
8593
8594         * tui/tui.c (tui_rl_other_window, tui_enable)
8595         (tui_is_window_visible, tui_get_command_dimension): Update.
8596         * tui/tui-winsource.c (tui_update_source_window_as_is)
8597         (tui_clear_source_content, tui_erase_source_content)
8598         (tui_show_source_line, tui_source_window_base::refill)
8599         (tui_source_window_base::do_scroll_horizontal)
8600         (tui_source_window_base::set_is_exec_point_at)
8601         (tui_update_breakpoint_info, tui_set_exec_info_content)
8602         (tui_alloc_source_buffer, tui_line_is_displayed)
8603         (tui_addr_is_displayed): Update.
8604         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8605         (tui_check_and_display_highlight_if_needed)
8606         (tui_win_info::make_visible, tui_win_info::refresh)
8607         (tui_refresh_all): Update.
8608         * tui/tui-windata.c (tui_first_data_item_displayed)
8609         (tui_delete_data_content_windows, tui_erase_data_content)
8610         (tui_display_all_data, tui_data_window::refresh_all)
8611         (tui_check_data_values): Update.
8612         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8613         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8614         (tui_win_info::backward_scroll, tui_refresh_all_win)
8615         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8616         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8617         (tui_source_window_base::set_new_height)
8618         (tui_data_window::set_new_height)
8619         (make_invisible_and_set_new_height)
8620         (make_visible_with_new_height, new_height_ok)
8621         (parse_scrolling_args): Update.
8622         * tui/tui-stack.c (tui_show_frame_info): Update.
8623         * tui/tui-source.c (tui_set_source_content)
8624         (tui_set_source_content_nil, tui_source_is_displayed)
8625         (tui_source_window::do_scroll_vertical): Update.
8626         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8627         (tui_display_registers_from, tui_display_reg_element_at_line)
8628         (tui_check_register_values, tui_reg_command): Update.
8629         * tui/tui-layout.c (tui_default_win_height)
8630         (show_source_disasm_command, show_data, init_and_make_win)
8631         (show_source_or_disasm_and_command): Update.
8632         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8633         (tui_redisplay_readline, tui_mld_flush)
8634         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8635         (tui_getc): Update.
8636         * tui/tui-disasm.c (tui_set_disassem_content)
8637         (tui_disasm_window::do_scroll_vertical): Update.
8638         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8639         Now virtual.
8640         (struct tui_win_info): Derive from tui_gen_win_info.
8641         <~tui_win_info>: Mark as override.
8642         <generic>: Remove member.
8643         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8644         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8645         (~tui_data_window, ~tui_win_info)
8646         (tui_free_all_source_wins_content): Update.
8647         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8648
8649 2019-06-25  Tom Tromey  <tom@tromey.com>
8650
8651         * tui/tui-layout.c (init_and_make_win): Use new.
8652         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8653         destructor, initializers.
8654         (tui_alloc_generic_win_info): Don't declare.
8655         * tui/tui-data.c (_locator): Add argument to constructor.
8656         (source_win, disasm_win): New globals.
8657         (exec_info): Remove.
8658         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8659         Update.
8660         (tui_alloc_generic_win_info): Remove.
8661         (init_content_element): Use new.
8662         (tui_win_info::tui_win_info): Update.
8663         (free_content_elements) <case DATA_WIN>: Use delete.
8664
8665 2019-06-25  Tom Tromey  <tom@tromey.com>
8666
8667         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8668         * tui/tui-windata.c (tui_first_data_item_displayed)
8669         (tui_delete_data_content_windows): Update.
8670         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8671         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8672         (tui_display_registers_from, tui_check_register_values): Update.
8673         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8674         pointer.
8675         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8676         window.
8677         (tui_free_data_content): Update.
8678         (free_content_elements) <case DATA_WIN>: Free the window.
8679
8680 2019-06-25  Tom Tromey  <tom@tromey.com>
8681
8682         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8683         Update.
8684         * tui/tui-layout.c (make_command_window)
8685         (show_source_disasm_command, show_data, init_and_make_win)
8686         (show_source_or_disasm_and_command): Update.
8687         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8688         method.
8689         <can_highight, is_highlighted>: Now bool.
8690         (tui_set_win_highlight): Don't declare.
8691         * tui/tui-data.c (tui_set_win_highlight): Remove.
8692
8693 2019-06-25  Tom Tromey  <tom@tromey.com>
8694
8695         * tui/tui-wingeneral.c (make_visible): Remove check of window
8696         type.
8697
8698 2019-06-25  Tom Tromey  <tom@tromey.com>
8699
8700         * tui/tui-win.c (tui_win_info::max_height)
8701         (tui_cmd_window::max_height): New methods.
8702         (new_height_ok): Call max_height.
8703         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8704         <max_height>: New method.
8705
8706 2019-06-25  Tom Tromey  <tom@tromey.com>
8707
8708         * tui/tui-win.c (tui_source_window_base::set_new_height)
8709         (tui_data_window::set_new_height): New methods.
8710         (make_invisible_and_set_new_height): Call set_new_height method.
8711         * tui/tui-data.h (struct tui_win_info)
8712         (struct tui_source_window_base, struct tui_data_window)
8713         <set_new_height>: New method.
8714
8715 2019-06-25  Tom Tromey  <tom@tromey.com>
8716
8717         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8718         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8719         tui_refresh_data_win.
8720         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8721         method.
8722         (tui_refresh_all_win): Call the refresh_all method.
8723         (tui_set_focus): Likewise.
8724         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8725         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8726         Likewise.
8727
8728 2019-06-25  Tom Tromey  <tom@tromey.com>
8729
8730         * tui/tui-winsource.h (tui_refill_source_window)
8731         (tui_set_is_exec_point_at): Don't declare.
8732         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8733         (tui_source_window_base::refill): Rename from
8734         tui_refill_source_window.
8735         (tui_source_window_base::do_scroll_horizontal): Update.
8736         (tui_source_window_base::set_is_exec_point_at): Rename from
8737         tui_set_is_exec_point_at.
8738         (tui_update_all_breakpoint_info): Update.
8739         * tui/tui-stack.c (tui_show_frame_info): Update.
8740         * tui/tui-layout.c (show_data): Add cast.
8741         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8742         * tui/tui-data.h (struct tui_source_window_base) <refill,
8743         set_is_exec_point_at>: New methods.
8744         (tui_source_windows, tui_add_to_source_windows): Update types.
8745         (tui_add_to_source_windows): Remove redundant declaration.
8746         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8747         (tui_source_windows): Change return type.
8748         (tui_clear_source_windows_detail): Update.
8749         (tui_add_to_source_windows): Change type of parameter.
8750         (tui_free_all_source_wins_content): Update.
8751
8752 2019-06-25  Tom Tromey  <tom@tromey.com>
8753
8754         * tui/tui-wingeneral.c (tui_win_info::refresh)
8755         (tui_source_window_base::refresh): New methods.
8756         (tui_refresh_all): Call the refresh method.
8757         * tui/tui-data.h (struct tui_win_info)
8758         (struct tui_source_window_base) <refresh>: New method.
8759
8760 2019-06-25  Tom Tromey  <tom@tromey.com>
8761
8762         * tui/tui.h (tui_is_window_visible): Return bool.
8763         * tui/tui.c (tui_is_window_visible): Return bool.
8764         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8765         (tui_make_visible, tui_make_invisible)
8766         (tui_win_info::make_visible)
8767         (tui_source_window_base::make_visible, make_all_visible)
8768         (tui_make_all_visible, tui_make_all_invisible): Update.
8769         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8770         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8771         bool.
8772         (struct tui_win_info, struct tui_source_window_base)
8773         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8774         * tui/tui-data.c (tui_init_generic_part): Update.
8775
8776 2019-06-25  Tom Tromey  <tom@tromey.com>
8777
8778         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8779         (tui_source_window_base::make_visible): New methods.
8780         (make_all_visible): Make method call.
8781         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8782         (struct tui_source_window_base, struct tui_cmd_window): Override
8783         make_visible.
8784         (tui_win_is_source_type): Don't declare.
8785         * tui/tui-data.c (tui_win_is_source_type): Remove.
8786
8787 2019-06-25  Tom Tromey  <tom@tromey.com>
8788
8789         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8790         NULL check.
8791
8792 2019-06-25  Tom Tromey  <tom@tromey.com>
8793
8794         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8795         Inline constructor.  Add initializers for members.
8796         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8797         constructors; now inline in class.
8798
8799 2019-06-25  Tom Tromey  <tom@tromey.com>
8800
8801         * tui/tui-regs.c (tui_show_registers): Update.
8802         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8803         bool.
8804         * tui/tui-data.c (tui_data_window::clear_detail)
8805         (tui_data_window): Update.
8806
8807 2019-06-25  Tom Tromey  <tom@tromey.com>
8808
8809         * tui/tui-windata.c (tui_display_all_data)
8810         (tui_display_data_from_line, tui_display_data_from)
8811         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8812         Update.
8813         * tui/tui-regs.c (tui_last_regs_line_no)
8814         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8815         (tui_show_registers, tui_show_register_group)
8816         (tui_display_registers_from, tui_display_reg_element_at_line)
8817         (tui_display_registers_from_line, tui_check_register_values)
8818         (tui_reg_next, tui_reg_prev): Update.
8819         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8820         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8821         tui_data_window.
8822         (struct tui_win_info) <detail>: Remove.  Add new fields from
8823         tui_data_info.
8824         (TUI_DATA_WIN): Add cast.
8825         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8826         (~tui_data_window): Simplify.
8827
8828 2019-06-25  Tom Tromey  <tom@tromey.com>
8829
8830         * tui/tui-layout.c (show_source_disasm_command)
8831         (show_source_or_disasm_and_command): Update.
8832         * tui/tui-io.c (update_cmdwin_start_line)
8833         (tui_redisplay_readline): Update.
8834         * tui/tui-data.h (struct tui_command_info): Remove.
8835         (struct tui_win_info) <detail>: Remove command_info member.
8836         (struct tui_data_window) <start_line>: New member, from
8837         tui_command_info.
8838         (TUI_CMD_WIN): Add casts.
8839
8840 2019-06-25  Tom Tromey  <tom@tromey.com>
8841
8842         * tui/tui-winsource.c (tui_update_source_window)
8843         (tui_refill_source_window)
8844         (tui_source_window_base::do_scroll_horizontal)
8845         (tui_update_breakpoint_info, tui_set_exec_info_content)
8846         (tui_show_exec_info_content, tui_erase_exec_info_content)
8847         (tui_clear_exec_info_content): Update.
8848         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8849         Update.
8850         * tui/tui-win.c (make_invisible_and_set_new_height)
8851         (make_visible_with_new_height): Update.
8852         * tui/tui-source.c (tui_set_source_content)
8853         (tui_show_symtab_source): Update.
8854         * tui/tui-layout.c (extract_display_start_addr)
8855         (show_source_disasm_command, show_data)
8856         (make_source_or_disasm_window)
8857         (show_source_or_disasm_and_command): Update.
8858         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8859         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8860         "gdbarch".
8861         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8862         to tui_source_window_base.
8863         (struct tui_win_info) <detail>: Remove source_info member.
8864         (struct tui_source_window_base) <has_locator>: Inline.
8865         Move contents from tui_source_info; rename has_locator member to
8866         m_has_locator.
8867         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8868         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8869         header file.
8870         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8871         Simplify.
8872         (tui_free_all_source_wins_content): Cast to
8873         tui_source_window_base.
8874
8875 2019-06-25  Tom Tromey  <tom@tromey.com>
8876
8877         * tui/tui-win.c (make_invisible_and_set_new_height)
8878         (make_visible_with_new_height): Call has_locator method.
8879         * tui/tui-layout.c (show_source_disasm_command, show_data)
8880         (show_source_or_disasm_and_command): Update for bool change.
8881         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8882         (tui_win_info) <has_locator>: New method.
8883         (struct tui_source_window_base) <has_locator>: New method.
8884         (tui_win_has_locator): Don't declare.
8885         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8886         from tui_win_has_locator.
8887         (tui_source_window_base): Use false, not FALSE.
8888
8889 2019-06-25  Tom Tromey  <tom@tromey.com>
8890
8891         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8892         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8893         clear_detail method directly.
8894         (tui_clear_win_detail): Remove.
8895
8896 2019-06-25  Tom Tromey  <tom@tromey.com>
8897
8898         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8899         "this", not TUI_DISASM_WIN.
8900
8901 2019-06-25  Tom Tromey  <tom@tromey.com>
8902
8903         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8904         declare.
8905         * tui/tui-winsource.c
8906         (tui_source_window_base::do_scroll_horizontal): Rename from
8907         tui_horizontal_source_scroll.
8908         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8909         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8910         from tui_vertical_data_scroll.
8911         * tui/tui-win.h (tui_scroll): Don't declare.
8912         * tui/tui-win.c (tui_win_info::forward_scroll)
8913         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8914         (tui_win_info::right_scroll): Rename and update.
8915         (tui_scroll_forward_command, tui_scroll_backward_command)
8916         (tui_scroll_left_command, tui_scroll_right_command): Update.
8917         (tui_scroll): Remove.
8918         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8919         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8920         from tui_vertical_source_scroll.
8921         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8922         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8923         from tui_vertical_disassem_scroll.
8924         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8925         do_scroll_horizontal>: New methods.
8926         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8927         Likewise.
8928         (struct tui_source_window_base): Add do_scroll_horizontal.
8929         (struct tui_source_window, struct tui_disasm_window): Add
8930         do_scroll_vertical.
8931         (struct tui_data_window, struct tui_cmd_window): Add
8932         do_scroll_horizontal and do_scroll_vertical.
8933         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8934
8935 2019-06-25  Tom Tromey  <tom@tromey.com>
8936
8937         * tui/tui-data.h (struct tui_source_window_base): New struct.
8938         (struct tui_source_window): Derive from tui_source_window_base.
8939         (struct tui_disasm_window): New struct.
8940         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8941         from tui_source_window::clear_detail.
8942         (tui_source_window_base): Rename from tui_source_window.
8943         (~tui_source_window_base): Rename from ~tui_source_window.
8944         (tui_alloc_win_info): Create a tui_disasm_window.
8945
8946 2019-06-25  Tom Tromey  <tom@tromey.com>
8947
8948         * tui/tui-data.h (struct tui_source_window)
8949         (struct tui_data_window): Declare destructors.
8950         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8951         destructors.
8952         (tui_win_info): Simplify.
8953
8954 2019-06-25  Tom Tromey  <tom@tromey.com>
8955
8956         * tui/tui-winsource.c (tui_display_main)
8957         (tui_update_source_windows_with_addr)
8958         (tui_update_all_breakpoint_info): Update.
8959         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8960         (new_height_ok, parse_scrolling_args): Update.
8961         * tui/tui-stack.c (tui_show_frame_info): Update.
8962         * tui/tui-data.h (struct tui_list): Remove.
8963         (tui_source_windows): Return a reference to a std::vector.
8964         * tui/tui-data.c (source_windows): Now a std::vector.
8965         (tui_source_windows): Change return type.
8966         (tui_clear_source_windows): Rewrite.
8967         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8968         (tui_free_all_source_wins_content): Rewrite.
8969
8970 2019-06-25  Tom Tromey  <tom@tromey.com>
8971
8972         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8973         (struct tui_data_window, struct tui_cmd_window): Declare
8974         clear_detail method.
8975         * tui/tui-data.c (tui_source_window::clear_detail)
8976         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8977         methods.
8978         (tui_clear_win_detail): Simplify.
8979
8980 2019-06-25  Tom Tromey  <tom@tromey.com>
8981
8982         * tui/tui-layout.c (make_source_window, make_disasm_window)
8983         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8984         Return the new window.
8985         (show_source_disasm_command, show_data)
8986         (show_source_or_disasm_and_command): Update.
8987
8988 2019-06-25  Tom Tromey  <tom@tromey.com>
8989
8990         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8991         parameter.  Return the new window.
8992         (show_source_disasm_command): Update and remove NULL check.
8993         (show_source_or_disasm_and_command): Update.
8994
8995 2019-06-25  Tom Tromey  <tom@tromey.com>
8996
8997         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8998
8999 2019-06-25  Tom Tromey  <tom@tromey.com>
9000
9001         * tui/tui-data.h (struct tui_win_info): Make constructor
9002         protected.  Make destructor virtual.  Add initializers.
9003         (tui_source_window, tui_data_window, tui_cmd_window): New
9004         classes.
9005         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
9006         constructor.  Add "type" parameter.
9007         (tui_source_window, tui_data_window, tui_cmd_window): New
9008         constructors.
9009         (tui_alloc_win_info): Instantiate the appropriate subclass.
9010
9011 2019-06-25  Tom Tromey  <tom@tromey.com>
9012
9013         * tui/tui-win.c (tui_resize_all): Use delete.
9014         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9015         destructor.
9016         (tui_free_window): Don't declare.
9017         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9018         Update.
9019
9020 2019-06-25  Tom Tromey  <tom@tromey.com>
9021
9022         * tui/tui-data.h (struct tui_win_info): Add constructor.
9023         * tui/tui-data.c (tui_alloc_win_info): Use new.
9024         (tui_free_window): Use delete.
9025
9026 2019-06-22  Tom Tromey  <tom@tromey.com>
9027
9028         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9029         declare.
9030         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9031
9032 2019-06-22  Tom Tromey  <tom@tromey.com>
9033
9034         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9035         declare.
9036         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9037
9038 2019-06-22  Tom de Vries  <tdevries@suse.de>
9039
9040         * dwarf2read.c (create_addrmap_from_aranges)
9041         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9042         instead of '%zu'.
9043
9044 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
9045
9046         * dwarf2read.h (dwarf2_section_info_def): Remove.
9047         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9048         * dwarf2read.c (struct dwo_sections) <types>: Change type to
9049         std::vector<dwarf2_section_info>.
9050         (struct dwo_file) <~dwo_file>: Remove.
9051         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9052         types field.
9053         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9054         (dwarf2_read_debug_names): Likewise.
9055         (create_debug_types_hash_table): Change parameter type to
9056         array_view, adjust code accordingly.
9057         (dwarf2_locate_dwo_sections): Adjust to std::vector.
9058         (partial_die_info::fixup): Likewise.
9059         (determine_prefix): Likewise.
9060         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9061
9062 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9063
9064         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9065         gdb_bfd_ref_ptr.
9066         <~dwo_file>: Remove call to gdb_bfd_unref.
9067         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9068         gdb_bfd_ref_ptr::get.
9069
9070 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9071
9072         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9073         type to htab_up.
9074         * dwarf2read.c (struct dwo_file): Initialize fields.
9075         <~dwo_file>: New.
9076         (free_dwo_file): Remove, move content to ~dwo_file.
9077         (struct dwo_file_deleter): Remove.
9078         (dwo_file_up>: Remove custom deleter.
9079         (free_dwo_files): Remove.
9080         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9081         dwo_files.
9082         (process_skeletonless_type_units): Call unique_ptr::get.
9083         (allocate_dwo_file_hash_table): Add deleter to created hash
9084         table.  Change return type to htab_up.
9085         (lookup_dwo_file_slot): Don't memset dwo_file, call
9086         unique_ptr::get.
9087         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9088         (create_dwo_unit_in_dwp_v2): Likewise.
9089         (open_and_init_dwo_file): Likewise.
9090         (free_dwo_file_from_slot): Remove.
9091
9092 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9093
9094         * dwarf2read.h (struct dwarf2_section_info) <readin,
9095         is_virtual>: Change type to bool.
9096         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9097         true instead of 1.
9098
9099 2019-06-19  Tom Tromey  <tom@tromey.com>
9100
9101         * tui/tui-data.h (tui_init_content_element): Don't declare.
9102
9103 2019-06-19  Tom Tromey  <tom@tromey.com>
9104
9105         * tui/tui-data.h (tui_init_win_info): Don't declare.
9106
9107 2019-06-19  Tom de Vries  <tdevries@suse.de>
9108
9109         * dwarf2read.h (abstract_to_concrete): Change type to
9110         std::unordered_map<sect_offset, std::vector<sect_offset>,
9111         gdb::hash_enum<sect_offset>>.
9112
9113 2019-06-19  Tom Tromey  <tromey@adacore.com>
9114
9115         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9116         EVAL_AVOID_SIDE_EFFECTS specially.
9117
9118 2019-06-19  Tom Tromey  <tromey@adacore.com>
9119
9120         * source-cache.c (highlighter): New global.
9121         (source_cache::get_source_lines): Create a highlighter on demand.
9122
9123 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9124
9125         * defs.h (deprecated_interactive_hook): Delete declaration.
9126         * interps.c (clear_interpreter_hooks): Remove use of
9127         deprecated_interactive_hook.
9128         * top.c (deprecated_interactive_hook): Delete definition.
9129         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9130
9131 2019-06-18  Tom de Vries  <tdevries@suse.de>
9132
9133         PR gdb/24515
9134         * dwarf2read.h (abstract_to_concrete): Change type from
9135         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9136         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9137         * dwarf2read.c (read_variable): Update.
9138         (dwarf2_fetch_die_loc_sect_off): Update.
9139
9140 2019-06-17  Tom de Vries  <tdevries@suse.de>
9141
9142         PR gdb/24617
9143         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9144         accessing parent[parent_len - 1].
9145
9146 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9147
9148         PR gdb/24364
9149         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9150         call dtrace_process_dof with NULL dof.
9151
9152 2019-06-16  Tom de Vries  <tdevries@suse.de>
9153
9154         PR gdb/24445
9155         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9156
9157 2019-06-16  Tom Tromey  <tom@tromey.com>
9158
9159         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9160         (make_all_visible): Use address of member.
9161
9162 2019-06-16  Tom Tromey  <tom@tromey.com>
9163
9164         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9165         (tui_free_window, free_content, free_content_elements): Remove
9166         unnecessary cast.
9167         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9168         cast.
9169         * tui/tui-regs.c (tui_show_register_group)
9170         (tui_display_registers_from, tui_display_reg_element_at_line):
9171         Remove unnecessary cast.
9172
9173 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9174
9175         * linux-nat.c (normal_mask): Delete.
9176         (_initialize_linux_nat): Don't initialise normal_mask.
9177
9178 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9179
9180         PR gdb/24445
9181         * dwarf-index-write.h (write_psymtabs_to_index): Add
9182         dwz_basename parameter.
9183         * dwarf-index-write.c (write_gdbindex): Move file writing to
9184         write_gdbindex_1.  Change return type void.
9185         (assert_file_size): Move up, remove filename parameter.
9186         (write_gdbindex_1): New function.
9187         (write_debug_names): Change return type to void, call
9188         assert_file_size.
9189         (struct index_wip_file): New struct.
9190         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9191         file logic to index_wip_file.  Write index for dwz file if
9192         needed.
9193         (save_gdb_index_command): Pass basename of dwz file, if present.
9194         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9195         build-id of dwz file, if present.
9196         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9197         (dwarf2_get_dwz_file): Likewise.
9198         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9199         (dwarf2_get_dwz_file): Likewise.
9200
9201 2019-06-16  Tom Tromey  <tom@tromey.com>
9202
9203         * coffread.c (process_coff_symbol): Use xstrdup.
9204         * value.c (create_internalvar): Use xstrdup.
9205
9206 2019-06-16  Tom Tromey  <tom@tromey.com>
9207
9208         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9209         * breakpoint.c (stopin_command, stopat_command)
9210         (until_break_command, decode_location_default): Remove unnecessary
9211         cast.
9212         * utils.c (subset_compare): Remove unnecessary cast.
9213         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9214         cast.
9215         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9216         cast.
9217         * infcmd.c (path_command): Remove unnecessary cast.
9218         * coffread.c (decode_type): Remove unnecessary cast.
9219         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9220         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9221         * tui/tui-stack.c (tui_show_locator_content)
9222         (tui_show_frame_info): Remove unnecessary cast.
9223         * tui/tui-win.c (tui_scroll_forward_command)
9224         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9225         (parse_scrolling_args): Remove unnecessary cast.
9226         * tui/tui-data.c (init_win_info, tui_del_window)
9227         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9228         (free_content_elements): Remove unnecessary cast.
9229         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9230         unnecessary cast.
9231         * tui/tui-source.c (tui_set_source_content)
9232         (tui_vertical_source_scroll): Remove unnecessary cast.
9233         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9234         cast.
9235         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9236         * tui/tui-regs.c (tui_display_registers_from)
9237         (tui_display_register): Remove unnecessary cast.
9238         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9239         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9240         (make_visible): Remove unnecessary cast.
9241         * tui/tui-winsource.c (tui_erase_source_content)
9242         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9243         unnecessary cast.
9244         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9245         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9246         * stabsread.c (read_type, read_array_type, read_range_type):
9247         Remove unnecessary cast.
9248         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9249         (parse_symbol, parse_type, upgrade_type, parse_external)
9250         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9251         unnecessary cast.
9252         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9253
9254 2019-06-16  Tom Tromey  <tom@tromey.com>
9255
9256         * tui/tui-data.c (tui_alloc_generic_win_info)
9257         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9258         checks.
9259
9260 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9261             Andrew Burgess  <andrew.burgess@embecosm.com>
9262
9263         * f-typeprint.c (f_print_type): Don't return early for not
9264         associated or not allocated types.
9265         (f_type_print_varspec_suffix): Add print_rank parameter and print
9266         ranks of array types in case they dangling.
9267         (f_type_print_base): Add print_rank parameter.
9268
9269 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9270
9271         * NEWS: Mention new MI commands.
9272         * break-catch-throw.c (enum exception_event_kind): Move to
9273         breakpoint.h.
9274         (print_mention_exception_catchpoint): Output text as a single
9275         message.
9276         (catch_exception_command_1): Rename to...
9277         (catch_exception_event): ...this, make non-static, update header
9278         command, and change some parameter types.
9279         (catch_catch_command): Update for changes to
9280         catch_exception_command_1.
9281         (catch_throw_command): Likewise.
9282         (catch_rethrow_command): Likewise.
9283         * breakpoint.c (enum exception_event_kind): Delete.
9284         * breakpoint.h (enum exception_event_kind): Moved here from
9285         break-catch-throw.c.
9286         (catch_exception_event): Declare.
9287         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9288         (mi_cmd_catch_throw): New function.
9289         (mi_cmd_catch_rethrow): New function.
9290         (mi_cmd_catch_catch): New function.
9291         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9292         'catch-catch' entries.
9293         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9294         (mi_cmd_catch_rethrow): Declare.
9295         (mi_cmd_catch_catch): Declare.
9296
9297 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9298
9299         * annotate.c (annotate_source_line): Change return type to void,
9300         update implementation to match.
9301         * annotate.h (annotate_source_line): Change return type to void,
9302         update header comment.
9303         * stack.c (print_frame_info): Don't change what frame information
9304         is printed based on whether annotations are on or not.
9305
9306 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9307
9308         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9309         (annotate_source): Make static.
9310         (annotate_source_line): Moved from source.c and renamed from
9311         identify_source_line.  Update the return type.
9312         * annotate.h (annotate_source): Delete declaration.
9313         (annotate_source_line): Declaration moved from source.h, and
9314         renamed from identify_source_line.  Return type updated.
9315         * source.c (identify_source_line): Moved to annotate.c and renamed
9316         to annotate_source_line.
9317         (info_line_command): Remove check of annotation_level.
9318         * source.h (identify_source_line): Move declaration to annotate.h
9319         and rename to annotate_source_line.
9320         * stack.c: Add 'annotate.h' include.
9321         (print_frame_info): Remove check of annotation_level before
9322         calling annotate_source_line.
9323
9324 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9325
9326         * source-cache.c (source_cache::get_plain_source_lines): Use
9327         open_source_file_with_line_charpos instead of just
9328         open_source_file, remove call to find_source_lines.
9329         (source_cache::get_source_lines): Likewise.
9330         * source.c (find_source_lines): Make static.
9331         (get_filename_and_charpos): Renamed into...
9332         (open_source_file_with_line_charpos): ..this along with changes to
9333         return a scoped_fd, and some other minor clean ups.
9334         (identify_source_line): Use open_source_file_with_line_charpos.
9335         (search_command_helper): Use open_source_file_with_line_charpos
9336         instead of just open_source_file, remove call to
9337         find_source_lines.
9338         * source.h (open_source_file_with_line_charpos): Declare new
9339         function.
9340         (find_source_lines): Delete declaration.
9341
9342 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9343
9344         * source.c (get_filename_and_charpos): Remove fullname
9345         parameter.
9346         (identify_source_line): Update call to get_filename_and_charpos.
9347
9348 2019-06-14  Tom Tromey  <tromey@adacore.com>
9349
9350         PR gdb/24502:
9351         * ui-style.h (skip_ansi_escape): Update comment.
9352         * ui-file.h (class no_terminal_escape_file): New class.
9353         * ui-file.c (no_terminal_escape_file::write)
9354         (no_terminal_escape_file::puts): New methods.
9355         * cli/cli-logging.c (handle_redirections): Use
9356         no_terminal_escape_file.
9357
9358 2019-06-14  Tom Tromey  <tromey@adacore.com>
9359
9360         * NEWS: Move convenience variable news above Python news.
9361
9362 2019-06-14  Tom Tromey  <tom@tromey.com>
9363
9364         * gnulib: Move directory to top-level.
9365         * configure.ac: Don't configure gnulib.
9366         * configure: Rebuild.
9367         * common/common-defs.h: Use new path to gnulib.
9368         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9369         (GNULIB_H): Remove.
9370         (INCGNU): Look in new gnulib location.
9371         (HFILES_NO_SRCDIR): Remove gnulib files.
9372         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9373         (generated_files): Remove GNULIB_H.
9374         ($(LIBGNU), all-lib): Remove targets.
9375         (distclean): Don't mention GNULIB_BUILDDIR.
9376         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9377
9378 2019-06-14  Tom Tromey  <tromey@adacore.com>
9379
9380         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9381         Warn if symbol file does not provide any symbols.
9382
9383 2019-06-14  Tom Tromey  <tromey@adacore.com>
9384
9385         * source.c (find_and_open_source): Respect basenames_may_differ.
9386
9387 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9388
9389         * annotate.c (annotate_breakpoints_invalid): Make use of
9390         scoped_restore_terminal_state.
9391         (annotate_frames_invalid): Likewise.
9392
9393 2019-06-14  Tom Tromey  <tromey@adacore.com>
9394
9395         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9396         allow assignment to an internalvar.
9397
9398 2019-06-14  Tom Tromey  <tromey@adacore.com>
9399
9400         * ada-lex.l: Allow "_" in attribute names.
9401
9402 2019-06-14  Tom Tromey  <tromey@adacore.com>
9403
9404         PR gdb/24653:
9405         * regcache.c (registers_changed): Don't call alloca.
9406         * top.c (execute_command): Don't call alloca.
9407
9408 2019-06-13  Pedro Alves  <palves@redhat.com>
9409
9410         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9411         'expression'.  When parsing an expression, error out if there's
9412         junk after "unlimited".
9413         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9414         (do_set_command): Adjust calls to is_unlimited_literal.
9415
9416 2019-06-13  Pedro Alves  <palves@redhat.com>
9417
9418         * compile/compile.c (make_compile_options_def_group): Add braces
9419         around array_view initializer.
9420         * thread.c (make_thread_apply_all_options_def_group)
9421         (make_thread_apply_all_options_def_group): Likewise.
9422
9423 2019-06-13  Pedro Alves  <palves@redhat.com>
9424
9425         * NEWS (New commands): Mention "maint test-options
9426         require-delimiter", "maint test-options unknown-is-error", "maint
9427         test-options unknown-is-operand" and "maint show
9428         test-options-completion-result".
9429         (New command options, command completion): New section.
9430         (Completion improvements): New section.
9431         Mention that you can abbreviate "unlimited".
9432
9433 2019-06-13  Pedro Alves  <palves@redhat.com>
9434
9435         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9436         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9437         * unittests/cli-utils-selftests.c (test_parse_flags)
9438         (test_parse_flags_qcs): Delete.
9439         (test_cli_utils): Don't call deleted functions.
9440
9441 2019-06-13  Pedro Alves  <palves@redhat.com>
9442
9443         * thread.c: Include "cli/cli-option.h".
9444         (tp_array_compar_ascending): Global.
9445         (tp_array_compar): Delete function.
9446         (tp_array_compar_ascending, tp_array_compar_descending): New
9447         functions.
9448         (ascending_option_def, qcs_flag_option_def)
9449         (thr_qcs_flags_option_defs)
9450         (make_thread_apply_all_options_def_group)
9451         (make_thread_apply_options_def_group): New.
9452         (thread_apply_all_command): Use gdb::option::process_options.
9453         (thread_apply_command_completer)
9454         (thread_apply_all_command_completer): New.
9455         (thread_apply_command): Use gdb::option::process_options.
9456         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9457         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9458         to generate help text of "thread apply".  Adjust "taas"'s help.
9459         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9460         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9461
9462 2019-06-13  Pedro Alves  <palves@redhat.com>
9463
9464         * thread.c (thread_apply_command): Check for invalid TID with
9465         isdigit instead of !isalpha.
9466
9467 2019-06-13  Pedro Alves  <palves@redhat.com>
9468
9469         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9470         (validate_flags_qcs): New.
9471         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9472         (validate_flags_qcs): Declare.
9473         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9474         (make_frame_apply_options_def_group): New.
9475         (frame_apply_command_count): Process options with
9476         gdb::option::process_options.
9477         (frame_apply_completer): New.
9478         (frame_apply_level_completer, frame_apply_all_completer)
9479         (frame_apply_completer): New.
9480         (_initialize_stack): Update help of "frame apply", "frame apply
9481         level", "frame apply all" and "faas" to mention supported options
9482         and install command completers.
9483         * stack.h (frame_apply_all_completer): Declare.
9484         * thread.c: Include "stack.h".
9485         (tfaas_command): Add "--".
9486         (_initialize_thread): Update help "tfaas" to mention supported
9487         options and install command completer.
9488
9489 2019-06-13  Pedro Alves  <palves@redhat.com>
9490
9491         * completer.c (complete_nested_command_line): New.
9492         (gdb_completion_word_break_characters_throw): Add assertion.
9493         * completer.h (complete_nested_command_line): Declare.
9494
9495 2019-06-13  Pedro Alves  <palves@redhat.com>
9496
9497         * stack.c (parse_backtrace_qualifiers): New.
9498         (backtrace_command): Use it.
9499         (backtrace_command_completer): Complete on qualifiers.
9500
9501 2019-06-13  Pedro Alves  <palves@redhat.com>
9502
9503         * frame.c: Include "cli/cli-option.h.
9504         (user_set_backtrace_options): New.
9505         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9506         Delete.
9507         (get_prev_frame): Adjust.
9508         (boolean_option_def, uinteger_option_def)
9509         (set_backtrace_option_defs): New.
9510         (_initialize_frame): Adjust and use
9511         gdb::option::add_setshow_cmds_for_options to install "set
9512         backtrace past-main" and "set backtrace past-entry".
9513         * frame.h: Include "cli/cli-option.h".
9514         (struct frame_print_options): Forward declare.
9515         (print_frame_arguments_all, print_frame_arguments_scalars)
9516         (print_frame_arguments_none): Declare.
9517         (print_entry_values): Delete declaration.
9518         (struct frame_print_options, user_frame_print_options): New.
9519         (struct set_backtrace_options): New.
9520         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9521         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9522         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9523         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9524         (list_args_or_locals): Add frame_print_options parameter.
9525         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9526         * python/py-framefilter.c (enumerate_args): Pass down
9527         USER_FRAME_PRINT_OPTIONS.
9528         * stack.c: Include "cli/cli-option.h".
9529         (print_frame_arguments_all, print_frame_arguments_scalars)
9530         (print_frame_arguments_none): Declare.
9531         (print_raw_frame_arguments, print_entry_values): Delete.
9532         (user_frame_print_options): New.
9533         (boolean_option_def, enum_option_def, frame_print_option_defs):
9534         New.
9535         (struct backtrace_cmd_options): New.
9536         (bt_flag_option_def): New.
9537         (backtrace_command_option_defs): New.
9538         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9539         (print_frame_arg, read_frame_arg, print_frame_args)
9540         (print_frame_info, print_frame): Add frame_print_options parameter
9541         and use it.
9542         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9543         (backtrace_command_1): Add frame_print_options and
9544         backtrace_cmd_options parameters and use them.
9545         (make_backtrace_options_def_group): New.
9546         (backtrace_command): Process command options with
9547         gdb::option::process_options.
9548         (backtrace_command_completer): New.
9549         (_initialize_stack): Extend "backtrace"'s help to mention
9550         supported options.  Install completer for "backtrace".
9551         Install some settings commands with add_setshow_cmds_for_options.
9552
9553 2019-06-13  Pedro Alves  <palves@redhat.com>
9554
9555         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9556         and that "set/show print raw frame-arguments" are now deprecated.
9557
9558         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9559         command.
9560         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9561         * stack.c (_initialize_stack): Install "set/show print
9562         raw-frame-arguments", and deprecate "set/show print raw
9563         frame-arguments".
9564         * valprint.c (_initialize_valprint): Deprecate "set/show print
9565         raw".
9566
9567 2019-06-13  Pedro Alves  <palves@redhat.com>
9568
9569         * compile/compile.c (struct compile_options): New.
9570         (compile_flag_option_def, compile_command_option_defs)
9571         (make_compile_options_def_group): New.
9572         (compile_file_command): Handle options with
9573         gdb::option::process_options.
9574         (compile_file_command_completer): New function.
9575         (compile_code_command): Handle options with
9576         gdb::option::process_options.
9577         (compile_code_command_completer): New function.
9578         (_initialize_compiler): Install completers for "compile code" and
9579         "compile file".  Mention available options in "compile code" and
9580         "compile code"'s help.
9581         * completer.c (advance_to_completion_word): New, factored out from
9582         ...
9583         (advance_to_expression_complete_word_point): ... this.
9584         (advance_to_filename_complete_word_point): New.
9585         * completer.h (advance_to_filename_complete_word_point): New
9586         declaration.
9587
9588 2019-06-13  Pedro Alves  <palves@redhat.com>
9589
9590         * compile/compile.c: Include "cli/cli-option.h".
9591         (compile_print_value): Scope data pointer is now a
9592         value_print_options pointer; adjust.
9593         (compile_print_command): Process options.  Scope data pointer is
9594         now a value_print_options pointer; adjust.
9595         (_initialize_compile): Update "compile print"'s help to include
9596         supported options.  Install a completer for "compile print".
9597         * cp-valprint.c (show_vtblprint, show_objectprint)
9598         (show_static_field_print): Delete.
9599         (_initialize_cp_valprint): Don't install "set print
9600         static-members", "set print vtbl", "set print object" here.
9601         * printcmd.c: Include "cli/cli-option.h" and
9602         "common/gdb_optional.h".
9603         (print_command_parse_format): Rework to fill in a
9604         value_print_options instead of a format_data.
9605         (print_value): Change parameter type from format_data pointer to
9606         value_print_options reference.  Adjust.
9607         (print_command_1): Process options.  Adjust to pass down a
9608         value_print_options.
9609         (print_command_completer): New.
9610         (_initialize_printcmd): Install print_command_completer as
9611         handle_brkchars completer for the "print" command.  Update
9612         "print"'s help to include supported options.
9613         * valprint.c: Include "cli/cli-option.h".
9614         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9615         here from cp-valprint.c.
9616         (boolean_option_def, uinteger_option_def)
9617         (value_print_option_defs, make_value_print_options_def_group):
9618         New.  Use gdb::option::add_setshow_cmds_for_options to install
9619         "set print elements", "set print null-stop", "set print repeats",
9620         "set print pretty", "set print union", "set print array", "set
9621         print address", "set print symbol", "set print array-indexes".
9622         * valprint.h: Include <string> and "cli/cli-option.h".
9623         (make_value_print_options_def_group): Declare.
9624         (print_value): Change parameter type from format_data pointer to
9625         value_print_options reference.
9626         (print_command_completer): Declare.
9627
9628 2019-06-13  Pedro Alves  <palves@redhat.com>
9629
9630         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9631         (COMMON_SFILES): Add maint-test-settings.c.
9632         * cli/cli-decode.c (boolean_enums): New global, factored out from
9633         ...
9634         (add_setshow_boolean_cmd): ... here.
9635         * cli/cli-decode.h (boolean_enums): Declare.
9636         * cli/cli-option.c: New file.
9637         * cli/cli-option.h: New file.
9638         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9639         factored out from ...
9640         (parse_cli_boolean_value(const char *)): ... this.
9641         (is_unlimited_literal): Change parameter type to pointer to
9642         pointer.  Adjust and advance ARG pointer.
9643         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9644         (parse_cli_var_enum): New, factored out from ...
9645         (do_set_command): ... this.  Adjust.
9646         * cli/cli-setshow.h (parse_cli_boolean_value)
9647         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9648         (parse_cli_var_enum): Declare.
9649         * cli/cli-utils.c: Include "cli/cli-option.h".
9650         (get_ulongest): New.
9651         * cli/cli-utils.h (get_ulongest): Declare.
9652         (check_for_argument): New overloads.
9653         * maint-test-options.c: New file.
9654
9655 2019-06-13  Pedro Alves  <palves@redhat.com>
9656
9657         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9658         parse a range if "-" is at the end of the string.
9659
9660 2019-06-13  Pedro Alves  <palves@redhat.com>
9661
9662         * cli/cli-setshow.c (parse_auto_binary_operation)
9663         (parse_cli_boolean_value): Don't allow "o".
9664
9665 2019-06-13  Pedro Alves  <palves@redhat.com>
9666
9667         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9668         * NEWS: Mention maint test-settings KIND.
9669         * maint-test-settings.c: New file.
9670
9671 2019-06-13  Pedro Alves  <palves@redhat.com>
9672
9673         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9674         completer.
9675         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9676         "set" completers.
9677
9678 2019-06-13  Pedro Alves  <palves@redhat.com>
9679
9680         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9681         after item.
9682
9683 2019-06-13  Pedro Alves  <palves@redhat.com>
9684
9685         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9686
9687 2019-06-13  Pedro Alves <palves@redhat.com>
9688
9689         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9690         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9691         call.
9692         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9693         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9694         calls.
9695         (check_for_argument): Skip spaces after argument.
9696
9697 2019-06-13  Pedro Alves  <palves@redhat.com>
9698
9699         * thread.c (thread_apply_command): Adjust TID parsing.
9700         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9701         detected before end of string.
9702         (tid_is_in_list): Error out if LIST is invalid.
9703
9704 2019-06-13  Pedro Alves  <palves@redhat.com>
9705
9706         * completer.c (complete_line_internal_1): Rewind completion word
9707         point.
9708         (completion_tracker::advance_custom_word_point_by): Change
9709         parameter type to int.
9710         * completer.h (completion_tracker::advance_custom_word_point_by):
9711         Likewise.
9712
9713 2019-06-13  Pedro Alves  <palves@redhat.com>
9714
9715         * completer.c (advance_to_completion_word): Handle delimiters.
9716
9717 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9718
9719         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9720
9721 2019-06-11  Tom Tromey  <tom@tromey.com>
9722
9723         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9724         (xmalloc_failed): Move to alloc.c.
9725         * alloc.c: New file.
9726         * Makefile.in (COMMON_SFILES): Add alloc.c.
9727
9728 2019-06-11  Tom Tromey  <tom@tromey.com>
9729
9730         * nat/linux-waitpid.c: Don't include server.h.
9731         (linux_debug): Remove.
9732         (my_waitpid): Update.
9733
9734 2019-06-11  Tom Tromey  <tromey@adacore.com>
9735
9736         * infcall.c (_initialize_infcall): Remove trailing newline from
9737         help.
9738         * user-regs.c (_initialize_user_regs): Remove trailing newline
9739         from help.
9740         * typeprint.c (_initialize_typeprint): Remove trailing newline
9741         from help.
9742         * reverse.c (_initialize_reverse): Remove trailing newlines from
9743         help.
9744         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9745         from help.
9746         * language.c (add_set_language_command): Remove trailing newline
9747         from help.
9748         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9749         help.
9750         * disasm.c (_initialize_disasm): Remove trailing newline from
9751         help.
9752         * top.c (init_main): Remove trailing newline from help.
9753         * interps.c (_initialize_interpreter): Remove trailing newline
9754         from help.
9755         * btrace.c (_initialize_btrace): Remove trailing newlines from
9756         help.
9757         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9758         from help.
9759         * python/python.c (_initialize_python): Remove trailing newline
9760         from help.
9761         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9762         help.
9763         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9764         from help.  Reformat some text.
9765         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9766         from help.
9767         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9768         newline from help.
9769
9770 2019-06-11  Tom Tromey  <tromey@adacore.com>
9771
9772         * darwin-nat.c (darwin_decode_exception_message)
9773         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9774
9775 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9776
9777         * valops.c (value_slice): Check for not allocated or not
9778         associated values.
9779
9780 2019-06-10  Tom de Vries  <tdevries@suse.de>
9781
9782         PR gdb/24618
9783         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9784         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9785         invalid.
9786
9787 2019-06-10  Tom de Vries  <tdevries@suse.de>
9788
9789         PR gdb/24611
9790         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9791         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9792
9793 2019-06-10  Tom de Vries  <tdevries@suse.de>
9794
9795         PR symtab/24545
9796         * symtab.c (struct demangled_name_entry): Add language field.
9797         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9798         static minimal symbol".  Set and use language field.
9799
9800 2019-06-10  Tom Tromey  <tromey@adacore.com>
9801
9802         * ada-lang.c (_initialize_ada_language): Update help text.
9803
9804 2019-06-10  Tom Tromey  <tromey@adacore.com>
9805
9806         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9807         with a newline.
9808         * guile/guile.c (handle_boot_error): Don't end warning with a
9809         newline.
9810         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9811         warning with a newline.
9812         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9813         newline.
9814         (s12z_frame_cache): Likewise.
9815         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9816         a newline.
9817         * solib-svr4.c (disable_probes_interface): Don't end warning with
9818         a newline.
9819         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9820         newline.
9821         * python/python.c (do_finish_initialization): Don't end warning
9822         with a newline.
9823
9824 2019-06-10  Tom Tromey  <tom@tromey.com>
9825
9826         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9827         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9828         gdbpy_enter.
9829
9830 2019-06-10  Tom Tromey  <tromey@adacore.com>
9831
9832         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9833         data.
9834         (elf_new_init): Don't call stabsread_new_init.
9835         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9836         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9837         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9838
9839 2019-06-10  Tom de Vries  <tdevries@suse.de>
9840
9841         PR symtab/16264
9842         PR symtab/24517
9843         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9844
9845 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9846
9847         * source.c (find_and_open_source): Also rewrite relative file
9848         names.
9849
9850 2019-04-26  Amos Bird  <amosbird@gmail.com>
9851
9852         * annotate.c (annotate_thread_exited): Add "thread-exited"
9853         annotation.
9854
9855 2019-06-06  Tom Tromey  <tromey@adacore.com>
9856
9857         * maint.h (class scoped_command_stats): Use
9858         DISABLE_COPY_AND_ASSIGN.
9859         <print_time>: New method.
9860         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9861         print_time.
9862         (scoped_command_stats::print_time): New method.
9863
9864 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9865
9866         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9867         instructions of lengths 6 or 8 bytes.
9868
9869 2019-06-04  Pedro Alves  <palves@redhat.com>
9870
9871         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9872
9873         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9874         * breakpoint.c (condition_completer): Likewise.
9875         * cli/cli-dump.c (scan_expression): Likewise.
9876         * common/filestuff.c (mkdir_recursive): Likewise.
9877         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9878         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9879         (gdb_abspath): Likewise.
9880         * compile/compile-cplus-types.c
9881         (compile_cplus_instance::decl_name): Likewise.
9882         * completer.c (complete_explicit_location):
9883         (signal_completer, reg_or_group_completer_1): Likewise.
9884         * cp-support.c (cp_remove_params_if_any): Likewise.
9885         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9886         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9887         * infcmd.c (strip_bg_char): Likewise.
9888         * linespec.c (copy_token_string): Likewise.
9889         * mi/mi-main.c (output_cores): Likewise.
9890         * psymtab.c (psymtab_search_name):
9891         * symfile.c (test_set_ext_lang_command): Likewise.
9892         * target.c (target_fileio_read_stralloc): Likewise.
9893         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9894         * value.c (complete_internalvar): Likewise.
9895
9896 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9897
9898         Add objfile property to gdb.Type.
9899         * NEWS: Mention Python API addition.
9900         * python/py-type.c (typy_get_objfile): New method.
9901
9902 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9903
9904         * NEWS: Mention the new set|show style [title|highlight].
9905         Mention changes to "show style", "help" and "apropos".
9906
9907 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9908
9909         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9910         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9911         instead of print_help_for_command.
9912         (print_doc_of_command): New function.
9913         (help_list): Add 'apropos -v word' suggestion.
9914         (print_help_for_command): Style the command name using title style.
9915         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9916         (_initialize_cli_cmds): Describe -v in apropos_command help.
9917
9918 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9919
9920         * cli/cli-style.h (cli_style_option): Add name in constructor,
9921         add m_name class member, add constructor with intensity,
9922         add name class function.
9923         (cli_style_option::add_setshow_commands): Remove name argument.
9924         (highlight_style, title_style): New styles.
9925         * cli/cli-style.c (do_show): New function that shows a style
9926         characteristic styling the style name with itself.
9927         (set_style_name): New function.
9928         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9929         Update all callers according to the changes in cli/cli-style.h.
9930         * utils.h (fputs_highlighted): New function.
9931         * utils.c (fputs_highlighted): Likewise.
9932
9933 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9934
9935         * NEWS: Mention new pipe command and new convenience variables.
9936
9937 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9938
9939         * cli/cli-cmds.c (pipe_command): New function.
9940         (_initialize_cli_cmds): Call add_com for pipe_command.
9941         Define | as an alias for pipe.
9942         (exit_status_set_internal_vars): New function.
9943         (shell_escape): Call exit_status_set_internal_vars.
9944         cli/cli-decode.c (find_command_name_length): Recognize | as
9945         a single character command.
9946
9947 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9948
9949         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9950         top.c (execute_command_to_ui_file): New function, mostly a copy
9951         of execute_command_to_string.
9952         (execute_command_to_string): Implement by calling
9953         execute_command_to_ui_file.
9954
9955 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9956
9957         * top.h (saved_command_line): Remove declaration.
9958         * top.c (previous_saved_command_line, previous_repeat_arguments):
9959         New variables.
9960         (saved_command_line): Make static, define together with other
9961         'repeat variables'.
9962         (dont_repeat): Clear repeat_arguments.
9963         (repeat_previous, get_saved_command_line, save_command_line):
9964         New functions.
9965         (gdb_init): Initialize saved_command_line
9966         and previous_saved_command_line.
9967         * main.c (captured_main_1): Remove saved_command_line initialization.
9968         * event-top.c (handle_line_of_input): Update to use
9969         the new 'repeat' related functions instead of direct access to
9970         saved_command_line.
9971         * command.h (repeat_previous, get_saved_command_line,
9972         save_command_line): New declarations.
9973         (dont_repeat): Add comment.
9974
9975 2019-05-30  Tom Tromey  <tromey@adacore.com>
9976
9977         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9978         Fix comment.
9979         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9980
9981 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9982
9983         PR cli/24587
9984         * completer.c (complete): Initialize variable word.
9985
9986 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9987
9988         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9989         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9990         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9991         'body' is NULL to the outter 'if', protecting the '!is_define'
9992         situation as well.
9993
9994 2019-05-29  Tom Tromey  <tromey@adacore.com>
9995
9996         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9997         (dwarf_unknown): New function.
9998         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9999         (dwarf_type_encoding_name): Use dwarf_unknown.
10000
10001 2019-05-29  Tom Tromey  <tromey@adacore.com>
10002
10003         PR c++/20020:
10004         * cp-valprint.c (cp_print_value_fields): Call
10005         cp_print_static_field inside "try".
10006
10007 2019-05-29  Tom Tromey  <tromey@adacore.com>
10008
10009         * inflow.c (struct terminal_info): Add default operator=.
10010         * configure: Rebuild.
10011         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10012         -Wdeprecated-copy-dtor, -Wredundant-move.
10013
10014 2019-05-29  Tom Tromey  <tromey@adacore.com>
10015
10016         * NEWS: Add entry.
10017         * infcmd.c (print_return_value_1): Handle finish_print
10018         option.
10019         (show_print_finish): New function.
10020         (_initialize_infcmd): Add "set/show print finish" commands.
10021         * valprint.c (user_print_options): Initialize new member.
10022         * valprint.h (struct value_print_options) <finish_print>: New
10023         member.
10024
10025 2019-05-28  Tom Tromey  <tromey@adacore.com>
10026
10027         * ada-lang.c (ada_remove_Xbn_suffix)
10028         (find_old_style_renaming_symbol)
10029         (parse_old_style_renaming): Remove.
10030         (ada_find_renaming_symbol): Don't call
10031         find_old_style_renaming_symbol.
10032         (ada_is_renaming_symbol): Rename from
10033         ada_find_renaming_symbol.  Remove "block" parameter.  Return
10034         bool.  Now static.
10035         (ada_read_var_value): Update and simplify.
10036         * ada-exp.y (write_var_or_type): Remove old code.
10037
10038 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
10039
10040         PR gdb/25010
10041         * event-top.c: Remove include comment.
10042         * inflow.c (class scoped_ignore_sigttou): Move from here...
10043         * inflow.h (class scoped_ignore_sigttou): ...to here.
10044         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10045         * top.c:  Remove include comment.
10046
10047 2019-05-27  Tom Tromey  <tom@tromey.com>
10048
10049         * NEWS: Fix typo.
10050
10051 2019-05-22  Tom Tromey  <tromey@adacore.com>
10052
10053         * target.c (target_follow_exec): Constify parameter.
10054         * target-delegates.c: Rebuild.
10055         * remote.c (remote_target::follow_exec): Constify parameter.
10056         * infrun.c (follow_exec): Constify parameter.
10057         * target.h (struct target_ops) <follow_exec>: Constify parameter.
10058         (target_follow_exec): Likewise.
10059
10060 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10061
10062         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10063         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10064
10065 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10066
10067         * NEWS: Add debugredirect and testsuite sections.
10068
10069 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
10070
10071         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10072         target descriptions using exclusively floating point register name
10073         aliases.
10074
10075 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10076
10077         PR gdb/18644:
10078         * f-lang.c (build_fortran_types): Handle the case where
10079         gdbarch_floatformat_for_type returns a nullptr.
10080
10081 2019-05-21  Tom de Vries  <tdevries@suse.de>
10082
10083         PR cli/24587
10084         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10085
10086 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10087
10088         PR gdb/18644:
10089         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10090         16-byte floats.
10091         * i386-tdep.c (i386_floatformat_for_type): Use
10092         floatformats_ia64_quad for the 16-byte floating point component
10093         within a fortran 32-byte complex number.
10094
10095 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10096
10097         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10098         delete default constructor.
10099         (find_partial_die): Update to return const struct.
10100         (partial_die_parent_scope): Move variable declaration into scope
10101         of its use and change its type to auto.
10102         (guess_partial_die_structure_name): Likewise.
10103         (partial_die_info::fixup): Likewise.
10104
10105 2019-05-17  Tom Tromey  <tromey@adacore.com>
10106
10107         * source.c (find_and_open_source): Remove cast.
10108
10109 2019-05-17  Tom Tromey  <tromey@adacore.com>
10110
10111         * annotate.c (annotate_source): Make "filename" const.
10112         * annotate.h (annotate_source): Use const.
10113
10114 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10115
10116         * disasm.c (set_disassembler_options): Send errors to stderr.
10117
10118 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10119
10120         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10121         (cli_interp_base::set_logging): Check debug_redirect.
10122         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10123         * cli/cli-logging.c (debug_redirect): Add static variable.
10124         (pop_output_files): Add default param.
10125         (handle_redirections): Print debug setting.
10126         (show_logging_command): Likewise.
10127         (_initialize_cli_logging): Add debugredirect command.
10128         * interps.c (current_interp_set_logging): Add debug_redirect
10129         parameter.
10130         * interps.h (set_logging): Add debug_redirect parameter.
10131         (current_interp_set_logging): Likewise.
10132         * mi/mi-common.h: Likewise.
10133         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10134
10135 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10136             Tom Tromey  <tromey@adacore.com>
10137
10138         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10139         directly.
10140         * cli/cli-interp.h (make_logging_output): Remove declaration.
10141         * cli/cli-logging.c (make_logging_output): Remove function.
10142         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10143         directly.
10144         * ui-file.c (tee_file::tee_file): Remove bools.
10145         (tee_file::~tee_file): Remove deletes.
10146         * ui-file.h (tee_file): Remove bools.
10147
10148 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10149
10150         * mi/mi-cmds.h (mi_cmd_complete): New function.
10151         * mi/mi-main.c (mi_cmd_complete): Likewise.
10152         * mi/mi-cmds.c: Define new MI command -complete.
10153         * NEWS: Mention new -complete command.
10154
10155 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10156
10157         * completer.h (complete): New function.
10158         * completer.c (complete): Likewise.
10159         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10160         function defined in completer.h.
10161
10162 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10163
10164         * MAINTAINERS (Write After Approval): Add myself.
10165
10166 2019-05-17  Tom de Vries  <tdevries@suse.de>
10167
10168         PR gdb/24094
10169         * dwarf2read.c (struct cu_partial_die_info): New struct.
10170         (find_partial_die): Return cu_partial_die_info.
10171         (partial_die_parent_scope, guess_partial_die_structure_name)
10172         (partial_die_info::fixup): Handle new return type of find_partial_die.
10173
10174 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10175
10176         PR breakpoints/24541
10177         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10178         "std::string", simplifying the algorithm.
10179
10180 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10181
10182         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10183         (stap_static_probe_ops::get_probes): Likewise.
10184
10185 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10186
10187         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10188         '-')" and "else if".
10189         (stap_parse_single_operand): Join checks for
10190         "gdbarch_stap_parse_special_token_p" and
10191         "gdbarch_stap_parse_special_token" in the same "if" statement.
10192         Invert check when verifying for operation on register
10193         displacement.
10194
10195 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10196
10197         * stap-probe.c (stap_get_opcode): Update comment.
10198         (stap_get_expected_argument_type): Likewise.
10199         (handle_stap_probe): Likewise.
10200
10201 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10202
10203         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10204         return type to 'bool'.  Adjust comment.  Use 'bool' when
10205         appropriate.
10206         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10207         * stap-probe.c (stap_parse_argument_1): Likewise.
10208         (stap_is_operator): Likewise.
10209         (stap_is_generic_prefix): Likewise.
10210         (stap_is_register_prefix): Likewise.
10211         (stap_is_register_indirection_prefix): Likewise.
10212         (stap_is_integer_prefix): Likewise.
10213         (stap_generic_check_suffix): Likewise.
10214         (stap_check_integer_suffix): Likewise.
10215         (stap_check_register_suffix): Likewise.
10216         (stap_check_register_indirection_suffix): Likewise.
10217         (stap_parse_register_operand): Likewise.
10218         (stap_parse_single_operand): Likewise.
10219         (stap_parse_argument_1): Likewise.
10220         (stap_probe::get_argument_count): Likewise.
10221         (stap_is_operator): Likewise.
10222
10223 2019-05-16  Tom Tromey  <tromey@adacore.com>
10224
10225         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10226         keyword to foreach.
10227
10228 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10229
10230         * linux-thread-db.c (try_thread_db_load_1): Change return type
10231         to bool.
10232         (try_thread_db_load): Likewise.
10233         (try_thread_db_load_from_pdir_1): Likewise.
10234         (try_thread_db_load_from_pdir): Likewise.
10235         (try_thread_db_load_from_sdir): Likewise.
10236         (try_thread_db_load_from_dir): Likewise.
10237         (thread_db_load_search): Likewise.
10238         (has_libpthread): Likewise.
10239         (thread_db_load): Likewise.
10240
10241 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10242
10243         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10244         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10245         NULL, and complain/return if that's the case.
10246
10247 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10248
10249         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10250         (advance, posn, abstract_read_memory): New functions.
10251         [struct mem_read_abstraction]: New struct.
10252         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10253
10254 2019-05-14  Tom Tromey  <tromey@adacore.com>
10255
10256         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10257         value is not lval_memory.
10258
10259 2019-05-14  Tom Tromey  <tromey@adacore.com>
10260
10261         * solib.c (info_sharedlibrary_command): Style the file name.
10262
10263 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10264
10265         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10266         (aarch64_vnv_type): Likewise.
10267         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10268         * common/tdesc.c: Likewise.
10269         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10270         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10271         * features/aarch64-fpu.xml: Add ieee half view.
10272         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10273         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10274         * gdbtypes.h (struct builtin_type): Likewise.
10275         (struct objfile_type): Likewise.
10276
10277 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10278
10279         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10280         typo.
10281         * location.h (string_to_event_location): Likewise.
10282
10283 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10284
10285         GDB 8.3 released.
10286
10287 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10288
10289         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10290         New variable declaration.
10291         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10292         New variable.
10293         (print_one_breakpoint): Use ui_out::test_flags and new global
10294         variable to compute use_fixed_output.
10295         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10296         Remove.
10297         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10298         (mi_multi_location_breakpoint_output_fixed): Remove.
10299         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10300         new variable.
10301         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10302         fix_multi_location_breakpoint_output flag if version >= 3.
10303         * ui-out.h (enum ui_out_flag)
10304         <fix_multi_location_breakpoint_output>: New enumerator.
10305
10306 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10307
10308         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10309
10310 2019-05-10  Tom Tromey  <tromey@adacore.com>
10311
10312         * ada-lang.c (catch_ada_completer): New function.
10313         (_initialize_ada_language): Use it.
10314
10315 2019-05-10  Tom Tromey  <tromey@adacore.com>
10316
10317         * thread.c (print_thread_info): Make "requested_threads" const.
10318         * gdbthread.h (print_thread_info): Make "requested_threads"
10319         const.
10320         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10321         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10322
10323 2019-05-08  Tom Tromey  <tom@tromey.com>
10324
10325         * gdbtypes.c (objfile_type_data): Change type.
10326         (objfile_type, _initialize_gdbtypes): Update.
10327
10328 2019-05-08  Tom Tromey  <tom@tromey.com>
10329
10330         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10331         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10332         (_initialize_dwarf2_frame): Update.
10333
10334 2019-05-08  Tom Tromey  <tom@tromey.com>
10335
10336         * objc-lang.c (objc_objfile_data): Change type.
10337         (find_methods): Update.
10338         (_initialize_objc_lang): Remove.
10339
10340 2019-05-08  Tom Tromey  <tom@tromey.com>
10341
10342         * stabsread.c (rs6000_builtin_type_data): Change type.
10343         (rs6000_builtin_type, _initialize_stabsread): Update.
10344
10345 2019-05-08  Tom Tromey  <tom@tromey.com>
10346
10347         * mips-tdep.c (mips_pdr_data): Remove.
10348         (_initialize_mips_tdep): Update.
10349
10350 2019-05-08  Tom Tromey  <tom@tromey.com>
10351
10352         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10353         (hppa_init_objfile_priv_data, read_unwind_info)
10354         (find_unwind_entry, _initialize_hppa_tdep): Update.
10355
10356 2019-05-08  Tom Tromey  <tom@tromey.com>
10357
10358         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10359         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10360         on obstack.
10361         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10362
10363 2019-05-08  Tom Tromey  <tom@tromey.com>
10364
10365         * mdebugread.c (basic_type_data): Change type.
10366         (basic_type, _initialize_mdebugread): Update.
10367
10368 2019-05-08  Tom Tromey  <tom@tromey.com>
10369
10370         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10371
10372 2019-05-08  Tom Tromey  <tom@tromey.com>
10373
10374         * nto-tdep.c (nto_inferior_data_reg): Change type.
10375         (nto_inferior_data): Update.
10376         (nto_inferior_data_cleanup, nto_new_inferior_data)
10377         (_initialize_nto_tdep): Remove.
10378         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10379
10380 2019-05-08  Tom Tromey  <tom@tromey.com>
10381
10382         * ada-lang.c (struct ada_inferior_data): Add initializers.
10383         (ada_inferior_data): Change type.
10384         (ada_inferior_data_cleanup): Remove.
10385         (get_ada_inferior_data, ada_inferior_exit)
10386         (struct ada_pspace_data): Add initializers, destructor.
10387         (ada_pspace_data_handle): Change type.
10388         (get_ada_pspace_data): Update.
10389         (ada_pspace_data_cleanup): Remove.
10390
10391 2019-05-08  Tom Tromey  <tom@tromey.com>
10392
10393         * coffread.c (struct coff_symfile_info): Add initializers.
10394         (coff_objfile_data_key): Move lower.  Change type.
10395         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10396         Update.
10397         (coff_free_info): Remove.
10398
10399 2019-05-08  Tom Tromey  <tom@tromey.com>
10400
10401         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10402         (fbsd_pspace_data_handle): Move lower.  Change type.
10403         (get_fbsd_pspace_data): Update.
10404         (fbsd_pspace_data_cleanup): Remove.
10405         (_initialize_fbsd_tdep): Update.
10406
10407 2019-05-08  Tom Tromey  <tom@tromey.com>
10408
10409         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10410         (get_ada_tasks_pspace_data): Update.
10411         (ada_tasks_pspace_data_cleanup): Remove.
10412         (_initialize_tasks): Update.
10413         (ada_tasks_inferior_data_handle): Change type.
10414         (get_ada_tasks_inferior_data): Update.
10415         (ada_tasks_inferior_data_cleanup): Remove.
10416         (struct ada_tasks_pspace_data): Add initializers.
10417
10418 2019-05-08  Tom Tromey  <tom@tromey.com>
10419
10420         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10421         * symfile-debug.c (debug_sym_get_probes): Change type.
10422         * stap-probe.c (handle_stap_probe):
10423         (stap_static_probe_ops::get_probes): Change type.
10424         * probe.h (class static_probe_ops) <get_probes>: Change type.
10425         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10426         (parse_probes_in_pspace): Update.
10427         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10428         Update.
10429         (any_static_probe_ops::get_probes): Change type.
10430         * elfread.c (elfread_data): New typedef.
10431         (probe_key): Change type.
10432         (elf_get_probes): Likewise.  Update.
10433         (probe_key_free): Remove.
10434         (_initialize_elfread): Update.
10435         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10436         Change type.
10437         (dtrace_process_dof_probe, dtrace_process_dof)
10438         (dtrace_static_probe_ops::get_probe): Change type.
10439
10440 2019-05-08  Tom Tromey  <tom@tromey.com>
10441
10442         * xcoffread.c (struct xcoff_symfile_info): Rename from
10443         coff_symfile_info.  Add initializers.
10444         (xcoff_objfile_data_key): Move lower.  Change type.
10445         (XCOFF_DATA): Rewrite.
10446         (xcoff_free_info): Remove.
10447         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10448         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10449         (xcoff_initial_scan): Update.
10450
10451 2019-05-08  Tom Tromey  <tom@tromey.com>
10452
10453         * solib-svr4.c (struct svr4_info): Add initializers and
10454         destructor.
10455         <probes_table>: Now an htab_up.
10456         (solib_svr4_pspace_data): Change type.
10457         (free_probes_table): Simplify.
10458         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10459         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10460         (probes_table_remove_objfile_probes, register_solib_event_probe)
10461         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10462         (_initialize_svr4_solib): Update.
10463
10464 2019-05-08  Tom Tromey  <tom@tromey.com>
10465
10466         * remote.c (remote_pspace_data): Change type.
10467         (remote_pspace_data_cleanup): Remove.
10468         (get_remote_exec_file, set_pspace_remote_exec_file)
10469         (_initialize_remote): Update.
10470
10471 2019-05-08  Tom Tromey  <tom@tromey.com>
10472
10473         * breakpoint.c (breakpoint_objfile_key): Change type.
10474         (get_breakpoint_objfile_data): Update.
10475         (free_breakpoint_objfile_data): Remove.
10476         (_initialize_breakpoint): Update.
10477
10478 2019-05-08  Tom Tromey  <tom@tromey.com>
10479
10480         * linux-tdep.c (struct linux_info): Add initializers.
10481         (linux_inferior_data): Move.  Change type.
10482         (invalidate_linux_cache_inf): Update.
10483         (linux_inferior_data_cleanup): Remove.
10484         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10485
10486 2019-05-08  Tom Tromey  <tom@tromey.com>
10487
10488         * auxv.c (auxv_inferior_data): Move.  Change type.
10489         (auxv_inferior_data_cleanup): Remove.
10490         (invalidate_auxv_cache_inf): Rewrite.
10491         (get_auxv_inferior_data, _initialize_auxv): Update.
10492
10493 2019-05-08  Tom Tromey  <tom@tromey.com>
10494
10495         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10496         (symfile_debug_objfile_data_key): Change type.
10497         (symfile_debug_installed, debug_qf_has_symbols)
10498         (debug_qf_find_last_source_symtab)
10499         (debug_qf_forget_cached_source_info)
10500         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10501         (debug_qf_print_stats, debug_qf_dump)
10502         (debug_qf_expand_symtabs_for_function)
10503         (debug_qf_expand_all_symtabs)
10504         (debug_qf_expand_symtabs_with_fullname)
10505         (debug_qf_map_matching_symbols)
10506         (debug_qf_expand_symtabs_matching)
10507         (debug_qf_find_pc_sect_compunit_symtab)
10508         (debug_qf_map_symbol_filenames)
10509         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10510         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10511         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10512         (debug_sym_read_linetable, debug_sym_relocate): Update.
10513         (symfile_debug_free_objfile): Remove.
10514         (install_symfile_debug_logging, _initialize_symfile_debug):
10515         Update.
10516
10517 2019-05-08  Tom Tromey  <tom@tromey.com>
10518
10519         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10520         allocate_on_obstack.
10521         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10522         (get_dwarf2_per_objfile): Update.
10523         (set_dwarf2_per_objfile): Remove.
10524         (dwarf2_has_info, dwarf2_get_section_info): Update.
10525         (dwarf2_free_objfile): Remove.
10526         (_initialize_dwarf2_read): Update.
10527
10528 2019-05-08  Tom Tromey  <tom@tromey.com>
10529
10530         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10531         initializers.
10532         <unsupported_script_warning_printed,
10533         script_not_found_warning_printed>: Now bool.
10534         (auto_load_pspace_data): Change type.
10535         (~auto_load_pspace_info): Rename from
10536         auto_load_pspace_data_cleanup.
10537         (get_auto_load_pspace_data, init_loaded_scripts_info)
10538         (clear_section_scripts, maybe_print_unsupported_script_warning)
10539         (maybe_print_script_not_found_warning, _initialize_auto_load):
10540         Update.
10541
10542 2019-05-08  Tom Tromey  <tom@tromey.com>
10543
10544         * objfiles.c (objfile_pspace_info): Add destructor and
10545         initializers.
10546         (objfiles_pspace_data): Change type.
10547         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10548         (get_objfile_pspace_data): Update.
10549         (objfiles_bfd_data): Change type.
10550         (get_objfile_bfd_data): Update.
10551         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10552
10553 2019-05-08  Tom Tromey  <tom@tromey.com>
10554
10555         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10556         Change type.
10557         (get_catch_syscall_inferior_data): Update.
10558         (catch_syscall_inferior_data_cleanup): Remove.
10559         (_initialize_break_catch_syscall): Update.
10560
10561 2019-05-08  Tom Tromey  <tom@tromey.com>
10562
10563         * inflow.c (struct terminal_info): Add destructor and
10564         initializers.
10565         (inflow_inferior_data): Change type.
10566         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10567         (get_inflow_inferior_data, inflow_inferior_exit)
10568         (swap_terminal_info, _initialize_inflow): Update.
10569
10570 2019-05-08  Tom Tromey  <tom@tromey.com>
10571
10572         * target-dcache.c (target_dcache_cleanup): Remove.
10573         (target_dcache_aspace_key): Change type.
10574         (target_dcache_init_p, target_dcache_invalidate)
10575         (target_dcache_get, target_dcache_get_or_init)
10576         (_initialize_target_dcache): Update.
10577         * dcache.h (struct dcache_deleter): New.
10578
10579 2019-05-08  Tom Tromey  <tom@tromey.com>
10580
10581         * symtab.c (struct symbol_cache): Add destructor and
10582         initializers.
10583         (symbol_cache_key): Move.  Change type.
10584         (make_symbol_cache, free_symbol_cache): Remove.
10585         (get_symbol_cache): Update.
10586         (symbol_cache_cleanup): Remove.
10587         (ALL_PSPACES, symbol_cache_flush)
10588         (maintenance_print_symbol_cache)
10589         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10590         Update.
10591
10592 2019-05-08  Tom Tromey  <tom@tromey.com>
10593
10594         * symtab.c (struct main_info): Add destructor and initializers.
10595         (main_progspace_key): Move.  Change type.
10596         (get_main_info): Update.
10597         (main_info_cleanup): Remove.
10598         (_initialize_symtab): Update.
10599
10600 2019-05-08  Tom Tromey  <tom@tromey.com>
10601
10602         * registry.h (DECLARE_REGISTRY): Define the _key class.
10603
10604 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10605
10606         * NEWS: Merge two 'New commands' sections.
10607
10608 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10609
10610         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10611         parameter and use Ada language definition instead.
10612         (ada_val_print_ptr): Remove unused language parameter.
10613         (ada_val_print_num): Remove language parameter and use Ada language
10614         definition instead.
10615         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10616         parameter.
10617         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10618         parameter and use Ada language definition instead.
10619         (ada_val_print_1): Update all ada_val_print_xxx calls.
10620         Remove language parameter.
10621         (ada_val_print): Update ada_val_print_1 call.
10622
10623 2019-05-08  Tom Tromey  <tromey@adacore.com>
10624
10625         * remote.c (remote_hw_watchpoint_limit)
10626         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10627         Now static.
10628
10629 2019-05-08  Tom Tromey  <tromey@adacore.com>
10630
10631         * maint.c (_initialize_maint_cmds): Move initialization code to
10632         remote.c.
10633         (watchdog, show_watchdog): Move to remote.c.
10634         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10635         "watchdog" static.
10636         (_initialize_remote): Move initialization code from maint.c.
10637         * defs.h (watchdog): Don't declare.
10638
10639 2019-05-08  Tom Tromey  <tromey@adacore.com>
10640
10641         * tui/tui-interp.c: Include main.h.
10642         * interps.c: Include main.h.
10643         * main.h (interpreter_p): Declare.
10644         * defs.h (interpreter_p): Don't declare.
10645
10646 2019-05-08  Tom Tromey  <tromey@adacore.com>
10647
10648         * dwarf2loc.c: Include dwarf2read.h.
10649         * defs.h (read_unsigned_leb128): Don't declare.
10650         * dwarf2read.h (read_unsigned_leb128): Declare.
10651
10652 2019-05-08  Tom Tromey  <tromey@adacore.com>
10653
10654         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10655         method.
10656
10657 2019-05-08  Tom Tromey  <tromey@adacore.com>
10658
10659         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10660         when no wrap column is set.
10661
10662 2019-05-08  Tom Tromey  <tromey@adacore.com>
10663
10664         * c-lang.c (c_get_string): Handle non-C-style arrays.
10665
10666 2019-05-08  Tom Tromey  <tromey@adacore.com>
10667
10668         * typeprint.c (print_offset_data::update): Print the bit offset,
10669         not the number of bits remaining.
10670
10671 2019-05-08  Tom Tromey  <tromey@adacore.com>
10672
10673         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10674         padding at end of comment.
10675
10676 2019-05-08  Tom Tromey  <tromey@adacore.com>
10677
10678         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10679         Compare main types.
10680
10681 2019-05-06  Tom Tromey  <tom@tromey.com>
10682
10683         * common/scoped_mmap.c: Include common-defs.h.
10684         * common/scoped_mmap.h: Don't include config.h.
10685
10686 2019-05-04  Tom Tromey  <tom@tromey.com>
10687
10688         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10689         (struct aarch64_call_info): Add initializers.
10690         <si>: Now a std::vector.
10691         (pass_on_stack, aarch64_push_dummy_call): Update.
10692
10693 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10694             Tom Tromey  <tom@tromey.com>
10695
10696         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10697         (ppc_threads): Now a std::vector.  Now static.
10698         (hwdebug_find_thread_points_by_tid)
10699         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10700         Update.
10701
10702 2019-05-04  Tom Tromey  <tom@tromey.com>
10703
10704         * arc-tdep.c (arc_tdesc_init): Return bool.
10705
10706 2019-05-04  Tom Tromey  <tom@tromey.com>
10707
10708         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10709         Use gdb_assert_not_reached.
10710
10711 2019-05-04  Tom Tromey  <tom@tromey.com>
10712
10713         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10714         "false".
10715
10716 2019-05-04  Tom Tromey  <tom@tromey.com>
10717
10718         * arc-tdep.c (arc_tdesc_init): Use bool.
10719
10720 2019-05-04  Tom Tromey  <tom@tromey.com>
10721
10722         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10723
10724 2019-05-04  Tom Tromey  <tom@tromey.com>
10725
10726         * cli/cli-cmds.c (valid_command_p): Return bool.
10727
10728 2019-05-04  Tom Tromey  <tom@tromey.com>
10729
10730         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10731         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10732
10733 2019-05-04  Raul Tambre  <raul@tambre.ee>
10734
10735         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10736         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10737         operator for comparison.
10738
10739 2019-05-04  Tom Tromey  <tom@tromey.com>
10740
10741         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10742         (lookup_partial_symbol, print_partial_symbols)
10743         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10744         (psymbol_compare): Update.
10745         (add_psymbol_to_bcache): Clear the entire psymbol.
10746         (maintenance_check_psymtabs): Update.
10747         * psympriv.h (struct partial_symbol): Don't derive from
10748         general_symbol_info.
10749         <obj_section, unrelocated_address, address,
10750         set_unrelocated_address>: Update.
10751         <ginfo>: New member.
10752         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10753         (debug_names::write_psymbols): Update.
10754
10755 2019-05-04  Tom de Vries  <tdevries@suse.de>
10756
10757         * contrib/cc-with-tweaks.sh: Support -n arg.
10758
10759 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10760
10761         * corelow.c (core_target::detach): Ensure frame cache and
10762         register caches are cleared.
10763         inferior.c (exit_inferior_1): Likewise.
10764
10765 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10766             Tom Tromey  <tom@tromey.com>
10767
10768         * dictionary.c (collate_pending_symbols_by_language): Remove
10769         "struct" from foreach.
10770         * symtab.c (lookup_global_symbol_from_objfile)
10771         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10772         foreach.
10773         * ser-tcp.c (net_open): Remove "struct" from foreach.
10774         * objfiles.c (objfile_relocate, objfile_rebase)
10775         (objfile_has_symbols): Remove "struct" from foreach.
10776         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10777         from foreach.
10778         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10779         foreach.
10780         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10781         "struct" from foreach.
10782         * ada-lang.c (create_excep_cond_exprs)
10783         (ada_exception_catchpoint_cond_string): Remove "struct" from
10784         foreach.
10785
10786 2019-05-03  Tom Tromey  <tromey@adacore.com>
10787
10788         * ada-exp.y (convert_char_literal): Check suffix of each
10789         enumerator.
10790
10791 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10792
10793         PR ada/21406:
10794         * ada-exp.y (yywrap): Don't define.
10795         * ada-lex.l (%option): Add noyywrap
10796         (yywrap): Remove.
10797
10798 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10799
10800         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10801         _WIN32_WINNT to the XP level, unless already defined to a higher
10802         level.
10803
10804         * unittests/parse-connection-spec-selftests.c:
10805         * ser-tcp.c:
10806         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10807         override.
10808
10809         * symfile.c (find_separate_debug_file): Remove colon from the
10810         drive spec of DOS/Windows file names of the target, so that the
10811         file name produced from DEBUGDIR and the target's directory will
10812         be valid on DOS/Windows systems.
10813
10814 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10815
10816         * rust-lang.c (val_print_struct): Handle printing structures
10817         containing strings.
10818
10819 2019-05-02  Tom Tromey  <tromey@adacore.com>
10820
10821         * valarith.c (_initialize_valarith): Remove.
10822
10823 2019-05-01  Tom Tromey  <tromey@adacore.com>
10824
10825         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10826         bitfields.
10827
10828 2019-05-01  Tom Tromey  <tromey@adacore.com>
10829
10830         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10831         for big-endian copies.
10832
10833 2019-04-30  Ali Tamur  <tamur@google.com>
10834         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10835         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10836         (read_3_bytes): New function.
10837
10838 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10839
10840         * windows-nat.c (main_thread_id): Delete.
10841         (handle_output_debug_string): Replace main_thread_id by
10842         current_event.dwThreadId.
10843         (fake_create_process): Likewise.
10844         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10845         Do not set main_thread_id.
10846         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10847         current_event.dwThreadId.
10848         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10849
10850 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10851
10852         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10853         Use current_event.dwThreadId instead of main_thread_id.
10854
10855 2019-04-30  Tom Tromey  <tromey@adacore.com>
10856
10857         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10858         (create_excep_cond_exprs): Iterate over program spaces.
10859         (ada_exception_catchpoint_cond_string): Examine all minimal
10860         symbols for exception types.
10861
10862 2019-04-30  Tom Tromey  <tromey@adacore.com>
10863
10864         PR c++/24470:
10865         * dwarf2read.c (process_structure_scope): Handle case where type
10866         has template parameters but no symbol was created.
10867
10868 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10869             Chris January  <chris.january@arm.com>
10870
10871         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10872         qualifier.
10873         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10874
10875 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10876
10877         * f-typeprint.c (f_print_type): Update rules for printing
10878         whitespace.
10879         (f_type_print_varspec_suffix): Likewise.
10880
10881 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10882             Chris January  <chris.january@arm.com>
10883
10884         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10885         function arguments.
10886
10887 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10888
10889         * f-lang.c (build_fortran_types): Change name of void type to
10890         lower case.
10891         * f-typeprint.c (f_type_print_base): Print the name of the void
10892         type, rather than a fixed string.
10893         * f-valprint.c (f_decorations): Use lower case void string.
10894
10895 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10896             Chris January  <chris.january@arm.com>
10897
10898         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10899         types for Fortran.
10900
10901 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10902             Chris January  <chris.january@arm.com>
10903             David Lecomber  <david.lecomber@arm.com>
10904
10905         * f-exp.y (BINOP_INTRINSIC): New token.
10906         (exp): New parser rule handling BINOP_INTRINSIC.
10907         (f77_keywords): Add new builtin procedures.
10908         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10909         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10910         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10911         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10912         (print_unop_subexp_f): New function.
10913         (print_binop_subexp_f): New function.
10914         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10915         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10916         (dump_subexp_body_f): Likewise.
10917         (operator_check_f): Likewise.
10918         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10919         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10920
10921 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10922
10923         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10924         UNOP_KIND.
10925         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10926         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10927         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10928         (operator_length_f): New fuction.
10929         (print_subexp_f): New function.
10930         (op_name_f): New function.
10931         (dump_subexp_body_f): New function.
10932         (operator_check_f): New function.
10933         (exp_descriptor_f): Replace standard expression handling functions
10934         with new functions.
10935         * gdb/fortran-operator.def: New file.
10936         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10937         * gdb/std-operator.def: Remove UNOP_KIND.
10938
10939 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10940
10941         * std-operator.def: Remove unbalanced, stray double quote
10942         character.
10943
10944 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10945             Chris January  <chris.january@arm.com>
10946             Daniel Everett  <daniel.everett@arm.com>
10947             Nick Forrington  <nick.forrington@arm.com>
10948             Richard Bunt  <richard.bunt@arm.com>
10949
10950         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10951         of depth when printing anonymous structs or unions.
10952         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10953         Don't print either the top-level value, or the children if the
10954         max-depth is exceeded.
10955         (ppscm_print_children): When printing the key of a map, allow one
10956         extra level of depth.
10957         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10958         print either the top-level value, or the children if the max-depth
10959         is exceeded.
10960         (print_children): When printing the key of a map, allow one extra
10961         level of depth.
10962         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10963         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10964         (user_print_options): Initialise max_depth field.
10965         (val_print_scalar_or_string_type_p): New function.
10966         (val_print): Check to see if the max depth has been reached.
10967         (val_print_check_max_depth): Define new function.
10968         (show_print_max_depth): New function.
10969         (_initialize_valprint): Add 'print max-depth' option.
10970         * valprint.h (struct value_print_options) <max_depth>: New field.
10971         (val_print_check_max_depth): Declare new function.
10972         * NEWS: Document new feature.
10973
10974 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10975
10976         * ada-lang.c (ada_language_defn): Initialise new field.
10977         * c-lang.c (c_is_string_type_p): New function.
10978         (c_language_defn): Initialise new field.
10979         (cplus_language_defn): Initialise new field.
10980         (asm_language_defn): Initialise new field.
10981         (minimal_language_defn): Initialise new field.
10982         * c-lang.h (c_is_string_type_p): Declare new function.
10983         * d-lang.c (d_language_defn): Initialise new field.
10984         * f-lang.c (f_is_string_type_p): New function.
10985         (f_language_defn): Initialise new field.
10986         * go-lang.c (go_is_string_type_p): New function.
10987         (go_language_defn): Initialise new field.
10988         * language.c (default_is_string_type_p): New function.
10989         (unknown_language_defn): Initialise new field.
10990         (auto_language_defn): Initialise new field.
10991         * language.h (struct language_defn) <la_is_string_type_p>: New
10992         member variable.
10993         (default_is_string_type_p): Declare new function.
10994         * m2-lang.c (m2_language_defn): Initialise new field.
10995         * objc-lang.c (objc_language_defn): Initialise new field.
10996         * opencl-lang.c (opencl_language_defn): Initialise new field.
10997         * p-lang.c (pascal_is_string_type_p): New function.
10998         (pascal_language_defn): Initialise new field.
10999         * rust-lang.c (rust_is_string_type_p): New function.
11000         (rust_language_defn): Initialise new field.
11001
11002 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11003
11004         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11005         New field.
11006         * ada-lang.c (ada_language_defn): Initialise new field.
11007         * c-lang.c (c_language_defn): Likewise.
11008         (cplus_language_defn): Likewise.
11009         (asm_language_defn): Likewise.
11010         (minimal_language_defn): Likewise.
11011         * d-lang.c (d_language_defn): Likewise.
11012         * f-lang.c (f_language_defn): Likewise.
11013         * go-lang.c (go_language_defn): Likewise.
11014         * language.c (unknown_language_defn): Likewise.
11015         (auto_language_defn): Likewise.
11016         * m2-lang.c (m2_language_defn): Likewise.
11017         * objc-lang.c (objc_language_defn): Likewise.
11018         * opencl-lang.c (opencl_language_defn): Likewise.
11019         * p-lang.c (pascal_language_defn): Likewise.
11020         * rust-lang.c (rust_language_defn): Likewise.
11021
11022 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11023
11024         * ada-lang.c (ada_is_character_type): Change return type to bool.
11025         (ada_is_string_type): Likewise.
11026         * ada-lang.h (ada_is_character_type): Update declaration
11027         (ada_is_string_type): Likewise.
11028
11029 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11030
11031         Support style in 'frame|thread apply'
11032
11033         * gdbcmd.h (execute_command_to_string): New term_out parameter.
11034         * record.c (record_start, record_stop): Update callers of
11035         execute_command_to_string with false.
11036         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11037         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11038         methods.
11039         (class string_file): New constructor with term_out parameter.
11040         Override methods term_out and can_emit_style_escape.  New member
11041         term_out.
11042         (class stdio_file): Override can_emit_style_escape.
11043         (class tee_file): Override term_out and can_emit_style_escape.
11044         * utils.h (can_emit_style_escape): Remove.
11045         * utils.c (can_emit_style_escape): Likewise.
11046         Update all callers of can_emit_style_escape (SOMESTREAM) to
11047         SOMESTREAM->can_emit_style_escape.
11048         * source-cache.c (source_cache::get_source_lines): Likewise.
11049         * stack.c (frame_apply_command_count): Call execute_command_to_string
11050         passing the term_out characteristic of the current gdb_stdout.
11051         * thread.c (thr_try_catch_cmd): Likewise.
11052         * top.c (execute_command_to_string): pass term_out parameter
11053         to construct the string_file for the command output.
11054         * ui-file.c (term_cli_styling): New function (most code moved
11055         from utils.c can_emit_style_escape).
11056         (string_file::string_file, string_file::can_emit_style_escape,
11057         stdio_file::can_emit_style_escape, tee_file::term_out,
11058         tee_file::can_emit_style_escape): New functions.
11059
11060 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11061
11062         * NEWS: Mention the new set|show may-call-functions.
11063         * infcall.c (may_call_functions_p): New variable.
11064         (show_may_call_functions_p): New function.
11065         (call_function_by_hand_dummy): Throws an error if not
11066         may-call-functions.
11067         (_initialize_infcall): Call add_setshow_boolean_cmd for
11068         may-call-functions.
11069
11070 2019-04-25  Keith Seitz  <keiths@redhat.com>
11071
11072         PR c++/24367
11073         * cp-support.c (inspect_type): Don't attempt substitutions
11074         of symbol with the same name.
11075
11076 2019-04-25  Tom Tromey  <tromey@adacore.com>
11077
11078         PR gdb/24475:
11079         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11080         static.
11081
11082 2019-04-25  Tom Tromey  <tromey@adacore.com>
11083
11084         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11085         rvalue reference.
11086         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11087         (gdb_xml_parser::parse): Use std::move.
11088         * python/python-internal.h (gdbpy_convert_exception): Take a const
11089         reference.
11090         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11091         std::move.
11092         * python/py-utils.c (gdbpy_convert_exception): Take a const
11093         reference.
11094         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11095         Use std::move.
11096         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11097         Use std::move.
11098         * mi/mi-main.c (mi_print_exception): Take a const reference.
11099         * main.c (handle_command_errors): Take a const reference.
11100         * linespec.c (parse_linespec): Use std::move.
11101         * infcall.c (run_inferior_call): Use std::move.
11102         (call_function_by_hand_dummy): Use std::move.
11103         * exec.c (try_open_exec_file): Use std::move.
11104         * exceptions.h (exception_print, exception_fprintf)
11105         (exception_print_same): Update.
11106         * exceptions.c (print_exception, exception_print)
11107         (exception_fprintf, exception_print_same): Change parameters to
11108         const reference.
11109         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11110         * common/new-op.c: Use std::move.
11111         * common/common-exceptions.h (struct gdb_exception): Add move
11112         constructor.
11113         (struct gdb_exception_error, struct gdb_exception_quit, struct
11114         gdb_quit_bad_alloc): Change constructor to move constructor.
11115         (throw_exception): Change parameter to rvalue reference.
11116         * common/common-exceptions.c (throw_exception): Take rvalue
11117         reference.
11118         * cli/cli-interp.c (safe_execute_command): Use std::move.
11119         * breakpoint.c (insert_bp_location, location_to_sals): Use
11120         std::move.
11121
11122 2019-04-25  Tom Tromey  <tromey@adacore.com>
11123
11124         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11125         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11126         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11127         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11128         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11129         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11130         guile/scm-value.c: Use unpack.
11131         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11132         gdbscm_gdb_exception.
11133         (gdbscm_throw_gdb_exception): Likewise.
11134         (struct gdbscm_gdb_exception): New.
11135         (unpack): New function.
11136         (gdbscm_wrap): Use unpack.
11137
11138 2019-04-25  Tom Tromey  <tromey@adacore.com>
11139
11140         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11141         (gdb_rl_callback_handler): Use std::move.
11142         * common/common-exceptions.h (struct gdb_exception): Add move
11143         assignment operator.
11144         (throw_exception_sjlj): Change "exception" to const reference.
11145         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11146         (throw_exception_sjlj): Change "exception" to const reference.
11147
11148 2019-04-25  Tom Tromey  <tromey@adacore.com>
11149
11150         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11151         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11152         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11153         Update.
11154         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11155         Update.
11156         * mi/mi-interp.c (mi_interp::exec): Update.
11157         * linespec.c (parse_linespec): Update.
11158         * infcall.c (run_inferior_call): Update.
11159         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11160         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11161         (gdbscm_lookup_global_symbol): Update.
11162         * guile/scm-param.c (gdbscm_parameter_value): Update.
11163         * guile/scm-frame.c (gdbscm_frame_read_register)
11164         (gdbscm_frame_read_var): Update.
11165         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11166         * exec.c (try_open_exec_file): Update.
11167         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11168         (gdb_rl_callback_handler): Update.
11169         * common/common-exceptions.h (exception_none): Don't declare.
11170         * common/common-exceptions.c (exception_none): Don't define.
11171         (struct catcher) <exception>: Update.
11172         * cli/cli-interp.c (safe_execute_command): Update.
11173         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11174
11175 2019-04-25  Ali Tamur  <tamur@google.com>
11176
11177         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11178         (read_attribute_value): Likewise.
11179         (dwarf2_read_addr_index): Update comment.
11180         (read_str_index): Add DW_FORM_strx.
11181         (dwarf2_string_attr): Likewise.
11182         (dwarf2_const_value_attr): Likewise.
11183         (dump_die_shallow): Likewise.
11184         (dwarf2_fetch_constant_bytes): Likewise.
11185         (skip_form_bytes): Likewise.
11186         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11187
11188 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11189
11190         PR corefiles/11608
11191         PR corefiles/18187
11192         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11193         OFFSET.  Verify if current mapping contains an ELF header.
11194         (linux_find_memory_regions_full): Adjust call to
11195         dump_mapping_p.
11196
11197 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11198             Kang Li <kanglictf@gmail.com>
11199
11200         PR gdb/21600
11201
11202         * dwarf2-frame.c (read_initial_length): Be consistent about using
11203         unsigned representation of length.
11204         (decode_frame_entry_1): Likewise.  Check for wraparound of
11205         end pointer as well as buffer overflow.
11206
11207 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11208
11209         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11210         "vq".
11211
11212 2019-04-24  Tom Tromey  <tromey@adacore.com>
11213
11214         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11215
11216 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11217
11218         * s12z-tdep.c (s12z_unwind_pc): Delete.
11219         (s12z_unwind_sp): Delete.
11220         (s12z_gdbarch_init): Don't register deleted functions with
11221         gdbarch.
11222
11223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11224
11225         * rl78-tdep.c (rl78_unwind_sp): Delete.
11226         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11227
11228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11229
11230         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11231         (xstormy16_unwind_pc): Delete.
11232         (xstormy16_dummy_id): Delete.
11233         (xstormy16_gdbarch_init): Don't register deleted functions with
11234         gdbarch.
11235
11236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11237
11238         * vax-tdep.c (vax_unwind_pc): Delete.
11239         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11240
11241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11242
11243         * v850-tdep.c (v850_unwind_sp): Delete.
11244         (v850_unwind_pc): Delete.
11245         (v850_dummy_id): Delete.
11246         (v850_gdbarch_init): Don't register deleted functions with
11247         gdbarch.
11248
11249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11250
11251         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11252         (tilegx_unwind_pc): Delete.
11253         (tilegx_unwind_dummy_id): Delete.
11254         (tilegx_gdbarch_init): Don't register deleted functions with
11255         gdbarch.
11256
11257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11258
11259         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11260         (tic6x_dummy_id): Delete.
11261         (tic6x_gdbarch_init): Don't register deleted functions with
11262         gdbarch.
11263
11264 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11265
11266         * sparc-tdep.c (sparc_unwind_pc): Delete.
11267         (sparc32_gdbarch_init): Don't register deleted function with
11268         gdbarch.
11269
11270 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11271
11272         * sh-tdep.c (sh_unwind_sp): Delete.
11273         (sh_unwind_pc): Delete.
11274         (sh_dummy_id): Delete.
11275         (sh_gdbarch_init): Don't register deleted functions with
11276         gdbarch.
11277
11278 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11279
11280         * score-tdep.c (score_unwind_sp): Delete.
11281         (score_unwind_pc): Delete.
11282         (score_dummy_id): Delete.
11283         (score_gdbarch_init): Don't register deleted functions with
11284         gdbarch.
11285
11286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11287
11288         * rx-tdep.c (rx_unwind_pc): Delete.
11289         (rx_unwind_sp): Delete.
11290         (rx_dummy_id): Delete.
11291         (rx_gdbarch_init): Don't register deleted functions with
11292         gdbarch.  Update comment.
11293
11294 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11295
11296         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11297         (rs6000_dummy_id): Delete.
11298         (rs6000_gdbarch_init): Don't register deleted functions with
11299         gdbarch.
11300
11301 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11302
11303         * or1k-tdep.c (or1k_dummy_id): Delete.
11304         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11305
11306 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11307
11308         * nios2-tdep.c (nios2_dummy_id): Delete.
11309         (nios2_unwind_sp): Delete.
11310         (nios2_gdbarch_init): Don't register deleted functions with
11311         gdbarch.
11312
11313 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11314
11315         * nds32-tdep.c (nds32_dummy_id): Delete.
11316         (nds32_unwind_pc): Delete.
11317         (nds32_unwind_sp): Delete.
11318         (nds32_gdbarch_init): Don't register deleted functions with
11319         gdbarch.
11320
11321 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11322
11323         * msp430-tdep.c (msp430_unwind_pc): Delete.
11324         (msp430_unwind_sp): Delete.
11325         (msp430_dummy_id): Delete.
11326         (msp430_gdbarch_init): Don't register deleted functions with
11327         gdbarch.
11328
11329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11330
11331         * moxie-tdep.c (moxie_unwind_sp): Delete.
11332         (moxie_unwind_pc): Delete.
11333         (moxie_dummy_id): Delete.
11334         (moxie_gdbarch_init): Don't register deleted functions with
11335         gdbarch.
11336
11337 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11338
11339         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11340         (mn10300_unwind_pc): Delete.
11341         (mn10300_unwind_sp): Delete.
11342         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11343         mn10300_unwind_sp.
11344         (mn10300_frame_unwind_init): Don't register deleted functions with
11345         gdbarch.
11346
11347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11348
11349         * mep-tdep.c (mep_unwind_pc): Delete.
11350         (mep_unwind_sp): Delete.
11351         (mep_dummy_id): Delete.
11352         (mep_gdbarch_init): Don't register deleted functions with
11353         gdbarch.
11354
11355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11356
11357         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11358         (m68hc11_unwind_sp): Delete.
11359         (m68hc11_gdbarch_init): Don't register deleted functions with
11360         gdbarch.
11361
11362 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11363
11364         * m32r-tdep.c (m32r_unwind_sp): Delete.
11365         (m32r_unwind_pc): Delete.
11366         (m32r_dummy_id): Delete.
11367         (m32r_gdbarch_init): Don't register deleted functions with
11368         gdbarch.
11369
11370 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11371
11372         * m32c-tdep.c (m32c_unwind_pc): Delete.
11373         (m32c_unwind_sp): Delete.
11374         (m32c_dummy_id): Delete.
11375         (m32c_gdbarch_init): Don't register deleted functions with
11376         gdbarch.
11377
11378 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11379
11380         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11381         (lm32_unwind_pc): Delete.
11382         (lm32_dummy_id): Delete.
11383         (lm32_gdbarch_init): Don't register deleted functions with
11384         gdbarch.
11385
11386 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11387
11388         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11389         (iq2000_unwind_pc): Delete.
11390         (iq2000_dummy_id): Delete.
11391         (iq2000_gdbarch_init): Don't register deleted functions with
11392         gdbarch.
11393
11394 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11395
11396         * nds32-tdep.c (nds32_type_align): Delete.
11397         (nds32_push_dummy_call): Use type_align instead.
11398
11399 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11400
11401         * arm-tdep.c (arm_type_align): Only handle vector override case.
11402         (arm_push_dummy_call): Use type_align.
11403         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11404
11405 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11406
11407         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11408         case.
11409         (pass_on_stack): Use type_align.
11410         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11411         function.
11412
11413 2019-04-23  Tom Tromey  <tromey@adacore.com>
11414
11415         * dwarf2read.c (line_header::file_name_at): Remove unused
11416         overload.
11417
11418 2019-04-23  Tom de Vries  <tdevries@suse.de>
11419
11420         PR gdb/24438
11421         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11422         invocation.
11423
11424
11425 2019-03-27  Ali Tamur  <tamur@google.com>
11426
11427         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11428         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11429         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11430         (dwarf_expr_context::get_addr_index): Likewise
11431         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11432         (symbol_needs_eval_context::get_addr_index): Likewise
11433         (disassemble_dwarf_expression): Add DW_OP_addrx
11434         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11435         (read_cutu_die_from_dwo): Update comment
11436         (skip_one_die): Add DW_FORM_addrx
11437         (read_attribute_value): Likewise
11438         (var_decode_location): Add DW_OP_addrx
11439         (dwarf2_const_value_attr): Add DW_FORM_addrx
11440         (dump_die_shallow): Likewise
11441         (dwarf2_fetch_constant_bytes): Likewise
11442         (decode_locdesc): Add DW_OP_addrx
11443         (skip_form_bytes): Add DW_FORM_addrx
11444
11445 2019-04-22  Ali Tamur  <tamur@google.com>
11446
11447         * MAINTAINERS (Write After Approval): Add self.
11448
11449 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11450
11451         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11452         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11453         (open_symbol_file_object): Likewise.
11454         (svr4_default_sos): Add info parameter.
11455         (svr4_read_so_list): Likewise.
11456         (svr4_current_sos_direct): Adjust functions calls to pass down
11457         info.
11458         (svr4_current_sos_1): Add info parameter.
11459         (svr4_current_sos): Call get_svr4_info, pass info down to
11460         svr4_current_sos_1.
11461         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11462         get_svr4_info.
11463         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11464         get_svr4_info.
11465         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11466         to get_svr4_info.
11467         (probes_table_remove_objfile_probes): Likewise.
11468         (register_solib_event_probe): Add info parameter.
11469         (solist_update_incremental): Pass info parameter down to
11470         svr4_read_so_list.
11471         (disable_probes_interface): Add info parameter.
11472         (svr4_handle_solib_event): Pass current_program_space to
11473         get_svr4_info.  Adjust disable_probes_interface cleanup.
11474         (svr4_create_probe_breakpoints): Add info parameter, pass it
11475         down to register_solib_event_probe.
11476         (svr4_create_solib_event_breakpoints): Add info parameter,
11477         pass it down to svr4_create_probe_breakpoints.
11478         (enable_break): Pass info down to
11479         svr4_create_solib_event_breakpoints.
11480         (svr4_solib_create_inferior_hook): Pass current_program_space to
11481         get_svr4_info.
11482         (svr4_clear_solib): Likewise.
11483
11484 2019-04-22  Pedro Alves  <palves@redhat.com>
11485
11486         * solib-svr4.c (svr4_free_objfile_observer): New.
11487         (probe_and_action::objfile): New field.
11488         (probes_table_htab_remove_objfile_probes)
11489         (probes_table_remove_objfile_probes): New functions.
11490         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11491         in the new probe_and_action.  Don't store the probe in 'lookup'.
11492         (svr4_create_probe_breakpoints): Pass objfile to
11493         register_solib_event_probe.
11494         (_initialize_svr4_solib): Register a free_objfile observer.
11495
11496 2019-04-19  Tom Tromey  <tom@tromey.com>
11497
11498         * common/queue.h: Remove.
11499
11500 2019-04-19  Tom Tromey  <tom@tromey.com>
11501
11502         * event-loop.c: Don't include "common/queue.h".
11503
11504 2019-04-19  Tom Tromey  <tom@tromey.com>
11505
11506         * remote.c (remote_target): Use delete.
11507         * remote-notif.h: Include <list>, not "common/queue.h".
11508         (notif_client_p): Remove typedef.
11509         (remote_notif_state): Add constructor, destructor, initializer.
11510         <notif_queue>: Now a std::list.
11511         (remote_notif_state_xfree): Don't declare.
11512         * remote-notif.c (remote_notif_process, handle_notification)
11513         (remote_notif_state_allocate): Update.
11514         (~remote_notif_state): Rename from remote_notif_state_xfree.
11515
11516 2019-04-19  Tom Tromey  <tom@tromey.com>
11517
11518         * symfile.c (reread_symbols): Update.
11519         * objfiles.c (objfile_register_static_link)
11520         (objfile_lookup_static_link): Update
11521         (~objfile) Don't delete static_links.
11522         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11523
11524 2019-04-19  Tom Tromey  <tom@tromey.com>
11525
11526         * type-stack.h (struct type_stack) <insert>: Constify string.
11527         * type-stack.c (type_stack::insert): Constify string.
11528         * gdbtypes.h (lookup_template_type): Update.
11529         (address_space_name_to_int): Update.
11530         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11531         const.
11532         (lookup_template_type): Make name const.
11533         * c-exp.y: Update rules.
11534         (lex_one_token, classify_name, classify_inner_name)
11535         (c_print_token): Update.
11536         * p-exp.y: Update rules.
11537         (yylex): Update.
11538         * f-exp.y: Update rules.
11539         (yylex): Update.
11540         * d-exp.y: Update rules.
11541         (lex_one_token, classify_name, classify_inner_name): Update.
11542         * parse.c (write_dollar_variable, copy_name): Return std::string.
11543         * parser-defs.h (copy_name): Change return type.
11544         * m2-exp.y: Update rules.
11545         (yylex): Update.
11546         * go-exp.y (lex_one_token): Update.
11547         Update rules.
11548         (classify_unsafe_function, classify_packaged_name)
11549         (classify_name, yylex): Update.
11550
11551 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11552
11553         * configure.ac: add --enable-source-highlight switch.
11554         * configure: Regenerate.
11555         * top.c (print_gdb_version): plumb --enable-source-highlight
11556         status to "show configuration".
11557
11558 2019-04-19  Tom Tromey  <tromey@adacore.com>
11559
11560         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11561         Check ADA_TYPE_P.
11562         (empty_record, ada_template_to_fixed_record_type_1)
11563         (template_to_static_fixed_type)
11564         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11565         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11566         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11567         macros.
11568
11569 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11570
11571         PR symtab/24423:
11572         * source.c (print_source_lines_base): Advance "iter" when a
11573         control character is seen.
11574
11575 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11576
11577         * inferior.h (struct infcall_suspend_state_deleter):
11578         Catch exception in destructor to avoid crash.
11579
11580 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11581
11582         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11583         close to the add_com "shell".
11584
11585 2019-04-18  Tom Tromey  <tromey@adacore.com>
11586
11587         * process-stratum-target.h (class process_stratum_target)
11588         <stratum>: Add "final".
11589
11590 2019-04-17  Tom Tromey  <tromey@adacore.com>
11591
11592         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11593         against nullptr before use.
11594
11595 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11596
11597         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11598
11599 2019-04-17  Jim Wilson  <jimw@sifive.com>
11600             Andrew Burgess  <andrew.burgess@embecosm.com>
11601
11602         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11603         code read might fail, assume 4-byte breakpoint in that case.
11604
11605 2019-04-15  Leszek Swirski  <leszeks@google.com>
11606
11607         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11608         rather than a hand-rolled POD check when checking for forced MEMORY
11609         classification.
11610
11611 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11612
11613         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11614         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11615         function.
11616         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11617         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11618         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11619         declaration.
11620
11621 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11622
11623         * aarch64-linux-nat.c
11624         (aarch64_linux_nat_target::thread_architecture): Add override.
11625         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11626         each VQ.
11627
11628 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11629
11630         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11631
11632 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11633
11634         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11635         target types of size 96-bits, add some additional comments, and
11636         check that the builtin type we found was the correct size.
11637
11638 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11639
11640         * utils.c (prompt_for_continue): Don't restore the styling at the
11641         end, as applied_style has the wrong value.  This fixes styling in
11642         long lists of file names that are interrupted by the "Continue?"
11643         prompt.
11644
11645 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11646
11647         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11648         * c-lang.c (c_language_defn): Likewise.
11649         (cplus_language_defn): Likewise.
11650         (asm_language_defn): Likewise.
11651         (minimal_language_defn): Likewise.
11652         * d-lang.c (d_language_defn): Likewise.
11653         * f-lang.c (f_language_defn): Likewise.
11654         * go-lang.c (go_language_defn): Likewise.
11655         * language.c (unknown_language_defn): Likewise.
11656         (auto_language_defn): Likewise.
11657         * language.h (struct language_defn): Remove la_magic field.
11658         (LANG_MAGIC): Delete.
11659         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11660         * objc-lang.c (objc_language_defn): Likewise.
11661         * opencl-lang.c (opencl_language_defn): Likewise.
11662         * p-lang.c (pascal_language_defn): Likewise.
11663         * rust-lang.c (rust_language_defn): Likewise.
11664
11665 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11666
11667         * riscv-tdep.c (riscv_type_align): New function.
11668         (riscv_type_alignment): Delete.
11669         (riscv_arg_location): Use 'type_align'.
11670         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11671
11672 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11673
11674         * gdbtypes.c (type_align): A struct with no non-static fields also
11675         has alignment of 1.
11676
11677 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11678
11679         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11680         component to 0.
11681         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11682         member.
11683         (riscv_struct_info::analyse): New implementation using new
11684         analyse_inner member function.
11685         (riscv_struct_info::field_offset): New member function.
11686         (riscv_struct_info::m_offsets): New member variable.
11687         (riscv_struct_info::analyse_inner): New private member function,
11688         takes the old implementation of riscv_struct_info::analyse but
11689         extended to track field offsets.
11690         (riscv_call_arg_struct): Update the struct folding special cases
11691         to handle cases where empty C++ structs, which are non-zero
11692         length, are found.
11693         (riscv_arg_location): Initialise the length of each location, a
11694         non-zero length now indicates the location is in use.
11695         (riscv_push_dummy_call): Allow for the first location having a
11696         non-zero offset when setting up arguments.
11697         (riscv_return_value): Likewise, but for return values.
11698
11699 2019-04-11  Tom Tromey  <tromey@adacore.com>
11700
11701         * utils.c (internal_vproblem): Make "msg" const.
11702
11703 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11704
11705         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11706         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11707         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11708         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11709
11710 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11711
11712         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11713         function.
11714         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11715         of amd64_collect_native_gregset.
11716         (amd64_linux_nat_target::store_registers): Likewise.
11717
11718 2019-04-10  Tom Tromey  <tom@tromey.com>
11719
11720         * symtab.c (lookup_global_symbol_from_objfile)
11721         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11722         * objfiles.h (class separate_debug_iterator): New.
11723         (class separate_debug_range): New.
11724         (struct objfile) <separate_debug_objfiles>: New method.
11725         (objfile_separate_debug_iterate): Don't declare.
11726         * objfiles.c (separate_debug_iterator::operator++): Rename from
11727         objfile_separate_debug_iterate.
11728         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11729         iterator.
11730         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11731         iterator.
11732
11733 2019-04-10  Tom Tromey  <tom@tromey.com>
11734
11735         * symfile.c (reread_symbols): Remove old comment.
11736         * objfiles.c (free_all_objfiles): Fix a typo.
11737
11738 2019-04-10  Tom Tromey  <tom@tromey.com>
11739
11740         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11741         * minsyms.c (lookup_minimal_symbol): Use foreach.
11742         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11743         (lookup_minimal_symbol_solib_trampoline): Likewise.
11744         * symfile.c (reread_symbols): Use foreach.
11745
11746 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11747             Tom Tromey  <tromey@adacore.com>
11748
11749         PR rust/24414:
11750         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11751         (rust_lex_int_test): Change "value" to be LONGEST.
11752         (rust_lex_tests): Add test for long integer literal.
11753
11754 2019-04-09  Tom Tromey  <tromey@adacore.com>
11755
11756         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11757         to bool.
11758         (extended_remote_target::attach): Update.
11759         (remote_target::remote_notice_new_inferior): Update.
11760         (remote_target::add_current_inferior_and_thread): Update.
11761         * inferior.c (exit_inferior_1): Use "false".
11762         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11763
11764 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11765
11766         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11767         the "start" command.
11768
11769 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11770
11771         * python/py-inferior.c (infpy_thread_from_thread_handle):
11772         Adjust comments to reflect renaming of thread_from_thread_handle
11773         to thread_from_handle.  Adjust keywords.  Fix type error message.
11774         (inferior_object_methods): Add thread_from_handle.  Retain
11775         thread_from_thread_handle, but mark it as deprecated.
11776
11777 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11778
11779         * gdbthread.h (find_thread_by_handle): Revise declaration.
11780         * thread.c (find_thread_by_handle): Likewise.  Adjust
11781         implementation too.
11782         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11783         support for buffer objects as handles.
11784
11785 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11786
11787         * python/py-infthread.c (thpy_thread_handle): New function.
11788         (thread_object_methods): Register thpy_thread_handle.
11789
11790 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11791
11792         * gdbthread.h (thread_to_thread_handle): Declare.
11793         * thread.c (gdbtypes.h): Include.
11794         (thread_to_thread_handle): New function.
11795
11796         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11797         (target_thread_info_to_thread_handle): Declare.
11798         * target.c (target_thread_info_to_thread_handle): New function.
11799         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11800         * target-delegates.c: Regenerate.
11801
11802         * linux-thread-db.c (class thread_db_target): Add method
11803         thread_info_to_thread_handle.
11804         (thread_db_target::thread_info_to_thread_handle): Define.
11805         * remote.c (class remote_target): Add new method
11806         thread_info_to_thread_handle.
11807         (remote_target::thread_info_to_thread_handle): Define.
11808
11809 2019-04-08  Pedro Alves  <palves@redhat.com>
11810
11811         * common/common-exceptions.c (throw_exception): Don't create
11812         named object to throw; throw directly.
11813         (throw_it): Likewise.  Don't initialize gdb_exception::message
11814         here, with new; pass FMT and AP to the ctor instead.
11815         * common/common-exceptions.h: Include <string>.
11816         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11817         const char *, va_list)): New ctor.  Use std::make_shared.
11818         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11819         errors)): Delete.
11820         (gdb_exception_error::gdb_exception_error(enum errors, const char
11821         *, va_list)): New.
11822         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11823         Add assertion.
11824         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11825         errors)): Delete.
11826         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11827         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11828         Add assertion.
11829
11830 2019-04-08  Tom Tromey  <tom@tromey.com>
11831
11832         * valops.c (value_rtti_indirect_type): Replace throw_exception
11833         with throw.
11834         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11835         with throw.
11836         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11837         throw.
11838         * target.c (target_translate_tls_address): Replace throw_exception
11839         with throw.
11840         * stack.c (frame_apply_command_count): Replace throw_exception
11841         with throw.
11842         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11843         throw.
11844         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11845         with throw.
11846         * rs6000-tdep.c (rs6000_frame_cache)
11847         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11848         * remote.c: Replace throw_exception with throw.
11849         * record-full.c (record_full_message, record_full_wait_1)
11850         (record_full_restore): Replace throw_exception with throw.
11851         * record-btrace.c:
11852         (get_thread_current_frame_id, record_btrace_start_replaying)
11853         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11854         (cmd_record_btrace_start): Replace throw_exception with throw.
11855         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11856         throw.
11857         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11858         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11859         * linespec.c:
11860         (find_linespec_symbols): Replace throw_exception with throw.
11861         * infrun.c (displaced_step_prepare, resume): Replace
11862         throw_exception with throw.
11863         * infcmd.c (post_create_inferior): Replace throw_exception with
11864         throw.
11865         * inf-loop.c (inferior_event_handler): Replace throw_exception
11866         with throw.
11867         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11868         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11869         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11870         (get_prev_frame_always, get_frame_pc_if_available)
11871         (get_frame_address_in_block_if_available, get_frame_language):
11872         Replace throw_exception with throw.
11873         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11874         throw_exception with throw.
11875         * eval.c (fetch_subexp_value, evaluate_var_value)
11876         (evaluate_funcall, evaluate_subexp_standard): Replace
11877         throw_exception with throw.
11878         * dwarf2loc.c (call_site_find_chain)
11879         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11880         Replace throw_exception with throw.
11881         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11882         with throw.
11883         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11884         throw.
11885         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11886         * completer.c (complete_line_internal): Replace throw_exception
11887         with throw.
11888         * compile/compile-object-run.c (compile_object_run): Replace
11889         throw_exception with throw.
11890         * cli/cli-script.c (process_next_line): Replace throw_exception
11891         with throw.
11892         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11893         (btrace_enable, btrace_maint_update_pt_packets): Replace
11894         throw_exception with throw.
11895         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11896         throw_exception with throw.
11897         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11898         throw_exception with throw.
11899         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11900         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11901         * aarch64-tdep.c (aarch64_make_prologue_cache)
11902         (aarch64_make_stub_cache): Replace throw_exception with throw.
11903
11904 2019-04-08  Tom Tromey  <tom@tromey.com>
11905
11906         * common/common-exceptions.c (throw_exception): Rename from
11907         throw_exception_cxx.  Remove old copy.  Make argument const.
11908         (throw_it): Create and throw exception objects directly.
11909         * common/common-exceptions.h (throw_exception): Make argument
11910         const.
11911         (struct gdb_exception_error): Add constructor.
11912         (struct gdb_exception_quit): Add constructor.
11913
11914 2019-04-08  Tom Tromey  <tom@tromey.com>
11915
11916         * common/common-exceptions.h (exception_rethrow): Don't declare.
11917         (TRY_SJLJ): Update comment.
11918         (TRY, CATCH, END_CATCH): Remove.
11919         * common/common-exceptions.c (exception_rethrow): Remove.
11920
11921 2019-04-08  Tom Tromey  <tom@tromey.com>
11922
11923         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11924         Remove.
11925         (gdb_exception_error): Rename from
11926         gdb_exception_RETURN_MASK_ERROR.
11927         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11928         (gdb_quit_bad_alloc): Update.
11929         * aarch64-tdep.c: Update.
11930         * ada-lang.c: Update.
11931         * ada-typeprint.c: Update.
11932         * ada-valprint.c: Update.
11933         * amd64-tdep.c: Update.
11934         * arch-utils.c: Update.
11935         * break-catch-throw.c: Update.
11936         * breakpoint.c: Update.
11937         * btrace.c: Update.
11938         * c-varobj.c: Update.
11939         * cli/cli-cmds.c: Update.
11940         * cli/cli-interp.c: Update.
11941         * cli/cli-script.c: Update.
11942         * common/common-exceptions.c: Update.
11943         * common/new-op.c: Update.
11944         * common/selftest.c: Update.
11945         * compile/compile-c-symbols.c: Update.
11946         * compile/compile-cplus-symbols.c: Update.
11947         * compile/compile-object-load.c: Update.
11948         * compile/compile-object-run.c: Update.
11949         * completer.c: Update.
11950         * corelow.c: Update.
11951         * cp-abi.c: Update.
11952         * cp-support.c: Update.
11953         * cp-valprint.c: Update.
11954         * darwin-nat.c: Update.
11955         * disasm-selftests.c: Update.
11956         * dtrace-probe.c: Update.
11957         * dwarf-index-cache.c: Update.
11958         * dwarf-index-write.c: Update.
11959         * dwarf2-frame-tailcall.c: Update.
11960         * dwarf2-frame.c: Update.
11961         * dwarf2loc.c: Update.
11962         * dwarf2read.c: Update.
11963         * eval.c: Update.
11964         * event-loop.c: Update.
11965         * event-top.c: Update.
11966         * exec.c: Update.
11967         * f-valprint.c: Update.
11968         * fbsd-tdep.c: Update.
11969         * frame-unwind.c: Update.
11970         * frame.c: Update.
11971         * gdbtypes.c: Update.
11972         * gnu-v3-abi.c: Update.
11973         * guile/guile-internal.h: Update.
11974         * guile/scm-block.c: Update.
11975         * guile/scm-breakpoint.c: Update.
11976         * guile/scm-cmd.c: Update.
11977         * guile/scm-disasm.c: Update.
11978         * guile/scm-frame.c: Update.
11979         * guile/scm-lazy-string.c: Update.
11980         * guile/scm-math.c: Update.
11981         * guile/scm-param.c: Update.
11982         * guile/scm-ports.c: Update.
11983         * guile/scm-pretty-print.c: Update.
11984         * guile/scm-symbol.c: Update.
11985         * guile/scm-symtab.c: Update.
11986         * guile/scm-type.c: Update.
11987         * guile/scm-value.c: Update.
11988         * i386-linux-tdep.c: Update.
11989         * i386-tdep.c: Update.
11990         * inf-loop.c: Update.
11991         * infcall.c: Update.
11992         * infcmd.c: Update.
11993         * infrun.c: Update.
11994         * jit.c: Update.
11995         * language.c: Update.
11996         * linespec.c: Update.
11997         * linux-fork.c: Update.
11998         * linux-nat.c: Update.
11999         * linux-tdep.c: Update.
12000         * linux-thread-db.c: Update.
12001         * main.c: Update.
12002         * mi/mi-cmd-break.c: Update.
12003         * mi/mi-cmd-stack.c: Update.
12004         * mi/mi-interp.c: Update.
12005         * mi/mi-main.c: Update.
12006         * objc-lang.c: Update.
12007         * p-valprint.c: Update.
12008         * parse.c: Update.
12009         * ppc-linux-tdep.c: Update.
12010         * printcmd.c: Update.
12011         * python/py-arch.c: Update.
12012         * python/py-breakpoint.c: Update.
12013         * python/py-cmd.c: Update.
12014         * python/py-finishbreakpoint.c: Update.
12015         * python/py-frame.c: Update.
12016         * python/py-framefilter.c: Update.
12017         * python/py-gdb-readline.c: Update.
12018         * python/py-inferior.c: Update.
12019         * python/py-infthread.c: Update.
12020         * python/py-lazy-string.c: Update.
12021         * python/py-linetable.c: Update.
12022         * python/py-objfile.c: Update.
12023         * python/py-param.c: Update.
12024         * python/py-prettyprint.c: Update.
12025         * python/py-progspace.c: Update.
12026         * python/py-record-btrace.c: Update.
12027         * python/py-record.c: Update.
12028         * python/py-symbol.c: Update.
12029         * python/py-type.c: Update.
12030         * python/py-unwind.c: Update.
12031         * python/py-utils.c: Update.
12032         * python/py-value.c: Update.
12033         * python/python.c: Update.
12034         * record-btrace.c: Update.
12035         * record-full.c: Update.
12036         * remote-fileio.c: Update.
12037         * remote.c: Update.
12038         * riscv-tdep.c: Update.
12039         * rs6000-aix-tdep.c: Update.
12040         * rs6000-tdep.c: Update.
12041         * rust-exp.y: Update.
12042         * rust-lang.c: Update.
12043         * s390-tdep.c: Update.
12044         * selftest-arch.c: Update.
12045         * solib-dsbt.c: Update.
12046         * solib-frv.c: Update.
12047         * solib-spu.c: Update.
12048         * solib-svr4.c: Update.
12049         * solib.c: Update.
12050         * sparc64-linux-tdep.c: Update.
12051         * stack.c: Update.
12052         * symfile-mem.c: Update.
12053         * symmisc.c: Update.
12054         * target.c: Update.
12055         * thread.c: Update.
12056         * top.c: Update.
12057         * tracefile-tfile.c: Update.
12058         * tui/tui.c: Update.
12059         * typeprint.c: Update.
12060         * unittests/cli-utils-selftests.c: Update.
12061         * unittests/parse-connection-spec-selftests.c: Update.
12062         * valops.c: Update.
12063         * valprint.c: Update.
12064         * value.c: Update.
12065         * varobj.c: Update.
12066         * windows-nat.c: Update.
12067         * x86-linux-nat.c: Update.
12068         * xml-support.c: Update.
12069
12070 2019-04-08  Tom Tromey  <tom@tromey.com>
12071
12072         * xml-support.c: Use C++ exception handling.
12073         * x86-linux-nat.c: Use C++ exception handling.
12074         * windows-nat.c: Use C++ exception handling.
12075         * varobj.c: Use C++ exception handling.
12076         * value.c: Use C++ exception handling.
12077         * valprint.c: Use C++ exception handling.
12078         * valops.c: Use C++ exception handling.
12079         * unittests/parse-connection-spec-selftests.c: Use C++ exception
12080         handling.
12081         * unittests/cli-utils-selftests.c: Use C++ exception handling.
12082         * typeprint.c: Use C++ exception handling.
12083         * tui/tui.c: Use C++ exception handling.
12084         * tracefile-tfile.c: Use C++ exception handling.
12085         * top.c: Use C++ exception handling.
12086         * thread.c: Use C++ exception handling.
12087         * target.c: Use C++ exception handling.
12088         * symmisc.c: Use C++ exception handling.
12089         * symfile-mem.c: Use C++ exception handling.
12090         * stack.c: Use C++ exception handling.
12091         * sparc64-linux-tdep.c: Use C++ exception handling.
12092         * solib.c: Use C++ exception handling.
12093         * solib-svr4.c: Use C++ exception handling.
12094         * solib-spu.c: Use C++ exception handling.
12095         * solib-frv.c: Use C++ exception handling.
12096         * solib-dsbt.c: Use C++ exception handling.
12097         * selftest-arch.c: Use C++ exception handling.
12098         * s390-tdep.c: Use C++ exception handling.
12099         * rust-lang.c: Use C++ exception handling.
12100         * rust-exp.y: Use C++ exception handling.
12101         * rs6000-tdep.c: Use C++ exception handling.
12102         * rs6000-aix-tdep.c: Use C++ exception handling.
12103         * riscv-tdep.c: Use C++ exception handling.
12104         * remote.c: Use C++ exception handling.
12105         * remote-fileio.c: Use C++ exception handling.
12106         * record-full.c: Use C++ exception handling.
12107         * record-btrace.c: Use C++ exception handling.
12108         * python/python.c: Use C++ exception handling.
12109         * python/py-value.c: Use C++ exception handling.
12110         * python/py-utils.c: Use C++ exception handling.
12111         * python/py-unwind.c: Use C++ exception handling.
12112         * python/py-type.c: Use C++ exception handling.
12113         * python/py-symbol.c: Use C++ exception handling.
12114         * python/py-record.c: Use C++ exception handling.
12115         * python/py-record-btrace.c: Use C++ exception handling.
12116         * python/py-progspace.c: Use C++ exception handling.
12117         * python/py-prettyprint.c: Use C++ exception handling.
12118         * python/py-param.c: Use C++ exception handling.
12119         * python/py-objfile.c: Use C++ exception handling.
12120         * python/py-linetable.c: Use C++ exception handling.
12121         * python/py-lazy-string.c: Use C++ exception handling.
12122         * python/py-infthread.c: Use C++ exception handling.
12123         * python/py-inferior.c: Use C++ exception handling.
12124         * python/py-gdb-readline.c: Use C++ exception handling.
12125         * python/py-framefilter.c: Use C++ exception handling.
12126         * python/py-frame.c: Use C++ exception handling.
12127         * python/py-finishbreakpoint.c: Use C++ exception handling.
12128         * python/py-cmd.c: Use C++ exception handling.
12129         * python/py-breakpoint.c: Use C++ exception handling.
12130         * python/py-arch.c: Use C++ exception handling.
12131         * printcmd.c: Use C++ exception handling.
12132         * ppc-linux-tdep.c: Use C++ exception handling.
12133         * parse.c: Use C++ exception handling.
12134         * p-valprint.c: Use C++ exception handling.
12135         * objc-lang.c: Use C++ exception handling.
12136         * mi/mi-main.c: Use C++ exception handling.
12137         * mi/mi-interp.c: Use C++ exception handling.
12138         * mi/mi-cmd-stack.c: Use C++ exception handling.
12139         * mi/mi-cmd-break.c: Use C++ exception handling.
12140         * main.c: Use C++ exception handling.
12141         * linux-thread-db.c: Use C++ exception handling.
12142         * linux-tdep.c: Use C++ exception handling.
12143         * linux-nat.c: Use C++ exception handling.
12144         * linux-fork.c: Use C++ exception handling.
12145         * linespec.c: Use C++ exception handling.
12146         * language.c: Use C++ exception handling.
12147         * jit.c: Use C++ exception handling.
12148         * infrun.c: Use C++ exception handling.
12149         * infcmd.c: Use C++ exception handling.
12150         * infcall.c: Use C++ exception handling.
12151         * inf-loop.c: Use C++ exception handling.
12152         * i386-tdep.c: Use C++ exception handling.
12153         * i386-linux-tdep.c: Use C++ exception handling.
12154         * guile/scm-value.c: Use C++ exception handling.
12155         * guile/scm-type.c: Use C++ exception handling.
12156         * guile/scm-symtab.c: Use C++ exception handling.
12157         * guile/scm-symbol.c: Use C++ exception handling.
12158         * guile/scm-pretty-print.c: Use C++ exception handling.
12159         * guile/scm-ports.c: Use C++ exception handling.
12160         * guile/scm-param.c: Use C++ exception handling.
12161         * guile/scm-math.c: Use C++ exception handling.
12162         * guile/scm-lazy-string.c: Use C++ exception handling.
12163         * guile/scm-frame.c: Use C++ exception handling.
12164         * guile/scm-disasm.c: Use C++ exception handling.
12165         * guile/scm-cmd.c: Use C++ exception handling.
12166         * guile/scm-breakpoint.c: Use C++ exception handling.
12167         * guile/scm-block.c: Use C++ exception handling.
12168         * guile/guile-internal.h: Use C++ exception handling.
12169         * gnu-v3-abi.c: Use C++ exception handling.
12170         * gdbtypes.c: Use C++ exception handling.
12171         * frame.c: Use C++ exception handling.
12172         * frame-unwind.c: Use C++ exception handling.
12173         * fbsd-tdep.c: Use C++ exception handling.
12174         * f-valprint.c: Use C++ exception handling.
12175         * exec.c: Use C++ exception handling.
12176         * event-top.c: Use C++ exception handling.
12177         * event-loop.c: Use C++ exception handling.
12178         * eval.c: Use C++ exception handling.
12179         * dwarf2read.c: Use C++ exception handling.
12180         * dwarf2loc.c: Use C++ exception handling.
12181         * dwarf2-frame.c: Use C++ exception handling.
12182         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12183         * dwarf-index-write.c: Use C++ exception handling.
12184         * dwarf-index-cache.c: Use C++ exception handling.
12185         * dtrace-probe.c: Use C++ exception handling.
12186         * disasm-selftests.c: Use C++ exception handling.
12187         * darwin-nat.c: Use C++ exception handling.
12188         * cp-valprint.c: Use C++ exception handling.
12189         * cp-support.c: Use C++ exception handling.
12190         * cp-abi.c: Use C++ exception handling.
12191         * corelow.c: Use C++ exception handling.
12192         * completer.c: Use C++ exception handling.
12193         * compile/compile-object-run.c: Use C++ exception handling.
12194         * compile/compile-object-load.c: Use C++ exception handling.
12195         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12196         * compile/compile-c-symbols.c: Use C++ exception handling.
12197         * common/selftest.c: Use C++ exception handling.
12198         * common/new-op.c: Use C++ exception handling.
12199         * cli/cli-script.c: Use C++ exception handling.
12200         * cli/cli-interp.c: Use C++ exception handling.
12201         * cli/cli-cmds.c: Use C++ exception handling.
12202         * c-varobj.c: Use C++ exception handling.
12203         * btrace.c: Use C++ exception handling.
12204         * breakpoint.c: Use C++ exception handling.
12205         * break-catch-throw.c: Use C++ exception handling.
12206         * arch-utils.c: Use C++ exception handling.
12207         * amd64-tdep.c: Use C++ exception handling.
12208         * ada-valprint.c: Use C++ exception handling.
12209         * ada-typeprint.c: Use C++ exception handling.
12210         * ada-lang.c: Use C++ exception handling.
12211         * aarch64-tdep.c: Use C++ exception handling.
12212
12213 2019-04-08  Tom Tromey  <tom@tromey.com>
12214
12215         * xml-support.c (gdb_xml_parser::parse): Update.
12216         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12217         * value.c (show_convenience): Update.
12218         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12219         (test_parse_flags_qcs): Update.
12220         * thread.c (thr_try_catch_cmd): Update.
12221         * target.c (target_translate_tls_address): Update.
12222         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12223         (info_frame_command_core, frame_apply_command_count): Update.
12224         * rust-exp.y (rust_lex_exception_test): Update.
12225         * riscv-tdep.c (riscv_print_one_register_info): Update.
12226         * remote.c (remote_target::enable_btrace): Update.
12227         * record-btrace.c (record_btrace_enable_warn): Update.
12228         * python/py-utils.c (gdbpy_convert_exception): Update.
12229         * printcmd.c (do_one_display, print_variable_and_value): Update.
12230         * mi/mi-main.c (mi_print_exception): Update.
12231         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12232         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12233         * linux-nat.c (linux_nat_target::attach): Update.
12234         * linux-fork.c (class scoped_switch_fork_info): Update.
12235         * infrun.c (displaced_step_prepare): Update.
12236         * infcall.c (call_function_by_hand_dummy): Update.
12237         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12238         * gnu-v3-abi.c (print_one_vtable): Update.
12239         * frame.c (get_prev_frame_always): Update.
12240         * f-valprint.c (info_common_command_for_block): Update.
12241         * exec.c (try_open_exec_file): Update.
12242         * exceptions.c (print_exception, exception_print)
12243         (exception_fprintf, exception_print_same): Update.
12244         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12245         * dwarf-index-cache.c (index_cache::store)
12246         (index_cache::lookup_gdb_index): Update.
12247         * darwin-nat.c (maybe_cache_shell): Update.
12248         * cp-valprint.c (cp_print_value_fields): Update.
12249         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12250         (gcc_cplus_symbol_address): Update.
12251         * compile/compile-c-symbols.c (gcc_convert_symbol)
12252         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12253         * common/selftest.c: Update.
12254         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12255         a std::string.
12256         (exception_try_scope_entry, exception_try_scope_exit): Don't
12257         declare.
12258         (struct exception_try_scope): Remove.
12259         (TRY): Don't use exception_try_scope.
12260         (struct gdb_exception): Add constructor, operator=.
12261         <what>: New method.
12262         (struct gdb_exception_RETURN_MASK_ALL)
12263         (struct gdb_exception_RETURN_MASK_ERROR)
12264         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12265         (struct gdb_quit_bad_alloc): Update.
12266         * common/common-exceptions.c (exception_none): Change
12267         initializer.
12268         (struct catcher) <state, exception>: Initialize inline.
12269         <prev>: Remove member.
12270         (current_catcher): Remove.
12271         (catchers): New global.
12272         (exceptions_state_mc_init): Simplify.
12273         (catcher_pop): Remove.
12274         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12275         (try_scope_depth, exception_try_scope_entry)
12276         (exception_try_scope_exit): Remove.
12277         (throw_exception_sjlj): Update.
12278         (exception_messages, exception_messages_size): Remove.
12279         (throw_it): Simplify.
12280         (gdb_exception_sliced_copy): Remove.
12281         (throw_exception_cxx): Update.
12282         * cli/cli-script.c (script_from_file): Update.
12283         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12284         Update.
12285         * ada-valprint.c (ada_val_print): Update.
12286         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12287         (create_excep_cond_exprs): Update.
12288
12289 2019-04-08  Tom Tromey  <tom@tromey.com>
12290
12291         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12292         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12293         (TRY, CATCH, END_CATCH): Remove some definitions.
12294         * common/common-exceptions.c: Don't use GDB_XCPT.
12295         (catcher_list_size): Remove.
12296         (throw_exception, throw_it): Simplify.
12297
12298 2019-04-05  Tom Tromey  <tom@tromey.com>
12299
12300         Revert the header-sorting patch.
12301         * ft32-tdep.c: Revert.
12302         * frv-tdep.c: Revert.
12303         * frv-linux-tdep.c: Revert.
12304         * frame.c: Revert.
12305         * frame-unwind.c: Revert.
12306         * frame-base.c: Revert.
12307         * fork-child.c: Revert.
12308         * findvar.c: Revert.
12309         * findcmd.c: Revert.
12310         * filesystem.c: Revert.
12311         * filename-seen-cache.h: Revert.
12312         * filename-seen-cache.c: Revert.
12313         * fbsd-tdep.c: Revert.
12314         * fbsd-nat.h: Revert.
12315         * fbsd-nat.c: Revert.
12316         * f-valprint.c: Revert.
12317         * f-typeprint.c: Revert.
12318         * f-lang.c: Revert.
12319         * extension.h: Revert.
12320         * extension.c: Revert.
12321         * extension-priv.h: Revert.
12322         * expprint.c: Revert.
12323         * exec.h: Revert.
12324         * exec.c: Revert.
12325         * exceptions.c: Revert.
12326         * event-top.c: Revert.
12327         * event-loop.c: Revert.
12328         * eval.c: Revert.
12329         * elfread.c: Revert.
12330         * dwarf2read.h: Revert.
12331         * dwarf2read.c: Revert.
12332         * dwarf2loc.c: Revert.
12333         * dwarf2expr.h: Revert.
12334         * dwarf2expr.c: Revert.
12335         * dwarf2-frame.c: Revert.
12336         * dwarf2-frame-tailcall.c: Revert.
12337         * dwarf-index-write.h: Revert.
12338         * dwarf-index-write.c: Revert.
12339         * dwarf-index-common.c: Revert.
12340         * dwarf-index-cache.h: Revert.
12341         * dwarf-index-cache.c: Revert.
12342         * dummy-frame.c: Revert.
12343         * dtrace-probe.c: Revert.
12344         * disasm.h: Revert.
12345         * disasm.c: Revert.
12346         * disasm-selftests.c: Revert.
12347         * dictionary.c: Revert.
12348         * dicos-tdep.c: Revert.
12349         * demangle.c: Revert.
12350         * dcache.h: Revert.
12351         * dcache.c: Revert.
12352         * darwin-nat.h: Revert.
12353         * darwin-nat.c: Revert.
12354         * darwin-nat-info.c: Revert.
12355         * d-valprint.c: Revert.
12356         * d-namespace.c: Revert.
12357         * d-lang.c: Revert.
12358         * ctf.c: Revert.
12359         * csky-tdep.c: Revert.
12360         * csky-linux-tdep.c: Revert.
12361         * cris-tdep.c: Revert.
12362         * cris-linux-tdep.c: Revert.
12363         * cp-valprint.c: Revert.
12364         * cp-support.c: Revert.
12365         * cp-namespace.c: Revert.
12366         * cp-abi.c: Revert.
12367         * corelow.c: Revert.
12368         * corefile.c: Revert.
12369         * continuations.c: Revert.
12370         * completer.h: Revert.
12371         * completer.c: Revert.
12372         * complaints.c: Revert.
12373         * coffread.c: Revert.
12374         * coff-pe-read.c: Revert.
12375         * cli-out.h: Revert.
12376         * cli-out.c: Revert.
12377         * charset.c: Revert.
12378         * c-varobj.c: Revert.
12379         * c-valprint.c: Revert.
12380         * c-typeprint.c: Revert.
12381         * c-lang.c: Revert.
12382         * buildsym.c: Revert.
12383         * buildsym-legacy.c: Revert.
12384         * build-id.h: Revert.
12385         * build-id.c: Revert.
12386         * btrace.c: Revert.
12387         * bsd-uthread.c: Revert.
12388         * breakpoint.h: Revert.
12389         * breakpoint.c: Revert.
12390         * break-catch-throw.c: Revert.
12391         * break-catch-syscall.c: Revert.
12392         * break-catch-sig.c: Revert.
12393         * blockframe.c: Revert.
12394         * block.c: Revert.
12395         * bfin-tdep.c: Revert.
12396         * bfin-linux-tdep.c: Revert.
12397         * bfd-target.c: Revert.
12398         * bcache.c: Revert.
12399         * ax-general.c: Revert.
12400         * ax-gdb.h: Revert.
12401         * ax-gdb.c: Revert.
12402         * avr-tdep.c: Revert.
12403         * auxv.c: Revert.
12404         * auto-load.c: Revert.
12405         * arm-wince-tdep.c: Revert.
12406         * arm-tdep.c: Revert.
12407         * arm-symbian-tdep.c: Revert.
12408         * arm-pikeos-tdep.c: Revert.
12409         * arm-obsd-tdep.c: Revert.
12410         * arm-nbsd-tdep.c: Revert.
12411         * arm-nbsd-nat.c: Revert.
12412         * arm-linux-tdep.c: Revert.
12413         * arm-linux-nat.c: Revert.
12414         * arm-fbsd-tdep.c: Revert.
12415         * arm-fbsd-nat.c: Revert.
12416         * arm-bsd-tdep.c: Revert.
12417         * arch-utils.c: Revert.
12418         * arc-tdep.c: Revert.
12419         * arc-newlib-tdep.c: Revert.
12420         * annotate.h: Revert.
12421         * annotate.c: Revert.
12422         * amd64-windows-tdep.c: Revert.
12423         * amd64-windows-nat.c: Revert.
12424         * amd64-tdep.c: Revert.
12425         * amd64-sol2-tdep.c: Revert.
12426         * amd64-obsd-tdep.c: Revert.
12427         * amd64-obsd-nat.c: Revert.
12428         * amd64-nbsd-tdep.c: Revert.
12429         * amd64-nbsd-nat.c: Revert.
12430         * amd64-nat.c: Revert.
12431         * amd64-linux-tdep.c: Revert.
12432         * amd64-linux-nat.c: Revert.
12433         * amd64-fbsd-tdep.c: Revert.
12434         * amd64-fbsd-nat.c: Revert.
12435         * amd64-dicos-tdep.c: Revert.
12436         * amd64-darwin-tdep.c: Revert.
12437         * amd64-bsd-nat.c: Revert.
12438         * alpha-tdep.c: Revert.
12439         * alpha-obsd-tdep.c: Revert.
12440         * alpha-nbsd-tdep.c: Revert.
12441         * alpha-mdebug-tdep.c: Revert.
12442         * alpha-linux-tdep.c: Revert.
12443         * alpha-linux-nat.c: Revert.
12444         * alpha-bsd-tdep.c: Revert.
12445         * alpha-bsd-nat.c: Revert.
12446         * aix-thread.c: Revert.
12447         * agent.c: Revert.
12448         * addrmap.c: Revert.
12449         * ada-varobj.c: Revert.
12450         * ada-valprint.c: Revert.
12451         * ada-typeprint.c: Revert.
12452         * ada-tasks.c: Revert.
12453         * ada-lang.c: Revert.
12454         * aarch64-tdep.c: Revert.
12455         * aarch64-ravenscar-thread.c: Revert.
12456         * aarch64-newlib-tdep.c: Revert.
12457         * aarch64-linux-tdep.c: Revert.
12458         * aarch64-linux-nat.c: Revert.
12459         * aarch64-fbsd-tdep.c: Revert.
12460         * aarch64-fbsd-nat.c: Revert.
12461         * aarch32-linux-nat.c: Revert.
12462
12463 2019-04-05  Tom Tromey  <tom@tromey.com>
12464
12465         * ft32-tdep.c: Sort headers.
12466         * frv-tdep.c: Sort headers.
12467         * frv-linux-tdep.c: Sort headers.
12468         * frame.c: Sort headers.
12469         * frame-unwind.c: Sort headers.
12470         * frame-base.c: Sort headers.
12471         * fork-child.c: Sort headers.
12472         * findvar.c: Sort headers.
12473         * findcmd.c: Sort headers.
12474         * filesystem.c: Sort headers.
12475         * filename-seen-cache.h: Sort headers.
12476         * filename-seen-cache.c: Sort headers.
12477         * fbsd-tdep.c: Sort headers.
12478         * fbsd-nat.h: Sort headers.
12479         * fbsd-nat.c: Sort headers.
12480         * f-valprint.c: Sort headers.
12481         * f-typeprint.c: Sort headers.
12482         * f-lang.c: Sort headers.
12483         * extension.h: Sort headers.
12484         * extension.c: Sort headers.
12485         * extension-priv.h: Sort headers.
12486         * expprint.c: Sort headers.
12487         * exec.h: Sort headers.
12488         * exec.c: Sort headers.
12489         * exceptions.c: Sort headers.
12490         * event-top.c: Sort headers.
12491         * event-loop.c: Sort headers.
12492         * eval.c: Sort headers.
12493         * elfread.c: Sort headers.
12494         * dwarf2read.h: Sort headers.
12495         * dwarf2read.c: Sort headers.
12496         * dwarf2loc.c: Sort headers.
12497         * dwarf2expr.h: Sort headers.
12498         * dwarf2expr.c: Sort headers.
12499         * dwarf2-frame.c: Sort headers.
12500         * dwarf2-frame-tailcall.c: Sort headers.
12501         * dwarf-index-write.h: Sort headers.
12502         * dwarf-index-write.c: Sort headers.
12503         * dwarf-index-common.c: Sort headers.
12504         * dwarf-index-cache.h: Sort headers.
12505         * dwarf-index-cache.c: Sort headers.
12506         * dummy-frame.c: Sort headers.
12507         * dtrace-probe.c: Sort headers.
12508         * disasm.h: Sort headers.
12509         * disasm.c: Sort headers.
12510         * disasm-selftests.c: Sort headers.
12511         * dictionary.c: Sort headers.
12512         * dicos-tdep.c: Sort headers.
12513         * demangle.c: Sort headers.
12514         * dcache.h: Sort headers.
12515         * dcache.c: Sort headers.
12516         * darwin-nat.h: Sort headers.
12517         * darwin-nat.c: Sort headers.
12518         * darwin-nat-info.c: Sort headers.
12519         * d-valprint.c: Sort headers.
12520         * d-namespace.c: Sort headers.
12521         * d-lang.c: Sort headers.
12522         * ctf.c: Sort headers.
12523         * csky-tdep.c: Sort headers.
12524         * csky-linux-tdep.c: Sort headers.
12525         * cris-tdep.c: Sort headers.
12526         * cris-linux-tdep.c: Sort headers.
12527         * cp-valprint.c: Sort headers.
12528         * cp-support.c: Sort headers.
12529         * cp-namespace.c: Sort headers.
12530         * cp-abi.c: Sort headers.
12531         * corelow.c: Sort headers.
12532         * corefile.c: Sort headers.
12533         * continuations.c: Sort headers.
12534         * completer.h: Sort headers.
12535         * completer.c: Sort headers.
12536         * complaints.c: Sort headers.
12537         * coffread.c: Sort headers.
12538         * coff-pe-read.c: Sort headers.
12539         * cli-out.h: Sort headers.
12540         * cli-out.c: Sort headers.
12541         * charset.c: Sort headers.
12542         * c-varobj.c: Sort headers.
12543         * c-valprint.c: Sort headers.
12544         * c-typeprint.c: Sort headers.
12545         * c-lang.c: Sort headers.
12546         * buildsym.c: Sort headers.
12547         * buildsym-legacy.c: Sort headers.
12548         * build-id.h: Sort headers.
12549         * build-id.c: Sort headers.
12550         * btrace.c: Sort headers.
12551         * bsd-uthread.c: Sort headers.
12552         * breakpoint.h: Sort headers.
12553         * breakpoint.c: Sort headers.
12554         * break-catch-throw.c: Sort headers.
12555         * break-catch-syscall.c: Sort headers.
12556         * break-catch-sig.c: Sort headers.
12557         * blockframe.c: Sort headers.
12558         * block.c: Sort headers.
12559         * bfin-tdep.c: Sort headers.
12560         * bfin-linux-tdep.c: Sort headers.
12561         * bfd-target.c: Sort headers.
12562         * bcache.c: Sort headers.
12563         * ax-general.c: Sort headers.
12564         * ax-gdb.h: Sort headers.
12565         * ax-gdb.c: Sort headers.
12566         * avr-tdep.c: Sort headers.
12567         * auxv.c: Sort headers.
12568         * auto-load.c: Sort headers.
12569         * arm-wince-tdep.c: Sort headers.
12570         * arm-tdep.c: Sort headers.
12571         * arm-symbian-tdep.c: Sort headers.
12572         * arm-pikeos-tdep.c: Sort headers.
12573         * arm-obsd-tdep.c: Sort headers.
12574         * arm-nbsd-tdep.c: Sort headers.
12575         * arm-nbsd-nat.c: Sort headers.
12576         * arm-linux-tdep.c: Sort headers.
12577         * arm-linux-nat.c: Sort headers.
12578         * arm-fbsd-tdep.c: Sort headers.
12579         * arm-fbsd-nat.c: Sort headers.
12580         * arm-bsd-tdep.c: Sort headers.
12581         * arch-utils.c: Sort headers.
12582         * arc-tdep.c: Sort headers.
12583         * arc-newlib-tdep.c: Sort headers.
12584         * annotate.h: Sort headers.
12585         * annotate.c: Sort headers.
12586         * amd64-windows-tdep.c: Sort headers.
12587         * amd64-windows-nat.c: Sort headers.
12588         * amd64-tdep.c: Sort headers.
12589         * amd64-sol2-tdep.c: Sort headers.
12590         * amd64-obsd-tdep.c: Sort headers.
12591         * amd64-obsd-nat.c: Sort headers.
12592         * amd64-nbsd-tdep.c: Sort headers.
12593         * amd64-nbsd-nat.c: Sort headers.
12594         * amd64-nat.c: Sort headers.
12595         * amd64-linux-tdep.c: Sort headers.
12596         * amd64-linux-nat.c: Sort headers.
12597         * amd64-fbsd-tdep.c: Sort headers.
12598         * amd64-fbsd-nat.c: Sort headers.
12599         * amd64-dicos-tdep.c: Sort headers.
12600         * amd64-darwin-tdep.c: Sort headers.
12601         * amd64-bsd-nat.c: Sort headers.
12602         * alpha-tdep.c: Sort headers.
12603         * alpha-obsd-tdep.c: Sort headers.
12604         * alpha-nbsd-tdep.c: Sort headers.
12605         * alpha-mdebug-tdep.c: Sort headers.
12606         * alpha-linux-tdep.c: Sort headers.
12607         * alpha-linux-nat.c: Sort headers.
12608         * alpha-bsd-tdep.c: Sort headers.
12609         * alpha-bsd-nat.c: Sort headers.
12610         * aix-thread.c: Sort headers.
12611         * agent.c: Sort headers.
12612         * addrmap.c: Sort headers.
12613         * ada-varobj.c: Sort headers.
12614         * ada-valprint.c: Sort headers.
12615         * ada-typeprint.c: Sort headers.
12616         * ada-tasks.c: Sort headers.
12617         * ada-lang.c: Sort headers.
12618         * aarch64-tdep.c: Sort headers.
12619         * aarch64-ravenscar-thread.c: Sort headers.
12620         * aarch64-newlib-tdep.c: Sort headers.
12621         * aarch64-linux-tdep.c: Sort headers.
12622         * aarch64-linux-nat.c: Sort headers.
12623         * aarch64-fbsd-tdep.c: Sort headers.
12624         * aarch64-fbsd-nat.c: Sort headers.
12625         * aarch32-linux-nat.c: Sort headers.
12626
12627 2019-04-04  Tom Tromey  <tom@tromey.com>
12628
12629         * varobj.c (varobj_create): Update.
12630         * rust-exp.y (struct rust_parser) <update_innermost_block,
12631         lookup_symbol>: New methods.
12632         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12633         Rename.
12634         (rust_parser::rust_lookup_type)
12635         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12636         * printcmd.c (display_command, do_one_display): Update.
12637         * parser-defs.h (struct parser_state) <parser_state>: Add
12638         "tracker" parameter.
12639         (block_tracker): New member.
12640         (class innermost_block_tracker) <innermost_block_tracker>: Add
12641         "types" parameter.
12642         <reset>: Remove method.
12643         (innermost_block): Don't declare.
12644         (null_post_parser): Update.
12645         * parse.c (innermost_block): Remove global.
12646         (write_dollar_variable): Update.
12647         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12648         Remove "tracker_types" parameter.
12649         (parse_expression): Add "tracker" parameter.
12650         (parse_expression_for_completion): Update.
12651         (null_post_parser): Add "tracker" parameter.
12652         * p-exp.y: Update rules.
12653         * m2-exp.y: Update rules.
12654         * language.h (struct language_defn) <la_post_parser>: Add
12655         "tracker" parameter.
12656         * go-exp.y: Update rules.
12657         * f-exp.y: Update rules.
12658         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12659         parameter.
12660         * d-exp.y: Update rules.
12661         * c-exp.y: Update rules.
12662         * breakpoint.c (set_breakpoint_condition): Create an
12663         innermost_block_tracker.
12664         (watch_command_1): Likewise.
12665         * ada-lang.c (resolve): Add "tracker" parameter.
12666         (resolve_subexp): Likewise.
12667         * ada-exp.y (write_var_from_sym): Update.
12668
12669 2019-04-04  Tom Tromey  <tom@tromey.com>
12670
12671         * type-stack.h: New file.
12672         * type-stack.c: New file.
12673         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12674         type-stack.h.
12675         (insert_into_type_stack, insert_type, push_type, push_type_int)
12676         (insert_type_address_space, pop_type, pop_type_int)
12677         (pop_typelist, pop_type_stack, append_type_stack)
12678         (push_type_stack, get_type_stack, push_typelist)
12679         (follow_type_instance_flags, follow_types): Don't declare.
12680         * parse.c (type_stack): Remove global.
12681         (parse_exp_in_context): Update.
12682         (insert_into_type_stack, insert_type, push_type, push_type_int)
12683         (insert_type_address_space, pop_type, pop_type_int)
12684         (pop_typelist, pop_type_stack, append_type_stack)
12685         (push_type_stack, get_type_stack, push_typelist)
12686         (follow_type_instance_flags, follow_types): Remove (moved to
12687         type-stack.c).
12688         * f-exp.y (type_stack): New global.
12689         Update rules.
12690         (push_kind_type, f_parse): Update.
12691         * d-exp.y (type_stack): New global.
12692         Update rules.
12693         (d_parse): Update.
12694         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12695         Update rules.
12696         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12697         (HFILES_NO_SRCDIR): Add type-stack.h.
12698
12699 2019-04-04  Tom Tromey  <tom@tromey.com>
12700
12701         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12702         (rust_parser::convert_ast_to_expression, rust_parse)
12703         (rust_lex_test_completion, rust_lex_tests): Update.
12704         * parser-defs.h (struct expr_completion_state): New.
12705         (struct parser_state) <parser_state>: Add completion parameter.
12706         <mark_struct_expression, mark_completion_tag>: New methods.
12707         <parse_completion, m_completion_state>: New members.
12708         (prefixify_expression, null_post_parser): Update.
12709         (mark_struct_expression, mark_completion_tag): Don't declare.
12710         * parse.c (parse_completion, expout_last_struct)
12711         (expout_tag_completion_type, expout_completion_name): Remove
12712         globals.
12713         (parser_state::mark_struct_expression)
12714         (parser_state::mark_completion_tag): Now methods.
12715         (prefixify_expression): Add last_struct parameter.
12716         (prefixify_subexp): Likewise.
12717         (parse_exp_1): Update.
12718         (parse_exp_in_context): Add cstate parameter.  Update.
12719         (parse_expression_for_completion): Create an
12720         expr_completion_state.
12721         (null_post_parser): Add "completion" parameter.
12722         * p-exp.y: Update rules.
12723         (yylex): Update.
12724         * language.h (struct language_defn) <la_post_parser>: Add
12725         "completing" parameter.
12726         * go-exp.y: Update rules.
12727         (lex_one_token): Update.
12728         * expression.h (parse_completion): Don't declare.
12729         * d-exp.y: Update rules.
12730         (lex_one_token): Update rules.
12731         * c-exp.y: Update rules.
12732         (lex_one_token): Update.
12733         * ada-lang.c (resolve): Add "parse_completion" parameter.
12734         (resolve_subexp): Likewise.
12735         (ada_resolve_function): Likewise.
12736
12737 2019-04-04  Tom Tromey  <tom@tromey.com>
12738
12739         * parser-defs.h (struct parser_state) <start_arglist,
12740         end_arglist>: New methods.
12741         <arglist_len, m_funcall_chain>: New members.
12742         (arglist_len, start_arglist, end_arglist): Don't declare.
12743         * parse.c (arglist_len, funcall_chain): Remove global.
12744         (start_arglist, end_arglist): Remove functions.
12745         (parse_exp_in_context): Update.
12746         * p-exp.y: Update rules.
12747         * m2-exp.y: Update rules.
12748         * go-exp.y: Update rules.
12749         * f-exp.y: Update rules.
12750         * d-exp.y: Update rules.
12751         * c-exp.y: Update rules.
12752
12753 2019-04-04  Tom Tromey  <tom@tromey.com>
12754
12755         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12756         lex_operator, push_back>: New methods.
12757         Update all rules.
12758         (rust_parser::lex_hex, lex_escape): Rename and update.
12759         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12760         (rust_parser::lex_operator): Rename and update.
12761         (rust_parser::lex_number, rustyylex, rustyyerror)
12762         (rust_lex_test_init, rust_lex_test_sequence)
12763         (rust_lex_test_push_back, rust_lex_tests): Update.
12764         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12765         parameter.
12766         <lexptr, prev_lexptr>: New members.
12767         (lexptr, prev_lexptr): Don't declare.
12768         * parse.c (lexptr, prev_lexptr): Remove globals.
12769         (parse_exp_in_context): Update.
12770         * p-exp.y (yylex, yyerror): Update.
12771         * m2-exp.y (parse_number, yylex, yyerror): Update.
12772         * go-exp.y (lex_one_token, yyerror): Update.
12773         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12774         * d-exp.y (lex_one_token, yyerror): Update.
12775         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12776         (lex_one_token, yyerror): Update.
12777         * ada-lex.l (YY_INPUT): Update.
12778         (rewind_to_char): Update.
12779         * ada-exp.y (yyerror): Update.
12780
12781 2019-04-04  Tom Tromey  <tom@tromey.com>
12782
12783         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12784         * parser-defs.h (struct parser_state) <parser_state>: Add new
12785         parameter.
12786         <comma_terminates>: New member.
12787         (comma_terminates): Don't declare global.
12788         * parse.c (comma_terminates): Remove global.
12789         (parse_exp_in_context): Update.
12790         * p-exp.y (yylex): Update.
12791         * m2-exp.y (yylex): Update.
12792         * go-exp.y (lex_one_token): Update.
12793         * f-exp.y (yylex): Update.
12794         * d-exp.y (lex_one_token): Update.
12795         * c-exp.y (lex_one_token): Update.
12796         * ada-lex.l: Update.
12797
12798 2019-04-04  Tom Tromey  <tom@tromey.com>
12799
12800         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12801         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12802         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12803         * parser-defs.h (paren_depth): Don't declare.
12804         * parse.c (paren_depth): Remove global.
12805         (parse_exp_in_context): Update.
12806         * p-exp.y (paren_depth): New global.
12807         (pascal_parse): Initialize it.
12808         * m2-exp.y (paren_depth): New global.
12809         (m2_parse): Initialize it.
12810         * go-exp.y (paren_depth): New global.
12811         (go_parse): Initialize it.
12812         * f-exp.y (paren_depth): New global.
12813         (f_parse): Initialize it.
12814         * d-exp.y (paren_depth): New global.
12815         (d_parse): Initialize it.
12816         * c-exp.y (paren_depth): New global.
12817         (c_parse): Initialize it.
12818         * ada-lex.l (paren_depth): New global.
12819         (lexer_init): Initialize it.
12820
12821 2019-04-04  Tom Tromey  <tom@tromey.com>
12822
12823         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12824         (rust_parser::convert_ast_to_type)
12825         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12826         * parser-defs.h (struct parser_state) <parser_state>: Add
12827         parameters.  Initialize new members.
12828         <expression_context_block, expression_context_pc>: New members.
12829         * parse.c (expression_context_block, expression_context_pc):
12830         Remove globals.
12831         (parse_exp_in_context): Update.
12832         * p-exp.y: Update all rules.
12833         (yylex): Update.
12834         * m2-exp.y: Update all rules.
12835         (yylex): Update.
12836         * go-exp.y (yylex): Update.
12837         * f-exp.y (yylex): Update.
12838         * d-exp.y: Update all rules.
12839         (yylex): Update.
12840         * c-exp.y: Update all rules.
12841         (lex_one_token, classify_name, yylex, c_parse): Update.
12842         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12843
12844 2019-04-04  Tom Tromey  <tom@tromey.com>
12845
12846         * gdbarch.h, gdbarch.c: Rebuild.
12847         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12848         * stap-probe.h:
12849         (struct stap_parse_info): Replace "parser_state" with
12850         "expr_builder".
12851         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12852         (parser_state): New class.
12853         * parse.c (expr_builder): Rename.
12854         (expr_builder::release): Rename.
12855         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12856         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12857         (write_exp_elt_longcst, write_exp_elt_floatcst)
12858         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12859         (write_exp_string_vector, write_exp_bitstring)
12860         (write_exp_msymbol, mark_struct_expression)
12861         (write_dollar_variable)
12862         (insert_type_address_space, increase_expout_size): Replace
12863         "parser_state" with "expr_builder".
12864         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12865         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12866         "parser_state" with "expr_builder".
12867
12868 2019-04-04  Tom Tromey  <tom@tromey.com>
12869
12870         * rust-exp.y: Replace "parse_language" with method call.
12871         * p-exp.y:
12872         (yylex): Replace "parse_language" with method call.
12873         * m2-exp.y:
12874         (yylex): Replace "parse_language" with method call.
12875         * go-exp.y (classify_name): Replace "parse_language" with method
12876         call.
12877         * f-exp.y (yylex): Replace "parse_language" with method call.
12878         * d-exp.y (lex_one_token): Replace "parse_language" with method
12879         call.
12880         * c-exp.y:
12881         (lex_one_token, classify_name, yylex): Replace "parse_language"
12882         with method call.
12883         * ada-exp.y (find_primitive_type, type_char)
12884         (type_system_address): Replace "parse_language" with method call.
12885
12886 2019-04-04  Tom Tromey  <tom@tromey.com>
12887
12888         * rust-exp.y: Replace "parse_gdbarch" with method call.
12889         * parse.c (write_dollar_variable, insert_type_address_space):
12890         Replace "parse_gdbarch" with method call.
12891         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12892         call.
12893         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12894         call.
12895         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12896         "parse_gdbarch" with method call.
12897         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12898         with method call.
12899         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12900         "parse_gdbarch" with method call.
12901         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12902         "parse_gdbarch" with method call.
12903         * c-exp.y (parse_type, parse_number, classify_name): Replace
12904         "parse_gdbarch" with method call.
12905         * ada-lex.l: Replace "parse_gdbarch" with method call.
12906         * ada-exp.y (parse_type, find_primitive_type, type_char)
12907         (type_system_address): Replace "parse_gdbarch" with method call.
12908
12909 2019-04-04  Tom Tromey  <tom@tromey.com>
12910
12911         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12912         * stap-probe.c (stap_parse_argument): Update.
12913         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12914         initial_size parameter.
12915         * rust-exp.y (rust_lex_tests): Update.
12916         * parse.c (parser_state): Update.
12917         (parse_exp_in_context): Update.
12918         * parser-defs.h (struct parser_state) <parser_state>: Remove
12919         "initial_size" parameter.
12920
12921 2019-04-04  Tom Tromey  <tom@tromey.com>
12922
12923         * parser-defs.h (increase_expout_size): Don't declare.
12924         * parse.c (increase_expout_size): Now static.
12925
12926 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12927
12928         * gnu-nat.c (gnu_nat_target::wait): Fix
12929         target_waitstatus_to_string call.
12930
12931 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12932
12933         * eval.c (evaluate_subexp_standard): Handle internal functions
12934         during Fortran function call handling.
12935
12936 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12937
12938         * NEWS: Mention new internal functions.
12939         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12940         (read_base_type): Use dwarf2_init_complex_target_type.
12941         * value.c (creal_internal_fn): New function.
12942         (cimag_internal_fn): New function.
12943         (_initialize_values): Register new internal functions.
12944
12945 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12946
12947         * infrun.c (stop_all_threads): If debug_infrun, always
12948         trace the wait status after wait_one, using
12949         target_waitstatus_to_string and target_pid_to_str.
12950         (handle_inferior_event): Replace various trace of
12951         wait status kind by a single trace.
12952         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12953         wait status kind image by target_waitstatus_to_string.
12954         * target/waitstatus.c (target_waitstatus_to_string): Fix
12955         obsolete comment.
12956
12957 2019-04-01  Tom Tromey  <tromey@adacore.com>
12958
12959         PR symtab/23331:
12960         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12961
12962 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12963             Pedro Alves  <palves@redhat.com>
12964
12965         * top.c (quit_force): Call 'finalize_values'.
12966         * value.c (finalize_values): New function.
12967         * value.h (finalize_values): Declare.
12968
12969 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
12970
12971         * NEWS: Announce $_gdb_major and $_gdb_minor.
12972
12973         * top.c (init_gdb_version_vars): New function.
12974         (gdb_init): Call init_gdb_version_vars.
12975
12976 2019-03-29  Tom Tromey  <tromey@adacore.com>
12977
12978         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12979         help text.  Remove dead code.
12980
12981 2019-03-29  Keith Seitz  <keiths@redhat.com>
12982
12983         From Siddhesh Poyarekar:
12984         * f-lang.h (f77_get_upperbound): Return LONGEST.
12985         (f77_get_lowerbound): Likewise.
12986         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12987         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12988         print them.
12989         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12990         plongest to format print it.
12991         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12992         (f77_get_upperbound): Likewise.
12993         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12994         LOWER_BOUND to LONGEST.
12995         (f77_create_arrayprint_offset_tbl): Likewise.
12996
12997 2019-03-29  Keith Seitz  <keiths@redhat.com>
12998
12999         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13000         %s/pulongest for TYPE_LENGTH instead of %d in format
13001         strings.
13002         * ada-typerint.c (ada_print_type): Likewise.
13003         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13004         * compile/compile-c-support.c (generate_register_struct): Likewise.
13005         * gdbtypes.c (recursive_dump_type): Likewise.
13006         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13007         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
13008         instead of %d in format strings.
13009         * riscv-tdep.c (riscv_type_alignment): Cast second argument
13010         to std::min to ULONGEST.
13011         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13012         instead of %d in format strings.
13013         * tracepoint.c (info_scope_command): Likewise.
13014         * typeprint.c (print_offset_data::update)
13015         (print_offset_data::finish): Likewise.
13016         * xtensa-tdep.c (xtensa_store_return_value)
13017         (xtensa_push_dummy_call): Likewise.
13018
13019 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
13020
13021         * windows-nat.c (display_selector): Fixed format specifications
13022         for 64-bit Cygwin.
13023
13024 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13025
13026         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13027
13028 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
13029
13030         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13031         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13032         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13033         (nios2_linux_init_abi): Install it.
13034
13035 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13036
13037         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13038
13039 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13040
13041         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13042
13043 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13044             Tom Tromey  <tromey@adacore.com>
13045
13046         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13047
13048 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
13049
13050         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13051         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13052         method to compute the bounds of range types. Also print "[evaluated]"
13053         if the bounds' values come from a dynamic evaluation.
13054
13055 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13056
13057         * cp-valprint.c (cp_print_value_fields): Don't print trailing
13058         whitespace when pretty printing is on.
13059
13060 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13061
13062         * ppc-linux-nat.c: Add include.
13063
13064 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13065
13066         * NEWS: Mention AArch64 Pointer Authentication.
13067
13068 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13069
13070         * arm-linux-nat.c: Add include.
13071
13072 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
13073
13074         * source-cache.c (source_cache::get_source_lines): Re-read
13075         fullname after calling open_source_file.
13076
13077 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
13078
13079         * NEWS: Mention TLS support for FreeBSD.
13080
13081 2019-03-25  Tom Tromey  <tromey@adacore.com>
13082
13083         * minsyms.c (BUNCH_SIZE): Update comment.
13084         (~minimal_symbol_reader): Remove old comment.
13085         (compact_minimal_symbols): Update comment.
13086         (minimal_symbol_reader::install): Remove old comment.  Update
13087         other comments.
13088
13089 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13090
13091         * s390-linux-nat.c: Add include.
13092
13093 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13094
13095         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13096         Call linux_get_hwcap.
13097         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13098         Likewise.
13099         (aarch64_linux_get_hwcap): Remove function.
13100         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13101         declaration.
13102         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13103         linux_get_hwcap.
13104         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13105         * linux-tdep.c (linux_get_hwcap): Add function.
13106         (linux_get_hwcap2): Likewise.
13107         * linux-tdep.h (linux_get_hwcap): Add declaration.
13108         (linux_get_hwcap2): Likewise.
13109         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13110         (ppc_linux_get_hwcap2): Likewise.
13111         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13112         linux_get_hwcap.
13113         (ppc_linux_nat_target::insert_watchpoint): Likewise.
13114         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13115         (ppc_linux_nat_target::read_description): Likewise.
13116         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13117         * s390-linux-nat.c: Likewise.
13118         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13119
13120 2019-03-24  Tom Tromey  <tom@tromey.com>
13121
13122         * ada-lang.c (standard_lookup): Simplify initialization.
13123         (ada_lookup_symbol_nonlocal): Simplify return.
13124         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13125         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13126         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13127         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13128         initialization.
13129         * solib.c (solib_global_lookup): Simplify.
13130         * symtab.c (null_block_symbol): Remove.
13131         (symbol_cache_lookup): Simplify returns.
13132         (lookup_language_this): Simplify returns.
13133         (lookup_symbol_aux): Simplify return.
13134         (lookup_local_symbol): Simplify returns.
13135         (lookup_global_symbol_from_objfile): Simplify return.
13136         (lookup_symbol_in_objfile_symtabs)
13137         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13138         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13139         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13140         * cp-namespace.c (cp_lookup_bare_symbol)
13141         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13142         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13143         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13144         (cp_lookup_symbol_via_imports): Simplify initialization.
13145         (find_symbol_in_baseclass): Likewise.
13146         * symtab.h (null_block_symbol): Remove.
13147         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13148         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13149         (d_lookup_symbol_module): Likewise.
13150         (find_symbol_in_baseclass): Simplify initialization.
13151
13152 2019-03-24  Tom Tromey  <tom@tromey.com>
13153
13154         * expression.h: Don't include symtab.h.
13155         (struct block): Forward declare.
13156
13157 2019-03-24  Tom Tromey  <tom@tromey.com>
13158
13159         * c-exp.y (typebase): Remove casts.
13160         * gdbtypes.c (lookup_unsigned_typename, )
13161         (lookup_signed_typename): Remove cast.
13162         * eval.c (parse_to_comma_and_eval): Remove cast.
13163         * parse.c (write_dollar_variable): Remove cast.
13164         * block.h (struct block) <superblock>: Now const.
13165         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13166         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13167         (map_block): Make "block" const.
13168         * symfile.h (struct quick_symbol_functions)
13169         <map_matching_symbols>: Constify block argument to "callback".
13170         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13171         const.
13172         (find_pc_sect_compunit_symtab): Make "b" const.
13173         (find_symbol_at_address): Likewise.
13174         (search_symbols): Likewise.
13175         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13176         (dw2_debug_names_lookup_symbol): Likewise.
13177         (dw2_map_matching_symbols): Update.
13178         * p-valprint.c (pascal_val_print): Remove "block".
13179         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13180         (aux_add_nonlocal_symbols): Make "block" const.
13181         (resolve_subexp): Remove cast.
13182         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13183         const.
13184         (iterate_over_file_blocks): Likewise.
13185         * f-exp.y (%union) <bval>: Remove.
13186         * coffread.c (patch_opaque_types): Make "b" const.
13187         * spu-tdep.c (spu_catch_start): Make "block" const.
13188         * c-valprint.c (print_unpacked_pointer): Remove "block".
13189         * symmisc.c (dump_symtab_1): Make "b" const.
13190         (block_depth): Make "block" const.
13191         * d-exp.y (%union) <bval>: Remove.
13192         * cp-support.h (cp_lookup_rtti_type): Update.
13193         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13194         * psymtab.c (psym_lookup_symbol): Make "block" const.
13195         (maintenance_check_psymtabs): Make "b" const.
13196         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13197         (enumerate_locals, enumerate_args): Update.
13198         * python/py-symtab.c (stpy_global_block): Make "block" const.
13199         (stpy_static_block): Likewise.
13200         * inline-frame.c (block_starting_point_at): Make "new_block"
13201         const.
13202         * block.c (find_block_in_blockvector): Make return type const.
13203         (blockvector_for_pc_sect): Make "b" const.
13204         (find_block_in_blockvector): Make "b" const.
13205
13206 2019-03-23  Tom Tromey  <tom@tromey.com>
13207
13208         * varobj.c (varobj_create): Update.
13209         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13210         * printcmd.c (display_command, do_one_display): Don't reset
13211         innermost_block.
13212         * parser-defs.h (enum innermost_block_tracker_type): Move to
13213         expression.h.
13214         (innermost_block): Update comment.
13215         * parse.c (parse_exp_1): Add tracker_types parameter.
13216         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13217         tracker_types parameter.  Reset innermost_block.
13218         (parse_exp_in_context): Remove.
13219         (parse_expression_for_completion): Update.
13220         * objfiles.c (~objfile): Don't reset expression_context_block or
13221         innermost_block.
13222         * expression.h (enum innermost_block_tracker_type): Move from
13223         parser-defs.h.
13224         (parse_exp_1): Add tracker_types parameter.
13225         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13226         reset innermost_block.
13227
13228 2019-03-23  Tom Tromey  <tom@tromey.com>
13229
13230         * objfiles.h: Include bcache.h.
13231
13232 2019-03-23  Tom Tromey  <tom@tromey.com>
13233
13234         * linespec.c (get_current_search_block): Use
13235         scoped_restore_current_language.
13236         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13237
13238 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13239             Jiong Wang  <jiong.wang@arm.com>
13240
13241         * aarch64-linux-tdep.c
13242         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13243         section.
13244         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13245
13246 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13247             Jiong Wang  <jiong.wang@arm.com>
13248
13249         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13250         instructions.
13251         (aarch64_analyze_prologue_test): Add PACIASP test.
13252         (aarch64_prologue_prev_register): Unmask PC value.
13253
13254 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13255             Jiong Wang  <jiong.wang@arm.com>
13256
13257         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13258         (aarch64_dwarf2_prev_register): Unmask PC value.
13259         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13260         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13261         DW_CFA_AARCH64_negate_ra_state.
13262         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13263
13264 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13265             Jiong Wang  <jiong.wang@arm.com>
13266
13267         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13268         registers.
13269         (aarch64_pseudo_register_name): Likewise.
13270         (aarch64_pseudo_register_type): Likewise.
13271         (aarch64_pseudo_register_reggroup_p): Likewise.
13272         (aarch64_gdbarch_init): Add pauth registers.
13273         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13274         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13275         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13276         (struct gdbarch_tdep): Add regnum for ra_state.
13277
13278 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13279             Jiong Wang  <jiong.wang@arm.com>
13280
13281         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13282
13283 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13284             Jiong Wang  <jiong.wang@arm.com>
13285
13286         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13287         function.
13288         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13289         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13290         (aarch64_gdbarch_init): Add puth registers.
13291         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13292         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13293         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13294
13295 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13296             Jiong Wang  <jiong.wang@arm.com>
13297
13298         * aarch64-linux-nat.c
13299         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13300         * aarch64-linux-tdep.c
13301         (aarch64_linux_core_read_description): Likewise.
13302         (aarch64_linux_get_hwcap): New function.
13303         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13304         (aarch64_linux_get_hwcap): New declaration.
13305
13306 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13307             Jiong Wang  <jiong.wang@arm.com>
13308
13309         * aarch64-linux-nat.c
13310         (aarch64_linux_nat_target::read_description): Add pauth param.
13311         * aarch64-linux-tdep.c
13312         (aarch64_linux_core_read_description): Likewise.
13313         * aarch64-tdep.c (struct target_desc): Add in pauth.
13314         (aarch64_read_description): Add pauth param.
13315         (aarch64_gdbarch_init): Likewise.
13316         * aarch64-tdep.h (aarch64_read_description): Likewise.
13317         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13318         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13319         * features/Makefile: Add new files.
13320         * features/aarch64-pauth.c: New file.
13321         * features/aarch64-pauth.xml: New file.
13322
13323 2019-03-20  Tom Tromey  <tromey@adacore.com>
13324
13325         * infrun.c (handle_inferior_event): Rename from
13326         handle_inferior_event_1.  Create a scoped_value_mark.
13327         (handle_inferior_event): Remove.
13328
13329 2019-03-19  Tom Tromey  <tromey@adacore.com>
13330
13331         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13332         * infrun.h (print_stop_event): Add "displays" parameter.
13333         * infrun.c (print_stop_event): Add "displays" parameter.
13334
13335 2019-03-19  Pedro Alves  <palves@redhat.com>
13336
13337         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13338         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13339         to -1.  Fix TABs vs spaces.
13340         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13341         * tui/tui-out.h (tui_ui_out) Add intro comments.
13342         <m_line, m_start_of_line>: In-class initialize, and add describing
13343         comment.
13344
13345 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13346
13347         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13348         variable names.
13349         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13350
13351 2019-03-18  Pedro Alves  <palves@redhat.com>
13352             Eli Zaretskii <eliz@gnu.org>
13353
13354         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13355         m_line and m_start_of_line.
13356
13357 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13358
13359         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13360         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13361         it returns a newline.  This fixes a regression in TU mode, whereby
13362         the next line is output on the same screen line as the user input.
13363
13364 2019-03-18  Tom Tromey  <tromey@adacore.com>
13365
13366         * minsyms.c (minimal_symbol_reader::install): Remove call to
13367         obstack_blank.
13368
13369 2019-03-18  Pedro Alves  <palves@redhat.com>
13370
13371         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13372         New globals.
13373         (apply_style): New, factored out from ...
13374         (apply_ansi_escape): ... this.  Handle reverse video mode.
13375         (tui_set_reverse_mode): New function.
13376         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13377         * tui/tui-winsource.c (tui_show_source_line): Use
13378         tui_set_reverse_mode instead of setting A_STANDOUT.
13379         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13380         New setter methods.
13381
13382 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13383
13384         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13385         Handle tabs.
13386
13387 2019-03-18  Tom Tromey  <tromey@adacore.com>
13388
13389         * ada-lang.c (empty_array): Add "high" parameter.
13390         (ada_evaluate_subexp): Update.
13391
13392 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13393
13394         * unittests/string_view-selftests.c: Define
13395         _initialize_string_view_selftests unconditionally.
13396
13397 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13398
13399         PR gdb/24350
13400         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13401
13402 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13403
13404         PR gdb/24351
13405         * windows-nat.c (display_selector): Fix format specifiers.
13406
13407 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13408
13409         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13410         tui_refill_source_window instead of tui_refresh_win, to update the
13411         current execution line.  This fixes redisplay of the current line
13412         when stepping through the code with "next" or "step".
13413
13414 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13415
13416         * source-cache.c (source_cache::get_source_lines): Call
13417         find_source_lines to initialize s->nlines.  This fixes vertical
13418         scrolling of TUI source window when the DOWN arrow is pressed.
13419
13420 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13421
13422         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13423         linux-thread-db.c (_initialize_thread_db): Likewise.
13424
13425 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13426
13427         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13428         wclrtoeol in tui_show_source_line".  This reverts changes made in
13429         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13430
13431 2019-03-15  Tom Tromey  <tom@tromey.com>
13432
13433         * symtab.h (struct minimal_symbol): Derive from
13434         general_symbol_info.
13435         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13436         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13437         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13438         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13439         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13440         (MSYMBOL_SEARCH_NAME): Update.
13441         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13442         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13443         * minsyms.c (minimal_symbol_reader::record_full): Update.
13444
13445 2019-03-15  Tom Tromey  <tom@tromey.com>
13446
13447         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13448
13449 2019-03-15  Tom Tromey  <tom@tromey.com>
13450
13451         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13452         unique_xmalloc_ptr.
13453         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13454         Update.
13455         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13456         (build_minimal_symbol_hash_tables)
13457         (minimal_symbol_reader::install): Update.
13458
13459 2019-03-15  Tom Tromey  <tom@tromey.com>
13460
13461         * symtab.c (create_demangled_names_hash): Update.
13462         (symbol_set_names): Update.
13463         * objfiles.h (struct objfile_per_bfd_storage)
13464         <demangled_names_hash>: Now an htab_up.
13465         * objfiles.c (objfile_per_bfd_storage): Simplify.
13466
13467 2019-03-15  Tom Tromey  <tom@tromey.com>
13468
13469         * objfiles.h (struct objfile_per_bfd_storage): Declare
13470         destructor.
13471         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13472         New.
13473         (get_objfile_bfd_data): Use new.  Don't initialize
13474         language_of_main.
13475         (free_objfile_per_bfd_storage): Remove.
13476         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13477
13478 2019-03-15  Tom Tromey  <tom@tromey.com>
13479
13480         * symfile.c (reread_symbols): Update.
13481         * objfiles.c (objfile::objfile): Update.
13482         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13483         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13484         comment.
13485         (minimal_symbol_reader::install): Update.
13486         (terminate_minimal_symbol_table): Remove.
13487         * jit.c (jit_object_close_impl): Update.
13488
13489 2019-03-15  Tom Tromey  <tom@tromey.com>
13490
13491         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13492         initializations.
13493
13494 2019-03-15  Tom Tromey  <tom@tromey.com>
13495
13496         * objfiles.h (struct objfile_per_bfd_storage)
13497         <demangled_hash_languages>: Now a bitset.
13498         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13499         (lookup_minimal_symbol): Update.
13500
13501 2019-03-15  Tom Tromey  <tom@tromey.com>
13502
13503         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13504         Don't return the symbol.
13505         * coffread.c (record_minimal_symbol): Use record_full.
13506
13507 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13508
13509         The MS-Windows port of ncurses fails to switch to a color pair if
13510         one or both of the colors are the implicit default colors.  This
13511         change records the default colors when TUI is initialized, and
13512         then specifies them explicitly when a color pair uses the default
13513         colors.  This allows color styling in TUI mode on MS-Windows.
13514
13515         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13516         ncurses_norm_attr.
13517         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13518         colors in ncurses_norm_attr.
13519         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13520         "none", replace it with the default color recorded in
13521         ncurses_norm_attr.
13522
13523 2019-03-14  Tom Tromey  <tromey@adacore.com>
13524
13525         * source-cache.h (class source_cache) <get_source_lines>: Return
13526         std::string.
13527         * source-cache.c (source_cache::extract_lines): Handle case where
13528         first_pos==npos.  Return std::string.
13529         (source_cache::get_source_lines): Update.
13530
13531 2019-03-14  Tom Tromey  <tromey@adacore.com>
13532
13533         * NEWS: Add item for "style sources" commands.
13534         * source-cache.c (source_cache::get_source_lines): Check
13535         source_styling.
13536         * cli/cli-style.c (source_styling): New global.
13537         (_initialize_cli_style): Add "style sources" commands.
13538         (show_style_sources): New function.
13539         * cli/cli-style.h (source_styling): Declare.
13540
13541 2019-03-14  Pedro Alves  <palves@redhat.com>
13542             Tom Tromey  <tromey@adacore.com>
13543
13544         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13545         * tui/tui-winsource.c (tui_refill_source_window): New function,
13546         from...
13547         (tui_horizontal_source_scroll): ... here.  Move some logic.
13548         * cli/cli-style.c (set_style_enabled): Notify new observable.
13549         * tui/tui-hooks.c (tui_redisplay_source): New function.
13550         (tui_attach_detach_observers): Attach or detach
13551         tui_redisplay_source.
13552         * observable.h (source_styling_changed): New observable.
13553         * observable.c: Define source_styling_changed observable.
13554
13555 2019-03-13  Tom Tromey  <tromey@adacore.com>
13556
13557         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13558         (i386_gnu_nat_target::store_registers): Update.
13559         * target-debug.h (target_debug_print_std_string): New macro.
13560         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13561         * windows-tdep.c (display_one_tib): Update.
13562         * tui/tui-stack.c (tui_make_status_line): Update.
13563         * top.c (print_inferior_quit_action): Update.
13564         * thread.c (thr_try_catch_cmd): Update.
13565         (add_thread_with_info): Update.
13566         (thread_target_id_str): Update.
13567         (thr_try_catch_cmd): Update.
13568         (thread_command): Update.
13569         (thread_find_command): Update.
13570         * record-btrace.c (record_btrace_target::info_record)
13571         (record_btrace_resume_thread, record_btrace_target::resume)
13572         (record_btrace_cancel_resume, record_btrace_step_thread)
13573         (record_btrace_target::wait, record_btrace_target::wait)
13574         (record_btrace_target::wait, record_btrace_target::stop): Update.
13575         * progspace.c (print_program_space): Update.
13576         * process-stratum-target.c
13577         (process_stratum_target::thread_address_space): Update.
13578         * linux-fork.c (linux_fork_mourn_inferior)
13579         (detach_checkpoint_command, info_checkpoints_command)
13580         (linux_fork_context): Update.
13581         (linux_fork_detach): Update.
13582         (class scoped_switch_fork_info): Update.
13583         (delete_checkpoint_command): Update.
13584         * infrun.c (follow_fork_inferior): Update.
13585         (follow_fork_inferior): Update.
13586         (proceed_after_vfork_done): Update.
13587         (handle_vfork_child_exec_or_exit): Update.
13588         (follow_exec): Update.
13589         (displaced_step_prepare_throw): Update.
13590         (displaced_step_restore): Update.
13591         (start_step_over): Update.
13592         (resume_1): Update.
13593         (clear_proceed_status_thread): Update.
13594         (proceed): Update.
13595         (print_target_wait_results): Update.
13596         (do_target_wait): Update.
13597         (context_switch): Update.
13598         (stop_all_threads): Update.
13599         (restart_threads): Update.
13600         (finish_step_over): Update.
13601         (handle_signal_stop): Update.
13602         (switch_back_to_stepped_thread): Update.
13603         (keep_going_pass_signal): Update.
13604         (print_exited_reason): Update.
13605         (normal_stop): Update.
13606         * inferior.c (inferior_pid_to_str): Change return type.
13607         (print_selected_inferior): Update.
13608         (add_inferior): Update.
13609         (detach_inferior): Update.
13610         * dummy-frame.c (fprint_dummy_frames): Update.
13611         * dcache.c (dcache_info_1): Update.
13612         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13613         (btrace_fetch, btrace_clear): Update.
13614         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13615         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13616         type.
13617         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13618         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13619         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13620         * gdbarch.c, gdbarch.h: Rebuild.
13621         * gdbarch.sh (core_pid_to_str): Change return type.
13622         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13623         return type.
13624         (windows_nat_target::pid_to_str): Change return type.
13625         (windows_delete_thread): Update.
13626         (windows_nat_target::attach): Update.
13627         (windows_nat_target::files_info): Update.
13628         * target-delegates.c: Rebuild.
13629         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13630         return type.
13631         (sol_thread_target::pid_to_str): Change return type.
13632         * remote.c (class remote_target) <pid_to_str>: Change return
13633         type.
13634         (remote_target::pid_to_str): Change return type.
13635         (extended_remote_target::attach, remote_target::remote_stop_ns)
13636         (remote_target::remote_notif_remove_queued_reply)
13637         (remote_target::push_stop_reply, remote_target::disable_btrace):
13638         Update.
13639         (extended_remote_target::attach): Update.
13640         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13641         type.
13642         (gdbsim_target::pid_to_str): Change return type.
13643         * ravenscar-thread.c (struct ravenscar_thread_target)
13644         <pid_to_str>: Change return type.
13645         (ravenscar_thread_target::pid_to_str): Change return type.
13646         * procfs.c (class procfs_target) <pid_to_str>: Change return
13647         type.
13648         (procfs_target::pid_to_str): Change return type.
13649         (procfs_target::attach): Update.
13650         (procfs_target::detach): Update.
13651         (procfs_target::fetch_registers): Update.
13652         (procfs_target::store_registers): Update.
13653         (procfs_target::wait): Update.
13654         (procfs_target::files_info): Update.
13655         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13656         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13657         return type.
13658         (nto_procfs_target::pid_to_str): Change return type.
13659         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13660         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13661         return type.
13662         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13663         (exit_lwp): Update.
13664         (attach_proc_task_lwp_callback, get_detach_signal)
13665         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13666         (linux_nat_target::resume, wait_lwp, stop_callback)
13667         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13668         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13669         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13670         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13671         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13672         type.
13673         (inf_ptrace_target::attach): Update.
13674         (inf_ptrace_target::files_info): Update.
13675         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13676         type.
13677         (go32_nat_target::pid_to_str): Change return type.
13678         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13679         (gnu_nat_target::wait): Update.
13680         (gnu_nat_target::wait): Update.
13681         (gnu_nat_target::resume): Update.
13682         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13683         (fbsd_nat_target::wait): Update.
13684         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13685         type.
13686         (darwin_nat_target::attach): Update.
13687         * corelow.c (class core_target) <pid_to_str>: Change return type.
13688         (core_target::pid_to_str): Change return type.
13689         * target.c (normal_pid_to_str): Change return type.
13690         (default_pid_to_str): Likewise.
13691         (target_pid_to_str): Change return type.
13692         (target_translate_tls_address): Update.
13693         (target_announce_detach): Update.
13694         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13695         return type.
13696         (bsd_uthread_target::pid_to_str): Change return type.
13697         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13698         type.
13699         (bsd_kvm_target::pid_to_str): Change return type.
13700         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13701         return type.
13702         (aix_thread_target::pid_to_str): Change return type.
13703         * target.h (struct target_ops) <pid_to_str>: Change return type.
13704         (target_pid_to_str, normal_pid_to_str): Likewise.
13705         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13706         type.
13707         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13708         type.
13709         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13710         return type.
13711         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13712         type.
13713         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13714         type.
13715         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13716         return type.
13717
13718 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13719
13720         * NEWS: Mention that the new default MI version is 3.  Mention
13721         changes to the output of commands and events that deal with
13722         multi-location breakpoints.
13723         * breakpoint.c: Include "mi/mi-out.h".
13724         (print_one_breakpoint): Change output syntax if using MI version
13725         >= 3.
13726         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13727         New.
13728         (mi_multi_location_breakpoint_output_fixed): New.
13729         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13730         (mi_cmd_fix_multi_location_breakpoint_output): New.
13731         (mi_multi_location_breakpoint_output_fixed): New.
13732         * mi/mi-cmds.c (mi_cmds): Register command
13733         -fix-multi-location-breakpoint-output.
13734         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13735         interpreter "mi".
13736
13737 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13738
13739         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13740         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13741         instantiate mi_ui_out based on interpreter name.
13742         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13743         * mi/mi-main.c (mi_load_progress): Likewise.
13744
13745 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13746
13747         * NEWS: Combine separate "New targets" sections for 8.3.
13748
13749 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13750
13751         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13752         (ppcfbsd_init_abi): Install gdbarch
13753         "fetch_tls_load_module_address" and "get_thread_local_address"
13754         methods.
13755
13756 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13757
13758         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13759         (riscv_fbsd_init_abi): Install gdbarch
13760         "fetch_tls_load_module_address" and "get_thread_local_address"
13761         methods.
13762
13763 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13764
13765         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13766         (i386fbsd_init_abi): Install gdbarch
13767         "fetch_tls_load_module_address" and "get_thread_local_address"
13768         methods.
13769
13770 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13771
13772         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13773         (amd64fbsd_init_abi): Install gdbarch
13774         "fetch_tls_load_module_address" and "get_thread_local_address"
13775         methods.
13776
13777 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13778
13779         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13780         (struct fbsd_pspace_data): New type.
13781         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13782         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13783         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13784         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13785         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13786
13787 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13788
13789         * gdbtypes.c (lookup_struct_elt): New function.
13790         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13791         * gdbtypes.h (struct struct_elt): New type.
13792         (lookup_struct_elt): New prototype.
13793
13794 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13795
13796         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13797         remove disabled code block.
13798
13799 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13800
13801         * gdbarch.sh (get_thread_local_address): New method.
13802         * gdbarch.h, gdbarch.c: Regenerate.
13803         * target.c (target_translate_tls_address): Use
13804         gdbarch_get_thread_local_address if present instead of
13805         target::get_thread_local_address.
13806
13807 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13808
13809         * target.h (target::get_thread_local_address): Update comment.
13810
13811 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13812
13813         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13814         objfile->separate_debug_objfile_backlink if not NULL.
13815
13816 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13817
13818         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13819         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13820         (amd64bsd_store_inferior_registers): Likewise.
13821         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13822         Enable segment base registers.
13823         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13824         PT_GETFSBASE and PT_GETGSBASE.
13825         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13826         PT_SETGSBASE.
13827         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13828         segment base registers.
13829         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13830
13831 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13832
13833         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13834         Update calls to i386_target_description to add 'segments'
13835         parameter.
13836         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13837         add segment base registers.
13838         * arch/i386.c (i386_create_target_description): Add 'segments'
13839         parameter to enable segment base registers.
13840         * arch/i386.h (i386_create_target_description): Likewise.
13841         * features/i386/32bit-segments.xml: New file.
13842         * features/i386/32bit-segments.c: Generate.
13843         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13844         call to i386_target_description to add 'segments' parameter.
13845         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13846         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13847         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13848         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13849         if feature is present.
13850         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13851         Add 'segments' parameter to call to i386_target_description.
13852         (i386_target_description): Add 'segments' parameter to enable
13853         segment base registers.
13854         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13855         to call to i386_target_description.
13856         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13857         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13858         Define I386_NUM_REGS.
13859         (i386_target_description): Add 'segments' parameter to enable
13860         segment base registers.
13861
13862 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13863
13864         PR/24325
13865         * source-cache.c: #undef open and close, to avoid unresolved
13866         externals during linking.
13867
13868 2019-03-12  Tom Tromey  <tromey@adacore.com>
13869
13870         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13871         const.  Add initializers.
13872         (_initialize_remote): Don't initialize ptid globals.
13873
13874 2019-03-12  Pedro Alves  <palves@redhat.com>
13875
13876         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13877
13878 2019-03-12  Pedro Alves  <palves@redhat.com>
13879
13880         * cp-name-parser.y (main): Remove unused 'len' variable.
13881
13882 2019-03-12  Tom Tromey  <tromey@adacore.com>
13883
13884         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13885         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13886
13887 2019-03-12  Tom Tromey  <tromey@adacore.com>
13888
13889         * linux-nat.c (iterate_over_lwps): Update.
13890         (stop_callback): Remove parameter.
13891         (stop_wait_callback, detach_callback, resume_set_callback)
13892         (select_singlestep_lwp_callback, set_ignore_sigint)
13893         (status_callback, resumed_callback, resume_clear_callback)
13894         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13895         data parameter.
13896         (linux_nat_target::detach, linux_nat_target::resume)
13897         (linux_stop_and_wait_all_lwps, select_event_lwp)
13898         (linux_nat_filter_event, linux_nat_wait_1)
13899         (linux_nat_target::kill, linux_nat_target::stop)
13900         (linux_nat_target::stop): Update.
13901         (linux_nat_resume_callback): Change type.
13902         (resume_stopped_resumed_lwps, count_events_callback)
13903         (select_event_lwp_callback): Likewise.
13904         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13905         * arm-linux-nat.c (struct update_registers_data): Remove.
13906         (update_registers_callback): Change type.
13907         (arm_linux_insert_hw_breakpoint1): Update.
13908         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13909         parameter.
13910         (x86_linux_dr_set_addr): Update.
13911         (x86_linux_dr_set_control): Update.
13912         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13913         (iterate_over_lwps): Use gdb::function_view.
13914         * nat/aarch64-linux-hw-point.c (struct
13915         aarch64_dr_update_callback_param): Remove.
13916         (debug_reg_change_callback): Change type.
13917         (aarch64_notify_debug_reg_change): Update.
13918         * s390-linux-nat.c (s390_refresh_per_info): Update.
13919
13920 2019-03-11  Tom Tromey  <tromey@adacore.com>
13921
13922         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13923         redundant assignment to "this_cu".
13924
13925 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13926
13927         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13928
13929 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13930
13931         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13932         from...
13933         (rank_one_type): ... this.
13934
13935 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13936
13937         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13938         from...
13939         (rank_one_type): ... this.
13940
13941 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13942
13943         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13944         from...
13945         (rank_one_type): ... this.
13946
13947 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13948
13949         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13950         from...
13951         (rank_one_type): ... this.
13952
13953 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13954
13955         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13956         from...
13957         (rank_one_type): ... this.
13958
13959 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13960
13961         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13962         from...
13963         (rank_one_type): ... this.
13964
13965 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13966
13967         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13968         from...
13969         (rank_one_type): ... this.
13970
13971 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13972
13973         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13974         from...
13975         (rank_one_type): ... this.
13976
13977 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13978
13979         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13980         from...
13981         (rank_one_type): ... this.
13982
13983 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13984
13985         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13986         from...
13987         (rank_one_type): ... this.
13988
13989 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13990
13991         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13992         from...
13993         (rank_one_type): ... this.
13994
13995 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13996
13997         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13998         from...
13999         (rank_one_type): ... this.
14000
14001 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14002
14003         * inferior.c (initialize_inferiors): Ensure 'help set/show print
14004         inferior-events' shows the example events.
14005
14006 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
14007
14008         Support styling on native MS-Windows console
14009
14010         PR/24315
14011         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14012         on MS-Windows if $TERM is not defined.
14013
14014         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14015
14016         * posix-hdep.c (gdb_console_fputs):
14017         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14018         functions.
14019         * ui-file.h (gdb_console_fputs): Add prototype.
14020
14021         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14022         back to fputs only if the former returns zero.
14023
14024 2019-03-07  Tom Tromey  <tom@tromey.com>
14025
14026         * symmisc.c (print_symbol_bcache_statistics): Update.
14027         (print_objfile_statistics): Update.
14028         * symfile.c (allocate_symtab): Update.
14029         * stabsread.c: Don't include bcache.h.
14030         * psymtab.h (struct psymbol_bcache): Don't declare.
14031         (class psymtab_storage) <psymbol_cache>: Now a bcache.
14032         (psymbol_bcache_init, psymbol_bcache_free)
14033         (psymbol_bcache_get_bcache): Don't declare.
14034         * psymtab.c (struct psymbol_bcache): Remove.
14035         (psymtab_storage::psymtab_storage): Update.
14036         (psymtab_storage::~psymtab_storage): Update.
14037         (psymbol_bcache_init, psymbol_bcache_free)
14038         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14039         (add_psymbol_to_bcache): Update.
14040         (allocate_psymtab): Update.
14041         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14042         macro_cache>: No longer pointers.
14043         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14044         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14045         * macrotab.c (macro_bcache): Update.
14046         * macroexp.c: Don't include bcache.h.
14047         * gdbtypes.c (check_types_worklist): Update.
14048         (types_deeply_equal): Remove TRY/CATCH.  Update.
14049         * elfread.c (elf_symtab_read): Update.
14050         * dwarf2read.c: Don't include bcache.h.
14051         * buildsym.c (buildsym_compunit::get_macro_table): Update.
14052         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14053         (print_bcache_statistics, bcache_memory_used): Don't declare.
14054         (struct bcache): Move from bcache.c.  Add constructor, destructor,
14055         methods.  Rename all data members.
14056         * bcache.c (struct bcache): Move to bcache.h.
14057         (bcache::expand_hash_table): Rename from expand_hash_table.
14058         (bcache): Remove.
14059         (bcache::insert): Rename from bcache_full.
14060         (bcache::compare): Rename from bcache_compare.
14061         (bcache_xmalloc): Remove.
14062         (bcache::~bcache): Rename from bcache_xfree.
14063         (bcache::print_statistics): Rename from print_bcache_statistics.
14064         (bcache::memory_used): Rename from bcache_memory_used.
14065
14066 2019-03-07  Pedro Alves  <palves@redhat.com>
14067
14068         * infrun.c (normal_stop): Also check for
14069         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14070
14071 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
14072
14073         * f-lang.c (value_from_host_double): Moved to...
14074         * value.c (value_from_host_double): ...here.
14075         * value.h (value_from_host_double): Declare.
14076         * guile/scm-math.c (vlscm_convert_typed_number): Use
14077         value_from_host_double.
14078         (vlscm_convert_number): Likewise.
14079         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14080         * python/py-value.c (convert_value_from_python): Likewise.
14081
14082 2019-03-06  Tom Tromey  <tom@tromey.com>
14083
14084         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14085
14086 2019-03-06  Tom Tromey  <tom@tromey.com>
14087
14088         * utils.h (free_current_contents): Don't declare.
14089         * utils.c (free_current_contents): Remove.
14090
14091 2019-03-06  Tom Tromey  <tom@tromey.com>
14092
14093         * top.c (quit_force): Update.
14094         * main.c (captured_command_loop): Update.
14095         * common/new-op.c (operator new): Update.
14096         * common/common-exceptions.c (struct catcher)
14097         <save_cleanup_chain>: Remove member.
14098         (exceptions_state_mc_init): Update.
14099         (exception_try_scope_entry): Return nullptr.
14100         (exception_try_scope_exit, exception_rethrow)
14101         (throw_exception_sjlj, throw_exception_cxx): Update.
14102         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14103         (all_cleanups, do_cleanups, discard_cleanups)
14104         (discard_final_cleanups, save_cleanups, save_final_cleanups)
14105         (restore_cleanups, restore_final_cleanups): Don't declare.
14106         (do_final_cleanups): Remove parameter.
14107         * common/cleanups.c (cleanup_chain, make_cleanup)
14108         (make_cleanup_dtor, all_cleanups, do_cleanups)
14109         (discard_my_cleanups, discard_cleanups)
14110         (discard_final_cleanups, save_my_cleanups, save_cleanups)
14111         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14112         (null_cleanup): Remove.
14113         (do_final_cleanups): Remove parameter.
14114
14115 2019-03-06  Tom Tromey  <tom@tromey.com>
14116
14117         * remote.c (remote_target::remote_parse_stop_reply): Use
14118         unique_xmalloc_ptr.
14119
14120 2019-03-06  Tom Tromey  <tom@tromey.com>
14121
14122         * stabsread.c (struct stabs_field_info): Rename from field_info.
14123         <list, fnlist>: Add initializers.
14124         <obstack>: New member.
14125         (read_member_functions, read_struct_fields, read_baseclasses):
14126         Allocate on obstack.  Don't use cleanups.
14127         (read_one_struct_field, read_member_functions, read_struct_fields)
14128         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14129         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14130         (read_struct_type): Update.
14131
14132 2019-03-06  Tom Tromey  <tom@tromey.com>
14133
14134         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14135         * common/filestuff.h (make_cleanup_close): Don't declare.
14136         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14137         Remove.
14138
14139 2019-03-06  Tom Tromey  <tom@tromey.com>
14140
14141         * solib-aix.c: Use make_scope_exit.
14142
14143 2019-03-06  Tom Tromey  <tom@tromey.com>
14144
14145         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14146         Use make_scope_exit.
14147
14148 2019-03-06  Tom Tromey  <tom@tromey.com>
14149
14150         * solib-svr4.c (disable_probes_interface): Remove parameter.
14151         (svr4_handle_solib_event): Use make_scope_exit.
14152
14153 2019-03-06  Tom Tromey  <tom@tromey.com>
14154
14155         * remote.c (struct stop_reply_deleter): Remove.
14156         (stop_reply_up): Update.
14157         (struct stop_reply): Derive from notif_event.  Don't typedef.
14158         <regcache>: Now a std::vector.
14159         (stop_reply_xfree): Remove.
14160         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14161         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14162         (remote_target::discard_pending_stop_replies): Use delete.
14163         (remote_target::remote_parse_stop_reply): Update.
14164         (remote_target::process_stop_reply): Update.
14165         * remote-notif.h (struct notif_event): Add virtual destructor.
14166         Remove "dtr" member.
14167         (struct notif_client) <alloc_event>: Return a unique_ptr.
14168         (notif_event_xfree): Don't declare.
14169         (notif_event_up): New typedef.
14170         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14171         (notif_event_xfree, do_notif_event_xfree): Remove.
14172         (remote_notif_state_xfree): Update.
14173
14174 2019-03-06  Tom Tromey  <tom@tromey.com>
14175
14176         * infrun.c (displaced_step_clear_cleanup): Now a
14177         forward_scope_exit type.
14178         (displaced_step_prepare_throw): Update.
14179         (displaced_step_fixup): Update.
14180
14181 2019-03-06  Tom Tromey  <tom@tromey.com>
14182
14183         * inferior.h (class inferior): Update comment.
14184         * gdbthread.h (class thread_info): Update comment.
14185
14186 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14187             Tom Tromey  <tom@tromey.com>
14188
14189         * stabsread.h (struct stab_section_list): Remove.
14190         (coffstab_build_psymtabs): Update.
14191         * dbxread.c (symbuf_sections): Now a std::vector.
14192         (sect_idx): New global.
14193         (fill_symbuf): Update.
14194         (coffstab_build_psymtabs): Change type of stabsects parameter.
14195         Update.
14196         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14197         std::vector.
14198         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14199         (coff_locate_sections): Update.
14200         (coff_symfile_read): Remove cleanups.  Update.
14201         (init_stringtab): Add storage parameter.
14202         (free_stringtab, free_stringtab_cleanup): Remove.
14203         (init_lineno): Add storage parameter.
14204         (free_linetab, free_linetab_cleanup): Remove.
14205
14206 2019-03-06  Pedro Alves  <palves@redhat.com>
14207
14208         * linux-fork.c (fork_info::clobber_regs): Delete.
14209         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14210         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14211         comment.  Adjust.
14212         (scoped_switch_fork_info::scoped_switch_fork_info)
14213         (checkpoint_command, linux_fork_context): Adjust
14214         fork_save_infrun_state calls.
14215
14216 2019-03-06  Pedro Alves  <palves@redhat.com>
14217
14218         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14219         (inf_has_multiple_threads): Return 'bool' and rewrite using
14220         inferior_info::threads().
14221
14222 2019-03-06  Pedro Alves  <palves@redhat.com>
14223
14224         * linux-fork.c: Include <list>.
14225         (fork_list): Now a std::list instance.
14226         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14227         (forks_exist_p, find_last_fork): Adjust.
14228         (new_fork): Delete.
14229         (one_fork_p): New.
14230         (add_fork): Adjust.
14231         (free_fork): Delete, folded into fork_info::~fork_info().
14232         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14233         Adjust.
14234         (init_fork_list): Delete.
14235         (linux_fork_killall, linux_fork_mourn_inferior)
14236         (linux_fork_detach, info_checkpoints_command): Adjust.
14237         (_initialize_linux_fork): No longer call init_fork_list.
14238
14239 2019-03-06  Pedro Alves  <palves@redhat.com>
14240
14241         * linux-fork.c (new_fork): New, split out of ...
14242         (add_fork): ... this.  Return void.  Move "first fork" special
14243         case from here, to ...
14244         (checkpoint_command): ... here.
14245         * linux-linux.h (add_fork): Return void.
14246
14247 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14248
14249         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14250
14251 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14252             Chris January  <chris.january@arm.com>
14253             David Lecomber  <david.lecomber@arm.com>
14254
14255         * f-exp.y: New token, UNOP_INTRINSIC.
14256         (exp): New pattern using UNOP_INTRINSIC token.
14257         (f77_keywords): Add 'abs' keyword.
14258         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14259         (value_from_host_double): New function.
14260         (evaluate_subexp_f): Support UNOP_ABS.
14261
14262 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14263
14264         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14265         types.
14266
14267 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14268
14269         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14270         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14271         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14272
14273 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14274
14275         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14276
14277 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14278             Chris January  <chris.january@arm.com>
14279
14280         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14281         * f-exp.y: Define 'KIND' token.
14282         (exp): New pattern for KIND expressions.
14283         (ptype): Handle types with a kind extension.
14284         (direct_abs_decl): Extend to spot kind extensions.
14285         (f77_keywords): Add 'kind' to the list.
14286         (push_kind_type): New function.
14287         (convert_to_kind_type): New function.
14288         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14289         * parse.c (operator_length_standard): Likewise.
14290         * parser-defs.h (enum type_pieces): Add tp_kind.
14291         * std-operator.def: Add UNOP_KIND.
14292
14293 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14294
14295         * f-exp.y (f_parse): Set yydebug.
14296
14297 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14298
14299         * f-lang.c (evaluate_subexp_f): New function.
14300         (exp_descriptor_f): New global.
14301         (f_language_defn): Use exp_descriptor_f instead of
14302         exp_descriptor_standard.
14303
14304 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14305
14306         * f-exp.y (struct token): Add comments.
14307         (dot_ops): Remove uppercase versions and the end marker.
14308         (f77_keywords): Likewise.
14309         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14310         entries in the dot_ops array are case insensitive, and use
14311         strncasecmp to compare strings.  Also some whitespace cleanup in
14312         this area.  Similar for the f77_keywords array, except entries in
14313         this list might be case sensitive.
14314
14315 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14316
14317         * f-exp.y (struct f77_boolean_val): Add comments.
14318         (boolean_values): Remove uppercase versions, and end marker.
14319         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14320         and use strncasecmp to achieve case insensitivity.  Additionally,
14321         perform whitespace cleanup around this code.
14322
14323 2019-03-06  Tom Tromey  <tromey@adacore.com>
14324
14325         * remote-sim.c (gdbsim_target_open): Use result of
14326         gdb_argv::release.
14327
14328 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14329         Dirk Schubert  <dirk.schubert@arm.com>
14330         Chris January  <chris.january@arm.com>
14331
14332         * eval.c (evaluate_subexp_standard): Call Fortran argument
14333         wrapping logic.
14334         * f-lang.c (struct value): A value which can be passed into a
14335         Fortran function call.
14336         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14337         where appropriate.
14338         (struct type): Value ready for a Fortran function call.
14339         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14340         is needed.
14341         * f-lang.h (fortran_argument_convert): Declaration.
14342         (fortran_preserve_arg_pointer): Declaration.
14343         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14344
14345 2019-03-05  Tom Tromey  <tromey@adacore.com>
14346
14347         * python/py-prettyprint.c (print_string_repr): Remove #if.
14348         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14349
14350 2019-03-05  Tom Tromey  <tromey@adacore.com>
14351
14352         * target.c (the_dummy_target): Move later.  Change type to
14353         "dummy_target".
14354         (initialize_targets): Don't initialize the_dummy_target.
14355
14356 2019-03-05  Tom Tromey  <tromey@adacore.com>
14357
14358         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14359         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14360
14361 2019-03-05  Tom Tromey  <tromey@adacore.com>
14362
14363         * windows-nat.c (windows_nat_target::attach)
14364         (windows_nat_target::detach): Don't call gdb_flush.
14365         * valprint.c (generic_val_print, val_print, val_print_string):
14366         Don't call gdb_flush.
14367         * utils.c (defaulted_query): Don't call gdb_flush.
14368         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14369         * target.c (target_announce_detach): Don't call gdb_flush.
14370         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14371         * remote.c (extended_remote_target::attach): Don't call
14372         gdb_flush.
14373         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14374         * printcmd.c (do_examine): Don't call gdb_flush.
14375         (info_display_command): Don't call gdb_flush.
14376         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14377         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14378         * memattr.c (info_mem_command): Don't call gdb_flush.
14379         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14380         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14381         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14382         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14383         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14384         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14385         (gnu_nat_target::detach): Don't call gdb_flush.
14386         * f-valprint.c (f_val_print): Don't call gdb_flush.
14387         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14388         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14389         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14390         gdb_flush.
14391         * c-valprint.c (c_val_print): Don't call gdb_flush.
14392         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14393
14394 2019-03-05  Tom Tromey  <tromey@adacore.com>
14395
14396         * varobj.c (update_dynamic_varobj_children): Update.
14397         (install_default_visualizer): Use reset, not release.
14398         * value.c (set_internalvar): Update.
14399         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14400         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14401         ATTRIBUTE_UNUSED_RESULT.
14402
14403 2019-03-05  Tom Tromey  <tromey@adacore.com>
14404
14405         * remote.c (class scoped_remote_fd) <release>: Add
14406         ATTRIBUTE_UNUSED_RESULT.
14407
14408 2019-03-05  Tom Tromey  <tromey@adacore.com>
14409
14410         * macroexp.c (struct macro_buffer) <release>: Add
14411         ATTRIBUTE_UNUSED_RESULT.
14412
14413 2019-03-05  Tom Tromey  <tromey@adacore.com>
14414
14415         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14416         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14417         ATTRIBUTE_UNUSED_RESULT.
14418
14419 2019-03-05  Tom Tromey  <tromey@adacore.com>
14420
14421         * common/scoped_fd.h (class scoped_fd) <release>: Add
14422         ATTRIBUTE_UNUSED_RESULT.
14423
14424 2019-03-05  Tom Tromey  <tromey@adacore.com>
14425
14426         * parser-defs.h (struct parser_state) <release>: Add
14427         ATTRIBUTE_UNUSED_RESULT.
14428
14429 2019-03-05  Tom Tromey  <tromey@adacore.com>
14430
14431         * utils.h (class gdb_argv) <release>: Add
14432         ATTRIBUTE_UNUSED_RESULT.
14433         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14434
14435 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14436
14437         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14438         for-loop range, to avoid compiler warnings.
14439
14440         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14441         avoid compiler warnings about unused variables.
14442
14443         * NEWS: Mention end of support for native debugging on MS-Windows
14444         before XP.
14445
14446         PR gdb/24292
14447         * common/netstuff.c:
14448         * gdbserver/gdbreplay.c
14449         * gdbserver/remote-utils.c:
14450         * ser-tcp.c:
14451         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14452         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14453         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14454         'getaddrinfo' and 'freeaddrinfo' were not available before
14455         Windows XP, and mingw.org's MinGW headers by default define
14456         _WIN32_WINNT to 0x500.
14457
14458 2019-03-01  Gary Benson <gbenson@redhat.com>
14459
14460         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14461
14462 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14463             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14464
14465         PR gdb/8527
14466         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14467         set_sigint_trap, clear_sigint_trap.
14468
14469 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14470
14471         * target.c (target_detach): Clear the regcache and the
14472         frame cache.
14473
14474 2019-02-27  Pedro Alves  <palves@redhat.com>
14475
14476         * utils.c (set_screen_size): When we cap the height/width sizes,
14477         tweak the corresponding command variable to show "unlimited":
14478
14479 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14480             Pedro Alves  <palves@redhat.com>
14481
14482         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14483         before calling rl_set_screen_size.
14484
14485 2019-02-27  Tom Tromey  <tromey@adacore.com>
14486
14487         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14488         define.
14489         * python/py-value.c: Remove Python 2.4 workaround.
14490         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14491         workaround.
14492         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14493         Python 2.4 workaround.
14494         * python/python-internal.h: Remove Python 2.4 comment.
14495         (Py_ssize_t): Don't define.
14496         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14497         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14498         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14499         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14500         * python/python.c (do_start_initialization): Remove Python 2.4
14501         workaround.
14502         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14503         (print_children): Remove Python 2.4 workaround.
14504         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14505         workaround.
14506         (CHARBUFFERPROC_NAME): Remove.
14507         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14508         Python 2.4 workaround.
14509
14510 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14511
14512         * NEWS: Note minimum Python version.
14513
14514 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14515
14516         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14517         code from these functions.  Remove corresponding ifdefs.  Use
14518         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14519         Remove gotos and target of gotos.
14520         (infpy_search_memory): Likewise.
14521
14522 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14523
14524         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14525         (hppa_gdbarch_init): Don't register deleted functions with
14526         gdbarch.
14527
14528 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14529
14530         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14531         (h8300_unwind_sp): Delete.
14532         (h8300_dummy_id): Delete.
14533         (h8300_gdbarch_init): Don't register deleted functions with
14534         gdbarch.
14535
14536 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14537
14538         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14539         (ft32_unwind_pc): Delete.
14540         (ft32_unwind_sp): Delete.
14541         (ft32_gdbarch_init): Don't register deleted functions with
14542         gdbarch.
14543
14544 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14545
14546         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14547         (frv_unwind_pc): Delete.
14548         (frv_unwind_sp): Delete.
14549         (frv_gdbarch_init): Don't register deleted functions with
14550         gdbarch.
14551
14552 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14553
14554         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14555         (riscv_unwind_pc): Delete.
14556         (riscv_unwind_sp): Delete.
14557         (riscv_gdbarch_init): Don't register deleted functions with
14558         gdbarch.
14559
14560 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14561
14562         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14563         (csky_unwind_pc): Delete.
14564         (csky_unwind_sp): Delete.
14565         (csky_gdbarch_init): Don't register deleted functions with
14566         gdbarch.
14567
14568 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14569
14570         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14571         (cris_unwind_pc): Delete.
14572         (cris_unwind_sp): Delete.
14573         (cris_gdbarch_init): Don't register deleted functions with
14574         gdbarch.
14575
14576 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14577
14578         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14579         (bfin_unwind_pc): Delete.
14580         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14581
14582 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14583
14584         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14585         (arm_unwind_pc): Delete.
14586         (arm_unwind_sp): Delete.
14587         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14588
14589 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14590
14591         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14592         (arc_unwind_pc): Delete.
14593         (arc_unwind_sp): Delete.
14594         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14595
14596 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14597
14598         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14599         (alpha_unwind_pc): Delete.
14600         (alpha_gdbarch_init): Don't register deleted functions with
14601         gdbarch.
14602
14603 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14604
14605         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14606         (aarch64_unwind_pc): Delete.
14607         (aarch64_unwind_sp): Delete.
14608         (aarch64_gdbarch_init): Don't register deleted functions with
14609         gdbarch.
14610
14611 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14612
14613         * gdbtypes.c (type_align): Don't consider static members when
14614         computing structure alignment.
14615
14616 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14617
14618         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14619         return 0 for other types.
14620         * arch-utils.c (default_type_align): Always return 0.
14621         * gdbarch.h: Regenerate.
14622         * gdbarch.sh (type_align): Extend comment.
14623         * gdbtypes.c (type_align): Add additional comments, always call
14624         gdbarch_type_align before applying the default rules.
14625         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14626         generic code will then apply a suitable default.
14627         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14628         types, return 0 for other types.
14629
14630 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14631
14632         * NEWS: Create a new section for the next release branch.
14633         Rename the section of the current branch, now that it has
14634         been cut.
14635
14636 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14637
14638         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14639         * version.in: Bump version to 8.3.50.DATE-git.
14640
14641 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14642
14643         * aix-thread.c (ptid_cmp): Remove unused variable.
14644         (get_signaled_thread): Likewise.
14645         (store_regs_user_thread): Likewise.
14646         (store_regs_kernel_thread): Likewise.
14647         (fetch_regs_kernel_thread): Remove shadowed variable.
14648
14649 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14650
14651         * features/riscv/32bit-cpu.xml: Add register numbers.
14652         * features/riscv/32bit-fpu.c: Regenerate.
14653         * features/riscv/32bit-fpu.xml: Add register numbers.
14654         * features/riscv/64bit-cpu.xml: Add register numbers.
14655         * features/riscv/64bit-fpu.c: Regenerate.
14656         * features/riscv/64bit-fpu.xml: Add register numbers.
14657
14658 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14659
14660         * NEWS: Mention two argument form of gdb.Value constructor.
14661         * python/py-value.c (convert_buffer_and_type_to_value): New
14662         function.
14663         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14664         Add support for handling an optional second argument.  Call
14665         convert_buffer_and_type_to_value as appropriate.
14666         * python/python-internal.h (Py_buffer_deleter): New struct.
14667         (Py_buffer_up): New typedef.
14668
14669 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14670
14671         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14672         instead of releasing ownership.
14673
14674 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14675
14676         * dwarf2read.c (open_and_init_dwp_file): Call
14677         elf_numsections instead of bfd_count_sections to initialize
14678         dwp_file->num_sections.
14679
14680 2019-02-25  Tom Tromey  <tromey@adacore.com>
14681
14682         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14683
14684 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14685
14686         * gcore.in: Add '--readnever' option when invoking GDB.
14687
14688 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14689
14690         * MAINTAINERS: Update my email address.
14691
14692 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14693
14694         * build-id.c (build_id_to_debug_bfd_1): New function.
14695         (build_id_to_debug_bfd): Look for separate debug file in
14696         sysroot.
14697
14698 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14699
14700         * gdbarch.sh: Update the copyright year range that is placed into
14701         generated files.
14702
14703 2019-02-22  Keith Seitz  <keiths@redhat.com>
14704
14705         PR symtab/23853
14706         * linespec.c (create_sals_line_offset): Search for the default
14707         symtab's filename instead of its fullname.
14708
14709 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14710
14711         * NEWS: Update style defaults.
14712
14713 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14714
14715         * main.c (captured_main_1): Disable styling in batch mode.
14716
14717 2019-02-20  Tom Tromey  <tom@tromey.com>
14718
14719         * symtab.c (symtab_symbol_info): Fix typos.
14720
14721 2019-02-20  Tom Tromey  <tromey@adacore.com>
14722
14723         * findcmd.c (_initialize_mem_search): Use upper case for
14724         metasyntactic variables.
14725
14726 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14727
14728         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14729         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14730
14731 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14732
14733         * top.h (source_file_name): Change to std::string.
14734         * top.c (source_file_name): Likewise.
14735         (command_line_input): Adjust.
14736         * cli/cli-script.c (script_from_file): Adjust.
14737
14738 2019-02-19  Tom Tromey  <tromey@adacore.com>
14739
14740         * ravenscar-thread.c
14741         (ravenscar_thread_target::update_thread_list): Don't call
14742         ada_build_task_list.
14743         * ada-lang.h (ada_build_task_list): Don't declare.
14744         * ada-tasks.c (struct ada_tasks_inferior_data)
14745         <task_list_valid_p>: Now bool.
14746         (read_known_tasks, ada_task_list_changed)
14747         (ada_tasks_invalidate_inferior_data): Update.
14748         (read_known_tasks_array): Return bool.
14749         (read_known_tasks_list): Likewise.
14750         (read_known_tasks): Return void.
14751         (ada_build_task_list): Now static.
14752
14753 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14754
14755         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14756         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14757
14758 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14759
14760         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14761         variant for ada_tasks_pspace_data_handle and
14762         ada_tasks_inferior_data_handle.
14763         (ada_tasks_pspace_data_cleanup): New function.
14764         (ada_tasks_inferior_data_cleanup): New function.
14765
14766 2019-02-17  Tom Tromey  <tom@tromey.com>
14767
14768         * macrotab.h (macro_source_fullname): Return a std::string.
14769         * macrotab.c (macro_include, check_for_redefinition)
14770         (macro_undef, macro_lookup_definition, foreach_macro)
14771         (foreach_macro_in_scope): Update.
14772         (macro_source_fullname): Return a std::string.
14773         * macrocmd.c (show_pp_source_pos): Update.
14774
14775 2019-02-17  Tom Tromey  <tom@tromey.com>
14776
14777         * macrocmd.c (show_pp_source_pos): Style the file names.
14778
14779 2019-02-17  Tom Tromey  <tom@tromey.com>
14780
14781         PR tui/24197:
14782         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14783
14784 2019-02-17  Tom Tromey  <tom@tromey.com>
14785
14786         * ada-lang.c (user_select_syms): Use filtered printing.
14787         * utils.c (wrap_style): New global.
14788         (desired_style): Remove.
14789         (emit_style_escape): Add stream parameter.
14790         (set_output_style, reset_terminal_style, prompt_for_continue):
14791         Update.
14792         (flush_wrap_buffer): Only flush gdb_stdout.
14793         (wrap_here): Set wrap_style.
14794         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14795         treat escape sequences as a character.  Change when wrap buffer is
14796         flushed.
14797         (fputs_styled): Do not set the output style when the default is
14798         requested.
14799         * ui-style.h (struct ui_file_style) <is_default>: New method.
14800         * source.c (print_source_lines_base): Emit escape sequences in one
14801         piece.
14802
14803 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14804
14805         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14806         integers and enumeration types.
14807
14808 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14809
14810         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14811         instead of lookup_symbol_in_language
14812         (do_exact_match): New function.
14813         (ada_get_symbol_name_matcher): Return do_exact_match when
14814         doing a verbatim match.
14815
14816 2019-02-15  Tom Tromey  <tromey@adacore.com>
14817
14818         * ravenscar-thread.c (ravenscar_thread_target::resume)
14819         (ravenscar_thread_target::wait): Special case wildcard requests.
14820
14821 2019-02-15  Tom Tromey  <tromey@adacore.com>
14822
14823         * ravenscar-thread.c (base_ptid): Remove.
14824         (struct ravenscar_thread_target) <close>: New method.
14825         <m_base_ptid>: New member.
14826         <update_inferior_ptid, active_task, task_is_currently_active,
14827         runtime_initialized>: Declare methods.
14828         <ravenscar_thread_target>: Add constructor.
14829         (ravenscar_thread_target::task_is_currently_active)
14830         (ravenscar_thread_target::update_inferior_ptid)
14831         (ravenscar_runtime_initialized): Rename.  Now methods.
14832         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14833         (ravenscar_thread_target::update_thread_list): Update.
14834         (ravenscar_thread_target::active_task): Now method.
14835         (ravenscar_thread_target::store_registers)
14836         (ravenscar_thread_target::prepare_to_store)
14837         (ravenscar_thread_target::prepare_to_store)
14838         (ravenscar_thread_target::mourn_inferior): Update.
14839         (ravenscar_inferior_created): Use "new" to create target.
14840         (ravenscar_thread_target::get_ada_task_ptid): Update.
14841         (_initialize_ravenscar): Don't initialize base_ptid.
14842         (ravenscar_ops): Remove global.
14843
14844 2019-02-15  Tom Tromey  <tromey@adacore.com>
14845
14846         * target.h (push_target): Declare new overload.
14847         * target.c (push_target): New overload, taking an rvalue reference.
14848         * remote.c (remote_target::open_1): Use push_target overload.
14849         * corelow.c (core_target_open): Use push_target overload.
14850
14851 2019-02-15  Tom Tromey  <tromey@adacore.com>
14852
14853         * ravenscar-thread.c (is_ravenscar_task)
14854         (ravenscar_task_is_currently_active): Return bool.
14855         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14856         (_initialize_ravenscar): Remove "(void)".
14857         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14858         Return bool.
14859
14860 2019-02-15  Tom Tromey  <tromey@adacore.com>
14861
14862         * ravenscar-thread.c (ravenscar_runtime_initializer)
14863         (has_ravenscar_runtime, get_running_thread_id)
14864         (ravenscar_thread_target::resume): Fix indentation.
14865
14866 2019-02-15  Tom Tromey  <tromey@adacore.com>
14867
14868         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14869         from ravenscar_arch_ops.
14870         (sparc_ravenscar_ops::fetch_registers)
14871         (sparc_ravenscar_ops::store_registers): Now methods.
14872         (sparc_ravenscar_prepare_to_store): Remove.
14873         (sparc_ravenscar_ops): Redefine.
14874         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14875         methods and destructor.  Remove members.
14876         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14877         (ravenscar_thread_target::store_registers)
14878         (ravenscar_thread_target::prepare_to_store): Update.
14879         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14880         Remove.
14881         (struct ppc_ravenscar_powerpc_ops): Derive from
14882         ravenscar_arch_ops.
14883         (ppc_ravenscar_powerpc_ops::fetch_registers)
14884         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14885         (ppc_ravenscar_powerpc_ops): Redefine.
14886         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14887         (ppc_ravenscar_e500_ops::fetch_registers)
14888         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14889         (ppc_ravenscar_e500_ops): Redefine.
14890         * aarch64-ravenscar-thread.c
14891         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14892         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14893         (aarch64_ravenscar_fetch_registers)
14894         (aarch64_ravenscar_store_registers): Now methods.
14895         (aarch64_ravenscar_ops): Redefine.
14896
14897 2019-02-15  Tom Tromey  <tromey@adacore.com>
14898
14899         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14900         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14901         (ravenscar_thread_target::stopped_by_watchpoint)
14902         (ravenscar_thread_target::stopped_data_address)
14903         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14904
14905 2019-02-15  Tom Tromey  <tromey@adacore.com>
14906
14907         * ravenscar-thread.c: Fix some typos.
14908
14909 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14910             Tom Tromey  <tromey@adacore.com>
14911
14912         * ada-lang.c (ada_exception_sal): Change addr_string to a
14913         std::string.
14914         (create_ada_exception_catchpoint): Update.
14915
14916 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14917             Tom Tromey  <tromey@adacore.com>
14918
14919         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14920         (bp_location_ops): Remove.
14921         (base_breakpoint_allocate_location): Update.
14922         (free_bp_location): Update.
14923         * ada-lang.c (class ada_catchpoint_location)
14924         <ada_catchpoint_location>: Remove ops parameter.
14925         (ada_catchpoint_location_dtor): Remove.
14926         (ada_catchpoint_location_ops): Remove.
14927         (allocate_location_exception): Update.
14928         * breakpoint.h (struct bp_location_ops): Remove.
14929         (class bp_location) <bp_location>: Remove bp_location_ops
14930         parameter.
14931         <~bp_location>: Add destructor.
14932         <ops>: Remove.
14933
14934 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14935             Pedro Alves  <palves@redhat.com>
14936
14937         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14938         'PATH_MAX'.
14939
14940 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14941             Samuel Thibault  <samuel.thibault@gnu.org>
14942             Thomas Schwinge  <thomas@codesourcery.com>
14943
14944         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14945         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14946
14947 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14948
14949         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14950         (check_empty): Use "const char *".
14951
14952         * gnu-nat.c (gnu_nat_target::detach): Instead of
14953         'detach_inferior (pid)' call
14954         'detach_inferior (find_inferior_pid (pid))'.
14955
14956         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14957         'nat/fork-inferior.o'.
14958         * gnu-nat.c: #include "nat/fork-inferior.h".
14959
14960         * gnu-nat.c (gnu_nat_target::detach): Instead of
14961         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14962         * gnu-nat.h: #include "inf-child.h".
14963         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14964         'i386_gnu_nat_target::fetch_registers'.
14965         (gnu_store_registers): Rename/move to
14966         'i386_gnu_nat_target::store_registers'.
14967
14968         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14969         * gnu-nat.h (mach_thread_info): New function.
14970         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14971
14972         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14973
14974 2019-02-14  Frederic Konrad  <konrad@adacore.com>
14975
14976         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14977
14978 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14979
14980         * windows-nat.c (windows_add_thread): Add new parameter
14981         "main_thread_p" with default value set to false.  Update
14982         function documentation as well as all callers.
14983         (windows_delete_thread): Likewise.
14984         (fake_create_process): Update call to windows_add_thread.
14985         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14986         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14987         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14988         call to windows_delete_thread.
14989
14990 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14991
14992         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14993
14994 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14995
14996         * symfile.c (find_separate_debug_file): Use canonical path of
14997         sysroot with child_path instead of gdb_sysroot if it is valid.
14998
14999 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15000
15001         * symfile.c (find_separate_debug_file): Use child_path to
15002         determine if an object file is under a sysroot.
15003
15004 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15005
15006         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15007         unittests/child-path-selftests.c.
15008         * common/pathstuff.c (child_path): New function.
15009         * common/pathstuff.h (child_path): New prototype.
15010         * unittests/child-path-selftests.c: New file.
15011
15012 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15013
15014         * symfile.c (find_separate_debug_file): Look for separate debug
15015         files in debug directories under the sysroot.
15016
15017 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15018
15019         * symtab.h (struct minimal_symbol data_p): New const method.
15020         (struct minimal_symbol text_p): Likewise.
15021         * symtab.c (output_source_filename): Use file name style
15022         to print file name.
15023         (print_symbol_info): Likewise.
15024         (print_msymbol_info): Use address style to print addresses.
15025         Use function name style to print executable text symbols.
15026         (expand_symtab_containing_pc): Use data_p.
15027         (find_pc_sect_compunit_symtab): Likewise.
15028
15029 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15030
15031         * breakpoint.c (describe_other_breakpoints): Use address style
15032         to print addresses.
15033         (say_where): Likewise.
15034
15035 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15036
15037         * ada-typeprint.c (print_func_type): Print function name
15038         style to print function name.
15039         * c-typeprint.c (c_print_type_1): Likewise.
15040
15041 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
15042
15043         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15044         for execve.
15045
15046 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15047
15048         * c-exp.y (direct_abs_decl): Use emplace_back to record the
15049         type_stack.
15050
15051 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
15052
15053         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15054         TYPE_CODE_REF types.
15055
15056 2019-02-08  Jim Wilson  <jimw@sifive.com>
15057
15058         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15059         (riscv_linux_fregset): New.
15060         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15061
15062 2019-02-07  Tom Tromey  <tom@tromey.com>
15063
15064         * thread.c (thread_cancel_execution_command): Update.
15065         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15066         methods.
15067         (struct thread_fsm_ops): Remove.
15068         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15069         (thread_fsm_should_stop, thread_fsm_return_value)
15070         (thread_fsm_set_finished, thread_fsm_finished_p)
15071         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15072         Don't declare.
15073         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15074         * infrun.c (clear_proceed_status_thread)
15075         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15076         (print_stop_event): Update.
15077         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15078         Add constructor.
15079         (step_command_fsm_ops): Remove.
15080         (new_step_command_fsm): Remove.
15081         (step_1): Update.
15082         (step_command_fsm::should_stop): Rename from
15083         step_command_fsm_should_stop.
15084         (step_command_fsm::clean_up): Rename from
15085         step_command_fsm_clean_up.
15086         (step_command_fsm::do_async_reply_reason): Rename from
15087         step_command_fsm_async_reply_reason.
15088         (struct until_next_fsm): Inherit from thread_fsm.  Add
15089         constructor.
15090         (until_next_fsm_ops): Remove.
15091         (new_until_next_fsm): Remove.
15092         (until_next_fsm::should_stop): Rename from
15093         until_next_fsm_should_stop.
15094         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15095         (until_next_fsm::do_async_reply_reason): Rename from
15096         until_next_fsm_async_reply_reason.
15097         (struct finish_command_fsm): Inherit from thread_fsm.  Add
15098         constructor.  Change type of breakpoint.
15099         (finish_command_fsm_ops): Remove.
15100         (new_finish_command_fsm): Remove.
15101         (finish_command_fsm::should_stop): Rename from
15102         finish_command_fsm_should_stop.
15103         (finish_command_fsm::clean_up): Rename from
15104         finish_command_fsm_clean_up.
15105         (finish_command_fsm::return_value): Rename from
15106         finish_command_fsm_return_value.
15107         (finish_command_fsm::do_async_reply_reason): Rename from
15108         finish_command_fsm_async_reply_reason.
15109         (finish_command): Update.
15110         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15111         Add constructor.
15112         (call_thread_fsm_ops): Remove.
15113         (call_thread_fsm::call_thread_fsm): Rename from
15114         new_call_thread_fsm.
15115         (call_thread_fsm::should_stop): Rename from
15116         call_thread_fsm_should_stop.
15117         (call_thread_fsm::should_notify_stop): Rename from
15118         call_thread_fsm_should_notify_stop.
15119         (run_inferior_call, call_function_by_hand_dummy): Update.
15120         * cli/cli-interp.c (should_print_stop_to_console): Update.
15121         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15122         Add constructor.  Change type of location_breakpoint,
15123         caller_breakpoint.
15124         (until_break_fsm_ops): Remove.
15125         (new_until_break_fsm): Remove.
15126         (until_break_fsm::should_stop): Rename from
15127         until_break_fsm_should_stop.
15128         (until_break_fsm::clean_up): Rename from
15129         until_break_fsm_clean_up.
15130         (until_break_fsm::do_async_reply_reason): Rename from
15131         until_break_fsm_async_reply_reason.
15132         (until_break_command): Update.
15133         * thread-fsm.c: Remove.
15134         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15135
15136 2019-02-07  Tom Tromey  <tom@tromey.com>
15137
15138         * yy-remap.h: Add include guard.
15139         * xtensa-tdep.h: Add include guard.
15140         * xcoffread.h: Rename include guard.
15141         * varobj-iter.h: Add include guard.
15142         * tui/tui.h: Rename include guard.
15143         * tui/tui-winsource.h: Rename include guard.
15144         * tui/tui-wingeneral.h: Rename include guard.
15145         * tui/tui-windata.h: Rename include guard.
15146         * tui/tui-win.h: Rename include guard.
15147         * tui/tui-stack.h: Rename include guard.
15148         * tui/tui-source.h: Rename include guard.
15149         * tui/tui-regs.h: Rename include guard.
15150         * tui/tui-out.h: Rename include guard.
15151         * tui/tui-layout.h: Rename include guard.
15152         * tui/tui-io.h: Rename include guard.
15153         * tui/tui-hooks.h: Rename include guard.
15154         * tui/tui-file.h: Rename include guard.
15155         * tui/tui-disasm.h: Rename include guard.
15156         * tui/tui-data.h: Rename include guard.
15157         * tui/tui-command.h: Rename include guard.
15158         * tic6x-tdep.h: Add include guard.
15159         * target/waitstatus.h: Rename include guard.
15160         * target/wait.h: Rename include guard.
15161         * target/target.h: Rename include guard.
15162         * target/resume.h: Rename include guard.
15163         * target-float.h: Rename include guard.
15164         * stabsread.h: Add include guard.
15165         * rs6000-tdep.h: Add include guard.
15166         * riscv-fbsd-tdep.h: Add include guard.
15167         * regformats/regdef.h: Rename include guard.
15168         * record.h: Rename include guard.
15169         * python/python.h: Rename include guard.
15170         * python/python-internal.h: Rename include guard.
15171         * python/py-stopevent.h: Rename include guard.
15172         * python/py-ref.h: Rename include guard.
15173         * python/py-record.h: Rename include guard.
15174         * python/py-record-full.h: Rename include guard.
15175         * python/py-record-btrace.h: Rename include guard.
15176         * python/py-instruction.h: Rename include guard.
15177         * python/py-events.h: Rename include guard.
15178         * python/py-event.h: Rename include guard.
15179         * procfs.h: Add include guard.
15180         * proc-utils.h: Add include guard.
15181         * p-lang.h: Add include guard.
15182         * or1k-tdep.h: Rename include guard.
15183         * observable.h: Rename include guard.
15184         * nto-tdep.h: Rename include guard.
15185         * nat/x86-linux.h: Rename include guard.
15186         * nat/x86-linux-dregs.h: Rename include guard.
15187         * nat/x86-gcc-cpuid.h: Add include guard.
15188         * nat/x86-dregs.h: Rename include guard.
15189         * nat/x86-cpuid.h: Rename include guard.
15190         * nat/ppc-linux.h: Rename include guard.
15191         * nat/mips-linux-watch.h: Rename include guard.
15192         * nat/linux-waitpid.h: Rename include guard.
15193         * nat/linux-ptrace.h: Rename include guard.
15194         * nat/linux-procfs.h: Rename include guard.
15195         * nat/linux-osdata.h: Rename include guard.
15196         * nat/linux-nat.h: Rename include guard.
15197         * nat/linux-namespaces.h: Rename include guard.
15198         * nat/linux-btrace.h: Rename include guard.
15199         * nat/glibc_thread_db.h: Rename include guard.
15200         * nat/gdb_thread_db.h: Rename include guard.
15201         * nat/gdb_ptrace.h: Rename include guard.
15202         * nat/fork-inferior.h: Rename include guard.
15203         * nat/amd64-linux-siginfo.h: Rename include guard.
15204         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15205         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15206         * nat/aarch64-linux.h: Rename include guard.
15207         * nat/aarch64-linux-hw-point.h: Rename include guard.
15208         * mn10300-tdep.h: Add include guard.
15209         * mips-linux-tdep.h: Add include guard.
15210         * mi/mi-parse.h: Rename include guard.
15211         * mi/mi-out.h: Rename include guard.
15212         * mi/mi-main.h: Rename include guard.
15213         * mi/mi-interp.h: Rename include guard.
15214         * mi/mi-getopt.h: Rename include guard.
15215         * mi/mi-console.h: Rename include guard.
15216         * mi/mi-common.h: Rename include guard.
15217         * mi/mi-cmds.h: Rename include guard.
15218         * mi/mi-cmd-break.h: Rename include guard.
15219         * m2-lang.h: Add include guard.
15220         * location.h: Rename include guard.
15221         * linux-record.h: Rename include guard.
15222         * linux-nat.h: Add include guard.
15223         * linux-fork.h: Add include guard.
15224         * i386-darwin-tdep.h: Rename include guard.
15225         * hppa-linux-offsets.h: Add include guard.
15226         * guile/guile.h: Rename include guard.
15227         * guile/guile-internal.h: Rename include guard.
15228         * gnu-nat.h: Rename include guard.
15229         * gdb-stabs.h: Rename include guard.
15230         * frv-tdep.h: Add include guard.
15231         * f-lang.h: Add include guard.
15232         * event-loop.h: Add include guard.
15233         * darwin-nat.h: Rename include guard.
15234         * cp-abi.h: Rename include guard.
15235         * config/sparc/nm-sol2.h: Rename include guard.
15236         * config/nm-nto.h: Rename include guard.
15237         * config/nm-linux.h: Add include guard.
15238         * config/i386/nm-i386gnu.h: Rename include guard.
15239         * config/djgpp/nl_types.h: Rename include guard.
15240         * config/djgpp/langinfo.h: Rename include guard.
15241         * compile/gcc-cp-plugin.h: Add include guard.
15242         * compile/gcc-c-plugin.h: Add include guard.
15243         * compile/compile.h: Rename include guard.
15244         * compile/compile-object-run.h: Rename include guard.
15245         * compile/compile-object-load.h: Rename include guard.
15246         * compile/compile-internal.h: Rename include guard.
15247         * compile/compile-cplus.h: Rename include guard.
15248         * compile/compile-c.h: Rename include guard.
15249         * common/xml-utils.h: Rename include guard.
15250         * common/x86-xstate.h: Rename include guard.
15251         * common/version.h: Rename include guard.
15252         * common/vec.h: Rename include guard.
15253         * common/tdesc.h: Rename include guard.
15254         * common/selftest.h: Rename include guard.
15255         * common/scoped_restore.h: Rename include guard.
15256         * common/scoped_mmap.h: Rename include guard.
15257         * common/scoped_fd.h: Rename include guard.
15258         * common/safe-iterator.h: Rename include guard.
15259         * common/run-time-clock.h: Rename include guard.
15260         * common/refcounted-object.h: Rename include guard.
15261         * common/queue.h: Rename include guard.
15262         * common/ptid.h: Rename include guard.
15263         * common/print-utils.h: Rename include guard.
15264         * common/preprocessor.h: Rename include guard.
15265         * common/pathstuff.h: Rename include guard.
15266         * common/observable.h: Rename include guard.
15267         * common/netstuff.h: Rename include guard.
15268         * common/job-control.h: Rename include guard.
15269         * common/host-defs.h: Rename include guard.
15270         * common/gdb_wait.h: Rename include guard.
15271         * common/gdb_vecs.h: Rename include guard.
15272         * common/gdb_unlinker.h: Rename include guard.
15273         * common/gdb_unique_ptr.h: Rename include guard.
15274         * common/gdb_tilde_expand.h: Rename include guard.
15275         * common/gdb_sys_time.h: Rename include guard.
15276         * common/gdb_string_view.h: Rename include guard.
15277         * common/gdb_splay_tree.h: Rename include guard.
15278         * common/gdb_setjmp.h: Rename include guard.
15279         * common/gdb_ref_ptr.h: Rename include guard.
15280         * common/gdb_optional.h: Rename include guard.
15281         * common/gdb_locale.h: Rename include guard.
15282         * common/gdb_assert.h: Rename include guard.
15283         * common/filtered-iterator.h: Rename include guard.
15284         * common/filestuff.h: Rename include guard.
15285         * common/fileio.h: Rename include guard.
15286         * common/environ.h: Rename include guard.
15287         * common/common-utils.h: Rename include guard.
15288         * common/common-types.h: Rename include guard.
15289         * common/common-regcache.h: Rename include guard.
15290         * common/common-inferior.h: Rename include guard.
15291         * common/common-gdbthread.h: Rename include guard.
15292         * common/common-exceptions.h: Rename include guard.
15293         * common/common-defs.h: Rename include guard.
15294         * common/common-debug.h: Rename include guard.
15295         * common/cleanups.h: Rename include guard.
15296         * common/buffer.h: Rename include guard.
15297         * common/btrace-common.h: Rename include guard.
15298         * common/break-common.h: Rename include guard.
15299         * cli/cli-utils.h: Rename include guard.
15300         * cli/cli-style.h: Rename include guard.
15301         * cli/cli-setshow.h: Rename include guard.
15302         * cli/cli-script.h: Rename include guard.
15303         * cli/cli-interp.h: Rename include guard.
15304         * cli/cli-decode.h: Rename include guard.
15305         * cli/cli-cmds.h: Rename include guard.
15306         * charset-list.h: Add include guard.
15307         * buildsym-legacy.h: Rename include guard.
15308         * bfin-tdep.h: Add include guard.
15309         * ax.h: Rename include guard.
15310         * arm-linux-tdep.h: Add include guard.
15311         * arm-fbsd-tdep.h: Add include guard.
15312         * arch/xtensa.h: Rename include guard.
15313         * arch/tic6x.h: Add include guard.
15314         * arch/i386.h: Add include guard.
15315         * arch/arm.h: Rename include guard.
15316         * arch/arm-linux.h: Rename include guard.
15317         * arch/arm-get-next-pcs.h: Rename include guard.
15318         * arch/amd64.h: Add include guard.
15319         * arch/aarch64-insn.h: Rename include guard.
15320         * arch-utils.h: Rename include guard.
15321         * annotate.h: Add include guard.
15322         * amd64-darwin-tdep.h: Rename include guard.
15323         * aarch64-linux-tdep.h: Add include guard.
15324         * aarch64-fbsd-tdep.h: Add include guard.
15325         * aarch32-linux-nat.h: Add include guard.
15326
15327 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15328
15329         * macrotab.c (macro_define_internal): New function that
15330         factorizes macro_define_object_internal and macro_define_function
15331         code.
15332         (macro_define_object_internal): Use macro_define_internal.
15333         (macro_define_function): Likewise.
15334
15335 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15336
15337         * macrocmd.c (extract_identifier): Return
15338         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15339         callers.
15340
15341 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15342
15343         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15344
15345 2019-02-05  Tom Tromey  <tom@tromey.com>
15346
15347         * target.c (target_stack::unpush): Move assertion earlier.
15348
15349 2019-01-30  Tom Tromey  <tom@tromey.com>
15350
15351         PR python/23615:
15352         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15353         (gdbpy_parse_and_eval): Likewise.
15354         * python/python-internal.h (gdbpy_allow_threads): New class.
15355
15356 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15357
15358         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15359         (aarch64_fbsd_fpregmap): Move earlier.
15360         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15361         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15362         instead of individual calls to trad_frame_set_reg_addr.
15363         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15364         earlier.
15365         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15366         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15367         instead of individual calls to trad_frame_set_reg_addr.
15368
15369 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15370
15371         * CONTRIBUTE: Replace contribution list with wiki link.
15372
15373 2019-01-25  Tom Tromey  <tom@tromey.com>
15374
15375         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15376
15377 2019-01-25  Tom Tromey  <tom@tromey.com>
15378
15379         * xtensa-linux-nat.c: Fix common/ includes.
15380         * xml-support.h: Fix common/ includes.
15381         * xml-support.c: Fix common/ includes.
15382         * x86-linux-nat.c: Fix common/ includes.
15383         * windows-nat.c: Fix common/ includes.
15384         * varobj.h: Fix common/ includes.
15385         * varobj.c: Fix common/ includes.
15386         * value.c: Fix common/ includes.
15387         * valops.c: Fix common/ includes.
15388         * utils.c: Fix common/ includes.
15389         * unittests/xml-utils-selftests.c: Fix common/ includes.
15390         * unittests/utils-selftests.c: Fix common/ includes.
15391         * unittests/unpack-selftests.c: Fix common/ includes.
15392         * unittests/tracepoint-selftests.c: Fix common/ includes.
15393         * unittests/style-selftests.c: Fix common/ includes.
15394         * unittests/string_view-selftests.c: Fix common/ includes.
15395         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15396         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15397         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15398         * unittests/rsp-low-selftests.c: Fix common/ includes.
15399         * unittests/parse-connection-spec-selftests.c: Fix common/
15400         includes.
15401         * unittests/optional-selftests.c: Fix common/ includes.
15402         * unittests/offset-type-selftests.c: Fix common/ includes.
15403         * unittests/observable-selftests.c: Fix common/ includes.
15404         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15405         * unittests/memrange-selftests.c: Fix common/ includes.
15406         * unittests/memory-map-selftests.c: Fix common/ includes.
15407         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15408         * unittests/function-view-selftests.c: Fix common/ includes.
15409         * unittests/environ-selftests.c: Fix common/ includes.
15410         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15411         * unittests/common-utils-selftests.c: Fix common/ includes.
15412         * unittests/cli-utils-selftests.c: Fix common/ includes.
15413         * unittests/array-view-selftests.c: Fix common/ includes.
15414         * ui-file.c: Fix common/ includes.
15415         * tui/tui-io.c: Fix common/ includes.
15416         * tracepoint.h: Fix common/ includes.
15417         * tracepoint.c: Fix common/ includes.
15418         * tracefile-tfile.c: Fix common/ includes.
15419         * top.h: Fix common/ includes.
15420         * top.c: Fix common/ includes.
15421         * thread.c: Fix common/ includes.
15422         * target/waitstatus.h: Fix common/ includes.
15423         * target/waitstatus.c: Fix common/ includes.
15424         * target.h: Fix common/ includes.
15425         * target.c: Fix common/ includes.
15426         * target-memory.c: Fix common/ includes.
15427         * target-descriptions.c: Fix common/ includes.
15428         * symtab.h: Fix common/ includes.
15429         * symfile.c: Fix common/ includes.
15430         * stap-probe.c: Fix common/ includes.
15431         * spu-linux-nat.c: Fix common/ includes.
15432         * sparc-nat.c: Fix common/ includes.
15433         * source.c: Fix common/ includes.
15434         * solib.c: Fix common/ includes.
15435         * solib-target.c: Fix common/ includes.
15436         * ser-unix.c: Fix common/ includes.
15437         * ser-tcp.c: Fix common/ includes.
15438         * ser-pipe.c: Fix common/ includes.
15439         * ser-base.c: Fix common/ includes.
15440         * selftest-arch.c: Fix common/ includes.
15441         * s12z-tdep.c: Fix common/ includes.
15442         * rust-exp.y: Fix common/ includes.
15443         * rs6000-aix-tdep.c: Fix common/ includes.
15444         * riscv-tdep.c: Fix common/ includes.
15445         * remote.c: Fix common/ includes.
15446         * remote-notif.h: Fix common/ includes.
15447         * remote-fileio.h: Fix common/ includes.
15448         * remote-fileio.c: Fix common/ includes.
15449         * regcache.h: Fix common/ includes.
15450         * regcache.c: Fix common/ includes.
15451         * record-btrace.c: Fix common/ includes.
15452         * python/python.c: Fix common/ includes.
15453         * python/py-type.c: Fix common/ includes.
15454         * python/py-inferior.c: Fix common/ includes.
15455         * progspace.h: Fix common/ includes.
15456         * producer.c: Fix common/ includes.
15457         * procfs.c: Fix common/ includes.
15458         * proc-api.c: Fix common/ includes.
15459         * printcmd.c: Fix common/ includes.
15460         * ppc-linux-nat.c: Fix common/ includes.
15461         * parser-defs.h: Fix common/ includes.
15462         * osdata.c: Fix common/ includes.
15463         * obsd-nat.c: Fix common/ includes.
15464         * nat/x86-linux.c: Fix common/ includes.
15465         * nat/x86-linux-dregs.c: Fix common/ includes.
15466         * nat/x86-dregs.h: Fix common/ includes.
15467         * nat/x86-dregs.c: Fix common/ includes.
15468         * nat/ppc-linux.c: Fix common/ includes.
15469         * nat/mips-linux-watch.h: Fix common/ includes.
15470         * nat/mips-linux-watch.c: Fix common/ includes.
15471         * nat/linux-waitpid.c: Fix common/ includes.
15472         * nat/linux-ptrace.h: Fix common/ includes.
15473         * nat/linux-ptrace.c: Fix common/ includes.
15474         * nat/linux-procfs.c: Fix common/ includes.
15475         * nat/linux-personality.c: Fix common/ includes.
15476         * nat/linux-osdata.c: Fix common/ includes.
15477         * nat/linux-namespaces.c: Fix common/ includes.
15478         * nat/linux-btrace.h: Fix common/ includes.
15479         * nat/linux-btrace.c: Fix common/ includes.
15480         * nat/fork-inferior.c: Fix common/ includes.
15481         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15482         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15483         * nat/aarch64-linux.c: Fix common/ includes.
15484         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15485         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15486         * namespace.h: Fix common/ includes.
15487         * mips-linux-tdep.c: Fix common/ includes.
15488         * minsyms.c: Fix common/ includes.
15489         * mi/mi-parse.h: Fix common/ includes.
15490         * mi/mi-main.c: Fix common/ includes.
15491         * mi/mi-cmd-env.c: Fix common/ includes.
15492         * memrange.h: Fix common/ includes.
15493         * memattr.c: Fix common/ includes.
15494         * maint.h: Fix common/ includes.
15495         * maint.c: Fix common/ includes.
15496         * main.c: Fix common/ includes.
15497         * machoread.c: Fix common/ includes.
15498         * location.c: Fix common/ includes.
15499         * linux-thread-db.c: Fix common/ includes.
15500         * linux-nat.c: Fix common/ includes.
15501         * linux-fork.c: Fix common/ includes.
15502         * inline-frame.c: Fix common/ includes.
15503         * infrun.c: Fix common/ includes.
15504         * inflow.c: Fix common/ includes.
15505         * inferior.h: Fix common/ includes.
15506         * inferior.c: Fix common/ includes.
15507         * infcmd.c: Fix common/ includes.
15508         * inf-ptrace.c: Fix common/ includes.
15509         * inf-child.c: Fix common/ includes.
15510         * ia64-linux-nat.c: Fix common/ includes.
15511         * i387-tdep.c: Fix common/ includes.
15512         * i386-tdep.c: Fix common/ includes.
15513         * i386-linux-tdep.c: Fix common/ includes.
15514         * i386-linux-nat.c: Fix common/ includes.
15515         * i386-go32-tdep.c: Fix common/ includes.
15516         * i386-fbsd-tdep.c: Fix common/ includes.
15517         * i386-fbsd-nat.c: Fix common/ includes.
15518         * guile/scm-type.c: Fix common/ includes.
15519         * guile/guile.c: Fix common/ includes.
15520         * go32-nat.c: Fix common/ includes.
15521         * gnu-nat.c: Fix common/ includes.
15522         * gdbthread.h: Fix common/ includes.
15523         * gdbarch-selftests.c: Fix common/ includes.
15524         * gdb_usleep.c: Fix common/ includes.
15525         * gdb_select.h: Fix common/ includes.
15526         * gdb_bfd.c: Fix common/ includes.
15527         * gcore.c: Fix common/ includes.
15528         * fork-child.c: Fix common/ includes.
15529         * findvar.c: Fix common/ includes.
15530         * fbsd-nat.c: Fix common/ includes.
15531         * event-top.c: Fix common/ includes.
15532         * event-loop.c: Fix common/ includes.
15533         * dwarf2read.c: Fix common/ includes.
15534         * dwarf2loc.c: Fix common/ includes.
15535         * dwarf2-frame.c: Fix common/ includes.
15536         * dwarf-index-cache.c: Fix common/ includes.
15537         * dtrace-probe.c: Fix common/ includes.
15538         * disasm-selftests.c: Fix common/ includes.
15539         * defs.h: Fix common/ includes.
15540         * csky-tdep.c: Fix common/ includes.
15541         * cp-valprint.c: Fix common/ includes.
15542         * cp-support.h: Fix common/ includes.
15543         * cp-support.c: Fix common/ includes.
15544         * corelow.c: Fix common/ includes.
15545         * completer.h: Fix common/ includes.
15546         * completer.c: Fix common/ includes.
15547         * compile/compile.c: Fix common/ includes.
15548         * compile/compile-loc2c.c: Fix common/ includes.
15549         * compile/compile-cplus-types.c: Fix common/ includes.
15550         * compile/compile-cplus-symbols.c: Fix common/ includes.
15551         * command.h: Fix common/ includes.
15552         * cli/cli-dump.c: Fix common/ includes.
15553         * cli/cli-cmds.c: Fix common/ includes.
15554         * charset.c: Fix common/ includes.
15555         * build-id.c: Fix common/ includes.
15556         * btrace.h: Fix common/ includes.
15557         * btrace.c: Fix common/ includes.
15558         * breakpoint.h: Fix common/ includes.
15559         * breakpoint.c: Fix common/ includes.
15560         * ax.h:
15561         (enum agent_op): Fix common/ includes.
15562         * ax-general.c (struct aop_map): Fix common/ includes.
15563         * ax-gdb.c: Fix common/ includes.
15564         * auxv.c: Fix common/ includes.
15565         * auto-load.c: Fix common/ includes.
15566         * arm-tdep.c: Fix common/ includes.
15567         * arch/riscv.c: Fix common/ includes.
15568         * arch/ppc-linux-common.c: Fix common/ includes.
15569         * arch/i386.c: Fix common/ includes.
15570         * arch/arm.c: Fix common/ includes.
15571         * arch/arm-linux.c: Fix common/ includes.
15572         * arch/arm-get-next-pcs.c: Fix common/ includes.
15573         * arch/amd64.c: Fix common/ includes.
15574         * arch/aarch64.c: Fix common/ includes.
15575         * arch/aarch64-insn.c: Fix common/ includes.
15576         * arch-utils.c: Fix common/ includes.
15577         * amd64-windows-tdep.c: Fix common/ includes.
15578         * amd64-tdep.c: Fix common/ includes.
15579         * amd64-sol2-tdep.c: Fix common/ includes.
15580         * amd64-obsd-tdep.c: Fix common/ includes.
15581         * amd64-nbsd-tdep.c: Fix common/ includes.
15582         * amd64-linux-tdep.c: Fix common/ includes.
15583         * amd64-linux-nat.c: Fix common/ includes.
15584         * amd64-fbsd-tdep.c: Fix common/ includes.
15585         * amd64-fbsd-nat.c: Fix common/ includes.
15586         * amd64-dicos-tdep.c: Fix common/ includes.
15587         * amd64-darwin-tdep.c: Fix common/ includes.
15588         * agent.c: Fix common/ includes.
15589         * ada-lang.h: Fix common/ includes.
15590         * ada-lang.c: Fix common/ includes.
15591         * aarch64-tdep.c: Fix common/ includes.
15592
15593 2019-01-25  Tom Tromey  <tom@tromey.com>
15594
15595         * common/create-version.sh: Use common/version.h.
15596
15597 2019-01-24  Pedro Alves  <palves@redhat.com>
15598
15599         * infrun.c (signal_stop, signal_print, signal_program)
15600         (signal_catch, signal_pass): Now arrays instead of pointers.
15601         (update_signals_program_target, do_target_resume)
15602         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15603         * linux-nat.c (linux_nat_target::pass_signals)
15604         (linux_nat_target::create_inferior, linux_nat_target::attach):
15605         Adjust.
15606         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15607         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15608         * procfs.c (procfs_target::pass_signals): Adjust.
15609         * record-full.c (record_full_target::resume): Adjust.
15610         * remote.c (remote_target::pass_signals)
15611         (remote_target::program_signals): Adjust.
15612         * target-debug.h (target_debug_print_signals): Now takes a
15613         gdb::array_view as parameter.  Adjust.
15614         * target.h (target_ops) <pass_signals, program_signals>: Replace
15615         pointer and length parameters with gdb::array_view.
15616         (target_pass_signals, target_program_signals): Likewise.
15617         * target-delegates.c: Regenerate.
15618
15619 2019-01-24  Pedro Alves  <palves@redhat.com>
15620
15621         * common/forward-scope-exit.h
15622         (forward_scope_exit::forward_scope_exit): Pass arguments to
15623         m_bind_function directly, instead of creating a std::bind and
15624         copying that.
15625
15626 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15627
15628         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15629         for static members.
15630         (pass_in_v_vfp_candidate): Likewise.
15631
15632 2019-01-23  Tom Tromey  <tom@tromey.com>
15633             Pedro Alves  <palves@redhat.com>
15634
15635         * regcache.c (class regcache_invalidator): Remove.
15636         (regcache::raw_write): Use make_scope_exit.
15637
15638 2019-01-23  Tom Tromey  <tom@tromey.com>
15639
15640         * ui-out.h (class ui_out_emit_type): Update comment.
15641
15642 2019-01-23  Tom Tromey  <tom@tromey.com>
15643
15644         * infrun.c (fetch_inferior_event): Update comment.
15645
15646 2019-01-23  Tom Tromey  <tom@tromey.com>
15647             Pedro Alves  <palves@redhat.com>
15648
15649         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15650         parameter.
15651         (fetch_inferior_event): Use SCOPE_EXIT.
15652
15653
15654 2019-01-23  Tom Tromey  <tom@tromey.com>
15655             Pedro Alves  <palves@redhat.com>
15656
15657         * infrun.c (disable_thread_events): Delete.
15658         (stop_all_threads): Use SCOPE_EXIT.
15659
15660 2019-01-23  Tom Tromey  <tom@tromey.com>
15661             Pedro Alves  <palves@redhat.com>
15662
15663         * symfile.c: Include forward-scope-exit.h.
15664         (clear_symtab_users_cleanup): Replace forward declaration with
15665         a FORWARD_SCOPE_EXIT.
15666         (syms_from_objfile_1): Use the forward_scope_exit and
15667         gdb::optional instead of cleanup_function.
15668         (reread_symbols): Use the forward_scope_exit instead of
15669         cleanup_function.
15670         (clear_symtab_users_cleanup): Remove function.
15671
15672 2019-01-23  Tom Tromey  <tom@tromey.com>
15673             Pedro Alves  <palves@redhat.com>
15674
15675         * linux-nat.c: Include scope-exit.h.
15676         (cleanup_target_stop): Remove.
15677         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15678         SCOPE_EXIT.
15679
15680 2019-01-23  Tom Tromey  <tom@tromey.com>
15681             Pedro Alves  <palves@redhat.com>
15682
15683         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15684         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15685
15686 2019-01-23  Tom Tromey  <tom@tromey.com>
15687             Andrew Burgess  <andrew.burgess@embecosm.com>
15688             Pedro Alves  <palves@redhat.com>
15689
15690         * infrun.c (fetch_inferior_event): Use scope_exit.
15691         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15692         * top.c (execute_command): Use scope_exit.
15693         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15694         * utils.c (do_bpstat_clear_actions_cleanup)
15695         (make_bpstat_clear_actions_cleanup): Remove.
15696
15697 2019-01-23  Tom Tromey  <tom@tromey.com>
15698             Pedro Alves  <palves@redhat.com>
15699
15700         * infrun.c: Include "common/scope-exit.h"
15701         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15702         (wait_for_inferior): Use SCOPE_EXIT.
15703         (fetch_inferior_event): Use scope_exit.
15704
15705 2019-01-23  Tom Tromey  <tom@tromey.com>
15706             Pedro Alves  <palves@redhat.com>
15707
15708         * breakpoint.c (create_breakpoint): Remove cleanup.
15709
15710 2019-01-23  Tom Tromey  <tom@tromey.com>
15711             Andrew Burgess  <andrew.burgess@embecosm.com>
15712             Pedro Alves  <palves@redhat.com>
15713
15714 2019-01-23  Pedro Alves  <palves@redhat.com>
15715
15716         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15717
15718 2019-01-23  Pedro Alves  <palves@redhat.com>
15719             Andrew Burgess  <andrew.burgess@embecosm.com>
15720
15721         * gdbthread.h: Include "common/forward-scope-exit.h".
15722         (scoped_finish_thread_state): Redefine custom class in terms of
15723         forward_scope_exit.
15724
15725 2019-01-23  Pedro Alves  <palves@redhat.com>
15726             Andrew Burgess  <andrew.burgess@embecosm.com>
15727
15728         * common/forward-scope-exit.h: New file.
15729
15730 2019-01-23  Pedro Alves  <palves@redhat.com>
15731             Andrew Burgess  <andrew.burgess@embecosm.com>
15732             Tom Tromey  <tom@tromey.com>
15733
15734         * common/scope-exit.h: New file.
15735
15736 2019-01-23  Pedro Alves  <palves@redhat.com>
15737
15738         * common/preprocessor.h (ESC): Rename to ...
15739         (ESC_PARENS): ... this.
15740         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15741         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15742
15743 2019-01-23  Tom Tromey  <tom@tromey.com>
15744
15745         * language.h (class scoped_switch_to_sym_language_if_auto):
15746         Initialize m_lang in both cases.
15747
15748 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15749
15750         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15751         with XCNEW.
15752
15753 2019-01-22  Tom Tromey  <tom@tromey.com>
15754
15755         * corelow.c: Do not include sys/file.h.
15756
15757 2019-01-22  Tom Tromey  <tom@tromey.com>
15758
15759         * tui/tui-wingeneral.h: Include gdb_curses.h.
15760
15761 2019-01-22  Tom Tromey  <tom@tromey.com>
15762
15763         * source-cache.h (class source_cache) <get_source_lines,
15764         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15765
15766 2019-01-22  Tom Tromey  <tom@tromey.com>
15767
15768         * remote-fileio.h (struct remote_target): Declare.
15769
15770 2019-01-22  Tom Tromey  <tom@tromey.com>
15771
15772         * python/py-arch.c: Do not include py-ref.h.
15773         * python/py-bpevent.c: Do not include py-ref.h.
15774         * python/py-cmd.c: Do not include py-ref.h.
15775         * python/py-continueevent.c: Do not include py-ref.h.
15776         * python/py-event.h: Do not include py-ref.h.
15777         * python/py-evtregistry.c: Do not include py-ref.h.
15778         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15779         * python/py-frame.c: Do not include py-ref.h.
15780         * python/py-framefilter.c: Do not include py-ref.h.
15781         * python/py-function.c: Do not include py-ref.h.
15782         * python/py-infevents.c: Do not include py-ref.h.
15783         * python/py-linetable.c: Do not include py-ref.h.
15784         * python/py-objfile.c: Do not include py-ref.h.
15785         * python/py-param.c: Do not include py-ref.h.
15786         * python/py-prettyprint.c: Do not include py-ref.h.
15787         * python/py-progspace.c: Do not include py-ref.h.
15788         * python/py-symbol.c: Do not include py-ref.h.
15789         * python/py-symtab.c: Do not include py-ref.h.
15790         * python/py-type.c: Do not include py-ref.h.
15791         * python/py-unwind.c: Do not include py-ref.h.
15792         * python/py-utils.c: Do not include py-ref.h.
15793         * python/py-value.c: Do not include py-ref.h.
15794         * python/py-varobj.c: Do not include py-ref.h.
15795         * python/py-xmethods.c: Do not include py-ref.h.
15796         * python/python.c: Do not include py-ref.h.
15797         * varobj.c: Do not include py-ref.h.
15798
15799 2019-01-22  Tom Tromey  <tom@tromey.com>
15800
15801         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15802         keyword for bcache.
15803
15804 2019-01-22  Tom Tromey  <tom@tromey.com>
15805
15806         * compile/compile-cplus-types.c: Remove a comment by #include.
15807
15808 2019-01-22  Tom Tromey  <tom@tromey.com>
15809
15810         * compile/gcc-c-plugin.h: Include compile-internal.h.
15811
15812 2019-01-22  Tom Tromey  <tom@tromey.com>
15813
15814         * stabsread.c (EXTERN): Do not define.
15815         (symnum, next_symbol_text_func, processing_gcc_compilation)
15816         (within_function, global_sym_chain, global_stabs)
15817         (previous_stab_code, this_object_header_files)
15818         (n_this_object_header_files)
15819         (n_allocated_this_object_header_files): Define.
15820         * stabsread.h (EXTERN): Never define.  Use "extern".
15821
15822 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15823
15824         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15825         history_value.
15826
15827 2019-01-21  Tom Tromey  <tom@tromey.com>
15828
15829         * ui-out.c: Fix includes.
15830         * tui/tui-source.c: Fix includes.
15831         * target.c: Fix includes.
15832         * remote.c: Fix includes.
15833         * regcache.c: Fix includes.
15834         * python/py-block.c: Fix includes.
15835         * printcmd.c: Fix includes.
15836         * or1k-tdep.c: Fix includes.
15837         * mi/mi-main.c: Fix includes.
15838         * m32r-tdep.c: Fix includes.
15839         * csky-tdep.c: Fix includes.
15840         * compile/compile-cplus-types.c: Fix includes.
15841         * cli/cli-interp.c: Fix includes.
15842
15843 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15844
15845         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15846         for padding.
15847
15848 2019-01-16  Tom Tromey  <tom@tromey.com>
15849
15850         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15851         earlier.
15852         (struct objfile) <msymbols_range>: Move from top level.
15853         <msymbols>: New method.
15854         (class objfile_msymbols): Remove.
15855         * symtab.c (default_collect_symbol_completion_matches_break_on):
15856         Update.
15857         * symmisc.c (dump_msymbols): Update.
15858         * stabsread.c (scan_file_globals): Update.
15859         * objc-lang.c (info_selectors_command, info_classes_command)
15860         (find_methods): Update.
15861         * minsyms.c (find_solib_trampoline_target): Update.
15862         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15863         * coffread.c (coff_symfile_read): Update.
15864         * ada-lang.c (ada_lookup_simple_minsym)
15865         (ada_collect_symbol_completion_matches): Update.
15866
15867 2019-01-16  Tom Tromey  <tom@tromey.com>
15868
15869         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15870         type.  Remove no-argument constructor.
15871         <iterator::operator++>: Simplify.
15872         <begin>: Update.
15873         <end>: Use minimal_symbol_count.
15874
15875 2019-01-16  Tom Tromey  <tom@tromey.com>
15876
15877         * objfiles.h (struct objfile) <psymtabs>: New method.
15878         (class objfile_psymtabs): Remove.
15879         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15880         typedef.
15881         <range>: New method.
15882         (require_partial_symbols): Change return type.
15883         * psymtab.c (require_partial_symbols)
15884         (psym_expand_symtabs_matching): Update.
15885         * mdebugread.c (parse_partial_symbols): Update.
15886         * dbxread.c (dbx_end_psymtab): Update.
15887
15888 2019-01-15  Tom Tromey  <tom@tromey.com>
15889
15890         * symtab.c (lookup_objfile_from_block)
15891         (lookup_symbol_in_objfile_symtabs)
15892         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15893         (find_line_symtab, info_sources_command)
15894         (default_collect_symbol_completion_matches_break_on)
15895         (make_source_files_completion_list): Update.
15896         * symmisc.c (print_objfile_statistics, dump_objfile)
15897         (maintenance_print_symbols, maintenance_info_symtabs)
15898         (maintenance_check_symtabs, maintenance_info_line_tables):
15899         Update.
15900         * source.c (select_source_symtab)
15901         (forget_cached_source_info_for_objfile): Update.
15902         * objfiles.h (class objfile_compunits): Remove.
15903         (struct objfile) <compunits_range>: New typedef.
15904         (compunits): New method.
15905         * objfiles.c (objfile_relocate1): Update.
15906         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15907         * maint.c (count_symtabs_and_blocks): Update.
15908         * linespec.c (iterate_over_all_matching_symtabs): Update.
15909         * cp-support.c (add_symbol_overload_list_qualified): Update.
15910         * coffread.c (coff_symtab_read): Update.
15911         * ada-lang.c (add_nonlocal_symbols)
15912         (ada_collect_symbol_completion_matches)
15913         (ada_add_global_exceptions): Update.
15914
15915 2019-01-15  Tom Tromey  <tom@tromey.com>
15916
15917         * progspace.h (program_space) <objfiles_safe_range>: New
15918         typedef.
15919         <objfiles_safe>: New method.
15920         * objfiles.h (class all_objfiles_safe): Remove.
15921         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15922         * jit.c (jit_inferior_exit_hook): Update.
15923
15924 2019-01-17  Tom Tromey  <tom@tromey.com>
15925
15926         * progspace.h (program_space) <objfiles_range>: New typedef.
15927         <objfiles>: New method.
15928         <objfiles_head>: Rename from objfiles.
15929         (object_files): Update.
15930         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15931         * guile/scm-pretty-print.c
15932         (ppscm_find_pretty_printer_from_objfiles): Update.
15933         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15934         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15935         Update.
15936         * python/py-progspace.c (pspy_get_objfiles): Update.
15937         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15938         Update.
15939         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15940         (objfpy_lookup_objfile_by_build_id): Update.
15941         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15942         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15943         Update.
15944         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15945         (expand_symtab_containing_pc, lookup_objfile_from_block)
15946         (lookup_static_symbol, basic_lookup_transparent_type)
15947         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15948         (find_line_symtab, info_sources_command)
15949         (default_collect_symbol_completion_matches_break_on)
15950         (make_source_files_completion_list, find_main_name): Update.
15951         * symmisc.c (print_symbol_bcache_statistics)
15952         (print_objfile_statistics, maintenance_print_symbols)
15953         (maintenance_print_msymbols, maintenance_print_objfiles)
15954         (maintenance_info_symtabs, maintenance_check_symtabs)
15955         (maintenance_expand_symtabs, maintenance_info_line_tables):
15956         Update.
15957         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15958         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15959         (map_overlay_command, unmap_overlay_command)
15960         (simple_overlay_update, expand_symtabs_matching)
15961         (map_symbol_filenames): Update.
15962         * symfile-debug.c (set_debug_symfile): Update.
15963         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15964         Update.
15965         * source.c (select_source_symtab, forget_cached_source_info):
15966         Update.
15967         * solib.c (solib_read_symbols): Update.
15968         * solib-spu.c (append_ocl_sos): Update.
15969         * psymtab.c (maintenance_print_psymbols)
15970         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15971         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15972         * printcmd.c (info_symbol_command): Update.
15973         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15974         Update.
15975         * objfiles.h (class all_objfiles): Remove.
15976         * objfiles.c (have_partial_symbols, have_full_symbols)
15977         (have_minimal_symbols, qsort_cmp, update_section_map)
15978         (shared_objfile_contains_address_p)
15979         (default_iterate_over_objfiles_in_search_order): Update.
15980         * objc-lang.c (info_selectors_command, info_classes_command)
15981         (find_methods): Update.
15982         * minsyms.c (find_solib_trampoline_target): Update.
15983         * maint.c (maintenance_info_sections)
15984         (maintenance_translate_address, count_symtabs_and_blocks):
15985         Update.
15986         * main.c (captured_main_1): Update.
15987         * linux-thread-db.c (try_thread_db_load_from_pdir)
15988         (has_libpthread): Update.
15989         * linespec.c (iterate_over_all_matching_symtabs)
15990         (search_minsyms_for_name): Update.
15991         * jit.c (jit_find_objf_with_entry_addr): Update.
15992         * hppa-tdep.c (find_unwind_entry)
15993         (hppa_lookup_stub_minimal_symbol): Update.
15994         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15995         Update.
15996         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15997         (elf_gnu_ifunc_resolve_by_got): Update.
15998         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15999         * dwarf-index-write.c (save_gdb_index_command): Update.
16000         * cp-support.c (add_symbol_overload_list_qualified): Update.
16001         * breakpoint.c (create_overlay_event_breakpoint)
16002         (create_longjmp_master_breakpoint)
16003         (create_std_terminate_master_breakpoint)
16004         (create_exception_master_breakpoint): Update.
16005         * blockframe.c (find_pc_partial_function): Update.
16006         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16007         (ada_collect_symbol_completion_matches)
16008         (ada_add_global_exceptions): Update.
16009
16010 2019-01-17  Tom Tromey  <tom@tromey.com>
16011
16012         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
16013         declare VEC.
16014         (solib_target_parse_libraries): Change return type.
16015         (library_list_start_segment, library_list_start_section)
16016         (library_list_end_library, library_list_start_library); Update.
16017         (solib_target_free_library_list): Remove.
16018         (solib_target_parse_libraries): Remove cleanup.  Change return
16019         type.
16020         (solib_target_current_sos): Update.
16021
16022 2019-01-17  Tom Tromey  <tromey@bapiya>
16023
16024         * valprint.c: Replace "the the" with "the".
16025         * symtab.c: Replace "the the" with "the".
16026         * solib.c: Replace "the the" with "the".
16027         * solib-dsbt.c: Replace "the the" with "the".
16028         * linespec.c: Replace "the the" with "the".
16029         * dwarf2loc.h: Replace "the the" with "the".
16030         * amd64-windows-tdep.c: Replace "the the" with "the".
16031         * aarch64-tdep.c: Replace "the the" with "the".
16032
16033 2019-01-16  Keith Seitz  <keiths@redhat.com>
16034
16035         PR gdb/23773
16036         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16037         <builder>: Rename to ..
16038         <m_builder>: ... this and make private.
16039         (dwarf2_cu::get_builder): New method.  Change all users of
16040         `builder' to use this method.
16041         (dwarf2_start_symtab): Move to ...
16042         (dwarf2_cu::start_symtab): ... here.  Update all callers
16043         (setup_type_unit_groups): Move to ...
16044         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
16045         callers.
16046         (dwarf2_cu::reset_builder): New method.
16047         (process_full_compunit, process_full_type_unit): Use
16048         dwarf2_cu::reset_builder.
16049         (follow_die_offset): Record the ancestor CU if it is different
16050         from the followed DIE's CU.
16051         (follow_die_sig_1): Likewise.
16052
16053 2019-01-15  Tom Tromey  <tom@tromey.com>
16054
16055         * remote.c (class remote_state) <buf>: Now a char_vector.
16056         <buf_size>: Remove.
16057         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
16058         parameter.
16059         (remote_target::getpkt_or_notif_sane_1)
16060         (remote_target::getpkt_sane)
16061         (remote_target::getpkt_or_notif_sane): Likewise.
16062         (class remote_target) <putpkt>: New overload.
16063         (remote_target::read_frame): Change type of "buf_p".  Remove
16064         sizeof_p parameter.
16065         (packet_ok): New overload.
16066         (packet_check_result): New overload.
16067         Update all uses.
16068
16069 2019-01-14  Tom Tromey  <tom@tromey.com>
16070
16071         * remote-notif.c (handle_notification, remote_notif_ack)
16072         (remote_notif_parse): Make "buf" const.
16073         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16074         const.
16075         (remote_notif_parse, remote_notif_ack, handle_notification):
16076         Likewise.
16077         * remote.c (remote_notif_stop_parse): Make "buf" const.
16078         (remote_target::remote_parse_stop_reply): Make "buf" const.
16079         (remote_notif_stop_ack): Make "buf" const.
16080
16081 2019-01-14  Tom Tromey  <tom@tromey.com>
16082
16083         * remote.c (remote_console_output): Make parameter const.
16084
16085 2019-01-14  Tom Tromey  <tom@tromey.com>
16086
16087         * target-debug.h (target_debug_print_signals): Constify.
16088         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16089         * procfs.c (procfs_target::pass_signals): Update.
16090         * linux-nat.c (linux_nat_target::pass_signals): Update.
16091         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16092         * target-delegates.c: Rebuild.
16093         * remote.c (remote_target::program_signals): Update.
16094         (remote_target::pass_signals): Update.
16095         * target.c (target_pass_signals): Constify argument.
16096         (target_program_signals): Likewise.
16097         * target.h (struct target_ops) <pass_signals, program_signals>:
16098         Constify argument.
16099         (target_pass_signals, target_program_signals): Constify argument.
16100
16101 2019-01-14  Tom Tromey  <tom@tromey.com>
16102
16103         PR tui/28819:
16104         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16105
16106 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
16107
16108         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16109         field.
16110         * rs6000-tdep.c: Include reggroups.h.
16111         (IS_V_ALIAS_PSEUDOREG): Define.
16112         (rs6000_register_name): Return names for the "vX" aliases.
16113         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16114         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
16115         aliases.  Call default_register_reggroup_p for all other
16116         pseudo-registers.
16117         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16118         New functions.
16119         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16120         Handle "vX" aliases.
16121         (v_alias_pseudo_register_collect): New function.
16122         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16123         (rs6000_gdbarch_init): Initialize "vX" aliases as
16124         pseudo-registers.  Restore registration of
16125         rs6000_pseudo_register_reggroup_p with
16126         set_tdesc_pseudo_register_reggroup_p.
16127
16128 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16129
16130         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16131         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16132         set_gdbarch_num_pseudo_regs.
16133
16134 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16135
16136         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16137         Remove arg prefixname, add do_set and do_show.
16138         Add member functions set_list and show_list.
16139         * cli/cli-style.c (class cli_style_option): Update accordingly.
16140         (style_set_list): Move to file scope.
16141         (style_show_list): Likewise.
16142         (set_style): Call help_list.
16143         (show_style): Call cmd_show_list.
16144         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16145         Update to use the new macro.
16146
16147 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16148
16149         * ada-lang.c (_initialize_ada_language): Expand the help text
16150         for the "catch exception" command.
16151
16152 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16153
16154         * symtab.c (matching_obj_sections): Initialize obj,
16155         declare it closer to its usage.
16156
16157 2019-01-10  Tom Tromey  <tom@tromey.com>
16158
16159         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16160         (basic_inf_threads_range): Remove.
16161         (inf_threads_range, inf_non_exited_threads_range)
16162         (safe_inf_threads_range): Use next_adapter.
16163
16164 2019-01-10  Keith Seitz  <keiths@redhat.com>
16165
16166         PR gdb/23712
16167         PR symtab/23010
16168         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16169         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16170
16171 2019-01-10  Keith Seitz  <keiths@redhat.com>
16172
16173         PR gdb/23712
16174         PR symtab/23010
16175         * dictionary.c (pending_to_vector): Remove.
16176         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16177         Remove _1 suffix, replacing functions of the same name.  Update
16178         all callers.
16179         (dict_create_hashed, dict_create_hashed_expandable)
16180         (dict_create_linear, dict_create_linear_expandable, dict_free)
16181         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16182         Make functions static.
16183
16184 2019-01-10  Keith Seitz  <keiths@redhat.com>
16185
16186         PR gdb/23712
16187         PR symtab/23010
16188         * dictionary.h (struct dictionary): Replace declaration with
16189         multidictionary.
16190         (dict_create_hashed, dict_create_hashed_expandable)
16191         (dict_create_linear, dict_create_linear_expandable)
16192         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16193         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16194         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16195         taking multidictionary argument.
16196         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16197         * block.h (struct block) <dict>: Change to multidictionary
16198         and rename `multidict'.
16199         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16200         symmisc.c: Update all dictionary references to multidictionary.
16201
16202 2019-01-10  Keith Seitz  <keiths@redhat.com>
16203
16204         PR gdb/23712
16205         PR symtab/23010
16206         * dictionary.c: Include unordered_map.
16207         (pending_to_vector): New function.
16208         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16209         Rewrite the non-"_1" functions to take vector instead
16210         of linked list.
16211         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16212         "new" _1 versions of the same name.
16213         (multidictionary): Define.
16214         (std::hash<enum language): New definition.
16215         (collate_pending_symbols_by_language, mdict_create_hashed)
16216         (mdict_create_hashed_expandable, mdict_create_linear)
16217         (mdict_create_linear_expandable, mdict_free)
16218         (find_language_dictionary, create_new_language_dictionary)
16219         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16220         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16221         (mdict_size, mdict_empty): New functions.
16222         * dictionary.h (mdict_iterator): Define.
16223
16224 2019-01-10  Pedro Alves  <palves@redhat.com>
16225
16226         * breakpoint.c (read_uploaded_action)
16227         (create_tracepoint_from_upload): Adjust to use
16228         gdb::unique_xmalloc_ptr.
16229         * ctf.c (ctf_write_uploaded_tp):
16230         (SET_ARRAY_FIELD): Use emplace_back.
16231         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16232         * tracefile-tfile.c (tfile_write_uploaded_tp):
16233         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16234         gdb::unique_xmalloc_ptr.
16235         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16236         at_string, cond_string, cmd_strings>: Replace char pointers
16237         with gdb::unique_xmalloc_ptr.
16238
16239 2019-01-10  Pedro Alves  <palves@redhat.com>
16240
16241         * solib-target.c (library_list_start_library): Don't xstrdup name.
16242
16243 2019-01-10  Pedro Alves  <palves@redhat.com>
16244
16245         * mdebugread.c (parse_partial_symbols): Use
16246         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16247
16248 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16249
16250         * linux-fork.c (scoped_switch_fork_info)
16251         <~scoped_switch_fork_info>: Fix incorrect variable name.
16252
16253 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16254
16255         * linux-fork.c (scoped_switch_fork_info)
16256         <scoped_switch_fork_info>: Make explicit.
16257         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16258
16259 2019-01-10  Tom Tromey  <tom@tromey.com>
16260
16261         * objfiles.h (objfile::reset_psymtabs): Update.
16262         * objfiles.c (objfile::objfile): Update.
16263         * psymtab.h (psymtab_storage::obstack): Update.
16264         (psymtab_storage::m_obstack): Use gdb::optional.
16265         (class psymtab_storage): Update comment.  Remove objfile
16266         parameter.
16267         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16268
16269 2019-01-10  Tom Tromey  <tom@tromey.com>
16270
16271         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16272         <free_psymtabs>: Now private.
16273         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16274         (allocate_psymtab): Use new method.
16275
16276 2019-01-10  Tom Tromey  <tom@tromey.com>
16277
16278         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16279         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16280         * mdebugread.c (parse_partial_symbols): Use
16281         allocate_dependencies.
16282         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16283         allocate_dependencies.
16284         (process_psymtab_comp_unit_reader)
16285         (build_type_psymtab_dependencies): Likewise.
16286         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16287
16288 2019-01-10  Tom Tromey  <tom@tromey.com>
16289
16290         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16291         PSYMBOL_SET_LANGUAGE.
16292         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16293
16294 2019-01-10  Tom Tromey  <tom@tromey.com>
16295
16296         * psymtab.h (psymtab_storage::obstack): New method.
16297         <m_obstack>: Rename from obstack; now private.
16298         * psymtab.c (psymtab_storage): Update.
16299         * dwarf2read.c (create_addrmap_from_index)
16300         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16301         Update.
16302
16303 2019-01-10  Tom Tromey  <tom@tromey.com>
16304
16305         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16306         * objfiles.h (objfile::reset_psymtabs): New method.
16307
16308 2019-01-10  Tom Tromey  <tom@tromey.com>
16309
16310         * symmisc.c (print_symbol_bcache_statistics): Update.
16311         (print_objfile_statistics): Update.
16312         * symfile.c (reread_symbols): Update.
16313         * psymtab.h (class psymtab_storage): New.
16314         * psymtab.c (psymtab_storage): New constructor.
16315         (~psymtab_storage): New destructor.
16316         (require_partial_symbols): Update.
16317         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16318         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16319         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16320         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16321         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16322         (start_psymtab_common, end_psymtab_common)
16323         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16324         (allocate_psymtab): Update.
16325         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16326         Update.
16327         (dump_psymtab_addrmap, maintenance_print_psymbols)
16328         (maintenance_check_psymtabs): Update.
16329         (class objfile_psymtabs): Move to objfiles.h.
16330         * psympriv.h (discard_psymtab): Now inline.
16331         (psymtab_discarder::psymtab_discarder): Update.
16332         (psymtab_discarder::~psymtab_discarder): Update.
16333         (ALL_OBJFILE_PSYMTABS): Rewrite.
16334         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16335         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16336         Remove fields.
16337         <partial_symtabs>: New field.
16338         (class objfile_psymtabs): Move from psymtab.h.  Update.
16339         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16340         psymbol_cache.
16341         (objfile::~objfile): Don't destroy psymbol_cache.
16342         * mdebugread.c (parse_partial_symbols): Update.
16343         * dwarf2read.c (create_addrmap_from_index)
16344         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16345         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16346         (add_partial_subprogram, dwarf2_ranges_read): Update.
16347         * dwarf-index-write.c (write_address_map)
16348         (write_one_signatured_type, recursively_write_psymbols)
16349         (class debug_names, class debug_names, write_psymtabs_to_index):
16350         Update.
16351
16352 2019-01-10  Tom Tromey  <tom@tromey.com>
16353
16354         * symtab.h (SYMBOL_SET_NAMES): Update.
16355         (symbol_set_names): Update.
16356         (MSYMBOL_SET_NAMES): Update.
16357         * symtab.c (symbol_set_names): Change argument to be an
16358         objfile_per_bfd_storage.
16359         * psymtab.c (add_psymbol_to_bcache): Update.
16360         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16361
16362 2019-01-10  Tom Tromey  <tom@tromey.com>
16363
16364         * symtab.c (create_demangled_names_hash): Change argument to be an
16365         objfile_per_bfd_storage.
16366         (symbol_set_names): Update.
16367
16368 2019-01-10  Tom Tromey  <tom@tromey.com>
16369
16370         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16371         init_psymbol_list.
16372         * psymtab.c (init_psymbol_list): Do nothing if already called.
16373         * psympriv.h (init_psymbol_list): Add comment.
16374         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16375         init_psymbol_list.
16376         * dbxread.c (dbx_symfile_read): Unconditionally call
16377         init_psymbol_list.
16378
16379 2019-01-10  Tom Tromey  <tom@tromey.com>
16380
16381         * xcoffread.c (scan_xcoff_symtab): Update.
16382         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16383         "where".
16384         * mdebugread.c (parse_partial_symbols)
16385         (handle_psymbol_enumerators): Update.
16386         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16387         * dbxread.c (read_dbx_symtab): Update.
16388         * psympriv.h (psymbol_placement): New enum.
16389         (add_psymbol_to_list): Update.
16390
16391 2019-01-10  Tom Tromey  <tom@tromey.com>
16392
16393         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16394         static_psymbols parameters.
16395         (scan_xcoff_symtab): Update.
16396         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16397         static_psymbols parameters.
16398         * psympriv.h (start_psymtab_common): Update.
16399         * mdebugread.c (parse_partial_symbols): Update.
16400         * dwarf2read.c (create_partial_symtab): Update.
16401         * dbxread.c (read_dbx_symtab): Update.
16402         (start_psymtab): Remove global_psymbols and static_psymbols
16403         parameters.
16404
16405 2019-01-10  Tom Tromey  <tom@tromey.com>
16406
16407         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16408         * psymtab.c (allocate_psymtab): Add comment.
16409         * psympriv.h (allocate_psymtab): Add comment.
16410         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16411         initializations.
16412         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16413
16414 2019-01-10  Tom Tromey  <tom@tromey.com>
16415
16416         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16417         Don't declare.
16418         * mipsread.c: Include mdebugread.h.
16419         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16420         Declare.
16421         * elfread.c: Include mdebugread.h.
16422
16423 2019-01-09  Tom Tromey  <tom@tromey.com>
16424
16425         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16426         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16427         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16428         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16429         (psym_lookup_symbol, psym_find_last_source_symtab)
16430         (psym_forget_cached_source_info, psym_print_stats)
16431         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16432         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16433         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16434         (psym_find_compunit_symtab_by_address)
16435         (maintenance_print_psymbols, maintenance_info_psymtabs)
16436         (maintenance_check_psymtabs): Use ranged for.
16437         * psymtab.h (class objfile_psymtabs): New.
16438         (require_partial_symbols): Return objfile_psymtabs.
16439         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16440
16441 2019-01-09  Tom Tromey  <tom@tromey.com>
16442
16443         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16444         (find_pc_mapped_section, list_overlays_command)
16445         (map_overlay_command, unmap_overlay_command)
16446         (simple_overlay_update): Use all_objfiles.
16447         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16448         * printcmd.c (info_symbol_command): Use all_objfiles.
16449         * objfiles.h (ALL_OBJSECTIONS): Remove.
16450         * maint.c (maintenance_translate_address): Use all_objfiles.
16451         * gcore.c (gcore_create_callback): Use all_objfiles.
16452         (objfile_find_memory_regions): Likewise.
16453
16454 2019-01-09  Tom Tromey  <tom@tromey.com>
16455
16456         * symtab.c (find_line_symtab, info_sources_command)
16457         (make_source_files_completion_list): Use objfile_compunits.
16458         * source.c (select_source_symtab): Use objfile_compunits.
16459         * objfiles.h (struct objfile): Update comment.
16460         (ALL_OBJFILES): Remove.
16461         (ALL_FILETABS): Remove.
16462         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16463         objfile_compunits.
16464
16465 2019-01-09  Tom Tromey  <tom@tromey.com>
16466
16467         * symmisc.c (print_objfile_statistics, dump_objfile)
16468         (maintenance_print_symbols): Use compunit_filetabs.
16469         * source.c (forget_cached_source_info_for_objfile): Use
16470         compunit_filetabs.
16471         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16472         (ALL_FILETABS): Use compunit_filetabs.
16473         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16474         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16475
16476 2019-01-09  Tom Tromey  <tom@tromey.com>
16477
16478         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16479         (compunit_filetabs): New.
16480         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16481         compunit_filetabs.
16482         (info_sources_command, make_source_files_completion_list): Remove
16483         declaration.
16484         * symmisc.c (print_objfile_statistics, dump_objfile)
16485         (maintenance_print_symbols): Remove declaration.
16486         (maintenance_info_symtabs): Use compunit_filetabs.
16487         (maintenance_info_line_tables): Likewise.
16488         * source.c (select_source_symtab): Change local variable name.
16489         (forget_cached_source_info_for_objfile): Remove declaration.
16490         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16491         * objfiles.c (objfile_relocate1): Remove declaration.
16492         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16493         declaration.
16494         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16495         * coffread.c (coff_symtab_read): Remove declaration.
16496         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16497         compunit_filetabs.
16498
16499 2019-01-09  Tom Tromey  <tom@tromey.com>
16500
16501         * symtab.c (lookup_objfile_from_block)
16502         (find_pc_sect_compunit_symtab, search_symbols)
16503         (default_collect_symbol_completion_matches_break_on): Use
16504         objfile_compunits.
16505         * objfiles.h (ALL_COMPUNITS): Remove.
16506         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16507         * cp-support.c (add_symbol_overload_list_qualified): Use
16508         objfile_compunits.
16509         * ada-lang.c (ada_collect_symbol_completion_matches)
16510         (ada_add_global_exceptions): Use objfile_compunits.
16511
16512 2019-01-09  Tom Tromey  <tom@tromey.com>
16513
16514         * source.c (select_source_symtab)
16515         (forget_cached_source_info_for_objfile): Remove declaration.
16516         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16517         declaration.
16518         * maint.c (count_symtabs_and_blocks): Remove declaration.
16519         * cp-support.c (add_symbol_overload_list_qualified): Remove
16520         declaration.
16521         * coffread.c (coff_symtab_read): Remove declaration.
16522         * symtab.c (lookup_symbol_in_objfile_symtabs)
16523         (basic_lookup_transparent_type_1): Use objfile_compunits.
16524         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16525         (info_sources_command, search_symbols)
16526         (default_collect_symbol_completion_matches_break_on)
16527         (make_source_files_completion_list): Remove declaration.
16528         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16529         (ada_collect_symbol_completion_matches)
16530         (ada_add_global_exceptions): Remove declaration.
16531         * linespec.c (iterate_over_all_matching_symtabs): Use
16532         objfile_compunits.
16533         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16534         (class objfile_compunits): New.
16535         (ALL_COMPUNITS): Use objfile_compunits.
16536         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16537         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16538         objfile_compunits.
16539         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16540
16541 2019-01-09  Tom Tromey  <tom@tromey.com>
16542
16543         * symtab.c (search_symbols)
16544         (default_collect_symbol_completion_matches_break_on): Use
16545         objfile_msymbols.
16546         * ada-lang.c (ada_lookup_simple_minsym)
16547         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16548         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16549         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16550         objfile_msymbols.
16551         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16552         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16553         * objc-lang.c (find_methods): Use objfile_msymbols.
16554         (info_selectors_command, info_classes_command): Likewise.
16555         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16556         * objfiles.h (class objfile_msymbols): New.
16557         (ALL_OBJFILE_MSYMBOLS): Remove.
16558         (ALL_MSYMBOLS): Remove.
16559
16560 2019-01-09  Tom Tromey  <tom@tromey.com>
16561
16562         * common/next-iterator.h (next_adapter): Add Iterator template
16563         parameter.
16564         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16565         (class all_objfiles_safe): New.
16566         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16567         * objfiles.c (put_objfile_before): Update comment.
16568         (add_separate_debug_objfile): Likewise.
16569         (free_all_objfiles): Use all_objfiles_safe.
16570         (objfile_purge_solibs): Likewise.
16571
16572 2019-01-09  Tom Tromey  <tom@tromey.com>
16573
16574         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16575         (expand_symtab_containing_pc, lookup_static_symbol)
16576         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16577         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16578         all_objfiles.
16579         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16580         * breakpoint.c (create_overlay_event_breakpoint)
16581         (create_longjmp_master_breakpoint)
16582         (create_std_terminate_master_breakpoint)
16583         (create_exception_master_breakpoint): Use all_objfiles.
16584         * linux-thread-db.c (try_thread_db_load_from_pdir)
16585         (has_libpthread): Use all_objfiles.
16586         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16587         * linespec.c (iterate_over_all_matching_symtabs)
16588         (search_minsyms_for_name): Use all_objfiles.
16589         * maint.c (maintenance_info_sections): Use all_objfiles.
16590         * main.c (captured_main_1): Use all_objfiles.
16591         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16592         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16593         * guile/scm-pretty-print.c
16594         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16595         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16596         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16597         (maintenance_print_msymbols): Use all_objfiles.
16598         * source.c (select_source_symtab): Use all_objfiles.
16599         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16600         * symfile.c (remove_symbol_file_command)
16601         (expand_symtabs_matching, map_symbol_filenames): Use
16602         all_objfiles.
16603         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16604         all_objfiles.
16605         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16606         * objc-lang.c (find_methods): Use all_objfiles.
16607         * objfiles.c (have_partial_symbols, have_full_symbols)
16608         (have_minimal_symbols, qsort_cmp)
16609         (default_iterate_over_objfiles_in_search_order): Use
16610         all_objfiles.
16611         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16612         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16613         (maintenance_check_psymtabs): Use all_objfiles.
16614         (ALL_PSYMTABS): Remove.
16615         * compile/compile-object-run.c (do_module_cleanup): Use
16616         all_objfiles.
16617         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16618         * cp-support.c (add_symbol_overload_list_qualified): Use
16619         all_objfiles.
16620         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16621         Use all_objfiles.
16622         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16623         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16624         all_objfiles.
16625         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16626         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16627         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16628         Uses all_objfiles.
16629         * solib.c (solib_read_symbols): Use all_objfiles
16630
16631 2019-01-09  Tom Tromey  <tom@tromey.com>
16632
16633         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16634         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16635         all_objfiles.
16636         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16637         * symmisc.c (print_symbol_bcache_statistics)
16638         (print_objfile_statistics, maintenance_print_objfiles)
16639         (maintenance_info_symtabs, maintenance_check_symtabs)
16640         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16641         all_objfiles.
16642         * source.c (forget_cached_source_info): Use all_objfiles.
16643         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16644         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16645         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16646         * objfiles.c (update_section_map): Use all_objfiles.
16647         (shared_objfile_contains_address_p): Likewise.
16648         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16649         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16650
16651 2019-01-09  Tom Tromey  <tom@tromey.com>
16652
16653         * common/next-iterator.h: New file.
16654         * objfiles.h (class all_objfiles): New.
16655         (struct objfile_iterator): New.
16656
16657 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16658
16659         * NEWS: Move the description of the changed "frame", "select-frame",
16660          and "info frame" commands to the Changed commands section.
16661
16662 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16663
16664         * gdbtypes.c (check_stub_method_group): Remove handling of old
16665         mangling schemes.
16666         * linespec.c (find_methods): Likewise.
16667         * stabsread.c (read_member_functions): Likewise.
16668         * valops.c (search_struct_method): Likewise.
16669         (value_struct_elt_for_reference): Likewise.
16670         * NEWS: Mention this change.
16671
16672 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16673
16674         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16675         print_source_lines.
16676         * source.c (print_source_lines_base): Update line number check.
16677         (print_source_lines): New function.
16678         (source_lines_range::source_lines_range): New function.
16679         * source.h (class source_lines_range): New class.
16680         (print_source_lines): New declaration.
16681
16682 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16683
16684         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16685
16686 2019-01-08  Tom Tromey  <tom@tromey.com>
16687             Simon Marchi  <simon.marchi@ericsson.com>
16688
16689         PR gdb/24060
16690         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16691         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16692         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16693         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16694         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16695         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16696
16697 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16698
16699         * source.c (select_source_symtab): Move header comment to
16700         declaration in source.h.
16701         (forget_cached_source_info_for_objfile): Likewise.
16702         (forget_cached_source_info): Likewise.
16703         (identify_source_line): Likewise.
16704         * source.h (identify_source_line): Move declaration from symtab.h
16705         and add comment from source.c
16706         (print_source_lines): Likewise.
16707         (forget_cached_source_info_for_objfile): Likewise.
16708         (forget_cached_source_info): Likewise.
16709         (select_source_symtab): Likewise.
16710         (enum print_source_lines_flag): Move definition from symtab.h.
16711         * symtab.h (identify_source_line): Move declaration to source.h.
16712         (print_source_lines): Likewise.
16713         (forget_cached_source_info_for_objfile): Likewise.
16714         (forget_cached_source_info): Likewise.
16715         (select_source_symtab): Likewise.
16716         (enum print_source_lines_flag): Move definition to source.h.
16717         * tui/tui-hooks.c: Add 'source.h' include.
16718
16719 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16720
16721         * source.c (print_source_lines_base): Handle requests to print
16722         reverse line number sequences, and guard against empty lines
16723         string.
16724
16725 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16726
16727         * source.c (print_source_lines_base): Fix skip of '\r' if next
16728         character is '\n'.
16729
16730 2019-01-06  Tom Tromey  <tom@tromey.com>
16731
16732         * c-exp.y (struct c_parse_state) <macro_original_text,
16733         expansion_obstack>: New member.
16734         (macro_original_text, expansion_obstack): Remove globals.
16735         (scan_macro_expansion, scanning_macro_expansion)
16736         (finished_macro_expansion): Update.
16737         (scan_macro_cleanup): Remove.
16738         (yylex, c_parse): Update.
16739
16740 2019-01-06  Tom Tromey  <tom@tromey.com>
16741
16742         * c-exp.y (struct c_parse_state) <strings>: New member.
16743         (operator_stoken): Update.
16744
16745 2019-01-06  Tom Tromey  <tom@tromey.com>
16746
16747         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16748         (union type_stack_elt) <typelist_val>: Now a pointer to
16749         std::vector.
16750         (type_stack_cleanup): Don't declare.
16751         (push_typelist): Update.
16752         * parse.c (pop_typelist): Return a std::vector.
16753         (push_typelist): Take a std::vector.
16754         (follow_types): Update.  Do not free args.
16755         (type_stack_cleanup): Remove.
16756         * c-exp.y (struct c_parse_state): New.
16757         (cpstate): New global.
16758         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16759         (nonempty_typelist): Update.
16760         (func_mod): Create a new vector.
16761         (c_parse): Create a c_parse_state.
16762         (check_parameter_typelist): Do not delete params.
16763         (function_method): Update.  Do not delete type_list.
16764
16765 2019-01-06  Tom Tromey  <tom@tromey.com>
16766
16767         PR gdb/28155:
16768         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16769         check_typedef.
16770         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16771         (print_return_value): Likewise.
16772
16773 2019-01-05  Tom Tromey  <tom@tromey.com>
16774
16775         * contrib/cleanup_check.py: Remove.
16776         * contrib/gcc-with-excheck: Remove.
16777         * contrib/exsummary.py: Remove.
16778         * contrib/excheck.py: Remove.
16779
16780 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16781
16782         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16783         NULL. Initialize tpprev to NULL instead of assigning it
16784         to NULL on the next statement.
16785         * windows-nat.c (windows_delete_thread): Remove check for
16786         main_thread_id before printing thread exit notifications.
16787         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16788         Remove thread ID check against main_thread_id.
16789         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16790         windows_delete_thread.
16791         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16792
16793 2019-01-04  Tom Tromey  <tom@tromey.com>
16794
16795         * compile/compile.c (_initialize_compile): Use upper case for
16796         metasyntactic variables.
16797         * symmisc.c (_initialize_symmisc): Use upper case for
16798         metasyntactic variables.
16799         * psymtab.c (_initialize_psymtab): Use upper case for
16800         metasyntactic variables.
16801         * demangle.c (demangle_command): Use upper case for metasyntactic
16802         variables.
16803         (_initialize_demangler): Likewise.
16804         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16805         variables.
16806
16807 2019-01-03  Tom Tromey  <tom@tromey.com>
16808
16809         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16810
16811 2019-01-03  Tom Tromey  <tom@tromey.com>
16812
16813         * python/py-symtab.c (salpy_str): Update.
16814         (struct salpy_sal_object) <symtab>: Now a PyObject.
16815         (salpy_dealloc): Update.
16816         (del_objfile_sal): Use gdbpy_ref.
16817
16818 2019-01-03  Tom Tromey  <tom@tromey.com>
16819
16820         * python/py-type.c (convert_field): Use new_reference.  Return
16821         gdbpy_ref.
16822         (make_fielditem): Return gdbpy_ref.
16823         (typy_fields): Update.
16824         (typy_getitem): Update.
16825         (field_name): Return gdbpy_ref.  Use new_reference.
16826         (typy_iterator_iternext): Update.
16827
16828 2019-01-03  Tom Tromey  <tom@tromey.com>
16829
16830         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16831
16832 2019-01-03  Tom Tromey  <tom@tromey.com>
16833
16834         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16835         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16836         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16837         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16838         (pspy_set_type_printers): Likewise.
16839         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16840         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16841         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16842         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16843         (objfpy_set_type_printers): Likewise.
16844
16845 2019-01-03  Tom Tromey  <tom@tromey.com>
16846
16847         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16848         (gdbpy_print_stack): Use gdbpy_err_fetch.
16849         * python/python-internal.h (class gdbpy_err_fetch): New class.
16850         (class gdbpy_enter) <m_error_type, m_error_value,
16851         m_error_traceback>: Remove.
16852         <m_error>: New member.
16853         (gdbpy_exception_to_string): Don't declare.
16854         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16855         * python/py-value.c (convert_value_from_python): Use
16856         gdbpy_err_fetch.
16857         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16858         gdbpy_exception_to_string.
16859         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16860         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16861         gdbpy_err_fetch.
16862
16863 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16864
16865         * linux-nat.c (delete_lwp_cleanup): Delete.
16866         (struct lwp_deleter): New struct.
16867         (lwp_info_up): New typedef.
16868         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16869         lwp_info_up.
16870
16871 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16872
16873         * linux-fork.c (class scoped_switch_fork_info): New class.
16874         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16875
16876 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16877
16878         * valops.c (find_overload_match): Remove use of null_cleanup, and
16879         calls to do_cleanups.
16880
16881 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16882
16883         * compile/compile-cplus-types.c
16884         (compile_cplus_instance::decl_name): Handle changes to
16885         cp_func_name.
16886         * cp-support.c (cp_func_name): Update header comment, update
16887         return type.
16888         * cp-support.h (cp_func_name): Update return type in declaration.
16889         * valops.c (find_overload_match): Move temp_func local to top
16890         level of function and change its type.  Use temp_func to hold and
16891         delete temporary string obtained from cp_func_name.
16892
16893 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16894
16895         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16896         gdb::char_vector, remove cleanup, and update uses of `msg`.
16897
16898 2019-01-03  Jim Wilson  <jimw@sifive.com>
16899
16900         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16901
16902 2019-01-02  Tom Tromey  <tom@tromey.com>
16903
16904         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16905         (tdesc_parse_xml): Remove cleanups.
16906         * target-descriptions.h (make_cleanup_free_target_description):
16907         Don't declare.
16908         (target_desc_deleter): New struct.
16909         (target_desc_up): New typedef.
16910         * target-descriptions.c (target_desc_deleter::operator()): Rename
16911         from free_target_description.
16912         (make_cleanup_free_target_description): Remove.
16913
16914 2019-01-02  Tom Tromey  <tom@tromey.com>
16915
16916         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16917         constructor, destructor.
16918         (linespec_parser): Remove typedef.
16919         (~linespec_parser): Rename from linespec_parser_delete.
16920         (linespec_lex_to_end, linespec_complete_label)
16921         (linespec_complete): Update.
16922         (decode_line_full): Remove cleanups.
16923         (decode_line_1): Update.
16924
16925 2019-01-02  Tom Tromey  <tom@tromey.com>
16926
16927         * python/python-internal.h (inferior_to_inferior_object): Change
16928         return type.
16929         * python/py-exitedevent.c (create_exited_event_object): Update.
16930         * python/py-inferior.c (inferior_to_inferior_object): Return
16931         gdbpy_ref.
16932         (python_new_inferior, python_inferior_deleted)
16933         (thread_to_thread_object, delete_thread_object)
16934         (build_inferior_list, gdbpy_selected_inferior): Update.
16935         * python/py-infthread.c (create_thread_object): Update.  Also fail
16936         if inferior_to_inferior_object fails.
16937
16938 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16939
16940         * inferior.h (class inferior) <displaced_step_state>: New field.
16941         * infrun.h (struct displaced_step_state): Move here from
16942         infrun.c.  Initialize fields, add constructor.
16943         <inf>: Remove field.
16944         <reset>: New method.
16945         * infrun.c (struct displaced_step_inferior_state): Move to
16946         infrun.h.
16947         (displaced_step_inferior_states): Remove.
16948         (get_displaced_stepping_state): Adust.
16949         (displaced_step_in_progress_any_inferior): Adjust.
16950         (displaced_step_in_progress_thread): Adjust.
16951         (displaced_step_in_progress): Adjust.
16952         (add_displaced_stepping_state): Remove.
16953         (get_displaced_step_closure_by_addr): Adjust.
16954         (remove_displaced_stepping_state): Remove.
16955         (infrun_inferior_exit): Call displaced_step_state.reset.
16956         (use_displaced_stepping): Don't check for NULL.
16957         (displaced_step_prepare_throw): Call
16958         get_displaced_stepping_state.
16959         (displaced_step_fixup): Don't check for NULL.
16960         (prepare_for_detach): Don't check for NULL.
16961
16962 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16963
16964         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16965          in case of call that did not complete.
16966
16967 2019-01-02  Andrey Utkin  <autkin@undo.io>
16968
16969         * symfile.c (find_separate_debug_file): Fix search of debug files for
16970         remote debuggee.
16971
16972 2019-01-02  Tom Tromey  <tom@tromey.com>
16973
16974         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16975         indentation.
16976         * python/py-frame.c (frapy_older): Remove cast.
16977         (frapy_newer): Likewise.
16978         * python/py-breakpoint.c (local_setattro): Remove cast.
16979         * python/py-arch.c (archpy_name): Remove local variable.
16980         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16981
16982 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16983
16984         * unittests/basic_string_view/element_access/char/empty.cc:
16985         Fix year range in copyright header.
16986
16987 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16988
16989         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16990         Delete.
16991         <operator==>: Update with for removed field.
16992         <hash>: Likewise.
16993         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16994         <isa_features>: ...this.
16995         <abi_features>: New field.
16996         (riscv_isa_flen): Update comment.
16997         (riscv_abi_xlen): New declaration.
16998         (riscv_abi_flen): New declaration.
16999         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17000         isa_features.
17001         (riscv_abi_xlen): New function.
17002         (riscv_isa_flen): Update to get answer from isa_features.
17003         (riscv_abi_flen): New function.
17004         (riscv_has_fp_abi): Update to get answer from abi_features.
17005         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17006         xlen and flen.
17007         (riscv_call_info) <xlen, flen>: Update comment.
17008         (riscv_call_arg_struct): Remove invalid assertions
17009         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17010         is removed.
17011         (riscv_gdbarch_init): Gather isa features and abi features
17012         separately, ensure both match on the gdbarch when reusing an old
17013         gdbarch.  Relax an error check to allow 32-bit abi float to run on
17014         a target with 64-bit float hardware.
17015
17016 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17017
17018         * source.c (search_command_helper): Stop reverse search
17019         when line 1 has been searched.
17020
17021 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17022
17023         * record-full.c (record_full_base_target::close): Rewrite
17024         record_full_core_buf_list free logic.
17025
17026 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17027
17028         * break-catch-syscall.c (print_one_catch_syscall): xfree
17029         the last text.
17030
17031 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17032
17033         * top.c (print_gdb_version): Update Copyright year in version
17034         message.
17035
17036 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17037
17038         Update copyright year range in all GDB files.
17039
17040 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
17041
17042         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
17043
17044 For older changes see ChangeLog-2018.
17045 \f
17046 Local Variables:
17047 mode: change-log
17048 left-margin: 8
17049 fill-column: 74
17050 version-control: never
17051 coding: utf-8
17052 End:
17053